* xfns.c: Don't assume strlen fits in int.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xfns.c: Don't assume strlen fits in int.
4 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5
6 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7 not unsigned long, as we prefer signed integers. All callers changed.
8 Detect integer overflow in repeat count.
9 (message_dolog): Don't assume print length fits in 39 bytes.
10 (display_mode_element): Don't assume strlen fits in int.
11
12 * termcap.c: Don't assume sizes fit in int and never overflow.
13 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
14 (gobble_line): Check for size-calculation overflow.
15
16 * minibuf.c (Fread_buffer):
17 * lread.c (intern, intern_c_string):
18 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
19 Don't assume string length fits in int.
20
21 * keyboard.c (parse_tool_bar_item):
22 * gtkutil.c (style_changed_cb): Avoid need for strlen.
23
24 * font.c: Don't assume string length fits in int.
25 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
26 Use ptrdiff_t, not int.
27 (font_intern_prop): Don't assume string length fits in int.
28 Don't assume integer property fits in fixnum.
29 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
30
31 * filelock.c: Fix some buffer overrun and integer overflow issues.
32 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
33 Reformulate so as not to need the command string.
34 Invoke gzip -cd rather than gunzip, as it's more portable.
35 (lock_info_type, lock_file_1, lock_file):
36 Don't assume pid_t and time_t fit in unsigned long.
37 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
38 (current_lock_owner): Prefer signed type for sizes.
39 Use memcpy, not strncpy, where memcpy is what is really wanted.
40 Don't assume (via atoi) that time_t and pid_t fit in int.
41 Check for time_t and/or pid_t out of range, e.g., via a network share.
42 Don't alloca where an auto var works fine.
43
44 * fileio.c: Fix some integer overflow issues.
45 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
46 Don't assume string length fits in int.
47 (directory_file_name): Don't assume string length fits in long.
48 (make_temp_name): Don't assume pid fits in int, or that its print
49 length is less than 20.
50
51 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
52
53 * coding.c (make_subsidiaries): Don't assume string length fits in int.
54
55 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
56
57 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
58 We prefer signed integers, even for size calculations.
59
60 * emacs.c: Don't assume string length fits in 'int'.
61 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
62 (main): Don't invoke strlen when not needed.
63
64 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
65 (XD_DEBUG_MESSAGE): Don't waste a byte.
66
67 * callproc.c (getenv_internal_1, getenv_internal)
68 (Fgetenv_internal):
69 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
70
71 * lread.c (invalid_syntax): Omit length argument.
72 All uses changed. This doesn't fix a bug, but it simplifies the
73 code away from its former Hollerith-constant appearance, and it's
74 one less 'int' to worry about when looking at integer-overflow issues.
75 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
76
77 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
78 This didn't break anything, but it didn't help either.
79 It's confusing to put a bogus integer in a place where the actual
80 value does not matter.
81 (LIST_END_P): Remove unused macro and its bogus comment.
82 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
83
84 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
85 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
86 implementation.
87 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
88 We prefer signed types, and the value cannot exceed the EMACS_INT
89 range anyway (because otherwise the length would not be representable).
90 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
91 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
92 This avoids a GCC warning when WIDE_EMACS_INT.
93
94 * indent.c (sane_tab_width): New function.
95 (current_column, scan_for_column, Findent_to, position_indentation)
96 (compute_motion): Use it. This is just for clarity.
97 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
98
99 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
100
101 * lisp.h (lint_assume): New macro.
102 * composite.c (composition_gstring_put_cache):
103 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
104
105 * editfns.c, insdel.c:
106 Omit unnecessary forward decls, to simplify future changes.
107
108 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
109
110 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
111
112 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
113 Use much-faster test for byte-length change.
114 Don't assume string byte-length fits in 'int'.
115 Check that character arg fits in 'int'.
116 (mapcar1): Declare byte as byte, for clarity.
117
118 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
119
120 * fns.c (concat): Catch string overflow earlier.
121 Do not rely on integer wraparound.
122
123 * dispextern.h (struct it.overlay_strings_charpos)
124 (struct it.selective): Now EMACS_INT, not int.
125 * xdisp.c (forward_to_next_line_start)
126 (back_to_previous_visible_line_start)
127 (reseat_at_next_visible_line_start, next_element_from_buffer):
128 Don't arbitrarily truncate the value of 'selective' to int.
129
130 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
131
132 * composite.c: Don't truncate sizes to 'int'.
133 (composition_gstring_p, composition_reseat_it)
134 (composition_adjust_point): Use EMACS_INT, not int.
135 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
136 not EMACS_UINT, for indexes.
137
138 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
139
140 * buffer.c: Include <verify.h>.
141 (struct sortvec.priority, struct sortstr.priority):
142 Now EMACS_INT, not int.
143 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
144 (struct sortstr.size, record_overlay_string)
145 (struct sortstrlist.size, struct sortlist.used):
146 Don't truncate size to int.
147 (record_overlay_string): Check for size-calculation overflow.
148 (init_buffer_once): Check at compile-time, not run-time.
149
150 2011-06-20 Deniz Dogan <deniz@dogan.se>
151
152 * process.c (Fset_process_buffer): Clarify return value in
153 docstring.
154
155 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
156
157 * dispnew.c (add_window_display_history): Use BVAR.
158
159 * xdisp.c (debug_method_add): Use BVAR.
160 (check_window_end, dump_glyph_matrix, dump_glyph)
161 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
162
163 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
164 Likewise.
165
166 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
167 check till after the cache is created in init_frame_faces.
168
169 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
170
171 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
172
173 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
174
175 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
176 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
177 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
178
179 Improve buffer-overflow checking (Bug#8873).
180 * fileio.c (Finsert_file_contents):
181 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
182 Remove the old (too-loose) buffer overflow checks.
183 They weren't needed, since make_gap checks for buffer overflow.
184 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
185 The old code merely checked for Emacs fixnum overflow, and relied
186 on undefined (wraparound) behavior. The new code avoids undefined
187 behavior, and also checks for ptrdiff_t and/or size_t overflow.
188
189 * editfns.c (Finsert_char): Don't dump core with very negative counts.
190 Tune. Don't use wider integers than needed. Don't use alloca.
191 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
192
193 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
194
195 * insdel.c, lisp.h (buffer_overflow): New function.
196 (insert_from_buffer_1, replace_range, replace_range_2):
197 * insdel.c (make_gap_larger):
198 * editfns.c (Finsert_char):
199 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
200
201 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
202
203 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
204
205 Integer overflow and signedness fixes (Bug#8873).
206
207 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
208 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
209
210 * fileio.c: Don't assume EMACS_INT fits in off_t.
211 (emacs_lseek): New static function.
212 (Finsert_file_contents, Fwrite_region): Use it.
213 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
214
215 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
216
217 * fns.c: Don't overflow int when computing a list length.
218 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
219 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
220 truncation on 64-bit hosts. Check for QUIT every
221 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
222 faster and is responsive enough.
223 (Flength): Report an error instead of overflowing an integer.
224 (Fsafe_length): Return a float if the value is not representable
225 as a fixnum. This shouldn't happen except in contrived situations.
226 (Fnthcdr, Fsort): Don't assume list length fits in int.
227 (Fcopy_sequence): Don't assume vector length fits in int.
228
229 * alloc.c: Check that resized vectors' lengths fit in fixnums.
230 (header_size, word_size): New constants.
231 (allocate_vectorlike): Don't check size overflow here.
232 (allocate_vector): Check it here instead, since this is the only
233 caller of allocate_vectorlike that could cause overflow.
234 Check that the new vector's length is representable as a fixnum.
235
236 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
237 The previous code was bogus. For example, next_almost_prime (32)
238 returned 39, which is undesirable as it is a multiple of 3; and
239 next_almost_prime (24) returned 25, which is a multiple of 5 so
240 why was the code bothering to check for multiples of 7?
241
242 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
243
244 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
245
246 Variadic C functions now count arguments with ptrdiff_t.
247 This partly undoes my 2011-03-30 change, which replaced int with size_t.
248 Back then I didn't know that the Emacs coding style prefers signed int.
249 Also, in the meantime I found a few more instances where arguments
250 were being counted with int, which may truncate counts on 64-bit
251 machines, or EMACS_INT, which may be unnecessarily wide.
252 * lisp.h (struct Lisp_Subr.function.aMANY)
253 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
254 Arg counts are now ptrdiff_t, not size_t.
255 All variadic functions and their callers changed accordingly.
256 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
257 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
258 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
259 * callint.c (Fcall_interactively): Check arg count for overflow,
260 to avoid potential buffer overrun. Use signed char, not 'int',
261 for 'varies' array, so that we needn't bother to check its size
262 calculation for overflow.
263 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
264 * eval.c (apply_lambda):
265 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
266 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
267 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
268
269 * callint.c (Fcall_interactively): Don't use index var as event count.
270
271 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
272 * mem-limits.h (SIZE): Remove; no longer used.
273
274 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
275
276 Remove unnecessary casts.
277 * xterm.c (x_term_init):
278 * xfns.c (x_set_border_pixel):
279 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
280 These aren't needed now that we assume ANSI C.
281
282 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
283 It's more likely to cause problems (due to unsigned overflow)
284 than to cure them.
285
286 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
287
288 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
289
290 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
291
292 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
293
294 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
295
296 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
297
298 GLYPH_CODE_FACE returns EMACS_INT, not int.
299 * dispextern.h (merge_faces):
300 * xfaces.c (merge_faces):
301 * xdisp.c (get_next_display_element, next_element_from_display_vector):
302 Don't assume EMACS_INT fits in int.
303
304 * character.h (CHAR_VALID_P): Remove unused parameter.
305 * fontset.c, lisp.h, xdisp.c: All uses changed.
306
307 * editfns.c (Ftranslate_region_internal): Omit redundant test.
308
309 * fns.c (concat): Minor tuning based on overflow analysis.
310 This doesn't fix any bugs. Use int to hold character, instead
311 of constantly refetching from Emacs object. Use XFASTINT, not
312 XINT, for value known to be a character. Don't bother comparing
313 a single byte to 0400, as it's always less.
314
315 * floatfns.c (Fexpt):
316 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
317
318 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
319 for characters.
320
321 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
322
323 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
324 Without this fix, on a 64-bit host (aset S 0 4294967386) would
325 incorrectly succeed when S was a string, because 4294967386 was
326 truncated before it was used.
327
328 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
329 Otherwise, an out-of-range integer could cause undefined behavior
330 on a 64-bit host.
331
332 * composite.c: Use int, not EMACS_INT, for characters.
333 (fill_gstring_body, composition_compute_stop_pos): Use int, not
334 EMACS_INT, for values that are known to be in character range.
335 This doesn't fix any bugs but is the usual style inside Emacs and
336 may generate better code on 32-bit machines.
337
338 Make sure a 64-bit char is never passed to ENCODE_CHAR.
339 This is for reasons similar to the recent CHAR_STRING fix.
340 * charset.c (Fencode_char): Check that character arg is actually
341 a character. Pass an int to ENCODE_CHAR.
342 * charset.h (ENCODE_CHAR): Verify that the character argument is no
343 wider than 'int', as a compile-time check to prevent future regressions
344 in this area.
345
346 * character.c (char_string): Remove unnecessary casts.
347
348 Make sure a 64-bit char is never passed to CHAR_STRING.
349 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
350 by silently ignoring the top 32 bits, allowing some values
351 that were far too large to be valid characters.
352 * character.h: Include <verify.h>.
353 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
354 arguments are no wider than unsigned, as a compile-time check
355 to prevent future regressions in this area.
356 * data.c (Faset):
357 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
358 (Fsubst_char_in_region):
359 * fns.c (concat):
360 * xdisp.c (decode_mode_spec_coding):
361 Adjust to CHAR_STRING's new requirement.
362 * editfns.c (Finsert_char, Fsubst_char_in_region):
363 * fns.c (concat): Check that character args are actually
364 characters. Without this test, these functions did the wrong
365 thing with wildly out-of-range values on 64-bit hosts.
366
367 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
368 These casts should not be needed on 32-bit hosts, either.
369 * keyboard.c (read_char):
370 * lread.c (Fload): Remove casts to unsigned.
371
372 * lisp.h (UNSIGNED_CMP): New macro.
373 This fixes comparison bugs on 64-bit hosts.
374 (ASCII_CHAR_P): Use it.
375 * casefiddle.c (casify_object):
376 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
377 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
378 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
379 * dispextern.h (FACE_FROM_ID):
380 * keyboard.c (read_char): Use UNSIGNED_CMP.
381
382 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
383 not to EMACS_INT, to avoid GCC warning.
384
385 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
386
387 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
388 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
389 isn't needed on 32-bit machines.
390
391 * buffer.c (Fgenerate_new_buffer_name):
392 Use EMACS_INT for count, not int.
393 (advance_to_char_boundary): Return EMACS_INT, not int.
394
395 * data.c (Qcompiled_function): Now static.
396
397 * window.c (window_body_lines): Now static.
398
399 * image.c (gif_load): Rename local to avoid shadowing.
400
401 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
402 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
403 * alloc.c (make_save_value): Integer argument is now of type
404 ptrdiff_t, not int.
405 (mark_object): Use ptrdiff_t, not int.
406 * lisp.h (pD): New macro.
407 * print.c (print_object): Use it.
408
409 * alloc.c: Use EMACS_INT, not int, to count objects.
410 (total_conses, total_markers, total_symbols, total_vector_size)
411 (total_free_conses, total_free_markers, total_free_symbols)
412 (total_free_floats, total_floats, total_free_intervals)
413 (total_intervals, total_strings, total_free_strings):
414 Now EMACS_INT, not int. All uses changed.
415 (Fgarbage_collect): Compute overall total using a double, so that
416 integer overflow is less likely to be a problem. Check for overflow
417 when converting back to an integer.
418 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
419 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
420 These were 'int' variables that could overflow on 64-bit hosts;
421 they were never used, so remove them instead of repairing them.
422 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
423 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
424 Previously, this ceilinged at INT_MAX, but that doesn't work on
425 64-bit machines.
426 (allocate_pseudovector): Don't use EMACS_INT when int would do.
427
428 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
429 (allocate_vectorlike): Check for ptrdiff_t overflow.
430 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
431 when a (possibly-narrower) signed value would do just as well.
432 We prefer using signed arithmetic, to avoid comparison confusion.
433
434 * alloc.c: Catch some string size overflows that we were missing.
435 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
436 for convenience in STRING_BYTES_MAX.
437 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
438 The definition here is exact; the one in lisp.h was approximate.
439 (allocate_string_data): Check for string overflow. This catches
440 some instances we weren't catching before. Also, it catches
441 size_t overflow on (unusual) hosts where SIZE_MAX <= min
442 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
443 and ptrdiff_t and EMACS_INT are both 64 bits.
444
445 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
446 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
447 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
448
449 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
450
451 * alloc.c (Fmake_string): Check for out-of-range init.
452
453 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
454
455 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
456
457 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
458
459 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
460 xg_get_default_scrollbar_width.
461
462 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
463 (int_gtk_range_get_value): Move to the scroll bar part of the file.
464 (style_changed_cb): Call update_theme_scrollbar_width and call
465 x_set_scroll_bar_default_width and xg_frame_set_char_size for
466 all frames (Bug#8505).
467 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
468 Call gtk_window_set_resizable if HAVE_GTK3.
469 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
470 and height if HAVE_GTK3 (Bug#8505).
471 (scroll_bar_width_for_theme): New variable.
472 (update_theme_scrollbar_width): New function.
473 (xg_get_default_scrollbar_width): Move code to
474 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
475 (xg_initialize): Call update_theme_scrollbar_width.
476
477 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
478
479 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
480
481 2011-06-12 Martin Rudalics <rudalics@gmx.at>
482
483 * frame.c (make_frame): Call other_buffer_safely instead of
484 other_buffer.
485
486 * window.c (temp_output_buffer_show): Call display_buffer with
487 second argument Vtemp_buffer_show_specifiers and reset latter
488 immediately after the call.
489 (Vtemp_buffer_show_specifiers): New variable.
490 (auto_window_vscroll_p, next_screen_context_lines)
491 (Vscroll_preserve_screen_position): Remove leading asterisks from
492 doc-strings.
493
494 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
495
496 Fix minor problems found by GCC 4.6.0 static checking.
497 * buffer.c (Qclone_number): Remove for now, as it's unused.
498 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
499 (record_buffer): Remove unused local.
500 * frame.c (other_visible_frames, frame_buffer_list): Now static.
501 (set_frame_buffer_list): Remove; unused.
502 * frame.h (other_visible_frames): Remove decl.
503 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
504 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
505 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
506 if HAVE_GPM.
507 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
508 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
509 Define only if HAVE_GPM.
510 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
511 (update_hints_inhibit): Remove; never set. All uses removed.
512 * widgetprv.h (emacsFrameClassRec): Remove decl.
513 * window.c (delete_deletable_window): Now returns void, since it
514 wasn't returning anything.
515 (compare_window_configurations): Remove unused locals.
516 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
517 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
518 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
519 the same widths as pointers. This follows up on the 2011-05-06 patch.
520 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
521 * xterm.h: Likewise.
522 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
523
524 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
525
526 * makefile.w32-in: Update dependencies.
527 (LISP_H): Add lib/intprops.h.
528
529 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
530
531 * image.c (gif_load): Add animation frame delay to the metadata.
532 (syms_of_image): Use DEFSYM. New symbol `delay'.
533
534 2011-06-11 Martin Rudalics <rudalics@gmx.at>
535
536 * window.c (delete_deletable_window): Re-add.
537 (Fset_window_configuration): Rewrite to handle dead buffers and
538 consequently deletable windows.
539 (window_tree, Fwindow_tree): Remove. Supply functionality in
540 window.el.
541 (compare_window_configurations): Simplify code.
542
543 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
544
545 * image.c (imagemagick_load_image): Fix type mismatch.
546 (Fimagemagick_types): Likewise.
547
548 * window.h (replace_buffer_in_windows): Declare.
549
550 2011-06-11 Martin Rudalics <rudalics@gmx.at>
551
552 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
553 Qclone_number. Remove external declaration of Qdelete_window.
554 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
555 code.
556 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
557 Qbuffer_list_update_hook if allowed.
558 (Fother_buffer): Rewrite doc-string. Major rewrite for new
559 buffer list implementation.
560 (other_buffer_safely): New function.
561 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
562 calls to replace_buffer_in_windows and
563 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
564 if allowed.
565 (record_buffer): Inhibit quitting and rewrite using quittable
566 functions. Run Qbuffer_list_update_hook if allowed.
567 (Frecord_buffer, Funrecord_buffer): New functions.
568 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
569 switch-to-buffer to window.el.
570 (bury-buffer): Move to window.el.
571 (Vbuffer_list_update_hook): New variable.
572
573 * lisp.h (other_buffer_safely): Add prototype in buffer.c
574 section.
575
576 * window.h (resize_frame_windows): Move up in code.
577 (Fwindow_frame): Remove EXFUN.
578 (replace_buffer_in_all_windows): Remove prototype.
579 (replace_buffer_in_windows_safely): Add prototype.
580
581 * window.c: Declare Qdelete_window static again. Move down
582 declaration of select_count.
583 (Fnext_window, Fprevious_window): Rewrite doc-strings.
584 (Fother_window): Move to window.el.
585 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
586 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
587 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
588 window.el.
589 (replace_buffer_in_windows): Implement by calling
590 Qreplace_buffer_in_windows.
591 (replace_buffer_in_all_windows): Remove with some functionality
592 moved into replace_buffer_in_windows_safely.
593 (replace_buffer_in_windows_safely): New function.
594 (select_window_norecord, select_frame_norecord): Move in front
595 of run_window_configuration_change_hook. Remove now obsolete
596 declarations.
597 (Fset_window_buffer): Rewrite doc-string. Call
598 Qrecord_window_buffer.
599 (keys_of_window): Move binding for other-window to window.el.
600
601 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
602
603 * dispextern.h (struct image): Replace data member, whose int_val
604 and ptr_val fields were not used by anything, with a single
605 lisp_val object.
606
607 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
608 (gif_clear_image, gif_load, imagemagick_load_image)
609 (gs_clear_image, gs_load): Callers changed.
610
611 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
612
613 * buffer.h: Include <time.h>, for time_t.
614 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
615
616 Fix minor problems found by static checking.
617
618 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
619
620 Make identifiers static if they are not used in other modules.
621 * data.c (Qcompiled_function, Qframe, Qvector):
622 * image.c (QimageMagick, Qsvg):
623 * minibuf.c (Qmetadata):
624 * window.c (resize_window_check, resize_root_window): Now static.
625 * window.h (resize_window_check, resize_root_window): Remove decls.
626
627 * window.c (window_deletion_count, delete_deletable_window):
628 Remove; unused.
629 (window_body_lines): Now static.
630 (Fdelete_other_windows_internal): Mark vars as initialized.
631 Make sure 'resize_failed' is initialized.
632 (run_window_configuration_change_hook): Rename local to avoid shadowing.
633 (resize_window_apply): Remove unused local.
634 * window.h (delete_deletable_window): Remove decl.
635
636 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
637 (imagemagick_load_image): Fix pointer signedness problem by changing
638 last arg from unsigned char * to char *. All uses changed.
639 Also, fix a local for similar reasons.
640 Remove unused locals. Remove locals to avoid shadowing.
641 (fn_rsvg_handle_free): Remove; unused.
642 (svg_load, svg_load_image): Fix pointer signedness problem.
643 (imagemagick_load_image): Don't use garbage pointer image_wand.
644
645 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
646
647 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
648
649 * image.c (gif_load): Fix omitted cast error introduced by
650 2011-06-06 change.
651
652 2011-06-10 Martin Rudalics <rudalics@gmx.at>
653
654 * window.h (resize_proportionally, orig_total_lines)
655 (orig_top_line): Remove from window structure.
656 (set_window_height, set_window_width, change_window_heights)
657 (Fdelete_window): Remove prototypes.
658 (resize_frame_windows): Remove duplicate declaration.
659
660 2011-06-10 Eli Zaretskii <eliz@gnu.org>
661
662 * window.h (resize_frame_windows, resize_window_check)
663 (delete_deletable_window, resize_root_window)
664 (resize_frame_windows): Declare prototypes.
665
666 * window.c (resize_window_apply): Make definition be "static" to
667 match the prototype.
668
669 2011-06-10 Martin Rudalics <rudalics@gmx.at>
670
671 * window.c: Remove declarations of Qwindow_size_fixed,
672 window_min_size_1, window_min_size_2, window_min_size,
673 size_window, window_fixed_size_p, enlarge_window, delete_window.
674 Remove static from declaration of Qdelete_window, it's
675 temporarily needed by Fbury_buffer.
676 (replace_window): Don't assign orig_top_line and
677 orig_total_lines.
678 (Fdelete_window, delete_window): Remove. Window deletion is
679 handled by window.el.
680 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
681 Fdelete_window calls with calls to Qdelete_window.
682 (Fdelete_other_windows): Remove. Deleting other windows is
683 handled by window.el.
684 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
685 handled in window.el.
686 (window_min_size_2, window_min_size_1, window_min_size): Remove.
687 Window minimum sizes are handled in window.el.
688 (shrink_windows, size_window, set_window_height)
689 (set_window_width, change_window_heights, window_height)
690 (window_width, CURBEG, CURSIZE, enlarge_window)
691 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
692 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
693 handled in window.el.
694 (make_dummy_parent): Rename to make_parent_window and give it a
695 second argument horflag.
696 (make_window): Don't set resize_proportionally any more.
697 (Fsplit_window): Remove. Windows are split in window.el.
698 (save_restore_action, save_restore_orig_size)
699 (shrink_window_lowest_first, save_restore_orig_size): Remove.
700 Resize mini windows in window.el.
701 (grow_mini_window, shrink_mini_window): Implement by calling
702 Qresize_root_window_vertically, resize_window_check and
703 resize_window_apply.
704 (saved_window, Fset_window_configuration, save_window_save): Do
705 not handle orig_top_line, orig_total_lines, and
706 resize_proportionally.
707 (window_min_height, window_min_width): Move to window.el.
708 (keys_of_window): Move bindings for delete-other-windows,
709 split-window, delete-window and enlarge-window to window.el.
710
711 * buffer.c: Temporarily extern Qdelete_window.
712 (Fbury_buffer): Temporarily call Qdelete_window instead of
713 Fdelete_window (Fbury_buffer will move to window.el soon).
714
715 * frame.c (set_menu_bar_lines_1): Remove code handling
716 orig_top_line and orig_total_lines.
717
718 * dispnew.c (adjust_frame_glyphs_initially): Don't use
719 set_window_height but set heights directly.
720 (change_frame_size_1): Use resize_frame_windows.
721
722 * xdisp.c (init_xdisp): Don't use set_window_height but set
723 heights directly.
724
725 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
726 resize_frame_windows instead of change_window_heights and run
727 run_window_configuration_change_hook.
728
729 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
730 instead of change_window_heights and run
731 run_window_configuration_change_hook.
732
733 2011-06-09 Martin Rudalics <rudalics@gmx.at>
734
735 * window.c (replace_window): Rename second argument REPLACEMENT to
736 NEW. New third argument SETFLAG. Rewrite.
737 (delete_window, make_dummy_parent): Call replace_window with
738 third argument 1.
739 (window_list_1): Move down in code.
740 (run_window_configuration_change_hook): Move set_buffer part
741 before select_frame_norecord part in order to unwind correctly.
742 Rename count1 to count.
743 (recombine_windows, delete_deletable_window, resize_root_window)
744 (Fdelete_other_windows_internal)
745 (Frun_window_configuration_change_hook, make_parent_window)
746 (resize_window_check, resize_window_apply, Fresize_window_apply)
747 (resize_frame_windows, Fsplit_window_internal)
748 (Fdelete_window_internal, Fresize_mini_window_internal): New
749 functions.
750 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
751
752 2011-06-08 Martin Rudalics <rudalics@gmx.at>
753
754 * window.h (window): Add some new members to window structure -
755 normal_lines, normal_cols, new_total, new_normal, clone_number,
756 splits, nest, prev_buffers, next_buffers.
757 (WINDOW_TOTAL_SIZE): Move here from window.c.
758 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
759
760 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
761 Remove.
762 (make_dummy_parent): Set new members of windows structure.
763 (make_window): Move down in code. Handle new members of window
764 structure.
765 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
766 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
767 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
768 (Fset_window_prev_buffers, Fwindow_next_buffers)
769 (Fset_window_next_buffers, Fset_window_clone_number): New
770 functions.
771 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
772 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
773 Doc-string fixes.
774 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
775 Argument WINDOW can be now internal window too.
776 (Fwindow_use_time): Move up in code.
777 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
778 Rewrite doc-string.
779 (Fset_window_configuration, saved_window)
780 (Fcurrent_window_configuration, save_window_save): Handle new
781 members of window structure.
782 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
783 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
784 (syms_of_window): New Lisp objects Qrecord_window_buffer,
785 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
786 Qget_mru_window, Qresize_root_window,
787 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
788 Qauto_buffer_name; staticpro them.
789
790 2011-06-07 Martin Rudalics <rudalics@gmx.at>
791
792 * window.c (Fwindow_total_size, Fwindow_left_column)
793 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
794 (Fwindow_list_1): New functions.
795 (window_box_text_cols): Replace with window_body_cols.
796 (Fwindow_width, Fscroll_left, Fscroll_right): Use
797 window_body_cols instead of window_box_text_cols.
798 (delete_window, Fset_window_configuration): Call
799 delete_all_subwindows with window as argument.
800 (delete_all_subwindows): Take a window as argument and not a
801 structure. Rewrite.
802 (window_loop): Remove handling of GET_LRU_WINDOW and
803 GET_LARGEST_WINDOW.
804 (Fget_lru_window, Fget_largest_window): Move to window.el.
805
806 * window.h: Extern window_body_cols instead of
807 window_box_text_cols. delete_all_subwindows now takes a
808 Lisp_Object as argument.
809
810 * indent.c (compute_motion, Fcompute_motion): Use
811 window_body_cols instead of window_box_text_cols.
812
813 * frame.c (delete_frame): Call delete_all_subwindows with root
814 window as argument.
815
816 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
817
818 * fns.c (Fputhash): Document return value.
819
820 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
821
822 * image.c (gif_load): Implement gif89a spec "no disposal" method.
823
824 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
825
826 Cons<->int and similar integer overflow fixes (Bug#8794).
827
828 Check for overflow when converting integer to cons and back.
829 * charset.c (Fdefine_charset_internal, Fdecode_char):
830 Use cons_to_unsigned to catch overflow.
831 (Fencode_char): Use INTEGER_TO_CONS.
832 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
833 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
834 * data.c (long_to_cons, cons_to_long): Remove.
835 (cons_to_unsigned, cons_to_signed): New functions.
836 These signal an error for invalid or out-of-range values.
837 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
838 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
839 * font.c (Ffont_variation_glyphs):
840 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
841 * lisp.h: Include <intprops.h>.
842 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
843 (cons_to_signed, cons_to_unsigned): New decls.
844 (long_to_cons, cons_to_long): Remove decls.
845 * undo.c (record_first_change): Use INTEGER_TO_CONS.
846 (Fprimitive_undo): Use CONS_TO_INTEGER.
847 * xfns.c (Fx_window_property): Likewise.
848 * xselect.c: Include <limits.h>.
849 (x_own_selection, selection_data_to_lisp_data):
850 Use INTEGER_TO_CONS.
851 (x_handle_selection_request, x_handle_selection_clear)
852 (x_get_foreign_selection, Fx_disown_selection_internal)
853 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
854 (lisp_data_to_selection_data): Use cons_to_unsigned.
855 (x_fill_property_data): Use cons_to_signed.
856 Report values out of range.
857
858 Check for buffer and string overflow more precisely.
859 * buffer.h (BUF_BYTES_MAX): New macro.
860 * lisp.h (STRING_BYTES_MAX): New macro.
861 * alloc.c (Fmake_string):
862 * character.c (string_escape_byte8):
863 * coding.c (coding_alloc_by_realloc):
864 * doprnt.c (doprnt):
865 * editfns.c (Fformat):
866 * eval.c (verror):
867 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
868 since they may not be the same number.
869 * editfns.c (Finsert_char):
870 * fileio.c (Finsert_file_contents):
871 Likewise for BUF_BYTES_MAX.
872
873 * image.c: Use ptrdiff_t, not int, for sizes.
874 (slurp_file): Switch from int to ptrdiff_t.
875 All uses changed.
876 (slurp_file): Check that file size fits in both size_t (for
877 malloc) and ptrdiff_t (for sanity and safety).
878
879 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
880 if b->modtime has its maximal value.
881
882 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
883
884 Don't assume time_t can fit into int.
885 * buffer.h (struct buffer.modtime): Now time_t, not int.
886 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
887 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
888
889 Minor fixes for signed vs unsigned integers.
890 * character.h (MAYBE_UNIFY_CHAR):
891 * charset.c (maybe_unify_char):
892 * keyboard.c (read_char, reorder_modifiers):
893 XINT -> XFASTINT, since the integer must be nonnegative.
894 * ftfont.c (ftfont_spec_pattern):
895 * keymap.c (access_keymap, silly_event_symbol_error):
896 XUINT -> XFASTINT, since the integer must be nonnegative.
897 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
898 since it makes no difference and we prefer signed.
899 * keyboard.c (record_char): Use XUINT when all the neighbors do.
900 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
901 nonnegative.
902
903 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
904
905 * window.h (Fwindow_frame): Declare.
906
907 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
908
909 * alloc.c: Simplify handling of large-request failures (Bug#8800).
910 (SPARE_MEMORY): Always define.
911 (LARGE_REQUEST): Remove.
912 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
913
914 2011-06-06 Martin Rudalics <rudalics@gmx.at>
915
916 * lisp.h: Move EXFUNS for Fframe_root_window,
917 Fframe_first_window and Fset_frame_selected_window to window.h.
918
919 * window.h: Move EXFUNS for Fframe_root_window,
920 Fframe_first_window and Fset_frame_selected_window here from
921 lisp.h.
922
923 * frame.c (Fwindow_frame, Fframe_first_window)
924 (Fframe_root_window, Fframe_selected_window)
925 (Fset_frame_selected_window): Move to window.c.
926 (Factive_minibuffer_window): Move to minibuf.c.
927 (Fother_visible_frames_p): New function.
928
929 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
930
931 * window.c (decode_window, decode_any_window): Move up in code.
932 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
933 (inhibit_frame_unsplittable): Remove unused variable.
934 (Fwindow_buffer): Move up and rewrite doc-string.
935 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
936 (Fwindow_prev): New functions.
937 (Fwindow_frame): Move here from frame.c. Accept any window as
938 argument.
939 (Fframe_root_window, Fframe_first_window)
940 (Fframe_selected_window): Move here from frame.c. Accept frame
941 or arbitrary window as argument. Update doc-strings.
942 (Fminibuffer_window): Move up in code.
943 (Fwindow_minibuffer_p): Move up in code and simplify.
944 (Fset_frame_selected_window): Move here from frame.c.
945 Marginal rewrite.
946 (Fselected_window, select_window, Fselect_window): Move up in
947 code. Minor doc-string fixes.
948
949 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
950
951 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
952 Do not assume that spare memory exists; that assumption is valid
953 only if SYSTEM_MALLOC.
954 (LARGE_REQUEST): New macro, so that the issue of large requests
955 is separated from the issue of spare memory.
956
957 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
958
959 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
960 format. (Bug#8806)
961
962 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
963
964 * xfns.c (x_set_scroll_bar_default_width): Move declarations
965 before statements.
966
967 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
968
969 * gtkutil.c (xg_get_default_scrollbar_width): New function.
970
971 * gtkutil.h: Declare xg_get_default_scrollbar_width.
972
973 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
974 min width by calling x_set_scroll_bar_default_width (Bug#8505).
975
976 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
977
978 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
979
980 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
981
982 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
983 (x_clipboard_manager_save): Add return value.
984 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
985 New error handlers.
986 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
987 Obey Vx_select_enable_clipboard_manager. Catch errors in
988 x_clipboard_manager_save (Bug#8779).
989 (Vx_select_enable_clipboard_manager): New variable.
990 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
991
992 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
993
994 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
995
996 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
997
998 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
999 in the current matrix if keep_current_p is non-zero.
1000
1001 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1002
1003 * bidi.c (bidi_level_of_next_char): Fix last change.
1004
1005 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1006
1007 Support bidi reordering of text covered by display properties.
1008
1009 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1010 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1011 (bidi_cache_search, bidi_cache_iterator_state)
1012 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1013 (bidi_level_of_next_char, bidi_move_to_visually_next):
1014 Support character positions inside a run of characters covered by a
1015 display string.
1016 (bidi_paragraph_init, bidi_resolve_explicit_1)
1017 (bidi_level_of_next_char): Call bidi_fetch_char and
1018 bidi_fetch_char_advance instead of FETCH_CHAR and
1019 FETCH_CHAR_ADVANCE.
1020 (bidi_init_it): Initialize new members.
1021 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1022 definitions.
1023 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1024 instead of using explicit *_CHAR codes.
1025 (bidi_resolve_explicit, bidi_resolve_weak):
1026 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1027 bidirectional text is supported only in multibyte buffers.
1028 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1029 it to initialize the frame_window_p member of struct bidi_it.
1030 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1031 (bidi_resolve_explicit, bidi_resolve_weak)
1032 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1033 bidi_it->nchars is non-positive.
1034 (bidi_level_of_next_char): Don't try to lookup the cache for the
1035 next/previous character if nothing is cached there yet, or if we
1036 were just reseat()'ed to a new position.
1037
1038 * xdisp.c (set_cursor_from_row): Set start and stop points
1039 according to the row's direction when priming the loop that looks
1040 for the glyph on which to display cursor.
1041 (single_display_spec_intangible_p): Function deleted.
1042 (display_prop_intangible_p): Reimplement to call
1043 handle_display_spec instead of single_display_spec_intangible_p.
1044 Accept 3 additional arguments needed by handle_display_spec.
1045 This fixes incorrect cursor motion across display property with complex
1046 values: lists, `(when COND...)' forms, etc.
1047 (single_display_spec_string_p): Support property values that are
1048 lists with the argument STRING its top-level element.
1049 (display_prop_string_p): Fix the condition for processing a
1050 property that is a list to be consistent with handle_display_spec.
1051 (handle_display_spec): New function, refactored from the
1052 last portion of handle_display_prop.
1053 (compute_display_string_pos): Accept additional argument
1054 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1055 value of a `display' property is a "replacing spec".
1056 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1057 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1058 the display property, but just return a value indicating whether
1059 the display property will replace the characters it covers.
1060 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1061 frame_window_p members of struct bidi_it.
1062 (compute_display_string_pos, compute_display_string_end):
1063 New functions.
1064 (push_it): Accept second argument POSITION, where pop_it should
1065 jump to continue iteration.
1066 (reseat_1): Initialize bidi_it.disp_pos.
1067
1068 * keyboard.c (adjust_point_for_property): Adjust the call to
1069 display_prop_intangible_p to its new signature.
1070
1071 * dispextern.h (struct bidi_it): New member frame_window_p.
1072 (bidi_init_it): Update prototypes.
1073 (display_prop_intangible_p): Update prototype.
1074 (compute_display_string_pos, compute_display_string_end):
1075 Declare prototypes.
1076 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1077 EMACS_INT.
1078
1079 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 Malloc failure behavior now depends on size of allocation.
1082 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1083 * lisp.h: Change signatures accordingly.
1084 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1085 All callers changed. (Bug#8762)
1086
1087 * gnutls.c: Use Emacs's memory allocators.
1088 Without this change, the gnutls library would invoke malloc etc.
1089 directly, which causes problems on non-SYNC_INPUT hosts, and which
1090 runs afoul of improving memory_full behavior. (Bug#8761)
1091 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1092 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1093 xfree instead of the default malloc, realloc, free.
1094 (Fgnutls_boot): No need to check for memory allocation failure,
1095 since xmalloc does that for us.
1096
1097 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1098 * category.c (hash_get_category_set):
1099 * ccl.c (ccl_driver):
1100 * charset.c (Fdefine_charset_internal):
1101 * charset.h (struct charset.hash_index):
1102 * composite.c (get_composition_id, gstring_lookup_cache)
1103 (composition_gstring_put_cache):
1104 * composite.h (struct composition.hash_index):
1105 * dispextern.h (struct image.hash):
1106 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1107 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1108 (hashfn_equal, hashfn_user_defined, make_hash_table)
1109 (maybe_resize_hash_table, hash_lookup, hash_put)
1110 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1111 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1112 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1113 * image.c (make_image, search_image_cache, lookup_image)
1114 (xpm_put_color_table_h):
1115 * lisp.h (struct Lisp_Hash_Table):
1116 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1117 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1118 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1119 * alloc.c (allocate_vectorlike):
1120 Check for overflow in vector size calculations.
1121 * ccl.c (ccl_driver):
1122 Check for overflow when converting EMACS_INT to int.
1123 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1124 need to be updated by these changes.
1125 * fns.c (make_hash_table, maybe_resize_hash_table):
1126 Check for integer overflow with large hash tables.
1127 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1128 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1129 (SXHASH_REDUCE): New macro.
1130 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1131 Use it instead of discarding useful hash info with large hash values.
1132 (sxhash_float): New function.
1133 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1134 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1135 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1136 Rewrite to use FIXNUM_BITS, as this simplifies things.
1137 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1138 Adjust signatures to match updated version of code.
1139 (consing_since_gc): Now EMACS_INT, since a single hash table can
1140 use more than INT_MAX bytes.
1141
1142 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1143
1144 Make it possible to build with GCC-4.6+ -O2 -flto.
1145
1146 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1147
1148 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1149
1150 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1151 Call minibuffer-inactive-mode.
1152
1153 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1154
1155 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1156 Update dependencies.
1157
1158 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1159
1160 * data.c (init_data): Remove code for UTS, this system is not
1161 supported anymore.
1162
1163 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1164
1165 Don't force ./temacs to start in terminal mode.
1166
1167 * frame.c (make_initial_frame): Initialize faces in all cases, not
1168 only when CANNOT_DUMP is defined.
1169 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1170
1171 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1172
1173 * dispnew.c (add_window_display_history): Use const for the string
1174 pointer. Remove declaration, not needed.
1175
1176 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 Use 'inline', not 'INLINE'.
1179 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1180 * alloc.c, fontset.c (INLINE): Remove.
1181 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1182 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1183 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1184 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1185 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1186
1187 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1188
1189 Make it possible to run ./temacs.
1190
1191 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1192 syms_of_callproc does the same thing. Remove test for
1193 "initialized", do it in the caller.
1194 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1195
1196 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1197
1198 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1199 (read_minibuf): Use get_minibuffer.
1200 (syms_of_minibuf): Use DEFSYM.
1201 (Qmetadata): New var.
1202 * data.c (Qbuffer): Don't make it static.
1203 (syms_of_data): Use DEFSYM.
1204
1205 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1206
1207 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1208 (CCL_CODE_MIN): New macro.
1209
1210 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1213
1214 * eval.c (Qdebug): Now static.
1215 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1216 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1217 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1218
1219 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1220
1221 * image.c: Various fixes to ImageMagick code comments.
1222 (Fimagemagick_types): Doc fix.
1223
1224 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 Minor fixes prompted by GCC 4.6.0 warnings.
1227
1228 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1229
1230 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1231 (x_clipboard_manager_save_all): Move extern decl to ...
1232 * xterm.h: ... here, so that it can be checked for consistency.
1233
1234 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1235
1236 * xselect.c (x_clipboard_manager_save_frame)
1237 (x_clipboard_manager_save_all): New functions.
1238 (Fx_clipboard_manager_save): Lisp function deleted.
1239
1240 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1241 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1242
1243 * xterm.h: Update prototype.
1244
1245 2011-05-28 William Xu <william.xwl@gmail.com>
1246
1247 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1248 exiting (Bug#8239).
1249
1250 2011-05-28 Jim Meyering <meyering@redhat.com>
1251
1252 Avoid a sign-extension bug in crypto_hash_function.
1253 * fns.c (to_uchar): Define.
1254 (crypto_hash_function): Use it to convert some newly-signed
1255 variables to unsigned, to avoid sign-extension bugs. For example,
1256 without this change, (md5 "truc") would evaluate to
1257 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1258 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1259 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1260
1261 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1262
1263 Integer overflow fixes.
1264
1265 * dbusbind.c: Serial number integer overflow fixes.
1266 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1267 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1268 to hold a serial number that is too large for a fixnum.
1269 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1270 Check for serial numbers out of range. Decode any serial number
1271 that was so large that it became a float. (Bug#8722)
1272
1273 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1274 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1275 Use XFASTINT rather than XUINT when numbers are nonnegative.
1276 (xd_append_arg, Fdbus_method_return_internal):
1277 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1278 arguments, check that Lisp number is nonnegative, rather than
1279 silently wrapping negative numbers around. (Bug#8722)
1280 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1281 (Bug#8722)
1282
1283 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1284
1285 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1286
1287 ccl: add integer overflow checks
1288 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1289 (IN_INT_RANGE): New macros.
1290 (ccl_driver): Use them to check for integer overflow when
1291 decoding a CCL program. Many of the new checks are whether XINT (x)
1292 fits in int; it doesn't always, on 64-bit hosts. The new version
1293 doesn't catch all possible integer overflows, but it's an
1294 improvement. (Bug#8719)
1295
1296 * alloc.c (make_event_array): Use XINT, not XUINT.
1297 There's no need for unsigned here.
1298
1299 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1300 This follows up to the 2011-05-06 change that substituted uintptr_t
1301 for EMACS_INT. This case wasn't caught back then.
1302
1303 Rework Fformat to avoid integer overflow issues.
1304 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1305 now (part of C89). Include <verify.h>.
1306 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1307 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1308 (Fformat): Avoid the prepass trying to compute sizes; it was only
1309 approximate and thus did not catch overflow reliably. Instead, walk
1310 through the format just once, formatting and computing sizes as we go,
1311 checking for integer overflow at every step, and allocating a larger
1312 buffer as needed. Keep track separately whether the format is
1313 multibyte. Keep only the most-recently calculated precision, rather
1314 than them all. Record whether each argument has been converted to
1315 string. Use EMACS_INT, not int, for byte and char and arg counts.
1316 Support field widths and precisions larger than INT_MAX. Avoid
1317 sprintf's undefined behavior with conversion specifications such as %#d
1318 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1319 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1320 formatting out-of-range floating point numbers with int
1321 formats. (Bug#8668)
1322
1323 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1324
1325 * data.c: Avoid integer truncation in expressions involving floats.
1326 * data.c: Include <intprops.h>.
1327 (arith_driver): When there's an integer overflow in an expression
1328 involving floating point, convert the integers to floating point
1329 so that the resulting value does not suffer from catastrophic
1330 integer truncation. For example, on a 64-bit host (* 4
1331 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1332 Do not rely on undefined behavior after integer overflow.
1333
1334 merge count_size_as_multibyte, parse_str_to_multibyte
1335 * character.c, character.h (count_size_as_multibyte):
1336 Rename from parse_str_to_multibyte; all uses changed.
1337 Check for integer overflow.
1338 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1339 since it's now a duplicate of the other. This is more of
1340 a character than a buffer op, so better that it's in character.c.
1341 * fns.c, print.c: Adjust to above changes.
1342
1343 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1344
1345 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1346
1347 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1350 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1351 (x_clipboard_manager_save): Now static.
1352 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1353
1354 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1355 (crypto_hash_function): Now static.
1356 Fix pointer signedness problems. Avoid unnecessary initializations.
1357
1358 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1359
1360 * termhooks.h (Vselection_alist): Make it terminal-local.
1361
1362 * terminal.c (create_terminal): Initialize it.
1363
1364 * xselect.c: Support for clipboard managers.
1365 (Vselection_alist): Move to termhooks.h as terminal-local var.
1366 (LOCAL_SELECTION): New macro.
1367 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1368 (symbol_to_x_atom): Remove gratuitous arg.
1369 (x_handle_selection_request, lisp_data_to_selection_data)
1370 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1371 (x_own_selection, x_get_local_selection, x_convert_selection):
1372 New arg, specifying work frame. Use terminal-local Vselection_alist.
1373 (some_frame_on_display): Delete unused function.
1374 (Fx_own_selection_internal, Fx_get_selection_internal)
1375 (Fx_disown_selection_internal, Fx_selection_owner_p)
1376 (Fx_selection_exists_p): New optional frame arg.
1377 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1378 (x_handle_selection_clear): Don't treat other terminals with the
1379 same keyboard specially. Use the terminal-local Vselection_alist.
1380 (x_clear_frame_selections): Use Frun_hook_with_args.
1381
1382 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1383
1384 * xterm.h: Add support for those atoms.
1385
1386 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1387
1388 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1389 (converted_selections, conversion_fail_tag): New global variables.
1390 (x_selection_request_lisp_error): Free the above.
1391 (x_get_local_selection): Remove unnecessary code.
1392 (x_reply_selection_request): Args changed; handle arbitrary array
1393 of converted selections stored in converted_selections.
1394 Separate the XChangeProperty and SelectionNotify steps.
1395 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1396 (x_convert_selection): New function.
1397 (x_handle_selection_event): Simplify.
1398 (x_get_foreign_selection): Don't ignore incoming requests while
1399 waiting for an answer; this will fail when we implement
1400 SAVE_TARGETS, and seems unnecessary anyway.
1401 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1402 (Vx_sent_selection_functions): Doc fix.
1403
1404 2011-05-26 Leo Liu <sdl.web@gmail.com>
1405
1406 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1407
1408 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1409
1410 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1411
1412 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1413 for fringe update if it has periodic bitmap.
1414 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1415 and fringe_bitmap_periodic_p.
1416
1417 * fringe.c (get_fringe_bitmap_data): New function.
1418 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1419 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1420 row. Mark glyph row for fringe update if periodicity changed.
1421
1422 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1423 for fringe update unless it has periodic bitmap.
1424
1425 2011-05-25 Kenichi Handa <handa@m17n.org>
1426
1427 * xdisp.c (get_next_display_element): Set correct it->face_id for
1428 a static composition.
1429
1430 2011-05-24 Leo Liu <sdl.web@gmail.com>
1431
1432 * deps.mk (fns.o):
1433 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1434
1435 * fns.c (crypto_hash_function, Fsha1): New function.
1436 (Fmd5): Use crypto_hash_function.
1437 (syms_of_fns): Add Ssha1.
1438
1439 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1440
1441 * gnutls.c: Remove unused macros.
1442 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1443 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1444 Remove macros that are defined and never used.
1445 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1446
1447 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1448
1449 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1450 (Fx_get_selection_internal): Minor cleanup.
1451 (Fx_own_selection_internal): Rename arguments for consistency with
1452 select.el.
1453
1454 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1457
1458 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1459
1460 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1461
1462 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1463
1464 * dispnew.c (scrolling_window): Don't exclude the case that the
1465 last enabled row in the desired matrix touches the bottom boundary.
1466
1467 2011-05-21 Glenn Morris <rgm@gnu.org>
1468
1469 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1470 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1471 and add some more files.
1472
1473 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1474
1475 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1476 report_file_error introduced by the change from 2011-05-07.
1477
1478 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1479
1480 * systime.h (Time): Define only if emacs is defined.
1481 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1482 where the include path doesn't have X11/X.h by default. See
1483 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1484
1485 2011-05-20 Kenichi Handa <handa@m17n.org>
1486
1487 * composite.c (find_automatic_composition): Fix previous change.
1488
1489 2011-05-20 Glenn Morris <rgm@gnu.org>
1490
1491 * lisp.mk: New file, split from Makefile.in.
1492 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1493 (shortlisp): Remove.
1494 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1495
1496 2011-05-19 Glenn Morris <rgm@gnu.org>
1497
1498 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1499 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1500 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1501 (lisp): Set the order to that of loadup.el.
1502 (shortlisp): Make it a copy of $lisp.
1503 (SOME_MACHINE_LISP): Remove.
1504 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1505 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1506
1507 2011-05-18 Kenichi Handa <handa@m17n.org>
1508
1509 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1510 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1511 (find_automatic_composition): Mostly rewrite for efficiency.
1512
1513 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1514
1515 * makefile.w32-in: Update dependencies.
1516
1517 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1518
1519 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1520 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1521
1522 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 Fix some integer overflow issues, such as string length overflow.
1525
1526 * insdel.c (count_size_as_multibyte): Check for string overflow.
1527
1528 * character.c (lisp_string_width): Check for string overflow.
1529 Use EMACS_INT, not int, for string indexes and lengths; in
1530 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1531 the resulting string length overflows an EMACS_INT; instead,
1532 report a string overflow if no precision given. When checking for
1533 precision exhaustion, use a check that cannot possibly have
1534 integer overflow. (Bug#8675)
1535 * character.h (lisp_string_width): Adjust to new signature.
1536
1537 * alloc.c (string_overflow): New function.
1538 (Fmake_string): Use it. This doesn't change behavior, but saves
1539 a few bytes and will simplify future changes.
1540 * character.c (string_escape_byte8): Likewise.
1541 * lisp.h (string_overflow): New decl.
1542
1543 Fixups, following up to the user-interface timestamp change.
1544 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1545 for UI timestamps, instead of unsigned long.
1546 * msdos.c (mouse_get_pos): Likewise.
1547 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1548 * w32gui.h (Time): Define by including "systime.h" rather than by
1549 declaring it ourselves. (Bug#8664)
1550
1551 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1552 * image.c (clear_image_cache): Likewise.
1553
1554 * term.c (term_mouse_position): Don't assume time_t wraparound.
1555
1556 Be more systematic about user-interface timestamps.
1557 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1558 and sometimes 'EMACS_UINT', to represent these timestamps.
1559 This change causes it to use 'Time' uniformly, as that's what X uses.
1560 This makes the code easier to follow, and makes it easier to catch
1561 integer overflow bugs such as Bug#8664.
1562 * frame.c (Fmouse_position, Fmouse_pixel_position):
1563 Use Time, not unsigned long, for user-interface timestamps.
1564 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1565 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1566 * keyboard.h (last_event_timestamp): Likewise.
1567 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1568 * menu.h (xmenu_show): Likewise.
1569 * term.c (term_mouse_position): Likewise.
1570 * termhooks.h (struct input_event.timestamp): Likewise.
1571 (struct terminal.mouse_position_hook): Likewise.
1572 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1573 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1574 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1575 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1576 what it was before.
1577 * menu.h, termhooks.h: Include "systime.h", for Time.
1578
1579 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1580 Don't assume that the difference between two unsigned long values
1581 can fit into an integer. At this point, we know button_down_time
1582 <= event->timestamp, so the difference must be nonnegative, so
1583 there's no need to cast the result if double-click-time is
1584 nonnegative, as it should be; check that it's nonnegative, just in
1585 case. This bug is triggered when events are more than 2**31 ms
1586 apart (about 25 days). (Bug#8664)
1587
1588 * xselect.c (last_event_timestamp): Remove duplicate decl.
1589 (x_own_selection): Remove needless cast to unsigned long.
1590
1591 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1592 that always fit in int. Use a sentinel instead of a counter, to
1593 avoid a temp and to allay GCC's concerns about possible int overflow.
1594 * frame.h (struct frame): Use int for menu_bar_items_used
1595 instead of EMACS_INT, since it always fits in int.
1596
1597 * menu.c (grow_menu_items): Check for int overflow.
1598
1599 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1600
1601 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1602 Before, the code was not consistent. These values cannot exceed
1603 2**31 - 1 so there's no need to make them unsigned.
1604 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1605 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1606 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1607 as modifiers.
1608 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1609
1610 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1611 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1612 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1613 presumably because the widths might not match.
1614
1615 * window.c (size_window): Avoid needless test at loop start.
1616
1617 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1618
1619 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1620
1621 2011-05-12 Drew Adams <drew.adams@oracle.com>
1622
1623 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1624
1625 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1626
1627 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1628 `width' to `bar_area_x' and `bar_area_width', respectively.
1629 (x_scroll_run): Take account of fringe background extension.
1630
1631 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1632 Rename local vars `left' and `width' to `bar_area_x' and
1633 `bar_area_width', respectively.
1634 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1635 background extension.
1636
1637 2011-05-10 Jim Meyering <meyering@redhat.com>
1638
1639 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1640
1641 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1642
1643 * image.c (Finit_image_library): Return t for built-in image types,
1644 like pbm and xbm. (Bug#8640)
1645
1646 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1647
1648 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1649
1650 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1651
1652 * w32console.c (Fset_screen_color): Doc fix.
1653 (Fget_screen_color): New function.
1654 (syms_of_ntterm): Defsubr it.
1655
1656 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1657 unlink the temporary file if Fcall_process didn't create it in the
1658 first place.
1659 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1660 child process will be redirected to a file specified with `:file'.
1661 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1662 cue to call_process_cleanup not to close that handle.
1663
1664 2011-05-07 Ben Key <bkey76@gmail.com>
1665
1666 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1667 one of two shell specific rules, either bootstrap-temacs-CMD or
1668 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1669 to the previous implementation of the bootstrap-temacs rule.
1670 The bootstrap-temacs-CMD rule is similar to the previous
1671 implementation of the bootstrap-temacs rule except that it
1672 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1673 variable.
1674
1675 These changes, along with some changes to nt/configure.bat,
1676 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1677 earlier fix to add support for --cflags and --ldflags options
1678 that include quotes so that it works whether make uses cmd or
1679 sh as the shell.
1680
1681 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1682
1683 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1684 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1685 is a constant.
1686 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1687 a string. Handle both cases.
1688 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1689 (Fdbus_register_method): Use Qinvalid_function.
1690
1691 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1692
1693 * makefile.w32-in: Update dependencies.
1694 (LISP_H): Add inttypes.h and stdin.h.
1695 (PROCESS_H): Add unistd.h.
1696
1697 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1698
1699 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1700 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1701
1702 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1703
1704 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1705
1706 * term.c (vfatal): Remove stray call to va_end.
1707 It's not needed and the C Standard doesn't allow it here anyway.
1708
1709 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1710 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1711
1712 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1713 bytes.
1714
1715 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1716
1717 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1718
1719 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1720
1721 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1722
1723 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1724
1725 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1726 * charset.c (Fdefine_charset_internal): Don't initialize
1727 charset.code_space[15]. The value was garbage, on hosts with
1728 32-bit int (Bug#8600).
1729
1730 * lread.c (read_integer): Be more consistent with string-to-number.
1731 Use string_to_number to do the actual conversion; this avoids
1732 rounding errors and fixes some other screwups. Without this fix,
1733 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1734 (digit_to_number): Move earlier, for benefit of read_integer.
1735 Return -1 if the digit is out of range for the base, -2 if it is
1736 not a digit in any supported base. (Bug#8602)
1737
1738 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1739
1740 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1741 to match comment at start of function. This also removes a
1742 GCC warning about overflow in a 32+64-bit port.
1743
1744 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1745
1746 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1747 Reported by Stefan Monnier in
1748 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1749 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1750 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1751
1752 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1753 (EMACS_UINTPTR): Likewise, with uintptr_t.
1754
1755 * lisp.h: Prefer 64-bit EMACS_INT if available.
1756 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1757 on 32-bit hosts that have 64-bit int, so that they can access
1758 large files.
1759 However, temporarily disable this change unless the temporary
1760 symbol WIDE_EMACS_INT is defined.
1761
1762 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1763
1764 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1765 This removes an assumption that EMACS_INT and long are the same
1766 width as pointers. The assumption is true for Emacs porting targets
1767 now, but we want to make other targets possible.
1768 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1769 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1770 In the rest of the code, change types of integers that hold casted
1771 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1772 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1773 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1774 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1775 No need to cast type when ORing.
1776 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1777 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1778 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1779 assume EMACS_INT is the same width as char *.
1780 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1781 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1782 Remove no-longer-needed casts.
1783 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1784 (xg_tool_bar_help_callback, xg_make_tool_item):
1785 Use EMACS_INTPTR to hold an integer
1786 that will be cast to void *; this can avoid a GCC warning
1787 if EMACS_INT is not the same width as void *.
1788 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1789 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1790 (current_message_1, set_message_1):
1791 Use a local to convert to proper width without a cast.
1792 * xmenu.c (dialog_selection_callback): Likewise.
1793
1794 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1795 Also, don't assume VALBITS / RAND_BITS is less than 5,
1796 and don't rely on undefined behavior when shifting a 1 left into
1797 the sign bit.
1798 * lisp.h (get_random): Change signature to match.
1799
1800 * lread.c (hash_string): Use size_t, not int, for hash computation.
1801 Normally we prefer signed values; but hashing is special, because
1802 it's better to use unsigned division on hash table sizes so that
1803 the remainder is nonnegative. Also, size_t is the natural width
1804 for hashing into memory. The previous code used 'int', which doesn't
1805 retain enough info to hash well into very large tables.
1806 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1807
1808 * dbusbind.c: Don't possibly lose pointer info when converting.
1809 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1810 Use XPNTR rather than XHASH, so that the high-order bits of
1811 the pointer aren't lost when converting through void *.
1812
1813 * eval.c (Fautoload): Don't double-shift a pointer.
1814
1815 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1816
1817 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1818
1819 * gnutls.c (DEF_GNUTLS_FN):
1820 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1821
1822 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1823
1824 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1825 marker. (Bug#8610)
1826
1827 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1828
1829 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1830 New version that can reserve upto 2GB of heap space.
1831
1832 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1833
1834 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1835
1836 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1837
1838 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1839 `gnutls_certificate_set_x509_key_file'.
1840
1841 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1842
1843 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1844 Update dependencies.
1845
1846 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1847
1848 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1849 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1850 Remove unused parameter `fildes'.
1851 * process.c (read_process_output, send_process): Don't pass it.
1852
1853 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1854
1855 Fix previous change: the library cache is defined in w32.c.
1856 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1857 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1858
1859 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1860
1861 Implement dynamic loading of GnuTLS on Windows.
1862
1863 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1864 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1865 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1866 Declare.
1867
1868 * gnutls.c (Qgnutls_dll): Define.
1869 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1870 (gnutls_*): Declare function pointers.
1871 (init_gnutls_functions): New function to initialize function pointers.
1872 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1873 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1874 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1875 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1876 (emacs_gnutls_write, emacs_gnutls_read)
1877 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1878 (Fgnutls_available_p): New function.
1879 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1880 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1881 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1882
1883 * image.c: Include w32.h.
1884 (Vimage_type_cache): Delete.
1885 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1886 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1887 (w32_delayed_load): Move to w32.c.
1888
1889 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1890
1891 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1892 (w32_delayed_load): Move from image.c. When loading a library, record
1893 its filename in the :loaded-from property of the library id.
1894 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1895 Initialize and staticpro them.
1896 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1897
1898 * process.c: Include lisp.h before w32.h, not after.
1899 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1900 instead of gnutls_record_check_pending.
1901
1902 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1903
1904 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1905
1906 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1907 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1908 as passed in.
1909
1910 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1911
1912 * xterm.c (x_set_frame_alpha): Do not set property on anything
1913 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1914
1915 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1916
1917 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1918
1919 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1920
1921 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1922 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1923 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1924 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1925 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1926 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1927 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1928 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1929 (Qgnutls_bootprop_callbacks_verify): Make static.
1930
1931 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1932
1933 * callproc.c: Indentation fixup.
1934
1935 * sysdep.c (wait_for_termination_1): Make static.
1936 (wait_for_termination, interruptible_wait_for_termination):
1937 Move after wait_for_termination_1.
1938
1939 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1940
1941 * sysdep.c (interruptible_wait_for_termination): New function
1942 which is like wait_for_termination, but allows keyboard
1943 interruptions.
1944
1945 * callproc.c (Fcall_process): Add (:file "file") as an option for
1946 the STDOUT buffer.
1947 (Fcall_process_region): Ditto.
1948
1949 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1950
1951 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1952 rather than `XVECTOR (FOO)->size'.
1953
1954 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1955 inttypes.h, as a gnulib replacement is used if it not available in
1956 system headers.
1957
1958 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1959
1960 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1961 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1962 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1963
1964 * coding.c (coding_alloc_by_realloc): Error out if destination
1965 will grow beyond MOST_POSITIVE_FIXNUM.
1966 (decode_coding_emacs_mule): Abort if there isn't enough place in
1967 charbuf for the composition carryover bytes. Reserve an extra
1968 space for up to 2 characters produced in a loop.
1969 (decode_coding_iso_2022): Abort if there isn't enough place in
1970 charbuf for the composition carryover bytes.
1971
1972 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1973
1974 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1975 aborting when %lld or %lll format is passed.
1976 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1977 %llo or %llx format is passed. (Bug#8545)
1978
1979 * window.c (window_scroll_line_based): Use a marker instead of
1980 simple variables to record original value of point. (Bug#7952)
1981
1982 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1983 produced by %s or %c overflows available buffer space. (Bug#8545)
1984
1985 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1986
1987 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1988 (SIZE_MAX): Move defn after all includes, as they might #define it.
1989
1990 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1991
1992 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1993
1994 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1995
1996 * keyboard.c (Qdelayed_warnings_hook): Define.
1997 (command_loop_1): Run `delayed-warnings-hook'
1998 if Vdelayed_warnings_list is non-nil.
1999 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2000 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2001
2002 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2003
2004 * doprnt.c (doprnt): Don't return value smaller than the buffer
2005 size if the message was truncated. (Bug#8545).
2006
2007 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2008
2009 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2010 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2011
2012 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2013
2014 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2015
2016 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2017
2018 * makefile.w32-in: Update dependencies.
2019
2020 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2021
2022 Improve `doprnt' and its usage. (Bug#8545)
2023 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2024 `format_end'. Remove support for %l as a conversion specifier.
2025 Don't use xrealloc. Improve diagnostics when the %l size modifier
2026 is used. Update the commentary.
2027
2028 * eval.c (verror): Simplify calculation of size_t.
2029
2030 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2031 messages.
2032
2033 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2034
2035 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2036 change.
2037
2038 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2039
2040 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2041 This makes this file independent of the recent pseudovector change.
2042
2043 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2046
2047 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2048 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2049 Remove unused local.
2050 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2051
2052 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2053 GCC 4.6.0 optimizes based on type-based alias analysis.
2054 For example, if b is of type struct buffer * and v of type struct
2055 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2056 != &v->size, and therefore "v->size = 1; b->size = 2; return
2057 v->size;" must therefore return 1. This assumption is incorrect
2058 for Emacs, since it type-puns struct Lisp_Vector * with many other
2059 types. To fix this problem, this patch adds a new type struct
2060 vectorlike_header that documents the constraints on layout of vectors
2061 and pseudovectors, and helps optimizing compilers not get fooled
2062 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2063 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2064 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2065 the size member.
2066 (XSETPVECTYPE): Rewrite in terms of new macro.
2067 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2068 This is a bit clearer, and further avoids the possibility of
2069 undesirable aliasing.
2070 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2071 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2072 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2073 since Lisp_Subr is a special case (no "next" field).
2074 (ASIZE): Now uses header.size rather than size.
2075 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2076 to avoid the hassle of writing XVECTOR (foo)->header.size.
2077 (struct vectorlike_header): New type.
2078 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2079 object, to help avoid aliasing.
2080 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2081 (SUBRP): Likewise, since Lisp_Subr is a special case.
2082 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2083 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2084 (struct Lisp_Hash_Table): Combine first two members into a single
2085 struct vectorlike_header member. All uses of "size" and "next" members
2086 changed to be "header.size" and "header.next".
2087 * buffer.h (struct buffer): Likewise.
2088 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2089 * frame.h (struct frame): Likewise.
2090 * process.h (struct Lisp_Process): Likewise.
2091 * termhooks.h (struct terminal): Likewise.
2092 * window.c (struct save_window_data, struct saved_window): Likewise.
2093 * window.h (struct window): Likewise.
2094 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2095 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2096 * buffer.c (init_buffer_once): Likewise.
2097 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2098 special case.
2099 * process.c (Fformat_network_address): Use local var for size,
2100 for brevity.
2101
2102 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2103
2104 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2105 * data.c (atof): Remove decl; no longer used or needed.
2106 (digit_to_number): Move to lread.c.
2107 (Fstring_to_number): Use new string_to_number function, to be
2108 consistent with how the Lisp reader treats infinities and NaNs.
2109 Do not assume that floating-point numbers represent EMACS_INT
2110 without losing information; this is not true on most 64-bit hosts.
2111 Avoid double-rounding errors, by insisting on integers when
2112 parsing non-base-10 numbers, as the documentation specifies.
2113 * lisp.h (string_to_number): New decl, replacing ...
2114 (isfloat_string): Remove.
2115 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2116 (read1): Do not accept +. and -. as integers; this
2117 appears to have been a coding error. Similarly, do not accept
2118 strings like +-1e0 as floating point numbers. Do not report
2119 overflow for integer overflows unless the base is not 10 which
2120 means we have no simple and reliable way to continue.
2121 Break out the floating-point parsing into a new
2122 function string_to_number, so that Fstring_to_number parses
2123 floating point numbers consistently with the Lisp reader.
2124 (digit_to_number): Move here from data.c. Make it static inline.
2125 (E_CHAR, EXP_INT): Remove, replacing with ...
2126 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2127 (string_to_number): New function, replacing isfloat_string.
2128 This function checks for valid syntax and produces the resulting
2129 Lisp float number too. Rework it so that string-to-number
2130 no longer mishandles examples like "1.0e+". Use strtoumax,
2131 so that overflow for non-base-10 numbers is reported only when
2132 there's no portable and simple way to convert to floating point.
2133
2134 * textprop.c (set_text_properties_1): Rewrite for clarity,
2135 and to avoid GCC warning about integer overflow.
2136
2137 * intervals.h (struct interval): Use EMACS_INT for members
2138 where EMACS_UINT might cause problems. See
2139 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2140 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2141 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2142 All uses changed.
2143 (offset_intervals): Tell GCC not to worry about length overflow
2144 when negating a negative length.
2145
2146 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2147 (overrun_check_free): Likewise.
2148
2149 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2150 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2151 word size.
2152
2153 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2154 (gnutls_make_error): Rename local to avoid shadowing.
2155 (gnutls_emacs_global_deinit): ifdef out; not used.
2156 (Fgnutls_boot): Use const for pointer to readonly storage.
2157 Comment out unused local. Fix pointer signedness problems.
2158
2159 * lread.c (openp): Don't stuff size_t into an 'int'.
2160 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2161 about possible signed overflow.
2162
2163 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2164 (GDK_KEY_g): Don't define if already defined.
2165 (xg_prepare_tooltip): Avoid pointer signedness problem.
2166 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2167
2168 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2169 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2170
2171 * xfns.c (Fx_window_property): Simplify a bit,
2172 to make a bit faster and to avoid GCC 4.6.0 warning.
2173 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2174
2175 * fns.c (internal_equal): Don't assume size_t fits in int.
2176
2177 * alloc.c (compact_small_strings): Tighten assertion a little.
2178
2179 Replace pEd with more-general pI, and fix some printf arg casts.
2180 * lisp.h (pI): New macro, generalizing old pEd macro to other
2181 conversion specifiers. For example, use "...%"pI"d..." rather
2182 than "...%"pEd"...".
2183 (pEd): Remove. All uses replaced with similar uses of pI.
2184 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2185 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2186 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2187 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2188 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2189 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2190 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2191 64-bit hosts.
2192 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2193 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2194 * print.c (safe_debug_print, print_object): Likewise.
2195 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2196 to int.
2197 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2198 avoiding the 0 flag, which is not portable.
2199 * process.c (Fmake_network_process): Use pI to avoid cast.
2200 * region-cache.c (pp_cache): Likewise.
2201 * xdisp.c (decode_mode_spec): Likewise.
2202 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2203 behavior on 64-bit hosts with printf arg.
2204 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2205 (x_stop_queuing_selection_requests): Likewise.
2206 (x_get_window_property): Don't truncate byte count to an 'int'
2207 when tracing.
2208
2209 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2210 here, since it parses constructs like leading '-' and spaces,
2211 which are not wanted; and it overflows with large numbers.
2212 Instead, simply match F[0-9]+, which is what is wanted anyway.
2213
2214 * alloc.c: Remove unportable assumptions about struct layout.
2215 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2216 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2217 (allocate_vectorlike, make_pure_vector): Use the new macros,
2218 plus offsetof, to remove unportable assumptions about struct layout.
2219 These assumptions hold on all porting targets that I know of, but
2220 they are not guaranteed, they're easy to remove, and removing them
2221 makes further changes easier.
2222
2223 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2224 This doesn't fix a bug but makes the code clearer.
2225 (string_overrun_cookie): Now const. Use initializers that
2226 don't formally overflow signed char, to avoid warnings.
2227 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2228 can cause Emacs to crash when string overrun checking is enabled.
2229 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2230 multiple of sizeof (EMACS_INT); it need not be, if
2231 alignof(EMACS_INT) < sizeof (EMACS_INT).
2232 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2233
2234 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2235
2236 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2237
2238 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2239
2240 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2241 supposed to be handshaking. (Bug#8556)
2242 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2243
2244 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2245
2246 * lisp.h (Qdebug): List symbol.
2247 * eval.c (Qdebug): Restore global linkage.
2248 * keyboard.c (debug-on-event): New variable.
2249 (handle_user_signal): Break into debugger when debug-on-event
2250 matches the current signal symbol.
2251
2252 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2253
2254 * alloc.c (check_sblock, check_string_bytes)
2255 (check_string_free_list): Convert to standard C.
2256
2257 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2258
2259 * w32.c (emacs_gnutls_push): Fix typo.
2260
2261 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2262
2263 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2264 "cast to pointer from integer of different size".
2265
2266 Improve doprnt and its use in verror. (Bug#8545)
2267 * doprnt.c (doprnt): Document the set of format control sequences
2268 supported by the function. Use SAFE_ALLOCA instead of always
2269 using `alloca'.
2270
2271 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2272 is one byte too soon. Don't use xrealloc; instead xfree and
2273 xmalloc anew.
2274
2275 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2276
2277 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2278 callbacks stage.
2279
2280 * gnutls.c: Renamed global_initialized to
2281 gnutls_global_initialized. Added internals for the
2282 :verify-hostname-error, :verify-error, and :verify-flags
2283 parameters of `gnutls-boot' and documented those parameters in the
2284 docstring. Start callback support.
2285 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2286 unless a fatal error occured. Call gnutls_alert_send_appropriate
2287 on error. Return error code.
2288 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2289 (emacs_gnutls_read): Likewise.
2290 (Fgnutls_boot): Return handshake error code.
2291 (emacs_gnutls_handle_error): New function.
2292 (wsaerror_to_errno): Likewise.
2293
2294 * w32.h (emacs_gnutls_pull): Add prototype.
2295 (emacs_gnutls_push): Likewise.
2296
2297 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2298 (emacs_gnutls_push): Likewise.
2299
2300 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2301
2302 * process.c (wait_reading_process_output): Check if GnuTLS
2303 buffered some data internally if no FDs are set for TLS
2304 connections.
2305
2306 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2307 (LIBS): Link to USER_LIBS.
2308 ($(BLD)/gnutls.$(0)): New target.
2309
2310 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2311
2312 * xdisp.c (handle_single_display_spec): Rename the
2313 display_replaced_before_p argument into display_replaced_p, to
2314 make it consistent with the commentary. Fix typos in the
2315 commentary.
2316
2317 * textprop.c (syms_of_textprop): Remove dead code.
2318 (copy_text_properties): Delete obsolete commentary about an
2319 interface that was deleted long ago. Fix typos in the description
2320 of arguments.
2321
2322 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2323 to changes in oldXMenu/XMenu.h from 2011-04-16.
2324 <menu_help_message, prev_menu_help_message>: Constify.
2325 (IT_menu_make_room): menu->help_text is now `const char **';
2326 adjust.
2327
2328 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2329 to changes in oldXMenu/XMenu.h from 2011-04-16.
2330 (struct XMenu): Declare `help_text' `const char **'.
2331
2332 * xfaces.c <Qunspecified>: Make extern again.
2333
2334 * syntax.c: Include sys/types.h before including regex.h, as
2335 required by Posix.
2336
2337 * doc.c (get_doc_string): Improve the format passed to `error'.
2338
2339 * doprnt.c (doprnt): Improve commentary.
2340
2341 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2342
2343 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2344 them with etags.
2345
2346 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2347 changes in globals.h immediately force recompilation.
2348 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2349 $(CURDIR)/s/ms-w32.h.
2350 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2351
2352 * character.c (Fchar_direction): Function deleted.
2353 (syms_of_character): Don't defsubr it.
2354 <char-direction-table>: Deleted.
2355
2356 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2357
2358 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2359 * doprnt.c: Include limits.h.
2360 (SIZE_MAX): New macro.
2361 (doprnt): Return a size_t value. 2nd arg is now size_t.
2362 Many local variables are now size_t instead of int or unsigned.
2363 Improve overflow protection. Support `l' modifier for integer
2364 conversions. Support %l conversion. Don't assume an EMACS_INT
2365 argument for integer conversions and for %c.
2366
2367 * lisp.h (doprnt): Restore prototype.
2368
2369 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2370 $(SRC)/character.h.
2371
2372 * Makefile.in (base_obj): Add back doprnt.o.
2373
2374 * deps.mk (doprnt.o): Add back prerequisites.
2375 (callint.o): Depend on character.h.
2376
2377 * eval.c (internal_lisp_condition_case): Include the handler
2378 representation in the error message.
2379 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2380 when breaking from the loop.
2381
2382 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2383
2384 * callint.c (Fcall_interactively): When displaying error message
2385 about invalid control letter, pass the character's codepoint, not
2386 a pointer to its multibyte form. Improve display of the character
2387 in octal and display also its hex code.
2388
2389 * character.c (char_string): Use %x to display the (unsigned)
2390 codepoint of an invalid character, to avoid displaying a bogus
2391 negative value.
2392
2393 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2394 `error', not SYMBOL_NAME itself.
2395
2396 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2397 character arguments to `error'.
2398
2399 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2400 to `error' in error message about FINAL_CHAR argument. Make sure
2401 FINAL_CHAR is a character, and use %c when it is passed as
2402 argument to `error'.
2403
2404 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2405
2406 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2407
2408 * w32.c: Include <time.h>.
2409 (sys_localtime): New function.
2410
2411 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2412
2413 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2414
2415 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2416
2417 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2418
2419 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2420 zombies (Bug#8467).
2421
2422 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2423
2424 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2425 gl_state.e_property when gl_state.object is Qt.
2426
2427 * insdel.c (make_gap_larger): Remove limitation of buffer size
2428 to <= INT_MAX.
2429
2430 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2431
2432 * xdisp.c (lookup_glyphless_char_display)
2433 (produce_glyphless_glyph): Handle cons cell entry in
2434 glyphless-char-display.
2435 (Vglyphless_char_display): Document it.
2436
2437 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2438 glyphless-char-display.
2439
2440 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2441
2442 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2443
2444 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2445
2446 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2447 definition for no-X builds.
2448
2449 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2450
2451 Static checks with GCC 4.6.0 and non-default toolkits.
2452
2453 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2454
2455 * process.c (keyboard_bit_set): Define only if SIGIO.
2456 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2457 (send_process): Repair possible setjmp clobbering.
2458
2459 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2460
2461 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2462
2463 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2464
2465 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2466 Define only if needed.
2467
2468 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2469 by pacifying GCC about it. Maybe it's time to retire it?
2470 * xfaces.c (USG, __TIMEVAL__): Likewise.
2471
2472 * dispextern.h (struct redisplay_interface): Rename param
2473 to avoid shadowing.
2474 * termhooks.h (struct terminal): Likewise.
2475 * xterm.c (xembed_send_message): Likewise.
2476
2477 * insdel.c (make_gap_smaller): Define only if
2478 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2479
2480 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2481 it.
2482
2483 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2484 so that we aren't warned about unused symbols.
2485
2486 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2487
2488 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2489
2490 * xfns.c (x_real_positions): Mark locals as initialized.
2491
2492 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2493
2494 * xterm.c: Fix problems found by static analysis with other toolkits.
2495 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2496 (x_dispatch_event): Declare static if USE_GTK, and
2497 define if USE_GTK || USE_X_TOOLKIT.
2498 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2499 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2500 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2501 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2502
2503 * xmenu.c (menu_help_callback): Pointer type fixes.
2504 Use const pointers when pointing at readonly data. Avoid pointer
2505 signedness clashes.
2506 (FALSE): Remove unused macro.
2507 (update_frame_menubar): Remove unused decl.
2508
2509 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2510
2511 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2512 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2513 (single_menu_item): Rename local to avoid shadowing.
2514
2515 * keyboard.c (make_lispy_event): Remove unused local var.
2516
2517 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2518 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2519
2520 * bitmaps: Change bitmaps from unsigned char back to the X11
2521 compatible char. Avoid the old compiler warnings about
2522 out-of-range initializers by using, for example, '\xab' rather
2523 than 0xab.
2524
2525 * xgselect.c (xgselect_initialize): Check vs interface
2526 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2527
2528 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2529
2530 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2531 to read-only memory.
2532
2533 * fns.c (vector): Remove; this old hack is no longer needed.
2534
2535 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2536 Remove unused var.
2537 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2538
2539 * xrdb.c (x_load_resources): Omit unused local.
2540
2541 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2542 (x_window): Rename locals to avoid shadowing.
2543 (USG): Use the kludged USG macro, to pacify gcc.
2544
2545 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2546 (x_term_init): Remove local to avoid shadowing.
2547
2548 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2549
2550 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2551 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2552
2553 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2554
2555 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2556
2557 Fix regex.c, syntax.c and friends for buffers > 2GB.
2558 * syntax.h (struct gl_state_s): Declare character position members
2559 EMACS_INT.
2560
2561 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2562
2563 * textprop.c (verify_interval_modification, interval_of):
2564 Declare arguments EMACS_INT.
2565
2566 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2567 EMACS_INT.
2568
2569 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2570
2571 * indent.c (Fvertical_motion): Local variable it_start is now
2572 EMACS_INT.
2573
2574 * regex.c (re_match, re_match_2, re_match_2_internal)
2575 (bcmp_translate, regcomp, regexec, print_double_string)
2576 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2577 (re_compile_pattern, re_exec): Declare arguments and local
2578 variables `size_t' and `ssize_t' and return values `regoff_t', as
2579 appropriate.
2580 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2581 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2582 <compile_stack_type>: `size' and `avail' are now `size_t'.
2583
2584 * regex.h <regoff_t>: Use ssize_t, not int.
2585 (re_search, re_search_2, re_match, re_match_2): Arguments that
2586 specify buffer/string position and length are now ssize_t and
2587 size_t. Return type is regoff_t.
2588
2589 2011-04-16 Ben Key <bkey76@gmail.com>
2590
2591 * nsfont.m: Fixed bugs in ns_get_family and
2592 ns_descriptor_to_entity that were caused by using free to
2593 deallocate memory blocks that were allocated by xmalloc (via
2594 xstrdup). This caused Emacs to crash when compiled with
2595 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2596 --enable-checking=xmallocoverrun). xfree is now used to
2597 deallocate these memory blocks.
2598
2599 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2602
2603 emacs_write: Accept and return EMACS_INT for sizes.
2604 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2605 et seq.
2606 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2607 Accept and return EMACS_INT.
2608 (emacs_gnutls_write): Return the number of bytes written on
2609 partial writes.
2610 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2611 (emacs_read, emacs_write): Remove check for negative size, as the
2612 Emacs source code has been audited now.
2613 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2614 (emacs_read, emacs_write): Use it.
2615 * process.c (send_process): Adjust to the new signatures of
2616 emacs_write and emacs_gnutls_write. Do not attempt to store
2617 a byte offset into an 'int'; it might overflow.
2618 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2619
2620 * sound.c: Don't assume sizes fit in 'int'.
2621 (struct sound_device.period_size, alsa_period_size):
2622 Return EMACS_INT, not int.
2623 (struct sound_device.write, vox_write, alsa_write):
2624 Accept EMACS_INT, not int.
2625 (wav_play, au_play): Use EMACS_INT to store sizes and to
2626 record read return values.
2627
2628 2011-04-15 Ben Key <bkey76@gmail.com>
2629
2630 * keyboard.c (Qundefined): Don't declare static since it is used
2631 in nsfns.m.
2632 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2633 static since they are used in nsfont.m.
2634
2635 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2636
2637 * process.c (Qprocessp): Don't declare static.
2638 * lisp.h (Qprocessp): Declare again.
2639
2640 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2641
2642 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2643
2644 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2645
2646 Improve C-level modularity by making more things 'static'.
2647
2648 Don't publish debugger-only interfaces to other modules.
2649 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2650 (verify_bytepos, count_markers): Move decls to the only modules
2651 that need them.
2652 * region-cache.h (pp_cache): Likewise.
2653 * window.h (check_all_windows): Likewise.
2654 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2655
2656 * sysdep.c (croak): Now static, if
2657 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2658 * syssignal.h (croak): Declare only if not static.
2659
2660 * alloc.c (refill_memory_reserve): Now static if
2661 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2662 * lisp.h (refill_memory_reserve): Declare only if not static.
2663
2664 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2665 Define only if USE_LUCID.
2666
2667 * xrdb.c (x_customization_string, x_rm_string): Now static.
2668
2669 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2670 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2671
2672 * xdisp.c (draw_row_with_mouse_face): Now static.
2673 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2674
2675 * window.h (check_all_windows): Mark externally visible.
2676
2677 * window.c (window_deletion_count): Now static.
2678
2679 * undo.c: Make symbols static if they're not exported.
2680 (last_undo_buffer, last_boundary_position, pending_boundary):
2681 Now static.
2682
2683 * textprop.c (interval_insert_behind_hooks): Now static.
2684 (interval_insert_in_front_hooks): Likewise.
2685
2686 * term.c: Make symbols static if they're not exported.
2687 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2688 (max_frame_lines, tty_set_terminal_modes):
2689 (tty_reset_terminal_modes, tty_turn_off_highlight):
2690 (get_tty_terminal): Now static.
2691 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2692 * termhooks.h (term_mouse_moveto): Do not declare if
2693 HAVE_WINDOW_SYSTEM.
2694 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2695 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2696
2697 * sysdep.c: Make symbols static if they're not exported.
2698 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2699 Now static.
2700 (sigprocmask_set, full_mask): Remove; unused.
2701 (wait_debugging): Mark as visible.
2702 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2703 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2704
2705 * syntax.c (syntax_temp): Define only if !__GNUC__.
2706
2707 * sound.c (current_sound_device, current_sound): Now static.
2708
2709 * search.c (searchbufs, searchbuf_head): Now static.
2710
2711 * scroll.c (scroll_cost): Remove; unused.
2712 * dispextern.h (scroll_cost): Remove decl.
2713
2714 * region-cache.h (pp_cache): Mark as externally visible.
2715
2716 * process.c: Make symbols static if they're not exported.
2717 (process_tick, update_tick, create_process, chan_process):
2718 (Vprocess_alist, proc_buffered_char, datagram_access):
2719 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2720 (deactivate_process): Mark defn as static, as well as decl.
2721 * lisp.h (create_process): Remove decl.
2722 * process.h (chan_process, Vprocess_alist): Remove decls.
2723
2724 * print.c: Make symbols static if they're not exported.
2725 (print_depth, new_backquote_output, being_printed, print_buffer):
2726 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2727 (print_interval, print_number_index, initial_stderr_stream):
2728 Now static.
2729 * lisp.h (Fprinc): Remove decl.
2730 (debug_output_compilation_hack): Mark as externally visible.
2731
2732 * sysdep.c (croak): Move decl from here to syssignal.h.
2733 * syssignal.h (croak): Put it here, so the API can be checked when
2734 'croak' is called from dissociate_if_controlling_tty.
2735
2736 * minibuf.c: Make symbols static if they're not exported.
2737 (minibuf_save_list, choose_minibuf_frame): Now static.
2738 * lisp.h (choose_minibuf_frame): Remove decl.
2739
2740 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2741
2742 * lread.c: Make symbols static if they're not exported.
2743 (read_objects, initial_obarray, oblookup_last_bucket_number):
2744 Now static.
2745 (make_symbol): Remove; unused.
2746 * lisp.h (initial_obarray, make_symbol): Remove decls.
2747
2748 * keyboard.c: Make symbols static if they're not exported.
2749 (single_kboard, recent_keys_index, total_keys, recent_keys):
2750 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2751 (this_single_command_key_start, echoing, last_auto_save):
2752 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2753 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2754 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2755 (Vlispy_mouse_stem, double_click_count):
2756 Now static.
2757 (force_auto_save_soon): Define only if SIGDANGER.
2758 (ignore_mouse_drag_p): Now static if
2759 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2760 (print_help): Remove; unused.
2761 (stop_character, last_timer_event): Mark as externally visible.
2762 * keyboard.h (ignore_mouse_drag_p): Declare only if
2763 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2764 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2765 * lisp.h (echoing): Remove decl.
2766 (force_auto_save_soon): Declare only if SIGDANGER.
2767 * xdisp.c (redisplay_window): Simplify code, to make it more
2768 obvious that ignore_mouse_drag_p is not accessed if !defined
2769 USE_GTK && !defined HAVE_NS.
2770
2771 * intervals.c: Make symbols static if they're not exported.
2772 (merge_properties_sticky, merge_interval_right, delete_interval):
2773 Now static.
2774 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2775
2776 * insdel.c: Make symbols static if they're not exported.
2777 However, leave prepare_to_modify_buffer alone. It's never
2778 called from outside this function, but that appears to be a bug.
2779 (combine_after_change_list, combine_after_change_buffer):
2780 (adjust_after_replace, signal_before_change): Now static.
2781 (adjust_after_replace_noundo): Remove; unused.
2782 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2783 (signal_before_change): Remove decls.
2784
2785 * indent.c (val_compute_motion, val_vmotion): Now static.
2786
2787 * image.c: Make symbols static if they're not exported.
2788 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2789 if USE_GTK.
2790 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2791 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2792
2793 * fringe.c (standard_bitmaps): Now static.
2794 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2795
2796 * frame.c: Make symbols static if they're not exported.
2797 (x_report_frame_params, make_terminal_frame): Now static.
2798 (get_frame_param): Now static, unless HAVE_NS.
2799 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2800 (x_get_resource_string): Remove; not used.
2801 * frame.h (make_terminal_frame, x_report_frame_params):
2802 (x_get_resource_string); Remove decls.
2803 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2804 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2805
2806 * font.c, fontset.c: Make symbols static if they're not exported.
2807 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2808 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2809 * font.c (font_close_object): Now static.
2810 * font.h (font_close_object): Remove.
2811 * fontset.c (FONTSET_OBJLIST): Remove.
2812 (free_realized_fontset) #if-0 the body, which does nothing.
2813 (face_suitable_for_char_p): #if-0, as it's never called.
2814 * fontset.h (face_suitable_for_char_p): Remove decl.
2815 * xfaces.c (face_at_string_position):
2816 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2817 since 0 is always ASCII.
2818
2819 * fns.c (weak_hash_tables): Now static.
2820
2821 * fileio.c: Make symbols static if they're not exported.
2822 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2823 (Vwrite_region_annotation_buffers): Now static.
2824
2825 * eval.c: Make symbols static if they're not exported.
2826 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2827 * lisp.h (backtrace_list): Remove decl.
2828
2829 * emacs.c: Make symbols static if they're not exported.
2830 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2831 (fatal_error_code, fatal_error_signal_hook, standard_args):
2832 Now static.
2833 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2834 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2835 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2836 * lisp.h (fatal_error_signal_hook): Remove decl.
2837 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2838
2839 * editfns.c: Move a (normally-unused) function to its only use.
2840 * editfns.c, lisp.h (get_operating_system_release): Remove.
2841 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2842 worth the hassle of breaking this out.
2843
2844 * xterm.c: Make symbols static if they're not exported.
2845 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2846 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2847 (x_destroy_window, x_delete_display):
2848 Now static.
2849 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2850 (x_mouse_leave): Remove; unused.
2851 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2852 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2853 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2854 Remove decls.
2855 (x_mouse_leave): Declare only if WINDOWSNT.
2856 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2857 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2858 USE_X_TOOLKIT.
2859
2860 * ftxfont.c: Make symbols static if they're not exported.
2861 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2862 HAVE_FREETYPE.
2863 * font.h (ftxfont_driver): Likewise.
2864
2865 * xfns.c: Make symbols static if they're not exported.
2866 (x_last_font_name, x_display_info_for_name):
2867 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2868 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2869 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2870 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2871 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2872 (last_show_tip_args): Now static.
2873 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2874 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2875 (x_screen_planes): Remove; unused.
2876 * dispextern.h (x_screen_planes): Remove decl.
2877
2878 * dispnew.c: Make symbols static if they're not exported.
2879 * dispextern.h (redraw_garbaged_frames, scrolling):
2880 (increment_row_positions): Remove.
2881 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2882 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2883 Now static.
2884 (redraw_garbaged_frames): Remove; unused.
2885
2886 * xfaces.c: Make symbols static if they're not exported.
2887 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2888 Remove decls.
2889 * xterm.h (defined_color): Remove decls.
2890 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2891 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2892 (menu_face_changed_default, defined_color, free_realized_face):
2893 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2894 (ascii_face_of_lisp_face): Remove; unused.
2895
2896 * xdisp.c: Make symbols static if they're not exported.
2897 * dispextern.h (scratch_glyph_row, window_box_edges):
2898 (glyph_to_pixel_coords, set_cursor_from_row):
2899 (get_next_display_element, set_iterator_to_next):
2900 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2901 (show_mouse_face): Remove decls
2902 * frame.h (message_buf_print): Likewise.
2903 * lisp.h (pop_message, set_message, check_point_in_composition):
2904 Likewise.
2905 * xterm.h (set_vertical_scroll_bar): Likewise.
2906 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2907 (message_buf_print, scratch_glyph_row, displayed_buffer):
2908 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2909 (get_next_display_element, show_mouse_face, window_box_edges):
2910 (frame_to_window_pixel_xy, check_point_in_composition):
2911 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2912 (glyph_to_pixel_coords): Remove; unused.
2913
2914 * dired.c (file_name_completion): Now static.
2915
2916 * dbusbind.c (xd_in_read_queued_messages): Now static.
2917
2918 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2919 * data.c (circular_list_error): Remove.
2920
2921 * commands.h (last_point_position, last_point_position_buffer):
2922 (last_point_position_window): Remove decls.
2923 * keyboard.c: Make these variables static.
2924
2925 * coding.h (coding, code_convert_region, encode_coding_gap):
2926 Remove decls.
2927 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2928 (iso_code_class, detect_coding, code_convert_region): Now static.
2929 (encode_coding_gap): Remove; unused.
2930
2931 * chartab.c (chartab_chars, chartab_bits): Now static.
2932
2933 * charset.h (charset_iso_8859_1): Remove decl.
2934 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2935 Now static.
2936
2937 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2938 * ccl.c (Vccl_program_table): Now static.
2939 (check_ccl_update): Remove; unused.
2940
2941 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2942 * category.h: ... from here.
2943 * category.c (check_category_table, set_category_set): Now static.
2944
2945 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2946 * lisp.h: Remove these decls.
2947
2948 * buffer.c (buffer_count): Remove unused var.
2949
2950 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2951 so that it's not optimized away.
2952 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2953 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2954 exported only to the debugger.
2955
2956 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2957 * atimer.h (run_all_atimers): Remove; not exported.
2958
2959 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2960 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2961 was inaccessible from Lisp.
2962 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2963 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2964
2965 alloc.c: Import and export fewer symbols, and remove unused items.
2966 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2967 is defined.
2968 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2969 it's not optimized away by whole-program optimization.
2970 (message_enable_multibyte, free_misc): Remove.
2971 (catchlist, handlerlist, mark_backtrace):
2972 Declare only if BYTE_MARK_STACK.
2973 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2974 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2975 (message_enable_multibyte): Remove decl.
2976 (free_misc, interval_free_list, float_block, float_block_index):
2977 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2978 (cons_free_list, last_marked_index):
2979 Now static.
2980 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2981 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2982 (mark_backtrace): Define only if BYTE_MARK_STACK.
2983 * xdisp.c (message_enable_multibyte): Now static.
2984
2985 Declare Lisp_Object Q* variables to be 'static' if not exported.
2986 This makes it easier for human readers (and static analyzers)
2987 to see whether these variables are used from other modules.
2988 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2989 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2990 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2991 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2992 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2993 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2994 * xmenu.c, xselect.c:
2995 Declare Q* vars static if they are not used in other modules.
2996 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2997 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2998 Remove decls of unexported vars.
2999 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3000
3001 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3002
3003 Make Emacs functions such as Fatom 'static' by default.
3004 This makes it easier for human readers (and static analyzers)
3005 to see whether these functions can be called from other modules.
3006 DEFUN now defines a static function. To make the function external
3007 so that it can be used in other C modules, use the new macro DEFUE.
3008 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3009 (Finit_image_library):
3010 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3011 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3012 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3013 Remove decls, since these functions are now static.
3014 (Funintern, Fget_internal_run_time): New decls, since these functions
3015 were already external.
3016
3017 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3018 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3019 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3020 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3021 * keyboard.c, keymap.c, lread.c:
3022 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3023 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3024 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3025 Mark functions with DEFUE instead of DEFUN,
3026 if they are used in other modules.
3027 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3028 decls for now-static functions.
3029 * buffer.h (Fdelete_overlay): Remove decl.
3030 * callproc.c (Fgetenv_internal): Mark as internal.
3031 * composite.c (Fremove_list_of_text_properties): Remove decl.
3032 (Fcomposition_get_gstring): New forward static decl.
3033 * composite.h (Fcomposite_get_gstring): Remove decl.
3034 * dired.c (Ffile_attributes): New forward static decl.
3035 * doc.c (Fdocumntation_property): New forward static decl.
3036 * eval.c (Ffetch_bytecode): New forward static decl.
3037 (Funintern): Remove extern decl; now in .h file where it belongs.
3038 * fileio.c (Fmake_symbolic_link): New forward static decl.
3039 * image.c (Finit_image_library): New forward static decl.
3040 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3041 * intervals.h (Fprevious_property_change):
3042 (Fremove_list_of_text_properties): Remove decls.
3043 * keyboard.c (Fthis_command_keys): Remove decl.
3044 (Fcommand_execute): New forward static decl.
3045 * keymap.c (Flookup_key): New forward static decl.
3046 (Fcopy_keymap): Now static.
3047 * keymap.h (Flookup_key): Remove decl.
3048 * process.c (Fget_process): New forward static decl.
3049 (Fprocess_datagram_address): Mark as internal.
3050 * syntax.c (Fsyntax_table_p): New forward static decl.
3051 (skip_chars): Remove duplicate decl.
3052 * textprop.c (Fprevious_property_change): New forward static decl.
3053 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3054 Now internal.
3055 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3056 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3057
3058 * editfns.c (Fformat): Remove unreachable code.
3059
3060 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3061
3062 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3063 change. (Bug#8496)
3064
3065 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3066
3067 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3068 when at ZV. (Bug#8487)
3069
3070 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3071
3072 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3073 (Bug#8437)
3074 * keyboard.c (parse_tool_bar_item): Likewise.
3075 * sound.c (sound_cleanup, alsa_close): Likewise.
3076 * termcap.c (tgetent): Likewise.
3077 * xfns.c (x_default_font_parameter): Likewise.
3078 * xsettings.c (read_and_apply_settings): Likewise.
3079
3080 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3081 (overrun_check_free): Protoize.
3082
3083 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3084
3085 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3086 since callers should never pass a negative size.
3087 Change the signature to match that of plain 'read' and 'write'; see
3088 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3089 * lisp.h: Update prototypes of emacs_write and emacs_read.
3090
3091 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3092
3093 * xdisp.c (redisplay_window): Don't try to determine the character
3094 position of the scroll margin if the window start point w->startp
3095 is outside the buffer's accessible region. (Bug#8468)
3096
3097 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3098
3099 Fix write-region and its subroutines for buffers > 2GB.
3100 * fileio.c (a_write, e_write): Modify declaration of arguments and
3101 local variables to support buffers larger than 2GB.
3102 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3103
3104 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3105 argument, local variables, and return value.
3106
3107 * lisp.h: Update prototypes of emacs_write and emacs_read.
3108
3109 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3110
3111 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3112
3113 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3114
3115 Fix more problems found by GCC 4.6.0's static checks.
3116
3117 * xdisp.c (vmessage): Use a better test for character truncation.
3118
3119 * charset.c (load_charset_map): <, not <=, for optimization,
3120 and to avoid potential problems with integer overflow.
3121 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3122 * casetab.c (set_identity, shuffle): Likewise.
3123 * editfns.c (Fformat): Likewise.
3124 * syntax.c (skip_chars): Likewise.
3125
3126 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3127 This also lets GCC 4.6.0 generate slightly better loop code.
3128
3129 * callint.c (Fcall_interactively): <, not <=, for optimization.
3130 (Fcall_interactively): Count the number of arguments produced,
3131 not the number of arguments given. This is simpler and lets GCC
3132 4.6.0 generate slightly better code.
3133
3134 * ftfont.c: Distingish more carefully between FcChar8 and char.
3135 The previous code passed unsigned char * to a functions like
3136 strlen and xstrcasecmp that expect char *, which does not
3137 conform to the C standard.
3138 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3139 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3140 char * when the C standard requires it.
3141
3142 * keyboard.c (read_char): Remove unused var.
3143
3144 * eval.c: Port to Windows vsnprintf (Bug#8435).
3145 Include <limits.h>.
3146 (SIZE_MAX): Define if the headers do not.
3147 (verror): Do not give up if vsnprintf returns a negative count.
3148 Instead, grow the buffer. This ports to Windows vsnprintf, which
3149 does not conform to C99. Problem reported by Eli Zaretskii.
3150 Also, simplify the allocation scheme, by avoiding the need for
3151 calling realloc, and removing the ALLOCATED variable.
3152
3153 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3154
3155 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3156 But keep the doprint source code for now, as we might revamp it
3157 and use it again (Bug#8435).
3158 * lisp.h (doprnt): Remove.
3159 * Makefile.in (base_obj): Remove doprnt.o.
3160 * deps.mk (doprnt.o): Remove.
3161
3162 error: Print 32- and 64-bit integers portably (Bug#8435).
3163 Without this change, on typical 64-bit hosts error ("...%d...", N)
3164 was used to print both 32- and 64-bit integers N, which relied on
3165 undefined behavior.
3166 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3167 New macro.
3168 * lisp.h (error, verror): Mark as printf-like functions.
3169 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3170 Report overflow in size calculations when allocating printf buffer.
3171 Do not truncate output string at its first null byte.
3172 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3173 Truncate the output at a character boundary, since vsnprintf does not
3174 do that.
3175 * charset.c (check_iso_charset_parameter): Convert internal
3176 character to string before calling 'error', since %c now has the
3177 printf meaning.
3178 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3179 overflow when computing char to be passed to 'error'. Do not
3180 pass Lisp_Object to 'error'; pass the integer instead.
3181 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3182 formatted with plain %d.
3183
3184 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3185
3186 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3187
3188 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3189
3190 * xterm.c (x_catch_errors): Remove duplicate declaration.
3191
3192 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3193
3194 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3195
3196 2011-04-10 Jim Meyering <meyering@redhat.com>
3197
3198 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3199 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3200 return ssize_t not "int", and use size_t as the buffer length.
3201 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3202 * gnutls.h: Update declarations.
3203 * process.c (read_process_output): Use ssize_t, to match.
3204 (send_process): Likewise.
3205
3206 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3207
3208 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3209
3210 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3211
3212 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3213 Use unsigned char, to match FcChar8 type definition.
3214
3215 * xterm.c (handle_one_xevent):
3216 * xmenu.c (create_and_show_popup_menu):
3217 * xselect.c (x_decline_selection_request)
3218 (x_reply_selection_request): Avoid type-punned deref of X events.
3219
3220 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3221
3222 Fix some uses of `int' instead of EMACS_INT.
3223 * search.c (string_match_1, fast_string_match)
3224 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3225 (scan_buffer, find_next_newline_no_quit)
3226 (find_before_next_newline, search_command, Freplace_match)
3227 (Fmatch_data): Make some `int' variables be EMACS_INT.
3228
3229 * xdisp.c (display_count_lines): 3rd argument and return value now
3230 EMACS_INT. All callers changed.
3231 (pint2hrstr): Last argument is now EMACS_INT.
3232
3233 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3234 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3235 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3236 (decode_coding_utf_16, decode_coding_emacs_mule)
3237 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3238 (decode_coding_ccl, decode_coding_charset)
3239 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3240 (decode_coding_iso_2022, decode_coding_emacs_mule)
3241 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3242 <char_offset, last_offset>: Declare EMACS_INT.
3243 (encode_coding_utf_8, encode_coding_utf_16)
3244 (encode_coding_emacs_mule, encode_invocation_designation)
3245 (encode_designation_at_bol, encode_coding_iso_2022)
3246 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3247 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3248 Declare EMACS_INT.
3249 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3250 (encode_invocation_designation): Last argument P_NCHARS is now
3251 EMACS_INT.
3252 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3253 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3254
3255 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3256 All users changed.
3257
3258 * ccl.c (Fccl_execute_on_string): Declare some variables
3259 EMACS_INT.
3260
3261 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3262
3263 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3264
3265 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3266
3267 * process.c (Fformat_network_address): Doc fix.
3268
3269 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3270
3271 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3272
3273 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3274
3275 * keyboard.c (read_char): Call Lisp function help-form-show,
3276 instead of using internal_with_output_to_temp_buffer.
3277 (Qhelp_form_show): New var.
3278 (syms_of_keyboard): Use DEFSYM macro.
3279
3280 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3281
3282 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3283
3284 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3285
3286 * process.c (Flist_processes): Remove to Lisp.
3287 (list_processes_1): Delete.
3288
3289 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3290
3291 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3292
3293 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3294
3295 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3296
3297 Fix more problems found by GCC 4.6.0's static checks.
3298
3299 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3300
3301 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3302
3303 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3304
3305 * xdisp.c (vmessage): Mark as a printf-like function.
3306
3307 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3308
3309 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3310
3311 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3312 printf-like functions.
3313 (tiff_load): Add casts to remove these marks before passing them
3314 to system-supplied API.
3315
3316 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3317
3318 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3319 This avoids several warnings with gcc -Wstrict-overflow.
3320 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3321 directly, rather than having caller test rule sign. This avoids
3322 some unnecessary tests.
3323 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3324 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3325 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3326
3327 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3328 (xfont_open): Avoid unnecessary tests.
3329
3330 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3331
3332 * composite.h, composite.c (composition_gstring_put_cache):
3333 Use EMACS_INT, not int, for length.
3334
3335 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3336 breaking out part of COMPOSITION_DECODE_RULE.
3337 (COMPOSITION_DECODE_RULE): Use it.
3338 * composite.c (get_composition_id): Remove unused local vars,
3339 by using the new macro.
3340
3341 * textprop.c (set_text_properties_1): Change while to do-while,
3342 since the condition is always true at first.
3343
3344 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3345 (interval_deletion_adjustment): Return unsigned value.
3346 All uses changed.
3347
3348 * process.c (list_processes_1, create_pty, read_process_output):
3349 (exec_sentinel): Remove vars that were set but not used.
3350 (create_pty): Remove unnecessary "volatile"s.
3351 (Fnetwork_interface_info): Avoid possibility of int overflow.
3352 (read_process_output): Do adaptive read buffering even if carryover.
3353 (read_process_output): Simplify nbytes computation if buffered.
3354
3355 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3356
3357 * syntax.c (scan_words): Remove var that was set but not used.
3358 (update_syntax_table): Use unsigned instead of int.
3359
3360 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3361 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3362 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3363
3364 * print.c (print_error_message): Avoid int overflow.
3365
3366 * font.c (font_list_entities): Redo for clarity,
3367 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3368
3369 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3370 (font_score): Avoid potential overflow in diff calculation.
3371
3372 * fns.c (substring_both): Remove var that is set but not used.
3373 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3374
3375 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3376
3377 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3378 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3379 can always succeed if overflow has undefined behavior.
3380
3381 * search.c (boyer_moore, wordify): Remove vars set but not used.
3382 (wordify): Omit three unnecessary tests.
3383
3384 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3385 All callers changed. This avoids the need for an unused var.
3386
3387 * casefiddle.c (casify_region): Remove var that is set but not used.
3388
3389 * dired.c (file_name_completion): Remove var that is set but not used.
3390
3391 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3392
3393 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3394 (Finsert_file_contents): Remove unnecessary code checking fd.
3395
3396 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3397 Check for integer overflow on size calculations.
3398
3399 * buffer.c (Fprevious_overlay_change): Remove var that is set
3400 but not used.
3401
3402 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3403 Remove vars that are set but not used.
3404 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3405 (timer_check_2): Mark vars as initialized.
3406
3407 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3408
3409 * image.c (lookup_image): Remove var that is set but not used.
3410 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3411
3412 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3413 that are set but not used.
3414
3415 * xfns.c (make_invisible_cursor): Don't return garbage
3416 if XCreateBitmapFromData fails (Bug#8410).
3417
3418 * xselect.c (x_get_local_selection, x_handle_property_notify):
3419 Remove vars that are set but not used.
3420
3421 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3422 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3423
3424 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3425 Remove var that is set but not used.
3426 (scroll_bar_windows_size): Now size_t, not int.
3427 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3428 Check for overflow.
3429
3430 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3431 (map_tty_color) [!defined MSDOS]: Likewise.
3432
3433 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3434
3435 * coding.c: Remove vars that are set but not used.
3436 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3437 All callers changed.
3438 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3439 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3440 (decode_coding_charset): Remove vars that are set but not used.
3441
3442 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3443 that is set but not used.
3444
3445 * print.c (print_object): Remove var that is set but not used.
3446
3447 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3448 The gnulib version avoids calling malloc in the usual case,
3449 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3450 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3451 * filelock.c (current_lock_owner): Likewise.
3452 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3453 * sysdep.c: Include allocator.h, careadlinkat.h.
3454 (emacs_no_realloc_allocator): New static constant.
3455 (emacs_readlink): New function.
3456 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3457 ../lib/careadlinkat.h.
3458
3459 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3460
3461 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3462 first non-nil return value).
3463
3464 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3465
3466 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3467 if not defined (Bug#8403).
3468
3469 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3470
3471 * xdisp.c (display_count_lines): Remove parameter `start',
3472 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3473 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3474 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3475 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3476 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3477 and thereabouts. All callers changed.
3478 (get_per_char_metric): Remove parameter `f', unused since
3479 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3480
3481 2011-04-02 Jim Meyering <meyering@redhat.com>
3482
3483 do not dereference NULL upon failed strdup
3484 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3485 (ns_get_family): Likewise.
3486
3487 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3488
3489 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3490
3491 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3492
3493 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3494 later (Bug#8403).
3495
3496 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3497
3498 Add lexical binding.
3499
3500 * window.c (Ftemp_output_buffer_show): New fun.
3501 (Fsave_window_excursion):
3502 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3503
3504 * lread.c (lisp_file_lexically_bound_p): New function.
3505 (Fload): Bind Qlexical_binding.
3506 (readevalloop): Remove `evalfun' arg.
3507 Bind Qinternal_interpreter_environment.
3508 (Feval_buffer): Bind Qlexical_binding.
3509 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3510 Mark as dynamic.
3511 (syms_of_lread): Declare `lexical-binding'.
3512
3513 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3514
3515 * keyboard.c (eval_dyn): New fun.
3516 (menu_item_eval_property): Use it.
3517
3518 * image.c (parse_image_spec): Use Ffunctionp.
3519
3520 * fns.c (concat, mapcar1): Accept byte-code-functions.
3521
3522 * eval.c (Fsetq): Handle lexical vars.
3523 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3524 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3525 (FletX, Flet): Obey lexical binding.
3526 (Fcommandp): Handle closures.
3527 (Feval): New `lexical' arg.
3528 (eval_sub): New function extracted from Feval. Use it almost
3529 everywhere where Feval was used. Look up vars in lexical env.
3530 Handle closures.
3531 (Ffunctionp): Move from subr.el.
3532 (Ffuncall): Handle closures.
3533 (apply_lambda): Remove `eval_flags'.
3534 (funcall_lambda): Handle closures and new byte-code-functions.
3535 (Fspecial_variable_p): New function.
3536 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3537 but without exporting it to Lisp.
3538
3539 * doc.c (Fdocumentation, store_function_docstring):
3540 * data.c (Finteractive_form): Handle closures.
3541
3542 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3543 interactive spec.
3544
3545 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3546 New byte-codes.
3547 (exec_byte_code): New function extracted from Fbyte_code to handle new
3548 calling convention for byte-code-functions. Add new byte-codes.
3549
3550 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3551
3552 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3553
3554 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3555
3556 * xdisp.c (redisplay_internal): Fix prototype.
3557
3558 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3559
3560 * xdisp.c (SCROLL_LIMIT): New macro.
3561 (try_scrolling): Use it when setting scroll_limit.
3562 Limit scrolling to 100 screen lines.
3563 (redisplay_window): Even when falling back on "recentering",
3564 position point in the window according to scroll-conservatively,
3565 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3566
3567 (try_scrolling): When point is above the window, allow searching
3568 as far as scroll_max, or one screenful, to compute vertical
3569 distance from PT to the scroll margin position. This prevents
3570 try_scrolling from unnecessarily failing when
3571 scroll-conservatively is set to a value slightly larger than the
3572 window height. Clean up the case of PT below the margin at bottom
3573 of window: scroll_max can no longer be INT_MAX. When aggressive
3574 scrolling is in use, don't let point enter the opposite scroll
3575 margin as result of the scroll.
3576 (syms_of_xdisp) <scroll-conservatively>: Document the
3577 threshold of 100 lines for never-recentering scrolling.
3578
3579 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3580
3581 * dispextern.h (move_it_by_lines):
3582 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3583 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3584 (message_log_check_duplicate): Remove parameters `prev_bol' and
3585 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3586 (redisplay_internal): Remove parameter `preserve_echo_area',
3587 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3588
3589 * indent.c (Fvertical_motion):
3590 * window.c (window_scroll_pixel_based, Frecenter):
3591 Don't pass `need_y_p' to `move_it_by_lines'.
3592
3593 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3594
3595 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3596 steal a few bits to be more compact.
3597 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3598 Remove unneeded casts.
3599
3600 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3601
3602 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3603
3604 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3605 binding" message (bug#7967).
3606
3607 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3608
3609 Fix more problems found by GCC 4.6.0's static checks.
3610
3611 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3612 Remove unused local var.
3613
3614 * editfns.c (Fmessage_box): Remove unused local var.
3615
3616 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3617 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3618 Omit unused local vars.
3619 * window.c (shrink_windows): Omit unused local var.
3620 * menu.c (digest_single_submenu): Omit unused local var.
3621 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3622 Omit unused local var.
3623
3624 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3625 Don't assume string length fits in int.
3626 (keyremap_step, read_key_sequence): Use size_t for sizes.
3627 (read_key_sequence): Don't check last_real_key_start redundantly.
3628
3629 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3630 instead of alloca (Bug#8344).
3631
3632 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3633 (Fbacktrace_frame): Don't assume nframes fits in int.
3634
3635 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3636
3637 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3638 concerns.
3639
3640 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3641
3642 * cm.c (calccost): Turn while-do into do-while, for clarity.
3643
3644 * keyboard.c (syms_of_keyboard): Use the same style as later
3645 in this function when indexing through an array. This also
3646 works around GCC bug 48267.
3647
3648 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3649
3650 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3651
3652 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3653 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3654
3655 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3656 This avoids undefined behavior on integer overflow, and is a bit
3657 more convenient anyway since it is compared to a size_t variable.
3658
3659 Variadic C functions now count arguments with size_t, not int.
3660 This avoids an unnecessary limitation on 64-bit machines, which
3661 caused (substring ...) to crash on large vectors (Bug#8344).
3662 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3663 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3664 All variadic functions and their callers changed accordingly.
3665 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3666 * data.c (arith_driver, float_arith_driver): Likewise.
3667 * editfns.c (general_insert_function): Likewise.
3668 * eval.c (struct backtrace.nargs, interactive_p)
3669 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3670 (funcall_lambda, mark_backtrace): Likewise.
3671 * fns.c (concat): Likewise.
3672 * frame.c (x_set_frame_parameters): Likewise.
3673 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3674 0 if not found, not -1. All callers changed.
3675
3676 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3677 (stack_copy_size): Now size_t, not int.
3678 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3679
3680 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3681
3682 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3683 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3684 All callers changed.
3685
3686 * lisp.h (multibyte_char_to_unibyte):
3687 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3688 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3689 * character.h (CHAR_TO_BYTE8):
3690 * cmds.c (internal_self_insert):
3691 * editfns.c (general_insert_function):
3692 * keymap.c (push_key_description):
3693 * search.c (Freplace_match):
3694 * xdisp.c (message_dolog, set_message_1): All callers changed.
3695
3696 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3697
3698 * keyboard.c (safe_run_hook_funcall): New function.
3699 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3700 don't set the hook to nil, but remove the offending function instead.
3701 (Qcommand_hook_internal): Remove, unused.
3702 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3703 Vcommand_hook_internal.
3704
3705 * eval.c (enum run_hooks_condition): Remove.
3706 (funcall_nil, funcall_not): New functions.
3707 (run_hook_with_args): Call each function through a `funcall' argument.
3708 Remove `cond' argument, now redundant.
3709 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3710 (Frun_hook_with_args_until_failure): Adjust accordingly.
3711 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3712
3713 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3714
3715 * dispextern.h (string_buffer_position): Remove declaration.
3716
3717 * print.c (strout): Remove parameter `multibyte', unused since
3718 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3719
3720 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3721 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3722 All callers changed.
3723
3724 * w32.c (_wsa_errlist): Use braces for struct initializers.
3725
3726 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3727 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3728 All callers changed.
3729 (string_buffer_position): Likewise. Also, make static (it's never
3730 used outside xdisp.c).
3731 (cursor_row_p): Remove parameter `w', unused since
3732 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3733 (decode_mode_spec): Remove parameter `precision', introduced during
3734 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3735 All callers changed.
3736
3737 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3738
3739 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3740
3741 2011-03-27 Anders Lindgren <andlind@gmail.com>
3742
3743 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3744 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3745 (ns_update_auto_hide_menu_bar): New functions.
3746 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3747 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3748 ns_constrain_all_frames.
3749 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3750 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3751
3752 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3753
3754 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3755
3756 2011-03-27 Glenn Morris <rgm@gnu.org>
3757
3758 * syssignal.h: Replace RETSIGTYPE with void.
3759 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3760 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3761 Replace SIGTYPE with void everywhere.
3762 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3763 * s/template.h (SIGTYPE): Remove commented out definition.
3764
3765 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3766
3767 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3768 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3769
3770 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3771
3772 * w32.c (read_unc_volume): Use parameter `henum', instead of
3773 global variable `wget_enum_handle'.
3774
3775 * keymap.c (describe_vector): Remove parameters `indices' and
3776 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3777 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3778
3779 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3780
3781 * keyboard.c (timer_check): Remove parameter `do_it_now',
3782 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3783 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3784 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3785
3786 * keyboard.c (read_char):
3787 * w32menu.c (w32_menu_display_help):
3788 * xmenu.c (show_help_event, menu_help_callback):
3789 Adjust calls to `show_help_echo'.
3790
3791 * gtkutil.c (xg_maybe_add_timer):
3792 * keyboard.c (readable_events):
3793 * process.c (wait_reading_process_output):
3794 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3795
3796 * insdel.c (adjust_markers_gap_motion):
3797 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3798 (gap_left, gap_right): Don't call it.
3799
3800 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3801
3802 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3803 incurred during fontification.
3804
3805 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3806
3807 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3808 (DEFVAR_PER_BUFFER): Don't pass it.
3809
3810 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3811 (scrolling_window): Don't pass it.
3812
3813 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3814
3815 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3816
3817 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3818 and `suffix'.
3819 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3820 of variables specific to SELinux and computation of `encoded_absname'.
3821
3822 * image.c (XPutPixel): Remove unused variable `height'.
3823
3824 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3825
3826 * unexw32.c (get_section_info): Remove unused variable `section'.
3827
3828 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3829 (system_process_attributes): Remove unused variable `sess'.
3830 (sys_read): Remove unused variable `err'.
3831
3832 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3833 (w32_wnd_proc): Remove unused variable `isdead'.
3834 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3835 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3836 (x_create_tip_frame): Remove unused variable `tem'.
3837
3838 * w32inevt.c (w32_console_read_socket):
3839 Remove unused variable `no_events'.
3840
3841 * w32term.c (x_draw_composite_glyph_string_foreground):
3842 Remove unused variable `width'.
3843
3844 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3845
3846 * w32term.c (x_set_glyph_string_clipping):
3847 Don't pass uninitialized region to CombineRgn.
3848
3849 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3850
3851 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3852 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3853 (Fx_close_connection): Remove unused variable `i'.
3854
3855 * w32font.c (w32font_draw): Return number of glyphs.
3856 (w32font_open_internal): Remove unused variable `i'.
3857 (w32font_driver): Add missing initializer.
3858
3859 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3860 (fill_in_menu): Remove unused variable `items_added'.
3861
3862 * w32term.c (last_mouse_press_frame): Remove static global variable.
3863 (w32_clip_to_row): Remove unused variable `f'.
3864 (x_delete_terminal): Remove unused variable `i'.
3865
3866 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3867 (NOTHING): Remove unused static global variable.
3868 (uniscribe_check_otf): Remove unused variable `table'.
3869 (uniscribe_font_driver): Add missing initializers.
3870
3871 2011-03-23 Julien Danjou <julien@danjou.info>
3872
3873 * term.c (Fsuspend_tty, Fresume_tty):
3874 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3875 * window.c (temp_output_buffer_show):
3876 * insdel.c (signal_before_change):
3877 * frame.c (Fhandle_switch_frame):
3878 * fileio.c (Fdo_auto_save):
3879 * emacs.c (Fkill_emacs):
3880 * editfns.c (save_excursion_restore):
3881 * cmds.c (internal_self_insert):
3882 * callint.c (Fcall_interactively):
3883 * buffer.c (Fkill_all_local_variables):
3884 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3885 Use Frun_hooks.
3886 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3887 unconditionnaly since it does the check itself.
3888
3889 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3890
3891 Fix more problems found by GCC 4.5.2's static checks.
3892
3893 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3894 the first time through the loop, since we know p0 < p1 then.
3895 This also avoids a gcc -Wstrict-overflow warning.
3896
3897 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3898 leading to a memory leak, possible in functions like
3899 load_charset_map_from_file that can allocate an unbounded number
3900 of objects (Bug#8318).
3901
3902 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3903 that could (at least in theory) be that large.
3904
3905 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3906 This is less likely to overflow, and avoids undefined behavior if
3907 overflow does occur. All callers changed. Use strtoul to scan
3908 for the unsigned long integer.
3909 (pint2hrstr): Simplify and tune code slightly.
3910 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3911
3912 * scroll.c (do_scrolling): Work around GCC bug 48228.
3913 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3914
3915 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3916 This also avoids a warning with gcc -Wstrict-overflow.
3917 (validate_x_resource_name): Simplify count usage.
3918 This also avoids a warning with gcc -Wstrict-overflow.
3919
3920 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3921 fail (Bug#8306).
3922
3923 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3924
3925 * process.c (Fmake_network_process): Use socklen_t, not int,
3926 where POSIX says socklen_t is required in portable programs.
3927 This fixes a porting bug on hosts like 64-bit HP-UX, where
3928 socklen_t is wider than int (Bug#8277).
3929 (Fmake_network_process, server_accept_connection):
3930 (wait_reading_process_output, read_process_output):
3931 Likewise.
3932
3933 * process.c: Rename or move locals to avoid shadowing.
3934 (list_processes_1, Fmake_network_process):
3935 (read_process_output_error_handler, exec_sentinel_error_handler):
3936 Rename or move locals.
3937 (Fmake_network_process): Define label "retry_connect" only if needed.
3938 (Fnetwork_interface_info): Fix pointer signedness.
3939 (process_send_signal): Add cast to avoid pointer signedness problem.
3940 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3941 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3942
3943 Make tparam.h and terminfo.c consistent.
3944 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3945 Include tparam.h instead, since it declares them.
3946 * cm.h (PC): Remove extern decl; tparam.h now does this.
3947 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3948 * terminfo.c: Include tparam.h, to check interfaces.
3949 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3950 (tparam): Adjust signature to match interface in tparam.h;
3951 this removes some undefined behavior. Check that outstring and len
3952 are zero, which they always are with Emacs.
3953 * tparam.h (PC, BC, UP): New extern decls.
3954
3955 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3956 (xftfont_open): Rename locals to avoid shadowing.
3957
3958 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3959 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3960 (OTF_TAG_SYM): Omit macro if not needed.
3961 (ftfont_list): Remove unused local.
3962 (get_adstyle_property, ftfont_pattern_entity):
3963 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3964 Rename locals to avoid shadowing.
3965
3966 * xfont.c (xfont_list_family): Mark var as initialized.
3967
3968 * xml.c (make_dom): Now static.
3969
3970 * composite.c (composition_compute_stop_pos): Rename local to
3971 avoid shadowing.
3972 (composition_reseat_it): Remove unused locals.
3973 (find_automatic_composition, composition_adjust_point): Likewise.
3974 (composition_update_it): Mark var as initialized.
3975 (find_automatic_composition): Mark vars as initialized,
3976 with a FIXME (Bug#8290).
3977
3978 character.h: Rename locals to avoid shadowing.
3979 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3980 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3981 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3982 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3983 to avoid shadowing.
3984
3985 * textprop.c (property_change_between_p): Remove; unused.
3986
3987 * intervals.c (interval_start_pos): Now static.
3988
3989 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3990
3991 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3992 Rename locals to avoid shadowing.
3993
3994 * sound.c (wav_play, au_play, Fplay_sound_internal):
3995 Fix pointer signedness.
3996 (alsa_choose_format): Remove unused local var.
3997 (wav_play): Initialize a variable to 0, to prevent undefined
3998 behavior (Bug#8278).
3999
4000 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4001
4002 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4003
4004 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4005 clobbering (Bug#8298).
4006 * sysdep.c (sys_subshell): Likewise.
4007 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4008
4009 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4010 This should get cleaned up, so that child_setup has the
4011 same signature on all platforms.
4012
4013 * callproc.c (call_process_cleanup): Now static.
4014 (relocate_fd): Rename locals to avoid shadowing.
4015
4016 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4017
4018 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4019 not to be necessary, and produces flickering.
4020
4021 2011-03-20 Glenn Morris <rgm@gnu.org>
4022
4023 * config.in: Remove file.
4024
4025 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4026
4027 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4028 are now in src/globals.h.
4029 (syms_of_minibuf): Remove spurious & from previous change.
4030
4031 2011-03-20 Leo <sdl.web@gmail.com>
4032
4033 * minibuf.c (completing-read-function): New variable.
4034 (completing-read-default): Rename from completing-read.
4035 (completing-read): Call completing-read-function.
4036
4037 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4038
4039 * xfaces.c (Fx_load_color_file):
4040 Read color file from absolute filename (bug#8250).
4041
4042 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4043
4044 * makefile.w32-in: Update dependencies.
4045
4046 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4047
4048 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4049
4050 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4051
4052 Fix more problems found by GCC 4.5.2's static checks.
4053
4054 * process.c (make_serial_process_unwind, send_process_trap):
4055 (sigchld_handler): Now static.
4056
4057 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4058 That way, the code declares only the vars that it needs.
4059 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4060 * s/cygwin.h (PTY_ITERATION): Likewise.
4061 * s/darwin.h (PTY_ITERATION): Likewise.
4062 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4063
4064 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4065 * process.c (allocate_pty): Don't declare stb unless it's needed.
4066
4067 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4068 (CONSTANTLIM): Remove; unused.
4069 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4070 Define only if needed.
4071
4072 * unexelf.c (unexec): Name an expression,
4073 to avoid gcc -Wbad-function-cast warning.
4074 Use a different way to cause a compilation error if anyone uses
4075 n rather than nn, a way that does not involve shadowing.
4076 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4077
4078 * deps.mk (unexalpha.o): Remove; unused.
4079
4080 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4081 * unexec.h: New file.
4082 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4083 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4084 Depend on unexec.h.
4085 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4086 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4087 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4088 Change as necessary to match prototype in unexec.h.
4089
4090 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4091 shadowing.
4092 (back_comment, skip_chars): Mark vars as initialized.
4093
4094 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4095 Rename locals to avoid shadowing.
4096
4097 * lread.c (read1): Rewrite so as not to use empty "else".
4098 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4099
4100 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4101
4102 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4103 warning when compiling print.c.
4104
4105 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4106 instead of using an uninitialized var.
4107 (font_sort_entities): Mark var as initialized.
4108
4109 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4110
4111 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4112 pointers to constants.
4113 (font_parse_fcname): Remove unused vars.
4114 (font_delete_unmatched): Now static.
4115 (font_get_spec): Remove; unused.
4116 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4117 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4118 Rename or move locals to avoid shadowing.
4119
4120 * fns.c (require_nesting_list, require_unwind): Now static.
4121 (Ffillarray): Rename locals to avoid shadowing.
4122
4123 * floatfns.c (domain_error2): Define only if needed.
4124 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4125
4126 * alloc.c (mark_backtrace): Move decl from here ...
4127 * lisp.h: ... to here, so that it can be checked.
4128
4129 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4130 (Fdefvar): Rewrite so as not to use empty "else".
4131 (lisp_indirect_variable): Name an expression,
4132 to avoid gcc -Wbad-function-cast warning.
4133 (Fdefvar): Rename locals to avoid shadowing.
4134
4135 * callint.c (quotify_arg, quotify_args): Now static.
4136 (Fcall_interactively): Rename locals to avoid shadowing.
4137 Use const pointer when appropriate.
4138
4139 * lisp.h (get_system_name, get_operating_system_release):
4140 Move decls here, to check interfaces.
4141 * process.c (get_operating_system_release): Move decl to lisp.h.
4142 * xrdb.c (get_system_name): Likewise.
4143 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4144 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4145 some of which prompt warnings from gcc -Wbad-function-cast.
4146 (Fformat_time_string, Fencode_time, Finsert_char):
4147 (Ftranslate_region_internal, Fformat):
4148 Rename or remove local vars to avoid shadowing.
4149 (Ftranslate_region_internal): Mark var as initialized.
4150
4151 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4152 avoid shadowing.
4153
4154 * lisp.h (eassert): Check that the argument compiles, even if
4155 ENABLE_CHECKING is not defined.
4156
4157 * data.c (Findirect_variable): Name an expression, to avoid
4158 gcc -Wbad-function-cast warning.
4159 (default_value, arithcompare, arith_driver, arith_error): Now static.
4160 (store_symval_forwarding): Rename local to avoid shadowing.
4161 (Fmake_variable_buffer_local, Fmake_local_variable):
4162 Mark variables as initialized.
4163 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4164
4165 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4166 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4167 Rename locals to avoid shadowing.
4168 (mark_stack): Move local variables into the #ifdef region where
4169 they're used.
4170 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4171 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4172 needed otherwise.
4173 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4174 (GC_STRING_CHARS): Remove; not used.
4175 (Fmemory_limit): Cast sbrk's returned value to char *.
4176
4177 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4178 avoids undefined behavior in theory.
4179
4180 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4181
4182 Use functions, not macros, for up- and down-casing (Bug#8254).
4183 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4184 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4185 to use the following functions instead of these macros.
4186 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4187 EMACS_INT, since callers assume the returned value fits in int.
4188 (upcase1): Likewise, for UPCASE_TABLE.
4189 (uppercasep, lowercasep, upcase): New static inline functions.
4190 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4191 the race-condition problem in the old DOWNCASE.
4192
4193 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4194 Rename locals to avoid shadowing.
4195 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4196 (regex_compile, re_search_2, re_match_2_internal):
4197 Remove unused local vars.
4198 (FREE_VAR): Rewrite so as not to use empty "else",
4199 which gcc can warn about.
4200 (regex_compile, re_match_2_internal): Mark locals as initialized.
4201 (RETALLOC_IF): Define only if needed.
4202 (WORDCHAR_P): Likewise. This one is never needed, but is used
4203 only in a comment talking about a compiler bug, so put inside
4204 the #if 0 of that comment.
4205 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4206 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4207 Remove; unused.
4208
4209 * search.c (boyer_moore): Rename locals to avoid shadowing.
4210 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4211 (PREV_CHAR_BOUNDARY): Likewise.
4212
4213 * search.c (simple_search): Remove unused var.
4214
4215 * dired.c (compile_pattern): Move decl from here ...
4216 * lisp.h: ... to here, so that it can be checked.
4217 (struct re_registers): New forward decl.
4218
4219 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4220
4221 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4222 All uses changed.
4223 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4224 Rename locals to avoid shadowing.
4225 (Fvertical_motion): Mark locals as initialized.
4226
4227 * casefiddle.c (casify_object, casify_region): Now static.
4228 (casify_region): Mark local as initialized.
4229
4230 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4231
4232 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4233 New macros, so that the caller can use some names other than
4234 gcpro1, gcpro2, etc.
4235 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4236 of the new macros.
4237 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4238 argument, for consistency with GCPRO2_VAR, etc: it is now the
4239 prefix of the variable, not the variable itself. All uses
4240 changed.
4241 * dired.c (directory_files_internal, file_name_completion):
4242 Rename locals to avoid shadowing.
4243
4244 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4245 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4246 dired.c's scmp function, had undefined behavior.
4247 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4248 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4249 * buffer.h: ... to here, because these macros use current_buffer,
4250 and the new implementation with inline functions needs to have
4251 current_buffer in scope now, rather than later when the macros
4252 are used.
4253 (downcase, upcase1): New static inline functions.
4254 (DOWNCASE, UPCASE1): Reimplement using these functions.
4255 This avoids undefined behavior in expressions like
4256 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4257 from race conditions in accessing the global variables
4258 case_temp1 and case_temp2.
4259 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4260 * lisp.h (case_temp1, case_temp2): Remove their decls.
4261 * character.h (ASCII_CHAR_P): Move from here ...
4262 * lisp.h: ... to here, so that the inline functions mentioned
4263 above can use them.
4264
4265 * dired.c (directory_files_internal_unwind): Now static.
4266
4267 * fileio.c (file_name_as_directory, directory_file_name):
4268 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4269 Now static.
4270 (file_name_as_directory): Use const pointers when appropriate.
4271 (Fexpand_file_name): Likewise. In particular, newdir might
4272 point at constant storage, so make it a const pointer.
4273 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4274 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4275 signedness issues.
4276 (Fset_file_times, Finsert_file_contents, auto_save_error):
4277 Rename locals to avoid shadowing.
4278
4279 * minibuf.c (choose_minibuf_frame_1): Now static.
4280 (Ftry_completion, Fall_completions): Rename or remove locals
4281 to avoid shadowing.
4282
4283 * marker.c (bytepos_to_charpos): Remove; unused.
4284
4285 * lisp.h (verify_bytepos, count_markers): New decls,
4286 so that gcc does not warn that these functions aren't declared.
4287
4288 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4289 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4290 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4291 (copy_text): Remove unused local var.
4292
4293 * filelock.c (within_one_second): Now static.
4294 (lock_file_1): Rename local to avoid shadowing.
4295
4296 * buffer.c (fix_overlays_before): Mark locals as initialized.
4297 (fix_start_end_in_overlays): Likewise. This function should be
4298 simplified by using pointers-to-pointers, but that's a different
4299 matter.
4300 (switch_to_buffer_1): Now static.
4301 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4302 (report_overlay_modification): Rename locals to avoid shadowing.
4303
4304 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4305 Fix pointer signedness issue.
4306 (sys_subshell): Mark local as volatile if checking for lint,
4307 to suppress a gcc -Wclobbered warning that does not seem to be right.
4308 (MAXPATHLEN): Define only if needed.
4309
4310 * process.c (serial_open, serial_configure): Move decls from here ...
4311 * systty.h: ... to here, so that they can be checked.
4312
4313 * fns.c (get_random, seed_random): Move extern decls from here ...
4314 * lisp.h: ... to here, so that they can be checked.
4315
4316 * sysdep.c (reset_io): Now static.
4317 (wait_for_termination_signal): Remove; unused.
4318
4319 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4320 (copy_keymap_item, append_key, push_text_char_description):
4321 Now static.
4322 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4323 (DENSE_TABLE_SIZE): Remove; unused.
4324 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4325 (describe_map_tree):
4326 Rename locals to avoid shadowing.
4327
4328 * keyboard.c: Declare functions static if they are not used elsewhere.
4329 (echo_char, echo_dash, cmd_error, top_level_2):
4330 (poll_for_input, handle_async_input): Now static.
4331 (read_char, kbd_buffer_get_event, make_lispy_position):
4332 (make_lispy_event, make_lispy_movement, apply_modifiers):
4333 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4334 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4335 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4336 (read_key_sequence, read_char): Mark locals as initialized.
4337 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4338
4339 * keyboard.h (make_ctrl_char): New decl.
4340 (mark_kboards): Move decl here ...
4341 * alloc.c (mark_kboards): ... from here.
4342
4343 * lisp.h (force_auto_save_soon): New decl.
4344
4345 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4346 (DEFINE_DUMMY_FUNCTION): New macro.
4347 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4348 Use it.
4349 (main): Add casts to avoid warnings
4350 if GCC considers string literals to be constants.
4351
4352 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4353
4354 * dbusbind.c: Pointer signedness fixes.
4355 (xd_signature, xd_append_arg, xd_initialize):
4356 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4357 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4358 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4359 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4360
4361 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4362 if GCC considers string literals to be constants.
4363 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4364
4365 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4366
4367 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4368 (print_preprocess, print_object): New macro to fix last change.
4369
4370 * print.c (print_preprocess): Don't forget font objects.
4371
4372 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4373
4374 * emacs.c (USAGE3): Doc fixes.
4375
4376 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4377
4378 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4379 structure.
4380
4381 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4382
4383 * lisp.h (VWindow_system, Qfile_name_history):
4384 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4385 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4386 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4387
4388 * w32select.c: Don't #include "keyboard.h".
4389 (run_protected): Add extern declaration for waiting_for_input.
4390
4391 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4392 * w32console.c (detect_input_pending, read_input_pending)
4393 (encode_terminal_code):
4394 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4395 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4396 (w32_system_caret_y, Qfile_name_history):
4397 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4398 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4399 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4400 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4401 * w32proc.c (Qlocal, report_file_error):
4402 * w32term.c (Vwindow_system, updating_frame):
4403 * w32uniscribe.c (initialized, uniscribe_font_driver):
4404 Remove unneeded extern declarations.
4405
4406 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4407
4408 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4409
4410 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4411
4412 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4413 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4414 These macros can no longer be used for assignment.
4415
4416 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4417 Assign struct members directly, instead of using BUF_BEGV etc.
4418 (record_buffer_markers, fetch_buffer_markers): New functions for
4419 recording and fetching special buffer markers.
4420 (set_buffer_internal_1, set_buffer_temp): Use them.
4421
4422 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4423
4424 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4425
4426 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4427 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4428
4429 * xdisp.c (hscroll_window_tree):
4430 (reconsider_clip_changes): Use PT instead of BUF_PT.
4431
4432 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4433
4434 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4435 $(EMACS_ROOT)/lib/intprops.h.
4436
4437 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4438
4439 Fix more problems found by GCC 4.5.2's static checks.
4440
4441 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4442 to unsigned char * to avoid compiler diagnostic.
4443 (xg_free_frame_widgets): Make it clear that a local variable is
4444 needed only if USE_GTK_TOOLTIP.
4445 (gdk_window_get_screen): Make it clear that this macro is needed
4446 only if USE_GTK_TOOLTIP.
4447 (int_gtk_range_get_value): New function, which avoids a diagnostic
4448 from gcc -Wbad-function-cast.
4449 (xg_set_toolkit_scroll_bar_thumb): Use it.
4450 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4451 diagnostic from gcc -Wbad-function-cast.
4452 (get_utf8_string, xg_get_file_with_chooser):
4453 Rename locals to avoid shadowing.
4454 (create_dialog): Move locals to avoid shadowing.
4455
4456 * xgselect.c (xg_select): Remove unused var.
4457
4458 * image.c (four_corners_best): Mark locals as initialized.
4459 (gif_load): Initialize transparent_p to zero (Bug#8238).
4460 Mark another local as initialized.
4461 (my_png_error, my_error_exit): Mark with NO_RETURN.
4462
4463 * image.c (clear_image_cache): Now static.
4464 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4465 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4466 (x_edge_detection): Remove unnecessary cast that
4467 gcc -Wbad-function-cast diagnoses.
4468 (gif_load): Fix pointer signedness.
4469 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4470 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4471
4472 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4473
4474 Improve quality of tests for time stamp overflow.
4475 For example, without this patch (encode-time 0 0 0 1 1
4476 1152921504606846976) returns the obviously-bogus value (-948597
4477 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4478 reports time overflow. See
4479 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4480 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4481 * editfns.c: Include limits.h and intprops.h.
4482 (TIME_T_MIN, TIME_T_MAX): New macros.
4483 (time_overflow): Move earlier, to before first use.
4484 (hi_time, lo_time): New functions, for an accurate test for
4485 out-of-range times.
4486 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4487 (Fget_internal_run_time): Don't assume time_t fits in int.
4488 (make_time): Use list2 instead of Fcons twice.
4489 (Fdecode_time): More accurate test for out-of-range times.
4490 (check_tm_member): New function.
4491 (Fencode_time): Use it, to test for out-of-range times.
4492 (lisp_time_argument): Don't rely on undefined left-shift and
4493 right-shift behavior when checking for time stamp overflow.
4494
4495 * editfns.c (time_overflow): New function, refactoring common code.
4496 (Fformat_time_string, Fdecode_time, Fencode_time):
4497 (Fcurrent_time_string): Use it.
4498
4499 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4500 * dired.c (make_time): Move to ...
4501 * editfns.c (make_time): ... here.
4502 * systime.h: Note the move.
4503
4504 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4505
4506 * fringe.c (update_window_fringes): Remove unused variables.
4507
4508 * unexmacosx.c (copy_data_segment): Also copy __got section.
4509 (Bug#8223)
4510
4511 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4512
4513 * termcap.c [MSDOS]: Include "msdos.h".
4514 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4515 Constify `char *' arguments and their references according to
4516 prototypes in tparam.h.
4517
4518 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4519
4520 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4521 Adapt all references accordingly.
4522
4523 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4524
4525 2011-03-11 Tom Tromey <tromey@redhat.com>
4526
4527 * buffer.c (syms_of_buffer): Remove obsolete comment.
4528
4529 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4530
4531 * termhooks.h (encode_terminal_code): Declare prototype.
4532
4533 * msdos.c (encode_terminal_code): Don't declare prototype.
4534
4535 * term.c (encode_terminal_code): Now external again, used by
4536 w32console.c and msdos.c.
4537
4538 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4539 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4540
4541 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4542
4543 Fix some minor problems found by GCC 4.5.2's static checks.
4544
4545 * fringe.c (update_window_fringes): Mark locals as initialized
4546 (Bug#8227).
4547 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4548
4549 * alloc.c (mark_fringe_data): Move decl from here ...
4550 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4551 to check its interface.
4552 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4553
4554 * fontset.c (free_realized_fontset): Now static.
4555 (Fset_fontset_font): Rename local to avoid shadowing.
4556 (fontset_font): Mark local as initialized.
4557 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4558
4559 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4560
4561 * xselect.c (x_disown_buffer_selections): Remove; not used.
4562 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4563 (x_own_selection, Fx_disown_selection_internal): Rename locals
4564 to avoid shadowing.
4565 (x_handle_dnd_message): Remove local to avoid shadowing.
4566
4567 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4568 so that the caller can use some name other than gcpro1.
4569 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4570 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4571 (Fx_backspace_delete_keys_p):
4572 Use them to avoid shadowing, and rename vars to avoid shadowing.
4573 (x_decode_color, x_set_name, x_window): Now static.
4574 (Fx_create_frame): Add braces to silence GCC warning.
4575 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4576 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4577 Remove unused locals.
4578 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4579 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4580 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4581 macros.
4582
4583 * xterm.h (x_mouse_leave): New decl.
4584
4585 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4586 Remove unused functions.
4587 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4588 (x_calc_absolute_position): Now static.
4589 (XTread_socket): Don't define label "out" unless it's used.
4590 Don't declare local "event" unless it's used.
4591 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4592 unless they are used.
4593 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4594 (x_fatal_error_signal): Remove; not used.
4595 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4596 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4597 (x_error_catcher, x_connection_closed, x_error_handler):
4598 (x_error_quitter, xembed_send_message, x_iconify_frame):
4599 (my_log_handler): Rename locals to avoid shadowing.
4600 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4601 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4602
4603 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4604 Rename or move locals to avoid shadowing.
4605 (tty_defined_color, merge_face_heights): Now static.
4606 (free_realized_faces_for_fontset): Remove; not used.
4607 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4608 does not deduce is never used uninitialized.
4609 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4610 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4611
4612 * terminal.c (store_terminal_param): Now static.
4613
4614 * xmenu.c (menu_highlight_callback): Now static.
4615 (set_frame_menubar): Remove unused local.
4616 (xmenu_show): Rename parameter to avoid shadowing.
4617 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4618 since they might point to immutable storage.
4619 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4620 since it's unused otherwise.
4621
4622 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4623 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4624 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4625 avoids a gcc -Wuninitialized diagnostic.
4626 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4627 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4628 does not deduce are never used uninitialized.
4629
4630 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4631
4632 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4633 * window.c (window_loop, size_window):
4634 (run_window_configuration_change_hook, enlarge_window): Likewise.
4635
4636 * window.c (display_buffer): Now static.
4637 (size_window): Mark variables that gcc -Wuninitialized
4638 does not deduce are never used uninitialized.
4639 * window.h (check_all_windows): New decl, to forestall
4640 gcc -Wmissing-prototypes diagnostic.
4641 * dispextern.h (bidi_dump_cached_states): Likewise.
4642
4643 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4644 shadowing.
4645 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4646 Include <limits.h>.
4647 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4648 and to avoid gcc -Wuninitialized warning.
4649 (load_charset_map): Mark variables that gcc -Wuninitialized
4650 does not deduce are never used uninitialized.
4651 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4652
4653 * coding.c (coding_set_source, coding_set_destination):
4654 Use "else { /* comment */ }" rather than "else /* comment */;"
4655 for clarity, and to avoid gcc -Wempty-body warning.
4656 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4657 a block, when the outer 'i' will do.
4658 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4659 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4660 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4661 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4662 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4663 Rename locals to avoid shadowing.
4664 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4665 * coding.c (emacs_mule_char, encode_invocation_designation):
4666 Now static, since they're not used elsewhere.
4667 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4668 (decode_coding_object, encode_coding_object, detect_coding_system):
4669 (decode_coding_emacs_mule): Mark variables that gcc
4670 -Wuninitialized does not deduce are never used uninitialized.
4671 (detect_coding_iso_2022): Initialize a local variable that might
4672 be used uninitialized. Leave a FIXME because it's not clear that
4673 this initialization is needed. (Bug#8211)
4674 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4675 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4676 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4677 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4678 Remove unused macros.
4679
4680 * category.c (hash_get_category_set): Remove unused local var.
4681 (copy_category_table): Now static, since it's not used elsewhere.
4682 * character.c (string_count_byte8): Likewise.
4683
4684 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4685 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4686
4687 * chartab.c (copy_sub_char_table): Now static, since it's not used
4688 elsewhere.
4689 (sub_char_table_ref_and_range, char_table_ref_and_range):
4690 Rename locals to avoid shadowing.
4691 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4692
4693 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4694 (BIDI_BOB): Remove unused macro.
4695
4696 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4697 deduce are never used uninitialized.
4698 * term.c (encode_terminal_code): Likewise.
4699
4700 * term.c (encode_terminal_code): Now static. Remove unused local.
4701
4702 * tparam.h: New file.
4703 * term.c, tparam.h: Include it.
4704 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4705 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4706 Move these decls to tparam.h, and make them agree with what
4707 is actually in tparam.c. The previous trick of using incompatible
4708 decls in different modules does not conform to the C standard.
4709 All callers of tparam changed to use tparam's actual API.
4710 * tparam.c (tparam1, tparam, tgoto):
4711 Use const pointers where appropriate.
4712
4713 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4714 * cm.h (struct cm): Likewise.
4715 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4716 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4717 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4718 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4719 (turn_on_face, init_tty): Likewise.
4720 * termchar.h (struct tty_display_info): Likewise.
4721
4722 * term.c (term_mouse_position): Rename local to avoid shadowing.
4723
4724 * alloc.c (mark_ttys): Move decl from here ...
4725 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4726
4727 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4728
4729 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4730
4731 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4732
4733 * search.c (compile_pattern_1): Remove argument regp, unused since
4734 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4735 (compile_pattern): Don't pass it.
4736
4737 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4738
4739 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4740 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4741 for ! HAVE_GTK3.
4742 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4743
4744 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4745
4746 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4747 gdk_window_get_screen, gdk_window_get_geometry,
4748 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4749 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4750 (xg_get_pixbuf_from_pixmap): New function.
4751 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4752 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4753 Call xg_get_pixbuf_from_pixmap instead of
4754 gdk_pixbuf_get_from_drawable.
4755 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4756 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4757 (xg_check_special_colors): Use GtkStyleContext and its functions
4758 for HAVE_GTK3.
4759 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4760 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4761 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4762 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4763 Call gtk_widget_get_preferred_size.
4764 (xg_frame_resized): gdk_window_get_geometry only takes 5
4765 parameters.
4766 (xg_win_to_widget, xg_event_is_for_menubar):
4767 Call gdk_x11_window_lookup_for_display.
4768 (xg_set_widget_bg): New function.
4769 (delete_cb): New function.
4770 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4771 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4772 (xg_set_background_color): Call xg_set_widget_bg.
4773 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4774 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4775 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4776 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4777 if ! HAVE_GTK3.
4778 (update_frame_tool_bar): Call gtk_widget_hide.
4779 (xg_initialize): Use GDK_KEY_g.
4780
4781 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4782 if ! HAVE_GTK3
4783 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4784
4785 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4786 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4787 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4788
4789 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4790
4791 * w32xfns.c (select_palette): Check success of RealizePalette against
4792 GDI_ERROR, not zero.
4793
4794 See ChangeLog.11 for earlier changes.
4795
4796 ;; Local Variables:
4797 ;; coding: utf-8
4798 ;; End:
4799
4800 Copyright (C) 2011 Free Software Foundation, Inc.
4801
4802 This file is part of GNU Emacs.
4803
4804 GNU Emacs is free software: you can redistribute it and/or modify
4805 it under the terms of the GNU General Public License as published by
4806 the Free Software Foundation, either version 3 of the License, or
4807 (at your option) any later version.
4808
4809 GNU Emacs is distributed in the hope that it will be useful,
4810 but WITHOUT ANY WARRANTY; without even the implied warranty of
4811 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4812 GNU General Public License for more details.
4813
4814 You should have received a copy of the GNU General Public License
4815 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.