1 2011-08-06 Paul Eggert <eggert@cs.ucla.edu>
3 Integer and memory overflow issues.
5 * charset.c (charset_table_size)
6 (struct charset_sort_data.priority): Now ptrdiff_t.
7 (charset_compare): Don't overflow if priorities differ greatly.
8 (Fsort_charsets): Don't assume list length fits in int.
9 Check for size-calculation overflow when allocating sort data.
10 (syms_of_charset): Allocate an initial charset table that is
11 just under 64 KiB, to avoid problems with glibc malloc and mmap.
13 * cmds.c (internal_self_insert): Check for size-calculation overflow.
15 * composite.h (struct composition.glyph_len): Now int, not unsigned.
16 The actual value is always <= INT_MAX, and leaving it unsigned made
17 overflow checking harder.
19 * dispextern.h (struct glyph_matrix.rows_allocated)
20 (struct face_cache.size): Now ptrdiff_t, for convenience in use
21 with xpalloc. The values are still always <= INT_MAX.
23 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
25 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
26 (SAFE_NALLOCA): New macro.
28 * region-cache.c (struct boundary.pos, find_cache_boundary)
29 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
30 (set_cache_region, invalidate_region_cache)
31 (revalidate_region_cache, know_region_cache, region_cache_forward)
32 (region_cache_backward, pp_cache):
33 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
34 so that ptrdiff_t * can be passed to xpalloc.
35 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
36 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
37 (pp_cache): Don't assume cache_len fits in int.
38 * region-cache.h: Adjust extern decls to match.
40 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
41 EMACS_INT, since either will do, for xpalloc.
43 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
44 (xnmalloc, xnrealloc, xpalloc): New functions.
46 * bidi.c (bidi_shelve_header_size): New constant.
47 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
48 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
50 * buffer.c (overlays_at, overlays_in, record_overlay_string)
52 Don't update size of array until after memory allocation succeeds,
53 because xmalloc/xrealloc may not return.
54 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
55 now that we have proper integer overflow checking.
56 (record_overlay_string, overlay_strings): Catch overflows when
57 calculating size of overlay_str_buf.
59 * callproc.c (Fcall_process): Check for size overflow when
60 calculating size of args2.
61 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
62 Normally we prefer signed values, but sticking with ptrdiff_t would
63 require adding more-complicated checks.
65 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
66 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
67 Redo buffer-overflow calculations to avoid integer overflow.
68 Add a FIXME comment where memory seems to be over-allocated.
70 * character.c (Fstring): Check for size-calculation overflow.
72 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
73 unnecessary integer overflow. Check for size overflow.
74 (encode_coding_object): Don't update size until xmalloc succeeds.
76 * composite.c (get_composition_id): Check for overflow in glyph
79 Integer and memory overflow fixes for display code.
80 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
81 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
82 (scrolling_window): Check for overflow in size calculations.
83 (line_draw_cost, realloc_glyph_pool, add_row_entry):
84 Don't assume glyph table len fits in int.
85 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
86 (row_table_size): Now ptrdiff_t, not int.
87 (scrolling_window): Avoid overflow in size calculations.
88 Don't update size until allocation succeeds.
89 * fns.c (concat): Check for overflow in size calculations.
90 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
91 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
92 (NEXT_ALMOST_PRIME_LIMIT): New constant.
94 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
95 (get_doc_string): Check for size calculation overflow.
96 Don't update size until allocation succeeds.
97 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
98 EMACS_INT, where ptrdiff_t will do.
99 (Fsubstitute_command_keys): Check for string overflow.
101 * editfns.c (set_time_zone_rule): Don't assume environment length
103 (message_length): Now ptrdiff_t, not int.
104 (Fmessage_box): Don't update size until allocation succeeds.
105 Don't assume message length fits in int.
106 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
108 * emacs.c (main): Do not reallocate argv, since there is a null at
109 the end that can be overwritten, and this way there's no need to
110 worry about size-calculation overflow.
111 (sort_args): Check for size-calculation overflow.
113 * eval.c (init_eval_once, grow_specpdl): Don't update size until
115 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
117 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
118 (x_set_scroll_bar_width, x_figure_window_size):
119 Check for integer overflow.
120 (x_set_alpha): Do not assume XINT fits in int.
122 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
123 This is for the members text_lines, text_cols, total_lines, total_cols,
124 where the system imposes an 'int' limit.
126 * fringe.c (Fdefine_fringe_bitmap):
127 Don't update size until alloc works.
129 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
130 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
132 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
133 Check for size-calculation overflow.
134 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
135 do, as we prefer signed integers.
136 (id_to_widget.max_size, id_to_widget.used)
137 (xg_store_widget_in_map, xg_remove_widget_from_map)
138 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
139 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
140 Use and return ptrdiff_t, not int.
141 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
142 * gtkutil.h: Change prototypes to match the above.
144 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
145 are duplicate now that they've been promoted to lisp.h.
146 (x_allocate_bitmap_record, x_alloc_image_color)
147 (make_image_cache, cache_image, xpm_load):
148 Don't update size until alloc is done.
149 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
151 Check for size calculation overflow.
152 (ct_colors_allocated_max): New constant.
153 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
156 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
157 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
158 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
159 Use ptrdiff_t, not int, to count maps.
160 (read_char_minibuf_menu_prompt): Check for overflow in size
161 calculations. Don't update size until allocation succeeds. Redo
162 calculations to avoid overflow.
163 * keyboard.h: Change prototypes to match the above.
165 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
167 (current_minor_maps): Check for size calculation overflow.
168 * keymap.h: Change prototypes to match the above.
170 * lread.c (read1, init_obarray): Don't update size until alloc done.
172 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
173 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
175 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
176 Now ptrdiff_t, not int.
177 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
178 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
180 * process.c (Fnetwork_interface_list): Check for overflow
183 * region-cache.c (move_cache_gap): Check for size calculation overflow.
185 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
186 overflow. Don't bother calling xmalloc when xrealloc will do.
188 * search.c (Freplace_match): Check for size calculation overflow.
189 (Fset_match_data): Don't assume list lengths fit in 'int'.
191 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
192 for command line length. Do not attempt to address one before the
193 beginning of an array, as that's not portable.
195 * term.c (max_frame_lines): Remove; unused.
196 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
198 (encode_terminal_code, calculate_costs): Check for size
199 calculation overflow.
200 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
201 table lengths and related sizes. Don't update size until alloc
202 done. Redo calculations to avoid overflow.
203 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
205 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
206 subtracting pointers.
207 (gobble_line): Check for overflow more carefully. Don't update size
210 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
211 Don't update size until alloc done.
212 Redo size calculations to avoid overflow.
213 Check for size calculation overflow.
214 (main) [DEBUG]: Fix typo in invoking tparam1.
216 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
217 Use ptrdiff_t, not int, for sizes.
218 (store_mode_line_noprop_char): Don't update size until alloc done.
220 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
221 Use ptrdiff_t, not int, for sizes.
222 (Finternal_make_lisp_face, cache_face):
223 Check for size calculation overflow.
224 (cache_face): Treat size calculation overflows as if they were
225 memory exhaustion (the usual treatment), rather than aborting.
227 * xfns.c (x_encode_text, x_set_name_internal)
228 (Fx_change_window_property): Use ptrdiff_t, not int, to count
229 sizes, since they can exceed INT_MAX in size. Check for size
230 calculation overflow.
232 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
233 (xg_select): Check for size calculation overflow.
234 Don't update size until alloc done.
236 * xrdb.c (get_environ_db): Don't assume path length fits in int,
237 as sprintf is limited to int lengths.
239 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
240 (X_LONG_MIN): New macros.
241 Use them to make the following changes clearer.
242 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
243 This change doesn't affect the value now, but it may help remind
244 future maintainers not to raise the value too much later.
245 (SELECTION_QUANTUM): Remove, replacing with ...
246 (selection_quantum): ... new function, which avoids overflow.
248 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
249 assumption that selection length fits in 'int'.
250 (x_reply_selection_request, x_handle_selection_request)
251 (x_get_window_property, receive_incremental_selection)
252 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
253 (lisp_data_to_selection_data, clean_local_selection_data):
254 Use ptrdiff_t, not int, to record length of selection.
255 (x_reply_selection_request, x_get_window_property)
256 (receive_incremental_selection, x_property_data_to_lisp):
257 Redo calculations to avoid overflow.
258 (x_reply_selection_request): When sending hint, ceiling it at
259 X_LONG_MAX rather than relying on wraparound overflow to send
261 (x_get_window_property, receive_incremental_selection)
262 (lisp_data_to_selection_data, x_property_data_to_lisp):
263 Check for size-calculation overflow.
264 (x_get_window_property, receive_incremental_selection)
265 (lisp_data_to_selection_data, Fx_register_dnd_atom):
266 Don't store size until memory allocation succeeds.
267 (x_get_window_property): Plug memory leak on memory exhaustion.
268 Don't double-block input; malloc is safe here. Don't assume 2**34
269 - 4 fits in unsigned long. Add an xassert to check
270 XGetWindowProperty overflow. Be more careful about overflow
271 calculations, and distinguish size from memory overflow better.
272 (receive_incremental_selection): When tracing, don't assume
273 unsigned int is less than INT_MAX.
274 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
275 harmful) conversions of unsigned short to int.
276 (lisp_data_to_selection_data): Don't assume that integers
277 in the range -65535 through -1 fit in an X unsigned short.
278 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
279 result parameters unless successful. Rely on cons_to_unsigned
280 to report problems with elements; the old code wasn't right anyway.
281 (x_check_property_data): Check for int overflow; we cannot use
282 a wider type due to X limits.
283 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
285 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
287 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
288 (x_term_init): Check for size calculation overflow.
289 (x_color_cells): Don't store size until memory allocation succeeds.
290 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
291 Don't assume alloca size is less than MAX_ALLOCA.
292 (x_term_init): Don't assume length fits in int (sprintf is limited
295 Use ptrdiff_t for composition IDs.
296 * character.c (lisp_string_width):
297 * composite.c (composition_table_size, n_compositions)
298 (get_composition_id, composition_gstring_from_id):
299 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
300 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
301 * window.c (Frecenter):
302 Use ptrdiff_t, not int, for composition IDs.
303 * composite.c (get_composition_id): Check for integer overflow.
304 * composite.h: Adjust prototypes to match the above changes.
306 Use ptrdiff_t for hash table indexes.
307 * category.c (hash_get_category_set):
308 * ccl.c (ccl_driver):
309 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
310 * coding.c (coding_system_charset_list, detect_coding_system):
311 * coding.h (struct coding_system.id):
312 * composite.c (get_composition_id, gstring_lookup_cache):
313 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
314 * image.c (xpm_get_color_table_h):
315 * lisp.h (hash_lookup, hash_put):
316 * minibuf.c (Ftest_completion):
317 Use ptrdiff_t for hash table indexes, not int (which is too
318 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
319 32-bit --with-wide-int hosts).
321 * charset.c (Fdefine_charset_internal): Check for integer overflow.
322 Add a FIXME comment about memory leaks.
323 (syms_of_charset): Don't assume xmalloc returns.
325 Don't assume that stated character widths fit in int.
326 * character.c (Fchar_width, c_string_width, lisp_string_width):
327 * character.h (CHAR_WIDTH):
328 * indent.c (MULTIBYTE_BYTES_WIDTH):
329 Use sanitize_char_width to avoid undefined and/or bad behavior
330 with outlandish widths.
331 * character.h (sanitize_tab_width): Renamed from sanitize_width,
332 now that we have two such functions. All uses changed.
333 (sanitize_char_width): New inline function.
335 Don't assume that tab-width fits in int.
336 * character.h (sanitize_width): New inline function.
337 (SANE_TAB_WIDTH): New macro.
338 (ASCII_CHAR_WIDTH): Use it.
339 * indent.c (sane_tab_width): Remove. All uses replaced by
340 SANE_TAB_WIDTH (current_buffer).
341 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
343 * fileio.c: Integer overflow issues with file modes.
344 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
346 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
347 Remove unreachable code.
348 (read_hex, load_charset_map_from_file): Check for integer overflow.
350 * xterm.c: don't go over XClientMessageEvent limit
351 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
352 (x_send_scroll_bar_event): Likewise. Check that the size does not
353 exceed limits imposed by XClientMessageEvent, as well as the usual
354 ptrdiff_t and size_t limits.
356 * keyboard.c: Overflow, signedness and related fixes.
357 (make_lispy_movement): Use same integer type in forward decl
358 that is used in the definition.
359 (read_key_sequence, keyremap_step):
360 Change bufsize argument back to int, undoing my 2011-03-30 change.
361 We prefer signed types, and int is wide enough here.
362 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
363 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
364 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
365 length, not size_t. Use ptrdiff_t for index, not int.
366 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
367 possibility of integer overflow.
369 Overflow, signedness and related fixes for images.
371 * dispextern.h (struct it.stack[0].u.image.image_id)
372 (struct_it.image_id, struct image.id, struct image_cache.size)
373 (struct image_cache.used, struct image_cache.ref_count):
374 * gtkutil.c (update_frame_tool_bar):
375 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
376 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
377 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
378 * nsmenu.m (update_frame_tool_bar):
379 * xdisp.c (calc_pixel_width_or_height):
380 * xfns.c (image_cache_refcount):
381 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
382 on typical 64-bit hosts.
384 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
385 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
386 Omit unnecessary casts to int.
387 (parse_image_spec): Check that integers fall into 'int' range
388 when the callers expect that.
389 (image_ascent): Redo ascent calculation to avoid int overflow.
390 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
391 (lookup_image): Remove unnecessary tests.
392 (xbm_image_p): Locals are now of int, not EMACS_INT,
393 since parse_image_check makes sure they fit into int.
394 (png_load, gif_load, svg_load_image):
395 Prefer int to unsigned where either will do.
396 (tiff_handler): New function, combining the cores of the
397 old tiff_error_handler and tiff_warning_handler. This
398 function is rewritten to use vsnprintf and thereby avoid
399 stack buffer overflows. It uses only the features of vsnprintf
400 that are common to both POSIX and native Microsoft.
401 (tiff_error_handler, tiff_warning_handler): Use it.
402 (tiff_load, gif_load, imagemagick_load_image):
403 Don't assume :index value fits in 'int'.
404 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
405 (imagemagick_load_image): Check that crop parameters fit into
406 the integer types that MagickCropImage accepts. Don't assume
407 Vimagemagick_render_type has a nonnegative value. Don't assume
408 size_t fits in 'long'.
409 (gs_load): Use printmax_t to print the widest integers possible.
410 Check for integer overflow when computing image height and width.
412 2011-08-05 Eli Zaretskii <eliz@gnu.org>
414 * bidi.c <bidi_cache_total_alloc>: Now static.
415 (bidi_initialize): Initialize bidi_cache_total_alloc.
417 *xdisp.c (display_line): Release buffer allocated for shelved bidi
420 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
421 amount allocated this far in `bidi_cache_total_alloc'.
422 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
423 non-zero, only free the data buffer without restoring the cache
424 contents. All callers changed.
426 * dispextern.h (bidi_unshelve_cache): Update prototype.
428 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
429 (move_it_in_display_line, move_it_to)
430 (move_it_vertically_backward, move_it_by_lines): Replace the call
431 to xfree to an equivalent call to bidi_unshelve_cache.
432 (move_it_in_display_line_to): Fix logic of returning
433 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
435 2011-08-05 Eli Zaretskii <eliz@gnu.org>
437 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
438 came from a string character with a `cursor' property. (Bug#9229)
440 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
442 * Makefile.in (LIB_PTHREAD): New variable.
443 (LIBES): Add LIB_PTHREAD (Bug#9216).
445 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
446 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
448 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
450 * regex.c (re_iswctype): Remove some redundant boolean
453 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
455 * xterm.c (x_find_topmost_parent): New function.
456 (x_set_frame_alpha): Find topmost parent window with
457 x_find_topmost_parent and set the property there also (bug#9181).
458 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
460 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
462 * callproc.c (Fcall_process): Avoid vfork clobbering
463 the local vars buffer, coding_systems, current_dir.
465 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
467 * keymap.c (Fmake_composed_keymap): Move to subr.el.
469 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
471 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
472 so that it is not optimized away.
474 * xdisp.c (compute_display_string_pos): Remove unused local.
476 2011-08-02 Eli Zaretskii <eliz@gnu.org>
478 Fix slow cursor motion and scrolling in large buffers with
479 selective display, like Org Mode buffers. (Bug#9218)
481 * dispextern.h (struct bidi_it): New member disp_prop_p.
483 * xdisp.c: Remove one-slot cache of display string positions.
484 (compute_display_string_pos): Accept an additional argument
485 DISP_PROP_P; callers changed. Scan at most 5K characters forward
486 for a display string or property. If found, set DISP_PROP_P
489 * bidi.c (bidi_fetch_char): Accept an additional argument
490 DISP_PROP_P, and pass it to compute_display_string_pos.
491 Only handle text covered by a display string if DISP_PROP_P is returned
492 non-zero. All callers of bidi_fetch_char changed.
494 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
496 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
498 2010-12-03 Don March <don@ohspite.net>
500 * keymap.c (Fdefine_key): Fix non-prefix key error message when
501 last character M-[char] is translated to ESC [char] (bug#7541).
503 2011-08-02 Kenichi Handa <handa@m17n.org>
505 * lisp.h (uniprop_table): Extern it.
507 * chartab.c (uniprop_table): Make it non-static.
509 2011-08-01 Eli Zaretskii <eliz@gnu.org>
511 * xdisp.c (forward_to_next_line_start): Accept additional argument
512 BIDI_IT_PREV, and store into it the state of the bidi iterator had
514 (reseat_at_next_visible_line_start): Use the bidi iterator state
515 returned by forward_to_next_line_start to restore the state of
516 it->bidi_it after backing up to previous newline. (Bug#9212)
518 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
520 * regex.c (re_comp): Protoize.
521 (re_exec): Fix return type.
522 (regexec): Fix type of `ret'. (Bug#9203)
524 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
526 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
527 This is needed if max-image-size is a floating-point number.
529 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
531 * print.c (print_object): Print empty symbol as ##.
533 * lread.c (read1): Read ## as empty symbol.
535 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
537 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
538 setting frame foreground color (Bug#9175).
539 (x_set_background_color): Likewise.
541 * nsmenu.m (-setText): Size tooltip dimensions precisely to
543 (EmacsTooltip -init): Remove bezels and add shadows to
546 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
547 or scroll bar (Bug#8470).
549 * nsfont.m (nsfont_open): Remove assignment to voffset and
550 unnecessary vars hshink, expand, hd, full_height, min_height.
551 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
553 * nsterm.h (nsfont_info): Remove voffset field.
555 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
557 Implement strike-through and overline on NextStep (Bug#8863).
559 * nsfont.m (nsfont_open): Use underline position provided by font,
560 instead of hard-coded value of 2.
561 (nsfont_draw): Call ns_draw_text_decoration instead.
563 * nsterm.h: Add declaration for ns_draw_text_decoration.
565 * nsterm.m (ns_draw_text_decoration): New function for drawing
566 underline, overline, and strike-through.
567 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
568 ns_draw_text_decoration. Change treatment of cursor drawing to
569 accomodate underlining, etc.
571 2011-07-28 Eli Zaretskii <eliz@gnu.org>
573 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
576 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
578 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
579 Without this fix, if a signal arrives just after memory fills up,
580 'malloc' might be invoked reentrantly.
582 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
583 In other words, assume that every image size is allowed, on non-X
584 hosts. This assumption is probably wrong, but it lets Emacs compile.
586 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
588 * regex.c (re_iswctype): Convert return values to boolean.
590 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
592 * xdisp.c (compute_display_string_pos): Don't use cached display
593 string position if the buffer had its restriction changed.
596 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
598 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
600 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
602 Integer signedness and overflow and related fixes. (Bug#9079)
604 * bidi.c: Integer size and overflow fixes.
605 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
606 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
607 (bidi_cache_find_level_change, bidi_cache_ensure_space)
608 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
609 (bidi_find_other_level_edge):
610 Use ptrdiff_t instead of EMACS_INT where either will do.
611 This works better on 32-bit hosts configured --with-wide-int.
612 (bidi_cache_ensure_space): Check for size-calculation overflow.
613 Use % rather than repeated addition, for better worst-case speed.
614 Don't set bidi_cache_size until after xrealloc returns, because it
616 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
617 (bidi_cache_ensure_space): Also check that the bidi cache size
618 does not exceed that of the largest Lisp string or buffer. See Eli
619 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
621 * alloc.c (__malloc_size_t): Remove.
622 All uses replaced by size_t. See Andreas Schwab's note
623 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
625 * image.c: Improve checking for integer overflow.
626 (check_image_size): Assume that f is nonnull, since
627 it is always nonnull in practice. This is one less thing to
628 worry about when checking for integer overflow later.
629 (x_check_image_size): New function, which checks for integer
630 overflow issues inside X.
631 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
632 This removes the need for a memory_full check.
633 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
634 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
635 (xbm_read_bitmap_data): Change locals back to 'int', since
636 their values must fit in 'int'.
637 (xpm_load_image, png_load, tiff_load):
638 Invoke x_create_x_image_and_pixmap earlier,
639 to avoid much needless work if the image is too large.
640 (tiff_load): Treat overly large images as if
641 x_create_x_image_and_pixmap failed, not as malloc failures.
642 (gs_load): Use x_check_image_size.
644 * gtkutil.c: Omit integer casts.
645 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
646 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
648 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
650 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
651 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
652 would wrongly return t on a 64-bit host.
654 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
655 The plain *_OVERFLOW macros run afoul of GCC bug 49705
656 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
657 and therefore cause GCC to emit a bogus diagnostic in some cases.
659 * image.c: Integer signedness and overflow and related fixes.
660 This is not an exhaustive set of fixes, but it's time to
661 record what I've got.
662 (lookup_pixel_color, check_image_size): Remove redundant decls.
663 (check_image_size): Don't assume that arbitrary EMACS_INT values
664 fit in 'int', or that arbitrary 'double' values fit in 'int'.
665 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
666 (tiff_load, imagemagick_load_image):
667 Check for overflow in size calculations.
668 (x_create_x_image_and_pixmap): Remove unnecessary test for
669 xmalloc returning NULL; that can't happen.
670 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
671 (xpm_color_bucket): Use better integer hashing function.
672 (xpm_cache_color): Don't possibly over-allocate memory.
673 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
675 Use ptrdiff_t, not int or size_t, to record sizes.
676 (png_load): Don't assume values greater than 2**31 fit in 'int'.
677 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
678 either works, as we prefer signed integers.
679 (tiff_read_from_memory, tiff_write_from_memory):
680 Return tsize_t, not size_t, since that's what the TIFF API wants.
681 (tiff_read_from_memory): Don't fail simply because the read would
682 go past EOF; instead, return a short read.
683 (tiff_load): Omit no-longer-needed casts.
684 (Fimagemagick_types): Don't assume size fits into 'int'.
686 Improve hashing quality when configured --with-wide-int.
687 * fns.c (hash_string): New function, taken from sxhash_string.
688 Do not discard information about ASCII character case; this
689 discarding is no longer needed.
690 (sxhash-string): Use it. Change sig to match it. Caller changed.
691 * lisp.h: Declare it.
692 * lread.c (hash_string): Remove, since we now use fns.c's version.
693 The fns.c version returns a wider integer if --with-wide-int is
694 specified, so this should help the quality of the hashing a bit.
696 * emacs.c: Integer overflow minor fix.
697 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
698 Define only if GNU_LINUX.
699 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
701 * dispnew.c: Integer signedness and overflow fixes.
702 Remove unnecessary forward decls, that were a maintenance hassle.
703 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
705 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
706 (scrolling_window): Use ptrdiff_t, not int, for byte count.
707 (prepare_desired_row, line_draw_cost):
708 Use int, not unsigned, where either works.
709 (save_current_matrix, restore_current_matrix):
710 Use ptrdiff_t, not size_t, where either works.
711 (init_display): Check for overflow more accurately, and without
712 relying on undefined behavior.
714 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
715 Remove, replacing with the new symbols in lisp.h. All uses changed.
716 * fileio.c (make_temp_name):
717 * filelock.c (lock_file_1, lock_file):
718 * xdisp.c (message_dolog):
719 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
720 Use pMd etc. instead.
721 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
722 replacing the pWIDE etc. symbols removed from editfns.c.
724 * keyboard.h (num_input_events): Now uintmax_t.
725 This is (very slightly) less likely to mess up due to wraparound.
728 * buffer.c: Integer signedness fixes.
729 (alloc_buffer_text, enlarge_buffer_text):
730 Use ptrdiff_t rather than size_t when either will do, as we prefer
733 * alloc.c: Integer signedness and overflow fixes.
734 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
735 (__malloc_size_t): Default to size_t, not to int.
736 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
737 (Fgarbage_collect, mark_object_loop_halt, mark_object):
738 Prefer ptrdiff_t to size_t when either would do, as we prefer
740 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
741 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
742 Now const. Initialize with values that are in range even if char
744 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
745 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
746 These functions do the right thing with sizes > 2**32.
747 (check_depth): Now ptrdiff_t, not int.
748 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
749 Adjust to new way of storing sizes. Check for size overflow bugs
751 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
752 slightly wrong anyway, as it missed one instance of
753 XMALLOC_OVERRUN_CHECK_OVERHEAD.
754 (refill_memory_reserve): Omit needless cast to size_t.
755 (mark_object_loop_halt): Mark as externally visible.
757 * xselect.c: Integer signedness and overflow fixes.
758 (Fx_register_dnd_atom, x_handle_dnd_message):
759 Use ptrdiff_t, not size_t, since we prefer signed.
760 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
761 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
762 x_dnd_atoms_size and x_dnd_atoms_length.
764 * doprnt.c: Prefer signed to unsigned when either works.
768 * xdisp.c (vmessage):
769 Use ptrdiff_t, not size_t, when using or implementing doprnt,
770 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
771 prefer signed arithmetic to avoid comparison confusion.
772 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
775 Assume freestanding C89 headers, string.h, stdlib.h.
776 * data.c, doprnt.c, floatfns.c, print.c:
777 Include float.h unconditionally.
778 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
779 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
780 * regex.c: Likewise for stddef.h, string.h.
781 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
782 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
783 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
784 (STDC_HEADERS): Remove obsolete defines.
785 * sysdep.c: Include limits.h unconditionally.
787 Assume support for memcmp, memcpy, memmove, memset.
788 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
789 * regex.c (memcmp, memcpy):
790 Remove; we assume C89 now.
792 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
793 (__malloc_safe_bcopy): Remove; no longer needed.
795 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
796 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
797 well either way, and we prefer signed to unsigned.
799 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
801 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
802 closes the connection while we're reading (bug#9182).
804 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
806 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
807 are specified (Bug#9168).
809 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
811 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
812 Found by GCC static checking and --with-wide-int on a 32-bit host.
814 2011-07-25 Eli Zaretskii <eliz@gnu.org>
816 * xdisp.c (compute_display_string_pos): Fix logic of caching
817 previous display string position. Initialize cached_prev_pos to
818 -1. Fixes slow-down at the beginning of a buffer.
820 2011-07-24 Eli Zaretskii <eliz@gnu.org>
822 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
823 for attrs[LFACE_FONTSET_INDEX].
825 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
827 * xml.c (parse_region): Remove unused local
828 that was recently introduced.
830 2011-07-23 Eli Zaretskii <eliz@gnu.org>
832 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
833 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
835 * xdisp.c (move_it_in_display_line_to): Record the best matching
836 position for TO_CHARPOS while scanning the line, and restore it on
837 exit if none of the characters scanned was an exact match.
838 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
839 when exact match is impossible due to invisible text, and the
842 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
844 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
847 2011-07-22 Eli Zaretskii <eliz@gnu.org>
849 Fix a significant slow-down of cursor motion with C-n, C-p,
850 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
851 auto-repeat under bidi redisplay in fontified buffers.
852 * xdisp.c (compute_stop_pos_backwards): New function.
853 (next_element_from_buffer): Call compute_stop_pos_backwards to
854 find a suitable prev_stop when we find ourselves before
856 (reseat): Don't look for prev_stop, as that could mean a very long
858 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
859 <cached_disp_overlay_modiff>: Cache for last found display string
861 (compute_display_string_pos): Return the cached position if asked
862 about the same buffer in the same area of character positions, and
863 the buffer wasn't changed since the time the display string
866 2011-07-22 Eli Zaretskii <eliz@gnu.org>
868 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
869 is an integer, which is important for empty lines. (Bug#9149)
871 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
873 * frame.c (Fmodify_frame_parameters): In tty case, update the
874 default face if necessary (Bug#4238).
876 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
878 * editfns.c (Fstring_to_char): No need to explain what a character
879 is in the docstring (Bug#6576).
881 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
883 * xml.c (parse_region): Make sure we always return a tree.
885 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
887 * xml.c (parse_region): If a document contains only comments,
890 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
892 * xml.c (make_dom): Return comments, too.
894 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
897 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
898 and the surrounding thread.
899 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
900 rather than fgets, and retry after EINTR. Otherwise, 'emacs
901 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
903 * s/openbsd.h (BROKEN_SIGIO): Define.
904 * unexelf.c (unexec) [__OpenBSD__]:
905 Don't update the .mdebug section of the Alpha COFF symbol table.
907 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
909 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
912 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
914 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
915 This fixes some race conditions on the permissions of any newly
918 * alloc.c (valid_pointer_p): Use pipe, not open.
919 This fixes some permissions issues when debugging.
921 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
922 If fchown fails to set both uid and gid, try to set just gid,
923 as that is sometimes allowed. Adjust the file's mode to eliminate
924 setuid or setgid bits that are inappropriate if fchown fails.
926 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
928 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
929 to compare Lisp_Objects.
930 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
931 global_gnutls_log_level, don't mistake it for a Lisp_Object.
932 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
934 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
936 * lread.c (read_integer): Unread even EOF character.
937 (read1): Likewise. Properly record start position of symbol.
939 * lread.c (read1): Read `#:' as empty uninterned symbol if no
940 symbol character follows.
942 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
944 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
945 This works around a problem with the previous change to Fcopy_file.
946 Recent glibc declares fchown with __attribute__((warn_unused_result)),
947 and without this change, GCC might complain about discarding
948 fchown's return value.
950 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
952 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
954 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
956 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
958 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
960 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
961 it's used from the C level.
963 * process.c: Use the same condition for POLL_FOR_INPUT in both
964 keyboard.c and process.c (bug#1858).
966 2011-07-09 Lawrence Mitchell <wence@gmx.li>
968 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
969 (Fgnutls_boot): Use it.
971 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
973 * doc.c (Fsubstitute_command_keys): Revert last change.
975 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
977 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
978 quotes the next character, and doesn't affect other longer
979 sequences (bug#8935).
981 * lread.c (syms_of_lread): Clarify that is isn't only
982 `eval-buffer' and `eval-defun' that's affected by
983 `lexical-binding' (bug#8460).
985 2011-07-15 Eli Zaretskii <eliz@gnu.org>
987 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
988 bidi redisplay when a line includes both an image and is
991 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
993 Fix minor problems found by static checking.
994 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
995 (elsz): Now a signed constant, not a size_t var. We prefer signed
996 types to unsigned, to avoid integer comparison confusion. Without
997 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
998 "cannot optimize loop, the loop counter may overflow", a symptom
1000 * indent.c (Fvertical_motion): Mark locals as initialized.
1001 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1003 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1005 * search.c (Fre_search_backward): Mention `case-fold-search' in
1006 all the re_search_* functions (bug#8138).
1008 * keyboard.c (Fopen_dribble_file): Document when the file is
1011 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1013 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1016 Support bidi reordering of display and overlay strings.
1017 * xdisp.c (compute_display_string_pos)
1018 (compute_display_string_end): Accept additional argument STRING.
1019 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1020 (reseat_to_string): Initialize bidi_it->string.s and
1021 bidi_it->string.schars.
1022 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1023 NULL (avoids a crash in bidi_paragraph_init).
1024 Initialize itb.string.lstring.
1025 (init_iterator): Call bidi_init_it only of a valid
1026 buffer position was specified. Initialize paragraph_embedding to
1028 (reseat_to_string): Initialize the bidi iterator.
1029 (display_string): If we need to ignore text properties of
1030 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1031 original value of -1 will not work with bidi.)
1032 (compute_display_string_pos): First arg is now struct
1033 `text_pos *'; all callers changed. Support display properties on
1035 (compute_display_string_end): Support display properties on Lisp
1037 (init_iterator, reseat_1, reseat_to_string): Initialize the
1038 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1039 when iterating on a string not from display properties).
1040 (compute_display_string_pos, compute_display_string_end):
1041 Fix calculation of the object to scan. Fixes an error when using
1043 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1044 base_level_stop; instead, set base_level_stop to BEGV.
1045 Fixes crashes in vertical-motion.
1046 (next_element_from_buffer): Improve commentary for when
1047 the iterator is before prev_stop.
1048 (init_iterator): Initialize bidi_p from the default value of
1049 bidi-display-reordering, not from buffer-local value. Use the
1050 buffer-local value only if initializing for buffer iteration.
1051 (handle_invisible_prop): Support invisible properties on strings
1052 that are being bidi-reordered.
1053 (set_iterator_to_next): Support bidi reordering of C strings and
1055 (next_element_from_string): Support bidi reordering of Lisp
1057 (handle_stop_backwards): Support Lisp strings as well.
1058 (display_string): Support display of R2L glyph rows.
1059 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1060 (init_iterator): Don't initialize it->bidi_p for strings
1062 (reseat_to_string): Initialize it->bidi_p for strings here.
1063 (next_element_from_string, next_element_from_c_string)
1064 (next_element_from_buffer): Add xassert's for correspondence
1065 between IT's object being iterated and it->bidi_it.string
1067 (face_before_or_after_it_pos): Support bidi iteration.
1068 (next_element_from_c_string): Handle the case of the first string
1069 character that is not the first one in the visual order.
1070 (get_visually_first_element): New function, refactored from common
1071 parts of next_element_from_buffer, next_element_from_string, and
1072 next_element_from_c_string.
1073 (tool_bar_lines_needed, redisplay_tool_bar)
1074 (display_menu_bar): Force left-to-right direction. Add a FIXME
1075 comment for making that be controlled by a user option.
1076 (push_it, pop_it): Save and restore the state of the
1077 bidi iterator. Save and restore the bidi_p flag.
1078 (pop_it): Iterate out of display property for string iteration as
1080 (iterate_out_of_display_property): Support iteration over strings.
1081 (handle_single_display_spec): Set up it->bidi_it for iteration
1082 over a display string, and call bidi_init_it.
1083 (handle_single_display_spec, next_overlay_string)
1084 (get_overlay_strings_1, push_display_prop): Set up the bidi
1085 iterator for displaying display or overlay strings.
1086 (forward_to_next_line_start): Don't use the shortcut if
1088 (back_to_previous_visible_line_start): If handle_display_prop
1089 pushed the iterator stack, restore the internal state of the bidi
1090 iterator by calling bidi_pop_it same number of times.
1091 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1092 and we are bidi-iterating, don't decrement the iterator position;
1093 instead, set the first_elt flag in the bidi iterator, to produce
1095 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1096 (push_display_prop): xassert that we are iterating a buffer.
1097 (push_it, pop_it): Save and restore paragraph_embedding member.
1098 (handle_single_display_spec, next_overlay_string)
1099 (get_overlay_strings_1, reseat_1, reseat_to_string)
1100 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1101 correctly. Don't assume unibyte strings are not bidi-reordered.
1102 (compute_display_string_pos)
1103 (compute_display_string_end): Fix handling the case of C string.
1104 (push_it, pop_it): Save and restore from_disp_prop_p.
1105 (handle_single_display_spec, push_display_prop): Set the
1106 from_disp_prop_p flag.
1107 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1108 (pop_it): Call iterate_out_of_display_property only if we are
1109 popping after iteration over a string that came from a display
1110 property. Fix a typo in popping stretch info. Add an assertion
1111 for verifying that the iterator position is in sync with the bidi
1113 (handle_single_display_spec, get_overlay_strings_1)
1114 (push_display_prop): Fix initialization of paragraph direction for
1115 string when that of the parent object is not yet determined.
1116 (reseat_1): Call bidi_init_it to resync the bidi
1117 iterator with IT's position. (Bug#7616)
1118 (find_row_edges): If ROW->start.pos gives position
1119 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1120 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1121 Reset the from_disp_prop_p flag.
1122 (SAVE_IT, RESTORE_IT): New macros.
1123 (pos_visible_p, face_before_or_after_it_pos)
1124 (back_to_previous_visible_line_start)
1125 (move_it_in_display_line_to, move_it_in_display_line)
1126 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1127 (try_scrolling, redisplay_window, display_line): Use them when
1128 saving a temporary copy of the iterator and restoring it back.
1129 (back_to_previous_visible_line_start, reseat_1)
1130 (init_iterator): Empty the bidi cache "stack".
1131 (move_it_in_display_line_to): If iterator ended up at
1132 EOL, but we never saw any buffer positions smaller than
1133 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1134 motion in bidi-reordered lines.
1135 (move_it_in_display_line_to): Record prev_method and prev_pos
1136 immediately before the call to set_iterator_to_next. Fixes cursor
1137 motion in bidi-reordered lines with stretch glyphs and strings
1138 displayed in margins. (Bug#8133) (Bug#8867)
1139 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1141 (pos_visible_p): Support positions in bidi-reordered lines.
1142 Save and restore bidi cache.
1144 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1145 (bidi_paragraph_info): Delete unused struct.
1146 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1147 (bidi_cache_start): New variable.
1148 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1150 (bidi_cache_fetch_state, bidi_cache_search)
1151 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1152 (bidi_cache_find, bidi_peek_at_next_level)
1153 (bidi_level_of_next_char, bidi_find_other_level_edge)
1154 (bidi_move_to_visually_next): Compare cache index with
1155 bidi_cache_start rather than with zero.
1156 (bidi_fetch_char): Accept new argument STRING; all callers
1157 changed. Support iteration over a string. Support strings with
1158 display properties. Support unibyte strings. Fix the type of
1159 `len' according to what STRING_CHAR_AND_LENGTH expects.
1160 (bidi_paragraph_init, bidi_resolve_explicit_1)
1161 (bidi_resolve_explicit, bidi_resolve_weak)
1162 (bidi_level_of_next_char, bidi_move_to_visually_next):
1163 Support iteration over a string.
1164 (bidi_set_sor_type, bidi_resolve_explicit_1)
1165 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1166 can now be zero (for strings); special values 0 and -1 were
1167 changed to -1 and -2, respectively.
1168 (bidi_char_at_pos): New function.
1169 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1170 Call it instead of FETCH_MULTIBYTE_CHAR.
1171 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1172 initialized to valid values.
1173 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1175 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1176 the test for valid cached positions. Fix the logic for looking up
1177 the sentinel state in the cache. GCPRO the Lisp string we are
1179 (bidi_push_it, bidi_pop_it): New functions.
1180 (bidi_initialize): Initialize the bidi cache start stack pointer.
1181 (bidi_cache_ensure_space): New function, refactored from part of
1182 bidi_cache_iterator_state. Don't assume the required size is just
1183 one BIDI_CACHE_CHUNK away.
1184 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1185 (bidi_count_bytes, bidi_char_at_pos): New functions.
1186 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1187 always valid if bidi_cache_idx is valid.
1188 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1189 is valid if it's going to be used.
1190 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1191 (bidi_cache_fetch_state, bidi_cache_search)
1192 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1193 (bidi_cache_iterator_state, bidi_cache_find)
1194 (bidi_find_other_level_edge, bidi_cache_start_stack):
1195 All variables related to cache indices are now EMACS_INT.
1197 * dispextern.h (struct bidi_string_data): New structure.
1198 (struct bidi_it): New member `string'. Make flag members be 1-bit
1199 fields, and put them last in the struct.
1200 (compute_display_string_pos, compute_display_string_end):
1202 (bidi_push_it, bidi_pop_it): Add prototypes.
1203 (struct iterator_stack_entry): New members bidi_p,
1204 paragraph_embedding, and from_disp_prop_p.
1205 (struct it): Member bidi_p is now a bit field 1 bit wide.
1206 (bidi_shelve_cache, bidi_unshelve_cache):
1209 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1210 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1211 and vector-like objects.
1213 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1214 cache around display iteration.
1216 * window.c (Fwindow_end, window_scroll_pixel_based)
1217 (displayed_window_lines, Frecenter): Save and restore the bidi
1218 cache around display iteration.
1220 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1222 * editfns.c (Fdelete_region): Clarify the use of the named
1223 parameters (bug#6788).
1225 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1227 * indent.c (Fvertical_motion): Set and restore w->pointm when
1228 saving and restoring the window's buffer (Bug#9006).
1230 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1232 * editfns.c (Fstring_to_char): Clarify just what is returned
1233 (bug#6576). Text by Eli Zaretskii.
1235 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1237 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1239 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1241 * buffer.c (mmap_find): Fix a typo.
1243 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1245 Fix execution of x selection hooks.
1246 * xselect.c (Qx_lost_selection_functions)
1247 (Qx_sent_selection_functions): New vars.
1248 (syms_of_xselect): DEFSYM them.
1249 (x_handle_selection_request): Pass Qx_sent_selection_functions
1250 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1251 (x_handle_selection_clear,x_clear_frame_selections):
1252 Pass Qx_lost_selection_functions rather than
1253 Vx_lost_selection_functions to Frun_hook_with_args.
1255 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1257 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1258 The old code sometimes used this field without initializing it.
1260 * alloc.c (gc_sweep): Don't read past end of array.
1261 In theory, the old code could also have corrupted Emacs internals,
1262 though it'd be very unlikely.
1264 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1266 * character.c (Fcharacterp): Don't advertise optional ignored
1267 argument. (Bug#4026)
1269 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1271 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1274 * window.c (Fset_window_start): Doc fix (bug#4199).
1275 (Fset_window_hscroll): Ditto.
1277 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1279 Fix minor new problems caught by GCC 4.6.1.
1280 * term.c (init_tty): Remove unused local.
1281 * xsettings.c (store_monospaced_changed): Define this function only
1282 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1285 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1287 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1289 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1291 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1292 are the mini-buffer and the echo area (bug#3320).
1294 * term.c (init_tty): Remove support for supdup, c10 and perq
1295 terminals, which are no longer supported (bug#1482).
1297 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1299 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1301 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1303 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1304 for non-popups (Bug#3642).
1306 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1308 * alloc.c (reset_malloc_hooks): Protoize.
1309 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1310 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1311 * cm.c (losecursor): Likewise.
1312 * data.c (fmod): Likewise.
1313 * dispnew.c (swap_glyphs_in_rows): Likewise.
1314 * emacs.c (memory_warning_signal): Likewise.
1315 * floatfns.c (float_error): Likewise.
1316 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1317 (otf_open, font_otf_capability, generate_otf_features)
1318 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1320 * image.c (pbm_read_file): Likewise.
1321 * indent.c (string_display_width): Likewise.
1322 * intervals.c (check_for_interval, search_for_interval)
1323 (inc_interval_count, count_intervals, root_interval)
1324 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1325 * lread.c (defalias): Likewise.
1326 * ralloc.c (r_alloc_check): Likewise.
1327 * regex.c (set_image_of_range_1, set_image_of_range)
1328 (regex_grow_registers): Likewise.
1329 * sysdep.c (strerror): Likewise.
1330 * termcap.c (valid_filename_p, tprint, main): Likewise.
1331 * tparam.c (main): Likewise.
1332 * unexhp9k800.c (run_time_remap, save_data_space)
1333 (update_file_ptrs, read_header, write_header, calculate_checksum)
1334 (copy_file, copy_rest, display_header): Likewise.
1335 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1337 * xdisp.c (check_it): Likewise.
1338 * xfaces.c (register_color, unregister_color, unregister_colors):
1340 * xfns.c (print_fontset_result): Likewise.
1341 * xrdb.c (member, fatal, main): Likewise.
1343 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1345 Fix minor problems found by static checking (Bug#9031).
1346 * chartab.c (char_table_set_range, map_sub_char_table):
1347 Remove unused locals.
1348 (uniprop_table): Now static.
1349 * composite.c (_work_char): Remove unused static var.
1351 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1353 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1355 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1357 * gtkutil.c (qttip_cb): Remove code without function.
1359 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1361 * w32.c (pthread_sigmask): New stub.
1363 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1365 Use pthread_sigmask, not sigprocmask (Bug#9010).
1366 sigprocmask is portable only for single-threaded applications, and
1367 Emacs can be multi-threaded when it uses GTK.
1368 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1370 * callproc.c (Fcall_process):
1371 * process.c (create_process):
1372 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1373 Use pthread_sigmask, not sigprocmask.
1375 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1377 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1378 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1381 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1383 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1384 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1385 (xg_hide_tooltip): Fix comment.
1387 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1388 in registerServicesMenuSendTypes.
1389 (validRequestorForSendType): Don't check ns_return_types.
1391 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1394 2011-07-08 Jason Rumney <jasonr@gnu.org>
1396 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1397 frame struct members of non-existent frames (Bug#6284).
1399 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1401 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1402 variable firstTime not needed on OSX >= 10.6.
1403 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1404 >= 10.5. Use setKnobProportion, setDoubleValue.
1406 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1407 (MAC_OS_X_VERSION_10_5): Define if not defined.
1408 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1409 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1410 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1412 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1413 cString and lossyCString on OSX >= 10.4
1415 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1416 sizeToFit on OSX >= 10.2.
1418 * nsimage.m (allocInitFromFile): Don't use deprecated method
1419 bestRepresentationForDevice on OSX >= 10.6.
1421 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1424 * emacs.c: Declare unexec_init_emacs_zone.
1426 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1428 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1430 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1431 on svcsMenu (Bug#8842).
1433 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1435 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1437 * nsterm.m (QUTF8_STRING): Declare.
1438 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1439 (validRequestorForSendType): Return type is (id).
1440 Change indexOfObjectIdenticalTo to indexOfObject.
1441 Check if we have local selection before returning self (Bug#8842).
1442 (writeSelectionToPasteboard): Put local selection into paste board
1443 if we have a local selection (Bug#8842).
1444 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1446 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1447 (ns_get_local_selection): Declare.
1449 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1451 * keymap.c (describe_map_tree): Don't insert a double newline at
1452 the end of the buffer (bug#1169) and return whether we inserted
1455 * callint.c (Fcall_interactively): Change "reading args" to
1456 "providing args" to try to clarify what it does (bug#1010).
1458 2011-07-07 Kenichi Handa <handa@m17n.org>
1460 * composite.c (composition_compute_stop_pos): Ignore a static
1461 composition starting before CHARPOS (Bug#8915).
1463 * xdisp.c (handle_composition_prop): Likewise.
1465 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1467 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1470 2011-07-07 Kenichi Handa <handa@m17n.org>
1472 * character.h (unicode_category_t): New enum type.
1474 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1475 (Qchar_code_property_table): New variable.
1476 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1477 (UNIPROP_COMPRESSED_FORM_P): New macros.
1478 (char_table_ascii): Uncompress the compressed values.
1479 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1480 Uncompress the compressed values.
1481 (sub_char_table_ref_and_range): Likewise.
1482 (char_table_ref_and_range): Uncompress the compressed values.
1483 (sub_char_table_set): New arg is_uniprop. Callers changed.
1484 Uncompress the compressed values.
1485 (sub_char_table_set_range): Args changed. Callers changed.
1486 (char_table_set_range): Adjuted for the above change.
1487 (map_sub_char_table): Delete args default_val and parent. Add arg
1488 top. Give decoded values to a Lisp function.
1489 (map_char_table): Adjust for the above change. Give decoded
1490 values to a Lisp function. Gcpro more variables.
1491 (uniprop_table_uncompress)
1492 (uniprop_decode_value_run_length): New functions.
1493 (uniprop_decoder, uniprop_decoder_count): New variables.
1494 (uniprop_get_decoder, uniprop_encode_value_character)
1495 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1497 (uniprop_encoder, uniprop_encoder_count): New variables.
1498 (uniprop_get_encoder, uniprop_table)
1499 (Funicode_property_table_internal, Fget_unicode_property_internal)
1500 (Fput_unicode_property_internal): New functions.
1501 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1502 Sunicode_property_table_internal, Sget_unicode_property_internal,
1503 and Sput_unicode_property_internal. Defvar_lisp
1504 char-code-property-alist.
1506 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1507 Vunicode_category_table.
1509 * font.c (font_range): Adjust for the change of
1510 Vunicode_category_table.
1512 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1514 * m/iris4d.h: Remove file, move contents ...
1515 * s/irix6-5.h: ... here.
1517 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1519 Remove unportable assumption about struct layout (Bug#8884).
1520 * alloc.c (mark_buffer):
1521 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1522 (clone_per_buffer_values): Don't assume that
1523 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1524 This isn't true in general, and it's particularly not true
1525 if Emacs is configured with --with-wide-int.
1526 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1527 New macros, used in the buffer.c change.
1529 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1531 * xsettings.c: Use both GConf and GSettings if both are available.
1532 (store_config_changed_event): Add comment.
1533 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1534 (store_tool_bar_style_changed): New functions.
1535 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1536 (struct xsettings): Move font inside HAVE_XFT.
1537 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1538 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1539 Move inside HAVE_XFT.
1540 (something_changed_gsettingsCB): Rename from something_changedCB.
1541 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1543 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1544 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1545 (something_changed_gconfCB): Rename from something_changedCB.
1546 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1547 (parse_settings): Move check for font inside HAVE_XFT.
1548 (read_settings, apply_xft_settings): Add comment.
1549 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1550 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1551 call store_font_name_changed.
1552 (xft_settings_event): Add comment.
1553 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1554 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1555 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1556 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1557 (xsettings_initialize): Call init_gsettings last.
1558 (xsettings_get_system_font, xsettings_get_system_normal_font):
1561 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1563 Random fixes. E.g., (random) never returned negative values.
1564 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1565 subseconds part to the entropy, as that's a bit more random.
1566 Prefer signed to unsigned, since the signedness doesn't matter and
1567 in general we prefer signed. When given a limit, use a
1568 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1569 latter isn't right if USE_2_TAGS_FOR_INTS.
1570 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1571 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1573 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1575 * textprop.c (text_property_stickiness):
1576 Obey Vtext_property_default_nonsticky.
1577 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1578 * w32fns.c (syms_of_w32fns):
1579 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1581 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1583 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1584 This is more efficient than Ffile_directory_p and avoids a minor race.
1586 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1588 * buffer.c (Foverlay_put): Say what the return value is
1591 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1592 is a directory before asking whether to use the file name
1594 (barf_or_query_if_file_exists): Make the "File is a directory"
1595 error be more correct.
1597 * fns.c (Frequire): Remove the mention of the .gz files, since
1598 that's installation-specific, but keep the mention of
1599 `get-load-suffixes'.
1601 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1603 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1604 Report string overflow if the output is too long.
1606 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1608 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1609 (syms_of_gnutls): Remove duplicate DEFSYM for
1610 Qgnutls_bootprop_verify_hostname_error, an error for
1611 Qgnutls_bootprop_verify_error (which is no longer used).
1613 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1614 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1615 Also (re)move comments that are misplaced or no longer relevant.
1617 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1619 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1621 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1623 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1624 and background color parameters if they have been changed.
1626 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1628 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1630 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1632 * xsettings.c (SYSTEM_FONT): Define only when used.
1633 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1635 * keymap.c (access_keymap_1): Now static.
1637 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1639 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1640 leave any prefix arg for the up event (Bug#1586).
1642 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1644 * lread.c (syms_of_lread): Mention single symbols defined by
1645 `defvar' or `defconst' (bug#7154).
1647 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1648 (Frequire): Mention get-load-suffixes.
1650 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1652 * window.h (window): Remove clone_number slot.
1653 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1655 (make_parent_window, make_window, saved_window)
1656 (Fset_window_configuration, save_window_save): Don't deal with
1658 * buffer.c (Qclone_number): Remove declaration.
1659 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1661 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1663 Add multiple inheritance to keymaps.
1664 * keymap.c (Fmake_composed_keymap): New function.
1665 (Fset_keymap_parent): Simplify.
1666 (fix_submap_inheritance): Remove.
1667 (access_keymap_1): New function extracted from access_keymap to handle
1668 embedded parents and handle lists of maps.
1669 (access_keymap): Use it.
1670 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1671 (Fcopy_keymap): Handle embedded parents.
1672 (Fcommand_remapping, define_as_prefix): Simplify.
1673 (Fkey_binding): Simplify.
1674 (syms_of_keymap): Move minibuffer-local-completion-map,
1675 minibuffer-local-filename-completion-map,
1676 minibuffer-local-must-match-map, and
1677 minibuffer-local-filename-must-match-map to Elisp.
1678 (syms_of_keymap): Defsubr make-composed-keymap.
1679 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1680 (parse_menu_item): Trivial simplification.
1682 2011-07-01 Glenn Morris <rgm@gnu.org>
1684 * Makefile.in (SETTINGS_LIBS): Fix typo.
1686 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1688 * coding.c (Fencode_coding_string): Record the last coding system
1689 used, as the function doc string says (bug#8738).
1691 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1693 * xsettings.c (store_monospaced_changed): Take new font as arg and
1694 check for change against current_mono_font.
1695 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1696 (emacs_settings_constructor, emacs_settings_get_property)
1697 (emacs_settings_set_property, emacs_settings_class_init)
1698 (emacs_settings_init, gsettings_obj): Remove.
1699 (something_changedCB): New function for HAVE_GSETTINGS.
1700 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1701 with value as argument.
1702 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1703 g_settings_new (Bug#8967). Do not create gsettings_obj.
1704 Remove calls to g_settings_bind. Connect something_changedCB to
1707 * xgselect.c: Add defined (HAVE_GSETTINGS).
1708 (xgselect_initialize): Ditto.
1710 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1711 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1714 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1716 * eval.c (struct backtrace): Simplify and port the data structure.
1717 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1718 signed bit field, as this assumption is not portable and it makes
1719 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1720 "char debug_on_exit : 1" as this is not portable either; instead,
1721 use the portable "unsigned int debug_on_exit : 1". Remove unused
1722 member evalargs. Remove obsolete comments about cc bombing out.
1724 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1726 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1727 Let HAVE_GSETTINGS override HAVE_GCONF.
1728 (store_monospaced_changed): New function.
1729 (EMACS_SETTINGS): A new type derived from GObject to handle
1730 GSettings notifications.
1731 (emacs_settings_constructor, emacs_settings_get_property)
1732 (emacs_settings_set_property, emacs_settings_class_init):
1734 (gsettings_client, gsettings_obj): New variables.
1735 (GSETTINGS_SCHEMA): New define.
1736 (something_changedCB): Call store_monospaced_changed.
1737 (init_gsettings): New function.
1738 (xsettings_initialize): Call init_gsettings.
1739 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1742 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1745 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1747 * window.c (resize_root_window, grow_mini_window)
1748 (shrink_mini_window): Rename Qresize_root_window to
1749 Qwindow_resize_root_window and Qresize_root_window_vertically to
1750 Qwindow_resize_root_window_vertically.
1752 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1754 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1756 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1758 * makefile.w32-in: Redesign dependencies so they reflect more
1759 clearly which files are directly included by each source file,
1760 and not through other includes.
1762 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1764 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1765 (sort_overlays, overlay_strings): When an overlay's clone number
1766 matches the window's clone number process the overlay even if
1767 the overlay's window property doesn't match the current window.
1769 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1770 (Fwindow_hchild): Rename to Fwindow_left_child.
1771 (Fwindow_next): Rename to Fwindow_next_sibling.
1772 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1773 (resize_window_check): Rename to window_resize_check.
1774 (resize_window_apply): Rename to window_resize_apply.
1775 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1776 (Fdelete_other_windows_internal, resize_frame_windows)
1777 (Fsplit_window_internal, Fdelete_window_internal)
1778 (grow_mini_window, shrink_mini_window)
1779 (Fresize_mini_window_internal): Fix callers accordingly.
1781 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1783 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1784 (emacs_fixed_set_min_size): Remove.
1785 (emacs_fixed_new): Take frame as argument.
1787 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1788 (_EmacsFixedPrivate): Remove minwidth/height.
1789 Add struct frame *f.
1790 (emacs_fixed_init): Initialize priv->f.
1791 (get_parent_class, emacs_fixed_set_min_size): Remove.
1792 (emacs_fixed_new): Set priv->f to argument.
1793 (emacs_fixed_get_preferred_width)
1794 (emacs_fixed_get_preferred_height): Use min_width/height from
1795 frames size_hint to set minimum and natural (Bug#8919).
1796 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1797 and use min_width/height from frames size_hint to set
1798 min_width/height (Bug#8919).
1800 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1801 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1804 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1806 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1807 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1810 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1812 * process.c (wait_reading_process_output): Bypass select if
1813 waiting for a cell while ignoring keyboard input, and input is
1814 pending. Suggested by Jan Djärv (Bug#8869).
1816 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1818 Use gnulib's dup2 module instead of rolling our own.
1819 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1821 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1823 * dispnew.c (scrolling_window): Before scrolling, turn off a
1824 mouse-highlight in the window being scrolled.
1826 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1828 Move DEFSYM to lisp.h and use everywhere.
1830 * character.h (DEFSYM): Move declaration...
1831 * lisp.h (DEFSYM): ...here.
1837 * w32select.c: Don't include character.h.
1839 * alloc.c (syms_of_alloc):
1840 * buffer.c (syms_of_buffer):
1841 * bytecode.c (syms_of_bytecode):
1842 * callint.c (syms_of_callint):
1843 * casefiddle.c (syms_of_casefiddle):
1844 * casetab.c (init_casetab_once):
1845 * category.c (init_category_once, syms_of_category):
1846 * ccl.c (syms_of_ccl):
1847 * cmds.c (syms_of_cmds):
1848 * composite.c (syms_of_composite):
1849 * dbusbind.c (syms_of_dbusbind):
1850 * dired.c (syms_of_dired):
1851 * dispnew.c (syms_of_display):
1852 * doc.c (syms_of_doc):
1853 * editfns.c (syms_of_editfns):
1854 * emacs.c (syms_of_emacs):
1855 * eval.c (syms_of_eval):
1856 * fileio.c (syms_of_fileio):
1857 * fns.c (syms_of_fns):
1858 * frame.c (syms_of_frame):
1859 * fringe.c (syms_of_fringe):
1860 * insdel.c (syms_of_insdel):
1861 * keymap.c (syms_of_keymap):
1862 * lread.c (init_obarray, syms_of_lread):
1863 * macros.c (syms_of_macros):
1864 * msdos.c (syms_of_msdos):
1865 * print.c (syms_of_print):
1866 * process.c (syms_of_process):
1867 * search.c (syms_of_search):
1868 * sound.c (syms_of_sound):
1869 * syntax.c (init_syntax_once, syms_of_syntax):
1870 * terminal.c (syms_of_terminal):
1871 * textprop.c (syms_of_textprop):
1872 * undo.c (syms_of_undo):
1873 * w32.c (globals_of_w32):
1874 * window.c (syms_of_window):
1875 * xdisp.c (syms_of_xdisp):
1876 * xfaces.c (syms_of_xfaces):
1877 * xfns.c (syms_of_xfns):
1878 * xmenu.c (syms_of_xmenu):
1879 * xsettings.c (syms_of_xsettings):
1880 * xterm.c (syms_of_xterm): Use DEFSYM.
1882 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1884 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1886 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1888 Integer and buffer overflow fixes (Bug#8873).
1890 * print.c (printchar, strout): Check for string overflow.
1891 (PRINTPREPARE, printchar, strout):
1892 Don't set size unless allocation succeeds.
1894 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1895 for sizes. Check for string overflow more accurately.
1896 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1898 * macros.c: Integer and buffer overflow fixes.
1899 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1900 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1901 Use ptrdiff_t, not int, for sizes.
1902 Don't increment bufsize until after realloc succeeds.
1903 Check for size-calculation overflow.
1904 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1906 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1908 * lread.c: Integer overflow fixes.
1909 (read_integer): Radix is now EMACS_INT, not int,
1910 to improve quality of diagnostics for out-of-range radices.
1911 Calculate buffer size correctly for out-of-range radices.
1912 (read1): Check for integer overflow in radices, and in
1913 read-circle numbers.
1914 (read_escape): Avoid int overflow.
1915 (Fload, openp, read_buffer_size, read1)
1916 (substitute_object_recurse, read_vector, read_list, map_obarray):
1917 Use ptrdiff_t, not int, for sizes.
1918 (read1): Use EMACS_INT, not int, for sizes.
1919 Check for size overflow.
1921 * image.c (cache_image): Check for size arithmetic overflow.
1923 * lread.c: Integer overflow issues.
1924 (saved_doc_string_size, saved_doc_string_length)
1925 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1926 Now ptrdiff_t, not int.
1927 (read1): Don't assume doc string length fits in int. Check for
1928 out-of-range doc string lengths.
1929 (read_list): Don't assume file position fits in int.
1930 (read_escape): Check for hex character overflow.
1932 2011-06-22 Leo Liu <sdl.web@gmail.com>
1934 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1935 Move to minibuffer.el.
1937 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1939 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1940 The following patches are for when GLYPH_DEBUG && !XASSERT.
1941 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1942 * dispnew.c (flush_stdout):
1943 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1944 Mark as externally visible.
1945 * dispnew.c (check_window_matrix_pointers): Now static.
1946 * dispnew.c (window_to_frame_vpos):
1947 * xfns.c (unwind_create_frame):
1948 * xterm.c (x_check_font): Remove unused local.
1949 * scroll.c (CHECK_BOUNDS):
1950 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1951 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1952 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1953 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1954 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1956 (debug_method_add): Use va_list and vsprintf rather than relying
1957 on undefined behavior with wrong number of arguments.
1958 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1959 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1960 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1961 since we're not interested in debugging glyphs with old libraries.
1962 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1963 GCC 4.6.0's static checking.
1965 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1967 Integer overflow and signedness fixes (Bug#8873).
1968 A few related buffer overrun fixes, too.
1970 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1972 * dispextern.h (struct face.stipple):
1973 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1974 (x_bitmap_mask, x_allocate_bitmap_record)
1975 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1976 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1977 (x_create_bitmap_from_xpm_data):
1978 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1979 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1981 * xfaces.c (load_pixmap):
1982 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1983 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1984 (.bitmaps_last, struct x_output.icon_bitmap):
1985 Use ptrdiff_t, not int, for bitmap indexes.
1986 (x_allocate_bitmap_record): Check for size overflow.
1987 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1989 Use ptrdiff_t, not int, for overlay counts.
1990 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1991 * editfns.c (overlays_around, get_pos_property):
1992 * textprop.c (get_char_property_and_overlay):
1993 * xdisp.c (next_overlay_change, note_mouse_highlight):
1994 * xfaces.c (face_at_buffer_position):
1995 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1996 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1997 (Fnext_overlay_change, Fprevious_overlay_change)
1998 (mouse_face_overlay_overlaps, Foverlays_in):
1999 Use ptrdiff_t, not int, for sizes.
2000 (overlays_at, overlays_in): Check for size-calculation overflow.
2002 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2004 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2005 (x_session_initialize): Do not assume string length fits in int.
2007 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2008 This is unlikely, but can occur if DPI is outlandish.
2010 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2011 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2013 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2014 * xrdb.c (magic_file_p, search_magic_path):
2015 Omit last arg SUFFIX; it was always 0. All callers changed.
2016 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2018 * xfont.c (xfont_match): Avoid need for strlen.
2020 * xfns.c: Don't assume strlen fits in int.
2021 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2023 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2024 not unsigned long, as we prefer signed integers. All callers changed.
2025 Detect integer overflow in repeat count.
2026 (message_dolog): Don't assume print length fits in 39 bytes.
2027 (display_mode_element): Don't assume strlen fits in int.
2029 * termcap.c: Don't assume sizes fit in int and never overflow.
2030 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2031 (gobble_line): Check for size-calculation overflow.
2033 * minibuf.c (Fread_buffer):
2034 * lread.c (intern, intern_c_string):
2035 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2036 Don't assume string length fits in int.
2038 * keyboard.c (parse_tool_bar_item):
2039 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2041 * font.c: Don't assume string length fits in int.
2042 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2043 Use ptrdiff_t, not int.
2044 (font_intern_prop): Don't assume string length fits in int.
2045 Don't assume integer property fits in fixnum.
2046 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2048 * filelock.c: Fix some buffer overrun and integer overflow issues.
2049 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2050 Reformulate so as not to need the command string.
2051 Invoke gzip -cd rather than gunzip, as it's more portable.
2052 (lock_info_type, lock_file_1, lock_file):
2053 Don't assume pid_t and time_t fit in unsigned long.
2054 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2055 (current_lock_owner): Prefer signed type for sizes.
2056 Use memcpy, not strncpy, where memcpy is what is really wanted.
2057 Don't assume (via atoi) that time_t and pid_t fit in int.
2058 Check for time_t and/or pid_t out of range, e.g., via a network share.
2059 Don't alloca where an auto var works fine.
2061 * fileio.c: Fix some integer overflow issues.
2062 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2063 Don't assume string length fits in int.
2064 (directory_file_name): Don't assume string length fits in long.
2065 (make_temp_name): Don't assume pid fits in int, or that its print
2066 length is less than 20.
2068 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2070 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2072 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2074 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2075 We prefer signed integers, even for size calculations.
2077 * emacs.c: Don't assume string length fits in 'int'.
2078 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2079 (main): Don't invoke strlen when not needed.
2081 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2082 (XD_DEBUG_MESSAGE): Don't waste a byte.
2084 * callproc.c (getenv_internal_1, getenv_internal)
2086 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2088 * lread.c (invalid_syntax): Omit length argument.
2089 All uses changed. This doesn't fix a bug, but it simplifies the
2090 code away from its former Hollerith-constant appearance, and it's
2091 one less 'int' to worry about when looking at integer-overflow issues.
2092 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2094 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2095 This didn't break anything, but it didn't help either.
2096 It's confusing to put a bogus integer in a place where the actual
2097 value does not matter.
2098 (LIST_END_P): Remove unused macro and its bogus comment.
2099 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2101 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2102 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2104 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2105 We prefer signed types, and the value cannot exceed the EMACS_INT
2106 range anyway (because otherwise the length would not be representable).
2107 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2108 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2109 This avoids a GCC warning when WIDE_EMACS_INT.
2111 * indent.c (sane_tab_width): New function.
2112 (current_column, scan_for_column, Findent_to, position_indentation)
2113 (compute_motion): Use it. This is just for clarity.
2114 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2116 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2118 * lisp.h (lint_assume): New macro.
2119 * composite.c (composition_gstring_put_cache):
2120 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2122 * editfns.c, insdel.c:
2123 Omit unnecessary forward decls, to simplify future changes.
2125 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2127 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2129 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2130 Use much-faster test for byte-length change.
2131 Don't assume string byte-length fits in 'int'.
2132 Check that character arg fits in 'int'.
2133 (mapcar1): Declare byte as byte, for clarity.
2135 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2137 * fns.c (concat): Catch string overflow earlier.
2138 Do not rely on integer wraparound.
2140 * dispextern.h (struct it.overlay_strings_charpos)
2141 (struct it.selective): Now EMACS_INT, not int.
2142 * xdisp.c (forward_to_next_line_start)
2143 (back_to_previous_visible_line_start)
2144 (reseat_at_next_visible_line_start, next_element_from_buffer):
2145 Don't arbitrarily truncate the value of 'selective' to int.
2147 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2149 * composite.c: Don't truncate sizes to 'int'.
2150 (composition_gstring_p, composition_reseat_it)
2151 (composition_adjust_point): Use EMACS_INT, not int.
2152 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2153 not EMACS_UINT, for indexes.
2155 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2157 * buffer.c: Include <verify.h>.
2158 (struct sortvec.priority, struct sortstr.priority):
2159 Now EMACS_INT, not int.
2160 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2161 (struct sortstr.size, record_overlay_string)
2162 (struct sortstrlist.size, struct sortlist.used):
2163 Don't truncate size to int.
2164 (record_overlay_string): Check for size-calculation overflow.
2165 (init_buffer_once): Check at compile-time, not run-time.
2167 2011-06-22 Jim Meyering <meyering@redhat.com>
2169 Don't leak an XBM-image-sized buffer
2170 * image.c (xbm_load): Free the image buffer after using it.
2172 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2175 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2176 that Sun C diagnosed.
2177 * fns.c (secure_hash): Fix pointer signedness issue.
2178 * intervals.c (static_offset_intervals): New function.
2179 (offset_intervals): Use it.
2181 2011-06-21 Leo Liu <sdl.web@gmail.com>
2184 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2187 * fns.c (secure_hash): Rename from crypto_hash_function and change
2188 the first arg to accept symbols.
2189 (Fsecure_hash): New primitive.
2190 (syms_of_fns): New symbols.
2192 2011-06-20 Deniz Dogan <deniz@dogan.se>
2194 * process.c (Fset_process_buffer): Clarify return value in
2197 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2199 * dispnew.c (add_window_display_history): Use BVAR.
2201 * xdisp.c (debug_method_add): Use BVAR.
2202 (check_window_end, dump_glyph_matrix, dump_glyph)
2203 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2205 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2208 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2209 check till after the cache is created in init_frame_faces.
2211 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2213 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2215 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2217 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2218 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2219 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2221 Improve buffer-overflow checking (Bug#8873).
2222 * fileio.c (Finsert_file_contents):
2223 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2224 Remove the old (too-loose) buffer overflow checks.
2225 They weren't needed, since make_gap checks for buffer overflow.
2226 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2227 The old code merely checked for Emacs fixnum overflow, and relied
2228 on undefined (wraparound) behavior. The new code avoids undefined
2229 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2231 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2232 Tune. Don't use wider integers than needed. Don't use alloca.
2233 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2235 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2237 * insdel.c, lisp.h (buffer_overflow): New function.
2238 (insert_from_buffer_1, replace_range, replace_range_2):
2239 * insdel.c (make_gap_larger):
2240 * editfns.c (Finsert_char):
2241 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2243 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2245 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2247 Integer overflow and signedness fixes (Bug#8873).
2249 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2250 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2252 * fileio.c: Don't assume EMACS_INT fits in off_t.
2253 (emacs_lseek): New static function.
2254 (Finsert_file_contents, Fwrite_region): Use it.
2255 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2257 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2259 * fns.c: Don't overflow int when computing a list length.
2260 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2261 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2262 truncation on 64-bit hosts. Check for QUIT every
2263 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2264 faster and is responsive enough.
2265 (Flength): Report an error instead of overflowing an integer.
2266 (Fsafe_length): Return a float if the value is not representable
2267 as a fixnum. This shouldn't happen except in contrived situations.
2268 (Fnthcdr, Fsort): Don't assume list length fits in int.
2269 (Fcopy_sequence): Don't assume vector length fits in int.
2271 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2272 (header_size, word_size): New constants.
2273 (allocate_vectorlike): Don't check size overflow here.
2274 (allocate_vector): Check it here instead, since this is the only
2275 caller of allocate_vectorlike that could cause overflow.
2276 Check that the new vector's length is representable as a fixnum.
2278 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2279 The previous code was bogus. For example, next_almost_prime (32)
2280 returned 39, which is undesirable as it is a multiple of 3; and
2281 next_almost_prime (24) returned 25, which is a multiple of 5 so
2282 why was the code bothering to check for multiples of 7?
2284 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2286 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2288 Variadic C functions now count arguments with ptrdiff_t.
2289 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2290 Back then I didn't know that the Emacs coding style prefers signed int.
2291 Also, in the meantime I found a few more instances where arguments
2292 were being counted with int, which may truncate counts on 64-bit
2293 machines, or EMACS_INT, which may be unnecessarily wide.
2294 * lisp.h (struct Lisp_Subr.function.aMANY)
2295 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2296 Arg counts are now ptrdiff_t, not size_t.
2297 All variadic functions and their callers changed accordingly.
2298 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2299 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2300 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2301 * callint.c (Fcall_interactively): Check arg count for overflow,
2302 to avoid potential buffer overrun. Use signed char, not 'int',
2303 for 'varies' array, so that we needn't bother to check its size
2304 calculation for overflow.
2305 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2306 * eval.c (apply_lambda):
2307 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2308 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2309 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2311 * callint.c (Fcall_interactively): Don't use index var as event count.
2313 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2314 * mem-limits.h (SIZE): Remove; no longer used.
2316 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2318 Remove unnecessary casts.
2319 * xterm.c (x_term_init):
2320 * xfns.c (x_set_border_pixel):
2321 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2322 These aren't needed now that we assume ANSI C.
2324 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2325 It's more likely to cause problems (due to unsigned overflow)
2328 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2330 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2332 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2334 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2336 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2338 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2340 GLYPH_CODE_FACE returns EMACS_INT, not int.
2341 * dispextern.h (merge_faces):
2342 * xfaces.c (merge_faces):
2343 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2344 Don't assume EMACS_INT fits in int.
2346 * character.h (CHAR_VALID_P): Remove unused parameter.
2347 * fontset.c, lisp.h, xdisp.c: All uses changed.
2349 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2351 * fns.c (concat): Minor tuning based on overflow analysis.
2352 This doesn't fix any bugs. Use int to hold character, instead
2353 of constantly refetching from Emacs object. Use XFASTINT, not
2354 XINT, for value known to be a character. Don't bother comparing
2355 a single byte to 0400, as it's always less.
2357 * floatfns.c (Fexpt):
2358 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2360 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2363 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2365 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2366 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2367 incorrectly succeed when S was a string, because 4294967386 was
2368 truncated before it was used.
2370 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2371 Otherwise, an out-of-range integer could cause undefined behavior
2374 * composite.c: Use int, not EMACS_INT, for characters.
2375 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2376 EMACS_INT, for values that are known to be in character range.
2377 This doesn't fix any bugs but is the usual style inside Emacs and
2378 may generate better code on 32-bit machines.
2380 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2381 This is for reasons similar to the recent CHAR_STRING fix.
2382 * charset.c (Fencode_char): Check that character arg is actually
2383 a character. Pass an int to ENCODE_CHAR.
2384 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2385 wider than 'int', as a compile-time check to prevent future regressions
2388 * character.c (char_string): Remove unnecessary casts.
2390 Make sure a 64-bit char is never passed to CHAR_STRING.
2391 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2392 by silently ignoring the top 32 bits, allowing some values
2393 that were far too large to be valid characters.
2394 * character.h: Include <verify.h>.
2395 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2396 arguments are no wider than unsigned, as a compile-time check
2397 to prevent future regressions in this area.
2399 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2400 (Fsubst_char_in_region):
2402 * xdisp.c (decode_mode_spec_coding):
2403 Adjust to CHAR_STRING's new requirement.
2404 * editfns.c (Finsert_char, Fsubst_char_in_region):
2405 * fns.c (concat): Check that character args are actually
2406 characters. Without this test, these functions did the wrong
2407 thing with wildly out-of-range values on 64-bit hosts.
2409 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2410 These casts should not be needed on 32-bit hosts, either.
2411 * keyboard.c (read_char):
2412 * lread.c (Fload): Remove casts to unsigned.
2414 * lisp.h (UNSIGNED_CMP): New macro.
2415 This fixes comparison bugs on 64-bit hosts.
2416 (ASCII_CHAR_P): Use it.
2417 * casefiddle.c (casify_object):
2418 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2419 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2420 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2421 * dispextern.h (FACE_FROM_ID):
2422 * keyboard.c (read_char): Use UNSIGNED_CMP.
2424 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2425 not to EMACS_INT, to avoid GCC warning.
2427 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2429 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2430 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2431 isn't needed on 32-bit machines.
2433 * buffer.c (Fgenerate_new_buffer_name):
2434 Use EMACS_INT for count, not int.
2435 (advance_to_char_boundary): Return EMACS_INT, not int.
2437 * data.c (Qcompiled_function): Now static.
2439 * window.c (window_body_lines): Now static.
2441 * image.c (gif_load): Rename local to avoid shadowing.
2443 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2444 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2445 * alloc.c (make_save_value): Integer argument is now of type
2447 (mark_object): Use ptrdiff_t, not int.
2448 * lisp.h (pD): New macro.
2449 * print.c (print_object): Use it.
2451 * alloc.c: Use EMACS_INT, not int, to count objects.
2452 (total_conses, total_markers, total_symbols, total_vector_size)
2453 (total_free_conses, total_free_markers, total_free_symbols)
2454 (total_free_floats, total_floats, total_free_intervals)
2455 (total_intervals, total_strings, total_free_strings):
2456 Now EMACS_INT, not int. All uses changed.
2457 (Fgarbage_collect): Compute overall total using a double, so that
2458 integer overflow is less likely to be a problem. Check for overflow
2459 when converting back to an integer.
2460 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2461 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2462 These were 'int' variables that could overflow on 64-bit hosts;
2463 they were never used, so remove them instead of repairing them.
2464 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2465 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2466 Previously, this ceilinged at INT_MAX, but that doesn't work on
2468 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2470 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2471 (allocate_vectorlike): Check for ptrdiff_t overflow.
2472 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2473 when a (possibly-narrower) signed value would do just as well.
2474 We prefer using signed arithmetic, to avoid comparison confusion.
2476 * alloc.c: Catch some string size overflows that we were missing.
2477 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2478 for convenience in STRING_BYTES_MAX.
2479 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2480 The definition here is exact; the one in lisp.h was approximate.
2481 (allocate_string_data): Check for string overflow. This catches
2482 some instances we weren't catching before. Also, it catches
2483 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2484 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2485 and ptrdiff_t and EMACS_INT are both 64 bits.
2487 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2488 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2489 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2491 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2493 * alloc.c (Fmake_string): Check for out-of-range init.
2495 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2497 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2499 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2501 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2502 xg_get_default_scrollbar_width.
2504 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2505 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2506 (style_changed_cb): Call update_theme_scrollbar_width and call
2507 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2508 all frames (Bug#8505).
2509 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2510 Call gtk_window_set_resizable if HAVE_GTK3.
2511 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2512 and height if HAVE_GTK3 (Bug#8505).
2513 (scroll_bar_width_for_theme): New variable.
2514 (update_theme_scrollbar_width): New function.
2515 (xg_get_default_scrollbar_width): Move code to
2516 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2517 (xg_initialize): Call update_theme_scrollbar_width.
2519 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2521 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2523 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2525 * frame.c (make_frame): Call other_buffer_safely instead of
2528 * window.c (temp_output_buffer_show): Call display_buffer with
2529 second argument Vtemp_buffer_show_specifiers and reset latter
2530 immediately after the call.
2531 (Vtemp_buffer_show_specifiers): New variable.
2532 (auto_window_vscroll_p, next_screen_context_lines)
2533 (Vscroll_preserve_screen_position): Remove leading asterisks from
2536 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2538 Fix minor problems found by GCC 4.6.0 static checking.
2539 * buffer.c (Qclone_number): Remove for now, as it's unused.
2540 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2541 (record_buffer): Remove unused local.
2542 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2543 (set_frame_buffer_list): Remove; unused.
2544 * frame.h (other_visible_frames): Remove decl.
2545 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2546 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2547 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2549 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2550 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2551 Define only if HAVE_GPM.
2552 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2553 (update_hints_inhibit): Remove; never set. All uses removed.
2554 * widgetprv.h (emacsFrameClassRec): Remove decl.
2555 * window.c (delete_deletable_window): Now returns void, since it
2556 wasn't returning anything.
2557 (compare_window_configurations): Remove unused locals.
2558 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2559 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2560 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2561 the same widths as pointers. This follows up on the 2011-05-06 patch.
2562 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2563 * xterm.h: Likewise.
2564 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2566 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2568 * makefile.w32-in: Update dependencies.
2569 (LISP_H): Add lib/intprops.h.
2571 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2573 * image.c (gif_load): Add animation frame delay to the metadata.
2574 (syms_of_image): Use DEFSYM. New symbol `delay'.
2576 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2578 * window.c (delete_deletable_window): Re-add.
2579 (Fset_window_configuration): Rewrite to handle dead buffers and
2580 consequently deletable windows.
2581 (window_tree, Fwindow_tree): Remove. Supply functionality in
2583 (compare_window_configurations): Simplify code.
2585 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2587 * image.c (imagemagick_load_image): Fix type mismatch.
2588 (Fimagemagick_types): Likewise.
2590 * window.h (replace_buffer_in_windows): Declare.
2592 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2594 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2595 Qclone_number. Remove external declaration of Qdelete_window.
2596 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2598 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2599 Run Qbuffer_list_update_hook if allowed.
2600 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2601 buffer list implementation.
2602 (other_buffer_safely): New function.
2603 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2604 calls to replace_buffer_in_windows and
2605 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2607 (record_buffer): Inhibit quitting and rewrite using quittable
2608 functions. Run Qbuffer_list_update_hook if allowed.
2609 (Frecord_buffer, Funrecord_buffer): New functions.
2610 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2611 Move switch-to-buffer to window.el.
2612 (bury-buffer): Move to window.el.
2613 (Vbuffer_list_update_hook): New variable.
2615 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2618 * window.h (resize_frame_windows): Move up in code.
2619 (Fwindow_frame): Remove EXFUN.
2620 (replace_buffer_in_all_windows): Remove prototype.
2621 (replace_buffer_in_windows_safely): Add prototype.
2623 * window.c: Declare Qdelete_window static again. Move down
2624 declaration of select_count.
2625 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2626 (Fother_window): Move to window.el.
2627 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2628 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2629 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2631 (replace_buffer_in_windows): Implement by calling
2632 Qreplace_buffer_in_windows.
2633 (replace_buffer_in_all_windows): Remove with some functionality
2634 moved into replace_buffer_in_windows_safely.
2635 (replace_buffer_in_windows_safely): New function.
2636 (select_window_norecord, select_frame_norecord): Move in front
2637 of run_window_configuration_change_hook. Remove now obsolete
2639 (Fset_window_buffer): Rewrite doc-string.
2640 Call Qrecord_window_buffer.
2641 (keys_of_window): Move binding for other-window to window.el.
2643 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2645 * dispextern.h (struct image): Replace data member, whose int_val
2646 and ptr_val fields were not used by anything, with a single
2649 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2650 (gif_clear_image, gif_load, imagemagick_load_image)
2651 (gs_clear_image, gs_load): Callers changed.
2653 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2655 * buffer.h: Include <time.h>, for time_t.
2656 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2658 Fix minor problems found by static checking.
2660 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2662 Make identifiers static if they are not used in other modules.
2663 * data.c (Qcompiled_function, Qframe, Qvector):
2664 * image.c (QimageMagick, Qsvg):
2665 * minibuf.c (Qmetadata):
2666 * window.c (resize_window_check, resize_root_window): Now static.
2667 * window.h (resize_window_check, resize_root_window): Remove decls.
2669 * window.c (window_deletion_count, delete_deletable_window):
2671 (window_body_lines): Now static.
2672 (Fdelete_other_windows_internal): Mark vars as initialized.
2673 Make sure 'resize_failed' is initialized.
2674 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2675 (resize_window_apply): Remove unused local.
2676 * window.h (delete_deletable_window): Remove decl.
2678 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2679 (imagemagick_load_image): Fix pointer signedness problem by changing
2680 last arg from unsigned char * to char *. All uses changed.
2681 Also, fix a local for similar reasons.
2682 Remove unused locals. Remove locals to avoid shadowing.
2683 (fn_rsvg_handle_free): Remove; unused.
2684 (svg_load, svg_load_image): Fix pointer signedness problem.
2685 (imagemagick_load_image): Don't use garbage pointer image_wand.
2687 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2689 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2691 * image.c (gif_load): Fix omitted cast error introduced by
2694 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2696 * window.h (resize_proportionally, orig_total_lines)
2697 (orig_top_line): Remove from window structure.
2698 (set_window_height, set_window_width, change_window_heights)
2699 (Fdelete_window): Remove prototypes.
2700 (resize_frame_windows): Remove duplicate declaration.
2702 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2704 * window.h (resize_frame_windows, resize_window_check)
2705 (delete_deletable_window, resize_root_window)
2706 (resize_frame_windows): Declare prototypes.
2708 * window.c (resize_window_apply): Make definition be "static" to
2709 match the prototype.
2711 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2713 * window.c: Remove declarations of Qwindow_size_fixed,
2714 window_min_size_1, window_min_size_2, window_min_size,
2715 size_window, window_fixed_size_p, enlarge_window, delete_window.
2716 Remove static from declaration of Qdelete_window, it's
2717 temporarily needed by Fbury_buffer.
2718 (replace_window): Don't assign orig_top_line and
2720 (Fdelete_window, delete_window): Remove. Window deletion is
2721 handled by window.el.
2722 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2723 Replace Fdelete_window calls with calls to Qdelete_window.
2724 (Fdelete_other_windows): Remove. Deleting other windows is
2725 handled by window.el.
2726 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2727 handled in window.el.
2728 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2729 Window minimum sizes are handled in window.el.
2730 (shrink_windows, size_window, set_window_height)
2731 (set_window_width, change_window_heights, window_height)
2732 (window_width, CURBEG, CURSIZE, enlarge_window)
2733 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2734 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2735 handled in window.el.
2736 (make_dummy_parent): Rename to make_parent_window and give it a
2737 second argument horflag.
2738 (make_window): Don't set resize_proportionally any more.
2739 (Fsplit_window): Remove. Windows are split in window.el.
2740 (save_restore_action, save_restore_orig_size)
2741 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2742 Resize mini windows in window.el.
2743 (grow_mini_window, shrink_mini_window): Implement by calling
2744 Qresize_root_window_vertically, resize_window_check and
2745 resize_window_apply.
2746 (saved_window, Fset_window_configuration, save_window_save):
2747 Do not handle orig_top_line, orig_total_lines, and
2748 resize_proportionally.
2749 (window_min_height, window_min_width): Move to window.el.
2750 (keys_of_window): Move bindings for delete-other-windows,
2751 split-window, delete-window and enlarge-window to window.el.
2753 * buffer.c: Temporarily extern Qdelete_window.
2754 (Fbury_buffer): Temporarily call Qdelete_window instead of
2755 Fdelete_window (Fbury_buffer will move to window.el soon).
2757 * frame.c (set_menu_bar_lines_1): Remove code handling
2758 orig_top_line and orig_total_lines.
2760 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2761 set_window_height but set heights directly.
2762 (change_frame_size_1): Use resize_frame_windows.
2764 * xdisp.c (init_xdisp): Don't use set_window_height but set
2767 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2768 Use resize_frame_windows instead of change_window_heights and run
2769 run_window_configuration_change_hook.
2771 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2772 instead of change_window_heights and run
2773 run_window_configuration_change_hook.
2775 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2777 * window.c (replace_window): Rename second argument REPLACEMENT to
2778 NEW. New third argument SETFLAG. Rewrite.
2779 (delete_window, make_dummy_parent): Call replace_window with
2781 (window_list_1): Move down in code.
2782 (run_window_configuration_change_hook): Move set_buffer part
2783 before select_frame_norecord part in order to unwind correctly.
2784 Rename count1 to count.
2785 (recombine_windows, delete_deletable_window, resize_root_window)
2786 (Fdelete_other_windows_internal)
2787 (Frun_window_configuration_change_hook, make_parent_window)
2788 (resize_window_check, resize_window_apply, Fresize_window_apply)
2789 (resize_frame_windows, Fsplit_window_internal)
2790 (Fdelete_window_internal, Fresize_mini_window_internal):
2792 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2794 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2796 * window.h (window): Add some new members to window structure -
2797 normal_lines, normal_cols, new_total, new_normal, clone_number,
2798 splits, nest, prev_buffers, next_buffers.
2799 (WINDOW_TOTAL_SIZE): Move here from window.c.
2800 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2802 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2804 (make_dummy_parent): Set new members of windows structure.
2805 (make_window): Move down in code. Handle new members of window
2807 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2808 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2809 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2810 (Fset_window_prev_buffers, Fwindow_next_buffers)
2811 (Fset_window_next_buffers, Fset_window_clone_number):
2813 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2814 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2816 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2817 Argument WINDOW can be now internal window too.
2818 (Fwindow_use_time): Move up in code.
2819 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2821 (Fset_window_configuration, saved_window)
2822 (Fcurrent_window_configuration, save_window_save): Handle new
2823 members of window structure.
2824 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2825 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2826 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2827 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2828 Qget_mru_window, Qresize_root_window,
2829 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2830 Qauto_buffer_name; staticpro them.
2832 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2834 * window.c (Fwindow_total_size, Fwindow_left_column)
2835 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2836 (Fwindow_list_1): New functions.
2837 (window_box_text_cols): Replace with window_body_cols.
2838 (Fwindow_width, Fscroll_left, Fscroll_right):
2839 Use window_body_cols instead of window_box_text_cols.
2840 (delete_window, Fset_window_configuration):
2841 Call delete_all_subwindows with window as argument.
2842 (delete_all_subwindows): Take a window as argument and not a
2844 (window_loop): Remove handling of GET_LRU_WINDOW and
2846 (Fget_lru_window, Fget_largest_window): Move to window.el.
2848 * window.h: Extern window_body_cols instead of
2849 window_box_text_cols. delete_all_subwindows now takes a
2850 Lisp_Object as argument.
2852 * indent.c (compute_motion, Fcompute_motion):
2853 Use window_body_cols instead of window_box_text_cols.
2855 * frame.c (delete_frame): Call delete_all_subwindows with root
2858 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2860 * fns.c (Fputhash): Document return value.
2862 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2864 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2866 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2868 Cons<->int and similar integer overflow fixes (Bug#8794).
2870 Check for overflow when converting integer to cons and back.
2871 * charset.c (Fdefine_charset_internal, Fdecode_char):
2872 Use cons_to_unsigned to catch overflow.
2873 (Fencode_char): Use INTEGER_TO_CONS.
2874 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2875 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2876 * data.c (long_to_cons, cons_to_long): Remove.
2877 (cons_to_unsigned, cons_to_signed): New functions.
2878 These signal an error for invalid or out-of-range values.
2879 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2880 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2881 * font.c (Ffont_variation_glyphs):
2882 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2883 * lisp.h: Include <intprops.h>.
2884 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2885 (cons_to_signed, cons_to_unsigned): New decls.
2886 (long_to_cons, cons_to_long): Remove decls.
2887 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2888 (Fprimitive_undo): Use CONS_TO_INTEGER.
2889 * xfns.c (Fx_window_property): Likewise.
2890 * xselect.c: Include <limits.h>.
2891 (x_own_selection, selection_data_to_lisp_data):
2892 Use INTEGER_TO_CONS.
2893 (x_handle_selection_request, x_handle_selection_clear)
2894 (x_get_foreign_selection, Fx_disown_selection_internal)
2895 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2896 (lisp_data_to_selection_data): Use cons_to_unsigned.
2897 (x_fill_property_data): Use cons_to_signed.
2898 Report values out of range.
2900 Check for buffer and string overflow more precisely.
2901 * buffer.h (BUF_BYTES_MAX): New macro.
2902 * lisp.h (STRING_BYTES_MAX): New macro.
2903 * alloc.c (Fmake_string):
2904 * character.c (string_escape_byte8):
2905 * coding.c (coding_alloc_by_realloc):
2906 * doprnt.c (doprnt):
2907 * editfns.c (Fformat):
2909 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2910 since they may not be the same number.
2911 * editfns.c (Finsert_char):
2912 * fileio.c (Finsert_file_contents):
2913 Likewise for BUF_BYTES_MAX.
2915 * image.c: Use ptrdiff_t, not int, for sizes.
2916 (slurp_file): Switch from int to ptrdiff_t.
2918 (slurp_file): Check that file size fits in both size_t (for
2919 malloc) and ptrdiff_t (for sanity and safety).
2921 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2922 if b->modtime has its maximal value.
2924 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2926 Don't assume time_t can fit into int.
2927 * buffer.h (struct buffer.modtime): Now time_t, not int.
2928 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2929 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2931 Minor fixes for signed vs unsigned integers.
2932 * character.h (MAYBE_UNIFY_CHAR):
2933 * charset.c (maybe_unify_char):
2934 * keyboard.c (read_char, reorder_modifiers):
2935 XINT -> XFASTINT, since the integer must be nonnegative.
2936 * ftfont.c (ftfont_spec_pattern):
2937 * keymap.c (access_keymap, silly_event_symbol_error):
2938 XUINT -> XFASTINT, since the integer must be nonnegative.
2939 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2940 since it makes no difference and we prefer signed.
2941 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2942 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2945 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2947 * window.h (Fwindow_frame): Declare.
2949 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2951 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2952 (SPARE_MEMORY): Always define.
2953 (LARGE_REQUEST): Remove.
2954 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2956 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2958 * lisp.h: Move EXFUNS for Fframe_root_window,
2959 Fframe_first_window and Fset_frame_selected_window to window.h.
2961 * window.h: Move EXFUNS for Fframe_root_window,
2962 Fframe_first_window and Fset_frame_selected_window here from
2965 * frame.c (Fwindow_frame, Fframe_first_window)
2966 (Fframe_root_window, Fframe_selected_window)
2967 (Fset_frame_selected_window): Move to window.c.
2968 (Factive_minibuffer_window): Move to minibuf.c.
2969 (Fother_visible_frames_p): New function.
2971 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2973 * window.c (decode_window, decode_any_window): Move up in code.
2974 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2975 (inhibit_frame_unsplittable): Remove unused variable.
2976 (Fwindow_buffer): Move up and rewrite doc-string.
2977 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2978 (Fwindow_prev): New functions.
2979 (Fwindow_frame): Move here from frame.c. Accept any window as
2981 (Fframe_root_window, Fframe_first_window)
2982 (Fframe_selected_window): Move here from frame.c. Accept frame
2983 or arbitrary window as argument. Update doc-strings.
2984 (Fminibuffer_window): Move up in code.
2985 (Fwindow_minibuffer_p): Move up in code and simplify.
2986 (Fset_frame_selected_window): Move here from frame.c.
2988 (Fselected_window, select_window, Fselect_window): Move up in
2989 code. Minor doc-string fixes.
2991 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2993 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2994 Do not assume that spare memory exists; that assumption is valid
2995 only if SYSTEM_MALLOC.
2996 (LARGE_REQUEST): New macro, so that the issue of large requests
2997 is separated from the issue of spare memory.
2999 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3001 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3004 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3006 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3009 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3011 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3013 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3015 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3016 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3018 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3020 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3022 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3024 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3025 (x_clipboard_manager_save): Add return value.
3026 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3028 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3029 Obey Vx_select_enable_clipboard_manager. Catch errors in
3030 x_clipboard_manager_save (Bug#8779).
3031 (Vx_select_enable_clipboard_manager): New variable.
3032 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3034 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3036 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3038 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3040 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3041 in the current matrix if keep_current_p is non-zero.
3043 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3045 * bidi.c (bidi_level_of_next_char): Fix last change.
3047 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3049 Support bidi reordering of text covered by display properties.
3051 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3052 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3053 (bidi_cache_search, bidi_cache_iterator_state)
3054 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3055 (bidi_level_of_next_char, bidi_move_to_visually_next):
3056 Support character positions inside a run of characters covered by a
3058 (bidi_paragraph_init, bidi_resolve_explicit_1)
3059 (bidi_level_of_next_char): Call bidi_fetch_char and
3060 bidi_fetch_char_advance instead of FETCH_CHAR and
3062 (bidi_init_it): Initialize new members.
3063 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3065 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3066 instead of using explicit *_CHAR codes.
3067 (bidi_resolve_explicit, bidi_resolve_weak):
3068 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3069 bidirectional text is supported only in multibyte buffers.
3070 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3071 it to initialize the frame_window_p member of struct bidi_it.
3072 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3073 (bidi_resolve_explicit, bidi_resolve_weak)
3074 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3075 bidi_it->nchars is non-positive.
3076 (bidi_level_of_next_char): Don't try to lookup the cache for the
3077 next/previous character if nothing is cached there yet, or if we
3078 were just reseat()'ed to a new position.
3080 * xdisp.c (set_cursor_from_row): Set start and stop points
3081 according to the row's direction when priming the loop that looks
3082 for the glyph on which to display cursor.
3083 (single_display_spec_intangible_p): Function deleted.
3084 (display_prop_intangible_p): Reimplement to call
3085 handle_display_spec instead of single_display_spec_intangible_p.
3086 Accept 3 additional arguments needed by handle_display_spec.
3087 This fixes incorrect cursor motion across display property with complex
3088 values: lists, `(when COND...)' forms, etc.
3089 (single_display_spec_string_p): Support property values that are
3090 lists with the argument STRING its top-level element.
3091 (display_prop_string_p): Fix the condition for processing a
3092 property that is a list to be consistent with handle_display_spec.
3093 (handle_display_spec): New function, refactored from the
3094 last portion of handle_display_prop.
3095 (compute_display_string_pos): Accept additional argument
3096 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3097 value of a `display' property is a "replacing spec".
3098 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3099 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3100 the display property, but just return a value indicating whether
3101 the display property will replace the characters it covers.
3102 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3103 frame_window_p members of struct bidi_it.
3104 (compute_display_string_pos, compute_display_string_end):
3106 (push_it): Accept second argument POSITION, where pop_it should
3107 jump to continue iteration.
3108 (reseat_1): Initialize bidi_it.disp_pos.
3110 * keyboard.c (adjust_point_for_property): Adjust the call to
3111 display_prop_intangible_p to its new signature.
3113 * dispextern.h (struct bidi_it): New member frame_window_p.
3114 (bidi_init_it): Update prototypes.
3115 (display_prop_intangible_p): Update prototype.
3116 (compute_display_string_pos, compute_display_string_end):
3118 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3121 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3123 Malloc failure behavior now depends on size of allocation.
3124 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3125 * lisp.h: Change signatures accordingly.
3126 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3127 All callers changed. (Bug#8762)
3129 * gnutls.c: Use Emacs's memory allocators.
3130 Without this change, the gnutls library would invoke malloc etc.
3131 directly, which causes problems on non-SYNC_INPUT hosts, and which
3132 runs afoul of improving memory_full behavior. (Bug#8761)
3133 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3134 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3135 xfree instead of the default malloc, realloc, free.
3136 (Fgnutls_boot): No need to check for memory allocation failure,
3137 since xmalloc does that for us.
3139 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3140 * category.c (hash_get_category_set):
3141 * ccl.c (ccl_driver):
3142 * charset.c (Fdefine_charset_internal):
3143 * charset.h (struct charset.hash_index):
3144 * composite.c (get_composition_id, gstring_lookup_cache)
3145 (composition_gstring_put_cache):
3146 * composite.h (struct composition.hash_index):
3147 * dispextern.h (struct image.hash):
3148 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3149 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3150 (hashfn_equal, hashfn_user_defined, make_hash_table)
3151 (maybe_resize_hash_table, hash_lookup, hash_put)
3152 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3153 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3154 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3155 * image.c (make_image, search_image_cache, lookup_image)
3156 (xpm_put_color_table_h):
3157 * lisp.h (struct Lisp_Hash_Table):
3158 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3159 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3160 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3161 * alloc.c (allocate_vectorlike):
3162 Check for overflow in vector size calculations.
3163 * ccl.c (ccl_driver):
3164 Check for overflow when converting EMACS_INT to int.
3165 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3166 need to be updated by these changes.
3167 * fns.c (make_hash_table, maybe_resize_hash_table):
3168 Check for integer overflow with large hash tables.
3169 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3170 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3171 (SXHASH_REDUCE): New macro.
3172 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3173 Use it instead of discarding useful hash info with large hash values.
3174 (sxhash_float): New function.
3175 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3176 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3177 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3178 Rewrite to use FIXNUM_BITS, as this simplifies things.
3179 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3180 Adjust signatures to match updated version of code.
3181 (consing_since_gc): Now EMACS_INT, since a single hash table can
3182 use more than INT_MAX bytes.
3184 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3186 Make it possible to build with GCC-4.6+ -O2 -flto.
3188 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3190 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3192 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3193 Call minibuffer-inactive-mode.
3195 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3197 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3198 Update dependencies.
3200 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3202 * data.c (init_data): Remove code for UTS, this system is not
3205 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3207 Don't force ./temacs to start in terminal mode.
3209 * frame.c (make_initial_frame): Initialize faces in all cases, not
3210 only when CANNOT_DUMP is defined.
3211 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3213 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3215 * dispnew.c (add_window_display_history): Use const for the string
3216 pointer. Remove declaration, not needed.
3218 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3220 Use 'inline', not 'INLINE'.
3221 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3222 * alloc.c, fontset.c (INLINE): Remove.
3223 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3224 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3225 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3226 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3227 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3229 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3231 Make it possible to run ./temacs.
3233 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3234 syms_of_callproc does the same thing. Remove test for
3235 "initialized", do it in the caller.
3236 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3238 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3240 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3241 (read_minibuf): Use get_minibuffer.
3242 (syms_of_minibuf): Use DEFSYM.
3243 (Qmetadata): New var.
3244 * data.c (Qbuffer): Don't make it static.
3245 (syms_of_data): Use DEFSYM.
3247 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3249 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3250 (CCL_CODE_MIN): New macro.
3252 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3254 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3256 * eval.c (Qdebug): Now static.
3257 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3258 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3259 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3261 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3263 * image.c: Various fixes to ImageMagick code comments.
3264 (Fimagemagick_types): Doc fix.
3266 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3268 Minor fixes prompted by GCC 4.6.0 warnings.
3270 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3272 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3273 (x_clipboard_manager_save_all): Move extern decl to ...
3274 * xterm.h: ... here, so that it can be checked for consistency.
3276 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3278 * xselect.c (x_clipboard_manager_save_frame)
3279 (x_clipboard_manager_save_all): New functions.
3280 (Fx_clipboard_manager_save): Lisp function deleted.
3282 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3283 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3285 * xterm.h: Update prototype.
3287 2011-05-28 William Xu <william.xwl@gmail.com>
3289 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3292 2011-05-28 Jim Meyering <meyering@redhat.com>
3294 Avoid a sign-extension bug in crypto_hash_function.
3295 * fns.c (to_uchar): Define.
3296 (crypto_hash_function): Use it to convert some newly-signed
3297 variables to unsigned, to avoid sign-extension bugs. For example,
3298 without this change, (md5 "truc") would evaluate to
3299 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3300 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3301 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3303 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3305 Integer overflow fixes.
3307 * dbusbind.c: Serial number integer overflow fixes.
3308 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3309 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3310 to hold a serial number that is too large for a fixnum.
3311 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3312 Check for serial numbers out of range. Decode any serial number
3313 that was so large that it became a float. (Bug#8722)
3315 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3316 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3317 Use XFASTINT rather than XUINT when numbers are nonnegative.
3318 (xd_append_arg, Fdbus_method_return_internal):
3319 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3320 arguments, check that Lisp number is nonnegative, rather than
3321 silently wrapping negative numbers around. (Bug#8722)
3322 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3325 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3327 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3329 ccl: add integer overflow checks
3330 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3331 (IN_INT_RANGE): New macros.
3332 (ccl_driver): Use them to check for integer overflow when
3333 decoding a CCL program. Many of the new checks are whether XINT (x)
3334 fits in int; it doesn't always, on 64-bit hosts. The new version
3335 doesn't catch all possible integer overflows, but it's an
3336 improvement. (Bug#8719)
3338 * alloc.c (make_event_array): Use XINT, not XUINT.
3339 There's no need for unsigned here.
3341 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3342 This follows up to the 2011-05-06 change that substituted uintptr_t
3343 for EMACS_INT. This case wasn't caught back then.
3345 Rework Fformat to avoid integer overflow issues.
3346 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3347 now (part of C89). Include <verify.h>.
3348 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3349 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3350 (Fformat): Avoid the prepass trying to compute sizes; it was only
3351 approximate and thus did not catch overflow reliably. Instead, walk
3352 through the format just once, formatting and computing sizes as we go,
3353 checking for integer overflow at every step, and allocating a larger
3354 buffer as needed. Keep track separately whether the format is
3355 multibyte. Keep only the most-recently calculated precision, rather
3356 than them all. Record whether each argument has been converted to
3357 string. Use EMACS_INT, not int, for byte and char and arg counts.
3358 Support field widths and precisions larger than INT_MAX. Avoid
3359 sprintf's undefined behavior with conversion specifications such as %#d
3360 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3361 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3362 formatting out-of-range floating point numbers with int
3365 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3367 * data.c: Avoid integer truncation in expressions involving floats.
3368 * data.c: Include <intprops.h>.
3369 (arith_driver): When there's an integer overflow in an expression
3370 involving floating point, convert the integers to floating point
3371 so that the resulting value does not suffer from catastrophic
3372 integer truncation. For example, on a 64-bit host (* 4
3373 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3374 Do not rely on undefined behavior after integer overflow.
3376 merge count_size_as_multibyte, parse_str_to_multibyte
3377 * character.c, character.h (count_size_as_multibyte):
3378 Rename from parse_str_to_multibyte; all uses changed.
3379 Check for integer overflow.
3380 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3381 since it's now a duplicate of the other. This is more of
3382 a character than a buffer op, so better that it's in character.c.
3383 * fns.c, print.c: Adjust to above changes.
3385 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3387 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3389 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3391 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3392 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3393 (x_clipboard_manager_save): Now static.
3394 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3396 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3397 (crypto_hash_function): Now static.
3398 Fix pointer signedness problems. Avoid unnecessary initializations.
3400 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3402 * termhooks.h (Vselection_alist): Make it terminal-local.
3404 * terminal.c (create_terminal): Initialize it.
3406 * xselect.c: Support for clipboard managers.
3407 (Vselection_alist): Move to termhooks.h as terminal-local var.
3408 (LOCAL_SELECTION): New macro.
3409 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3410 (symbol_to_x_atom): Remove gratuitous arg.
3411 (x_handle_selection_request, lisp_data_to_selection_data)
3412 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3413 (x_own_selection, x_get_local_selection, x_convert_selection):
3414 New arg, specifying work frame. Use terminal-local Vselection_alist.
3415 (some_frame_on_display): Delete unused function.
3416 (Fx_own_selection_internal, Fx_get_selection_internal)
3417 (Fx_disown_selection_internal, Fx_selection_owner_p)
3418 (Fx_selection_exists_p): New optional frame arg.
3419 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3420 (x_handle_selection_clear): Don't treat other terminals with the
3421 same keyboard specially. Use the terminal-local Vselection_alist.
3422 (x_clear_frame_selections): Use Frun_hook_with_args.
3424 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3426 * xterm.h: Add support for those atoms.
3428 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3430 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3431 (converted_selections, conversion_fail_tag): New global variables.
3432 (x_selection_request_lisp_error): Free the above.
3433 (x_get_local_selection): Remove unnecessary code.
3434 (x_reply_selection_request): Args changed; handle arbitrary array
3435 of converted selections stored in converted_selections.
3436 Separate the XChangeProperty and SelectionNotify steps.
3437 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3438 (x_convert_selection): New function.
3439 (x_handle_selection_event): Simplify.
3440 (x_get_foreign_selection): Don't ignore incoming requests while
3441 waiting for an answer; this will fail when we implement
3442 SAVE_TARGETS, and seems unnecessary anyway.
3443 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3444 (Vx_sent_selection_functions): Doc fix.
3446 2011-05-26 Leo Liu <sdl.web@gmail.com>
3448 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3450 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3452 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3454 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3455 for fringe update if it has periodic bitmap.
3456 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3457 and fringe_bitmap_periodic_p.
3459 * fringe.c (get_fringe_bitmap_data): New function.
3460 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3461 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3462 row. Mark glyph row for fringe update if periodicity changed.
3464 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3465 for fringe update unless it has periodic bitmap.
3467 2011-05-25 Kenichi Handa <handa@m17n.org>
3469 * xdisp.c (get_next_display_element): Set correct it->face_id for
3470 a static composition.
3472 2011-05-24 Leo Liu <sdl.web@gmail.com>
3475 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3477 * fns.c (crypto_hash_function, Fsha1): New function.
3478 (Fmd5): Use crypto_hash_function.
3479 (syms_of_fns): Add Ssha1.
3481 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3483 * gnutls.c: Remove unused macros.
3484 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3485 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3486 Remove macros that are defined and never used.
3487 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3489 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3491 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3492 (Fx_get_selection_internal): Minor cleanup.
3493 (Fx_own_selection_internal): Rename arguments for consistency with
3496 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3498 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3500 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3502 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3504 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3506 * dispnew.c (scrolling_window): Don't exclude the case that the
3507 last enabled row in the desired matrix touches the bottom boundary.
3509 2011-05-21 Glenn Morris <rgm@gnu.org>
3511 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3512 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3513 and add some more files.
3515 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3517 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3518 report_file_error introduced by the change from 2011-05-07.
3520 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3522 * systime.h (Time): Define only if emacs is defined.
3523 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3524 where the include path doesn't have X11/X.h by default. See
3525 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3527 2011-05-20 Kenichi Handa <handa@m17n.org>
3529 * composite.c (find_automatic_composition): Fix previous change.
3531 2011-05-20 Glenn Morris <rgm@gnu.org>
3533 * lisp.mk: New file, split from Makefile.in.
3534 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3535 (shortlisp): Remove.
3536 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3538 2011-05-19 Glenn Morris <rgm@gnu.org>
3540 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3541 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3542 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3543 (lisp): Set the order to that of loadup.el.
3544 (shortlisp): Make it a copy of $lisp.
3545 (SOME_MACHINE_LISP): Remove.
3546 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3547 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3549 2011-05-18 Kenichi Handa <handa@m17n.org>
3551 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3552 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3553 (find_automatic_composition): Mostly rewrite for efficiency.
3555 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3557 * makefile.w32-in: Update dependencies.
3559 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3561 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3562 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3564 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3566 Fix some integer overflow issues, such as string length overflow.
3568 * insdel.c (count_size_as_multibyte): Check for string overflow.
3570 * character.c (lisp_string_width): Check for string overflow.
3571 Use EMACS_INT, not int, for string indexes and lengths; in
3572 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3573 the resulting string length overflows an EMACS_INT; instead,
3574 report a string overflow if no precision given. When checking for
3575 precision exhaustion, use a check that cannot possibly have
3576 integer overflow. (Bug#8675)
3577 * character.h (lisp_string_width): Adjust to new signature.
3579 * alloc.c (string_overflow): New function.
3580 (Fmake_string): Use it. This doesn't change behavior, but saves
3581 a few bytes and will simplify future changes.
3582 * character.c (string_escape_byte8): Likewise.
3583 * lisp.h (string_overflow): New decl.
3585 Fixups, following up to the user-interface timestamp change.
3586 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3587 for UI timestamps, instead of unsigned long.
3588 * msdos.c (mouse_get_pos): Likewise.
3589 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3590 * w32gui.h (Time): Define by including "systime.h" rather than by
3591 declaring it ourselves. (Bug#8664)
3593 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3594 * image.c (clear_image_cache): Likewise.
3596 * term.c (term_mouse_position): Don't assume time_t wraparound.
3598 Be more systematic about user-interface timestamps.
3599 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3600 and sometimes 'EMACS_UINT', to represent these timestamps.
3601 This change causes it to use 'Time' uniformly, as that's what X uses.
3602 This makes the code easier to follow, and makes it easier to catch
3603 integer overflow bugs such as Bug#8664.
3604 * frame.c (Fmouse_position, Fmouse_pixel_position):
3605 Use Time, not unsigned long, for user-interface timestamps.
3606 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3607 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3608 * keyboard.h (last_event_timestamp): Likewise.
3609 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3610 * menu.h (xmenu_show): Likewise.
3611 * term.c (term_mouse_position): Likewise.
3612 * termhooks.h (struct input_event.timestamp): Likewise.
3613 (struct terminal.mouse_position_hook): Likewise.
3614 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3615 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3616 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3617 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3619 * menu.h, termhooks.h: Include "systime.h", for Time.
3621 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3622 Don't assume that the difference between two unsigned long values
3623 can fit into an integer. At this point, we know button_down_time
3624 <= event->timestamp, so the difference must be nonnegative, so
3625 there's no need to cast the result if double-click-time is
3626 nonnegative, as it should be; check that it's nonnegative, just in
3627 case. This bug is triggered when events are more than 2**31 ms
3628 apart (about 25 days). (Bug#8664)
3630 * xselect.c (last_event_timestamp): Remove duplicate decl.
3631 (x_own_selection): Remove needless cast to unsigned long.
3633 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3634 that always fit in int. Use a sentinel instead of a counter, to
3635 avoid a temp and to allay GCC's concerns about possible int overflow.
3636 * frame.h (struct frame): Use int for menu_bar_items_used
3637 instead of EMACS_INT, since it always fits in int.
3639 * menu.c (grow_menu_items): Check for int overflow.
3641 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3643 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3644 Before, the code was not consistent. These values cannot exceed
3645 2**31 - 1 so there's no need to make them unsigned.
3646 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3647 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3648 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3650 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3652 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3653 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3654 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3655 presumably because the widths might not match.
3657 * window.c (size_window): Avoid needless test at loop start.
3659 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3661 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3663 2011-05-12 Drew Adams <drew.adams@oracle.com>
3665 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3667 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3669 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3670 `width' to `bar_area_x' and `bar_area_width', respectively.
3671 (x_scroll_run): Take account of fringe background extension.
3673 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3674 Rename local vars `left' and `width' to `bar_area_x' and
3675 `bar_area_width', respectively.
3676 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3677 background extension.
3679 2011-05-10 Jim Meyering <meyering@redhat.com>
3681 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3683 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3685 * image.c (Finit_image_library): Return t for built-in image types,
3686 like pbm and xbm. (Bug#8640)
3688 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3690 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3692 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3694 * w32console.c (Fset_screen_color): Doc fix.
3695 (Fget_screen_color): New function.
3696 (syms_of_ntterm): Defsubr it.
3698 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3699 unlink the temporary file if Fcall_process didn't create it in the
3701 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3702 child process will be redirected to a file specified with `:file'.
3703 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3704 cue to call_process_cleanup not to close that handle.
3706 2011-05-07 Ben Key <bkey76@gmail.com>
3708 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3709 one of two shell specific rules, either bootstrap-temacs-CMD or
3710 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3711 to the previous implementation of the bootstrap-temacs rule.
3712 The bootstrap-temacs-CMD rule is similar to the previous
3713 implementation of the bootstrap-temacs rule except that it
3714 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3717 These changes, along with some changes to nt/configure.bat,
3718 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3719 earlier fix to add support for --cflags and --ldflags options
3720 that include quotes so that it works whether make uses cmd or
3723 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3725 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3726 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3728 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3729 a string. Handle both cases.
3730 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3731 (Fdbus_register_method): Use Qinvalid_function.
3733 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3735 * makefile.w32-in: Update dependencies.
3736 (LISP_H): Add inttypes.h and stdin.h.
3737 (PROCESS_H): Add unistd.h.
3739 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3741 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3742 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3744 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3746 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3748 * term.c (vfatal): Remove stray call to va_end.
3749 It's not needed and the C Standard doesn't allow it here anyway.
3751 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3752 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3754 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3757 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3759 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3761 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3763 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3765 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3767 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3768 * charset.c (Fdefine_charset_internal): Don't initialize
3769 charset.code_space[15]. The value was garbage, on hosts with
3770 32-bit int (Bug#8600).
3772 * lread.c (read_integer): Be more consistent with string-to-number.
3773 Use string_to_number to do the actual conversion; this avoids
3774 rounding errors and fixes some other screwups. Without this fix,
3775 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3776 (digit_to_number): Move earlier, for benefit of read_integer.
3777 Return -1 if the digit is out of range for the base, -2 if it is
3778 not a digit in any supported base. (Bug#8602)
3780 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3782 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3783 to match comment at start of function. This also removes a
3784 GCC warning about overflow in a 32+64-bit port.
3786 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3788 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3789 Reported by Stefan Monnier in
3790 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3791 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3792 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3794 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3795 (EMACS_UINTPTR): Likewise, with uintptr_t.
3797 * lisp.h: Prefer 64-bit EMACS_INT if available.
3798 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3799 on 32-bit hosts that have 64-bit int, so that they can access
3801 However, temporarily disable this change unless the temporary
3802 symbol WIDE_EMACS_INT is defined.
3804 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3806 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3807 This removes an assumption that EMACS_INT and long are the same
3808 width as pointers. The assumption is true for Emacs porting targets
3809 now, but we want to make other targets possible.
3810 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3811 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3812 In the rest of the code, change types of integers that hold casted
3813 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3814 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3815 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3816 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3817 No need to cast type when ORing.
3818 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3819 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3820 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3821 assume EMACS_INT is the same width as char *.
3822 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3823 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3824 Remove no-longer-needed casts.
3825 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3826 (xg_tool_bar_help_callback, xg_make_tool_item):
3827 Use EMACS_INTPTR to hold an integer
3828 that will be cast to void *; this can avoid a GCC warning
3829 if EMACS_INT is not the same width as void *.
3830 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3831 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3832 (current_message_1, set_message_1):
3833 Use a local to convert to proper width without a cast.
3834 * xmenu.c (dialog_selection_callback): Likewise.
3836 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3837 Also, don't assume VALBITS / RAND_BITS is less than 5,
3838 and don't rely on undefined behavior when shifting a 1 left into
3840 * lisp.h (get_random): Change signature to match.
3842 * lread.c (hash_string): Use size_t, not int, for hash computation.
3843 Normally we prefer signed values; but hashing is special, because
3844 it's better to use unsigned division on hash table sizes so that
3845 the remainder is nonnegative. Also, size_t is the natural width
3846 for hashing into memory. The previous code used 'int', which doesn't
3847 retain enough info to hash well into very large tables.
3848 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3850 * dbusbind.c: Don't possibly lose pointer info when converting.
3851 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3852 Use XPNTR rather than XHASH, so that the high-order bits of
3853 the pointer aren't lost when converting through void *.
3855 * eval.c (Fautoload): Don't double-shift a pointer.
3857 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3859 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3861 * gnutls.c (DEF_GNUTLS_FN):
3862 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3864 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3866 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3869 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3871 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3872 New version that can reserve upto 2GB of heap space.
3874 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3876 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3878 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3880 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3881 `gnutls_certificate_set_x509_key_file'.
3883 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3885 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3886 Update dependencies.
3888 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3890 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3891 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3892 Remove unused parameter `fildes'.
3893 * process.c (read_process_output, send_process): Don't pass it.
3895 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3897 Fix previous change: the library cache is defined in w32.c.
3898 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3899 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3901 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3903 Implement dynamic loading of GnuTLS on Windows.
3905 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3906 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3907 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3910 * gnutls.c (Qgnutls_dll): Define.
3911 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3912 (gnutls_*): Declare function pointers.
3913 (init_gnutls_functions): New function to initialize function pointers.
3914 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3915 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3916 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3917 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3918 (emacs_gnutls_write, emacs_gnutls_read)
3919 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3920 (Fgnutls_available_p): New function.
3921 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3922 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3923 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3925 * image.c: Include w32.h.
3926 (Vimage_type_cache): Delete.
3927 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3928 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3929 (w32_delayed_load): Move to w32.c.
3931 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3933 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3934 (w32_delayed_load): Move from image.c. When loading a library, record
3935 its filename in the :loaded-from property of the library id.
3936 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3937 Initialize and staticpro them.
3938 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3940 * process.c: Include lisp.h before w32.h, not after.
3941 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3942 instead of gnutls_record_check_pending.
3944 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3946 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3948 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3949 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3952 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3954 * xterm.c (x_set_frame_alpha): Do not set property on anything
3955 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3957 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3959 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3961 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3963 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3964 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3965 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3966 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3967 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3968 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3969 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3970 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3971 (Qgnutls_bootprop_callbacks_verify): Make static.
3973 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3975 * callproc.c: Indentation fixup.
3977 * sysdep.c (wait_for_termination_1): Make static.
3978 (wait_for_termination, interruptible_wait_for_termination):
3979 Move after wait_for_termination_1.
3981 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3983 * sysdep.c (interruptible_wait_for_termination): New function
3984 which is like wait_for_termination, but allows keyboard
3987 * callproc.c (Fcall_process): Add (:file "file") as an option for
3989 (Fcall_process_region): Ditto.
3991 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3993 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3994 rather than `XVECTOR (FOO)->size'.
3996 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3997 inttypes.h, as a gnulib replacement is used if it not available in
4000 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4002 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4003 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4004 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4006 * coding.c (coding_alloc_by_realloc): Error out if destination
4007 will grow beyond MOST_POSITIVE_FIXNUM.
4008 (decode_coding_emacs_mule): Abort if there isn't enough place in
4009 charbuf for the composition carryover bytes. Reserve an extra
4010 space for up to 2 characters produced in a loop.
4011 (decode_coding_iso_2022): Abort if there isn't enough place in
4012 charbuf for the composition carryover bytes.
4014 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4016 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4017 aborting when %lld or %lll format is passed.
4018 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4019 %llo or %llx format is passed. (Bug#8545)
4021 * window.c (window_scroll_line_based): Use a marker instead of
4022 simple variables to record original value of point. (Bug#7952)
4024 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4025 produced by %s or %c overflows available buffer space. (Bug#8545)
4027 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4029 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4030 (SIZE_MAX): Move defn after all includes, as they might #define it.
4032 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4034 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4036 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4038 * keyboard.c (Qdelayed_warnings_hook): Define.
4039 (command_loop_1): Run `delayed-warnings-hook'
4040 if Vdelayed_warnings_list is non-nil.
4041 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4042 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4044 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4046 * doprnt.c (doprnt): Don't return value smaller than the buffer
4047 size if the message was truncated. (Bug#8545).
4049 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4051 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4052 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4054 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4056 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4058 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4060 * makefile.w32-in: Update dependencies.
4062 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4064 Improve `doprnt' and its usage. (Bug#8545)
4065 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4066 `format_end'. Remove support for %l as a conversion specifier.
4067 Don't use xrealloc. Improve diagnostics when the %l size modifier
4068 is used. Update the commentary.
4070 * eval.c (verror): Simplify calculation of size_t.
4072 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4075 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4077 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4080 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4082 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4083 This makes this file independent of the recent pseudovector change.
4085 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4087 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4089 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4090 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4091 Remove unused local.
4092 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4094 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4095 GCC 4.6.0 optimizes based on type-based alias analysis.
4096 For example, if b is of type struct buffer * and v of type struct
4097 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4098 != &v->size, and therefore "v->size = 1; b->size = 2; return
4099 v->size;" must therefore return 1. This assumption is incorrect
4100 for Emacs, since it type-puns struct Lisp_Vector * with many other
4101 types. To fix this problem, this patch adds a new type struct
4102 vectorlike_header that documents the constraints on layout of vectors
4103 and pseudovectors, and helps optimizing compilers not get fooled
4104 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4105 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4106 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4108 (XSETPVECTYPE): Rewrite in terms of new macro.
4109 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4110 This is a bit clearer, and further avoids the possibility of
4111 undesirable aliasing.
4112 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4113 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4114 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4115 since Lisp_Subr is a special case (no "next" field).
4116 (ASIZE): Now uses header.size rather than size.
4117 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4118 to avoid the hassle of writing XVECTOR (foo)->header.size.
4119 (struct vectorlike_header): New type.
4120 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4121 object, to help avoid aliasing.
4122 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4123 (SUBRP): Likewise, since Lisp_Subr is a special case.
4124 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4125 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4126 (struct Lisp_Hash_Table): Combine first two members into a single
4127 struct vectorlike_header member. All uses of "size" and "next" members
4128 changed to be "header.size" and "header.next".
4129 * buffer.h (struct buffer): Likewise.
4130 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4131 * frame.h (struct frame): Likewise.
4132 * process.h (struct Lisp_Process): Likewise.
4133 * termhooks.h (struct terminal): Likewise.
4134 * window.c (struct save_window_data, struct saved_window): Likewise.
4135 * window.h (struct window): Likewise.
4136 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4137 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4138 * buffer.c (init_buffer_once): Likewise.
4139 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4141 * process.c (Fformat_network_address): Use local var for size,
4144 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4146 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4147 * data.c (atof): Remove decl; no longer used or needed.
4148 (digit_to_number): Move to lread.c.
4149 (Fstring_to_number): Use new string_to_number function, to be
4150 consistent with how the Lisp reader treats infinities and NaNs.
4151 Do not assume that floating-point numbers represent EMACS_INT
4152 without losing information; this is not true on most 64-bit hosts.
4153 Avoid double-rounding errors, by insisting on integers when
4154 parsing non-base-10 numbers, as the documentation specifies.
4155 * lisp.h (string_to_number): New decl, replacing ...
4156 (isfloat_string): Remove.
4157 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4158 (read1): Do not accept +. and -. as integers; this
4159 appears to have been a coding error. Similarly, do not accept
4160 strings like +-1e0 as floating point numbers. Do not report
4161 overflow for integer overflows unless the base is not 10 which
4162 means we have no simple and reliable way to continue.
4163 Break out the floating-point parsing into a new
4164 function string_to_number, so that Fstring_to_number parses
4165 floating point numbers consistently with the Lisp reader.
4166 (digit_to_number): Move here from data.c. Make it static inline.
4167 (E_CHAR, EXP_INT): Remove, replacing with ...
4168 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4169 (string_to_number): New function, replacing isfloat_string.
4170 This function checks for valid syntax and produces the resulting
4171 Lisp float number too. Rework it so that string-to-number
4172 no longer mishandles examples like "1.0e+". Use strtoumax,
4173 so that overflow for non-base-10 numbers is reported only when
4174 there's no portable and simple way to convert to floating point.
4176 * textprop.c (set_text_properties_1): Rewrite for clarity,
4177 and to avoid GCC warning about integer overflow.
4179 * intervals.h (struct interval): Use EMACS_INT for members
4180 where EMACS_UINT might cause problems. See
4181 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4182 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4183 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4185 (offset_intervals): Tell GCC not to worry about length overflow
4186 when negating a negative length.
4188 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4189 (overrun_check_free): Likewise.
4191 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4192 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4195 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4196 (gnutls_make_error): Rename local to avoid shadowing.
4197 (gnutls_emacs_global_deinit): ifdef out; not used.
4198 (Fgnutls_boot): Use const for pointer to readonly storage.
4199 Comment out unused local. Fix pointer signedness problems.
4201 * lread.c (openp): Don't stuff size_t into an 'int'.
4202 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4203 about possible signed overflow.
4205 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4206 (GDK_KEY_g): Don't define if already defined.
4207 (xg_prepare_tooltip): Avoid pointer signedness problem.
4208 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4210 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4211 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4213 * xfns.c (Fx_window_property): Simplify a bit,
4214 to make a bit faster and to avoid GCC 4.6.0 warning.
4215 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4217 * fns.c (internal_equal): Don't assume size_t fits in int.
4219 * alloc.c (compact_small_strings): Tighten assertion a little.
4221 Replace pEd with more-general pI, and fix some printf arg casts.
4222 * lisp.h (pI): New macro, generalizing old pEd macro to other
4223 conversion specifiers. For example, use "...%"pI"d..." rather
4224 than "...%"pEd"...".
4225 (pEd): Remove. All uses replaced with similar uses of pI.
4226 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4227 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4228 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4229 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4230 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4231 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4232 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4234 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4235 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4236 * print.c (safe_debug_print, print_object): Likewise.
4237 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4239 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4240 avoiding the 0 flag, which is not portable.
4241 * process.c (Fmake_network_process): Use pI to avoid cast.
4242 * region-cache.c (pp_cache): Likewise.
4243 * xdisp.c (decode_mode_spec): Likewise.
4244 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4245 behavior on 64-bit hosts with printf arg.
4246 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4247 (x_stop_queuing_selection_requests): Likewise.
4248 (x_get_window_property): Don't truncate byte count to an 'int'
4251 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4252 here, since it parses constructs like leading '-' and spaces,
4253 which are not wanted; and it overflows with large numbers.
4254 Instead, simply match F[0-9]+, which is what is wanted anyway.
4256 * alloc.c: Remove unportable assumptions about struct layout.
4257 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4258 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4259 (allocate_vectorlike, make_pure_vector): Use the new macros,
4260 plus offsetof, to remove unportable assumptions about struct layout.
4261 These assumptions hold on all porting targets that I know of, but
4262 they are not guaranteed, they're easy to remove, and removing them
4263 makes further changes easier.
4265 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4266 This doesn't fix a bug but makes the code clearer.
4267 (string_overrun_cookie): Now const. Use initializers that
4268 don't formally overflow signed char, to avoid warnings.
4269 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4270 can cause Emacs to crash when string overrun checking is enabled.
4271 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4272 multiple of sizeof (EMACS_INT); it need not be, if
4273 alignof(EMACS_INT) < sizeof (EMACS_INT).
4274 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4276 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4278 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4280 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4282 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4283 supposed to be handshaking. (Bug#8556)
4284 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4286 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4288 * lisp.h (Qdebug): List symbol.
4289 * eval.c (Qdebug): Restore global linkage.
4290 * keyboard.c (debug-on-event): New variable.
4291 (handle_user_signal): Break into debugger when debug-on-event
4292 matches the current signal symbol.
4294 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4296 * alloc.c (check_sblock, check_string_bytes)
4297 (check_string_free_list): Convert to standard C.
4299 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4301 * w32.c (emacs_gnutls_push): Fix typo.
4303 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4305 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4306 "cast to pointer from integer of different size".
4308 Improve doprnt and its use in verror. (Bug#8545)
4309 * doprnt.c (doprnt): Document the set of format control sequences
4310 supported by the function. Use SAFE_ALLOCA instead of always
4313 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4314 is one byte too soon. Don't use xrealloc; instead xfree and
4317 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4319 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4322 * gnutls.c: Renamed global_initialized to
4323 gnutls_global_initialized. Added internals for the
4324 :verify-hostname-error, :verify-error, and :verify-flags
4325 parameters of `gnutls-boot' and documented those parameters in the
4326 docstring. Start callback support.
4327 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4328 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4329 on error. Return error code.
4330 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4331 (emacs_gnutls_read): Likewise.
4332 (Fgnutls_boot): Return handshake error code.
4333 (emacs_gnutls_handle_error): New function.
4334 (wsaerror_to_errno): Likewise.
4336 * w32.h (emacs_gnutls_pull): Add prototype.
4337 (emacs_gnutls_push): Likewise.
4339 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4340 (emacs_gnutls_push): Likewise.
4342 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4344 * process.c (wait_reading_process_output): Check if GnuTLS
4345 buffered some data internally if no FDs are set for TLS
4348 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4349 (LIBS): Link to USER_LIBS.
4350 ($(BLD)/gnutls.$(0)): New target.
4352 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4354 * xdisp.c (handle_single_display_spec): Rename the
4355 display_replaced_before_p argument into display_replaced_p, to
4356 make it consistent with the commentary. Fix typos in the
4359 * textprop.c (syms_of_textprop): Remove dead code.
4360 (copy_text_properties): Delete obsolete commentary about an
4361 interface that was deleted long ago. Fix typos in the description
4364 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4365 to changes in oldXMenu/XMenu.h from 2011-04-16.
4366 <menu_help_message, prev_menu_help_message>: Constify.
4367 (IT_menu_make_room): menu->help_text is now `const char **';
4370 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4371 to changes in oldXMenu/XMenu.h from 2011-04-16.
4372 (struct XMenu): Declare `help_text' `const char **'.
4374 * xfaces.c <Qunspecified>: Make extern again.
4376 * syntax.c: Include sys/types.h before including regex.h, as
4379 * doc.c (get_doc_string): Improve the format passed to `error'.
4381 * doprnt.c (doprnt): Improve commentary.
4383 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4385 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4388 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4389 changes in globals.h immediately force recompilation.
4390 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4391 $(CURDIR)/s/ms-w32.h.
4392 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4394 * character.c (Fchar_direction): Function deleted.
4395 (syms_of_character): Don't defsubr it.
4396 <char-direction-table>: Deleted.
4398 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4400 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4401 * doprnt.c: Include limits.h.
4402 (SIZE_MAX): New macro.
4403 (doprnt): Return a size_t value. 2nd arg is now size_t.
4404 Many local variables are now size_t instead of int or unsigned.
4405 Improve overflow protection. Support `l' modifier for integer
4406 conversions. Support %l conversion. Don't assume an EMACS_INT
4407 argument for integer conversions and for %c.
4409 * lisp.h (doprnt): Restore prototype.
4411 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4414 * Makefile.in (base_obj): Add back doprnt.o.
4416 * deps.mk (doprnt.o): Add back prerequisites.
4417 (callint.o): Depend on character.h.
4419 * eval.c (internal_lisp_condition_case): Include the handler
4420 representation in the error message.
4421 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4422 when breaking from the loop.
4424 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4426 * callint.c (Fcall_interactively): When displaying error message
4427 about invalid control letter, pass the character's codepoint, not
4428 a pointer to its multibyte form. Improve display of the character
4429 in octal and display also its hex code.
4431 * character.c (char_string): Use %x to display the (unsigned)
4432 codepoint of an invalid character, to avoid displaying a bogus
4435 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4436 `error', not SYMBOL_NAME itself.
4438 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4439 character arguments to `error'.
4441 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4442 to `error' in error message about FINAL_CHAR argument. Make sure
4443 FINAL_CHAR is a character, and use %c when it is passed as
4444 argument to `error'.
4446 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4448 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4450 * w32.c: Include <time.h>.
4451 (sys_localtime): New function.
4453 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4455 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4457 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4459 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4461 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4464 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4466 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4467 gl_state.e_property when gl_state.object is Qt.
4469 * insdel.c (make_gap_larger): Remove limitation of buffer size
4472 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4474 * xdisp.c (lookup_glyphless_char_display)
4475 (produce_glyphless_glyph): Handle cons cell entry in
4476 glyphless-char-display.
4477 (Vglyphless_char_display): Document it.
4479 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4480 glyphless-char-display.
4482 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4484 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4486 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4488 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4489 definition for no-X builds.
4491 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4493 Static checks with GCC 4.6.0 and non-default toolkits.
4495 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4497 * process.c (keyboard_bit_set): Define only if SIGIO.
4498 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4499 (send_process): Repair possible setjmp clobbering.
4501 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4503 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4505 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4507 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4508 Define only if needed.
4510 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4511 by pacifying GCC about it. Maybe it's time to retire it?
4512 * xfaces.c (USG, __TIMEVAL__): Likewise.
4514 * dispextern.h (struct redisplay_interface): Rename param
4516 * termhooks.h (struct terminal): Likewise.
4517 * xterm.c (xembed_send_message): Likewise.
4519 * insdel.c (make_gap_smaller): Define only if
4520 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4522 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4525 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4526 so that we aren't warned about unused symbols.
4528 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4530 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4532 * xfns.c (x_real_positions): Mark locals as initialized.
4534 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4536 * xterm.c: Fix problems found by static analysis with other toolkits.
4537 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4538 (x_dispatch_event): Declare static if USE_GTK, and
4539 define if USE_GTK || USE_X_TOOLKIT.
4540 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4541 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4542 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4543 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4545 * xmenu.c (menu_help_callback): Pointer type fixes.
4546 Use const pointers when pointing at readonly data. Avoid pointer
4548 (FALSE): Remove unused macro.
4549 (update_frame_menubar): Remove unused decl.
4551 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4553 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4554 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4555 (single_menu_item): Rename local to avoid shadowing.
4557 * keyboard.c (make_lispy_event): Remove unused local var.
4559 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4560 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4562 * bitmaps: Change bitmaps from unsigned char back to the X11
4563 compatible char. Avoid the old compiler warnings about
4564 out-of-range initializers by using, for example, '\xab' rather
4567 * xgselect.c (xgselect_initialize): Check vs interface
4568 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4570 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4572 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4573 to read-only memory.
4575 * fns.c (vector): Remove; this old hack is no longer needed.
4577 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4579 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4581 * xrdb.c (x_load_resources): Omit unused local.
4583 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4584 (x_window): Rename locals to avoid shadowing.
4585 (USG): Use the kludged USG macro, to pacify gcc.
4587 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4588 (x_term_init): Remove local to avoid shadowing.
4590 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4592 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4593 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4595 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4597 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4599 Fix regex.c, syntax.c and friends for buffers > 2GB.
4600 * syntax.h (struct gl_state_s): Declare character position members
4603 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4605 * textprop.c (verify_interval_modification, interval_of):
4606 Declare arguments EMACS_INT.
4608 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4611 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4613 * indent.c (Fvertical_motion): Local variable it_start is now
4616 * regex.c (re_match, re_match_2, re_match_2_internal)
4617 (bcmp_translate, regcomp, regexec, print_double_string)
4618 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4619 (re_compile_pattern, re_exec): Declare arguments and local
4620 variables `size_t' and `ssize_t' and return values `regoff_t', as
4622 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4623 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4624 <compile_stack_type>: `size' and `avail' are now `size_t'.
4626 * regex.h <regoff_t>: Use ssize_t, not int.
4627 (re_search, re_search_2, re_match, re_match_2): Arguments that
4628 specify buffer/string position and length are now ssize_t and
4629 size_t. Return type is regoff_t.
4631 2011-04-16 Ben Key <bkey76@gmail.com>
4633 * nsfont.m: Fixed bugs in ns_get_family and
4634 ns_descriptor_to_entity that were caused by using free to
4635 deallocate memory blocks that were allocated by xmalloc (via
4636 xstrdup). This caused Emacs to crash when compiled with
4637 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4638 --enable-checking=xmallocoverrun). xfree is now used to
4639 deallocate these memory blocks.
4641 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4643 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4645 emacs_write: Accept and return EMACS_INT for sizes.
4646 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4648 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4649 Accept and return EMACS_INT.
4650 (emacs_gnutls_write): Return the number of bytes written on
4652 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4653 (emacs_read, emacs_write): Remove check for negative size, as the
4654 Emacs source code has been audited now.
4655 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4656 (emacs_read, emacs_write): Use it.
4657 * process.c (send_process): Adjust to the new signatures of
4658 emacs_write and emacs_gnutls_write. Do not attempt to store
4659 a byte offset into an 'int'; it might overflow.
4660 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4662 * sound.c: Don't assume sizes fit in 'int'.
4663 (struct sound_device.period_size, alsa_period_size):
4664 Return EMACS_INT, not int.
4665 (struct sound_device.write, vox_write, alsa_write):
4666 Accept EMACS_INT, not int.
4667 (wav_play, au_play): Use EMACS_INT to store sizes and to
4668 record read return values.
4670 2011-04-15 Ben Key <bkey76@gmail.com>
4672 * keyboard.c (Qundefined): Don't declare static since it is used
4674 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4675 static since they are used in nsfont.m.
4677 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4679 * process.c (Qprocessp): Don't declare static.
4680 * lisp.h (Qprocessp): Declare again.
4682 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4684 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4686 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4688 Improve C-level modularity by making more things 'static'.
4690 Don't publish debugger-only interfaces to other modules.
4691 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4692 (verify_bytepos, count_markers): Move decls to the only modules
4694 * region-cache.h (pp_cache): Likewise.
4695 * window.h (check_all_windows): Likewise.
4696 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4698 * sysdep.c (croak): Now static, if
4699 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4700 * syssignal.h (croak): Declare only if not static.
4702 * alloc.c (refill_memory_reserve): Now static if
4703 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4704 * lisp.h (refill_memory_reserve): Declare only if not static.
4706 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4707 Define only if USE_LUCID.
4709 * xrdb.c (x_customization_string, x_rm_string): Now static.
4711 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4712 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4714 * xdisp.c (draw_row_with_mouse_face): Now static.
4715 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4717 * window.h (check_all_windows): Mark externally visible.
4719 * window.c (window_deletion_count): Now static.
4721 * undo.c: Make symbols static if they're not exported.
4722 (last_undo_buffer, last_boundary_position, pending_boundary):
4725 * textprop.c (interval_insert_behind_hooks): Now static.
4726 (interval_insert_in_front_hooks): Likewise.
4728 * term.c: Make symbols static if they're not exported.
4729 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4730 (max_frame_lines, tty_set_terminal_modes):
4731 (tty_reset_terminal_modes, tty_turn_off_highlight):
4732 (get_tty_terminal): Now static.
4733 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4734 * termhooks.h (term_mouse_moveto): Do not declare if
4736 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4737 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4739 * sysdep.c: Make symbols static if they're not exported.
4740 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4742 (sigprocmask_set, full_mask): Remove; unused.
4743 (wait_debugging): Mark as visible.
4744 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4745 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4747 * syntax.c (syntax_temp): Define only if !__GNUC__.
4749 * sound.c (current_sound_device, current_sound): Now static.
4751 * search.c (searchbufs, searchbuf_head): Now static.
4753 * scroll.c (scroll_cost): Remove; unused.
4754 * dispextern.h (scroll_cost): Remove decl.
4756 * region-cache.h (pp_cache): Mark as externally visible.
4758 * process.c: Make symbols static if they're not exported.
4759 (process_tick, update_tick, create_process, chan_process):
4760 (Vprocess_alist, proc_buffered_char, datagram_access):
4761 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4762 (deactivate_process): Mark defn as static, as well as decl.
4763 * lisp.h (create_process): Remove decl.
4764 * process.h (chan_process, Vprocess_alist): Remove decls.
4766 * print.c: Make symbols static if they're not exported.
4767 (print_depth, new_backquote_output, being_printed, print_buffer):
4768 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4769 (print_interval, print_number_index, initial_stderr_stream):
4771 * lisp.h (Fprinc): Remove decl.
4772 (debug_output_compilation_hack): Mark as externally visible.
4774 * sysdep.c (croak): Move decl from here to syssignal.h.
4775 * syssignal.h (croak): Put it here, so the API can be checked when
4776 'croak' is called from dissociate_if_controlling_tty.
4778 * minibuf.c: Make symbols static if they're not exported.
4779 (minibuf_save_list, choose_minibuf_frame): Now static.
4780 * lisp.h (choose_minibuf_frame): Remove decl.
4782 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4784 * lread.c: Make symbols static if they're not exported.
4785 (read_objects, initial_obarray, oblookup_last_bucket_number):
4787 (make_symbol): Remove; unused.
4788 * lisp.h (initial_obarray, make_symbol): Remove decls.
4790 * keyboard.c: Make symbols static if they're not exported.
4791 (single_kboard, recent_keys_index, total_keys, recent_keys):
4792 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4793 (this_single_command_key_start, echoing, last_auto_save):
4794 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4795 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4796 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4797 (Vlispy_mouse_stem, double_click_count):
4799 (force_auto_save_soon): Define only if SIGDANGER.
4800 (ignore_mouse_drag_p): Now static if
4801 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4802 (print_help): Remove; unused.
4803 (stop_character, last_timer_event): Mark as externally visible.
4804 * keyboard.h (ignore_mouse_drag_p): Declare only if
4805 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4806 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4807 * lisp.h (echoing): Remove decl.
4808 (force_auto_save_soon): Declare only if SIGDANGER.
4809 * xdisp.c (redisplay_window): Simplify code, to make it more
4810 obvious that ignore_mouse_drag_p is not accessed if !defined
4811 USE_GTK && !defined HAVE_NS.
4813 * intervals.c: Make symbols static if they're not exported.
4814 (merge_properties_sticky, merge_interval_right, delete_interval):
4816 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4818 * insdel.c: Make symbols static if they're not exported.
4819 However, leave prepare_to_modify_buffer alone. It's never
4820 called from outside this function, but that appears to be a bug.
4821 (combine_after_change_list, combine_after_change_buffer):
4822 (adjust_after_replace, signal_before_change): Now static.
4823 (adjust_after_replace_noundo): Remove; unused.
4824 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4825 (signal_before_change): Remove decls.
4827 * indent.c (val_compute_motion, val_vmotion): Now static.
4829 * image.c: Make symbols static if they're not exported.
4830 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4832 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4833 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4835 * fringe.c (standard_bitmaps): Now static.
4836 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4838 * frame.c: Make symbols static if they're not exported.
4839 (x_report_frame_params, make_terminal_frame): Now static.
4840 (get_frame_param): Now static, unless HAVE_NS.
4841 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4842 (x_get_resource_string): Remove; not used.
4843 * frame.h (make_terminal_frame, x_report_frame_params):
4844 (x_get_resource_string); Remove decls.
4845 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4846 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4848 * font.c, fontset.c: Make symbols static if they're not exported.
4849 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4850 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4851 * font.c (font_close_object): Now static.
4852 * font.h (font_close_object): Remove.
4853 * fontset.c (FONTSET_OBJLIST): Remove.
4854 (free_realized_fontset) #if-0 the body, which does nothing.
4855 (face_suitable_for_char_p): #if-0, as it's never called.
4856 * fontset.h (face_suitable_for_char_p): Remove decl.
4857 * xfaces.c (face_at_string_position):
4858 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4859 since 0 is always ASCII.
4861 * fns.c (weak_hash_tables): Now static.
4863 * fileio.c: Make symbols static if they're not exported.
4864 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4865 (Vwrite_region_annotation_buffers): Now static.
4867 * eval.c: Make symbols static if they're not exported.
4868 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4869 * lisp.h (backtrace_list): Remove decl.
4871 * emacs.c: Make symbols static if they're not exported.
4872 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4873 (fatal_error_code, fatal_error_signal_hook, standard_args):
4875 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4876 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4877 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4878 * lisp.h (fatal_error_signal_hook): Remove decl.
4879 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4881 * editfns.c: Move a (normally-unused) function to its only use.
4882 * editfns.c, lisp.h (get_operating_system_release): Remove.
4883 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4884 worth the hassle of breaking this out.
4886 * xterm.c: Make symbols static if they're not exported.
4887 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4888 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4889 (x_destroy_window, x_delete_display):
4891 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4892 (x_mouse_leave): Remove; unused.
4893 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4894 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4895 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4897 (x_mouse_leave): Declare only if WINDOWSNT.
4898 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4899 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4902 * ftxfont.c: Make symbols static if they're not exported.
4903 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4905 * font.h (ftxfont_driver): Likewise.
4907 * xfns.c: Make symbols static if they're not exported.
4908 (x_last_font_name, x_display_info_for_name):
4909 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4910 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4911 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4912 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4913 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4914 (last_show_tip_args): Now static.
4915 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4916 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4917 (x_screen_planes): Remove; unused.
4918 * dispextern.h (x_screen_planes): Remove decl.
4920 * dispnew.c: Make symbols static if they're not exported.
4921 * dispextern.h (redraw_garbaged_frames, scrolling):
4922 (increment_row_positions): Remove.
4923 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4924 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4926 (redraw_garbaged_frames): Remove; unused.
4928 * xfaces.c: Make symbols static if they're not exported.
4929 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4931 * xterm.h (defined_color): Remove decls.
4932 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4933 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4934 (menu_face_changed_default, defined_color, free_realized_face):
4935 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4936 (ascii_face_of_lisp_face): Remove; unused.
4938 * xdisp.c: Make symbols static if they're not exported.
4939 * dispextern.h (scratch_glyph_row, window_box_edges):
4940 (glyph_to_pixel_coords, set_cursor_from_row):
4941 (get_next_display_element, set_iterator_to_next):
4942 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4943 (show_mouse_face): Remove decls
4944 * frame.h (message_buf_print): Likewise.
4945 * lisp.h (pop_message, set_message, check_point_in_composition):
4947 * xterm.h (set_vertical_scroll_bar): Likewise.
4948 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4949 (message_buf_print, scratch_glyph_row, displayed_buffer):
4950 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4951 (get_next_display_element, show_mouse_face, window_box_edges):
4952 (frame_to_window_pixel_xy, check_point_in_composition):
4953 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4954 (glyph_to_pixel_coords): Remove; unused.
4956 * dired.c (file_name_completion): Now static.
4958 * dbusbind.c (xd_in_read_queued_messages): Now static.
4960 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4961 * data.c (circular_list_error): Remove.
4963 * commands.h (last_point_position, last_point_position_buffer):
4964 (last_point_position_window): Remove decls.
4965 * keyboard.c: Make these variables static.
4967 * coding.h (coding, code_convert_region, encode_coding_gap):
4969 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4970 (iso_code_class, detect_coding, code_convert_region): Now static.
4971 (encode_coding_gap): Remove; unused.
4973 * chartab.c (chartab_chars, chartab_bits): Now static.
4975 * charset.h (charset_iso_8859_1): Remove decl.
4976 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4979 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4980 * ccl.c (Vccl_program_table): Now static.
4981 (check_ccl_update): Remove; unused.
4983 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4984 * category.h: ... from here.
4985 * category.c (check_category_table, set_category_set): Now static.
4987 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4988 * lisp.h: Remove these decls.
4990 * buffer.c (buffer_count): Remove unused var.
4992 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4993 so that it's not optimized away.
4994 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4995 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4996 exported only to the debugger.
4998 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4999 * atimer.h (run_all_atimers): Remove; not exported.
5001 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5002 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5003 was inaccessible from Lisp.
5004 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5005 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5007 alloc.c: Import and export fewer symbols, and remove unused items.
5008 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5010 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5011 it's not optimized away by whole-program optimization.
5012 (message_enable_multibyte, free_misc): Remove.
5013 (catchlist, handlerlist, mark_backtrace):
5014 Declare only if BYTE_MARK_STACK.
5015 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5016 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5017 (message_enable_multibyte): Remove decl.
5018 (free_misc, interval_free_list, float_block, float_block_index):
5019 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5020 (cons_free_list, last_marked_index):
5022 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5023 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5024 (mark_backtrace): Define only if BYTE_MARK_STACK.
5025 * xdisp.c (message_enable_multibyte): Now static.
5027 Declare Lisp_Object Q* variables to be 'static' if not exported.
5028 This makes it easier for human readers (and static analyzers)
5029 to see whether these variables are used from other modules.
5030 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5031 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5032 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5033 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5034 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5035 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5036 * xmenu.c, xselect.c:
5037 Declare Q* vars static if they are not used in other modules.
5038 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5039 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5040 Remove decls of unexported vars.
5041 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5043 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5045 Make Emacs functions such as Fatom 'static' by default.
5046 This makes it easier for human readers (and static analyzers)
5047 to see whether these functions can be called from other modules.
5048 DEFUN now defines a static function. To make the function external
5049 so that it can be used in other C modules, use the new macro DEFUE.
5050 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5051 (Finit_image_library):
5052 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5053 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5054 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5055 Remove decls, since these functions are now static.
5056 (Funintern, Fget_internal_run_time): New decls, since these functions
5057 were already external.
5059 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5060 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5061 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5062 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5063 * keyboard.c, keymap.c, lread.c:
5064 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5065 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5066 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5067 Mark functions with DEFUE instead of DEFUN,
5068 if they are used in other modules.
5069 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5070 decls for now-static functions.
5071 * buffer.h (Fdelete_overlay): Remove decl.
5072 * callproc.c (Fgetenv_internal): Mark as internal.
5073 * composite.c (Fremove_list_of_text_properties): Remove decl.
5074 (Fcomposition_get_gstring): New forward static decl.
5075 * composite.h (Fcomposite_get_gstring): Remove decl.
5076 * dired.c (Ffile_attributes): New forward static decl.
5077 * doc.c (Fdocumntation_property): New forward static decl.
5078 * eval.c (Ffetch_bytecode): New forward static decl.
5079 (Funintern): Remove extern decl; now in .h file where it belongs.
5080 * fileio.c (Fmake_symbolic_link): New forward static decl.
5081 * image.c (Finit_image_library): New forward static decl.
5082 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5083 * intervals.h (Fprevious_property_change):
5084 (Fremove_list_of_text_properties): Remove decls.
5085 * keyboard.c (Fthis_command_keys): Remove decl.
5086 (Fcommand_execute): New forward static decl.
5087 * keymap.c (Flookup_key): New forward static decl.
5088 (Fcopy_keymap): Now static.
5089 * keymap.h (Flookup_key): Remove decl.
5090 * process.c (Fget_process): New forward static decl.
5091 (Fprocess_datagram_address): Mark as internal.
5092 * syntax.c (Fsyntax_table_p): New forward static decl.
5093 (skip_chars): Remove duplicate decl.
5094 * textprop.c (Fprevious_property_change): New forward static decl.
5095 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5097 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5098 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5100 * editfns.c (Fformat): Remove unreachable code.
5102 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5104 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5107 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5109 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5110 when at ZV. (Bug#8487)
5112 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5114 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5116 * keyboard.c (parse_tool_bar_item): Likewise.
5117 * sound.c (sound_cleanup, alsa_close): Likewise.
5118 * termcap.c (tgetent): Likewise.
5119 * xfns.c (x_default_font_parameter): Likewise.
5120 * xsettings.c (read_and_apply_settings): Likewise.
5122 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5123 (overrun_check_free): Protoize.
5125 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5127 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5128 since callers should never pass a negative size.
5129 Change the signature to match that of plain 'read' and 'write'; see
5130 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5131 * lisp.h: Update prototypes of emacs_write and emacs_read.
5133 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5135 * xdisp.c (redisplay_window): Don't try to determine the character
5136 position of the scroll margin if the window start point w->startp
5137 is outside the buffer's accessible region. (Bug#8468)
5139 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5141 Fix write-region and its subroutines for buffers > 2GB.
5142 * fileio.c (a_write, e_write): Modify declaration of arguments and
5143 local variables to support buffers larger than 2GB.
5144 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5146 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5147 argument, local variables, and return value.
5149 * lisp.h: Update prototypes of emacs_write and emacs_read.
5151 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5153 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5155 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5157 Fix more problems found by GCC 4.6.0's static checks.
5159 * xdisp.c (vmessage): Use a better test for character truncation.
5161 * charset.c (load_charset_map): <, not <=, for optimization,
5162 and to avoid potential problems with integer overflow.
5163 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5164 * casetab.c (set_identity, shuffle): Likewise.
5165 * editfns.c (Fformat): Likewise.
5166 * syntax.c (skip_chars): Likewise.
5168 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5169 This also lets GCC 4.6.0 generate slightly better loop code.
5171 * callint.c (Fcall_interactively): <, not <=, for optimization.
5172 (Fcall_interactively): Count the number of arguments produced,
5173 not the number of arguments given. This is simpler and lets GCC
5174 4.6.0 generate slightly better code.
5176 * ftfont.c: Distingish more carefully between FcChar8 and char.
5177 The previous code passed unsigned char * to a functions like
5178 strlen and xstrcasecmp that expect char *, which does not
5179 conform to the C standard.
5180 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5181 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5182 char * when the C standard requires it.
5184 * keyboard.c (read_char): Remove unused var.
5186 * eval.c: Port to Windows vsnprintf (Bug#8435).
5188 (SIZE_MAX): Define if the headers do not.
5189 (verror): Do not give up if vsnprintf returns a negative count.
5190 Instead, grow the buffer. This ports to Windows vsnprintf, which
5191 does not conform to C99. Problem reported by Eli Zaretskii.
5192 Also, simplify the allocation scheme, by avoiding the need for
5193 calling realloc, and removing the ALLOCATED variable.
5195 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5197 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5198 But keep the doprint source code for now, as we might revamp it
5199 and use it again (Bug#8435).
5200 * lisp.h (doprnt): Remove.
5201 * Makefile.in (base_obj): Remove doprnt.o.
5202 * deps.mk (doprnt.o): Remove.
5204 error: Print 32- and 64-bit integers portably (Bug#8435).
5205 Without this change, on typical 64-bit hosts error ("...%d...", N)
5206 was used to print both 32- and 64-bit integers N, which relied on
5208 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5210 * lisp.h (error, verror): Mark as printf-like functions.
5211 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5212 Report overflow in size calculations when allocating printf buffer.
5213 Do not truncate output string at its first null byte.
5214 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5215 Truncate the output at a character boundary, since vsnprintf does not
5217 * charset.c (check_iso_charset_parameter): Convert internal
5218 character to string before calling 'error', since %c now has the
5220 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5221 overflow when computing char to be passed to 'error'. Do not
5222 pass Lisp_Object to 'error'; pass the integer instead.
5223 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5224 formatted with plain %d.
5226 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5228 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5230 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5232 * xterm.c (x_catch_errors): Remove duplicate declaration.
5234 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5236 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5238 2011-04-10 Jim Meyering <meyering@redhat.com>
5240 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5241 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5242 return ssize_t not "int", and use size_t as the buffer length.
5243 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5244 * gnutls.h: Update declarations.
5245 * process.c (read_process_output): Use ssize_t, to match.
5246 (send_process): Likewise.
5248 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5250 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5252 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5254 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5255 Use unsigned char, to match FcChar8 type definition.
5257 * xterm.c (handle_one_xevent):
5258 * xmenu.c (create_and_show_popup_menu):
5259 * xselect.c (x_decline_selection_request)
5260 (x_reply_selection_request): Avoid type-punned deref of X events.
5262 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5264 Fix some uses of `int' instead of EMACS_INT.
5265 * search.c (string_match_1, fast_string_match)
5266 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5267 (scan_buffer, find_next_newline_no_quit)
5268 (find_before_next_newline, search_command, Freplace_match)
5269 (Fmatch_data): Make some `int' variables be EMACS_INT.
5271 * xdisp.c (display_count_lines): 3rd argument and return value now
5272 EMACS_INT. All callers changed.
5273 (pint2hrstr): Last argument is now EMACS_INT.
5275 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5276 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5277 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5278 (decode_coding_utf_16, decode_coding_emacs_mule)
5279 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5280 (decode_coding_ccl, decode_coding_charset)
5281 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5282 (decode_coding_iso_2022, decode_coding_emacs_mule)
5283 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5284 <char_offset, last_offset>: Declare EMACS_INT.
5285 (encode_coding_utf_8, encode_coding_utf_16)
5286 (encode_coding_emacs_mule, encode_invocation_designation)
5287 (encode_designation_at_bol, encode_coding_iso_2022)
5288 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5289 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5291 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5292 (encode_invocation_designation): Last argument P_NCHARS is now
5294 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5295 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5297 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5300 * ccl.c (Fccl_execute_on_string): Declare some variables
5303 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5305 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5307 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5309 * process.c (Fformat_network_address): Doc fix.
5311 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5313 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5315 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5317 * keyboard.c (read_char): Call Lisp function help-form-show,
5318 instead of using internal_with_output_to_temp_buffer.
5319 (Qhelp_form_show): New var.
5320 (syms_of_keyboard): Use DEFSYM macro.
5322 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5324 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5326 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5328 * process.c (Flist_processes): Remove to Lisp.
5329 (list_processes_1): Delete.
5331 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5333 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5335 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5337 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5339 Fix more problems found by GCC 4.6.0's static checks.
5341 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5343 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5345 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5347 * xdisp.c (vmessage): Mark as a printf-like function.
5349 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5351 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5353 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5354 printf-like functions.
5355 (tiff_load): Add casts to remove these marks before passing them
5356 to system-supplied API.
5358 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5360 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5361 This avoids several warnings with gcc -Wstrict-overflow.
5362 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5363 directly, rather than having caller test rule sign. This avoids
5364 some unnecessary tests.
5365 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5366 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5367 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5369 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5370 (xfont_open): Avoid unnecessary tests.
5372 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5374 * composite.h, composite.c (composition_gstring_put_cache):
5375 Use EMACS_INT, not int, for length.
5377 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5378 breaking out part of COMPOSITION_DECODE_RULE.
5379 (COMPOSITION_DECODE_RULE): Use it.
5380 * composite.c (get_composition_id): Remove unused local vars,
5381 by using the new macro.
5383 * textprop.c (set_text_properties_1): Change while to do-while,
5384 since the condition is always true at first.
5386 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5387 (interval_deletion_adjustment): Return unsigned value.
5390 * process.c (list_processes_1, create_pty, read_process_output):
5391 (exec_sentinel): Remove vars that were set but not used.
5392 (create_pty): Remove unnecessary "volatile"s.
5393 (Fnetwork_interface_info): Avoid possibility of int overflow.
5394 (read_process_output): Do adaptive read buffering even if carryover.
5395 (read_process_output): Simplify nbytes computation if buffered.
5397 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5399 * syntax.c (scan_words): Remove var that was set but not used.
5400 (update_syntax_table): Use unsigned instead of int.
5402 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5403 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5404 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5406 * print.c (print_error_message): Avoid int overflow.
5408 * font.c (font_list_entities): Redo for clarity,
5409 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5411 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5412 (font_score): Avoid potential overflow in diff calculation.
5414 * fns.c (substring_both): Remove var that is set but not used.
5415 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5417 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5419 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5420 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5421 can always succeed if overflow has undefined behavior.
5423 * search.c (boyer_moore, wordify): Remove vars set but not used.
5424 (wordify): Omit three unnecessary tests.
5426 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5427 All callers changed. This avoids the need for an unused var.
5429 * casefiddle.c (casify_region): Remove var that is set but not used.
5431 * dired.c (file_name_completion): Remove var that is set but not used.
5433 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5435 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5436 (Finsert_file_contents): Remove unnecessary code checking fd.
5438 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5439 Check for integer overflow on size calculations.
5441 * buffer.c (Fprevious_overlay_change): Remove var that is set
5444 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5445 Remove vars that are set but not used.
5446 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5447 (timer_check_2): Mark vars as initialized.
5449 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5451 * image.c (lookup_image): Remove var that is set but not used.
5452 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5454 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5455 that are set but not used.
5457 * xfns.c (make_invisible_cursor): Don't return garbage
5458 if XCreateBitmapFromData fails (Bug#8410).
5460 * xselect.c (x_get_local_selection, x_handle_property_notify):
5461 Remove vars that are set but not used.
5463 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5464 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5466 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5467 Remove var that is set but not used.
5468 (scroll_bar_windows_size): Now size_t, not int.
5469 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5472 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5473 (map_tty_color) [!defined MSDOS]: Likewise.
5475 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5477 * coding.c: Remove vars that are set but not used.
5478 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5479 All callers changed.
5480 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5481 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5482 (decode_coding_charset): Remove vars that are set but not used.
5484 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5485 that is set but not used.
5487 * print.c (print_object): Remove var that is set but not used.
5489 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5490 The gnulib version avoids calling malloc in the usual case,
5491 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5492 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5493 * filelock.c (current_lock_owner): Likewise.
5494 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5495 * sysdep.c: Include allocator.h, careadlinkat.h.
5496 (emacs_no_realloc_allocator): New static constant.
5497 (emacs_readlink): New function.
5498 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5499 ../lib/careadlinkat.h.
5501 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5503 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5504 first non-nil return value).
5506 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5508 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5509 if not defined (Bug#8403).
5511 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5513 * xdisp.c (display_count_lines): Remove parameter `start',
5514 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5515 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5516 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5517 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5518 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5519 and thereabouts. All callers changed.
5520 (get_per_char_metric): Remove parameter `f', unused since
5521 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5523 2011-04-02 Jim Meyering <meyering@redhat.com>
5525 do not dereference NULL upon failed strdup
5526 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5527 (ns_get_family): Likewise.
5529 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5531 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5533 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5535 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5538 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5540 Add lexical binding.
5542 * window.c (Ftemp_output_buffer_show): New fun.
5543 (Fsave_window_excursion):
5544 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5546 * lread.c (lisp_file_lexically_bound_p): New function.
5547 (Fload): Bind Qlexical_binding.
5548 (readevalloop): Remove `evalfun' arg.
5549 Bind Qinternal_interpreter_environment.
5550 (Feval_buffer): Bind Qlexical_binding.
5551 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5553 (syms_of_lread): Declare `lexical-binding'.
5555 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5557 * keyboard.c (eval_dyn): New fun.
5558 (menu_item_eval_property): Use it.
5560 * image.c (parse_image_spec): Use Ffunctionp.
5562 * fns.c (concat, mapcar1): Accept byte-code-functions.
5564 * eval.c (Fsetq): Handle lexical vars.
5565 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5566 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5567 (FletX, Flet): Obey lexical binding.
5568 (Fcommandp): Handle closures.
5569 (Feval): New `lexical' arg.
5570 (eval_sub): New function extracted from Feval. Use it almost
5571 everywhere where Feval was used. Look up vars in lexical env.
5573 (Ffunctionp): Move from subr.el.
5574 (Ffuncall): Handle closures.
5575 (apply_lambda): Remove `eval_flags'.
5576 (funcall_lambda): Handle closures and new byte-code-functions.
5577 (Fspecial_variable_p): New function.
5578 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5579 but without exporting it to Lisp.
5581 * doc.c (Fdocumentation, store_function_docstring):
5582 * data.c (Finteractive_form): Handle closures.
5584 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5587 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5589 (exec_byte_code): New function extracted from Fbyte_code to handle new
5590 calling convention for byte-code-functions. Add new byte-codes.
5592 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5594 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5596 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5598 * xdisp.c (redisplay_internal): Fix prototype.
5600 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5602 * xdisp.c (SCROLL_LIMIT): New macro.
5603 (try_scrolling): Use it when setting scroll_limit.
5604 Limit scrolling to 100 screen lines.
5605 (redisplay_window): Even when falling back on "recentering",
5606 position point in the window according to scroll-conservatively,
5607 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5609 (try_scrolling): When point is above the window, allow searching
5610 as far as scroll_max, or one screenful, to compute vertical
5611 distance from PT to the scroll margin position. This prevents
5612 try_scrolling from unnecessarily failing when
5613 scroll-conservatively is set to a value slightly larger than the
5614 window height. Clean up the case of PT below the margin at bottom
5615 of window: scroll_max can no longer be INT_MAX. When aggressive
5616 scrolling is in use, don't let point enter the opposite scroll
5617 margin as result of the scroll.
5618 (syms_of_xdisp) <scroll-conservatively>: Document the
5619 threshold of 100 lines for never-recentering scrolling.
5621 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5623 * dispextern.h (move_it_by_lines):
5624 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5625 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5626 (message_log_check_duplicate): Remove parameters `prev_bol' and
5627 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5628 (redisplay_internal): Remove parameter `preserve_echo_area',
5629 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5631 * indent.c (Fvertical_motion):
5632 * window.c (window_scroll_pixel_based, Frecenter):
5633 Don't pass `need_y_p' to `move_it_by_lines'.
5635 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5637 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5638 steal a few bits to be more compact.
5639 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5640 Remove unneeded casts.
5642 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5644 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5646 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5647 binding" message (bug#7967).
5649 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5651 Fix more problems found by GCC 4.6.0's static checks.
5653 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5654 Remove unused local var.
5656 * editfns.c (Fmessage_box): Remove unused local var.
5658 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5659 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5660 Omit unused local vars.
5661 * window.c (shrink_windows): Omit unused local var.
5662 * menu.c (digest_single_submenu): Omit unused local var.
5663 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5664 Omit unused local var.
5666 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5667 Don't assume string length fits in int.
5668 (keyremap_step, read_key_sequence): Use size_t for sizes.
5669 (read_key_sequence): Don't check last_real_key_start redundantly.
5671 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5672 instead of alloca (Bug#8344).
5674 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5675 (Fbacktrace_frame): Don't assume nframes fits in int.
5677 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5679 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5682 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5684 * cm.c (calccost): Turn while-do into do-while, for clarity.
5686 * keyboard.c (syms_of_keyboard): Use the same style as later
5687 in this function when indexing through an array. This also
5688 works around GCC bug 48267.
5690 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5692 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5694 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5695 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5697 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5698 This avoids undefined behavior on integer overflow, and is a bit
5699 more convenient anyway since it is compared to a size_t variable.
5701 Variadic C functions now count arguments with size_t, not int.
5702 This avoids an unnecessary limitation on 64-bit machines, which
5703 caused (substring ...) to crash on large vectors (Bug#8344).
5704 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5705 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5706 All variadic functions and their callers changed accordingly.
5707 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5708 * data.c (arith_driver, float_arith_driver): Likewise.
5709 * editfns.c (general_insert_function): Likewise.
5710 * eval.c (struct backtrace.nargs, interactive_p)
5711 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5712 (funcall_lambda, mark_backtrace): Likewise.
5713 * fns.c (concat): Likewise.
5714 * frame.c (x_set_frame_parameters): Likewise.
5715 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5716 0 if not found, not -1. All callers changed.
5718 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5719 (stack_copy_size): Now size_t, not int.
5720 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5722 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5724 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5725 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5726 All callers changed.
5728 * lisp.h (multibyte_char_to_unibyte):
5729 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5730 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5731 * character.h (CHAR_TO_BYTE8):
5732 * cmds.c (internal_self_insert):
5733 * editfns.c (general_insert_function):
5734 * keymap.c (push_key_description):
5735 * search.c (Freplace_match):
5736 * xdisp.c (message_dolog, set_message_1): All callers changed.
5738 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5740 * keyboard.c (safe_run_hook_funcall): New function.
5741 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5742 don't set the hook to nil, but remove the offending function instead.
5743 (Qcommand_hook_internal): Remove, unused.
5744 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5745 Vcommand_hook_internal.
5747 * eval.c (enum run_hooks_condition): Remove.
5748 (funcall_nil, funcall_not): New functions.
5749 (run_hook_with_args): Call each function through a `funcall' argument.
5750 Remove `cond' argument, now redundant.
5751 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5752 (Frun_hook_with_args_until_failure): Adjust accordingly.
5753 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5755 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5757 * dispextern.h (string_buffer_position): Remove declaration.
5759 * print.c (strout): Remove parameter `multibyte', unused since
5760 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5762 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5763 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5764 All callers changed.
5766 * w32.c (_wsa_errlist): Use braces for struct initializers.
5768 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5769 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5770 All callers changed.
5771 (string_buffer_position): Likewise. Also, make static (it's never
5772 used outside xdisp.c).
5773 (cursor_row_p): Remove parameter `w', unused since
5774 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5775 (decode_mode_spec): Remove parameter `precision', introduced during
5776 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5777 All callers changed.
5779 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5781 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5783 2011-03-27 Anders Lindgren <andlind@gmail.com>
5785 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5786 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5787 (ns_update_auto_hide_menu_bar): New functions.
5788 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5789 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5790 ns_constrain_all_frames.
5791 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5792 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5794 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5796 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5798 2011-03-27 Glenn Morris <rgm@gnu.org>
5800 * syssignal.h: Replace RETSIGTYPE with void.
5801 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5802 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5803 Replace SIGTYPE with void everywhere.
5804 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5805 * s/template.h (SIGTYPE): Remove commented out definition.
5807 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5809 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5810 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5812 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5814 * w32.c (read_unc_volume): Use parameter `henum', instead of
5815 global variable `wget_enum_handle'.
5817 * keymap.c (describe_vector): Remove parameters `indices' and
5818 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5819 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5821 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5823 * keyboard.c (timer_check): Remove parameter `do_it_now',
5824 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5825 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5826 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5828 * keyboard.c (read_char):
5829 * w32menu.c (w32_menu_display_help):
5830 * xmenu.c (show_help_event, menu_help_callback):
5831 Adjust calls to `show_help_echo'.
5833 * gtkutil.c (xg_maybe_add_timer):
5834 * keyboard.c (readable_events):
5835 * process.c (wait_reading_process_output):
5836 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5838 * insdel.c (adjust_markers_gap_motion):
5839 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5840 (gap_left, gap_right): Don't call it.
5842 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5844 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5845 incurred during fontification.
5847 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5849 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5850 (DEFVAR_PER_BUFFER): Don't pass it.
5852 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5853 (scrolling_window): Don't pass it.
5855 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5857 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5859 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5861 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5862 of variables specific to SELinux and computation of `encoded_absname'.
5864 * image.c (XPutPixel): Remove unused variable `height'.
5866 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5868 * unexw32.c (get_section_info): Remove unused variable `section'.
5870 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5871 (system_process_attributes): Remove unused variable `sess'.
5872 (sys_read): Remove unused variable `err'.
5874 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5875 (w32_wnd_proc): Remove unused variable `isdead'.
5876 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5877 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5878 (x_create_tip_frame): Remove unused variable `tem'.
5880 * w32inevt.c (w32_console_read_socket):
5881 Remove unused variable `no_events'.
5883 * w32term.c (x_draw_composite_glyph_string_foreground):
5884 Remove unused variable `width'.
5886 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5888 * w32term.c (x_set_glyph_string_clipping):
5889 Don't pass uninitialized region to CombineRgn.
5891 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5893 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5894 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5895 (Fx_close_connection): Remove unused variable `i'.
5897 * w32font.c (w32font_draw): Return number of glyphs.
5898 (w32font_open_internal): Remove unused variable `i'.
5899 (w32font_driver): Add missing initializer.
5901 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5902 (fill_in_menu): Remove unused variable `items_added'.
5904 * w32term.c (last_mouse_press_frame): Remove static global variable.
5905 (w32_clip_to_row): Remove unused variable `f'.
5906 (x_delete_terminal): Remove unused variable `i'.
5908 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5909 (NOTHING): Remove unused static global variable.
5910 (uniscribe_check_otf): Remove unused variable `table'.
5911 (uniscribe_font_driver): Add missing initializers.
5913 2011-03-23 Julien Danjou <julien@danjou.info>
5915 * term.c (Fsuspend_tty, Fresume_tty):
5916 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5917 * window.c (temp_output_buffer_show):
5918 * insdel.c (signal_before_change):
5919 * frame.c (Fhandle_switch_frame):
5920 * fileio.c (Fdo_auto_save):
5921 * emacs.c (Fkill_emacs):
5922 * editfns.c (save_excursion_restore):
5923 * cmds.c (internal_self_insert):
5924 * callint.c (Fcall_interactively):
5925 * buffer.c (Fkill_all_local_variables):
5926 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5928 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5929 unconditionnaly since it does the check itself.
5931 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5933 Fix more problems found by GCC 4.5.2's static checks.
5935 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5936 the first time through the loop, since we know p0 < p1 then.
5937 This also avoids a gcc -Wstrict-overflow warning.
5939 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5940 leading to a memory leak, possible in functions like
5941 load_charset_map_from_file that can allocate an unbounded number
5942 of objects (Bug#8318).
5944 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5945 that could (at least in theory) be that large.
5947 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5948 This is less likely to overflow, and avoids undefined behavior if
5949 overflow does occur. All callers changed. Use strtoul to scan
5950 for the unsigned long integer.
5951 (pint2hrstr): Simplify and tune code slightly.
5952 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5954 * scroll.c (do_scrolling): Work around GCC bug 48228.
5955 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5957 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5958 This also avoids a warning with gcc -Wstrict-overflow.
5959 (validate_x_resource_name): Simplify count usage.
5960 This also avoids a warning with gcc -Wstrict-overflow.
5962 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5965 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5967 * process.c (Fmake_network_process): Use socklen_t, not int,
5968 where POSIX says socklen_t is required in portable programs.
5969 This fixes a porting bug on hosts like 64-bit HP-UX, where
5970 socklen_t is wider than int (Bug#8277).
5971 (Fmake_network_process, server_accept_connection):
5972 (wait_reading_process_output, read_process_output):
5975 * process.c: Rename or move locals to avoid shadowing.
5976 (list_processes_1, Fmake_network_process):
5977 (read_process_output_error_handler, exec_sentinel_error_handler):
5978 Rename or move locals.
5979 (Fmake_network_process): Define label "retry_connect" only if needed.
5980 (Fnetwork_interface_info): Fix pointer signedness.
5981 (process_send_signal): Add cast to avoid pointer signedness problem.
5982 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5983 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5985 Make tparam.h and terminfo.c consistent.
5986 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5987 Include tparam.h instead, since it declares them.
5988 * cm.h (PC): Remove extern decl; tparam.h now does this.
5989 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5990 * terminfo.c: Include tparam.h, to check interfaces.
5991 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5992 (tparam): Adjust signature to match interface in tparam.h;
5993 this removes some undefined behavior. Check that outstring and len
5994 are zero, which they always are with Emacs.
5995 * tparam.h (PC, BC, UP): New extern decls.
5997 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5998 (xftfont_open): Rename locals to avoid shadowing.
6000 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6001 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6002 (OTF_TAG_SYM): Omit macro if not needed.
6003 (ftfont_list): Remove unused local.
6004 (get_adstyle_property, ftfont_pattern_entity):
6005 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6006 Rename locals to avoid shadowing.
6008 * xfont.c (xfont_list_family): Mark var as initialized.
6010 * xml.c (make_dom): Now static.
6012 * composite.c (composition_compute_stop_pos): Rename local to
6014 (composition_reseat_it): Remove unused locals.
6015 (find_automatic_composition, composition_adjust_point): Likewise.
6016 (composition_update_it): Mark var as initialized.
6017 (find_automatic_composition): Mark vars as initialized,
6018 with a FIXME (Bug#8290).
6020 character.h: Rename locals to avoid shadowing.
6021 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6022 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6023 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6024 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6027 * textprop.c (property_change_between_p): Remove; unused.
6029 * intervals.c (interval_start_pos): Now static.
6031 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6033 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6034 Rename locals to avoid shadowing.
6036 * sound.c (wav_play, au_play, Fplay_sound_internal):
6037 Fix pointer signedness.
6038 (alsa_choose_format): Remove unused local var.
6039 (wav_play): Initialize a variable to 0, to prevent undefined
6040 behavior (Bug#8278).
6042 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6044 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6046 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6047 clobbering (Bug#8298).
6048 * sysdep.c (sys_subshell): Likewise.
6049 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6051 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6052 This should get cleaned up, so that child_setup has the
6053 same signature on all platforms.
6055 * callproc.c (call_process_cleanup): Now static.
6056 (relocate_fd): Rename locals to avoid shadowing.
6058 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6060 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6061 not to be necessary, and produces flickering.
6063 2011-03-20 Glenn Morris <rgm@gnu.org>
6065 * config.in: Remove file.
6067 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6069 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6070 are now in src/globals.h.
6071 (syms_of_minibuf): Remove spurious & from previous change.
6073 2011-03-20 Leo <sdl.web@gmail.com>
6075 * minibuf.c (completing-read-function): New variable.
6076 (completing-read-default): Rename from completing-read.
6077 (completing-read): Call completing-read-function.
6079 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6081 * xfaces.c (Fx_load_color_file):
6082 Read color file from absolute filename (bug#8250).
6084 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6086 * makefile.w32-in: Update dependencies.
6088 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6090 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6092 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6094 Fix more problems found by GCC 4.5.2's static checks.
6096 * process.c (make_serial_process_unwind, send_process_trap):
6097 (sigchld_handler): Now static.
6099 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6100 That way, the code declares only the vars that it needs.
6101 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6102 * s/cygwin.h (PTY_ITERATION): Likewise.
6103 * s/darwin.h (PTY_ITERATION): Likewise.
6104 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6106 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6107 * process.c (allocate_pty): Don't declare stb unless it's needed.
6109 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6110 (CONSTANTLIM): Remove; unused.
6111 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6112 Define only if needed.
6114 * unexelf.c (unexec): Name an expression,
6115 to avoid gcc -Wbad-function-cast warning.
6116 Use a different way to cause a compilation error if anyone uses
6117 n rather than nn, a way that does not involve shadowing.
6118 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6120 * deps.mk (unexalpha.o): Remove; unused.
6122 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6123 * unexec.h: New file.
6124 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6125 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6127 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6128 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6129 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6130 Change as necessary to match prototype in unexec.h.
6132 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6134 (back_comment, skip_chars): Mark vars as initialized.
6136 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6137 Rename locals to avoid shadowing.
6139 * lread.c (read1): Rewrite so as not to use empty "else".
6140 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6142 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6144 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6145 warning when compiling print.c.
6147 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6148 instead of using an uninitialized var.
6149 (font_sort_entities): Mark var as initialized.
6151 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6153 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6154 pointers to constants.
6155 (font_parse_fcname): Remove unused vars.
6156 (font_delete_unmatched): Now static.
6157 (font_get_spec): Remove; unused.
6158 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6159 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6160 Rename or move locals to avoid shadowing.
6162 * fns.c (require_nesting_list, require_unwind): Now static.
6163 (Ffillarray): Rename locals to avoid shadowing.
6165 * floatfns.c (domain_error2): Define only if needed.
6166 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6168 * alloc.c (mark_backtrace): Move decl from here ...
6169 * lisp.h: ... to here, so that it can be checked.
6171 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6172 (Fdefvar): Rewrite so as not to use empty "else".
6173 (lisp_indirect_variable): Name an expression,
6174 to avoid gcc -Wbad-function-cast warning.
6175 (Fdefvar): Rename locals to avoid shadowing.
6177 * callint.c (quotify_arg, quotify_args): Now static.
6178 (Fcall_interactively): Rename locals to avoid shadowing.
6179 Use const pointer when appropriate.
6181 * lisp.h (get_system_name, get_operating_system_release):
6182 Move decls here, to check interfaces.
6183 * process.c (get_operating_system_release): Move decl to lisp.h.
6184 * xrdb.c (get_system_name): Likewise.
6185 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6186 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6187 some of which prompt warnings from gcc -Wbad-function-cast.
6188 (Fformat_time_string, Fencode_time, Finsert_char):
6189 (Ftranslate_region_internal, Fformat):
6190 Rename or remove local vars to avoid shadowing.
6191 (Ftranslate_region_internal): Mark var as initialized.
6193 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6196 * lisp.h (eassert): Check that the argument compiles, even if
6197 ENABLE_CHECKING is not defined.
6199 * data.c (Findirect_variable): Name an expression, to avoid
6200 gcc -Wbad-function-cast warning.
6201 (default_value, arithcompare, arith_driver, arith_error): Now static.
6202 (store_symval_forwarding): Rename local to avoid shadowing.
6203 (Fmake_variable_buffer_local, Fmake_local_variable):
6204 Mark variables as initialized.
6205 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6207 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6208 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6209 Rename locals to avoid shadowing.
6210 (mark_stack): Move local variables into the #ifdef region where
6212 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6213 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6215 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6216 (GC_STRING_CHARS): Remove; not used.
6217 (Fmemory_limit): Cast sbrk's returned value to char *.
6219 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6220 avoids undefined behavior in theory.
6222 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6224 Use functions, not macros, for up- and down-casing (Bug#8254).
6225 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6226 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6227 to use the following functions instead of these macros.
6228 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6229 EMACS_INT, since callers assume the returned value fits in int.
6230 (upcase1): Likewise, for UPCASE_TABLE.
6231 (uppercasep, lowercasep, upcase): New static inline functions.
6232 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6233 the race-condition problem in the old DOWNCASE.
6235 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6236 Rename locals to avoid shadowing.
6237 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6238 (regex_compile, re_search_2, re_match_2_internal):
6239 Remove unused local vars.
6240 (FREE_VAR): Rewrite so as not to use empty "else",
6241 which gcc can warn about.
6242 (regex_compile, re_match_2_internal): Mark locals as initialized.
6243 (RETALLOC_IF): Define only if needed.
6244 (WORDCHAR_P): Likewise. This one is never needed, but is used
6245 only in a comment talking about a compiler bug, so put inside
6246 the #if 0 of that comment.
6247 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6248 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6251 * search.c (boyer_moore): Rename locals to avoid shadowing.
6252 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6253 (PREV_CHAR_BOUNDARY): Likewise.
6255 * search.c (simple_search): Remove unused var.
6257 * dired.c (compile_pattern): Move decl from here ...
6258 * lisp.h: ... to here, so that it can be checked.
6259 (struct re_registers): New forward decl.
6261 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6263 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6265 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6266 Rename locals to avoid shadowing.
6267 (Fvertical_motion): Mark locals as initialized.
6269 * casefiddle.c (casify_object, casify_region): Now static.
6270 (casify_region): Mark local as initialized.
6272 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6274 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6275 New macros, so that the caller can use some names other than
6276 gcpro1, gcpro2, etc.
6277 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6279 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6280 argument, for consistency with GCPRO2_VAR, etc: it is now the
6281 prefix of the variable, not the variable itself. All uses
6283 * dired.c (directory_files_internal, file_name_completion):
6284 Rename locals to avoid shadowing.
6286 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6287 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6288 dired.c's scmp function, had undefined behavior.
6289 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6290 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6291 * buffer.h: ... to here, because these macros use current_buffer,
6292 and the new implementation with inline functions needs to have
6293 current_buffer in scope now, rather than later when the macros
6295 (downcase, upcase1): New static inline functions.
6296 (DOWNCASE, UPCASE1): Reimplement using these functions.
6297 This avoids undefined behavior in expressions like
6298 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6299 from race conditions in accessing the global variables
6300 case_temp1 and case_temp2.
6301 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6302 * lisp.h (case_temp1, case_temp2): Remove their decls.
6303 * character.h (ASCII_CHAR_P): Move from here ...
6304 * lisp.h: ... to here, so that the inline functions mentioned
6307 * dired.c (directory_files_internal_unwind): Now static.
6309 * fileio.c (file_name_as_directory, directory_file_name):
6310 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6312 (file_name_as_directory): Use const pointers when appropriate.
6313 (Fexpand_file_name): Likewise. In particular, newdir might
6314 point at constant storage, so make it a const pointer.
6315 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6316 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6318 (Fset_file_times, Finsert_file_contents, auto_save_error):
6319 Rename locals to avoid shadowing.
6321 * minibuf.c (choose_minibuf_frame_1): Now static.
6322 (Ftry_completion, Fall_completions): Rename or remove locals
6325 * marker.c (bytepos_to_charpos): Remove; unused.
6327 * lisp.h (verify_bytepos, count_markers): New decls,
6328 so that gcc does not warn that these functions aren't declared.
6330 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6331 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6332 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6333 (copy_text): Remove unused local var.
6335 * filelock.c (within_one_second): Now static.
6336 (lock_file_1): Rename local to avoid shadowing.
6338 * buffer.c (fix_overlays_before): Mark locals as initialized.
6339 (fix_start_end_in_overlays): Likewise. This function should be
6340 simplified by using pointers-to-pointers, but that's a different
6342 (switch_to_buffer_1): Now static.
6343 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6344 (report_overlay_modification): Rename locals to avoid shadowing.
6346 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6347 Fix pointer signedness issue.
6348 (sys_subshell): Mark local as volatile if checking for lint,
6349 to suppress a gcc -Wclobbered warning that does not seem to be right.
6350 (MAXPATHLEN): Define only if needed.
6352 * process.c (serial_open, serial_configure): Move decls from here ...
6353 * systty.h: ... to here, so that they can be checked.
6355 * fns.c (get_random, seed_random): Move extern decls from here ...
6356 * lisp.h: ... to here, so that they can be checked.
6358 * sysdep.c (reset_io): Now static.
6359 (wait_for_termination_signal): Remove; unused.
6361 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6362 (copy_keymap_item, append_key, push_text_char_description):
6364 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6365 (DENSE_TABLE_SIZE): Remove; unused.
6366 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6367 (describe_map_tree):
6368 Rename locals to avoid shadowing.
6370 * keyboard.c: Declare functions static if they are not used elsewhere.
6371 (echo_char, echo_dash, cmd_error, top_level_2):
6372 (poll_for_input, handle_async_input): Now static.
6373 (read_char, kbd_buffer_get_event, make_lispy_position):
6374 (make_lispy_event, make_lispy_movement, apply_modifiers):
6375 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6376 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6377 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6378 (read_key_sequence, read_char): Mark locals as initialized.
6379 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6381 * keyboard.h (make_ctrl_char): New decl.
6382 (mark_kboards): Move decl here ...
6383 * alloc.c (mark_kboards): ... from here.
6385 * lisp.h (force_auto_save_soon): New decl.
6387 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6388 (DEFINE_DUMMY_FUNCTION): New macro.
6389 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6391 (main): Add casts to avoid warnings
6392 if GCC considers string literals to be constants.
6394 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6396 * dbusbind.c: Pointer signedness fixes.
6397 (xd_signature, xd_append_arg, xd_initialize):
6398 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6399 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6400 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6401 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6403 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6404 if GCC considers string literals to be constants.
6405 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6407 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6409 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6410 (print_preprocess, print_object): New macro to fix last change.
6412 * print.c (print_preprocess): Don't forget font objects.
6414 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6416 * emacs.c (USAGE3): Doc fixes.
6418 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6420 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6423 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6425 * lisp.h (VWindow_system, Qfile_name_history):
6426 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6427 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6428 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6430 * w32select.c: Don't #include "keyboard.h".
6431 (run_protected): Add extern declaration for waiting_for_input.
6433 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6434 * w32console.c (detect_input_pending, read_input_pending)
6435 (encode_terminal_code):
6436 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6437 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6438 (w32_system_caret_y, Qfile_name_history):
6439 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6440 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6441 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6442 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6443 * w32proc.c (Qlocal, report_file_error):
6444 * w32term.c (Vwindow_system, updating_frame):
6445 * w32uniscribe.c (initialized, uniscribe_font_driver):
6446 Remove unneeded extern declarations.
6448 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6450 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6452 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6454 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6455 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6456 These macros can no longer be used for assignment.
6458 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6459 Assign struct members directly, instead of using BUF_BEGV etc.
6460 (record_buffer_markers, fetch_buffer_markers): New functions for
6461 recording and fetching special buffer markers.
6462 (set_buffer_internal_1, set_buffer_temp): Use them.
6464 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6466 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6468 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6469 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6471 * xdisp.c (hscroll_window_tree):
6472 (reconsider_clip_changes): Use PT instead of BUF_PT.
6474 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6476 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6477 $(EMACS_ROOT)/lib/intprops.h.
6479 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6481 Fix more problems found by GCC 4.5.2's static checks.
6483 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6484 to unsigned char * to avoid compiler diagnostic.
6485 (xg_free_frame_widgets): Make it clear that a local variable is
6486 needed only if USE_GTK_TOOLTIP.
6487 (gdk_window_get_screen): Make it clear that this macro is needed
6488 only if USE_GTK_TOOLTIP.
6489 (int_gtk_range_get_value): New function, which avoids a diagnostic
6490 from gcc -Wbad-function-cast.
6491 (xg_set_toolkit_scroll_bar_thumb): Use it.
6492 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6493 diagnostic from gcc -Wbad-function-cast.
6494 (get_utf8_string, xg_get_file_with_chooser):
6495 Rename locals to avoid shadowing.
6496 (create_dialog): Move locals to avoid shadowing.
6498 * xgselect.c (xg_select): Remove unused var.
6500 * image.c (four_corners_best): Mark locals as initialized.
6501 (gif_load): Initialize transparent_p to zero (Bug#8238).
6502 Mark another local as initialized.
6503 (my_png_error, my_error_exit): Mark with NO_RETURN.
6505 * image.c (clear_image_cache): Now static.
6506 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6507 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6508 (x_edge_detection): Remove unnecessary cast that
6509 gcc -Wbad-function-cast diagnoses.
6510 (gif_load): Fix pointer signedness.
6511 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6512 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6514 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6516 Improve quality of tests for time stamp overflow.
6517 For example, without this patch (encode-time 0 0 0 1 1
6518 1152921504606846976) returns the obviously-bogus value (-948597
6519 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6520 reports time overflow. See
6521 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6522 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6523 * editfns.c: Include limits.h and intprops.h.
6524 (TIME_T_MIN, TIME_T_MAX): New macros.
6525 (time_overflow): Move earlier, to before first use.
6526 (hi_time, lo_time): New functions, for an accurate test for
6528 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6529 (Fget_internal_run_time): Don't assume time_t fits in int.
6530 (make_time): Use list2 instead of Fcons twice.
6531 (Fdecode_time): More accurate test for out-of-range times.
6532 (check_tm_member): New function.
6533 (Fencode_time): Use it, to test for out-of-range times.
6534 (lisp_time_argument): Don't rely on undefined left-shift and
6535 right-shift behavior when checking for time stamp overflow.
6537 * editfns.c (time_overflow): New function, refactoring common code.
6538 (Fformat_time_string, Fdecode_time, Fencode_time):
6539 (Fcurrent_time_string): Use it.
6541 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6542 * dired.c (make_time): Move to ...
6543 * editfns.c (make_time): ... here.
6544 * systime.h: Note the move.
6546 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6548 * fringe.c (update_window_fringes): Remove unused variables.
6550 * unexmacosx.c (copy_data_segment): Also copy __got section.
6553 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6555 * termcap.c [MSDOS]: Include "msdos.h".
6556 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6557 Constify `char *' arguments and their references according to
6558 prototypes in tparam.h.
6560 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6562 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6563 Adapt all references accordingly.
6565 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6567 2011-03-11 Tom Tromey <tromey@redhat.com>
6569 * buffer.c (syms_of_buffer): Remove obsolete comment.
6571 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6573 * termhooks.h (encode_terminal_code): Declare prototype.
6575 * msdos.c (encode_terminal_code): Don't declare prototype.
6577 * term.c (encode_terminal_code): Now external again, used by
6578 w32console.c and msdos.c.
6580 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6581 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6583 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6585 Fix some minor problems found by GCC 4.5.2's static checks.
6587 * fringe.c (update_window_fringes): Mark locals as initialized
6589 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6591 * alloc.c (mark_fringe_data): Move decl from here ...
6592 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6593 to check its interface.
6594 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6596 * fontset.c (free_realized_fontset): Now static.
6597 (Fset_fontset_font): Rename local to avoid shadowing.
6598 (fontset_font): Mark local as initialized.
6599 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6601 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6603 * xselect.c (x_disown_buffer_selections): Remove; not used.
6604 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6605 (x_own_selection, Fx_disown_selection_internal): Rename locals
6607 (x_handle_dnd_message): Remove local to avoid shadowing.
6609 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6610 so that the caller can use some name other than gcpro1.
6611 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6612 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6613 (Fx_backspace_delete_keys_p):
6614 Use them to avoid shadowing, and rename vars to avoid shadowing.
6615 (x_decode_color, x_set_name, x_window): Now static.
6616 (Fx_create_frame): Add braces to silence GCC warning.
6617 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6618 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6619 Remove unused locals.
6620 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6621 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6622 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6625 * xterm.h (x_mouse_leave): New decl.
6627 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6628 Remove unused functions.
6629 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6630 (x_calc_absolute_position): Now static.
6631 (XTread_socket): Don't define label "out" unless it's used.
6632 Don't declare local "event" unless it's used.
6633 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6634 unless they are used.
6635 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6636 (x_fatal_error_signal): Remove; not used.
6637 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6638 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6639 (x_error_catcher, x_connection_closed, x_error_handler):
6640 (x_error_quitter, xembed_send_message, x_iconify_frame):
6641 (my_log_handler): Rename locals to avoid shadowing.
6642 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6643 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6645 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6646 Rename or move locals to avoid shadowing.
6647 (tty_defined_color, merge_face_heights): Now static.
6648 (free_realized_faces_for_fontset): Remove; not used.
6649 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6650 does not deduce is never used uninitialized.
6651 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6652 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6654 * terminal.c (store_terminal_param): Now static.
6656 * xmenu.c (menu_highlight_callback): Now static.
6657 (set_frame_menubar): Remove unused local.
6658 (xmenu_show): Rename parameter to avoid shadowing.
6659 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6660 since they might point to immutable storage.
6661 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6662 since it's unused otherwise.
6664 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6665 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6666 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6667 avoids a gcc -Wuninitialized diagnostic.
6668 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6669 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6670 does not deduce are never used uninitialized.
6672 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6674 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6675 * window.c (window_loop, size_window):
6676 (run_window_configuration_change_hook, enlarge_window): Likewise.
6678 * window.c (display_buffer): Now static.
6679 (size_window): Mark variables that gcc -Wuninitialized
6680 does not deduce are never used uninitialized.
6681 * window.h (check_all_windows): New decl, to forestall
6682 gcc -Wmissing-prototypes diagnostic.
6683 * dispextern.h (bidi_dump_cached_states): Likewise.
6685 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6687 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6689 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6690 and to avoid gcc -Wuninitialized warning.
6691 (load_charset_map): Mark variables that gcc -Wuninitialized
6692 does not deduce are never used uninitialized.
6693 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6695 * coding.c (coding_set_source, coding_set_destination):
6696 Use "else { /* comment */ }" rather than "else /* comment */;"
6697 for clarity, and to avoid gcc -Wempty-body warning.
6698 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6699 a block, when the outer 'i' will do.
6700 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6701 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6702 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6703 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6704 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6705 Rename locals to avoid shadowing.
6706 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6707 * coding.c (emacs_mule_char, encode_invocation_designation):
6708 Now static, since they're not used elsewhere.
6709 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6710 (decode_coding_object, encode_coding_object, detect_coding_system):
6711 (decode_coding_emacs_mule): Mark variables that gcc
6712 -Wuninitialized does not deduce are never used uninitialized.
6713 (detect_coding_iso_2022): Initialize a local variable that might
6714 be used uninitialized. Leave a FIXME because it's not clear that
6715 this initialization is needed. (Bug#8211)
6716 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6717 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6718 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6719 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6720 Remove unused macros.
6722 * category.c (hash_get_category_set): Remove unused local var.
6723 (copy_category_table): Now static, since it's not used elsewhere.
6724 * character.c (string_count_byte8): Likewise.
6726 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6727 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6729 * chartab.c (copy_sub_char_table): Now static, since it's not used
6731 (sub_char_table_ref_and_range, char_table_ref_and_range):
6732 Rename locals to avoid shadowing.
6733 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6735 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6736 (BIDI_BOB): Remove unused macro.
6738 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6739 deduce are never used uninitialized.
6740 * term.c (encode_terminal_code): Likewise.
6742 * term.c (encode_terminal_code): Now static. Remove unused local.
6744 * tparam.h: New file.
6745 * term.c, tparam.h: Include it.
6746 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6747 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6748 Move these decls to tparam.h, and make them agree with what
6749 is actually in tparam.c. The previous trick of using incompatible
6750 decls in different modules does not conform to the C standard.
6751 All callers of tparam changed to use tparam's actual API.
6752 * tparam.c (tparam1, tparam, tgoto):
6753 Use const pointers where appropriate.
6755 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6756 * cm.h (struct cm): Likewise.
6757 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6758 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6759 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6760 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6761 (turn_on_face, init_tty): Likewise.
6762 * termchar.h (struct tty_display_info): Likewise.
6764 * term.c (term_mouse_position): Rename local to avoid shadowing.
6766 * alloc.c (mark_ttys): Move decl from here ...
6767 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6769 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6771 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6773 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6775 * search.c (compile_pattern_1): Remove argument regp, unused since
6776 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6777 (compile_pattern): Don't pass it.
6779 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6781 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6782 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6784 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6786 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6788 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6789 gdk_window_get_screen, gdk_window_get_geometry,
6790 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6791 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6792 (xg_get_pixbuf_from_pixmap): New function.
6793 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6794 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6795 Call xg_get_pixbuf_from_pixmap instead of
6796 gdk_pixbuf_get_from_drawable.
6797 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6798 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6799 (xg_check_special_colors): Use GtkStyleContext and its functions
6801 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6802 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6803 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6804 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6805 Call gtk_widget_get_preferred_size.
6806 (xg_frame_resized): gdk_window_get_geometry only takes 5
6808 (xg_win_to_widget, xg_event_is_for_menubar):
6809 Call gdk_x11_window_lookup_for_display.
6810 (xg_set_widget_bg): New function.
6811 (delete_cb): New function.
6812 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6813 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6814 (xg_set_background_color): Call xg_set_widget_bg.
6815 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6816 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6817 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6818 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6820 (update_frame_tool_bar): Call gtk_widget_hide.
6821 (xg_initialize): Use GDK_KEY_g.
6823 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6825 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6827 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6828 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6829 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6831 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6833 * w32xfns.c (select_palette): Check success of RealizePalette against
6834 GDI_ERROR, not zero.
6836 See ChangeLog.11 for earlier changes.
6842 Copyright (C) 2011 Free Software Foundation, Inc.
6844 This file is part of GNU Emacs.
6846 GNU Emacs is free software: you can redistribute it and/or modify
6847 it under the terms of the GNU General Public License as published by
6848 the Free Software Foundation, either version 3 of the License, or
6849 (at your option) any later version.
6851 GNU Emacs is distributed in the hope that it will be useful,
6852 but WITHOUT ANY WARRANTY; without even the implied warranty of
6853 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6854 GNU General Public License for more details.
6856 You should have received a copy of the GNU General Public License
6857 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.