* xfns.c (Fx_window_property): Simplify a bit,
[bpt/emacs.git] / src / ChangeLog
1 2011-04-19 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xfns.c (Fx_window_property): Simplify a bit,
4 to make a bit faster and to avoid GCC 4.6.0 warning.
5 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6
7 * fns.c (internal_equal): Don't assume size_t fits in int.
8
9 * alloc.c (compact_small_strings): Tighten assertion a little.
10
11 Replace pEd with more-general pI, and fix some printf arg casts.
12 * lisp.h (pI): New macro, generalizing old pEd macro to other
13 conversion specifiers. For example, use "...%"pI"d..." rather
14 than "...%"pEd"...".
15 (pEd): Remove. All uses replaced with similar uses of pI.
16 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
17 * alloc.c (check_pure_size): Don't overflow by converting size to int.
18 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
19 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
20 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
21 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
22 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
23 64-bit hosts.
24 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
25 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
26 * print.c (safe_debug_print, print_object): Likewise.
27 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
28 to int.
29 Use pI instead of if-then-else-abort. Use %p to avoid casts.
30 * process.c (Fmake_network_process): Use pI to avoid cast.
31 * region-cache.c (pp_cache): Likewise.
32 * xdisp.c (decode_mode_spec): Likewise.
33 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
34 behavior on 64-bit hosts with printf arg.
35 * xselect.c (x_queue_event): Use %p to avoid casts.
36 (x_stop_queuing_selection_requests): Likewise.
37 (x_get_window_property): Don't truncate byte count to an 'int'
38 when tracing.
39
40 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
41 here, since it parses constructs like leading '-' and spaces,
42 which are not wanted; and it overflows with large numbers.
43 Instead, simply match F[0-9]+, which is what is wanted anyway.
44
45 * alloc.c: Remove unportable assumptions about struct layout.
46 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
47 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
48 (allocate_vectorlike, make_pure_vector): Use the new macros,
49 plus offsetof, to remove unportable assumptions about struct layout.
50 These assumptions hold on all porting targets that I know of, but
51 they are not guaranteed, they're easy to remove, and removing them
52 makes further changes easier.
53
54 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
55 This doesn't fix a bug but makes the code clearer.
56 (string_overrun_cookie): Now const. Use initializers that
57 don't formally overflow signed char, to avoid warnings.
58 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
59 can cause Emacs to crash when string overrun checking is enabled.
60 (allocate_buffer): Don't assume sizeof (struct buffer) is a
61 multiple of sizeof (EMACS_INT); it need not be, if
62 alignof(EMACS_INT) < sizeof (EMACS_INT).
63 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
64
65 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
66
67 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
68
69 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
70
71 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
72 definition for no-X builds.
73
74 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
75
76 Static checks with GCC 4.6.0 and non-default toolkits.
77
78 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
79
80 * process.c (keyboard_bit_set): Define only if SIGIO.
81 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
82 (send_process): Repair possible setjmp clobbering.
83
84 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
85
86 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
87
88 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
89
90 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
91 Define only if needed.
92
93 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
94 by pacifying GCC about it. Maybe it's time to retire it?
95 * xfaces.c (USG, __TIMEVAL__): Likewise.
96
97 * dispextern.h (struct redisplay_interface): Rename param
98 to avoid shadowing.
99 * termhooks.h (struct terminal): Likewise.
100 * xterm.c (xembed_send_message): Likewise.
101
102 * insdel.c (make_gap_smaller): Define only if
103 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
104
105 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
106 it.
107
108 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
109 so that we aren't warned about unused symbols.
110
111 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
112
113 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
114
115 * xfns.c (x_real_positions): Mark locals as initialized.
116
117 * xmenu.c (xmenu_show): Don't use uninitialized vars.
118
119 * xterm.c: Fix problems found by static analysis with other toolkits.
120 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
121 (x_dispatch_event): Declare static if USE_GTK, and
122 define if USE_GTK || USE_X_TOOLKIT.
123 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
124 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
125 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
126 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
127
128 * xmenu.c (menu_help_callback): Pointer type fixes.
129 Use const pointers when pointing at readonly data. Avoid pointer
130 signedness clashes.
131 (FALSE): Remove unused macro.
132 (update_frame_menubar): Remove unused decl.
133
134 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
135
136 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
137 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
138 (single_menu_item): Rename local to avoid shadowing.
139
140 * keyboard.c (make_lispy_event): Remove unused local var.
141
142 * frame.c, frame.h (x_get_resource_string): Bring this back, but
143 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
144
145 * bitmaps: Change bitmaps from unsigned char back to the X11
146 compatible char. Avoid the old compiler warnings about
147 out-of-range initializers by using, for example, '\xab' rather
148 than 0xab.
149
150 * xgselect.c (xgselect_initialize): Check vs interface
151 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
152
153 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
154
155 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
156 to read-only memory.
157
158 * fns.c (vector): Remove; this old hack is no longer needed.
159
160 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
161 Remove unused var.
162 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
163
164 * xrdb.c (x_load_resources): Omit unused local.
165
166 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
167 (x_window): Rename locals to avoid shadowing.
168 (USG): Use the kludged USG macro, to pacify gcc.
169
170 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
171 (x_term_init): Remove local to avoid shadowing.
172
173 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
174
175 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
176 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
177
178 2011-04-16 Eli Zaretskii <eliz@gnu.org>
179
180 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
181
182 Fix regex.c, syntax.c and friends for buffers > 2GB.
183 * syntax.h (struct gl_state_s): Declare character position members
184 EMACS_INT.
185
186 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
187
188 * textprop.c (verify_interval_modification, interval_of): Declare
189 arguments EMACS_INT.
190
191 * intervals.c (adjust_intervals_for_insertion): Declare arguments
192 EMACS_INT.
193
194 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
195
196 * indent.c (Fvertical_motion): Local variable it_start is now
197 EMACS_INT.
198
199 * regex.c (re_match, re_match_2, re_match_2_internal)
200 (bcmp_translate, regcomp, regexec, print_double_string)
201 (group_in_compile_stack, re_search, re_search_2, regex_compile)
202 (re_compile_pattern, re_exec): Declare arguments and local
203 variables `size_t' and `ssize_t' and return values `regoff_t', as
204 appropriate.
205 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
206 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
207 <compile_stack_type>: `size' and `avail' are now `size_t'.
208
209 * regex.h <regoff_t>: Use ssize_t, not int.
210 (re_search, re_search_2, re_match, re_match_2): Arguments that
211 specify buffer/string position and length are now ssize_t and
212 size_t. Return type is regoff_t.
213
214 2011-04-16 Ben Key <bkey76@gmail.com>
215
216 * nsfont.m: Fixed bugs in ns_get_family and
217 ns_descriptor_to_entity that were caused by using free to
218 deallocate memory blocks that were allocated by xmalloc (via
219 xstrdup). This caused Emacs to crash when compiled with
220 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
221 --enable-checking=xmallocoverrun). xfree is now used to
222 deallocate these memory blocks.
223
224 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
225
226 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
227
228 emacs_write: Accept and return EMACS_INT for sizes.
229 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
230 et seq.
231 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
232 Accept and return EMACS_INT.
233 (emacs_gnutls_write): Return the number of bytes written on
234 partial writes.
235 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
236 (emacs_read, emacs_write): Remove check for negative size, as the
237 Emacs source code has been audited now.
238 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
239 (emacs_read, emacs_write): Use it.
240 * process.c (send_process): Adjust to the new signatures of
241 emacs_write and emacs_gnutls_write. Do not attempt to store
242 a byte offset into an 'int'; it might overflow.
243 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
244
245 * sound.c: Don't assume sizes fit in 'int'.
246 (struct sound_device.period_size, alsa_period_size):
247 Return EMACS_INT, not int.
248 (struct sound_device.write, vox_write, alsa_write):
249 Accept EMACS_INT, not int.
250 (wav_play, au_play): Use EMACS_INT to store sizes and to
251 record read return values.
252
253 2011-04-15 Ben Key <bkey76@gmail.com>
254
255 * keyboard.c (Qundefined): Don't declare static since it is used
256 in nsfns.m.
257 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
258 static since they are used in nsfont.m.
259
260 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
261
262 * process.c (Qprocessp): Don't declare static.
263 * lisp.h (Qprocessp): Declare again.
264
265 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
266
267 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
268
269 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
270
271 Improve C-level modularity by making more things 'static'.
272
273 Don't publish debugger-only interfaces to other modules.
274 * lisp.h (safe_debug_print, debug_output_compilation_hack):
275 (verify_bytepos, count_markers): Move decls to the only modules
276 that need them.
277 * region-cache.h (pp_cache): Likewise.
278 * window.h (check_all_windows): Likewise.
279 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
280
281 * sysdep.c (croak): Now static, if
282 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
283 * syssignal.h (croak): Declare only if not static.
284
285 * alloc.c (refill_memory_reserve): Now static if
286 !defined REL_ALLOC || defined SYSTEM_MALLOC.
287 * lisp.h (refill_memory_reserve): Declare only if not static.
288
289 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
290 Define only if USE_LUCID.
291
292 * xrdb.c (x_customization_string, x_rm_string): Now static.
293
294 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
295 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
296
297 * xdisp.c (draw_row_with_mouse_face): Now static.
298 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
299
300 * window.h (check_all_windows): Mark externally visible.
301
302 * window.c (window_deletion_count): Now static.
303
304 * undo.c: Make symbols static if they're not exported.
305 (last_undo_buffer, last_boundary_position, pending_boundary):
306 Now static.
307
308 * textprop.c (interval_insert_behind_hooks): Now static.
309 (interval_insert_in_front_hooks): Likewise.
310
311 * term.c: Make symbols static if they're not exported.
312 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
313 (max_frame_lines, tty_set_terminal_modes):
314 (tty_reset_terminal_modes, tty_turn_off_highlight):
315 (get_tty_terminal): Now static.
316 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
317 * termhooks.h (term_mouse_moveto): Do not declare if
318 HAVE_WINDOW_SYSTEM.
319 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
320 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
321
322 * sysdep.c: Make symbols static if they're not exported.
323 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
324 Now static.
325 (sigprocmask_set, full_mask): Remove; unused.
326 (wait_debugging): Mark as visible.
327 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
328 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
329
330 * syntax.c (syntax_temp): Define only if !__GNUC__.
331
332 * sound.c (current_sound_device, current_sound): Now static.
333
334 * search.c (searchbufs, searchbuf_head): Now static.
335
336 * scroll.c (scroll_cost): Remove; unused.
337 * dispextern.h (scroll_cost): Remove decl.
338
339 * region-cache.h (pp_cache): Mark as externally visible.
340
341 * process.c: Make symbols static if they're not exported.
342 (process_tick, update_tick, create_process, chan_process):
343 (Vprocess_alist, proc_buffered_char, datagram_access):
344 (fd_callback_data, send_process_frame, process_sent_to): Now static.
345 (deactivate_process): Mark defn as static, as well as decl.
346 * lisp.h (create_process): Remove decl.
347 * process.h (chan_process, Vprocess_alist): Remove decls.
348
349 * print.c: Make symbols static if they're not exported.
350 (print_depth, new_backquote_output, being_printed, print_buffer):
351 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
352 (print_interval, print_number_index, initial_stderr_stream):
353 Now static.
354 * lisp.h (Fprinc): Remove decl.
355 (debug_output_compilation_hack): Mark as externally visible.
356
357 * sysdep.c (croak): Move decl from here to syssignal.h.
358 * syssignal.h (croak): Put it here, so the API can be checked when
359 'croak' is called from dissociate_if_controlling_tty.
360
361 * minibuf.c: Make symbols static if they're not exported.
362 (minibuf_save_list, choose_minibuf_frame): Now static.
363 * lisp.h (choose_minibuf_frame): Remove decl.
364
365 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
366
367 * lread.c: Make symbols static if they're not exported.
368 (read_objects, initial_obarray, oblookup_last_bucket_number):
369 Now static.
370 (make_symbol): Remove; unused.
371 * lisp.h (initial_obarray, make_symbol): Remove decls.
372
373 * keyboard.c: Make symbols static if they're not exported.
374 (single_kboard, recent_keys_index, total_keys, recent_keys):
375 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
376 (this_single_command_key_start, echoing, last_auto_save):
377 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
378 (command_loop, echo_now, keyboard_init_hook, help_char_p):
379 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
380 (Vlispy_mouse_stem, double_click_count):
381 Now static.
382 (force_auto_save_soon): Define only if SIGDANGER.
383 (ignore_mouse_drag_p): Now static if
384 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
385 (print_help): Remove; unused.
386 (stop_character, last_timer_event): Mark as externally visible.
387 * keyboard.h (ignore_mouse_drag_p): Declare only if
388 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
389 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
390 * lisp.h (echoing): Remove decl.
391 (force_auto_save_soon): Declare only if SIGDANGER.
392 * xdisp.c (redisplay_window): Simplify code, to make it more
393 obvious that ignore_mouse_drag_p is not accessed if !defined
394 USE_GTK && !defined HAVE_NS.
395
396 * intervals.c: Make symbols static if they're not exported.
397 (merge_properties_sticky, merge_interval_right, delete_interval):
398 Now static.
399 * intervals.h (merge_interval_right, delete_interval): Remove decls.
400
401 * insdel.c: Make symbols static if they're not exported.
402 However, leave prepare_to_modify_buffer alone. It's never
403 called from outside this function, but that appears to be a bug.
404 (combine_after_change_list, combine_after_change_buffer):
405 (adjust_after_replace, signal_before_change): Now static.
406 (adjust_after_replace_noundo): Remove; unused.
407 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
408 (signal_before_change): Remove decls.
409
410 * indent.c (val_compute_motion, val_vmotion): Now static.
411
412 * image.c: Make symbols static if they're not exported.
413 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
414 if USE_GTK.
415 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
416 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
417
418 * fringe.c (standard_bitmaps): Now static.
419 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
420
421 * frame.c: Make symbols static if they're not exported.
422 (x_report_frame_params, make_terminal_frame): Now static.
423 (get_frame_param): Now static, unless HAVE_NS.
424 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
425 (x_get_resource_string): Remove; not used.
426 * frame.h (make_terminal_frame, x_report_frame_params):
427 (x_get_resource_string); Remove decls.
428 (x_fullscreen_adjust): Declare only if WINDOWSNT.
429 * lisp.h (get_frame_param): Declare only if HAVE_NS.
430
431 * font.c, fontset.c: Make symbols static if they're not exported.
432 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
433 (FACE_SUITABLE_FOR_CHAR_P): Use it.
434 * font.c (font_close_object): Now static.
435 * font.h (font_close_object): Remove.
436 * fontset.c (FONTSET_OBJLIST): Remove.
437 (free_realized_fontset) #if-0 the body, which does nothing.
438 (face_suitable_for_char_p): #if-0, as it's never called.
439 * fontset.h (face_suitable_for_char_p): Remove decl.
440 * xfaces.c (face_at_string_position): Use
441 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
442 since 0 is always ASCII.
443
444 * fns.c (weak_hash_tables): Now static.
445
446 * fileio.c: Make symbols static if they're not exported.
447 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
448 (Vwrite_region_annotation_buffers): Now static.
449
450 * eval.c: Make symbols static if they're not exported.
451 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
452 * lisp.h (backtrace_list): Remove decl.
453
454 * emacs.c: Make symbols static if they're not exported.
455 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
456 (fatal_error_code, fatal_error_signal_hook, standard_args):
457 Now static.
458 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
459 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
460 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
461 * lisp.h (fatal_error_signal_hook): Remove decl.
462 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
463
464 * editfns.c: Move a (normally-unused) function to its only use.
465 * editfns.c, lisp.h (get_operating_system_release): Remove.
466 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
467 worth the hassle of breaking this out.
468
469 * xterm.c: Make symbols static if they're not exported.
470 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
471 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
472 (x_destroy_window, x_delete_display):
473 Now static.
474 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
475 (x_mouse_leave): Remove; unused.
476 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
477 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
478 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
479 Remove decls.
480 (x_mouse_leave): Declare only if WINDOWSNT.
481 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
482 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
483 USE_X_TOOLKIT.
484
485 * ftxfont.c: Make symbols static if they're not exported.
486 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
487 HAVE_FREETYPE.
488 * font.h (ftxfont_driver): Likewise.
489
490 * xfns.c: Make symbols static if they're not exported.
491 (x_last_font_name, x_display_info_for_name):
492 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
493 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
494 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
495 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
496 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
497 (last_show_tip_args): Now static.
498 (xic_defaut_fontset, xic_create_fontsetname): Define only if
499 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
500 (x_screen_planes): Remove; unused.
501 * dispextern.h (x_screen_planes): Remove decl.
502
503 * dispnew.c: Make symbols static if they're not exported.
504 * dispextern.h (redraw_garbaged_frames, scrolling):
505 (increment_row_positions): Remove.
506 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
507 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
508 Now static.
509 (redraw_garbaged_frames): Remove; unused.
510
511 * xfaces.c: Make symbols static if they're not exported.
512 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
513 Remove decls.
514 * xterm.h (defined_color): Remove decls.
515 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
516 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
517 (menu_face_changed_default, defined_color, free_realized_face):
518 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
519 (ascii_face_of_lisp_face): Remove; unused.
520
521 * xdisp.c: Make symbols static if they're not exported.
522 * dispextern.h (scratch_glyph_row, window_box_edges):
523 (glyph_to_pixel_coords, set_cursor_from_row):
524 (get_next_display_element, set_iterator_to_next):
525 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
526 (show_mouse_face): Remove decls
527 * frame.h (message_buf_print): Likewise.
528 * lisp.h (pop_message, set_message, check_point_in_composition):
529 Likewise.
530 * xterm.h (set_vertical_scroll_bar): Likewise.
531 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
532 (message_buf_print, scratch_glyph_row, displayed_buffer):
533 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
534 (get_next_display_element, show_mouse_face, window_box_edges):
535 (frame_to_window_pixel_xy, check_point_in_composition):
536 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
537 (glyph_to_pixel_coords): Remove; unused.
538
539 * dired.c (file_name_completion): Now static.
540
541 * dbusbind.c (xd_in_read_queued_messages): Now static.
542
543 * lisp.h (circular_list_error, FOREACH): Remove; unused.
544 * data.c (circular_list_error): Remove.
545
546 * commands.h (last_point_position, last_point_position_buffer):
547 (last_point_position_window): Remove decls.
548 * keyboard.c: Make these variables static.
549
550 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
551 decls.
552 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
553 (iso_code_class, detect_coding, code_convert_region): Now static.
554 (encode_coding_gap): Remove; unused.
555
556 * chartab.c (chartab_chars, chartab_bits): Now static.
557
558 * charset.h (charset_iso_8859_1): Remove decl.
559 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
560 Now static.
561
562 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
563 * ccl.c (Vccl_program_table): Now static.
564 (check_ccl_update): Remove; unused.
565
566 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
567 * category.h: ... from here.
568 * category.c (check_category_table, set_category_set): Now static.
569
570 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
571 * lisp.h: Remove these decls.
572
573 * buffer.c (buffer_count): Remove unused var.
574
575 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
576 so that it's not optimized away.
577 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
578 * dispextern.h (bidi_dump_cached_states): Remove, since it's
579 exported only to the debugger.
580
581 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
582 * atimer.h (run_all_atimers): Removed; not exported.
583
584 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
585 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
586 was inaccessible from Lisp.
587 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
588 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
589
590 alloc.c: Import and export fewer symbols, and remove unused items.
591 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
592 is defined.
593 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
594 it's not optimized away by whole-program optimization.
595 (message_enable_multibyte, free_misc): Remove.
596 (catchlist, handlerlist, mark_backtrace):
597 Declare only if BYTE_MARK_STACK.
598 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
599 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
600 (message_enable_multibyte): Remove decl.
601 (free_misc, interval_free_list, float_block, float_block_index):
602 (n_float_blocks, float_free_list, cons_block, cons_block_index):
603 (cons_free_list, last_marked_index):
604 Now static.
605 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
606 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
607 (mark_backtrace): Define only if BYTE_MARK_STACK.
608 * xdisp.c (message_enable_multibyte): Now static.
609
610 Declare Lisp_Object Q* variables to be 'static' if not exported.
611 This makes it easier for human readers (and static analyzers)
612 to see whether these variables are used from other modules.
613 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
614 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
615 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
616 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
617 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
618 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
619 * xmenu.c, xselect.c:
620 Declare Q* vars static if they are not used in other modules.
621 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
622 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
623 Remove decls of unexported vars.
624 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
625
626 * lisp.h (DEFINE_FUNC): Make sname 'static'.
627
628 Make Emacs functions such as Fatom 'static' by default.
629 This makes it easier for human readers (and static analyzers)
630 to see whether these functions can be called from other modules.
631 DEFUN now defines a static function. To make the function external
632 so that it can be used in other C modules, use the new macro DEFUE.
633 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
634 (Finit_image_library):
635 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
636 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
637 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
638 Remove decls, since these functions are now static.
639 (Funintern, Fget_internal_run_time): New decls, since these functions
640 were already external.
641
642 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
643 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
644 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
645 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
646 * keyboard.c, keymap.c, lread.c:
647 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
648 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
649 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
650 Mark functions with DEFUE instead of DEFUN,
651 if they are used in other modules.
652 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
653 decls for now-static functions.
654 * buffer.h (Fdelete_overlay): Remove decl.
655 * callproc.c (Fgetenv_internal): Mark as internal.
656 * composite.c (Fremove_list_of_text_properties): Remove decl.
657 (Fcomposition_get_gstring): New forward static decl.
658 * composite.h (Fcomposite_get_gstring): Remove decl.
659 * dired.c (Ffile_attributes): New forward static decl.
660 * doc.c (Fdocumntation_property): New forward static decl.
661 * eval.c (Ffetch_bytecode): New forward static decl.
662 (Funintern): Remove extern decl; now in .h file where it belongs.
663 * fileio.c (Fmake_symbolic_link): New forward static decl.
664 * image.c (Finit_image_library): New forward static decl.
665 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
666 * intervals.h (Fprevious_property_change):
667 (Fremove_list_of_text_properties): Remove decls.
668 * keyboard.c (Fthis_command_keys): Remove decl.
669 (Fcommand_execute): New forward static decl.
670 * keymap.c (Flookup_key): New forward static decl.
671 (Fcopy_keymap): Now static.
672 * keymap.h (Flookup_key): Remove decl.
673 * process.c (Fget_process): New forward static decl.
674 (Fprocess_datagram_address): Mark as internal.
675 * syntax.c (Fsyntax_table_p): New forward static decl.
676 (skip_chars): Remove duplicate decl.
677 * textprop.c (Fprevious_property_change): New forward static decl.
678 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
679 Now internal.
680 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
681 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
682
683 * editfns.c (Fformat): Remove unreachable code.
684
685 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
686
687 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
688 change. (Bug#8496)
689
690 2011-04-13 Eli Zaretskii <eliz@gnu.org>
691
692 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
693 when at ZV. (Bug#8487)
694
695 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
696
697 * charset.c (Fclear_charset_maps): Use xfree instead of free.
698 (Bug#8437)
699 * keyboard.c (parse_tool_bar_item): Likewise.
700 * sound.c (sound_cleanup, alsa_close): Likewise.
701 * termcap.c (tgetent): Likewise.
702 * xfns.c (x_default_font_parameter): Likewise.
703 * xsettings.c (read_and_apply_settings): Likewise.
704
705 * alloc.c (overrun_check_malloc, overrun_check_realloc)
706 (overrun_check_free): Protoize.
707
708 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
709
710 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
711 since callers should never pass a negative size.
712 Change the signature to match that of plain 'read' and 'write'; see
713 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
714 * lisp.h: Update prototypes of emacs_write and emacs_read.
715
716 2011-04-11 Eli Zaretskii <eliz@gnu.org>
717
718 * xdisp.c (redisplay_window): Don't try to determine the character
719 position of the scroll margin if the window start point w->startp
720 is outside the buffer's accessible region. (Bug#8468)
721
722 2011-04-10 Eli Zaretskii <eliz@gnu.org>
723
724 Fix write-region and its subroutines for buffers > 2GB.
725 * fileio.c (a_write, e_write): Modify declaration of arguments and
726 local variables to support buffers larger than 2GB.
727 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
728
729 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
730 argument, local variables, and return value.
731
732 * lisp.h: Update prototypes of emacs_write and emacs_read.
733
734 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
735
736 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
737
738 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
739
740 Fix more problems found by GCC 4.6.0's static checks.
741
742 * xdisp.c (vmessage): Use a better test for character truncation.
743
744 * charset.c (load_charset_map): <, not <=, for optimization,
745 and to avoid potential problems with integer overflow.
746 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
747 * casetab.c (set_identity, shuffle): Likewise.
748 * editfns.c (Fformat): Likewise.
749 * syntax.c (skip_chars): Likewise.
750
751 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
752 This also lets GCC 4.6.0 generate slightly better loop code.
753
754 * callint.c (Fcall_interactively): <, not <=, for optimization.
755 (Fcall_interactively): Count the number of arguments produced,
756 not the number of arguments given. This is simpler and lets GCC
757 4.6.0 generate slightly better code.
758
759 * ftfont.c: Distingish more carefully between FcChar8 and char.
760 The previous code passed unsigned char * to a functions like
761 strlen and xstrcasecmp that expect char *, which does not
762 conform to the C standard.
763 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
764 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
765 char * when the C standard requires it.
766
767 * keyboard.c (read_char): Remove unused var.
768
769 * eval.c: Port to Windows vsnprintf (Bug#8435).
770 Include <limits.h>.
771 (SIZE_MAX): Define if the headers do not.
772 (verror): Do not give up if vsnprintf returns a negative count.
773 Instead, grow the buffer. This ports to Windows vsnprintf, which
774 does not conform to C99. Problem reported by Eli Zaretskii.
775 Also, simplify the allocation scheme, by avoiding the need for
776 calling realloc, and removing the ALLOCATED variable.
777
778 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
779
780 Remove invocations of doprnt, as Emacs now uses vsnprintf.
781 But keep the doprint source code for now, as we might revamp it
782 and use it again (Bug#8435).
783 * lisp.h (doprnt): Remove.
784 * Makefile.in (base_obj): Remove doprnt.o.
785 * deps.mk (doprnt.o): Remove.
786
787 error: Print 32- and 64-bit integers portably (Bug#8435).
788 Without this change, on typical 64-bit hosts error ("...%d...", N)
789 was used to print both 32- and 64-bit integers N, which relied on
790 undefined behavior.
791 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
792 New macro.
793 * lisp.h (error, verror): Mark as printf-like functions.
794 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
795 Report overflow in size calculations when allocating printf buffer.
796 Do not truncate output string at its first null byte.
797 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
798 Truncate the output at a character boundary, since vsnprintf does not
799 do that.
800 * charset.c (check_iso_charset_parameter): Convert internal
801 character to string before calling 'error', since %c now has the
802 printf meaning.
803 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
804 overflow when computing char to be passed to 'error'. Do not
805 pass Lisp_Object to 'error'; pass the integer instead.
806 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
807 formatted with plain %d.
808
809 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
810
811 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
812
813 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
814
815 * xterm.c (x_catch_errors): Remove duplicate declaration.
816
817 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
818
819 * xdisp.c, lisp.h (message_nolog): Remove; unused.
820
821 2011-04-10 Jim Meyering <meyering@redhat.com>
822
823 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
824 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
825 return ssize_t not "int", and use size_t as the buffer length.
826 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
827 * gnutls.h: Update declarations.
828 * process.c (read_process_output): Use ssize_t, to match.
829 (send_process): Likewise.
830
831 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
832
833 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
834
835 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
836
837 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
838 unsigned char, to match FcChar8 type definition.
839
840 * xterm.c (handle_one_xevent):
841 * xmenu.c (create_and_show_popup_menu):
842 * xselect.c (x_decline_selection_request)
843 (x_reply_selection_request): Avoid type-punned deref of X events.
844
845 2011-04-09 Eli Zaretskii <eliz@gnu.org>
846
847 Fix some uses of `int' instead of EMACS_INT.
848 * search.c (string_match_1, fast_string_match)
849 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
850 (scan_buffer, find_next_newline_no_quit)
851 (find_before_next_newline, search_command, Freplace_match)
852 (Fmatch_data): Make some `int' variables be EMACS_INT.
853
854 * xdisp.c (display_count_lines): 3rd argument and return value now
855 EMACS_INT. All callers changed.
856 (pint2hrstr): Last argument is now EMACS_INT.
857
858 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
859 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
860 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
861 (decode_coding_utf_16, decode_coding_emacs_mule)
862 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
863 (decode_coding_ccl, decode_coding_charset)
864 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
865 (decode_coding_iso_2022, decode_coding_emacs_mule)
866 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
867 <char_offset, last_offset>: Declare EMACS_INT.
868 (encode_coding_utf_8, encode_coding_utf_16)
869 (encode_coding_emacs_mule, encode_invocation_designation)
870 (encode_designation_at_bol, encode_coding_iso_2022)
871 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
872 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
873 Declare EMACS_INT.
874 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
875 (encode_invocation_designation): Last argument P_NCHARS is now
876 EMACS_INT.
877 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
878 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
879
880 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
881 All users changed.
882
883 * ccl.c (Fccl_execute_on_string): Declare some variables
884 EMACS_INT.
885
886 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
887
888 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
889
890 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
891
892 * process.c (Fformat_network_address): Doc fix.
893
894 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
895
896 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
897
898 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
899
900 * keyboard.c (read_char): Call Lisp function help-form-show,
901 instead of using internal_with_output_to_temp_buffer.
902 (Qhelp_form_show): New var.
903 (syms_of_keyboard): Use DEFSYM macro.
904
905 * print.c (internal_with_output_to_temp_buffer): Function deleted.
906
907 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
908
909 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
910
911 * process.c (Flist_processes): Removed to Lisp.
912 (list_processes_1): Deleted.
913
914 2011-04-06 Eli Zaretskii <eliz@gnu.org>
915
916 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
917
918 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
919
920 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
921
922 Fix more problems found by GCC 4.6.0's static checks.
923
924 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
925
926 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
927
928 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
929
930 * xdisp.c (vmessage): Mark as a printf-like function.
931
932 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
933
934 * sound.c (sound_warning): Don't crash if arg contains a printf format.
935
936 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
937 printf-like functions.
938 (tiff_load): Add casts to remove these marks before passing them
939 to system-supplied API.
940
941 * eval.c (Fsignal): Remove excess argument to 'fatal'.
942
943 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
944 This avoids several warnings with gcc -Wstrict-overflow.
945 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
946 directly, rather than having caller test rule sign. This avoids
947 some unnecessary tests.
948 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
949 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
950 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
951
952 * xfont.c (xfont_text_extents): Remove var that was set but not used.
953 (xfont_open): Avoid unnecessary tests.
954
955 * composite.c (composition_gstring_put_cache): Use unsigned integer.
956
957 * composite.h, composite.c (composition_gstring_put_cache):
958 Use EMACS_INT, not int, for length.
959
960 * composite.h (COMPOSITION_DECODE_REFS): New macro,
961 breaking out part of COMPOSITION_DECODE_RULE.
962 (COMPOSITION_DECODE_RULE): Use it.
963 * composite.c (get_composition_id): Remove unused local vars,
964 by using the new macro.
965
966 * textprop.c (set_text_properties_1): Change while to do-while,
967 since the condition is always true at first.
968
969 * intervals.c (graft_intervals_into_buffer): Mark var as used.
970 (interval_deletion_adjustment): Return unsigned value.
971 All uses changed.
972
973 * process.c (list_processes_1, create_pty, read_process_output):
974 (exec_sentinel): Remove vars that were set but not used.
975 (create_pty): Remove unnecessary "volatile"s.
976 (Fnetwork_interface_info): Avoid possibility of int overflow.
977 (read_process_output): Do adaptive read buffering even if carryover.
978 (read_process_output): Simplify nbytes computation if buffered.
979
980 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
981
982 * syntax.c (scan_words): Remove var that was set but not used.
983 (update_syntax_table): Use unsigned instead of int.
984
985 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
986 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
987 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
988
989 * print.c (print_error_message): Avoid int overflow.
990
991 * font.c (font_list_entities): Redo for clarity,
992 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
993
994 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
995 (font_score): Avoid potential overflow in diff calculation.
996
997 * fns.c (substring_both): Remove var that is set but not used.
998 (sxhash): Redo loop for clarity and to avoid wraparound warning.
999
1000 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1001
1002 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1003 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1004 can always succeed if overflow has undefined behavior.
1005
1006 * search.c (boyer_moore, wordify): Remove vars set but not used.
1007 (wordify): Omit three unnecessary tests.
1008
1009 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1010 All callers changed. This avoids the need for an unused var.
1011
1012 * casefiddle.c (casify_region): Remove var that is set but not used.
1013
1014 * dired.c (file_name_completion): Remove var that is set but not used.
1015
1016 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1017
1018 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1019 (Finsert_file_contents): Remove unnecessary code checking fd.
1020
1021 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1022 Check for integer overflow on size calculations.
1023
1024 * buffer.c (Fprevious_overlay_change): Remove var that is set
1025 but not used.
1026
1027 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1028 Remove vars that are set but not used.
1029 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1030 (timer_check_2): Mark vars as initialized.
1031
1032 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1033
1034 * image.c (lookup_image): Remove var that is set but not used.
1035 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1036
1037 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1038 that are set but not used.
1039
1040 * xfns.c (make_invisible_cursor): Don't return garbage
1041 if XCreateBitmapFromData fails (Bug#8410).
1042
1043 * xselect.c (x_get_local_selection, x_handle_property_notify):
1044 Remove vars that are set but not used.
1045
1046 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1047 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1048
1049 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1050 Remove var that is set but not used.
1051 (scroll_bar_windows_size): Now size_t, not int.
1052 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1053 Check for overflow.
1054
1055 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1056 (map_tty_color) [!defined MSDOS]: Likewise.
1057
1058 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1059
1060 * coding.c: Remove vars that are set but not used.
1061 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1062 All callers changed.
1063 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1064 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1065 (decode_coding_charset): Remove vars that are set but not used.
1066
1067 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1068 that is set but not used.
1069
1070 * print.c (print_object): Remove var that is set but not used.
1071
1072 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1073 The gnulib version avoids calling malloc in the usual case,
1074 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1075 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1076 * filelock.c (current_lock_owner): Likewise.
1077 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1078 * sysdep.c: Include allocator.h, careadlinkat.h.
1079 (emacs_no_realloc_allocator): New static constant.
1080 (emacs_readlink): New function.
1081 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1082 ../lib/careadlinkat.h.
1083
1084 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1085
1086 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1087 first non-nil return value).
1088
1089 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1090
1091 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1092 if not defined (Bug#8403).
1093
1094 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1095
1096 * xdisp.c (display_count_lines): Remove parameter `start',
1097 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1098 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1099 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1100 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1101 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1102 and thereabouts. All callers changed.
1103 (get_per_char_metric): Remove parameter `f', unused since
1104 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1105
1106 2011-04-02 Jim Meyering <meyering@redhat.com>
1107
1108 do not dereference NULL upon failed strdup
1109 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1110 (ns_get_family): Likewise.
1111
1112 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1113
1114 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1115
1116 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1117
1118 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1119 later (Bug#8403).
1120
1121 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1122
1123 Add lexical binding.
1124
1125 * window.c (Ftemp_output_buffer_show): New fun.
1126 (Fsave_window_excursion):
1127 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1128
1129 * lread.c (lisp_file_lexically_bound_p): New function.
1130 (Fload): Bind Qlexical_binding.
1131 (readevalloop): Remove `evalfun' arg.
1132 Bind Qinternal_interpreter_environment.
1133 (Feval_buffer): Bind Qlexical_binding.
1134 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1135 Mark as dynamic.
1136 (syms_of_lread): Declare `lexical-binding'.
1137
1138 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1139
1140 * keyboard.c (eval_dyn): New fun.
1141 (menu_item_eval_property): Use it.
1142
1143 * image.c (parse_image_spec): Use Ffunctionp.
1144
1145 * fns.c (concat, mapcar1): Accept byte-code-functions.
1146
1147 * eval.c (Fsetq): Handle lexical vars.
1148 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1149 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1150 (FletX, Flet): Obey lexical binding.
1151 (Fcommandp): Handle closures.
1152 (Feval): New `lexical' arg.
1153 (eval_sub): New function extracted from Feval. Use it almost
1154 everywhere where Feval was used. Look up vars in lexical env.
1155 Handle closures.
1156 (Ffunctionp): Move from subr.el.
1157 (Ffuncall): Handle closures.
1158 (apply_lambda): Remove `eval_flags'.
1159 (funcall_lambda): Handle closures and new byte-code-functions.
1160 (Fspecial_variable_p): New function.
1161 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1162 but without exporting it to Lisp.
1163
1164 * doc.c (Fdocumentation, store_function_docstring):
1165 * data.c (Finteractive_form): Handle closures.
1166
1167 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1168 interactive spec.
1169
1170 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1171 byte-codes.
1172 (exec_byte_code): New function extracted from Fbyte_code to handle new
1173 calling convention for byte-code-functions. Add new byte-codes.
1174
1175 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1176
1177 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1178
1179 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1180
1181 * xdisp.c (redisplay_internal): Fix prototype.
1182
1183 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1184
1185 * xdisp.c (SCROLL_LIMIT): New macro.
1186 (try_scrolling): Use it when setting scroll_limit. Limit
1187 scrolling to 100 screen lines.
1188 (redisplay_window): Even when falling back on "recentering",
1189 position point in the window according to scroll-conservatively,
1190 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1191
1192 (try_scrolling): When point is above the window, allow searching
1193 as far as scroll_max, or one screenful, to compute vertical
1194 distance from PT to the scroll margin position. This prevents
1195 try_scrolling from unnecessarily failing when
1196 scroll-conservatively is set to a value slightly larger than the
1197 window height. Clean up the case of PT below the margin at bottom
1198 of window: scroll_max can no longer be INT_MAX. When aggressive
1199 scrolling is in use, don't let point enter the opposite scroll
1200 margin as result of the scroll.
1201 (syms_of_xdisp) <scroll-conservatively>: Document the
1202 threshold of 100 lines for never-recentering scrolling.
1203
1204 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1205
1206 * dispextern.h (move_it_by_lines):
1207 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1208 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1209 (message_log_check_duplicate): Remove parameters `prev_bol' and
1210 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1211 (redisplay_internal): Remove parameter `preserve_echo_area',
1212 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1213
1214 * indent.c (Fvertical_motion):
1215 * window.c (window_scroll_pixel_based, Frecenter):
1216 Don't pass `need_y_p' to `move_it_by_lines'.
1217
1218 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1219
1220 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1221 steal a few bits to be more compact.
1222 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1223 Remove unneeded casts.
1224
1225 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1226
1227 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1228
1229 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1230 binding" message (bug#7967).
1231
1232 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 Fix more problems found by GCC 4.6.0's static checks.
1235
1236 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1237 Remove unused local var.
1238
1239 * editfns.c (Fmessage_box): Remove unused local var.
1240
1241 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1242 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1243 Omit unused local vars.
1244 * window.c (shrink_windows): Omit unused local var.
1245 * menu.c (digest_single_submenu): Omit unused local var.
1246 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1247 Omit unused local var.
1248
1249 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1250 Don't assume string length fits in int.
1251 (keyremap_step, read_key_sequence): Use size_t for sizes.
1252 (read_key_sequence): Don't check last_real_key_start redundantly.
1253
1254 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1255 instead of alloca (Bug#8344).
1256
1257 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1258 (Fbacktrace_frame): Don't assume nframes fits in int.
1259
1260 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1261
1262 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1263 concerns.
1264
1265 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1266
1267 * cm.c (calccost): Turn while-do into do-while, for clarity.
1268
1269 * keyboard.c (syms_of_keyboard): Use the same style as later
1270 in this function when indexing through an array. This also
1271 works around GCC bug 48267.
1272
1273 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1274
1275 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1276
1277 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1278 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1279
1280 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1281 This avoids undefined behavior on integer overflow, and is a bit
1282 more convenient anyway since it is compared to a size_t variable.
1283
1284 Variadic C functions now count arguments with size_t, not int.
1285 This avoids an unnecessary limitation on 64-bit machines, which
1286 caused (substring ...) to crash on large vectors (Bug#8344).
1287 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1288 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1289 All variadic functions and their callers changed accordingly.
1290 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1291 * data.c (arith_driver, float_arith_driver): Likewise.
1292 * editfns.c (general_insert_function): Likewise.
1293 * eval.c (struct backtrace.nargs, interactive_p)
1294 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1295 (funcall_lambda, mark_backtrace): Likewise.
1296 * fns.c (concat): Likewise.
1297 * frame.c (x_set_frame_parameters): Likewise.
1298 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1299 0 if not found, not -1. All callers changed.
1300
1301 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1302 (stack_copy_size): Now size_t, not int.
1303 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1304
1305 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1306
1307 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1308 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1309 All callers changed.
1310
1311 * lisp.h (multibyte_char_to_unibyte):
1312 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1313 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1314 * character.h (CHAR_TO_BYTE8):
1315 * cmds.c (internal_self_insert):
1316 * editfns.c (general_insert_function):
1317 * keymap.c (push_key_description):
1318 * search.c (Freplace_match):
1319 * xdisp.c (message_dolog, set_message_1): All callers changed.
1320
1321 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1322
1323 * keyboard.c (safe_run_hook_funcall): New function.
1324 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1325 don't set the hook to nil, but remove the offending function instead.
1326 (Qcommand_hook_internal): Remove, unused.
1327 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1328 Vcommand_hook_internal.
1329
1330 * eval.c (enum run_hooks_condition): Remove.
1331 (funcall_nil, funcall_not): New functions.
1332 (run_hook_with_args): Call each function through a `funcall' argument.
1333 Remove `cond' argument, now redundant.
1334 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1335 (Frun_hook_with_args_until_failure): Adjust accordingly.
1336 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1337
1338 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1339
1340 * dispextern.h (string_buffer_position): Remove declaration.
1341
1342 * print.c (strout): Remove parameter `multibyte', unused since
1343 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1344
1345 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1346 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1347 All callers changed.
1348
1349 * w32.c (_wsa_errlist): Use braces for struct initializers.
1350
1351 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1352 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1353 All callers changed.
1354 (string_buffer_position): Likewise. Also, make static (it's never
1355 used outside xdisp.c).
1356 (cursor_row_p): Remove parameter `w', unused since
1357 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1358 (decode_mode_spec): Remove parameter `precision', introduced during
1359 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1360 All callers changed.
1361
1362 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1363
1364 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1365
1366 2011-03-27 Anders Lindgren <andlind@gmail.com>
1367
1368 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1369 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1370 (ns_update_auto_hide_menu_bar): New functions.
1371 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1372 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1373 ns_constrain_all_frames.
1374 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1375 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1376
1377 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1378
1379 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1380
1381 2011-03-27 Glenn Morris <rgm@gnu.org>
1382
1383 * syssignal.h: Replace RETSIGTYPE with void.
1384 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1385 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1386 Replace SIGTYPE with void everywhere.
1387 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1388 * s/template.h (SIGTYPE): Remove commented out definition.
1389
1390 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1391
1392 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1393 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1394
1395 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1396
1397 * w32.c (read_unc_volume): Use parameter `henum', instead of
1398 global variable `wget_enum_handle'.
1399
1400 * keymap.c (describe_vector): Remove parameters `indices' and
1401 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1402 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1403
1404 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1405
1406 * keyboard.c (timer_check): Remove parameter `do_it_now',
1407 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1408 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1409 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1410
1411 * keyboard.c (read_char):
1412 * w32menu.c (w32_menu_display_help):
1413 * xmenu.c (show_help_event, menu_help_callback):
1414 Adjust calls to `show_help_echo'.
1415
1416 * gtkutil.c (xg_maybe_add_timer):
1417 * keyboard.c (readable_events):
1418 * process.c (wait_reading_process_output):
1419 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1420
1421 * insdel.c (adjust_markers_gap_motion):
1422 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1423 (gap_left, gap_right): Don't call it.
1424
1425 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1426
1427 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1428 incurred during fontification.
1429
1430 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1431
1432 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1433 (DEFVAR_PER_BUFFER): Don't pass it.
1434
1435 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1436 (scrolling_window): Don't pass it.
1437
1438 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1439
1440 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1441
1442 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1443 and `suffix'.
1444 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1445 of variables specific to SELinux and computation of `encoded_absname'.
1446
1447 * image.c (XPutPixel): Remove unused variable `height'.
1448
1449 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1450
1451 * unexw32.c (get_section_info): Remove unused variable `section'.
1452
1453 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1454 (system_process_attributes): Remove unused variable `sess'.
1455 (sys_read): Remove unused variable `err'.
1456
1457 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1458 (w32_wnd_proc): Remove unused variable `isdead'.
1459 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1460 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1461 (x_create_tip_frame): Remove unused variable `tem'.
1462
1463 * w32inevt.c (w32_console_read_socket):
1464 Remove unused variable `no_events'.
1465
1466 * w32term.c (x_draw_composite_glyph_string_foreground):
1467 Remove unused variable `width'.
1468
1469 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1470
1471 * w32term.c (x_set_glyph_string_clipping):
1472 Don't pass uninitialized region to CombineRgn.
1473
1474 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1475
1476 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1477 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1478 (Fx_close_connection): Remove unused variable `i'.
1479
1480 * w32font.c (w32font_draw): Return number of glyphs.
1481 (w32font_open_internal): Remove unused variable `i'.
1482 (w32font_driver): Add missing initializer.
1483
1484 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1485 (fill_in_menu): Remove unused variable `items_added'.
1486
1487 * w32term.c (last_mouse_press_frame): Remove static global variable.
1488 (w32_clip_to_row): Remove unused variable `f'.
1489 (x_delete_terminal): Remove unused variable `i'.
1490
1491 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1492 (NOTHING): Remove unused static global variable.
1493 (uniscribe_check_otf): Remove unused variable `table'.
1494 (uniscribe_font_driver): Add missing initializers.
1495
1496 2011-03-23 Julien Danjou <julien@danjou.info>
1497
1498 * term.c (Fsuspend_tty, Fresume_tty):
1499 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1500 * window.c (temp_output_buffer_show):
1501 * insdel.c (signal_before_change):
1502 * frame.c (Fhandle_switch_frame):
1503 * fileio.c (Fdo_auto_save):
1504 * emacs.c (Fkill_emacs):
1505 * editfns.c (save_excursion_restore):
1506 * cmds.c (internal_self_insert):
1507 * callint.c (Fcall_interactively):
1508 * buffer.c (Fkill_all_local_variables):
1509 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1510 Use Frun_hooks.
1511 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1512 unconditionnaly since it does the check itself.
1513
1514 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 Fix more problems found by GCC 4.5.2's static checks.
1517
1518 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1519 the first time through the loop, since we know p0 < p1 then.
1520 This also avoids a gcc -Wstrict-overflow warning.
1521
1522 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1523 leading to a memory leak, possible in functions like
1524 load_charset_map_from_file that can allocate an unbounded number
1525 of objects (Bug#8318).
1526
1527 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1528 that could (at least in theory) be that large.
1529
1530 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1531 This is less likely to overflow, and avoids undefined behavior if
1532 overflow does occur. All callers changed. Use strtoul to scan
1533 for the unsigned long integer.
1534 (pint2hrstr): Simplify and tune code slightly.
1535 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1536
1537 * scroll.c (do_scrolling): Work around GCC bug 48228.
1538 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1539
1540 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1541 This also avoids a warning with gcc -Wstrict-overflow.
1542 (validate_x_resource_name): Simplify count usage.
1543 This also avoids a warning with gcc -Wstrict-overflow.
1544
1545 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1546 fail (Bug#8306).
1547
1548 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1549
1550 * process.c (Fmake_network_process): Use socklen_t, not int,
1551 where POSIX says socklen_t is required in portable programs.
1552 This fixes a porting bug on hosts like 64-bit HP-UX, where
1553 socklen_t is wider than int (Bug#8277).
1554 (Fmake_network_process, server_accept_connection):
1555 (wait_reading_process_output, read_process_output):
1556 Likewise.
1557
1558 * process.c: Rename or move locals to avoid shadowing.
1559 (list_processes_1, Fmake_network_process):
1560 (read_process_output_error_handler, exec_sentinel_error_handler):
1561 Rename or move locals.
1562 (Fmake_network_process): Define label "retry_connect" only if needed.
1563 (Fnetwork_interface_info): Fix pointer signedness.
1564 (process_send_signal): Add cast to avoid pointer signedness problem.
1565 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1566 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1567
1568 Make tparam.h and terminfo.c consistent.
1569 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1570 Include tparam.h instead, since it declares them.
1571 * cm.h (PC): Remove extern decl; tparam.h now does this.
1572 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1573 * terminfo.c: Include tparam.h, to check interfaces.
1574 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1575 (tparam): Adjust signature to match interface in tparam.h;
1576 this removes some undefined behavior. Check that outstring and len
1577 are zero, which they always are with Emacs.
1578 * tparam.h (PC, BC, UP): New extern decls.
1579
1580 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1581 (xftfont_open): Rename locals to avoid shadowing.
1582
1583 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1584 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1585 (OTF_TAG_SYM): Omit macro if not needed.
1586 (ftfont_list): Remove unused local.
1587 (get_adstyle_property, ftfont_pattern_entity):
1588 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1589 Rename locals to avoid shadowing.
1590
1591 * xfont.c (xfont_list_family): Mark var as initialized.
1592
1593 * xml.c (make_dom): Now static.
1594
1595 * composite.c (composition_compute_stop_pos): Rename local to
1596 avoid shadowing.
1597 (composition_reseat_it): Remove unused locals.
1598 (find_automatic_composition, composition_adjust_point): Likewise.
1599 (composition_update_it): Mark var as initialized.
1600 (find_automatic_composition): Mark vars as initialized,
1601 with a FIXME (Bug#8290).
1602
1603 character.h: Rename locals to avoid shadowing.
1604 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1605 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1606 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1607 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1608 to avoid shadowing.
1609
1610 * textprop.c (property_change_between_p): Remove; unused.
1611
1612 * intervals.c (interval_start_pos): Now static.
1613
1614 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1615
1616 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1617 Rename locals to avoid shadowing.
1618
1619 * sound.c (wav_play, au_play, Fplay_sound_internal):
1620 Fix pointer signedness.
1621 (alsa_choose_format): Remove unused local var.
1622 (wav_play): Initialize a variable to 0, to prevent undefined
1623 behavior (Bug#8278).
1624
1625 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1626
1627 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1628
1629 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1630 clobbering (Bug#8298).
1631 * sysdep.c (sys_subshell): Likewise.
1632 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1633
1634 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1635 This should get cleaned up, so that child_setup has the
1636 same signature on all platforms.
1637
1638 * callproc.c (call_process_cleanup): Now static.
1639 (relocate_fd): Rename locals to avoid shadowing.
1640
1641 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1642
1643 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1644 not to be necessary, and produces flickering.
1645
1646 2011-03-20 Glenn Morris <rgm@gnu.org>
1647
1648 * config.in: Remove file.
1649
1650 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1651
1652 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1653 are now in src/globals.h.
1654 (syms_of_minibuf): Remove spurious & from previous change.
1655
1656 2011-03-20 Leo <sdl.web@gmail.com>
1657
1658 * minibuf.c (completing-read-function): New variable.
1659 (completing-read-default): Rename from completing-read.
1660 (completing-read): Call completing-read-function.
1661
1662 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1663
1664 * xfaces.c (Fx_load_color_file):
1665 Read color file from absolute filename (bug#8250).
1666
1667 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1668
1669 * makefile.w32-in: Update dependencies.
1670
1671 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1672
1673 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1674
1675 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1676
1677 Fix more problems found by GCC 4.5.2's static checks.
1678
1679 * process.c (make_serial_process_unwind, send_process_trap):
1680 (sigchld_handler): Now static.
1681
1682 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1683 That way, the code declares only the vars that it needs.
1684 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1685 * s/cygwin.h (PTY_ITERATION): Likewise.
1686 * s/darwin.h (PTY_ITERATION): Likewise.
1687 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1688
1689 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1690 * process.c (allocate_pty): Don't declare stb unless it's needed.
1691
1692 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1693 (CONSTANTLIM): Remove; unused.
1694 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1695 Define only if needed.
1696
1697 * unexelf.c (unexec): Name an expression,
1698 to avoid gcc -Wbad-function-cast warning.
1699 Use a different way to cause a compilation error if anyone uses
1700 n rather than nn, a way that does not involve shadowing.
1701 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1702
1703 * deps.mk (unexalpha.o): Remove; unused.
1704
1705 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1706 * unexec.h: New file.
1707 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1708 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1709 Depend on unexec.h.
1710 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1711 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1712 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1713 Change as necessary to match prototype in unexec.h.
1714
1715 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1716 shadowing.
1717 (back_comment, skip_chars): Mark vars as initialized.
1718
1719 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1720 Rename locals to avoid shadowing.
1721
1722 * lread.c (read1): Rewrite so as not to use empty "else".
1723 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1724
1725 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1726
1727 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1728 warning when compiling print.c.
1729
1730 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1731 instead of using an uninitialized var.
1732 (font_sort_entities): Mark var as initialized.
1733
1734 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1735
1736 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1737 pointers to constants.
1738 (font_parse_fcname): Remove unused vars.
1739 (font_delete_unmatched): Now static.
1740 (font_get_spec): Remove; unused.
1741 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1742 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1743 Rename or move locals to avoid shadowing.
1744
1745 * fns.c (require_nesting_list, require_unwind): Now static.
1746 (Ffillarray): Rename locals to avoid shadowing.
1747
1748 * floatfns.c (domain_error2): Define only if needed.
1749 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1750
1751 * alloc.c (mark_backtrace): Move decl from here ...
1752 * lisp.h: ... to here, so that it can be checked.
1753
1754 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1755 (Fdefvar): Rewrite so as not to use empty "else".
1756 (lisp_indirect_variable): Name an expression,
1757 to avoid gcc -Wbad-function-cast warning.
1758 (Fdefvar): Rename locals to avoid shadowing.
1759
1760 * callint.c (quotify_arg, quotify_args): Now static.
1761 (Fcall_interactively): Rename locals to avoid shadowing.
1762 Use const pointer when appropriate.
1763
1764 * lisp.h (get_system_name, get_operating_system_release):
1765 Move decls here, to check interfaces.
1766 * process.c (get_operating_system_release): Move decl to lisp.h.
1767 * xrdb.c (get_system_name): Likewise.
1768 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1769 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1770 some of which prompt warnings from gcc -Wbad-function-cast.
1771 (Fformat_time_string, Fencode_time, Finsert_char):
1772 (Ftranslate_region_internal, Fformat):
1773 Rename or remove local vars to avoid shadowing.
1774 (Ftranslate_region_internal): Mark var as initialized.
1775
1776 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1777 avoid shadowing.
1778
1779 * lisp.h (eassert): Check that the argument compiles, even if
1780 ENABLE_CHECKING is not defined.
1781
1782 * data.c (Findirect_variable): Name an expression, to avoid
1783 gcc -Wbad-function-cast warning.
1784 (default_value, arithcompare, arith_driver, arith_error): Now static.
1785 (store_symval_forwarding): Rename local to avoid shadowing.
1786 (Fmake_variable_buffer_local, Fmake_local_variable):
1787 Mark variables as initialized.
1788 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1789
1790 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1791 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1792 Rename locals to avoid shadowing.
1793 (mark_stack): Move local variables into the #ifdef region where
1794 they're used.
1795 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1796 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1797 needed otherwise.
1798 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1799 (GC_STRING_CHARS): Remove; not used.
1800 (Fmemory_limit): Cast sbrk's returned value to char *.
1801
1802 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1803 avoids undefined behavior in theory.
1804
1805 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1806
1807 Use functions, not macros, for up- and down-casing (Bug#8254).
1808 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1809 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1810 to use the following functions instead of these macros.
1811 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1812 EMACS_INT, since callers assume the returned value fits in int.
1813 (upcase1): Likewise, for UPCASE_TABLE.
1814 (uppercasep, lowercasep, upcase): New static inline functions.
1815 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1816 the race-condition problem in the old DOWNCASE.
1817
1818 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1819 Rename locals to avoid shadowing.
1820 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1821 (regex_compile, re_search_2, re_match_2_internal):
1822 Remove unused local vars.
1823 (FREE_VAR): Rewrite so as not to use empty "else",
1824 which gcc can warn about.
1825 (regex_compile, re_match_2_internal): Mark locals as initialized.
1826 (RETALLOC_IF): Define only if needed.
1827 (WORDCHAR_P): Likewise. This one is never needed, but is used
1828 only in a comment talking about a compiler bug, so put inside
1829 the #if 0 of that comment.
1830 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1831 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1832 Remove; unused.
1833
1834 * search.c (boyer_moore): Rename locals to avoid shadowing.
1835 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1836 (PREV_CHAR_BOUNDARY): Likewise.
1837
1838 * search.c (simple_search): Remove unused var.
1839
1840 * dired.c (compile_pattern): Move decl from here ...
1841 * lisp.h: ... to here, so that it can be checked.
1842 (struct re_registers): New forward decl.
1843
1844 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1845
1846 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1847 All uses changed.
1848 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1849 Rename locals to avoid shadowing.
1850 (Fvertical_motion): Mark locals as initialized.
1851
1852 * casefiddle.c (casify_object, casify_region): Now static.
1853 (casify_region): Mark local as initialized.
1854
1855 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1856
1857 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1858 New macros, so that the caller can use some names other than
1859 gcpro1, gcpro2, etc.
1860 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1861 of the new macros.
1862 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1863 argument, for consistency with GCPRO2_VAR, etc: it is now the
1864 prefix of the variable, not the variable itself. All uses
1865 changed.
1866 * dired.c (directory_files_internal, file_name_completion):
1867 Rename locals to avoid shadowing.
1868
1869 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1870 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1871 dired.c's scmp function, had undefined behavior.
1872 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1873 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1874 * buffer.h: ... to here, because these macros use current_buffer,
1875 and the new implementation with inline functions needs to have
1876 current_buffer in scope now, rather than later when the macros
1877 are used.
1878 (downcase, upcase1): New static inline functions.
1879 (DOWNCASE, UPCASE1): Reimplement using these functions.
1880 This avoids undefined behavior in expressions like
1881 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1882 from race conditions in accessing the global variables
1883 case_temp1 and case_temp2.
1884 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1885 * lisp.h (case_temp1, case_temp2): Remove their decls.
1886 * character.h (ASCII_CHAR_P): Move from here ...
1887 * lisp.h: ... to here, so that the inline functions mentioned
1888 above can use them.
1889
1890 * dired.c (directory_files_internal_unwind): Now static.
1891
1892 * fileio.c (file_name_as_directory, directory_file_name):
1893 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1894 Now static.
1895 (file_name_as_directory): Use const pointers when appropriate.
1896 (Fexpand_file_name): Likewise. In particular, newdir might
1897 point at constant storage, so make it a const pointer.
1898 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1899 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1900 signedness issues.
1901 (Fset_file_times, Finsert_file_contents, auto_save_error):
1902 Rename locals to avoid shadowing.
1903
1904 * minibuf.c (choose_minibuf_frame_1): Now static.
1905 (Ftry_completion, Fall_completions): Rename or remove locals
1906 to avoid shadowing.
1907
1908 * marker.c (bytepos_to_charpos): Remove; unused.
1909
1910 * lisp.h (verify_bytepos, count_markers): New decls,
1911 so that gcc does not warn that these functions aren't declared.
1912
1913 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1914 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1915 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1916 (copy_text): Remove unused local var.
1917
1918 * filelock.c (within_one_second): Now static.
1919 (lock_file_1): Rename local to avoid shadowing.
1920
1921 * buffer.c (fix_overlays_before): Mark locals as initialized.
1922 (fix_start_end_in_overlays): Likewise. This function should be
1923 simplified by using pointers-to-pointers, but that's a different
1924 matter.
1925 (switch_to_buffer_1): Now static.
1926 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1927 (report_overlay_modification): Rename locals to avoid shadowing.
1928
1929 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1930 Fix pointer signedness issue.
1931 (sys_subshell): Mark local as volatile if checking for lint,
1932 to suppress a gcc -Wclobbered warning that does not seem to be right.
1933 (MAXPATHLEN): Define only if needed.
1934
1935 * process.c (serial_open, serial_configure): Move decls from here ...
1936 * systty.h: ... to here, so that they can be checked.
1937
1938 * fns.c (get_random, seed_random): Move extern decls from here ...
1939 * lisp.h: ... to here, so that they can be checked.
1940
1941 * sysdep.c (reset_io): Now static.
1942 (wait_for_termination_signal): Remove; unused.
1943
1944 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1945 (copy_keymap_item, append_key, push_text_char_description):
1946 Now static.
1947 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1948 (DENSE_TABLE_SIZE): Remove; unused.
1949 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1950 (describe_map_tree):
1951 Rename locals to avoid shadowing.
1952
1953 * keyboard.c: Declare functions static if they are not used elsewhere.
1954 (echo_char, echo_dash, cmd_error, top_level_2):
1955 (poll_for_input, handle_async_input): Now static.
1956 (read_char, kbd_buffer_get_event, make_lispy_position):
1957 (make_lispy_event, make_lispy_movement, apply_modifiers):
1958 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1959 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1960 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1961 (read_key_sequence, read_char): Mark locals as initialized.
1962 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1963
1964 * keyboard.h (make_ctrl_char): New decl.
1965 (mark_kboards): Move decl here ...
1966 * alloc.c (mark_kboards): ... from here.
1967
1968 * lisp.h (force_auto_save_soon): New decl.
1969
1970 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1971 (DEFINE_DUMMY_FUNCTION): New macro.
1972 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1973 Use it.
1974 (main): Add casts to avoid warnings
1975 if GCC considers string literals to be constants.
1976
1977 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1978
1979 * dbusbind.c: Pointer signedness fixes.
1980 (xd_signature, xd_append_arg, xd_initialize):
1981 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1982 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1983 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1984 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1985
1986 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1987 if GCC considers string literals to be constants.
1988 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1989
1990 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1991
1992 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1993 (print_preprocess, print_object): New macro to fix last change.
1994
1995 * print.c (print_preprocess): Don't forget font objects.
1996
1997 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1998
1999 * emacs.c (USAGE3): Doc fixes.
2000
2001 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2002
2003 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2004 structure.
2005
2006 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2007
2008 * lisp.h (VWindow_system, Qfile_name_history):
2009 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2010 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2011 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2012
2013 * w32select.c: Don't #include "keyboard.h".
2014 (run_protected): Add extern declaration for waiting_for_input.
2015
2016 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2017 * w32console.c (detect_input_pending, read_input_pending)
2018 (encode_terminal_code):
2019 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2020 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2021 (w32_system_caret_y, Qfile_name_history):
2022 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2023 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2024 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2025 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2026 * w32proc.c (Qlocal, report_file_error):
2027 * w32term.c (Vwindow_system, updating_frame):
2028 * w32uniscribe.c (initialized, uniscribe_font_driver):
2029 Remove unneeded extern declarations.
2030
2031 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2032
2033 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2034
2035 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2036
2037 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2038 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2039 These macros can no longer be used for assignment.
2040
2041 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2042 Assign struct members directly, instead of using BUF_BEGV etc.
2043 (record_buffer_markers, fetch_buffer_markers): New functions for
2044 recording and fetching special buffer markers.
2045 (set_buffer_internal_1, set_buffer_temp): Use them.
2046
2047 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2048
2049 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2050
2051 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2052 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2053
2054 * xdisp.c (hscroll_window_tree):
2055 (reconsider_clip_changes): Use PT instead of BUF_PT.
2056
2057 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2058
2059 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2060 $(EMACS_ROOT)/lib/intprops.h.
2061
2062 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2063
2064 Fix more problems found by GCC 4.5.2's static checks.
2065
2066 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2067 to unsigned char * to avoid compiler diagnostic.
2068 (xg_free_frame_widgets): Make it clear that a local variable is
2069 needed only if USE_GTK_TOOLTIP.
2070 (gdk_window_get_screen): Make it clear that this macro is needed
2071 only if USE_GTK_TOOLTIP.
2072 (int_gtk_range_get_value): New function, which avoids a diagnostic
2073 from gcc -Wbad-function-cast.
2074 (xg_set_toolkit_scroll_bar_thumb): Use it.
2075 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2076 diagnostic from gcc -Wbad-function-cast.
2077 (get_utf8_string, xg_get_file_with_chooser):
2078 Rename locals to avoid shadowing.
2079 (create_dialog): Move locals to avoid shadowing.
2080
2081 * xgselect.c (xg_select): Remove unused var.
2082
2083 * image.c (four_corners_best): Mark locals as initialized.
2084 (gif_load): Initialize transparent_p to zero (Bug#8238).
2085 Mark another local as initialized.
2086 (my_png_error, my_error_exit): Mark with NO_RETURN.
2087
2088 * image.c (clear_image_cache): Now static.
2089 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2090 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2091 (x_edge_detection): Remove unnecessary cast that
2092 gcc -Wbad-function-cast diagnoses.
2093 (gif_load): Fix pointer signedness.
2094 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2095 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2096
2097 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2098
2099 Improve quality of tests for time stamp overflow.
2100 For example, without this patch (encode-time 0 0 0 1 1
2101 1152921504606846976) returns the obviously-bogus value (-948597
2102 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2103 reports time overflow. See
2104 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2105 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2106 * editfns.c: Include limits.h and intprops.h.
2107 (TIME_T_MIN, TIME_T_MAX): New macros.
2108 (time_overflow): Move earlier, to before first use.
2109 (hi_time, lo_time): New functions, for an accurate test for
2110 out-of-range times.
2111 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2112 (Fget_internal_run_time): Don't assume time_t fits in int.
2113 (make_time): Use list2 instead of Fcons twice.
2114 (Fdecode_time): More accurate test for out-of-range times.
2115 (check_tm_member): New function.
2116 (Fencode_time): Use it, to test for out-of-range times.
2117 (lisp_time_argument): Don't rely on undefined left-shift and
2118 right-shift behavior when checking for time stamp overflow.
2119
2120 * editfns.c (time_overflow): New function, refactoring common code.
2121 (Fformat_time_string, Fdecode_time, Fencode_time):
2122 (Fcurrent_time_string): Use it.
2123
2124 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2125 * dired.c (make_time): Move to ...
2126 * editfns.c (make_time): ... here.
2127 * systime.h: Note the move.
2128
2129 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2130
2131 * fringe.c (update_window_fringes): Remove unused variables.
2132
2133 * unexmacosx.c (copy_data_segment): Also copy __got section.
2134 (Bug#8223)
2135
2136 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2137
2138 * termcap.c [MSDOS]: Include "msdos.h".
2139 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2140 Constify `char *' arguments and their references according to
2141 prototypes in tparam.h.
2142
2143 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2144
2145 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2146 Adapt all references accordingly.
2147
2148 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2149
2150 2011-03-11 Tom Tromey <tromey@redhat.com>
2151
2152 * buffer.c (syms_of_buffer): Remove obsolete comment.
2153
2154 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2155
2156 * termhooks.h (encode_terminal_code): Declare prototype.
2157
2158 * msdos.c (encode_terminal_code): Don't declare prototype.
2159
2160 * term.c (encode_terminal_code): Now external again, used by
2161 w32console.c and msdos.c.
2162
2163 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2164 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2165
2166 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2167
2168 Fix some minor problems found by GCC 4.5.2's static checks.
2169
2170 * fringe.c (update_window_fringes): Mark locals as initialized
2171 (Bug#8227).
2172 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2173
2174 * alloc.c (mark_fringe_data): Move decl from here ...
2175 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2176 to check its interface.
2177 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2178
2179 * fontset.c (free_realized_fontset): Now static.
2180 (Fset_fontset_font): Rename local to avoid shadowing.
2181 (fontset_font): Mark local as initialized.
2182 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2183
2184 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2185
2186 * xselect.c (x_disown_buffer_selections): Remove; not used.
2187 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2188 (x_own_selection, Fx_disown_selection_internal): Rename locals
2189 to avoid shadowing.
2190 (x_handle_dnd_message): Remove local to avoid shadowing.
2191
2192 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2193 so that the caller can use some name other than gcpro1.
2194 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2195 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2196 (Fx_backspace_delete_keys_p):
2197 Use them to avoid shadowing, and rename vars to avoid shadowing.
2198 (x_decode_color, x_set_name, x_window): Now static.
2199 (Fx_create_frame): Add braces to silence GCC warning.
2200 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2201 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2202 Remove unused locals.
2203 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2204 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2205 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2206 macros.
2207
2208 * xterm.h (x_mouse_leave): New decl.
2209
2210 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2211 Remove unused functions.
2212 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2213 (x_calc_absolute_position): Now static.
2214 (XTread_socket): Don't define label "out" unless it's used.
2215 Don't declare local "event" unless it's used.
2216 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2217 unless they are used.
2218 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2219 (x_fatal_error_signal): Remove; not used.
2220 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2221 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2222 (x_error_catcher, x_connection_closed, x_error_handler):
2223 (x_error_quitter, xembed_send_message, x_iconify_frame):
2224 (my_log_handler): Rename locals to avoid shadowing.
2225 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2226 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2227
2228 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2229 Rename or move locals to avoid shadowing.
2230 (tty_defined_color, merge_face_heights): Now static.
2231 (free_realized_faces_for_fontset): Remove; not used.
2232 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2233 does not deduce is never used uninitialized.
2234 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2235 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2236
2237 * terminal.c (store_terminal_param): Now static.
2238
2239 * xmenu.c (menu_highlight_callback): Now static.
2240 (set_frame_menubar): Remove unused local.
2241 (xmenu_show): Rename parameter to avoid shadowing.
2242 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2243 since they might point to immutable storage.
2244 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2245 since it's unused otherwise.
2246
2247 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2248 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2249 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2250 avoids a gcc -Wuninitialized diagnostic.
2251 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2252 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2253 does not deduce are never used uninitialized.
2254
2255 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2256
2257 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2258 * window.c (window_loop, size_window):
2259 (run_window_configuration_change_hook, enlarge_window): Likewise.
2260
2261 * window.c (display_buffer): Now static.
2262 (size_window): Mark variables that gcc -Wuninitialized
2263 does not deduce are never used uninitialized.
2264 * window.h (check_all_windows): New decl, to forestall
2265 gcc -Wmissing-prototypes diagnostic.
2266 * dispextern.h (bidi_dump_cached_states): Likewise.
2267
2268 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2269 shadowing.
2270 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2271 Include <limits.h>.
2272 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2273 and to avoid gcc -Wuninitialized warning.
2274 (load_charset_map): Mark variables that gcc -Wuninitialized
2275 does not deduce are never used uninitialized.
2276 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2277
2278 * coding.c (coding_set_source, coding_set_destination):
2279 Use "else { /* comment */ }" rather than "else /* comment */;"
2280 for clarity, and to avoid gcc -Wempty-body warning.
2281 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2282 a block, when the outer 'i' will do.
2283 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2284 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2285 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2286 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2287 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2288 Rename locals to avoid shadowing.
2289 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2290 * coding.c (emacs_mule_char, encode_invocation_designation):
2291 Now static, since they're not used elsewhere.
2292 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2293 (decode_coding_object, encode_coding_object, detect_coding_system):
2294 (decode_coding_emacs_mule): Mark variables that gcc
2295 -Wuninitialized does not deduce are never used uninitialized.
2296 (detect_coding_iso_2022): Initialize a local variable that might
2297 be used uninitialized. Leave a FIXME because it's not clear that
2298 this initialization is needed. (Bug#8211)
2299 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2300 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2301 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2302 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2303 Remove unused macros.
2304
2305 * category.c (hash_get_category_set): Remove unused local var.
2306 (copy_category_table): Now static, since it's not used elsewhere.
2307 * character.c (string_count_byte8): Likewise.
2308
2309 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2310 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2311
2312 * chartab.c (copy_sub_char_table): Now static, since it's not used
2313 elsewhere.
2314 (sub_char_table_ref_and_range, char_table_ref_and_range):
2315 Rename locals to avoid shadowing.
2316 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2317
2318 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2319 (BIDI_BOB): Remove unused macro.
2320
2321 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2322 deduce are never used uninitialized.
2323 * term.c (encode_terminal_code): Likewise.
2324
2325 * term.c (encode_terminal_code): Now static. Remove unused local.
2326
2327 * tparam.h: New file.
2328 * term.c, tparam.h: Include it.
2329 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2330 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2331 Move these decls to tparam.h, and make them agree with what
2332 is actually in tparam.c. The previous trick of using incompatible
2333 decls in different modules does not conform to the C standard.
2334 All callers of tparam changed to use tparam's actual API.
2335 * tparam.c (tparam1, tparam, tgoto):
2336 Use const pointers where appropriate.
2337
2338 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2339 * cm.h (struct cm): Likewise.
2340 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2341 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2342 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2343 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2344 (turn_on_face, init_tty): Likewise.
2345 * termchar.h (struct tty_display_info): Likewise.
2346
2347 * term.c (term_mouse_position): Rename local to avoid shadowing.
2348
2349 * alloc.c (mark_ttys): Move decl from here ...
2350 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2351
2352 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2353
2354 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2355
2356 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2357
2358 * search.c (compile_pattern_1): Remove argument regp, unused since
2359 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2360 (compile_pattern): Don't pass it.
2361
2362 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2363
2364 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2365 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2366 for ! HAVE_GTK3.
2367 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2368
2369 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2370
2371 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2372 gdk_window_get_screen, gdk_window_get_geometry,
2373 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2374 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2375 (xg_get_pixbuf_from_pixmap): New function.
2376 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2377 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2378 Call xg_get_pixbuf_from_pixmap instead of
2379 gdk_pixbuf_get_from_drawable.
2380 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2381 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2382 (xg_check_special_colors): Use GtkStyleContext and its functions
2383 for HAVE_GTK3.
2384 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2385 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2386 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2387 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2388 Call gtk_widget_get_preferred_size.
2389 (xg_frame_resized): gdk_window_get_geometry only takes 5
2390 parameters.
2391 (xg_win_to_widget, xg_event_is_for_menubar):
2392 Call gdk_x11_window_lookup_for_display.
2393 (xg_set_widget_bg): New function.
2394 (delete_cb): New function.
2395 (xg_create_frame_widgets): connect delete-event to delete_cb.
2396 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2397 (xg_set_background_color): Call xg_set_widget_bg.
2398 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2399 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2400 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2401 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2402 if ! HAVE_GTK3.
2403 (update_frame_tool_bar): Call gtk_widget_hide.
2404 (xg_initialize): Use GDK_KEY_g.
2405
2406 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2407 if ! HAVE_GTK3
2408 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2409
2410 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2411 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2412 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2413
2414 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2415
2416 * w32xfns.c (select_palette): Check success of RealizePalette against
2417 GDI_ERROR, not zero.
2418
2419 See ChangeLog.11 for earlier changes.
2420
2421 ;; Local Variables:
2422 ;; coding: utf-8
2423 ;; End:
2424
2425 Copyright (C) 2011 Free Software Foundation, Inc.
2426
2427 This file is part of GNU Emacs.
2428
2429 GNU Emacs is free software: you can redistribute it and/or modify
2430 it under the terms of the GNU General Public License as published by
2431 the Free Software Foundation, either version 3 of the License, or
2432 (at your option) any later version.
2433
2434 GNU Emacs is distributed in the hope that it will be useful,
2435 but WITHOUT ANY WARRANTY; without even the implied warranty of
2436 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2437 GNU General Public License for more details.
2438
2439 You should have received a copy of the GNU General Public License
2440 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.