1 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
3 * minibuf.c (Fread_from_minibuffer): Doc fix.
5 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
8 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
10 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
12 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
13 value for non-existent files.
15 2011-09-11 Eli Zaretskii <eliz@gnu.org>
17 * fileio.c (Finsert_file_contents): If the file cannot be opened,
18 set its "size" to -1. This will set the modtime_size field of
19 the corresponding buffer to -1, which is what
20 verify-visited-file-modtime expects for files that do not exist.
23 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
25 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
27 * lisp.h: ... from here. push_key_description is no longer
28 defined in keyboard.c, so its declaration should not be in
29 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
30 logically belongs with push_key_description.
32 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
34 * buffer.h: Include <sys/types.h> instead of <time.h>.
35 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
36 Problem reported by Herbert J. Skuhra.
38 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
40 * xml.c (parse_region): Make the parsing work for
41 non-comment-starting XML files again (bug#9144).
43 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
45 * image.c (gif_load): Fix calculation of bottom and right corner.
48 2011-09-10 Eli Zaretskii <eliz@gnu.org>
50 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
51 redisplay in small windows.
53 2011-09-09 Eli Zaretskii <eliz@gnu.org>
55 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
57 2011-09-08 Martin Rudalics <rudalics@gmx.at>
59 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
60 Operate on live windows only.
62 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
64 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
66 2011-09-07 Eli Zaretskii <eliz@gnu.org>
68 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
69 only under bidi iteration.
71 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
73 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
75 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
77 isnan: Fix porting problem to Solaris 10 with bundled gcc.
78 Without this fix, the command to link temacs failed due to an
79 undefined symbol __builtin_isnan. This is because
80 /usr/include/iso/math_c99.h #defines isnan(x) to
81 __builtin_isnan(x), but the bundled gcc, which identifies itself
82 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
84 * floatfns.c (isnan): #undef, and then #define to a clone of
86 (Fisnan): Always define, since it's always available now.
87 (syms_of_floatfns): Always define isnan at the Lisp level.
89 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
91 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
93 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
95 * fileio.c: Fix bugs with large file offsets (Bug#9428).
96 The previous code assumed that file offsets (off_t values) fit in
97 EMACS_INT variables, which is not true on typical 32-bit hosts.
98 The code messed up by falsely reporting buffer overflow in cases
99 such as (insert-file-contents "big" nil 1 2) into an empty buffer
100 when "big" contains more than 2**29 bytes, even though this
101 inserts just one byte and does not overflow the buffer.
102 (Finsert_file_contents): Store file offsets as off_t
103 values, not as EMACS_INT values. Check for overflow when
104 converting between EMACS_INT and off_t. When checking for
105 buffer overflow or for overlap, take the offsets into account.
106 Don't use EMACS_INT for small values where int suffices.
107 When checking for overlap, fix a typo: ZV was used where
108 ZV_BYTE was intended.
109 (Fwrite_region): Don't assume off_t fits into 'long'.
110 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
112 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
114 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
116 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
118 sprintf-related integer and memory overflow issues (Bug#9412).
120 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
121 (esprintf, exprintf, evxprintf): New functions.
122 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
123 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
124 (modify_event_symbol): Do not assume that the length of
125 name_alist_or_stem is safe to alloca and fits in int.
126 (Fexecute_extended_command): Likewise for function name and binding.
127 (Frecursion_depth): Wrap around reliably on integer overflow.
128 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
129 since some callers pass EMACS_INT values.
130 (Fsingle_key_description): Don't crash if symbol name contains more
131 than MAX_ALLOCA bytes.
132 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
133 (get_minibuffer): Arg is now EMACS_INT, not int.
134 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
135 (esprintf, exprintf, evxprintf): New decls.
136 * window.h (command_loop_level, minibuf_level): Reflect API changes.
138 * dbusbind.c (signature_cat): New function.
139 (xd_signature, Fdbus_register_signal):
140 Do not overrun buffer; instead, report string overflow.
142 * dispnew.c (add_window_display_history): Don't overrun buffer.
143 Truncate instead; this is OK since it's just a log.
145 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
146 even if the time zone offset is outlandishly large.
147 Don't mishandle offset == INT_MIN.
149 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
150 when creating daemon; the previous buffer-overflow check was incorrect.
152 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
153 which has the guts of the old verror function.
155 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
156 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
158 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
159 (font_unparse_xlfd): Don't blindly alloca long strings.
160 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
161 fits in int, when using sprintf. Use single snprintf to count
162 length of string rather than counting it via multiple sprintfs;
163 that's simpler and more reliable.
164 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
165 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
166 sprintf, in case result does not fit in int.
168 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
169 (fontset_from_font): Print it.
171 * frame.c (tty_frame_count): Now printmax_t, not int.
172 (make_terminal_frame, set_term_frame_name): Print it.
173 (x_report_frame_params): In X, window IDs are unsigned long,
174 not signed long, so print them as unsigned.
175 (validate_x_resource_name): Check for implausibly long names,
176 and don't assume name length fits in 'int'.
177 (x_get_resource_string): Don't blindly alloca invocation name;
178 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
181 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
182 (xg_check_special_colors, xg_set_geometry):
183 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
185 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
186 Use esprintf, not sprintf, in case result does not fit in int.
188 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
189 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
190 it as a large positive number.
191 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
192 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
194 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
195 in case result does not fit in int.
197 * print.c (float_to_string): Detect width overflow more reliably.
198 (print_object): Make sprintf buffer a bit bigger, to avoid potential
199 buffer overrun. Don't assume list length fits in 'int'. Treat
200 print length of 0 as 0, not as infinity; to be consistent with other
201 uses of print length in this function. Don't overflow print length
202 index. Don't assume hash table size fits in 'long', or that
203 vectorlike size fits in 'unsigned long'.
205 * process.c (make_process): Use printmax_t, not int, to format
206 process-name gensyms.
208 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
210 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
211 to avoid potential buffer overrun.
213 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
214 if X resource line is longer than 512 bytes.
216 * xfns.c (x_window): Make sprintf buffer a bit bigger
217 to avoid potential buffer overrun.
219 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
221 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
223 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
225 Integer overflow fixes for scrolling, etc.
226 Without these, Emacs silently mishandles large integers sometimes.
227 For example, "C-u 4294967297 M-x recenter" was treated as if
228 it were "C-u 1 M-x recenter" on a typical 64-bit host.
230 * xdisp.c (try_window_id): Check Emacs fixnum range before
233 * window.c (window_scroll_line_based, Frecenter):
234 Check that an Emacs fixnum is in range before assigning it to 'int'.
235 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
236 values converted from Emacs fixnums.
237 (Frecenter): Don't wrap around a line count if it is out of 'int'
238 range; instead, treat it as an extreme value.
239 (Fset_window_configuration, compare_window_configurations):
240 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
242 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
243 that can exceed INT_MAX. Check that EMACS_INT value is in range
244 before assigning it to the (possibly-narrower) index.
245 (match_limit): Don't assume that a fixnum can fit in 'int'.
247 * print.c (print_object): Use ptrdiff_t, not int, for index that can
250 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
251 (Fvertical_motion): Don't wrap around LINES values that don't fit
252 in 'int'. Instead, treat them as extreme values. This is good
253 enough for windows, which can't have more than INT_MAX lines anyway.
255 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
257 * Require libxml/parser.h to avoid compilation warning.
259 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
261 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
262 since this reportedly can destroy thread storage.
264 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
266 * syntax.c (find_defun_start): Update all cache variables if
267 exiting early (Bug#9401).
269 2011-08-30 Eli Zaretskii <eliz@gnu.org>
271 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
273 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
274 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
275 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
277 * term.c (tty_append_glyph): New function.
278 (produce_stretch_glyph): Static function and its prototype deleted.
280 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
283 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
285 * image.c (parse_image_spec): Check for nonnegative, not for positive,
286 when checking :margin (Bug#9390).
287 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
288 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
289 so that the name doesn't mislead. All uses changed.
291 2011-08-28 Johan Bockgård <bojohan@gnu.org>
293 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
296 2011-08-27 Eli Zaretskii <eliz@gnu.org>
298 * xdisp.c (move_it_to): Don't bail out early when reaching
299 position beyond to_charpos, if we are scanning backwards.
300 (move_it_vertically_backward): When DY == 0, make sure we get to
301 the first character in the line after the newline.
303 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
305 * ccl.c: Improve and simplify overflow checking (Bug#9196).
306 (ccl_driver): Do not generate an out-of-range pointer.
307 (Fccl_execute_on_string): Remove unnecessary check for
308 integer overflow, noted by Stefan Monnier in
309 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
310 Remove a FIXME that didn't need fixing.
311 Simplify the newly-introduced buffer reallocation code.
313 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
315 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
317 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
319 Integer and memory overflow issues (Bug#9196).
321 * doc.c (get_doc_string): Rework so that
322 get_doc_string_buffer_size is the actual buffer size, rather than
323 being 1 less than the actual buffer size; this makes xpalloc more
326 * image.c (x_allocate_bitmap_record, cache_image):
327 * xselect.c (Fx_register_dnd_atom):
328 Simplify previous changes by using xpalloc.
330 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
331 since either will do and ptrdiff_t is convenient with xpalloc.
333 * charset.c (charset_table_size)
334 (struct charset_sort_data.priority): Now ptrdiff_t.
335 (charset_compare): Don't overflow if priorities differ greatly.
336 (Fsort_charsets): Don't assume list length fits in int.
337 Check for size-calculation overflow when allocating sort data.
338 (syms_of_charset): Allocate an initial charset table that is
339 just under 64 KiB, to avoid problems with glibc malloc and mmap.
341 * cmds.c (internal_self_insert): Check for size-calculation overflow.
343 * composite.h (struct composition.glyph_len): Now int, not unsigned.
344 The actual value is always <= INT_MAX, and leaving it unsigned made
345 overflow checking harder.
347 * dispextern.h (struct glyph_matrix.rows_allocated)
348 (struct face_cache.size): Now ptrdiff_t, for convenience in use
349 with xpalloc. The values are still always <= INT_MAX.
351 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
353 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
354 (SAFE_NALLOCA): New macro.
356 * region-cache.c (struct boundary.pos, find_cache_boundary)
357 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
358 (set_cache_region, invalidate_region_cache)
359 (revalidate_region_cache, know_region_cache, region_cache_forward)
360 (region_cache_backward, pp_cache):
361 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
362 so that ptrdiff_t * can be passed to xpalloc.
363 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
364 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
365 (pp_cache): Don't assume cache_len fits in int.
366 * region-cache.h: Adjust extern decls to match.
368 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
369 EMACS_INT, since either will do, for xpalloc.
371 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
372 (xnmalloc, xnrealloc, xpalloc): New functions.
374 * bidi.c (bidi_shelve_header_size): New constant.
375 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
376 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
378 * bidi.c (bidi_cache_shrink):
379 * buffer.c (overlays_at, overlays_in, record_overlay_string)
381 Don't update size of array until after memory allocation succeeds,
382 because xmalloc/xrealloc may not return.
383 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
384 now that we have proper integer overflow checking.
385 (record_overlay_string, overlay_strings): Catch overflows when
386 calculating size of overlay_str_buf.
388 * callproc.c (Fcall_process): Check for size overflow when
389 calculating size of args2.
390 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
391 Normally we prefer signed values, but sticking with ptrdiff_t would
392 require adding more-complicated checks.
394 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
395 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
396 Redo buffer-overflow calculations to avoid integer overflow.
397 Add a FIXME comment where memory seems to be over-allocated.
399 * character.c (Fstring): Check for size-calculation overflow.
401 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
402 unnecessary integer overflow. Check for size overflow.
403 (encode_coding_object): Don't update size until xmalloc succeeds.
405 * composite.c (get_composition_id): Check for overflow in glyph
408 Integer and memory overflow fixes for display code.
409 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
410 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
411 (scrolling_window): Check for overflow in size calculations.
412 (line_draw_cost, realloc_glyph_pool, add_row_entry):
413 Don't assume glyph table len fits in int.
414 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
415 (row_table_size): Now ptrdiff_t, not int.
416 (scrolling_window): Avoid overflow in size calculations.
417 Don't update size until allocation succeeds.
418 * fns.c (concat): Check for overflow in size calculations.
419 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
420 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
421 (NEXT_ALMOST_PRIME_LIMIT): New constant.
423 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
424 (get_doc_string): Check for size calculation overflow.
425 Don't update size until allocation succeeds.
426 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
427 EMACS_INT, where ptrdiff_t will do.
428 (Fsubstitute_command_keys): Check for string overflow.
430 * editfns.c (set_time_zone_rule): Don't assume environment length
432 (message_length): Now ptrdiff_t, not int.
433 (Fmessage_box): Don't update size until allocation succeeds.
434 Don't assume message length fits in int.
435 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
437 * emacs.c (main): Do not reallocate argv, since there is a null at
438 the end that can be overwritten, and this way there's no need to
439 worry about size-calculation overflow.
440 (sort_args): Check for size-calculation overflow.
442 * eval.c (init_eval_once, grow_specpdl): Don't update size until
444 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
446 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
447 (x_set_scroll_bar_width, x_figure_window_size):
448 Check for integer overflow.
449 (x_set_alpha): Do not assume XINT fits in int.
451 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
452 This is for the members text_lines, text_cols, total_lines, total_cols,
453 where the system imposes an 'int' limit.
455 * fringe.c (Fdefine_fringe_bitmap):
456 Don't update size until alloc works.
458 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
459 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
461 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
462 Check for size-calculation overflow.
463 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
464 do, as we prefer signed integers.
465 (id_to_widget.max_size, id_to_widget.used)
466 (xg_store_widget_in_map, xg_remove_widget_from_map)
467 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
468 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
469 Use and return ptrdiff_t, not int.
470 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
471 * gtkutil.h: Change prototypes to match the above.
473 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
474 are duplicate now that they've been promoted to lisp.h.
475 (x_allocate_bitmap_record, x_alloc_image_color)
476 (make_image_cache, cache_image, xpm_load):
477 Don't update size until alloc is done.
478 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
480 Check for size calculation overflow.
481 (ct_colors_allocated_max): New constant.
482 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
485 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
486 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
487 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
488 Use ptrdiff_t, not int, to count maps.
489 (read_char_minibuf_menu_prompt): Check for overflow in size
490 calculations. Don't update size until allocation succeeds. Redo
491 calculations to avoid overflow.
492 * keyboard.h: Change prototypes to match the above.
494 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
496 (current_minor_maps): Check for size calculation overflow.
497 * keymap.h: Change prototypes to match the above.
499 * lread.c (read1, init_obarray): Don't update size until alloc done.
501 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
502 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
504 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
505 Now ptrdiff_t, not int.
506 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
507 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
509 * process.c (Fnetwork_interface_list): Check for overflow
512 * region-cache.c (move_cache_gap): Check for size calculation overflow.
514 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
515 overflow. Don't bother calling xmalloc when xrealloc will do.
517 * search.c (Freplace_match): Check for size calculation overflow.
518 (Fset_match_data): Don't assume list lengths fit in 'int'.
520 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
521 for command line length. Do not attempt to address one before the
522 beginning of an array, as that's not portable.
524 * term.c (max_frame_lines): Remove; unused.
525 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
527 (encode_terminal_code, calculate_costs): Check for size
528 calculation overflow.
529 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
530 table lengths and related sizes. Don't update size until alloc
531 done. Redo calculations to avoid overflow.
532 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
534 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
535 subtracting pointers.
536 (gobble_line): Check for overflow more carefully. Don't update size
539 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
540 Don't update size until alloc done.
541 Redo size calculations to avoid overflow.
542 Check for size calculation overflow.
543 (main) [DEBUG]: Fix typo in invoking tparam1.
545 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
546 Use ptrdiff_t, not int, for sizes.
547 (store_mode_line_noprop_char): Don't update size until alloc done.
549 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
550 Use ptrdiff_t, not int, for sizes.
551 (Finternal_make_lisp_face, cache_face):
552 Check for size calculation overflow.
553 (cache_face): Treat size calculation overflows as if they were
554 memory exhaustion (the usual treatment), rather than aborting.
556 * xfns.c (x_encode_text, x_set_name_internal)
557 (Fx_change_window_property): Use ptrdiff_t, not int, to count
558 sizes, since they can exceed INT_MAX in size. Check for size
559 calculation overflow.
561 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
562 (xg_select): Check for size calculation overflow.
563 Don't update size until alloc done.
565 * xrdb.c (get_environ_db): Don't assume path length fits in int,
566 as sprintf is limited to int lengths.
568 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
569 (X_LONG_MIN): New macros.
570 Use them to make the following changes clearer.
571 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
572 This change doesn't affect the value now, but it may help remind
573 future maintainers not to raise the value too much later.
574 (SELECTION_QUANTUM): Remove, replacing with ...
575 (selection_quantum): ... new function, which avoids overflow.
577 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
578 assumption that selection length fits in 'int'.
579 (x_reply_selection_request, x_handle_selection_request)
580 (x_get_window_property, receive_incremental_selection)
581 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
582 (lisp_data_to_selection_data, clean_local_selection_data):
583 Use ptrdiff_t, not int, to record length of selection.
584 (x_reply_selection_request, x_get_window_property)
585 (receive_incremental_selection, x_property_data_to_lisp):
586 Redo calculations to avoid overflow.
587 (x_reply_selection_request): When sending hint, ceiling it at
588 X_LONG_MAX rather than relying on wraparound overflow to send
590 (x_get_window_property, receive_incremental_selection)
591 (lisp_data_to_selection_data, x_property_data_to_lisp):
592 Check for size-calculation overflow.
593 (x_get_window_property, receive_incremental_selection)
594 (lisp_data_to_selection_data, Fx_register_dnd_atom):
595 Don't store size until memory allocation succeeds.
596 (x_get_window_property): Plug memory leak on memory exhaustion.
597 Don't double-block input; malloc is safe here. Don't assume 2**34
598 - 4 fits in unsigned long. Add an xassert to check
599 XGetWindowProperty overflow. Be more careful about overflow
600 calculations, and distinguish size from memory overflow better.
601 (receive_incremental_selection): When tracing, don't assume
602 unsigned int is less than INT_MAX.
603 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
604 harmful) conversions of unsigned short to int.
605 (lisp_data_to_selection_data): Don't assume that integers
606 in the range -65535 through -1 fit in an X unsigned short.
607 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
608 result parameters unless successful. Rely on cons_to_unsigned
609 to report problems with elements; the old code wasn't right anyway.
610 (x_check_property_data): Check for int overflow; we cannot use
611 a wider type due to X limits.
612 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
614 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
616 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
617 (x_term_init): Check for size calculation overflow.
618 (x_color_cells): Don't store size until memory allocation succeeds.
619 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
620 Don't assume alloca size is less than MAX_ALLOCA.
621 (x_term_init): Don't assume length fits in int (sprintf is limited
624 Use ptrdiff_t for composition IDs.
625 * character.c (lisp_string_width):
626 * composite.c (composition_table_size, n_compositions)
627 (get_composition_id, composition_gstring_from_id):
628 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
629 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
630 * window.c (Frecenter):
631 Use ptrdiff_t, not int, for composition IDs.
632 * composite.c (get_composition_id): Check for integer overflow.
633 * composite.h: Adjust prototypes to match the above changes.
635 Use ptrdiff_t for hash table indexes.
636 * category.c (hash_get_category_set):
637 * ccl.c (ccl_driver):
638 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
639 * coding.c (coding_system_charset_list, detect_coding_system):
640 * coding.h (struct coding_system.id):
641 * composite.c (get_composition_id, gstring_lookup_cache):
642 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
643 * image.c (xpm_get_color_table_h):
644 * lisp.h (hash_lookup, hash_put):
645 * minibuf.c (Ftest_completion):
646 Use ptrdiff_t for hash table indexes, not int (which is too
647 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
648 32-bit --with-wide-int hosts).
650 * charset.c (Fdefine_charset_internal): Check for integer overflow.
651 Add a FIXME comment about memory leaks.
652 (syms_of_charset): Don't assume xmalloc returns.
654 Don't assume that stated character widths fit in int.
655 * character.c (Fchar_width, c_string_width, lisp_string_width):
656 * character.h (CHAR_WIDTH):
657 * indent.c (MULTIBYTE_BYTES_WIDTH):
658 Use sanitize_char_width to avoid undefined and/or bad behavior
659 with outlandish widths.
660 * character.h (sanitize_tab_width): Renamed from sanitize_width,
661 now that we have two such functions. All uses changed.
662 (sanitize_char_width): New inline function.
664 Don't assume that tab-width fits in int.
665 * character.h (sanitize_width): New inline function.
666 (SANE_TAB_WIDTH): New macro.
667 (ASCII_CHAR_WIDTH): Use it.
668 * indent.c (sane_tab_width): Remove. All uses replaced by
669 SANE_TAB_WIDTH (current_buffer).
670 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
672 * fileio.c: Integer overflow issues with file modes.
673 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
675 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
676 Remove unreachable code.
677 (read_hex, load_charset_map_from_file): Check for integer overflow.
679 * xterm.c: don't go over XClientMessageEvent limit
680 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
681 (x_send_scroll_bar_event): Likewise. Check that the size does not
682 exceed limits imposed by XClientMessageEvent, as well as the usual
683 ptrdiff_t and size_t limits.
685 * keyboard.c: Overflow, signedness and related fixes.
686 (make_lispy_movement): Use same integer type in forward decl
687 that is used in the definition.
688 (read_key_sequence, keyremap_step):
689 Change bufsize argument back to int, undoing my 2011-03-30 change.
690 We prefer signed types, and int is wide enough here.
691 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
692 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
693 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
694 length, not size_t. Use ptrdiff_t for index, not int.
695 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
696 possibility of integer overflow.
698 Overflow, signedness and related fixes for images.
700 * dispextern.h (struct it.stack[0].u.image.image_id)
701 (struct_it.image_id, struct image.id, struct image_cache.size)
702 (struct image_cache.used, struct image_cache.ref_count):
703 * gtkutil.c (update_frame_tool_bar):
704 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
705 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
706 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
707 * nsmenu.m (update_frame_tool_bar):
708 * xdisp.c (calc_pixel_width_or_height):
709 * xfns.c (image_cache_refcount):
710 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
711 on typical 64-bit hosts.
713 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
714 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
715 Omit unnecessary casts to int.
716 (parse_image_spec): Check that integers fall into 'int' range
717 when the callers expect that.
718 (image_ascent): Redo ascent calculation to avoid int overflow.
719 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
720 (lookup_image): Remove unnecessary tests.
721 (xbm_image_p): Locals are now of int, not EMACS_INT,
722 since parse_image_check makes sure they fit into int.
723 (png_load, gif_load, svg_load_image):
724 Prefer int to unsigned where either will do.
725 (tiff_handler): New function, combining the cores of the
726 old tiff_error_handler and tiff_warning_handler. This
727 function is rewritten to use vsnprintf and thereby avoid
728 stack buffer overflows. It uses only the features of vsnprintf
729 that are common to both POSIX and native Microsoft.
730 (tiff_error_handler, tiff_warning_handler): Use it.
731 (tiff_load, gif_load, imagemagick_load_image):
732 Don't assume :index value fits in 'int'.
733 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
734 (imagemagick_load_image): Check that crop parameters fit into
735 the integer types that MagickCropImage accepts. Don't assume
736 Vimagemagick_render_type has a nonnegative value. Don't assume
737 size_t fits in 'long'.
738 (gs_load): Use printmax_t to print the widest integers possible.
739 Check for integer overflow when computing image height and width.
741 2011-08-26 Eli Zaretskii <eliz@gnu.org>
743 * xdisp.c (redisplay_window): Don't force window start if point
744 will be invisible in the resulting window. (Bug#9324)
746 2011-08-25 Eli Zaretskii <eliz@gnu.org>
748 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
749 the display spec is of the form `(space ...)'.
750 (handle_display_spec): Return the value returned by
751 handle_single_display_spec, not just 1 or zero.
752 (handle_single_display_spec): If the display spec is of the form
753 `(space ...)', and specifies display in the text area, return 2
755 (try_cursor_movement): Check for the need to scroll more
756 accurately, and prefer exact match for point under bidi. Don't
757 advance `row' beyond the last row of the window.
759 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
760 into disp_prop; all users changed.
762 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
763 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
764 for the text covered by the display property.
766 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
768 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
769 Change return value to nil.
770 (Frecord_buffer): Delete unused function.
772 2011-08-24 Eli Zaretskii <eliz@gnu.org>
774 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
775 buffers, return left-to-right.
776 (set_cursor_from_row): Consider candidate row a win if its glyph
777 represents a newline and point is on that newline. Fixes cursor
778 positioning on the newline at EOL of R2L text within L2R
779 paragraph, and vice versa.
780 (try_cursor_movement): Check continued rows, in addition to
781 continuation rows. Fixes unwarranted scroll when point enters a
782 continued line of R2L text within an L2R paragraph, or vice versa.
783 (cursor_row_p): Consider the case of point being equal to
784 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
785 from the end of a short line to the beginning of a continued line
786 of R2L text within L2R paragraph.
787 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
790 * bidi.c (bidi_check_type): Use xassert.
791 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
794 2011-08-23 Eli Zaretskii <eliz@gnu.org>
796 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
799 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
801 * nsfont.m (ns_otf_to_script): Fix typo.
803 2011-08-22 Kenichi Handa <handa@m17n.org>
805 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
806 extra slot even if the purpose is char-code-property-table.
808 2011-08-23 Eli Zaretskii <eliz@gnu.org>
810 * xdisp.c (redisplay_window): When computing centering_position,
811 account for the height of the header line. (Bug#8874)
813 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
814 instead of CHAR_TO_BYTE. Fixes a crash when a completion
815 candidate is selected by the mouse, and that candidate has a
816 composed character under the mouse.
818 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
819 coordinates reported by pos-visible-in-window-p for a composed
820 character in column zero.
822 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
824 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
826 2011-08-22 Eli Zaretskii <eliz@gnu.org>
828 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
829 consider it a hit if to_charpos is anywhere in the range of the
830 composed buffer positions.
832 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
834 * image.c (gif_load): Don't assume that each subimage has the same
835 dimensions as the base image. Handle disposal method that is
836 "undefined" by the gif spec (Bug#9335).
838 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
840 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
841 (Fcondition_case): Document `debug' symbol in error handler.
843 2011-08-19 Eli Zaretskii <eliz@gnu.org>
845 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
846 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
847 from an Org mode buffer to a Speedbar frame.
849 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
850 a composition, take its buffer position from IT->cmp_it.charpos.
851 Fixes cursor positioning at the beginning of a line that begins
852 with a composed character.
854 2011-08-18 Eli Zaretskii <eliz@gnu.org>
856 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
857 character bidirectional type, use STRONG_L instead. Fixes crashes
858 in a buffer produced by `describe-categories'.
860 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
861 members before the level stack, so they would be saved and
862 restored when copying iterator state. Fixes incorrect reordering
863 around TABs covered by display properties.
865 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
867 * process.c (Fnetwork_interface_list): Correctly determine buffer
870 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
872 * eval.c (internal_condition_case, internal_condition_case_1)
873 (internal_condition_case_2, internal_condition_case_n):
874 Remove unnecessary aborts (Bug#9081).
876 2011-08-17 Eli Zaretskii <eliz@gnu.org>
878 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
879 has no `load' handler, try opening the file locally. (Bug#9311)
881 2011-08-16 Ken Brown <kbrown@cornell.edu>
883 * gmalloc.c: Expand comment.
885 2011-08-16 Eli Zaretskii <eliz@gnu.org>
887 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
888 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
890 2011-08-16 Ken Brown <kbrown@cornell.edu>
892 Fix memory allocation problems in Cygwin build (Bug#9273).
894 * unexcw.c ( __malloc_initialized): Declare external variable.
895 (fixup_executable): Force the dumped emacs to reinitialize malloc.
897 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
899 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
901 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
903 [CYGWIN] (special_realloc): New function.
904 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
905 requests to realloc storage in the static heap.
907 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
909 * bidi.c (bidi_initialize): Remove unused local.
911 2011-08-15 Eli Zaretskii <eliz@gnu.org>
913 * biditype.h: File removed.
915 * bidimirror.h: File removed.
917 * deps.mk (bidi.o): Remove biditype.h and
920 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
923 * dispextern.h: Fix a typo in the comment to bidi_type_t.
925 * chartab.c: Improve commentary for the uniprop_table API.
927 * bidi.c (bidi_paragraph_init): Support zero value of
928 bidi_ignore_explicit_marks_for_paragraph_level.
929 (bidi_initialize): Use uniprop_table instead of including
930 biditype.h and bidimirror.h.
932 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
933 coordinates of the iterator when restoring from ppos_it.
936 2011-08-14 Kenichi Handa <handa@m17n.org>
938 * process.c (create_process): Call setup_process_coding_systems
939 after the pid of the process is set to -1 (Bug#8162).
941 2011-08-14 Eli Zaretskii <eliz@gnu.org>
943 * xdisp.c (move_it_in_display_line_to): Don't invoke
944 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
945 ppos_it. Fixes vertical cursor motion when line beginning is
946 covered by an image. (Bug#9296)
948 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
950 * nsterm.h (ns_run_ascript): Declare.
951 (NSAPP_DATA2_RUNASSCRIPT): Define.
953 * nsfns.m (as_script, as_result, as_status): New static variables.
954 (ns_run_ascript): New function.
955 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
956 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
957 the event loop. Get status from as_status (Bug#7276).
959 * nsterm.m (sendEvent): If event is NSApplicationDefined and
960 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
961 the event loop (Bug#7276).
963 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
965 * gnutls.c (QCgnutls_bootprop_priority)
966 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
967 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
968 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
969 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
970 (QCgnutls_bootprop_verify_hostname_error)
971 (QCgnutls_bootprop_callbacks_verify): Rename from
972 Qgnutls_bootprop_..., all uses changed.
974 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
977 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
979 * xfaces.c (Qframe_set_background_mode): Now static.
980 * dispextern.h (Qframe_set_background_mode): Remove decl.
982 * process.c (Fnetwork_interface_info): Declare local only if needed.
984 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
986 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
987 (Fnetwork_interface_list): Allocate in increments of bytes instead
988 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
989 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
991 (struct ifflag_def): notrailers is smart on OSX.
992 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
993 Get hardware address with getifaddrs if available.
995 2011-08-12 Eli Zaretskii <eliz@gnu.org>
997 * xdisp.c (iterate_out_of_display_property): xassert that
998 IT->position is set to within IT->object's boundaries. Break from
999 the loop as soon as EOB is reached; avoids infloops in redisplay
1000 when IT->position is set up wrongly due to some bug.
1001 Set IT->current to match the bidi iterator unconditionally.
1002 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1003 entry. Force push_it to save on the stack the current
1004 buffer/string position, to be restored by pop_it. Fix flags in
1005 the iterator structure wrt the object coming from a display
1006 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1007 properties. (Bug#9284)
1009 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1011 * fontset.c (fontset_get_font_group): Add proper type checks.
1014 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1016 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1017 and LC_VERSION_MIN_MACOSX.
1018 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1019 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1021 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1023 * xdisp.c (forward_to_next_line_start): Allow to use the
1024 no-display-properties-and-no-overlays under bidi display.
1025 Set disp_pos in the bidi iterator to avoid searches for display
1026 properties and overlays.
1028 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1030 * editfns.c (Fset_time_zone_rule): Document relationship with the
1033 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1034 the font entity extracted from the cache (Bug#8109).
1036 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1038 * composite.c (autocmp_chars): Don't reset point. That is done by
1039 restore_point_unwind (Bug#5984).
1041 2011-08-07 Juri Linkov <juri@jurta.org>
1043 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1044 to show the arg `TIME' instead of `TIMEVAL'.
1046 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1048 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1049 display property strides EOL and includes a newline, as in
1050 longlines-mode. (Bug#9254)
1051 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1052 word-wrap under bidirectional display. (Bug#9224)
1054 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1055 is non-zero, even if the data buffer is NULL. Fixes a crash in
1056 vertical-motion with longlines-mode. (Bug#9254)
1058 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1060 * bidi.c <bidi_cache_total_alloc>: Now static.
1061 (bidi_initialize): Initialize bidi_cache_total_alloc.
1063 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1066 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1067 amount allocated this far in `bidi_cache_total_alloc'.
1068 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1069 non-zero, only free the data buffer without restoring the cache
1070 contents. All callers changed.
1072 * dispextern.h (bidi_unshelve_cache): Update prototype.
1074 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1075 (move_it_in_display_line, move_it_to)
1076 (move_it_vertically_backward, move_it_by_lines): Replace the call
1077 to xfree to an equivalent call to bidi_unshelve_cache.
1078 (move_it_in_display_line_to): Fix logic of returning
1079 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1081 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1083 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1084 came from a string character with a `cursor' property. (Bug#9229)
1086 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1088 * Makefile.in (LIB_PTHREAD): New variable.
1089 (LIBES): Add LIB_PTHREAD (Bug#9216).
1091 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1092 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1094 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1096 * regex.c (re_iswctype): Remove some redundant boolean
1099 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1101 * xterm.c (x_find_topmost_parent): New function.
1102 (x_set_frame_alpha): Find topmost parent window with
1103 x_find_topmost_parent and set the property there also (bug#9181).
1104 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1106 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1108 * callproc.c (Fcall_process): Avoid vfork clobbering
1109 the local vars buffer, coding_systems, current_dir.
1111 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1113 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1115 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1117 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1118 so that it is not optimized away.
1120 * xdisp.c (compute_display_string_pos): Remove unused local.
1122 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1124 Fix slow cursor motion and scrolling in large buffers with
1125 selective display, like Org Mode buffers. (Bug#9218)
1127 * dispextern.h (struct bidi_it): New member disp_prop_p.
1129 * xdisp.c: Remove one-slot cache of display string positions.
1130 (compute_display_string_pos): Accept an additional argument
1131 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1132 for a display string or property. If found, set DISP_PROP_P
1135 * bidi.c (bidi_fetch_char): Accept an additional argument
1136 DISP_PROP_P, and pass it to compute_display_string_pos.
1137 Only handle text covered by a display string if DISP_PROP_P is returned
1138 non-zero. All callers of bidi_fetch_char changed.
1140 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1142 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1144 2010-12-03 Don March <don@ohspite.net>
1146 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1147 last character M-[char] is translated to ESC [char] (bug#7541).
1149 2011-08-02 Kenichi Handa <handa@m17n.org>
1151 * lisp.h (uniprop_table): Extern it.
1153 * chartab.c (uniprop_table): Make it non-static.
1155 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1157 * xdisp.c (forward_to_next_line_start): Accept additional argument
1158 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1160 (reseat_at_next_visible_line_start): Use the bidi iterator state
1161 returned by forward_to_next_line_start to restore the state of
1162 it->bidi_it after backing up to previous newline. (Bug#9212)
1164 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1166 * regex.c (re_comp): Protoize.
1167 (re_exec): Fix return type.
1168 (regexec): Fix type of `ret'. (Bug#9203)
1170 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1172 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1173 This is needed if max-image-size is a floating-point number.
1175 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1177 * print.c (print_object): Print empty symbol as ##.
1179 * lread.c (read1): Read ## as empty symbol.
1181 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1183 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1184 setting frame foreground color (Bug#9175).
1185 (x_set_background_color): Likewise.
1187 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1188 contents (Bug#9176).
1189 (EmacsTooltip -init): Remove bezels and add shadows to
1192 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1193 or scroll bar (Bug#8470).
1195 * nsfont.m (nsfont_open): Remove assignment to voffset and
1196 unnecessary vars hshink, expand, hd, full_height, min_height.
1197 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1199 * nsterm.h (nsfont_info): Remove voffset field.
1201 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1203 Implement strike-through and overline on NextStep (Bug#8863).
1205 * nsfont.m (nsfont_open): Use underline position provided by font,
1206 instead of hard-coded value of 2.
1207 (nsfont_draw): Call ns_draw_text_decoration instead.
1209 * nsterm.h: Add declaration for ns_draw_text_decoration.
1211 * nsterm.m (ns_draw_text_decoration): New function for drawing
1212 underline, overline, and strike-through.
1213 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1214 ns_draw_text_decoration. Change treatment of cursor drawing to
1215 accomodate underlining, etc.
1217 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1219 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1222 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1224 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1225 Without this fix, if a signal arrives just after memory fills up,
1226 'malloc' might be invoked reentrantly.
1228 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1229 In other words, assume that every image size is allowed, on non-X
1230 hosts. This assumption is probably wrong, but it lets Emacs compile.
1232 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1234 * regex.c (re_iswctype): Convert return values to boolean.
1236 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1238 * xdisp.c (compute_display_string_pos): Don't use cached display
1239 string position if the buffer had its restriction changed.
1242 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1244 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1246 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1248 Integer signedness and overflow and related fixes. (Bug#9079)
1250 * bidi.c: Integer size and overflow fixes.
1251 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1252 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1253 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1254 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1255 (bidi_find_other_level_edge):
1256 Use ptrdiff_t instead of EMACS_INT where either will do.
1257 This works better on 32-bit hosts configured --with-wide-int.
1258 (bidi_cache_ensure_space): Check for size-calculation overflow.
1259 Use % rather than repeated addition, for better worst-case speed.
1260 Don't set bidi_cache_size until after xrealloc returns, because it
1262 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1263 (bidi_cache_ensure_space): Also check that the bidi cache size
1264 does not exceed that of the largest Lisp string or buffer. See Eli
1265 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1267 * alloc.c (__malloc_size_t): Remove.
1268 All uses replaced by size_t. See Andreas Schwab's note
1269 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1271 * image.c: Improve checking for integer overflow.
1272 (check_image_size): Assume that f is nonnull, since
1273 it is always nonnull in practice. This is one less thing to
1274 worry about when checking for integer overflow later.
1275 (x_check_image_size): New function, which checks for integer
1276 overflow issues inside X.
1277 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1278 This removes the need for a memory_full check.
1279 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1280 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1281 (xbm_read_bitmap_data): Change locals back to 'int', since
1282 their values must fit in 'int'.
1283 (xpm_load_image, png_load, tiff_load):
1284 Invoke x_create_x_image_and_pixmap earlier,
1285 to avoid much needless work if the image is too large.
1286 (tiff_load): Treat overly large images as if
1287 x_create_x_image_and_pixmap failed, not as malloc failures.
1288 (gs_load): Use x_check_image_size.
1290 * gtkutil.c: Omit integer casts.
1291 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1292 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1294 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1296 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1297 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1298 would wrongly return t on a 64-bit host.
1300 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1301 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1302 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1303 and therefore cause GCC to emit a bogus diagnostic in some cases.
1305 * image.c: Integer signedness and overflow and related fixes.
1306 This is not an exhaustive set of fixes, but it's time to
1307 record what I've got.
1308 (lookup_pixel_color, check_image_size): Remove redundant decls.
1309 (check_image_size): Don't assume that arbitrary EMACS_INT values
1310 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1311 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1312 (tiff_load, imagemagick_load_image):
1313 Check for overflow in size calculations.
1314 (x_create_x_image_and_pixmap): Remove unnecessary test for
1315 xmalloc returning NULL; that can't happen.
1316 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1317 (xpm_color_bucket): Use better integer hashing function.
1318 (xpm_cache_color): Don't possibly over-allocate memory.
1319 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1320 (gif_memory_source):
1321 Use ptrdiff_t, not int or size_t, to record sizes.
1322 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1323 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1324 either works, as we prefer signed integers.
1325 (tiff_read_from_memory, tiff_write_from_memory):
1326 Return tsize_t, not size_t, since that's what the TIFF API wants.
1327 (tiff_read_from_memory): Don't fail simply because the read would
1328 go past EOF; instead, return a short read.
1329 (tiff_load): Omit no-longer-needed casts.
1330 (Fimagemagick_types): Don't assume size fits into 'int'.
1332 Improve hashing quality when configured --with-wide-int.
1333 * fns.c (hash_string): New function, taken from sxhash_string.
1334 Do not discard information about ASCII character case; this
1335 discarding is no longer needed.
1336 (sxhash-string): Use it. Change sig to match it. Caller changed.
1337 * lisp.h: Declare it.
1338 * lread.c (hash_string): Remove, since we now use fns.c's version.
1339 The fns.c version returns a wider integer if --with-wide-int is
1340 specified, so this should help the quality of the hashing a bit.
1342 * emacs.c: Integer overflow minor fix.
1343 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1344 Define only if GNU_LINUX.
1345 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1347 * dispnew.c: Integer signedness and overflow fixes.
1348 Remove unnecessary forward decls, that were a maintenance hassle.
1349 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1351 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1352 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1353 (prepare_desired_row, line_draw_cost):
1354 Use int, not unsigned, where either works.
1355 (save_current_matrix, restore_current_matrix):
1356 Use ptrdiff_t, not size_t, where either works.
1357 (init_display): Check for overflow more accurately, and without
1358 relying on undefined behavior.
1360 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1361 Remove, replacing with the new symbols in lisp.h. All uses changed.
1362 * fileio.c (make_temp_name):
1363 * filelock.c (lock_file_1, lock_file):
1364 * xdisp.c (message_dolog):
1365 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1366 Use pMd etc. instead.
1367 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1368 replacing the pWIDE etc. symbols removed from editfns.c.
1370 * keyboard.h (num_input_events): Now uintmax_t.
1371 This is (very slightly) less likely to mess up due to wraparound.
1374 * buffer.c: Integer signedness fixes.
1375 (alloc_buffer_text, enlarge_buffer_text):
1376 Use ptrdiff_t rather than size_t when either will do, as we prefer
1379 * alloc.c: Integer signedness and overflow fixes.
1380 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1381 (__malloc_size_t): Default to size_t, not to int.
1382 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1383 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1384 Prefer ptrdiff_t to size_t when either would do, as we prefer
1386 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1387 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1388 Now const. Initialize with values that are in range even if char
1390 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1391 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1392 These functions do the right thing with sizes > 2**32.
1393 (check_depth): Now ptrdiff_t, not int.
1394 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1395 Adjust to new way of storing sizes. Check for size overflow bugs
1397 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1398 slightly wrong anyway, as it missed one instance of
1399 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1400 (refill_memory_reserve): Omit needless cast to size_t.
1401 (mark_object_loop_halt): Mark as externally visible.
1403 * xselect.c: Integer signedness and overflow fixes.
1404 (Fx_register_dnd_atom, x_handle_dnd_message):
1405 Use ptrdiff_t, not size_t, since we prefer signed.
1406 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1407 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1408 x_dnd_atoms_size and x_dnd_atoms_length.
1410 * doprnt.c: Prefer signed to unsigned when either works.
1412 * doprnt.c (doprnt):
1414 * xdisp.c (vmessage):
1415 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1416 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1417 prefer signed arithmetic to avoid comparison confusion.
1418 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1419 but is a bit tricky.
1421 Assume freestanding C89 headers, string.h, stdlib.h.
1422 * data.c, doprnt.c, floatfns.c, print.c:
1423 Include float.h unconditionally.
1424 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1425 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1426 * regex.c: Likewise for stddef.h, string.h.
1427 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1428 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1429 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1430 (STDC_HEADERS): Remove obsolete defines.
1431 * sysdep.c: Include limits.h unconditionally.
1433 Assume support for memcmp, memcpy, memmove, memset.
1434 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1435 * regex.c (memcmp, memcpy):
1436 Remove; we assume C89 now.
1438 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1439 (__malloc_safe_bcopy): Remove; no longer needed.
1441 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1442 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1443 well either way, and we prefer signed to unsigned.
1445 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1447 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1448 closes the connection while we're reading (bug#9182).
1450 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1452 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1453 are specified (Bug#9168).
1455 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1457 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1458 Found by GCC static checking and --with-wide-int on a 32-bit host.
1460 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1462 * xdisp.c (compute_display_string_pos): Fix logic of caching
1463 previous display string position. Initialize cached_prev_pos to
1464 -1. Fixes slow-down at the beginning of a buffer.
1466 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1468 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1469 for attrs[LFACE_FONTSET_INDEX].
1471 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1473 * xml.c (parse_region): Remove unused local
1474 that was recently introduced.
1476 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1478 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1479 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1481 * xdisp.c (move_it_in_display_line_to): Record the best matching
1482 position for TO_CHARPOS while scanning the line, and restore it on
1483 exit if none of the characters scanned was an exact match.
1484 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1485 when exact match is impossible due to invisible text, and the
1486 lines are truncated.
1488 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1490 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1493 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1495 Fix a significant slow-down of cursor motion with C-n, C-p,
1496 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1497 auto-repeat under bidi redisplay in fontified buffers.
1498 * xdisp.c (compute_stop_pos_backwards): New function.
1499 (next_element_from_buffer): Call compute_stop_pos_backwards to
1500 find a suitable prev_stop when we find ourselves before
1502 (reseat): Don't look for prev_stop, as that could mean a very long
1504 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1505 <cached_disp_overlay_modiff>: Cache for last found display string
1507 (compute_display_string_pos): Return the cached position if asked
1508 about the same buffer in the same area of character positions, and
1509 the buffer wasn't changed since the time the display string
1510 position was cached.
1512 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1514 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1515 is an integer, which is important for empty lines. (Bug#9149)
1517 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1519 * frame.c (Fmodify_frame_parameters): In tty case, update the
1520 default face if necessary (Bug#4238).
1522 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1524 * editfns.c (Fstring_to_char): No need to explain what a character
1525 is in the docstring (Bug#6576).
1527 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1529 * xml.c (parse_region): Make sure we always return a tree.
1531 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1533 * xml.c (parse_region): If a document contains only comments,
1536 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1538 * xml.c (make_dom): Return comments, too.
1540 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1543 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1544 and the surrounding thread.
1545 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1546 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1547 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1549 * s/openbsd.h (BROKEN_SIGIO): Define.
1550 * unexelf.c (unexec) [__OpenBSD__]:
1551 Don't update the .mdebug section of the Alpha COFF symbol table.
1553 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1555 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1558 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1560 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1561 This fixes some race conditions on the permissions of any newly
1564 * alloc.c (valid_pointer_p): Use pipe, not open.
1565 This fixes some permissions issues when debugging.
1567 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1568 If fchown fails to set both uid and gid, try to set just gid,
1569 as that is sometimes allowed. Adjust the file's mode to eliminate
1570 setuid or setgid bits that are inappropriate if fchown fails.
1572 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1574 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1575 to compare Lisp_Objects.
1576 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1577 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1578 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1580 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1582 * lread.c (read_integer): Unread even EOF character.
1583 (read1): Likewise. Properly record start position of symbol.
1585 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1586 symbol character follows.
1588 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1590 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1591 This works around a problem with the previous change to Fcopy_file.
1592 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1593 and without this change, GCC might complain about discarding
1594 fchown's return value.
1596 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1598 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1600 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1602 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1604 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1606 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1607 it's used from the C level.
1609 * process.c: Use the same condition for POLL_FOR_INPUT in both
1610 keyboard.c and process.c (bug#1858).
1612 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1614 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1615 (Fgnutls_boot): Use it.
1617 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1619 * doc.c (Fsubstitute_command_keys): Revert last change.
1621 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1623 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1624 quotes the next character, and doesn't affect other longer
1625 sequences (bug#8935).
1627 * lread.c (syms_of_lread): Clarify that is isn't only
1628 `eval-buffer' and `eval-defun' that's affected by
1629 `lexical-binding' (bug#8460).
1631 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1633 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1634 bidi redisplay when a line includes both an image and is
1637 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1639 Fix minor problems found by static checking.
1640 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1641 (elsz): Now a signed constant, not a size_t var. We prefer signed
1642 types to unsigned, to avoid integer comparison confusion. Without
1643 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1644 "cannot optimize loop, the loop counter may overflow", a symptom
1646 * indent.c (Fvertical_motion): Mark locals as initialized.
1647 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1649 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1651 * search.c (Fre_search_backward): Mention `case-fold-search' in
1652 all the re_search_* functions (bug#8138).
1654 * keyboard.c (Fopen_dribble_file): Document when the file is
1657 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1659 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1662 Support bidi reordering of display and overlay strings.
1663 * xdisp.c (compute_display_string_pos)
1664 (compute_display_string_end): Accept additional argument STRING.
1665 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1666 (reseat_to_string): Initialize bidi_it->string.s and
1667 bidi_it->string.schars.
1668 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1669 NULL (avoids a crash in bidi_paragraph_init).
1670 Initialize itb.string.lstring.
1671 (init_iterator): Call bidi_init_it only of a valid
1672 buffer position was specified. Initialize paragraph_embedding to
1674 (reseat_to_string): Initialize the bidi iterator.
1675 (display_string): If we need to ignore text properties of
1676 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1677 original value of -1 will not work with bidi.)
1678 (compute_display_string_pos): First arg is now struct
1679 `text_pos *'; all callers changed. Support display properties on
1681 (compute_display_string_end): Support display properties on Lisp
1683 (init_iterator, reseat_1, reseat_to_string): Initialize the
1684 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1685 when iterating on a string not from display properties).
1686 (compute_display_string_pos, compute_display_string_end):
1687 Fix calculation of the object to scan. Fixes an error when using
1689 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1690 base_level_stop; instead, set base_level_stop to BEGV.
1691 Fixes crashes in vertical-motion.
1692 (next_element_from_buffer): Improve commentary for when
1693 the iterator is before prev_stop.
1694 (init_iterator): Initialize bidi_p from the default value of
1695 bidi-display-reordering, not from buffer-local value. Use the
1696 buffer-local value only if initializing for buffer iteration.
1697 (handle_invisible_prop): Support invisible properties on strings
1698 that are being bidi-reordered.
1699 (set_iterator_to_next): Support bidi reordering of C strings and
1701 (next_element_from_string): Support bidi reordering of Lisp
1703 (handle_stop_backwards): Support Lisp strings as well.
1704 (display_string): Support display of R2L glyph rows.
1705 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1706 (init_iterator): Don't initialize it->bidi_p for strings
1708 (reseat_to_string): Initialize it->bidi_p for strings here.
1709 (next_element_from_string, next_element_from_c_string)
1710 (next_element_from_buffer): Add xassert's for correspondence
1711 between IT's object being iterated and it->bidi_it.string
1713 (face_before_or_after_it_pos): Support bidi iteration.
1714 (next_element_from_c_string): Handle the case of the first string
1715 character that is not the first one in the visual order.
1716 (get_visually_first_element): New function, refactored from common
1717 parts of next_element_from_buffer, next_element_from_string, and
1718 next_element_from_c_string.
1719 (tool_bar_lines_needed, redisplay_tool_bar)
1720 (display_menu_bar): Force left-to-right direction. Add a FIXME
1721 comment for making that be controlled by a user option.
1722 (push_it, pop_it): Save and restore the state of the
1723 bidi iterator. Save and restore the bidi_p flag.
1724 (pop_it): Iterate out of display property for string iteration as
1726 (iterate_out_of_display_property): Support iteration over strings.
1727 (handle_single_display_spec): Set up it->bidi_it for iteration
1728 over a display string, and call bidi_init_it.
1729 (handle_single_display_spec, next_overlay_string)
1730 (get_overlay_strings_1, push_display_prop): Set up the bidi
1731 iterator for displaying display or overlay strings.
1732 (forward_to_next_line_start): Don't use the shortcut if
1734 (back_to_previous_visible_line_start): If handle_display_prop
1735 pushed the iterator stack, restore the internal state of the bidi
1736 iterator by calling bidi_pop_it same number of times.
1737 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1738 and we are bidi-iterating, don't decrement the iterator position;
1739 instead, set the first_elt flag in the bidi iterator, to produce
1741 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1742 (push_display_prop): xassert that we are iterating a buffer.
1743 (push_it, pop_it): Save and restore paragraph_embedding member.
1744 (handle_single_display_spec, next_overlay_string)
1745 (get_overlay_strings_1, reseat_1, reseat_to_string)
1746 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1747 correctly. Don't assume unibyte strings are not bidi-reordered.
1748 (compute_display_string_pos)
1749 (compute_display_string_end): Fix handling the case of C string.
1750 (push_it, pop_it): Save and restore from_disp_prop_p.
1751 (handle_single_display_spec, push_display_prop): Set the
1752 from_disp_prop_p flag.
1753 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1754 (pop_it): Call iterate_out_of_display_property only if we are
1755 popping after iteration over a string that came from a display
1756 property. Fix a typo in popping stretch info. Add an assertion
1757 for verifying that the iterator position is in sync with the bidi
1759 (handle_single_display_spec, get_overlay_strings_1)
1760 (push_display_prop): Fix initialization of paragraph direction for
1761 string when that of the parent object is not yet determined.
1762 (reseat_1): Call bidi_init_it to resync the bidi
1763 iterator with IT's position. (Bug#7616)
1764 (find_row_edges): If ROW->start.pos gives position
1765 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1766 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1767 Reset the from_disp_prop_p flag.
1768 (SAVE_IT, RESTORE_IT): New macros.
1769 (pos_visible_p, face_before_or_after_it_pos)
1770 (back_to_previous_visible_line_start)
1771 (move_it_in_display_line_to, move_it_in_display_line)
1772 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1773 (try_scrolling, redisplay_window, display_line): Use them when
1774 saving a temporary copy of the iterator and restoring it back.
1775 (back_to_previous_visible_line_start, reseat_1)
1776 (init_iterator): Empty the bidi cache "stack".
1777 (move_it_in_display_line_to): If iterator ended up at
1778 EOL, but we never saw any buffer positions smaller than
1779 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1780 motion in bidi-reordered lines.
1781 (move_it_in_display_line_to): Record prev_method and prev_pos
1782 immediately before the call to set_iterator_to_next. Fixes cursor
1783 motion in bidi-reordered lines with stretch glyphs and strings
1784 displayed in margins. (Bug#8133) (Bug#8867)
1785 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1787 (pos_visible_p): Support positions in bidi-reordered lines.
1788 Save and restore bidi cache.
1790 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1791 (bidi_paragraph_info): Delete unused struct.
1792 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1793 (bidi_cache_start): New variable.
1794 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1796 (bidi_cache_fetch_state, bidi_cache_search)
1797 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1798 (bidi_cache_find, bidi_peek_at_next_level)
1799 (bidi_level_of_next_char, bidi_find_other_level_edge)
1800 (bidi_move_to_visually_next): Compare cache index with
1801 bidi_cache_start rather than with zero.
1802 (bidi_fetch_char): Accept new argument STRING; all callers
1803 changed. Support iteration over a string. Support strings with
1804 display properties. Support unibyte strings. Fix the type of
1805 `len' according to what STRING_CHAR_AND_LENGTH expects.
1806 (bidi_paragraph_init, bidi_resolve_explicit_1)
1807 (bidi_resolve_explicit, bidi_resolve_weak)
1808 (bidi_level_of_next_char, bidi_move_to_visually_next):
1809 Support iteration over a string.
1810 (bidi_set_sor_type, bidi_resolve_explicit_1)
1811 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1812 can now be zero (for strings); special values 0 and -1 were
1813 changed to -1 and -2, respectively.
1814 (bidi_char_at_pos): New function.
1815 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1816 Call it instead of FETCH_MULTIBYTE_CHAR.
1817 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1818 initialized to valid values.
1819 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1821 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1822 the test for valid cached positions. Fix the logic for looking up
1823 the sentinel state in the cache. GCPRO the Lisp string we are
1825 (bidi_push_it, bidi_pop_it): New functions.
1826 (bidi_initialize): Initialize the bidi cache start stack pointer.
1827 (bidi_cache_ensure_space): New function, refactored from part of
1828 bidi_cache_iterator_state. Don't assume the required size is just
1829 one BIDI_CACHE_CHUNK away.
1830 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1831 (bidi_count_bytes, bidi_char_at_pos): New functions.
1832 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1833 always valid if bidi_cache_idx is valid.
1834 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1835 is valid if it's going to be used.
1836 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1837 (bidi_cache_fetch_state, bidi_cache_search)
1838 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1839 (bidi_cache_iterator_state, bidi_cache_find)
1840 (bidi_find_other_level_edge, bidi_cache_start_stack):
1841 All variables related to cache indices are now EMACS_INT.
1843 * dispextern.h (struct bidi_string_data): New structure.
1844 (struct bidi_it): New member `string'. Make flag members be 1-bit
1845 fields, and put them last in the struct.
1846 (compute_display_string_pos, compute_display_string_end):
1848 (bidi_push_it, bidi_pop_it): Add prototypes.
1849 (struct iterator_stack_entry): New members bidi_p,
1850 paragraph_embedding, and from_disp_prop_p.
1851 (struct it): Member bidi_p is now a bit field 1 bit wide.
1852 (bidi_shelve_cache, bidi_unshelve_cache):
1855 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1856 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1857 and vector-like objects.
1859 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1860 cache around display iteration.
1862 * window.c (Fwindow_end, window_scroll_pixel_based)
1863 (displayed_window_lines, Frecenter): Save and restore the bidi
1864 cache around display iteration.
1866 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1868 * editfns.c (Fdelete_region): Clarify the use of the named
1869 parameters (bug#6788).
1871 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1873 * indent.c (Fvertical_motion): Set and restore w->pointm when
1874 saving and restoring the window's buffer (Bug#9006).
1876 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1878 * editfns.c (Fstring_to_char): Clarify just what is returned
1879 (bug#6576). Text by Eli Zaretskii.
1881 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1883 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1885 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1887 * buffer.c (mmap_find): Fix a typo.
1889 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1891 Fix execution of x selection hooks.
1892 * xselect.c (Qx_lost_selection_functions)
1893 (Qx_sent_selection_functions): New vars.
1894 (syms_of_xselect): DEFSYM them.
1895 (x_handle_selection_request): Pass Qx_sent_selection_functions
1896 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1897 (x_handle_selection_clear,x_clear_frame_selections):
1898 Pass Qx_lost_selection_functions rather than
1899 Vx_lost_selection_functions to Frun_hook_with_args.
1901 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1903 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1904 The old code sometimes used this field without initializing it.
1906 * alloc.c (gc_sweep): Don't read past end of array.
1907 In theory, the old code could also have corrupted Emacs internals,
1908 though it'd be very unlikely.
1910 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1912 * character.c (Fcharacterp): Don't advertise optional ignored
1913 argument. (Bug#4026)
1915 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1917 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1920 * window.c (Fset_window_start): Doc fix (bug#4199).
1921 (Fset_window_hscroll): Ditto.
1923 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1925 Fix minor new problems caught by GCC 4.6.1.
1926 * term.c (init_tty): Remove unused local.
1927 * xsettings.c (store_monospaced_changed): Define this function only
1928 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1931 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1933 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1935 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1937 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1938 are the mini-buffer and the echo area (bug#3320).
1940 * term.c (init_tty): Remove support for supdup, c10 and perq
1941 terminals, which are no longer supported (bug#1482).
1943 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1945 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1947 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1949 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1950 for non-popups (Bug#3642).
1952 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1954 * alloc.c (reset_malloc_hooks): Protoize.
1955 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1956 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1957 * cm.c (losecursor): Likewise.
1958 * data.c (fmod): Likewise.
1959 * dispnew.c (swap_glyphs_in_rows): Likewise.
1960 * emacs.c (memory_warning_signal): Likewise.
1961 * floatfns.c (float_error): Likewise.
1962 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1963 (otf_open, font_otf_capability, generate_otf_features)
1964 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1966 * image.c (pbm_read_file): Likewise.
1967 * indent.c (string_display_width): Likewise.
1968 * intervals.c (check_for_interval, search_for_interval)
1969 (inc_interval_count, count_intervals, root_interval)
1970 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1971 * lread.c (defalias): Likewise.
1972 * ralloc.c (r_alloc_check): Likewise.
1973 * regex.c (set_image_of_range_1, set_image_of_range)
1974 (regex_grow_registers): Likewise.
1975 * sysdep.c (strerror): Likewise.
1976 * termcap.c (valid_filename_p, tprint, main): Likewise.
1977 * tparam.c (main): Likewise.
1978 * unexhp9k800.c (run_time_remap, save_data_space)
1979 (update_file_ptrs, read_header, write_header, calculate_checksum)
1980 (copy_file, copy_rest, display_header): Likewise.
1981 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1983 * xdisp.c (check_it): Likewise.
1984 * xfaces.c (register_color, unregister_color, unregister_colors):
1986 * xfns.c (print_fontset_result): Likewise.
1987 * xrdb.c (member, fatal, main): Likewise.
1989 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1991 Fix minor problems found by static checking (Bug#9031).
1992 * chartab.c (char_table_set_range, map_sub_char_table):
1993 Remove unused locals.
1994 (uniprop_table): Now static.
1995 * composite.c (_work_char): Remove unused static var.
1997 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1999 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2001 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2003 * gtkutil.c (qttip_cb): Remove code without function.
2005 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2007 * w32.c (pthread_sigmask): New stub.
2009 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2011 Use pthread_sigmask, not sigprocmask (Bug#9010).
2012 sigprocmask is portable only for single-threaded applications, and
2013 Emacs can be multi-threaded when it uses GTK.
2014 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2016 * callproc.c (Fcall_process):
2017 * process.c (create_process):
2018 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2019 Use pthread_sigmask, not sigprocmask.
2021 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2023 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2024 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2027 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2029 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2030 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2031 (xg_hide_tooltip): Fix comment.
2033 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2034 in registerServicesMenuSendTypes.
2035 (validRequestorForSendType): Don't check ns_return_types.
2037 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2040 2011-07-08 Jason Rumney <jasonr@gnu.org>
2042 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2043 frame struct members of non-existent frames (Bug#6284).
2045 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2047 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2048 variable firstTime not needed on OSX >= 10.6.
2049 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2050 >= 10.5. Use setKnobProportion, setDoubleValue.
2052 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2053 (MAC_OS_X_VERSION_10_5): Define if not defined.
2054 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2055 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2056 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2058 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2059 cString and lossyCString on OSX >= 10.4
2061 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2062 sizeToFit on OSX >= 10.2.
2064 * nsimage.m (allocInitFromFile): Don't use deprecated method
2065 bestRepresentationForDevice on OSX >= 10.6.
2067 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2070 * emacs.c: Declare unexec_init_emacs_zone.
2072 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2074 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2076 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2077 on svcsMenu (Bug#8842).
2079 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2081 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2083 * nsterm.m (QUTF8_STRING): Declare.
2084 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2085 (validRequestorForSendType): Return type is (id).
2086 Change indexOfObjectIdenticalTo to indexOfObject.
2087 Check if we have local selection before returning self (Bug#8842).
2088 (writeSelectionToPasteboard): Put local selection into paste board
2089 if we have a local selection (Bug#8842).
2090 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2092 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2093 (ns_get_local_selection): Declare.
2095 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2097 * keymap.c (describe_map_tree): Don't insert a double newline at
2098 the end of the buffer (bug#1169) and return whether we inserted
2101 * callint.c (Fcall_interactively): Change "reading args" to
2102 "providing args" to try to clarify what it does (bug#1010).
2104 2011-07-07 Kenichi Handa <handa@m17n.org>
2106 * composite.c (composition_compute_stop_pos): Ignore a static
2107 composition starting before CHARPOS (Bug#8915).
2109 * xdisp.c (handle_composition_prop): Likewise.
2111 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2113 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2116 2011-07-07 Kenichi Handa <handa@m17n.org>
2118 * character.h (unicode_category_t): New enum type.
2120 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2121 (Qchar_code_property_table): New variable.
2122 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2123 (UNIPROP_COMPRESSED_FORM_P): New macros.
2124 (char_table_ascii): Uncompress the compressed values.
2125 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2126 Uncompress the compressed values.
2127 (sub_char_table_ref_and_range): Likewise.
2128 (char_table_ref_and_range): Uncompress the compressed values.
2129 (sub_char_table_set): New arg is_uniprop. Callers changed.
2130 Uncompress the compressed values.
2131 (sub_char_table_set_range): Args changed. Callers changed.
2132 (char_table_set_range): Adjuted for the above change.
2133 (map_sub_char_table): Delete args default_val and parent. Add arg
2134 top. Give decoded values to a Lisp function.
2135 (map_char_table): Adjust for the above change. Give decoded
2136 values to a Lisp function. Gcpro more variables.
2137 (uniprop_table_uncompress)
2138 (uniprop_decode_value_run_length): New functions.
2139 (uniprop_decoder, uniprop_decoder_count): New variables.
2140 (uniprop_get_decoder, uniprop_encode_value_character)
2141 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2143 (uniprop_encoder, uniprop_encoder_count): New variables.
2144 (uniprop_get_encoder, uniprop_table)
2145 (Funicode_property_table_internal, Fget_unicode_property_internal)
2146 (Fput_unicode_property_internal): New functions.
2147 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2148 Sunicode_property_table_internal, Sget_unicode_property_internal,
2149 and Sput_unicode_property_internal. Defvar_lisp
2150 char-code-property-alist.
2152 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2153 Vunicode_category_table.
2155 * font.c (font_range): Adjust for the change of
2156 Vunicode_category_table.
2158 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2160 * m/iris4d.h: Remove file, move contents ...
2161 * s/irix6-5.h: ... here.
2163 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2165 Remove unportable assumption about struct layout (Bug#8884).
2166 * alloc.c (mark_buffer):
2167 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2168 (clone_per_buffer_values): Don't assume that
2169 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2170 This isn't true in general, and it's particularly not true
2171 if Emacs is configured with --with-wide-int.
2172 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2173 New macros, used in the buffer.c change.
2175 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2177 * xsettings.c: Use both GConf and GSettings if both are available.
2178 (store_config_changed_event): Add comment.
2179 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2180 (store_tool_bar_style_changed): New functions.
2181 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2182 (struct xsettings): Move font inside HAVE_XFT.
2183 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2184 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2185 Move inside HAVE_XFT.
2186 (something_changed_gsettingsCB): Rename from something_changedCB.
2187 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2189 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2190 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2191 (something_changed_gconfCB): Rename from something_changedCB.
2192 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2193 (parse_settings): Move check for font inside HAVE_XFT.
2194 (read_settings, apply_xft_settings): Add comment.
2195 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2196 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2197 call store_font_name_changed.
2198 (xft_settings_event): Add comment.
2199 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2200 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2201 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2202 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2203 (xsettings_initialize): Call init_gsettings last.
2204 (xsettings_get_system_font, xsettings_get_system_normal_font):
2207 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2209 Random fixes. E.g., (random) never returned negative values.
2210 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2211 subseconds part to the entropy, as that's a bit more random.
2212 Prefer signed to unsigned, since the signedness doesn't matter and
2213 in general we prefer signed. When given a limit, use a
2214 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2215 latter isn't right if USE_2_TAGS_FOR_INTS.
2216 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2217 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2219 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2221 * textprop.c (text_property_stickiness):
2222 Obey Vtext_property_default_nonsticky.
2223 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2224 * w32fns.c (syms_of_w32fns):
2225 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2227 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2229 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2230 This is more efficient than Ffile_directory_p and avoids a minor race.
2232 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2234 * buffer.c (Foverlay_put): Say what the return value is
2237 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2238 is a directory before asking whether to use the file name
2240 (barf_or_query_if_file_exists): Make the "File is a directory"
2241 error be more correct.
2243 * fns.c (Frequire): Remove the mention of the .gz files, since
2244 that's installation-specific, but keep the mention of
2245 `get-load-suffixes'.
2247 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2249 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2250 Report string overflow if the output is too long.
2252 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2254 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2255 (syms_of_gnutls): Remove duplicate DEFSYM for
2256 Qgnutls_bootprop_verify_hostname_error, an error for
2257 Qgnutls_bootprop_verify_error (which is no longer used).
2259 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2260 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2261 Also (re)move comments that are misplaced or no longer relevant.
2263 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2265 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2267 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2269 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2270 and background color parameters if they have been changed.
2272 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2274 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2276 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2278 * xsettings.c (SYSTEM_FONT): Define only when used.
2279 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2281 * keymap.c (access_keymap_1): Now static.
2283 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2285 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2286 leave any prefix arg for the up event (Bug#1586).
2288 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2290 * lread.c (syms_of_lread): Mention single symbols defined by
2291 `defvar' or `defconst' (bug#7154).
2293 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2294 (Frequire): Mention get-load-suffixes.
2296 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2298 * window.h (window): Remove clone_number slot.
2299 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2301 (make_parent_window, make_window, saved_window)
2302 (Fset_window_configuration, save_window_save): Don't deal with
2304 * buffer.c (Qclone_number): Remove declaration.
2305 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2307 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2309 Add multiple inheritance to keymaps.
2310 * keymap.c (Fmake_composed_keymap): New function.
2311 (Fset_keymap_parent): Simplify.
2312 (fix_submap_inheritance): Remove.
2313 (access_keymap_1): New function extracted from access_keymap to handle
2314 embedded parents and handle lists of maps.
2315 (access_keymap): Use it.
2316 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2317 (Fcopy_keymap): Handle embedded parents.
2318 (Fcommand_remapping, define_as_prefix): Simplify.
2319 (Fkey_binding): Simplify.
2320 (syms_of_keymap): Move minibuffer-local-completion-map,
2321 minibuffer-local-filename-completion-map,
2322 minibuffer-local-must-match-map, and
2323 minibuffer-local-filename-must-match-map to Elisp.
2324 (syms_of_keymap): Defsubr make-composed-keymap.
2325 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2326 (parse_menu_item): Trivial simplification.
2328 2011-07-01 Glenn Morris <rgm@gnu.org>
2330 * Makefile.in (SETTINGS_LIBS): Fix typo.
2332 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2334 * coding.c (Fencode_coding_string): Record the last coding system
2335 used, as the function doc string says (bug#8738).
2337 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2339 * xsettings.c (store_monospaced_changed): Take new font as arg and
2340 check for change against current_mono_font.
2341 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2342 (emacs_settings_constructor, emacs_settings_get_property)
2343 (emacs_settings_set_property, emacs_settings_class_init)
2344 (emacs_settings_init, gsettings_obj): Remove.
2345 (something_changedCB): New function for HAVE_GSETTINGS.
2346 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2347 with value as argument.
2348 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2349 g_settings_new (Bug#8967). Do not create gsettings_obj.
2350 Remove calls to g_settings_bind. Connect something_changedCB to
2353 * xgselect.c: Add defined (HAVE_GSETTINGS).
2354 (xgselect_initialize): Ditto.
2356 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2357 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2360 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2362 * eval.c (struct backtrace): Simplify and port the data structure.
2363 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2364 signed bit field, as this assumption is not portable and it makes
2365 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2366 "char debug_on_exit : 1" as this is not portable either; instead,
2367 use the portable "unsigned int debug_on_exit : 1". Remove unused
2368 member evalargs. Remove obsolete comments about cc bombing out.
2370 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2372 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2373 Let HAVE_GSETTINGS override HAVE_GCONF.
2374 (store_monospaced_changed): New function.
2375 (EMACS_SETTINGS): A new type derived from GObject to handle
2376 GSettings notifications.
2377 (emacs_settings_constructor, emacs_settings_get_property)
2378 (emacs_settings_set_property, emacs_settings_class_init):
2380 (gsettings_client, gsettings_obj): New variables.
2381 (GSETTINGS_SCHEMA): New define.
2382 (something_changedCB): Call store_monospaced_changed.
2383 (init_gsettings): New function.
2384 (xsettings_initialize): Call init_gsettings.
2385 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2388 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2391 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2393 * window.c (resize_root_window, grow_mini_window)
2394 (shrink_mini_window): Rename Qresize_root_window to
2395 Qwindow_resize_root_window and Qresize_root_window_vertically to
2396 Qwindow_resize_root_window_vertically.
2398 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2400 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2402 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2404 * makefile.w32-in: Redesign dependencies so they reflect more
2405 clearly which files are directly included by each source file,
2406 and not through other includes.
2408 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2410 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2411 (sort_overlays, overlay_strings): When an overlay's clone number
2412 matches the window's clone number process the overlay even if
2413 the overlay's window property doesn't match the current window.
2415 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2416 (Fwindow_hchild): Rename to Fwindow_left_child.
2417 (Fwindow_next): Rename to Fwindow_next_sibling.
2418 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2419 (resize_window_check): Rename to window_resize_check.
2420 (resize_window_apply): Rename to window_resize_apply.
2421 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2422 (Fdelete_other_windows_internal, resize_frame_windows)
2423 (Fsplit_window_internal, Fdelete_window_internal)
2424 (grow_mini_window, shrink_mini_window)
2425 (Fresize_mini_window_internal): Fix callers accordingly.
2427 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2429 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2430 (emacs_fixed_set_min_size): Remove.
2431 (emacs_fixed_new): Take frame as argument.
2433 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2434 (_EmacsFixedPrivate): Remove minwidth/height.
2435 Add struct frame *f.
2436 (emacs_fixed_init): Initialize priv->f.
2437 (get_parent_class, emacs_fixed_set_min_size): Remove.
2438 (emacs_fixed_new): Set priv->f to argument.
2439 (emacs_fixed_get_preferred_width)
2440 (emacs_fixed_get_preferred_height): Use min_width/height from
2441 frames size_hint to set minimum and natural (Bug#8919).
2442 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2443 and use min_width/height from frames size_hint to set
2444 min_width/height (Bug#8919).
2446 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2447 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2450 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2452 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2453 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2456 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2458 * process.c (wait_reading_process_output): Bypass select if
2459 waiting for a cell while ignoring keyboard input, and input is
2460 pending. Suggested by Jan Djärv (Bug#8869).
2462 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2464 Use gnulib's dup2 module instead of rolling our own.
2465 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2467 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2469 * dispnew.c (scrolling_window): Before scrolling, turn off a
2470 mouse-highlight in the window being scrolled.
2472 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2474 Move DEFSYM to lisp.h and use everywhere.
2476 * character.h (DEFSYM): Move declaration...
2477 * lisp.h (DEFSYM): ...here.
2483 * w32select.c: Don't include character.h.
2485 * alloc.c (syms_of_alloc):
2486 * buffer.c (syms_of_buffer):
2487 * bytecode.c (syms_of_bytecode):
2488 * callint.c (syms_of_callint):
2489 * casefiddle.c (syms_of_casefiddle):
2490 * casetab.c (init_casetab_once):
2491 * category.c (init_category_once, syms_of_category):
2492 * ccl.c (syms_of_ccl):
2493 * cmds.c (syms_of_cmds):
2494 * composite.c (syms_of_composite):
2495 * dbusbind.c (syms_of_dbusbind):
2496 * dired.c (syms_of_dired):
2497 * dispnew.c (syms_of_display):
2498 * doc.c (syms_of_doc):
2499 * editfns.c (syms_of_editfns):
2500 * emacs.c (syms_of_emacs):
2501 * eval.c (syms_of_eval):
2502 * fileio.c (syms_of_fileio):
2503 * fns.c (syms_of_fns):
2504 * frame.c (syms_of_frame):
2505 * fringe.c (syms_of_fringe):
2506 * insdel.c (syms_of_insdel):
2507 * keymap.c (syms_of_keymap):
2508 * lread.c (init_obarray, syms_of_lread):
2509 * macros.c (syms_of_macros):
2510 * msdos.c (syms_of_msdos):
2511 * print.c (syms_of_print):
2512 * process.c (syms_of_process):
2513 * search.c (syms_of_search):
2514 * sound.c (syms_of_sound):
2515 * syntax.c (init_syntax_once, syms_of_syntax):
2516 * terminal.c (syms_of_terminal):
2517 * textprop.c (syms_of_textprop):
2518 * undo.c (syms_of_undo):
2519 * w32.c (globals_of_w32):
2520 * window.c (syms_of_window):
2521 * xdisp.c (syms_of_xdisp):
2522 * xfaces.c (syms_of_xfaces):
2523 * xfns.c (syms_of_xfns):
2524 * xmenu.c (syms_of_xmenu):
2525 * xsettings.c (syms_of_xsettings):
2526 * xterm.c (syms_of_xterm): Use DEFSYM.
2528 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2530 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2532 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2534 Integer and buffer overflow fixes (Bug#8873).
2536 * print.c (printchar, strout): Check for string overflow.
2537 (PRINTPREPARE, printchar, strout):
2538 Don't set size unless allocation succeeds.
2540 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2541 for sizes. Check for string overflow more accurately.
2542 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2544 * macros.c: Integer and buffer overflow fixes.
2545 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2546 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2547 Use ptrdiff_t, not int, for sizes.
2548 Don't increment bufsize until after realloc succeeds.
2549 Check for size-calculation overflow.
2550 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2552 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2554 * lread.c: Integer overflow fixes.
2555 (read_integer): Radix is now EMACS_INT, not int,
2556 to improve quality of diagnostics for out-of-range radices.
2557 Calculate buffer size correctly for out-of-range radices.
2558 (read1): Check for integer overflow in radices, and in
2559 read-circle numbers.
2560 (read_escape): Avoid int overflow.
2561 (Fload, openp, read_buffer_size, read1)
2562 (substitute_object_recurse, read_vector, read_list, map_obarray):
2563 Use ptrdiff_t, not int, for sizes.
2564 (read1): Use EMACS_INT, not int, for sizes.
2565 Check for size overflow.
2567 * image.c (cache_image): Check for size arithmetic overflow.
2569 * lread.c: Integer overflow issues.
2570 (saved_doc_string_size, saved_doc_string_length)
2571 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2572 Now ptrdiff_t, not int.
2573 (read1): Don't assume doc string length fits in int. Check for
2574 out-of-range doc string lengths.
2575 (read_list): Don't assume file position fits in int.
2576 (read_escape): Check for hex character overflow.
2578 2011-06-22 Leo Liu <sdl.web@gmail.com>
2580 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2581 Move to minibuffer.el.
2583 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2585 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2586 The following patches are for when GLYPH_DEBUG && !XASSERT.
2587 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2588 * dispnew.c (flush_stdout):
2589 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2590 Mark as externally visible.
2591 * dispnew.c (check_window_matrix_pointers): Now static.
2592 * dispnew.c (window_to_frame_vpos):
2593 * xfns.c (unwind_create_frame):
2594 * xterm.c (x_check_font): Remove unused local.
2595 * scroll.c (CHECK_BOUNDS):
2596 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2597 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2598 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2599 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2600 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2602 (debug_method_add): Use va_list and vsprintf rather than relying
2603 on undefined behavior with wrong number of arguments.
2604 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2605 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2606 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2607 since we're not interested in debugging glyphs with old libraries.
2608 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2609 GCC 4.6.0's static checking.
2611 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2613 Integer overflow and signedness fixes (Bug#8873).
2614 A few related buffer overrun fixes, too.
2616 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2618 * dispextern.h (struct face.stipple):
2619 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2620 (x_bitmap_mask, x_allocate_bitmap_record)
2621 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2622 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2623 (x_create_bitmap_from_xpm_data):
2624 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2625 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2627 * xfaces.c (load_pixmap):
2628 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2629 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2630 (.bitmaps_last, struct x_output.icon_bitmap):
2631 Use ptrdiff_t, not int, for bitmap indexes.
2632 (x_allocate_bitmap_record): Check for size overflow.
2633 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2635 Use ptrdiff_t, not int, for overlay counts.
2636 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2637 * editfns.c (overlays_around, get_pos_property):
2638 * textprop.c (get_char_property_and_overlay):
2639 * xdisp.c (next_overlay_change, note_mouse_highlight):
2640 * xfaces.c (face_at_buffer_position):
2641 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2642 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2643 (Fnext_overlay_change, Fprevious_overlay_change)
2644 (mouse_face_overlay_overlaps, Foverlays_in):
2645 Use ptrdiff_t, not int, for sizes.
2646 (overlays_at, overlays_in): Check for size-calculation overflow.
2648 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2650 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2651 (x_session_initialize): Do not assume string length fits in int.
2653 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2654 This is unlikely, but can occur if DPI is outlandish.
2656 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2657 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2659 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2660 * xrdb.c (magic_file_p, search_magic_path):
2661 Omit last arg SUFFIX; it was always 0. All callers changed.
2662 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2664 * xfont.c (xfont_match): Avoid need for strlen.
2666 * xfns.c: Don't assume strlen fits in int.
2667 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2669 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2670 not unsigned long, as we prefer signed integers. All callers changed.
2671 Detect integer overflow in repeat count.
2672 (message_dolog): Don't assume print length fits in 39 bytes.
2673 (display_mode_element): Don't assume strlen fits in int.
2675 * termcap.c: Don't assume sizes fit in int and never overflow.
2676 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2677 (gobble_line): Check for size-calculation overflow.
2679 * minibuf.c (Fread_buffer):
2680 * lread.c (intern, intern_c_string):
2681 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2682 Don't assume string length fits in int.
2684 * keyboard.c (parse_tool_bar_item):
2685 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2687 * font.c: Don't assume string length fits in int.
2688 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2689 Use ptrdiff_t, not int.
2690 (font_intern_prop): Don't assume string length fits in int.
2691 Don't assume integer property fits in fixnum.
2692 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2694 * filelock.c: Fix some buffer overrun and integer overflow issues.
2695 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2696 Reformulate so as not to need the command string.
2697 Invoke gzip -cd rather than gunzip, as it's more portable.
2698 (lock_info_type, lock_file_1, lock_file):
2699 Don't assume pid_t and time_t fit in unsigned long.
2700 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2701 (current_lock_owner): Prefer signed type for sizes.
2702 Use memcpy, not strncpy, where memcpy is what is really wanted.
2703 Don't assume (via atoi) that time_t and pid_t fit in int.
2704 Check for time_t and/or pid_t out of range, e.g., via a network share.
2705 Don't alloca where an auto var works fine.
2707 * fileio.c: Fix some integer overflow issues.
2708 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2709 Don't assume string length fits in int.
2710 (directory_file_name): Don't assume string length fits in long.
2711 (make_temp_name): Don't assume pid fits in int, or that its print
2712 length is less than 20.
2714 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2716 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2718 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2720 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2721 We prefer signed integers, even for size calculations.
2723 * emacs.c: Don't assume string length fits in 'int'.
2724 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2725 (main): Don't invoke strlen when not needed.
2727 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2728 (XD_DEBUG_MESSAGE): Don't waste a byte.
2730 * callproc.c (getenv_internal_1, getenv_internal)
2732 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2734 * lread.c (invalid_syntax): Omit length argument.
2735 All uses changed. This doesn't fix a bug, but it simplifies the
2736 code away from its former Hollerith-constant appearance, and it's
2737 one less 'int' to worry about when looking at integer-overflow issues.
2738 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2740 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2741 This didn't break anything, but it didn't help either.
2742 It's confusing to put a bogus integer in a place where the actual
2743 value does not matter.
2744 (LIST_END_P): Remove unused macro and its bogus comment.
2745 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2747 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2748 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2750 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2751 We prefer signed types, and the value cannot exceed the EMACS_INT
2752 range anyway (because otherwise the length would not be representable).
2753 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2754 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2755 This avoids a GCC warning when WIDE_EMACS_INT.
2757 * indent.c (sane_tab_width): New function.
2758 (current_column, scan_for_column, Findent_to, position_indentation)
2759 (compute_motion): Use it. This is just for clarity.
2760 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2762 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2764 * lisp.h (lint_assume): New macro.
2765 * composite.c (composition_gstring_put_cache):
2766 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2768 * editfns.c, insdel.c:
2769 Omit unnecessary forward decls, to simplify future changes.
2771 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2773 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2775 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2776 Use much-faster test for byte-length change.
2777 Don't assume string byte-length fits in 'int'.
2778 Check that character arg fits in 'int'.
2779 (mapcar1): Declare byte as byte, for clarity.
2781 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2783 * fns.c (concat): Catch string overflow earlier.
2784 Do not rely on integer wraparound.
2786 * dispextern.h (struct it.overlay_strings_charpos)
2787 (struct it.selective): Now EMACS_INT, not int.
2788 * xdisp.c (forward_to_next_line_start)
2789 (back_to_previous_visible_line_start)
2790 (reseat_at_next_visible_line_start, next_element_from_buffer):
2791 Don't arbitrarily truncate the value of 'selective' to int.
2793 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2795 * composite.c: Don't truncate sizes to 'int'.
2796 (composition_gstring_p, composition_reseat_it)
2797 (composition_adjust_point): Use EMACS_INT, not int.
2798 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2799 not EMACS_UINT, for indexes.
2801 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2803 * buffer.c: Include <verify.h>.
2804 (struct sortvec.priority, struct sortstr.priority):
2805 Now EMACS_INT, not int.
2806 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2807 (struct sortstr.size, record_overlay_string)
2808 (struct sortstrlist.size, struct sortlist.used):
2809 Don't truncate size to int.
2810 (record_overlay_string): Check for size-calculation overflow.
2811 (init_buffer_once): Check at compile-time, not run-time.
2813 2011-06-22 Jim Meyering <meyering@redhat.com>
2815 Don't leak an XBM-image-sized buffer
2816 * image.c (xbm_load): Free the image buffer after using it.
2818 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2821 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2822 that Sun C diagnosed.
2823 * fns.c (secure_hash): Fix pointer signedness issue.
2824 * intervals.c (static_offset_intervals): New function.
2825 (offset_intervals): Use it.
2827 2011-06-21 Leo Liu <sdl.web@gmail.com>
2830 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2833 * fns.c (secure_hash): Rename from crypto_hash_function and change
2834 the first arg to accept symbols.
2835 (Fsecure_hash): New primitive.
2836 (syms_of_fns): New symbols.
2838 2011-06-20 Deniz Dogan <deniz@dogan.se>
2840 * process.c (Fset_process_buffer): Clarify return value in
2843 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2845 * dispnew.c (add_window_display_history): Use BVAR.
2847 * xdisp.c (debug_method_add): Use BVAR.
2848 (check_window_end, dump_glyph_matrix, dump_glyph)
2849 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2851 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2854 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2855 check till after the cache is created in init_frame_faces.
2857 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2859 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2861 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2863 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2864 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2865 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2867 Improve buffer-overflow checking (Bug#8873).
2868 * fileio.c (Finsert_file_contents):
2869 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2870 Remove the old (too-loose) buffer overflow checks.
2871 They weren't needed, since make_gap checks for buffer overflow.
2872 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2873 The old code merely checked for Emacs fixnum overflow, and relied
2874 on undefined (wraparound) behavior. The new code avoids undefined
2875 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2877 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2878 Tune. Don't use wider integers than needed. Don't use alloca.
2879 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2881 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2883 * insdel.c, lisp.h (buffer_overflow): New function.
2884 (insert_from_buffer_1, replace_range, replace_range_2):
2885 * insdel.c (make_gap_larger):
2886 * editfns.c (Finsert_char):
2887 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2889 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2891 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2893 Integer overflow and signedness fixes (Bug#8873).
2895 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2896 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2898 * fileio.c: Don't assume EMACS_INT fits in off_t.
2899 (emacs_lseek): New static function.
2900 (Finsert_file_contents, Fwrite_region): Use it.
2901 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2903 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2905 * fns.c: Don't overflow int when computing a list length.
2906 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2907 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2908 truncation on 64-bit hosts. Check for QUIT every
2909 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2910 faster and is responsive enough.
2911 (Flength): Report an error instead of overflowing an integer.
2912 (Fsafe_length): Return a float if the value is not representable
2913 as a fixnum. This shouldn't happen except in contrived situations.
2914 (Fnthcdr, Fsort): Don't assume list length fits in int.
2915 (Fcopy_sequence): Don't assume vector length fits in int.
2917 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2918 (header_size, word_size): New constants.
2919 (allocate_vectorlike): Don't check size overflow here.
2920 (allocate_vector): Check it here instead, since this is the only
2921 caller of allocate_vectorlike that could cause overflow.
2922 Check that the new vector's length is representable as a fixnum.
2924 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2925 The previous code was bogus. For example, next_almost_prime (32)
2926 returned 39, which is undesirable as it is a multiple of 3; and
2927 next_almost_prime (24) returned 25, which is a multiple of 5 so
2928 why was the code bothering to check for multiples of 7?
2930 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2932 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2934 Variadic C functions now count arguments with ptrdiff_t.
2935 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2936 Back then I didn't know that the Emacs coding style prefers signed int.
2937 Also, in the meantime I found a few more instances where arguments
2938 were being counted with int, which may truncate counts on 64-bit
2939 machines, or EMACS_INT, which may be unnecessarily wide.
2940 * lisp.h (struct Lisp_Subr.function.aMANY)
2941 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2942 Arg counts are now ptrdiff_t, not size_t.
2943 All variadic functions and their callers changed accordingly.
2944 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2945 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2946 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2947 * callint.c (Fcall_interactively): Check arg count for overflow,
2948 to avoid potential buffer overrun. Use signed char, not 'int',
2949 for 'varies' array, so that we needn't bother to check its size
2950 calculation for overflow.
2951 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2952 * eval.c (apply_lambda):
2953 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2954 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2955 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2957 * callint.c (Fcall_interactively): Don't use index var as event count.
2959 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2960 * mem-limits.h (SIZE): Remove; no longer used.
2962 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2964 Remove unnecessary casts.
2965 * xterm.c (x_term_init):
2966 * xfns.c (x_set_border_pixel):
2967 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2968 These aren't needed now that we assume ANSI C.
2970 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2971 It's more likely to cause problems (due to unsigned overflow)
2974 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2976 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2978 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2980 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2982 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2984 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2986 GLYPH_CODE_FACE returns EMACS_INT, not int.
2987 * dispextern.h (merge_faces):
2988 * xfaces.c (merge_faces):
2989 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2990 Don't assume EMACS_INT fits in int.
2992 * character.h (CHAR_VALID_P): Remove unused parameter.
2993 * fontset.c, lisp.h, xdisp.c: All uses changed.
2995 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2997 * fns.c (concat): Minor tuning based on overflow analysis.
2998 This doesn't fix any bugs. Use int to hold character, instead
2999 of constantly refetching from Emacs object. Use XFASTINT, not
3000 XINT, for value known to be a character. Don't bother comparing
3001 a single byte to 0400, as it's always less.
3003 * floatfns.c (Fexpt):
3004 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3006 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3009 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3011 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3012 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3013 incorrectly succeed when S was a string, because 4294967386 was
3014 truncated before it was used.
3016 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3017 Otherwise, an out-of-range integer could cause undefined behavior
3020 * composite.c: Use int, not EMACS_INT, for characters.
3021 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3022 EMACS_INT, for values that are known to be in character range.
3023 This doesn't fix any bugs but is the usual style inside Emacs and
3024 may generate better code on 32-bit machines.
3026 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3027 This is for reasons similar to the recent CHAR_STRING fix.
3028 * charset.c (Fencode_char): Check that character arg is actually
3029 a character. Pass an int to ENCODE_CHAR.
3030 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3031 wider than 'int', as a compile-time check to prevent future regressions
3034 * character.c (char_string): Remove unnecessary casts.
3036 Make sure a 64-bit char is never passed to CHAR_STRING.
3037 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3038 by silently ignoring the top 32 bits, allowing some values
3039 that were far too large to be valid characters.
3040 * character.h: Include <verify.h>.
3041 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3042 arguments are no wider than unsigned, as a compile-time check
3043 to prevent future regressions in this area.
3045 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3046 (Fsubst_char_in_region):
3048 * xdisp.c (decode_mode_spec_coding):
3049 Adjust to CHAR_STRING's new requirement.
3050 * editfns.c (Finsert_char, Fsubst_char_in_region):
3051 * fns.c (concat): Check that character args are actually
3052 characters. Without this test, these functions did the wrong
3053 thing with wildly out-of-range values on 64-bit hosts.
3055 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3056 These casts should not be needed on 32-bit hosts, either.
3057 * keyboard.c (read_char):
3058 * lread.c (Fload): Remove casts to unsigned.
3060 * lisp.h (UNSIGNED_CMP): New macro.
3061 This fixes comparison bugs on 64-bit hosts.
3062 (ASCII_CHAR_P): Use it.
3063 * casefiddle.c (casify_object):
3064 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3065 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3066 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3067 * dispextern.h (FACE_FROM_ID):
3068 * keyboard.c (read_char): Use UNSIGNED_CMP.
3070 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3071 not to EMACS_INT, to avoid GCC warning.
3073 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3075 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3076 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3077 isn't needed on 32-bit machines.
3079 * buffer.c (Fgenerate_new_buffer_name):
3080 Use EMACS_INT for count, not int.
3081 (advance_to_char_boundary): Return EMACS_INT, not int.
3083 * data.c (Qcompiled_function): Now static.
3085 * window.c (window_body_lines): Now static.
3087 * image.c (gif_load): Rename local to avoid shadowing.
3089 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3090 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3091 * alloc.c (make_save_value): Integer argument is now of type
3093 (mark_object): Use ptrdiff_t, not int.
3094 * lisp.h (pD): New macro.
3095 * print.c (print_object): Use it.
3097 * alloc.c: Use EMACS_INT, not int, to count objects.
3098 (total_conses, total_markers, total_symbols, total_vector_size)
3099 (total_free_conses, total_free_markers, total_free_symbols)
3100 (total_free_floats, total_floats, total_free_intervals)
3101 (total_intervals, total_strings, total_free_strings):
3102 Now EMACS_INT, not int. All uses changed.
3103 (Fgarbage_collect): Compute overall total using a double, so that
3104 integer overflow is less likely to be a problem. Check for overflow
3105 when converting back to an integer.
3106 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3107 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3108 These were 'int' variables that could overflow on 64-bit hosts;
3109 they were never used, so remove them instead of repairing them.
3110 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3111 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3112 Previously, this ceilinged at INT_MAX, but that doesn't work on
3114 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3116 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3117 (allocate_vectorlike): Check for ptrdiff_t overflow.
3118 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3119 when a (possibly-narrower) signed value would do just as well.
3120 We prefer using signed arithmetic, to avoid comparison confusion.
3122 * alloc.c: Catch some string size overflows that we were missing.
3123 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3124 for convenience in STRING_BYTES_MAX.
3125 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3126 The definition here is exact; the one in lisp.h was approximate.
3127 (allocate_string_data): Check for string overflow. This catches
3128 some instances we weren't catching before. Also, it catches
3129 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3130 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3131 and ptrdiff_t and EMACS_INT are both 64 bits.
3133 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3134 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3135 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3137 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3139 * alloc.c (Fmake_string): Check for out-of-range init.
3141 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3143 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3145 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3147 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3148 xg_get_default_scrollbar_width.
3150 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3151 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3152 (style_changed_cb): Call update_theme_scrollbar_width and call
3153 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3154 all frames (Bug#8505).
3155 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3156 Call gtk_window_set_resizable if HAVE_GTK3.
3157 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3158 and height if HAVE_GTK3 (Bug#8505).
3159 (scroll_bar_width_for_theme): New variable.
3160 (update_theme_scrollbar_width): New function.
3161 (xg_get_default_scrollbar_width): Move code to
3162 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3163 (xg_initialize): Call update_theme_scrollbar_width.
3165 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3167 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3169 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3171 * frame.c (make_frame): Call other_buffer_safely instead of
3174 * window.c (temp_output_buffer_show): Call display_buffer with
3175 second argument Vtemp_buffer_show_specifiers and reset latter
3176 immediately after the call.
3177 (Vtemp_buffer_show_specifiers): New variable.
3178 (auto_window_vscroll_p, next_screen_context_lines)
3179 (Vscroll_preserve_screen_position): Remove leading asterisks from
3182 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3184 Fix minor problems found by GCC 4.6.0 static checking.
3185 * buffer.c (Qclone_number): Remove for now, as it's unused.
3186 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3187 (record_buffer): Remove unused local.
3188 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3189 (set_frame_buffer_list): Remove; unused.
3190 * frame.h (other_visible_frames): Remove decl.
3191 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3192 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3193 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3195 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3196 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3197 Define only if HAVE_GPM.
3198 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3199 (update_hints_inhibit): Remove; never set. All uses removed.
3200 * widgetprv.h (emacsFrameClassRec): Remove decl.
3201 * window.c (delete_deletable_window): Now returns void, since it
3202 wasn't returning anything.
3203 (compare_window_configurations): Remove unused locals.
3204 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3205 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3206 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3207 the same widths as pointers. This follows up on the 2011-05-06 patch.
3208 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3209 * xterm.h: Likewise.
3210 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3212 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3214 * makefile.w32-in: Update dependencies.
3215 (LISP_H): Add lib/intprops.h.
3217 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3219 * image.c (gif_load): Add animation frame delay to the metadata.
3220 (syms_of_image): Use DEFSYM. New symbol `delay'.
3222 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3224 * window.c (delete_deletable_window): Re-add.
3225 (Fset_window_configuration): Rewrite to handle dead buffers and
3226 consequently deletable windows.
3227 (window_tree, Fwindow_tree): Remove. Supply functionality in
3229 (compare_window_configurations): Simplify code.
3231 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3233 * image.c (imagemagick_load_image): Fix type mismatch.
3234 (Fimagemagick_types): Likewise.
3236 * window.h (replace_buffer_in_windows): Declare.
3238 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3240 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3241 Qclone_number. Remove external declaration of Qdelete_window.
3242 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3244 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3245 Run Qbuffer_list_update_hook if allowed.
3246 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3247 buffer list implementation.
3248 (other_buffer_safely): New function.
3249 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3250 calls to replace_buffer_in_windows and
3251 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3253 (record_buffer): Inhibit quitting and rewrite using quittable
3254 functions. Run Qbuffer_list_update_hook if allowed.
3255 (Frecord_buffer, Funrecord_buffer): New functions.
3256 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3257 Move switch-to-buffer to window.el.
3258 (bury-buffer): Move to window.el.
3259 (Vbuffer_list_update_hook): New variable.
3261 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3264 * window.h (resize_frame_windows): Move up in code.
3265 (Fwindow_frame): Remove EXFUN.
3266 (replace_buffer_in_all_windows): Remove prototype.
3267 (replace_buffer_in_windows_safely): Add prototype.
3269 * window.c: Declare Qdelete_window static again. Move down
3270 declaration of select_count.
3271 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3272 (Fother_window): Move to window.el.
3273 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3274 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3275 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3277 (replace_buffer_in_windows): Implement by calling
3278 Qreplace_buffer_in_windows.
3279 (replace_buffer_in_all_windows): Remove with some functionality
3280 moved into replace_buffer_in_windows_safely.
3281 (replace_buffer_in_windows_safely): New function.
3282 (select_window_norecord, select_frame_norecord): Move in front
3283 of run_window_configuration_change_hook. Remove now obsolete
3285 (Fset_window_buffer): Rewrite doc-string.
3286 Call Qrecord_window_buffer.
3287 (keys_of_window): Move binding for other-window to window.el.
3289 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3291 * dispextern.h (struct image): Replace data member, whose int_val
3292 and ptr_val fields were not used by anything, with a single
3295 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3296 (gif_clear_image, gif_load, imagemagick_load_image)
3297 (gs_clear_image, gs_load): Callers changed.
3299 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3301 * buffer.h: Include <time.h>, for time_t.
3302 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3304 Fix minor problems found by static checking.
3306 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3308 Make identifiers static if they are not used in other modules.
3309 * data.c (Qcompiled_function, Qframe, Qvector):
3310 * image.c (QimageMagick, Qsvg):
3311 * minibuf.c (Qmetadata):
3312 * window.c (resize_window_check, resize_root_window): Now static.
3313 * window.h (resize_window_check, resize_root_window): Remove decls.
3315 * window.c (window_deletion_count, delete_deletable_window):
3317 (window_body_lines): Now static.
3318 (Fdelete_other_windows_internal): Mark vars as initialized.
3319 Make sure 'resize_failed' is initialized.
3320 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3321 (resize_window_apply): Remove unused local.
3322 * window.h (delete_deletable_window): Remove decl.
3324 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3325 (imagemagick_load_image): Fix pointer signedness problem by changing
3326 last arg from unsigned char * to char *. All uses changed.
3327 Also, fix a local for similar reasons.
3328 Remove unused locals. Remove locals to avoid shadowing.
3329 (fn_rsvg_handle_free): Remove; unused.
3330 (svg_load, svg_load_image): Fix pointer signedness problem.
3331 (imagemagick_load_image): Don't use garbage pointer image_wand.
3333 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3335 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3337 * image.c (gif_load): Fix omitted cast error introduced by
3340 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3342 * window.h (resize_proportionally, orig_total_lines)
3343 (orig_top_line): Remove from window structure.
3344 (set_window_height, set_window_width, change_window_heights)
3345 (Fdelete_window): Remove prototypes.
3346 (resize_frame_windows): Remove duplicate declaration.
3348 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3350 * window.h (resize_frame_windows, resize_window_check)
3351 (delete_deletable_window, resize_root_window)
3352 (resize_frame_windows): Declare prototypes.
3354 * window.c (resize_window_apply): Make definition be "static" to
3355 match the prototype.
3357 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3359 * window.c: Remove declarations of Qwindow_size_fixed,
3360 window_min_size_1, window_min_size_2, window_min_size,
3361 size_window, window_fixed_size_p, enlarge_window, delete_window.
3362 Remove static from declaration of Qdelete_window, it's
3363 temporarily needed by Fbury_buffer.
3364 (replace_window): Don't assign orig_top_line and
3366 (Fdelete_window, delete_window): Remove. Window deletion is
3367 handled by window.el.
3368 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3369 Replace Fdelete_window calls with calls to Qdelete_window.
3370 (Fdelete_other_windows): Remove. Deleting other windows is
3371 handled by window.el.
3372 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3373 handled in window.el.
3374 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3375 Window minimum sizes are handled in window.el.
3376 (shrink_windows, size_window, set_window_height)
3377 (set_window_width, change_window_heights, window_height)
3378 (window_width, CURBEG, CURSIZE, enlarge_window)
3379 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3380 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3381 handled in window.el.
3382 (make_dummy_parent): Rename to make_parent_window and give it a
3383 second argument horflag.
3384 (make_window): Don't set resize_proportionally any more.
3385 (Fsplit_window): Remove. Windows are split in window.el.
3386 (save_restore_action, save_restore_orig_size)
3387 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3388 Resize mini windows in window.el.
3389 (grow_mini_window, shrink_mini_window): Implement by calling
3390 Qresize_root_window_vertically, resize_window_check and
3391 resize_window_apply.
3392 (saved_window, Fset_window_configuration, save_window_save):
3393 Do not handle orig_top_line, orig_total_lines, and
3394 resize_proportionally.
3395 (window_min_height, window_min_width): Move to window.el.
3396 (keys_of_window): Move bindings for delete-other-windows,
3397 split-window, delete-window and enlarge-window to window.el.
3399 * buffer.c: Temporarily extern Qdelete_window.
3400 (Fbury_buffer): Temporarily call Qdelete_window instead of
3401 Fdelete_window (Fbury_buffer will move to window.el soon).
3403 * frame.c (set_menu_bar_lines_1): Remove code handling
3404 orig_top_line and orig_total_lines.
3406 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3407 set_window_height but set heights directly.
3408 (change_frame_size_1): Use resize_frame_windows.
3410 * xdisp.c (init_xdisp): Don't use set_window_height but set
3413 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3414 Use resize_frame_windows instead of change_window_heights and run
3415 run_window_configuration_change_hook.
3417 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3418 instead of change_window_heights and run
3419 run_window_configuration_change_hook.
3421 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3423 * window.c (replace_window): Rename second argument REPLACEMENT to
3424 NEW. New third argument SETFLAG. Rewrite.
3425 (delete_window, make_dummy_parent): Call replace_window with
3427 (window_list_1): Move down in code.
3428 (run_window_configuration_change_hook): Move set_buffer part
3429 before select_frame_norecord part in order to unwind correctly.
3430 Rename count1 to count.
3431 (recombine_windows, delete_deletable_window, resize_root_window)
3432 (Fdelete_other_windows_internal)
3433 (Frun_window_configuration_change_hook, make_parent_window)
3434 (resize_window_check, resize_window_apply, Fresize_window_apply)
3435 (resize_frame_windows, Fsplit_window_internal)
3436 (Fdelete_window_internal, Fresize_mini_window_internal):
3438 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3440 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3442 * window.h (window): Add some new members to window structure -
3443 normal_lines, normal_cols, new_total, new_normal, clone_number,
3444 splits, nest, prev_buffers, next_buffers.
3445 (WINDOW_TOTAL_SIZE): Move here from window.c.
3446 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3448 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3450 (make_dummy_parent): Set new members of windows structure.
3451 (make_window): Move down in code. Handle new members of window
3453 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3454 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3455 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3456 (Fset_window_prev_buffers, Fwindow_next_buffers)
3457 (Fset_window_next_buffers, Fset_window_clone_number):
3459 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3460 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3462 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3463 Argument WINDOW can be now internal window too.
3464 (Fwindow_use_time): Move up in code.
3465 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3467 (Fset_window_configuration, saved_window)
3468 (Fcurrent_window_configuration, save_window_save): Handle new
3469 members of window structure.
3470 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3471 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3472 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3473 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3474 Qget_mru_window, Qresize_root_window,
3475 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3476 Qauto_buffer_name; staticpro them.
3478 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3480 * window.c (Fwindow_total_size, Fwindow_left_column)
3481 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3482 (Fwindow_list_1): New functions.
3483 (window_box_text_cols): Replace with window_body_cols.
3484 (Fwindow_width, Fscroll_left, Fscroll_right):
3485 Use window_body_cols instead of window_box_text_cols.
3486 (delete_window, Fset_window_configuration):
3487 Call delete_all_subwindows with window as argument.
3488 (delete_all_subwindows): Take a window as argument and not a
3490 (window_loop): Remove handling of GET_LRU_WINDOW and
3492 (Fget_lru_window, Fget_largest_window): Move to window.el.
3494 * window.h: Extern window_body_cols instead of
3495 window_box_text_cols. delete_all_subwindows now takes a
3496 Lisp_Object as argument.
3498 * indent.c (compute_motion, Fcompute_motion):
3499 Use window_body_cols instead of window_box_text_cols.
3501 * frame.c (delete_frame): Call delete_all_subwindows with root
3504 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3506 * fns.c (Fputhash): Document return value.
3508 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3510 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3512 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3514 Cons<->int and similar integer overflow fixes (Bug#8794).
3516 Check for overflow when converting integer to cons and back.
3517 * charset.c (Fdefine_charset_internal, Fdecode_char):
3518 Use cons_to_unsigned to catch overflow.
3519 (Fencode_char): Use INTEGER_TO_CONS.
3520 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3521 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3522 * data.c (long_to_cons, cons_to_long): Remove.
3523 (cons_to_unsigned, cons_to_signed): New functions.
3524 These signal an error for invalid or out-of-range values.
3525 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3526 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3527 * font.c (Ffont_variation_glyphs):
3528 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3529 * lisp.h: Include <intprops.h>.
3530 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3531 (cons_to_signed, cons_to_unsigned): New decls.
3532 (long_to_cons, cons_to_long): Remove decls.
3533 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3534 (Fprimitive_undo): Use CONS_TO_INTEGER.
3535 * xfns.c (Fx_window_property): Likewise.
3536 * xselect.c: Include <limits.h>.
3537 (x_own_selection, selection_data_to_lisp_data):
3538 Use INTEGER_TO_CONS.
3539 (x_handle_selection_request, x_handle_selection_clear)
3540 (x_get_foreign_selection, Fx_disown_selection_internal)
3541 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3542 (lisp_data_to_selection_data): Use cons_to_unsigned.
3543 (x_fill_property_data): Use cons_to_signed.
3544 Report values out of range.
3546 Check for buffer and string overflow more precisely.
3547 * buffer.h (BUF_BYTES_MAX): New macro.
3548 * lisp.h (STRING_BYTES_MAX): New macro.
3549 * alloc.c (Fmake_string):
3550 * character.c (string_escape_byte8):
3551 * coding.c (coding_alloc_by_realloc):
3552 * doprnt.c (doprnt):
3553 * editfns.c (Fformat):
3555 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3556 since they may not be the same number.
3557 * editfns.c (Finsert_char):
3558 * fileio.c (Finsert_file_contents):
3559 Likewise for BUF_BYTES_MAX.
3561 * image.c: Use ptrdiff_t, not int, for sizes.
3562 (slurp_file): Switch from int to ptrdiff_t.
3564 (slurp_file): Check that file size fits in both size_t (for
3565 malloc) and ptrdiff_t (for sanity and safety).
3567 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3568 if b->modtime has its maximal value.
3570 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3572 Don't assume time_t can fit into int.
3573 * buffer.h (struct buffer.modtime): Now time_t, not int.
3574 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3575 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3577 Minor fixes for signed vs unsigned integers.
3578 * character.h (MAYBE_UNIFY_CHAR):
3579 * charset.c (maybe_unify_char):
3580 * keyboard.c (read_char, reorder_modifiers):
3581 XINT -> XFASTINT, since the integer must be nonnegative.
3582 * ftfont.c (ftfont_spec_pattern):
3583 * keymap.c (access_keymap, silly_event_symbol_error):
3584 XUINT -> XFASTINT, since the integer must be nonnegative.
3585 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3586 since it makes no difference and we prefer signed.
3587 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3588 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3591 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3593 * window.h (Fwindow_frame): Declare.
3595 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3597 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3598 (SPARE_MEMORY): Always define.
3599 (LARGE_REQUEST): Remove.
3600 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3602 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3604 * lisp.h: Move EXFUNS for Fframe_root_window,
3605 Fframe_first_window and Fset_frame_selected_window to window.h.
3607 * window.h: Move EXFUNS for Fframe_root_window,
3608 Fframe_first_window and Fset_frame_selected_window here from
3611 * frame.c (Fwindow_frame, Fframe_first_window)
3612 (Fframe_root_window, Fframe_selected_window)
3613 (Fset_frame_selected_window): Move to window.c.
3614 (Factive_minibuffer_window): Move to minibuf.c.
3615 (Fother_visible_frames_p): New function.
3617 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3619 * window.c (decode_window, decode_any_window): Move up in code.
3620 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3621 (inhibit_frame_unsplittable): Remove unused variable.
3622 (Fwindow_buffer): Move up and rewrite doc-string.
3623 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3624 (Fwindow_prev): New functions.
3625 (Fwindow_frame): Move here from frame.c. Accept any window as
3627 (Fframe_root_window, Fframe_first_window)
3628 (Fframe_selected_window): Move here from frame.c. Accept frame
3629 or arbitrary window as argument. Update doc-strings.
3630 (Fminibuffer_window): Move up in code.
3631 (Fwindow_minibuffer_p): Move up in code and simplify.
3632 (Fset_frame_selected_window): Move here from frame.c.
3634 (Fselected_window, select_window, Fselect_window): Move up in
3635 code. Minor doc-string fixes.
3637 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3639 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3640 Do not assume that spare memory exists; that assumption is valid
3641 only if SYSTEM_MALLOC.
3642 (LARGE_REQUEST): New macro, so that the issue of large requests
3643 is separated from the issue of spare memory.
3645 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3647 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3650 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3652 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3655 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3657 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3659 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3661 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3662 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3664 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3666 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3668 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3670 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3671 (x_clipboard_manager_save): Add return value.
3672 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3674 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3675 Obey Vx_select_enable_clipboard_manager. Catch errors in
3676 x_clipboard_manager_save (Bug#8779).
3677 (Vx_select_enable_clipboard_manager): New variable.
3678 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3680 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3682 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3684 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3686 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3687 in the current matrix if keep_current_p is non-zero.
3689 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3691 * bidi.c (bidi_level_of_next_char): Fix last change.
3693 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3695 Support bidi reordering of text covered by display properties.
3697 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3698 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3699 (bidi_cache_search, bidi_cache_iterator_state)
3700 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3701 (bidi_level_of_next_char, bidi_move_to_visually_next):
3702 Support character positions inside a run of characters covered by a
3704 (bidi_paragraph_init, bidi_resolve_explicit_1)
3705 (bidi_level_of_next_char): Call bidi_fetch_char and
3706 bidi_fetch_char_advance instead of FETCH_CHAR and
3708 (bidi_init_it): Initialize new members.
3709 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3711 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3712 instead of using explicit *_CHAR codes.
3713 (bidi_resolve_explicit, bidi_resolve_weak):
3714 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3715 bidirectional text is supported only in multibyte buffers.
3716 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3717 it to initialize the frame_window_p member of struct bidi_it.
3718 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3719 (bidi_resolve_explicit, bidi_resolve_weak)
3720 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3721 bidi_it->nchars is non-positive.
3722 (bidi_level_of_next_char): Don't try to lookup the cache for the
3723 next/previous character if nothing is cached there yet, or if we
3724 were just reseat()'ed to a new position.
3726 * xdisp.c (set_cursor_from_row): Set start and stop points
3727 according to the row's direction when priming the loop that looks
3728 for the glyph on which to display cursor.
3729 (single_display_spec_intangible_p): Function deleted.
3730 (display_prop_intangible_p): Reimplement to call
3731 handle_display_spec instead of single_display_spec_intangible_p.
3732 Accept 3 additional arguments needed by handle_display_spec.
3733 This fixes incorrect cursor motion across display property with complex
3734 values: lists, `(when COND...)' forms, etc.
3735 (single_display_spec_string_p): Support property values that are
3736 lists with the argument STRING its top-level element.
3737 (display_prop_string_p): Fix the condition for processing a
3738 property that is a list to be consistent with handle_display_spec.
3739 (handle_display_spec): New function, refactored from the
3740 last portion of handle_display_prop.
3741 (compute_display_string_pos): Accept additional argument
3742 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3743 value of a `display' property is a "replacing spec".
3744 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3745 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3746 the display property, but just return a value indicating whether
3747 the display property will replace the characters it covers.
3748 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3749 frame_window_p members of struct bidi_it.
3750 (compute_display_string_pos, compute_display_string_end):
3752 (push_it): Accept second argument POSITION, where pop_it should
3753 jump to continue iteration.
3754 (reseat_1): Initialize bidi_it.disp_pos.
3756 * keyboard.c (adjust_point_for_property): Adjust the call to
3757 display_prop_intangible_p to its new signature.
3759 * dispextern.h (struct bidi_it): New member frame_window_p.
3760 (bidi_init_it): Update prototypes.
3761 (display_prop_intangible_p): Update prototype.
3762 (compute_display_string_pos, compute_display_string_end):
3764 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3767 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3769 Malloc failure behavior now depends on size of allocation.
3770 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3771 * lisp.h: Change signatures accordingly.
3772 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3773 All callers changed. (Bug#8762)
3775 * gnutls.c: Use Emacs's memory allocators.
3776 Without this change, the gnutls library would invoke malloc etc.
3777 directly, which causes problems on non-SYNC_INPUT hosts, and which
3778 runs afoul of improving memory_full behavior. (Bug#8761)
3779 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3780 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3781 xfree instead of the default malloc, realloc, free.
3782 (Fgnutls_boot): No need to check for memory allocation failure,
3783 since xmalloc does that for us.
3785 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3786 * category.c (hash_get_category_set):
3787 * ccl.c (ccl_driver):
3788 * charset.c (Fdefine_charset_internal):
3789 * charset.h (struct charset.hash_index):
3790 * composite.c (get_composition_id, gstring_lookup_cache)
3791 (composition_gstring_put_cache):
3792 * composite.h (struct composition.hash_index):
3793 * dispextern.h (struct image.hash):
3794 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3795 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3796 (hashfn_equal, hashfn_user_defined, make_hash_table)
3797 (maybe_resize_hash_table, hash_lookup, hash_put)
3798 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3799 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3800 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3801 * image.c (make_image, search_image_cache, lookup_image)
3802 (xpm_put_color_table_h):
3803 * lisp.h (struct Lisp_Hash_Table):
3804 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3805 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3806 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3807 * alloc.c (allocate_vectorlike):
3808 Check for overflow in vector size calculations.
3809 * ccl.c (ccl_driver):
3810 Check for overflow when converting EMACS_INT to int.
3811 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3812 need to be updated by these changes.
3813 * fns.c (make_hash_table, maybe_resize_hash_table):
3814 Check for integer overflow with large hash tables.
3815 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3816 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3817 (SXHASH_REDUCE): New macro.
3818 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3819 Use it instead of discarding useful hash info with large hash values.
3820 (sxhash_float): New function.
3821 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3822 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3823 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3824 Rewrite to use FIXNUM_BITS, as this simplifies things.
3825 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3826 Adjust signatures to match updated version of code.
3827 (consing_since_gc): Now EMACS_INT, since a single hash table can
3828 use more than INT_MAX bytes.
3830 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3832 Make it possible to build with GCC-4.6+ -O2 -flto.
3834 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3836 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3838 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3839 Call minibuffer-inactive-mode.
3841 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3843 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3844 Update dependencies.
3846 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3848 * data.c (init_data): Remove code for UTS, this system is not
3851 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3853 Don't force ./temacs to start in terminal mode.
3855 * frame.c (make_initial_frame): Initialize faces in all cases, not
3856 only when CANNOT_DUMP is defined.
3857 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3859 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3861 * dispnew.c (add_window_display_history): Use const for the string
3862 pointer. Remove declaration, not needed.
3864 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3866 Use 'inline', not 'INLINE'.
3867 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3868 * alloc.c, fontset.c (INLINE): Remove.
3869 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3870 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3871 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3872 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3873 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3875 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3877 Make it possible to run ./temacs.
3879 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3880 syms_of_callproc does the same thing. Remove test for
3881 "initialized", do it in the caller.
3882 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3884 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3886 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3887 (read_minibuf): Use get_minibuffer.
3888 (syms_of_minibuf): Use DEFSYM.
3889 (Qmetadata): New var.
3890 * data.c (Qbuffer): Don't make it static.
3891 (syms_of_data): Use DEFSYM.
3893 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3895 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3896 (CCL_CODE_MIN): New macro.
3898 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3900 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3902 * eval.c (Qdebug): Now static.
3903 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3904 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3905 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3907 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3909 * image.c: Various fixes to ImageMagick code comments.
3910 (Fimagemagick_types): Doc fix.
3912 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3914 Minor fixes prompted by GCC 4.6.0 warnings.
3916 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3918 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3919 (x_clipboard_manager_save_all): Move extern decl to ...
3920 * xterm.h: ... here, so that it can be checked for consistency.
3922 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3924 * xselect.c (x_clipboard_manager_save_frame)
3925 (x_clipboard_manager_save_all): New functions.
3926 (Fx_clipboard_manager_save): Lisp function deleted.
3928 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3929 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3931 * xterm.h: Update prototype.
3933 2011-05-28 William Xu <william.xwl@gmail.com>
3935 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3938 2011-05-28 Jim Meyering <meyering@redhat.com>
3940 Avoid a sign-extension bug in crypto_hash_function.
3941 * fns.c (to_uchar): Define.
3942 (crypto_hash_function): Use it to convert some newly-signed
3943 variables to unsigned, to avoid sign-extension bugs. For example,
3944 without this change, (md5 "truc") would evaluate to
3945 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3946 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3947 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3949 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3951 Integer overflow fixes.
3953 * dbusbind.c: Serial number integer overflow fixes.
3954 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3955 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3956 to hold a serial number that is too large for a fixnum.
3957 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3958 Check for serial numbers out of range. Decode any serial number
3959 that was so large that it became a float. (Bug#8722)
3961 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3962 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3963 Use XFASTINT rather than XUINT when numbers are nonnegative.
3964 (xd_append_arg, Fdbus_method_return_internal):
3965 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3966 arguments, check that Lisp number is nonnegative, rather than
3967 silently wrapping negative numbers around. (Bug#8722)
3968 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3971 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3973 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3975 ccl: add integer overflow checks
3976 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3977 (IN_INT_RANGE): New macros.
3978 (ccl_driver): Use them to check for integer overflow when
3979 decoding a CCL program. Many of the new checks are whether XINT (x)
3980 fits in int; it doesn't always, on 64-bit hosts. The new version
3981 doesn't catch all possible integer overflows, but it's an
3982 improvement. (Bug#8719)
3984 * alloc.c (make_event_array): Use XINT, not XUINT.
3985 There's no need for unsigned here.
3987 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3988 This follows up to the 2011-05-06 change that substituted uintptr_t
3989 for EMACS_INT. This case wasn't caught back then.
3991 Rework Fformat to avoid integer overflow issues.
3992 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3993 now (part of C89). Include <verify.h>.
3994 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3995 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3996 (Fformat): Avoid the prepass trying to compute sizes; it was only
3997 approximate and thus did not catch overflow reliably. Instead, walk
3998 through the format just once, formatting and computing sizes as we go,
3999 checking for integer overflow at every step, and allocating a larger
4000 buffer as needed. Keep track separately whether the format is
4001 multibyte. Keep only the most-recently calculated precision, rather
4002 than them all. Record whether each argument has been converted to
4003 string. Use EMACS_INT, not int, for byte and char and arg counts.
4004 Support field widths and precisions larger than INT_MAX. Avoid
4005 sprintf's undefined behavior with conversion specifications such as %#d
4006 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4007 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4008 formatting out-of-range floating point numbers with int
4011 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4013 * data.c: Avoid integer truncation in expressions involving floats.
4014 * data.c: Include <intprops.h>.
4015 (arith_driver): When there's an integer overflow in an expression
4016 involving floating point, convert the integers to floating point
4017 so that the resulting value does not suffer from catastrophic
4018 integer truncation. For example, on a 64-bit host (* 4
4019 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4020 Do not rely on undefined behavior after integer overflow.
4022 merge count_size_as_multibyte, parse_str_to_multibyte
4023 * character.c, character.h (count_size_as_multibyte):
4024 Rename from parse_str_to_multibyte; all uses changed.
4025 Check for integer overflow.
4026 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4027 since it's now a duplicate of the other. This is more of
4028 a character than a buffer op, so better that it's in character.c.
4029 * fns.c, print.c: Adjust to above changes.
4031 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4033 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4035 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4037 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4038 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4039 (x_clipboard_manager_save): Now static.
4040 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4042 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4043 (crypto_hash_function): Now static.
4044 Fix pointer signedness problems. Avoid unnecessary initializations.
4046 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4048 * termhooks.h (Vselection_alist): Make it terminal-local.
4050 * terminal.c (create_terminal): Initialize it.
4052 * xselect.c: Support for clipboard managers.
4053 (Vselection_alist): Move to termhooks.h as terminal-local var.
4054 (LOCAL_SELECTION): New macro.
4055 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4056 (symbol_to_x_atom): Remove gratuitous arg.
4057 (x_handle_selection_request, lisp_data_to_selection_data)
4058 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4059 (x_own_selection, x_get_local_selection, x_convert_selection):
4060 New arg, specifying work frame. Use terminal-local Vselection_alist.
4061 (some_frame_on_display): Delete unused function.
4062 (Fx_own_selection_internal, Fx_get_selection_internal)
4063 (Fx_disown_selection_internal, Fx_selection_owner_p)
4064 (Fx_selection_exists_p): New optional frame arg.
4065 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4066 (x_handle_selection_clear): Don't treat other terminals with the
4067 same keyboard specially. Use the terminal-local Vselection_alist.
4068 (x_clear_frame_selections): Use Frun_hook_with_args.
4070 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4072 * xterm.h: Add support for those atoms.
4074 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4076 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4077 (converted_selections, conversion_fail_tag): New global variables.
4078 (x_selection_request_lisp_error): Free the above.
4079 (x_get_local_selection): Remove unnecessary code.
4080 (x_reply_selection_request): Args changed; handle arbitrary array
4081 of converted selections stored in converted_selections.
4082 Separate the XChangeProperty and SelectionNotify steps.
4083 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4084 (x_convert_selection): New function.
4085 (x_handle_selection_event): Simplify.
4086 (x_get_foreign_selection): Don't ignore incoming requests while
4087 waiting for an answer; this will fail when we implement
4088 SAVE_TARGETS, and seems unnecessary anyway.
4089 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4090 (Vx_sent_selection_functions): Doc fix.
4092 2011-05-26 Leo Liu <sdl.web@gmail.com>
4094 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4096 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4098 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4100 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4101 for fringe update if it has periodic bitmap.
4102 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4103 and fringe_bitmap_periodic_p.
4105 * fringe.c (get_fringe_bitmap_data): New function.
4106 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4107 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4108 row. Mark glyph row for fringe update if periodicity changed.
4110 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4111 for fringe update unless it has periodic bitmap.
4113 2011-05-25 Kenichi Handa <handa@m17n.org>
4115 * xdisp.c (get_next_display_element): Set correct it->face_id for
4116 a static composition.
4118 2011-05-24 Leo Liu <sdl.web@gmail.com>
4121 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4123 * fns.c (crypto_hash_function, Fsha1): New function.
4124 (Fmd5): Use crypto_hash_function.
4125 (syms_of_fns): Add Ssha1.
4127 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4129 * gnutls.c: Remove unused macros.
4130 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4131 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4132 Remove macros that are defined and never used.
4133 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4135 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4137 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4138 (Fx_get_selection_internal): Minor cleanup.
4139 (Fx_own_selection_internal): Rename arguments for consistency with
4142 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4144 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4146 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4148 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4150 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4152 * dispnew.c (scrolling_window): Don't exclude the case that the
4153 last enabled row in the desired matrix touches the bottom boundary.
4155 2011-05-21 Glenn Morris <rgm@gnu.org>
4157 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4158 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4159 and add some more files.
4161 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4163 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4164 report_file_error introduced by the change from 2011-05-07.
4166 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4168 * systime.h (Time): Define only if emacs is defined.
4169 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4170 where the include path doesn't have X11/X.h by default. See
4171 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4173 2011-05-20 Kenichi Handa <handa@m17n.org>
4175 * composite.c (find_automatic_composition): Fix previous change.
4177 2011-05-20 Glenn Morris <rgm@gnu.org>
4179 * lisp.mk: New file, split from Makefile.in.
4180 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4181 (shortlisp): Remove.
4182 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4184 2011-05-19 Glenn Morris <rgm@gnu.org>
4186 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4187 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4188 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4189 (lisp): Set the order to that of loadup.el.
4190 (shortlisp): Make it a copy of $lisp.
4191 (SOME_MACHINE_LISP): Remove.
4192 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4193 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4195 2011-05-18 Kenichi Handa <handa@m17n.org>
4197 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4198 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4199 (find_automatic_composition): Mostly rewrite for efficiency.
4201 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4203 * makefile.w32-in: Update dependencies.
4205 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4207 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4208 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4210 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4212 Fix some integer overflow issues, such as string length overflow.
4214 * insdel.c (count_size_as_multibyte): Check for string overflow.
4216 * character.c (lisp_string_width): Check for string overflow.
4217 Use EMACS_INT, not int, for string indexes and lengths; in
4218 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4219 the resulting string length overflows an EMACS_INT; instead,
4220 report a string overflow if no precision given. When checking for
4221 precision exhaustion, use a check that cannot possibly have
4222 integer overflow. (Bug#8675)
4223 * character.h (lisp_string_width): Adjust to new signature.
4225 * alloc.c (string_overflow): New function.
4226 (Fmake_string): Use it. This doesn't change behavior, but saves
4227 a few bytes and will simplify future changes.
4228 * character.c (string_escape_byte8): Likewise.
4229 * lisp.h (string_overflow): New decl.
4231 Fixups, following up to the user-interface timestamp change.
4232 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4233 for UI timestamps, instead of unsigned long.
4234 * msdos.c (mouse_get_pos): Likewise.
4235 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4236 * w32gui.h (Time): Define by including "systime.h" rather than by
4237 declaring it ourselves. (Bug#8664)
4239 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4240 * image.c (clear_image_cache): Likewise.
4242 * term.c (term_mouse_position): Don't assume time_t wraparound.
4244 Be more systematic about user-interface timestamps.
4245 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4246 and sometimes 'EMACS_UINT', to represent these timestamps.
4247 This change causes it to use 'Time' uniformly, as that's what X uses.
4248 This makes the code easier to follow, and makes it easier to catch
4249 integer overflow bugs such as Bug#8664.
4250 * frame.c (Fmouse_position, Fmouse_pixel_position):
4251 Use Time, not unsigned long, for user-interface timestamps.
4252 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4253 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4254 * keyboard.h (last_event_timestamp): Likewise.
4255 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4256 * menu.h (xmenu_show): Likewise.
4257 * term.c (term_mouse_position): Likewise.
4258 * termhooks.h (struct input_event.timestamp): Likewise.
4259 (struct terminal.mouse_position_hook): Likewise.
4260 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4261 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4262 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4263 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4265 * menu.h, termhooks.h: Include "systime.h", for Time.
4267 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4268 Don't assume that the difference between two unsigned long values
4269 can fit into an integer. At this point, we know button_down_time
4270 <= event->timestamp, so the difference must be nonnegative, so
4271 there's no need to cast the result if double-click-time is
4272 nonnegative, as it should be; check that it's nonnegative, just in
4273 case. This bug is triggered when events are more than 2**31 ms
4274 apart (about 25 days). (Bug#8664)
4276 * xselect.c (last_event_timestamp): Remove duplicate decl.
4277 (x_own_selection): Remove needless cast to unsigned long.
4279 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4280 that always fit in int. Use a sentinel instead of a counter, to
4281 avoid a temp and to allay GCC's concerns about possible int overflow.
4282 * frame.h (struct frame): Use int for menu_bar_items_used
4283 instead of EMACS_INT, since it always fits in int.
4285 * menu.c (grow_menu_items): Check for int overflow.
4287 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4289 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4290 Before, the code was not consistent. These values cannot exceed
4291 2**31 - 1 so there's no need to make them unsigned.
4292 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4293 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4294 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4296 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4298 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4299 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4300 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4301 presumably because the widths might not match.
4303 * window.c (size_window): Avoid needless test at loop start.
4305 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4307 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4309 2011-05-12 Drew Adams <drew.adams@oracle.com>
4311 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4313 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4315 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4316 `width' to `bar_area_x' and `bar_area_width', respectively.
4317 (x_scroll_run): Take account of fringe background extension.
4319 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4320 Rename local vars `left' and `width' to `bar_area_x' and
4321 `bar_area_width', respectively.
4322 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4323 background extension.
4325 2011-05-10 Jim Meyering <meyering@redhat.com>
4327 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4329 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4331 * image.c (Finit_image_library): Return t for built-in image types,
4332 like pbm and xbm. (Bug#8640)
4334 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4336 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4338 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4340 * w32console.c (Fset_screen_color): Doc fix.
4341 (Fget_screen_color): New function.
4342 (syms_of_ntterm): Defsubr it.
4344 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4345 unlink the temporary file if Fcall_process didn't create it in the
4347 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4348 child process will be redirected to a file specified with `:file'.
4349 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4350 cue to call_process_cleanup not to close that handle.
4352 2011-05-07 Ben Key <bkey76@gmail.com>
4354 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4355 one of two shell specific rules, either bootstrap-temacs-CMD or
4356 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4357 to the previous implementation of the bootstrap-temacs rule.
4358 The bootstrap-temacs-CMD rule is similar to the previous
4359 implementation of the bootstrap-temacs rule except that it
4360 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4363 These changes, along with some changes to nt/configure.bat,
4364 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4365 earlier fix to add support for --cflags and --ldflags options
4366 that include quotes so that it works whether make uses cmd or
4369 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4371 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4372 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4374 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4375 a string. Handle both cases.
4376 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4377 (Fdbus_register_method): Use Qinvalid_function.
4379 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4381 * makefile.w32-in: Update dependencies.
4382 (LISP_H): Add inttypes.h and stdin.h.
4383 (PROCESS_H): Add unistd.h.
4385 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4387 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4388 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4390 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4392 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4394 * term.c (vfatal): Remove stray call to va_end.
4395 It's not needed and the C Standard doesn't allow it here anyway.
4397 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4398 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4400 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4403 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4405 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4407 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4409 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4411 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4413 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4414 * charset.c (Fdefine_charset_internal): Don't initialize
4415 charset.code_space[15]. The value was garbage, on hosts with
4416 32-bit int (Bug#8600).
4418 * lread.c (read_integer): Be more consistent with string-to-number.
4419 Use string_to_number to do the actual conversion; this avoids
4420 rounding errors and fixes some other screwups. Without this fix,
4421 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4422 (digit_to_number): Move earlier, for benefit of read_integer.
4423 Return -1 if the digit is out of range for the base, -2 if it is
4424 not a digit in any supported base. (Bug#8602)
4426 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4428 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4429 to match comment at start of function. This also removes a
4430 GCC warning about overflow in a 32+64-bit port.
4432 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4434 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4435 Reported by Stefan Monnier in
4436 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4437 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4438 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4440 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4441 (EMACS_UINTPTR): Likewise, with uintptr_t.
4443 * lisp.h: Prefer 64-bit EMACS_INT if available.
4444 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4445 on 32-bit hosts that have 64-bit int, so that they can access
4447 However, temporarily disable this change unless the temporary
4448 symbol WIDE_EMACS_INT is defined.
4450 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4452 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4453 This removes an assumption that EMACS_INT and long are the same
4454 width as pointers. The assumption is true for Emacs porting targets
4455 now, but we want to make other targets possible.
4456 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4457 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4458 In the rest of the code, change types of integers that hold casted
4459 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4460 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4461 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4462 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4463 No need to cast type when ORing.
4464 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4465 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4466 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4467 assume EMACS_INT is the same width as char *.
4468 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4469 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4470 Remove no-longer-needed casts.
4471 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4472 (xg_tool_bar_help_callback, xg_make_tool_item):
4473 Use EMACS_INTPTR to hold an integer
4474 that will be cast to void *; this can avoid a GCC warning
4475 if EMACS_INT is not the same width as void *.
4476 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4477 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4478 (current_message_1, set_message_1):
4479 Use a local to convert to proper width without a cast.
4480 * xmenu.c (dialog_selection_callback): Likewise.
4482 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4483 Also, don't assume VALBITS / RAND_BITS is less than 5,
4484 and don't rely on undefined behavior when shifting a 1 left into
4486 * lisp.h (get_random): Change signature to match.
4488 * lread.c (hash_string): Use size_t, not int, for hash computation.
4489 Normally we prefer signed values; but hashing is special, because
4490 it's better to use unsigned division on hash table sizes so that
4491 the remainder is nonnegative. Also, size_t is the natural width
4492 for hashing into memory. The previous code used 'int', which doesn't
4493 retain enough info to hash well into very large tables.
4494 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4496 * dbusbind.c: Don't possibly lose pointer info when converting.
4497 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4498 Use XPNTR rather than XHASH, so that the high-order bits of
4499 the pointer aren't lost when converting through void *.
4501 * eval.c (Fautoload): Don't double-shift a pointer.
4503 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4505 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4507 * gnutls.c (DEF_GNUTLS_FN):
4508 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4510 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4512 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4515 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4517 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4518 New version that can reserve upto 2GB of heap space.
4520 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4522 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4524 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4526 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4527 `gnutls_certificate_set_x509_key_file'.
4529 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4531 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4532 Update dependencies.
4534 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4536 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4537 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4538 Remove unused parameter `fildes'.
4539 * process.c (read_process_output, send_process): Don't pass it.
4541 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4543 Fix previous change: the library cache is defined in w32.c.
4544 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4545 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4547 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4549 Implement dynamic loading of GnuTLS on Windows.
4551 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4552 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4553 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4556 * gnutls.c (Qgnutls_dll): Define.
4557 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4558 (gnutls_*): Declare function pointers.
4559 (init_gnutls_functions): New function to initialize function pointers.
4560 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4561 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4562 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4563 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4564 (emacs_gnutls_write, emacs_gnutls_read)
4565 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4566 (Fgnutls_available_p): New function.
4567 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4568 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4569 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4571 * image.c: Include w32.h.
4572 (Vimage_type_cache): Delete.
4573 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4574 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4575 (w32_delayed_load): Move to w32.c.
4577 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4579 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4580 (w32_delayed_load): Move from image.c. When loading a library, record
4581 its filename in the :loaded-from property of the library id.
4582 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4583 Initialize and staticpro them.
4584 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4586 * process.c: Include lisp.h before w32.h, not after.
4587 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4588 instead of gnutls_record_check_pending.
4590 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4592 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4594 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4595 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4598 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4600 * xterm.c (x_set_frame_alpha): Do not set property on anything
4601 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4603 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4605 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4607 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4609 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4610 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4611 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4612 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4613 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4614 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4615 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4616 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4617 (Qgnutls_bootprop_callbacks_verify): Make static.
4619 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4621 * callproc.c: Indentation fixup.
4623 * sysdep.c (wait_for_termination_1): Make static.
4624 (wait_for_termination, interruptible_wait_for_termination):
4625 Move after wait_for_termination_1.
4627 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4629 * sysdep.c (interruptible_wait_for_termination): New function
4630 which is like wait_for_termination, but allows keyboard
4633 * callproc.c (Fcall_process): Add (:file "file") as an option for
4635 (Fcall_process_region): Ditto.
4637 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4639 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4640 rather than `XVECTOR (FOO)->size'.
4642 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4643 inttypes.h, as a gnulib replacement is used if it not available in
4646 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4648 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4649 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4650 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4652 * coding.c (coding_alloc_by_realloc): Error out if destination
4653 will grow beyond MOST_POSITIVE_FIXNUM.
4654 (decode_coding_emacs_mule): Abort if there isn't enough place in
4655 charbuf for the composition carryover bytes. Reserve an extra
4656 space for up to 2 characters produced in a loop.
4657 (decode_coding_iso_2022): Abort if there isn't enough place in
4658 charbuf for the composition carryover bytes.
4660 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4662 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4663 aborting when %lld or %lll format is passed.
4664 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4665 %llo or %llx format is passed. (Bug#8545)
4667 * window.c (window_scroll_line_based): Use a marker instead of
4668 simple variables to record original value of point. (Bug#7952)
4670 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4671 produced by %s or %c overflows available buffer space. (Bug#8545)
4673 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4675 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4676 (SIZE_MAX): Move defn after all includes, as they might #define it.
4678 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4680 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4682 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4684 * keyboard.c (Qdelayed_warnings_hook): Define.
4685 (command_loop_1): Run `delayed-warnings-hook'
4686 if Vdelayed_warnings_list is non-nil.
4687 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4688 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4690 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4692 * doprnt.c (doprnt): Don't return value smaller than the buffer
4693 size if the message was truncated. (Bug#8545).
4695 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4697 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4698 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4700 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4702 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4704 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4706 * makefile.w32-in: Update dependencies.
4708 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4710 Improve `doprnt' and its usage. (Bug#8545)
4711 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4712 `format_end'. Remove support for %l as a conversion specifier.
4713 Don't use xrealloc. Improve diagnostics when the %l size modifier
4714 is used. Update the commentary.
4716 * eval.c (verror): Simplify calculation of size_t.
4718 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4721 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4723 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4726 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4728 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4729 This makes this file independent of the recent pseudovector change.
4731 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4733 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4735 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4736 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4737 Remove unused local.
4738 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4740 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4741 GCC 4.6.0 optimizes based on type-based alias analysis.
4742 For example, if b is of type struct buffer * and v of type struct
4743 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4744 != &v->size, and therefore "v->size = 1; b->size = 2; return
4745 v->size;" must therefore return 1. This assumption is incorrect
4746 for Emacs, since it type-puns struct Lisp_Vector * with many other
4747 types. To fix this problem, this patch adds a new type struct
4748 vectorlike_header that documents the constraints on layout of vectors
4749 and pseudovectors, and helps optimizing compilers not get fooled
4750 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4751 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4752 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4754 (XSETPVECTYPE): Rewrite in terms of new macro.
4755 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4756 This is a bit clearer, and further avoids the possibility of
4757 undesirable aliasing.
4758 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4759 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4760 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4761 since Lisp_Subr is a special case (no "next" field).
4762 (ASIZE): Now uses header.size rather than size.
4763 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4764 to avoid the hassle of writing XVECTOR (foo)->header.size.
4765 (struct vectorlike_header): New type.
4766 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4767 object, to help avoid aliasing.
4768 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4769 (SUBRP): Likewise, since Lisp_Subr is a special case.
4770 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4771 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4772 (struct Lisp_Hash_Table): Combine first two members into a single
4773 struct vectorlike_header member. All uses of "size" and "next" members
4774 changed to be "header.size" and "header.next".
4775 * buffer.h (struct buffer): Likewise.
4776 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4777 * frame.h (struct frame): Likewise.
4778 * process.h (struct Lisp_Process): Likewise.
4779 * termhooks.h (struct terminal): Likewise.
4780 * window.c (struct save_window_data, struct saved_window): Likewise.
4781 * window.h (struct window): Likewise.
4782 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4783 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4784 * buffer.c (init_buffer_once): Likewise.
4785 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4787 * process.c (Fformat_network_address): Use local var for size,
4790 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4792 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4793 * data.c (atof): Remove decl; no longer used or needed.
4794 (digit_to_number): Move to lread.c.
4795 (Fstring_to_number): Use new string_to_number function, to be
4796 consistent with how the Lisp reader treats infinities and NaNs.
4797 Do not assume that floating-point numbers represent EMACS_INT
4798 without losing information; this is not true on most 64-bit hosts.
4799 Avoid double-rounding errors, by insisting on integers when
4800 parsing non-base-10 numbers, as the documentation specifies.
4801 * lisp.h (string_to_number): New decl, replacing ...
4802 (isfloat_string): Remove.
4803 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4804 (read1): Do not accept +. and -. as integers; this
4805 appears to have been a coding error. Similarly, do not accept
4806 strings like +-1e0 as floating point numbers. Do not report
4807 overflow for integer overflows unless the base is not 10 which
4808 means we have no simple and reliable way to continue.
4809 Break out the floating-point parsing into a new
4810 function string_to_number, so that Fstring_to_number parses
4811 floating point numbers consistently with the Lisp reader.
4812 (digit_to_number): Move here from data.c. Make it static inline.
4813 (E_CHAR, EXP_INT): Remove, replacing with ...
4814 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4815 (string_to_number): New function, replacing isfloat_string.
4816 This function checks for valid syntax and produces the resulting
4817 Lisp float number too. Rework it so that string-to-number
4818 no longer mishandles examples like "1.0e+". Use strtoumax,
4819 so that overflow for non-base-10 numbers is reported only when
4820 there's no portable and simple way to convert to floating point.
4822 * textprop.c (set_text_properties_1): Rewrite for clarity,
4823 and to avoid GCC warning about integer overflow.
4825 * intervals.h (struct interval): Use EMACS_INT for members
4826 where EMACS_UINT might cause problems. See
4827 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4828 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4829 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4831 (offset_intervals): Tell GCC not to worry about length overflow
4832 when negating a negative length.
4834 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4835 (overrun_check_free): Likewise.
4837 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4838 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4841 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4842 (gnutls_make_error): Rename local to avoid shadowing.
4843 (gnutls_emacs_global_deinit): ifdef out; not used.
4844 (Fgnutls_boot): Use const for pointer to readonly storage.
4845 Comment out unused local. Fix pointer signedness problems.
4847 * lread.c (openp): Don't stuff size_t into an 'int'.
4848 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4849 about possible signed overflow.
4851 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4852 (GDK_KEY_g): Don't define if already defined.
4853 (xg_prepare_tooltip): Avoid pointer signedness problem.
4854 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4856 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4857 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4859 * xfns.c (Fx_window_property): Simplify a bit,
4860 to make a bit faster and to avoid GCC 4.6.0 warning.
4861 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4863 * fns.c (internal_equal): Don't assume size_t fits in int.
4865 * alloc.c (compact_small_strings): Tighten assertion a little.
4867 Replace pEd with more-general pI, and fix some printf arg casts.
4868 * lisp.h (pI): New macro, generalizing old pEd macro to other
4869 conversion specifiers. For example, use "...%"pI"d..." rather
4870 than "...%"pEd"...".
4871 (pEd): Remove. All uses replaced with similar uses of pI.
4872 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4873 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4874 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4875 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4876 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4877 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4878 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4880 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4881 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4882 * print.c (safe_debug_print, print_object): Likewise.
4883 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4885 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4886 avoiding the 0 flag, which is not portable.
4887 * process.c (Fmake_network_process): Use pI to avoid cast.
4888 * region-cache.c (pp_cache): Likewise.
4889 * xdisp.c (decode_mode_spec): Likewise.
4890 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4891 behavior on 64-bit hosts with printf arg.
4892 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4893 (x_stop_queuing_selection_requests): Likewise.
4894 (x_get_window_property): Don't truncate byte count to an 'int'
4897 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4898 here, since it parses constructs like leading '-' and spaces,
4899 which are not wanted; and it overflows with large numbers.
4900 Instead, simply match F[0-9]+, which is what is wanted anyway.
4902 * alloc.c: Remove unportable assumptions about struct layout.
4903 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4904 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4905 (allocate_vectorlike, make_pure_vector): Use the new macros,
4906 plus offsetof, to remove unportable assumptions about struct layout.
4907 These assumptions hold on all porting targets that I know of, but
4908 they are not guaranteed, they're easy to remove, and removing them
4909 makes further changes easier.
4911 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4912 This doesn't fix a bug but makes the code clearer.
4913 (string_overrun_cookie): Now const. Use initializers that
4914 don't formally overflow signed char, to avoid warnings.
4915 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4916 can cause Emacs to crash when string overrun checking is enabled.
4917 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4918 multiple of sizeof (EMACS_INT); it need not be, if
4919 alignof(EMACS_INT) < sizeof (EMACS_INT).
4920 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4922 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4924 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4926 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4928 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4929 supposed to be handshaking. (Bug#8556)
4930 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4932 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4934 * lisp.h (Qdebug): List symbol.
4935 * eval.c (Qdebug): Restore global linkage.
4936 * keyboard.c (debug-on-event): New variable.
4937 (handle_user_signal): Break into debugger when debug-on-event
4938 matches the current signal symbol.
4940 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4942 * alloc.c (check_sblock, check_string_bytes)
4943 (check_string_free_list): Convert to standard C.
4945 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4947 * w32.c (emacs_gnutls_push): Fix typo.
4949 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4951 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4952 "cast to pointer from integer of different size".
4954 Improve doprnt and its use in verror. (Bug#8545)
4955 * doprnt.c (doprnt): Document the set of format control sequences
4956 supported by the function. Use SAFE_ALLOCA instead of always
4959 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4960 is one byte too soon. Don't use xrealloc; instead xfree and
4963 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4965 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4968 * gnutls.c: Renamed global_initialized to
4969 gnutls_global_initialized. Added internals for the
4970 :verify-hostname-error, :verify-error, and :verify-flags
4971 parameters of `gnutls-boot' and documented those parameters in the
4972 docstring. Start callback support.
4973 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4974 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4975 on error. Return error code.
4976 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4977 (emacs_gnutls_read): Likewise.
4978 (Fgnutls_boot): Return handshake error code.
4979 (emacs_gnutls_handle_error): New function.
4980 (wsaerror_to_errno): Likewise.
4982 * w32.h (emacs_gnutls_pull): Add prototype.
4983 (emacs_gnutls_push): Likewise.
4985 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4986 (emacs_gnutls_push): Likewise.
4988 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4990 * process.c (wait_reading_process_output): Check if GnuTLS
4991 buffered some data internally if no FDs are set for TLS
4994 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4995 (LIBS): Link to USER_LIBS.
4996 ($(BLD)/gnutls.$(0)): New target.
4998 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5000 * xdisp.c (handle_single_display_spec): Rename the
5001 display_replaced_before_p argument into display_replaced_p, to
5002 make it consistent with the commentary. Fix typos in the
5005 * textprop.c (syms_of_textprop): Remove dead code.
5006 (copy_text_properties): Delete obsolete commentary about an
5007 interface that was deleted long ago. Fix typos in the description
5010 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5011 to changes in oldXMenu/XMenu.h from 2011-04-16.
5012 <menu_help_message, prev_menu_help_message>: Constify.
5013 (IT_menu_make_room): menu->help_text is now `const char **';
5016 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5017 to changes in oldXMenu/XMenu.h from 2011-04-16.
5018 (struct XMenu): Declare `help_text' `const char **'.
5020 * xfaces.c <Qunspecified>: Make extern again.
5022 * syntax.c: Include sys/types.h before including regex.h, as
5025 * doc.c (get_doc_string): Improve the format passed to `error'.
5027 * doprnt.c (doprnt): Improve commentary.
5029 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5031 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5034 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5035 changes in globals.h immediately force recompilation.
5036 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5037 $(CURDIR)/s/ms-w32.h.
5038 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5040 * character.c (Fchar_direction): Function deleted.
5041 (syms_of_character): Don't defsubr it.
5042 <char-direction-table>: Deleted.
5044 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5046 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5047 * doprnt.c: Include limits.h.
5048 (SIZE_MAX): New macro.
5049 (doprnt): Return a size_t value. 2nd arg is now size_t.
5050 Many local variables are now size_t instead of int or unsigned.
5051 Improve overflow protection. Support `l' modifier for integer
5052 conversions. Support %l conversion. Don't assume an EMACS_INT
5053 argument for integer conversions and for %c.
5055 * lisp.h (doprnt): Restore prototype.
5057 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5060 * Makefile.in (base_obj): Add back doprnt.o.
5062 * deps.mk (doprnt.o): Add back prerequisites.
5063 (callint.o): Depend on character.h.
5065 * eval.c (internal_lisp_condition_case): Include the handler
5066 representation in the error message.
5067 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5068 when breaking from the loop.
5070 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5072 * callint.c (Fcall_interactively): When displaying error message
5073 about invalid control letter, pass the character's codepoint, not
5074 a pointer to its multibyte form. Improve display of the character
5075 in octal and display also its hex code.
5077 * character.c (char_string): Use %x to display the (unsigned)
5078 codepoint of an invalid character, to avoid displaying a bogus
5081 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5082 `error', not SYMBOL_NAME itself.
5084 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5085 character arguments to `error'.
5087 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5088 to `error' in error message about FINAL_CHAR argument. Make sure
5089 FINAL_CHAR is a character, and use %c when it is passed as
5090 argument to `error'.
5092 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5094 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5096 * w32.c: Include <time.h>.
5097 (sys_localtime): New function.
5099 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5101 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5103 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5105 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5107 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5110 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5112 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5113 gl_state.e_property when gl_state.object is Qt.
5115 * insdel.c (make_gap_larger): Remove limitation of buffer size
5118 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5120 * xdisp.c (lookup_glyphless_char_display)
5121 (produce_glyphless_glyph): Handle cons cell entry in
5122 glyphless-char-display.
5123 (Vglyphless_char_display): Document it.
5125 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5126 glyphless-char-display.
5128 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5130 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5132 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5134 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5135 definition for no-X builds.
5137 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5139 Static checks with GCC 4.6.0 and non-default toolkits.
5141 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5143 * process.c (keyboard_bit_set): Define only if SIGIO.
5144 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5145 (send_process): Repair possible setjmp clobbering.
5147 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5149 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5151 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5153 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5154 Define only if needed.
5156 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5157 by pacifying GCC about it. Maybe it's time to retire it?
5158 * xfaces.c (USG, __TIMEVAL__): Likewise.
5160 * dispextern.h (struct redisplay_interface): Rename param
5162 * termhooks.h (struct terminal): Likewise.
5163 * xterm.c (xembed_send_message): Likewise.
5165 * insdel.c (make_gap_smaller): Define only if
5166 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5168 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5171 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5172 so that we aren't warned about unused symbols.
5174 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5176 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5178 * xfns.c (x_real_positions): Mark locals as initialized.
5180 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5182 * xterm.c: Fix problems found by static analysis with other toolkits.
5183 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5184 (x_dispatch_event): Declare static if USE_GTK, and
5185 define if USE_GTK || USE_X_TOOLKIT.
5186 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5187 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5188 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5189 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5191 * xmenu.c (menu_help_callback): Pointer type fixes.
5192 Use const pointers when pointing at readonly data. Avoid pointer
5194 (FALSE): Remove unused macro.
5195 (update_frame_menubar): Remove unused decl.
5197 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5199 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5200 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5201 (single_menu_item): Rename local to avoid shadowing.
5203 * keyboard.c (make_lispy_event): Remove unused local var.
5205 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5206 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5208 * bitmaps: Change bitmaps from unsigned char back to the X11
5209 compatible char. Avoid the old compiler warnings about
5210 out-of-range initializers by using, for example, '\xab' rather
5213 * xgselect.c (xgselect_initialize): Check vs interface
5214 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5216 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5218 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5219 to read-only memory.
5221 * fns.c (vector): Remove; this old hack is no longer needed.
5223 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5225 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5227 * xrdb.c (x_load_resources): Omit unused local.
5229 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5230 (x_window): Rename locals to avoid shadowing.
5231 (USG): Use the kludged USG macro, to pacify gcc.
5233 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5234 (x_term_init): Remove local to avoid shadowing.
5236 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5238 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5239 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5241 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5243 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5245 Fix regex.c, syntax.c and friends for buffers > 2GB.
5246 * syntax.h (struct gl_state_s): Declare character position members
5249 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5251 * textprop.c (verify_interval_modification, interval_of):
5252 Declare arguments EMACS_INT.
5254 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5257 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5259 * indent.c (Fvertical_motion): Local variable it_start is now
5262 * regex.c (re_match, re_match_2, re_match_2_internal)
5263 (bcmp_translate, regcomp, regexec, print_double_string)
5264 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5265 (re_compile_pattern, re_exec): Declare arguments and local
5266 variables `size_t' and `ssize_t' and return values `regoff_t', as
5268 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5269 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5270 <compile_stack_type>: `size' and `avail' are now `size_t'.
5272 * regex.h <regoff_t>: Use ssize_t, not int.
5273 (re_search, re_search_2, re_match, re_match_2): Arguments that
5274 specify buffer/string position and length are now ssize_t and
5275 size_t. Return type is regoff_t.
5277 2011-04-16 Ben Key <bkey76@gmail.com>
5279 * nsfont.m: Fixed bugs in ns_get_family and
5280 ns_descriptor_to_entity that were caused by using free to
5281 deallocate memory blocks that were allocated by xmalloc (via
5282 xstrdup). This caused Emacs to crash when compiled with
5283 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5284 --enable-checking=xmallocoverrun). xfree is now used to
5285 deallocate these memory blocks.
5287 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5289 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5291 emacs_write: Accept and return EMACS_INT for sizes.
5292 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5294 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5295 Accept and return EMACS_INT.
5296 (emacs_gnutls_write): Return the number of bytes written on
5298 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5299 (emacs_read, emacs_write): Remove check for negative size, as the
5300 Emacs source code has been audited now.
5301 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5302 (emacs_read, emacs_write): Use it.
5303 * process.c (send_process): Adjust to the new signatures of
5304 emacs_write and emacs_gnutls_write. Do not attempt to store
5305 a byte offset into an 'int'; it might overflow.
5306 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5308 * sound.c: Don't assume sizes fit in 'int'.
5309 (struct sound_device.period_size, alsa_period_size):
5310 Return EMACS_INT, not int.
5311 (struct sound_device.write, vox_write, alsa_write):
5312 Accept EMACS_INT, not int.
5313 (wav_play, au_play): Use EMACS_INT to store sizes and to
5314 record read return values.
5316 2011-04-15 Ben Key <bkey76@gmail.com>
5318 * keyboard.c (Qundefined): Don't declare static since it is used
5320 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5321 static since they are used in nsfont.m.
5323 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5325 * process.c (Qprocessp): Don't declare static.
5326 * lisp.h (Qprocessp): Declare again.
5328 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5330 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5332 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5334 Improve C-level modularity by making more things 'static'.
5336 Don't publish debugger-only interfaces to other modules.
5337 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5338 (verify_bytepos, count_markers): Move decls to the only modules
5340 * region-cache.h (pp_cache): Likewise.
5341 * window.h (check_all_windows): Likewise.
5342 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5344 * sysdep.c (croak): Now static, if
5345 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5346 * syssignal.h (croak): Declare only if not static.
5348 * alloc.c (refill_memory_reserve): Now static if
5349 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5350 * lisp.h (refill_memory_reserve): Declare only if not static.
5352 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5353 Define only if USE_LUCID.
5355 * xrdb.c (x_customization_string, x_rm_string): Now static.
5357 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5358 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5360 * xdisp.c (draw_row_with_mouse_face): Now static.
5361 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5363 * window.h (check_all_windows): Mark externally visible.
5365 * window.c (window_deletion_count): Now static.
5367 * undo.c: Make symbols static if they're not exported.
5368 (last_undo_buffer, last_boundary_position, pending_boundary):
5371 * textprop.c (interval_insert_behind_hooks): Now static.
5372 (interval_insert_in_front_hooks): Likewise.
5374 * term.c: Make symbols static if they're not exported.
5375 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5376 (max_frame_lines, tty_set_terminal_modes):
5377 (tty_reset_terminal_modes, tty_turn_off_highlight):
5378 (get_tty_terminal): Now static.
5379 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5380 * termhooks.h (term_mouse_moveto): Do not declare if
5382 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5383 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5385 * sysdep.c: Make symbols static if they're not exported.
5386 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5388 (sigprocmask_set, full_mask): Remove; unused.
5389 (wait_debugging): Mark as visible.
5390 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5391 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5393 * syntax.c (syntax_temp): Define only if !__GNUC__.
5395 * sound.c (current_sound_device, current_sound): Now static.
5397 * search.c (searchbufs, searchbuf_head): Now static.
5399 * scroll.c (scroll_cost): Remove; unused.
5400 * dispextern.h (scroll_cost): Remove decl.
5402 * region-cache.h (pp_cache): Mark as externally visible.
5404 * process.c: Make symbols static if they're not exported.
5405 (process_tick, update_tick, create_process, chan_process):
5406 (Vprocess_alist, proc_buffered_char, datagram_access):
5407 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5408 (deactivate_process): Mark defn as static, as well as decl.
5409 * lisp.h (create_process): Remove decl.
5410 * process.h (chan_process, Vprocess_alist): Remove decls.
5412 * print.c: Make symbols static if they're not exported.
5413 (print_depth, new_backquote_output, being_printed, print_buffer):
5414 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5415 (print_interval, print_number_index, initial_stderr_stream):
5417 * lisp.h (Fprinc): Remove decl.
5418 (debug_output_compilation_hack): Mark as externally visible.
5420 * sysdep.c (croak): Move decl from here to syssignal.h.
5421 * syssignal.h (croak): Put it here, so the API can be checked when
5422 'croak' is called from dissociate_if_controlling_tty.
5424 * minibuf.c: Make symbols static if they're not exported.
5425 (minibuf_save_list, choose_minibuf_frame): Now static.
5426 * lisp.h (choose_minibuf_frame): Remove decl.
5428 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5430 * lread.c: Make symbols static if they're not exported.
5431 (read_objects, initial_obarray, oblookup_last_bucket_number):
5433 (make_symbol): Remove; unused.
5434 * lisp.h (initial_obarray, make_symbol): Remove decls.
5436 * keyboard.c: Make symbols static if they're not exported.
5437 (single_kboard, recent_keys_index, total_keys, recent_keys):
5438 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5439 (this_single_command_key_start, echoing, last_auto_save):
5440 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5441 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5442 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5443 (Vlispy_mouse_stem, double_click_count):
5445 (force_auto_save_soon): Define only if SIGDANGER.
5446 (ignore_mouse_drag_p): Now static if
5447 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5448 (print_help): Remove; unused.
5449 (stop_character, last_timer_event): Mark as externally visible.
5450 * keyboard.h (ignore_mouse_drag_p): Declare only if
5451 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5452 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5453 * lisp.h (echoing): Remove decl.
5454 (force_auto_save_soon): Declare only if SIGDANGER.
5455 * xdisp.c (redisplay_window): Simplify code, to make it more
5456 obvious that ignore_mouse_drag_p is not accessed if !defined
5457 USE_GTK && !defined HAVE_NS.
5459 * intervals.c: Make symbols static if they're not exported.
5460 (merge_properties_sticky, merge_interval_right, delete_interval):
5462 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5464 * insdel.c: Make symbols static if they're not exported.
5465 However, leave prepare_to_modify_buffer alone. It's never
5466 called from outside this function, but that appears to be a bug.
5467 (combine_after_change_list, combine_after_change_buffer):
5468 (adjust_after_replace, signal_before_change): Now static.
5469 (adjust_after_replace_noundo): Remove; unused.
5470 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5471 (signal_before_change): Remove decls.
5473 * indent.c (val_compute_motion, val_vmotion): Now static.
5475 * image.c: Make symbols static if they're not exported.
5476 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5478 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5479 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5481 * fringe.c (standard_bitmaps): Now static.
5482 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5484 * frame.c: Make symbols static if they're not exported.
5485 (x_report_frame_params, make_terminal_frame): Now static.
5486 (get_frame_param): Now static, unless HAVE_NS.
5487 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5488 (x_get_resource_string): Remove; not used.
5489 * frame.h (make_terminal_frame, x_report_frame_params):
5490 (x_get_resource_string); Remove decls.
5491 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5492 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5494 * font.c, fontset.c: Make symbols static if they're not exported.
5495 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5496 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5497 * font.c (font_close_object): Now static.
5498 * font.h (font_close_object): Remove.
5499 * fontset.c (FONTSET_OBJLIST): Remove.
5500 (free_realized_fontset) #if-0 the body, which does nothing.
5501 (face_suitable_for_char_p): #if-0, as it's never called.
5502 * fontset.h (face_suitable_for_char_p): Remove decl.
5503 * xfaces.c (face_at_string_position):
5504 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5505 since 0 is always ASCII.
5507 * fns.c (weak_hash_tables): Now static.
5509 * fileio.c: Make symbols static if they're not exported.
5510 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5511 (Vwrite_region_annotation_buffers): Now static.
5513 * eval.c: Make symbols static if they're not exported.
5514 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5515 * lisp.h (backtrace_list): Remove decl.
5517 * emacs.c: Make symbols static if they're not exported.
5518 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5519 (fatal_error_code, fatal_error_signal_hook, standard_args):
5521 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5522 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5523 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5524 * lisp.h (fatal_error_signal_hook): Remove decl.
5525 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5527 * editfns.c: Move a (normally-unused) function to its only use.
5528 * editfns.c, lisp.h (get_operating_system_release): Remove.
5529 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5530 worth the hassle of breaking this out.
5532 * xterm.c: Make symbols static if they're not exported.
5533 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5534 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5535 (x_destroy_window, x_delete_display):
5537 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5538 (x_mouse_leave): Remove; unused.
5539 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5540 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5541 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5543 (x_mouse_leave): Declare only if WINDOWSNT.
5544 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5545 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5548 * ftxfont.c: Make symbols static if they're not exported.
5549 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5551 * font.h (ftxfont_driver): Likewise.
5553 * xfns.c: Make symbols static if they're not exported.
5554 (x_last_font_name, x_display_info_for_name):
5555 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5556 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5557 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5558 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5559 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5560 (last_show_tip_args): Now static.
5561 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5562 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5563 (x_screen_planes): Remove; unused.
5564 * dispextern.h (x_screen_planes): Remove decl.
5566 * dispnew.c: Make symbols static if they're not exported.
5567 * dispextern.h (redraw_garbaged_frames, scrolling):
5568 (increment_row_positions): Remove.
5569 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5570 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5572 (redraw_garbaged_frames): Remove; unused.
5574 * xfaces.c: Make symbols static if they're not exported.
5575 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5577 * xterm.h (defined_color): Remove decls.
5578 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5579 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5580 (menu_face_changed_default, defined_color, free_realized_face):
5581 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5582 (ascii_face_of_lisp_face): Remove; unused.
5584 * xdisp.c: Make symbols static if they're not exported.
5585 * dispextern.h (scratch_glyph_row, window_box_edges):
5586 (glyph_to_pixel_coords, set_cursor_from_row):
5587 (get_next_display_element, set_iterator_to_next):
5588 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5589 (show_mouse_face): Remove decls
5590 * frame.h (message_buf_print): Likewise.
5591 * lisp.h (pop_message, set_message, check_point_in_composition):
5593 * xterm.h (set_vertical_scroll_bar): Likewise.
5594 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5595 (message_buf_print, scratch_glyph_row, displayed_buffer):
5596 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5597 (get_next_display_element, show_mouse_face, window_box_edges):
5598 (frame_to_window_pixel_xy, check_point_in_composition):
5599 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5600 (glyph_to_pixel_coords): Remove; unused.
5602 * dired.c (file_name_completion): Now static.
5604 * dbusbind.c (xd_in_read_queued_messages): Now static.
5606 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5607 * data.c (circular_list_error): Remove.
5609 * commands.h (last_point_position, last_point_position_buffer):
5610 (last_point_position_window): Remove decls.
5611 * keyboard.c: Make these variables static.
5613 * coding.h (coding, code_convert_region, encode_coding_gap):
5615 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5616 (iso_code_class, detect_coding, code_convert_region): Now static.
5617 (encode_coding_gap): Remove; unused.
5619 * chartab.c (chartab_chars, chartab_bits): Now static.
5621 * charset.h (charset_iso_8859_1): Remove decl.
5622 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5625 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5626 * ccl.c (Vccl_program_table): Now static.
5627 (check_ccl_update): Remove; unused.
5629 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5630 * category.h: ... from here.
5631 * category.c (check_category_table, set_category_set): Now static.
5633 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5634 * lisp.h: Remove these decls.
5636 * buffer.c (buffer_count): Remove unused var.
5638 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5639 so that it's not optimized away.
5640 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5641 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5642 exported only to the debugger.
5644 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5645 * atimer.h (run_all_atimers): Remove; not exported.
5647 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5648 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5649 was inaccessible from Lisp.
5650 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5651 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5653 alloc.c: Import and export fewer symbols, and remove unused items.
5654 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5656 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5657 it's not optimized away by whole-program optimization.
5658 (message_enable_multibyte, free_misc): Remove.
5659 (catchlist, handlerlist, mark_backtrace):
5660 Declare only if BYTE_MARK_STACK.
5661 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5662 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5663 (message_enable_multibyte): Remove decl.
5664 (free_misc, interval_free_list, float_block, float_block_index):
5665 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5666 (cons_free_list, last_marked_index):
5668 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5669 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5670 (mark_backtrace): Define only if BYTE_MARK_STACK.
5671 * xdisp.c (message_enable_multibyte): Now static.
5673 Declare Lisp_Object Q* variables to be 'static' if not exported.
5674 This makes it easier for human readers (and static analyzers)
5675 to see whether these variables are used from other modules.
5676 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5677 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5678 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5679 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5680 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5681 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5682 * xmenu.c, xselect.c:
5683 Declare Q* vars static if they are not used in other modules.
5684 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5685 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5686 Remove decls of unexported vars.
5687 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5689 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5691 Make Emacs functions such as Fatom 'static' by default.
5692 This makes it easier for human readers (and static analyzers)
5693 to see whether these functions can be called from other modules.
5694 DEFUN now defines a static function. To make the function external
5695 so that it can be used in other C modules, use the new macro DEFUE.
5696 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5697 (Finit_image_library):
5698 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5699 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5700 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5701 Remove decls, since these functions are now static.
5702 (Funintern, Fget_internal_run_time): New decls, since these functions
5703 were already external.
5705 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5706 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5707 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5708 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5709 * keyboard.c, keymap.c, lread.c:
5710 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5711 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5712 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5713 Mark functions with DEFUE instead of DEFUN,
5714 if they are used in other modules.
5715 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5716 decls for now-static functions.
5717 * buffer.h (Fdelete_overlay): Remove decl.
5718 * callproc.c (Fgetenv_internal): Mark as internal.
5719 * composite.c (Fremove_list_of_text_properties): Remove decl.
5720 (Fcomposition_get_gstring): New forward static decl.
5721 * composite.h (Fcomposite_get_gstring): Remove decl.
5722 * dired.c (Ffile_attributes): New forward static decl.
5723 * doc.c (Fdocumntation_property): New forward static decl.
5724 * eval.c (Ffetch_bytecode): New forward static decl.
5725 (Funintern): Remove extern decl; now in .h file where it belongs.
5726 * fileio.c (Fmake_symbolic_link): New forward static decl.
5727 * image.c (Finit_image_library): New forward static decl.
5728 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5729 * intervals.h (Fprevious_property_change):
5730 (Fremove_list_of_text_properties): Remove decls.
5731 * keyboard.c (Fthis_command_keys): Remove decl.
5732 (Fcommand_execute): New forward static decl.
5733 * keymap.c (Flookup_key): New forward static decl.
5734 (Fcopy_keymap): Now static.
5735 * keymap.h (Flookup_key): Remove decl.
5736 * process.c (Fget_process): New forward static decl.
5737 (Fprocess_datagram_address): Mark as internal.
5738 * syntax.c (Fsyntax_table_p): New forward static decl.
5739 (skip_chars): Remove duplicate decl.
5740 * textprop.c (Fprevious_property_change): New forward static decl.
5741 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5743 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5744 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5746 * editfns.c (Fformat): Remove unreachable code.
5748 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5750 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5753 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5755 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5756 when at ZV. (Bug#8487)
5758 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5760 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5762 * keyboard.c (parse_tool_bar_item): Likewise.
5763 * sound.c (sound_cleanup, alsa_close): Likewise.
5764 * termcap.c (tgetent): Likewise.
5765 * xfns.c (x_default_font_parameter): Likewise.
5766 * xsettings.c (read_and_apply_settings): Likewise.
5768 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5769 (overrun_check_free): Protoize.
5771 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5773 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5774 since callers should never pass a negative size.
5775 Change the signature to match that of plain 'read' and 'write'; see
5776 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5777 * lisp.h: Update prototypes of emacs_write and emacs_read.
5779 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5781 * xdisp.c (redisplay_window): Don't try to determine the character
5782 position of the scroll margin if the window start point w->startp
5783 is outside the buffer's accessible region. (Bug#8468)
5785 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5787 Fix write-region and its subroutines for buffers > 2GB.
5788 * fileio.c (a_write, e_write): Modify declaration of arguments and
5789 local variables to support buffers larger than 2GB.
5790 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5792 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5793 argument, local variables, and return value.
5795 * lisp.h: Update prototypes of emacs_write and emacs_read.
5797 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5799 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5801 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5803 Fix more problems found by GCC 4.6.0's static checks.
5805 * xdisp.c (vmessage): Use a better test for character truncation.
5807 * charset.c (load_charset_map): <, not <=, for optimization,
5808 and to avoid potential problems with integer overflow.
5809 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5810 * casetab.c (set_identity, shuffle): Likewise.
5811 * editfns.c (Fformat): Likewise.
5812 * syntax.c (skip_chars): Likewise.
5814 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5815 This also lets GCC 4.6.0 generate slightly better loop code.
5817 * callint.c (Fcall_interactively): <, not <=, for optimization.
5818 (Fcall_interactively): Count the number of arguments produced,
5819 not the number of arguments given. This is simpler and lets GCC
5820 4.6.0 generate slightly better code.
5822 * ftfont.c: Distingish more carefully between FcChar8 and char.
5823 The previous code passed unsigned char * to a functions like
5824 strlen and xstrcasecmp that expect char *, which does not
5825 conform to the C standard.
5826 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5827 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5828 char * when the C standard requires it.
5830 * keyboard.c (read_char): Remove unused var.
5832 * eval.c: Port to Windows vsnprintf (Bug#8435).
5834 (SIZE_MAX): Define if the headers do not.
5835 (verror): Do not give up if vsnprintf returns a negative count.
5836 Instead, grow the buffer. This ports to Windows vsnprintf, which
5837 does not conform to C99. Problem reported by Eli Zaretskii.
5838 Also, simplify the allocation scheme, by avoiding the need for
5839 calling realloc, and removing the ALLOCATED variable.
5841 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5843 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5844 But keep the doprint source code for now, as we might revamp it
5845 and use it again (Bug#8435).
5846 * lisp.h (doprnt): Remove.
5847 * Makefile.in (base_obj): Remove doprnt.o.
5848 * deps.mk (doprnt.o): Remove.
5850 error: Print 32- and 64-bit integers portably (Bug#8435).
5851 Without this change, on typical 64-bit hosts error ("...%d...", N)
5852 was used to print both 32- and 64-bit integers N, which relied on
5854 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5856 * lisp.h (error, verror): Mark as printf-like functions.
5857 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5858 Report overflow in size calculations when allocating printf buffer.
5859 Do not truncate output string at its first null byte.
5860 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5861 Truncate the output at a character boundary, since vsnprintf does not
5863 * charset.c (check_iso_charset_parameter): Convert internal
5864 character to string before calling 'error', since %c now has the
5866 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5867 overflow when computing char to be passed to 'error'. Do not
5868 pass Lisp_Object to 'error'; pass the integer instead.
5869 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5870 formatted with plain %d.
5872 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5874 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5876 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5878 * xterm.c (x_catch_errors): Remove duplicate declaration.
5880 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5882 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5884 2011-04-10 Jim Meyering <meyering@redhat.com>
5886 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5887 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5888 return ssize_t not "int", and use size_t as the buffer length.
5889 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5890 * gnutls.h: Update declarations.
5891 * process.c (read_process_output): Use ssize_t, to match.
5892 (send_process): Likewise.
5894 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5896 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5898 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5900 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5901 Use unsigned char, to match FcChar8 type definition.
5903 * xterm.c (handle_one_xevent):
5904 * xmenu.c (create_and_show_popup_menu):
5905 * xselect.c (x_decline_selection_request)
5906 (x_reply_selection_request): Avoid type-punned deref of X events.
5908 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5910 Fix some uses of `int' instead of EMACS_INT.
5911 * search.c (string_match_1, fast_string_match)
5912 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5913 (scan_buffer, find_next_newline_no_quit)
5914 (find_before_next_newline, search_command, Freplace_match)
5915 (Fmatch_data): Make some `int' variables be EMACS_INT.
5917 * xdisp.c (display_count_lines): 3rd argument and return value now
5918 EMACS_INT. All callers changed.
5919 (pint2hrstr): Last argument is now EMACS_INT.
5921 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5922 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5923 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5924 (decode_coding_utf_16, decode_coding_emacs_mule)
5925 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5926 (decode_coding_ccl, decode_coding_charset)
5927 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5928 (decode_coding_iso_2022, decode_coding_emacs_mule)
5929 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5930 <char_offset, last_offset>: Declare EMACS_INT.
5931 (encode_coding_utf_8, encode_coding_utf_16)
5932 (encode_coding_emacs_mule, encode_invocation_designation)
5933 (encode_designation_at_bol, encode_coding_iso_2022)
5934 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5935 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5937 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5938 (encode_invocation_designation): Last argument P_NCHARS is now
5940 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5941 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5943 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5946 * ccl.c (Fccl_execute_on_string): Declare some variables
5949 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5951 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5953 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5955 * process.c (Fformat_network_address): Doc fix.
5957 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5959 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5961 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5963 * keyboard.c (read_char): Call Lisp function help-form-show,
5964 instead of using internal_with_output_to_temp_buffer.
5965 (Qhelp_form_show): New var.
5966 (syms_of_keyboard): Use DEFSYM macro.
5968 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5970 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5972 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5974 * process.c (Flist_processes): Remove to Lisp.
5975 (list_processes_1): Delete.
5977 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5979 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5981 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5983 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5985 Fix more problems found by GCC 4.6.0's static checks.
5987 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5989 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5991 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5993 * xdisp.c (vmessage): Mark as a printf-like function.
5995 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5997 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5999 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6000 printf-like functions.
6001 (tiff_load): Add casts to remove these marks before passing them
6002 to system-supplied API.
6004 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6006 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6007 This avoids several warnings with gcc -Wstrict-overflow.
6008 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6009 directly, rather than having caller test rule sign. This avoids
6010 some unnecessary tests.
6011 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6012 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6013 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6015 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6016 (xfont_open): Avoid unnecessary tests.
6018 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6020 * composite.h, composite.c (composition_gstring_put_cache):
6021 Use EMACS_INT, not int, for length.
6023 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6024 breaking out part of COMPOSITION_DECODE_RULE.
6025 (COMPOSITION_DECODE_RULE): Use it.
6026 * composite.c (get_composition_id): Remove unused local vars,
6027 by using the new macro.
6029 * textprop.c (set_text_properties_1): Change while to do-while,
6030 since the condition is always true at first.
6032 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6033 (interval_deletion_adjustment): Return unsigned value.
6036 * process.c (list_processes_1, create_pty, read_process_output):
6037 (exec_sentinel): Remove vars that were set but not used.
6038 (create_pty): Remove unnecessary "volatile"s.
6039 (Fnetwork_interface_info): Avoid possibility of int overflow.
6040 (read_process_output): Do adaptive read buffering even if carryover.
6041 (read_process_output): Simplify nbytes computation if buffered.
6043 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6045 * syntax.c (scan_words): Remove var that was set but not used.
6046 (update_syntax_table): Use unsigned instead of int.
6048 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6049 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6050 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6052 * print.c (print_error_message): Avoid int overflow.
6054 * font.c (font_list_entities): Redo for clarity,
6055 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6057 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6058 (font_score): Avoid potential overflow in diff calculation.
6060 * fns.c (substring_both): Remove var that is set but not used.
6061 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6063 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6065 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6066 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6067 can always succeed if overflow has undefined behavior.
6069 * search.c (boyer_moore, wordify): Remove vars set but not used.
6070 (wordify): Omit three unnecessary tests.
6072 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6073 All callers changed. This avoids the need for an unused var.
6075 * casefiddle.c (casify_region): Remove var that is set but not used.
6077 * dired.c (file_name_completion): Remove var that is set but not used.
6079 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6081 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6082 (Finsert_file_contents): Remove unnecessary code checking fd.
6084 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6085 Check for integer overflow on size calculations.
6087 * buffer.c (Fprevious_overlay_change): Remove var that is set
6090 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6091 Remove vars that are set but not used.
6092 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6093 (timer_check_2): Mark vars as initialized.
6095 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6097 * image.c (lookup_image): Remove var that is set but not used.
6098 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6100 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6101 that are set but not used.
6103 * xfns.c (make_invisible_cursor): Don't return garbage
6104 if XCreateBitmapFromData fails (Bug#8410).
6106 * xselect.c (x_get_local_selection, x_handle_property_notify):
6107 Remove vars that are set but not used.
6109 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6110 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6112 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6113 Remove var that is set but not used.
6114 (scroll_bar_windows_size): Now size_t, not int.
6115 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6118 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6119 (map_tty_color) [!defined MSDOS]: Likewise.
6121 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6123 * coding.c: Remove vars that are set but not used.
6124 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6125 All callers changed.
6126 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6127 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6128 (decode_coding_charset): Remove vars that are set but not used.
6130 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6131 that is set but not used.
6133 * print.c (print_object): Remove var that is set but not used.
6135 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6136 The gnulib version avoids calling malloc in the usual case,
6137 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6138 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6139 * filelock.c (current_lock_owner): Likewise.
6140 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6141 * sysdep.c: Include allocator.h, careadlinkat.h.
6142 (emacs_no_realloc_allocator): New static constant.
6143 (emacs_readlink): New function.
6144 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6145 ../lib/careadlinkat.h.
6147 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6149 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6150 first non-nil return value).
6152 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6154 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6155 if not defined (Bug#8403).
6157 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6159 * xdisp.c (display_count_lines): Remove parameter `start',
6160 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6161 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6162 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6163 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6164 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6165 and thereabouts. All callers changed.
6166 (get_per_char_metric): Remove parameter `f', unused since
6167 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6169 2011-04-02 Jim Meyering <meyering@redhat.com>
6171 do not dereference NULL upon failed strdup
6172 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6173 (ns_get_family): Likewise.
6175 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6177 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6179 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6181 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6184 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6186 Add lexical binding.
6188 * window.c (Ftemp_output_buffer_show): New fun.
6189 (Fsave_window_excursion):
6190 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6192 * lread.c (lisp_file_lexically_bound_p): New function.
6193 (Fload): Bind Qlexical_binding.
6194 (readevalloop): Remove `evalfun' arg.
6195 Bind Qinternal_interpreter_environment.
6196 (Feval_buffer): Bind Qlexical_binding.
6197 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6199 (syms_of_lread): Declare `lexical-binding'.
6201 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6203 * keyboard.c (eval_dyn): New fun.
6204 (menu_item_eval_property): Use it.
6206 * image.c (parse_image_spec): Use Ffunctionp.
6208 * fns.c (concat, mapcar1): Accept byte-code-functions.
6210 * eval.c (Fsetq): Handle lexical vars.
6211 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6212 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6213 (FletX, Flet): Obey lexical binding.
6214 (Fcommandp): Handle closures.
6215 (Feval): New `lexical' arg.
6216 (eval_sub): New function extracted from Feval. Use it almost
6217 everywhere where Feval was used. Look up vars in lexical env.
6219 (Ffunctionp): Move from subr.el.
6220 (Ffuncall): Handle closures.
6221 (apply_lambda): Remove `eval_flags'.
6222 (funcall_lambda): Handle closures and new byte-code-functions.
6223 (Fspecial_variable_p): New function.
6224 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6225 but without exporting it to Lisp.
6227 * doc.c (Fdocumentation, store_function_docstring):
6228 * data.c (Finteractive_form): Handle closures.
6230 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6233 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6235 (exec_byte_code): New function extracted from Fbyte_code to handle new
6236 calling convention for byte-code-functions. Add new byte-codes.
6238 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6240 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6242 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6244 * xdisp.c (redisplay_internal): Fix prototype.
6246 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6248 * xdisp.c (SCROLL_LIMIT): New macro.
6249 (try_scrolling): Use it when setting scroll_limit.
6250 Limit scrolling to 100 screen lines.
6251 (redisplay_window): Even when falling back on "recentering",
6252 position point in the window according to scroll-conservatively,
6253 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6255 (try_scrolling): When point is above the window, allow searching
6256 as far as scroll_max, or one screenful, to compute vertical
6257 distance from PT to the scroll margin position. This prevents
6258 try_scrolling from unnecessarily failing when
6259 scroll-conservatively is set to a value slightly larger than the
6260 window height. Clean up the case of PT below the margin at bottom
6261 of window: scroll_max can no longer be INT_MAX. When aggressive
6262 scrolling is in use, don't let point enter the opposite scroll
6263 margin as result of the scroll.
6264 (syms_of_xdisp) <scroll-conservatively>: Document the
6265 threshold of 100 lines for never-recentering scrolling.
6267 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6269 * dispextern.h (move_it_by_lines):
6270 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6271 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6272 (message_log_check_duplicate): Remove parameters `prev_bol' and
6273 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6274 (redisplay_internal): Remove parameter `preserve_echo_area',
6275 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6277 * indent.c (Fvertical_motion):
6278 * window.c (window_scroll_pixel_based, Frecenter):
6279 Don't pass `need_y_p' to `move_it_by_lines'.
6281 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6283 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6284 steal a few bits to be more compact.
6285 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6286 Remove unneeded casts.
6288 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6290 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6292 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6293 binding" message (bug#7967).
6295 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6297 Fix more problems found by GCC 4.6.0's static checks.
6299 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6300 Remove unused local var.
6302 * editfns.c (Fmessage_box): Remove unused local var.
6304 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6305 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6306 Omit unused local vars.
6307 * window.c (shrink_windows): Omit unused local var.
6308 * menu.c (digest_single_submenu): Omit unused local var.
6309 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6310 Omit unused local var.
6312 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6313 Don't assume string length fits in int.
6314 (keyremap_step, read_key_sequence): Use size_t for sizes.
6315 (read_key_sequence): Don't check last_real_key_start redundantly.
6317 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6318 instead of alloca (Bug#8344).
6320 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6321 (Fbacktrace_frame): Don't assume nframes fits in int.
6323 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6325 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6328 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6330 * cm.c (calccost): Turn while-do into do-while, for clarity.
6332 * keyboard.c (syms_of_keyboard): Use the same style as later
6333 in this function when indexing through an array. This also
6334 works around GCC bug 48267.
6336 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6338 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6340 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6341 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6343 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6344 This avoids undefined behavior on integer overflow, and is a bit
6345 more convenient anyway since it is compared to a size_t variable.
6347 Variadic C functions now count arguments with size_t, not int.
6348 This avoids an unnecessary limitation on 64-bit machines, which
6349 caused (substring ...) to crash on large vectors (Bug#8344).
6350 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6351 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6352 All variadic functions and their callers changed accordingly.
6353 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6354 * data.c (arith_driver, float_arith_driver): Likewise.
6355 * editfns.c (general_insert_function): Likewise.
6356 * eval.c (struct backtrace.nargs, interactive_p)
6357 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6358 (funcall_lambda, mark_backtrace): Likewise.
6359 * fns.c (concat): Likewise.
6360 * frame.c (x_set_frame_parameters): Likewise.
6361 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6362 0 if not found, not -1. All callers changed.
6364 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6365 (stack_copy_size): Now size_t, not int.
6366 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6368 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6370 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6371 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6372 All callers changed.
6374 * lisp.h (multibyte_char_to_unibyte):
6375 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6376 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6377 * character.h (CHAR_TO_BYTE8):
6378 * cmds.c (internal_self_insert):
6379 * editfns.c (general_insert_function):
6380 * keymap.c (push_key_description):
6381 * search.c (Freplace_match):
6382 * xdisp.c (message_dolog, set_message_1): All callers changed.
6384 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6386 * keyboard.c (safe_run_hook_funcall): New function.
6387 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6388 don't set the hook to nil, but remove the offending function instead.
6389 (Qcommand_hook_internal): Remove, unused.
6390 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6391 Vcommand_hook_internal.
6393 * eval.c (enum run_hooks_condition): Remove.
6394 (funcall_nil, funcall_not): New functions.
6395 (run_hook_with_args): Call each function through a `funcall' argument.
6396 Remove `cond' argument, now redundant.
6397 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6398 (Frun_hook_with_args_until_failure): Adjust accordingly.
6399 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6401 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6403 * dispextern.h (string_buffer_position): Remove declaration.
6405 * print.c (strout): Remove parameter `multibyte', unused since
6406 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6408 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6409 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6410 All callers changed.
6412 * w32.c (_wsa_errlist): Use braces for struct initializers.
6414 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6415 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6416 All callers changed.
6417 (string_buffer_position): Likewise. Also, make static (it's never
6418 used outside xdisp.c).
6419 (cursor_row_p): Remove parameter `w', unused since
6420 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6421 (decode_mode_spec): Remove parameter `precision', introduced during
6422 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6423 All callers changed.
6425 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6427 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6429 2011-03-27 Anders Lindgren <andlind@gmail.com>
6431 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6432 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6433 (ns_update_auto_hide_menu_bar): New functions.
6434 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6435 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6436 ns_constrain_all_frames.
6437 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6438 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6440 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6442 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6444 2011-03-27 Glenn Morris <rgm@gnu.org>
6446 * syssignal.h: Replace RETSIGTYPE with void.
6447 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6448 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6449 Replace SIGTYPE with void everywhere.
6450 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6451 * s/template.h (SIGTYPE): Remove commented out definition.
6453 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6455 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6456 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6458 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6460 * w32.c (read_unc_volume): Use parameter `henum', instead of
6461 global variable `wget_enum_handle'.
6463 * keymap.c (describe_vector): Remove parameters `indices' and
6464 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6465 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6467 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6469 * keyboard.c (timer_check): Remove parameter `do_it_now',
6470 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6471 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6472 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6474 * keyboard.c (read_char):
6475 * w32menu.c (w32_menu_display_help):
6476 * xmenu.c (show_help_event, menu_help_callback):
6477 Adjust calls to `show_help_echo'.
6479 * gtkutil.c (xg_maybe_add_timer):
6480 * keyboard.c (readable_events):
6481 * process.c (wait_reading_process_output):
6482 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6484 * insdel.c (adjust_markers_gap_motion):
6485 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6486 (gap_left, gap_right): Don't call it.
6488 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6490 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6491 incurred during fontification.
6493 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6495 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6496 (DEFVAR_PER_BUFFER): Don't pass it.
6498 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6499 (scrolling_window): Don't pass it.
6501 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6503 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6505 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6507 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6508 of variables specific to SELinux and computation of `encoded_absname'.
6510 * image.c (XPutPixel): Remove unused variable `height'.
6512 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6514 * unexw32.c (get_section_info): Remove unused variable `section'.
6516 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6517 (system_process_attributes): Remove unused variable `sess'.
6518 (sys_read): Remove unused variable `err'.
6520 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6521 (w32_wnd_proc): Remove unused variable `isdead'.
6522 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6523 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6524 (x_create_tip_frame): Remove unused variable `tem'.
6526 * w32inevt.c (w32_console_read_socket):
6527 Remove unused variable `no_events'.
6529 * w32term.c (x_draw_composite_glyph_string_foreground):
6530 Remove unused variable `width'.
6532 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6534 * w32term.c (x_set_glyph_string_clipping):
6535 Don't pass uninitialized region to CombineRgn.
6537 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6539 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6540 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6541 (Fx_close_connection): Remove unused variable `i'.
6543 * w32font.c (w32font_draw): Return number of glyphs.
6544 (w32font_open_internal): Remove unused variable `i'.
6545 (w32font_driver): Add missing initializer.
6547 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6548 (fill_in_menu): Remove unused variable `items_added'.
6550 * w32term.c (last_mouse_press_frame): Remove static global variable.
6551 (w32_clip_to_row): Remove unused variable `f'.
6552 (x_delete_terminal): Remove unused variable `i'.
6554 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6555 (NOTHING): Remove unused static global variable.
6556 (uniscribe_check_otf): Remove unused variable `table'.
6557 (uniscribe_font_driver): Add missing initializers.
6559 2011-03-23 Julien Danjou <julien@danjou.info>
6561 * term.c (Fsuspend_tty, Fresume_tty):
6562 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6563 * window.c (temp_output_buffer_show):
6564 * insdel.c (signal_before_change):
6565 * frame.c (Fhandle_switch_frame):
6566 * fileio.c (Fdo_auto_save):
6567 * emacs.c (Fkill_emacs):
6568 * editfns.c (save_excursion_restore):
6569 * cmds.c (internal_self_insert):
6570 * callint.c (Fcall_interactively):
6571 * buffer.c (Fkill_all_local_variables):
6572 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6574 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6575 unconditionnaly since it does the check itself.
6577 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6579 Fix more problems found by GCC 4.5.2's static checks.
6581 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6582 the first time through the loop, since we know p0 < p1 then.
6583 This also avoids a gcc -Wstrict-overflow warning.
6585 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6586 leading to a memory leak, possible in functions like
6587 load_charset_map_from_file that can allocate an unbounded number
6588 of objects (Bug#8318).
6590 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6591 that could (at least in theory) be that large.
6593 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6594 This is less likely to overflow, and avoids undefined behavior if
6595 overflow does occur. All callers changed. Use strtoul to scan
6596 for the unsigned long integer.
6597 (pint2hrstr): Simplify and tune code slightly.
6598 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6600 * scroll.c (do_scrolling): Work around GCC bug 48228.
6601 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6603 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6604 This also avoids a warning with gcc -Wstrict-overflow.
6605 (validate_x_resource_name): Simplify count usage.
6606 This also avoids a warning with gcc -Wstrict-overflow.
6608 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6611 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6613 * process.c (Fmake_network_process): Use socklen_t, not int,
6614 where POSIX says socklen_t is required in portable programs.
6615 This fixes a porting bug on hosts like 64-bit HP-UX, where
6616 socklen_t is wider than int (Bug#8277).
6617 (Fmake_network_process, server_accept_connection):
6618 (wait_reading_process_output, read_process_output):
6621 * process.c: Rename or move locals to avoid shadowing.
6622 (list_processes_1, Fmake_network_process):
6623 (read_process_output_error_handler, exec_sentinel_error_handler):
6624 Rename or move locals.
6625 (Fmake_network_process): Define label "retry_connect" only if needed.
6626 (Fnetwork_interface_info): Fix pointer signedness.
6627 (process_send_signal): Add cast to avoid pointer signedness problem.
6628 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6629 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6631 Make tparam.h and terminfo.c consistent.
6632 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6633 Include tparam.h instead, since it declares them.
6634 * cm.h (PC): Remove extern decl; tparam.h now does this.
6635 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6636 * terminfo.c: Include tparam.h, to check interfaces.
6637 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6638 (tparam): Adjust signature to match interface in tparam.h;
6639 this removes some undefined behavior. Check that outstring and len
6640 are zero, which they always are with Emacs.
6641 * tparam.h (PC, BC, UP): New extern decls.
6643 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6644 (xftfont_open): Rename locals to avoid shadowing.
6646 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6647 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6648 (OTF_TAG_SYM): Omit macro if not needed.
6649 (ftfont_list): Remove unused local.
6650 (get_adstyle_property, ftfont_pattern_entity):
6651 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6652 Rename locals to avoid shadowing.
6654 * xfont.c (xfont_list_family): Mark var as initialized.
6656 * xml.c (make_dom): Now static.
6658 * composite.c (composition_compute_stop_pos): Rename local to
6660 (composition_reseat_it): Remove unused locals.
6661 (find_automatic_composition, composition_adjust_point): Likewise.
6662 (composition_update_it): Mark var as initialized.
6663 (find_automatic_composition): Mark vars as initialized,
6664 with a FIXME (Bug#8290).
6666 character.h: Rename locals to avoid shadowing.
6667 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6668 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6669 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6670 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6673 * textprop.c (property_change_between_p): Remove; unused.
6675 * intervals.c (interval_start_pos): Now static.
6677 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6679 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6680 Rename locals to avoid shadowing.
6682 * sound.c (wav_play, au_play, Fplay_sound_internal):
6683 Fix pointer signedness.
6684 (alsa_choose_format): Remove unused local var.
6685 (wav_play): Initialize a variable to 0, to prevent undefined
6686 behavior (Bug#8278).
6688 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6690 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6692 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6693 clobbering (Bug#8298).
6694 * sysdep.c (sys_subshell): Likewise.
6695 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6697 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6698 This should get cleaned up, so that child_setup has the
6699 same signature on all platforms.
6701 * callproc.c (call_process_cleanup): Now static.
6702 (relocate_fd): Rename locals to avoid shadowing.
6704 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6706 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6707 not to be necessary, and produces flickering.
6709 2011-03-20 Glenn Morris <rgm@gnu.org>
6711 * config.in: Remove file.
6713 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6715 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6716 are now in src/globals.h.
6717 (syms_of_minibuf): Remove spurious & from previous change.
6719 2011-03-20 Leo <sdl.web@gmail.com>
6721 * minibuf.c (completing-read-function): New variable.
6722 (completing-read-default): Rename from completing-read.
6723 (completing-read): Call completing-read-function.
6725 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6727 * xfaces.c (Fx_load_color_file):
6728 Read color file from absolute filename (bug#8250).
6730 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6732 * makefile.w32-in: Update dependencies.
6734 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6736 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6738 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6740 Fix more problems found by GCC 4.5.2's static checks.
6742 * process.c (make_serial_process_unwind, send_process_trap):
6743 (sigchld_handler): Now static.
6745 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6746 That way, the code declares only the vars that it needs.
6747 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6748 * s/cygwin.h (PTY_ITERATION): Likewise.
6749 * s/darwin.h (PTY_ITERATION): Likewise.
6750 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6752 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6753 * process.c (allocate_pty): Don't declare stb unless it's needed.
6755 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6756 (CONSTANTLIM): Remove; unused.
6757 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6758 Define only if needed.
6760 * unexelf.c (unexec): Name an expression,
6761 to avoid gcc -Wbad-function-cast warning.
6762 Use a different way to cause a compilation error if anyone uses
6763 n rather than nn, a way that does not involve shadowing.
6764 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6766 * deps.mk (unexalpha.o): Remove; unused.
6768 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6769 * unexec.h: New file.
6770 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6771 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6773 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6774 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6775 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6776 Change as necessary to match prototype in unexec.h.
6778 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6780 (back_comment, skip_chars): Mark vars as initialized.
6782 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6783 Rename locals to avoid shadowing.
6785 * lread.c (read1): Rewrite so as not to use empty "else".
6786 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6788 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6790 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6791 warning when compiling print.c.
6793 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6794 instead of using an uninitialized var.
6795 (font_sort_entities): Mark var as initialized.
6797 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6799 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6800 pointers to constants.
6801 (font_parse_fcname): Remove unused vars.
6802 (font_delete_unmatched): Now static.
6803 (font_get_spec): Remove; unused.
6804 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6805 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6806 Rename or move locals to avoid shadowing.
6808 * fns.c (require_nesting_list, require_unwind): Now static.
6809 (Ffillarray): Rename locals to avoid shadowing.
6811 * floatfns.c (domain_error2): Define only if needed.
6812 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6814 * alloc.c (mark_backtrace): Move decl from here ...
6815 * lisp.h: ... to here, so that it can be checked.
6817 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6818 (Fdefvar): Rewrite so as not to use empty "else".
6819 (lisp_indirect_variable): Name an expression,
6820 to avoid gcc -Wbad-function-cast warning.
6821 (Fdefvar): Rename locals to avoid shadowing.
6823 * callint.c (quotify_arg, quotify_args): Now static.
6824 (Fcall_interactively): Rename locals to avoid shadowing.
6825 Use const pointer when appropriate.
6827 * lisp.h (get_system_name, get_operating_system_release):
6828 Move decls here, to check interfaces.
6829 * process.c (get_operating_system_release): Move decl to lisp.h.
6830 * xrdb.c (get_system_name): Likewise.
6831 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6832 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6833 some of which prompt warnings from gcc -Wbad-function-cast.
6834 (Fformat_time_string, Fencode_time, Finsert_char):
6835 (Ftranslate_region_internal, Fformat):
6836 Rename or remove local vars to avoid shadowing.
6837 (Ftranslate_region_internal): Mark var as initialized.
6839 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6842 * lisp.h (eassert): Check that the argument compiles, even if
6843 ENABLE_CHECKING is not defined.
6845 * data.c (Findirect_variable): Name an expression, to avoid
6846 gcc -Wbad-function-cast warning.
6847 (default_value, arithcompare, arith_driver, arith_error): Now static.
6848 (store_symval_forwarding): Rename local to avoid shadowing.
6849 (Fmake_variable_buffer_local, Fmake_local_variable):
6850 Mark variables as initialized.
6851 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6853 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6854 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6855 Rename locals to avoid shadowing.
6856 (mark_stack): Move local variables into the #ifdef region where
6858 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6859 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6861 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6862 (GC_STRING_CHARS): Remove; not used.
6863 (Fmemory_limit): Cast sbrk's returned value to char *.
6865 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6866 avoids undefined behavior in theory.
6868 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6870 Use functions, not macros, for up- and down-casing (Bug#8254).
6871 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6872 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6873 to use the following functions instead of these macros.
6874 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6875 EMACS_INT, since callers assume the returned value fits in int.
6876 (upcase1): Likewise, for UPCASE_TABLE.
6877 (uppercasep, lowercasep, upcase): New static inline functions.
6878 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6879 the race-condition problem in the old DOWNCASE.
6881 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6882 Rename locals to avoid shadowing.
6883 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6884 (regex_compile, re_search_2, re_match_2_internal):
6885 Remove unused local vars.
6886 (FREE_VAR): Rewrite so as not to use empty "else",
6887 which gcc can warn about.
6888 (regex_compile, re_match_2_internal): Mark locals as initialized.
6889 (RETALLOC_IF): Define only if needed.
6890 (WORDCHAR_P): Likewise. This one is never needed, but is used
6891 only in a comment talking about a compiler bug, so put inside
6892 the #if 0 of that comment.
6893 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6894 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6897 * search.c (boyer_moore): Rename locals to avoid shadowing.
6898 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6899 (PREV_CHAR_BOUNDARY): Likewise.
6901 * search.c (simple_search): Remove unused var.
6903 * dired.c (compile_pattern): Move decl from here ...
6904 * lisp.h: ... to here, so that it can be checked.
6905 (struct re_registers): New forward decl.
6907 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6909 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6911 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6912 Rename locals to avoid shadowing.
6913 (Fvertical_motion): Mark locals as initialized.
6915 * casefiddle.c (casify_object, casify_region): Now static.
6916 (casify_region): Mark local as initialized.
6918 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6920 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6921 New macros, so that the caller can use some names other than
6922 gcpro1, gcpro2, etc.
6923 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6925 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6926 argument, for consistency with GCPRO2_VAR, etc: it is now the
6927 prefix of the variable, not the variable itself. All uses
6929 * dired.c (directory_files_internal, file_name_completion):
6930 Rename locals to avoid shadowing.
6932 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6933 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6934 dired.c's scmp function, had undefined behavior.
6935 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6936 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6937 * buffer.h: ... to here, because these macros use current_buffer,
6938 and the new implementation with inline functions needs to have
6939 current_buffer in scope now, rather than later when the macros
6941 (downcase, upcase1): New static inline functions.
6942 (DOWNCASE, UPCASE1): Reimplement using these functions.
6943 This avoids undefined behavior in expressions like
6944 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6945 from race conditions in accessing the global variables
6946 case_temp1 and case_temp2.
6947 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6948 * lisp.h (case_temp1, case_temp2): Remove their decls.
6949 * character.h (ASCII_CHAR_P): Move from here ...
6950 * lisp.h: ... to here, so that the inline functions mentioned
6953 * dired.c (directory_files_internal_unwind): Now static.
6955 * fileio.c (file_name_as_directory, directory_file_name):
6956 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6958 (file_name_as_directory): Use const pointers when appropriate.
6959 (Fexpand_file_name): Likewise. In particular, newdir might
6960 point at constant storage, so make it a const pointer.
6961 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6962 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6964 (Fset_file_times, Finsert_file_contents, auto_save_error):
6965 Rename locals to avoid shadowing.
6967 * minibuf.c (choose_minibuf_frame_1): Now static.
6968 (Ftry_completion, Fall_completions): Rename or remove locals
6971 * marker.c (bytepos_to_charpos): Remove; unused.
6973 * lisp.h (verify_bytepos, count_markers): New decls,
6974 so that gcc does not warn that these functions aren't declared.
6976 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6977 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6978 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6979 (copy_text): Remove unused local var.
6981 * filelock.c (within_one_second): Now static.
6982 (lock_file_1): Rename local to avoid shadowing.
6984 * buffer.c (fix_overlays_before): Mark locals as initialized.
6985 (fix_start_end_in_overlays): Likewise. This function should be
6986 simplified by using pointers-to-pointers, but that's a different
6988 (switch_to_buffer_1): Now static.
6989 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6990 (report_overlay_modification): Rename locals to avoid shadowing.
6992 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6993 Fix pointer signedness issue.
6994 (sys_subshell): Mark local as volatile if checking for lint,
6995 to suppress a gcc -Wclobbered warning that does not seem to be right.
6996 (MAXPATHLEN): Define only if needed.
6998 * process.c (serial_open, serial_configure): Move decls from here ...
6999 * systty.h: ... to here, so that they can be checked.
7001 * fns.c (get_random, seed_random): Move extern decls from here ...
7002 * lisp.h: ... to here, so that they can be checked.
7004 * sysdep.c (reset_io): Now static.
7005 (wait_for_termination_signal): Remove; unused.
7007 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7008 (copy_keymap_item, append_key, push_text_char_description):
7010 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7011 (DENSE_TABLE_SIZE): Remove; unused.
7012 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7013 (describe_map_tree):
7014 Rename locals to avoid shadowing.
7016 * keyboard.c: Declare functions static if they are not used elsewhere.
7017 (echo_char, echo_dash, cmd_error, top_level_2):
7018 (poll_for_input, handle_async_input): Now static.
7019 (read_char, kbd_buffer_get_event, make_lispy_position):
7020 (make_lispy_event, make_lispy_movement, apply_modifiers):
7021 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7022 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7023 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7024 (read_key_sequence, read_char): Mark locals as initialized.
7025 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7027 * keyboard.h (make_ctrl_char): New decl.
7028 (mark_kboards): Move decl here ...
7029 * alloc.c (mark_kboards): ... from here.
7031 * lisp.h (force_auto_save_soon): New decl.
7033 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7034 (DEFINE_DUMMY_FUNCTION): New macro.
7035 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7037 (main): Add casts to avoid warnings
7038 if GCC considers string literals to be constants.
7040 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7042 * dbusbind.c: Pointer signedness fixes.
7043 (xd_signature, xd_append_arg, xd_initialize):
7044 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7045 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7046 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7047 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7049 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7050 if GCC considers string literals to be constants.
7051 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7053 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7055 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7056 (print_preprocess, print_object): New macro to fix last change.
7058 * print.c (print_preprocess): Don't forget font objects.
7060 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7062 * emacs.c (USAGE3): Doc fixes.
7064 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7066 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7069 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7071 * lisp.h (VWindow_system, Qfile_name_history):
7072 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7073 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7074 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7076 * w32select.c: Don't #include "keyboard.h".
7077 (run_protected): Add extern declaration for waiting_for_input.
7079 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7080 * w32console.c (detect_input_pending, read_input_pending)
7081 (encode_terminal_code):
7082 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7083 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7084 (w32_system_caret_y, Qfile_name_history):
7085 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7086 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7087 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7088 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7089 * w32proc.c (Qlocal, report_file_error):
7090 * w32term.c (Vwindow_system, updating_frame):
7091 * w32uniscribe.c (initialized, uniscribe_font_driver):
7092 Remove unneeded extern declarations.
7094 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7096 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7098 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7100 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7101 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7102 These macros can no longer be used for assignment.
7104 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7105 Assign struct members directly, instead of using BUF_BEGV etc.
7106 (record_buffer_markers, fetch_buffer_markers): New functions for
7107 recording and fetching special buffer markers.
7108 (set_buffer_internal_1, set_buffer_temp): Use them.
7110 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7112 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7114 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7115 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7117 * xdisp.c (hscroll_window_tree):
7118 (reconsider_clip_changes): Use PT instead of BUF_PT.
7120 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7122 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7123 $(EMACS_ROOT)/lib/intprops.h.
7125 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7127 Fix more problems found by GCC 4.5.2's static checks.
7129 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7130 to unsigned char * to avoid compiler diagnostic.
7131 (xg_free_frame_widgets): Make it clear that a local variable is
7132 needed only if USE_GTK_TOOLTIP.
7133 (gdk_window_get_screen): Make it clear that this macro is needed
7134 only if USE_GTK_TOOLTIP.
7135 (int_gtk_range_get_value): New function, which avoids a diagnostic
7136 from gcc -Wbad-function-cast.
7137 (xg_set_toolkit_scroll_bar_thumb): Use it.
7138 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7139 diagnostic from gcc -Wbad-function-cast.
7140 (get_utf8_string, xg_get_file_with_chooser):
7141 Rename locals to avoid shadowing.
7142 (create_dialog): Move locals to avoid shadowing.
7144 * xgselect.c (xg_select): Remove unused var.
7146 * image.c (four_corners_best): Mark locals as initialized.
7147 (gif_load): Initialize transparent_p to zero (Bug#8238).
7148 Mark another local as initialized.
7149 (my_png_error, my_error_exit): Mark with NO_RETURN.
7151 * image.c (clear_image_cache): Now static.
7152 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7153 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7154 (x_edge_detection): Remove unnecessary cast that
7155 gcc -Wbad-function-cast diagnoses.
7156 (gif_load): Fix pointer signedness.
7157 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7158 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7160 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7162 Improve quality of tests for time stamp overflow.
7163 For example, without this patch (encode-time 0 0 0 1 1
7164 1152921504606846976) returns the obviously-bogus value (-948597
7165 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7166 reports time overflow. See
7167 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7168 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7169 * editfns.c: Include limits.h and intprops.h.
7170 (TIME_T_MIN, TIME_T_MAX): New macros.
7171 (time_overflow): Move earlier, to before first use.
7172 (hi_time, lo_time): New functions, for an accurate test for
7174 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7175 (Fget_internal_run_time): Don't assume time_t fits in int.
7176 (make_time): Use list2 instead of Fcons twice.
7177 (Fdecode_time): More accurate test for out-of-range times.
7178 (check_tm_member): New function.
7179 (Fencode_time): Use it, to test for out-of-range times.
7180 (lisp_time_argument): Don't rely on undefined left-shift and
7181 right-shift behavior when checking for time stamp overflow.
7183 * editfns.c (time_overflow): New function, refactoring common code.
7184 (Fformat_time_string, Fdecode_time, Fencode_time):
7185 (Fcurrent_time_string): Use it.
7187 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7188 * dired.c (make_time): Move to ...
7189 * editfns.c (make_time): ... here.
7190 * systime.h: Note the move.
7192 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7194 * fringe.c (update_window_fringes): Remove unused variables.
7196 * unexmacosx.c (copy_data_segment): Also copy __got section.
7199 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7201 * termcap.c [MSDOS]: Include "msdos.h".
7202 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7203 Constify `char *' arguments and their references according to
7204 prototypes in tparam.h.
7206 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7208 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7209 Adapt all references accordingly.
7211 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7213 2011-03-11 Tom Tromey <tromey@redhat.com>
7215 * buffer.c (syms_of_buffer): Remove obsolete comment.
7217 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7219 * termhooks.h (encode_terminal_code): Declare prototype.
7221 * msdos.c (encode_terminal_code): Don't declare prototype.
7223 * term.c (encode_terminal_code): Now external again, used by
7224 w32console.c and msdos.c.
7226 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7227 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7229 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7231 Fix some minor problems found by GCC 4.5.2's static checks.
7233 * fringe.c (update_window_fringes): Mark locals as initialized
7235 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7237 * alloc.c (mark_fringe_data): Move decl from here ...
7238 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7239 to check its interface.
7240 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7242 * fontset.c (free_realized_fontset): Now static.
7243 (Fset_fontset_font): Rename local to avoid shadowing.
7244 (fontset_font): Mark local as initialized.
7245 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7247 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7249 * xselect.c (x_disown_buffer_selections): Remove; not used.
7250 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7251 (x_own_selection, Fx_disown_selection_internal): Rename locals
7253 (x_handle_dnd_message): Remove local to avoid shadowing.
7255 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7256 so that the caller can use some name other than gcpro1.
7257 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7258 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7259 (Fx_backspace_delete_keys_p):
7260 Use them to avoid shadowing, and rename vars to avoid shadowing.
7261 (x_decode_color, x_set_name, x_window): Now static.
7262 (Fx_create_frame): Add braces to silence GCC warning.
7263 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7264 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7265 Remove unused locals.
7266 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7267 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7268 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7271 * xterm.h (x_mouse_leave): New decl.
7273 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7274 Remove unused functions.
7275 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7276 (x_calc_absolute_position): Now static.
7277 (XTread_socket): Don't define label "out" unless it's used.
7278 Don't declare local "event" unless it's used.
7279 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7280 unless they are used.
7281 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7282 (x_fatal_error_signal): Remove; not used.
7283 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7284 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7285 (x_error_catcher, x_connection_closed, x_error_handler):
7286 (x_error_quitter, xembed_send_message, x_iconify_frame):
7287 (my_log_handler): Rename locals to avoid shadowing.
7288 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7289 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7291 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7292 Rename or move locals to avoid shadowing.
7293 (tty_defined_color, merge_face_heights): Now static.
7294 (free_realized_faces_for_fontset): Remove; not used.
7295 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7296 does not deduce is never used uninitialized.
7297 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7298 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7300 * terminal.c (store_terminal_param): Now static.
7302 * xmenu.c (menu_highlight_callback): Now static.
7303 (set_frame_menubar): Remove unused local.
7304 (xmenu_show): Rename parameter to avoid shadowing.
7305 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7306 since they might point to immutable storage.
7307 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7308 since it's unused otherwise.
7310 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7311 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7312 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7313 avoids a gcc -Wuninitialized diagnostic.
7314 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7315 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7316 does not deduce are never used uninitialized.
7318 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7320 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7321 * window.c (window_loop, size_window):
7322 (run_window_configuration_change_hook, enlarge_window): Likewise.
7324 * window.c (display_buffer): Now static.
7325 (size_window): Mark variables that gcc -Wuninitialized
7326 does not deduce are never used uninitialized.
7327 * window.h (check_all_windows): New decl, to forestall
7328 gcc -Wmissing-prototypes diagnostic.
7329 * dispextern.h (bidi_dump_cached_states): Likewise.
7331 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7333 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7335 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7336 and to avoid gcc -Wuninitialized warning.
7337 (load_charset_map): Mark variables that gcc -Wuninitialized
7338 does not deduce are never used uninitialized.
7339 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7341 * coding.c (coding_set_source, coding_set_destination):
7342 Use "else { /* comment */ }" rather than "else /* comment */;"
7343 for clarity, and to avoid gcc -Wempty-body warning.
7344 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7345 a block, when the outer 'i' will do.
7346 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7347 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7348 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7349 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7350 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7351 Rename locals to avoid shadowing.
7352 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7353 * coding.c (emacs_mule_char, encode_invocation_designation):
7354 Now static, since they're not used elsewhere.
7355 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7356 (decode_coding_object, encode_coding_object, detect_coding_system):
7357 (decode_coding_emacs_mule): Mark variables that gcc
7358 -Wuninitialized does not deduce are never used uninitialized.
7359 (detect_coding_iso_2022): Initialize a local variable that might
7360 be used uninitialized. Leave a FIXME because it's not clear that
7361 this initialization is needed. (Bug#8211)
7362 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7363 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7364 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7365 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7366 Remove unused macros.
7368 * category.c (hash_get_category_set): Remove unused local var.
7369 (copy_category_table): Now static, since it's not used elsewhere.
7370 * character.c (string_count_byte8): Likewise.
7372 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7373 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7375 * chartab.c (copy_sub_char_table): Now static, since it's not used
7377 (sub_char_table_ref_and_range, char_table_ref_and_range):
7378 Rename locals to avoid shadowing.
7379 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7381 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7382 (BIDI_BOB): Remove unused macro.
7384 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7385 deduce are never used uninitialized.
7386 * term.c (encode_terminal_code): Likewise.
7388 * term.c (encode_terminal_code): Now static. Remove unused local.
7390 * tparam.h: New file.
7391 * term.c, tparam.h: Include it.
7392 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7393 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7394 Move these decls to tparam.h, and make them agree with what
7395 is actually in tparam.c. The previous trick of using incompatible
7396 decls in different modules does not conform to the C standard.
7397 All callers of tparam changed to use tparam's actual API.
7398 * tparam.c (tparam1, tparam, tgoto):
7399 Use const pointers where appropriate.
7401 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7402 * cm.h (struct cm): Likewise.
7403 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7404 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7405 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7406 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7407 (turn_on_face, init_tty): Likewise.
7408 * termchar.h (struct tty_display_info): Likewise.
7410 * term.c (term_mouse_position): Rename local to avoid shadowing.
7412 * alloc.c (mark_ttys): Move decl from here ...
7413 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7415 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7417 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7419 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7421 * search.c (compile_pattern_1): Remove argument regp, unused since
7422 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7423 (compile_pattern): Don't pass it.
7425 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7427 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7428 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7430 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7432 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7434 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7435 gdk_window_get_screen, gdk_window_get_geometry,
7436 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7437 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7438 (xg_get_pixbuf_from_pixmap): New function.
7439 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7440 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7441 Call xg_get_pixbuf_from_pixmap instead of
7442 gdk_pixbuf_get_from_drawable.
7443 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7444 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7445 (xg_check_special_colors): Use GtkStyleContext and its functions
7447 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7448 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7449 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7450 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7451 Call gtk_widget_get_preferred_size.
7452 (xg_frame_resized): gdk_window_get_geometry only takes 5
7454 (xg_win_to_widget, xg_event_is_for_menubar):
7455 Call gdk_x11_window_lookup_for_display.
7456 (xg_set_widget_bg): New function.
7457 (delete_cb): New function.
7458 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7459 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7460 (xg_set_background_color): Call xg_set_widget_bg.
7461 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7462 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7463 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7464 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7466 (update_frame_tool_bar): Call gtk_widget_hide.
7467 (xg_initialize): Use GDK_KEY_g.
7469 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7471 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7473 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7474 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7475 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7477 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7479 * w32xfns.c (select_palette): Check success of RealizePalette against
7480 GDI_ERROR, not zero.
7482 See ChangeLog.11 for earlier changes.
7488 Copyright (C) 2011 Free Software Foundation, Inc.
7490 This file is part of GNU Emacs.
7492 GNU Emacs is free software: you can redistribute it and/or modify
7493 it under the terms of the GNU General Public License as published by
7494 the Free Software Foundation, either version 3 of the License, or
7495 (at your option) any later version.
7497 GNU Emacs is distributed in the hope that it will be useful,
7498 but WITHOUT ANY WARRANTY; without even the implied warranty of
7499 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7500 GNU General Public License for more details.
7502 You should have received a copy of the GNU General Public License
7503 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.