1 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8 Operate on live windows only.
10 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
12 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
14 2011-09-07 Eli Zaretskii <eliz@gnu.org>
16 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
17 only under bidi iteration.
19 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
21 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
23 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
25 isnan: Fix porting problem to Solaris 10 with bundled gcc.
26 Without this fix, the command to link temacs failed due to an
27 undefined symbol __builtin_isnan. This is because
28 /usr/include/iso/math_c99.h #defines isnan(x) to
29 __builtin_isnan(x), but the bundled gcc, which identifies itself
30 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
32 * floatfns.c (isnan): #undef, and then #define to a clone of
34 (Fisnan): Always define, since it's always available now.
35 (syms_of_floatfns): Always define isnan at the Lisp level.
37 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
39 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
41 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
43 * fileio.c: Fix bugs with large file offsets (Bug#9428).
44 The previous code assumed that file offsets (off_t values) fit in
45 EMACS_INT variables, which is not true on typical 32-bit hosts.
46 The code messed up by falsely reporting buffer overflow in cases
47 such as (insert-file-contents "big" nil 1 2) into an empty buffer
48 when "big" contains more than 2**29 bytes, even though this
49 inserts just one byte and does not overflow the buffer.
50 (Finsert_file_contents): Store file offsets as off_t
51 values, not as EMACS_INT values. Check for overflow when
52 converting between EMACS_INT and off_t. When checking for
53 buffer overflow or for overlap, take the offsets into account.
54 Don't use EMACS_INT for small values where int suffices.
55 When checking for overlap, fix a typo: ZV was used where
57 (Fwrite_region): Don't assume off_t fits into 'long'.
58 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
60 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
62 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
64 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
66 sprintf-related integer and memory overflow issues (Bug#9412).
68 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
69 (esprintf, exprintf, evxprintf): New functions.
70 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
71 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
72 (modify_event_symbol): Do not assume that the length of
73 name_alist_or_stem is safe to alloca and fits in int.
74 (Fexecute_extended_command): Likewise for function name and binding.
75 (Frecursion_depth): Wrap around reliably on integer overflow.
76 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
77 since some callers pass EMACS_INT values.
78 (Fsingle_key_description): Don't crash if symbol name contains more
79 than MAX_ALLOCA bytes.
80 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
81 (get_minibuffer): Arg is now EMACS_INT, not int.
82 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
83 (esprintf, exprintf, evxprintf): New decls.
84 * window.h (command_loop_level, minibuf_level): Reflect API changes.
86 * dbusbind.c (signature_cat): New function.
87 (xd_signature, Fdbus_register_signal):
88 Do not overrun buffer; instead, report string overflow.
90 * dispnew.c (add_window_display_history): Don't overrun buffer.
91 Truncate instead; this is OK since it's just a log.
93 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
94 even if the time zone offset is outlandishly large.
95 Don't mishandle offset == INT_MIN.
97 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
98 when creating daemon; the previous buffer-overflow check was incorrect.
100 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
101 which has the guts of the old verror function.
103 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
104 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
106 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
107 (font_unparse_xlfd): Don't blindly alloca long strings.
108 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
109 fits in int, when using sprintf. Use single snprintf to count
110 length of string rather than counting it via multiple sprintfs;
111 that's simpler and more reliable.
112 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
113 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
114 sprintf, in case result does not fit in int.
116 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
117 (fontset_from_font): Print it.
119 * frame.c (tty_frame_count): Now printmax_t, not int.
120 (make_terminal_frame, set_term_frame_name): Print it.
121 (x_report_frame_params): In X, window IDs are unsigned long,
122 not signed long, so print them as unsigned.
123 (validate_x_resource_name): Check for implausibly long names,
124 and don't assume name length fits in 'int'.
125 (x_get_resource_string): Don't blindly alloca invocation name;
126 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
129 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
130 (xg_check_special_colors, xg_set_geometry):
131 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
133 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
134 Use esprintf, not sprintf, in case result does not fit in int.
136 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
137 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
138 it as a large positive number.
139 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
140 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
142 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
143 in case result does not fit in int.
145 * print.c (float_to_string): Detect width overflow more reliably.
146 (print_object): Make sprintf buffer a bit bigger, to avoid potential
147 buffer overrun. Don't assume list length fits in 'int'. Treat
148 print length of 0 as 0, not as infinity; to be consistent with other
149 uses of print length in this function. Don't overflow print length
150 index. Don't assume hash table size fits in 'long', or that
151 vectorlike size fits in 'unsigned long'.
153 * process.c (make_process): Use printmax_t, not int, to format
154 process-name gensyms.
156 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
158 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
159 to avoid potential buffer overrun.
161 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
162 if X resource line is longer than 512 bytes.
164 * xfns.c (x_window): Make sprintf buffer a bit bigger
165 to avoid potential buffer overrun.
167 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
169 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
171 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
173 Integer overflow fixes for scrolling, etc.
174 Without these, Emacs silently mishandles large integers sometimes.
175 For example, "C-u 4294967297 M-x recenter" was treated as if
176 it were "C-u 1 M-x recenter" on a typical 64-bit host.
178 * xdisp.c (try_window_id): Check Emacs fixnum range before
181 * window.c (window_scroll_line_based, Frecenter):
182 Check that an Emacs fixnum is in range before assigning it to 'int'.
183 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
184 values converted from Emacs fixnums.
185 (Frecenter): Don't wrap around a line count if it is out of 'int'
186 range; instead, treat it as an extreme value.
187 (Fset_window_configuration, compare_window_configurations):
188 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
190 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
191 that can exceed INT_MAX. Check that EMACS_INT value is in range
192 before assigning it to the (possibly-narrower) index.
193 (match_limit): Don't assume that a fixnum can fit in 'int'.
195 * print.c (print_object): Use ptrdiff_t, not int, for index that can
198 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
199 (Fvertical_motion): Don't wrap around LINES values that don't fit
200 in 'int'. Instead, treat them as extreme values. This is good
201 enough for windows, which can't have more than INT_MAX lines anyway.
203 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
205 * Require libxml/parser.h to avoid compilation warning.
207 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
209 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
210 since this reportedly can destroy thread storage.
212 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
214 * syntax.c (find_defun_start): Update all cache variables if
215 exiting early (Bug#9401).
217 2011-08-30 Eli Zaretskii <eliz@gnu.org>
219 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
221 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
222 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
223 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
225 * term.c (tty_append_glyph): New function.
226 (produce_stretch_glyph): Static function and its prototype deleted.
228 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
231 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
233 * image.c (parse_image_spec): Check for nonnegative, not for positive,
234 when checking :margin (Bug#9390).
235 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
236 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
237 so that the name doesn't mislead. All uses changed.
239 2011-08-28 Johan Bockgård <bojohan@gnu.org>
241 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
244 2011-08-27 Eli Zaretskii <eliz@gnu.org>
246 * xdisp.c (move_it_to): Don't bail out early when reaching
247 position beyond to_charpos, if we are scanning backwards.
248 (move_it_vertically_backward): When DY == 0, make sure we get to
249 the first character in the line after the newline.
251 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
253 * ccl.c: Improve and simplify overflow checking (Bug#9196).
254 (ccl_driver): Do not generate an out-of-range pointer.
255 (Fccl_execute_on_string): Remove unnecessary check for
256 integer overflow, noted by Stefan Monnier in
257 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
258 Remove a FIXME that didn't need fixing.
259 Simplify the newly-introduced buffer reallocation code.
261 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
263 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
265 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
267 Integer and memory overflow issues (Bug#9196).
269 * doc.c (get_doc_string): Rework so that
270 get_doc_string_buffer_size is the actual buffer size, rather than
271 being 1 less than the actual buffer size; this makes xpalloc more
274 * image.c (x_allocate_bitmap_record, cache_image):
275 * xselect.c (Fx_register_dnd_atom):
276 Simplify previous changes by using xpalloc.
278 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
279 since either will do and ptrdiff_t is convenient with xpalloc.
281 * charset.c (charset_table_size)
282 (struct charset_sort_data.priority): Now ptrdiff_t.
283 (charset_compare): Don't overflow if priorities differ greatly.
284 (Fsort_charsets): Don't assume list length fits in int.
285 Check for size-calculation overflow when allocating sort data.
286 (syms_of_charset): Allocate an initial charset table that is
287 just under 64 KiB, to avoid problems with glibc malloc and mmap.
289 * cmds.c (internal_self_insert): Check for size-calculation overflow.
291 * composite.h (struct composition.glyph_len): Now int, not unsigned.
292 The actual value is always <= INT_MAX, and leaving it unsigned made
293 overflow checking harder.
295 * dispextern.h (struct glyph_matrix.rows_allocated)
296 (struct face_cache.size): Now ptrdiff_t, for convenience in use
297 with xpalloc. The values are still always <= INT_MAX.
299 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
301 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
302 (SAFE_NALLOCA): New macro.
304 * region-cache.c (struct boundary.pos, find_cache_boundary)
305 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
306 (set_cache_region, invalidate_region_cache)
307 (revalidate_region_cache, know_region_cache, region_cache_forward)
308 (region_cache_backward, pp_cache):
309 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
310 so that ptrdiff_t * can be passed to xpalloc.
311 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
312 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
313 (pp_cache): Don't assume cache_len fits in int.
314 * region-cache.h: Adjust extern decls to match.
316 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
317 EMACS_INT, since either will do, for xpalloc.
319 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
320 (xnmalloc, xnrealloc, xpalloc): New functions.
322 * bidi.c (bidi_shelve_header_size): New constant.
323 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
324 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
326 * bidi.c (bidi_cache_shrink):
327 * buffer.c (overlays_at, overlays_in, record_overlay_string)
329 Don't update size of array until after memory allocation succeeds,
330 because xmalloc/xrealloc may not return.
331 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
332 now that we have proper integer overflow checking.
333 (record_overlay_string, overlay_strings): Catch overflows when
334 calculating size of overlay_str_buf.
336 * callproc.c (Fcall_process): Check for size overflow when
337 calculating size of args2.
338 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
339 Normally we prefer signed values, but sticking with ptrdiff_t would
340 require adding more-complicated checks.
342 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
343 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
344 Redo buffer-overflow calculations to avoid integer overflow.
345 Add a FIXME comment where memory seems to be over-allocated.
347 * character.c (Fstring): Check for size-calculation overflow.
349 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
350 unnecessary integer overflow. Check for size overflow.
351 (encode_coding_object): Don't update size until xmalloc succeeds.
353 * composite.c (get_composition_id): Check for overflow in glyph
356 Integer and memory overflow fixes for display code.
357 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
358 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
359 (scrolling_window): Check for overflow in size calculations.
360 (line_draw_cost, realloc_glyph_pool, add_row_entry):
361 Don't assume glyph table len fits in int.
362 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
363 (row_table_size): Now ptrdiff_t, not int.
364 (scrolling_window): Avoid overflow in size calculations.
365 Don't update size until allocation succeeds.
366 * fns.c (concat): Check for overflow in size calculations.
367 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
368 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
369 (NEXT_ALMOST_PRIME_LIMIT): New constant.
371 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
372 (get_doc_string): Check for size calculation overflow.
373 Don't update size until allocation succeeds.
374 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
375 EMACS_INT, where ptrdiff_t will do.
376 (Fsubstitute_command_keys): Check for string overflow.
378 * editfns.c (set_time_zone_rule): Don't assume environment length
380 (message_length): Now ptrdiff_t, not int.
381 (Fmessage_box): Don't update size until allocation succeeds.
382 Don't assume message length fits in int.
383 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
385 * emacs.c (main): Do not reallocate argv, since there is a null at
386 the end that can be overwritten, and this way there's no need to
387 worry about size-calculation overflow.
388 (sort_args): Check for size-calculation overflow.
390 * eval.c (init_eval_once, grow_specpdl): Don't update size until
392 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
394 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
395 (x_set_scroll_bar_width, x_figure_window_size):
396 Check for integer overflow.
397 (x_set_alpha): Do not assume XINT fits in int.
399 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
400 This is for the members text_lines, text_cols, total_lines, total_cols,
401 where the system imposes an 'int' limit.
403 * fringe.c (Fdefine_fringe_bitmap):
404 Don't update size until alloc works.
406 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
407 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
409 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
410 Check for size-calculation overflow.
411 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
412 do, as we prefer signed integers.
413 (id_to_widget.max_size, id_to_widget.used)
414 (xg_store_widget_in_map, xg_remove_widget_from_map)
415 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
416 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
417 Use and return ptrdiff_t, not int.
418 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
419 * gtkutil.h: Change prototypes to match the above.
421 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
422 are duplicate now that they've been promoted to lisp.h.
423 (x_allocate_bitmap_record, x_alloc_image_color)
424 (make_image_cache, cache_image, xpm_load):
425 Don't update size until alloc is done.
426 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
428 Check for size calculation overflow.
429 (ct_colors_allocated_max): New constant.
430 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
433 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
434 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
435 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
436 Use ptrdiff_t, not int, to count maps.
437 (read_char_minibuf_menu_prompt): Check for overflow in size
438 calculations. Don't update size until allocation succeeds. Redo
439 calculations to avoid overflow.
440 * keyboard.h: Change prototypes to match the above.
442 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
444 (current_minor_maps): Check for size calculation overflow.
445 * keymap.h: Change prototypes to match the above.
447 * lread.c (read1, init_obarray): Don't update size until alloc done.
449 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
450 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
452 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
453 Now ptrdiff_t, not int.
454 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
455 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
457 * process.c (Fnetwork_interface_list): Check for overflow
460 * region-cache.c (move_cache_gap): Check for size calculation overflow.
462 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
463 overflow. Don't bother calling xmalloc when xrealloc will do.
465 * search.c (Freplace_match): Check for size calculation overflow.
466 (Fset_match_data): Don't assume list lengths fit in 'int'.
468 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
469 for command line length. Do not attempt to address one before the
470 beginning of an array, as that's not portable.
472 * term.c (max_frame_lines): Remove; unused.
473 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
475 (encode_terminal_code, calculate_costs): Check for size
476 calculation overflow.
477 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
478 table lengths and related sizes. Don't update size until alloc
479 done. Redo calculations to avoid overflow.
480 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
482 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
483 subtracting pointers.
484 (gobble_line): Check for overflow more carefully. Don't update size
487 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
488 Don't update size until alloc done.
489 Redo size calculations to avoid overflow.
490 Check for size calculation overflow.
491 (main) [DEBUG]: Fix typo in invoking tparam1.
493 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
494 Use ptrdiff_t, not int, for sizes.
495 (store_mode_line_noprop_char): Don't update size until alloc done.
497 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
498 Use ptrdiff_t, not int, for sizes.
499 (Finternal_make_lisp_face, cache_face):
500 Check for size calculation overflow.
501 (cache_face): Treat size calculation overflows as if they were
502 memory exhaustion (the usual treatment), rather than aborting.
504 * xfns.c (x_encode_text, x_set_name_internal)
505 (Fx_change_window_property): Use ptrdiff_t, not int, to count
506 sizes, since they can exceed INT_MAX in size. Check for size
507 calculation overflow.
509 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
510 (xg_select): Check for size calculation overflow.
511 Don't update size until alloc done.
513 * xrdb.c (get_environ_db): Don't assume path length fits in int,
514 as sprintf is limited to int lengths.
516 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
517 (X_LONG_MIN): New macros.
518 Use them to make the following changes clearer.
519 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
520 This change doesn't affect the value now, but it may help remind
521 future maintainers not to raise the value too much later.
522 (SELECTION_QUANTUM): Remove, replacing with ...
523 (selection_quantum): ... new function, which avoids overflow.
525 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
526 assumption that selection length fits in 'int'.
527 (x_reply_selection_request, x_handle_selection_request)
528 (x_get_window_property, receive_incremental_selection)
529 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
530 (lisp_data_to_selection_data, clean_local_selection_data):
531 Use ptrdiff_t, not int, to record length of selection.
532 (x_reply_selection_request, x_get_window_property)
533 (receive_incremental_selection, x_property_data_to_lisp):
534 Redo calculations to avoid overflow.
535 (x_reply_selection_request): When sending hint, ceiling it at
536 X_LONG_MAX rather than relying on wraparound overflow to send
538 (x_get_window_property, receive_incremental_selection)
539 (lisp_data_to_selection_data, x_property_data_to_lisp):
540 Check for size-calculation overflow.
541 (x_get_window_property, receive_incremental_selection)
542 (lisp_data_to_selection_data, Fx_register_dnd_atom):
543 Don't store size until memory allocation succeeds.
544 (x_get_window_property): Plug memory leak on memory exhaustion.
545 Don't double-block input; malloc is safe here. Don't assume 2**34
546 - 4 fits in unsigned long. Add an xassert to check
547 XGetWindowProperty overflow. Be more careful about overflow
548 calculations, and distinguish size from memory overflow better.
549 (receive_incremental_selection): When tracing, don't assume
550 unsigned int is less than INT_MAX.
551 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
552 harmful) conversions of unsigned short to int.
553 (lisp_data_to_selection_data): Don't assume that integers
554 in the range -65535 through -1 fit in an X unsigned short.
555 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
556 result parameters unless successful. Rely on cons_to_unsigned
557 to report problems with elements; the old code wasn't right anyway.
558 (x_check_property_data): Check for int overflow; we cannot use
559 a wider type due to X limits.
560 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
562 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
564 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
565 (x_term_init): Check for size calculation overflow.
566 (x_color_cells): Don't store size until memory allocation succeeds.
567 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
568 Don't assume alloca size is less than MAX_ALLOCA.
569 (x_term_init): Don't assume length fits in int (sprintf is limited
572 Use ptrdiff_t for composition IDs.
573 * character.c (lisp_string_width):
574 * composite.c (composition_table_size, n_compositions)
575 (get_composition_id, composition_gstring_from_id):
576 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
577 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
578 * window.c (Frecenter):
579 Use ptrdiff_t, not int, for composition IDs.
580 * composite.c (get_composition_id): Check for integer overflow.
581 * composite.h: Adjust prototypes to match the above changes.
583 Use ptrdiff_t for hash table indexes.
584 * category.c (hash_get_category_set):
585 * ccl.c (ccl_driver):
586 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
587 * coding.c (coding_system_charset_list, detect_coding_system):
588 * coding.h (struct coding_system.id):
589 * composite.c (get_composition_id, gstring_lookup_cache):
590 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
591 * image.c (xpm_get_color_table_h):
592 * lisp.h (hash_lookup, hash_put):
593 * minibuf.c (Ftest_completion):
594 Use ptrdiff_t for hash table indexes, not int (which is too
595 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
596 32-bit --with-wide-int hosts).
598 * charset.c (Fdefine_charset_internal): Check for integer overflow.
599 Add a FIXME comment about memory leaks.
600 (syms_of_charset): Don't assume xmalloc returns.
602 Don't assume that stated character widths fit in int.
603 * character.c (Fchar_width, c_string_width, lisp_string_width):
604 * character.h (CHAR_WIDTH):
605 * indent.c (MULTIBYTE_BYTES_WIDTH):
606 Use sanitize_char_width to avoid undefined and/or bad behavior
607 with outlandish widths.
608 * character.h (sanitize_tab_width): Renamed from sanitize_width,
609 now that we have two such functions. All uses changed.
610 (sanitize_char_width): New inline function.
612 Don't assume that tab-width fits in int.
613 * character.h (sanitize_width): New inline function.
614 (SANE_TAB_WIDTH): New macro.
615 (ASCII_CHAR_WIDTH): Use it.
616 * indent.c (sane_tab_width): Remove. All uses replaced by
617 SANE_TAB_WIDTH (current_buffer).
618 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
620 * fileio.c: Integer overflow issues with file modes.
621 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
623 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
624 Remove unreachable code.
625 (read_hex, load_charset_map_from_file): Check for integer overflow.
627 * xterm.c: don't go over XClientMessageEvent limit
628 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
629 (x_send_scroll_bar_event): Likewise. Check that the size does not
630 exceed limits imposed by XClientMessageEvent, as well as the usual
631 ptrdiff_t and size_t limits.
633 * keyboard.c: Overflow, signedness and related fixes.
634 (make_lispy_movement): Use same integer type in forward decl
635 that is used in the definition.
636 (read_key_sequence, keyremap_step):
637 Change bufsize argument back to int, undoing my 2011-03-30 change.
638 We prefer signed types, and int is wide enough here.
639 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
640 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
641 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
642 length, not size_t. Use ptrdiff_t for index, not int.
643 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
644 possibility of integer overflow.
646 Overflow, signedness and related fixes for images.
648 * dispextern.h (struct it.stack[0].u.image.image_id)
649 (struct_it.image_id, struct image.id, struct image_cache.size)
650 (struct image_cache.used, struct image_cache.ref_count):
651 * gtkutil.c (update_frame_tool_bar):
652 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
653 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
654 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
655 * nsmenu.m (update_frame_tool_bar):
656 * xdisp.c (calc_pixel_width_or_height):
657 * xfns.c (image_cache_refcount):
658 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
659 on typical 64-bit hosts.
661 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
662 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
663 Omit unnecessary casts to int.
664 (parse_image_spec): Check that integers fall into 'int' range
665 when the callers expect that.
666 (image_ascent): Redo ascent calculation to avoid int overflow.
667 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
668 (lookup_image): Remove unnecessary tests.
669 (xbm_image_p): Locals are now of int, not EMACS_INT,
670 since parse_image_check makes sure they fit into int.
671 (png_load, gif_load, svg_load_image):
672 Prefer int to unsigned where either will do.
673 (tiff_handler): New function, combining the cores of the
674 old tiff_error_handler and tiff_warning_handler. This
675 function is rewritten to use vsnprintf and thereby avoid
676 stack buffer overflows. It uses only the features of vsnprintf
677 that are common to both POSIX and native Microsoft.
678 (tiff_error_handler, tiff_warning_handler): Use it.
679 (tiff_load, gif_load, imagemagick_load_image):
680 Don't assume :index value fits in 'int'.
681 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
682 (imagemagick_load_image): Check that crop parameters fit into
683 the integer types that MagickCropImage accepts. Don't assume
684 Vimagemagick_render_type has a nonnegative value. Don't assume
685 size_t fits in 'long'.
686 (gs_load): Use printmax_t to print the widest integers possible.
687 Check for integer overflow when computing image height and width.
689 2011-08-26 Eli Zaretskii <eliz@gnu.org>
691 * xdisp.c (redisplay_window): Don't force window start if point
692 will be invisible in the resulting window. (Bug#9324)
694 2011-08-25 Eli Zaretskii <eliz@gnu.org>
696 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
697 the display spec is of the form `(space ...)'.
698 (handle_display_spec): Return the value returned by
699 handle_single_display_spec, not just 1 or zero.
700 (handle_single_display_spec): If the display spec is of the form
701 `(space ...)', and specifies display in the text area, return 2
703 (try_cursor_movement): Check for the need to scroll more
704 accurately, and prefer exact match for point under bidi. Don't
705 advance `row' beyond the last row of the window.
707 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
708 into disp_prop; all users changed.
710 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
711 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
712 for the text covered by the display property.
714 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
716 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
717 Change return value to nil.
718 (Frecord_buffer): Delete unused function.
720 2011-08-24 Eli Zaretskii <eliz@gnu.org>
722 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
723 buffers, return left-to-right.
724 (set_cursor_from_row): Consider candidate row a win if its glyph
725 represents a newline and point is on that newline. Fixes cursor
726 positioning on the newline at EOL of R2L text within L2R
727 paragraph, and vice versa.
728 (try_cursor_movement): Check continued rows, in addition to
729 continuation rows. Fixes unwarranted scroll when point enters a
730 continued line of R2L text within an L2R paragraph, or vice versa.
731 (cursor_row_p): Consider the case of point being equal to
732 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
733 from the end of a short line to the beginning of a continued line
734 of R2L text within L2R paragraph.
735 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
738 * bidi.c (bidi_check_type): Use xassert.
739 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
742 2011-08-23 Eli Zaretskii <eliz@gnu.org>
744 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
747 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
749 * nsfont.m (ns_otf_to_script): Fix typo.
751 2011-08-22 Kenichi Handa <handa@m17n.org>
753 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
754 extra slot even if the purpose is char-code-property-table.
756 2011-08-23 Eli Zaretskii <eliz@gnu.org>
758 * xdisp.c (redisplay_window): When computing centering_position,
759 account for the height of the header line. (Bug#8874)
761 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
762 instead of CHAR_TO_BYTE. Fixes a crash when a completion
763 candidate is selected by the mouse, and that candidate has a
764 composed character under the mouse.
766 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
767 coordinates reported by pos-visible-in-window-p for a composed
768 character in column zero.
770 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
772 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
774 2011-08-22 Eli Zaretskii <eliz@gnu.org>
776 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
777 consider it a hit if to_charpos is anywhere in the range of the
778 composed buffer positions.
780 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
782 * image.c (gif_load): Don't assume that each subimage has the same
783 dimensions as the base image. Handle disposal method that is
784 "undefined" by the gif spec (Bug#9335).
786 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
788 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
789 (Fcondition_case): Document `debug' symbol in error handler.
791 2011-08-19 Eli Zaretskii <eliz@gnu.org>
793 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
794 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
795 from an Org mode buffer to a Speedbar frame.
797 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
798 a composition, take its buffer position from IT->cmp_it.charpos.
799 Fixes cursor positioning at the beginning of a line that begins
800 with a composed character.
802 2011-08-18 Eli Zaretskii <eliz@gnu.org>
804 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
805 character bidirectional type, use STRONG_L instead. Fixes crashes
806 in a buffer produced by `describe-categories'.
808 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
809 members before the level stack, so they would be saved and
810 restored when copying iterator state. Fixes incorrect reordering
811 around TABs covered by display properties.
813 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
815 * process.c (Fnetwork_interface_list): Correctly determine buffer
818 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
820 * eval.c (internal_condition_case, internal_condition_case_1)
821 (internal_condition_case_2, internal_condition_case_n):
822 Remove unnecessary aborts (Bug#9081).
824 2011-08-17 Eli Zaretskii <eliz@gnu.org>
826 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
827 has no `load' handler, try opening the file locally. (Bug#9311)
829 2011-08-16 Ken Brown <kbrown@cornell.edu>
831 * gmalloc.c: Expand comment.
833 2011-08-16 Eli Zaretskii <eliz@gnu.org>
835 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
836 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
838 2011-08-16 Ken Brown <kbrown@cornell.edu>
840 Fix memory allocation problems in Cygwin build (Bug#9273).
842 * unexcw.c ( __malloc_initialized): Declare external variable.
843 (fixup_executable): Force the dumped emacs to reinitialize malloc.
845 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
847 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
849 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
851 [CYGWIN] (special_realloc): New function.
852 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
853 requests to realloc storage in the static heap.
855 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
857 * bidi.c (bidi_initialize): Remove unused local.
859 2011-08-15 Eli Zaretskii <eliz@gnu.org>
861 * biditype.h: File removed.
863 * bidimirror.h: File removed.
865 * deps.mk (bidi.o): Remove biditype.h and
868 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
871 * dispextern.h: Fix a typo in the comment to bidi_type_t.
873 * chartab.c: Improve commentary for the uniprop_table API.
875 * bidi.c (bidi_paragraph_init): Support zero value of
876 bidi_ignore_explicit_marks_for_paragraph_level.
877 (bidi_initialize): Use uniprop_table instead of including
878 biditype.h and bidimirror.h.
880 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
881 coordinates of the iterator when restoring from ppos_it.
884 2011-08-14 Kenichi Handa <handa@m17n.org>
886 * process.c (create_process): Call setup_process_coding_systems
887 after the pid of the process is set to -1 (Bug#8162).
889 2011-08-14 Eli Zaretskii <eliz@gnu.org>
891 * xdisp.c (move_it_in_display_line_to): Don't invoke
892 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
893 ppos_it. Fixes vertical cursor motion when line beginning is
894 covered by an image. (Bug#9296)
896 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
898 * nsterm.h (ns_run_ascript): Declare.
899 (NSAPP_DATA2_RUNASSCRIPT): Define.
901 * nsfns.m (as_script, as_result, as_status): New static variables.
902 (ns_run_ascript): New function.
903 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
904 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
905 the event loop. Get status from as_status (Bug#7276).
907 * nsterm.m (sendEvent): If event is NSApplicationDefined and
908 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
909 the event loop (Bug#7276).
911 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
913 * gnutls.c (QCgnutls_bootprop_priority)
914 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
915 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
916 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
917 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
918 (QCgnutls_bootprop_verify_hostname_error)
919 (QCgnutls_bootprop_callbacks_verify): Rename from
920 Qgnutls_bootprop_..., all uses changed.
922 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
925 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
927 * xfaces.c (Qframe_set_background_mode): Now static.
928 * dispextern.h (Qframe_set_background_mode): Remove decl.
930 * process.c (Fnetwork_interface_info): Declare local only if needed.
932 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
934 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
935 (Fnetwork_interface_list): Allocate in increments of bytes instead
936 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
937 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
939 (struct ifflag_def): notrailers is smart on OSX.
940 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
941 Get hardware address with getifaddrs if available.
943 2011-08-12 Eli Zaretskii <eliz@gnu.org>
945 * xdisp.c (iterate_out_of_display_property): xassert that
946 IT->position is set to within IT->object's boundaries. Break from
947 the loop as soon as EOB is reached; avoids infloops in redisplay
948 when IT->position is set up wrongly due to some bug.
949 Set IT->current to match the bidi iterator unconditionally.
950 (push_display_prop): Allow GET_FROM_STRING as IT->method on
951 entry. Force push_it to save on the stack the current
952 buffer/string position, to be restored by pop_it. Fix flags in
953 the iterator structure wrt the object coming from a display
954 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
955 properties. (Bug#9284)
957 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
959 * fontset.c (fontset_get_font_group): Add proper type checks.
962 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
964 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
965 and LC_VERSION_MIN_MACOSX.
966 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
967 (dump_it) [LC_FUNCTION_STARTS]: Use it.
969 2011-08-08 Eli Zaretskii <eliz@gnu.org>
971 * xdisp.c (forward_to_next_line_start): Allow to use the
972 no-display-properties-and-no-overlays under bidi display.
973 Set disp_pos in the bidi iterator to avoid searches for display
974 properties and overlays.
976 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
978 * editfns.c (Fset_time_zone_rule): Document relationship with the
981 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
982 the font entity extracted from the cache (Bug#8109).
984 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
986 * composite.c (autocmp_chars): Don't reset point. That is done by
987 restore_point_unwind (Bug#5984).
989 2011-08-07 Juri Linkov <juri@jurta.org>
991 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
992 to show the arg `TIME' instead of `TIMEVAL'.
994 2011-08-06 Eli Zaretskii <eliz@gnu.org>
996 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
997 display property strides EOL and includes a newline, as in
998 longlines-mode. (Bug#9254)
999 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1000 word-wrap under bidirectional display. (Bug#9224)
1002 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1003 is non-zero, even if the data buffer is NULL. Fixes a crash in
1004 vertical-motion with longlines-mode. (Bug#9254)
1006 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1008 * bidi.c <bidi_cache_total_alloc>: Now static.
1009 (bidi_initialize): Initialize bidi_cache_total_alloc.
1011 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1014 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1015 amount allocated this far in `bidi_cache_total_alloc'.
1016 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1017 non-zero, only free the data buffer without restoring the cache
1018 contents. All callers changed.
1020 * dispextern.h (bidi_unshelve_cache): Update prototype.
1022 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1023 (move_it_in_display_line, move_it_to)
1024 (move_it_vertically_backward, move_it_by_lines): Replace the call
1025 to xfree to an equivalent call to bidi_unshelve_cache.
1026 (move_it_in_display_line_to): Fix logic of returning
1027 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1029 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1031 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1032 came from a string character with a `cursor' property. (Bug#9229)
1034 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1036 * Makefile.in (LIB_PTHREAD): New variable.
1037 (LIBES): Add LIB_PTHREAD (Bug#9216).
1039 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1040 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1042 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1044 * regex.c (re_iswctype): Remove some redundant boolean
1047 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1049 * xterm.c (x_find_topmost_parent): New function.
1050 (x_set_frame_alpha): Find topmost parent window with
1051 x_find_topmost_parent and set the property there also (bug#9181).
1052 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1054 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1056 * callproc.c (Fcall_process): Avoid vfork clobbering
1057 the local vars buffer, coding_systems, current_dir.
1059 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1061 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1063 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1065 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1066 so that it is not optimized away.
1068 * xdisp.c (compute_display_string_pos): Remove unused local.
1070 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1072 Fix slow cursor motion and scrolling in large buffers with
1073 selective display, like Org Mode buffers. (Bug#9218)
1075 * dispextern.h (struct bidi_it): New member disp_prop_p.
1077 * xdisp.c: Remove one-slot cache of display string positions.
1078 (compute_display_string_pos): Accept an additional argument
1079 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1080 for a display string or property. If found, set DISP_PROP_P
1083 * bidi.c (bidi_fetch_char): Accept an additional argument
1084 DISP_PROP_P, and pass it to compute_display_string_pos.
1085 Only handle text covered by a display string if DISP_PROP_P is returned
1086 non-zero. All callers of bidi_fetch_char changed.
1088 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1090 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1092 2010-12-03 Don March <don@ohspite.net>
1094 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1095 last character M-[char] is translated to ESC [char] (bug#7541).
1097 2011-08-02 Kenichi Handa <handa@m17n.org>
1099 * lisp.h (uniprop_table): Extern it.
1101 * chartab.c (uniprop_table): Make it non-static.
1103 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1105 * xdisp.c (forward_to_next_line_start): Accept additional argument
1106 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1108 (reseat_at_next_visible_line_start): Use the bidi iterator state
1109 returned by forward_to_next_line_start to restore the state of
1110 it->bidi_it after backing up to previous newline. (Bug#9212)
1112 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1114 * regex.c (re_comp): Protoize.
1115 (re_exec): Fix return type.
1116 (regexec): Fix type of `ret'. (Bug#9203)
1118 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1120 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1121 This is needed if max-image-size is a floating-point number.
1123 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1125 * print.c (print_object): Print empty symbol as ##.
1127 * lread.c (read1): Read ## as empty symbol.
1129 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1131 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1132 setting frame foreground color (Bug#9175).
1133 (x_set_background_color): Likewise.
1135 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1136 contents (Bug#9176).
1137 (EmacsTooltip -init): Remove bezels and add shadows to
1140 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1141 or scroll bar (Bug#8470).
1143 * nsfont.m (nsfont_open): Remove assignment to voffset and
1144 unnecessary vars hshink, expand, hd, full_height, min_height.
1145 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1147 * nsterm.h (nsfont_info): Remove voffset field.
1149 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1151 Implement strike-through and overline on NextStep (Bug#8863).
1153 * nsfont.m (nsfont_open): Use underline position provided by font,
1154 instead of hard-coded value of 2.
1155 (nsfont_draw): Call ns_draw_text_decoration instead.
1157 * nsterm.h: Add declaration for ns_draw_text_decoration.
1159 * nsterm.m (ns_draw_text_decoration): New function for drawing
1160 underline, overline, and strike-through.
1161 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1162 ns_draw_text_decoration. Change treatment of cursor drawing to
1163 accomodate underlining, etc.
1165 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1167 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1170 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1172 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1173 Without this fix, if a signal arrives just after memory fills up,
1174 'malloc' might be invoked reentrantly.
1176 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1177 In other words, assume that every image size is allowed, on non-X
1178 hosts. This assumption is probably wrong, but it lets Emacs compile.
1180 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1182 * regex.c (re_iswctype): Convert return values to boolean.
1184 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1186 * xdisp.c (compute_display_string_pos): Don't use cached display
1187 string position if the buffer had its restriction changed.
1190 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1192 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1194 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1196 Integer signedness and overflow and related fixes. (Bug#9079)
1198 * bidi.c: Integer size and overflow fixes.
1199 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1200 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1201 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1202 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1203 (bidi_find_other_level_edge):
1204 Use ptrdiff_t instead of EMACS_INT where either will do.
1205 This works better on 32-bit hosts configured --with-wide-int.
1206 (bidi_cache_ensure_space): Check for size-calculation overflow.
1207 Use % rather than repeated addition, for better worst-case speed.
1208 Don't set bidi_cache_size until after xrealloc returns, because it
1210 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1211 (bidi_cache_ensure_space): Also check that the bidi cache size
1212 does not exceed that of the largest Lisp string or buffer. See Eli
1213 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1215 * alloc.c (__malloc_size_t): Remove.
1216 All uses replaced by size_t. See Andreas Schwab's note
1217 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1219 * image.c: Improve checking for integer overflow.
1220 (check_image_size): Assume that f is nonnull, since
1221 it is always nonnull in practice. This is one less thing to
1222 worry about when checking for integer overflow later.
1223 (x_check_image_size): New function, which checks for integer
1224 overflow issues inside X.
1225 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1226 This removes the need for a memory_full check.
1227 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1228 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1229 (xbm_read_bitmap_data): Change locals back to 'int', since
1230 their values must fit in 'int'.
1231 (xpm_load_image, png_load, tiff_load):
1232 Invoke x_create_x_image_and_pixmap earlier,
1233 to avoid much needless work if the image is too large.
1234 (tiff_load): Treat overly large images as if
1235 x_create_x_image_and_pixmap failed, not as malloc failures.
1236 (gs_load): Use x_check_image_size.
1238 * gtkutil.c: Omit integer casts.
1239 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1240 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1242 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1244 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1245 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1246 would wrongly return t on a 64-bit host.
1248 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1249 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1250 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1251 and therefore cause GCC to emit a bogus diagnostic in some cases.
1253 * image.c: Integer signedness and overflow and related fixes.
1254 This is not an exhaustive set of fixes, but it's time to
1255 record what I've got.
1256 (lookup_pixel_color, check_image_size): Remove redundant decls.
1257 (check_image_size): Don't assume that arbitrary EMACS_INT values
1258 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1259 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1260 (tiff_load, imagemagick_load_image):
1261 Check for overflow in size calculations.
1262 (x_create_x_image_and_pixmap): Remove unnecessary test for
1263 xmalloc returning NULL; that can't happen.
1264 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1265 (xpm_color_bucket): Use better integer hashing function.
1266 (xpm_cache_color): Don't possibly over-allocate memory.
1267 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1268 (gif_memory_source):
1269 Use ptrdiff_t, not int or size_t, to record sizes.
1270 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1271 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1272 either works, as we prefer signed integers.
1273 (tiff_read_from_memory, tiff_write_from_memory):
1274 Return tsize_t, not size_t, since that's what the TIFF API wants.
1275 (tiff_read_from_memory): Don't fail simply because the read would
1276 go past EOF; instead, return a short read.
1277 (tiff_load): Omit no-longer-needed casts.
1278 (Fimagemagick_types): Don't assume size fits into 'int'.
1280 Improve hashing quality when configured --with-wide-int.
1281 * fns.c (hash_string): New function, taken from sxhash_string.
1282 Do not discard information about ASCII character case; this
1283 discarding is no longer needed.
1284 (sxhash-string): Use it. Change sig to match it. Caller changed.
1285 * lisp.h: Declare it.
1286 * lread.c (hash_string): Remove, since we now use fns.c's version.
1287 The fns.c version returns a wider integer if --with-wide-int is
1288 specified, so this should help the quality of the hashing a bit.
1290 * emacs.c: Integer overflow minor fix.
1291 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1292 Define only if GNU_LINUX.
1293 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1295 * dispnew.c: Integer signedness and overflow fixes.
1296 Remove unnecessary forward decls, that were a maintenance hassle.
1297 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1299 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1300 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1301 (prepare_desired_row, line_draw_cost):
1302 Use int, not unsigned, where either works.
1303 (save_current_matrix, restore_current_matrix):
1304 Use ptrdiff_t, not size_t, where either works.
1305 (init_display): Check for overflow more accurately, and without
1306 relying on undefined behavior.
1308 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1309 Remove, replacing with the new symbols in lisp.h. All uses changed.
1310 * fileio.c (make_temp_name):
1311 * filelock.c (lock_file_1, lock_file):
1312 * xdisp.c (message_dolog):
1313 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1314 Use pMd etc. instead.
1315 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1316 replacing the pWIDE etc. symbols removed from editfns.c.
1318 * keyboard.h (num_input_events): Now uintmax_t.
1319 This is (very slightly) less likely to mess up due to wraparound.
1322 * buffer.c: Integer signedness fixes.
1323 (alloc_buffer_text, enlarge_buffer_text):
1324 Use ptrdiff_t rather than size_t when either will do, as we prefer
1327 * alloc.c: Integer signedness and overflow fixes.
1328 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1329 (__malloc_size_t): Default to size_t, not to int.
1330 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1331 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1332 Prefer ptrdiff_t to size_t when either would do, as we prefer
1334 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1335 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1336 Now const. Initialize with values that are in range even if char
1338 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1339 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1340 These functions do the right thing with sizes > 2**32.
1341 (check_depth): Now ptrdiff_t, not int.
1342 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1343 Adjust to new way of storing sizes. Check for size overflow bugs
1345 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1346 slightly wrong anyway, as it missed one instance of
1347 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1348 (refill_memory_reserve): Omit needless cast to size_t.
1349 (mark_object_loop_halt): Mark as externally visible.
1351 * xselect.c: Integer signedness and overflow fixes.
1352 (Fx_register_dnd_atom, x_handle_dnd_message):
1353 Use ptrdiff_t, not size_t, since we prefer signed.
1354 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1355 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1356 x_dnd_atoms_size and x_dnd_atoms_length.
1358 * doprnt.c: Prefer signed to unsigned when either works.
1360 * doprnt.c (doprnt):
1362 * xdisp.c (vmessage):
1363 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1364 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1365 prefer signed arithmetic to avoid comparison confusion.
1366 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1367 but is a bit tricky.
1369 Assume freestanding C89 headers, string.h, stdlib.h.
1370 * data.c, doprnt.c, floatfns.c, print.c:
1371 Include float.h unconditionally.
1372 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1373 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1374 * regex.c: Likewise for stddef.h, string.h.
1375 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1376 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1377 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1378 (STDC_HEADERS): Remove obsolete defines.
1379 * sysdep.c: Include limits.h unconditionally.
1381 Assume support for memcmp, memcpy, memmove, memset.
1382 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1383 * regex.c (memcmp, memcpy):
1384 Remove; we assume C89 now.
1386 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1387 (__malloc_safe_bcopy): Remove; no longer needed.
1389 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1390 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1391 well either way, and we prefer signed to unsigned.
1393 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1395 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1396 closes the connection while we're reading (bug#9182).
1398 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1400 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1401 are specified (Bug#9168).
1403 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1405 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1406 Found by GCC static checking and --with-wide-int on a 32-bit host.
1408 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1410 * xdisp.c (compute_display_string_pos): Fix logic of caching
1411 previous display string position. Initialize cached_prev_pos to
1412 -1. Fixes slow-down at the beginning of a buffer.
1414 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1416 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1417 for attrs[LFACE_FONTSET_INDEX].
1419 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1421 * xml.c (parse_region): Remove unused local
1422 that was recently introduced.
1424 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1426 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1427 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1429 * xdisp.c (move_it_in_display_line_to): Record the best matching
1430 position for TO_CHARPOS while scanning the line, and restore it on
1431 exit if none of the characters scanned was an exact match.
1432 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1433 when exact match is impossible due to invisible text, and the
1434 lines are truncated.
1436 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1438 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1441 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1443 Fix a significant slow-down of cursor motion with C-n, C-p,
1444 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1445 auto-repeat under bidi redisplay in fontified buffers.
1446 * xdisp.c (compute_stop_pos_backwards): New function.
1447 (next_element_from_buffer): Call compute_stop_pos_backwards to
1448 find a suitable prev_stop when we find ourselves before
1450 (reseat): Don't look for prev_stop, as that could mean a very long
1452 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1453 <cached_disp_overlay_modiff>: Cache for last found display string
1455 (compute_display_string_pos): Return the cached position if asked
1456 about the same buffer in the same area of character positions, and
1457 the buffer wasn't changed since the time the display string
1458 position was cached.
1460 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1462 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1463 is an integer, which is important for empty lines. (Bug#9149)
1465 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1467 * frame.c (Fmodify_frame_parameters): In tty case, update the
1468 default face if necessary (Bug#4238).
1470 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1472 * editfns.c (Fstring_to_char): No need to explain what a character
1473 is in the docstring (Bug#6576).
1475 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1477 * xml.c (parse_region): Make sure we always return a tree.
1479 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1481 * xml.c (parse_region): If a document contains only comments,
1484 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1486 * xml.c (make_dom): Return comments, too.
1488 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1491 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1492 and the surrounding thread.
1493 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1494 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1495 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1497 * s/openbsd.h (BROKEN_SIGIO): Define.
1498 * unexelf.c (unexec) [__OpenBSD__]:
1499 Don't update the .mdebug section of the Alpha COFF symbol table.
1501 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1503 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1506 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1508 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1509 This fixes some race conditions on the permissions of any newly
1512 * alloc.c (valid_pointer_p): Use pipe, not open.
1513 This fixes some permissions issues when debugging.
1515 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1516 If fchown fails to set both uid and gid, try to set just gid,
1517 as that is sometimes allowed. Adjust the file's mode to eliminate
1518 setuid or setgid bits that are inappropriate if fchown fails.
1520 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1522 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1523 to compare Lisp_Objects.
1524 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1525 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1526 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1528 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1530 * lread.c (read_integer): Unread even EOF character.
1531 (read1): Likewise. Properly record start position of symbol.
1533 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1534 symbol character follows.
1536 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1538 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1539 This works around a problem with the previous change to Fcopy_file.
1540 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1541 and without this change, GCC might complain about discarding
1542 fchown's return value.
1544 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1546 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1548 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1550 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1552 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1554 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1555 it's used from the C level.
1557 * process.c: Use the same condition for POLL_FOR_INPUT in both
1558 keyboard.c and process.c (bug#1858).
1560 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1562 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1563 (Fgnutls_boot): Use it.
1565 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1567 * doc.c (Fsubstitute_command_keys): Revert last change.
1569 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1571 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1572 quotes the next character, and doesn't affect other longer
1573 sequences (bug#8935).
1575 * lread.c (syms_of_lread): Clarify that is isn't only
1576 `eval-buffer' and `eval-defun' that's affected by
1577 `lexical-binding' (bug#8460).
1579 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1581 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1582 bidi redisplay when a line includes both an image and is
1585 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1587 Fix minor problems found by static checking.
1588 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1589 (elsz): Now a signed constant, not a size_t var. We prefer signed
1590 types to unsigned, to avoid integer comparison confusion. Without
1591 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1592 "cannot optimize loop, the loop counter may overflow", a symptom
1594 * indent.c (Fvertical_motion): Mark locals as initialized.
1595 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1597 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1599 * search.c (Fre_search_backward): Mention `case-fold-search' in
1600 all the re_search_* functions (bug#8138).
1602 * keyboard.c (Fopen_dribble_file): Document when the file is
1605 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1607 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1610 Support bidi reordering of display and overlay strings.
1611 * xdisp.c (compute_display_string_pos)
1612 (compute_display_string_end): Accept additional argument STRING.
1613 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1614 (reseat_to_string): Initialize bidi_it->string.s and
1615 bidi_it->string.schars.
1616 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1617 NULL (avoids a crash in bidi_paragraph_init).
1618 Initialize itb.string.lstring.
1619 (init_iterator): Call bidi_init_it only of a valid
1620 buffer position was specified. Initialize paragraph_embedding to
1622 (reseat_to_string): Initialize the bidi iterator.
1623 (display_string): If we need to ignore text properties of
1624 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1625 original value of -1 will not work with bidi.)
1626 (compute_display_string_pos): First arg is now struct
1627 `text_pos *'; all callers changed. Support display properties on
1629 (compute_display_string_end): Support display properties on Lisp
1631 (init_iterator, reseat_1, reseat_to_string): Initialize the
1632 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1633 when iterating on a string not from display properties).
1634 (compute_display_string_pos, compute_display_string_end):
1635 Fix calculation of the object to scan. Fixes an error when using
1637 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1638 base_level_stop; instead, set base_level_stop to BEGV.
1639 Fixes crashes in vertical-motion.
1640 (next_element_from_buffer): Improve commentary for when
1641 the iterator is before prev_stop.
1642 (init_iterator): Initialize bidi_p from the default value of
1643 bidi-display-reordering, not from buffer-local value. Use the
1644 buffer-local value only if initializing for buffer iteration.
1645 (handle_invisible_prop): Support invisible properties on strings
1646 that are being bidi-reordered.
1647 (set_iterator_to_next): Support bidi reordering of C strings and
1649 (next_element_from_string): Support bidi reordering of Lisp
1651 (handle_stop_backwards): Support Lisp strings as well.
1652 (display_string): Support display of R2L glyph rows.
1653 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1654 (init_iterator): Don't initialize it->bidi_p for strings
1656 (reseat_to_string): Initialize it->bidi_p for strings here.
1657 (next_element_from_string, next_element_from_c_string)
1658 (next_element_from_buffer): Add xassert's for correspondence
1659 between IT's object being iterated and it->bidi_it.string
1661 (face_before_or_after_it_pos): Support bidi iteration.
1662 (next_element_from_c_string): Handle the case of the first string
1663 character that is not the first one in the visual order.
1664 (get_visually_first_element): New function, refactored from common
1665 parts of next_element_from_buffer, next_element_from_string, and
1666 next_element_from_c_string.
1667 (tool_bar_lines_needed, redisplay_tool_bar)
1668 (display_menu_bar): Force left-to-right direction. Add a FIXME
1669 comment for making that be controlled by a user option.
1670 (push_it, pop_it): Save and restore the state of the
1671 bidi iterator. Save and restore the bidi_p flag.
1672 (pop_it): Iterate out of display property for string iteration as
1674 (iterate_out_of_display_property): Support iteration over strings.
1675 (handle_single_display_spec): Set up it->bidi_it for iteration
1676 over a display string, and call bidi_init_it.
1677 (handle_single_display_spec, next_overlay_string)
1678 (get_overlay_strings_1, push_display_prop): Set up the bidi
1679 iterator for displaying display or overlay strings.
1680 (forward_to_next_line_start): Don't use the shortcut if
1682 (back_to_previous_visible_line_start): If handle_display_prop
1683 pushed the iterator stack, restore the internal state of the bidi
1684 iterator by calling bidi_pop_it same number of times.
1685 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1686 and we are bidi-iterating, don't decrement the iterator position;
1687 instead, set the first_elt flag in the bidi iterator, to produce
1689 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1690 (push_display_prop): xassert that we are iterating a buffer.
1691 (push_it, pop_it): Save and restore paragraph_embedding member.
1692 (handle_single_display_spec, next_overlay_string)
1693 (get_overlay_strings_1, reseat_1, reseat_to_string)
1694 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1695 correctly. Don't assume unibyte strings are not bidi-reordered.
1696 (compute_display_string_pos)
1697 (compute_display_string_end): Fix handling the case of C string.
1698 (push_it, pop_it): Save and restore from_disp_prop_p.
1699 (handle_single_display_spec, push_display_prop): Set the
1700 from_disp_prop_p flag.
1701 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1702 (pop_it): Call iterate_out_of_display_property only if we are
1703 popping after iteration over a string that came from a display
1704 property. Fix a typo in popping stretch info. Add an assertion
1705 for verifying that the iterator position is in sync with the bidi
1707 (handle_single_display_spec, get_overlay_strings_1)
1708 (push_display_prop): Fix initialization of paragraph direction for
1709 string when that of the parent object is not yet determined.
1710 (reseat_1): Call bidi_init_it to resync the bidi
1711 iterator with IT's position. (Bug#7616)
1712 (find_row_edges): If ROW->start.pos gives position
1713 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1714 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1715 Reset the from_disp_prop_p flag.
1716 (SAVE_IT, RESTORE_IT): New macros.
1717 (pos_visible_p, face_before_or_after_it_pos)
1718 (back_to_previous_visible_line_start)
1719 (move_it_in_display_line_to, move_it_in_display_line)
1720 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1721 (try_scrolling, redisplay_window, display_line): Use them when
1722 saving a temporary copy of the iterator and restoring it back.
1723 (back_to_previous_visible_line_start, reseat_1)
1724 (init_iterator): Empty the bidi cache "stack".
1725 (move_it_in_display_line_to): If iterator ended up at
1726 EOL, but we never saw any buffer positions smaller than
1727 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1728 motion in bidi-reordered lines.
1729 (move_it_in_display_line_to): Record prev_method and prev_pos
1730 immediately before the call to set_iterator_to_next. Fixes cursor
1731 motion in bidi-reordered lines with stretch glyphs and strings
1732 displayed in margins. (Bug#8133) (Bug#8867)
1733 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1735 (pos_visible_p): Support positions in bidi-reordered lines.
1736 Save and restore bidi cache.
1738 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1739 (bidi_paragraph_info): Delete unused struct.
1740 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1741 (bidi_cache_start): New variable.
1742 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1744 (bidi_cache_fetch_state, bidi_cache_search)
1745 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1746 (bidi_cache_find, bidi_peek_at_next_level)
1747 (bidi_level_of_next_char, bidi_find_other_level_edge)
1748 (bidi_move_to_visually_next): Compare cache index with
1749 bidi_cache_start rather than with zero.
1750 (bidi_fetch_char): Accept new argument STRING; all callers
1751 changed. Support iteration over a string. Support strings with
1752 display properties. Support unibyte strings. Fix the type of
1753 `len' according to what STRING_CHAR_AND_LENGTH expects.
1754 (bidi_paragraph_init, bidi_resolve_explicit_1)
1755 (bidi_resolve_explicit, bidi_resolve_weak)
1756 (bidi_level_of_next_char, bidi_move_to_visually_next):
1757 Support iteration over a string.
1758 (bidi_set_sor_type, bidi_resolve_explicit_1)
1759 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1760 can now be zero (for strings); special values 0 and -1 were
1761 changed to -1 and -2, respectively.
1762 (bidi_char_at_pos): New function.
1763 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1764 Call it instead of FETCH_MULTIBYTE_CHAR.
1765 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1766 initialized to valid values.
1767 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1769 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1770 the test for valid cached positions. Fix the logic for looking up
1771 the sentinel state in the cache. GCPRO the Lisp string we are
1773 (bidi_push_it, bidi_pop_it): New functions.
1774 (bidi_initialize): Initialize the bidi cache start stack pointer.
1775 (bidi_cache_ensure_space): New function, refactored from part of
1776 bidi_cache_iterator_state. Don't assume the required size is just
1777 one BIDI_CACHE_CHUNK away.
1778 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1779 (bidi_count_bytes, bidi_char_at_pos): New functions.
1780 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1781 always valid if bidi_cache_idx is valid.
1782 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1783 is valid if it's going to be used.
1784 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1785 (bidi_cache_fetch_state, bidi_cache_search)
1786 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1787 (bidi_cache_iterator_state, bidi_cache_find)
1788 (bidi_find_other_level_edge, bidi_cache_start_stack):
1789 All variables related to cache indices are now EMACS_INT.
1791 * dispextern.h (struct bidi_string_data): New structure.
1792 (struct bidi_it): New member `string'. Make flag members be 1-bit
1793 fields, and put them last in the struct.
1794 (compute_display_string_pos, compute_display_string_end):
1796 (bidi_push_it, bidi_pop_it): Add prototypes.
1797 (struct iterator_stack_entry): New members bidi_p,
1798 paragraph_embedding, and from_disp_prop_p.
1799 (struct it): Member bidi_p is now a bit field 1 bit wide.
1800 (bidi_shelve_cache, bidi_unshelve_cache):
1803 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1804 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1805 and vector-like objects.
1807 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1808 cache around display iteration.
1810 * window.c (Fwindow_end, window_scroll_pixel_based)
1811 (displayed_window_lines, Frecenter): Save and restore the bidi
1812 cache around display iteration.
1814 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1816 * editfns.c (Fdelete_region): Clarify the use of the named
1817 parameters (bug#6788).
1819 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1821 * indent.c (Fvertical_motion): Set and restore w->pointm when
1822 saving and restoring the window's buffer (Bug#9006).
1824 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1826 * editfns.c (Fstring_to_char): Clarify just what is returned
1827 (bug#6576). Text by Eli Zaretskii.
1829 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1831 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1833 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1835 * buffer.c (mmap_find): Fix a typo.
1837 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1839 Fix execution of x selection hooks.
1840 * xselect.c (Qx_lost_selection_functions)
1841 (Qx_sent_selection_functions): New vars.
1842 (syms_of_xselect): DEFSYM them.
1843 (x_handle_selection_request): Pass Qx_sent_selection_functions
1844 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1845 (x_handle_selection_clear,x_clear_frame_selections):
1846 Pass Qx_lost_selection_functions rather than
1847 Vx_lost_selection_functions to Frun_hook_with_args.
1849 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1851 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1852 The old code sometimes used this field without initializing it.
1854 * alloc.c (gc_sweep): Don't read past end of array.
1855 In theory, the old code could also have corrupted Emacs internals,
1856 though it'd be very unlikely.
1858 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1860 * character.c (Fcharacterp): Don't advertise optional ignored
1861 argument. (Bug#4026)
1863 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1865 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1868 * window.c (Fset_window_start): Doc fix (bug#4199).
1869 (Fset_window_hscroll): Ditto.
1871 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1873 Fix minor new problems caught by GCC 4.6.1.
1874 * term.c (init_tty): Remove unused local.
1875 * xsettings.c (store_monospaced_changed): Define this function only
1876 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1879 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1881 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1883 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1885 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1886 are the mini-buffer and the echo area (bug#3320).
1888 * term.c (init_tty): Remove support for supdup, c10 and perq
1889 terminals, which are no longer supported (bug#1482).
1891 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1893 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1895 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1897 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1898 for non-popups (Bug#3642).
1900 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1902 * alloc.c (reset_malloc_hooks): Protoize.
1903 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1904 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1905 * cm.c (losecursor): Likewise.
1906 * data.c (fmod): Likewise.
1907 * dispnew.c (swap_glyphs_in_rows): Likewise.
1908 * emacs.c (memory_warning_signal): Likewise.
1909 * floatfns.c (float_error): Likewise.
1910 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1911 (otf_open, font_otf_capability, generate_otf_features)
1912 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1914 * image.c (pbm_read_file): Likewise.
1915 * indent.c (string_display_width): Likewise.
1916 * intervals.c (check_for_interval, search_for_interval)
1917 (inc_interval_count, count_intervals, root_interval)
1918 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1919 * lread.c (defalias): Likewise.
1920 * ralloc.c (r_alloc_check): Likewise.
1921 * regex.c (set_image_of_range_1, set_image_of_range)
1922 (regex_grow_registers): Likewise.
1923 * sysdep.c (strerror): Likewise.
1924 * termcap.c (valid_filename_p, tprint, main): Likewise.
1925 * tparam.c (main): Likewise.
1926 * unexhp9k800.c (run_time_remap, save_data_space)
1927 (update_file_ptrs, read_header, write_header, calculate_checksum)
1928 (copy_file, copy_rest, display_header): Likewise.
1929 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1931 * xdisp.c (check_it): Likewise.
1932 * xfaces.c (register_color, unregister_color, unregister_colors):
1934 * xfns.c (print_fontset_result): Likewise.
1935 * xrdb.c (member, fatal, main): Likewise.
1937 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1939 Fix minor problems found by static checking (Bug#9031).
1940 * chartab.c (char_table_set_range, map_sub_char_table):
1941 Remove unused locals.
1942 (uniprop_table): Now static.
1943 * composite.c (_work_char): Remove unused static var.
1945 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1947 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1949 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1951 * gtkutil.c (qttip_cb): Remove code without function.
1953 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1955 * w32.c (pthread_sigmask): New stub.
1957 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1959 Use pthread_sigmask, not sigprocmask (Bug#9010).
1960 sigprocmask is portable only for single-threaded applications, and
1961 Emacs can be multi-threaded when it uses GTK.
1962 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1964 * callproc.c (Fcall_process):
1965 * process.c (create_process):
1966 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1967 Use pthread_sigmask, not sigprocmask.
1969 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1971 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1972 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1975 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1977 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1978 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1979 (xg_hide_tooltip): Fix comment.
1981 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1982 in registerServicesMenuSendTypes.
1983 (validRequestorForSendType): Don't check ns_return_types.
1985 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1988 2011-07-08 Jason Rumney <jasonr@gnu.org>
1990 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1991 frame struct members of non-existent frames (Bug#6284).
1993 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1995 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1996 variable firstTime not needed on OSX >= 10.6.
1997 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1998 >= 10.5. Use setKnobProportion, setDoubleValue.
2000 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2001 (MAC_OS_X_VERSION_10_5): Define if not defined.
2002 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2003 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2004 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2006 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2007 cString and lossyCString on OSX >= 10.4
2009 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2010 sizeToFit on OSX >= 10.2.
2012 * nsimage.m (allocInitFromFile): Don't use deprecated method
2013 bestRepresentationForDevice on OSX >= 10.6.
2015 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2018 * emacs.c: Declare unexec_init_emacs_zone.
2020 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2022 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2024 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2025 on svcsMenu (Bug#8842).
2027 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2029 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2031 * nsterm.m (QUTF8_STRING): Declare.
2032 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2033 (validRequestorForSendType): Return type is (id).
2034 Change indexOfObjectIdenticalTo to indexOfObject.
2035 Check if we have local selection before returning self (Bug#8842).
2036 (writeSelectionToPasteboard): Put local selection into paste board
2037 if we have a local selection (Bug#8842).
2038 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2040 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2041 (ns_get_local_selection): Declare.
2043 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2045 * keymap.c (describe_map_tree): Don't insert a double newline at
2046 the end of the buffer (bug#1169) and return whether we inserted
2049 * callint.c (Fcall_interactively): Change "reading args" to
2050 "providing args" to try to clarify what it does (bug#1010).
2052 2011-07-07 Kenichi Handa <handa@m17n.org>
2054 * composite.c (composition_compute_stop_pos): Ignore a static
2055 composition starting before CHARPOS (Bug#8915).
2057 * xdisp.c (handle_composition_prop): Likewise.
2059 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2061 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2064 2011-07-07 Kenichi Handa <handa@m17n.org>
2066 * character.h (unicode_category_t): New enum type.
2068 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2069 (Qchar_code_property_table): New variable.
2070 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2071 (UNIPROP_COMPRESSED_FORM_P): New macros.
2072 (char_table_ascii): Uncompress the compressed values.
2073 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2074 Uncompress the compressed values.
2075 (sub_char_table_ref_and_range): Likewise.
2076 (char_table_ref_and_range): Uncompress the compressed values.
2077 (sub_char_table_set): New arg is_uniprop. Callers changed.
2078 Uncompress the compressed values.
2079 (sub_char_table_set_range): Args changed. Callers changed.
2080 (char_table_set_range): Adjuted for the above change.
2081 (map_sub_char_table): Delete args default_val and parent. Add arg
2082 top. Give decoded values to a Lisp function.
2083 (map_char_table): Adjust for the above change. Give decoded
2084 values to a Lisp function. Gcpro more variables.
2085 (uniprop_table_uncompress)
2086 (uniprop_decode_value_run_length): New functions.
2087 (uniprop_decoder, uniprop_decoder_count): New variables.
2088 (uniprop_get_decoder, uniprop_encode_value_character)
2089 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2091 (uniprop_encoder, uniprop_encoder_count): New variables.
2092 (uniprop_get_encoder, uniprop_table)
2093 (Funicode_property_table_internal, Fget_unicode_property_internal)
2094 (Fput_unicode_property_internal): New functions.
2095 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2096 Sunicode_property_table_internal, Sget_unicode_property_internal,
2097 and Sput_unicode_property_internal. Defvar_lisp
2098 char-code-property-alist.
2100 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2101 Vunicode_category_table.
2103 * font.c (font_range): Adjust for the change of
2104 Vunicode_category_table.
2106 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2108 * m/iris4d.h: Remove file, move contents ...
2109 * s/irix6-5.h: ... here.
2111 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2113 Remove unportable assumption about struct layout (Bug#8884).
2114 * alloc.c (mark_buffer):
2115 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2116 (clone_per_buffer_values): Don't assume that
2117 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2118 This isn't true in general, and it's particularly not true
2119 if Emacs is configured with --with-wide-int.
2120 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2121 New macros, used in the buffer.c change.
2123 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2125 * xsettings.c: Use both GConf and GSettings if both are available.
2126 (store_config_changed_event): Add comment.
2127 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2128 (store_tool_bar_style_changed): New functions.
2129 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2130 (struct xsettings): Move font inside HAVE_XFT.
2131 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2132 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2133 Move inside HAVE_XFT.
2134 (something_changed_gsettingsCB): Rename from something_changedCB.
2135 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2137 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2138 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2139 (something_changed_gconfCB): Rename from something_changedCB.
2140 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2141 (parse_settings): Move check for font inside HAVE_XFT.
2142 (read_settings, apply_xft_settings): Add comment.
2143 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2144 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2145 call store_font_name_changed.
2146 (xft_settings_event): Add comment.
2147 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2148 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2149 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2150 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2151 (xsettings_initialize): Call init_gsettings last.
2152 (xsettings_get_system_font, xsettings_get_system_normal_font):
2155 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2157 Random fixes. E.g., (random) never returned negative values.
2158 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2159 subseconds part to the entropy, as that's a bit more random.
2160 Prefer signed to unsigned, since the signedness doesn't matter and
2161 in general we prefer signed. When given a limit, use a
2162 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2163 latter isn't right if USE_2_TAGS_FOR_INTS.
2164 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2165 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2167 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2169 * textprop.c (text_property_stickiness):
2170 Obey Vtext_property_default_nonsticky.
2171 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2172 * w32fns.c (syms_of_w32fns):
2173 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2175 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2177 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2178 This is more efficient than Ffile_directory_p and avoids a minor race.
2180 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2182 * buffer.c (Foverlay_put): Say what the return value is
2185 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2186 is a directory before asking whether to use the file name
2188 (barf_or_query_if_file_exists): Make the "File is a directory"
2189 error be more correct.
2191 * fns.c (Frequire): Remove the mention of the .gz files, since
2192 that's installation-specific, but keep the mention of
2193 `get-load-suffixes'.
2195 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2197 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2198 Report string overflow if the output is too long.
2200 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2202 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2203 (syms_of_gnutls): Remove duplicate DEFSYM for
2204 Qgnutls_bootprop_verify_hostname_error, an error for
2205 Qgnutls_bootprop_verify_error (which is no longer used).
2207 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2208 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2209 Also (re)move comments that are misplaced or no longer relevant.
2211 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2213 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2215 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2217 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2218 and background color parameters if they have been changed.
2220 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2222 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2224 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2226 * xsettings.c (SYSTEM_FONT): Define only when used.
2227 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2229 * keymap.c (access_keymap_1): Now static.
2231 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2233 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2234 leave any prefix arg for the up event (Bug#1586).
2236 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2238 * lread.c (syms_of_lread): Mention single symbols defined by
2239 `defvar' or `defconst' (bug#7154).
2241 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2242 (Frequire): Mention get-load-suffixes.
2244 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2246 * window.h (window): Remove clone_number slot.
2247 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2249 (make_parent_window, make_window, saved_window)
2250 (Fset_window_configuration, save_window_save): Don't deal with
2252 * buffer.c (Qclone_number): Remove declaration.
2253 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2255 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2257 Add multiple inheritance to keymaps.
2258 * keymap.c (Fmake_composed_keymap): New function.
2259 (Fset_keymap_parent): Simplify.
2260 (fix_submap_inheritance): Remove.
2261 (access_keymap_1): New function extracted from access_keymap to handle
2262 embedded parents and handle lists of maps.
2263 (access_keymap): Use it.
2264 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2265 (Fcopy_keymap): Handle embedded parents.
2266 (Fcommand_remapping, define_as_prefix): Simplify.
2267 (Fkey_binding): Simplify.
2268 (syms_of_keymap): Move minibuffer-local-completion-map,
2269 minibuffer-local-filename-completion-map,
2270 minibuffer-local-must-match-map, and
2271 minibuffer-local-filename-must-match-map to Elisp.
2272 (syms_of_keymap): Defsubr make-composed-keymap.
2273 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2274 (parse_menu_item): Trivial simplification.
2276 2011-07-01 Glenn Morris <rgm@gnu.org>
2278 * Makefile.in (SETTINGS_LIBS): Fix typo.
2280 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2282 * coding.c (Fencode_coding_string): Record the last coding system
2283 used, as the function doc string says (bug#8738).
2285 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2287 * xsettings.c (store_monospaced_changed): Take new font as arg and
2288 check for change against current_mono_font.
2289 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2290 (emacs_settings_constructor, emacs_settings_get_property)
2291 (emacs_settings_set_property, emacs_settings_class_init)
2292 (emacs_settings_init, gsettings_obj): Remove.
2293 (something_changedCB): New function for HAVE_GSETTINGS.
2294 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2295 with value as argument.
2296 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2297 g_settings_new (Bug#8967). Do not create gsettings_obj.
2298 Remove calls to g_settings_bind. Connect something_changedCB to
2301 * xgselect.c: Add defined (HAVE_GSETTINGS).
2302 (xgselect_initialize): Ditto.
2304 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2305 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2308 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2310 * eval.c (struct backtrace): Simplify and port the data structure.
2311 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2312 signed bit field, as this assumption is not portable and it makes
2313 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2314 "char debug_on_exit : 1" as this is not portable either; instead,
2315 use the portable "unsigned int debug_on_exit : 1". Remove unused
2316 member evalargs. Remove obsolete comments about cc bombing out.
2318 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2320 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2321 Let HAVE_GSETTINGS override HAVE_GCONF.
2322 (store_monospaced_changed): New function.
2323 (EMACS_SETTINGS): A new type derived from GObject to handle
2324 GSettings notifications.
2325 (emacs_settings_constructor, emacs_settings_get_property)
2326 (emacs_settings_set_property, emacs_settings_class_init):
2328 (gsettings_client, gsettings_obj): New variables.
2329 (GSETTINGS_SCHEMA): New define.
2330 (something_changedCB): Call store_monospaced_changed.
2331 (init_gsettings): New function.
2332 (xsettings_initialize): Call init_gsettings.
2333 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2336 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2339 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2341 * window.c (resize_root_window, grow_mini_window)
2342 (shrink_mini_window): Rename Qresize_root_window to
2343 Qwindow_resize_root_window and Qresize_root_window_vertically to
2344 Qwindow_resize_root_window_vertically.
2346 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2348 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2350 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2352 * makefile.w32-in: Redesign dependencies so they reflect more
2353 clearly which files are directly included by each source file,
2354 and not through other includes.
2356 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2358 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2359 (sort_overlays, overlay_strings): When an overlay's clone number
2360 matches the window's clone number process the overlay even if
2361 the overlay's window property doesn't match the current window.
2363 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2364 (Fwindow_hchild): Rename to Fwindow_left_child.
2365 (Fwindow_next): Rename to Fwindow_next_sibling.
2366 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2367 (resize_window_check): Rename to window_resize_check.
2368 (resize_window_apply): Rename to window_resize_apply.
2369 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2370 (Fdelete_other_windows_internal, resize_frame_windows)
2371 (Fsplit_window_internal, Fdelete_window_internal)
2372 (grow_mini_window, shrink_mini_window)
2373 (Fresize_mini_window_internal): Fix callers accordingly.
2375 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2377 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2378 (emacs_fixed_set_min_size): Remove.
2379 (emacs_fixed_new): Take frame as argument.
2381 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2382 (_EmacsFixedPrivate): Remove minwidth/height.
2383 Add struct frame *f.
2384 (emacs_fixed_init): Initialize priv->f.
2385 (get_parent_class, emacs_fixed_set_min_size): Remove.
2386 (emacs_fixed_new): Set priv->f to argument.
2387 (emacs_fixed_get_preferred_width)
2388 (emacs_fixed_get_preferred_height): Use min_width/height from
2389 frames size_hint to set minimum and natural (Bug#8919).
2390 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2391 and use min_width/height from frames size_hint to set
2392 min_width/height (Bug#8919).
2394 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2395 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2398 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2400 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2401 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2404 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2406 * process.c (wait_reading_process_output): Bypass select if
2407 waiting for a cell while ignoring keyboard input, and input is
2408 pending. Suggested by Jan Djärv (Bug#8869).
2410 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2412 Use gnulib's dup2 module instead of rolling our own.
2413 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2415 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2417 * dispnew.c (scrolling_window): Before scrolling, turn off a
2418 mouse-highlight in the window being scrolled.
2420 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2422 Move DEFSYM to lisp.h and use everywhere.
2424 * character.h (DEFSYM): Move declaration...
2425 * lisp.h (DEFSYM): ...here.
2431 * w32select.c: Don't include character.h.
2433 * alloc.c (syms_of_alloc):
2434 * buffer.c (syms_of_buffer):
2435 * bytecode.c (syms_of_bytecode):
2436 * callint.c (syms_of_callint):
2437 * casefiddle.c (syms_of_casefiddle):
2438 * casetab.c (init_casetab_once):
2439 * category.c (init_category_once, syms_of_category):
2440 * ccl.c (syms_of_ccl):
2441 * cmds.c (syms_of_cmds):
2442 * composite.c (syms_of_composite):
2443 * dbusbind.c (syms_of_dbusbind):
2444 * dired.c (syms_of_dired):
2445 * dispnew.c (syms_of_display):
2446 * doc.c (syms_of_doc):
2447 * editfns.c (syms_of_editfns):
2448 * emacs.c (syms_of_emacs):
2449 * eval.c (syms_of_eval):
2450 * fileio.c (syms_of_fileio):
2451 * fns.c (syms_of_fns):
2452 * frame.c (syms_of_frame):
2453 * fringe.c (syms_of_fringe):
2454 * insdel.c (syms_of_insdel):
2455 * keymap.c (syms_of_keymap):
2456 * lread.c (init_obarray, syms_of_lread):
2457 * macros.c (syms_of_macros):
2458 * msdos.c (syms_of_msdos):
2459 * print.c (syms_of_print):
2460 * process.c (syms_of_process):
2461 * search.c (syms_of_search):
2462 * sound.c (syms_of_sound):
2463 * syntax.c (init_syntax_once, syms_of_syntax):
2464 * terminal.c (syms_of_terminal):
2465 * textprop.c (syms_of_textprop):
2466 * undo.c (syms_of_undo):
2467 * w32.c (globals_of_w32):
2468 * window.c (syms_of_window):
2469 * xdisp.c (syms_of_xdisp):
2470 * xfaces.c (syms_of_xfaces):
2471 * xfns.c (syms_of_xfns):
2472 * xmenu.c (syms_of_xmenu):
2473 * xsettings.c (syms_of_xsettings):
2474 * xterm.c (syms_of_xterm): Use DEFSYM.
2476 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2478 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2480 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2482 Integer and buffer overflow fixes (Bug#8873).
2484 * print.c (printchar, strout): Check for string overflow.
2485 (PRINTPREPARE, printchar, strout):
2486 Don't set size unless allocation succeeds.
2488 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2489 for sizes. Check for string overflow more accurately.
2490 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2492 * macros.c: Integer and buffer overflow fixes.
2493 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2494 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2495 Use ptrdiff_t, not int, for sizes.
2496 Don't increment bufsize until after realloc succeeds.
2497 Check for size-calculation overflow.
2498 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2500 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2502 * lread.c: Integer overflow fixes.
2503 (read_integer): Radix is now EMACS_INT, not int,
2504 to improve quality of diagnostics for out-of-range radices.
2505 Calculate buffer size correctly for out-of-range radices.
2506 (read1): Check for integer overflow in radices, and in
2507 read-circle numbers.
2508 (read_escape): Avoid int overflow.
2509 (Fload, openp, read_buffer_size, read1)
2510 (substitute_object_recurse, read_vector, read_list, map_obarray):
2511 Use ptrdiff_t, not int, for sizes.
2512 (read1): Use EMACS_INT, not int, for sizes.
2513 Check for size overflow.
2515 * image.c (cache_image): Check for size arithmetic overflow.
2517 * lread.c: Integer overflow issues.
2518 (saved_doc_string_size, saved_doc_string_length)
2519 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2520 Now ptrdiff_t, not int.
2521 (read1): Don't assume doc string length fits in int. Check for
2522 out-of-range doc string lengths.
2523 (read_list): Don't assume file position fits in int.
2524 (read_escape): Check for hex character overflow.
2526 2011-06-22 Leo Liu <sdl.web@gmail.com>
2528 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2529 Move to minibuffer.el.
2531 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2533 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2534 The following patches are for when GLYPH_DEBUG && !XASSERT.
2535 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2536 * dispnew.c (flush_stdout):
2537 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2538 Mark as externally visible.
2539 * dispnew.c (check_window_matrix_pointers): Now static.
2540 * dispnew.c (window_to_frame_vpos):
2541 * xfns.c (unwind_create_frame):
2542 * xterm.c (x_check_font): Remove unused local.
2543 * scroll.c (CHECK_BOUNDS):
2544 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2545 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2546 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2547 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2548 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2550 (debug_method_add): Use va_list and vsprintf rather than relying
2551 on undefined behavior with wrong number of arguments.
2552 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2553 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2554 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2555 since we're not interested in debugging glyphs with old libraries.
2556 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2557 GCC 4.6.0's static checking.
2559 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2561 Integer overflow and signedness fixes (Bug#8873).
2562 A few related buffer overrun fixes, too.
2564 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2566 * dispextern.h (struct face.stipple):
2567 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2568 (x_bitmap_mask, x_allocate_bitmap_record)
2569 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2570 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2571 (x_create_bitmap_from_xpm_data):
2572 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2573 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2575 * xfaces.c (load_pixmap):
2576 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2577 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2578 (.bitmaps_last, struct x_output.icon_bitmap):
2579 Use ptrdiff_t, not int, for bitmap indexes.
2580 (x_allocate_bitmap_record): Check for size overflow.
2581 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2583 Use ptrdiff_t, not int, for overlay counts.
2584 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2585 * editfns.c (overlays_around, get_pos_property):
2586 * textprop.c (get_char_property_and_overlay):
2587 * xdisp.c (next_overlay_change, note_mouse_highlight):
2588 * xfaces.c (face_at_buffer_position):
2589 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2590 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2591 (Fnext_overlay_change, Fprevious_overlay_change)
2592 (mouse_face_overlay_overlaps, Foverlays_in):
2593 Use ptrdiff_t, not int, for sizes.
2594 (overlays_at, overlays_in): Check for size-calculation overflow.
2596 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2598 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2599 (x_session_initialize): Do not assume string length fits in int.
2601 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2602 This is unlikely, but can occur if DPI is outlandish.
2604 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2605 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2607 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2608 * xrdb.c (magic_file_p, search_magic_path):
2609 Omit last arg SUFFIX; it was always 0. All callers changed.
2610 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2612 * xfont.c (xfont_match): Avoid need for strlen.
2614 * xfns.c: Don't assume strlen fits in int.
2615 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2617 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2618 not unsigned long, as we prefer signed integers. All callers changed.
2619 Detect integer overflow in repeat count.
2620 (message_dolog): Don't assume print length fits in 39 bytes.
2621 (display_mode_element): Don't assume strlen fits in int.
2623 * termcap.c: Don't assume sizes fit in int and never overflow.
2624 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2625 (gobble_line): Check for size-calculation overflow.
2627 * minibuf.c (Fread_buffer):
2628 * lread.c (intern, intern_c_string):
2629 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2630 Don't assume string length fits in int.
2632 * keyboard.c (parse_tool_bar_item):
2633 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2635 * font.c: Don't assume string length fits in int.
2636 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2637 Use ptrdiff_t, not int.
2638 (font_intern_prop): Don't assume string length fits in int.
2639 Don't assume integer property fits in fixnum.
2640 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2642 * filelock.c: Fix some buffer overrun and integer overflow issues.
2643 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2644 Reformulate so as not to need the command string.
2645 Invoke gzip -cd rather than gunzip, as it's more portable.
2646 (lock_info_type, lock_file_1, lock_file):
2647 Don't assume pid_t and time_t fit in unsigned long.
2648 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2649 (current_lock_owner): Prefer signed type for sizes.
2650 Use memcpy, not strncpy, where memcpy is what is really wanted.
2651 Don't assume (via atoi) that time_t and pid_t fit in int.
2652 Check for time_t and/or pid_t out of range, e.g., via a network share.
2653 Don't alloca where an auto var works fine.
2655 * fileio.c: Fix some integer overflow issues.
2656 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2657 Don't assume string length fits in int.
2658 (directory_file_name): Don't assume string length fits in long.
2659 (make_temp_name): Don't assume pid fits in int, or that its print
2660 length is less than 20.
2662 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2664 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2666 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2668 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2669 We prefer signed integers, even for size calculations.
2671 * emacs.c: Don't assume string length fits in 'int'.
2672 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2673 (main): Don't invoke strlen when not needed.
2675 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2676 (XD_DEBUG_MESSAGE): Don't waste a byte.
2678 * callproc.c (getenv_internal_1, getenv_internal)
2680 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2682 * lread.c (invalid_syntax): Omit length argument.
2683 All uses changed. This doesn't fix a bug, but it simplifies the
2684 code away from its former Hollerith-constant appearance, and it's
2685 one less 'int' to worry about when looking at integer-overflow issues.
2686 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2688 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2689 This didn't break anything, but it didn't help either.
2690 It's confusing to put a bogus integer in a place where the actual
2691 value does not matter.
2692 (LIST_END_P): Remove unused macro and its bogus comment.
2693 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2695 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2696 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2698 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2699 We prefer signed types, and the value cannot exceed the EMACS_INT
2700 range anyway (because otherwise the length would not be representable).
2701 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2702 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2703 This avoids a GCC warning when WIDE_EMACS_INT.
2705 * indent.c (sane_tab_width): New function.
2706 (current_column, scan_for_column, Findent_to, position_indentation)
2707 (compute_motion): Use it. This is just for clarity.
2708 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2710 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2712 * lisp.h (lint_assume): New macro.
2713 * composite.c (composition_gstring_put_cache):
2714 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2716 * editfns.c, insdel.c:
2717 Omit unnecessary forward decls, to simplify future changes.
2719 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2721 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2723 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2724 Use much-faster test for byte-length change.
2725 Don't assume string byte-length fits in 'int'.
2726 Check that character arg fits in 'int'.
2727 (mapcar1): Declare byte as byte, for clarity.
2729 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2731 * fns.c (concat): Catch string overflow earlier.
2732 Do not rely on integer wraparound.
2734 * dispextern.h (struct it.overlay_strings_charpos)
2735 (struct it.selective): Now EMACS_INT, not int.
2736 * xdisp.c (forward_to_next_line_start)
2737 (back_to_previous_visible_line_start)
2738 (reseat_at_next_visible_line_start, next_element_from_buffer):
2739 Don't arbitrarily truncate the value of 'selective' to int.
2741 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2743 * composite.c: Don't truncate sizes to 'int'.
2744 (composition_gstring_p, composition_reseat_it)
2745 (composition_adjust_point): Use EMACS_INT, not int.
2746 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2747 not EMACS_UINT, for indexes.
2749 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2751 * buffer.c: Include <verify.h>.
2752 (struct sortvec.priority, struct sortstr.priority):
2753 Now EMACS_INT, not int.
2754 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2755 (struct sortstr.size, record_overlay_string)
2756 (struct sortstrlist.size, struct sortlist.used):
2757 Don't truncate size to int.
2758 (record_overlay_string): Check for size-calculation overflow.
2759 (init_buffer_once): Check at compile-time, not run-time.
2761 2011-06-22 Jim Meyering <meyering@redhat.com>
2763 Don't leak an XBM-image-sized buffer
2764 * image.c (xbm_load): Free the image buffer after using it.
2766 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2769 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2770 that Sun C diagnosed.
2771 * fns.c (secure_hash): Fix pointer signedness issue.
2772 * intervals.c (static_offset_intervals): New function.
2773 (offset_intervals): Use it.
2775 2011-06-21 Leo Liu <sdl.web@gmail.com>
2778 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2781 * fns.c (secure_hash): Rename from crypto_hash_function and change
2782 the first arg to accept symbols.
2783 (Fsecure_hash): New primitive.
2784 (syms_of_fns): New symbols.
2786 2011-06-20 Deniz Dogan <deniz@dogan.se>
2788 * process.c (Fset_process_buffer): Clarify return value in
2791 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2793 * dispnew.c (add_window_display_history): Use BVAR.
2795 * xdisp.c (debug_method_add): Use BVAR.
2796 (check_window_end, dump_glyph_matrix, dump_glyph)
2797 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2799 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2802 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2803 check till after the cache is created in init_frame_faces.
2805 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2807 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2809 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2811 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2812 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2813 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2815 Improve buffer-overflow checking (Bug#8873).
2816 * fileio.c (Finsert_file_contents):
2817 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2818 Remove the old (too-loose) buffer overflow checks.
2819 They weren't needed, since make_gap checks for buffer overflow.
2820 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2821 The old code merely checked for Emacs fixnum overflow, and relied
2822 on undefined (wraparound) behavior. The new code avoids undefined
2823 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2825 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2826 Tune. Don't use wider integers than needed. Don't use alloca.
2827 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2829 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2831 * insdel.c, lisp.h (buffer_overflow): New function.
2832 (insert_from_buffer_1, replace_range, replace_range_2):
2833 * insdel.c (make_gap_larger):
2834 * editfns.c (Finsert_char):
2835 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2837 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2839 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2841 Integer overflow and signedness fixes (Bug#8873).
2843 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2844 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2846 * fileio.c: Don't assume EMACS_INT fits in off_t.
2847 (emacs_lseek): New static function.
2848 (Finsert_file_contents, Fwrite_region): Use it.
2849 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2851 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2853 * fns.c: Don't overflow int when computing a list length.
2854 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2855 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2856 truncation on 64-bit hosts. Check for QUIT every
2857 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2858 faster and is responsive enough.
2859 (Flength): Report an error instead of overflowing an integer.
2860 (Fsafe_length): Return a float if the value is not representable
2861 as a fixnum. This shouldn't happen except in contrived situations.
2862 (Fnthcdr, Fsort): Don't assume list length fits in int.
2863 (Fcopy_sequence): Don't assume vector length fits in int.
2865 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2866 (header_size, word_size): New constants.
2867 (allocate_vectorlike): Don't check size overflow here.
2868 (allocate_vector): Check it here instead, since this is the only
2869 caller of allocate_vectorlike that could cause overflow.
2870 Check that the new vector's length is representable as a fixnum.
2872 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2873 The previous code was bogus. For example, next_almost_prime (32)
2874 returned 39, which is undesirable as it is a multiple of 3; and
2875 next_almost_prime (24) returned 25, which is a multiple of 5 so
2876 why was the code bothering to check for multiples of 7?
2878 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2880 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2882 Variadic C functions now count arguments with ptrdiff_t.
2883 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2884 Back then I didn't know that the Emacs coding style prefers signed int.
2885 Also, in the meantime I found a few more instances where arguments
2886 were being counted with int, which may truncate counts on 64-bit
2887 machines, or EMACS_INT, which may be unnecessarily wide.
2888 * lisp.h (struct Lisp_Subr.function.aMANY)
2889 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2890 Arg counts are now ptrdiff_t, not size_t.
2891 All variadic functions and their callers changed accordingly.
2892 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2893 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2894 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2895 * callint.c (Fcall_interactively): Check arg count for overflow,
2896 to avoid potential buffer overrun. Use signed char, not 'int',
2897 for 'varies' array, so that we needn't bother to check its size
2898 calculation for overflow.
2899 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2900 * eval.c (apply_lambda):
2901 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2902 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2903 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2905 * callint.c (Fcall_interactively): Don't use index var as event count.
2907 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2908 * mem-limits.h (SIZE): Remove; no longer used.
2910 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2912 Remove unnecessary casts.
2913 * xterm.c (x_term_init):
2914 * xfns.c (x_set_border_pixel):
2915 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2916 These aren't needed now that we assume ANSI C.
2918 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2919 It's more likely to cause problems (due to unsigned overflow)
2922 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2924 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2926 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2928 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2930 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2932 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2934 GLYPH_CODE_FACE returns EMACS_INT, not int.
2935 * dispextern.h (merge_faces):
2936 * xfaces.c (merge_faces):
2937 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2938 Don't assume EMACS_INT fits in int.
2940 * character.h (CHAR_VALID_P): Remove unused parameter.
2941 * fontset.c, lisp.h, xdisp.c: All uses changed.
2943 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2945 * fns.c (concat): Minor tuning based on overflow analysis.
2946 This doesn't fix any bugs. Use int to hold character, instead
2947 of constantly refetching from Emacs object. Use XFASTINT, not
2948 XINT, for value known to be a character. Don't bother comparing
2949 a single byte to 0400, as it's always less.
2951 * floatfns.c (Fexpt):
2952 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2954 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2957 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2959 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2960 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2961 incorrectly succeed when S was a string, because 4294967386 was
2962 truncated before it was used.
2964 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2965 Otherwise, an out-of-range integer could cause undefined behavior
2968 * composite.c: Use int, not EMACS_INT, for characters.
2969 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2970 EMACS_INT, for values that are known to be in character range.
2971 This doesn't fix any bugs but is the usual style inside Emacs and
2972 may generate better code on 32-bit machines.
2974 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2975 This is for reasons similar to the recent CHAR_STRING fix.
2976 * charset.c (Fencode_char): Check that character arg is actually
2977 a character. Pass an int to ENCODE_CHAR.
2978 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2979 wider than 'int', as a compile-time check to prevent future regressions
2982 * character.c (char_string): Remove unnecessary casts.
2984 Make sure a 64-bit char is never passed to CHAR_STRING.
2985 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2986 by silently ignoring the top 32 bits, allowing some values
2987 that were far too large to be valid characters.
2988 * character.h: Include <verify.h>.
2989 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2990 arguments are no wider than unsigned, as a compile-time check
2991 to prevent future regressions in this area.
2993 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2994 (Fsubst_char_in_region):
2996 * xdisp.c (decode_mode_spec_coding):
2997 Adjust to CHAR_STRING's new requirement.
2998 * editfns.c (Finsert_char, Fsubst_char_in_region):
2999 * fns.c (concat): Check that character args are actually
3000 characters. Without this test, these functions did the wrong
3001 thing with wildly out-of-range values on 64-bit hosts.
3003 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3004 These casts should not be needed on 32-bit hosts, either.
3005 * keyboard.c (read_char):
3006 * lread.c (Fload): Remove casts to unsigned.
3008 * lisp.h (UNSIGNED_CMP): New macro.
3009 This fixes comparison bugs on 64-bit hosts.
3010 (ASCII_CHAR_P): Use it.
3011 * casefiddle.c (casify_object):
3012 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3013 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3014 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3015 * dispextern.h (FACE_FROM_ID):
3016 * keyboard.c (read_char): Use UNSIGNED_CMP.
3018 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3019 not to EMACS_INT, to avoid GCC warning.
3021 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3023 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3024 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3025 isn't needed on 32-bit machines.
3027 * buffer.c (Fgenerate_new_buffer_name):
3028 Use EMACS_INT for count, not int.
3029 (advance_to_char_boundary): Return EMACS_INT, not int.
3031 * data.c (Qcompiled_function): Now static.
3033 * window.c (window_body_lines): Now static.
3035 * image.c (gif_load): Rename local to avoid shadowing.
3037 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3038 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3039 * alloc.c (make_save_value): Integer argument is now of type
3041 (mark_object): Use ptrdiff_t, not int.
3042 * lisp.h (pD): New macro.
3043 * print.c (print_object): Use it.
3045 * alloc.c: Use EMACS_INT, not int, to count objects.
3046 (total_conses, total_markers, total_symbols, total_vector_size)
3047 (total_free_conses, total_free_markers, total_free_symbols)
3048 (total_free_floats, total_floats, total_free_intervals)
3049 (total_intervals, total_strings, total_free_strings):
3050 Now EMACS_INT, not int. All uses changed.
3051 (Fgarbage_collect): Compute overall total using a double, so that
3052 integer overflow is less likely to be a problem. Check for overflow
3053 when converting back to an integer.
3054 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3055 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3056 These were 'int' variables that could overflow on 64-bit hosts;
3057 they were never used, so remove them instead of repairing them.
3058 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3059 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3060 Previously, this ceilinged at INT_MAX, but that doesn't work on
3062 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3064 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3065 (allocate_vectorlike): Check for ptrdiff_t overflow.
3066 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3067 when a (possibly-narrower) signed value would do just as well.
3068 We prefer using signed arithmetic, to avoid comparison confusion.
3070 * alloc.c: Catch some string size overflows that we were missing.
3071 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3072 for convenience in STRING_BYTES_MAX.
3073 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3074 The definition here is exact; the one in lisp.h was approximate.
3075 (allocate_string_data): Check for string overflow. This catches
3076 some instances we weren't catching before. Also, it catches
3077 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3078 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3079 and ptrdiff_t and EMACS_INT are both 64 bits.
3081 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3082 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3083 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3085 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3087 * alloc.c (Fmake_string): Check for out-of-range init.
3089 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3091 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3093 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3095 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3096 xg_get_default_scrollbar_width.
3098 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3099 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3100 (style_changed_cb): Call update_theme_scrollbar_width and call
3101 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3102 all frames (Bug#8505).
3103 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3104 Call gtk_window_set_resizable if HAVE_GTK3.
3105 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3106 and height if HAVE_GTK3 (Bug#8505).
3107 (scroll_bar_width_for_theme): New variable.
3108 (update_theme_scrollbar_width): New function.
3109 (xg_get_default_scrollbar_width): Move code to
3110 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3111 (xg_initialize): Call update_theme_scrollbar_width.
3113 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3115 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3117 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3119 * frame.c (make_frame): Call other_buffer_safely instead of
3122 * window.c (temp_output_buffer_show): Call display_buffer with
3123 second argument Vtemp_buffer_show_specifiers and reset latter
3124 immediately after the call.
3125 (Vtemp_buffer_show_specifiers): New variable.
3126 (auto_window_vscroll_p, next_screen_context_lines)
3127 (Vscroll_preserve_screen_position): Remove leading asterisks from
3130 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3132 Fix minor problems found by GCC 4.6.0 static checking.
3133 * buffer.c (Qclone_number): Remove for now, as it's unused.
3134 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3135 (record_buffer): Remove unused local.
3136 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3137 (set_frame_buffer_list): Remove; unused.
3138 * frame.h (other_visible_frames): Remove decl.
3139 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3140 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3141 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3143 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3144 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3145 Define only if HAVE_GPM.
3146 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3147 (update_hints_inhibit): Remove; never set. All uses removed.
3148 * widgetprv.h (emacsFrameClassRec): Remove decl.
3149 * window.c (delete_deletable_window): Now returns void, since it
3150 wasn't returning anything.
3151 (compare_window_configurations): Remove unused locals.
3152 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3153 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3154 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3155 the same widths as pointers. This follows up on the 2011-05-06 patch.
3156 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3157 * xterm.h: Likewise.
3158 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3160 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3162 * makefile.w32-in: Update dependencies.
3163 (LISP_H): Add lib/intprops.h.
3165 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3167 * image.c (gif_load): Add animation frame delay to the metadata.
3168 (syms_of_image): Use DEFSYM. New symbol `delay'.
3170 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3172 * window.c (delete_deletable_window): Re-add.
3173 (Fset_window_configuration): Rewrite to handle dead buffers and
3174 consequently deletable windows.
3175 (window_tree, Fwindow_tree): Remove. Supply functionality in
3177 (compare_window_configurations): Simplify code.
3179 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3181 * image.c (imagemagick_load_image): Fix type mismatch.
3182 (Fimagemagick_types): Likewise.
3184 * window.h (replace_buffer_in_windows): Declare.
3186 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3188 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3189 Qclone_number. Remove external declaration of Qdelete_window.
3190 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3192 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3193 Run Qbuffer_list_update_hook if allowed.
3194 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3195 buffer list implementation.
3196 (other_buffer_safely): New function.
3197 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3198 calls to replace_buffer_in_windows and
3199 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3201 (record_buffer): Inhibit quitting and rewrite using quittable
3202 functions. Run Qbuffer_list_update_hook if allowed.
3203 (Frecord_buffer, Funrecord_buffer): New functions.
3204 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3205 Move switch-to-buffer to window.el.
3206 (bury-buffer): Move to window.el.
3207 (Vbuffer_list_update_hook): New variable.
3209 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3212 * window.h (resize_frame_windows): Move up in code.
3213 (Fwindow_frame): Remove EXFUN.
3214 (replace_buffer_in_all_windows): Remove prototype.
3215 (replace_buffer_in_windows_safely): Add prototype.
3217 * window.c: Declare Qdelete_window static again. Move down
3218 declaration of select_count.
3219 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3220 (Fother_window): Move to window.el.
3221 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3222 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3223 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3225 (replace_buffer_in_windows): Implement by calling
3226 Qreplace_buffer_in_windows.
3227 (replace_buffer_in_all_windows): Remove with some functionality
3228 moved into replace_buffer_in_windows_safely.
3229 (replace_buffer_in_windows_safely): New function.
3230 (select_window_norecord, select_frame_norecord): Move in front
3231 of run_window_configuration_change_hook. Remove now obsolete
3233 (Fset_window_buffer): Rewrite doc-string.
3234 Call Qrecord_window_buffer.
3235 (keys_of_window): Move binding for other-window to window.el.
3237 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3239 * dispextern.h (struct image): Replace data member, whose int_val
3240 and ptr_val fields were not used by anything, with a single
3243 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3244 (gif_clear_image, gif_load, imagemagick_load_image)
3245 (gs_clear_image, gs_load): Callers changed.
3247 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3249 * buffer.h: Include <time.h>, for time_t.
3250 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3252 Fix minor problems found by static checking.
3254 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3256 Make identifiers static if they are not used in other modules.
3257 * data.c (Qcompiled_function, Qframe, Qvector):
3258 * image.c (QimageMagick, Qsvg):
3259 * minibuf.c (Qmetadata):
3260 * window.c (resize_window_check, resize_root_window): Now static.
3261 * window.h (resize_window_check, resize_root_window): Remove decls.
3263 * window.c (window_deletion_count, delete_deletable_window):
3265 (window_body_lines): Now static.
3266 (Fdelete_other_windows_internal): Mark vars as initialized.
3267 Make sure 'resize_failed' is initialized.
3268 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3269 (resize_window_apply): Remove unused local.
3270 * window.h (delete_deletable_window): Remove decl.
3272 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3273 (imagemagick_load_image): Fix pointer signedness problem by changing
3274 last arg from unsigned char * to char *. All uses changed.
3275 Also, fix a local for similar reasons.
3276 Remove unused locals. Remove locals to avoid shadowing.
3277 (fn_rsvg_handle_free): Remove; unused.
3278 (svg_load, svg_load_image): Fix pointer signedness problem.
3279 (imagemagick_load_image): Don't use garbage pointer image_wand.
3281 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3283 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3285 * image.c (gif_load): Fix omitted cast error introduced by
3288 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3290 * window.h (resize_proportionally, orig_total_lines)
3291 (orig_top_line): Remove from window structure.
3292 (set_window_height, set_window_width, change_window_heights)
3293 (Fdelete_window): Remove prototypes.
3294 (resize_frame_windows): Remove duplicate declaration.
3296 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3298 * window.h (resize_frame_windows, resize_window_check)
3299 (delete_deletable_window, resize_root_window)
3300 (resize_frame_windows): Declare prototypes.
3302 * window.c (resize_window_apply): Make definition be "static" to
3303 match the prototype.
3305 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3307 * window.c: Remove declarations of Qwindow_size_fixed,
3308 window_min_size_1, window_min_size_2, window_min_size,
3309 size_window, window_fixed_size_p, enlarge_window, delete_window.
3310 Remove static from declaration of Qdelete_window, it's
3311 temporarily needed by Fbury_buffer.
3312 (replace_window): Don't assign orig_top_line and
3314 (Fdelete_window, delete_window): Remove. Window deletion is
3315 handled by window.el.
3316 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3317 Replace Fdelete_window calls with calls to Qdelete_window.
3318 (Fdelete_other_windows): Remove. Deleting other windows is
3319 handled by window.el.
3320 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3321 handled in window.el.
3322 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3323 Window minimum sizes are handled in window.el.
3324 (shrink_windows, size_window, set_window_height)
3325 (set_window_width, change_window_heights, window_height)
3326 (window_width, CURBEG, CURSIZE, enlarge_window)
3327 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3328 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3329 handled in window.el.
3330 (make_dummy_parent): Rename to make_parent_window and give it a
3331 second argument horflag.
3332 (make_window): Don't set resize_proportionally any more.
3333 (Fsplit_window): Remove. Windows are split in window.el.
3334 (save_restore_action, save_restore_orig_size)
3335 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3336 Resize mini windows in window.el.
3337 (grow_mini_window, shrink_mini_window): Implement by calling
3338 Qresize_root_window_vertically, resize_window_check and
3339 resize_window_apply.
3340 (saved_window, Fset_window_configuration, save_window_save):
3341 Do not handle orig_top_line, orig_total_lines, and
3342 resize_proportionally.
3343 (window_min_height, window_min_width): Move to window.el.
3344 (keys_of_window): Move bindings for delete-other-windows,
3345 split-window, delete-window and enlarge-window to window.el.
3347 * buffer.c: Temporarily extern Qdelete_window.
3348 (Fbury_buffer): Temporarily call Qdelete_window instead of
3349 Fdelete_window (Fbury_buffer will move to window.el soon).
3351 * frame.c (set_menu_bar_lines_1): Remove code handling
3352 orig_top_line and orig_total_lines.
3354 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3355 set_window_height but set heights directly.
3356 (change_frame_size_1): Use resize_frame_windows.
3358 * xdisp.c (init_xdisp): Don't use set_window_height but set
3361 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3362 Use resize_frame_windows instead of change_window_heights and run
3363 run_window_configuration_change_hook.
3365 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3366 instead of change_window_heights and run
3367 run_window_configuration_change_hook.
3369 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3371 * window.c (replace_window): Rename second argument REPLACEMENT to
3372 NEW. New third argument SETFLAG. Rewrite.
3373 (delete_window, make_dummy_parent): Call replace_window with
3375 (window_list_1): Move down in code.
3376 (run_window_configuration_change_hook): Move set_buffer part
3377 before select_frame_norecord part in order to unwind correctly.
3378 Rename count1 to count.
3379 (recombine_windows, delete_deletable_window, resize_root_window)
3380 (Fdelete_other_windows_internal)
3381 (Frun_window_configuration_change_hook, make_parent_window)
3382 (resize_window_check, resize_window_apply, Fresize_window_apply)
3383 (resize_frame_windows, Fsplit_window_internal)
3384 (Fdelete_window_internal, Fresize_mini_window_internal):
3386 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3388 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3390 * window.h (window): Add some new members to window structure -
3391 normal_lines, normal_cols, new_total, new_normal, clone_number,
3392 splits, nest, prev_buffers, next_buffers.
3393 (WINDOW_TOTAL_SIZE): Move here from window.c.
3394 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3396 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3398 (make_dummy_parent): Set new members of windows structure.
3399 (make_window): Move down in code. Handle new members of window
3401 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3402 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3403 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3404 (Fset_window_prev_buffers, Fwindow_next_buffers)
3405 (Fset_window_next_buffers, Fset_window_clone_number):
3407 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3408 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3410 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3411 Argument WINDOW can be now internal window too.
3412 (Fwindow_use_time): Move up in code.
3413 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3415 (Fset_window_configuration, saved_window)
3416 (Fcurrent_window_configuration, save_window_save): Handle new
3417 members of window structure.
3418 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3419 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3420 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3421 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3422 Qget_mru_window, Qresize_root_window,
3423 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3424 Qauto_buffer_name; staticpro them.
3426 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3428 * window.c (Fwindow_total_size, Fwindow_left_column)
3429 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3430 (Fwindow_list_1): New functions.
3431 (window_box_text_cols): Replace with window_body_cols.
3432 (Fwindow_width, Fscroll_left, Fscroll_right):
3433 Use window_body_cols instead of window_box_text_cols.
3434 (delete_window, Fset_window_configuration):
3435 Call delete_all_subwindows with window as argument.
3436 (delete_all_subwindows): Take a window as argument and not a
3438 (window_loop): Remove handling of GET_LRU_WINDOW and
3440 (Fget_lru_window, Fget_largest_window): Move to window.el.
3442 * window.h: Extern window_body_cols instead of
3443 window_box_text_cols. delete_all_subwindows now takes a
3444 Lisp_Object as argument.
3446 * indent.c (compute_motion, Fcompute_motion):
3447 Use window_body_cols instead of window_box_text_cols.
3449 * frame.c (delete_frame): Call delete_all_subwindows with root
3452 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3454 * fns.c (Fputhash): Document return value.
3456 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3458 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3460 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3462 Cons<->int and similar integer overflow fixes (Bug#8794).
3464 Check for overflow when converting integer to cons and back.
3465 * charset.c (Fdefine_charset_internal, Fdecode_char):
3466 Use cons_to_unsigned to catch overflow.
3467 (Fencode_char): Use INTEGER_TO_CONS.
3468 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3469 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3470 * data.c (long_to_cons, cons_to_long): Remove.
3471 (cons_to_unsigned, cons_to_signed): New functions.
3472 These signal an error for invalid or out-of-range values.
3473 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3474 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3475 * font.c (Ffont_variation_glyphs):
3476 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3477 * lisp.h: Include <intprops.h>.
3478 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3479 (cons_to_signed, cons_to_unsigned): New decls.
3480 (long_to_cons, cons_to_long): Remove decls.
3481 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3482 (Fprimitive_undo): Use CONS_TO_INTEGER.
3483 * xfns.c (Fx_window_property): Likewise.
3484 * xselect.c: Include <limits.h>.
3485 (x_own_selection, selection_data_to_lisp_data):
3486 Use INTEGER_TO_CONS.
3487 (x_handle_selection_request, x_handle_selection_clear)
3488 (x_get_foreign_selection, Fx_disown_selection_internal)
3489 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3490 (lisp_data_to_selection_data): Use cons_to_unsigned.
3491 (x_fill_property_data): Use cons_to_signed.
3492 Report values out of range.
3494 Check for buffer and string overflow more precisely.
3495 * buffer.h (BUF_BYTES_MAX): New macro.
3496 * lisp.h (STRING_BYTES_MAX): New macro.
3497 * alloc.c (Fmake_string):
3498 * character.c (string_escape_byte8):
3499 * coding.c (coding_alloc_by_realloc):
3500 * doprnt.c (doprnt):
3501 * editfns.c (Fformat):
3503 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3504 since they may not be the same number.
3505 * editfns.c (Finsert_char):
3506 * fileio.c (Finsert_file_contents):
3507 Likewise for BUF_BYTES_MAX.
3509 * image.c: Use ptrdiff_t, not int, for sizes.
3510 (slurp_file): Switch from int to ptrdiff_t.
3512 (slurp_file): Check that file size fits in both size_t (for
3513 malloc) and ptrdiff_t (for sanity and safety).
3515 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3516 if b->modtime has its maximal value.
3518 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3520 Don't assume time_t can fit into int.
3521 * buffer.h (struct buffer.modtime): Now time_t, not int.
3522 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3523 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3525 Minor fixes for signed vs unsigned integers.
3526 * character.h (MAYBE_UNIFY_CHAR):
3527 * charset.c (maybe_unify_char):
3528 * keyboard.c (read_char, reorder_modifiers):
3529 XINT -> XFASTINT, since the integer must be nonnegative.
3530 * ftfont.c (ftfont_spec_pattern):
3531 * keymap.c (access_keymap, silly_event_symbol_error):
3532 XUINT -> XFASTINT, since the integer must be nonnegative.
3533 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3534 since it makes no difference and we prefer signed.
3535 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3536 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3539 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3541 * window.h (Fwindow_frame): Declare.
3543 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3545 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3546 (SPARE_MEMORY): Always define.
3547 (LARGE_REQUEST): Remove.
3548 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3550 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3552 * lisp.h: Move EXFUNS for Fframe_root_window,
3553 Fframe_first_window and Fset_frame_selected_window to window.h.
3555 * window.h: Move EXFUNS for Fframe_root_window,
3556 Fframe_first_window and Fset_frame_selected_window here from
3559 * frame.c (Fwindow_frame, Fframe_first_window)
3560 (Fframe_root_window, Fframe_selected_window)
3561 (Fset_frame_selected_window): Move to window.c.
3562 (Factive_minibuffer_window): Move to minibuf.c.
3563 (Fother_visible_frames_p): New function.
3565 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3567 * window.c (decode_window, decode_any_window): Move up in code.
3568 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3569 (inhibit_frame_unsplittable): Remove unused variable.
3570 (Fwindow_buffer): Move up and rewrite doc-string.
3571 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3572 (Fwindow_prev): New functions.
3573 (Fwindow_frame): Move here from frame.c. Accept any window as
3575 (Fframe_root_window, Fframe_first_window)
3576 (Fframe_selected_window): Move here from frame.c. Accept frame
3577 or arbitrary window as argument. Update doc-strings.
3578 (Fminibuffer_window): Move up in code.
3579 (Fwindow_minibuffer_p): Move up in code and simplify.
3580 (Fset_frame_selected_window): Move here from frame.c.
3582 (Fselected_window, select_window, Fselect_window): Move up in
3583 code. Minor doc-string fixes.
3585 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3587 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3588 Do not assume that spare memory exists; that assumption is valid
3589 only if SYSTEM_MALLOC.
3590 (LARGE_REQUEST): New macro, so that the issue of large requests
3591 is separated from the issue of spare memory.
3593 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3595 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3598 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3600 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3603 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3605 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3607 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3609 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3610 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3612 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3614 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3616 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3618 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3619 (x_clipboard_manager_save): Add return value.
3620 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3622 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3623 Obey Vx_select_enable_clipboard_manager. Catch errors in
3624 x_clipboard_manager_save (Bug#8779).
3625 (Vx_select_enable_clipboard_manager): New variable.
3626 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3628 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3630 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3632 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3634 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3635 in the current matrix if keep_current_p is non-zero.
3637 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3639 * bidi.c (bidi_level_of_next_char): Fix last change.
3641 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3643 Support bidi reordering of text covered by display properties.
3645 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3646 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3647 (bidi_cache_search, bidi_cache_iterator_state)
3648 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3649 (bidi_level_of_next_char, bidi_move_to_visually_next):
3650 Support character positions inside a run of characters covered by a
3652 (bidi_paragraph_init, bidi_resolve_explicit_1)
3653 (bidi_level_of_next_char): Call bidi_fetch_char and
3654 bidi_fetch_char_advance instead of FETCH_CHAR and
3656 (bidi_init_it): Initialize new members.
3657 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3659 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3660 instead of using explicit *_CHAR codes.
3661 (bidi_resolve_explicit, bidi_resolve_weak):
3662 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3663 bidirectional text is supported only in multibyte buffers.
3664 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3665 it to initialize the frame_window_p member of struct bidi_it.
3666 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3667 (bidi_resolve_explicit, bidi_resolve_weak)
3668 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3669 bidi_it->nchars is non-positive.
3670 (bidi_level_of_next_char): Don't try to lookup the cache for the
3671 next/previous character if nothing is cached there yet, or if we
3672 were just reseat()'ed to a new position.
3674 * xdisp.c (set_cursor_from_row): Set start and stop points
3675 according to the row's direction when priming the loop that looks
3676 for the glyph on which to display cursor.
3677 (single_display_spec_intangible_p): Function deleted.
3678 (display_prop_intangible_p): Reimplement to call
3679 handle_display_spec instead of single_display_spec_intangible_p.
3680 Accept 3 additional arguments needed by handle_display_spec.
3681 This fixes incorrect cursor motion across display property with complex
3682 values: lists, `(when COND...)' forms, etc.
3683 (single_display_spec_string_p): Support property values that are
3684 lists with the argument STRING its top-level element.
3685 (display_prop_string_p): Fix the condition for processing a
3686 property that is a list to be consistent with handle_display_spec.
3687 (handle_display_spec): New function, refactored from the
3688 last portion of handle_display_prop.
3689 (compute_display_string_pos): Accept additional argument
3690 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3691 value of a `display' property is a "replacing spec".
3692 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3693 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3694 the display property, but just return a value indicating whether
3695 the display property will replace the characters it covers.
3696 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3697 frame_window_p members of struct bidi_it.
3698 (compute_display_string_pos, compute_display_string_end):
3700 (push_it): Accept second argument POSITION, where pop_it should
3701 jump to continue iteration.
3702 (reseat_1): Initialize bidi_it.disp_pos.
3704 * keyboard.c (adjust_point_for_property): Adjust the call to
3705 display_prop_intangible_p to its new signature.
3707 * dispextern.h (struct bidi_it): New member frame_window_p.
3708 (bidi_init_it): Update prototypes.
3709 (display_prop_intangible_p): Update prototype.
3710 (compute_display_string_pos, compute_display_string_end):
3712 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3715 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3717 Malloc failure behavior now depends on size of allocation.
3718 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3719 * lisp.h: Change signatures accordingly.
3720 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3721 All callers changed. (Bug#8762)
3723 * gnutls.c: Use Emacs's memory allocators.
3724 Without this change, the gnutls library would invoke malloc etc.
3725 directly, which causes problems on non-SYNC_INPUT hosts, and which
3726 runs afoul of improving memory_full behavior. (Bug#8761)
3727 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3728 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3729 xfree instead of the default malloc, realloc, free.
3730 (Fgnutls_boot): No need to check for memory allocation failure,
3731 since xmalloc does that for us.
3733 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3734 * category.c (hash_get_category_set):
3735 * ccl.c (ccl_driver):
3736 * charset.c (Fdefine_charset_internal):
3737 * charset.h (struct charset.hash_index):
3738 * composite.c (get_composition_id, gstring_lookup_cache)
3739 (composition_gstring_put_cache):
3740 * composite.h (struct composition.hash_index):
3741 * dispextern.h (struct image.hash):
3742 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3743 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3744 (hashfn_equal, hashfn_user_defined, make_hash_table)
3745 (maybe_resize_hash_table, hash_lookup, hash_put)
3746 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3747 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3748 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3749 * image.c (make_image, search_image_cache, lookup_image)
3750 (xpm_put_color_table_h):
3751 * lisp.h (struct Lisp_Hash_Table):
3752 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3753 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3754 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3755 * alloc.c (allocate_vectorlike):
3756 Check for overflow in vector size calculations.
3757 * ccl.c (ccl_driver):
3758 Check for overflow when converting EMACS_INT to int.
3759 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3760 need to be updated by these changes.
3761 * fns.c (make_hash_table, maybe_resize_hash_table):
3762 Check for integer overflow with large hash tables.
3763 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3764 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3765 (SXHASH_REDUCE): New macro.
3766 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3767 Use it instead of discarding useful hash info with large hash values.
3768 (sxhash_float): New function.
3769 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3770 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3771 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3772 Rewrite to use FIXNUM_BITS, as this simplifies things.
3773 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3774 Adjust signatures to match updated version of code.
3775 (consing_since_gc): Now EMACS_INT, since a single hash table can
3776 use more than INT_MAX bytes.
3778 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3780 Make it possible to build with GCC-4.6+ -O2 -flto.
3782 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3784 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3786 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3787 Call minibuffer-inactive-mode.
3789 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3791 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3792 Update dependencies.
3794 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3796 * data.c (init_data): Remove code for UTS, this system is not
3799 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3801 Don't force ./temacs to start in terminal mode.
3803 * frame.c (make_initial_frame): Initialize faces in all cases, not
3804 only when CANNOT_DUMP is defined.
3805 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3807 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3809 * dispnew.c (add_window_display_history): Use const for the string
3810 pointer. Remove declaration, not needed.
3812 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3814 Use 'inline', not 'INLINE'.
3815 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3816 * alloc.c, fontset.c (INLINE): Remove.
3817 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3818 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3819 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3820 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3821 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3823 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3825 Make it possible to run ./temacs.
3827 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3828 syms_of_callproc does the same thing. Remove test for
3829 "initialized", do it in the caller.
3830 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3832 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3834 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3835 (read_minibuf): Use get_minibuffer.
3836 (syms_of_minibuf): Use DEFSYM.
3837 (Qmetadata): New var.
3838 * data.c (Qbuffer): Don't make it static.
3839 (syms_of_data): Use DEFSYM.
3841 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3843 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3844 (CCL_CODE_MIN): New macro.
3846 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3848 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3850 * eval.c (Qdebug): Now static.
3851 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3852 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3853 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3855 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3857 * image.c: Various fixes to ImageMagick code comments.
3858 (Fimagemagick_types): Doc fix.
3860 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3862 Minor fixes prompted by GCC 4.6.0 warnings.
3864 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3866 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3867 (x_clipboard_manager_save_all): Move extern decl to ...
3868 * xterm.h: ... here, so that it can be checked for consistency.
3870 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3872 * xselect.c (x_clipboard_manager_save_frame)
3873 (x_clipboard_manager_save_all): New functions.
3874 (Fx_clipboard_manager_save): Lisp function deleted.
3876 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3877 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3879 * xterm.h: Update prototype.
3881 2011-05-28 William Xu <william.xwl@gmail.com>
3883 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3886 2011-05-28 Jim Meyering <meyering@redhat.com>
3888 Avoid a sign-extension bug in crypto_hash_function.
3889 * fns.c (to_uchar): Define.
3890 (crypto_hash_function): Use it to convert some newly-signed
3891 variables to unsigned, to avoid sign-extension bugs. For example,
3892 without this change, (md5 "truc") would evaluate to
3893 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3894 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3895 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3897 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3899 Integer overflow fixes.
3901 * dbusbind.c: Serial number integer overflow fixes.
3902 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3903 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3904 to hold a serial number that is too large for a fixnum.
3905 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3906 Check for serial numbers out of range. Decode any serial number
3907 that was so large that it became a float. (Bug#8722)
3909 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3910 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3911 Use XFASTINT rather than XUINT when numbers are nonnegative.
3912 (xd_append_arg, Fdbus_method_return_internal):
3913 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3914 arguments, check that Lisp number is nonnegative, rather than
3915 silently wrapping negative numbers around. (Bug#8722)
3916 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3919 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3921 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3923 ccl: add integer overflow checks
3924 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3925 (IN_INT_RANGE): New macros.
3926 (ccl_driver): Use them to check for integer overflow when
3927 decoding a CCL program. Many of the new checks are whether XINT (x)
3928 fits in int; it doesn't always, on 64-bit hosts. The new version
3929 doesn't catch all possible integer overflows, but it's an
3930 improvement. (Bug#8719)
3932 * alloc.c (make_event_array): Use XINT, not XUINT.
3933 There's no need for unsigned here.
3935 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3936 This follows up to the 2011-05-06 change that substituted uintptr_t
3937 for EMACS_INT. This case wasn't caught back then.
3939 Rework Fformat to avoid integer overflow issues.
3940 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3941 now (part of C89). Include <verify.h>.
3942 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3943 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3944 (Fformat): Avoid the prepass trying to compute sizes; it was only
3945 approximate and thus did not catch overflow reliably. Instead, walk
3946 through the format just once, formatting and computing sizes as we go,
3947 checking for integer overflow at every step, and allocating a larger
3948 buffer as needed. Keep track separately whether the format is
3949 multibyte. Keep only the most-recently calculated precision, rather
3950 than them all. Record whether each argument has been converted to
3951 string. Use EMACS_INT, not int, for byte and char and arg counts.
3952 Support field widths and precisions larger than INT_MAX. Avoid
3953 sprintf's undefined behavior with conversion specifications such as %#d
3954 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3955 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3956 formatting out-of-range floating point numbers with int
3959 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3961 * data.c: Avoid integer truncation in expressions involving floats.
3962 * data.c: Include <intprops.h>.
3963 (arith_driver): When there's an integer overflow in an expression
3964 involving floating point, convert the integers to floating point
3965 so that the resulting value does not suffer from catastrophic
3966 integer truncation. For example, on a 64-bit host (* 4
3967 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3968 Do not rely on undefined behavior after integer overflow.
3970 merge count_size_as_multibyte, parse_str_to_multibyte
3971 * character.c, character.h (count_size_as_multibyte):
3972 Rename from parse_str_to_multibyte; all uses changed.
3973 Check for integer overflow.
3974 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3975 since it's now a duplicate of the other. This is more of
3976 a character than a buffer op, so better that it's in character.c.
3977 * fns.c, print.c: Adjust to above changes.
3979 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3981 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3983 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3985 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3986 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3987 (x_clipboard_manager_save): Now static.
3988 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3990 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3991 (crypto_hash_function): Now static.
3992 Fix pointer signedness problems. Avoid unnecessary initializations.
3994 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3996 * termhooks.h (Vselection_alist): Make it terminal-local.
3998 * terminal.c (create_terminal): Initialize it.
4000 * xselect.c: Support for clipboard managers.
4001 (Vselection_alist): Move to termhooks.h as terminal-local var.
4002 (LOCAL_SELECTION): New macro.
4003 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4004 (symbol_to_x_atom): Remove gratuitous arg.
4005 (x_handle_selection_request, lisp_data_to_selection_data)
4006 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4007 (x_own_selection, x_get_local_selection, x_convert_selection):
4008 New arg, specifying work frame. Use terminal-local Vselection_alist.
4009 (some_frame_on_display): Delete unused function.
4010 (Fx_own_selection_internal, Fx_get_selection_internal)
4011 (Fx_disown_selection_internal, Fx_selection_owner_p)
4012 (Fx_selection_exists_p): New optional frame arg.
4013 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4014 (x_handle_selection_clear): Don't treat other terminals with the
4015 same keyboard specially. Use the terminal-local Vselection_alist.
4016 (x_clear_frame_selections): Use Frun_hook_with_args.
4018 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4020 * xterm.h: Add support for those atoms.
4022 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4024 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4025 (converted_selections, conversion_fail_tag): New global variables.
4026 (x_selection_request_lisp_error): Free the above.
4027 (x_get_local_selection): Remove unnecessary code.
4028 (x_reply_selection_request): Args changed; handle arbitrary array
4029 of converted selections stored in converted_selections.
4030 Separate the XChangeProperty and SelectionNotify steps.
4031 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4032 (x_convert_selection): New function.
4033 (x_handle_selection_event): Simplify.
4034 (x_get_foreign_selection): Don't ignore incoming requests while
4035 waiting for an answer; this will fail when we implement
4036 SAVE_TARGETS, and seems unnecessary anyway.
4037 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4038 (Vx_sent_selection_functions): Doc fix.
4040 2011-05-26 Leo Liu <sdl.web@gmail.com>
4042 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4044 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4046 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4048 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4049 for fringe update if it has periodic bitmap.
4050 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4051 and fringe_bitmap_periodic_p.
4053 * fringe.c (get_fringe_bitmap_data): New function.
4054 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4055 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4056 row. Mark glyph row for fringe update if periodicity changed.
4058 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4059 for fringe update unless it has periodic bitmap.
4061 2011-05-25 Kenichi Handa <handa@m17n.org>
4063 * xdisp.c (get_next_display_element): Set correct it->face_id for
4064 a static composition.
4066 2011-05-24 Leo Liu <sdl.web@gmail.com>
4069 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4071 * fns.c (crypto_hash_function, Fsha1): New function.
4072 (Fmd5): Use crypto_hash_function.
4073 (syms_of_fns): Add Ssha1.
4075 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4077 * gnutls.c: Remove unused macros.
4078 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4079 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4080 Remove macros that are defined and never used.
4081 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4083 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4085 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4086 (Fx_get_selection_internal): Minor cleanup.
4087 (Fx_own_selection_internal): Rename arguments for consistency with
4090 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4092 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4094 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4096 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4098 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4100 * dispnew.c (scrolling_window): Don't exclude the case that the
4101 last enabled row in the desired matrix touches the bottom boundary.
4103 2011-05-21 Glenn Morris <rgm@gnu.org>
4105 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4106 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4107 and add some more files.
4109 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4111 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4112 report_file_error introduced by the change from 2011-05-07.
4114 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4116 * systime.h (Time): Define only if emacs is defined.
4117 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4118 where the include path doesn't have X11/X.h by default. See
4119 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4121 2011-05-20 Kenichi Handa <handa@m17n.org>
4123 * composite.c (find_automatic_composition): Fix previous change.
4125 2011-05-20 Glenn Morris <rgm@gnu.org>
4127 * lisp.mk: New file, split from Makefile.in.
4128 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4129 (shortlisp): Remove.
4130 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4132 2011-05-19 Glenn Morris <rgm@gnu.org>
4134 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4135 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4136 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4137 (lisp): Set the order to that of loadup.el.
4138 (shortlisp): Make it a copy of $lisp.
4139 (SOME_MACHINE_LISP): Remove.
4140 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4141 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4143 2011-05-18 Kenichi Handa <handa@m17n.org>
4145 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4146 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4147 (find_automatic_composition): Mostly rewrite for efficiency.
4149 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4151 * makefile.w32-in: Update dependencies.
4153 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4155 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4156 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4158 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4160 Fix some integer overflow issues, such as string length overflow.
4162 * insdel.c (count_size_as_multibyte): Check for string overflow.
4164 * character.c (lisp_string_width): Check for string overflow.
4165 Use EMACS_INT, not int, for string indexes and lengths; in
4166 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4167 the resulting string length overflows an EMACS_INT; instead,
4168 report a string overflow if no precision given. When checking for
4169 precision exhaustion, use a check that cannot possibly have
4170 integer overflow. (Bug#8675)
4171 * character.h (lisp_string_width): Adjust to new signature.
4173 * alloc.c (string_overflow): New function.
4174 (Fmake_string): Use it. This doesn't change behavior, but saves
4175 a few bytes and will simplify future changes.
4176 * character.c (string_escape_byte8): Likewise.
4177 * lisp.h (string_overflow): New decl.
4179 Fixups, following up to the user-interface timestamp change.
4180 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4181 for UI timestamps, instead of unsigned long.
4182 * msdos.c (mouse_get_pos): Likewise.
4183 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4184 * w32gui.h (Time): Define by including "systime.h" rather than by
4185 declaring it ourselves. (Bug#8664)
4187 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4188 * image.c (clear_image_cache): Likewise.
4190 * term.c (term_mouse_position): Don't assume time_t wraparound.
4192 Be more systematic about user-interface timestamps.
4193 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4194 and sometimes 'EMACS_UINT', to represent these timestamps.
4195 This change causes it to use 'Time' uniformly, as that's what X uses.
4196 This makes the code easier to follow, and makes it easier to catch
4197 integer overflow bugs such as Bug#8664.
4198 * frame.c (Fmouse_position, Fmouse_pixel_position):
4199 Use Time, not unsigned long, for user-interface timestamps.
4200 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4201 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4202 * keyboard.h (last_event_timestamp): Likewise.
4203 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4204 * menu.h (xmenu_show): Likewise.
4205 * term.c (term_mouse_position): Likewise.
4206 * termhooks.h (struct input_event.timestamp): Likewise.
4207 (struct terminal.mouse_position_hook): Likewise.
4208 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4209 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4210 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4211 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4213 * menu.h, termhooks.h: Include "systime.h", for Time.
4215 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4216 Don't assume that the difference between two unsigned long values
4217 can fit into an integer. At this point, we know button_down_time
4218 <= event->timestamp, so the difference must be nonnegative, so
4219 there's no need to cast the result if double-click-time is
4220 nonnegative, as it should be; check that it's nonnegative, just in
4221 case. This bug is triggered when events are more than 2**31 ms
4222 apart (about 25 days). (Bug#8664)
4224 * xselect.c (last_event_timestamp): Remove duplicate decl.
4225 (x_own_selection): Remove needless cast to unsigned long.
4227 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4228 that always fit in int. Use a sentinel instead of a counter, to
4229 avoid a temp and to allay GCC's concerns about possible int overflow.
4230 * frame.h (struct frame): Use int for menu_bar_items_used
4231 instead of EMACS_INT, since it always fits in int.
4233 * menu.c (grow_menu_items): Check for int overflow.
4235 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4237 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4238 Before, the code was not consistent. These values cannot exceed
4239 2**31 - 1 so there's no need to make them unsigned.
4240 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4241 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4242 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4244 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4246 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4247 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4248 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4249 presumably because the widths might not match.
4251 * window.c (size_window): Avoid needless test at loop start.
4253 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4255 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4257 2011-05-12 Drew Adams <drew.adams@oracle.com>
4259 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4261 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4263 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4264 `width' to `bar_area_x' and `bar_area_width', respectively.
4265 (x_scroll_run): Take account of fringe background extension.
4267 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4268 Rename local vars `left' and `width' to `bar_area_x' and
4269 `bar_area_width', respectively.
4270 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4271 background extension.
4273 2011-05-10 Jim Meyering <meyering@redhat.com>
4275 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4277 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4279 * image.c (Finit_image_library): Return t for built-in image types,
4280 like pbm and xbm. (Bug#8640)
4282 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4284 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4286 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4288 * w32console.c (Fset_screen_color): Doc fix.
4289 (Fget_screen_color): New function.
4290 (syms_of_ntterm): Defsubr it.
4292 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4293 unlink the temporary file if Fcall_process didn't create it in the
4295 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4296 child process will be redirected to a file specified with `:file'.
4297 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4298 cue to call_process_cleanup not to close that handle.
4300 2011-05-07 Ben Key <bkey76@gmail.com>
4302 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4303 one of two shell specific rules, either bootstrap-temacs-CMD or
4304 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4305 to the previous implementation of the bootstrap-temacs rule.
4306 The bootstrap-temacs-CMD rule is similar to the previous
4307 implementation of the bootstrap-temacs rule except that it
4308 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4311 These changes, along with some changes to nt/configure.bat,
4312 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4313 earlier fix to add support for --cflags and --ldflags options
4314 that include quotes so that it works whether make uses cmd or
4317 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4319 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4320 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4322 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4323 a string. Handle both cases.
4324 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4325 (Fdbus_register_method): Use Qinvalid_function.
4327 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4329 * makefile.w32-in: Update dependencies.
4330 (LISP_H): Add inttypes.h and stdin.h.
4331 (PROCESS_H): Add unistd.h.
4333 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4335 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4336 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4338 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4340 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4342 * term.c (vfatal): Remove stray call to va_end.
4343 It's not needed and the C Standard doesn't allow it here anyway.
4345 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4346 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4348 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4351 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4353 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4355 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4357 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4359 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4361 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4362 * charset.c (Fdefine_charset_internal): Don't initialize
4363 charset.code_space[15]. The value was garbage, on hosts with
4364 32-bit int (Bug#8600).
4366 * lread.c (read_integer): Be more consistent with string-to-number.
4367 Use string_to_number to do the actual conversion; this avoids
4368 rounding errors and fixes some other screwups. Without this fix,
4369 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4370 (digit_to_number): Move earlier, for benefit of read_integer.
4371 Return -1 if the digit is out of range for the base, -2 if it is
4372 not a digit in any supported base. (Bug#8602)
4374 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4376 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4377 to match comment at start of function. This also removes a
4378 GCC warning about overflow in a 32+64-bit port.
4380 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4382 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4383 Reported by Stefan Monnier in
4384 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4385 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4386 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4388 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4389 (EMACS_UINTPTR): Likewise, with uintptr_t.
4391 * lisp.h: Prefer 64-bit EMACS_INT if available.
4392 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4393 on 32-bit hosts that have 64-bit int, so that they can access
4395 However, temporarily disable this change unless the temporary
4396 symbol WIDE_EMACS_INT is defined.
4398 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4400 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4401 This removes an assumption that EMACS_INT and long are the same
4402 width as pointers. The assumption is true for Emacs porting targets
4403 now, but we want to make other targets possible.
4404 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4405 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4406 In the rest of the code, change types of integers that hold casted
4407 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4408 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4409 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4410 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4411 No need to cast type when ORing.
4412 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4413 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4414 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4415 assume EMACS_INT is the same width as char *.
4416 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4417 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4418 Remove no-longer-needed casts.
4419 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4420 (xg_tool_bar_help_callback, xg_make_tool_item):
4421 Use EMACS_INTPTR to hold an integer
4422 that will be cast to void *; this can avoid a GCC warning
4423 if EMACS_INT is not the same width as void *.
4424 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4425 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4426 (current_message_1, set_message_1):
4427 Use a local to convert to proper width without a cast.
4428 * xmenu.c (dialog_selection_callback): Likewise.
4430 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4431 Also, don't assume VALBITS / RAND_BITS is less than 5,
4432 and don't rely on undefined behavior when shifting a 1 left into
4434 * lisp.h (get_random): Change signature to match.
4436 * lread.c (hash_string): Use size_t, not int, for hash computation.
4437 Normally we prefer signed values; but hashing is special, because
4438 it's better to use unsigned division on hash table sizes so that
4439 the remainder is nonnegative. Also, size_t is the natural width
4440 for hashing into memory. The previous code used 'int', which doesn't
4441 retain enough info to hash well into very large tables.
4442 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4444 * dbusbind.c: Don't possibly lose pointer info when converting.
4445 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4446 Use XPNTR rather than XHASH, so that the high-order bits of
4447 the pointer aren't lost when converting through void *.
4449 * eval.c (Fautoload): Don't double-shift a pointer.
4451 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4453 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4455 * gnutls.c (DEF_GNUTLS_FN):
4456 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4458 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4460 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4463 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4465 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4466 New version that can reserve upto 2GB of heap space.
4468 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4470 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4472 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4474 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4475 `gnutls_certificate_set_x509_key_file'.
4477 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4479 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4480 Update dependencies.
4482 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4484 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4485 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4486 Remove unused parameter `fildes'.
4487 * process.c (read_process_output, send_process): Don't pass it.
4489 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4491 Fix previous change: the library cache is defined in w32.c.
4492 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4493 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4495 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4497 Implement dynamic loading of GnuTLS on Windows.
4499 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4500 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4501 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4504 * gnutls.c (Qgnutls_dll): Define.
4505 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4506 (gnutls_*): Declare function pointers.
4507 (init_gnutls_functions): New function to initialize function pointers.
4508 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4509 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4510 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4511 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4512 (emacs_gnutls_write, emacs_gnutls_read)
4513 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4514 (Fgnutls_available_p): New function.
4515 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4516 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4517 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4519 * image.c: Include w32.h.
4520 (Vimage_type_cache): Delete.
4521 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4522 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4523 (w32_delayed_load): Move to w32.c.
4525 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4527 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4528 (w32_delayed_load): Move from image.c. When loading a library, record
4529 its filename in the :loaded-from property of the library id.
4530 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4531 Initialize and staticpro them.
4532 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4534 * process.c: Include lisp.h before w32.h, not after.
4535 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4536 instead of gnutls_record_check_pending.
4538 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4540 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4542 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4543 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4546 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4548 * xterm.c (x_set_frame_alpha): Do not set property on anything
4549 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4551 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4553 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4555 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4557 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4558 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4559 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4560 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4561 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4562 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4563 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4564 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4565 (Qgnutls_bootprop_callbacks_verify): Make static.
4567 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4569 * callproc.c: Indentation fixup.
4571 * sysdep.c (wait_for_termination_1): Make static.
4572 (wait_for_termination, interruptible_wait_for_termination):
4573 Move after wait_for_termination_1.
4575 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4577 * sysdep.c (interruptible_wait_for_termination): New function
4578 which is like wait_for_termination, but allows keyboard
4581 * callproc.c (Fcall_process): Add (:file "file") as an option for
4583 (Fcall_process_region): Ditto.
4585 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4587 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4588 rather than `XVECTOR (FOO)->size'.
4590 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4591 inttypes.h, as a gnulib replacement is used if it not available in
4594 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4596 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4597 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4598 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4600 * coding.c (coding_alloc_by_realloc): Error out if destination
4601 will grow beyond MOST_POSITIVE_FIXNUM.
4602 (decode_coding_emacs_mule): Abort if there isn't enough place in
4603 charbuf for the composition carryover bytes. Reserve an extra
4604 space for up to 2 characters produced in a loop.
4605 (decode_coding_iso_2022): Abort if there isn't enough place in
4606 charbuf for the composition carryover bytes.
4608 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4610 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4611 aborting when %lld or %lll format is passed.
4612 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4613 %llo or %llx format is passed. (Bug#8545)
4615 * window.c (window_scroll_line_based): Use a marker instead of
4616 simple variables to record original value of point. (Bug#7952)
4618 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4619 produced by %s or %c overflows available buffer space. (Bug#8545)
4621 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4623 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4624 (SIZE_MAX): Move defn after all includes, as they might #define it.
4626 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4628 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4630 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4632 * keyboard.c (Qdelayed_warnings_hook): Define.
4633 (command_loop_1): Run `delayed-warnings-hook'
4634 if Vdelayed_warnings_list is non-nil.
4635 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4636 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4638 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4640 * doprnt.c (doprnt): Don't return value smaller than the buffer
4641 size if the message was truncated. (Bug#8545).
4643 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4645 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4646 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4648 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4650 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4652 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4654 * makefile.w32-in: Update dependencies.
4656 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4658 Improve `doprnt' and its usage. (Bug#8545)
4659 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4660 `format_end'. Remove support for %l as a conversion specifier.
4661 Don't use xrealloc. Improve diagnostics when the %l size modifier
4662 is used. Update the commentary.
4664 * eval.c (verror): Simplify calculation of size_t.
4666 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4669 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4671 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4674 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4676 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4677 This makes this file independent of the recent pseudovector change.
4679 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4681 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4683 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4684 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4685 Remove unused local.
4686 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4688 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4689 GCC 4.6.0 optimizes based on type-based alias analysis.
4690 For example, if b is of type struct buffer * and v of type struct
4691 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4692 != &v->size, and therefore "v->size = 1; b->size = 2; return
4693 v->size;" must therefore return 1. This assumption is incorrect
4694 for Emacs, since it type-puns struct Lisp_Vector * with many other
4695 types. To fix this problem, this patch adds a new type struct
4696 vectorlike_header that documents the constraints on layout of vectors
4697 and pseudovectors, and helps optimizing compilers not get fooled
4698 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4699 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4700 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4702 (XSETPVECTYPE): Rewrite in terms of new macro.
4703 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4704 This is a bit clearer, and further avoids the possibility of
4705 undesirable aliasing.
4706 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4707 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4708 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4709 since Lisp_Subr is a special case (no "next" field).
4710 (ASIZE): Now uses header.size rather than size.
4711 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4712 to avoid the hassle of writing XVECTOR (foo)->header.size.
4713 (struct vectorlike_header): New type.
4714 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4715 object, to help avoid aliasing.
4716 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4717 (SUBRP): Likewise, since Lisp_Subr is a special case.
4718 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4719 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4720 (struct Lisp_Hash_Table): Combine first two members into a single
4721 struct vectorlike_header member. All uses of "size" and "next" members
4722 changed to be "header.size" and "header.next".
4723 * buffer.h (struct buffer): Likewise.
4724 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4725 * frame.h (struct frame): Likewise.
4726 * process.h (struct Lisp_Process): Likewise.
4727 * termhooks.h (struct terminal): Likewise.
4728 * window.c (struct save_window_data, struct saved_window): Likewise.
4729 * window.h (struct window): Likewise.
4730 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4731 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4732 * buffer.c (init_buffer_once): Likewise.
4733 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4735 * process.c (Fformat_network_address): Use local var for size,
4738 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4740 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4741 * data.c (atof): Remove decl; no longer used or needed.
4742 (digit_to_number): Move to lread.c.
4743 (Fstring_to_number): Use new string_to_number function, to be
4744 consistent with how the Lisp reader treats infinities and NaNs.
4745 Do not assume that floating-point numbers represent EMACS_INT
4746 without losing information; this is not true on most 64-bit hosts.
4747 Avoid double-rounding errors, by insisting on integers when
4748 parsing non-base-10 numbers, as the documentation specifies.
4749 * lisp.h (string_to_number): New decl, replacing ...
4750 (isfloat_string): Remove.
4751 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4752 (read1): Do not accept +. and -. as integers; this
4753 appears to have been a coding error. Similarly, do not accept
4754 strings like +-1e0 as floating point numbers. Do not report
4755 overflow for integer overflows unless the base is not 10 which
4756 means we have no simple and reliable way to continue.
4757 Break out the floating-point parsing into a new
4758 function string_to_number, so that Fstring_to_number parses
4759 floating point numbers consistently with the Lisp reader.
4760 (digit_to_number): Move here from data.c. Make it static inline.
4761 (E_CHAR, EXP_INT): Remove, replacing with ...
4762 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4763 (string_to_number): New function, replacing isfloat_string.
4764 This function checks for valid syntax and produces the resulting
4765 Lisp float number too. Rework it so that string-to-number
4766 no longer mishandles examples like "1.0e+". Use strtoumax,
4767 so that overflow for non-base-10 numbers is reported only when
4768 there's no portable and simple way to convert to floating point.
4770 * textprop.c (set_text_properties_1): Rewrite for clarity,
4771 and to avoid GCC warning about integer overflow.
4773 * intervals.h (struct interval): Use EMACS_INT for members
4774 where EMACS_UINT might cause problems. See
4775 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4776 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4777 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4779 (offset_intervals): Tell GCC not to worry about length overflow
4780 when negating a negative length.
4782 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4783 (overrun_check_free): Likewise.
4785 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4786 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4789 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4790 (gnutls_make_error): Rename local to avoid shadowing.
4791 (gnutls_emacs_global_deinit): ifdef out; not used.
4792 (Fgnutls_boot): Use const for pointer to readonly storage.
4793 Comment out unused local. Fix pointer signedness problems.
4795 * lread.c (openp): Don't stuff size_t into an 'int'.
4796 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4797 about possible signed overflow.
4799 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4800 (GDK_KEY_g): Don't define if already defined.
4801 (xg_prepare_tooltip): Avoid pointer signedness problem.
4802 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4804 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4805 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4807 * xfns.c (Fx_window_property): Simplify a bit,
4808 to make a bit faster and to avoid GCC 4.6.0 warning.
4809 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4811 * fns.c (internal_equal): Don't assume size_t fits in int.
4813 * alloc.c (compact_small_strings): Tighten assertion a little.
4815 Replace pEd with more-general pI, and fix some printf arg casts.
4816 * lisp.h (pI): New macro, generalizing old pEd macro to other
4817 conversion specifiers. For example, use "...%"pI"d..." rather
4818 than "...%"pEd"...".
4819 (pEd): Remove. All uses replaced with similar uses of pI.
4820 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4821 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4822 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4823 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4824 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4825 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4826 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4828 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4829 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4830 * print.c (safe_debug_print, print_object): Likewise.
4831 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4833 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4834 avoiding the 0 flag, which is not portable.
4835 * process.c (Fmake_network_process): Use pI to avoid cast.
4836 * region-cache.c (pp_cache): Likewise.
4837 * xdisp.c (decode_mode_spec): Likewise.
4838 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4839 behavior on 64-bit hosts with printf arg.
4840 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4841 (x_stop_queuing_selection_requests): Likewise.
4842 (x_get_window_property): Don't truncate byte count to an 'int'
4845 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4846 here, since it parses constructs like leading '-' and spaces,
4847 which are not wanted; and it overflows with large numbers.
4848 Instead, simply match F[0-9]+, which is what is wanted anyway.
4850 * alloc.c: Remove unportable assumptions about struct layout.
4851 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4852 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4853 (allocate_vectorlike, make_pure_vector): Use the new macros,
4854 plus offsetof, to remove unportable assumptions about struct layout.
4855 These assumptions hold on all porting targets that I know of, but
4856 they are not guaranteed, they're easy to remove, and removing them
4857 makes further changes easier.
4859 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4860 This doesn't fix a bug but makes the code clearer.
4861 (string_overrun_cookie): Now const. Use initializers that
4862 don't formally overflow signed char, to avoid warnings.
4863 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4864 can cause Emacs to crash when string overrun checking is enabled.
4865 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4866 multiple of sizeof (EMACS_INT); it need not be, if
4867 alignof(EMACS_INT) < sizeof (EMACS_INT).
4868 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4870 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4872 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4874 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4876 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4877 supposed to be handshaking. (Bug#8556)
4878 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4880 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4882 * lisp.h (Qdebug): List symbol.
4883 * eval.c (Qdebug): Restore global linkage.
4884 * keyboard.c (debug-on-event): New variable.
4885 (handle_user_signal): Break into debugger when debug-on-event
4886 matches the current signal symbol.
4888 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4890 * alloc.c (check_sblock, check_string_bytes)
4891 (check_string_free_list): Convert to standard C.
4893 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4895 * w32.c (emacs_gnutls_push): Fix typo.
4897 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4899 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4900 "cast to pointer from integer of different size".
4902 Improve doprnt and its use in verror. (Bug#8545)
4903 * doprnt.c (doprnt): Document the set of format control sequences
4904 supported by the function. Use SAFE_ALLOCA instead of always
4907 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4908 is one byte too soon. Don't use xrealloc; instead xfree and
4911 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4913 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4916 * gnutls.c: Renamed global_initialized to
4917 gnutls_global_initialized. Added internals for the
4918 :verify-hostname-error, :verify-error, and :verify-flags
4919 parameters of `gnutls-boot' and documented those parameters in the
4920 docstring. Start callback support.
4921 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4922 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4923 on error. Return error code.
4924 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4925 (emacs_gnutls_read): Likewise.
4926 (Fgnutls_boot): Return handshake error code.
4927 (emacs_gnutls_handle_error): New function.
4928 (wsaerror_to_errno): Likewise.
4930 * w32.h (emacs_gnutls_pull): Add prototype.
4931 (emacs_gnutls_push): Likewise.
4933 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4934 (emacs_gnutls_push): Likewise.
4936 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4938 * process.c (wait_reading_process_output): Check if GnuTLS
4939 buffered some data internally if no FDs are set for TLS
4942 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4943 (LIBS): Link to USER_LIBS.
4944 ($(BLD)/gnutls.$(0)): New target.
4946 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4948 * xdisp.c (handle_single_display_spec): Rename the
4949 display_replaced_before_p argument into display_replaced_p, to
4950 make it consistent with the commentary. Fix typos in the
4953 * textprop.c (syms_of_textprop): Remove dead code.
4954 (copy_text_properties): Delete obsolete commentary about an
4955 interface that was deleted long ago. Fix typos in the description
4958 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4959 to changes in oldXMenu/XMenu.h from 2011-04-16.
4960 <menu_help_message, prev_menu_help_message>: Constify.
4961 (IT_menu_make_room): menu->help_text is now `const char **';
4964 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4965 to changes in oldXMenu/XMenu.h from 2011-04-16.
4966 (struct XMenu): Declare `help_text' `const char **'.
4968 * xfaces.c <Qunspecified>: Make extern again.
4970 * syntax.c: Include sys/types.h before including regex.h, as
4973 * doc.c (get_doc_string): Improve the format passed to `error'.
4975 * doprnt.c (doprnt): Improve commentary.
4977 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4979 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4982 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4983 changes in globals.h immediately force recompilation.
4984 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4985 $(CURDIR)/s/ms-w32.h.
4986 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4988 * character.c (Fchar_direction): Function deleted.
4989 (syms_of_character): Don't defsubr it.
4990 <char-direction-table>: Deleted.
4992 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4994 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4995 * doprnt.c: Include limits.h.
4996 (SIZE_MAX): New macro.
4997 (doprnt): Return a size_t value. 2nd arg is now size_t.
4998 Many local variables are now size_t instead of int or unsigned.
4999 Improve overflow protection. Support `l' modifier for integer
5000 conversions. Support %l conversion. Don't assume an EMACS_INT
5001 argument for integer conversions and for %c.
5003 * lisp.h (doprnt): Restore prototype.
5005 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5008 * Makefile.in (base_obj): Add back doprnt.o.
5010 * deps.mk (doprnt.o): Add back prerequisites.
5011 (callint.o): Depend on character.h.
5013 * eval.c (internal_lisp_condition_case): Include the handler
5014 representation in the error message.
5015 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5016 when breaking from the loop.
5018 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5020 * callint.c (Fcall_interactively): When displaying error message
5021 about invalid control letter, pass the character's codepoint, not
5022 a pointer to its multibyte form. Improve display of the character
5023 in octal and display also its hex code.
5025 * character.c (char_string): Use %x to display the (unsigned)
5026 codepoint of an invalid character, to avoid displaying a bogus
5029 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5030 `error', not SYMBOL_NAME itself.
5032 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5033 character arguments to `error'.
5035 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5036 to `error' in error message about FINAL_CHAR argument. Make sure
5037 FINAL_CHAR is a character, and use %c when it is passed as
5038 argument to `error'.
5040 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5042 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5044 * w32.c: Include <time.h>.
5045 (sys_localtime): New function.
5047 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5049 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5051 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5053 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5055 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5058 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5060 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5061 gl_state.e_property when gl_state.object is Qt.
5063 * insdel.c (make_gap_larger): Remove limitation of buffer size
5066 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5068 * xdisp.c (lookup_glyphless_char_display)
5069 (produce_glyphless_glyph): Handle cons cell entry in
5070 glyphless-char-display.
5071 (Vglyphless_char_display): Document it.
5073 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5074 glyphless-char-display.
5076 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5078 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5080 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5082 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5083 definition for no-X builds.
5085 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5087 Static checks with GCC 4.6.0 and non-default toolkits.
5089 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5091 * process.c (keyboard_bit_set): Define only if SIGIO.
5092 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5093 (send_process): Repair possible setjmp clobbering.
5095 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5097 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5099 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5101 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5102 Define only if needed.
5104 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5105 by pacifying GCC about it. Maybe it's time to retire it?
5106 * xfaces.c (USG, __TIMEVAL__): Likewise.
5108 * dispextern.h (struct redisplay_interface): Rename param
5110 * termhooks.h (struct terminal): Likewise.
5111 * xterm.c (xembed_send_message): Likewise.
5113 * insdel.c (make_gap_smaller): Define only if
5114 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5116 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5119 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5120 so that we aren't warned about unused symbols.
5122 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5124 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5126 * xfns.c (x_real_positions): Mark locals as initialized.
5128 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5130 * xterm.c: Fix problems found by static analysis with other toolkits.
5131 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5132 (x_dispatch_event): Declare static if USE_GTK, and
5133 define if USE_GTK || USE_X_TOOLKIT.
5134 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5135 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5136 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5137 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5139 * xmenu.c (menu_help_callback): Pointer type fixes.
5140 Use const pointers when pointing at readonly data. Avoid pointer
5142 (FALSE): Remove unused macro.
5143 (update_frame_menubar): Remove unused decl.
5145 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5147 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5148 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5149 (single_menu_item): Rename local to avoid shadowing.
5151 * keyboard.c (make_lispy_event): Remove unused local var.
5153 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5154 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5156 * bitmaps: Change bitmaps from unsigned char back to the X11
5157 compatible char. Avoid the old compiler warnings about
5158 out-of-range initializers by using, for example, '\xab' rather
5161 * xgselect.c (xgselect_initialize): Check vs interface
5162 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5164 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5166 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5167 to read-only memory.
5169 * fns.c (vector): Remove; this old hack is no longer needed.
5171 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5173 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5175 * xrdb.c (x_load_resources): Omit unused local.
5177 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5178 (x_window): Rename locals to avoid shadowing.
5179 (USG): Use the kludged USG macro, to pacify gcc.
5181 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5182 (x_term_init): Remove local to avoid shadowing.
5184 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5186 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5187 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5189 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5191 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5193 Fix regex.c, syntax.c and friends for buffers > 2GB.
5194 * syntax.h (struct gl_state_s): Declare character position members
5197 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5199 * textprop.c (verify_interval_modification, interval_of):
5200 Declare arguments EMACS_INT.
5202 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5205 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5207 * indent.c (Fvertical_motion): Local variable it_start is now
5210 * regex.c (re_match, re_match_2, re_match_2_internal)
5211 (bcmp_translate, regcomp, regexec, print_double_string)
5212 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5213 (re_compile_pattern, re_exec): Declare arguments and local
5214 variables `size_t' and `ssize_t' and return values `regoff_t', as
5216 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5217 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5218 <compile_stack_type>: `size' and `avail' are now `size_t'.
5220 * regex.h <regoff_t>: Use ssize_t, not int.
5221 (re_search, re_search_2, re_match, re_match_2): Arguments that
5222 specify buffer/string position and length are now ssize_t and
5223 size_t. Return type is regoff_t.
5225 2011-04-16 Ben Key <bkey76@gmail.com>
5227 * nsfont.m: Fixed bugs in ns_get_family and
5228 ns_descriptor_to_entity that were caused by using free to
5229 deallocate memory blocks that were allocated by xmalloc (via
5230 xstrdup). This caused Emacs to crash when compiled with
5231 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5232 --enable-checking=xmallocoverrun). xfree is now used to
5233 deallocate these memory blocks.
5235 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5237 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5239 emacs_write: Accept and return EMACS_INT for sizes.
5240 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5242 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5243 Accept and return EMACS_INT.
5244 (emacs_gnutls_write): Return the number of bytes written on
5246 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5247 (emacs_read, emacs_write): Remove check for negative size, as the
5248 Emacs source code has been audited now.
5249 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5250 (emacs_read, emacs_write): Use it.
5251 * process.c (send_process): Adjust to the new signatures of
5252 emacs_write and emacs_gnutls_write. Do not attempt to store
5253 a byte offset into an 'int'; it might overflow.
5254 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5256 * sound.c: Don't assume sizes fit in 'int'.
5257 (struct sound_device.period_size, alsa_period_size):
5258 Return EMACS_INT, not int.
5259 (struct sound_device.write, vox_write, alsa_write):
5260 Accept EMACS_INT, not int.
5261 (wav_play, au_play): Use EMACS_INT to store sizes and to
5262 record read return values.
5264 2011-04-15 Ben Key <bkey76@gmail.com>
5266 * keyboard.c (Qundefined): Don't declare static since it is used
5268 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5269 static since they are used in nsfont.m.
5271 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5273 * process.c (Qprocessp): Don't declare static.
5274 * lisp.h (Qprocessp): Declare again.
5276 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5278 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5280 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5282 Improve C-level modularity by making more things 'static'.
5284 Don't publish debugger-only interfaces to other modules.
5285 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5286 (verify_bytepos, count_markers): Move decls to the only modules
5288 * region-cache.h (pp_cache): Likewise.
5289 * window.h (check_all_windows): Likewise.
5290 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5292 * sysdep.c (croak): Now static, if
5293 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5294 * syssignal.h (croak): Declare only if not static.
5296 * alloc.c (refill_memory_reserve): Now static if
5297 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5298 * lisp.h (refill_memory_reserve): Declare only if not static.
5300 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5301 Define only if USE_LUCID.
5303 * xrdb.c (x_customization_string, x_rm_string): Now static.
5305 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5306 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5308 * xdisp.c (draw_row_with_mouse_face): Now static.
5309 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5311 * window.h (check_all_windows): Mark externally visible.
5313 * window.c (window_deletion_count): Now static.
5315 * undo.c: Make symbols static if they're not exported.
5316 (last_undo_buffer, last_boundary_position, pending_boundary):
5319 * textprop.c (interval_insert_behind_hooks): Now static.
5320 (interval_insert_in_front_hooks): Likewise.
5322 * term.c: Make symbols static if they're not exported.
5323 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5324 (max_frame_lines, tty_set_terminal_modes):
5325 (tty_reset_terminal_modes, tty_turn_off_highlight):
5326 (get_tty_terminal): Now static.
5327 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5328 * termhooks.h (term_mouse_moveto): Do not declare if
5330 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5331 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5333 * sysdep.c: Make symbols static if they're not exported.
5334 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5336 (sigprocmask_set, full_mask): Remove; unused.
5337 (wait_debugging): Mark as visible.
5338 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5339 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5341 * syntax.c (syntax_temp): Define only if !__GNUC__.
5343 * sound.c (current_sound_device, current_sound): Now static.
5345 * search.c (searchbufs, searchbuf_head): Now static.
5347 * scroll.c (scroll_cost): Remove; unused.
5348 * dispextern.h (scroll_cost): Remove decl.
5350 * region-cache.h (pp_cache): Mark as externally visible.
5352 * process.c: Make symbols static if they're not exported.
5353 (process_tick, update_tick, create_process, chan_process):
5354 (Vprocess_alist, proc_buffered_char, datagram_access):
5355 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5356 (deactivate_process): Mark defn as static, as well as decl.
5357 * lisp.h (create_process): Remove decl.
5358 * process.h (chan_process, Vprocess_alist): Remove decls.
5360 * print.c: Make symbols static if they're not exported.
5361 (print_depth, new_backquote_output, being_printed, print_buffer):
5362 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5363 (print_interval, print_number_index, initial_stderr_stream):
5365 * lisp.h (Fprinc): Remove decl.
5366 (debug_output_compilation_hack): Mark as externally visible.
5368 * sysdep.c (croak): Move decl from here to syssignal.h.
5369 * syssignal.h (croak): Put it here, so the API can be checked when
5370 'croak' is called from dissociate_if_controlling_tty.
5372 * minibuf.c: Make symbols static if they're not exported.
5373 (minibuf_save_list, choose_minibuf_frame): Now static.
5374 * lisp.h (choose_minibuf_frame): Remove decl.
5376 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5378 * lread.c: Make symbols static if they're not exported.
5379 (read_objects, initial_obarray, oblookup_last_bucket_number):
5381 (make_symbol): Remove; unused.
5382 * lisp.h (initial_obarray, make_symbol): Remove decls.
5384 * keyboard.c: Make symbols static if they're not exported.
5385 (single_kboard, recent_keys_index, total_keys, recent_keys):
5386 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5387 (this_single_command_key_start, echoing, last_auto_save):
5388 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5389 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5390 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5391 (Vlispy_mouse_stem, double_click_count):
5393 (force_auto_save_soon): Define only if SIGDANGER.
5394 (ignore_mouse_drag_p): Now static if
5395 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5396 (print_help): Remove; unused.
5397 (stop_character, last_timer_event): Mark as externally visible.
5398 * keyboard.h (ignore_mouse_drag_p): Declare only if
5399 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5400 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5401 * lisp.h (echoing): Remove decl.
5402 (force_auto_save_soon): Declare only if SIGDANGER.
5403 * xdisp.c (redisplay_window): Simplify code, to make it more
5404 obvious that ignore_mouse_drag_p is not accessed if !defined
5405 USE_GTK && !defined HAVE_NS.
5407 * intervals.c: Make symbols static if they're not exported.
5408 (merge_properties_sticky, merge_interval_right, delete_interval):
5410 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5412 * insdel.c: Make symbols static if they're not exported.
5413 However, leave prepare_to_modify_buffer alone. It's never
5414 called from outside this function, but that appears to be a bug.
5415 (combine_after_change_list, combine_after_change_buffer):
5416 (adjust_after_replace, signal_before_change): Now static.
5417 (adjust_after_replace_noundo): Remove; unused.
5418 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5419 (signal_before_change): Remove decls.
5421 * indent.c (val_compute_motion, val_vmotion): Now static.
5423 * image.c: Make symbols static if they're not exported.
5424 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5426 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5427 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5429 * fringe.c (standard_bitmaps): Now static.
5430 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5432 * frame.c: Make symbols static if they're not exported.
5433 (x_report_frame_params, make_terminal_frame): Now static.
5434 (get_frame_param): Now static, unless HAVE_NS.
5435 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5436 (x_get_resource_string): Remove; not used.
5437 * frame.h (make_terminal_frame, x_report_frame_params):
5438 (x_get_resource_string); Remove decls.
5439 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5440 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5442 * font.c, fontset.c: Make symbols static if they're not exported.
5443 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5444 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5445 * font.c (font_close_object): Now static.
5446 * font.h (font_close_object): Remove.
5447 * fontset.c (FONTSET_OBJLIST): Remove.
5448 (free_realized_fontset) #if-0 the body, which does nothing.
5449 (face_suitable_for_char_p): #if-0, as it's never called.
5450 * fontset.h (face_suitable_for_char_p): Remove decl.
5451 * xfaces.c (face_at_string_position):
5452 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5453 since 0 is always ASCII.
5455 * fns.c (weak_hash_tables): Now static.
5457 * fileio.c: Make symbols static if they're not exported.
5458 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5459 (Vwrite_region_annotation_buffers): Now static.
5461 * eval.c: Make symbols static if they're not exported.
5462 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5463 * lisp.h (backtrace_list): Remove decl.
5465 * emacs.c: Make symbols static if they're not exported.
5466 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5467 (fatal_error_code, fatal_error_signal_hook, standard_args):
5469 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5470 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5471 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5472 * lisp.h (fatal_error_signal_hook): Remove decl.
5473 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5475 * editfns.c: Move a (normally-unused) function to its only use.
5476 * editfns.c, lisp.h (get_operating_system_release): Remove.
5477 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5478 worth the hassle of breaking this out.
5480 * xterm.c: Make symbols static if they're not exported.
5481 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5482 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5483 (x_destroy_window, x_delete_display):
5485 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5486 (x_mouse_leave): Remove; unused.
5487 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5488 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5489 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5491 (x_mouse_leave): Declare only if WINDOWSNT.
5492 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5493 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5496 * ftxfont.c: Make symbols static if they're not exported.
5497 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5499 * font.h (ftxfont_driver): Likewise.
5501 * xfns.c: Make symbols static if they're not exported.
5502 (x_last_font_name, x_display_info_for_name):
5503 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5504 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5505 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5506 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5507 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5508 (last_show_tip_args): Now static.
5509 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5510 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5511 (x_screen_planes): Remove; unused.
5512 * dispextern.h (x_screen_planes): Remove decl.
5514 * dispnew.c: Make symbols static if they're not exported.
5515 * dispextern.h (redraw_garbaged_frames, scrolling):
5516 (increment_row_positions): Remove.
5517 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5518 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5520 (redraw_garbaged_frames): Remove; unused.
5522 * xfaces.c: Make symbols static if they're not exported.
5523 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5525 * xterm.h (defined_color): Remove decls.
5526 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5527 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5528 (menu_face_changed_default, defined_color, free_realized_face):
5529 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5530 (ascii_face_of_lisp_face): Remove; unused.
5532 * xdisp.c: Make symbols static if they're not exported.
5533 * dispextern.h (scratch_glyph_row, window_box_edges):
5534 (glyph_to_pixel_coords, set_cursor_from_row):
5535 (get_next_display_element, set_iterator_to_next):
5536 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5537 (show_mouse_face): Remove decls
5538 * frame.h (message_buf_print): Likewise.
5539 * lisp.h (pop_message, set_message, check_point_in_composition):
5541 * xterm.h (set_vertical_scroll_bar): Likewise.
5542 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5543 (message_buf_print, scratch_glyph_row, displayed_buffer):
5544 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5545 (get_next_display_element, show_mouse_face, window_box_edges):
5546 (frame_to_window_pixel_xy, check_point_in_composition):
5547 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5548 (glyph_to_pixel_coords): Remove; unused.
5550 * dired.c (file_name_completion): Now static.
5552 * dbusbind.c (xd_in_read_queued_messages): Now static.
5554 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5555 * data.c (circular_list_error): Remove.
5557 * commands.h (last_point_position, last_point_position_buffer):
5558 (last_point_position_window): Remove decls.
5559 * keyboard.c: Make these variables static.
5561 * coding.h (coding, code_convert_region, encode_coding_gap):
5563 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5564 (iso_code_class, detect_coding, code_convert_region): Now static.
5565 (encode_coding_gap): Remove; unused.
5567 * chartab.c (chartab_chars, chartab_bits): Now static.
5569 * charset.h (charset_iso_8859_1): Remove decl.
5570 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5573 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5574 * ccl.c (Vccl_program_table): Now static.
5575 (check_ccl_update): Remove; unused.
5577 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5578 * category.h: ... from here.
5579 * category.c (check_category_table, set_category_set): Now static.
5581 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5582 * lisp.h: Remove these decls.
5584 * buffer.c (buffer_count): Remove unused var.
5586 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5587 so that it's not optimized away.
5588 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5589 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5590 exported only to the debugger.
5592 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5593 * atimer.h (run_all_atimers): Remove; not exported.
5595 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5596 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5597 was inaccessible from Lisp.
5598 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5599 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5601 alloc.c: Import and export fewer symbols, and remove unused items.
5602 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5604 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5605 it's not optimized away by whole-program optimization.
5606 (message_enable_multibyte, free_misc): Remove.
5607 (catchlist, handlerlist, mark_backtrace):
5608 Declare only if BYTE_MARK_STACK.
5609 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5610 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5611 (message_enable_multibyte): Remove decl.
5612 (free_misc, interval_free_list, float_block, float_block_index):
5613 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5614 (cons_free_list, last_marked_index):
5616 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5617 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5618 (mark_backtrace): Define only if BYTE_MARK_STACK.
5619 * xdisp.c (message_enable_multibyte): Now static.
5621 Declare Lisp_Object Q* variables to be 'static' if not exported.
5622 This makes it easier for human readers (and static analyzers)
5623 to see whether these variables are used from other modules.
5624 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5625 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5626 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5627 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5628 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5629 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5630 * xmenu.c, xselect.c:
5631 Declare Q* vars static if they are not used in other modules.
5632 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5633 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5634 Remove decls of unexported vars.
5635 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5637 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5639 Make Emacs functions such as Fatom 'static' by default.
5640 This makes it easier for human readers (and static analyzers)
5641 to see whether these functions can be called from other modules.
5642 DEFUN now defines a static function. To make the function external
5643 so that it can be used in other C modules, use the new macro DEFUE.
5644 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5645 (Finit_image_library):
5646 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5647 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5648 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5649 Remove decls, since these functions are now static.
5650 (Funintern, Fget_internal_run_time): New decls, since these functions
5651 were already external.
5653 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5654 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5655 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5656 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5657 * keyboard.c, keymap.c, lread.c:
5658 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5659 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5660 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5661 Mark functions with DEFUE instead of DEFUN,
5662 if they are used in other modules.
5663 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5664 decls for now-static functions.
5665 * buffer.h (Fdelete_overlay): Remove decl.
5666 * callproc.c (Fgetenv_internal): Mark as internal.
5667 * composite.c (Fremove_list_of_text_properties): Remove decl.
5668 (Fcomposition_get_gstring): New forward static decl.
5669 * composite.h (Fcomposite_get_gstring): Remove decl.
5670 * dired.c (Ffile_attributes): New forward static decl.
5671 * doc.c (Fdocumntation_property): New forward static decl.
5672 * eval.c (Ffetch_bytecode): New forward static decl.
5673 (Funintern): Remove extern decl; now in .h file where it belongs.
5674 * fileio.c (Fmake_symbolic_link): New forward static decl.
5675 * image.c (Finit_image_library): New forward static decl.
5676 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5677 * intervals.h (Fprevious_property_change):
5678 (Fremove_list_of_text_properties): Remove decls.
5679 * keyboard.c (Fthis_command_keys): Remove decl.
5680 (Fcommand_execute): New forward static decl.
5681 * keymap.c (Flookup_key): New forward static decl.
5682 (Fcopy_keymap): Now static.
5683 * keymap.h (Flookup_key): Remove decl.
5684 * process.c (Fget_process): New forward static decl.
5685 (Fprocess_datagram_address): Mark as internal.
5686 * syntax.c (Fsyntax_table_p): New forward static decl.
5687 (skip_chars): Remove duplicate decl.
5688 * textprop.c (Fprevious_property_change): New forward static decl.
5689 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5691 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5692 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5694 * editfns.c (Fformat): Remove unreachable code.
5696 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5698 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5701 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5703 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5704 when at ZV. (Bug#8487)
5706 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5708 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5710 * keyboard.c (parse_tool_bar_item): Likewise.
5711 * sound.c (sound_cleanup, alsa_close): Likewise.
5712 * termcap.c (tgetent): Likewise.
5713 * xfns.c (x_default_font_parameter): Likewise.
5714 * xsettings.c (read_and_apply_settings): Likewise.
5716 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5717 (overrun_check_free): Protoize.
5719 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5721 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5722 since callers should never pass a negative size.
5723 Change the signature to match that of plain 'read' and 'write'; see
5724 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5725 * lisp.h: Update prototypes of emacs_write and emacs_read.
5727 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5729 * xdisp.c (redisplay_window): Don't try to determine the character
5730 position of the scroll margin if the window start point w->startp
5731 is outside the buffer's accessible region. (Bug#8468)
5733 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5735 Fix write-region and its subroutines for buffers > 2GB.
5736 * fileio.c (a_write, e_write): Modify declaration of arguments and
5737 local variables to support buffers larger than 2GB.
5738 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5740 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5741 argument, local variables, and return value.
5743 * lisp.h: Update prototypes of emacs_write and emacs_read.
5745 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5747 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5749 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5751 Fix more problems found by GCC 4.6.0's static checks.
5753 * xdisp.c (vmessage): Use a better test for character truncation.
5755 * charset.c (load_charset_map): <, not <=, for optimization,
5756 and to avoid potential problems with integer overflow.
5757 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5758 * casetab.c (set_identity, shuffle): Likewise.
5759 * editfns.c (Fformat): Likewise.
5760 * syntax.c (skip_chars): Likewise.
5762 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5763 This also lets GCC 4.6.0 generate slightly better loop code.
5765 * callint.c (Fcall_interactively): <, not <=, for optimization.
5766 (Fcall_interactively): Count the number of arguments produced,
5767 not the number of arguments given. This is simpler and lets GCC
5768 4.6.0 generate slightly better code.
5770 * ftfont.c: Distingish more carefully between FcChar8 and char.
5771 The previous code passed unsigned char * to a functions like
5772 strlen and xstrcasecmp that expect char *, which does not
5773 conform to the C standard.
5774 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5775 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5776 char * when the C standard requires it.
5778 * keyboard.c (read_char): Remove unused var.
5780 * eval.c: Port to Windows vsnprintf (Bug#8435).
5782 (SIZE_MAX): Define if the headers do not.
5783 (verror): Do not give up if vsnprintf returns a negative count.
5784 Instead, grow the buffer. This ports to Windows vsnprintf, which
5785 does not conform to C99. Problem reported by Eli Zaretskii.
5786 Also, simplify the allocation scheme, by avoiding the need for
5787 calling realloc, and removing the ALLOCATED variable.
5789 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5791 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5792 But keep the doprint source code for now, as we might revamp it
5793 and use it again (Bug#8435).
5794 * lisp.h (doprnt): Remove.
5795 * Makefile.in (base_obj): Remove doprnt.o.
5796 * deps.mk (doprnt.o): Remove.
5798 error: Print 32- and 64-bit integers portably (Bug#8435).
5799 Without this change, on typical 64-bit hosts error ("...%d...", N)
5800 was used to print both 32- and 64-bit integers N, which relied on
5802 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5804 * lisp.h (error, verror): Mark as printf-like functions.
5805 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5806 Report overflow in size calculations when allocating printf buffer.
5807 Do not truncate output string at its first null byte.
5808 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5809 Truncate the output at a character boundary, since vsnprintf does not
5811 * charset.c (check_iso_charset_parameter): Convert internal
5812 character to string before calling 'error', since %c now has the
5814 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5815 overflow when computing char to be passed to 'error'. Do not
5816 pass Lisp_Object to 'error'; pass the integer instead.
5817 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5818 formatted with plain %d.
5820 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5822 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5824 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5826 * xterm.c (x_catch_errors): Remove duplicate declaration.
5828 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5830 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5832 2011-04-10 Jim Meyering <meyering@redhat.com>
5834 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5835 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5836 return ssize_t not "int", and use size_t as the buffer length.
5837 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5838 * gnutls.h: Update declarations.
5839 * process.c (read_process_output): Use ssize_t, to match.
5840 (send_process): Likewise.
5842 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5844 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5846 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5848 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5849 Use unsigned char, to match FcChar8 type definition.
5851 * xterm.c (handle_one_xevent):
5852 * xmenu.c (create_and_show_popup_menu):
5853 * xselect.c (x_decline_selection_request)
5854 (x_reply_selection_request): Avoid type-punned deref of X events.
5856 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5858 Fix some uses of `int' instead of EMACS_INT.
5859 * search.c (string_match_1, fast_string_match)
5860 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5861 (scan_buffer, find_next_newline_no_quit)
5862 (find_before_next_newline, search_command, Freplace_match)
5863 (Fmatch_data): Make some `int' variables be EMACS_INT.
5865 * xdisp.c (display_count_lines): 3rd argument and return value now
5866 EMACS_INT. All callers changed.
5867 (pint2hrstr): Last argument is now EMACS_INT.
5869 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5870 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5871 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5872 (decode_coding_utf_16, decode_coding_emacs_mule)
5873 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5874 (decode_coding_ccl, decode_coding_charset)
5875 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5876 (decode_coding_iso_2022, decode_coding_emacs_mule)
5877 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5878 <char_offset, last_offset>: Declare EMACS_INT.
5879 (encode_coding_utf_8, encode_coding_utf_16)
5880 (encode_coding_emacs_mule, encode_invocation_designation)
5881 (encode_designation_at_bol, encode_coding_iso_2022)
5882 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5883 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5885 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5886 (encode_invocation_designation): Last argument P_NCHARS is now
5888 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5889 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5891 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5894 * ccl.c (Fccl_execute_on_string): Declare some variables
5897 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5899 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5901 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5903 * process.c (Fformat_network_address): Doc fix.
5905 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5907 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5909 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5911 * keyboard.c (read_char): Call Lisp function help-form-show,
5912 instead of using internal_with_output_to_temp_buffer.
5913 (Qhelp_form_show): New var.
5914 (syms_of_keyboard): Use DEFSYM macro.
5916 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5918 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5920 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5922 * process.c (Flist_processes): Remove to Lisp.
5923 (list_processes_1): Delete.
5925 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5927 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5929 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5931 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5933 Fix more problems found by GCC 4.6.0's static checks.
5935 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5937 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5939 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5941 * xdisp.c (vmessage): Mark as a printf-like function.
5943 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5945 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5947 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5948 printf-like functions.
5949 (tiff_load): Add casts to remove these marks before passing them
5950 to system-supplied API.
5952 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5954 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5955 This avoids several warnings with gcc -Wstrict-overflow.
5956 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5957 directly, rather than having caller test rule sign. This avoids
5958 some unnecessary tests.
5959 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5960 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5961 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5963 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5964 (xfont_open): Avoid unnecessary tests.
5966 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5968 * composite.h, composite.c (composition_gstring_put_cache):
5969 Use EMACS_INT, not int, for length.
5971 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5972 breaking out part of COMPOSITION_DECODE_RULE.
5973 (COMPOSITION_DECODE_RULE): Use it.
5974 * composite.c (get_composition_id): Remove unused local vars,
5975 by using the new macro.
5977 * textprop.c (set_text_properties_1): Change while to do-while,
5978 since the condition is always true at first.
5980 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5981 (interval_deletion_adjustment): Return unsigned value.
5984 * process.c (list_processes_1, create_pty, read_process_output):
5985 (exec_sentinel): Remove vars that were set but not used.
5986 (create_pty): Remove unnecessary "volatile"s.
5987 (Fnetwork_interface_info): Avoid possibility of int overflow.
5988 (read_process_output): Do adaptive read buffering even if carryover.
5989 (read_process_output): Simplify nbytes computation if buffered.
5991 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5993 * syntax.c (scan_words): Remove var that was set but not used.
5994 (update_syntax_table): Use unsigned instead of int.
5996 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5997 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5998 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6000 * print.c (print_error_message): Avoid int overflow.
6002 * font.c (font_list_entities): Redo for clarity,
6003 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6005 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6006 (font_score): Avoid potential overflow in diff calculation.
6008 * fns.c (substring_both): Remove var that is set but not used.
6009 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6011 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6013 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6014 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6015 can always succeed if overflow has undefined behavior.
6017 * search.c (boyer_moore, wordify): Remove vars set but not used.
6018 (wordify): Omit three unnecessary tests.
6020 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6021 All callers changed. This avoids the need for an unused var.
6023 * casefiddle.c (casify_region): Remove var that is set but not used.
6025 * dired.c (file_name_completion): Remove var that is set but not used.
6027 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6029 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6030 (Finsert_file_contents): Remove unnecessary code checking fd.
6032 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6033 Check for integer overflow on size calculations.
6035 * buffer.c (Fprevious_overlay_change): Remove var that is set
6038 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6039 Remove vars that are set but not used.
6040 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6041 (timer_check_2): Mark vars as initialized.
6043 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6045 * image.c (lookup_image): Remove var that is set but not used.
6046 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6048 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6049 that are set but not used.
6051 * xfns.c (make_invisible_cursor): Don't return garbage
6052 if XCreateBitmapFromData fails (Bug#8410).
6054 * xselect.c (x_get_local_selection, x_handle_property_notify):
6055 Remove vars that are set but not used.
6057 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6058 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6060 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6061 Remove var that is set but not used.
6062 (scroll_bar_windows_size): Now size_t, not int.
6063 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6066 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6067 (map_tty_color) [!defined MSDOS]: Likewise.
6069 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6071 * coding.c: Remove vars that are set but not used.
6072 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6073 All callers changed.
6074 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6075 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6076 (decode_coding_charset): Remove vars that are set but not used.
6078 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6079 that is set but not used.
6081 * print.c (print_object): Remove var that is set but not used.
6083 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6084 The gnulib version avoids calling malloc in the usual case,
6085 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6086 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6087 * filelock.c (current_lock_owner): Likewise.
6088 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6089 * sysdep.c: Include allocator.h, careadlinkat.h.
6090 (emacs_no_realloc_allocator): New static constant.
6091 (emacs_readlink): New function.
6092 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6093 ../lib/careadlinkat.h.
6095 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6097 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6098 first non-nil return value).
6100 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6102 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6103 if not defined (Bug#8403).
6105 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6107 * xdisp.c (display_count_lines): Remove parameter `start',
6108 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6109 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6110 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6111 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6112 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6113 and thereabouts. All callers changed.
6114 (get_per_char_metric): Remove parameter `f', unused since
6115 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6117 2011-04-02 Jim Meyering <meyering@redhat.com>
6119 do not dereference NULL upon failed strdup
6120 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6121 (ns_get_family): Likewise.
6123 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6125 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6127 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6129 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6132 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6134 Add lexical binding.
6136 * window.c (Ftemp_output_buffer_show): New fun.
6137 (Fsave_window_excursion):
6138 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6140 * lread.c (lisp_file_lexically_bound_p): New function.
6141 (Fload): Bind Qlexical_binding.
6142 (readevalloop): Remove `evalfun' arg.
6143 Bind Qinternal_interpreter_environment.
6144 (Feval_buffer): Bind Qlexical_binding.
6145 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6147 (syms_of_lread): Declare `lexical-binding'.
6149 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6151 * keyboard.c (eval_dyn): New fun.
6152 (menu_item_eval_property): Use it.
6154 * image.c (parse_image_spec): Use Ffunctionp.
6156 * fns.c (concat, mapcar1): Accept byte-code-functions.
6158 * eval.c (Fsetq): Handle lexical vars.
6159 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6160 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6161 (FletX, Flet): Obey lexical binding.
6162 (Fcommandp): Handle closures.
6163 (Feval): New `lexical' arg.
6164 (eval_sub): New function extracted from Feval. Use it almost
6165 everywhere where Feval was used. Look up vars in lexical env.
6167 (Ffunctionp): Move from subr.el.
6168 (Ffuncall): Handle closures.
6169 (apply_lambda): Remove `eval_flags'.
6170 (funcall_lambda): Handle closures and new byte-code-functions.
6171 (Fspecial_variable_p): New function.
6172 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6173 but without exporting it to Lisp.
6175 * doc.c (Fdocumentation, store_function_docstring):
6176 * data.c (Finteractive_form): Handle closures.
6178 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6181 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6183 (exec_byte_code): New function extracted from Fbyte_code to handle new
6184 calling convention for byte-code-functions. Add new byte-codes.
6186 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6188 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6190 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6192 * xdisp.c (redisplay_internal): Fix prototype.
6194 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6196 * xdisp.c (SCROLL_LIMIT): New macro.
6197 (try_scrolling): Use it when setting scroll_limit.
6198 Limit scrolling to 100 screen lines.
6199 (redisplay_window): Even when falling back on "recentering",
6200 position point in the window according to scroll-conservatively,
6201 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6203 (try_scrolling): When point is above the window, allow searching
6204 as far as scroll_max, or one screenful, to compute vertical
6205 distance from PT to the scroll margin position. This prevents
6206 try_scrolling from unnecessarily failing when
6207 scroll-conservatively is set to a value slightly larger than the
6208 window height. Clean up the case of PT below the margin at bottom
6209 of window: scroll_max can no longer be INT_MAX. When aggressive
6210 scrolling is in use, don't let point enter the opposite scroll
6211 margin as result of the scroll.
6212 (syms_of_xdisp) <scroll-conservatively>: Document the
6213 threshold of 100 lines for never-recentering scrolling.
6215 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6217 * dispextern.h (move_it_by_lines):
6218 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6219 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6220 (message_log_check_duplicate): Remove parameters `prev_bol' and
6221 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6222 (redisplay_internal): Remove parameter `preserve_echo_area',
6223 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6225 * indent.c (Fvertical_motion):
6226 * window.c (window_scroll_pixel_based, Frecenter):
6227 Don't pass `need_y_p' to `move_it_by_lines'.
6229 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6231 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6232 steal a few bits to be more compact.
6233 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6234 Remove unneeded casts.
6236 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6238 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6240 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6241 binding" message (bug#7967).
6243 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6245 Fix more problems found by GCC 4.6.0's static checks.
6247 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6248 Remove unused local var.
6250 * editfns.c (Fmessage_box): Remove unused local var.
6252 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6253 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6254 Omit unused local vars.
6255 * window.c (shrink_windows): Omit unused local var.
6256 * menu.c (digest_single_submenu): Omit unused local var.
6257 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6258 Omit unused local var.
6260 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6261 Don't assume string length fits in int.
6262 (keyremap_step, read_key_sequence): Use size_t for sizes.
6263 (read_key_sequence): Don't check last_real_key_start redundantly.
6265 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6266 instead of alloca (Bug#8344).
6268 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6269 (Fbacktrace_frame): Don't assume nframes fits in int.
6271 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6273 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6276 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6278 * cm.c (calccost): Turn while-do into do-while, for clarity.
6280 * keyboard.c (syms_of_keyboard): Use the same style as later
6281 in this function when indexing through an array. This also
6282 works around GCC bug 48267.
6284 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6286 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6288 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6289 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6291 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6292 This avoids undefined behavior on integer overflow, and is a bit
6293 more convenient anyway since it is compared to a size_t variable.
6295 Variadic C functions now count arguments with size_t, not int.
6296 This avoids an unnecessary limitation on 64-bit machines, which
6297 caused (substring ...) to crash on large vectors (Bug#8344).
6298 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6299 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6300 All variadic functions and their callers changed accordingly.
6301 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6302 * data.c (arith_driver, float_arith_driver): Likewise.
6303 * editfns.c (general_insert_function): Likewise.
6304 * eval.c (struct backtrace.nargs, interactive_p)
6305 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6306 (funcall_lambda, mark_backtrace): Likewise.
6307 * fns.c (concat): Likewise.
6308 * frame.c (x_set_frame_parameters): Likewise.
6309 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6310 0 if not found, not -1. All callers changed.
6312 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6313 (stack_copy_size): Now size_t, not int.
6314 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6316 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6318 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6319 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6320 All callers changed.
6322 * lisp.h (multibyte_char_to_unibyte):
6323 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6324 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6325 * character.h (CHAR_TO_BYTE8):
6326 * cmds.c (internal_self_insert):
6327 * editfns.c (general_insert_function):
6328 * keymap.c (push_key_description):
6329 * search.c (Freplace_match):
6330 * xdisp.c (message_dolog, set_message_1): All callers changed.
6332 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6334 * keyboard.c (safe_run_hook_funcall): New function.
6335 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6336 don't set the hook to nil, but remove the offending function instead.
6337 (Qcommand_hook_internal): Remove, unused.
6338 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6339 Vcommand_hook_internal.
6341 * eval.c (enum run_hooks_condition): Remove.
6342 (funcall_nil, funcall_not): New functions.
6343 (run_hook_with_args): Call each function through a `funcall' argument.
6344 Remove `cond' argument, now redundant.
6345 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6346 (Frun_hook_with_args_until_failure): Adjust accordingly.
6347 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6349 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6351 * dispextern.h (string_buffer_position): Remove declaration.
6353 * print.c (strout): Remove parameter `multibyte', unused since
6354 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6356 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6357 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6358 All callers changed.
6360 * w32.c (_wsa_errlist): Use braces for struct initializers.
6362 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6363 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6364 All callers changed.
6365 (string_buffer_position): Likewise. Also, make static (it's never
6366 used outside xdisp.c).
6367 (cursor_row_p): Remove parameter `w', unused since
6368 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6369 (decode_mode_spec): Remove parameter `precision', introduced during
6370 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6371 All callers changed.
6373 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6375 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6377 2011-03-27 Anders Lindgren <andlind@gmail.com>
6379 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6380 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6381 (ns_update_auto_hide_menu_bar): New functions.
6382 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6383 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6384 ns_constrain_all_frames.
6385 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6386 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6388 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6390 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6392 2011-03-27 Glenn Morris <rgm@gnu.org>
6394 * syssignal.h: Replace RETSIGTYPE with void.
6395 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6396 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6397 Replace SIGTYPE with void everywhere.
6398 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6399 * s/template.h (SIGTYPE): Remove commented out definition.
6401 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6403 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6404 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6406 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6408 * w32.c (read_unc_volume): Use parameter `henum', instead of
6409 global variable `wget_enum_handle'.
6411 * keymap.c (describe_vector): Remove parameters `indices' and
6412 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6413 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6415 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6417 * keyboard.c (timer_check): Remove parameter `do_it_now',
6418 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6419 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6420 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6422 * keyboard.c (read_char):
6423 * w32menu.c (w32_menu_display_help):
6424 * xmenu.c (show_help_event, menu_help_callback):
6425 Adjust calls to `show_help_echo'.
6427 * gtkutil.c (xg_maybe_add_timer):
6428 * keyboard.c (readable_events):
6429 * process.c (wait_reading_process_output):
6430 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6432 * insdel.c (adjust_markers_gap_motion):
6433 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6434 (gap_left, gap_right): Don't call it.
6436 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6438 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6439 incurred during fontification.
6441 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6443 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6444 (DEFVAR_PER_BUFFER): Don't pass it.
6446 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6447 (scrolling_window): Don't pass it.
6449 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6451 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6453 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6455 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6456 of variables specific to SELinux and computation of `encoded_absname'.
6458 * image.c (XPutPixel): Remove unused variable `height'.
6460 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6462 * unexw32.c (get_section_info): Remove unused variable `section'.
6464 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6465 (system_process_attributes): Remove unused variable `sess'.
6466 (sys_read): Remove unused variable `err'.
6468 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6469 (w32_wnd_proc): Remove unused variable `isdead'.
6470 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6471 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6472 (x_create_tip_frame): Remove unused variable `tem'.
6474 * w32inevt.c (w32_console_read_socket):
6475 Remove unused variable `no_events'.
6477 * w32term.c (x_draw_composite_glyph_string_foreground):
6478 Remove unused variable `width'.
6480 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6482 * w32term.c (x_set_glyph_string_clipping):
6483 Don't pass uninitialized region to CombineRgn.
6485 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6487 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6488 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6489 (Fx_close_connection): Remove unused variable `i'.
6491 * w32font.c (w32font_draw): Return number of glyphs.
6492 (w32font_open_internal): Remove unused variable `i'.
6493 (w32font_driver): Add missing initializer.
6495 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6496 (fill_in_menu): Remove unused variable `items_added'.
6498 * w32term.c (last_mouse_press_frame): Remove static global variable.
6499 (w32_clip_to_row): Remove unused variable `f'.
6500 (x_delete_terminal): Remove unused variable `i'.
6502 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6503 (NOTHING): Remove unused static global variable.
6504 (uniscribe_check_otf): Remove unused variable `table'.
6505 (uniscribe_font_driver): Add missing initializers.
6507 2011-03-23 Julien Danjou <julien@danjou.info>
6509 * term.c (Fsuspend_tty, Fresume_tty):
6510 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6511 * window.c (temp_output_buffer_show):
6512 * insdel.c (signal_before_change):
6513 * frame.c (Fhandle_switch_frame):
6514 * fileio.c (Fdo_auto_save):
6515 * emacs.c (Fkill_emacs):
6516 * editfns.c (save_excursion_restore):
6517 * cmds.c (internal_self_insert):
6518 * callint.c (Fcall_interactively):
6519 * buffer.c (Fkill_all_local_variables):
6520 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6522 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6523 unconditionnaly since it does the check itself.
6525 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6527 Fix more problems found by GCC 4.5.2's static checks.
6529 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6530 the first time through the loop, since we know p0 < p1 then.
6531 This also avoids a gcc -Wstrict-overflow warning.
6533 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6534 leading to a memory leak, possible in functions like
6535 load_charset_map_from_file that can allocate an unbounded number
6536 of objects (Bug#8318).
6538 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6539 that could (at least in theory) be that large.
6541 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6542 This is less likely to overflow, and avoids undefined behavior if
6543 overflow does occur. All callers changed. Use strtoul to scan
6544 for the unsigned long integer.
6545 (pint2hrstr): Simplify and tune code slightly.
6546 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6548 * scroll.c (do_scrolling): Work around GCC bug 48228.
6549 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6551 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6552 This also avoids a warning with gcc -Wstrict-overflow.
6553 (validate_x_resource_name): Simplify count usage.
6554 This also avoids a warning with gcc -Wstrict-overflow.
6556 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6559 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6561 * process.c (Fmake_network_process): Use socklen_t, not int,
6562 where POSIX says socklen_t is required in portable programs.
6563 This fixes a porting bug on hosts like 64-bit HP-UX, where
6564 socklen_t is wider than int (Bug#8277).
6565 (Fmake_network_process, server_accept_connection):
6566 (wait_reading_process_output, read_process_output):
6569 * process.c: Rename or move locals to avoid shadowing.
6570 (list_processes_1, Fmake_network_process):
6571 (read_process_output_error_handler, exec_sentinel_error_handler):
6572 Rename or move locals.
6573 (Fmake_network_process): Define label "retry_connect" only if needed.
6574 (Fnetwork_interface_info): Fix pointer signedness.
6575 (process_send_signal): Add cast to avoid pointer signedness problem.
6576 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6577 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6579 Make tparam.h and terminfo.c consistent.
6580 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6581 Include tparam.h instead, since it declares them.
6582 * cm.h (PC): Remove extern decl; tparam.h now does this.
6583 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6584 * terminfo.c: Include tparam.h, to check interfaces.
6585 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6586 (tparam): Adjust signature to match interface in tparam.h;
6587 this removes some undefined behavior. Check that outstring and len
6588 are zero, which they always are with Emacs.
6589 * tparam.h (PC, BC, UP): New extern decls.
6591 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6592 (xftfont_open): Rename locals to avoid shadowing.
6594 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6595 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6596 (OTF_TAG_SYM): Omit macro if not needed.
6597 (ftfont_list): Remove unused local.
6598 (get_adstyle_property, ftfont_pattern_entity):
6599 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6600 Rename locals to avoid shadowing.
6602 * xfont.c (xfont_list_family): Mark var as initialized.
6604 * xml.c (make_dom): Now static.
6606 * composite.c (composition_compute_stop_pos): Rename local to
6608 (composition_reseat_it): Remove unused locals.
6609 (find_automatic_composition, composition_adjust_point): Likewise.
6610 (composition_update_it): Mark var as initialized.
6611 (find_automatic_composition): Mark vars as initialized,
6612 with a FIXME (Bug#8290).
6614 character.h: Rename locals to avoid shadowing.
6615 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6616 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6617 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6618 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6621 * textprop.c (property_change_between_p): Remove; unused.
6623 * intervals.c (interval_start_pos): Now static.
6625 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6627 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6628 Rename locals to avoid shadowing.
6630 * sound.c (wav_play, au_play, Fplay_sound_internal):
6631 Fix pointer signedness.
6632 (alsa_choose_format): Remove unused local var.
6633 (wav_play): Initialize a variable to 0, to prevent undefined
6634 behavior (Bug#8278).
6636 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6638 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6640 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6641 clobbering (Bug#8298).
6642 * sysdep.c (sys_subshell): Likewise.
6643 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6645 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6646 This should get cleaned up, so that child_setup has the
6647 same signature on all platforms.
6649 * callproc.c (call_process_cleanup): Now static.
6650 (relocate_fd): Rename locals to avoid shadowing.
6652 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6654 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6655 not to be necessary, and produces flickering.
6657 2011-03-20 Glenn Morris <rgm@gnu.org>
6659 * config.in: Remove file.
6661 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6663 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6664 are now in src/globals.h.
6665 (syms_of_minibuf): Remove spurious & from previous change.
6667 2011-03-20 Leo <sdl.web@gmail.com>
6669 * minibuf.c (completing-read-function): New variable.
6670 (completing-read-default): Rename from completing-read.
6671 (completing-read): Call completing-read-function.
6673 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6675 * xfaces.c (Fx_load_color_file):
6676 Read color file from absolute filename (bug#8250).
6678 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6680 * makefile.w32-in: Update dependencies.
6682 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6684 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6686 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6688 Fix more problems found by GCC 4.5.2's static checks.
6690 * process.c (make_serial_process_unwind, send_process_trap):
6691 (sigchld_handler): Now static.
6693 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6694 That way, the code declares only the vars that it needs.
6695 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6696 * s/cygwin.h (PTY_ITERATION): Likewise.
6697 * s/darwin.h (PTY_ITERATION): Likewise.
6698 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6700 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6701 * process.c (allocate_pty): Don't declare stb unless it's needed.
6703 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6704 (CONSTANTLIM): Remove; unused.
6705 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6706 Define only if needed.
6708 * unexelf.c (unexec): Name an expression,
6709 to avoid gcc -Wbad-function-cast warning.
6710 Use a different way to cause a compilation error if anyone uses
6711 n rather than nn, a way that does not involve shadowing.
6712 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6714 * deps.mk (unexalpha.o): Remove; unused.
6716 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6717 * unexec.h: New file.
6718 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6719 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6721 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6722 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6723 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6724 Change as necessary to match prototype in unexec.h.
6726 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6728 (back_comment, skip_chars): Mark vars as initialized.
6730 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6731 Rename locals to avoid shadowing.
6733 * lread.c (read1): Rewrite so as not to use empty "else".
6734 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6736 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6738 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6739 warning when compiling print.c.
6741 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6742 instead of using an uninitialized var.
6743 (font_sort_entities): Mark var as initialized.
6745 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6747 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6748 pointers to constants.
6749 (font_parse_fcname): Remove unused vars.
6750 (font_delete_unmatched): Now static.
6751 (font_get_spec): Remove; unused.
6752 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6753 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6754 Rename or move locals to avoid shadowing.
6756 * fns.c (require_nesting_list, require_unwind): Now static.
6757 (Ffillarray): Rename locals to avoid shadowing.
6759 * floatfns.c (domain_error2): Define only if needed.
6760 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6762 * alloc.c (mark_backtrace): Move decl from here ...
6763 * lisp.h: ... to here, so that it can be checked.
6765 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6766 (Fdefvar): Rewrite so as not to use empty "else".
6767 (lisp_indirect_variable): Name an expression,
6768 to avoid gcc -Wbad-function-cast warning.
6769 (Fdefvar): Rename locals to avoid shadowing.
6771 * callint.c (quotify_arg, quotify_args): Now static.
6772 (Fcall_interactively): Rename locals to avoid shadowing.
6773 Use const pointer when appropriate.
6775 * lisp.h (get_system_name, get_operating_system_release):
6776 Move decls here, to check interfaces.
6777 * process.c (get_operating_system_release): Move decl to lisp.h.
6778 * xrdb.c (get_system_name): Likewise.
6779 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6780 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6781 some of which prompt warnings from gcc -Wbad-function-cast.
6782 (Fformat_time_string, Fencode_time, Finsert_char):
6783 (Ftranslate_region_internal, Fformat):
6784 Rename or remove local vars to avoid shadowing.
6785 (Ftranslate_region_internal): Mark var as initialized.
6787 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6790 * lisp.h (eassert): Check that the argument compiles, even if
6791 ENABLE_CHECKING is not defined.
6793 * data.c (Findirect_variable): Name an expression, to avoid
6794 gcc -Wbad-function-cast warning.
6795 (default_value, arithcompare, arith_driver, arith_error): Now static.
6796 (store_symval_forwarding): Rename local to avoid shadowing.
6797 (Fmake_variable_buffer_local, Fmake_local_variable):
6798 Mark variables as initialized.
6799 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6801 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6802 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6803 Rename locals to avoid shadowing.
6804 (mark_stack): Move local variables into the #ifdef region where
6806 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6807 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6809 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6810 (GC_STRING_CHARS): Remove; not used.
6811 (Fmemory_limit): Cast sbrk's returned value to char *.
6813 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6814 avoids undefined behavior in theory.
6816 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6818 Use functions, not macros, for up- and down-casing (Bug#8254).
6819 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6820 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6821 to use the following functions instead of these macros.
6822 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6823 EMACS_INT, since callers assume the returned value fits in int.
6824 (upcase1): Likewise, for UPCASE_TABLE.
6825 (uppercasep, lowercasep, upcase): New static inline functions.
6826 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6827 the race-condition problem in the old DOWNCASE.
6829 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6830 Rename locals to avoid shadowing.
6831 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6832 (regex_compile, re_search_2, re_match_2_internal):
6833 Remove unused local vars.
6834 (FREE_VAR): Rewrite so as not to use empty "else",
6835 which gcc can warn about.
6836 (regex_compile, re_match_2_internal): Mark locals as initialized.
6837 (RETALLOC_IF): Define only if needed.
6838 (WORDCHAR_P): Likewise. This one is never needed, but is used
6839 only in a comment talking about a compiler bug, so put inside
6840 the #if 0 of that comment.
6841 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6842 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6845 * search.c (boyer_moore): Rename locals to avoid shadowing.
6846 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6847 (PREV_CHAR_BOUNDARY): Likewise.
6849 * search.c (simple_search): Remove unused var.
6851 * dired.c (compile_pattern): Move decl from here ...
6852 * lisp.h: ... to here, so that it can be checked.
6853 (struct re_registers): New forward decl.
6855 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6857 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6859 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6860 Rename locals to avoid shadowing.
6861 (Fvertical_motion): Mark locals as initialized.
6863 * casefiddle.c (casify_object, casify_region): Now static.
6864 (casify_region): Mark local as initialized.
6866 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6868 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6869 New macros, so that the caller can use some names other than
6870 gcpro1, gcpro2, etc.
6871 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6873 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6874 argument, for consistency with GCPRO2_VAR, etc: it is now the
6875 prefix of the variable, not the variable itself. All uses
6877 * dired.c (directory_files_internal, file_name_completion):
6878 Rename locals to avoid shadowing.
6880 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6881 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6882 dired.c's scmp function, had undefined behavior.
6883 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6884 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6885 * buffer.h: ... to here, because these macros use current_buffer,
6886 and the new implementation with inline functions needs to have
6887 current_buffer in scope now, rather than later when the macros
6889 (downcase, upcase1): New static inline functions.
6890 (DOWNCASE, UPCASE1): Reimplement using these functions.
6891 This avoids undefined behavior in expressions like
6892 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6893 from race conditions in accessing the global variables
6894 case_temp1 and case_temp2.
6895 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6896 * lisp.h (case_temp1, case_temp2): Remove their decls.
6897 * character.h (ASCII_CHAR_P): Move from here ...
6898 * lisp.h: ... to here, so that the inline functions mentioned
6901 * dired.c (directory_files_internal_unwind): Now static.
6903 * fileio.c (file_name_as_directory, directory_file_name):
6904 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6906 (file_name_as_directory): Use const pointers when appropriate.
6907 (Fexpand_file_name): Likewise. In particular, newdir might
6908 point at constant storage, so make it a const pointer.
6909 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6910 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6912 (Fset_file_times, Finsert_file_contents, auto_save_error):
6913 Rename locals to avoid shadowing.
6915 * minibuf.c (choose_minibuf_frame_1): Now static.
6916 (Ftry_completion, Fall_completions): Rename or remove locals
6919 * marker.c (bytepos_to_charpos): Remove; unused.
6921 * lisp.h (verify_bytepos, count_markers): New decls,
6922 so that gcc does not warn that these functions aren't declared.
6924 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6925 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6926 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6927 (copy_text): Remove unused local var.
6929 * filelock.c (within_one_second): Now static.
6930 (lock_file_1): Rename local to avoid shadowing.
6932 * buffer.c (fix_overlays_before): Mark locals as initialized.
6933 (fix_start_end_in_overlays): Likewise. This function should be
6934 simplified by using pointers-to-pointers, but that's a different
6936 (switch_to_buffer_1): Now static.
6937 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6938 (report_overlay_modification): Rename locals to avoid shadowing.
6940 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6941 Fix pointer signedness issue.
6942 (sys_subshell): Mark local as volatile if checking for lint,
6943 to suppress a gcc -Wclobbered warning that does not seem to be right.
6944 (MAXPATHLEN): Define only if needed.
6946 * process.c (serial_open, serial_configure): Move decls from here ...
6947 * systty.h: ... to here, so that they can be checked.
6949 * fns.c (get_random, seed_random): Move extern decls from here ...
6950 * lisp.h: ... to here, so that they can be checked.
6952 * sysdep.c (reset_io): Now static.
6953 (wait_for_termination_signal): Remove; unused.
6955 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6956 (copy_keymap_item, append_key, push_text_char_description):
6958 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6959 (DENSE_TABLE_SIZE): Remove; unused.
6960 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6961 (describe_map_tree):
6962 Rename locals to avoid shadowing.
6964 * keyboard.c: Declare functions static if they are not used elsewhere.
6965 (echo_char, echo_dash, cmd_error, top_level_2):
6966 (poll_for_input, handle_async_input): Now static.
6967 (read_char, kbd_buffer_get_event, make_lispy_position):
6968 (make_lispy_event, make_lispy_movement, apply_modifiers):
6969 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6970 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6971 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6972 (read_key_sequence, read_char): Mark locals as initialized.
6973 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6975 * keyboard.h (make_ctrl_char): New decl.
6976 (mark_kboards): Move decl here ...
6977 * alloc.c (mark_kboards): ... from here.
6979 * lisp.h (force_auto_save_soon): New decl.
6981 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6982 (DEFINE_DUMMY_FUNCTION): New macro.
6983 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6985 (main): Add casts to avoid warnings
6986 if GCC considers string literals to be constants.
6988 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6990 * dbusbind.c: Pointer signedness fixes.
6991 (xd_signature, xd_append_arg, xd_initialize):
6992 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6993 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6994 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6995 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6997 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6998 if GCC considers string literals to be constants.
6999 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7001 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7003 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7004 (print_preprocess, print_object): New macro to fix last change.
7006 * print.c (print_preprocess): Don't forget font objects.
7008 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7010 * emacs.c (USAGE3): Doc fixes.
7012 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7014 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7017 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7019 * lisp.h (VWindow_system, Qfile_name_history):
7020 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7021 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7022 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7024 * w32select.c: Don't #include "keyboard.h".
7025 (run_protected): Add extern declaration for waiting_for_input.
7027 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7028 * w32console.c (detect_input_pending, read_input_pending)
7029 (encode_terminal_code):
7030 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7031 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7032 (w32_system_caret_y, Qfile_name_history):
7033 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7034 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7035 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7036 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7037 * w32proc.c (Qlocal, report_file_error):
7038 * w32term.c (Vwindow_system, updating_frame):
7039 * w32uniscribe.c (initialized, uniscribe_font_driver):
7040 Remove unneeded extern declarations.
7042 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7044 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7046 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7048 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7049 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7050 These macros can no longer be used for assignment.
7052 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7053 Assign struct members directly, instead of using BUF_BEGV etc.
7054 (record_buffer_markers, fetch_buffer_markers): New functions for
7055 recording and fetching special buffer markers.
7056 (set_buffer_internal_1, set_buffer_temp): Use them.
7058 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7060 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7062 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7063 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7065 * xdisp.c (hscroll_window_tree):
7066 (reconsider_clip_changes): Use PT instead of BUF_PT.
7068 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7070 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7071 $(EMACS_ROOT)/lib/intprops.h.
7073 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7075 Fix more problems found by GCC 4.5.2's static checks.
7077 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7078 to unsigned char * to avoid compiler diagnostic.
7079 (xg_free_frame_widgets): Make it clear that a local variable is
7080 needed only if USE_GTK_TOOLTIP.
7081 (gdk_window_get_screen): Make it clear that this macro is needed
7082 only if USE_GTK_TOOLTIP.
7083 (int_gtk_range_get_value): New function, which avoids a diagnostic
7084 from gcc -Wbad-function-cast.
7085 (xg_set_toolkit_scroll_bar_thumb): Use it.
7086 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7087 diagnostic from gcc -Wbad-function-cast.
7088 (get_utf8_string, xg_get_file_with_chooser):
7089 Rename locals to avoid shadowing.
7090 (create_dialog): Move locals to avoid shadowing.
7092 * xgselect.c (xg_select): Remove unused var.
7094 * image.c (four_corners_best): Mark locals as initialized.
7095 (gif_load): Initialize transparent_p to zero (Bug#8238).
7096 Mark another local as initialized.
7097 (my_png_error, my_error_exit): Mark with NO_RETURN.
7099 * image.c (clear_image_cache): Now static.
7100 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7101 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7102 (x_edge_detection): Remove unnecessary cast that
7103 gcc -Wbad-function-cast diagnoses.
7104 (gif_load): Fix pointer signedness.
7105 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7106 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7108 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7110 Improve quality of tests for time stamp overflow.
7111 For example, without this patch (encode-time 0 0 0 1 1
7112 1152921504606846976) returns the obviously-bogus value (-948597
7113 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7114 reports time overflow. See
7115 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7116 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7117 * editfns.c: Include limits.h and intprops.h.
7118 (TIME_T_MIN, TIME_T_MAX): New macros.
7119 (time_overflow): Move earlier, to before first use.
7120 (hi_time, lo_time): New functions, for an accurate test for
7122 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7123 (Fget_internal_run_time): Don't assume time_t fits in int.
7124 (make_time): Use list2 instead of Fcons twice.
7125 (Fdecode_time): More accurate test for out-of-range times.
7126 (check_tm_member): New function.
7127 (Fencode_time): Use it, to test for out-of-range times.
7128 (lisp_time_argument): Don't rely on undefined left-shift and
7129 right-shift behavior when checking for time stamp overflow.
7131 * editfns.c (time_overflow): New function, refactoring common code.
7132 (Fformat_time_string, Fdecode_time, Fencode_time):
7133 (Fcurrent_time_string): Use it.
7135 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7136 * dired.c (make_time): Move to ...
7137 * editfns.c (make_time): ... here.
7138 * systime.h: Note the move.
7140 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7142 * fringe.c (update_window_fringes): Remove unused variables.
7144 * unexmacosx.c (copy_data_segment): Also copy __got section.
7147 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7149 * termcap.c [MSDOS]: Include "msdos.h".
7150 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7151 Constify `char *' arguments and their references according to
7152 prototypes in tparam.h.
7154 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7156 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7157 Adapt all references accordingly.
7159 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7161 2011-03-11 Tom Tromey <tromey@redhat.com>
7163 * buffer.c (syms_of_buffer): Remove obsolete comment.
7165 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7167 * termhooks.h (encode_terminal_code): Declare prototype.
7169 * msdos.c (encode_terminal_code): Don't declare prototype.
7171 * term.c (encode_terminal_code): Now external again, used by
7172 w32console.c and msdos.c.
7174 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7175 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7177 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7179 Fix some minor problems found by GCC 4.5.2's static checks.
7181 * fringe.c (update_window_fringes): Mark locals as initialized
7183 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7185 * alloc.c (mark_fringe_data): Move decl from here ...
7186 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7187 to check its interface.
7188 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7190 * fontset.c (free_realized_fontset): Now static.
7191 (Fset_fontset_font): Rename local to avoid shadowing.
7192 (fontset_font): Mark local as initialized.
7193 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7195 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7197 * xselect.c (x_disown_buffer_selections): Remove; not used.
7198 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7199 (x_own_selection, Fx_disown_selection_internal): Rename locals
7201 (x_handle_dnd_message): Remove local to avoid shadowing.
7203 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7204 so that the caller can use some name other than gcpro1.
7205 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7206 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7207 (Fx_backspace_delete_keys_p):
7208 Use them to avoid shadowing, and rename vars to avoid shadowing.
7209 (x_decode_color, x_set_name, x_window): Now static.
7210 (Fx_create_frame): Add braces to silence GCC warning.
7211 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7212 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7213 Remove unused locals.
7214 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7215 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7216 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7219 * xterm.h (x_mouse_leave): New decl.
7221 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7222 Remove unused functions.
7223 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7224 (x_calc_absolute_position): Now static.
7225 (XTread_socket): Don't define label "out" unless it's used.
7226 Don't declare local "event" unless it's used.
7227 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7228 unless they are used.
7229 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7230 (x_fatal_error_signal): Remove; not used.
7231 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7232 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7233 (x_error_catcher, x_connection_closed, x_error_handler):
7234 (x_error_quitter, xembed_send_message, x_iconify_frame):
7235 (my_log_handler): Rename locals to avoid shadowing.
7236 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7237 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7239 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7240 Rename or move locals to avoid shadowing.
7241 (tty_defined_color, merge_face_heights): Now static.
7242 (free_realized_faces_for_fontset): Remove; not used.
7243 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7244 does not deduce is never used uninitialized.
7245 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7246 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7248 * terminal.c (store_terminal_param): Now static.
7250 * xmenu.c (menu_highlight_callback): Now static.
7251 (set_frame_menubar): Remove unused local.
7252 (xmenu_show): Rename parameter to avoid shadowing.
7253 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7254 since they might point to immutable storage.
7255 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7256 since it's unused otherwise.
7258 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7259 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7260 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7261 avoids a gcc -Wuninitialized diagnostic.
7262 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7263 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7264 does not deduce are never used uninitialized.
7266 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7268 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7269 * window.c (window_loop, size_window):
7270 (run_window_configuration_change_hook, enlarge_window): Likewise.
7272 * window.c (display_buffer): Now static.
7273 (size_window): Mark variables that gcc -Wuninitialized
7274 does not deduce are never used uninitialized.
7275 * window.h (check_all_windows): New decl, to forestall
7276 gcc -Wmissing-prototypes diagnostic.
7277 * dispextern.h (bidi_dump_cached_states): Likewise.
7279 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7281 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7283 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7284 and to avoid gcc -Wuninitialized warning.
7285 (load_charset_map): Mark variables that gcc -Wuninitialized
7286 does not deduce are never used uninitialized.
7287 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7289 * coding.c (coding_set_source, coding_set_destination):
7290 Use "else { /* comment */ }" rather than "else /* comment */;"
7291 for clarity, and to avoid gcc -Wempty-body warning.
7292 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7293 a block, when the outer 'i' will do.
7294 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7295 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7296 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7297 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7298 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7299 Rename locals to avoid shadowing.
7300 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7301 * coding.c (emacs_mule_char, encode_invocation_designation):
7302 Now static, since they're not used elsewhere.
7303 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7304 (decode_coding_object, encode_coding_object, detect_coding_system):
7305 (decode_coding_emacs_mule): Mark variables that gcc
7306 -Wuninitialized does not deduce are never used uninitialized.
7307 (detect_coding_iso_2022): Initialize a local variable that might
7308 be used uninitialized. Leave a FIXME because it's not clear that
7309 this initialization is needed. (Bug#8211)
7310 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7311 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7312 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7313 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7314 Remove unused macros.
7316 * category.c (hash_get_category_set): Remove unused local var.
7317 (copy_category_table): Now static, since it's not used elsewhere.
7318 * character.c (string_count_byte8): Likewise.
7320 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7321 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7323 * chartab.c (copy_sub_char_table): Now static, since it's not used
7325 (sub_char_table_ref_and_range, char_table_ref_and_range):
7326 Rename locals to avoid shadowing.
7327 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7329 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7330 (BIDI_BOB): Remove unused macro.
7332 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7333 deduce are never used uninitialized.
7334 * term.c (encode_terminal_code): Likewise.
7336 * term.c (encode_terminal_code): Now static. Remove unused local.
7338 * tparam.h: New file.
7339 * term.c, tparam.h: Include it.
7340 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7341 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7342 Move these decls to tparam.h, and make them agree with what
7343 is actually in tparam.c. The previous trick of using incompatible
7344 decls in different modules does not conform to the C standard.
7345 All callers of tparam changed to use tparam's actual API.
7346 * tparam.c (tparam1, tparam, tgoto):
7347 Use const pointers where appropriate.
7349 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7350 * cm.h (struct cm): Likewise.
7351 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7352 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7353 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7354 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7355 (turn_on_face, init_tty): Likewise.
7356 * termchar.h (struct tty_display_info): Likewise.
7358 * term.c (term_mouse_position): Rename local to avoid shadowing.
7360 * alloc.c (mark_ttys): Move decl from here ...
7361 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7363 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7365 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7367 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7369 * search.c (compile_pattern_1): Remove argument regp, unused since
7370 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7371 (compile_pattern): Don't pass it.
7373 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7375 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7376 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7378 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7380 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7382 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7383 gdk_window_get_screen, gdk_window_get_geometry,
7384 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7385 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7386 (xg_get_pixbuf_from_pixmap): New function.
7387 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7388 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7389 Call xg_get_pixbuf_from_pixmap instead of
7390 gdk_pixbuf_get_from_drawable.
7391 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7392 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7393 (xg_check_special_colors): Use GtkStyleContext and its functions
7395 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7396 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7397 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7398 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7399 Call gtk_widget_get_preferred_size.
7400 (xg_frame_resized): gdk_window_get_geometry only takes 5
7402 (xg_win_to_widget, xg_event_is_for_menubar):
7403 Call gdk_x11_window_lookup_for_display.
7404 (xg_set_widget_bg): New function.
7405 (delete_cb): New function.
7406 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7407 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7408 (xg_set_background_color): Call xg_set_widget_bg.
7409 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7410 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7411 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7412 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7414 (update_frame_tool_bar): Call gtk_widget_hide.
7415 (xg_initialize): Use GDK_KEY_g.
7417 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7419 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7421 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7422 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7423 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7425 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7427 * w32xfns.c (select_palette): Check success of RealizePalette against
7428 GDI_ERROR, not zero.
7430 See ChangeLog.11 for earlier changes.
7436 Copyright (C) 2011 Free Software Foundation, Inc.
7438 This file is part of GNU Emacs.
7440 GNU Emacs is free software: you can redistribute it and/or modify
7441 it under the terms of the GNU General Public License as published by
7442 the Free Software Foundation, either version 3 of the License, or
7443 (at your option) any later version.
7445 GNU Emacs is distributed in the hope that it will be useful,
7446 but WITHOUT ANY WARRANTY; without even the implied warranty of
7447 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7448 GNU General Public License for more details.
7450 You should have received a copy of the GNU General Public License
7451 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.