Extend `call-process' to take the `(:file "file")' syntax to redirect
[bpt/emacs.git] / src / ChangeLog
1 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * sysdep.c (interruptible_wait_for_termination): New function
4 which is like wait_for_termination, but allows keyboard
5 interruptions.
6
7 * callproc.c (Fcall_process): Add (:file "file") as an option for
8 the STDOUT buffer.
9 (Fcall_process_region): Ditto.
10
11 2011-04-30 Eli Zaretskii <eliz@gnu.org>
12
13 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
14 rather than `XVECTOR (FOO)->size'.
15
16 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
17 inttypes.h, as a gnulib replacement is used if it not available in
18 system headers.
19
20 2011-04-21 Eli Zaretskii <eliz@gnu.org>
21
22 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
23 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
24 of MOST_POSITIVE_FIXNUM. (Bug#8528)
25
26 * coding.c (coding_alloc_by_realloc): Error out if destination
27 will grow beyond MOST_POSITIVE_FIXNUM.
28 (decode_coding_emacs_mule): Abort if there isn't enough place in
29 charbuf for the composition carryover bytes. Reserve an extra
30 space for up to 2 characters produced in a loop.
31 (decode_coding_iso_2022): Abort if there isn't enough place in
32 charbuf for the composition carryover bytes.
33
34 2011-04-21 Eli Zaretskii <eliz@gnu.org>
35
36 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
37 aborting when %lld or %lll format is passed.
38 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
39 %llo or %llx format is passed. (Bug#8545)
40
41 * window.c (window_scroll_line_based): Use a marker instead of
42 simple variables to record original value of point. (Bug#7952)
43
44 * doprnt.c (doprnt): Fix the case where a multibyte sequence
45 produced by %s or %c overflows available buffer space. (Bug#8545)
46
47 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
48
49 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
50 (SIZE_MAX): Move defn after all includes, as they might #define it.
51
52 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
53
54 * w32.c (init_environment): Warn about defaulting HOME to C:\.
55
56 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
57
58 * keyboard.c (Qdelayed_warnings_hook): Define.
59 (command_loop_1): Run `delayed-warnings-hook'
60 if Vdelayed_warnings_list is non-nil.
61 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
62 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
63
64 2011-04-28 Eli Zaretskii <eliz@gnu.org>
65
66 * doprnt.c (doprnt): Don't return value smaller than the buffer
67 size if the message was truncated. (Bug#8545).
68
69 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
70
71 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
72 (Fx_window_property): #if-0 the whole functions, not just the bodies.
73
74 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
75
76 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
77
78 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
79
80 * makefile.w32-in: Update dependencies.
81
82 2011-04-27 Eli Zaretskii <eliz@gnu.org>
83
84 Improve `doprnt' and its usage. (Bug#8545)
85 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
86 `format_end'. Remove support for %l as a conversion specifier.
87 Don't use xrealloc. Improve diagnostics when the %l size modifier
88 is used. Update the commentary.
89
90 * eval.c (verror): Simplify calculation of size_t.
91
92 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
93 messages.
94
95 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
96
97 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
98 change.
99
100 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
101
102 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
103 This makes this file independent of the recent pseudovector change.
104
105 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
106
107 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
108
109 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
110 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
111 Remove unused local.
112 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
113
114 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
115 GCC 4.6.0 optimizes based on type-based alias analysis. For
116 example, if b is of type struct buffer * and v of type struct
117 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
118 != &v->size, and therefore "v->size = 1; b->size = 2; return
119 v->size;" must therefore return 1. This assumption is incorrect
120 for Emacs, since it type-puns struct Lisp_Vector * with many other
121 types. To fix this problem, this patch adds a new type struct
122 vectorlike_header that documents the constraints on layout of vectors
123 and pseudovectors, and helps optimizing compilers not get fooled
124 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
125 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
126 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
127 the size member.
128 (XSETPVECTYPE): Rewrite in terms of new macro.
129 (XSETPVECTYPESIZE): New macro, specifying both type and size.
130 This is a bit clearer, and further avoids the possibility of
131 undesirable aliasing.
132 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
133 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
134 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
135 since Lisp_Subr is a special case (no "next" field).
136 (ASIZE): Now uses header.size rather than size. All
137 previous uses of XVECTOR (foo)->size replaced to use this macro,
138 to avoid the hassle of writing XVECTOR (foo)->header.size.
139 (struct vectorlike_header): New type.
140 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
141 object, to help avoid aliasing.
142 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
143 (SUBRP): Likewise, since Lisp_Subr is a special case.
144 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
145 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
146 (struct Lisp_Hash_Table): Combine first two members into a single
147 struct vectorlike_header member. All uses of "size" and "next" members
148 changed to be "header.size" and "header.next".
149 * buffer.h (struct buffer): Likewise.
150 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
151 * frame.h (struct frame): Likewise.
152 * process.h (struct Lisp_Process): Likewise.
153 * termhooks.h (struct terminal): Likewise.
154 * window.c (struct save_window_data, struct saved_window): Likewise.
155 * window.h (struct window): Likewise.
156 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
157 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
158 * buffer.c (init_buffer_once): Likewise.
159 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
160 special case.
161 * process.c (Fformat_network_address): Use local var for size,
162 for brevity.
163
164 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
165
166 Make the Lisp reader and string-to-float more consistent (Bug#8525)
167 * data.c (atof): Remove decl; no longer used or needed.
168 (digit_to_number): Move to lread.c.
169 (Fstring_to_number): Use new string_to_number function, to be
170 consistent with how the Lisp reader treats infinities and NaNs.
171 Do not assume that floating-point numbers represent EMACS_INT
172 without losing information; this is not true on most 64-bit hosts.
173 Avoid double-rounding errors, by insisting on integers when
174 parsing non-base-10 numbers, as the documentation specifies.
175 * lisp.h (string_to_number): New decl, replacing ...
176 (isfloat_string): Remove.
177 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
178 (read1): Do not accept +. and -. as integers; this
179 appears to have been a coding error. Similarly, do not accept
180 strings like +-1e0 as floating point numbers. Do not report
181 overflow for integer overflows unless the base is not 10 which
182 means we have no simple and reliable way to continue.
183 Break out the floating-point parsing into a new
184 function string_to_number, so that Fstring_to_number parses
185 floating point numbers consistently with the Lisp reader.
186 (digit_to_number): Moved here from data.c. Make it static inline.
187 (E_CHAR, EXP_INT): Remove, replacing with ...
188 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
189 (string_to_number): New function, replacing isfloat_string.
190 This function checks for valid syntax and produces the resulting
191 Lisp float number too. Rework it so that string-to-number
192 no longer mishandles examples like "1.0e+". Use strtoumax,
193 so that overflow for non-base-10 numbers is reported only when
194 there's no portable and simple way to convert to floating point.
195
196 * textprop.c (set_text_properties_1): Rewrite for clarity,
197 and to avoid GCC warning about integer overflow.
198
199 * intervals.h (struct interval): Use EMACS_INT for members
200 where EMACS_UINT might cause problems. See
201 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
202 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
203 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
204 All uses changed.
205 (offset_intervals): Tell GCC not to worry about length overflow
206 when negating a negative length.
207
208 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
209 (overrun_check_free): Likewise.
210
211 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
212 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
213 word size.
214
215 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
216 (gnutls_make_error): Rename local to avoid shadowing.
217 (gnutls_emacs_global_deinit): ifdef out; not used.
218 (Fgnutls_boot): Use const for pointer to readonly storage.
219 Comment out unused local. Fix pointer signedness problems.
220
221 * lread.c (openp): Don't stuff size_t into an 'int'.
222 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
223 about possible signed overflow.
224
225 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
226 (GDK_KEY_g): Don't define if already defined.
227 (xg_prepare_tooltip): Avoid pointer signedness problem.
228 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
229
230 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
231 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
232
233 * xfns.c (Fx_window_property): Simplify a bit,
234 to make a bit faster and to avoid GCC 4.6.0 warning.
235 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
236
237 * fns.c (internal_equal): Don't assume size_t fits in int.
238
239 * alloc.c (compact_small_strings): Tighten assertion a little.
240
241 Replace pEd with more-general pI, and fix some printf arg casts.
242 * lisp.h (pI): New macro, generalizing old pEd macro to other
243 conversion specifiers. For example, use "...%"pI"d..." rather
244 than "...%"pEd"...".
245 (pEd): Remove. All uses replaced with similar uses of pI.
246 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
247 * alloc.c (check_pure_size): Don't overflow by converting size to int.
248 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
249 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
250 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
251 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
252 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
253 64-bit hosts.
254 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
255 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
256 * print.c (safe_debug_print, print_object): Likewise.
257 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
258 to int.
259 Use pI instead of if-then-else-abort. Use %p to avoid casts,
260 avoiding the 0 flag, which is not portable.
261 * process.c (Fmake_network_process): Use pI to avoid cast.
262 * region-cache.c (pp_cache): Likewise.
263 * xdisp.c (decode_mode_spec): Likewise.
264 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
265 behavior on 64-bit hosts with printf arg.
266 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
267 (x_stop_queuing_selection_requests): Likewise.
268 (x_get_window_property): Don't truncate byte count to an 'int'
269 when tracing.
270
271 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
272 here, since it parses constructs like leading '-' and spaces,
273 which are not wanted; and it overflows with large numbers.
274 Instead, simply match F[0-9]+, which is what is wanted anyway.
275
276 * alloc.c: Remove unportable assumptions about struct layout.
277 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
278 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
279 (allocate_vectorlike, make_pure_vector): Use the new macros,
280 plus offsetof, to remove unportable assumptions about struct layout.
281 These assumptions hold on all porting targets that I know of, but
282 they are not guaranteed, they're easy to remove, and removing them
283 makes further changes easier.
284
285 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
286 This doesn't fix a bug but makes the code clearer.
287 (string_overrun_cookie): Now const. Use initializers that
288 don't formally overflow signed char, to avoid warnings.
289 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
290 can cause Emacs to crash when string overrun checking is enabled.
291 (allocate_buffer): Don't assume sizeof (struct buffer) is a
292 multiple of sizeof (EMACS_INT); it need not be, if
293 alignof(EMACS_INT) < sizeof (EMACS_INT).
294 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
295
296 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
297
298 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
299
300 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
301
302 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
303 supposed to be handshaking. (Bug#8556)
304 Reported by Paul Eggert <eggert@cs.ucla.edu>.
305
306 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
307
308 * lisp.h (Qdebug): List symbol.
309 * eval.c (Qdebug): Restore global linkage.
310 * keyboard.c (debug-on-event): New variable.
311 (handle_user_signal): Break into debugger when debug-on-event
312 matches the current signal symbol.
313
314 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
315
316 * alloc.c (check_sblock, check_string_bytes)
317 (check_string_free_list): Convert to standard C.
318
319 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
320
321 * w32.c (emacs_gnutls_push): Fix typo.
322
323 2011-04-25 Eli Zaretskii <eliz@gnu.org>
324
325 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
326 "cast to pointer from integer of different size".
327
328 Improve doprnt and its use in verror. (Bug#8545)
329 * doprnt.c (doprnt): Document the set of format control sequences
330 supported by the function. Use SAFE_ALLOCA instead of always
331 using `alloca'.
332
333 * eval.c (verror): Don't limit the buffer size at size_max-1, that
334 is one byte too soon. Don't use xrealloc; instead xfree and
335 xmalloc anew.
336
337 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
338
339 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
340 callbacks stage.
341
342 * gnutls.c: Renamed global_initialized to
343 gnutls_global_initialized. Added internals for the
344 :verify-hostname-error, :verify-error, and :verify-flags
345 parameters of `gnutls-boot' and documented those parameters in the
346 docstring. Start callback support.
347 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
348 unless a fatal error occured. Call gnutls_alert_send_appropriate
349 on error. Return error code.
350 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
351 (emacs_gnutls_read): Likewise.
352 (Fgnutls_boot): Return handshake error code.
353 (emacs_gnutls_handle_error): New function.
354 (wsaerror_to_errno): Likewise.
355
356 * w32.h (emacs_gnutls_pull): Add prototype.
357 (emacs_gnutls_push): Likewise.
358
359 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
360 (emacs_gnutls_push): Likewise.
361
362 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
363
364 * process.c (wait_reading_process_output): Check if GnuTLS
365 buffered some data internally if no FDs are set for TLS
366 connections.
367
368 * makefile.w32-in (OBJ2): Add gnutls.$(O).
369 (LIBS): Link to USER_LIBS.
370 ($(BLD)/gnutls.$(0)): New target.
371
372 2011-04-24 Eli Zaretskii <eliz@gnu.org>
373
374 * xdisp.c (handle_single_display_spec): Rename the
375 display_replaced_before_p argument into display_replaced_p, to
376 make it consistent with the commentary. Fix typos in the
377 commentary.
378
379 * textprop.c (syms_of_textprop): Remove dead code.
380 (copy_text_properties): Delete obsolete commentary about an
381 interface that was deleted long ago. Fix typos in the description
382 of arguments.
383
384 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
385 to changes in oldXMenu/XMenu.h from 2011-04-16.
386 <menu_help_message, prev_menu_help_message>: Constify.
387 (IT_menu_make_room): menu->help_text is now `const char **';
388 adjust.
389
390 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
391 to changes in oldXMenu/XMenu.h from 2011-04-16.
392 (struct XMenu): Declare `help_text' `const char **'.
393
394 * xfaces.c <Qunspecified>: Make extern again.
395
396 * syntax.c: Include sys/types.h before including regex.h, as
397 required by Posix.
398
399 * doc.c (get_doc_string): Improve the format passed to `error'.
400
401 * doprnt.c (doprnt): Improve commentary.
402
403 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
404
405 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
406 them with etags.
407
408 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
409 changes in globals.h immediately force recompilation.
410 (TAGS): Depend on $(CURDIR)/m/intel386.h and
411 $(CURDIR)/s/ms-w32.h.
412 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
413
414 * character.c (Fchar_direction): Function deleted.
415 (syms_of_character): Don't defsubr it.
416 <char-direction-table>: Deleted.
417
418 2011-04-23 Eli Zaretskii <eliz@gnu.org>
419
420 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
421 * doprnt.c: Include limits.h.
422 (SIZE_MAX): New macro.
423 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
424 local variables are now size_t instead of int or unsigned.
425 Improve overflow protection. Support `l' modifier for integer
426 conversions. Support %l conversion. Don't assume an EMACS_INT
427 argument for integer conversions and for %c.
428
429 * lisp.h (doprnt): Restore prototype.
430
431 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
432 $(SRC)/character.h.
433
434 * Makefile.in (base_obj): Add back doprnt.o.
435
436 * deps.mk (doprnt.o): Add back prerequisites.
437 (callint.o): Depend on character.h.
438
439 * eval.c (internal_lisp_condition_case): Include the handler
440 representation in the error message.
441 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
442 when breaking from the loop.
443
444 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
445
446 * callint.c (Fcall_interactively): When displaying error message
447 about invalid control letter, pass the character's codepoint, not
448 a pointer to its multibyte form. Improve display of the character
449 in octal and display also its hex code.
450
451 * character.c (char_string): Use %x to display the (unsigned)
452 codepoint of an invalid character, to avoid displaying a bogus
453 negative value.
454
455 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
456 `error', not SYMBOL_NAME itself.
457
458 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
459 character arguments to `error'.
460
461 * charset.c (check_iso_charset_parameter): Fix incorrect argument
462 to `error' in error message about FINAL_CHAR argument. Make sure
463 FINAL_CHAR is a character, and use %c when it is passed as
464 argument to `error'.
465
466 2011-04-23 Eli Zaretskii <eliz@gnu.org>
467
468 * s/ms-w32.h (localtime): Redirect to sys_localtime.
469
470 * w32.c: Include <time.h>.
471 (sys_localtime): New function.
472
473 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
474
475 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
476
477 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
478
479 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
480
481 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
482 zombies (Bug#8467).
483
484 2011-04-19 Eli Zaretskii <eliz@gnu.org>
485
486 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
487 gl_state.e_property when gl_state.object is Qt.
488
489 * insdel.c (make_gap_larger): Remove limitation of buffer size
490 to <= INT_MAX.
491
492 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
493
494 * xdisp.c (lookup_glyphless_char_display)
495 (produce_glyphless_glyph): Handle cons cell entry in
496 glyphless-char-display.
497 (Vglyphless_char_display): Document it.
498
499 * term.c (produce_glyphless_glyph): Handle cons cell entry in
500 glyphless-char-display.
501
502 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
503
504 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
505
506 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
507
508 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
509 definition for no-X builds.
510
511 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
512
513 Static checks with GCC 4.6.0 and non-default toolkits.
514
515 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
516
517 * process.c (keyboard_bit_set): Define only if SIGIO.
518 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
519 (send_process): Repair possible setjmp clobbering.
520
521 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
522
523 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
524
525 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
526
527 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
528 Define only if needed.
529
530 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
531 by pacifying GCC about it. Maybe it's time to retire it?
532 * xfaces.c (USG, __TIMEVAL__): Likewise.
533
534 * dispextern.h (struct redisplay_interface): Rename param
535 to avoid shadowing.
536 * termhooks.h (struct terminal): Likewise.
537 * xterm.c (xembed_send_message): Likewise.
538
539 * insdel.c (make_gap_smaller): Define only if
540 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
541
542 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
543 it.
544
545 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
546 so that we aren't warned about unused symbols.
547
548 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
549
550 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
551
552 * xfns.c (x_real_positions): Mark locals as initialized.
553
554 * xmenu.c (xmenu_show): Don't use uninitialized vars.
555
556 * xterm.c: Fix problems found by static analysis with other toolkits.
557 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
558 (x_dispatch_event): Declare static if USE_GTK, and
559 define if USE_GTK || USE_X_TOOLKIT.
560 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
561 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
562 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
563 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
564
565 * xmenu.c (menu_help_callback): Pointer type fixes.
566 Use const pointers when pointing at readonly data. Avoid pointer
567 signedness clashes.
568 (FALSE): Remove unused macro.
569 (update_frame_menubar): Remove unused decl.
570
571 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
572
573 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
574 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
575 (single_menu_item): Rename local to avoid shadowing.
576
577 * keyboard.c (make_lispy_event): Remove unused local var.
578
579 * frame.c, frame.h (x_get_resource_string): Bring this back, but
580 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
581
582 * bitmaps: Change bitmaps from unsigned char back to the X11
583 compatible char. Avoid the old compiler warnings about
584 out-of-range initializers by using, for example, '\xab' rather
585 than 0xab.
586
587 * xgselect.c (xgselect_initialize): Check vs interface
588 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
589
590 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
591
592 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
593 to read-only memory.
594
595 * fns.c (vector): Remove; this old hack is no longer needed.
596
597 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
598 Remove unused var.
599 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
600
601 * xrdb.c (x_load_resources): Omit unused local.
602
603 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
604 (x_window): Rename locals to avoid shadowing.
605 (USG): Use the kludged USG macro, to pacify gcc.
606
607 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
608 (x_term_init): Remove local to avoid shadowing.
609
610 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
611
612 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
613 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
614
615 2011-04-16 Eli Zaretskii <eliz@gnu.org>
616
617 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
618
619 Fix regex.c, syntax.c and friends for buffers > 2GB.
620 * syntax.h (struct gl_state_s): Declare character position members
621 EMACS_INT.
622
623 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
624
625 * textprop.c (verify_interval_modification, interval_of): Declare
626 arguments EMACS_INT.
627
628 * intervals.c (adjust_intervals_for_insertion): Declare arguments
629 EMACS_INT.
630
631 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
632
633 * indent.c (Fvertical_motion): Local variable it_start is now
634 EMACS_INT.
635
636 * regex.c (re_match, re_match_2, re_match_2_internal)
637 (bcmp_translate, regcomp, regexec, print_double_string)
638 (group_in_compile_stack, re_search, re_search_2, regex_compile)
639 (re_compile_pattern, re_exec): Declare arguments and local
640 variables `size_t' and `ssize_t' and return values `regoff_t', as
641 appropriate.
642 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
643 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
644 <compile_stack_type>: `size' and `avail' are now `size_t'.
645
646 * regex.h <regoff_t>: Use ssize_t, not int.
647 (re_search, re_search_2, re_match, re_match_2): Arguments that
648 specify buffer/string position and length are now ssize_t and
649 size_t. Return type is regoff_t.
650
651 2011-04-16 Ben Key <bkey76@gmail.com>
652
653 * nsfont.m: Fixed bugs in ns_get_family and
654 ns_descriptor_to_entity that were caused by using free to
655 deallocate memory blocks that were allocated by xmalloc (via
656 xstrdup). This caused Emacs to crash when compiled with
657 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
658 --enable-checking=xmallocoverrun). xfree is now used to
659 deallocate these memory blocks.
660
661 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
662
663 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
664
665 emacs_write: Accept and return EMACS_INT for sizes.
666 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
667 et seq.
668 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
669 Accept and return EMACS_INT.
670 (emacs_gnutls_write): Return the number of bytes written on
671 partial writes.
672 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
673 (emacs_read, emacs_write): Remove check for negative size, as the
674 Emacs source code has been audited now.
675 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
676 (emacs_read, emacs_write): Use it.
677 * process.c (send_process): Adjust to the new signatures of
678 emacs_write and emacs_gnutls_write. Do not attempt to store
679 a byte offset into an 'int'; it might overflow.
680 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
681
682 * sound.c: Don't assume sizes fit in 'int'.
683 (struct sound_device.period_size, alsa_period_size):
684 Return EMACS_INT, not int.
685 (struct sound_device.write, vox_write, alsa_write):
686 Accept EMACS_INT, not int.
687 (wav_play, au_play): Use EMACS_INT to store sizes and to
688 record read return values.
689
690 2011-04-15 Ben Key <bkey76@gmail.com>
691
692 * keyboard.c (Qundefined): Don't declare static since it is used
693 in nsfns.m.
694 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
695 static since they are used in nsfont.m.
696
697 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
698
699 * process.c (Qprocessp): Don't declare static.
700 * lisp.h (Qprocessp): Declare again.
701
702 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
703
704 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
705
706 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
707
708 Improve C-level modularity by making more things 'static'.
709
710 Don't publish debugger-only interfaces to other modules.
711 * lisp.h (safe_debug_print, debug_output_compilation_hack):
712 (verify_bytepos, count_markers): Move decls to the only modules
713 that need them.
714 * region-cache.h (pp_cache): Likewise.
715 * window.h (check_all_windows): Likewise.
716 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
717
718 * sysdep.c (croak): Now static, if
719 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
720 * syssignal.h (croak): Declare only if not static.
721
722 * alloc.c (refill_memory_reserve): Now static if
723 !defined REL_ALLOC || defined SYSTEM_MALLOC.
724 * lisp.h (refill_memory_reserve): Declare only if not static.
725
726 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
727 Define only if USE_LUCID.
728
729 * xrdb.c (x_customization_string, x_rm_string): Now static.
730
731 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
732 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
733
734 * xdisp.c (draw_row_with_mouse_face): Now static.
735 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
736
737 * window.h (check_all_windows): Mark externally visible.
738
739 * window.c (window_deletion_count): Now static.
740
741 * undo.c: Make symbols static if they're not exported.
742 (last_undo_buffer, last_boundary_position, pending_boundary):
743 Now static.
744
745 * textprop.c (interval_insert_behind_hooks): Now static.
746 (interval_insert_in_front_hooks): Likewise.
747
748 * term.c: Make symbols static if they're not exported.
749 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
750 (max_frame_lines, tty_set_terminal_modes):
751 (tty_reset_terminal_modes, tty_turn_off_highlight):
752 (get_tty_terminal): Now static.
753 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
754 * termhooks.h (term_mouse_moveto): Do not declare if
755 HAVE_WINDOW_SYSTEM.
756 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
757 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
758
759 * sysdep.c: Make symbols static if they're not exported.
760 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
761 Now static.
762 (sigprocmask_set, full_mask): Remove; unused.
763 (wait_debugging): Mark as visible.
764 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
765 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
766
767 * syntax.c (syntax_temp): Define only if !__GNUC__.
768
769 * sound.c (current_sound_device, current_sound): Now static.
770
771 * search.c (searchbufs, searchbuf_head): Now static.
772
773 * scroll.c (scroll_cost): Remove; unused.
774 * dispextern.h (scroll_cost): Remove decl.
775
776 * region-cache.h (pp_cache): Mark as externally visible.
777
778 * process.c: Make symbols static if they're not exported.
779 (process_tick, update_tick, create_process, chan_process):
780 (Vprocess_alist, proc_buffered_char, datagram_access):
781 (fd_callback_data, send_process_frame, process_sent_to): Now static.
782 (deactivate_process): Mark defn as static, as well as decl.
783 * lisp.h (create_process): Remove decl.
784 * process.h (chan_process, Vprocess_alist): Remove decls.
785
786 * print.c: Make symbols static if they're not exported.
787 (print_depth, new_backquote_output, being_printed, print_buffer):
788 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
789 (print_interval, print_number_index, initial_stderr_stream):
790 Now static.
791 * lisp.h (Fprinc): Remove decl.
792 (debug_output_compilation_hack): Mark as externally visible.
793
794 * sysdep.c (croak): Move decl from here to syssignal.h.
795 * syssignal.h (croak): Put it here, so the API can be checked when
796 'croak' is called from dissociate_if_controlling_tty.
797
798 * minibuf.c: Make symbols static if they're not exported.
799 (minibuf_save_list, choose_minibuf_frame): Now static.
800 * lisp.h (choose_minibuf_frame): Remove decl.
801
802 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
803
804 * lread.c: Make symbols static if they're not exported.
805 (read_objects, initial_obarray, oblookup_last_bucket_number):
806 Now static.
807 (make_symbol): Remove; unused.
808 * lisp.h (initial_obarray, make_symbol): Remove decls.
809
810 * keyboard.c: Make symbols static if they're not exported.
811 (single_kboard, recent_keys_index, total_keys, recent_keys):
812 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
813 (this_single_command_key_start, echoing, last_auto_save):
814 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
815 (command_loop, echo_now, keyboard_init_hook, help_char_p):
816 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
817 (Vlispy_mouse_stem, double_click_count):
818 Now static.
819 (force_auto_save_soon): Define only if SIGDANGER.
820 (ignore_mouse_drag_p): Now static if
821 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
822 (print_help): Remove; unused.
823 (stop_character, last_timer_event): Mark as externally visible.
824 * keyboard.h (ignore_mouse_drag_p): Declare only if
825 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
826 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
827 * lisp.h (echoing): Remove decl.
828 (force_auto_save_soon): Declare only if SIGDANGER.
829 * xdisp.c (redisplay_window): Simplify code, to make it more
830 obvious that ignore_mouse_drag_p is not accessed if !defined
831 USE_GTK && !defined HAVE_NS.
832
833 * intervals.c: Make symbols static if they're not exported.
834 (merge_properties_sticky, merge_interval_right, delete_interval):
835 Now static.
836 * intervals.h (merge_interval_right, delete_interval): Remove decls.
837
838 * insdel.c: Make symbols static if they're not exported.
839 However, leave prepare_to_modify_buffer alone. It's never
840 called from outside this function, but that appears to be a bug.
841 (combine_after_change_list, combine_after_change_buffer):
842 (adjust_after_replace, signal_before_change): Now static.
843 (adjust_after_replace_noundo): Remove; unused.
844 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
845 (signal_before_change): Remove decls.
846
847 * indent.c (val_compute_motion, val_vmotion): Now static.
848
849 * image.c: Make symbols static if they're not exported.
850 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
851 if USE_GTK.
852 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
853 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
854
855 * fringe.c (standard_bitmaps): Now static.
856 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
857
858 * frame.c: Make symbols static if they're not exported.
859 (x_report_frame_params, make_terminal_frame): Now static.
860 (get_frame_param): Now static, unless HAVE_NS.
861 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
862 (x_get_resource_string): Remove; not used.
863 * frame.h (make_terminal_frame, x_report_frame_params):
864 (x_get_resource_string); Remove decls.
865 (x_fullscreen_adjust): Declare only if WINDOWSNT.
866 * lisp.h (get_frame_param): Declare only if HAVE_NS.
867
868 * font.c, fontset.c: Make symbols static if they're not exported.
869 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
870 (FACE_SUITABLE_FOR_CHAR_P): Use it.
871 * font.c (font_close_object): Now static.
872 * font.h (font_close_object): Remove.
873 * fontset.c (FONTSET_OBJLIST): Remove.
874 (free_realized_fontset) #if-0 the body, which does nothing.
875 (face_suitable_for_char_p): #if-0, as it's never called.
876 * fontset.h (face_suitable_for_char_p): Remove decl.
877 * xfaces.c (face_at_string_position): Use
878 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
879 since 0 is always ASCII.
880
881 * fns.c (weak_hash_tables): Now static.
882
883 * fileio.c: Make symbols static if they're not exported.
884 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
885 (Vwrite_region_annotation_buffers): Now static.
886
887 * eval.c: Make symbols static if they're not exported.
888 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
889 * lisp.h (backtrace_list): Remove decl.
890
891 * emacs.c: Make symbols static if they're not exported.
892 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
893 (fatal_error_code, fatal_error_signal_hook, standard_args):
894 Now static.
895 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
896 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
897 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
898 * lisp.h (fatal_error_signal_hook): Remove decl.
899 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
900
901 * editfns.c: Move a (normally-unused) function to its only use.
902 * editfns.c, lisp.h (get_operating_system_release): Remove.
903 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
904 worth the hassle of breaking this out.
905
906 * xterm.c: Make symbols static if they're not exported.
907 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
908 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
909 (x_destroy_window, x_delete_display):
910 Now static.
911 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
912 (x_mouse_leave): Remove; unused.
913 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
914 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
915 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
916 Remove decls.
917 (x_mouse_leave): Declare only if WINDOWSNT.
918 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
919 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
920 USE_X_TOOLKIT.
921
922 * ftxfont.c: Make symbols static if they're not exported.
923 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
924 HAVE_FREETYPE.
925 * font.h (ftxfont_driver): Likewise.
926
927 * xfns.c: Make symbols static if they're not exported.
928 (x_last_font_name, x_display_info_for_name):
929 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
930 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
931 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
932 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
933 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
934 (last_show_tip_args): Now static.
935 (xic_defaut_fontset, xic_create_fontsetname): Define only if
936 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
937 (x_screen_planes): Remove; unused.
938 * dispextern.h (x_screen_planes): Remove decl.
939
940 * dispnew.c: Make symbols static if they're not exported.
941 * dispextern.h (redraw_garbaged_frames, scrolling):
942 (increment_row_positions): Remove.
943 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
944 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
945 Now static.
946 (redraw_garbaged_frames): Remove; unused.
947
948 * xfaces.c: Make symbols static if they're not exported.
949 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
950 Remove decls.
951 * xterm.h (defined_color): Remove decls.
952 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
953 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
954 (menu_face_changed_default, defined_color, free_realized_face):
955 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
956 (ascii_face_of_lisp_face): Remove; unused.
957
958 * xdisp.c: Make symbols static if they're not exported.
959 * dispextern.h (scratch_glyph_row, window_box_edges):
960 (glyph_to_pixel_coords, set_cursor_from_row):
961 (get_next_display_element, set_iterator_to_next):
962 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
963 (show_mouse_face): Remove decls
964 * frame.h (message_buf_print): Likewise.
965 * lisp.h (pop_message, set_message, check_point_in_composition):
966 Likewise.
967 * xterm.h (set_vertical_scroll_bar): Likewise.
968 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
969 (message_buf_print, scratch_glyph_row, displayed_buffer):
970 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
971 (get_next_display_element, show_mouse_face, window_box_edges):
972 (frame_to_window_pixel_xy, check_point_in_composition):
973 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
974 (glyph_to_pixel_coords): Remove; unused.
975
976 * dired.c (file_name_completion): Now static.
977
978 * dbusbind.c (xd_in_read_queued_messages): Now static.
979
980 * lisp.h (circular_list_error, FOREACH): Remove; unused.
981 * data.c (circular_list_error): Remove.
982
983 * commands.h (last_point_position, last_point_position_buffer):
984 (last_point_position_window): Remove decls.
985 * keyboard.c: Make these variables static.
986
987 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
988 decls.
989 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
990 (iso_code_class, detect_coding, code_convert_region): Now static.
991 (encode_coding_gap): Remove; unused.
992
993 * chartab.c (chartab_chars, chartab_bits): Now static.
994
995 * charset.h (charset_iso_8859_1): Remove decl.
996 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
997 Now static.
998
999 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1000 * ccl.c (Vccl_program_table): Now static.
1001 (check_ccl_update): Remove; unused.
1002
1003 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1004 * category.h: ... from here.
1005 * category.c (check_category_table, set_category_set): Now static.
1006
1007 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1008 * lisp.h: Remove these decls.
1009
1010 * buffer.c (buffer_count): Remove unused var.
1011
1012 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1013 so that it's not optimized away.
1014 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1015 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1016 exported only to the debugger.
1017
1018 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1019 * atimer.h (run_all_atimers): Removed; not exported.
1020
1021 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1022 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1023 was inaccessible from Lisp.
1024 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1025 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1026
1027 alloc.c: Import and export fewer symbols, and remove unused items.
1028 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1029 is defined.
1030 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1031 it's not optimized away by whole-program optimization.
1032 (message_enable_multibyte, free_misc): Remove.
1033 (catchlist, handlerlist, mark_backtrace):
1034 Declare only if BYTE_MARK_STACK.
1035 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1036 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1037 (message_enable_multibyte): Remove decl.
1038 (free_misc, interval_free_list, float_block, float_block_index):
1039 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1040 (cons_free_list, last_marked_index):
1041 Now static.
1042 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1043 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1044 (mark_backtrace): Define only if BYTE_MARK_STACK.
1045 * xdisp.c (message_enable_multibyte): Now static.
1046
1047 Declare Lisp_Object Q* variables to be 'static' if not exported.
1048 This makes it easier for human readers (and static analyzers)
1049 to see whether these variables are used from other modules.
1050 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1051 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1052 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1053 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1054 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1055 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1056 * xmenu.c, xselect.c:
1057 Declare Q* vars static if they are not used in other modules.
1058 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1059 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1060 Remove decls of unexported vars.
1061 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1062
1063 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1064
1065 Make Emacs functions such as Fatom 'static' by default.
1066 This makes it easier for human readers (and static analyzers)
1067 to see whether these functions can be called from other modules.
1068 DEFUN now defines a static function. To make the function external
1069 so that it can be used in other C modules, use the new macro DEFUE.
1070 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1071 (Finit_image_library):
1072 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1073 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1074 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1075 Remove decls, since these functions are now static.
1076 (Funintern, Fget_internal_run_time): New decls, since these functions
1077 were already external.
1078
1079 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1080 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1081 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1082 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1083 * keyboard.c, keymap.c, lread.c:
1084 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1085 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1086 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1087 Mark functions with DEFUE instead of DEFUN,
1088 if they are used in other modules.
1089 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1090 decls for now-static functions.
1091 * buffer.h (Fdelete_overlay): Remove decl.
1092 * callproc.c (Fgetenv_internal): Mark as internal.
1093 * composite.c (Fremove_list_of_text_properties): Remove decl.
1094 (Fcomposition_get_gstring): New forward static decl.
1095 * composite.h (Fcomposite_get_gstring): Remove decl.
1096 * dired.c (Ffile_attributes): New forward static decl.
1097 * doc.c (Fdocumntation_property): New forward static decl.
1098 * eval.c (Ffetch_bytecode): New forward static decl.
1099 (Funintern): Remove extern decl; now in .h file where it belongs.
1100 * fileio.c (Fmake_symbolic_link): New forward static decl.
1101 * image.c (Finit_image_library): New forward static decl.
1102 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1103 * intervals.h (Fprevious_property_change):
1104 (Fremove_list_of_text_properties): Remove decls.
1105 * keyboard.c (Fthis_command_keys): Remove decl.
1106 (Fcommand_execute): New forward static decl.
1107 * keymap.c (Flookup_key): New forward static decl.
1108 (Fcopy_keymap): Now static.
1109 * keymap.h (Flookup_key): Remove decl.
1110 * process.c (Fget_process): New forward static decl.
1111 (Fprocess_datagram_address): Mark as internal.
1112 * syntax.c (Fsyntax_table_p): New forward static decl.
1113 (skip_chars): Remove duplicate decl.
1114 * textprop.c (Fprevious_property_change): New forward static decl.
1115 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1116 Now internal.
1117 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1118 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1119
1120 * editfns.c (Fformat): Remove unreachable code.
1121
1122 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1123
1124 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1125 change. (Bug#8496)
1126
1127 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1128
1129 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1130 when at ZV. (Bug#8487)
1131
1132 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1133
1134 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1135 (Bug#8437)
1136 * keyboard.c (parse_tool_bar_item): Likewise.
1137 * sound.c (sound_cleanup, alsa_close): Likewise.
1138 * termcap.c (tgetent): Likewise.
1139 * xfns.c (x_default_font_parameter): Likewise.
1140 * xsettings.c (read_and_apply_settings): Likewise.
1141
1142 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1143 (overrun_check_free): Protoize.
1144
1145 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1146
1147 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1148 since callers should never pass a negative size.
1149 Change the signature to match that of plain 'read' and 'write'; see
1150 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1151 * lisp.h: Update prototypes of emacs_write and emacs_read.
1152
1153 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1154
1155 * xdisp.c (redisplay_window): Don't try to determine the character
1156 position of the scroll margin if the window start point w->startp
1157 is outside the buffer's accessible region. (Bug#8468)
1158
1159 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1160
1161 Fix write-region and its subroutines for buffers > 2GB.
1162 * fileio.c (a_write, e_write): Modify declaration of arguments and
1163 local variables to support buffers larger than 2GB.
1164 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1165
1166 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1167 argument, local variables, and return value.
1168
1169 * lisp.h: Update prototypes of emacs_write and emacs_read.
1170
1171 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1172
1173 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1176
1177 Fix more problems found by GCC 4.6.0's static checks.
1178
1179 * xdisp.c (vmessage): Use a better test for character truncation.
1180
1181 * charset.c (load_charset_map): <, not <=, for optimization,
1182 and to avoid potential problems with integer overflow.
1183 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1184 * casetab.c (set_identity, shuffle): Likewise.
1185 * editfns.c (Fformat): Likewise.
1186 * syntax.c (skip_chars): Likewise.
1187
1188 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1189 This also lets GCC 4.6.0 generate slightly better loop code.
1190
1191 * callint.c (Fcall_interactively): <, not <=, for optimization.
1192 (Fcall_interactively): Count the number of arguments produced,
1193 not the number of arguments given. This is simpler and lets GCC
1194 4.6.0 generate slightly better code.
1195
1196 * ftfont.c: Distingish more carefully between FcChar8 and char.
1197 The previous code passed unsigned char * to a functions like
1198 strlen and xstrcasecmp that expect char *, which does not
1199 conform to the C standard.
1200 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1201 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1202 char * when the C standard requires it.
1203
1204 * keyboard.c (read_char): Remove unused var.
1205
1206 * eval.c: Port to Windows vsnprintf (Bug#8435).
1207 Include <limits.h>.
1208 (SIZE_MAX): Define if the headers do not.
1209 (verror): Do not give up if vsnprintf returns a negative count.
1210 Instead, grow the buffer. This ports to Windows vsnprintf, which
1211 does not conform to C99. Problem reported by Eli Zaretskii.
1212 Also, simplify the allocation scheme, by avoiding the need for
1213 calling realloc, and removing the ALLOCATED variable.
1214
1215 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1216
1217 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1218 But keep the doprint source code for now, as we might revamp it
1219 and use it again (Bug#8435).
1220 * lisp.h (doprnt): Remove.
1221 * Makefile.in (base_obj): Remove doprnt.o.
1222 * deps.mk (doprnt.o): Remove.
1223
1224 error: Print 32- and 64-bit integers portably (Bug#8435).
1225 Without this change, on typical 64-bit hosts error ("...%d...", N)
1226 was used to print both 32- and 64-bit integers N, which relied on
1227 undefined behavior.
1228 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1229 New macro.
1230 * lisp.h (error, verror): Mark as printf-like functions.
1231 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1232 Report overflow in size calculations when allocating printf buffer.
1233 Do not truncate output string at its first null byte.
1234 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1235 Truncate the output at a character boundary, since vsnprintf does not
1236 do that.
1237 * charset.c (check_iso_charset_parameter): Convert internal
1238 character to string before calling 'error', since %c now has the
1239 printf meaning.
1240 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1241 overflow when computing char to be passed to 'error'. Do not
1242 pass Lisp_Object to 'error'; pass the integer instead.
1243 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1244 formatted with plain %d.
1245
1246 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1247
1248 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1249
1250 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1251
1252 * xterm.c (x_catch_errors): Remove duplicate declaration.
1253
1254 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1255
1256 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1257
1258 2011-04-10 Jim Meyering <meyering@redhat.com>
1259
1260 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1261 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1262 return ssize_t not "int", and use size_t as the buffer length.
1263 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1264 * gnutls.h: Update declarations.
1265 * process.c (read_process_output): Use ssize_t, to match.
1266 (send_process): Likewise.
1267
1268 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1269
1270 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1271
1272 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1273
1274 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1275 unsigned char, to match FcChar8 type definition.
1276
1277 * xterm.c (handle_one_xevent):
1278 * xmenu.c (create_and_show_popup_menu):
1279 * xselect.c (x_decline_selection_request)
1280 (x_reply_selection_request): Avoid type-punned deref of X events.
1281
1282 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1283
1284 Fix some uses of `int' instead of EMACS_INT.
1285 * search.c (string_match_1, fast_string_match)
1286 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1287 (scan_buffer, find_next_newline_no_quit)
1288 (find_before_next_newline, search_command, Freplace_match)
1289 (Fmatch_data): Make some `int' variables be EMACS_INT.
1290
1291 * xdisp.c (display_count_lines): 3rd argument and return value now
1292 EMACS_INT. All callers changed.
1293 (pint2hrstr): Last argument is now EMACS_INT.
1294
1295 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1296 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1297 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1298 (decode_coding_utf_16, decode_coding_emacs_mule)
1299 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1300 (decode_coding_ccl, decode_coding_charset)
1301 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1302 (decode_coding_iso_2022, decode_coding_emacs_mule)
1303 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1304 <char_offset, last_offset>: Declare EMACS_INT.
1305 (encode_coding_utf_8, encode_coding_utf_16)
1306 (encode_coding_emacs_mule, encode_invocation_designation)
1307 (encode_designation_at_bol, encode_coding_iso_2022)
1308 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1309 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1310 Declare EMACS_INT.
1311 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1312 (encode_invocation_designation): Last argument P_NCHARS is now
1313 EMACS_INT.
1314 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1315 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1316
1317 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1318 All users changed.
1319
1320 * ccl.c (Fccl_execute_on_string): Declare some variables
1321 EMACS_INT.
1322
1323 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1324
1325 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1326
1327 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1328
1329 * process.c (Fformat_network_address): Doc fix.
1330
1331 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1332
1333 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1334
1335 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1336
1337 * keyboard.c (read_char): Call Lisp function help-form-show,
1338 instead of using internal_with_output_to_temp_buffer.
1339 (Qhelp_form_show): New var.
1340 (syms_of_keyboard): Use DEFSYM macro.
1341
1342 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1343
1344 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1345
1346 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1347
1348 * process.c (Flist_processes): Removed to Lisp.
1349 (list_processes_1): Deleted.
1350
1351 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1352
1353 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1354
1355 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1356
1357 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 Fix more problems found by GCC 4.6.0's static checks.
1360
1361 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1362
1363 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1364
1365 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1366
1367 * xdisp.c (vmessage): Mark as a printf-like function.
1368
1369 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1370
1371 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1372
1373 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1374 printf-like functions.
1375 (tiff_load): Add casts to remove these marks before passing them
1376 to system-supplied API.
1377
1378 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1379
1380 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1381 This avoids several warnings with gcc -Wstrict-overflow.
1382 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1383 directly, rather than having caller test rule sign. This avoids
1384 some unnecessary tests.
1385 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1386 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1387 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1388
1389 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1390 (xfont_open): Avoid unnecessary tests.
1391
1392 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1393
1394 * composite.h, composite.c (composition_gstring_put_cache):
1395 Use EMACS_INT, not int, for length.
1396
1397 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1398 breaking out part of COMPOSITION_DECODE_RULE.
1399 (COMPOSITION_DECODE_RULE): Use it.
1400 * composite.c (get_composition_id): Remove unused local vars,
1401 by using the new macro.
1402
1403 * textprop.c (set_text_properties_1): Change while to do-while,
1404 since the condition is always true at first.
1405
1406 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1407 (interval_deletion_adjustment): Return unsigned value.
1408 All uses changed.
1409
1410 * process.c (list_processes_1, create_pty, read_process_output):
1411 (exec_sentinel): Remove vars that were set but not used.
1412 (create_pty): Remove unnecessary "volatile"s.
1413 (Fnetwork_interface_info): Avoid possibility of int overflow.
1414 (read_process_output): Do adaptive read buffering even if carryover.
1415 (read_process_output): Simplify nbytes computation if buffered.
1416
1417 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1418
1419 * syntax.c (scan_words): Remove var that was set but not used.
1420 (update_syntax_table): Use unsigned instead of int.
1421
1422 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1423 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1424 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1425
1426 * print.c (print_error_message): Avoid int overflow.
1427
1428 * font.c (font_list_entities): Redo for clarity,
1429 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1430
1431 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1432 (font_score): Avoid potential overflow in diff calculation.
1433
1434 * fns.c (substring_both): Remove var that is set but not used.
1435 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1436
1437 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1438
1439 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1440 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1441 can always succeed if overflow has undefined behavior.
1442
1443 * search.c (boyer_moore, wordify): Remove vars set but not used.
1444 (wordify): Omit three unnecessary tests.
1445
1446 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1447 All callers changed. This avoids the need for an unused var.
1448
1449 * casefiddle.c (casify_region): Remove var that is set but not used.
1450
1451 * dired.c (file_name_completion): Remove var that is set but not used.
1452
1453 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1454
1455 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1456 (Finsert_file_contents): Remove unnecessary code checking fd.
1457
1458 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1459 Check for integer overflow on size calculations.
1460
1461 * buffer.c (Fprevious_overlay_change): Remove var that is set
1462 but not used.
1463
1464 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1465 Remove vars that are set but not used.
1466 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1467 (timer_check_2): Mark vars as initialized.
1468
1469 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1470
1471 * image.c (lookup_image): Remove var that is set but not used.
1472 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1473
1474 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1475 that are set but not used.
1476
1477 * xfns.c (make_invisible_cursor): Don't return garbage
1478 if XCreateBitmapFromData fails (Bug#8410).
1479
1480 * xselect.c (x_get_local_selection, x_handle_property_notify):
1481 Remove vars that are set but not used.
1482
1483 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1484 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1485
1486 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1487 Remove var that is set but not used.
1488 (scroll_bar_windows_size): Now size_t, not int.
1489 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1490 Check for overflow.
1491
1492 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1493 (map_tty_color) [!defined MSDOS]: Likewise.
1494
1495 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1496
1497 * coding.c: Remove vars that are set but not used.
1498 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1499 All callers changed.
1500 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1501 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1502 (decode_coding_charset): Remove vars that are set but not used.
1503
1504 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1505 that is set but not used.
1506
1507 * print.c (print_object): Remove var that is set but not used.
1508
1509 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1510 The gnulib version avoids calling malloc in the usual case,
1511 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1512 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1513 * filelock.c (current_lock_owner): Likewise.
1514 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1515 * sysdep.c: Include allocator.h, careadlinkat.h.
1516 (emacs_no_realloc_allocator): New static constant.
1517 (emacs_readlink): New function.
1518 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1519 ../lib/careadlinkat.h.
1520
1521 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1522
1523 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1524 first non-nil return value).
1525
1526 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1527
1528 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1529 if not defined (Bug#8403).
1530
1531 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1532
1533 * xdisp.c (display_count_lines): Remove parameter `start',
1534 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1535 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1536 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1537 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1538 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1539 and thereabouts. All callers changed.
1540 (get_per_char_metric): Remove parameter `f', unused since
1541 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1542
1543 2011-04-02 Jim Meyering <meyering@redhat.com>
1544
1545 do not dereference NULL upon failed strdup
1546 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1547 (ns_get_family): Likewise.
1548
1549 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1550
1551 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1552
1553 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1554
1555 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1556 later (Bug#8403).
1557
1558 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1559
1560 Add lexical binding.
1561
1562 * window.c (Ftemp_output_buffer_show): New fun.
1563 (Fsave_window_excursion):
1564 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1565
1566 * lread.c (lisp_file_lexically_bound_p): New function.
1567 (Fload): Bind Qlexical_binding.
1568 (readevalloop): Remove `evalfun' arg.
1569 Bind Qinternal_interpreter_environment.
1570 (Feval_buffer): Bind Qlexical_binding.
1571 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1572 Mark as dynamic.
1573 (syms_of_lread): Declare `lexical-binding'.
1574
1575 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1576
1577 * keyboard.c (eval_dyn): New fun.
1578 (menu_item_eval_property): Use it.
1579
1580 * image.c (parse_image_spec): Use Ffunctionp.
1581
1582 * fns.c (concat, mapcar1): Accept byte-code-functions.
1583
1584 * eval.c (Fsetq): Handle lexical vars.
1585 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1586 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1587 (FletX, Flet): Obey lexical binding.
1588 (Fcommandp): Handle closures.
1589 (Feval): New `lexical' arg.
1590 (eval_sub): New function extracted from Feval. Use it almost
1591 everywhere where Feval was used. Look up vars in lexical env.
1592 Handle closures.
1593 (Ffunctionp): Move from subr.el.
1594 (Ffuncall): Handle closures.
1595 (apply_lambda): Remove `eval_flags'.
1596 (funcall_lambda): Handle closures and new byte-code-functions.
1597 (Fspecial_variable_p): New function.
1598 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1599 but without exporting it to Lisp.
1600
1601 * doc.c (Fdocumentation, store_function_docstring):
1602 * data.c (Finteractive_form): Handle closures.
1603
1604 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1605 interactive spec.
1606
1607 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1608 byte-codes.
1609 (exec_byte_code): New function extracted from Fbyte_code to handle new
1610 calling convention for byte-code-functions. Add new byte-codes.
1611
1612 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1613
1614 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1615
1616 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1617
1618 * xdisp.c (redisplay_internal): Fix prototype.
1619
1620 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1621
1622 * xdisp.c (SCROLL_LIMIT): New macro.
1623 (try_scrolling): Use it when setting scroll_limit. Limit
1624 scrolling to 100 screen lines.
1625 (redisplay_window): Even when falling back on "recentering",
1626 position point in the window according to scroll-conservatively,
1627 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1628
1629 (try_scrolling): When point is above the window, allow searching
1630 as far as scroll_max, or one screenful, to compute vertical
1631 distance from PT to the scroll margin position. This prevents
1632 try_scrolling from unnecessarily failing when
1633 scroll-conservatively is set to a value slightly larger than the
1634 window height. Clean up the case of PT below the margin at bottom
1635 of window: scroll_max can no longer be INT_MAX. When aggressive
1636 scrolling is in use, don't let point enter the opposite scroll
1637 margin as result of the scroll.
1638 (syms_of_xdisp) <scroll-conservatively>: Document the
1639 threshold of 100 lines for never-recentering scrolling.
1640
1641 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1642
1643 * dispextern.h (move_it_by_lines):
1644 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1645 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1646 (message_log_check_duplicate): Remove parameters `prev_bol' and
1647 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1648 (redisplay_internal): Remove parameter `preserve_echo_area',
1649 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1650
1651 * indent.c (Fvertical_motion):
1652 * window.c (window_scroll_pixel_based, Frecenter):
1653 Don't pass `need_y_p' to `move_it_by_lines'.
1654
1655 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1656
1657 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1658 steal a few bits to be more compact.
1659 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1660 Remove unneeded casts.
1661
1662 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1663
1664 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1665
1666 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1667 binding" message (bug#7967).
1668
1669 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1670
1671 Fix more problems found by GCC 4.6.0's static checks.
1672
1673 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1674 Remove unused local var.
1675
1676 * editfns.c (Fmessage_box): Remove unused local var.
1677
1678 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1679 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1680 Omit unused local vars.
1681 * window.c (shrink_windows): Omit unused local var.
1682 * menu.c (digest_single_submenu): Omit unused local var.
1683 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1684 Omit unused local var.
1685
1686 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1687 Don't assume string length fits in int.
1688 (keyremap_step, read_key_sequence): Use size_t for sizes.
1689 (read_key_sequence): Don't check last_real_key_start redundantly.
1690
1691 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1692 instead of alloca (Bug#8344).
1693
1694 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1695 (Fbacktrace_frame): Don't assume nframes fits in int.
1696
1697 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1698
1699 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1700 concerns.
1701
1702 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1703
1704 * cm.c (calccost): Turn while-do into do-while, for clarity.
1705
1706 * keyboard.c (syms_of_keyboard): Use the same style as later
1707 in this function when indexing through an array. This also
1708 works around GCC bug 48267.
1709
1710 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1711
1712 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1713
1714 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1715 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1716
1717 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1718 This avoids undefined behavior on integer overflow, and is a bit
1719 more convenient anyway since it is compared to a size_t variable.
1720
1721 Variadic C functions now count arguments with size_t, not int.
1722 This avoids an unnecessary limitation on 64-bit machines, which
1723 caused (substring ...) to crash on large vectors (Bug#8344).
1724 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1725 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1726 All variadic functions and their callers changed accordingly.
1727 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1728 * data.c (arith_driver, float_arith_driver): Likewise.
1729 * editfns.c (general_insert_function): Likewise.
1730 * eval.c (struct backtrace.nargs, interactive_p)
1731 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1732 (funcall_lambda, mark_backtrace): Likewise.
1733 * fns.c (concat): Likewise.
1734 * frame.c (x_set_frame_parameters): Likewise.
1735 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1736 0 if not found, not -1. All callers changed.
1737
1738 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1739 (stack_copy_size): Now size_t, not int.
1740 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1741
1742 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1743
1744 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1745 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1746 All callers changed.
1747
1748 * lisp.h (multibyte_char_to_unibyte):
1749 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1750 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1751 * character.h (CHAR_TO_BYTE8):
1752 * cmds.c (internal_self_insert):
1753 * editfns.c (general_insert_function):
1754 * keymap.c (push_key_description):
1755 * search.c (Freplace_match):
1756 * xdisp.c (message_dolog, set_message_1): All callers changed.
1757
1758 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1759
1760 * keyboard.c (safe_run_hook_funcall): New function.
1761 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1762 don't set the hook to nil, but remove the offending function instead.
1763 (Qcommand_hook_internal): Remove, unused.
1764 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1765 Vcommand_hook_internal.
1766
1767 * eval.c (enum run_hooks_condition): Remove.
1768 (funcall_nil, funcall_not): New functions.
1769 (run_hook_with_args): Call each function through a `funcall' argument.
1770 Remove `cond' argument, now redundant.
1771 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1772 (Frun_hook_with_args_until_failure): Adjust accordingly.
1773 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1774
1775 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1776
1777 * dispextern.h (string_buffer_position): Remove declaration.
1778
1779 * print.c (strout): Remove parameter `multibyte', unused since
1780 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1781
1782 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1783 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1784 All callers changed.
1785
1786 * w32.c (_wsa_errlist): Use braces for struct initializers.
1787
1788 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1789 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1790 All callers changed.
1791 (string_buffer_position): Likewise. Also, make static (it's never
1792 used outside xdisp.c).
1793 (cursor_row_p): Remove parameter `w', unused since
1794 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1795 (decode_mode_spec): Remove parameter `precision', introduced during
1796 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1797 All callers changed.
1798
1799 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1800
1801 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1802
1803 2011-03-27 Anders Lindgren <andlind@gmail.com>
1804
1805 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1806 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1807 (ns_update_auto_hide_menu_bar): New functions.
1808 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1809 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1810 ns_constrain_all_frames.
1811 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1812 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1813
1814 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1815
1816 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1817
1818 2011-03-27 Glenn Morris <rgm@gnu.org>
1819
1820 * syssignal.h: Replace RETSIGTYPE with void.
1821 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1822 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1823 Replace SIGTYPE with void everywhere.
1824 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1825 * s/template.h (SIGTYPE): Remove commented out definition.
1826
1827 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1828
1829 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1830 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1831
1832 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1833
1834 * w32.c (read_unc_volume): Use parameter `henum', instead of
1835 global variable `wget_enum_handle'.
1836
1837 * keymap.c (describe_vector): Remove parameters `indices' and
1838 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1839 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1840
1841 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1842
1843 * keyboard.c (timer_check): Remove parameter `do_it_now',
1844 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1845 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1846 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1847
1848 * keyboard.c (read_char):
1849 * w32menu.c (w32_menu_display_help):
1850 * xmenu.c (show_help_event, menu_help_callback):
1851 Adjust calls to `show_help_echo'.
1852
1853 * gtkutil.c (xg_maybe_add_timer):
1854 * keyboard.c (readable_events):
1855 * process.c (wait_reading_process_output):
1856 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1857
1858 * insdel.c (adjust_markers_gap_motion):
1859 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1860 (gap_left, gap_right): Don't call it.
1861
1862 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1863
1864 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1865 incurred during fontification.
1866
1867 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1868
1869 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1870 (DEFVAR_PER_BUFFER): Don't pass it.
1871
1872 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1873 (scrolling_window): Don't pass it.
1874
1875 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1876
1877 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1878
1879 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1880 and `suffix'.
1881 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1882 of variables specific to SELinux and computation of `encoded_absname'.
1883
1884 * image.c (XPutPixel): Remove unused variable `height'.
1885
1886 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1887
1888 * unexw32.c (get_section_info): Remove unused variable `section'.
1889
1890 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1891 (system_process_attributes): Remove unused variable `sess'.
1892 (sys_read): Remove unused variable `err'.
1893
1894 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1895 (w32_wnd_proc): Remove unused variable `isdead'.
1896 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1897 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1898 (x_create_tip_frame): Remove unused variable `tem'.
1899
1900 * w32inevt.c (w32_console_read_socket):
1901 Remove unused variable `no_events'.
1902
1903 * w32term.c (x_draw_composite_glyph_string_foreground):
1904 Remove unused variable `width'.
1905
1906 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1907
1908 * w32term.c (x_set_glyph_string_clipping):
1909 Don't pass uninitialized region to CombineRgn.
1910
1911 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1912
1913 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1914 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1915 (Fx_close_connection): Remove unused variable `i'.
1916
1917 * w32font.c (w32font_draw): Return number of glyphs.
1918 (w32font_open_internal): Remove unused variable `i'.
1919 (w32font_driver): Add missing initializer.
1920
1921 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1922 (fill_in_menu): Remove unused variable `items_added'.
1923
1924 * w32term.c (last_mouse_press_frame): Remove static global variable.
1925 (w32_clip_to_row): Remove unused variable `f'.
1926 (x_delete_terminal): Remove unused variable `i'.
1927
1928 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1929 (NOTHING): Remove unused static global variable.
1930 (uniscribe_check_otf): Remove unused variable `table'.
1931 (uniscribe_font_driver): Add missing initializers.
1932
1933 2011-03-23 Julien Danjou <julien@danjou.info>
1934
1935 * term.c (Fsuspend_tty, Fresume_tty):
1936 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1937 * window.c (temp_output_buffer_show):
1938 * insdel.c (signal_before_change):
1939 * frame.c (Fhandle_switch_frame):
1940 * fileio.c (Fdo_auto_save):
1941 * emacs.c (Fkill_emacs):
1942 * editfns.c (save_excursion_restore):
1943 * cmds.c (internal_self_insert):
1944 * callint.c (Fcall_interactively):
1945 * buffer.c (Fkill_all_local_variables):
1946 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1947 Use Frun_hooks.
1948 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1949 unconditionnaly since it does the check itself.
1950
1951 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 Fix more problems found by GCC 4.5.2's static checks.
1954
1955 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1956 the first time through the loop, since we know p0 < p1 then.
1957 This also avoids a gcc -Wstrict-overflow warning.
1958
1959 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1960 leading to a memory leak, possible in functions like
1961 load_charset_map_from_file that can allocate an unbounded number
1962 of objects (Bug#8318).
1963
1964 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1965 that could (at least in theory) be that large.
1966
1967 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1968 This is less likely to overflow, and avoids undefined behavior if
1969 overflow does occur. All callers changed. Use strtoul to scan
1970 for the unsigned long integer.
1971 (pint2hrstr): Simplify and tune code slightly.
1972 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1973
1974 * scroll.c (do_scrolling): Work around GCC bug 48228.
1975 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1976
1977 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1978 This also avoids a warning with gcc -Wstrict-overflow.
1979 (validate_x_resource_name): Simplify count usage.
1980 This also avoids a warning with gcc -Wstrict-overflow.
1981
1982 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1983 fail (Bug#8306).
1984
1985 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1986
1987 * process.c (Fmake_network_process): Use socklen_t, not int,
1988 where POSIX says socklen_t is required in portable programs.
1989 This fixes a porting bug on hosts like 64-bit HP-UX, where
1990 socklen_t is wider than int (Bug#8277).
1991 (Fmake_network_process, server_accept_connection):
1992 (wait_reading_process_output, read_process_output):
1993 Likewise.
1994
1995 * process.c: Rename or move locals to avoid shadowing.
1996 (list_processes_1, Fmake_network_process):
1997 (read_process_output_error_handler, exec_sentinel_error_handler):
1998 Rename or move locals.
1999 (Fmake_network_process): Define label "retry_connect" only if needed.
2000 (Fnetwork_interface_info): Fix pointer signedness.
2001 (process_send_signal): Add cast to avoid pointer signedness problem.
2002 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2003 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2004
2005 Make tparam.h and terminfo.c consistent.
2006 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2007 Include tparam.h instead, since it declares them.
2008 * cm.h (PC): Remove extern decl; tparam.h now does this.
2009 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2010 * terminfo.c: Include tparam.h, to check interfaces.
2011 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2012 (tparam): Adjust signature to match interface in tparam.h;
2013 this removes some undefined behavior. Check that outstring and len
2014 are zero, which they always are with Emacs.
2015 * tparam.h (PC, BC, UP): New extern decls.
2016
2017 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2018 (xftfont_open): Rename locals to avoid shadowing.
2019
2020 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2021 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2022 (OTF_TAG_SYM): Omit macro if not needed.
2023 (ftfont_list): Remove unused local.
2024 (get_adstyle_property, ftfont_pattern_entity):
2025 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2026 Rename locals to avoid shadowing.
2027
2028 * xfont.c (xfont_list_family): Mark var as initialized.
2029
2030 * xml.c (make_dom): Now static.
2031
2032 * composite.c (composition_compute_stop_pos): Rename local to
2033 avoid shadowing.
2034 (composition_reseat_it): Remove unused locals.
2035 (find_automatic_composition, composition_adjust_point): Likewise.
2036 (composition_update_it): Mark var as initialized.
2037 (find_automatic_composition): Mark vars as initialized,
2038 with a FIXME (Bug#8290).
2039
2040 character.h: Rename locals to avoid shadowing.
2041 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2042 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2043 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2044 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2045 to avoid shadowing.
2046
2047 * textprop.c (property_change_between_p): Remove; unused.
2048
2049 * intervals.c (interval_start_pos): Now static.
2050
2051 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2052
2053 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2054 Rename locals to avoid shadowing.
2055
2056 * sound.c (wav_play, au_play, Fplay_sound_internal):
2057 Fix pointer signedness.
2058 (alsa_choose_format): Remove unused local var.
2059 (wav_play): Initialize a variable to 0, to prevent undefined
2060 behavior (Bug#8278).
2061
2062 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2063
2064 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2065
2066 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2067 clobbering (Bug#8298).
2068 * sysdep.c (sys_subshell): Likewise.
2069 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2070
2071 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2072 This should get cleaned up, so that child_setup has the
2073 same signature on all platforms.
2074
2075 * callproc.c (call_process_cleanup): Now static.
2076 (relocate_fd): Rename locals to avoid shadowing.
2077
2078 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2079
2080 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2081 not to be necessary, and produces flickering.
2082
2083 2011-03-20 Glenn Morris <rgm@gnu.org>
2084
2085 * config.in: Remove file.
2086
2087 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2088
2089 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2090 are now in src/globals.h.
2091 (syms_of_minibuf): Remove spurious & from previous change.
2092
2093 2011-03-20 Leo <sdl.web@gmail.com>
2094
2095 * minibuf.c (completing-read-function): New variable.
2096 (completing-read-default): Rename from completing-read.
2097 (completing-read): Call completing-read-function.
2098
2099 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2100
2101 * xfaces.c (Fx_load_color_file):
2102 Read color file from absolute filename (bug#8250).
2103
2104 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2105
2106 * makefile.w32-in: Update dependencies.
2107
2108 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2109
2110 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2111
2112 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2113
2114 Fix more problems found by GCC 4.5.2's static checks.
2115
2116 * process.c (make_serial_process_unwind, send_process_trap):
2117 (sigchld_handler): Now static.
2118
2119 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2120 That way, the code declares only the vars that it needs.
2121 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2122 * s/cygwin.h (PTY_ITERATION): Likewise.
2123 * s/darwin.h (PTY_ITERATION): Likewise.
2124 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2125
2126 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2127 * process.c (allocate_pty): Don't declare stb unless it's needed.
2128
2129 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2130 (CONSTANTLIM): Remove; unused.
2131 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2132 Define only if needed.
2133
2134 * unexelf.c (unexec): Name an expression,
2135 to avoid gcc -Wbad-function-cast warning.
2136 Use a different way to cause a compilation error if anyone uses
2137 n rather than nn, a way that does not involve shadowing.
2138 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2139
2140 * deps.mk (unexalpha.o): Remove; unused.
2141
2142 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2143 * unexec.h: New file.
2144 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2145 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2146 Depend on unexec.h.
2147 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2148 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2149 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2150 Change as necessary to match prototype in unexec.h.
2151
2152 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2153 shadowing.
2154 (back_comment, skip_chars): Mark vars as initialized.
2155
2156 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2157 Rename locals to avoid shadowing.
2158
2159 * lread.c (read1): Rewrite so as not to use empty "else".
2160 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2161
2162 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2163
2164 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2165 warning when compiling print.c.
2166
2167 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2168 instead of using an uninitialized var.
2169 (font_sort_entities): Mark var as initialized.
2170
2171 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2172
2173 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2174 pointers to constants.
2175 (font_parse_fcname): Remove unused vars.
2176 (font_delete_unmatched): Now static.
2177 (font_get_spec): Remove; unused.
2178 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2179 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2180 Rename or move locals to avoid shadowing.
2181
2182 * fns.c (require_nesting_list, require_unwind): Now static.
2183 (Ffillarray): Rename locals to avoid shadowing.
2184
2185 * floatfns.c (domain_error2): Define only if needed.
2186 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2187
2188 * alloc.c (mark_backtrace): Move decl from here ...
2189 * lisp.h: ... to here, so that it can be checked.
2190
2191 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2192 (Fdefvar): Rewrite so as not to use empty "else".
2193 (lisp_indirect_variable): Name an expression,
2194 to avoid gcc -Wbad-function-cast warning.
2195 (Fdefvar): Rename locals to avoid shadowing.
2196
2197 * callint.c (quotify_arg, quotify_args): Now static.
2198 (Fcall_interactively): Rename locals to avoid shadowing.
2199 Use const pointer when appropriate.
2200
2201 * lisp.h (get_system_name, get_operating_system_release):
2202 Move decls here, to check interfaces.
2203 * process.c (get_operating_system_release): Move decl to lisp.h.
2204 * xrdb.c (get_system_name): Likewise.
2205 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2206 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2207 some of which prompt warnings from gcc -Wbad-function-cast.
2208 (Fformat_time_string, Fencode_time, Finsert_char):
2209 (Ftranslate_region_internal, Fformat):
2210 Rename or remove local vars to avoid shadowing.
2211 (Ftranslate_region_internal): Mark var as initialized.
2212
2213 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2214 avoid shadowing.
2215
2216 * lisp.h (eassert): Check that the argument compiles, even if
2217 ENABLE_CHECKING is not defined.
2218
2219 * data.c (Findirect_variable): Name an expression, to avoid
2220 gcc -Wbad-function-cast warning.
2221 (default_value, arithcompare, arith_driver, arith_error): Now static.
2222 (store_symval_forwarding): Rename local to avoid shadowing.
2223 (Fmake_variable_buffer_local, Fmake_local_variable):
2224 Mark variables as initialized.
2225 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2226
2227 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2228 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2229 Rename locals to avoid shadowing.
2230 (mark_stack): Move local variables into the #ifdef region where
2231 they're used.
2232 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2233 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2234 needed otherwise.
2235 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2236 (GC_STRING_CHARS): Remove; not used.
2237 (Fmemory_limit): Cast sbrk's returned value to char *.
2238
2239 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2240 avoids undefined behavior in theory.
2241
2242 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2243
2244 Use functions, not macros, for up- and down-casing (Bug#8254).
2245 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2246 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2247 to use the following functions instead of these macros.
2248 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2249 EMACS_INT, since callers assume the returned value fits in int.
2250 (upcase1): Likewise, for UPCASE_TABLE.
2251 (uppercasep, lowercasep, upcase): New static inline functions.
2252 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2253 the race-condition problem in the old DOWNCASE.
2254
2255 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2256 Rename locals to avoid shadowing.
2257 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2258 (regex_compile, re_search_2, re_match_2_internal):
2259 Remove unused local vars.
2260 (FREE_VAR): Rewrite so as not to use empty "else",
2261 which gcc can warn about.
2262 (regex_compile, re_match_2_internal): Mark locals as initialized.
2263 (RETALLOC_IF): Define only if needed.
2264 (WORDCHAR_P): Likewise. This one is never needed, but is used
2265 only in a comment talking about a compiler bug, so put inside
2266 the #if 0 of that comment.
2267 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2268 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2269 Remove; unused.
2270
2271 * search.c (boyer_moore): Rename locals to avoid shadowing.
2272 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2273 (PREV_CHAR_BOUNDARY): Likewise.
2274
2275 * search.c (simple_search): Remove unused var.
2276
2277 * dired.c (compile_pattern): Move decl from here ...
2278 * lisp.h: ... to here, so that it can be checked.
2279 (struct re_registers): New forward decl.
2280
2281 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2282
2283 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2284 All uses changed.
2285 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2286 Rename locals to avoid shadowing.
2287 (Fvertical_motion): Mark locals as initialized.
2288
2289 * casefiddle.c (casify_object, casify_region): Now static.
2290 (casify_region): Mark local as initialized.
2291
2292 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2293
2294 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2295 New macros, so that the caller can use some names other than
2296 gcpro1, gcpro2, etc.
2297 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2298 of the new macros.
2299 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2300 argument, for consistency with GCPRO2_VAR, etc: it is now the
2301 prefix of the variable, not the variable itself. All uses
2302 changed.
2303 * dired.c (directory_files_internal, file_name_completion):
2304 Rename locals to avoid shadowing.
2305
2306 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2307 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2308 dired.c's scmp function, had undefined behavior.
2309 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2310 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2311 * buffer.h: ... to here, because these macros use current_buffer,
2312 and the new implementation with inline functions needs to have
2313 current_buffer in scope now, rather than later when the macros
2314 are used.
2315 (downcase, upcase1): New static inline functions.
2316 (DOWNCASE, UPCASE1): Reimplement using these functions.
2317 This avoids undefined behavior in expressions like
2318 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2319 from race conditions in accessing the global variables
2320 case_temp1 and case_temp2.
2321 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2322 * lisp.h (case_temp1, case_temp2): Remove their decls.
2323 * character.h (ASCII_CHAR_P): Move from here ...
2324 * lisp.h: ... to here, so that the inline functions mentioned
2325 above can use them.
2326
2327 * dired.c (directory_files_internal_unwind): Now static.
2328
2329 * fileio.c (file_name_as_directory, directory_file_name):
2330 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2331 Now static.
2332 (file_name_as_directory): Use const pointers when appropriate.
2333 (Fexpand_file_name): Likewise. In particular, newdir might
2334 point at constant storage, so make it a const pointer.
2335 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2336 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2337 signedness issues.
2338 (Fset_file_times, Finsert_file_contents, auto_save_error):
2339 Rename locals to avoid shadowing.
2340
2341 * minibuf.c (choose_minibuf_frame_1): Now static.
2342 (Ftry_completion, Fall_completions): Rename or remove locals
2343 to avoid shadowing.
2344
2345 * marker.c (bytepos_to_charpos): Remove; unused.
2346
2347 * lisp.h (verify_bytepos, count_markers): New decls,
2348 so that gcc does not warn that these functions aren't declared.
2349
2350 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2351 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2352 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2353 (copy_text): Remove unused local var.
2354
2355 * filelock.c (within_one_second): Now static.
2356 (lock_file_1): Rename local to avoid shadowing.
2357
2358 * buffer.c (fix_overlays_before): Mark locals as initialized.
2359 (fix_start_end_in_overlays): Likewise. This function should be
2360 simplified by using pointers-to-pointers, but that's a different
2361 matter.
2362 (switch_to_buffer_1): Now static.
2363 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2364 (report_overlay_modification): Rename locals to avoid shadowing.
2365
2366 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2367 Fix pointer signedness issue.
2368 (sys_subshell): Mark local as volatile if checking for lint,
2369 to suppress a gcc -Wclobbered warning that does not seem to be right.
2370 (MAXPATHLEN): Define only if needed.
2371
2372 * process.c (serial_open, serial_configure): Move decls from here ...
2373 * systty.h: ... to here, so that they can be checked.
2374
2375 * fns.c (get_random, seed_random): Move extern decls from here ...
2376 * lisp.h: ... to here, so that they can be checked.
2377
2378 * sysdep.c (reset_io): Now static.
2379 (wait_for_termination_signal): Remove; unused.
2380
2381 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2382 (copy_keymap_item, append_key, push_text_char_description):
2383 Now static.
2384 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2385 (DENSE_TABLE_SIZE): Remove; unused.
2386 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2387 (describe_map_tree):
2388 Rename locals to avoid shadowing.
2389
2390 * keyboard.c: Declare functions static if they are not used elsewhere.
2391 (echo_char, echo_dash, cmd_error, top_level_2):
2392 (poll_for_input, handle_async_input): Now static.
2393 (read_char, kbd_buffer_get_event, make_lispy_position):
2394 (make_lispy_event, make_lispy_movement, apply_modifiers):
2395 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2396 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2397 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2398 (read_key_sequence, read_char): Mark locals as initialized.
2399 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2400
2401 * keyboard.h (make_ctrl_char): New decl.
2402 (mark_kboards): Move decl here ...
2403 * alloc.c (mark_kboards): ... from here.
2404
2405 * lisp.h (force_auto_save_soon): New decl.
2406
2407 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2408 (DEFINE_DUMMY_FUNCTION): New macro.
2409 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2410 Use it.
2411 (main): Add casts to avoid warnings
2412 if GCC considers string literals to be constants.
2413
2414 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2415
2416 * dbusbind.c: Pointer signedness fixes.
2417 (xd_signature, xd_append_arg, xd_initialize):
2418 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2419 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2420 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2421 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2422
2423 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2424 if GCC considers string literals to be constants.
2425 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2426
2427 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2428
2429 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2430 (print_preprocess, print_object): New macro to fix last change.
2431
2432 * print.c (print_preprocess): Don't forget font objects.
2433
2434 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2435
2436 * emacs.c (USAGE3): Doc fixes.
2437
2438 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2439
2440 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2441 structure.
2442
2443 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2444
2445 * lisp.h (VWindow_system, Qfile_name_history):
2446 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2447 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2448 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2449
2450 * w32select.c: Don't #include "keyboard.h".
2451 (run_protected): Add extern declaration for waiting_for_input.
2452
2453 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2454 * w32console.c (detect_input_pending, read_input_pending)
2455 (encode_terminal_code):
2456 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2457 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2458 (w32_system_caret_y, Qfile_name_history):
2459 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2460 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2461 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2462 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2463 * w32proc.c (Qlocal, report_file_error):
2464 * w32term.c (Vwindow_system, updating_frame):
2465 * w32uniscribe.c (initialized, uniscribe_font_driver):
2466 Remove unneeded extern declarations.
2467
2468 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2469
2470 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2471
2472 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2473
2474 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2475 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2476 These macros can no longer be used for assignment.
2477
2478 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2479 Assign struct members directly, instead of using BUF_BEGV etc.
2480 (record_buffer_markers, fetch_buffer_markers): New functions for
2481 recording and fetching special buffer markers.
2482 (set_buffer_internal_1, set_buffer_temp): Use them.
2483
2484 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2485
2486 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2487
2488 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2489 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2490
2491 * xdisp.c (hscroll_window_tree):
2492 (reconsider_clip_changes): Use PT instead of BUF_PT.
2493
2494 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2495
2496 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2497 $(EMACS_ROOT)/lib/intprops.h.
2498
2499 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2500
2501 Fix more problems found by GCC 4.5.2's static checks.
2502
2503 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2504 to unsigned char * to avoid compiler diagnostic.
2505 (xg_free_frame_widgets): Make it clear that a local variable is
2506 needed only if USE_GTK_TOOLTIP.
2507 (gdk_window_get_screen): Make it clear that this macro is needed
2508 only if USE_GTK_TOOLTIP.
2509 (int_gtk_range_get_value): New function, which avoids a diagnostic
2510 from gcc -Wbad-function-cast.
2511 (xg_set_toolkit_scroll_bar_thumb): Use it.
2512 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2513 diagnostic from gcc -Wbad-function-cast.
2514 (get_utf8_string, xg_get_file_with_chooser):
2515 Rename locals to avoid shadowing.
2516 (create_dialog): Move locals to avoid shadowing.
2517
2518 * xgselect.c (xg_select): Remove unused var.
2519
2520 * image.c (four_corners_best): Mark locals as initialized.
2521 (gif_load): Initialize transparent_p to zero (Bug#8238).
2522 Mark another local as initialized.
2523 (my_png_error, my_error_exit): Mark with NO_RETURN.
2524
2525 * image.c (clear_image_cache): Now static.
2526 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2527 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2528 (x_edge_detection): Remove unnecessary cast that
2529 gcc -Wbad-function-cast diagnoses.
2530 (gif_load): Fix pointer signedness.
2531 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2532 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2533
2534 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2535
2536 Improve quality of tests for time stamp overflow.
2537 For example, without this patch (encode-time 0 0 0 1 1
2538 1152921504606846976) returns the obviously-bogus value (-948597
2539 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2540 reports time overflow. See
2541 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2542 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2543 * editfns.c: Include limits.h and intprops.h.
2544 (TIME_T_MIN, TIME_T_MAX): New macros.
2545 (time_overflow): Move earlier, to before first use.
2546 (hi_time, lo_time): New functions, for an accurate test for
2547 out-of-range times.
2548 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2549 (Fget_internal_run_time): Don't assume time_t fits in int.
2550 (make_time): Use list2 instead of Fcons twice.
2551 (Fdecode_time): More accurate test for out-of-range times.
2552 (check_tm_member): New function.
2553 (Fencode_time): Use it, to test for out-of-range times.
2554 (lisp_time_argument): Don't rely on undefined left-shift and
2555 right-shift behavior when checking for time stamp overflow.
2556
2557 * editfns.c (time_overflow): New function, refactoring common code.
2558 (Fformat_time_string, Fdecode_time, Fencode_time):
2559 (Fcurrent_time_string): Use it.
2560
2561 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2562 * dired.c (make_time): Move to ...
2563 * editfns.c (make_time): ... here.
2564 * systime.h: Note the move.
2565
2566 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2567
2568 * fringe.c (update_window_fringes): Remove unused variables.
2569
2570 * unexmacosx.c (copy_data_segment): Also copy __got section.
2571 (Bug#8223)
2572
2573 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2574
2575 * termcap.c [MSDOS]: Include "msdos.h".
2576 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2577 Constify `char *' arguments and their references according to
2578 prototypes in tparam.h.
2579
2580 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2581
2582 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2583 Adapt all references accordingly.
2584
2585 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2586
2587 2011-03-11 Tom Tromey <tromey@redhat.com>
2588
2589 * buffer.c (syms_of_buffer): Remove obsolete comment.
2590
2591 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2592
2593 * termhooks.h (encode_terminal_code): Declare prototype.
2594
2595 * msdos.c (encode_terminal_code): Don't declare prototype.
2596
2597 * term.c (encode_terminal_code): Now external again, used by
2598 w32console.c and msdos.c.
2599
2600 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2601 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2602
2603 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2604
2605 Fix some minor problems found by GCC 4.5.2's static checks.
2606
2607 * fringe.c (update_window_fringes): Mark locals as initialized
2608 (Bug#8227).
2609 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2610
2611 * alloc.c (mark_fringe_data): Move decl from here ...
2612 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2613 to check its interface.
2614 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2615
2616 * fontset.c (free_realized_fontset): Now static.
2617 (Fset_fontset_font): Rename local to avoid shadowing.
2618 (fontset_font): Mark local as initialized.
2619 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2620
2621 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2622
2623 * xselect.c (x_disown_buffer_selections): Remove; not used.
2624 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2625 (x_own_selection, Fx_disown_selection_internal): Rename locals
2626 to avoid shadowing.
2627 (x_handle_dnd_message): Remove local to avoid shadowing.
2628
2629 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2630 so that the caller can use some name other than gcpro1.
2631 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2632 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2633 (Fx_backspace_delete_keys_p):
2634 Use them to avoid shadowing, and rename vars to avoid shadowing.
2635 (x_decode_color, x_set_name, x_window): Now static.
2636 (Fx_create_frame): Add braces to silence GCC warning.
2637 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2638 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2639 Remove unused locals.
2640 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2641 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2642 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2643 macros.
2644
2645 * xterm.h (x_mouse_leave): New decl.
2646
2647 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2648 Remove unused functions.
2649 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2650 (x_calc_absolute_position): Now static.
2651 (XTread_socket): Don't define label "out" unless it's used.
2652 Don't declare local "event" unless it's used.
2653 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2654 unless they are used.
2655 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2656 (x_fatal_error_signal): Remove; not used.
2657 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2658 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2659 (x_error_catcher, x_connection_closed, x_error_handler):
2660 (x_error_quitter, xembed_send_message, x_iconify_frame):
2661 (my_log_handler): Rename locals to avoid shadowing.
2662 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2663 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2664
2665 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2666 Rename or move locals to avoid shadowing.
2667 (tty_defined_color, merge_face_heights): Now static.
2668 (free_realized_faces_for_fontset): Remove; not used.
2669 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2670 does not deduce is never used uninitialized.
2671 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2672 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2673
2674 * terminal.c (store_terminal_param): Now static.
2675
2676 * xmenu.c (menu_highlight_callback): Now static.
2677 (set_frame_menubar): Remove unused local.
2678 (xmenu_show): Rename parameter to avoid shadowing.
2679 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2680 since they might point to immutable storage.
2681 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2682 since it's unused otherwise.
2683
2684 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2685 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2686 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2687 avoids a gcc -Wuninitialized diagnostic.
2688 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2689 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2690 does not deduce are never used uninitialized.
2691
2692 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2693
2694 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2695 * window.c (window_loop, size_window):
2696 (run_window_configuration_change_hook, enlarge_window): Likewise.
2697
2698 * window.c (display_buffer): Now static.
2699 (size_window): Mark variables that gcc -Wuninitialized
2700 does not deduce are never used uninitialized.
2701 * window.h (check_all_windows): New decl, to forestall
2702 gcc -Wmissing-prototypes diagnostic.
2703 * dispextern.h (bidi_dump_cached_states): Likewise.
2704
2705 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2706 shadowing.
2707 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2708 Include <limits.h>.
2709 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2710 and to avoid gcc -Wuninitialized warning.
2711 (load_charset_map): Mark variables that gcc -Wuninitialized
2712 does not deduce are never used uninitialized.
2713 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2714
2715 * coding.c (coding_set_source, coding_set_destination):
2716 Use "else { /* comment */ }" rather than "else /* comment */;"
2717 for clarity, and to avoid gcc -Wempty-body warning.
2718 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2719 a block, when the outer 'i' will do.
2720 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2721 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2722 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2723 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2724 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2725 Rename locals to avoid shadowing.
2726 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2727 * coding.c (emacs_mule_char, encode_invocation_designation):
2728 Now static, since they're not used elsewhere.
2729 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2730 (decode_coding_object, encode_coding_object, detect_coding_system):
2731 (decode_coding_emacs_mule): Mark variables that gcc
2732 -Wuninitialized does not deduce are never used uninitialized.
2733 (detect_coding_iso_2022): Initialize a local variable that might
2734 be used uninitialized. Leave a FIXME because it's not clear that
2735 this initialization is needed. (Bug#8211)
2736 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2737 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2738 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2739 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2740 Remove unused macros.
2741
2742 * category.c (hash_get_category_set): Remove unused local var.
2743 (copy_category_table): Now static, since it's not used elsewhere.
2744 * character.c (string_count_byte8): Likewise.
2745
2746 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2747 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2748
2749 * chartab.c (copy_sub_char_table): Now static, since it's not used
2750 elsewhere.
2751 (sub_char_table_ref_and_range, char_table_ref_and_range):
2752 Rename locals to avoid shadowing.
2753 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2754
2755 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2756 (BIDI_BOB): Remove unused macro.
2757
2758 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2759 deduce are never used uninitialized.
2760 * term.c (encode_terminal_code): Likewise.
2761
2762 * term.c (encode_terminal_code): Now static. Remove unused local.
2763
2764 * tparam.h: New file.
2765 * term.c, tparam.h: Include it.
2766 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2767 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2768 Move these decls to tparam.h, and make them agree with what
2769 is actually in tparam.c. The previous trick of using incompatible
2770 decls in different modules does not conform to the C standard.
2771 All callers of tparam changed to use tparam's actual API.
2772 * tparam.c (tparam1, tparam, tgoto):
2773 Use const pointers where appropriate.
2774
2775 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2776 * cm.h (struct cm): Likewise.
2777 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2778 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2779 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2780 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2781 (turn_on_face, init_tty): Likewise.
2782 * termchar.h (struct tty_display_info): Likewise.
2783
2784 * term.c (term_mouse_position): Rename local to avoid shadowing.
2785
2786 * alloc.c (mark_ttys): Move decl from here ...
2787 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2788
2789 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2790
2791 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2792
2793 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2794
2795 * search.c (compile_pattern_1): Remove argument regp, unused since
2796 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2797 (compile_pattern): Don't pass it.
2798
2799 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2800
2801 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2802 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2803 for ! HAVE_GTK3.
2804 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2805
2806 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2807
2808 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2809 gdk_window_get_screen, gdk_window_get_geometry,
2810 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2811 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2812 (xg_get_pixbuf_from_pixmap): New function.
2813 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2814 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2815 Call xg_get_pixbuf_from_pixmap instead of
2816 gdk_pixbuf_get_from_drawable.
2817 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2818 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2819 (xg_check_special_colors): Use GtkStyleContext and its functions
2820 for HAVE_GTK3.
2821 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2822 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2823 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2824 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2825 Call gtk_widget_get_preferred_size.
2826 (xg_frame_resized): gdk_window_get_geometry only takes 5
2827 parameters.
2828 (xg_win_to_widget, xg_event_is_for_menubar):
2829 Call gdk_x11_window_lookup_for_display.
2830 (xg_set_widget_bg): New function.
2831 (delete_cb): New function.
2832 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2833 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2834 (xg_set_background_color): Call xg_set_widget_bg.
2835 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2836 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2837 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2838 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2839 if ! HAVE_GTK3.
2840 (update_frame_tool_bar): Call gtk_widget_hide.
2841 (xg_initialize): Use GDK_KEY_g.
2842
2843 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2844 if ! HAVE_GTK3
2845 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2846
2847 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2848 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2849 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2850
2851 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2852
2853 * w32xfns.c (select_palette): Check success of RealizePalette against
2854 GDI_ERROR, not zero.
2855
2856 See ChangeLog.11 for earlier changes.
2857
2858 ;; Local Variables:
2859 ;; coding: utf-8
2860 ;; End:
2861
2862 Copyright (C) 2011 Free Software Foundation, Inc.
2863
2864 This file is part of GNU Emacs.
2865
2866 GNU Emacs is free software: you can redistribute it and/or modify
2867 it under the terms of the GNU General Public License as published by
2868 the Free Software Foundation, either version 3 of the License, or
2869 (at your option) any later version.
2870
2871 GNU Emacs is distributed in the hope that it will be useful,
2872 but WITHOUT ANY WARRANTY; without even the implied warranty of
2873 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2874 GNU General Public License for more details.
2875
2876 You should have received a copy of the GNU General Public License
2877 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.