Remove unused external symbols.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2
3 Remove unused external symbols.
4 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5 * xdisp.c (calc_pixel_width_or_height): Now static.
6 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7 * indent.c (check_display_width):
8 * w32term.c: Fix comment to match code.
9 * xterm.c, xterm.h (x_catching_errors): Remove.
10
11 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
12
13 * xselect.c: Use signed conversions more consistently (Bug#9498).
14 (selection_data_to_lisp_data): Assume incoming selection data are
15 signed integers, not unsigned. This is to be consistent with
16 outgoing selection data, which was modified to use signed integers
17 in as part of the fix to Bug#9196 in response to Jan D.'s comment
18 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
19 expects long, not unsigned long.
20
21 2011-09-14 Eli Zaretskii <eliz@gnu.org>
22
23 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
24 computation of loop end. Reported by Johan Bockgård
25 <bojohan@gnu.org>.
26
27 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
28
29 * frame.c (Fother_visible_frames_p): Function deleted.
30
31 2011-09-12 Eli Zaretskii <eliz@gnu.org>
32
33 * indent.c (compute_motion): Process display vector front to back
34 rather than the other way around. (Bug#2496)
35
36 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
37
38 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
39
40 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
41
42 * minibuf.c (Fread_from_minibuffer): Doc fix.
43
44 2011-09-11 Eli Zaretskii <eliz@gnu.org>
45
46 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
47 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
48
49 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
50
51 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
52 value for non-existent files.
53
54 2011-09-11 Eli Zaretskii <eliz@gnu.org>
55
56 * fileio.c (Finsert_file_contents): If the file cannot be opened,
57 set its "size" to -1. This will set the modtime_size field of
58 the corresponding buffer to -1, which is what
59 verify-visited-file-modtime expects for files that do not exist.
60 (Bug#9139)
61
62 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
63
64 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
65 here ...
66 * lisp.h: ... from here. push_key_description is no longer
67 defined in keyboard.c, so its declaration should not be in
68 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
69 logically belongs with push_key_description.
70
71 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
72
73 * buffer.h: Include <sys/types.h> instead of <time.h>.
74 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
75 Problem reported by Herbert J. Skuhra.
76
77 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
78
79 * xml.c (parse_region): Make the parsing work for
80 non-comment-starting XML files again (bug#9144).
81
82 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
83
84 * image.c (gif_load): Fix calculation of bottom and right corner.
85 (Bug#9468)
86
87 2011-09-10 Eli Zaretskii <eliz@gnu.org>
88
89 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
90 redisplay in small windows.
91
92 2011-09-09 Eli Zaretskii <eliz@gnu.org>
93
94 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
95
96 2011-09-08 Martin Rudalics <rudalics@gmx.at>
97
98 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
99 Operate on live windows only.
100
101 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
102
103 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
104
105 2011-09-07 Eli Zaretskii <eliz@gnu.org>
106
107 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
108 only under bidi iteration.
109
110 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
111
112 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
113
114 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
115
116 isnan: Fix porting problem to Solaris 10 with bundled gcc.
117 Without this fix, the command to link temacs failed due to an
118 undefined symbol __builtin_isnan. This is because
119 /usr/include/iso/math_c99.h #defines isnan(x) to
120 __builtin_isnan(x), but the bundled gcc, which identifies itself
121 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
122 a __builtin_isnan.
123 * floatfns.c (isnan): #undef, and then #define to a clone of
124 what's in data.c.
125 (Fisnan): Always define, since it's always available now.
126 (syms_of_floatfns): Always define isnan at the Lisp level.
127
128 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
129
130 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
131
132 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
133
134 * fileio.c: Fix bugs with large file offsets (Bug#9428).
135 The previous code assumed that file offsets (off_t values) fit in
136 EMACS_INT variables, which is not true on typical 32-bit hosts.
137 The code messed up by falsely reporting buffer overflow in cases
138 such as (insert-file-contents "big" nil 1 2) into an empty buffer
139 when "big" contains more than 2**29 bytes, even though this
140 inserts just one byte and does not overflow the buffer.
141 (Finsert_file_contents): Store file offsets as off_t
142 values, not as EMACS_INT values. Check for overflow when
143 converting between EMACS_INT and off_t. When checking for
144 buffer overflow or for overlap, take the offsets into account.
145 Don't use EMACS_INT for small values where int suffices.
146 When checking for overlap, fix a typo: ZV was used where
147 ZV_BYTE was intended.
148 (Fwrite_region): Don't assume off_t fits into 'long'.
149 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
150
151 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
152
153 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
154
155 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
156
157 sprintf-related integer and memory overflow issues (Bug#9412).
158
159 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
160 (esprintf, exprintf, evxprintf): New functions.
161 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
162 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
163 (modify_event_symbol): Do not assume that the length of
164 name_alist_or_stem is safe to alloca and fits in int.
165 (Fexecute_extended_command): Likewise for function name and binding.
166 (Frecursion_depth): Wrap around reliably on integer overflow.
167 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
168 since some callers pass EMACS_INT values.
169 (Fsingle_key_description): Don't crash if symbol name contains more
170 than MAX_ALLOCA bytes.
171 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
172 (get_minibuffer): Arg is now EMACS_INT, not int.
173 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
174 (esprintf, exprintf, evxprintf): New decls.
175 * window.h (command_loop_level, minibuf_level): Reflect API changes.
176
177 * dbusbind.c (signature_cat): New function.
178 (xd_signature, Fdbus_register_signal):
179 Do not overrun buffer; instead, report string overflow.
180
181 * dispnew.c (add_window_display_history): Don't overrun buffer.
182 Truncate instead; this is OK since it's just a log.
183
184 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
185 even if the time zone offset is outlandishly large.
186 Don't mishandle offset == INT_MIN.
187
188 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
189 when creating daemon; the previous buffer-overflow check was incorrect.
190
191 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
192 which has the guts of the old verror function.
193
194 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
195 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
196
197 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
198 (font_unparse_xlfd): Don't blindly alloca long strings.
199 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
200 fits in int, when using sprintf. Use single snprintf to count
201 length of string rather than counting it via multiple sprintfs;
202 that's simpler and more reliable.
203 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
204 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
205 sprintf, in case result does not fit in int.
206
207 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
208 (fontset_from_font): Print it.
209
210 * frame.c (tty_frame_count): Now printmax_t, not int.
211 (make_terminal_frame, set_term_frame_name): Print it.
212 (x_report_frame_params): In X, window IDs are unsigned long,
213 not signed long, so print them as unsigned.
214 (validate_x_resource_name): Check for implausibly long names,
215 and don't assume name length fits in 'int'.
216 (x_get_resource_string): Don't blindly alloca invocation name;
217 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
218 not fit in int.
219
220 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
221 (xg_check_special_colors, xg_set_geometry):
222 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
223
224 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
225 Use esprintf, not sprintf, in case result does not fit in int.
226
227 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
228 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
229 it as a large positive number.
230 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
231 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
232
233 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
234 in case result does not fit in int.
235
236 * print.c (float_to_string): Detect width overflow more reliably.
237 (print_object): Make sprintf buffer a bit bigger, to avoid potential
238 buffer overrun. Don't assume list length fits in 'int'. Treat
239 print length of 0 as 0, not as infinity; to be consistent with other
240 uses of print length in this function. Don't overflow print length
241 index. Don't assume hash table size fits in 'long', or that
242 vectorlike size fits in 'unsigned long'.
243
244 * process.c (make_process): Use printmax_t, not int, to format
245 process-name gensyms.
246
247 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
248
249 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
250 to avoid potential buffer overrun.
251
252 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
253 if X resource line is longer than 512 bytes.
254
255 * xfns.c (x_window): Make sprintf buffer a bit bigger
256 to avoid potential buffer overrun.
257
258 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
259
260 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
261
262 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
263
264 Integer overflow fixes for scrolling, etc.
265 Without these, Emacs silently mishandles large integers sometimes.
266 For example, "C-u 4294967297 M-x recenter" was treated as if
267 it were "C-u 1 M-x recenter" on a typical 64-bit host.
268
269 * xdisp.c (try_window_id): Check Emacs fixnum range before
270 converting to 'int'.
271
272 * window.c (window_scroll_line_based, Frecenter):
273 Check that an Emacs fixnum is in range before assigning it to 'int'.
274 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
275 values converted from Emacs fixnums.
276 (Frecenter): Don't wrap around a line count if it is out of 'int'
277 range; instead, treat it as an extreme value.
278 (Fset_window_configuration, compare_window_configurations):
279 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
280
281 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
282 that can exceed INT_MAX. Check that EMACS_INT value is in range
283 before assigning it to the (possibly-narrower) index.
284 (match_limit): Don't assume that a fixnum can fit in 'int'.
285
286 * print.c (print_object): Use ptrdiff_t, not int, for index that can
287 exceed INT_MAX.
288
289 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
290 (Fvertical_motion): Don't wrap around LINES values that don't fit
291 in 'int'. Instead, treat them as extreme values. This is good
292 enough for windows, which can't have more than INT_MAX lines anyway.
293
294 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
295
296 * Require libxml/parser.h to avoid compilation warning.
297
298 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
299
300 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
301 since this reportedly can destroy thread storage.
302
303 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
304
305 * syntax.c (find_defun_start): Update all cache variables if
306 exiting early (Bug#9401).
307
308 2011-08-30 Eli Zaretskii <eliz@gnu.org>
309
310 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
311
312 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
313 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
314 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
315
316 * term.c (tty_append_glyph): New function.
317 (produce_stretch_glyph): Static function and its prototype deleted.
318
319 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
320 prototypes.
321
322 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
323
324 * image.c (parse_image_spec): Check for nonnegative, not for positive,
325 when checking :margin (Bug#9390).
326 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
327 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
328 so that the name doesn't mislead. All uses changed.
329
330 2011-08-28 Johan Bockgård <bojohan@gnu.org>
331
332 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
333 set_tty_hooks.
334
335 2011-08-27 Eli Zaretskii <eliz@gnu.org>
336
337 * xdisp.c (move_it_to): Don't bail out early when reaching
338 position beyond to_charpos, if we are scanning backwards.
339 (move_it_vertically_backward): When DY == 0, make sure we get to
340 the first character in the line after the newline.
341
342 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
343
344 * ccl.c: Improve and simplify overflow checking (Bug#9196).
345 (ccl_driver): Do not generate an out-of-range pointer.
346 (Fccl_execute_on_string): Remove unnecessary check for
347 integer overflow, noted by Stefan Monnier in
348 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
349 Remove a FIXME that didn't need fixing.
350 Simplify the newly-introduced buffer reallocation code.
351
352 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
353
354 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
355
356 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
357
358 Integer and memory overflow issues (Bug#9196).
359
360 * doc.c (get_doc_string): Rework so that
361 get_doc_string_buffer_size is the actual buffer size, rather than
362 being 1 less than the actual buffer size; this makes xpalloc more
363 convenient.
364
365 * image.c (x_allocate_bitmap_record, cache_image):
366 * xselect.c (Fx_register_dnd_atom):
367 Simplify previous changes by using xpalloc.
368
369 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
370 since either will do and ptrdiff_t is convenient with xpalloc.
371
372 * charset.c (charset_table_size)
373 (struct charset_sort_data.priority): Now ptrdiff_t.
374 (charset_compare): Don't overflow if priorities differ greatly.
375 (Fsort_charsets): Don't assume list length fits in int.
376 Check for size-calculation overflow when allocating sort data.
377 (syms_of_charset): Allocate an initial charset table that is
378 just under 64 KiB, to avoid problems with glibc malloc and mmap.
379
380 * cmds.c (internal_self_insert): Check for size-calculation overflow.
381
382 * composite.h (struct composition.glyph_len): Now int, not unsigned.
383 The actual value is always <= INT_MAX, and leaving it unsigned made
384 overflow checking harder.
385
386 * dispextern.h (struct glyph_matrix.rows_allocated)
387 (struct face_cache.size): Now ptrdiff_t, for convenience in use
388 with xpalloc. The values are still always <= INT_MAX.
389
390 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
391
392 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
393 (SAFE_NALLOCA): New macro.
394
395 * region-cache.c (struct boundary.pos, find_cache_boundary)
396 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
397 (set_cache_region, invalidate_region_cache)
398 (revalidate_region_cache, know_region_cache, region_cache_forward)
399 (region_cache_backward, pp_cache):
400 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
401 so that ptrdiff_t * can be passed to xpalloc.
402 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
403 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
404 (pp_cache): Don't assume cache_len fits in int.
405 * region-cache.h: Adjust extern decls to match.
406
407 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
408 EMACS_INT, since either will do, for xpalloc.
409
410 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
411 (xnmalloc, xnrealloc, xpalloc): New functions.
412
413 * bidi.c (bidi_shelve_header_size): New constant.
414 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
415 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
416
417 * bidi.c (bidi_cache_shrink):
418 * buffer.c (overlays_at, overlays_in, record_overlay_string)
419 (overlay_strings):
420 Don't update size of array until after memory allocation succeeds,
421 because xmalloc/xrealloc may not return.
422 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
423 now that we have proper integer overflow checking.
424 (record_overlay_string, overlay_strings): Catch overflows when
425 calculating size of overlay_str_buf.
426
427 * callproc.c (Fcall_process): Check for size overflow when
428 calculating size of args2.
429 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
430 Normally we prefer signed values, but sticking with ptrdiff_t would
431 require adding more-complicated checks.
432
433 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
434 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
435 Redo buffer-overflow calculations to avoid integer overflow.
436 Add a FIXME comment where memory seems to be over-allocated.
437
438 * character.c (Fstring): Check for size-calculation overflow.
439
440 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
441 unnecessary integer overflow. Check for size overflow.
442 (encode_coding_object): Don't update size until xmalloc succeeds.
443
444 * composite.c (get_composition_id): Check for overflow in glyph
445 length calculations.
446
447 Integer and memory overflow fixes for display code.
448 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
449 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
450 (scrolling_window): Check for overflow in size calculations.
451 (line_draw_cost, realloc_glyph_pool, add_row_entry):
452 Don't assume glyph table len fits in int.
453 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
454 (row_table_size): Now ptrdiff_t, not int.
455 (scrolling_window): Avoid overflow in size calculations.
456 Don't update size until allocation succeeds.
457 * fns.c (concat): Check for overflow in size calculations.
458 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
459 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
460 (NEXT_ALMOST_PRIME_LIMIT): New constant.
461
462 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
463 (get_doc_string): Check for size calculation overflow.
464 Don't update size until allocation succeeds.
465 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
466 EMACS_INT, where ptrdiff_t will do.
467 (Fsubstitute_command_keys): Check for string overflow.
468
469 * editfns.c (set_time_zone_rule): Don't assume environment length
470 fits in int.
471 (message_length): Now ptrdiff_t, not int.
472 (Fmessage_box): Don't update size until allocation succeeds.
473 Don't assume message length fits in int.
474 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
475
476 * emacs.c (main): Do not reallocate argv, since there is a null at
477 the end that can be overwritten, and this way there's no need to
478 worry about size-calculation overflow.
479 (sort_args): Check for size-calculation overflow.
480
481 * eval.c (init_eval_once, grow_specpdl): Don't update size until
482 alloc succeeds.
483 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
484
485 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
486 (x_set_scroll_bar_width, x_figure_window_size):
487 Check for integer overflow.
488 (x_set_alpha): Do not assume XINT fits in int.
489
490 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
491 This is for the members text_lines, text_cols, total_lines, total_cols,
492 where the system imposes an 'int' limit.
493
494 * fringe.c (Fdefine_fringe_bitmap):
495 Don't update size until alloc works.
496
497 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
498 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
499
500 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
501 Check for size-calculation overflow.
502 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
503 do, as we prefer signed integers.
504 (id_to_widget.max_size, id_to_widget.used)
505 (xg_store_widget_in_map, xg_remove_widget_from_map)
506 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
507 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
508 Use and return ptrdiff_t, not int.
509 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
510 * gtkutil.h: Change prototypes to match the above.
511
512 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
513 are duplicate now that they've been promoted to lisp.h.
514 (x_allocate_bitmap_record, x_alloc_image_color)
515 (make_image_cache, cache_image, xpm_load):
516 Don't update size until alloc is done.
517 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
518 (x_detect_edges):
519 Check for size calculation overflow.
520 (ct_colors_allocated_max): New constant.
521 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
522 overflow.
523
524 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
525 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
526 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
527 Use ptrdiff_t, not int, to count maps.
528 (read_char_minibuf_menu_prompt): Check for overflow in size
529 calculations. Don't update size until allocation succeeds. Redo
530 calculations to avoid overflow.
531 * keyboard.h: Change prototypes to match the above.
532
533 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
534 to count maps.
535 (current_minor_maps): Check for size calculation overflow.
536 * keymap.h: Change prototypes to match the above.
537
538 * lread.c (read1, init_obarray): Don't update size until alloc done.
539
540 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
541 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
542
543 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
544 Now ptrdiff_t, not int.
545 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
546 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
547
548 * process.c (Fnetwork_interface_list): Check for overflow
549 in size calculation.
550
551 * region-cache.c (move_cache_gap): Check for size calculation overflow.
552
553 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
554 overflow. Don't bother calling xmalloc when xrealloc will do.
555
556 * search.c (Freplace_match): Check for size calculation overflow.
557 (Fset_match_data): Don't assume list lengths fit in 'int'.
558
559 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
560 for command line length. Do not attempt to address one before the
561 beginning of an array, as that's not portable.
562
563 * term.c (max_frame_lines): Remove; unused.
564 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
565 not int.
566 (encode_terminal_code, calculate_costs): Check for size
567 calculation overflow.
568 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
569 table lengths and related sizes. Don't update size until alloc
570 done. Redo calculations to avoid overflow.
571 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
572
573 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
574 subtracting pointers.
575 (gobble_line): Check for overflow more carefully. Don't update size
576 until alloc done.
577
578 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
579 Don't update size until alloc done.
580 Redo size calculations to avoid overflow.
581 Check for size calculation overflow.
582 (main) [DEBUG]: Fix typo in invoking tparam1.
583
584 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
585 Use ptrdiff_t, not int, for sizes.
586 (store_mode_line_noprop_char): Don't update size until alloc done.
587
588 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
589 Use ptrdiff_t, not int, for sizes.
590 (Finternal_make_lisp_face, cache_face):
591 Check for size calculation overflow.
592 (cache_face): Treat size calculation overflows as if they were
593 memory exhaustion (the usual treatment), rather than aborting.
594
595 * xfns.c (x_encode_text, x_set_name_internal)
596 (Fx_change_window_property): Use ptrdiff_t, not int, to count
597 sizes, since they can exceed INT_MAX in size. Check for size
598 calculation overflow.
599
600 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
601 (xg_select): Check for size calculation overflow.
602 Don't update size until alloc done.
603
604 * xrdb.c (get_environ_db): Don't assume path length fits in int,
605 as sprintf is limited to int lengths.
606
607 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
608 (X_LONG_MIN): New macros.
609 Use them to make the following changes clearer.
610 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
611 This change doesn't affect the value now, but it may help remind
612 future maintainers not to raise the value too much later.
613 (SELECTION_QUANTUM): Remove, replacing with ...
614 (selection_quantum): ... new function, which avoids overflow.
615 All uses changed.
616 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
617 assumption that selection length fits in 'int'.
618 (x_reply_selection_request, x_handle_selection_request)
619 (x_get_window_property, receive_incremental_selection)
620 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
621 (lisp_data_to_selection_data, clean_local_selection_data):
622 Use ptrdiff_t, not int, to record length of selection.
623 (x_reply_selection_request, x_get_window_property)
624 (receive_incremental_selection, x_property_data_to_lisp):
625 Redo calculations to avoid overflow.
626 (x_reply_selection_request): When sending hint, ceiling it at
627 X_LONG_MAX rather than relying on wraparound overflow to send
628 something.
629 (x_get_window_property, receive_incremental_selection)
630 (lisp_data_to_selection_data, x_property_data_to_lisp):
631 Check for size-calculation overflow.
632 (x_get_window_property, receive_incremental_selection)
633 (lisp_data_to_selection_data, Fx_register_dnd_atom):
634 Don't store size until memory allocation succeeds.
635 (x_get_window_property): Plug memory leak on memory exhaustion.
636 Don't double-block input; malloc is safe here. Don't assume 2**34
637 - 4 fits in unsigned long. Add an xassert to check
638 XGetWindowProperty overflow. Be more careful about overflow
639 calculations, and distinguish size from memory overflow better.
640 (receive_incremental_selection): When tracing, don't assume
641 unsigned int is less than INT_MAX.
642 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
643 harmful) conversions of unsigned short to int.
644 (lisp_data_to_selection_data): Don't assume that integers
645 in the range -65535 through -1 fit in an X unsigned short.
646 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
647 result parameters unless successful. Rely on cons_to_unsigned
648 to report problems with elements; the old code wasn't right anyway.
649 (x_check_property_data): Check for int overflow; we cannot use
650 a wider type due to X limits.
651 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
652
653 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
654
655 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
656 (x_term_init): Check for size calculation overflow.
657 (x_color_cells): Don't store size until memory allocation succeeds.
658 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
659 Don't assume alloca size is less than MAX_ALLOCA.
660 (x_term_init): Don't assume length fits in int (sprintf is limited
661 to int size).
662
663 Use ptrdiff_t for composition IDs.
664 * character.c (lisp_string_width):
665 * composite.c (composition_table_size, n_compositions)
666 (get_composition_id, composition_gstring_from_id):
667 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
668 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
669 * window.c (Frecenter):
670 Use ptrdiff_t, not int, for composition IDs.
671 * composite.c (get_composition_id): Check for integer overflow.
672 * composite.h: Adjust prototypes to match the above changes.
673
674 Use ptrdiff_t for hash table indexes.
675 * category.c (hash_get_category_set):
676 * ccl.c (ccl_driver):
677 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
678 * coding.c (coding_system_charset_list, detect_coding_system):
679 * coding.h (struct coding_system.id):
680 * composite.c (get_composition_id, gstring_lookup_cache):
681 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
682 * image.c (xpm_get_color_table_h):
683 * lisp.h (hash_lookup, hash_put):
684 * minibuf.c (Ftest_completion):
685 Use ptrdiff_t for hash table indexes, not int (which is too
686 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
687 32-bit --with-wide-int hosts).
688
689 * charset.c (Fdefine_charset_internal): Check for integer overflow.
690 Add a FIXME comment about memory leaks.
691 (syms_of_charset): Don't assume xmalloc returns.
692
693 Don't assume that stated character widths fit in int.
694 * character.c (Fchar_width, c_string_width, lisp_string_width):
695 * character.h (CHAR_WIDTH):
696 * indent.c (MULTIBYTE_BYTES_WIDTH):
697 Use sanitize_char_width to avoid undefined and/or bad behavior
698 with outlandish widths.
699 * character.h (sanitize_tab_width): Renamed from sanitize_width,
700 now that we have two such functions. All uses changed.
701 (sanitize_char_width): New inline function.
702
703 Don't assume that tab-width fits in int.
704 * character.h (sanitize_width): New inline function.
705 (SANE_TAB_WIDTH): New macro.
706 (ASCII_CHAR_WIDTH): Use it.
707 * indent.c (sane_tab_width): Remove. All uses replaced by
708 SANE_TAB_WIDTH (current_buffer).
709 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
710
711 * fileio.c: Integer overflow issues with file modes.
712 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
713
714 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
715 Remove unreachable code.
716 (read_hex, load_charset_map_from_file): Check for integer overflow.
717
718 * xterm.c: don't go over XClientMessageEvent limit
719 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
720 (x_send_scroll_bar_event): Likewise. Check that the size does not
721 exceed limits imposed by XClientMessageEvent, as well as the usual
722 ptrdiff_t and size_t limits.
723
724 * keyboard.c: Overflow, signedness and related fixes.
725 (make_lispy_movement): Use same integer type in forward decl
726 that is used in the definition.
727 (read_key_sequence, keyremap_step):
728 Change bufsize argument back to int, undoing my 2011-03-30 change.
729 We prefer signed types, and int is wide enough here.
730 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
731 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
732 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
733 length, not size_t. Use ptrdiff_t for index, not int.
734 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
735 possibility of integer overflow.
736
737 Overflow, signedness and related fixes for images.
738
739 * dispextern.h (struct it.stack[0].u.image.image_id)
740 (struct_it.image_id, struct image.id, struct image_cache.size)
741 (struct image_cache.used, struct image_cache.ref_count):
742 * gtkutil.c (update_frame_tool_bar):
743 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
744 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
745 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
746 * nsmenu.m (update_frame_tool_bar):
747 * xdisp.c (calc_pixel_width_or_height):
748 * xfns.c (image_cache_refcount):
749 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
750 on typical 64-bit hosts.
751
752 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
753 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
754 Omit unnecessary casts to int.
755 (parse_image_spec): Check that integers fall into 'int' range
756 when the callers expect that.
757 (image_ascent): Redo ascent calculation to avoid int overflow.
758 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
759 (lookup_image): Remove unnecessary tests.
760 (xbm_image_p): Locals are now of int, not EMACS_INT,
761 since parse_image_check makes sure they fit into int.
762 (png_load, gif_load, svg_load_image):
763 Prefer int to unsigned where either will do.
764 (tiff_handler): New function, combining the cores of the
765 old tiff_error_handler and tiff_warning_handler. This
766 function is rewritten to use vsnprintf and thereby avoid
767 stack buffer overflows. It uses only the features of vsnprintf
768 that are common to both POSIX and native Microsoft.
769 (tiff_error_handler, tiff_warning_handler): Use it.
770 (tiff_load, gif_load, imagemagick_load_image):
771 Don't assume :index value fits in 'int'.
772 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
773 (imagemagick_load_image): Check that crop parameters fit into
774 the integer types that MagickCropImage accepts. Don't assume
775 Vimagemagick_render_type has a nonnegative value. Don't assume
776 size_t fits in 'long'.
777 (gs_load): Use printmax_t to print the widest integers possible.
778 Check for integer overflow when computing image height and width.
779
780 2011-08-26 Eli Zaretskii <eliz@gnu.org>
781
782 * xdisp.c (redisplay_window): Don't force window start if point
783 will be invisible in the resulting window. (Bug#9324)
784
785 2011-08-25 Eli Zaretskii <eliz@gnu.org>
786
787 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
788 the display spec is of the form `(space ...)'.
789 (handle_display_spec): Return the value returned by
790 handle_single_display_spec, not just 1 or zero.
791 (handle_single_display_spec): If the display spec is of the form
792 `(space ...)', and specifies display in the text area, return 2
793 rather than 1.
794 (try_cursor_movement): Check for the need to scroll more
795 accurately, and prefer exact match for point under bidi. Don't
796 advance `row' beyond the last row of the window.
797
798 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
799 into disp_prop; all users changed.
800
801 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
802 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
803 for the text covered by the display property.
804
805 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
806
807 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
808 Change return value to nil.
809 (Frecord_buffer): Delete unused function.
810
811 2011-08-24 Eli Zaretskii <eliz@gnu.org>
812
813 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
814 buffers, return left-to-right.
815 (set_cursor_from_row): Consider candidate row a win if its glyph
816 represents a newline and point is on that newline. Fixes cursor
817 positioning on the newline at EOL of R2L text within L2R
818 paragraph, and vice versa.
819 (try_cursor_movement): Check continued rows, in addition to
820 continuation rows. Fixes unwarranted scroll when point enters a
821 continued line of R2L text within an L2R paragraph, or vice versa.
822 (cursor_row_p): Consider the case of point being equal to
823 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
824 from the end of a short line to the beginning of a continued line
825 of R2L text within L2R paragraph.
826 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
827 composed characters.
828
829 * bidi.c (bidi_check_type): Use xassert.
830 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
831 members.
832
833 2011-08-23 Eli Zaretskii <eliz@gnu.org>
834
835 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
836 a character.
837
838 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
839
840 * nsfont.m (ns_otf_to_script): Fix typo.
841
842 2011-08-22 Kenichi Handa <handa@m17n.org>
843
844 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
845 extra slot even if the purpose is char-code-property-table.
846
847 2011-08-23 Eli Zaretskii <eliz@gnu.org>
848
849 * xdisp.c (redisplay_window): When computing centering_position,
850 account for the height of the header line. (Bug#8874)
851
852 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
853 instead of CHAR_TO_BYTE. Fixes a crash when a completion
854 candidate is selected by the mouse, and that candidate has a
855 composed character under the mouse.
856
857 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
858 coordinates reported by pos-visible-in-window-p for a composed
859 character in column zero.
860
861 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
862
863 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
864
865 2011-08-22 Eli Zaretskii <eliz@gnu.org>
866
867 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
868 consider it a hit if to_charpos is anywhere in the range of the
869 composed buffer positions.
870
871 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
872
873 * image.c (gif_load): Don't assume that each subimage has the same
874 dimensions as the base image. Handle disposal method that is
875 "undefined" by the gif spec (Bug#9335).
876
877 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
878
879 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
880 (Fcondition_case): Document `debug' symbol in error handler.
881
882 2011-08-19 Eli Zaretskii <eliz@gnu.org>
883
884 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
885 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
886 from an Org mode buffer to a Speedbar frame.
887
888 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
889 a composition, take its buffer position from IT->cmp_it.charpos.
890 Fixes cursor positioning at the beginning of a line that begins
891 with a composed character.
892
893 2011-08-18 Eli Zaretskii <eliz@gnu.org>
894
895 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
896 character bidirectional type, use STRONG_L instead. Fixes crashes
897 in a buffer produced by `describe-categories'.
898
899 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
900 members before the level stack, so they would be saved and
901 restored when copying iterator state. Fixes incorrect reordering
902 around TABs covered by display properties.
903
904 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
905
906 * process.c (Fnetwork_interface_list): Correctly determine buffer
907 size.
908
909 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
910
911 * eval.c (internal_condition_case, internal_condition_case_1)
912 (internal_condition_case_2, internal_condition_case_n):
913 Remove unnecessary aborts (Bug#9081).
914
915 2011-08-17 Eli Zaretskii <eliz@gnu.org>
916
917 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
918 has no `load' handler, try opening the file locally. (Bug#9311)
919
920 2011-08-16 Ken Brown <kbrown@cornell.edu>
921
922 * gmalloc.c: Expand comment.
923
924 2011-08-16 Eli Zaretskii <eliz@gnu.org>
925
926 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
927 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
928
929 2011-08-16 Ken Brown <kbrown@cornell.edu>
930
931 Fix memory allocation problems in Cygwin build (Bug#9273).
932
933 * unexcw.c ( __malloc_initialized): Declare external variable.
934 (fixup_executable): Force the dumped emacs to reinitialize malloc.
935
936 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
937 New variables.
938 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
939 dumped emacs.
940 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
941 in the static heap.
942 [CYGWIN] (special_realloc): New function.
943 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
944 requests to realloc storage in the static heap.
945
946 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
947
948 * bidi.c (bidi_initialize): Remove unused local.
949
950 2011-08-15 Eli Zaretskii <eliz@gnu.org>
951
952 * biditype.h: File removed.
953
954 * bidimirror.h: File removed.
955
956 * deps.mk (bidi.o): Remove biditype.h and
957 bidimirror.h.
958
959 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
960 bidimirror.h.
961
962 * dispextern.h: Fix a typo in the comment to bidi_type_t.
963
964 * chartab.c: Improve commentary for the uniprop_table API.
965
966 * bidi.c (bidi_paragraph_init): Support zero value of
967 bidi_ignore_explicit_marks_for_paragraph_level.
968 (bidi_initialize): Use uniprop_table instead of including
969 biditype.h and bidimirror.h.
970
971 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
972 coordinates of the iterator when restoring from ppos_it.
973 (Bug#9296)
974
975 2011-08-14 Kenichi Handa <handa@m17n.org>
976
977 * process.c (create_process): Call setup_process_coding_systems
978 after the pid of the process is set to -1 (Bug#8162).
979
980 2011-08-14 Eli Zaretskii <eliz@gnu.org>
981
982 * xdisp.c (move_it_in_display_line_to): Don't invoke
983 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
984 ppos_it. Fixes vertical cursor motion when line beginning is
985 covered by an image. (Bug#9296)
986
987 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
988
989 * nsterm.h (ns_run_ascript): Declare.
990 (NSAPP_DATA2_RUNASSCRIPT): Define.
991
992 * nsfns.m (as_script, as_result, as_status): New static variables.
993 (ns_run_ascript): New function.
994 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
995 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
996 the event loop. Get status from as_status (Bug#7276).
997
998 * nsterm.m (sendEvent): If event is NSApplicationDefined and
999 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1000 the event loop (Bug#7276).
1001
1002 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1003
1004 * gnutls.c (QCgnutls_bootprop_priority)
1005 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1006 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1007 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1008 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1009 (QCgnutls_bootprop_verify_hostname_error)
1010 (QCgnutls_bootprop_callbacks_verify): Rename from
1011 Qgnutls_bootprop_..., all uses changed.
1012
1013 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1014 uses changed.
1015
1016 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1017
1018 * xfaces.c (Qframe_set_background_mode): Now static.
1019 * dispextern.h (Qframe_set_background_mode): Remove decl.
1020
1021 * process.c (Fnetwork_interface_info): Declare local only if needed.
1022
1023 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1024
1025 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1026 (Fnetwork_interface_list): Allocate in increments of bytes instead
1027 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1028 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1029 sockaddr.
1030 (struct ifflag_def): notrailers is smart on OSX.
1031 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1032 Get hardware address with getifaddrs if available.
1033
1034 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1035
1036 * xdisp.c (iterate_out_of_display_property): xassert that
1037 IT->position is set to within IT->object's boundaries. Break from
1038 the loop as soon as EOB is reached; avoids infloops in redisplay
1039 when IT->position is set up wrongly due to some bug.
1040 Set IT->current to match the bidi iterator unconditionally.
1041 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1042 entry. Force push_it to save on the stack the current
1043 buffer/string position, to be restored by pop_it. Fix flags in
1044 the iterator structure wrt the object coming from a display
1045 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1046 properties. (Bug#9284)
1047
1048 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1049
1050 * fontset.c (fontset_get_font_group): Add proper type checks.
1051 (Bug#9172)
1052
1053 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1054
1055 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1056 and LC_VERSION_MIN_MACOSX.
1057 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1058 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1059
1060 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1061
1062 * xdisp.c (forward_to_next_line_start): Allow to use the
1063 no-display-properties-and-no-overlays under bidi display.
1064 Set disp_pos in the bidi iterator to avoid searches for display
1065 properties and overlays.
1066
1067 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1068
1069 * editfns.c (Fset_time_zone_rule): Document relationship with the
1070 setenv function.
1071
1072 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1073 the font entity extracted from the cache (Bug#8109).
1074
1075 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1076
1077 * composite.c (autocmp_chars): Don't reset point. That is done by
1078 restore_point_unwind (Bug#5984).
1079
1080 2011-08-07 Juri Linkov <juri@jurta.org>
1081
1082 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1083 to show the arg `TIME' instead of `TIMEVAL'.
1084
1085 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1086
1087 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1088 display property strides EOL and includes a newline, as in
1089 longlines-mode. (Bug#9254)
1090 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1091 word-wrap under bidirectional display. (Bug#9224)
1092
1093 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1094 is non-zero, even if the data buffer is NULL. Fixes a crash in
1095 vertical-motion with longlines-mode. (Bug#9254)
1096
1097 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1098
1099 * bidi.c <bidi_cache_total_alloc>: Now static.
1100 (bidi_initialize): Initialize bidi_cache_total_alloc.
1101
1102 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1103 cache. (Bug#9221)
1104
1105 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1106 amount allocated this far in `bidi_cache_total_alloc'.
1107 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1108 non-zero, only free the data buffer without restoring the cache
1109 contents. All callers changed.
1110
1111 * dispextern.h (bidi_unshelve_cache): Update prototype.
1112
1113 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1114 (move_it_in_display_line, move_it_to)
1115 (move_it_vertically_backward, move_it_by_lines): Replace the call
1116 to xfree to an equivalent call to bidi_unshelve_cache.
1117 (move_it_in_display_line_to): Fix logic of returning
1118 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1119
1120 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1121
1122 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1123 came from a string character with a `cursor' property. (Bug#9229)
1124
1125 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1126
1127 * Makefile.in (LIB_PTHREAD): New variable.
1128 (LIBES): Add LIB_PTHREAD (Bug#9216).
1129
1130 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1131 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1132
1133 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1134
1135 * regex.c (re_iswctype): Remove some redundant boolean
1136 conversions.
1137
1138 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1139
1140 * xterm.c (x_find_topmost_parent): New function.
1141 (x_set_frame_alpha): Find topmost parent window with
1142 x_find_topmost_parent and set the property there also (bug#9181).
1143 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1144
1145 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1146
1147 * callproc.c (Fcall_process): Avoid vfork clobbering
1148 the local vars buffer, coding_systems, current_dir.
1149
1150 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1151
1152 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1153
1154 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1155
1156 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1157 so that it is not optimized away.
1158
1159 * xdisp.c (compute_display_string_pos): Remove unused local.
1160
1161 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1162
1163 Fix slow cursor motion and scrolling in large buffers with
1164 selective display, like Org Mode buffers. (Bug#9218)
1165
1166 * dispextern.h (struct bidi_it): New member disp_prop_p.
1167
1168 * xdisp.c: Remove one-slot cache of display string positions.
1169 (compute_display_string_pos): Accept an additional argument
1170 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1171 for a display string or property. If found, set DISP_PROP_P
1172 non-zero.
1173
1174 * bidi.c (bidi_fetch_char): Accept an additional argument
1175 DISP_PROP_P, and pass it to compute_display_string_pos.
1176 Only handle text covered by a display string if DISP_PROP_P is returned
1177 non-zero. All callers of bidi_fetch_char changed.
1178
1179 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1180
1181 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1182
1183 2010-12-03 Don March <don@ohspite.net>
1184
1185 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1186 last character M-[char] is translated to ESC [char] (bug#7541).
1187
1188 2011-08-02 Kenichi Handa <handa@m17n.org>
1189
1190 * lisp.h (uniprop_table): Extern it.
1191
1192 * chartab.c (uniprop_table): Make it non-static.
1193
1194 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1195
1196 * xdisp.c (forward_to_next_line_start): Accept additional argument
1197 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1198 on the newline.
1199 (reseat_at_next_visible_line_start): Use the bidi iterator state
1200 returned by forward_to_next_line_start to restore the state of
1201 it->bidi_it after backing up to previous newline. (Bug#9212)
1202
1203 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1204
1205 * regex.c (re_comp): Protoize.
1206 (re_exec): Fix return type.
1207 (regexec): Fix type of `ret'. (Bug#9203)
1208
1209 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1210
1211 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1212 This is needed if max-image-size is a floating-point number.
1213
1214 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1215
1216 * print.c (print_object): Print empty symbol as ##.
1217
1218 * lread.c (read1): Read ## as empty symbol.
1219
1220 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1221
1222 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1223 setting frame foreground color (Bug#9175).
1224 (x_set_background_color): Likewise.
1225
1226 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1227 contents (Bug#9176).
1228 (EmacsTooltip -init): Remove bezels and add shadows to
1229 tooltip windows.
1230
1231 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1232 or scroll bar (Bug#8470).
1233
1234 * nsfont.m (nsfont_open): Remove assignment to voffset and
1235 unnecessary vars hshink, expand, hd, full_height, min_height.
1236 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1237
1238 * nsterm.h (nsfont_info): Remove voffset field.
1239
1240 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1241
1242 Implement strike-through and overline on NextStep (Bug#8863).
1243
1244 * nsfont.m (nsfont_open): Use underline position provided by font,
1245 instead of hard-coded value of 2.
1246 (nsfont_draw): Call ns_draw_text_decoration instead.
1247
1248 * nsterm.h: Add declaration for ns_draw_text_decoration.
1249
1250 * nsterm.m (ns_draw_text_decoration): New function for drawing
1251 underline, overline, and strike-through.
1252 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1253 ns_draw_text_decoration. Change treatment of cursor drawing to
1254 accomodate underlining, etc.
1255
1256 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1257
1258 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1259 default.
1260
1261 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1262
1263 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1264 Without this fix, if a signal arrives just after memory fills up,
1265 'malloc' might be invoked reentrantly.
1266
1267 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1268 In other words, assume that every image size is allowed, on non-X
1269 hosts. This assumption is probably wrong, but it lets Emacs compile.
1270
1271 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1272
1273 * regex.c (re_iswctype): Convert return values to boolean.
1274
1275 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1276
1277 * xdisp.c (compute_display_string_pos): Don't use cached display
1278 string position if the buffer had its restriction changed.
1279 (Bug#9184)
1280
1281 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1282
1283 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1284
1285 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1286
1287 Integer signedness and overflow and related fixes. (Bug#9079)
1288
1289 * bidi.c: Integer size and overflow fixes.
1290 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1291 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1292 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1293 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1294 (bidi_find_other_level_edge):
1295 Use ptrdiff_t instead of EMACS_INT where either will do.
1296 This works better on 32-bit hosts configured --with-wide-int.
1297 (bidi_cache_ensure_space): Check for size-calculation overflow.
1298 Use % rather than repeated addition, for better worst-case speed.
1299 Don't set bidi_cache_size until after xrealloc returns, because it
1300 might not return.
1301 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1302 (bidi_cache_ensure_space): Also check that the bidi cache size
1303 does not exceed that of the largest Lisp string or buffer. See Eli
1304 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1305
1306 * alloc.c (__malloc_size_t): Remove.
1307 All uses replaced by size_t. See Andreas Schwab's note
1308 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1309
1310 * image.c: Improve checking for integer overflow.
1311 (check_image_size): Assume that f is nonnull, since
1312 it is always nonnull in practice. This is one less thing to
1313 worry about when checking for integer overflow later.
1314 (x_check_image_size): New function, which checks for integer
1315 overflow issues inside X.
1316 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1317 This removes the need for a memory_full check.
1318 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1319 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1320 (xbm_read_bitmap_data): Change locals back to 'int', since
1321 their values must fit in 'int'.
1322 (xpm_load_image, png_load, tiff_load):
1323 Invoke x_create_x_image_and_pixmap earlier,
1324 to avoid much needless work if the image is too large.
1325 (tiff_load): Treat overly large images as if
1326 x_create_x_image_and_pixmap failed, not as malloc failures.
1327 (gs_load): Use x_check_image_size.
1328
1329 * gtkutil.c: Omit integer casts.
1330 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1331 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1332
1333 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1334
1335 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1336 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1337 would wrongly return t on a 64-bit host.
1338
1339 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1340 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1341 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1342 and therefore cause GCC to emit a bogus diagnostic in some cases.
1343
1344 * image.c: Integer signedness and overflow and related fixes.
1345 This is not an exhaustive set of fixes, but it's time to
1346 record what I've got.
1347 (lookup_pixel_color, check_image_size): Remove redundant decls.
1348 (check_image_size): Don't assume that arbitrary EMACS_INT values
1349 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1350 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1351 (tiff_load, imagemagick_load_image):
1352 Check for overflow in size calculations.
1353 (x_create_x_image_and_pixmap): Remove unnecessary test for
1354 xmalloc returning NULL; that can't happen.
1355 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1356 (xpm_color_bucket): Use better integer hashing function.
1357 (xpm_cache_color): Don't possibly over-allocate memory.
1358 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1359 (gif_memory_source):
1360 Use ptrdiff_t, not int or size_t, to record sizes.
1361 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1362 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1363 either works, as we prefer signed integers.
1364 (tiff_read_from_memory, tiff_write_from_memory):
1365 Return tsize_t, not size_t, since that's what the TIFF API wants.
1366 (tiff_read_from_memory): Don't fail simply because the read would
1367 go past EOF; instead, return a short read.
1368 (tiff_load): Omit no-longer-needed casts.
1369 (Fimagemagick_types): Don't assume size fits into 'int'.
1370
1371 Improve hashing quality when configured --with-wide-int.
1372 * fns.c (hash_string): New function, taken from sxhash_string.
1373 Do not discard information about ASCII character case; this
1374 discarding is no longer needed.
1375 (sxhash-string): Use it. Change sig to match it. Caller changed.
1376 * lisp.h: Declare it.
1377 * lread.c (hash_string): Remove, since we now use fns.c's version.
1378 The fns.c version returns a wider integer if --with-wide-int is
1379 specified, so this should help the quality of the hashing a bit.
1380
1381 * emacs.c: Integer overflow minor fix.
1382 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1383 Define only if GNU_LINUX.
1384 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1385
1386 * dispnew.c: Integer signedness and overflow fixes.
1387 Remove unnecessary forward decls, that were a maintenance hassle.
1388 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1389 All uses changed.
1390 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1391 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1392 (prepare_desired_row, line_draw_cost):
1393 Use int, not unsigned, where either works.
1394 (save_current_matrix, restore_current_matrix):
1395 Use ptrdiff_t, not size_t, where either works.
1396 (init_display): Check for overflow more accurately, and without
1397 relying on undefined behavior.
1398
1399 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1400 Remove, replacing with the new symbols in lisp.h. All uses changed.
1401 * fileio.c (make_temp_name):
1402 * filelock.c (lock_file_1, lock_file):
1403 * xdisp.c (message_dolog):
1404 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1405 Use pMd etc. instead.
1406 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1407 replacing the pWIDE etc. symbols removed from editfns.c.
1408
1409 * keyboard.h (num_input_events): Now uintmax_t.
1410 This is (very slightly) less likely to mess up due to wraparound.
1411 All uses changed.
1412
1413 * buffer.c: Integer signedness fixes.
1414 (alloc_buffer_text, enlarge_buffer_text):
1415 Use ptrdiff_t rather than size_t when either will do, as we prefer
1416 signed integers.
1417
1418 * alloc.c: Integer signedness and overflow fixes.
1419 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1420 (__malloc_size_t): Default to size_t, not to int.
1421 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1422 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1423 Prefer ptrdiff_t to size_t when either would do, as we prefer
1424 signed integers.
1425 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1426 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1427 Now const. Initialize with values that are in range even if char
1428 is signed.
1429 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1430 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1431 These functions do the right thing with sizes > 2**32.
1432 (check_depth): Now ptrdiff_t, not int.
1433 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1434 Adjust to new way of storing sizes. Check for size overflow bugs
1435 in rest of code.
1436 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1437 slightly wrong anyway, as it missed one instance of
1438 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1439 (refill_memory_reserve): Omit needless cast to size_t.
1440 (mark_object_loop_halt): Mark as externally visible.
1441
1442 * xselect.c: Integer signedness and overflow fixes.
1443 (Fx_register_dnd_atom, x_handle_dnd_message):
1444 Use ptrdiff_t, not size_t, since we prefer signed.
1445 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1446 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1447 x_dnd_atoms_size and x_dnd_atoms_length.
1448
1449 * doprnt.c: Prefer signed to unsigned when either works.
1450 * eval.c (verror):
1451 * doprnt.c (doprnt):
1452 * lisp.h (doprnt):
1453 * xdisp.c (vmessage):
1454 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1455 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1456 prefer signed arithmetic to avoid comparison confusion.
1457 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1458 but is a bit tricky.
1459
1460 Assume freestanding C89 headers, string.h, stdlib.h.
1461 * data.c, doprnt.c, floatfns.c, print.c:
1462 Include float.h unconditionally.
1463 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1464 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1465 * regex.c: Likewise for stddef.h, string.h.
1466 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1467 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1468 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1469 (STDC_HEADERS): Remove obsolete defines.
1470 * sysdep.c: Include limits.h unconditionally.
1471
1472 Assume support for memcmp, memcpy, memmove, memset.
1473 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1474 * regex.c (memcmp, memcpy):
1475 Remove; we assume C89 now.
1476
1477 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1478 (__malloc_safe_bcopy): Remove; no longer needed.
1479
1480 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1481 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1482 well either way, and we prefer signed to unsigned.
1483
1484 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1485
1486 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1487 closes the connection while we're reading (bug#9182).
1488
1489 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1490
1491 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1492 are specified (Bug#9168).
1493
1494 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1495
1496 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1497 Found by GCC static checking and --with-wide-int on a 32-bit host.
1498
1499 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1500
1501 * xdisp.c (compute_display_string_pos): Fix logic of caching
1502 previous display string position. Initialize cached_prev_pos to
1503 -1. Fixes slow-down at the beginning of a buffer.
1504
1505 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1506
1507 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1508 for attrs[LFACE_FONTSET_INDEX].
1509
1510 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 * xml.c (parse_region): Remove unused local
1513 that was recently introduced.
1514
1515 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1516
1517 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1518 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1519
1520 * xdisp.c (move_it_in_display_line_to): Record the best matching
1521 position for TO_CHARPOS while scanning the line, and restore it on
1522 exit if none of the characters scanned was an exact match.
1523 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1524 when exact match is impossible due to invisible text, and the
1525 lines are truncated.
1526
1527 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1528
1529 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1530 for OSX >= 10.7.
1531
1532 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1533
1534 Fix a significant slow-down of cursor motion with C-n, C-p,
1535 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1536 auto-repeat under bidi redisplay in fontified buffers.
1537 * xdisp.c (compute_stop_pos_backwards): New function.
1538 (next_element_from_buffer): Call compute_stop_pos_backwards to
1539 find a suitable prev_stop when we find ourselves before
1540 base_level_stop.
1541 (reseat): Don't look for prev_stop, as that could mean a very long
1542 run.
1543 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1544 <cached_disp_overlay_modiff>: Cache for last found display string
1545 position.
1546 (compute_display_string_pos): Return the cached position if asked
1547 about the same buffer in the same area of character positions, and
1548 the buffer wasn't changed since the time the display string
1549 position was cached.
1550
1551 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1552
1553 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1554 is an integer, which is important for empty lines. (Bug#9149)
1555
1556 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1557
1558 * frame.c (Fmodify_frame_parameters): In tty case, update the
1559 default face if necessary (Bug#4238).
1560
1561 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1562
1563 * editfns.c (Fstring_to_char): No need to explain what a character
1564 is in the docstring (Bug#6576).
1565
1566 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1567
1568 * xml.c (parse_region): Make sure we always return a tree.
1569
1570 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1571
1572 * xml.c (parse_region): If a document contains only comments,
1573 return that, too.
1574
1575 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1576
1577 * xml.c (make_dom): Return comments, too.
1578
1579 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 Port to OpenBSD.
1582 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1583 and the surrounding thread.
1584 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1585 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1586 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1587 timer goes off.
1588 * s/openbsd.h (BROKEN_SIGIO): Define.
1589 * unexelf.c (unexec) [__OpenBSD__]:
1590 Don't update the .mdebug section of the Alpha COFF symbol table.
1591
1592 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1593
1594 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1595 (bug#8460).
1596
1597 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1598
1599 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1600 This fixes some race conditions on the permissions of any newly
1601 created file.
1602
1603 * alloc.c (valid_pointer_p): Use pipe, not open.
1604 This fixes some permissions issues when debugging.
1605
1606 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1607 If fchown fails to set both uid and gid, try to set just gid,
1608 as that is sometimes allowed. Adjust the file's mode to eliminate
1609 setuid or setgid bits that are inappropriate if fchown fails.
1610
1611 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1612
1613 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1614 to compare Lisp_Objects.
1615 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1616 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1617 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1618
1619 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1620
1621 * lread.c (read_integer): Unread even EOF character.
1622 (read1): Likewise. Properly record start position of symbol.
1623
1624 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1625 symbol character follows.
1626
1627 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1628
1629 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1630 This works around a problem with the previous change to Fcopy_file.
1631 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1632 and without this change, GCC might complain about discarding
1633 fchown's return value.
1634
1635 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1636
1637 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1638
1639 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1640
1641 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1642
1643 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1644
1645 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1646 it's used from the C level.
1647
1648 * process.c: Use the same condition for POLL_FOR_INPUT in both
1649 keyboard.c and process.c (bug#1858).
1650
1651 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1652
1653 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1654 (Fgnutls_boot): Use it.
1655
1656 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1657
1658 * doc.c (Fsubstitute_command_keys): Revert last change.
1659
1660 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1661
1662 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1663 quotes the next character, and doesn't affect other longer
1664 sequences (bug#8935).
1665
1666 * lread.c (syms_of_lread): Clarify that is isn't only
1667 `eval-buffer' and `eval-defun' that's affected by
1668 `lexical-binding' (bug#8460).
1669
1670 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1671
1672 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1673 bidi redisplay when a line includes both an image and is
1674 truncated.
1675
1676 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 Fix minor problems found by static checking.
1679 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1680 (elsz): Now a signed constant, not a size_t var. We prefer signed
1681 types to unsigned, to avoid integer comparison confusion. Without
1682 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1683 "cannot optimize loop, the loop counter may overflow", a symptom
1684 of the confusion.
1685 * indent.c (Fvertical_motion): Mark locals as initialized.
1686 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1687
1688 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1689
1690 * search.c (Fre_search_backward): Mention `case-fold-search' in
1691 all the re_search_* functions (bug#8138).
1692
1693 * keyboard.c (Fopen_dribble_file): Document when the file is
1694 closed (bug#8056).
1695
1696 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1697
1698 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1699 bidi_cache_idx.
1700
1701 Support bidi reordering of display and overlay strings.
1702 * xdisp.c (compute_display_string_pos)
1703 (compute_display_string_end): Accept additional argument STRING.
1704 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1705 (reseat_to_string): Initialize bidi_it->string.s and
1706 bidi_it->string.schars.
1707 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1708 NULL (avoids a crash in bidi_paragraph_init).
1709 Initialize itb.string.lstring.
1710 (init_iterator): Call bidi_init_it only of a valid
1711 buffer position was specified. Initialize paragraph_embedding to
1712 L2R.
1713 (reseat_to_string): Initialize the bidi iterator.
1714 (display_string): If we need to ignore text properties of
1715 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1716 original value of -1 will not work with bidi.)
1717 (compute_display_string_pos): First arg is now struct
1718 `text_pos *'; all callers changed. Support display properties on
1719 Lisp strings.
1720 (compute_display_string_end): Support display properties on Lisp
1721 strings.
1722 (init_iterator, reseat_1, reseat_to_string): Initialize the
1723 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1724 when iterating on a string not from display properties).
1725 (compute_display_string_pos, compute_display_string_end):
1726 Fix calculation of the object to scan. Fixes an error when using
1727 arrow keys.
1728 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1729 base_level_stop; instead, set base_level_stop to BEGV.
1730 Fixes crashes in vertical-motion.
1731 (next_element_from_buffer): Improve commentary for when
1732 the iterator is before prev_stop.
1733 (init_iterator): Initialize bidi_p from the default value of
1734 bidi-display-reordering, not from buffer-local value. Use the
1735 buffer-local value only if initializing for buffer iteration.
1736 (handle_invisible_prop): Support invisible properties on strings
1737 that are being bidi-reordered.
1738 (set_iterator_to_next): Support bidi reordering of C strings and
1739 Lisp strings.
1740 (next_element_from_string): Support bidi reordering of Lisp
1741 strings.
1742 (handle_stop_backwards): Support Lisp strings as well.
1743 (display_string): Support display of R2L glyph rows.
1744 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1745 (init_iterator): Don't initialize it->bidi_p for strings
1746 here.
1747 (reseat_to_string): Initialize it->bidi_p for strings here.
1748 (next_element_from_string, next_element_from_c_string)
1749 (next_element_from_buffer): Add xassert's for correspondence
1750 between IT's object being iterated and it->bidi_it.string
1751 structure.
1752 (face_before_or_after_it_pos): Support bidi iteration.
1753 (next_element_from_c_string): Handle the case of the first string
1754 character that is not the first one in the visual order.
1755 (get_visually_first_element): New function, refactored from common
1756 parts of next_element_from_buffer, next_element_from_string, and
1757 next_element_from_c_string.
1758 (tool_bar_lines_needed, redisplay_tool_bar)
1759 (display_menu_bar): Force left-to-right direction. Add a FIXME
1760 comment for making that be controlled by a user option.
1761 (push_it, pop_it): Save and restore the state of the
1762 bidi iterator. Save and restore the bidi_p flag.
1763 (pop_it): Iterate out of display property for string iteration as
1764 well.
1765 (iterate_out_of_display_property): Support iteration over strings.
1766 (handle_single_display_spec): Set up it->bidi_it for iteration
1767 over a display string, and call bidi_init_it.
1768 (handle_single_display_spec, next_overlay_string)
1769 (get_overlay_strings_1, push_display_prop): Set up the bidi
1770 iterator for displaying display or overlay strings.
1771 (forward_to_next_line_start): Don't use the shortcut if
1772 bidi-iterating.
1773 (back_to_previous_visible_line_start): If handle_display_prop
1774 pushed the iterator stack, restore the internal state of the bidi
1775 iterator by calling bidi_pop_it same number of times.
1776 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1777 and we are bidi-iterating, don't decrement the iterator position;
1778 instead, set the first_elt flag in the bidi iterator, to produce
1779 the same effect.
1780 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1781 (push_display_prop): xassert that we are iterating a buffer.
1782 (push_it, pop_it): Save and restore paragraph_embedding member.
1783 (handle_single_display_spec, next_overlay_string)
1784 (get_overlay_strings_1, reseat_1, reseat_to_string)
1785 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1786 correctly. Don't assume unibyte strings are not bidi-reordered.
1787 (compute_display_string_pos)
1788 (compute_display_string_end): Fix handling the case of C string.
1789 (push_it, pop_it): Save and restore from_disp_prop_p.
1790 (handle_single_display_spec, push_display_prop): Set the
1791 from_disp_prop_p flag.
1792 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1793 (pop_it): Call iterate_out_of_display_property only if we are
1794 popping after iteration over a string that came from a display
1795 property. Fix a typo in popping stretch info. Add an assertion
1796 for verifying that the iterator position is in sync with the bidi
1797 iterator.
1798 (handle_single_display_spec, get_overlay_strings_1)
1799 (push_display_prop): Fix initialization of paragraph direction for
1800 string when that of the parent object is not yet determined.
1801 (reseat_1): Call bidi_init_it to resync the bidi
1802 iterator with IT's position. (Bug#7616)
1803 (find_row_edges): If ROW->start.pos gives position
1804 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1805 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1806 Reset the from_disp_prop_p flag.
1807 (SAVE_IT, RESTORE_IT): New macros.
1808 (pos_visible_p, face_before_or_after_it_pos)
1809 (back_to_previous_visible_line_start)
1810 (move_it_in_display_line_to, move_it_in_display_line)
1811 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1812 (try_scrolling, redisplay_window, display_line): Use them when
1813 saving a temporary copy of the iterator and restoring it back.
1814 (back_to_previous_visible_line_start, reseat_1)
1815 (init_iterator): Empty the bidi cache "stack".
1816 (move_it_in_display_line_to): If iterator ended up at
1817 EOL, but we never saw any buffer positions smaller than
1818 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1819 motion in bidi-reordered lines.
1820 (move_it_in_display_line_to): Record prev_method and prev_pos
1821 immediately before the call to set_iterator_to_next. Fixes cursor
1822 motion in bidi-reordered lines with stretch glyphs and strings
1823 displayed in margins. (Bug#8133) (Bug#8867)
1824 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1825 TO_CHARPOS.
1826 (pos_visible_p): Support positions in bidi-reordered lines.
1827 Save and restore bidi cache.
1828
1829 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1830 (bidi_paragraph_info): Delete unused struct.
1831 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1832 (bidi_cache_start): New variable.
1833 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1834 to zero.
1835 (bidi_cache_fetch_state, bidi_cache_search)
1836 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1837 (bidi_cache_find, bidi_peek_at_next_level)
1838 (bidi_level_of_next_char, bidi_find_other_level_edge)
1839 (bidi_move_to_visually_next): Compare cache index with
1840 bidi_cache_start rather than with zero.
1841 (bidi_fetch_char): Accept new argument STRING; all callers
1842 changed. Support iteration over a string. Support strings with
1843 display properties. Support unibyte strings. Fix the type of
1844 `len' according to what STRING_CHAR_AND_LENGTH expects.
1845 (bidi_paragraph_init, bidi_resolve_explicit_1)
1846 (bidi_resolve_explicit, bidi_resolve_weak)
1847 (bidi_level_of_next_char, bidi_move_to_visually_next):
1848 Support iteration over a string.
1849 (bidi_set_sor_type, bidi_resolve_explicit_1)
1850 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1851 can now be zero (for strings); special values 0 and -1 were
1852 changed to -1 and -2, respectively.
1853 (bidi_char_at_pos): New function.
1854 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1855 Call it instead of FETCH_MULTIBYTE_CHAR.
1856 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1857 initialized to valid values.
1858 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1859 values.
1860 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1861 the test for valid cached positions. Fix the logic for looking up
1862 the sentinel state in the cache. GCPRO the Lisp string we are
1863 iterating.
1864 (bidi_push_it, bidi_pop_it): New functions.
1865 (bidi_initialize): Initialize the bidi cache start stack pointer.
1866 (bidi_cache_ensure_space): New function, refactored from part of
1867 bidi_cache_iterator_state. Don't assume the required size is just
1868 one BIDI_CACHE_CHUNK away.
1869 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1870 (bidi_count_bytes, bidi_char_at_pos): New functions.
1871 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1872 always valid if bidi_cache_idx is valid.
1873 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1874 is valid if it's going to be used.
1875 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1876 (bidi_cache_fetch_state, bidi_cache_search)
1877 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1878 (bidi_cache_iterator_state, bidi_cache_find)
1879 (bidi_find_other_level_edge, bidi_cache_start_stack):
1880 All variables related to cache indices are now EMACS_INT.
1881
1882 * dispextern.h (struct bidi_string_data): New structure.
1883 (struct bidi_it): New member `string'. Make flag members be 1-bit
1884 fields, and put them last in the struct.
1885 (compute_display_string_pos, compute_display_string_end):
1886 Update prototypes.
1887 (bidi_push_it, bidi_pop_it): Add prototypes.
1888 (struct iterator_stack_entry): New members bidi_p,
1889 paragraph_embedding, and from_disp_prop_p.
1890 (struct it): Member bidi_p is now a bit field 1 bit wide.
1891 (bidi_shelve_cache, bidi_unshelve_cache):
1892 Declare prototypes.
1893
1894 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1895 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1896 and vector-like objects.
1897
1898 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1899 cache around display iteration.
1900
1901 * window.c (Fwindow_end, window_scroll_pixel_based)
1902 (displayed_window_lines, Frecenter): Save and restore the bidi
1903 cache around display iteration.
1904
1905 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1906
1907 * editfns.c (Fdelete_region): Clarify the use of the named
1908 parameters (bug#6788).
1909
1910 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1911
1912 * indent.c (Fvertical_motion): Set and restore w->pointm when
1913 saving and restoring the window's buffer (Bug#9006).
1914
1915 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1916
1917 * editfns.c (Fstring_to_char): Clarify just what is returned
1918 (bug#6576). Text by Eli Zaretskii.
1919
1920 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1921
1922 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1923
1924 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1925
1926 * buffer.c (mmap_find): Fix a typo.
1927
1928 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1929
1930 Fix execution of x selection hooks.
1931 * xselect.c (Qx_lost_selection_functions)
1932 (Qx_sent_selection_functions): New vars.
1933 (syms_of_xselect): DEFSYM them.
1934 (x_handle_selection_request): Pass Qx_sent_selection_functions
1935 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1936 (x_handle_selection_clear,x_clear_frame_selections):
1937 Pass Qx_lost_selection_functions rather than
1938 Vx_lost_selection_functions to Frun_hook_with_args.
1939
1940 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1941
1942 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1943 The old code sometimes used this field without initializing it.
1944
1945 * alloc.c (gc_sweep): Don't read past end of array.
1946 In theory, the old code could also have corrupted Emacs internals,
1947 though it'd be very unlikely.
1948
1949 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1950
1951 * character.c (Fcharacterp): Don't advertise optional ignored
1952 argument. (Bug#4026)
1953
1954 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1955
1956 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1957 key" (bug#4257).
1958
1959 * window.c (Fset_window_start): Doc fix (bug#4199).
1960 (Fset_window_hscroll): Ditto.
1961
1962 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1963
1964 Fix minor new problems caught by GCC 4.6.1.
1965 * term.c (init_tty): Remove unused local.
1966 * xsettings.c (store_monospaced_changed): Define this function only
1967 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1968 not used otherwise.
1969
1970 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1971
1972 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1973
1974 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1975
1976 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1977 are the mini-buffer and the echo area (bug#3320).
1978
1979 * term.c (init_tty): Remove support for supdup, c10 and perq
1980 terminals, which are no longer supported (bug#1482).
1981
1982 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1983
1984 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1985
1986 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1987
1988 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1989 for non-popups (Bug#3642).
1990
1991 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1992
1993 * alloc.c (reset_malloc_hooks): Protoize.
1994 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1995 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1996 * cm.c (losecursor): Likewise.
1997 * data.c (fmod): Likewise.
1998 * dispnew.c (swap_glyphs_in_rows): Likewise.
1999 * emacs.c (memory_warning_signal): Likewise.
2000 * floatfns.c (float_error): Likewise.
2001 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2002 (otf_open, font_otf_capability, generate_otf_features)
2003 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2004 Likewise.
2005 * image.c (pbm_read_file): Likewise.
2006 * indent.c (string_display_width): Likewise.
2007 * intervals.c (check_for_interval, search_for_interval)
2008 (inc_interval_count, count_intervals, root_interval)
2009 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2010 * lread.c (defalias): Likewise.
2011 * ralloc.c (r_alloc_check): Likewise.
2012 * regex.c (set_image_of_range_1, set_image_of_range)
2013 (regex_grow_registers): Likewise.
2014 * sysdep.c (strerror): Likewise.
2015 * termcap.c (valid_filename_p, tprint, main): Likewise.
2016 * tparam.c (main): Likewise.
2017 * unexhp9k800.c (run_time_remap, save_data_space)
2018 (update_file_ptrs, read_header, write_header, calculate_checksum)
2019 (copy_file, copy_rest, display_header): Likewise.
2020 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2021 Likewise.
2022 * xdisp.c (check_it): Likewise.
2023 * xfaces.c (register_color, unregister_color, unregister_colors):
2024 Likewise.
2025 * xfns.c (print_fontset_result): Likewise.
2026 * xrdb.c (member, fatal, main): Likewise.
2027
2028 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2029
2030 Fix minor problems found by static checking (Bug#9031).
2031 * chartab.c (char_table_set_range, map_sub_char_table):
2032 Remove unused locals.
2033 (uniprop_table): Now static.
2034 * composite.c (_work_char): Remove unused static var.
2035
2036 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2039
2040 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2041
2042 * gtkutil.c (qttip_cb): Remove code without function.
2043
2044 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2045
2046 * w32.c (pthread_sigmask): New stub.
2047
2048 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 Use pthread_sigmask, not sigprocmask (Bug#9010).
2051 sigprocmask is portable only for single-threaded applications, and
2052 Emacs can be multi-threaded when it uses GTK.
2053 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2054 (LIBES): Use it.
2055 * callproc.c (Fcall_process):
2056 * process.c (create_process):
2057 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2058 Use pthread_sigmask, not sigprocmask.
2059
2060 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2061
2062 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2063 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2064 wrong (Bug#8591).
2065
2066 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2067
2068 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2069 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2070 (xg_hide_tooltip): Fix comment.
2071
2072 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2073 in registerServicesMenuSendTypes.
2074 (validRequestorForSendType): Don't check ns_return_types.
2075
2076 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2077 ns_return_type.
2078
2079 2011-07-08 Jason Rumney <jasonr@gnu.org>
2080
2081 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2082 frame struct members of non-existent frames (Bug#6284).
2083
2084 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2085
2086 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2087 variable firstTime not needed on OSX >= 10.6.
2088 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2089 >= 10.5. Use setKnobProportion, setDoubleValue.
2090
2091 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2092 (MAC_OS_X_VERSION_10_5): Define if not defined.
2093 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2094 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2095 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2096
2097 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2098 cString and lossyCString on OSX >= 10.4
2099
2100 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2101 sizeToFit on OSX >= 10.2.
2102
2103 * nsimage.m (allocInitFromFile): Don't use deprecated method
2104 bestRepresentationForDevice on OSX >= 10.6.
2105
2106 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2107 to avoid warning.
2108
2109 * emacs.c: Declare unexec_init_emacs_zone.
2110
2111 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2112
2113 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2114
2115 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2116 on svcsMenu (Bug#8842).
2117
2118 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2119 ns_return_types.
2120 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2121
2122 * nsterm.m (QUTF8_STRING): Declare.
2123 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2124 (validRequestorForSendType): Return type is (id).
2125 Change indexOfObjectIdenticalTo to indexOfObject.
2126 Check if we have local selection before returning self (Bug#8842).
2127 (writeSelectionToPasteboard): Put local selection into paste board
2128 if we have a local selection (Bug#8842).
2129 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2130
2131 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2132 (ns_get_local_selection): Declare.
2133
2134 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2135
2136 * keymap.c (describe_map_tree): Don't insert a double newline at
2137 the end of the buffer (bug#1169) and return whether we inserted
2138 something.
2139
2140 * callint.c (Fcall_interactively): Change "reading args" to
2141 "providing args" to try to clarify what it does (bug#1010).
2142
2143 2011-07-07 Kenichi Handa <handa@m17n.org>
2144
2145 * composite.c (composition_compute_stop_pos): Ignore a static
2146 composition starting before CHARPOS (Bug#8915).
2147
2148 * xdisp.c (handle_composition_prop): Likewise.
2149
2150 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2151
2152 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2153 (Bug#9015)
2154
2155 2011-07-07 Kenichi Handa <handa@m17n.org>
2156
2157 * character.h (unicode_category_t): New enum type.
2158
2159 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2160 (Qchar_code_property_table): New variable.
2161 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2162 (UNIPROP_COMPRESSED_FORM_P): New macros.
2163 (char_table_ascii): Uncompress the compressed values.
2164 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2165 Uncompress the compressed values.
2166 (sub_char_table_ref_and_range): Likewise.
2167 (char_table_ref_and_range): Uncompress the compressed values.
2168 (sub_char_table_set): New arg is_uniprop. Callers changed.
2169 Uncompress the compressed values.
2170 (sub_char_table_set_range): Args changed. Callers changed.
2171 (char_table_set_range): Adjuted for the above change.
2172 (map_sub_char_table): Delete args default_val and parent. Add arg
2173 top. Give decoded values to a Lisp function.
2174 (map_char_table): Adjust for the above change. Give decoded
2175 values to a Lisp function. Gcpro more variables.
2176 (uniprop_table_uncompress)
2177 (uniprop_decode_value_run_length): New functions.
2178 (uniprop_decoder, uniprop_decoder_count): New variables.
2179 (uniprop_get_decoder, uniprop_encode_value_character)
2180 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2181 New functions.
2182 (uniprop_encoder, uniprop_encoder_count): New variables.
2183 (uniprop_get_encoder, uniprop_table)
2184 (Funicode_property_table_internal, Fget_unicode_property_internal)
2185 (Fput_unicode_property_internal): New functions.
2186 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2187 Sunicode_property_table_internal, Sget_unicode_property_internal,
2188 and Sput_unicode_property_internal. Defvar_lisp
2189 char-code-property-alist.
2190
2191 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2192 Vunicode_category_table.
2193
2194 * font.c (font_range): Adjust for the change of
2195 Vunicode_category_table.
2196
2197 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2198
2199 * m/iris4d.h: Remove file, move contents ...
2200 * s/irix6-5.h: ... here.
2201
2202 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 Remove unportable assumption about struct layout (Bug#8884).
2205 * alloc.c (mark_buffer):
2206 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2207 (clone_per_buffer_values): Don't assume that
2208 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2209 This isn't true in general, and it's particularly not true
2210 if Emacs is configured with --with-wide-int.
2211 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2212 New macros, used in the buffer.c change.
2213
2214 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2215
2216 * xsettings.c: Use both GConf and GSettings if both are available.
2217 (store_config_changed_event): Add comment.
2218 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2219 (store_tool_bar_style_changed): New functions.
2220 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2221 (struct xsettings): Move font inside HAVE_XFT.
2222 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2223 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2224 Move inside HAVE_XFT.
2225 (something_changed_gsettingsCB): Rename from something_changedCB.
2226 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2227 also.
2228 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2229 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2230 (something_changed_gconfCB): Rename from something_changedCB.
2231 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2232 (parse_settings): Move check for font inside HAVE_XFT.
2233 (read_settings, apply_xft_settings): Add comment.
2234 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2235 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2236 call store_font_name_changed.
2237 (xft_settings_event): Add comment.
2238 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2239 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2240 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2241 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2242 (xsettings_initialize): Call init_gsettings last.
2243 (xsettings_get_system_font, xsettings_get_system_normal_font):
2244 Add comment.
2245
2246 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2247
2248 Random fixes. E.g., (random) never returned negative values.
2249 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2250 subseconds part to the entropy, as that's a bit more random.
2251 Prefer signed to unsigned, since the signedness doesn't matter and
2252 in general we prefer signed. When given a limit, use a
2253 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2254 latter isn't right if USE_2_TAGS_FOR_INTS.
2255 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2256 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2257
2258 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2259
2260 * textprop.c (text_property_stickiness):
2261 Obey Vtext_property_default_nonsticky.
2262 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2263 * w32fns.c (syms_of_w32fns):
2264 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2265
2266 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2267
2268 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2269 This is more efficient than Ffile_directory_p and avoids a minor race.
2270
2271 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2272
2273 * buffer.c (Foverlay_put): Say what the return value is
2274 (bug#7835).
2275
2276 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2277 is a directory before asking whether to use the file name
2278 (bug#7564).
2279 (barf_or_query_if_file_exists): Make the "File is a directory"
2280 error be more correct.
2281
2282 * fns.c (Frequire): Remove the mention of the .gz files, since
2283 that's installation-specific, but keep the mention of
2284 `get-load-suffixes'.
2285
2286 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2289 Report string overflow if the output is too long.
2290
2291 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2292
2293 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2294 (syms_of_gnutls): Remove duplicate DEFSYM for
2295 Qgnutls_bootprop_verify_hostname_error, an error for
2296 Qgnutls_bootprop_verify_error (which is no longer used).
2297
2298 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2299 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2300 Also (re)move comments that are misplaced or no longer relevant.
2301
2302 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2303
2304 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2305
2306 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2307
2308 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2309 and background color parameters if they have been changed.
2310
2311 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2312
2313 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2314
2315 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2316
2317 * xsettings.c (SYSTEM_FONT): Define only when used.
2318 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2319
2320 * keymap.c (access_keymap_1): Now static.
2321
2322 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2323
2324 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2325 leave any prefix arg for the up event (Bug#1586).
2326
2327 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2328
2329 * lread.c (syms_of_lread): Mention single symbols defined by
2330 `defvar' or `defconst' (bug#7154).
2331
2332 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2333 (Frequire): Mention get-load-suffixes.
2334
2335 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2336
2337 * window.h (window): Remove clone_number slot.
2338 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2339 Remove.
2340 (make_parent_window, make_window, saved_window)
2341 (Fset_window_configuration, save_window_save): Don't deal with
2342 clone numbers.
2343 * buffer.c (Qclone_number): Remove declaration.
2344 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2345
2346 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2347
2348 Add multiple inheritance to keymaps.
2349 * keymap.c (Fmake_composed_keymap): New function.
2350 (Fset_keymap_parent): Simplify.
2351 (fix_submap_inheritance): Remove.
2352 (access_keymap_1): New function extracted from access_keymap to handle
2353 embedded parents and handle lists of maps.
2354 (access_keymap): Use it.
2355 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2356 (Fcopy_keymap): Handle embedded parents.
2357 (Fcommand_remapping, define_as_prefix): Simplify.
2358 (Fkey_binding): Simplify.
2359 (syms_of_keymap): Move minibuffer-local-completion-map,
2360 minibuffer-local-filename-completion-map,
2361 minibuffer-local-must-match-map, and
2362 minibuffer-local-filename-must-match-map to Elisp.
2363 (syms_of_keymap): Defsubr make-composed-keymap.
2364 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2365 (parse_menu_item): Trivial simplification.
2366
2367 2011-07-01 Glenn Morris <rgm@gnu.org>
2368
2369 * Makefile.in (SETTINGS_LIBS): Fix typo.
2370
2371 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2372
2373 * coding.c (Fencode_coding_string): Record the last coding system
2374 used, as the function doc string says (bug#8738).
2375
2376 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2377
2378 * xsettings.c (store_monospaced_changed): Take new font as arg and
2379 check for change against current_mono_font.
2380 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2381 (emacs_settings_constructor, emacs_settings_get_property)
2382 (emacs_settings_set_property, emacs_settings_class_init)
2383 (emacs_settings_init, gsettings_obj): Remove.
2384 (something_changedCB): New function for HAVE_GSETTINGS.
2385 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2386 with value as argument.
2387 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2388 g_settings_new (Bug#8967). Do not create gsettings_obj.
2389 Remove calls to g_settings_bind. Connect something_changedCB to
2390 "changed".
2391
2392 * xgselect.c: Add defined (HAVE_GSETTINGS).
2393 (xgselect_initialize): Ditto.
2394
2395 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2396 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2397 xg_select.
2398
2399 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2400
2401 * eval.c (struct backtrace): Simplify and port the data structure.
2402 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2403 signed bit field, as this assumption is not portable and it makes
2404 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2405 "char debug_on_exit : 1" as this is not portable either; instead,
2406 use the portable "unsigned int debug_on_exit : 1". Remove unused
2407 member evalargs. Remove obsolete comments about cc bombing out.
2408
2409 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2410
2411 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2412 Let HAVE_GSETTINGS override HAVE_GCONF.
2413 (store_monospaced_changed): New function.
2414 (EMACS_SETTINGS): A new type derived from GObject to handle
2415 GSettings notifications.
2416 (emacs_settings_constructor, emacs_settings_get_property)
2417 (emacs_settings_set_property, emacs_settings_class_init):
2418 New functions.
2419 (gsettings_client, gsettings_obj): New variables.
2420 (GSETTINGS_SCHEMA): New define.
2421 (something_changedCB): Call store_monospaced_changed.
2422 (init_gsettings): New function.
2423 (xsettings_initialize): Call init_gsettings.
2424 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2425 to NULL.
2426
2427 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2428 GCONF_CFLAGS/LIBS.
2429
2430 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2431
2432 * window.c (resize_root_window, grow_mini_window)
2433 (shrink_mini_window): Rename Qresize_root_window to
2434 Qwindow_resize_root_window and Qresize_root_window_vertically to
2435 Qwindow_resize_root_window_vertically.
2436
2437 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2440
2441 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2442
2443 * makefile.w32-in: Redesign dependencies so they reflect more
2444 clearly which files are directly included by each source file,
2445 and not through other includes.
2446
2447 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2448
2449 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2450 (sort_overlays, overlay_strings): When an overlay's clone number
2451 matches the window's clone number process the overlay even if
2452 the overlay's window property doesn't match the current window.
2453
2454 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2455 (Fwindow_hchild): Rename to Fwindow_left_child.
2456 (Fwindow_next): Rename to Fwindow_next_sibling.
2457 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2458 (resize_window_check): Rename to window_resize_check.
2459 (resize_window_apply): Rename to window_resize_apply.
2460 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2461 (Fdelete_other_windows_internal, resize_frame_windows)
2462 (Fsplit_window_internal, Fdelete_window_internal)
2463 (grow_mini_window, shrink_mini_window)
2464 (Fresize_mini_window_internal): Fix callers accordingly.
2465
2466 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2467
2468 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2469 (emacs_fixed_set_min_size): Remove.
2470 (emacs_fixed_new): Take frame as argument.
2471
2472 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2473 (_EmacsFixedPrivate): Remove minwidth/height.
2474 Add struct frame *f.
2475 (emacs_fixed_init): Initialize priv->f.
2476 (get_parent_class, emacs_fixed_set_min_size): Remove.
2477 (emacs_fixed_new): Set priv->f to argument.
2478 (emacs_fixed_get_preferred_width)
2479 (emacs_fixed_get_preferred_height): Use min_width/height from
2480 frames size_hint to set minimum and natural (Bug#8919).
2481 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2482 and use min_width/height from frames size_hint to set
2483 min_width/height (Bug#8919).
2484
2485 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2486 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2487 Fix indentation.
2488
2489 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2490
2491 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2492 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2493 called at ZV.
2494
2495 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2496
2497 * process.c (wait_reading_process_output): Bypass select if
2498 waiting for a cell while ignoring keyboard input, and input is
2499 pending. Suggested by Jan Djärv (Bug#8869).
2500
2501 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 Use gnulib's dup2 module instead of rolling our own.
2504 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2505
2506 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2507
2508 * dispnew.c (scrolling_window): Before scrolling, turn off a
2509 mouse-highlight in the window being scrolled.
2510
2511 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2512
2513 Move DEFSYM to lisp.h and use everywhere.
2514
2515 * character.h (DEFSYM): Move declaration...
2516 * lisp.h (DEFSYM): ...here.
2517
2518 * gnutls.c:
2519 * minibuf.c:
2520 * w32menu.c:
2521 * w32proc.c:
2522 * w32select.c: Don't include character.h.
2523
2524 * alloc.c (syms_of_alloc):
2525 * buffer.c (syms_of_buffer):
2526 * bytecode.c (syms_of_bytecode):
2527 * callint.c (syms_of_callint):
2528 * casefiddle.c (syms_of_casefiddle):
2529 * casetab.c (init_casetab_once):
2530 * category.c (init_category_once, syms_of_category):
2531 * ccl.c (syms_of_ccl):
2532 * cmds.c (syms_of_cmds):
2533 * composite.c (syms_of_composite):
2534 * dbusbind.c (syms_of_dbusbind):
2535 * dired.c (syms_of_dired):
2536 * dispnew.c (syms_of_display):
2537 * doc.c (syms_of_doc):
2538 * editfns.c (syms_of_editfns):
2539 * emacs.c (syms_of_emacs):
2540 * eval.c (syms_of_eval):
2541 * fileio.c (syms_of_fileio):
2542 * fns.c (syms_of_fns):
2543 * frame.c (syms_of_frame):
2544 * fringe.c (syms_of_fringe):
2545 * insdel.c (syms_of_insdel):
2546 * keymap.c (syms_of_keymap):
2547 * lread.c (init_obarray, syms_of_lread):
2548 * macros.c (syms_of_macros):
2549 * msdos.c (syms_of_msdos):
2550 * print.c (syms_of_print):
2551 * process.c (syms_of_process):
2552 * search.c (syms_of_search):
2553 * sound.c (syms_of_sound):
2554 * syntax.c (init_syntax_once, syms_of_syntax):
2555 * terminal.c (syms_of_terminal):
2556 * textprop.c (syms_of_textprop):
2557 * undo.c (syms_of_undo):
2558 * w32.c (globals_of_w32):
2559 * window.c (syms_of_window):
2560 * xdisp.c (syms_of_xdisp):
2561 * xfaces.c (syms_of_xfaces):
2562 * xfns.c (syms_of_xfns):
2563 * xmenu.c (syms_of_xmenu):
2564 * xsettings.c (syms_of_xsettings):
2565 * xterm.c (syms_of_xterm): Use DEFSYM.
2566
2567 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2568
2569 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2570
2571 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2572
2573 Integer and buffer overflow fixes (Bug#8873).
2574
2575 * print.c (printchar, strout): Check for string overflow.
2576 (PRINTPREPARE, printchar, strout):
2577 Don't set size unless allocation succeeds.
2578
2579 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2580 for sizes. Check for string overflow more accurately.
2581 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2582
2583 * macros.c: Integer and buffer overflow fixes.
2584 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2585 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2586 Use ptrdiff_t, not int, for sizes.
2587 Don't increment bufsize until after realloc succeeds.
2588 Check for size-calculation overflow.
2589 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2590
2591 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2592
2593 * lread.c: Integer overflow fixes.
2594 (read_integer): Radix is now EMACS_INT, not int,
2595 to improve quality of diagnostics for out-of-range radices.
2596 Calculate buffer size correctly for out-of-range radices.
2597 (read1): Check for integer overflow in radices, and in
2598 read-circle numbers.
2599 (read_escape): Avoid int overflow.
2600 (Fload, openp, read_buffer_size, read1)
2601 (substitute_object_recurse, read_vector, read_list, map_obarray):
2602 Use ptrdiff_t, not int, for sizes.
2603 (read1): Use EMACS_INT, not int, for sizes.
2604 Check for size overflow.
2605
2606 * image.c (cache_image): Check for size arithmetic overflow.
2607
2608 * lread.c: Integer overflow issues.
2609 (saved_doc_string_size, saved_doc_string_length)
2610 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2611 Now ptrdiff_t, not int.
2612 (read1): Don't assume doc string length fits in int. Check for
2613 out-of-range doc string lengths.
2614 (read_list): Don't assume file position fits in int.
2615 (read_escape): Check for hex character overflow.
2616
2617 2011-06-22 Leo Liu <sdl.web@gmail.com>
2618
2619 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2620 Move to minibuffer.el.
2621
2622 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2625 The following patches are for when GLYPH_DEBUG && !XASSERT.
2626 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2627 * dispnew.c (flush_stdout):
2628 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2629 Mark as externally visible.
2630 * dispnew.c (check_window_matrix_pointers): Now static.
2631 * dispnew.c (window_to_frame_vpos):
2632 * xfns.c (unwind_create_frame):
2633 * xterm.c (x_check_font): Remove unused local.
2634 * scroll.c (CHECK_BOUNDS):
2635 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2636 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2637 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2638 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2639 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2640 Now static.
2641 (debug_method_add): Use va_list and vsprintf rather than relying
2642 on undefined behavior with wrong number of arguments.
2643 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2644 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2645 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2646 since we're not interested in debugging glyphs with old libraries.
2647 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2648 GCC 4.6.0's static checking.
2649
2650 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2651
2652 Integer overflow and signedness fixes (Bug#8873).
2653 A few related buffer overrun fixes, too.
2654
2655 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2656
2657 * dispextern.h (struct face.stipple):
2658 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2659 (x_bitmap_mask, x_allocate_bitmap_record)
2660 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2661 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2662 (x_create_bitmap_from_xpm_data):
2663 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2664 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2665 (.bitmaps_last):
2666 * xfaces.c (load_pixmap):
2667 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2668 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2669 (.bitmaps_last, struct x_output.icon_bitmap):
2670 Use ptrdiff_t, not int, for bitmap indexes.
2671 (x_allocate_bitmap_record): Check for size overflow.
2672 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2673
2674 Use ptrdiff_t, not int, for overlay counts.
2675 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2676 * editfns.c (overlays_around, get_pos_property):
2677 * textprop.c (get_char_property_and_overlay):
2678 * xdisp.c (next_overlay_change, note_mouse_highlight):
2679 * xfaces.c (face_at_buffer_position):
2680 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2681 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2682 (Fnext_overlay_change, Fprevious_overlay_change)
2683 (mouse_face_overlay_overlaps, Foverlays_in):
2684 Use ptrdiff_t, not int, for sizes.
2685 (overlays_at, overlays_in): Check for size-calculation overflow.
2686
2687 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2688
2689 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2690 (x_session_initialize): Do not assume string length fits in int.
2691
2692 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2693 This is unlikely, but can occur if DPI is outlandish.
2694
2695 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2696 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2697
2698 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2699 * xrdb.c (magic_file_p, search_magic_path):
2700 Omit last arg SUFFIX; it was always 0. All callers changed.
2701 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2702
2703 * xfont.c (xfont_match): Avoid need for strlen.
2704
2705 * xfns.c: Don't assume strlen fits in int.
2706 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2707
2708 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2709 not unsigned long, as we prefer signed integers. All callers changed.
2710 Detect integer overflow in repeat count.
2711 (message_dolog): Don't assume print length fits in 39 bytes.
2712 (display_mode_element): Don't assume strlen fits in int.
2713
2714 * termcap.c: Don't assume sizes fit in int and never overflow.
2715 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2716 (gobble_line): Check for size-calculation overflow.
2717
2718 * minibuf.c (Fread_buffer):
2719 * lread.c (intern, intern_c_string):
2720 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2721 Don't assume string length fits in int.
2722
2723 * keyboard.c (parse_tool_bar_item):
2724 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2725
2726 * font.c: Don't assume string length fits in int.
2727 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2728 Use ptrdiff_t, not int.
2729 (font_intern_prop): Don't assume string length fits in int.
2730 Don't assume integer property fits in fixnum.
2731 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2732
2733 * filelock.c: Fix some buffer overrun and integer overflow issues.
2734 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2735 Reformulate so as not to need the command string.
2736 Invoke gzip -cd rather than gunzip, as it's more portable.
2737 (lock_info_type, lock_file_1, lock_file):
2738 Don't assume pid_t and time_t fit in unsigned long.
2739 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2740 (current_lock_owner): Prefer signed type for sizes.
2741 Use memcpy, not strncpy, where memcpy is what is really wanted.
2742 Don't assume (via atoi) that time_t and pid_t fit in int.
2743 Check for time_t and/or pid_t out of range, e.g., via a network share.
2744 Don't alloca where an auto var works fine.
2745
2746 * fileio.c: Fix some integer overflow issues.
2747 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2748 Don't assume string length fits in int.
2749 (directory_file_name): Don't assume string length fits in long.
2750 (make_temp_name): Don't assume pid fits in int, or that its print
2751 length is less than 20.
2752
2753 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2754
2755 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2756
2757 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2758
2759 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2760 We prefer signed integers, even for size calculations.
2761
2762 * emacs.c: Don't assume string length fits in 'int'.
2763 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2764 (main): Don't invoke strlen when not needed.
2765
2766 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2767 (XD_DEBUG_MESSAGE): Don't waste a byte.
2768
2769 * callproc.c (getenv_internal_1, getenv_internal)
2770 (Fgetenv_internal):
2771 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2772
2773 * lread.c (invalid_syntax): Omit length argument.
2774 All uses changed. This doesn't fix a bug, but it simplifies the
2775 code away from its former Hollerith-constant appearance, and it's
2776 one less 'int' to worry about when looking at integer-overflow issues.
2777 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2778
2779 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2780 This didn't break anything, but it didn't help either.
2781 It's confusing to put a bogus integer in a place where the actual
2782 value does not matter.
2783 (LIST_END_P): Remove unused macro and its bogus comment.
2784 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2785
2786 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2787 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2788 implementation.
2789 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2790 We prefer signed types, and the value cannot exceed the EMACS_INT
2791 range anyway (because otherwise the length would not be representable).
2792 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2793 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2794 This avoids a GCC warning when WIDE_EMACS_INT.
2795
2796 * indent.c (sane_tab_width): New function.
2797 (current_column, scan_for_column, Findent_to, position_indentation)
2798 (compute_motion): Use it. This is just for clarity.
2799 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2800
2801 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2802
2803 * lisp.h (lint_assume): New macro.
2804 * composite.c (composition_gstring_put_cache):
2805 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2806
2807 * editfns.c, insdel.c:
2808 Omit unnecessary forward decls, to simplify future changes.
2809
2810 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2811
2812 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2813
2814 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2815 Use much-faster test for byte-length change.
2816 Don't assume string byte-length fits in 'int'.
2817 Check that character arg fits in 'int'.
2818 (mapcar1): Declare byte as byte, for clarity.
2819
2820 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2821
2822 * fns.c (concat): Catch string overflow earlier.
2823 Do not rely on integer wraparound.
2824
2825 * dispextern.h (struct it.overlay_strings_charpos)
2826 (struct it.selective): Now EMACS_INT, not int.
2827 * xdisp.c (forward_to_next_line_start)
2828 (back_to_previous_visible_line_start)
2829 (reseat_at_next_visible_line_start, next_element_from_buffer):
2830 Don't arbitrarily truncate the value of 'selective' to int.
2831
2832 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2833
2834 * composite.c: Don't truncate sizes to 'int'.
2835 (composition_gstring_p, composition_reseat_it)
2836 (composition_adjust_point): Use EMACS_INT, not int.
2837 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2838 not EMACS_UINT, for indexes.
2839
2840 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2841
2842 * buffer.c: Include <verify.h>.
2843 (struct sortvec.priority, struct sortstr.priority):
2844 Now EMACS_INT, not int.
2845 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2846 (struct sortstr.size, record_overlay_string)
2847 (struct sortstrlist.size, struct sortlist.used):
2848 Don't truncate size to int.
2849 (record_overlay_string): Check for size-calculation overflow.
2850 (init_buffer_once): Check at compile-time, not run-time.
2851
2852 2011-06-22 Jim Meyering <meyering@redhat.com>
2853
2854 Don't leak an XBM-image-sized buffer
2855 * image.c (xbm_load): Free the image buffer after using it.
2856
2857 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2858
2859 Port to Sun C.
2860 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2861 that Sun C diagnosed.
2862 * fns.c (secure_hash): Fix pointer signedness issue.
2863 * intervals.c (static_offset_intervals): New function.
2864 (offset_intervals): Use it.
2865
2866 2011-06-21 Leo Liu <sdl.web@gmail.com>
2867
2868 * deps.mk (fns.o):
2869 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2870 sha512.h.
2871
2872 * fns.c (secure_hash): Rename from crypto_hash_function and change
2873 the first arg to accept symbols.
2874 (Fsecure_hash): New primitive.
2875 (syms_of_fns): New symbols.
2876
2877 2011-06-20 Deniz Dogan <deniz@dogan.se>
2878
2879 * process.c (Fset_process_buffer): Clarify return value in
2880 docstring.
2881
2882 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2883
2884 * dispnew.c (add_window_display_history): Use BVAR.
2885
2886 * xdisp.c (debug_method_add): Use BVAR.
2887 (check_window_end, dump_glyph_matrix, dump_glyph)
2888 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2889
2890 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2891 Likewise.
2892
2893 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2894 check till after the cache is created in init_frame_faces.
2895
2896 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2897
2898 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2899
2900 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2901
2902 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2903 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2904 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2905
2906 Improve buffer-overflow checking (Bug#8873).
2907 * fileio.c (Finsert_file_contents):
2908 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2909 Remove the old (too-loose) buffer overflow checks.
2910 They weren't needed, since make_gap checks for buffer overflow.
2911 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2912 The old code merely checked for Emacs fixnum overflow, and relied
2913 on undefined (wraparound) behavior. The new code avoids undefined
2914 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2915
2916 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2917 Tune. Don't use wider integers than needed. Don't use alloca.
2918 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2919
2920 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2921
2922 * insdel.c, lisp.h (buffer_overflow): New function.
2923 (insert_from_buffer_1, replace_range, replace_range_2):
2924 * insdel.c (make_gap_larger):
2925 * editfns.c (Finsert_char):
2926 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2927
2928 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2929
2930 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2931
2932 Integer overflow and signedness fixes (Bug#8873).
2933
2934 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2935 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2936
2937 * fileio.c: Don't assume EMACS_INT fits in off_t.
2938 (emacs_lseek): New static function.
2939 (Finsert_file_contents, Fwrite_region): Use it.
2940 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2941
2942 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2943
2944 * fns.c: Don't overflow int when computing a list length.
2945 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2946 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2947 truncation on 64-bit hosts. Check for QUIT every
2948 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2949 faster and is responsive enough.
2950 (Flength): Report an error instead of overflowing an integer.
2951 (Fsafe_length): Return a float if the value is not representable
2952 as a fixnum. This shouldn't happen except in contrived situations.
2953 (Fnthcdr, Fsort): Don't assume list length fits in int.
2954 (Fcopy_sequence): Don't assume vector length fits in int.
2955
2956 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2957 (header_size, word_size): New constants.
2958 (allocate_vectorlike): Don't check size overflow here.
2959 (allocate_vector): Check it here instead, since this is the only
2960 caller of allocate_vectorlike that could cause overflow.
2961 Check that the new vector's length is representable as a fixnum.
2962
2963 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2964 The previous code was bogus. For example, next_almost_prime (32)
2965 returned 39, which is undesirable as it is a multiple of 3; and
2966 next_almost_prime (24) returned 25, which is a multiple of 5 so
2967 why was the code bothering to check for multiples of 7?
2968
2969 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2970
2971 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2972
2973 Variadic C functions now count arguments with ptrdiff_t.
2974 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2975 Back then I didn't know that the Emacs coding style prefers signed int.
2976 Also, in the meantime I found a few more instances where arguments
2977 were being counted with int, which may truncate counts on 64-bit
2978 machines, or EMACS_INT, which may be unnecessarily wide.
2979 * lisp.h (struct Lisp_Subr.function.aMANY)
2980 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2981 Arg counts are now ptrdiff_t, not size_t.
2982 All variadic functions and their callers changed accordingly.
2983 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2984 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2985 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2986 * callint.c (Fcall_interactively): Check arg count for overflow,
2987 to avoid potential buffer overrun. Use signed char, not 'int',
2988 for 'varies' array, so that we needn't bother to check its size
2989 calculation for overflow.
2990 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2991 * eval.c (apply_lambda):
2992 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2993 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2994 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2995
2996 * callint.c (Fcall_interactively): Don't use index var as event count.
2997
2998 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2999 * mem-limits.h (SIZE): Remove; no longer used.
3000
3001 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3002
3003 Remove unnecessary casts.
3004 * xterm.c (x_term_init):
3005 * xfns.c (x_set_border_pixel):
3006 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3007 These aren't needed now that we assume ANSI C.
3008
3009 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3010 It's more likely to cause problems (due to unsigned overflow)
3011 than to cure them.
3012
3013 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3014
3015 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3016
3017 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3018
3019 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3020
3021 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3022
3023 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3024
3025 GLYPH_CODE_FACE returns EMACS_INT, not int.
3026 * dispextern.h (merge_faces):
3027 * xfaces.c (merge_faces):
3028 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3029 Don't assume EMACS_INT fits in int.
3030
3031 * character.h (CHAR_VALID_P): Remove unused parameter.
3032 * fontset.c, lisp.h, xdisp.c: All uses changed.
3033
3034 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3035
3036 * fns.c (concat): Minor tuning based on overflow analysis.
3037 This doesn't fix any bugs. Use int to hold character, instead
3038 of constantly refetching from Emacs object. Use XFASTINT, not
3039 XINT, for value known to be a character. Don't bother comparing
3040 a single byte to 0400, as it's always less.
3041
3042 * floatfns.c (Fexpt):
3043 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3044
3045 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3046 for characters.
3047
3048 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3049
3050 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3051 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3052 incorrectly succeed when S was a string, because 4294967386 was
3053 truncated before it was used.
3054
3055 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3056 Otherwise, an out-of-range integer could cause undefined behavior
3057 on a 64-bit host.
3058
3059 * composite.c: Use int, not EMACS_INT, for characters.
3060 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3061 EMACS_INT, for values that are known to be in character range.
3062 This doesn't fix any bugs but is the usual style inside Emacs and
3063 may generate better code on 32-bit machines.
3064
3065 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3066 This is for reasons similar to the recent CHAR_STRING fix.
3067 * charset.c (Fencode_char): Check that character arg is actually
3068 a character. Pass an int to ENCODE_CHAR.
3069 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3070 wider than 'int', as a compile-time check to prevent future regressions
3071 in this area.
3072
3073 * character.c (char_string): Remove unnecessary casts.
3074
3075 Make sure a 64-bit char is never passed to CHAR_STRING.
3076 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3077 by silently ignoring the top 32 bits, allowing some values
3078 that were far too large to be valid characters.
3079 * character.h: Include <verify.h>.
3080 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3081 arguments are no wider than unsigned, as a compile-time check
3082 to prevent future regressions in this area.
3083 * data.c (Faset):
3084 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3085 (Fsubst_char_in_region):
3086 * fns.c (concat):
3087 * xdisp.c (decode_mode_spec_coding):
3088 Adjust to CHAR_STRING's new requirement.
3089 * editfns.c (Finsert_char, Fsubst_char_in_region):
3090 * fns.c (concat): Check that character args are actually
3091 characters. Without this test, these functions did the wrong
3092 thing with wildly out-of-range values on 64-bit hosts.
3093
3094 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3095 These casts should not be needed on 32-bit hosts, either.
3096 * keyboard.c (read_char):
3097 * lread.c (Fload): Remove casts to unsigned.
3098
3099 * lisp.h (UNSIGNED_CMP): New macro.
3100 This fixes comparison bugs on 64-bit hosts.
3101 (ASCII_CHAR_P): Use it.
3102 * casefiddle.c (casify_object):
3103 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3104 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3105 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3106 * dispextern.h (FACE_FROM_ID):
3107 * keyboard.c (read_char): Use UNSIGNED_CMP.
3108
3109 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3110 not to EMACS_INT, to avoid GCC warning.
3111
3112 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3113
3114 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3115 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3116 isn't needed on 32-bit machines.
3117
3118 * buffer.c (Fgenerate_new_buffer_name):
3119 Use EMACS_INT for count, not int.
3120 (advance_to_char_boundary): Return EMACS_INT, not int.
3121
3122 * data.c (Qcompiled_function): Now static.
3123
3124 * window.c (window_body_lines): Now static.
3125
3126 * image.c (gif_load): Rename local to avoid shadowing.
3127
3128 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3129 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3130 * alloc.c (make_save_value): Integer argument is now of type
3131 ptrdiff_t, not int.
3132 (mark_object): Use ptrdiff_t, not int.
3133 * lisp.h (pD): New macro.
3134 * print.c (print_object): Use it.
3135
3136 * alloc.c: Use EMACS_INT, not int, to count objects.
3137 (total_conses, total_markers, total_symbols, total_vector_size)
3138 (total_free_conses, total_free_markers, total_free_symbols)
3139 (total_free_floats, total_floats, total_free_intervals)
3140 (total_intervals, total_strings, total_free_strings):
3141 Now EMACS_INT, not int. All uses changed.
3142 (Fgarbage_collect): Compute overall total using a double, so that
3143 integer overflow is less likely to be a problem. Check for overflow
3144 when converting back to an integer.
3145 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3146 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3147 These were 'int' variables that could overflow on 64-bit hosts;
3148 they were never used, so remove them instead of repairing them.
3149 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3150 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3151 Previously, this ceilinged at INT_MAX, but that doesn't work on
3152 64-bit machines.
3153 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3154
3155 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3156 (allocate_vectorlike): Check for ptrdiff_t overflow.
3157 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3158 when a (possibly-narrower) signed value would do just as well.
3159 We prefer using signed arithmetic, to avoid comparison confusion.
3160
3161 * alloc.c: Catch some string size overflows that we were missing.
3162 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3163 for convenience in STRING_BYTES_MAX.
3164 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3165 The definition here is exact; the one in lisp.h was approximate.
3166 (allocate_string_data): Check for string overflow. This catches
3167 some instances we weren't catching before. Also, it catches
3168 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3169 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3170 and ptrdiff_t and EMACS_INT are both 64 bits.
3171
3172 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3173 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3174 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3175
3176 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3177
3178 * alloc.c (Fmake_string): Check for out-of-range init.
3179
3180 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3181
3182 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3183
3184 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3185
3186 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3187 xg_get_default_scrollbar_width.
3188
3189 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3190 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3191 (style_changed_cb): Call update_theme_scrollbar_width and call
3192 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3193 all frames (Bug#8505).
3194 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3195 Call gtk_window_set_resizable if HAVE_GTK3.
3196 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3197 and height if HAVE_GTK3 (Bug#8505).
3198 (scroll_bar_width_for_theme): New variable.
3199 (update_theme_scrollbar_width): New function.
3200 (xg_get_default_scrollbar_width): Move code to
3201 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3202 (xg_initialize): Call update_theme_scrollbar_width.
3203
3204 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3205
3206 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3207
3208 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3209
3210 * frame.c (make_frame): Call other_buffer_safely instead of
3211 other_buffer.
3212
3213 * window.c (temp_output_buffer_show): Call display_buffer with
3214 second argument Vtemp_buffer_show_specifiers and reset latter
3215 immediately after the call.
3216 (Vtemp_buffer_show_specifiers): New variable.
3217 (auto_window_vscroll_p, next_screen_context_lines)
3218 (Vscroll_preserve_screen_position): Remove leading asterisks from
3219 doc-strings.
3220
3221 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3222
3223 Fix minor problems found by GCC 4.6.0 static checking.
3224 * buffer.c (Qclone_number): Remove for now, as it's unused.
3225 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3226 (record_buffer): Remove unused local.
3227 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3228 (set_frame_buffer_list): Remove; unused.
3229 * frame.h (other_visible_frames): Remove decl.
3230 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3231 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3232 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3233 if HAVE_GPM.
3234 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3235 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3236 Define only if HAVE_GPM.
3237 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3238 (update_hints_inhibit): Remove; never set. All uses removed.
3239 * widgetprv.h (emacsFrameClassRec): Remove decl.
3240 * window.c (delete_deletable_window): Now returns void, since it
3241 wasn't returning anything.
3242 (compare_window_configurations): Remove unused locals.
3243 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3244 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3245 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3246 the same widths as pointers. This follows up on the 2011-05-06 patch.
3247 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3248 * xterm.h: Likewise.
3249 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3250
3251 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3252
3253 * makefile.w32-in: Update dependencies.
3254 (LISP_H): Add lib/intprops.h.
3255
3256 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3257
3258 * image.c (gif_load): Add animation frame delay to the metadata.
3259 (syms_of_image): Use DEFSYM. New symbol `delay'.
3260
3261 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3262
3263 * window.c (delete_deletable_window): Re-add.
3264 (Fset_window_configuration): Rewrite to handle dead buffers and
3265 consequently deletable windows.
3266 (window_tree, Fwindow_tree): Remove. Supply functionality in
3267 window.el.
3268 (compare_window_configurations): Simplify code.
3269
3270 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3271
3272 * image.c (imagemagick_load_image): Fix type mismatch.
3273 (Fimagemagick_types): Likewise.
3274
3275 * window.h (replace_buffer_in_windows): Declare.
3276
3277 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3278
3279 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3280 Qclone_number. Remove external declaration of Qdelete_window.
3281 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3282 code.
3283 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3284 Run Qbuffer_list_update_hook if allowed.
3285 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3286 buffer list implementation.
3287 (other_buffer_safely): New function.
3288 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3289 calls to replace_buffer_in_windows and
3290 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3291 if allowed.
3292 (record_buffer): Inhibit quitting and rewrite using quittable
3293 functions. Run Qbuffer_list_update_hook if allowed.
3294 (Frecord_buffer, Funrecord_buffer): New functions.
3295 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3296 Move switch-to-buffer to window.el.
3297 (bury-buffer): Move to window.el.
3298 (Vbuffer_list_update_hook): New variable.
3299
3300 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3301 section.
3302
3303 * window.h (resize_frame_windows): Move up in code.
3304 (Fwindow_frame): Remove EXFUN.
3305 (replace_buffer_in_all_windows): Remove prototype.
3306 (replace_buffer_in_windows_safely): Add prototype.
3307
3308 * window.c: Declare Qdelete_window static again. Move down
3309 declaration of select_count.
3310 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3311 (Fother_window): Move to window.el.
3312 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3313 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3314 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3315 window.el.
3316 (replace_buffer_in_windows): Implement by calling
3317 Qreplace_buffer_in_windows.
3318 (replace_buffer_in_all_windows): Remove with some functionality
3319 moved into replace_buffer_in_windows_safely.
3320 (replace_buffer_in_windows_safely): New function.
3321 (select_window_norecord, select_frame_norecord): Move in front
3322 of run_window_configuration_change_hook. Remove now obsolete
3323 declarations.
3324 (Fset_window_buffer): Rewrite doc-string.
3325 Call Qrecord_window_buffer.
3326 (keys_of_window): Move binding for other-window to window.el.
3327
3328 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3329
3330 * dispextern.h (struct image): Replace data member, whose int_val
3331 and ptr_val fields were not used by anything, with a single
3332 lisp_val object.
3333
3334 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3335 (gif_clear_image, gif_load, imagemagick_load_image)
3336 (gs_clear_image, gs_load): Callers changed.
3337
3338 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3339
3340 * buffer.h: Include <time.h>, for time_t.
3341 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3342
3343 Fix minor problems found by static checking.
3344
3345 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3346
3347 Make identifiers static if they are not used in other modules.
3348 * data.c (Qcompiled_function, Qframe, Qvector):
3349 * image.c (QimageMagick, Qsvg):
3350 * minibuf.c (Qmetadata):
3351 * window.c (resize_window_check, resize_root_window): Now static.
3352 * window.h (resize_window_check, resize_root_window): Remove decls.
3353
3354 * window.c (window_deletion_count, delete_deletable_window):
3355 Remove; unused.
3356 (window_body_lines): Now static.
3357 (Fdelete_other_windows_internal): Mark vars as initialized.
3358 Make sure 'resize_failed' is initialized.
3359 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3360 (resize_window_apply): Remove unused local.
3361 * window.h (delete_deletable_window): Remove decl.
3362
3363 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3364 (imagemagick_load_image): Fix pointer signedness problem by changing
3365 last arg from unsigned char * to char *. All uses changed.
3366 Also, fix a local for similar reasons.
3367 Remove unused locals. Remove locals to avoid shadowing.
3368 (fn_rsvg_handle_free): Remove; unused.
3369 (svg_load, svg_load_image): Fix pointer signedness problem.
3370 (imagemagick_load_image): Don't use garbage pointer image_wand.
3371
3372 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3373
3374 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3375
3376 * image.c (gif_load): Fix omitted cast error introduced by
3377 2011-06-06 change.
3378
3379 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3380
3381 * window.h (resize_proportionally, orig_total_lines)
3382 (orig_top_line): Remove from window structure.
3383 (set_window_height, set_window_width, change_window_heights)
3384 (Fdelete_window): Remove prototypes.
3385 (resize_frame_windows): Remove duplicate declaration.
3386
3387 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3388
3389 * window.h (resize_frame_windows, resize_window_check)
3390 (delete_deletable_window, resize_root_window)
3391 (resize_frame_windows): Declare prototypes.
3392
3393 * window.c (resize_window_apply): Make definition be "static" to
3394 match the prototype.
3395
3396 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3397
3398 * window.c: Remove declarations of Qwindow_size_fixed,
3399 window_min_size_1, window_min_size_2, window_min_size,
3400 size_window, window_fixed_size_p, enlarge_window, delete_window.
3401 Remove static from declaration of Qdelete_window, it's
3402 temporarily needed by Fbury_buffer.
3403 (replace_window): Don't assign orig_top_line and
3404 orig_total_lines.
3405 (Fdelete_window, delete_window): Remove. Window deletion is
3406 handled by window.el.
3407 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3408 Replace Fdelete_window calls with calls to Qdelete_window.
3409 (Fdelete_other_windows): Remove. Deleting other windows is
3410 handled by window.el.
3411 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3412 handled in window.el.
3413 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3414 Window minimum sizes are handled in window.el.
3415 (shrink_windows, size_window, set_window_height)
3416 (set_window_width, change_window_heights, window_height)
3417 (window_width, CURBEG, CURSIZE, enlarge_window)
3418 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3419 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3420 handled in window.el.
3421 (make_dummy_parent): Rename to make_parent_window and give it a
3422 second argument horflag.
3423 (make_window): Don't set resize_proportionally any more.
3424 (Fsplit_window): Remove. Windows are split in window.el.
3425 (save_restore_action, save_restore_orig_size)
3426 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3427 Resize mini windows in window.el.
3428 (grow_mini_window, shrink_mini_window): Implement by calling
3429 Qresize_root_window_vertically, resize_window_check and
3430 resize_window_apply.
3431 (saved_window, Fset_window_configuration, save_window_save):
3432 Do not handle orig_top_line, orig_total_lines, and
3433 resize_proportionally.
3434 (window_min_height, window_min_width): Move to window.el.
3435 (keys_of_window): Move bindings for delete-other-windows,
3436 split-window, delete-window and enlarge-window to window.el.
3437
3438 * buffer.c: Temporarily extern Qdelete_window.
3439 (Fbury_buffer): Temporarily call Qdelete_window instead of
3440 Fdelete_window (Fbury_buffer will move to window.el soon).
3441
3442 * frame.c (set_menu_bar_lines_1): Remove code handling
3443 orig_top_line and orig_total_lines.
3444
3445 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3446 set_window_height but set heights directly.
3447 (change_frame_size_1): Use resize_frame_windows.
3448
3449 * xdisp.c (init_xdisp): Don't use set_window_height but set
3450 heights directly.
3451
3452 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3453 Use resize_frame_windows instead of change_window_heights and run
3454 run_window_configuration_change_hook.
3455
3456 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3457 instead of change_window_heights and run
3458 run_window_configuration_change_hook.
3459
3460 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3461
3462 * window.c (replace_window): Rename second argument REPLACEMENT to
3463 NEW. New third argument SETFLAG. Rewrite.
3464 (delete_window, make_dummy_parent): Call replace_window with
3465 third argument 1.
3466 (window_list_1): Move down in code.
3467 (run_window_configuration_change_hook): Move set_buffer part
3468 before select_frame_norecord part in order to unwind correctly.
3469 Rename count1 to count.
3470 (recombine_windows, delete_deletable_window, resize_root_window)
3471 (Fdelete_other_windows_internal)
3472 (Frun_window_configuration_change_hook, make_parent_window)
3473 (resize_window_check, resize_window_apply, Fresize_window_apply)
3474 (resize_frame_windows, Fsplit_window_internal)
3475 (Fdelete_window_internal, Fresize_mini_window_internal):
3476 New functions.
3477 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3478
3479 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3480
3481 * window.h (window): Add some new members to window structure -
3482 normal_lines, normal_cols, new_total, new_normal, clone_number,
3483 splits, nest, prev_buffers, next_buffers.
3484 (WINDOW_TOTAL_SIZE): Move here from window.c.
3485 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3486
3487 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3488 Remove.
3489 (make_dummy_parent): Set new members of windows structure.
3490 (make_window): Move down in code. Handle new members of window
3491 structure.
3492 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3493 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3494 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3495 (Fset_window_prev_buffers, Fwindow_next_buffers)
3496 (Fset_window_next_buffers, Fset_window_clone_number):
3497 New functions.
3498 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3499 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3500 Doc-string fixes.
3501 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3502 Argument WINDOW can be now internal window too.
3503 (Fwindow_use_time): Move up in code.
3504 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3505 Rewrite doc-string.
3506 (Fset_window_configuration, saved_window)
3507 (Fcurrent_window_configuration, save_window_save): Handle new
3508 members of window structure.
3509 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3510 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3511 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3512 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3513 Qget_mru_window, Qresize_root_window,
3514 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3515 Qauto_buffer_name; staticpro them.
3516
3517 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3518
3519 * window.c (Fwindow_total_size, Fwindow_left_column)
3520 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3521 (Fwindow_list_1): New functions.
3522 (window_box_text_cols): Replace with window_body_cols.
3523 (Fwindow_width, Fscroll_left, Fscroll_right):
3524 Use window_body_cols instead of window_box_text_cols.
3525 (delete_window, Fset_window_configuration):
3526 Call delete_all_subwindows with window as argument.
3527 (delete_all_subwindows): Take a window as argument and not a
3528 structure. Rewrite.
3529 (window_loop): Remove handling of GET_LRU_WINDOW and
3530 GET_LARGEST_WINDOW.
3531 (Fget_lru_window, Fget_largest_window): Move to window.el.
3532
3533 * window.h: Extern window_body_cols instead of
3534 window_box_text_cols. delete_all_subwindows now takes a
3535 Lisp_Object as argument.
3536
3537 * indent.c (compute_motion, Fcompute_motion):
3538 Use window_body_cols instead of window_box_text_cols.
3539
3540 * frame.c (delete_frame): Call delete_all_subwindows with root
3541 window as argument.
3542
3543 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3544
3545 * fns.c (Fputhash): Document return value.
3546
3547 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3548
3549 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3550
3551 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3552
3553 Cons<->int and similar integer overflow fixes (Bug#8794).
3554
3555 Check for overflow when converting integer to cons and back.
3556 * charset.c (Fdefine_charset_internal, Fdecode_char):
3557 Use cons_to_unsigned to catch overflow.
3558 (Fencode_char): Use INTEGER_TO_CONS.
3559 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3560 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3561 * data.c (long_to_cons, cons_to_long): Remove.
3562 (cons_to_unsigned, cons_to_signed): New functions.
3563 These signal an error for invalid or out-of-range values.
3564 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3565 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3566 * font.c (Ffont_variation_glyphs):
3567 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3568 * lisp.h: Include <intprops.h>.
3569 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3570 (cons_to_signed, cons_to_unsigned): New decls.
3571 (long_to_cons, cons_to_long): Remove decls.
3572 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3573 (Fprimitive_undo): Use CONS_TO_INTEGER.
3574 * xfns.c (Fx_window_property): Likewise.
3575 * xselect.c: Include <limits.h>.
3576 (x_own_selection, selection_data_to_lisp_data):
3577 Use INTEGER_TO_CONS.
3578 (x_handle_selection_request, x_handle_selection_clear)
3579 (x_get_foreign_selection, Fx_disown_selection_internal)
3580 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3581 (lisp_data_to_selection_data): Use cons_to_unsigned.
3582 (x_fill_property_data): Use cons_to_signed.
3583 Report values out of range.
3584
3585 Check for buffer and string overflow more precisely.
3586 * buffer.h (BUF_BYTES_MAX): New macro.
3587 * lisp.h (STRING_BYTES_MAX): New macro.
3588 * alloc.c (Fmake_string):
3589 * character.c (string_escape_byte8):
3590 * coding.c (coding_alloc_by_realloc):
3591 * doprnt.c (doprnt):
3592 * editfns.c (Fformat):
3593 * eval.c (verror):
3594 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3595 since they may not be the same number.
3596 * editfns.c (Finsert_char):
3597 * fileio.c (Finsert_file_contents):
3598 Likewise for BUF_BYTES_MAX.
3599
3600 * image.c: Use ptrdiff_t, not int, for sizes.
3601 (slurp_file): Switch from int to ptrdiff_t.
3602 All uses changed.
3603 (slurp_file): Check that file size fits in both size_t (for
3604 malloc) and ptrdiff_t (for sanity and safety).
3605
3606 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3607 if b->modtime has its maximal value.
3608
3609 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3610
3611 Don't assume time_t can fit into int.
3612 * buffer.h (struct buffer.modtime): Now time_t, not int.
3613 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3614 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3615
3616 Minor fixes for signed vs unsigned integers.
3617 * character.h (MAYBE_UNIFY_CHAR):
3618 * charset.c (maybe_unify_char):
3619 * keyboard.c (read_char, reorder_modifiers):
3620 XINT -> XFASTINT, since the integer must be nonnegative.
3621 * ftfont.c (ftfont_spec_pattern):
3622 * keymap.c (access_keymap, silly_event_symbol_error):
3623 XUINT -> XFASTINT, since the integer must be nonnegative.
3624 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3625 since it makes no difference and we prefer signed.
3626 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3627 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3628 nonnegative.
3629
3630 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3631
3632 * window.h (Fwindow_frame): Declare.
3633
3634 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3635
3636 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3637 (SPARE_MEMORY): Always define.
3638 (LARGE_REQUEST): Remove.
3639 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3640
3641 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3642
3643 * lisp.h: Move EXFUNS for Fframe_root_window,
3644 Fframe_first_window and Fset_frame_selected_window to window.h.
3645
3646 * window.h: Move EXFUNS for Fframe_root_window,
3647 Fframe_first_window and Fset_frame_selected_window here from
3648 lisp.h.
3649
3650 * frame.c (Fwindow_frame, Fframe_first_window)
3651 (Fframe_root_window, Fframe_selected_window)
3652 (Fset_frame_selected_window): Move to window.c.
3653 (Factive_minibuffer_window): Move to minibuf.c.
3654 (Fother_visible_frames_p): New function.
3655
3656 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3657
3658 * window.c (decode_window, decode_any_window): Move up in code.
3659 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3660 (inhibit_frame_unsplittable): Remove unused variable.
3661 (Fwindow_buffer): Move up and rewrite doc-string.
3662 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3663 (Fwindow_prev): New functions.
3664 (Fwindow_frame): Move here from frame.c. Accept any window as
3665 argument.
3666 (Fframe_root_window, Fframe_first_window)
3667 (Fframe_selected_window): Move here from frame.c. Accept frame
3668 or arbitrary window as argument. Update doc-strings.
3669 (Fminibuffer_window): Move up in code.
3670 (Fwindow_minibuffer_p): Move up in code and simplify.
3671 (Fset_frame_selected_window): Move here from frame.c.
3672 Marginal rewrite.
3673 (Fselected_window, select_window, Fselect_window): Move up in
3674 code. Minor doc-string fixes.
3675
3676 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3677
3678 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3679 Do not assume that spare memory exists; that assumption is valid
3680 only if SYSTEM_MALLOC.
3681 (LARGE_REQUEST): New macro, so that the issue of large requests
3682 is separated from the issue of spare memory.
3683
3684 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3685
3686 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3687 format. (Bug#8806)
3688
3689 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3690
3691 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3692 before statements.
3693
3694 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3695
3696 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3697
3698 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3699
3700 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3701 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3702
3703 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3704
3705 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3706
3707 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3708
3709 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3710 (x_clipboard_manager_save): Add return value.
3711 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3712 New error handlers.
3713 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3714 Obey Vx_select_enable_clipboard_manager. Catch errors in
3715 x_clipboard_manager_save (Bug#8779).
3716 (Vx_select_enable_clipboard_manager): New variable.
3717 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3718
3719 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3720
3721 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3722
3723 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3724
3725 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3726 in the current matrix if keep_current_p is non-zero.
3727
3728 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3729
3730 * bidi.c (bidi_level_of_next_char): Fix last change.
3731
3732 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3733
3734 Support bidi reordering of text covered by display properties.
3735
3736 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3737 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3738 (bidi_cache_search, bidi_cache_iterator_state)
3739 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3740 (bidi_level_of_next_char, bidi_move_to_visually_next):
3741 Support character positions inside a run of characters covered by a
3742 display string.
3743 (bidi_paragraph_init, bidi_resolve_explicit_1)
3744 (bidi_level_of_next_char): Call bidi_fetch_char and
3745 bidi_fetch_char_advance instead of FETCH_CHAR and
3746 FETCH_CHAR_ADVANCE.
3747 (bidi_init_it): Initialize new members.
3748 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3749 definitions.
3750 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3751 instead of using explicit *_CHAR codes.
3752 (bidi_resolve_explicit, bidi_resolve_weak):
3753 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3754 bidirectional text is supported only in multibyte buffers.
3755 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3756 it to initialize the frame_window_p member of struct bidi_it.
3757 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3758 (bidi_resolve_explicit, bidi_resolve_weak)
3759 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3760 bidi_it->nchars is non-positive.
3761 (bidi_level_of_next_char): Don't try to lookup the cache for the
3762 next/previous character if nothing is cached there yet, or if we
3763 were just reseat()'ed to a new position.
3764
3765 * xdisp.c (set_cursor_from_row): Set start and stop points
3766 according to the row's direction when priming the loop that looks
3767 for the glyph on which to display cursor.
3768 (single_display_spec_intangible_p): Function deleted.
3769 (display_prop_intangible_p): Reimplement to call
3770 handle_display_spec instead of single_display_spec_intangible_p.
3771 Accept 3 additional arguments needed by handle_display_spec.
3772 This fixes incorrect cursor motion across display property with complex
3773 values: lists, `(when COND...)' forms, etc.
3774 (single_display_spec_string_p): Support property values that are
3775 lists with the argument STRING its top-level element.
3776 (display_prop_string_p): Fix the condition for processing a
3777 property that is a list to be consistent with handle_display_spec.
3778 (handle_display_spec): New function, refactored from the
3779 last portion of handle_display_prop.
3780 (compute_display_string_pos): Accept additional argument
3781 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3782 value of a `display' property is a "replacing spec".
3783 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3784 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3785 the display property, but just return a value indicating whether
3786 the display property will replace the characters it covers.
3787 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3788 frame_window_p members of struct bidi_it.
3789 (compute_display_string_pos, compute_display_string_end):
3790 New functions.
3791 (push_it): Accept second argument POSITION, where pop_it should
3792 jump to continue iteration.
3793 (reseat_1): Initialize bidi_it.disp_pos.
3794
3795 * keyboard.c (adjust_point_for_property): Adjust the call to
3796 display_prop_intangible_p to its new signature.
3797
3798 * dispextern.h (struct bidi_it): New member frame_window_p.
3799 (bidi_init_it): Update prototypes.
3800 (display_prop_intangible_p): Update prototype.
3801 (compute_display_string_pos, compute_display_string_end):
3802 Declare prototypes.
3803 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3804 EMACS_INT.
3805
3806 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 Malloc failure behavior now depends on size of allocation.
3809 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3810 * lisp.h: Change signatures accordingly.
3811 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3812 All callers changed. (Bug#8762)
3813
3814 * gnutls.c: Use Emacs's memory allocators.
3815 Without this change, the gnutls library would invoke malloc etc.
3816 directly, which causes problems on non-SYNC_INPUT hosts, and which
3817 runs afoul of improving memory_full behavior. (Bug#8761)
3818 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3819 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3820 xfree instead of the default malloc, realloc, free.
3821 (Fgnutls_boot): No need to check for memory allocation failure,
3822 since xmalloc does that for us.
3823
3824 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3825 * category.c (hash_get_category_set):
3826 * ccl.c (ccl_driver):
3827 * charset.c (Fdefine_charset_internal):
3828 * charset.h (struct charset.hash_index):
3829 * composite.c (get_composition_id, gstring_lookup_cache)
3830 (composition_gstring_put_cache):
3831 * composite.h (struct composition.hash_index):
3832 * dispextern.h (struct image.hash):
3833 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3834 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3835 (hashfn_equal, hashfn_user_defined, make_hash_table)
3836 (maybe_resize_hash_table, hash_lookup, hash_put)
3837 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3838 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3839 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3840 * image.c (make_image, search_image_cache, lookup_image)
3841 (xpm_put_color_table_h):
3842 * lisp.h (struct Lisp_Hash_Table):
3843 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3844 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3845 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3846 * alloc.c (allocate_vectorlike):
3847 Check for overflow in vector size calculations.
3848 * ccl.c (ccl_driver):
3849 Check for overflow when converting EMACS_INT to int.
3850 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3851 need to be updated by these changes.
3852 * fns.c (make_hash_table, maybe_resize_hash_table):
3853 Check for integer overflow with large hash tables.
3854 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3855 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3856 (SXHASH_REDUCE): New macro.
3857 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3858 Use it instead of discarding useful hash info with large hash values.
3859 (sxhash_float): New function.
3860 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3861 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3862 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3863 Rewrite to use FIXNUM_BITS, as this simplifies things.
3864 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3865 Adjust signatures to match updated version of code.
3866 (consing_since_gc): Now EMACS_INT, since a single hash table can
3867 use more than INT_MAX bytes.
3868
3869 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3870
3871 Make it possible to build with GCC-4.6+ -O2 -flto.
3872
3873 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3874
3875 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3876
3877 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3878 Call minibuffer-inactive-mode.
3879
3880 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3881
3882 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3883 Update dependencies.
3884
3885 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3886
3887 * data.c (init_data): Remove code for UTS, this system is not
3888 supported anymore.
3889
3890 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3891
3892 Don't force ./temacs to start in terminal mode.
3893
3894 * frame.c (make_initial_frame): Initialize faces in all cases, not
3895 only when CANNOT_DUMP is defined.
3896 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3897
3898 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3899
3900 * dispnew.c (add_window_display_history): Use const for the string
3901 pointer. Remove declaration, not needed.
3902
3903 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3904
3905 Use 'inline', not 'INLINE'.
3906 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3907 * alloc.c, fontset.c (INLINE): Remove.
3908 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3909 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3910 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3911 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3912 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3913
3914 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3915
3916 Make it possible to run ./temacs.
3917
3918 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3919 syms_of_callproc does the same thing. Remove test for
3920 "initialized", do it in the caller.
3921 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3922
3923 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3924
3925 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3926 (read_minibuf): Use get_minibuffer.
3927 (syms_of_minibuf): Use DEFSYM.
3928 (Qmetadata): New var.
3929 * data.c (Qbuffer): Don't make it static.
3930 (syms_of_data): Use DEFSYM.
3931
3932 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3933
3934 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3935 (CCL_CODE_MIN): New macro.
3936
3937 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3938
3939 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3940
3941 * eval.c (Qdebug): Now static.
3942 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3943 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3944 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3945
3946 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3947
3948 * image.c: Various fixes to ImageMagick code comments.
3949 (Fimagemagick_types): Doc fix.
3950
3951 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3952
3953 Minor fixes prompted by GCC 4.6.0 warnings.
3954
3955 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3956
3957 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3958 (x_clipboard_manager_save_all): Move extern decl to ...
3959 * xterm.h: ... here, so that it can be checked for consistency.
3960
3961 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3962
3963 * xselect.c (x_clipboard_manager_save_frame)
3964 (x_clipboard_manager_save_all): New functions.
3965 (Fx_clipboard_manager_save): Lisp function deleted.
3966
3967 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3968 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3969
3970 * xterm.h: Update prototype.
3971
3972 2011-05-28 William Xu <william.xwl@gmail.com>
3973
3974 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3975 exiting (Bug#8239).
3976
3977 2011-05-28 Jim Meyering <meyering@redhat.com>
3978
3979 Avoid a sign-extension bug in crypto_hash_function.
3980 * fns.c (to_uchar): Define.
3981 (crypto_hash_function): Use it to convert some newly-signed
3982 variables to unsigned, to avoid sign-extension bugs. For example,
3983 without this change, (md5 "truc") would evaluate to
3984 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3985 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3986 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3987
3988 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3989
3990 Integer overflow fixes.
3991
3992 * dbusbind.c: Serial number integer overflow fixes.
3993 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3994 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3995 to hold a serial number that is too large for a fixnum.
3996 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3997 Check for serial numbers out of range. Decode any serial number
3998 that was so large that it became a float. (Bug#8722)
3999
4000 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4001 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4002 Use XFASTINT rather than XUINT when numbers are nonnegative.
4003 (xd_append_arg, Fdbus_method_return_internal):
4004 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4005 arguments, check that Lisp number is nonnegative, rather than
4006 silently wrapping negative numbers around. (Bug#8722)
4007 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4008 (Bug#8722)
4009
4010 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4011
4012 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4013
4014 ccl: add integer overflow checks
4015 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4016 (IN_INT_RANGE): New macros.
4017 (ccl_driver): Use them to check for integer overflow when
4018 decoding a CCL program. Many of the new checks are whether XINT (x)
4019 fits in int; it doesn't always, on 64-bit hosts. The new version
4020 doesn't catch all possible integer overflows, but it's an
4021 improvement. (Bug#8719)
4022
4023 * alloc.c (make_event_array): Use XINT, not XUINT.
4024 There's no need for unsigned here.
4025
4026 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4027 This follows up to the 2011-05-06 change that substituted uintptr_t
4028 for EMACS_INT. This case wasn't caught back then.
4029
4030 Rework Fformat to avoid integer overflow issues.
4031 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4032 now (part of C89). Include <verify.h>.
4033 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4034 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4035 (Fformat): Avoid the prepass trying to compute sizes; it was only
4036 approximate and thus did not catch overflow reliably. Instead, walk
4037 through the format just once, formatting and computing sizes as we go,
4038 checking for integer overflow at every step, and allocating a larger
4039 buffer as needed. Keep track separately whether the format is
4040 multibyte. Keep only the most-recently calculated precision, rather
4041 than them all. Record whether each argument has been converted to
4042 string. Use EMACS_INT, not int, for byte and char and arg counts.
4043 Support field widths and precisions larger than INT_MAX. Avoid
4044 sprintf's undefined behavior with conversion specifications such as %#d
4045 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4046 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4047 formatting out-of-range floating point numbers with int
4048 formats. (Bug#8668)
4049
4050 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4051
4052 * data.c: Avoid integer truncation in expressions involving floats.
4053 * data.c: Include <intprops.h>.
4054 (arith_driver): When there's an integer overflow in an expression
4055 involving floating point, convert the integers to floating point
4056 so that the resulting value does not suffer from catastrophic
4057 integer truncation. For example, on a 64-bit host (* 4
4058 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4059 Do not rely on undefined behavior after integer overflow.
4060
4061 merge count_size_as_multibyte, parse_str_to_multibyte
4062 * character.c, character.h (count_size_as_multibyte):
4063 Rename from parse_str_to_multibyte; all uses changed.
4064 Check for integer overflow.
4065 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4066 since it's now a duplicate of the other. This is more of
4067 a character than a buffer op, so better that it's in character.c.
4068 * fns.c, print.c: Adjust to above changes.
4069
4070 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4071
4072 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4073
4074 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4075
4076 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4077 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4078 (x_clipboard_manager_save): Now static.
4079 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4080
4081 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4082 (crypto_hash_function): Now static.
4083 Fix pointer signedness problems. Avoid unnecessary initializations.
4084
4085 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4086
4087 * termhooks.h (Vselection_alist): Make it terminal-local.
4088
4089 * terminal.c (create_terminal): Initialize it.
4090
4091 * xselect.c: Support for clipboard managers.
4092 (Vselection_alist): Move to termhooks.h as terminal-local var.
4093 (LOCAL_SELECTION): New macro.
4094 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4095 (symbol_to_x_atom): Remove gratuitous arg.
4096 (x_handle_selection_request, lisp_data_to_selection_data)
4097 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4098 (x_own_selection, x_get_local_selection, x_convert_selection):
4099 New arg, specifying work frame. Use terminal-local Vselection_alist.
4100 (some_frame_on_display): Delete unused function.
4101 (Fx_own_selection_internal, Fx_get_selection_internal)
4102 (Fx_disown_selection_internal, Fx_selection_owner_p)
4103 (Fx_selection_exists_p): New optional frame arg.
4104 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4105 (x_handle_selection_clear): Don't treat other terminals with the
4106 same keyboard specially. Use the terminal-local Vselection_alist.
4107 (x_clear_frame_selections): Use Frun_hook_with_args.
4108
4109 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4110
4111 * xterm.h: Add support for those atoms.
4112
4113 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4114
4115 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4116 (converted_selections, conversion_fail_tag): New global variables.
4117 (x_selection_request_lisp_error): Free the above.
4118 (x_get_local_selection): Remove unnecessary code.
4119 (x_reply_selection_request): Args changed; handle arbitrary array
4120 of converted selections stored in converted_selections.
4121 Separate the XChangeProperty and SelectionNotify steps.
4122 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4123 (x_convert_selection): New function.
4124 (x_handle_selection_event): Simplify.
4125 (x_get_foreign_selection): Don't ignore incoming requests while
4126 waiting for an answer; this will fail when we implement
4127 SAVE_TARGETS, and seems unnecessary anyway.
4128 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4129 (Vx_sent_selection_functions): Doc fix.
4130
4131 2011-05-26 Leo Liu <sdl.web@gmail.com>
4132
4133 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4134
4135 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4136
4137 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4138
4139 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4140 for fringe update if it has periodic bitmap.
4141 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4142 and fringe_bitmap_periodic_p.
4143
4144 * fringe.c (get_fringe_bitmap_data): New function.
4145 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4146 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4147 row. Mark glyph row for fringe update if periodicity changed.
4148
4149 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4150 for fringe update unless it has periodic bitmap.
4151
4152 2011-05-25 Kenichi Handa <handa@m17n.org>
4153
4154 * xdisp.c (get_next_display_element): Set correct it->face_id for
4155 a static composition.
4156
4157 2011-05-24 Leo Liu <sdl.web@gmail.com>
4158
4159 * deps.mk (fns.o):
4160 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4161
4162 * fns.c (crypto_hash_function, Fsha1): New function.
4163 (Fmd5): Use crypto_hash_function.
4164 (syms_of_fns): Add Ssha1.
4165
4166 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4167
4168 * gnutls.c: Remove unused macros.
4169 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4170 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4171 Remove macros that are defined and never used.
4172 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4173
4174 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4175
4176 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4177 (Fx_get_selection_internal): Minor cleanup.
4178 (Fx_own_selection_internal): Rename arguments for consistency with
4179 select.el.
4180
4181 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4182
4183 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4184
4185 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4186
4187 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4188
4189 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4190
4191 * dispnew.c (scrolling_window): Don't exclude the case that the
4192 last enabled row in the desired matrix touches the bottom boundary.
4193
4194 2011-05-21 Glenn Morris <rgm@gnu.org>
4195
4196 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4197 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4198 and add some more files.
4199
4200 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4201
4202 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4203 report_file_error introduced by the change from 2011-05-07.
4204
4205 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4206
4207 * systime.h (Time): Define only if emacs is defined.
4208 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4209 where the include path doesn't have X11/X.h by default. See
4210 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4211
4212 2011-05-20 Kenichi Handa <handa@m17n.org>
4213
4214 * composite.c (find_automatic_composition): Fix previous change.
4215
4216 2011-05-20 Glenn Morris <rgm@gnu.org>
4217
4218 * lisp.mk: New file, split from Makefile.in.
4219 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4220 (shortlisp): Remove.
4221 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4222
4223 2011-05-19 Glenn Morris <rgm@gnu.org>
4224
4225 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4226 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4227 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4228 (lisp): Set the order to that of loadup.el.
4229 (shortlisp): Make it a copy of $lisp.
4230 (SOME_MACHINE_LISP): Remove.
4231 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4232 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4233
4234 2011-05-18 Kenichi Handa <handa@m17n.org>
4235
4236 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4237 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4238 (find_automatic_composition): Mostly rewrite for efficiency.
4239
4240 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4241
4242 * makefile.w32-in: Update dependencies.
4243
4244 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4245
4246 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4247 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4248
4249 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4250
4251 Fix some integer overflow issues, such as string length overflow.
4252
4253 * insdel.c (count_size_as_multibyte): Check for string overflow.
4254
4255 * character.c (lisp_string_width): Check for string overflow.
4256 Use EMACS_INT, not int, for string indexes and lengths; in
4257 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4258 the resulting string length overflows an EMACS_INT; instead,
4259 report a string overflow if no precision given. When checking for
4260 precision exhaustion, use a check that cannot possibly have
4261 integer overflow. (Bug#8675)
4262 * character.h (lisp_string_width): Adjust to new signature.
4263
4264 * alloc.c (string_overflow): New function.
4265 (Fmake_string): Use it. This doesn't change behavior, but saves
4266 a few bytes and will simplify future changes.
4267 * character.c (string_escape_byte8): Likewise.
4268 * lisp.h (string_overflow): New decl.
4269
4270 Fixups, following up to the user-interface timestamp change.
4271 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4272 for UI timestamps, instead of unsigned long.
4273 * msdos.c (mouse_get_pos): Likewise.
4274 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4275 * w32gui.h (Time): Define by including "systime.h" rather than by
4276 declaring it ourselves. (Bug#8664)
4277
4278 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4279 * image.c (clear_image_cache): Likewise.
4280
4281 * term.c (term_mouse_position): Don't assume time_t wraparound.
4282
4283 Be more systematic about user-interface timestamps.
4284 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4285 and sometimes 'EMACS_UINT', to represent these timestamps.
4286 This change causes it to use 'Time' uniformly, as that's what X uses.
4287 This makes the code easier to follow, and makes it easier to catch
4288 integer overflow bugs such as Bug#8664.
4289 * frame.c (Fmouse_position, Fmouse_pixel_position):
4290 Use Time, not unsigned long, for user-interface timestamps.
4291 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4292 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4293 * keyboard.h (last_event_timestamp): Likewise.
4294 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4295 * menu.h (xmenu_show): Likewise.
4296 * term.c (term_mouse_position): Likewise.
4297 * termhooks.h (struct input_event.timestamp): Likewise.
4298 (struct terminal.mouse_position_hook): Likewise.
4299 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4300 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4301 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4302 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4303 what it was before.
4304 * menu.h, termhooks.h: Include "systime.h", for Time.
4305
4306 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4307 Don't assume that the difference between two unsigned long values
4308 can fit into an integer. At this point, we know button_down_time
4309 <= event->timestamp, so the difference must be nonnegative, so
4310 there's no need to cast the result if double-click-time is
4311 nonnegative, as it should be; check that it's nonnegative, just in
4312 case. This bug is triggered when events are more than 2**31 ms
4313 apart (about 25 days). (Bug#8664)
4314
4315 * xselect.c (last_event_timestamp): Remove duplicate decl.
4316 (x_own_selection): Remove needless cast to unsigned long.
4317
4318 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4319 that always fit in int. Use a sentinel instead of a counter, to
4320 avoid a temp and to allay GCC's concerns about possible int overflow.
4321 * frame.h (struct frame): Use int for menu_bar_items_used
4322 instead of EMACS_INT, since it always fits in int.
4323
4324 * menu.c (grow_menu_items): Check for int overflow.
4325
4326 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4327
4328 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4329 Before, the code was not consistent. These values cannot exceed
4330 2**31 - 1 so there's no need to make them unsigned.
4331 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4332 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4333 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4334 as modifiers.
4335 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4336
4337 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4338 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4339 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4340 presumably because the widths might not match.
4341
4342 * window.c (size_window): Avoid needless test at loop start.
4343
4344 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4345
4346 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4347
4348 2011-05-12 Drew Adams <drew.adams@oracle.com>
4349
4350 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4351
4352 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4353
4354 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4355 `width' to `bar_area_x' and `bar_area_width', respectively.
4356 (x_scroll_run): Take account of fringe background extension.
4357
4358 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4359 Rename local vars `left' and `width' to `bar_area_x' and
4360 `bar_area_width', respectively.
4361 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4362 background extension.
4363
4364 2011-05-10 Jim Meyering <meyering@redhat.com>
4365
4366 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4367
4368 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4369
4370 * image.c (Finit_image_library): Return t for built-in image types,
4371 like pbm and xbm. (Bug#8640)
4372
4373 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4374
4375 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4376
4377 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4378
4379 * w32console.c (Fset_screen_color): Doc fix.
4380 (Fget_screen_color): New function.
4381 (syms_of_ntterm): Defsubr it.
4382
4383 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4384 unlink the temporary file if Fcall_process didn't create it in the
4385 first place.
4386 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4387 child process will be redirected to a file specified with `:file'.
4388 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4389 cue to call_process_cleanup not to close that handle.
4390
4391 2011-05-07 Ben Key <bkey76@gmail.com>
4392
4393 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4394 one of two shell specific rules, either bootstrap-temacs-CMD or
4395 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4396 to the previous implementation of the bootstrap-temacs rule.
4397 The bootstrap-temacs-CMD rule is similar to the previous
4398 implementation of the bootstrap-temacs rule except that it
4399 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4400 variable.
4401
4402 These changes, along with some changes to nt/configure.bat,
4403 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4404 earlier fix to add support for --cflags and --ldflags options
4405 that include quotes so that it works whether make uses cmd or
4406 sh as the shell.
4407
4408 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4409
4410 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4411 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4412 is a constant.
4413 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4414 a string. Handle both cases.
4415 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4416 (Fdbus_register_method): Use Qinvalid_function.
4417
4418 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4419
4420 * makefile.w32-in: Update dependencies.
4421 (LISP_H): Add inttypes.h and stdin.h.
4422 (PROCESS_H): Add unistd.h.
4423
4424 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4425
4426 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4427 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4428
4429 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4430
4431 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4432
4433 * term.c (vfatal): Remove stray call to va_end.
4434 It's not needed and the C Standard doesn't allow it here anyway.
4435
4436 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4437 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4438
4439 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4440 bytes.
4441
4442 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4443
4444 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4445
4446 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4447
4448 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4449
4450 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4451
4452 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4453 * charset.c (Fdefine_charset_internal): Don't initialize
4454 charset.code_space[15]. The value was garbage, on hosts with
4455 32-bit int (Bug#8600).
4456
4457 * lread.c (read_integer): Be more consistent with string-to-number.
4458 Use string_to_number to do the actual conversion; this avoids
4459 rounding errors and fixes some other screwups. Without this fix,
4460 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4461 (digit_to_number): Move earlier, for benefit of read_integer.
4462 Return -1 if the digit is out of range for the base, -2 if it is
4463 not a digit in any supported base. (Bug#8602)
4464
4465 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4466
4467 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4468 to match comment at start of function. This also removes a
4469 GCC warning about overflow in a 32+64-bit port.
4470
4471 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4472
4473 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4474 Reported by Stefan Monnier in
4475 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4476 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4477 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4478
4479 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4480 (EMACS_UINTPTR): Likewise, with uintptr_t.
4481
4482 * lisp.h: Prefer 64-bit EMACS_INT if available.
4483 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4484 on 32-bit hosts that have 64-bit int, so that they can access
4485 large files.
4486 However, temporarily disable this change unless the temporary
4487 symbol WIDE_EMACS_INT is defined.
4488
4489 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4490
4491 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4492 This removes an assumption that EMACS_INT and long are the same
4493 width as pointers. The assumption is true for Emacs porting targets
4494 now, but we want to make other targets possible.
4495 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4496 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4497 In the rest of the code, change types of integers that hold casted
4498 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4499 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4500 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4501 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4502 No need to cast type when ORing.
4503 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4504 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4505 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4506 assume EMACS_INT is the same width as char *.
4507 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4508 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4509 Remove no-longer-needed casts.
4510 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4511 (xg_tool_bar_help_callback, xg_make_tool_item):
4512 Use EMACS_INTPTR to hold an integer
4513 that will be cast to void *; this can avoid a GCC warning
4514 if EMACS_INT is not the same width as void *.
4515 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4516 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4517 (current_message_1, set_message_1):
4518 Use a local to convert to proper width without a cast.
4519 * xmenu.c (dialog_selection_callback): Likewise.
4520
4521 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4522 Also, don't assume VALBITS / RAND_BITS is less than 5,
4523 and don't rely on undefined behavior when shifting a 1 left into
4524 the sign bit.
4525 * lisp.h (get_random): Change signature to match.
4526
4527 * lread.c (hash_string): Use size_t, not int, for hash computation.
4528 Normally we prefer signed values; but hashing is special, because
4529 it's better to use unsigned division on hash table sizes so that
4530 the remainder is nonnegative. Also, size_t is the natural width
4531 for hashing into memory. The previous code used 'int', which doesn't
4532 retain enough info to hash well into very large tables.
4533 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4534
4535 * dbusbind.c: Don't possibly lose pointer info when converting.
4536 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4537 Use XPNTR rather than XHASH, so that the high-order bits of
4538 the pointer aren't lost when converting through void *.
4539
4540 * eval.c (Fautoload): Don't double-shift a pointer.
4541
4542 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4543
4544 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4545
4546 * gnutls.c (DEF_GNUTLS_FN):
4547 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4548
4549 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4550
4551 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4552 marker. (Bug#8610)
4553
4554 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4555
4556 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4557 New version that can reserve upto 2GB of heap space.
4558
4559 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4560
4561 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4562
4563 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4564
4565 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4566 `gnutls_certificate_set_x509_key_file'.
4567
4568 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4569
4570 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4571 Update dependencies.
4572
4573 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4574
4575 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4576 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4577 Remove unused parameter `fildes'.
4578 * process.c (read_process_output, send_process): Don't pass it.
4579
4580 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4581
4582 Fix previous change: the library cache is defined in w32.c.
4583 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4584 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4585
4586 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4587
4588 Implement dynamic loading of GnuTLS on Windows.
4589
4590 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4591 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4592 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4593 Declare.
4594
4595 * gnutls.c (Qgnutls_dll): Define.
4596 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4597 (gnutls_*): Declare function pointers.
4598 (init_gnutls_functions): New function to initialize function pointers.
4599 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4600 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4601 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4602 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4603 (emacs_gnutls_write, emacs_gnutls_read)
4604 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4605 (Fgnutls_available_p): New function.
4606 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4607 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4608 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4609
4610 * image.c: Include w32.h.
4611 (Vimage_type_cache): Delete.
4612 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4613 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4614 (w32_delayed_load): Move to w32.c.
4615
4616 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4617
4618 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4619 (w32_delayed_load): Move from image.c. When loading a library, record
4620 its filename in the :loaded-from property of the library id.
4621 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4622 Initialize and staticpro them.
4623 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4624
4625 * process.c: Include lisp.h before w32.h, not after.
4626 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4627 instead of gnutls_record_check_pending.
4628
4629 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4630
4631 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4632
4633 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4634 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4635 as passed in.
4636
4637 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4638
4639 * xterm.c (x_set_frame_alpha): Do not set property on anything
4640 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4641
4642 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4643
4644 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4645
4646 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4647
4648 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4649 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4650 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4651 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4652 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4653 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4654 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4655 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4656 (Qgnutls_bootprop_callbacks_verify): Make static.
4657
4658 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4659
4660 * callproc.c: Indentation fixup.
4661
4662 * sysdep.c (wait_for_termination_1): Make static.
4663 (wait_for_termination, interruptible_wait_for_termination):
4664 Move after wait_for_termination_1.
4665
4666 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4667
4668 * sysdep.c (interruptible_wait_for_termination): New function
4669 which is like wait_for_termination, but allows keyboard
4670 interruptions.
4671
4672 * callproc.c (Fcall_process): Add (:file "file") as an option for
4673 the STDOUT buffer.
4674 (Fcall_process_region): Ditto.
4675
4676 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4677
4678 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4679 rather than `XVECTOR (FOO)->size'.
4680
4681 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4682 inttypes.h, as a gnulib replacement is used if it not available in
4683 system headers.
4684
4685 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4686
4687 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4688 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4689 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4690
4691 * coding.c (coding_alloc_by_realloc): Error out if destination
4692 will grow beyond MOST_POSITIVE_FIXNUM.
4693 (decode_coding_emacs_mule): Abort if there isn't enough place in
4694 charbuf for the composition carryover bytes. Reserve an extra
4695 space for up to 2 characters produced in a loop.
4696 (decode_coding_iso_2022): Abort if there isn't enough place in
4697 charbuf for the composition carryover bytes.
4698
4699 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4700
4701 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4702 aborting when %lld or %lll format is passed.
4703 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4704 %llo or %llx format is passed. (Bug#8545)
4705
4706 * window.c (window_scroll_line_based): Use a marker instead of
4707 simple variables to record original value of point. (Bug#7952)
4708
4709 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4710 produced by %s or %c overflows available buffer space. (Bug#8545)
4711
4712 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4713
4714 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4715 (SIZE_MAX): Move defn after all includes, as they might #define it.
4716
4717 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4718
4719 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4720
4721 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4722
4723 * keyboard.c (Qdelayed_warnings_hook): Define.
4724 (command_loop_1): Run `delayed-warnings-hook'
4725 if Vdelayed_warnings_list is non-nil.
4726 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4727 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4728
4729 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4730
4731 * doprnt.c (doprnt): Don't return value smaller than the buffer
4732 size if the message was truncated. (Bug#8545).
4733
4734 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4735
4736 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4737 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4738
4739 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4740
4741 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4742
4743 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4744
4745 * makefile.w32-in: Update dependencies.
4746
4747 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4748
4749 Improve `doprnt' and its usage. (Bug#8545)
4750 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4751 `format_end'. Remove support for %l as a conversion specifier.
4752 Don't use xrealloc. Improve diagnostics when the %l size modifier
4753 is used. Update the commentary.
4754
4755 * eval.c (verror): Simplify calculation of size_t.
4756
4757 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4758 messages.
4759
4760 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4761
4762 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4763 change.
4764
4765 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4766
4767 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4768 This makes this file independent of the recent pseudovector change.
4769
4770 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4771
4772 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4773
4774 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4775 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4776 Remove unused local.
4777 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4778
4779 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4780 GCC 4.6.0 optimizes based on type-based alias analysis.
4781 For example, if b is of type struct buffer * and v of type struct
4782 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4783 != &v->size, and therefore "v->size = 1; b->size = 2; return
4784 v->size;" must therefore return 1. This assumption is incorrect
4785 for Emacs, since it type-puns struct Lisp_Vector * with many other
4786 types. To fix this problem, this patch adds a new type struct
4787 vectorlike_header that documents the constraints on layout of vectors
4788 and pseudovectors, and helps optimizing compilers not get fooled
4789 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4790 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4791 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4792 the size member.
4793 (XSETPVECTYPE): Rewrite in terms of new macro.
4794 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4795 This is a bit clearer, and further avoids the possibility of
4796 undesirable aliasing.
4797 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4798 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4799 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4800 since Lisp_Subr is a special case (no "next" field).
4801 (ASIZE): Now uses header.size rather than size.
4802 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4803 to avoid the hassle of writing XVECTOR (foo)->header.size.
4804 (struct vectorlike_header): New type.
4805 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4806 object, to help avoid aliasing.
4807 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4808 (SUBRP): Likewise, since Lisp_Subr is a special case.
4809 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4810 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4811 (struct Lisp_Hash_Table): Combine first two members into a single
4812 struct vectorlike_header member. All uses of "size" and "next" members
4813 changed to be "header.size" and "header.next".
4814 * buffer.h (struct buffer): Likewise.
4815 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4816 * frame.h (struct frame): Likewise.
4817 * process.h (struct Lisp_Process): Likewise.
4818 * termhooks.h (struct terminal): Likewise.
4819 * window.c (struct save_window_data, struct saved_window): Likewise.
4820 * window.h (struct window): Likewise.
4821 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4822 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4823 * buffer.c (init_buffer_once): Likewise.
4824 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4825 special case.
4826 * process.c (Fformat_network_address): Use local var for size,
4827 for brevity.
4828
4829 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4830
4831 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4832 * data.c (atof): Remove decl; no longer used or needed.
4833 (digit_to_number): Move to lread.c.
4834 (Fstring_to_number): Use new string_to_number function, to be
4835 consistent with how the Lisp reader treats infinities and NaNs.
4836 Do not assume that floating-point numbers represent EMACS_INT
4837 without losing information; this is not true on most 64-bit hosts.
4838 Avoid double-rounding errors, by insisting on integers when
4839 parsing non-base-10 numbers, as the documentation specifies.
4840 * lisp.h (string_to_number): New decl, replacing ...
4841 (isfloat_string): Remove.
4842 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4843 (read1): Do not accept +. and -. as integers; this
4844 appears to have been a coding error. Similarly, do not accept
4845 strings like +-1e0 as floating point numbers. Do not report
4846 overflow for integer overflows unless the base is not 10 which
4847 means we have no simple and reliable way to continue.
4848 Break out the floating-point parsing into a new
4849 function string_to_number, so that Fstring_to_number parses
4850 floating point numbers consistently with the Lisp reader.
4851 (digit_to_number): Move here from data.c. Make it static inline.
4852 (E_CHAR, EXP_INT): Remove, replacing with ...
4853 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4854 (string_to_number): New function, replacing isfloat_string.
4855 This function checks for valid syntax and produces the resulting
4856 Lisp float number too. Rework it so that string-to-number
4857 no longer mishandles examples like "1.0e+". Use strtoumax,
4858 so that overflow for non-base-10 numbers is reported only when
4859 there's no portable and simple way to convert to floating point.
4860
4861 * textprop.c (set_text_properties_1): Rewrite for clarity,
4862 and to avoid GCC warning about integer overflow.
4863
4864 * intervals.h (struct interval): Use EMACS_INT for members
4865 where EMACS_UINT might cause problems. See
4866 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4867 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4868 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4869 All uses changed.
4870 (offset_intervals): Tell GCC not to worry about length overflow
4871 when negating a negative length.
4872
4873 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4874 (overrun_check_free): Likewise.
4875
4876 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4877 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4878 word size.
4879
4880 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4881 (gnutls_make_error): Rename local to avoid shadowing.
4882 (gnutls_emacs_global_deinit): ifdef out; not used.
4883 (Fgnutls_boot): Use const for pointer to readonly storage.
4884 Comment out unused local. Fix pointer signedness problems.
4885
4886 * lread.c (openp): Don't stuff size_t into an 'int'.
4887 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4888 about possible signed overflow.
4889
4890 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4891 (GDK_KEY_g): Don't define if already defined.
4892 (xg_prepare_tooltip): Avoid pointer signedness problem.
4893 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4894
4895 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4896 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4897
4898 * xfns.c (Fx_window_property): Simplify a bit,
4899 to make a bit faster and to avoid GCC 4.6.0 warning.
4900 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4901
4902 * fns.c (internal_equal): Don't assume size_t fits in int.
4903
4904 * alloc.c (compact_small_strings): Tighten assertion a little.
4905
4906 Replace pEd with more-general pI, and fix some printf arg casts.
4907 * lisp.h (pI): New macro, generalizing old pEd macro to other
4908 conversion specifiers. For example, use "...%"pI"d..." rather
4909 than "...%"pEd"...".
4910 (pEd): Remove. All uses replaced with similar uses of pI.
4911 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4912 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4913 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4914 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4915 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4916 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4917 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4918 64-bit hosts.
4919 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4920 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4921 * print.c (safe_debug_print, print_object): Likewise.
4922 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4923 to int.
4924 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4925 avoiding the 0 flag, which is not portable.
4926 * process.c (Fmake_network_process): Use pI to avoid cast.
4927 * region-cache.c (pp_cache): Likewise.
4928 * xdisp.c (decode_mode_spec): Likewise.
4929 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4930 behavior on 64-bit hosts with printf arg.
4931 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4932 (x_stop_queuing_selection_requests): Likewise.
4933 (x_get_window_property): Don't truncate byte count to an 'int'
4934 when tracing.
4935
4936 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4937 here, since it parses constructs like leading '-' and spaces,
4938 which are not wanted; and it overflows with large numbers.
4939 Instead, simply match F[0-9]+, which is what is wanted anyway.
4940
4941 * alloc.c: Remove unportable assumptions about struct layout.
4942 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4943 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4944 (allocate_vectorlike, make_pure_vector): Use the new macros,
4945 plus offsetof, to remove unportable assumptions about struct layout.
4946 These assumptions hold on all porting targets that I know of, but
4947 they are not guaranteed, they're easy to remove, and removing them
4948 makes further changes easier.
4949
4950 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4951 This doesn't fix a bug but makes the code clearer.
4952 (string_overrun_cookie): Now const. Use initializers that
4953 don't formally overflow signed char, to avoid warnings.
4954 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4955 can cause Emacs to crash when string overrun checking is enabled.
4956 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4957 multiple of sizeof (EMACS_INT); it need not be, if
4958 alignof(EMACS_INT) < sizeof (EMACS_INT).
4959 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4960
4961 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4962
4963 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4964
4965 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4966
4967 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4968 supposed to be handshaking. (Bug#8556)
4969 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4970
4971 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4972
4973 * lisp.h (Qdebug): List symbol.
4974 * eval.c (Qdebug): Restore global linkage.
4975 * keyboard.c (debug-on-event): New variable.
4976 (handle_user_signal): Break into debugger when debug-on-event
4977 matches the current signal symbol.
4978
4979 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4980
4981 * alloc.c (check_sblock, check_string_bytes)
4982 (check_string_free_list): Convert to standard C.
4983
4984 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4985
4986 * w32.c (emacs_gnutls_push): Fix typo.
4987
4988 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4989
4990 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4991 "cast to pointer from integer of different size".
4992
4993 Improve doprnt and its use in verror. (Bug#8545)
4994 * doprnt.c (doprnt): Document the set of format control sequences
4995 supported by the function. Use SAFE_ALLOCA instead of always
4996 using `alloca'.
4997
4998 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4999 is one byte too soon. Don't use xrealloc; instead xfree and
5000 xmalloc anew.
5001
5002 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5003
5004 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5005 callbacks stage.
5006
5007 * gnutls.c: Renamed global_initialized to
5008 gnutls_global_initialized. Added internals for the
5009 :verify-hostname-error, :verify-error, and :verify-flags
5010 parameters of `gnutls-boot' and documented those parameters in the
5011 docstring. Start callback support.
5012 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5013 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5014 on error. Return error code.
5015 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5016 (emacs_gnutls_read): Likewise.
5017 (Fgnutls_boot): Return handshake error code.
5018 (emacs_gnutls_handle_error): New function.
5019 (wsaerror_to_errno): Likewise.
5020
5021 * w32.h (emacs_gnutls_pull): Add prototype.
5022 (emacs_gnutls_push): Likewise.
5023
5024 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5025 (emacs_gnutls_push): Likewise.
5026
5027 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5028
5029 * process.c (wait_reading_process_output): Check if GnuTLS
5030 buffered some data internally if no FDs are set for TLS
5031 connections.
5032
5033 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5034 (LIBS): Link to USER_LIBS.
5035 ($(BLD)/gnutls.$(0)): New target.
5036
5037 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5038
5039 * xdisp.c (handle_single_display_spec): Rename the
5040 display_replaced_before_p argument into display_replaced_p, to
5041 make it consistent with the commentary. Fix typos in the
5042 commentary.
5043
5044 * textprop.c (syms_of_textprop): Remove dead code.
5045 (copy_text_properties): Delete obsolete commentary about an
5046 interface that was deleted long ago. Fix typos in the description
5047 of arguments.
5048
5049 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5050 to changes in oldXMenu/XMenu.h from 2011-04-16.
5051 <menu_help_message, prev_menu_help_message>: Constify.
5052 (IT_menu_make_room): menu->help_text is now `const char **';
5053 adjust.
5054
5055 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5056 to changes in oldXMenu/XMenu.h from 2011-04-16.
5057 (struct XMenu): Declare `help_text' `const char **'.
5058
5059 * xfaces.c <Qunspecified>: Make extern again.
5060
5061 * syntax.c: Include sys/types.h before including regex.h, as
5062 required by Posix.
5063
5064 * doc.c (get_doc_string): Improve the format passed to `error'.
5065
5066 * doprnt.c (doprnt): Improve commentary.
5067
5068 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5069
5070 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5071 them with etags.
5072
5073 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5074 changes in globals.h immediately force recompilation.
5075 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5076 $(CURDIR)/s/ms-w32.h.
5077 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5078
5079 * character.c (Fchar_direction): Function deleted.
5080 (syms_of_character): Don't defsubr it.
5081 <char-direction-table>: Deleted.
5082
5083 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5084
5085 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5086 * doprnt.c: Include limits.h.
5087 (SIZE_MAX): New macro.
5088 (doprnt): Return a size_t value. 2nd arg is now size_t.
5089 Many local variables are now size_t instead of int or unsigned.
5090 Improve overflow protection. Support `l' modifier for integer
5091 conversions. Support %l conversion. Don't assume an EMACS_INT
5092 argument for integer conversions and for %c.
5093
5094 * lisp.h (doprnt): Restore prototype.
5095
5096 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5097 $(SRC)/character.h.
5098
5099 * Makefile.in (base_obj): Add back doprnt.o.
5100
5101 * deps.mk (doprnt.o): Add back prerequisites.
5102 (callint.o): Depend on character.h.
5103
5104 * eval.c (internal_lisp_condition_case): Include the handler
5105 representation in the error message.
5106 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5107 when breaking from the loop.
5108
5109 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5110
5111 * callint.c (Fcall_interactively): When displaying error message
5112 about invalid control letter, pass the character's codepoint, not
5113 a pointer to its multibyte form. Improve display of the character
5114 in octal and display also its hex code.
5115
5116 * character.c (char_string): Use %x to display the (unsigned)
5117 codepoint of an invalid character, to avoid displaying a bogus
5118 negative value.
5119
5120 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5121 `error', not SYMBOL_NAME itself.
5122
5123 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5124 character arguments to `error'.
5125
5126 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5127 to `error' in error message about FINAL_CHAR argument. Make sure
5128 FINAL_CHAR is a character, and use %c when it is passed as
5129 argument to `error'.
5130
5131 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5132
5133 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5134
5135 * w32.c: Include <time.h>.
5136 (sys_localtime): New function.
5137
5138 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5139
5140 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5141
5142 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5143
5144 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5145
5146 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5147 zombies (Bug#8467).
5148
5149 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5150
5151 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5152 gl_state.e_property when gl_state.object is Qt.
5153
5154 * insdel.c (make_gap_larger): Remove limitation of buffer size
5155 to <= INT_MAX.
5156
5157 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5158
5159 * xdisp.c (lookup_glyphless_char_display)
5160 (produce_glyphless_glyph): Handle cons cell entry in
5161 glyphless-char-display.
5162 (Vglyphless_char_display): Document it.
5163
5164 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5165 glyphless-char-display.
5166
5167 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5168
5169 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5170
5171 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5172
5173 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5174 definition for no-X builds.
5175
5176 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5177
5178 Static checks with GCC 4.6.0 and non-default toolkits.
5179
5180 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5181
5182 * process.c (keyboard_bit_set): Define only if SIGIO.
5183 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5184 (send_process): Repair possible setjmp clobbering.
5185
5186 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5187
5188 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5189
5190 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5191
5192 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5193 Define only if needed.
5194
5195 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5196 by pacifying GCC about it. Maybe it's time to retire it?
5197 * xfaces.c (USG, __TIMEVAL__): Likewise.
5198
5199 * dispextern.h (struct redisplay_interface): Rename param
5200 to avoid shadowing.
5201 * termhooks.h (struct terminal): Likewise.
5202 * xterm.c (xembed_send_message): Likewise.
5203
5204 * insdel.c (make_gap_smaller): Define only if
5205 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5206
5207 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5208 it.
5209
5210 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5211 so that we aren't warned about unused symbols.
5212
5213 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5214
5215 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5216
5217 * xfns.c (x_real_positions): Mark locals as initialized.
5218
5219 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5220
5221 * xterm.c: Fix problems found by static analysis with other toolkits.
5222 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5223 (x_dispatch_event): Declare static if USE_GTK, and
5224 define if USE_GTK || USE_X_TOOLKIT.
5225 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5226 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5227 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5228 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5229
5230 * xmenu.c (menu_help_callback): Pointer type fixes.
5231 Use const pointers when pointing at readonly data. Avoid pointer
5232 signedness clashes.
5233 (FALSE): Remove unused macro.
5234 (update_frame_menubar): Remove unused decl.
5235
5236 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5237
5238 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5239 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5240 (single_menu_item): Rename local to avoid shadowing.
5241
5242 * keyboard.c (make_lispy_event): Remove unused local var.
5243
5244 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5245 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5246
5247 * bitmaps: Change bitmaps from unsigned char back to the X11
5248 compatible char. Avoid the old compiler warnings about
5249 out-of-range initializers by using, for example, '\xab' rather
5250 than 0xab.
5251
5252 * xgselect.c (xgselect_initialize): Check vs interface
5253 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5254
5255 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5256
5257 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5258 to read-only memory.
5259
5260 * fns.c (vector): Remove; this old hack is no longer needed.
5261
5262 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5263 Remove unused var.
5264 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5265
5266 * xrdb.c (x_load_resources): Omit unused local.
5267
5268 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5269 (x_window): Rename locals to avoid shadowing.
5270 (USG): Use the kludged USG macro, to pacify gcc.
5271
5272 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5273 (x_term_init): Remove local to avoid shadowing.
5274
5275 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5276
5277 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5278 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5279
5280 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5281
5282 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5283
5284 Fix regex.c, syntax.c and friends for buffers > 2GB.
5285 * syntax.h (struct gl_state_s): Declare character position members
5286 EMACS_INT.
5287
5288 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5289
5290 * textprop.c (verify_interval_modification, interval_of):
5291 Declare arguments EMACS_INT.
5292
5293 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5294 EMACS_INT.
5295
5296 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5297
5298 * indent.c (Fvertical_motion): Local variable it_start is now
5299 EMACS_INT.
5300
5301 * regex.c (re_match, re_match_2, re_match_2_internal)
5302 (bcmp_translate, regcomp, regexec, print_double_string)
5303 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5304 (re_compile_pattern, re_exec): Declare arguments and local
5305 variables `size_t' and `ssize_t' and return values `regoff_t', as
5306 appropriate.
5307 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5308 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5309 <compile_stack_type>: `size' and `avail' are now `size_t'.
5310
5311 * regex.h <regoff_t>: Use ssize_t, not int.
5312 (re_search, re_search_2, re_match, re_match_2): Arguments that
5313 specify buffer/string position and length are now ssize_t and
5314 size_t. Return type is regoff_t.
5315
5316 2011-04-16 Ben Key <bkey76@gmail.com>
5317
5318 * nsfont.m: Fixed bugs in ns_get_family and
5319 ns_descriptor_to_entity that were caused by using free to
5320 deallocate memory blocks that were allocated by xmalloc (via
5321 xstrdup). This caused Emacs to crash when compiled with
5322 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5323 --enable-checking=xmallocoverrun). xfree is now used to
5324 deallocate these memory blocks.
5325
5326 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5327
5328 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5329
5330 emacs_write: Accept and return EMACS_INT for sizes.
5331 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5332 et seq.
5333 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5334 Accept and return EMACS_INT.
5335 (emacs_gnutls_write): Return the number of bytes written on
5336 partial writes.
5337 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5338 (emacs_read, emacs_write): Remove check for negative size, as the
5339 Emacs source code has been audited now.
5340 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5341 (emacs_read, emacs_write): Use it.
5342 * process.c (send_process): Adjust to the new signatures of
5343 emacs_write and emacs_gnutls_write. Do not attempt to store
5344 a byte offset into an 'int'; it might overflow.
5345 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5346
5347 * sound.c: Don't assume sizes fit in 'int'.
5348 (struct sound_device.period_size, alsa_period_size):
5349 Return EMACS_INT, not int.
5350 (struct sound_device.write, vox_write, alsa_write):
5351 Accept EMACS_INT, not int.
5352 (wav_play, au_play): Use EMACS_INT to store sizes and to
5353 record read return values.
5354
5355 2011-04-15 Ben Key <bkey76@gmail.com>
5356
5357 * keyboard.c (Qundefined): Don't declare static since it is used
5358 in nsfns.m.
5359 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5360 static since they are used in nsfont.m.
5361
5362 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5363
5364 * process.c (Qprocessp): Don't declare static.
5365 * lisp.h (Qprocessp): Declare again.
5366
5367 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5368
5369 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5370
5371 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5372
5373 Improve C-level modularity by making more things 'static'.
5374
5375 Don't publish debugger-only interfaces to other modules.
5376 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5377 (verify_bytepos, count_markers): Move decls to the only modules
5378 that need them.
5379 * region-cache.h (pp_cache): Likewise.
5380 * window.h (check_all_windows): Likewise.
5381 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5382
5383 * sysdep.c (croak): Now static, if
5384 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5385 * syssignal.h (croak): Declare only if not static.
5386
5387 * alloc.c (refill_memory_reserve): Now static if
5388 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5389 * lisp.h (refill_memory_reserve): Declare only if not static.
5390
5391 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5392 Define only if USE_LUCID.
5393
5394 * xrdb.c (x_customization_string, x_rm_string): Now static.
5395
5396 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5397 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5398
5399 * xdisp.c (draw_row_with_mouse_face): Now static.
5400 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5401
5402 * window.h (check_all_windows): Mark externally visible.
5403
5404 * window.c (window_deletion_count): Now static.
5405
5406 * undo.c: Make symbols static if they're not exported.
5407 (last_undo_buffer, last_boundary_position, pending_boundary):
5408 Now static.
5409
5410 * textprop.c (interval_insert_behind_hooks): Now static.
5411 (interval_insert_in_front_hooks): Likewise.
5412
5413 * term.c: Make symbols static if they're not exported.
5414 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5415 (max_frame_lines, tty_set_terminal_modes):
5416 (tty_reset_terminal_modes, tty_turn_off_highlight):
5417 (get_tty_terminal): Now static.
5418 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5419 * termhooks.h (term_mouse_moveto): Do not declare if
5420 HAVE_WINDOW_SYSTEM.
5421 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5422 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5423
5424 * sysdep.c: Make symbols static if they're not exported.
5425 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5426 Now static.
5427 (sigprocmask_set, full_mask): Remove; unused.
5428 (wait_debugging): Mark as visible.
5429 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5430 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5431
5432 * syntax.c (syntax_temp): Define only if !__GNUC__.
5433
5434 * sound.c (current_sound_device, current_sound): Now static.
5435
5436 * search.c (searchbufs, searchbuf_head): Now static.
5437
5438 * scroll.c (scroll_cost): Remove; unused.
5439 * dispextern.h (scroll_cost): Remove decl.
5440
5441 * region-cache.h (pp_cache): Mark as externally visible.
5442
5443 * process.c: Make symbols static if they're not exported.
5444 (process_tick, update_tick, create_process, chan_process):
5445 (Vprocess_alist, proc_buffered_char, datagram_access):
5446 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5447 (deactivate_process): Mark defn as static, as well as decl.
5448 * lisp.h (create_process): Remove decl.
5449 * process.h (chan_process, Vprocess_alist): Remove decls.
5450
5451 * print.c: Make symbols static if they're not exported.
5452 (print_depth, new_backquote_output, being_printed, print_buffer):
5453 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5454 (print_interval, print_number_index, initial_stderr_stream):
5455 Now static.
5456 * lisp.h (Fprinc): Remove decl.
5457 (debug_output_compilation_hack): Mark as externally visible.
5458
5459 * sysdep.c (croak): Move decl from here to syssignal.h.
5460 * syssignal.h (croak): Put it here, so the API can be checked when
5461 'croak' is called from dissociate_if_controlling_tty.
5462
5463 * minibuf.c: Make symbols static if they're not exported.
5464 (minibuf_save_list, choose_minibuf_frame): Now static.
5465 * lisp.h (choose_minibuf_frame): Remove decl.
5466
5467 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5468
5469 * lread.c: Make symbols static if they're not exported.
5470 (read_objects, initial_obarray, oblookup_last_bucket_number):
5471 Now static.
5472 (make_symbol): Remove; unused.
5473 * lisp.h (initial_obarray, make_symbol): Remove decls.
5474
5475 * keyboard.c: Make symbols static if they're not exported.
5476 (single_kboard, recent_keys_index, total_keys, recent_keys):
5477 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5478 (this_single_command_key_start, echoing, last_auto_save):
5479 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5480 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5481 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5482 (Vlispy_mouse_stem, double_click_count):
5483 Now static.
5484 (force_auto_save_soon): Define only if SIGDANGER.
5485 (ignore_mouse_drag_p): Now static if
5486 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5487 (print_help): Remove; unused.
5488 (stop_character, last_timer_event): Mark as externally visible.
5489 * keyboard.h (ignore_mouse_drag_p): Declare only if
5490 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5491 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5492 * lisp.h (echoing): Remove decl.
5493 (force_auto_save_soon): Declare only if SIGDANGER.
5494 * xdisp.c (redisplay_window): Simplify code, to make it more
5495 obvious that ignore_mouse_drag_p is not accessed if !defined
5496 USE_GTK && !defined HAVE_NS.
5497
5498 * intervals.c: Make symbols static if they're not exported.
5499 (merge_properties_sticky, merge_interval_right, delete_interval):
5500 Now static.
5501 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5502
5503 * insdel.c: Make symbols static if they're not exported.
5504 However, leave prepare_to_modify_buffer alone. It's never
5505 called from outside this function, but that appears to be a bug.
5506 (combine_after_change_list, combine_after_change_buffer):
5507 (adjust_after_replace, signal_before_change): Now static.
5508 (adjust_after_replace_noundo): Remove; unused.
5509 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5510 (signal_before_change): Remove decls.
5511
5512 * indent.c (val_compute_motion, val_vmotion): Now static.
5513
5514 * image.c: Make symbols static if they're not exported.
5515 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5516 if USE_GTK.
5517 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5518 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5519
5520 * fringe.c (standard_bitmaps): Now static.
5521 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5522
5523 * frame.c: Make symbols static if they're not exported.
5524 (x_report_frame_params, make_terminal_frame): Now static.
5525 (get_frame_param): Now static, unless HAVE_NS.
5526 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5527 (x_get_resource_string): Remove; not used.
5528 * frame.h (make_terminal_frame, x_report_frame_params):
5529 (x_get_resource_string); Remove decls.
5530 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5531 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5532
5533 * font.c, fontset.c: Make symbols static if they're not exported.
5534 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5535 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5536 * font.c (font_close_object): Now static.
5537 * font.h (font_close_object): Remove.
5538 * fontset.c (FONTSET_OBJLIST): Remove.
5539 (free_realized_fontset) #if-0 the body, which does nothing.
5540 (face_suitable_for_char_p): #if-0, as it's never called.
5541 * fontset.h (face_suitable_for_char_p): Remove decl.
5542 * xfaces.c (face_at_string_position):
5543 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5544 since 0 is always ASCII.
5545
5546 * fns.c (weak_hash_tables): Now static.
5547
5548 * fileio.c: Make symbols static if they're not exported.
5549 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5550 (Vwrite_region_annotation_buffers): Now static.
5551
5552 * eval.c: Make symbols static if they're not exported.
5553 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5554 * lisp.h (backtrace_list): Remove decl.
5555
5556 * emacs.c: Make symbols static if they're not exported.
5557 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5558 (fatal_error_code, fatal_error_signal_hook, standard_args):
5559 Now static.
5560 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5561 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5562 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5563 * lisp.h (fatal_error_signal_hook): Remove decl.
5564 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5565
5566 * editfns.c: Move a (normally-unused) function to its only use.
5567 * editfns.c, lisp.h (get_operating_system_release): Remove.
5568 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5569 worth the hassle of breaking this out.
5570
5571 * xterm.c: Make symbols static if they're not exported.
5572 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5573 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5574 (x_destroy_window, x_delete_display):
5575 Now static.
5576 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5577 (x_mouse_leave): Remove; unused.
5578 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5579 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5580 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5581 Remove decls.
5582 (x_mouse_leave): Declare only if WINDOWSNT.
5583 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5584 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5585 USE_X_TOOLKIT.
5586
5587 * ftxfont.c: Make symbols static if they're not exported.
5588 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5589 HAVE_FREETYPE.
5590 * font.h (ftxfont_driver): Likewise.
5591
5592 * xfns.c: Make symbols static if they're not exported.
5593 (x_last_font_name, x_display_info_for_name):
5594 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5595 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5596 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5597 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5598 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5599 (last_show_tip_args): Now static.
5600 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5601 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5602 (x_screen_planes): Remove; unused.
5603 * dispextern.h (x_screen_planes): Remove decl.
5604
5605 * dispnew.c: Make symbols static if they're not exported.
5606 * dispextern.h (redraw_garbaged_frames, scrolling):
5607 (increment_row_positions): Remove.
5608 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5609 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5610 Now static.
5611 (redraw_garbaged_frames): Remove; unused.
5612
5613 * xfaces.c: Make symbols static if they're not exported.
5614 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5615 Remove decls.
5616 * xterm.h (defined_color): Remove decls.
5617 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5618 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5619 (menu_face_changed_default, defined_color, free_realized_face):
5620 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5621 (ascii_face_of_lisp_face): Remove; unused.
5622
5623 * xdisp.c: Make symbols static if they're not exported.
5624 * dispextern.h (scratch_glyph_row, window_box_edges):
5625 (glyph_to_pixel_coords, set_cursor_from_row):
5626 (get_next_display_element, set_iterator_to_next):
5627 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5628 (show_mouse_face): Remove decls
5629 * frame.h (message_buf_print): Likewise.
5630 * lisp.h (pop_message, set_message, check_point_in_composition):
5631 Likewise.
5632 * xterm.h (set_vertical_scroll_bar): Likewise.
5633 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5634 (message_buf_print, scratch_glyph_row, displayed_buffer):
5635 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5636 (get_next_display_element, show_mouse_face, window_box_edges):
5637 (frame_to_window_pixel_xy, check_point_in_composition):
5638 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5639 (glyph_to_pixel_coords): Remove; unused.
5640
5641 * dired.c (file_name_completion): Now static.
5642
5643 * dbusbind.c (xd_in_read_queued_messages): Now static.
5644
5645 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5646 * data.c (circular_list_error): Remove.
5647
5648 * commands.h (last_point_position, last_point_position_buffer):
5649 (last_point_position_window): Remove decls.
5650 * keyboard.c: Make these variables static.
5651
5652 * coding.h (coding, code_convert_region, encode_coding_gap):
5653 Remove decls.
5654 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5655 (iso_code_class, detect_coding, code_convert_region): Now static.
5656 (encode_coding_gap): Remove; unused.
5657
5658 * chartab.c (chartab_chars, chartab_bits): Now static.
5659
5660 * charset.h (charset_iso_8859_1): Remove decl.
5661 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5662 Now static.
5663
5664 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5665 * ccl.c (Vccl_program_table): Now static.
5666 (check_ccl_update): Remove; unused.
5667
5668 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5669 * category.h: ... from here.
5670 * category.c (check_category_table, set_category_set): Now static.
5671
5672 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5673 * lisp.h: Remove these decls.
5674
5675 * buffer.c (buffer_count): Remove unused var.
5676
5677 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5678 so that it's not optimized away.
5679 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5680 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5681 exported only to the debugger.
5682
5683 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5684 * atimer.h (run_all_atimers): Remove; not exported.
5685
5686 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5687 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5688 was inaccessible from Lisp.
5689 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5690 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5691
5692 alloc.c: Import and export fewer symbols, and remove unused items.
5693 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5694 is defined.
5695 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5696 it's not optimized away by whole-program optimization.
5697 (message_enable_multibyte, free_misc): Remove.
5698 (catchlist, handlerlist, mark_backtrace):
5699 Declare only if BYTE_MARK_STACK.
5700 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5701 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5702 (message_enable_multibyte): Remove decl.
5703 (free_misc, interval_free_list, float_block, float_block_index):
5704 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5705 (cons_free_list, last_marked_index):
5706 Now static.
5707 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5708 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5709 (mark_backtrace): Define only if BYTE_MARK_STACK.
5710 * xdisp.c (message_enable_multibyte): Now static.
5711
5712 Declare Lisp_Object Q* variables to be 'static' if not exported.
5713 This makes it easier for human readers (and static analyzers)
5714 to see whether these variables are used from other modules.
5715 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5716 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5717 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5718 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5719 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5720 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5721 * xmenu.c, xselect.c:
5722 Declare Q* vars static if they are not used in other modules.
5723 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5724 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5725 Remove decls of unexported vars.
5726 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5727
5728 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5729
5730 Make Emacs functions such as Fatom 'static' by default.
5731 This makes it easier for human readers (and static analyzers)
5732 to see whether these functions can be called from other modules.
5733 DEFUN now defines a static function. To make the function external
5734 so that it can be used in other C modules, use the new macro DEFUE.
5735 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5736 (Finit_image_library):
5737 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5738 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5739 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5740 Remove decls, since these functions are now static.
5741 (Funintern, Fget_internal_run_time): New decls, since these functions
5742 were already external.
5743
5744 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5745 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5746 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5747 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5748 * keyboard.c, keymap.c, lread.c:
5749 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5750 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5751 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5752 Mark functions with DEFUE instead of DEFUN,
5753 if they are used in other modules.
5754 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5755 decls for now-static functions.
5756 * buffer.h (Fdelete_overlay): Remove decl.
5757 * callproc.c (Fgetenv_internal): Mark as internal.
5758 * composite.c (Fremove_list_of_text_properties): Remove decl.
5759 (Fcomposition_get_gstring): New forward static decl.
5760 * composite.h (Fcomposite_get_gstring): Remove decl.
5761 * dired.c (Ffile_attributes): New forward static decl.
5762 * doc.c (Fdocumntation_property): New forward static decl.
5763 * eval.c (Ffetch_bytecode): New forward static decl.
5764 (Funintern): Remove extern decl; now in .h file where it belongs.
5765 * fileio.c (Fmake_symbolic_link): New forward static decl.
5766 * image.c (Finit_image_library): New forward static decl.
5767 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5768 * intervals.h (Fprevious_property_change):
5769 (Fremove_list_of_text_properties): Remove decls.
5770 * keyboard.c (Fthis_command_keys): Remove decl.
5771 (Fcommand_execute): New forward static decl.
5772 * keymap.c (Flookup_key): New forward static decl.
5773 (Fcopy_keymap): Now static.
5774 * keymap.h (Flookup_key): Remove decl.
5775 * process.c (Fget_process): New forward static decl.
5776 (Fprocess_datagram_address): Mark as internal.
5777 * syntax.c (Fsyntax_table_p): New forward static decl.
5778 (skip_chars): Remove duplicate decl.
5779 * textprop.c (Fprevious_property_change): New forward static decl.
5780 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5781 Now internal.
5782 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5783 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5784
5785 * editfns.c (Fformat): Remove unreachable code.
5786
5787 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5788
5789 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5790 change. (Bug#8496)
5791
5792 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5793
5794 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5795 when at ZV. (Bug#8487)
5796
5797 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5798
5799 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5800 (Bug#8437)
5801 * keyboard.c (parse_tool_bar_item): Likewise.
5802 * sound.c (sound_cleanup, alsa_close): Likewise.
5803 * termcap.c (tgetent): Likewise.
5804 * xfns.c (x_default_font_parameter): Likewise.
5805 * xsettings.c (read_and_apply_settings): Likewise.
5806
5807 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5808 (overrun_check_free): Protoize.
5809
5810 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5811
5812 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5813 since callers should never pass a negative size.
5814 Change the signature to match that of plain 'read' and 'write'; see
5815 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5816 * lisp.h: Update prototypes of emacs_write and emacs_read.
5817
5818 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5819
5820 * xdisp.c (redisplay_window): Don't try to determine the character
5821 position of the scroll margin if the window start point w->startp
5822 is outside the buffer's accessible region. (Bug#8468)
5823
5824 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5825
5826 Fix write-region and its subroutines for buffers > 2GB.
5827 * fileio.c (a_write, e_write): Modify declaration of arguments and
5828 local variables to support buffers larger than 2GB.
5829 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5830
5831 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5832 argument, local variables, and return value.
5833
5834 * lisp.h: Update prototypes of emacs_write and emacs_read.
5835
5836 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5837
5838 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5839
5840 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5841
5842 Fix more problems found by GCC 4.6.0's static checks.
5843
5844 * xdisp.c (vmessage): Use a better test for character truncation.
5845
5846 * charset.c (load_charset_map): <, not <=, for optimization,
5847 and to avoid potential problems with integer overflow.
5848 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5849 * casetab.c (set_identity, shuffle): Likewise.
5850 * editfns.c (Fformat): Likewise.
5851 * syntax.c (skip_chars): Likewise.
5852
5853 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5854 This also lets GCC 4.6.0 generate slightly better loop code.
5855
5856 * callint.c (Fcall_interactively): <, not <=, for optimization.
5857 (Fcall_interactively): Count the number of arguments produced,
5858 not the number of arguments given. This is simpler and lets GCC
5859 4.6.0 generate slightly better code.
5860
5861 * ftfont.c: Distingish more carefully between FcChar8 and char.
5862 The previous code passed unsigned char * to a functions like
5863 strlen and xstrcasecmp that expect char *, which does not
5864 conform to the C standard.
5865 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5866 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5867 char * when the C standard requires it.
5868
5869 * keyboard.c (read_char): Remove unused var.
5870
5871 * eval.c: Port to Windows vsnprintf (Bug#8435).
5872 Include <limits.h>.
5873 (SIZE_MAX): Define if the headers do not.
5874 (verror): Do not give up if vsnprintf returns a negative count.
5875 Instead, grow the buffer. This ports to Windows vsnprintf, which
5876 does not conform to C99. Problem reported by Eli Zaretskii.
5877 Also, simplify the allocation scheme, by avoiding the need for
5878 calling realloc, and removing the ALLOCATED variable.
5879
5880 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5881
5882 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5883 But keep the doprint source code for now, as we might revamp it
5884 and use it again (Bug#8435).
5885 * lisp.h (doprnt): Remove.
5886 * Makefile.in (base_obj): Remove doprnt.o.
5887 * deps.mk (doprnt.o): Remove.
5888
5889 error: Print 32- and 64-bit integers portably (Bug#8435).
5890 Without this change, on typical 64-bit hosts error ("...%d...", N)
5891 was used to print both 32- and 64-bit integers N, which relied on
5892 undefined behavior.
5893 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5894 New macro.
5895 * lisp.h (error, verror): Mark as printf-like functions.
5896 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5897 Report overflow in size calculations when allocating printf buffer.
5898 Do not truncate output string at its first null byte.
5899 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5900 Truncate the output at a character boundary, since vsnprintf does not
5901 do that.
5902 * charset.c (check_iso_charset_parameter): Convert internal
5903 character to string before calling 'error', since %c now has the
5904 printf meaning.
5905 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5906 overflow when computing char to be passed to 'error'. Do not
5907 pass Lisp_Object to 'error'; pass the integer instead.
5908 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5909 formatted with plain %d.
5910
5911 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5912
5913 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5914
5915 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5916
5917 * xterm.c (x_catch_errors): Remove duplicate declaration.
5918
5919 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5920
5921 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5922
5923 2011-04-10 Jim Meyering <meyering@redhat.com>
5924
5925 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5926 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5927 return ssize_t not "int", and use size_t as the buffer length.
5928 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5929 * gnutls.h: Update declarations.
5930 * process.c (read_process_output): Use ssize_t, to match.
5931 (send_process): Likewise.
5932
5933 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5934
5935 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5936
5937 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5938
5939 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5940 Use unsigned char, to match FcChar8 type definition.
5941
5942 * xterm.c (handle_one_xevent):
5943 * xmenu.c (create_and_show_popup_menu):
5944 * xselect.c (x_decline_selection_request)
5945 (x_reply_selection_request): Avoid type-punned deref of X events.
5946
5947 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5948
5949 Fix some uses of `int' instead of EMACS_INT.
5950 * search.c (string_match_1, fast_string_match)
5951 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5952 (scan_buffer, find_next_newline_no_quit)
5953 (find_before_next_newline, search_command, Freplace_match)
5954 (Fmatch_data): Make some `int' variables be EMACS_INT.
5955
5956 * xdisp.c (display_count_lines): 3rd argument and return value now
5957 EMACS_INT. All callers changed.
5958 (pint2hrstr): Last argument is now EMACS_INT.
5959
5960 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5961 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5962 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5963 (decode_coding_utf_16, decode_coding_emacs_mule)
5964 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5965 (decode_coding_ccl, decode_coding_charset)
5966 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5967 (decode_coding_iso_2022, decode_coding_emacs_mule)
5968 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5969 <char_offset, last_offset>: Declare EMACS_INT.
5970 (encode_coding_utf_8, encode_coding_utf_16)
5971 (encode_coding_emacs_mule, encode_invocation_designation)
5972 (encode_designation_at_bol, encode_coding_iso_2022)
5973 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5974 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5975 Declare EMACS_INT.
5976 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5977 (encode_invocation_designation): Last argument P_NCHARS is now
5978 EMACS_INT.
5979 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5980 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5981
5982 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5983 All users changed.
5984
5985 * ccl.c (Fccl_execute_on_string): Declare some variables
5986 EMACS_INT.
5987
5988 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5989
5990 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5991
5992 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5993
5994 * process.c (Fformat_network_address): Doc fix.
5995
5996 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5997
5998 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5999
6000 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6001
6002 * keyboard.c (read_char): Call Lisp function help-form-show,
6003 instead of using internal_with_output_to_temp_buffer.
6004 (Qhelp_form_show): New var.
6005 (syms_of_keyboard): Use DEFSYM macro.
6006
6007 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6008
6009 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6010
6011 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6012
6013 * process.c (Flist_processes): Remove to Lisp.
6014 (list_processes_1): Delete.
6015
6016 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6017
6018 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6019
6020 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6021
6022 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6023
6024 Fix more problems found by GCC 4.6.0's static checks.
6025
6026 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6027
6028 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6029
6030 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6031
6032 * xdisp.c (vmessage): Mark as a printf-like function.
6033
6034 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6035
6036 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6037
6038 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6039 printf-like functions.
6040 (tiff_load): Add casts to remove these marks before passing them
6041 to system-supplied API.
6042
6043 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6044
6045 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6046 This avoids several warnings with gcc -Wstrict-overflow.
6047 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6048 directly, rather than having caller test rule sign. This avoids
6049 some unnecessary tests.
6050 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6051 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6052 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6053
6054 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6055 (xfont_open): Avoid unnecessary tests.
6056
6057 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6058
6059 * composite.h, composite.c (composition_gstring_put_cache):
6060 Use EMACS_INT, not int, for length.
6061
6062 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6063 breaking out part of COMPOSITION_DECODE_RULE.
6064 (COMPOSITION_DECODE_RULE): Use it.
6065 * composite.c (get_composition_id): Remove unused local vars,
6066 by using the new macro.
6067
6068 * textprop.c (set_text_properties_1): Change while to do-while,
6069 since the condition is always true at first.
6070
6071 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6072 (interval_deletion_adjustment): Return unsigned value.
6073 All uses changed.
6074
6075 * process.c (list_processes_1, create_pty, read_process_output):
6076 (exec_sentinel): Remove vars that were set but not used.
6077 (create_pty): Remove unnecessary "volatile"s.
6078 (Fnetwork_interface_info): Avoid possibility of int overflow.
6079 (read_process_output): Do adaptive read buffering even if carryover.
6080 (read_process_output): Simplify nbytes computation if buffered.
6081
6082 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6083
6084 * syntax.c (scan_words): Remove var that was set but not used.
6085 (update_syntax_table): Use unsigned instead of int.
6086
6087 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6088 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6089 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6090
6091 * print.c (print_error_message): Avoid int overflow.
6092
6093 * font.c (font_list_entities): Redo for clarity,
6094 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6095
6096 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6097 (font_score): Avoid potential overflow in diff calculation.
6098
6099 * fns.c (substring_both): Remove var that is set but not used.
6100 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6101
6102 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6103
6104 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6105 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6106 can always succeed if overflow has undefined behavior.
6107
6108 * search.c (boyer_moore, wordify): Remove vars set but not used.
6109 (wordify): Omit three unnecessary tests.
6110
6111 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6112 All callers changed. This avoids the need for an unused var.
6113
6114 * casefiddle.c (casify_region): Remove var that is set but not used.
6115
6116 * dired.c (file_name_completion): Remove var that is set but not used.
6117
6118 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6119
6120 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6121 (Finsert_file_contents): Remove unnecessary code checking fd.
6122
6123 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6124 Check for integer overflow on size calculations.
6125
6126 * buffer.c (Fprevious_overlay_change): Remove var that is set
6127 but not used.
6128
6129 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6130 Remove vars that are set but not used.
6131 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6132 (timer_check_2): Mark vars as initialized.
6133
6134 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6135
6136 * image.c (lookup_image): Remove var that is set but not used.
6137 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6138
6139 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6140 that are set but not used.
6141
6142 * xfns.c (make_invisible_cursor): Don't return garbage
6143 if XCreateBitmapFromData fails (Bug#8410).
6144
6145 * xselect.c (x_get_local_selection, x_handle_property_notify):
6146 Remove vars that are set but not used.
6147
6148 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6149 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6150
6151 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6152 Remove var that is set but not used.
6153 (scroll_bar_windows_size): Now size_t, not int.
6154 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6155 Check for overflow.
6156
6157 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6158 (map_tty_color) [!defined MSDOS]: Likewise.
6159
6160 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6161
6162 * coding.c: Remove vars that are set but not used.
6163 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6164 All callers changed.
6165 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6166 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6167 (decode_coding_charset): Remove vars that are set but not used.
6168
6169 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6170 that is set but not used.
6171
6172 * print.c (print_object): Remove var that is set but not used.
6173
6174 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6175 The gnulib version avoids calling malloc in the usual case,
6176 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6177 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6178 * filelock.c (current_lock_owner): Likewise.
6179 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6180 * sysdep.c: Include allocator.h, careadlinkat.h.
6181 (emacs_no_realloc_allocator): New static constant.
6182 (emacs_readlink): New function.
6183 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6184 ../lib/careadlinkat.h.
6185
6186 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6187
6188 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6189 first non-nil return value).
6190
6191 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6192
6193 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6194 if not defined (Bug#8403).
6195
6196 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6197
6198 * xdisp.c (display_count_lines): Remove parameter `start',
6199 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6200 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6201 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6202 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6203 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6204 and thereabouts. All callers changed.
6205 (get_per_char_metric): Remove parameter `f', unused since
6206 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6207
6208 2011-04-02 Jim Meyering <meyering@redhat.com>
6209
6210 do not dereference NULL upon failed strdup
6211 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6212 (ns_get_family): Likewise.
6213
6214 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6215
6216 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6217
6218 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6219
6220 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6221 later (Bug#8403).
6222
6223 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6224
6225 Add lexical binding.
6226
6227 * window.c (Ftemp_output_buffer_show): New fun.
6228 (Fsave_window_excursion):
6229 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6230
6231 * lread.c (lisp_file_lexically_bound_p): New function.
6232 (Fload): Bind Qlexical_binding.
6233 (readevalloop): Remove `evalfun' arg.
6234 Bind Qinternal_interpreter_environment.
6235 (Feval_buffer): Bind Qlexical_binding.
6236 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6237 Mark as dynamic.
6238 (syms_of_lread): Declare `lexical-binding'.
6239
6240 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6241
6242 * keyboard.c (eval_dyn): New fun.
6243 (menu_item_eval_property): Use it.
6244
6245 * image.c (parse_image_spec): Use Ffunctionp.
6246
6247 * fns.c (concat, mapcar1): Accept byte-code-functions.
6248
6249 * eval.c (Fsetq): Handle lexical vars.
6250 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6251 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6252 (FletX, Flet): Obey lexical binding.
6253 (Fcommandp): Handle closures.
6254 (Feval): New `lexical' arg.
6255 (eval_sub): New function extracted from Feval. Use it almost
6256 everywhere where Feval was used. Look up vars in lexical env.
6257 Handle closures.
6258 (Ffunctionp): Move from subr.el.
6259 (Ffuncall): Handle closures.
6260 (apply_lambda): Remove `eval_flags'.
6261 (funcall_lambda): Handle closures and new byte-code-functions.
6262 (Fspecial_variable_p): New function.
6263 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6264 but without exporting it to Lisp.
6265
6266 * doc.c (Fdocumentation, store_function_docstring):
6267 * data.c (Finteractive_form): Handle closures.
6268
6269 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6270 interactive spec.
6271
6272 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6273 New byte-codes.
6274 (exec_byte_code): New function extracted from Fbyte_code to handle new
6275 calling convention for byte-code-functions. Add new byte-codes.
6276
6277 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6278
6279 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6280
6281 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6282
6283 * xdisp.c (redisplay_internal): Fix prototype.
6284
6285 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6286
6287 * xdisp.c (SCROLL_LIMIT): New macro.
6288 (try_scrolling): Use it when setting scroll_limit.
6289 Limit scrolling to 100 screen lines.
6290 (redisplay_window): Even when falling back on "recentering",
6291 position point in the window according to scroll-conservatively,
6292 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6293
6294 (try_scrolling): When point is above the window, allow searching
6295 as far as scroll_max, or one screenful, to compute vertical
6296 distance from PT to the scroll margin position. This prevents
6297 try_scrolling from unnecessarily failing when
6298 scroll-conservatively is set to a value slightly larger than the
6299 window height. Clean up the case of PT below the margin at bottom
6300 of window: scroll_max can no longer be INT_MAX. When aggressive
6301 scrolling is in use, don't let point enter the opposite scroll
6302 margin as result of the scroll.
6303 (syms_of_xdisp) <scroll-conservatively>: Document the
6304 threshold of 100 lines for never-recentering scrolling.
6305
6306 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6307
6308 * dispextern.h (move_it_by_lines):
6309 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6310 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6311 (message_log_check_duplicate): Remove parameters `prev_bol' and
6312 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6313 (redisplay_internal): Remove parameter `preserve_echo_area',
6314 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6315
6316 * indent.c (Fvertical_motion):
6317 * window.c (window_scroll_pixel_based, Frecenter):
6318 Don't pass `need_y_p' to `move_it_by_lines'.
6319
6320 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6321
6322 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6323 steal a few bits to be more compact.
6324 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6325 Remove unneeded casts.
6326
6327 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6328
6329 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6330
6331 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6332 binding" message (bug#7967).
6333
6334 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6335
6336 Fix more problems found by GCC 4.6.0's static checks.
6337
6338 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6339 Remove unused local var.
6340
6341 * editfns.c (Fmessage_box): Remove unused local var.
6342
6343 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6344 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6345 Omit unused local vars.
6346 * window.c (shrink_windows): Omit unused local var.
6347 * menu.c (digest_single_submenu): Omit unused local var.
6348 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6349 Omit unused local var.
6350
6351 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6352 Don't assume string length fits in int.
6353 (keyremap_step, read_key_sequence): Use size_t for sizes.
6354 (read_key_sequence): Don't check last_real_key_start redundantly.
6355
6356 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6357 instead of alloca (Bug#8344).
6358
6359 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6360 (Fbacktrace_frame): Don't assume nframes fits in int.
6361
6362 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6363
6364 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6365 concerns.
6366
6367 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6368
6369 * cm.c (calccost): Turn while-do into do-while, for clarity.
6370
6371 * keyboard.c (syms_of_keyboard): Use the same style as later
6372 in this function when indexing through an array. This also
6373 works around GCC bug 48267.
6374
6375 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6376
6377 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6378
6379 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6380 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6381
6382 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6383 This avoids undefined behavior on integer overflow, and is a bit
6384 more convenient anyway since it is compared to a size_t variable.
6385
6386 Variadic C functions now count arguments with size_t, not int.
6387 This avoids an unnecessary limitation on 64-bit machines, which
6388 caused (substring ...) to crash on large vectors (Bug#8344).
6389 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6390 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6391 All variadic functions and their callers changed accordingly.
6392 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6393 * data.c (arith_driver, float_arith_driver): Likewise.
6394 * editfns.c (general_insert_function): Likewise.
6395 * eval.c (struct backtrace.nargs, interactive_p)
6396 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6397 (funcall_lambda, mark_backtrace): Likewise.
6398 * fns.c (concat): Likewise.
6399 * frame.c (x_set_frame_parameters): Likewise.
6400 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6401 0 if not found, not -1. All callers changed.
6402
6403 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6404 (stack_copy_size): Now size_t, not int.
6405 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6406
6407 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6408
6409 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6410 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6411 All callers changed.
6412
6413 * lisp.h (multibyte_char_to_unibyte):
6414 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6415 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6416 * character.h (CHAR_TO_BYTE8):
6417 * cmds.c (internal_self_insert):
6418 * editfns.c (general_insert_function):
6419 * keymap.c (push_key_description):
6420 * search.c (Freplace_match):
6421 * xdisp.c (message_dolog, set_message_1): All callers changed.
6422
6423 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6424
6425 * keyboard.c (safe_run_hook_funcall): New function.
6426 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6427 don't set the hook to nil, but remove the offending function instead.
6428 (Qcommand_hook_internal): Remove, unused.
6429 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6430 Vcommand_hook_internal.
6431
6432 * eval.c (enum run_hooks_condition): Remove.
6433 (funcall_nil, funcall_not): New functions.
6434 (run_hook_with_args): Call each function through a `funcall' argument.
6435 Remove `cond' argument, now redundant.
6436 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6437 (Frun_hook_with_args_until_failure): Adjust accordingly.
6438 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6439
6440 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6441
6442 * dispextern.h (string_buffer_position): Remove declaration.
6443
6444 * print.c (strout): Remove parameter `multibyte', unused since
6445 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6446
6447 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6448 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6449 All callers changed.
6450
6451 * w32.c (_wsa_errlist): Use braces for struct initializers.
6452
6453 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6454 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6455 All callers changed.
6456 (string_buffer_position): Likewise. Also, make static (it's never
6457 used outside xdisp.c).
6458 (cursor_row_p): Remove parameter `w', unused since
6459 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6460 (decode_mode_spec): Remove parameter `precision', introduced during
6461 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6462 All callers changed.
6463
6464 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6465
6466 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6467
6468 2011-03-27 Anders Lindgren <andlind@gmail.com>
6469
6470 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6471 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6472 (ns_update_auto_hide_menu_bar): New functions.
6473 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6474 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6475 ns_constrain_all_frames.
6476 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6477 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6478
6479 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6480
6481 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6482
6483 2011-03-27 Glenn Morris <rgm@gnu.org>
6484
6485 * syssignal.h: Replace RETSIGTYPE with void.
6486 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6487 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6488 Replace SIGTYPE with void everywhere.
6489 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6490 * s/template.h (SIGTYPE): Remove commented out definition.
6491
6492 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6493
6494 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6495 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6496
6497 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6498
6499 * w32.c (read_unc_volume): Use parameter `henum', instead of
6500 global variable `wget_enum_handle'.
6501
6502 * keymap.c (describe_vector): Remove parameters `indices' and
6503 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6504 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6505
6506 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6507
6508 * keyboard.c (timer_check): Remove parameter `do_it_now',
6509 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6510 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6511 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6512
6513 * keyboard.c (read_char):
6514 * w32menu.c (w32_menu_display_help):
6515 * xmenu.c (show_help_event, menu_help_callback):
6516 Adjust calls to `show_help_echo'.
6517
6518 * gtkutil.c (xg_maybe_add_timer):
6519 * keyboard.c (readable_events):
6520 * process.c (wait_reading_process_output):
6521 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6522
6523 * insdel.c (adjust_markers_gap_motion):
6524 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6525 (gap_left, gap_right): Don't call it.
6526
6527 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6528
6529 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6530 incurred during fontification.
6531
6532 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6533
6534 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6535 (DEFVAR_PER_BUFFER): Don't pass it.
6536
6537 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6538 (scrolling_window): Don't pass it.
6539
6540 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6541
6542 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6543
6544 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6545 and `suffix'.
6546 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6547 of variables specific to SELinux and computation of `encoded_absname'.
6548
6549 * image.c (XPutPixel): Remove unused variable `height'.
6550
6551 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6552
6553 * unexw32.c (get_section_info): Remove unused variable `section'.
6554
6555 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6556 (system_process_attributes): Remove unused variable `sess'.
6557 (sys_read): Remove unused variable `err'.
6558
6559 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6560 (w32_wnd_proc): Remove unused variable `isdead'.
6561 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6562 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6563 (x_create_tip_frame): Remove unused variable `tem'.
6564
6565 * w32inevt.c (w32_console_read_socket):
6566 Remove unused variable `no_events'.
6567
6568 * w32term.c (x_draw_composite_glyph_string_foreground):
6569 Remove unused variable `width'.
6570
6571 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6572
6573 * w32term.c (x_set_glyph_string_clipping):
6574 Don't pass uninitialized region to CombineRgn.
6575
6576 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6577
6578 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6579 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6580 (Fx_close_connection): Remove unused variable `i'.
6581
6582 * w32font.c (w32font_draw): Return number of glyphs.
6583 (w32font_open_internal): Remove unused variable `i'.
6584 (w32font_driver): Add missing initializer.
6585
6586 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6587 (fill_in_menu): Remove unused variable `items_added'.
6588
6589 * w32term.c (last_mouse_press_frame): Remove static global variable.
6590 (w32_clip_to_row): Remove unused variable `f'.
6591 (x_delete_terminal): Remove unused variable `i'.
6592
6593 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6594 (NOTHING): Remove unused static global variable.
6595 (uniscribe_check_otf): Remove unused variable `table'.
6596 (uniscribe_font_driver): Add missing initializers.
6597
6598 2011-03-23 Julien Danjou <julien@danjou.info>
6599
6600 * term.c (Fsuspend_tty, Fresume_tty):
6601 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6602 * window.c (temp_output_buffer_show):
6603 * insdel.c (signal_before_change):
6604 * frame.c (Fhandle_switch_frame):
6605 * fileio.c (Fdo_auto_save):
6606 * emacs.c (Fkill_emacs):
6607 * editfns.c (save_excursion_restore):
6608 * cmds.c (internal_self_insert):
6609 * callint.c (Fcall_interactively):
6610 * buffer.c (Fkill_all_local_variables):
6611 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6612 Use Frun_hooks.
6613 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6614 unconditionnaly since it does the check itself.
6615
6616 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6617
6618 Fix more problems found by GCC 4.5.2's static checks.
6619
6620 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6621 the first time through the loop, since we know p0 < p1 then.
6622 This also avoids a gcc -Wstrict-overflow warning.
6623
6624 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6625 leading to a memory leak, possible in functions like
6626 load_charset_map_from_file that can allocate an unbounded number
6627 of objects (Bug#8318).
6628
6629 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6630 that could (at least in theory) be that large.
6631
6632 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6633 This is less likely to overflow, and avoids undefined behavior if
6634 overflow does occur. All callers changed. Use strtoul to scan
6635 for the unsigned long integer.
6636 (pint2hrstr): Simplify and tune code slightly.
6637 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6638
6639 * scroll.c (do_scrolling): Work around GCC bug 48228.
6640 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6641
6642 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6643 This also avoids a warning with gcc -Wstrict-overflow.
6644 (validate_x_resource_name): Simplify count usage.
6645 This also avoids a warning with gcc -Wstrict-overflow.
6646
6647 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6648 fail (Bug#8306).
6649
6650 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6651
6652 * process.c (Fmake_network_process): Use socklen_t, not int,
6653 where POSIX says socklen_t is required in portable programs.
6654 This fixes a porting bug on hosts like 64-bit HP-UX, where
6655 socklen_t is wider than int (Bug#8277).
6656 (Fmake_network_process, server_accept_connection):
6657 (wait_reading_process_output, read_process_output):
6658 Likewise.
6659
6660 * process.c: Rename or move locals to avoid shadowing.
6661 (list_processes_1, Fmake_network_process):
6662 (read_process_output_error_handler, exec_sentinel_error_handler):
6663 Rename or move locals.
6664 (Fmake_network_process): Define label "retry_connect" only if needed.
6665 (Fnetwork_interface_info): Fix pointer signedness.
6666 (process_send_signal): Add cast to avoid pointer signedness problem.
6667 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6668 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6669
6670 Make tparam.h and terminfo.c consistent.
6671 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6672 Include tparam.h instead, since it declares them.
6673 * cm.h (PC): Remove extern decl; tparam.h now does this.
6674 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6675 * terminfo.c: Include tparam.h, to check interfaces.
6676 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6677 (tparam): Adjust signature to match interface in tparam.h;
6678 this removes some undefined behavior. Check that outstring and len
6679 are zero, which they always are with Emacs.
6680 * tparam.h (PC, BC, UP): New extern decls.
6681
6682 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6683 (xftfont_open): Rename locals to avoid shadowing.
6684
6685 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6686 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6687 (OTF_TAG_SYM): Omit macro if not needed.
6688 (ftfont_list): Remove unused local.
6689 (get_adstyle_property, ftfont_pattern_entity):
6690 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6691 Rename locals to avoid shadowing.
6692
6693 * xfont.c (xfont_list_family): Mark var as initialized.
6694
6695 * xml.c (make_dom): Now static.
6696
6697 * composite.c (composition_compute_stop_pos): Rename local to
6698 avoid shadowing.
6699 (composition_reseat_it): Remove unused locals.
6700 (find_automatic_composition, composition_adjust_point): Likewise.
6701 (composition_update_it): Mark var as initialized.
6702 (find_automatic_composition): Mark vars as initialized,
6703 with a FIXME (Bug#8290).
6704
6705 character.h: Rename locals to avoid shadowing.
6706 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6707 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6708 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6709 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6710 to avoid shadowing.
6711
6712 * textprop.c (property_change_between_p): Remove; unused.
6713
6714 * intervals.c (interval_start_pos): Now static.
6715
6716 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6717
6718 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6719 Rename locals to avoid shadowing.
6720
6721 * sound.c (wav_play, au_play, Fplay_sound_internal):
6722 Fix pointer signedness.
6723 (alsa_choose_format): Remove unused local var.
6724 (wav_play): Initialize a variable to 0, to prevent undefined
6725 behavior (Bug#8278).
6726
6727 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6728
6729 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6730
6731 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6732 clobbering (Bug#8298).
6733 * sysdep.c (sys_subshell): Likewise.
6734 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6735
6736 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6737 This should get cleaned up, so that child_setup has the
6738 same signature on all platforms.
6739
6740 * callproc.c (call_process_cleanup): Now static.
6741 (relocate_fd): Rename locals to avoid shadowing.
6742
6743 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6744
6745 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6746 not to be necessary, and produces flickering.
6747
6748 2011-03-20 Glenn Morris <rgm@gnu.org>
6749
6750 * config.in: Remove file.
6751
6752 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6753
6754 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6755 are now in src/globals.h.
6756 (syms_of_minibuf): Remove spurious & from previous change.
6757
6758 2011-03-20 Leo <sdl.web@gmail.com>
6759
6760 * minibuf.c (completing-read-function): New variable.
6761 (completing-read-default): Rename from completing-read.
6762 (completing-read): Call completing-read-function.
6763
6764 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6765
6766 * xfaces.c (Fx_load_color_file):
6767 Read color file from absolute filename (bug#8250).
6768
6769 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6770
6771 * makefile.w32-in: Update dependencies.
6772
6773 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6774
6775 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6776
6777 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6778
6779 Fix more problems found by GCC 4.5.2's static checks.
6780
6781 * process.c (make_serial_process_unwind, send_process_trap):
6782 (sigchld_handler): Now static.
6783
6784 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6785 That way, the code declares only the vars that it needs.
6786 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6787 * s/cygwin.h (PTY_ITERATION): Likewise.
6788 * s/darwin.h (PTY_ITERATION): Likewise.
6789 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6790
6791 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6792 * process.c (allocate_pty): Don't declare stb unless it's needed.
6793
6794 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6795 (CONSTANTLIM): Remove; unused.
6796 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6797 Define only if needed.
6798
6799 * unexelf.c (unexec): Name an expression,
6800 to avoid gcc -Wbad-function-cast warning.
6801 Use a different way to cause a compilation error if anyone uses
6802 n rather than nn, a way that does not involve shadowing.
6803 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6804
6805 * deps.mk (unexalpha.o): Remove; unused.
6806
6807 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6808 * unexec.h: New file.
6809 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6810 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6811 Depend on unexec.h.
6812 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6813 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6814 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6815 Change as necessary to match prototype in unexec.h.
6816
6817 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6818 shadowing.
6819 (back_comment, skip_chars): Mark vars as initialized.
6820
6821 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6822 Rename locals to avoid shadowing.
6823
6824 * lread.c (read1): Rewrite so as not to use empty "else".
6825 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6826
6827 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6828
6829 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6830 warning when compiling print.c.
6831
6832 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6833 instead of using an uninitialized var.
6834 (font_sort_entities): Mark var as initialized.
6835
6836 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6837
6838 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6839 pointers to constants.
6840 (font_parse_fcname): Remove unused vars.
6841 (font_delete_unmatched): Now static.
6842 (font_get_spec): Remove; unused.
6843 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6844 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6845 Rename or move locals to avoid shadowing.
6846
6847 * fns.c (require_nesting_list, require_unwind): Now static.
6848 (Ffillarray): Rename locals to avoid shadowing.
6849
6850 * floatfns.c (domain_error2): Define only if needed.
6851 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6852
6853 * alloc.c (mark_backtrace): Move decl from here ...
6854 * lisp.h: ... to here, so that it can be checked.
6855
6856 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6857 (Fdefvar): Rewrite so as not to use empty "else".
6858 (lisp_indirect_variable): Name an expression,
6859 to avoid gcc -Wbad-function-cast warning.
6860 (Fdefvar): Rename locals to avoid shadowing.
6861
6862 * callint.c (quotify_arg, quotify_args): Now static.
6863 (Fcall_interactively): Rename locals to avoid shadowing.
6864 Use const pointer when appropriate.
6865
6866 * lisp.h (get_system_name, get_operating_system_release):
6867 Move decls here, to check interfaces.
6868 * process.c (get_operating_system_release): Move decl to lisp.h.
6869 * xrdb.c (get_system_name): Likewise.
6870 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6871 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6872 some of which prompt warnings from gcc -Wbad-function-cast.
6873 (Fformat_time_string, Fencode_time, Finsert_char):
6874 (Ftranslate_region_internal, Fformat):
6875 Rename or remove local vars to avoid shadowing.
6876 (Ftranslate_region_internal): Mark var as initialized.
6877
6878 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6879 avoid shadowing.
6880
6881 * lisp.h (eassert): Check that the argument compiles, even if
6882 ENABLE_CHECKING is not defined.
6883
6884 * data.c (Findirect_variable): Name an expression, to avoid
6885 gcc -Wbad-function-cast warning.
6886 (default_value, arithcompare, arith_driver, arith_error): Now static.
6887 (store_symval_forwarding): Rename local to avoid shadowing.
6888 (Fmake_variable_buffer_local, Fmake_local_variable):
6889 Mark variables as initialized.
6890 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6891
6892 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6893 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6894 Rename locals to avoid shadowing.
6895 (mark_stack): Move local variables into the #ifdef region where
6896 they're used.
6897 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6898 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6899 needed otherwise.
6900 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6901 (GC_STRING_CHARS): Remove; not used.
6902 (Fmemory_limit): Cast sbrk's returned value to char *.
6903
6904 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6905 avoids undefined behavior in theory.
6906
6907 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6908
6909 Use functions, not macros, for up- and down-casing (Bug#8254).
6910 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6911 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6912 to use the following functions instead of these macros.
6913 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6914 EMACS_INT, since callers assume the returned value fits in int.
6915 (upcase1): Likewise, for UPCASE_TABLE.
6916 (uppercasep, lowercasep, upcase): New static inline functions.
6917 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6918 the race-condition problem in the old DOWNCASE.
6919
6920 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6921 Rename locals to avoid shadowing.
6922 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6923 (regex_compile, re_search_2, re_match_2_internal):
6924 Remove unused local vars.
6925 (FREE_VAR): Rewrite so as not to use empty "else",
6926 which gcc can warn about.
6927 (regex_compile, re_match_2_internal): Mark locals as initialized.
6928 (RETALLOC_IF): Define only if needed.
6929 (WORDCHAR_P): Likewise. This one is never needed, but is used
6930 only in a comment talking about a compiler bug, so put inside
6931 the #if 0 of that comment.
6932 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6933 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6934 Remove; unused.
6935
6936 * search.c (boyer_moore): Rename locals to avoid shadowing.
6937 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6938 (PREV_CHAR_BOUNDARY): Likewise.
6939
6940 * search.c (simple_search): Remove unused var.
6941
6942 * dired.c (compile_pattern): Move decl from here ...
6943 * lisp.h: ... to here, so that it can be checked.
6944 (struct re_registers): New forward decl.
6945
6946 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6947
6948 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6949 All uses changed.
6950 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6951 Rename locals to avoid shadowing.
6952 (Fvertical_motion): Mark locals as initialized.
6953
6954 * casefiddle.c (casify_object, casify_region): Now static.
6955 (casify_region): Mark local as initialized.
6956
6957 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6958
6959 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6960 New macros, so that the caller can use some names other than
6961 gcpro1, gcpro2, etc.
6962 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6963 of the new macros.
6964 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6965 argument, for consistency with GCPRO2_VAR, etc: it is now the
6966 prefix of the variable, not the variable itself. All uses
6967 changed.
6968 * dired.c (directory_files_internal, file_name_completion):
6969 Rename locals to avoid shadowing.
6970
6971 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6972 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6973 dired.c's scmp function, had undefined behavior.
6974 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6975 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6976 * buffer.h: ... to here, because these macros use current_buffer,
6977 and the new implementation with inline functions needs to have
6978 current_buffer in scope now, rather than later when the macros
6979 are used.
6980 (downcase, upcase1): New static inline functions.
6981 (DOWNCASE, UPCASE1): Reimplement using these functions.
6982 This avoids undefined behavior in expressions like
6983 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6984 from race conditions in accessing the global variables
6985 case_temp1 and case_temp2.
6986 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6987 * lisp.h (case_temp1, case_temp2): Remove their decls.
6988 * character.h (ASCII_CHAR_P): Move from here ...
6989 * lisp.h: ... to here, so that the inline functions mentioned
6990 above can use them.
6991
6992 * dired.c (directory_files_internal_unwind): Now static.
6993
6994 * fileio.c (file_name_as_directory, directory_file_name):
6995 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6996 Now static.
6997 (file_name_as_directory): Use const pointers when appropriate.
6998 (Fexpand_file_name): Likewise. In particular, newdir might
6999 point at constant storage, so make it a const pointer.
7000 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7001 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7002 signedness issues.
7003 (Fset_file_times, Finsert_file_contents, auto_save_error):
7004 Rename locals to avoid shadowing.
7005
7006 * minibuf.c (choose_minibuf_frame_1): Now static.
7007 (Ftry_completion, Fall_completions): Rename or remove locals
7008 to avoid shadowing.
7009
7010 * marker.c (bytepos_to_charpos): Remove; unused.
7011
7012 * lisp.h (verify_bytepos, count_markers): New decls,
7013 so that gcc does not warn that these functions aren't declared.
7014
7015 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7016 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7017 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7018 (copy_text): Remove unused local var.
7019
7020 * filelock.c (within_one_second): Now static.
7021 (lock_file_1): Rename local to avoid shadowing.
7022
7023 * buffer.c (fix_overlays_before): Mark locals as initialized.
7024 (fix_start_end_in_overlays): Likewise. This function should be
7025 simplified by using pointers-to-pointers, but that's a different
7026 matter.
7027 (switch_to_buffer_1): Now static.
7028 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7029 (report_overlay_modification): Rename locals to avoid shadowing.
7030
7031 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7032 Fix pointer signedness issue.
7033 (sys_subshell): Mark local as volatile if checking for lint,
7034 to suppress a gcc -Wclobbered warning that does not seem to be right.
7035 (MAXPATHLEN): Define only if needed.
7036
7037 * process.c (serial_open, serial_configure): Move decls from here ...
7038 * systty.h: ... to here, so that they can be checked.
7039
7040 * fns.c (get_random, seed_random): Move extern decls from here ...
7041 * lisp.h: ... to here, so that they can be checked.
7042
7043 * sysdep.c (reset_io): Now static.
7044 (wait_for_termination_signal): Remove; unused.
7045
7046 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7047 (copy_keymap_item, append_key, push_text_char_description):
7048 Now static.
7049 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7050 (DENSE_TABLE_SIZE): Remove; unused.
7051 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7052 (describe_map_tree):
7053 Rename locals to avoid shadowing.
7054
7055 * keyboard.c: Declare functions static if they are not used elsewhere.
7056 (echo_char, echo_dash, cmd_error, top_level_2):
7057 (poll_for_input, handle_async_input): Now static.
7058 (read_char, kbd_buffer_get_event, make_lispy_position):
7059 (make_lispy_event, make_lispy_movement, apply_modifiers):
7060 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7061 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7062 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7063 (read_key_sequence, read_char): Mark locals as initialized.
7064 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7065
7066 * keyboard.h (make_ctrl_char): New decl.
7067 (mark_kboards): Move decl here ...
7068 * alloc.c (mark_kboards): ... from here.
7069
7070 * lisp.h (force_auto_save_soon): New decl.
7071
7072 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7073 (DEFINE_DUMMY_FUNCTION): New macro.
7074 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7075 Use it.
7076 (main): Add casts to avoid warnings
7077 if GCC considers string literals to be constants.
7078
7079 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7080
7081 * dbusbind.c: Pointer signedness fixes.
7082 (xd_signature, xd_append_arg, xd_initialize):
7083 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7084 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7085 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7086 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7087
7088 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7089 if GCC considers string literals to be constants.
7090 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7091
7092 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7093
7094 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7095 (print_preprocess, print_object): New macro to fix last change.
7096
7097 * print.c (print_preprocess): Don't forget font objects.
7098
7099 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7100
7101 * emacs.c (USAGE3): Doc fixes.
7102
7103 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7104
7105 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7106 structure.
7107
7108 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7109
7110 * lisp.h (VWindow_system, Qfile_name_history):
7111 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7112 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7113 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7114
7115 * w32select.c: Don't #include "keyboard.h".
7116 (run_protected): Add extern declaration for waiting_for_input.
7117
7118 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7119 * w32console.c (detect_input_pending, read_input_pending)
7120 (encode_terminal_code):
7121 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7122 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7123 (w32_system_caret_y, Qfile_name_history):
7124 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7125 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7126 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7127 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7128 * w32proc.c (Qlocal, report_file_error):
7129 * w32term.c (Vwindow_system, updating_frame):
7130 * w32uniscribe.c (initialized, uniscribe_font_driver):
7131 Remove unneeded extern declarations.
7132
7133 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7134
7135 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7136
7137 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7138
7139 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7140 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7141 These macros can no longer be used for assignment.
7142
7143 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7144 Assign struct members directly, instead of using BUF_BEGV etc.
7145 (record_buffer_markers, fetch_buffer_markers): New functions for
7146 recording and fetching special buffer markers.
7147 (set_buffer_internal_1, set_buffer_temp): Use them.
7148
7149 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7150
7151 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7152
7153 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7154 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7155
7156 * xdisp.c (hscroll_window_tree):
7157 (reconsider_clip_changes): Use PT instead of BUF_PT.
7158
7159 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7160
7161 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7162 $(EMACS_ROOT)/lib/intprops.h.
7163
7164 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7165
7166 Fix more problems found by GCC 4.5.2's static checks.
7167
7168 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7169 to unsigned char * to avoid compiler diagnostic.
7170 (xg_free_frame_widgets): Make it clear that a local variable is
7171 needed only if USE_GTK_TOOLTIP.
7172 (gdk_window_get_screen): Make it clear that this macro is needed
7173 only if USE_GTK_TOOLTIP.
7174 (int_gtk_range_get_value): New function, which avoids a diagnostic
7175 from gcc -Wbad-function-cast.
7176 (xg_set_toolkit_scroll_bar_thumb): Use it.
7177 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7178 diagnostic from gcc -Wbad-function-cast.
7179 (get_utf8_string, xg_get_file_with_chooser):
7180 Rename locals to avoid shadowing.
7181 (create_dialog): Move locals to avoid shadowing.
7182
7183 * xgselect.c (xg_select): Remove unused var.
7184
7185 * image.c (four_corners_best): Mark locals as initialized.
7186 (gif_load): Initialize transparent_p to zero (Bug#8238).
7187 Mark another local as initialized.
7188 (my_png_error, my_error_exit): Mark with NO_RETURN.
7189
7190 * image.c (clear_image_cache): Now static.
7191 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7192 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7193 (x_edge_detection): Remove unnecessary cast that
7194 gcc -Wbad-function-cast diagnoses.
7195 (gif_load): Fix pointer signedness.
7196 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7197 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7198
7199 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7200
7201 Improve quality of tests for time stamp overflow.
7202 For example, without this patch (encode-time 0 0 0 1 1
7203 1152921504606846976) returns the obviously-bogus value (-948597
7204 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7205 reports time overflow. See
7206 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7207 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7208 * editfns.c: Include limits.h and intprops.h.
7209 (TIME_T_MIN, TIME_T_MAX): New macros.
7210 (time_overflow): Move earlier, to before first use.
7211 (hi_time, lo_time): New functions, for an accurate test for
7212 out-of-range times.
7213 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7214 (Fget_internal_run_time): Don't assume time_t fits in int.
7215 (make_time): Use list2 instead of Fcons twice.
7216 (Fdecode_time): More accurate test for out-of-range times.
7217 (check_tm_member): New function.
7218 (Fencode_time): Use it, to test for out-of-range times.
7219 (lisp_time_argument): Don't rely on undefined left-shift and
7220 right-shift behavior when checking for time stamp overflow.
7221
7222 * editfns.c (time_overflow): New function, refactoring common code.
7223 (Fformat_time_string, Fdecode_time, Fencode_time):
7224 (Fcurrent_time_string): Use it.
7225
7226 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7227 * dired.c (make_time): Move to ...
7228 * editfns.c (make_time): ... here.
7229 * systime.h: Note the move.
7230
7231 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7232
7233 * fringe.c (update_window_fringes): Remove unused variables.
7234
7235 * unexmacosx.c (copy_data_segment): Also copy __got section.
7236 (Bug#8223)
7237
7238 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7239
7240 * termcap.c [MSDOS]: Include "msdos.h".
7241 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7242 Constify `char *' arguments and their references according to
7243 prototypes in tparam.h.
7244
7245 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7246
7247 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7248 Adapt all references accordingly.
7249
7250 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7251
7252 2011-03-11 Tom Tromey <tromey@redhat.com>
7253
7254 * buffer.c (syms_of_buffer): Remove obsolete comment.
7255
7256 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7257
7258 * termhooks.h (encode_terminal_code): Declare prototype.
7259
7260 * msdos.c (encode_terminal_code): Don't declare prototype.
7261
7262 * term.c (encode_terminal_code): Now external again, used by
7263 w32console.c and msdos.c.
7264
7265 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7266 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7267
7268 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7269
7270 Fix some minor problems found by GCC 4.5.2's static checks.
7271
7272 * fringe.c (update_window_fringes): Mark locals as initialized
7273 (Bug#8227).
7274 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7275
7276 * alloc.c (mark_fringe_data): Move decl from here ...
7277 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7278 to check its interface.
7279 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7280
7281 * fontset.c (free_realized_fontset): Now static.
7282 (Fset_fontset_font): Rename local to avoid shadowing.
7283 (fontset_font): Mark local as initialized.
7284 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7285
7286 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7287
7288 * xselect.c (x_disown_buffer_selections): Remove; not used.
7289 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7290 (x_own_selection, Fx_disown_selection_internal): Rename locals
7291 to avoid shadowing.
7292 (x_handle_dnd_message): Remove local to avoid shadowing.
7293
7294 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7295 so that the caller can use some name other than gcpro1.
7296 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7297 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7298 (Fx_backspace_delete_keys_p):
7299 Use them to avoid shadowing, and rename vars to avoid shadowing.
7300 (x_decode_color, x_set_name, x_window): Now static.
7301 (Fx_create_frame): Add braces to silence GCC warning.
7302 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7303 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7304 Remove unused locals.
7305 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7306 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7307 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7308 macros.
7309
7310 * xterm.h (x_mouse_leave): New decl.
7311
7312 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7313 Remove unused functions.
7314 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7315 (x_calc_absolute_position): Now static.
7316 (XTread_socket): Don't define label "out" unless it's used.
7317 Don't declare local "event" unless it's used.
7318 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7319 unless they are used.
7320 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7321 (x_fatal_error_signal): Remove; not used.
7322 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7323 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7324 (x_error_catcher, x_connection_closed, x_error_handler):
7325 (x_error_quitter, xembed_send_message, x_iconify_frame):
7326 (my_log_handler): Rename locals to avoid shadowing.
7327 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7328 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7329
7330 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7331 Rename or move locals to avoid shadowing.
7332 (tty_defined_color, merge_face_heights): Now static.
7333 (free_realized_faces_for_fontset): Remove; not used.
7334 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7335 does not deduce is never used uninitialized.
7336 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7337 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7338
7339 * terminal.c (store_terminal_param): Now static.
7340
7341 * xmenu.c (menu_highlight_callback): Now static.
7342 (set_frame_menubar): Remove unused local.
7343 (xmenu_show): Rename parameter to avoid shadowing.
7344 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7345 since they might point to immutable storage.
7346 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7347 since it's unused otherwise.
7348
7349 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7350 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7351 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7352 avoids a gcc -Wuninitialized diagnostic.
7353 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7354 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7355 does not deduce are never used uninitialized.
7356
7357 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7358
7359 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7360 * window.c (window_loop, size_window):
7361 (run_window_configuration_change_hook, enlarge_window): Likewise.
7362
7363 * window.c (display_buffer): Now static.
7364 (size_window): Mark variables that gcc -Wuninitialized
7365 does not deduce are never used uninitialized.
7366 * window.h (check_all_windows): New decl, to forestall
7367 gcc -Wmissing-prototypes diagnostic.
7368 * dispextern.h (bidi_dump_cached_states): Likewise.
7369
7370 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7371 shadowing.
7372 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7373 Include <limits.h>.
7374 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7375 and to avoid gcc -Wuninitialized warning.
7376 (load_charset_map): Mark variables that gcc -Wuninitialized
7377 does not deduce are never used uninitialized.
7378 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7379
7380 * coding.c (coding_set_source, coding_set_destination):
7381 Use "else { /* comment */ }" rather than "else /* comment */;"
7382 for clarity, and to avoid gcc -Wempty-body warning.
7383 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7384 a block, when the outer 'i' will do.
7385 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7386 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7387 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7388 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7389 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7390 Rename locals to avoid shadowing.
7391 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7392 * coding.c (emacs_mule_char, encode_invocation_designation):
7393 Now static, since they're not used elsewhere.
7394 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7395 (decode_coding_object, encode_coding_object, detect_coding_system):
7396 (decode_coding_emacs_mule): Mark variables that gcc
7397 -Wuninitialized does not deduce are never used uninitialized.
7398 (detect_coding_iso_2022): Initialize a local variable that might
7399 be used uninitialized. Leave a FIXME because it's not clear that
7400 this initialization is needed. (Bug#8211)
7401 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7402 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7403 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7404 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7405 Remove unused macros.
7406
7407 * category.c (hash_get_category_set): Remove unused local var.
7408 (copy_category_table): Now static, since it's not used elsewhere.
7409 * character.c (string_count_byte8): Likewise.
7410
7411 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7412 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7413
7414 * chartab.c (copy_sub_char_table): Now static, since it's not used
7415 elsewhere.
7416 (sub_char_table_ref_and_range, char_table_ref_and_range):
7417 Rename locals to avoid shadowing.
7418 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7419
7420 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7421 (BIDI_BOB): Remove unused macro.
7422
7423 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7424 deduce are never used uninitialized.
7425 * term.c (encode_terminal_code): Likewise.
7426
7427 * term.c (encode_terminal_code): Now static. Remove unused local.
7428
7429 * tparam.h: New file.
7430 * term.c, tparam.h: Include it.
7431 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7432 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7433 Move these decls to tparam.h, and make them agree with what
7434 is actually in tparam.c. The previous trick of using incompatible
7435 decls in different modules does not conform to the C standard.
7436 All callers of tparam changed to use tparam's actual API.
7437 * tparam.c (tparam1, tparam, tgoto):
7438 Use const pointers where appropriate.
7439
7440 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7441 * cm.h (struct cm): Likewise.
7442 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7443 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7444 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7445 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7446 (turn_on_face, init_tty): Likewise.
7447 * termchar.h (struct tty_display_info): Likewise.
7448
7449 * term.c (term_mouse_position): Rename local to avoid shadowing.
7450
7451 * alloc.c (mark_ttys): Move decl from here ...
7452 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7453
7454 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7455
7456 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7457
7458 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7459
7460 * search.c (compile_pattern_1): Remove argument regp, unused since
7461 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7462 (compile_pattern): Don't pass it.
7463
7464 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7465
7466 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7467 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7468 for ! HAVE_GTK3.
7469 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7470
7471 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7472
7473 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7474 gdk_window_get_screen, gdk_window_get_geometry,
7475 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7476 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7477 (xg_get_pixbuf_from_pixmap): New function.
7478 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7479 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7480 Call xg_get_pixbuf_from_pixmap instead of
7481 gdk_pixbuf_get_from_drawable.
7482 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7483 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7484 (xg_check_special_colors): Use GtkStyleContext and its functions
7485 for HAVE_GTK3.
7486 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7487 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7488 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7489 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7490 Call gtk_widget_get_preferred_size.
7491 (xg_frame_resized): gdk_window_get_geometry only takes 5
7492 parameters.
7493 (xg_win_to_widget, xg_event_is_for_menubar):
7494 Call gdk_x11_window_lookup_for_display.
7495 (xg_set_widget_bg): New function.
7496 (delete_cb): New function.
7497 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7498 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7499 (xg_set_background_color): Call xg_set_widget_bg.
7500 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7501 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7502 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7503 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7504 if ! HAVE_GTK3.
7505 (update_frame_tool_bar): Call gtk_widget_hide.
7506 (xg_initialize): Use GDK_KEY_g.
7507
7508 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7509 if ! HAVE_GTK3
7510 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7511
7512 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7513 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7514 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7515
7516 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7517
7518 * w32xfns.c (select_palette): Check success of RealizePalette against
7519 GDI_ERROR, not zero.
7520
7521 See ChangeLog.11 for earlier changes.
7522
7523 ;; Local Variables:
7524 ;; coding: utf-8
7525 ;; End:
7526
7527 Copyright (C) 2011 Free Software Foundation, Inc.
7528
7529 This file is part of GNU Emacs.
7530
7531 GNU Emacs is free software: you can redistribute it and/or modify
7532 it under the terms of the GNU General Public License as published by
7533 the Free Software Foundation, either version 3 of the License, or
7534 (at your option) any later version.
7535
7536 GNU Emacs is distributed in the hope that it will be useful,
7537 but WITHOUT ANY WARRANTY; without even the implied warranty of
7538 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7539 GNU General Public License for more details.
7540
7541 You should have received a copy of the GNU General Public License
7542 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.