Fix pos-visible-in-window-p for zero-column composed character.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4 coordinates reported by pos-visible-in-window-p for a composed
5 character in column zero.
6
7 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8
9 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
10
11 2011-08-22 Eli Zaretskii <eliz@gnu.org>
12
13 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
14 consider it a hit if to_charpos is anywhere in the range of the
15 composed buffer positions.
16
17 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
18
19 * image.c (gif_load): Don't assume that each subimage has the same
20 dimensions as the base image. Handle disposal method that is
21 "undefined" by the gif spec (Bug#9335).
22
23 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
24
25 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
26 (Fcondition_case): Document `debug' symbol in error handler.
27
28 2011-08-19 Eli Zaretskii <eliz@gnu.org>
29
30 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
31 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
32 from an Org mode buffer to a Speedbar frame.
33
34 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
35 a composition, take its buffer position from IT->cmp_it.charpos.
36 Fixes cursor positioning at the beginning of a line that begins
37 with a composed character.
38
39 2011-08-18 Eli Zaretskii <eliz@gnu.org>
40
41 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
42 character bidirectional type, use STRONG_L instead. Fixes crashes
43 in a buffer produced by `describe-categories'.
44
45 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
46 members before the level stack, so they would be saved and
47 restored when copying iterator state. Fixes incorrect reordering
48 around TABs covered by display properties.
49
50 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
51
52 * process.c (Fnetwork_interface_list): Correctly determine buffer
53 size.
54
55 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
56
57 * eval.c (internal_condition_case, internal_condition_case_1)
58 (internal_condition_case_2, internal_condition_case_n):
59 Remove unnecessary aborts (Bug#9081).
60
61 2011-08-17 Eli Zaretskii <eliz@gnu.org>
62
63 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
64 has no `load' handler, try opening the file locally. (Bug#9311)
65
66 2011-08-16 Ken Brown <kbrown@cornell.edu>
67
68 * gmalloc.c: Expand comment.
69
70 2011-08-16 Eli Zaretskii <eliz@gnu.org>
71
72 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
73 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
74
75 2011-08-16 Ken Brown <kbrown@cornell.edu>
76
77 Fix memory allocation problems in Cygwin build (Bug#9273).
78
79 * unexcw.c ( __malloc_initialized): Declare external variable.
80 (fixup_executable): Force the dumped emacs to reinitialize malloc.
81
82 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
83 New variables.
84 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
85 dumped emacs.
86 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
87 in the static heap.
88 [CYGWIN] (special_realloc): New function.
89 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
90 requests to realloc storage in the static heap.
91
92 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
93
94 * bidi.c (bidi_initialize): Remove unused local.
95
96 2011-08-15 Eli Zaretskii <eliz@gnu.org>
97
98 * biditype.h: File removed.
99
100 * bidimirror.h: File removed.
101
102 * deps.mk (bidi.o): Remove biditype.h and
103 bidimirror.h.
104
105 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
106 bidimirror.h.
107
108 * dispextern.h: Fix a typo in the comment to bidi_type_t.
109
110 * chartab.c: Improve commentary for the uniprop_table API.
111
112 * bidi.c (bidi_paragraph_init): Support zero value of
113 bidi_ignore_explicit_marks_for_paragraph_level.
114 (bidi_initialize): Use uniprop_table instead of including
115 biditype.h and bidimirror.h.
116
117 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
118 coordinates of the iterator when restoring from ppos_it.
119 (Bug#9296)
120
121 2011-08-14 Kenichi Handa <handa@m17n.org>
122
123 * process.c (create_process): Call setup_process_coding_systems
124 after the pid of the process is set to -1 (Bug#8162).
125
126 2011-08-14 Eli Zaretskii <eliz@gnu.org>
127
128 * xdisp.c (move_it_in_display_line_to): Don't invoke
129 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
130 ppos_it. Fixes vertical cursor motion when line beginning is
131 covered by an image. (Bug#9296)
132
133 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
134
135 * nsterm.h (ns_run_ascript): Declare.
136 (NSAPP_DATA2_RUNASSCRIPT): Define.
137
138 * nsfns.m (as_script, as_result, as_status): New static variables.
139 (ns_run_ascript): New function.
140 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
141 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
142 the event loop. Get status from as_status (Bug#7276).
143
144 * nsterm.m (sendEvent): If event is NSApplicationDefined and
145 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
146 the event loop (Bug#7276).
147
148 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
149
150 * gnutls.c (QCgnutls_bootprop_priority)
151 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
152 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
153 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
154 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
155 (QCgnutls_bootprop_verify_hostname_error)
156 (QCgnutls_bootprop_callbacks_verify): Rename from
157 Qgnutls_bootprop_..., all uses changed.
158
159 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
160 uses changed.
161
162 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
163
164 * xfaces.c (Qframe_set_background_mode): Now static.
165 * dispextern.h (Qframe_set_background_mode): Remove decl.
166
167 * process.c (Fnetwork_interface_info): Declare local only if needed.
168
169 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
170
171 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
172 (Fnetwork_interface_list): Allocate in increments of bytes instead
173 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
174 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
175 sockaddr.
176 (struct ifflag_def): notrailers is smart on OSX.
177 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
178 Get hardware address with getifaddrs if available.
179
180 2011-08-12 Eli Zaretskii <eliz@gnu.org>
181
182 * xdisp.c (iterate_out_of_display_property): xassert that
183 IT->position is set to within IT->object's boundaries. Break from
184 the loop as soon as EOB is reached; avoids infloops in redisplay
185 when IT->position is set up wrongly due to some bug.
186 Set IT->current to match the bidi iterator unconditionally.
187 (push_display_prop): Allow GET_FROM_STRING as IT->method on
188 entry. Force push_it to save on the stack the current
189 buffer/string position, to be restored by pop_it. Fix flags in
190 the iterator structure wrt the object coming from a display
191 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
192 properties. (Bug#9284)
193
194 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
195
196 * fontset.c (fontset_get_font_group): Add proper type checks.
197 (Bug#9172)
198
199 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
200
201 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
202 and LC_VERSION_MIN_MACOSX.
203 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
204 (dump_it) [LC_FUNCTION_STARTS]: Use it.
205
206 2011-08-08 Eli Zaretskii <eliz@gnu.org>
207
208 * xdisp.c (forward_to_next_line_start): Allow to use the
209 no-display-properties-and-no-overlays under bidi display.
210 Set disp_pos in the bidi iterator to avoid searches for display
211 properties and overlays.
212
213 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
214
215 * editfns.c (Fset_time_zone_rule): Document relationship with the
216 setenv function.
217
218 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
219 the font entity extracted from the cache (Bug#8109).
220
221 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
222
223 * composite.c (autocmp_chars): Don't reset point. That is done by
224 restore_point_unwind (Bug#5984).
225
226 2011-08-07 Juri Linkov <juri@jurta.org>
227
228 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
229 to show the arg `TIME' instead of `TIMEVAL'.
230
231 2011-08-06 Eli Zaretskii <eliz@gnu.org>
232
233 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
234 display property strides EOL and includes a newline, as in
235 longlines-mode. (Bug#9254)
236 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
237 word-wrap under bidirectional display. (Bug#9224)
238
239 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
240 is non-zero, even if the data buffer is NULL. Fixes a crash in
241 vertical-motion with longlines-mode. (Bug#9254)
242
243 2011-08-05 Eli Zaretskii <eliz@gnu.org>
244
245 * bidi.c <bidi_cache_total_alloc>: Now static.
246 (bidi_initialize): Initialize bidi_cache_total_alloc.
247
248 * xdisp.c (display_line): Release buffer allocated for shelved bidi
249 cache. (Bug#9221)
250
251 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
252 amount allocated this far in `bidi_cache_total_alloc'.
253 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
254 non-zero, only free the data buffer without restoring the cache
255 contents. All callers changed.
256
257 * dispextern.h (bidi_unshelve_cache): Update prototype.
258
259 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
260 (move_it_in_display_line, move_it_to)
261 (move_it_vertically_backward, move_it_by_lines): Replace the call
262 to xfree to an equivalent call to bidi_unshelve_cache.
263 (move_it_in_display_line_to): Fix logic of returning
264 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
265
266 2011-08-05 Eli Zaretskii <eliz@gnu.org>
267
268 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
269 came from a string character with a `cursor' property. (Bug#9229)
270
271 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
272
273 * Makefile.in (LIB_PTHREAD): New variable.
274 (LIBES): Add LIB_PTHREAD (Bug#9216).
275
276 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
277 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
278
279 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
280
281 * regex.c (re_iswctype): Remove some redundant boolean
282 conversions.
283
284 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
285
286 * xterm.c (x_find_topmost_parent): New function.
287 (x_set_frame_alpha): Find topmost parent window with
288 x_find_topmost_parent and set the property there also (bug#9181).
289 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
290
291 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
292
293 * callproc.c (Fcall_process): Avoid vfork clobbering
294 the local vars buffer, coding_systems, current_dir.
295
296 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
297
298 * keymap.c (Fmake_composed_keymap): Move to subr.el.
299
300 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
301
302 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
303 so that it is not optimized away.
304
305 * xdisp.c (compute_display_string_pos): Remove unused local.
306
307 2011-08-02 Eli Zaretskii <eliz@gnu.org>
308
309 Fix slow cursor motion and scrolling in large buffers with
310 selective display, like Org Mode buffers. (Bug#9218)
311
312 * dispextern.h (struct bidi_it): New member disp_prop_p.
313
314 * xdisp.c: Remove one-slot cache of display string positions.
315 (compute_display_string_pos): Accept an additional argument
316 DISP_PROP_P; callers changed. Scan at most 5K characters forward
317 for a display string or property. If found, set DISP_PROP_P
318 non-zero.
319
320 * bidi.c (bidi_fetch_char): Accept an additional argument
321 DISP_PROP_P, and pass it to compute_display_string_pos.
322 Only handle text covered by a display string if DISP_PROP_P is returned
323 non-zero. All callers of bidi_fetch_char changed.
324
325 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
326
327 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
328
329 2010-12-03 Don March <don@ohspite.net>
330
331 * keymap.c (Fdefine_key): Fix non-prefix key error message when
332 last character M-[char] is translated to ESC [char] (bug#7541).
333
334 2011-08-02 Kenichi Handa <handa@m17n.org>
335
336 * lisp.h (uniprop_table): Extern it.
337
338 * chartab.c (uniprop_table): Make it non-static.
339
340 2011-08-01 Eli Zaretskii <eliz@gnu.org>
341
342 * xdisp.c (forward_to_next_line_start): Accept additional argument
343 BIDI_IT_PREV, and store into it the state of the bidi iterator had
344 on the newline.
345 (reseat_at_next_visible_line_start): Use the bidi iterator state
346 returned by forward_to_next_line_start to restore the state of
347 it->bidi_it after backing up to previous newline. (Bug#9212)
348
349 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
350
351 * regex.c (re_comp): Protoize.
352 (re_exec): Fix return type.
353 (regexec): Fix type of `ret'. (Bug#9203)
354
355 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
356
357 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
358 This is needed if max-image-size is a floating-point number.
359
360 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
361
362 * print.c (print_object): Print empty symbol as ##.
363
364 * lread.c (read1): Read ## as empty symbol.
365
366 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
367
368 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
369 setting frame foreground color (Bug#9175).
370 (x_set_background_color): Likewise.
371
372 * nsmenu.m (-setText): Size tooltip dimensions precisely to
373 contents (Bug#9176).
374 (EmacsTooltip -init): Remove bezels and add shadows to
375 tooltip windows.
376
377 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
378 or scroll bar (Bug#8470).
379
380 * nsfont.m (nsfont_open): Remove assignment to voffset and
381 unnecessary vars hshink, expand, hd, full_height, min_height.
382 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
383
384 * nsterm.h (nsfont_info): Remove voffset field.
385
386 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
387
388 Implement strike-through and overline on NextStep (Bug#8863).
389
390 * nsfont.m (nsfont_open): Use underline position provided by font,
391 instead of hard-coded value of 2.
392 (nsfont_draw): Call ns_draw_text_decoration instead.
393
394 * nsterm.h: Add declaration for ns_draw_text_decoration.
395
396 * nsterm.m (ns_draw_text_decoration): New function for drawing
397 underline, overline, and strike-through.
398 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
399 ns_draw_text_decoration. Change treatment of cursor drawing to
400 accomodate underlining, etc.
401
402 2011-07-28 Eli Zaretskii <eliz@gnu.org>
403
404 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
405 default.
406
407 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
408
409 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
410 Without this fix, if a signal arrives just after memory fills up,
411 'malloc' might be invoked reentrantly.
412
413 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
414 In other words, assume that every image size is allowed, on non-X
415 hosts. This assumption is probably wrong, but it lets Emacs compile.
416
417 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
418
419 * regex.c (re_iswctype): Convert return values to boolean.
420
421 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
422
423 * xdisp.c (compute_display_string_pos): Don't use cached display
424 string position if the buffer had its restriction changed.
425 (Bug#9184)
426
427 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
428
429 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
430
431 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
432
433 Integer signedness and overflow and related fixes. (Bug#9079)
434
435 * bidi.c: Integer size and overflow fixes.
436 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
437 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
438 (bidi_cache_find_level_change, bidi_cache_ensure_space)
439 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
440 (bidi_find_other_level_edge):
441 Use ptrdiff_t instead of EMACS_INT where either will do.
442 This works better on 32-bit hosts configured --with-wide-int.
443 (bidi_cache_ensure_space): Check for size-calculation overflow.
444 Use % rather than repeated addition, for better worst-case speed.
445 Don't set bidi_cache_size until after xrealloc returns, because it
446 might not return.
447 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
448 (bidi_cache_ensure_space): Also check that the bidi cache size
449 does not exceed that of the largest Lisp string or buffer. See Eli
450 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
451
452 * alloc.c (__malloc_size_t): Remove.
453 All uses replaced by size_t. See Andreas Schwab's note
454 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
455
456 * image.c: Improve checking for integer overflow.
457 (check_image_size): Assume that f is nonnull, since
458 it is always nonnull in practice. This is one less thing to
459 worry about when checking for integer overflow later.
460 (x_check_image_size): New function, which checks for integer
461 overflow issues inside X.
462 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
463 This removes the need for a memory_full check.
464 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
465 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
466 (xbm_read_bitmap_data): Change locals back to 'int', since
467 their values must fit in 'int'.
468 (xpm_load_image, png_load, tiff_load):
469 Invoke x_create_x_image_and_pixmap earlier,
470 to avoid much needless work if the image is too large.
471 (tiff_load): Treat overly large images as if
472 x_create_x_image_and_pixmap failed, not as malloc failures.
473 (gs_load): Use x_check_image_size.
474
475 * gtkutil.c: Omit integer casts.
476 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
477 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
478
479 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
480
481 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
482 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
483 would wrongly return t on a 64-bit host.
484
485 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
486 The plain *_OVERFLOW macros run afoul of GCC bug 49705
487 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
488 and therefore cause GCC to emit a bogus diagnostic in some cases.
489
490 * image.c: Integer signedness and overflow and related fixes.
491 This is not an exhaustive set of fixes, but it's time to
492 record what I've got.
493 (lookup_pixel_color, check_image_size): Remove redundant decls.
494 (check_image_size): Don't assume that arbitrary EMACS_INT values
495 fit in 'int', or that arbitrary 'double' values fit in 'int'.
496 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
497 (tiff_load, imagemagick_load_image):
498 Check for overflow in size calculations.
499 (x_create_x_image_and_pixmap): Remove unnecessary test for
500 xmalloc returning NULL; that can't happen.
501 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
502 (xpm_color_bucket): Use better integer hashing function.
503 (xpm_cache_color): Don't possibly over-allocate memory.
504 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
505 (gif_memory_source):
506 Use ptrdiff_t, not int or size_t, to record sizes.
507 (png_load): Don't assume values greater than 2**31 fit in 'int'.
508 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
509 either works, as we prefer signed integers.
510 (tiff_read_from_memory, tiff_write_from_memory):
511 Return tsize_t, not size_t, since that's what the TIFF API wants.
512 (tiff_read_from_memory): Don't fail simply because the read would
513 go past EOF; instead, return a short read.
514 (tiff_load): Omit no-longer-needed casts.
515 (Fimagemagick_types): Don't assume size fits into 'int'.
516
517 Improve hashing quality when configured --with-wide-int.
518 * fns.c (hash_string): New function, taken from sxhash_string.
519 Do not discard information about ASCII character case; this
520 discarding is no longer needed.
521 (sxhash-string): Use it. Change sig to match it. Caller changed.
522 * lisp.h: Declare it.
523 * lread.c (hash_string): Remove, since we now use fns.c's version.
524 The fns.c version returns a wider integer if --with-wide-int is
525 specified, so this should help the quality of the hashing a bit.
526
527 * emacs.c: Integer overflow minor fix.
528 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
529 Define only if GNU_LINUX.
530 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
531
532 * dispnew.c: Integer signedness and overflow fixes.
533 Remove unnecessary forward decls, that were a maintenance hassle.
534 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
535 All uses changed.
536 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
537 (scrolling_window): Use ptrdiff_t, not int, for byte count.
538 (prepare_desired_row, line_draw_cost):
539 Use int, not unsigned, where either works.
540 (save_current_matrix, restore_current_matrix):
541 Use ptrdiff_t, not size_t, where either works.
542 (init_display): Check for overflow more accurately, and without
543 relying on undefined behavior.
544
545 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
546 Remove, replacing with the new symbols in lisp.h. All uses changed.
547 * fileio.c (make_temp_name):
548 * filelock.c (lock_file_1, lock_file):
549 * xdisp.c (message_dolog):
550 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
551 Use pMd etc. instead.
552 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
553 replacing the pWIDE etc. symbols removed from editfns.c.
554
555 * keyboard.h (num_input_events): Now uintmax_t.
556 This is (very slightly) less likely to mess up due to wraparound.
557 All uses changed.
558
559 * buffer.c: Integer signedness fixes.
560 (alloc_buffer_text, enlarge_buffer_text):
561 Use ptrdiff_t rather than size_t when either will do, as we prefer
562 signed integers.
563
564 * alloc.c: Integer signedness and overflow fixes.
565 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
566 (__malloc_size_t): Default to size_t, not to int.
567 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
568 (Fgarbage_collect, mark_object_loop_halt, mark_object):
569 Prefer ptrdiff_t to size_t when either would do, as we prefer
570 signed integers.
571 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
572 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
573 Now const. Initialize with values that are in range even if char
574 is signed.
575 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
576 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
577 These functions do the right thing with sizes > 2**32.
578 (check_depth): Now ptrdiff_t, not int.
579 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
580 Adjust to new way of storing sizes. Check for size overflow bugs
581 in rest of code.
582 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
583 slightly wrong anyway, as it missed one instance of
584 XMALLOC_OVERRUN_CHECK_OVERHEAD.
585 (refill_memory_reserve): Omit needless cast to size_t.
586 (mark_object_loop_halt): Mark as externally visible.
587
588 * xselect.c: Integer signedness and overflow fixes.
589 (Fx_register_dnd_atom, x_handle_dnd_message):
590 Use ptrdiff_t, not size_t, since we prefer signed.
591 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
592 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
593 x_dnd_atoms_size and x_dnd_atoms_length.
594
595 * doprnt.c: Prefer signed to unsigned when either works.
596 * eval.c (verror):
597 * doprnt.c (doprnt):
598 * lisp.h (doprnt):
599 * xdisp.c (vmessage):
600 Use ptrdiff_t, not size_t, when using or implementing doprnt,
601 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
602 prefer signed arithmetic to avoid comparison confusion.
603 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
604 but is a bit tricky.
605
606 Assume freestanding C89 headers, string.h, stdlib.h.
607 * data.c, doprnt.c, floatfns.c, print.c:
608 Include float.h unconditionally.
609 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
610 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
611 * regex.c: Likewise for stddef.h, string.h.
612 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
613 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
614 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
615 (STDC_HEADERS): Remove obsolete defines.
616 * sysdep.c: Include limits.h unconditionally.
617
618 Assume support for memcmp, memcpy, memmove, memset.
619 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
620 * regex.c (memcmp, memcpy):
621 Remove; we assume C89 now.
622
623 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
624 (__malloc_safe_bcopy): Remove; no longer needed.
625
626 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
627 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
628 well either way, and we prefer signed to unsigned.
629
630 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
631
632 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
633 closes the connection while we're reading (bug#9182).
634
635 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
636
637 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
638 are specified (Bug#9168).
639
640 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
641
642 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
643 Found by GCC static checking and --with-wide-int on a 32-bit host.
644
645 2011-07-25 Eli Zaretskii <eliz@gnu.org>
646
647 * xdisp.c (compute_display_string_pos): Fix logic of caching
648 previous display string position. Initialize cached_prev_pos to
649 -1. Fixes slow-down at the beginning of a buffer.
650
651 2011-07-24 Eli Zaretskii <eliz@gnu.org>
652
653 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
654 for attrs[LFACE_FONTSET_INDEX].
655
656 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
657
658 * xml.c (parse_region): Remove unused local
659 that was recently introduced.
660
661 2011-07-23 Eli Zaretskii <eliz@gnu.org>
662
663 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
664 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
665
666 * xdisp.c (move_it_in_display_line_to): Record the best matching
667 position for TO_CHARPOS while scanning the line, and restore it on
668 exit if none of the characters scanned was an exact match.
669 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
670 when exact match is impossible due to invisible text, and the
671 lines are truncated.
672
673 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
674
675 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
676 for OSX >= 10.7.
677
678 2011-07-22 Eli Zaretskii <eliz@gnu.org>
679
680 Fix a significant slow-down of cursor motion with C-n, C-p,
681 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
682 auto-repeat under bidi redisplay in fontified buffers.
683 * xdisp.c (compute_stop_pos_backwards): New function.
684 (next_element_from_buffer): Call compute_stop_pos_backwards to
685 find a suitable prev_stop when we find ourselves before
686 base_level_stop.
687 (reseat): Don't look for prev_stop, as that could mean a very long
688 run.
689 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
690 <cached_disp_overlay_modiff>: Cache for last found display string
691 position.
692 (compute_display_string_pos): Return the cached position if asked
693 about the same buffer in the same area of character positions, and
694 the buffer wasn't changed since the time the display string
695 position was cached.
696
697 2011-07-22 Eli Zaretskii <eliz@gnu.org>
698
699 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
700 is an integer, which is important for empty lines. (Bug#9149)
701
702 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
703
704 * frame.c (Fmodify_frame_parameters): In tty case, update the
705 default face if necessary (Bug#4238).
706
707 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
708
709 * editfns.c (Fstring_to_char): No need to explain what a character
710 is in the docstring (Bug#6576).
711
712 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
713
714 * xml.c (parse_region): Make sure we always return a tree.
715
716 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
717
718 * xml.c (parse_region): If a document contains only comments,
719 return that, too.
720
721 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
722
723 * xml.c (make_dom): Return comments, too.
724
725 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
726
727 Port to OpenBSD.
728 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
729 and the surrounding thread.
730 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
731 rather than fgets, and retry after EINTR. Otherwise, 'emacs
732 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
733 timer goes off.
734 * s/openbsd.h (BROKEN_SIGIO): Define.
735 * unexelf.c (unexec) [__OpenBSD__]:
736 Don't update the .mdebug section of the Alpha COFF symbol table.
737
738 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
739
740 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
741 (bug#8460).
742
743 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
744
745 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
746 This fixes some race conditions on the permissions of any newly
747 created file.
748
749 * alloc.c (valid_pointer_p): Use pipe, not open.
750 This fixes some permissions issues when debugging.
751
752 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
753 If fchown fails to set both uid and gid, try to set just gid,
754 as that is sometimes allowed. Adjust the file's mode to eliminate
755 setuid or setgid bits that are inappropriate if fchown fails.
756
757 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
758
759 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
760 to compare Lisp_Objects.
761 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
762 global_gnutls_log_level, don't mistake it for a Lisp_Object.
763 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
764
765 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
766
767 * lread.c (read_integer): Unread even EOF character.
768 (read1): Likewise. Properly record start position of symbol.
769
770 * lread.c (read1): Read `#:' as empty uninterned symbol if no
771 symbol character follows.
772
773 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
774
775 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
776 This works around a problem with the previous change to Fcopy_file.
777 Recent glibc declares fchown with __attribute__((warn_unused_result)),
778 and without this change, GCC might complain about discarding
779 fchown's return value.
780
781 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
782
783 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
784
785 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
786
787 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
788
789 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
790
791 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
792 it's used from the C level.
793
794 * process.c: Use the same condition for POLL_FOR_INPUT in both
795 keyboard.c and process.c (bug#1858).
796
797 2011-07-09 Lawrence Mitchell <wence@gmx.li>
798
799 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
800 (Fgnutls_boot): Use it.
801
802 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
803
804 * doc.c (Fsubstitute_command_keys): Revert last change.
805
806 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
807
808 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
809 quotes the next character, and doesn't affect other longer
810 sequences (bug#8935).
811
812 * lread.c (syms_of_lread): Clarify that is isn't only
813 `eval-buffer' and `eval-defun' that's affected by
814 `lexical-binding' (bug#8460).
815
816 2011-07-15 Eli Zaretskii <eliz@gnu.org>
817
818 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
819 bidi redisplay when a line includes both an image and is
820 truncated.
821
822 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
823
824 Fix minor problems found by static checking.
825 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
826 (elsz): Now a signed constant, not a size_t var. We prefer signed
827 types to unsigned, to avoid integer comparison confusion. Without
828 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
829 "cannot optimize loop, the loop counter may overflow", a symptom
830 of the confusion.
831 * indent.c (Fvertical_motion): Mark locals as initialized.
832 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
833
834 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
835
836 * search.c (Fre_search_backward): Mention `case-fold-search' in
837 all the re_search_* functions (bug#8138).
838
839 * keyboard.c (Fopen_dribble_file): Document when the file is
840 closed (bug#8056).
841
842 2011-07-14 Eli Zaretskii <eliz@gnu.org>
843
844 * bidi.c (bidi_dump_cached_states): Fix format of displaying
845 bidi_cache_idx.
846
847 Support bidi reordering of display and overlay strings.
848 * xdisp.c (compute_display_string_pos)
849 (compute_display_string_end): Accept additional argument STRING.
850 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
851 (reseat_to_string): Initialize bidi_it->string.s and
852 bidi_it->string.schars.
853 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
854 NULL (avoids a crash in bidi_paragraph_init).
855 Initialize itb.string.lstring.
856 (init_iterator): Call bidi_init_it only of a valid
857 buffer position was specified. Initialize paragraph_embedding to
858 L2R.
859 (reseat_to_string): Initialize the bidi iterator.
860 (display_string): If we need to ignore text properties of
861 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
862 original value of -1 will not work with bidi.)
863 (compute_display_string_pos): First arg is now struct
864 `text_pos *'; all callers changed. Support display properties on
865 Lisp strings.
866 (compute_display_string_end): Support display properties on Lisp
867 strings.
868 (init_iterator, reseat_1, reseat_to_string): Initialize the
869 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
870 when iterating on a string not from display properties).
871 (compute_display_string_pos, compute_display_string_end):
872 Fix calculation of the object to scan. Fixes an error when using
873 arrow keys.
874 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
875 base_level_stop; instead, set base_level_stop to BEGV.
876 Fixes crashes in vertical-motion.
877 (next_element_from_buffer): Improve commentary for when
878 the iterator is before prev_stop.
879 (init_iterator): Initialize bidi_p from the default value of
880 bidi-display-reordering, not from buffer-local value. Use the
881 buffer-local value only if initializing for buffer iteration.
882 (handle_invisible_prop): Support invisible properties on strings
883 that are being bidi-reordered.
884 (set_iterator_to_next): Support bidi reordering of C strings and
885 Lisp strings.
886 (next_element_from_string): Support bidi reordering of Lisp
887 strings.
888 (handle_stop_backwards): Support Lisp strings as well.
889 (display_string): Support display of R2L glyph rows.
890 Use IT_STRING_CHARPOS when displaying from a Lisp string.
891 (init_iterator): Don't initialize it->bidi_p for strings
892 here.
893 (reseat_to_string): Initialize it->bidi_p for strings here.
894 (next_element_from_string, next_element_from_c_string)
895 (next_element_from_buffer): Add xassert's for correspondence
896 between IT's object being iterated and it->bidi_it.string
897 structure.
898 (face_before_or_after_it_pos): Support bidi iteration.
899 (next_element_from_c_string): Handle the case of the first string
900 character that is not the first one in the visual order.
901 (get_visually_first_element): New function, refactored from common
902 parts of next_element_from_buffer, next_element_from_string, and
903 next_element_from_c_string.
904 (tool_bar_lines_needed, redisplay_tool_bar)
905 (display_menu_bar): Force left-to-right direction. Add a FIXME
906 comment for making that be controlled by a user option.
907 (push_it, pop_it): Save and restore the state of the
908 bidi iterator. Save and restore the bidi_p flag.
909 (pop_it): Iterate out of display property for string iteration as
910 well.
911 (iterate_out_of_display_property): Support iteration over strings.
912 (handle_single_display_spec): Set up it->bidi_it for iteration
913 over a display string, and call bidi_init_it.
914 (handle_single_display_spec, next_overlay_string)
915 (get_overlay_strings_1, push_display_prop): Set up the bidi
916 iterator for displaying display or overlay strings.
917 (forward_to_next_line_start): Don't use the shortcut if
918 bidi-iterating.
919 (back_to_previous_visible_line_start): If handle_display_prop
920 pushed the iterator stack, restore the internal state of the bidi
921 iterator by calling bidi_pop_it same number of times.
922 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
923 and we are bidi-iterating, don't decrement the iterator position;
924 instead, set the first_elt flag in the bidi iterator, to produce
925 the same effect.
926 (reseat_1): Remove redundant setting of string_from_display_prop_p.
927 (push_display_prop): xassert that we are iterating a buffer.
928 (push_it, pop_it): Save and restore paragraph_embedding member.
929 (handle_single_display_spec, next_overlay_string)
930 (get_overlay_strings_1, reseat_1, reseat_to_string)
931 (push_display_prop): Set up the `unibyte' member of bidi_it.string
932 correctly. Don't assume unibyte strings are not bidi-reordered.
933 (compute_display_string_pos)
934 (compute_display_string_end): Fix handling the case of C string.
935 (push_it, pop_it): Save and restore from_disp_prop_p.
936 (handle_single_display_spec, push_display_prop): Set the
937 from_disp_prop_p flag.
938 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
939 (pop_it): Call iterate_out_of_display_property only if we are
940 popping after iteration over a string that came from a display
941 property. Fix a typo in popping stretch info. Add an assertion
942 for verifying that the iterator position is in sync with the bidi
943 iterator.
944 (handle_single_display_spec, get_overlay_strings_1)
945 (push_display_prop): Fix initialization of paragraph direction for
946 string when that of the parent object is not yet determined.
947 (reseat_1): Call bidi_init_it to resync the bidi
948 iterator with IT's position. (Bug#7616)
949 (find_row_edges): If ROW->start.pos gives position
950 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
951 (handle_stop, back_to_previous_visible_line_start, reseat_1):
952 Reset the from_disp_prop_p flag.
953 (SAVE_IT, RESTORE_IT): New macros.
954 (pos_visible_p, face_before_or_after_it_pos)
955 (back_to_previous_visible_line_start)
956 (move_it_in_display_line_to, move_it_in_display_line)
957 (move_it_to, move_it_vertically_backward, move_it_by_lines)
958 (try_scrolling, redisplay_window, display_line): Use them when
959 saving a temporary copy of the iterator and restoring it back.
960 (back_to_previous_visible_line_start, reseat_1)
961 (init_iterator): Empty the bidi cache "stack".
962 (move_it_in_display_line_to): If iterator ended up at
963 EOL, but we never saw any buffer positions smaller than
964 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
965 motion in bidi-reordered lines.
966 (move_it_in_display_line_to): Record prev_method and prev_pos
967 immediately before the call to set_iterator_to_next. Fixes cursor
968 motion in bidi-reordered lines with stretch glyphs and strings
969 displayed in margins. (Bug#8133) (Bug#8867)
970 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
971 TO_CHARPOS.
972 (pos_visible_p): Support positions in bidi-reordered lines.
973 Save and restore bidi cache.
974
975 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
976 (bidi_paragraph_info): Delete unused struct.
977 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
978 (bidi_cache_start): New variable.
979 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
980 to zero.
981 (bidi_cache_fetch_state, bidi_cache_search)
982 (bidi_cache_find_level_change, bidi_cache_iterator_state)
983 (bidi_cache_find, bidi_peek_at_next_level)
984 (bidi_level_of_next_char, bidi_find_other_level_edge)
985 (bidi_move_to_visually_next): Compare cache index with
986 bidi_cache_start rather than with zero.
987 (bidi_fetch_char): Accept new argument STRING; all callers
988 changed. Support iteration over a string. Support strings with
989 display properties. Support unibyte strings. Fix the type of
990 `len' according to what STRING_CHAR_AND_LENGTH expects.
991 (bidi_paragraph_init, bidi_resolve_explicit_1)
992 (bidi_resolve_explicit, bidi_resolve_weak)
993 (bidi_level_of_next_char, bidi_move_to_visually_next):
994 Support iteration over a string.
995 (bidi_set_sor_type, bidi_resolve_explicit_1)
996 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
997 can now be zero (for strings); special values 0 and -1 were
998 changed to -1 and -2, respectively.
999 (bidi_char_at_pos): New function.
1000 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1001 Call it instead of FETCH_MULTIBYTE_CHAR.
1002 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1003 initialized to valid values.
1004 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1005 values.
1006 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1007 the test for valid cached positions. Fix the logic for looking up
1008 the sentinel state in the cache. GCPRO the Lisp string we are
1009 iterating.
1010 (bidi_push_it, bidi_pop_it): New functions.
1011 (bidi_initialize): Initialize the bidi cache start stack pointer.
1012 (bidi_cache_ensure_space): New function, refactored from part of
1013 bidi_cache_iterator_state. Don't assume the required size is just
1014 one BIDI_CACHE_CHUNK away.
1015 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1016 (bidi_count_bytes, bidi_char_at_pos): New functions.
1017 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1018 always valid if bidi_cache_idx is valid.
1019 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1020 is valid if it's going to be used.
1021 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1022 (bidi_cache_fetch_state, bidi_cache_search)
1023 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1024 (bidi_cache_iterator_state, bidi_cache_find)
1025 (bidi_find_other_level_edge, bidi_cache_start_stack):
1026 All variables related to cache indices are now EMACS_INT.
1027
1028 * dispextern.h (struct bidi_string_data): New structure.
1029 (struct bidi_it): New member `string'. Make flag members be 1-bit
1030 fields, and put them last in the struct.
1031 (compute_display_string_pos, compute_display_string_end):
1032 Update prototypes.
1033 (bidi_push_it, bidi_pop_it): Add prototypes.
1034 (struct iterator_stack_entry): New members bidi_p,
1035 paragraph_embedding, and from_disp_prop_p.
1036 (struct it): Member bidi_p is now a bit field 1 bit wide.
1037 (bidi_shelve_cache, bidi_unshelve_cache):
1038 Declare prototypes.
1039
1040 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1041 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1042 and vector-like objects.
1043
1044 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1045 cache around display iteration.
1046
1047 * window.c (Fwindow_end, window_scroll_pixel_based)
1048 (displayed_window_lines, Frecenter): Save and restore the bidi
1049 cache around display iteration.
1050
1051 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1052
1053 * editfns.c (Fdelete_region): Clarify the use of the named
1054 parameters (bug#6788).
1055
1056 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1057
1058 * indent.c (Fvertical_motion): Set and restore w->pointm when
1059 saving and restoring the window's buffer (Bug#9006).
1060
1061 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1062
1063 * editfns.c (Fstring_to_char): Clarify just what is returned
1064 (bug#6576). Text by Eli Zaretskii.
1065
1066 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1067
1068 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1069
1070 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1071
1072 * buffer.c (mmap_find): Fix a typo.
1073
1074 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1075
1076 Fix execution of x selection hooks.
1077 * xselect.c (Qx_lost_selection_functions)
1078 (Qx_sent_selection_functions): New vars.
1079 (syms_of_xselect): DEFSYM them.
1080 (x_handle_selection_request): Pass Qx_sent_selection_functions
1081 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1082 (x_handle_selection_clear,x_clear_frame_selections):
1083 Pass Qx_lost_selection_functions rather than
1084 Vx_lost_selection_functions to Frun_hook_with_args.
1085
1086 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1089 The old code sometimes used this field without initializing it.
1090
1091 * alloc.c (gc_sweep): Don't read past end of array.
1092 In theory, the old code could also have corrupted Emacs internals,
1093 though it'd be very unlikely.
1094
1095 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1096
1097 * character.c (Fcharacterp): Don't advertise optional ignored
1098 argument. (Bug#4026)
1099
1100 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1101
1102 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1103 key" (bug#4257).
1104
1105 * window.c (Fset_window_start): Doc fix (bug#4199).
1106 (Fset_window_hscroll): Ditto.
1107
1108 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 Fix minor new problems caught by GCC 4.6.1.
1111 * term.c (init_tty): Remove unused local.
1112 * xsettings.c (store_monospaced_changed): Define this function only
1113 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1114 not used otherwise.
1115
1116 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1117
1118 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1119
1120 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1121
1122 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1123 are the mini-buffer and the echo area (bug#3320).
1124
1125 * term.c (init_tty): Remove support for supdup, c10 and perq
1126 terminals, which are no longer supported (bug#1482).
1127
1128 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1129
1130 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1131
1132 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1133
1134 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1135 for non-popups (Bug#3642).
1136
1137 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1138
1139 * alloc.c (reset_malloc_hooks): Protoize.
1140 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1141 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1142 * cm.c (losecursor): Likewise.
1143 * data.c (fmod): Likewise.
1144 * dispnew.c (swap_glyphs_in_rows): Likewise.
1145 * emacs.c (memory_warning_signal): Likewise.
1146 * floatfns.c (float_error): Likewise.
1147 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1148 (otf_open, font_otf_capability, generate_otf_features)
1149 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1150 Likewise.
1151 * image.c (pbm_read_file): Likewise.
1152 * indent.c (string_display_width): Likewise.
1153 * intervals.c (check_for_interval, search_for_interval)
1154 (inc_interval_count, count_intervals, root_interval)
1155 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1156 * lread.c (defalias): Likewise.
1157 * ralloc.c (r_alloc_check): Likewise.
1158 * regex.c (set_image_of_range_1, set_image_of_range)
1159 (regex_grow_registers): Likewise.
1160 * sysdep.c (strerror): Likewise.
1161 * termcap.c (valid_filename_p, tprint, main): Likewise.
1162 * tparam.c (main): Likewise.
1163 * unexhp9k800.c (run_time_remap, save_data_space)
1164 (update_file_ptrs, read_header, write_header, calculate_checksum)
1165 (copy_file, copy_rest, display_header): Likewise.
1166 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1167 Likewise.
1168 * xdisp.c (check_it): Likewise.
1169 * xfaces.c (register_color, unregister_color, unregister_colors):
1170 Likewise.
1171 * xfns.c (print_fontset_result): Likewise.
1172 * xrdb.c (member, fatal, main): Likewise.
1173
1174 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1175
1176 Fix minor problems found by static checking (Bug#9031).
1177 * chartab.c (char_table_set_range, map_sub_char_table):
1178 Remove unused locals.
1179 (uniprop_table): Now static.
1180 * composite.c (_work_char): Remove unused static var.
1181
1182 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1183
1184 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1185
1186 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1187
1188 * gtkutil.c (qttip_cb): Remove code without function.
1189
1190 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1191
1192 * w32.c (pthread_sigmask): New stub.
1193
1194 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1195
1196 Use pthread_sigmask, not sigprocmask (Bug#9010).
1197 sigprocmask is portable only for single-threaded applications, and
1198 Emacs can be multi-threaded when it uses GTK.
1199 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1200 (LIBES): Use it.
1201 * callproc.c (Fcall_process):
1202 * process.c (create_process):
1203 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1204 Use pthread_sigmask, not sigprocmask.
1205
1206 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1207
1208 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1209 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1210 wrong (Bug#8591).
1211
1212 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1213
1214 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1215 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1216 (xg_hide_tooltip): Fix comment.
1217
1218 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1219 in registerServicesMenuSendTypes.
1220 (validRequestorForSendType): Don't check ns_return_types.
1221
1222 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1223 ns_return_type.
1224
1225 2011-07-08 Jason Rumney <jasonr@gnu.org>
1226
1227 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1228 frame struct members of non-existent frames (Bug#6284).
1229
1230 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1231
1232 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1233 variable firstTime not needed on OSX >= 10.6.
1234 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1235 >= 10.5. Use setKnobProportion, setDoubleValue.
1236
1237 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1238 (MAC_OS_X_VERSION_10_5): Define if not defined.
1239 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1240 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1241 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1242
1243 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1244 cString and lossyCString on OSX >= 10.4
1245
1246 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1247 sizeToFit on OSX >= 10.2.
1248
1249 * nsimage.m (allocInitFromFile): Don't use deprecated method
1250 bestRepresentationForDevice on OSX >= 10.6.
1251
1252 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1253 to avoid warning.
1254
1255 * emacs.c: Declare unexec_init_emacs_zone.
1256
1257 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1258
1259 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1260
1261 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1262 on svcsMenu (Bug#8842).
1263
1264 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1265 ns_return_types.
1266 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1267
1268 * nsterm.m (QUTF8_STRING): Declare.
1269 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1270 (validRequestorForSendType): Return type is (id).
1271 Change indexOfObjectIdenticalTo to indexOfObject.
1272 Check if we have local selection before returning self (Bug#8842).
1273 (writeSelectionToPasteboard): Put local selection into paste board
1274 if we have a local selection (Bug#8842).
1275 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1276
1277 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1278 (ns_get_local_selection): Declare.
1279
1280 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1281
1282 * keymap.c (describe_map_tree): Don't insert a double newline at
1283 the end of the buffer (bug#1169) and return whether we inserted
1284 something.
1285
1286 * callint.c (Fcall_interactively): Change "reading args" to
1287 "providing args" to try to clarify what it does (bug#1010).
1288
1289 2011-07-07 Kenichi Handa <handa@m17n.org>
1290
1291 * composite.c (composition_compute_stop_pos): Ignore a static
1292 composition starting before CHARPOS (Bug#8915).
1293
1294 * xdisp.c (handle_composition_prop): Likewise.
1295
1296 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1297
1298 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1299 (Bug#9015)
1300
1301 2011-07-07 Kenichi Handa <handa@m17n.org>
1302
1303 * character.h (unicode_category_t): New enum type.
1304
1305 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1306 (Qchar_code_property_table): New variable.
1307 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1308 (UNIPROP_COMPRESSED_FORM_P): New macros.
1309 (char_table_ascii): Uncompress the compressed values.
1310 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1311 Uncompress the compressed values.
1312 (sub_char_table_ref_and_range): Likewise.
1313 (char_table_ref_and_range): Uncompress the compressed values.
1314 (sub_char_table_set): New arg is_uniprop. Callers changed.
1315 Uncompress the compressed values.
1316 (sub_char_table_set_range): Args changed. Callers changed.
1317 (char_table_set_range): Adjuted for the above change.
1318 (map_sub_char_table): Delete args default_val and parent. Add arg
1319 top. Give decoded values to a Lisp function.
1320 (map_char_table): Adjust for the above change. Give decoded
1321 values to a Lisp function. Gcpro more variables.
1322 (uniprop_table_uncompress)
1323 (uniprop_decode_value_run_length): New functions.
1324 (uniprop_decoder, uniprop_decoder_count): New variables.
1325 (uniprop_get_decoder, uniprop_encode_value_character)
1326 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1327 New functions.
1328 (uniprop_encoder, uniprop_encoder_count): New variables.
1329 (uniprop_get_encoder, uniprop_table)
1330 (Funicode_property_table_internal, Fget_unicode_property_internal)
1331 (Fput_unicode_property_internal): New functions.
1332 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1333 Sunicode_property_table_internal, Sget_unicode_property_internal,
1334 and Sput_unicode_property_internal. Defvar_lisp
1335 char-code-property-alist.
1336
1337 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1338 Vunicode_category_table.
1339
1340 * font.c (font_range): Adjust for the change of
1341 Vunicode_category_table.
1342
1343 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1344
1345 * m/iris4d.h: Remove file, move contents ...
1346 * s/irix6-5.h: ... here.
1347
1348 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 Remove unportable assumption about struct layout (Bug#8884).
1351 * alloc.c (mark_buffer):
1352 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1353 (clone_per_buffer_values): Don't assume that
1354 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1355 This isn't true in general, and it's particularly not true
1356 if Emacs is configured with --with-wide-int.
1357 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1358 New macros, used in the buffer.c change.
1359
1360 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1361
1362 * xsettings.c: Use both GConf and GSettings if both are available.
1363 (store_config_changed_event): Add comment.
1364 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1365 (store_tool_bar_style_changed): New functions.
1366 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1367 (struct xsettings): Move font inside HAVE_XFT.
1368 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1369 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1370 Move inside HAVE_XFT.
1371 (something_changed_gsettingsCB): Rename from something_changedCB.
1372 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1373 also.
1374 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1375 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1376 (something_changed_gconfCB): Rename from something_changedCB.
1377 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1378 (parse_settings): Move check for font inside HAVE_XFT.
1379 (read_settings, apply_xft_settings): Add comment.
1380 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1381 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1382 call store_font_name_changed.
1383 (xft_settings_event): Add comment.
1384 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1385 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1386 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1387 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1388 (xsettings_initialize): Call init_gsettings last.
1389 (xsettings_get_system_font, xsettings_get_system_normal_font):
1390 Add comment.
1391
1392 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 Random fixes. E.g., (random) never returned negative values.
1395 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1396 subseconds part to the entropy, as that's a bit more random.
1397 Prefer signed to unsigned, since the signedness doesn't matter and
1398 in general we prefer signed. When given a limit, use a
1399 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1400 latter isn't right if USE_2_TAGS_FOR_INTS.
1401 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1402 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1403
1404 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1405
1406 * textprop.c (text_property_stickiness):
1407 Obey Vtext_property_default_nonsticky.
1408 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1409 * w32fns.c (syms_of_w32fns):
1410 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1411
1412 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1415 This is more efficient than Ffile_directory_p and avoids a minor race.
1416
1417 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1418
1419 * buffer.c (Foverlay_put): Say what the return value is
1420 (bug#7835).
1421
1422 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1423 is a directory before asking whether to use the file name
1424 (bug#7564).
1425 (barf_or_query_if_file_exists): Make the "File is a directory"
1426 error be more correct.
1427
1428 * fns.c (Frequire): Remove the mention of the .gz files, since
1429 that's installation-specific, but keep the mention of
1430 `get-load-suffixes'.
1431
1432 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1433
1434 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1435 Report string overflow if the output is too long.
1436
1437 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1438
1439 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1440 (syms_of_gnutls): Remove duplicate DEFSYM for
1441 Qgnutls_bootprop_verify_hostname_error, an error for
1442 Qgnutls_bootprop_verify_error (which is no longer used).
1443
1444 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1445 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1446 Also (re)move comments that are misplaced or no longer relevant.
1447
1448 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1449
1450 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1451
1452 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1453
1454 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1455 and background color parameters if they have been changed.
1456
1457 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1458
1459 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1460
1461 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 * xsettings.c (SYSTEM_FONT): Define only when used.
1464 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1465
1466 * keymap.c (access_keymap_1): Now static.
1467
1468 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1469
1470 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1471 leave any prefix arg for the up event (Bug#1586).
1472
1473 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1474
1475 * lread.c (syms_of_lread): Mention single symbols defined by
1476 `defvar' or `defconst' (bug#7154).
1477
1478 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1479 (Frequire): Mention get-load-suffixes.
1480
1481 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1482
1483 * window.h (window): Remove clone_number slot.
1484 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1485 Remove.
1486 (make_parent_window, make_window, saved_window)
1487 (Fset_window_configuration, save_window_save): Don't deal with
1488 clone numbers.
1489 * buffer.c (Qclone_number): Remove declaration.
1490 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1491
1492 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1493
1494 Add multiple inheritance to keymaps.
1495 * keymap.c (Fmake_composed_keymap): New function.
1496 (Fset_keymap_parent): Simplify.
1497 (fix_submap_inheritance): Remove.
1498 (access_keymap_1): New function extracted from access_keymap to handle
1499 embedded parents and handle lists of maps.
1500 (access_keymap): Use it.
1501 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1502 (Fcopy_keymap): Handle embedded parents.
1503 (Fcommand_remapping, define_as_prefix): Simplify.
1504 (Fkey_binding): Simplify.
1505 (syms_of_keymap): Move minibuffer-local-completion-map,
1506 minibuffer-local-filename-completion-map,
1507 minibuffer-local-must-match-map, and
1508 minibuffer-local-filename-must-match-map to Elisp.
1509 (syms_of_keymap): Defsubr make-composed-keymap.
1510 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1511 (parse_menu_item): Trivial simplification.
1512
1513 2011-07-01 Glenn Morris <rgm@gnu.org>
1514
1515 * Makefile.in (SETTINGS_LIBS): Fix typo.
1516
1517 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1518
1519 * coding.c (Fencode_coding_string): Record the last coding system
1520 used, as the function doc string says (bug#8738).
1521
1522 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1523
1524 * xsettings.c (store_monospaced_changed): Take new font as arg and
1525 check for change against current_mono_font.
1526 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1527 (emacs_settings_constructor, emacs_settings_get_property)
1528 (emacs_settings_set_property, emacs_settings_class_init)
1529 (emacs_settings_init, gsettings_obj): Remove.
1530 (something_changedCB): New function for HAVE_GSETTINGS.
1531 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1532 with value as argument.
1533 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1534 g_settings_new (Bug#8967). Do not create gsettings_obj.
1535 Remove calls to g_settings_bind. Connect something_changedCB to
1536 "changed".
1537
1538 * xgselect.c: Add defined (HAVE_GSETTINGS).
1539 (xgselect_initialize): Ditto.
1540
1541 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1542 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1543 xg_select.
1544
1545 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1546
1547 * eval.c (struct backtrace): Simplify and port the data structure.
1548 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1549 signed bit field, as this assumption is not portable and it makes
1550 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1551 "char debug_on_exit : 1" as this is not portable either; instead,
1552 use the portable "unsigned int debug_on_exit : 1". Remove unused
1553 member evalargs. Remove obsolete comments about cc bombing out.
1554
1555 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1556
1557 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1558 Let HAVE_GSETTINGS override HAVE_GCONF.
1559 (store_monospaced_changed): New function.
1560 (EMACS_SETTINGS): A new type derived from GObject to handle
1561 GSettings notifications.
1562 (emacs_settings_constructor, emacs_settings_get_property)
1563 (emacs_settings_set_property, emacs_settings_class_init):
1564 New functions.
1565 (gsettings_client, gsettings_obj): New variables.
1566 (GSETTINGS_SCHEMA): New define.
1567 (something_changedCB): Call store_monospaced_changed.
1568 (init_gsettings): New function.
1569 (xsettings_initialize): Call init_gsettings.
1570 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1571 to NULL.
1572
1573 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1574 GCONF_CFLAGS/LIBS.
1575
1576 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1577
1578 * window.c (resize_root_window, grow_mini_window)
1579 (shrink_mini_window): Rename Qresize_root_window to
1580 Qwindow_resize_root_window and Qresize_root_window_vertically to
1581 Qwindow_resize_root_window_vertically.
1582
1583 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1584
1585 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1586
1587 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1588
1589 * makefile.w32-in: Redesign dependencies so they reflect more
1590 clearly which files are directly included by each source file,
1591 and not through other includes.
1592
1593 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1594
1595 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1596 (sort_overlays, overlay_strings): When an overlay's clone number
1597 matches the window's clone number process the overlay even if
1598 the overlay's window property doesn't match the current window.
1599
1600 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1601 (Fwindow_hchild): Rename to Fwindow_left_child.
1602 (Fwindow_next): Rename to Fwindow_next_sibling.
1603 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1604 (resize_window_check): Rename to window_resize_check.
1605 (resize_window_apply): Rename to window_resize_apply.
1606 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1607 (Fdelete_other_windows_internal, resize_frame_windows)
1608 (Fsplit_window_internal, Fdelete_window_internal)
1609 (grow_mini_window, shrink_mini_window)
1610 (Fresize_mini_window_internal): Fix callers accordingly.
1611
1612 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1613
1614 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1615 (emacs_fixed_set_min_size): Remove.
1616 (emacs_fixed_new): Take frame as argument.
1617
1618 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1619 (_EmacsFixedPrivate): Remove minwidth/height.
1620 Add struct frame *f.
1621 (emacs_fixed_init): Initialize priv->f.
1622 (get_parent_class, emacs_fixed_set_min_size): Remove.
1623 (emacs_fixed_new): Set priv->f to argument.
1624 (emacs_fixed_get_preferred_width)
1625 (emacs_fixed_get_preferred_height): Use min_width/height from
1626 frames size_hint to set minimum and natural (Bug#8919).
1627 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1628 and use min_width/height from frames size_hint to set
1629 min_width/height (Bug#8919).
1630
1631 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1632 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1633 Fix indentation.
1634
1635 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1636
1637 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1638 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1639 called at ZV.
1640
1641 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1642
1643 * process.c (wait_reading_process_output): Bypass select if
1644 waiting for a cell while ignoring keyboard input, and input is
1645 pending. Suggested by Jan Djärv (Bug#8869).
1646
1647 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1648
1649 Use gnulib's dup2 module instead of rolling our own.
1650 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1651
1652 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1653
1654 * dispnew.c (scrolling_window): Before scrolling, turn off a
1655 mouse-highlight in the window being scrolled.
1656
1657 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1658
1659 Move DEFSYM to lisp.h and use everywhere.
1660
1661 * character.h (DEFSYM): Move declaration...
1662 * lisp.h (DEFSYM): ...here.
1663
1664 * gnutls.c:
1665 * minibuf.c:
1666 * w32menu.c:
1667 * w32proc.c:
1668 * w32select.c: Don't include character.h.
1669
1670 * alloc.c (syms_of_alloc):
1671 * buffer.c (syms_of_buffer):
1672 * bytecode.c (syms_of_bytecode):
1673 * callint.c (syms_of_callint):
1674 * casefiddle.c (syms_of_casefiddle):
1675 * casetab.c (init_casetab_once):
1676 * category.c (init_category_once, syms_of_category):
1677 * ccl.c (syms_of_ccl):
1678 * cmds.c (syms_of_cmds):
1679 * composite.c (syms_of_composite):
1680 * dbusbind.c (syms_of_dbusbind):
1681 * dired.c (syms_of_dired):
1682 * dispnew.c (syms_of_display):
1683 * doc.c (syms_of_doc):
1684 * editfns.c (syms_of_editfns):
1685 * emacs.c (syms_of_emacs):
1686 * eval.c (syms_of_eval):
1687 * fileio.c (syms_of_fileio):
1688 * fns.c (syms_of_fns):
1689 * frame.c (syms_of_frame):
1690 * fringe.c (syms_of_fringe):
1691 * insdel.c (syms_of_insdel):
1692 * keymap.c (syms_of_keymap):
1693 * lread.c (init_obarray, syms_of_lread):
1694 * macros.c (syms_of_macros):
1695 * msdos.c (syms_of_msdos):
1696 * print.c (syms_of_print):
1697 * process.c (syms_of_process):
1698 * search.c (syms_of_search):
1699 * sound.c (syms_of_sound):
1700 * syntax.c (init_syntax_once, syms_of_syntax):
1701 * terminal.c (syms_of_terminal):
1702 * textprop.c (syms_of_textprop):
1703 * undo.c (syms_of_undo):
1704 * w32.c (globals_of_w32):
1705 * window.c (syms_of_window):
1706 * xdisp.c (syms_of_xdisp):
1707 * xfaces.c (syms_of_xfaces):
1708 * xfns.c (syms_of_xfns):
1709 * xmenu.c (syms_of_xmenu):
1710 * xsettings.c (syms_of_xsettings):
1711 * xterm.c (syms_of_xterm): Use DEFSYM.
1712
1713 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1714
1715 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1716
1717 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1718
1719 Integer and buffer overflow fixes (Bug#8873).
1720
1721 * print.c (printchar, strout): Check for string overflow.
1722 (PRINTPREPARE, printchar, strout):
1723 Don't set size unless allocation succeeds.
1724
1725 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1726 for sizes. Check for string overflow more accurately.
1727 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1728
1729 * macros.c: Integer and buffer overflow fixes.
1730 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1731 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1732 Use ptrdiff_t, not int, for sizes.
1733 Don't increment bufsize until after realloc succeeds.
1734 Check for size-calculation overflow.
1735 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1736
1737 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1738
1739 * lread.c: Integer overflow fixes.
1740 (read_integer): Radix is now EMACS_INT, not int,
1741 to improve quality of diagnostics for out-of-range radices.
1742 Calculate buffer size correctly for out-of-range radices.
1743 (read1): Check for integer overflow in radices, and in
1744 read-circle numbers.
1745 (read_escape): Avoid int overflow.
1746 (Fload, openp, read_buffer_size, read1)
1747 (substitute_object_recurse, read_vector, read_list, map_obarray):
1748 Use ptrdiff_t, not int, for sizes.
1749 (read1): Use EMACS_INT, not int, for sizes.
1750 Check for size overflow.
1751
1752 * image.c (cache_image): Check for size arithmetic overflow.
1753
1754 * lread.c: Integer overflow issues.
1755 (saved_doc_string_size, saved_doc_string_length)
1756 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1757 Now ptrdiff_t, not int.
1758 (read1): Don't assume doc string length fits in int. Check for
1759 out-of-range doc string lengths.
1760 (read_list): Don't assume file position fits in int.
1761 (read_escape): Check for hex character overflow.
1762
1763 2011-06-22 Leo Liu <sdl.web@gmail.com>
1764
1765 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1766 Move to minibuffer.el.
1767
1768 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1769
1770 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1771 The following patches are for when GLYPH_DEBUG && !XASSERT.
1772 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1773 * dispnew.c (flush_stdout):
1774 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1775 Mark as externally visible.
1776 * dispnew.c (check_window_matrix_pointers): Now static.
1777 * dispnew.c (window_to_frame_vpos):
1778 * xfns.c (unwind_create_frame):
1779 * xterm.c (x_check_font): Remove unused local.
1780 * scroll.c (CHECK_BOUNDS):
1781 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1782 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1783 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1784 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1785 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1786 Now static.
1787 (debug_method_add): Use va_list and vsprintf rather than relying
1788 on undefined behavior with wrong number of arguments.
1789 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1790 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1791 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1792 since we're not interested in debugging glyphs with old libraries.
1793 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1794 GCC 4.6.0's static checking.
1795
1796 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 Integer overflow and signedness fixes (Bug#8873).
1799 A few related buffer overrun fixes, too.
1800
1801 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1802
1803 * dispextern.h (struct face.stipple):
1804 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1805 (x_bitmap_mask, x_allocate_bitmap_record)
1806 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1807 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1808 (x_create_bitmap_from_xpm_data):
1809 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1810 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1811 (.bitmaps_last):
1812 * xfaces.c (load_pixmap):
1813 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1814 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1815 (.bitmaps_last, struct x_output.icon_bitmap):
1816 Use ptrdiff_t, not int, for bitmap indexes.
1817 (x_allocate_bitmap_record): Check for size overflow.
1818 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1819
1820 Use ptrdiff_t, not int, for overlay counts.
1821 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1822 * editfns.c (overlays_around, get_pos_property):
1823 * textprop.c (get_char_property_and_overlay):
1824 * xdisp.c (next_overlay_change, note_mouse_highlight):
1825 * xfaces.c (face_at_buffer_position):
1826 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1827 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1828 (Fnext_overlay_change, Fprevious_overlay_change)
1829 (mouse_face_overlay_overlaps, Foverlays_in):
1830 Use ptrdiff_t, not int, for sizes.
1831 (overlays_at, overlays_in): Check for size-calculation overflow.
1832
1833 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1834
1835 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1836 (x_session_initialize): Do not assume string length fits in int.
1837
1838 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1839 This is unlikely, but can occur if DPI is outlandish.
1840
1841 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1842 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1843
1844 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1845 * xrdb.c (magic_file_p, search_magic_path):
1846 Omit last arg SUFFIX; it was always 0. All callers changed.
1847 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1848
1849 * xfont.c (xfont_match): Avoid need for strlen.
1850
1851 * xfns.c: Don't assume strlen fits in int.
1852 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1853
1854 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1855 not unsigned long, as we prefer signed integers. All callers changed.
1856 Detect integer overflow in repeat count.
1857 (message_dolog): Don't assume print length fits in 39 bytes.
1858 (display_mode_element): Don't assume strlen fits in int.
1859
1860 * termcap.c: Don't assume sizes fit in int and never overflow.
1861 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1862 (gobble_line): Check for size-calculation overflow.
1863
1864 * minibuf.c (Fread_buffer):
1865 * lread.c (intern, intern_c_string):
1866 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1867 Don't assume string length fits in int.
1868
1869 * keyboard.c (parse_tool_bar_item):
1870 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1871
1872 * font.c: Don't assume string length fits in int.
1873 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1874 Use ptrdiff_t, not int.
1875 (font_intern_prop): Don't assume string length fits in int.
1876 Don't assume integer property fits in fixnum.
1877 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1878
1879 * filelock.c: Fix some buffer overrun and integer overflow issues.
1880 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1881 Reformulate so as not to need the command string.
1882 Invoke gzip -cd rather than gunzip, as it's more portable.
1883 (lock_info_type, lock_file_1, lock_file):
1884 Don't assume pid_t and time_t fit in unsigned long.
1885 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1886 (current_lock_owner): Prefer signed type for sizes.
1887 Use memcpy, not strncpy, where memcpy is what is really wanted.
1888 Don't assume (via atoi) that time_t and pid_t fit in int.
1889 Check for time_t and/or pid_t out of range, e.g., via a network share.
1890 Don't alloca where an auto var works fine.
1891
1892 * fileio.c: Fix some integer overflow issues.
1893 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1894 Don't assume string length fits in int.
1895 (directory_file_name): Don't assume string length fits in long.
1896 (make_temp_name): Don't assume pid fits in int, or that its print
1897 length is less than 20.
1898
1899 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1900
1901 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1902
1903 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1904
1905 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1906 We prefer signed integers, even for size calculations.
1907
1908 * emacs.c: Don't assume string length fits in 'int'.
1909 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1910 (main): Don't invoke strlen when not needed.
1911
1912 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1913 (XD_DEBUG_MESSAGE): Don't waste a byte.
1914
1915 * callproc.c (getenv_internal_1, getenv_internal)
1916 (Fgetenv_internal):
1917 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1918
1919 * lread.c (invalid_syntax): Omit length argument.
1920 All uses changed. This doesn't fix a bug, but it simplifies the
1921 code away from its former Hollerith-constant appearance, and it's
1922 one less 'int' to worry about when looking at integer-overflow issues.
1923 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1924
1925 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1926 This didn't break anything, but it didn't help either.
1927 It's confusing to put a bogus integer in a place where the actual
1928 value does not matter.
1929 (LIST_END_P): Remove unused macro and its bogus comment.
1930 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1931
1932 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1933 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1934 implementation.
1935 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1936 We prefer signed types, and the value cannot exceed the EMACS_INT
1937 range anyway (because otherwise the length would not be representable).
1938 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1939 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1940 This avoids a GCC warning when WIDE_EMACS_INT.
1941
1942 * indent.c (sane_tab_width): New function.
1943 (current_column, scan_for_column, Findent_to, position_indentation)
1944 (compute_motion): Use it. This is just for clarity.
1945 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1946
1947 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1948
1949 * lisp.h (lint_assume): New macro.
1950 * composite.c (composition_gstring_put_cache):
1951 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1952
1953 * editfns.c, insdel.c:
1954 Omit unnecessary forward decls, to simplify future changes.
1955
1956 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1957
1958 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1959
1960 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1961 Use much-faster test for byte-length change.
1962 Don't assume string byte-length fits in 'int'.
1963 Check that character arg fits in 'int'.
1964 (mapcar1): Declare byte as byte, for clarity.
1965
1966 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1967
1968 * fns.c (concat): Catch string overflow earlier.
1969 Do not rely on integer wraparound.
1970
1971 * dispextern.h (struct it.overlay_strings_charpos)
1972 (struct it.selective): Now EMACS_INT, not int.
1973 * xdisp.c (forward_to_next_line_start)
1974 (back_to_previous_visible_line_start)
1975 (reseat_at_next_visible_line_start, next_element_from_buffer):
1976 Don't arbitrarily truncate the value of 'selective' to int.
1977
1978 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1979
1980 * composite.c: Don't truncate sizes to 'int'.
1981 (composition_gstring_p, composition_reseat_it)
1982 (composition_adjust_point): Use EMACS_INT, not int.
1983 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1984 not EMACS_UINT, for indexes.
1985
1986 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1987
1988 * buffer.c: Include <verify.h>.
1989 (struct sortvec.priority, struct sortstr.priority):
1990 Now EMACS_INT, not int.
1991 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1992 (struct sortstr.size, record_overlay_string)
1993 (struct sortstrlist.size, struct sortlist.used):
1994 Don't truncate size to int.
1995 (record_overlay_string): Check for size-calculation overflow.
1996 (init_buffer_once): Check at compile-time, not run-time.
1997
1998 2011-06-22 Jim Meyering <meyering@redhat.com>
1999
2000 Don't leak an XBM-image-sized buffer
2001 * image.c (xbm_load): Free the image buffer after using it.
2002
2003 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 Port to Sun C.
2006 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2007 that Sun C diagnosed.
2008 * fns.c (secure_hash): Fix pointer signedness issue.
2009 * intervals.c (static_offset_intervals): New function.
2010 (offset_intervals): Use it.
2011
2012 2011-06-21 Leo Liu <sdl.web@gmail.com>
2013
2014 * deps.mk (fns.o):
2015 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2016 sha512.h.
2017
2018 * fns.c (secure_hash): Rename from crypto_hash_function and change
2019 the first arg to accept symbols.
2020 (Fsecure_hash): New primitive.
2021 (syms_of_fns): New symbols.
2022
2023 2011-06-20 Deniz Dogan <deniz@dogan.se>
2024
2025 * process.c (Fset_process_buffer): Clarify return value in
2026 docstring.
2027
2028 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2029
2030 * dispnew.c (add_window_display_history): Use BVAR.
2031
2032 * xdisp.c (debug_method_add): Use BVAR.
2033 (check_window_end, dump_glyph_matrix, dump_glyph)
2034 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2035
2036 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2037 Likewise.
2038
2039 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2040 check till after the cache is created in init_frame_faces.
2041
2042 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2043
2044 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2045
2046 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2049 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2050 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2051
2052 Improve buffer-overflow checking (Bug#8873).
2053 * fileio.c (Finsert_file_contents):
2054 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2055 Remove the old (too-loose) buffer overflow checks.
2056 They weren't needed, since make_gap checks for buffer overflow.
2057 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2058 The old code merely checked for Emacs fixnum overflow, and relied
2059 on undefined (wraparound) behavior. The new code avoids undefined
2060 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2061
2062 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2063 Tune. Don't use wider integers than needed. Don't use alloca.
2064 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2065
2066 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2067
2068 * insdel.c, lisp.h (buffer_overflow): New function.
2069 (insert_from_buffer_1, replace_range, replace_range_2):
2070 * insdel.c (make_gap_larger):
2071 * editfns.c (Finsert_char):
2072 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2073
2074 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2075
2076 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2077
2078 Integer overflow and signedness fixes (Bug#8873).
2079
2080 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2081 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2082
2083 * fileio.c: Don't assume EMACS_INT fits in off_t.
2084 (emacs_lseek): New static function.
2085 (Finsert_file_contents, Fwrite_region): Use it.
2086 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2087
2088 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2089
2090 * fns.c: Don't overflow int when computing a list length.
2091 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2092 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2093 truncation on 64-bit hosts. Check for QUIT every
2094 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2095 faster and is responsive enough.
2096 (Flength): Report an error instead of overflowing an integer.
2097 (Fsafe_length): Return a float if the value is not representable
2098 as a fixnum. This shouldn't happen except in contrived situations.
2099 (Fnthcdr, Fsort): Don't assume list length fits in int.
2100 (Fcopy_sequence): Don't assume vector length fits in int.
2101
2102 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2103 (header_size, word_size): New constants.
2104 (allocate_vectorlike): Don't check size overflow here.
2105 (allocate_vector): Check it here instead, since this is the only
2106 caller of allocate_vectorlike that could cause overflow.
2107 Check that the new vector's length is representable as a fixnum.
2108
2109 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2110 The previous code was bogus. For example, next_almost_prime (32)
2111 returned 39, which is undesirable as it is a multiple of 3; and
2112 next_almost_prime (24) returned 25, which is a multiple of 5 so
2113 why was the code bothering to check for multiples of 7?
2114
2115 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2116
2117 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2118
2119 Variadic C functions now count arguments with ptrdiff_t.
2120 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2121 Back then I didn't know that the Emacs coding style prefers signed int.
2122 Also, in the meantime I found a few more instances where arguments
2123 were being counted with int, which may truncate counts on 64-bit
2124 machines, or EMACS_INT, which may be unnecessarily wide.
2125 * lisp.h (struct Lisp_Subr.function.aMANY)
2126 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2127 Arg counts are now ptrdiff_t, not size_t.
2128 All variadic functions and their callers changed accordingly.
2129 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2130 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2131 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2132 * callint.c (Fcall_interactively): Check arg count for overflow,
2133 to avoid potential buffer overrun. Use signed char, not 'int',
2134 for 'varies' array, so that we needn't bother to check its size
2135 calculation for overflow.
2136 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2137 * eval.c (apply_lambda):
2138 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2139 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2140 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2141
2142 * callint.c (Fcall_interactively): Don't use index var as event count.
2143
2144 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2145 * mem-limits.h (SIZE): Remove; no longer used.
2146
2147 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2148
2149 Remove unnecessary casts.
2150 * xterm.c (x_term_init):
2151 * xfns.c (x_set_border_pixel):
2152 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2153 These aren't needed now that we assume ANSI C.
2154
2155 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2156 It's more likely to cause problems (due to unsigned overflow)
2157 than to cure them.
2158
2159 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2160
2161 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2162
2163 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2164
2165 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2166
2167 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2168
2169 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2170
2171 GLYPH_CODE_FACE returns EMACS_INT, not int.
2172 * dispextern.h (merge_faces):
2173 * xfaces.c (merge_faces):
2174 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2175 Don't assume EMACS_INT fits in int.
2176
2177 * character.h (CHAR_VALID_P): Remove unused parameter.
2178 * fontset.c, lisp.h, xdisp.c: All uses changed.
2179
2180 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2181
2182 * fns.c (concat): Minor tuning based on overflow analysis.
2183 This doesn't fix any bugs. Use int to hold character, instead
2184 of constantly refetching from Emacs object. Use XFASTINT, not
2185 XINT, for value known to be a character. Don't bother comparing
2186 a single byte to 0400, as it's always less.
2187
2188 * floatfns.c (Fexpt):
2189 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2190
2191 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2192 for characters.
2193
2194 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2195
2196 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2197 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2198 incorrectly succeed when S was a string, because 4294967386 was
2199 truncated before it was used.
2200
2201 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2202 Otherwise, an out-of-range integer could cause undefined behavior
2203 on a 64-bit host.
2204
2205 * composite.c: Use int, not EMACS_INT, for characters.
2206 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2207 EMACS_INT, for values that are known to be in character range.
2208 This doesn't fix any bugs but is the usual style inside Emacs and
2209 may generate better code on 32-bit machines.
2210
2211 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2212 This is for reasons similar to the recent CHAR_STRING fix.
2213 * charset.c (Fencode_char): Check that character arg is actually
2214 a character. Pass an int to ENCODE_CHAR.
2215 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2216 wider than 'int', as a compile-time check to prevent future regressions
2217 in this area.
2218
2219 * character.c (char_string): Remove unnecessary casts.
2220
2221 Make sure a 64-bit char is never passed to CHAR_STRING.
2222 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2223 by silently ignoring the top 32 bits, allowing some values
2224 that were far too large to be valid characters.
2225 * character.h: Include <verify.h>.
2226 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2227 arguments are no wider than unsigned, as a compile-time check
2228 to prevent future regressions in this area.
2229 * data.c (Faset):
2230 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2231 (Fsubst_char_in_region):
2232 * fns.c (concat):
2233 * xdisp.c (decode_mode_spec_coding):
2234 Adjust to CHAR_STRING's new requirement.
2235 * editfns.c (Finsert_char, Fsubst_char_in_region):
2236 * fns.c (concat): Check that character args are actually
2237 characters. Without this test, these functions did the wrong
2238 thing with wildly out-of-range values on 64-bit hosts.
2239
2240 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2241 These casts should not be needed on 32-bit hosts, either.
2242 * keyboard.c (read_char):
2243 * lread.c (Fload): Remove casts to unsigned.
2244
2245 * lisp.h (UNSIGNED_CMP): New macro.
2246 This fixes comparison bugs on 64-bit hosts.
2247 (ASCII_CHAR_P): Use it.
2248 * casefiddle.c (casify_object):
2249 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2250 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2251 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2252 * dispextern.h (FACE_FROM_ID):
2253 * keyboard.c (read_char): Use UNSIGNED_CMP.
2254
2255 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2256 not to EMACS_INT, to avoid GCC warning.
2257
2258 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2259
2260 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2261 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2262 isn't needed on 32-bit machines.
2263
2264 * buffer.c (Fgenerate_new_buffer_name):
2265 Use EMACS_INT for count, not int.
2266 (advance_to_char_boundary): Return EMACS_INT, not int.
2267
2268 * data.c (Qcompiled_function): Now static.
2269
2270 * window.c (window_body_lines): Now static.
2271
2272 * image.c (gif_load): Rename local to avoid shadowing.
2273
2274 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2275 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2276 * alloc.c (make_save_value): Integer argument is now of type
2277 ptrdiff_t, not int.
2278 (mark_object): Use ptrdiff_t, not int.
2279 * lisp.h (pD): New macro.
2280 * print.c (print_object): Use it.
2281
2282 * alloc.c: Use EMACS_INT, not int, to count objects.
2283 (total_conses, total_markers, total_symbols, total_vector_size)
2284 (total_free_conses, total_free_markers, total_free_symbols)
2285 (total_free_floats, total_floats, total_free_intervals)
2286 (total_intervals, total_strings, total_free_strings):
2287 Now EMACS_INT, not int. All uses changed.
2288 (Fgarbage_collect): Compute overall total using a double, so that
2289 integer overflow is less likely to be a problem. Check for overflow
2290 when converting back to an integer.
2291 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2292 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2293 These were 'int' variables that could overflow on 64-bit hosts;
2294 they were never used, so remove them instead of repairing them.
2295 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2296 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2297 Previously, this ceilinged at INT_MAX, but that doesn't work on
2298 64-bit machines.
2299 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2300
2301 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2302 (allocate_vectorlike): Check for ptrdiff_t overflow.
2303 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2304 when a (possibly-narrower) signed value would do just as well.
2305 We prefer using signed arithmetic, to avoid comparison confusion.
2306
2307 * alloc.c: Catch some string size overflows that we were missing.
2308 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2309 for convenience in STRING_BYTES_MAX.
2310 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2311 The definition here is exact; the one in lisp.h was approximate.
2312 (allocate_string_data): Check for string overflow. This catches
2313 some instances we weren't catching before. Also, it catches
2314 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2315 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2316 and ptrdiff_t and EMACS_INT are both 64 bits.
2317
2318 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2319 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2320 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2321
2322 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2323
2324 * alloc.c (Fmake_string): Check for out-of-range init.
2325
2326 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2327
2328 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2329
2330 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2331
2332 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2333 xg_get_default_scrollbar_width.
2334
2335 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2336 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2337 (style_changed_cb): Call update_theme_scrollbar_width and call
2338 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2339 all frames (Bug#8505).
2340 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2341 Call gtk_window_set_resizable if HAVE_GTK3.
2342 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2343 and height if HAVE_GTK3 (Bug#8505).
2344 (scroll_bar_width_for_theme): New variable.
2345 (update_theme_scrollbar_width): New function.
2346 (xg_get_default_scrollbar_width): Move code to
2347 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2348 (xg_initialize): Call update_theme_scrollbar_width.
2349
2350 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2351
2352 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2353
2354 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2355
2356 * frame.c (make_frame): Call other_buffer_safely instead of
2357 other_buffer.
2358
2359 * window.c (temp_output_buffer_show): Call display_buffer with
2360 second argument Vtemp_buffer_show_specifiers and reset latter
2361 immediately after the call.
2362 (Vtemp_buffer_show_specifiers): New variable.
2363 (auto_window_vscroll_p, next_screen_context_lines)
2364 (Vscroll_preserve_screen_position): Remove leading asterisks from
2365 doc-strings.
2366
2367 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2368
2369 Fix minor problems found by GCC 4.6.0 static checking.
2370 * buffer.c (Qclone_number): Remove for now, as it's unused.
2371 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2372 (record_buffer): Remove unused local.
2373 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2374 (set_frame_buffer_list): Remove; unused.
2375 * frame.h (other_visible_frames): Remove decl.
2376 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2377 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2378 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2379 if HAVE_GPM.
2380 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2381 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2382 Define only if HAVE_GPM.
2383 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2384 (update_hints_inhibit): Remove; never set. All uses removed.
2385 * widgetprv.h (emacsFrameClassRec): Remove decl.
2386 * window.c (delete_deletable_window): Now returns void, since it
2387 wasn't returning anything.
2388 (compare_window_configurations): Remove unused locals.
2389 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2390 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2391 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2392 the same widths as pointers. This follows up on the 2011-05-06 patch.
2393 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2394 * xterm.h: Likewise.
2395 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2396
2397 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2398
2399 * makefile.w32-in: Update dependencies.
2400 (LISP_H): Add lib/intprops.h.
2401
2402 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2403
2404 * image.c (gif_load): Add animation frame delay to the metadata.
2405 (syms_of_image): Use DEFSYM. New symbol `delay'.
2406
2407 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2408
2409 * window.c (delete_deletable_window): Re-add.
2410 (Fset_window_configuration): Rewrite to handle dead buffers and
2411 consequently deletable windows.
2412 (window_tree, Fwindow_tree): Remove. Supply functionality in
2413 window.el.
2414 (compare_window_configurations): Simplify code.
2415
2416 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2417
2418 * image.c (imagemagick_load_image): Fix type mismatch.
2419 (Fimagemagick_types): Likewise.
2420
2421 * window.h (replace_buffer_in_windows): Declare.
2422
2423 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2424
2425 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2426 Qclone_number. Remove external declaration of Qdelete_window.
2427 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2428 code.
2429 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2430 Run Qbuffer_list_update_hook if allowed.
2431 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2432 buffer list implementation.
2433 (other_buffer_safely): New function.
2434 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2435 calls to replace_buffer_in_windows and
2436 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2437 if allowed.
2438 (record_buffer): Inhibit quitting and rewrite using quittable
2439 functions. Run Qbuffer_list_update_hook if allowed.
2440 (Frecord_buffer, Funrecord_buffer): New functions.
2441 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2442 Move switch-to-buffer to window.el.
2443 (bury-buffer): Move to window.el.
2444 (Vbuffer_list_update_hook): New variable.
2445
2446 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2447 section.
2448
2449 * window.h (resize_frame_windows): Move up in code.
2450 (Fwindow_frame): Remove EXFUN.
2451 (replace_buffer_in_all_windows): Remove prototype.
2452 (replace_buffer_in_windows_safely): Add prototype.
2453
2454 * window.c: Declare Qdelete_window static again. Move down
2455 declaration of select_count.
2456 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2457 (Fother_window): Move to window.el.
2458 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2459 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2460 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2461 window.el.
2462 (replace_buffer_in_windows): Implement by calling
2463 Qreplace_buffer_in_windows.
2464 (replace_buffer_in_all_windows): Remove with some functionality
2465 moved into replace_buffer_in_windows_safely.
2466 (replace_buffer_in_windows_safely): New function.
2467 (select_window_norecord, select_frame_norecord): Move in front
2468 of run_window_configuration_change_hook. Remove now obsolete
2469 declarations.
2470 (Fset_window_buffer): Rewrite doc-string.
2471 Call Qrecord_window_buffer.
2472 (keys_of_window): Move binding for other-window to window.el.
2473
2474 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2475
2476 * dispextern.h (struct image): Replace data member, whose int_val
2477 and ptr_val fields were not used by anything, with a single
2478 lisp_val object.
2479
2480 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2481 (gif_clear_image, gif_load, imagemagick_load_image)
2482 (gs_clear_image, gs_load): Callers changed.
2483
2484 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2485
2486 * buffer.h: Include <time.h>, for time_t.
2487 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2488
2489 Fix minor problems found by static checking.
2490
2491 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2492
2493 Make identifiers static if they are not used in other modules.
2494 * data.c (Qcompiled_function, Qframe, Qvector):
2495 * image.c (QimageMagick, Qsvg):
2496 * minibuf.c (Qmetadata):
2497 * window.c (resize_window_check, resize_root_window): Now static.
2498 * window.h (resize_window_check, resize_root_window): Remove decls.
2499
2500 * window.c (window_deletion_count, delete_deletable_window):
2501 Remove; unused.
2502 (window_body_lines): Now static.
2503 (Fdelete_other_windows_internal): Mark vars as initialized.
2504 Make sure 'resize_failed' is initialized.
2505 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2506 (resize_window_apply): Remove unused local.
2507 * window.h (delete_deletable_window): Remove decl.
2508
2509 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2510 (imagemagick_load_image): Fix pointer signedness problem by changing
2511 last arg from unsigned char * to char *. All uses changed.
2512 Also, fix a local for similar reasons.
2513 Remove unused locals. Remove locals to avoid shadowing.
2514 (fn_rsvg_handle_free): Remove; unused.
2515 (svg_load, svg_load_image): Fix pointer signedness problem.
2516 (imagemagick_load_image): Don't use garbage pointer image_wand.
2517
2518 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2519
2520 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2521
2522 * image.c (gif_load): Fix omitted cast error introduced by
2523 2011-06-06 change.
2524
2525 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2526
2527 * window.h (resize_proportionally, orig_total_lines)
2528 (orig_top_line): Remove from window structure.
2529 (set_window_height, set_window_width, change_window_heights)
2530 (Fdelete_window): Remove prototypes.
2531 (resize_frame_windows): Remove duplicate declaration.
2532
2533 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2534
2535 * window.h (resize_frame_windows, resize_window_check)
2536 (delete_deletable_window, resize_root_window)
2537 (resize_frame_windows): Declare prototypes.
2538
2539 * window.c (resize_window_apply): Make definition be "static" to
2540 match the prototype.
2541
2542 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2543
2544 * window.c: Remove declarations of Qwindow_size_fixed,
2545 window_min_size_1, window_min_size_2, window_min_size,
2546 size_window, window_fixed_size_p, enlarge_window, delete_window.
2547 Remove static from declaration of Qdelete_window, it's
2548 temporarily needed by Fbury_buffer.
2549 (replace_window): Don't assign orig_top_line and
2550 orig_total_lines.
2551 (Fdelete_window, delete_window): Remove. Window deletion is
2552 handled by window.el.
2553 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2554 Replace Fdelete_window calls with calls to Qdelete_window.
2555 (Fdelete_other_windows): Remove. Deleting other windows is
2556 handled by window.el.
2557 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2558 handled in window.el.
2559 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2560 Window minimum sizes are handled in window.el.
2561 (shrink_windows, size_window, set_window_height)
2562 (set_window_width, change_window_heights, window_height)
2563 (window_width, CURBEG, CURSIZE, enlarge_window)
2564 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2565 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2566 handled in window.el.
2567 (make_dummy_parent): Rename to make_parent_window and give it a
2568 second argument horflag.
2569 (make_window): Don't set resize_proportionally any more.
2570 (Fsplit_window): Remove. Windows are split in window.el.
2571 (save_restore_action, save_restore_orig_size)
2572 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2573 Resize mini windows in window.el.
2574 (grow_mini_window, shrink_mini_window): Implement by calling
2575 Qresize_root_window_vertically, resize_window_check and
2576 resize_window_apply.
2577 (saved_window, Fset_window_configuration, save_window_save):
2578 Do not handle orig_top_line, orig_total_lines, and
2579 resize_proportionally.
2580 (window_min_height, window_min_width): Move to window.el.
2581 (keys_of_window): Move bindings for delete-other-windows,
2582 split-window, delete-window and enlarge-window to window.el.
2583
2584 * buffer.c: Temporarily extern Qdelete_window.
2585 (Fbury_buffer): Temporarily call Qdelete_window instead of
2586 Fdelete_window (Fbury_buffer will move to window.el soon).
2587
2588 * frame.c (set_menu_bar_lines_1): Remove code handling
2589 orig_top_line and orig_total_lines.
2590
2591 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2592 set_window_height but set heights directly.
2593 (change_frame_size_1): Use resize_frame_windows.
2594
2595 * xdisp.c (init_xdisp): Don't use set_window_height but set
2596 heights directly.
2597
2598 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2599 Use resize_frame_windows instead of change_window_heights and run
2600 run_window_configuration_change_hook.
2601
2602 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2603 instead of change_window_heights and run
2604 run_window_configuration_change_hook.
2605
2606 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2607
2608 * window.c (replace_window): Rename second argument REPLACEMENT to
2609 NEW. New third argument SETFLAG. Rewrite.
2610 (delete_window, make_dummy_parent): Call replace_window with
2611 third argument 1.
2612 (window_list_1): Move down in code.
2613 (run_window_configuration_change_hook): Move set_buffer part
2614 before select_frame_norecord part in order to unwind correctly.
2615 Rename count1 to count.
2616 (recombine_windows, delete_deletable_window, resize_root_window)
2617 (Fdelete_other_windows_internal)
2618 (Frun_window_configuration_change_hook, make_parent_window)
2619 (resize_window_check, resize_window_apply, Fresize_window_apply)
2620 (resize_frame_windows, Fsplit_window_internal)
2621 (Fdelete_window_internal, Fresize_mini_window_internal):
2622 New functions.
2623 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2624
2625 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2626
2627 * window.h (window): Add some new members to window structure -
2628 normal_lines, normal_cols, new_total, new_normal, clone_number,
2629 splits, nest, prev_buffers, next_buffers.
2630 (WINDOW_TOTAL_SIZE): Move here from window.c.
2631 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2632
2633 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2634 Remove.
2635 (make_dummy_parent): Set new members of windows structure.
2636 (make_window): Move down in code. Handle new members of window
2637 structure.
2638 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2639 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2640 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2641 (Fset_window_prev_buffers, Fwindow_next_buffers)
2642 (Fset_window_next_buffers, Fset_window_clone_number):
2643 New functions.
2644 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2645 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2646 Doc-string fixes.
2647 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2648 Argument WINDOW can be now internal window too.
2649 (Fwindow_use_time): Move up in code.
2650 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2651 Rewrite doc-string.
2652 (Fset_window_configuration, saved_window)
2653 (Fcurrent_window_configuration, save_window_save): Handle new
2654 members of window structure.
2655 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2656 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2657 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2658 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2659 Qget_mru_window, Qresize_root_window,
2660 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2661 Qauto_buffer_name; staticpro them.
2662
2663 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2664
2665 * window.c (Fwindow_total_size, Fwindow_left_column)
2666 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2667 (Fwindow_list_1): New functions.
2668 (window_box_text_cols): Replace with window_body_cols.
2669 (Fwindow_width, Fscroll_left, Fscroll_right):
2670 Use window_body_cols instead of window_box_text_cols.
2671 (delete_window, Fset_window_configuration):
2672 Call delete_all_subwindows with window as argument.
2673 (delete_all_subwindows): Take a window as argument and not a
2674 structure. Rewrite.
2675 (window_loop): Remove handling of GET_LRU_WINDOW and
2676 GET_LARGEST_WINDOW.
2677 (Fget_lru_window, Fget_largest_window): Move to window.el.
2678
2679 * window.h: Extern window_body_cols instead of
2680 window_box_text_cols. delete_all_subwindows now takes a
2681 Lisp_Object as argument.
2682
2683 * indent.c (compute_motion, Fcompute_motion):
2684 Use window_body_cols instead of window_box_text_cols.
2685
2686 * frame.c (delete_frame): Call delete_all_subwindows with root
2687 window as argument.
2688
2689 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2690
2691 * fns.c (Fputhash): Document return value.
2692
2693 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2694
2695 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2696
2697 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2698
2699 Cons<->int and similar integer overflow fixes (Bug#8794).
2700
2701 Check for overflow when converting integer to cons and back.
2702 * charset.c (Fdefine_charset_internal, Fdecode_char):
2703 Use cons_to_unsigned to catch overflow.
2704 (Fencode_char): Use INTEGER_TO_CONS.
2705 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2706 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2707 * data.c (long_to_cons, cons_to_long): Remove.
2708 (cons_to_unsigned, cons_to_signed): New functions.
2709 These signal an error for invalid or out-of-range values.
2710 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2711 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2712 * font.c (Ffont_variation_glyphs):
2713 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2714 * lisp.h: Include <intprops.h>.
2715 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2716 (cons_to_signed, cons_to_unsigned): New decls.
2717 (long_to_cons, cons_to_long): Remove decls.
2718 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2719 (Fprimitive_undo): Use CONS_TO_INTEGER.
2720 * xfns.c (Fx_window_property): Likewise.
2721 * xselect.c: Include <limits.h>.
2722 (x_own_selection, selection_data_to_lisp_data):
2723 Use INTEGER_TO_CONS.
2724 (x_handle_selection_request, x_handle_selection_clear)
2725 (x_get_foreign_selection, Fx_disown_selection_internal)
2726 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2727 (lisp_data_to_selection_data): Use cons_to_unsigned.
2728 (x_fill_property_data): Use cons_to_signed.
2729 Report values out of range.
2730
2731 Check for buffer and string overflow more precisely.
2732 * buffer.h (BUF_BYTES_MAX): New macro.
2733 * lisp.h (STRING_BYTES_MAX): New macro.
2734 * alloc.c (Fmake_string):
2735 * character.c (string_escape_byte8):
2736 * coding.c (coding_alloc_by_realloc):
2737 * doprnt.c (doprnt):
2738 * editfns.c (Fformat):
2739 * eval.c (verror):
2740 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2741 since they may not be the same number.
2742 * editfns.c (Finsert_char):
2743 * fileio.c (Finsert_file_contents):
2744 Likewise for BUF_BYTES_MAX.
2745
2746 * image.c: Use ptrdiff_t, not int, for sizes.
2747 (slurp_file): Switch from int to ptrdiff_t.
2748 All uses changed.
2749 (slurp_file): Check that file size fits in both size_t (for
2750 malloc) and ptrdiff_t (for sanity and safety).
2751
2752 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2753 if b->modtime has its maximal value.
2754
2755 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2756
2757 Don't assume time_t can fit into int.
2758 * buffer.h (struct buffer.modtime): Now time_t, not int.
2759 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2760 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2761
2762 Minor fixes for signed vs unsigned integers.
2763 * character.h (MAYBE_UNIFY_CHAR):
2764 * charset.c (maybe_unify_char):
2765 * keyboard.c (read_char, reorder_modifiers):
2766 XINT -> XFASTINT, since the integer must be nonnegative.
2767 * ftfont.c (ftfont_spec_pattern):
2768 * keymap.c (access_keymap, silly_event_symbol_error):
2769 XUINT -> XFASTINT, since the integer must be nonnegative.
2770 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2771 since it makes no difference and we prefer signed.
2772 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2773 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2774 nonnegative.
2775
2776 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2777
2778 * window.h (Fwindow_frame): Declare.
2779
2780 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2781
2782 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2783 (SPARE_MEMORY): Always define.
2784 (LARGE_REQUEST): Remove.
2785 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2786
2787 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2788
2789 * lisp.h: Move EXFUNS for Fframe_root_window,
2790 Fframe_first_window and Fset_frame_selected_window to window.h.
2791
2792 * window.h: Move EXFUNS for Fframe_root_window,
2793 Fframe_first_window and Fset_frame_selected_window here from
2794 lisp.h.
2795
2796 * frame.c (Fwindow_frame, Fframe_first_window)
2797 (Fframe_root_window, Fframe_selected_window)
2798 (Fset_frame_selected_window): Move to window.c.
2799 (Factive_minibuffer_window): Move to minibuf.c.
2800 (Fother_visible_frames_p): New function.
2801
2802 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2803
2804 * window.c (decode_window, decode_any_window): Move up in code.
2805 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2806 (inhibit_frame_unsplittable): Remove unused variable.
2807 (Fwindow_buffer): Move up and rewrite doc-string.
2808 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2809 (Fwindow_prev): New functions.
2810 (Fwindow_frame): Move here from frame.c. Accept any window as
2811 argument.
2812 (Fframe_root_window, Fframe_first_window)
2813 (Fframe_selected_window): Move here from frame.c. Accept frame
2814 or arbitrary window as argument. Update doc-strings.
2815 (Fminibuffer_window): Move up in code.
2816 (Fwindow_minibuffer_p): Move up in code and simplify.
2817 (Fset_frame_selected_window): Move here from frame.c.
2818 Marginal rewrite.
2819 (Fselected_window, select_window, Fselect_window): Move up in
2820 code. Minor doc-string fixes.
2821
2822 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2823
2824 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2825 Do not assume that spare memory exists; that assumption is valid
2826 only if SYSTEM_MALLOC.
2827 (LARGE_REQUEST): New macro, so that the issue of large requests
2828 is separated from the issue of spare memory.
2829
2830 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2831
2832 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2833 format. (Bug#8806)
2834
2835 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2836
2837 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2838 before statements.
2839
2840 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2841
2842 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2843
2844 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2845
2846 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2847 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2848
2849 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2850
2851 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2852
2853 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2854
2855 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2856 (x_clipboard_manager_save): Add return value.
2857 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2858 New error handlers.
2859 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2860 Obey Vx_select_enable_clipboard_manager. Catch errors in
2861 x_clipboard_manager_save (Bug#8779).
2862 (Vx_select_enable_clipboard_manager): New variable.
2863 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2864
2865 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2866
2867 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2868
2869 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2870
2871 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2872 in the current matrix if keep_current_p is non-zero.
2873
2874 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2875
2876 * bidi.c (bidi_level_of_next_char): Fix last change.
2877
2878 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2879
2880 Support bidi reordering of text covered by display properties.
2881
2882 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2883 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2884 (bidi_cache_search, bidi_cache_iterator_state)
2885 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2886 (bidi_level_of_next_char, bidi_move_to_visually_next):
2887 Support character positions inside a run of characters covered by a
2888 display string.
2889 (bidi_paragraph_init, bidi_resolve_explicit_1)
2890 (bidi_level_of_next_char): Call bidi_fetch_char and
2891 bidi_fetch_char_advance instead of FETCH_CHAR and
2892 FETCH_CHAR_ADVANCE.
2893 (bidi_init_it): Initialize new members.
2894 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2895 definitions.
2896 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2897 instead of using explicit *_CHAR codes.
2898 (bidi_resolve_explicit, bidi_resolve_weak):
2899 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2900 bidirectional text is supported only in multibyte buffers.
2901 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2902 it to initialize the frame_window_p member of struct bidi_it.
2903 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2904 (bidi_resolve_explicit, bidi_resolve_weak)
2905 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2906 bidi_it->nchars is non-positive.
2907 (bidi_level_of_next_char): Don't try to lookup the cache for the
2908 next/previous character if nothing is cached there yet, or if we
2909 were just reseat()'ed to a new position.
2910
2911 * xdisp.c (set_cursor_from_row): Set start and stop points
2912 according to the row's direction when priming the loop that looks
2913 for the glyph on which to display cursor.
2914 (single_display_spec_intangible_p): Function deleted.
2915 (display_prop_intangible_p): Reimplement to call
2916 handle_display_spec instead of single_display_spec_intangible_p.
2917 Accept 3 additional arguments needed by handle_display_spec.
2918 This fixes incorrect cursor motion across display property with complex
2919 values: lists, `(when COND...)' forms, etc.
2920 (single_display_spec_string_p): Support property values that are
2921 lists with the argument STRING its top-level element.
2922 (display_prop_string_p): Fix the condition for processing a
2923 property that is a list to be consistent with handle_display_spec.
2924 (handle_display_spec): New function, refactored from the
2925 last portion of handle_display_prop.
2926 (compute_display_string_pos): Accept additional argument
2927 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2928 value of a `display' property is a "replacing spec".
2929 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2930 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2931 the display property, but just return a value indicating whether
2932 the display property will replace the characters it covers.
2933 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2934 frame_window_p members of struct bidi_it.
2935 (compute_display_string_pos, compute_display_string_end):
2936 New functions.
2937 (push_it): Accept second argument POSITION, where pop_it should
2938 jump to continue iteration.
2939 (reseat_1): Initialize bidi_it.disp_pos.
2940
2941 * keyboard.c (adjust_point_for_property): Adjust the call to
2942 display_prop_intangible_p to its new signature.
2943
2944 * dispextern.h (struct bidi_it): New member frame_window_p.
2945 (bidi_init_it): Update prototypes.
2946 (display_prop_intangible_p): Update prototype.
2947 (compute_display_string_pos, compute_display_string_end):
2948 Declare prototypes.
2949 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2950 EMACS_INT.
2951
2952 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2953
2954 Malloc failure behavior now depends on size of allocation.
2955 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2956 * lisp.h: Change signatures accordingly.
2957 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2958 All callers changed. (Bug#8762)
2959
2960 * gnutls.c: Use Emacs's memory allocators.
2961 Without this change, the gnutls library would invoke malloc etc.
2962 directly, which causes problems on non-SYNC_INPUT hosts, and which
2963 runs afoul of improving memory_full behavior. (Bug#8761)
2964 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2965 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2966 xfree instead of the default malloc, realloc, free.
2967 (Fgnutls_boot): No need to check for memory allocation failure,
2968 since xmalloc does that for us.
2969
2970 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2971 * category.c (hash_get_category_set):
2972 * ccl.c (ccl_driver):
2973 * charset.c (Fdefine_charset_internal):
2974 * charset.h (struct charset.hash_index):
2975 * composite.c (get_composition_id, gstring_lookup_cache)
2976 (composition_gstring_put_cache):
2977 * composite.h (struct composition.hash_index):
2978 * dispextern.h (struct image.hash):
2979 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2980 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2981 (hashfn_equal, hashfn_user_defined, make_hash_table)
2982 (maybe_resize_hash_table, hash_lookup, hash_put)
2983 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2984 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2985 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2986 * image.c (make_image, search_image_cache, lookup_image)
2987 (xpm_put_color_table_h):
2988 * lisp.h (struct Lisp_Hash_Table):
2989 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2990 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2991 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2992 * alloc.c (allocate_vectorlike):
2993 Check for overflow in vector size calculations.
2994 * ccl.c (ccl_driver):
2995 Check for overflow when converting EMACS_INT to int.
2996 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2997 need to be updated by these changes.
2998 * fns.c (make_hash_table, maybe_resize_hash_table):
2999 Check for integer overflow with large hash tables.
3000 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3001 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3002 (SXHASH_REDUCE): New macro.
3003 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3004 Use it instead of discarding useful hash info with large hash values.
3005 (sxhash_float): New function.
3006 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3007 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3008 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3009 Rewrite to use FIXNUM_BITS, as this simplifies things.
3010 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3011 Adjust signatures to match updated version of code.
3012 (consing_since_gc): Now EMACS_INT, since a single hash table can
3013 use more than INT_MAX bytes.
3014
3015 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3016
3017 Make it possible to build with GCC-4.6+ -O2 -flto.
3018
3019 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3020
3021 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3022
3023 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3024 Call minibuffer-inactive-mode.
3025
3026 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3027
3028 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3029 Update dependencies.
3030
3031 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3032
3033 * data.c (init_data): Remove code for UTS, this system is not
3034 supported anymore.
3035
3036 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3037
3038 Don't force ./temacs to start in terminal mode.
3039
3040 * frame.c (make_initial_frame): Initialize faces in all cases, not
3041 only when CANNOT_DUMP is defined.
3042 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3043
3044 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3045
3046 * dispnew.c (add_window_display_history): Use const for the string
3047 pointer. Remove declaration, not needed.
3048
3049 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3050
3051 Use 'inline', not 'INLINE'.
3052 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3053 * alloc.c, fontset.c (INLINE): Remove.
3054 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3055 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3056 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3057 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3058 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3059
3060 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3061
3062 Make it possible to run ./temacs.
3063
3064 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3065 syms_of_callproc does the same thing. Remove test for
3066 "initialized", do it in the caller.
3067 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3068
3069 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3070
3071 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3072 (read_minibuf): Use get_minibuffer.
3073 (syms_of_minibuf): Use DEFSYM.
3074 (Qmetadata): New var.
3075 * data.c (Qbuffer): Don't make it static.
3076 (syms_of_data): Use DEFSYM.
3077
3078 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3079
3080 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3081 (CCL_CODE_MIN): New macro.
3082
3083 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3084
3085 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3086
3087 * eval.c (Qdebug): Now static.
3088 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3089 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3090 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3091
3092 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3093
3094 * image.c: Various fixes to ImageMagick code comments.
3095 (Fimagemagick_types): Doc fix.
3096
3097 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3098
3099 Minor fixes prompted by GCC 4.6.0 warnings.
3100
3101 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3102
3103 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3104 (x_clipboard_manager_save_all): Move extern decl to ...
3105 * xterm.h: ... here, so that it can be checked for consistency.
3106
3107 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3108
3109 * xselect.c (x_clipboard_manager_save_frame)
3110 (x_clipboard_manager_save_all): New functions.
3111 (Fx_clipboard_manager_save): Lisp function deleted.
3112
3113 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3114 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3115
3116 * xterm.h: Update prototype.
3117
3118 2011-05-28 William Xu <william.xwl@gmail.com>
3119
3120 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3121 exiting (Bug#8239).
3122
3123 2011-05-28 Jim Meyering <meyering@redhat.com>
3124
3125 Avoid a sign-extension bug in crypto_hash_function.
3126 * fns.c (to_uchar): Define.
3127 (crypto_hash_function): Use it to convert some newly-signed
3128 variables to unsigned, to avoid sign-extension bugs. For example,
3129 without this change, (md5 "truc") would evaluate to
3130 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3131 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3132 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3133
3134 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3135
3136 Integer overflow fixes.
3137
3138 * dbusbind.c: Serial number integer overflow fixes.
3139 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3140 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3141 to hold a serial number that is too large for a fixnum.
3142 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3143 Check for serial numbers out of range. Decode any serial number
3144 that was so large that it became a float. (Bug#8722)
3145
3146 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3147 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3148 Use XFASTINT rather than XUINT when numbers are nonnegative.
3149 (xd_append_arg, Fdbus_method_return_internal):
3150 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3151 arguments, check that Lisp number is nonnegative, rather than
3152 silently wrapping negative numbers around. (Bug#8722)
3153 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3154 (Bug#8722)
3155
3156 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3157
3158 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3159
3160 ccl: add integer overflow checks
3161 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3162 (IN_INT_RANGE): New macros.
3163 (ccl_driver): Use them to check for integer overflow when
3164 decoding a CCL program. Many of the new checks are whether XINT (x)
3165 fits in int; it doesn't always, on 64-bit hosts. The new version
3166 doesn't catch all possible integer overflows, but it's an
3167 improvement. (Bug#8719)
3168
3169 * alloc.c (make_event_array): Use XINT, not XUINT.
3170 There's no need for unsigned here.
3171
3172 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3173 This follows up to the 2011-05-06 change that substituted uintptr_t
3174 for EMACS_INT. This case wasn't caught back then.
3175
3176 Rework Fformat to avoid integer overflow issues.
3177 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3178 now (part of C89). Include <verify.h>.
3179 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3180 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3181 (Fformat): Avoid the prepass trying to compute sizes; it was only
3182 approximate and thus did not catch overflow reliably. Instead, walk
3183 through the format just once, formatting and computing sizes as we go,
3184 checking for integer overflow at every step, and allocating a larger
3185 buffer as needed. Keep track separately whether the format is
3186 multibyte. Keep only the most-recently calculated precision, rather
3187 than them all. Record whether each argument has been converted to
3188 string. Use EMACS_INT, not int, for byte and char and arg counts.
3189 Support field widths and precisions larger than INT_MAX. Avoid
3190 sprintf's undefined behavior with conversion specifications such as %#d
3191 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3192 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3193 formatting out-of-range floating point numbers with int
3194 formats. (Bug#8668)
3195
3196 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3197
3198 * data.c: Avoid integer truncation in expressions involving floats.
3199 * data.c: Include <intprops.h>.
3200 (arith_driver): When there's an integer overflow in an expression
3201 involving floating point, convert the integers to floating point
3202 so that the resulting value does not suffer from catastrophic
3203 integer truncation. For example, on a 64-bit host (* 4
3204 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3205 Do not rely on undefined behavior after integer overflow.
3206
3207 merge count_size_as_multibyte, parse_str_to_multibyte
3208 * character.c, character.h (count_size_as_multibyte):
3209 Rename from parse_str_to_multibyte; all uses changed.
3210 Check for integer overflow.
3211 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3212 since it's now a duplicate of the other. This is more of
3213 a character than a buffer op, so better that it's in character.c.
3214 * fns.c, print.c: Adjust to above changes.
3215
3216 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3217
3218 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3219
3220 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3221
3222 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3223 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3224 (x_clipboard_manager_save): Now static.
3225 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3226
3227 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3228 (crypto_hash_function): Now static.
3229 Fix pointer signedness problems. Avoid unnecessary initializations.
3230
3231 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3232
3233 * termhooks.h (Vselection_alist): Make it terminal-local.
3234
3235 * terminal.c (create_terminal): Initialize it.
3236
3237 * xselect.c: Support for clipboard managers.
3238 (Vselection_alist): Move to termhooks.h as terminal-local var.
3239 (LOCAL_SELECTION): New macro.
3240 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3241 (symbol_to_x_atom): Remove gratuitous arg.
3242 (x_handle_selection_request, lisp_data_to_selection_data)
3243 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3244 (x_own_selection, x_get_local_selection, x_convert_selection):
3245 New arg, specifying work frame. Use terminal-local Vselection_alist.
3246 (some_frame_on_display): Delete unused function.
3247 (Fx_own_selection_internal, Fx_get_selection_internal)
3248 (Fx_disown_selection_internal, Fx_selection_owner_p)
3249 (Fx_selection_exists_p): New optional frame arg.
3250 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3251 (x_handle_selection_clear): Don't treat other terminals with the
3252 same keyboard specially. Use the terminal-local Vselection_alist.
3253 (x_clear_frame_selections): Use Frun_hook_with_args.
3254
3255 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3256
3257 * xterm.h: Add support for those atoms.
3258
3259 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3260
3261 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3262 (converted_selections, conversion_fail_tag): New global variables.
3263 (x_selection_request_lisp_error): Free the above.
3264 (x_get_local_selection): Remove unnecessary code.
3265 (x_reply_selection_request): Args changed; handle arbitrary array
3266 of converted selections stored in converted_selections.
3267 Separate the XChangeProperty and SelectionNotify steps.
3268 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3269 (x_convert_selection): New function.
3270 (x_handle_selection_event): Simplify.
3271 (x_get_foreign_selection): Don't ignore incoming requests while
3272 waiting for an answer; this will fail when we implement
3273 SAVE_TARGETS, and seems unnecessary anyway.
3274 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3275 (Vx_sent_selection_functions): Doc fix.
3276
3277 2011-05-26 Leo Liu <sdl.web@gmail.com>
3278
3279 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3280
3281 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3282
3283 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3284
3285 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3286 for fringe update if it has periodic bitmap.
3287 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3288 and fringe_bitmap_periodic_p.
3289
3290 * fringe.c (get_fringe_bitmap_data): New function.
3291 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3292 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3293 row. Mark glyph row for fringe update if periodicity changed.
3294
3295 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3296 for fringe update unless it has periodic bitmap.
3297
3298 2011-05-25 Kenichi Handa <handa@m17n.org>
3299
3300 * xdisp.c (get_next_display_element): Set correct it->face_id for
3301 a static composition.
3302
3303 2011-05-24 Leo Liu <sdl.web@gmail.com>
3304
3305 * deps.mk (fns.o):
3306 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3307
3308 * fns.c (crypto_hash_function, Fsha1): New function.
3309 (Fmd5): Use crypto_hash_function.
3310 (syms_of_fns): Add Ssha1.
3311
3312 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3313
3314 * gnutls.c: Remove unused macros.
3315 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3316 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3317 Remove macros that are defined and never used.
3318 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3319
3320 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3321
3322 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3323 (Fx_get_selection_internal): Minor cleanup.
3324 (Fx_own_selection_internal): Rename arguments for consistency with
3325 select.el.
3326
3327 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3328
3329 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3330
3331 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3332
3333 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3334
3335 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3336
3337 * dispnew.c (scrolling_window): Don't exclude the case that the
3338 last enabled row in the desired matrix touches the bottom boundary.
3339
3340 2011-05-21 Glenn Morris <rgm@gnu.org>
3341
3342 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3343 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3344 and add some more files.
3345
3346 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3347
3348 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3349 report_file_error introduced by the change from 2011-05-07.
3350
3351 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3352
3353 * systime.h (Time): Define only if emacs is defined.
3354 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3355 where the include path doesn't have X11/X.h by default. See
3356 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3357
3358 2011-05-20 Kenichi Handa <handa@m17n.org>
3359
3360 * composite.c (find_automatic_composition): Fix previous change.
3361
3362 2011-05-20 Glenn Morris <rgm@gnu.org>
3363
3364 * lisp.mk: New file, split from Makefile.in.
3365 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3366 (shortlisp): Remove.
3367 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3368
3369 2011-05-19 Glenn Morris <rgm@gnu.org>
3370
3371 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3372 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3373 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3374 (lisp): Set the order to that of loadup.el.
3375 (shortlisp): Make it a copy of $lisp.
3376 (SOME_MACHINE_LISP): Remove.
3377 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3378 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3379
3380 2011-05-18 Kenichi Handa <handa@m17n.org>
3381
3382 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3383 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3384 (find_automatic_composition): Mostly rewrite for efficiency.
3385
3386 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3387
3388 * makefile.w32-in: Update dependencies.
3389
3390 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3391
3392 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3393 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3394
3395 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3396
3397 Fix some integer overflow issues, such as string length overflow.
3398
3399 * insdel.c (count_size_as_multibyte): Check for string overflow.
3400
3401 * character.c (lisp_string_width): Check for string overflow.
3402 Use EMACS_INT, not int, for string indexes and lengths; in
3403 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3404 the resulting string length overflows an EMACS_INT; instead,
3405 report a string overflow if no precision given. When checking for
3406 precision exhaustion, use a check that cannot possibly have
3407 integer overflow. (Bug#8675)
3408 * character.h (lisp_string_width): Adjust to new signature.
3409
3410 * alloc.c (string_overflow): New function.
3411 (Fmake_string): Use it. This doesn't change behavior, but saves
3412 a few bytes and will simplify future changes.
3413 * character.c (string_escape_byte8): Likewise.
3414 * lisp.h (string_overflow): New decl.
3415
3416 Fixups, following up to the user-interface timestamp change.
3417 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3418 for UI timestamps, instead of unsigned long.
3419 * msdos.c (mouse_get_pos): Likewise.
3420 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3421 * w32gui.h (Time): Define by including "systime.h" rather than by
3422 declaring it ourselves. (Bug#8664)
3423
3424 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3425 * image.c (clear_image_cache): Likewise.
3426
3427 * term.c (term_mouse_position): Don't assume time_t wraparound.
3428
3429 Be more systematic about user-interface timestamps.
3430 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3431 and sometimes 'EMACS_UINT', to represent these timestamps.
3432 This change causes it to use 'Time' uniformly, as that's what X uses.
3433 This makes the code easier to follow, and makes it easier to catch
3434 integer overflow bugs such as Bug#8664.
3435 * frame.c (Fmouse_position, Fmouse_pixel_position):
3436 Use Time, not unsigned long, for user-interface timestamps.
3437 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3438 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3439 * keyboard.h (last_event_timestamp): Likewise.
3440 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3441 * menu.h (xmenu_show): Likewise.
3442 * term.c (term_mouse_position): Likewise.
3443 * termhooks.h (struct input_event.timestamp): Likewise.
3444 (struct terminal.mouse_position_hook): Likewise.
3445 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3446 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3447 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3448 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3449 what it was before.
3450 * menu.h, termhooks.h: Include "systime.h", for Time.
3451
3452 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3453 Don't assume that the difference between two unsigned long values
3454 can fit into an integer. At this point, we know button_down_time
3455 <= event->timestamp, so the difference must be nonnegative, so
3456 there's no need to cast the result if double-click-time is
3457 nonnegative, as it should be; check that it's nonnegative, just in
3458 case. This bug is triggered when events are more than 2**31 ms
3459 apart (about 25 days). (Bug#8664)
3460
3461 * xselect.c (last_event_timestamp): Remove duplicate decl.
3462 (x_own_selection): Remove needless cast to unsigned long.
3463
3464 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3465 that always fit in int. Use a sentinel instead of a counter, to
3466 avoid a temp and to allay GCC's concerns about possible int overflow.
3467 * frame.h (struct frame): Use int for menu_bar_items_used
3468 instead of EMACS_INT, since it always fits in int.
3469
3470 * menu.c (grow_menu_items): Check for int overflow.
3471
3472 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3473
3474 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3475 Before, the code was not consistent. These values cannot exceed
3476 2**31 - 1 so there's no need to make them unsigned.
3477 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3478 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3479 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3480 as modifiers.
3481 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3482
3483 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3484 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3485 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3486 presumably because the widths might not match.
3487
3488 * window.c (size_window): Avoid needless test at loop start.
3489
3490 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3491
3492 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3493
3494 2011-05-12 Drew Adams <drew.adams@oracle.com>
3495
3496 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3497
3498 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3499
3500 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3501 `width' to `bar_area_x' and `bar_area_width', respectively.
3502 (x_scroll_run): Take account of fringe background extension.
3503
3504 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3505 Rename local vars `left' and `width' to `bar_area_x' and
3506 `bar_area_width', respectively.
3507 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3508 background extension.
3509
3510 2011-05-10 Jim Meyering <meyering@redhat.com>
3511
3512 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3513
3514 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3515
3516 * image.c (Finit_image_library): Return t for built-in image types,
3517 like pbm and xbm. (Bug#8640)
3518
3519 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3520
3521 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3522
3523 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3524
3525 * w32console.c (Fset_screen_color): Doc fix.
3526 (Fget_screen_color): New function.
3527 (syms_of_ntterm): Defsubr it.
3528
3529 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3530 unlink the temporary file if Fcall_process didn't create it in the
3531 first place.
3532 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3533 child process will be redirected to a file specified with `:file'.
3534 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3535 cue to call_process_cleanup not to close that handle.
3536
3537 2011-05-07 Ben Key <bkey76@gmail.com>
3538
3539 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3540 one of two shell specific rules, either bootstrap-temacs-CMD or
3541 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3542 to the previous implementation of the bootstrap-temacs rule.
3543 The bootstrap-temacs-CMD rule is similar to the previous
3544 implementation of the bootstrap-temacs rule except that it
3545 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3546 variable.
3547
3548 These changes, along with some changes to nt/configure.bat,
3549 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3550 earlier fix to add support for --cflags and --ldflags options
3551 that include quotes so that it works whether make uses cmd or
3552 sh as the shell.
3553
3554 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3555
3556 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3557 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3558 is a constant.
3559 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3560 a string. Handle both cases.
3561 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3562 (Fdbus_register_method): Use Qinvalid_function.
3563
3564 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3565
3566 * makefile.w32-in: Update dependencies.
3567 (LISP_H): Add inttypes.h and stdin.h.
3568 (PROCESS_H): Add unistd.h.
3569
3570 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3571
3572 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3573 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3574
3575 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3576
3577 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3578
3579 * term.c (vfatal): Remove stray call to va_end.
3580 It's not needed and the C Standard doesn't allow it here anyway.
3581
3582 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3583 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3584
3585 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3586 bytes.
3587
3588 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3589
3590 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3591
3592 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3593
3594 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3595
3596 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3597
3598 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3599 * charset.c (Fdefine_charset_internal): Don't initialize
3600 charset.code_space[15]. The value was garbage, on hosts with
3601 32-bit int (Bug#8600).
3602
3603 * lread.c (read_integer): Be more consistent with string-to-number.
3604 Use string_to_number to do the actual conversion; this avoids
3605 rounding errors and fixes some other screwups. Without this fix,
3606 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3607 (digit_to_number): Move earlier, for benefit of read_integer.
3608 Return -1 if the digit is out of range for the base, -2 if it is
3609 not a digit in any supported base. (Bug#8602)
3610
3611 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3612
3613 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3614 to match comment at start of function. This also removes a
3615 GCC warning about overflow in a 32+64-bit port.
3616
3617 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3618
3619 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3620 Reported by Stefan Monnier in
3621 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3622 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3623 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3624
3625 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3626 (EMACS_UINTPTR): Likewise, with uintptr_t.
3627
3628 * lisp.h: Prefer 64-bit EMACS_INT if available.
3629 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3630 on 32-bit hosts that have 64-bit int, so that they can access
3631 large files.
3632 However, temporarily disable this change unless the temporary
3633 symbol WIDE_EMACS_INT is defined.
3634
3635 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3636
3637 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3638 This removes an assumption that EMACS_INT and long are the same
3639 width as pointers. The assumption is true for Emacs porting targets
3640 now, but we want to make other targets possible.
3641 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3642 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3643 In the rest of the code, change types of integers that hold casted
3644 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3645 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3646 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3647 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3648 No need to cast type when ORing.
3649 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3650 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3651 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3652 assume EMACS_INT is the same width as char *.
3653 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3654 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3655 Remove no-longer-needed casts.
3656 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3657 (xg_tool_bar_help_callback, xg_make_tool_item):
3658 Use EMACS_INTPTR to hold an integer
3659 that will be cast to void *; this can avoid a GCC warning
3660 if EMACS_INT is not the same width as void *.
3661 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3662 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3663 (current_message_1, set_message_1):
3664 Use a local to convert to proper width without a cast.
3665 * xmenu.c (dialog_selection_callback): Likewise.
3666
3667 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3668 Also, don't assume VALBITS / RAND_BITS is less than 5,
3669 and don't rely on undefined behavior when shifting a 1 left into
3670 the sign bit.
3671 * lisp.h (get_random): Change signature to match.
3672
3673 * lread.c (hash_string): Use size_t, not int, for hash computation.
3674 Normally we prefer signed values; but hashing is special, because
3675 it's better to use unsigned division on hash table sizes so that
3676 the remainder is nonnegative. Also, size_t is the natural width
3677 for hashing into memory. The previous code used 'int', which doesn't
3678 retain enough info to hash well into very large tables.
3679 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3680
3681 * dbusbind.c: Don't possibly lose pointer info when converting.
3682 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3683 Use XPNTR rather than XHASH, so that the high-order bits of
3684 the pointer aren't lost when converting through void *.
3685
3686 * eval.c (Fautoload): Don't double-shift a pointer.
3687
3688 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3689
3690 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3691
3692 * gnutls.c (DEF_GNUTLS_FN):
3693 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3694
3695 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3696
3697 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3698 marker. (Bug#8610)
3699
3700 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3701
3702 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3703 New version that can reserve upto 2GB of heap space.
3704
3705 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3706
3707 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3708
3709 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3710
3711 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3712 `gnutls_certificate_set_x509_key_file'.
3713
3714 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3715
3716 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3717 Update dependencies.
3718
3719 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3720
3721 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3722 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3723 Remove unused parameter `fildes'.
3724 * process.c (read_process_output, send_process): Don't pass it.
3725
3726 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3727
3728 Fix previous change: the library cache is defined in w32.c.
3729 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3730 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3731
3732 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3733
3734 Implement dynamic loading of GnuTLS on Windows.
3735
3736 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3737 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3738 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3739 Declare.
3740
3741 * gnutls.c (Qgnutls_dll): Define.
3742 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3743 (gnutls_*): Declare function pointers.
3744 (init_gnutls_functions): New function to initialize function pointers.
3745 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3746 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3747 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3748 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3749 (emacs_gnutls_write, emacs_gnutls_read)
3750 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3751 (Fgnutls_available_p): New function.
3752 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3753 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3754 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3755
3756 * image.c: Include w32.h.
3757 (Vimage_type_cache): Delete.
3758 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3759 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3760 (w32_delayed_load): Move to w32.c.
3761
3762 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3763
3764 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3765 (w32_delayed_load): Move from image.c. When loading a library, record
3766 its filename in the :loaded-from property of the library id.
3767 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3768 Initialize and staticpro them.
3769 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3770
3771 * process.c: Include lisp.h before w32.h, not after.
3772 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3773 instead of gnutls_record_check_pending.
3774
3775 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3776
3777 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3778
3779 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3780 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3781 as passed in.
3782
3783 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3784
3785 * xterm.c (x_set_frame_alpha): Do not set property on anything
3786 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3787
3788 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3789
3790 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3791
3792 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3793
3794 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3795 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3796 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3797 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3798 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3799 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3800 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3801 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3802 (Qgnutls_bootprop_callbacks_verify): Make static.
3803
3804 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3805
3806 * callproc.c: Indentation fixup.
3807
3808 * sysdep.c (wait_for_termination_1): Make static.
3809 (wait_for_termination, interruptible_wait_for_termination):
3810 Move after wait_for_termination_1.
3811
3812 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3813
3814 * sysdep.c (interruptible_wait_for_termination): New function
3815 which is like wait_for_termination, but allows keyboard
3816 interruptions.
3817
3818 * callproc.c (Fcall_process): Add (:file "file") as an option for
3819 the STDOUT buffer.
3820 (Fcall_process_region): Ditto.
3821
3822 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3823
3824 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3825 rather than `XVECTOR (FOO)->size'.
3826
3827 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3828 inttypes.h, as a gnulib replacement is used if it not available in
3829 system headers.
3830
3831 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3832
3833 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3834 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3835 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3836
3837 * coding.c (coding_alloc_by_realloc): Error out if destination
3838 will grow beyond MOST_POSITIVE_FIXNUM.
3839 (decode_coding_emacs_mule): Abort if there isn't enough place in
3840 charbuf for the composition carryover bytes. Reserve an extra
3841 space for up to 2 characters produced in a loop.
3842 (decode_coding_iso_2022): Abort if there isn't enough place in
3843 charbuf for the composition carryover bytes.
3844
3845 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3846
3847 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3848 aborting when %lld or %lll format is passed.
3849 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3850 %llo or %llx format is passed. (Bug#8545)
3851
3852 * window.c (window_scroll_line_based): Use a marker instead of
3853 simple variables to record original value of point. (Bug#7952)
3854
3855 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3856 produced by %s or %c overflows available buffer space. (Bug#8545)
3857
3858 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3859
3860 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3861 (SIZE_MAX): Move defn after all includes, as they might #define it.
3862
3863 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3864
3865 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3866
3867 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3868
3869 * keyboard.c (Qdelayed_warnings_hook): Define.
3870 (command_loop_1): Run `delayed-warnings-hook'
3871 if Vdelayed_warnings_list is non-nil.
3872 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3873 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3874
3875 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3876
3877 * doprnt.c (doprnt): Don't return value smaller than the buffer
3878 size if the message was truncated. (Bug#8545).
3879
3880 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3881
3882 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3883 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3884
3885 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3886
3887 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3888
3889 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3890
3891 * makefile.w32-in: Update dependencies.
3892
3893 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3894
3895 Improve `doprnt' and its usage. (Bug#8545)
3896 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3897 `format_end'. Remove support for %l as a conversion specifier.
3898 Don't use xrealloc. Improve diagnostics when the %l size modifier
3899 is used. Update the commentary.
3900
3901 * eval.c (verror): Simplify calculation of size_t.
3902
3903 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3904 messages.
3905
3906 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3907
3908 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3909 change.
3910
3911 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3912
3913 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3914 This makes this file independent of the recent pseudovector change.
3915
3916 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3917
3918 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3919
3920 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3921 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3922 Remove unused local.
3923 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3924
3925 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3926 GCC 4.6.0 optimizes based on type-based alias analysis.
3927 For example, if b is of type struct buffer * and v of type struct
3928 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3929 != &v->size, and therefore "v->size = 1; b->size = 2; return
3930 v->size;" must therefore return 1. This assumption is incorrect
3931 for Emacs, since it type-puns struct Lisp_Vector * with many other
3932 types. To fix this problem, this patch adds a new type struct
3933 vectorlike_header that documents the constraints on layout of vectors
3934 and pseudovectors, and helps optimizing compilers not get fooled
3935 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3936 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3937 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3938 the size member.
3939 (XSETPVECTYPE): Rewrite in terms of new macro.
3940 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3941 This is a bit clearer, and further avoids the possibility of
3942 undesirable aliasing.
3943 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3944 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3945 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3946 since Lisp_Subr is a special case (no "next" field).
3947 (ASIZE): Now uses header.size rather than size.
3948 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3949 to avoid the hassle of writing XVECTOR (foo)->header.size.
3950 (struct vectorlike_header): New type.
3951 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3952 object, to help avoid aliasing.
3953 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3954 (SUBRP): Likewise, since Lisp_Subr is a special case.
3955 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3956 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3957 (struct Lisp_Hash_Table): Combine first two members into a single
3958 struct vectorlike_header member. All uses of "size" and "next" members
3959 changed to be "header.size" and "header.next".
3960 * buffer.h (struct buffer): Likewise.
3961 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3962 * frame.h (struct frame): Likewise.
3963 * process.h (struct Lisp_Process): Likewise.
3964 * termhooks.h (struct terminal): Likewise.
3965 * window.c (struct save_window_data, struct saved_window): Likewise.
3966 * window.h (struct window): Likewise.
3967 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3968 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3969 * buffer.c (init_buffer_once): Likewise.
3970 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3971 special case.
3972 * process.c (Fformat_network_address): Use local var for size,
3973 for brevity.
3974
3975 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3976
3977 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3978 * data.c (atof): Remove decl; no longer used or needed.
3979 (digit_to_number): Move to lread.c.
3980 (Fstring_to_number): Use new string_to_number function, to be
3981 consistent with how the Lisp reader treats infinities and NaNs.
3982 Do not assume that floating-point numbers represent EMACS_INT
3983 without losing information; this is not true on most 64-bit hosts.
3984 Avoid double-rounding errors, by insisting on integers when
3985 parsing non-base-10 numbers, as the documentation specifies.
3986 * lisp.h (string_to_number): New decl, replacing ...
3987 (isfloat_string): Remove.
3988 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3989 (read1): Do not accept +. and -. as integers; this
3990 appears to have been a coding error. Similarly, do not accept
3991 strings like +-1e0 as floating point numbers. Do not report
3992 overflow for integer overflows unless the base is not 10 which
3993 means we have no simple and reliable way to continue.
3994 Break out the floating-point parsing into a new
3995 function string_to_number, so that Fstring_to_number parses
3996 floating point numbers consistently with the Lisp reader.
3997 (digit_to_number): Move here from data.c. Make it static inline.
3998 (E_CHAR, EXP_INT): Remove, replacing with ...
3999 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4000 (string_to_number): New function, replacing isfloat_string.
4001 This function checks for valid syntax and produces the resulting
4002 Lisp float number too. Rework it so that string-to-number
4003 no longer mishandles examples like "1.0e+". Use strtoumax,
4004 so that overflow for non-base-10 numbers is reported only when
4005 there's no portable and simple way to convert to floating point.
4006
4007 * textprop.c (set_text_properties_1): Rewrite for clarity,
4008 and to avoid GCC warning about integer overflow.
4009
4010 * intervals.h (struct interval): Use EMACS_INT for members
4011 where EMACS_UINT might cause problems. See
4012 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4013 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4014 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4015 All uses changed.
4016 (offset_intervals): Tell GCC not to worry about length overflow
4017 when negating a negative length.
4018
4019 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4020 (overrun_check_free): Likewise.
4021
4022 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4023 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4024 word size.
4025
4026 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4027 (gnutls_make_error): Rename local to avoid shadowing.
4028 (gnutls_emacs_global_deinit): ifdef out; not used.
4029 (Fgnutls_boot): Use const for pointer to readonly storage.
4030 Comment out unused local. Fix pointer signedness problems.
4031
4032 * lread.c (openp): Don't stuff size_t into an 'int'.
4033 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4034 about possible signed overflow.
4035
4036 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4037 (GDK_KEY_g): Don't define if already defined.
4038 (xg_prepare_tooltip): Avoid pointer signedness problem.
4039 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4040
4041 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4042 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4043
4044 * xfns.c (Fx_window_property): Simplify a bit,
4045 to make a bit faster and to avoid GCC 4.6.0 warning.
4046 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4047
4048 * fns.c (internal_equal): Don't assume size_t fits in int.
4049
4050 * alloc.c (compact_small_strings): Tighten assertion a little.
4051
4052 Replace pEd with more-general pI, and fix some printf arg casts.
4053 * lisp.h (pI): New macro, generalizing old pEd macro to other
4054 conversion specifiers. For example, use "...%"pI"d..." rather
4055 than "...%"pEd"...".
4056 (pEd): Remove. All uses replaced with similar uses of pI.
4057 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4058 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4059 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4060 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4061 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4062 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4063 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4064 64-bit hosts.
4065 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4066 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4067 * print.c (safe_debug_print, print_object): Likewise.
4068 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4069 to int.
4070 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4071 avoiding the 0 flag, which is not portable.
4072 * process.c (Fmake_network_process): Use pI to avoid cast.
4073 * region-cache.c (pp_cache): Likewise.
4074 * xdisp.c (decode_mode_spec): Likewise.
4075 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4076 behavior on 64-bit hosts with printf arg.
4077 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4078 (x_stop_queuing_selection_requests): Likewise.
4079 (x_get_window_property): Don't truncate byte count to an 'int'
4080 when tracing.
4081
4082 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4083 here, since it parses constructs like leading '-' and spaces,
4084 which are not wanted; and it overflows with large numbers.
4085 Instead, simply match F[0-9]+, which is what is wanted anyway.
4086
4087 * alloc.c: Remove unportable assumptions about struct layout.
4088 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4089 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4090 (allocate_vectorlike, make_pure_vector): Use the new macros,
4091 plus offsetof, to remove unportable assumptions about struct layout.
4092 These assumptions hold on all porting targets that I know of, but
4093 they are not guaranteed, they're easy to remove, and removing them
4094 makes further changes easier.
4095
4096 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4097 This doesn't fix a bug but makes the code clearer.
4098 (string_overrun_cookie): Now const. Use initializers that
4099 don't formally overflow signed char, to avoid warnings.
4100 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4101 can cause Emacs to crash when string overrun checking is enabled.
4102 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4103 multiple of sizeof (EMACS_INT); it need not be, if
4104 alignof(EMACS_INT) < sizeof (EMACS_INT).
4105 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4106
4107 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4108
4109 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4110
4111 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4112
4113 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4114 supposed to be handshaking. (Bug#8556)
4115 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4116
4117 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4118
4119 * lisp.h (Qdebug): List symbol.
4120 * eval.c (Qdebug): Restore global linkage.
4121 * keyboard.c (debug-on-event): New variable.
4122 (handle_user_signal): Break into debugger when debug-on-event
4123 matches the current signal symbol.
4124
4125 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4126
4127 * alloc.c (check_sblock, check_string_bytes)
4128 (check_string_free_list): Convert to standard C.
4129
4130 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4131
4132 * w32.c (emacs_gnutls_push): Fix typo.
4133
4134 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4135
4136 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4137 "cast to pointer from integer of different size".
4138
4139 Improve doprnt and its use in verror. (Bug#8545)
4140 * doprnt.c (doprnt): Document the set of format control sequences
4141 supported by the function. Use SAFE_ALLOCA instead of always
4142 using `alloca'.
4143
4144 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4145 is one byte too soon. Don't use xrealloc; instead xfree and
4146 xmalloc anew.
4147
4148 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4149
4150 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4151 callbacks stage.
4152
4153 * gnutls.c: Renamed global_initialized to
4154 gnutls_global_initialized. Added internals for the
4155 :verify-hostname-error, :verify-error, and :verify-flags
4156 parameters of `gnutls-boot' and documented those parameters in the
4157 docstring. Start callback support.
4158 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4159 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4160 on error. Return error code.
4161 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4162 (emacs_gnutls_read): Likewise.
4163 (Fgnutls_boot): Return handshake error code.
4164 (emacs_gnutls_handle_error): New function.
4165 (wsaerror_to_errno): Likewise.
4166
4167 * w32.h (emacs_gnutls_pull): Add prototype.
4168 (emacs_gnutls_push): Likewise.
4169
4170 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4171 (emacs_gnutls_push): Likewise.
4172
4173 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4174
4175 * process.c (wait_reading_process_output): Check if GnuTLS
4176 buffered some data internally if no FDs are set for TLS
4177 connections.
4178
4179 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4180 (LIBS): Link to USER_LIBS.
4181 ($(BLD)/gnutls.$(0)): New target.
4182
4183 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4184
4185 * xdisp.c (handle_single_display_spec): Rename the
4186 display_replaced_before_p argument into display_replaced_p, to
4187 make it consistent with the commentary. Fix typos in the
4188 commentary.
4189
4190 * textprop.c (syms_of_textprop): Remove dead code.
4191 (copy_text_properties): Delete obsolete commentary about an
4192 interface that was deleted long ago. Fix typos in the description
4193 of arguments.
4194
4195 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4196 to changes in oldXMenu/XMenu.h from 2011-04-16.
4197 <menu_help_message, prev_menu_help_message>: Constify.
4198 (IT_menu_make_room): menu->help_text is now `const char **';
4199 adjust.
4200
4201 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4202 to changes in oldXMenu/XMenu.h from 2011-04-16.
4203 (struct XMenu): Declare `help_text' `const char **'.
4204
4205 * xfaces.c <Qunspecified>: Make extern again.
4206
4207 * syntax.c: Include sys/types.h before including regex.h, as
4208 required by Posix.
4209
4210 * doc.c (get_doc_string): Improve the format passed to `error'.
4211
4212 * doprnt.c (doprnt): Improve commentary.
4213
4214 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4215
4216 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4217 them with etags.
4218
4219 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4220 changes in globals.h immediately force recompilation.
4221 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4222 $(CURDIR)/s/ms-w32.h.
4223 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4224
4225 * character.c (Fchar_direction): Function deleted.
4226 (syms_of_character): Don't defsubr it.
4227 <char-direction-table>: Deleted.
4228
4229 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4230
4231 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4232 * doprnt.c: Include limits.h.
4233 (SIZE_MAX): New macro.
4234 (doprnt): Return a size_t value. 2nd arg is now size_t.
4235 Many local variables are now size_t instead of int or unsigned.
4236 Improve overflow protection. Support `l' modifier for integer
4237 conversions. Support %l conversion. Don't assume an EMACS_INT
4238 argument for integer conversions and for %c.
4239
4240 * lisp.h (doprnt): Restore prototype.
4241
4242 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4243 $(SRC)/character.h.
4244
4245 * Makefile.in (base_obj): Add back doprnt.o.
4246
4247 * deps.mk (doprnt.o): Add back prerequisites.
4248 (callint.o): Depend on character.h.
4249
4250 * eval.c (internal_lisp_condition_case): Include the handler
4251 representation in the error message.
4252 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4253 when breaking from the loop.
4254
4255 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4256
4257 * callint.c (Fcall_interactively): When displaying error message
4258 about invalid control letter, pass the character's codepoint, not
4259 a pointer to its multibyte form. Improve display of the character
4260 in octal and display also its hex code.
4261
4262 * character.c (char_string): Use %x to display the (unsigned)
4263 codepoint of an invalid character, to avoid displaying a bogus
4264 negative value.
4265
4266 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4267 `error', not SYMBOL_NAME itself.
4268
4269 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4270 character arguments to `error'.
4271
4272 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4273 to `error' in error message about FINAL_CHAR argument. Make sure
4274 FINAL_CHAR is a character, and use %c when it is passed as
4275 argument to `error'.
4276
4277 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4278
4279 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4280
4281 * w32.c: Include <time.h>.
4282 (sys_localtime): New function.
4283
4284 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4285
4286 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4287
4288 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4289
4290 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4291
4292 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4293 zombies (Bug#8467).
4294
4295 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4296
4297 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4298 gl_state.e_property when gl_state.object is Qt.
4299
4300 * insdel.c (make_gap_larger): Remove limitation of buffer size
4301 to <= INT_MAX.
4302
4303 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4304
4305 * xdisp.c (lookup_glyphless_char_display)
4306 (produce_glyphless_glyph): Handle cons cell entry in
4307 glyphless-char-display.
4308 (Vglyphless_char_display): Document it.
4309
4310 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4311 glyphless-char-display.
4312
4313 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4314
4315 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4316
4317 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4318
4319 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4320 definition for no-X builds.
4321
4322 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4323
4324 Static checks with GCC 4.6.0 and non-default toolkits.
4325
4326 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4327
4328 * process.c (keyboard_bit_set): Define only if SIGIO.
4329 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4330 (send_process): Repair possible setjmp clobbering.
4331
4332 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4333
4334 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4335
4336 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4337
4338 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4339 Define only if needed.
4340
4341 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4342 by pacifying GCC about it. Maybe it's time to retire it?
4343 * xfaces.c (USG, __TIMEVAL__): Likewise.
4344
4345 * dispextern.h (struct redisplay_interface): Rename param
4346 to avoid shadowing.
4347 * termhooks.h (struct terminal): Likewise.
4348 * xterm.c (xembed_send_message): Likewise.
4349
4350 * insdel.c (make_gap_smaller): Define only if
4351 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4352
4353 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4354 it.
4355
4356 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4357 so that we aren't warned about unused symbols.
4358
4359 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4360
4361 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4362
4363 * xfns.c (x_real_positions): Mark locals as initialized.
4364
4365 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4366
4367 * xterm.c: Fix problems found by static analysis with other toolkits.
4368 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4369 (x_dispatch_event): Declare static if USE_GTK, and
4370 define if USE_GTK || USE_X_TOOLKIT.
4371 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4372 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4373 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4374 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4375
4376 * xmenu.c (menu_help_callback): Pointer type fixes.
4377 Use const pointers when pointing at readonly data. Avoid pointer
4378 signedness clashes.
4379 (FALSE): Remove unused macro.
4380 (update_frame_menubar): Remove unused decl.
4381
4382 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4383
4384 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4385 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4386 (single_menu_item): Rename local to avoid shadowing.
4387
4388 * keyboard.c (make_lispy_event): Remove unused local var.
4389
4390 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4391 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4392
4393 * bitmaps: Change bitmaps from unsigned char back to the X11
4394 compatible char. Avoid the old compiler warnings about
4395 out-of-range initializers by using, for example, '\xab' rather
4396 than 0xab.
4397
4398 * xgselect.c (xgselect_initialize): Check vs interface
4399 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4400
4401 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4402
4403 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4404 to read-only memory.
4405
4406 * fns.c (vector): Remove; this old hack is no longer needed.
4407
4408 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4409 Remove unused var.
4410 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4411
4412 * xrdb.c (x_load_resources): Omit unused local.
4413
4414 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4415 (x_window): Rename locals to avoid shadowing.
4416 (USG): Use the kludged USG macro, to pacify gcc.
4417
4418 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4419 (x_term_init): Remove local to avoid shadowing.
4420
4421 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4422
4423 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4424 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4425
4426 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4427
4428 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4429
4430 Fix regex.c, syntax.c and friends for buffers > 2GB.
4431 * syntax.h (struct gl_state_s): Declare character position members
4432 EMACS_INT.
4433
4434 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4435
4436 * textprop.c (verify_interval_modification, interval_of):
4437 Declare arguments EMACS_INT.
4438
4439 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4440 EMACS_INT.
4441
4442 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4443
4444 * indent.c (Fvertical_motion): Local variable it_start is now
4445 EMACS_INT.
4446
4447 * regex.c (re_match, re_match_2, re_match_2_internal)
4448 (bcmp_translate, regcomp, regexec, print_double_string)
4449 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4450 (re_compile_pattern, re_exec): Declare arguments and local
4451 variables `size_t' and `ssize_t' and return values `regoff_t', as
4452 appropriate.
4453 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4454 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4455 <compile_stack_type>: `size' and `avail' are now `size_t'.
4456
4457 * regex.h <regoff_t>: Use ssize_t, not int.
4458 (re_search, re_search_2, re_match, re_match_2): Arguments that
4459 specify buffer/string position and length are now ssize_t and
4460 size_t. Return type is regoff_t.
4461
4462 2011-04-16 Ben Key <bkey76@gmail.com>
4463
4464 * nsfont.m: Fixed bugs in ns_get_family and
4465 ns_descriptor_to_entity that were caused by using free to
4466 deallocate memory blocks that were allocated by xmalloc (via
4467 xstrdup). This caused Emacs to crash when compiled with
4468 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4469 --enable-checking=xmallocoverrun). xfree is now used to
4470 deallocate these memory blocks.
4471
4472 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4473
4474 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4475
4476 emacs_write: Accept and return EMACS_INT for sizes.
4477 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4478 et seq.
4479 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4480 Accept and return EMACS_INT.
4481 (emacs_gnutls_write): Return the number of bytes written on
4482 partial writes.
4483 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4484 (emacs_read, emacs_write): Remove check for negative size, as the
4485 Emacs source code has been audited now.
4486 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4487 (emacs_read, emacs_write): Use it.
4488 * process.c (send_process): Adjust to the new signatures of
4489 emacs_write and emacs_gnutls_write. Do not attempt to store
4490 a byte offset into an 'int'; it might overflow.
4491 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4492
4493 * sound.c: Don't assume sizes fit in 'int'.
4494 (struct sound_device.period_size, alsa_period_size):
4495 Return EMACS_INT, not int.
4496 (struct sound_device.write, vox_write, alsa_write):
4497 Accept EMACS_INT, not int.
4498 (wav_play, au_play): Use EMACS_INT to store sizes and to
4499 record read return values.
4500
4501 2011-04-15 Ben Key <bkey76@gmail.com>
4502
4503 * keyboard.c (Qundefined): Don't declare static since it is used
4504 in nsfns.m.
4505 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4506 static since they are used in nsfont.m.
4507
4508 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4509
4510 * process.c (Qprocessp): Don't declare static.
4511 * lisp.h (Qprocessp): Declare again.
4512
4513 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4514
4515 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4516
4517 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4518
4519 Improve C-level modularity by making more things 'static'.
4520
4521 Don't publish debugger-only interfaces to other modules.
4522 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4523 (verify_bytepos, count_markers): Move decls to the only modules
4524 that need them.
4525 * region-cache.h (pp_cache): Likewise.
4526 * window.h (check_all_windows): Likewise.
4527 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4528
4529 * sysdep.c (croak): Now static, if
4530 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4531 * syssignal.h (croak): Declare only if not static.
4532
4533 * alloc.c (refill_memory_reserve): Now static if
4534 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4535 * lisp.h (refill_memory_reserve): Declare only if not static.
4536
4537 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4538 Define only if USE_LUCID.
4539
4540 * xrdb.c (x_customization_string, x_rm_string): Now static.
4541
4542 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4543 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4544
4545 * xdisp.c (draw_row_with_mouse_face): Now static.
4546 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4547
4548 * window.h (check_all_windows): Mark externally visible.
4549
4550 * window.c (window_deletion_count): Now static.
4551
4552 * undo.c: Make symbols static if they're not exported.
4553 (last_undo_buffer, last_boundary_position, pending_boundary):
4554 Now static.
4555
4556 * textprop.c (interval_insert_behind_hooks): Now static.
4557 (interval_insert_in_front_hooks): Likewise.
4558
4559 * term.c: Make symbols static if they're not exported.
4560 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4561 (max_frame_lines, tty_set_terminal_modes):
4562 (tty_reset_terminal_modes, tty_turn_off_highlight):
4563 (get_tty_terminal): Now static.
4564 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4565 * termhooks.h (term_mouse_moveto): Do not declare if
4566 HAVE_WINDOW_SYSTEM.
4567 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4568 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4569
4570 * sysdep.c: Make symbols static if they're not exported.
4571 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4572 Now static.
4573 (sigprocmask_set, full_mask): Remove; unused.
4574 (wait_debugging): Mark as visible.
4575 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4576 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4577
4578 * syntax.c (syntax_temp): Define only if !__GNUC__.
4579
4580 * sound.c (current_sound_device, current_sound): Now static.
4581
4582 * search.c (searchbufs, searchbuf_head): Now static.
4583
4584 * scroll.c (scroll_cost): Remove; unused.
4585 * dispextern.h (scroll_cost): Remove decl.
4586
4587 * region-cache.h (pp_cache): Mark as externally visible.
4588
4589 * process.c: Make symbols static if they're not exported.
4590 (process_tick, update_tick, create_process, chan_process):
4591 (Vprocess_alist, proc_buffered_char, datagram_access):
4592 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4593 (deactivate_process): Mark defn as static, as well as decl.
4594 * lisp.h (create_process): Remove decl.
4595 * process.h (chan_process, Vprocess_alist): Remove decls.
4596
4597 * print.c: Make symbols static if they're not exported.
4598 (print_depth, new_backquote_output, being_printed, print_buffer):
4599 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4600 (print_interval, print_number_index, initial_stderr_stream):
4601 Now static.
4602 * lisp.h (Fprinc): Remove decl.
4603 (debug_output_compilation_hack): Mark as externally visible.
4604
4605 * sysdep.c (croak): Move decl from here to syssignal.h.
4606 * syssignal.h (croak): Put it here, so the API can be checked when
4607 'croak' is called from dissociate_if_controlling_tty.
4608
4609 * minibuf.c: Make symbols static if they're not exported.
4610 (minibuf_save_list, choose_minibuf_frame): Now static.
4611 * lisp.h (choose_minibuf_frame): Remove decl.
4612
4613 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4614
4615 * lread.c: Make symbols static if they're not exported.
4616 (read_objects, initial_obarray, oblookup_last_bucket_number):
4617 Now static.
4618 (make_symbol): Remove; unused.
4619 * lisp.h (initial_obarray, make_symbol): Remove decls.
4620
4621 * keyboard.c: Make symbols static if they're not exported.
4622 (single_kboard, recent_keys_index, total_keys, recent_keys):
4623 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4624 (this_single_command_key_start, echoing, last_auto_save):
4625 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4626 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4627 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4628 (Vlispy_mouse_stem, double_click_count):
4629 Now static.
4630 (force_auto_save_soon): Define only if SIGDANGER.
4631 (ignore_mouse_drag_p): Now static if
4632 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4633 (print_help): Remove; unused.
4634 (stop_character, last_timer_event): Mark as externally visible.
4635 * keyboard.h (ignore_mouse_drag_p): Declare only if
4636 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4637 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4638 * lisp.h (echoing): Remove decl.
4639 (force_auto_save_soon): Declare only if SIGDANGER.
4640 * xdisp.c (redisplay_window): Simplify code, to make it more
4641 obvious that ignore_mouse_drag_p is not accessed if !defined
4642 USE_GTK && !defined HAVE_NS.
4643
4644 * intervals.c: Make symbols static if they're not exported.
4645 (merge_properties_sticky, merge_interval_right, delete_interval):
4646 Now static.
4647 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4648
4649 * insdel.c: Make symbols static if they're not exported.
4650 However, leave prepare_to_modify_buffer alone. It's never
4651 called from outside this function, but that appears to be a bug.
4652 (combine_after_change_list, combine_after_change_buffer):
4653 (adjust_after_replace, signal_before_change): Now static.
4654 (adjust_after_replace_noundo): Remove; unused.
4655 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4656 (signal_before_change): Remove decls.
4657
4658 * indent.c (val_compute_motion, val_vmotion): Now static.
4659
4660 * image.c: Make symbols static if they're not exported.
4661 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4662 if USE_GTK.
4663 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4664 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4665
4666 * fringe.c (standard_bitmaps): Now static.
4667 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4668
4669 * frame.c: Make symbols static if they're not exported.
4670 (x_report_frame_params, make_terminal_frame): Now static.
4671 (get_frame_param): Now static, unless HAVE_NS.
4672 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4673 (x_get_resource_string): Remove; not used.
4674 * frame.h (make_terminal_frame, x_report_frame_params):
4675 (x_get_resource_string); Remove decls.
4676 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4677 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4678
4679 * font.c, fontset.c: Make symbols static if they're not exported.
4680 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4681 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4682 * font.c (font_close_object): Now static.
4683 * font.h (font_close_object): Remove.
4684 * fontset.c (FONTSET_OBJLIST): Remove.
4685 (free_realized_fontset) #if-0 the body, which does nothing.
4686 (face_suitable_for_char_p): #if-0, as it's never called.
4687 * fontset.h (face_suitable_for_char_p): Remove decl.
4688 * xfaces.c (face_at_string_position):
4689 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4690 since 0 is always ASCII.
4691
4692 * fns.c (weak_hash_tables): Now static.
4693
4694 * fileio.c: Make symbols static if they're not exported.
4695 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4696 (Vwrite_region_annotation_buffers): Now static.
4697
4698 * eval.c: Make symbols static if they're not exported.
4699 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4700 * lisp.h (backtrace_list): Remove decl.
4701
4702 * emacs.c: Make symbols static if they're not exported.
4703 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4704 (fatal_error_code, fatal_error_signal_hook, standard_args):
4705 Now static.
4706 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4707 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4708 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4709 * lisp.h (fatal_error_signal_hook): Remove decl.
4710 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4711
4712 * editfns.c: Move a (normally-unused) function to its only use.
4713 * editfns.c, lisp.h (get_operating_system_release): Remove.
4714 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4715 worth the hassle of breaking this out.
4716
4717 * xterm.c: Make symbols static if they're not exported.
4718 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4719 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4720 (x_destroy_window, x_delete_display):
4721 Now static.
4722 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4723 (x_mouse_leave): Remove; unused.
4724 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4725 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4726 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4727 Remove decls.
4728 (x_mouse_leave): Declare only if WINDOWSNT.
4729 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4730 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4731 USE_X_TOOLKIT.
4732
4733 * ftxfont.c: Make symbols static if they're not exported.
4734 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4735 HAVE_FREETYPE.
4736 * font.h (ftxfont_driver): Likewise.
4737
4738 * xfns.c: Make symbols static if they're not exported.
4739 (x_last_font_name, x_display_info_for_name):
4740 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4741 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4742 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4743 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4744 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4745 (last_show_tip_args): Now static.
4746 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4747 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4748 (x_screen_planes): Remove; unused.
4749 * dispextern.h (x_screen_planes): Remove decl.
4750
4751 * dispnew.c: Make symbols static if they're not exported.
4752 * dispextern.h (redraw_garbaged_frames, scrolling):
4753 (increment_row_positions): Remove.
4754 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4755 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4756 Now static.
4757 (redraw_garbaged_frames): Remove; unused.
4758
4759 * xfaces.c: Make symbols static if they're not exported.
4760 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4761 Remove decls.
4762 * xterm.h (defined_color): Remove decls.
4763 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4764 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4765 (menu_face_changed_default, defined_color, free_realized_face):
4766 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4767 (ascii_face_of_lisp_face): Remove; unused.
4768
4769 * xdisp.c: Make symbols static if they're not exported.
4770 * dispextern.h (scratch_glyph_row, window_box_edges):
4771 (glyph_to_pixel_coords, set_cursor_from_row):
4772 (get_next_display_element, set_iterator_to_next):
4773 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4774 (show_mouse_face): Remove decls
4775 * frame.h (message_buf_print): Likewise.
4776 * lisp.h (pop_message, set_message, check_point_in_composition):
4777 Likewise.
4778 * xterm.h (set_vertical_scroll_bar): Likewise.
4779 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4780 (message_buf_print, scratch_glyph_row, displayed_buffer):
4781 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4782 (get_next_display_element, show_mouse_face, window_box_edges):
4783 (frame_to_window_pixel_xy, check_point_in_composition):
4784 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4785 (glyph_to_pixel_coords): Remove; unused.
4786
4787 * dired.c (file_name_completion): Now static.
4788
4789 * dbusbind.c (xd_in_read_queued_messages): Now static.
4790
4791 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4792 * data.c (circular_list_error): Remove.
4793
4794 * commands.h (last_point_position, last_point_position_buffer):
4795 (last_point_position_window): Remove decls.
4796 * keyboard.c: Make these variables static.
4797
4798 * coding.h (coding, code_convert_region, encode_coding_gap):
4799 Remove decls.
4800 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4801 (iso_code_class, detect_coding, code_convert_region): Now static.
4802 (encode_coding_gap): Remove; unused.
4803
4804 * chartab.c (chartab_chars, chartab_bits): Now static.
4805
4806 * charset.h (charset_iso_8859_1): Remove decl.
4807 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4808 Now static.
4809
4810 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4811 * ccl.c (Vccl_program_table): Now static.
4812 (check_ccl_update): Remove; unused.
4813
4814 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4815 * category.h: ... from here.
4816 * category.c (check_category_table, set_category_set): Now static.
4817
4818 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4819 * lisp.h: Remove these decls.
4820
4821 * buffer.c (buffer_count): Remove unused var.
4822
4823 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4824 so that it's not optimized away.
4825 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4826 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4827 exported only to the debugger.
4828
4829 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4830 * atimer.h (run_all_atimers): Remove; not exported.
4831
4832 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4833 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4834 was inaccessible from Lisp.
4835 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4836 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4837
4838 alloc.c: Import and export fewer symbols, and remove unused items.
4839 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4840 is defined.
4841 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4842 it's not optimized away by whole-program optimization.
4843 (message_enable_multibyte, free_misc): Remove.
4844 (catchlist, handlerlist, mark_backtrace):
4845 Declare only if BYTE_MARK_STACK.
4846 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4847 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4848 (message_enable_multibyte): Remove decl.
4849 (free_misc, interval_free_list, float_block, float_block_index):
4850 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4851 (cons_free_list, last_marked_index):
4852 Now static.
4853 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4854 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4855 (mark_backtrace): Define only if BYTE_MARK_STACK.
4856 * xdisp.c (message_enable_multibyte): Now static.
4857
4858 Declare Lisp_Object Q* variables to be 'static' if not exported.
4859 This makes it easier for human readers (and static analyzers)
4860 to see whether these variables are used from other modules.
4861 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4862 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4863 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4864 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4865 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4866 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4867 * xmenu.c, xselect.c:
4868 Declare Q* vars static if they are not used in other modules.
4869 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4870 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4871 Remove decls of unexported vars.
4872 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4873
4874 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4875
4876 Make Emacs functions such as Fatom 'static' by default.
4877 This makes it easier for human readers (and static analyzers)
4878 to see whether these functions can be called from other modules.
4879 DEFUN now defines a static function. To make the function external
4880 so that it can be used in other C modules, use the new macro DEFUE.
4881 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4882 (Finit_image_library):
4883 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4884 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4885 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4886 Remove decls, since these functions are now static.
4887 (Funintern, Fget_internal_run_time): New decls, since these functions
4888 were already external.
4889
4890 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4891 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4892 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4893 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4894 * keyboard.c, keymap.c, lread.c:
4895 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4896 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4897 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4898 Mark functions with DEFUE instead of DEFUN,
4899 if they are used in other modules.
4900 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4901 decls for now-static functions.
4902 * buffer.h (Fdelete_overlay): Remove decl.
4903 * callproc.c (Fgetenv_internal): Mark as internal.
4904 * composite.c (Fremove_list_of_text_properties): Remove decl.
4905 (Fcomposition_get_gstring): New forward static decl.
4906 * composite.h (Fcomposite_get_gstring): Remove decl.
4907 * dired.c (Ffile_attributes): New forward static decl.
4908 * doc.c (Fdocumntation_property): New forward static decl.
4909 * eval.c (Ffetch_bytecode): New forward static decl.
4910 (Funintern): Remove extern decl; now in .h file where it belongs.
4911 * fileio.c (Fmake_symbolic_link): New forward static decl.
4912 * image.c (Finit_image_library): New forward static decl.
4913 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4914 * intervals.h (Fprevious_property_change):
4915 (Fremove_list_of_text_properties): Remove decls.
4916 * keyboard.c (Fthis_command_keys): Remove decl.
4917 (Fcommand_execute): New forward static decl.
4918 * keymap.c (Flookup_key): New forward static decl.
4919 (Fcopy_keymap): Now static.
4920 * keymap.h (Flookup_key): Remove decl.
4921 * process.c (Fget_process): New forward static decl.
4922 (Fprocess_datagram_address): Mark as internal.
4923 * syntax.c (Fsyntax_table_p): New forward static decl.
4924 (skip_chars): Remove duplicate decl.
4925 * textprop.c (Fprevious_property_change): New forward static decl.
4926 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4927 Now internal.
4928 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4929 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4930
4931 * editfns.c (Fformat): Remove unreachable code.
4932
4933 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4934
4935 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4936 change. (Bug#8496)
4937
4938 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4939
4940 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4941 when at ZV. (Bug#8487)
4942
4943 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4944
4945 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4946 (Bug#8437)
4947 * keyboard.c (parse_tool_bar_item): Likewise.
4948 * sound.c (sound_cleanup, alsa_close): Likewise.
4949 * termcap.c (tgetent): Likewise.
4950 * xfns.c (x_default_font_parameter): Likewise.
4951 * xsettings.c (read_and_apply_settings): Likewise.
4952
4953 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4954 (overrun_check_free): Protoize.
4955
4956 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4957
4958 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4959 since callers should never pass a negative size.
4960 Change the signature to match that of plain 'read' and 'write'; see
4961 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4962 * lisp.h: Update prototypes of emacs_write and emacs_read.
4963
4964 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4965
4966 * xdisp.c (redisplay_window): Don't try to determine the character
4967 position of the scroll margin if the window start point w->startp
4968 is outside the buffer's accessible region. (Bug#8468)
4969
4970 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4971
4972 Fix write-region and its subroutines for buffers > 2GB.
4973 * fileio.c (a_write, e_write): Modify declaration of arguments and
4974 local variables to support buffers larger than 2GB.
4975 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4976
4977 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4978 argument, local variables, and return value.
4979
4980 * lisp.h: Update prototypes of emacs_write and emacs_read.
4981
4982 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4983
4984 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4985
4986 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4987
4988 Fix more problems found by GCC 4.6.0's static checks.
4989
4990 * xdisp.c (vmessage): Use a better test for character truncation.
4991
4992 * charset.c (load_charset_map): <, not <=, for optimization,
4993 and to avoid potential problems with integer overflow.
4994 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4995 * casetab.c (set_identity, shuffle): Likewise.
4996 * editfns.c (Fformat): Likewise.
4997 * syntax.c (skip_chars): Likewise.
4998
4999 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5000 This also lets GCC 4.6.0 generate slightly better loop code.
5001
5002 * callint.c (Fcall_interactively): <, not <=, for optimization.
5003 (Fcall_interactively): Count the number of arguments produced,
5004 not the number of arguments given. This is simpler and lets GCC
5005 4.6.0 generate slightly better code.
5006
5007 * ftfont.c: Distingish more carefully between FcChar8 and char.
5008 The previous code passed unsigned char * to a functions like
5009 strlen and xstrcasecmp that expect char *, which does not
5010 conform to the C standard.
5011 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5012 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5013 char * when the C standard requires it.
5014
5015 * keyboard.c (read_char): Remove unused var.
5016
5017 * eval.c: Port to Windows vsnprintf (Bug#8435).
5018 Include <limits.h>.
5019 (SIZE_MAX): Define if the headers do not.
5020 (verror): Do not give up if vsnprintf returns a negative count.
5021 Instead, grow the buffer. This ports to Windows vsnprintf, which
5022 does not conform to C99. Problem reported by Eli Zaretskii.
5023 Also, simplify the allocation scheme, by avoiding the need for
5024 calling realloc, and removing the ALLOCATED variable.
5025
5026 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5027
5028 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5029 But keep the doprint source code for now, as we might revamp it
5030 and use it again (Bug#8435).
5031 * lisp.h (doprnt): Remove.
5032 * Makefile.in (base_obj): Remove doprnt.o.
5033 * deps.mk (doprnt.o): Remove.
5034
5035 error: Print 32- and 64-bit integers portably (Bug#8435).
5036 Without this change, on typical 64-bit hosts error ("...%d...", N)
5037 was used to print both 32- and 64-bit integers N, which relied on
5038 undefined behavior.
5039 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5040 New macro.
5041 * lisp.h (error, verror): Mark as printf-like functions.
5042 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5043 Report overflow in size calculations when allocating printf buffer.
5044 Do not truncate output string at its first null byte.
5045 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5046 Truncate the output at a character boundary, since vsnprintf does not
5047 do that.
5048 * charset.c (check_iso_charset_parameter): Convert internal
5049 character to string before calling 'error', since %c now has the
5050 printf meaning.
5051 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5052 overflow when computing char to be passed to 'error'. Do not
5053 pass Lisp_Object to 'error'; pass the integer instead.
5054 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5055 formatted with plain %d.
5056
5057 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5058
5059 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5060
5061 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5062
5063 * xterm.c (x_catch_errors): Remove duplicate declaration.
5064
5065 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5066
5067 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5068
5069 2011-04-10 Jim Meyering <meyering@redhat.com>
5070
5071 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5072 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5073 return ssize_t not "int", and use size_t as the buffer length.
5074 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5075 * gnutls.h: Update declarations.
5076 * process.c (read_process_output): Use ssize_t, to match.
5077 (send_process): Likewise.
5078
5079 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5080
5081 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5082
5083 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5084
5085 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5086 Use unsigned char, to match FcChar8 type definition.
5087
5088 * xterm.c (handle_one_xevent):
5089 * xmenu.c (create_and_show_popup_menu):
5090 * xselect.c (x_decline_selection_request)
5091 (x_reply_selection_request): Avoid type-punned deref of X events.
5092
5093 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5094
5095 Fix some uses of `int' instead of EMACS_INT.
5096 * search.c (string_match_1, fast_string_match)
5097 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5098 (scan_buffer, find_next_newline_no_quit)
5099 (find_before_next_newline, search_command, Freplace_match)
5100 (Fmatch_data): Make some `int' variables be EMACS_INT.
5101
5102 * xdisp.c (display_count_lines): 3rd argument and return value now
5103 EMACS_INT. All callers changed.
5104 (pint2hrstr): Last argument is now EMACS_INT.
5105
5106 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5107 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5108 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5109 (decode_coding_utf_16, decode_coding_emacs_mule)
5110 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5111 (decode_coding_ccl, decode_coding_charset)
5112 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5113 (decode_coding_iso_2022, decode_coding_emacs_mule)
5114 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5115 <char_offset, last_offset>: Declare EMACS_INT.
5116 (encode_coding_utf_8, encode_coding_utf_16)
5117 (encode_coding_emacs_mule, encode_invocation_designation)
5118 (encode_designation_at_bol, encode_coding_iso_2022)
5119 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5120 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5121 Declare EMACS_INT.
5122 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5123 (encode_invocation_designation): Last argument P_NCHARS is now
5124 EMACS_INT.
5125 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5126 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5127
5128 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5129 All users changed.
5130
5131 * ccl.c (Fccl_execute_on_string): Declare some variables
5132 EMACS_INT.
5133
5134 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5135
5136 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5137
5138 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5139
5140 * process.c (Fformat_network_address): Doc fix.
5141
5142 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5143
5144 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5145
5146 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5147
5148 * keyboard.c (read_char): Call Lisp function help-form-show,
5149 instead of using internal_with_output_to_temp_buffer.
5150 (Qhelp_form_show): New var.
5151 (syms_of_keyboard): Use DEFSYM macro.
5152
5153 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5154
5155 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5156
5157 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5158
5159 * process.c (Flist_processes): Remove to Lisp.
5160 (list_processes_1): Delete.
5161
5162 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5163
5164 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5165
5166 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5167
5168 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5169
5170 Fix more problems found by GCC 4.6.0's static checks.
5171
5172 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5173
5174 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5175
5176 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5177
5178 * xdisp.c (vmessage): Mark as a printf-like function.
5179
5180 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5181
5182 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5183
5184 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5185 printf-like functions.
5186 (tiff_load): Add casts to remove these marks before passing them
5187 to system-supplied API.
5188
5189 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5190
5191 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5192 This avoids several warnings with gcc -Wstrict-overflow.
5193 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5194 directly, rather than having caller test rule sign. This avoids
5195 some unnecessary tests.
5196 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5197 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5198 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5199
5200 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5201 (xfont_open): Avoid unnecessary tests.
5202
5203 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5204
5205 * composite.h, composite.c (composition_gstring_put_cache):
5206 Use EMACS_INT, not int, for length.
5207
5208 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5209 breaking out part of COMPOSITION_DECODE_RULE.
5210 (COMPOSITION_DECODE_RULE): Use it.
5211 * composite.c (get_composition_id): Remove unused local vars,
5212 by using the new macro.
5213
5214 * textprop.c (set_text_properties_1): Change while to do-while,
5215 since the condition is always true at first.
5216
5217 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5218 (interval_deletion_adjustment): Return unsigned value.
5219 All uses changed.
5220
5221 * process.c (list_processes_1, create_pty, read_process_output):
5222 (exec_sentinel): Remove vars that were set but not used.
5223 (create_pty): Remove unnecessary "volatile"s.
5224 (Fnetwork_interface_info): Avoid possibility of int overflow.
5225 (read_process_output): Do adaptive read buffering even if carryover.
5226 (read_process_output): Simplify nbytes computation if buffered.
5227
5228 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5229
5230 * syntax.c (scan_words): Remove var that was set but not used.
5231 (update_syntax_table): Use unsigned instead of int.
5232
5233 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5234 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5235 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5236
5237 * print.c (print_error_message): Avoid int overflow.
5238
5239 * font.c (font_list_entities): Redo for clarity,
5240 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5241
5242 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5243 (font_score): Avoid potential overflow in diff calculation.
5244
5245 * fns.c (substring_both): Remove var that is set but not used.
5246 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5247
5248 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5249
5250 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5251 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5252 can always succeed if overflow has undefined behavior.
5253
5254 * search.c (boyer_moore, wordify): Remove vars set but not used.
5255 (wordify): Omit three unnecessary tests.
5256
5257 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5258 All callers changed. This avoids the need for an unused var.
5259
5260 * casefiddle.c (casify_region): Remove var that is set but not used.
5261
5262 * dired.c (file_name_completion): Remove var that is set but not used.
5263
5264 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5265
5266 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5267 (Finsert_file_contents): Remove unnecessary code checking fd.
5268
5269 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5270 Check for integer overflow on size calculations.
5271
5272 * buffer.c (Fprevious_overlay_change): Remove var that is set
5273 but not used.
5274
5275 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5276 Remove vars that are set but not used.
5277 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5278 (timer_check_2): Mark vars as initialized.
5279
5280 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5281
5282 * image.c (lookup_image): Remove var that is set but not used.
5283 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5284
5285 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5286 that are set but not used.
5287
5288 * xfns.c (make_invisible_cursor): Don't return garbage
5289 if XCreateBitmapFromData fails (Bug#8410).
5290
5291 * xselect.c (x_get_local_selection, x_handle_property_notify):
5292 Remove vars that are set but not used.
5293
5294 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5295 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5296
5297 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5298 Remove var that is set but not used.
5299 (scroll_bar_windows_size): Now size_t, not int.
5300 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5301 Check for overflow.
5302
5303 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5304 (map_tty_color) [!defined MSDOS]: Likewise.
5305
5306 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5307
5308 * coding.c: Remove vars that are set but not used.
5309 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5310 All callers changed.
5311 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5312 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5313 (decode_coding_charset): Remove vars that are set but not used.
5314
5315 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5316 that is set but not used.
5317
5318 * print.c (print_object): Remove var that is set but not used.
5319
5320 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5321 The gnulib version avoids calling malloc in the usual case,
5322 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5323 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5324 * filelock.c (current_lock_owner): Likewise.
5325 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5326 * sysdep.c: Include allocator.h, careadlinkat.h.
5327 (emacs_no_realloc_allocator): New static constant.
5328 (emacs_readlink): New function.
5329 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5330 ../lib/careadlinkat.h.
5331
5332 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5333
5334 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5335 first non-nil return value).
5336
5337 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5338
5339 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5340 if not defined (Bug#8403).
5341
5342 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5343
5344 * xdisp.c (display_count_lines): Remove parameter `start',
5345 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5346 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5347 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5348 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5349 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5350 and thereabouts. All callers changed.
5351 (get_per_char_metric): Remove parameter `f', unused since
5352 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5353
5354 2011-04-02 Jim Meyering <meyering@redhat.com>
5355
5356 do not dereference NULL upon failed strdup
5357 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5358 (ns_get_family): Likewise.
5359
5360 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5361
5362 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5363
5364 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5365
5366 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5367 later (Bug#8403).
5368
5369 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5370
5371 Add lexical binding.
5372
5373 * window.c (Ftemp_output_buffer_show): New fun.
5374 (Fsave_window_excursion):
5375 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5376
5377 * lread.c (lisp_file_lexically_bound_p): New function.
5378 (Fload): Bind Qlexical_binding.
5379 (readevalloop): Remove `evalfun' arg.
5380 Bind Qinternal_interpreter_environment.
5381 (Feval_buffer): Bind Qlexical_binding.
5382 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5383 Mark as dynamic.
5384 (syms_of_lread): Declare `lexical-binding'.
5385
5386 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5387
5388 * keyboard.c (eval_dyn): New fun.
5389 (menu_item_eval_property): Use it.
5390
5391 * image.c (parse_image_spec): Use Ffunctionp.
5392
5393 * fns.c (concat, mapcar1): Accept byte-code-functions.
5394
5395 * eval.c (Fsetq): Handle lexical vars.
5396 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5397 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5398 (FletX, Flet): Obey lexical binding.
5399 (Fcommandp): Handle closures.
5400 (Feval): New `lexical' arg.
5401 (eval_sub): New function extracted from Feval. Use it almost
5402 everywhere where Feval was used. Look up vars in lexical env.
5403 Handle closures.
5404 (Ffunctionp): Move from subr.el.
5405 (Ffuncall): Handle closures.
5406 (apply_lambda): Remove `eval_flags'.
5407 (funcall_lambda): Handle closures and new byte-code-functions.
5408 (Fspecial_variable_p): New function.
5409 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5410 but without exporting it to Lisp.
5411
5412 * doc.c (Fdocumentation, store_function_docstring):
5413 * data.c (Finteractive_form): Handle closures.
5414
5415 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5416 interactive spec.
5417
5418 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5419 New byte-codes.
5420 (exec_byte_code): New function extracted from Fbyte_code to handle new
5421 calling convention for byte-code-functions. Add new byte-codes.
5422
5423 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5424
5425 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5426
5427 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5428
5429 * xdisp.c (redisplay_internal): Fix prototype.
5430
5431 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5432
5433 * xdisp.c (SCROLL_LIMIT): New macro.
5434 (try_scrolling): Use it when setting scroll_limit.
5435 Limit scrolling to 100 screen lines.
5436 (redisplay_window): Even when falling back on "recentering",
5437 position point in the window according to scroll-conservatively,
5438 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5439
5440 (try_scrolling): When point is above the window, allow searching
5441 as far as scroll_max, or one screenful, to compute vertical
5442 distance from PT to the scroll margin position. This prevents
5443 try_scrolling from unnecessarily failing when
5444 scroll-conservatively is set to a value slightly larger than the
5445 window height. Clean up the case of PT below the margin at bottom
5446 of window: scroll_max can no longer be INT_MAX. When aggressive
5447 scrolling is in use, don't let point enter the opposite scroll
5448 margin as result of the scroll.
5449 (syms_of_xdisp) <scroll-conservatively>: Document the
5450 threshold of 100 lines for never-recentering scrolling.
5451
5452 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5453
5454 * dispextern.h (move_it_by_lines):
5455 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5456 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5457 (message_log_check_duplicate): Remove parameters `prev_bol' and
5458 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5459 (redisplay_internal): Remove parameter `preserve_echo_area',
5460 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5461
5462 * indent.c (Fvertical_motion):
5463 * window.c (window_scroll_pixel_based, Frecenter):
5464 Don't pass `need_y_p' to `move_it_by_lines'.
5465
5466 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5467
5468 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5469 steal a few bits to be more compact.
5470 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5471 Remove unneeded casts.
5472
5473 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5474
5475 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5476
5477 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5478 binding" message (bug#7967).
5479
5480 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5481
5482 Fix more problems found by GCC 4.6.0's static checks.
5483
5484 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5485 Remove unused local var.
5486
5487 * editfns.c (Fmessage_box): Remove unused local var.
5488
5489 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5490 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5491 Omit unused local vars.
5492 * window.c (shrink_windows): Omit unused local var.
5493 * menu.c (digest_single_submenu): Omit unused local var.
5494 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5495 Omit unused local var.
5496
5497 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5498 Don't assume string length fits in int.
5499 (keyremap_step, read_key_sequence): Use size_t for sizes.
5500 (read_key_sequence): Don't check last_real_key_start redundantly.
5501
5502 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5503 instead of alloca (Bug#8344).
5504
5505 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5506 (Fbacktrace_frame): Don't assume nframes fits in int.
5507
5508 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5509
5510 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5511 concerns.
5512
5513 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5514
5515 * cm.c (calccost): Turn while-do into do-while, for clarity.
5516
5517 * keyboard.c (syms_of_keyboard): Use the same style as later
5518 in this function when indexing through an array. This also
5519 works around GCC bug 48267.
5520
5521 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5522
5523 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5524
5525 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5526 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5527
5528 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5529 This avoids undefined behavior on integer overflow, and is a bit
5530 more convenient anyway since it is compared to a size_t variable.
5531
5532 Variadic C functions now count arguments with size_t, not int.
5533 This avoids an unnecessary limitation on 64-bit machines, which
5534 caused (substring ...) to crash on large vectors (Bug#8344).
5535 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5536 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5537 All variadic functions and their callers changed accordingly.
5538 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5539 * data.c (arith_driver, float_arith_driver): Likewise.
5540 * editfns.c (general_insert_function): Likewise.
5541 * eval.c (struct backtrace.nargs, interactive_p)
5542 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5543 (funcall_lambda, mark_backtrace): Likewise.
5544 * fns.c (concat): Likewise.
5545 * frame.c (x_set_frame_parameters): Likewise.
5546 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5547 0 if not found, not -1. All callers changed.
5548
5549 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5550 (stack_copy_size): Now size_t, not int.
5551 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5552
5553 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5554
5555 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5556 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5557 All callers changed.
5558
5559 * lisp.h (multibyte_char_to_unibyte):
5560 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5561 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5562 * character.h (CHAR_TO_BYTE8):
5563 * cmds.c (internal_self_insert):
5564 * editfns.c (general_insert_function):
5565 * keymap.c (push_key_description):
5566 * search.c (Freplace_match):
5567 * xdisp.c (message_dolog, set_message_1): All callers changed.
5568
5569 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5570
5571 * keyboard.c (safe_run_hook_funcall): New function.
5572 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5573 don't set the hook to nil, but remove the offending function instead.
5574 (Qcommand_hook_internal): Remove, unused.
5575 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5576 Vcommand_hook_internal.
5577
5578 * eval.c (enum run_hooks_condition): Remove.
5579 (funcall_nil, funcall_not): New functions.
5580 (run_hook_with_args): Call each function through a `funcall' argument.
5581 Remove `cond' argument, now redundant.
5582 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5583 (Frun_hook_with_args_until_failure): Adjust accordingly.
5584 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5585
5586 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5587
5588 * dispextern.h (string_buffer_position): Remove declaration.
5589
5590 * print.c (strout): Remove parameter `multibyte', unused since
5591 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5592
5593 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5594 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5595 All callers changed.
5596
5597 * w32.c (_wsa_errlist): Use braces for struct initializers.
5598
5599 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5600 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5601 All callers changed.
5602 (string_buffer_position): Likewise. Also, make static (it's never
5603 used outside xdisp.c).
5604 (cursor_row_p): Remove parameter `w', unused since
5605 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5606 (decode_mode_spec): Remove parameter `precision', introduced during
5607 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5608 All callers changed.
5609
5610 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5611
5612 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5613
5614 2011-03-27 Anders Lindgren <andlind@gmail.com>
5615
5616 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5617 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5618 (ns_update_auto_hide_menu_bar): New functions.
5619 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5620 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5621 ns_constrain_all_frames.
5622 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5623 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5624
5625 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5626
5627 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5628
5629 2011-03-27 Glenn Morris <rgm@gnu.org>
5630
5631 * syssignal.h: Replace RETSIGTYPE with void.
5632 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5633 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5634 Replace SIGTYPE with void everywhere.
5635 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5636 * s/template.h (SIGTYPE): Remove commented out definition.
5637
5638 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5639
5640 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5641 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5642
5643 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5644
5645 * w32.c (read_unc_volume): Use parameter `henum', instead of
5646 global variable `wget_enum_handle'.
5647
5648 * keymap.c (describe_vector): Remove parameters `indices' and
5649 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5650 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5651
5652 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5653
5654 * keyboard.c (timer_check): Remove parameter `do_it_now',
5655 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5656 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5657 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5658
5659 * keyboard.c (read_char):
5660 * w32menu.c (w32_menu_display_help):
5661 * xmenu.c (show_help_event, menu_help_callback):
5662 Adjust calls to `show_help_echo'.
5663
5664 * gtkutil.c (xg_maybe_add_timer):
5665 * keyboard.c (readable_events):
5666 * process.c (wait_reading_process_output):
5667 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5668
5669 * insdel.c (adjust_markers_gap_motion):
5670 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5671 (gap_left, gap_right): Don't call it.
5672
5673 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5674
5675 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5676 incurred during fontification.
5677
5678 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5679
5680 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5681 (DEFVAR_PER_BUFFER): Don't pass it.
5682
5683 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5684 (scrolling_window): Don't pass it.
5685
5686 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5687
5688 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5689
5690 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5691 and `suffix'.
5692 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5693 of variables specific to SELinux and computation of `encoded_absname'.
5694
5695 * image.c (XPutPixel): Remove unused variable `height'.
5696
5697 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5698
5699 * unexw32.c (get_section_info): Remove unused variable `section'.
5700
5701 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5702 (system_process_attributes): Remove unused variable `sess'.
5703 (sys_read): Remove unused variable `err'.
5704
5705 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5706 (w32_wnd_proc): Remove unused variable `isdead'.
5707 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5708 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5709 (x_create_tip_frame): Remove unused variable `tem'.
5710
5711 * w32inevt.c (w32_console_read_socket):
5712 Remove unused variable `no_events'.
5713
5714 * w32term.c (x_draw_composite_glyph_string_foreground):
5715 Remove unused variable `width'.
5716
5717 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5718
5719 * w32term.c (x_set_glyph_string_clipping):
5720 Don't pass uninitialized region to CombineRgn.
5721
5722 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5723
5724 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5725 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5726 (Fx_close_connection): Remove unused variable `i'.
5727
5728 * w32font.c (w32font_draw): Return number of glyphs.
5729 (w32font_open_internal): Remove unused variable `i'.
5730 (w32font_driver): Add missing initializer.
5731
5732 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5733 (fill_in_menu): Remove unused variable `items_added'.
5734
5735 * w32term.c (last_mouse_press_frame): Remove static global variable.
5736 (w32_clip_to_row): Remove unused variable `f'.
5737 (x_delete_terminal): Remove unused variable `i'.
5738
5739 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5740 (NOTHING): Remove unused static global variable.
5741 (uniscribe_check_otf): Remove unused variable `table'.
5742 (uniscribe_font_driver): Add missing initializers.
5743
5744 2011-03-23 Julien Danjou <julien@danjou.info>
5745
5746 * term.c (Fsuspend_tty, Fresume_tty):
5747 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5748 * window.c (temp_output_buffer_show):
5749 * insdel.c (signal_before_change):
5750 * frame.c (Fhandle_switch_frame):
5751 * fileio.c (Fdo_auto_save):
5752 * emacs.c (Fkill_emacs):
5753 * editfns.c (save_excursion_restore):
5754 * cmds.c (internal_self_insert):
5755 * callint.c (Fcall_interactively):
5756 * buffer.c (Fkill_all_local_variables):
5757 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5758 Use Frun_hooks.
5759 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5760 unconditionnaly since it does the check itself.
5761
5762 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5763
5764 Fix more problems found by GCC 4.5.2's static checks.
5765
5766 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5767 the first time through the loop, since we know p0 < p1 then.
5768 This also avoids a gcc -Wstrict-overflow warning.
5769
5770 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5771 leading to a memory leak, possible in functions like
5772 load_charset_map_from_file that can allocate an unbounded number
5773 of objects (Bug#8318).
5774
5775 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5776 that could (at least in theory) be that large.
5777
5778 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5779 This is less likely to overflow, and avoids undefined behavior if
5780 overflow does occur. All callers changed. Use strtoul to scan
5781 for the unsigned long integer.
5782 (pint2hrstr): Simplify and tune code slightly.
5783 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5784
5785 * scroll.c (do_scrolling): Work around GCC bug 48228.
5786 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5787
5788 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5789 This also avoids a warning with gcc -Wstrict-overflow.
5790 (validate_x_resource_name): Simplify count usage.
5791 This also avoids a warning with gcc -Wstrict-overflow.
5792
5793 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5794 fail (Bug#8306).
5795
5796 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5797
5798 * process.c (Fmake_network_process): Use socklen_t, not int,
5799 where POSIX says socklen_t is required in portable programs.
5800 This fixes a porting bug on hosts like 64-bit HP-UX, where
5801 socklen_t is wider than int (Bug#8277).
5802 (Fmake_network_process, server_accept_connection):
5803 (wait_reading_process_output, read_process_output):
5804 Likewise.
5805
5806 * process.c: Rename or move locals to avoid shadowing.
5807 (list_processes_1, Fmake_network_process):
5808 (read_process_output_error_handler, exec_sentinel_error_handler):
5809 Rename or move locals.
5810 (Fmake_network_process): Define label "retry_connect" only if needed.
5811 (Fnetwork_interface_info): Fix pointer signedness.
5812 (process_send_signal): Add cast to avoid pointer signedness problem.
5813 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5814 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5815
5816 Make tparam.h and terminfo.c consistent.
5817 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5818 Include tparam.h instead, since it declares them.
5819 * cm.h (PC): Remove extern decl; tparam.h now does this.
5820 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5821 * terminfo.c: Include tparam.h, to check interfaces.
5822 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5823 (tparam): Adjust signature to match interface in tparam.h;
5824 this removes some undefined behavior. Check that outstring and len
5825 are zero, which they always are with Emacs.
5826 * tparam.h (PC, BC, UP): New extern decls.
5827
5828 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5829 (xftfont_open): Rename locals to avoid shadowing.
5830
5831 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5832 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5833 (OTF_TAG_SYM): Omit macro if not needed.
5834 (ftfont_list): Remove unused local.
5835 (get_adstyle_property, ftfont_pattern_entity):
5836 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5837 Rename locals to avoid shadowing.
5838
5839 * xfont.c (xfont_list_family): Mark var as initialized.
5840
5841 * xml.c (make_dom): Now static.
5842
5843 * composite.c (composition_compute_stop_pos): Rename local to
5844 avoid shadowing.
5845 (composition_reseat_it): Remove unused locals.
5846 (find_automatic_composition, composition_adjust_point): Likewise.
5847 (composition_update_it): Mark var as initialized.
5848 (find_automatic_composition): Mark vars as initialized,
5849 with a FIXME (Bug#8290).
5850
5851 character.h: Rename locals to avoid shadowing.
5852 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5853 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5854 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5855 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5856 to avoid shadowing.
5857
5858 * textprop.c (property_change_between_p): Remove; unused.
5859
5860 * intervals.c (interval_start_pos): Now static.
5861
5862 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5863
5864 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5865 Rename locals to avoid shadowing.
5866
5867 * sound.c (wav_play, au_play, Fplay_sound_internal):
5868 Fix pointer signedness.
5869 (alsa_choose_format): Remove unused local var.
5870 (wav_play): Initialize a variable to 0, to prevent undefined
5871 behavior (Bug#8278).
5872
5873 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5874
5875 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5876
5877 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5878 clobbering (Bug#8298).
5879 * sysdep.c (sys_subshell): Likewise.
5880 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5881
5882 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5883 This should get cleaned up, so that child_setup has the
5884 same signature on all platforms.
5885
5886 * callproc.c (call_process_cleanup): Now static.
5887 (relocate_fd): Rename locals to avoid shadowing.
5888
5889 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5890
5891 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5892 not to be necessary, and produces flickering.
5893
5894 2011-03-20 Glenn Morris <rgm@gnu.org>
5895
5896 * config.in: Remove file.
5897
5898 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5899
5900 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5901 are now in src/globals.h.
5902 (syms_of_minibuf): Remove spurious & from previous change.
5903
5904 2011-03-20 Leo <sdl.web@gmail.com>
5905
5906 * minibuf.c (completing-read-function): New variable.
5907 (completing-read-default): Rename from completing-read.
5908 (completing-read): Call completing-read-function.
5909
5910 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5911
5912 * xfaces.c (Fx_load_color_file):
5913 Read color file from absolute filename (bug#8250).
5914
5915 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5916
5917 * makefile.w32-in: Update dependencies.
5918
5919 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5920
5921 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5922
5923 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5924
5925 Fix more problems found by GCC 4.5.2's static checks.
5926
5927 * process.c (make_serial_process_unwind, send_process_trap):
5928 (sigchld_handler): Now static.
5929
5930 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5931 That way, the code declares only the vars that it needs.
5932 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5933 * s/cygwin.h (PTY_ITERATION): Likewise.
5934 * s/darwin.h (PTY_ITERATION): Likewise.
5935 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5936
5937 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5938 * process.c (allocate_pty): Don't declare stb unless it's needed.
5939
5940 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5941 (CONSTANTLIM): Remove; unused.
5942 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5943 Define only if needed.
5944
5945 * unexelf.c (unexec): Name an expression,
5946 to avoid gcc -Wbad-function-cast warning.
5947 Use a different way to cause a compilation error if anyone uses
5948 n rather than nn, a way that does not involve shadowing.
5949 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5950
5951 * deps.mk (unexalpha.o): Remove; unused.
5952
5953 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5954 * unexec.h: New file.
5955 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5956 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5957 Depend on unexec.h.
5958 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5959 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5960 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5961 Change as necessary to match prototype in unexec.h.
5962
5963 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5964 shadowing.
5965 (back_comment, skip_chars): Mark vars as initialized.
5966
5967 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5968 Rename locals to avoid shadowing.
5969
5970 * lread.c (read1): Rewrite so as not to use empty "else".
5971 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5972
5973 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5974
5975 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5976 warning when compiling print.c.
5977
5978 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5979 instead of using an uninitialized var.
5980 (font_sort_entities): Mark var as initialized.
5981
5982 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5983
5984 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5985 pointers to constants.
5986 (font_parse_fcname): Remove unused vars.
5987 (font_delete_unmatched): Now static.
5988 (font_get_spec): Remove; unused.
5989 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5990 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5991 Rename or move locals to avoid shadowing.
5992
5993 * fns.c (require_nesting_list, require_unwind): Now static.
5994 (Ffillarray): Rename locals to avoid shadowing.
5995
5996 * floatfns.c (domain_error2): Define only if needed.
5997 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5998
5999 * alloc.c (mark_backtrace): Move decl from here ...
6000 * lisp.h: ... to here, so that it can be checked.
6001
6002 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6003 (Fdefvar): Rewrite so as not to use empty "else".
6004 (lisp_indirect_variable): Name an expression,
6005 to avoid gcc -Wbad-function-cast warning.
6006 (Fdefvar): Rename locals to avoid shadowing.
6007
6008 * callint.c (quotify_arg, quotify_args): Now static.
6009 (Fcall_interactively): Rename locals to avoid shadowing.
6010 Use const pointer when appropriate.
6011
6012 * lisp.h (get_system_name, get_operating_system_release):
6013 Move decls here, to check interfaces.
6014 * process.c (get_operating_system_release): Move decl to lisp.h.
6015 * xrdb.c (get_system_name): Likewise.
6016 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6017 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6018 some of which prompt warnings from gcc -Wbad-function-cast.
6019 (Fformat_time_string, Fencode_time, Finsert_char):
6020 (Ftranslate_region_internal, Fformat):
6021 Rename or remove local vars to avoid shadowing.
6022 (Ftranslate_region_internal): Mark var as initialized.
6023
6024 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6025 avoid shadowing.
6026
6027 * lisp.h (eassert): Check that the argument compiles, even if
6028 ENABLE_CHECKING is not defined.
6029
6030 * data.c (Findirect_variable): Name an expression, to avoid
6031 gcc -Wbad-function-cast warning.
6032 (default_value, arithcompare, arith_driver, arith_error): Now static.
6033 (store_symval_forwarding): Rename local to avoid shadowing.
6034 (Fmake_variable_buffer_local, Fmake_local_variable):
6035 Mark variables as initialized.
6036 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6037
6038 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6039 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6040 Rename locals to avoid shadowing.
6041 (mark_stack): Move local variables into the #ifdef region where
6042 they're used.
6043 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6044 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6045 needed otherwise.
6046 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6047 (GC_STRING_CHARS): Remove; not used.
6048 (Fmemory_limit): Cast sbrk's returned value to char *.
6049
6050 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6051 avoids undefined behavior in theory.
6052
6053 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6054
6055 Use functions, not macros, for up- and down-casing (Bug#8254).
6056 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6057 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6058 to use the following functions instead of these macros.
6059 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6060 EMACS_INT, since callers assume the returned value fits in int.
6061 (upcase1): Likewise, for UPCASE_TABLE.
6062 (uppercasep, lowercasep, upcase): New static inline functions.
6063 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6064 the race-condition problem in the old DOWNCASE.
6065
6066 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6067 Rename locals to avoid shadowing.
6068 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6069 (regex_compile, re_search_2, re_match_2_internal):
6070 Remove unused local vars.
6071 (FREE_VAR): Rewrite so as not to use empty "else",
6072 which gcc can warn about.
6073 (regex_compile, re_match_2_internal): Mark locals as initialized.
6074 (RETALLOC_IF): Define only if needed.
6075 (WORDCHAR_P): Likewise. This one is never needed, but is used
6076 only in a comment talking about a compiler bug, so put inside
6077 the #if 0 of that comment.
6078 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6079 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6080 Remove; unused.
6081
6082 * search.c (boyer_moore): Rename locals to avoid shadowing.
6083 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6084 (PREV_CHAR_BOUNDARY): Likewise.
6085
6086 * search.c (simple_search): Remove unused var.
6087
6088 * dired.c (compile_pattern): Move decl from here ...
6089 * lisp.h: ... to here, so that it can be checked.
6090 (struct re_registers): New forward decl.
6091
6092 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6093
6094 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6095 All uses changed.
6096 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6097 Rename locals to avoid shadowing.
6098 (Fvertical_motion): Mark locals as initialized.
6099
6100 * casefiddle.c (casify_object, casify_region): Now static.
6101 (casify_region): Mark local as initialized.
6102
6103 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6104
6105 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6106 New macros, so that the caller can use some names other than
6107 gcpro1, gcpro2, etc.
6108 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6109 of the new macros.
6110 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6111 argument, for consistency with GCPRO2_VAR, etc: it is now the
6112 prefix of the variable, not the variable itself. All uses
6113 changed.
6114 * dired.c (directory_files_internal, file_name_completion):
6115 Rename locals to avoid shadowing.
6116
6117 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6118 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6119 dired.c's scmp function, had undefined behavior.
6120 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6121 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6122 * buffer.h: ... to here, because these macros use current_buffer,
6123 and the new implementation with inline functions needs to have
6124 current_buffer in scope now, rather than later when the macros
6125 are used.
6126 (downcase, upcase1): New static inline functions.
6127 (DOWNCASE, UPCASE1): Reimplement using these functions.
6128 This avoids undefined behavior in expressions like
6129 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6130 from race conditions in accessing the global variables
6131 case_temp1 and case_temp2.
6132 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6133 * lisp.h (case_temp1, case_temp2): Remove their decls.
6134 * character.h (ASCII_CHAR_P): Move from here ...
6135 * lisp.h: ... to here, so that the inline functions mentioned
6136 above can use them.
6137
6138 * dired.c (directory_files_internal_unwind): Now static.
6139
6140 * fileio.c (file_name_as_directory, directory_file_name):
6141 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6142 Now static.
6143 (file_name_as_directory): Use const pointers when appropriate.
6144 (Fexpand_file_name): Likewise. In particular, newdir might
6145 point at constant storage, so make it a const pointer.
6146 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6147 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6148 signedness issues.
6149 (Fset_file_times, Finsert_file_contents, auto_save_error):
6150 Rename locals to avoid shadowing.
6151
6152 * minibuf.c (choose_minibuf_frame_1): Now static.
6153 (Ftry_completion, Fall_completions): Rename or remove locals
6154 to avoid shadowing.
6155
6156 * marker.c (bytepos_to_charpos): Remove; unused.
6157
6158 * lisp.h (verify_bytepos, count_markers): New decls,
6159 so that gcc does not warn that these functions aren't declared.
6160
6161 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6162 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6163 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6164 (copy_text): Remove unused local var.
6165
6166 * filelock.c (within_one_second): Now static.
6167 (lock_file_1): Rename local to avoid shadowing.
6168
6169 * buffer.c (fix_overlays_before): Mark locals as initialized.
6170 (fix_start_end_in_overlays): Likewise. This function should be
6171 simplified by using pointers-to-pointers, but that's a different
6172 matter.
6173 (switch_to_buffer_1): Now static.
6174 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6175 (report_overlay_modification): Rename locals to avoid shadowing.
6176
6177 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6178 Fix pointer signedness issue.
6179 (sys_subshell): Mark local as volatile if checking for lint,
6180 to suppress a gcc -Wclobbered warning that does not seem to be right.
6181 (MAXPATHLEN): Define only if needed.
6182
6183 * process.c (serial_open, serial_configure): Move decls from here ...
6184 * systty.h: ... to here, so that they can be checked.
6185
6186 * fns.c (get_random, seed_random): Move extern decls from here ...
6187 * lisp.h: ... to here, so that they can be checked.
6188
6189 * sysdep.c (reset_io): Now static.
6190 (wait_for_termination_signal): Remove; unused.
6191
6192 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6193 (copy_keymap_item, append_key, push_text_char_description):
6194 Now static.
6195 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6196 (DENSE_TABLE_SIZE): Remove; unused.
6197 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6198 (describe_map_tree):
6199 Rename locals to avoid shadowing.
6200
6201 * keyboard.c: Declare functions static if they are not used elsewhere.
6202 (echo_char, echo_dash, cmd_error, top_level_2):
6203 (poll_for_input, handle_async_input): Now static.
6204 (read_char, kbd_buffer_get_event, make_lispy_position):
6205 (make_lispy_event, make_lispy_movement, apply_modifiers):
6206 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6207 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6208 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6209 (read_key_sequence, read_char): Mark locals as initialized.
6210 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6211
6212 * keyboard.h (make_ctrl_char): New decl.
6213 (mark_kboards): Move decl here ...
6214 * alloc.c (mark_kboards): ... from here.
6215
6216 * lisp.h (force_auto_save_soon): New decl.
6217
6218 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6219 (DEFINE_DUMMY_FUNCTION): New macro.
6220 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6221 Use it.
6222 (main): Add casts to avoid warnings
6223 if GCC considers string literals to be constants.
6224
6225 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6226
6227 * dbusbind.c: Pointer signedness fixes.
6228 (xd_signature, xd_append_arg, xd_initialize):
6229 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6230 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6231 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6232 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6233
6234 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6235 if GCC considers string literals to be constants.
6236 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6237
6238 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6239
6240 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6241 (print_preprocess, print_object): New macro to fix last change.
6242
6243 * print.c (print_preprocess): Don't forget font objects.
6244
6245 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6246
6247 * emacs.c (USAGE3): Doc fixes.
6248
6249 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6250
6251 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6252 structure.
6253
6254 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6255
6256 * lisp.h (VWindow_system, Qfile_name_history):
6257 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6258 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6259 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6260
6261 * w32select.c: Don't #include "keyboard.h".
6262 (run_protected): Add extern declaration for waiting_for_input.
6263
6264 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6265 * w32console.c (detect_input_pending, read_input_pending)
6266 (encode_terminal_code):
6267 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6268 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6269 (w32_system_caret_y, Qfile_name_history):
6270 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6271 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6272 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6273 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6274 * w32proc.c (Qlocal, report_file_error):
6275 * w32term.c (Vwindow_system, updating_frame):
6276 * w32uniscribe.c (initialized, uniscribe_font_driver):
6277 Remove unneeded extern declarations.
6278
6279 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6280
6281 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6282
6283 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6284
6285 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6286 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6287 These macros can no longer be used for assignment.
6288
6289 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6290 Assign struct members directly, instead of using BUF_BEGV etc.
6291 (record_buffer_markers, fetch_buffer_markers): New functions for
6292 recording and fetching special buffer markers.
6293 (set_buffer_internal_1, set_buffer_temp): Use them.
6294
6295 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6296
6297 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6298
6299 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6300 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6301
6302 * xdisp.c (hscroll_window_tree):
6303 (reconsider_clip_changes): Use PT instead of BUF_PT.
6304
6305 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6306
6307 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6308 $(EMACS_ROOT)/lib/intprops.h.
6309
6310 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6311
6312 Fix more problems found by GCC 4.5.2's static checks.
6313
6314 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6315 to unsigned char * to avoid compiler diagnostic.
6316 (xg_free_frame_widgets): Make it clear that a local variable is
6317 needed only if USE_GTK_TOOLTIP.
6318 (gdk_window_get_screen): Make it clear that this macro is needed
6319 only if USE_GTK_TOOLTIP.
6320 (int_gtk_range_get_value): New function, which avoids a diagnostic
6321 from gcc -Wbad-function-cast.
6322 (xg_set_toolkit_scroll_bar_thumb): Use it.
6323 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6324 diagnostic from gcc -Wbad-function-cast.
6325 (get_utf8_string, xg_get_file_with_chooser):
6326 Rename locals to avoid shadowing.
6327 (create_dialog): Move locals to avoid shadowing.
6328
6329 * xgselect.c (xg_select): Remove unused var.
6330
6331 * image.c (four_corners_best): Mark locals as initialized.
6332 (gif_load): Initialize transparent_p to zero (Bug#8238).
6333 Mark another local as initialized.
6334 (my_png_error, my_error_exit): Mark with NO_RETURN.
6335
6336 * image.c (clear_image_cache): Now static.
6337 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6338 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6339 (x_edge_detection): Remove unnecessary cast that
6340 gcc -Wbad-function-cast diagnoses.
6341 (gif_load): Fix pointer signedness.
6342 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6343 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6344
6345 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6346
6347 Improve quality of tests for time stamp overflow.
6348 For example, without this patch (encode-time 0 0 0 1 1
6349 1152921504606846976) returns the obviously-bogus value (-948597
6350 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6351 reports time overflow. See
6352 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6353 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6354 * editfns.c: Include limits.h and intprops.h.
6355 (TIME_T_MIN, TIME_T_MAX): New macros.
6356 (time_overflow): Move earlier, to before first use.
6357 (hi_time, lo_time): New functions, for an accurate test for
6358 out-of-range times.
6359 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6360 (Fget_internal_run_time): Don't assume time_t fits in int.
6361 (make_time): Use list2 instead of Fcons twice.
6362 (Fdecode_time): More accurate test for out-of-range times.
6363 (check_tm_member): New function.
6364 (Fencode_time): Use it, to test for out-of-range times.
6365 (lisp_time_argument): Don't rely on undefined left-shift and
6366 right-shift behavior when checking for time stamp overflow.
6367
6368 * editfns.c (time_overflow): New function, refactoring common code.
6369 (Fformat_time_string, Fdecode_time, Fencode_time):
6370 (Fcurrent_time_string): Use it.
6371
6372 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6373 * dired.c (make_time): Move to ...
6374 * editfns.c (make_time): ... here.
6375 * systime.h: Note the move.
6376
6377 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6378
6379 * fringe.c (update_window_fringes): Remove unused variables.
6380
6381 * unexmacosx.c (copy_data_segment): Also copy __got section.
6382 (Bug#8223)
6383
6384 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6385
6386 * termcap.c [MSDOS]: Include "msdos.h".
6387 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6388 Constify `char *' arguments and their references according to
6389 prototypes in tparam.h.
6390
6391 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6392
6393 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6394 Adapt all references accordingly.
6395
6396 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6397
6398 2011-03-11 Tom Tromey <tromey@redhat.com>
6399
6400 * buffer.c (syms_of_buffer): Remove obsolete comment.
6401
6402 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6403
6404 * termhooks.h (encode_terminal_code): Declare prototype.
6405
6406 * msdos.c (encode_terminal_code): Don't declare prototype.
6407
6408 * term.c (encode_terminal_code): Now external again, used by
6409 w32console.c and msdos.c.
6410
6411 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6412 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6413
6414 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6415
6416 Fix some minor problems found by GCC 4.5.2's static checks.
6417
6418 * fringe.c (update_window_fringes): Mark locals as initialized
6419 (Bug#8227).
6420 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6421
6422 * alloc.c (mark_fringe_data): Move decl from here ...
6423 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6424 to check its interface.
6425 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6426
6427 * fontset.c (free_realized_fontset): Now static.
6428 (Fset_fontset_font): Rename local to avoid shadowing.
6429 (fontset_font): Mark local as initialized.
6430 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6431
6432 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6433
6434 * xselect.c (x_disown_buffer_selections): Remove; not used.
6435 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6436 (x_own_selection, Fx_disown_selection_internal): Rename locals
6437 to avoid shadowing.
6438 (x_handle_dnd_message): Remove local to avoid shadowing.
6439
6440 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6441 so that the caller can use some name other than gcpro1.
6442 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6443 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6444 (Fx_backspace_delete_keys_p):
6445 Use them to avoid shadowing, and rename vars to avoid shadowing.
6446 (x_decode_color, x_set_name, x_window): Now static.
6447 (Fx_create_frame): Add braces to silence GCC warning.
6448 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6449 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6450 Remove unused locals.
6451 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6452 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6453 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6454 macros.
6455
6456 * xterm.h (x_mouse_leave): New decl.
6457
6458 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6459 Remove unused functions.
6460 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6461 (x_calc_absolute_position): Now static.
6462 (XTread_socket): Don't define label "out" unless it's used.
6463 Don't declare local "event" unless it's used.
6464 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6465 unless they are used.
6466 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6467 (x_fatal_error_signal): Remove; not used.
6468 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6469 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6470 (x_error_catcher, x_connection_closed, x_error_handler):
6471 (x_error_quitter, xembed_send_message, x_iconify_frame):
6472 (my_log_handler): Rename locals to avoid shadowing.
6473 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6474 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6475
6476 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6477 Rename or move locals to avoid shadowing.
6478 (tty_defined_color, merge_face_heights): Now static.
6479 (free_realized_faces_for_fontset): Remove; not used.
6480 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6481 does not deduce is never used uninitialized.
6482 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6483 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6484
6485 * terminal.c (store_terminal_param): Now static.
6486
6487 * xmenu.c (menu_highlight_callback): Now static.
6488 (set_frame_menubar): Remove unused local.
6489 (xmenu_show): Rename parameter to avoid shadowing.
6490 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6491 since they might point to immutable storage.
6492 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6493 since it's unused otherwise.
6494
6495 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6496 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6497 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6498 avoids a gcc -Wuninitialized diagnostic.
6499 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6500 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6501 does not deduce are never used uninitialized.
6502
6503 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6504
6505 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6506 * window.c (window_loop, size_window):
6507 (run_window_configuration_change_hook, enlarge_window): Likewise.
6508
6509 * window.c (display_buffer): Now static.
6510 (size_window): Mark variables that gcc -Wuninitialized
6511 does not deduce are never used uninitialized.
6512 * window.h (check_all_windows): New decl, to forestall
6513 gcc -Wmissing-prototypes diagnostic.
6514 * dispextern.h (bidi_dump_cached_states): Likewise.
6515
6516 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6517 shadowing.
6518 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6519 Include <limits.h>.
6520 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6521 and to avoid gcc -Wuninitialized warning.
6522 (load_charset_map): Mark variables that gcc -Wuninitialized
6523 does not deduce are never used uninitialized.
6524 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6525
6526 * coding.c (coding_set_source, coding_set_destination):
6527 Use "else { /* comment */ }" rather than "else /* comment */;"
6528 for clarity, and to avoid gcc -Wempty-body warning.
6529 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6530 a block, when the outer 'i' will do.
6531 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6532 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6533 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6534 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6535 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6536 Rename locals to avoid shadowing.
6537 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6538 * coding.c (emacs_mule_char, encode_invocation_designation):
6539 Now static, since they're not used elsewhere.
6540 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6541 (decode_coding_object, encode_coding_object, detect_coding_system):
6542 (decode_coding_emacs_mule): Mark variables that gcc
6543 -Wuninitialized does not deduce are never used uninitialized.
6544 (detect_coding_iso_2022): Initialize a local variable that might
6545 be used uninitialized. Leave a FIXME because it's not clear that
6546 this initialization is needed. (Bug#8211)
6547 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6548 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6549 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6550 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6551 Remove unused macros.
6552
6553 * category.c (hash_get_category_set): Remove unused local var.
6554 (copy_category_table): Now static, since it's not used elsewhere.
6555 * character.c (string_count_byte8): Likewise.
6556
6557 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6558 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6559
6560 * chartab.c (copy_sub_char_table): Now static, since it's not used
6561 elsewhere.
6562 (sub_char_table_ref_and_range, char_table_ref_and_range):
6563 Rename locals to avoid shadowing.
6564 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6565
6566 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6567 (BIDI_BOB): Remove unused macro.
6568
6569 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6570 deduce are never used uninitialized.
6571 * term.c (encode_terminal_code): Likewise.
6572
6573 * term.c (encode_terminal_code): Now static. Remove unused local.
6574
6575 * tparam.h: New file.
6576 * term.c, tparam.h: Include it.
6577 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6578 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6579 Move these decls to tparam.h, and make them agree with what
6580 is actually in tparam.c. The previous trick of using incompatible
6581 decls in different modules does not conform to the C standard.
6582 All callers of tparam changed to use tparam's actual API.
6583 * tparam.c (tparam1, tparam, tgoto):
6584 Use const pointers where appropriate.
6585
6586 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6587 * cm.h (struct cm): Likewise.
6588 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6589 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6590 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6591 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6592 (turn_on_face, init_tty): Likewise.
6593 * termchar.h (struct tty_display_info): Likewise.
6594
6595 * term.c (term_mouse_position): Rename local to avoid shadowing.
6596
6597 * alloc.c (mark_ttys): Move decl from here ...
6598 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6599
6600 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6601
6602 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6603
6604 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6605
6606 * search.c (compile_pattern_1): Remove argument regp, unused since
6607 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6608 (compile_pattern): Don't pass it.
6609
6610 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6611
6612 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6613 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6614 for ! HAVE_GTK3.
6615 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6616
6617 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6618
6619 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6620 gdk_window_get_screen, gdk_window_get_geometry,
6621 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6622 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6623 (xg_get_pixbuf_from_pixmap): New function.
6624 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6625 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6626 Call xg_get_pixbuf_from_pixmap instead of
6627 gdk_pixbuf_get_from_drawable.
6628 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6629 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6630 (xg_check_special_colors): Use GtkStyleContext and its functions
6631 for HAVE_GTK3.
6632 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6633 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6634 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6635 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6636 Call gtk_widget_get_preferred_size.
6637 (xg_frame_resized): gdk_window_get_geometry only takes 5
6638 parameters.
6639 (xg_win_to_widget, xg_event_is_for_menubar):
6640 Call gdk_x11_window_lookup_for_display.
6641 (xg_set_widget_bg): New function.
6642 (delete_cb): New function.
6643 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6644 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6645 (xg_set_background_color): Call xg_set_widget_bg.
6646 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6647 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6648 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6649 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6650 if ! HAVE_GTK3.
6651 (update_frame_tool_bar): Call gtk_widget_hide.
6652 (xg_initialize): Use GDK_KEY_g.
6653
6654 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6655 if ! HAVE_GTK3
6656 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6657
6658 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6659 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6660 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6661
6662 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6663
6664 * w32xfns.c (select_palette): Check success of RealizePalette against
6665 GDI_ERROR, not zero.
6666
6667 See ChangeLog.11 for earlier changes.
6668
6669 ;; Local Variables:
6670 ;; coding: utf-8
6671 ;; End:
6672
6673 Copyright (C) 2011 Free Software Foundation, Inc.
6674
6675 This file is part of GNU Emacs.
6676
6677 GNU Emacs is free software: you can redistribute it and/or modify
6678 it under the terms of the GNU General Public License as published by
6679 the Free Software Foundation, either version 3 of the License, or
6680 (at your option) any later version.
6681
6682 GNU Emacs is distributed in the hope that it will be useful,
6683 but WITHOUT ANY WARRANTY; without even the implied warranty of
6684 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6685 GNU General Public License for more details.
6686
6687 You should have received a copy of the GNU General Public License
6688 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.