* src/xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
[bpt/emacs.git] / src / ChangeLog
1 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4
5 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6
7 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9 (x_clipboard_manager_save): Now static.
10 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11
12 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
13 (crypto_hash_function): Now static.
14 Fix pointer signedness problems. Avoid unnecessary initializations.
15
16 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
17
18 * termhooks.h (Vselection_alist): Make it terminal-local.
19
20 * terminal.c (create_terminal): Initialize it.
21
22 * xselect.c: Support for clipboard managers.
23 (Vselection_alist): Move to termhooks.h as terminal-local var.
24 (LOCAL_SELECTION): New macro.
25 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
26 (symbol_to_x_atom): Remove gratuitous arg.
27 (x_handle_selection_request, lisp_data_to_selection_data)
28 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
29 (x_own_selection, x_get_local_selection, x_convert_selection): New
30 arg, specifying work frame. Use terminal-local Vselection_alist.
31 (some_frame_on_display): Delete unused function.
32 (Fx_own_selection_internal, Fx_get_selection_internal)
33 (Fx_disown_selection_internal, Fx_selection_owner_p)
34 (Fx_selection_exists_p): New optional frame arg.
35 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
36 (x_handle_selection_clear): Don't treat other terminals with the
37 same keyboard specially. Use the terminal-local Vselection_alist.
38 (x_clear_frame_selections): Use Frun_hook_with_args.
39
40 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
41
42 * xterm.h: Add support for those atoms.
43
44 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
45
46 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
47 (converted_selections, conversion_fail_tag): New global variables.
48 (x_selection_request_lisp_error): Free the above.
49 (x_get_local_selection): Remove unnecessary code.
50 (x_reply_selection_request): Args changed; handle arbitrary array
51 of converted selections stored in converted_selections. Separate
52 the XChangeProperty and SelectionNotify steps.
53 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
54 (x_convert_selection): New function.
55 (x_handle_selection_event): Simplify.
56 (x_get_foreign_selection): Don't ignore incoming requests while
57 waiting for an answer; this will fail when we implement
58 SAVE_TARGETS, and seems unnecessary anyway.
59 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
60 (Vx_sent_selection_functions): Doc fix.
61
62 2011-05-26 Leo Liu <sdl.web@gmail.com>
63
64 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
65
66 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
67
68 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
69
70 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
71 for fringe update if it has periodic bitmap.
72 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
73 and fringe_bitmap_periodic_p.
74
75 * fringe.c (get_fringe_bitmap_data): New function.
76 (draw_fringe_bitmap_1, update_window_fringes): Use it.
77 (update_window_fringes): Record periodicity of fringe bitmap in glyph
78 row. Mark glyph row for fringe update if periodicity changed.
79
80 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
81 for fringe update unless it has periodic bitmap.
82
83 2011-05-25 Kenichi Handa <handa@m17n.org>
84
85 * xdisp.c (get_next_display_element): Set correct it->face_id for
86 a static composition.
87
88 2011-05-24 Leo Liu <sdl.web@gmail.com>
89
90 * deps.mk (fns.o):
91 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
92
93 * fns.c (crypto_hash_function, Fsha1): New function.
94 (Fmd5): Use crypto_hash_function.
95 (syms_of_fns): Add Ssha1.
96
97 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
98
99 * gnutls.c: Remove unused macros.
100 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
101 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
102 Remove macros that are defined and never used.
103 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
104
105 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
106
107 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
108 (Fx_get_selection_internal): Minor cleanup.
109 (Fx_own_selection_internal): Rename arguments for consistency with
110 select.el.
111
112 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
113
114 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
115
116 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
117
118 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
119
120 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
121
122 * dispnew.c (scrolling_window): Don't exclude the case that the
123 last enabled row in the desired matrix touches the bottom boundary.
124
125 2011-05-21 Glenn Morris <rgm@gnu.org>
126
127 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
128 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
129 and add some more files.
130
131 2011-05-20 Eli Zaretskii <eliz@gnu.org>
132
133 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
134 report_file_error introduced by the change from 2011-05-07.
135
136 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
137
138 * systime.h (Time): Define only if emacs is defined.
139 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
140 where the include path doesn't have X11/X.h by default. See
141 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
142
143 2011-05-20 Kenichi Handa <handa@m17n.org>
144
145 * composite.c (find_automatic_composition): Fix previous change.
146
147 2011-05-20 Glenn Morris <rgm@gnu.org>
148
149 * lisp.mk: New file, split from Makefile.in.
150 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
151 (shortlisp): Remove.
152 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
153
154 2011-05-19 Glenn Morris <rgm@gnu.org>
155
156 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
157 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
158 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
159 (lisp): Set the order to that of loadup.el.
160 (shortlisp): Make it a copy of $lisp.
161 (SOME_MACHINE_LISP): Remove.
162 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
163 Use just $shortlisp, not $SOME_MACHINE_LISP too.
164
165 2011-05-18 Kenichi Handa <handa@m17n.org>
166
167 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
168 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
169 (find_automatic_composition): Mostly rewrite for efficiency.
170
171 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
172
173 * makefile.w32-in: Update dependencies.
174
175 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
176
177 * menu.c: Include limits.h (fixes the MS-Windows build broken by
178 revision 104625).
179
180 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
181
182 Fix some integer overflow issues, such as string length overflow.
183
184 * insdel.c (count_size_as_multibyte): Check for string overflow.
185
186 * character.c (lisp_string_width): Check for string overflow.
187 Use EMACS_INT, not int, for string indexes and lengths; in
188 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
189 the resulting string length overflows an EMACS_INT; instead,
190 report a string overflow if no precision given. When checking for
191 precision exhaustion, use a check that cannot possibly have
192 integer overflow. (Bug#8675)
193 * character.h (lisp_string_width): Adjust to new signature.
194
195 * alloc.c (string_overflow): New function.
196 (Fmake_string): Use it. This doesn't change behavior, but saves
197 a few bytes and will simplify future changes.
198 * character.c (string_escape_byte8): Likewise.
199 * lisp.h (string_overflow): New decl.
200
201 Fixups, following up to the user-interface timestamp change.
202 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
203 for UI timestamps, instead of unsigned long.
204 * msdos.c (mouse_get_pos): Likewise.
205 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
206 * w32gui.h (Time): Define by including "systime.h" rather than by
207 declaring it ourselves. (Bug#8664)
208
209 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
210 * image.c (clear_image_cache): Likewise.
211
212 * term.c (term_mouse_position): Don't assume time_t wraparound.
213
214 Be more systematic about user-interface timestamps.
215 Before, the code sometimes used 'Time', sometimes 'unsigned long',
216 and sometimes 'EMACS_UINT', to represent these timestamps. This
217 change causes it to use 'Time' uniformly, as that's what X uses.
218 This makes the code easier to follow, and makes it easier to catch
219 integer overflow bugs such as Bug#8664.
220 * frame.c (Fmouse_position, Fmouse_pixel_position):
221 Use Time, not unsigned long, for user-interface timestamps.
222 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
223 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
224 * keyboard.h (last_event_timestamp): Likewise.
225 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
226 * menu.h (xmenu_show): Likewise.
227 * term.c (term_mouse_position): Likewise.
228 * termhooks.h (struct input_event.timestamp): Likewise.
229 (struct terminal.mouse_position_hook): Likewise.
230 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
231 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
232 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
233 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
234 what it was before.
235 * menu.h, termhooks.h: Include "systime.h", for Time.
236
237 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
238 Don't assume that the difference between two unsigned long values
239 can fit into an integer. At this point, we know button_down_time
240 <= event->timestamp, so the difference must be nonnegative, so
241 there's no need to cast the result if double-click-time is
242 nonnegative, as it should be; check that it's nonnegative, just in
243 case. This bug is triggered when events are more than 2**31 ms
244 apart (about 25 days). (Bug#8664)
245
246 * xselect.c (last_event_timestamp): Remove duplicate decl.
247 (x_own_selection): Remove needless cast to unsigned long.
248
249 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
250 that always fit in int. Use a sentinel instead of a counter, to
251 avoid a temp and to allay GCC's concerns about possible int overflow.
252 * frame.h (struct frame): Use int for menu_bar_items_used
253 instead of EMACS_INT, since it always fits in int.
254
255 * menu.c (grow_menu_items): Check for int overflow.
256
257 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
258
259 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
260 Before, the code was not consistent. These values cannot exceed
261 2**31 - 1 so there's no need to make them unsigned.
262 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
263 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
264 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
265 as modifiers.
266 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
267
268 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
269 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
270 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
271 presumably because the widths might not match.
272
273 * window.c (size_window): Avoid needless test at loop start.
274
275 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
276
277 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
278
279 2011-05-12 Drew Adams <drew.adams@oracle.com>
280
281 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
282
283 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
284
285 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
286 `width' to `bar_area_x' and `bar_area_width', respectively.
287 (x_scroll_run): Take account of fringe background extension.
288
289 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
290 Rename local vars `left' and `width' to `bar_area_x' and
291 `bar_area_width', respectively.
292 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
293 background extension.
294
295 2011-05-10 Jim Meyering <meyering@redhat.com>
296
297 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
298
299 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
300
301 * image.c (Finit_image_library): Return t for built-in image types,
302 like pbm and xbm. (Bug#8640)
303
304 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
305
306 * w32menu.c (set_frame_menubar): Fix submenu allocation.
307
308 2011-05-07 Eli Zaretskii <eliz@gnu.org>
309
310 * w32console.c (Fset_screen_color): Doc fix.
311 (Fget_screen_color): New function.
312 (syms_of_ntterm): Defsubr it.
313
314 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
315 unlink the temporary file if Fcall_process didn't create it in the
316 first place.
317 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
318 child process will be redirected to a file specified with `:file'.
319 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
320 cue to call_process_cleanup not to close that handle.
321
322 2011-05-07 Ben Key <bkey76@gmail.com>
323
324 * makefile.w32-in: The bootstrap-temacs rule now makes use of
325 one of two shell specific rules, either bootstrap-temacs-CMD or
326 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
327 to the previous implementation of the bootstrap-temacs rule.
328 The bootstrap-temacs-CMD rule is similar to the previous
329 implementation of the bootstrap-temacs rule except that it
330 makes use of the ESC_CFLAGS variable instead of the CFLAGS
331 variable.
332
333 These changes, along with some changes to nt/configure.bat,
334 nt/gmake.defs, and nt/nmake.defs, are required to extend my
335 earlier fix to add support for --cflags and --ldflags options
336 that include quotes so that it works whether make uses cmd or
337 sh as the shell.
338
339 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
340
341 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
342 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
343 is a constant.
344 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
345 a string. Handle both cases.
346 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
347 (Fdbus_register_method): Use Qinvalid_function.
348
349 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
350
351 * makefile.w32-in: Update dependencies.
352 (LISP_H): Add inttypes.h and stdin.h.
353 (PROCESS_H): Add unistd.h.
354
355 2011-05-06 Eli Zaretskii <eliz@gnu.org>
356
357 * lread.c: Include limits.h (fixes the MS-Windows build broken by
358 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
359
360 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
361
362 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
363
364 * term.c (vfatal): Remove stray call to va_end.
365 It's not needed and the C Standard doesn't allow it here anyway.
366
367 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
368 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
369
370 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
371 bytes.
372
373 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
374
375 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
376
377 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
378
379 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
380
381 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
382
383 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
384 * charset.c (Fdefine_charset_internal): Don't initialize
385 charset.code_space[15]. The value was garbage, on hosts with
386 32-bit int (Bug#8600).
387
388 * lread.c (read_integer): Be more consistent with string-to-number.
389 Use string_to_number to do the actual conversion; this avoids
390 rounding errors and fixes some other screwups. Without this fix,
391 for example, #x1fffffffffffffff was misread as -2305843009213693952.
392 (digit_to_number): Move earlier, for benefit of read_integer.
393 Return -1 if the digit is out of range for the base, -2 if it is
394 not a digit in any supported base. (Bug#8602)
395
396 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
397
398 * dispnew.c (scrolling_window): Return 1 if we scrolled,
399 to match comment at start of function. This also removes a
400 GCC warning about overflow in a 32+64-bit port.
401
402 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
403
404 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
405 Reported by Stefan Monnier in
406 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
407 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
408 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
409
410 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
411 (EMACS_UINTPTR): Likewise, with uintptr_t.
412
413 * lisp.h: Prefer 64-bit EMACS_INT if available.
414 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
415 on 32-bit hosts that have 64-bit int, so that they can access
416 large files.
417 However, temporarily disable this change unless the temporary
418 symbol WIDE_EMACS_INT is defined.
419
420 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
421
422 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
423 This removes an assumption that EMACS_INT and long are the same
424 width as pointers. The assumption is true for Emacs porting targets
425 now, but we want to make other targets possible.
426 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
427 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
428 In the rest of the code, change types of integers that hold casted
429 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
430 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
431 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
432 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
433 No need to cast type when ORing.
434 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
435 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
436 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
437 assume EMACS_INT is the same width as char *.
438 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
439 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
440 Remove no-longer-needed casts.
441 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
442 (xg_tool_bar_help_callback, xg_make_tool_item):
443 Use EMACS_INTPTR to hold an integer
444 that will be cast to void *; this can avoid a GCC warning
445 if EMACS_INT is not the same width as void *.
446 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
447 * xdisp.c (display_echo_area_1, resize_mini_window_1):
448 (current_message_1, set_message_1):
449 Use a local to convert to proper width without a cast.
450 * xmenu.c (dialog_selection_callback): Likewise.
451
452 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
453 Also, don't assume VALBITS / RAND_BITS is less than 5,
454 and don't rely on undefined behavior when shifting a 1 left into
455 the sign bit.
456 * lisp.h (get_random): Change signature to match.
457
458 * lread.c (hash_string): Use size_t, not int, for hash computation.
459 Normally we prefer signed values; but hashing is special, because
460 it's better to use unsigned division on hash table sizes so that
461 the remainder is nonnegative. Also, size_t is the natural width
462 for hashing into memory. The previous code used 'int', which doesn't
463 retain enough info to hash well into very large tables.
464 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
465
466 * dbusbind.c: Don't possibly lose pointer info when converting.
467 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
468 Use XPNTR rather than XHASH, so that the high-order bits of
469 the pointer aren't lost when converting through void *.
470
471 * eval.c (Fautoload): Don't double-shift a pointer.
472
473 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
474
475 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
476
477 * gnutls.c (DEF_GNUTLS_FN):
478 * image.c (DEF_IMGLIB_FN): Make function pointers static.
479
480 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
481
482 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
483 marker. (Bug#8610)
484
485 2011-05-05 Eli Zaretskii <eliz@gnu.org>
486
487 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
488 New version that can reserve upto 2GB of heap space.
489
490 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
491
492 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
493
494 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
495
496 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
497 `gnutls_certificate_set_x509_key_file'.
498
499 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
500
501 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
502 Update dependencies.
503
504 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
505
506 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
507 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
508 Remove unused parameter `fildes'.
509 * process.c (read_process_output, send_process): Don't pass it.
510
511 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
512
513 Fix previous change: the library cache is defined in w32.c.
514 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
515 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
516
517 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
518
519 Implement dynamic loading of GnuTLS on Windows.
520
521 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
522 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
523 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
524 Declare.
525
526 * gnutls.c (Qgnutls_dll): Define.
527 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
528 (gnutls_*): Declare function pointers.
529 (init_gnutls_functions): New function to initialize function pointers.
530 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
531 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
532 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
533 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
534 (emacs_gnutls_write, emacs_gnutls_read)
535 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
536 (Fgnutls_available_p): New function.
537 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
538 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
539 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
540
541 * image.c: Include w32.h.
542 (Vimage_type_cache): Delete.
543 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
544 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
545 (w32_delayed_load): Move to w32.c.
546
547 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
548
549 * w32.c (QCloaded_from, Vlibrary_cache): Define.
550 (w32_delayed_load): Move from image.c. When loading a library, record
551 its filename in the :loaded-from property of the library id.
552 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
553 Initialize and staticpro them.
554 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
555
556 * process.c: Include lisp.h before w32.h, not after.
557 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
558 instead of gnutls_record_check_pending.
559
560 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
561
562 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
563
564 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
565 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
566 as passed in.
567
568 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
569
570 * xterm.c (x_set_frame_alpha): Do not set property on anything
571 else than FRAME_X_OUTER_WINDOW (Bug#8608).
572
573 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
574
575 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
576
577 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
578
579 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
580 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
581 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
582 (gnutls_global_initialized, Qgnutls_bootprop_priority)
583 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
584 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
585 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
586 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
587 (Qgnutls_bootprop_callbacks_verify): Make static.
588
589 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
590
591 * callproc.c: Indentation fixup.
592
593 * sysdep.c (wait_for_termination_1): Make static.
594 (wait_for_termination, interruptible_wait_for_termination):
595 Move after wait_for_termination_1.
596
597 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
598
599 * sysdep.c (interruptible_wait_for_termination): New function
600 which is like wait_for_termination, but allows keyboard
601 interruptions.
602
603 * callproc.c (Fcall_process): Add (:file "file") as an option for
604 the STDOUT buffer.
605 (Fcall_process_region): Ditto.
606
607 2011-04-30 Eli Zaretskii <eliz@gnu.org>
608
609 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
610 rather than `XVECTOR (FOO)->size'.
611
612 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
613 inttypes.h, as a gnulib replacement is used if it not available in
614 system headers.
615
616 2011-04-21 Eli Zaretskii <eliz@gnu.org>
617
618 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
619 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
620 of MOST_POSITIVE_FIXNUM. (Bug#8528)
621
622 * coding.c (coding_alloc_by_realloc): Error out if destination
623 will grow beyond MOST_POSITIVE_FIXNUM.
624 (decode_coding_emacs_mule): Abort if there isn't enough place in
625 charbuf for the composition carryover bytes. Reserve an extra
626 space for up to 2 characters produced in a loop.
627 (decode_coding_iso_2022): Abort if there isn't enough place in
628 charbuf for the composition carryover bytes.
629
630 2011-04-21 Eli Zaretskii <eliz@gnu.org>
631
632 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
633 aborting when %lld or %lll format is passed.
634 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
635 %llo or %llx format is passed. (Bug#8545)
636
637 * window.c (window_scroll_line_based): Use a marker instead of
638 simple variables to record original value of point. (Bug#7952)
639
640 * doprnt.c (doprnt): Fix the case where a multibyte sequence
641 produced by %s or %c overflows available buffer space. (Bug#8545)
642
643 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
644
645 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
646 (SIZE_MAX): Move defn after all includes, as they might #define it.
647
648 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
649
650 * w32.c (init_environment): Warn about defaulting HOME to C:\.
651
652 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
653
654 * keyboard.c (Qdelayed_warnings_hook): Define.
655 (command_loop_1): Run `delayed-warnings-hook'
656 if Vdelayed_warnings_list is non-nil.
657 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
658 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
659
660 2011-04-28 Eli Zaretskii <eliz@gnu.org>
661
662 * doprnt.c (doprnt): Don't return value smaller than the buffer
663 size if the message was truncated. (Bug#8545).
664
665 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
666
667 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
668 (Fx_window_property): #if-0 the whole functions, not just the bodies.
669
670 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
671
672 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
673
674 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
675
676 * makefile.w32-in: Update dependencies.
677
678 2011-04-27 Eli Zaretskii <eliz@gnu.org>
679
680 Improve `doprnt' and its usage. (Bug#8545)
681 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
682 `format_end'. Remove support for %l as a conversion specifier.
683 Don't use xrealloc. Improve diagnostics when the %l size modifier
684 is used. Update the commentary.
685
686 * eval.c (verror): Simplify calculation of size_t.
687
688 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
689 messages.
690
691 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
692
693 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
694 change.
695
696 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
697
698 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
699 This makes this file independent of the recent pseudovector change.
700
701 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
702
703 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
704
705 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
706 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
707 Remove unused local.
708 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
709
710 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
711 GCC 4.6.0 optimizes based on type-based alias analysis.
712 For example, if b is of type struct buffer * and v of type struct
713 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
714 != &v->size, and therefore "v->size = 1; b->size = 2; return
715 v->size;" must therefore return 1. This assumption is incorrect
716 for Emacs, since it type-puns struct Lisp_Vector * with many other
717 types. To fix this problem, this patch adds a new type struct
718 vectorlike_header that documents the constraints on layout of vectors
719 and pseudovectors, and helps optimizing compilers not get fooled
720 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
721 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
722 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
723 the size member.
724 (XSETPVECTYPE): Rewrite in terms of new macro.
725 (XSETPVECTYPESIZE): New macro, specifying both type and size.
726 This is a bit clearer, and further avoids the possibility of
727 undesirable aliasing.
728 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
729 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
730 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
731 since Lisp_Subr is a special case (no "next" field).
732 (ASIZE): Now uses header.size rather than size.
733 All previous uses of XVECTOR (foo)->size replaced to use this macro,
734 to avoid the hassle of writing XVECTOR (foo)->header.size.
735 (struct vectorlike_header): New type.
736 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
737 object, to help avoid aliasing.
738 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
739 (SUBRP): Likewise, since Lisp_Subr is a special case.
740 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
741 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
742 (struct Lisp_Hash_Table): Combine first two members into a single
743 struct vectorlike_header member. All uses of "size" and "next" members
744 changed to be "header.size" and "header.next".
745 * buffer.h (struct buffer): Likewise.
746 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
747 * frame.h (struct frame): Likewise.
748 * process.h (struct Lisp_Process): Likewise.
749 * termhooks.h (struct terminal): Likewise.
750 * window.c (struct save_window_data, struct saved_window): Likewise.
751 * window.h (struct window): Likewise.
752 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
753 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
754 * buffer.c (init_buffer_once): Likewise.
755 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
756 special case.
757 * process.c (Fformat_network_address): Use local var for size,
758 for brevity.
759
760 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
761
762 Make the Lisp reader and string-to-float more consistent (Bug#8525)
763 * data.c (atof): Remove decl; no longer used or needed.
764 (digit_to_number): Move to lread.c.
765 (Fstring_to_number): Use new string_to_number function, to be
766 consistent with how the Lisp reader treats infinities and NaNs.
767 Do not assume that floating-point numbers represent EMACS_INT
768 without losing information; this is not true on most 64-bit hosts.
769 Avoid double-rounding errors, by insisting on integers when
770 parsing non-base-10 numbers, as the documentation specifies.
771 * lisp.h (string_to_number): New decl, replacing ...
772 (isfloat_string): Remove.
773 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
774 (read1): Do not accept +. and -. as integers; this
775 appears to have been a coding error. Similarly, do not accept
776 strings like +-1e0 as floating point numbers. Do not report
777 overflow for integer overflows unless the base is not 10 which
778 means we have no simple and reliable way to continue.
779 Break out the floating-point parsing into a new
780 function string_to_number, so that Fstring_to_number parses
781 floating point numbers consistently with the Lisp reader.
782 (digit_to_number): Move here from data.c. Make it static inline.
783 (E_CHAR, EXP_INT): Remove, replacing with ...
784 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
785 (string_to_number): New function, replacing isfloat_string.
786 This function checks for valid syntax and produces the resulting
787 Lisp float number too. Rework it so that string-to-number
788 no longer mishandles examples like "1.0e+". Use strtoumax,
789 so that overflow for non-base-10 numbers is reported only when
790 there's no portable and simple way to convert to floating point.
791
792 * textprop.c (set_text_properties_1): Rewrite for clarity,
793 and to avoid GCC warning about integer overflow.
794
795 * intervals.h (struct interval): Use EMACS_INT for members
796 where EMACS_UINT might cause problems. See
797 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
798 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
799 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
800 All uses changed.
801 (offset_intervals): Tell GCC not to worry about length overflow
802 when negating a negative length.
803
804 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
805 (overrun_check_free): Likewise.
806
807 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
808 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
809 word size.
810
811 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
812 (gnutls_make_error): Rename local to avoid shadowing.
813 (gnutls_emacs_global_deinit): ifdef out; not used.
814 (Fgnutls_boot): Use const for pointer to readonly storage.
815 Comment out unused local. Fix pointer signedness problems.
816
817 * lread.c (openp): Don't stuff size_t into an 'int'.
818 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
819 about possible signed overflow.
820
821 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
822 (GDK_KEY_g): Don't define if already defined.
823 (xg_prepare_tooltip): Avoid pointer signedness problem.
824 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
825
826 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
827 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
828
829 * xfns.c (Fx_window_property): Simplify a bit,
830 to make a bit faster and to avoid GCC 4.6.0 warning.
831 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
832
833 * fns.c (internal_equal): Don't assume size_t fits in int.
834
835 * alloc.c (compact_small_strings): Tighten assertion a little.
836
837 Replace pEd with more-general pI, and fix some printf arg casts.
838 * lisp.h (pI): New macro, generalizing old pEd macro to other
839 conversion specifiers. For example, use "...%"pI"d..." rather
840 than "...%"pEd"...".
841 (pEd): Remove. All uses replaced with similar uses of pI.
842 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
843 * alloc.c (check_pure_size): Don't overflow by converting size to int.
844 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
845 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
846 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
847 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
848 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
849 64-bit hosts.
850 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
851 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
852 * print.c (safe_debug_print, print_object): Likewise.
853 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
854 to int.
855 Use pI instead of if-then-else-abort. Use %p to avoid casts,
856 avoiding the 0 flag, which is not portable.
857 * process.c (Fmake_network_process): Use pI to avoid cast.
858 * region-cache.c (pp_cache): Likewise.
859 * xdisp.c (decode_mode_spec): Likewise.
860 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
861 behavior on 64-bit hosts with printf arg.
862 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
863 (x_stop_queuing_selection_requests): Likewise.
864 (x_get_window_property): Don't truncate byte count to an 'int'
865 when tracing.
866
867 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
868 here, since it parses constructs like leading '-' and spaces,
869 which are not wanted; and it overflows with large numbers.
870 Instead, simply match F[0-9]+, which is what is wanted anyway.
871
872 * alloc.c: Remove unportable assumptions about struct layout.
873 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
874 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
875 (allocate_vectorlike, make_pure_vector): Use the new macros,
876 plus offsetof, to remove unportable assumptions about struct layout.
877 These assumptions hold on all porting targets that I know of, but
878 they are not guaranteed, they're easy to remove, and removing them
879 makes further changes easier.
880
881 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
882 This doesn't fix a bug but makes the code clearer.
883 (string_overrun_cookie): Now const. Use initializers that
884 don't formally overflow signed char, to avoid warnings.
885 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
886 can cause Emacs to crash when string overrun checking is enabled.
887 (allocate_buffer): Don't assume sizeof (struct buffer) is a
888 multiple of sizeof (EMACS_INT); it need not be, if
889 alignof(EMACS_INT) < sizeof (EMACS_INT).
890 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
891
892 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
893
894 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
895
896 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
897
898 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
899 supposed to be handshaking. (Bug#8556)
900 Reported by Paul Eggert <eggert@cs.ucla.edu>.
901
902 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
903
904 * lisp.h (Qdebug): List symbol.
905 * eval.c (Qdebug): Restore global linkage.
906 * keyboard.c (debug-on-event): New variable.
907 (handle_user_signal): Break into debugger when debug-on-event
908 matches the current signal symbol.
909
910 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
911
912 * alloc.c (check_sblock, check_string_bytes)
913 (check_string_free_list): Convert to standard C.
914
915 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
916
917 * w32.c (emacs_gnutls_push): Fix typo.
918
919 2011-04-25 Eli Zaretskii <eliz@gnu.org>
920
921 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
922 "cast to pointer from integer of different size".
923
924 Improve doprnt and its use in verror. (Bug#8545)
925 * doprnt.c (doprnt): Document the set of format control sequences
926 supported by the function. Use SAFE_ALLOCA instead of always
927 using `alloca'.
928
929 * eval.c (verror): Don't limit the buffer size at size_max-1, that
930 is one byte too soon. Don't use xrealloc; instead xfree and
931 xmalloc anew.
932
933 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
934
935 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
936 callbacks stage.
937
938 * gnutls.c: Renamed global_initialized to
939 gnutls_global_initialized. Added internals for the
940 :verify-hostname-error, :verify-error, and :verify-flags
941 parameters of `gnutls-boot' and documented those parameters in the
942 docstring. Start callback support.
943 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
944 unless a fatal error occured. Call gnutls_alert_send_appropriate
945 on error. Return error code.
946 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
947 (emacs_gnutls_read): Likewise.
948 (Fgnutls_boot): Return handshake error code.
949 (emacs_gnutls_handle_error): New function.
950 (wsaerror_to_errno): Likewise.
951
952 * w32.h (emacs_gnutls_pull): Add prototype.
953 (emacs_gnutls_push): Likewise.
954
955 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
956 (emacs_gnutls_push): Likewise.
957
958 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
959
960 * process.c (wait_reading_process_output): Check if GnuTLS
961 buffered some data internally if no FDs are set for TLS
962 connections.
963
964 * makefile.w32-in (OBJ2): Add gnutls.$(O).
965 (LIBS): Link to USER_LIBS.
966 ($(BLD)/gnutls.$(0)): New target.
967
968 2011-04-24 Eli Zaretskii <eliz@gnu.org>
969
970 * xdisp.c (handle_single_display_spec): Rename the
971 display_replaced_before_p argument into display_replaced_p, to
972 make it consistent with the commentary. Fix typos in the
973 commentary.
974
975 * textprop.c (syms_of_textprop): Remove dead code.
976 (copy_text_properties): Delete obsolete commentary about an
977 interface that was deleted long ago. Fix typos in the description
978 of arguments.
979
980 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
981 to changes in oldXMenu/XMenu.h from 2011-04-16.
982 <menu_help_message, prev_menu_help_message>: Constify.
983 (IT_menu_make_room): menu->help_text is now `const char **';
984 adjust.
985
986 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
987 to changes in oldXMenu/XMenu.h from 2011-04-16.
988 (struct XMenu): Declare `help_text' `const char **'.
989
990 * xfaces.c <Qunspecified>: Make extern again.
991
992 * syntax.c: Include sys/types.h before including regex.h, as
993 required by Posix.
994
995 * doc.c (get_doc_string): Improve the format passed to `error'.
996
997 * doprnt.c (doprnt): Improve commentary.
998
999 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1000
1001 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1002 them with etags.
1003
1004 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1005 changes in globals.h immediately force recompilation.
1006 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1007 $(CURDIR)/s/ms-w32.h.
1008 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1009
1010 * character.c (Fchar_direction): Function deleted.
1011 (syms_of_character): Don't defsubr it.
1012 <char-direction-table>: Deleted.
1013
1014 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1015
1016 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1017 * doprnt.c: Include limits.h.
1018 (SIZE_MAX): New macro.
1019 (doprnt): Return a size_t value. 2nd arg is now size_t.
1020 Many local variables are now size_t instead of int or unsigned.
1021 Improve overflow protection. Support `l' modifier for integer
1022 conversions. Support %l conversion. Don't assume an EMACS_INT
1023 argument for integer conversions and for %c.
1024
1025 * lisp.h (doprnt): Restore prototype.
1026
1027 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1028 $(SRC)/character.h.
1029
1030 * Makefile.in (base_obj): Add back doprnt.o.
1031
1032 * deps.mk (doprnt.o): Add back prerequisites.
1033 (callint.o): Depend on character.h.
1034
1035 * eval.c (internal_lisp_condition_case): Include the handler
1036 representation in the error message.
1037 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1038 when breaking from the loop.
1039
1040 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1041
1042 * callint.c (Fcall_interactively): When displaying error message
1043 about invalid control letter, pass the character's codepoint, not
1044 a pointer to its multibyte form. Improve display of the character
1045 in octal and display also its hex code.
1046
1047 * character.c (char_string): Use %x to display the (unsigned)
1048 codepoint of an invalid character, to avoid displaying a bogus
1049 negative value.
1050
1051 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1052 `error', not SYMBOL_NAME itself.
1053
1054 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1055 character arguments to `error'.
1056
1057 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1058 to `error' in error message about FINAL_CHAR argument. Make sure
1059 FINAL_CHAR is a character, and use %c when it is passed as
1060 argument to `error'.
1061
1062 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1063
1064 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1065
1066 * w32.c: Include <time.h>.
1067 (sys_localtime): New function.
1068
1069 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1070
1071 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1072
1073 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1074
1075 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1076
1077 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1078 zombies (Bug#8467).
1079
1080 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1081
1082 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1083 gl_state.e_property when gl_state.object is Qt.
1084
1085 * insdel.c (make_gap_larger): Remove limitation of buffer size
1086 to <= INT_MAX.
1087
1088 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1089
1090 * xdisp.c (lookup_glyphless_char_display)
1091 (produce_glyphless_glyph): Handle cons cell entry in
1092 glyphless-char-display.
1093 (Vglyphless_char_display): Document it.
1094
1095 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1096 glyphless-char-display.
1097
1098 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1099
1100 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1101
1102 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1103
1104 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1105 definition for no-X builds.
1106
1107 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1108
1109 Static checks with GCC 4.6.0 and non-default toolkits.
1110
1111 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1112
1113 * process.c (keyboard_bit_set): Define only if SIGIO.
1114 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1115 (send_process): Repair possible setjmp clobbering.
1116
1117 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1118
1119 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1120
1121 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1122
1123 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1124 Define only if needed.
1125
1126 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1127 by pacifying GCC about it. Maybe it's time to retire it?
1128 * xfaces.c (USG, __TIMEVAL__): Likewise.
1129
1130 * dispextern.h (struct redisplay_interface): Rename param
1131 to avoid shadowing.
1132 * termhooks.h (struct terminal): Likewise.
1133 * xterm.c (xembed_send_message): Likewise.
1134
1135 * insdel.c (make_gap_smaller): Define only if
1136 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1137
1138 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1139 it.
1140
1141 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1142 so that we aren't warned about unused symbols.
1143
1144 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1145
1146 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1147
1148 * xfns.c (x_real_positions): Mark locals as initialized.
1149
1150 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1151
1152 * xterm.c: Fix problems found by static analysis with other toolkits.
1153 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1154 (x_dispatch_event): Declare static if USE_GTK, and
1155 define if USE_GTK || USE_X_TOOLKIT.
1156 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1157 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1158 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1159 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1160
1161 * xmenu.c (menu_help_callback): Pointer type fixes.
1162 Use const pointers when pointing at readonly data. Avoid pointer
1163 signedness clashes.
1164 (FALSE): Remove unused macro.
1165 (update_frame_menubar): Remove unused decl.
1166
1167 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1168
1169 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1170 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1171 (single_menu_item): Rename local to avoid shadowing.
1172
1173 * keyboard.c (make_lispy_event): Remove unused local var.
1174
1175 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1176 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1177
1178 * bitmaps: Change bitmaps from unsigned char back to the X11
1179 compatible char. Avoid the old compiler warnings about
1180 out-of-range initializers by using, for example, '\xab' rather
1181 than 0xab.
1182
1183 * xgselect.c (xgselect_initialize): Check vs interface
1184 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1185
1186 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1187
1188 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1189 to read-only memory.
1190
1191 * fns.c (vector): Remove; this old hack is no longer needed.
1192
1193 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1194 Remove unused var.
1195 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1196
1197 * xrdb.c (x_load_resources): Omit unused local.
1198
1199 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1200 (x_window): Rename locals to avoid shadowing.
1201 (USG): Use the kludged USG macro, to pacify gcc.
1202
1203 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1204 (x_term_init): Remove local to avoid shadowing.
1205
1206 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1207
1208 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1209 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1210
1211 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1212
1213 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1214
1215 Fix regex.c, syntax.c and friends for buffers > 2GB.
1216 * syntax.h (struct gl_state_s): Declare character position members
1217 EMACS_INT.
1218
1219 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1220
1221 * textprop.c (verify_interval_modification, interval_of):
1222 Declare arguments EMACS_INT.
1223
1224 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1225 EMACS_INT.
1226
1227 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1228
1229 * indent.c (Fvertical_motion): Local variable it_start is now
1230 EMACS_INT.
1231
1232 * regex.c (re_match, re_match_2, re_match_2_internal)
1233 (bcmp_translate, regcomp, regexec, print_double_string)
1234 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1235 (re_compile_pattern, re_exec): Declare arguments and local
1236 variables `size_t' and `ssize_t' and return values `regoff_t', as
1237 appropriate.
1238 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1239 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1240 <compile_stack_type>: `size' and `avail' are now `size_t'.
1241
1242 * regex.h <regoff_t>: Use ssize_t, not int.
1243 (re_search, re_search_2, re_match, re_match_2): Arguments that
1244 specify buffer/string position and length are now ssize_t and
1245 size_t. Return type is regoff_t.
1246
1247 2011-04-16 Ben Key <bkey76@gmail.com>
1248
1249 * nsfont.m: Fixed bugs in ns_get_family and
1250 ns_descriptor_to_entity that were caused by using free to
1251 deallocate memory blocks that were allocated by xmalloc (via
1252 xstrdup). This caused Emacs to crash when compiled with
1253 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1254 --enable-checking=xmallocoverrun). xfree is now used to
1255 deallocate these memory blocks.
1256
1257 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1260
1261 emacs_write: Accept and return EMACS_INT for sizes.
1262 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1263 et seq.
1264 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1265 Accept and return EMACS_INT.
1266 (emacs_gnutls_write): Return the number of bytes written on
1267 partial writes.
1268 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1269 (emacs_read, emacs_write): Remove check for negative size, as the
1270 Emacs source code has been audited now.
1271 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1272 (emacs_read, emacs_write): Use it.
1273 * process.c (send_process): Adjust to the new signatures of
1274 emacs_write and emacs_gnutls_write. Do not attempt to store
1275 a byte offset into an 'int'; it might overflow.
1276 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1277
1278 * sound.c: Don't assume sizes fit in 'int'.
1279 (struct sound_device.period_size, alsa_period_size):
1280 Return EMACS_INT, not int.
1281 (struct sound_device.write, vox_write, alsa_write):
1282 Accept EMACS_INT, not int.
1283 (wav_play, au_play): Use EMACS_INT to store sizes and to
1284 record read return values.
1285
1286 2011-04-15 Ben Key <bkey76@gmail.com>
1287
1288 * keyboard.c (Qundefined): Don't declare static since it is used
1289 in nsfns.m.
1290 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1291 static since they are used in nsfont.m.
1292
1293 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1294
1295 * process.c (Qprocessp): Don't declare static.
1296 * lisp.h (Qprocessp): Declare again.
1297
1298 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1299
1300 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1301
1302 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 Improve C-level modularity by making more things 'static'.
1305
1306 Don't publish debugger-only interfaces to other modules.
1307 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1308 (verify_bytepos, count_markers): Move decls to the only modules
1309 that need them.
1310 * region-cache.h (pp_cache): Likewise.
1311 * window.h (check_all_windows): Likewise.
1312 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1313
1314 * sysdep.c (croak): Now static, if
1315 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1316 * syssignal.h (croak): Declare only if not static.
1317
1318 * alloc.c (refill_memory_reserve): Now static if
1319 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1320 * lisp.h (refill_memory_reserve): Declare only if not static.
1321
1322 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1323 Define only if USE_LUCID.
1324
1325 * xrdb.c (x_customization_string, x_rm_string): Now static.
1326
1327 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1328 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1329
1330 * xdisp.c (draw_row_with_mouse_face): Now static.
1331 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1332
1333 * window.h (check_all_windows): Mark externally visible.
1334
1335 * window.c (window_deletion_count): Now static.
1336
1337 * undo.c: Make symbols static if they're not exported.
1338 (last_undo_buffer, last_boundary_position, pending_boundary):
1339 Now static.
1340
1341 * textprop.c (interval_insert_behind_hooks): Now static.
1342 (interval_insert_in_front_hooks): Likewise.
1343
1344 * term.c: Make symbols static if they're not exported.
1345 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1346 (max_frame_lines, tty_set_terminal_modes):
1347 (tty_reset_terminal_modes, tty_turn_off_highlight):
1348 (get_tty_terminal): Now static.
1349 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1350 * termhooks.h (term_mouse_moveto): Do not declare if
1351 HAVE_WINDOW_SYSTEM.
1352 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1353 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1354
1355 * sysdep.c: Make symbols static if they're not exported.
1356 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1357 Now static.
1358 (sigprocmask_set, full_mask): Remove; unused.
1359 (wait_debugging): Mark as visible.
1360 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1361 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1362
1363 * syntax.c (syntax_temp): Define only if !__GNUC__.
1364
1365 * sound.c (current_sound_device, current_sound): Now static.
1366
1367 * search.c (searchbufs, searchbuf_head): Now static.
1368
1369 * scroll.c (scroll_cost): Remove; unused.
1370 * dispextern.h (scroll_cost): Remove decl.
1371
1372 * region-cache.h (pp_cache): Mark as externally visible.
1373
1374 * process.c: Make symbols static if they're not exported.
1375 (process_tick, update_tick, create_process, chan_process):
1376 (Vprocess_alist, proc_buffered_char, datagram_access):
1377 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1378 (deactivate_process): Mark defn as static, as well as decl.
1379 * lisp.h (create_process): Remove decl.
1380 * process.h (chan_process, Vprocess_alist): Remove decls.
1381
1382 * print.c: Make symbols static if they're not exported.
1383 (print_depth, new_backquote_output, being_printed, print_buffer):
1384 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1385 (print_interval, print_number_index, initial_stderr_stream):
1386 Now static.
1387 * lisp.h (Fprinc): Remove decl.
1388 (debug_output_compilation_hack): Mark as externally visible.
1389
1390 * sysdep.c (croak): Move decl from here to syssignal.h.
1391 * syssignal.h (croak): Put it here, so the API can be checked when
1392 'croak' is called from dissociate_if_controlling_tty.
1393
1394 * minibuf.c: Make symbols static if they're not exported.
1395 (minibuf_save_list, choose_minibuf_frame): Now static.
1396 * lisp.h (choose_minibuf_frame): Remove decl.
1397
1398 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1399
1400 * lread.c: Make symbols static if they're not exported.
1401 (read_objects, initial_obarray, oblookup_last_bucket_number):
1402 Now static.
1403 (make_symbol): Remove; unused.
1404 * lisp.h (initial_obarray, make_symbol): Remove decls.
1405
1406 * keyboard.c: Make symbols static if they're not exported.
1407 (single_kboard, recent_keys_index, total_keys, recent_keys):
1408 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1409 (this_single_command_key_start, echoing, last_auto_save):
1410 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1411 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1412 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1413 (Vlispy_mouse_stem, double_click_count):
1414 Now static.
1415 (force_auto_save_soon): Define only if SIGDANGER.
1416 (ignore_mouse_drag_p): Now static if
1417 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1418 (print_help): Remove; unused.
1419 (stop_character, last_timer_event): Mark as externally visible.
1420 * keyboard.h (ignore_mouse_drag_p): Declare only if
1421 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1422 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1423 * lisp.h (echoing): Remove decl.
1424 (force_auto_save_soon): Declare only if SIGDANGER.
1425 * xdisp.c (redisplay_window): Simplify code, to make it more
1426 obvious that ignore_mouse_drag_p is not accessed if !defined
1427 USE_GTK && !defined HAVE_NS.
1428
1429 * intervals.c: Make symbols static if they're not exported.
1430 (merge_properties_sticky, merge_interval_right, delete_interval):
1431 Now static.
1432 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1433
1434 * insdel.c: Make symbols static if they're not exported.
1435 However, leave prepare_to_modify_buffer alone. It's never
1436 called from outside this function, but that appears to be a bug.
1437 (combine_after_change_list, combine_after_change_buffer):
1438 (adjust_after_replace, signal_before_change): Now static.
1439 (adjust_after_replace_noundo): Remove; unused.
1440 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1441 (signal_before_change): Remove decls.
1442
1443 * indent.c (val_compute_motion, val_vmotion): Now static.
1444
1445 * image.c: Make symbols static if they're not exported.
1446 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1447 if USE_GTK.
1448 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1449 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1450
1451 * fringe.c (standard_bitmaps): Now static.
1452 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1453
1454 * frame.c: Make symbols static if they're not exported.
1455 (x_report_frame_params, make_terminal_frame): Now static.
1456 (get_frame_param): Now static, unless HAVE_NS.
1457 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1458 (x_get_resource_string): Remove; not used.
1459 * frame.h (make_terminal_frame, x_report_frame_params):
1460 (x_get_resource_string); Remove decls.
1461 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1462 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1463
1464 * font.c, fontset.c: Make symbols static if they're not exported.
1465 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1466 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1467 * font.c (font_close_object): Now static.
1468 * font.h (font_close_object): Remove.
1469 * fontset.c (FONTSET_OBJLIST): Remove.
1470 (free_realized_fontset) #if-0 the body, which does nothing.
1471 (face_suitable_for_char_p): #if-0, as it's never called.
1472 * fontset.h (face_suitable_for_char_p): Remove decl.
1473 * xfaces.c (face_at_string_position):
1474 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1475 since 0 is always ASCII.
1476
1477 * fns.c (weak_hash_tables): Now static.
1478
1479 * fileio.c: Make symbols static if they're not exported.
1480 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1481 (Vwrite_region_annotation_buffers): Now static.
1482
1483 * eval.c: Make symbols static if they're not exported.
1484 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1485 * lisp.h (backtrace_list): Remove decl.
1486
1487 * emacs.c: Make symbols static if they're not exported.
1488 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1489 (fatal_error_code, fatal_error_signal_hook, standard_args):
1490 Now static.
1491 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1492 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1493 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1494 * lisp.h (fatal_error_signal_hook): Remove decl.
1495 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1496
1497 * editfns.c: Move a (normally-unused) function to its only use.
1498 * editfns.c, lisp.h (get_operating_system_release): Remove.
1499 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1500 worth the hassle of breaking this out.
1501
1502 * xterm.c: Make symbols static if they're not exported.
1503 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1504 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1505 (x_destroy_window, x_delete_display):
1506 Now static.
1507 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1508 (x_mouse_leave): Remove; unused.
1509 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1510 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1511 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1512 Remove decls.
1513 (x_mouse_leave): Declare only if WINDOWSNT.
1514 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1515 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1516 USE_X_TOOLKIT.
1517
1518 * ftxfont.c: Make symbols static if they're not exported.
1519 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1520 HAVE_FREETYPE.
1521 * font.h (ftxfont_driver): Likewise.
1522
1523 * xfns.c: Make symbols static if they're not exported.
1524 (x_last_font_name, x_display_info_for_name):
1525 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1526 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1527 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1528 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1529 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1530 (last_show_tip_args): Now static.
1531 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1532 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1533 (x_screen_planes): Remove; unused.
1534 * dispextern.h (x_screen_planes): Remove decl.
1535
1536 * dispnew.c: Make symbols static if they're not exported.
1537 * dispextern.h (redraw_garbaged_frames, scrolling):
1538 (increment_row_positions): Remove.
1539 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1540 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1541 Now static.
1542 (redraw_garbaged_frames): Remove; unused.
1543
1544 * xfaces.c: Make symbols static if they're not exported.
1545 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1546 Remove decls.
1547 * xterm.h (defined_color): Remove decls.
1548 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1549 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1550 (menu_face_changed_default, defined_color, free_realized_face):
1551 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1552 (ascii_face_of_lisp_face): Remove; unused.
1553
1554 * xdisp.c: Make symbols static if they're not exported.
1555 * dispextern.h (scratch_glyph_row, window_box_edges):
1556 (glyph_to_pixel_coords, set_cursor_from_row):
1557 (get_next_display_element, set_iterator_to_next):
1558 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1559 (show_mouse_face): Remove decls
1560 * frame.h (message_buf_print): Likewise.
1561 * lisp.h (pop_message, set_message, check_point_in_composition):
1562 Likewise.
1563 * xterm.h (set_vertical_scroll_bar): Likewise.
1564 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1565 (message_buf_print, scratch_glyph_row, displayed_buffer):
1566 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1567 (get_next_display_element, show_mouse_face, window_box_edges):
1568 (frame_to_window_pixel_xy, check_point_in_composition):
1569 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1570 (glyph_to_pixel_coords): Remove; unused.
1571
1572 * dired.c (file_name_completion): Now static.
1573
1574 * dbusbind.c (xd_in_read_queued_messages): Now static.
1575
1576 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1577 * data.c (circular_list_error): Remove.
1578
1579 * commands.h (last_point_position, last_point_position_buffer):
1580 (last_point_position_window): Remove decls.
1581 * keyboard.c: Make these variables static.
1582
1583 * coding.h (coding, code_convert_region, encode_coding_gap):
1584 Remove decls.
1585 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1586 (iso_code_class, detect_coding, code_convert_region): Now static.
1587 (encode_coding_gap): Remove; unused.
1588
1589 * chartab.c (chartab_chars, chartab_bits): Now static.
1590
1591 * charset.h (charset_iso_8859_1): Remove decl.
1592 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1593 Now static.
1594
1595 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1596 * ccl.c (Vccl_program_table): Now static.
1597 (check_ccl_update): Remove; unused.
1598
1599 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1600 * category.h: ... from here.
1601 * category.c (check_category_table, set_category_set): Now static.
1602
1603 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1604 * lisp.h: Remove these decls.
1605
1606 * buffer.c (buffer_count): Remove unused var.
1607
1608 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1609 so that it's not optimized away.
1610 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1611 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1612 exported only to the debugger.
1613
1614 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1615 * atimer.h (run_all_atimers): Remove; not exported.
1616
1617 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1618 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1619 was inaccessible from Lisp.
1620 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1621 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1622
1623 alloc.c: Import and export fewer symbols, and remove unused items.
1624 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1625 is defined.
1626 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1627 it's not optimized away by whole-program optimization.
1628 (message_enable_multibyte, free_misc): Remove.
1629 (catchlist, handlerlist, mark_backtrace):
1630 Declare only if BYTE_MARK_STACK.
1631 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1632 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1633 (message_enable_multibyte): Remove decl.
1634 (free_misc, interval_free_list, float_block, float_block_index):
1635 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1636 (cons_free_list, last_marked_index):
1637 Now static.
1638 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1639 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1640 (mark_backtrace): Define only if BYTE_MARK_STACK.
1641 * xdisp.c (message_enable_multibyte): Now static.
1642
1643 Declare Lisp_Object Q* variables to be 'static' if not exported.
1644 This makes it easier for human readers (and static analyzers)
1645 to see whether these variables are used from other modules.
1646 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1647 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1648 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1649 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1650 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1651 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1652 * xmenu.c, xselect.c:
1653 Declare Q* vars static if they are not used in other modules.
1654 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1655 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1656 Remove decls of unexported vars.
1657 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1658
1659 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1660
1661 Make Emacs functions such as Fatom 'static' by default.
1662 This makes it easier for human readers (and static analyzers)
1663 to see whether these functions can be called from other modules.
1664 DEFUN now defines a static function. To make the function external
1665 so that it can be used in other C modules, use the new macro DEFUE.
1666 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1667 (Finit_image_library):
1668 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1669 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1670 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1671 Remove decls, since these functions are now static.
1672 (Funintern, Fget_internal_run_time): New decls, since these functions
1673 were already external.
1674
1675 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1676 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1677 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1678 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1679 * keyboard.c, keymap.c, lread.c:
1680 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1681 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1682 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1683 Mark functions with DEFUE instead of DEFUN,
1684 if they are used in other modules.
1685 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1686 decls for now-static functions.
1687 * buffer.h (Fdelete_overlay): Remove decl.
1688 * callproc.c (Fgetenv_internal): Mark as internal.
1689 * composite.c (Fremove_list_of_text_properties): Remove decl.
1690 (Fcomposition_get_gstring): New forward static decl.
1691 * composite.h (Fcomposite_get_gstring): Remove decl.
1692 * dired.c (Ffile_attributes): New forward static decl.
1693 * doc.c (Fdocumntation_property): New forward static decl.
1694 * eval.c (Ffetch_bytecode): New forward static decl.
1695 (Funintern): Remove extern decl; now in .h file where it belongs.
1696 * fileio.c (Fmake_symbolic_link): New forward static decl.
1697 * image.c (Finit_image_library): New forward static decl.
1698 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1699 * intervals.h (Fprevious_property_change):
1700 (Fremove_list_of_text_properties): Remove decls.
1701 * keyboard.c (Fthis_command_keys): Remove decl.
1702 (Fcommand_execute): New forward static decl.
1703 * keymap.c (Flookup_key): New forward static decl.
1704 (Fcopy_keymap): Now static.
1705 * keymap.h (Flookup_key): Remove decl.
1706 * process.c (Fget_process): New forward static decl.
1707 (Fprocess_datagram_address): Mark as internal.
1708 * syntax.c (Fsyntax_table_p): New forward static decl.
1709 (skip_chars): Remove duplicate decl.
1710 * textprop.c (Fprevious_property_change): New forward static decl.
1711 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1712 Now internal.
1713 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1714 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1715
1716 * editfns.c (Fformat): Remove unreachable code.
1717
1718 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1719
1720 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1721 change. (Bug#8496)
1722
1723 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1724
1725 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1726 when at ZV. (Bug#8487)
1727
1728 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1729
1730 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1731 (Bug#8437)
1732 * keyboard.c (parse_tool_bar_item): Likewise.
1733 * sound.c (sound_cleanup, alsa_close): Likewise.
1734 * termcap.c (tgetent): Likewise.
1735 * xfns.c (x_default_font_parameter): Likewise.
1736 * xsettings.c (read_and_apply_settings): Likewise.
1737
1738 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1739 (overrun_check_free): Protoize.
1740
1741 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1742
1743 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1744 since callers should never pass a negative size.
1745 Change the signature to match that of plain 'read' and 'write'; see
1746 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1747 * lisp.h: Update prototypes of emacs_write and emacs_read.
1748
1749 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1750
1751 * xdisp.c (redisplay_window): Don't try to determine the character
1752 position of the scroll margin if the window start point w->startp
1753 is outside the buffer's accessible region. (Bug#8468)
1754
1755 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1756
1757 Fix write-region and its subroutines for buffers > 2GB.
1758 * fileio.c (a_write, e_write): Modify declaration of arguments and
1759 local variables to support buffers larger than 2GB.
1760 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1761
1762 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1763 argument, local variables, and return value.
1764
1765 * lisp.h: Update prototypes of emacs_write and emacs_read.
1766
1767 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1768
1769 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1770
1771 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1772
1773 Fix more problems found by GCC 4.6.0's static checks.
1774
1775 * xdisp.c (vmessage): Use a better test for character truncation.
1776
1777 * charset.c (load_charset_map): <, not <=, for optimization,
1778 and to avoid potential problems with integer overflow.
1779 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1780 * casetab.c (set_identity, shuffle): Likewise.
1781 * editfns.c (Fformat): Likewise.
1782 * syntax.c (skip_chars): Likewise.
1783
1784 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1785 This also lets GCC 4.6.0 generate slightly better loop code.
1786
1787 * callint.c (Fcall_interactively): <, not <=, for optimization.
1788 (Fcall_interactively): Count the number of arguments produced,
1789 not the number of arguments given. This is simpler and lets GCC
1790 4.6.0 generate slightly better code.
1791
1792 * ftfont.c: Distingish more carefully between FcChar8 and char.
1793 The previous code passed unsigned char * to a functions like
1794 strlen and xstrcasecmp that expect char *, which does not
1795 conform to the C standard.
1796 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1797 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1798 char * when the C standard requires it.
1799
1800 * keyboard.c (read_char): Remove unused var.
1801
1802 * eval.c: Port to Windows vsnprintf (Bug#8435).
1803 Include <limits.h>.
1804 (SIZE_MAX): Define if the headers do not.
1805 (verror): Do not give up if vsnprintf returns a negative count.
1806 Instead, grow the buffer. This ports to Windows vsnprintf, which
1807 does not conform to C99. Problem reported by Eli Zaretskii.
1808 Also, simplify the allocation scheme, by avoiding the need for
1809 calling realloc, and removing the ALLOCATED variable.
1810
1811 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1812
1813 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1814 But keep the doprint source code for now, as we might revamp it
1815 and use it again (Bug#8435).
1816 * lisp.h (doprnt): Remove.
1817 * Makefile.in (base_obj): Remove doprnt.o.
1818 * deps.mk (doprnt.o): Remove.
1819
1820 error: Print 32- and 64-bit integers portably (Bug#8435).
1821 Without this change, on typical 64-bit hosts error ("...%d...", N)
1822 was used to print both 32- and 64-bit integers N, which relied on
1823 undefined behavior.
1824 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1825 New macro.
1826 * lisp.h (error, verror): Mark as printf-like functions.
1827 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1828 Report overflow in size calculations when allocating printf buffer.
1829 Do not truncate output string at its first null byte.
1830 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1831 Truncate the output at a character boundary, since vsnprintf does not
1832 do that.
1833 * charset.c (check_iso_charset_parameter): Convert internal
1834 character to string before calling 'error', since %c now has the
1835 printf meaning.
1836 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1837 overflow when computing char to be passed to 'error'. Do not
1838 pass Lisp_Object to 'error'; pass the integer instead.
1839 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1840 formatted with plain %d.
1841
1842 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1843
1844 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1845
1846 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1847
1848 * xterm.c (x_catch_errors): Remove duplicate declaration.
1849
1850 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1851
1852 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1853
1854 2011-04-10 Jim Meyering <meyering@redhat.com>
1855
1856 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1857 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1858 return ssize_t not "int", and use size_t as the buffer length.
1859 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1860 * gnutls.h: Update declarations.
1861 * process.c (read_process_output): Use ssize_t, to match.
1862 (send_process): Likewise.
1863
1864 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1865
1866 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1867
1868 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1869
1870 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1871 Use unsigned char, to match FcChar8 type definition.
1872
1873 * xterm.c (handle_one_xevent):
1874 * xmenu.c (create_and_show_popup_menu):
1875 * xselect.c (x_decline_selection_request)
1876 (x_reply_selection_request): Avoid type-punned deref of X events.
1877
1878 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1879
1880 Fix some uses of `int' instead of EMACS_INT.
1881 * search.c (string_match_1, fast_string_match)
1882 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1883 (scan_buffer, find_next_newline_no_quit)
1884 (find_before_next_newline, search_command, Freplace_match)
1885 (Fmatch_data): Make some `int' variables be EMACS_INT.
1886
1887 * xdisp.c (display_count_lines): 3rd argument and return value now
1888 EMACS_INT. All callers changed.
1889 (pint2hrstr): Last argument is now EMACS_INT.
1890
1891 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1892 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1893 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1894 (decode_coding_utf_16, decode_coding_emacs_mule)
1895 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1896 (decode_coding_ccl, decode_coding_charset)
1897 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1898 (decode_coding_iso_2022, decode_coding_emacs_mule)
1899 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1900 <char_offset, last_offset>: Declare EMACS_INT.
1901 (encode_coding_utf_8, encode_coding_utf_16)
1902 (encode_coding_emacs_mule, encode_invocation_designation)
1903 (encode_designation_at_bol, encode_coding_iso_2022)
1904 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1905 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1906 Declare EMACS_INT.
1907 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1908 (encode_invocation_designation): Last argument P_NCHARS is now
1909 EMACS_INT.
1910 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1911 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1912
1913 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1914 All users changed.
1915
1916 * ccl.c (Fccl_execute_on_string): Declare some variables
1917 EMACS_INT.
1918
1919 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1920
1921 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1922
1923 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1924
1925 * process.c (Fformat_network_address): Doc fix.
1926
1927 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1928
1929 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1930
1931 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1932
1933 * keyboard.c (read_char): Call Lisp function help-form-show,
1934 instead of using internal_with_output_to_temp_buffer.
1935 (Qhelp_form_show): New var.
1936 (syms_of_keyboard): Use DEFSYM macro.
1937
1938 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1939
1940 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1941
1942 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1943
1944 * process.c (Flist_processes): Remove to Lisp.
1945 (list_processes_1): Delete.
1946
1947 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1948
1949 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1950
1951 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1952
1953 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1954
1955 Fix more problems found by GCC 4.6.0's static checks.
1956
1957 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1958
1959 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1960
1961 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1962
1963 * xdisp.c (vmessage): Mark as a printf-like function.
1964
1965 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1966
1967 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1968
1969 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1970 printf-like functions.
1971 (tiff_load): Add casts to remove these marks before passing them
1972 to system-supplied API.
1973
1974 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1975
1976 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1977 This avoids several warnings with gcc -Wstrict-overflow.
1978 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1979 directly, rather than having caller test rule sign. This avoids
1980 some unnecessary tests.
1981 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1982 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1983 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1984
1985 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1986 (xfont_open): Avoid unnecessary tests.
1987
1988 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1989
1990 * composite.h, composite.c (composition_gstring_put_cache):
1991 Use EMACS_INT, not int, for length.
1992
1993 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1994 breaking out part of COMPOSITION_DECODE_RULE.
1995 (COMPOSITION_DECODE_RULE): Use it.
1996 * composite.c (get_composition_id): Remove unused local vars,
1997 by using the new macro.
1998
1999 * textprop.c (set_text_properties_1): Change while to do-while,
2000 since the condition is always true at first.
2001
2002 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2003 (interval_deletion_adjustment): Return unsigned value.
2004 All uses changed.
2005
2006 * process.c (list_processes_1, create_pty, read_process_output):
2007 (exec_sentinel): Remove vars that were set but not used.
2008 (create_pty): Remove unnecessary "volatile"s.
2009 (Fnetwork_interface_info): Avoid possibility of int overflow.
2010 (read_process_output): Do adaptive read buffering even if carryover.
2011 (read_process_output): Simplify nbytes computation if buffered.
2012
2013 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2014
2015 * syntax.c (scan_words): Remove var that was set but not used.
2016 (update_syntax_table): Use unsigned instead of int.
2017
2018 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2019 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2020 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2021
2022 * print.c (print_error_message): Avoid int overflow.
2023
2024 * font.c (font_list_entities): Redo for clarity,
2025 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2026
2027 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2028 (font_score): Avoid potential overflow in diff calculation.
2029
2030 * fns.c (substring_both): Remove var that is set but not used.
2031 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2032
2033 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2034
2035 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2036 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2037 can always succeed if overflow has undefined behavior.
2038
2039 * search.c (boyer_moore, wordify): Remove vars set but not used.
2040 (wordify): Omit three unnecessary tests.
2041
2042 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2043 All callers changed. This avoids the need for an unused var.
2044
2045 * casefiddle.c (casify_region): Remove var that is set but not used.
2046
2047 * dired.c (file_name_completion): Remove var that is set but not used.
2048
2049 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2050
2051 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2052 (Finsert_file_contents): Remove unnecessary code checking fd.
2053
2054 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2055 Check for integer overflow on size calculations.
2056
2057 * buffer.c (Fprevious_overlay_change): Remove var that is set
2058 but not used.
2059
2060 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2061 Remove vars that are set but not used.
2062 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2063 (timer_check_2): Mark vars as initialized.
2064
2065 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2066
2067 * image.c (lookup_image): Remove var that is set but not used.
2068 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2069
2070 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2071 that are set but not used.
2072
2073 * xfns.c (make_invisible_cursor): Don't return garbage
2074 if XCreateBitmapFromData fails (Bug#8410).
2075
2076 * xselect.c (x_get_local_selection, x_handle_property_notify):
2077 Remove vars that are set but not used.
2078
2079 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2080 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2081
2082 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2083 Remove var that is set but not used.
2084 (scroll_bar_windows_size): Now size_t, not int.
2085 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2086 Check for overflow.
2087
2088 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2089 (map_tty_color) [!defined MSDOS]: Likewise.
2090
2091 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2092
2093 * coding.c: Remove vars that are set but not used.
2094 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2095 All callers changed.
2096 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2097 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2098 (decode_coding_charset): Remove vars that are set but not used.
2099
2100 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2101 that is set but not used.
2102
2103 * print.c (print_object): Remove var that is set but not used.
2104
2105 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2106 The gnulib version avoids calling malloc in the usual case,
2107 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2108 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2109 * filelock.c (current_lock_owner): Likewise.
2110 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2111 * sysdep.c: Include allocator.h, careadlinkat.h.
2112 (emacs_no_realloc_allocator): New static constant.
2113 (emacs_readlink): New function.
2114 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2115 ../lib/careadlinkat.h.
2116
2117 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2118
2119 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2120 first non-nil return value).
2121
2122 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2123
2124 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2125 if not defined (Bug#8403).
2126
2127 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2128
2129 * xdisp.c (display_count_lines): Remove parameter `start',
2130 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2131 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2132 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2133 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2134 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2135 and thereabouts. All callers changed.
2136 (get_per_char_metric): Remove parameter `f', unused since
2137 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2138
2139 2011-04-02 Jim Meyering <meyering@redhat.com>
2140
2141 do not dereference NULL upon failed strdup
2142 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2143 (ns_get_family): Likewise.
2144
2145 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2146
2147 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2148
2149 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2150
2151 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2152 later (Bug#8403).
2153
2154 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2155
2156 Add lexical binding.
2157
2158 * window.c (Ftemp_output_buffer_show): New fun.
2159 (Fsave_window_excursion):
2160 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2161
2162 * lread.c (lisp_file_lexically_bound_p): New function.
2163 (Fload): Bind Qlexical_binding.
2164 (readevalloop): Remove `evalfun' arg.
2165 Bind Qinternal_interpreter_environment.
2166 (Feval_buffer): Bind Qlexical_binding.
2167 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2168 Mark as dynamic.
2169 (syms_of_lread): Declare `lexical-binding'.
2170
2171 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2172
2173 * keyboard.c (eval_dyn): New fun.
2174 (menu_item_eval_property): Use it.
2175
2176 * image.c (parse_image_spec): Use Ffunctionp.
2177
2178 * fns.c (concat, mapcar1): Accept byte-code-functions.
2179
2180 * eval.c (Fsetq): Handle lexical vars.
2181 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2182 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2183 (FletX, Flet): Obey lexical binding.
2184 (Fcommandp): Handle closures.
2185 (Feval): New `lexical' arg.
2186 (eval_sub): New function extracted from Feval. Use it almost
2187 everywhere where Feval was used. Look up vars in lexical env.
2188 Handle closures.
2189 (Ffunctionp): Move from subr.el.
2190 (Ffuncall): Handle closures.
2191 (apply_lambda): Remove `eval_flags'.
2192 (funcall_lambda): Handle closures and new byte-code-functions.
2193 (Fspecial_variable_p): New function.
2194 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2195 but without exporting it to Lisp.
2196
2197 * doc.c (Fdocumentation, store_function_docstring):
2198 * data.c (Finteractive_form): Handle closures.
2199
2200 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2201 interactive spec.
2202
2203 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2204 New byte-codes.
2205 (exec_byte_code): New function extracted from Fbyte_code to handle new
2206 calling convention for byte-code-functions. Add new byte-codes.
2207
2208 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2209
2210 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2211
2212 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2213
2214 * xdisp.c (redisplay_internal): Fix prototype.
2215
2216 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (SCROLL_LIMIT): New macro.
2219 (try_scrolling): Use it when setting scroll_limit.
2220 Limit scrolling to 100 screen lines.
2221 (redisplay_window): Even when falling back on "recentering",
2222 position point in the window according to scroll-conservatively,
2223 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2224
2225 (try_scrolling): When point is above the window, allow searching
2226 as far as scroll_max, or one screenful, to compute vertical
2227 distance from PT to the scroll margin position. This prevents
2228 try_scrolling from unnecessarily failing when
2229 scroll-conservatively is set to a value slightly larger than the
2230 window height. Clean up the case of PT below the margin at bottom
2231 of window: scroll_max can no longer be INT_MAX. When aggressive
2232 scrolling is in use, don't let point enter the opposite scroll
2233 margin as result of the scroll.
2234 (syms_of_xdisp) <scroll-conservatively>: Document the
2235 threshold of 100 lines for never-recentering scrolling.
2236
2237 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2238
2239 * dispextern.h (move_it_by_lines):
2240 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2241 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2242 (message_log_check_duplicate): Remove parameters `prev_bol' and
2243 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2244 (redisplay_internal): Remove parameter `preserve_echo_area',
2245 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2246
2247 * indent.c (Fvertical_motion):
2248 * window.c (window_scroll_pixel_based, Frecenter):
2249 Don't pass `need_y_p' to `move_it_by_lines'.
2250
2251 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2252
2253 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2254 steal a few bits to be more compact.
2255 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2256 Remove unneeded casts.
2257
2258 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2259
2260 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2261
2262 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2263 binding" message (bug#7967).
2264
2265 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2266
2267 Fix more problems found by GCC 4.6.0's static checks.
2268
2269 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2270 Remove unused local var.
2271
2272 * editfns.c (Fmessage_box): Remove unused local var.
2273
2274 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2275 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2276 Omit unused local vars.
2277 * window.c (shrink_windows): Omit unused local var.
2278 * menu.c (digest_single_submenu): Omit unused local var.
2279 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2280 Omit unused local var.
2281
2282 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2283 Don't assume string length fits in int.
2284 (keyremap_step, read_key_sequence): Use size_t for sizes.
2285 (read_key_sequence): Don't check last_real_key_start redundantly.
2286
2287 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2288 instead of alloca (Bug#8344).
2289
2290 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2291 (Fbacktrace_frame): Don't assume nframes fits in int.
2292
2293 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2294
2295 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2296 concerns.
2297
2298 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2299
2300 * cm.c (calccost): Turn while-do into do-while, for clarity.
2301
2302 * keyboard.c (syms_of_keyboard): Use the same style as later
2303 in this function when indexing through an array. This also
2304 works around GCC bug 48267.
2305
2306 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2307
2308 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2309
2310 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2311 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2312
2313 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2314 This avoids undefined behavior on integer overflow, and is a bit
2315 more convenient anyway since it is compared to a size_t variable.
2316
2317 Variadic C functions now count arguments with size_t, not int.
2318 This avoids an unnecessary limitation on 64-bit machines, which
2319 caused (substring ...) to crash on large vectors (Bug#8344).
2320 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2321 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2322 All variadic functions and their callers changed accordingly.
2323 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2324 * data.c (arith_driver, float_arith_driver): Likewise.
2325 * editfns.c (general_insert_function): Likewise.
2326 * eval.c (struct backtrace.nargs, interactive_p)
2327 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2328 (funcall_lambda, mark_backtrace): Likewise.
2329 * fns.c (concat): Likewise.
2330 * frame.c (x_set_frame_parameters): Likewise.
2331 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2332 0 if not found, not -1. All callers changed.
2333
2334 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2335 (stack_copy_size): Now size_t, not int.
2336 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2337
2338 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2339
2340 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2341 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2342 All callers changed.
2343
2344 * lisp.h (multibyte_char_to_unibyte):
2345 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2346 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2347 * character.h (CHAR_TO_BYTE8):
2348 * cmds.c (internal_self_insert):
2349 * editfns.c (general_insert_function):
2350 * keymap.c (push_key_description):
2351 * search.c (Freplace_match):
2352 * xdisp.c (message_dolog, set_message_1): All callers changed.
2353
2354 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2355
2356 * keyboard.c (safe_run_hook_funcall): New function.
2357 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2358 don't set the hook to nil, but remove the offending function instead.
2359 (Qcommand_hook_internal): Remove, unused.
2360 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2361 Vcommand_hook_internal.
2362
2363 * eval.c (enum run_hooks_condition): Remove.
2364 (funcall_nil, funcall_not): New functions.
2365 (run_hook_with_args): Call each function through a `funcall' argument.
2366 Remove `cond' argument, now redundant.
2367 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2368 (Frun_hook_with_args_until_failure): Adjust accordingly.
2369 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2370
2371 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2372
2373 * dispextern.h (string_buffer_position): Remove declaration.
2374
2375 * print.c (strout): Remove parameter `multibyte', unused since
2376 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2377
2378 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2379 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2380 All callers changed.
2381
2382 * w32.c (_wsa_errlist): Use braces for struct initializers.
2383
2384 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2385 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2386 All callers changed.
2387 (string_buffer_position): Likewise. Also, make static (it's never
2388 used outside xdisp.c).
2389 (cursor_row_p): Remove parameter `w', unused since
2390 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2391 (decode_mode_spec): Remove parameter `precision', introduced during
2392 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2393 All callers changed.
2394
2395 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2396
2397 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2398
2399 2011-03-27 Anders Lindgren <andlind@gmail.com>
2400
2401 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2402 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2403 (ns_update_auto_hide_menu_bar): New functions.
2404 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2405 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2406 ns_constrain_all_frames.
2407 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2408 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2409
2410 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2411
2412 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2413
2414 2011-03-27 Glenn Morris <rgm@gnu.org>
2415
2416 * syssignal.h: Replace RETSIGTYPE with void.
2417 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2418 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2419 Replace SIGTYPE with void everywhere.
2420 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2421 * s/template.h (SIGTYPE): Remove commented out definition.
2422
2423 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2424
2425 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2426 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2427
2428 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2429
2430 * w32.c (read_unc_volume): Use parameter `henum', instead of
2431 global variable `wget_enum_handle'.
2432
2433 * keymap.c (describe_vector): Remove parameters `indices' and
2434 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2435 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2436
2437 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2438
2439 * keyboard.c (timer_check): Remove parameter `do_it_now',
2440 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2441 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2442 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2443
2444 * keyboard.c (read_char):
2445 * w32menu.c (w32_menu_display_help):
2446 * xmenu.c (show_help_event, menu_help_callback):
2447 Adjust calls to `show_help_echo'.
2448
2449 * gtkutil.c (xg_maybe_add_timer):
2450 * keyboard.c (readable_events):
2451 * process.c (wait_reading_process_output):
2452 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2453
2454 * insdel.c (adjust_markers_gap_motion):
2455 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2456 (gap_left, gap_right): Don't call it.
2457
2458 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2459
2460 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2461 incurred during fontification.
2462
2463 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2464
2465 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2466 (DEFVAR_PER_BUFFER): Don't pass it.
2467
2468 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2469 (scrolling_window): Don't pass it.
2470
2471 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2472
2473 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2474
2475 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2476 and `suffix'.
2477 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2478 of variables specific to SELinux and computation of `encoded_absname'.
2479
2480 * image.c (XPutPixel): Remove unused variable `height'.
2481
2482 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2483
2484 * unexw32.c (get_section_info): Remove unused variable `section'.
2485
2486 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2487 (system_process_attributes): Remove unused variable `sess'.
2488 (sys_read): Remove unused variable `err'.
2489
2490 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2491 (w32_wnd_proc): Remove unused variable `isdead'.
2492 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2493 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2494 (x_create_tip_frame): Remove unused variable `tem'.
2495
2496 * w32inevt.c (w32_console_read_socket):
2497 Remove unused variable `no_events'.
2498
2499 * w32term.c (x_draw_composite_glyph_string_foreground):
2500 Remove unused variable `width'.
2501
2502 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2503
2504 * w32term.c (x_set_glyph_string_clipping):
2505 Don't pass uninitialized region to CombineRgn.
2506
2507 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2508
2509 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2510 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2511 (Fx_close_connection): Remove unused variable `i'.
2512
2513 * w32font.c (w32font_draw): Return number of glyphs.
2514 (w32font_open_internal): Remove unused variable `i'.
2515 (w32font_driver): Add missing initializer.
2516
2517 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2518 (fill_in_menu): Remove unused variable `items_added'.
2519
2520 * w32term.c (last_mouse_press_frame): Remove static global variable.
2521 (w32_clip_to_row): Remove unused variable `f'.
2522 (x_delete_terminal): Remove unused variable `i'.
2523
2524 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2525 (NOTHING): Remove unused static global variable.
2526 (uniscribe_check_otf): Remove unused variable `table'.
2527 (uniscribe_font_driver): Add missing initializers.
2528
2529 2011-03-23 Julien Danjou <julien@danjou.info>
2530
2531 * term.c (Fsuspend_tty, Fresume_tty):
2532 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2533 * window.c (temp_output_buffer_show):
2534 * insdel.c (signal_before_change):
2535 * frame.c (Fhandle_switch_frame):
2536 * fileio.c (Fdo_auto_save):
2537 * emacs.c (Fkill_emacs):
2538 * editfns.c (save_excursion_restore):
2539 * cmds.c (internal_self_insert):
2540 * callint.c (Fcall_interactively):
2541 * buffer.c (Fkill_all_local_variables):
2542 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2543 Use Frun_hooks.
2544 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2545 unconditionnaly since it does the check itself.
2546
2547 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2548
2549 Fix more problems found by GCC 4.5.2's static checks.
2550
2551 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2552 the first time through the loop, since we know p0 < p1 then.
2553 This also avoids a gcc -Wstrict-overflow warning.
2554
2555 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2556 leading to a memory leak, possible in functions like
2557 load_charset_map_from_file that can allocate an unbounded number
2558 of objects (Bug#8318).
2559
2560 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2561 that could (at least in theory) be that large.
2562
2563 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2564 This is less likely to overflow, and avoids undefined behavior if
2565 overflow does occur. All callers changed. Use strtoul to scan
2566 for the unsigned long integer.
2567 (pint2hrstr): Simplify and tune code slightly.
2568 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2569
2570 * scroll.c (do_scrolling): Work around GCC bug 48228.
2571 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2572
2573 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2574 This also avoids a warning with gcc -Wstrict-overflow.
2575 (validate_x_resource_name): Simplify count usage.
2576 This also avoids a warning with gcc -Wstrict-overflow.
2577
2578 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2579 fail (Bug#8306).
2580
2581 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2582
2583 * process.c (Fmake_network_process): Use socklen_t, not int,
2584 where POSIX says socklen_t is required in portable programs.
2585 This fixes a porting bug on hosts like 64-bit HP-UX, where
2586 socklen_t is wider than int (Bug#8277).
2587 (Fmake_network_process, server_accept_connection):
2588 (wait_reading_process_output, read_process_output):
2589 Likewise.
2590
2591 * process.c: Rename or move locals to avoid shadowing.
2592 (list_processes_1, Fmake_network_process):
2593 (read_process_output_error_handler, exec_sentinel_error_handler):
2594 Rename or move locals.
2595 (Fmake_network_process): Define label "retry_connect" only if needed.
2596 (Fnetwork_interface_info): Fix pointer signedness.
2597 (process_send_signal): Add cast to avoid pointer signedness problem.
2598 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2599 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2600
2601 Make tparam.h and terminfo.c consistent.
2602 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2603 Include tparam.h instead, since it declares them.
2604 * cm.h (PC): Remove extern decl; tparam.h now does this.
2605 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2606 * terminfo.c: Include tparam.h, to check interfaces.
2607 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2608 (tparam): Adjust signature to match interface in tparam.h;
2609 this removes some undefined behavior. Check that outstring and len
2610 are zero, which they always are with Emacs.
2611 * tparam.h (PC, BC, UP): New extern decls.
2612
2613 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2614 (xftfont_open): Rename locals to avoid shadowing.
2615
2616 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2617 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2618 (OTF_TAG_SYM): Omit macro if not needed.
2619 (ftfont_list): Remove unused local.
2620 (get_adstyle_property, ftfont_pattern_entity):
2621 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2622 Rename locals to avoid shadowing.
2623
2624 * xfont.c (xfont_list_family): Mark var as initialized.
2625
2626 * xml.c (make_dom): Now static.
2627
2628 * composite.c (composition_compute_stop_pos): Rename local to
2629 avoid shadowing.
2630 (composition_reseat_it): Remove unused locals.
2631 (find_automatic_composition, composition_adjust_point): Likewise.
2632 (composition_update_it): Mark var as initialized.
2633 (find_automatic_composition): Mark vars as initialized,
2634 with a FIXME (Bug#8290).
2635
2636 character.h: Rename locals to avoid shadowing.
2637 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2638 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2639 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2640 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2641 to avoid shadowing.
2642
2643 * textprop.c (property_change_between_p): Remove; unused.
2644
2645 * intervals.c (interval_start_pos): Now static.
2646
2647 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2648
2649 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2650 Rename locals to avoid shadowing.
2651
2652 * sound.c (wav_play, au_play, Fplay_sound_internal):
2653 Fix pointer signedness.
2654 (alsa_choose_format): Remove unused local var.
2655 (wav_play): Initialize a variable to 0, to prevent undefined
2656 behavior (Bug#8278).
2657
2658 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2659
2660 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2661
2662 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2663 clobbering (Bug#8298).
2664 * sysdep.c (sys_subshell): Likewise.
2665 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2666
2667 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2668 This should get cleaned up, so that child_setup has the
2669 same signature on all platforms.
2670
2671 * callproc.c (call_process_cleanup): Now static.
2672 (relocate_fd): Rename locals to avoid shadowing.
2673
2674 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2675
2676 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2677 not to be necessary, and produces flickering.
2678
2679 2011-03-20 Glenn Morris <rgm@gnu.org>
2680
2681 * config.in: Remove file.
2682
2683 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2684
2685 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2686 are now in src/globals.h.
2687 (syms_of_minibuf): Remove spurious & from previous change.
2688
2689 2011-03-20 Leo <sdl.web@gmail.com>
2690
2691 * minibuf.c (completing-read-function): New variable.
2692 (completing-read-default): Rename from completing-read.
2693 (completing-read): Call completing-read-function.
2694
2695 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2696
2697 * xfaces.c (Fx_load_color_file):
2698 Read color file from absolute filename (bug#8250).
2699
2700 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2701
2702 * makefile.w32-in: Update dependencies.
2703
2704 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2705
2706 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2707
2708 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2709
2710 Fix more problems found by GCC 4.5.2's static checks.
2711
2712 * process.c (make_serial_process_unwind, send_process_trap):
2713 (sigchld_handler): Now static.
2714
2715 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2716 That way, the code declares only the vars that it needs.
2717 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2718 * s/cygwin.h (PTY_ITERATION): Likewise.
2719 * s/darwin.h (PTY_ITERATION): Likewise.
2720 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2721
2722 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2723 * process.c (allocate_pty): Don't declare stb unless it's needed.
2724
2725 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2726 (CONSTANTLIM): Remove; unused.
2727 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2728 Define only if needed.
2729
2730 * unexelf.c (unexec): Name an expression,
2731 to avoid gcc -Wbad-function-cast warning.
2732 Use a different way to cause a compilation error if anyone uses
2733 n rather than nn, a way that does not involve shadowing.
2734 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2735
2736 * deps.mk (unexalpha.o): Remove; unused.
2737
2738 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2739 * unexec.h: New file.
2740 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2741 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2742 Depend on unexec.h.
2743 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2744 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2745 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2746 Change as necessary to match prototype in unexec.h.
2747
2748 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2749 shadowing.
2750 (back_comment, skip_chars): Mark vars as initialized.
2751
2752 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2753 Rename locals to avoid shadowing.
2754
2755 * lread.c (read1): Rewrite so as not to use empty "else".
2756 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2757
2758 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2759
2760 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2761 warning when compiling print.c.
2762
2763 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2764 instead of using an uninitialized var.
2765 (font_sort_entities): Mark var as initialized.
2766
2767 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2768
2769 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2770 pointers to constants.
2771 (font_parse_fcname): Remove unused vars.
2772 (font_delete_unmatched): Now static.
2773 (font_get_spec): Remove; unused.
2774 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2775 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2776 Rename or move locals to avoid shadowing.
2777
2778 * fns.c (require_nesting_list, require_unwind): Now static.
2779 (Ffillarray): Rename locals to avoid shadowing.
2780
2781 * floatfns.c (domain_error2): Define only if needed.
2782 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2783
2784 * alloc.c (mark_backtrace): Move decl from here ...
2785 * lisp.h: ... to here, so that it can be checked.
2786
2787 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2788 (Fdefvar): Rewrite so as not to use empty "else".
2789 (lisp_indirect_variable): Name an expression,
2790 to avoid gcc -Wbad-function-cast warning.
2791 (Fdefvar): Rename locals to avoid shadowing.
2792
2793 * callint.c (quotify_arg, quotify_args): Now static.
2794 (Fcall_interactively): Rename locals to avoid shadowing.
2795 Use const pointer when appropriate.
2796
2797 * lisp.h (get_system_name, get_operating_system_release):
2798 Move decls here, to check interfaces.
2799 * process.c (get_operating_system_release): Move decl to lisp.h.
2800 * xrdb.c (get_system_name): Likewise.
2801 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2802 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2803 some of which prompt warnings from gcc -Wbad-function-cast.
2804 (Fformat_time_string, Fencode_time, Finsert_char):
2805 (Ftranslate_region_internal, Fformat):
2806 Rename or remove local vars to avoid shadowing.
2807 (Ftranslate_region_internal): Mark var as initialized.
2808
2809 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2810 avoid shadowing.
2811
2812 * lisp.h (eassert): Check that the argument compiles, even if
2813 ENABLE_CHECKING is not defined.
2814
2815 * data.c (Findirect_variable): Name an expression, to avoid
2816 gcc -Wbad-function-cast warning.
2817 (default_value, arithcompare, arith_driver, arith_error): Now static.
2818 (store_symval_forwarding): Rename local to avoid shadowing.
2819 (Fmake_variable_buffer_local, Fmake_local_variable):
2820 Mark variables as initialized.
2821 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2822
2823 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2824 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2825 Rename locals to avoid shadowing.
2826 (mark_stack): Move local variables into the #ifdef region where
2827 they're used.
2828 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2829 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2830 needed otherwise.
2831 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2832 (GC_STRING_CHARS): Remove; not used.
2833 (Fmemory_limit): Cast sbrk's returned value to char *.
2834
2835 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2836 avoids undefined behavior in theory.
2837
2838 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2839
2840 Use functions, not macros, for up- and down-casing (Bug#8254).
2841 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2842 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2843 to use the following functions instead of these macros.
2844 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2845 EMACS_INT, since callers assume the returned value fits in int.
2846 (upcase1): Likewise, for UPCASE_TABLE.
2847 (uppercasep, lowercasep, upcase): New static inline functions.
2848 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2849 the race-condition problem in the old DOWNCASE.
2850
2851 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2852 Rename locals to avoid shadowing.
2853 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2854 (regex_compile, re_search_2, re_match_2_internal):
2855 Remove unused local vars.
2856 (FREE_VAR): Rewrite so as not to use empty "else",
2857 which gcc can warn about.
2858 (regex_compile, re_match_2_internal): Mark locals as initialized.
2859 (RETALLOC_IF): Define only if needed.
2860 (WORDCHAR_P): Likewise. This one is never needed, but is used
2861 only in a comment talking about a compiler bug, so put inside
2862 the #if 0 of that comment.
2863 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2864 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2865 Remove; unused.
2866
2867 * search.c (boyer_moore): Rename locals to avoid shadowing.
2868 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2869 (PREV_CHAR_BOUNDARY): Likewise.
2870
2871 * search.c (simple_search): Remove unused var.
2872
2873 * dired.c (compile_pattern): Move decl from here ...
2874 * lisp.h: ... to here, so that it can be checked.
2875 (struct re_registers): New forward decl.
2876
2877 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2878
2879 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2880 All uses changed.
2881 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2882 Rename locals to avoid shadowing.
2883 (Fvertical_motion): Mark locals as initialized.
2884
2885 * casefiddle.c (casify_object, casify_region): Now static.
2886 (casify_region): Mark local as initialized.
2887
2888 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2889
2890 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2891 New macros, so that the caller can use some names other than
2892 gcpro1, gcpro2, etc.
2893 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2894 of the new macros.
2895 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2896 argument, for consistency with GCPRO2_VAR, etc: it is now the
2897 prefix of the variable, not the variable itself. All uses
2898 changed.
2899 * dired.c (directory_files_internal, file_name_completion):
2900 Rename locals to avoid shadowing.
2901
2902 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2903 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2904 dired.c's scmp function, had undefined behavior.
2905 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2906 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2907 * buffer.h: ... to here, because these macros use current_buffer,
2908 and the new implementation with inline functions needs to have
2909 current_buffer in scope now, rather than later when the macros
2910 are used.
2911 (downcase, upcase1): New static inline functions.
2912 (DOWNCASE, UPCASE1): Reimplement using these functions.
2913 This avoids undefined behavior in expressions like
2914 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2915 from race conditions in accessing the global variables
2916 case_temp1 and case_temp2.
2917 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2918 * lisp.h (case_temp1, case_temp2): Remove their decls.
2919 * character.h (ASCII_CHAR_P): Move from here ...
2920 * lisp.h: ... to here, so that the inline functions mentioned
2921 above can use them.
2922
2923 * dired.c (directory_files_internal_unwind): Now static.
2924
2925 * fileio.c (file_name_as_directory, directory_file_name):
2926 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2927 Now static.
2928 (file_name_as_directory): Use const pointers when appropriate.
2929 (Fexpand_file_name): Likewise. In particular, newdir might
2930 point at constant storage, so make it a const pointer.
2931 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2932 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2933 signedness issues.
2934 (Fset_file_times, Finsert_file_contents, auto_save_error):
2935 Rename locals to avoid shadowing.
2936
2937 * minibuf.c (choose_minibuf_frame_1): Now static.
2938 (Ftry_completion, Fall_completions): Rename or remove locals
2939 to avoid shadowing.
2940
2941 * marker.c (bytepos_to_charpos): Remove; unused.
2942
2943 * lisp.h (verify_bytepos, count_markers): New decls,
2944 so that gcc does not warn that these functions aren't declared.
2945
2946 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2947 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2948 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2949 (copy_text): Remove unused local var.
2950
2951 * filelock.c (within_one_second): Now static.
2952 (lock_file_1): Rename local to avoid shadowing.
2953
2954 * buffer.c (fix_overlays_before): Mark locals as initialized.
2955 (fix_start_end_in_overlays): Likewise. This function should be
2956 simplified by using pointers-to-pointers, but that's a different
2957 matter.
2958 (switch_to_buffer_1): Now static.
2959 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2960 (report_overlay_modification): Rename locals to avoid shadowing.
2961
2962 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2963 Fix pointer signedness issue.
2964 (sys_subshell): Mark local as volatile if checking for lint,
2965 to suppress a gcc -Wclobbered warning that does not seem to be right.
2966 (MAXPATHLEN): Define only if needed.
2967
2968 * process.c (serial_open, serial_configure): Move decls from here ...
2969 * systty.h: ... to here, so that they can be checked.
2970
2971 * fns.c (get_random, seed_random): Move extern decls from here ...
2972 * lisp.h: ... to here, so that they can be checked.
2973
2974 * sysdep.c (reset_io): Now static.
2975 (wait_for_termination_signal): Remove; unused.
2976
2977 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2978 (copy_keymap_item, append_key, push_text_char_description):
2979 Now static.
2980 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2981 (DENSE_TABLE_SIZE): Remove; unused.
2982 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2983 (describe_map_tree):
2984 Rename locals to avoid shadowing.
2985
2986 * keyboard.c: Declare functions static if they are not used elsewhere.
2987 (echo_char, echo_dash, cmd_error, top_level_2):
2988 (poll_for_input, handle_async_input): Now static.
2989 (read_char, kbd_buffer_get_event, make_lispy_position):
2990 (make_lispy_event, make_lispy_movement, apply_modifiers):
2991 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2992 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2993 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2994 (read_key_sequence, read_char): Mark locals as initialized.
2995 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2996
2997 * keyboard.h (make_ctrl_char): New decl.
2998 (mark_kboards): Move decl here ...
2999 * alloc.c (mark_kboards): ... from here.
3000
3001 * lisp.h (force_auto_save_soon): New decl.
3002
3003 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3004 (DEFINE_DUMMY_FUNCTION): New macro.
3005 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3006 Use it.
3007 (main): Add casts to avoid warnings
3008 if GCC considers string literals to be constants.
3009
3010 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3011
3012 * dbusbind.c: Pointer signedness fixes.
3013 (xd_signature, xd_append_arg, xd_initialize):
3014 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3015 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3016 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3017 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3018
3019 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3020 if GCC considers string literals to be constants.
3021 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3022
3023 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3024
3025 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3026 (print_preprocess, print_object): New macro to fix last change.
3027
3028 * print.c (print_preprocess): Don't forget font objects.
3029
3030 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3031
3032 * emacs.c (USAGE3): Doc fixes.
3033
3034 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3035
3036 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3037 structure.
3038
3039 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3040
3041 * lisp.h (VWindow_system, Qfile_name_history):
3042 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3043 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3044 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3045
3046 * w32select.c: Don't #include "keyboard.h".
3047 (run_protected): Add extern declaration for waiting_for_input.
3048
3049 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3050 * w32console.c (detect_input_pending, read_input_pending)
3051 (encode_terminal_code):
3052 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3053 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3054 (w32_system_caret_y, Qfile_name_history):
3055 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3056 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3057 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3058 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3059 * w32proc.c (Qlocal, report_file_error):
3060 * w32term.c (Vwindow_system, updating_frame):
3061 * w32uniscribe.c (initialized, uniscribe_font_driver):
3062 Remove unneeded extern declarations.
3063
3064 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3065
3066 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3067
3068 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3069
3070 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3071 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3072 These macros can no longer be used for assignment.
3073
3074 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3075 Assign struct members directly, instead of using BUF_BEGV etc.
3076 (record_buffer_markers, fetch_buffer_markers): New functions for
3077 recording and fetching special buffer markers.
3078 (set_buffer_internal_1, set_buffer_temp): Use them.
3079
3080 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3081
3082 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3083
3084 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3085 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3086
3087 * xdisp.c (hscroll_window_tree):
3088 (reconsider_clip_changes): Use PT instead of BUF_PT.
3089
3090 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3091
3092 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3093 $(EMACS_ROOT)/lib/intprops.h.
3094
3095 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3096
3097 Fix more problems found by GCC 4.5.2's static checks.
3098
3099 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3100 to unsigned char * to avoid compiler diagnostic.
3101 (xg_free_frame_widgets): Make it clear that a local variable is
3102 needed only if USE_GTK_TOOLTIP.
3103 (gdk_window_get_screen): Make it clear that this macro is needed
3104 only if USE_GTK_TOOLTIP.
3105 (int_gtk_range_get_value): New function, which avoids a diagnostic
3106 from gcc -Wbad-function-cast.
3107 (xg_set_toolkit_scroll_bar_thumb): Use it.
3108 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3109 diagnostic from gcc -Wbad-function-cast.
3110 (get_utf8_string, xg_get_file_with_chooser):
3111 Rename locals to avoid shadowing.
3112 (create_dialog): Move locals to avoid shadowing.
3113
3114 * xgselect.c (xg_select): Remove unused var.
3115
3116 * image.c (four_corners_best): Mark locals as initialized.
3117 (gif_load): Initialize transparent_p to zero (Bug#8238).
3118 Mark another local as initialized.
3119 (my_png_error, my_error_exit): Mark with NO_RETURN.
3120
3121 * image.c (clear_image_cache): Now static.
3122 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3123 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3124 (x_edge_detection): Remove unnecessary cast that
3125 gcc -Wbad-function-cast diagnoses.
3126 (gif_load): Fix pointer signedness.
3127 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3128 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3129
3130 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3131
3132 Improve quality of tests for time stamp overflow.
3133 For example, without this patch (encode-time 0 0 0 1 1
3134 1152921504606846976) returns the obviously-bogus value (-948597
3135 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3136 reports time overflow. See
3137 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3138 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3139 * editfns.c: Include limits.h and intprops.h.
3140 (TIME_T_MIN, TIME_T_MAX): New macros.
3141 (time_overflow): Move earlier, to before first use.
3142 (hi_time, lo_time): New functions, for an accurate test for
3143 out-of-range times.
3144 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3145 (Fget_internal_run_time): Don't assume time_t fits in int.
3146 (make_time): Use list2 instead of Fcons twice.
3147 (Fdecode_time): More accurate test for out-of-range times.
3148 (check_tm_member): New function.
3149 (Fencode_time): Use it, to test for out-of-range times.
3150 (lisp_time_argument): Don't rely on undefined left-shift and
3151 right-shift behavior when checking for time stamp overflow.
3152
3153 * editfns.c (time_overflow): New function, refactoring common code.
3154 (Fformat_time_string, Fdecode_time, Fencode_time):
3155 (Fcurrent_time_string): Use it.
3156
3157 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3158 * dired.c (make_time): Move to ...
3159 * editfns.c (make_time): ... here.
3160 * systime.h: Note the move.
3161
3162 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3163
3164 * fringe.c (update_window_fringes): Remove unused variables.
3165
3166 * unexmacosx.c (copy_data_segment): Also copy __got section.
3167 (Bug#8223)
3168
3169 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3170
3171 * termcap.c [MSDOS]: Include "msdos.h".
3172 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3173 Constify `char *' arguments and their references according to
3174 prototypes in tparam.h.
3175
3176 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3177
3178 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3179 Adapt all references accordingly.
3180
3181 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3182
3183 2011-03-11 Tom Tromey <tromey@redhat.com>
3184
3185 * buffer.c (syms_of_buffer): Remove obsolete comment.
3186
3187 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3188
3189 * termhooks.h (encode_terminal_code): Declare prototype.
3190
3191 * msdos.c (encode_terminal_code): Don't declare prototype.
3192
3193 * term.c (encode_terminal_code): Now external again, used by
3194 w32console.c and msdos.c.
3195
3196 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3197 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3198
3199 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3200
3201 Fix some minor problems found by GCC 4.5.2's static checks.
3202
3203 * fringe.c (update_window_fringes): Mark locals as initialized
3204 (Bug#8227).
3205 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3206
3207 * alloc.c (mark_fringe_data): Move decl from here ...
3208 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3209 to check its interface.
3210 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3211
3212 * fontset.c (free_realized_fontset): Now static.
3213 (Fset_fontset_font): Rename local to avoid shadowing.
3214 (fontset_font): Mark local as initialized.
3215 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3216
3217 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3218
3219 * xselect.c (x_disown_buffer_selections): Remove; not used.
3220 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3221 (x_own_selection, Fx_disown_selection_internal): Rename locals
3222 to avoid shadowing.
3223 (x_handle_dnd_message): Remove local to avoid shadowing.
3224
3225 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3226 so that the caller can use some name other than gcpro1.
3227 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3228 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3229 (Fx_backspace_delete_keys_p):
3230 Use them to avoid shadowing, and rename vars to avoid shadowing.
3231 (x_decode_color, x_set_name, x_window): Now static.
3232 (Fx_create_frame): Add braces to silence GCC warning.
3233 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3234 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3235 Remove unused locals.
3236 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3237 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3238 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3239 macros.
3240
3241 * xterm.h (x_mouse_leave): New decl.
3242
3243 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3244 Remove unused functions.
3245 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3246 (x_calc_absolute_position): Now static.
3247 (XTread_socket): Don't define label "out" unless it's used.
3248 Don't declare local "event" unless it's used.
3249 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3250 unless they are used.
3251 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3252 (x_fatal_error_signal): Remove; not used.
3253 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3254 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3255 (x_error_catcher, x_connection_closed, x_error_handler):
3256 (x_error_quitter, xembed_send_message, x_iconify_frame):
3257 (my_log_handler): Rename locals to avoid shadowing.
3258 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3259 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3260
3261 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3262 Rename or move locals to avoid shadowing.
3263 (tty_defined_color, merge_face_heights): Now static.
3264 (free_realized_faces_for_fontset): Remove; not used.
3265 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3266 does not deduce is never used uninitialized.
3267 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3268 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3269
3270 * terminal.c (store_terminal_param): Now static.
3271
3272 * xmenu.c (menu_highlight_callback): Now static.
3273 (set_frame_menubar): Remove unused local.
3274 (xmenu_show): Rename parameter to avoid shadowing.
3275 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3276 since they might point to immutable storage.
3277 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3278 since it's unused otherwise.
3279
3280 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3281 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3282 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3283 avoids a gcc -Wuninitialized diagnostic.
3284 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3285 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3286 does not deduce are never used uninitialized.
3287
3288 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3289
3290 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3291 * window.c (window_loop, size_window):
3292 (run_window_configuration_change_hook, enlarge_window): Likewise.
3293
3294 * window.c (display_buffer): Now static.
3295 (size_window): Mark variables that gcc -Wuninitialized
3296 does not deduce are never used uninitialized.
3297 * window.h (check_all_windows): New decl, to forestall
3298 gcc -Wmissing-prototypes diagnostic.
3299 * dispextern.h (bidi_dump_cached_states): Likewise.
3300
3301 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3302 shadowing.
3303 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3304 Include <limits.h>.
3305 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3306 and to avoid gcc -Wuninitialized warning.
3307 (load_charset_map): Mark variables that gcc -Wuninitialized
3308 does not deduce are never used uninitialized.
3309 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3310
3311 * coding.c (coding_set_source, coding_set_destination):
3312 Use "else { /* comment */ }" rather than "else /* comment */;"
3313 for clarity, and to avoid gcc -Wempty-body warning.
3314 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3315 a block, when the outer 'i' will do.
3316 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3317 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3318 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3319 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3320 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3321 Rename locals to avoid shadowing.
3322 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3323 * coding.c (emacs_mule_char, encode_invocation_designation):
3324 Now static, since they're not used elsewhere.
3325 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3326 (decode_coding_object, encode_coding_object, detect_coding_system):
3327 (decode_coding_emacs_mule): Mark variables that gcc
3328 -Wuninitialized does not deduce are never used uninitialized.
3329 (detect_coding_iso_2022): Initialize a local variable that might
3330 be used uninitialized. Leave a FIXME because it's not clear that
3331 this initialization is needed. (Bug#8211)
3332 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3333 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3334 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3335 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3336 Remove unused macros.
3337
3338 * category.c (hash_get_category_set): Remove unused local var.
3339 (copy_category_table): Now static, since it's not used elsewhere.
3340 * character.c (string_count_byte8): Likewise.
3341
3342 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3343 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3344
3345 * chartab.c (copy_sub_char_table): Now static, since it's not used
3346 elsewhere.
3347 (sub_char_table_ref_and_range, char_table_ref_and_range):
3348 Rename locals to avoid shadowing.
3349 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3350
3351 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3352 (BIDI_BOB): Remove unused macro.
3353
3354 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3355 deduce are never used uninitialized.
3356 * term.c (encode_terminal_code): Likewise.
3357
3358 * term.c (encode_terminal_code): Now static. Remove unused local.
3359
3360 * tparam.h: New file.
3361 * term.c, tparam.h: Include it.
3362 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3363 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3364 Move these decls to tparam.h, and make them agree with what
3365 is actually in tparam.c. The previous trick of using incompatible
3366 decls in different modules does not conform to the C standard.
3367 All callers of tparam changed to use tparam's actual API.
3368 * tparam.c (tparam1, tparam, tgoto):
3369 Use const pointers where appropriate.
3370
3371 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3372 * cm.h (struct cm): Likewise.
3373 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3374 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3375 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3376 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3377 (turn_on_face, init_tty): Likewise.
3378 * termchar.h (struct tty_display_info): Likewise.
3379
3380 * term.c (term_mouse_position): Rename local to avoid shadowing.
3381
3382 * alloc.c (mark_ttys): Move decl from here ...
3383 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3384
3385 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3386
3387 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3388
3389 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3390
3391 * search.c (compile_pattern_1): Remove argument regp, unused since
3392 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3393 (compile_pattern): Don't pass it.
3394
3395 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3396
3397 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3398 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3399 for ! HAVE_GTK3.
3400 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3401
3402 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3403
3404 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3405 gdk_window_get_screen, gdk_window_get_geometry,
3406 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3407 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3408 (xg_get_pixbuf_from_pixmap): New function.
3409 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3410 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3411 Call xg_get_pixbuf_from_pixmap instead of
3412 gdk_pixbuf_get_from_drawable.
3413 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3414 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3415 (xg_check_special_colors): Use GtkStyleContext and its functions
3416 for HAVE_GTK3.
3417 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3418 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3419 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3420 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3421 Call gtk_widget_get_preferred_size.
3422 (xg_frame_resized): gdk_window_get_geometry only takes 5
3423 parameters.
3424 (xg_win_to_widget, xg_event_is_for_menubar):
3425 Call gdk_x11_window_lookup_for_display.
3426 (xg_set_widget_bg): New function.
3427 (delete_cb): New function.
3428 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3429 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3430 (xg_set_background_color): Call xg_set_widget_bg.
3431 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3432 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3433 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3434 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3435 if ! HAVE_GTK3.
3436 (update_frame_tool_bar): Call gtk_widget_hide.
3437 (xg_initialize): Use GDK_KEY_g.
3438
3439 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3440 if ! HAVE_GTK3
3441 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3442
3443 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3444 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3445 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3446
3447 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3448
3449 * w32xfns.c (select_palette): Check success of RealizePalette against
3450 GDI_ERROR, not zero.
3451
3452 See ChangeLog.11 for earlier changes.
3453
3454 ;; Local Variables:
3455 ;; coding: utf-8
3456 ;; End:
3457
3458 Copyright (C) 2011 Free Software Foundation, Inc.
3459
3460 This file is part of GNU Emacs.
3461
3462 GNU Emacs is free software: you can redistribute it and/or modify
3463 it under the terms of the GNU General Public License as published by
3464 the Free Software Foundation, either version 3 of the License, or
3465 (at your option) any later version.
3466
3467 GNU Emacs is distributed in the hope that it will be useful,
3468 but WITHOUT ANY WARRANTY; without even the implied warranty of
3469 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3470 GNU General Public License for more details.
3471
3472 You should have received a copy of the GNU General Public License
3473 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.