1 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
4 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
6 2012-08-02 Glenn Morris <rgm@gnu.org>
8 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
9 hard-coding the path separator.
11 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
13 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
14 This how ASET and AREF are supposed to work, and makes
15 it easier to think about future improvements. See
16 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
17 * charset.h (set_charset_attr): New function.
18 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
19 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
20 (aref_addr): New function. All uses of &AREF(...) changed.
21 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
22 (set_hash_index): New functions. All lvalue-style uses of
23 HASH_KEY etc. changed.
24 * keyboard.c (set_prop): New function. All lvalue-style uses
27 2012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
29 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
30 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
31 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
32 * nsfns.m (ns_set_name_as_filename): Likewise.
33 * nsmenu.m (ns_update_menubar): Likewise.
34 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
36 2012-08-01 Eli Zaretskii <eliz@gnu.org>
38 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
39 Adapt to latest changes in field names of the corresponding Lisp
42 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
44 2012-08-01 Glenn Morris <rgm@gnu.org>
46 * s/msdos.h: Remove file.
47 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
48 * Makefile.in (S_FILE): Remove.
49 (config_h): Remove S_FILE.
51 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
53 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
54 Remove; moved to nt/config.nt.
56 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
58 Use INTERNAL_FIELD for conses and overlays.
59 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
60 Remove obsolete comment.
62 (struct Lisp_Overlay): Use INTERNAL_FIELD.
63 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
65 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
67 Use INTERNAL_FIELD for symbols.
68 * lisp.h (SVAR): New macro. Adjust users.
69 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
70 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
72 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
74 Use INTERNAL_FIELD for processes.
75 * process.h (PVAR): New macro. Adjust style.
76 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
77 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
79 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
81 Use INTERNAL_FIELD for windows.
82 * window.h (WVAR): New macro.
83 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
84 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
85 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
86 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
87 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
88 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
90 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
92 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
94 2012-08-01 Glenn Morris <rgm@gnu.org>
96 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
99 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
101 * makefile.w32-in (CONFIG_H): Update dependencies.
102 (CONF_POST_H): New macro.
104 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
106 2012-07-31 Glenn Morris <rgm@gnu.org>
108 * Makefile.in (S_FILE): No longer set by configure.
110 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
112 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
114 * process.h (NULL_DEVICE):
116 * editfns.c (USER_FULL_NAME): Let configure set them.
118 * s/README, s/template.h: Remove files.
120 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
122 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
123 Move to configure.ac.
125 2012-07-31 Eli Zaretskii <eliz@gnu.org>
127 * .gdbinit (xframe): Adapt to introduction of FVAR and the
128 resulting renaming of 'struct frame' members.
130 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
132 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
133 after introduction of FVAR.
135 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
137 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
139 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
140 instead of compositeToPoint.
141 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
143 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
145 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
147 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
148 * lisp.h (INTERNAL_FIELD): New macro.
149 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
150 (BVAR): Change to use INTERNAL_FIELD.
151 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
152 (KVAR): Change to use INTERNAL_FIELD.
153 * frame.h (FVAR): New macro.
154 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
155 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
156 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
157 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
158 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
160 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
162 Miscellaneous fixes for non-default X toolkits.
163 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
164 * xterm.c (x_frame_of_widget): Remove redundant prototype.
165 Move under #ifdef USE_LUCID.
166 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
167 definition and usage to avoid warnings.
169 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
171 * nsterm.m (openFiles): Fix previous checkin.
173 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
175 * indent.c (compute_motion): Remove unused local.
177 2012-07-31 Glenn Morris <rgm@gnu.org>
179 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
181 * conf_post.h [USG5_4]:
182 Move remaining contents of s/usg5-4-common.h here.
183 * s/usg5-4-common.h: Remove file.
185 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
186 * s/irix6-5.h: Remove file.
188 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
189 * s/darwin.h: Remove file.
191 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
192 * s/hpux10-20.h: Remove file, which is now empty.
194 2012-07-30 Glenn Morris <rgm@gnu.org>
196 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
197 * Makefile.in (config_h): Add conf_post.h.
198 * makefile.w32-in (CONFIG_H): Add conf_post.h.
200 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
202 * nsterm.m (ns_do_open_file): New variable.
203 (ns_term_init): Set ns_do_open_file to YES after run returns.
204 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
205 files only if ns_do_open_file.
207 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
209 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
210 This no-op macro hasn't been needed for many years.
211 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
213 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
214 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
215 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
216 gdb_make_enums_visible.
217 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
218 (DIRECTORY_SEP): Now a constant, not a macro.
220 2012-07-30 Eli Zaretskii <eliz@gnu.org>
222 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
223 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
225 * w32term.c <w32_keyboard_codepage>: Renamed from
226 keyboard_codepage and now external. All users changed.
228 * w32term.h: Add declaration of w32_keyboard_codepage.
230 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
231 the codepage to translate keys to Unicode. If this argument is
232 -1, use the value returned by GetConsoleCP. All callers changed.
234 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
236 Update .PHONY listings in makefiles.
237 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
238 bootstrap-clean, distclean, maintainer-clean, versioclean,
241 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
242 This is a bit clearer. Fix some commentary typos.
244 2012-07-30 Glenn Morris <rgm@gnu.org>
246 * s/netbsd.h: Let configure include signal.h if needed.
247 Remove file, which is now empty.
249 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
250 Let configure set them.
251 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
252 No more need to undefine.
254 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
256 * keymap.c (Fkey_description): Don't remove 0x80 bit from
257 non-single-byte char when adding meta modifier. (Bug#12090)
259 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
261 Convert safe_call to use variable number of arguments.
262 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
263 (safe_call2): Fix comment.
264 * lisp.h (safe_call): Adjust prototype.
265 * coding.c (encode_coding_object): Change to use safe_call2.
266 * xfaces.c (merge_face_heights): Change to use safe_call1.
268 2012-07-30 Glenn Morris <rgm@gnu.org>
270 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
271 does that unconditionally. Remove file, which is now empty.
273 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
276 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
278 Export to GDB most of lisp.h's remaining object-like macros.
279 * lisp.h (min, max): Move earlier, because they're used earlier now.
280 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
281 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
282 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
283 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
284 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
285 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
286 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
287 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
288 Now constants, for GDB. They need not be macros.
289 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
290 Now constants, for GDB, as well as macros, for static initializers.
291 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
292 Move to after the definition of struct Lisp_Char_Table,
293 since the former now needs that type defined.
294 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
295 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
296 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
297 New enums, for gdb_make_enums_visible.
298 (GLYPH_MODE_LINE_FACE): Remove; unused.
299 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
300 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
301 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
302 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
303 enum maxargs, enum MAX_ALLOCA.
304 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
305 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
306 no longer needed, now that they are done in lisp.h.
308 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
310 Cleanup string bytes checking.
311 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
312 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
313 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
314 (check_sblock, compact_small_strings): Simplify.
316 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
318 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
319 These macros are confusing and no longer need to be defined, as
320 the enum values now suffice. All uses replaced with definiens.
321 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
323 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
325 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
326 ($(BLD)/w32console.$(O)): Update dependencies.
328 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
330 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
331 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
333 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
335 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
337 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
338 setting sitelisp (Bug#12010).
340 2012-07-29 Eli Zaretskii <eliz@gnu.org>
342 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
344 * w32heap.c (cache_system_info):
345 * w32.c (sys_rename):
346 * w32proc.c (find_child_console, sys_kill): All users changed.
348 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
350 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
352 2012-07-29 Eli Zaretskii <eliz@gnu.org>
354 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
356 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
358 Cleanup statistics calculation in Fgarbage_collect.
359 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
360 zombies percentage calculation. Simplify elapsed time calculation.
362 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
364 Generalize marker debugging code under MARKER_DEBUG and use eassert.
365 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
366 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
367 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
368 (replace_range, replace_range_2, del_range_2): Change to eassert.
369 * marker.c (byte_char_debug_check): Adjust style.
371 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
373 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
374 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
375 long-ago-commented-out code that talks about "WIN32".
376 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
379 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
381 Use Gnulib stdalign module (Bug#9772, Bug#9960).
382 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
383 Simplify by using alignof.
384 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
385 * lisp.h: Include <stdalign.h>.
386 (GCALIGNMENT): New macro and constant.
387 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
388 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
389 (stdalign): New macro, if not already defined.
391 2012-07-28 Eli Zaretskii <eliz@gnu.org>
393 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
394 * w32inevt.c: Include w32inevt.h.
395 (w32_read_console_input): New inline function, calls either
396 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
397 w32_console_unicode_input.
398 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
399 (w32_kbd_patch_key, key_event): Use the codepage returned by
400 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
401 (key_event): use uChar.UnicodeChar only if
402 w32_console_unicode_input is non-zero.
404 * w32console.c: Include w32heap.h.
405 <w32_console_unicode_input>: New global variable.
406 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
407 family of Windows, zero otherwise.
409 * w32inevt.h: Declare w32_console_unicode_input.
411 * xdisp.c (init_iterator): Don't reference tip_frame in a build
412 --without-x. (Bug#11742)
414 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
416 Adjust GDB to reflect pvec_type changes (Bug#12036).
417 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
418 2012-07-04 changes to pseudovector representation. Problem
419 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
421 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
423 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
425 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
427 2012-07-27 Eli Zaretskii <eliz@gnu.org>
429 * alloc.c (listn): Fix the order the arguments are consed onto the
432 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
433 enumeration constants, as PURE and HEAP are too general, and clash
434 with other headers and sources, such as gmalloc.c and the
435 MS-Windows system headers. All users changed.
437 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
439 Revert last save_excursion_save and save_excursion_restore changes.
440 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
441 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
443 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
445 Fix recently-introduced typos in Windows port.
446 Reported by Martin Rudalics <rudalics@gmx.at>.
447 * w32.c (init_environment): Replace comma with semicolon.
448 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
450 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
452 Improve GDB symbol export (Bug#12036).
453 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
454 arms of an 'if', not using conditional expressions; otherwise GDB
455 complains about the types in the unevaluated arm when the argument
456 is an integer literal.
457 (xgetint): Simplify expression.
458 * alloc.c (gdb_make_enums_visible): New constant. This ports to
459 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
460 Zaretskii in <http://bugs.gnu.org/12036#13>.
461 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
462 needed now that we have gdb_make_enums_visible.
463 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
464 (enum enum_USE_LSB_TAG):
465 New enum types, packaging up enums that need to be exported to GDB.
467 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
469 Utility function to make a list from specified amount of objects.
470 * lisp.h (enum constype): New datatype.
471 (listn): New prototype.
472 * alloc.c (listn): New function.
473 (Fmemory_use_count, syms_of_alloc): Use it.
474 * buffer.c (syms_of_buffer): Likewise.
475 * callint.c (syms_of_callint): Likewise.
476 * charset.c (define_charset_internal): Likewise.
477 * coding.c (syms_of_coding): Likewise.
478 * keymap.c (syms_of_keymap): Likewise.
479 * search.c (syms_of_search): Likewise.
480 * syntax.c (syms_of_syntax): Likewise.
481 * w32.c (init_environment): Likewise.
482 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
483 * xdisp.c (syms_of_xdisp): Likewise.
484 * xfns.c (syms_of_xfns): Likewise.
486 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
488 Fast save_excursion_save and save_excursion_restore.
489 * lisp.h (struct Lisp_Excursion): New data type.
490 (PVEC_EXCURSION): New pseudovector type.
491 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
492 to deal with it. Adjust comments.
493 (init_marker, attach_marker): New prototype.
494 (unchain_marker): Adjust prototype.
495 * marker.c (attach_marker): Change to global.
496 (init_marker): New function.
497 * alloc.c (Fmake_marker, build_marker): Use it.
498 (build_marker): More easserts.
499 (mark_object): Handle struct Lisp_Excursion.
500 * editfns.c (save_excursion_save, save_excursion_restore):
501 Reimplement to use struct Lisp_Excursion. Add comments.
503 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
505 Fix export of symbols to GDB (Bug#12036).
506 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
507 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
508 emacs.c, as this is a more-suitable home. Had this been done earlier
509 the fix for 12036 would have avoided some of the problems noted in
510 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
511 would have been more obvious.
512 * emacs.c: Do not include <verify.h>; no longer needed.
513 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
514 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
515 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
516 Remove; now done in lisp.h.
517 * lisp.h (PUBLISH_TO_GDB): New macro.
518 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
519 (DATA_SEG_BITS): Use it.
520 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
521 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
522 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
523 not be usable in #if. This simplifies things.
525 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
527 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
529 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
531 Simplify export of symbols to GDB (Bug#12036).
532 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
533 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
534 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
535 Adjust to changes in lisp.h and emacs.c, by using
536 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
537 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
538 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
539 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
540 instead of gdb_valbits.
541 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
542 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
543 instead of gdb_array_mark_flag.
544 (xboolvector): Get size from $->size, not $->header.size.
545 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
546 (xreload, hook-run, hookpost-run): Remove.
547 * emacs.c: Include <verify.h>.
548 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
549 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
551 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
552 (gdb_USE_LSB_TAG): New enum constants.
553 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
554 Also define these as enum constants, so they're visible to GDB.
555 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
556 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
557 as constants, so they're visible to GDB.
558 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
559 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
560 Now enum constants, not macros, so they're visible to GDB.
561 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
562 more convenient now. All uses changed.
563 (VALMASK) [USE_LSB_TAG]: Also define in this case.
564 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
566 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
568 Explicitly free restriction data that are not needed anymore.
569 * editfns.c (save_restriction_restore): Free restriction data.
571 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
573 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
574 add argument, tune behavior, and adjust all callers.
576 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
578 Use typedef for EMACS_INT, EMACS_UINT.
579 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
580 than macros. This simplifies debugging in the usual case, since
581 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
582 and it allows expressions involving EMACS_INT casts.
583 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
585 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
587 * nsterm.m (ns_read_socket): Return early if there is a modal
590 2012-07-25 Martin Rudalics <rudalics@gmx.at>
592 * frame.c (Fredirect_frame_focus): In doc-string don't mention
593 that FOCUS-FRAME can be omitted.
595 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
597 Adjust buffer text indirection counters at the end of Fkill_buffer.
598 * buffer.c (Fkill_buffer): Adjust indirection counters when the
599 buffer is definitely dead. This should really fix an issue reported
600 by Christoph Scholtes again. (Bug#12007).
601 (init_buffer_once): Initialize indirection counters of
602 buffer_defaults and buffer_local_symbols (for sanity and safety).
604 2012-07-24 Eli Zaretskii <eliz@gnu.org>
606 * xdisp.c (init_iterator): Don't compute dimensions of truncation
607 and continuation glyphs on tooltip frames, leave them at zero.
608 Avoids continued lines in tooltips. (Bug#11832)
610 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
612 Simplify copy_overlay.
613 * buffer.c (copy_overlay): Simplify. Use build_marker.
614 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
616 2012-07-23 Eli Zaretskii <eliz@gnu.org>
618 * print.c (print_object): Don't crash when a frame's name is nil
619 or invalid. (Bug#12025)
621 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
622 it signals an error when a tooltip frame is being created.
624 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
626 Cleanup miscellaneous objects allocation and initialization.
627 * alloc.c (allocate_misc): Change to static. Add argument to
628 specify the subtype. Adjust comment and users.
629 (build_overlay): New function.
630 * buffer.c (copy_overlays, Fmake_overlay): Use it.
631 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
632 (allocate_misc): Remove prototype.
633 (build_overlay): Add prototype.
635 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
637 Swap buffer text indirection counters in Fbuffer_swap_text.
638 * buffer.c (Fbuffer_swap_text): Swap indirections too.
639 This avoids crash reported by Christoph Scholtes at
640 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
642 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
644 * nsmenu.m (Popdown_data): New struct.
645 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
647 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
648 (initWithContentRect): Make imgView and contentView non-static
649 and autorelease them. Also autorelease img and matrix (Bug#12005).
650 (dealloc): Remove (Bug#12005).
652 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
654 Adjust consing_since_gc when objects are explicitly freed.
655 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
656 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
657 (free_cons, free_misc): Subtract object size from consing_since_gc.
659 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
661 Simplify and cleanup markers positioning code.
662 * marker.c (attach_marker): More useful eassert.
663 (live_buffer, set_marker_internal): New function.
664 (Fset_marker, set_marker_restricted): Use set_marker_internal.
665 (set_marker_both, set_marker_restricted_both): Use live_buffer.
667 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
669 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
670 as it's limited by the amount of memory, not by INT_MAX.
672 2012-07-21 Eli Zaretskii <eliz@gnu.org>
674 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
675 in special-event-map. See the discussion at
676 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
679 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
680 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
681 Fabrice Popineau <fabrice.popineau@supelec.fr>.
683 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
685 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
686 (conversationIdentifier): Return value is NSInteger.
687 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
689 2012-07-21 Chong Yidong <cyd@gnu.org>
691 * window.c (decode_any_window): Signal an error if the window is
692 on a dead frame (Bug#11984).
694 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
696 Add indirection counting to speed up Fkill_buffer.
697 * buffer.h (struct buffer): New member.
698 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
699 (Fmake_indirect_buffer): Set indirection counter to -1, increment
700 base buffer indirection counter.
701 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
702 (Fkill_buffer): Adjust indirection counters as needed, don't walk
703 through buffer list if indirection counter is 0.
705 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
707 Extend the value returned by Fgarbage_collect with heap statistics.
708 * alloc.c (Qheap): New symbol.
709 (syms_of_alloc): DEFSYM it.
710 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
711 (Fmemory_free): Remove.
712 (syms_of_alloc): Don't defsubr it.
713 * buffer.c (Fcompact_buffer): Remove.
714 (syms_of_buffer): Don't defsubr it.
716 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
718 Make maybe_gc inline.
719 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
720 * lisp.h (consing_since_gc, gc_relative_threshold)
721 (memory_full_cons_threshold): Revert declaration.
722 (maybe_gc): Remove prototype, define as inline.
723 * alloc.c: Remove old commented-out code.
724 (consing_since_gc, gc_relative_threshold)
725 (memory_full_cons_threshold): Revert to global.
728 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
730 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
731 * lisp.h (build_unibyte_string): New function.
732 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
733 * sysdep.c, w32fns.c, xfns.c: Use it.
734 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
735 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
736 Adjust users accordingly.
737 * font.h (font_open_by_name): Adjust prototype.
739 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
741 Cleanup calls to Fgarbage_collect.
742 * lisp.h (maybe_gc): New prototype.
743 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
745 * alloc.c (maybe_gc): New function.
746 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
748 * bytecode.c (MAYBE_GC): Use maybe_gc.
749 * eval.c (eval_sub, Ffuncall): Likewise.
750 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
751 to avoid dependency from auto-save feature.
753 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
755 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
756 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
757 'for_each_per_buffer_object_at'.
758 All uses changed. It's better to use upper-case for macros that
759 cannot be implemented as functions, to give the reader a clue
760 that they're special.
762 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
764 * alloc.c (Fgarbage_collect): Tweak docstring.
766 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
768 Tweak the value returned from Fgarbage_collect again.
769 * alloc.c (Fgarbage_collect): New return value, as confirmed in
770 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
771 Adjust documentation.
772 (total_vector_bytes): Rename to total_vector_slots, adjust
774 (total_free_vector_bytes): Rename to total_free_vector_slots,
776 (Qstring_bytes, Qvector_slots): New symbols.
777 (syms_of_alloc): DEFSYM them.
779 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
781 Buffer compaction primitive which may be used from Lisp.
782 * buffer.c (compact_buffer, Fcompact_buffer): New function.
783 (syms_of_buffer): Register Fcompact_buffer.
784 * alloc.c (Fgarbage_collect): Use compact_buffer.
785 * buffer.h (compact_buffer): New prototype.
786 (struct buffer_text): New member.
788 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
790 New macro to iterate over all buffers, miscellaneous cleanups.
791 * lisp.h (all_buffers): Remove declaration.
792 * buffer.h (all_buffers): Add declaration, with comment.
793 (for_each_buffer): New macro.
794 * alloc.c (Fgarbage_collect, mark_object): Use it.
795 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
796 (init_buffer): Likewise.
797 * data.c (Fset_default): Likewise.
798 * coding.c (code_conversion_restore): Remove redundant check
800 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
802 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
804 Fix bug that created negative-length intervals.
805 * intervals.c (merge_interval_right, merge_interval_left):
806 Do not zero out this interval if it is absorbed by its children,
807 as this interval's total length doesn't change in that case. See
808 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
810 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
812 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
813 when invoking (make-bool-vector N t) and N is a positive
814 multiple of 8 -- the last 8 bits were mistakenly cleared.
816 Remove some struct layout assumptions in bool vectors.
817 * alloc.c (bool_header_size): New constant.
818 (header_size, word_size): Move earlier, as they're now used earlier.
819 Use 'word_size' in a few more places, where it's appropriate.
820 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
821 padding before the data member of a bool vector.
822 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
823 than doing the check by hand with an abort ().
825 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
827 * eval.c (Fdefvar): Don't check constants since we only set the var if
828 it's not yet defined anyway (bug#11904).
830 * lisp.h (last_undo_boundary): Declare new var.
831 * keyboard.c (command_loop_1): Set it.
832 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
833 were auto-added by the command loop (bug#11774).
835 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
837 * w32font.c (Qsymbol): Remove local definition.
838 (syms_of_w32font): Don't DEFSYM it.
840 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
842 Fix sweep_vectors to handle large bool vectors correctly.
843 * alloc.c (sweep_vectors): Account total_vector_bytes for
844 bool vectors larger than VBLOCK_BYTES_MAX.
846 2012-07-18 Chong Yidong <cyd@gnu.org>
848 * frame.c (x_set_frame_parameters): Revert bogus change introduced
849 in 2012-05-25 commit by Paul Eggert (Bug#11738).
851 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
853 Return more descriptive data from Fgarbage_collect.
854 Suggested by Stefan Monnier in
855 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
856 * alloc.c (bounded_number): New function.
857 (total_buffers, total_vectors): New variable.
858 (total_string_size): Rename to total_string_bytes, adjust users.
859 (total_vector_size): Rename to total_vector_bytes, adjust users.
860 (sweep_vectors): Account total_vectors and total_vector_bytes.
861 (Fgarbage_collect): New return value. Adjust documentation.
862 (gc_sweep): Account total_buffers.
863 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
864 (VECTOR_SIZE): Remove.
865 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
866 (Qinterval, Qmisc): New symbols.
867 (syms_of_data): Initialize them.
868 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
869 (Qcons, Qbuffer): New declarations.
871 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
873 * alloc.c (Fmemory_free): Account for memory-free's own storage.
874 Round up, not down. Improve doc.
876 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
878 Restore old code in allocate_string_data to avoid Faset breakage.
879 Reported by Julien Danjou <julien@danjou.info> in
880 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
881 * alloc.c (allocate_string_data): Restore old code with minor
882 adjustments, fix comment to explain this subtle issue.
884 2012-07-17 Eli Zaretskii <eliz@gnu.org>
886 Remove FILE_SYSTEM_CASE.
887 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
889 * fileio.c (FILE_SYSTEM_CASE): Don't define.
890 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
891 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
892 call-process-region passes it through expand-file-name.
894 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
896 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
898 Fix crash when creating indirect buffer (Bug#11917)
899 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
900 Don't handle unbound variables specially if non-zero.
901 (Fbuffer_local_variables): Pass zero.
902 (clone_per_buffer_values): Pass non-zero.
904 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
906 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
907 to make the loop interruptible.
909 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
911 * gnutls.c (emacs_gnutls_handshake): Only retry if
912 GNUTLS_E_INTERRUPTED.
914 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
916 Cleanup and convert miscellaneous checks to eassert.
917 * alloc.c (mark_interval): Fix comment, partially rephrase
918 old comment from intervals.h (see below).
919 * intervals.c (find_interval, adjust_intervals_for_insertion)
920 (delete_interval, adjust_intervals_for_deletion)
921 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
923 (adjust_intervals_for_insertion, make_new_interval):
924 Remove obsolete and unused code.
925 * intervals.h (struct interval): Remove obsolete comment.
926 * textprotp.c (erase_properties): Remove unused code.
927 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
928 (Fremove_list_of_text_properties): Convert to eassert.
930 2012-07-17 Chong Yidong <cyd@gnu.org>
932 * editfns.c (Finsert_char): Doc fix.
934 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
936 Fix previous change to make Fmemory_free always accurate.
937 * alloc.c (make_interval): Update total_free_intervals.
938 (make_float): Likewise for total_free_floats.
939 (free_cons, Fcons): Likewise for total_free_conses.
940 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
941 Likewise for total_free_vector_bytes.
942 (Fmake_symbol): Likewise for total_free_symbols.
943 (bytes_free): Remove.
945 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
947 Simple free memory accounting feature.
948 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
949 (sweep_vectors): Accumulate size of free vectors.
950 (Fgarbage_collect): Setup bytes_free.
951 (Fmemory_free): New function.
952 (syms_of_alloc): Register it.
954 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
956 Cleanup overlays checking.
957 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
958 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
959 eassert and OVERLAYP.
960 (sort_overlays): Change to use OVERLAYP.
962 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
964 * editfns.c (Finsert_char): Make it interactive, and make the
965 second arg optional. Copy interactive spec and docstring from
968 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
970 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
971 Unlike the other wrapped functions, fabs has an unspecified
974 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
976 * nsterm.m (keyDown): Interpret flags without left/right bits
977 as the left key (Bug#11670).
979 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
981 Remove empty and useless init functions.
982 * lisp.h (init_character_once, init_fns, init_image)
983 (init_filelock, init_sound): Remove prototype.
984 * character.c (init_character_once): Remove.
985 * filelock.c (init_filelock): Likewise.
986 * fns.c (init_fns): Likewise.
987 * image.c (init_image): Likewise.
988 * sound.c (init_sound): Likewise.
989 * emacs.c (main): Adjust accordingly.
991 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
993 * gtkutil.h: Tiny cleanups.
994 (use_old_gtk_file_dialog): Remove useless declaration.
995 (xg_uses_old_file_dialog): Add suggested const attribute.
997 2012-07-15 Eli Zaretskii <eliz@gnu.org>
999 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1000 (bidi_paragraph_init): Use it to limit search forward for a strong
1001 directional character in abnormally large paragraphs full of
1002 neutral or weak characters. (Bug#11943)
1004 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1006 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1007 the toolbar (Bug#9451).
1008 (xg_make_tool_item): Give the widget event box a transparent
1011 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1013 Cleanup basic allocation variables and functions.
1014 * alloc.c (ignore_warnings, init_intervals, init_float)
1015 (init_cons, init_symbol, init_marker): Remove.
1016 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1017 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1018 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1019 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1020 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1021 (staticidx, init_alloc_once, init_strings, free_ablock):
1022 Remove redundant initialization.
1023 * fns.c (init_weak_hash_tables): Remove.
1024 * lisp.h (init_weak_hash_tables): Remove prototype.
1026 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1028 Use zero_vector where appropriate.
1029 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1031 * lisp.h (zero_vector): New declaration.
1032 * font.c (null_vector): Remove.
1033 (syms_of_font): Remove initialization and staticpro.
1034 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1035 * keymap.c (Faccessible_keymaps): Likewise.
1037 2012-07-15 Leo Liu <sdl.web@gmail.com>
1039 * fringe.c: Fix typo in comments.
1041 2012-07-14 Leo Liu <sdl.web@gmail.com>
1043 * fringe.c: Add a new bitmap exclamation-mark.
1045 2012-07-14 Eli Zaretskii <eliz@gnu.org>
1047 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1049 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1050 (HAVE_MENUS): Don't define, defined by editing config.in with
1052 (GMALLOC_INHIBIT_VALLOC): Don't define.
1053 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1055 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
1057 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1059 2012-07-14 Glenn Morris <rgm@gnu.org>
1061 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1062 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1063 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1065 2012-07-13 Glenn Morris <rgm@gnu.org>
1067 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1069 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1070 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1072 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1074 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1075 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1076 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1077 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1079 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1080 as boolean expression.
1081 (x_set_window_size): Remove unused variable toolbar.
1082 (ns_get_color_default, ns_mod_to_lisp): Remove.
1083 (ns_mouse_position): Remove unused variables xchar and ychar.
1084 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1085 (ns_set_vertical_scroll_bar): Remove unused variable count.
1086 (ns_delete_terminal): Remove unused variable i.
1087 (ns_term_init): Remove unused variables r, g and b.
1088 (mouseDown): Remove unused variable window.
1089 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1090 (initFrameFromEmacs): Remove unused variable vbextra.
1091 (mouseEntered): Remove unused variables p and dpyinfo.
1092 (mouseExited): Remove unused variables p and r.
1093 (ns_define_frame_cursor, ns_clear_frame_area)
1094 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1095 (menuDown): Assign [sender tag] to variable and cast the variable.
1097 * nsterm.h (menuDown): Add id as type to argument sender.
1098 (ns_display_info_for_name): Add Lisp_Object argument.
1099 (ns_term_init): Add Lisp_Object argument.
1100 (ns_map_event_to_object): Add void argument.
1101 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1102 prototype with arguments and only declare if __OBJC__.
1103 (nxatoms_of_nsselect): Add void argument.
1104 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1105 (ns_alloc_autorelease_pool): Add void argument.
1106 (ns_release_autorelease_pool): Add void* argument.
1107 (ns_get_defaults_value): Add const char* argument.
1109 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1110 (initFromContents): Use SSDATA where appropriate.
1111 (ns_update_menubar): Add braces to ambigous if-else.
1112 (initWithTitle): Put () around assignment in if statement.
1113 (ns_menu_show): Remove unused variables window and keymap.
1114 (update_frame_tool_bar): Remove unused variable selected_p.
1115 (initWithContentRect): Remove unused variable this_cmd_name.
1117 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1119 (setXBMColor): Remove unused variable len.
1120 (setPixmapData): Put () around assignment in loop statement.
1122 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1123 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1125 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1126 around assignment in loop statement.
1127 (nsfont_open): Remove unused variable i.
1128 (nsfont_open): Remove unused variable len.
1129 (nsfont_draw): Remove unused variable cs.
1131 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1132 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1133 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1134 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1135 (Fns_font_name, Fns_perform_service)
1136 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1137 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1138 (ns_set_name): Remove unused variable view.
1139 (x_set_menu_bar_lines): Remove unused variable olines.
1140 (x_set_tool_bar_lines): Remove unused variable root_window.
1141 (Fns_list_colors): Put () around assignment in while statement.
1142 (Fns_perform_service): Remove unused variable len.
1143 (Fns_display_usable_bounds): Remove unused variable top.
1144 (syms_of_nsfns): Remove unused variable i.
1146 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1149 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
1151 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1152 and free it with DestroyExceptionInfo (Bug#11558).
1154 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
1156 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1157 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1158 Set here, not in nt/config.nt.
1160 2012-07-13 Eli Zaretskii <eliz@gnu.org>
1162 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1163 cursor overflow into the last glyph on display line when the right
1164 fringe is off. (Bug#11832)
1166 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1168 * xdisp.c (produce_special_glyphs): Now static.
1169 * dispextern.h (produce_special_glyphs): Remove decl.
1171 2012-07-13 Glenn Morris <rgm@gnu.org>
1173 * s/bsd-common.h, s/cygwin.h: Remove empty files.
1174 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1176 * s/usg5-4-common.h (USG, USG5):
1177 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1178 * s/sol2-6.h (SOLARIS2):
1179 * s/irix6-5.h (IRIX6_5):
1180 * s/hpux10-20.h (USG, USG5, HPUX):
1181 * s/gnu-linux.h (USG, GNU_LINUX):
1182 * s/freebsd.h (BSD_SYSTEM):
1183 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1184 * s/cygwin.h (CYGWIN):
1185 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1186 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1188 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1190 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1192 2012-07-13 Glenn Morris <rgm@gnu.org>
1194 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1196 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1198 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1199 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1201 2012-07-12 Glenn Morris <rgm@gnu.org>
1203 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1205 * process.c (init_process_emacs): Rename from init_process.
1206 The old name is also the name of a Mach system call.
1207 * lisp.h, emacs.c: Update for this name change.
1208 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1211 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1213 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1214 memmove call that removes glyphs covered by the left truncation
1215 glyph. Improve commentary.
1216 (display_line): Fix display of continuation glyphs on GUI frames
1217 when the right fringe is turned off and variable-size fonts are
1218 used in the window. Move the code that appends a stretch glyph to
1219 produce_special_glyphs, so that it could be used for truncation
1220 and continuation glyphs alike.
1221 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1222 glyph of a suitably computed width, to align the special glyphs at
1223 the window margin. Code moved from display_line. (Bug#11832)
1225 2012-07-12 Glenn Morris <rgm@gnu.org>
1227 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1229 * s/gnu-linux.h, s/hpux10-20.h:
1230 Do not unconditionally define HAVE_XRMSETDATABASE.
1232 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1234 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1236 Fix typos that broke OS X build.
1237 Reported by Randal L. Schwartz in
1238 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1239 * nsterm.m (ns_timeout): Add missing local decl.
1240 (ns_get_color): snprintf -> sprintf, to fix typo.
1242 2012-07-12 Glenn Morris <rgm@gnu.org>
1244 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1245 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1246 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1247 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1249 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1250 Move PTY_OPEN to configure.
1252 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1253 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1254 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1256 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1258 Use empty_unibyte_string where applicable.
1259 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1260 * lread.c (read1): Likewise.
1261 * xsettings.c (syms_of_xsettings): Likewise.
1263 2012-07-12 Glenn Morris <rgm@gnu.org>
1265 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1266 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1267 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1268 * s/hpux10-20.h (RUN_TIME_REMAP):
1269 * s/bsd-common.h (TABDLY): Move to configure.
1271 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1273 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1275 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1276 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1278 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1280 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1281 * s/template.h: Move NARROWPROTO to configure.
1283 2012-07-11 Glenn Morris <rgm@gnu.org>
1285 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1286 unused since 2011-01-17 change to systty.h.
1288 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1289 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1290 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1292 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1294 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1296 2012-07-11 Glenn Morris <rgm@gnu.org>
1298 * s/darwin.h, s/gnu-linux.h, s/template.h:
1299 Move INTERRUPT_INPUT to configure.
1301 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1303 Minor adjustments to interning code.
1304 * lisp.h (intern, intern_c_string): Redefine as static inline
1305 wrappers for intern_1 and intern_c_string_1, respectively.
1306 (intern_1, intern_c_string_1): Rename prototypes.
1307 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1309 * font.c (font_intern_prop): Likewise. Adjust comment.
1310 * w32font.c (intern_font_name): Likewise.
1312 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1314 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1316 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1317 of Fcar/Fcdr if possible.
1318 * font.c (check_otf_features): Likewise.
1319 * fontset.c (Fnew_fontset): Likewise.
1320 * gnutls.c (Fgnutls_boot): Likewise.
1321 * minibuf.c (read_minibuf): Likewise.
1322 * msdos.c (IT_set_frame_parameters): Likewise.
1323 * xmenu.c (Fx_popup_dialog): Likewise.
1324 * w32menu.c (Fx_popup_dialog): Likewise.
1326 2012-07-11 Glenn Morris <rgm@gnu.org>
1328 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1329 since nothing has defined it on these platforms.
1331 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1332 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1334 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1335 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1336 Move CLASH_DETECTION to configure.
1338 * s/gnu.h: Remove file, which is now empty.
1340 * s/gnu.h, s/gnu-linux.h:
1341 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1343 2012-07-11 John Wiegley <johnw@newartisans.com>
1345 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1346 function attribute, so we only use it if it exists in the
1349 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1351 Avoid call to strlen in fast_c_string_match_ignore_case.
1352 * search.c (fast_c_string_match_ignore_case): Change to use
1353 length argument. Adjust users accordingly.
1354 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1356 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1358 Assume mkdir, rmdir.
1359 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1360 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1363 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1366 * s/hpux10-20.h (HAVE_PERROR): Remove.
1367 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1368 Remove dummy definition, as this problem was obsolete long ago.
1371 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1373 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1375 Avoid calls to strlen in font processing functions.
1376 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1377 (font_open_by_name): Change to use length argument. Adjust
1379 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1381 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1382 Change to return ptrdiff_t.
1383 (xfont_list_pattern, xfont_match): Use length returned by
1384 xfont_decode_coding_xlfd.
1385 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1387 2012-07-11 Glenn Morris <rgm@gnu.org>
1389 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1390 Move DONT_REOPEN_PTY to configure.
1392 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1393 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1395 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1397 Remove "#define unix" that is no longer needed (Bug#11905).
1398 * s/aix4-2.h (unix): Remove; no longer needed.
1400 EMACS_TIME simplification (Bug#11875).
1401 This replaces macros (which typically do not work in GDB)
1402 with functions, typedefs and enums, making the code easier to debug.
1403 The functional style also makes code easier to read and maintain.
1404 * systime.h: Include <sys/time.h> on all hosts, not just if
1405 WINDOWSNT, since 'struct timeval' is needed in general.
1406 (EMACS_TIME): Now a typedef, not a macro.
1407 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1409 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1410 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1411 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1412 (EMACS_TIME_LE): Now functions, not macros.
1413 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1414 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1415 which are not functions. All uses rewritten to use:
1416 (make_emacs_time): New function.
1417 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1418 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1419 not functions. All uses rewritten to use the following, respectively:
1420 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1421 (add_emacs_time, sub_emacs_time): New functions.
1422 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1423 * fileio.c (Fcopy_file):
1424 * xterm.c (XTflash): Get the current time closer to when it's used.
1425 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1427 * bytecode.c (targets): Suppress -Woverride-init warnings.
1429 Simplify by avoiding confusing use of strncpy etc.
1430 * doc.c (Fsnarf_documentation):
1431 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1432 * frame.c (Fmake_terminal_frame):
1433 * gtkutil.c (get_utf8_string):
1435 * nsmenu.m (ns_update_menubar):
1436 * regex.c (regerror):
1437 Prefer memcpy to strncpy and strncat when either will do.
1438 * fileio.c (Fsubstitute_in_file_name):
1439 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1440 (menu_separator_name_p):
1441 * nsmenu.m (ns_update_menubar):
1442 Prefer memcmp to strncmp when either will do.
1443 * nsterm.m: Include <ftoastr.h>.
1445 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1446 Prefer snprintf to strncpy.
1447 * nsterm.m (ns_term_init):
1448 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1449 * nsterm.m (ns_term_init):
1450 Avoid the need for strncpy, by using build_string or
1451 make_unibyte_string directly. Use dtoastr, not snprintf.
1452 * process.c (Fmake_network_process): Diagnose service names that
1453 are too long, rather than silently truncating them or creating
1454 non-null-terminated names.
1455 (Fnetwork_interface_info): Likewise, for interface names.
1456 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1457 Prefer sprintf to strncat.
1458 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1459 Prefer vsnprintf to vsprintf + strncpy.
1461 2012-07-10 Glenn Morris <rgm@gnu.org>
1463 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1464 Clarify fallback case.
1466 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1468 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1469 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1470 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1471 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1472 where argument type is known to be a Lisp_Cons.
1474 2012-07-10 Tom Tromey <tromey@redhat.com>
1476 * bytecode.c (BYTE_CODE_THREADED): New macro.
1477 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1478 (enum byte_code_op): New type.
1479 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1480 (exec_byte_code): Use them. Use token threading when applicable.
1482 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1484 Optimize pure C strings initialization.
1485 * lisp.h (make_pure_string): Fix prototype.
1486 (build_pure_c_string): New function, defined as static inline. This
1487 provides a better opportunity to optimize away calls to strlen when
1488 the function is called with compile-time constant argument.
1489 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1490 argument, adjust users accordingly. Use build_pure_c_string where
1492 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1493 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1494 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1496 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1498 Avoid calls to strlen in miscellaneous functions.
1499 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1500 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1501 * lread.c (openp): Likewise.
1503 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1505 Avoid calls to strlen in path processing functions.
1506 * fileio.c (file_name_as_directory): Add comment. Change to add
1507 srclen argument and return the length of result. Adjust users
1509 (directory_file_name): Fix comment. Change to add srclen argument,
1510 swap 1st and 2nd arguments to obey the common convention. Adjust
1512 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1514 2012-07-10 Glenn Morris <rgm@gnu.org>
1516 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1517 Move PENDING_OUTPUT_COUNT definition to configure.
1519 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1520 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1521 * s/gnu.h (DATA_START): Move definitions to configure.
1523 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1524 We include usg5-4-common.h, which defines them both.
1526 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1527 O_RDONLY already includes it).
1529 Stop ns builds setting the EMACSLOADPATH environment variable.
1530 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1531 Now it does not set EMACSLOADPATH, just returns the load-path string.
1532 * nsterm.h: Update accordingly.
1533 * lread.c [HAVE_NS]: Include nsterm.h.
1534 (init_lread) [HAVE_NS]: Use ns_load_path.
1535 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1537 2012-07-09 Glenn Morris <rgm@gnu.org>
1539 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1540 since the included bsd-common.h does so.
1542 Stop ns builds setting the EMACSPATH environment variable.
1543 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1544 (ns_init_paths): Do not set EMACSPATH.
1545 * nsterm.h (ns_exec_path): Add it.
1546 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1549 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1551 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1553 * process.c (wait_reading_process_output): 'waitchannels' was unset
1554 when read_kbd || !NILP (wait_for_cell); fix this.
1556 Add GCC-style 'const' attribute to functions that can use it.
1557 * character.h (char_resolve_modifier_mask):
1558 * keyboard.h (make_ctrl_char):
1559 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1560 (init_character_once, next_almost_prime, init_fns, init_image)
1561 (flush_pending_output, init_sound):
1562 * mem-limits.h (start_of_data):
1563 * menu.h (finish_menu_items):
1564 Add ATTRIBUTE_CONST.
1565 * emacs.c (DEFINE_DUMMY_FUNCTION):
1566 Declare the dummy function with ATTRIBUTE_CONST.
1567 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1568 Add decls with ATTRIBUTE_CONST.
1570 Minor improvements to make_formatted_string.
1571 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1572 where int is good enough, as vsprintf returns an int.
1573 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1575 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1577 Use make_formatted_string to avoid double length calculation.
1578 * lisp.h (make_formatted_string): New prototype.
1579 * alloc.c (make_formatted_string): New function.
1580 * buffer.c (Fgenerate_new_buffer_name): Use it.
1581 * dbus.c (syms_of_dbusbind): Likewise.
1582 * editfns.c (Fcurrent_time_zone): Likewise.
1583 * filelock.c (get_boot_time): Likewise.
1584 * frame.c (make_terminal_frame, set_term_frame_name)
1585 (x_report_frame_params): Likewise.
1586 * image.c (gs_load): Likewise.
1587 * minibuf.c (get_minibuffer): Likewise.
1588 * msdos.c (dos_set_window_size): Likewise.
1589 * process.c (make_process): Likewise.
1590 * xdisp.c (ensure_echo_area_buffers): Likewise.
1591 * xsettings.c (apply_xft_settings): Likewise.
1593 2012-07-09 Glenn Morris <rgm@gnu.org>
1595 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1596 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1597 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1598 * nsterm.h (ns_etc_directory): Add it.
1599 * callproc.c [HAVE_NS]: Include nsterm.h.
1600 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1602 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1604 Move marker debugging code under MARKER_DEBUG.
1605 * marker.c (MARKER_DEBUG): Move marker debugging code under
1606 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1607 for bootstrap with --enable-checking (~3x slowdown reported
1608 by Juanma Barranquero <lekktu@gmail.com>).
1609 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1611 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1613 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1614 See <http://bugs.gnu.org/11825#29>.
1616 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1618 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1619 has no font, use the frame's font. (Bug#11813)
1620 (display_line): Add commentary about displaying truncation glyphs
1622 (produce_special_glyphs): Move here from term.c.
1624 * term.c (produce_special_glyphs): Move to xdisp.c.
1626 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1629 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1631 * xdisp.c (display_line): Avoid warning about implicit declaration
1634 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1636 * lisp.h: Remove empty conditional.
1638 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1640 * lread.c (load_path_check): Now static.
1642 Fix some minor --with-ns problems found by static checking.
1643 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1644 (x_set_font) [!HAVE_X_WINDOWS]:
1645 * image.c (xpm_load_image) [HAVE_NS]:
1646 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1647 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1648 Remove unused local.
1649 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1650 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1651 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1652 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1653 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1654 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1655 Fix pointer signedness problem.
1656 * xfaces.c (FRAME_X_FONT_TABLE):
1657 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1659 2012-07-07 Glenn Morris <rgm@gnu.org>
1661 * lread.c (load_path_check): New function, split from init_lread.
1662 (init_lread): Reorganize. Motivation:
1663 If EMACSLOADPATH is set, check/warn about that rather than the
1664 defaults, which we are not going to use. Hence we can remove
1665 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1666 Don't warn if site-lisp directories are missing.
1667 If not installed, start from a blank load-path, since
1668 PATH_LOADSEARCH refers to the eventual installation directories.
1670 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1672 Support truncation and continuation glyphs on GUI frames, when
1673 fringes are disabled. (Bug#11832)
1674 * xdisp.c (init_iterator): Get dimensions of truncation and
1675 continuation glyphs even if on GUI frames. Adjust
1676 it->last_visible_x on GUI frames when the left or right fringes,
1677 or both, are absent.
1678 (start_display, move_it_in_display_line_to): Handle the case of a
1679 GUI frame without a fringe to display continuation or truncation
1681 (insert_left_trunc_glyphs): Support GUI frames: make sure
1682 truncation glyphs overwrite enough glyphs from the current line to
1683 have sufficient space in pixels.
1684 (display_line): Support truncation and continuation glyphs on GUI
1685 frames. If some spare pixels are left on the line after inserting
1686 the truncation glyphs, fill that space with a stretch glyph of a
1687 suitably computed width.
1689 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1690 produce_glyphs, to support GUI sessions.
1692 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1694 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1696 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1698 Do not require float-time's arg to fit in time_t (Bug#11825).
1699 This works better on hosts where time_t is unsigned, and where
1700 float-time is applied to the (negative) difference between two times.
1701 * editfns.c (decode_time_components): Last arg is now double *,
1702 not int *, and means to store all the result as a double, without
1703 worrying about whether the seconds part fits in time_t.
1704 All callers changed.
1705 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1706 All callers changed.
1707 (Ffloat_time): Do not fail merely because the specified time falls
1708 outside of time_t range.
1710 2012-07-07 Glenn Morris <rgm@gnu.org>
1712 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1713 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1714 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1716 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1718 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1719 Update dependencies.
1721 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1723 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1725 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1726 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1727 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1728 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1729 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1730 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1732 * xfont.c (compare_font_names): Redo to omit the need for casts.
1734 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1736 * xfns.c (Fx_change_window_property): Doc fix.
1737 * w32fns.c (Fx_change_window_property): Doc fix.
1739 * w32fns.c (Fx_window_property): Accept the same arguments as the
1740 X Windows version. Doc fix.
1741 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1743 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1744 Eli Zaretskii <eliz@gnu.org>
1746 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1747 Windows-specific code from nt/config.nt moved here.
1748 Obsolete settings removed.
1750 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1752 * process.c: Avoid unnecessary calls to gettime.
1753 (wait_reading_process_output): Don't get the time of day
1754 when gobbling data immediately and not waiting, as there's no need
1755 for it in that case. This removes a FIXME.
1757 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1759 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1760 is defined (Bug#11768).
1762 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1764 Fix marker debugging code.
1765 * marker.c (byte_char_debug_check): Do not perform the check
1766 if buffer is not multibyte.
1767 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1768 Call byte_char_debug_check with correct arguments.
1770 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1772 Compile marker debugging code only if ENABLE_CHECKING is defined.
1773 * marker.c (byte_char_debug_check, count_markers):
1774 Use only if ENABLE_CHECKING is defined.
1775 (byte_debug_flag): Remove.
1776 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1777 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1779 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1781 Avoid code repetition in marker-related functions.
1782 * marker.c (attach_marker): New function.
1783 (Fset_marker, set_marker_restricted, set_marker_both)
1784 (set_marker_restricted_both): Use it.
1785 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1786 Consistently rename charno to charpos.
1787 (marker_position): Add eassert.
1788 (marker_byte_position): Convert to eassert.
1790 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1792 Simplify list operations in unchain_overlay and unchain_marker.
1793 * buffer.c (unchain_overlay): Simplify. Add comment.
1794 * marker.c (unchain_marker): Simplify. Fix comments.
1796 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1798 Introduce fast path for the widely used marker operation.
1799 * alloc.c (build_marker): New function.
1800 * lisp.h (build_marker): New prototype.
1801 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1802 * composite.c (autocmp_chars): Likewise.
1803 * editfns.c (buildmark): Remove.
1804 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1805 (save_restriction_save): Use build_marker.
1806 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1807 * window.c (save_window_save): Likewise.
1809 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1811 Do not use Fdelete_overlay in delete_all_overlays
1812 to avoid redundant calls to unchain_overlay.
1813 * buffer.c (drop_overlay): New function.
1814 (delete_all_overlays, Fdelete_overlay): Use it.
1815 * minibuf.c (get_minibuffer): Fix comment.
1817 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1819 Port to OpenBSD 5.1 amd64.
1820 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1821 This is needed for OpenBSD, and should be harmless on all BSD systems.
1822 Also, include <sys/sysctl.h>, as it should be available on all
1823 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1824 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1825 use p_pid member, not kp_proc.pid.
1827 2012-07-06 Glenn Morris <rgm@gnu.org>
1829 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1831 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1833 More xmalloc and related cleanup.
1834 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1835 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1836 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1837 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1838 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1839 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1840 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1841 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1842 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1844 Omit needless casts involving void * pointers and allocation.
1845 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1846 as the former is more robust if P's type is changed.
1847 Prefer xzalloc to xmalloc + memset 0.
1848 Simplify malloc-or-realloc to realloc.
1849 Don't worry about xmalloc returning a null pointer.
1850 Prefer xstrdup to xmalloc + strcpy.
1851 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1853 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1854 alloca of a constant.
1856 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1858 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1859 hscroll is larger than the line width. Fixes long and futile
1860 looping inside extend_face_to_end_of_line (on a TTY) producing
1861 glyphs that are not needed and thrown away.
1863 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1865 * marker.c (set_marker_restricted_both): Simplify by using
1868 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1870 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1872 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1874 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1875 not defined (Bug#11768).
1876 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1877 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1878 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1879 followed by gtk_box_set_homogeneous (Bug#11768).
1880 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1881 (update_theme_scrollbar_width, xg_create_scroll_bar):
1882 Use gtk_scrollbar_new (Bug#11768).
1883 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1884 (is_box_type): New function (Bug#11768).
1885 (xg_tool_item_stale_p): Call is_box_type.
1886 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1887 with default display (Bug#11768).
1889 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1891 * xdisp.c (window_hscroll_limited): New function.
1892 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1893 coordinates when window's hscroll is set to insanely large
1896 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1898 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1899 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1901 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1904 * lisp.h (xzalloc): New prototype. Omit needless casts.
1905 * alloc.c (xzalloc): New function. Omit needless casts.
1906 * charset.c: Omit needless casts. Convert all calls to
1907 xmalloc with following memset to xzalloc.
1908 * dispnew.c: Likewise.
1909 * fringe.c: Likewise.
1910 * image.c: Likewise.
1911 * sound.c: Likewise.
1913 * w32fns.c: Likewise.
1914 * w32font.c: Likewise.
1915 * w32term.c: Likewise.
1916 * xfaces.c: Likewise.
1918 * xterm.c: Likewise.
1919 * atimer.c: Omit needless casts.
1920 * buffer.c: Likewise.
1921 * callproc.c: Likewise.
1923 * coding.c: Likewise.
1924 * composite.c: Likewise.
1926 * doprnt.c: Likewise.
1927 * editfns.c: Likewise.
1928 * emacs.c: Likewise.
1930 * filelock.c: Likewise.
1932 * gtkutil.c: Likewise.
1933 * keyboard.c: Likewise.
1935 * lread.c: Likewise.
1936 * minibuf.c: Likewise.
1937 * msdos.c: Likewise.
1938 * print.c: Likewise.
1939 * process.c: Likewise.
1940 * region-cache.c: Likewise.
1941 * search.c: Likewise.
1942 * sysdep.c: Likewise.
1943 * termcap.c: Likewise.
1944 * terminal.c: Likewise.
1945 * tparam.c: Likewise.
1946 * w16select.c: Likewise.
1948 * w32reg.c: Likewise.
1949 * w32select.c: Likewise.
1950 * w32uniscribe.c: Likewise.
1951 * widget.c: Likewise.
1952 * xdisp.c: Likewise.
1953 * xmenu.c: Likewise.
1955 * xselect.c: Likewise.
1957 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1959 * fileio.c (time_error_value): Check the right error number.
1960 Problem reported by Troels Nielsen in
1961 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1963 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1965 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1966 This should be fixed in a better way; see Eli Zaretskii in
1967 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1968 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1970 * fileio.c (time_error_value): Rename from special_mtime.
1971 The old name's problems were noted by Eli Zaretskii in
1972 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1974 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1975 This variable's comment says Emacs needs at least one GDB-visible
1976 symbol of type enum pvec_type, to work around GDB problems.
1977 The symbol's value doesn't matter.
1979 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1980 that causes compilation to fail on pre-C99 compilers.
1982 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1984 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1985 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1987 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1989 * buffer.c (init_buffer_once): Fix initialization of
1990 headers for buffer_defaults and buffer_local_symbols.
1991 Reported by Juanma Barranquero <lekktu@gmail.com>.
1993 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1995 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1996 * lisp.h (enum pvec_type): Use fewer bits.
1997 (PSEUDOVECTOR_SIZE_BITS): New constant.
1998 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1999 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2000 change in pvec_type.
2001 (PSEUDOVECTOR_TYPEP): New macro.
2002 (TYPED_PSEUDOVECTORP): Use it.
2003 * fns.c (internal_equal): Adapt code to extract pvectype.
2004 * emacs.c (gdb_pvec_type): Update type.
2005 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2006 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2007 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2008 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2009 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2010 abusing vector->header.next.nbytes.
2011 (live_vector_p): Use PVEC_TYPE.
2012 (mark_object): Adapt code to extract pvectype. Use switch.
2014 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2016 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2017 Tighten new eassert a bit.
2019 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2021 Fix compilation with --enable-gcc-warnings and -O1
2023 * doprnt.c (doprnt): Change type of tem to int, initialize
2024 to avoid compiler warning. Add eassert.
2025 * search.c (simple_search): Initialize match_byte to avoid
2026 compiler warning. Add eassert.
2028 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2030 Avoid weird behavior with large horizontal scrolls.
2031 Without this change, for example, large hscroll values would
2032 mess up Emacs's display on Fedora 15 x86, presumably due to
2033 overflows in int calculations in the display code.
2034 Also, if buffers had long lines, Emacs would freeze.
2035 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2036 (set_window_hscroll): New function, containing the old guts of
2037 Fset_window_hscroll. Return the clipped value.
2038 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2039 This avoids the need to check against PTRDIFF_MAX.
2041 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2043 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2045 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2047 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2049 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2050 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2051 since GCC 4.4.6 issues a bogus warning for them.
2053 Fix bugs in file timestamp newness comparisons.
2054 * fileio.c (Ffile_newer_than_file_p):
2055 * lread.c (Fload): Use full timestamp resolution of files,
2056 not just the 1-second resolution, so that files that are only
2057 slightly newer still count as newer.
2058 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2059 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2061 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2063 * fileio.c: Improve handling of file time marker. (Bug#11852)
2064 (special_mtime): New function.
2065 (Finsert_file_contents, Fverify_visited_file_modtime):
2066 Use it to set special mtime values consistently.
2068 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2070 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2071 marker for non-existing file. (Bug#11852)
2073 2012-07-03 Glenn Morris <rgm@gnu.org>
2075 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2076 and did not make it into globals.h).
2078 2012-07-03 Tom Tromey <tromey@redhat.com>
2080 * window.c (Fset_window_margins, Fset_window_fringes)
2081 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2082 * textprop.c (Fprevious_property_change): No longer static.
2083 * syntax.c (Fsyntax_table_p): No longer static.
2084 * process.c (Fget_process, Fprocess_datagram_address): No longer
2086 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2087 * keyboard.c (Fcommand_execute): No longer static.
2089 * insdel.c (Fcombine_after_change_execute): No longer static.
2090 * image.c (Finit_image_library): No longer static.
2091 * fileio.c (Fmake_symbolic_link): No longer static.
2092 * eval.c (Ffetch_bytecode): No longer static.
2093 * editfns.c (Fuser_full_name): No longer static.
2094 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2096 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2098 * dired.c (Ffile_attributes): No longer static.
2099 * composite.c (Fcomposition_get_gstring): No longer static.
2100 * callproc.c (Fgetenv_internal): No longer static.
2102 * ccl.h: Remove EXFUNs.
2103 * buffer.h: Remove EXFUNs.
2104 * dispextern.h: Remove EXFUNs.
2105 * intervals.h: Remove EXFUNs.
2106 * fontset.h: Remove EXFUN.
2107 * font.h: Remove EXFUNs.
2108 * dosfns.c (system_process_attributes): Remove EXFUN.
2109 * keymap.h: Remove EXFUNs.
2110 * lisp.h: Remove EXFUNs.
2111 * w32term.h: Remove EXFUNs.
2112 * window.h: Remove EXFUNs.
2113 * xsettings.h: Remove EXFUN.
2114 * xterm.h: Remove EXFUN.
2116 2012-07-03 Glenn Morris <rgm@gnu.org>
2118 * lisp.h (Frandom): Make it visible to C.
2119 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2120 buffer for invisible buffers. (Bug#1229)
2122 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2124 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2125 values which aren't power of 2.
2126 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2127 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2130 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2132 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2134 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2136 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2138 * alloc.c (allocate_vector_block): Remove redundant
2139 calls to mallopt if DOUG_LEA_MALLOC is defined.
2140 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2141 avoid calls to mallopt if zero_vector is returned.
2143 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2145 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2146 is enabled, avoid dereferencing NULL current_sblock if
2149 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2151 Cleanup basic buffer management.
2152 * buffer.h (struct buffer): Change layout to use generic vector
2153 marking code. Fix some comments. Change type of 'clip_changed'
2154 to bitfield. Remove unused #ifndef old.
2155 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2156 (GET_OVERLAYS_AT): Fix indentation.
2157 (for_each_per_buffer_object_at): New macro.
2158 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2159 (Fbuffer_local_variables): Use it.
2160 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2161 * alloc.c (allocate_buffer): Adjust to match new layout of
2162 struct buffer. Fix comment.
2163 (mark_overlay): New function.
2164 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2165 Lisp area of struct buffer.
2166 (mark_object): Use it. Adjust marking of misc objects
2167 and related comments.
2169 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2171 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2172 wrapper that is not needed because the wrapped code is a no-op (zero
2173 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2174 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2176 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2178 * alloc.c (mark_buffer): Simplify. Remove prototype.
2179 (mark_object): Add comment. Reorganize marking of vector-like
2180 objects. Use CHECK_LIVE for all vector-like objects except buffers
2181 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2182 redundant calls to mark_vectorlike for bool vectors.
2184 2012-06-30 Glenn Morris <rgm@gnu.org>
2186 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2188 * epaths.in (PATH_SITELOADSEARCH): New.
2189 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2190 This is rather than relying on --enable-locallisppath elements
2191 having "site-lisp" in their names. (Bug#10208#25, 11658)
2193 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2195 * w32proc.c (sys_select): Accept and ignore one more argument.
2197 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2199 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2200 (pselect) [!MS_DOS]: Redirect to sys_select.
2202 * sysdep.c: Don't include dos.h and dosfns.h.
2204 * process.c (sys_select):
2205 * msdos.c (sys_select): Accept one more argument and ignore it.
2207 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2208 adapt data types and code to that.
2211 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2212 which clashes with the gnulib function of the same name.
2214 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2216 * font.c (font_style_to_value, font_style_symbolic)
2217 (font_prop_validate_style): Add type checks for values in
2220 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2222 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2225 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2227 * xdisp.c (try_window_id): Undo last change.
2229 * w32.c (getwd): Adjust commentary about startup_dir.
2230 (init_environment): Always call sys_access, even in non-MSVC
2231 builds. Don't chdir to the directory of the Emacs executable.
2232 This undoes code from 1997 which was justified by the need to
2233 "avoid conflicts when removing and renaming directories". But its
2234 downside was that every relative file name was being interpreted
2235 relative to the directory of the Emacs executable, which can never
2236 be TRT. In particular, it broke sys_access when called with
2237 relative file names.
2238 (sys_access): Map GetLastError to errno.
2240 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2242 * window.h (struct window): Change type of 'fringes_outside_margins'
2243 to bitfield. Fix comment. Adjust users accordingly.
2244 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2246 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2249 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2251 * gnutls.c (emacs_gnutls_handshake):
2252 Add QUIT to make the loop interruptible.
2254 2012-06-29 Glenn Morris <rgm@gnu.org>
2256 * charset.c (init_charset): Make lack of etc/charsets fatal.
2258 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2260 * editfns.c (region_limit): Fix type mismatch.
2262 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2264 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2265 undefined. Convert from xassert to eassert.
2266 * nsmenu.m: Convert from xassert to eassert.
2267 * nsterm.m: Likewise.
2269 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2271 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2273 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2275 Avoid integer overflow on scroll-left and scroll-right.
2276 * window.c (HSCROLL_MAX): New macro.
2277 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2278 overflow when requested scroll falls outside ptrdiff_t range.
2280 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2282 * window.h (struct window): Change type of 'hscroll',
2283 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2284 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2285 Adjust users accordingly.
2286 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2287 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2288 from EMACS_INT to ptrdiff_t.
2289 (make_window): Omit redundant initialization.
2291 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2293 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2295 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2297 * window.h (struct window): Change type of 'use_time' and
2298 'sequence_number' from Lisp_Object to int.
2299 * frame.c (make_frame): Adjust users accordingly.
2300 * print.c (print_object): Likewise.
2301 * window.c (select_window, Fwindow_use_time, make_parent_window)
2302 (make_window): Likewise.
2304 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2306 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2307 enabled with --enable-checking=[all,glyphs] configure option.
2308 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2309 adjust comments accordingly.
2310 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2311 undefined, adjust comments accordingly.
2312 * image.c: Likewise.
2313 * scroll.c: Likewise.
2314 * w32fns.c: Likewise.
2315 * w32term.c: Likewise.
2316 * xdisp.c: Likewise.
2317 * xfaces.c: Likewise.
2319 * xterm.c: Likewise.
2321 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2323 Generalize run-time debugging checks.
2324 * dispextern.h (XASSERTS): Remove.
2325 * fontset.c (xassert): Remove.
2326 Convert from xassert to eassert.
2327 * alloc.c: Convert from xassert to eassert.
2329 * dispnew.c: Likewise.
2331 * fringe.c: Likewise.
2332 * ftfont.c: Likewise.
2333 * gtkutil.c: Likewise.
2334 * image.c: Likewise.
2335 * keyboard.c: Likewise.
2337 * process.c: Likewise.
2338 * scroll.c: Likewise.
2339 * sound.c: Likewise.
2341 * w32console.c: Likewise.
2342 * w32fns.c: Likewise.
2343 * w32term.c: Likewise.
2344 * window.c: Likewise.
2345 * xdisp.c: Likewise.
2346 * xfaces.c: Likewise.
2348 * xselect.c: Likewise.
2349 * xterm.c: Likewise.
2351 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2353 * fns.c (maybe_resize_hash_table): Output message when growing the
2356 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2358 * alloc.c (allocate_string_data): Remove dead code.
2359 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2360 avoid GCC warning about unused macro.
2362 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2364 * alloc.c (allocate_string): Omit intervals initialization.
2365 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2366 as in make_pure_string and make_pure_c_string.
2368 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2370 * alloc.c (allocate_string): Fix last change.
2372 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2374 * alloc.c (allocate_string): Remove two redundant calls
2375 to memset, add explicit initialization where appropriate.
2377 2012-06-27 Glenn Morris <rgm@gnu.org>
2379 * lisp.mk (lisp): Remove paths.elc.
2381 2012-06-27 Chong Yidong <cyd@gnu.org>
2383 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2385 2012-06-26 John Wiegley <johnw@newartisans.com>
2387 * unexmacosx.c (copy_data_segment): Add two section names used
2388 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2390 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2391 when building with Clang.
2393 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2395 * eval.c (Fapply): Allow calling it with a single argument.
2397 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2399 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2400 _stricmp and _strnicmp.
2401 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2403 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2405 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2407 (allocate_process): Likewise for new process.
2408 (allocate_terminal): Change to use offsetof.
2409 (allocate_frame): Likewise.
2410 * frame.c (make_frame): Omit redundant initialization.
2411 * window.c (make_parent_window): Use memset.
2412 (make_window): Omit redundant initialization.
2413 * process.c (make_process): Omit redundant initialization.
2414 * terminal.c (create_terminal): Likewise.
2416 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2418 * term.c (delete_tty): Remove redundant call to memset.
2420 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2422 * alloc.c: Remove build_string.
2423 * lisp.h: Define build_string as static inline. This provides
2424 a better opportunity to optimize away calls to strlen when the
2425 function is called with compile-time constant argument.
2426 * image.c (imagemagick_error): Convert to build_string.
2427 * w32proc.c (sys_spawnve): Likewise.
2428 * xterm.c (x_term_init): Likewise.
2430 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2432 Use sprintf return value instead of invoking strlen on result.
2433 In the old days this wasn't portable, since some sprintf
2434 implementations returned char *. But they died out years ago and
2435 Emacs already assumes sprintf returns int.
2436 Similarly for float_to_string.
2437 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2438 * ccl.c (ccl_driver):
2439 * character.c (string_escape_byte8):
2440 * data.c (Fnumber_to_string):
2441 * doprnt.c (doprnt):
2442 * print.c (print_object):
2443 * xdisp.c (message_dolog):
2444 * xfns.c (syms_of_xfns):
2445 Use sprintf or float_to_string result to avoid need to call strlen.
2446 * data.c (Fnumber_to_string):
2447 Use make_unibyte_string, since the string must be ASCII.
2448 * lisp.h, print.c (float_to_string): Now returns int length.
2449 * term.c (produce_glyphless_glyph):
2450 Use sprintf result rather than recomputing it.
2452 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2453 * Makefile.in (ALL_CFLAGS):
2454 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2455 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2457 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2459 * dispextern.h (xstrcasecmp): Define to library function
2460 strcasecmp if available.
2461 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2463 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2465 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2466 Avoid comma operator.
2467 * menu.c (push_submenu_start, push_submenu_end)
2468 (push_left_right_boundary, push_menu_pane): Likewise.
2469 * msdos.c (dos_rawgetc): Likewise.
2471 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2473 * xfns.c (xic_create_fontsetname): Remove redundant calls
2476 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2478 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2479 sprintf already null-terminates its output.
2481 * xfns.c (x_window): Remove redundant cast.
2483 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2485 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2486 `const char *' to `char *' to avoid compiler warning.
2488 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2490 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2491 instead of truncating it to 63 (admittedly a generous limit).
2493 * process.c: Fix spelling and caps in comments.
2495 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2497 * emacs.c (setpgrp): Remove definition, unused.
2498 * sysdep.c (setpgrp): Remove definition, not used in this file.
2500 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2502 * makefile.w32-in: Update dependencies.
2504 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2506 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2507 (SYSTIME_H): Add nt/inc/sys/time.h.
2509 * systime.h [WINDOWSNT]: Include sys/time.h.
2511 * s/ms-w32.h (struct timespec): Definition moved from
2512 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2514 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2516 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2517 * buffer.h (buffer_slot_type_mismatch):
2518 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2519 * eval.c (unwind_to_catch):
2520 * image.c (my_png_error, my_error_exit):
2521 * keyboard.c (quit_throw_to_read_char, user_error)
2522 (Fexit_recursive_edit, Fabort_recursive_edit):
2523 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2524 (wrong_type_argument, buffer_overflow, __executable_start)
2525 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2526 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2527 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2529 (child_setup) [!DOS_NT]:
2530 * lread.c (end_of_file_error, invalid_syntax):
2531 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2532 * puresize.h (pure_write_error):
2533 * search.c (matcher_overflow):
2534 * sound.c (sound_perror, alsa_sound_perror):
2535 * sysdep.c, syssignal.h (croak):
2536 * term.c (maybe_fatal, vfatal):
2537 * textprop.c (text_read_only):
2538 * undo.c (user_error):
2539 * unexmacosx.c (unexec_error):
2540 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2541 Use _Noreturn rather than NO_RETURN.
2542 No need for separate decl merely because of _Noreturn.
2543 * sound.c (sound_warning, parse_sound):
2544 Remove unnecessary forward decls.
2546 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2548 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2549 * lisp.h (WAIT_READING_MAX): New macro.
2550 * dispnew.c (Fsleep_for, sit_for):
2551 * keyboard.c (kbd_buffer_get_event):
2552 * process.c (Faccept_process_output):
2553 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2554 This improves on the previous patch, which introduced a bug
2555 when time_t is unsigned and as wide as intmax_t.
2556 See <http://bugs.gnu.org/9000#51>.
2558 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2560 * dispnew.c (sit_for, Fsleep_for):
2561 * keyboard.c (kbd_buffer_get_event):
2562 * process.c (Faccept_process_output): Avoid compiler warnings when
2563 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2565 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2567 * makefile.w32-in: Update dependencies.
2569 * w32.c (ltime): Add return type and declare static.
2570 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2572 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2574 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2575 Privately reported by Herbert J. Skuhra.
2576 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2578 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2579 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2581 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2583 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2584 last argument of make_unibyte_string.
2586 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2587 language ID in the event parameters.
2589 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2590 event.code, not the obscure "character set ID".
2592 2012-06-23 Chong Yidong <cyd@gnu.org>
2594 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2596 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2598 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2599 * w32.c (fdutimens): New function.
2601 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2603 * s/ms-w32.h (pselect): Redirect to sys_select.
2605 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2607 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2608 in the logic of incrementing and decrementing the value of
2609 use_relocatable_buffers.
2611 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2613 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2614 Privately reported by Herbert J. Skuhra.
2615 [__FreeBSD__]: Remove "*/" typo after "#include".
2616 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2617 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2618 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2619 Don't assume EMACS_TIME and struct timeval are the same type.
2621 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2623 Support higher-resolution time stamps (Bug#9000).
2624 The time stamps are only nanosecond-resolution at the C level,
2625 since that's the best that any real-world system supports now.
2626 But they are picosecond-resolution at the Lisp level, as that's
2627 easy, and leaves room for future OS improvements.
2629 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2632 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2633 Don't get current time unless it's needed.
2635 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2636 now provides it if it's absent.
2637 (start_atimer): Port to higher-res time stamps.
2638 Check for time stamp overflow. Don't get current time more
2639 often than is needed.
2641 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2642 Include systime.h, not time.h.
2643 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2645 * dired.c: Include stat-time.h.
2646 (Ffile-attributes): File times now have higher resolution.
2648 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2649 (struct image): Timestamp now has higher resolution.
2651 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2652 has at least microseconds now. All uses removed.
2653 (update_frame, update_single_window, update_window, update_frame_1)
2654 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2656 * editfns.c (time_overflow): Now extern.
2657 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2658 (float-time, Fformat_time_string, Fcurrent_time_string)
2659 (Fcurrent_time_zone): Accept and generate higher-resolution
2661 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2662 (decode_time_components, lisp_seconds_argument): New functions.
2663 (make_time): Now static.
2664 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2665 Report an error if the time is invalid, rather than having the caller
2668 * fileio.c: Include <stat-time.h>
2669 (Fcopy_file): Copy higher-resolution time stamps.
2670 Prefer to set the time stamp via a file descriptor if that works.
2671 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2672 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2673 (Fvisited_file_modtime, Fset_visited_file_modtime):
2674 Support higher-resolution time stamps.
2676 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2678 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2680 * image.c (prepare_image_for_display, clear_image_cache)
2681 (lookup_image): Port to higer-resolution time stamps.
2683 * keyboard.c (start_polling, bind_polling_period):
2684 Check for time stamp overflow.
2685 (read_char, kbd_buffer_get_event, timer_start_idle)
2686 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2687 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2688 Port to higher-resolution time stamps. Do not assume time_t is signed.
2689 (decode_timer): New function. Timers are now vectors of length 9,
2690 not 8, to accommodate the picosecond component.
2691 (timer_check_2): Use it.
2693 * nsterm.m (select_timeout, timeval_subtract): Remove.
2694 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2695 as they're a bit more accurate and handle overflow better.
2696 (ns_select): Change prototype to be compatible with pselect.
2697 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2698 * nsterm.h (ns_select): Adjust prototype.
2700 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2701 us-resolution time stamps.
2702 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2704 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2706 * lisp.h (time_overflow): New decl.
2707 (wait_reading_process_output): First arg is now intmax_t, not int,
2708 to accommodate larger waits.
2710 * process.h (struct Lisp_Process.read_output_delay):
2711 Now counts nanoseconds, not microseconds.
2712 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2714 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2715 (wait_reading_process_output):
2716 Port to ns-resolution time stamps.
2717 (Faccept_process_output, wait_reading_process_output):
2718 Check for time stamp overflow. Do not assume time_t is signed.
2719 (select_wrapper): Remove; we now use pselect.
2720 (Fprocess_attributes): Now generates ns-resolution time stamps.
2722 * sysdep.c: Include utimens.h. Don't include utime.h
2723 or worry about struct utimbuf; gnulib does that for us now.
2724 (gettimeofday): Remove; gnulib provides a substitute.
2725 (make_timeval): New function.
2726 (set_file_times): Now sets ns-resolution time stamps.
2727 New arg FD; all uses changed.
2728 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2729 (system_process_attributes):
2730 Now returns ns-resolution time stamp. All uses changed.
2731 Check for time stamp overflow.
2733 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2734 provides a substitute now.
2736 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2737 since it guarantees struct timespec.
2738 (EMACS_TIME): Now struct timespec, so that we can support
2739 ns-resolution time stamps.
2740 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2741 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2742 (EMACS_USECS): Remove.
2743 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2744 so multiply the arg by 1000 before storing it.
2745 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2747 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2748 Port to ns-resolution time stamps.
2749 (EMACS_TIME_NEG_P): Remove; replaced by....
2750 (EMACS_TIME_SIGN): New macro.
2751 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2752 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2753 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2754 (make_timeval, make_lisp_time, decode_time_components): New decls.
2755 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2756 that it mishandled time_t overflow. You can't compare by subtracting!
2757 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2758 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2760 * term.c: Include <sys/time.h>.
2761 (timeval_to_Time): New function, for proper overflow wraparound.
2762 (term_mouse_position, term_mouse_click): Use it.
2764 * undo.c (record_first_change): Support higher-resolution time stamps
2766 (Fprimitive_undo): Use them when restoring time stamps.
2768 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2769 (w32_get_internal_run_time):
2770 Port to higher-resolution Emacs time stamps.
2771 (ltime): Now accepts single 64-bit integer, as that's more convenient
2774 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2776 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2777 for compatibility with pselect. Support ns-resolution time stamps.
2779 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2781 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2782 Check for time stamp overflow, and support ns-resolution time stamps.
2784 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2785 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2786 (timeval_subtract): Remove; no longer needed.
2787 (XTflash, XTring_bell, x_wait_for_event):
2788 Port to ns-resolution time stamps. Don't assume time_t is signed.
2790 2012-06-22 Chong Yidong <cyd@gnu.org>
2792 * xdisp.c (x_consider_frame_title): Revert last change.
2794 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2796 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2797 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2798 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2799 staticidx goes up to 1597 out of 1600 = 0x640.)
2801 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2803 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2804 Otherwise, the umask might be mistakenly 0 while handling input signals.
2806 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2808 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2810 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2812 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2813 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2814 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2815 access to `contents' member of Lisp_Vector objects with AREF and ASET
2818 2012-06-19 Chong Yidong <cyd@gnu.org>
2820 * frame.c (delete_frame): When selecting a frame on a different
2821 text terminal, do not alter the terminal's top-frame.
2823 * xdisp.c (format_mode_line_unwind_data): Record the target
2824 frame's selected window and its terminal's top-frame.
2825 (unwind_format_mode_line): Restore them.
2826 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2828 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2829 since tty frames can be explicitly named.
2830 (prepare_menu_bars): Likewise.
2832 * term.c (Ftty_top_frame): New function.
2834 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2836 Port byte-code-meter to modern targets.
2837 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2838 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2839 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2840 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2841 (METER_1, METER_2): Simplify.
2843 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2845 * data.c (Fdefalias): Return `symbol' (bug#11686).
2847 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2849 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2850 gets killed during executing of this function (Bug#11665).
2851 Try to always return Qt when the buffer has been actually killed.
2852 (Vkill_buffer_query_functions): In doc-string say that functions
2853 run by this hook should not change the current buffer.
2855 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2857 Fix recently-introduced process.c problems found by static checking.
2858 * process.c (write_queue_push, write_queue_pop, send_process):
2859 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2860 (write_queue_pop): Fix pointer signedness problem.
2861 (send_process): Remove unused local.
2863 2012-06-17 Chong Yidong <cyd@gnu.org>
2865 * xdisp.c (redisplay_internal): No need to redisplay terminal
2866 frames that are not on top.
2868 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2870 * process.c (make_process): Initialize write_queue.
2871 (write_queue_push, write_queue_pop): New functions.
2872 (send_process): Use them to maintain correct ordering of process
2875 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2877 * lisp.h (eassert): Assume C89 or later.
2878 This removes the need for CHECK.
2879 (CHECK): Remove. Its comments about always evaluating its
2880 argument were confusing, as 'eassert' typically does not evaluate
2883 * coding.c (produce_chars): Use ptrdiff_t, not int.
2885 * xterm.c (x_draw_underwave): Check for integer overflow.
2886 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2888 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2890 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2891 referenced (Bug#11583).
2893 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2895 Implement wave-style variant of underlining.
2896 * dispextern.h (face_underline_type): New enum.
2897 (face): Add field for underline type.
2898 * nsterm.m (ns_draw_underwave): New function.
2899 (ns_draw_text_decoration): Use it.
2900 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2902 (x_draw_glyph_string): Use them.
2903 * xfaces.c (Qline, Qwave): New Lisp objects.
2904 (check_lface_attrs, merge_face_ref)
2905 (Finternal_set_lisp_face_attribute, realize_x_face):
2906 Handle wave-style underline face attributes.
2907 * xterm.c (x_draw_underwave): New function.
2908 (x_draw_glyph_string): Use it.
2910 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2912 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2913 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2914 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2915 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2916 ($(BLD)/w32select.$(O)): Update dependencies.
2918 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2920 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2921 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2922 * character.c (_fetch_multibyte_char_p): Remove.
2923 * alloc.c: Include "character.h" before "buffer.h".
2925 * buffer.c: Likewise.
2926 * bytecode.c: Likewise.
2927 * callint.c: Likewise.
2928 * callproc.c: Likewise.
2929 * casefiddle.c: Likewise.
2930 * casetab.c: Likewise.
2931 * category.c: Likewise.
2933 * coding.c: Likewise.
2934 * composite.c: Likewise.
2935 * dired.c: Likewise.
2936 * dispnew.c: Likewise.
2938 * dosfns.c: Likewise.
2939 * editfns.c: Likewise.
2940 * emacs.c: Likewise.
2941 * fileio.c: Likewise.
2942 * filelock.c: Likewise.
2944 * fontset.c: Likewise.
2945 * fringe.c: Likewise.
2946 * indent.c: Likewise.
2947 * insdel.c: Likewise.
2948 * intervals.c: Likewise.
2949 * keyboard.c: Likewise.
2950 * keymap.c: Likewise.
2951 * lread.c: Likewise.
2952 * macros.c: Likewise.
2953 * marker.c: Likewise.
2954 * minibuf.c: Likewise.
2955 * nsfns.m: Likewise.
2956 * nsmenu.m: Likewise.
2957 * print.c: Likewise.
2958 * process.c: Likewise.
2959 * regex.c: Likewise.
2960 * region-cache.c: Likewise.
2961 * search.c: Likewise.
2962 * syntax.c: Likewise.
2964 * textprop.c: Likewise.
2966 * unexsol.c: Likewise.
2967 * w16select.c: Likewise.
2968 * w32fns.c: Likewise.
2969 * w32menu.c: Likewise.
2970 * window.c: Likewise.
2971 * xdisp.c: Likewise.
2973 * xmenu.c: Likewise.
2975 * xselect.c: Likewise.
2977 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2979 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2980 If all the glyphs of the glyph row came from strings, and we have no
2981 cursor positioning clues, put the cursor on the first glyph of the
2983 (handle_face_prop): Use chunk-relative overlay string index when
2984 indexing into it->string_overlays array. (Bug#11653)
2985 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2986 the rightmost. (Bug#11720)
2988 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2990 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2991 (CATEGORY_MEMBER): Enforce 1/0 value.
2992 * category.c (_temp_category_set): Remove.
2994 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2996 * window.c (Fdelete_other_windows_internal)
2997 (Fdelete_window_internal): Don't access frame's mouse highlight
2998 info of the initial frame. (Bug#11677)
3000 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3002 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3003 Assume USE_2_TAGS_FOR_INTS.
3004 (xreload): Adjust $tagmask width to match recent lisp.h change.
3006 Simplify lisp.h in minor ways that should not affect code.
3007 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3008 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3009 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3010 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3011 (INTTYPEBITS): New macro, for clarity.
3012 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
3013 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3014 Simplify now that USE_LSB_TAG is always defined.
3015 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3016 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3018 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
3020 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3022 2012-06-13 Glenn Morris <rgm@gnu.org>
3024 * s/bsd-common.h (BSD4_3):
3025 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3027 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3029 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3032 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3034 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
3035 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
3036 * alloc.c (widen_to_Lisp_Object): Remove.
3037 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3038 * frame.c (delete_frame): Remove outdated comment.
3039 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3040 USE_LISP_UNION_TYPE.
3041 (Fw32_unregister_hot_key): Likewise.
3042 (Fw32_toggle_lock_key): Likewise.
3043 * w32menu.c (add_menu_item): Likewise.
3044 (w32_menu_display_help): Use XIL instead of checking
3045 USE_LISP_UNION_TYPE.
3046 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3047 (init_heap): Likewise.
3048 * w32term.c (w32_read_socket): Update comment.
3050 2012-06-13 Glenn Morris <rgm@gnu.org>
3052 * s/usg5-4-common.h, src/s/unixware.h:
3053 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3055 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3057 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3059 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3060 * alloc.c (make_number) [!defined make_number]:
3061 Remove, as lisp.h always defines this now.
3062 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3063 (roundup_size): Verify that it is a power of 2.
3064 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3065 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3066 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3067 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3068 USE_LSB_TAG now is always defined to be either 0 or 1.
3070 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3071 code works fine either way, and efficiency is not a concern here,
3072 as the union type is for debugging, not for production.
3073 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3074 Use an inline function on all platforms when using the union type,
3075 since this is simpler and 'static inline' can be used portably
3077 (LISP_INITIALLY_ZERO): New macro.
3078 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3079 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3081 2012-06-12 Glenn Morris <rgm@gnu.org>
3083 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3085 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
3087 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3088 Move BROKEN_SIGIO to configure.
3090 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3091 Move NO_TERMIO to configure.
3093 2012-06-12 Chong Yidong <cyd@gnu.org>
3095 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3096 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3097 MagickExportImagePixels is undefined.
3099 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3101 * image.c (imagemagick_load_image): Remove unused label.
3103 2012-06-11 Glenn Morris <rgm@gnu.org>
3105 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3106 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3107 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3108 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3110 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3112 * alloc.c (make_byte_code): New function.
3113 (Fmake_byte_code): Use it. Don't purify here.
3114 * lread.c (read1): Use it as well to avoid extra allocation.
3116 2012-06-11 Chong Yidong <cyd@gnu.org>
3118 * image.c (imagemagick_load_image): Implement transparency.
3120 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3122 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3123 account for preceding backslashes. (Bug#11663)
3125 2012-06-09 Chong Yidong <cyd@gnu.org>
3127 * term.c: Support italics in capable terminals (Bug#9652).
3128 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3129 (turn_on_face): Output using TS_enter_italic_mode if available.
3130 Don't handle unused blinking and alt-charset cases.
3131 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3132 and tty_alt_charset_p cases.
3133 (tty_capable_p, init_tty): Support italics.
3135 * termchar.h (struct tty_display_info): Add field for italics.
3136 Remove unused blink field.
3138 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3141 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3142 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3143 tty_alt_charset_p. Add tty_italic_p.
3145 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
3147 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3148 dbus_type_is_basic if available.
3149 (xd_extract_signed, xd_extract_unsigned): Rename from
3150 extract_signed and extract_unsigned, respectively. Adapt callers.
3152 2012-06-09 Chong Yidong <cyd@gnu.org>
3154 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3156 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3159 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3161 * xdisp.c (vmessage): Treat frame message as multibyte.
3162 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3163 would generate the diagnostic "Making \302\247 buffer-local while
3166 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3168 * dispnew.c (showing_window_margins_p): Undo last change, which
3169 was done due to an inadvertent commit.
3170 (adjust_frame_glyphs_for_frame_redisplay): Do call
3171 showing_window_margins_p.
3173 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3175 * eval.c (Fmake_var_non_special): New primitive.
3176 (syms_of_eval): Defsubr it.
3177 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3179 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3181 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3182 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3184 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3186 * alloc.c (allocate_vectorlike): Fix last change.
3188 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3190 Block-based vector allocation of small vectors.
3191 * lisp.h (struct vectorlike_header): New field `nbytes',
3192 adjust comment accordingly.
3193 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3194 to denote vector blocks. Adjust users (live_vector_p,
3195 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3196 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3197 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3198 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3199 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3200 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3201 (roundup_size): New constant.
3202 (struct vector_block): New data type.
3203 (vector_blocks, vector_free_lists, zero_vector): New variables.
3204 (all_vectors): Rename to `large_vectors'.
3205 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3206 (sweep_vectors): New functions.
3207 (allocate_vectorlike): Return `zero_vector' as the only vector of
3208 0 items. Allocate new vector from block if vector size is less than
3209 or equal to VBLOCK_BYTES_MAX.
3210 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3211 (init_alloc_once): Add call to init_vectors.
3213 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3215 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3217 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3219 * doprnt.c (doprnt): Truncate multibyte char correctly.
3220 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3221 would mishandle a string argument "Xc" if X was a multibyte
3222 character of length 2: it would truncate after X's first byte
3223 rather than including all of X.
3225 2012-06-06 Chong Yidong <cyd@gnu.org>
3227 * buffer.c (word_wrap): Doc fix.
3229 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3231 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3233 2012-06-03 Glenn Morris <rgm@gnu.org>
3235 * xdisp.c (tool-bar-style): Doc fix.
3237 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3239 * Makefile.in (PAXCTL): Define.
3240 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3241 binary via PaX flags if the paxctl utility is available.
3242 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3243 Restore PaX flags to their default. (Bug#11398)
3245 2012-06-03 Chong Yidong <cyd@gnu.org>
3247 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3250 2012-06-03 Chong Yidong <cyd@gnu.org>
3252 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3253 (note_mode_line_or_margin_highlight): If there is no help echo,
3254 use mode-line-default-help-echo. Handle the case where the mouse
3255 position is past the end of the mode line string.
3257 * buffer.c (buffer_local_value_1): New function, split from
3258 Fbuffer_local_value; can return Qunbound.
3259 (Fbuffer_local_value): Use it.
3260 (Vmode_line_format): Docstring tweaks.
3262 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3264 * sysdep.c (system_process_attributes): Improve comment.
3266 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3268 * keyboard.c: Export real-this-command to Elisp.
3269 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3270 and DEFVAR it. Update all users.
3272 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3274 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3276 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3277 Convert pctcpu and pctmem to Lisp float properly.
3278 Let the compiler fold better, as 100.0/0x8000 is exact.
3280 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3282 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3285 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3287 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3289 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3291 For a 'struct window', replace some Lisp_Object fields to
3292 bitfields where appropriate, remove unused fields.
3293 * window.h (struct window): Remove unused 'last_mark_x' and
3294 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3295 change it's type from Lisp_Object to bitfield.
3296 Change type of 'force_start', 'optional_new_start',
3297 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3298 fields from Lisp_Object to bitfield. Adjust users accordingly.
3300 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3302 Pacify gcc -Wdouble-precision when using Xaw.
3303 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3304 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3305 Use 'float' consistently, rather than 'float' in most places
3306 and 'double' in a couple of places.
3308 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3310 * xdisp.c (handle_stop): Detect whether we have overlay strings
3311 loaded by testing it->current.overlay_string_index to be
3312 non-negative, instead of checking whether n_overlay_strings is
3313 positive. (Bug#11587)
3315 2012-05-31 Chong Yidong <cyd@gnu.org>
3317 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3319 * doc.c (Fsubstitute_command_keys): Doc fix.
3321 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3323 * search.c (search_buffer): Remove calls to
3324 r_alloc_inhibit_buffer_relocation, as it is now called by
3325 maybe_unify_char, which was the cause of relocation of buffer text
3328 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3330 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3331 for the duration of call to load_charset, to avoid problems with
3332 callers of maybe_unify_char that access buffer text through C
3335 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3336 decrement the inhibition flag, instead of just setting or
3339 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3341 Remove obsolete '#define static' cruft.
3342 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3343 This #undef was "temporary" in 2000; it is no longer needed
3344 now that '#define static' has gone away.
3345 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3346 (gray_bitmap_bits): Remove; no longer needed.
3347 All uses replaced with definiens.
3348 * xterm.c: Include "bitmaps/gray.xbm".
3350 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3352 Clean up __executable_start, monstartup when --enable-profiling.
3353 The following changes affect the code only when profiling.
3354 * dispnew.c (__executable_start): Rename from safe_bcopy.
3355 Define only on platforms that need it.
3356 * emacs.c: Include <sys/gmon.h> when profiling.
3357 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3358 (__executable_start): Remove decl, since lisp.h does it now.
3359 (safe_bcopy): Remove decl; no longer has that name.
3360 (main): Coalesce #if into single bit of code, for simplicity.
3361 Cast pointers to uintptr_t, since standard libraries want integers
3363 * lisp.h (__executable_start): New decl.
3365 2012-05-31 Glenn Morris <rgm@gnu.org>
3367 * image.c (Fimagemagick_types): Doc fix.
3369 2012-05-30 Jim Meyering <meyering@redhat.com>
3371 * callproc.c (Fcall_process_region): Include directory component
3372 in mkstemp error message (Bug#11586).
3374 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3376 * alloc.c, lisp.h (make_pure_vector): Now static.
3378 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3380 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3381 Move to byte-run.el.
3382 (Fautoload): Do the hash-doc more carefully.
3383 * data.c (Fdefalias): Purify definition, except for keymaps.
3384 (Qdefun): Move from eval.c.
3385 * lisp.h (Qdefun): Remove.
3386 * lread.c (read1): Tiny simplification.
3388 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3390 Do not create empty overlays with the evaporate property (Bug#9642).
3391 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3392 Bug#9642, but explicitly check that the buffer the overlay would
3393 be moved to is live and rearrange lines to make sure that errors
3394 will not put the overlay in an inconsistent state.
3395 (Fdelete_overlay): Cosmetics.
3397 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3399 * w32term.c (my_bring_window_to_top): New function.
3400 (x_raise_frame): Use handle returned by DeferWindowPos, which
3401 could be different from the original one.
3402 Call my_bring_window_to_top instead of my_set_foreground_window.
3405 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3406 by calling BringWindowToTop.
3408 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3409 (WM_EMACS_END): Increase by one.
3411 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3413 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3414 This avoids undefined behavior that might cause the eassert
3415 to not catch an out-of-range value.
3417 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3419 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3420 Update dependencies.
3422 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3424 * bidi.c (bidi_mirror_char): Fix last change.
3426 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3428 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3429 when referring to sectname field in printf format.
3431 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3433 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3434 Only r_alloc_inhibit_buffer_relocation needed to be added;
3435 the others were already declared.
3437 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3438 before checking whether it's out of range. Put the check inside
3440 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3442 2012-05-27 Ken Brown <kbrown@cornell.edu>
3444 * callproc.c (Fcall_process): Restore a line that was accidentally
3445 commented out in the 2011-02-13 change (bug#11547).
3447 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3449 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3450 defined on ralloc.c.
3452 * buffer.c [REL_ALLOC]: Remove prototypes of
3453 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3454 they are now on lisp.h.
3456 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3458 * search.c (search_buffer): Use it to inhibit relocation of buffer
3459 text while re_search_2 is doing its job, because re_search_2 is
3460 passed C pointers to buffer text. (Bug#11519)
3462 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3465 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3466 state after an additional call to move_it_in_display_line_to, keep
3467 the values of it->max_ascent and it->max_descent found for the
3469 (pos_visible_p): Revert the comparison against bottom_y to what it
3470 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3473 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3475 Fix coding-related core dumps with gcc -ftrapv.
3476 The code was computing A - B, where A and B are pointers, and B is
3477 random garbage. This can lead to core dumps on platforms that
3478 have special pointer registers, and it also leads to core dumps on
3479 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3480 A - B only when B is initialized properly.
3481 * coding.c (coding_set_source, coding_set_destination): Return void.
3482 (coding_change_source, coding_change_destinations): New functions,
3483 with the old behaviors of coding_set_source and coding_set_destination.
3484 All callers that need an offset changed to use these new functions.
3486 2012-05-26 Glenn Morris <rgm@gnu.org>
3488 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3490 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3492 Extend mouse support on W32 text-mode console.
3493 * xdisp.c (draw_row_with_mouse_face):
3494 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3496 * w32console.c: Include window.h.
3497 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3499 (initialize_w32_display): Initialize mouse-highlight data.
3501 * w32inevt.c: Include termchar.h and window.h.
3502 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3503 moves, call note_mouse_highlight. If help_echo changed, call
3504 gen_help_event to produce help-echo message in the echo area.
3505 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3508 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3510 * lread.c (read1): Simplify slightly to avoid an overflow warning
3511 with GCC 4.7.0 on x86-64.
3513 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3515 * bidi.c (bidi_mirror_char): Revert last change: an int is
3516 definitely wide enough here.
3518 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3520 Fix integer width and related bugs (Bug#9874).
3521 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3522 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3523 (string_bytes, check_sblock, allocate_string_data):
3524 (compact_small_strings, Fmake_bool_vector, make_string)
3525 (make_unibyte_string, make_multibyte_string)
3526 (make_string_from_bytes, make_specified_string)
3527 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3528 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3531 (allocate_pseudovector):
3532 Use int, not EMACS_INT, where int is wide enough.
3533 (inhibit_garbage_collection, Fgarbage_collect):
3534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3535 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3536 int might not be wide enough.
3537 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3538 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3539 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3540 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3541 (bidi_level_of_next_char, bidi_move_to_visually_next):
3542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3543 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3544 (Fkill_buffer, Fset_buffer_major_mode)
3545 (advance_to_char_boundary, Fbuffer_swap_text)
3546 (Fset_buffer_multibyte, overlays_at, overlays_in)
3547 (overlay_touches_p, struct sortvec, record_overlay_string)
3548 (overlay_strings, recenter_overlay_lists)
3549 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3550 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3551 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3552 (Foverlay_recenter, last_overlay_modification_hooks_used)
3553 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3555 (validate_region): Omit unnecessary test for b <= e,
3556 since that's guaranteed by the previous test.
3557 (adjust_overlays_for_delete): Avoid pos + length overflow.
3558 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3559 (report_overlay_modification):
3560 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3561 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3562 Omit pointer cast, which isn't needed anyway, and doesn't work
3563 after the EMACS_INT -> ptrdiff_t change.
3564 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3565 * buffer.h: Adjust decls to match defn changes elsewhere.
3566 (struct buffer_text, struct buffer):
3567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3568 Use EMACS_INT, not int, where int might not be wide enough.
3569 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3570 not int, to avoid needless 32-bit limit on 64-bit hosts.
3571 (exec_byte_code): Use tighter memory-full test, one that checks
3572 for alloca overflow. Don't compute the address of the object just
3573 before an array, as that's not portable. Use EMACS_INT, not
3574 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3575 * callint.c (Fcall_interactively):
3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3577 * callproc.c (call_process_kill, Fcall_process):
3578 Don't assume pid_t fits into an Emacs fixnum.
3579 (call_process_cleanup, Fcall_process, child_setup):
3580 Don't assume pid_t fits into int.
3581 (call_process_cleanup, Fcall_process, delete_temp_file)
3582 (Fcall_process_region):
3583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3584 (Fcall_process): Simplify handling of volatile integers.
3585 Use int, not EMACS_INT, where int will do.
3586 * casefiddle.c (casify_object, casify_region, operate_on_word)
3587 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3589 (casify_object): Avoid integer overflow when overallocating buffer.
3590 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3591 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3592 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3593 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3594 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3595 integers are now checked earlier. All uses replaced with XINT.
3597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3598 For CCL_MapSingle, check that content and value are in int range.
3599 (ccl_driver, Fregister_code_conversion_map):
3600 Check that Vcode_version_map_vector is a vector.
3601 (resolve_symbol_ccl_program): Check that vector header is in range.
3602 Always copy the vector, so that we can check its contents reliably
3603 now rather than having to recheck each instruction as it's being
3604 executed. Check that vector words fit in 'int'.
3605 (ccl_get_compiled_code, Fregister_ccl_program)
3606 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3607 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3608 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3609 contents are in range.
3610 (Fccl_execute_on_string): Check that status is in range.
3611 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3612 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3613 Accept and return EMACS_INT, not int, because callers can pass values
3615 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3616 (multibyte_chars_in_text, parse_str_as_multibyte)
3617 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3618 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3619 (string_escape_byte8, Fget_byte):
3620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3621 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3622 avoid mishandling large integers.
3623 * character.h: Adjust decls to match defn changes elsewhere.
3624 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3625 (Ffind_charset_region):
3626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3627 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3628 (load_charset_map_from_vector, Fdefine_charset_internal):
3629 Don't assume fixnum fits in int.
3630 (load_charset_map_from_vector, Fmap_charset_chars):
3631 Remove now-unnecessary CHECK_NATNUMs.
3632 (Fdefine_charset_internal): Check ranges here, more carefully.
3633 Don't rely on undefined behavior with signed left shift overflow.
3634 Don't assume unsigned int fits into fixnum, or that fixnum fits
3635 into unsigned int. Don't require max_code to be a valid fixnum;
3636 that's not true for gb10830 4-byte on a 32-bit host. Allow
3637 invalid_code to be a cons, for the same reason. Require code_offset
3638 to be a character. Avoid int overflow if max_char is close
3640 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3641 this is intended anyway and avoids some undefined behavior.
3642 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3643 INDEX_TO_CODE_POINT, as that's what it expects.
3644 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3645 * charset.h (DECODE_CHAR): Return int, not unsigned;
3646 this is what was intended anyway, and it avoids undefined behavior.
3647 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3648 integer-overflow issues.
3649 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3650 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3651 where the argument is EMACS_INT, and this behavior is not intended.
3652 * chartab.c (Fmake_char_table, Fset_char_table_range)
3653 (uniprop_get_decoder, uniprop_get_encoder):
3654 Don't assume fixnum fits in int.
3655 * cmds.c (move_point): New function, that does the gist of
3656 Fforward_char and Fbackward_char, but does so while checking
3657 for integer overflow more accurately.
3658 (Fforward_char, Fbackward_char): Use it.
3659 (Fforward_line, Fend_of_line, internal_self_insert)
3660 (internal_self_insert):
3661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3662 Fix a FIXME, by checking for integer overflow when calculating
3663 target_clm and actual_clm.
3664 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3665 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3666 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3667 (coding_alloc_by_making_gap, alloc_destination)
3668 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3669 (encode_coding_utf_16, detect_coding_emacs_mule)
3670 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3671 (detect_coding_iso_2022, decode_coding_iso_2022)
3672 (encode_invocation_designation, encode_designation_at_bol)
3673 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3674 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3675 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3676 (encode_coding_ccl, encode_coding_raw_text)
3677 (detect_coding_charset, decode_coding_charset)
3678 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3679 (produce_composition, produce_charset, produce_annotation)
3680 (decode_coding, handle_composition_annotation)
3681 (handle_charset_annotation, consume_chars, decode_coding_gap)
3682 (decode_coding_object, encode_coding_object, detect_coding_system)
3683 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3684 (code_convert_region, code_convert_string)
3685 (Fdefine_coding_system_internal)
3686 (coding_set_source, coding_set_destination):
3687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3688 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3689 (Fdefine_coding_system_internal):
3690 Don't assume fixnums fit in int.
3691 (decode_coding_gap, decode_coding_object, encode_coding_object)
3692 (Fread_coding_system, Fdetect_coding_region)
3693 (Funencodable_char_position, Fcheck_coding_systems_region)
3694 (get_translation, handle_composition_annotation, consume_chars):
3695 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3696 (consume_chars): Rewrite to not calculate an address outside buffer.
3697 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3698 Don't access memory outside of the args array.
3699 (Fdefine_coding_system_internal): Check for charset-id overflow.
3700 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3701 result of ENCODE_CHAR.
3702 * coding.h: Adjust decls to match defn changes elsewhere.
3703 (struct coding_system):
3704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3705 * composite.c (get_composition_id, find_composition)
3706 (run_composition_function, update_compositions)
3707 (compose_text, composition_gstring_put_cache)
3708 (composition_gstring_p, composition_gstring_width)
3709 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3710 (composition_compute_stop_pos, composition_reseat_it)
3711 (composition_update_it, struct position_record)
3712 (find_automatic_composition, composition_adjust_point)
3713 (Fcomposition_get_gstring, Ffind_composition_internal):
3714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3715 (update_compositions):
3716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3717 * composite.h: Adjust decls to match defn changes elsewhere.
3718 (struct composition):
3719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3720 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3721 Do not attempt to compute the address of the object just before a
3722 buffer; this is not portable.
3724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3725 (Faset): Use int, not EMACS_INT, where int is wide enough.
3726 (Fstring_to_number): Don't assume fixnums fit in int.
3727 (Frem): Don't assume arg is nonnegative.
3728 * dbusbind.c (xd_append_arg): Check for integers out of range.
3729 (Fdbus_call_method): Don't overflow the timeout int.
3730 (extract_signed, extract_unsigned): New functions.
3731 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3732 (xd_get_connection_references): Return ptrdiff_t, not int.
3734 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3735 (xd_read_message_1):
3736 Use int, not unsigned, where the dbus API uses int.
3737 (Fdbus_message_internal): Don't overflow mtype.
3738 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3739 * dired.c (directory_files_internal, file_name_completion, scmp)
3740 (file_name_completion_stat):
3741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3742 (file_name_completion): Don't overflow matchcount.
3743 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3744 * dispextern.h: Adjust decls to match defn changes elsewhere.
3745 (struct text_pos, struct glyph, struct bidi_saved_info)
3746 (struct bidi_string_data, struct bidi_it, struct composition_it)
3748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3749 (struct display_pos, struct composition_it, struct it):
3750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3751 * dispnew.c (increment_matrix_positions)
3752 (increment_row_positions, mode_line_string)
3753 (marginal_area_string):
3754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3755 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3757 (duration_to_sec_usec): New function, to check for overflow better.
3758 (Fsleep_for, sit_for): Use it.
3759 * doc.c (get_doc_string, store_function_docstring):
3760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3761 (get_doc_string, Fsnarf_documentation):
3762 Use int, not EMACS_INT, where int is wide enough.
3764 Use SAFE_ALLOCA, not alloca.
3765 Check for overflow when converting EMACS_INT to off_t.
3766 * doprnt.c (doprnt):
3767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3768 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3769 Don't assume uid_t fits into fixnum.
3770 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3771 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3772 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3773 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3774 (general_insert_function)
3775 (Finsert_char, make_buffer_string, make_buffer_string_both)
3776 (update_buffer_properties, Fbuffer_substring)
3777 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3778 (Fsubst_char_in_region, check_translation)
3779 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3780 (transpose_markers, Ftranspose_regions):
3781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3782 (clip_to_bounds): Move to lisp.h as an inline function).
3783 (Fconstrain_to_field): Don't assume integers are nonnegative.
3784 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3785 (Fsubst_char_in_region, Fsave_restriction):
3786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3787 (Femacs_pid): Don't assume pid_t fits into fixnum.
3788 (lo_time): Use int, not EMACS_INT, when int suffices.
3789 (lisp_time_argument): Check for usec out of range.
3790 (Fencode_time): Don't assume fixnum fits in int.
3791 (Fuser_login_name, Fuser_full_name): Signal an error
3792 if a uid argument is out of range, rather than relying on
3794 (Fformat_time_string): Remove now-unnecessary check.
3795 lisp_time_argument checks for out-of-range usec now.
3796 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3797 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3798 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3799 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3800 (init_cmdargs, Fdump_emacs):
3801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3802 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3803 the bottom (typically) 32 bits of the fixnum.
3804 * eval.c (specpdl_size, call_debugger):
3805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3806 (when_entered_debugger, Fbacktrace_debug):
3807 Don't assume fixnum can fit in int.
3808 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3809 the object just before a buffer; this is not portable.
3810 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3811 (grow_specpdl, unbind_to):
3812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3813 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3814 (grow_specpdl): Simplify allocation by using xpalloc.
3815 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3816 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3817 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3819 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3822 (Fcopy_file, non_regular_nbytes, read_non_regular)
3823 (Finsert_file_contents):
3824 Use int, not EMACS_INT, where int is wide enough.
3825 (READ_BUF_SIZE): Verify that it fits in int.
3826 (Finsert_file_contents): Check that counts are in proper range,
3827 rather than assuming fixnums fit into ptrdiff_t etc.
3828 Don't assume fixnums fit into int.
3829 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3830 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3831 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3832 (string_char_to_byte, string_byte_to_char)
3833 (string_make_multibyte, string_to_multibyte)
3834 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3835 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3836 (substring_both, Fdelete, internal_equal, Ffillarray)
3837 (Fclear_string, mapcar1)
3838 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3839 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3840 (larger_vector, make_hash_table, maybe_resize_hash_table)
3841 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3842 (Fmaphash, secure_hash):
3843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3844 (concat): Check for string index and length overflow.
3845 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3847 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3848 (larger_vector): New API (vec, incr_min, size_max) replaces old
3849 one (vec, new_size, init). This catches size overflow.
3850 INIT was removed because it was always Qnil.
3851 All callers changed.
3852 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3853 the upper bound on a hash table index size.
3854 (make_hash_table, maybe_resize_hash_table): Use it.
3855 (secure_hash): Computer start_byte and end_byte only after
3856 they're known to be in ptrdiff_t range.
3857 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3858 (Ffont_get_glyphs, Ffont_at):
3859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3860 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3861 (Flist_fonts, Fopen_font):
3862 Don't assume fixnum can fit in int.
3863 (check_gstring): Don't assume index can fit in int.
3864 (font_match_p): Check that fixnum is a character, not a nonnegative
3865 fixnum, since the later code needs to stuff it into an int.
3866 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3867 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3868 conversion overflow issues.
3869 (Fopen_font): Check for integer out of range.
3870 (Ffont_get_glyphs): Don't assume index can fit in int.
3871 * font.h: Adjust decls to match defn changes elsewhere.
3872 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3874 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3875 printmax_t, where ptrdiff_t is wide enough.
3876 (Finternal_char_font):
3877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3878 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3879 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3880 (Fset_frame_position, x_set_frame_parameters)
3881 (x_set_line_spacing, x_set_border_width)
3882 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3883 Check that fixnums are in proper range for system types.
3884 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3886 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3887 Use SAFE_ALLOCA_LISP, not alloca.
3888 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3889 intptr_t is wide enough.
3890 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3891 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3892 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3893 Check for fixnum out of range.
3894 * ftfont.c (ftfont_list): Don't assume index fits in int.
3895 Check that fixnums are in proper range for system types.
3896 (ftfont_shape_by_flt):
3897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3898 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3900 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3901 Check that fixnums are in proper range for system types.
3902 * gnutls.h: Adjust decls to match defn changes elsewhere.
3903 * gtkutil.c (xg_dialog_run):
3904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3905 (update_frame_tool_bar):
3906 Check that fixnums are in proper range for system types.
3907 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3908 (lookup_image): Check that fixnums are in range for system types.
3909 * indent.c (last_known_column, last_known_column_point):
3910 (current_column_bol_cache):
3911 (skip_invisible, current_column, check_display_width):
3912 (check_display_width, scan_for_column, current_column_1)
3913 (Findent_to, Fcurrent_indentation, position_indentation)
3914 (indented_beyond_p, Fmove_to_column, compute_motion):
3915 (Fcompute_motion, Fvertical_motion):
3916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3917 (last_known_column_modified): Use EMACS_INT, not int.
3918 (check_display_width):
3920 Check that fixnums and floats are in proper range for system types.
3921 (compute_motion): Don't assume index or fixnum fits in int.
3922 (compute_motion, Fcompute_motion):
3923 Use int, not EMACS_INT, when it is wide enough.
3924 (vmotion): Omit local var start_hpos that is always 0; that way
3925 we don't need to worry about overflow in expressions involving it.
3926 * indent.h: Adjust decls to match defn changes elsewhere.
3928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3929 Use int, not EMACS_INT, where int is wide enough.
3930 Remove unused members ovstring_chars_done and tab_offset;
3932 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3933 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3934 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3935 (make_gap, copy_text, insert, insert_and_inherit)
3936 (insert_before_markers, insert_before_markers_and_inherit)
3937 (insert_1, count_combining_before, count_combining_after)
3938 (insert_1_both, insert_from_string)
3939 (insert_from_string_before_markers, insert_from_string_1)
3940 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3941 (adjust_after_replace, adjust_after_insert, replace_range)
3942 (replace_range_2, del_range, del_range_1, del_range_byte)
3943 (del_range_both, del_range_2, modify_region)
3944 (prepare_to_modify_buffer, signal_before_change)
3945 (signal_after_change, Fcombine_after_change_execute):
3946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3947 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3948 (balance_an_interval, split_interval_right, split_interval_left)
3949 (find_interval, next_interval, update_interval)
3950 (adjust_intervals_for_insertion, delete_node, delete_interval)
3951 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3952 (static_offset_intervals, offset_intervals)
3953 (merge_interval_right, merge_interval_left, make_new_interval)
3954 (graft_intervals_into_buffer, temp_set_point_both)
3955 (temp_set_point, set_point, adjust_for_invis_intang)
3956 (set_point_both, move_if_not_intangible, get_property_and_range)
3957 (get_local_map, copy_intervals, copy_intervals_to_string)
3958 (compare_string_intervals, set_intervals_multibyte_1):
3959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3960 * intervals.h: Adjust decls to match defn changes elsewhere.
3962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3963 * keyboard.c (this_command_key_count, this_single_command_key_start)
3964 (before_command_key_count, before_command_echo_length, echo_now)
3965 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3966 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3967 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3968 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3970 (last_non_minibuf_size, last_point_position, echo_truncate)
3971 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3972 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3973 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3974 (stuff_buffered_input):
3975 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3976 (last_auto_save, command_loop_1, read_char):
3977 Use EMACS_INT, not int, to avoid integer overflow.
3978 (record_char): Avoid overflow in total_keys computation.
3979 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3980 * keyboard.h: Adjust decls to match defn changes elsewhere.
3981 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3982 (Fkey_description, Fdescribe_vector, Flookup_key):
3983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3984 (click_position): New function, to check that positions are in range.
3985 (Fcurrent_active_maps):
3987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3988 (Faccessible_keymaps, Fkey_description):
3989 (preferred_sequence_p):
3990 Don't assume fixnum can fit into int.
3991 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3992 Check for integer overflow in size calculations.
3993 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3994 avoid mishandling large integers.
3995 * lisp.h: Adjust decls to match defn changes elsewhere.
3996 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3997 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3998 (struct Lisp_Marker):
3999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4000 (clip_to_bounds): Now an inline function, moved here from editfns.c.
4001 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4002 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4003 All callers changed.
4004 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4005 Assume the arg has valid form, since it always does.
4006 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4007 unsigned integer system type.
4008 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4009 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4011 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4012 (duration_to_sec_usec): New decl.
4013 * lread.c (read_from_string_index, read_from_string_index_byte)
4014 (read_from_string_limit, readchar, unreadchar, openp)
4015 (read_internal_start, read1, oblookup):
4016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4017 (Fload, readevalloop, Feval_buffer, Feval_region):
4018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4019 (openp): Check for out-of-range argument to 'access'.
4020 (read1): Use int, not EMACS_INT, where int is wide enough.
4021 Don't assume fixnum fits into int.
4022 Fix off-by-one error that can read outside a buffer.
4023 (read_filtered_event): Use duration_to_sec_usec
4024 to do proper overflow checking on durations.
4025 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4026 in size calculation.
4027 (Fexecute_kbd_macro):
4028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4029 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4030 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4031 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4032 (set_marker_both, set_marker_restricted_both, marker_position)
4033 (marker_byte_position, Fbuffer_has_markers_at):
4034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4035 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
4036 * menu.c (ensure_menu_items): Rename from grow_menu_items.
4037 It now merely ensures that the menu is large enough, without
4038 necessarily growing it, as this avoids some integer overflow issues.
4039 All callers changed.
4040 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4041 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4042 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4043 Use SAFE_ALLOCA_LISP, not alloca.
4044 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4045 to EMACS_INT. Check that fixnums are in proper range for system types.
4046 * minibuf.c (minibuf_prompt_width, string_to_object)
4047 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4048 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4050 (get_minibuffer, read_minibuf_unwind):
4051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4052 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4053 this simplifies overflow checking. All callers changed.
4054 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4057 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4058 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4059 Check that fixnums are in proper range for system types.
4060 (Fx_create_frame, Fx_show_tip):
4061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4062 * nsfont.m (ns_findfonts, nsfont_list_family):
4063 Don't assume fixnum fits in long.
4064 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4066 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4068 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
4069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4070 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4071 (PRINTDECLARE, PRINTPREPARE):
4072 (strout, print_string):
4073 (print, print_preprocess, print_check_string_charset_prop)
4075 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4077 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4079 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
4080 (printchar, strout): Use xpalloc to catch size calculation overflow.
4081 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
4082 (print_error_message): Use SAFE_ALLOCA, not alloca.
4083 (print_object): Use int, not EMACS_INT, where int is wide enough.
4084 (print_depth, new_backquote_output, print_number_index):
4085 Use ptrdiff_t, not int, where int might not be wide enough.
4086 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4087 (Fset_process_window_size, Fformat_network_address)
4088 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
4090 Check that fixnums are in proper range for system types.
4091 (Fsignal_process): Simplify by avoiding a goto.
4092 Check for process-ids out of pid_t range rather than relying on
4094 (process_tick, update_tick): Use EMACS_INT, not int.
4095 (Fformat_network_address, read_process_output, send_process)
4096 (Fprocess_send_region, status_notify):
4097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4098 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4099 (wait_reading_process_output, read_process_output, exec_sentinel):
4100 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4101 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4102 (Faccept_process_output): Use duration_to_sec_usec to do proper
4103 overflow checking on durations.
4104 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4105 Don't assume pid_t fits in int.
4106 * process.h (struct Lisp_Process): Members tick and update_tick
4107 are now of type EMACS_INT, not int.
4108 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4109 configured --with-wide-int.
4110 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4111 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4112 * search.c (looking_at_1, string_match_1):
4113 (fast_string_match, fast_c_string_match_ignore_case)
4114 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4115 (scan_newline, find_before_next_newline, search_command)
4116 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4117 (set_search_regs, wordify):
4120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4121 (string_match_1, search_buffer, set_search_regs):
4123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4124 (wordify): Check for overflow in size calculation.
4125 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4126 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4127 Check that fixnums are in proper range for system types.
4128 * sound.c (struct sound_device)
4129 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4131 (Fplay_sound_internal):
4132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4133 * syntax.c (struct lisp_parse_state, find_start_modiff)
4134 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4135 (Fparse_partial_sexp):
4136 Don't assume fixnums can fit in int.
4137 (struct lisp_parse_state, find_start_pos, find_start_value)
4138 (find_start_value_byte, find_start_begv)
4139 (update_syntax_table, char_quoted, dec_bytepos)
4140 (find_defun_start, prev_char_comend_first, back_comment):
4141 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4142 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4144 (Finternal_describe_syntax_value): Check that match_lisp is a
4145 character, not an integer, since the code stuffs it into int.
4146 (scan_words, scan_sexps_forward):
4147 Check that fixnums are in proper range for system types.
4149 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4150 (scan_sexps_forward):
4151 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4152 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4153 * syntax.h: Adjust decls to match defn changes elsewhere.
4154 (struct gl_state_s):
4155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4156 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4157 MOST_POSITIVE_FIXNUM.
4158 * sysdep.c (wait_for_termination_1, wait_for_termination)
4159 (interruptible_wait_for_termination, mkdir):
4160 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4161 (emacs_read, emacs_write):
4162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4163 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4164 and double all fit in int.
4165 * term.c (set_tty_color_mode):
4166 Check that fixnums are in proper range for system types.
4167 * termhooks.h (struct input_event):
4168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4169 * textprop.c (validate_interval_range, interval_of)
4170 (Fadd_text_properties, set_text_properties_1)
4171 (Fremove_text_properties, Fremove_list_of_text_properties)
4172 (Ftext_property_any, Ftext_property_not_all)
4173 (copy_text_properties, text_property_list, extend_property_ranges)
4174 (verify_interval_modification):
4175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4176 (Fnext_single_char_property_change)
4177 (Fprevious_single_char_property_change):
4178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4179 (copy_text_properties):
4180 Check for integer overflow in index calculation.
4181 * undo.c (last_boundary_position, record_point, record_insert)
4182 (record_delete, record_marker_adjustment, record_change)
4183 (record_property_change):
4184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4185 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4187 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4188 (Fx_hide_tip, Fx_file_dialog):
4189 * w32menu.c (set_frame_menubar):
4190 Use ptrdiff_t, not int, for consistency with rest of code.
4191 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4192 (select_window, Fdelete_other_windows_internal)
4193 (window_scroll_pixel_based, window_scroll_line_based)
4194 (Frecenter, Fset_window_configuration):
4195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4196 (Fset_window_hscroll, run_window_configuration_change_hook)
4197 (set_window_buffer, temp_output_buffer_show, scroll_command)
4198 (Fscroll_other_window, Frecenter):
4199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4200 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4201 Don't assume fixnum fits in int.
4202 (Fset_window_scroll_bars):
4203 Check that fixnums are in proper range for system types.
4204 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4205 (string_pos, c_string_pos, number_of_chars, init_iterator)
4206 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4207 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4208 (compute_display_string_end, handle_face_prop)
4209 (face_before_or_after_it_pos, handle_invisible_prop)
4210 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4211 (display_prop_intangible_p, string_buffer_position_lim)
4212 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4213 (get_overlay_strings_1, get_overlay_strings)
4214 (iterate_out_of_display_property, forward_to_next_line_start)
4215 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4216 (get_next_display_element, set_iterator_to_next)
4217 (get_visually_first_element, compute_stop_pos_backwards)
4218 (handle_stop_backwards, next_element_from_buffer)
4219 (move_it_in_display_line_to, move_it_in_display_line)
4220 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4221 (add_to_log, message_dolog, message_log_check_duplicate)
4222 (message2, message2_nolog, message3, message3_nolog
4223 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4224 (current_message_1, truncate_echo_area, truncate_message_1)
4225 (set_message, set_message_1, store_mode_line_noprop)
4226 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4227 (text_outside_line_unchanged_p, check_point_in_composition)
4228 (reconsider_clip_changes)
4229 (redisplay_internal, set_cursor_from_row, try_scrolling)
4230 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4231 (redisplay_window, find_last_unchanged_at_beg_row)
4232 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4233 (trailing_whitespace_p, find_row_edges, display_line)
4234 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4235 (display_mode_element, store_mode_line_string)
4236 (pint2str, pint2hrstr, decode_mode_spec)
4237 (display_count_lines, display_string, draw_glyphs)
4238 (x_produce_glyphs, x_insert_glyphs)
4239 (rows_from_pos_range, mouse_face_from_buffer_pos)
4240 (fast_find_string_pos, mouse_face_from_string_pos)
4241 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4243 (safe_call, init_from_display_pos, handle_fontified_prop)
4244 (handle_single_display_spec, load_overlay_strings)
4245 (with_echo_area_buffer, setup_echo_area_for_printing)
4246 (display_echo_area, echo_area_display)
4247 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4248 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4249 (redisplay_window, dump_glyph_row, display_mode_line)
4250 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4251 (handle_display_spec, display_prop_string_p):
4252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4253 (handle_single_display_spec, build_desired_tool_bar_string)
4254 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4255 (get_specified_cursor_type):
4256 Check that fixnums are in proper range for system types.
4257 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4258 (Flookup_image_map):
4259 Don't assume fixnums fit in int.
4260 (compare_overlay_entries):
4261 Avoid mishandling comparisons due to subtraction overflow.
4262 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4263 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4264 (handle_tool_bar_click):
4265 Use int, not unsigned, since we prefer signed and the signedness
4266 doesn't matter here.
4267 (get_next_display_element, next_element_from_display_vector):
4268 Use int, not EMACS_INT, when int is wide enough.
4269 (start_hourglass): Use duration_to_sec_usec to do proper
4270 overflow checking on durations.
4271 * xfaces.c (Fbitmap_spec_p):
4272 Check that fixnums are in proper range for system types.
4273 (compare_fonts_by_sort_order):
4274 Avoid mishandling comparisons due to subtraction overflow.
4275 (Fx_family_fonts, realize_basic_faces):
4276 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4278 Don't assume fixnum fits in int.
4279 Use SAFE_ALLOCA_LISP, not alloca.
4280 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4281 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4282 (face_at_buffer_position, face_for_overlay_string)
4283 (face_at_string_position):
4284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4285 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4286 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4288 Check that fixnums are in proper range for system types.
4289 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4290 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4292 (Fx_change_window_property): Don't assume fixnums fit in int.
4293 * xfont.c (xfont_chars_supported):
4294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4295 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4296 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4297 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4298 * xml.c (parse_region):
4299 * xrdb.c (magic_file_p):
4300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4301 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4302 (x_get_local_selection, x_reply_selection_request)
4303 (x_handle_selection_request, wait_for_property_change):
4304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4305 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4306 short is wide enough.
4307 (x_send_client_event): Don't assume fixnum fits in int.
4308 * xterm.c (x_x_to_emacs_modifiers):
4309 Don't assume EMACS_INT overflows nicely into int.
4310 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4312 (handle_one_xevent): NATNUMP can eval its arg twice.
4313 (x_connection_closed):
4314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4315 * xterm.h: Adjust decls to match defn changes elsewhere.
4316 (struct scroll_bar): Use struct vectorlike_header
4317 rather than rolling our own approximation.
4318 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4320 2012-05-25 Glenn Morris <rgm@gnu.org>
4322 * lisp.mk (lisp): Update for more files being compiled now.
4324 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4326 * lread.c: Remove `read_pure' which makes no difference.
4327 (read_pure): Remove var.
4328 (unreadpure): Remove function.
4329 (readevalloop): Don't call read_list with -1 flag.
4330 (read1, read_vector): Don't test read_pure any more.
4331 (read_list): Simplify.
4333 * fileio.c, character.h: Minor style tweaks.
4335 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4337 * window.h (clip_changed): Remove useless declaration.
4339 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4341 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4342 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4344 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4347 This directory predates autoconf and is no longer needed nowadays.
4348 Move its few remaining bits of functionality to where they're needed.
4349 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4350 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4351 * m/template.h: Remove.
4352 * Makefile.in (M_FILE): Remove. All uses removed.
4353 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4354 * lisp.h (USE_LSB_TAG):
4355 * mem-limits.h (EXCEEDS_LISP_PTR):
4356 Use VAL_MAX, not VALBITS, in #if.
4357 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4358 (EMACS_UINT): Define unconditionally now.
4359 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4360 (BITS_PER_EMACS_INT): New constants, replacing
4361 what used to be in config.h, but not useful in #if.
4362 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4363 define them any more.
4364 (VAL_MAX): New macro.
4366 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4367 BITS_PER_EMACS_INT, in #if.
4368 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4369 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4370 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4371 * s/ms-w32.h (DATA_START):
4372 Move here from removed file m/intel386.h.
4373 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4374 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4376 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4378 Assume C89 or later.
4379 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4380 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4382 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4383 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4384 * textprop.c, tparam.c (NULL): Remove.
4385 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4386 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4387 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4388 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4389 * xterm.c (input_signal_count): Assume volatile works.
4391 2012-05-21 Ken Brown <kbrown@cornell.edu>
4393 * xgselect.c (xg_select): Fix first argument in call to 'select'
4396 2012-05-20 Ken Brown <kbrown@cornell.edu>
4398 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4399 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4401 2012-05-19 Ken Brown <kbrown@cornell.edu>
4403 * xfns.c (x_in_use): Remove `static' qualifier.
4404 * xterm.h (x_in_use): Declare.
4405 * xgselect.c: Include xterm.h.
4406 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4407 and `display_arg' (bug#9754).
4409 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4411 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4413 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4414 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4416 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4418 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4420 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4421 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4423 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4424 reference to image_cache->refcount.
4425 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4427 2012-05-17 Juri Linkov <juri@jurta.org>
4429 * search.c (Fword_search_regexp, Fword_search_backward)
4430 (Fword_search_forward, Fword_search_backward_lax)
4431 (Fword_search_forward_lax): Move functions to isearch.el
4432 (bug#10145, bug#11381).
4434 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4436 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4438 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4440 * lread.c (init_obarray): Declare Qt and Qnil as special.
4442 2012-05-14 Glenn Morris <rgm@gnu.org>
4444 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4445 Put "libexec" before "bin", for the sake of init_callproc_1.
4447 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4449 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4451 * unexaix.c: Port to more-recent AIX compilers.
4452 (report_error, report_error_1, make_hdr, copy_sym)
4453 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4454 Make arguments const char *, not char *, to avoid violations of C
4455 standard and to fix some AIX warnings reported by Gilles Pion.
4457 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4459 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4460 already have overlays loaded.
4461 (handle_single_display_spec): Before returning without displaying
4462 fringe bitmap, synchronize the bidi iterator with the main display
4463 iterator, by calling iterate_out_of_display_property.
4464 (iterate_out_of_display_property): Detect buffer iteration by
4465 testing that it->string is a Lisp string.
4466 (get_next_display_element): When the current object is exhausted,
4467 and there's something on it->stack, call set_iterator_to_next to
4468 proceed with what's on the stack, instead of returning zero.
4469 (set_iterator_to_next): If called at the end of a Lisp string,
4470 proceed to consider_string_end without incrementing string
4471 position. Don't increment display vector index past the end of
4472 the display vector. (Bug#11417)
4473 (pos_visible_p): Don't report a position visible when move_it_to
4474 stopped at the last line of window, which happens to be scanned
4475 backwards by the bidi iteration. (Bug#11464)
4477 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4479 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4480 and right-margin display specs even if the spec is invalid or we
4481 are on a TTY, and thus unable to display on the fringes.
4482 That's because the text with the property will not be displayed anyway,
4483 so we need to signal to the caller that this is a "replacing"
4484 display spec. This fixes display when the spec is invalid or we
4487 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4489 * unexaix.c (make_hdr): Fix typo in prototype.
4490 This bug broke the build on AIX. Problem reported by Gilles Pion.
4492 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4494 * keyboard.c (kbd_buffer_get_event): Read special events also in
4495 batch mode. (Bug#11415)
4497 2012-05-12 Glenn Morris <rgm@gnu.org>
4499 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4501 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4503 * lisp.mk (lisp): Add newcomment.elc.
4505 2012-05-12 Glenn Morris <rgm@gnu.org>
4507 * Makefile.in (MKDIR_P): New, set by configure.
4508 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4510 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4512 Remove unused function hourglass_started.
4513 * dispextern.h (hourglass_started):
4514 * w32fns.c (hourglass_started):
4515 * xdisp.c (hourglass_started): Remove.
4517 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4519 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4520 Update dependencies.
4522 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4524 * xgselect.c (xg_select): Put maxfds+1 into a var.
4525 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4527 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4529 2012-05-10 Dave Abrahams <dave@boostpro.com>
4531 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4532 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4534 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4536 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4537 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4538 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4539 Initialize xd_registered_buses.
4541 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4543 Untag more efficiently if USE_LSB_TAG.
4544 This is based on a proposal by YAMAMOTO Mitsuharu in
4545 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4546 For an admittedly artificial (nth 8000 longlist) benchmark on
4547 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4548 Emacs's overall text size by 1%.
4549 * lisp.h (XUNTAG): New macro.
4550 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4551 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4552 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4553 * eval.c (Fautoload):
4554 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4555 * frame.h (XFRAME): Use XUNTAG.
4557 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4558 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4559 Remove unportable assumptions about print widths of types like
4561 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4562 intptr_t when converting between pointer and integer, to avoid GCC
4563 warnings about wrong width.
4565 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4567 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4568 stack for each reader_thread, instead of defaulting to 8MB
4569 determined by the linker. This avoids failures in creating
4570 subprocesses on Windows 7, see the discussion in this thread:
4571 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4573 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4575 Fix up display of the *Minibuf-0* buffer in the mini window.
4576 * keyboard.c (read_char): Don't clear the echo area if there's no
4578 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4579 contents of *Minibuf-0*) if there's no message displayed in its stead.
4581 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4583 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4586 2012-05-06 Chong Yidong <cyd@gnu.org>
4588 * lisp.mk (lisp): Update.
4590 2012-05-05 Jim Meyering <meyering@redhat.com>
4592 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4594 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4596 * data.c (PUT_ERROR): New macro.
4597 (syms_of_data): Use it. Add new error type `user-error'.
4598 * undo.c (user_error): New function.
4599 (Fprimitive_undo): Use it.
4600 * print.c (print_error_message): Adjust print style for `user-error'.
4601 * keyboard.c (user_error): New function.
4602 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4604 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4606 Do not limit current-time-string to years 1000..9999.
4607 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4608 (Fcurrent_time_string): Support any year that is supported by the
4609 underlying localtime representation. Don't use asctime, as it
4610 has undefined behavior for years outside the range -999..9999.
4612 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4614 Fix race conditions involving setenv, gmtime, localtime, asctime.
4615 Without this fix, interrupts could mess up code that uses these
4616 nonreentrant functions, since setting TZ invalidates existing
4617 tm_zone or tzname values, and since most of these functions return
4618 pointers to static storage.
4619 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4620 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4621 Grow the critical sections to include not just invoking
4622 localtime/gmtime, but also accessing these functions' results
4623 including their tm_zone values if any, and any related TZ setting.
4624 (format_time_string): Last arg is now struct tm *, not struct tm **,
4625 so that the struct tm is saved in the critical section.
4626 All callers changed. Simplify allocation of initial buffer, partly
4627 motivated by the fact that memory allocation needs to be outside
4628 the critical section.
4630 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4632 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4633 with RESET_INTERVAL.
4635 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4636 Remove duplicated buffer name initialization.
4638 2012-05-02 Jim Meyering <jim@meyering.net>
4640 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4642 * xfns.c (x_window): Use xstrdup (Bug#11375).
4644 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4646 * xdisp.c (pos_visible_p): If already at a newline from the
4647 display string before the 'while' loop, don't walk back the glyphs
4648 from it3.glyph_row. Solves assertion violation when the display
4649 string begins with a newline (egg.el). (Bug#11367)
4651 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4653 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4656 2012-05-01 Glenn Morris <rgm@gnu.org>
4658 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4659 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4660 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4661 All were removed before 23.1.
4663 * dispnew.c: Remove HAVE_LIBNCURSES test;
4664 it is always true on relevant platforms.
4666 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4667 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4669 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4671 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4673 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4674 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4677 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4679 Do not avoid creating empty evaporating overlays (Bug#9642).
4680 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4681 That is, do not delete an evaporating overlay if it becomes
4682 empty after its bounds are adjusted to fit within its buffer.
4683 This fix caused other problems, and I'm reverting it until we get
4684 to the bottom of them.
4686 2012-04-27 Chong Yidong <cyd@gnu.org>
4688 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4690 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4692 * xdisp.c (pos_visible_p): If the window start position is beyond
4693 ZV, start the display from buffer beginning. Prevents assertion
4694 violation in init_iterator when the minibuffer window is scrolled
4697 * window.c (window_scroll_pixel_based): Likewise.
4699 2012-04-27 Chong Yidong <cyd@gnu.org>
4701 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4703 2012-04-27 Glenn Morris <rgm@gnu.org>
4705 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4706 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4708 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4710 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4711 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4713 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4715 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4716 display element, check also the underlying string or buffer
4717 character. (Bug#11341)
4719 * w32menu.c: Include w32heap.h.
4720 (add_menu_item): If the call to AppendMenuW (via
4721 unicode_append_menu) fails, disable Unicode menus only if we are
4722 running on Windows 9X/Me.
4724 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4726 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4727 (xgetint): Add missing shift for LSB tags.
4729 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4731 * keyboard.c (read_char): Don't wipe echo area for select window
4732 events: These might get delayed via `mouse-autoselect-window'
4735 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4737 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4738 manipulation of :loaded-from data.
4740 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4742 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4743 now a cons (bug#11311).
4745 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4747 Do not create empty overlays with the evaporate property (Bug#9642).
4748 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4749 if it becomes empty after its bounds are adjusted to fit within
4750 its buffer. Without this fix, in a nonempty buffer (let ((o
4751 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4752 yields an empty overlay that has the evaporate property, which is
4753 not supposed to happen.
4755 Fix minor GTK3 problems found by static checking.
4756 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4757 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4758 (struct _EmacsFixedClass, emacs_fixed_get_type):
4759 Move decls here from emacsgtkfixed.h, since they needn't be public.
4760 (emacs_fixed_get_type): Now static.
4761 (emacs_fixed_class_init): Omit unused local.
4762 (emacs_fixed_child_type): Remove; unused.
4763 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4764 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4765 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4766 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4767 (EMACS_FIXED_GET_CLASS): Remove; unused.
4768 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4770 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4771 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4773 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4775 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4776 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4777 (__malloc_size_t, __malloc_ptrdiff_t):
4778 Remove. All uses removed, replaced by the definiens if needed,
4779 since we can assume C89 or better now.
4780 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4781 (protect_malloc_state, align, get_contiguous_space)
4782 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4783 (malloc_atfork_handler_child, malloc_enable_thread)
4784 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4785 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4786 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4787 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4788 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4789 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4790 Define using prototypes, not old style.
4791 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4792 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4793 (align): Don't assume that signed integer overflow wraps around.
4794 Omit unused local var.
4795 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4796 (_free_internal_nolock, memalign, mallochook, reallochook):
4797 Omit no-longer-needed casts.
4798 (valloc): Use getpagesize, not __getpagesize.
4799 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4800 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4802 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4804 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4806 Move functions from C to Lisp. Make non-blocking method calls
4807 the default. Implement further D-Bus standard interfaces.
4809 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4810 (QCdbus_request_name_allow_replacement)
4811 (QCdbus_request_name_replace_existing)
4812 (QCdbus_request_name_do_not_queue)
4813 (QCdbus_request_name_reply_primary_owner)
4814 (QCdbus_request_name_reply_in_queue)
4815 (QCdbus_request_name_reply_exists)
4816 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4817 (QCdbus_registered_serial, QCdbus_registered_method)
4818 (QCdbus_registered_signal): New Lisp objects.
4819 (XD_DEBUG_MESSAGE): Use sizeof.
4820 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4821 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4822 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4823 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4824 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4825 (xd_signature, xd_append_arg): Allow float for integer types.
4826 (xd_get_connection_references): New function.
4827 (xd_get_connection_address): Rename from xd_initialize.
4828 Return cached address.
4829 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4830 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4832 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4833 Return number of refcounts.
4834 (Fdbus_get_unique_name): Make stronger parameter check.
4835 (Fdbus_message_internal): New defun.
4836 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4837 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4838 (Fdbus_send_signal, Fdbus_register_service)
4839 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4840 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4841 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4842 (Vdbus_compiled_version, Vdbus_runtime_version)
4843 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4844 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4845 (Vdbus_message_type_signal): New defvars.
4846 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4849 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4851 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4852 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4853 Do not assume ptrdiff_t is the same width as 'int'.
4855 * alloc.c: Handle unusual debugging option combinations.
4856 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4857 since the two debugging options are incompatible.
4858 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4860 (mem_init, mem_insert, mem_insert_fixup):
4861 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4862 (NEED_MEM_INSERT): Remove; no longer needed.
4864 2012-04-22 Leo Liu <sdl.web@gmail.com>
4866 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4868 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4870 * sysdep.c [__FreeBSD__]: Minor cleanups.
4871 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4872 Use Emacs indenting style more consistently. Avoid some casts.
4873 Use 'double' consistently rather than mixing 'float' and 'double'.
4875 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4877 * sysdep.c (list_system_processes, system_process_attributes):
4878 Add implementation for FreeBSD (Bug#5243).
4880 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4882 * lisp.mk (lisp): Update.
4884 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4886 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4887 It is never used otherwise.
4889 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4891 * print.c (print_preprocess): Only check print_depth if print-circle
4893 (print_object): Check for cycles even when print-circle is nil and
4894 print-gensym is t, but only check print_depth if print-circle is nil.
4896 2012-04-20 Chong Yidong <cyd@gnu.org>
4898 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4899 set the status to "failed" and ensure that sentinel is run.
4901 2012-04-20 Glenn Morris <rgm@gnu.org>
4903 * process.c (Fset_process_inherit_coding_system_flag)
4904 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4905 (Fmake_network_process, Fmake_serial_process): Doc fix.
4907 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4909 * xdisp.c (string_buffer_position_lim): Limit starting position to
4911 (set_cursor_from_row): If called for a mode-line or header-line
4912 row, return zero immediately.
4913 (try_cursor_movement): If inside continuation line, don't back up
4914 farther than the first row after the header line, if any.
4915 Don't consider the header-line row as "partially visible", even if
4916 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4918 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4920 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4923 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4924 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4926 configure: new option --enable-gcc-warnings (Bug#11207)
4927 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4928 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4929 (ALL_CFLAGS): Use new macros rather than old.
4930 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4931 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4932 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4933 -Wunused-result, -Wunused-variable. This should go away once
4934 the Emacs and Gnulib regex code is merged.
4935 (xmalloc, xrealloc): Now static.
4937 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4939 * dired.c (Fsystem_groups): Remove unused local.
4941 2012-04-17 Glenn Morris <rgm@gnu.org>
4943 * dired.c (Fsystem_users): Doc fix.
4945 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4947 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4948 (syms_of_dired): Add them.
4950 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4952 Fix minor alloc.c problems found by static checking.
4953 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4954 New extern decls, to avoid calling undeclared functions.
4955 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4956 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4957 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4958 (NEED_MEM_INSERT): New macro.
4959 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4960 Remove one incorrect comment and fix another.
4962 Fix minor ralloc.c problems found by static checking.
4963 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4964 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4965 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4966 (r_alloc_sbrk): Now static.
4968 Improve ralloc.c interface checking.
4969 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4970 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4971 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4972 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4973 [REL_ALLOC]: ... to here, to check interface.
4974 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4975 Remove decls. This fixes an "It stinks!".
4977 * alloc.c (which_symbols): Fix alignment issue / type clash.
4979 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4981 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4982 (struct Lisp_Misc_Any): Likewise.
4983 (struct Lisp_Free): Likewise.
4984 * alloc.c (union aligned_Lisp_Symbol): Define.
4985 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4986 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4987 (union aligned_Lisp_Misc): Define.
4988 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4989 aligned_Lisp_Misc instead of union Lisp_Misc.
4990 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4992 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4994 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4995 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4996 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4997 * s/netbsd.h, s/sol2-6.h:
4998 Remove definition of GC_MARK_STACK, since the default now works.
4999 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5000 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5001 no longer the default.
5002 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5004 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
5006 * lread.c (lisp_file_lexically_bound_p):
5007 Fix hang at ";-*-\n" (bug#11238).
5009 2012-04-14 Eli Zaretskii <eliz@gnu.org>
5011 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5012 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5014 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5016 * nsterm.m (constrainFrameRect): Always constrain when there is only
5017 one screen (Bug#10962).
5019 2012-04-13 Ken Brown <kbrown@cornell.edu>
5021 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5023 2012-04-13 Reuben Thomas <rrt@sc3d.org>
5025 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5027 2012-04-11 Daniel Colascione <dancol@dancol.org>
5029 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5030 against is gone. It's better to use vfork now so that when Cygwin
5031 gains a new, working vfork, we use it automatically (bug#10398).
5033 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5035 * window.c (save_window_save): Obey window-point-insertion-type.
5037 2012-04-11 Glenn Morris <rgm@gnu.org>
5039 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5041 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5043 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5045 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
5047 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5048 (force_quit_count): New var.
5049 (handle_interrupt): Use it.
5051 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
5053 * w32.c (w32_delayed_load): Record the full path of the library
5054 being loaded (bug#10424).
5056 2012-04-09 Glenn Morris <rgm@gnu.org>
5058 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5059 not just in the obarray, before snarfing them. (Bug#11036)
5061 * Makefile.in ($(leimdir)/leim-list.el):
5062 Pass EMACS rather than BUILT_EMACS.
5064 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5066 * process.c (make_process):
5067 * process.h: Add integer `gnutls_handshakes_tried' member to
5070 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5071 Add convenience `GNUTLS_LOG2i' macro.
5073 * gnutls.c (gnutls_log_function2i): Convenience log function.
5074 (emacs_gnutls_read): Use new log functions,
5075 `gnutls_handshakes_tried' process member, and
5076 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5077 attempts per process (connection).
5079 2012-04-09 Chong Yidong <cyd@gnu.org>
5081 * eval.c (Fuser_variable_p, user_variable_p_eh)
5082 (lisp_indirect_variable): Functions deleted.
5083 (Fdefvar): Caller changed.
5085 * callint.c (Finteractive, Fcall_interactively):
5086 * minibuf.c (Fread_variable): Callers changed.
5088 2012-04-09 Eli Zaretskii <eliz@gnu.org>
5090 * xdisp.c (set_cursor_from_row): If the display string appears in
5091 the buffer at position that is closer to point than the position
5092 after the display string, display the cursor on the first glyph of
5093 the display string. Fixes cursor display when a 'display' text
5094 property immediately follows invisible text. (Bug#11094)
5096 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5098 composite.c: use 'double' consistently
5099 * composite.c (get_composition_id): Use 'double' consistently
5100 instead of converting 'float' to 'double' and vice versa; this is
5101 easier to understand and avoids a GCC warning.
5103 2012-04-09 Glenn Morris <rgm@gnu.org>
5105 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5106 preparation for dumping it with emacs. (Bug#4789)
5107 (leimdir): New variable.
5108 ($(leimdir)/leim-list.el): New rule.
5109 (emacs$(EXEEXT)): Depend on leim-list.el.
5111 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5112 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5113 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5115 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5117 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5120 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
5122 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5123 Remove unused local variable.
5125 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5127 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5128 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5129 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5130 objects, as mark_maybe_pointer will catch them otherwise.
5131 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5132 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5134 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5136 Fix typo that broke non-Windows builds.
5137 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5139 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5141 Support building on MS-Windows with libxml2.
5143 * makefile.w32-in (OBJ2): Add xml.$(O).
5144 (GLOBAL_SOURCES): Add xml.c.
5145 ($(BLD)/xml.$(O)): New dependency list.
5147 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5148 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5149 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5150 [!WINDOWSNT]: New macros.
5151 (init_libxml2_functions, libxml2_loaded_p): New functions.
5152 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5153 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5154 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5155 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5157 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5158 Call init_libxml2_functions before calling libxml2 functions.
5159 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5161 * emacs.c: Don't include libxml/parser.h.
5162 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5163 xmlCleanupParser directly.
5165 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5167 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5169 * indent.c (Fvertical_motion): If there is a display string at
5170 point, use it.vpos to compute how many lines to backtrack after
5171 move_it_to point. (Bug#11133)
5173 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5175 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5176 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5177 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5178 macros related to unification of CJK characters. For the details,
5179 see the discussion following the message here:
5180 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5182 2012-04-04 Chong Yidong <cyd@gnu.org>
5184 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5186 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5188 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5189 instead of alloca. (Bug#11138)
5191 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5193 * w32menu.c (is_simple_dialog): Properly check lisp types.
5196 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5198 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5199 position we get to after a call to move_it_to fails the
5200 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5201 only if we wind up in a string from display property. (Bug#11063)
5203 * window.c (Fdelete_other_windows_internal): Invalidate the row
5204 and column information about mouse highlight, so that redisplay
5205 restores it after reallocating the glyph matrices. (Bug#7464)
5207 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5208 string comes from a `display' text property, use the buffer
5209 position of that property as if we actually saw that position in
5211 (move_it_by_lines): Remove the assertion that
5212 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5213 violated when there's a before-string at the beginning of a line.
5216 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5218 * xdisp.c (append_space_for_newline): If the default face was
5219 remapped, use the remapped face for the appended newline.
5220 (extend_face_to_end_of_line): Use the remapped default face for
5221 extending the face to the end of the line.
5222 (display_line): Call extend_face_to_end_of_line when the default
5223 face was remapped. (Bug#11068)
5225 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5227 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5229 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5231 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5233 2012-03-27 Glenn Morris <rgm@gnu.org>
5235 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5238 2012-03-26 Kenichi Handa <handa@m17n.org>
5240 * dispextern.h (struct glyph): Fix previous change. Change the
5241 bit length of glyphless.ch to 25 (Bug#11082).
5243 2012-03-26 Chong Yidong <cyd@gnu.org>
5245 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5246 (command_loop_1): Use it; inhibit selection update for
5247 handle-select-window too (Bug#8996).
5249 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5251 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5253 2012-03-25 Kenichi Handa <handa@m17n.org>
5255 * dispextern.h (struct glyph): Change the bit length of
5256 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5258 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5260 * s/ms-w32.h (tzname): Include time.h before redirecting to
5261 _tzname. Fixes the MSVC build. (Bug#9960)
5263 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5265 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5268 * xterm.c (XTread_socket): Only modify handling_signal if
5269 !SYNC_INPUT. (Bug#11080)
5271 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5273 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5274 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5275 when fetching a multibyte character consumes more bytes than
5276 CHAR_BYTES returns, due to unification of CJK characters in
5277 string_char. (Bug#11073)
5279 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5281 * process.c (wait_reading_process_output): Handle pty disconnect
5282 by refraining from sending oneself a SIGCHLD (bug#10933).
5284 2012-03-22 Chong Yidong <cyd@gnu.org>
5286 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5288 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5289 Mark string as coming from a prefix property.
5290 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5291 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5293 2012-03-21 Chong Yidong <cyd@gnu.org>
5295 * xfaces.c (Vface_remapping_alist): Doc fix.
5297 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5299 * w32proc.c (Fw32_set_console_codepage)
5300 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5303 2012-03-20 Chong Yidong <cyd@gnu.org>
5305 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5306 to reflect default non-nil value of redisplay-dont-pause.
5308 2012-03-19 Kenichi Handa <handa@m17n.org>
5310 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5311 it fit in a valid range (Bug#11003).
5313 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5315 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5316 that is not from display property, accept the row as a "cursor
5317 row" if one of the string's character has a non-nil `cursor'
5318 property. Fixes cursor positioning when there are newlines in
5319 overlay strings, e.g. in icomplete.el. (Bug#11035)
5321 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5323 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5325 2012-03-12 Chong Yidong <cyd@gnu.org>
5327 * eval.c (inhibit_lisp_code): Rename from
5328 inhibit_window_configuration_change_hook; move from window.c.
5330 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5331 * window.c (run_window_configuration_change_hook)
5332 (syms_of_window): Callers changed.
5334 2012-03-11 Chong Yidong <cyd@gnu.org>
5336 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5338 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5340 2012-03-10 Chong Yidong <cyd@gnu.org>
5342 * frame.c (other_visible_frames): Don't assume the selected frame
5343 is visible (Bug#10955).
5345 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5347 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5349 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5351 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5352 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5355 2012-03-03 Glenn Morris <rgm@gnu.org>
5357 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5359 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5361 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5362 position past the first glyph_row that ends at ZV. (Bug#10902)
5363 (redisplay_window, next_element_from_string): Fix typos in
5365 (redisplay_window): Pass to move_it_vertically the margin in
5366 pixels, not in screen lines.
5368 2012-03-02 Glenn Morris <rgm@gnu.org>
5370 * buffer.c (buffer-list-update-hook): Doc fix.
5372 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5374 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5375 push_it before setting up the iterator for the first overlay
5376 string, even if we have an empty string loaded.
5377 (next_overlay_string): If there's an empty string on the iterator
5378 stack, pop the stack. (Bug#10903)
5380 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5382 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5383 Suggested by Stefan Monnier in
5384 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5385 * alloc.c (widen_to_Lisp_Object): New static function.
5386 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5387 and widening them to Lisp_Objects. This would work even if
5388 USE_LSB_TAG is defined and wide integers are used, which might
5389 happen in a future version of Emacs.
5391 2012-02-25 Chong Yidong <cyd@gnu.org>
5393 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5396 * xselect.c (Fx_selection_exists_p): Doc fix.
5397 (x_clipboard_manager_save_all): Print an informative message
5398 before saving to clipboard manager.
5400 2012-02-24 Chong Yidong <cyd@gnu.org>
5402 * keyboard.c (process_special_events): Handle all X selection
5403 requests in kbd_buffer, not just the next one (Bug#8869).
5405 2012-02-23 Chong Yidong <cyd@gnu.org>
5407 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5408 call when setting menu-bar-lines and tool-bar-lines parameters.
5409 (unwind_create_frame_1): New helper function.
5411 * window.c (inhibit_window_configuration_change_hook): New var.
5412 (run_window_configuration_change_hook): Obey it.
5413 (syms_of_window): Initialize it.
5415 2012-02-22 Chong Yidong <cyd@gnu.org>
5417 * xterm.c (x_draw_image_relief): Add missing type check for
5418 Vtool_bar_button_margin (Bug#10743).
5420 2012-02-21 Chong Yidong <cyd@gnu.org>
5422 * fileio.c (Vfile_name_handler_alist): Doc fix.
5424 * buffer.c (Fget_file_buffer): Protect against invalid file
5425 handler return value.
5427 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5429 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5430 when computing $valmask.
5432 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5433 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5434 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5435 It's useless in that case, and it can cause problems on hosts
5436 that allocate halves of EMACS_INT values separately.
5437 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5438 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5439 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5440 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5441 it avoids undefined behavior on hosts where shifting right by more
5442 than the word width has undefined behavior.
5444 2012-02-19 Chong Yidong <cyd@gnu.org>
5446 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5447 (Funhandled_file_name_directory, Ffile_name_as_directory)
5448 (Fdirectory_file_name, Fexpand_file_name)
5449 (Fsubstitute_in_file_name): Protect against invalid file handler
5450 return values (Bug#10845).
5452 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5454 * .gdbinit (pitx): Fix incorrect references to fields of the
5457 2012-02-17 Chong Yidong <cyd@gnu.org>
5459 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5461 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5463 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5464 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5466 2012-02-15 Chong Yidong <cyd@gnu.org>
5468 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5469 marked as special. Also, starting docstrings with * is obsolete.
5471 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5473 * gnutls.c (emacs_gnutls_write): Fix last change.
5475 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5477 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5480 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5482 * keymap.c (Fsingle_key_description): Handle char ranges.
5484 2012-02-12 Chong Yidong <cyd@gnu.org>
5486 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5487 as that creates a dangerous corner case.
5489 * window.c (Fdelete_window_internal): Invalidate the mouse
5490 highlight (Bug#9904).
5492 2012-02-12 Glenn Morris <rgm@gnu.org>
5494 * xselect.c (Fx_own_selection_internal)
5495 (Fx_get_selection_internal, Fx_disown_selection_internal)
5496 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5497 * nsselect.m (Fx_own_selection_internal)
5498 (Fx_disown_selection_internal, Fx_selection_exists_p)
5499 (Fx_selection_owner_p, Fx_get_selection_internal):
5500 Sync docs and argument specs with the xselect.c versions.
5502 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5504 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5506 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5508 * w32select.c (Fx_selection_exists_p): Sync doc string and
5509 argument list with xselect.c. (Bug#10783)
5511 * w16select.c (Fx_selection_exists_p): Sync doc string and
5512 argument list with xselect.c. (Bug#10783)
5514 2012-02-10 Glenn Morris <rgm@gnu.org>
5516 * fns.c (Fsecure_hash): Doc fix.
5518 2012-02-09 Kenichi Handa <handa@m17n.org>
5520 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5522 2012-02-07 Chong Yidong <cyd@gnu.org>
5524 * buffer.c (Fbuffer_local_variables)
5525 (buffer_lisp_local_variables): Handle unbound vars correctly;
5526 don't let Qunbound leak into Lisp.
5528 2012-02-07 Glenn Morris <rgm@gnu.org>
5530 * image.c (Fimagemagick_types): Doc fix.
5532 * image.c (imagemagick-render-type): Change it from a lisp object
5533 to an integer. Move the doc here from the lisp manual.
5534 Treat all values not equal to 0 the same.
5536 2012-02-06 Chong Yidong <cyd@gnu.org>
5538 * doc.c (store_function_docstring): Avoid applying docstring of
5539 alias to base function (Bug#2603).
5541 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5543 * .gdbinit (pp1, pv1): Remove redundant defines.
5546 2012-02-04 Chong Yidong <cyd@gnu.org>
5548 * nsterm.m: Declare a global (Bug#10694).
5550 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5552 * w32.c (get_emacs_configuration_options):
5553 Include --enable-checking, if specified, in the return value.
5555 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5557 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5558 after rounding frame sizes. (Bug#9723)
5560 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5562 * keyboard.c (adjust_point_for_property): Don't position point
5563 before BEGV. (Bug#10696)
5565 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5567 Handle overflow when computing char display width (Bug#9496).
5568 * character.c (char_width): Return EMACS_INT, not int.
5569 (char_width, c_string_width): Check for overflow when
5570 computing the width; this is possible now that individual
5571 characters can have unbounded width. Problem introduced
5572 by merge from Emacs 23 on 2012-01-19.
5574 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5576 * dbusbind.c (Fdbus_register_method): Mention the return value
5577 :ignore in the docstring.
5579 2012-02-02 Glenn Morris <rgm@gnu.org>
5581 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5583 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5584 Unconditionally set to t. (Bug#10673)
5585 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5586 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5587 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5589 2012-02-02 Kenichi Handa <handa@m17n.org>
5591 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5592 0, do not call append_composite_glyph.
5594 2012-02-02 Kenichi Handa <handa@m17n.org>
5596 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5598 (x_produce_glyphs): If the component of a composition is a null
5599 string, set it->pixel_width to 1 to avoid zero-width glyph.
5601 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5603 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5604 first 2 arguments are identical. This makes inserting large
5605 output from a subprocess an order of magnitude faster on
5606 MS-Windows, where all sbrk'ed memory is always contiguous.
5608 2012-01-31 Glenn Morris <rgm@gnu.org>
5610 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5611 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5612 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5614 2012-01-29 Glenn Morris <rgm@gnu.org>
5616 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5618 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5620 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5622 2012-01-28 Chong Yidong <cyd@gnu.org>
5624 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5626 2012-01-26 Chong Yidong <cyd@gnu.org>
5628 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5630 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5631 repeat counts (Bug#10507).
5633 2012-01-26 Glenn Morris <rgm@gnu.org>
5635 * lread.c (syms_of_lread): Doc fix.
5637 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5639 * coding.c (encode_designation_at_bol): Change return value to
5642 2012-01-25 Chong Yidong <cyd@gnu.org>
5644 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5646 2012-01-21 Chong Yidong <cyd@gnu.org>
5648 * floatfns.c (Fcopysign): Make the second argument non-optional,
5649 since nil is not allowed anyway.
5651 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5653 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5654 (send_process): Likewise.
5656 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5658 * window.c (save_window_save, Fcurrent_window_configuration)
5659 (Vwindow_persistent_parameters): Do not use Qstate.
5660 Rewrite doc-strings.
5662 2012-01-19 Kenichi Handa <handa@m17n.org>
5664 * character.c (char_width): New function.
5665 (Fchar_width, c_string_width, lisp_string_width):
5666 Use char_width (Bug#9496).
5668 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5670 * window.c (Vwindow_persistent_parameters): New variable.
5671 (Fset_window_configuration, save_window_save): Handle persistent
5674 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5676 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5677 thrashing the stack of the thread. (Bug#9087)
5679 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5681 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5683 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5685 * xdisp.c (rows_from_pos_range): Handle the case where the
5686 highlight ends on a newline. (Bug#10464)
5687 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5688 he end column for display of highlight that ends on a newline
5691 2012-01-11 Glenn Morris <rgm@gnu.org>
5693 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5694 from load-path also when installation-directory is nil. (Bug#10208)
5696 2012-01-10 Glenn Morris <rgm@gnu.org>
5698 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5700 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5701 Update template values to be closer to their typical values these days.
5703 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5705 * xdisp.c (rows_from_pos_range): Accept additional argument
5706 DISP_STRING, and accept any glyph in a row whose object is that
5707 string as eligible for mouse highlight. Fixes mouse highlight of
5708 display strings from overlays. (Bug#10464)
5710 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5712 emacs: fix an auto-save permissions race condition (Bug#10400)
5713 * fileio.c (auto_saving_dir_umask): New static var.
5714 (Fmake_directory_internal): Use it.
5715 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5716 creating the directory. The old code temporarily assigns
5717 too-generous permissions to the directory.
5718 (do_auto_save_eh): Clear it.
5719 (Fdo_auto_save): Catch all errors, not just file errors, so
5720 that the var is always cleared.
5722 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5724 * search.c (scan_buffer): Pass character positions to
5725 know_region_cache, not byte positions. (Bug#6540)
5727 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5729 * w32.c (sys_rename): Report EXDEV when rename of a directory
5730 fails because the target is on another logical disk. (Bug#10284)
5732 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5734 * xterm.c (x_embed_request_focus): New function.
5736 * xterm.h: Add prototype.
5738 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5740 2012-01-05 Glenn Morris <rgm@gnu.org>
5742 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5744 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5746 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5747 Load gnutls_transport_set_lowat only if GnuTLS version is below
5749 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5750 GnuTLS versions below 2.11.1.
5752 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5754 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5755 to the doc string advising against its use for altering the way
5756 windows are scrolled.
5758 2011-12-28 Kenichi Handa <handa@m17n.org>
5760 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5761 coding-system ASCII compatible only when it does not produce BOM
5762 on encoding (Bug#10383).
5764 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5766 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5768 (create_and_show_popup_menu): Always use menu_position_func for
5771 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5773 * callint.c (Fcall_interactively): Don't truncate prompt string.
5775 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5777 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5778 property that ends at ZV, so that the bidi iteration could be
5779 resumed from there (after widening). (Bug#10360)
5781 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5783 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5785 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5787 * nsterm.m (x_free_frame_resources):
5788 Release f->output_data.ns->miniimage.
5789 (ns_index_color): Fix indentation. Do not retain
5790 color_table->colors[i].
5792 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5795 * nsfns.m (x_set_background_color): Assign return value from
5796 ns_index_color to face-background instead of NSColor*.
5797 (ns_implicitly_set_icon_type): Fix indentation.
5798 Change assignment in for loop to comparison.
5800 * emacs.c (ns_pool): New variable.
5801 (main): Assign ns_pool.
5802 (Fkill_emacs): Call ns_release_autorelease_pool.
5804 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5805 autorelease fdesc, release fdAttrs and tdict.
5806 (ns_get_covering_families): Release charset.
5807 (ns_findfonts): Release NSFontDescriptor created with new.
5808 (ns_uni_to_glyphs): Fix indentation.
5809 (setString): Release attrStr before assigning new value.
5811 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5813 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5815 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5816 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5818 2011-12-18 David Reitter <reitter@cmu.edu>
5820 * nsterm.m (ns_term_init): Subscribe for notifications
5821 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5822 to method trackingNotification in EmacsMenu.
5824 * nsmenu.m (trackingMenu): New variable.
5825 (trackingNotification): New method (from Aquamacs).
5826 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5827 from Aquamacs (Bug#7030).
5829 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5831 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5832 (symbol_to_nsstring): Fix indentation.
5833 (ns_symbol_to_pb): New function.
5834 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5835 (Fns_rotate_cut_buffers_internal): Remove.
5836 (Fns_store_selection_internal): Rename from
5837 Fns_store_cut_buffer_internal.
5838 (ns_get_foreign_selection, Fx_own_selection_internal)
5839 (Fx_disown_selection_internal, Fx_selection_exists_p)
5840 (Fns_get_selection_internal, Fns_store_selection_internal):
5841 Use ns_symbol_to_pb and check if return value is nil.
5842 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5843 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5844 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5845 renamed to Sns_store_selection_internal.
5846 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5847 and remove this function.
5848 (ns_handle_selection_clear): Remove, never used.
5849 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5852 2011-12-17 Ken Brown <kbrown@cornell.edu>
5854 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5855 GID is unknown (Bug#10257).
5857 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5859 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5860 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5861 which caused a build failure on GNU/Linux IA-64. This problem was
5862 introduced by my 2011-10-07 patch.
5864 2011-12-15 Juri Linkov <juri@jurta.org>
5866 * image.c (imagemagick_error): New function. (Bug#10112)
5867 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5868 Use `imagemagick_error' where ImageMagick functions return
5870 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5873 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5875 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5876 fill background (Bug#8992).
5878 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5880 * window.c (Vwindow_combination_resize)
5881 (Vwindow_combination_limit): Use t instead of non-nil in
5883 (Vrecenter_redisplay): Add first sentence of doc-string on
5885 (Frecenter): Fix doc-string typo.
5887 2011-12-11 Kenichi Handa <handa@m17n.org>
5889 * coding.c (Funencodable_char_position): Pay attention to the
5890 buffer text relocation (Bug#9389).
5892 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5894 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5895 gtk_init (Bug#10100).
5897 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5899 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5900 IT->string is nil. (Bug#10263)
5902 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5904 * nsterm.h (x_free_frame_resources): Declare.
5906 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5907 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5909 * nsterm.h (ns_get_defaults_value): Declare.
5911 * nsterm.m (ns_default): Call ns_get_defaults_value.
5913 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5915 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5918 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5920 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5921 that where the value of an _OBJC_* symbol points to is in the .bss
5922 section (Bug#10240).
5924 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5926 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5927 after the loop to call ccl_driver at least once (Bug#8619).
5929 2011-12-08 Kenichi Handa <handa@m17n.org>
5931 * ftfont.c (get_adstyle_property): Fix previous change
5934 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5936 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5937 dirs from the default value of EMACSLOADPATH (bug#10208).
5939 2011-12-07 Glenn Morris <rgm@gnu.org>
5941 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5942 installation and source directories as well. (Bug#10208)
5944 2011-12-06 Chong Yidong <cyd@gnu.org>
5946 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5948 2011-12-06 Glenn Morris <rgm@gnu.org>
5950 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5951 as an error, not just -1. (Bug#10217)
5953 2011-12-05 Chong Yidong <cyd@gnu.org>
5955 * keyboard.c (process_special_events): New function.
5956 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5958 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5960 * coding.c (encode_designation_at_bol): Don't use uninitialized
5961 local variable (Bug#9318).
5963 2011-12-05 Kenichi Handa <handa@m17n.org>
5965 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5966 return Qnil (Bug#8046, Bug#10193).
5968 2011-12-05 Kenichi Handa <handa@m17n.org>
5970 * coding.c (encode_designation_at_bol): New args charbuf_end and
5971 dst. Return the number of produced bytes. Callers changed.
5972 (coding_set_source): Return how many bytes coding->source was
5974 (coding_set_destination): Return how many bytes
5975 coding->destination was relocated.
5976 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5977 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5979 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5981 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5982 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5985 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5987 The following changes are to fix Bug#9318.
5989 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5990 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5991 (encode_coding_iso_2022, encode_coding_sjis)
5992 (encode_coding_big5, encode_coding_charset): Use the above macros.
5994 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5996 * lisp.h (process_quit_flag): Fix external declaration.
5998 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6000 Don't macro-inline non-performance-critical code.
6001 * eval.c (process_quit_flag): New function.
6002 * lisp.h (QUIT): Use it.
6004 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6006 * nsfns.m (get_geometry_from_preferences): New function.
6007 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6009 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6011 * emacs.c (Qkill_emacs): Define.
6012 (syms_of_emacs): Initialize it.
6013 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6014 Qquit_flag to `kill-emacs' instead.
6015 (quit_throw_to_read_char): Add parameter `from_signal'.
6016 All callers changed. Call Fkill_emacs if requested and safe.
6017 * lisp.h (QUIT): Call Fkill_emacs if requested.
6019 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6021 * widget.c (update_wm_hints): Return if wmshell is null.
6022 (widget_update_wm_size_hints): New function.
6024 * widget.h (widget_update_wm_size_hints): Declare.
6026 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6027 widget_update_wm_size_hints (Bug#10104).
6029 2011-12-03 Eli Zaretskii <eliz@gnu.org>
6031 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6032 before a newline, prepare the bidi iterator for consuming the
6033 newline, and keep the current paragraph direction. (Bug#10183)
6034 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
6036 2011-12-02 Juri Linkov <juri@jurta.org>
6038 * search.c (Fword_search_regexp): New Lisp function created from
6039 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6040 (Fword_search_backward, Fword_search_forward)
6041 (Fword_search_backward_lax, Fword_search_forward_lax):
6042 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6043 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6045 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6047 * fileio.c (Finsert_file_contents): Move after-change-function call
6048 to before the "handled:" label, since all "goto handled" appear in
6049 cases where the *-change-functions have already been properly called
6052 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6054 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6055 waiting for input. (Bug#10169)
6057 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6059 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6060 verifies glyph row's hash code--we have just reallocated the
6061 glyphs, so their contents can be complete garbage. (Bug#10164)
6063 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
6065 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6067 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6069 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6070 attributes are tested _before_ calling verify_row_hash, to protect
6071 against GCC re-ordering of the tests. (Bug#10164)
6073 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6075 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6077 * xterm.c (handle_one_xevent): Only set async_visible and friends
6078 if net_wm_state_hidden_seen is non-zero (Bug#10002)
6079 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
6080 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6082 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6084 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6085 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6086 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6087 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6088 All uses changed to use GCPRO1 etc.
6089 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6090 Revert to old implementation (i.e., before 2011-03-11).
6092 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6094 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6095 of scroll runs so as to avoid assigning disabled bogus rows and
6096 unnecessary graphics copy operations.
6098 2011-11-27 Eli Zaretskii <eliz@gnu.org>
6100 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6101 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6102 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6103 (malloc, free, realloc, calloc): Redirect to e_* only when
6106 * lisp.h (GCTYPEBITS): Move before first use.
6107 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6108 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6109 this macro definition.
6111 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6114 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6116 * gtkutil.c (xg_create_frame_widgets):
6117 Call gtk_window_set_has_resize_grip (FALSE) if that function is
6118 present with Gtk+ 2.0.
6120 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6122 * fileio.c (Finsert_file_contents): Undo previous change; see
6123 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6125 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6127 Rename locals to avoid shadowing.
6128 * fileio.c (Finsert_file_contents):
6129 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6130 * process.c (wait_reading_process_output):
6131 Rename inner 'proc' to 'p' to avoid shadowing.
6132 Indent for consistency with usual Emacs style.
6134 2011-11-25 Eli Zaretskii <eliz@gnu.org>
6136 * xdisp.c (redisplay_window): If cursor row is not fully visible
6137 after recentering, and scroll-conservatively is set to a large
6138 number, scroll window by a few more lines to make the cursor fully
6139 visible and out of scroll-margin. (Bug#10105)
6140 (start_display): Don't move to the next line if the display should
6141 start at a newline that is part of a display vector or an overlay
6144 2011-11-24 Juri Linkov <juri@jurta.org>
6146 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6147 after the `MagickPingImage' call. (Bug#10112)
6149 2011-11-23 Chong Yidong <cyd@gnu.org>
6151 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6153 2011-11-23 Martin Rudalics <rudalics@gmx.at>
6155 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6156 making another buffer current. (Bug#10114)
6158 2011-11-23 Glenn Morris <rgm@gnu.org>
6160 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6162 2011-11-23 Chong Yidong <cyd@gnu.org>
6164 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6165 using it (Bug#5984).
6167 2011-11-22 Eli Zaretskii <eliz@gnu.org>
6169 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6170 and header-lines, as they don't have one computed for them.
6173 * .gdbinit (prow): Make displayed values more self-explaining.
6174 Add row's hash code.
6176 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6178 * process.c (wait_reading_process_output): Fix asynchrounous
6179 GnuTLS socket handling on some versions of the GnuTLS library.
6180 (wait_reading_process_output): Add comment and URL.
6182 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6184 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6186 2011-11-21 Chong Yidong <cyd@gnu.org>
6188 * window.c (Fnext_window, Fprevious_window): Doc fix.
6190 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6192 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6194 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6196 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6198 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6200 * window.c (Fset_window_combination_limit): Rename argument
6202 (Vwindow_combination_limit): Remove "status" from doc-string.
6204 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6206 * m/ibms390.h: Remove.
6207 * m/ibms390x.h: Don't include "ibms390.h".
6209 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6211 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6212 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6214 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6216 * casetab.c (Fset_case_table):
6217 * charset.c (Fcharset_after): Fix typos.
6219 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6221 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6222 Otherwise, valgrind does not work on some platforms.
6223 Problem reported by Andreas Schwab in
6224 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6225 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6226 is set, removing the need for VIRT_ADDRESS_VARIES.
6227 (PURE_P): Use a more-efficient implementation that needs just one
6228 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6229 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6230 to 4 (xorl, subq, cmpq, setbe).
6231 * alloc.c (pure): Always extern now, since that's the
6232 VIRT_ADDR_VARIES behavior.
6233 (PURE_POINTER_P): Use a single comparison, not two, for
6234 consistency with the new puresize.h.
6235 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6236 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6237 Remove VIRT_ADDR_VARIES no longer needed.
6239 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6241 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6242 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6243 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6244 behave as if the cursor position were at the window margin.
6246 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6247 and the cursor position is out of bounds, behave as if the cursor
6248 position were at the window margin. (Bug#10075)
6250 2011-11-18 Chong Yidong <cyd@gnu.org>
6252 * window.c (Fwindow_combination_limit): Make first argument
6253 non-optional, since it is meaningless for live windows like the
6256 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6258 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6260 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6262 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6263 (graft_intervals_into_buffer): Simplify.
6265 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6267 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6268 hash values of the two rows.
6269 (copy_row_except_pointers): Preserve the used[] arrays and the
6270 hash values of the two rows. (Bug#10035)
6271 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6273 * xdisp.c (row_hash): New function, body extracted from
6274 compute_line_metrics.
6275 (compute_line_metrics): Call row_hash, instead of computing the
6278 * dispnew.c (verify_row_hash): Call row_hash for computing the
6279 hash code of a row, instead of duplicating code from xdisp.c.
6281 * dispextern.h (row_hash): Add prototype.
6283 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6285 * frame.c (delete_frame): Don't delete the terminal when the last
6286 X frame is closed if emacs is built with GTK toolkit.
6288 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6290 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6292 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6294 * window.c (Vwindow_splits): Rename to
6295 Vwindow_combination_resize. Suggested by Juri Linkov.
6296 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6299 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6301 * nsfns.m (Fns_font_name):
6302 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6304 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6306 * window.h (window): Rename slot "nest" to "combination_limit".
6307 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6308 (Fset_window_nest): Rename to Fset_window_combination_limit.
6309 (Vwindow_nest): Rename to Vwindow_combination_limit.
6310 (recombine_windows, make_parent_window, make_window)
6311 (Fsplit_window_internal, saved_window)
6312 (Fset_window_configuration, save_window_save): Rename all
6313 occurrences of window_nest to window_combination_limit.
6315 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6317 * image.c (imagemagick_load_image): Fix typo.
6319 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6321 * xdisp.c (display_line): Move the call to
6322 highlight_trailing_whitespace before the call to
6323 compute_line_metrics, since the latter needs to see the final
6324 faces of all the glyphs to compute ROW's hash value.
6325 Fixes assertion violations in row_equal_p. (Bug#10035)
6327 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6329 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6330 just return (bug#10044).
6332 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6334 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6335 with user-defined heap size. Bump the default size of the temacs
6336 heap to 27MB, to avoid memory warning when running temacs.
6337 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6339 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6340 current_matrix and desired_matrix. (Bug#9990)
6341 (verify_row_hash) [XASSERTS]: New function.
6342 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6343 that the hash value of glyph rows is correct.
6345 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6347 * window.h (window): Remove splits slot.
6348 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6349 (Fdelete_other_windows_internal, make_parent_window)
6350 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6351 (Fset_window_configuration, save_window_save): Don't deal with
6352 split status of windows.
6353 (saved_window): Remove splits slot.
6354 (Vwindow_splits): Rewrite doc-string.
6356 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6358 * xfns.c (unwind_create_frame):
6359 * nsfns.m (unwind_create_frame):
6360 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6361 Vframe_list (Bug#9999).
6363 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6365 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6367 2011-11-11 Kenichi Handa <handa@m17n.org>
6369 * callproc.c (Fcall_process): Set the member dst_multibyte of
6372 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6374 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6375 avoid a crash (bug#9496).
6377 2011-11-09 Chong Yidong <cyd@gnu.org>
6379 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6380 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6382 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6384 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6386 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6388 Avoid some portability problems by eschewing 'extern inline' functions.
6389 The trivial performance wins aren't worth the portability hassles; see
6390 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6392 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6393 (window_box_width, window_box_left, window_box_left_offset)
6394 (window_box_right, window_box_right_offset): Undo previous change,
6395 by removing the "extern"s.
6396 * intervals.c (adjust_intervals_for_insertion)
6397 (adjust_intervals_for_deletion): Undo previous change,
6398 making these static again.
6399 (offset_intervals, temp_set_point_both, temp_set_point)
6400 (copy_intervals_to_string): No longer inline.
6401 * xdisp.c (window_text_bottom_y, window_box_width)
6402 (window_box_height, window_box_left_offset)
6403 (window_box_right_offset, window_box_left, window_box_right)
6404 (window_box): No longer inline.
6406 2011-11-08 Chong Yidong <cyd@gnu.org>
6408 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6409 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6410 Signal an error if not a live window.
6411 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6412 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6414 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6416 * lisp.h (syms_of_abbrev): Remove declaration.
6417 Reported by CHENG Gao <chenggao@royau.me>.
6419 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6421 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6422 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6423 of temacs in GUI mode.
6425 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6427 * window.h: Declare delete_all_child_windows instead of
6428 delete_all_subwindows.
6429 * window.c (Fwindow_nest, Fset_window_nest)
6430 (Fset_window_new_total, Fset_window_new_normal)
6431 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6432 (delete_all_subwindows): Rename to delete_all_child_windows.
6433 (Fdelete_other_windows_internal, Fset_window_configuration):
6434 Call delete_all_child_windows instead of delete_all_subwindows.
6435 * frame.c (delete_frame): Call delete_all_child_windows instead
6436 of delete_all_subwindows.
6438 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6440 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6441 This is also needed for porting to any host where GC_MARK_STACK is
6442 not GC_MAKE_GCPROS_NOOPS.
6443 (which_symbols): Use it.
6445 2011-11-07 Kenichi Handa <handa@m17n.org>
6447 * coding.c (coding_set_destination): Check coding->src_pos only
6448 when coding->src_object is a buffer (bug#9910).
6450 * process.c (send_process): Set the member src_multibyte of coding
6451 to 0 (bug#9911) when sending a unibyte text.
6453 * callproc.c (Fcall_process): Set the member src_multibyte of
6454 process_coding to 0 (bug#9912).
6456 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6458 * xmenu.c (cleanup_widget_value_tree): New function.
6459 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6460 calling free_menubar_widget_value_tree directly (Bug#9830).
6462 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6464 Fix some portability problems with 'inline'.
6465 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6466 (window_box_width, window_box_left, window_box_left_offset)
6467 (window_box_right, window_box_right_offset): Declare extern.
6468 Otherwise, these inline functions do not conform to C99 and
6469 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6470 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6471 * intervals.c (adjust_intervals_for_insertion)
6472 (adjust_intervals_for_deletion): Now extern, because otherwise the
6473 extern inline functions 'offset_intervals' couldn't refer to it.
6474 (static_offset_intervals): Remove.
6475 (offset_intervals): Rewrite using the old contents of
6476 static_offset_intervals. The old version didn't conform to C99
6477 because an extern inline function contained a reference to an
6478 identifier with static linkage.
6480 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6482 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6485 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6487 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6488 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6489 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6490 return Qleft_to_right.
6492 2011-11-06 Chong Yidong <cyd@gnu.org>
6494 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6495 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6496 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6497 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6498 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6499 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6500 (Fwindow_vscroll): Doc fix.
6501 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6502 argument, since it makes no sense to pass a live window and for
6503 consistency with window-child.
6505 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6507 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6510 2011-11-05 Jason Rumney <jasonr@gnu.org>
6512 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6513 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6515 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6516 bitwise arithmetic preventing use of unicode-sip and non-truetype
6519 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6521 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6524 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6525 initialization code to keep similarity to xfns.c after changes
6528 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6530 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6531 (unwind_create_frame): New function (Bug#9943).
6532 (Fx_create_frame): Restructure code to be more similar to the one in
6533 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6534 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6535 Move terminal->reference_count++ just before making the frame official
6538 * nsterm.m (x_free_frame_resources): New function.
6539 (x_destroy_window): Move code to x_free_frame_resources.
6541 * xfns.c (unwind_create_frame): Fix comment.
6542 (Fx_create_frame, x_create_tip_frame):
6543 Move terminal->reference_count++ just before making the frame
6544 official. Move initialization of image_cache_refcount and
6545 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6547 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6549 Support MSVC build with newer versions of Visual Studio.
6550 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6551 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6554 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6555 which are not supported by MSVC.
6556 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6557 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6559 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6561 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6563 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6565 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6567 Support MSVC build with newer versions of Visual Studio.
6568 * w32.c: Don't include w32api.h for MSVC.
6569 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6571 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6572 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6573 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6574 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6576 (alloca) [_MSC_VER]: Define to _alloca.
6578 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6580 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6582 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6584 * xdisp.c (note_mouse_highlight): If either of
6585 previous/next-single-property-change returns nil, treat that as
6586 the beginning or the end of the buffer. (Bug#9955)
6588 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6590 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6591 label is not null (Bug#9951).
6592 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6595 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6597 * window.c (Fwindow_body_size): Mention in the doc string that the
6598 return value is in frame's canonical units. (Bug#9949)
6600 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6602 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6604 * w32fns.c (unwind_create_frame): If needed, free the glyph
6605 matrices of the partially constructed frame. (Bug#9943)
6606 * xfns.c (unwind_create_frame): Likewise.
6608 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6610 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6611 Don't stop backward scan on the continuation glyph, even though
6612 its CHARPOS is positive.
6613 (mouse_face_from_buffer_pos, note_mouse_highlight):
6614 Rename cover_string to disp_string.
6616 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6618 * window.c (temp_output_buffer_show): Don't use
6619 Vtemp_buffer_show_specifiers.
6620 (Vtemp_buffer_show_specifiers): Remove unused variable.
6622 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6624 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6625 past the beginning of the current glyph matrix.
6627 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6629 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6630 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6631 HAVE_GTK3 (Bug#9869).
6633 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6634 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6636 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6638 * xterm.c: Declare x_handle_net_wm_state to return int.
6639 (handle_one_xevent): Check if we are iconified but don't have
6640 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6641 (get_current_wm_state): Return non-zero if not hidden,
6642 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6643 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6644 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6645 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6647 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6649 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6650 so that this new function doesn't get optimized away by a
6651 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6653 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6655 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6657 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6659 Fix the `xbytecode' command.
6660 * .gdbinit (xprintbytestr): New command.
6661 (xwhichsymbols): Rename from `which'; all callers changed.
6662 (xbytecode): Print the byte-code string as well.
6664 2011-10-29 Kim Storm <storm@cua.dk>
6666 * alloc.c (which_symbols): New function.
6668 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6670 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6673 2011-10-29 Glenn Morris <rgm@gnu.org>
6675 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6676 Not clear what it was for, and it causes various bugs. (Bug#9839)
6678 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6680 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6681 possible random value that matches one of those tested as
6682 condition to clear the mouse face.
6684 2011-10-28 Chong Yidong <cyd@gnu.org>
6686 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6688 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6690 * window.c (make_window): Initialize phys_cursor_on_p.
6692 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6694 * lisp.h (struct Lisp_Symbol): Update comments.
6696 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6698 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6700 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6702 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6703 <oslsachem@gmail.com> for helping to debug this.
6705 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6706 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6707 (g_b_init_get_glyph_outline_w): New static variables.
6708 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6709 (GetGlyphOutlineW_Proc): New typedefs.
6710 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6711 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6713 (w32font_open_internal, compute_metrics):
6714 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6715 instead of calling the "wide" APIs directly.
6717 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6719 * w32.h (syms_of_w32font): Add prototype.
6721 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6723 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6724 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6725 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6726 (Fmove_to_window_line): Doc fix.
6728 2011-10-27 Chong Yidong <cyd@gnu.org>
6730 * process.c (make_process): Set gnutls_state to NULL.
6732 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6733 non-NULL, regardless of GNUTLS_INITSTAGE.
6734 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6735 an error. Set process slots as soon as we allocate them.
6737 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6739 2011-10-27 Chong Yidong <cyd@gnu.org>
6741 * gnutls.c (emacs_gnutls_deinit): New function.
6742 Deallocate credentials structures as well as calling gnutls_deinit.
6743 (Fgnutls_deinit, Fgnutls_boot): Use it.
6745 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6746 (deactivate_process): Call emacs_gnutls_deinit.
6748 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6750 * image.c (x_create_x_image_and_pixmap):
6751 * w32.c (sys_rename, w32_delayed_load):
6752 * w32font.c (fill_in_logfont):
6753 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6755 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6757 * w32fns.c (w32_default_color_map): New function,
6758 extracted from Fw32_default_color_map.
6759 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6761 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6763 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6765 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6767 * keyboard.c (test_undefined): New function (bug#9751).
6768 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6770 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6772 * sysdep.c (init_sys_modes): Fix the check for the controlling
6773 terminal (Bug#6649).
6775 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6777 * dispextern.h (struct bidi_it): New member next_en_type.
6779 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6780 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6781 current character, check also for next_en_type being WEAK_EN.
6782 (bidi_resolve_weak): Don't enter the expensive loop if the current
6783 position is before next_en_pos. Record the bidi type of the first
6784 non-ET, non-BN character we find, in addition to its position.
6785 (bidi_level_of_next_char): Invalidate next_en_type when
6786 next_en_pos is over-stepped.
6788 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6790 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6791 * editfns.c: Rewrite current-time-zone so that it invokes
6792 the equivalent of (format-time-string "%Z") to get the time zone name.
6793 This fixes a bug when the time zone name contains characters that
6794 need converting from the system time locale to Emacs internal format.
6795 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6796 that patch fixed format-time-string to do the conversion, but
6797 I forgot to fix current-time-zone.
6798 (format_time_string): New function, containing most of
6799 what Fformat_time_string used to contain.
6800 (Fformat_time_string): Rewrite in terms of format_time_string.
6801 This doesn't change this function's behavior.
6802 (current-time-zone): Rewrite to use format_time_string.
6803 This fixes the bug reported by Michael Schierl in
6804 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6805 Jason Rumney's 2007-06-07 change worked around this bug, but
6807 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6809 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6811 * xdisp.c (start_display): If the character at POS is displayed
6812 via a display vector, reset IT->current.dpvec_index to zero.
6813 (try_window_reusing_current_matrix): If a line ends in a display
6814 vector or the next line starts in a display vector, continue
6815 redrawing the window even though the character position of
6816 start_row was reached.
6819 2011-10-18 Chong Yidong <cyd@gnu.org>
6821 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6822 with nobreak-char-display too.
6824 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6826 Fix part 3 of bug#9771.
6827 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6828 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6829 non-neutral characters if the current character is a paragraph
6830 separator (a.k.a. Newline). This avoids running the same
6831 expensive loop twice, once when we consume the preceding newline
6832 and the other time when the line actually needs to be displayed.
6833 Avoid the loop when we see neutrals on the base embedding level
6834 following a character whose directionality is the same as the
6835 paragraph's. This avoids running the expensive loop when a line
6836 ends in a long sequence of neutrals, like control characters.
6837 Add assertion against STRONG_AL type. Slightly rearrange code
6838 that determines the type of a neutral given the first non-neutral
6840 (bidi_level_of_next_char): Set next_en_pos to zero when
6841 invalidating its info.
6843 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6845 * xdisp.c (push_display_prop): Determine whether to record string
6846 or buffer position by IT->string, not by IT->method. Allow
6847 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6848 (move_it_vertically_backward): Don't look for character position
6849 immediately after the newline when in a continuation line.
6852 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6854 * window.c (coordinates_in_window): Rewrite and delabelize
6855 vertical border check. (Bug#5357) (Bug#9618)
6857 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6859 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6860 errors in XSetWindowBorder (bug#9310).
6862 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6864 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6865 avoid crash when xmalloc overrun checking is enabled.
6867 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6869 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6870 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6871 cursor motion with <left> and <right> arrow keys.
6873 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6874 some callers set that themselves.
6876 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6878 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6879 display string and the previous row comes from the same string and
6880 is empty. (Bug#9739) (Bug#9738)
6882 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6884 * doc.c (get_doc_string): Encode file name (bug#9735).
6886 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6888 * bidi.c (bidi_level_of_next_char):
6889 * xdisp.c (get_visually_first_element): Remove old incorrect
6890 comments regarding the Unicode Line Separator character.
6892 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6894 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6896 * alloc.c (Fgc_status): Do not access beyond zombies array
6897 boundary if nzombies > MAX_ZOMBIES.
6898 * alloc.c (dump_zombies): Add missing format specifier.
6900 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6902 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6903 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6905 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6906 Some packages use them to denote characters with modifiers.
6908 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6910 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6911 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6912 matching a pp-number. Rename parameter var to var1.
6914 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6916 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6918 2011-10-08 Glenn Morris <rgm@gnu.org>
6920 * callint.c (Fcall_interactively): Give a more explicit error for the
6921 'c' case with a non-character input. (Bug#8479)
6923 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6925 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6927 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6928 lines that are hscrolled on the left.
6930 * dispnew.c (buffer_posn_from_coords): Account for a possible
6931 presence of header-line. (Bug#4426)
6933 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6935 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6936 Don't advertise functionality which we discourage or doesn't work.
6938 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6940 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6941 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6942 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6943 this makes Emacs dump core during garbage collection on rare
6944 occasions. sizeof is obviously inferior to offsetof here, so
6945 stick with offsetof.
6946 (GC_POINTER_ALIGNMENT): New macro.
6947 (mark_memory): Omit 3rd (offset) arg; caller changed.
6948 Don't assume EMACS_INT alignment is the same as pointer alignment.
6950 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6952 * keyboard.c (read_key_sequence_remapped): New var.
6953 (read_key_sequence): Compute remapping in the right buffer.
6954 (command_loop_1): Use read_key_sequence's remapping directly.
6956 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6958 * dired.c (file_name_completion): Don't expand file name.
6959 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6960 before checking file name handler.
6962 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6963 they've been requested explicitly (bug#9591).
6965 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6967 * keymap.c (Fsingle_key_description): Use make_specified_string
6968 instead of build_string to build string from push_key_description.
6971 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6973 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6974 This fixes a Y2038 bug on 64-bit hosts.
6975 * buffer.c (reset_buffer):
6976 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6977 (Fclear_buffer_auto_save_failure):
6978 Use 0, not -1, to represent an unset failure time, since time_t
6979 might not be signed.
6981 Remove dependency on glibc malloc internals.
6982 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6983 Move back here from lisp.h, but with their new implementations.
6984 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6985 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6986 * charset.c (charset_table_init): New static var.
6987 (syms_of_charset): Use it instead of xmalloc. This removes a
6988 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6989 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6990 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6991 Move back to alloc.c.
6992 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6993 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6995 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6997 * nsterm.m (windowDidResize): Call x_set_window_size only when
6998 ns_in_resize is true. Otherwise set pixelwidth/height and
6999 call change_frame_size (Bug#9628).
7001 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7003 Port --enable-checking=all to Fedora 14 x86-64.
7004 * charset.c (syms_of_charset): Also account for glibc malloc's
7005 internal overhead when calculating the initial malloc maximum.
7007 Port --enable-checking=all to Fedora 14 x86.
7008 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7010 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7011 (overrun_check_realloc, overrun_check_free):
7012 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7013 That way, xmalloc returns a properly-aligned pointer even if
7014 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7015 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7016 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7017 into account when calculating the initial malloc maximum.
7018 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7019 Move here from alloc.c, so that charset.c can use it too.
7020 Properly align; the old code wasn't right for common 32-bit hosts
7021 when configured with --enable-checking=all.
7022 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7023 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7025 2011-09-29 Eli Zaretskii <eliz@gnu.org>
7027 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
7030 2011-09-28 Eli Zaretskii <eliz@gnu.org>
7032 * xdisp.c (compute_display_string_end): If there's no display
7033 string at CHARPOS, return -1.
7035 * bidi.c (bidi_fetch_char): When compute_display_string_end
7036 returns a negative value, treat the character as a normal
7037 character not covered by a display string. (Bug#9624)
7039 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
7041 * lread.c (Fread_from_string): Fix typo in docstring.
7043 2011-09-27 Eli Zaretskii <eliz@gnu.org>
7045 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7046 newline, reseat the iterator instead of bidi-iterating there one
7047 character at a time. (Bug#9610)
7048 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7049 TO_CHARPOS if the bidi iterator is at base embedding level.
7051 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7053 * lread.c (readevalloop): Use correct code for NBSP.
7054 (read1): Likewise. (Bug#9608)
7056 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
7058 * dbusbind.c (Fdbus_register_signal): When service is not
7059 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7061 2011-09-25 Glenn Morris <rgm@gnu.org>
7063 * buffer.c (truncate-lines): Doc fix.
7065 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
7067 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7068 (Fset_window_next_buffers): Doc fix.
7070 2011-09-24 Glenn Morris <rgm@gnu.org>
7072 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7074 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7076 Fix minor problems found by static checking.
7077 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
7078 * indent.c (Fvertical_motion): Fix == vs = typo.
7080 2011-09-24 Eli Zaretskii <eliz@gnu.org>
7082 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7083 Default value is now t. Doc fix.
7085 * indent.c (Fvertical_motion): Compute and apply the overshoot
7086 logic when moving up, not only when moving down. Fix the
7087 confusing name and values of the it_overshoot_expected variable;
7088 logic changes accordingly. (Bug#9254) (Bug#9549)
7090 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7091 CHARPOS is covered by a display string which includes newlines.
7092 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7093 is covered by a display string with embedded newlines.
7095 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
7097 * dbusbind.c (Fdbus_register_signal): Add match rule to
7098 Vdbus_registered_objects_table. (Bug#9581)
7099 (Fdbus_register_method, Vdbus_registered_objects_table):
7102 2011-09-24 Jim Meyering <meyering@redhat.com>
7104 do not ignore write error for any output size
7105 The previous change was incomplete.
7106 While it makes emacs --batch detect the vast majority of stdout
7107 write failures, errors were still ignored whenever the output size is
7108 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7109 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7110 && echo FAIL: ignored write error
7111 FAIL: ignored write error
7112 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7113 && echo FAIL: ignored write error
7114 FAIL: ignored write error
7115 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7117 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7119 * emacs.c (Fkill_emacs): In noninteractive mode exit
7120 non-successfully if a write error occurred on stdout. (Bug#9574)
7122 2011-09-21 Eli Zaretskii <eliz@gnu.org>
7124 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7127 * dispextern.h (struct it): Update the comment documenting what
7130 2011-09-20 Eli Zaretskii <eliz@gnu.org>
7132 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7133 a display string, extend search for cursor position to end of row.
7134 (find_row_edges): If the row ends in a newline from a display
7135 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7136 Handle the case of a display string with multiple newlines.
7137 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7138 non-empty line. Fixes confusing cursor motion with arrow keys at
7139 the beginning of a line that starts with whitespace.
7141 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7143 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7146 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
7148 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7151 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7153 * xdisp.c (display_line): Record maximum and minimum buffer
7154 positions even if no glyphs were produced (e.g., by a zero-width
7155 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7156 buffer positions that will be removed from the glyph row because
7158 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7159 column is beyond frame width: don't subtract 1 "pixel" when
7160 computing width of the stretch.
7161 (reseat_at_next_visible_line_start): Undo the change made on
7162 2011-09-17 that saved paragraph information and restored it after
7163 the call to `reseat'. (Bug#9545)
7165 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7167 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7168 and turn window cursor on if cleared (Bug#9415).
7170 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7172 * search.c (boyer_moore): Take unibyte characters from pattern
7173 literally. (Bug#9458)
7175 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7177 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7179 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7181 Fix minor problem found by static checking.
7182 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7183 initialized, to pacify gcc -Wuninitialized.
7185 * fileio.c: Report proper errno when syscall falls.
7186 (Finsert_file_contents): Save and restore errno,
7187 so that report_file_error outputs the correct diagnostic.
7188 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7190 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7192 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7194 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7196 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7197 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7199 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7201 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7202 about the current paragraph and restore it after the call to reseat.
7204 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7205 (bidi_find_paragraph_start): Search back for paragraph beginning
7206 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7207 (bidi_move_to_visually_next): Only trigger paragraph-related
7208 computations when the last character is a newline or at EOB, not
7209 just any NEUTRAL_B. (Bug#9470)
7211 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7212 truncated lines if point is covered by a display string. (Bug#9524)
7214 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7216 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7217 (cons_to_x_long): New function.
7218 (lisp_data_to_selection_data): Use it. Correct the test for
7219 short-versus-long data; it was negated. Break out of vector
7220 loop, for efficiency, when a long datum is discovered.
7222 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7224 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7226 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7228 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7229 GCC PR/17406) by declaring this function with external scope.
7231 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7233 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7234 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7236 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7238 * editfns.c (Fformat): Correctly handle text properties on "%%".
7240 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7242 * xterm.c (x_draw_composite_glyph_string_foreground):
7243 * w32term.c (x_draw_composite_glyph_string_foreground):
7244 * term.c (encode_terminal_code):
7245 * composite.c (composition_update_it, get_composition_id):
7246 * xdisp.c (get_next_display_element)
7247 (fill_composite_glyph_string): Add comments about special meaning
7248 of TAB characters in a composition.
7250 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7252 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7253 This occurs when processing a multibyte format.
7254 Problem reported by Wolfgang Jenker.
7256 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7258 * xdisp.c (try_cursor_movement): Only check for exact match if
7259 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7261 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7263 Remove unused external symbols.
7264 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7265 * xdisp.c (calc_pixel_width_or_height): Now static.
7266 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7267 * indent.c (check_display_width):
7268 * w32term.c: Fix comment to match code.
7269 * xterm.c, xterm.h (x_catching_errors): Remove.
7271 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7273 * xselect.c: Use signed conversions more consistently (Bug#9498).
7274 (selection_data_to_lisp_data): Assume incoming selection data are
7275 signed integers, not unsigned. This is to be consistent with
7276 outgoing selection data, which was modified to use signed integers
7277 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7278 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7279 expects long, not unsigned long.
7281 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7283 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7284 computation of loop end. Reported by Johan Bockgård
7287 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7289 * frame.c (Fother_visible_frames_p): Function deleted.
7291 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7293 * indent.c (compute_motion): Process display vector front to back
7294 rather than the other way around. (Bug#2496)
7296 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7298 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7300 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7302 * minibuf.c (Fread_from_minibuffer): Doc fix.
7304 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7306 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7307 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7309 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7311 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7312 value for non-existent files.
7314 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7316 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7317 set its "size" to -1. This will set the modtime_size field of
7318 the corresponding buffer to -1, which is what
7319 verify-visited-file-modtime expects for files that do not exist.
7322 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7324 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7326 * lisp.h: ... from here. push_key_description is no longer
7327 defined in keyboard.c, so its declaration should not be in
7328 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7329 logically belongs with push_key_description.
7331 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7333 * buffer.h: Include <sys/types.h> instead of <time.h>.
7334 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7335 Problem reported by Herbert J. Skuhra.
7337 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7339 * xml.c (parse_region): Make the parsing work for
7340 non-comment-starting XML files again (bug#9144).
7342 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7344 * image.c (gif_load): Fix calculation of bottom and right corner.
7347 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7349 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7350 redisplay in small windows.
7352 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7354 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7356 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7358 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7359 Operate on live windows only.
7361 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7363 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7365 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7367 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7368 only under bidi iteration.
7370 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7372 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7374 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7376 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7377 Without this fix, the command to link temacs failed due to an
7378 undefined symbol __builtin_isnan. This is because
7379 /usr/include/iso/math_c99.h #defines isnan(x) to
7380 __builtin_isnan(x), but the bundled gcc, which identifies itself
7381 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7383 * floatfns.c (isnan): #undef, and then #define to a clone of
7385 (Fisnan): Always define, since it's always available now.
7386 (syms_of_floatfns): Always define isnan at the Lisp level.
7388 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7390 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7392 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7394 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7395 The previous code assumed that file offsets (off_t values) fit in
7396 EMACS_INT variables, which is not true on typical 32-bit hosts.
7397 The code messed up by falsely reporting buffer overflow in cases
7398 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7399 when "big" contains more than 2**29 bytes, even though this
7400 inserts just one byte and does not overflow the buffer.
7401 (Finsert_file_contents): Store file offsets as off_t
7402 values, not as EMACS_INT values. Check for overflow when
7403 converting between EMACS_INT and off_t. When checking for
7404 buffer overflow or for overlap, take the offsets into account.
7405 Don't use EMACS_INT for small values where int suffices.
7406 When checking for overlap, fix a typo: ZV was used where
7407 ZV_BYTE was intended.
7408 (Fwrite_region): Don't assume off_t fits into 'long'.
7409 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7411 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7413 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7415 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7417 sprintf-related integer and memory overflow issues (Bug#9412).
7419 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7420 (esprintf, exprintf, evxprintf): New functions.
7421 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7422 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7423 (modify_event_symbol): Do not assume that the length of
7424 name_alist_or_stem is safe to alloca and fits in int.
7425 (Fexecute_extended_command): Likewise for function name and binding.
7426 (Frecursion_depth): Wrap around reliably on integer overflow.
7427 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7428 since some callers pass EMACS_INT values.
7429 (Fsingle_key_description): Don't crash if symbol name contains more
7430 than MAX_ALLOCA bytes.
7431 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7432 (get_minibuffer): Arg is now EMACS_INT, not int.
7433 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7434 (esprintf, exprintf, evxprintf): New decls.
7435 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7437 * dbusbind.c (signature_cat): New function.
7438 (xd_signature, Fdbus_register_signal):
7439 Do not overrun buffer; instead, report string overflow.
7441 * dispnew.c (add_window_display_history): Don't overrun buffer.
7442 Truncate instead; this is OK since it's just a log.
7444 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7445 even if the time zone offset is outlandishly large.
7446 Don't mishandle offset == INT_MIN.
7448 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7449 when creating daemon; the previous buffer-overflow check was incorrect.
7451 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7452 which has the guts of the old verror function.
7454 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7455 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7457 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7458 (font_unparse_xlfd): Don't blindly alloca long strings.
7459 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7460 fits in int, when using sprintf. Use single snprintf to count
7461 length of string rather than counting it via multiple sprintfs;
7462 that's simpler and more reliable.
7463 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7464 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7465 sprintf, in case result does not fit in int.
7467 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7468 (fontset_from_font): Print it.
7470 * frame.c (tty_frame_count): Now printmax_t, not int.
7471 (make_terminal_frame, set_term_frame_name): Print it.
7472 (x_report_frame_params): In X, window IDs are unsigned long,
7473 not signed long, so print them as unsigned.
7474 (validate_x_resource_name): Check for implausibly long names,
7475 and don't assume name length fits in 'int'.
7476 (x_get_resource_string): Don't blindly alloca invocation name;
7477 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7480 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7481 (xg_check_special_colors, xg_set_geometry):
7482 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7484 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7485 Use esprintf, not sprintf, in case result does not fit in int.
7487 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7488 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7489 it as a large positive number.
7490 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7491 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7493 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7494 in case result does not fit in int.
7496 * print.c (float_to_string): Detect width overflow more reliably.
7497 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7498 buffer overrun. Don't assume list length fits in 'int'. Treat
7499 print length of 0 as 0, not as infinity; to be consistent with other
7500 uses of print length in this function. Don't overflow print length
7501 index. Don't assume hash table size fits in 'long', or that
7502 vectorlike size fits in 'unsigned long'.
7504 * process.c (make_process): Use printmax_t, not int, to format
7505 process-name gensyms.
7507 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7509 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7510 to avoid potential buffer overrun.
7512 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7513 if X resource line is longer than 512 bytes.
7515 * xfns.c (x_window): Make sprintf buffer a bit bigger
7516 to avoid potential buffer overrun.
7518 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7520 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7522 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7524 Integer overflow fixes for scrolling, etc.
7525 Without these, Emacs silently mishandles large integers sometimes.
7526 For example, "C-u 4294967297 M-x recenter" was treated as if
7527 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7529 * xdisp.c (try_window_id): Check Emacs fixnum range before
7530 converting to 'int'.
7532 * window.c (window_scroll_line_based, Frecenter):
7533 Check that an Emacs fixnum is in range before assigning it to 'int'.
7534 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7535 values converted from Emacs fixnums.
7536 (Frecenter): Don't wrap around a line count if it is out of 'int'
7537 range; instead, treat it as an extreme value.
7538 (Fset_window_configuration, compare_window_configurations):
7539 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7541 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7542 that can exceed INT_MAX. Check that EMACS_INT value is in range
7543 before assigning it to the (possibly-narrower) index.
7544 (match_limit): Don't assume that a fixnum can fit in 'int'.
7546 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7549 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7550 (Fvertical_motion): Don't wrap around LINES values that don't fit
7551 in 'int'. Instead, treat them as extreme values. This is good
7552 enough for windows, which can't have more than INT_MAX lines anyway.
7554 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7556 * Require libxml/parser.h to avoid compilation warning.
7558 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7560 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7561 since this reportedly can destroy thread storage.
7563 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7565 * syntax.c (find_defun_start): Update all cache variables if
7566 exiting early (Bug#9401).
7568 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7570 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7572 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7573 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7574 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7576 * term.c (tty_append_glyph): New function.
7577 (produce_stretch_glyph): Static function and its prototype deleted.
7579 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7582 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7584 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7585 when checking :margin (Bug#9390).
7586 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7587 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7588 so that the name doesn't mislead. All uses changed.
7590 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7592 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7595 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7597 * xdisp.c (move_it_to): Don't bail out early when reaching
7598 position beyond to_charpos, if we are scanning backwards.
7599 (move_it_vertically_backward): When DY == 0, make sure we get to
7600 the first character in the line after the newline.
7602 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7604 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7605 (ccl_driver): Do not generate an out-of-range pointer.
7606 (Fccl_execute_on_string): Remove unnecessary check for
7607 integer overflow, noted by Stefan Monnier in
7608 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7609 Remove a FIXME that didn't need fixing.
7610 Simplify the newly-introduced buffer reallocation code.
7612 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7614 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7616 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7618 Integer and memory overflow issues (Bug#9196).
7620 * doc.c (get_doc_string): Rework so that
7621 get_doc_string_buffer_size is the actual buffer size, rather than
7622 being 1 less than the actual buffer size; this makes xpalloc more
7625 * image.c (x_allocate_bitmap_record, cache_image):
7626 * xselect.c (Fx_register_dnd_atom):
7627 Simplify previous changes by using xpalloc.
7629 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7630 since either will do and ptrdiff_t is convenient with xpalloc.
7632 * charset.c (charset_table_size)
7633 (struct charset_sort_data.priority): Now ptrdiff_t.
7634 (charset_compare): Don't overflow if priorities differ greatly.
7635 (Fsort_charsets): Don't assume list length fits in int.
7636 Check for size-calculation overflow when allocating sort data.
7637 (syms_of_charset): Allocate an initial charset table that is
7638 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7640 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7642 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7643 The actual value is always <= INT_MAX, and leaving it unsigned made
7644 overflow checking harder.
7646 * dispextern.h (struct glyph_matrix.rows_allocated)
7647 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7648 with xpalloc. The values are still always <= INT_MAX.
7650 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7652 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7653 (SAFE_NALLOCA): New macro.
7655 * region-cache.c (struct boundary.pos, find_cache_boundary)
7656 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7657 (set_cache_region, invalidate_region_cache)
7658 (revalidate_region_cache, know_region_cache, region_cache_forward)
7659 (region_cache_backward, pp_cache):
7660 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7661 so that ptrdiff_t * can be passed to xpalloc.
7662 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7663 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7664 (pp_cache): Don't assume cache_len fits in int.
7665 * region-cache.h: Adjust extern decls to match.
7667 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7668 EMACS_INT, since either will do, for xpalloc.
7670 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7671 (xnmalloc, xnrealloc, xpalloc): New functions.
7673 * bidi.c (bidi_shelve_header_size): New constant.
7674 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7675 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7677 * bidi.c (bidi_cache_shrink):
7678 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7680 Don't update size of array until after memory allocation succeeds,
7681 because xmalloc/xrealloc may not return.
7682 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7683 now that we have proper integer overflow checking.
7684 (record_overlay_string, overlay_strings): Catch overflows when
7685 calculating size of overlay_str_buf.
7687 * callproc.c (Fcall_process): Check for size overflow when
7688 calculating size of args2.
7689 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7690 Normally we prefer signed values, but sticking with ptrdiff_t would
7691 require adding more-complicated checks.
7693 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7694 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7695 Redo buffer-overflow calculations to avoid integer overflow.
7696 Add a FIXME comment where memory seems to be over-allocated.
7698 * character.c (Fstring): Check for size-calculation overflow.
7700 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7701 unnecessary integer overflow. Check for size overflow.
7702 (encode_coding_object): Don't update size until xmalloc succeeds.
7704 * composite.c (get_composition_id): Check for overflow in glyph
7705 length calculations.
7707 Integer and memory overflow fixes for display code.
7708 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7709 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7710 (scrolling_window): Check for overflow in size calculations.
7711 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7712 Don't assume glyph table len fits in int.
7713 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7714 (row_table_size): Now ptrdiff_t, not int.
7715 (scrolling_window): Avoid overflow in size calculations.
7716 Don't update size until allocation succeeds.
7717 * fns.c (concat): Check for overflow in size calculations.
7718 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7719 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7720 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7722 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7723 (get_doc_string): Check for size calculation overflow.
7724 Don't update size until allocation succeeds.
7725 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7726 EMACS_INT, where ptrdiff_t will do.
7727 (Fsubstitute_command_keys): Check for string overflow.
7729 * editfns.c (set_time_zone_rule): Don't assume environment length
7731 (message_length): Now ptrdiff_t, not int.
7732 (Fmessage_box): Don't update size until allocation succeeds.
7733 Don't assume message length fits in int.
7734 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7736 * emacs.c (main): Do not reallocate argv, since there is a null at
7737 the end that can be overwritten, and this way there's no need to
7738 worry about size-calculation overflow.
7739 (sort_args): Check for size-calculation overflow.
7741 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7743 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7745 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7746 (x_set_scroll_bar_width, x_figure_window_size):
7747 Check for integer overflow.
7748 (x_set_alpha): Do not assume XINT fits in int.
7750 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7751 This is for the members text_lines, text_cols, total_lines, total_cols,
7752 where the system imposes an 'int' limit.
7754 * fringe.c (Fdefine_fringe_bitmap):
7755 Don't update size until alloc works.
7757 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7758 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7760 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7761 Check for size-calculation overflow.
7762 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7763 do, as we prefer signed integers.
7764 (id_to_widget.max_size, id_to_widget.used)
7765 (xg_store_widget_in_map, xg_remove_widget_from_map)
7766 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7767 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7768 Use and return ptrdiff_t, not int.
7769 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7770 * gtkutil.h: Change prototypes to match the above.
7772 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7773 are duplicate now that they've been promoted to lisp.h.
7774 (x_allocate_bitmap_record, x_alloc_image_color)
7775 (make_image_cache, cache_image, xpm_load):
7776 Don't update size until alloc is done.
7777 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7779 Check for size calculation overflow.
7780 (ct_colors_allocated_max): New constant.
7781 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7784 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7785 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7786 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7787 Use ptrdiff_t, not int, to count maps.
7788 (read_char_minibuf_menu_prompt): Check for overflow in size
7789 calculations. Don't update size until allocation succeeds.
7790 Redo calculations to avoid overflow.
7791 * keyboard.h: Change prototypes to match the above.
7793 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7795 (current_minor_maps): Check for size calculation overflow.
7796 * keymap.h: Change prototypes to match the above.
7798 * lread.c (read1, init_obarray): Don't update size until alloc done.
7800 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7801 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7803 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7804 Now ptrdiff_t, not int.
7805 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7806 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7808 * process.c (Fnetwork_interface_list): Check for overflow
7809 in size calculation.
7811 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7813 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7814 overflow. Don't bother calling xmalloc when xrealloc will do.
7816 * search.c (Freplace_match): Check for size calculation overflow.
7817 (Fset_match_data): Don't assume list lengths fit in 'int'.
7819 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7820 for command line length. Do not attempt to address one before the
7821 beginning of an array, as that's not portable.
7823 * term.c (max_frame_lines): Remove; unused.
7824 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7826 (encode_terminal_code, calculate_costs): Check for size
7827 calculation overflow.
7828 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7829 table lengths and related sizes. Don't update size until alloc
7830 done. Redo calculations to avoid overflow.
7831 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7833 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7834 subtracting pointers.
7835 (gobble_line): Check for overflow more carefully. Don't update size
7838 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7839 Don't update size until alloc done.
7840 Redo size calculations to avoid overflow.
7841 Check for size calculation overflow.
7842 (main) [DEBUG]: Fix typo in invoking tparam1.
7844 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7845 Use ptrdiff_t, not int, for sizes.
7846 (store_mode_line_noprop_char): Don't update size until alloc done.
7848 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7849 Use ptrdiff_t, not int, for sizes.
7850 (Finternal_make_lisp_face, cache_face):
7851 Check for size calculation overflow.
7852 (cache_face): Treat size calculation overflows as if they were
7853 memory exhaustion (the usual treatment), rather than aborting.
7855 * xfns.c (x_encode_text, x_set_name_internal)
7856 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7857 sizes, since they can exceed INT_MAX in size. Check for size
7858 calculation overflow.
7860 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7861 (xg_select): Check for size calculation overflow.
7862 Don't update size until alloc done.
7864 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7865 as sprintf is limited to int lengths.
7867 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7868 (X_LONG_MIN): New macros.
7869 Use them to make the following changes clearer.
7870 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7871 This change doesn't affect the value now, but it may help remind
7872 future maintainers not to raise the value too much later.
7873 (SELECTION_QUANTUM): Remove, replacing with ...
7874 (selection_quantum): ... new function, which avoids overflow.
7876 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7877 assumption that selection length fits in 'int'.
7878 (x_reply_selection_request, x_handle_selection_request)
7879 (x_get_window_property, receive_incremental_selection)
7880 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7881 (lisp_data_to_selection_data, clean_local_selection_data):
7882 Use ptrdiff_t, not int, to record length of selection.
7883 (x_reply_selection_request, x_get_window_property)
7884 (receive_incremental_selection, x_property_data_to_lisp):
7885 Redo calculations to avoid overflow.
7886 (x_reply_selection_request): When sending hint, ceiling it at
7887 X_LONG_MAX rather than relying on wraparound overflow to send
7889 (x_get_window_property, receive_incremental_selection)
7890 (lisp_data_to_selection_data, x_property_data_to_lisp):
7891 Check for size-calculation overflow.
7892 (x_get_window_property, receive_incremental_selection)
7893 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7894 Don't store size until memory allocation succeeds.
7895 (x_get_window_property): Plug memory leak on memory exhaustion.
7896 Don't double-block input; malloc is safe here. Don't assume 2**34
7897 - 4 fits in unsigned long. Add an xassert to check
7898 XGetWindowProperty overflow. Be more careful about overflow
7899 calculations, and distinguish size from memory overflow better.
7900 (receive_incremental_selection): When tracing, don't assume
7901 unsigned int is less than INT_MAX.
7902 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7903 harmful) conversions of unsigned short to int.
7904 (lisp_data_to_selection_data): Don't assume that integers
7905 in the range -65535 through -1 fit in an X unsigned short.
7906 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7907 result parameters unless successful. Rely on cons_to_unsigned
7908 to report problems with elements; the old code wasn't right anyway.
7909 (x_check_property_data): Check for int overflow; we cannot use
7910 a wider type due to X limits.
7911 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7913 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7915 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7916 (x_term_init): Check for size calculation overflow.
7917 (x_color_cells): Don't store size until memory allocation succeeds.
7918 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7919 Don't assume alloca size is less than MAX_ALLOCA.
7920 (x_term_init): Don't assume length fits in int (sprintf is limited
7923 Use ptrdiff_t for composition IDs.
7924 * character.c (lisp_string_width):
7925 * composite.c (composition_table_size, n_compositions)
7926 (get_composition_id, composition_gstring_from_id):
7927 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7928 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7929 * window.c (Frecenter):
7930 Use ptrdiff_t, not int, for composition IDs.
7931 * composite.c (get_composition_id): Check for integer overflow.
7932 * composite.h: Adjust prototypes to match the above changes.
7934 Use ptrdiff_t for hash table indexes.
7935 * category.c (hash_get_category_set):
7936 * ccl.c (ccl_driver):
7937 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7938 * coding.c (coding_system_charset_list, detect_coding_system):
7939 * coding.h (struct coding_system.id):
7940 * composite.c (get_composition_id, gstring_lookup_cache):
7941 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7942 * image.c (xpm_get_color_table_h):
7943 * lisp.h (hash_lookup, hash_put):
7944 * minibuf.c (Ftest_completion):
7945 Use ptrdiff_t for hash table indexes, not int (which is too
7946 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7947 32-bit --with-wide-int hosts).
7949 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7950 Add a FIXME comment about memory leaks.
7951 (syms_of_charset): Don't assume xmalloc returns.
7953 Don't assume that stated character widths fit in int.
7954 * character.c (Fchar_width, c_string_width, lisp_string_width):
7955 * character.h (CHAR_WIDTH):
7956 * indent.c (MULTIBYTE_BYTES_WIDTH):
7957 Use sanitize_char_width to avoid undefined and/or bad behavior
7958 with outlandish widths.
7959 * character.h (sanitize_tab_width): Rename from sanitize_width,
7960 now that we have two such functions. All uses changed.
7961 (sanitize_char_width): New inline function.
7963 Don't assume that tab-width fits in int.
7964 * character.h (sanitize_width): New inline function.
7965 (SANE_TAB_WIDTH): New macro.
7966 (ASCII_CHAR_WIDTH): Use it.
7967 * indent.c (sane_tab_width): Remove. All uses replaced by
7968 SANE_TAB_WIDTH (current_buffer).
7969 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7971 * fileio.c: Integer overflow issues with file modes.
7972 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7974 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7975 Remove unreachable code.
7976 (read_hex, load_charset_map_from_file): Check for integer overflow.
7978 * xterm.c: Don't go over XClientMessageEvent limit.
7979 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7980 (x_send_scroll_bar_event): Likewise. Check that the size does not
7981 exceed limits imposed by XClientMessageEvent, as well as the usual
7982 ptrdiff_t and size_t limits.
7984 * keyboard.c: Overflow, signedness and related fixes.
7985 (make_lispy_movement): Use same integer type in forward decl
7986 that is used in the definition.
7987 (read_key_sequence, keyremap_step):
7988 Change bufsize argument back to int, undoing my 2011-03-30 change.
7989 We prefer signed types, and int is wide enough here.
7990 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7991 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7992 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7993 length, not size_t. Use ptrdiff_t for index, not int.
7994 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7995 possibility of integer overflow.
7997 Overflow, signedness and related fixes for images.
7999 * dispextern.h (struct it.stack[0].u.image.image_id)
8000 (struct_it.image_id, struct image.id, struct image_cache.size)
8001 (struct image_cache.used, struct image_cache.ref_count):
8002 * gtkutil.c (update_frame_tool_bar):
8003 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8004 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8005 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8006 * nsmenu.m (update_frame_tool_bar):
8007 * xdisp.c (calc_pixel_width_or_height):
8008 * xfns.c (image_cache_refcount):
8009 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8010 on typical 64-bit hosts.
8012 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8013 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8014 Omit unnecessary casts to int.
8015 (parse_image_spec): Check that integers fall into 'int' range
8016 when the callers expect that.
8017 (image_ascent): Redo ascent calculation to avoid int overflow.
8018 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8019 (lookup_image): Remove unnecessary tests.
8020 (xbm_image_p): Locals are now of int, not EMACS_INT,
8021 since parse_image_check makes sure they fit into int.
8022 (png_load, gif_load, svg_load_image):
8023 Prefer int to unsigned where either will do.
8024 (tiff_handler): New function, combining the cores of the
8025 old tiff_error_handler and tiff_warning_handler.
8026 This function is rewritten to use vsnprintf and thereby avoid
8027 stack buffer overflows. It uses only the features of vsnprintf
8028 that are common to both POSIX and native Microsoft.
8029 (tiff_error_handler, tiff_warning_handler): Use it.
8030 (tiff_load, gif_load, imagemagick_load_image):
8031 Don't assume :index value fits in 'int'.
8032 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8033 (imagemagick_load_image): Check that crop parameters fit into
8034 the integer types that MagickCropImage accepts. Don't assume
8035 Vimagemagick_render_type has a nonnegative value. Don't assume
8036 size_t fits in 'long'.
8037 (gs_load): Use printmax_t to print the widest integers possible.
8038 Check for integer overflow when computing image height and width.
8040 2011-08-26 Eli Zaretskii <eliz@gnu.org>
8042 * xdisp.c (redisplay_window): Don't force window start if point
8043 will be invisible in the resulting window. (Bug#9324)
8045 2011-08-25 Eli Zaretskii <eliz@gnu.org>
8047 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8048 the display spec is of the form `(space ...)'.
8049 (handle_display_spec): Return the value returned by
8050 handle_single_display_spec, not just 1 or zero.
8051 (handle_single_display_spec): If the display spec is of the form
8052 `(space ...)', and specifies display in the text area, return 2
8054 (try_cursor_movement): Check for the need to scroll more
8055 accurately, and prefer exact match for point under bidi.
8056 Don't advance `row' beyond the last row of the window.
8058 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8059 into disp_prop; all users changed.
8061 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8062 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8063 for the text covered by the display property.
8065 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
8067 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8068 Change return value to nil.
8069 (Frecord_buffer): Delete unused function.
8071 2011-08-24 Eli Zaretskii <eliz@gnu.org>
8073 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8074 buffers, return left-to-right.
8075 (set_cursor_from_row): Consider candidate row a win if its glyph
8076 represents a newline and point is on that newline. Fixes cursor
8077 positioning on the newline at EOL of R2L text within L2R
8078 paragraph, and vice versa.
8079 (try_cursor_movement): Check continued rows, in addition to
8080 continuation rows. Fixes unwarranted scroll when point enters a
8081 continued line of R2L text within an L2R paragraph, or vice versa.
8082 (cursor_row_p): Consider the case of point being equal to
8083 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8084 from the end of a short line to the beginning of a continued line
8085 of R2L text within L2R paragraph.
8086 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8087 composed characters.
8089 * bidi.c (bidi_check_type): Use xassert.
8090 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8093 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8095 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8098 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
8100 * nsfont.m (ns_otf_to_script): Fix typo.
8102 2011-08-22 Kenichi Handa <handa@m17n.org>
8104 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8105 extra slot even if the purpose is char-code-property-table.
8107 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8109 * xdisp.c (redisplay_window): When computing centering_position,
8110 account for the height of the header line. (Bug#8874)
8112 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8113 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8114 candidate is selected by the mouse, and that candidate has a
8115 composed character under the mouse.
8117 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8118 coordinates reported by pos-visible-in-window-p for a composed
8119 character in column zero.
8121 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8123 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8125 2011-08-22 Eli Zaretskii <eliz@gnu.org>
8127 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8128 consider it a hit if to_charpos is anywhere in the range of the
8129 composed buffer positions.
8131 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
8133 * image.c (gif_load): Don't assume that each subimage has the same
8134 dimensions as the base image. Handle disposal method that is
8135 "undefined" by the gif spec (Bug#9335).
8137 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
8139 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
8140 (Fcondition_case): Document `debug' symbol in error handler.
8142 2011-08-19 Eli Zaretskii <eliz@gnu.org>
8144 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8145 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8146 from an Org mode buffer to a Speedbar frame.
8148 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8149 a composition, take its buffer position from IT->cmp_it.charpos.
8150 Fixes cursor positioning at the beginning of a line that begins
8151 with a composed character.
8153 2011-08-18 Eli Zaretskii <eliz@gnu.org>
8155 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8156 character bidirectional type, use STRONG_L instead. Fixes crashes
8157 in a buffer produced by `describe-categories'.
8159 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8160 members before the level stack, so they would be saved and
8161 restored when copying iterator state. Fixes incorrect reordering
8162 around TABs covered by display properties.
8164 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8166 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
8168 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8170 * eval.c (internal_condition_case, internal_condition_case_1)
8171 (internal_condition_case_2, internal_condition_case_n):
8172 Remove unnecessary aborts (Bug#9081).
8174 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8176 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8177 has no `load' handler, try opening the file locally. (Bug#9311)
8179 2011-08-16 Ken Brown <kbrown@cornell.edu>
8181 * gmalloc.c: Expand comment.
8183 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8185 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8186 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8188 2011-08-16 Ken Brown <kbrown@cornell.edu>
8190 Fix memory allocation problems in Cygwin build (Bug#9273).
8192 * unexcw.c ( __malloc_initialized): Declare external variable.
8193 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8195 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8197 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8199 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8201 [CYGWIN] (special_realloc): New function.
8202 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8203 requests to realloc storage in the static heap.
8205 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8207 * bidi.c (bidi_initialize): Remove unused local.
8209 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8212 * biditype.h: Remove file.
8213 * makefile.w32-in ($(BLD)/bidi.$(O)):
8214 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8216 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8218 * chartab.c: Improve commentary for the uniprop_table API.
8220 * bidi.c (bidi_paragraph_init): Support zero value of
8221 bidi_ignore_explicit_marks_for_paragraph_level.
8222 (bidi_initialize): Use uniprop_table instead of including
8223 biditype.h and bidimirror.h.
8225 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8226 coordinates of the iterator when restoring from ppos_it.
8229 2011-08-14 Kenichi Handa <handa@m17n.org>
8231 * process.c (create_process): Call setup_process_coding_systems
8232 after the pid of the process is set to -1 (Bug#8162).
8234 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8236 * xdisp.c (move_it_in_display_line_to): Don't invoke
8237 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8238 ppos_it. Fixes vertical cursor motion when line beginning is
8239 covered by an image. (Bug#9296)
8241 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8243 * nsterm.h (ns_run_ascript): Declare.
8244 (NSAPP_DATA2_RUNASSCRIPT): Define.
8246 * nsfns.m (as_script, as_result, as_status): New static variables.
8247 (ns_run_ascript): New function.
8248 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8249 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8250 the event loop. Get status from as_status (Bug#7276).
8252 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8253 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8254 the event loop (Bug#7276).
8256 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8258 * gnutls.c (QCgnutls_bootprop_priority)
8259 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8260 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8261 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8262 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8263 (QCgnutls_bootprop_verify_hostname_error)
8264 (QCgnutls_bootprop_callbacks_verify): Rename from
8265 Qgnutls_bootprop_..., all uses changed.
8267 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8270 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8272 * xfaces.c (Qframe_set_background_mode): Now static.
8273 * dispextern.h (Qframe_set_background_mode): Remove decl.
8275 * process.c (Fnetwork_interface_info): Declare local only if needed.
8277 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8279 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8280 (Fnetwork_interface_list): Allocate in increments of bytes instead
8281 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8282 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8284 (struct ifflag_def): notrailers is smart on OSX.
8285 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8286 Get hardware address with getifaddrs if available.
8288 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8290 * xdisp.c (iterate_out_of_display_property): xassert that
8291 IT->position is set to within IT->object's boundaries. Break from
8292 the loop as soon as EOB is reached; avoids infloops in redisplay
8293 when IT->position is set up wrongly due to some bug.
8294 Set IT->current to match the bidi iterator unconditionally.
8295 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8296 entry. Force push_it to save on the stack the current
8297 buffer/string position, to be restored by pop_it. Fix flags in
8298 the iterator structure wrt the object coming from a display
8299 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8300 properties. (Bug#9284)
8302 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8304 * fontset.c (fontset_get_font_group): Add proper type checks.
8307 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8309 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8310 and LC_VERSION_MIN_MACOSX.
8311 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8312 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8314 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8316 * xdisp.c (forward_to_next_line_start): Allow to use the
8317 no-display-properties-and-no-overlays under bidi display.
8318 Set disp_pos in the bidi iterator to avoid searches for display
8319 properties and overlays.
8321 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8323 * editfns.c (Fset_time_zone_rule): Document relationship with the
8326 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8327 the font entity extracted from the cache (Bug#8109).
8329 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8331 * composite.c (autocmp_chars): Don't reset point. That is done by
8332 restore_point_unwind (Bug#5984).
8334 2011-08-07 Juri Linkov <juri@jurta.org>
8336 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8337 to show the arg `TIME' instead of `TIMEVAL'.
8339 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8341 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8342 display property strides EOL and includes a newline, as in
8343 longlines-mode. (Bug#9254)
8344 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8345 word-wrap under bidirectional display. (Bug#9224)
8347 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8348 is non-zero, even if the data buffer is NULL. Fixes a crash in
8349 vertical-motion with longlines-mode. (Bug#9254)
8351 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8353 * bidi.c <bidi_cache_total_alloc>: Now static.
8354 (bidi_initialize): Initialize bidi_cache_total_alloc.
8356 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8359 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8360 amount allocated this far in `bidi_cache_total_alloc'.
8361 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8362 non-zero, only free the data buffer without restoring the cache
8363 contents. All callers changed.
8365 * dispextern.h (bidi_unshelve_cache): Update prototype.
8367 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8368 (move_it_in_display_line, move_it_to)
8369 (move_it_vertically_backward, move_it_by_lines): Replace the call
8370 to xfree to an equivalent call to bidi_unshelve_cache.
8371 (move_it_in_display_line_to): Fix logic of returning
8372 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8374 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8376 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8377 came from a string character with a `cursor' property. (Bug#9229)
8379 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8381 * Makefile.in (LIB_PTHREAD): New variable.
8382 (LIBES): Add LIB_PTHREAD (Bug#9216).
8384 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8385 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8387 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8389 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8391 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8393 * xterm.c (x_find_topmost_parent): New function.
8394 (x_set_frame_alpha): Find topmost parent window with
8395 x_find_topmost_parent and set the property there also (bug#9181).
8396 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8398 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8400 * callproc.c (Fcall_process): Avoid vfork clobbering
8401 the local vars buffer, coding_systems, current_dir.
8403 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8405 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8407 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8409 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8410 so that it is not optimized away.
8412 * xdisp.c (compute_display_string_pos): Remove unused local.
8414 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8416 Fix slow cursor motion and scrolling in large buffers with
8417 selective display, like Org Mode buffers. (Bug#9218)
8419 * dispextern.h (struct bidi_it): New member disp_prop_p.
8421 * xdisp.c: Remove one-slot cache of display string positions.
8422 (compute_display_string_pos): Accept an additional argument
8423 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8424 for a display string or property. If found, set DISP_PROP_P
8427 * bidi.c (bidi_fetch_char): Accept an additional argument
8428 DISP_PROP_P, and pass it to compute_display_string_pos.
8429 Only handle text covered by a display string if DISP_PROP_P is returned
8430 non-zero. All callers of bidi_fetch_char changed.
8432 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8434 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8436 2010-12-03 Don March <don@ohspite.net>
8438 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8439 last character M-[char] is translated to ESC [char] (bug#7541).
8441 2011-08-02 Kenichi Handa <handa@m17n.org>
8443 * lisp.h (uniprop_table): Extern it.
8445 * chartab.c (uniprop_table): Make it non-static.
8447 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8449 * xdisp.c (forward_to_next_line_start): Accept additional argument
8450 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8452 (reseat_at_next_visible_line_start): Use the bidi iterator state
8453 returned by forward_to_next_line_start to restore the state of
8454 it->bidi_it after backing up to previous newline. (Bug#9212)
8456 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8458 * regex.c (re_comp): Protoize.
8459 (re_exec): Fix return type.
8460 (regexec): Fix type of `ret'. (Bug#9203)
8462 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8464 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8465 This is needed if max-image-size is a floating-point number.
8467 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8469 * print.c (print_object): Print empty symbol as ##.
8471 * lread.c (read1): Read ## as empty symbol.
8473 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8475 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8476 setting frame foreground color (Bug#9175).
8477 (x_set_background_color): Likewise.
8479 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8480 contents (Bug#9176).
8481 (EmacsTooltip -init): Remove bezels and add shadows to
8484 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8485 or scroll bar (Bug#8470).
8487 * nsfont.m (nsfont_open): Remove assignment to voffset and
8488 unnecessary vars hshink, expand, hd, full_height, min_height.
8489 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8491 * nsterm.h (nsfont_info): Remove voffset field.
8493 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8495 Implement strike-through and overline on NextStep (Bug#8863).
8497 * nsfont.m (nsfont_open): Use underline position provided by font,
8498 instead of hard-coded value of 2.
8499 (nsfont_draw): Call ns_draw_text_decoration instead.
8501 * nsterm.h: Add declaration for ns_draw_text_decoration.
8503 * nsterm.m (ns_draw_text_decoration): New function for drawing
8504 underline, overline, and strike-through.
8505 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8506 ns_draw_text_decoration. Change treatment of cursor drawing to
8507 accommodate underlining, etc.
8509 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8511 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8514 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8516 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8517 Without this fix, if a signal arrives just after memory fills up,
8518 'malloc' might be invoked reentrantly.
8520 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8521 In other words, assume that every image size is allowed, on non-X
8522 hosts. This assumption is probably wrong, but it lets Emacs compile.
8524 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8526 * regex.c (re_iswctype): Convert return values to boolean.
8528 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8530 * xdisp.c (compute_display_string_pos): Don't use cached display
8531 string position if the buffer had its restriction changed.
8534 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8536 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8538 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8540 Integer signedness and overflow and related fixes. (Bug#9079)
8542 * bidi.c: Integer size and overflow fixes.
8543 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8544 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8545 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8546 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8547 (bidi_find_other_level_edge):
8548 Use ptrdiff_t instead of EMACS_INT where either will do.
8549 This works better on 32-bit hosts configured --with-wide-int.
8550 (bidi_cache_ensure_space): Check for size-calculation overflow.
8551 Use % rather than repeated addition, for better worst-case speed.
8552 Don't set bidi_cache_size until after xrealloc returns, because it
8554 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8555 (bidi_cache_ensure_space): Also check that the bidi cache size
8556 does not exceed that of the largest Lisp string or buffer. See Eli
8557 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8559 * alloc.c (__malloc_size_t): Remove.
8560 All uses replaced by size_t. See Andreas Schwab's note
8561 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8563 * image.c: Improve checking for integer overflow.
8564 (check_image_size): Assume that f is nonnull, since
8565 it is always nonnull in practice. This is one less thing to
8566 worry about when checking for integer overflow later.
8567 (x_check_image_size): New function, which checks for integer
8568 overflow issues inside X.
8569 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8570 This removes the need for a memory_full check.
8571 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8572 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8573 (xbm_read_bitmap_data): Change locals back to 'int', since
8574 their values must fit in 'int'.
8575 (xpm_load_image, png_load, tiff_load):
8576 Invoke x_create_x_image_and_pixmap earlier,
8577 to avoid much needless work if the image is too large.
8578 (tiff_load): Treat overly large images as if
8579 x_create_x_image_and_pixmap failed, not as malloc failures.
8580 (gs_load): Use x_check_image_size.
8582 * gtkutil.c: Omit integer casts.
8583 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8584 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8586 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8588 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8589 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8590 would wrongly return t on a 64-bit host.
8592 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8593 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8594 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8595 and therefore cause GCC to emit a bogus diagnostic in some cases.
8597 * image.c: Integer signedness and overflow and related fixes.
8598 This is not an exhaustive set of fixes, but it's time to
8599 record what I've got.
8600 (lookup_pixel_color, check_image_size): Remove redundant decls.
8601 (check_image_size): Don't assume that arbitrary EMACS_INT values
8602 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8603 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8604 (tiff_load, imagemagick_load_image):
8605 Check for overflow in size calculations.
8606 (x_create_x_image_and_pixmap): Remove unnecessary test for
8607 xmalloc returning NULL; that can't happen.
8608 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8609 (xpm_color_bucket): Use better integer hashing function.
8610 (xpm_cache_color): Don't possibly over-allocate memory.
8611 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8612 (gif_memory_source):
8613 Use ptrdiff_t, not int or size_t, to record sizes.
8614 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8615 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8616 either works, as we prefer signed integers.
8617 (tiff_read_from_memory, tiff_write_from_memory):
8618 Return tsize_t, not size_t, since that's what the TIFF API wants.
8619 (tiff_read_from_memory): Don't fail simply because the read would
8620 go past EOF; instead, return a short read.
8621 (tiff_load): Omit no-longer-needed casts.
8622 (Fimagemagick_types): Don't assume size fits into 'int'.
8624 Improve hashing quality when configured --with-wide-int.
8625 * fns.c (hash_string): New function, taken from sxhash_string.
8626 Do not discard information about ASCII character case; this
8627 discarding is no longer needed.
8628 (sxhash-string): Use it. Change sig to match it. Caller changed.
8629 * lisp.h: Declare it.
8630 * lread.c (hash_string): Remove, since we now use fns.c's version.
8631 The fns.c version returns a wider integer if --with-wide-int is
8632 specified, so this should help the quality of the hashing a bit.
8634 * emacs.c: Integer overflow minor fix.
8635 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8636 Define only if GNU_LINUX.
8637 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8639 * dispnew.c: Integer signedness and overflow fixes.
8640 Remove unnecessary forward decls, that were a maintenance hassle.
8641 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8643 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8644 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8645 (prepare_desired_row, line_draw_cost):
8646 Use int, not unsigned, where either works.
8647 (save_current_matrix, restore_current_matrix):
8648 Use ptrdiff_t, not size_t, where either works.
8649 (init_display): Check for overflow more accurately, and without
8650 relying on undefined behavior.
8652 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8653 Remove, replacing with the new symbols in lisp.h. All uses changed.
8654 * fileio.c (make_temp_name):
8655 * filelock.c (lock_file_1, lock_file):
8656 * xdisp.c (message_dolog):
8657 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8658 Use pMd etc. instead.
8659 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8660 replacing the pWIDE etc. symbols removed from editfns.c.
8662 * keyboard.h (num_input_events): Now uintmax_t.
8663 This is (very slightly) less likely to mess up due to wraparound.
8666 * buffer.c: Integer signedness fixes.
8667 (alloc_buffer_text, enlarge_buffer_text):
8668 Use ptrdiff_t rather than size_t when either will do, as we prefer
8671 * alloc.c: Integer signedness and overflow fixes.
8672 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8673 (__malloc_size_t): Default to size_t, not to int.
8674 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8675 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8676 Prefer ptrdiff_t to size_t when either would do, as we prefer
8678 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8679 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8680 Now const. Initialize with values that are in range even if char
8682 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8683 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8684 These functions do the right thing with sizes > 2**32.
8685 (check_depth): Now ptrdiff_t, not int.
8686 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8687 Adjust to new way of storing sizes. Check for size overflow bugs
8689 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8690 slightly wrong anyway, as it missed one instance of
8691 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8692 (refill_memory_reserve): Omit needless cast to size_t.
8693 (mark_object_loop_halt): Mark as externally visible.
8695 * xselect.c: Integer signedness and overflow fixes.
8696 (Fx_register_dnd_atom, x_handle_dnd_message):
8697 Use ptrdiff_t, not size_t, since we prefer signed.
8698 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8699 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8700 x_dnd_atoms_size and x_dnd_atoms_length.
8702 * doprnt.c: Prefer signed to unsigned when either works.
8704 * doprnt.c (doprnt):
8706 * xdisp.c (vmessage):
8707 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8708 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8709 prefer signed arithmetic to avoid comparison confusion.
8710 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8711 but is a bit tricky.
8713 Assume freestanding C89 headers, string.h, stdlib.h.
8714 * data.c, doprnt.c, floatfns.c, print.c:
8715 Include float.h unconditionally.
8716 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8717 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8718 * regex.c: Likewise for stddef.h, string.h.
8719 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8720 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8721 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8722 (STDC_HEADERS): Remove obsolete defines.
8723 * sysdep.c: Include limits.h unconditionally.
8725 Assume support for memcmp, memcpy, memmove, memset.
8726 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8727 * regex.c (memcmp, memcpy):
8728 Remove; we assume C89 now.
8730 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8731 (__malloc_safe_bcopy): Remove; no longer needed.
8733 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8734 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8735 well either way, and we prefer signed to unsigned.
8737 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8739 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8740 closes the connection while we're reading (bug#9182).
8742 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8744 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8745 are specified (Bug#9168).
8747 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8749 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8750 Found by GCC static checking and --with-wide-int on a 32-bit host.
8752 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8754 * xdisp.c (compute_display_string_pos): Fix logic of caching
8755 previous display string position. Initialize cached_prev_pos to
8756 -1. Fixes slow-down at the beginning of a buffer.
8758 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8760 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8761 for attrs[LFACE_FONTSET_INDEX].
8763 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8765 * xml.c (parse_region): Remove unused local
8766 that was recently introduced.
8768 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8770 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8771 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8773 * xdisp.c (move_it_in_display_line_to): Record the best matching
8774 position for TO_CHARPOS while scanning the line, and restore it on
8775 exit if none of the characters scanned was an exact match.
8776 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8777 when exact match is impossible due to invisible text, and the
8778 lines are truncated.
8780 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8782 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8785 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8787 Fix a significant slow-down of cursor motion with C-n, C-p,
8788 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8789 auto-repeat under bidi redisplay in fontified buffers.
8790 * xdisp.c (compute_stop_pos_backwards): New function.
8791 (next_element_from_buffer): Call compute_stop_pos_backwards to
8792 find a suitable prev_stop when we find ourselves before
8794 (reseat): Don't look for prev_stop, as that could mean a very long
8796 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8797 <cached_disp_overlay_modiff>: Cache for last found display string
8799 (compute_display_string_pos): Return the cached position if asked
8800 about the same buffer in the same area of character positions, and
8801 the buffer wasn't changed since the time the display string
8802 position was cached.
8804 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8806 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8807 is an integer, which is important for empty lines. (Bug#9149)
8809 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8811 * frame.c (Fmodify_frame_parameters): In tty case, update the
8812 default face if necessary (Bug#4238).
8814 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8816 * editfns.c (Fstring_to_char): No need to explain what a character
8817 is in the docstring (Bug#6576).
8819 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8821 * xml.c (parse_region): Make sure we always return a tree.
8823 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8825 * xml.c (parse_region): If a document contains only comments,
8828 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8830 * xml.c (make_dom): Return comments, too.
8832 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8835 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8836 and the surrounding thread.
8837 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8838 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8839 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8841 * s/openbsd.h (BROKEN_SIGIO): Define.
8842 * unexelf.c (unexec) [__OpenBSD__]:
8843 Don't update the .mdebug section of the Alpha COFF symbol table.
8845 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8847 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8850 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8852 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8853 This fixes some race conditions on the permissions of any newly
8856 * alloc.c (valid_pointer_p): Use pipe, not open.
8857 This fixes some permissions issues when debugging.
8859 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8860 If fchown fails to set both uid and gid, try to set just gid,
8861 as that is sometimes allowed. Adjust the file's mode to eliminate
8862 setuid or setgid bits that are inappropriate if fchown fails.
8864 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8866 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8867 to compare Lisp_Objects.
8868 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8869 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8870 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8872 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8874 * lread.c (read_integer): Unread even EOF character.
8875 (read1): Likewise. Properly record start position of symbol.
8877 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8878 symbol character follows.
8880 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8882 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8883 This works around a problem with the previous change to Fcopy_file.
8884 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8885 and without this change, GCC might complain about discarding
8886 fchown's return value.
8888 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8890 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8892 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8894 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8896 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8898 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8899 it's used from the C level.
8901 * process.c: Use the same condition for POLL_FOR_INPUT in both
8902 keyboard.c and process.c (bug#1858).
8904 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8906 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8907 (Fgnutls_boot): Use it.
8909 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8911 * doc.c (Fsubstitute_command_keys): Revert last change.
8913 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8915 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8916 quotes the next character, and doesn't affect other longer
8917 sequences (bug#8935).
8919 * lread.c (syms_of_lread): Clarify that is isn't only
8920 `eval-buffer' and `eval-defun' that's affected by
8921 `lexical-binding' (bug#8460).
8923 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8925 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8926 bidi redisplay when a line includes both an image and is truncated.
8928 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8930 Fix minor problems found by static checking.
8931 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8932 (elsz): Now a signed constant, not a size_t var. We prefer signed
8933 types to unsigned, to avoid integer comparison confusion. Without
8934 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8935 "cannot optimize loop, the loop counter may overflow", a symptom
8937 * indent.c (Fvertical_motion): Mark locals as initialized.
8938 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8940 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8942 * search.c (Fre_search_backward): Mention `case-fold-search' in
8943 all the re_search_* functions (bug#8138).
8945 * keyboard.c (Fopen_dribble_file): Document when the file is
8948 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8950 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8953 Support bidi reordering of display and overlay strings.
8954 * xdisp.c (compute_display_string_pos)
8955 (compute_display_string_end): Accept additional argument STRING.
8956 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8957 (reseat_to_string): Initialize bidi_it->string.s and
8958 bidi_it->string.schars.
8959 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8960 NULL (avoids a crash in bidi_paragraph_init).
8961 Initialize itb.string.lstring.
8962 (init_iterator): Call bidi_init_it only of a valid
8963 buffer position was specified. Initialize paragraph_embedding to
8965 (reseat_to_string): Initialize the bidi iterator.
8966 (display_string): If we need to ignore text properties of
8967 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8968 original value of -1 will not work with bidi.)
8969 (compute_display_string_pos): First arg is now struct
8970 `text_pos *'; all callers changed. Support display properties on
8972 (compute_display_string_end): Support display properties on Lisp
8974 (init_iterator, reseat_1, reseat_to_string): Initialize the
8975 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8976 when iterating on a string not from display properties).
8977 (compute_display_string_pos, compute_display_string_end):
8978 Fix calculation of the object to scan. Fixes an error when using
8980 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8981 base_level_stop; instead, set base_level_stop to BEGV.
8982 Fixes crashes in vertical-motion.
8983 (next_element_from_buffer): Improve commentary for when
8984 the iterator is before prev_stop.
8985 (init_iterator): Initialize bidi_p from the default value of
8986 bidi-display-reordering, not from buffer-local value. Use the
8987 buffer-local value only if initializing for buffer iteration.
8988 (handle_invisible_prop): Support invisible properties on strings
8989 that are being bidi-reordered.
8990 (set_iterator_to_next): Support bidi reordering of C strings and
8992 (next_element_from_string): Support bidi reordering of Lisp
8994 (handle_stop_backwards): Support Lisp strings as well.
8995 (display_string): Support display of R2L glyph rows.
8996 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8997 (init_iterator): Don't initialize it->bidi_p for strings
8999 (reseat_to_string): Initialize it->bidi_p for strings here.
9000 (next_element_from_string, next_element_from_c_string)
9001 (next_element_from_buffer): Add xassert's for correspondence
9002 between IT's object being iterated and it->bidi_it.string
9004 (face_before_or_after_it_pos): Support bidi iteration.
9005 (next_element_from_c_string): Handle the case of the first string
9006 character that is not the first one in the visual order.
9007 (get_visually_first_element): New function, refactored from common
9008 parts of next_element_from_buffer, next_element_from_string, and
9009 next_element_from_c_string.
9010 (tool_bar_lines_needed, redisplay_tool_bar)
9011 (display_menu_bar): Force left-to-right direction. Add a FIXME
9012 comment for making that be controlled by a user option.
9013 (push_it, pop_it): Save and restore the state of the
9014 bidi iterator. Save and restore the bidi_p flag.
9015 (pop_it): Iterate out of display property for string iteration as
9017 (iterate_out_of_display_property): Support iteration over strings.
9018 (handle_single_display_spec): Set up it->bidi_it for iteration
9019 over a display string, and call bidi_init_it.
9020 (handle_single_display_spec, next_overlay_string)
9021 (get_overlay_strings_1, push_display_prop): Set up the bidi
9022 iterator for displaying display or overlay strings.
9023 (forward_to_next_line_start): Don't use the shortcut if
9025 (back_to_previous_visible_line_start): If handle_display_prop
9026 pushed the iterator stack, restore the internal state of the bidi
9027 iterator by calling bidi_pop_it same number of times.
9028 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9029 and we are bidi-iterating, don't decrement the iterator position;
9030 instead, set the first_elt flag in the bidi iterator, to produce
9032 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9033 (push_display_prop): xassert that we are iterating a buffer.
9034 (push_it, pop_it): Save and restore paragraph_embedding member.
9035 (handle_single_display_spec, next_overlay_string)
9036 (get_overlay_strings_1, reseat_1, reseat_to_string)
9037 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9038 correctly. Don't assume unibyte strings are not bidi-reordered.
9039 (compute_display_string_pos)
9040 (compute_display_string_end): Fix handling the case of C string.
9041 (push_it, pop_it): Save and restore from_disp_prop_p.
9042 (handle_single_display_spec, push_display_prop): Set the
9043 from_disp_prop_p flag.
9044 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9045 (pop_it): Call iterate_out_of_display_property only if we are
9046 popping after iteration over a string that came from a display
9047 property. Fix a typo in popping stretch info. Add an assertion
9048 for verifying that the iterator position is in sync with the bidi
9050 (handle_single_display_spec, get_overlay_strings_1)
9051 (push_display_prop): Fix initialization of paragraph direction for
9052 string when that of the parent object is not yet determined.
9053 (reseat_1): Call bidi_init_it to resync the bidi
9054 iterator with IT's position. (Bug#7616)
9055 (find_row_edges): If ROW->start.pos gives position
9056 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9057 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9058 Reset the from_disp_prop_p flag.
9059 (SAVE_IT, RESTORE_IT): New macros.
9060 (pos_visible_p, face_before_or_after_it_pos)
9061 (back_to_previous_visible_line_start)
9062 (move_it_in_display_line_to, move_it_in_display_line)
9063 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9064 (try_scrolling, redisplay_window, display_line): Use them when
9065 saving a temporary copy of the iterator and restoring it back.
9066 (back_to_previous_visible_line_start, reseat_1)
9067 (init_iterator): Empty the bidi cache "stack".
9068 (move_it_in_display_line_to): If iterator ended up at
9069 EOL, but we never saw any buffer positions smaller than
9070 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9071 motion in bidi-reordered lines.
9072 (move_it_in_display_line_to): Record prev_method and prev_pos
9073 immediately before the call to set_iterator_to_next. Fixes cursor
9074 motion in bidi-reordered lines with stretch glyphs and strings
9075 displayed in margins. (Bug#8133) (Bug#8867)
9076 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9078 (pos_visible_p): Support positions in bidi-reordered lines.
9079 Save and restore bidi cache.
9081 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9082 (bidi_paragraph_info): Delete unused struct.
9083 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9084 (bidi_cache_start): New variable.
9085 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9087 (bidi_cache_fetch_state, bidi_cache_search)
9088 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9089 (bidi_cache_find, bidi_peek_at_next_level)
9090 (bidi_level_of_next_char, bidi_find_other_level_edge)
9091 (bidi_move_to_visually_next): Compare cache index with
9092 bidi_cache_start rather than with zero.
9093 (bidi_fetch_char): Accept new argument STRING; all callers
9094 changed. Support iteration over a string. Support strings with
9095 display properties. Support unibyte strings. Fix the type of
9096 `len' according to what STRING_CHAR_AND_LENGTH expects.
9097 (bidi_paragraph_init, bidi_resolve_explicit_1)
9098 (bidi_resolve_explicit, bidi_resolve_weak)
9099 (bidi_level_of_next_char, bidi_move_to_visually_next):
9100 Support iteration over a string.
9101 (bidi_set_sor_type, bidi_resolve_explicit_1)
9102 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9103 can now be zero (for strings); special values 0 and -1 were
9104 changed to -1 and -2, respectively.
9105 (bidi_char_at_pos): New function.
9106 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9107 Call it instead of FETCH_MULTIBYTE_CHAR.
9108 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9109 initialized to valid values.
9110 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9112 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9113 the test for valid cached positions. Fix the logic for looking up
9114 the sentinel state in the cache. GCPRO the Lisp string we are
9116 (bidi_push_it, bidi_pop_it): New functions.
9117 (bidi_initialize): Initialize the bidi cache start stack pointer.
9118 (bidi_cache_ensure_space): New function, refactored from part of
9119 bidi_cache_iterator_state. Don't assume the required size is just
9120 one BIDI_CACHE_CHUNK away.
9121 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9122 (bidi_count_bytes, bidi_char_at_pos): New functions.
9123 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9124 always valid if bidi_cache_idx is valid.
9125 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9126 is valid if it's going to be used.
9127 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9128 (bidi_cache_fetch_state, bidi_cache_search)
9129 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9130 (bidi_cache_iterator_state, bidi_cache_find)
9131 (bidi_find_other_level_edge, bidi_cache_start_stack):
9132 All variables related to cache indices are now EMACS_INT.
9134 * dispextern.h (struct bidi_string_data): New structure.
9135 (struct bidi_it): New member `string'. Make flag members be 1-bit
9136 fields, and put them last in the struct.
9137 (compute_display_string_pos, compute_display_string_end):
9139 (bidi_push_it, bidi_pop_it): Add prototypes.
9140 (struct iterator_stack_entry): New members bidi_p,
9141 paragraph_embedding, and from_disp_prop_p.
9142 (struct it): Member bidi_p is now a bit field 1 bit wide.
9143 (bidi_shelve_cache, bidi_unshelve_cache):
9146 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9147 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9148 and vector-like objects.
9150 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9151 cache around display iteration.
9153 * window.c (Fwindow_end, window_scroll_pixel_based)
9154 (displayed_window_lines, Frecenter): Save and restore the bidi
9155 cache around display iteration.
9157 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9159 * editfns.c (Fdelete_region): Clarify the use of the named
9160 parameters (bug#6788).
9162 2011-07-14 Martin Rudalics <rudalics@gmx.at>
9164 * indent.c (Fvertical_motion): Set and restore w->pointm when
9165 saving and restoring the window's buffer (Bug#9006).
9167 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9169 * editfns.c (Fstring_to_char): Clarify just what is returned
9170 (bug#6576). Text by Eli Zaretskii.
9172 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9174 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9176 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9178 * buffer.c (mmap_find): Fix a typo.
9180 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9182 Fix execution of x selection hooks.
9183 * xselect.c (Qx_lost_selection_functions)
9184 (Qx_sent_selection_functions): New vars.
9185 (syms_of_xselect): DEFSYM them.
9186 (x_handle_selection_request): Pass Qx_sent_selection_functions
9187 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9188 (x_handle_selection_clear,x_clear_frame_selections):
9189 Pass Qx_lost_selection_functions rather than
9190 Vx_lost_selection_functions to Frun_hook_with_args.
9192 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9194 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9195 The old code sometimes used this field without initializing it.
9197 * alloc.c (gc_sweep): Don't read past end of array.
9198 In theory, the old code could also have corrupted Emacs internals,
9199 though it'd be very unlikely.
9201 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9203 * character.c (Fcharacterp): Don't advertise optional ignored
9204 argument. (Bug#4026)
9206 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9208 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9211 * window.c (Fset_window_start): Doc fix (bug#4199).
9212 (Fset_window_hscroll): Ditto.
9214 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9216 Fix minor new problems caught by GCC 4.6.1.
9217 * term.c (init_tty): Remove unused local.
9218 * xsettings.c (store_monospaced_changed): Define this function only
9219 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9222 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9224 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9226 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9228 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9229 are the mini-buffer and the echo area (bug#3320).
9231 * term.c (init_tty): Remove support for supdup, c10 and perq
9232 terminals, which are no longer supported (bug#1482).
9234 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9236 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9238 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9240 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9241 for non-popups (Bug#3642).
9243 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9245 * alloc.c (reset_malloc_hooks): Protoize.
9246 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9247 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9248 * cm.c (losecursor): Likewise.
9249 * data.c (fmod): Likewise.
9250 * dispnew.c (swap_glyphs_in_rows): Likewise.
9251 * emacs.c (memory_warning_signal): Likewise.
9252 * floatfns.c (float_error): Likewise.
9253 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9254 (otf_open, font_otf_capability, generate_otf_features)
9255 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9257 * image.c (pbm_read_file): Likewise.
9258 * indent.c (string_display_width): Likewise.
9259 * intervals.c (check_for_interval, search_for_interval)
9260 (inc_interval_count, count_intervals, root_interval)
9261 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9262 * lread.c (defalias): Likewise.
9263 * ralloc.c (r_alloc_check): Likewise.
9264 * regex.c (set_image_of_range_1, set_image_of_range)
9265 (regex_grow_registers): Likewise.
9266 * sysdep.c (strerror): Likewise.
9267 * termcap.c (valid_filename_p, tprint, main): Likewise.
9268 * tparam.c (main): Likewise.
9269 * unexhp9k800.c (run_time_remap, save_data_space)
9270 (update_file_ptrs, read_header, write_header, calculate_checksum)
9271 (copy_file, copy_rest, display_header): Likewise.
9272 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9274 * xdisp.c (check_it): Likewise.
9275 * xfaces.c (register_color, unregister_color, unregister_colors):
9277 * xfns.c (print_fontset_result): Likewise.
9278 * xrdb.c (member, fatal, main): Likewise.
9280 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9282 Fix minor problems found by static checking (Bug#9031).
9283 * chartab.c (char_table_set_range, map_sub_char_table):
9284 Remove unused locals.
9285 (uniprop_table): Now static.
9286 * composite.c (_work_char): Remove unused static var.
9288 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9290 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9292 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9294 * gtkutil.c (qttip_cb): Remove code without function.
9296 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9298 * w32.c (pthread_sigmask): New stub.
9300 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9302 Use pthread_sigmask, not sigprocmask (Bug#9010).
9303 sigprocmask is portable only for single-threaded applications, and
9304 Emacs can be multi-threaded when it uses GTK.
9305 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9307 * callproc.c (Fcall_process):
9308 * process.c (create_process):
9309 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9310 Use pthread_sigmask, not sigprocmask.
9312 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9314 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9315 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9318 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9320 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9321 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9322 (xg_hide_tooltip): Fix comment.
9324 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9325 in registerServicesMenuSendTypes.
9326 (validRequestorForSendType): Don't check ns_return_types.
9328 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9331 2011-07-08 Jason Rumney <jasonr@gnu.org>
9333 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9334 SH_SHOW for hidden windows (Bug#5482).
9336 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9337 frame struct members of non-existent frames (Bug#6284).
9339 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9341 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9342 variable firstTime not needed on OSX >= 10.6.
9343 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9344 >= 10.5. Use setKnobProportion, setDoubleValue.
9346 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9347 (MAC_OS_X_VERSION_10_5): Define if not defined.
9348 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9349 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9350 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9352 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9353 cString and lossyCString on OSX >= 10.4.
9355 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9356 sizeToFit on OSX >= 10.2.
9358 * nsimage.m (allocInitFromFile): Don't use deprecated method
9359 bestRepresentationForDevice on OSX >= 10.6.
9361 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9364 * emacs.c: Declare unexec_init_emacs_zone.
9366 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9368 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9370 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9371 on svcsMenu (Bug#8842).
9373 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9375 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9377 * nsterm.m (QUTF8_STRING): Declare.
9378 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9379 (validRequestorForSendType): Return type is (id).
9380 Change indexOfObjectIdenticalTo to indexOfObject.
9381 Check if we have local selection before returning self (Bug#8842).
9382 (writeSelectionToPasteboard): Put local selection into paste board
9383 if we have a local selection (Bug#8842).
9384 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9386 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9387 (ns_get_local_selection): Declare.
9389 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9391 * keymap.c (describe_map_tree): Don't insert a double newline at
9392 the end of the buffer (bug#1169) and return whether we inserted
9395 * callint.c (Fcall_interactively): Change "reading args" to
9396 "providing args" to try to clarify what it does (bug#1010).
9398 2011-07-07 Kenichi Handa <handa@m17n.org>
9400 * composite.c (composition_compute_stop_pos): Ignore a static
9401 composition starting before CHARPOS (Bug#8915).
9403 * xdisp.c (handle_composition_prop): Likewise.
9405 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9407 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9410 2011-07-07 Kenichi Handa <handa@m17n.org>
9412 * character.h (unicode_category_t): New enum type.
9414 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9415 (Qchar_code_property_table): New variable.
9416 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9417 (UNIPROP_COMPRESSED_FORM_P): New macros.
9418 (char_table_ascii): Uncompress the compressed values.
9419 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9420 Uncompress the compressed values.
9421 (sub_char_table_ref_and_range): Likewise.
9422 (char_table_ref_and_range): Uncompress the compressed values.
9423 (sub_char_table_set): New arg is_uniprop. Callers changed.
9424 Uncompress the compressed values.
9425 (sub_char_table_set_range): Args changed. Callers changed.
9426 (char_table_set_range): Adjuted for the above change.
9427 (map_sub_char_table): Delete args default_val and parent. Add arg
9428 top. Give decoded values to a Lisp function.
9429 (map_char_table): Adjust for the above change. Give decoded
9430 values to a Lisp function. Gcpro more variables.
9431 (uniprop_table_uncompress)
9432 (uniprop_decode_value_run_length): New functions.
9433 (uniprop_decoder, uniprop_decoder_count): New variables.
9434 (uniprop_get_decoder, uniprop_encode_value_character)
9435 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9437 (uniprop_encoder, uniprop_encoder_count): New variables.
9438 (uniprop_get_encoder, uniprop_table)
9439 (Funicode_property_table_internal, Fget_unicode_property_internal)
9440 (Fput_unicode_property_internal): New functions.
9441 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9442 Sunicode_property_table_internal, Sget_unicode_property_internal,
9443 and Sput_unicode_property_internal. Defvar_lisp
9444 char-code-property-alist.
9446 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9447 Vunicode_category_table.
9449 * font.c (font_range): Adjust for the change of
9450 Vunicode_category_table.
9452 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9454 * m/iris4d.h: Remove file, move contents ...
9455 * s/irix6-5.h: ... here.
9457 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9459 Remove unportable assumption about struct layout (Bug#8884).
9460 * alloc.c (mark_buffer):
9461 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9462 (clone_per_buffer_values): Don't assume that
9463 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9464 This isn't true in general, and it's particularly not true
9465 if Emacs is configured with --with-wide-int.
9466 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9467 New macros, used in the buffer.c change.
9469 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9471 * xsettings.c: Use both GConf and GSettings if both are available.
9472 (store_config_changed_event): Add comment.
9473 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9474 (store_tool_bar_style_changed): New functions.
9475 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9476 (struct xsettings): Move font inside HAVE_XFT.
9477 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9478 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9479 Move inside HAVE_XFT.
9480 (something_changed_gsettingsCB): Rename from something_changedCB.
9481 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9483 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9484 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9485 (something_changed_gconfCB): Rename from something_changedCB.
9486 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9487 (parse_settings): Move check for font inside HAVE_XFT.
9488 (read_settings, apply_xft_settings): Add comment.
9489 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9490 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9491 call store_font_name_changed.
9492 (xft_settings_event): Add comment.
9493 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9494 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9495 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9496 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9497 (xsettings_initialize): Call init_gsettings last.
9498 (xsettings_get_system_font, xsettings_get_system_normal_font):
9501 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9503 Random fixes. E.g., (random) never returned negative values.
9504 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9505 subseconds part to the entropy, as that's a bit more random.
9506 Prefer signed to unsigned, since the signedness doesn't matter and
9507 in general we prefer signed. When given a limit, use a
9508 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9509 latter isn't right if USE_2_TAGS_FOR_INTS.
9510 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9511 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9513 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9515 * textprop.c (text_property_stickiness):
9516 Obey Vtext_property_default_nonsticky.
9517 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9518 * w32fns.c (syms_of_w32fns):
9519 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9521 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9523 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9524 This is more efficient than Ffile_directory_p and avoids a minor race.
9526 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9528 * buffer.c (Foverlay_put): Say what the return value is
9531 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9532 is a directory before asking whether to use the file name
9534 (barf_or_query_if_file_exists): Make the "File is a directory"
9535 error be more correct.
9537 * fns.c (Frequire): Remove the mention of the .gz files, since
9538 that's installation-specific, but keep the mention of
9539 `get-load-suffixes'.
9541 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9543 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9544 Report string overflow if the output is too long.
9546 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9548 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9549 (syms_of_gnutls): Remove duplicate DEFSYM for
9550 Qgnutls_bootprop_verify_hostname_error, an error for
9551 Qgnutls_bootprop_verify_error (which is no longer used).
9553 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9554 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9555 Also (re)move comments that are misplaced or no longer relevant.
9557 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9559 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9561 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9563 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9564 and background color parameters if they have been changed.
9566 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9568 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9570 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9572 * xsettings.c (SYSTEM_FONT): Define only when used.
9573 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9575 * keymap.c (access_keymap_1): Now static.
9577 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9579 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9580 leave any prefix arg for the up event (Bug#1586).
9582 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9584 * lread.c (syms_of_lread): Mention single symbols defined by
9585 `defvar' or `defconst' (bug#7154).
9587 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9588 (Frequire): Mention get-load-suffixes.
9590 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9592 * window.h (window): Remove clone_number slot.
9593 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9595 (make_parent_window, make_window, saved_window)
9596 (Fset_window_configuration, save_window_save): Don't deal with
9598 * buffer.c (Qclone_number): Remove declaration.
9599 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9601 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9603 Add multiple inheritance to keymaps.
9604 * keymap.c (Fmake_composed_keymap): New function.
9605 (Fset_keymap_parent): Simplify.
9606 (fix_submap_inheritance): Remove.
9607 (access_keymap_1): New function extracted from access_keymap to handle
9608 embedded parents and handle lists of maps.
9609 (access_keymap): Use it.
9610 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9611 (Fcopy_keymap): Handle embedded parents.
9612 (Fcommand_remapping, define_as_prefix): Simplify.
9613 (Fkey_binding): Simplify.
9614 (syms_of_keymap): Move minibuffer-local-completion-map,
9615 minibuffer-local-filename-completion-map,
9616 minibuffer-local-must-match-map, and
9617 minibuffer-local-filename-must-match-map to Elisp.
9618 (syms_of_keymap): Defsubr make-composed-keymap.
9619 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9620 (parse_menu_item): Trivial simplification.
9622 2011-07-01 Glenn Morris <rgm@gnu.org>
9624 * Makefile.in (SETTINGS_LIBS): Fix typo.
9626 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9628 * coding.c (Fencode_coding_string): Record the last coding system
9629 used, as the function doc string says (bug#8738).
9631 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9633 * xsettings.c (store_monospaced_changed): Take new font as arg and
9634 check for change against current_mono_font.
9635 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9636 (emacs_settings_constructor, emacs_settings_get_property)
9637 (emacs_settings_set_property, emacs_settings_class_init)
9638 (emacs_settings_init, gsettings_obj): Remove.
9639 (something_changedCB): New function for HAVE_GSETTINGS.
9640 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9641 with value as argument.
9642 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9643 g_settings_new (Bug#8967). Do not create gsettings_obj.
9644 Remove calls to g_settings_bind. Connect something_changedCB to
9647 * xgselect.c: Add defined (HAVE_GSETTINGS).
9648 (xgselect_initialize): Ditto.
9650 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9651 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9654 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9656 * eval.c (struct backtrace): Simplify and port the data structure.
9657 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9658 signed bit field, as this assumption is not portable and it makes
9659 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9660 "char debug_on_exit : 1" as this is not portable either; instead,
9661 use the portable "unsigned int debug_on_exit : 1". Remove unused
9662 member evalargs. Remove obsolete comments about cc bombing out.
9664 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9666 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9667 Let HAVE_GSETTINGS override HAVE_GCONF.
9668 (store_monospaced_changed): New function.
9669 (EMACS_SETTINGS): A new type derived from GObject to handle
9670 GSettings notifications.
9671 (emacs_settings_constructor, emacs_settings_get_property)
9672 (emacs_settings_set_property, emacs_settings_class_init):
9674 (gsettings_client, gsettings_obj): New variables.
9675 (GSETTINGS_SCHEMA): New define.
9676 (something_changedCB): Call store_monospaced_changed.
9677 (init_gsettings): New function.
9678 (xsettings_initialize): Call init_gsettings.
9679 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9682 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9685 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9687 * window.c (resize_root_window, grow_mini_window)
9688 (shrink_mini_window): Rename Qresize_root_window to
9689 Qwindow_resize_root_window and Qresize_root_window_vertically to
9690 Qwindow_resize_root_window_vertically.
9692 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9694 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9696 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9698 * makefile.w32-in: Redesign dependencies so they reflect more
9699 clearly which files are directly included by each source file,
9700 and not through other includes.
9702 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9704 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9705 (sort_overlays, overlay_strings): When an overlay's clone number
9706 matches the window's clone number process the overlay even if
9707 the overlay's window property doesn't match the current window.
9709 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9710 (Fwindow_hchild): Rename to Fwindow_left_child.
9711 (Fwindow_next): Rename to Fwindow_next_sibling.
9712 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9713 (resize_window_check): Rename to window_resize_check.
9714 (resize_window_apply): Rename to window_resize_apply.
9715 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9716 (Fdelete_other_windows_internal, resize_frame_windows)
9717 (Fsplit_window_internal, Fdelete_window_internal)
9718 (grow_mini_window, shrink_mini_window)
9719 (Fresize_mini_window_internal): Fix callers accordingly.
9721 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9723 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9724 (emacs_fixed_set_min_size): Remove.
9725 (emacs_fixed_new): Take frame as argument.
9727 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9728 (_EmacsFixedPrivate): Remove minwidth/height.
9729 Add struct frame *f.
9730 (emacs_fixed_init): Initialize priv->f.
9731 (get_parent_class, emacs_fixed_set_min_size): Remove.
9732 (emacs_fixed_new): Set priv->f to argument.
9733 (emacs_fixed_get_preferred_width)
9734 (emacs_fixed_get_preferred_height): Use min_width/height from
9735 frames size_hint to set minimum and natural (Bug#8919).
9736 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9737 and use min_width/height from frames size_hint to set
9738 min_width/height (Bug#8919).
9740 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9741 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9744 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9746 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9747 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9750 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9752 * process.c (wait_reading_process_output): Bypass select if
9753 waiting for a cell while ignoring keyboard input, and input is
9754 pending. Suggested by Jan Djärv (Bug#8869).
9756 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9758 Use gnulib's dup2 module instead of rolling our own.
9759 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9761 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9763 * dispnew.c (scrolling_window): Before scrolling, turn off a
9764 mouse-highlight in the window being scrolled.
9766 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9768 Move DEFSYM to lisp.h and use everywhere.
9770 * character.h (DEFSYM): Move declaration...
9771 * lisp.h (DEFSYM): ...here.
9777 * w32select.c: Don't include character.h.
9779 * alloc.c (syms_of_alloc):
9780 * buffer.c (syms_of_buffer):
9781 * bytecode.c (syms_of_bytecode):
9782 * callint.c (syms_of_callint):
9783 * casefiddle.c (syms_of_casefiddle):
9784 * casetab.c (init_casetab_once):
9785 * category.c (init_category_once, syms_of_category):
9786 * ccl.c (syms_of_ccl):
9787 * cmds.c (syms_of_cmds):
9788 * composite.c (syms_of_composite):
9789 * dbusbind.c (syms_of_dbusbind):
9790 * dired.c (syms_of_dired):
9791 * dispnew.c (syms_of_display):
9792 * doc.c (syms_of_doc):
9793 * editfns.c (syms_of_editfns):
9794 * emacs.c (syms_of_emacs):
9795 * eval.c (syms_of_eval):
9796 * fileio.c (syms_of_fileio):
9797 * fns.c (syms_of_fns):
9798 * frame.c (syms_of_frame):
9799 * fringe.c (syms_of_fringe):
9800 * insdel.c (syms_of_insdel):
9801 * keymap.c (syms_of_keymap):
9802 * lread.c (init_obarray, syms_of_lread):
9803 * macros.c (syms_of_macros):
9804 * msdos.c (syms_of_msdos):
9805 * print.c (syms_of_print):
9806 * process.c (syms_of_process):
9807 * search.c (syms_of_search):
9808 * sound.c (syms_of_sound):
9809 * syntax.c (init_syntax_once, syms_of_syntax):
9810 * terminal.c (syms_of_terminal):
9811 * textprop.c (syms_of_textprop):
9812 * undo.c (syms_of_undo):
9813 * w32.c (globals_of_w32):
9814 * window.c (syms_of_window):
9815 * xdisp.c (syms_of_xdisp):
9816 * xfaces.c (syms_of_xfaces):
9817 * xfns.c (syms_of_xfns):
9818 * xmenu.c (syms_of_xmenu):
9819 * xsettings.c (syms_of_xsettings):
9820 * xterm.c (syms_of_xterm): Use DEFSYM.
9822 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9824 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9826 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9828 Integer and buffer overflow fixes (Bug#8873).
9830 * print.c (printchar, strout): Check for string overflow.
9831 (PRINTPREPARE, printchar, strout):
9832 Don't set size unless allocation succeeds.
9834 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9835 for sizes. Check for string overflow more accurately.
9836 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9838 * macros.c: Integer and buffer overflow fixes.
9839 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9840 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9841 Use ptrdiff_t, not int, for sizes.
9842 Don't increment bufsize until after realloc succeeds.
9843 Check for size-calculation overflow.
9844 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9846 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9848 * lread.c: Integer overflow fixes.
9849 (read_integer): Radix is now EMACS_INT, not int,
9850 to improve quality of diagnostics for out-of-range radices.
9851 Calculate buffer size correctly for out-of-range radices.
9852 (read1): Check for integer overflow in radices, and in
9853 read-circle numbers.
9854 (read_escape): Avoid int overflow.
9855 (Fload, openp, read_buffer_size, read1)
9856 (substitute_object_recurse, read_vector, read_list, map_obarray):
9857 Use ptrdiff_t, not int, for sizes.
9858 (read1): Use EMACS_INT, not int, for sizes.
9859 Check for size overflow.
9861 * image.c (cache_image): Check for size arithmetic overflow.
9863 * lread.c: Integer overflow issues.
9864 (saved_doc_string_size, saved_doc_string_length)
9865 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9866 Now ptrdiff_t, not int.
9867 (read1): Don't assume doc string length fits in int. Check for
9868 out-of-range doc string lengths.
9869 (read_list): Don't assume file position fits in int.
9870 (read_escape): Check for hex character overflow.
9872 2011-06-22 Leo Liu <sdl.web@gmail.com>
9874 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9875 Move to minibuffer.el.
9877 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9879 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9880 The following patches are for when GLYPH_DEBUG && !XASSERT.
9881 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9882 * dispnew.c (flush_stdout):
9883 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9884 Mark as externally visible.
9885 * dispnew.c (check_window_matrix_pointers): Now static.
9886 * dispnew.c (window_to_frame_vpos):
9887 * xfns.c (unwind_create_frame):
9888 * xterm.c (x_check_font): Remove unused local.
9889 * scroll.c (CHECK_BOUNDS):
9890 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9891 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9892 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9893 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9894 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9896 (debug_method_add): Use va_list and vsprintf rather than relying
9897 on undefined behavior with wrong number of arguments.
9898 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9899 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9900 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9901 since we're not interested in debugging glyphs with old libraries.
9902 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9903 GCC 4.6.0's static checking.
9905 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9907 Integer overflow and signedness fixes (Bug#8873).
9908 A few related buffer overrun fixes, too.
9910 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9912 * dispextern.h (struct face.stipple):
9913 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9914 (x_bitmap_mask, x_allocate_bitmap_record)
9915 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9916 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9917 (x_create_bitmap_from_xpm_data):
9918 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9919 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9921 * xfaces.c (load_pixmap):
9922 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9923 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9924 (.bitmaps_last, struct x_output.icon_bitmap):
9925 Use ptrdiff_t, not int, for bitmap indexes.
9926 (x_allocate_bitmap_record): Check for size overflow.
9927 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9929 Use ptrdiff_t, not int, for overlay counts.
9930 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9931 * editfns.c (overlays_around, get_pos_property):
9932 * textprop.c (get_char_property_and_overlay):
9933 * xdisp.c (next_overlay_change, note_mouse_highlight):
9934 * xfaces.c (face_at_buffer_position):
9935 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9936 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9937 (Fnext_overlay_change, Fprevious_overlay_change)
9938 (mouse_face_overlay_overlaps, Foverlays_in):
9939 Use ptrdiff_t, not int, for sizes.
9940 (overlays_at, overlays_in): Check for size-calculation overflow.
9942 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9944 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9945 (x_session_initialize): Do not assume string length fits in int.
9947 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9948 This is unlikely, but can occur if DPI is outlandish.
9950 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9951 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9953 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9954 * xrdb.c (magic_file_p, search_magic_path):
9955 Omit last arg SUFFIX; it was always 0. All callers changed.
9956 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9958 * xfont.c (xfont_match): Avoid need for strlen.
9960 * xfns.c: Don't assume strlen fits in int.
9961 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9963 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9964 not unsigned long, as we prefer signed integers. All callers changed.
9965 Detect integer overflow in repeat count.
9966 (message_dolog): Don't assume print length fits in 39 bytes.
9967 (display_mode_element): Don't assume strlen fits in int.
9969 * termcap.c: Don't assume sizes fit in int and never overflow.
9970 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9971 (gobble_line): Check for size-calculation overflow.
9973 * minibuf.c (Fread_buffer):
9974 * lread.c (intern, intern_c_string):
9975 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9976 Don't assume string length fits in int.
9978 * keyboard.c (parse_tool_bar_item):
9979 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9981 * font.c: Don't assume string length fits in int.
9982 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9983 Use ptrdiff_t, not int.
9984 (font_intern_prop): Don't assume string length fits in int.
9985 Don't assume integer property fits in fixnum.
9986 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9988 * filelock.c: Fix some buffer overrun and integer overflow issues.
9989 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9990 Reformulate so as not to need the command string.
9991 Invoke gzip -cd rather than gunzip, as it's more portable.
9992 (lock_info_type, lock_file_1, lock_file):
9993 Don't assume pid_t and time_t fit in unsigned long.
9994 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9995 (current_lock_owner): Prefer signed type for sizes.
9996 Use memcpy, not strncpy, where memcpy is what is really wanted.
9997 Don't assume (via atoi) that time_t and pid_t fit in int.
9998 Check for time_t and/or pid_t out of range, e.g., via a network share.
9999 Don't alloca where an auto var works fine.
10001 * fileio.c: Fix some integer overflow issues.
10002 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10003 Don't assume string length fits in int.
10004 (directory_file_name): Don't assume string length fits in long.
10005 (make_temp_name): Don't assume pid fits in int, or that its print
10006 length is less than 20.
10008 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10010 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10012 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10014 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10015 We prefer signed integers, even for size calculations.
10017 * emacs.c: Don't assume string length fits in 'int'.
10018 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10019 (main): Don't invoke strlen when not needed.
10021 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10022 (XD_DEBUG_MESSAGE): Don't waste a byte.
10024 * callproc.c (getenv_internal_1, getenv_internal)
10025 (Fgetenv_internal):
10026 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10028 * lread.c (invalid_syntax): Omit length argument.
10029 All uses changed. This doesn't fix a bug, but it simplifies the
10030 code away from its former Hollerith-constant appearance, and it's
10031 one less 'int' to worry about when looking at integer-overflow issues.
10032 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
10034 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10035 This didn't break anything, but it didn't help either.
10036 It's confusing to put a bogus integer in a place where the actual
10037 value does not matter.
10038 (LIST_END_P): Remove unused macro and its bogus comment.
10039 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
10041 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10042 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10044 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10045 We prefer signed types, and the value cannot exceed the EMACS_INT
10046 range anyway (because otherwise the length would not be representable).
10047 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10048 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10049 This avoids a GCC warning when WIDE_EMACS_INT.
10051 * indent.c (sane_tab_width): New function.
10052 (current_column, scan_for_column, Findent_to, position_indentation)
10053 (compute_motion): Use it. This is just for clarity.
10054 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
10056 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
10058 * lisp.h (lint_assume): New macro.
10059 * composite.c (composition_gstring_put_cache):
10060 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10062 * editfns.c, insdel.c:
10063 Omit unnecessary forward decls, to simplify future changes.
10065 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10067 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10069 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
10070 Use much-faster test for byte-length change.
10071 Don't assume string byte-length fits in 'int'.
10072 Check that character arg fits in 'int'.
10073 (mapcar1): Declare byte as byte, for clarity.
10075 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10077 * fns.c (concat): Catch string overflow earlier.
10078 Do not rely on integer wraparound.
10080 * dispextern.h (struct it.overlay_strings_charpos)
10081 (struct it.selective): Now EMACS_INT, not int.
10082 * xdisp.c (forward_to_next_line_start)
10083 (back_to_previous_visible_line_start)
10084 (reseat_at_next_visible_line_start, next_element_from_buffer):
10085 Don't arbitrarily truncate the value of 'selective' to int.
10087 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10089 * composite.c: Don't truncate sizes to 'int'.
10090 (composition_gstring_p, composition_reseat_it)
10091 (composition_adjust_point): Use EMACS_INT, not int.
10092 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10093 not EMACS_UINT, for indexes.
10095 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10097 * buffer.c: Include <verify.h>.
10098 (struct sortvec.priority, struct sortstr.priority):
10099 Now EMACS_INT, not int.
10100 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
10101 (struct sortstr.size, record_overlay_string)
10102 (struct sortstrlist.size, struct sortlist.used):
10103 Don't truncate size to int.
10104 (record_overlay_string): Check for size-calculation overflow.
10105 (init_buffer_once): Check at compile-time, not run-time.
10107 2011-06-22 Jim Meyering <meyering@redhat.com>
10109 Don't leak an XBM-image-sized buffer
10110 * image.c (xbm_load): Free the image buffer after using it.
10112 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10115 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10116 that Sun C diagnosed.
10117 * fns.c (secure_hash): Fix pointer signedness issue.
10118 * intervals.c (static_offset_intervals): New function.
10119 (offset_intervals): Use it.
10121 2011-06-21 Leo Liu <sdl.web@gmail.com>
10124 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10127 * fns.c (secure_hash): Rename from crypto_hash_function and change
10128 the first arg to accept symbols.
10129 (Fsecure_hash): New primitive.
10130 (syms_of_fns): New symbols.
10132 2011-06-20 Deniz Dogan <deniz@dogan.se>
10134 * process.c (Fset_process_buffer): Clarify return value in
10137 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
10139 * dispnew.c (add_window_display_history): Use BVAR.
10141 * xdisp.c (debug_method_add): Use BVAR.
10142 (check_window_end, dump_glyph_matrix, dump_glyph)
10143 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10145 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10148 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10149 check till after the cache is created in init_frame_faces.
10151 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10153 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10155 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10157 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10158 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10159 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10161 Improve buffer-overflow checking (Bug#8873).
10162 * fileio.c (Finsert_file_contents):
10163 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10164 Remove the old (too-loose) buffer overflow checks.
10165 They weren't needed, since make_gap checks for buffer overflow.
10166 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10167 The old code merely checked for Emacs fixnum overflow, and relied
10168 on undefined (wraparound) behavior. The new code avoids undefined
10169 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10171 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10172 Tune. Don't use wider integers than needed. Don't use alloca.
10173 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10175 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10177 * insdel.c, lisp.h (buffer_overflow): New function.
10178 (insert_from_buffer_1, replace_range, replace_range_2):
10179 * insdel.c (make_gap_larger):
10180 * editfns.c (Finsert_char):
10181 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10183 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10185 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10187 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10189 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10190 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10192 * fileio.c: Don't assume EMACS_INT fits in off_t.
10193 (emacs_lseek): New static function.
10194 (Finsert_file_contents, Fwrite_region): Use it.
10195 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10197 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10199 * fns.c: Don't overflow int when computing a list length.
10200 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10201 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10202 truncation on 64-bit hosts. Check for QUIT every
10203 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10204 faster and is responsive enough.
10205 (Flength): Report an error instead of overflowing an integer.
10206 (Fsafe_length): Return a float if the value is not representable
10207 as a fixnum. This shouldn't happen except in contrived situations.
10208 (Fnthcdr, Fsort): Don't assume list length fits in int.
10209 (Fcopy_sequence): Don't assume vector length fits in int.
10211 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10212 (header_size, word_size): New constants.
10213 (allocate_vectorlike): Don't check size overflow here.
10214 (allocate_vector): Check it here instead, since this is the only
10215 caller of allocate_vectorlike that could cause overflow.
10216 Check that the new vector's length is representable as a fixnum.
10218 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10219 The previous code was bogus. For example, next_almost_prime (32)
10220 returned 39, which is undesirable as it is a multiple of 3; and
10221 next_almost_prime (24) returned 25, which is a multiple of 5 so
10222 why was the code bothering to check for multiples of 7?
10224 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10226 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10228 Variadic C functions now count arguments with ptrdiff_t.
10229 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10230 Back then I didn't know that the Emacs coding style prefers signed int.
10231 Also, in the meantime I found a few more instances where arguments
10232 were being counted with int, which may truncate counts on 64-bit
10233 machines, or EMACS_INT, which may be unnecessarily wide.
10234 * lisp.h (struct Lisp_Subr.function.aMANY)
10235 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10236 Arg counts are now ptrdiff_t, not size_t.
10237 All variadic functions and their callers changed accordingly.
10238 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10239 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10240 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10241 * callint.c (Fcall_interactively): Check arg count for overflow,
10242 to avoid potential buffer overrun. Use signed char, not 'int',
10243 for 'varies' array, so that we needn't bother to check its size
10244 calculation for overflow.
10245 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10246 * eval.c (apply_lambda):
10247 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10248 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10249 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10251 * callint.c (Fcall_interactively): Don't use index var as event count.
10253 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10254 * mem-limits.h (SIZE): Remove; no longer used.
10256 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10258 Remove unnecessary casts.
10259 * xterm.c (x_term_init):
10260 * xfns.c (x_set_border_pixel):
10261 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10262 These aren't needed now that we assume ANSI C.
10264 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10265 It's more likely to cause problems (due to unsigned overflow)
10268 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10270 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10272 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10274 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10276 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10278 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10280 GLYPH_CODE_FACE returns EMACS_INT, not int.
10281 * dispextern.h (merge_faces):
10282 * xfaces.c (merge_faces):
10283 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10284 Don't assume EMACS_INT fits in int.
10286 * character.h (CHAR_VALID_P): Remove unused parameter.
10287 * fontset.c, lisp.h, xdisp.c: All uses changed.
10289 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10291 * fns.c (concat): Minor tuning based on overflow analysis.
10292 This doesn't fix any bugs. Use int to hold character, instead
10293 of constantly refetching from Emacs object. Use XFASTINT, not
10294 XINT, for value known to be a character. Don't bother comparing
10295 a single byte to 0400, as it's always less.
10297 * floatfns.c (Fexpt):
10298 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10300 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10303 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10305 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10306 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10307 incorrectly succeed when S was a string, because 4294967386 was
10308 truncated before it was used.
10310 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10311 Otherwise, an out-of-range integer could cause undefined behavior
10314 * composite.c: Use int, not EMACS_INT, for characters.
10315 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10316 EMACS_INT, for values that are known to be in character range.
10317 This doesn't fix any bugs but is the usual style inside Emacs and
10318 may generate better code on 32-bit machines.
10320 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10321 This is for reasons similar to the recent CHAR_STRING fix.
10322 * charset.c (Fencode_char): Check that character arg is actually
10323 a character. Pass an int to ENCODE_CHAR.
10324 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10325 wider than 'int', as a compile-time check to prevent future regressions
10328 * character.c (char_string): Remove unnecessary casts.
10330 Make sure a 64-bit char is never passed to CHAR_STRING.
10331 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10332 by silently ignoring the top 32 bits, allowing some values
10333 that were far too large to be valid characters.
10334 * character.h: Include <verify.h>.
10335 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10336 arguments are no wider than unsigned, as a compile-time check
10337 to prevent future regressions in this area.
10339 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10340 (Fsubst_char_in_region):
10342 * xdisp.c (decode_mode_spec_coding):
10343 Adjust to CHAR_STRING's new requirement.
10344 * editfns.c (Finsert_char, Fsubst_char_in_region):
10345 * fns.c (concat): Check that character args are actually
10346 characters. Without this test, these functions did the wrong
10347 thing with wildly out-of-range values on 64-bit hosts.
10349 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10350 These casts should not be needed on 32-bit hosts, either.
10351 * keyboard.c (read_char):
10352 * lread.c (Fload): Remove casts to unsigned.
10354 * lisp.h (UNSIGNED_CMP): New macro.
10355 This fixes comparison bugs on 64-bit hosts.
10356 (ASCII_CHAR_P): Use it.
10357 * casefiddle.c (casify_object):
10358 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10359 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10360 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10361 * dispextern.h (FACE_FROM_ID):
10362 * keyboard.c (read_char): Use UNSIGNED_CMP.
10364 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10365 not to EMACS_INT, to avoid GCC warning.
10367 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10369 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10370 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10371 isn't needed on 32-bit machines.
10373 * buffer.c (Fgenerate_new_buffer_name):
10374 Use EMACS_INT for count, not int.
10375 (advance_to_char_boundary): Return EMACS_INT, not int.
10377 * data.c (Qcompiled_function): Now static.
10379 * window.c (window_body_lines): Now static.
10381 * image.c (gif_load): Rename local to avoid shadowing.
10383 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10384 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10385 * alloc.c (make_save_value): Integer argument is now of type
10386 ptrdiff_t, not int.
10387 (mark_object): Use ptrdiff_t, not int.
10388 * lisp.h (pD): New macro.
10389 * print.c (print_object): Use it.
10391 * alloc.c: Use EMACS_INT, not int, to count objects.
10392 (total_conses, total_markers, total_symbols, total_vector_size)
10393 (total_free_conses, total_free_markers, total_free_symbols)
10394 (total_free_floats, total_floats, total_free_intervals)
10395 (total_intervals, total_strings, total_free_strings):
10396 Now EMACS_INT, not int. All uses changed.
10397 (Fgarbage_collect): Compute overall total using a double, so that
10398 integer overflow is less likely to be a problem. Check for overflow
10399 when converting back to an integer.
10400 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10401 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10402 These were 'int' variables that could overflow on 64-bit hosts;
10403 they were never used, so remove them instead of repairing them.
10404 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10405 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10406 Previously, this ceilinged at INT_MAX, but that doesn't work on
10408 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10410 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10411 (allocate_vectorlike): Check for ptrdiff_t overflow.
10412 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10413 when a (possibly-narrower) signed value would do just as well.
10414 We prefer using signed arithmetic, to avoid comparison confusion.
10416 * alloc.c: Catch some string size overflows that we were missing.
10417 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10418 for convenience in STRING_BYTES_MAX.
10419 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10420 The definition here is exact; the one in lisp.h was approximate.
10421 (allocate_string_data): Check for string overflow. This catches
10422 some instances we weren't catching before. Also, it catches
10423 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10424 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10425 and ptrdiff_t and EMACS_INT are both 64 bits.
10427 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10428 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10429 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10431 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10433 * alloc.c (Fmake_string): Check for out-of-range init.
10435 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10437 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10439 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10441 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10442 xg_get_default_scrollbar_width.
10444 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10445 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10446 (style_changed_cb): Call update_theme_scrollbar_width and call
10447 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10448 all frames (Bug#8505).
10449 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10450 Call gtk_window_set_resizable if HAVE_GTK3.
10451 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10452 and height if HAVE_GTK3 (Bug#8505).
10453 (scroll_bar_width_for_theme): New variable.
10454 (update_theme_scrollbar_width): New function.
10455 (xg_get_default_scrollbar_width): Move code to
10456 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10457 (xg_initialize): Call update_theme_scrollbar_width.
10459 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10461 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10463 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10465 * frame.c (make_frame): Call other_buffer_safely instead of
10468 * window.c (temp_output_buffer_show): Call display_buffer with
10469 second argument Vtemp_buffer_show_specifiers and reset latter
10470 immediately after the call.
10471 (Vtemp_buffer_show_specifiers): New variable.
10472 (auto_window_vscroll_p, next_screen_context_lines)
10473 (Vscroll_preserve_screen_position): Remove leading asterisks from
10476 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10478 Fix minor problems found by GCC 4.6.0 static checking.
10479 * buffer.c (Qclone_number): Remove for now, as it's unused.
10480 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10481 (record_buffer): Remove unused local.
10482 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10483 (set_frame_buffer_list): Remove; unused.
10484 * frame.h (other_visible_frames): Remove decl.
10485 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10486 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10487 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10489 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10490 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10491 Define only if HAVE_GPM.
10492 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10493 (update_hints_inhibit): Remove; never set. All uses removed.
10494 * widgetprv.h (emacsFrameClassRec): Remove decl.
10495 * window.c (delete_deletable_window): Now returns void, since it
10496 wasn't returning anything.
10497 (compare_window_configurations): Remove unused locals.
10498 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10499 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10500 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10501 the same widths as pointers. This follows up on the 2011-05-06 patch.
10502 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10503 * xterm.h: Likewise.
10504 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10506 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10508 * makefile.w32-in: Update dependencies.
10509 (LISP_H): Add lib/intprops.h.
10511 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10513 * image.c (gif_load): Add animation frame delay to the metadata.
10514 (syms_of_image): Use DEFSYM. New symbol `delay'.
10516 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10518 * window.c (delete_deletable_window): Re-add.
10519 (Fset_window_configuration): Rewrite to handle dead buffers and
10520 consequently deletable windows.
10521 (window_tree, Fwindow_tree): Remove. Supply functionality in
10523 (compare_window_configurations): Simplify code.
10525 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10527 * image.c (imagemagick_load_image): Fix type mismatch.
10528 (Fimagemagick_types): Likewise.
10530 * window.h (replace_buffer_in_windows): Declare.
10532 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10534 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10535 Qclone_number. Remove external declaration of Qdelete_window.
10536 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10538 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10539 Run Qbuffer_list_update_hook if allowed.
10540 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10541 buffer list implementation.
10542 (other_buffer_safely): New function.
10543 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10544 calls to replace_buffer_in_windows and
10545 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10547 (record_buffer): Inhibit quitting and rewrite using quittable
10548 functions. Run Qbuffer_list_update_hook if allowed.
10549 (Frecord_buffer, Funrecord_buffer): New functions.
10550 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10551 Move switch-to-buffer to window.el.
10552 (bury-buffer): Move to window.el.
10553 (Vbuffer_list_update_hook): New variable.
10555 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10558 * window.h (resize_frame_windows): Move up in code.
10559 (Fwindow_frame): Remove EXFUN.
10560 (replace_buffer_in_all_windows): Remove prototype.
10561 (replace_buffer_in_windows_safely): Add prototype.
10563 * window.c: Declare Qdelete_window static again. Move down
10564 declaration of select_count.
10565 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10566 (Fother_window): Move to window.el.
10567 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10568 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10569 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10571 (replace_buffer_in_windows): Implement by calling
10572 Qreplace_buffer_in_windows.
10573 (replace_buffer_in_all_windows): Remove with some functionality
10574 moved into replace_buffer_in_windows_safely.
10575 (replace_buffer_in_windows_safely): New function.
10576 (select_window_norecord, select_frame_norecord): Move in front
10577 of run_window_configuration_change_hook. Remove now obsolete
10579 (Fset_window_buffer): Rewrite doc-string.
10580 Call Qrecord_window_buffer.
10581 (keys_of_window): Move binding for other-window to window.el.
10583 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10585 * dispextern.h (struct image): Replace data member, whose int_val
10586 and ptr_val fields were not used by anything, with a single
10589 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10590 (gif_clear_image, gif_load, imagemagick_load_image)
10591 (gs_clear_image, gs_load): Callers changed.
10593 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10595 * buffer.h: Include <time.h>, for time_t.
10596 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10598 Fix minor problems found by static checking.
10600 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10602 Make identifiers static if they are not used in other modules.
10603 * data.c (Qcompiled_function, Qframe, Qvector):
10604 * image.c (QimageMagick, Qsvg):
10605 * minibuf.c (Qmetadata):
10606 * window.c (resize_window_check, resize_root_window): Now static.
10607 * window.h (resize_window_check, resize_root_window): Remove decls.
10609 * window.c (window_deletion_count, delete_deletable_window):
10611 (window_body_lines): Now static.
10612 (Fdelete_other_windows_internal): Mark vars as initialized.
10613 Make sure 'resize_failed' is initialized.
10614 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10615 (resize_window_apply): Remove unused local.
10616 * window.h (delete_deletable_window): Remove decl.
10618 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10619 (imagemagick_load_image): Fix pointer signedness problem by changing
10620 last arg from unsigned char * to char *. All uses changed.
10621 Also, fix a local for similar reasons.
10622 Remove unused locals. Remove locals to avoid shadowing.
10623 (fn_rsvg_handle_free): Remove; unused.
10624 (svg_load, svg_load_image): Fix pointer signedness problem.
10625 (imagemagick_load_image): Don't use garbage pointer image_wand.
10627 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10629 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10631 * image.c (gif_load): Fix omitted cast error introduced by
10634 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10636 * window.h (resize_proportionally, orig_total_lines)
10637 (orig_top_line): Remove from window structure.
10638 (set_window_height, set_window_width, change_window_heights)
10639 (Fdelete_window): Remove prototypes.
10640 (resize_frame_windows): Remove duplicate declaration.
10642 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10644 * window.h (resize_frame_windows, resize_window_check)
10645 (delete_deletable_window, resize_root_window)
10646 (resize_frame_windows): Declare prototypes.
10648 * window.c (resize_window_apply): Make definition be "static" to
10649 match the prototype.
10651 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10653 * window.c: Remove declarations of Qwindow_size_fixed,
10654 window_min_size_1, window_min_size_2, window_min_size,
10655 size_window, window_fixed_size_p, enlarge_window, delete_window.
10656 Remove static from declaration of Qdelete_window, it's
10657 temporarily needed by Fbury_buffer.
10658 (replace_window): Don't assign orig_top_line and
10660 (Fdelete_window, delete_window): Remove. Window deletion is
10661 handled by window.el.
10662 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10663 Replace Fdelete_window calls with calls to Qdelete_window.
10664 (Fdelete_other_windows): Remove. Deleting other windows is
10665 handled by window.el.
10666 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10667 handled in window.el.
10668 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10669 Window minimum sizes are handled in window.el.
10670 (shrink_windows, size_window, set_window_height)
10671 (set_window_width, change_window_heights, window_height)
10672 (window_width, CURBEG, CURSIZE, enlarge_window)
10673 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10674 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10675 handled in window.el.
10676 (make_dummy_parent): Rename to make_parent_window and give it a
10677 second argument horflag.
10678 (make_window): Don't set resize_proportionally any more.
10679 (Fsplit_window): Remove. Windows are split in window.el.
10680 (save_restore_action, save_restore_orig_size)
10681 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10682 Resize mini windows in window.el.
10683 (grow_mini_window, shrink_mini_window): Implement by calling
10684 Qresize_root_window_vertically, resize_window_check and
10685 resize_window_apply.
10686 (saved_window, Fset_window_configuration, save_window_save):
10687 Do not handle orig_top_line, orig_total_lines, and
10688 resize_proportionally.
10689 (window_min_height, window_min_width): Move to window.el.
10690 (keys_of_window): Move bindings for delete-other-windows,
10691 split-window, delete-window and enlarge-window to window.el.
10693 * buffer.c: Temporarily extern Qdelete_window.
10694 (Fbury_buffer): Temporarily call Qdelete_window instead of
10695 Fdelete_window (Fbury_buffer will move to window.el soon).
10697 * frame.c (set_menu_bar_lines_1): Remove code handling
10698 orig_top_line and orig_total_lines.
10700 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10701 set_window_height but set heights directly.
10702 (change_frame_size_1): Use resize_frame_windows.
10704 * xdisp.c (init_xdisp): Don't use set_window_height but set
10707 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10708 Use resize_frame_windows instead of change_window_heights and run
10709 run_window_configuration_change_hook.
10711 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10712 instead of change_window_heights and run
10713 run_window_configuration_change_hook.
10715 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10717 * window.c (replace_window): Rename second argument REPLACEMENT to
10718 NEW. New third argument SETFLAG. Rewrite.
10719 (delete_window, make_dummy_parent): Call replace_window with
10721 (window_list_1): Move down in code.
10722 (run_window_configuration_change_hook): Move set_buffer part
10723 before select_frame_norecord part in order to unwind correctly.
10724 Rename count1 to count.
10725 (recombine_windows, delete_deletable_window, resize_root_window)
10726 (Fdelete_other_windows_internal)
10727 (Frun_window_configuration_change_hook, make_parent_window)
10728 (resize_window_check, resize_window_apply, Fresize_window_apply)
10729 (resize_frame_windows, Fsplit_window_internal)
10730 (Fdelete_window_internal, Fresize_mini_window_internal):
10732 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10734 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10736 * window.h (window): Add some new members to window structure -
10737 normal_lines, normal_cols, new_total, new_normal, clone_number,
10738 splits, nest, prev_buffers, next_buffers.
10739 (WINDOW_TOTAL_SIZE): Move here from window.c.
10740 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10742 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10744 (make_dummy_parent): Set new members of windows structure.
10745 (make_window): Move down in code. Handle new members of window
10747 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10748 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10749 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10750 (Fset_window_prev_buffers, Fwindow_next_buffers)
10751 (Fset_window_next_buffers, Fset_window_clone_number):
10753 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10754 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10756 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10757 Argument WINDOW can be now internal window too.
10758 (Fwindow_use_time): Move up in code.
10759 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10760 Rewrite doc-string.
10761 (Fset_window_configuration, saved_window)
10762 (Fcurrent_window_configuration, save_window_save): Handle new
10763 members of window structure.
10764 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10765 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10766 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10767 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10768 Qget_mru_window, Qresize_root_window,
10769 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10770 Qauto_buffer_name; staticpro them.
10772 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10774 * window.c (Fwindow_total_size, Fwindow_left_column)
10775 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10776 (Fwindow_list_1): New functions.
10777 (window_box_text_cols): Replace with window_body_cols.
10778 (Fwindow_width, Fscroll_left, Fscroll_right):
10779 Use window_body_cols instead of window_box_text_cols.
10780 (delete_window, Fset_window_configuration):
10781 Call delete_all_subwindows with window as argument.
10782 (delete_all_subwindows): Take a window as argument and not a
10783 structure. Rewrite.
10784 (window_loop): Remove handling of GET_LRU_WINDOW and
10785 GET_LARGEST_WINDOW.
10786 (Fget_lru_window, Fget_largest_window): Move to window.el.
10788 * window.h: Extern window_body_cols instead of
10789 window_box_text_cols. delete_all_subwindows now takes a
10790 Lisp_Object as argument.
10792 * indent.c (compute_motion, Fcompute_motion):
10793 Use window_body_cols instead of window_box_text_cols.
10795 * frame.c (delete_frame): Call delete_all_subwindows with root
10796 window as argument.
10798 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10800 * fns.c (Fputhash): Document return value.
10802 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10804 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10806 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10808 Cons<->int and similar integer overflow fixes (Bug#8794).
10810 Check for overflow when converting integer to cons and back.
10811 * charset.c (Fdefine_charset_internal, Fdecode_char):
10812 Use cons_to_unsigned to catch overflow.
10813 (Fencode_char): Use INTEGER_TO_CONS.
10814 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10815 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10816 * data.c (long_to_cons, cons_to_long): Remove.
10817 (cons_to_unsigned, cons_to_signed): New functions.
10818 These signal an error for invalid or out-of-range values.
10819 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10820 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10821 * font.c (Ffont_variation_glyphs):
10822 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10823 * lisp.h: Include <intprops.h>.
10824 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10825 (cons_to_signed, cons_to_unsigned): New decls.
10826 (long_to_cons, cons_to_long): Remove decls.
10827 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10828 (Fprimitive_undo): Use CONS_TO_INTEGER.
10829 * xfns.c (Fx_window_property): Likewise.
10830 * xselect.c: Include <limits.h>.
10831 (x_own_selection, selection_data_to_lisp_data):
10832 Use INTEGER_TO_CONS.
10833 (x_handle_selection_request, x_handle_selection_clear)
10834 (x_get_foreign_selection, Fx_disown_selection_internal)
10835 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10836 (lisp_data_to_selection_data): Use cons_to_unsigned.
10837 (x_fill_property_data): Use cons_to_signed.
10838 Report values out of range.
10840 Check for buffer and string overflow more precisely.
10841 * buffer.h (BUF_BYTES_MAX): New macro.
10842 * lisp.h (STRING_BYTES_MAX): New macro.
10843 * alloc.c (Fmake_string):
10844 * character.c (string_escape_byte8):
10845 * coding.c (coding_alloc_by_realloc):
10846 * doprnt.c (doprnt):
10847 * editfns.c (Fformat):
10849 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10850 since they may not be the same number.
10851 * editfns.c (Finsert_char):
10852 * fileio.c (Finsert_file_contents):
10853 Likewise for BUF_BYTES_MAX.
10855 * image.c: Use ptrdiff_t, not int, for sizes.
10856 (slurp_file): Switch from int to ptrdiff_t.
10858 (slurp_file): Check that file size fits in both size_t (for
10859 malloc) and ptrdiff_t (for sanity and safety).
10861 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10862 if b->modtime has its maximal value.
10864 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10866 Don't assume time_t can fit into int.
10867 * buffer.h (struct buffer.modtime): Now time_t, not int.
10868 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10869 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10871 Minor fixes for signed vs unsigned integers.
10872 * character.h (MAYBE_UNIFY_CHAR):
10873 * charset.c (maybe_unify_char):
10874 * keyboard.c (read_char, reorder_modifiers):
10875 XINT -> XFASTINT, since the integer must be nonnegative.
10876 * ftfont.c (ftfont_spec_pattern):
10877 * keymap.c (access_keymap, silly_event_symbol_error):
10878 XUINT -> XFASTINT, since the integer must be nonnegative.
10879 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10880 since it makes no difference and we prefer signed.
10881 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10882 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10885 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10887 * window.h (Fwindow_frame): Declare.
10889 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10891 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10892 (SPARE_MEMORY): Always define.
10893 (LARGE_REQUEST): Remove.
10894 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10896 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10898 * lisp.h: Move EXFUNS for Fframe_root_window,
10899 Fframe_first_window and Fset_frame_selected_window to window.h.
10901 * window.h: Move EXFUNS for Fframe_root_window,
10902 Fframe_first_window and Fset_frame_selected_window here from
10905 * frame.c (Fwindow_frame, Fframe_first_window)
10906 (Fframe_root_window, Fframe_selected_window)
10907 (Fset_frame_selected_window): Move to window.c.
10908 (Factive_minibuffer_window): Move to minibuf.c.
10909 (Fother_visible_frames_p): New function.
10911 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10913 * window.c (decode_window, decode_any_window): Move up in code.
10914 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10915 (inhibit_frame_unsplittable): Remove unused variable.
10916 (Fwindow_buffer): Move up and rewrite doc-string.
10917 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10918 (Fwindow_prev): New functions.
10919 (Fwindow_frame): Move here from frame.c. Accept any window as
10921 (Fframe_root_window, Fframe_first_window)
10922 (Fframe_selected_window): Move here from frame.c. Accept frame
10923 or arbitrary window as argument. Update doc-strings.
10924 (Fminibuffer_window): Move up in code.
10925 (Fwindow_minibuffer_p): Move up in code and simplify.
10926 (Fset_frame_selected_window): Move here from frame.c.
10928 (Fselected_window, select_window, Fselect_window): Move up in
10929 code. Minor doc-string fixes.
10931 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10933 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10934 Do not assume that spare memory exists; that assumption is valid
10935 only if SYSTEM_MALLOC.
10936 (LARGE_REQUEST): New macro, so that the issue of large requests
10937 is separated from the issue of spare memory.
10939 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10941 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10944 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10946 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10949 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10951 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10953 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10955 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10956 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10958 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10960 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10962 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10964 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10965 (x_clipboard_manager_save): Add return value.
10966 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10967 New error handlers.
10968 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10969 Obey Vx_select_enable_clipboard_manager. Catch errors in
10970 x_clipboard_manager_save (Bug#8779).
10971 (Vx_select_enable_clipboard_manager): New variable.
10972 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10974 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10976 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10978 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10980 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10981 in the current matrix if keep_current_p is non-zero.
10983 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10985 * bidi.c (bidi_level_of_next_char): Fix last change.
10987 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10989 Support bidi reordering of text covered by display properties.
10991 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10992 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10993 (bidi_cache_search, bidi_cache_iterator_state)
10994 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10995 (bidi_level_of_next_char, bidi_move_to_visually_next):
10996 Support character positions inside a run of characters covered by a
10998 (bidi_paragraph_init, bidi_resolve_explicit_1)
10999 (bidi_level_of_next_char): Call bidi_fetch_char and
11000 bidi_fetch_char_advance instead of FETCH_CHAR and
11001 FETCH_CHAR_ADVANCE.
11002 (bidi_init_it): Initialize new members.
11003 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11005 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11006 instead of using explicit *_CHAR codes.
11007 (bidi_resolve_explicit, bidi_resolve_weak):
11008 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
11009 bidirectional text is supported only in multibyte buffers.
11010 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11011 it to initialize the frame_window_p member of struct bidi_it.
11012 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11013 (bidi_resolve_explicit, bidi_resolve_weak)
11014 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11015 bidi_it->nchars is non-positive.
11016 (bidi_level_of_next_char): Don't try to lookup the cache for the
11017 next/previous character if nothing is cached there yet, or if we
11018 were just reseat()'ed to a new position.
11020 * xdisp.c (set_cursor_from_row): Set start and stop points
11021 according to the row's direction when priming the loop that looks
11022 for the glyph on which to display cursor.
11023 (single_display_spec_intangible_p): Function deleted.
11024 (display_prop_intangible_p): Reimplement to call
11025 handle_display_spec instead of single_display_spec_intangible_p.
11026 Accept 3 additional arguments needed by handle_display_spec.
11027 This fixes incorrect cursor motion across display property with complex
11028 values: lists, `(when COND...)' forms, etc.
11029 (single_display_spec_string_p): Support property values that are
11030 lists with the argument STRING its top-level element.
11031 (display_prop_string_p): Fix the condition for processing a
11032 property that is a list to be consistent with handle_display_spec.
11033 (handle_display_spec): New function, refactored from the
11034 last portion of handle_display_prop.
11035 (compute_display_string_pos): Accept additional argument
11036 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11037 value of a `display' property is a "replacing spec".
11038 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11039 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11040 the display property, but just return a value indicating whether
11041 the display property will replace the characters it covers.
11042 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11043 frame_window_p members of struct bidi_it.
11044 (compute_display_string_pos, compute_display_string_end):
11046 (push_it): Accept second argument POSITION, where pop_it should
11047 jump to continue iteration.
11048 (reseat_1): Initialize bidi_it.disp_pos.
11050 * keyboard.c (adjust_point_for_property): Adjust the call to
11051 display_prop_intangible_p to its new signature.
11053 * dispextern.h (struct bidi_it): New member frame_window_p.
11054 (bidi_init_it): Update prototypes.
11055 (display_prop_intangible_p): Update prototype.
11056 (compute_display_string_pos, compute_display_string_end):
11057 Declare prototypes.
11058 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11061 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
11063 Malloc failure behavior now depends on size of allocation.
11064 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11065 * lisp.h: Change signatures accordingly.
11066 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11067 All callers changed. (Bug#8762)
11069 * gnutls.c: Use Emacs's memory allocators.
11070 Without this change, the gnutls library would invoke malloc etc.
11071 directly, which causes problems on non-SYNC_INPUT hosts, and which
11072 runs afoul of improving memory_full behavior. (Bug#8761)
11073 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11074 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11075 xfree instead of the default malloc, realloc, free.
11076 (Fgnutls_boot): No need to check for memory allocation failure,
11077 since xmalloc does that for us.
11079 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
11080 * category.c (hash_get_category_set):
11081 * ccl.c (ccl_driver):
11082 * charset.c (Fdefine_charset_internal):
11083 * charset.h (struct charset.hash_index):
11084 * composite.c (get_composition_id, gstring_lookup_cache)
11085 (composition_gstring_put_cache):
11086 * composite.h (struct composition.hash_index):
11087 * dispextern.h (struct image.hash):
11088 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11089 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11090 (hashfn_equal, hashfn_user_defined, make_hash_table)
11091 (maybe_resize_hash_table, hash_lookup, hash_put)
11092 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11093 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11094 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11095 * image.c (make_image, search_image_cache, lookup_image)
11096 (xpm_put_color_table_h):
11097 * lisp.h (struct Lisp_Hash_Table):
11098 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
11099 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
11100 for hashes and hash indexes, instead of 'unsigned' and 'int'.
11101 * alloc.c (allocate_vectorlike):
11102 Check for overflow in vector size calculations.
11103 * ccl.c (ccl_driver):
11104 Check for overflow when converting EMACS_INT to int.
11105 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11106 need to be updated by these changes.
11107 * fns.c (make_hash_table, maybe_resize_hash_table):
11108 Check for integer overflow with large hash tables.
11109 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11110 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11111 (SXHASH_REDUCE): New macro.
11112 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11113 Use it instead of discarding useful hash info with large hash values.
11114 (sxhash_float): New function.
11115 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11116 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
11117 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11118 Rewrite to use FIXNUM_BITS, as this simplifies things.
11119 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11120 Adjust signatures to match updated version of code.
11121 (consing_since_gc): Now EMACS_INT, since a single hash table can
11122 use more than INT_MAX bytes.
11124 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11126 Make it possible to build with GCC-4.6+ -O2 -flto.
11128 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11130 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11132 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11133 Call minibuffer-inactive-mode.
11135 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
11137 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11138 Update dependencies.
11140 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11142 * data.c (init_data): Remove code for UTS, this system is not
11145 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11147 Don't force ./temacs to start in terminal mode.
11149 * frame.c (make_initial_frame): Initialize faces in all cases, not
11150 only when CANNOT_DUMP is defined.
11151 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11153 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11155 * dispnew.c (add_window_display_history): Use const for the string
11156 pointer. Remove declaration, not needed.
11158 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11160 Use 'inline', not 'INLINE'.
11161 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
11162 * alloc.c, fontset.c (INLINE): Remove.
11163 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11164 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11165 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11166 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11167 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11169 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11171 Make it possible to run ./temacs.
11173 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11174 syms_of_callproc does the same thing. Remove test for
11175 "initialized", do it in the caller.
11176 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11178 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11180 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11181 (read_minibuf): Use get_minibuffer.
11182 (syms_of_minibuf): Use DEFSYM.
11183 (Qmetadata): New var.
11184 * data.c (Qbuffer): Don't make it static.
11185 (syms_of_data): Use DEFSYM.
11187 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11189 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11190 (CCL_CODE_MIN): New macro.
11192 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11194 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11196 * eval.c (Qdebug): Now static.
11197 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11198 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11199 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11201 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11203 * image.c: Various fixes to ImageMagick code comments.
11204 (Fimagemagick_types): Doc fix.
11206 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11208 Minor fixes prompted by GCC 4.6.0 warnings.
11210 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11212 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11213 (x_clipboard_manager_save_all): Move extern decl to ...
11214 * xterm.h: ... here, so that it can be checked for consistency.
11216 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11218 * xselect.c (x_clipboard_manager_save_frame)
11219 (x_clipboard_manager_save_all): New functions.
11220 (Fx_clipboard_manager_save): Lisp function deleted.
11222 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11223 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11225 * xterm.h: Update prototype.
11227 2011-05-28 William Xu <william.xwl@gmail.com>
11229 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11230 exiting (Bug#8239).
11232 2011-05-28 Jim Meyering <meyering@redhat.com>
11234 Avoid a sign-extension bug in crypto_hash_function.
11235 * fns.c (to_uchar): Define.
11236 (crypto_hash_function): Use it to convert some newly-signed
11237 variables to unsigned, to avoid sign-extension bugs. For example,
11238 without this change, (md5 "truc") would evaluate to
11239 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11240 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11241 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11243 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11245 Integer overflow fixes.
11247 * dbusbind.c: Serial number integer overflow fixes.
11248 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11249 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11250 to hold a serial number that is too large for a fixnum.
11251 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11252 Check for serial numbers out of range. Decode any serial number
11253 that was so large that it became a float. (Bug#8722)
11255 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11256 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11257 Use XFASTINT rather than XUINT when numbers are nonnegative.
11258 (xd_append_arg, Fdbus_method_return_internal):
11259 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11260 arguments, check that Lisp number is nonnegative, rather than
11261 silently wrapping negative numbers around. (Bug#8722)
11262 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11265 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11267 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11269 ccl: Add integer overflow checks.
11270 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11271 (IN_INT_RANGE): New macros.
11272 (ccl_driver): Use them to check for integer overflow when
11273 decoding a CCL program. Many of the new checks are whether XINT (x)
11274 fits in int; it doesn't always, on 64-bit hosts. The new version
11275 doesn't catch all possible integer overflows, but it's an
11276 improvement. (Bug#8719)
11278 * alloc.c (make_event_array): Use XINT, not XUINT.
11279 There's no need for unsigned here.
11281 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11282 This follows up to the 2011-05-06 change that substituted uintptr_t
11283 for EMACS_INT. This case wasn't caught back then.
11285 Rework Fformat to avoid integer overflow issues.
11286 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11287 now (part of C89). Include <verify.h>.
11288 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11289 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11290 (Fformat): Avoid the prepass trying to compute sizes; it was only
11291 approximate and thus did not catch overflow reliably. Instead, walk
11292 through the format just once, formatting and computing sizes as we go,
11293 checking for integer overflow at every step, and allocating a larger
11294 buffer as needed. Keep track separately whether the format is
11295 multibyte. Keep only the most-recently calculated precision, rather
11296 than them all. Record whether each argument has been converted to
11297 string. Use EMACS_INT, not int, for byte and char and arg counts.
11298 Support field widths and precisions larger than INT_MAX. Avoid
11299 sprintf's undefined behavior with conversion specifications such as %#d
11300 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11301 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11302 formatting out-of-range floating point numbers with int
11303 formats. (Bug#8668)
11305 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11307 * data.c: Avoid integer truncation in expressions involving floats.
11308 * data.c: Include <intprops.h>.
11309 (arith_driver): When there's an integer overflow in an expression
11310 involving floating point, convert the integers to floating point
11311 so that the resulting value does not suffer from catastrophic
11312 integer truncation. For example, on a 64-bit host (* 4
11313 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11314 Do not rely on undefined behavior after integer overflow.
11316 merge count_size_as_multibyte, parse_str_to_multibyte
11317 * character.c, character.h (count_size_as_multibyte):
11318 Rename from parse_str_to_multibyte; all uses changed.
11319 Check for integer overflow.
11320 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11321 since it's now a duplicate of the other. This is more of
11322 a character than a buffer op, so better that it's in character.c.
11323 * fns.c, print.c: Adjust to above changes.
11325 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11327 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11329 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11331 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11332 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11333 (x_clipboard_manager_save): Now static.
11334 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11336 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11337 (crypto_hash_function): Now static.
11338 Fix pointer signedness problems. Avoid unnecessary initializations.
11340 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11342 * termhooks.h (Vselection_alist): Make it terminal-local.
11344 * terminal.c (create_terminal): Initialize it.
11346 * xselect.c: Support for clipboard managers.
11347 (Vselection_alist): Move to termhooks.h as terminal-local var.
11348 (LOCAL_SELECTION): New macro.
11349 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11350 (symbol_to_x_atom): Remove gratuitous arg.
11351 (x_handle_selection_request, lisp_data_to_selection_data)
11352 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11353 (x_own_selection, x_get_local_selection, x_convert_selection):
11354 New arg, specifying work frame. Use terminal-local Vselection_alist.
11355 (some_frame_on_display): Delete unused function.
11356 (Fx_own_selection_internal, Fx_get_selection_internal)
11357 (Fx_disown_selection_internal, Fx_selection_owner_p)
11358 (Fx_selection_exists_p): New optional frame arg.
11359 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11360 (x_handle_selection_clear): Don't treat other terminals with the
11361 same keyboard specially. Use the terminal-local Vselection_alist.
11362 (x_clear_frame_selections): Use Frun_hook_with_args.
11364 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11366 * xterm.h: Add support for those atoms.
11368 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11370 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11371 (converted_selections, conversion_fail_tag): New global variables.
11372 (x_selection_request_lisp_error): Free the above.
11373 (x_get_local_selection): Remove unnecessary code.
11374 (x_reply_selection_request): Args changed; handle arbitrary array
11375 of converted selections stored in converted_selections.
11376 Separate the XChangeProperty and SelectionNotify steps.
11377 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11378 (x_convert_selection): New function.
11379 (x_handle_selection_event): Simplify.
11380 (x_get_foreign_selection): Don't ignore incoming requests while
11381 waiting for an answer; this will fail when we implement
11382 SAVE_TARGETS, and seems unnecessary anyway.
11383 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11384 (Vx_sent_selection_functions): Doc fix.
11386 2011-05-26 Leo Liu <sdl.web@gmail.com>
11388 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11390 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11392 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11394 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11395 for fringe update if it has periodic bitmap.
11396 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11397 and fringe_bitmap_periodic_p.
11399 * fringe.c (get_fringe_bitmap_data): New function.
11400 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11401 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11402 row. Mark glyph row for fringe update if periodicity changed.
11404 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11405 for fringe update unless it has periodic bitmap.
11407 2011-05-25 Kenichi Handa <handa@m17n.org>
11409 * xdisp.c (get_next_display_element): Set correct it->face_id for
11410 a static composition.
11412 2011-05-24 Leo Liu <sdl.web@gmail.com>
11415 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11417 * fns.c (crypto_hash_function, Fsha1): New function.
11418 (Fmd5): Use crypto_hash_function.
11419 (syms_of_fns): Add Ssha1.
11421 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11423 * gnutls.c: Remove unused macros.
11424 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11425 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11426 Remove macros that are defined and never used.
11427 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11429 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11431 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11432 (Fx_get_selection_internal): Minor cleanup.
11433 (Fx_own_selection_internal): Rename arguments for consistency with
11436 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11438 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11440 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11442 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11444 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11446 * dispnew.c (scrolling_window): Don't exclude the case that the
11447 last enabled row in the desired matrix touches the bottom boundary.
11449 2011-05-21 Glenn Morris <rgm@gnu.org>
11451 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11452 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11453 and add some more files.
11455 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11457 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11458 report_file_error introduced by the change from 2011-05-07.
11460 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11462 * systime.h (Time): Define only if emacs is defined.
11463 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11464 where the include path doesn't have X11/X.h by default. See
11465 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11467 2011-05-20 Kenichi Handa <handa@m17n.org>
11469 * composite.c (find_automatic_composition): Fix previous change.
11471 2011-05-20 Glenn Morris <rgm@gnu.org>
11473 * lisp.mk: New file, split from Makefile.in.
11474 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11475 (shortlisp): Remove.
11476 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11478 2011-05-19 Glenn Morris <rgm@gnu.org>
11480 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11481 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11482 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11483 (lisp): Set the order to that of loadup.el.
11484 (shortlisp): Make it a copy of $lisp.
11485 (SOME_MACHINE_LISP): Remove.
11486 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11487 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11489 2011-05-18 Kenichi Handa <handa@m17n.org>
11491 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11492 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11493 (find_automatic_composition): Mostly rewrite for efficiency.
11495 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11497 * makefile.w32-in: Update dependencies.
11499 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11501 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11502 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11504 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11506 Fix some integer overflow issues, such as string length overflow.
11508 * insdel.c (count_size_as_multibyte): Check for string overflow.
11510 * character.c (lisp_string_width): Check for string overflow.
11511 Use EMACS_INT, not int, for string indexes and lengths; in
11512 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11513 the resulting string length overflows an EMACS_INT; instead,
11514 report a string overflow if no precision given. When checking for
11515 precision exhaustion, use a check that cannot possibly have
11516 integer overflow. (Bug#8675)
11517 * character.h (lisp_string_width): Adjust to new signature.
11519 * alloc.c (string_overflow): New function.
11520 (Fmake_string): Use it. This doesn't change behavior, but saves
11521 a few bytes and will simplify future changes.
11522 * character.c (string_escape_byte8): Likewise.
11523 * lisp.h (string_overflow): New decl.
11525 Fixups, following up to the user-interface timestamp change.
11526 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11527 for UI timestamps, instead of unsigned long.
11528 * msdos.c (mouse_get_pos): Likewise.
11529 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11530 * w32gui.h (Time): Define by including "systime.h" rather than by
11531 declaring it ourselves. (Bug#8664)
11533 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11534 * image.c (clear_image_cache): Likewise.
11536 * term.c (term_mouse_position): Don't assume time_t wraparound.
11538 Be more systematic about user-interface timestamps.
11539 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11540 and sometimes 'EMACS_UINT', to represent these timestamps.
11541 This change causes it to use 'Time' uniformly, as that's what X uses.
11542 This makes the code easier to follow, and makes it easier to catch
11543 integer overflow bugs such as Bug#8664.
11544 * frame.c (Fmouse_position, Fmouse_pixel_position):
11545 Use Time, not unsigned long, for user-interface timestamps.
11546 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11547 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11548 * keyboard.h (last_event_timestamp): Likewise.
11549 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11550 * menu.h (xmenu_show): Likewise.
11551 * term.c (term_mouse_position): Likewise.
11552 * termhooks.h (struct input_event.timestamp): Likewise.
11553 (struct terminal.mouse_position_hook): Likewise.
11554 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11555 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11556 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11557 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11558 what it was before.
11559 * menu.h, termhooks.h: Include "systime.h", for Time.
11561 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11562 Don't assume that the difference between two unsigned long values
11563 can fit into an integer. At this point, we know button_down_time
11564 <= event->timestamp, so the difference must be nonnegative, so
11565 there's no need to cast the result if double-click-time is
11566 nonnegative, as it should be; check that it's nonnegative, just in
11567 case. This bug is triggered when events are more than 2**31 ms
11568 apart (about 25 days). (Bug#8664)
11570 * xselect.c (last_event_timestamp): Remove duplicate decl.
11571 (x_own_selection): Remove needless cast to unsigned long.
11573 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11574 that always fit in int. Use a sentinel instead of a counter, to
11575 avoid a temp and to allay GCC's concerns about possible int overflow.
11576 * frame.h (struct frame): Use int for menu_bar_items_used
11577 instead of EMACS_INT, since it always fits in int.
11579 * menu.c (grow_menu_items): Check for int overflow.
11581 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11583 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11584 Before, the code was not consistent. These values cannot exceed
11585 2**31 - 1 so there's no need to make them unsigned.
11586 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11587 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11588 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11590 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11592 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11593 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11594 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11595 presumably because the widths might not match.
11597 * window.c (size_window): Avoid needless test at loop start.
11599 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11601 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11603 2011-05-12 Drew Adams <drew.adams@oracle.com>
11605 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11607 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11609 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11610 `width' to `bar_area_x' and `bar_area_width', respectively.
11611 (x_scroll_run): Take account of fringe background extension.
11613 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11614 Rename local vars `left' and `width' to `bar_area_x' and
11615 `bar_area_width', respectively.
11616 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11617 background extension.
11619 2011-05-10 Jim Meyering <meyering@redhat.com>
11621 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11623 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11625 * image.c (Finit_image_library): Return t for built-in image types,
11626 like pbm and xbm. (Bug#8640)
11628 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11630 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11632 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11634 * w32console.c (Fset_screen_color): Doc fix.
11635 (Fget_screen_color): New function.
11636 (syms_of_ntterm): Defsubr it.
11638 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11639 unlink the temporary file if Fcall_process didn't create it in the
11641 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11642 child process will be redirected to a file specified with `:file'.
11643 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11644 cue to call_process_cleanup not to close that handle.
11646 2011-05-07 Ben Key <bkey76@gmail.com>
11648 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11649 one of two shell specific rules, either bootstrap-temacs-CMD or
11650 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11651 to the previous implementation of the bootstrap-temacs rule.
11652 The bootstrap-temacs-CMD rule is similar to the previous
11653 implementation of the bootstrap-temacs rule except that it
11654 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11657 These changes, along with some changes to nt/configure.bat,
11658 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11659 earlier fix to add support for --cflags and --ldflags options
11660 that include quotes so that it works whether make uses cmd or
11663 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11665 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11666 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11668 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11669 a string. Handle both cases.
11670 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11671 (Fdbus_register_method): Use Qinvalid_function.
11673 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11675 * makefile.w32-in: Update dependencies.
11676 (LISP_H): Add inttypes.h and stdin.h.
11677 (PROCESS_H): Add unistd.h.
11679 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11681 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11682 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11684 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11686 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11688 * term.c (vfatal): Remove stray call to va_end.
11689 It's not needed and the C Standard doesn't allow it here anyway.
11691 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11692 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11694 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11697 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11699 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11701 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11703 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11705 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11707 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11708 * charset.c (Fdefine_charset_internal): Don't initialize
11709 charset.code_space[15]. The value was garbage, on hosts with
11710 32-bit int (Bug#8600).
11712 * lread.c (read_integer): Be more consistent with string-to-number.
11713 Use string_to_number to do the actual conversion; this avoids
11714 rounding errors and fixes some other screwups. Without this fix,
11715 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11716 (digit_to_number): Move earlier, for benefit of read_integer.
11717 Return -1 if the digit is out of range for the base, -2 if it is
11718 not a digit in any supported base. (Bug#8602)
11720 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11722 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11723 to match comment at start of function. This also removes a
11724 GCC warning about overflow in a 32+64-bit port.
11726 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11728 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11729 Reported by Stefan Monnier in
11730 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11731 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11732 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11734 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11735 (EMACS_UINTPTR): Likewise, with uintptr_t.
11737 * lisp.h: Prefer 64-bit EMACS_INT if available.
11738 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11739 on 32-bit hosts that have 64-bit int, so that they can access
11741 However, temporarily disable this change unless the temporary
11742 symbol WIDE_EMACS_INT is defined.
11744 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11746 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11747 This removes an assumption that EMACS_INT and long are the same
11748 width as pointers. The assumption is true for Emacs porting targets
11749 now, but we want to make other targets possible.
11750 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11751 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11752 In the rest of the code, change types of integers that hold casted
11753 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11754 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11755 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11756 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11757 No need to cast type when ORing.
11758 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11759 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11760 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11761 assume EMACS_INT is the same width as char *.
11762 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11763 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11764 Remove no-longer-needed casts.
11765 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11766 (xg_tool_bar_help_callback, xg_make_tool_item):
11767 Use EMACS_INTPTR to hold an integer
11768 that will be cast to void *; this can avoid a GCC warning
11769 if EMACS_INT is not the same width as void *.
11770 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11771 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11772 (current_message_1, set_message_1):
11773 Use a local to convert to proper width without a cast.
11774 * xmenu.c (dialog_selection_callback): Likewise.
11776 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11777 Also, don't assume VALBITS / RAND_BITS is less than 5,
11778 and don't rely on undefined behavior when shifting a 1 left into
11780 * lisp.h (get_random): Change signature to match.
11782 * lread.c (hash_string): Use size_t, not int, for hash computation.
11783 Normally we prefer signed values; but hashing is special, because
11784 it's better to use unsigned division on hash table sizes so that
11785 the remainder is nonnegative. Also, size_t is the natural width
11786 for hashing into memory. The previous code used 'int', which doesn't
11787 retain enough info to hash well into very large tables.
11788 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11790 * dbusbind.c: Don't possibly lose pointer info when converting.
11791 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11792 Use XPNTR rather than XHASH, so that the high-order bits of
11793 the pointer aren't lost when converting through void *.
11795 * eval.c (Fautoload): Don't double-shift a pointer.
11797 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11799 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11801 * gnutls.c (DEF_GNUTLS_FN):
11802 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11804 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11806 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11809 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11811 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11812 New version that can reserve upto 2GB of heap space.
11814 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11816 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11818 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11820 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11821 `gnutls_certificate_set_x509_key_file'.
11823 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11825 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11826 Update dependencies.
11828 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11830 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11831 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11832 Remove unused parameter `fildes'.
11833 * process.c (read_process_output, send_process): Don't pass it.
11835 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11837 Fix previous change: the library cache is defined in w32.c.
11838 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11839 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11841 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11843 Implement dynamic loading of GnuTLS on Windows.
11845 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11846 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11847 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11850 * gnutls.c (Qgnutls_dll): Define.
11851 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11852 (gnutls_*): Declare function pointers.
11853 (init_gnutls_functions): New function to initialize function pointers.
11854 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11855 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11856 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11857 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11858 (emacs_gnutls_write, emacs_gnutls_read)
11859 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11860 (Fgnutls_available_p): New function.
11861 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11862 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11863 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11865 * image.c: Include w32.h.
11866 (Vimage_type_cache): Delete.
11867 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11868 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11869 (w32_delayed_load): Move to w32.c.
11871 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11873 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11874 (w32_delayed_load): Move from image.c. When loading a library, record
11875 its filename in the :loaded-from property of the library id.
11876 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11877 Initialize and staticpro them.
11878 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11880 * process.c: Include lisp.h before w32.h, not after.
11881 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11882 instead of gnutls_record_check_pending.
11884 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11886 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11888 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11889 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11892 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11894 * xterm.c (x_set_frame_alpha): Do not set property on anything
11895 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11897 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11899 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11901 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11903 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11904 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11905 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11906 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11907 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11908 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11909 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11910 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11911 (Qgnutls_bootprop_callbacks_verify): Make static.
11913 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11915 * callproc.c: Indentation fixup.
11917 * sysdep.c (wait_for_termination_1): Make static.
11918 (wait_for_termination, interruptible_wait_for_termination):
11919 Move after wait_for_termination_1.
11921 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11923 * sysdep.c (interruptible_wait_for_termination): New function
11924 which is like wait_for_termination, but allows keyboard
11927 * callproc.c (Fcall_process): Add (:file "file") as an option for
11929 (Fcall_process_region): Ditto.
11931 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11933 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11934 rather than `XVECTOR (FOO)->size'.
11936 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11937 inttypes.h, as a gnulib replacement is used if it not available in
11940 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11942 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11943 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11944 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11946 * coding.c (coding_alloc_by_realloc): Error out if destination
11947 will grow beyond MOST_POSITIVE_FIXNUM.
11948 (decode_coding_emacs_mule): Abort if there isn't enough place in
11949 charbuf for the composition carryover bytes. Reserve an extra
11950 space for up to 2 characters produced in a loop.
11951 (decode_coding_iso_2022): Abort if there isn't enough place in
11952 charbuf for the composition carryover bytes.
11954 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11956 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11957 aborting when %lld or %lll format is passed.
11958 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11959 %llo or %llx format is passed. (Bug#8545)
11961 * window.c (window_scroll_line_based): Use a marker instead of
11962 simple variables to record original value of point. (Bug#7952)
11964 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11965 produced by %s or %c overflows available buffer space. (Bug#8545)
11967 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11969 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11970 (SIZE_MAX): Move defn after all includes, as they might #define it.
11972 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11974 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11976 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11978 * keyboard.c (Qdelayed_warnings_hook): Define.
11979 (command_loop_1): Run `delayed-warnings-hook'
11980 if Vdelayed_warnings_list is non-nil.
11981 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11982 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11984 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11986 * doprnt.c (doprnt): Don't return value smaller than the buffer
11987 size if the message was truncated. (Bug#8545).
11989 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11991 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11992 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11994 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11996 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11998 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
12000 * makefile.w32-in: Update dependencies.
12002 2011-04-27 Eli Zaretskii <eliz@gnu.org>
12004 Improve `doprnt' and its usage. (Bug#8545)
12005 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12006 `format_end'. Remove support for %l as a conversion specifier.
12007 Don't use xrealloc. Improve diagnostics when the %l size modifier
12008 is used. Update the commentary.
12010 * eval.c (verror): Simplify calculation of size_t.
12012 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12015 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12017 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12020 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12022 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12023 This makes this file independent of the recent pseudovector change.
12025 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
12027 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12029 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
12030 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
12031 Remove unused local.
12032 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
12034 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
12035 GCC 4.6.0 optimizes based on type-based alias analysis.
12036 For example, if b is of type struct buffer * and v of type struct
12037 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12038 != &v->size, and therefore "v->size = 1; b->size = 2; return
12039 v->size;" must therefore return 1. This assumption is incorrect
12040 for Emacs, since it type-puns struct Lisp_Vector * with many other
12041 types. To fix this problem, this patch adds a new type struct
12042 vectorlike_header that documents the constraints on layout of vectors
12043 and pseudovectors, and helps optimizing compilers not get fooled
12044 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12045 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
12046 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12048 (XSETPVECTYPE): Rewrite in terms of new macro.
12049 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12050 This is a bit clearer, and further avoids the possibility of
12051 undesirable aliasing.
12052 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
12053 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
12054 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12055 since Lisp_Subr is a special case (no "next" field).
12056 (ASIZE): Now uses header.size rather than size.
12057 All previous uses of XVECTOR (foo)->size replaced to use this macro,
12058 to avoid the hassle of writing XVECTOR (foo)->header.size.
12059 (struct vectorlike_header): New type.
12060 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12061 object, to help avoid aliasing.
12062 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12063 (SUBRP): Likewise, since Lisp_Subr is a special case.
12064 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12065 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12066 (struct Lisp_Hash_Table): Combine first two members into a single
12067 struct vectorlike_header member. All uses of "size" and "next" members
12068 changed to be "header.size" and "header.next".
12069 * buffer.h (struct buffer): Likewise.
12070 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12071 * frame.h (struct frame): Likewise.
12072 * process.h (struct Lisp_Process): Likewise.
12073 * termhooks.h (struct terminal): Likewise.
12074 * window.c (struct save_window_data, struct saved_window): Likewise.
12075 * window.h (struct window): Likewise.
12076 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12077 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12078 * buffer.c (init_buffer_once): Likewise.
12079 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12081 * process.c (Fformat_network_address): Use local var for size,
12084 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12086 Make the Lisp reader and string-to-float more consistent (Bug#8525)
12087 * data.c (atof): Remove decl; no longer used or needed.
12088 (digit_to_number): Move to lread.c.
12089 (Fstring_to_number): Use new string_to_number function, to be
12090 consistent with how the Lisp reader treats infinities and NaNs.
12091 Do not assume that floating-point numbers represent EMACS_INT
12092 without losing information; this is not true on most 64-bit hosts.
12093 Avoid double-rounding errors, by insisting on integers when
12094 parsing non-base-10 numbers, as the documentation specifies.
12095 * lisp.h (string_to_number): New decl, replacing ...
12096 (isfloat_string): Remove.
12097 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
12098 (read1): Do not accept +. and -. as integers; this
12099 appears to have been a coding error. Similarly, do not accept
12100 strings like +-1e0 as floating point numbers. Do not report
12101 overflow for integer overflows unless the base is not 10 which
12102 means we have no simple and reliable way to continue.
12103 Break out the floating-point parsing into a new
12104 function string_to_number, so that Fstring_to_number parses
12105 floating point numbers consistently with the Lisp reader.
12106 (digit_to_number): Move here from data.c. Make it static inline.
12107 (E_CHAR, EXP_INT): Remove, replacing with ...
12108 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12109 (string_to_number): New function, replacing isfloat_string.
12110 This function checks for valid syntax and produces the resulting
12111 Lisp float number too. Rework it so that string-to-number
12112 no longer mishandles examples like "1.0e+". Use strtoumax,
12113 so that overflow for non-base-10 numbers is reported only when
12114 there's no portable and simple way to convert to floating point.
12116 * textprop.c (set_text_properties_1): Rewrite for clarity,
12117 and to avoid GCC warning about integer overflow.
12119 * intervals.h (struct interval): Use EMACS_INT for members
12120 where EMACS_UINT might cause problems. See
12121 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12122 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12123 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12125 (offset_intervals): Tell GCC not to worry about length overflow
12126 when negating a negative length.
12128 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12129 (overrun_check_free): Likewise.
12131 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12132 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12135 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12136 (gnutls_make_error): Rename local to avoid shadowing.
12137 (gnutls_emacs_global_deinit): ifdef out; not used.
12138 (Fgnutls_boot): Use const for pointer to readonly storage.
12139 Comment out unused local. Fix pointer signedness problems.
12141 * lread.c (openp): Don't stuff size_t into an 'int'.
12142 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12143 about possible signed overflow.
12145 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12146 (GDK_KEY_g): Don't define if already defined.
12147 (xg_prepare_tooltip): Avoid pointer signedness problem.
12148 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12150 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12151 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12153 * xfns.c (Fx_window_property): Simplify a bit,
12154 to make a bit faster and to avoid GCC 4.6.0 warning.
12155 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12157 * fns.c (internal_equal): Don't assume size_t fits in int.
12159 * alloc.c (compact_small_strings): Tighten assertion a little.
12161 Replace pEd with more-general pI, and fix some printf arg casts.
12162 * lisp.h (pI): New macro, generalizing old pEd macro to other
12163 conversion specifiers. For example, use "...%"pI"d..." rather
12164 than "...%"pEd"...".
12165 (pEd): Remove. All uses replaced with similar uses of pI.
12166 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
12167 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12168 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12169 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12170 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12171 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12172 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12174 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12175 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12176 * print.c (safe_debug_print, print_object): Likewise.
12177 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12179 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12180 avoiding the 0 flag, which is not portable.
12181 * process.c (Fmake_network_process): Use pI to avoid cast.
12182 * region-cache.c (pp_cache): Likewise.
12183 * xdisp.c (decode_mode_spec): Likewise.
12184 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12185 behavior on 64-bit hosts with printf arg.
12186 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12187 (x_stop_queuing_selection_requests): Likewise.
12188 (x_get_window_property): Don't truncate byte count to an 'int'
12191 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12192 here, since it parses constructs like leading '-' and spaces,
12193 which are not wanted; and it overflows with large numbers.
12194 Instead, simply match F[0-9]+, which is what is wanted anyway.
12196 * alloc.c: Remove unportable assumptions about struct layout.
12197 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12198 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12199 (allocate_vectorlike, make_pure_vector): Use the new macros,
12200 plus offsetof, to remove unportable assumptions about struct layout.
12201 These assumptions hold on all porting targets that I know of, but
12202 they are not guaranteed, they're easy to remove, and removing them
12203 makes further changes easier.
12205 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12206 This doesn't fix a bug but makes the code clearer.
12207 (string_overrun_cookie): Now const. Use initializers that
12208 don't formally overflow signed char, to avoid warnings.
12209 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12210 can cause Emacs to crash when string overrun checking is enabled.
12211 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12212 multiple of sizeof (EMACS_INT); it need not be, if
12213 alignof(EMACS_INT) < sizeof (EMACS_INT).
12214 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12216 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12218 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12220 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12222 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12223 supposed to be handshaking. (Bug#8556)
12224 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12226 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12228 * lisp.h (Qdebug): List symbol.
12229 * eval.c (Qdebug): Restore global linkage.
12230 * keyboard.c (debug-on-event): New variable.
12231 (handle_user_signal): Break into debugger when debug-on-event
12232 matches the current signal symbol.
12234 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12236 * alloc.c (check_sblock, check_string_bytes)
12237 (check_string_free_list): Convert to standard C.
12239 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12241 * w32.c (emacs_gnutls_push): Fix typo.
12243 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12245 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12246 "cast to pointer from integer of different size".
12248 Improve doprnt and its use in verror. (Bug#8545)
12249 * doprnt.c (doprnt): Document the set of format control sequences
12250 supported by the function. Use SAFE_ALLOCA instead of always
12253 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12254 is one byte too soon. Don't use xrealloc; instead xfree and
12257 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12259 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12262 * gnutls.c: Renamed global_initialized to
12263 gnutls_global_initialized. Added internals for the
12264 :verify-hostname-error, :verify-error, and :verify-flags
12265 parameters of `gnutls-boot' and documented those parameters in the
12266 docstring. Start callback support.
12267 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12268 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12269 on error. Return error code.
12270 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12271 (emacs_gnutls_read): Likewise.
12272 (Fgnutls_boot): Return handshake error code.
12273 (emacs_gnutls_handle_error): New function.
12274 (wsaerror_to_errno): Likewise.
12276 * w32.h (emacs_gnutls_pull): Add prototype.
12277 (emacs_gnutls_push): Likewise.
12279 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12280 (emacs_gnutls_push): Likewise.
12282 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12284 * process.c (wait_reading_process_output): Check if GnuTLS
12285 buffered some data internally if no FDs are set for TLS
12288 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12289 (LIBS): Link to USER_LIBS.
12290 ($(BLD)/gnutls.$(0)): New target.
12292 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12294 * xdisp.c (handle_single_display_spec): Rename the
12295 display_replaced_before_p argument into display_replaced_p, to
12296 make it consistent with the commentary. Fix typos in the
12299 * textprop.c (syms_of_textprop): Remove dead code.
12300 (copy_text_properties): Delete obsolete commentary about an
12301 interface that was deleted long ago. Fix typos in the description
12304 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12305 to changes in oldXMenu/XMenu.h from 2011-04-16.
12306 <menu_help_message, prev_menu_help_message>: Constify.
12307 (IT_menu_make_room): menu->help_text is now `const char **';
12310 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12311 to changes in oldXMenu/XMenu.h from 2011-04-16.
12312 (struct XMenu): Declare `help_text' `const char **'.
12314 * xfaces.c <Qunspecified>: Make extern again.
12316 * syntax.c: Include sys/types.h before including regex.h, as
12319 * doc.c (get_doc_string): Improve the format passed to `error'.
12321 * doprnt.c (doprnt): Improve commentary.
12323 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12325 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12328 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12329 changes in globals.h immediately force recompilation.
12330 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12331 $(CURDIR)/s/ms-w32.h.
12332 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12334 * character.c (Fchar_direction): Function deleted.
12335 (syms_of_character): Don't defsubr it.
12336 <char-direction-table>: Deleted.
12338 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12340 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12341 * doprnt.c: Include limits.h.
12342 (SIZE_MAX): New macro.
12343 (doprnt): Return a size_t value. 2nd arg is now size_t.
12344 Many local variables are now size_t instead of int or unsigned.
12345 Improve overflow protection. Support `l' modifier for integer
12346 conversions. Support %l conversion. Don't assume an EMACS_INT
12347 argument for integer conversions and for %c.
12349 * lisp.h (doprnt): Restore prototype.
12351 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12352 $(SRC)/character.h.
12354 * Makefile.in (base_obj): Add back doprnt.o.
12356 * deps.mk (doprnt.o): Add back prerequisites.
12357 (callint.o): Depend on character.h.
12359 * eval.c (internal_lisp_condition_case): Include the handler
12360 representation in the error message.
12361 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12362 when breaking from the loop.
12364 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12366 * callint.c (Fcall_interactively): When displaying error message
12367 about invalid control letter, pass the character's codepoint, not
12368 a pointer to its multibyte form. Improve display of the character
12369 in octal and display also its hex code.
12371 * character.c (char_string): Use %x to display the (unsigned)
12372 codepoint of an invalid character, to avoid displaying a bogus
12375 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12376 `error', not SYMBOL_NAME itself.
12378 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12379 character arguments to `error'.
12381 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12382 to `error' in error message about FINAL_CHAR argument. Make sure
12383 FINAL_CHAR is a character, and use %c when it is passed as
12384 argument to `error'.
12386 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12388 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12390 * w32.c: Include <time.h>.
12391 (sys_localtime): New function.
12393 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12395 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12397 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12399 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12401 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12402 zombies (Bug#8467).
12404 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12406 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12407 gl_state.e_property when gl_state.object is Qt.
12409 * insdel.c (make_gap_larger): Remove limitation of buffer size
12412 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12414 * xdisp.c (lookup_glyphless_char_display)
12415 (produce_glyphless_glyph): Handle cons cell entry in
12416 glyphless-char-display.
12417 (Vglyphless_char_display): Document it.
12419 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12420 glyphless-char-display.
12422 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12424 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12426 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12428 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12429 definition for no-X builds.
12431 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12433 Static checks with GCC 4.6.0 and non-default toolkits.
12435 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12437 * process.c (keyboard_bit_set): Define only if SIGIO.
12438 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12439 (send_process): Repair possible setjmp clobbering.
12441 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12443 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12445 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12447 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12448 Define only if needed.
12450 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12451 by pacifying GCC about it. Maybe it's time to retire it?
12452 * xfaces.c (USG, __TIMEVAL__): Likewise.
12454 * dispextern.h (struct redisplay_interface): Rename param
12455 to avoid shadowing.
12456 * termhooks.h (struct terminal): Likewise.
12457 * xterm.c (xembed_send_message): Likewise.
12459 * insdel.c (make_gap_smaller): Define only if
12460 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12462 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12465 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12466 so that we aren't warned about unused symbols.
12468 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12470 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12472 * xfns.c (x_real_positions): Mark locals as initialized.
12474 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12476 * xterm.c: Fix problems found by static analysis with other toolkits.
12477 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12478 (x_dispatch_event): Declare static if USE_GTK, and
12479 define if USE_GTK || USE_X_TOOLKIT.
12480 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12481 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12482 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12483 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12485 * xmenu.c (menu_help_callback): Pointer type fixes.
12486 Use const pointers when pointing at readonly data. Avoid pointer
12487 signedness clashes.
12488 (FALSE): Remove unused macro.
12489 (update_frame_menubar): Remove unused decl.
12491 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12493 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12494 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12495 (single_menu_item): Rename local to avoid shadowing.
12497 * keyboard.c (make_lispy_event): Remove unused local var.
12499 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12500 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12502 * bitmaps: Change bitmaps from unsigned char back to the X11
12503 compatible char. Avoid the old compiler warnings about
12504 out-of-range initializers by using, for example, '\xab' rather
12507 * xgselect.c (xgselect_initialize): Check vs interface
12508 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12510 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12512 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12513 to read-only memory.
12515 * fns.c (vector): Remove; this old hack is no longer needed.
12517 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12519 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12521 * xrdb.c (x_load_resources): Omit unused local.
12523 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12524 (x_window): Rename locals to avoid shadowing.
12525 (USG): Use the kludged USG macro, to pacify gcc.
12527 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12528 (x_term_init): Remove local to avoid shadowing.
12530 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12532 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12533 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12535 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12537 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12539 Fix regex.c, syntax.c and friends for buffers > 2GB.
12540 * syntax.h (struct gl_state_s): Declare character position members
12543 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12545 * textprop.c (verify_interval_modification, interval_of):
12546 Declare arguments EMACS_INT.
12548 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12551 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12553 * indent.c (Fvertical_motion): Local variable it_start is now
12556 * regex.c (re_match, re_match_2, re_match_2_internal)
12557 (bcmp_translate, regcomp, regexec, print_double_string)
12558 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12559 (re_compile_pattern, re_exec): Declare arguments and local
12560 variables `size_t' and `ssize_t' and return values `regoff_t', as
12562 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12563 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12564 <compile_stack_type>: `size' and `avail' are now `size_t'.
12566 * regex.h <regoff_t>: Use ssize_t, not int.
12567 (re_search, re_search_2, re_match, re_match_2): Arguments that
12568 specify buffer/string position and length are now ssize_t and
12569 size_t. Return type is regoff_t.
12571 2011-04-16 Ben Key <bkey76@gmail.com>
12573 * nsfont.m: Fixed bugs in ns_get_family and
12574 ns_descriptor_to_entity that were caused by using free to
12575 deallocate memory blocks that were allocated by xmalloc (via
12576 xstrdup). This caused Emacs to crash when compiled with
12577 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12578 --enable-checking=xmallocoverrun). xfree is now used to
12579 deallocate these memory blocks.
12581 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12583 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12585 emacs_write: Accept and return EMACS_INT for sizes.
12586 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12588 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12589 Accept and return EMACS_INT.
12590 (emacs_gnutls_write): Return the number of bytes written on
12592 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12593 (emacs_read, emacs_write): Remove check for negative size, as the
12594 Emacs source code has been audited now.
12595 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12596 (emacs_read, emacs_write): Use it.
12597 * process.c (send_process): Adjust to the new signatures of
12598 emacs_write and emacs_gnutls_write. Do not attempt to store
12599 a byte offset into an 'int'; it might overflow.
12600 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12602 * sound.c: Don't assume sizes fit in 'int'.
12603 (struct sound_device.period_size, alsa_period_size):
12604 Return EMACS_INT, not int.
12605 (struct sound_device.write, vox_write, alsa_write):
12606 Accept EMACS_INT, not int.
12607 (wav_play, au_play): Use EMACS_INT to store sizes and to
12608 record read return values.
12610 2011-04-15 Ben Key <bkey76@gmail.com>
12612 * keyboard.c (Qundefined): Don't declare static since it is used
12614 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12615 static since they are used in nsfont.m.
12617 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12619 * process.c (Qprocessp): Don't declare static.
12620 * lisp.h (Qprocessp): Declare again.
12622 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12624 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12626 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12628 Improve C-level modularity by making more things 'static'.
12630 Don't publish debugger-only interfaces to other modules.
12631 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12632 (verify_bytepos, count_markers): Move decls to the only modules
12634 * region-cache.h (pp_cache): Likewise.
12635 * window.h (check_all_windows): Likewise.
12636 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12638 * sysdep.c (croak): Now static, if
12639 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12640 * syssignal.h (croak): Declare only if not static.
12642 * alloc.c (refill_memory_reserve): Now static if
12643 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12644 * lisp.h (refill_memory_reserve): Declare only if not static.
12646 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12647 Define only if USE_LUCID.
12649 * xrdb.c (x_customization_string, x_rm_string): Now static.
12651 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12652 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12654 * xdisp.c (draw_row_with_mouse_face): Now static.
12655 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12657 * window.h (check_all_windows): Mark externally visible.
12659 * window.c (window_deletion_count): Now static.
12661 * undo.c: Make symbols static if they're not exported.
12662 (last_undo_buffer, last_boundary_position, pending_boundary):
12665 * textprop.c (interval_insert_behind_hooks): Now static.
12666 (interval_insert_in_front_hooks): Likewise.
12668 * term.c: Make symbols static if they're not exported.
12669 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12670 (max_frame_lines, tty_set_terminal_modes):
12671 (tty_reset_terminal_modes, tty_turn_off_highlight):
12672 (get_tty_terminal): Now static.
12673 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12674 * termhooks.h (term_mouse_moveto): Do not declare if
12675 HAVE_WINDOW_SYSTEM.
12676 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12677 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12679 * sysdep.c: Make symbols static if they're not exported.
12680 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12682 (sigprocmask_set, full_mask): Remove; unused.
12683 (wait_debugging): Mark as visible.
12684 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12685 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12687 * syntax.c (syntax_temp): Define only if !__GNUC__.
12689 * sound.c (current_sound_device, current_sound): Now static.
12691 * search.c (searchbufs, searchbuf_head): Now static.
12693 * scroll.c (scroll_cost): Remove; unused.
12694 * dispextern.h (scroll_cost): Remove decl.
12696 * region-cache.h (pp_cache): Mark as externally visible.
12698 * process.c: Make symbols static if they're not exported.
12699 (process_tick, update_tick, create_process, chan_process):
12700 (Vprocess_alist, proc_buffered_char, datagram_access):
12701 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12702 (deactivate_process): Mark defn as static, as well as decl.
12703 * lisp.h (create_process): Remove decl.
12704 * process.h (chan_process, Vprocess_alist): Remove decls.
12706 * print.c: Make symbols static if they're not exported.
12707 (print_depth, new_backquote_output, being_printed, print_buffer):
12708 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12709 (print_interval, print_number_index, initial_stderr_stream):
12711 * lisp.h (Fprinc): Remove decl.
12712 (debug_output_compilation_hack): Mark as externally visible.
12714 * sysdep.c (croak): Move decl from here to syssignal.h.
12715 * syssignal.h (croak): Put it here, so the API can be checked when
12716 'croak' is called from dissociate_if_controlling_tty.
12718 * minibuf.c: Make symbols static if they're not exported.
12719 (minibuf_save_list, choose_minibuf_frame): Now static.
12720 * lisp.h (choose_minibuf_frame): Remove decl.
12722 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12724 * lread.c: Make symbols static if they're not exported.
12725 (read_objects, initial_obarray, oblookup_last_bucket_number):
12727 (make_symbol): Remove; unused.
12728 * lisp.h (initial_obarray, make_symbol): Remove decls.
12730 * keyboard.c: Make symbols static if they're not exported.
12731 (single_kboard, recent_keys_index, total_keys, recent_keys):
12732 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12733 (this_single_command_key_start, echoing, last_auto_save):
12734 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12735 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12736 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12737 (Vlispy_mouse_stem, double_click_count):
12739 (force_auto_save_soon): Define only if SIGDANGER.
12740 (ignore_mouse_drag_p): Now static if
12741 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12742 (print_help): Remove; unused.
12743 (stop_character, last_timer_event): Mark as externally visible.
12744 * keyboard.h (ignore_mouse_drag_p): Declare only if
12745 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12746 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12747 * lisp.h (echoing): Remove decl.
12748 (force_auto_save_soon): Declare only if SIGDANGER.
12749 * xdisp.c (redisplay_window): Simplify code, to make it more
12750 obvious that ignore_mouse_drag_p is not accessed if !defined
12751 USE_GTK && !defined HAVE_NS.
12753 * intervals.c: Make symbols static if they're not exported.
12754 (merge_properties_sticky, merge_interval_right, delete_interval):
12756 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12758 * insdel.c: Make symbols static if they're not exported.
12759 However, leave prepare_to_modify_buffer alone. It's never
12760 called from outside this function, but that appears to be a bug.
12761 (combine_after_change_list, combine_after_change_buffer):
12762 (adjust_after_replace, signal_before_change): Now static.
12763 (adjust_after_replace_noundo): Remove; unused.
12764 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12765 (signal_before_change): Remove decls.
12767 * indent.c (val_compute_motion, val_vmotion): Now static.
12769 * image.c: Make symbols static if they're not exported.
12770 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12772 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12773 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12775 * fringe.c (standard_bitmaps): Now static.
12776 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12778 * frame.c: Make symbols static if they're not exported.
12779 (x_report_frame_params, make_terminal_frame): Now static.
12780 (get_frame_param): Now static, unless HAVE_NS.
12781 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12782 (x_get_resource_string): Remove; not used.
12783 * frame.h (make_terminal_frame, x_report_frame_params):
12784 (x_get_resource_string); Remove decls.
12785 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12786 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12788 * font.c, fontset.c: Make symbols static if they're not exported.
12789 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12790 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12791 * font.c (font_close_object): Now static.
12792 * font.h (font_close_object): Remove.
12793 * fontset.c (FONTSET_OBJLIST): Remove.
12794 (free_realized_fontset) #if-0 the body, which does nothing.
12795 (face_suitable_for_char_p): #if-0, as it's never called.
12796 * fontset.h (face_suitable_for_char_p): Remove decl.
12797 * xfaces.c (face_at_string_position):
12798 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12799 since 0 is always ASCII.
12801 * fns.c (weak_hash_tables): Now static.
12803 * fileio.c: Make symbols static if they're not exported.
12804 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12805 (Vwrite_region_annotation_buffers): Now static.
12807 * eval.c: Make symbols static if they're not exported.
12808 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12809 * lisp.h (backtrace_list): Remove decl.
12811 * emacs.c: Make symbols static if they're not exported.
12812 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12813 (fatal_error_code, fatal_error_signal_hook, standard_args):
12815 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12816 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12817 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12818 * lisp.h (fatal_error_signal_hook): Remove decl.
12819 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12821 * editfns.c: Move a (normally-unused) function to its only use.
12822 * editfns.c, lisp.h (get_operating_system_release): Remove.
12823 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12824 worth the hassle of breaking this out.
12826 * xterm.c: Make symbols static if they're not exported.
12827 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12828 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12829 (x_destroy_window, x_delete_display):
12831 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12832 (x_mouse_leave): Remove; unused.
12833 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12834 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12835 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12837 (x_mouse_leave): Declare only if WINDOWSNT.
12838 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12839 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12842 * ftxfont.c: Make symbols static if they're not exported.
12843 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12845 * font.h (ftxfont_driver): Likewise.
12847 * xfns.c: Make symbols static if they're not exported.
12848 (x_last_font_name, x_display_info_for_name):
12849 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12850 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12851 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12852 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12853 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12854 (last_show_tip_args): Now static.
12855 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12856 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12857 (x_screen_planes): Remove; unused.
12858 * dispextern.h (x_screen_planes): Remove decl.
12860 * dispnew.c: Make symbols static if they're not exported.
12861 * dispextern.h (redraw_garbaged_frames, scrolling):
12862 (increment_row_positions): Remove.
12863 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12864 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12866 (redraw_garbaged_frames): Remove; unused.
12868 * xfaces.c: Make symbols static if they're not exported.
12869 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12871 * xterm.h (defined_color): Remove decls.
12872 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12873 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12874 (menu_face_changed_default, defined_color, free_realized_face):
12875 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12876 (ascii_face_of_lisp_face): Remove; unused.
12878 * xdisp.c: Make symbols static if they're not exported.
12879 * dispextern.h (scratch_glyph_row, window_box_edges):
12880 (glyph_to_pixel_coords, set_cursor_from_row):
12881 (get_next_display_element, set_iterator_to_next):
12882 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12883 (show_mouse_face): Remove decls
12884 * frame.h (message_buf_print): Likewise.
12885 * lisp.h (pop_message, set_message, check_point_in_composition):
12887 * xterm.h (set_vertical_scroll_bar): Likewise.
12888 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12889 (message_buf_print, scratch_glyph_row, displayed_buffer):
12890 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12891 (get_next_display_element, show_mouse_face, window_box_edges):
12892 (frame_to_window_pixel_xy, check_point_in_composition):
12893 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12894 (glyph_to_pixel_coords): Remove; unused.
12896 * dired.c (file_name_completion): Now static.
12898 * dbusbind.c (xd_in_read_queued_messages): Now static.
12900 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12901 * data.c (circular_list_error): Remove.
12903 * commands.h (last_point_position, last_point_position_buffer):
12904 (last_point_position_window): Remove decls.
12905 * keyboard.c: Make these variables static.
12907 * coding.h (coding, code_convert_region, encode_coding_gap):
12909 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12910 (iso_code_class, detect_coding, code_convert_region): Now static.
12911 (encode_coding_gap): Remove; unused.
12913 * chartab.c (chartab_chars, chartab_bits): Now static.
12915 * charset.h (charset_iso_8859_1): Remove decl.
12916 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12919 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12920 * ccl.c (Vccl_program_table): Now static.
12921 (check_ccl_update): Remove; unused.
12923 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12924 * category.h: ... from here.
12925 * category.c (check_category_table, set_category_set): Now static.
12927 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12928 * lisp.h: Remove these decls.
12930 * buffer.c (buffer_count): Remove unused var.
12932 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12933 so that it's not optimized away.
12934 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12935 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12936 exported only to the debugger.
12938 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12939 * atimer.h (run_all_atimers): Remove; not exported.
12941 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12942 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12943 was inaccessible from Lisp.
12944 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12945 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12947 alloc.c: Import and export fewer symbols, and remove unused items.
12948 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12950 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12951 it's not optimized away by whole-program optimization.
12952 (message_enable_multibyte, free_misc): Remove.
12953 (catchlist, handlerlist, mark_backtrace):
12954 Declare only if BYTE_MARK_STACK.
12955 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12956 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12957 (message_enable_multibyte): Remove decl.
12958 (free_misc, interval_free_list, float_block, float_block_index):
12959 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12960 (cons_free_list, last_marked_index):
12962 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12963 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12964 (mark_backtrace): Define only if BYTE_MARK_STACK.
12965 * xdisp.c (message_enable_multibyte): Now static.
12967 Declare Lisp_Object Q* variables to be 'static' if not exported.
12968 This makes it easier for human readers (and static analyzers)
12969 to see whether these variables are used from other modules.
12970 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12971 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12972 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12973 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12974 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12975 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12976 * xmenu.c, xselect.c:
12977 Declare Q* vars static if they are not used in other modules.
12978 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12979 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12980 Remove decls of unexported vars.
12981 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12983 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12985 Make Emacs functions such as Fatom 'static' by default.
12986 This makes it easier for human readers (and static analyzers)
12987 to see whether these functions can be called from other modules.
12988 DEFUN now defines a static function. To make the function external
12989 so that it can be used in other C modules, use the new macro DEFUE.
12990 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12991 (Finit_image_library):
12992 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12993 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12994 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12995 Remove decls, since these functions are now static.
12996 (Funintern, Fget_internal_run_time): New decls, since these functions
12997 were already external.
12999 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13000 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13001 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13002 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13003 * keyboard.c, keymap.c, lread.c:
13004 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13005 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13006 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13007 Mark functions with DEFUE instead of DEFUN,
13008 if they are used in other modules.
13009 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13010 decls for now-static functions.
13011 * buffer.h (Fdelete_overlay): Remove decl.
13012 * callproc.c (Fgetenv_internal): Mark as internal.
13013 * composite.c (Fremove_list_of_text_properties): Remove decl.
13014 (Fcomposition_get_gstring): New forward static decl.
13015 * composite.h (Fcomposite_get_gstring): Remove decl.
13016 * dired.c (Ffile_attributes): New forward static decl.
13017 * doc.c (Fdocumntation_property): New forward static decl.
13018 * eval.c (Ffetch_bytecode): New forward static decl.
13019 (Funintern): Remove extern decl; now in .h file where it belongs.
13020 * fileio.c (Fmake_symbolic_link): New forward static decl.
13021 * image.c (Finit_image_library): New forward static decl.
13022 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13023 * intervals.h (Fprevious_property_change):
13024 (Fremove_list_of_text_properties): Remove decls.
13025 * keyboard.c (Fthis_command_keys): Remove decl.
13026 (Fcommand_execute): New forward static decl.
13027 * keymap.c (Flookup_key): New forward static decl.
13028 (Fcopy_keymap): Now static.
13029 * keymap.h (Flookup_key): Remove decl.
13030 * process.c (Fget_process): New forward static decl.
13031 (Fprocess_datagram_address): Mark as internal.
13032 * syntax.c (Fsyntax_table_p): New forward static decl.
13033 (skip_chars): Remove duplicate decl.
13034 * textprop.c (Fprevious_property_change): New forward static decl.
13035 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13037 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13038 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13040 * editfns.c (Fformat): Remove unreachable code.
13042 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13044 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13047 2011-04-13 Eli Zaretskii <eliz@gnu.org>
13049 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13050 when at ZV. (Bug#8487)
13052 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13054 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13056 * keyboard.c (parse_tool_bar_item): Likewise.
13057 * sound.c (sound_cleanup, alsa_close): Likewise.
13058 * termcap.c (tgetent): Likewise.
13059 * xfns.c (x_default_font_parameter): Likewise.
13060 * xsettings.c (read_and_apply_settings): Likewise.
13062 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13063 (overrun_check_free): Protoize.
13065 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13067 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13068 since callers should never pass a negative size.
13069 Change the signature to match that of plain 'read' and 'write'; see
13070 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13071 * lisp.h: Update prototypes of emacs_write and emacs_read.
13073 2011-04-11 Eli Zaretskii <eliz@gnu.org>
13075 * xdisp.c (redisplay_window): Don't try to determine the character
13076 position of the scroll margin if the window start point w->startp
13077 is outside the buffer's accessible region. (Bug#8468)
13079 2011-04-10 Eli Zaretskii <eliz@gnu.org>
13081 Fix write-region and its subroutines for buffers > 2GB.
13082 * fileio.c (a_write, e_write): Modify declaration of arguments and
13083 local variables to support buffers larger than 2GB.
13084 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13086 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13087 argument, local variables, and return value.
13089 * lisp.h: Update prototypes of emacs_write and emacs_read.
13091 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13093 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
13095 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13097 Fix more problems found by GCC 4.6.0's static checks.
13099 * xdisp.c (vmessage): Use a better test for character truncation.
13101 * charset.c (load_charset_map): <, not <=, for optimization,
13102 and to avoid potential problems with integer overflow.
13103 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
13104 * casetab.c (set_identity, shuffle): Likewise.
13105 * editfns.c (Fformat): Likewise.
13106 * syntax.c (skip_chars): Likewise.
13108 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13109 This also lets GCC 4.6.0 generate slightly better loop code.
13111 * callint.c (Fcall_interactively): <, not <=, for optimization.
13112 (Fcall_interactively): Count the number of arguments produced,
13113 not the number of arguments given. This is simpler and lets GCC
13114 4.6.0 generate slightly better code.
13116 * ftfont.c: Distingish more carefully between FcChar8 and char.
13117 The previous code passed unsigned char * to a functions like
13118 strlen and xstrcasecmp that expect char *, which does not
13119 conform to the C standard.
13120 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13121 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13122 char * when the C standard requires it.
13124 * keyboard.c (read_char): Remove unused var.
13126 * eval.c: Port to Windows vsnprintf (Bug#8435).
13127 Include <limits.h>.
13128 (SIZE_MAX): Define if the headers do not.
13129 (verror): Do not give up if vsnprintf returns a negative count.
13130 Instead, grow the buffer. This ports to Windows vsnprintf, which
13131 does not conform to C99. Problem reported by Eli Zaretskii.
13132 Also, simplify the allocation scheme, by avoiding the need for
13133 calling realloc, and removing the ALLOCATED variable.
13135 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13137 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13138 But keep the doprint source code for now, as we might revamp it
13139 and use it again (Bug#8435).
13140 * lisp.h (doprnt): Remove.
13141 * Makefile.in (base_obj): Remove doprnt.o.
13142 * deps.mk (doprnt.o): Remove.
13144 error: Print 32- and 64-bit integers portably (Bug#8435).
13145 Without this change, on typical 64-bit hosts error ("...%d...", N)
13146 was used to print both 32- and 64-bit integers N, which relied on
13147 undefined behavior.
13148 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
13149 * lisp.h (error, verror): Mark as printf-like functions.
13150 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13151 Report overflow in size calculations when allocating printf buffer.
13152 Do not truncate output string at its first null byte.
13153 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13154 Truncate the output at a character boundary, since vsnprintf does not
13156 * charset.c (check_iso_charset_parameter): Convert internal
13157 character to string before calling 'error', since %c now has the
13159 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13160 overflow when computing char to be passed to 'error'. Do not
13161 pass Lisp_Object to 'error'; pass the integer instead.
13162 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13163 formatted with plain %d.
13165 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13167 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13169 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13171 * xterm.c (x_catch_errors): Remove duplicate declaration.
13173 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13175 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13177 2011-04-10 Jim Meyering <meyering@redhat.com>
13179 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13180 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13181 return ssize_t not "int", and use size_t as the buffer length.
13182 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13183 * gnutls.h: Update declarations.
13184 * process.c (read_process_output): Use ssize_t, to match.
13185 (send_process): Likewise.
13187 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13189 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13191 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13193 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13194 Use unsigned char, to match FcChar8 type definition.
13196 * xterm.c (handle_one_xevent):
13197 * xmenu.c (create_and_show_popup_menu):
13198 * xselect.c (x_decline_selection_request)
13199 (x_reply_selection_request): Avoid type-punned deref of X events.
13201 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13203 Fix some uses of `int' instead of EMACS_INT.
13204 * search.c (string_match_1, fast_string_match)
13205 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13206 (scan_buffer, find_next_newline_no_quit)
13207 (find_before_next_newline, search_command, Freplace_match)
13208 (Fmatch_data): Make some `int' variables be EMACS_INT.
13210 * xdisp.c (display_count_lines): 3rd argument and return value now
13211 EMACS_INT. All callers changed.
13212 (pint2hrstr): Last argument is now EMACS_INT.
13214 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13215 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13216 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13217 (decode_coding_utf_16, decode_coding_emacs_mule)
13218 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13219 (decode_coding_ccl, decode_coding_charset)
13220 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13221 (decode_coding_iso_2022, decode_coding_emacs_mule)
13222 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13223 <char_offset, last_offset>: Declare EMACS_INT.
13224 (encode_coding_utf_8, encode_coding_utf_16)
13225 (encode_coding_emacs_mule, encode_invocation_designation)
13226 (encode_designation_at_bol, encode_coding_iso_2022)
13227 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13228 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13230 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13231 (encode_invocation_designation): Last argument P_NCHARS is now
13233 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13234 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13236 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13239 * ccl.c (Fccl_execute_on_string): Declare some variables
13242 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13244 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13246 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13248 * process.c (Fformat_network_address): Doc fix.
13250 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13252 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13254 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13256 * keyboard.c (read_char): Call Lisp function help-form-show,
13257 instead of using internal_with_output_to_temp_buffer.
13258 (Qhelp_form_show): New var.
13259 (syms_of_keyboard): Use DEFSYM macro.
13261 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13263 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13265 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13267 * process.c (Flist_processes): Remove to Lisp.
13268 (list_processes_1): Delete.
13270 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13272 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13274 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13276 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13278 Fix more problems found by GCC 4.6.0's static checks.
13280 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13282 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13284 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13286 * xdisp.c (vmessage): Mark as a printf-like function.
13288 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13290 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13292 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13293 printf-like functions.
13294 (tiff_load): Add casts to remove these marks before passing them
13295 to system-supplied API.
13297 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13299 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13300 This avoids several warnings with gcc -Wstrict-overflow.
13301 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13302 directly, rather than having caller test rule sign. This avoids
13303 some unnecessary tests.
13304 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13305 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13306 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13308 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13309 (xfont_open): Avoid unnecessary tests.
13311 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13313 * composite.h, composite.c (composition_gstring_put_cache):
13314 Use EMACS_INT, not int, for length.
13316 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13317 breaking out part of COMPOSITION_DECODE_RULE.
13318 (COMPOSITION_DECODE_RULE): Use it.
13319 * composite.c (get_composition_id): Remove unused local vars,
13320 by using the new macro.
13322 * textprop.c (set_text_properties_1): Change while to do-while,
13323 since the condition is always true at first.
13325 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13326 (interval_deletion_adjustment): Return unsigned value.
13329 * process.c (list_processes_1, create_pty, read_process_output):
13330 (exec_sentinel): Remove vars that were set but not used.
13331 (create_pty): Remove unnecessary "volatile"s.
13332 (Fnetwork_interface_info): Avoid possibility of int overflow.
13333 (read_process_output): Do adaptive read buffering even if carryover.
13334 (read_process_output): Simplify nbytes computation if buffered.
13336 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13338 * syntax.c (scan_words): Remove var that was set but not used.
13339 (update_syntax_table): Use unsigned instead of int.
13341 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13342 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13343 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13345 * print.c (print_error_message): Avoid int overflow.
13347 * font.c (font_list_entities): Redo for clarity,
13348 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13350 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13351 (font_score): Avoid potential overflow in diff calculation.
13353 * fns.c (substring_both): Remove var that is set but not used.
13354 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13356 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13358 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13359 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13360 can always succeed if overflow has undefined behavior.
13362 * search.c (boyer_moore, wordify): Remove vars set but not used.
13363 (wordify): Omit three unnecessary tests.
13365 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13366 All callers changed. This avoids the need for an unused var.
13368 * casefiddle.c (casify_region): Remove var that is set but not used.
13370 * dired.c (file_name_completion): Remove var that is set but not used.
13372 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13374 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13375 (Finsert_file_contents): Remove unnecessary code checking fd.
13377 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13378 Check for integer overflow on size calculations.
13380 * buffer.c (Fprevious_overlay_change): Remove var that is set
13383 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13384 Remove vars that are set but not used.
13385 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13386 (timer_check_2): Mark vars as initialized.
13388 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13390 * image.c (lookup_image): Remove var that is set but not used.
13391 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13393 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13394 that are set but not used.
13396 * xfns.c (make_invisible_cursor): Don't return garbage
13397 if XCreateBitmapFromData fails (Bug#8410).
13399 * xselect.c (x_get_local_selection, x_handle_property_notify):
13400 Remove vars that are set but not used.
13402 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13403 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13405 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13406 Remove var that is set but not used.
13407 (scroll_bar_windows_size): Now size_t, not int.
13408 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13409 Check for overflow.
13411 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13412 (map_tty_color) [!defined MSDOS]: Likewise.
13414 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13416 * coding.c: Remove vars that are set but not used.
13417 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13418 All callers changed.
13419 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13420 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13421 (decode_coding_charset): Remove vars that are set but not used.
13423 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13424 that is set but not used.
13426 * print.c (print_object): Remove var that is set but not used.
13428 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13429 The gnulib version avoids calling malloc in the usual case,
13430 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13431 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13432 * filelock.c (current_lock_owner): Likewise.
13433 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13434 * sysdep.c: Include allocator.h, careadlinkat.h.
13435 (emacs_no_realloc_allocator): New static constant.
13436 (emacs_readlink): New function.
13437 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13438 ../lib/careadlinkat.h.
13440 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13442 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13443 first non-nil return value).
13445 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13447 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13448 if not defined (Bug#8403).
13450 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13452 * xdisp.c (display_count_lines): Remove parameter `start',
13453 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13454 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13455 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13456 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13457 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13458 and thereabouts. All callers changed.
13459 (get_per_char_metric): Remove parameter `f', unused since
13460 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13462 2011-04-02 Jim Meyering <meyering@redhat.com>
13464 do not dereference NULL upon failed strdup
13465 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13466 (ns_get_family): Likewise.
13468 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13470 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13472 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13474 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13477 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13479 Add lexical binding.
13481 * window.c (Ftemp_output_buffer_show): New fun.
13482 (Fsave_window_excursion):
13483 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13485 * lread.c (lisp_file_lexically_bound_p): New function.
13486 (Fload): Bind Qlexical_binding.
13487 (readevalloop): Remove `evalfun' arg.
13488 Bind Qinternal_interpreter_environment.
13489 (Feval_buffer): Bind Qlexical_binding.
13490 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13492 (syms_of_lread): Declare `lexical-binding'.
13494 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13496 * keyboard.c (eval_dyn): New fun.
13497 (menu_item_eval_property): Use it.
13499 * image.c (parse_image_spec): Use Ffunctionp.
13501 * fns.c (concat, mapcar1): Accept byte-code-functions.
13503 * eval.c (Fsetq): Handle lexical vars.
13504 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13505 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13506 (FletX, Flet): Obey lexical binding.
13507 (Fcommandp): Handle closures.
13508 (Feval): New `lexical' arg.
13509 (eval_sub): New function extracted from Feval. Use it almost
13510 everywhere where Feval was used. Look up vars in lexical env.
13512 (Ffunctionp): Move from subr.el.
13513 (Ffuncall): Handle closures.
13514 (apply_lambda): Remove `eval_flags'.
13515 (funcall_lambda): Handle closures and new byte-code-functions.
13516 (Fspecial_variable_p): New function.
13517 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13518 but without exporting it to Lisp.
13520 * doc.c (Fdocumentation, store_function_docstring):
13521 * data.c (Finteractive_form): Handle closures.
13523 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13526 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13528 (exec_byte_code): New function extracted from Fbyte_code to handle new
13529 calling convention for byte-code-functions. Add new byte-codes.
13531 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13533 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13535 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13537 * xdisp.c (redisplay_internal): Fix prototype.
13539 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13541 * xdisp.c (SCROLL_LIMIT): New macro.
13542 (try_scrolling): Use it when setting scroll_limit.
13543 Limit scrolling to 100 screen lines.
13544 (redisplay_window): Even when falling back on "recentering",
13545 position point in the window according to scroll-conservatively,
13546 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13548 (try_scrolling): When point is above the window, allow searching
13549 as far as scroll_max, or one screenful, to compute vertical
13550 distance from PT to the scroll margin position. This prevents
13551 try_scrolling from unnecessarily failing when
13552 scroll-conservatively is set to a value slightly larger than the
13553 window height. Clean up the case of PT below the margin at bottom
13554 of window: scroll_max can no longer be INT_MAX. When aggressive
13555 scrolling is in use, don't let point enter the opposite scroll
13556 margin as result of the scroll.
13557 (syms_of_xdisp) <scroll-conservatively>: Document the
13558 threshold of 100 lines for never-recentering scrolling.
13560 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13562 * dispextern.h (move_it_by_lines):
13563 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13564 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13565 (message_log_check_duplicate): Remove parameters `prev_bol' and
13566 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13567 (redisplay_internal): Remove parameter `preserve_echo_area',
13568 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13570 * indent.c (Fvertical_motion):
13571 * window.c (window_scroll_pixel_based, Frecenter):
13572 Don't pass `need_y_p' to `move_it_by_lines'.
13574 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13576 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13577 steal a few bits to be more compact.
13578 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13579 Remove unneeded casts.
13581 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13583 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13585 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13586 binding" message (bug#7967).
13588 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13590 Fix more problems found by GCC 4.6.0's static checks.
13592 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13593 Remove unused local var.
13595 * editfns.c (Fmessage_box): Remove unused local var.
13597 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13598 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13599 Omit unused local vars.
13600 * window.c (shrink_windows): Omit unused local var.
13601 * menu.c (digest_single_submenu): Omit unused local var.
13602 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13603 Omit unused local var.
13605 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13606 Don't assume string length fits in int.
13607 (keyremap_step, read_key_sequence): Use size_t for sizes.
13608 (read_key_sequence): Don't check last_real_key_start redundantly.
13610 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13611 instead of alloca (Bug#8344).
13613 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13614 (Fbacktrace_frame): Don't assume nframes fits in int.
13616 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13618 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13621 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13623 * cm.c (calccost): Turn while-do into do-while, for clarity.
13625 * keyboard.c (syms_of_keyboard): Use the same style as later
13626 in this function when indexing through an array. This also
13627 works around GCC bug 48267.
13629 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13631 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13633 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13634 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13636 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13637 This avoids undefined behavior on integer overflow, and is a bit
13638 more convenient anyway since it is compared to a size_t variable.
13640 Variadic C functions now count arguments with size_t, not int.
13641 This avoids an unnecessary limitation on 64-bit machines, which
13642 caused (substring ...) to crash on large vectors (Bug#8344).
13643 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13644 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13645 All variadic functions and their callers changed accordingly.
13646 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13647 * data.c (arith_driver, float_arith_driver): Likewise.
13648 * editfns.c (general_insert_function): Likewise.
13649 * eval.c (struct backtrace.nargs, interactive_p)
13650 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13651 (funcall_lambda, mark_backtrace): Likewise.
13652 * fns.c (concat): Likewise.
13653 * frame.c (x_set_frame_parameters): Likewise.
13654 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13655 0 if not found, not -1. All callers changed.
13657 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13658 (stack_copy_size): Now size_t, not int.
13659 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13661 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13663 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13664 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13665 All callers changed.
13667 * lisp.h (multibyte_char_to_unibyte):
13668 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13669 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13670 * character.h (CHAR_TO_BYTE8):
13671 * cmds.c (internal_self_insert):
13672 * editfns.c (general_insert_function):
13673 * keymap.c (push_key_description):
13674 * search.c (Freplace_match):
13675 * xdisp.c (message_dolog, set_message_1): All callers changed.
13677 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13679 * keyboard.c (safe_run_hook_funcall): New function.
13680 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13681 don't set the hook to nil, but remove the offending function instead.
13682 (Qcommand_hook_internal): Remove, unused.
13683 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13684 Vcommand_hook_internal.
13686 * eval.c (enum run_hooks_condition): Remove.
13687 (funcall_nil, funcall_not): New functions.
13688 (run_hook_with_args): Call each function through a `funcall' argument.
13689 Remove `cond' argument, now redundant.
13690 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13691 (Frun_hook_with_args_until_failure): Adjust accordingly.
13692 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13694 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13696 * dispextern.h (string_buffer_position): Remove declaration.
13698 * print.c (strout): Remove parameter `multibyte', unused since
13699 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13701 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13702 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13703 All callers changed.
13705 * w32.c (_wsa_errlist): Use braces for struct initializers.
13707 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13708 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13709 All callers changed.
13710 (string_buffer_position): Likewise. Also, make static (it's never
13711 used outside xdisp.c).
13712 (cursor_row_p): Remove parameter `w', unused since
13713 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13714 (decode_mode_spec): Remove parameter `precision', introduced during
13715 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13716 All callers changed.
13718 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13720 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13722 2011-03-27 Anders Lindgren <andlind@gmail.com>
13724 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13725 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13726 (ns_update_auto_hide_menu_bar): New functions.
13727 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13728 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13729 ns_constrain_all_frames.
13730 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13731 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13733 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13735 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13737 2011-03-27 Glenn Morris <rgm@gnu.org>
13739 * syssignal.h: Replace RETSIGTYPE with void.
13740 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13741 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13742 Replace SIGTYPE with void everywhere.
13743 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13744 * s/template.h (SIGTYPE): Remove commented out definition.
13746 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13748 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13749 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13751 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13753 * w32.c (read_unc_volume): Use parameter `henum', instead of
13754 global variable `wget_enum_handle'.
13756 * keymap.c (describe_vector): Remove parameters `indices' and
13757 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13758 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13760 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13762 * keyboard.c (timer_check): Remove parameter `do_it_now',
13763 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13764 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13765 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13767 * keyboard.c (read_char):
13768 * w32menu.c (w32_menu_display_help):
13769 * xmenu.c (show_help_event, menu_help_callback):
13770 Adjust calls to `show_help_echo'.
13772 * gtkutil.c (xg_maybe_add_timer):
13773 * keyboard.c (readable_events):
13774 * process.c (wait_reading_process_output):
13775 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13777 * insdel.c (adjust_markers_gap_motion):
13778 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13779 (gap_left, gap_right): Don't call it.
13781 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13783 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13784 incurred during fontification.
13786 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13788 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13789 (DEFVAR_PER_BUFFER): Don't pass it.
13791 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13792 (scrolling_window): Don't pass it.
13794 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13796 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13798 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13800 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13801 of variables specific to SELinux and computation of `encoded_absname'.
13803 * image.c (XPutPixel): Remove unused variable `height'.
13805 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13807 * unexw32.c (get_section_info): Remove unused variable `section'.
13809 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13810 (system_process_attributes): Remove unused variable `sess'.
13811 (sys_read): Remove unused variable `err'.
13813 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13814 (w32_wnd_proc): Remove unused variable `isdead'.
13815 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13816 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13817 (x_create_tip_frame): Remove unused variable `tem'.
13819 * w32inevt.c (w32_console_read_socket):
13820 Remove unused variable `no_events'.
13822 * w32term.c (x_draw_composite_glyph_string_foreground):
13823 Remove unused variable `width'.
13825 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13827 * w32term.c (x_set_glyph_string_clipping):
13828 Don't pass uninitialized region to CombineRgn.
13830 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13832 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13833 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13834 (Fx_close_connection): Remove unused variable `i'.
13836 * w32font.c (w32font_draw): Return number of glyphs.
13837 (w32font_open_internal): Remove unused variable `i'.
13838 (w32font_driver): Add missing initializer.
13840 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13841 (fill_in_menu): Remove unused variable `items_added'.
13843 * w32term.c (last_mouse_press_frame): Remove static global variable.
13844 (w32_clip_to_row): Remove unused variable `f'.
13845 (x_delete_terminal): Remove unused variable `i'.
13847 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13848 (NOTHING): Remove unused static global variable.
13849 (uniscribe_check_otf): Remove unused variable `table'.
13850 (uniscribe_font_driver): Add missing initializers.
13852 2011-03-23 Julien Danjou <julien@danjou.info>
13854 * term.c (Fsuspend_tty, Fresume_tty):
13855 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13856 * window.c (temp_output_buffer_show):
13857 * insdel.c (signal_before_change):
13858 * frame.c (Fhandle_switch_frame):
13859 * fileio.c (Fdo_auto_save):
13860 * emacs.c (Fkill_emacs):
13861 * editfns.c (save_excursion_restore):
13862 * cmds.c (internal_self_insert):
13863 * callint.c (Fcall_interactively):
13864 * buffer.c (Fkill_all_local_variables):
13865 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13867 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13868 unconditionally since it does the check itself.
13870 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13872 Fix more problems found by GCC 4.5.2's static checks.
13874 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13875 the first time through the loop, since we know p0 < p1 then.
13876 This also avoids a gcc -Wstrict-overflow warning.
13878 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13879 leading to a memory leak, possible in functions like
13880 load_charset_map_from_file that can allocate an unbounded number
13881 of objects (Bug#8318).
13883 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13884 that could (at least in theory) be that large.
13886 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13887 This is less likely to overflow, and avoids undefined behavior if
13888 overflow does occur. All callers changed. Use strtoul to scan
13889 for the unsigned long integer.
13890 (pint2hrstr): Simplify and tune code slightly.
13891 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13893 * scroll.c (do_scrolling): Work around GCC bug 48228.
13894 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13896 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13897 This also avoids a warning with gcc -Wstrict-overflow.
13898 (validate_x_resource_name): Simplify count usage.
13899 This also avoids a warning with gcc -Wstrict-overflow.
13901 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13904 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13906 * process.c (Fmake_network_process): Use socklen_t, not int,
13907 where POSIX says socklen_t is required in portable programs.
13908 This fixes a porting bug on hosts like 64-bit HP-UX, where
13909 socklen_t is wider than int (Bug#8277).
13910 (Fmake_network_process, server_accept_connection):
13911 (wait_reading_process_output, read_process_output):
13914 * process.c: Rename or move locals to avoid shadowing.
13915 (list_processes_1, Fmake_network_process):
13916 (read_process_output_error_handler, exec_sentinel_error_handler):
13917 Rename or move locals.
13918 (Fmake_network_process): Define label "retry_connect" only if needed.
13919 (Fnetwork_interface_info): Fix pointer signedness.
13920 (process_send_signal): Add cast to avoid pointer signedness problem.
13921 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13922 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13924 Make tparam.h and terminfo.c consistent.
13925 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13926 Include tparam.h instead, since it declares them.
13927 * cm.h (PC): Remove extern decl; tparam.h now does this.
13928 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13929 * terminfo.c: Include tparam.h, to check interfaces.
13930 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13931 (tparam): Adjust signature to match interface in tparam.h;
13932 this removes some undefined behavior. Check that outstring and len
13933 are zero, which they always are with Emacs.
13934 * tparam.h (PC, BC, UP): New extern decls.
13936 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13937 (xftfont_open): Rename locals to avoid shadowing.
13939 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13940 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13941 (OTF_TAG_SYM): Omit macro if not needed.
13942 (ftfont_list): Remove unused local.
13943 (get_adstyle_property, ftfont_pattern_entity):
13944 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13945 Rename locals to avoid shadowing.
13947 * xfont.c (xfont_list_family): Mark var as initialized.
13949 * xml.c (make_dom): Now static.
13951 * composite.c (composition_compute_stop_pos): Rename local to
13953 (composition_reseat_it): Remove unused locals.
13954 (find_automatic_composition, composition_adjust_point): Likewise.
13955 (composition_update_it): Mark var as initialized.
13956 (find_automatic_composition): Mark vars as initialized,
13957 with a FIXME (Bug#8290).
13959 character.h: Rename locals to avoid shadowing.
13960 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13961 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13962 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13963 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13964 to avoid shadowing.
13966 * textprop.c (property_change_between_p): Remove; unused.
13968 * intervals.c (interval_start_pos): Now static.
13970 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13972 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13973 Rename locals to avoid shadowing.
13975 * sound.c (wav_play, au_play, Fplay_sound_internal):
13976 Fix pointer signedness.
13977 (alsa_choose_format): Remove unused local var.
13978 (wav_play): Initialize a variable to 0, to prevent undefined
13979 behavior (Bug#8278).
13981 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13983 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13985 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13986 clobbering (Bug#8298).
13987 * sysdep.c (sys_subshell): Likewise.
13988 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13990 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13991 This should get cleaned up, so that child_setup has the
13992 same signature on all platforms.
13994 * callproc.c (call_process_cleanup): Now static.
13995 (relocate_fd): Rename locals to avoid shadowing.
13997 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13999 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14000 not to be necessary, and produces flickering.
14002 2011-03-20 Glenn Morris <rgm@gnu.org>
14004 * config.in: Remove file.
14006 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
14008 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14009 are now in src/globals.h.
14010 (syms_of_minibuf): Remove spurious & from previous change.
14012 2011-03-20 Leo Liu <sdl.web@gmail.com>
14014 * minibuf.c (completing-read-function): New variable.
14015 (completing-read-default): Rename from completing-read.
14016 (completing-read): Call completing-read-function.
14018 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14020 * xfaces.c (Fx_load_color_file):
14021 Read color file from absolute filename (bug#8250).
14023 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14025 * makefile.w32-in: Update dependencies.
14027 2011-03-17 Eli Zaretskii <eliz@gnu.org>
14029 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14031 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14033 Fix more problems found by GCC 4.5.2's static checks.
14035 * process.c (make_serial_process_unwind, send_process_trap):
14036 (sigchld_handler): Now static.
14038 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14039 That way, the code declares only the vars that it needs.
14040 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14041 * s/cygwin.h (PTY_ITERATION): Likewise.
14042 * s/darwin.h (PTY_ITERATION): Likewise.
14043 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14045 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14046 * process.c (allocate_pty): Don't declare stb unless it's needed.
14048 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
14049 (CONSTANTLIM): Remove; unused.
14050 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14051 Define only if needed.
14053 * unexelf.c (unexec): Name an expression,
14054 to avoid gcc -Wbad-function-cast warning.
14055 Use a different way to cause a compilation error if anyone uses
14056 n rather than nn, a way that does not involve shadowing.
14057 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
14059 * deps.mk (unexalpha.o): Remove; unused.
14061 New file unexec.h, the (simple) interface for unexec (Bug#8267).
14062 * unexec.h: New file.
14063 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14064 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14065 Depend on unexec.h.
14066 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14067 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14068 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
14069 Change as necessary to match prototype in unexec.h.
14071 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14073 (back_comment, skip_chars): Mark vars as initialized.
14075 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14076 Rename locals to avoid shadowing.
14078 * lread.c (read1): Rewrite so as not to use empty "else".
14079 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
14081 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14083 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14084 warning when compiling print.c.
14086 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14087 instead of using an uninitialized var.
14088 (font_sort_entities): Mark var as initialized.
14090 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14092 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14093 pointers to constants.
14094 (font_parse_fcname): Remove unused vars.
14095 (font_delete_unmatched): Now static.
14096 (font_get_spec): Remove; unused.
14097 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14098 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14099 Rename or move locals to avoid shadowing.
14101 * fns.c (require_nesting_list, require_unwind): Now static.
14102 (Ffillarray): Rename locals to avoid shadowing.
14104 * floatfns.c (domain_error2): Define only if needed.
14105 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
14107 * alloc.c (mark_backtrace): Move decl from here ...
14108 * lisp.h: ... to here, so that it can be checked.
14110 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
14111 (Fdefvar): Rewrite so as not to use empty "else".
14112 (lisp_indirect_variable): Name an expression,
14113 to avoid gcc -Wbad-function-cast warning.
14114 (Fdefvar): Rename locals to avoid shadowing.
14116 * callint.c (quotify_arg, quotify_args): Now static.
14117 (Fcall_interactively): Rename locals to avoid shadowing.
14118 Use const pointer when appropriate.
14120 * lisp.h (get_system_name, get_operating_system_release):
14121 Move decls here, to check interfaces.
14122 * process.c (get_operating_system_release): Move decl to lisp.h.
14123 * xrdb.c (get_system_name): Likewise.
14124 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14125 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14126 some of which prompt warnings from gcc -Wbad-function-cast.
14127 (Fformat_time_string, Fencode_time, Finsert_char):
14128 (Ftranslate_region_internal, Fformat):
14129 Rename or remove local vars to avoid shadowing.
14130 (Ftranslate_region_internal): Mark var as initialized.
14132 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14135 * lisp.h (eassert): Check that the argument compiles, even if
14136 ENABLE_CHECKING is not defined.
14138 * data.c (Findirect_variable): Name an expression, to avoid
14139 gcc -Wbad-function-cast warning.
14140 (default_value, arithcompare, arith_driver, arith_error): Now static.
14141 (store_symval_forwarding): Rename local to avoid shadowing.
14142 (Fmake_variable_buffer_local, Fmake_local_variable):
14143 Mark variables as initialized.
14144 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
14146 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
14147 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14148 Rename locals to avoid shadowing.
14149 (mark_stack): Move local variables into the #ifdef region where
14151 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14152 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14154 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14155 (GC_STRING_CHARS): Remove; not used.
14156 (Fmemory_limit): Cast sbrk's returned value to char *.
14158 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14159 avoids undefined behavior in theory.
14161 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14163 Use functions, not macros, for up- and down-casing (Bug#8254).
14164 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14165 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14166 to use the following functions instead of these macros.
14167 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14168 EMACS_INT, since callers assume the returned value fits in int.
14169 (upcase1): Likewise, for UPCASE_TABLE.
14170 (uppercasep, lowercasep, upcase): New static inline functions.
14171 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14172 the race-condition problem in the old DOWNCASE.
14174 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14175 Rename locals to avoid shadowing.
14176 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14177 (regex_compile, re_search_2, re_match_2_internal):
14178 Remove unused local vars.
14179 (FREE_VAR): Rewrite so as not to use empty "else",
14180 which gcc can warn about.
14181 (regex_compile, re_match_2_internal): Mark locals as initialized.
14182 (RETALLOC_IF): Define only if needed.
14183 (WORDCHAR_P): Likewise. This one is never needed, but is used
14184 only in a comment talking about a compiler bug, so put inside
14185 the #if 0 of that comment.
14186 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14187 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14190 * search.c (boyer_moore): Rename locals to avoid shadowing.
14191 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14192 (PREV_CHAR_BOUNDARY): Likewise.
14194 * search.c (simple_search): Remove unused var.
14196 * dired.c (compile_pattern): Move decl from here ...
14197 * lisp.h: ... to here, so that it can be checked.
14198 (struct re_registers): New forward decl.
14200 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14202 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14204 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14205 Rename locals to avoid shadowing.
14206 (Fvertical_motion): Mark locals as initialized.
14208 * casefiddle.c (casify_object, casify_region): Now static.
14209 (casify_region): Mark local as initialized.
14211 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14213 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14214 New macros, so that the caller can use some names other than
14215 gcpro1, gcpro2, etc.
14216 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14218 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14219 argument, for consistency with GCPRO2_VAR, etc: it is now the
14220 prefix of the variable, not the variable itself. All uses
14222 * dired.c (directory_files_internal, file_name_completion):
14223 Rename locals to avoid shadowing.
14225 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14226 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14227 dired.c's scmp function, had undefined behavior.
14228 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14229 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14230 * buffer.h: ... to here, because these macros use current_buffer,
14231 and the new implementation with inline functions needs to have
14232 current_buffer in scope now, rather than later when the macros
14234 (downcase, upcase1): New static inline functions.
14235 (DOWNCASE, UPCASE1): Reimplement using these functions.
14236 This avoids undefined behavior in expressions like
14237 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14238 from race conditions in accessing the global variables
14239 case_temp1 and case_temp2.
14240 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14241 * lisp.h (case_temp1, case_temp2): Remove their decls.
14242 * character.h (ASCII_CHAR_P): Move from here ...
14243 * lisp.h: ... to here, so that the inline functions mentioned
14244 above can use them.
14246 * dired.c (directory_files_internal_unwind): Now static.
14248 * fileio.c (file_name_as_directory, directory_file_name):
14249 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14251 (file_name_as_directory): Use const pointers when appropriate.
14252 (Fexpand_file_name): Likewise. In particular, newdir might
14253 point at constant storage, so make it a const pointer.
14254 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14255 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14257 (Fset_file_times, Finsert_file_contents, auto_save_error):
14258 Rename locals to avoid shadowing.
14260 * minibuf.c (choose_minibuf_frame_1): Now static.
14261 (Ftry_completion, Fall_completions): Rename or remove locals
14262 to avoid shadowing.
14264 * marker.c (bytepos_to_charpos): Remove; unused.
14266 * lisp.h (verify_bytepos, count_markers): New decls,
14267 so that gcc does not warn that these functions aren't declared.
14269 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14270 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14271 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14272 (copy_text): Remove unused local var.
14274 * filelock.c (within_one_second): Now static.
14275 (lock_file_1): Rename local to avoid shadowing.
14277 * buffer.c (fix_overlays_before): Mark locals as initialized.
14278 (fix_start_end_in_overlays): Likewise. This function should be
14279 simplified by using pointers-to-pointers, but that's a different
14281 (switch_to_buffer_1): Now static.
14282 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14283 (report_overlay_modification): Rename locals to avoid shadowing.
14285 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14286 Fix pointer signedness issue.
14287 (sys_subshell): Mark local as volatile if checking for lint,
14288 to suppress a gcc -Wclobbered warning that does not seem to be right.
14289 (MAXPATHLEN): Define only if needed.
14291 * process.c (serial_open, serial_configure): Move decls from here ...
14292 * systty.h: ... to here, so that they can be checked.
14294 * fns.c (get_random, seed_random): Move extern decls from here ...
14295 * lisp.h: ... to here, so that they can be checked.
14297 * sysdep.c (reset_io): Now static.
14298 (wait_for_termination_signal): Remove; unused.
14300 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14301 (copy_keymap_item, append_key, push_text_char_description):
14303 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14304 (DENSE_TABLE_SIZE): Remove; unused.
14305 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14306 (describe_map_tree):
14307 Rename locals to avoid shadowing.
14309 * keyboard.c: Declare functions static if they are not used elsewhere.
14310 (echo_char, echo_dash, cmd_error, top_level_2):
14311 (poll_for_input, handle_async_input): Now static.
14312 (read_char, kbd_buffer_get_event, make_lispy_position):
14313 (make_lispy_event, make_lispy_movement, apply_modifiers):
14314 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14315 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14316 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14317 (read_key_sequence, read_char): Mark locals as initialized.
14318 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14320 * keyboard.h (make_ctrl_char): New decl.
14321 (mark_kboards): Move decl here ...
14322 * alloc.c (mark_kboards): ... from here.
14324 * lisp.h (force_auto_save_soon): New decl.
14326 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14327 (DEFINE_DUMMY_FUNCTION): New macro.
14328 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14330 (main): Add casts to avoid warnings
14331 if GCC considers string literals to be constants.
14333 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14335 * dbusbind.c: Pointer signedness fixes.
14336 (xd_signature, xd_append_arg, xd_initialize):
14337 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14338 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14339 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14340 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14342 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14343 if GCC considers string literals to be constants.
14344 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14346 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14348 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14349 (print_preprocess, print_object): New macro to fix last change.
14351 * print.c (print_preprocess): Don't forget font objects.
14353 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14355 * emacs.c (USAGE3): Doc fixes.
14357 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14359 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14362 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14364 * lisp.h (VWindow_system, Qfile_name_history):
14365 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14366 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14367 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14369 * w32select.c: Don't #include "keyboard.h".
14370 (run_protected): Add extern declaration for waiting_for_input.
14372 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14373 * w32console.c (detect_input_pending, read_input_pending)
14374 (encode_terminal_code):
14375 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14376 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14377 (w32_system_caret_y, Qfile_name_history):
14378 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14379 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14380 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14381 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14382 * w32proc.c (Qlocal, report_file_error):
14383 * w32term.c (Vwindow_system, updating_frame):
14384 * w32uniscribe.c (initialized, uniscribe_font_driver):
14385 Remove unneeded extern declarations.
14387 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14389 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14391 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14393 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14394 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14395 These macros can no longer be used for assignment.
14397 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14398 Assign struct members directly, instead of using BUF_BEGV etc.
14399 (record_buffer_markers, fetch_buffer_markers): New functions for
14400 recording and fetching special buffer markers.
14401 (set_buffer_internal_1, set_buffer_temp): Use them.
14403 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14405 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14407 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14408 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14410 * xdisp.c (hscroll_window_tree):
14411 (reconsider_clip_changes): Use PT instead of BUF_PT.
14413 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14415 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14416 $(EMACS_ROOT)/lib/intprops.h.
14418 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14420 Fix more problems found by GCC 4.5.2's static checks.
14422 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14423 to unsigned char * to avoid compiler diagnostic.
14424 (xg_free_frame_widgets): Make it clear that a local variable is
14425 needed only if USE_GTK_TOOLTIP.
14426 (gdk_window_get_screen): Make it clear that this macro is needed
14427 only if USE_GTK_TOOLTIP.
14428 (int_gtk_range_get_value): New function, which avoids a diagnostic
14429 from gcc -Wbad-function-cast.
14430 (xg_set_toolkit_scroll_bar_thumb): Use it.
14431 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14432 diagnostic from gcc -Wbad-function-cast.
14433 (get_utf8_string, xg_get_file_with_chooser):
14434 Rename locals to avoid shadowing.
14435 (create_dialog): Move locals to avoid shadowing.
14437 * xgselect.c (xg_select): Remove unused var.
14439 * image.c (four_corners_best): Mark locals as initialized.
14440 (gif_load): Initialize transparent_p to zero (Bug#8238).
14441 Mark another local as initialized.
14442 (my_png_error, my_error_exit): Mark with NO_RETURN.
14444 * image.c (clear_image_cache): Now static.
14445 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14446 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14447 (x_edge_detection): Remove unnecessary cast that
14448 gcc -Wbad-function-cast diagnoses.
14449 (gif_load): Fix pointer signedness.
14450 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14451 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14453 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14455 Improve quality of tests for time stamp overflow.
14456 For example, without this patch (encode-time 0 0 0 1 1
14457 1152921504606846976) returns the obviously-bogus value (-948597
14458 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14459 reports time overflow. See
14460 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14461 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14462 * editfns.c: Include limits.h and intprops.h.
14463 (TIME_T_MIN, TIME_T_MAX): New macros.
14464 (time_overflow): Move earlier, to before first use.
14465 (hi_time, lo_time): New functions, for an accurate test for
14466 out-of-range times.
14467 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14468 (Fget_internal_run_time): Don't assume time_t fits in int.
14469 (make_time): Use list2 instead of Fcons twice.
14470 (Fdecode_time): More accurate test for out-of-range times.
14471 (check_tm_member): New function.
14472 (Fencode_time): Use it, to test for out-of-range times.
14473 (lisp_time_argument): Don't rely on undefined left-shift and
14474 right-shift behavior when checking for time stamp overflow.
14476 * editfns.c (time_overflow): New function, refactoring common code.
14477 (Fformat_time_string, Fdecode_time, Fencode_time):
14478 (Fcurrent_time_string): Use it.
14480 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14481 * dired.c (make_time): Move to ...
14482 * editfns.c (make_time): ... here.
14483 * systime.h: Note the move.
14485 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14487 * fringe.c (update_window_fringes): Remove unused variables.
14489 * unexmacosx.c (copy_data_segment): Also copy __got section.
14492 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14494 * termcap.c [MSDOS]: Include "msdos.h".
14495 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14496 Constify `char *' arguments and their references according to
14497 prototypes in tparam.h.
14499 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14501 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14502 Adapt all references accordingly.
14504 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14506 2011-03-11 Tom Tromey <tromey@redhat.com>
14508 * buffer.c (syms_of_buffer): Remove obsolete comment.
14510 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14512 * termhooks.h (encode_terminal_code): Declare prototype.
14514 * msdos.c (encode_terminal_code): Don't declare prototype.
14516 * term.c (encode_terminal_code): Now external again, used by
14517 w32console.c and msdos.c.
14519 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14520 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14522 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14524 Fix some minor problems found by GCC 4.5.2's static checks.
14526 * fringe.c (update_window_fringes): Mark locals as initialized
14528 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14530 * alloc.c (mark_fringe_data): Move decl from here ...
14531 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14532 to check its interface.
14533 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14535 * fontset.c (free_realized_fontset): Now static.
14536 (Fset_fontset_font): Rename local to avoid shadowing.
14537 (fontset_font): Mark local as initialized.
14538 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14540 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14542 * xselect.c (x_disown_buffer_selections): Remove; not used.
14543 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14544 (x_own_selection, Fx_disown_selection_internal): Rename locals
14545 to avoid shadowing.
14546 (x_handle_dnd_message): Remove local to avoid shadowing.
14548 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14549 so that the caller can use some name other than gcpro1.
14550 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14551 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14552 (Fx_backspace_delete_keys_p):
14553 Use them to avoid shadowing, and rename vars to avoid shadowing.
14554 (x_decode_color, x_set_name, x_window): Now static.
14555 (Fx_create_frame): Add braces to silence GCC warning.
14556 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14557 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14558 Remove unused locals.
14559 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14560 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14561 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14564 * xterm.h (x_mouse_leave): New decl.
14566 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14567 Remove unused functions.
14568 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14569 (x_calc_absolute_position): Now static.
14570 (XTread_socket): Don't define label "out" unless it's used.
14571 Don't declare local "event" unless it's used.
14572 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14573 unless they are used.
14574 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14575 (x_fatal_error_signal): Remove; not used.
14576 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14577 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14578 (x_error_catcher, x_connection_closed, x_error_handler):
14579 (x_error_quitter, xembed_send_message, x_iconify_frame):
14580 (my_log_handler): Rename locals to avoid shadowing.
14581 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14582 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14584 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14585 Rename or move locals to avoid shadowing.
14586 (tty_defined_color, merge_face_heights): Now static.
14587 (free_realized_faces_for_fontset): Remove; not used.
14588 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14589 does not deduce is never used uninitialized.
14590 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14591 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14593 * terminal.c (store_terminal_param): Now static.
14595 * xmenu.c (menu_highlight_callback): Now static.
14596 (set_frame_menubar): Remove unused local.
14597 (xmenu_show): Rename parameter to avoid shadowing.
14598 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14599 since they might point to immutable storage.
14600 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14601 since it's unused otherwise.
14603 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14604 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14605 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14606 avoids a gcc -Wuninitialized diagnostic.
14607 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14608 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14609 does not deduce are never used uninitialized.
14611 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14613 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14614 * window.c (window_loop, size_window):
14615 (run_window_configuration_change_hook, enlarge_window): Likewise.
14617 * window.c (display_buffer): Now static.
14618 (size_window): Mark variables that gcc -Wuninitialized
14619 does not deduce are never used uninitialized.
14620 * window.h (check_all_windows): New decl, to forestall
14621 gcc -Wmissing-prototypes diagnostic.
14622 * dispextern.h (bidi_dump_cached_states): Likewise.
14624 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14626 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14627 Include <limits.h>.
14628 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14629 and to avoid gcc -Wuninitialized warning.
14630 (load_charset_map): Mark variables that gcc -Wuninitialized
14631 does not deduce are never used uninitialized.
14632 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14634 * coding.c (coding_set_source, coding_set_destination):
14635 Use "else { /* comment */ }" rather than "else /* comment */;"
14636 for clarity, and to avoid gcc -Wempty-body warning.
14637 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14638 a block, when the outer 'i' will do.
14639 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14640 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14641 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14642 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14643 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14644 Rename locals to avoid shadowing.
14645 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14646 * coding.c (emacs_mule_char, encode_invocation_designation):
14647 Now static, since they're not used elsewhere.
14648 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14649 (decode_coding_object, encode_coding_object, detect_coding_system):
14650 (decode_coding_emacs_mule): Mark variables that gcc
14651 -Wuninitialized does not deduce are never used uninitialized.
14652 (detect_coding_iso_2022): Initialize a local variable that might
14653 be used uninitialized. Leave a FIXME because it's not clear that
14654 this initialization is needed. (Bug#8211)
14655 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14656 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14657 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14658 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14659 Remove unused macros.
14661 * category.c (hash_get_category_set): Remove unused local var.
14662 (copy_category_table): Now static, since it's not used elsewhere.
14663 * character.c (string_count_byte8): Likewise.
14665 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14666 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14668 * chartab.c (copy_sub_char_table): Now static, since it's not used
14670 (sub_char_table_ref_and_range, char_table_ref_and_range):
14671 Rename locals to avoid shadowing.
14672 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14674 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14675 (BIDI_BOB): Remove unused macro.
14677 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14678 deduce are never used uninitialized.
14679 * term.c (encode_terminal_code): Likewise.
14681 * term.c (encode_terminal_code): Now static. Remove unused local.
14683 * tparam.h: New file.
14684 * term.c, tparam.h: Include it.
14685 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14686 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14687 Move these decls to tparam.h, and make them agree with what
14688 is actually in tparam.c. The previous trick of using incompatible
14689 decls in different modules does not conform to the C standard.
14690 All callers of tparam changed to use tparam's actual API.
14691 * tparam.c (tparam1, tparam, tgoto):
14692 Use const pointers where appropriate.
14694 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14695 * cm.h (struct cm): Likewise.
14696 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14697 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14698 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14699 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14700 (turn_on_face, init_tty): Likewise.
14701 * termchar.h (struct tty_display_info): Likewise.
14703 * term.c (term_mouse_position): Rename local to avoid shadowing.
14705 * alloc.c (mark_ttys): Move decl from here ...
14706 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14708 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14710 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14712 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14714 * search.c (compile_pattern_1): Remove argument regp, unused since
14715 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14716 (compile_pattern): Don't pass it.
14718 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14720 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14721 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14723 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14725 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14727 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14728 gdk_window_get_screen, gdk_window_get_geometry,
14729 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14730 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14731 (xg_get_pixbuf_from_pixmap): New function.
14732 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14733 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14734 Call xg_get_pixbuf_from_pixmap instead of
14735 gdk_pixbuf_get_from_drawable.
14736 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14737 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14738 (xg_check_special_colors): Use GtkStyleContext and its functions
14740 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14741 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14742 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14743 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14744 Call gtk_widget_get_preferred_size.
14745 (xg_frame_resized): gdk_window_get_geometry only takes 5
14747 (xg_win_to_widget, xg_event_is_for_menubar):
14748 Call gdk_x11_window_lookup_for_display.
14749 (xg_set_widget_bg): New function.
14750 (delete_cb): New function.
14751 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14752 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14753 (xg_set_background_color): Call xg_set_widget_bg.
14754 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14755 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14756 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14757 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14759 (update_frame_tool_bar): Call gtk_widget_hide.
14760 (xg_initialize): Use GDK_KEY_g.
14762 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14764 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14766 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14767 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14768 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14770 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14772 * w32xfns.c (select_palette): Check success of RealizePalette against
14773 GDI_ERROR, not zero.
14775 See ChangeLog.11 for earlier changes.
14777 ;; Local Variables:
14781 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14783 This file is part of GNU Emacs.
14785 GNU Emacs is free software: you can redistribute it and/or modify
14786 it under the terms of the GNU General Public License as published by
14787 the Free Software Foundation, either version 3 of the License, or
14788 (at your option) any later version.
14790 GNU Emacs is distributed in the hope that it will be useful,
14791 but WITHOUT ANY WARRANTY; without even the implied warranty of
14792 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14793 GNU General Public License for more details.
14795 You should have received a copy of the GNU General Public License
14796 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.