* indent.c (Fvertical_motion): Fix == vs = typo.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2
3 * indent.c (Fvertical_motion): Fix == vs = typo.
4
5 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6
7 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
8 value is now t. Doc fix.
9
10 * indent.c (Fvertical_motion): Compute and apply the overshoot
11 logic when moving up, not only when moving down. Fix the
12 confusing name and values of the it_overshoot_expected variable;
13 logic changes accordingly. (Bug#9254) (Bug#9549)
14
15 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
16 CHARPOS is covered by a display string which includes newlines.
17 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
18 is covered by a display string with embedded newlines.
19
20 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
21
22 * dbusbind.c (Fdbus_register_signal): Add match rule to
23 Vdbus_registered_objects_table. (Bug#9581)
24 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
25 docstring.
26
27 2011-09-24 Jim Meyering <meyering@redhat.com>
28
29 do not ignore write error for any output size
30 The previous change was incomplete.
31 While it makes emacs --batch detect the vast majority of stdout
32 write failures, errors were still ignored whenever the output size is
33 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
34 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
35 && echo FAIL: ignored write error
36 FAIL: ignored write error
37 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
38 && echo FAIL: ignored write error
39 FAIL: ignored write error
40 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
41
42 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
43
44 * emacs.c (Fkill_emacs): In noninteractive mode exit
45 non-successfully if a write error occurred on stdout. (Bug#9574)
46
47 2011-09-21 Eli Zaretskii <eliz@gnu.org>
48
49 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
50 the xassert test.
51
52 * dispextern.h (struct it): Update the comment documenting what
53 can it->OBJECT be.
54
55 2011-09-20 Eli Zaretskii <eliz@gnu.org>
56
57 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
58 a display string, extend search for cursor position to end of row.
59 (find_row_edges): If the row ends in a newline from a display
60 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
61 Handle the case of a display string with multiple newlines.
62 (Fcurrent_bidi_paragraph_direction): Fix search for previous
63 non-empty line. Fixes confusing cursor motion with arrow keys at
64 the beginning of a line that starts with whitespace.
65
66 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
67
68 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
69 (bug#9493).
70
71 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
72
73 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
74 boolean (Bug#9154).
75
76 2011-09-18 Eli Zaretskii <eliz@gnu.org>
77
78 * xdisp.c (display_line): Record maximum and minimum buffer
79 positions even if no glyphs were produced (e.g., by a zero-width
80 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
81 buffer positions that will be removed from the glyph row because
82 they don't fit.
83 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
84 column is beyond frame width: don't subtract 1 "pixel" when
85 computing width of the stretch.
86 (reseat_at_next_visible_line_start): Undo the change made on
87 2011-09-17 that saved paragraph information and restored it after
88 the call to `reseat'. (Bug#9545)
89
90 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
91
92 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
93 and turn window cursor on if cleared (Bug#9415).
94
95 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
96
97 * search.c (boyer_moore): Take unibyte characters from pattern
98 literally. (Bug#9458)
99
100 2011-09-18 Eli Zaretskii <eliz@gnu.org>
101
102 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
103
104 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
105
106 Fix minor problem found by static checking.
107 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
108 initialized, to pacify gcc -Wuninitialized.
109
110 * fileio.c: Report proper errno when syscall falls.
111 (Finsert_file_contents): Save and restore errno,
112 so that report_file_error outputs the correct diagnostic.
113 (Fwrite_region) [CLASH_DETECTION]: Likewise.
114
115 2011-09-18 Eli Zaretskii <eliz@gnu.org>
116
117 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
118
119 2011-09-17 Eli Zaretskii <eliz@gnu.org>
120
121 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
122 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
123
124 2011-09-17 Eli Zaretskii <eliz@gnu.org>
125
126 * xdisp.c (reseat_at_next_visible_line_start): Keep information
127 about the current paragraph and restore it after the call to
128 reseat.
129
130 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
131 (bidi_find_paragraph_start): Search back for paragraph beginning
132 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
133 (bidi_move_to_visually_next): Only trigger paragraph-related
134 computations when the last character is a newline or at EOB, not
135 just any NEUTRAL_B. (Bug#9470)
136
137 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
138 truncated lines if point is covered by a display string. (Bug#9524)
139
140 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
141
142 * xselect.c: Relax test for outgoing X longs (Bug#9498).
143 (cons_to_x_long): New function.
144 (lisp_data_to_selection_data): Use it. Correct the test for
145 short-versus-long data; it was negated. Break out of vector
146 loop, for efficiency, when a long datum is discovered.
147
148 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
149
150 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
151
152 2011-09-16 Eli Zaretskii <eliz@gnu.org>
153
154 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
155 GCC PR/17406) by declaring this function with external scope.
156
157 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
158
159 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
160 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
161
162 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
163
164 * editfns.c (Fformat): Correctly handle text properties on "%%".
165
166 2011-09-15 Eli Zaretskii <eliz@gnu.org>
167
168 * xterm.c (x_draw_composite_glyph_string_foreground):
169 * w32term.c (x_draw_composite_glyph_string_foreground):
170 * term.c (encode_terminal_code):
171 * composite.c (composition_update_it, get_composition_id):
172 * xdisp.c (get_next_display_element)
173 (fill_composite_glyph_string): Add comments about special meaning
174 of TAB characters in a composition.
175
176 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
177
178 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
179 This occurs when processing a multibyte format.
180 Problem reported by Wolfgang Jenker.
181
182 2011-09-15 Johan Bockgård <bojohan@gnu.org>
183
184 * xdisp.c (try_cursor_movement): Only check for exact match if
185 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
186
187 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
188
189 Remove unused external symbols.
190 * dispextern.h (calc_pixel_width_or_height): Remove decl.
191 * xdisp.c (calc_pixel_width_or_height): Now static.
192 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
193 * indent.c (check_display_width):
194 * w32term.c: Fix comment to match code.
195 * xterm.c, xterm.h (x_catching_errors): Remove.
196
197 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
198
199 * xselect.c: Use signed conversions more consistently (Bug#9498).
200 (selection_data_to_lisp_data): Assume incoming selection data are
201 signed integers, not unsigned. This is to be consistent with
202 outgoing selection data, which was modified to use signed integers
203 in as part of the fix to Bug#9196 in response to Jan D.'s comment
204 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
205 expects long, not unsigned long.
206
207 2011-09-14 Eli Zaretskii <eliz@gnu.org>
208
209 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
210 computation of loop end. Reported by Johan Bockgård
211 <bojohan@gnu.org>.
212
213 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
214
215 * frame.c (Fother_visible_frames_p): Function deleted.
216
217 2011-09-12 Eli Zaretskii <eliz@gnu.org>
218
219 * indent.c (compute_motion): Process display vector front to back
220 rather than the other way around. (Bug#2496)
221
222 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
223
224 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
225
226 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
227
228 * minibuf.c (Fread_from_minibuffer): Doc fix.
229
230 2011-09-11 Eli Zaretskii <eliz@gnu.org>
231
232 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
233 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
234
235 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
236
237 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
238 value for non-existent files.
239
240 2011-09-11 Eli Zaretskii <eliz@gnu.org>
241
242 * fileio.c (Finsert_file_contents): If the file cannot be opened,
243 set its "size" to -1. This will set the modtime_size field of
244 the corresponding buffer to -1, which is what
245 verify-visited-file-modtime expects for files that do not exist.
246 (Bug#9139)
247
248 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
249
250 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
251 here ...
252 * lisp.h: ... from here. push_key_description is no longer
253 defined in keyboard.c, so its declaration should not be in
254 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
255 logically belongs with push_key_description.
256
257 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
258
259 * buffer.h: Include <sys/types.h> instead of <time.h>.
260 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
261 Problem reported by Herbert J. Skuhra.
262
263 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
264
265 * xml.c (parse_region): Make the parsing work for
266 non-comment-starting XML files again (bug#9144).
267
268 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
269
270 * image.c (gif_load): Fix calculation of bottom and right corner.
271 (Bug#9468)
272
273 2011-09-10 Eli Zaretskii <eliz@gnu.org>
274
275 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
276 redisplay in small windows.
277
278 2011-09-09 Eli Zaretskii <eliz@gnu.org>
279
280 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
281
282 2011-09-08 Martin Rudalics <rudalics@gmx.at>
283
284 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
285 Operate on live windows only.
286
287 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
288
289 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
290
291 2011-09-07 Eli Zaretskii <eliz@gnu.org>
292
293 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
294 only under bidi iteration.
295
296 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
297
298 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
299
300 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
301
302 isnan: Fix porting problem to Solaris 10 with bundled gcc.
303 Without this fix, the command to link temacs failed due to an
304 undefined symbol __builtin_isnan. This is because
305 /usr/include/iso/math_c99.h #defines isnan(x) to
306 __builtin_isnan(x), but the bundled gcc, which identifies itself
307 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
308 a __builtin_isnan.
309 * floatfns.c (isnan): #undef, and then #define to a clone of
310 what's in data.c.
311 (Fisnan): Always define, since it's always available now.
312 (syms_of_floatfns): Always define isnan at the Lisp level.
313
314 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
315
316 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
317
318 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
319
320 * fileio.c: Fix bugs with large file offsets (Bug#9428).
321 The previous code assumed that file offsets (off_t values) fit in
322 EMACS_INT variables, which is not true on typical 32-bit hosts.
323 The code messed up by falsely reporting buffer overflow in cases
324 such as (insert-file-contents "big" nil 1 2) into an empty buffer
325 when "big" contains more than 2**29 bytes, even though this
326 inserts just one byte and does not overflow the buffer.
327 (Finsert_file_contents): Store file offsets as off_t
328 values, not as EMACS_INT values. Check for overflow when
329 converting between EMACS_INT and off_t. When checking for
330 buffer overflow or for overlap, take the offsets into account.
331 Don't use EMACS_INT for small values where int suffices.
332 When checking for overlap, fix a typo: ZV was used where
333 ZV_BYTE was intended.
334 (Fwrite_region): Don't assume off_t fits into 'long'.
335 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
336
337 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
338
339 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
340
341 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
342
343 sprintf-related integer and memory overflow issues (Bug#9412).
344
345 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
346 (esprintf, exprintf, evxprintf): New functions.
347 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
348 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
349 (modify_event_symbol): Do not assume that the length of
350 name_alist_or_stem is safe to alloca and fits in int.
351 (Fexecute_extended_command): Likewise for function name and binding.
352 (Frecursion_depth): Wrap around reliably on integer overflow.
353 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
354 since some callers pass EMACS_INT values.
355 (Fsingle_key_description): Don't crash if symbol name contains more
356 than MAX_ALLOCA bytes.
357 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
358 (get_minibuffer): Arg is now EMACS_INT, not int.
359 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
360 (esprintf, exprintf, evxprintf): New decls.
361 * window.h (command_loop_level, minibuf_level): Reflect API changes.
362
363 * dbusbind.c (signature_cat): New function.
364 (xd_signature, Fdbus_register_signal):
365 Do not overrun buffer; instead, report string overflow.
366
367 * dispnew.c (add_window_display_history): Don't overrun buffer.
368 Truncate instead; this is OK since it's just a log.
369
370 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
371 even if the time zone offset is outlandishly large.
372 Don't mishandle offset == INT_MIN.
373
374 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
375 when creating daemon; the previous buffer-overflow check was incorrect.
376
377 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
378 which has the guts of the old verror function.
379
380 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
381 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
382
383 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
384 (font_unparse_xlfd): Don't blindly alloca long strings.
385 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
386 fits in int, when using sprintf. Use single snprintf to count
387 length of string rather than counting it via multiple sprintfs;
388 that's simpler and more reliable.
389 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
390 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
391 sprintf, in case result does not fit in int.
392
393 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
394 (fontset_from_font): Print it.
395
396 * frame.c (tty_frame_count): Now printmax_t, not int.
397 (make_terminal_frame, set_term_frame_name): Print it.
398 (x_report_frame_params): In X, window IDs are unsigned long,
399 not signed long, so print them as unsigned.
400 (validate_x_resource_name): Check for implausibly long names,
401 and don't assume name length fits in 'int'.
402 (x_get_resource_string): Don't blindly alloca invocation name;
403 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
404 not fit in int.
405
406 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
407 (xg_check_special_colors, xg_set_geometry):
408 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
409
410 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
411 Use esprintf, not sprintf, in case result does not fit in int.
412
413 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
414 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
415 it as a large positive number.
416 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
417 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
418
419 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
420 in case result does not fit in int.
421
422 * print.c (float_to_string): Detect width overflow more reliably.
423 (print_object): Make sprintf buffer a bit bigger, to avoid potential
424 buffer overrun. Don't assume list length fits in 'int'. Treat
425 print length of 0 as 0, not as infinity; to be consistent with other
426 uses of print length in this function. Don't overflow print length
427 index. Don't assume hash table size fits in 'long', or that
428 vectorlike size fits in 'unsigned long'.
429
430 * process.c (make_process): Use printmax_t, not int, to format
431 process-name gensyms.
432
433 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
434
435 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
436 to avoid potential buffer overrun.
437
438 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
439 if X resource line is longer than 512 bytes.
440
441 * xfns.c (x_window): Make sprintf buffer a bit bigger
442 to avoid potential buffer overrun.
443
444 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
445
446 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
447
448 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
449
450 Integer overflow fixes for scrolling, etc.
451 Without these, Emacs silently mishandles large integers sometimes.
452 For example, "C-u 4294967297 M-x recenter" was treated as if
453 it were "C-u 1 M-x recenter" on a typical 64-bit host.
454
455 * xdisp.c (try_window_id): Check Emacs fixnum range before
456 converting to 'int'.
457
458 * window.c (window_scroll_line_based, Frecenter):
459 Check that an Emacs fixnum is in range before assigning it to 'int'.
460 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
461 values converted from Emacs fixnums.
462 (Frecenter): Don't wrap around a line count if it is out of 'int'
463 range; instead, treat it as an extreme value.
464 (Fset_window_configuration, compare_window_configurations):
465 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
466
467 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
468 that can exceed INT_MAX. Check that EMACS_INT value is in range
469 before assigning it to the (possibly-narrower) index.
470 (match_limit): Don't assume that a fixnum can fit in 'int'.
471
472 * print.c (print_object): Use ptrdiff_t, not int, for index that can
473 exceed INT_MAX.
474
475 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
476 (Fvertical_motion): Don't wrap around LINES values that don't fit
477 in 'int'. Instead, treat them as extreme values. This is good
478 enough for windows, which can't have more than INT_MAX lines anyway.
479
480 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
481
482 * Require libxml/parser.h to avoid compilation warning.
483
484 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
485
486 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
487 since this reportedly can destroy thread storage.
488
489 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
490
491 * syntax.c (find_defun_start): Update all cache variables if
492 exiting early (Bug#9401).
493
494 2011-08-30 Eli Zaretskii <eliz@gnu.org>
495
496 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
497
498 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
499 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
500 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
501
502 * term.c (tty_append_glyph): New function.
503 (produce_stretch_glyph): Static function and its prototype deleted.
504
505 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
506 prototypes.
507
508 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
509
510 * image.c (parse_image_spec): Check for nonnegative, not for positive,
511 when checking :margin (Bug#9390).
512 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
513 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
514 so that the name doesn't mislead. All uses changed.
515
516 2011-08-28 Johan Bockgård <bojohan@gnu.org>
517
518 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
519 set_tty_hooks.
520
521 2011-08-27 Eli Zaretskii <eliz@gnu.org>
522
523 * xdisp.c (move_it_to): Don't bail out early when reaching
524 position beyond to_charpos, if we are scanning backwards.
525 (move_it_vertically_backward): When DY == 0, make sure we get to
526 the first character in the line after the newline.
527
528 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
529
530 * ccl.c: Improve and simplify overflow checking (Bug#9196).
531 (ccl_driver): Do not generate an out-of-range pointer.
532 (Fccl_execute_on_string): Remove unnecessary check for
533 integer overflow, noted by Stefan Monnier in
534 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
535 Remove a FIXME that didn't need fixing.
536 Simplify the newly-introduced buffer reallocation code.
537
538 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
539
540 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
541
542 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
543
544 Integer and memory overflow issues (Bug#9196).
545
546 * doc.c (get_doc_string): Rework so that
547 get_doc_string_buffer_size is the actual buffer size, rather than
548 being 1 less than the actual buffer size; this makes xpalloc more
549 convenient.
550
551 * image.c (x_allocate_bitmap_record, cache_image):
552 * xselect.c (Fx_register_dnd_atom):
553 Simplify previous changes by using xpalloc.
554
555 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
556 since either will do and ptrdiff_t is convenient with xpalloc.
557
558 * charset.c (charset_table_size)
559 (struct charset_sort_data.priority): Now ptrdiff_t.
560 (charset_compare): Don't overflow if priorities differ greatly.
561 (Fsort_charsets): Don't assume list length fits in int.
562 Check for size-calculation overflow when allocating sort data.
563 (syms_of_charset): Allocate an initial charset table that is
564 just under 64 KiB, to avoid problems with glibc malloc and mmap.
565
566 * cmds.c (internal_self_insert): Check for size-calculation overflow.
567
568 * composite.h (struct composition.glyph_len): Now int, not unsigned.
569 The actual value is always <= INT_MAX, and leaving it unsigned made
570 overflow checking harder.
571
572 * dispextern.h (struct glyph_matrix.rows_allocated)
573 (struct face_cache.size): Now ptrdiff_t, for convenience in use
574 with xpalloc. The values are still always <= INT_MAX.
575
576 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
577
578 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
579 (SAFE_NALLOCA): New macro.
580
581 * region-cache.c (struct boundary.pos, find_cache_boundary)
582 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
583 (set_cache_region, invalidate_region_cache)
584 (revalidate_region_cache, know_region_cache, region_cache_forward)
585 (region_cache_backward, pp_cache):
586 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
587 so that ptrdiff_t * can be passed to xpalloc.
588 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
589 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
590 (pp_cache): Don't assume cache_len fits in int.
591 * region-cache.h: Adjust extern decls to match.
592
593 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
594 EMACS_INT, since either will do, for xpalloc.
595
596 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
597 (xnmalloc, xnrealloc, xpalloc): New functions.
598
599 * bidi.c (bidi_shelve_header_size): New constant.
600 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
601 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
602
603 * bidi.c (bidi_cache_shrink):
604 * buffer.c (overlays_at, overlays_in, record_overlay_string)
605 (overlay_strings):
606 Don't update size of array until after memory allocation succeeds,
607 because xmalloc/xrealloc may not return.
608 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
609 now that we have proper integer overflow checking.
610 (record_overlay_string, overlay_strings): Catch overflows when
611 calculating size of overlay_str_buf.
612
613 * callproc.c (Fcall_process): Check for size overflow when
614 calculating size of args2.
615 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
616 Normally we prefer signed values, but sticking with ptrdiff_t would
617 require adding more-complicated checks.
618
619 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
620 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
621 Redo buffer-overflow calculations to avoid integer overflow.
622 Add a FIXME comment where memory seems to be over-allocated.
623
624 * character.c (Fstring): Check for size-calculation overflow.
625
626 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
627 unnecessary integer overflow. Check for size overflow.
628 (encode_coding_object): Don't update size until xmalloc succeeds.
629
630 * composite.c (get_composition_id): Check for overflow in glyph
631 length calculations.
632
633 Integer and memory overflow fixes for display code.
634 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
635 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
636 (scrolling_window): Check for overflow in size calculations.
637 (line_draw_cost, realloc_glyph_pool, add_row_entry):
638 Don't assume glyph table len fits in int.
639 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
640 (row_table_size): Now ptrdiff_t, not int.
641 (scrolling_window): Avoid overflow in size calculations.
642 Don't update size until allocation succeeds.
643 * fns.c (concat): Check for overflow in size calculations.
644 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
645 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
646 (NEXT_ALMOST_PRIME_LIMIT): New constant.
647
648 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
649 (get_doc_string): Check for size calculation overflow.
650 Don't update size until allocation succeeds.
651 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
652 EMACS_INT, where ptrdiff_t will do.
653 (Fsubstitute_command_keys): Check for string overflow.
654
655 * editfns.c (set_time_zone_rule): Don't assume environment length
656 fits in int.
657 (message_length): Now ptrdiff_t, not int.
658 (Fmessage_box): Don't update size until allocation succeeds.
659 Don't assume message length fits in int.
660 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
661
662 * emacs.c (main): Do not reallocate argv, since there is a null at
663 the end that can be overwritten, and this way there's no need to
664 worry about size-calculation overflow.
665 (sort_args): Check for size-calculation overflow.
666
667 * eval.c (init_eval_once, grow_specpdl): Don't update size until
668 alloc succeeds.
669 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
670
671 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
672 (x_set_scroll_bar_width, x_figure_window_size):
673 Check for integer overflow.
674 (x_set_alpha): Do not assume XINT fits in int.
675
676 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
677 This is for the members text_lines, text_cols, total_lines, total_cols,
678 where the system imposes an 'int' limit.
679
680 * fringe.c (Fdefine_fringe_bitmap):
681 Don't update size until alloc works.
682
683 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
684 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
685
686 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
687 Check for size-calculation overflow.
688 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
689 do, as we prefer signed integers.
690 (id_to_widget.max_size, id_to_widget.used)
691 (xg_store_widget_in_map, xg_remove_widget_from_map)
692 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
693 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
694 Use and return ptrdiff_t, not int.
695 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
696 * gtkutil.h: Change prototypes to match the above.
697
698 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
699 are duplicate now that they've been promoted to lisp.h.
700 (x_allocate_bitmap_record, x_alloc_image_color)
701 (make_image_cache, cache_image, xpm_load):
702 Don't update size until alloc is done.
703 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
704 (x_detect_edges):
705 Check for size calculation overflow.
706 (ct_colors_allocated_max): New constant.
707 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
708 overflow.
709
710 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
711 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
712 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
713 Use ptrdiff_t, not int, to count maps.
714 (read_char_minibuf_menu_prompt): Check for overflow in size
715 calculations. Don't update size until allocation succeeds. Redo
716 calculations to avoid overflow.
717 * keyboard.h: Change prototypes to match the above.
718
719 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
720 to count maps.
721 (current_minor_maps): Check for size calculation overflow.
722 * keymap.h: Change prototypes to match the above.
723
724 * lread.c (read1, init_obarray): Don't update size until alloc done.
725
726 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
727 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
728
729 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
730 Now ptrdiff_t, not int.
731 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
732 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
733
734 * process.c (Fnetwork_interface_list): Check for overflow
735 in size calculation.
736
737 * region-cache.c (move_cache_gap): Check for size calculation overflow.
738
739 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
740 overflow. Don't bother calling xmalloc when xrealloc will do.
741
742 * search.c (Freplace_match): Check for size calculation overflow.
743 (Fset_match_data): Don't assume list lengths fit in 'int'.
744
745 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
746 for command line length. Do not attempt to address one before the
747 beginning of an array, as that's not portable.
748
749 * term.c (max_frame_lines): Remove; unused.
750 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
751 not int.
752 (encode_terminal_code, calculate_costs): Check for size
753 calculation overflow.
754 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
755 table lengths and related sizes. Don't update size until alloc
756 done. Redo calculations to avoid overflow.
757 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
758
759 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
760 subtracting pointers.
761 (gobble_line): Check for overflow more carefully. Don't update size
762 until alloc done.
763
764 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
765 Don't update size until alloc done.
766 Redo size calculations to avoid overflow.
767 Check for size calculation overflow.
768 (main) [DEBUG]: Fix typo in invoking tparam1.
769
770 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
771 Use ptrdiff_t, not int, for sizes.
772 (store_mode_line_noprop_char): Don't update size until alloc done.
773
774 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
775 Use ptrdiff_t, not int, for sizes.
776 (Finternal_make_lisp_face, cache_face):
777 Check for size calculation overflow.
778 (cache_face): Treat size calculation overflows as if they were
779 memory exhaustion (the usual treatment), rather than aborting.
780
781 * xfns.c (x_encode_text, x_set_name_internal)
782 (Fx_change_window_property): Use ptrdiff_t, not int, to count
783 sizes, since they can exceed INT_MAX in size. Check for size
784 calculation overflow.
785
786 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
787 (xg_select): Check for size calculation overflow.
788 Don't update size until alloc done.
789
790 * xrdb.c (get_environ_db): Don't assume path length fits in int,
791 as sprintf is limited to int lengths.
792
793 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
794 (X_LONG_MIN): New macros.
795 Use them to make the following changes clearer.
796 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
797 This change doesn't affect the value now, but it may help remind
798 future maintainers not to raise the value too much later.
799 (SELECTION_QUANTUM): Remove, replacing with ...
800 (selection_quantum): ... new function, which avoids overflow.
801 All uses changed.
802 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
803 assumption that selection length fits in 'int'.
804 (x_reply_selection_request, x_handle_selection_request)
805 (x_get_window_property, receive_incremental_selection)
806 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
807 (lisp_data_to_selection_data, clean_local_selection_data):
808 Use ptrdiff_t, not int, to record length of selection.
809 (x_reply_selection_request, x_get_window_property)
810 (receive_incremental_selection, x_property_data_to_lisp):
811 Redo calculations to avoid overflow.
812 (x_reply_selection_request): When sending hint, ceiling it at
813 X_LONG_MAX rather than relying on wraparound overflow to send
814 something.
815 (x_get_window_property, receive_incremental_selection)
816 (lisp_data_to_selection_data, x_property_data_to_lisp):
817 Check for size-calculation overflow.
818 (x_get_window_property, receive_incremental_selection)
819 (lisp_data_to_selection_data, Fx_register_dnd_atom):
820 Don't store size until memory allocation succeeds.
821 (x_get_window_property): Plug memory leak on memory exhaustion.
822 Don't double-block input; malloc is safe here. Don't assume 2**34
823 - 4 fits in unsigned long. Add an xassert to check
824 XGetWindowProperty overflow. Be more careful about overflow
825 calculations, and distinguish size from memory overflow better.
826 (receive_incremental_selection): When tracing, don't assume
827 unsigned int is less than INT_MAX.
828 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
829 harmful) conversions of unsigned short to int.
830 (lisp_data_to_selection_data): Don't assume that integers
831 in the range -65535 through -1 fit in an X unsigned short.
832 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
833 result parameters unless successful. Rely on cons_to_unsigned
834 to report problems with elements; the old code wasn't right anyway.
835 (x_check_property_data): Check for int overflow; we cannot use
836 a wider type due to X limits.
837 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
838
839 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
840
841 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
842 (x_term_init): Check for size calculation overflow.
843 (x_color_cells): Don't store size until memory allocation succeeds.
844 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
845 Don't assume alloca size is less than MAX_ALLOCA.
846 (x_term_init): Don't assume length fits in int (sprintf is limited
847 to int size).
848
849 Use ptrdiff_t for composition IDs.
850 * character.c (lisp_string_width):
851 * composite.c (composition_table_size, n_compositions)
852 (get_composition_id, composition_gstring_from_id):
853 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
854 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
855 * window.c (Frecenter):
856 Use ptrdiff_t, not int, for composition IDs.
857 * composite.c (get_composition_id): Check for integer overflow.
858 * composite.h: Adjust prototypes to match the above changes.
859
860 Use ptrdiff_t for hash table indexes.
861 * category.c (hash_get_category_set):
862 * ccl.c (ccl_driver):
863 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
864 * coding.c (coding_system_charset_list, detect_coding_system):
865 * coding.h (struct coding_system.id):
866 * composite.c (get_composition_id, gstring_lookup_cache):
867 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
868 * image.c (xpm_get_color_table_h):
869 * lisp.h (hash_lookup, hash_put):
870 * minibuf.c (Ftest_completion):
871 Use ptrdiff_t for hash table indexes, not int (which is too
872 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
873 32-bit --with-wide-int hosts).
874
875 * charset.c (Fdefine_charset_internal): Check for integer overflow.
876 Add a FIXME comment about memory leaks.
877 (syms_of_charset): Don't assume xmalloc returns.
878
879 Don't assume that stated character widths fit in int.
880 * character.c (Fchar_width, c_string_width, lisp_string_width):
881 * character.h (CHAR_WIDTH):
882 * indent.c (MULTIBYTE_BYTES_WIDTH):
883 Use sanitize_char_width to avoid undefined and/or bad behavior
884 with outlandish widths.
885 * character.h (sanitize_tab_width): Renamed from sanitize_width,
886 now that we have two such functions. All uses changed.
887 (sanitize_char_width): New inline function.
888
889 Don't assume that tab-width fits in int.
890 * character.h (sanitize_width): New inline function.
891 (SANE_TAB_WIDTH): New macro.
892 (ASCII_CHAR_WIDTH): Use it.
893 * indent.c (sane_tab_width): Remove. All uses replaced by
894 SANE_TAB_WIDTH (current_buffer).
895 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
896
897 * fileio.c: Integer overflow issues with file modes.
898 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
899
900 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
901 Remove unreachable code.
902 (read_hex, load_charset_map_from_file): Check for integer overflow.
903
904 * xterm.c: don't go over XClientMessageEvent limit
905 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
906 (x_send_scroll_bar_event): Likewise. Check that the size does not
907 exceed limits imposed by XClientMessageEvent, as well as the usual
908 ptrdiff_t and size_t limits.
909
910 * keyboard.c: Overflow, signedness and related fixes.
911 (make_lispy_movement): Use same integer type in forward decl
912 that is used in the definition.
913 (read_key_sequence, keyremap_step):
914 Change bufsize argument back to int, undoing my 2011-03-30 change.
915 We prefer signed types, and int is wide enough here.
916 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
917 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
918 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
919 length, not size_t. Use ptrdiff_t for index, not int.
920 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
921 possibility of integer overflow.
922
923 Overflow, signedness and related fixes for images.
924
925 * dispextern.h (struct it.stack[0].u.image.image_id)
926 (struct_it.image_id, struct image.id, struct image_cache.size)
927 (struct image_cache.used, struct image_cache.ref_count):
928 * gtkutil.c (update_frame_tool_bar):
929 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
930 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
931 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
932 * nsmenu.m (update_frame_tool_bar):
933 * xdisp.c (calc_pixel_width_or_height):
934 * xfns.c (image_cache_refcount):
935 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
936 on typical 64-bit hosts.
937
938 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
939 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
940 Omit unnecessary casts to int.
941 (parse_image_spec): Check that integers fall into 'int' range
942 when the callers expect that.
943 (image_ascent): Redo ascent calculation to avoid int overflow.
944 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
945 (lookup_image): Remove unnecessary tests.
946 (xbm_image_p): Locals are now of int, not EMACS_INT,
947 since parse_image_check makes sure they fit into int.
948 (png_load, gif_load, svg_load_image):
949 Prefer int to unsigned where either will do.
950 (tiff_handler): New function, combining the cores of the
951 old tiff_error_handler and tiff_warning_handler. This
952 function is rewritten to use vsnprintf and thereby avoid
953 stack buffer overflows. It uses only the features of vsnprintf
954 that are common to both POSIX and native Microsoft.
955 (tiff_error_handler, tiff_warning_handler): Use it.
956 (tiff_load, gif_load, imagemagick_load_image):
957 Don't assume :index value fits in 'int'.
958 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
959 (imagemagick_load_image): Check that crop parameters fit into
960 the integer types that MagickCropImage accepts. Don't assume
961 Vimagemagick_render_type has a nonnegative value. Don't assume
962 size_t fits in 'long'.
963 (gs_load): Use printmax_t to print the widest integers possible.
964 Check for integer overflow when computing image height and width.
965
966 2011-08-26 Eli Zaretskii <eliz@gnu.org>
967
968 * xdisp.c (redisplay_window): Don't force window start if point
969 will be invisible in the resulting window. (Bug#9324)
970
971 2011-08-25 Eli Zaretskii <eliz@gnu.org>
972
973 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
974 the display spec is of the form `(space ...)'.
975 (handle_display_spec): Return the value returned by
976 handle_single_display_spec, not just 1 or zero.
977 (handle_single_display_spec): If the display spec is of the form
978 `(space ...)', and specifies display in the text area, return 2
979 rather than 1.
980 (try_cursor_movement): Check for the need to scroll more
981 accurately, and prefer exact match for point under bidi. Don't
982 advance `row' beyond the last row of the window.
983
984 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
985 into disp_prop; all users changed.
986
987 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
988 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
989 for the text covered by the display property.
990
991 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
992
993 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
994 Change return value to nil.
995 (Frecord_buffer): Delete unused function.
996
997 2011-08-24 Eli Zaretskii <eliz@gnu.org>
998
999 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1000 buffers, return left-to-right.
1001 (set_cursor_from_row): Consider candidate row a win if its glyph
1002 represents a newline and point is on that newline. Fixes cursor
1003 positioning on the newline at EOL of R2L text within L2R
1004 paragraph, and vice versa.
1005 (try_cursor_movement): Check continued rows, in addition to
1006 continuation rows. Fixes unwarranted scroll when point enters a
1007 continued line of R2L text within an L2R paragraph, or vice versa.
1008 (cursor_row_p): Consider the case of point being equal to
1009 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1010 from the end of a short line to the beginning of a continued line
1011 of R2L text within L2R paragraph.
1012 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1013 composed characters.
1014
1015 * bidi.c (bidi_check_type): Use xassert.
1016 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1017 members.
1018
1019 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1020
1021 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1022 a character.
1023
1024 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1025
1026 * nsfont.m (ns_otf_to_script): Fix typo.
1027
1028 2011-08-22 Kenichi Handa <handa@m17n.org>
1029
1030 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1031 extra slot even if the purpose is char-code-property-table.
1032
1033 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1034
1035 * xdisp.c (redisplay_window): When computing centering_position,
1036 account for the height of the header line. (Bug#8874)
1037
1038 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1039 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1040 candidate is selected by the mouse, and that candidate has a
1041 composed character under the mouse.
1042
1043 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1044 coordinates reported by pos-visible-in-window-p for a composed
1045 character in column zero.
1046
1047 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1048
1049 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1050
1051 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1052
1053 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1054 consider it a hit if to_charpos is anywhere in the range of the
1055 composed buffer positions.
1056
1057 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1058
1059 * image.c (gif_load): Don't assume that each subimage has the same
1060 dimensions as the base image. Handle disposal method that is
1061 "undefined" by the gif spec (Bug#9335).
1062
1063 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1064
1065 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1066 (Fcondition_case): Document `debug' symbol in error handler.
1067
1068 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1069
1070 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1071 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1072 from an Org mode buffer to a Speedbar frame.
1073
1074 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1075 a composition, take its buffer position from IT->cmp_it.charpos.
1076 Fixes cursor positioning at the beginning of a line that begins
1077 with a composed character.
1078
1079 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1080
1081 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1082 character bidirectional type, use STRONG_L instead. Fixes crashes
1083 in a buffer produced by `describe-categories'.
1084
1085 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1086 members before the level stack, so they would be saved and
1087 restored when copying iterator state. Fixes incorrect reordering
1088 around TABs covered by display properties.
1089
1090 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1091
1092 * process.c (Fnetwork_interface_list): Correctly determine buffer
1093 size.
1094
1095 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1096
1097 * eval.c (internal_condition_case, internal_condition_case_1)
1098 (internal_condition_case_2, internal_condition_case_n):
1099 Remove unnecessary aborts (Bug#9081).
1100
1101 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1102
1103 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1104 has no `load' handler, try opening the file locally. (Bug#9311)
1105
1106 2011-08-16 Ken Brown <kbrown@cornell.edu>
1107
1108 * gmalloc.c: Expand comment.
1109
1110 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1111
1112 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1113 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1114
1115 2011-08-16 Ken Brown <kbrown@cornell.edu>
1116
1117 Fix memory allocation problems in Cygwin build (Bug#9273).
1118
1119 * unexcw.c ( __malloc_initialized): Declare external variable.
1120 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1121
1122 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1123 New variables.
1124 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1125 dumped emacs.
1126 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1127 in the static heap.
1128 [CYGWIN] (special_realloc): New function.
1129 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1130 requests to realloc storage in the static heap.
1131
1132 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1133
1134 * bidi.c (bidi_initialize): Remove unused local.
1135
1136 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1137
1138 * biditype.h: File removed.
1139
1140 * bidimirror.h: File removed.
1141
1142 * deps.mk (bidi.o): Remove biditype.h and
1143 bidimirror.h.
1144
1145 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1146 bidimirror.h.
1147
1148 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1149
1150 * chartab.c: Improve commentary for the uniprop_table API.
1151
1152 * bidi.c (bidi_paragraph_init): Support zero value of
1153 bidi_ignore_explicit_marks_for_paragraph_level.
1154 (bidi_initialize): Use uniprop_table instead of including
1155 biditype.h and bidimirror.h.
1156
1157 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1158 coordinates of the iterator when restoring from ppos_it.
1159 (Bug#9296)
1160
1161 2011-08-14 Kenichi Handa <handa@m17n.org>
1162
1163 * process.c (create_process): Call setup_process_coding_systems
1164 after the pid of the process is set to -1 (Bug#8162).
1165
1166 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1167
1168 * xdisp.c (move_it_in_display_line_to): Don't invoke
1169 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1170 ppos_it. Fixes vertical cursor motion when line beginning is
1171 covered by an image. (Bug#9296)
1172
1173 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1174
1175 * nsterm.h (ns_run_ascript): Declare.
1176 (NSAPP_DATA2_RUNASSCRIPT): Define.
1177
1178 * nsfns.m (as_script, as_result, as_status): New static variables.
1179 (ns_run_ascript): New function.
1180 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1181 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1182 the event loop. Get status from as_status (Bug#7276).
1183
1184 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1185 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1186 the event loop (Bug#7276).
1187
1188 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1189
1190 * gnutls.c (QCgnutls_bootprop_priority)
1191 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1192 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1193 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1194 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1195 (QCgnutls_bootprop_verify_hostname_error)
1196 (QCgnutls_bootprop_callbacks_verify): Rename from
1197 Qgnutls_bootprop_..., all uses changed.
1198
1199 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1200 uses changed.
1201
1202 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * xfaces.c (Qframe_set_background_mode): Now static.
1205 * dispextern.h (Qframe_set_background_mode): Remove decl.
1206
1207 * process.c (Fnetwork_interface_info): Declare local only if needed.
1208
1209 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1210
1211 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1212 (Fnetwork_interface_list): Allocate in increments of bytes instead
1213 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1214 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1215 sockaddr.
1216 (struct ifflag_def): notrailers is smart on OSX.
1217 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1218 Get hardware address with getifaddrs if available.
1219
1220 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1221
1222 * xdisp.c (iterate_out_of_display_property): xassert that
1223 IT->position is set to within IT->object's boundaries. Break from
1224 the loop as soon as EOB is reached; avoids infloops in redisplay
1225 when IT->position is set up wrongly due to some bug.
1226 Set IT->current to match the bidi iterator unconditionally.
1227 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1228 entry. Force push_it to save on the stack the current
1229 buffer/string position, to be restored by pop_it. Fix flags in
1230 the iterator structure wrt the object coming from a display
1231 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1232 properties. (Bug#9284)
1233
1234 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1235
1236 * fontset.c (fontset_get_font_group): Add proper type checks.
1237 (Bug#9172)
1238
1239 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1240
1241 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1242 and LC_VERSION_MIN_MACOSX.
1243 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1244 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1245
1246 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1247
1248 * xdisp.c (forward_to_next_line_start): Allow to use the
1249 no-display-properties-and-no-overlays under bidi display.
1250 Set disp_pos in the bidi iterator to avoid searches for display
1251 properties and overlays.
1252
1253 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1254
1255 * editfns.c (Fset_time_zone_rule): Document relationship with the
1256 setenv function.
1257
1258 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1259 the font entity extracted from the cache (Bug#8109).
1260
1261 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1262
1263 * composite.c (autocmp_chars): Don't reset point. That is done by
1264 restore_point_unwind (Bug#5984).
1265
1266 2011-08-07 Juri Linkov <juri@jurta.org>
1267
1268 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1269 to show the arg `TIME' instead of `TIMEVAL'.
1270
1271 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1272
1273 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1274 display property strides EOL and includes a newline, as in
1275 longlines-mode. (Bug#9254)
1276 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1277 word-wrap under bidirectional display. (Bug#9224)
1278
1279 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1280 is non-zero, even if the data buffer is NULL. Fixes a crash in
1281 vertical-motion with longlines-mode. (Bug#9254)
1282
1283 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1284
1285 * bidi.c <bidi_cache_total_alloc>: Now static.
1286 (bidi_initialize): Initialize bidi_cache_total_alloc.
1287
1288 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1289 cache. (Bug#9221)
1290
1291 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1292 amount allocated this far in `bidi_cache_total_alloc'.
1293 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1294 non-zero, only free the data buffer without restoring the cache
1295 contents. All callers changed.
1296
1297 * dispextern.h (bidi_unshelve_cache): Update prototype.
1298
1299 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1300 (move_it_in_display_line, move_it_to)
1301 (move_it_vertically_backward, move_it_by_lines): Replace the call
1302 to xfree to an equivalent call to bidi_unshelve_cache.
1303 (move_it_in_display_line_to): Fix logic of returning
1304 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1305
1306 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1307
1308 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1309 came from a string character with a `cursor' property. (Bug#9229)
1310
1311 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1312
1313 * Makefile.in (LIB_PTHREAD): New variable.
1314 (LIBES): Add LIB_PTHREAD (Bug#9216).
1315
1316 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1317 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1318
1319 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1320
1321 * regex.c (re_iswctype): Remove some redundant boolean
1322 conversions.
1323
1324 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1325
1326 * xterm.c (x_find_topmost_parent): New function.
1327 (x_set_frame_alpha): Find topmost parent window with
1328 x_find_topmost_parent and set the property there also (bug#9181).
1329 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1330
1331 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1332
1333 * callproc.c (Fcall_process): Avoid vfork clobbering
1334 the local vars buffer, coding_systems, current_dir.
1335
1336 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1337
1338 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1339
1340 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1341
1342 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1343 so that it is not optimized away.
1344
1345 * xdisp.c (compute_display_string_pos): Remove unused local.
1346
1347 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1348
1349 Fix slow cursor motion and scrolling in large buffers with
1350 selective display, like Org Mode buffers. (Bug#9218)
1351
1352 * dispextern.h (struct bidi_it): New member disp_prop_p.
1353
1354 * xdisp.c: Remove one-slot cache of display string positions.
1355 (compute_display_string_pos): Accept an additional argument
1356 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1357 for a display string or property. If found, set DISP_PROP_P
1358 non-zero.
1359
1360 * bidi.c (bidi_fetch_char): Accept an additional argument
1361 DISP_PROP_P, and pass it to compute_display_string_pos.
1362 Only handle text covered by a display string if DISP_PROP_P is returned
1363 non-zero. All callers of bidi_fetch_char changed.
1364
1365 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1366
1367 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1368
1369 2010-12-03 Don March <don@ohspite.net>
1370
1371 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1372 last character M-[char] is translated to ESC [char] (bug#7541).
1373
1374 2011-08-02 Kenichi Handa <handa@m17n.org>
1375
1376 * lisp.h (uniprop_table): Extern it.
1377
1378 * chartab.c (uniprop_table): Make it non-static.
1379
1380 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1381
1382 * xdisp.c (forward_to_next_line_start): Accept additional argument
1383 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1384 on the newline.
1385 (reseat_at_next_visible_line_start): Use the bidi iterator state
1386 returned by forward_to_next_line_start to restore the state of
1387 it->bidi_it after backing up to previous newline. (Bug#9212)
1388
1389 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1390
1391 * regex.c (re_comp): Protoize.
1392 (re_exec): Fix return type.
1393 (regexec): Fix type of `ret'. (Bug#9203)
1394
1395 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1396
1397 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1398 This is needed if max-image-size is a floating-point number.
1399
1400 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1401
1402 * print.c (print_object): Print empty symbol as ##.
1403
1404 * lread.c (read1): Read ## as empty symbol.
1405
1406 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1407
1408 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1409 setting frame foreground color (Bug#9175).
1410 (x_set_background_color): Likewise.
1411
1412 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1413 contents (Bug#9176).
1414 (EmacsTooltip -init): Remove bezels and add shadows to
1415 tooltip windows.
1416
1417 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1418 or scroll bar (Bug#8470).
1419
1420 * nsfont.m (nsfont_open): Remove assignment to voffset and
1421 unnecessary vars hshink, expand, hd, full_height, min_height.
1422 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1423
1424 * nsterm.h (nsfont_info): Remove voffset field.
1425
1426 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1427
1428 Implement strike-through and overline on NextStep (Bug#8863).
1429
1430 * nsfont.m (nsfont_open): Use underline position provided by font,
1431 instead of hard-coded value of 2.
1432 (nsfont_draw): Call ns_draw_text_decoration instead.
1433
1434 * nsterm.h: Add declaration for ns_draw_text_decoration.
1435
1436 * nsterm.m (ns_draw_text_decoration): New function for drawing
1437 underline, overline, and strike-through.
1438 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1439 ns_draw_text_decoration. Change treatment of cursor drawing to
1440 accommodate underlining, etc.
1441
1442 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1443
1444 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1445 default.
1446
1447 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1450 Without this fix, if a signal arrives just after memory fills up,
1451 'malloc' might be invoked reentrantly.
1452
1453 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1454 In other words, assume that every image size is allowed, on non-X
1455 hosts. This assumption is probably wrong, but it lets Emacs compile.
1456
1457 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1458
1459 * regex.c (re_iswctype): Convert return values to boolean.
1460
1461 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1462
1463 * xdisp.c (compute_display_string_pos): Don't use cached display
1464 string position if the buffer had its restriction changed.
1465 (Bug#9184)
1466
1467 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1468
1469 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1470
1471 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1472
1473 Integer signedness and overflow and related fixes. (Bug#9079)
1474
1475 * bidi.c: Integer size and overflow fixes.
1476 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1477 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1478 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1479 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1480 (bidi_find_other_level_edge):
1481 Use ptrdiff_t instead of EMACS_INT where either will do.
1482 This works better on 32-bit hosts configured --with-wide-int.
1483 (bidi_cache_ensure_space): Check for size-calculation overflow.
1484 Use % rather than repeated addition, for better worst-case speed.
1485 Don't set bidi_cache_size until after xrealloc returns, because it
1486 might not return.
1487 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1488 (bidi_cache_ensure_space): Also check that the bidi cache size
1489 does not exceed that of the largest Lisp string or buffer. See Eli
1490 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1491
1492 * alloc.c (__malloc_size_t): Remove.
1493 All uses replaced by size_t. See Andreas Schwab's note
1494 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1495
1496 * image.c: Improve checking for integer overflow.
1497 (check_image_size): Assume that f is nonnull, since
1498 it is always nonnull in practice. This is one less thing to
1499 worry about when checking for integer overflow later.
1500 (x_check_image_size): New function, which checks for integer
1501 overflow issues inside X.
1502 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1503 This removes the need for a memory_full check.
1504 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1505 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1506 (xbm_read_bitmap_data): Change locals back to 'int', since
1507 their values must fit in 'int'.
1508 (xpm_load_image, png_load, tiff_load):
1509 Invoke x_create_x_image_and_pixmap earlier,
1510 to avoid much needless work if the image is too large.
1511 (tiff_load): Treat overly large images as if
1512 x_create_x_image_and_pixmap failed, not as malloc failures.
1513 (gs_load): Use x_check_image_size.
1514
1515 * gtkutil.c: Omit integer casts.
1516 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1517 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1518
1519 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1520
1521 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1522 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1523 would wrongly return t on a 64-bit host.
1524
1525 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1526 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1527 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1528 and therefore cause GCC to emit a bogus diagnostic in some cases.
1529
1530 * image.c: Integer signedness and overflow and related fixes.
1531 This is not an exhaustive set of fixes, but it's time to
1532 record what I've got.
1533 (lookup_pixel_color, check_image_size): Remove redundant decls.
1534 (check_image_size): Don't assume that arbitrary EMACS_INT values
1535 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1536 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1537 (tiff_load, imagemagick_load_image):
1538 Check for overflow in size calculations.
1539 (x_create_x_image_and_pixmap): Remove unnecessary test for
1540 xmalloc returning NULL; that can't happen.
1541 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1542 (xpm_color_bucket): Use better integer hashing function.
1543 (xpm_cache_color): Don't possibly over-allocate memory.
1544 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1545 (gif_memory_source):
1546 Use ptrdiff_t, not int or size_t, to record sizes.
1547 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1548 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1549 either works, as we prefer signed integers.
1550 (tiff_read_from_memory, tiff_write_from_memory):
1551 Return tsize_t, not size_t, since that's what the TIFF API wants.
1552 (tiff_read_from_memory): Don't fail simply because the read would
1553 go past EOF; instead, return a short read.
1554 (tiff_load): Omit no-longer-needed casts.
1555 (Fimagemagick_types): Don't assume size fits into 'int'.
1556
1557 Improve hashing quality when configured --with-wide-int.
1558 * fns.c (hash_string): New function, taken from sxhash_string.
1559 Do not discard information about ASCII character case; this
1560 discarding is no longer needed.
1561 (sxhash-string): Use it. Change sig to match it. Caller changed.
1562 * lisp.h: Declare it.
1563 * lread.c (hash_string): Remove, since we now use fns.c's version.
1564 The fns.c version returns a wider integer if --with-wide-int is
1565 specified, so this should help the quality of the hashing a bit.
1566
1567 * emacs.c: Integer overflow minor fix.
1568 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1569 Define only if GNU_LINUX.
1570 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1571
1572 * dispnew.c: Integer signedness and overflow fixes.
1573 Remove unnecessary forward decls, that were a maintenance hassle.
1574 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1575 All uses changed.
1576 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1577 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1578 (prepare_desired_row, line_draw_cost):
1579 Use int, not unsigned, where either works.
1580 (save_current_matrix, restore_current_matrix):
1581 Use ptrdiff_t, not size_t, where either works.
1582 (init_display): Check for overflow more accurately, and without
1583 relying on undefined behavior.
1584
1585 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1586 Remove, replacing with the new symbols in lisp.h. All uses changed.
1587 * fileio.c (make_temp_name):
1588 * filelock.c (lock_file_1, lock_file):
1589 * xdisp.c (message_dolog):
1590 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1591 Use pMd etc. instead.
1592 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1593 replacing the pWIDE etc. symbols removed from editfns.c.
1594
1595 * keyboard.h (num_input_events): Now uintmax_t.
1596 This is (very slightly) less likely to mess up due to wraparound.
1597 All uses changed.
1598
1599 * buffer.c: Integer signedness fixes.
1600 (alloc_buffer_text, enlarge_buffer_text):
1601 Use ptrdiff_t rather than size_t when either will do, as we prefer
1602 signed integers.
1603
1604 * alloc.c: Integer signedness and overflow fixes.
1605 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1606 (__malloc_size_t): Default to size_t, not to int.
1607 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1608 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1609 Prefer ptrdiff_t to size_t when either would do, as we prefer
1610 signed integers.
1611 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1612 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1613 Now const. Initialize with values that are in range even if char
1614 is signed.
1615 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1616 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1617 These functions do the right thing with sizes > 2**32.
1618 (check_depth): Now ptrdiff_t, not int.
1619 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1620 Adjust to new way of storing sizes. Check for size overflow bugs
1621 in rest of code.
1622 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1623 slightly wrong anyway, as it missed one instance of
1624 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1625 (refill_memory_reserve): Omit needless cast to size_t.
1626 (mark_object_loop_halt): Mark as externally visible.
1627
1628 * xselect.c: Integer signedness and overflow fixes.
1629 (Fx_register_dnd_atom, x_handle_dnd_message):
1630 Use ptrdiff_t, not size_t, since we prefer signed.
1631 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1632 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1633 x_dnd_atoms_size and x_dnd_atoms_length.
1634
1635 * doprnt.c: Prefer signed to unsigned when either works.
1636 * eval.c (verror):
1637 * doprnt.c (doprnt):
1638 * lisp.h (doprnt):
1639 * xdisp.c (vmessage):
1640 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1641 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1642 prefer signed arithmetic to avoid comparison confusion.
1643 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1644 but is a bit tricky.
1645
1646 Assume freestanding C89 headers, string.h, stdlib.h.
1647 * data.c, doprnt.c, floatfns.c, print.c:
1648 Include float.h unconditionally.
1649 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1650 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1651 * regex.c: Likewise for stddef.h, string.h.
1652 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1653 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1654 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1655 (STDC_HEADERS): Remove obsolete defines.
1656 * sysdep.c: Include limits.h unconditionally.
1657
1658 Assume support for memcmp, memcpy, memmove, memset.
1659 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1660 * regex.c (memcmp, memcpy):
1661 Remove; we assume C89 now.
1662
1663 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1664 (__malloc_safe_bcopy): Remove; no longer needed.
1665
1666 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1667 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1668 well either way, and we prefer signed to unsigned.
1669
1670 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1671
1672 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1673 closes the connection while we're reading (bug#9182).
1674
1675 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1676
1677 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1678 are specified (Bug#9168).
1679
1680 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1681
1682 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1683 Found by GCC static checking and --with-wide-int on a 32-bit host.
1684
1685 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1686
1687 * xdisp.c (compute_display_string_pos): Fix logic of caching
1688 previous display string position. Initialize cached_prev_pos to
1689 -1. Fixes slow-down at the beginning of a buffer.
1690
1691 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1692
1693 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1694 for attrs[LFACE_FONTSET_INDEX].
1695
1696 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 * xml.c (parse_region): Remove unused local
1699 that was recently introduced.
1700
1701 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1702
1703 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1704 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1705
1706 * xdisp.c (move_it_in_display_line_to): Record the best matching
1707 position for TO_CHARPOS while scanning the line, and restore it on
1708 exit if none of the characters scanned was an exact match.
1709 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1710 when exact match is impossible due to invisible text, and the
1711 lines are truncated.
1712
1713 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1714
1715 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1716 for OSX >= 10.7.
1717
1718 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1719
1720 Fix a significant slow-down of cursor motion with C-n, C-p,
1721 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1722 auto-repeat under bidi redisplay in fontified buffers.
1723 * xdisp.c (compute_stop_pos_backwards): New function.
1724 (next_element_from_buffer): Call compute_stop_pos_backwards to
1725 find a suitable prev_stop when we find ourselves before
1726 base_level_stop.
1727 (reseat): Don't look for prev_stop, as that could mean a very long
1728 run.
1729 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1730 <cached_disp_overlay_modiff>: Cache for last found display string
1731 position.
1732 (compute_display_string_pos): Return the cached position if asked
1733 about the same buffer in the same area of character positions, and
1734 the buffer wasn't changed since the time the display string
1735 position was cached.
1736
1737 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1738
1739 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1740 is an integer, which is important for empty lines. (Bug#9149)
1741
1742 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1743
1744 * frame.c (Fmodify_frame_parameters): In tty case, update the
1745 default face if necessary (Bug#4238).
1746
1747 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1748
1749 * editfns.c (Fstring_to_char): No need to explain what a character
1750 is in the docstring (Bug#6576).
1751
1752 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1753
1754 * xml.c (parse_region): Make sure we always return a tree.
1755
1756 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1757
1758 * xml.c (parse_region): If a document contains only comments,
1759 return that, too.
1760
1761 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1762
1763 * xml.c (make_dom): Return comments, too.
1764
1765 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1766
1767 Port to OpenBSD.
1768 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1769 and the surrounding thread.
1770 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1771 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1772 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1773 timer goes off.
1774 * s/openbsd.h (BROKEN_SIGIO): Define.
1775 * unexelf.c (unexec) [__OpenBSD__]:
1776 Don't update the .mdebug section of the Alpha COFF symbol table.
1777
1778 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1779
1780 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1781 (bug#8460).
1782
1783 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1784
1785 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1786 This fixes some race conditions on the permissions of any newly
1787 created file.
1788
1789 * alloc.c (valid_pointer_p): Use pipe, not open.
1790 This fixes some permissions issues when debugging.
1791
1792 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1793 If fchown fails to set both uid and gid, try to set just gid,
1794 as that is sometimes allowed. Adjust the file's mode to eliminate
1795 setuid or setgid bits that are inappropriate if fchown fails.
1796
1797 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1798
1799 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1800 to compare Lisp_Objects.
1801 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1802 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1803 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1804
1805 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1806
1807 * lread.c (read_integer): Unread even EOF character.
1808 (read1): Likewise. Properly record start position of symbol.
1809
1810 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1811 symbol character follows.
1812
1813 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1814
1815 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1816 This works around a problem with the previous change to Fcopy_file.
1817 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1818 and without this change, GCC might complain about discarding
1819 fchown's return value.
1820
1821 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1822
1823 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1824
1825 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1826
1827 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1828
1829 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1830
1831 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1832 it's used from the C level.
1833
1834 * process.c: Use the same condition for POLL_FOR_INPUT in both
1835 keyboard.c and process.c (bug#1858).
1836
1837 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1838
1839 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1840 (Fgnutls_boot): Use it.
1841
1842 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1843
1844 * doc.c (Fsubstitute_command_keys): Revert last change.
1845
1846 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1847
1848 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1849 quotes the next character, and doesn't affect other longer
1850 sequences (bug#8935).
1851
1852 * lread.c (syms_of_lread): Clarify that is isn't only
1853 `eval-buffer' and `eval-defun' that's affected by
1854 `lexical-binding' (bug#8460).
1855
1856 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1857
1858 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1859 bidi redisplay when a line includes both an image and is
1860 truncated.
1861
1862 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1863
1864 Fix minor problems found by static checking.
1865 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1866 (elsz): Now a signed constant, not a size_t var. We prefer signed
1867 types to unsigned, to avoid integer comparison confusion. Without
1868 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1869 "cannot optimize loop, the loop counter may overflow", a symptom
1870 of the confusion.
1871 * indent.c (Fvertical_motion): Mark locals as initialized.
1872 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1873
1874 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1875
1876 * search.c (Fre_search_backward): Mention `case-fold-search' in
1877 all the re_search_* functions (bug#8138).
1878
1879 * keyboard.c (Fopen_dribble_file): Document when the file is
1880 closed (bug#8056).
1881
1882 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1883
1884 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1885 bidi_cache_idx.
1886
1887 Support bidi reordering of display and overlay strings.
1888 * xdisp.c (compute_display_string_pos)
1889 (compute_display_string_end): Accept additional argument STRING.
1890 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1891 (reseat_to_string): Initialize bidi_it->string.s and
1892 bidi_it->string.schars.
1893 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1894 NULL (avoids a crash in bidi_paragraph_init).
1895 Initialize itb.string.lstring.
1896 (init_iterator): Call bidi_init_it only of a valid
1897 buffer position was specified. Initialize paragraph_embedding to
1898 L2R.
1899 (reseat_to_string): Initialize the bidi iterator.
1900 (display_string): If we need to ignore text properties of
1901 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1902 original value of -1 will not work with bidi.)
1903 (compute_display_string_pos): First arg is now struct
1904 `text_pos *'; all callers changed. Support display properties on
1905 Lisp strings.
1906 (compute_display_string_end): Support display properties on Lisp
1907 strings.
1908 (init_iterator, reseat_1, reseat_to_string): Initialize the
1909 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1910 when iterating on a string not from display properties).
1911 (compute_display_string_pos, compute_display_string_end):
1912 Fix calculation of the object to scan. Fixes an error when using
1913 arrow keys.
1914 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1915 base_level_stop; instead, set base_level_stop to BEGV.
1916 Fixes crashes in vertical-motion.
1917 (next_element_from_buffer): Improve commentary for when
1918 the iterator is before prev_stop.
1919 (init_iterator): Initialize bidi_p from the default value of
1920 bidi-display-reordering, not from buffer-local value. Use the
1921 buffer-local value only if initializing for buffer iteration.
1922 (handle_invisible_prop): Support invisible properties on strings
1923 that are being bidi-reordered.
1924 (set_iterator_to_next): Support bidi reordering of C strings and
1925 Lisp strings.
1926 (next_element_from_string): Support bidi reordering of Lisp
1927 strings.
1928 (handle_stop_backwards): Support Lisp strings as well.
1929 (display_string): Support display of R2L glyph rows.
1930 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1931 (init_iterator): Don't initialize it->bidi_p for strings
1932 here.
1933 (reseat_to_string): Initialize it->bidi_p for strings here.
1934 (next_element_from_string, next_element_from_c_string)
1935 (next_element_from_buffer): Add xassert's for correspondence
1936 between IT's object being iterated and it->bidi_it.string
1937 structure.
1938 (face_before_or_after_it_pos): Support bidi iteration.
1939 (next_element_from_c_string): Handle the case of the first string
1940 character that is not the first one in the visual order.
1941 (get_visually_first_element): New function, refactored from common
1942 parts of next_element_from_buffer, next_element_from_string, and
1943 next_element_from_c_string.
1944 (tool_bar_lines_needed, redisplay_tool_bar)
1945 (display_menu_bar): Force left-to-right direction. Add a FIXME
1946 comment for making that be controlled by a user option.
1947 (push_it, pop_it): Save and restore the state of the
1948 bidi iterator. Save and restore the bidi_p flag.
1949 (pop_it): Iterate out of display property for string iteration as
1950 well.
1951 (iterate_out_of_display_property): Support iteration over strings.
1952 (handle_single_display_spec): Set up it->bidi_it for iteration
1953 over a display string, and call bidi_init_it.
1954 (handle_single_display_spec, next_overlay_string)
1955 (get_overlay_strings_1, push_display_prop): Set up the bidi
1956 iterator for displaying display or overlay strings.
1957 (forward_to_next_line_start): Don't use the shortcut if
1958 bidi-iterating.
1959 (back_to_previous_visible_line_start): If handle_display_prop
1960 pushed the iterator stack, restore the internal state of the bidi
1961 iterator by calling bidi_pop_it same number of times.
1962 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1963 and we are bidi-iterating, don't decrement the iterator position;
1964 instead, set the first_elt flag in the bidi iterator, to produce
1965 the same effect.
1966 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1967 (push_display_prop): xassert that we are iterating a buffer.
1968 (push_it, pop_it): Save and restore paragraph_embedding member.
1969 (handle_single_display_spec, next_overlay_string)
1970 (get_overlay_strings_1, reseat_1, reseat_to_string)
1971 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1972 correctly. Don't assume unibyte strings are not bidi-reordered.
1973 (compute_display_string_pos)
1974 (compute_display_string_end): Fix handling the case of C string.
1975 (push_it, pop_it): Save and restore from_disp_prop_p.
1976 (handle_single_display_spec, push_display_prop): Set the
1977 from_disp_prop_p flag.
1978 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1979 (pop_it): Call iterate_out_of_display_property only if we are
1980 popping after iteration over a string that came from a display
1981 property. Fix a typo in popping stretch info. Add an assertion
1982 for verifying that the iterator position is in sync with the bidi
1983 iterator.
1984 (handle_single_display_spec, get_overlay_strings_1)
1985 (push_display_prop): Fix initialization of paragraph direction for
1986 string when that of the parent object is not yet determined.
1987 (reseat_1): Call bidi_init_it to resync the bidi
1988 iterator with IT's position. (Bug#7616)
1989 (find_row_edges): If ROW->start.pos gives position
1990 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1991 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1992 Reset the from_disp_prop_p flag.
1993 (SAVE_IT, RESTORE_IT): New macros.
1994 (pos_visible_p, face_before_or_after_it_pos)
1995 (back_to_previous_visible_line_start)
1996 (move_it_in_display_line_to, move_it_in_display_line)
1997 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1998 (try_scrolling, redisplay_window, display_line): Use them when
1999 saving a temporary copy of the iterator and restoring it back.
2000 (back_to_previous_visible_line_start, reseat_1)
2001 (init_iterator): Empty the bidi cache "stack".
2002 (move_it_in_display_line_to): If iterator ended up at
2003 EOL, but we never saw any buffer positions smaller than
2004 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2005 motion in bidi-reordered lines.
2006 (move_it_in_display_line_to): Record prev_method and prev_pos
2007 immediately before the call to set_iterator_to_next. Fixes cursor
2008 motion in bidi-reordered lines with stretch glyphs and strings
2009 displayed in margins. (Bug#8133) (Bug#8867)
2010 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2011 TO_CHARPOS.
2012 (pos_visible_p): Support positions in bidi-reordered lines.
2013 Save and restore bidi cache.
2014
2015 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2016 (bidi_paragraph_info): Delete unused struct.
2017 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2018 (bidi_cache_start): New variable.
2019 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2020 to zero.
2021 (bidi_cache_fetch_state, bidi_cache_search)
2022 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2023 (bidi_cache_find, bidi_peek_at_next_level)
2024 (bidi_level_of_next_char, bidi_find_other_level_edge)
2025 (bidi_move_to_visually_next): Compare cache index with
2026 bidi_cache_start rather than with zero.
2027 (bidi_fetch_char): Accept new argument STRING; all callers
2028 changed. Support iteration over a string. Support strings with
2029 display properties. Support unibyte strings. Fix the type of
2030 `len' according to what STRING_CHAR_AND_LENGTH expects.
2031 (bidi_paragraph_init, bidi_resolve_explicit_1)
2032 (bidi_resolve_explicit, bidi_resolve_weak)
2033 (bidi_level_of_next_char, bidi_move_to_visually_next):
2034 Support iteration over a string.
2035 (bidi_set_sor_type, bidi_resolve_explicit_1)
2036 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2037 can now be zero (for strings); special values 0 and -1 were
2038 changed to -1 and -2, respectively.
2039 (bidi_char_at_pos): New function.
2040 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2041 Call it instead of FETCH_MULTIBYTE_CHAR.
2042 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2043 initialized to valid values.
2044 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2045 values.
2046 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2047 the test for valid cached positions. Fix the logic for looking up
2048 the sentinel state in the cache. GCPRO the Lisp string we are
2049 iterating.
2050 (bidi_push_it, bidi_pop_it): New functions.
2051 (bidi_initialize): Initialize the bidi cache start stack pointer.
2052 (bidi_cache_ensure_space): New function, refactored from part of
2053 bidi_cache_iterator_state. Don't assume the required size is just
2054 one BIDI_CACHE_CHUNK away.
2055 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2056 (bidi_count_bytes, bidi_char_at_pos): New functions.
2057 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2058 always valid if bidi_cache_idx is valid.
2059 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2060 is valid if it's going to be used.
2061 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2062 (bidi_cache_fetch_state, bidi_cache_search)
2063 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2064 (bidi_cache_iterator_state, bidi_cache_find)
2065 (bidi_find_other_level_edge, bidi_cache_start_stack):
2066 All variables related to cache indices are now EMACS_INT.
2067
2068 * dispextern.h (struct bidi_string_data): New structure.
2069 (struct bidi_it): New member `string'. Make flag members be 1-bit
2070 fields, and put them last in the struct.
2071 (compute_display_string_pos, compute_display_string_end):
2072 Update prototypes.
2073 (bidi_push_it, bidi_pop_it): Add prototypes.
2074 (struct iterator_stack_entry): New members bidi_p,
2075 paragraph_embedding, and from_disp_prop_p.
2076 (struct it): Member bidi_p is now a bit field 1 bit wide.
2077 (bidi_shelve_cache, bidi_unshelve_cache):
2078 Declare prototypes.
2079
2080 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2081 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2082 and vector-like objects.
2083
2084 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2085 cache around display iteration.
2086
2087 * window.c (Fwindow_end, window_scroll_pixel_based)
2088 (displayed_window_lines, Frecenter): Save and restore the bidi
2089 cache around display iteration.
2090
2091 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2092
2093 * editfns.c (Fdelete_region): Clarify the use of the named
2094 parameters (bug#6788).
2095
2096 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2097
2098 * indent.c (Fvertical_motion): Set and restore w->pointm when
2099 saving and restoring the window's buffer (Bug#9006).
2100
2101 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2102
2103 * editfns.c (Fstring_to_char): Clarify just what is returned
2104 (bug#6576). Text by Eli Zaretskii.
2105
2106 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2107
2108 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2109
2110 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2111
2112 * buffer.c (mmap_find): Fix a typo.
2113
2114 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2115
2116 Fix execution of x selection hooks.
2117 * xselect.c (Qx_lost_selection_functions)
2118 (Qx_sent_selection_functions): New vars.
2119 (syms_of_xselect): DEFSYM them.
2120 (x_handle_selection_request): Pass Qx_sent_selection_functions
2121 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2122 (x_handle_selection_clear,x_clear_frame_selections):
2123 Pass Qx_lost_selection_functions rather than
2124 Vx_lost_selection_functions to Frun_hook_with_args.
2125
2126 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2129 The old code sometimes used this field without initializing it.
2130
2131 * alloc.c (gc_sweep): Don't read past end of array.
2132 In theory, the old code could also have corrupted Emacs internals,
2133 though it'd be very unlikely.
2134
2135 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2136
2137 * character.c (Fcharacterp): Don't advertise optional ignored
2138 argument. (Bug#4026)
2139
2140 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2141
2142 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2143 key" (bug#4257).
2144
2145 * window.c (Fset_window_start): Doc fix (bug#4199).
2146 (Fset_window_hscroll): Ditto.
2147
2148 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2149
2150 Fix minor new problems caught by GCC 4.6.1.
2151 * term.c (init_tty): Remove unused local.
2152 * xsettings.c (store_monospaced_changed): Define this function only
2153 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2154 not used otherwise.
2155
2156 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2157
2158 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2159
2160 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2161
2162 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2163 are the mini-buffer and the echo area (bug#3320).
2164
2165 * term.c (init_tty): Remove support for supdup, c10 and perq
2166 terminals, which are no longer supported (bug#1482).
2167
2168 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2169
2170 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2171
2172 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2173
2174 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2175 for non-popups (Bug#3642).
2176
2177 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2178
2179 * alloc.c (reset_malloc_hooks): Protoize.
2180 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2181 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2182 * cm.c (losecursor): Likewise.
2183 * data.c (fmod): Likewise.
2184 * dispnew.c (swap_glyphs_in_rows): Likewise.
2185 * emacs.c (memory_warning_signal): Likewise.
2186 * floatfns.c (float_error): Likewise.
2187 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2188 (otf_open, font_otf_capability, generate_otf_features)
2189 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2190 Likewise.
2191 * image.c (pbm_read_file): Likewise.
2192 * indent.c (string_display_width): Likewise.
2193 * intervals.c (check_for_interval, search_for_interval)
2194 (inc_interval_count, count_intervals, root_interval)
2195 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2196 * lread.c (defalias): Likewise.
2197 * ralloc.c (r_alloc_check): Likewise.
2198 * regex.c (set_image_of_range_1, set_image_of_range)
2199 (regex_grow_registers): Likewise.
2200 * sysdep.c (strerror): Likewise.
2201 * termcap.c (valid_filename_p, tprint, main): Likewise.
2202 * tparam.c (main): Likewise.
2203 * unexhp9k800.c (run_time_remap, save_data_space)
2204 (update_file_ptrs, read_header, write_header, calculate_checksum)
2205 (copy_file, copy_rest, display_header): Likewise.
2206 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2207 Likewise.
2208 * xdisp.c (check_it): Likewise.
2209 * xfaces.c (register_color, unregister_color, unregister_colors):
2210 Likewise.
2211 * xfns.c (print_fontset_result): Likewise.
2212 * xrdb.c (member, fatal, main): Likewise.
2213
2214 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2215
2216 Fix minor problems found by static checking (Bug#9031).
2217 * chartab.c (char_table_set_range, map_sub_char_table):
2218 Remove unused locals.
2219 (uniprop_table): Now static.
2220 * composite.c (_work_char): Remove unused static var.
2221
2222 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2223
2224 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2225
2226 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2227
2228 * gtkutil.c (qttip_cb): Remove code without function.
2229
2230 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2231
2232 * w32.c (pthread_sigmask): New stub.
2233
2234 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2235
2236 Use pthread_sigmask, not sigprocmask (Bug#9010).
2237 sigprocmask is portable only for single-threaded applications, and
2238 Emacs can be multi-threaded when it uses GTK.
2239 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2240 (LIBES): Use it.
2241 * callproc.c (Fcall_process):
2242 * process.c (create_process):
2243 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2244 Use pthread_sigmask, not sigprocmask.
2245
2246 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2247
2248 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2249 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2250 wrong (Bug#8591).
2251
2252 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2253
2254 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2255 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2256 (xg_hide_tooltip): Fix comment.
2257
2258 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2259 in registerServicesMenuSendTypes.
2260 (validRequestorForSendType): Don't check ns_return_types.
2261
2262 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2263 ns_return_type.
2264
2265 2011-07-08 Jason Rumney <jasonr@gnu.org>
2266
2267 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2268 frame struct members of non-existent frames (Bug#6284).
2269
2270 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2271
2272 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2273 variable firstTime not needed on OSX >= 10.6.
2274 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2275 >= 10.5. Use setKnobProportion, setDoubleValue.
2276
2277 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2278 (MAC_OS_X_VERSION_10_5): Define if not defined.
2279 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2280 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2281 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2282
2283 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2284 cString and lossyCString on OSX >= 10.4
2285
2286 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2287 sizeToFit on OSX >= 10.2.
2288
2289 * nsimage.m (allocInitFromFile): Don't use deprecated method
2290 bestRepresentationForDevice on OSX >= 10.6.
2291
2292 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2293 to avoid warning.
2294
2295 * emacs.c: Declare unexec_init_emacs_zone.
2296
2297 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2298
2299 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2300
2301 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2302 on svcsMenu (Bug#8842).
2303
2304 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2305 ns_return_types.
2306 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2307
2308 * nsterm.m (QUTF8_STRING): Declare.
2309 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2310 (validRequestorForSendType): Return type is (id).
2311 Change indexOfObjectIdenticalTo to indexOfObject.
2312 Check if we have local selection before returning self (Bug#8842).
2313 (writeSelectionToPasteboard): Put local selection into paste board
2314 if we have a local selection (Bug#8842).
2315 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2316
2317 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2318 (ns_get_local_selection): Declare.
2319
2320 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2321
2322 * keymap.c (describe_map_tree): Don't insert a double newline at
2323 the end of the buffer (bug#1169) and return whether we inserted
2324 something.
2325
2326 * callint.c (Fcall_interactively): Change "reading args" to
2327 "providing args" to try to clarify what it does (bug#1010).
2328
2329 2011-07-07 Kenichi Handa <handa@m17n.org>
2330
2331 * composite.c (composition_compute_stop_pos): Ignore a static
2332 composition starting before CHARPOS (Bug#8915).
2333
2334 * xdisp.c (handle_composition_prop): Likewise.
2335
2336 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2337
2338 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2339 (Bug#9015)
2340
2341 2011-07-07 Kenichi Handa <handa@m17n.org>
2342
2343 * character.h (unicode_category_t): New enum type.
2344
2345 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2346 (Qchar_code_property_table): New variable.
2347 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2348 (UNIPROP_COMPRESSED_FORM_P): New macros.
2349 (char_table_ascii): Uncompress the compressed values.
2350 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2351 Uncompress the compressed values.
2352 (sub_char_table_ref_and_range): Likewise.
2353 (char_table_ref_and_range): Uncompress the compressed values.
2354 (sub_char_table_set): New arg is_uniprop. Callers changed.
2355 Uncompress the compressed values.
2356 (sub_char_table_set_range): Args changed. Callers changed.
2357 (char_table_set_range): Adjuted for the above change.
2358 (map_sub_char_table): Delete args default_val and parent. Add arg
2359 top. Give decoded values to a Lisp function.
2360 (map_char_table): Adjust for the above change. Give decoded
2361 values to a Lisp function. Gcpro more variables.
2362 (uniprop_table_uncompress)
2363 (uniprop_decode_value_run_length): New functions.
2364 (uniprop_decoder, uniprop_decoder_count): New variables.
2365 (uniprop_get_decoder, uniprop_encode_value_character)
2366 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2367 New functions.
2368 (uniprop_encoder, uniprop_encoder_count): New variables.
2369 (uniprop_get_encoder, uniprop_table)
2370 (Funicode_property_table_internal, Fget_unicode_property_internal)
2371 (Fput_unicode_property_internal): New functions.
2372 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2373 Sunicode_property_table_internal, Sget_unicode_property_internal,
2374 and Sput_unicode_property_internal. Defvar_lisp
2375 char-code-property-alist.
2376
2377 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2378 Vunicode_category_table.
2379
2380 * font.c (font_range): Adjust for the change of
2381 Vunicode_category_table.
2382
2383 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2384
2385 * m/iris4d.h: Remove file, move contents ...
2386 * s/irix6-5.h: ... here.
2387
2388 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2389
2390 Remove unportable assumption about struct layout (Bug#8884).
2391 * alloc.c (mark_buffer):
2392 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2393 (clone_per_buffer_values): Don't assume that
2394 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2395 This isn't true in general, and it's particularly not true
2396 if Emacs is configured with --with-wide-int.
2397 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2398 New macros, used in the buffer.c change.
2399
2400 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2401
2402 * xsettings.c: Use both GConf and GSettings if both are available.
2403 (store_config_changed_event): Add comment.
2404 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2405 (store_tool_bar_style_changed): New functions.
2406 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2407 (struct xsettings): Move font inside HAVE_XFT.
2408 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2409 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2410 Move inside HAVE_XFT.
2411 (something_changed_gsettingsCB): Rename from something_changedCB.
2412 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2413 also.
2414 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2415 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2416 (something_changed_gconfCB): Rename from something_changedCB.
2417 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2418 (parse_settings): Move check for font inside HAVE_XFT.
2419 (read_settings, apply_xft_settings): Add comment.
2420 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2421 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2422 call store_font_name_changed.
2423 (xft_settings_event): Add comment.
2424 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2425 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2426 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2427 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2428 (xsettings_initialize): Call init_gsettings last.
2429 (xsettings_get_system_font, xsettings_get_system_normal_font):
2430 Add comment.
2431
2432 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2433
2434 Random fixes. E.g., (random) never returned negative values.
2435 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2436 subseconds part to the entropy, as that's a bit more random.
2437 Prefer signed to unsigned, since the signedness doesn't matter and
2438 in general we prefer signed. When given a limit, use a
2439 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2440 latter isn't right if USE_2_TAGS_FOR_INTS.
2441 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2442 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2443
2444 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2445
2446 * textprop.c (text_property_stickiness):
2447 Obey Vtext_property_default_nonsticky.
2448 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2449 * w32fns.c (syms_of_w32fns):
2450 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2451
2452 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2453
2454 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2455 This is more efficient than Ffile_directory_p and avoids a minor race.
2456
2457 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2458
2459 * buffer.c (Foverlay_put): Say what the return value is
2460 (bug#7835).
2461
2462 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2463 is a directory before asking whether to use the file name
2464 (bug#7564).
2465 (barf_or_query_if_file_exists): Make the "File is a directory"
2466 error be more correct.
2467
2468 * fns.c (Frequire): Remove the mention of the .gz files, since
2469 that's installation-specific, but keep the mention of
2470 `get-load-suffixes'.
2471
2472 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2473
2474 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2475 Report string overflow if the output is too long.
2476
2477 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2478
2479 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2480 (syms_of_gnutls): Remove duplicate DEFSYM for
2481 Qgnutls_bootprop_verify_hostname_error, an error for
2482 Qgnutls_bootprop_verify_error (which is no longer used).
2483
2484 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2485 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2486 Also (re)move comments that are misplaced or no longer relevant.
2487
2488 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2489
2490 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2491
2492 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2493
2494 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2495 and background color parameters if they have been changed.
2496
2497 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2498
2499 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2500
2501 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 * xsettings.c (SYSTEM_FONT): Define only when used.
2504 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2505
2506 * keymap.c (access_keymap_1): Now static.
2507
2508 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2509
2510 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2511 leave any prefix arg for the up event (Bug#1586).
2512
2513 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2514
2515 * lread.c (syms_of_lread): Mention single symbols defined by
2516 `defvar' or `defconst' (bug#7154).
2517
2518 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2519 (Frequire): Mention get-load-suffixes.
2520
2521 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2522
2523 * window.h (window): Remove clone_number slot.
2524 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2525 Remove.
2526 (make_parent_window, make_window, saved_window)
2527 (Fset_window_configuration, save_window_save): Don't deal with
2528 clone numbers.
2529 * buffer.c (Qclone_number): Remove declaration.
2530 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2531
2532 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2533
2534 Add multiple inheritance to keymaps.
2535 * keymap.c (Fmake_composed_keymap): New function.
2536 (Fset_keymap_parent): Simplify.
2537 (fix_submap_inheritance): Remove.
2538 (access_keymap_1): New function extracted from access_keymap to handle
2539 embedded parents and handle lists of maps.
2540 (access_keymap): Use it.
2541 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2542 (Fcopy_keymap): Handle embedded parents.
2543 (Fcommand_remapping, define_as_prefix): Simplify.
2544 (Fkey_binding): Simplify.
2545 (syms_of_keymap): Move minibuffer-local-completion-map,
2546 minibuffer-local-filename-completion-map,
2547 minibuffer-local-must-match-map, and
2548 minibuffer-local-filename-must-match-map to Elisp.
2549 (syms_of_keymap): Defsubr make-composed-keymap.
2550 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2551 (parse_menu_item): Trivial simplification.
2552
2553 2011-07-01 Glenn Morris <rgm@gnu.org>
2554
2555 * Makefile.in (SETTINGS_LIBS): Fix typo.
2556
2557 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2558
2559 * coding.c (Fencode_coding_string): Record the last coding system
2560 used, as the function doc string says (bug#8738).
2561
2562 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2563
2564 * xsettings.c (store_monospaced_changed): Take new font as arg and
2565 check for change against current_mono_font.
2566 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2567 (emacs_settings_constructor, emacs_settings_get_property)
2568 (emacs_settings_set_property, emacs_settings_class_init)
2569 (emacs_settings_init, gsettings_obj): Remove.
2570 (something_changedCB): New function for HAVE_GSETTINGS.
2571 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2572 with value as argument.
2573 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2574 g_settings_new (Bug#8967). Do not create gsettings_obj.
2575 Remove calls to g_settings_bind. Connect something_changedCB to
2576 "changed".
2577
2578 * xgselect.c: Add defined (HAVE_GSETTINGS).
2579 (xgselect_initialize): Ditto.
2580
2581 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2582 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2583 xg_select.
2584
2585 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2586
2587 * eval.c (struct backtrace): Simplify and port the data structure.
2588 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2589 signed bit field, as this assumption is not portable and it makes
2590 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2591 "char debug_on_exit : 1" as this is not portable either; instead,
2592 use the portable "unsigned int debug_on_exit : 1". Remove unused
2593 member evalargs. Remove obsolete comments about cc bombing out.
2594
2595 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2596
2597 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2598 Let HAVE_GSETTINGS override HAVE_GCONF.
2599 (store_monospaced_changed): New function.
2600 (EMACS_SETTINGS): A new type derived from GObject to handle
2601 GSettings notifications.
2602 (emacs_settings_constructor, emacs_settings_get_property)
2603 (emacs_settings_set_property, emacs_settings_class_init):
2604 New functions.
2605 (gsettings_client, gsettings_obj): New variables.
2606 (GSETTINGS_SCHEMA): New define.
2607 (something_changedCB): Call store_monospaced_changed.
2608 (init_gsettings): New function.
2609 (xsettings_initialize): Call init_gsettings.
2610 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2611 to NULL.
2612
2613 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2614 GCONF_CFLAGS/LIBS.
2615
2616 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2617
2618 * window.c (resize_root_window, grow_mini_window)
2619 (shrink_mini_window): Rename Qresize_root_window to
2620 Qwindow_resize_root_window and Qresize_root_window_vertically to
2621 Qwindow_resize_root_window_vertically.
2622
2623 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2624
2625 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2626
2627 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2628
2629 * makefile.w32-in: Redesign dependencies so they reflect more
2630 clearly which files are directly included by each source file,
2631 and not through other includes.
2632
2633 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2634
2635 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2636 (sort_overlays, overlay_strings): When an overlay's clone number
2637 matches the window's clone number process the overlay even if
2638 the overlay's window property doesn't match the current window.
2639
2640 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2641 (Fwindow_hchild): Rename to Fwindow_left_child.
2642 (Fwindow_next): Rename to Fwindow_next_sibling.
2643 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2644 (resize_window_check): Rename to window_resize_check.
2645 (resize_window_apply): Rename to window_resize_apply.
2646 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2647 (Fdelete_other_windows_internal, resize_frame_windows)
2648 (Fsplit_window_internal, Fdelete_window_internal)
2649 (grow_mini_window, shrink_mini_window)
2650 (Fresize_mini_window_internal): Fix callers accordingly.
2651
2652 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2653
2654 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2655 (emacs_fixed_set_min_size): Remove.
2656 (emacs_fixed_new): Take frame as argument.
2657
2658 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2659 (_EmacsFixedPrivate): Remove minwidth/height.
2660 Add struct frame *f.
2661 (emacs_fixed_init): Initialize priv->f.
2662 (get_parent_class, emacs_fixed_set_min_size): Remove.
2663 (emacs_fixed_new): Set priv->f to argument.
2664 (emacs_fixed_get_preferred_width)
2665 (emacs_fixed_get_preferred_height): Use min_width/height from
2666 frames size_hint to set minimum and natural (Bug#8919).
2667 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2668 and use min_width/height from frames size_hint to set
2669 min_width/height (Bug#8919).
2670
2671 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2672 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2673 Fix indentation.
2674
2675 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2676
2677 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2678 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2679 called at ZV.
2680
2681 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2682
2683 * process.c (wait_reading_process_output): Bypass select if
2684 waiting for a cell while ignoring keyboard input, and input is
2685 pending. Suggested by Jan Djärv (Bug#8869).
2686
2687 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 Use gnulib's dup2 module instead of rolling our own.
2690 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2691
2692 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2693
2694 * dispnew.c (scrolling_window): Before scrolling, turn off a
2695 mouse-highlight in the window being scrolled.
2696
2697 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2698
2699 Move DEFSYM to lisp.h and use everywhere.
2700
2701 * character.h (DEFSYM): Move declaration...
2702 * lisp.h (DEFSYM): ...here.
2703
2704 * gnutls.c:
2705 * minibuf.c:
2706 * w32menu.c:
2707 * w32proc.c:
2708 * w32select.c: Don't include character.h.
2709
2710 * alloc.c (syms_of_alloc):
2711 * buffer.c (syms_of_buffer):
2712 * bytecode.c (syms_of_bytecode):
2713 * callint.c (syms_of_callint):
2714 * casefiddle.c (syms_of_casefiddle):
2715 * casetab.c (init_casetab_once):
2716 * category.c (init_category_once, syms_of_category):
2717 * ccl.c (syms_of_ccl):
2718 * cmds.c (syms_of_cmds):
2719 * composite.c (syms_of_composite):
2720 * dbusbind.c (syms_of_dbusbind):
2721 * dired.c (syms_of_dired):
2722 * dispnew.c (syms_of_display):
2723 * doc.c (syms_of_doc):
2724 * editfns.c (syms_of_editfns):
2725 * emacs.c (syms_of_emacs):
2726 * eval.c (syms_of_eval):
2727 * fileio.c (syms_of_fileio):
2728 * fns.c (syms_of_fns):
2729 * frame.c (syms_of_frame):
2730 * fringe.c (syms_of_fringe):
2731 * insdel.c (syms_of_insdel):
2732 * keymap.c (syms_of_keymap):
2733 * lread.c (init_obarray, syms_of_lread):
2734 * macros.c (syms_of_macros):
2735 * msdos.c (syms_of_msdos):
2736 * print.c (syms_of_print):
2737 * process.c (syms_of_process):
2738 * search.c (syms_of_search):
2739 * sound.c (syms_of_sound):
2740 * syntax.c (init_syntax_once, syms_of_syntax):
2741 * terminal.c (syms_of_terminal):
2742 * textprop.c (syms_of_textprop):
2743 * undo.c (syms_of_undo):
2744 * w32.c (globals_of_w32):
2745 * window.c (syms_of_window):
2746 * xdisp.c (syms_of_xdisp):
2747 * xfaces.c (syms_of_xfaces):
2748 * xfns.c (syms_of_xfns):
2749 * xmenu.c (syms_of_xmenu):
2750 * xsettings.c (syms_of_xsettings):
2751 * xterm.c (syms_of_xterm): Use DEFSYM.
2752
2753 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2754
2755 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2756
2757 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2758
2759 Integer and buffer overflow fixes (Bug#8873).
2760
2761 * print.c (printchar, strout): Check for string overflow.
2762 (PRINTPREPARE, printchar, strout):
2763 Don't set size unless allocation succeeds.
2764
2765 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2766 for sizes. Check for string overflow more accurately.
2767 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2768
2769 * macros.c: Integer and buffer overflow fixes.
2770 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2771 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2772 Use ptrdiff_t, not int, for sizes.
2773 Don't increment bufsize until after realloc succeeds.
2774 Check for size-calculation overflow.
2775 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2776
2777 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2778
2779 * lread.c: Integer overflow fixes.
2780 (read_integer): Radix is now EMACS_INT, not int,
2781 to improve quality of diagnostics for out-of-range radices.
2782 Calculate buffer size correctly for out-of-range radices.
2783 (read1): Check for integer overflow in radices, and in
2784 read-circle numbers.
2785 (read_escape): Avoid int overflow.
2786 (Fload, openp, read_buffer_size, read1)
2787 (substitute_object_recurse, read_vector, read_list, map_obarray):
2788 Use ptrdiff_t, not int, for sizes.
2789 (read1): Use EMACS_INT, not int, for sizes.
2790 Check for size overflow.
2791
2792 * image.c (cache_image): Check for size arithmetic overflow.
2793
2794 * lread.c: Integer overflow issues.
2795 (saved_doc_string_size, saved_doc_string_length)
2796 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2797 Now ptrdiff_t, not int.
2798 (read1): Don't assume doc string length fits in int. Check for
2799 out-of-range doc string lengths.
2800 (read_list): Don't assume file position fits in int.
2801 (read_escape): Check for hex character overflow.
2802
2803 2011-06-22 Leo Liu <sdl.web@gmail.com>
2804
2805 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2806 Move to minibuffer.el.
2807
2808 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2811 The following patches are for when GLYPH_DEBUG && !XASSERT.
2812 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2813 * dispnew.c (flush_stdout):
2814 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2815 Mark as externally visible.
2816 * dispnew.c (check_window_matrix_pointers): Now static.
2817 * dispnew.c (window_to_frame_vpos):
2818 * xfns.c (unwind_create_frame):
2819 * xterm.c (x_check_font): Remove unused local.
2820 * scroll.c (CHECK_BOUNDS):
2821 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2822 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2823 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2824 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2825 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2826 Now static.
2827 (debug_method_add): Use va_list and vsprintf rather than relying
2828 on undefined behavior with wrong number of arguments.
2829 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2830 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2831 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2832 since we're not interested in debugging glyphs with old libraries.
2833 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2834 GCC 4.6.0's static checking.
2835
2836 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2837
2838 Integer overflow and signedness fixes (Bug#8873).
2839 A few related buffer overrun fixes, too.
2840
2841 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2842
2843 * dispextern.h (struct face.stipple):
2844 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2845 (x_bitmap_mask, x_allocate_bitmap_record)
2846 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2847 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2848 (x_create_bitmap_from_xpm_data):
2849 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2850 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2851 (.bitmaps_last):
2852 * xfaces.c (load_pixmap):
2853 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2854 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2855 (.bitmaps_last, struct x_output.icon_bitmap):
2856 Use ptrdiff_t, not int, for bitmap indexes.
2857 (x_allocate_bitmap_record): Check for size overflow.
2858 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2859
2860 Use ptrdiff_t, not int, for overlay counts.
2861 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2862 * editfns.c (overlays_around, get_pos_property):
2863 * textprop.c (get_char_property_and_overlay):
2864 * xdisp.c (next_overlay_change, note_mouse_highlight):
2865 * xfaces.c (face_at_buffer_position):
2866 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2867 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2868 (Fnext_overlay_change, Fprevious_overlay_change)
2869 (mouse_face_overlay_overlaps, Foverlays_in):
2870 Use ptrdiff_t, not int, for sizes.
2871 (overlays_at, overlays_in): Check for size-calculation overflow.
2872
2873 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2874
2875 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2876 (x_session_initialize): Do not assume string length fits in int.
2877
2878 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2879 This is unlikely, but can occur if DPI is outlandish.
2880
2881 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2882 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2883
2884 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2885 * xrdb.c (magic_file_p, search_magic_path):
2886 Omit last arg SUFFIX; it was always 0. All callers changed.
2887 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2888
2889 * xfont.c (xfont_match): Avoid need for strlen.
2890
2891 * xfns.c: Don't assume strlen fits in int.
2892 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2893
2894 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2895 not unsigned long, as we prefer signed integers. All callers changed.
2896 Detect integer overflow in repeat count.
2897 (message_dolog): Don't assume print length fits in 39 bytes.
2898 (display_mode_element): Don't assume strlen fits in int.
2899
2900 * termcap.c: Don't assume sizes fit in int and never overflow.
2901 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2902 (gobble_line): Check for size-calculation overflow.
2903
2904 * minibuf.c (Fread_buffer):
2905 * lread.c (intern, intern_c_string):
2906 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2907 Don't assume string length fits in int.
2908
2909 * keyboard.c (parse_tool_bar_item):
2910 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2911
2912 * font.c: Don't assume string length fits in int.
2913 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2914 Use ptrdiff_t, not int.
2915 (font_intern_prop): Don't assume string length fits in int.
2916 Don't assume integer property fits in fixnum.
2917 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2918
2919 * filelock.c: Fix some buffer overrun and integer overflow issues.
2920 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2921 Reformulate so as not to need the command string.
2922 Invoke gzip -cd rather than gunzip, as it's more portable.
2923 (lock_info_type, lock_file_1, lock_file):
2924 Don't assume pid_t and time_t fit in unsigned long.
2925 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2926 (current_lock_owner): Prefer signed type for sizes.
2927 Use memcpy, not strncpy, where memcpy is what is really wanted.
2928 Don't assume (via atoi) that time_t and pid_t fit in int.
2929 Check for time_t and/or pid_t out of range, e.g., via a network share.
2930 Don't alloca where an auto var works fine.
2931
2932 * fileio.c: Fix some integer overflow issues.
2933 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2934 Don't assume string length fits in int.
2935 (directory_file_name): Don't assume string length fits in long.
2936 (make_temp_name): Don't assume pid fits in int, or that its print
2937 length is less than 20.
2938
2939 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2940
2941 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2942
2943 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2944
2945 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2946 We prefer signed integers, even for size calculations.
2947
2948 * emacs.c: Don't assume string length fits in 'int'.
2949 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2950 (main): Don't invoke strlen when not needed.
2951
2952 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2953 (XD_DEBUG_MESSAGE): Don't waste a byte.
2954
2955 * callproc.c (getenv_internal_1, getenv_internal)
2956 (Fgetenv_internal):
2957 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2958
2959 * lread.c (invalid_syntax): Omit length argument.
2960 All uses changed. This doesn't fix a bug, but it simplifies the
2961 code away from its former Hollerith-constant appearance, and it's
2962 one less 'int' to worry about when looking at integer-overflow issues.
2963 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2964
2965 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2966 This didn't break anything, but it didn't help either.
2967 It's confusing to put a bogus integer in a place where the actual
2968 value does not matter.
2969 (LIST_END_P): Remove unused macro and its bogus comment.
2970 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2971
2972 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2973 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2974 implementation.
2975 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2976 We prefer signed types, and the value cannot exceed the EMACS_INT
2977 range anyway (because otherwise the length would not be representable).
2978 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2979 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2980 This avoids a GCC warning when WIDE_EMACS_INT.
2981
2982 * indent.c (sane_tab_width): New function.
2983 (current_column, scan_for_column, Findent_to, position_indentation)
2984 (compute_motion): Use it. This is just for clarity.
2985 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2986
2987 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2988
2989 * lisp.h (lint_assume): New macro.
2990 * composite.c (composition_gstring_put_cache):
2991 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2992
2993 * editfns.c, insdel.c:
2994 Omit unnecessary forward decls, to simplify future changes.
2995
2996 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2997
2998 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2999
3000 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3001 Use much-faster test for byte-length change.
3002 Don't assume string byte-length fits in 'int'.
3003 Check that character arg fits in 'int'.
3004 (mapcar1): Declare byte as byte, for clarity.
3005
3006 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3007
3008 * fns.c (concat): Catch string overflow earlier.
3009 Do not rely on integer wraparound.
3010
3011 * dispextern.h (struct it.overlay_strings_charpos)
3012 (struct it.selective): Now EMACS_INT, not int.
3013 * xdisp.c (forward_to_next_line_start)
3014 (back_to_previous_visible_line_start)
3015 (reseat_at_next_visible_line_start, next_element_from_buffer):
3016 Don't arbitrarily truncate the value of 'selective' to int.
3017
3018 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3019
3020 * composite.c: Don't truncate sizes to 'int'.
3021 (composition_gstring_p, composition_reseat_it)
3022 (composition_adjust_point): Use EMACS_INT, not int.
3023 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3024 not EMACS_UINT, for indexes.
3025
3026 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3027
3028 * buffer.c: Include <verify.h>.
3029 (struct sortvec.priority, struct sortstr.priority):
3030 Now EMACS_INT, not int.
3031 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3032 (struct sortstr.size, record_overlay_string)
3033 (struct sortstrlist.size, struct sortlist.used):
3034 Don't truncate size to int.
3035 (record_overlay_string): Check for size-calculation overflow.
3036 (init_buffer_once): Check at compile-time, not run-time.
3037
3038 2011-06-22 Jim Meyering <meyering@redhat.com>
3039
3040 Don't leak an XBM-image-sized buffer
3041 * image.c (xbm_load): Free the image buffer after using it.
3042
3043 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 Port to Sun C.
3046 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3047 that Sun C diagnosed.
3048 * fns.c (secure_hash): Fix pointer signedness issue.
3049 * intervals.c (static_offset_intervals): New function.
3050 (offset_intervals): Use it.
3051
3052 2011-06-21 Leo Liu <sdl.web@gmail.com>
3053
3054 * deps.mk (fns.o):
3055 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3056 sha512.h.
3057
3058 * fns.c (secure_hash): Rename from crypto_hash_function and change
3059 the first arg to accept symbols.
3060 (Fsecure_hash): New primitive.
3061 (syms_of_fns): New symbols.
3062
3063 2011-06-20 Deniz Dogan <deniz@dogan.se>
3064
3065 * process.c (Fset_process_buffer): Clarify return value in
3066 docstring.
3067
3068 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3069
3070 * dispnew.c (add_window_display_history): Use BVAR.
3071
3072 * xdisp.c (debug_method_add): Use BVAR.
3073 (check_window_end, dump_glyph_matrix, dump_glyph)
3074 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3075
3076 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3077 Likewise.
3078
3079 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3080 check till after the cache is created in init_frame_faces.
3081
3082 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3083
3084 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3085
3086 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3087
3088 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3089 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3090 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3091
3092 Improve buffer-overflow checking (Bug#8873).
3093 * fileio.c (Finsert_file_contents):
3094 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3095 Remove the old (too-loose) buffer overflow checks.
3096 They weren't needed, since make_gap checks for buffer overflow.
3097 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3098 The old code merely checked for Emacs fixnum overflow, and relied
3099 on undefined (wraparound) behavior. The new code avoids undefined
3100 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3101
3102 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3103 Tune. Don't use wider integers than needed. Don't use alloca.
3104 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3105
3106 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3107
3108 * insdel.c, lisp.h (buffer_overflow): New function.
3109 (insert_from_buffer_1, replace_range, replace_range_2):
3110 * insdel.c (make_gap_larger):
3111 * editfns.c (Finsert_char):
3112 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3113
3114 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3115
3116 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3117
3118 Integer overflow and signedness fixes (Bug#8873).
3119
3120 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3121 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3122
3123 * fileio.c: Don't assume EMACS_INT fits in off_t.
3124 (emacs_lseek): New static function.
3125 (Finsert_file_contents, Fwrite_region): Use it.
3126 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3127
3128 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3129
3130 * fns.c: Don't overflow int when computing a list length.
3131 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3132 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3133 truncation on 64-bit hosts. Check for QUIT every
3134 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3135 faster and is responsive enough.
3136 (Flength): Report an error instead of overflowing an integer.
3137 (Fsafe_length): Return a float if the value is not representable
3138 as a fixnum. This shouldn't happen except in contrived situations.
3139 (Fnthcdr, Fsort): Don't assume list length fits in int.
3140 (Fcopy_sequence): Don't assume vector length fits in int.
3141
3142 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3143 (header_size, word_size): New constants.
3144 (allocate_vectorlike): Don't check size overflow here.
3145 (allocate_vector): Check it here instead, since this is the only
3146 caller of allocate_vectorlike that could cause overflow.
3147 Check that the new vector's length is representable as a fixnum.
3148
3149 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3150 The previous code was bogus. For example, next_almost_prime (32)
3151 returned 39, which is undesirable as it is a multiple of 3; and
3152 next_almost_prime (24) returned 25, which is a multiple of 5 so
3153 why was the code bothering to check for multiples of 7?
3154
3155 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3156
3157 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3158
3159 Variadic C functions now count arguments with ptrdiff_t.
3160 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3161 Back then I didn't know that the Emacs coding style prefers signed int.
3162 Also, in the meantime I found a few more instances where arguments
3163 were being counted with int, which may truncate counts on 64-bit
3164 machines, or EMACS_INT, which may be unnecessarily wide.
3165 * lisp.h (struct Lisp_Subr.function.aMANY)
3166 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3167 Arg counts are now ptrdiff_t, not size_t.
3168 All variadic functions and their callers changed accordingly.
3169 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3170 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3171 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3172 * callint.c (Fcall_interactively): Check arg count for overflow,
3173 to avoid potential buffer overrun. Use signed char, not 'int',
3174 for 'varies' array, so that we needn't bother to check its size
3175 calculation for overflow.
3176 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3177 * eval.c (apply_lambda):
3178 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3179 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3180 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3181
3182 * callint.c (Fcall_interactively): Don't use index var as event count.
3183
3184 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3185 * mem-limits.h (SIZE): Remove; no longer used.
3186
3187 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3188
3189 Remove unnecessary casts.
3190 * xterm.c (x_term_init):
3191 * xfns.c (x_set_border_pixel):
3192 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3193 These aren't needed now that we assume ANSI C.
3194
3195 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3196 It's more likely to cause problems (due to unsigned overflow)
3197 than to cure them.
3198
3199 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3200
3201 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3202
3203 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3204
3205 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3206
3207 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3208
3209 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3210
3211 GLYPH_CODE_FACE returns EMACS_INT, not int.
3212 * dispextern.h (merge_faces):
3213 * xfaces.c (merge_faces):
3214 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3215 Don't assume EMACS_INT fits in int.
3216
3217 * character.h (CHAR_VALID_P): Remove unused parameter.
3218 * fontset.c, lisp.h, xdisp.c: All uses changed.
3219
3220 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3221
3222 * fns.c (concat): Minor tuning based on overflow analysis.
3223 This doesn't fix any bugs. Use int to hold character, instead
3224 of constantly refetching from Emacs object. Use XFASTINT, not
3225 XINT, for value known to be a character. Don't bother comparing
3226 a single byte to 0400, as it's always less.
3227
3228 * floatfns.c (Fexpt):
3229 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3230
3231 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3232 for characters.
3233
3234 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3235
3236 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3237 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3238 incorrectly succeed when S was a string, because 4294967386 was
3239 truncated before it was used.
3240
3241 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3242 Otherwise, an out-of-range integer could cause undefined behavior
3243 on a 64-bit host.
3244
3245 * composite.c: Use int, not EMACS_INT, for characters.
3246 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3247 EMACS_INT, for values that are known to be in character range.
3248 This doesn't fix any bugs but is the usual style inside Emacs and
3249 may generate better code on 32-bit machines.
3250
3251 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3252 This is for reasons similar to the recent CHAR_STRING fix.
3253 * charset.c (Fencode_char): Check that character arg is actually
3254 a character. Pass an int to ENCODE_CHAR.
3255 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3256 wider than 'int', as a compile-time check to prevent future regressions
3257 in this area.
3258
3259 * character.c (char_string): Remove unnecessary casts.
3260
3261 Make sure a 64-bit char is never passed to CHAR_STRING.
3262 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3263 by silently ignoring the top 32 bits, allowing some values
3264 that were far too large to be valid characters.
3265 * character.h: Include <verify.h>.
3266 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3267 arguments are no wider than unsigned, as a compile-time check
3268 to prevent future regressions in this area.
3269 * data.c (Faset):
3270 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3271 (Fsubst_char_in_region):
3272 * fns.c (concat):
3273 * xdisp.c (decode_mode_spec_coding):
3274 Adjust to CHAR_STRING's new requirement.
3275 * editfns.c (Finsert_char, Fsubst_char_in_region):
3276 * fns.c (concat): Check that character args are actually
3277 characters. Without this test, these functions did the wrong
3278 thing with wildly out-of-range values on 64-bit hosts.
3279
3280 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3281 These casts should not be needed on 32-bit hosts, either.
3282 * keyboard.c (read_char):
3283 * lread.c (Fload): Remove casts to unsigned.
3284
3285 * lisp.h (UNSIGNED_CMP): New macro.
3286 This fixes comparison bugs on 64-bit hosts.
3287 (ASCII_CHAR_P): Use it.
3288 * casefiddle.c (casify_object):
3289 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3290 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3291 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3292 * dispextern.h (FACE_FROM_ID):
3293 * keyboard.c (read_char): Use UNSIGNED_CMP.
3294
3295 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3296 not to EMACS_INT, to avoid GCC warning.
3297
3298 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3299
3300 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3301 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3302 isn't needed on 32-bit machines.
3303
3304 * buffer.c (Fgenerate_new_buffer_name):
3305 Use EMACS_INT for count, not int.
3306 (advance_to_char_boundary): Return EMACS_INT, not int.
3307
3308 * data.c (Qcompiled_function): Now static.
3309
3310 * window.c (window_body_lines): Now static.
3311
3312 * image.c (gif_load): Rename local to avoid shadowing.
3313
3314 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3315 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3316 * alloc.c (make_save_value): Integer argument is now of type
3317 ptrdiff_t, not int.
3318 (mark_object): Use ptrdiff_t, not int.
3319 * lisp.h (pD): New macro.
3320 * print.c (print_object): Use it.
3321
3322 * alloc.c: Use EMACS_INT, not int, to count objects.
3323 (total_conses, total_markers, total_symbols, total_vector_size)
3324 (total_free_conses, total_free_markers, total_free_symbols)
3325 (total_free_floats, total_floats, total_free_intervals)
3326 (total_intervals, total_strings, total_free_strings):
3327 Now EMACS_INT, not int. All uses changed.
3328 (Fgarbage_collect): Compute overall total using a double, so that
3329 integer overflow is less likely to be a problem. Check for overflow
3330 when converting back to an integer.
3331 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3332 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3333 These were 'int' variables that could overflow on 64-bit hosts;
3334 they were never used, so remove them instead of repairing them.
3335 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3336 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3337 Previously, this ceilinged at INT_MAX, but that doesn't work on
3338 64-bit machines.
3339 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3340
3341 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3342 (allocate_vectorlike): Check for ptrdiff_t overflow.
3343 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3344 when a (possibly-narrower) signed value would do just as well.
3345 We prefer using signed arithmetic, to avoid comparison confusion.
3346
3347 * alloc.c: Catch some string size overflows that we were missing.
3348 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3349 for convenience in STRING_BYTES_MAX.
3350 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3351 The definition here is exact; the one in lisp.h was approximate.
3352 (allocate_string_data): Check for string overflow. This catches
3353 some instances we weren't catching before. Also, it catches
3354 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3355 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3356 and ptrdiff_t and EMACS_INT are both 64 bits.
3357
3358 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3359 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3360 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3361
3362 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3363
3364 * alloc.c (Fmake_string): Check for out-of-range init.
3365
3366 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3367
3368 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3369
3370 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3371
3372 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3373 xg_get_default_scrollbar_width.
3374
3375 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3376 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3377 (style_changed_cb): Call update_theme_scrollbar_width and call
3378 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3379 all frames (Bug#8505).
3380 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3381 Call gtk_window_set_resizable if HAVE_GTK3.
3382 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3383 and height if HAVE_GTK3 (Bug#8505).
3384 (scroll_bar_width_for_theme): New variable.
3385 (update_theme_scrollbar_width): New function.
3386 (xg_get_default_scrollbar_width): Move code to
3387 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3388 (xg_initialize): Call update_theme_scrollbar_width.
3389
3390 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3391
3392 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3393
3394 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3395
3396 * frame.c (make_frame): Call other_buffer_safely instead of
3397 other_buffer.
3398
3399 * window.c (temp_output_buffer_show): Call display_buffer with
3400 second argument Vtemp_buffer_show_specifiers and reset latter
3401 immediately after the call.
3402 (Vtemp_buffer_show_specifiers): New variable.
3403 (auto_window_vscroll_p, next_screen_context_lines)
3404 (Vscroll_preserve_screen_position): Remove leading asterisks from
3405 doc-strings.
3406
3407 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3408
3409 Fix minor problems found by GCC 4.6.0 static checking.
3410 * buffer.c (Qclone_number): Remove for now, as it's unused.
3411 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3412 (record_buffer): Remove unused local.
3413 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3414 (set_frame_buffer_list): Remove; unused.
3415 * frame.h (other_visible_frames): Remove decl.
3416 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3417 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3418 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3419 if HAVE_GPM.
3420 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3421 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3422 Define only if HAVE_GPM.
3423 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3424 (update_hints_inhibit): Remove; never set. All uses removed.
3425 * widgetprv.h (emacsFrameClassRec): Remove decl.
3426 * window.c (delete_deletable_window): Now returns void, since it
3427 wasn't returning anything.
3428 (compare_window_configurations): Remove unused locals.
3429 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3430 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3431 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3432 the same widths as pointers. This follows up on the 2011-05-06 patch.
3433 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3434 * xterm.h: Likewise.
3435 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3436
3437 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3438
3439 * makefile.w32-in: Update dependencies.
3440 (LISP_H): Add lib/intprops.h.
3441
3442 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3443
3444 * image.c (gif_load): Add animation frame delay to the metadata.
3445 (syms_of_image): Use DEFSYM. New symbol `delay'.
3446
3447 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3448
3449 * window.c (delete_deletable_window): Re-add.
3450 (Fset_window_configuration): Rewrite to handle dead buffers and
3451 consequently deletable windows.
3452 (window_tree, Fwindow_tree): Remove. Supply functionality in
3453 window.el.
3454 (compare_window_configurations): Simplify code.
3455
3456 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3457
3458 * image.c (imagemagick_load_image): Fix type mismatch.
3459 (Fimagemagick_types): Likewise.
3460
3461 * window.h (replace_buffer_in_windows): Declare.
3462
3463 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3464
3465 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3466 Qclone_number. Remove external declaration of Qdelete_window.
3467 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3468 code.
3469 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3470 Run Qbuffer_list_update_hook if allowed.
3471 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3472 buffer list implementation.
3473 (other_buffer_safely): New function.
3474 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3475 calls to replace_buffer_in_windows and
3476 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3477 if allowed.
3478 (record_buffer): Inhibit quitting and rewrite using quittable
3479 functions. Run Qbuffer_list_update_hook if allowed.
3480 (Frecord_buffer, Funrecord_buffer): New functions.
3481 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3482 Move switch-to-buffer to window.el.
3483 (bury-buffer): Move to window.el.
3484 (Vbuffer_list_update_hook): New variable.
3485
3486 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3487 section.
3488
3489 * window.h (resize_frame_windows): Move up in code.
3490 (Fwindow_frame): Remove EXFUN.
3491 (replace_buffer_in_all_windows): Remove prototype.
3492 (replace_buffer_in_windows_safely): Add prototype.
3493
3494 * window.c: Declare Qdelete_window static again. Move down
3495 declaration of select_count.
3496 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3497 (Fother_window): Move to window.el.
3498 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3499 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3500 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3501 window.el.
3502 (replace_buffer_in_windows): Implement by calling
3503 Qreplace_buffer_in_windows.
3504 (replace_buffer_in_all_windows): Remove with some functionality
3505 moved into replace_buffer_in_windows_safely.
3506 (replace_buffer_in_windows_safely): New function.
3507 (select_window_norecord, select_frame_norecord): Move in front
3508 of run_window_configuration_change_hook. Remove now obsolete
3509 declarations.
3510 (Fset_window_buffer): Rewrite doc-string.
3511 Call Qrecord_window_buffer.
3512 (keys_of_window): Move binding for other-window to window.el.
3513
3514 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3515
3516 * dispextern.h (struct image): Replace data member, whose int_val
3517 and ptr_val fields were not used by anything, with a single
3518 lisp_val object.
3519
3520 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3521 (gif_clear_image, gif_load, imagemagick_load_image)
3522 (gs_clear_image, gs_load): Callers changed.
3523
3524 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3525
3526 * buffer.h: Include <time.h>, for time_t.
3527 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3528
3529 Fix minor problems found by static checking.
3530
3531 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3532
3533 Make identifiers static if they are not used in other modules.
3534 * data.c (Qcompiled_function, Qframe, Qvector):
3535 * image.c (QimageMagick, Qsvg):
3536 * minibuf.c (Qmetadata):
3537 * window.c (resize_window_check, resize_root_window): Now static.
3538 * window.h (resize_window_check, resize_root_window): Remove decls.
3539
3540 * window.c (window_deletion_count, delete_deletable_window):
3541 Remove; unused.
3542 (window_body_lines): Now static.
3543 (Fdelete_other_windows_internal): Mark vars as initialized.
3544 Make sure 'resize_failed' is initialized.
3545 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3546 (resize_window_apply): Remove unused local.
3547 * window.h (delete_deletable_window): Remove decl.
3548
3549 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3550 (imagemagick_load_image): Fix pointer signedness problem by changing
3551 last arg from unsigned char * to char *. All uses changed.
3552 Also, fix a local for similar reasons.
3553 Remove unused locals. Remove locals to avoid shadowing.
3554 (fn_rsvg_handle_free): Remove; unused.
3555 (svg_load, svg_load_image): Fix pointer signedness problem.
3556 (imagemagick_load_image): Don't use garbage pointer image_wand.
3557
3558 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3559
3560 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3561
3562 * image.c (gif_load): Fix omitted cast error introduced by
3563 2011-06-06 change.
3564
3565 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3566
3567 * window.h (resize_proportionally, orig_total_lines)
3568 (orig_top_line): Remove from window structure.
3569 (set_window_height, set_window_width, change_window_heights)
3570 (Fdelete_window): Remove prototypes.
3571 (resize_frame_windows): Remove duplicate declaration.
3572
3573 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3574
3575 * window.h (resize_frame_windows, resize_window_check)
3576 (delete_deletable_window, resize_root_window)
3577 (resize_frame_windows): Declare prototypes.
3578
3579 * window.c (resize_window_apply): Make definition be "static" to
3580 match the prototype.
3581
3582 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3583
3584 * window.c: Remove declarations of Qwindow_size_fixed,
3585 window_min_size_1, window_min_size_2, window_min_size,
3586 size_window, window_fixed_size_p, enlarge_window, delete_window.
3587 Remove static from declaration of Qdelete_window, it's
3588 temporarily needed by Fbury_buffer.
3589 (replace_window): Don't assign orig_top_line and
3590 orig_total_lines.
3591 (Fdelete_window, delete_window): Remove. Window deletion is
3592 handled by window.el.
3593 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3594 Replace Fdelete_window calls with calls to Qdelete_window.
3595 (Fdelete_other_windows): Remove. Deleting other windows is
3596 handled by window.el.
3597 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3598 handled in window.el.
3599 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3600 Window minimum sizes are handled in window.el.
3601 (shrink_windows, size_window, set_window_height)
3602 (set_window_width, change_window_heights, window_height)
3603 (window_width, CURBEG, CURSIZE, enlarge_window)
3604 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3605 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3606 handled in window.el.
3607 (make_dummy_parent): Rename to make_parent_window and give it a
3608 second argument horflag.
3609 (make_window): Don't set resize_proportionally any more.
3610 (Fsplit_window): Remove. Windows are split in window.el.
3611 (save_restore_action, save_restore_orig_size)
3612 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3613 Resize mini windows in window.el.
3614 (grow_mini_window, shrink_mini_window): Implement by calling
3615 Qresize_root_window_vertically, resize_window_check and
3616 resize_window_apply.
3617 (saved_window, Fset_window_configuration, save_window_save):
3618 Do not handle orig_top_line, orig_total_lines, and
3619 resize_proportionally.
3620 (window_min_height, window_min_width): Move to window.el.
3621 (keys_of_window): Move bindings for delete-other-windows,
3622 split-window, delete-window and enlarge-window to window.el.
3623
3624 * buffer.c: Temporarily extern Qdelete_window.
3625 (Fbury_buffer): Temporarily call Qdelete_window instead of
3626 Fdelete_window (Fbury_buffer will move to window.el soon).
3627
3628 * frame.c (set_menu_bar_lines_1): Remove code handling
3629 orig_top_line and orig_total_lines.
3630
3631 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3632 set_window_height but set heights directly.
3633 (change_frame_size_1): Use resize_frame_windows.
3634
3635 * xdisp.c (init_xdisp): Don't use set_window_height but set
3636 heights directly.
3637
3638 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3639 Use resize_frame_windows instead of change_window_heights and run
3640 run_window_configuration_change_hook.
3641
3642 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3643 instead of change_window_heights and run
3644 run_window_configuration_change_hook.
3645
3646 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3647
3648 * window.c (replace_window): Rename second argument REPLACEMENT to
3649 NEW. New third argument SETFLAG. Rewrite.
3650 (delete_window, make_dummy_parent): Call replace_window with
3651 third argument 1.
3652 (window_list_1): Move down in code.
3653 (run_window_configuration_change_hook): Move set_buffer part
3654 before select_frame_norecord part in order to unwind correctly.
3655 Rename count1 to count.
3656 (recombine_windows, delete_deletable_window, resize_root_window)
3657 (Fdelete_other_windows_internal)
3658 (Frun_window_configuration_change_hook, make_parent_window)
3659 (resize_window_check, resize_window_apply, Fresize_window_apply)
3660 (resize_frame_windows, Fsplit_window_internal)
3661 (Fdelete_window_internal, Fresize_mini_window_internal):
3662 New functions.
3663 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3664
3665 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3666
3667 * window.h (window): Add some new members to window structure -
3668 normal_lines, normal_cols, new_total, new_normal, clone_number,
3669 splits, nest, prev_buffers, next_buffers.
3670 (WINDOW_TOTAL_SIZE): Move here from window.c.
3671 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3672
3673 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3674 Remove.
3675 (make_dummy_parent): Set new members of windows structure.
3676 (make_window): Move down in code. Handle new members of window
3677 structure.
3678 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3679 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3680 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3681 (Fset_window_prev_buffers, Fwindow_next_buffers)
3682 (Fset_window_next_buffers, Fset_window_clone_number):
3683 New functions.
3684 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3685 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3686 Doc-string fixes.
3687 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3688 Argument WINDOW can be now internal window too.
3689 (Fwindow_use_time): Move up in code.
3690 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3691 Rewrite doc-string.
3692 (Fset_window_configuration, saved_window)
3693 (Fcurrent_window_configuration, save_window_save): Handle new
3694 members of window structure.
3695 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3696 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3697 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3698 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3699 Qget_mru_window, Qresize_root_window,
3700 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3701 Qauto_buffer_name; staticpro them.
3702
3703 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3704
3705 * window.c (Fwindow_total_size, Fwindow_left_column)
3706 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3707 (Fwindow_list_1): New functions.
3708 (window_box_text_cols): Replace with window_body_cols.
3709 (Fwindow_width, Fscroll_left, Fscroll_right):
3710 Use window_body_cols instead of window_box_text_cols.
3711 (delete_window, Fset_window_configuration):
3712 Call delete_all_subwindows with window as argument.
3713 (delete_all_subwindows): Take a window as argument and not a
3714 structure. Rewrite.
3715 (window_loop): Remove handling of GET_LRU_WINDOW and
3716 GET_LARGEST_WINDOW.
3717 (Fget_lru_window, Fget_largest_window): Move to window.el.
3718
3719 * window.h: Extern window_body_cols instead of
3720 window_box_text_cols. delete_all_subwindows now takes a
3721 Lisp_Object as argument.
3722
3723 * indent.c (compute_motion, Fcompute_motion):
3724 Use window_body_cols instead of window_box_text_cols.
3725
3726 * frame.c (delete_frame): Call delete_all_subwindows with root
3727 window as argument.
3728
3729 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3730
3731 * fns.c (Fputhash): Document return value.
3732
3733 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3734
3735 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3736
3737 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3738
3739 Cons<->int and similar integer overflow fixes (Bug#8794).
3740
3741 Check for overflow when converting integer to cons and back.
3742 * charset.c (Fdefine_charset_internal, Fdecode_char):
3743 Use cons_to_unsigned to catch overflow.
3744 (Fencode_char): Use INTEGER_TO_CONS.
3745 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3746 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3747 * data.c (long_to_cons, cons_to_long): Remove.
3748 (cons_to_unsigned, cons_to_signed): New functions.
3749 These signal an error for invalid or out-of-range values.
3750 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3751 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3752 * font.c (Ffont_variation_glyphs):
3753 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3754 * lisp.h: Include <intprops.h>.
3755 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3756 (cons_to_signed, cons_to_unsigned): New decls.
3757 (long_to_cons, cons_to_long): Remove decls.
3758 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3759 (Fprimitive_undo): Use CONS_TO_INTEGER.
3760 * xfns.c (Fx_window_property): Likewise.
3761 * xselect.c: Include <limits.h>.
3762 (x_own_selection, selection_data_to_lisp_data):
3763 Use INTEGER_TO_CONS.
3764 (x_handle_selection_request, x_handle_selection_clear)
3765 (x_get_foreign_selection, Fx_disown_selection_internal)
3766 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3767 (lisp_data_to_selection_data): Use cons_to_unsigned.
3768 (x_fill_property_data): Use cons_to_signed.
3769 Report values out of range.
3770
3771 Check for buffer and string overflow more precisely.
3772 * buffer.h (BUF_BYTES_MAX): New macro.
3773 * lisp.h (STRING_BYTES_MAX): New macro.
3774 * alloc.c (Fmake_string):
3775 * character.c (string_escape_byte8):
3776 * coding.c (coding_alloc_by_realloc):
3777 * doprnt.c (doprnt):
3778 * editfns.c (Fformat):
3779 * eval.c (verror):
3780 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3781 since they may not be the same number.
3782 * editfns.c (Finsert_char):
3783 * fileio.c (Finsert_file_contents):
3784 Likewise for BUF_BYTES_MAX.
3785
3786 * image.c: Use ptrdiff_t, not int, for sizes.
3787 (slurp_file): Switch from int to ptrdiff_t.
3788 All uses changed.
3789 (slurp_file): Check that file size fits in both size_t (for
3790 malloc) and ptrdiff_t (for sanity and safety).
3791
3792 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3793 if b->modtime has its maximal value.
3794
3795 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3796
3797 Don't assume time_t can fit into int.
3798 * buffer.h (struct buffer.modtime): Now time_t, not int.
3799 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3800 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3801
3802 Minor fixes for signed vs unsigned integers.
3803 * character.h (MAYBE_UNIFY_CHAR):
3804 * charset.c (maybe_unify_char):
3805 * keyboard.c (read_char, reorder_modifiers):
3806 XINT -> XFASTINT, since the integer must be nonnegative.
3807 * ftfont.c (ftfont_spec_pattern):
3808 * keymap.c (access_keymap, silly_event_symbol_error):
3809 XUINT -> XFASTINT, since the integer must be nonnegative.
3810 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3811 since it makes no difference and we prefer signed.
3812 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3813 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3814 nonnegative.
3815
3816 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3817
3818 * window.h (Fwindow_frame): Declare.
3819
3820 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3821
3822 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3823 (SPARE_MEMORY): Always define.
3824 (LARGE_REQUEST): Remove.
3825 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3826
3827 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3828
3829 * lisp.h: Move EXFUNS for Fframe_root_window,
3830 Fframe_first_window and Fset_frame_selected_window to window.h.
3831
3832 * window.h: Move EXFUNS for Fframe_root_window,
3833 Fframe_first_window and Fset_frame_selected_window here from
3834 lisp.h.
3835
3836 * frame.c (Fwindow_frame, Fframe_first_window)
3837 (Fframe_root_window, Fframe_selected_window)
3838 (Fset_frame_selected_window): Move to window.c.
3839 (Factive_minibuffer_window): Move to minibuf.c.
3840 (Fother_visible_frames_p): New function.
3841
3842 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3843
3844 * window.c (decode_window, decode_any_window): Move up in code.
3845 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3846 (inhibit_frame_unsplittable): Remove unused variable.
3847 (Fwindow_buffer): Move up and rewrite doc-string.
3848 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3849 (Fwindow_prev): New functions.
3850 (Fwindow_frame): Move here from frame.c. Accept any window as
3851 argument.
3852 (Fframe_root_window, Fframe_first_window)
3853 (Fframe_selected_window): Move here from frame.c. Accept frame
3854 or arbitrary window as argument. Update doc-strings.
3855 (Fminibuffer_window): Move up in code.
3856 (Fwindow_minibuffer_p): Move up in code and simplify.
3857 (Fset_frame_selected_window): Move here from frame.c.
3858 Marginal rewrite.
3859 (Fselected_window, select_window, Fselect_window): Move up in
3860 code. Minor doc-string fixes.
3861
3862 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3863
3864 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3865 Do not assume that spare memory exists; that assumption is valid
3866 only if SYSTEM_MALLOC.
3867 (LARGE_REQUEST): New macro, so that the issue of large requests
3868 is separated from the issue of spare memory.
3869
3870 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3871
3872 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3873 format. (Bug#8806)
3874
3875 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3876
3877 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3878 before statements.
3879
3880 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3881
3882 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3883
3884 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3885
3886 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3887 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3888
3889 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3890
3891 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3892
3893 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3894
3895 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3896 (x_clipboard_manager_save): Add return value.
3897 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3898 New error handlers.
3899 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3900 Obey Vx_select_enable_clipboard_manager. Catch errors in
3901 x_clipboard_manager_save (Bug#8779).
3902 (Vx_select_enable_clipboard_manager): New variable.
3903 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3904
3905 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3906
3907 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3908
3909 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3910
3911 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3912 in the current matrix if keep_current_p is non-zero.
3913
3914 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3915
3916 * bidi.c (bidi_level_of_next_char): Fix last change.
3917
3918 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3919
3920 Support bidi reordering of text covered by display properties.
3921
3922 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3923 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3924 (bidi_cache_search, bidi_cache_iterator_state)
3925 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3926 (bidi_level_of_next_char, bidi_move_to_visually_next):
3927 Support character positions inside a run of characters covered by a
3928 display string.
3929 (bidi_paragraph_init, bidi_resolve_explicit_1)
3930 (bidi_level_of_next_char): Call bidi_fetch_char and
3931 bidi_fetch_char_advance instead of FETCH_CHAR and
3932 FETCH_CHAR_ADVANCE.
3933 (bidi_init_it): Initialize new members.
3934 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3935 definitions.
3936 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3937 instead of using explicit *_CHAR codes.
3938 (bidi_resolve_explicit, bidi_resolve_weak):
3939 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3940 bidirectional text is supported only in multibyte buffers.
3941 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3942 it to initialize the frame_window_p member of struct bidi_it.
3943 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3944 (bidi_resolve_explicit, bidi_resolve_weak)
3945 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3946 bidi_it->nchars is non-positive.
3947 (bidi_level_of_next_char): Don't try to lookup the cache for the
3948 next/previous character if nothing is cached there yet, or if we
3949 were just reseat()'ed to a new position.
3950
3951 * xdisp.c (set_cursor_from_row): Set start and stop points
3952 according to the row's direction when priming the loop that looks
3953 for the glyph on which to display cursor.
3954 (single_display_spec_intangible_p): Function deleted.
3955 (display_prop_intangible_p): Reimplement to call
3956 handle_display_spec instead of single_display_spec_intangible_p.
3957 Accept 3 additional arguments needed by handle_display_spec.
3958 This fixes incorrect cursor motion across display property with complex
3959 values: lists, `(when COND...)' forms, etc.
3960 (single_display_spec_string_p): Support property values that are
3961 lists with the argument STRING its top-level element.
3962 (display_prop_string_p): Fix the condition for processing a
3963 property that is a list to be consistent with handle_display_spec.
3964 (handle_display_spec): New function, refactored from the
3965 last portion of handle_display_prop.
3966 (compute_display_string_pos): Accept additional argument
3967 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3968 value of a `display' property is a "replacing spec".
3969 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3970 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3971 the display property, but just return a value indicating whether
3972 the display property will replace the characters it covers.
3973 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3974 frame_window_p members of struct bidi_it.
3975 (compute_display_string_pos, compute_display_string_end):
3976 New functions.
3977 (push_it): Accept second argument POSITION, where pop_it should
3978 jump to continue iteration.
3979 (reseat_1): Initialize bidi_it.disp_pos.
3980
3981 * keyboard.c (adjust_point_for_property): Adjust the call to
3982 display_prop_intangible_p to its new signature.
3983
3984 * dispextern.h (struct bidi_it): New member frame_window_p.
3985 (bidi_init_it): Update prototypes.
3986 (display_prop_intangible_p): Update prototype.
3987 (compute_display_string_pos, compute_display_string_end):
3988 Declare prototypes.
3989 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3990 EMACS_INT.
3991
3992 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3993
3994 Malloc failure behavior now depends on size of allocation.
3995 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3996 * lisp.h: Change signatures accordingly.
3997 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3998 All callers changed. (Bug#8762)
3999
4000 * gnutls.c: Use Emacs's memory allocators.
4001 Without this change, the gnutls library would invoke malloc etc.
4002 directly, which causes problems on non-SYNC_INPUT hosts, and which
4003 runs afoul of improving memory_full behavior. (Bug#8761)
4004 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4005 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4006 xfree instead of the default malloc, realloc, free.
4007 (Fgnutls_boot): No need to check for memory allocation failure,
4008 since xmalloc does that for us.
4009
4010 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4011 * category.c (hash_get_category_set):
4012 * ccl.c (ccl_driver):
4013 * charset.c (Fdefine_charset_internal):
4014 * charset.h (struct charset.hash_index):
4015 * composite.c (get_composition_id, gstring_lookup_cache)
4016 (composition_gstring_put_cache):
4017 * composite.h (struct composition.hash_index):
4018 * dispextern.h (struct image.hash):
4019 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4020 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4021 (hashfn_equal, hashfn_user_defined, make_hash_table)
4022 (maybe_resize_hash_table, hash_lookup, hash_put)
4023 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4024 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4025 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4026 * image.c (make_image, search_image_cache, lookup_image)
4027 (xpm_put_color_table_h):
4028 * lisp.h (struct Lisp_Hash_Table):
4029 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4030 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4031 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4032 * alloc.c (allocate_vectorlike):
4033 Check for overflow in vector size calculations.
4034 * ccl.c (ccl_driver):
4035 Check for overflow when converting EMACS_INT to int.
4036 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4037 need to be updated by these changes.
4038 * fns.c (make_hash_table, maybe_resize_hash_table):
4039 Check for integer overflow with large hash tables.
4040 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4041 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4042 (SXHASH_REDUCE): New macro.
4043 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4044 Use it instead of discarding useful hash info with large hash values.
4045 (sxhash_float): New function.
4046 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4047 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4048 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4049 Rewrite to use FIXNUM_BITS, as this simplifies things.
4050 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4051 Adjust signatures to match updated version of code.
4052 (consing_since_gc): Now EMACS_INT, since a single hash table can
4053 use more than INT_MAX bytes.
4054
4055 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4056
4057 Make it possible to build with GCC-4.6+ -O2 -flto.
4058
4059 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4060
4061 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4062
4063 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4064 Call minibuffer-inactive-mode.
4065
4066 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4067
4068 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4069 Update dependencies.
4070
4071 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4072
4073 * data.c (init_data): Remove code for UTS, this system is not
4074 supported anymore.
4075
4076 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4077
4078 Don't force ./temacs to start in terminal mode.
4079
4080 * frame.c (make_initial_frame): Initialize faces in all cases, not
4081 only when CANNOT_DUMP is defined.
4082 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4083
4084 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4085
4086 * dispnew.c (add_window_display_history): Use const for the string
4087 pointer. Remove declaration, not needed.
4088
4089 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4090
4091 Use 'inline', not 'INLINE'.
4092 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4093 * alloc.c, fontset.c (INLINE): Remove.
4094 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4095 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4096 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4097 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4098 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4099
4100 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4101
4102 Make it possible to run ./temacs.
4103
4104 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4105 syms_of_callproc does the same thing. Remove test for
4106 "initialized", do it in the caller.
4107 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4108
4109 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4110
4111 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4112 (read_minibuf): Use get_minibuffer.
4113 (syms_of_minibuf): Use DEFSYM.
4114 (Qmetadata): New var.
4115 * data.c (Qbuffer): Don't make it static.
4116 (syms_of_data): Use DEFSYM.
4117
4118 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4119
4120 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4121 (CCL_CODE_MIN): New macro.
4122
4123 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4124
4125 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4126
4127 * eval.c (Qdebug): Now static.
4128 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4129 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4130 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4131
4132 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4133
4134 * image.c: Various fixes to ImageMagick code comments.
4135 (Fimagemagick_types): Doc fix.
4136
4137 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4138
4139 Minor fixes prompted by GCC 4.6.0 warnings.
4140
4141 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4142
4143 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4144 (x_clipboard_manager_save_all): Move extern decl to ...
4145 * xterm.h: ... here, so that it can be checked for consistency.
4146
4147 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4148
4149 * xselect.c (x_clipboard_manager_save_frame)
4150 (x_clipboard_manager_save_all): New functions.
4151 (Fx_clipboard_manager_save): Lisp function deleted.
4152
4153 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4154 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4155
4156 * xterm.h: Update prototype.
4157
4158 2011-05-28 William Xu <william.xwl@gmail.com>
4159
4160 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4161 exiting (Bug#8239).
4162
4163 2011-05-28 Jim Meyering <meyering@redhat.com>
4164
4165 Avoid a sign-extension bug in crypto_hash_function.
4166 * fns.c (to_uchar): Define.
4167 (crypto_hash_function): Use it to convert some newly-signed
4168 variables to unsigned, to avoid sign-extension bugs. For example,
4169 without this change, (md5 "truc") would evaluate to
4170 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4171 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4172 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4173
4174 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4175
4176 Integer overflow fixes.
4177
4178 * dbusbind.c: Serial number integer overflow fixes.
4179 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4180 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4181 to hold a serial number that is too large for a fixnum.
4182 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4183 Check for serial numbers out of range. Decode any serial number
4184 that was so large that it became a float. (Bug#8722)
4185
4186 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4187 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4188 Use XFASTINT rather than XUINT when numbers are nonnegative.
4189 (xd_append_arg, Fdbus_method_return_internal):
4190 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4191 arguments, check that Lisp number is nonnegative, rather than
4192 silently wrapping negative numbers around. (Bug#8722)
4193 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4194 (Bug#8722)
4195
4196 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4197
4198 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4199
4200 ccl: add integer overflow checks
4201 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4202 (IN_INT_RANGE): New macros.
4203 (ccl_driver): Use them to check for integer overflow when
4204 decoding a CCL program. Many of the new checks are whether XINT (x)
4205 fits in int; it doesn't always, on 64-bit hosts. The new version
4206 doesn't catch all possible integer overflows, but it's an
4207 improvement. (Bug#8719)
4208
4209 * alloc.c (make_event_array): Use XINT, not XUINT.
4210 There's no need for unsigned here.
4211
4212 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4213 This follows up to the 2011-05-06 change that substituted uintptr_t
4214 for EMACS_INT. This case wasn't caught back then.
4215
4216 Rework Fformat to avoid integer overflow issues.
4217 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4218 now (part of C89). Include <verify.h>.
4219 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4220 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4221 (Fformat): Avoid the prepass trying to compute sizes; it was only
4222 approximate and thus did not catch overflow reliably. Instead, walk
4223 through the format just once, formatting and computing sizes as we go,
4224 checking for integer overflow at every step, and allocating a larger
4225 buffer as needed. Keep track separately whether the format is
4226 multibyte. Keep only the most-recently calculated precision, rather
4227 than them all. Record whether each argument has been converted to
4228 string. Use EMACS_INT, not int, for byte and char and arg counts.
4229 Support field widths and precisions larger than INT_MAX. Avoid
4230 sprintf's undefined behavior with conversion specifications such as %#d
4231 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4232 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4233 formatting out-of-range floating point numbers with int
4234 formats. (Bug#8668)
4235
4236 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4237
4238 * data.c: Avoid integer truncation in expressions involving floats.
4239 * data.c: Include <intprops.h>.
4240 (arith_driver): When there's an integer overflow in an expression
4241 involving floating point, convert the integers to floating point
4242 so that the resulting value does not suffer from catastrophic
4243 integer truncation. For example, on a 64-bit host (* 4
4244 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4245 Do not rely on undefined behavior after integer overflow.
4246
4247 merge count_size_as_multibyte, parse_str_to_multibyte
4248 * character.c, character.h (count_size_as_multibyte):
4249 Rename from parse_str_to_multibyte; all uses changed.
4250 Check for integer overflow.
4251 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4252 since it's now a duplicate of the other. This is more of
4253 a character than a buffer op, so better that it's in character.c.
4254 * fns.c, print.c: Adjust to above changes.
4255
4256 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4257
4258 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4259
4260 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4261
4262 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4263 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4264 (x_clipboard_manager_save): Now static.
4265 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4266
4267 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4268 (crypto_hash_function): Now static.
4269 Fix pointer signedness problems. Avoid unnecessary initializations.
4270
4271 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4272
4273 * termhooks.h (Vselection_alist): Make it terminal-local.
4274
4275 * terminal.c (create_terminal): Initialize it.
4276
4277 * xselect.c: Support for clipboard managers.
4278 (Vselection_alist): Move to termhooks.h as terminal-local var.
4279 (LOCAL_SELECTION): New macro.
4280 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4281 (symbol_to_x_atom): Remove gratuitous arg.
4282 (x_handle_selection_request, lisp_data_to_selection_data)
4283 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4284 (x_own_selection, x_get_local_selection, x_convert_selection):
4285 New arg, specifying work frame. Use terminal-local Vselection_alist.
4286 (some_frame_on_display): Delete unused function.
4287 (Fx_own_selection_internal, Fx_get_selection_internal)
4288 (Fx_disown_selection_internal, Fx_selection_owner_p)
4289 (Fx_selection_exists_p): New optional frame arg.
4290 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4291 (x_handle_selection_clear): Don't treat other terminals with the
4292 same keyboard specially. Use the terminal-local Vselection_alist.
4293 (x_clear_frame_selections): Use Frun_hook_with_args.
4294
4295 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4296
4297 * xterm.h: Add support for those atoms.
4298
4299 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4300
4301 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4302 (converted_selections, conversion_fail_tag): New global variables.
4303 (x_selection_request_lisp_error): Free the above.
4304 (x_get_local_selection): Remove unnecessary code.
4305 (x_reply_selection_request): Args changed; handle arbitrary array
4306 of converted selections stored in converted_selections.
4307 Separate the XChangeProperty and SelectionNotify steps.
4308 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4309 (x_convert_selection): New function.
4310 (x_handle_selection_event): Simplify.
4311 (x_get_foreign_selection): Don't ignore incoming requests while
4312 waiting for an answer; this will fail when we implement
4313 SAVE_TARGETS, and seems unnecessary anyway.
4314 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4315 (Vx_sent_selection_functions): Doc fix.
4316
4317 2011-05-26 Leo Liu <sdl.web@gmail.com>
4318
4319 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4320
4321 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4322
4323 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4324
4325 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4326 for fringe update if it has periodic bitmap.
4327 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4328 and fringe_bitmap_periodic_p.
4329
4330 * fringe.c (get_fringe_bitmap_data): New function.
4331 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4332 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4333 row. Mark glyph row for fringe update if periodicity changed.
4334
4335 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4336 for fringe update unless it has periodic bitmap.
4337
4338 2011-05-25 Kenichi Handa <handa@m17n.org>
4339
4340 * xdisp.c (get_next_display_element): Set correct it->face_id for
4341 a static composition.
4342
4343 2011-05-24 Leo Liu <sdl.web@gmail.com>
4344
4345 * deps.mk (fns.o):
4346 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4347
4348 * fns.c (crypto_hash_function, Fsha1): New function.
4349 (Fmd5): Use crypto_hash_function.
4350 (syms_of_fns): Add Ssha1.
4351
4352 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4353
4354 * gnutls.c: Remove unused macros.
4355 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4356 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4357 Remove macros that are defined and never used.
4358 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4359
4360 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4361
4362 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4363 (Fx_get_selection_internal): Minor cleanup.
4364 (Fx_own_selection_internal): Rename arguments for consistency with
4365 select.el.
4366
4367 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4368
4369 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4370
4371 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4372
4373 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4374
4375 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4376
4377 * dispnew.c (scrolling_window): Don't exclude the case that the
4378 last enabled row in the desired matrix touches the bottom boundary.
4379
4380 2011-05-21 Glenn Morris <rgm@gnu.org>
4381
4382 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4383 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4384 and add some more files.
4385
4386 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4387
4388 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4389 report_file_error introduced by the change from 2011-05-07.
4390
4391 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4392
4393 * systime.h (Time): Define only if emacs is defined.
4394 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4395 where the include path doesn't have X11/X.h by default. See
4396 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4397
4398 2011-05-20 Kenichi Handa <handa@m17n.org>
4399
4400 * composite.c (find_automatic_composition): Fix previous change.
4401
4402 2011-05-20 Glenn Morris <rgm@gnu.org>
4403
4404 * lisp.mk: New file, split from Makefile.in.
4405 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4406 (shortlisp): Remove.
4407 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4408
4409 2011-05-19 Glenn Morris <rgm@gnu.org>
4410
4411 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4412 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4413 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4414 (lisp): Set the order to that of loadup.el.
4415 (shortlisp): Make it a copy of $lisp.
4416 (SOME_MACHINE_LISP): Remove.
4417 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4418 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4419
4420 2011-05-18 Kenichi Handa <handa@m17n.org>
4421
4422 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4423 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4424 (find_automatic_composition): Mostly rewrite for efficiency.
4425
4426 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4427
4428 * makefile.w32-in: Update dependencies.
4429
4430 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4431
4432 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4433 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4434
4435 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4436
4437 Fix some integer overflow issues, such as string length overflow.
4438
4439 * insdel.c (count_size_as_multibyte): Check for string overflow.
4440
4441 * character.c (lisp_string_width): Check for string overflow.
4442 Use EMACS_INT, not int, for string indexes and lengths; in
4443 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4444 the resulting string length overflows an EMACS_INT; instead,
4445 report a string overflow if no precision given. When checking for
4446 precision exhaustion, use a check that cannot possibly have
4447 integer overflow. (Bug#8675)
4448 * character.h (lisp_string_width): Adjust to new signature.
4449
4450 * alloc.c (string_overflow): New function.
4451 (Fmake_string): Use it. This doesn't change behavior, but saves
4452 a few bytes and will simplify future changes.
4453 * character.c (string_escape_byte8): Likewise.
4454 * lisp.h (string_overflow): New decl.
4455
4456 Fixups, following up to the user-interface timestamp change.
4457 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4458 for UI timestamps, instead of unsigned long.
4459 * msdos.c (mouse_get_pos): Likewise.
4460 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4461 * w32gui.h (Time): Define by including "systime.h" rather than by
4462 declaring it ourselves. (Bug#8664)
4463
4464 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4465 * image.c (clear_image_cache): Likewise.
4466
4467 * term.c (term_mouse_position): Don't assume time_t wraparound.
4468
4469 Be more systematic about user-interface timestamps.
4470 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4471 and sometimes 'EMACS_UINT', to represent these timestamps.
4472 This change causes it to use 'Time' uniformly, as that's what X uses.
4473 This makes the code easier to follow, and makes it easier to catch
4474 integer overflow bugs such as Bug#8664.
4475 * frame.c (Fmouse_position, Fmouse_pixel_position):
4476 Use Time, not unsigned long, for user-interface timestamps.
4477 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4478 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4479 * keyboard.h (last_event_timestamp): Likewise.
4480 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4481 * menu.h (xmenu_show): Likewise.
4482 * term.c (term_mouse_position): Likewise.
4483 * termhooks.h (struct input_event.timestamp): Likewise.
4484 (struct terminal.mouse_position_hook): Likewise.
4485 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4486 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4487 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4488 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4489 what it was before.
4490 * menu.h, termhooks.h: Include "systime.h", for Time.
4491
4492 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4493 Don't assume that the difference between two unsigned long values
4494 can fit into an integer. At this point, we know button_down_time
4495 <= event->timestamp, so the difference must be nonnegative, so
4496 there's no need to cast the result if double-click-time is
4497 nonnegative, as it should be; check that it's nonnegative, just in
4498 case. This bug is triggered when events are more than 2**31 ms
4499 apart (about 25 days). (Bug#8664)
4500
4501 * xselect.c (last_event_timestamp): Remove duplicate decl.
4502 (x_own_selection): Remove needless cast to unsigned long.
4503
4504 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4505 that always fit in int. Use a sentinel instead of a counter, to
4506 avoid a temp and to allay GCC's concerns about possible int overflow.
4507 * frame.h (struct frame): Use int for menu_bar_items_used
4508 instead of EMACS_INT, since it always fits in int.
4509
4510 * menu.c (grow_menu_items): Check for int overflow.
4511
4512 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4513
4514 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4515 Before, the code was not consistent. These values cannot exceed
4516 2**31 - 1 so there's no need to make them unsigned.
4517 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4518 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4519 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4520 as modifiers.
4521 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4522
4523 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4524 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4525 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4526 presumably because the widths might not match.
4527
4528 * window.c (size_window): Avoid needless test at loop start.
4529
4530 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4531
4532 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4533
4534 2011-05-12 Drew Adams <drew.adams@oracle.com>
4535
4536 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4537
4538 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4539
4540 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4541 `width' to `bar_area_x' and `bar_area_width', respectively.
4542 (x_scroll_run): Take account of fringe background extension.
4543
4544 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4545 Rename local vars `left' and `width' to `bar_area_x' and
4546 `bar_area_width', respectively.
4547 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4548 background extension.
4549
4550 2011-05-10 Jim Meyering <meyering@redhat.com>
4551
4552 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4553
4554 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4555
4556 * image.c (Finit_image_library): Return t for built-in image types,
4557 like pbm and xbm. (Bug#8640)
4558
4559 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4560
4561 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4562
4563 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4564
4565 * w32console.c (Fset_screen_color): Doc fix.
4566 (Fget_screen_color): New function.
4567 (syms_of_ntterm): Defsubr it.
4568
4569 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4570 unlink the temporary file if Fcall_process didn't create it in the
4571 first place.
4572 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4573 child process will be redirected to a file specified with `:file'.
4574 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4575 cue to call_process_cleanup not to close that handle.
4576
4577 2011-05-07 Ben Key <bkey76@gmail.com>
4578
4579 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4580 one of two shell specific rules, either bootstrap-temacs-CMD or
4581 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4582 to the previous implementation of the bootstrap-temacs rule.
4583 The bootstrap-temacs-CMD rule is similar to the previous
4584 implementation of the bootstrap-temacs rule except that it
4585 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4586 variable.
4587
4588 These changes, along with some changes to nt/configure.bat,
4589 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4590 earlier fix to add support for --cflags and --ldflags options
4591 that include quotes so that it works whether make uses cmd or
4592 sh as the shell.
4593
4594 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4595
4596 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4597 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4598 is a constant.
4599 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4600 a string. Handle both cases.
4601 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4602 (Fdbus_register_method): Use Qinvalid_function.
4603
4604 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4605
4606 * makefile.w32-in: Update dependencies.
4607 (LISP_H): Add inttypes.h and stdin.h.
4608 (PROCESS_H): Add unistd.h.
4609
4610 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4611
4612 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4613 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4614
4615 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4616
4617 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4618
4619 * term.c (vfatal): Remove stray call to va_end.
4620 It's not needed and the C Standard doesn't allow it here anyway.
4621
4622 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4623 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4624
4625 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4626 bytes.
4627
4628 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4629
4630 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4631
4632 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4633
4634 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4635
4636 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4637
4638 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4639 * charset.c (Fdefine_charset_internal): Don't initialize
4640 charset.code_space[15]. The value was garbage, on hosts with
4641 32-bit int (Bug#8600).
4642
4643 * lread.c (read_integer): Be more consistent with string-to-number.
4644 Use string_to_number to do the actual conversion; this avoids
4645 rounding errors and fixes some other screwups. Without this fix,
4646 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4647 (digit_to_number): Move earlier, for benefit of read_integer.
4648 Return -1 if the digit is out of range for the base, -2 if it is
4649 not a digit in any supported base. (Bug#8602)
4650
4651 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4652
4653 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4654 to match comment at start of function. This also removes a
4655 GCC warning about overflow in a 32+64-bit port.
4656
4657 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4658
4659 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4660 Reported by Stefan Monnier in
4661 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4662 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4663 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4664
4665 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4666 (EMACS_UINTPTR): Likewise, with uintptr_t.
4667
4668 * lisp.h: Prefer 64-bit EMACS_INT if available.
4669 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4670 on 32-bit hosts that have 64-bit int, so that they can access
4671 large files.
4672 However, temporarily disable this change unless the temporary
4673 symbol WIDE_EMACS_INT is defined.
4674
4675 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4676
4677 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4678 This removes an assumption that EMACS_INT and long are the same
4679 width as pointers. The assumption is true for Emacs porting targets
4680 now, but we want to make other targets possible.
4681 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4682 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4683 In the rest of the code, change types of integers that hold casted
4684 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4685 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4686 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4687 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4688 No need to cast type when ORing.
4689 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4690 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4691 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4692 assume EMACS_INT is the same width as char *.
4693 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4694 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4695 Remove no-longer-needed casts.
4696 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4697 (xg_tool_bar_help_callback, xg_make_tool_item):
4698 Use EMACS_INTPTR to hold an integer
4699 that will be cast to void *; this can avoid a GCC warning
4700 if EMACS_INT is not the same width as void *.
4701 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4702 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4703 (current_message_1, set_message_1):
4704 Use a local to convert to proper width without a cast.
4705 * xmenu.c (dialog_selection_callback): Likewise.
4706
4707 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4708 Also, don't assume VALBITS / RAND_BITS is less than 5,
4709 and don't rely on undefined behavior when shifting a 1 left into
4710 the sign bit.
4711 * lisp.h (get_random): Change signature to match.
4712
4713 * lread.c (hash_string): Use size_t, not int, for hash computation.
4714 Normally we prefer signed values; but hashing is special, because
4715 it's better to use unsigned division on hash table sizes so that
4716 the remainder is nonnegative. Also, size_t is the natural width
4717 for hashing into memory. The previous code used 'int', which doesn't
4718 retain enough info to hash well into very large tables.
4719 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4720
4721 * dbusbind.c: Don't possibly lose pointer info when converting.
4722 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4723 Use XPNTR rather than XHASH, so that the high-order bits of
4724 the pointer aren't lost when converting through void *.
4725
4726 * eval.c (Fautoload): Don't double-shift a pointer.
4727
4728 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4729
4730 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4731
4732 * gnutls.c (DEF_GNUTLS_FN):
4733 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4734
4735 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4736
4737 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4738 marker. (Bug#8610)
4739
4740 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4741
4742 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4743 New version that can reserve upto 2GB of heap space.
4744
4745 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4746
4747 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4748
4749 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4750
4751 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4752 `gnutls_certificate_set_x509_key_file'.
4753
4754 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4755
4756 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4757 Update dependencies.
4758
4759 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4760
4761 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4762 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4763 Remove unused parameter `fildes'.
4764 * process.c (read_process_output, send_process): Don't pass it.
4765
4766 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4767
4768 Fix previous change: the library cache is defined in w32.c.
4769 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4770 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4771
4772 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4773
4774 Implement dynamic loading of GnuTLS on Windows.
4775
4776 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4777 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4778 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4779 Declare.
4780
4781 * gnutls.c (Qgnutls_dll): Define.
4782 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4783 (gnutls_*): Declare function pointers.
4784 (init_gnutls_functions): New function to initialize function pointers.
4785 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4786 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4787 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4788 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4789 (emacs_gnutls_write, emacs_gnutls_read)
4790 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4791 (Fgnutls_available_p): New function.
4792 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4793 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4794 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4795
4796 * image.c: Include w32.h.
4797 (Vimage_type_cache): Delete.
4798 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4799 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4800 (w32_delayed_load): Move to w32.c.
4801
4802 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4803
4804 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4805 (w32_delayed_load): Move from image.c. When loading a library, record
4806 its filename in the :loaded-from property of the library id.
4807 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4808 Initialize and staticpro them.
4809 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4810
4811 * process.c: Include lisp.h before w32.h, not after.
4812 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4813 instead of gnutls_record_check_pending.
4814
4815 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4816
4817 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4818
4819 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4820 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4821 as passed in.
4822
4823 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4824
4825 * xterm.c (x_set_frame_alpha): Do not set property on anything
4826 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4827
4828 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4829
4830 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4831
4832 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4833
4834 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4835 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4836 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4837 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4838 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4839 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4840 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4841 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4842 (Qgnutls_bootprop_callbacks_verify): Make static.
4843
4844 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4845
4846 * callproc.c: Indentation fixup.
4847
4848 * sysdep.c (wait_for_termination_1): Make static.
4849 (wait_for_termination, interruptible_wait_for_termination):
4850 Move after wait_for_termination_1.
4851
4852 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4853
4854 * sysdep.c (interruptible_wait_for_termination): New function
4855 which is like wait_for_termination, but allows keyboard
4856 interruptions.
4857
4858 * callproc.c (Fcall_process): Add (:file "file") as an option for
4859 the STDOUT buffer.
4860 (Fcall_process_region): Ditto.
4861
4862 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4863
4864 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4865 rather than `XVECTOR (FOO)->size'.
4866
4867 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4868 inttypes.h, as a gnulib replacement is used if it not available in
4869 system headers.
4870
4871 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4872
4873 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4874 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4875 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4876
4877 * coding.c (coding_alloc_by_realloc): Error out if destination
4878 will grow beyond MOST_POSITIVE_FIXNUM.
4879 (decode_coding_emacs_mule): Abort if there isn't enough place in
4880 charbuf for the composition carryover bytes. Reserve an extra
4881 space for up to 2 characters produced in a loop.
4882 (decode_coding_iso_2022): Abort if there isn't enough place in
4883 charbuf for the composition carryover bytes.
4884
4885 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4886
4887 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4888 aborting when %lld or %lll format is passed.
4889 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4890 %llo or %llx format is passed. (Bug#8545)
4891
4892 * window.c (window_scroll_line_based): Use a marker instead of
4893 simple variables to record original value of point. (Bug#7952)
4894
4895 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4896 produced by %s or %c overflows available buffer space. (Bug#8545)
4897
4898 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4899
4900 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4901 (SIZE_MAX): Move defn after all includes, as they might #define it.
4902
4903 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4904
4905 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4906
4907 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4908
4909 * keyboard.c (Qdelayed_warnings_hook): Define.
4910 (command_loop_1): Run `delayed-warnings-hook'
4911 if Vdelayed_warnings_list is non-nil.
4912 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4913 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4914
4915 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4916
4917 * doprnt.c (doprnt): Don't return value smaller than the buffer
4918 size if the message was truncated. (Bug#8545).
4919
4920 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4921
4922 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4923 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4924
4925 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4926
4927 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4928
4929 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4930
4931 * makefile.w32-in: Update dependencies.
4932
4933 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4934
4935 Improve `doprnt' and its usage. (Bug#8545)
4936 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4937 `format_end'. Remove support for %l as a conversion specifier.
4938 Don't use xrealloc. Improve diagnostics when the %l size modifier
4939 is used. Update the commentary.
4940
4941 * eval.c (verror): Simplify calculation of size_t.
4942
4943 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4944 messages.
4945
4946 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4947
4948 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4949 change.
4950
4951 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4952
4953 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4954 This makes this file independent of the recent pseudovector change.
4955
4956 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4957
4958 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4959
4960 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4961 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4962 Remove unused local.
4963 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4964
4965 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4966 GCC 4.6.0 optimizes based on type-based alias analysis.
4967 For example, if b is of type struct buffer * and v of type struct
4968 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4969 != &v->size, and therefore "v->size = 1; b->size = 2; return
4970 v->size;" must therefore return 1. This assumption is incorrect
4971 for Emacs, since it type-puns struct Lisp_Vector * with many other
4972 types. To fix this problem, this patch adds a new type struct
4973 vectorlike_header that documents the constraints on layout of vectors
4974 and pseudovectors, and helps optimizing compilers not get fooled
4975 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4976 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4977 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4978 the size member.
4979 (XSETPVECTYPE): Rewrite in terms of new macro.
4980 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4981 This is a bit clearer, and further avoids the possibility of
4982 undesirable aliasing.
4983 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4984 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4985 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4986 since Lisp_Subr is a special case (no "next" field).
4987 (ASIZE): Now uses header.size rather than size.
4988 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4989 to avoid the hassle of writing XVECTOR (foo)->header.size.
4990 (struct vectorlike_header): New type.
4991 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4992 object, to help avoid aliasing.
4993 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4994 (SUBRP): Likewise, since Lisp_Subr is a special case.
4995 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4996 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4997 (struct Lisp_Hash_Table): Combine first two members into a single
4998 struct vectorlike_header member. All uses of "size" and "next" members
4999 changed to be "header.size" and "header.next".
5000 * buffer.h (struct buffer): Likewise.
5001 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5002 * frame.h (struct frame): Likewise.
5003 * process.h (struct Lisp_Process): Likewise.
5004 * termhooks.h (struct terminal): Likewise.
5005 * window.c (struct save_window_data, struct saved_window): Likewise.
5006 * window.h (struct window): Likewise.
5007 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5008 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5009 * buffer.c (init_buffer_once): Likewise.
5010 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5011 special case.
5012 * process.c (Fformat_network_address): Use local var for size,
5013 for brevity.
5014
5015 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5016
5017 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5018 * data.c (atof): Remove decl; no longer used or needed.
5019 (digit_to_number): Move to lread.c.
5020 (Fstring_to_number): Use new string_to_number function, to be
5021 consistent with how the Lisp reader treats infinities and NaNs.
5022 Do not assume that floating-point numbers represent EMACS_INT
5023 without losing information; this is not true on most 64-bit hosts.
5024 Avoid double-rounding errors, by insisting on integers when
5025 parsing non-base-10 numbers, as the documentation specifies.
5026 * lisp.h (string_to_number): New decl, replacing ...
5027 (isfloat_string): Remove.
5028 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5029 (read1): Do not accept +. and -. as integers; this
5030 appears to have been a coding error. Similarly, do not accept
5031 strings like +-1e0 as floating point numbers. Do not report
5032 overflow for integer overflows unless the base is not 10 which
5033 means we have no simple and reliable way to continue.
5034 Break out the floating-point parsing into a new
5035 function string_to_number, so that Fstring_to_number parses
5036 floating point numbers consistently with the Lisp reader.
5037 (digit_to_number): Move here from data.c. Make it static inline.
5038 (E_CHAR, EXP_INT): Remove, replacing with ...
5039 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5040 (string_to_number): New function, replacing isfloat_string.
5041 This function checks for valid syntax and produces the resulting
5042 Lisp float number too. Rework it so that string-to-number
5043 no longer mishandles examples like "1.0e+". Use strtoumax,
5044 so that overflow for non-base-10 numbers is reported only when
5045 there's no portable and simple way to convert to floating point.
5046
5047 * textprop.c (set_text_properties_1): Rewrite for clarity,
5048 and to avoid GCC warning about integer overflow.
5049
5050 * intervals.h (struct interval): Use EMACS_INT for members
5051 where EMACS_UINT might cause problems. See
5052 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5053 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5054 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5055 All uses changed.
5056 (offset_intervals): Tell GCC not to worry about length overflow
5057 when negating a negative length.
5058
5059 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5060 (overrun_check_free): Likewise.
5061
5062 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5063 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5064 word size.
5065
5066 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5067 (gnutls_make_error): Rename local to avoid shadowing.
5068 (gnutls_emacs_global_deinit): ifdef out; not used.
5069 (Fgnutls_boot): Use const for pointer to readonly storage.
5070 Comment out unused local. Fix pointer signedness problems.
5071
5072 * lread.c (openp): Don't stuff size_t into an 'int'.
5073 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5074 about possible signed overflow.
5075
5076 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5077 (GDK_KEY_g): Don't define if already defined.
5078 (xg_prepare_tooltip): Avoid pointer signedness problem.
5079 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5080
5081 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5082 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5083
5084 * xfns.c (Fx_window_property): Simplify a bit,
5085 to make a bit faster and to avoid GCC 4.6.0 warning.
5086 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5087
5088 * fns.c (internal_equal): Don't assume size_t fits in int.
5089
5090 * alloc.c (compact_small_strings): Tighten assertion a little.
5091
5092 Replace pEd with more-general pI, and fix some printf arg casts.
5093 * lisp.h (pI): New macro, generalizing old pEd macro to other
5094 conversion specifiers. For example, use "...%"pI"d..." rather
5095 than "...%"pEd"...".
5096 (pEd): Remove. All uses replaced with similar uses of pI.
5097 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5098 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5099 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5100 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5101 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5102 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5103 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5104 64-bit hosts.
5105 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5106 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5107 * print.c (safe_debug_print, print_object): Likewise.
5108 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5109 to int.
5110 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5111 avoiding the 0 flag, which is not portable.
5112 * process.c (Fmake_network_process): Use pI to avoid cast.
5113 * region-cache.c (pp_cache): Likewise.
5114 * xdisp.c (decode_mode_spec): Likewise.
5115 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5116 behavior on 64-bit hosts with printf arg.
5117 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5118 (x_stop_queuing_selection_requests): Likewise.
5119 (x_get_window_property): Don't truncate byte count to an 'int'
5120 when tracing.
5121
5122 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5123 here, since it parses constructs like leading '-' and spaces,
5124 which are not wanted; and it overflows with large numbers.
5125 Instead, simply match F[0-9]+, which is what is wanted anyway.
5126
5127 * alloc.c: Remove unportable assumptions about struct layout.
5128 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5129 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5130 (allocate_vectorlike, make_pure_vector): Use the new macros,
5131 plus offsetof, to remove unportable assumptions about struct layout.
5132 These assumptions hold on all porting targets that I know of, but
5133 they are not guaranteed, they're easy to remove, and removing them
5134 makes further changes easier.
5135
5136 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5137 This doesn't fix a bug but makes the code clearer.
5138 (string_overrun_cookie): Now const. Use initializers that
5139 don't formally overflow signed char, to avoid warnings.
5140 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5141 can cause Emacs to crash when string overrun checking is enabled.
5142 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5143 multiple of sizeof (EMACS_INT); it need not be, if
5144 alignof(EMACS_INT) < sizeof (EMACS_INT).
5145 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5146
5147 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5148
5149 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5150
5151 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5152
5153 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5154 supposed to be handshaking. (Bug#8556)
5155 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5156
5157 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5158
5159 * lisp.h (Qdebug): List symbol.
5160 * eval.c (Qdebug): Restore global linkage.
5161 * keyboard.c (debug-on-event): New variable.
5162 (handle_user_signal): Break into debugger when debug-on-event
5163 matches the current signal symbol.
5164
5165 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5166
5167 * alloc.c (check_sblock, check_string_bytes)
5168 (check_string_free_list): Convert to standard C.
5169
5170 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5171
5172 * w32.c (emacs_gnutls_push): Fix typo.
5173
5174 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5175
5176 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5177 "cast to pointer from integer of different size".
5178
5179 Improve doprnt and its use in verror. (Bug#8545)
5180 * doprnt.c (doprnt): Document the set of format control sequences
5181 supported by the function. Use SAFE_ALLOCA instead of always
5182 using `alloca'.
5183
5184 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5185 is one byte too soon. Don't use xrealloc; instead xfree and
5186 xmalloc anew.
5187
5188 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5189
5190 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5191 callbacks stage.
5192
5193 * gnutls.c: Renamed global_initialized to
5194 gnutls_global_initialized. Added internals for the
5195 :verify-hostname-error, :verify-error, and :verify-flags
5196 parameters of `gnutls-boot' and documented those parameters in the
5197 docstring. Start callback support.
5198 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5199 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5200 on error. Return error code.
5201 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5202 (emacs_gnutls_read): Likewise.
5203 (Fgnutls_boot): Return handshake error code.
5204 (emacs_gnutls_handle_error): New function.
5205 (wsaerror_to_errno): Likewise.
5206
5207 * w32.h (emacs_gnutls_pull): Add prototype.
5208 (emacs_gnutls_push): Likewise.
5209
5210 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5211 (emacs_gnutls_push): Likewise.
5212
5213 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5214
5215 * process.c (wait_reading_process_output): Check if GnuTLS
5216 buffered some data internally if no FDs are set for TLS
5217 connections.
5218
5219 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5220 (LIBS): Link to USER_LIBS.
5221 ($(BLD)/gnutls.$(0)): New target.
5222
5223 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5224
5225 * xdisp.c (handle_single_display_spec): Rename the
5226 display_replaced_before_p argument into display_replaced_p, to
5227 make it consistent with the commentary. Fix typos in the
5228 commentary.
5229
5230 * textprop.c (syms_of_textprop): Remove dead code.
5231 (copy_text_properties): Delete obsolete commentary about an
5232 interface that was deleted long ago. Fix typos in the description
5233 of arguments.
5234
5235 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5236 to changes in oldXMenu/XMenu.h from 2011-04-16.
5237 <menu_help_message, prev_menu_help_message>: Constify.
5238 (IT_menu_make_room): menu->help_text is now `const char **';
5239 adjust.
5240
5241 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5242 to changes in oldXMenu/XMenu.h from 2011-04-16.
5243 (struct XMenu): Declare `help_text' `const char **'.
5244
5245 * xfaces.c <Qunspecified>: Make extern again.
5246
5247 * syntax.c: Include sys/types.h before including regex.h, as
5248 required by Posix.
5249
5250 * doc.c (get_doc_string): Improve the format passed to `error'.
5251
5252 * doprnt.c (doprnt): Improve commentary.
5253
5254 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5255
5256 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5257 them with etags.
5258
5259 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5260 changes in globals.h immediately force recompilation.
5261 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5262 $(CURDIR)/s/ms-w32.h.
5263 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5264
5265 * character.c (Fchar_direction): Function deleted.
5266 (syms_of_character): Don't defsubr it.
5267 <char-direction-table>: Deleted.
5268
5269 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5270
5271 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5272 * doprnt.c: Include limits.h.
5273 (SIZE_MAX): New macro.
5274 (doprnt): Return a size_t value. 2nd arg is now size_t.
5275 Many local variables are now size_t instead of int or unsigned.
5276 Improve overflow protection. Support `l' modifier for integer
5277 conversions. Support %l conversion. Don't assume an EMACS_INT
5278 argument for integer conversions and for %c.
5279
5280 * lisp.h (doprnt): Restore prototype.
5281
5282 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5283 $(SRC)/character.h.
5284
5285 * Makefile.in (base_obj): Add back doprnt.o.
5286
5287 * deps.mk (doprnt.o): Add back prerequisites.
5288 (callint.o): Depend on character.h.
5289
5290 * eval.c (internal_lisp_condition_case): Include the handler
5291 representation in the error message.
5292 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5293 when breaking from the loop.
5294
5295 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5296
5297 * callint.c (Fcall_interactively): When displaying error message
5298 about invalid control letter, pass the character's codepoint, not
5299 a pointer to its multibyte form. Improve display of the character
5300 in octal and display also its hex code.
5301
5302 * character.c (char_string): Use %x to display the (unsigned)
5303 codepoint of an invalid character, to avoid displaying a bogus
5304 negative value.
5305
5306 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5307 `error', not SYMBOL_NAME itself.
5308
5309 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5310 character arguments to `error'.
5311
5312 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5313 to `error' in error message about FINAL_CHAR argument. Make sure
5314 FINAL_CHAR is a character, and use %c when it is passed as
5315 argument to `error'.
5316
5317 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5318
5319 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5320
5321 * w32.c: Include <time.h>.
5322 (sys_localtime): New function.
5323
5324 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5325
5326 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5327
5328 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5329
5330 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5331
5332 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5333 zombies (Bug#8467).
5334
5335 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5336
5337 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5338 gl_state.e_property when gl_state.object is Qt.
5339
5340 * insdel.c (make_gap_larger): Remove limitation of buffer size
5341 to <= INT_MAX.
5342
5343 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5344
5345 * xdisp.c (lookup_glyphless_char_display)
5346 (produce_glyphless_glyph): Handle cons cell entry in
5347 glyphless-char-display.
5348 (Vglyphless_char_display): Document it.
5349
5350 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5351 glyphless-char-display.
5352
5353 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5354
5355 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5356
5357 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5358
5359 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5360 definition for no-X builds.
5361
5362 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5363
5364 Static checks with GCC 4.6.0 and non-default toolkits.
5365
5366 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5367
5368 * process.c (keyboard_bit_set): Define only if SIGIO.
5369 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5370 (send_process): Repair possible setjmp clobbering.
5371
5372 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5373
5374 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5375
5376 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5377
5378 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5379 Define only if needed.
5380
5381 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5382 by pacifying GCC about it. Maybe it's time to retire it?
5383 * xfaces.c (USG, __TIMEVAL__): Likewise.
5384
5385 * dispextern.h (struct redisplay_interface): Rename param
5386 to avoid shadowing.
5387 * termhooks.h (struct terminal): Likewise.
5388 * xterm.c (xembed_send_message): Likewise.
5389
5390 * insdel.c (make_gap_smaller): Define only if
5391 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5392
5393 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5394 it.
5395
5396 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5397 so that we aren't warned about unused symbols.
5398
5399 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5400
5401 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5402
5403 * xfns.c (x_real_positions): Mark locals as initialized.
5404
5405 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5406
5407 * xterm.c: Fix problems found by static analysis with other toolkits.
5408 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5409 (x_dispatch_event): Declare static if USE_GTK, and
5410 define if USE_GTK || USE_X_TOOLKIT.
5411 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5412 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5413 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5414 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5415
5416 * xmenu.c (menu_help_callback): Pointer type fixes.
5417 Use const pointers when pointing at readonly data. Avoid pointer
5418 signedness clashes.
5419 (FALSE): Remove unused macro.
5420 (update_frame_menubar): Remove unused decl.
5421
5422 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5423
5424 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5425 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5426 (single_menu_item): Rename local to avoid shadowing.
5427
5428 * keyboard.c (make_lispy_event): Remove unused local var.
5429
5430 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5431 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5432
5433 * bitmaps: Change bitmaps from unsigned char back to the X11
5434 compatible char. Avoid the old compiler warnings about
5435 out-of-range initializers by using, for example, '\xab' rather
5436 than 0xab.
5437
5438 * xgselect.c (xgselect_initialize): Check vs interface
5439 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5440
5441 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5442
5443 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5444 to read-only memory.
5445
5446 * fns.c (vector): Remove; this old hack is no longer needed.
5447
5448 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5449 Remove unused var.
5450 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5451
5452 * xrdb.c (x_load_resources): Omit unused local.
5453
5454 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5455 (x_window): Rename locals to avoid shadowing.
5456 (USG): Use the kludged USG macro, to pacify gcc.
5457
5458 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5459 (x_term_init): Remove local to avoid shadowing.
5460
5461 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5462
5463 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5464 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5465
5466 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5467
5468 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5469
5470 Fix regex.c, syntax.c and friends for buffers > 2GB.
5471 * syntax.h (struct gl_state_s): Declare character position members
5472 EMACS_INT.
5473
5474 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5475
5476 * textprop.c (verify_interval_modification, interval_of):
5477 Declare arguments EMACS_INT.
5478
5479 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5480 EMACS_INT.
5481
5482 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5483
5484 * indent.c (Fvertical_motion): Local variable it_start is now
5485 EMACS_INT.
5486
5487 * regex.c (re_match, re_match_2, re_match_2_internal)
5488 (bcmp_translate, regcomp, regexec, print_double_string)
5489 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5490 (re_compile_pattern, re_exec): Declare arguments and local
5491 variables `size_t' and `ssize_t' and return values `regoff_t', as
5492 appropriate.
5493 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5494 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5495 <compile_stack_type>: `size' and `avail' are now `size_t'.
5496
5497 * regex.h <regoff_t>: Use ssize_t, not int.
5498 (re_search, re_search_2, re_match, re_match_2): Arguments that
5499 specify buffer/string position and length are now ssize_t and
5500 size_t. Return type is regoff_t.
5501
5502 2011-04-16 Ben Key <bkey76@gmail.com>
5503
5504 * nsfont.m: Fixed bugs in ns_get_family and
5505 ns_descriptor_to_entity that were caused by using free to
5506 deallocate memory blocks that were allocated by xmalloc (via
5507 xstrdup). This caused Emacs to crash when compiled with
5508 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5509 --enable-checking=xmallocoverrun). xfree is now used to
5510 deallocate these memory blocks.
5511
5512 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5513
5514 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5515
5516 emacs_write: Accept and return EMACS_INT for sizes.
5517 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5518 et seq.
5519 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5520 Accept and return EMACS_INT.
5521 (emacs_gnutls_write): Return the number of bytes written on
5522 partial writes.
5523 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5524 (emacs_read, emacs_write): Remove check for negative size, as the
5525 Emacs source code has been audited now.
5526 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5527 (emacs_read, emacs_write): Use it.
5528 * process.c (send_process): Adjust to the new signatures of
5529 emacs_write and emacs_gnutls_write. Do not attempt to store
5530 a byte offset into an 'int'; it might overflow.
5531 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5532
5533 * sound.c: Don't assume sizes fit in 'int'.
5534 (struct sound_device.period_size, alsa_period_size):
5535 Return EMACS_INT, not int.
5536 (struct sound_device.write, vox_write, alsa_write):
5537 Accept EMACS_INT, not int.
5538 (wav_play, au_play): Use EMACS_INT to store sizes and to
5539 record read return values.
5540
5541 2011-04-15 Ben Key <bkey76@gmail.com>
5542
5543 * keyboard.c (Qundefined): Don't declare static since it is used
5544 in nsfns.m.
5545 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5546 static since they are used in nsfont.m.
5547
5548 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5549
5550 * process.c (Qprocessp): Don't declare static.
5551 * lisp.h (Qprocessp): Declare again.
5552
5553 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5554
5555 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5556
5557 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5558
5559 Improve C-level modularity by making more things 'static'.
5560
5561 Don't publish debugger-only interfaces to other modules.
5562 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5563 (verify_bytepos, count_markers): Move decls to the only modules
5564 that need them.
5565 * region-cache.h (pp_cache): Likewise.
5566 * window.h (check_all_windows): Likewise.
5567 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5568
5569 * sysdep.c (croak): Now static, if
5570 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5571 * syssignal.h (croak): Declare only if not static.
5572
5573 * alloc.c (refill_memory_reserve): Now static if
5574 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5575 * lisp.h (refill_memory_reserve): Declare only if not static.
5576
5577 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5578 Define only if USE_LUCID.
5579
5580 * xrdb.c (x_customization_string, x_rm_string): Now static.
5581
5582 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5583 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5584
5585 * xdisp.c (draw_row_with_mouse_face): Now static.
5586 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5587
5588 * window.h (check_all_windows): Mark externally visible.
5589
5590 * window.c (window_deletion_count): Now static.
5591
5592 * undo.c: Make symbols static if they're not exported.
5593 (last_undo_buffer, last_boundary_position, pending_boundary):
5594 Now static.
5595
5596 * textprop.c (interval_insert_behind_hooks): Now static.
5597 (interval_insert_in_front_hooks): Likewise.
5598
5599 * term.c: Make symbols static if they're not exported.
5600 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5601 (max_frame_lines, tty_set_terminal_modes):
5602 (tty_reset_terminal_modes, tty_turn_off_highlight):
5603 (get_tty_terminal): Now static.
5604 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5605 * termhooks.h (term_mouse_moveto): Do not declare if
5606 HAVE_WINDOW_SYSTEM.
5607 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5608 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5609
5610 * sysdep.c: Make symbols static if they're not exported.
5611 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5612 Now static.
5613 (sigprocmask_set, full_mask): Remove; unused.
5614 (wait_debugging): Mark as visible.
5615 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5616 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5617
5618 * syntax.c (syntax_temp): Define only if !__GNUC__.
5619
5620 * sound.c (current_sound_device, current_sound): Now static.
5621
5622 * search.c (searchbufs, searchbuf_head): Now static.
5623
5624 * scroll.c (scroll_cost): Remove; unused.
5625 * dispextern.h (scroll_cost): Remove decl.
5626
5627 * region-cache.h (pp_cache): Mark as externally visible.
5628
5629 * process.c: Make symbols static if they're not exported.
5630 (process_tick, update_tick, create_process, chan_process):
5631 (Vprocess_alist, proc_buffered_char, datagram_access):
5632 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5633 (deactivate_process): Mark defn as static, as well as decl.
5634 * lisp.h (create_process): Remove decl.
5635 * process.h (chan_process, Vprocess_alist): Remove decls.
5636
5637 * print.c: Make symbols static if they're not exported.
5638 (print_depth, new_backquote_output, being_printed, print_buffer):
5639 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5640 (print_interval, print_number_index, initial_stderr_stream):
5641 Now static.
5642 * lisp.h (Fprinc): Remove decl.
5643 (debug_output_compilation_hack): Mark as externally visible.
5644
5645 * sysdep.c (croak): Move decl from here to syssignal.h.
5646 * syssignal.h (croak): Put it here, so the API can be checked when
5647 'croak' is called from dissociate_if_controlling_tty.
5648
5649 * minibuf.c: Make symbols static if they're not exported.
5650 (minibuf_save_list, choose_minibuf_frame): Now static.
5651 * lisp.h (choose_minibuf_frame): Remove decl.
5652
5653 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5654
5655 * lread.c: Make symbols static if they're not exported.
5656 (read_objects, initial_obarray, oblookup_last_bucket_number):
5657 Now static.
5658 (make_symbol): Remove; unused.
5659 * lisp.h (initial_obarray, make_symbol): Remove decls.
5660
5661 * keyboard.c: Make symbols static if they're not exported.
5662 (single_kboard, recent_keys_index, total_keys, recent_keys):
5663 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5664 (this_single_command_key_start, echoing, last_auto_save):
5665 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5666 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5667 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5668 (Vlispy_mouse_stem, double_click_count):
5669 Now static.
5670 (force_auto_save_soon): Define only if SIGDANGER.
5671 (ignore_mouse_drag_p): Now static if
5672 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5673 (print_help): Remove; unused.
5674 (stop_character, last_timer_event): Mark as externally visible.
5675 * keyboard.h (ignore_mouse_drag_p): Declare only if
5676 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5677 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5678 * lisp.h (echoing): Remove decl.
5679 (force_auto_save_soon): Declare only if SIGDANGER.
5680 * xdisp.c (redisplay_window): Simplify code, to make it more
5681 obvious that ignore_mouse_drag_p is not accessed if !defined
5682 USE_GTK && !defined HAVE_NS.
5683
5684 * intervals.c: Make symbols static if they're not exported.
5685 (merge_properties_sticky, merge_interval_right, delete_interval):
5686 Now static.
5687 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5688
5689 * insdel.c: Make symbols static if they're not exported.
5690 However, leave prepare_to_modify_buffer alone. It's never
5691 called from outside this function, but that appears to be a bug.
5692 (combine_after_change_list, combine_after_change_buffer):
5693 (adjust_after_replace, signal_before_change): Now static.
5694 (adjust_after_replace_noundo): Remove; unused.
5695 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5696 (signal_before_change): Remove decls.
5697
5698 * indent.c (val_compute_motion, val_vmotion): Now static.
5699
5700 * image.c: Make symbols static if they're not exported.
5701 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5702 if USE_GTK.
5703 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5704 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5705
5706 * fringe.c (standard_bitmaps): Now static.
5707 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5708
5709 * frame.c: Make symbols static if they're not exported.
5710 (x_report_frame_params, make_terminal_frame): Now static.
5711 (get_frame_param): Now static, unless HAVE_NS.
5712 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5713 (x_get_resource_string): Remove; not used.
5714 * frame.h (make_terminal_frame, x_report_frame_params):
5715 (x_get_resource_string); Remove decls.
5716 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5717 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5718
5719 * font.c, fontset.c: Make symbols static if they're not exported.
5720 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5721 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5722 * font.c (font_close_object): Now static.
5723 * font.h (font_close_object): Remove.
5724 * fontset.c (FONTSET_OBJLIST): Remove.
5725 (free_realized_fontset) #if-0 the body, which does nothing.
5726 (face_suitable_for_char_p): #if-0, as it's never called.
5727 * fontset.h (face_suitable_for_char_p): Remove decl.
5728 * xfaces.c (face_at_string_position):
5729 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5730 since 0 is always ASCII.
5731
5732 * fns.c (weak_hash_tables): Now static.
5733
5734 * fileio.c: Make symbols static if they're not exported.
5735 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5736 (Vwrite_region_annotation_buffers): Now static.
5737
5738 * eval.c: Make symbols static if they're not exported.
5739 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5740 * lisp.h (backtrace_list): Remove decl.
5741
5742 * emacs.c: Make symbols static if they're not exported.
5743 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5744 (fatal_error_code, fatal_error_signal_hook, standard_args):
5745 Now static.
5746 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5747 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5748 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5749 * lisp.h (fatal_error_signal_hook): Remove decl.
5750 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5751
5752 * editfns.c: Move a (normally-unused) function to its only use.
5753 * editfns.c, lisp.h (get_operating_system_release): Remove.
5754 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5755 worth the hassle of breaking this out.
5756
5757 * xterm.c: Make symbols static if they're not exported.
5758 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5759 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5760 (x_destroy_window, x_delete_display):
5761 Now static.
5762 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5763 (x_mouse_leave): Remove; unused.
5764 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5765 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5766 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5767 Remove decls.
5768 (x_mouse_leave): Declare only if WINDOWSNT.
5769 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5770 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5771 USE_X_TOOLKIT.
5772
5773 * ftxfont.c: Make symbols static if they're not exported.
5774 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5775 HAVE_FREETYPE.
5776 * font.h (ftxfont_driver): Likewise.
5777
5778 * xfns.c: Make symbols static if they're not exported.
5779 (x_last_font_name, x_display_info_for_name):
5780 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5781 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5782 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5783 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5784 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5785 (last_show_tip_args): Now static.
5786 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5787 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5788 (x_screen_planes): Remove; unused.
5789 * dispextern.h (x_screen_planes): Remove decl.
5790
5791 * dispnew.c: Make symbols static if they're not exported.
5792 * dispextern.h (redraw_garbaged_frames, scrolling):
5793 (increment_row_positions): Remove.
5794 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5795 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5796 Now static.
5797 (redraw_garbaged_frames): Remove; unused.
5798
5799 * xfaces.c: Make symbols static if they're not exported.
5800 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5801 Remove decls.
5802 * xterm.h (defined_color): Remove decls.
5803 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5804 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5805 (menu_face_changed_default, defined_color, free_realized_face):
5806 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5807 (ascii_face_of_lisp_face): Remove; unused.
5808
5809 * xdisp.c: Make symbols static if they're not exported.
5810 * dispextern.h (scratch_glyph_row, window_box_edges):
5811 (glyph_to_pixel_coords, set_cursor_from_row):
5812 (get_next_display_element, set_iterator_to_next):
5813 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5814 (show_mouse_face): Remove decls
5815 * frame.h (message_buf_print): Likewise.
5816 * lisp.h (pop_message, set_message, check_point_in_composition):
5817 Likewise.
5818 * xterm.h (set_vertical_scroll_bar): Likewise.
5819 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5820 (message_buf_print, scratch_glyph_row, displayed_buffer):
5821 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5822 (get_next_display_element, show_mouse_face, window_box_edges):
5823 (frame_to_window_pixel_xy, check_point_in_composition):
5824 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5825 (glyph_to_pixel_coords): Remove; unused.
5826
5827 * dired.c (file_name_completion): Now static.
5828
5829 * dbusbind.c (xd_in_read_queued_messages): Now static.
5830
5831 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5832 * data.c (circular_list_error): Remove.
5833
5834 * commands.h (last_point_position, last_point_position_buffer):
5835 (last_point_position_window): Remove decls.
5836 * keyboard.c: Make these variables static.
5837
5838 * coding.h (coding, code_convert_region, encode_coding_gap):
5839 Remove decls.
5840 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5841 (iso_code_class, detect_coding, code_convert_region): Now static.
5842 (encode_coding_gap): Remove; unused.
5843
5844 * chartab.c (chartab_chars, chartab_bits): Now static.
5845
5846 * charset.h (charset_iso_8859_1): Remove decl.
5847 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5848 Now static.
5849
5850 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5851 * ccl.c (Vccl_program_table): Now static.
5852 (check_ccl_update): Remove; unused.
5853
5854 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5855 * category.h: ... from here.
5856 * category.c (check_category_table, set_category_set): Now static.
5857
5858 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5859 * lisp.h: Remove these decls.
5860
5861 * buffer.c (buffer_count): Remove unused var.
5862
5863 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5864 so that it's not optimized away.
5865 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5866 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5867 exported only to the debugger.
5868
5869 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5870 * atimer.h (run_all_atimers): Remove; not exported.
5871
5872 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5873 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5874 was inaccessible from Lisp.
5875 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5876 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5877
5878 alloc.c: Import and export fewer symbols, and remove unused items.
5879 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5880 is defined.
5881 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5882 it's not optimized away by whole-program optimization.
5883 (message_enable_multibyte, free_misc): Remove.
5884 (catchlist, handlerlist, mark_backtrace):
5885 Declare only if BYTE_MARK_STACK.
5886 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5887 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5888 (message_enable_multibyte): Remove decl.
5889 (free_misc, interval_free_list, float_block, float_block_index):
5890 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5891 (cons_free_list, last_marked_index):
5892 Now static.
5893 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5894 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5895 (mark_backtrace): Define only if BYTE_MARK_STACK.
5896 * xdisp.c (message_enable_multibyte): Now static.
5897
5898 Declare Lisp_Object Q* variables to be 'static' if not exported.
5899 This makes it easier for human readers (and static analyzers)
5900 to see whether these variables are used from other modules.
5901 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5902 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5903 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5904 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5905 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5906 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5907 * xmenu.c, xselect.c:
5908 Declare Q* vars static if they are not used in other modules.
5909 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5910 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5911 Remove decls of unexported vars.
5912 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5913
5914 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5915
5916 Make Emacs functions such as Fatom 'static' by default.
5917 This makes it easier for human readers (and static analyzers)
5918 to see whether these functions can be called from other modules.
5919 DEFUN now defines a static function. To make the function external
5920 so that it can be used in other C modules, use the new macro DEFUE.
5921 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5922 (Finit_image_library):
5923 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5924 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5925 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5926 Remove decls, since these functions are now static.
5927 (Funintern, Fget_internal_run_time): New decls, since these functions
5928 were already external.
5929
5930 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5931 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5932 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5933 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5934 * keyboard.c, keymap.c, lread.c:
5935 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5936 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5937 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5938 Mark functions with DEFUE instead of DEFUN,
5939 if they are used in other modules.
5940 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5941 decls for now-static functions.
5942 * buffer.h (Fdelete_overlay): Remove decl.
5943 * callproc.c (Fgetenv_internal): Mark as internal.
5944 * composite.c (Fremove_list_of_text_properties): Remove decl.
5945 (Fcomposition_get_gstring): New forward static decl.
5946 * composite.h (Fcomposite_get_gstring): Remove decl.
5947 * dired.c (Ffile_attributes): New forward static decl.
5948 * doc.c (Fdocumntation_property): New forward static decl.
5949 * eval.c (Ffetch_bytecode): New forward static decl.
5950 (Funintern): Remove extern decl; now in .h file where it belongs.
5951 * fileio.c (Fmake_symbolic_link): New forward static decl.
5952 * image.c (Finit_image_library): New forward static decl.
5953 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5954 * intervals.h (Fprevious_property_change):
5955 (Fremove_list_of_text_properties): Remove decls.
5956 * keyboard.c (Fthis_command_keys): Remove decl.
5957 (Fcommand_execute): New forward static decl.
5958 * keymap.c (Flookup_key): New forward static decl.
5959 (Fcopy_keymap): Now static.
5960 * keymap.h (Flookup_key): Remove decl.
5961 * process.c (Fget_process): New forward static decl.
5962 (Fprocess_datagram_address): Mark as internal.
5963 * syntax.c (Fsyntax_table_p): New forward static decl.
5964 (skip_chars): Remove duplicate decl.
5965 * textprop.c (Fprevious_property_change): New forward static decl.
5966 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5967 Now internal.
5968 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5969 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5970
5971 * editfns.c (Fformat): Remove unreachable code.
5972
5973 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5974
5975 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5976 change. (Bug#8496)
5977
5978 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5979
5980 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5981 when at ZV. (Bug#8487)
5982
5983 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5984
5985 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5986 (Bug#8437)
5987 * keyboard.c (parse_tool_bar_item): Likewise.
5988 * sound.c (sound_cleanup, alsa_close): Likewise.
5989 * termcap.c (tgetent): Likewise.
5990 * xfns.c (x_default_font_parameter): Likewise.
5991 * xsettings.c (read_and_apply_settings): Likewise.
5992
5993 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5994 (overrun_check_free): Protoize.
5995
5996 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5997
5998 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5999 since callers should never pass a negative size.
6000 Change the signature to match that of plain 'read' and 'write'; see
6001 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6002 * lisp.h: Update prototypes of emacs_write and emacs_read.
6003
6004 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6005
6006 * xdisp.c (redisplay_window): Don't try to determine the character
6007 position of the scroll margin if the window start point w->startp
6008 is outside the buffer's accessible region. (Bug#8468)
6009
6010 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6011
6012 Fix write-region and its subroutines for buffers > 2GB.
6013 * fileio.c (a_write, e_write): Modify declaration of arguments and
6014 local variables to support buffers larger than 2GB.
6015 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6016
6017 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6018 argument, local variables, and return value.
6019
6020 * lisp.h: Update prototypes of emacs_write and emacs_read.
6021
6022 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6023
6024 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6025
6026 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6027
6028 Fix more problems found by GCC 4.6.0's static checks.
6029
6030 * xdisp.c (vmessage): Use a better test for character truncation.
6031
6032 * charset.c (load_charset_map): <, not <=, for optimization,
6033 and to avoid potential problems with integer overflow.
6034 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6035 * casetab.c (set_identity, shuffle): Likewise.
6036 * editfns.c (Fformat): Likewise.
6037 * syntax.c (skip_chars): Likewise.
6038
6039 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6040 This also lets GCC 4.6.0 generate slightly better loop code.
6041
6042 * callint.c (Fcall_interactively): <, not <=, for optimization.
6043 (Fcall_interactively): Count the number of arguments produced,
6044 not the number of arguments given. This is simpler and lets GCC
6045 4.6.0 generate slightly better code.
6046
6047 * ftfont.c: Distingish more carefully between FcChar8 and char.
6048 The previous code passed unsigned char * to a functions like
6049 strlen and xstrcasecmp that expect char *, which does not
6050 conform to the C standard.
6051 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6052 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6053 char * when the C standard requires it.
6054
6055 * keyboard.c (read_char): Remove unused var.
6056
6057 * eval.c: Port to Windows vsnprintf (Bug#8435).
6058 Include <limits.h>.
6059 (SIZE_MAX): Define if the headers do not.
6060 (verror): Do not give up if vsnprintf returns a negative count.
6061 Instead, grow the buffer. This ports to Windows vsnprintf, which
6062 does not conform to C99. Problem reported by Eli Zaretskii.
6063 Also, simplify the allocation scheme, by avoiding the need for
6064 calling realloc, and removing the ALLOCATED variable.
6065
6066 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6067
6068 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6069 But keep the doprint source code for now, as we might revamp it
6070 and use it again (Bug#8435).
6071 * lisp.h (doprnt): Remove.
6072 * Makefile.in (base_obj): Remove doprnt.o.
6073 * deps.mk (doprnt.o): Remove.
6074
6075 error: Print 32- and 64-bit integers portably (Bug#8435).
6076 Without this change, on typical 64-bit hosts error ("...%d...", N)
6077 was used to print both 32- and 64-bit integers N, which relied on
6078 undefined behavior.
6079 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6080 New macro.
6081 * lisp.h (error, verror): Mark as printf-like functions.
6082 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6083 Report overflow in size calculations when allocating printf buffer.
6084 Do not truncate output string at its first null byte.
6085 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6086 Truncate the output at a character boundary, since vsnprintf does not
6087 do that.
6088 * charset.c (check_iso_charset_parameter): Convert internal
6089 character to string before calling 'error', since %c now has the
6090 printf meaning.
6091 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6092 overflow when computing char to be passed to 'error'. Do not
6093 pass Lisp_Object to 'error'; pass the integer instead.
6094 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6095 formatted with plain %d.
6096
6097 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6098
6099 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6100
6101 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6102
6103 * xterm.c (x_catch_errors): Remove duplicate declaration.
6104
6105 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6106
6107 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6108
6109 2011-04-10 Jim Meyering <meyering@redhat.com>
6110
6111 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6112 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6113 return ssize_t not "int", and use size_t as the buffer length.
6114 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6115 * gnutls.h: Update declarations.
6116 * process.c (read_process_output): Use ssize_t, to match.
6117 (send_process): Likewise.
6118
6119 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6120
6121 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6122
6123 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6124
6125 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6126 Use unsigned char, to match FcChar8 type definition.
6127
6128 * xterm.c (handle_one_xevent):
6129 * xmenu.c (create_and_show_popup_menu):
6130 * xselect.c (x_decline_selection_request)
6131 (x_reply_selection_request): Avoid type-punned deref of X events.
6132
6133 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6134
6135 Fix some uses of `int' instead of EMACS_INT.
6136 * search.c (string_match_1, fast_string_match)
6137 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6138 (scan_buffer, find_next_newline_no_quit)
6139 (find_before_next_newline, search_command, Freplace_match)
6140 (Fmatch_data): Make some `int' variables be EMACS_INT.
6141
6142 * xdisp.c (display_count_lines): 3rd argument and return value now
6143 EMACS_INT. All callers changed.
6144 (pint2hrstr): Last argument is now EMACS_INT.
6145
6146 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6147 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6148 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6149 (decode_coding_utf_16, decode_coding_emacs_mule)
6150 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6151 (decode_coding_ccl, decode_coding_charset)
6152 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6153 (decode_coding_iso_2022, decode_coding_emacs_mule)
6154 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6155 <char_offset, last_offset>: Declare EMACS_INT.
6156 (encode_coding_utf_8, encode_coding_utf_16)
6157 (encode_coding_emacs_mule, encode_invocation_designation)
6158 (encode_designation_at_bol, encode_coding_iso_2022)
6159 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6160 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6161 Declare EMACS_INT.
6162 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6163 (encode_invocation_designation): Last argument P_NCHARS is now
6164 EMACS_INT.
6165 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6166 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6167
6168 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6169 All users changed.
6170
6171 * ccl.c (Fccl_execute_on_string): Declare some variables
6172 EMACS_INT.
6173
6174 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6175
6176 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6177
6178 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6179
6180 * process.c (Fformat_network_address): Doc fix.
6181
6182 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6183
6184 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6185
6186 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6187
6188 * keyboard.c (read_char): Call Lisp function help-form-show,
6189 instead of using internal_with_output_to_temp_buffer.
6190 (Qhelp_form_show): New var.
6191 (syms_of_keyboard): Use DEFSYM macro.
6192
6193 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6194
6195 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6196
6197 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6198
6199 * process.c (Flist_processes): Remove to Lisp.
6200 (list_processes_1): Delete.
6201
6202 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6203
6204 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6205
6206 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6207
6208 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6209
6210 Fix more problems found by GCC 4.6.0's static checks.
6211
6212 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6213
6214 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6215
6216 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6217
6218 * xdisp.c (vmessage): Mark as a printf-like function.
6219
6220 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6221
6222 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6223
6224 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6225 printf-like functions.
6226 (tiff_load): Add casts to remove these marks before passing them
6227 to system-supplied API.
6228
6229 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6230
6231 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6232 This avoids several warnings with gcc -Wstrict-overflow.
6233 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6234 directly, rather than having caller test rule sign. This avoids
6235 some unnecessary tests.
6236 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6237 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6238 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6239
6240 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6241 (xfont_open): Avoid unnecessary tests.
6242
6243 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6244
6245 * composite.h, composite.c (composition_gstring_put_cache):
6246 Use EMACS_INT, not int, for length.
6247
6248 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6249 breaking out part of COMPOSITION_DECODE_RULE.
6250 (COMPOSITION_DECODE_RULE): Use it.
6251 * composite.c (get_composition_id): Remove unused local vars,
6252 by using the new macro.
6253
6254 * textprop.c (set_text_properties_1): Change while to do-while,
6255 since the condition is always true at first.
6256
6257 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6258 (interval_deletion_adjustment): Return unsigned value.
6259 All uses changed.
6260
6261 * process.c (list_processes_1, create_pty, read_process_output):
6262 (exec_sentinel): Remove vars that were set but not used.
6263 (create_pty): Remove unnecessary "volatile"s.
6264 (Fnetwork_interface_info): Avoid possibility of int overflow.
6265 (read_process_output): Do adaptive read buffering even if carryover.
6266 (read_process_output): Simplify nbytes computation if buffered.
6267
6268 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6269
6270 * syntax.c (scan_words): Remove var that was set but not used.
6271 (update_syntax_table): Use unsigned instead of int.
6272
6273 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6274 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6275 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6276
6277 * print.c (print_error_message): Avoid int overflow.
6278
6279 * font.c (font_list_entities): Redo for clarity,
6280 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6281
6282 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6283 (font_score): Avoid potential overflow in diff calculation.
6284
6285 * fns.c (substring_both): Remove var that is set but not used.
6286 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6287
6288 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6289
6290 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6291 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6292 can always succeed if overflow has undefined behavior.
6293
6294 * search.c (boyer_moore, wordify): Remove vars set but not used.
6295 (wordify): Omit three unnecessary tests.
6296
6297 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6298 All callers changed. This avoids the need for an unused var.
6299
6300 * casefiddle.c (casify_region): Remove var that is set but not used.
6301
6302 * dired.c (file_name_completion): Remove var that is set but not used.
6303
6304 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6305
6306 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6307 (Finsert_file_contents): Remove unnecessary code checking fd.
6308
6309 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6310 Check for integer overflow on size calculations.
6311
6312 * buffer.c (Fprevious_overlay_change): Remove var that is set
6313 but not used.
6314
6315 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6316 Remove vars that are set but not used.
6317 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6318 (timer_check_2): Mark vars as initialized.
6319
6320 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6321
6322 * image.c (lookup_image): Remove var that is set but not used.
6323 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6324
6325 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6326 that are set but not used.
6327
6328 * xfns.c (make_invisible_cursor): Don't return garbage
6329 if XCreateBitmapFromData fails (Bug#8410).
6330
6331 * xselect.c (x_get_local_selection, x_handle_property_notify):
6332 Remove vars that are set but not used.
6333
6334 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6335 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6336
6337 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6338 Remove var that is set but not used.
6339 (scroll_bar_windows_size): Now size_t, not int.
6340 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6341 Check for overflow.
6342
6343 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6344 (map_tty_color) [!defined MSDOS]: Likewise.
6345
6346 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6347
6348 * coding.c: Remove vars that are set but not used.
6349 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6350 All callers changed.
6351 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6352 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6353 (decode_coding_charset): Remove vars that are set but not used.
6354
6355 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6356 that is set but not used.
6357
6358 * print.c (print_object): Remove var that is set but not used.
6359
6360 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6361 The gnulib version avoids calling malloc in the usual case,
6362 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6363 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6364 * filelock.c (current_lock_owner): Likewise.
6365 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6366 * sysdep.c: Include allocator.h, careadlinkat.h.
6367 (emacs_no_realloc_allocator): New static constant.
6368 (emacs_readlink): New function.
6369 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6370 ../lib/careadlinkat.h.
6371
6372 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6373
6374 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6375 first non-nil return value).
6376
6377 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6378
6379 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6380 if not defined (Bug#8403).
6381
6382 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6383
6384 * xdisp.c (display_count_lines): Remove parameter `start',
6385 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6386 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6387 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6388 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6389 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6390 and thereabouts. All callers changed.
6391 (get_per_char_metric): Remove parameter `f', unused since
6392 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6393
6394 2011-04-02 Jim Meyering <meyering@redhat.com>
6395
6396 do not dereference NULL upon failed strdup
6397 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6398 (ns_get_family): Likewise.
6399
6400 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6401
6402 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6403
6404 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6405
6406 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6407 later (Bug#8403).
6408
6409 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6410
6411 Add lexical binding.
6412
6413 * window.c (Ftemp_output_buffer_show): New fun.
6414 (Fsave_window_excursion):
6415 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6416
6417 * lread.c (lisp_file_lexically_bound_p): New function.
6418 (Fload): Bind Qlexical_binding.
6419 (readevalloop): Remove `evalfun' arg.
6420 Bind Qinternal_interpreter_environment.
6421 (Feval_buffer): Bind Qlexical_binding.
6422 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6423 Mark as dynamic.
6424 (syms_of_lread): Declare `lexical-binding'.
6425
6426 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6427
6428 * keyboard.c (eval_dyn): New fun.
6429 (menu_item_eval_property): Use it.
6430
6431 * image.c (parse_image_spec): Use Ffunctionp.
6432
6433 * fns.c (concat, mapcar1): Accept byte-code-functions.
6434
6435 * eval.c (Fsetq): Handle lexical vars.
6436 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6437 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6438 (FletX, Flet): Obey lexical binding.
6439 (Fcommandp): Handle closures.
6440 (Feval): New `lexical' arg.
6441 (eval_sub): New function extracted from Feval. Use it almost
6442 everywhere where Feval was used. Look up vars in lexical env.
6443 Handle closures.
6444 (Ffunctionp): Move from subr.el.
6445 (Ffuncall): Handle closures.
6446 (apply_lambda): Remove `eval_flags'.
6447 (funcall_lambda): Handle closures and new byte-code-functions.
6448 (Fspecial_variable_p): New function.
6449 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6450 but without exporting it to Lisp.
6451
6452 * doc.c (Fdocumentation, store_function_docstring):
6453 * data.c (Finteractive_form): Handle closures.
6454
6455 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6456 interactive spec.
6457
6458 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6459 New byte-codes.
6460 (exec_byte_code): New function extracted from Fbyte_code to handle new
6461 calling convention for byte-code-functions. Add new byte-codes.
6462
6463 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6464
6465 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6466
6467 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6468
6469 * xdisp.c (redisplay_internal): Fix prototype.
6470
6471 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6472
6473 * xdisp.c (SCROLL_LIMIT): New macro.
6474 (try_scrolling): Use it when setting scroll_limit.
6475 Limit scrolling to 100 screen lines.
6476 (redisplay_window): Even when falling back on "recentering",
6477 position point in the window according to scroll-conservatively,
6478 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6479
6480 (try_scrolling): When point is above the window, allow searching
6481 as far as scroll_max, or one screenful, to compute vertical
6482 distance from PT to the scroll margin position. This prevents
6483 try_scrolling from unnecessarily failing when
6484 scroll-conservatively is set to a value slightly larger than the
6485 window height. Clean up the case of PT below the margin at bottom
6486 of window: scroll_max can no longer be INT_MAX. When aggressive
6487 scrolling is in use, don't let point enter the opposite scroll
6488 margin as result of the scroll.
6489 (syms_of_xdisp) <scroll-conservatively>: Document the
6490 threshold of 100 lines for never-recentering scrolling.
6491
6492 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6493
6494 * dispextern.h (move_it_by_lines):
6495 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6496 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6497 (message_log_check_duplicate): Remove parameters `prev_bol' and
6498 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6499 (redisplay_internal): Remove parameter `preserve_echo_area',
6500 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6501
6502 * indent.c (Fvertical_motion):
6503 * window.c (window_scroll_pixel_based, Frecenter):
6504 Don't pass `need_y_p' to `move_it_by_lines'.
6505
6506 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6507
6508 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6509 steal a few bits to be more compact.
6510 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6511 Remove unneeded casts.
6512
6513 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6514
6515 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6516
6517 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6518 binding" message (bug#7967).
6519
6520 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6521
6522 Fix more problems found by GCC 4.6.0's static checks.
6523
6524 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6525 Remove unused local var.
6526
6527 * editfns.c (Fmessage_box): Remove unused local var.
6528
6529 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6530 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6531 Omit unused local vars.
6532 * window.c (shrink_windows): Omit unused local var.
6533 * menu.c (digest_single_submenu): Omit unused local var.
6534 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6535 Omit unused local var.
6536
6537 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6538 Don't assume string length fits in int.
6539 (keyremap_step, read_key_sequence): Use size_t for sizes.
6540 (read_key_sequence): Don't check last_real_key_start redundantly.
6541
6542 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6543 instead of alloca (Bug#8344).
6544
6545 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6546 (Fbacktrace_frame): Don't assume nframes fits in int.
6547
6548 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6549
6550 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6551 concerns.
6552
6553 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6554
6555 * cm.c (calccost): Turn while-do into do-while, for clarity.
6556
6557 * keyboard.c (syms_of_keyboard): Use the same style as later
6558 in this function when indexing through an array. This also
6559 works around GCC bug 48267.
6560
6561 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6562
6563 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6564
6565 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6566 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6567
6568 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6569 This avoids undefined behavior on integer overflow, and is a bit
6570 more convenient anyway since it is compared to a size_t variable.
6571
6572 Variadic C functions now count arguments with size_t, not int.
6573 This avoids an unnecessary limitation on 64-bit machines, which
6574 caused (substring ...) to crash on large vectors (Bug#8344).
6575 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6576 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6577 All variadic functions and their callers changed accordingly.
6578 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6579 * data.c (arith_driver, float_arith_driver): Likewise.
6580 * editfns.c (general_insert_function): Likewise.
6581 * eval.c (struct backtrace.nargs, interactive_p)
6582 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6583 (funcall_lambda, mark_backtrace): Likewise.
6584 * fns.c (concat): Likewise.
6585 * frame.c (x_set_frame_parameters): Likewise.
6586 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6587 0 if not found, not -1. All callers changed.
6588
6589 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6590 (stack_copy_size): Now size_t, not int.
6591 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6592
6593 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6594
6595 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6596 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6597 All callers changed.
6598
6599 * lisp.h (multibyte_char_to_unibyte):
6600 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6601 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6602 * character.h (CHAR_TO_BYTE8):
6603 * cmds.c (internal_self_insert):
6604 * editfns.c (general_insert_function):
6605 * keymap.c (push_key_description):
6606 * search.c (Freplace_match):
6607 * xdisp.c (message_dolog, set_message_1): All callers changed.
6608
6609 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6610
6611 * keyboard.c (safe_run_hook_funcall): New function.
6612 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6613 don't set the hook to nil, but remove the offending function instead.
6614 (Qcommand_hook_internal): Remove, unused.
6615 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6616 Vcommand_hook_internal.
6617
6618 * eval.c (enum run_hooks_condition): Remove.
6619 (funcall_nil, funcall_not): New functions.
6620 (run_hook_with_args): Call each function through a `funcall' argument.
6621 Remove `cond' argument, now redundant.
6622 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6623 (Frun_hook_with_args_until_failure): Adjust accordingly.
6624 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6625
6626 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6627
6628 * dispextern.h (string_buffer_position): Remove declaration.
6629
6630 * print.c (strout): Remove parameter `multibyte', unused since
6631 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6632
6633 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6634 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6635 All callers changed.
6636
6637 * w32.c (_wsa_errlist): Use braces for struct initializers.
6638
6639 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6640 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6641 All callers changed.
6642 (string_buffer_position): Likewise. Also, make static (it's never
6643 used outside xdisp.c).
6644 (cursor_row_p): Remove parameter `w', unused since
6645 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6646 (decode_mode_spec): Remove parameter `precision', introduced during
6647 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6648 All callers changed.
6649
6650 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6651
6652 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6653
6654 2011-03-27 Anders Lindgren <andlind@gmail.com>
6655
6656 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6657 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6658 (ns_update_auto_hide_menu_bar): New functions.
6659 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6660 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6661 ns_constrain_all_frames.
6662 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6663 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6664
6665 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6666
6667 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6668
6669 2011-03-27 Glenn Morris <rgm@gnu.org>
6670
6671 * syssignal.h: Replace RETSIGTYPE with void.
6672 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6673 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6674 Replace SIGTYPE with void everywhere.
6675 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6676 * s/template.h (SIGTYPE): Remove commented out definition.
6677
6678 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6679
6680 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6681 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6682
6683 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6684
6685 * w32.c (read_unc_volume): Use parameter `henum', instead of
6686 global variable `wget_enum_handle'.
6687
6688 * keymap.c (describe_vector): Remove parameters `indices' and
6689 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6690 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6691
6692 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6693
6694 * keyboard.c (timer_check): Remove parameter `do_it_now',
6695 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6696 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6697 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6698
6699 * keyboard.c (read_char):
6700 * w32menu.c (w32_menu_display_help):
6701 * xmenu.c (show_help_event, menu_help_callback):
6702 Adjust calls to `show_help_echo'.
6703
6704 * gtkutil.c (xg_maybe_add_timer):
6705 * keyboard.c (readable_events):
6706 * process.c (wait_reading_process_output):
6707 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6708
6709 * insdel.c (adjust_markers_gap_motion):
6710 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6711 (gap_left, gap_right): Don't call it.
6712
6713 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6714
6715 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6716 incurred during fontification.
6717
6718 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6719
6720 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6721 (DEFVAR_PER_BUFFER): Don't pass it.
6722
6723 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6724 (scrolling_window): Don't pass it.
6725
6726 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6727
6728 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6729
6730 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6731 and `suffix'.
6732 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6733 of variables specific to SELinux and computation of `encoded_absname'.
6734
6735 * image.c (XPutPixel): Remove unused variable `height'.
6736
6737 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6738
6739 * unexw32.c (get_section_info): Remove unused variable `section'.
6740
6741 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6742 (system_process_attributes): Remove unused variable `sess'.
6743 (sys_read): Remove unused variable `err'.
6744
6745 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6746 (w32_wnd_proc): Remove unused variable `isdead'.
6747 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6748 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6749 (x_create_tip_frame): Remove unused variable `tem'.
6750
6751 * w32inevt.c (w32_console_read_socket):
6752 Remove unused variable `no_events'.
6753
6754 * w32term.c (x_draw_composite_glyph_string_foreground):
6755 Remove unused variable `width'.
6756
6757 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6758
6759 * w32term.c (x_set_glyph_string_clipping):
6760 Don't pass uninitialized region to CombineRgn.
6761
6762 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6763
6764 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6765 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6766 (Fx_close_connection): Remove unused variable `i'.
6767
6768 * w32font.c (w32font_draw): Return number of glyphs.
6769 (w32font_open_internal): Remove unused variable `i'.
6770 (w32font_driver): Add missing initializer.
6771
6772 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6773 (fill_in_menu): Remove unused variable `items_added'.
6774
6775 * w32term.c (last_mouse_press_frame): Remove static global variable.
6776 (w32_clip_to_row): Remove unused variable `f'.
6777 (x_delete_terminal): Remove unused variable `i'.
6778
6779 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6780 (NOTHING): Remove unused static global variable.
6781 (uniscribe_check_otf): Remove unused variable `table'.
6782 (uniscribe_font_driver): Add missing initializers.
6783
6784 2011-03-23 Julien Danjou <julien@danjou.info>
6785
6786 * term.c (Fsuspend_tty, Fresume_tty):
6787 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6788 * window.c (temp_output_buffer_show):
6789 * insdel.c (signal_before_change):
6790 * frame.c (Fhandle_switch_frame):
6791 * fileio.c (Fdo_auto_save):
6792 * emacs.c (Fkill_emacs):
6793 * editfns.c (save_excursion_restore):
6794 * cmds.c (internal_self_insert):
6795 * callint.c (Fcall_interactively):
6796 * buffer.c (Fkill_all_local_variables):
6797 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6798 Use Frun_hooks.
6799 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6800 unconditionnaly since it does the check itself.
6801
6802 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6803
6804 Fix more problems found by GCC 4.5.2's static checks.
6805
6806 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6807 the first time through the loop, since we know p0 < p1 then.
6808 This also avoids a gcc -Wstrict-overflow warning.
6809
6810 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6811 leading to a memory leak, possible in functions like
6812 load_charset_map_from_file that can allocate an unbounded number
6813 of objects (Bug#8318).
6814
6815 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6816 that could (at least in theory) be that large.
6817
6818 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6819 This is less likely to overflow, and avoids undefined behavior if
6820 overflow does occur. All callers changed. Use strtoul to scan
6821 for the unsigned long integer.
6822 (pint2hrstr): Simplify and tune code slightly.
6823 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6824
6825 * scroll.c (do_scrolling): Work around GCC bug 48228.
6826 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6827
6828 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6829 This also avoids a warning with gcc -Wstrict-overflow.
6830 (validate_x_resource_name): Simplify count usage.
6831 This also avoids a warning with gcc -Wstrict-overflow.
6832
6833 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6834 fail (Bug#8306).
6835
6836 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6837
6838 * process.c (Fmake_network_process): Use socklen_t, not int,
6839 where POSIX says socklen_t is required in portable programs.
6840 This fixes a porting bug on hosts like 64-bit HP-UX, where
6841 socklen_t is wider than int (Bug#8277).
6842 (Fmake_network_process, server_accept_connection):
6843 (wait_reading_process_output, read_process_output):
6844 Likewise.
6845
6846 * process.c: Rename or move locals to avoid shadowing.
6847 (list_processes_1, Fmake_network_process):
6848 (read_process_output_error_handler, exec_sentinel_error_handler):
6849 Rename or move locals.
6850 (Fmake_network_process): Define label "retry_connect" only if needed.
6851 (Fnetwork_interface_info): Fix pointer signedness.
6852 (process_send_signal): Add cast to avoid pointer signedness problem.
6853 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6854 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6855
6856 Make tparam.h and terminfo.c consistent.
6857 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6858 Include tparam.h instead, since it declares them.
6859 * cm.h (PC): Remove extern decl; tparam.h now does this.
6860 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6861 * terminfo.c: Include tparam.h, to check interfaces.
6862 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6863 (tparam): Adjust signature to match interface in tparam.h;
6864 this removes some undefined behavior. Check that outstring and len
6865 are zero, which they always are with Emacs.
6866 * tparam.h (PC, BC, UP): New extern decls.
6867
6868 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6869 (xftfont_open): Rename locals to avoid shadowing.
6870
6871 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6872 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6873 (OTF_TAG_SYM): Omit macro if not needed.
6874 (ftfont_list): Remove unused local.
6875 (get_adstyle_property, ftfont_pattern_entity):
6876 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6877 Rename locals to avoid shadowing.
6878
6879 * xfont.c (xfont_list_family): Mark var as initialized.
6880
6881 * xml.c (make_dom): Now static.
6882
6883 * composite.c (composition_compute_stop_pos): Rename local to
6884 avoid shadowing.
6885 (composition_reseat_it): Remove unused locals.
6886 (find_automatic_composition, composition_adjust_point): Likewise.
6887 (composition_update_it): Mark var as initialized.
6888 (find_automatic_composition): Mark vars as initialized,
6889 with a FIXME (Bug#8290).
6890
6891 character.h: Rename locals to avoid shadowing.
6892 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6893 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6894 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6895 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6896 to avoid shadowing.
6897
6898 * textprop.c (property_change_between_p): Remove; unused.
6899
6900 * intervals.c (interval_start_pos): Now static.
6901
6902 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6903
6904 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6905 Rename locals to avoid shadowing.
6906
6907 * sound.c (wav_play, au_play, Fplay_sound_internal):
6908 Fix pointer signedness.
6909 (alsa_choose_format): Remove unused local var.
6910 (wav_play): Initialize a variable to 0, to prevent undefined
6911 behavior (Bug#8278).
6912
6913 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6914
6915 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6916
6917 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6918 clobbering (Bug#8298).
6919 * sysdep.c (sys_subshell): Likewise.
6920 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6921
6922 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6923 This should get cleaned up, so that child_setup has the
6924 same signature on all platforms.
6925
6926 * callproc.c (call_process_cleanup): Now static.
6927 (relocate_fd): Rename locals to avoid shadowing.
6928
6929 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6930
6931 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6932 not to be necessary, and produces flickering.
6933
6934 2011-03-20 Glenn Morris <rgm@gnu.org>
6935
6936 * config.in: Remove file.
6937
6938 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6939
6940 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6941 are now in src/globals.h.
6942 (syms_of_minibuf): Remove spurious & from previous change.
6943
6944 2011-03-20 Leo <sdl.web@gmail.com>
6945
6946 * minibuf.c (completing-read-function): New variable.
6947 (completing-read-default): Rename from completing-read.
6948 (completing-read): Call completing-read-function.
6949
6950 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6951
6952 * xfaces.c (Fx_load_color_file):
6953 Read color file from absolute filename (bug#8250).
6954
6955 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6956
6957 * makefile.w32-in: Update dependencies.
6958
6959 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6960
6961 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6962
6963 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6964
6965 Fix more problems found by GCC 4.5.2's static checks.
6966
6967 * process.c (make_serial_process_unwind, send_process_trap):
6968 (sigchld_handler): Now static.
6969
6970 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6971 That way, the code declares only the vars that it needs.
6972 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6973 * s/cygwin.h (PTY_ITERATION): Likewise.
6974 * s/darwin.h (PTY_ITERATION): Likewise.
6975 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6976
6977 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6978 * process.c (allocate_pty): Don't declare stb unless it's needed.
6979
6980 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6981 (CONSTANTLIM): Remove; unused.
6982 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6983 Define only if needed.
6984
6985 * unexelf.c (unexec): Name an expression,
6986 to avoid gcc -Wbad-function-cast warning.
6987 Use a different way to cause a compilation error if anyone uses
6988 n rather than nn, a way that does not involve shadowing.
6989 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6990
6991 * deps.mk (unexalpha.o): Remove; unused.
6992
6993 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6994 * unexec.h: New file.
6995 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6996 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6997 Depend on unexec.h.
6998 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6999 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7000 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7001 Change as necessary to match prototype in unexec.h.
7002
7003 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7004 shadowing.
7005 (back_comment, skip_chars): Mark vars as initialized.
7006
7007 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7008 Rename locals to avoid shadowing.
7009
7010 * lread.c (read1): Rewrite so as not to use empty "else".
7011 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7012
7013 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7014
7015 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7016 warning when compiling print.c.
7017
7018 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7019 instead of using an uninitialized var.
7020 (font_sort_entities): Mark var as initialized.
7021
7022 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7023
7024 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7025 pointers to constants.
7026 (font_parse_fcname): Remove unused vars.
7027 (font_delete_unmatched): Now static.
7028 (font_get_spec): Remove; unused.
7029 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7030 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7031 Rename or move locals to avoid shadowing.
7032
7033 * fns.c (require_nesting_list, require_unwind): Now static.
7034 (Ffillarray): Rename locals to avoid shadowing.
7035
7036 * floatfns.c (domain_error2): Define only if needed.
7037 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7038
7039 * alloc.c (mark_backtrace): Move decl from here ...
7040 * lisp.h: ... to here, so that it can be checked.
7041
7042 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7043 (Fdefvar): Rewrite so as not to use empty "else".
7044 (lisp_indirect_variable): Name an expression,
7045 to avoid gcc -Wbad-function-cast warning.
7046 (Fdefvar): Rename locals to avoid shadowing.
7047
7048 * callint.c (quotify_arg, quotify_args): Now static.
7049 (Fcall_interactively): Rename locals to avoid shadowing.
7050 Use const pointer when appropriate.
7051
7052 * lisp.h (get_system_name, get_operating_system_release):
7053 Move decls here, to check interfaces.
7054 * process.c (get_operating_system_release): Move decl to lisp.h.
7055 * xrdb.c (get_system_name): Likewise.
7056 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7057 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7058 some of which prompt warnings from gcc -Wbad-function-cast.
7059 (Fformat_time_string, Fencode_time, Finsert_char):
7060 (Ftranslate_region_internal, Fformat):
7061 Rename or remove local vars to avoid shadowing.
7062 (Ftranslate_region_internal): Mark var as initialized.
7063
7064 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7065 avoid shadowing.
7066
7067 * lisp.h (eassert): Check that the argument compiles, even if
7068 ENABLE_CHECKING is not defined.
7069
7070 * data.c (Findirect_variable): Name an expression, to avoid
7071 gcc -Wbad-function-cast warning.
7072 (default_value, arithcompare, arith_driver, arith_error): Now static.
7073 (store_symval_forwarding): Rename local to avoid shadowing.
7074 (Fmake_variable_buffer_local, Fmake_local_variable):
7075 Mark variables as initialized.
7076 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7077
7078 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7079 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7080 Rename locals to avoid shadowing.
7081 (mark_stack): Move local variables into the #ifdef region where
7082 they're used.
7083 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7084 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7085 needed otherwise.
7086 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7087 (GC_STRING_CHARS): Remove; not used.
7088 (Fmemory_limit): Cast sbrk's returned value to char *.
7089
7090 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7091 avoids undefined behavior in theory.
7092
7093 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7094
7095 Use functions, not macros, for up- and down-casing (Bug#8254).
7096 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7097 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7098 to use the following functions instead of these macros.
7099 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7100 EMACS_INT, since callers assume the returned value fits in int.
7101 (upcase1): Likewise, for UPCASE_TABLE.
7102 (uppercasep, lowercasep, upcase): New static inline functions.
7103 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7104 the race-condition problem in the old DOWNCASE.
7105
7106 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7107 Rename locals to avoid shadowing.
7108 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7109 (regex_compile, re_search_2, re_match_2_internal):
7110 Remove unused local vars.
7111 (FREE_VAR): Rewrite so as not to use empty "else",
7112 which gcc can warn about.
7113 (regex_compile, re_match_2_internal): Mark locals as initialized.
7114 (RETALLOC_IF): Define only if needed.
7115 (WORDCHAR_P): Likewise. This one is never needed, but is used
7116 only in a comment talking about a compiler bug, so put inside
7117 the #if 0 of that comment.
7118 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7119 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7120 Remove; unused.
7121
7122 * search.c (boyer_moore): Rename locals to avoid shadowing.
7123 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7124 (PREV_CHAR_BOUNDARY): Likewise.
7125
7126 * search.c (simple_search): Remove unused var.
7127
7128 * dired.c (compile_pattern): Move decl from here ...
7129 * lisp.h: ... to here, so that it can be checked.
7130 (struct re_registers): New forward decl.
7131
7132 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7133
7134 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7135 All uses changed.
7136 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7137 Rename locals to avoid shadowing.
7138 (Fvertical_motion): Mark locals as initialized.
7139
7140 * casefiddle.c (casify_object, casify_region): Now static.
7141 (casify_region): Mark local as initialized.
7142
7143 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7144
7145 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7146 New macros, so that the caller can use some names other than
7147 gcpro1, gcpro2, etc.
7148 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7149 of the new macros.
7150 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7151 argument, for consistency with GCPRO2_VAR, etc: it is now the
7152 prefix of the variable, not the variable itself. All uses
7153 changed.
7154 * dired.c (directory_files_internal, file_name_completion):
7155 Rename locals to avoid shadowing.
7156
7157 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7158 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7159 dired.c's scmp function, had undefined behavior.
7160 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7161 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7162 * buffer.h: ... to here, because these macros use current_buffer,
7163 and the new implementation with inline functions needs to have
7164 current_buffer in scope now, rather than later when the macros
7165 are used.
7166 (downcase, upcase1): New static inline functions.
7167 (DOWNCASE, UPCASE1): Reimplement using these functions.
7168 This avoids undefined behavior in expressions like
7169 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7170 from race conditions in accessing the global variables
7171 case_temp1 and case_temp2.
7172 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7173 * lisp.h (case_temp1, case_temp2): Remove their decls.
7174 * character.h (ASCII_CHAR_P): Move from here ...
7175 * lisp.h: ... to here, so that the inline functions mentioned
7176 above can use them.
7177
7178 * dired.c (directory_files_internal_unwind): Now static.
7179
7180 * fileio.c (file_name_as_directory, directory_file_name):
7181 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7182 Now static.
7183 (file_name_as_directory): Use const pointers when appropriate.
7184 (Fexpand_file_name): Likewise. In particular, newdir might
7185 point at constant storage, so make it a const pointer.
7186 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7187 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7188 signedness issues.
7189 (Fset_file_times, Finsert_file_contents, auto_save_error):
7190 Rename locals to avoid shadowing.
7191
7192 * minibuf.c (choose_minibuf_frame_1): Now static.
7193 (Ftry_completion, Fall_completions): Rename or remove locals
7194 to avoid shadowing.
7195
7196 * marker.c (bytepos_to_charpos): Remove; unused.
7197
7198 * lisp.h (verify_bytepos, count_markers): New decls,
7199 so that gcc does not warn that these functions aren't declared.
7200
7201 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7202 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7203 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7204 (copy_text): Remove unused local var.
7205
7206 * filelock.c (within_one_second): Now static.
7207 (lock_file_1): Rename local to avoid shadowing.
7208
7209 * buffer.c (fix_overlays_before): Mark locals as initialized.
7210 (fix_start_end_in_overlays): Likewise. This function should be
7211 simplified by using pointers-to-pointers, but that's a different
7212 matter.
7213 (switch_to_buffer_1): Now static.
7214 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7215 (report_overlay_modification): Rename locals to avoid shadowing.
7216
7217 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7218 Fix pointer signedness issue.
7219 (sys_subshell): Mark local as volatile if checking for lint,
7220 to suppress a gcc -Wclobbered warning that does not seem to be right.
7221 (MAXPATHLEN): Define only if needed.
7222
7223 * process.c (serial_open, serial_configure): Move decls from here ...
7224 * systty.h: ... to here, so that they can be checked.
7225
7226 * fns.c (get_random, seed_random): Move extern decls from here ...
7227 * lisp.h: ... to here, so that they can be checked.
7228
7229 * sysdep.c (reset_io): Now static.
7230 (wait_for_termination_signal): Remove; unused.
7231
7232 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7233 (copy_keymap_item, append_key, push_text_char_description):
7234 Now static.
7235 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7236 (DENSE_TABLE_SIZE): Remove; unused.
7237 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7238 (describe_map_tree):
7239 Rename locals to avoid shadowing.
7240
7241 * keyboard.c: Declare functions static if they are not used elsewhere.
7242 (echo_char, echo_dash, cmd_error, top_level_2):
7243 (poll_for_input, handle_async_input): Now static.
7244 (read_char, kbd_buffer_get_event, make_lispy_position):
7245 (make_lispy_event, make_lispy_movement, apply_modifiers):
7246 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7247 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7248 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7249 (read_key_sequence, read_char): Mark locals as initialized.
7250 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7251
7252 * keyboard.h (make_ctrl_char): New decl.
7253 (mark_kboards): Move decl here ...
7254 * alloc.c (mark_kboards): ... from here.
7255
7256 * lisp.h (force_auto_save_soon): New decl.
7257
7258 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7259 (DEFINE_DUMMY_FUNCTION): New macro.
7260 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7261 Use it.
7262 (main): Add casts to avoid warnings
7263 if GCC considers string literals to be constants.
7264
7265 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7266
7267 * dbusbind.c: Pointer signedness fixes.
7268 (xd_signature, xd_append_arg, xd_initialize):
7269 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7270 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7271 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7272 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7273
7274 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7275 if GCC considers string literals to be constants.
7276 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7277
7278 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7279
7280 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7281 (print_preprocess, print_object): New macro to fix last change.
7282
7283 * print.c (print_preprocess): Don't forget font objects.
7284
7285 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7286
7287 * emacs.c (USAGE3): Doc fixes.
7288
7289 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7290
7291 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7292 structure.
7293
7294 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7295
7296 * lisp.h (VWindow_system, Qfile_name_history):
7297 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7298 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7299 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7300
7301 * w32select.c: Don't #include "keyboard.h".
7302 (run_protected): Add extern declaration for waiting_for_input.
7303
7304 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7305 * w32console.c (detect_input_pending, read_input_pending)
7306 (encode_terminal_code):
7307 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7308 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7309 (w32_system_caret_y, Qfile_name_history):
7310 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7311 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7312 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7313 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7314 * w32proc.c (Qlocal, report_file_error):
7315 * w32term.c (Vwindow_system, updating_frame):
7316 * w32uniscribe.c (initialized, uniscribe_font_driver):
7317 Remove unneeded extern declarations.
7318
7319 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7320
7321 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7322
7323 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7324
7325 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7326 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7327 These macros can no longer be used for assignment.
7328
7329 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7330 Assign struct members directly, instead of using BUF_BEGV etc.
7331 (record_buffer_markers, fetch_buffer_markers): New functions for
7332 recording and fetching special buffer markers.
7333 (set_buffer_internal_1, set_buffer_temp): Use them.
7334
7335 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7336
7337 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7338
7339 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7340 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7341
7342 * xdisp.c (hscroll_window_tree):
7343 (reconsider_clip_changes): Use PT instead of BUF_PT.
7344
7345 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7346
7347 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7348 $(EMACS_ROOT)/lib/intprops.h.
7349
7350 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7351
7352 Fix more problems found by GCC 4.5.2's static checks.
7353
7354 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7355 to unsigned char * to avoid compiler diagnostic.
7356 (xg_free_frame_widgets): Make it clear that a local variable is
7357 needed only if USE_GTK_TOOLTIP.
7358 (gdk_window_get_screen): Make it clear that this macro is needed
7359 only if USE_GTK_TOOLTIP.
7360 (int_gtk_range_get_value): New function, which avoids a diagnostic
7361 from gcc -Wbad-function-cast.
7362 (xg_set_toolkit_scroll_bar_thumb): Use it.
7363 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7364 diagnostic from gcc -Wbad-function-cast.
7365 (get_utf8_string, xg_get_file_with_chooser):
7366 Rename locals to avoid shadowing.
7367 (create_dialog): Move locals to avoid shadowing.
7368
7369 * xgselect.c (xg_select): Remove unused var.
7370
7371 * image.c (four_corners_best): Mark locals as initialized.
7372 (gif_load): Initialize transparent_p to zero (Bug#8238).
7373 Mark another local as initialized.
7374 (my_png_error, my_error_exit): Mark with NO_RETURN.
7375
7376 * image.c (clear_image_cache): Now static.
7377 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7378 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7379 (x_edge_detection): Remove unnecessary cast that
7380 gcc -Wbad-function-cast diagnoses.
7381 (gif_load): Fix pointer signedness.
7382 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7383 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7384
7385 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7386
7387 Improve quality of tests for time stamp overflow.
7388 For example, without this patch (encode-time 0 0 0 1 1
7389 1152921504606846976) returns the obviously-bogus value (-948597
7390 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7391 reports time overflow. See
7392 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7393 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7394 * editfns.c: Include limits.h and intprops.h.
7395 (TIME_T_MIN, TIME_T_MAX): New macros.
7396 (time_overflow): Move earlier, to before first use.
7397 (hi_time, lo_time): New functions, for an accurate test for
7398 out-of-range times.
7399 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7400 (Fget_internal_run_time): Don't assume time_t fits in int.
7401 (make_time): Use list2 instead of Fcons twice.
7402 (Fdecode_time): More accurate test for out-of-range times.
7403 (check_tm_member): New function.
7404 (Fencode_time): Use it, to test for out-of-range times.
7405 (lisp_time_argument): Don't rely on undefined left-shift and
7406 right-shift behavior when checking for time stamp overflow.
7407
7408 * editfns.c (time_overflow): New function, refactoring common code.
7409 (Fformat_time_string, Fdecode_time, Fencode_time):
7410 (Fcurrent_time_string): Use it.
7411
7412 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7413 * dired.c (make_time): Move to ...
7414 * editfns.c (make_time): ... here.
7415 * systime.h: Note the move.
7416
7417 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7418
7419 * fringe.c (update_window_fringes): Remove unused variables.
7420
7421 * unexmacosx.c (copy_data_segment): Also copy __got section.
7422 (Bug#8223)
7423
7424 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7425
7426 * termcap.c [MSDOS]: Include "msdos.h".
7427 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7428 Constify `char *' arguments and their references according to
7429 prototypes in tparam.h.
7430
7431 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7432
7433 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7434 Adapt all references accordingly.
7435
7436 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7437
7438 2011-03-11 Tom Tromey <tromey@redhat.com>
7439
7440 * buffer.c (syms_of_buffer): Remove obsolete comment.
7441
7442 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7443
7444 * termhooks.h (encode_terminal_code): Declare prototype.
7445
7446 * msdos.c (encode_terminal_code): Don't declare prototype.
7447
7448 * term.c (encode_terminal_code): Now external again, used by
7449 w32console.c and msdos.c.
7450
7451 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7452 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7453
7454 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7455
7456 Fix some minor problems found by GCC 4.5.2's static checks.
7457
7458 * fringe.c (update_window_fringes): Mark locals as initialized
7459 (Bug#8227).
7460 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7461
7462 * alloc.c (mark_fringe_data): Move decl from here ...
7463 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7464 to check its interface.
7465 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7466
7467 * fontset.c (free_realized_fontset): Now static.
7468 (Fset_fontset_font): Rename local to avoid shadowing.
7469 (fontset_font): Mark local as initialized.
7470 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7471
7472 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7473
7474 * xselect.c (x_disown_buffer_selections): Remove; not used.
7475 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7476 (x_own_selection, Fx_disown_selection_internal): Rename locals
7477 to avoid shadowing.
7478 (x_handle_dnd_message): Remove local to avoid shadowing.
7479
7480 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7481 so that the caller can use some name other than gcpro1.
7482 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7483 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7484 (Fx_backspace_delete_keys_p):
7485 Use them to avoid shadowing, and rename vars to avoid shadowing.
7486 (x_decode_color, x_set_name, x_window): Now static.
7487 (Fx_create_frame): Add braces to silence GCC warning.
7488 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7489 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7490 Remove unused locals.
7491 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7492 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7493 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7494 macros.
7495
7496 * xterm.h (x_mouse_leave): New decl.
7497
7498 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7499 Remove unused functions.
7500 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7501 (x_calc_absolute_position): Now static.
7502 (XTread_socket): Don't define label "out" unless it's used.
7503 Don't declare local "event" unless it's used.
7504 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7505 unless they are used.
7506 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7507 (x_fatal_error_signal): Remove; not used.
7508 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7509 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7510 (x_error_catcher, x_connection_closed, x_error_handler):
7511 (x_error_quitter, xembed_send_message, x_iconify_frame):
7512 (my_log_handler): Rename locals to avoid shadowing.
7513 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7514 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7515
7516 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7517 Rename or move locals to avoid shadowing.
7518 (tty_defined_color, merge_face_heights): Now static.
7519 (free_realized_faces_for_fontset): Remove; not used.
7520 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7521 does not deduce is never used uninitialized.
7522 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7523 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7524
7525 * terminal.c (store_terminal_param): Now static.
7526
7527 * xmenu.c (menu_highlight_callback): Now static.
7528 (set_frame_menubar): Remove unused local.
7529 (xmenu_show): Rename parameter to avoid shadowing.
7530 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7531 since they might point to immutable storage.
7532 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7533 since it's unused otherwise.
7534
7535 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7536 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7537 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7538 avoids a gcc -Wuninitialized diagnostic.
7539 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7540 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7541 does not deduce are never used uninitialized.
7542
7543 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7544
7545 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7546 * window.c (window_loop, size_window):
7547 (run_window_configuration_change_hook, enlarge_window): Likewise.
7548
7549 * window.c (display_buffer): Now static.
7550 (size_window): Mark variables that gcc -Wuninitialized
7551 does not deduce are never used uninitialized.
7552 * window.h (check_all_windows): New decl, to forestall
7553 gcc -Wmissing-prototypes diagnostic.
7554 * dispextern.h (bidi_dump_cached_states): Likewise.
7555
7556 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7557 shadowing.
7558 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7559 Include <limits.h>.
7560 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7561 and to avoid gcc -Wuninitialized warning.
7562 (load_charset_map): Mark variables that gcc -Wuninitialized
7563 does not deduce are never used uninitialized.
7564 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7565
7566 * coding.c (coding_set_source, coding_set_destination):
7567 Use "else { /* comment */ }" rather than "else /* comment */;"
7568 for clarity, and to avoid gcc -Wempty-body warning.
7569 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7570 a block, when the outer 'i' will do.
7571 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7572 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7573 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7574 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7575 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7576 Rename locals to avoid shadowing.
7577 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7578 * coding.c (emacs_mule_char, encode_invocation_designation):
7579 Now static, since they're not used elsewhere.
7580 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7581 (decode_coding_object, encode_coding_object, detect_coding_system):
7582 (decode_coding_emacs_mule): Mark variables that gcc
7583 -Wuninitialized does not deduce are never used uninitialized.
7584 (detect_coding_iso_2022): Initialize a local variable that might
7585 be used uninitialized. Leave a FIXME because it's not clear that
7586 this initialization is needed. (Bug#8211)
7587 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7588 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7589 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7590 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7591 Remove unused macros.
7592
7593 * category.c (hash_get_category_set): Remove unused local var.
7594 (copy_category_table): Now static, since it's not used elsewhere.
7595 * character.c (string_count_byte8): Likewise.
7596
7597 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7598 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7599
7600 * chartab.c (copy_sub_char_table): Now static, since it's not used
7601 elsewhere.
7602 (sub_char_table_ref_and_range, char_table_ref_and_range):
7603 Rename locals to avoid shadowing.
7604 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7605
7606 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7607 (BIDI_BOB): Remove unused macro.
7608
7609 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7610 deduce are never used uninitialized.
7611 * term.c (encode_terminal_code): Likewise.
7612
7613 * term.c (encode_terminal_code): Now static. Remove unused local.
7614
7615 * tparam.h: New file.
7616 * term.c, tparam.h: Include it.
7617 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7618 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7619 Move these decls to tparam.h, and make them agree with what
7620 is actually in tparam.c. The previous trick of using incompatible
7621 decls in different modules does not conform to the C standard.
7622 All callers of tparam changed to use tparam's actual API.
7623 * tparam.c (tparam1, tparam, tgoto):
7624 Use const pointers where appropriate.
7625
7626 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7627 * cm.h (struct cm): Likewise.
7628 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7629 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7630 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7631 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7632 (turn_on_face, init_tty): Likewise.
7633 * termchar.h (struct tty_display_info): Likewise.
7634
7635 * term.c (term_mouse_position): Rename local to avoid shadowing.
7636
7637 * alloc.c (mark_ttys): Move decl from here ...
7638 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7639
7640 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7641
7642 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7643
7644 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7645
7646 * search.c (compile_pattern_1): Remove argument regp, unused since
7647 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7648 (compile_pattern): Don't pass it.
7649
7650 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7651
7652 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7653 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7654 for ! HAVE_GTK3.
7655 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7656
7657 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7658
7659 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7660 gdk_window_get_screen, gdk_window_get_geometry,
7661 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7662 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7663 (xg_get_pixbuf_from_pixmap): New function.
7664 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7665 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7666 Call xg_get_pixbuf_from_pixmap instead of
7667 gdk_pixbuf_get_from_drawable.
7668 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7669 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7670 (xg_check_special_colors): Use GtkStyleContext and its functions
7671 for HAVE_GTK3.
7672 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7673 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7674 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7675 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7676 Call gtk_widget_get_preferred_size.
7677 (xg_frame_resized): gdk_window_get_geometry only takes 5
7678 parameters.
7679 (xg_win_to_widget, xg_event_is_for_menubar):
7680 Call gdk_x11_window_lookup_for_display.
7681 (xg_set_widget_bg): New function.
7682 (delete_cb): New function.
7683 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7684 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7685 (xg_set_background_color): Call xg_set_widget_bg.
7686 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7687 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7688 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7689 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7690 if ! HAVE_GTK3.
7691 (update_frame_tool_bar): Call gtk_widget_hide.
7692 (xg_initialize): Use GDK_KEY_g.
7693
7694 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7695 if ! HAVE_GTK3
7696 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7697
7698 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7699 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7700 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7701
7702 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7703
7704 * w32xfns.c (select_palette): Check success of RealizePalette against
7705 GDI_ERROR, not zero.
7706
7707 See ChangeLog.11 for earlier changes.
7708
7709 ;; Local Variables:
7710 ;; coding: utf-8
7711 ;; End:
7712
7713 Copyright (C) 2011 Free Software Foundation, Inc.
7714
7715 This file is part of GNU Emacs.
7716
7717 GNU Emacs is free software: you can redistribute it and/or modify
7718 it under the terms of the GNU General Public License as published by
7719 the Free Software Foundation, either version 3 of the License, or
7720 (at your option) any later version.
7721
7722 GNU Emacs is distributed in the hope that it will be useful,
7723 but WITHOUT ANY WARRANTY; without even the implied warranty of
7724 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7725 GNU General Public License for more details.
7726
7727 You should have received a copy of the GNU General Public License
7728 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.