1 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3 * data.c (Fdefalias): Return `symbol' (bug#11686).
5 2012-06-18 Martin Rudalics <rudalics@gmx.at>
7 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
8 gets killed during executing of this function (Bug#11665).
9 Try to always return Qt when the buffer has been actually killed.
10 (Vkill_buffer_query_functions): In doc-string say that functions
11 run by this hook should not change the current buffer.
13 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
15 Fix recently-introduced process.c problems found by static checking.
16 * process.c (write_queue_push, write_queue_pop, send_process):
17 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
18 (write_queue_pop): Fix pointer signedness problem.
19 (send_process): Remove unused local.
21 2012-06-17 Chong Yidong <cyd@gnu.org>
23 * xdisp.c (redisplay_internal): No need to redisplay terminal
24 frames that are not on top.
26 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
28 * process.c (make_process): Initialize write_queue.
29 (write_queue_push, write_queue_pop): New functions.
30 (send_process): Use them to maintain correct ordering of process
33 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
35 * lisp.h (eassert): Assume C89 or later.
36 This removes the need for CHECK.
37 (CHECK): Remove. Its comments about always evaluating its
38 argument were confusing, as 'eassert' typically does not evaluate
41 * coding.c (produce_chars): Use ptrdiff_t, not int.
43 * xterm.c (x_draw_underwave): Check for integer overflow.
44 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
46 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
48 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
49 referenced (Bug#11583).
51 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
53 Implement wave-style variant of underlining.
54 * dispextern.h (face_underline_type): New enum.
55 (face): Add field for underline type.
56 * nsterm.m (ns_draw_underwave): New function.
57 (ns_draw_text_decoration): Use it.
58 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
60 (x_draw_glyph_string): Use them.
61 * xfaces.c (Qline, Qwave): New Lisp objects.
62 (check_lface_attrs, merge_face_ref)
63 (Finternal_set_lisp_face_attribute, realize_x_face):
64 Handle wave-style underline face attributes.
65 * xterm.c (x_draw_underwave): New function.
66 (x_draw_glyph_string): Use it.
68 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
70 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
71 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
72 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
73 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
74 ($(BLD)/w32select.$(O)): Update dependencies.
76 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
78 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
79 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
80 * character.c (_fetch_multibyte_char_p): Remove.
81 * alloc.c: Include "character.h" before "buffer.h".
84 * bytecode.c: Likewise.
85 * callint.c: Likewise.
86 * callproc.c: Likewise.
87 * casefiddle.c: Likewise.
88 * casetab.c: Likewise.
89 * category.c: Likewise.
92 * composite.c: Likewise.
94 * dispnew.c: Likewise.
97 * editfns.c: Likewise.
100 * filelock.c: Likewise.
102 * fontset.c: Likewise.
103 * fringe.c: Likewise.
104 * indent.c: Likewise.
105 * insdel.c: Likewise.
106 * intervals.c: Likewise.
107 * keyboard.c: Likewise.
108 * keymap.c: Likewise.
110 * macros.c: Likewise.
111 * marker.c: Likewise.
112 * minibuf.c: Likewise.
114 * nsmenu.m: Likewise.
116 * process.c: Likewise.
118 * region-cache.c: Likewise.
119 * search.c: Likewise.
120 * syntax.c: Likewise.
122 * textprop.c: Likewise.
124 * unexsol.c: Likewise.
125 * w16select.c: Likewise.
126 * w32fns.c: Likewise.
127 * w32menu.c: Likewise.
128 * window.c: Likewise.
133 * xselect.c: Likewise.
135 2012-06-16 Eli Zaretskii <eliz@gnu.org>
137 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
138 If all the glyphs of the glyph row came from strings, and we have no
139 cursor positioning clues, put the cursor on the first glyph of the
141 (handle_face_prop): Use chunk-relative overlay string index when
142 indexing into it->string_overlays array. (Bug#11653)
143 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
144 the rightmost. (Bug#11720)
146 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
148 * category.h (CHAR_HAS_CATEGORY): Define as inline.
149 (CATEGORY_MEMBER): Enforce 1/0 value.
150 * category.c (_temp_category_set): Remove.
152 2012-06-16 Eli Zaretskii <eliz@gnu.org>
154 * window.c (Fdelete_other_windows_internal)
155 (Fdelete_window_internal): Don't access frame's mouse highlight
156 info of the initial frame. (Bug#11677)
158 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
160 * .gdbinit (xgetint): Fix recently-introduced paren typo.
161 Assume USE_2_TAGS_FOR_INTS.
162 (xreload): Adjust $tagmask width to match recent lisp.h change.
164 Simplify lisp.h in minor ways that should not affect code.
165 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
166 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
167 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
168 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
169 (INTTYPEBITS): New macro, for clarity.
170 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
171 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
172 Simplify now that USE_LSB_TAG is always defined.
173 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
174 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
176 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
178 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
180 2012-06-13 Glenn Morris <rgm@gnu.org>
182 * s/bsd-common.h (BSD4_3):
183 * s/usg5-4-common.h (USG5_4): No longer define; unused.
185 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
187 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
190 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
192 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
193 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
194 * alloc.c (widen_to_Lisp_Object): Remove.
195 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
196 * frame.c (delete_frame): Remove outdated comment.
197 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
199 (Fw32_unregister_hot_key): Likewise.
200 (Fw32_toggle_lock_key): Likewise.
201 * w32menu.c (add_menu_item): Likewise.
202 (w32_menu_display_help): Use XIL instead of checking
204 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
205 (init_heap): Likewise.
206 * w32term.c (w32_read_socket): Update comment.
208 2012-06-13 Glenn Morris <rgm@gnu.org>
210 * s/usg5-4-common.h, src/s/unixware.h:
211 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
213 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
215 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
217 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
218 * alloc.c (make_number) [!defined make_number]:
219 Remove, as lisp.h always defines this now.
220 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
221 (roundup_size): Verify that it is a power of 2.
222 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
223 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
224 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
225 -DUSE_LSB_TAG=0, to override the automatically-selected default.
226 USE_LSB_TAG now is always defined to be either 0 or 1.
228 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
229 code works fine either way, and efficiency is not a concern here,
230 as the union type is for debugging, not for production.
231 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
232 Use an inline function on all platforms when using the union type,
233 since this is simpler and 'static inline' can be used portably
235 (LISP_INITIALLY_ZERO): New macro.
236 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
237 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
239 2012-06-12 Glenn Morris <rgm@gnu.org>
241 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
243 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
245 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
246 Move BROKEN_SIGIO to configure.
248 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
249 Move NO_TERMIO to configure.
251 2012-06-12 Chong Yidong <cyd@gnu.org>
253 * image.c (imagemagick_load_image): Use MagickFlattenImage if
254 MagickMergeImageLayers is undefined. Use pixel pusher loop if
255 MagickExportImagePixels is undefined.
257 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
259 * image.c (imagemagick_load_image): Remove unused label.
261 2012-06-11 Glenn Morris <rgm@gnu.org>
263 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
264 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
265 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
266 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
268 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
270 * alloc.c (make_byte_code): New function.
271 (Fmake_byte_code): Use it. Don't purify here.
272 * lread.c (read1): Use it as well to avoid extra allocation.
274 2012-06-11 Chong Yidong <cyd@gnu.org>
276 * image.c (imagemagick_load_image): Implement transparency.
278 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
280 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
281 account for preceding backslashes. (Bug#11663)
283 2012-06-09 Chong Yidong <cyd@gnu.org>
285 * term.c: Support italics in capable terminals (Bug#9652).
286 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
287 (turn_on_face): Output using TS_enter_italic_mode if available.
288 Don't handle unused blinking and alt-charset cases.
289 (turn_off_face): Handle italic case; discard unused tty_blinking_p
290 and tty_alt_charset_p cases.
291 (tty_capable_p, init_tty): Support italics.
293 * termchar.h (struct tty_display_info): Add field for italics.
294 Remove unused blink field.
296 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
299 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
300 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
301 tty_alt_charset_p. Add tty_italic_p.
303 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
305 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
306 dbus_type_is_basic if available.
307 (xd_extract_signed, xd_extract_unsigned): Rename from
308 extract_signed and extract_unsigned, respectively. Adapt callers.
310 2012-06-09 Chong Yidong <cyd@gnu.org>
312 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
314 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
317 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
319 * xdisp.c (vmessage): Treat frame message as multibyte.
320 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
321 would generate the diagnostic "Making \302\247 buffer-local while
324 2012-06-08 Eli Zaretskii <eliz@gnu.org>
326 * dispnew.c (showing_window_margins_p): Undo last change, which
327 was done due to an inadvertent commit.
328 (adjust_frame_glyphs_for_frame_redisplay): Do call
329 showing_window_margins_p.
331 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
333 * eval.c (Fmake_var_non_special): New primitive.
334 (syms_of_eval): Defsubr it.
335 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
337 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
339 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
340 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
342 2012-06-08 Eli Zaretskii <eliz@gnu.org>
344 * alloc.c (allocate_vectorlike): Fix last change.
346 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
348 Block-based vector allocation of small vectors.
349 * lisp.h (struct vectorlike_header): New field `nbytes',
350 adjust comment accordingly.
351 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
352 to denote vector blocks. Adjust users (live_vector_p,
353 mark_maybe_pointer, valid_lisp_object_p) accordingly.
354 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
355 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
356 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
357 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
358 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
359 (roundup_size): New constant.
360 (struct vector_block): New data type.
361 (vector_blocks, vector_free_lists, zero_vector): New variables.
362 (all_vectors): Rename to `large_vectors'.
363 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
364 (sweep_vectors): New functions.
365 (allocate_vectorlike): Return `zero_vector' as the only vector of
366 0 items. Allocate new vector from block if vector size is less than
367 or equal to VBLOCK_BYTES_MAX.
368 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
369 (init_alloc_once): Add call to init_vectors.
371 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
373 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
375 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
377 * doprnt.c (doprnt): Truncate multibyte char correctly.
378 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
379 would mishandle a string argument "Xc" if X was a multibyte
380 character of length 2: it would truncate after X's first byte
381 rather than including all of X.
383 2012-06-06 Chong Yidong <cyd@gnu.org>
385 * buffer.c (word_wrap): Doc fix.
387 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
389 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
391 2012-06-03 Glenn Morris <rgm@gnu.org>
393 * xdisp.c (tool-bar-style): Doc fix.
395 2012-06-03 Ulrich Müller <ulm@gentoo.org>
397 * Makefile.in (PAXCTL): Define.
398 (temacs$(EXEEXT)): Disable memory randomization for the temacs
399 binary via PaX flags if the paxctl utility is available.
400 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
401 Restore PaX flags to their default. (Bug#11398)
403 2012-06-03 Chong Yidong <cyd@gnu.org>
405 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
408 2012-06-03 Chong Yidong <cyd@gnu.org>
410 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
411 (note_mode_line_or_margin_highlight): If there is no help echo,
412 use mode-line-default-help-echo. Handle the case where the mouse
413 position is past the end of the mode line string.
415 * buffer.c (buffer_local_value_1): New function, split from
416 Fbuffer_local_value; can return Qunbound.
417 (Fbuffer_local_value): Use it.
418 (Vmode_line_format): Docstring tweaks.
420 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
422 * sysdep.c (system_process_attributes): Improve comment.
424 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
426 * keyboard.c: Export real-this-command to Elisp.
427 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
428 and DEFVAR it. Update all users.
430 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
432 * minibuf.c (Fassoc_string): Remove duplicate declaration.
434 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
435 Convert pctcpu and pctmem to Lisp float properly.
436 Let the compiler fold better, as 100.0/0x8000 is exact.
438 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
440 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
443 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
445 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
447 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
449 For a 'struct window', replace some Lisp_Object fields to
450 bitfields where appropriate, remove unused fields.
451 * window.h (struct window): Remove unused 'last_mark_x' and
452 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
453 change it's type from Lisp_Object to bitfield.
454 Change type of 'force_start', 'optional_new_start',
455 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
456 fields from Lisp_Object to bitfield. Adjust users accordingly.
458 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
460 Pacify gcc -Wdouble-precision when using Xaw.
461 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
462 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
463 Use 'float' consistently, rather than 'float' in most places
464 and 'double' in a couple of places.
466 2012-05-31 Eli Zaretskii <eliz@gnu.org>
468 * xdisp.c (handle_stop): Detect whether we have overlay strings
469 loaded by testing it->current.overlay_string_index to be
470 non-negative, instead of checking whether n_overlay_strings is
471 positive. (Bug#11587)
473 2012-05-31 Chong Yidong <cyd@gnu.org>
475 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
477 * doc.c (Fsubstitute_command_keys): Doc fix.
479 2012-05-31 Eli Zaretskii <eliz@gnu.org>
481 * search.c (search_buffer): Remove calls to
482 r_alloc_inhibit_buffer_relocation, as it is now called by
483 maybe_unify_char, which was the cause of relocation of buffer text
486 2012-05-31 Eli Zaretskii <eliz@gnu.org>
488 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
489 for the duration of call to load_charset, to avoid problems with
490 callers of maybe_unify_char that access buffer text through C
493 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
494 decrement the inhibition flag, instead of just setting or
497 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
499 Remove obsolete '#define static' cruft.
500 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
501 This #undef was "temporary" in 2000; it is no longer needed
502 now that '#define static' has gone away.
503 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
504 (gray_bitmap_bits): Remove; no longer needed.
505 All uses replaced with definiens.
506 * xterm.c: Include "bitmaps/gray.xbm".
508 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
510 Clean up __executable_start, monstartup when --enable-profiling.
511 The following changes affect the code only when profiling.
512 * dispnew.c (__executable_start): Rename from safe_bcopy.
513 Define only on platforms that need it.
514 * emacs.c: Include <sys/gmon.h> when profiling.
515 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
516 (__executable_start): Remove decl, since lisp.h does it now.
517 (safe_bcopy): Remove decl; no longer has that name.
518 (main): Coalesce #if into single bit of code, for simplicity.
519 Cast pointers to uintptr_t, since standard libraries want integers
521 * lisp.h (__executable_start): New decl.
523 2012-05-31 Glenn Morris <rgm@gnu.org>
525 * image.c (Fimagemagick_types): Doc fix.
527 2012-05-30 Jim Meyering <meyering@redhat.com>
529 * callproc.c (Fcall_process_region): Include directory component
530 in mkstemp error message (Bug#11586).
532 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
534 * alloc.c, lisp.h (make_pure_vector): Now static.
536 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
538 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
540 (Fautoload): Do the hash-doc more carefully.
541 * data.c (Fdefalias): Purify definition, except for keymaps.
542 (Qdefun): Move from eval.c.
543 * lisp.h (Qdefun): Remove.
544 * lread.c (read1): Tiny simplification.
546 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
548 Do not create empty overlays with the evaporate property (Bug#9642).
549 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
550 Bug#9642, but explicitly check that the buffer the overlay would
551 be moved to is live and rearrange lines to make sure that errors
552 will not put the overlay in an inconsistent state.
553 (Fdelete_overlay): Cosmetics.
555 2012-05-28 Eli Zaretskii <eliz@gnu.org>
557 * w32term.c (my_bring_window_to_top): New function.
558 (x_raise_frame): Use handle returned by DeferWindowPos, which
559 could be different from the original one.
560 Call my_bring_window_to_top instead of my_set_foreground_window.
563 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
564 by calling BringWindowToTop.
566 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
567 (WM_EMACS_END): Increase by one.
569 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
571 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
572 This avoids undefined behavior that might cause the eassert
573 to not catch an out-of-range value.
575 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
577 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
580 2012-05-27 Eli Zaretskii <eliz@gnu.org>
582 * bidi.c (bidi_mirror_char): Fix last change.
584 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
586 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
587 when referring to sectname field in printf format.
589 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
591 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
592 Only r_alloc_inhibit_buffer_relocation needed to be added;
593 the others were already declared.
595 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
596 before checking whether it's out of range. Put the check inside
598 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
600 2012-05-27 Ken Brown <kbrown@cornell.edu>
602 * callproc.c (Fcall_process): Restore a line that was accidentally
603 commented out in the 2011-02-13 change (bug#11547).
605 2012-05-27 Eli Zaretskii <eliz@gnu.org>
607 * lisp.h [REL_ALLOC]: Add prototypes for external functions
610 * buffer.c [REL_ALLOC]: Remove prototypes of
611 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
612 they are now on lisp.h.
614 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
616 * search.c (search_buffer): Use it to inhibit relocation of buffer
617 text while re_search_2 is doing its job, because re_search_2 is
618 passed C pointers to buffer text. (Bug#11519)
620 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
623 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
624 state after an additional call to move_it_in_display_line_to, keep
625 the values of it->max_ascent and it->max_descent found for the
627 (pos_visible_p): Revert the comparison against bottom_y to what it
628 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
631 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
633 Fix coding-related core dumps with gcc -ftrapv.
634 The code was computing A - B, where A and B are pointers, and B is
635 random garbage. This can lead to core dumps on platforms that
636 have special pointer registers, and it also leads to core dumps on
637 x86-64 when compiled with gcc -ftrapv. The fix is to compute
638 A - B only when B is initialized properly.
639 * coding.c (coding_set_source, coding_set_destination): Return void.
640 (coding_change_source, coding_change_destinations): New functions,
641 with the old behaviors of coding_set_source and coding_set_destination.
642 All callers that need an offset changed to use these new functions.
644 2012-05-26 Glenn Morris <rgm@gnu.org>
646 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
648 2012-05-26 Eli Zaretskii <eliz@gnu.org>
650 Extend mouse support on W32 text-mode console.
651 * xdisp.c (draw_row_with_mouse_face):
652 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
654 * w32console.c: Include window.h.
655 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
657 (initialize_w32_display): Initialize mouse-highlight data.
659 * w32inevt.c: Include termchar.h and window.h.
660 (do_mouse_event): Support mouse-autoselect-window. When the mouse
661 moves, call note_mouse_highlight. If help_echo changed, call
662 gen_help_event to produce help-echo message in the echo area.
663 Call clear_mouse_face if mouse_face_hidden is set in the mouse
666 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
668 * lread.c (read1): Simplify slightly to avoid an overflow warning
669 with GCC 4.7.0 on x86-64.
671 2012-05-26 Eli Zaretskii <eliz@gnu.org>
673 * bidi.c (bidi_mirror_char): Revert last change: an int is
674 definitely wide enough here.
676 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
678 Fix integer width and related bugs (Bug#9874).
679 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
680 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
681 (string_bytes, check_sblock, allocate_string_data):
682 (compact_small_strings, Fmake_bool_vector, make_string)
683 (make_unibyte_string, make_multibyte_string)
684 (make_string_from_bytes, make_specified_string)
685 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
686 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
689 (allocate_pseudovector):
690 Use int, not EMACS_INT, where int is wide enough.
691 (inhibit_garbage_collection, Fgarbage_collect):
692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
693 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
694 int might not be wide enough.
695 (bidi_cache_search, bidi_cache_find, bidi_init_it)
696 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
697 (bidi_at_paragraph_end, bidi_find_paragraph_start)
698 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
699 (bidi_level_of_next_char, bidi_move_to_visually_next):
700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
701 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
702 (Fkill_buffer, Fset_buffer_major_mode)
703 (advance_to_char_boundary, Fbuffer_swap_text)
704 (Fset_buffer_multibyte, overlays_at, overlays_in)
705 (overlay_touches_p, struct sortvec, record_overlay_string)
706 (overlay_strings, recenter_overlay_lists)
707 (adjust_overlays_for_insert, adjust_overlays_for_delete)
708 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
709 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
710 (Foverlay_recenter, last_overlay_modification_hooks_used)
711 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
713 (validate_region): Omit unnecessary test for b <= e,
714 since that's guaranteed by the previous test.
715 (adjust_overlays_for_delete): Avoid pos + length overflow.
716 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
717 (report_overlay_modification):
718 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
719 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
720 Omit pointer cast, which isn't needed anyway, and doesn't work
721 after the EMACS_INT -> ptrdiff_t change.
722 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
723 * buffer.h: Adjust decls to match defn changes elsewhere.
724 (struct buffer_text, struct buffer):
725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
726 Use EMACS_INT, not int, where int might not be wide enough.
727 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
728 not int, to avoid needless 32-bit limit on 64-bit hosts.
729 (exec_byte_code): Use tighter memory-full test, one that checks
730 for alloca overflow. Don't compute the address of the object just
731 before an array, as that's not portable. Use EMACS_INT, not
732 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
733 * callint.c (Fcall_interactively):
734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
735 * callproc.c (call_process_kill, Fcall_process):
736 Don't assume pid_t fits into an Emacs fixnum.
737 (call_process_cleanup, Fcall_process, child_setup):
738 Don't assume pid_t fits into int.
739 (call_process_cleanup, Fcall_process, delete_temp_file)
740 (Fcall_process_region):
741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
742 (Fcall_process): Simplify handling of volatile integers.
743 Use int, not EMACS_INT, where int will do.
744 * casefiddle.c (casify_object, casify_region, operate_on_word)
745 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
747 (casify_object): Avoid integer overflow when overallocating buffer.
748 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
749 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
750 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
751 * category.h (CATEGORYP): Don't assume arg is nonnegative.
752 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
753 integers are now checked earlier. All uses replaced with XINT.
755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
756 For CCL_MapSingle, check that content and value are in int range.
757 (ccl_driver, Fregister_code_conversion_map):
758 Check that Vcode_version_map_vector is a vector.
759 (resolve_symbol_ccl_program): Check that vector header is in range.
760 Always copy the vector, so that we can check its contents reliably
761 now rather than having to recheck each instruction as it's being
762 executed. Check that vector words fit in 'int'.
763 (ccl_get_compiled_code, Fregister_ccl_program)
764 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
765 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
766 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
767 contents are in range.
768 (Fccl_execute_on_string): Check that status is in range.
769 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
770 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
771 Accept and return EMACS_INT, not int, because callers can pass values
773 (c_string_width, strwidth, lisp_string_width, chars_in_text)
774 (multibyte_chars_in_text, parse_str_as_multibyte)
775 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
776 (str_as_unibyte, str_to_unibyte, string_count_byte8)
777 (string_escape_byte8, Fget_byte):
778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
779 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
780 avoid mishandling large integers.
781 * character.h: Adjust decls to match defn changes elsewhere.
782 * charset.c (load_charset_map_from_file, find_charsets_in_text)
783 (Ffind_charset_region):
784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
785 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
786 (load_charset_map_from_vector, Fdefine_charset_internal):
787 Don't assume fixnum fits in int.
788 (load_charset_map_from_vector, Fmap_charset_chars):
789 Remove now-unnecessary CHECK_NATNUMs.
790 (Fdefine_charset_internal): Check ranges here, more carefully.
791 Don't rely on undefined behavior with signed left shift overflow.
792 Don't assume unsigned int fits into fixnum, or that fixnum fits
793 into unsigned int. Don't require max_code to be a valid fixnum;
794 that's not true for gb10830 4-byte on a 32-bit host. Allow
795 invalid_code to be a cons, for the same reason. Require code_offset
796 to be a character. Avoid int overflow if max_char is close
798 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
799 this is intended anyway and avoids some undefined behavior.
800 (load_charset_map): Pass unsigned, not int, as 2nd arg of
801 INDEX_TO_CODE_POINT, as that's what it expects.
802 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
803 * charset.h (DECODE_CHAR): Return int, not unsigned;
804 this is what was intended anyway, and it avoids undefined behavior.
805 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
806 integer-overflow issues.
807 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
808 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
809 where the argument is EMACS_INT, and this behavior is not intended.
810 * chartab.c (Fmake_char_table, Fset_char_table_range)
811 (uniprop_get_decoder, uniprop_get_encoder):
812 Don't assume fixnum fits in int.
813 * cmds.c (move_point): New function, that does the gist of
814 Fforward_char and Fbackward_char, but does so while checking
815 for integer overflow more accurately.
816 (Fforward_char, Fbackward_char): Use it.
817 (Fforward_line, Fend_of_line, internal_self_insert)
818 (internal_self_insert):
819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
820 Fix a FIXME, by checking for integer overflow when calculating
821 target_clm and actual_clm.
822 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
823 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
824 (ASSURE_DESTINATION, coding_alloc_by_realloc)
825 (coding_alloc_by_making_gap, alloc_destination)
826 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
827 (encode_coding_utf_16, detect_coding_emacs_mule)
828 (decode_coding_emacs_mule, encode_coding_emacs_mule)
829 (detect_coding_iso_2022, decode_coding_iso_2022)
830 (encode_invocation_designation, encode_designation_at_bol)
831 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
832 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
833 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
834 (encode_coding_ccl, encode_coding_raw_text)
835 (detect_coding_charset, decode_coding_charset)
836 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
837 (produce_composition, produce_charset, produce_annotation)
838 (decode_coding, handle_composition_annotation)
839 (handle_charset_annotation, consume_chars, decode_coding_gap)
840 (decode_coding_object, encode_coding_object, detect_coding_system)
841 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
842 (code_convert_region, code_convert_string)
843 (Fdefine_coding_system_internal)
844 (coding_set_source, coding_set_destination):
845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
846 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
847 (Fdefine_coding_system_internal):
848 Don't assume fixnums fit in int.
849 (decode_coding_gap, decode_coding_object, encode_coding_object)
850 (Fread_coding_system, Fdetect_coding_region)
851 (Funencodable_char_position, Fcheck_coding_systems_region)
852 (get_translation, handle_composition_annotation, consume_chars):
853 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
854 (consume_chars): Rewrite to not calculate an address outside buffer.
855 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
856 Don't access memory outside of the args array.
857 (Fdefine_coding_system_internal): Check for charset-id overflow.
858 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
859 result of ENCODE_CHAR.
860 * coding.h: Adjust decls to match defn changes elsewhere.
861 (struct coding_system):
862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
863 * composite.c (get_composition_id, find_composition)
864 (run_composition_function, update_compositions)
865 (compose_text, composition_gstring_put_cache)
866 (composition_gstring_p, composition_gstring_width)
867 (fill_gstring_header, fill_gstring_body, autocmp_chars)
868 (composition_compute_stop_pos, composition_reseat_it)
869 (composition_update_it, struct position_record)
870 (find_automatic_composition, composition_adjust_point)
871 (Fcomposition_get_gstring, Ffind_composition_internal):
872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
873 (update_compositions):
874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
875 * composite.h: Adjust decls to match defn changes elsewhere.
876 (struct composition):
877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
878 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
879 Do not attempt to compute the address of the object just before a
880 buffer; this is not portable.
882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
883 (Faset): Use int, not EMACS_INT, where int is wide enough.
884 (Fstring_to_number): Don't assume fixnums fit in int.
885 (Frem): Don't assume arg is nonnegative.
886 * dbusbind.c (xd_append_arg): Check for integers out of range.
887 (Fdbus_call_method): Don't overflow the timeout int.
888 (extract_signed, extract_unsigned): New functions.
889 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
890 (xd_get_connection_references): Return ptrdiff_t, not int.
892 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
894 Use int, not unsigned, where the dbus API uses int.
895 (Fdbus_message_internal): Don't overflow mtype.
896 (syms_of_dbusbind): Allocate right-sized buffer for integers.
897 * dired.c (directory_files_internal, file_name_completion, scmp)
898 (file_name_completion_stat):
899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
900 (file_name_completion): Don't overflow matchcount.
901 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
902 * dispextern.h: Adjust decls to match defn changes elsewhere.
903 (struct text_pos, struct glyph, struct bidi_saved_info)
904 (struct bidi_string_data, struct bidi_it, struct composition_it)
906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
907 (struct display_pos, struct composition_it, struct it):
908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
909 * dispnew.c (increment_matrix_positions)
910 (increment_row_positions, mode_line_string)
911 (marginal_area_string):
912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
913 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
915 (duration_to_sec_usec): New function, to check for overflow better.
916 (Fsleep_for, sit_for): Use it.
917 * doc.c (get_doc_string, store_function_docstring):
918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
919 (get_doc_string, Fsnarf_documentation):
920 Use int, not EMACS_INT, where int is wide enough.
922 Use SAFE_ALLOCA, not alloca.
923 Check for overflow when converting EMACS_INT to off_t.
925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
926 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
927 Don't assume uid_t fits into fixnum.
928 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
929 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
930 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
931 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
932 (general_insert_function)
933 (Finsert_char, make_buffer_string, make_buffer_string_both)
934 (update_buffer_properties, Fbuffer_substring)
935 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
936 (Fsubst_char_in_region, check_translation)
937 (Ftranslate_region_internal, save_restriction_restore, Fformat)
938 (transpose_markers, Ftranspose_regions):
939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
940 (clip_to_bounds): Move to lisp.h as an inline function).
941 (Fconstrain_to_field): Don't assume integers are nonnegative.
942 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
943 (Fsubst_char_in_region, Fsave_restriction):
944 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
945 (Femacs_pid): Don't assume pid_t fits into fixnum.
946 (lo_time): Use int, not EMACS_INT, when int suffices.
947 (lisp_time_argument): Check for usec out of range.
948 (Fencode_time): Don't assume fixnum fits in int.
949 (Fuser_login_name, Fuser_full_name): Signal an error
950 if a uid argument is out of range, rather than relying on
952 (Fformat_time_string): Remove now-unnecessary check.
953 lisp_time_argument checks for out-of-range usec now.
954 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
955 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
956 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
957 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
958 (init_cmdargs, Fdump_emacs):
959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
960 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
961 the bottom (typically) 32 bits of the fixnum.
962 * eval.c (specpdl_size, call_debugger):
963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
964 (when_entered_debugger, Fbacktrace_debug):
965 Don't assume fixnum can fit in int.
966 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
967 the object just before a buffer; this is not portable.
968 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
969 (grow_specpdl, unbind_to):
970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
971 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
972 (grow_specpdl): Simplify allocation by using xpalloc.
973 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
974 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
975 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
980 (Fcopy_file, non_regular_nbytes, read_non_regular)
981 (Finsert_file_contents):
982 Use int, not EMACS_INT, where int is wide enough.
983 (READ_BUF_SIZE): Verify that it fits in int.
984 (Finsert_file_contents): Check that counts are in proper range,
985 rather than assuming fixnums fit into ptrdiff_t etc.
986 Don't assume fixnums fit into int.
987 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
988 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
989 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
990 (string_char_to_byte, string_byte_to_char)
991 (string_make_multibyte, string_to_multibyte)
992 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
993 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
994 (substring_both, Fdelete, internal_equal, Ffillarray)
995 (Fclear_string, mapcar1)
996 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
997 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
998 (larger_vector, make_hash_table, maybe_resize_hash_table)
999 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1000 (Fmaphash, secure_hash):
1001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1002 (concat): Check for string index and length overflow.
1003 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1006 (larger_vector): New API (vec, incr_min, size_max) replaces old
1007 one (vec, new_size, init). This catches size overflow.
1008 INIT was removed because it was always Qnil.
1009 All callers changed.
1010 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1011 the upper bound on a hash table index size.
1012 (make_hash_table, maybe_resize_hash_table): Use it.
1013 (secure_hash): Computer start_byte and end_byte only after
1014 they're known to be in ptrdiff_t range.
1015 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1016 (Ffont_get_glyphs, Ffont_at):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1019 (Flist_fonts, Fopen_font):
1020 Don't assume fixnum can fit in int.
1021 (check_gstring): Don't assume index can fit in int.
1022 (font_match_p): Check that fixnum is a character, not a nonnegative
1023 fixnum, since the later code needs to stuff it into an int.
1024 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1025 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1026 conversion overflow issues.
1027 (Fopen_font): Check for integer out of range.
1028 (Ffont_get_glyphs): Don't assume index can fit in int.
1029 * font.h: Adjust decls to match defn changes elsewhere.
1030 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1032 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1033 printmax_t, where ptrdiff_t is wide enough.
1034 (Finternal_char_font):
1035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1036 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1037 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1038 (Fset_frame_position, x_set_frame_parameters)
1039 (x_set_line_spacing, x_set_border_width)
1040 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1041 Check that fixnums are in proper range for system types.
1042 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1044 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1045 Use SAFE_ALLOCA_LISP, not alloca.
1046 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1047 intptr_t is wide enough.
1048 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1049 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1050 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1051 Check for fixnum out of range.
1052 * ftfont.c (ftfont_list): Don't assume index fits in int.
1053 Check that fixnums are in proper range for system types.
1054 (ftfont_shape_by_flt):
1055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1056 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1058 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1059 Check that fixnums are in proper range for system types.
1060 * gnutls.h: Adjust decls to match defn changes elsewhere.
1061 * gtkutil.c (xg_dialog_run):
1062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1063 (update_frame_tool_bar):
1064 Check that fixnums are in proper range for system types.
1065 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1066 (lookup_image): Check that fixnums are in range for system types.
1067 * indent.c (last_known_column, last_known_column_point):
1068 (current_column_bol_cache):
1069 (skip_invisible, current_column, check_display_width):
1070 (check_display_width, scan_for_column, current_column_1)
1071 (Findent_to, Fcurrent_indentation, position_indentation)
1072 (indented_beyond_p, Fmove_to_column, compute_motion):
1073 (Fcompute_motion, Fvertical_motion):
1074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1075 (last_known_column_modified): Use EMACS_INT, not int.
1076 (check_display_width):
1078 Check that fixnums and floats are in proper range for system types.
1079 (compute_motion): Don't assume index or fixnum fits in int.
1080 (compute_motion, Fcompute_motion):
1081 Use int, not EMACS_INT, when it is wide enough.
1082 (vmotion): Omit local var start_hpos that is always 0; that way
1083 we don't need to worry about overflow in expressions involving it.
1084 * indent.h: Adjust decls to match defn changes elsewhere.
1086 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1087 Use int, not EMACS_INT, where int is wide enough.
1088 Remove unused members ovstring_chars_done and tab_offset;
1090 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1091 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1092 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1093 (make_gap, copy_text, insert, insert_and_inherit)
1094 (insert_before_markers, insert_before_markers_and_inherit)
1095 (insert_1, count_combining_before, count_combining_after)
1096 (insert_1_both, insert_from_string)
1097 (insert_from_string_before_markers, insert_from_string_1)
1098 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1099 (adjust_after_replace, adjust_after_insert, replace_range)
1100 (replace_range_2, del_range, del_range_1, del_range_byte)
1101 (del_range_both, del_range_2, modify_region)
1102 (prepare_to_modify_buffer, signal_before_change)
1103 (signal_after_change, Fcombine_after_change_execute):
1104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1105 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1106 (balance_an_interval, split_interval_right, split_interval_left)
1107 (find_interval, next_interval, update_interval)
1108 (adjust_intervals_for_insertion, delete_node, delete_interval)
1109 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1110 (static_offset_intervals, offset_intervals)
1111 (merge_interval_right, merge_interval_left, make_new_interval)
1112 (graft_intervals_into_buffer, temp_set_point_both)
1113 (temp_set_point, set_point, adjust_for_invis_intang)
1114 (set_point_both, move_if_not_intangible, get_property_and_range)
1115 (get_local_map, copy_intervals, copy_intervals_to_string)
1116 (compare_string_intervals, set_intervals_multibyte_1):
1117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1118 * intervals.h: Adjust decls to match defn changes elsewhere.
1120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1121 * keyboard.c (this_command_key_count, this_single_command_key_start)
1122 (before_command_key_count, before_command_echo_length, echo_now)
1123 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1124 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1125 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1126 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1127 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1128 (last_non_minibuf_size, last_point_position, echo_truncate)
1129 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1130 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1131 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1132 (stuff_buffered_input):
1133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1134 (last_auto_save, command_loop_1, read_char):
1135 Use EMACS_INT, not int, to avoid integer overflow.
1136 (record_char): Avoid overflow in total_keys computation.
1137 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1138 * keyboard.h: Adjust decls to match defn changes elsewhere.
1139 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1140 (Fkey_description, Fdescribe_vector, Flookup_key):
1141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1142 (click_position): New function, to check that positions are in range.
1143 (Fcurrent_active_maps):
1145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1146 (Faccessible_keymaps, Fkey_description):
1147 (preferred_sequence_p):
1148 Don't assume fixnum can fit into int.
1149 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1150 Check for integer overflow in size calculations.
1151 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1152 avoid mishandling large integers.
1153 * lisp.h: Adjust decls to match defn changes elsewhere.
1154 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1155 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1156 (struct Lisp_Marker):
1157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1158 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1159 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1160 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1161 All callers changed.
1162 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1163 Assume the arg has valid form, since it always does.
1164 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1165 unsigned integer system type.
1166 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1167 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1169 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1170 (duration_to_sec_usec): New decl.
1171 * lread.c (read_from_string_index, read_from_string_index_byte)
1172 (read_from_string_limit, readchar, unreadchar, openp)
1173 (read_internal_start, read1, oblookup):
1174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1175 (Fload, readevalloop, Feval_buffer, Feval_region):
1176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1177 (openp): Check for out-of-range argument to 'access'.
1178 (read1): Use int, not EMACS_INT, where int is wide enough.
1179 Don't assume fixnum fits into int.
1180 Fix off-by-one error that can read outside a buffer.
1181 (read_filtered_event): Use duration_to_sec_usec
1182 to do proper overflow checking on durations.
1183 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1184 in size calculation.
1185 (Fexecute_kbd_macro):
1186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1187 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1188 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1189 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1190 (set_marker_both, set_marker_restricted_both, marker_position)
1191 (marker_byte_position, Fbuffer_has_markers_at):
1192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1193 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1194 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1195 It now merely ensures that the menu is large enough, without
1196 necessarily growing it, as this avoids some integer overflow issues.
1197 All callers changed.
1198 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1200 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1201 Use SAFE_ALLOCA_LISP, not alloca.
1202 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1203 to EMACS_INT. Check that fixnums are in proper range for system types.
1204 * minibuf.c (minibuf_prompt_width, string_to_object)
1205 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1206 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1208 (get_minibuffer, read_minibuf_unwind):
1209 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1210 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1211 this simplifies overflow checking. All callers changed.
1212 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1215 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1216 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1217 Check that fixnums are in proper range for system types.
1218 (Fx_create_frame, Fx_show_tip):
1219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1220 * nsfont.m (ns_findfonts, nsfont_list_family):
1221 Don't assume fixnum fits in long.
1222 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1224 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1226 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1228 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1229 (PRINTDECLARE, PRINTPREPARE):
1230 (strout, print_string):
1231 (print, print_preprocess, print_check_string_charset_prop)
1233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1235 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1237 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1238 (printchar, strout): Use xpalloc to catch size calculation overflow.
1239 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1240 (print_error_message): Use SAFE_ALLOCA, not alloca.
1241 (print_object): Use int, not EMACS_INT, where int is wide enough.
1242 (print_depth, new_backquote_output, print_number_index):
1243 Use ptrdiff_t, not int, where int might not be wide enough.
1244 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1245 (Fset_process_window_size, Fformat_network_address)
1246 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1248 Check that fixnums are in proper range for system types.
1249 (Fsignal_process): Simplify by avoiding a goto.
1250 Check for process-ids out of pid_t range rather than relying on
1252 (process_tick, update_tick): Use EMACS_INT, not int.
1253 (Fformat_network_address, read_process_output, send_process)
1254 (Fprocess_send_region, status_notify):
1255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1256 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1257 (wait_reading_process_output, read_process_output, exec_sentinel):
1258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1259 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1260 (Faccept_process_output): Use duration_to_sec_usec to do proper
1261 overflow checking on durations.
1262 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1263 Don't assume pid_t fits in int.
1264 * process.h (struct Lisp_Process): Members tick and update_tick
1265 are now of type EMACS_INT, not int.
1266 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1267 configured --with-wide-int.
1268 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1269 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1270 * search.c (looking_at_1, string_match_1):
1271 (fast_string_match, fast_c_string_match_ignore_case)
1272 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1273 (scan_newline, find_before_next_newline, search_command)
1274 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1275 (set_search_regs, wordify):
1278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1279 (string_match_1, search_buffer, set_search_regs):
1281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1282 (wordify): Check for overflow in size calculation.
1283 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1284 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1285 Check that fixnums are in proper range for system types.
1286 * sound.c (struct sound_device)
1287 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1289 (Fplay_sound_internal):
1290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1291 * syntax.c (struct lisp_parse_state, find_start_modiff)
1292 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1293 (Fparse_partial_sexp):
1294 Don't assume fixnums can fit in int.
1295 (struct lisp_parse_state, find_start_pos, find_start_value)
1296 (find_start_value_byte, find_start_begv)
1297 (update_syntax_table, char_quoted, dec_bytepos)
1298 (find_defun_start, prev_char_comend_first, back_comment):
1299 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1300 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1302 (Finternal_describe_syntax_value): Check that match_lisp is a
1303 character, not an integer, since the code stuffs it into int.
1304 (scan_words, scan_sexps_forward):
1305 Check that fixnums are in proper range for system types.
1307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1308 (scan_sexps_forward):
1309 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1310 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1311 * syntax.h: Adjust decls to match defn changes elsewhere.
1312 (struct gl_state_s):
1313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1314 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1315 MOST_POSITIVE_FIXNUM.
1316 * sysdep.c (wait_for_termination_1, wait_for_termination)
1317 (interruptible_wait_for_termination, mkdir):
1318 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1319 (emacs_read, emacs_write):
1320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1321 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1322 and double all fit in int.
1323 * term.c (set_tty_color_mode):
1324 Check that fixnums are in proper range for system types.
1325 * termhooks.h (struct input_event):
1326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1327 * textprop.c (validate_interval_range, interval_of)
1328 (Fadd_text_properties, set_text_properties_1)
1329 (Fremove_text_properties, Fremove_list_of_text_properties)
1330 (Ftext_property_any, Ftext_property_not_all)
1331 (copy_text_properties, text_property_list, extend_property_ranges)
1332 (verify_interval_modification):
1333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1334 (Fnext_single_char_property_change)
1335 (Fprevious_single_char_property_change):
1336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1337 (copy_text_properties):
1338 Check for integer overflow in index calculation.
1339 * undo.c (last_boundary_position, record_point, record_insert)
1340 (record_delete, record_marker_adjustment, record_change)
1341 (record_property_change):
1342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1343 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1345 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1346 (Fx_hide_tip, Fx_file_dialog):
1347 * w32menu.c (set_frame_menubar):
1348 Use ptrdiff_t, not int, for consistency with rest of code.
1349 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1350 (select_window, Fdelete_other_windows_internal)
1351 (window_scroll_pixel_based, window_scroll_line_based)
1352 (Frecenter, Fset_window_configuration):
1353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1354 (Fset_window_hscroll, run_window_configuration_change_hook)
1355 (set_window_buffer, temp_output_buffer_show, scroll_command)
1356 (Fscroll_other_window, Frecenter):
1357 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1358 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1359 Don't assume fixnum fits in int.
1360 (Fset_window_scroll_bars):
1361 Check that fixnums are in proper range for system types.
1362 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1363 (string_pos, c_string_pos, number_of_chars, init_iterator)
1364 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1365 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1366 (compute_display_string_end, handle_face_prop)
1367 (face_before_or_after_it_pos, handle_invisible_prop)
1368 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1369 (display_prop_intangible_p, string_buffer_position_lim)
1370 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1371 (get_overlay_strings_1, get_overlay_strings)
1372 (iterate_out_of_display_property, forward_to_next_line_start)
1373 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1374 (get_next_display_element, set_iterator_to_next)
1375 (get_visually_first_element, compute_stop_pos_backwards)
1376 (handle_stop_backwards, next_element_from_buffer)
1377 (move_it_in_display_line_to, move_it_in_display_line)
1378 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1379 (add_to_log, message_dolog, message_log_check_duplicate)
1380 (message2, message2_nolog, message3, message3_nolog
1381 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1382 (current_message_1, truncate_echo_area, truncate_message_1)
1383 (set_message, set_message_1, store_mode_line_noprop)
1384 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1385 (text_outside_line_unchanged_p, check_point_in_composition)
1386 (reconsider_clip_changes)
1387 (redisplay_internal, set_cursor_from_row, try_scrolling)
1388 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1389 (redisplay_window, find_last_unchanged_at_beg_row)
1390 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1391 (trailing_whitespace_p, find_row_edges, display_line)
1392 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1393 (display_mode_element, store_mode_line_string)
1394 (pint2str, pint2hrstr, decode_mode_spec)
1395 (display_count_lines, display_string, draw_glyphs)
1396 (x_produce_glyphs, x_insert_glyphs)
1397 (rows_from_pos_range, mouse_face_from_buffer_pos)
1398 (fast_find_string_pos, mouse_face_from_string_pos)
1399 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1401 (safe_call, init_from_display_pos, handle_fontified_prop)
1402 (handle_single_display_spec, load_overlay_strings)
1403 (with_echo_area_buffer, setup_echo_area_for_printing)
1404 (display_echo_area, echo_area_display)
1405 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1406 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1407 (redisplay_window, dump_glyph_row, display_mode_line)
1408 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1409 (handle_display_spec, display_prop_string_p):
1410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1411 (handle_single_display_spec, build_desired_tool_bar_string)
1412 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1413 (get_specified_cursor_type):
1414 Check that fixnums are in proper range for system types.
1415 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1416 (Flookup_image_map):
1417 Don't assume fixnums fit in int.
1418 (compare_overlay_entries):
1419 Avoid mishandling comparisons due to subtraction overflow.
1420 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1421 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1422 (handle_tool_bar_click):
1423 Use int, not unsigned, since we prefer signed and the signedness
1424 doesn't matter here.
1425 (get_next_display_element, next_element_from_display_vector):
1426 Use int, not EMACS_INT, when int is wide enough.
1427 (start_hourglass): Use duration_to_sec_usec to do proper
1428 overflow checking on durations.
1429 * xfaces.c (Fbitmap_spec_p):
1430 Check that fixnums are in proper range for system types.
1431 (compare_fonts_by_sort_order):
1432 Avoid mishandling comparisons due to subtraction overflow.
1433 (Fx_family_fonts, realize_basic_faces):
1434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1436 Don't assume fixnum fits in int.
1437 Use SAFE_ALLOCA_LISP, not alloca.
1438 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1439 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1440 (face_at_buffer_position, face_for_overlay_string)
1441 (face_at_string_position):
1442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1443 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1444 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1446 Check that fixnums are in proper range for system types.
1447 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1448 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1449 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1450 (Fx_change_window_property): Don't assume fixnums fit in int.
1451 * xfont.c (xfont_chars_supported):
1452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1453 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1454 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1455 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1456 * xml.c (parse_region):
1457 * xrdb.c (magic_file_p):
1458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1459 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1460 (x_get_local_selection, x_reply_selection_request)
1461 (x_handle_selection_request, wait_for_property_change):
1462 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1463 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1464 short is wide enough.
1465 (x_send_client_event): Don't assume fixnum fits in int.
1466 * xterm.c (x_x_to_emacs_modifiers):
1467 Don't assume EMACS_INT overflows nicely into int.
1468 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1470 (handle_one_xevent): NATNUMP can eval its arg twice.
1471 (x_connection_closed):
1472 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1473 * xterm.h: Adjust decls to match defn changes elsewhere.
1474 (struct scroll_bar): Use struct vectorlike_header
1475 rather than rolling our own approximation.
1476 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1478 2012-05-25 Glenn Morris <rgm@gnu.org>
1480 * lisp.mk (lisp): Update for more files being compiled now.
1482 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1484 * lread.c: Remove `read_pure' which makes no difference.
1485 (read_pure): Remove var.
1486 (unreadpure): Remove function.
1487 (readevalloop): Don't call read_list with -1 flag.
1488 (read1, read_vector): Don't test read_pure any more.
1489 (read_list): Simplify.
1491 * fileio.c, character.h: Minor style tweaks.
1493 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1495 * window.h (clip_changed): Remove useless declaration.
1497 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1499 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1500 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1502 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1505 This directory predates autoconf and is no longer needed nowadays.
1506 Move its few remaining bits of functionality to where they're needed.
1507 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1508 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1509 * m/template.h: Remove.
1510 * Makefile.in (M_FILE): Remove. All uses removed.
1511 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1512 * lisp.h (USE_LSB_TAG):
1513 * mem-limits.h (EXCEEDS_LISP_PTR):
1514 Use VAL_MAX, not VALBITS, in #if.
1515 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1516 (EMACS_UINT): Define unconditionally now.
1517 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1518 (BITS_PER_EMACS_INT): New constants, replacing
1519 what used to be in config.h, but not useful in #if.
1520 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1521 define them any more.
1522 (VAL_MAX): New macro.
1524 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1525 BITS_PER_EMACS_INT, in #if.
1526 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1527 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1528 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1529 * s/ms-w32.h (DATA_START):
1530 Move here from removed file m/intel386.h.
1531 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1532 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1534 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1536 Assume C89 or later.
1537 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1538 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1540 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1541 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1542 * textprop.c, tparam.c (NULL): Remove.
1543 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1544 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1545 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1546 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1547 * xterm.c (input_signal_count): Assume volatile works.
1549 2012-05-21 Ken Brown <kbrown@cornell.edu>
1551 * xgselect.c (xg_select): Fix first argument in call to 'select'
1554 2012-05-20 Ken Brown <kbrown@cornell.edu>
1556 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1557 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1559 2012-05-19 Ken Brown <kbrown@cornell.edu>
1561 * xfns.c (x_in_use): Remove `static' qualifier.
1562 * xterm.h (x_in_use): Declare.
1563 * xgselect.c: Include xterm.h.
1564 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1565 and `display_arg' (bug#9754).
1567 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1569 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1571 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1572 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1574 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1576 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1578 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1579 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1581 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1582 reference to image_cache->refcount.
1583 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1585 2012-05-17 Juri Linkov <juri@jurta.org>
1587 * search.c (Fword_search_regexp, Fword_search_backward)
1588 (Fword_search_forward, Fword_search_backward_lax)
1589 (Fword_search_forward_lax): Move functions to isearch.el
1590 (bug#10145, bug#11381).
1592 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1594 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1596 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1598 * lread.c (init_obarray): Declare Qt and Qnil as special.
1600 2012-05-14 Glenn Morris <rgm@gnu.org>
1602 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1603 Put "libexec" before "bin", for the sake of init_callproc_1.
1605 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1607 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1609 * unexaix.c: Port to more-recent AIX compilers.
1610 (report_error, report_error_1, make_hdr, copy_sym)
1611 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1612 Make arguments const char *, not char *, to avoid violations of C
1613 standard and to fix some AIX warnings reported by Gilles Pion.
1615 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1617 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1618 already have overlays loaded.
1619 (handle_single_display_spec): Before returning without displaying
1620 fringe bitmap, synchronize the bidi iterator with the main display
1621 iterator, by calling iterate_out_of_display_property.
1622 (iterate_out_of_display_property): Detect buffer iteration by
1623 testing that it->string is a Lisp string.
1624 (get_next_display_element): When the current object is exhausted,
1625 and there's something on it->stack, call set_iterator_to_next to
1626 proceed with what's on the stack, instead of returning zero.
1627 (set_iterator_to_next): If called at the end of a Lisp string,
1628 proceed to consider_string_end without incrementing string
1629 position. Don't increment display vector index past the end of
1630 the display vector. (Bug#11417)
1631 (pos_visible_p): Don't report a position visible when move_it_to
1632 stopped at the last line of window, which happens to be scanned
1633 backwards by the bidi iteration. (Bug#11464)
1635 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1637 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1638 and right-margin display specs even if the spec is invalid or we
1639 are on a TTY, and thus unable to display on the fringes.
1640 That's because the text with the property will not be displayed anyway,
1641 so we need to signal to the caller that this is a "replacing"
1642 display spec. This fixes display when the spec is invalid or we
1645 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1647 * unexaix.c (make_hdr): Fix typo in prototype.
1648 This bug broke the build on AIX. Problem reported by Gilles Pion.
1650 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1652 * keyboard.c (kbd_buffer_get_event): Read special events also in
1653 batch mode. (Bug#11415)
1655 2012-05-12 Glenn Morris <rgm@gnu.org>
1657 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1659 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1661 * lisp.mk (lisp): Add newcomment.elc.
1663 2012-05-12 Glenn Morris <rgm@gnu.org>
1665 * Makefile.in (MKDIR_P): New, set by configure.
1666 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1668 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1670 Remove unused function hourglass_started.
1671 * dispextern.h (hourglass_started):
1672 * w32fns.c (hourglass_started):
1673 * xdisp.c (hourglass_started): Remove.
1675 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1677 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1678 Update dependencies.
1680 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1682 * xgselect.c (xg_select): Put maxfds+1 into a var.
1683 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1685 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1687 2012-05-10 Dave Abrahams <dave@boostpro.com>
1689 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1690 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1692 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1694 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1695 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1696 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1697 Initialize xd_registered_buses.
1699 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1701 Untag more efficiently if USE_LSB_TAG.
1702 This is based on a proposal by YAMAMOTO Mitsuharu in
1703 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1704 For an admittedly artificial (nth 8000 longlist) benchmark on
1705 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1706 Emacs's overall text size by 1%.
1707 * lisp.h (XUNTAG): New macro.
1708 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1709 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1710 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1711 * eval.c (Fautoload):
1712 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1713 * frame.h (XFRAME): Use XUNTAG.
1715 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1716 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1717 Remove unportable assumptions about print widths of types like
1719 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1720 intptr_t when converting between pointer and integer, to avoid GCC
1721 warnings about wrong width.
1723 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1725 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1726 stack for each reader_thread, instead of defaulting to 8MB
1727 determined by the linker. This avoids failures in creating
1728 subprocesses on Windows 7, see the discussion in this thread:
1729 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1731 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1733 Fix up display of the *Minibuf-0* buffer in the mini window.
1734 * keyboard.c (read_char): Don't clear the echo area if there's no
1736 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1737 contents of *Minibuf-0*) if there's no message displayed in its stead.
1739 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1741 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1744 2012-05-06 Chong Yidong <cyd@gnu.org>
1746 * lisp.mk (lisp): Update.
1748 2012-05-05 Jim Meyering <meyering@redhat.com>
1750 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1752 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1754 * data.c (PUT_ERROR): New macro.
1755 (syms_of_data): Use it. Add new error type `user-error'.
1756 * undo.c (user_error): New function.
1757 (Fprimitive_undo): Use it.
1758 * print.c (print_error_message): Adjust print style for `user-error'.
1759 * keyboard.c (user_error): New function.
1760 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1762 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1764 Do not limit current-time-string to years 1000..9999.
1765 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1766 (Fcurrent_time_string): Support any year that is supported by the
1767 underlying localtime representation. Don't use asctime, as it
1768 has undefined behavior for years outside the range -999..9999.
1770 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1772 Fix race conditions involving setenv, gmtime, localtime, asctime.
1773 Without this fix, interrupts could mess up code that uses these
1774 nonreentrant functions, since setting TZ invalidates existing
1775 tm_zone or tzname values, and since most of these functions return
1776 pointers to static storage.
1777 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1778 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1779 Grow the critical sections to include not just invoking
1780 localtime/gmtime, but also accessing these functions' results
1781 including their tm_zone values if any, and any related TZ setting.
1782 (format_time_string): Last arg is now struct tm *, not struct tm **,
1783 so that the struct tm is saved in the critical section.
1784 All callers changed. Simplify allocation of initial buffer, partly
1785 motivated by the fact that memory allocation needs to be outside
1786 the critical section.
1788 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1790 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1791 with RESET_INTERVAL.
1793 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1794 Remove duplicated buffer name initialization.
1796 2012-05-02 Jim Meyering <jim@meyering.net>
1798 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1800 * xfns.c (x_window): Use xstrdup (Bug#11375).
1802 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1804 * xdisp.c (pos_visible_p): If already at a newline from the
1805 display string before the 'while' loop, don't walk back the glyphs
1806 from it3.glyph_row. Solves assertion violation when the display
1807 string begins with a newline (egg.el). (Bug#11367)
1809 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1811 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1814 2012-05-01 Glenn Morris <rgm@gnu.org>
1816 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1817 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1818 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1819 All were removed before 23.1.
1821 * dispnew.c: Remove HAVE_LIBNCURSES test;
1822 it is always true on relevant platforms.
1824 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1825 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1827 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1829 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1831 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1832 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1835 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1837 Do not avoid creating empty evaporating overlays (Bug#9642).
1838 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1839 That is, do not delete an evaporating overlay if it becomes
1840 empty after its bounds are adjusted to fit within its buffer.
1841 This fix caused other problems, and I'm reverting it until we get
1842 to the bottom of them.
1844 2012-04-27 Chong Yidong <cyd@gnu.org>
1846 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1848 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1850 * xdisp.c (pos_visible_p): If the window start position is beyond
1851 ZV, start the display from buffer beginning. Prevents assertion
1852 violation in init_iterator when the minibuffer window is scrolled
1855 * window.c (window_scroll_pixel_based): Likewise.
1857 2012-04-27 Chong Yidong <cyd@gnu.org>
1859 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1861 2012-04-27 Glenn Morris <rgm@gnu.org>
1863 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1864 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1866 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1868 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1869 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1871 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1873 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1874 display element, check also the underlying string or buffer
1875 character. (Bug#11341)
1877 * w32menu.c: Include w32heap.h.
1878 (add_menu_item): If the call to AppendMenuW (via
1879 unicode_append_menu) fails, disable Unicode menus only if we are
1880 running on Windows 9X/Me.
1882 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1884 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1885 (xgetint): Add missing shift for LSB tags.
1887 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1889 * keyboard.c (read_char): Don't wipe echo area for select window
1890 events: These might get delayed via `mouse-autoselect-window'
1893 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1895 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1896 manipulation of :loaded-from data.
1898 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1900 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1901 now a cons (bug#11311).
1903 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1905 Do not create empty overlays with the evaporate property (Bug#9642).
1906 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1907 if it becomes empty after its bounds are adjusted to fit within
1908 its buffer. Without this fix, in a nonempty buffer (let ((o
1909 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1910 yields an empty overlay that has the evaporate property, which is
1911 not supposed to happen.
1913 Fix minor GTK3 problems found by static checking.
1914 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1915 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1916 (struct _EmacsFixedClass, emacs_fixed_get_type):
1917 Move decls here from emacsgtkfixed.h, since they needn't be public.
1918 (emacs_fixed_get_type): Now static.
1919 (emacs_fixed_class_init): Omit unused local.
1920 (emacs_fixed_child_type): Remove; unused.
1921 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1922 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1923 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1924 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1925 (EMACS_FIXED_GET_CLASS): Remove; unused.
1926 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1928 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1929 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1931 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1933 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1934 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1935 (__malloc_size_t, __malloc_ptrdiff_t):
1936 Remove. All uses removed, replaced by the definiens if needed,
1937 since we can assume C89 or better now.
1938 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1939 (protect_malloc_state, align, get_contiguous_space)
1940 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1941 (malloc_atfork_handler_child, malloc_enable_thread)
1942 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1943 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1944 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1945 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1946 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1947 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1948 Define using prototypes, not old style.
1949 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1950 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1951 (align): Don't assume that signed integer overflow wraps around.
1952 Omit unused local var.
1953 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1954 (_free_internal_nolock, memalign, mallochook, reallochook):
1955 Omit no-longer-needed casts.
1956 (valloc): Use getpagesize, not __getpagesize.
1957 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1958 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1960 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1962 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1964 Move functions from C to Lisp. Make non-blocking method calls
1965 the default. Implement further D-Bus standard interfaces.
1967 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1968 (QCdbus_request_name_allow_replacement)
1969 (QCdbus_request_name_replace_existing)
1970 (QCdbus_request_name_do_not_queue)
1971 (QCdbus_request_name_reply_primary_owner)
1972 (QCdbus_request_name_reply_in_queue)
1973 (QCdbus_request_name_reply_exists)
1974 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1975 (QCdbus_registered_serial, QCdbus_registered_method)
1976 (QCdbus_registered_signal): New Lisp objects.
1977 (XD_DEBUG_MESSAGE): Use sizeof.
1978 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1979 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1980 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1981 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1982 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1983 (xd_signature, xd_append_arg): Allow float for integer types.
1984 (xd_get_connection_references): New function.
1985 (xd_get_connection_address): Rename from xd_initialize.
1986 Return cached address.
1987 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1988 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1990 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1991 Return number of refcounts.
1992 (Fdbus_get_unique_name): Make stronger parameter check.
1993 (Fdbus_message_internal): New defun.
1994 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1995 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1996 (Fdbus_send_signal, Fdbus_register_service)
1997 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1998 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1999 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2000 (Vdbus_compiled_version, Vdbus_runtime_version)
2001 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2002 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2003 (Vdbus_message_type_signal): New defvars.
2004 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2007 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2009 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2010 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2011 Do not assume ptrdiff_t is the same width as 'int'.
2013 * alloc.c: Handle unusual debugging option combinations.
2014 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2015 since the two debugging options are incompatible.
2016 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2018 (mem_init, mem_insert, mem_insert_fixup):
2019 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2020 (NEED_MEM_INSERT): Remove; no longer needed.
2022 2012-04-22 Leo Liu <sdl.web@gmail.com>
2024 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2026 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2028 * sysdep.c [__FreeBSD__]: Minor cleanups.
2029 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2030 Use Emacs indenting style more consistently. Avoid some casts.
2031 Use 'double' consistently rather than mixing 'float' and 'double'.
2033 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2035 * sysdep.c (list_system_processes, system_process_attributes):
2036 Add implementation for FreeBSD (Bug#5243).
2038 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2040 * lisp.mk (lisp): Update.
2042 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2044 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2045 It is never used otherwise.
2047 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2049 * print.c (print_preprocess): Only check print_depth if print-circle
2051 (print_object): Check for cycles even when print-circle is nil and
2052 print-gensym is t, but only check print_depth if print-circle is nil.
2054 2012-04-20 Chong Yidong <cyd@gnu.org>
2056 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2057 set the status to "failed" and ensure that sentinel is run.
2059 2012-04-20 Glenn Morris <rgm@gnu.org>
2061 * process.c (Fset_process_inherit_coding_system_flag)
2062 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2063 (Fmake_network_process, Fmake_serial_process): Doc fix.
2065 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2067 * xdisp.c (string_buffer_position_lim): Limit starting position to
2069 (set_cursor_from_row): If called for a mode-line or header-line
2070 row, return zero immediately.
2071 (try_cursor_movement): If inside continuation line, don't back up
2072 farther than the first row after the header line, if any.
2073 Don't consider the header-line row as "partially visible", even if
2074 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2076 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2078 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2081 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2082 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2084 configure: new option --enable-gcc-warnings (Bug#11207)
2085 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2086 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2087 (ALL_CFLAGS): Use new macros rather than old.
2088 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2089 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2090 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2091 -Wunused-result, -Wunused-variable. This should go away once
2092 the Emacs and Gnulib regex code is merged.
2093 (xmalloc, xrealloc): Now static.
2095 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2097 * dired.c (Fsystem_groups): Remove unused local.
2099 2012-04-17 Glenn Morris <rgm@gnu.org>
2101 * dired.c (Fsystem_users): Doc fix.
2103 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2105 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2106 (syms_of_dired): Add them.
2108 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2110 Fix minor alloc.c problems found by static checking.
2111 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2112 New extern decls, to avoid calling undeclared functions.
2113 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2114 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2115 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2116 (NEED_MEM_INSERT): New macro.
2117 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2118 Remove one incorrect comment and fix another.
2120 Fix minor ralloc.c problems found by static checking.
2121 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2122 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2123 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2124 (r_alloc_sbrk): Now static.
2126 Improve ralloc.c interface checking.
2127 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2128 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2129 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2130 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2131 [REL_ALLOC]: ... to here, to check interface.
2132 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2133 Remove decls. This fixes an "It stinks!".
2135 * alloc.c (which_symbols): Fix alignment issue / type clash.
2137 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2139 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2140 (struct Lisp_Misc_Any): Likewise.
2141 (struct Lisp_Free): Likewise.
2142 * alloc.c (union aligned_Lisp_Symbol): Define.
2143 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2144 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2145 (union aligned_Lisp_Misc): Define.
2146 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2147 aligned_Lisp_Misc instead of union Lisp_Misc.
2148 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2150 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2152 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2153 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2154 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2155 * s/netbsd.h, s/sol2-6.h:
2156 Remove definition of GC_MARK_STACK, since the default now works.
2157 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2158 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2159 no longer the default.
2160 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2162 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2164 * lread.c (lisp_file_lexically_bound_p):
2165 Fix hang at ";-*-\n" (bug#11238).
2167 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2169 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2170 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2172 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2174 * nsterm.m (constrainFrameRect): Always constrain when there is only
2175 one screen (Bug#10962).
2177 2012-04-13 Ken Brown <kbrown@cornell.edu>
2179 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2181 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2183 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2185 2012-04-11 Daniel Colascione <dancol@dancol.org>
2187 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2188 against is gone. It's better to use vfork now so that when Cygwin
2189 gains a new, working vfork, we use it automatically (bug#10398).
2191 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2193 * window.c (save_window_save): Obey window-point-insertion-type.
2195 2012-04-11 Glenn Morris <rgm@gnu.org>
2197 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2199 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2201 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2203 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2205 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2206 (force_quit_count): New var.
2207 (handle_interrupt): Use it.
2209 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2211 * w32.c (w32_delayed_load): Record the full path of the library
2212 being loaded (bug#10424).
2214 2012-04-09 Glenn Morris <rgm@gnu.org>
2216 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2217 not just in the obarray, before snarfing them. (Bug#11036)
2219 * Makefile.in ($(leimdir)/leim-list.el):
2220 Pass EMACS rather than BUILT_EMACS.
2222 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2224 * process.c (make_process):
2225 * process.h: Add integer `gnutls_handshakes_tried' member to
2228 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2229 Add convenience `GNUTLS_LOG2i' macro.
2231 * gnutls.c (gnutls_log_function2i): Convenience log function.
2232 (emacs_gnutls_read): Use new log functions,
2233 `gnutls_handshakes_tried' process member, and
2234 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2235 attempts per process (connection).
2237 2012-04-09 Chong Yidong <cyd@gnu.org>
2239 * eval.c (Fuser_variable_p, user_variable_p_eh)
2240 (lisp_indirect_variable): Functions deleted.
2241 (Fdefvar): Caller changed.
2243 * callint.c (Finteractive, Fcall_interactively):
2244 * minibuf.c (Fread_variable): Callers changed.
2246 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2248 * xdisp.c (set_cursor_from_row): If the display string appears in
2249 the buffer at position that is closer to point than the position
2250 after the display string, display the cursor on the first glyph of
2251 the display string. Fixes cursor display when a 'display' text
2252 property immediately follows invisible text. (Bug#11094)
2254 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2256 composite.c: use 'double' consistently
2257 * composite.c (get_composition_id): Use 'double' consistently
2258 instead of converting 'float' to 'double' and vice versa; this is
2259 easier to understand and avoids a GCC warning.
2261 2012-04-09 Glenn Morris <rgm@gnu.org>
2263 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2264 preparation for dumping it with emacs. (Bug#4789)
2265 (leimdir): New variable.
2266 ($(leimdir)/leim-list.el): New rule.
2267 (emacs$(EXEEXT)): Depend on leim-list.el.
2269 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2270 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2271 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2273 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2275 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2278 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2280 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2281 Remove unused local variable.
2283 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2285 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2286 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2287 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2288 objects, as mark_maybe_pointer will catch them otherwise.
2289 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2290 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2292 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2294 Fix typo that broke non-Windows builds.
2295 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2297 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2299 Support building on MS-Windows with libxml2.
2301 * makefile.w32-in (OBJ2): Add xml.$(O).
2302 (GLOBAL_SOURCES): Add xml.c.
2303 ($(BLD)/xml.$(O)): New dependency list.
2305 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2306 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2307 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2308 [!WINDOWSNT]: New macros.
2309 (init_libxml2_functions, libxml2_loaded_p): New functions.
2310 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2311 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2312 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2313 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2315 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2316 Call init_libxml2_functions before calling libxml2 functions.
2317 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2319 * emacs.c: Don't include libxml/parser.h.
2320 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2321 xmlCleanupParser directly.
2323 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2325 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2327 * indent.c (Fvertical_motion): If there is a display string at
2328 point, use it.vpos to compute how many lines to backtrack after
2329 move_it_to point. (Bug#11133)
2331 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2333 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2334 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2335 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2336 macros related to unification of CJK characters. For the details,
2337 see the discussion following the message here:
2338 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2340 2012-04-04 Chong Yidong <cyd@gnu.org>
2342 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2344 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2346 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2347 instead of alloca. (Bug#11138)
2349 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2351 * w32menu.c (is_simple_dialog): Properly check lisp types.
2354 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2356 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2357 position we get to after a call to move_it_to fails the
2358 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2359 only if we wind up in a string from display property. (Bug#11063)
2361 * window.c (Fdelete_other_windows_internal): Invalidate the row
2362 and column information about mouse highlight, so that redisplay
2363 restores it after reallocating the glyph matrices. (Bug#7464)
2365 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2366 string comes from a `display' text property, use the buffer
2367 position of that property as if we actually saw that position in
2369 (move_it_by_lines): Remove the assertion that
2370 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2371 violated when there's a before-string at the beginning of a line.
2374 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2376 * xdisp.c (append_space_for_newline): If the default face was
2377 remapped, use the remapped face for the appended newline.
2378 (extend_face_to_end_of_line): Use the remapped default face for
2379 extending the face to the end of the line.
2380 (display_line): Call extend_face_to_end_of_line when the default
2381 face was remapped. (Bug#11068)
2383 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2385 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2387 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2389 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2391 2012-03-27 Glenn Morris <rgm@gnu.org>
2393 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2396 2012-03-26 Kenichi Handa <handa@m17n.org>
2398 * dispextern.h (struct glyph): Fix previous change. Change the
2399 bit length of glyphless.ch to 25 (Bug#11082).
2401 2012-03-26 Chong Yidong <cyd@gnu.org>
2403 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2404 (command_loop_1): Use it; inhibit selection update for
2405 handle-select-window too (Bug#8996).
2407 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2409 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2411 2012-03-25 Kenichi Handa <handa@m17n.org>
2413 * dispextern.h (struct glyph): Change the bit length of
2414 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2416 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2418 * s/ms-w32.h (tzname): Include time.h before redirecting to
2419 _tzname. Fixes the MSVC build. (Bug#9960)
2421 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2423 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2426 * xterm.c (XTread_socket): Only modify handling_signal if
2427 !SYNC_INPUT. (Bug#11080)
2429 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2431 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2432 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2433 when fetching a multibyte character consumes more bytes than
2434 CHAR_BYTES returns, due to unification of CJK characters in
2435 string_char. (Bug#11073)
2437 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2439 * process.c (wait_reading_process_output): Handle pty disconnect
2440 by refraining from sending oneself a SIGCHLD (bug#10933).
2442 2012-03-22 Chong Yidong <cyd@gnu.org>
2444 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2446 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2447 Mark string as coming from a prefix property.
2448 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2449 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2451 2012-03-21 Chong Yidong <cyd@gnu.org>
2453 * xfaces.c (Vface_remapping_alist): Doc fix.
2455 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2457 * w32proc.c (Fw32_set_console_codepage)
2458 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2461 2012-03-20 Chong Yidong <cyd@gnu.org>
2463 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2464 to reflect default non-nil value of redisplay-dont-pause.
2466 2012-03-19 Kenichi Handa <handa@m17n.org>
2468 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2469 it fit in a valid range (Bug#11003).
2471 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2473 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2474 that is not from display property, accept the row as a "cursor
2475 row" if one of the string's character has a non-nil `cursor'
2476 property. Fixes cursor positioning when there are newlines in
2477 overlay strings, e.g. in icomplete.el. (Bug#11035)
2479 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2481 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2483 2012-03-12 Chong Yidong <cyd@gnu.org>
2485 * eval.c (inhibit_lisp_code): Rename from
2486 inhibit_window_configuration_change_hook; move from window.c.
2488 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2489 * window.c (run_window_configuration_change_hook)
2490 (syms_of_window): Callers changed.
2492 2012-03-11 Chong Yidong <cyd@gnu.org>
2494 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2496 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2498 2012-03-10 Chong Yidong <cyd@gnu.org>
2500 * frame.c (other_visible_frames): Don't assume the selected frame
2501 is visible (Bug#10955).
2503 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2505 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2507 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2509 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2510 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2513 2012-03-03 Glenn Morris <rgm@gnu.org>
2515 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2517 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2519 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2520 position past the first glyph_row that ends at ZV. (Bug#10902)
2521 (redisplay_window, next_element_from_string): Fix typos in
2523 (redisplay_window): Pass to move_it_vertically the margin in
2524 pixels, not in screen lines.
2526 2012-03-02 Glenn Morris <rgm@gnu.org>
2528 * buffer.c (buffer-list-update-hook): Doc fix.
2530 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2532 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2533 push_it before setting up the iterator for the first overlay
2534 string, even if we have an empty string loaded.
2535 (next_overlay_string): If there's an empty string on the iterator
2536 stack, pop the stack. (Bug#10903)
2538 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2540 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2541 Suggested by Stefan Monnier in
2542 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2543 * alloc.c (widen_to_Lisp_Object): New static function.
2544 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2545 and widening them to Lisp_Objects. This would work even if
2546 USE_LSB_TAG is defined and wide integers are used, which might
2547 happen in a future version of Emacs.
2549 2012-02-25 Chong Yidong <cyd@gnu.org>
2551 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2554 * xselect.c (Fx_selection_exists_p): Doc fix.
2555 (x_clipboard_manager_save_all): Print an informative message
2556 before saving to clipboard manager.
2558 2012-02-24 Chong Yidong <cyd@gnu.org>
2560 * keyboard.c (process_special_events): Handle all X selection
2561 requests in kbd_buffer, not just the next one (Bug#8869).
2563 2012-02-23 Chong Yidong <cyd@gnu.org>
2565 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2566 call when setting menu-bar-lines and tool-bar-lines parameters.
2567 (unwind_create_frame_1): New helper function.
2569 * window.c (inhibit_window_configuration_change_hook): New var.
2570 (run_window_configuration_change_hook): Obey it.
2571 (syms_of_window): Initialize it.
2573 2012-02-22 Chong Yidong <cyd@gnu.org>
2575 * xterm.c (x_draw_image_relief): Add missing type check for
2576 Vtool_bar_button_margin (Bug#10743).
2578 2012-02-21 Chong Yidong <cyd@gnu.org>
2580 * fileio.c (Vfile_name_handler_alist): Doc fix.
2582 * buffer.c (Fget_file_buffer): Protect against invalid file
2583 handler return value.
2585 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2587 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2588 when computing $valmask.
2590 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2591 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2592 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2593 It's useless in that case, and it can cause problems on hosts
2594 that allocate halves of EMACS_INT values separately.
2595 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2596 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2597 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2598 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2599 it avoids undefined behavior on hosts where shifting right by more
2600 than the word width has undefined behavior.
2602 2012-02-19 Chong Yidong <cyd@gnu.org>
2604 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2605 (Funhandled_file_name_directory, Ffile_name_as_directory)
2606 (Fdirectory_file_name, Fexpand_file_name)
2607 (Fsubstitute_in_file_name): Protect against invalid file handler
2608 return values (Bug#10845).
2610 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2612 * .gdbinit (pitx): Fix incorrect references to fields of the
2615 2012-02-17 Chong Yidong <cyd@gnu.org>
2617 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2619 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2621 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2622 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2624 2012-02-15 Chong Yidong <cyd@gnu.org>
2626 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2627 marked as special. Also, starting docstrings with * is obsolete.
2629 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2631 * gnutls.c (emacs_gnutls_write): Fix last change.
2633 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2635 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2638 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2640 * keymap.c (Fsingle_key_description): Handle char ranges.
2642 2012-02-12 Chong Yidong <cyd@gnu.org>
2644 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2645 as that creates a dangerous corner case.
2647 * window.c (Fdelete_window_internal): Invalidate the mouse
2648 highlight (Bug#9904).
2650 2012-02-12 Glenn Morris <rgm@gnu.org>
2652 * xselect.c (Fx_own_selection_internal)
2653 (Fx_get_selection_internal, Fx_disown_selection_internal)
2654 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2655 * nsselect.m (Fx_own_selection_internal)
2656 (Fx_disown_selection_internal, Fx_selection_exists_p)
2657 (Fx_selection_owner_p, Fx_get_selection_internal):
2658 Sync docs and argument specs with the xselect.c versions.
2660 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2662 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2664 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2666 * w32select.c (Fx_selection_exists_p): Sync doc string and
2667 argument list with xselect.c. (Bug#10783)
2669 * w16select.c (Fx_selection_exists_p): Sync doc string and
2670 argument list with xselect.c. (Bug#10783)
2672 2012-02-10 Glenn Morris <rgm@gnu.org>
2674 * fns.c (Fsecure_hash): Doc fix.
2676 2012-02-09 Kenichi Handa <handa@m17n.org>
2678 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2680 2012-02-07 Chong Yidong <cyd@gnu.org>
2682 * buffer.c (Fbuffer_local_variables)
2683 (buffer_lisp_local_variables): Handle unbound vars correctly;
2684 don't let Qunbound leak into Lisp.
2686 2012-02-07 Glenn Morris <rgm@gnu.org>
2688 * image.c (Fimagemagick_types): Doc fix.
2690 * image.c (imagemagick-render-type): Change it from a lisp object
2691 to an integer. Move the doc here from the lisp manual.
2692 Treat all values not equal to 0 the same.
2694 2012-02-06 Chong Yidong <cyd@gnu.org>
2696 * doc.c (store_function_docstring): Avoid applying docstring of
2697 alias to base function (Bug#2603).
2699 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2701 * .gdbinit (pp1, pv1): Remove redundant defines.
2704 2012-02-04 Chong Yidong <cyd@gnu.org>
2706 * nsterm.m: Declare a global (Bug#10694).
2708 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2710 * w32.c (get_emacs_configuration_options):
2711 Include --enable-checking, if specified, in the return value.
2713 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2715 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2716 after rounding frame sizes. (Bug#9723)
2718 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2720 * keyboard.c (adjust_point_for_property): Don't position point
2721 before BEGV. (Bug#10696)
2723 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2725 Handle overflow when computing char display width (Bug#9496).
2726 * character.c (char_width): Return EMACS_INT, not int.
2727 (char_width, c_string_width): Check for overflow when
2728 computing the width; this is possible now that individual
2729 characters can have unbounded width. Problem introduced
2730 by merge from Emacs 23 on 2012-01-19.
2732 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2734 * dbusbind.c (Fdbus_register_method): Mention the return value
2735 :ignore in the docstring.
2737 2012-02-02 Glenn Morris <rgm@gnu.org>
2739 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2741 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2742 Unconditionally set to t. (Bug#10673)
2743 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2744 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2745 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2747 2012-02-02 Kenichi Handa <handa@m17n.org>
2749 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2750 0, do not call append_composite_glyph.
2752 2012-02-02 Kenichi Handa <handa@m17n.org>
2754 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2756 (x_produce_glyphs): If the component of a composition is a null
2757 string, set it->pixel_width to 1 to avoid zero-width glyph.
2759 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2761 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2762 first 2 arguments are identical. This makes inserting large
2763 output from a subprocess an order of magnitude faster on
2764 MS-Windows, where all sbrk'ed memory is always contiguous.
2766 2012-01-31 Glenn Morris <rgm@gnu.org>
2768 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2769 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2770 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2772 2012-01-29 Glenn Morris <rgm@gnu.org>
2774 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2776 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2778 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2780 2012-01-28 Chong Yidong <cyd@gnu.org>
2782 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2784 2012-01-26 Chong Yidong <cyd@gnu.org>
2786 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2788 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2789 repeat counts (Bug#10507).
2791 2012-01-26 Glenn Morris <rgm@gnu.org>
2793 * lread.c (syms_of_lread): Doc fix.
2795 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2797 * coding.c (encode_designation_at_bol): Change return value to
2800 2012-01-25 Chong Yidong <cyd@gnu.org>
2802 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2804 2012-01-21 Chong Yidong <cyd@gnu.org>
2806 * floatfns.c (Fcopysign): Make the second argument non-optional,
2807 since nil is not allowed anyway.
2809 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2811 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2812 (send_process): Likewise.
2814 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2816 * window.c (save_window_save, Fcurrent_window_configuration)
2817 (Vwindow_persistent_parameters): Do not use Qstate.
2818 Rewrite doc-strings.
2820 2012-01-19 Kenichi Handa <handa@m17n.org>
2822 * character.c (char_width): New function.
2823 (Fchar_width, c_string_width, lisp_string_width):
2824 Use char_width (Bug#9496).
2826 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2828 * window.c (Vwindow_persistent_parameters): New variable.
2829 (Fset_window_configuration, save_window_save): Handle persistent
2832 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2834 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2835 thrashing the stack of the thread. (Bug#9087)
2837 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2839 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2841 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2843 * xdisp.c (rows_from_pos_range): Handle the case where the
2844 highlight ends on a newline. (Bug#10464)
2845 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2846 he end column for display of highlight that ends on a newline
2849 2012-01-11 Glenn Morris <rgm@gnu.org>
2851 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2852 from load-path also when installation-directory is nil. (Bug#10208)
2854 2012-01-10 Glenn Morris <rgm@gnu.org>
2856 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2858 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2859 Update template values to be closer to their typical values these days.
2861 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2863 * xdisp.c (rows_from_pos_range): Accept additional argument
2864 DISP_STRING, and accept any glyph in a row whose object is that
2865 string as eligible for mouse highlight. Fixes mouse highlight of
2866 display strings from overlays. (Bug#10464)
2868 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2870 emacs: fix an auto-save permissions race condition (Bug#10400)
2871 * fileio.c (auto_saving_dir_umask): New static var.
2872 (Fmake_directory_internal): Use it.
2873 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2874 creating the directory. The old code temporarily assigns
2875 too-generous permissions to the directory.
2876 (do_auto_save_eh): Clear it.
2877 (Fdo_auto_save): Catch all errors, not just file errors, so
2878 that the var is always cleared.
2880 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2882 * search.c (scan_buffer): Pass character positions to
2883 know_region_cache, not byte positions. (Bug#6540)
2885 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2887 * w32.c (sys_rename): Report EXDEV when rename of a directory
2888 fails because the target is on another logical disk. (Bug#10284)
2890 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2892 * xterm.c (x_embed_request_focus): New function.
2894 * xterm.h: Add prototype.
2896 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2898 2012-01-05 Glenn Morris <rgm@gnu.org>
2900 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2902 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2904 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2905 Load gnutls_transport_set_lowat only if GnuTLS version is below
2907 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2908 GnuTLS versions below 2.11.1.
2910 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2912 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2913 to the doc string advising against its use for altering the way
2914 windows are scrolled.
2916 2011-12-28 Kenichi Handa <handa@m17n.org>
2918 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2919 coding-system ASCII compatible only when it does not produce BOM
2920 on encoding (Bug#10383).
2922 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2924 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2926 (create_and_show_popup_menu): Always use menu_position_func for
2929 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2931 * callint.c (Fcall_interactively): Don't truncate prompt string.
2933 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2935 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2936 property that ends at ZV, so that the bidi iteration could be
2937 resumed from there (after widening). (Bug#10360)
2939 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2941 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2943 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2945 * nsterm.m (x_free_frame_resources):
2946 Release f->output_data.ns->miniimage.
2947 (ns_index_color): Fix indentation. Do not retain
2948 color_table->colors[i].
2950 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2953 * nsfns.m (x_set_background_color): Assign return value from
2954 ns_index_color to face-background instead of NSColor*.
2955 (ns_implicitly_set_icon_type): Fix indentation.
2956 Change assignment in for loop to comparison.
2958 * emacs.c (ns_pool): New variable.
2959 (main): Assign ns_pool.
2960 (Fkill_emacs): Call ns_release_autorelease_pool.
2962 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2963 autorelease fdesc, release fdAttrs and tdict.
2964 (ns_get_covering_families): Release charset.
2965 (ns_findfonts): Release NSFontDescriptor created with new.
2966 (ns_uni_to_glyphs): Fix indentation.
2967 (setString): Release attrStr before assigning new value.
2969 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2971 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2973 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2974 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2976 2011-12-18 David Reitter <reitter@cmu.edu>
2978 * nsterm.m (ns_term_init): Subscribe for notifications
2979 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2980 to method trackingNotification in EmacsMenu.
2982 * nsmenu.m (trackingMenu): New variable.
2983 (trackingNotification): New method (from Aquamacs).
2984 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2985 from Aquamacs (Bug#7030).
2987 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2989 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2990 (symbol_to_nsstring): Fix indentation.
2991 (ns_symbol_to_pb): New function.
2992 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2993 (Fns_rotate_cut_buffers_internal): Remove.
2994 (Fns_store_selection_internal): Rename from
2995 Fns_store_cut_buffer_internal.
2996 (ns_get_foreign_selection, Fx_own_selection_internal)
2997 (Fx_disown_selection_internal, Fx_selection_exists_p)
2998 (Fns_get_selection_internal, Fns_store_selection_internal):
2999 Use ns_symbol_to_pb and check if return value is nil.
3000 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3001 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3002 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3003 renamed to Sns_store_selection_internal.
3004 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3005 and remove this function.
3006 (ns_handle_selection_clear): Remove, never used.
3007 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3010 2011-12-17 Ken Brown <kbrown@cornell.edu>
3012 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3013 GID is unknown (Bug#10257).
3015 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3017 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3018 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3019 which caused a build failure on GNU/Linux IA-64. This problem was
3020 introduced by my 2011-10-07 patch.
3022 2011-12-15 Juri Linkov <juri@jurta.org>
3024 * image.c (imagemagick_error): New function. (Bug#10112)
3025 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3026 Use `imagemagick_error' where ImageMagick functions return
3028 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3031 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3033 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3034 fill background (Bug#8992).
3036 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3038 * window.c (Vwindow_combination_resize)
3039 (Vwindow_combination_limit): Use t instead of non-nil in
3041 (Vrecenter_redisplay): Add first sentence of doc-string on
3043 (Frecenter): Fix doc-string typo.
3045 2011-12-11 Kenichi Handa <handa@m17n.org>
3047 * coding.c (Funencodable_char_position): Pay attention to the
3048 buffer text relocation (Bug#9389).
3050 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3052 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3053 gtk_init (Bug#10100).
3055 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3057 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3058 IT->string is nil. (Bug#10263)
3060 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3062 * nsterm.h (x_free_frame_resources): Declare.
3064 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3065 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3067 * nsterm.h (ns_get_defaults_value): Declare.
3069 * nsterm.m (ns_default): Call ns_get_defaults_value.
3071 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3073 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3076 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3078 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3079 that where the value of an _OBJC_* symbol points to is in the .bss
3080 section (Bug#10240).
3082 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3084 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3085 after the loop to call ccl_driver at least once (Bug#8619).
3087 2011-12-08 Kenichi Handa <handa@m17n.org>
3089 * ftfont.c (get_adstyle_property): Fix previous change
3092 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3094 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3095 dirs from the default value of EMACSLOADPATH (bug#10208).
3097 2011-12-07 Glenn Morris <rgm@gnu.org>
3099 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3100 installation and source directories as well. (Bug#10208)
3102 2011-12-06 Chong Yidong <cyd@gnu.org>
3104 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3106 2011-12-06 Glenn Morris <rgm@gnu.org>
3108 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3109 as an error, not just -1. (Bug#10217)
3111 2011-12-05 Chong Yidong <cyd@gnu.org>
3113 * keyboard.c (process_special_events): New function.
3114 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3116 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3118 * coding.c (encode_designation_at_bol): Don't use uninitialized
3119 local variable (Bug#9318).
3121 2011-12-05 Kenichi Handa <handa@m17n.org>
3123 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3124 return Qnil (Bug#8046, Bug#10193).
3126 2011-12-05 Kenichi Handa <handa@m17n.org>
3128 * coding.c (encode_designation_at_bol): New args charbuf_end and
3129 dst. Return the number of produced bytes. Callers changed.
3130 (coding_set_source): Return how many bytes coding->source was
3132 (coding_set_destination): Return how many bytes
3133 coding->destination was relocated.
3134 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3135 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3137 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3139 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3140 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3143 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3145 The following changes are to fix Bug#9318.
3147 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3148 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3149 (encode_coding_iso_2022, encode_coding_sjis)
3150 (encode_coding_big5, encode_coding_charset): Use the above macros.
3152 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3154 * lisp.h (process_quit_flag): Fix external declaration.
3156 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3158 Don't macro-inline non-performance-critical code.
3159 * eval.c (process_quit_flag): New function.
3160 * lisp.h (QUIT): Use it.
3162 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3164 * nsfns.m (get_geometry_from_preferences): New function.
3165 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3167 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3169 * emacs.c (Qkill_emacs): Define.
3170 (syms_of_emacs): Initialize it.
3171 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3172 Qquit_flag to `kill-emacs' instead.
3173 (quit_throw_to_read_char): Add parameter `from_signal'.
3174 All callers changed. Call Fkill_emacs if requested and safe.
3175 * lisp.h (QUIT): Call Fkill_emacs if requested.
3177 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3179 * widget.c (update_wm_hints): Return if wmshell is null.
3180 (widget_update_wm_size_hints): New function.
3182 * widget.h (widget_update_wm_size_hints): Declare.
3184 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3185 widget_update_wm_size_hints (Bug#10104).
3187 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3189 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3190 before a newline, prepare the bidi iterator for consuming the
3191 newline, and keep the current paragraph direction. (Bug#10183)
3192 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3194 2011-12-02 Juri Linkov <juri@jurta.org>
3196 * search.c (Fword_search_regexp): New Lisp function created from
3197 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3198 (Fword_search_backward, Fword_search_forward)
3199 (Fword_search_backward_lax, Fword_search_forward_lax):
3200 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3201 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3203 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3205 * fileio.c (Finsert_file_contents): Move after-change-function call
3206 to before the "handled:" label, since all "goto handled" appear in
3207 cases where the *-change-functions have already been properly called
3210 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3212 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3213 waiting for input. (Bug#10169)
3215 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3217 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3218 verifies glyph row's hash code--we have just reallocated the
3219 glyphs, so their contents can be complete garbage. (Bug#10164)
3221 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3223 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3225 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3227 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3228 attributes are tested _before_ calling verify_row_hash, to protect
3229 against GCC re-ordering of the tests. (Bug#10164)
3231 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3233 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3235 * xterm.c (handle_one_xevent): Only set async_visible and friends
3236 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3237 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3238 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3240 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3242 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3243 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3244 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3245 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3246 All uses changed to use GCPRO1 etc.
3247 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3248 Revert to old implementation (i.e., before 2011-03-11).
3250 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3252 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3253 of scroll runs so as to avoid assigning disabled bogus rows and
3254 unnecessary graphics copy operations.
3256 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3258 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3259 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3260 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3261 (malloc, free, realloc, calloc): Redirect to e_* only when
3264 * lisp.h (GCTYPEBITS): Move before first use.
3265 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3266 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3267 this macro definition.
3269 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3272 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3274 * gtkutil.c (xg_create_frame_widgets):
3275 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3276 present with Gtk+ 2.0.
3278 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3280 * fileio.c (Finsert_file_contents): Undo previous change; see
3281 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3283 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3285 Rename locals to avoid shadowing.
3286 * fileio.c (Finsert_file_contents):
3287 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3288 * process.c (wait_reading_process_output):
3289 Rename inner 'proc' to 'p' to avoid shadowing.
3290 Indent for consistency with usual Emacs style.
3292 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3294 * xdisp.c (redisplay_window): If cursor row is not fully visible
3295 after recentering, and scroll-conservatively is set to a large
3296 number, scroll window by a few more lines to make the cursor fully
3297 visible and out of scroll-margin. (Bug#10105)
3298 (start_display): Don't move to the next line if the display should
3299 start at a newline that is part of a display vector or an overlay
3302 2011-11-24 Juri Linkov <juri@jurta.org>
3304 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3305 after the `MagickPingImage' call. (Bug#10112)
3307 2011-11-23 Chong Yidong <cyd@gnu.org>
3309 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3311 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3313 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3314 making another buffer current. (Bug#10114)
3316 2011-11-23 Glenn Morris <rgm@gnu.org>
3318 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3320 2011-11-23 Chong Yidong <cyd@gnu.org>
3322 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3323 using it (Bug#5984).
3325 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3327 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3328 and header-lines, as they don't have one computed for them.
3331 * .gdbinit (prow): Make displayed values more self-explaining.
3332 Add row's hash code.
3334 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3336 * process.c (wait_reading_process_output): Fix asynchrounous
3337 GnuTLS socket handling on some versions of the GnuTLS library.
3338 (wait_reading_process_output): Add comment and URL.
3340 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3342 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3344 2011-11-21 Chong Yidong <cyd@gnu.org>
3346 * window.c (Fnext_window, Fprevious_window): Doc fix.
3348 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3350 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3352 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3354 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3356 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3358 * window.c (Fset_window_combination_limit): Rename argument
3360 (Vwindow_combination_limit): Remove "status" from doc-string.
3362 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3364 * m/ibms390.h: Remove.
3365 * m/ibms390x.h: Don't include "ibms390.h".
3367 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3369 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3370 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3372 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3374 * casetab.c (Fset_case_table):
3375 * charset.c (Fcharset_after): Fix typos.
3377 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3379 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3380 Otherwise, valgrind does not work on some platforms.
3381 Problem reported by Andreas Schwab in
3382 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3383 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3384 is set, removing the need for VIRT_ADDRESS_VARIES.
3385 (PURE_P): Use a more-efficient implementation that needs just one
3386 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3387 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3388 to 4 (xorl, subq, cmpq, setbe).
3389 * alloc.c (pure): Always extern now, since that's the
3390 VIRT_ADDR_VARIES behavior.
3391 (PURE_POINTER_P): Use a single comparison, not two, for
3392 consistency with the new puresize.h.
3393 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3394 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3395 Remove VIRT_ADDR_VARIES no longer needed.
3397 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3399 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3400 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3401 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3402 behave as if the cursor position were at the window margin.
3404 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3405 and the cursor position is out of bounds, behave as if the cursor
3406 position were at the window margin. (Bug#10075)
3408 2011-11-18 Chong Yidong <cyd@gnu.org>
3410 * window.c (Fwindow_combination_limit): Make first argument
3411 non-optional, since it is meaningless for live windows like the
3414 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3416 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3418 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3420 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3421 (graft_intervals_into_buffer): Simplify.
3423 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3425 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3426 hash values of the two rows.
3427 (copy_row_except_pointers): Preserve the used[] arrays and the
3428 hash values of the two rows. (Bug#10035)
3429 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3431 * xdisp.c (row_hash): New function, body extracted from
3432 compute_line_metrics.
3433 (compute_line_metrics): Call row_hash, instead of computing the
3436 * dispnew.c (verify_row_hash): Call row_hash for computing the
3437 hash code of a row, instead of duplicating code from xdisp.c.
3439 * dispextern.h (row_hash): Add prototype.
3441 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3443 * frame.c (delete_frame): Don't delete the terminal when the last
3444 X frame is closed if emacs is built with GTK toolkit.
3446 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3448 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3450 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3452 * window.c (Vwindow_splits): Rename to
3453 Vwindow_combination_resize. Suggested by Juri Linkov.
3454 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3457 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3459 * nsfns.m (Fns_font_name):
3460 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3462 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3464 * window.h (window): Rename slot "nest" to "combination_limit".
3465 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3466 (Fset_window_nest): Rename to Fset_window_combination_limit.
3467 (Vwindow_nest): Rename to Vwindow_combination_limit.
3468 (recombine_windows, make_parent_window, make_window)
3469 (Fsplit_window_internal, saved_window)
3470 (Fset_window_configuration, save_window_save): Rename all
3471 occurrences of window_nest to window_combination_limit.
3473 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3475 * image.c (imagemagick_load_image): Fix typo.
3477 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3479 * xdisp.c (display_line): Move the call to
3480 highlight_trailing_whitespace before the call to
3481 compute_line_metrics, since the latter needs to see the final
3482 faces of all the glyphs to compute ROW's hash value.
3483 Fixes assertion violations in row_equal_p. (Bug#10035)
3485 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3487 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3488 just return (bug#10044).
3490 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3492 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3493 with user-defined heap size. Bump the default size of the temacs
3494 heap to 27MB, to avoid memory warning when running temacs.
3495 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3497 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3498 current_matrix and desired_matrix. (Bug#9990)
3499 (verify_row_hash) [XASSERTS]: New function.
3500 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3501 that the hash value of glyph rows is correct.
3503 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3505 * window.h (window): Remove splits slot.
3506 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3507 (Fdelete_other_windows_internal, make_parent_window)
3508 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3509 (Fset_window_configuration, save_window_save): Don't deal with
3510 split status of windows.
3511 (saved_window): Remove splits slot.
3512 (Vwindow_splits): Rewrite doc-string.
3514 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3516 * xfns.c (unwind_create_frame):
3517 * nsfns.m (unwind_create_frame):
3518 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3519 Vframe_list (Bug#9999).
3521 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3523 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3525 2011-11-11 Kenichi Handa <handa@m17n.org>
3527 * callproc.c (Fcall_process): Set the member dst_multibyte of
3530 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3532 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3533 avoid a crash (bug#9496).
3535 2011-11-09 Chong Yidong <cyd@gnu.org>
3537 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3538 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3540 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3542 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3544 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3546 Avoid some portability problems by eschewing 'extern inline' functions.
3547 The trivial performance wins aren't worth the portability hassles; see
3548 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3550 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3551 (window_box_width, window_box_left, window_box_left_offset)
3552 (window_box_right, window_box_right_offset): Undo previous change,
3553 by removing the "extern"s.
3554 * intervals.c (adjust_intervals_for_insertion)
3555 (adjust_intervals_for_deletion): Undo previous change,
3556 making these static again.
3557 (offset_intervals, temp_set_point_both, temp_set_point)
3558 (copy_intervals_to_string): No longer inline.
3559 * xdisp.c (window_text_bottom_y, window_box_width)
3560 (window_box_height, window_box_left_offset)
3561 (window_box_right_offset, window_box_left, window_box_right)
3562 (window_box): No longer inline.
3564 2011-11-08 Chong Yidong <cyd@gnu.org>
3566 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3567 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3568 Signal an error if not a live window.
3569 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3570 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3572 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3574 * lisp.h (syms_of_abbrev): Remove declaration.
3575 Reported by CHENG Gao <chenggao@royau.me>.
3577 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3579 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3580 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3581 of temacs in GUI mode.
3583 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3585 * window.h: Declare delete_all_child_windows instead of
3586 delete_all_subwindows.
3587 * window.c (Fwindow_nest, Fset_window_nest)
3588 (Fset_window_new_total, Fset_window_new_normal)
3589 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3590 (delete_all_subwindows): Rename to delete_all_child_windows.
3591 (Fdelete_other_windows_internal, Fset_window_configuration):
3592 Call delete_all_child_windows instead of delete_all_subwindows.
3593 * frame.c (delete_frame): Call delete_all_child_windows instead
3594 of delete_all_subwindows.
3596 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3598 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3599 This is also needed for porting to any host where GC_MARK_STACK is
3600 not GC_MAKE_GCPROS_NOOPS.
3601 (which_symbols): Use it.
3603 2011-11-07 Kenichi Handa <handa@m17n.org>
3605 * coding.c (coding_set_destination): Check coding->src_pos only
3606 when coding->src_object is a buffer (bug#9910).
3608 * process.c (send_process): Set the member src_multibyte of coding
3609 to 0 (bug#9911) when sending a unibyte text.
3611 * callproc.c (Fcall_process): Set the member src_multibyte of
3612 process_coding to 0 (bug#9912).
3614 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3616 * xmenu.c (cleanup_widget_value_tree): New function.
3617 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3618 calling free_menubar_widget_value_tree directly (Bug#9830).
3620 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3622 Fix some portability problems with 'inline'.
3623 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3624 (window_box_width, window_box_left, window_box_left_offset)
3625 (window_box_right, window_box_right_offset): Declare extern.
3626 Otherwise, these inline functions do not conform to C99 and
3627 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3628 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3629 * intervals.c (adjust_intervals_for_insertion)
3630 (adjust_intervals_for_deletion): Now extern, because otherwise the
3631 extern inline functions 'offset_intervals' couldn't refer to it.
3632 (static_offset_intervals): Remove.
3633 (offset_intervals): Rewrite using the old contents of
3634 static_offset_intervals. The old version didn't conform to C99
3635 because an extern inline function contained a reference to an
3636 identifier with static linkage.
3638 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3640 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3643 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3645 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3646 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3647 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3648 return Qleft_to_right.
3650 2011-11-06 Chong Yidong <cyd@gnu.org>
3652 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3653 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3654 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3655 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3656 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3657 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3658 (Fwindow_vscroll): Doc fix.
3659 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3660 argument, since it makes no sense to pass a live window and for
3661 consistency with window-child.
3663 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3665 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3668 2011-11-05 Jason Rumney <jasonr@gnu.org>
3670 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3671 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3673 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3674 bitwise arithmetic preventing use of unicode-sip and non-truetype
3677 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3679 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3682 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3683 initialization code to keep similarity to xfns.c after changes
3686 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3688 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3689 (unwind_create_frame): New function (Bug#9943).
3690 (Fx_create_frame): Restructure code to be more similar to the one in
3691 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3692 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3693 Move terminal->reference_count++ just before making the frame official
3696 * nsterm.m (x_free_frame_resources): New function.
3697 (x_destroy_window): Move code to x_free_frame_resources.
3699 * xfns.c (unwind_create_frame): Fix comment.
3700 (Fx_create_frame, x_create_tip_frame):
3701 Move terminal->reference_count++ just before making the frame
3702 official. Move initialization of image_cache_refcount and
3703 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3705 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3707 Support MSVC build with newer versions of Visual Studio.
3708 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3709 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3712 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3713 which are not supported by MSVC.
3714 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3715 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3717 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3719 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3721 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3723 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3725 Support MSVC build with newer versions of Visual Studio.
3726 * w32.c: Don't include w32api.h for MSVC.
3727 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3729 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3730 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3731 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3732 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3734 (alloca) [_MSC_VER]: Define to _alloca.
3736 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3738 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3740 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3742 * xdisp.c (note_mouse_highlight): If either of
3743 previous/next-single-property-change returns nil, treat that as
3744 the beginning or the end of the buffer. (Bug#9955)
3746 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3748 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3749 label is not null (Bug#9951).
3750 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3753 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3755 * window.c (Fwindow_body_size): Mention in the doc string that the
3756 return value is in frame's canonical units. (Bug#9949)
3758 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3760 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3762 * w32fns.c (unwind_create_frame): If needed, free the glyph
3763 matrices of the partially constructed frame. (Bug#9943)
3764 * xfns.c (unwind_create_frame): Likewise.
3766 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3768 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3769 Don't stop backward scan on the continuation glyph, even though
3770 its CHARPOS is positive.
3771 (mouse_face_from_buffer_pos, note_mouse_highlight):
3772 Rename cover_string to disp_string.
3774 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3776 * window.c (temp_output_buffer_show): Don't use
3777 Vtemp_buffer_show_specifiers.
3778 (Vtemp_buffer_show_specifiers): Remove unused variable.
3780 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3782 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3783 past the beginning of the current glyph matrix.
3785 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3787 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3788 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3789 HAVE_GTK3 (Bug#9869).
3791 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3792 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3794 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3796 * xterm.c: Declare x_handle_net_wm_state to return int.
3797 (handle_one_xevent): Check if we are iconified but don't have
3798 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3799 (get_current_wm_state): Return non-zero if not hidden,
3800 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3801 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3802 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3803 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3805 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3807 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3808 so that this new function doesn't get optimized away by a
3809 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3811 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3813 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3815 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3817 Fix the `xbytecode' command.
3818 * .gdbinit (xprintbytestr): New command.
3819 (xwhichsymbols): Rename from `which'; all callers changed.
3820 (xbytecode): Print the byte-code string as well.
3822 2011-10-29 Kim Storm <storm@cua.dk>
3824 * alloc.c (which_symbols): New function.
3826 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3828 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3831 2011-10-29 Glenn Morris <rgm@gnu.org>
3833 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3834 Not clear what it was for, and it causes various bugs. (Bug#9839)
3836 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3838 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3839 possible random value that matches one of those tested as
3840 condition to clear the mouse face.
3842 2011-10-28 Chong Yidong <cyd@gnu.org>
3844 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3846 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3848 * window.c (make_window): Initialize phys_cursor_on_p.
3850 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3852 * lisp.h (struct Lisp_Symbol): Update comments.
3854 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3856 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3858 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3860 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3861 <oslsachem@gmail.com> for helping to debug this.
3863 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3864 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3865 (g_b_init_get_glyph_outline_w): New static variables.
3866 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3867 (GetGlyphOutlineW_Proc): New typedefs.
3868 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3869 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3871 (w32font_open_internal, compute_metrics):
3872 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3873 instead of calling the "wide" APIs directly.
3875 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3877 * w32.h (syms_of_w32font): Add prototype.
3879 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3881 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3882 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3883 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3884 (Fmove_to_window_line): Doc fix.
3886 2011-10-27 Chong Yidong <cyd@gnu.org>
3888 * process.c (make_process): Set gnutls_state to NULL.
3890 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3891 non-NULL, regardless of GNUTLS_INITSTAGE.
3892 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3893 an error. Set process slots as soon as we allocate them.
3895 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3897 2011-10-27 Chong Yidong <cyd@gnu.org>
3899 * gnutls.c (emacs_gnutls_deinit): New function.
3900 Deallocate credentials structures as well as calling gnutls_deinit.
3901 (Fgnutls_deinit, Fgnutls_boot): Use it.
3903 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3904 (deactivate_process): Call emacs_gnutls_deinit.
3906 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3908 * image.c (x_create_x_image_and_pixmap):
3909 * w32.c (sys_rename, w32_delayed_load):
3910 * w32font.c (fill_in_logfont):
3911 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3913 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3915 * w32fns.c (w32_default_color_map): New function,
3916 extracted from Fw32_default_color_map.
3917 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3919 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3921 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3923 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3925 * keyboard.c (test_undefined): New function (bug#9751).
3926 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3928 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3930 * sysdep.c (init_sys_modes): Fix the check for the controlling
3931 terminal (Bug#6649).
3933 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3935 * dispextern.h (struct bidi_it): New member next_en_type.
3937 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3938 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3939 current character, check also for next_en_type being WEAK_EN.
3940 (bidi_resolve_weak): Don't enter the expensive loop if the current
3941 position is before next_en_pos. Record the bidi type of the first
3942 non-ET, non-BN character we find, in addition to its position.
3943 (bidi_level_of_next_char): Invalidate next_en_type when
3944 next_en_pos is over-stepped.
3946 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3948 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3949 * editfns.c: Rewrite current-time-zone so that it invokes
3950 the equivalent of (format-time-string "%Z") to get the time zone name.
3951 This fixes a bug when the time zone name contains characters that
3952 need converting from the system time locale to Emacs internal format.
3953 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3954 that patch fixed format-time-string to do the conversion, but
3955 I forgot to fix current-time-zone.
3956 (format_time_string): New function, containing most of
3957 what Fformat_time_string used to contain.
3958 (Fformat_time_string): Rewrite in terms of format_time_string.
3959 This doesn't change this function's behavior.
3960 (current-time-zone): Rewrite to use format_time_string.
3961 This fixes the bug reported by Michael Schierl in
3962 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3963 Jason Rumney's 2007-06-07 change worked around this bug, but
3965 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3967 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3969 * xdisp.c (start_display): If the character at POS is displayed
3970 via a display vector, reset IT->current.dpvec_index to zero.
3971 (try_window_reusing_current_matrix): If a line ends in a display
3972 vector or the next line starts in a display vector, continue
3973 redrawing the window even though the character position of
3974 start_row was reached.
3977 2011-10-18 Chong Yidong <cyd@gnu.org>
3979 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3980 with nobreak-char-display too.
3982 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3984 Fix part 3 of bug#9771.
3985 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3986 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3987 non-neutral characters if the current character is a paragraph
3988 separator (a.k.a. Newline). This avoids running the same
3989 expensive loop twice, once when we consume the preceding newline
3990 and the other time when the line actually needs to be displayed.
3991 Avoid the loop when we see neutrals on the base embedding level
3992 following a character whose directionality is the same as the
3993 paragraph's. This avoids running the expensive loop when a line
3994 ends in a long sequence of neutrals, like control characters.
3995 Add assertion against STRONG_AL type. Slightly rearrange code
3996 that determines the type of a neutral given the first non-neutral
3998 (bidi_level_of_next_char): Set next_en_pos to zero when
3999 invalidating its info.
4001 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4003 * xdisp.c (push_display_prop): Determine whether to record string
4004 or buffer position by IT->string, not by IT->method. Allow
4005 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4006 (move_it_vertically_backward): Don't look for character position
4007 immediately after the newline when in a continuation line.
4010 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4012 * window.c (coordinates_in_window): Rewrite and delabelize
4013 vertical border check. (Bug#5357) (Bug#9618)
4015 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4017 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4018 errors in XSetWindowBorder (bug#9310).
4020 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4022 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4023 avoid crash when xmalloc overrun checking is enabled.
4025 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4027 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4028 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4029 cursor motion with <left> and <right> arrow keys.
4031 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4032 some callers set that themselves.
4034 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4036 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4037 display string and the previous row comes from the same string and
4038 is empty. (Bug#9739) (Bug#9738)
4040 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4042 * doc.c (get_doc_string): Encode file name (bug#9735).
4044 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4046 * bidi.c (bidi_level_of_next_char):
4047 * xdisp.c (get_visually_first_element): Remove old incorrect
4048 comments regarding the Unicode Line Separator character.
4050 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4052 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4054 * alloc.c (Fgc_status): Do not access beyond zombies array
4055 boundary if nzombies > MAX_ZOMBIES.
4056 * alloc.c (dump_zombies): Add missing format specifier.
4058 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4060 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4061 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4063 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4064 Some packages use them to denote characters with modifiers.
4066 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4068 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4069 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4070 matching a pp-number. Rename parameter var to var1.
4072 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4074 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4076 2011-10-08 Glenn Morris <rgm@gnu.org>
4078 * callint.c (Fcall_interactively): Give a more explicit error for the
4079 'c' case with a non-character input. (Bug#8479)
4081 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4083 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4085 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4086 lines that are hscrolled on the left.
4088 * dispnew.c (buffer_posn_from_coords): Account for a possible
4089 presence of header-line. (Bug#4426)
4091 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4093 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4094 Don't advertise functionality which we discourage or doesn't work.
4096 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4098 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4099 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4100 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4101 this makes Emacs dump core during garbage collection on rare
4102 occasions. sizeof is obviously inferior to offsetof here, so
4103 stick with offsetof.
4104 (GC_POINTER_ALIGNMENT): New macro.
4105 (mark_memory): Omit 3rd (offset) arg; caller changed.
4106 Don't assume EMACS_INT alignment is the same as pointer alignment.
4108 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4110 * keyboard.c (read_key_sequence_remapped): New var.
4111 (read_key_sequence): Compute remapping in the right buffer.
4112 (command_loop_1): Use read_key_sequence's remapping directly.
4114 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4116 * dired.c (file_name_completion): Don't expand file name.
4117 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4118 before checking file name handler.
4120 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4121 they've been requested explicitly (bug#9591).
4123 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4125 * keymap.c (Fsingle_key_description): Use make_specified_string
4126 instead of build_string to build string from push_key_description.
4129 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4131 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4132 This fixes a Y2038 bug on 64-bit hosts.
4133 * buffer.c (reset_buffer):
4134 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4135 (Fclear_buffer_auto_save_failure):
4136 Use 0, not -1, to represent an unset failure time, since time_t
4137 might not be signed.
4139 Remove dependency on glibc malloc internals.
4140 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4141 Move back here from lisp.h, but with their new implementations.
4142 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4143 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4144 * charset.c (charset_table_init): New static var.
4145 (syms_of_charset): Use it instead of xmalloc. This removes a
4146 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4147 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4148 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4149 Move back to alloc.c.
4150 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4151 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4153 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4155 * nsterm.m (windowDidResize): Call x_set_window_size only when
4156 ns_in_resize is true. Otherwise set pixelwidth/height and
4157 call change_frame_size (Bug#9628).
4159 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4161 Port --enable-checking=all to Fedora 14 x86-64.
4162 * charset.c (syms_of_charset): Also account for glibc malloc's
4163 internal overhead when calculating the initial malloc maximum.
4165 Port --enable-checking=all to Fedora 14 x86.
4166 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4168 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4169 (overrun_check_realloc, overrun_check_free):
4170 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4171 That way, xmalloc returns a properly-aligned pointer even if
4172 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4173 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4174 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4175 into account when calculating the initial malloc maximum.
4176 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4177 Move here from alloc.c, so that charset.c can use it too.
4178 Properly align; the old code wasn't right for common 32-bit hosts
4179 when configured with --enable-checking=all.
4180 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4181 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4183 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4185 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4188 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4190 * xdisp.c (compute_display_string_end): If there's no display
4191 string at CHARPOS, return -1.
4193 * bidi.c (bidi_fetch_char): When compute_display_string_end
4194 returns a negative value, treat the character as a normal
4195 character not covered by a display string. (Bug#9624)
4197 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4199 * lread.c (Fread_from_string): Fix typo in docstring.
4201 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4203 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4204 newline, reseat the iterator instead of bidi-iterating there one
4205 character at a time. (Bug#9610)
4206 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4207 TO_CHARPOS if the bidi iterator is at base embedding level.
4209 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4211 * lread.c (readevalloop): Use correct code for NBSP.
4212 (read1): Likewise. (Bug#9608)
4214 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4216 * dbusbind.c (Fdbus_register_signal): When service is not
4217 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4219 2011-09-25 Glenn Morris <rgm@gnu.org>
4221 * buffer.c (truncate-lines): Doc fix.
4223 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4225 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4226 (Fset_window_next_buffers): Doc fix.
4228 2011-09-24 Glenn Morris <rgm@gnu.org>
4230 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4232 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4234 Fix minor problems found by static checking.
4235 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4236 * indent.c (Fvertical_motion): Fix == vs = typo.
4238 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4240 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4241 Default value is now t. Doc fix.
4243 * indent.c (Fvertical_motion): Compute and apply the overshoot
4244 logic when moving up, not only when moving down. Fix the
4245 confusing name and values of the it_overshoot_expected variable;
4246 logic changes accordingly. (Bug#9254) (Bug#9549)
4248 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4249 CHARPOS is covered by a display string which includes newlines.
4250 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4251 is covered by a display string with embedded newlines.
4253 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4255 * dbusbind.c (Fdbus_register_signal): Add match rule to
4256 Vdbus_registered_objects_table. (Bug#9581)
4257 (Fdbus_register_method, Vdbus_registered_objects_table):
4260 2011-09-24 Jim Meyering <meyering@redhat.com>
4262 do not ignore write error for any output size
4263 The previous change was incomplete.
4264 While it makes emacs --batch detect the vast majority of stdout
4265 write failures, errors were still ignored whenever the output size is
4266 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4267 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4268 && echo FAIL: ignored write error
4269 FAIL: ignored write error
4270 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4271 && echo FAIL: ignored write error
4272 FAIL: ignored write error
4273 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4275 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4277 * emacs.c (Fkill_emacs): In noninteractive mode exit
4278 non-successfully if a write error occurred on stdout. (Bug#9574)
4280 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4282 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4285 * dispextern.h (struct it): Update the comment documenting what
4288 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4290 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4291 a display string, extend search for cursor position to end of row.
4292 (find_row_edges): If the row ends in a newline from a display
4293 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4294 Handle the case of a display string with multiple newlines.
4295 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4296 non-empty line. Fixes confusing cursor motion with arrow keys at
4297 the beginning of a line that starts with whitespace.
4299 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4301 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4304 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4306 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4309 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4311 * xdisp.c (display_line): Record maximum and minimum buffer
4312 positions even if no glyphs were produced (e.g., by a zero-width
4313 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4314 buffer positions that will be removed from the glyph row because
4316 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4317 column is beyond frame width: don't subtract 1 "pixel" when
4318 computing width of the stretch.
4319 (reseat_at_next_visible_line_start): Undo the change made on
4320 2011-09-17 that saved paragraph information and restored it after
4321 the call to `reseat'. (Bug#9545)
4323 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4325 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4326 and turn window cursor on if cleared (Bug#9415).
4328 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4330 * search.c (boyer_moore): Take unibyte characters from pattern
4331 literally. (Bug#9458)
4333 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4335 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4337 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4339 Fix minor problem found by static checking.
4340 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4341 initialized, to pacify gcc -Wuninitialized.
4343 * fileio.c: Report proper errno when syscall falls.
4344 (Finsert_file_contents): Save and restore errno,
4345 so that report_file_error outputs the correct diagnostic.
4346 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4348 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4350 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4352 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4354 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4355 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4357 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4359 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4360 about the current paragraph and restore it after the call to reseat.
4362 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4363 (bidi_find_paragraph_start): Search back for paragraph beginning
4364 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4365 (bidi_move_to_visually_next): Only trigger paragraph-related
4366 computations when the last character is a newline or at EOB, not
4367 just any NEUTRAL_B. (Bug#9470)
4369 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4370 truncated lines if point is covered by a display string. (Bug#9524)
4372 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4374 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4375 (cons_to_x_long): New function.
4376 (lisp_data_to_selection_data): Use it. Correct the test for
4377 short-versus-long data; it was negated. Break out of vector
4378 loop, for efficiency, when a long datum is discovered.
4380 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4382 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4384 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4386 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4387 GCC PR/17406) by declaring this function with external scope.
4389 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4391 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4392 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4394 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4396 * editfns.c (Fformat): Correctly handle text properties on "%%".
4398 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4400 * xterm.c (x_draw_composite_glyph_string_foreground):
4401 * w32term.c (x_draw_composite_glyph_string_foreground):
4402 * term.c (encode_terminal_code):
4403 * composite.c (composition_update_it, get_composition_id):
4404 * xdisp.c (get_next_display_element)
4405 (fill_composite_glyph_string): Add comments about special meaning
4406 of TAB characters in a composition.
4408 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4410 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4411 This occurs when processing a multibyte format.
4412 Problem reported by Wolfgang Jenker.
4414 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4416 * xdisp.c (try_cursor_movement): Only check for exact match if
4417 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4419 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4421 Remove unused external symbols.
4422 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4423 * xdisp.c (calc_pixel_width_or_height): Now static.
4424 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4425 * indent.c (check_display_width):
4426 * w32term.c: Fix comment to match code.
4427 * xterm.c, xterm.h (x_catching_errors): Remove.
4429 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4431 * xselect.c: Use signed conversions more consistently (Bug#9498).
4432 (selection_data_to_lisp_data): Assume incoming selection data are
4433 signed integers, not unsigned. This is to be consistent with
4434 outgoing selection data, which was modified to use signed integers
4435 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4436 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4437 expects long, not unsigned long.
4439 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4441 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4442 computation of loop end. Reported by Johan Bockgård
4445 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4447 * frame.c (Fother_visible_frames_p): Function deleted.
4449 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4451 * indent.c (compute_motion): Process display vector front to back
4452 rather than the other way around. (Bug#2496)
4454 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4456 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4458 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4460 * minibuf.c (Fread_from_minibuffer): Doc fix.
4462 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4464 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4465 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4467 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4469 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4470 value for non-existent files.
4472 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4474 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4475 set its "size" to -1. This will set the modtime_size field of
4476 the corresponding buffer to -1, which is what
4477 verify-visited-file-modtime expects for files that do not exist.
4480 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4482 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4484 * lisp.h: ... from here. push_key_description is no longer
4485 defined in keyboard.c, so its declaration should not be in
4486 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4487 logically belongs with push_key_description.
4489 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4491 * buffer.h: Include <sys/types.h> instead of <time.h>.
4492 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4493 Problem reported by Herbert J. Skuhra.
4495 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4497 * xml.c (parse_region): Make the parsing work for
4498 non-comment-starting XML files again (bug#9144).
4500 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4502 * image.c (gif_load): Fix calculation of bottom and right corner.
4505 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4507 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4508 redisplay in small windows.
4510 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4512 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4514 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4516 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4517 Operate on live windows only.
4519 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4521 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4523 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4525 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4526 only under bidi iteration.
4528 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4530 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4532 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4534 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4535 Without this fix, the command to link temacs failed due to an
4536 undefined symbol __builtin_isnan. This is because
4537 /usr/include/iso/math_c99.h #defines isnan(x) to
4538 __builtin_isnan(x), but the bundled gcc, which identifies itself
4539 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4541 * floatfns.c (isnan): #undef, and then #define to a clone of
4543 (Fisnan): Always define, since it's always available now.
4544 (syms_of_floatfns): Always define isnan at the Lisp level.
4546 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4548 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4550 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4552 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4553 The previous code assumed that file offsets (off_t values) fit in
4554 EMACS_INT variables, which is not true on typical 32-bit hosts.
4555 The code messed up by falsely reporting buffer overflow in cases
4556 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4557 when "big" contains more than 2**29 bytes, even though this
4558 inserts just one byte and does not overflow the buffer.
4559 (Finsert_file_contents): Store file offsets as off_t
4560 values, not as EMACS_INT values. Check for overflow when
4561 converting between EMACS_INT and off_t. When checking for
4562 buffer overflow or for overlap, take the offsets into account.
4563 Don't use EMACS_INT for small values where int suffices.
4564 When checking for overlap, fix a typo: ZV was used where
4565 ZV_BYTE was intended.
4566 (Fwrite_region): Don't assume off_t fits into 'long'.
4567 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4569 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4571 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4573 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4575 sprintf-related integer and memory overflow issues (Bug#9412).
4577 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4578 (esprintf, exprintf, evxprintf): New functions.
4579 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4580 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4581 (modify_event_symbol): Do not assume that the length of
4582 name_alist_or_stem is safe to alloca and fits in int.
4583 (Fexecute_extended_command): Likewise for function name and binding.
4584 (Frecursion_depth): Wrap around reliably on integer overflow.
4585 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4586 since some callers pass EMACS_INT values.
4587 (Fsingle_key_description): Don't crash if symbol name contains more
4588 than MAX_ALLOCA bytes.
4589 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4590 (get_minibuffer): Arg is now EMACS_INT, not int.
4591 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4592 (esprintf, exprintf, evxprintf): New decls.
4593 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4595 * dbusbind.c (signature_cat): New function.
4596 (xd_signature, Fdbus_register_signal):
4597 Do not overrun buffer; instead, report string overflow.
4599 * dispnew.c (add_window_display_history): Don't overrun buffer.
4600 Truncate instead; this is OK since it's just a log.
4602 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4603 even if the time zone offset is outlandishly large.
4604 Don't mishandle offset == INT_MIN.
4606 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4607 when creating daemon; the previous buffer-overflow check was incorrect.
4609 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4610 which has the guts of the old verror function.
4612 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4613 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4615 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4616 (font_unparse_xlfd): Don't blindly alloca long strings.
4617 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4618 fits in int, when using sprintf. Use single snprintf to count
4619 length of string rather than counting it via multiple sprintfs;
4620 that's simpler and more reliable.
4621 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4622 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4623 sprintf, in case result does not fit in int.
4625 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4626 (fontset_from_font): Print it.
4628 * frame.c (tty_frame_count): Now printmax_t, not int.
4629 (make_terminal_frame, set_term_frame_name): Print it.
4630 (x_report_frame_params): In X, window IDs are unsigned long,
4631 not signed long, so print them as unsigned.
4632 (validate_x_resource_name): Check for implausibly long names,
4633 and don't assume name length fits in 'int'.
4634 (x_get_resource_string): Don't blindly alloca invocation name;
4635 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4638 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4639 (xg_check_special_colors, xg_set_geometry):
4640 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4642 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4643 Use esprintf, not sprintf, in case result does not fit in int.
4645 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4646 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4647 it as a large positive number.
4648 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4649 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4651 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4652 in case result does not fit in int.
4654 * print.c (float_to_string): Detect width overflow more reliably.
4655 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4656 buffer overrun. Don't assume list length fits in 'int'. Treat
4657 print length of 0 as 0, not as infinity; to be consistent with other
4658 uses of print length in this function. Don't overflow print length
4659 index. Don't assume hash table size fits in 'long', or that
4660 vectorlike size fits in 'unsigned long'.
4662 * process.c (make_process): Use printmax_t, not int, to format
4663 process-name gensyms.
4665 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4667 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4668 to avoid potential buffer overrun.
4670 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4671 if X resource line is longer than 512 bytes.
4673 * xfns.c (x_window): Make sprintf buffer a bit bigger
4674 to avoid potential buffer overrun.
4676 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4678 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4680 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4682 Integer overflow fixes for scrolling, etc.
4683 Without these, Emacs silently mishandles large integers sometimes.
4684 For example, "C-u 4294967297 M-x recenter" was treated as if
4685 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4687 * xdisp.c (try_window_id): Check Emacs fixnum range before
4688 converting to 'int'.
4690 * window.c (window_scroll_line_based, Frecenter):
4691 Check that an Emacs fixnum is in range before assigning it to 'int'.
4692 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4693 values converted from Emacs fixnums.
4694 (Frecenter): Don't wrap around a line count if it is out of 'int'
4695 range; instead, treat it as an extreme value.
4696 (Fset_window_configuration, compare_window_configurations):
4697 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4699 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4700 that can exceed INT_MAX. Check that EMACS_INT value is in range
4701 before assigning it to the (possibly-narrower) index.
4702 (match_limit): Don't assume that a fixnum can fit in 'int'.
4704 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4707 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4708 (Fvertical_motion): Don't wrap around LINES values that don't fit
4709 in 'int'. Instead, treat them as extreme values. This is good
4710 enough for windows, which can't have more than INT_MAX lines anyway.
4712 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4714 * Require libxml/parser.h to avoid compilation warning.
4716 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4718 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4719 since this reportedly can destroy thread storage.
4721 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4723 * syntax.c (find_defun_start): Update all cache variables if
4724 exiting early (Bug#9401).
4726 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4728 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4730 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4731 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4732 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4734 * term.c (tty_append_glyph): New function.
4735 (produce_stretch_glyph): Static function and its prototype deleted.
4737 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4740 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4742 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4743 when checking :margin (Bug#9390).
4744 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4745 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4746 so that the name doesn't mislead. All uses changed.
4748 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4750 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4753 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4755 * xdisp.c (move_it_to): Don't bail out early when reaching
4756 position beyond to_charpos, if we are scanning backwards.
4757 (move_it_vertically_backward): When DY == 0, make sure we get to
4758 the first character in the line after the newline.
4760 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4762 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4763 (ccl_driver): Do not generate an out-of-range pointer.
4764 (Fccl_execute_on_string): Remove unnecessary check for
4765 integer overflow, noted by Stefan Monnier in
4766 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4767 Remove a FIXME that didn't need fixing.
4768 Simplify the newly-introduced buffer reallocation code.
4770 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4772 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4774 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4776 Integer and memory overflow issues (Bug#9196).
4778 * doc.c (get_doc_string): Rework so that
4779 get_doc_string_buffer_size is the actual buffer size, rather than
4780 being 1 less than the actual buffer size; this makes xpalloc more
4783 * image.c (x_allocate_bitmap_record, cache_image):
4784 * xselect.c (Fx_register_dnd_atom):
4785 Simplify previous changes by using xpalloc.
4787 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4788 since either will do and ptrdiff_t is convenient with xpalloc.
4790 * charset.c (charset_table_size)
4791 (struct charset_sort_data.priority): Now ptrdiff_t.
4792 (charset_compare): Don't overflow if priorities differ greatly.
4793 (Fsort_charsets): Don't assume list length fits in int.
4794 Check for size-calculation overflow when allocating sort data.
4795 (syms_of_charset): Allocate an initial charset table that is
4796 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4798 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4800 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4801 The actual value is always <= INT_MAX, and leaving it unsigned made
4802 overflow checking harder.
4804 * dispextern.h (struct glyph_matrix.rows_allocated)
4805 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4806 with xpalloc. The values are still always <= INT_MAX.
4808 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4810 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4811 (SAFE_NALLOCA): New macro.
4813 * region-cache.c (struct boundary.pos, find_cache_boundary)
4814 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4815 (set_cache_region, invalidate_region_cache)
4816 (revalidate_region_cache, know_region_cache, region_cache_forward)
4817 (region_cache_backward, pp_cache):
4818 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4819 so that ptrdiff_t * can be passed to xpalloc.
4820 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4821 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4822 (pp_cache): Don't assume cache_len fits in int.
4823 * region-cache.h: Adjust extern decls to match.
4825 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4826 EMACS_INT, since either will do, for xpalloc.
4828 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4829 (xnmalloc, xnrealloc, xpalloc): New functions.
4831 * bidi.c (bidi_shelve_header_size): New constant.
4832 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4833 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4835 * bidi.c (bidi_cache_shrink):
4836 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4838 Don't update size of array until after memory allocation succeeds,
4839 because xmalloc/xrealloc may not return.
4840 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4841 now that we have proper integer overflow checking.
4842 (record_overlay_string, overlay_strings): Catch overflows when
4843 calculating size of overlay_str_buf.
4845 * callproc.c (Fcall_process): Check for size overflow when
4846 calculating size of args2.
4847 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4848 Normally we prefer signed values, but sticking with ptrdiff_t would
4849 require adding more-complicated checks.
4851 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4852 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4853 Redo buffer-overflow calculations to avoid integer overflow.
4854 Add a FIXME comment where memory seems to be over-allocated.
4856 * character.c (Fstring): Check for size-calculation overflow.
4858 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4859 unnecessary integer overflow. Check for size overflow.
4860 (encode_coding_object): Don't update size until xmalloc succeeds.
4862 * composite.c (get_composition_id): Check for overflow in glyph
4863 length calculations.
4865 Integer and memory overflow fixes for display code.
4866 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4867 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4868 (scrolling_window): Check for overflow in size calculations.
4869 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4870 Don't assume glyph table len fits in int.
4871 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4872 (row_table_size): Now ptrdiff_t, not int.
4873 (scrolling_window): Avoid overflow in size calculations.
4874 Don't update size until allocation succeeds.
4875 * fns.c (concat): Check for overflow in size calculations.
4876 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4877 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4878 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4880 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4881 (get_doc_string): Check for size calculation overflow.
4882 Don't update size until allocation succeeds.
4883 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4884 EMACS_INT, where ptrdiff_t will do.
4885 (Fsubstitute_command_keys): Check for string overflow.
4887 * editfns.c (set_time_zone_rule): Don't assume environment length
4889 (message_length): Now ptrdiff_t, not int.
4890 (Fmessage_box): Don't update size until allocation succeeds.
4891 Don't assume message length fits in int.
4892 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4894 * emacs.c (main): Do not reallocate argv, since there is a null at
4895 the end that can be overwritten, and this way there's no need to
4896 worry about size-calculation overflow.
4897 (sort_args): Check for size-calculation overflow.
4899 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4901 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4903 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4904 (x_set_scroll_bar_width, x_figure_window_size):
4905 Check for integer overflow.
4906 (x_set_alpha): Do not assume XINT fits in int.
4908 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4909 This is for the members text_lines, text_cols, total_lines, total_cols,
4910 where the system imposes an 'int' limit.
4912 * fringe.c (Fdefine_fringe_bitmap):
4913 Don't update size until alloc works.
4915 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4916 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4918 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4919 Check for size-calculation overflow.
4920 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4921 do, as we prefer signed integers.
4922 (id_to_widget.max_size, id_to_widget.used)
4923 (xg_store_widget_in_map, xg_remove_widget_from_map)
4924 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4925 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4926 Use and return ptrdiff_t, not int.
4927 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4928 * gtkutil.h: Change prototypes to match the above.
4930 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4931 are duplicate now that they've been promoted to lisp.h.
4932 (x_allocate_bitmap_record, x_alloc_image_color)
4933 (make_image_cache, cache_image, xpm_load):
4934 Don't update size until alloc is done.
4935 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4937 Check for size calculation overflow.
4938 (ct_colors_allocated_max): New constant.
4939 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4942 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4943 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4944 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4945 Use ptrdiff_t, not int, to count maps.
4946 (read_char_minibuf_menu_prompt): Check for overflow in size
4947 calculations. Don't update size until allocation succeeds.
4948 Redo calculations to avoid overflow.
4949 * keyboard.h: Change prototypes to match the above.
4951 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4953 (current_minor_maps): Check for size calculation overflow.
4954 * keymap.h: Change prototypes to match the above.
4956 * lread.c (read1, init_obarray): Don't update size until alloc done.
4958 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4959 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4961 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4962 Now ptrdiff_t, not int.
4963 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4964 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4966 * process.c (Fnetwork_interface_list): Check for overflow
4967 in size calculation.
4969 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4971 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4972 overflow. Don't bother calling xmalloc when xrealloc will do.
4974 * search.c (Freplace_match): Check for size calculation overflow.
4975 (Fset_match_data): Don't assume list lengths fit in 'int'.
4977 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4978 for command line length. Do not attempt to address one before the
4979 beginning of an array, as that's not portable.
4981 * term.c (max_frame_lines): Remove; unused.
4982 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4984 (encode_terminal_code, calculate_costs): Check for size
4985 calculation overflow.
4986 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4987 table lengths and related sizes. Don't update size until alloc
4988 done. Redo calculations to avoid overflow.
4989 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4991 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4992 subtracting pointers.
4993 (gobble_line): Check for overflow more carefully. Don't update size
4996 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4997 Don't update size until alloc done.
4998 Redo size calculations to avoid overflow.
4999 Check for size calculation overflow.
5000 (main) [DEBUG]: Fix typo in invoking tparam1.
5002 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5003 Use ptrdiff_t, not int, for sizes.
5004 (store_mode_line_noprop_char): Don't update size until alloc done.
5006 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5007 Use ptrdiff_t, not int, for sizes.
5008 (Finternal_make_lisp_face, cache_face):
5009 Check for size calculation overflow.
5010 (cache_face): Treat size calculation overflows as if they were
5011 memory exhaustion (the usual treatment), rather than aborting.
5013 * xfns.c (x_encode_text, x_set_name_internal)
5014 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5015 sizes, since they can exceed INT_MAX in size. Check for size
5016 calculation overflow.
5018 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5019 (xg_select): Check for size calculation overflow.
5020 Don't update size until alloc done.
5022 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5023 as sprintf is limited to int lengths.
5025 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5026 (X_LONG_MIN): New macros.
5027 Use them to make the following changes clearer.
5028 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5029 This change doesn't affect the value now, but it may help remind
5030 future maintainers not to raise the value too much later.
5031 (SELECTION_QUANTUM): Remove, replacing with ...
5032 (selection_quantum): ... new function, which avoids overflow.
5034 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5035 assumption that selection length fits in 'int'.
5036 (x_reply_selection_request, x_handle_selection_request)
5037 (x_get_window_property, receive_incremental_selection)
5038 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5039 (lisp_data_to_selection_data, clean_local_selection_data):
5040 Use ptrdiff_t, not int, to record length of selection.
5041 (x_reply_selection_request, x_get_window_property)
5042 (receive_incremental_selection, x_property_data_to_lisp):
5043 Redo calculations to avoid overflow.
5044 (x_reply_selection_request): When sending hint, ceiling it at
5045 X_LONG_MAX rather than relying on wraparound overflow to send
5047 (x_get_window_property, receive_incremental_selection)
5048 (lisp_data_to_selection_data, x_property_data_to_lisp):
5049 Check for size-calculation overflow.
5050 (x_get_window_property, receive_incremental_selection)
5051 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5052 Don't store size until memory allocation succeeds.
5053 (x_get_window_property): Plug memory leak on memory exhaustion.
5054 Don't double-block input; malloc is safe here. Don't assume 2**34
5055 - 4 fits in unsigned long. Add an xassert to check
5056 XGetWindowProperty overflow. Be more careful about overflow
5057 calculations, and distinguish size from memory overflow better.
5058 (receive_incremental_selection): When tracing, don't assume
5059 unsigned int is less than INT_MAX.
5060 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5061 harmful) conversions of unsigned short to int.
5062 (lisp_data_to_selection_data): Don't assume that integers
5063 in the range -65535 through -1 fit in an X unsigned short.
5064 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5065 result parameters unless successful. Rely on cons_to_unsigned
5066 to report problems with elements; the old code wasn't right anyway.
5067 (x_check_property_data): Check for int overflow; we cannot use
5068 a wider type due to X limits.
5069 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5071 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5073 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5074 (x_term_init): Check for size calculation overflow.
5075 (x_color_cells): Don't store size until memory allocation succeeds.
5076 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5077 Don't assume alloca size is less than MAX_ALLOCA.
5078 (x_term_init): Don't assume length fits in int (sprintf is limited
5081 Use ptrdiff_t for composition IDs.
5082 * character.c (lisp_string_width):
5083 * composite.c (composition_table_size, n_compositions)
5084 (get_composition_id, composition_gstring_from_id):
5085 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5086 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5087 * window.c (Frecenter):
5088 Use ptrdiff_t, not int, for composition IDs.
5089 * composite.c (get_composition_id): Check for integer overflow.
5090 * composite.h: Adjust prototypes to match the above changes.
5092 Use ptrdiff_t for hash table indexes.
5093 * category.c (hash_get_category_set):
5094 * ccl.c (ccl_driver):
5095 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5096 * coding.c (coding_system_charset_list, detect_coding_system):
5097 * coding.h (struct coding_system.id):
5098 * composite.c (get_composition_id, gstring_lookup_cache):
5099 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5100 * image.c (xpm_get_color_table_h):
5101 * lisp.h (hash_lookup, hash_put):
5102 * minibuf.c (Ftest_completion):
5103 Use ptrdiff_t for hash table indexes, not int (which is too
5104 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5105 32-bit --with-wide-int hosts).
5107 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5108 Add a FIXME comment about memory leaks.
5109 (syms_of_charset): Don't assume xmalloc returns.
5111 Don't assume that stated character widths fit in int.
5112 * character.c (Fchar_width, c_string_width, lisp_string_width):
5113 * character.h (CHAR_WIDTH):
5114 * indent.c (MULTIBYTE_BYTES_WIDTH):
5115 Use sanitize_char_width to avoid undefined and/or bad behavior
5116 with outlandish widths.
5117 * character.h (sanitize_tab_width): Rename from sanitize_width,
5118 now that we have two such functions. All uses changed.
5119 (sanitize_char_width): New inline function.
5121 Don't assume that tab-width fits in int.
5122 * character.h (sanitize_width): New inline function.
5123 (SANE_TAB_WIDTH): New macro.
5124 (ASCII_CHAR_WIDTH): Use it.
5125 * indent.c (sane_tab_width): Remove. All uses replaced by
5126 SANE_TAB_WIDTH (current_buffer).
5127 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5129 * fileio.c: Integer overflow issues with file modes.
5130 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5132 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5133 Remove unreachable code.
5134 (read_hex, load_charset_map_from_file): Check for integer overflow.
5136 * xterm.c: Don't go over XClientMessageEvent limit.
5137 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5138 (x_send_scroll_bar_event): Likewise. Check that the size does not
5139 exceed limits imposed by XClientMessageEvent, as well as the usual
5140 ptrdiff_t and size_t limits.
5142 * keyboard.c: Overflow, signedness and related fixes.
5143 (make_lispy_movement): Use same integer type in forward decl
5144 that is used in the definition.
5145 (read_key_sequence, keyremap_step):
5146 Change bufsize argument back to int, undoing my 2011-03-30 change.
5147 We prefer signed types, and int is wide enough here.
5148 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5149 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5150 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5151 length, not size_t. Use ptrdiff_t for index, not int.
5152 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5153 possibility of integer overflow.
5155 Overflow, signedness and related fixes for images.
5157 * dispextern.h (struct it.stack[0].u.image.image_id)
5158 (struct_it.image_id, struct image.id, struct image_cache.size)
5159 (struct image_cache.used, struct image_cache.ref_count):
5160 * gtkutil.c (update_frame_tool_bar):
5161 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5162 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5163 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5164 * nsmenu.m (update_frame_tool_bar):
5165 * xdisp.c (calc_pixel_width_or_height):
5166 * xfns.c (image_cache_refcount):
5167 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5168 on typical 64-bit hosts.
5170 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5171 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5172 Omit unnecessary casts to int.
5173 (parse_image_spec): Check that integers fall into 'int' range
5174 when the callers expect that.
5175 (image_ascent): Redo ascent calculation to avoid int overflow.
5176 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5177 (lookup_image): Remove unnecessary tests.
5178 (xbm_image_p): Locals are now of int, not EMACS_INT,
5179 since parse_image_check makes sure they fit into int.
5180 (png_load, gif_load, svg_load_image):
5181 Prefer int to unsigned where either will do.
5182 (tiff_handler): New function, combining the cores of the
5183 old tiff_error_handler and tiff_warning_handler.
5184 This function is rewritten to use vsnprintf and thereby avoid
5185 stack buffer overflows. It uses only the features of vsnprintf
5186 that are common to both POSIX and native Microsoft.
5187 (tiff_error_handler, tiff_warning_handler): Use it.
5188 (tiff_load, gif_load, imagemagick_load_image):
5189 Don't assume :index value fits in 'int'.
5190 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5191 (imagemagick_load_image): Check that crop parameters fit into
5192 the integer types that MagickCropImage accepts. Don't assume
5193 Vimagemagick_render_type has a nonnegative value. Don't assume
5194 size_t fits in 'long'.
5195 (gs_load): Use printmax_t to print the widest integers possible.
5196 Check for integer overflow when computing image height and width.
5198 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5200 * xdisp.c (redisplay_window): Don't force window start if point
5201 will be invisible in the resulting window. (Bug#9324)
5203 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5205 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5206 the display spec is of the form `(space ...)'.
5207 (handle_display_spec): Return the value returned by
5208 handle_single_display_spec, not just 1 or zero.
5209 (handle_single_display_spec): If the display spec is of the form
5210 `(space ...)', and specifies display in the text area, return 2
5212 (try_cursor_movement): Check for the need to scroll more
5213 accurately, and prefer exact match for point under bidi.
5214 Don't advance `row' beyond the last row of the window.
5216 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5217 into disp_prop; all users changed.
5219 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5220 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5221 for the text covered by the display property.
5223 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5225 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5226 Change return value to nil.
5227 (Frecord_buffer): Delete unused function.
5229 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5231 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5232 buffers, return left-to-right.
5233 (set_cursor_from_row): Consider candidate row a win if its glyph
5234 represents a newline and point is on that newline. Fixes cursor
5235 positioning on the newline at EOL of R2L text within L2R
5236 paragraph, and vice versa.
5237 (try_cursor_movement): Check continued rows, in addition to
5238 continuation rows. Fixes unwarranted scroll when point enters a
5239 continued line of R2L text within an L2R paragraph, or vice versa.
5240 (cursor_row_p): Consider the case of point being equal to
5241 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5242 from the end of a short line to the beginning of a continued line
5243 of R2L text within L2R paragraph.
5244 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5245 composed characters.
5247 * bidi.c (bidi_check_type): Use xassert.
5248 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5251 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5253 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5256 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5258 * nsfont.m (ns_otf_to_script): Fix typo.
5260 2011-08-22 Kenichi Handa <handa@m17n.org>
5262 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5263 extra slot even if the purpose is char-code-property-table.
5265 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5267 * xdisp.c (redisplay_window): When computing centering_position,
5268 account for the height of the header line. (Bug#8874)
5270 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5271 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5272 candidate is selected by the mouse, and that candidate has a
5273 composed character under the mouse.
5275 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5276 coordinates reported by pos-visible-in-window-p for a composed
5277 character in column zero.
5279 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5281 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5283 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5285 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5286 consider it a hit if to_charpos is anywhere in the range of the
5287 composed buffer positions.
5289 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5291 * image.c (gif_load): Don't assume that each subimage has the same
5292 dimensions as the base image. Handle disposal method that is
5293 "undefined" by the gif spec (Bug#9335).
5295 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5297 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5298 (Fcondition_case): Document `debug' symbol in error handler.
5300 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5302 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5303 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5304 from an Org mode buffer to a Speedbar frame.
5306 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5307 a composition, take its buffer position from IT->cmp_it.charpos.
5308 Fixes cursor positioning at the beginning of a line that begins
5309 with a composed character.
5311 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5313 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5314 character bidirectional type, use STRONG_L instead. Fixes crashes
5315 in a buffer produced by `describe-categories'.
5317 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5318 members before the level stack, so they would be saved and
5319 restored when copying iterator state. Fixes incorrect reordering
5320 around TABs covered by display properties.
5322 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5324 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5326 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5328 * eval.c (internal_condition_case, internal_condition_case_1)
5329 (internal_condition_case_2, internal_condition_case_n):
5330 Remove unnecessary aborts (Bug#9081).
5332 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5334 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5335 has no `load' handler, try opening the file locally. (Bug#9311)
5337 2011-08-16 Ken Brown <kbrown@cornell.edu>
5339 * gmalloc.c: Expand comment.
5341 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5343 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5344 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5346 2011-08-16 Ken Brown <kbrown@cornell.edu>
5348 Fix memory allocation problems in Cygwin build (Bug#9273).
5350 * unexcw.c ( __malloc_initialized): Declare external variable.
5351 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5353 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5355 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5357 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5359 [CYGWIN] (special_realloc): New function.
5360 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5361 requests to realloc storage in the static heap.
5363 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5365 * bidi.c (bidi_initialize): Remove unused local.
5367 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5370 * biditype.h: Remove file.
5371 * makefile.w32-in ($(BLD)/bidi.$(O)):
5372 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5374 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5376 * chartab.c: Improve commentary for the uniprop_table API.
5378 * bidi.c (bidi_paragraph_init): Support zero value of
5379 bidi_ignore_explicit_marks_for_paragraph_level.
5380 (bidi_initialize): Use uniprop_table instead of including
5381 biditype.h and bidimirror.h.
5383 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5384 coordinates of the iterator when restoring from ppos_it.
5387 2011-08-14 Kenichi Handa <handa@m17n.org>
5389 * process.c (create_process): Call setup_process_coding_systems
5390 after the pid of the process is set to -1 (Bug#8162).
5392 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5394 * xdisp.c (move_it_in_display_line_to): Don't invoke
5395 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5396 ppos_it. Fixes vertical cursor motion when line beginning is
5397 covered by an image. (Bug#9296)
5399 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5401 * nsterm.h (ns_run_ascript): Declare.
5402 (NSAPP_DATA2_RUNASSCRIPT): Define.
5404 * nsfns.m (as_script, as_result, as_status): New static variables.
5405 (ns_run_ascript): New function.
5406 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5407 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5408 the event loop. Get status from as_status (Bug#7276).
5410 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5411 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5412 the event loop (Bug#7276).
5414 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5416 * gnutls.c (QCgnutls_bootprop_priority)
5417 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5418 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5419 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5420 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5421 (QCgnutls_bootprop_verify_hostname_error)
5422 (QCgnutls_bootprop_callbacks_verify): Rename from
5423 Qgnutls_bootprop_..., all uses changed.
5425 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5428 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5430 * xfaces.c (Qframe_set_background_mode): Now static.
5431 * dispextern.h (Qframe_set_background_mode): Remove decl.
5433 * process.c (Fnetwork_interface_info): Declare local only if needed.
5435 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5437 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5438 (Fnetwork_interface_list): Allocate in increments of bytes instead
5439 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5440 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5442 (struct ifflag_def): notrailers is smart on OSX.
5443 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5444 Get hardware address with getifaddrs if available.
5446 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5448 * xdisp.c (iterate_out_of_display_property): xassert that
5449 IT->position is set to within IT->object's boundaries. Break from
5450 the loop as soon as EOB is reached; avoids infloops in redisplay
5451 when IT->position is set up wrongly due to some bug.
5452 Set IT->current to match the bidi iterator unconditionally.
5453 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5454 entry. Force push_it to save on the stack the current
5455 buffer/string position, to be restored by pop_it. Fix flags in
5456 the iterator structure wrt the object coming from a display
5457 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5458 properties. (Bug#9284)
5460 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5462 * fontset.c (fontset_get_font_group): Add proper type checks.
5465 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5467 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5468 and LC_VERSION_MIN_MACOSX.
5469 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5470 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5472 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5474 * xdisp.c (forward_to_next_line_start): Allow to use the
5475 no-display-properties-and-no-overlays under bidi display.
5476 Set disp_pos in the bidi iterator to avoid searches for display
5477 properties and overlays.
5479 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5481 * editfns.c (Fset_time_zone_rule): Document relationship with the
5484 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5485 the font entity extracted from the cache (Bug#8109).
5487 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5489 * composite.c (autocmp_chars): Don't reset point. That is done by
5490 restore_point_unwind (Bug#5984).
5492 2011-08-07 Juri Linkov <juri@jurta.org>
5494 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5495 to show the arg `TIME' instead of `TIMEVAL'.
5497 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5499 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5500 display property strides EOL and includes a newline, as in
5501 longlines-mode. (Bug#9254)
5502 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5503 word-wrap under bidirectional display. (Bug#9224)
5505 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5506 is non-zero, even if the data buffer is NULL. Fixes a crash in
5507 vertical-motion with longlines-mode. (Bug#9254)
5509 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5511 * bidi.c <bidi_cache_total_alloc>: Now static.
5512 (bidi_initialize): Initialize bidi_cache_total_alloc.
5514 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5517 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5518 amount allocated this far in `bidi_cache_total_alloc'.
5519 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5520 non-zero, only free the data buffer without restoring the cache
5521 contents. All callers changed.
5523 * dispextern.h (bidi_unshelve_cache): Update prototype.
5525 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5526 (move_it_in_display_line, move_it_to)
5527 (move_it_vertically_backward, move_it_by_lines): Replace the call
5528 to xfree to an equivalent call to bidi_unshelve_cache.
5529 (move_it_in_display_line_to): Fix logic of returning
5530 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5532 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5534 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5535 came from a string character with a `cursor' property. (Bug#9229)
5537 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5539 * Makefile.in (LIB_PTHREAD): New variable.
5540 (LIBES): Add LIB_PTHREAD (Bug#9216).
5542 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5543 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5545 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5547 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5549 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5551 * xterm.c (x_find_topmost_parent): New function.
5552 (x_set_frame_alpha): Find topmost parent window with
5553 x_find_topmost_parent and set the property there also (bug#9181).
5554 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5556 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5558 * callproc.c (Fcall_process): Avoid vfork clobbering
5559 the local vars buffer, coding_systems, current_dir.
5561 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5563 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5565 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5567 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5568 so that it is not optimized away.
5570 * xdisp.c (compute_display_string_pos): Remove unused local.
5572 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5574 Fix slow cursor motion and scrolling in large buffers with
5575 selective display, like Org Mode buffers. (Bug#9218)
5577 * dispextern.h (struct bidi_it): New member disp_prop_p.
5579 * xdisp.c: Remove one-slot cache of display string positions.
5580 (compute_display_string_pos): Accept an additional argument
5581 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5582 for a display string or property. If found, set DISP_PROP_P
5585 * bidi.c (bidi_fetch_char): Accept an additional argument
5586 DISP_PROP_P, and pass it to compute_display_string_pos.
5587 Only handle text covered by a display string if DISP_PROP_P is returned
5588 non-zero. All callers of bidi_fetch_char changed.
5590 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5592 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5594 2010-12-03 Don March <don@ohspite.net>
5596 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5597 last character M-[char] is translated to ESC [char] (bug#7541).
5599 2011-08-02 Kenichi Handa <handa@m17n.org>
5601 * lisp.h (uniprop_table): Extern it.
5603 * chartab.c (uniprop_table): Make it non-static.
5605 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5607 * xdisp.c (forward_to_next_line_start): Accept additional argument
5608 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5610 (reseat_at_next_visible_line_start): Use the bidi iterator state
5611 returned by forward_to_next_line_start to restore the state of
5612 it->bidi_it after backing up to previous newline. (Bug#9212)
5614 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5616 * regex.c (re_comp): Protoize.
5617 (re_exec): Fix return type.
5618 (regexec): Fix type of `ret'. (Bug#9203)
5620 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5622 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5623 This is needed if max-image-size is a floating-point number.
5625 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5627 * print.c (print_object): Print empty symbol as ##.
5629 * lread.c (read1): Read ## as empty symbol.
5631 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5633 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5634 setting frame foreground color (Bug#9175).
5635 (x_set_background_color): Likewise.
5637 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5638 contents (Bug#9176).
5639 (EmacsTooltip -init): Remove bezels and add shadows to
5642 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5643 or scroll bar (Bug#8470).
5645 * nsfont.m (nsfont_open): Remove assignment to voffset and
5646 unnecessary vars hshink, expand, hd, full_height, min_height.
5647 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5649 * nsterm.h (nsfont_info): Remove voffset field.
5651 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5653 Implement strike-through and overline on NextStep (Bug#8863).
5655 * nsfont.m (nsfont_open): Use underline position provided by font,
5656 instead of hard-coded value of 2.
5657 (nsfont_draw): Call ns_draw_text_decoration instead.
5659 * nsterm.h: Add declaration for ns_draw_text_decoration.
5661 * nsterm.m (ns_draw_text_decoration): New function for drawing
5662 underline, overline, and strike-through.
5663 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5664 ns_draw_text_decoration. Change treatment of cursor drawing to
5665 accommodate underlining, etc.
5667 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5669 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5672 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5674 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5675 Without this fix, if a signal arrives just after memory fills up,
5676 'malloc' might be invoked reentrantly.
5678 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5679 In other words, assume that every image size is allowed, on non-X
5680 hosts. This assumption is probably wrong, but it lets Emacs compile.
5682 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5684 * regex.c (re_iswctype): Convert return values to boolean.
5686 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5688 * xdisp.c (compute_display_string_pos): Don't use cached display
5689 string position if the buffer had its restriction changed.
5692 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5694 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5696 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5698 Integer signedness and overflow and related fixes. (Bug#9079)
5700 * bidi.c: Integer size and overflow fixes.
5701 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5702 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5703 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5704 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5705 (bidi_find_other_level_edge):
5706 Use ptrdiff_t instead of EMACS_INT where either will do.
5707 This works better on 32-bit hosts configured --with-wide-int.
5708 (bidi_cache_ensure_space): Check for size-calculation overflow.
5709 Use % rather than repeated addition, for better worst-case speed.
5710 Don't set bidi_cache_size until after xrealloc returns, because it
5712 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5713 (bidi_cache_ensure_space): Also check that the bidi cache size
5714 does not exceed that of the largest Lisp string or buffer. See Eli
5715 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5717 * alloc.c (__malloc_size_t): Remove.
5718 All uses replaced by size_t. See Andreas Schwab's note
5719 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5721 * image.c: Improve checking for integer overflow.
5722 (check_image_size): Assume that f is nonnull, since
5723 it is always nonnull in practice. This is one less thing to
5724 worry about when checking for integer overflow later.
5725 (x_check_image_size): New function, which checks for integer
5726 overflow issues inside X.
5727 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5728 This removes the need for a memory_full check.
5729 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5730 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5731 (xbm_read_bitmap_data): Change locals back to 'int', since
5732 their values must fit in 'int'.
5733 (xpm_load_image, png_load, tiff_load):
5734 Invoke x_create_x_image_and_pixmap earlier,
5735 to avoid much needless work if the image is too large.
5736 (tiff_load): Treat overly large images as if
5737 x_create_x_image_and_pixmap failed, not as malloc failures.
5738 (gs_load): Use x_check_image_size.
5740 * gtkutil.c: Omit integer casts.
5741 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5742 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5744 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5746 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5747 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5748 would wrongly return t on a 64-bit host.
5750 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5751 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5752 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5753 and therefore cause GCC to emit a bogus diagnostic in some cases.
5755 * image.c: Integer signedness and overflow and related fixes.
5756 This is not an exhaustive set of fixes, but it's time to
5757 record what I've got.
5758 (lookup_pixel_color, check_image_size): Remove redundant decls.
5759 (check_image_size): Don't assume that arbitrary EMACS_INT values
5760 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5761 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5762 (tiff_load, imagemagick_load_image):
5763 Check for overflow in size calculations.
5764 (x_create_x_image_and_pixmap): Remove unnecessary test for
5765 xmalloc returning NULL; that can't happen.
5766 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5767 (xpm_color_bucket): Use better integer hashing function.
5768 (xpm_cache_color): Don't possibly over-allocate memory.
5769 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5770 (gif_memory_source):
5771 Use ptrdiff_t, not int or size_t, to record sizes.
5772 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5773 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5774 either works, as we prefer signed integers.
5775 (tiff_read_from_memory, tiff_write_from_memory):
5776 Return tsize_t, not size_t, since that's what the TIFF API wants.
5777 (tiff_read_from_memory): Don't fail simply because the read would
5778 go past EOF; instead, return a short read.
5779 (tiff_load): Omit no-longer-needed casts.
5780 (Fimagemagick_types): Don't assume size fits into 'int'.
5782 Improve hashing quality when configured --with-wide-int.
5783 * fns.c (hash_string): New function, taken from sxhash_string.
5784 Do not discard information about ASCII character case; this
5785 discarding is no longer needed.
5786 (sxhash-string): Use it. Change sig to match it. Caller changed.
5787 * lisp.h: Declare it.
5788 * lread.c (hash_string): Remove, since we now use fns.c's version.
5789 The fns.c version returns a wider integer if --with-wide-int is
5790 specified, so this should help the quality of the hashing a bit.
5792 * emacs.c: Integer overflow minor fix.
5793 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5794 Define only if GNU_LINUX.
5795 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5797 * dispnew.c: Integer signedness and overflow fixes.
5798 Remove unnecessary forward decls, that were a maintenance hassle.
5799 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5801 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5802 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5803 (prepare_desired_row, line_draw_cost):
5804 Use int, not unsigned, where either works.
5805 (save_current_matrix, restore_current_matrix):
5806 Use ptrdiff_t, not size_t, where either works.
5807 (init_display): Check for overflow more accurately, and without
5808 relying on undefined behavior.
5810 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5811 Remove, replacing with the new symbols in lisp.h. All uses changed.
5812 * fileio.c (make_temp_name):
5813 * filelock.c (lock_file_1, lock_file):
5814 * xdisp.c (message_dolog):
5815 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5816 Use pMd etc. instead.
5817 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5818 replacing the pWIDE etc. symbols removed from editfns.c.
5820 * keyboard.h (num_input_events): Now uintmax_t.
5821 This is (very slightly) less likely to mess up due to wraparound.
5824 * buffer.c: Integer signedness fixes.
5825 (alloc_buffer_text, enlarge_buffer_text):
5826 Use ptrdiff_t rather than size_t when either will do, as we prefer
5829 * alloc.c: Integer signedness and overflow fixes.
5830 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5831 (__malloc_size_t): Default to size_t, not to int.
5832 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5833 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5834 Prefer ptrdiff_t to size_t when either would do, as we prefer
5836 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5837 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5838 Now const. Initialize with values that are in range even if char
5840 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5841 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5842 These functions do the right thing with sizes > 2**32.
5843 (check_depth): Now ptrdiff_t, not int.
5844 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5845 Adjust to new way of storing sizes. Check for size overflow bugs
5847 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5848 slightly wrong anyway, as it missed one instance of
5849 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5850 (refill_memory_reserve): Omit needless cast to size_t.
5851 (mark_object_loop_halt): Mark as externally visible.
5853 * xselect.c: Integer signedness and overflow fixes.
5854 (Fx_register_dnd_atom, x_handle_dnd_message):
5855 Use ptrdiff_t, not size_t, since we prefer signed.
5856 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5857 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5858 x_dnd_atoms_size and x_dnd_atoms_length.
5860 * doprnt.c: Prefer signed to unsigned when either works.
5862 * doprnt.c (doprnt):
5864 * xdisp.c (vmessage):
5865 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5866 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5867 prefer signed arithmetic to avoid comparison confusion.
5868 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5869 but is a bit tricky.
5871 Assume freestanding C89 headers, string.h, stdlib.h.
5872 * data.c, doprnt.c, floatfns.c, print.c:
5873 Include float.h unconditionally.
5874 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5875 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5876 * regex.c: Likewise for stddef.h, string.h.
5877 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5878 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5879 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5880 (STDC_HEADERS): Remove obsolete defines.
5881 * sysdep.c: Include limits.h unconditionally.
5883 Assume support for memcmp, memcpy, memmove, memset.
5884 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5885 * regex.c (memcmp, memcpy):
5886 Remove; we assume C89 now.
5888 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5889 (__malloc_safe_bcopy): Remove; no longer needed.
5891 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5892 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5893 well either way, and we prefer signed to unsigned.
5895 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5897 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5898 closes the connection while we're reading (bug#9182).
5900 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5902 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5903 are specified (Bug#9168).
5905 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5907 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5908 Found by GCC static checking and --with-wide-int on a 32-bit host.
5910 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5912 * xdisp.c (compute_display_string_pos): Fix logic of caching
5913 previous display string position. Initialize cached_prev_pos to
5914 -1. Fixes slow-down at the beginning of a buffer.
5916 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5918 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5919 for attrs[LFACE_FONTSET_INDEX].
5921 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5923 * xml.c (parse_region): Remove unused local
5924 that was recently introduced.
5926 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5928 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5929 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5931 * xdisp.c (move_it_in_display_line_to): Record the best matching
5932 position for TO_CHARPOS while scanning the line, and restore it on
5933 exit if none of the characters scanned was an exact match.
5934 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5935 when exact match is impossible due to invisible text, and the
5936 lines are truncated.
5938 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5940 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5943 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5945 Fix a significant slow-down of cursor motion with C-n, C-p,
5946 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5947 auto-repeat under bidi redisplay in fontified buffers.
5948 * xdisp.c (compute_stop_pos_backwards): New function.
5949 (next_element_from_buffer): Call compute_stop_pos_backwards to
5950 find a suitable prev_stop when we find ourselves before
5952 (reseat): Don't look for prev_stop, as that could mean a very long
5954 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5955 <cached_disp_overlay_modiff>: Cache for last found display string
5957 (compute_display_string_pos): Return the cached position if asked
5958 about the same buffer in the same area of character positions, and
5959 the buffer wasn't changed since the time the display string
5960 position was cached.
5962 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5964 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5965 is an integer, which is important for empty lines. (Bug#9149)
5967 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5969 * frame.c (Fmodify_frame_parameters): In tty case, update the
5970 default face if necessary (Bug#4238).
5972 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5974 * editfns.c (Fstring_to_char): No need to explain what a character
5975 is in the docstring (Bug#6576).
5977 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5979 * xml.c (parse_region): Make sure we always return a tree.
5981 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5983 * xml.c (parse_region): If a document contains only comments,
5986 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5988 * xml.c (make_dom): Return comments, too.
5990 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5993 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5994 and the surrounding thread.
5995 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5996 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5997 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5999 * s/openbsd.h (BROKEN_SIGIO): Define.
6000 * unexelf.c (unexec) [__OpenBSD__]:
6001 Don't update the .mdebug section of the Alpha COFF symbol table.
6003 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6005 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6008 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6010 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6011 This fixes some race conditions on the permissions of any newly
6014 * alloc.c (valid_pointer_p): Use pipe, not open.
6015 This fixes some permissions issues when debugging.
6017 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6018 If fchown fails to set both uid and gid, try to set just gid,
6019 as that is sometimes allowed. Adjust the file's mode to eliminate
6020 setuid or setgid bits that are inappropriate if fchown fails.
6022 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6024 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6025 to compare Lisp_Objects.
6026 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6027 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6028 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6030 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6032 * lread.c (read_integer): Unread even EOF character.
6033 (read1): Likewise. Properly record start position of symbol.
6035 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6036 symbol character follows.
6038 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6040 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6041 This works around a problem with the previous change to Fcopy_file.
6042 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6043 and without this change, GCC might complain about discarding
6044 fchown's return value.
6046 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6048 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6050 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6052 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6054 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6056 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6057 it's used from the C level.
6059 * process.c: Use the same condition for POLL_FOR_INPUT in both
6060 keyboard.c and process.c (bug#1858).
6062 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6064 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6065 (Fgnutls_boot): Use it.
6067 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6069 * doc.c (Fsubstitute_command_keys): Revert last change.
6071 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6073 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6074 quotes the next character, and doesn't affect other longer
6075 sequences (bug#8935).
6077 * lread.c (syms_of_lread): Clarify that is isn't only
6078 `eval-buffer' and `eval-defun' that's affected by
6079 `lexical-binding' (bug#8460).
6081 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6083 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6084 bidi redisplay when a line includes both an image and is truncated.
6086 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6088 Fix minor problems found by static checking.
6089 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6090 (elsz): Now a signed constant, not a size_t var. We prefer signed
6091 types to unsigned, to avoid integer comparison confusion. Without
6092 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6093 "cannot optimize loop, the loop counter may overflow", a symptom
6095 * indent.c (Fvertical_motion): Mark locals as initialized.
6096 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6098 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6100 * search.c (Fre_search_backward): Mention `case-fold-search' in
6101 all the re_search_* functions (bug#8138).
6103 * keyboard.c (Fopen_dribble_file): Document when the file is
6106 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6108 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6111 Support bidi reordering of display and overlay strings.
6112 * xdisp.c (compute_display_string_pos)
6113 (compute_display_string_end): Accept additional argument STRING.
6114 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6115 (reseat_to_string): Initialize bidi_it->string.s and
6116 bidi_it->string.schars.
6117 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6118 NULL (avoids a crash in bidi_paragraph_init).
6119 Initialize itb.string.lstring.
6120 (init_iterator): Call bidi_init_it only of a valid
6121 buffer position was specified. Initialize paragraph_embedding to
6123 (reseat_to_string): Initialize the bidi iterator.
6124 (display_string): If we need to ignore text properties of
6125 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6126 original value of -1 will not work with bidi.)
6127 (compute_display_string_pos): First arg is now struct
6128 `text_pos *'; all callers changed. Support display properties on
6130 (compute_display_string_end): Support display properties on Lisp
6132 (init_iterator, reseat_1, reseat_to_string): Initialize the
6133 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6134 when iterating on a string not from display properties).
6135 (compute_display_string_pos, compute_display_string_end):
6136 Fix calculation of the object to scan. Fixes an error when using
6138 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6139 base_level_stop; instead, set base_level_stop to BEGV.
6140 Fixes crashes in vertical-motion.
6141 (next_element_from_buffer): Improve commentary for when
6142 the iterator is before prev_stop.
6143 (init_iterator): Initialize bidi_p from the default value of
6144 bidi-display-reordering, not from buffer-local value. Use the
6145 buffer-local value only if initializing for buffer iteration.
6146 (handle_invisible_prop): Support invisible properties on strings
6147 that are being bidi-reordered.
6148 (set_iterator_to_next): Support bidi reordering of C strings and
6150 (next_element_from_string): Support bidi reordering of Lisp
6152 (handle_stop_backwards): Support Lisp strings as well.
6153 (display_string): Support display of R2L glyph rows.
6154 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6155 (init_iterator): Don't initialize it->bidi_p for strings
6157 (reseat_to_string): Initialize it->bidi_p for strings here.
6158 (next_element_from_string, next_element_from_c_string)
6159 (next_element_from_buffer): Add xassert's for correspondence
6160 between IT's object being iterated and it->bidi_it.string
6162 (face_before_or_after_it_pos): Support bidi iteration.
6163 (next_element_from_c_string): Handle the case of the first string
6164 character that is not the first one in the visual order.
6165 (get_visually_first_element): New function, refactored from common
6166 parts of next_element_from_buffer, next_element_from_string, and
6167 next_element_from_c_string.
6168 (tool_bar_lines_needed, redisplay_tool_bar)
6169 (display_menu_bar): Force left-to-right direction. Add a FIXME
6170 comment for making that be controlled by a user option.
6171 (push_it, pop_it): Save and restore the state of the
6172 bidi iterator. Save and restore the bidi_p flag.
6173 (pop_it): Iterate out of display property for string iteration as
6175 (iterate_out_of_display_property): Support iteration over strings.
6176 (handle_single_display_spec): Set up it->bidi_it for iteration
6177 over a display string, and call bidi_init_it.
6178 (handle_single_display_spec, next_overlay_string)
6179 (get_overlay_strings_1, push_display_prop): Set up the bidi
6180 iterator for displaying display or overlay strings.
6181 (forward_to_next_line_start): Don't use the shortcut if
6183 (back_to_previous_visible_line_start): If handle_display_prop
6184 pushed the iterator stack, restore the internal state of the bidi
6185 iterator by calling bidi_pop_it same number of times.
6186 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6187 and we are bidi-iterating, don't decrement the iterator position;
6188 instead, set the first_elt flag in the bidi iterator, to produce
6190 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6191 (push_display_prop): xassert that we are iterating a buffer.
6192 (push_it, pop_it): Save and restore paragraph_embedding member.
6193 (handle_single_display_spec, next_overlay_string)
6194 (get_overlay_strings_1, reseat_1, reseat_to_string)
6195 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6196 correctly. Don't assume unibyte strings are not bidi-reordered.
6197 (compute_display_string_pos)
6198 (compute_display_string_end): Fix handling the case of C string.
6199 (push_it, pop_it): Save and restore from_disp_prop_p.
6200 (handle_single_display_spec, push_display_prop): Set the
6201 from_disp_prop_p flag.
6202 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6203 (pop_it): Call iterate_out_of_display_property only if we are
6204 popping after iteration over a string that came from a display
6205 property. Fix a typo in popping stretch info. Add an assertion
6206 for verifying that the iterator position is in sync with the bidi
6208 (handle_single_display_spec, get_overlay_strings_1)
6209 (push_display_prop): Fix initialization of paragraph direction for
6210 string when that of the parent object is not yet determined.
6211 (reseat_1): Call bidi_init_it to resync the bidi
6212 iterator with IT's position. (Bug#7616)
6213 (find_row_edges): If ROW->start.pos gives position
6214 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6215 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6216 Reset the from_disp_prop_p flag.
6217 (SAVE_IT, RESTORE_IT): New macros.
6218 (pos_visible_p, face_before_or_after_it_pos)
6219 (back_to_previous_visible_line_start)
6220 (move_it_in_display_line_to, move_it_in_display_line)
6221 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6222 (try_scrolling, redisplay_window, display_line): Use them when
6223 saving a temporary copy of the iterator and restoring it back.
6224 (back_to_previous_visible_line_start, reseat_1)
6225 (init_iterator): Empty the bidi cache "stack".
6226 (move_it_in_display_line_to): If iterator ended up at
6227 EOL, but we never saw any buffer positions smaller than
6228 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6229 motion in bidi-reordered lines.
6230 (move_it_in_display_line_to): Record prev_method and prev_pos
6231 immediately before the call to set_iterator_to_next. Fixes cursor
6232 motion in bidi-reordered lines with stretch glyphs and strings
6233 displayed in margins. (Bug#8133) (Bug#8867)
6234 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6236 (pos_visible_p): Support positions in bidi-reordered lines.
6237 Save and restore bidi cache.
6239 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6240 (bidi_paragraph_info): Delete unused struct.
6241 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6242 (bidi_cache_start): New variable.
6243 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6245 (bidi_cache_fetch_state, bidi_cache_search)
6246 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6247 (bidi_cache_find, bidi_peek_at_next_level)
6248 (bidi_level_of_next_char, bidi_find_other_level_edge)
6249 (bidi_move_to_visually_next): Compare cache index with
6250 bidi_cache_start rather than with zero.
6251 (bidi_fetch_char): Accept new argument STRING; all callers
6252 changed. Support iteration over a string. Support strings with
6253 display properties. Support unibyte strings. Fix the type of
6254 `len' according to what STRING_CHAR_AND_LENGTH expects.
6255 (bidi_paragraph_init, bidi_resolve_explicit_1)
6256 (bidi_resolve_explicit, bidi_resolve_weak)
6257 (bidi_level_of_next_char, bidi_move_to_visually_next):
6258 Support iteration over a string.
6259 (bidi_set_sor_type, bidi_resolve_explicit_1)
6260 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6261 can now be zero (for strings); special values 0 and -1 were
6262 changed to -1 and -2, respectively.
6263 (bidi_char_at_pos): New function.
6264 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6265 Call it instead of FETCH_MULTIBYTE_CHAR.
6266 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6267 initialized to valid values.
6268 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6270 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6271 the test for valid cached positions. Fix the logic for looking up
6272 the sentinel state in the cache. GCPRO the Lisp string we are
6274 (bidi_push_it, bidi_pop_it): New functions.
6275 (bidi_initialize): Initialize the bidi cache start stack pointer.
6276 (bidi_cache_ensure_space): New function, refactored from part of
6277 bidi_cache_iterator_state. Don't assume the required size is just
6278 one BIDI_CACHE_CHUNK away.
6279 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6280 (bidi_count_bytes, bidi_char_at_pos): New functions.
6281 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6282 always valid if bidi_cache_idx is valid.
6283 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6284 is valid if it's going to be used.
6285 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6286 (bidi_cache_fetch_state, bidi_cache_search)
6287 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6288 (bidi_cache_iterator_state, bidi_cache_find)
6289 (bidi_find_other_level_edge, bidi_cache_start_stack):
6290 All variables related to cache indices are now EMACS_INT.
6292 * dispextern.h (struct bidi_string_data): New structure.
6293 (struct bidi_it): New member `string'. Make flag members be 1-bit
6294 fields, and put them last in the struct.
6295 (compute_display_string_pos, compute_display_string_end):
6297 (bidi_push_it, bidi_pop_it): Add prototypes.
6298 (struct iterator_stack_entry): New members bidi_p,
6299 paragraph_embedding, and from_disp_prop_p.
6300 (struct it): Member bidi_p is now a bit field 1 bit wide.
6301 (bidi_shelve_cache, bidi_unshelve_cache):
6304 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6305 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6306 and vector-like objects.
6308 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6309 cache around display iteration.
6311 * window.c (Fwindow_end, window_scroll_pixel_based)
6312 (displayed_window_lines, Frecenter): Save and restore the bidi
6313 cache around display iteration.
6315 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6317 * editfns.c (Fdelete_region): Clarify the use of the named
6318 parameters (bug#6788).
6320 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6322 * indent.c (Fvertical_motion): Set and restore w->pointm when
6323 saving and restoring the window's buffer (Bug#9006).
6325 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6327 * editfns.c (Fstring_to_char): Clarify just what is returned
6328 (bug#6576). Text by Eli Zaretskii.
6330 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6332 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6334 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6336 * buffer.c (mmap_find): Fix a typo.
6338 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6340 Fix execution of x selection hooks.
6341 * xselect.c (Qx_lost_selection_functions)
6342 (Qx_sent_selection_functions): New vars.
6343 (syms_of_xselect): DEFSYM them.
6344 (x_handle_selection_request): Pass Qx_sent_selection_functions
6345 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6346 (x_handle_selection_clear,x_clear_frame_selections):
6347 Pass Qx_lost_selection_functions rather than
6348 Vx_lost_selection_functions to Frun_hook_with_args.
6350 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6352 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6353 The old code sometimes used this field without initializing it.
6355 * alloc.c (gc_sweep): Don't read past end of array.
6356 In theory, the old code could also have corrupted Emacs internals,
6357 though it'd be very unlikely.
6359 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6361 * character.c (Fcharacterp): Don't advertise optional ignored
6362 argument. (Bug#4026)
6364 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6366 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6369 * window.c (Fset_window_start): Doc fix (bug#4199).
6370 (Fset_window_hscroll): Ditto.
6372 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6374 Fix minor new problems caught by GCC 4.6.1.
6375 * term.c (init_tty): Remove unused local.
6376 * xsettings.c (store_monospaced_changed): Define this function only
6377 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6380 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6382 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6384 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6386 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6387 are the mini-buffer and the echo area (bug#3320).
6389 * term.c (init_tty): Remove support for supdup, c10 and perq
6390 terminals, which are no longer supported (bug#1482).
6392 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6394 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6396 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6398 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6399 for non-popups (Bug#3642).
6401 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6403 * alloc.c (reset_malloc_hooks): Protoize.
6404 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6405 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6406 * cm.c (losecursor): Likewise.
6407 * data.c (fmod): Likewise.
6408 * dispnew.c (swap_glyphs_in_rows): Likewise.
6409 * emacs.c (memory_warning_signal): Likewise.
6410 * floatfns.c (float_error): Likewise.
6411 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6412 (otf_open, font_otf_capability, generate_otf_features)
6413 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6415 * image.c (pbm_read_file): Likewise.
6416 * indent.c (string_display_width): Likewise.
6417 * intervals.c (check_for_interval, search_for_interval)
6418 (inc_interval_count, count_intervals, root_interval)
6419 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6420 * lread.c (defalias): Likewise.
6421 * ralloc.c (r_alloc_check): Likewise.
6422 * regex.c (set_image_of_range_1, set_image_of_range)
6423 (regex_grow_registers): Likewise.
6424 * sysdep.c (strerror): Likewise.
6425 * termcap.c (valid_filename_p, tprint, main): Likewise.
6426 * tparam.c (main): Likewise.
6427 * unexhp9k800.c (run_time_remap, save_data_space)
6428 (update_file_ptrs, read_header, write_header, calculate_checksum)
6429 (copy_file, copy_rest, display_header): Likewise.
6430 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6432 * xdisp.c (check_it): Likewise.
6433 * xfaces.c (register_color, unregister_color, unregister_colors):
6435 * xfns.c (print_fontset_result): Likewise.
6436 * xrdb.c (member, fatal, main): Likewise.
6438 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6440 Fix minor problems found by static checking (Bug#9031).
6441 * chartab.c (char_table_set_range, map_sub_char_table):
6442 Remove unused locals.
6443 (uniprop_table): Now static.
6444 * composite.c (_work_char): Remove unused static var.
6446 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6448 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6450 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6452 * gtkutil.c (qttip_cb): Remove code without function.
6454 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6456 * w32.c (pthread_sigmask): New stub.
6458 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6460 Use pthread_sigmask, not sigprocmask (Bug#9010).
6461 sigprocmask is portable only for single-threaded applications, and
6462 Emacs can be multi-threaded when it uses GTK.
6463 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6465 * callproc.c (Fcall_process):
6466 * process.c (create_process):
6467 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6468 Use pthread_sigmask, not sigprocmask.
6470 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6472 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6473 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6476 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6478 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6479 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6480 (xg_hide_tooltip): Fix comment.
6482 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6483 in registerServicesMenuSendTypes.
6484 (validRequestorForSendType): Don't check ns_return_types.
6486 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6489 2011-07-08 Jason Rumney <jasonr@gnu.org>
6491 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6492 SH_SHOW for hidden windows (Bug#5482).
6494 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6495 frame struct members of non-existent frames (Bug#6284).
6497 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6499 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6500 variable firstTime not needed on OSX >= 10.6.
6501 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6502 >= 10.5. Use setKnobProportion, setDoubleValue.
6504 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6505 (MAC_OS_X_VERSION_10_5): Define if not defined.
6506 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6507 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6508 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6510 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6511 cString and lossyCString on OSX >= 10.4
6513 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6514 sizeToFit on OSX >= 10.2.
6516 * nsimage.m (allocInitFromFile): Don't use deprecated method
6517 bestRepresentationForDevice on OSX >= 10.6.
6519 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6522 * emacs.c: Declare unexec_init_emacs_zone.
6524 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6526 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6528 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6529 on svcsMenu (Bug#8842).
6531 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6533 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6535 * nsterm.m (QUTF8_STRING): Declare.
6536 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6537 (validRequestorForSendType): Return type is (id).
6538 Change indexOfObjectIdenticalTo to indexOfObject.
6539 Check if we have local selection before returning self (Bug#8842).
6540 (writeSelectionToPasteboard): Put local selection into paste board
6541 if we have a local selection (Bug#8842).
6542 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6544 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6545 (ns_get_local_selection): Declare.
6547 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6549 * keymap.c (describe_map_tree): Don't insert a double newline at
6550 the end of the buffer (bug#1169) and return whether we inserted
6553 * callint.c (Fcall_interactively): Change "reading args" to
6554 "providing args" to try to clarify what it does (bug#1010).
6556 2011-07-07 Kenichi Handa <handa@m17n.org>
6558 * composite.c (composition_compute_stop_pos): Ignore a static
6559 composition starting before CHARPOS (Bug#8915).
6561 * xdisp.c (handle_composition_prop): Likewise.
6563 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6565 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6568 2011-07-07 Kenichi Handa <handa@m17n.org>
6570 * character.h (unicode_category_t): New enum type.
6572 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6573 (Qchar_code_property_table): New variable.
6574 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6575 (UNIPROP_COMPRESSED_FORM_P): New macros.
6576 (char_table_ascii): Uncompress the compressed values.
6577 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6578 Uncompress the compressed values.
6579 (sub_char_table_ref_and_range): Likewise.
6580 (char_table_ref_and_range): Uncompress the compressed values.
6581 (sub_char_table_set): New arg is_uniprop. Callers changed.
6582 Uncompress the compressed values.
6583 (sub_char_table_set_range): Args changed. Callers changed.
6584 (char_table_set_range): Adjuted for the above change.
6585 (map_sub_char_table): Delete args default_val and parent. Add arg
6586 top. Give decoded values to a Lisp function.
6587 (map_char_table): Adjust for the above change. Give decoded
6588 values to a Lisp function. Gcpro more variables.
6589 (uniprop_table_uncompress)
6590 (uniprop_decode_value_run_length): New functions.
6591 (uniprop_decoder, uniprop_decoder_count): New variables.
6592 (uniprop_get_decoder, uniprop_encode_value_character)
6593 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6595 (uniprop_encoder, uniprop_encoder_count): New variables.
6596 (uniprop_get_encoder, uniprop_table)
6597 (Funicode_property_table_internal, Fget_unicode_property_internal)
6598 (Fput_unicode_property_internal): New functions.
6599 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6600 Sunicode_property_table_internal, Sget_unicode_property_internal,
6601 and Sput_unicode_property_internal. Defvar_lisp
6602 char-code-property-alist.
6604 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6605 Vunicode_category_table.
6607 * font.c (font_range): Adjust for the change of
6608 Vunicode_category_table.
6610 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6612 * m/iris4d.h: Remove file, move contents ...
6613 * s/irix6-5.h: ... here.
6615 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6617 Remove unportable assumption about struct layout (Bug#8884).
6618 * alloc.c (mark_buffer):
6619 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6620 (clone_per_buffer_values): Don't assume that
6621 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6622 This isn't true in general, and it's particularly not true
6623 if Emacs is configured with --with-wide-int.
6624 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6625 New macros, used in the buffer.c change.
6627 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6629 * xsettings.c: Use both GConf and GSettings if both are available.
6630 (store_config_changed_event): Add comment.
6631 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6632 (store_tool_bar_style_changed): New functions.
6633 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6634 (struct xsettings): Move font inside HAVE_XFT.
6635 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6636 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6637 Move inside HAVE_XFT.
6638 (something_changed_gsettingsCB): Rename from something_changedCB.
6639 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6641 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6642 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6643 (something_changed_gconfCB): Rename from something_changedCB.
6644 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6645 (parse_settings): Move check for font inside HAVE_XFT.
6646 (read_settings, apply_xft_settings): Add comment.
6647 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6648 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6649 call store_font_name_changed.
6650 (xft_settings_event): Add comment.
6651 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6652 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6653 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6654 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6655 (xsettings_initialize): Call init_gsettings last.
6656 (xsettings_get_system_font, xsettings_get_system_normal_font):
6659 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6661 Random fixes. E.g., (random) never returned negative values.
6662 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6663 subseconds part to the entropy, as that's a bit more random.
6664 Prefer signed to unsigned, since the signedness doesn't matter and
6665 in general we prefer signed. When given a limit, use a
6666 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6667 latter isn't right if USE_2_TAGS_FOR_INTS.
6668 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6669 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6671 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6673 * textprop.c (text_property_stickiness):
6674 Obey Vtext_property_default_nonsticky.
6675 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6676 * w32fns.c (syms_of_w32fns):
6677 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6679 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6681 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6682 This is more efficient than Ffile_directory_p and avoids a minor race.
6684 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6686 * buffer.c (Foverlay_put): Say what the return value is
6689 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6690 is a directory before asking whether to use the file name
6692 (barf_or_query_if_file_exists): Make the "File is a directory"
6693 error be more correct.
6695 * fns.c (Frequire): Remove the mention of the .gz files, since
6696 that's installation-specific, but keep the mention of
6697 `get-load-suffixes'.
6699 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6701 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6702 Report string overflow if the output is too long.
6704 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6706 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6707 (syms_of_gnutls): Remove duplicate DEFSYM for
6708 Qgnutls_bootprop_verify_hostname_error, an error for
6709 Qgnutls_bootprop_verify_error (which is no longer used).
6711 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6712 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6713 Also (re)move comments that are misplaced or no longer relevant.
6715 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6717 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6719 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6721 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6722 and background color parameters if they have been changed.
6724 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6726 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6728 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6730 * xsettings.c (SYSTEM_FONT): Define only when used.
6731 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6733 * keymap.c (access_keymap_1): Now static.
6735 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6737 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6738 leave any prefix arg for the up event (Bug#1586).
6740 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6742 * lread.c (syms_of_lread): Mention single symbols defined by
6743 `defvar' or `defconst' (bug#7154).
6745 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6746 (Frequire): Mention get-load-suffixes.
6748 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6750 * window.h (window): Remove clone_number slot.
6751 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6753 (make_parent_window, make_window, saved_window)
6754 (Fset_window_configuration, save_window_save): Don't deal with
6756 * buffer.c (Qclone_number): Remove declaration.
6757 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6759 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6761 Add multiple inheritance to keymaps.
6762 * keymap.c (Fmake_composed_keymap): New function.
6763 (Fset_keymap_parent): Simplify.
6764 (fix_submap_inheritance): Remove.
6765 (access_keymap_1): New function extracted from access_keymap to handle
6766 embedded parents and handle lists of maps.
6767 (access_keymap): Use it.
6768 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6769 (Fcopy_keymap): Handle embedded parents.
6770 (Fcommand_remapping, define_as_prefix): Simplify.
6771 (Fkey_binding): Simplify.
6772 (syms_of_keymap): Move minibuffer-local-completion-map,
6773 minibuffer-local-filename-completion-map,
6774 minibuffer-local-must-match-map, and
6775 minibuffer-local-filename-must-match-map to Elisp.
6776 (syms_of_keymap): Defsubr make-composed-keymap.
6777 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6778 (parse_menu_item): Trivial simplification.
6780 2011-07-01 Glenn Morris <rgm@gnu.org>
6782 * Makefile.in (SETTINGS_LIBS): Fix typo.
6784 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6786 * coding.c (Fencode_coding_string): Record the last coding system
6787 used, as the function doc string says (bug#8738).
6789 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6791 * xsettings.c (store_monospaced_changed): Take new font as arg and
6792 check for change against current_mono_font.
6793 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6794 (emacs_settings_constructor, emacs_settings_get_property)
6795 (emacs_settings_set_property, emacs_settings_class_init)
6796 (emacs_settings_init, gsettings_obj): Remove.
6797 (something_changedCB): New function for HAVE_GSETTINGS.
6798 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6799 with value as argument.
6800 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6801 g_settings_new (Bug#8967). Do not create gsettings_obj.
6802 Remove calls to g_settings_bind. Connect something_changedCB to
6805 * xgselect.c: Add defined (HAVE_GSETTINGS).
6806 (xgselect_initialize): Ditto.
6808 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6809 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6812 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6814 * eval.c (struct backtrace): Simplify and port the data structure.
6815 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6816 signed bit field, as this assumption is not portable and it makes
6817 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6818 "char debug_on_exit : 1" as this is not portable either; instead,
6819 use the portable "unsigned int debug_on_exit : 1". Remove unused
6820 member evalargs. Remove obsolete comments about cc bombing out.
6822 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6824 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6825 Let HAVE_GSETTINGS override HAVE_GCONF.
6826 (store_monospaced_changed): New function.
6827 (EMACS_SETTINGS): A new type derived from GObject to handle
6828 GSettings notifications.
6829 (emacs_settings_constructor, emacs_settings_get_property)
6830 (emacs_settings_set_property, emacs_settings_class_init):
6832 (gsettings_client, gsettings_obj): New variables.
6833 (GSETTINGS_SCHEMA): New define.
6834 (something_changedCB): Call store_monospaced_changed.
6835 (init_gsettings): New function.
6836 (xsettings_initialize): Call init_gsettings.
6837 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6840 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6843 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6845 * window.c (resize_root_window, grow_mini_window)
6846 (shrink_mini_window): Rename Qresize_root_window to
6847 Qwindow_resize_root_window and Qresize_root_window_vertically to
6848 Qwindow_resize_root_window_vertically.
6850 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6852 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6854 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6856 * makefile.w32-in: Redesign dependencies so they reflect more
6857 clearly which files are directly included by each source file,
6858 and not through other includes.
6860 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6862 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6863 (sort_overlays, overlay_strings): When an overlay's clone number
6864 matches the window's clone number process the overlay even if
6865 the overlay's window property doesn't match the current window.
6867 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6868 (Fwindow_hchild): Rename to Fwindow_left_child.
6869 (Fwindow_next): Rename to Fwindow_next_sibling.
6870 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6871 (resize_window_check): Rename to window_resize_check.
6872 (resize_window_apply): Rename to window_resize_apply.
6873 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6874 (Fdelete_other_windows_internal, resize_frame_windows)
6875 (Fsplit_window_internal, Fdelete_window_internal)
6876 (grow_mini_window, shrink_mini_window)
6877 (Fresize_mini_window_internal): Fix callers accordingly.
6879 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6881 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6882 (emacs_fixed_set_min_size): Remove.
6883 (emacs_fixed_new): Take frame as argument.
6885 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6886 (_EmacsFixedPrivate): Remove minwidth/height.
6887 Add struct frame *f.
6888 (emacs_fixed_init): Initialize priv->f.
6889 (get_parent_class, emacs_fixed_set_min_size): Remove.
6890 (emacs_fixed_new): Set priv->f to argument.
6891 (emacs_fixed_get_preferred_width)
6892 (emacs_fixed_get_preferred_height): Use min_width/height from
6893 frames size_hint to set minimum and natural (Bug#8919).
6894 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6895 and use min_width/height from frames size_hint to set
6896 min_width/height (Bug#8919).
6898 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6899 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6902 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6904 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6905 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6908 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6910 * process.c (wait_reading_process_output): Bypass select if
6911 waiting for a cell while ignoring keyboard input, and input is
6912 pending. Suggested by Jan Djärv (Bug#8869).
6914 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6916 Use gnulib's dup2 module instead of rolling our own.
6917 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6919 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6921 * dispnew.c (scrolling_window): Before scrolling, turn off a
6922 mouse-highlight in the window being scrolled.
6924 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6926 Move DEFSYM to lisp.h and use everywhere.
6928 * character.h (DEFSYM): Move declaration...
6929 * lisp.h (DEFSYM): ...here.
6935 * w32select.c: Don't include character.h.
6937 * alloc.c (syms_of_alloc):
6938 * buffer.c (syms_of_buffer):
6939 * bytecode.c (syms_of_bytecode):
6940 * callint.c (syms_of_callint):
6941 * casefiddle.c (syms_of_casefiddle):
6942 * casetab.c (init_casetab_once):
6943 * category.c (init_category_once, syms_of_category):
6944 * ccl.c (syms_of_ccl):
6945 * cmds.c (syms_of_cmds):
6946 * composite.c (syms_of_composite):
6947 * dbusbind.c (syms_of_dbusbind):
6948 * dired.c (syms_of_dired):
6949 * dispnew.c (syms_of_display):
6950 * doc.c (syms_of_doc):
6951 * editfns.c (syms_of_editfns):
6952 * emacs.c (syms_of_emacs):
6953 * eval.c (syms_of_eval):
6954 * fileio.c (syms_of_fileio):
6955 * fns.c (syms_of_fns):
6956 * frame.c (syms_of_frame):
6957 * fringe.c (syms_of_fringe):
6958 * insdel.c (syms_of_insdel):
6959 * keymap.c (syms_of_keymap):
6960 * lread.c (init_obarray, syms_of_lread):
6961 * macros.c (syms_of_macros):
6962 * msdos.c (syms_of_msdos):
6963 * print.c (syms_of_print):
6964 * process.c (syms_of_process):
6965 * search.c (syms_of_search):
6966 * sound.c (syms_of_sound):
6967 * syntax.c (init_syntax_once, syms_of_syntax):
6968 * terminal.c (syms_of_terminal):
6969 * textprop.c (syms_of_textprop):
6970 * undo.c (syms_of_undo):
6971 * w32.c (globals_of_w32):
6972 * window.c (syms_of_window):
6973 * xdisp.c (syms_of_xdisp):
6974 * xfaces.c (syms_of_xfaces):
6975 * xfns.c (syms_of_xfns):
6976 * xmenu.c (syms_of_xmenu):
6977 * xsettings.c (syms_of_xsettings):
6978 * xterm.c (syms_of_xterm): Use DEFSYM.
6980 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6982 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6984 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6986 Integer and buffer overflow fixes (Bug#8873).
6988 * print.c (printchar, strout): Check for string overflow.
6989 (PRINTPREPARE, printchar, strout):
6990 Don't set size unless allocation succeeds.
6992 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6993 for sizes. Check for string overflow more accurately.
6994 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6996 * macros.c: Integer and buffer overflow fixes.
6997 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6998 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6999 Use ptrdiff_t, not int, for sizes.
7000 Don't increment bufsize until after realloc succeeds.
7001 Check for size-calculation overflow.
7002 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7004 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7006 * lread.c: Integer overflow fixes.
7007 (read_integer): Radix is now EMACS_INT, not int,
7008 to improve quality of diagnostics for out-of-range radices.
7009 Calculate buffer size correctly for out-of-range radices.
7010 (read1): Check for integer overflow in radices, and in
7011 read-circle numbers.
7012 (read_escape): Avoid int overflow.
7013 (Fload, openp, read_buffer_size, read1)
7014 (substitute_object_recurse, read_vector, read_list, map_obarray):
7015 Use ptrdiff_t, not int, for sizes.
7016 (read1): Use EMACS_INT, not int, for sizes.
7017 Check for size overflow.
7019 * image.c (cache_image): Check for size arithmetic overflow.
7021 * lread.c: Integer overflow issues.
7022 (saved_doc_string_size, saved_doc_string_length)
7023 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7024 Now ptrdiff_t, not int.
7025 (read1): Don't assume doc string length fits in int. Check for
7026 out-of-range doc string lengths.
7027 (read_list): Don't assume file position fits in int.
7028 (read_escape): Check for hex character overflow.
7030 2011-06-22 Leo Liu <sdl.web@gmail.com>
7032 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7033 Move to minibuffer.el.
7035 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7037 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7038 The following patches are for when GLYPH_DEBUG && !XASSERT.
7039 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7040 * dispnew.c (flush_stdout):
7041 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7042 Mark as externally visible.
7043 * dispnew.c (check_window_matrix_pointers): Now static.
7044 * dispnew.c (window_to_frame_vpos):
7045 * xfns.c (unwind_create_frame):
7046 * xterm.c (x_check_font): Remove unused local.
7047 * scroll.c (CHECK_BOUNDS):
7048 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7049 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7050 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7051 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7052 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7054 (debug_method_add): Use va_list and vsprintf rather than relying
7055 on undefined behavior with wrong number of arguments.
7056 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7057 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7058 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7059 since we're not interested in debugging glyphs with old libraries.
7060 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7061 GCC 4.6.0's static checking.
7063 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7065 Integer overflow and signedness fixes (Bug#8873).
7066 A few related buffer overrun fixes, too.
7068 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7070 * dispextern.h (struct face.stipple):
7071 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7072 (x_bitmap_mask, x_allocate_bitmap_record)
7073 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7074 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7075 (x_create_bitmap_from_xpm_data):
7076 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7077 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7079 * xfaces.c (load_pixmap):
7080 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7081 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7082 (.bitmaps_last, struct x_output.icon_bitmap):
7083 Use ptrdiff_t, not int, for bitmap indexes.
7084 (x_allocate_bitmap_record): Check for size overflow.
7085 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7087 Use ptrdiff_t, not int, for overlay counts.
7088 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7089 * editfns.c (overlays_around, get_pos_property):
7090 * textprop.c (get_char_property_and_overlay):
7091 * xdisp.c (next_overlay_change, note_mouse_highlight):
7092 * xfaces.c (face_at_buffer_position):
7093 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7094 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7095 (Fnext_overlay_change, Fprevious_overlay_change)
7096 (mouse_face_overlay_overlaps, Foverlays_in):
7097 Use ptrdiff_t, not int, for sizes.
7098 (overlays_at, overlays_in): Check for size-calculation overflow.
7100 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7102 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7103 (x_session_initialize): Do not assume string length fits in int.
7105 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7106 This is unlikely, but can occur if DPI is outlandish.
7108 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7109 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7111 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7112 * xrdb.c (magic_file_p, search_magic_path):
7113 Omit last arg SUFFIX; it was always 0. All callers changed.
7114 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7116 * xfont.c (xfont_match): Avoid need for strlen.
7118 * xfns.c: Don't assume strlen fits in int.
7119 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7121 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7122 not unsigned long, as we prefer signed integers. All callers changed.
7123 Detect integer overflow in repeat count.
7124 (message_dolog): Don't assume print length fits in 39 bytes.
7125 (display_mode_element): Don't assume strlen fits in int.
7127 * termcap.c: Don't assume sizes fit in int and never overflow.
7128 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7129 (gobble_line): Check for size-calculation overflow.
7131 * minibuf.c (Fread_buffer):
7132 * lread.c (intern, intern_c_string):
7133 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7134 Don't assume string length fits in int.
7136 * keyboard.c (parse_tool_bar_item):
7137 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7139 * font.c: Don't assume string length fits in int.
7140 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7141 Use ptrdiff_t, not int.
7142 (font_intern_prop): Don't assume string length fits in int.
7143 Don't assume integer property fits in fixnum.
7144 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7146 * filelock.c: Fix some buffer overrun and integer overflow issues.
7147 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7148 Reformulate so as not to need the command string.
7149 Invoke gzip -cd rather than gunzip, as it's more portable.
7150 (lock_info_type, lock_file_1, lock_file):
7151 Don't assume pid_t and time_t fit in unsigned long.
7152 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7153 (current_lock_owner): Prefer signed type for sizes.
7154 Use memcpy, not strncpy, where memcpy is what is really wanted.
7155 Don't assume (via atoi) that time_t and pid_t fit in int.
7156 Check for time_t and/or pid_t out of range, e.g., via a network share.
7157 Don't alloca where an auto var works fine.
7159 * fileio.c: Fix some integer overflow issues.
7160 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7161 Don't assume string length fits in int.
7162 (directory_file_name): Don't assume string length fits in long.
7163 (make_temp_name): Don't assume pid fits in int, or that its print
7164 length is less than 20.
7166 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7168 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7170 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7172 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7173 We prefer signed integers, even for size calculations.
7175 * emacs.c: Don't assume string length fits in 'int'.
7176 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7177 (main): Don't invoke strlen when not needed.
7179 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7180 (XD_DEBUG_MESSAGE): Don't waste a byte.
7182 * callproc.c (getenv_internal_1, getenv_internal)
7184 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7186 * lread.c (invalid_syntax): Omit length argument.
7187 All uses changed. This doesn't fix a bug, but it simplifies the
7188 code away from its former Hollerith-constant appearance, and it's
7189 one less 'int' to worry about when looking at integer-overflow issues.
7190 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7192 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7193 This didn't break anything, but it didn't help either.
7194 It's confusing to put a bogus integer in a place where the actual
7195 value does not matter.
7196 (LIST_END_P): Remove unused macro and its bogus comment.
7197 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7199 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7200 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7202 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7203 We prefer signed types, and the value cannot exceed the EMACS_INT
7204 range anyway (because otherwise the length would not be representable).
7205 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7206 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7207 This avoids a GCC warning when WIDE_EMACS_INT.
7209 * indent.c (sane_tab_width): New function.
7210 (current_column, scan_for_column, Findent_to, position_indentation)
7211 (compute_motion): Use it. This is just for clarity.
7212 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7214 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7216 * lisp.h (lint_assume): New macro.
7217 * composite.c (composition_gstring_put_cache):
7218 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7220 * editfns.c, insdel.c:
7221 Omit unnecessary forward decls, to simplify future changes.
7223 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7225 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7227 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7228 Use much-faster test for byte-length change.
7229 Don't assume string byte-length fits in 'int'.
7230 Check that character arg fits in 'int'.
7231 (mapcar1): Declare byte as byte, for clarity.
7233 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7235 * fns.c (concat): Catch string overflow earlier.
7236 Do not rely on integer wraparound.
7238 * dispextern.h (struct it.overlay_strings_charpos)
7239 (struct it.selective): Now EMACS_INT, not int.
7240 * xdisp.c (forward_to_next_line_start)
7241 (back_to_previous_visible_line_start)
7242 (reseat_at_next_visible_line_start, next_element_from_buffer):
7243 Don't arbitrarily truncate the value of 'selective' to int.
7245 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7247 * composite.c: Don't truncate sizes to 'int'.
7248 (composition_gstring_p, composition_reseat_it)
7249 (composition_adjust_point): Use EMACS_INT, not int.
7250 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7251 not EMACS_UINT, for indexes.
7253 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7255 * buffer.c: Include <verify.h>.
7256 (struct sortvec.priority, struct sortstr.priority):
7257 Now EMACS_INT, not int.
7258 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7259 (struct sortstr.size, record_overlay_string)
7260 (struct sortstrlist.size, struct sortlist.used):
7261 Don't truncate size to int.
7262 (record_overlay_string): Check for size-calculation overflow.
7263 (init_buffer_once): Check at compile-time, not run-time.
7265 2011-06-22 Jim Meyering <meyering@redhat.com>
7267 Don't leak an XBM-image-sized buffer
7268 * image.c (xbm_load): Free the image buffer after using it.
7270 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7273 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7274 that Sun C diagnosed.
7275 * fns.c (secure_hash): Fix pointer signedness issue.
7276 * intervals.c (static_offset_intervals): New function.
7277 (offset_intervals): Use it.
7279 2011-06-21 Leo Liu <sdl.web@gmail.com>
7282 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7285 * fns.c (secure_hash): Rename from crypto_hash_function and change
7286 the first arg to accept symbols.
7287 (Fsecure_hash): New primitive.
7288 (syms_of_fns): New symbols.
7290 2011-06-20 Deniz Dogan <deniz@dogan.se>
7292 * process.c (Fset_process_buffer): Clarify return value in
7295 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7297 * dispnew.c (add_window_display_history): Use BVAR.
7299 * xdisp.c (debug_method_add): Use BVAR.
7300 (check_window_end, dump_glyph_matrix, dump_glyph)
7301 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7303 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7306 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7307 check till after the cache is created in init_frame_faces.
7309 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7311 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7313 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7315 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7316 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7317 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7319 Improve buffer-overflow checking (Bug#8873).
7320 * fileio.c (Finsert_file_contents):
7321 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7322 Remove the old (too-loose) buffer overflow checks.
7323 They weren't needed, since make_gap checks for buffer overflow.
7324 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7325 The old code merely checked for Emacs fixnum overflow, and relied
7326 on undefined (wraparound) behavior. The new code avoids undefined
7327 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7329 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7330 Tune. Don't use wider integers than needed. Don't use alloca.
7331 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7333 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7335 * insdel.c, lisp.h (buffer_overflow): New function.
7336 (insert_from_buffer_1, replace_range, replace_range_2):
7337 * insdel.c (make_gap_larger):
7338 * editfns.c (Finsert_char):
7339 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7341 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7343 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7345 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7347 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7348 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7350 * fileio.c: Don't assume EMACS_INT fits in off_t.
7351 (emacs_lseek): New static function.
7352 (Finsert_file_contents, Fwrite_region): Use it.
7353 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7355 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7357 * fns.c: Don't overflow int when computing a list length.
7358 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7359 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7360 truncation on 64-bit hosts. Check for QUIT every
7361 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7362 faster and is responsive enough.
7363 (Flength): Report an error instead of overflowing an integer.
7364 (Fsafe_length): Return a float if the value is not representable
7365 as a fixnum. This shouldn't happen except in contrived situations.
7366 (Fnthcdr, Fsort): Don't assume list length fits in int.
7367 (Fcopy_sequence): Don't assume vector length fits in int.
7369 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7370 (header_size, word_size): New constants.
7371 (allocate_vectorlike): Don't check size overflow here.
7372 (allocate_vector): Check it here instead, since this is the only
7373 caller of allocate_vectorlike that could cause overflow.
7374 Check that the new vector's length is representable as a fixnum.
7376 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7377 The previous code was bogus. For example, next_almost_prime (32)
7378 returned 39, which is undesirable as it is a multiple of 3; and
7379 next_almost_prime (24) returned 25, which is a multiple of 5 so
7380 why was the code bothering to check for multiples of 7?
7382 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7384 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7386 Variadic C functions now count arguments with ptrdiff_t.
7387 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7388 Back then I didn't know that the Emacs coding style prefers signed int.
7389 Also, in the meantime I found a few more instances where arguments
7390 were being counted with int, which may truncate counts on 64-bit
7391 machines, or EMACS_INT, which may be unnecessarily wide.
7392 * lisp.h (struct Lisp_Subr.function.aMANY)
7393 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7394 Arg counts are now ptrdiff_t, not size_t.
7395 All variadic functions and their callers changed accordingly.
7396 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7397 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7398 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7399 * callint.c (Fcall_interactively): Check arg count for overflow,
7400 to avoid potential buffer overrun. Use signed char, not 'int',
7401 for 'varies' array, so that we needn't bother to check its size
7402 calculation for overflow.
7403 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7404 * eval.c (apply_lambda):
7405 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7406 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7407 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7409 * callint.c (Fcall_interactively): Don't use index var as event count.
7411 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7412 * mem-limits.h (SIZE): Remove; no longer used.
7414 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7416 Remove unnecessary casts.
7417 * xterm.c (x_term_init):
7418 * xfns.c (x_set_border_pixel):
7419 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7420 These aren't needed now that we assume ANSI C.
7422 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7423 It's more likely to cause problems (due to unsigned overflow)
7426 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7428 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7430 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7432 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7434 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7436 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7438 GLYPH_CODE_FACE returns EMACS_INT, not int.
7439 * dispextern.h (merge_faces):
7440 * xfaces.c (merge_faces):
7441 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7442 Don't assume EMACS_INT fits in int.
7444 * character.h (CHAR_VALID_P): Remove unused parameter.
7445 * fontset.c, lisp.h, xdisp.c: All uses changed.
7447 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7449 * fns.c (concat): Minor tuning based on overflow analysis.
7450 This doesn't fix any bugs. Use int to hold character, instead
7451 of constantly refetching from Emacs object. Use XFASTINT, not
7452 XINT, for value known to be a character. Don't bother comparing
7453 a single byte to 0400, as it's always less.
7455 * floatfns.c (Fexpt):
7456 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7458 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7461 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7463 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7464 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7465 incorrectly succeed when S was a string, because 4294967386 was
7466 truncated before it was used.
7468 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7469 Otherwise, an out-of-range integer could cause undefined behavior
7472 * composite.c: Use int, not EMACS_INT, for characters.
7473 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7474 EMACS_INT, for values that are known to be in character range.
7475 This doesn't fix any bugs but is the usual style inside Emacs and
7476 may generate better code on 32-bit machines.
7478 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7479 This is for reasons similar to the recent CHAR_STRING fix.
7480 * charset.c (Fencode_char): Check that character arg is actually
7481 a character. Pass an int to ENCODE_CHAR.
7482 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7483 wider than 'int', as a compile-time check to prevent future regressions
7486 * character.c (char_string): Remove unnecessary casts.
7488 Make sure a 64-bit char is never passed to CHAR_STRING.
7489 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7490 by silently ignoring the top 32 bits, allowing some values
7491 that were far too large to be valid characters.
7492 * character.h: Include <verify.h>.
7493 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7494 arguments are no wider than unsigned, as a compile-time check
7495 to prevent future regressions in this area.
7497 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7498 (Fsubst_char_in_region):
7500 * xdisp.c (decode_mode_spec_coding):
7501 Adjust to CHAR_STRING's new requirement.
7502 * editfns.c (Finsert_char, Fsubst_char_in_region):
7503 * fns.c (concat): Check that character args are actually
7504 characters. Without this test, these functions did the wrong
7505 thing with wildly out-of-range values on 64-bit hosts.
7507 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7508 These casts should not be needed on 32-bit hosts, either.
7509 * keyboard.c (read_char):
7510 * lread.c (Fload): Remove casts to unsigned.
7512 * lisp.h (UNSIGNED_CMP): New macro.
7513 This fixes comparison bugs on 64-bit hosts.
7514 (ASCII_CHAR_P): Use it.
7515 * casefiddle.c (casify_object):
7516 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7517 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7518 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7519 * dispextern.h (FACE_FROM_ID):
7520 * keyboard.c (read_char): Use UNSIGNED_CMP.
7522 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7523 not to EMACS_INT, to avoid GCC warning.
7525 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7527 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7528 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7529 isn't needed on 32-bit machines.
7531 * buffer.c (Fgenerate_new_buffer_name):
7532 Use EMACS_INT for count, not int.
7533 (advance_to_char_boundary): Return EMACS_INT, not int.
7535 * data.c (Qcompiled_function): Now static.
7537 * window.c (window_body_lines): Now static.
7539 * image.c (gif_load): Rename local to avoid shadowing.
7541 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7542 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7543 * alloc.c (make_save_value): Integer argument is now of type
7545 (mark_object): Use ptrdiff_t, not int.
7546 * lisp.h (pD): New macro.
7547 * print.c (print_object): Use it.
7549 * alloc.c: Use EMACS_INT, not int, to count objects.
7550 (total_conses, total_markers, total_symbols, total_vector_size)
7551 (total_free_conses, total_free_markers, total_free_symbols)
7552 (total_free_floats, total_floats, total_free_intervals)
7553 (total_intervals, total_strings, total_free_strings):
7554 Now EMACS_INT, not int. All uses changed.
7555 (Fgarbage_collect): Compute overall total using a double, so that
7556 integer overflow is less likely to be a problem. Check for overflow
7557 when converting back to an integer.
7558 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7559 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7560 These were 'int' variables that could overflow on 64-bit hosts;
7561 they were never used, so remove them instead of repairing them.
7562 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7563 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7564 Previously, this ceilinged at INT_MAX, but that doesn't work on
7566 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7568 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7569 (allocate_vectorlike): Check for ptrdiff_t overflow.
7570 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7571 when a (possibly-narrower) signed value would do just as well.
7572 We prefer using signed arithmetic, to avoid comparison confusion.
7574 * alloc.c: Catch some string size overflows that we were missing.
7575 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7576 for convenience in STRING_BYTES_MAX.
7577 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7578 The definition here is exact; the one in lisp.h was approximate.
7579 (allocate_string_data): Check for string overflow. This catches
7580 some instances we weren't catching before. Also, it catches
7581 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7582 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7583 and ptrdiff_t and EMACS_INT are both 64 bits.
7585 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7586 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7587 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7589 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7591 * alloc.c (Fmake_string): Check for out-of-range init.
7593 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7595 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7597 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7599 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7600 xg_get_default_scrollbar_width.
7602 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7603 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7604 (style_changed_cb): Call update_theme_scrollbar_width and call
7605 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7606 all frames (Bug#8505).
7607 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7608 Call gtk_window_set_resizable if HAVE_GTK3.
7609 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7610 and height if HAVE_GTK3 (Bug#8505).
7611 (scroll_bar_width_for_theme): New variable.
7612 (update_theme_scrollbar_width): New function.
7613 (xg_get_default_scrollbar_width): Move code to
7614 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7615 (xg_initialize): Call update_theme_scrollbar_width.
7617 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7619 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7621 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7623 * frame.c (make_frame): Call other_buffer_safely instead of
7626 * window.c (temp_output_buffer_show): Call display_buffer with
7627 second argument Vtemp_buffer_show_specifiers and reset latter
7628 immediately after the call.
7629 (Vtemp_buffer_show_specifiers): New variable.
7630 (auto_window_vscroll_p, next_screen_context_lines)
7631 (Vscroll_preserve_screen_position): Remove leading asterisks from
7634 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7636 Fix minor problems found by GCC 4.6.0 static checking.
7637 * buffer.c (Qclone_number): Remove for now, as it's unused.
7638 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7639 (record_buffer): Remove unused local.
7640 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7641 (set_frame_buffer_list): Remove; unused.
7642 * frame.h (other_visible_frames): Remove decl.
7643 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7644 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7645 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7647 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7648 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7649 Define only if HAVE_GPM.
7650 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7651 (update_hints_inhibit): Remove; never set. All uses removed.
7652 * widgetprv.h (emacsFrameClassRec): Remove decl.
7653 * window.c (delete_deletable_window): Now returns void, since it
7654 wasn't returning anything.
7655 (compare_window_configurations): Remove unused locals.
7656 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7657 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7658 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7659 the same widths as pointers. This follows up on the 2011-05-06 patch.
7660 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7661 * xterm.h: Likewise.
7662 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7664 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7666 * makefile.w32-in: Update dependencies.
7667 (LISP_H): Add lib/intprops.h.
7669 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7671 * image.c (gif_load): Add animation frame delay to the metadata.
7672 (syms_of_image): Use DEFSYM. New symbol `delay'.
7674 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7676 * window.c (delete_deletable_window): Re-add.
7677 (Fset_window_configuration): Rewrite to handle dead buffers and
7678 consequently deletable windows.
7679 (window_tree, Fwindow_tree): Remove. Supply functionality in
7681 (compare_window_configurations): Simplify code.
7683 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7685 * image.c (imagemagick_load_image): Fix type mismatch.
7686 (Fimagemagick_types): Likewise.
7688 * window.h (replace_buffer_in_windows): Declare.
7690 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7692 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7693 Qclone_number. Remove external declaration of Qdelete_window.
7694 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7696 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7697 Run Qbuffer_list_update_hook if allowed.
7698 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7699 buffer list implementation.
7700 (other_buffer_safely): New function.
7701 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7702 calls to replace_buffer_in_windows and
7703 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7705 (record_buffer): Inhibit quitting and rewrite using quittable
7706 functions. Run Qbuffer_list_update_hook if allowed.
7707 (Frecord_buffer, Funrecord_buffer): New functions.
7708 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7709 Move switch-to-buffer to window.el.
7710 (bury-buffer): Move to window.el.
7711 (Vbuffer_list_update_hook): New variable.
7713 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7716 * window.h (resize_frame_windows): Move up in code.
7717 (Fwindow_frame): Remove EXFUN.
7718 (replace_buffer_in_all_windows): Remove prototype.
7719 (replace_buffer_in_windows_safely): Add prototype.
7721 * window.c: Declare Qdelete_window static again. Move down
7722 declaration of select_count.
7723 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7724 (Fother_window): Move to window.el.
7725 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7726 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7727 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7729 (replace_buffer_in_windows): Implement by calling
7730 Qreplace_buffer_in_windows.
7731 (replace_buffer_in_all_windows): Remove with some functionality
7732 moved into replace_buffer_in_windows_safely.
7733 (replace_buffer_in_windows_safely): New function.
7734 (select_window_norecord, select_frame_norecord): Move in front
7735 of run_window_configuration_change_hook. Remove now obsolete
7737 (Fset_window_buffer): Rewrite doc-string.
7738 Call Qrecord_window_buffer.
7739 (keys_of_window): Move binding for other-window to window.el.
7741 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7743 * dispextern.h (struct image): Replace data member, whose int_val
7744 and ptr_val fields were not used by anything, with a single
7747 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7748 (gif_clear_image, gif_load, imagemagick_load_image)
7749 (gs_clear_image, gs_load): Callers changed.
7751 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7753 * buffer.h: Include <time.h>, for time_t.
7754 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7756 Fix minor problems found by static checking.
7758 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7760 Make identifiers static if they are not used in other modules.
7761 * data.c (Qcompiled_function, Qframe, Qvector):
7762 * image.c (QimageMagick, Qsvg):
7763 * minibuf.c (Qmetadata):
7764 * window.c (resize_window_check, resize_root_window): Now static.
7765 * window.h (resize_window_check, resize_root_window): Remove decls.
7767 * window.c (window_deletion_count, delete_deletable_window):
7769 (window_body_lines): Now static.
7770 (Fdelete_other_windows_internal): Mark vars as initialized.
7771 Make sure 'resize_failed' is initialized.
7772 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7773 (resize_window_apply): Remove unused local.
7774 * window.h (delete_deletable_window): Remove decl.
7776 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7777 (imagemagick_load_image): Fix pointer signedness problem by changing
7778 last arg from unsigned char * to char *. All uses changed.
7779 Also, fix a local for similar reasons.
7780 Remove unused locals. Remove locals to avoid shadowing.
7781 (fn_rsvg_handle_free): Remove; unused.
7782 (svg_load, svg_load_image): Fix pointer signedness problem.
7783 (imagemagick_load_image): Don't use garbage pointer image_wand.
7785 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7787 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7789 * image.c (gif_load): Fix omitted cast error introduced by
7792 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7794 * window.h (resize_proportionally, orig_total_lines)
7795 (orig_top_line): Remove from window structure.
7796 (set_window_height, set_window_width, change_window_heights)
7797 (Fdelete_window): Remove prototypes.
7798 (resize_frame_windows): Remove duplicate declaration.
7800 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7802 * window.h (resize_frame_windows, resize_window_check)
7803 (delete_deletable_window, resize_root_window)
7804 (resize_frame_windows): Declare prototypes.
7806 * window.c (resize_window_apply): Make definition be "static" to
7807 match the prototype.
7809 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7811 * window.c: Remove declarations of Qwindow_size_fixed,
7812 window_min_size_1, window_min_size_2, window_min_size,
7813 size_window, window_fixed_size_p, enlarge_window, delete_window.
7814 Remove static from declaration of Qdelete_window, it's
7815 temporarily needed by Fbury_buffer.
7816 (replace_window): Don't assign orig_top_line and
7818 (Fdelete_window, delete_window): Remove. Window deletion is
7819 handled by window.el.
7820 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7821 Replace Fdelete_window calls with calls to Qdelete_window.
7822 (Fdelete_other_windows): Remove. Deleting other windows is
7823 handled by window.el.
7824 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7825 handled in window.el.
7826 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7827 Window minimum sizes are handled in window.el.
7828 (shrink_windows, size_window, set_window_height)
7829 (set_window_width, change_window_heights, window_height)
7830 (window_width, CURBEG, CURSIZE, enlarge_window)
7831 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7832 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7833 handled in window.el.
7834 (make_dummy_parent): Rename to make_parent_window and give it a
7835 second argument horflag.
7836 (make_window): Don't set resize_proportionally any more.
7837 (Fsplit_window): Remove. Windows are split in window.el.
7838 (save_restore_action, save_restore_orig_size)
7839 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7840 Resize mini windows in window.el.
7841 (grow_mini_window, shrink_mini_window): Implement by calling
7842 Qresize_root_window_vertically, resize_window_check and
7843 resize_window_apply.
7844 (saved_window, Fset_window_configuration, save_window_save):
7845 Do not handle orig_top_line, orig_total_lines, and
7846 resize_proportionally.
7847 (window_min_height, window_min_width): Move to window.el.
7848 (keys_of_window): Move bindings for delete-other-windows,
7849 split-window, delete-window and enlarge-window to window.el.
7851 * buffer.c: Temporarily extern Qdelete_window.
7852 (Fbury_buffer): Temporarily call Qdelete_window instead of
7853 Fdelete_window (Fbury_buffer will move to window.el soon).
7855 * frame.c (set_menu_bar_lines_1): Remove code handling
7856 orig_top_line and orig_total_lines.
7858 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7859 set_window_height but set heights directly.
7860 (change_frame_size_1): Use resize_frame_windows.
7862 * xdisp.c (init_xdisp): Don't use set_window_height but set
7865 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7866 Use resize_frame_windows instead of change_window_heights and run
7867 run_window_configuration_change_hook.
7869 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7870 instead of change_window_heights and run
7871 run_window_configuration_change_hook.
7873 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7875 * window.c (replace_window): Rename second argument REPLACEMENT to
7876 NEW. New third argument SETFLAG. Rewrite.
7877 (delete_window, make_dummy_parent): Call replace_window with
7879 (window_list_1): Move down in code.
7880 (run_window_configuration_change_hook): Move set_buffer part
7881 before select_frame_norecord part in order to unwind correctly.
7882 Rename count1 to count.
7883 (recombine_windows, delete_deletable_window, resize_root_window)
7884 (Fdelete_other_windows_internal)
7885 (Frun_window_configuration_change_hook, make_parent_window)
7886 (resize_window_check, resize_window_apply, Fresize_window_apply)
7887 (resize_frame_windows, Fsplit_window_internal)
7888 (Fdelete_window_internal, Fresize_mini_window_internal):
7890 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7892 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7894 * window.h (window): Add some new members to window structure -
7895 normal_lines, normal_cols, new_total, new_normal, clone_number,
7896 splits, nest, prev_buffers, next_buffers.
7897 (WINDOW_TOTAL_SIZE): Move here from window.c.
7898 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7900 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7902 (make_dummy_parent): Set new members of windows structure.
7903 (make_window): Move down in code. Handle new members of window
7905 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7906 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7907 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7908 (Fset_window_prev_buffers, Fwindow_next_buffers)
7909 (Fset_window_next_buffers, Fset_window_clone_number):
7911 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7912 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7914 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7915 Argument WINDOW can be now internal window too.
7916 (Fwindow_use_time): Move up in code.
7917 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7919 (Fset_window_configuration, saved_window)
7920 (Fcurrent_window_configuration, save_window_save): Handle new
7921 members of window structure.
7922 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7923 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7924 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7925 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7926 Qget_mru_window, Qresize_root_window,
7927 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7928 Qauto_buffer_name; staticpro them.
7930 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7932 * window.c (Fwindow_total_size, Fwindow_left_column)
7933 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7934 (Fwindow_list_1): New functions.
7935 (window_box_text_cols): Replace with window_body_cols.
7936 (Fwindow_width, Fscroll_left, Fscroll_right):
7937 Use window_body_cols instead of window_box_text_cols.
7938 (delete_window, Fset_window_configuration):
7939 Call delete_all_subwindows with window as argument.
7940 (delete_all_subwindows): Take a window as argument and not a
7942 (window_loop): Remove handling of GET_LRU_WINDOW and
7944 (Fget_lru_window, Fget_largest_window): Move to window.el.
7946 * window.h: Extern window_body_cols instead of
7947 window_box_text_cols. delete_all_subwindows now takes a
7948 Lisp_Object as argument.
7950 * indent.c (compute_motion, Fcompute_motion):
7951 Use window_body_cols instead of window_box_text_cols.
7953 * frame.c (delete_frame): Call delete_all_subwindows with root
7956 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7958 * fns.c (Fputhash): Document return value.
7960 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7962 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7964 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7966 Cons<->int and similar integer overflow fixes (Bug#8794).
7968 Check for overflow when converting integer to cons and back.
7969 * charset.c (Fdefine_charset_internal, Fdecode_char):
7970 Use cons_to_unsigned to catch overflow.
7971 (Fencode_char): Use INTEGER_TO_CONS.
7972 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7973 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7974 * data.c (long_to_cons, cons_to_long): Remove.
7975 (cons_to_unsigned, cons_to_signed): New functions.
7976 These signal an error for invalid or out-of-range values.
7977 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7978 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7979 * font.c (Ffont_variation_glyphs):
7980 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7981 * lisp.h: Include <intprops.h>.
7982 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7983 (cons_to_signed, cons_to_unsigned): New decls.
7984 (long_to_cons, cons_to_long): Remove decls.
7985 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7986 (Fprimitive_undo): Use CONS_TO_INTEGER.
7987 * xfns.c (Fx_window_property): Likewise.
7988 * xselect.c: Include <limits.h>.
7989 (x_own_selection, selection_data_to_lisp_data):
7990 Use INTEGER_TO_CONS.
7991 (x_handle_selection_request, x_handle_selection_clear)
7992 (x_get_foreign_selection, Fx_disown_selection_internal)
7993 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7994 (lisp_data_to_selection_data): Use cons_to_unsigned.
7995 (x_fill_property_data): Use cons_to_signed.
7996 Report values out of range.
7998 Check for buffer and string overflow more precisely.
7999 * buffer.h (BUF_BYTES_MAX): New macro.
8000 * lisp.h (STRING_BYTES_MAX): New macro.
8001 * alloc.c (Fmake_string):
8002 * character.c (string_escape_byte8):
8003 * coding.c (coding_alloc_by_realloc):
8004 * doprnt.c (doprnt):
8005 * editfns.c (Fformat):
8007 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8008 since they may not be the same number.
8009 * editfns.c (Finsert_char):
8010 * fileio.c (Finsert_file_contents):
8011 Likewise for BUF_BYTES_MAX.
8013 * image.c: Use ptrdiff_t, not int, for sizes.
8014 (slurp_file): Switch from int to ptrdiff_t.
8016 (slurp_file): Check that file size fits in both size_t (for
8017 malloc) and ptrdiff_t (for sanity and safety).
8019 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8020 if b->modtime has its maximal value.
8022 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8024 Don't assume time_t can fit into int.
8025 * buffer.h (struct buffer.modtime): Now time_t, not int.
8026 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8027 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8029 Minor fixes for signed vs unsigned integers.
8030 * character.h (MAYBE_UNIFY_CHAR):
8031 * charset.c (maybe_unify_char):
8032 * keyboard.c (read_char, reorder_modifiers):
8033 XINT -> XFASTINT, since the integer must be nonnegative.
8034 * ftfont.c (ftfont_spec_pattern):
8035 * keymap.c (access_keymap, silly_event_symbol_error):
8036 XUINT -> XFASTINT, since the integer must be nonnegative.
8037 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8038 since it makes no difference and we prefer signed.
8039 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8040 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8043 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8045 * window.h (Fwindow_frame): Declare.
8047 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8049 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8050 (SPARE_MEMORY): Always define.
8051 (LARGE_REQUEST): Remove.
8052 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8054 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8056 * lisp.h: Move EXFUNS for Fframe_root_window,
8057 Fframe_first_window and Fset_frame_selected_window to window.h.
8059 * window.h: Move EXFUNS for Fframe_root_window,
8060 Fframe_first_window and Fset_frame_selected_window here from
8063 * frame.c (Fwindow_frame, Fframe_first_window)
8064 (Fframe_root_window, Fframe_selected_window)
8065 (Fset_frame_selected_window): Move to window.c.
8066 (Factive_minibuffer_window): Move to minibuf.c.
8067 (Fother_visible_frames_p): New function.
8069 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8071 * window.c (decode_window, decode_any_window): Move up in code.
8072 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8073 (inhibit_frame_unsplittable): Remove unused variable.
8074 (Fwindow_buffer): Move up and rewrite doc-string.
8075 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8076 (Fwindow_prev): New functions.
8077 (Fwindow_frame): Move here from frame.c. Accept any window as
8079 (Fframe_root_window, Fframe_first_window)
8080 (Fframe_selected_window): Move here from frame.c. Accept frame
8081 or arbitrary window as argument. Update doc-strings.
8082 (Fminibuffer_window): Move up in code.
8083 (Fwindow_minibuffer_p): Move up in code and simplify.
8084 (Fset_frame_selected_window): Move here from frame.c.
8086 (Fselected_window, select_window, Fselect_window): Move up in
8087 code. Minor doc-string fixes.
8089 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8091 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8092 Do not assume that spare memory exists; that assumption is valid
8093 only if SYSTEM_MALLOC.
8094 (LARGE_REQUEST): New macro, so that the issue of large requests
8095 is separated from the issue of spare memory.
8097 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8099 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8102 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8104 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8107 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8109 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8111 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8113 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8114 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8116 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8118 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8120 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8122 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8123 (x_clipboard_manager_save): Add return value.
8124 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8126 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8127 Obey Vx_select_enable_clipboard_manager. Catch errors in
8128 x_clipboard_manager_save (Bug#8779).
8129 (Vx_select_enable_clipboard_manager): New variable.
8130 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8132 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8134 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8136 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8138 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8139 in the current matrix if keep_current_p is non-zero.
8141 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8143 * bidi.c (bidi_level_of_next_char): Fix last change.
8145 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8147 Support bidi reordering of text covered by display properties.
8149 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8150 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8151 (bidi_cache_search, bidi_cache_iterator_state)
8152 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8153 (bidi_level_of_next_char, bidi_move_to_visually_next):
8154 Support character positions inside a run of characters covered by a
8156 (bidi_paragraph_init, bidi_resolve_explicit_1)
8157 (bidi_level_of_next_char): Call bidi_fetch_char and
8158 bidi_fetch_char_advance instead of FETCH_CHAR and
8160 (bidi_init_it): Initialize new members.
8161 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8163 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8164 instead of using explicit *_CHAR codes.
8165 (bidi_resolve_explicit, bidi_resolve_weak):
8166 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8167 bidirectional text is supported only in multibyte buffers.
8168 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8169 it to initialize the frame_window_p member of struct bidi_it.
8170 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8171 (bidi_resolve_explicit, bidi_resolve_weak)
8172 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8173 bidi_it->nchars is non-positive.
8174 (bidi_level_of_next_char): Don't try to lookup the cache for the
8175 next/previous character if nothing is cached there yet, or if we
8176 were just reseat()'ed to a new position.
8178 * xdisp.c (set_cursor_from_row): Set start and stop points
8179 according to the row's direction when priming the loop that looks
8180 for the glyph on which to display cursor.
8181 (single_display_spec_intangible_p): Function deleted.
8182 (display_prop_intangible_p): Reimplement to call
8183 handle_display_spec instead of single_display_spec_intangible_p.
8184 Accept 3 additional arguments needed by handle_display_spec.
8185 This fixes incorrect cursor motion across display property with complex
8186 values: lists, `(when COND...)' forms, etc.
8187 (single_display_spec_string_p): Support property values that are
8188 lists with the argument STRING its top-level element.
8189 (display_prop_string_p): Fix the condition for processing a
8190 property that is a list to be consistent with handle_display_spec.
8191 (handle_display_spec): New function, refactored from the
8192 last portion of handle_display_prop.
8193 (compute_display_string_pos): Accept additional argument
8194 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8195 value of a `display' property is a "replacing spec".
8196 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8197 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8198 the display property, but just return a value indicating whether
8199 the display property will replace the characters it covers.
8200 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8201 frame_window_p members of struct bidi_it.
8202 (compute_display_string_pos, compute_display_string_end):
8204 (push_it): Accept second argument POSITION, where pop_it should
8205 jump to continue iteration.
8206 (reseat_1): Initialize bidi_it.disp_pos.
8208 * keyboard.c (adjust_point_for_property): Adjust the call to
8209 display_prop_intangible_p to its new signature.
8211 * dispextern.h (struct bidi_it): New member frame_window_p.
8212 (bidi_init_it): Update prototypes.
8213 (display_prop_intangible_p): Update prototype.
8214 (compute_display_string_pos, compute_display_string_end):
8216 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8219 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8221 Malloc failure behavior now depends on size of allocation.
8222 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8223 * lisp.h: Change signatures accordingly.
8224 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8225 All callers changed. (Bug#8762)
8227 * gnutls.c: Use Emacs's memory allocators.
8228 Without this change, the gnutls library would invoke malloc etc.
8229 directly, which causes problems on non-SYNC_INPUT hosts, and which
8230 runs afoul of improving memory_full behavior. (Bug#8761)
8231 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8232 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8233 xfree instead of the default malloc, realloc, free.
8234 (Fgnutls_boot): No need to check for memory allocation failure,
8235 since xmalloc does that for us.
8237 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8238 * category.c (hash_get_category_set):
8239 * ccl.c (ccl_driver):
8240 * charset.c (Fdefine_charset_internal):
8241 * charset.h (struct charset.hash_index):
8242 * composite.c (get_composition_id, gstring_lookup_cache)
8243 (composition_gstring_put_cache):
8244 * composite.h (struct composition.hash_index):
8245 * dispextern.h (struct image.hash):
8246 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8247 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8248 (hashfn_equal, hashfn_user_defined, make_hash_table)
8249 (maybe_resize_hash_table, hash_lookup, hash_put)
8250 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8251 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8252 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8253 * image.c (make_image, search_image_cache, lookup_image)
8254 (xpm_put_color_table_h):
8255 * lisp.h (struct Lisp_Hash_Table):
8256 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8257 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8258 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8259 * alloc.c (allocate_vectorlike):
8260 Check for overflow in vector size calculations.
8261 * ccl.c (ccl_driver):
8262 Check for overflow when converting EMACS_INT to int.
8263 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8264 need to be updated by these changes.
8265 * fns.c (make_hash_table, maybe_resize_hash_table):
8266 Check for integer overflow with large hash tables.
8267 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8268 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8269 (SXHASH_REDUCE): New macro.
8270 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8271 Use it instead of discarding useful hash info with large hash values.
8272 (sxhash_float): New function.
8273 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8274 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8275 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8276 Rewrite to use FIXNUM_BITS, as this simplifies things.
8277 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8278 Adjust signatures to match updated version of code.
8279 (consing_since_gc): Now EMACS_INT, since a single hash table can
8280 use more than INT_MAX bytes.
8282 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8284 Make it possible to build with GCC-4.6+ -O2 -flto.
8286 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8288 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8290 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8291 Call minibuffer-inactive-mode.
8293 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8295 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8296 Update dependencies.
8298 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8300 * data.c (init_data): Remove code for UTS, this system is not
8303 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8305 Don't force ./temacs to start in terminal mode.
8307 * frame.c (make_initial_frame): Initialize faces in all cases, not
8308 only when CANNOT_DUMP is defined.
8309 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8311 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8313 * dispnew.c (add_window_display_history): Use const for the string
8314 pointer. Remove declaration, not needed.
8316 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8318 Use 'inline', not 'INLINE'.
8319 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8320 * alloc.c, fontset.c (INLINE): Remove.
8321 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8322 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8323 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8324 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8325 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8327 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8329 Make it possible to run ./temacs.
8331 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8332 syms_of_callproc does the same thing. Remove test for
8333 "initialized", do it in the caller.
8334 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8336 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8338 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8339 (read_minibuf): Use get_minibuffer.
8340 (syms_of_minibuf): Use DEFSYM.
8341 (Qmetadata): New var.
8342 * data.c (Qbuffer): Don't make it static.
8343 (syms_of_data): Use DEFSYM.
8345 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8347 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8348 (CCL_CODE_MIN): New macro.
8350 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8352 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8354 * eval.c (Qdebug): Now static.
8355 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8356 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8357 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8359 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8361 * image.c: Various fixes to ImageMagick code comments.
8362 (Fimagemagick_types): Doc fix.
8364 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8366 Minor fixes prompted by GCC 4.6.0 warnings.
8368 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8370 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8371 (x_clipboard_manager_save_all): Move extern decl to ...
8372 * xterm.h: ... here, so that it can be checked for consistency.
8374 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8376 * xselect.c (x_clipboard_manager_save_frame)
8377 (x_clipboard_manager_save_all): New functions.
8378 (Fx_clipboard_manager_save): Lisp function deleted.
8380 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8381 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8383 * xterm.h: Update prototype.
8385 2011-05-28 William Xu <william.xwl@gmail.com>
8387 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8390 2011-05-28 Jim Meyering <meyering@redhat.com>
8392 Avoid a sign-extension bug in crypto_hash_function.
8393 * fns.c (to_uchar): Define.
8394 (crypto_hash_function): Use it to convert some newly-signed
8395 variables to unsigned, to avoid sign-extension bugs. For example,
8396 without this change, (md5 "truc") would evaluate to
8397 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8398 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8399 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8401 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8403 Integer overflow fixes.
8405 * dbusbind.c: Serial number integer overflow fixes.
8406 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8407 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8408 to hold a serial number that is too large for a fixnum.
8409 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8410 Check for serial numbers out of range. Decode any serial number
8411 that was so large that it became a float. (Bug#8722)
8413 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8414 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8415 Use XFASTINT rather than XUINT when numbers are nonnegative.
8416 (xd_append_arg, Fdbus_method_return_internal):
8417 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8418 arguments, check that Lisp number is nonnegative, rather than
8419 silently wrapping negative numbers around. (Bug#8722)
8420 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8423 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8425 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8427 ccl: Add integer overflow checks.
8428 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8429 (IN_INT_RANGE): New macros.
8430 (ccl_driver): Use them to check for integer overflow when
8431 decoding a CCL program. Many of the new checks are whether XINT (x)
8432 fits in int; it doesn't always, on 64-bit hosts. The new version
8433 doesn't catch all possible integer overflows, but it's an
8434 improvement. (Bug#8719)
8436 * alloc.c (make_event_array): Use XINT, not XUINT.
8437 There's no need for unsigned here.
8439 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8440 This follows up to the 2011-05-06 change that substituted uintptr_t
8441 for EMACS_INT. This case wasn't caught back then.
8443 Rework Fformat to avoid integer overflow issues.
8444 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8445 now (part of C89). Include <verify.h>.
8446 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8447 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8448 (Fformat): Avoid the prepass trying to compute sizes; it was only
8449 approximate and thus did not catch overflow reliably. Instead, walk
8450 through the format just once, formatting and computing sizes as we go,
8451 checking for integer overflow at every step, and allocating a larger
8452 buffer as needed. Keep track separately whether the format is
8453 multibyte. Keep only the most-recently calculated precision, rather
8454 than them all. Record whether each argument has been converted to
8455 string. Use EMACS_INT, not int, for byte and char and arg counts.
8456 Support field widths and precisions larger than INT_MAX. Avoid
8457 sprintf's undefined behavior with conversion specifications such as %#d
8458 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8459 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8460 formatting out-of-range floating point numbers with int
8463 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8465 * data.c: Avoid integer truncation in expressions involving floats.
8466 * data.c: Include <intprops.h>.
8467 (arith_driver): When there's an integer overflow in an expression
8468 involving floating point, convert the integers to floating point
8469 so that the resulting value does not suffer from catastrophic
8470 integer truncation. For example, on a 64-bit host (* 4
8471 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8472 Do not rely on undefined behavior after integer overflow.
8474 merge count_size_as_multibyte, parse_str_to_multibyte
8475 * character.c, character.h (count_size_as_multibyte):
8476 Rename from parse_str_to_multibyte; all uses changed.
8477 Check for integer overflow.
8478 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8479 since it's now a duplicate of the other. This is more of
8480 a character than a buffer op, so better that it's in character.c.
8481 * fns.c, print.c: Adjust to above changes.
8483 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8485 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8487 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8489 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8490 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8491 (x_clipboard_manager_save): Now static.
8492 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8494 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8495 (crypto_hash_function): Now static.
8496 Fix pointer signedness problems. Avoid unnecessary initializations.
8498 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8500 * termhooks.h (Vselection_alist): Make it terminal-local.
8502 * terminal.c (create_terminal): Initialize it.
8504 * xselect.c: Support for clipboard managers.
8505 (Vselection_alist): Move to termhooks.h as terminal-local var.
8506 (LOCAL_SELECTION): New macro.
8507 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8508 (symbol_to_x_atom): Remove gratuitous arg.
8509 (x_handle_selection_request, lisp_data_to_selection_data)
8510 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8511 (x_own_selection, x_get_local_selection, x_convert_selection):
8512 New arg, specifying work frame. Use terminal-local Vselection_alist.
8513 (some_frame_on_display): Delete unused function.
8514 (Fx_own_selection_internal, Fx_get_selection_internal)
8515 (Fx_disown_selection_internal, Fx_selection_owner_p)
8516 (Fx_selection_exists_p): New optional frame arg.
8517 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8518 (x_handle_selection_clear): Don't treat other terminals with the
8519 same keyboard specially. Use the terminal-local Vselection_alist.
8520 (x_clear_frame_selections): Use Frun_hook_with_args.
8522 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8524 * xterm.h: Add support for those atoms.
8526 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8528 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8529 (converted_selections, conversion_fail_tag): New global variables.
8530 (x_selection_request_lisp_error): Free the above.
8531 (x_get_local_selection): Remove unnecessary code.
8532 (x_reply_selection_request): Args changed; handle arbitrary array
8533 of converted selections stored in converted_selections.
8534 Separate the XChangeProperty and SelectionNotify steps.
8535 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8536 (x_convert_selection): New function.
8537 (x_handle_selection_event): Simplify.
8538 (x_get_foreign_selection): Don't ignore incoming requests while
8539 waiting for an answer; this will fail when we implement
8540 SAVE_TARGETS, and seems unnecessary anyway.
8541 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8542 (Vx_sent_selection_functions): Doc fix.
8544 2011-05-26 Leo Liu <sdl.web@gmail.com>
8546 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8548 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8550 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8552 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8553 for fringe update if it has periodic bitmap.
8554 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8555 and fringe_bitmap_periodic_p.
8557 * fringe.c (get_fringe_bitmap_data): New function.
8558 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8559 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8560 row. Mark glyph row for fringe update if periodicity changed.
8562 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8563 for fringe update unless it has periodic bitmap.
8565 2011-05-25 Kenichi Handa <handa@m17n.org>
8567 * xdisp.c (get_next_display_element): Set correct it->face_id for
8568 a static composition.
8570 2011-05-24 Leo Liu <sdl.web@gmail.com>
8573 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8575 * fns.c (crypto_hash_function, Fsha1): New function.
8576 (Fmd5): Use crypto_hash_function.
8577 (syms_of_fns): Add Ssha1.
8579 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8581 * gnutls.c: Remove unused macros.
8582 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8583 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8584 Remove macros that are defined and never used.
8585 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8587 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8589 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8590 (Fx_get_selection_internal): Minor cleanup.
8591 (Fx_own_selection_internal): Rename arguments for consistency with
8594 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8596 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8598 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8600 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8602 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8604 * dispnew.c (scrolling_window): Don't exclude the case that the
8605 last enabled row in the desired matrix touches the bottom boundary.
8607 2011-05-21 Glenn Morris <rgm@gnu.org>
8609 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8610 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8611 and add some more files.
8613 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8615 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8616 report_file_error introduced by the change from 2011-05-07.
8618 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8620 * systime.h (Time): Define only if emacs is defined.
8621 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8622 where the include path doesn't have X11/X.h by default. See
8623 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8625 2011-05-20 Kenichi Handa <handa@m17n.org>
8627 * composite.c (find_automatic_composition): Fix previous change.
8629 2011-05-20 Glenn Morris <rgm@gnu.org>
8631 * lisp.mk: New file, split from Makefile.in.
8632 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8633 (shortlisp): Remove.
8634 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8636 2011-05-19 Glenn Morris <rgm@gnu.org>
8638 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8639 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8640 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8641 (lisp): Set the order to that of loadup.el.
8642 (shortlisp): Make it a copy of $lisp.
8643 (SOME_MACHINE_LISP): Remove.
8644 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8645 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8647 2011-05-18 Kenichi Handa <handa@m17n.org>
8649 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8650 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8651 (find_automatic_composition): Mostly rewrite for efficiency.
8653 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8655 * makefile.w32-in: Update dependencies.
8657 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8659 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8660 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8662 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8664 Fix some integer overflow issues, such as string length overflow.
8666 * insdel.c (count_size_as_multibyte): Check for string overflow.
8668 * character.c (lisp_string_width): Check for string overflow.
8669 Use EMACS_INT, not int, for string indexes and lengths; in
8670 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8671 the resulting string length overflows an EMACS_INT; instead,
8672 report a string overflow if no precision given. When checking for
8673 precision exhaustion, use a check that cannot possibly have
8674 integer overflow. (Bug#8675)
8675 * character.h (lisp_string_width): Adjust to new signature.
8677 * alloc.c (string_overflow): New function.
8678 (Fmake_string): Use it. This doesn't change behavior, but saves
8679 a few bytes and will simplify future changes.
8680 * character.c (string_escape_byte8): Likewise.
8681 * lisp.h (string_overflow): New decl.
8683 Fixups, following up to the user-interface timestamp change.
8684 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8685 for UI timestamps, instead of unsigned long.
8686 * msdos.c (mouse_get_pos): Likewise.
8687 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8688 * w32gui.h (Time): Define by including "systime.h" rather than by
8689 declaring it ourselves. (Bug#8664)
8691 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8692 * image.c (clear_image_cache): Likewise.
8694 * term.c (term_mouse_position): Don't assume time_t wraparound.
8696 Be more systematic about user-interface timestamps.
8697 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8698 and sometimes 'EMACS_UINT', to represent these timestamps.
8699 This change causes it to use 'Time' uniformly, as that's what X uses.
8700 This makes the code easier to follow, and makes it easier to catch
8701 integer overflow bugs such as Bug#8664.
8702 * frame.c (Fmouse_position, Fmouse_pixel_position):
8703 Use Time, not unsigned long, for user-interface timestamps.
8704 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8705 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8706 * keyboard.h (last_event_timestamp): Likewise.
8707 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8708 * menu.h (xmenu_show): Likewise.
8709 * term.c (term_mouse_position): Likewise.
8710 * termhooks.h (struct input_event.timestamp): Likewise.
8711 (struct terminal.mouse_position_hook): Likewise.
8712 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8713 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8714 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8715 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8717 * menu.h, termhooks.h: Include "systime.h", for Time.
8719 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8720 Don't assume that the difference between two unsigned long values
8721 can fit into an integer. At this point, we know button_down_time
8722 <= event->timestamp, so the difference must be nonnegative, so
8723 there's no need to cast the result if double-click-time is
8724 nonnegative, as it should be; check that it's nonnegative, just in
8725 case. This bug is triggered when events are more than 2**31 ms
8726 apart (about 25 days). (Bug#8664)
8728 * xselect.c (last_event_timestamp): Remove duplicate decl.
8729 (x_own_selection): Remove needless cast to unsigned long.
8731 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8732 that always fit in int. Use a sentinel instead of a counter, to
8733 avoid a temp and to allay GCC's concerns about possible int overflow.
8734 * frame.h (struct frame): Use int for menu_bar_items_used
8735 instead of EMACS_INT, since it always fits in int.
8737 * menu.c (grow_menu_items): Check for int overflow.
8739 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8741 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8742 Before, the code was not consistent. These values cannot exceed
8743 2**31 - 1 so there's no need to make them unsigned.
8744 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8745 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8746 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8748 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8750 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8751 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8752 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8753 presumably because the widths might not match.
8755 * window.c (size_window): Avoid needless test at loop start.
8757 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8759 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8761 2011-05-12 Drew Adams <drew.adams@oracle.com>
8763 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8765 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8767 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8768 `width' to `bar_area_x' and `bar_area_width', respectively.
8769 (x_scroll_run): Take account of fringe background extension.
8771 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8772 Rename local vars `left' and `width' to `bar_area_x' and
8773 `bar_area_width', respectively.
8774 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8775 background extension.
8777 2011-05-10 Jim Meyering <meyering@redhat.com>
8779 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8781 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8783 * image.c (Finit_image_library): Return t for built-in image types,
8784 like pbm and xbm. (Bug#8640)
8786 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8788 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8790 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8792 * w32console.c (Fset_screen_color): Doc fix.
8793 (Fget_screen_color): New function.
8794 (syms_of_ntterm): Defsubr it.
8796 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8797 unlink the temporary file if Fcall_process didn't create it in the
8799 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8800 child process will be redirected to a file specified with `:file'.
8801 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8802 cue to call_process_cleanup not to close that handle.
8804 2011-05-07 Ben Key <bkey76@gmail.com>
8806 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8807 one of two shell specific rules, either bootstrap-temacs-CMD or
8808 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8809 to the previous implementation of the bootstrap-temacs rule.
8810 The bootstrap-temacs-CMD rule is similar to the previous
8811 implementation of the bootstrap-temacs rule except that it
8812 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8815 These changes, along with some changes to nt/configure.bat,
8816 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8817 earlier fix to add support for --cflags and --ldflags options
8818 that include quotes so that it works whether make uses cmd or
8821 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8823 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8824 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8826 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8827 a string. Handle both cases.
8828 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8829 (Fdbus_register_method): Use Qinvalid_function.
8831 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8833 * makefile.w32-in: Update dependencies.
8834 (LISP_H): Add inttypes.h and stdin.h.
8835 (PROCESS_H): Add unistd.h.
8837 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8839 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8840 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8842 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8844 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8846 * term.c (vfatal): Remove stray call to va_end.
8847 It's not needed and the C Standard doesn't allow it here anyway.
8849 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8850 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8852 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8855 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8857 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8859 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8861 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8863 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8865 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8866 * charset.c (Fdefine_charset_internal): Don't initialize
8867 charset.code_space[15]. The value was garbage, on hosts with
8868 32-bit int (Bug#8600).
8870 * lread.c (read_integer): Be more consistent with string-to-number.
8871 Use string_to_number to do the actual conversion; this avoids
8872 rounding errors and fixes some other screwups. Without this fix,
8873 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8874 (digit_to_number): Move earlier, for benefit of read_integer.
8875 Return -1 if the digit is out of range for the base, -2 if it is
8876 not a digit in any supported base. (Bug#8602)
8878 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8880 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8881 to match comment at start of function. This also removes a
8882 GCC warning about overflow in a 32+64-bit port.
8884 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8886 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8887 Reported by Stefan Monnier in
8888 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8889 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8890 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8892 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8893 (EMACS_UINTPTR): Likewise, with uintptr_t.
8895 * lisp.h: Prefer 64-bit EMACS_INT if available.
8896 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8897 on 32-bit hosts that have 64-bit int, so that they can access
8899 However, temporarily disable this change unless the temporary
8900 symbol WIDE_EMACS_INT is defined.
8902 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8904 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8905 This removes an assumption that EMACS_INT and long are the same
8906 width as pointers. The assumption is true for Emacs porting targets
8907 now, but we want to make other targets possible.
8908 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8909 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8910 In the rest of the code, change types of integers that hold casted
8911 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8912 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8913 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8914 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8915 No need to cast type when ORing.
8916 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8917 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8918 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8919 assume EMACS_INT is the same width as char *.
8920 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8921 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8922 Remove no-longer-needed casts.
8923 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8924 (xg_tool_bar_help_callback, xg_make_tool_item):
8925 Use EMACS_INTPTR to hold an integer
8926 that will be cast to void *; this can avoid a GCC warning
8927 if EMACS_INT is not the same width as void *.
8928 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8929 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8930 (current_message_1, set_message_1):
8931 Use a local to convert to proper width without a cast.
8932 * xmenu.c (dialog_selection_callback): Likewise.
8934 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8935 Also, don't assume VALBITS / RAND_BITS is less than 5,
8936 and don't rely on undefined behavior when shifting a 1 left into
8938 * lisp.h (get_random): Change signature to match.
8940 * lread.c (hash_string): Use size_t, not int, for hash computation.
8941 Normally we prefer signed values; but hashing is special, because
8942 it's better to use unsigned division on hash table sizes so that
8943 the remainder is nonnegative. Also, size_t is the natural width
8944 for hashing into memory. The previous code used 'int', which doesn't
8945 retain enough info to hash well into very large tables.
8946 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8948 * dbusbind.c: Don't possibly lose pointer info when converting.
8949 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8950 Use XPNTR rather than XHASH, so that the high-order bits of
8951 the pointer aren't lost when converting through void *.
8953 * eval.c (Fautoload): Don't double-shift a pointer.
8955 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8957 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8959 * gnutls.c (DEF_GNUTLS_FN):
8960 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8962 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8964 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8967 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8969 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8970 New version that can reserve upto 2GB of heap space.
8972 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8974 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8976 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8978 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8979 `gnutls_certificate_set_x509_key_file'.
8981 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8983 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8984 Update dependencies.
8986 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8988 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8989 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8990 Remove unused parameter `fildes'.
8991 * process.c (read_process_output, send_process): Don't pass it.
8993 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8995 Fix previous change: the library cache is defined in w32.c.
8996 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8997 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8999 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9001 Implement dynamic loading of GnuTLS on Windows.
9003 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9004 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9005 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9008 * gnutls.c (Qgnutls_dll): Define.
9009 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9010 (gnutls_*): Declare function pointers.
9011 (init_gnutls_functions): New function to initialize function pointers.
9012 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9013 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9014 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9015 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9016 (emacs_gnutls_write, emacs_gnutls_read)
9017 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9018 (Fgnutls_available_p): New function.
9019 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9020 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9021 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9023 * image.c: Include w32.h.
9024 (Vimage_type_cache): Delete.
9025 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9026 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9027 (w32_delayed_load): Move to w32.c.
9029 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9031 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9032 (w32_delayed_load): Move from image.c. When loading a library, record
9033 its filename in the :loaded-from property of the library id.
9034 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9035 Initialize and staticpro them.
9036 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9038 * process.c: Include lisp.h before w32.h, not after.
9039 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9040 instead of gnutls_record_check_pending.
9042 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9044 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9046 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9047 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9050 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9052 * xterm.c (x_set_frame_alpha): Do not set property on anything
9053 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9055 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9057 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9059 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9061 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9062 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9063 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9064 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9065 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9066 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9067 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9068 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9069 (Qgnutls_bootprop_callbacks_verify): Make static.
9071 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9073 * callproc.c: Indentation fixup.
9075 * sysdep.c (wait_for_termination_1): Make static.
9076 (wait_for_termination, interruptible_wait_for_termination):
9077 Move after wait_for_termination_1.
9079 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9081 * sysdep.c (interruptible_wait_for_termination): New function
9082 which is like wait_for_termination, but allows keyboard
9085 * callproc.c (Fcall_process): Add (:file "file") as an option for
9087 (Fcall_process_region): Ditto.
9089 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9091 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9092 rather than `XVECTOR (FOO)->size'.
9094 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9095 inttypes.h, as a gnulib replacement is used if it not available in
9098 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9100 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9101 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9102 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9104 * coding.c (coding_alloc_by_realloc): Error out if destination
9105 will grow beyond MOST_POSITIVE_FIXNUM.
9106 (decode_coding_emacs_mule): Abort if there isn't enough place in
9107 charbuf for the composition carryover bytes. Reserve an extra
9108 space for up to 2 characters produced in a loop.
9109 (decode_coding_iso_2022): Abort if there isn't enough place in
9110 charbuf for the composition carryover bytes.
9112 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9114 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9115 aborting when %lld or %lll format is passed.
9116 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9117 %llo or %llx format is passed. (Bug#8545)
9119 * window.c (window_scroll_line_based): Use a marker instead of
9120 simple variables to record original value of point. (Bug#7952)
9122 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9123 produced by %s or %c overflows available buffer space. (Bug#8545)
9125 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9127 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9128 (SIZE_MAX): Move defn after all includes, as they might #define it.
9130 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9132 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9134 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9136 * keyboard.c (Qdelayed_warnings_hook): Define.
9137 (command_loop_1): Run `delayed-warnings-hook'
9138 if Vdelayed_warnings_list is non-nil.
9139 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9140 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9142 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9144 * doprnt.c (doprnt): Don't return value smaller than the buffer
9145 size if the message was truncated. (Bug#8545).
9147 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9149 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9150 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9152 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9154 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9156 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9158 * makefile.w32-in: Update dependencies.
9160 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9162 Improve `doprnt' and its usage. (Bug#8545)
9163 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9164 `format_end'. Remove support for %l as a conversion specifier.
9165 Don't use xrealloc. Improve diagnostics when the %l size modifier
9166 is used. Update the commentary.
9168 * eval.c (verror): Simplify calculation of size_t.
9170 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9173 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9175 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9178 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9180 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9181 This makes this file independent of the recent pseudovector change.
9183 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9185 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9187 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9188 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9189 Remove unused local.
9190 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9192 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9193 GCC 4.6.0 optimizes based on type-based alias analysis.
9194 For example, if b is of type struct buffer * and v of type struct
9195 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9196 != &v->size, and therefore "v->size = 1; b->size = 2; return
9197 v->size;" must therefore return 1. This assumption is incorrect
9198 for Emacs, since it type-puns struct Lisp_Vector * with many other
9199 types. To fix this problem, this patch adds a new type struct
9200 vectorlike_header that documents the constraints on layout of vectors
9201 and pseudovectors, and helps optimizing compilers not get fooled
9202 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9203 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9204 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9206 (XSETPVECTYPE): Rewrite in terms of new macro.
9207 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9208 This is a bit clearer, and further avoids the possibility of
9209 undesirable aliasing.
9210 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9211 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9212 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9213 since Lisp_Subr is a special case (no "next" field).
9214 (ASIZE): Now uses header.size rather than size.
9215 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9216 to avoid the hassle of writing XVECTOR (foo)->header.size.
9217 (struct vectorlike_header): New type.
9218 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9219 object, to help avoid aliasing.
9220 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9221 (SUBRP): Likewise, since Lisp_Subr is a special case.
9222 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9223 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9224 (struct Lisp_Hash_Table): Combine first two members into a single
9225 struct vectorlike_header member. All uses of "size" and "next" members
9226 changed to be "header.size" and "header.next".
9227 * buffer.h (struct buffer): Likewise.
9228 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9229 * frame.h (struct frame): Likewise.
9230 * process.h (struct Lisp_Process): Likewise.
9231 * termhooks.h (struct terminal): Likewise.
9232 * window.c (struct save_window_data, struct saved_window): Likewise.
9233 * window.h (struct window): Likewise.
9234 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9235 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9236 * buffer.c (init_buffer_once): Likewise.
9237 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9239 * process.c (Fformat_network_address): Use local var for size,
9242 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9244 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9245 * data.c (atof): Remove decl; no longer used or needed.
9246 (digit_to_number): Move to lread.c.
9247 (Fstring_to_number): Use new string_to_number function, to be
9248 consistent with how the Lisp reader treats infinities and NaNs.
9249 Do not assume that floating-point numbers represent EMACS_INT
9250 without losing information; this is not true on most 64-bit hosts.
9251 Avoid double-rounding errors, by insisting on integers when
9252 parsing non-base-10 numbers, as the documentation specifies.
9253 * lisp.h (string_to_number): New decl, replacing ...
9254 (isfloat_string): Remove.
9255 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9256 (read1): Do not accept +. and -. as integers; this
9257 appears to have been a coding error. Similarly, do not accept
9258 strings like +-1e0 as floating point numbers. Do not report
9259 overflow for integer overflows unless the base is not 10 which
9260 means we have no simple and reliable way to continue.
9261 Break out the floating-point parsing into a new
9262 function string_to_number, so that Fstring_to_number parses
9263 floating point numbers consistently with the Lisp reader.
9264 (digit_to_number): Move here from data.c. Make it static inline.
9265 (E_CHAR, EXP_INT): Remove, replacing with ...
9266 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9267 (string_to_number): New function, replacing isfloat_string.
9268 This function checks for valid syntax and produces the resulting
9269 Lisp float number too. Rework it so that string-to-number
9270 no longer mishandles examples like "1.0e+". Use strtoumax,
9271 so that overflow for non-base-10 numbers is reported only when
9272 there's no portable and simple way to convert to floating point.
9274 * textprop.c (set_text_properties_1): Rewrite for clarity,
9275 and to avoid GCC warning about integer overflow.
9277 * intervals.h (struct interval): Use EMACS_INT for members
9278 where EMACS_UINT might cause problems. See
9279 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9280 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9281 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9283 (offset_intervals): Tell GCC not to worry about length overflow
9284 when negating a negative length.
9286 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9287 (overrun_check_free): Likewise.
9289 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9290 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9293 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9294 (gnutls_make_error): Rename local to avoid shadowing.
9295 (gnutls_emacs_global_deinit): ifdef out; not used.
9296 (Fgnutls_boot): Use const for pointer to readonly storage.
9297 Comment out unused local. Fix pointer signedness problems.
9299 * lread.c (openp): Don't stuff size_t into an 'int'.
9300 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9301 about possible signed overflow.
9303 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9304 (GDK_KEY_g): Don't define if already defined.
9305 (xg_prepare_tooltip): Avoid pointer signedness problem.
9306 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9308 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9309 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9311 * xfns.c (Fx_window_property): Simplify a bit,
9312 to make a bit faster and to avoid GCC 4.6.0 warning.
9313 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9315 * fns.c (internal_equal): Don't assume size_t fits in int.
9317 * alloc.c (compact_small_strings): Tighten assertion a little.
9319 Replace pEd with more-general pI, and fix some printf arg casts.
9320 * lisp.h (pI): New macro, generalizing old pEd macro to other
9321 conversion specifiers. For example, use "...%"pI"d..." rather
9322 than "...%"pEd"...".
9323 (pEd): Remove. All uses replaced with similar uses of pI.
9324 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9325 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9326 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9327 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9328 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9329 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9330 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9332 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9333 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9334 * print.c (safe_debug_print, print_object): Likewise.
9335 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9337 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9338 avoiding the 0 flag, which is not portable.
9339 * process.c (Fmake_network_process): Use pI to avoid cast.
9340 * region-cache.c (pp_cache): Likewise.
9341 * xdisp.c (decode_mode_spec): Likewise.
9342 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9343 behavior on 64-bit hosts with printf arg.
9344 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9345 (x_stop_queuing_selection_requests): Likewise.
9346 (x_get_window_property): Don't truncate byte count to an 'int'
9349 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9350 here, since it parses constructs like leading '-' and spaces,
9351 which are not wanted; and it overflows with large numbers.
9352 Instead, simply match F[0-9]+, which is what is wanted anyway.
9354 * alloc.c: Remove unportable assumptions about struct layout.
9355 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9356 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9357 (allocate_vectorlike, make_pure_vector): Use the new macros,
9358 plus offsetof, to remove unportable assumptions about struct layout.
9359 These assumptions hold on all porting targets that I know of, but
9360 they are not guaranteed, they're easy to remove, and removing them
9361 makes further changes easier.
9363 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9364 This doesn't fix a bug but makes the code clearer.
9365 (string_overrun_cookie): Now const. Use initializers that
9366 don't formally overflow signed char, to avoid warnings.
9367 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9368 can cause Emacs to crash when string overrun checking is enabled.
9369 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9370 multiple of sizeof (EMACS_INT); it need not be, if
9371 alignof(EMACS_INT) < sizeof (EMACS_INT).
9372 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9374 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9376 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9378 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9380 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9381 supposed to be handshaking. (Bug#8556)
9382 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9384 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9386 * lisp.h (Qdebug): List symbol.
9387 * eval.c (Qdebug): Restore global linkage.
9388 * keyboard.c (debug-on-event): New variable.
9389 (handle_user_signal): Break into debugger when debug-on-event
9390 matches the current signal symbol.
9392 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9394 * alloc.c (check_sblock, check_string_bytes)
9395 (check_string_free_list): Convert to standard C.
9397 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9399 * w32.c (emacs_gnutls_push): Fix typo.
9401 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9403 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9404 "cast to pointer from integer of different size".
9406 Improve doprnt and its use in verror. (Bug#8545)
9407 * doprnt.c (doprnt): Document the set of format control sequences
9408 supported by the function. Use SAFE_ALLOCA instead of always
9411 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9412 is one byte too soon. Don't use xrealloc; instead xfree and
9415 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9417 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9420 * gnutls.c: Renamed global_initialized to
9421 gnutls_global_initialized. Added internals for the
9422 :verify-hostname-error, :verify-error, and :verify-flags
9423 parameters of `gnutls-boot' and documented those parameters in the
9424 docstring. Start callback support.
9425 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9426 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9427 on error. Return error code.
9428 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9429 (emacs_gnutls_read): Likewise.
9430 (Fgnutls_boot): Return handshake error code.
9431 (emacs_gnutls_handle_error): New function.
9432 (wsaerror_to_errno): Likewise.
9434 * w32.h (emacs_gnutls_pull): Add prototype.
9435 (emacs_gnutls_push): Likewise.
9437 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9438 (emacs_gnutls_push): Likewise.
9440 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9442 * process.c (wait_reading_process_output): Check if GnuTLS
9443 buffered some data internally if no FDs are set for TLS
9446 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9447 (LIBS): Link to USER_LIBS.
9448 ($(BLD)/gnutls.$(0)): New target.
9450 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9452 * xdisp.c (handle_single_display_spec): Rename the
9453 display_replaced_before_p argument into display_replaced_p, to
9454 make it consistent with the commentary. Fix typos in the
9457 * textprop.c (syms_of_textprop): Remove dead code.
9458 (copy_text_properties): Delete obsolete commentary about an
9459 interface that was deleted long ago. Fix typos in the description
9462 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9463 to changes in oldXMenu/XMenu.h from 2011-04-16.
9464 <menu_help_message, prev_menu_help_message>: Constify.
9465 (IT_menu_make_room): menu->help_text is now `const char **';
9468 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9469 to changes in oldXMenu/XMenu.h from 2011-04-16.
9470 (struct XMenu): Declare `help_text' `const char **'.
9472 * xfaces.c <Qunspecified>: Make extern again.
9474 * syntax.c: Include sys/types.h before including regex.h, as
9477 * doc.c (get_doc_string): Improve the format passed to `error'.
9479 * doprnt.c (doprnt): Improve commentary.
9481 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9483 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9486 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9487 changes in globals.h immediately force recompilation.
9488 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9489 $(CURDIR)/s/ms-w32.h.
9490 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9492 * character.c (Fchar_direction): Function deleted.
9493 (syms_of_character): Don't defsubr it.
9494 <char-direction-table>: Deleted.
9496 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9498 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9499 * doprnt.c: Include limits.h.
9500 (SIZE_MAX): New macro.
9501 (doprnt): Return a size_t value. 2nd arg is now size_t.
9502 Many local variables are now size_t instead of int or unsigned.
9503 Improve overflow protection. Support `l' modifier for integer
9504 conversions. Support %l conversion. Don't assume an EMACS_INT
9505 argument for integer conversions and for %c.
9507 * lisp.h (doprnt): Restore prototype.
9509 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9512 * Makefile.in (base_obj): Add back doprnt.o.
9514 * deps.mk (doprnt.o): Add back prerequisites.
9515 (callint.o): Depend on character.h.
9517 * eval.c (internal_lisp_condition_case): Include the handler
9518 representation in the error message.
9519 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9520 when breaking from the loop.
9522 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9524 * callint.c (Fcall_interactively): When displaying error message
9525 about invalid control letter, pass the character's codepoint, not
9526 a pointer to its multibyte form. Improve display of the character
9527 in octal and display also its hex code.
9529 * character.c (char_string): Use %x to display the (unsigned)
9530 codepoint of an invalid character, to avoid displaying a bogus
9533 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9534 `error', not SYMBOL_NAME itself.
9536 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9537 character arguments to `error'.
9539 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9540 to `error' in error message about FINAL_CHAR argument. Make sure
9541 FINAL_CHAR is a character, and use %c when it is passed as
9542 argument to `error'.
9544 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9546 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9548 * w32.c: Include <time.h>.
9549 (sys_localtime): New function.
9551 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9553 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9555 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9557 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9559 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9562 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9564 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9565 gl_state.e_property when gl_state.object is Qt.
9567 * insdel.c (make_gap_larger): Remove limitation of buffer size
9570 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9572 * xdisp.c (lookup_glyphless_char_display)
9573 (produce_glyphless_glyph): Handle cons cell entry in
9574 glyphless-char-display.
9575 (Vglyphless_char_display): Document it.
9577 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9578 glyphless-char-display.
9580 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9582 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9584 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9586 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9587 definition for no-X builds.
9589 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9591 Static checks with GCC 4.6.0 and non-default toolkits.
9593 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9595 * process.c (keyboard_bit_set): Define only if SIGIO.
9596 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9597 (send_process): Repair possible setjmp clobbering.
9599 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9601 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9603 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9605 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9606 Define only if needed.
9608 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9609 by pacifying GCC about it. Maybe it's time to retire it?
9610 * xfaces.c (USG, __TIMEVAL__): Likewise.
9612 * dispextern.h (struct redisplay_interface): Rename param
9614 * termhooks.h (struct terminal): Likewise.
9615 * xterm.c (xembed_send_message): Likewise.
9617 * insdel.c (make_gap_smaller): Define only if
9618 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9620 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9623 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9624 so that we aren't warned about unused symbols.
9626 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9628 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9630 * xfns.c (x_real_positions): Mark locals as initialized.
9632 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9634 * xterm.c: Fix problems found by static analysis with other toolkits.
9635 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9636 (x_dispatch_event): Declare static if USE_GTK, and
9637 define if USE_GTK || USE_X_TOOLKIT.
9638 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9639 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9640 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9641 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9643 * xmenu.c (menu_help_callback): Pointer type fixes.
9644 Use const pointers when pointing at readonly data. Avoid pointer
9646 (FALSE): Remove unused macro.
9647 (update_frame_menubar): Remove unused decl.
9649 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9651 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9652 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9653 (single_menu_item): Rename local to avoid shadowing.
9655 * keyboard.c (make_lispy_event): Remove unused local var.
9657 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9658 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9660 * bitmaps: Change bitmaps from unsigned char back to the X11
9661 compatible char. Avoid the old compiler warnings about
9662 out-of-range initializers by using, for example, '\xab' rather
9665 * xgselect.c (xgselect_initialize): Check vs interface
9666 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9668 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9670 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9671 to read-only memory.
9673 * fns.c (vector): Remove; this old hack is no longer needed.
9675 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9677 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9679 * xrdb.c (x_load_resources): Omit unused local.
9681 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9682 (x_window): Rename locals to avoid shadowing.
9683 (USG): Use the kludged USG macro, to pacify gcc.
9685 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9686 (x_term_init): Remove local to avoid shadowing.
9688 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9690 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9691 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9693 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9695 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9697 Fix regex.c, syntax.c and friends for buffers > 2GB.
9698 * syntax.h (struct gl_state_s): Declare character position members
9701 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9703 * textprop.c (verify_interval_modification, interval_of):
9704 Declare arguments EMACS_INT.
9706 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9709 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9711 * indent.c (Fvertical_motion): Local variable it_start is now
9714 * regex.c (re_match, re_match_2, re_match_2_internal)
9715 (bcmp_translate, regcomp, regexec, print_double_string)
9716 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9717 (re_compile_pattern, re_exec): Declare arguments and local
9718 variables `size_t' and `ssize_t' and return values `regoff_t', as
9720 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9721 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9722 <compile_stack_type>: `size' and `avail' are now `size_t'.
9724 * regex.h <regoff_t>: Use ssize_t, not int.
9725 (re_search, re_search_2, re_match, re_match_2): Arguments that
9726 specify buffer/string position and length are now ssize_t and
9727 size_t. Return type is regoff_t.
9729 2011-04-16 Ben Key <bkey76@gmail.com>
9731 * nsfont.m: Fixed bugs in ns_get_family and
9732 ns_descriptor_to_entity that were caused by using free to
9733 deallocate memory blocks that were allocated by xmalloc (via
9734 xstrdup). This caused Emacs to crash when compiled with
9735 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9736 --enable-checking=xmallocoverrun). xfree is now used to
9737 deallocate these memory blocks.
9739 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9741 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9743 emacs_write: Accept and return EMACS_INT for sizes.
9744 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9746 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9747 Accept and return EMACS_INT.
9748 (emacs_gnutls_write): Return the number of bytes written on
9750 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9751 (emacs_read, emacs_write): Remove check for negative size, as the
9752 Emacs source code has been audited now.
9753 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9754 (emacs_read, emacs_write): Use it.
9755 * process.c (send_process): Adjust to the new signatures of
9756 emacs_write and emacs_gnutls_write. Do not attempt to store
9757 a byte offset into an 'int'; it might overflow.
9758 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9760 * sound.c: Don't assume sizes fit in 'int'.
9761 (struct sound_device.period_size, alsa_period_size):
9762 Return EMACS_INT, not int.
9763 (struct sound_device.write, vox_write, alsa_write):
9764 Accept EMACS_INT, not int.
9765 (wav_play, au_play): Use EMACS_INT to store sizes and to
9766 record read return values.
9768 2011-04-15 Ben Key <bkey76@gmail.com>
9770 * keyboard.c (Qundefined): Don't declare static since it is used
9772 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9773 static since they are used in nsfont.m.
9775 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9777 * process.c (Qprocessp): Don't declare static.
9778 * lisp.h (Qprocessp): Declare again.
9780 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9782 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9784 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9786 Improve C-level modularity by making more things 'static'.
9788 Don't publish debugger-only interfaces to other modules.
9789 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9790 (verify_bytepos, count_markers): Move decls to the only modules
9792 * region-cache.h (pp_cache): Likewise.
9793 * window.h (check_all_windows): Likewise.
9794 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9796 * sysdep.c (croak): Now static, if
9797 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9798 * syssignal.h (croak): Declare only if not static.
9800 * alloc.c (refill_memory_reserve): Now static if
9801 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9802 * lisp.h (refill_memory_reserve): Declare only if not static.
9804 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9805 Define only if USE_LUCID.
9807 * xrdb.c (x_customization_string, x_rm_string): Now static.
9809 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9810 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9812 * xdisp.c (draw_row_with_mouse_face): Now static.
9813 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9815 * window.h (check_all_windows): Mark externally visible.
9817 * window.c (window_deletion_count): Now static.
9819 * undo.c: Make symbols static if they're not exported.
9820 (last_undo_buffer, last_boundary_position, pending_boundary):
9823 * textprop.c (interval_insert_behind_hooks): Now static.
9824 (interval_insert_in_front_hooks): Likewise.
9826 * term.c: Make symbols static if they're not exported.
9827 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9828 (max_frame_lines, tty_set_terminal_modes):
9829 (tty_reset_terminal_modes, tty_turn_off_highlight):
9830 (get_tty_terminal): Now static.
9831 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9832 * termhooks.h (term_mouse_moveto): Do not declare if
9834 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9835 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9837 * sysdep.c: Make symbols static if they're not exported.
9838 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9840 (sigprocmask_set, full_mask): Remove; unused.
9841 (wait_debugging): Mark as visible.
9842 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9843 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9845 * syntax.c (syntax_temp): Define only if !__GNUC__.
9847 * sound.c (current_sound_device, current_sound): Now static.
9849 * search.c (searchbufs, searchbuf_head): Now static.
9851 * scroll.c (scroll_cost): Remove; unused.
9852 * dispextern.h (scroll_cost): Remove decl.
9854 * region-cache.h (pp_cache): Mark as externally visible.
9856 * process.c: Make symbols static if they're not exported.
9857 (process_tick, update_tick, create_process, chan_process):
9858 (Vprocess_alist, proc_buffered_char, datagram_access):
9859 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9860 (deactivate_process): Mark defn as static, as well as decl.
9861 * lisp.h (create_process): Remove decl.
9862 * process.h (chan_process, Vprocess_alist): Remove decls.
9864 * print.c: Make symbols static if they're not exported.
9865 (print_depth, new_backquote_output, being_printed, print_buffer):
9866 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9867 (print_interval, print_number_index, initial_stderr_stream):
9869 * lisp.h (Fprinc): Remove decl.
9870 (debug_output_compilation_hack): Mark as externally visible.
9872 * sysdep.c (croak): Move decl from here to syssignal.h.
9873 * syssignal.h (croak): Put it here, so the API can be checked when
9874 'croak' is called from dissociate_if_controlling_tty.
9876 * minibuf.c: Make symbols static if they're not exported.
9877 (minibuf_save_list, choose_minibuf_frame): Now static.
9878 * lisp.h (choose_minibuf_frame): Remove decl.
9880 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9882 * lread.c: Make symbols static if they're not exported.
9883 (read_objects, initial_obarray, oblookup_last_bucket_number):
9885 (make_symbol): Remove; unused.
9886 * lisp.h (initial_obarray, make_symbol): Remove decls.
9888 * keyboard.c: Make symbols static if they're not exported.
9889 (single_kboard, recent_keys_index, total_keys, recent_keys):
9890 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9891 (this_single_command_key_start, echoing, last_auto_save):
9892 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9893 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9894 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9895 (Vlispy_mouse_stem, double_click_count):
9897 (force_auto_save_soon): Define only if SIGDANGER.
9898 (ignore_mouse_drag_p): Now static if
9899 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9900 (print_help): Remove; unused.
9901 (stop_character, last_timer_event): Mark as externally visible.
9902 * keyboard.h (ignore_mouse_drag_p): Declare only if
9903 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9904 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9905 * lisp.h (echoing): Remove decl.
9906 (force_auto_save_soon): Declare only if SIGDANGER.
9907 * xdisp.c (redisplay_window): Simplify code, to make it more
9908 obvious that ignore_mouse_drag_p is not accessed if !defined
9909 USE_GTK && !defined HAVE_NS.
9911 * intervals.c: Make symbols static if they're not exported.
9912 (merge_properties_sticky, merge_interval_right, delete_interval):
9914 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9916 * insdel.c: Make symbols static if they're not exported.
9917 However, leave prepare_to_modify_buffer alone. It's never
9918 called from outside this function, but that appears to be a bug.
9919 (combine_after_change_list, combine_after_change_buffer):
9920 (adjust_after_replace, signal_before_change): Now static.
9921 (adjust_after_replace_noundo): Remove; unused.
9922 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9923 (signal_before_change): Remove decls.
9925 * indent.c (val_compute_motion, val_vmotion): Now static.
9927 * image.c: Make symbols static if they're not exported.
9928 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9930 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9931 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9933 * fringe.c (standard_bitmaps): Now static.
9934 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9936 * frame.c: Make symbols static if they're not exported.
9937 (x_report_frame_params, make_terminal_frame): Now static.
9938 (get_frame_param): Now static, unless HAVE_NS.
9939 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9940 (x_get_resource_string): Remove; not used.
9941 * frame.h (make_terminal_frame, x_report_frame_params):
9942 (x_get_resource_string); Remove decls.
9943 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9944 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9946 * font.c, fontset.c: Make symbols static if they're not exported.
9947 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9948 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9949 * font.c (font_close_object): Now static.
9950 * font.h (font_close_object): Remove.
9951 * fontset.c (FONTSET_OBJLIST): Remove.
9952 (free_realized_fontset) #if-0 the body, which does nothing.
9953 (face_suitable_for_char_p): #if-0, as it's never called.
9954 * fontset.h (face_suitable_for_char_p): Remove decl.
9955 * xfaces.c (face_at_string_position):
9956 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9957 since 0 is always ASCII.
9959 * fns.c (weak_hash_tables): Now static.
9961 * fileio.c: Make symbols static if they're not exported.
9962 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9963 (Vwrite_region_annotation_buffers): Now static.
9965 * eval.c: Make symbols static if they're not exported.
9966 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9967 * lisp.h (backtrace_list): Remove decl.
9969 * emacs.c: Make symbols static if they're not exported.
9970 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9971 (fatal_error_code, fatal_error_signal_hook, standard_args):
9973 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9974 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9975 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9976 * lisp.h (fatal_error_signal_hook): Remove decl.
9977 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9979 * editfns.c: Move a (normally-unused) function to its only use.
9980 * editfns.c, lisp.h (get_operating_system_release): Remove.
9981 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9982 worth the hassle of breaking this out.
9984 * xterm.c: Make symbols static if they're not exported.
9985 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9986 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9987 (x_destroy_window, x_delete_display):
9989 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9990 (x_mouse_leave): Remove; unused.
9991 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9992 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9993 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9995 (x_mouse_leave): Declare only if WINDOWSNT.
9996 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9997 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10000 * ftxfont.c: Make symbols static if they're not exported.
10001 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10003 * font.h (ftxfont_driver): Likewise.
10005 * xfns.c: Make symbols static if they're not exported.
10006 (x_last_font_name, x_display_info_for_name):
10007 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10008 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10009 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10010 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10011 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10012 (last_show_tip_args): Now static.
10013 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10014 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10015 (x_screen_planes): Remove; unused.
10016 * dispextern.h (x_screen_planes): Remove decl.
10018 * dispnew.c: Make symbols static if they're not exported.
10019 * dispextern.h (redraw_garbaged_frames, scrolling):
10020 (increment_row_positions): Remove.
10021 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10022 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10024 (redraw_garbaged_frames): Remove; unused.
10026 * xfaces.c: Make symbols static if they're not exported.
10027 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10029 * xterm.h (defined_color): Remove decls.
10030 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10031 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10032 (menu_face_changed_default, defined_color, free_realized_face):
10033 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10034 (ascii_face_of_lisp_face): Remove; unused.
10036 * xdisp.c: Make symbols static if they're not exported.
10037 * dispextern.h (scratch_glyph_row, window_box_edges):
10038 (glyph_to_pixel_coords, set_cursor_from_row):
10039 (get_next_display_element, set_iterator_to_next):
10040 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10041 (show_mouse_face): Remove decls
10042 * frame.h (message_buf_print): Likewise.
10043 * lisp.h (pop_message, set_message, check_point_in_composition):
10045 * xterm.h (set_vertical_scroll_bar): Likewise.
10046 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10047 (message_buf_print, scratch_glyph_row, displayed_buffer):
10048 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10049 (get_next_display_element, show_mouse_face, window_box_edges):
10050 (frame_to_window_pixel_xy, check_point_in_composition):
10051 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10052 (glyph_to_pixel_coords): Remove; unused.
10054 * dired.c (file_name_completion): Now static.
10056 * dbusbind.c (xd_in_read_queued_messages): Now static.
10058 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10059 * data.c (circular_list_error): Remove.
10061 * commands.h (last_point_position, last_point_position_buffer):
10062 (last_point_position_window): Remove decls.
10063 * keyboard.c: Make these variables static.
10065 * coding.h (coding, code_convert_region, encode_coding_gap):
10067 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10068 (iso_code_class, detect_coding, code_convert_region): Now static.
10069 (encode_coding_gap): Remove; unused.
10071 * chartab.c (chartab_chars, chartab_bits): Now static.
10073 * charset.h (charset_iso_8859_1): Remove decl.
10074 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10077 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10078 * ccl.c (Vccl_program_table): Now static.
10079 (check_ccl_update): Remove; unused.
10081 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10082 * category.h: ... from here.
10083 * category.c (check_category_table, set_category_set): Now static.
10085 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10086 * lisp.h: Remove these decls.
10088 * buffer.c (buffer_count): Remove unused var.
10090 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10091 so that it's not optimized away.
10092 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10093 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10094 exported only to the debugger.
10096 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10097 * atimer.h (run_all_atimers): Remove; not exported.
10099 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10100 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10101 was inaccessible from Lisp.
10102 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10103 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10105 alloc.c: Import and export fewer symbols, and remove unused items.
10106 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10108 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10109 it's not optimized away by whole-program optimization.
10110 (message_enable_multibyte, free_misc): Remove.
10111 (catchlist, handlerlist, mark_backtrace):
10112 Declare only if BYTE_MARK_STACK.
10113 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10114 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10115 (message_enable_multibyte): Remove decl.
10116 (free_misc, interval_free_list, float_block, float_block_index):
10117 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10118 (cons_free_list, last_marked_index):
10120 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10121 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10122 (mark_backtrace): Define only if BYTE_MARK_STACK.
10123 * xdisp.c (message_enable_multibyte): Now static.
10125 Declare Lisp_Object Q* variables to be 'static' if not exported.
10126 This makes it easier for human readers (and static analyzers)
10127 to see whether these variables are used from other modules.
10128 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10129 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10130 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10131 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10132 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10133 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10134 * xmenu.c, xselect.c:
10135 Declare Q* vars static if they are not used in other modules.
10136 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10137 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10138 Remove decls of unexported vars.
10139 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10141 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10143 Make Emacs functions such as Fatom 'static' by default.
10144 This makes it easier for human readers (and static analyzers)
10145 to see whether these functions can be called from other modules.
10146 DEFUN now defines a static function. To make the function external
10147 so that it can be used in other C modules, use the new macro DEFUE.
10148 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10149 (Finit_image_library):
10150 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10151 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10152 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10153 Remove decls, since these functions are now static.
10154 (Funintern, Fget_internal_run_time): New decls, since these functions
10155 were already external.
10157 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10158 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10159 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10160 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10161 * keyboard.c, keymap.c, lread.c:
10162 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10163 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10164 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10165 Mark functions with DEFUE instead of DEFUN,
10166 if they are used in other modules.
10167 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10168 decls for now-static functions.
10169 * buffer.h (Fdelete_overlay): Remove decl.
10170 * callproc.c (Fgetenv_internal): Mark as internal.
10171 * composite.c (Fremove_list_of_text_properties): Remove decl.
10172 (Fcomposition_get_gstring): New forward static decl.
10173 * composite.h (Fcomposite_get_gstring): Remove decl.
10174 * dired.c (Ffile_attributes): New forward static decl.
10175 * doc.c (Fdocumntation_property): New forward static decl.
10176 * eval.c (Ffetch_bytecode): New forward static decl.
10177 (Funintern): Remove extern decl; now in .h file where it belongs.
10178 * fileio.c (Fmake_symbolic_link): New forward static decl.
10179 * image.c (Finit_image_library): New forward static decl.
10180 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10181 * intervals.h (Fprevious_property_change):
10182 (Fremove_list_of_text_properties): Remove decls.
10183 * keyboard.c (Fthis_command_keys): Remove decl.
10184 (Fcommand_execute): New forward static decl.
10185 * keymap.c (Flookup_key): New forward static decl.
10186 (Fcopy_keymap): Now static.
10187 * keymap.h (Flookup_key): Remove decl.
10188 * process.c (Fget_process): New forward static decl.
10189 (Fprocess_datagram_address): Mark as internal.
10190 * syntax.c (Fsyntax_table_p): New forward static decl.
10191 (skip_chars): Remove duplicate decl.
10192 * textprop.c (Fprevious_property_change): New forward static decl.
10193 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10195 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10196 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10198 * editfns.c (Fformat): Remove unreachable code.
10200 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10202 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10205 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10207 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10208 when at ZV. (Bug#8487)
10210 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10212 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10214 * keyboard.c (parse_tool_bar_item): Likewise.
10215 * sound.c (sound_cleanup, alsa_close): Likewise.
10216 * termcap.c (tgetent): Likewise.
10217 * xfns.c (x_default_font_parameter): Likewise.
10218 * xsettings.c (read_and_apply_settings): Likewise.
10220 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10221 (overrun_check_free): Protoize.
10223 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10225 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10226 since callers should never pass a negative size.
10227 Change the signature to match that of plain 'read' and 'write'; see
10228 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10229 * lisp.h: Update prototypes of emacs_write and emacs_read.
10231 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10233 * xdisp.c (redisplay_window): Don't try to determine the character
10234 position of the scroll margin if the window start point w->startp
10235 is outside the buffer's accessible region. (Bug#8468)
10237 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10239 Fix write-region and its subroutines for buffers > 2GB.
10240 * fileio.c (a_write, e_write): Modify declaration of arguments and
10241 local variables to support buffers larger than 2GB.
10242 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10244 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10245 argument, local variables, and return value.
10247 * lisp.h: Update prototypes of emacs_write and emacs_read.
10249 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10251 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10253 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10255 Fix more problems found by GCC 4.6.0's static checks.
10257 * xdisp.c (vmessage): Use a better test for character truncation.
10259 * charset.c (load_charset_map): <, not <=, for optimization,
10260 and to avoid potential problems with integer overflow.
10261 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10262 * casetab.c (set_identity, shuffle): Likewise.
10263 * editfns.c (Fformat): Likewise.
10264 * syntax.c (skip_chars): Likewise.
10266 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10267 This also lets GCC 4.6.0 generate slightly better loop code.
10269 * callint.c (Fcall_interactively): <, not <=, for optimization.
10270 (Fcall_interactively): Count the number of arguments produced,
10271 not the number of arguments given. This is simpler and lets GCC
10272 4.6.0 generate slightly better code.
10274 * ftfont.c: Distingish more carefully between FcChar8 and char.
10275 The previous code passed unsigned char * to a functions like
10276 strlen and xstrcasecmp that expect char *, which does not
10277 conform to the C standard.
10278 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10279 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10280 char * when the C standard requires it.
10282 * keyboard.c (read_char): Remove unused var.
10284 * eval.c: Port to Windows vsnprintf (Bug#8435).
10285 Include <limits.h>.
10286 (SIZE_MAX): Define if the headers do not.
10287 (verror): Do not give up if vsnprintf returns a negative count.
10288 Instead, grow the buffer. This ports to Windows vsnprintf, which
10289 does not conform to C99. Problem reported by Eli Zaretskii.
10290 Also, simplify the allocation scheme, by avoiding the need for
10291 calling realloc, and removing the ALLOCATED variable.
10293 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10295 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10296 But keep the doprint source code for now, as we might revamp it
10297 and use it again (Bug#8435).
10298 * lisp.h (doprnt): Remove.
10299 * Makefile.in (base_obj): Remove doprnt.o.
10300 * deps.mk (doprnt.o): Remove.
10302 error: Print 32- and 64-bit integers portably (Bug#8435).
10303 Without this change, on typical 64-bit hosts error ("...%d...", N)
10304 was used to print both 32- and 64-bit integers N, which relied on
10305 undefined behavior.
10306 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10307 * lisp.h (error, verror): Mark as printf-like functions.
10308 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10309 Report overflow in size calculations when allocating printf buffer.
10310 Do not truncate output string at its first null byte.
10311 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10312 Truncate the output at a character boundary, since vsnprintf does not
10314 * charset.c (check_iso_charset_parameter): Convert internal
10315 character to string before calling 'error', since %c now has the
10317 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10318 overflow when computing char to be passed to 'error'. Do not
10319 pass Lisp_Object to 'error'; pass the integer instead.
10320 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10321 formatted with plain %d.
10323 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10325 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10327 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10329 * xterm.c (x_catch_errors): Remove duplicate declaration.
10331 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10333 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10335 2011-04-10 Jim Meyering <meyering@redhat.com>
10337 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10338 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10339 return ssize_t not "int", and use size_t as the buffer length.
10340 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10341 * gnutls.h: Update declarations.
10342 * process.c (read_process_output): Use ssize_t, to match.
10343 (send_process): Likewise.
10345 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10347 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10349 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10351 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10352 Use unsigned char, to match FcChar8 type definition.
10354 * xterm.c (handle_one_xevent):
10355 * xmenu.c (create_and_show_popup_menu):
10356 * xselect.c (x_decline_selection_request)
10357 (x_reply_selection_request): Avoid type-punned deref of X events.
10359 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10361 Fix some uses of `int' instead of EMACS_INT.
10362 * search.c (string_match_1, fast_string_match)
10363 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10364 (scan_buffer, find_next_newline_no_quit)
10365 (find_before_next_newline, search_command, Freplace_match)
10366 (Fmatch_data): Make some `int' variables be EMACS_INT.
10368 * xdisp.c (display_count_lines): 3rd argument and return value now
10369 EMACS_INT. All callers changed.
10370 (pint2hrstr): Last argument is now EMACS_INT.
10372 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10373 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10374 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10375 (decode_coding_utf_16, decode_coding_emacs_mule)
10376 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10377 (decode_coding_ccl, decode_coding_charset)
10378 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10379 (decode_coding_iso_2022, decode_coding_emacs_mule)
10380 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10381 <char_offset, last_offset>: Declare EMACS_INT.
10382 (encode_coding_utf_8, encode_coding_utf_16)
10383 (encode_coding_emacs_mule, encode_invocation_designation)
10384 (encode_designation_at_bol, encode_coding_iso_2022)
10385 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10386 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10388 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10389 (encode_invocation_designation): Last argument P_NCHARS is now
10391 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10392 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10394 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10397 * ccl.c (Fccl_execute_on_string): Declare some variables
10400 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10402 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10404 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10406 * process.c (Fformat_network_address): Doc fix.
10408 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10410 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10412 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10414 * keyboard.c (read_char): Call Lisp function help-form-show,
10415 instead of using internal_with_output_to_temp_buffer.
10416 (Qhelp_form_show): New var.
10417 (syms_of_keyboard): Use DEFSYM macro.
10419 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10421 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10423 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10425 * process.c (Flist_processes): Remove to Lisp.
10426 (list_processes_1): Delete.
10428 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10430 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10432 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10434 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10436 Fix more problems found by GCC 4.6.0's static checks.
10438 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10440 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10442 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10444 * xdisp.c (vmessage): Mark as a printf-like function.
10446 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10448 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10450 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10451 printf-like functions.
10452 (tiff_load): Add casts to remove these marks before passing them
10453 to system-supplied API.
10455 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10457 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10458 This avoids several warnings with gcc -Wstrict-overflow.
10459 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10460 directly, rather than having caller test rule sign. This avoids
10461 some unnecessary tests.
10462 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10463 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10464 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10466 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10467 (xfont_open): Avoid unnecessary tests.
10469 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10471 * composite.h, composite.c (composition_gstring_put_cache):
10472 Use EMACS_INT, not int, for length.
10474 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10475 breaking out part of COMPOSITION_DECODE_RULE.
10476 (COMPOSITION_DECODE_RULE): Use it.
10477 * composite.c (get_composition_id): Remove unused local vars,
10478 by using the new macro.
10480 * textprop.c (set_text_properties_1): Change while to do-while,
10481 since the condition is always true at first.
10483 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10484 (interval_deletion_adjustment): Return unsigned value.
10487 * process.c (list_processes_1, create_pty, read_process_output):
10488 (exec_sentinel): Remove vars that were set but not used.
10489 (create_pty): Remove unnecessary "volatile"s.
10490 (Fnetwork_interface_info): Avoid possibility of int overflow.
10491 (read_process_output): Do adaptive read buffering even if carryover.
10492 (read_process_output): Simplify nbytes computation if buffered.
10494 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10496 * syntax.c (scan_words): Remove var that was set but not used.
10497 (update_syntax_table): Use unsigned instead of int.
10499 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10500 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10501 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10503 * print.c (print_error_message): Avoid int overflow.
10505 * font.c (font_list_entities): Redo for clarity,
10506 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10508 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10509 (font_score): Avoid potential overflow in diff calculation.
10511 * fns.c (substring_both): Remove var that is set but not used.
10512 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10514 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10516 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10517 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10518 can always succeed if overflow has undefined behavior.
10520 * search.c (boyer_moore, wordify): Remove vars set but not used.
10521 (wordify): Omit three unnecessary tests.
10523 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10524 All callers changed. This avoids the need for an unused var.
10526 * casefiddle.c (casify_region): Remove var that is set but not used.
10528 * dired.c (file_name_completion): Remove var that is set but not used.
10530 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10532 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10533 (Finsert_file_contents): Remove unnecessary code checking fd.
10535 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10536 Check for integer overflow on size calculations.
10538 * buffer.c (Fprevious_overlay_change): Remove var that is set
10541 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10542 Remove vars that are set but not used.
10543 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10544 (timer_check_2): Mark vars as initialized.
10546 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10548 * image.c (lookup_image): Remove var that is set but not used.
10549 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10551 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10552 that are set but not used.
10554 * xfns.c (make_invisible_cursor): Don't return garbage
10555 if XCreateBitmapFromData fails (Bug#8410).
10557 * xselect.c (x_get_local_selection, x_handle_property_notify):
10558 Remove vars that are set but not used.
10560 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10561 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10563 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10564 Remove var that is set but not used.
10565 (scroll_bar_windows_size): Now size_t, not int.
10566 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10567 Check for overflow.
10569 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10570 (map_tty_color) [!defined MSDOS]: Likewise.
10572 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10574 * coding.c: Remove vars that are set but not used.
10575 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10576 All callers changed.
10577 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10578 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10579 (decode_coding_charset): Remove vars that are set but not used.
10581 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10582 that is set but not used.
10584 * print.c (print_object): Remove var that is set but not used.
10586 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10587 The gnulib version avoids calling malloc in the usual case,
10588 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10589 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10590 * filelock.c (current_lock_owner): Likewise.
10591 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10592 * sysdep.c: Include allocator.h, careadlinkat.h.
10593 (emacs_no_realloc_allocator): New static constant.
10594 (emacs_readlink): New function.
10595 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10596 ../lib/careadlinkat.h.
10598 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10600 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10601 first non-nil return value).
10603 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10605 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10606 if not defined (Bug#8403).
10608 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10610 * xdisp.c (display_count_lines): Remove parameter `start',
10611 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10612 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10613 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10614 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10615 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10616 and thereabouts. All callers changed.
10617 (get_per_char_metric): Remove parameter `f', unused since
10618 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10620 2011-04-02 Jim Meyering <meyering@redhat.com>
10622 do not dereference NULL upon failed strdup
10623 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10624 (ns_get_family): Likewise.
10626 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10628 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10630 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10632 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10635 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10637 Add lexical binding.
10639 * window.c (Ftemp_output_buffer_show): New fun.
10640 (Fsave_window_excursion):
10641 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10643 * lread.c (lisp_file_lexically_bound_p): New function.
10644 (Fload): Bind Qlexical_binding.
10645 (readevalloop): Remove `evalfun' arg.
10646 Bind Qinternal_interpreter_environment.
10647 (Feval_buffer): Bind Qlexical_binding.
10648 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10650 (syms_of_lread): Declare `lexical-binding'.
10652 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10654 * keyboard.c (eval_dyn): New fun.
10655 (menu_item_eval_property): Use it.
10657 * image.c (parse_image_spec): Use Ffunctionp.
10659 * fns.c (concat, mapcar1): Accept byte-code-functions.
10661 * eval.c (Fsetq): Handle lexical vars.
10662 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10663 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10664 (FletX, Flet): Obey lexical binding.
10665 (Fcommandp): Handle closures.
10666 (Feval): New `lexical' arg.
10667 (eval_sub): New function extracted from Feval. Use it almost
10668 everywhere where Feval was used. Look up vars in lexical env.
10670 (Ffunctionp): Move from subr.el.
10671 (Ffuncall): Handle closures.
10672 (apply_lambda): Remove `eval_flags'.
10673 (funcall_lambda): Handle closures and new byte-code-functions.
10674 (Fspecial_variable_p): New function.
10675 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10676 but without exporting it to Lisp.
10678 * doc.c (Fdocumentation, store_function_docstring):
10679 * data.c (Finteractive_form): Handle closures.
10681 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10684 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10686 (exec_byte_code): New function extracted from Fbyte_code to handle new
10687 calling convention for byte-code-functions. Add new byte-codes.
10689 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10691 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10693 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10695 * xdisp.c (redisplay_internal): Fix prototype.
10697 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10699 * xdisp.c (SCROLL_LIMIT): New macro.
10700 (try_scrolling): Use it when setting scroll_limit.
10701 Limit scrolling to 100 screen lines.
10702 (redisplay_window): Even when falling back on "recentering",
10703 position point in the window according to scroll-conservatively,
10704 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10706 (try_scrolling): When point is above the window, allow searching
10707 as far as scroll_max, or one screenful, to compute vertical
10708 distance from PT to the scroll margin position. This prevents
10709 try_scrolling from unnecessarily failing when
10710 scroll-conservatively is set to a value slightly larger than the
10711 window height. Clean up the case of PT below the margin at bottom
10712 of window: scroll_max can no longer be INT_MAX. When aggressive
10713 scrolling is in use, don't let point enter the opposite scroll
10714 margin as result of the scroll.
10715 (syms_of_xdisp) <scroll-conservatively>: Document the
10716 threshold of 100 lines for never-recentering scrolling.
10718 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10720 * dispextern.h (move_it_by_lines):
10721 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10722 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10723 (message_log_check_duplicate): Remove parameters `prev_bol' and
10724 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10725 (redisplay_internal): Remove parameter `preserve_echo_area',
10726 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10728 * indent.c (Fvertical_motion):
10729 * window.c (window_scroll_pixel_based, Frecenter):
10730 Don't pass `need_y_p' to `move_it_by_lines'.
10732 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10734 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10735 steal a few bits to be more compact.
10736 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10737 Remove unneeded casts.
10739 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10741 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10743 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10744 binding" message (bug#7967).
10746 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10748 Fix more problems found by GCC 4.6.0's static checks.
10750 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10751 Remove unused local var.
10753 * editfns.c (Fmessage_box): Remove unused local var.
10755 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10756 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10757 Omit unused local vars.
10758 * window.c (shrink_windows): Omit unused local var.
10759 * menu.c (digest_single_submenu): Omit unused local var.
10760 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10761 Omit unused local var.
10763 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10764 Don't assume string length fits in int.
10765 (keyremap_step, read_key_sequence): Use size_t for sizes.
10766 (read_key_sequence): Don't check last_real_key_start redundantly.
10768 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10769 instead of alloca (Bug#8344).
10771 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10772 (Fbacktrace_frame): Don't assume nframes fits in int.
10774 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10776 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10779 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10781 * cm.c (calccost): Turn while-do into do-while, for clarity.
10783 * keyboard.c (syms_of_keyboard): Use the same style as later
10784 in this function when indexing through an array. This also
10785 works around GCC bug 48267.
10787 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10789 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10791 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10792 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10794 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10795 This avoids undefined behavior on integer overflow, and is a bit
10796 more convenient anyway since it is compared to a size_t variable.
10798 Variadic C functions now count arguments with size_t, not int.
10799 This avoids an unnecessary limitation on 64-bit machines, which
10800 caused (substring ...) to crash on large vectors (Bug#8344).
10801 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10802 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10803 All variadic functions and their callers changed accordingly.
10804 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10805 * data.c (arith_driver, float_arith_driver): Likewise.
10806 * editfns.c (general_insert_function): Likewise.
10807 * eval.c (struct backtrace.nargs, interactive_p)
10808 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10809 (funcall_lambda, mark_backtrace): Likewise.
10810 * fns.c (concat): Likewise.
10811 * frame.c (x_set_frame_parameters): Likewise.
10812 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10813 0 if not found, not -1. All callers changed.
10815 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10816 (stack_copy_size): Now size_t, not int.
10817 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10819 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10821 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10822 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10823 All callers changed.
10825 * lisp.h (multibyte_char_to_unibyte):
10826 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10827 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10828 * character.h (CHAR_TO_BYTE8):
10829 * cmds.c (internal_self_insert):
10830 * editfns.c (general_insert_function):
10831 * keymap.c (push_key_description):
10832 * search.c (Freplace_match):
10833 * xdisp.c (message_dolog, set_message_1): All callers changed.
10835 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10837 * keyboard.c (safe_run_hook_funcall): New function.
10838 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10839 don't set the hook to nil, but remove the offending function instead.
10840 (Qcommand_hook_internal): Remove, unused.
10841 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10842 Vcommand_hook_internal.
10844 * eval.c (enum run_hooks_condition): Remove.
10845 (funcall_nil, funcall_not): New functions.
10846 (run_hook_with_args): Call each function through a `funcall' argument.
10847 Remove `cond' argument, now redundant.
10848 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10849 (Frun_hook_with_args_until_failure): Adjust accordingly.
10850 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10852 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10854 * dispextern.h (string_buffer_position): Remove declaration.
10856 * print.c (strout): Remove parameter `multibyte', unused since
10857 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10859 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10860 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10861 All callers changed.
10863 * w32.c (_wsa_errlist): Use braces for struct initializers.
10865 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10866 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10867 All callers changed.
10868 (string_buffer_position): Likewise. Also, make static (it's never
10869 used outside xdisp.c).
10870 (cursor_row_p): Remove parameter `w', unused since
10871 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10872 (decode_mode_spec): Remove parameter `precision', introduced during
10873 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10874 All callers changed.
10876 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10878 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10880 2011-03-27 Anders Lindgren <andlind@gmail.com>
10882 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10883 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10884 (ns_update_auto_hide_menu_bar): New functions.
10885 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10886 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10887 ns_constrain_all_frames.
10888 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10889 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10891 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10893 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10895 2011-03-27 Glenn Morris <rgm@gnu.org>
10897 * syssignal.h: Replace RETSIGTYPE with void.
10898 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10899 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10900 Replace SIGTYPE with void everywhere.
10901 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10902 * s/template.h (SIGTYPE): Remove commented out definition.
10904 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10906 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10907 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10909 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10911 * w32.c (read_unc_volume): Use parameter `henum', instead of
10912 global variable `wget_enum_handle'.
10914 * keymap.c (describe_vector): Remove parameters `indices' and
10915 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10916 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10918 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10920 * keyboard.c (timer_check): Remove parameter `do_it_now',
10921 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10922 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10923 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10925 * keyboard.c (read_char):
10926 * w32menu.c (w32_menu_display_help):
10927 * xmenu.c (show_help_event, menu_help_callback):
10928 Adjust calls to `show_help_echo'.
10930 * gtkutil.c (xg_maybe_add_timer):
10931 * keyboard.c (readable_events):
10932 * process.c (wait_reading_process_output):
10933 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10935 * insdel.c (adjust_markers_gap_motion):
10936 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10937 (gap_left, gap_right): Don't call it.
10939 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10941 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10942 incurred during fontification.
10944 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10946 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10947 (DEFVAR_PER_BUFFER): Don't pass it.
10949 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10950 (scrolling_window): Don't pass it.
10952 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10954 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10956 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10958 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10959 of variables specific to SELinux and computation of `encoded_absname'.
10961 * image.c (XPutPixel): Remove unused variable `height'.
10963 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10965 * unexw32.c (get_section_info): Remove unused variable `section'.
10967 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10968 (system_process_attributes): Remove unused variable `sess'.
10969 (sys_read): Remove unused variable `err'.
10971 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10972 (w32_wnd_proc): Remove unused variable `isdead'.
10973 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10974 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10975 (x_create_tip_frame): Remove unused variable `tem'.
10977 * w32inevt.c (w32_console_read_socket):
10978 Remove unused variable `no_events'.
10980 * w32term.c (x_draw_composite_glyph_string_foreground):
10981 Remove unused variable `width'.
10983 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10985 * w32term.c (x_set_glyph_string_clipping):
10986 Don't pass uninitialized region to CombineRgn.
10988 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10990 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10991 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10992 (Fx_close_connection): Remove unused variable `i'.
10994 * w32font.c (w32font_draw): Return number of glyphs.
10995 (w32font_open_internal): Remove unused variable `i'.
10996 (w32font_driver): Add missing initializer.
10998 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10999 (fill_in_menu): Remove unused variable `items_added'.
11001 * w32term.c (last_mouse_press_frame): Remove static global variable.
11002 (w32_clip_to_row): Remove unused variable `f'.
11003 (x_delete_terminal): Remove unused variable `i'.
11005 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11006 (NOTHING): Remove unused static global variable.
11007 (uniscribe_check_otf): Remove unused variable `table'.
11008 (uniscribe_font_driver): Add missing initializers.
11010 2011-03-23 Julien Danjou <julien@danjou.info>
11012 * term.c (Fsuspend_tty, Fresume_tty):
11013 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11014 * window.c (temp_output_buffer_show):
11015 * insdel.c (signal_before_change):
11016 * frame.c (Fhandle_switch_frame):
11017 * fileio.c (Fdo_auto_save):
11018 * emacs.c (Fkill_emacs):
11019 * editfns.c (save_excursion_restore):
11020 * cmds.c (internal_self_insert):
11021 * callint.c (Fcall_interactively):
11022 * buffer.c (Fkill_all_local_variables):
11023 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11025 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11026 unconditionally since it does the check itself.
11028 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11030 Fix more problems found by GCC 4.5.2's static checks.
11032 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11033 the first time through the loop, since we know p0 < p1 then.
11034 This also avoids a gcc -Wstrict-overflow warning.
11036 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11037 leading to a memory leak, possible in functions like
11038 load_charset_map_from_file that can allocate an unbounded number
11039 of objects (Bug#8318).
11041 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11042 that could (at least in theory) be that large.
11044 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11045 This is less likely to overflow, and avoids undefined behavior if
11046 overflow does occur. All callers changed. Use strtoul to scan
11047 for the unsigned long integer.
11048 (pint2hrstr): Simplify and tune code slightly.
11049 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11051 * scroll.c (do_scrolling): Work around GCC bug 48228.
11052 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11054 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11055 This also avoids a warning with gcc -Wstrict-overflow.
11056 (validate_x_resource_name): Simplify count usage.
11057 This also avoids a warning with gcc -Wstrict-overflow.
11059 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11062 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11064 * process.c (Fmake_network_process): Use socklen_t, not int,
11065 where POSIX says socklen_t is required in portable programs.
11066 This fixes a porting bug on hosts like 64-bit HP-UX, where
11067 socklen_t is wider than int (Bug#8277).
11068 (Fmake_network_process, server_accept_connection):
11069 (wait_reading_process_output, read_process_output):
11072 * process.c: Rename or move locals to avoid shadowing.
11073 (list_processes_1, Fmake_network_process):
11074 (read_process_output_error_handler, exec_sentinel_error_handler):
11075 Rename or move locals.
11076 (Fmake_network_process): Define label "retry_connect" only if needed.
11077 (Fnetwork_interface_info): Fix pointer signedness.
11078 (process_send_signal): Add cast to avoid pointer signedness problem.
11079 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11080 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11082 Make tparam.h and terminfo.c consistent.
11083 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11084 Include tparam.h instead, since it declares them.
11085 * cm.h (PC): Remove extern decl; tparam.h now does this.
11086 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11087 * terminfo.c: Include tparam.h, to check interfaces.
11088 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11089 (tparam): Adjust signature to match interface in tparam.h;
11090 this removes some undefined behavior. Check that outstring and len
11091 are zero, which they always are with Emacs.
11092 * tparam.h (PC, BC, UP): New extern decls.
11094 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11095 (xftfont_open): Rename locals to avoid shadowing.
11097 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11098 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11099 (OTF_TAG_SYM): Omit macro if not needed.
11100 (ftfont_list): Remove unused local.
11101 (get_adstyle_property, ftfont_pattern_entity):
11102 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11103 Rename locals to avoid shadowing.
11105 * xfont.c (xfont_list_family): Mark var as initialized.
11107 * xml.c (make_dom): Now static.
11109 * composite.c (composition_compute_stop_pos): Rename local to
11111 (composition_reseat_it): Remove unused locals.
11112 (find_automatic_composition, composition_adjust_point): Likewise.
11113 (composition_update_it): Mark var as initialized.
11114 (find_automatic_composition): Mark vars as initialized,
11115 with a FIXME (Bug#8290).
11117 character.h: Rename locals to avoid shadowing.
11118 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11119 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11120 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11121 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11122 to avoid shadowing.
11124 * textprop.c (property_change_between_p): Remove; unused.
11126 * intervals.c (interval_start_pos): Now static.
11128 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11130 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11131 Rename locals to avoid shadowing.
11133 * sound.c (wav_play, au_play, Fplay_sound_internal):
11134 Fix pointer signedness.
11135 (alsa_choose_format): Remove unused local var.
11136 (wav_play): Initialize a variable to 0, to prevent undefined
11137 behavior (Bug#8278).
11139 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11141 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11143 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11144 clobbering (Bug#8298).
11145 * sysdep.c (sys_subshell): Likewise.
11146 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11148 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11149 This should get cleaned up, so that child_setup has the
11150 same signature on all platforms.
11152 * callproc.c (call_process_cleanup): Now static.
11153 (relocate_fd): Rename locals to avoid shadowing.
11155 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11157 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11158 not to be necessary, and produces flickering.
11160 2011-03-20 Glenn Morris <rgm@gnu.org>
11162 * config.in: Remove file.
11164 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11166 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11167 are now in src/globals.h.
11168 (syms_of_minibuf): Remove spurious & from previous change.
11170 2011-03-20 Leo Liu <sdl.web@gmail.com>
11172 * minibuf.c (completing-read-function): New variable.
11173 (completing-read-default): Rename from completing-read.
11174 (completing-read): Call completing-read-function.
11176 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11178 * xfaces.c (Fx_load_color_file):
11179 Read color file from absolute filename (bug#8250).
11181 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11183 * makefile.w32-in: Update dependencies.
11185 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11187 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11189 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11191 Fix more problems found by GCC 4.5.2's static checks.
11193 * process.c (make_serial_process_unwind, send_process_trap):
11194 (sigchld_handler): Now static.
11196 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11197 That way, the code declares only the vars that it needs.
11198 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11199 * s/cygwin.h (PTY_ITERATION): Likewise.
11200 * s/darwin.h (PTY_ITERATION): Likewise.
11201 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11203 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11204 * process.c (allocate_pty): Don't declare stb unless it's needed.
11206 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11207 (CONSTANTLIM): Remove; unused.
11208 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11209 Define only if needed.
11211 * unexelf.c (unexec): Name an expression,
11212 to avoid gcc -Wbad-function-cast warning.
11213 Use a different way to cause a compilation error if anyone uses
11214 n rather than nn, a way that does not involve shadowing.
11215 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11217 * deps.mk (unexalpha.o): Remove; unused.
11219 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11220 * unexec.h: New file.
11221 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11222 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11223 Depend on unexec.h.
11224 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11225 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11226 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11227 Change as necessary to match prototype in unexec.h.
11229 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11231 (back_comment, skip_chars): Mark vars as initialized.
11233 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11234 Rename locals to avoid shadowing.
11236 * lread.c (read1): Rewrite so as not to use empty "else".
11237 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11239 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11241 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11242 warning when compiling print.c.
11244 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11245 instead of using an uninitialized var.
11246 (font_sort_entities): Mark var as initialized.
11248 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11250 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11251 pointers to constants.
11252 (font_parse_fcname): Remove unused vars.
11253 (font_delete_unmatched): Now static.
11254 (font_get_spec): Remove; unused.
11255 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11256 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11257 Rename or move locals to avoid shadowing.
11259 * fns.c (require_nesting_list, require_unwind): Now static.
11260 (Ffillarray): Rename locals to avoid shadowing.
11262 * floatfns.c (domain_error2): Define only if needed.
11263 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11265 * alloc.c (mark_backtrace): Move decl from here ...
11266 * lisp.h: ... to here, so that it can be checked.
11268 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11269 (Fdefvar): Rewrite so as not to use empty "else".
11270 (lisp_indirect_variable): Name an expression,
11271 to avoid gcc -Wbad-function-cast warning.
11272 (Fdefvar): Rename locals to avoid shadowing.
11274 * callint.c (quotify_arg, quotify_args): Now static.
11275 (Fcall_interactively): Rename locals to avoid shadowing.
11276 Use const pointer when appropriate.
11278 * lisp.h (get_system_name, get_operating_system_release):
11279 Move decls here, to check interfaces.
11280 * process.c (get_operating_system_release): Move decl to lisp.h.
11281 * xrdb.c (get_system_name): Likewise.
11282 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11283 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11284 some of which prompt warnings from gcc -Wbad-function-cast.
11285 (Fformat_time_string, Fencode_time, Finsert_char):
11286 (Ftranslate_region_internal, Fformat):
11287 Rename or remove local vars to avoid shadowing.
11288 (Ftranslate_region_internal): Mark var as initialized.
11290 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11293 * lisp.h (eassert): Check that the argument compiles, even if
11294 ENABLE_CHECKING is not defined.
11296 * data.c (Findirect_variable): Name an expression, to avoid
11297 gcc -Wbad-function-cast warning.
11298 (default_value, arithcompare, arith_driver, arith_error): Now static.
11299 (store_symval_forwarding): Rename local to avoid shadowing.
11300 (Fmake_variable_buffer_local, Fmake_local_variable):
11301 Mark variables as initialized.
11302 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11304 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11305 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11306 Rename locals to avoid shadowing.
11307 (mark_stack): Move local variables into the #ifdef region where
11309 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11310 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11312 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11313 (GC_STRING_CHARS): Remove; not used.
11314 (Fmemory_limit): Cast sbrk's returned value to char *.
11316 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11317 avoids undefined behavior in theory.
11319 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11321 Use functions, not macros, for up- and down-casing (Bug#8254).
11322 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11323 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11324 to use the following functions instead of these macros.
11325 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11326 EMACS_INT, since callers assume the returned value fits in int.
11327 (upcase1): Likewise, for UPCASE_TABLE.
11328 (uppercasep, lowercasep, upcase): New static inline functions.
11329 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11330 the race-condition problem in the old DOWNCASE.
11332 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11333 Rename locals to avoid shadowing.
11334 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11335 (regex_compile, re_search_2, re_match_2_internal):
11336 Remove unused local vars.
11337 (FREE_VAR): Rewrite so as not to use empty "else",
11338 which gcc can warn about.
11339 (regex_compile, re_match_2_internal): Mark locals as initialized.
11340 (RETALLOC_IF): Define only if needed.
11341 (WORDCHAR_P): Likewise. This one is never needed, but is used
11342 only in a comment talking about a compiler bug, so put inside
11343 the #if 0 of that comment.
11344 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11345 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11348 * search.c (boyer_moore): Rename locals to avoid shadowing.
11349 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11350 (PREV_CHAR_BOUNDARY): Likewise.
11352 * search.c (simple_search): Remove unused var.
11354 * dired.c (compile_pattern): Move decl from here ...
11355 * lisp.h: ... to here, so that it can be checked.
11356 (struct re_registers): New forward decl.
11358 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11360 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11362 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11363 Rename locals to avoid shadowing.
11364 (Fvertical_motion): Mark locals as initialized.
11366 * casefiddle.c (casify_object, casify_region): Now static.
11367 (casify_region): Mark local as initialized.
11369 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11371 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11372 New macros, so that the caller can use some names other than
11373 gcpro1, gcpro2, etc.
11374 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11376 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11377 argument, for consistency with GCPRO2_VAR, etc: it is now the
11378 prefix of the variable, not the variable itself. All uses
11380 * dired.c (directory_files_internal, file_name_completion):
11381 Rename locals to avoid shadowing.
11383 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11384 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11385 dired.c's scmp function, had undefined behavior.
11386 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11387 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11388 * buffer.h: ... to here, because these macros use current_buffer,
11389 and the new implementation with inline functions needs to have
11390 current_buffer in scope now, rather than later when the macros
11392 (downcase, upcase1): New static inline functions.
11393 (DOWNCASE, UPCASE1): Reimplement using these functions.
11394 This avoids undefined behavior in expressions like
11395 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11396 from race conditions in accessing the global variables
11397 case_temp1 and case_temp2.
11398 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11399 * lisp.h (case_temp1, case_temp2): Remove their decls.
11400 * character.h (ASCII_CHAR_P): Move from here ...
11401 * lisp.h: ... to here, so that the inline functions mentioned
11402 above can use them.
11404 * dired.c (directory_files_internal_unwind): Now static.
11406 * fileio.c (file_name_as_directory, directory_file_name):
11407 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11409 (file_name_as_directory): Use const pointers when appropriate.
11410 (Fexpand_file_name): Likewise. In particular, newdir might
11411 point at constant storage, so make it a const pointer.
11412 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11413 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11415 (Fset_file_times, Finsert_file_contents, auto_save_error):
11416 Rename locals to avoid shadowing.
11418 * minibuf.c (choose_minibuf_frame_1): Now static.
11419 (Ftry_completion, Fall_completions): Rename or remove locals
11420 to avoid shadowing.
11422 * marker.c (bytepos_to_charpos): Remove; unused.
11424 * lisp.h (verify_bytepos, count_markers): New decls,
11425 so that gcc does not warn that these functions aren't declared.
11427 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11428 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11429 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11430 (copy_text): Remove unused local var.
11432 * filelock.c (within_one_second): Now static.
11433 (lock_file_1): Rename local to avoid shadowing.
11435 * buffer.c (fix_overlays_before): Mark locals as initialized.
11436 (fix_start_end_in_overlays): Likewise. This function should be
11437 simplified by using pointers-to-pointers, but that's a different
11439 (switch_to_buffer_1): Now static.
11440 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11441 (report_overlay_modification): Rename locals to avoid shadowing.
11443 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11444 Fix pointer signedness issue.
11445 (sys_subshell): Mark local as volatile if checking for lint,
11446 to suppress a gcc -Wclobbered warning that does not seem to be right.
11447 (MAXPATHLEN): Define only if needed.
11449 * process.c (serial_open, serial_configure): Move decls from here ...
11450 * systty.h: ... to here, so that they can be checked.
11452 * fns.c (get_random, seed_random): Move extern decls from here ...
11453 * lisp.h: ... to here, so that they can be checked.
11455 * sysdep.c (reset_io): Now static.
11456 (wait_for_termination_signal): Remove; unused.
11458 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11459 (copy_keymap_item, append_key, push_text_char_description):
11461 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11462 (DENSE_TABLE_SIZE): Remove; unused.
11463 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11464 (describe_map_tree):
11465 Rename locals to avoid shadowing.
11467 * keyboard.c: Declare functions static if they are not used elsewhere.
11468 (echo_char, echo_dash, cmd_error, top_level_2):
11469 (poll_for_input, handle_async_input): Now static.
11470 (read_char, kbd_buffer_get_event, make_lispy_position):
11471 (make_lispy_event, make_lispy_movement, apply_modifiers):
11472 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11473 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11474 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11475 (read_key_sequence, read_char): Mark locals as initialized.
11476 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11478 * keyboard.h (make_ctrl_char): New decl.
11479 (mark_kboards): Move decl here ...
11480 * alloc.c (mark_kboards): ... from here.
11482 * lisp.h (force_auto_save_soon): New decl.
11484 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11485 (DEFINE_DUMMY_FUNCTION): New macro.
11486 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11488 (main): Add casts to avoid warnings
11489 if GCC considers string literals to be constants.
11491 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11493 * dbusbind.c: Pointer signedness fixes.
11494 (xd_signature, xd_append_arg, xd_initialize):
11495 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11496 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11497 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11498 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11500 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11501 if GCC considers string literals to be constants.
11502 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11504 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11506 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11507 (print_preprocess, print_object): New macro to fix last change.
11509 * print.c (print_preprocess): Don't forget font objects.
11511 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11513 * emacs.c (USAGE3): Doc fixes.
11515 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11517 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11520 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11522 * lisp.h (VWindow_system, Qfile_name_history):
11523 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11524 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11525 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11527 * w32select.c: Don't #include "keyboard.h".
11528 (run_protected): Add extern declaration for waiting_for_input.
11530 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11531 * w32console.c (detect_input_pending, read_input_pending)
11532 (encode_terminal_code):
11533 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11534 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11535 (w32_system_caret_y, Qfile_name_history):
11536 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11537 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11538 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11539 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11540 * w32proc.c (Qlocal, report_file_error):
11541 * w32term.c (Vwindow_system, updating_frame):
11542 * w32uniscribe.c (initialized, uniscribe_font_driver):
11543 Remove unneeded extern declarations.
11545 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11547 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11549 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11551 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11552 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11553 These macros can no longer be used for assignment.
11555 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11556 Assign struct members directly, instead of using BUF_BEGV etc.
11557 (record_buffer_markers, fetch_buffer_markers): New functions for
11558 recording and fetching special buffer markers.
11559 (set_buffer_internal_1, set_buffer_temp): Use them.
11561 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11563 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11565 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11566 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11568 * xdisp.c (hscroll_window_tree):
11569 (reconsider_clip_changes): Use PT instead of BUF_PT.
11571 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11573 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11574 $(EMACS_ROOT)/lib/intprops.h.
11576 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11578 Fix more problems found by GCC 4.5.2's static checks.
11580 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11581 to unsigned char * to avoid compiler diagnostic.
11582 (xg_free_frame_widgets): Make it clear that a local variable is
11583 needed only if USE_GTK_TOOLTIP.
11584 (gdk_window_get_screen): Make it clear that this macro is needed
11585 only if USE_GTK_TOOLTIP.
11586 (int_gtk_range_get_value): New function, which avoids a diagnostic
11587 from gcc -Wbad-function-cast.
11588 (xg_set_toolkit_scroll_bar_thumb): Use it.
11589 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11590 diagnostic from gcc -Wbad-function-cast.
11591 (get_utf8_string, xg_get_file_with_chooser):
11592 Rename locals to avoid shadowing.
11593 (create_dialog): Move locals to avoid shadowing.
11595 * xgselect.c (xg_select): Remove unused var.
11597 * image.c (four_corners_best): Mark locals as initialized.
11598 (gif_load): Initialize transparent_p to zero (Bug#8238).
11599 Mark another local as initialized.
11600 (my_png_error, my_error_exit): Mark with NO_RETURN.
11602 * image.c (clear_image_cache): Now static.
11603 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11604 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11605 (x_edge_detection): Remove unnecessary cast that
11606 gcc -Wbad-function-cast diagnoses.
11607 (gif_load): Fix pointer signedness.
11608 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11609 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11611 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11613 Improve quality of tests for time stamp overflow.
11614 For example, without this patch (encode-time 0 0 0 1 1
11615 1152921504606846976) returns the obviously-bogus value (-948597
11616 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11617 reports time overflow. See
11618 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11619 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11620 * editfns.c: Include limits.h and intprops.h.
11621 (TIME_T_MIN, TIME_T_MAX): New macros.
11622 (time_overflow): Move earlier, to before first use.
11623 (hi_time, lo_time): New functions, for an accurate test for
11624 out-of-range times.
11625 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11626 (Fget_internal_run_time): Don't assume time_t fits in int.
11627 (make_time): Use list2 instead of Fcons twice.
11628 (Fdecode_time): More accurate test for out-of-range times.
11629 (check_tm_member): New function.
11630 (Fencode_time): Use it, to test for out-of-range times.
11631 (lisp_time_argument): Don't rely on undefined left-shift and
11632 right-shift behavior when checking for time stamp overflow.
11634 * editfns.c (time_overflow): New function, refactoring common code.
11635 (Fformat_time_string, Fdecode_time, Fencode_time):
11636 (Fcurrent_time_string): Use it.
11638 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11639 * dired.c (make_time): Move to ...
11640 * editfns.c (make_time): ... here.
11641 * systime.h: Note the move.
11643 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11645 * fringe.c (update_window_fringes): Remove unused variables.
11647 * unexmacosx.c (copy_data_segment): Also copy __got section.
11650 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11652 * termcap.c [MSDOS]: Include "msdos.h".
11653 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11654 Constify `char *' arguments and their references according to
11655 prototypes in tparam.h.
11657 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11659 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11660 Adapt all references accordingly.
11662 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11664 2011-03-11 Tom Tromey <tromey@redhat.com>
11666 * buffer.c (syms_of_buffer): Remove obsolete comment.
11668 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11670 * termhooks.h (encode_terminal_code): Declare prototype.
11672 * msdos.c (encode_terminal_code): Don't declare prototype.
11674 * term.c (encode_terminal_code): Now external again, used by
11675 w32console.c and msdos.c.
11677 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11678 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11680 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11682 Fix some minor problems found by GCC 4.5.2's static checks.
11684 * fringe.c (update_window_fringes): Mark locals as initialized
11686 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11688 * alloc.c (mark_fringe_data): Move decl from here ...
11689 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11690 to check its interface.
11691 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11693 * fontset.c (free_realized_fontset): Now static.
11694 (Fset_fontset_font): Rename local to avoid shadowing.
11695 (fontset_font): Mark local as initialized.
11696 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11698 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11700 * xselect.c (x_disown_buffer_selections): Remove; not used.
11701 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11702 (x_own_selection, Fx_disown_selection_internal): Rename locals
11703 to avoid shadowing.
11704 (x_handle_dnd_message): Remove local to avoid shadowing.
11706 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11707 so that the caller can use some name other than gcpro1.
11708 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11709 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11710 (Fx_backspace_delete_keys_p):
11711 Use them to avoid shadowing, and rename vars to avoid shadowing.
11712 (x_decode_color, x_set_name, x_window): Now static.
11713 (Fx_create_frame): Add braces to silence GCC warning.
11714 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11715 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11716 Remove unused locals.
11717 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11718 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11719 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11722 * xterm.h (x_mouse_leave): New decl.
11724 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11725 Remove unused functions.
11726 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11727 (x_calc_absolute_position): Now static.
11728 (XTread_socket): Don't define label "out" unless it's used.
11729 Don't declare local "event" unless it's used.
11730 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11731 unless they are used.
11732 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11733 (x_fatal_error_signal): Remove; not used.
11734 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11735 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11736 (x_error_catcher, x_connection_closed, x_error_handler):
11737 (x_error_quitter, xembed_send_message, x_iconify_frame):
11738 (my_log_handler): Rename locals to avoid shadowing.
11739 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11740 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11742 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11743 Rename or move locals to avoid shadowing.
11744 (tty_defined_color, merge_face_heights): Now static.
11745 (free_realized_faces_for_fontset): Remove; not used.
11746 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11747 does not deduce is never used uninitialized.
11748 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11749 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11751 * terminal.c (store_terminal_param): Now static.
11753 * xmenu.c (menu_highlight_callback): Now static.
11754 (set_frame_menubar): Remove unused local.
11755 (xmenu_show): Rename parameter to avoid shadowing.
11756 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11757 since they might point to immutable storage.
11758 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11759 since it's unused otherwise.
11761 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11762 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11763 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11764 avoids a gcc -Wuninitialized diagnostic.
11765 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11766 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11767 does not deduce are never used uninitialized.
11769 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11771 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11772 * window.c (window_loop, size_window):
11773 (run_window_configuration_change_hook, enlarge_window): Likewise.
11775 * window.c (display_buffer): Now static.
11776 (size_window): Mark variables that gcc -Wuninitialized
11777 does not deduce are never used uninitialized.
11778 * window.h (check_all_windows): New decl, to forestall
11779 gcc -Wmissing-prototypes diagnostic.
11780 * dispextern.h (bidi_dump_cached_states): Likewise.
11782 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11784 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11785 Include <limits.h>.
11786 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11787 and to avoid gcc -Wuninitialized warning.
11788 (load_charset_map): Mark variables that gcc -Wuninitialized
11789 does not deduce are never used uninitialized.
11790 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11792 * coding.c (coding_set_source, coding_set_destination):
11793 Use "else { /* comment */ }" rather than "else /* comment */;"
11794 for clarity, and to avoid gcc -Wempty-body warning.
11795 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11796 a block, when the outer 'i' will do.
11797 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11798 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11799 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11800 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11801 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11802 Rename locals to avoid shadowing.
11803 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11804 * coding.c (emacs_mule_char, encode_invocation_designation):
11805 Now static, since they're not used elsewhere.
11806 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11807 (decode_coding_object, encode_coding_object, detect_coding_system):
11808 (decode_coding_emacs_mule): Mark variables that gcc
11809 -Wuninitialized does not deduce are never used uninitialized.
11810 (detect_coding_iso_2022): Initialize a local variable that might
11811 be used uninitialized. Leave a FIXME because it's not clear that
11812 this initialization is needed. (Bug#8211)
11813 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11814 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11815 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11816 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11817 Remove unused macros.
11819 * category.c (hash_get_category_set): Remove unused local var.
11820 (copy_category_table): Now static, since it's not used elsewhere.
11821 * character.c (string_count_byte8): Likewise.
11823 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11824 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11826 * chartab.c (copy_sub_char_table): Now static, since it's not used
11828 (sub_char_table_ref_and_range, char_table_ref_and_range):
11829 Rename locals to avoid shadowing.
11830 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11832 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11833 (BIDI_BOB): Remove unused macro.
11835 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11836 deduce are never used uninitialized.
11837 * term.c (encode_terminal_code): Likewise.
11839 * term.c (encode_terminal_code): Now static. Remove unused local.
11841 * tparam.h: New file.
11842 * term.c, tparam.h: Include it.
11843 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11844 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11845 Move these decls to tparam.h, and make them agree with what
11846 is actually in tparam.c. The previous trick of using incompatible
11847 decls in different modules does not conform to the C standard.
11848 All callers of tparam changed to use tparam's actual API.
11849 * tparam.c (tparam1, tparam, tgoto):
11850 Use const pointers where appropriate.
11852 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11853 * cm.h (struct cm): Likewise.
11854 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11855 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11856 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11857 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11858 (turn_on_face, init_tty): Likewise.
11859 * termchar.h (struct tty_display_info): Likewise.
11861 * term.c (term_mouse_position): Rename local to avoid shadowing.
11863 * alloc.c (mark_ttys): Move decl from here ...
11864 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11866 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11868 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11870 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11872 * search.c (compile_pattern_1): Remove argument regp, unused since
11873 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11874 (compile_pattern): Don't pass it.
11876 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11878 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11879 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11881 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11883 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11885 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11886 gdk_window_get_screen, gdk_window_get_geometry,
11887 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11888 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11889 (xg_get_pixbuf_from_pixmap): New function.
11890 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11891 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11892 Call xg_get_pixbuf_from_pixmap instead of
11893 gdk_pixbuf_get_from_drawable.
11894 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11895 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11896 (xg_check_special_colors): Use GtkStyleContext and its functions
11898 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11899 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11900 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11901 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11902 Call gtk_widget_get_preferred_size.
11903 (xg_frame_resized): gdk_window_get_geometry only takes 5
11905 (xg_win_to_widget, xg_event_is_for_menubar):
11906 Call gdk_x11_window_lookup_for_display.
11907 (xg_set_widget_bg): New function.
11908 (delete_cb): New function.
11909 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11910 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11911 (xg_set_background_color): Call xg_set_widget_bg.
11912 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11913 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11914 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11915 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11917 (update_frame_tool_bar): Call gtk_widget_hide.
11918 (xg_initialize): Use GDK_KEY_g.
11920 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11922 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11924 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11925 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11926 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11928 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11930 * w32xfns.c (select_palette): Check success of RealizePalette against
11931 GDI_ERROR, not zero.
11933 See ChangeLog.11 for earlier changes.
11935 ;; Local Variables:
11939 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11941 This file is part of GNU Emacs.
11943 GNU Emacs is free software: you can redistribute it and/or modify
11944 it under the terms of the GNU General Public License as published by
11945 the Free Software Foundation, either version 3 of the License, or
11946 (at your option) any later version.
11948 GNU Emacs is distributed in the hope that it will be useful,
11949 but WITHOUT ANY WARRANTY; without even the implied warranty of
11950 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11951 GNU General Public License for more details.
11953 You should have received a copy of the GNU General Public License
11954 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.