1 2011-07-07 Paul Eggert <eggert@cs.ucla.edu>
3 Assume freestanding C89 headers, string.h, stdlib.h.
4 * data.c, doprnt.c, floatfns.c, print.c:
5 Include float.h unconditionally.
6 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8 * regex.c: Likewise for stddef.h, string.h.
9 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
10 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
11 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
12 (STDC_HEADERS): Remove obsolete defines.
13 * sysdep.c: Include limits.h unconditionally.
15 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
17 Assume support for memcmp, memcpy, memmove, memset.
18 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
19 * regex.c (memcmp, memcpy):
20 Remove; we assume C89 now.
22 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
23 (__malloc_safe_bcopy): Remove; no longer needed.
25 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
26 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
27 well either way, and we prefer signed to unsigned.
29 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
31 Remove unportable assumption about struct layout (Bug#8884).
32 * alloc.c (mark_buffer):
33 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
34 (clone_per_buffer_values): Don't assume that
35 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
36 This isn't true in general, and it's particularly not true
37 if Emacs is configured with --with-wide-int.
38 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
39 New macros, used in the buffer.c change.
41 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
43 * xsettings.c: Use both GConf and GSettings if both are available.
44 (store_config_changed_event): Add comment.
45 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
46 (store_tool_bar_style_changed): New functions.
47 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
48 (struct xsettings): Move font inside HAVE_XFT.
49 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
50 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
52 (something_changed_gsettingsCB): Renamed from something_changedCB.
53 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
55 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
56 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
57 (something_changed_gconfCB): Renamed from something_changedCB.
58 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
59 (parse_settings): Move check for font inside HAVE_XFT.
60 (read_settings, apply_xft_settings): Add comment.
61 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
62 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
63 call store_font_name_changed.
64 (xft_settings_event): Add comment.
65 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
66 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
67 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
68 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
69 (xsettings_initialize): Call init_gsettings last.
70 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
73 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
75 Random fixes. E.g., (random) never returned negative values.
76 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
77 subseconds part to the entropy, as that's a bit more random.
78 Prefer signed to unsigned, since the signedness doesn't matter and
79 in general we prefer signed. When given a limit, use a
80 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
81 latter isn't right if USE_2_TAGS_FOR_INTS.
82 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
83 not 0..VALMASK. Don't discard "excess" bits that random () returns.
85 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
87 * textprop.c (text_property_stickiness):
88 Obey Vtext_property_default_nonsticky.
89 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
90 * w32fns.c (syms_of_w32fns):
91 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
93 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
95 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
96 This is more efficient than Ffile_directory_p and avoids a minor race.
98 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
100 * buffer.c (Foverlay_put): Say what the return value is
103 * fileio.c (barf_or_query_if_file_exists): Check first if the file
104 is a directory before asking whether to use the file name
106 (barf_or_query_if_file_exists): Make the "File is a directory"
107 error be more correct.
109 * fns.c (Frequire): Remove the mention of the .gz files, since
110 that's installation-specific, but keep the mention of
113 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
115 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
116 Report string overflow if the output is too long.
118 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
120 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
121 (syms_of_gnutls): Remove duplicate DEFSYM for
122 Qgnutls_bootprop_verify_hostname_error, an error for
123 Qgnutls_bootprop_verify_error (which is no longer used).
125 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
126 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
127 Also (re)move comments that are misplaced or no longer relevant.
129 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
131 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
133 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
135 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
136 and background color parameters if they have been changed.
138 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
140 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
142 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
144 * xsettings.c (SYSTEM_FONT): Define only when used.
145 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
147 * keymap.c (access_keymap_1): Now static.
149 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
151 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
152 leave any prefix arg for the up event (Bug#1586).
154 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
156 * lread.c (syms_of_lread): Mention single symbols defined by
157 `defvar' or `defconst' (bug#7154).
159 * fns.c (Frequire): Mention .el.gz files (bug#7314).
160 (Frequire): Mention get-load-suffixes.
162 2011-07-02 Martin Rudalics <rudalics@gmx.at>
164 * window.h (window): Remove clone_number slot.
165 * window.c (Fwindow_clone_number, Fset_window_clone_number):
167 (make_parent_window, make_window, saved_window)
168 (Fset_window_configuration, save_window_save): Don't deal with
170 * buffer.c (Qclone_number): Remove declaration.
171 (sort_overlays, overlay_strings): Don't deal with clone numbers.
173 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
175 Add multiple inheritance to keymaps.
176 * keymap.c (Fmake_composed_keymap): New function.
177 (Fset_keymap_parent): Simplify.
178 (fix_submap_inheritance): Remove.
179 (access_keymap_1): New function extracted from access_keymap to handle
180 embedded parents and handle lists of maps.
181 (access_keymap): Use it.
182 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
183 (Fcopy_keymap): Handle embedded parents.
184 (Fcommand_remapping, define_as_prefix): Simplify.
185 (Fkey_binding): Simplify.
186 (syms_of_keymap): Move minibuffer-local-completion-map,
187 minibuffer-local-filename-completion-map,
188 minibuffer-local-must-match-map, and
189 minibuffer-local-filename-must-match-map to Elisp.
190 (syms_of_keymap): Defsubr make-composed-keymap.
191 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
192 (parse_menu_item): Trivial simplification.
194 2011-07-01 Glenn Morris <rgm@gnu.org>
196 * Makefile.in (SETTINGS_LIBS): Fix typo.
198 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
200 * coding.c (Fencode_coding_string): Record the last coding system
201 used, as the function doc string says (bug#8738).
203 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
205 * xsettings.c (store_monospaced_changed): Take new font as arg and
206 check for change against current_mono_font.
207 (EMACS_TYPE_SETTINGS): Remove this and related defines.
208 (emacs_settings_constructor, emacs_settings_get_property)
209 (emacs_settings_set_property, emacs_settings_class_init)
210 (emacs_settings_init, gsettings_obj): Remove.
211 (something_changedCB): New function for HAVE_GSETTINGS.
212 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
213 with value as argument.
214 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
215 g_settings_new (Bug#8967). Do not create gsettings_obj.
216 Remove calls to g_settings_bind. Connect something_changedCB to
219 * xgselect.c: Add defined (HAVE_GSETTINGS).
220 (xgselect_initialize): Ditto.
222 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
223 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
226 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
228 * eval.c (struct backtrace): Simplify and port the data structure.
229 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
230 signed bit field, as this assumption is not portable and it makes
231 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
232 "char debug_on_exit : 1" as this is not portable either; instead,
233 use the portable "unsigned int debug_on_exit : 1". Remove unused
234 member evalargs. Remove obsolete comments about cc bombing out.
236 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
238 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
239 Let HAVE_GSETTINGS override HAVE_GCONF.
240 (store_monospaced_changed): New function.
241 (EMACS_SETTINGS): A new type derived from GObject to handle
242 GSettings notifications.
243 (emacs_settings_constructor, emacs_settings_get_property)
244 (emacs_settings_set_property, emacs_settings_class_init):
246 (gsettings_client, gsettings_obj): New variables.
247 (GSETTINGS_SCHEMA): New define.
248 (something_changedCB): Call store_monospaced_changed.
249 (init_gsettings): New function.
250 (xsettings_initialize): Call init_gsettings.
251 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
254 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
257 2011-06-29 Martin Rudalics <rudalics@gmx.at>
259 * window.c (resize_root_window, grow_mini_window)
260 (shrink_mini_window): Rename Qresize_root_window to
261 Qwindow_resize_root_window and Qresize_root_window_vertically to
262 Qwindow_resize_root_window_vertically.
264 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
266 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
268 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
270 * makefile.w32-in: Redesign dependencies so they reflect more
271 clearly which files are directly included by each source file,
272 and not through other includes.
274 2011-06-27 Martin Rudalics <rudalics@gmx.at>
276 * buffer.c (Qclone_number): Declare static and DEFSYM it.
277 (sort_overlays, overlay_strings): When an overlay's clone number
278 matches the window's clone number process the overlay even if
279 the overlay's window property doesn't match the current window.
281 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
282 (Fwindow_hchild): Rename to Fwindow_left_child.
283 (Fwindow_next): Rename to Fwindow_next_sibling.
284 (Fwindow_prev): Rename to Fwindow_prev_sibling.
285 (resize_window_check): Rename to window_resize_check.
286 (resize_window_apply): Rename to window_resize_apply.
287 (Fresize_window_apply): Rename to Fwindow_resize_apply.
288 (Fdelete_other_windows_internal, resize_frame_windows)
289 (Fsplit_window_internal, Fdelete_window_internal)
290 (grow_mini_window, shrink_mini_window)
291 (Fresize_mini_window_internal): Fix callers accordingly.
293 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
295 * emacsgtkfixed.h: State that this is only used with Gtk+3.
296 (emacs_fixed_set_min_size): Remove.
297 (emacs_fixed_new): Take frame as argument.
299 * emacsgtkfixed.c: State that this is only used with Gtk+3.
300 (_EmacsFixedPrivate): Remove minwidth/height.
302 (emacs_fixed_init): Initialize priv->f.
303 (get_parent_class, emacs_fixed_set_min_size): Remove.
304 (emacs_fixed_new): Set priv->f to argument.
305 (emacs_fixed_get_preferred_width)
306 (emacs_fixed_get_preferred_height): Use min_width/height from
307 frames size_hint to set minimum and natural (Bug#8919).
308 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
309 and use min_width/height from frames size_hint to set
310 min_width/height (Bug#8919).
312 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
313 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
316 2011-06-26 Eli Zaretskii <eliz@gnu.org>
318 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
319 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
322 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
324 * process.c (wait_reading_process_output): Bypass select if
325 waiting for a cell while ignoring keyboard input, and input is
326 pending. Suggested by Jan Djärv (Bug#8869).
328 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
330 Use gnulib's dup2 module instead of rolling our own.
331 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
333 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
335 * dispnew.c (scrolling_window): Before scrolling, turn off a
336 mouse-highlight in the window being scrolled.
338 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
340 Move DEFSYM to lisp.h and use everywhere.
342 * character.h (DEFSYM): Move declaration...
343 * lisp.h (DEFSYM): ...here.
349 * w32select.c: Don't include character.h.
351 * alloc.c (syms_of_alloc):
352 * buffer.c (syms_of_buffer):
353 * bytecode.c (syms_of_bytecode):
354 * callint.c (syms_of_callint):
355 * casefiddle.c (syms_of_casefiddle):
356 * casetab.c (init_casetab_once):
357 * category.c (init_category_once, syms_of_category):
358 * ccl.c (syms_of_ccl):
359 * cmds.c (syms_of_cmds):
360 * composite.c (syms_of_composite):
361 * dbusbind.c (syms_of_dbusbind):
362 * dired.c (syms_of_dired):
363 * dispnew.c (syms_of_display):
364 * doc.c (syms_of_doc):
365 * editfns.c (syms_of_editfns):
366 * emacs.c (syms_of_emacs):
367 * eval.c (syms_of_eval):
368 * fileio.c (syms_of_fileio):
369 * fns.c (syms_of_fns):
370 * frame.c (syms_of_frame):
371 * fringe.c (syms_of_fringe):
372 * insdel.c (syms_of_insdel):
373 * keymap.c (syms_of_keymap):
374 * lread.c (init_obarray, syms_of_lread):
375 * macros.c (syms_of_macros):
376 * msdos.c (syms_of_msdos):
377 * print.c (syms_of_print):
378 * process.c (syms_of_process):
379 * search.c (syms_of_search):
380 * sound.c (syms_of_sound):
381 * syntax.c (init_syntax_once, syms_of_syntax):
382 * terminal.c (syms_of_terminal):
383 * textprop.c (syms_of_textprop):
384 * undo.c (syms_of_undo):
385 * w32.c (globals_of_w32):
386 * window.c (syms_of_window):
387 * xdisp.c (syms_of_xdisp):
388 * xfaces.c (syms_of_xfaces):
389 * xfns.c (syms_of_xfns):
390 * xmenu.c (syms_of_xmenu):
391 * xsettings.c (syms_of_xsettings):
392 * xterm.c (syms_of_xterm): Use DEFSYM.
394 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
396 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
398 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
400 Integer and buffer overflow fixes (Bug#8873).
402 * print.c (printchar, strout): Check for string overflow.
403 (PRINTPREPARE, printchar, strout):
404 Don't set size unless allocation succeeds.
406 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
407 for sizes. Check for string overflow more accurately.
408 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
410 * macros.c: Integer and buffer overflow fixes.
411 * keyboard.h (struct keyboard.kbd_macro_bufsize):
412 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
413 Use ptrdiff_t, not int, for sizes.
414 Don't increment bufsize until after realloc succeeds.
415 Check for size-calculation overflow.
416 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
418 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
420 * lread.c: Integer overflow fixes.
421 (read_integer): Radix is now EMACS_INT, not int,
422 to improve quality of diagnostics for out-of-range radices.
423 Calculate buffer size correctly for out-of-range radices.
424 (read1): Check for integer overflow in radices, and in
426 (read_escape): Avoid int overflow.
427 (Fload, openp, read_buffer_size, read1)
428 (substitute_object_recurse, read_vector, read_list, map_obarray):
429 Use ptrdiff_t, not int, for sizes.
430 (read1): Use EMACS_INT, not int, for sizes.
431 Check for size overflow.
433 * image.c (cache_image): Check for size arithmetic overflow.
435 * lread.c: Integer overflow issues.
436 (saved_doc_string_size, saved_doc_string_length)
437 (prev_saved_doc_string_size, prev_saved_doc_string_length):
438 Now ptrdiff_t, not int.
439 (read1): Don't assume doc string length fits in int. Check for
440 out-of-range doc string lengths.
441 (read_list): Don't assume file position fits in int.
442 (read_escape): Check for hex character overflow.
444 2011-06-22 Leo Liu <sdl.web@gmail.com>
446 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
447 Move to minibuffer.el.
449 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
451 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
452 The following patches are for when GLYPH_DEBUG && !XASSERT.
453 * dispextern.h (trace_redisplay_p, dump_glyph_string):
454 * dispnew.c (flush_stdout):
455 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
456 Mark as externally visible.
457 * dispnew.c (check_window_matrix_pointers): Now static.
458 * dispnew.c (window_to_frame_vpos):
459 * xfns.c (unwind_create_frame):
460 * xterm.c (x_check_font): Remove unused local.
461 * scroll.c (CHECK_BOUNDS):
462 * xfaces.c (cache_fache): Rename local to avoid shadowing.
463 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
464 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
465 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
466 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
468 (debug_method_add): Use va_list and vsprintf rather than relying
469 on undefined behavior with wrong number of arguments.
470 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
471 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
472 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
473 since we're not interested in debugging glyphs with old libraries.
474 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
475 GCC 4.6.0's static checking.
477 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
479 Integer overflow and signedness fixes (Bug#8873).
480 A few related buffer overrun fixes, too.
482 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
484 * dispextern.h (struct face.stipple):
485 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
486 (x_bitmap_mask, x_allocate_bitmap_record)
487 (x_create_bitmap_from_data, x_create_bitmap_from_file)
488 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
489 (x_create_bitmap_from_xpm_data):
490 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
491 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
493 * xfaces.c (load_pixmap):
494 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
495 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
496 (.bitmaps_last, struct x_output.icon_bitmap):
497 Use ptrdiff_t, not int, for bitmap indexes.
498 (x_allocate_bitmap_record): Check for size overflow.
499 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
501 Use ptrdiff_t, not int, for overlay counts.
502 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
503 * editfns.c (overlays_around, get_pos_property):
504 * textprop.c (get_char_property_and_overlay):
505 * xdisp.c (next_overlay_change, note_mouse_highlight):
506 * xfaces.c (face_at_buffer_position):
507 * buffer.c (OVERLAY_COUNT_MAX): New macro.
508 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
509 (Fnext_overlay_change, Fprevious_overlay_change)
510 (mouse_face_overlay_overlaps, Foverlays_in):
511 Use ptrdiff_t, not int, for sizes.
512 (overlays_at, overlays_in): Check for size-calculation overflow.
514 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
516 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
517 (x_session_initialize): Do not assume string length fits in int.
519 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
520 This is unlikely, but can occur if DPI is outlandish.
522 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
523 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
525 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
526 * xrdb.c (magic_file_p, search_magic_path):
527 Omit last arg SUFFIX; it was always 0. All callers changed.
528 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
530 * xfont.c (xfont_match): Avoid need for strlen.
532 * xfns.c: Don't assume strlen fits in int.
533 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
535 * xdisp.c (message_log_check_duplicate): Return intmax_t,
536 not unsigned long, as we prefer signed integers. All callers changed.
537 Detect integer overflow in repeat count.
538 (message_dolog): Don't assume print length fits in 39 bytes.
539 (display_mode_element): Don't assume strlen fits in int.
541 * termcap.c: Don't assume sizes fit in int and never overflow.
542 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
543 (gobble_line): Check for size-calculation overflow.
545 * minibuf.c (Fread_buffer):
546 * lread.c (intern, intern_c_string):
547 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
548 Don't assume string length fits in int.
550 * keyboard.c (parse_tool_bar_item):
551 * gtkutil.c (style_changed_cb): Avoid need for strlen.
553 * font.c: Don't assume string length fits in int.
554 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
555 Use ptrdiff_t, not int.
556 (font_intern_prop): Don't assume string length fits in int.
557 Don't assume integer property fits in fixnum.
558 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
560 * filelock.c: Fix some buffer overrun and integer overflow issues.
561 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
562 Reformulate so as not to need the command string.
563 Invoke gzip -cd rather than gunzip, as it's more portable.
564 (lock_info_type, lock_file_1, lock_file):
565 Don't assume pid_t and time_t fit in unsigned long.
566 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
567 (current_lock_owner): Prefer signed type for sizes.
568 Use memcpy, not strncpy, where memcpy is what is really wanted.
569 Don't assume (via atoi) that time_t and pid_t fit in int.
570 Check for time_t and/or pid_t out of range, e.g., via a network share.
571 Don't alloca where an auto var works fine.
573 * fileio.c: Fix some integer overflow issues.
574 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
575 Don't assume string length fits in int.
576 (directory_file_name): Don't assume string length fits in long.
577 (make_temp_name): Don't assume pid fits in int, or that its print
578 length is less than 20.
580 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
582 * coding.c (make_subsidiaries): Don't assume string length fits in int.
584 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
586 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
587 We prefer signed integers, even for size calculations.
589 * emacs.c: Don't assume string length fits in 'int'.
590 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
591 (main): Don't invoke strlen when not needed.
593 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
594 (XD_DEBUG_MESSAGE): Don't waste a byte.
596 * callproc.c (getenv_internal_1, getenv_internal)
598 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
600 * lread.c (invalid_syntax): Omit length argument.
601 All uses changed. This doesn't fix a bug, but it simplifies the
602 code away from its former Hollerith-constant appearance, and it's
603 one less 'int' to worry about when looking at integer-overflow issues.
604 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
606 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
607 This didn't break anything, but it didn't help either.
608 It's confusing to put a bogus integer in a place where the actual
609 value does not matter.
610 (LIST_END_P): Remove unused macro and its bogus comment.
611 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
613 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
614 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
616 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
617 We prefer signed types, and the value cannot exceed the EMACS_INT
618 range anyway (because otherwise the length would not be representable).
619 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
620 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
621 This avoids a GCC warning when WIDE_EMACS_INT.
623 * indent.c (sane_tab_width): New function.
624 (current_column, scan_for_column, Findent_to, position_indentation)
625 (compute_motion): Use it. This is just for clarity.
626 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
628 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
630 * lisp.h (lint_assume): New macro.
631 * composite.c (composition_gstring_put_cache):
632 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
634 * editfns.c, insdel.c:
635 Omit unnecessary forward decls, to simplify future changes.
637 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
639 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
641 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
642 Use much-faster test for byte-length change.
643 Don't assume string byte-length fits in 'int'.
644 Check that character arg fits in 'int'.
645 (mapcar1): Declare byte as byte, for clarity.
647 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
649 * fns.c (concat): Catch string overflow earlier.
650 Do not rely on integer wraparound.
652 * dispextern.h (struct it.overlay_strings_charpos)
653 (struct it.selective): Now EMACS_INT, not int.
654 * xdisp.c (forward_to_next_line_start)
655 (back_to_previous_visible_line_start)
656 (reseat_at_next_visible_line_start, next_element_from_buffer):
657 Don't arbitrarily truncate the value of 'selective' to int.
659 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
661 * composite.c: Don't truncate sizes to 'int'.
662 (composition_gstring_p, composition_reseat_it)
663 (composition_adjust_point): Use EMACS_INT, not int.
664 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
665 not EMACS_UINT, for indexes.
667 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
669 * buffer.c: Include <verify.h>.
670 (struct sortvec.priority, struct sortstr.priority):
671 Now EMACS_INT, not int.
672 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
673 (struct sortstr.size, record_overlay_string)
674 (struct sortstrlist.size, struct sortlist.used):
675 Don't truncate size to int.
676 (record_overlay_string): Check for size-calculation overflow.
677 (init_buffer_once): Check at compile-time, not run-time.
679 2011-06-22 Jim Meyering <meyering@redhat.com>
681 Don't leak an XBM-image-sized buffer
682 * image.c (xbm_load): Free the image buffer after using it.
684 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
687 * composite.c (find_automatic_composition): Omit needless 'return 0;'
688 that Sun C diagnosed.
689 * fns.c (secure_hash): Fix pointer signedness issue.
690 * intervals.c (static_offset_intervals): New function.
691 (offset_intervals): Use it.
693 2011-06-21 Leo Liu <sdl.web@gmail.com>
696 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
699 * fns.c (secure_hash): Rename from crypto_hash_function and change
700 the first arg to accept symbols.
701 (Fsecure_hash): New primitive.
702 (syms_of_fns): New symbols.
704 2011-06-20 Deniz Dogan <deniz@dogan.se>
706 * process.c (Fset_process_buffer): Clarify return value in
709 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
711 * dispnew.c (add_window_display_history): Use BVAR.
713 * xdisp.c (debug_method_add): Use BVAR.
714 (check_window_end, dump_glyph_matrix, dump_glyph)
715 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
717 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
720 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
721 check till after the cache is created in init_frame_faces.
723 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
725 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
727 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
729 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
730 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
731 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
733 Improve buffer-overflow checking (Bug#8873).
734 * fileio.c (Finsert_file_contents):
735 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
736 Remove the old (too-loose) buffer overflow checks.
737 They weren't needed, since make_gap checks for buffer overflow.
738 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
739 The old code merely checked for Emacs fixnum overflow, and relied
740 on undefined (wraparound) behavior. The new code avoids undefined
741 behavior, and also checks for ptrdiff_t and/or size_t overflow.
743 * editfns.c (Finsert_char): Don't dump core with very negative counts.
744 Tune. Don't use wider integers than needed. Don't use alloca.
745 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
747 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
749 * insdel.c, lisp.h (buffer_overflow): New function.
750 (insert_from_buffer_1, replace_range, replace_range_2):
751 * insdel.c (make_gap_larger):
752 * editfns.c (Finsert_char):
753 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
755 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
757 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
759 Integer overflow and signedness fixes (Bug#8873).
761 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
762 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
764 * fileio.c: Don't assume EMACS_INT fits in off_t.
765 (emacs_lseek): New static function.
766 (Finsert_file_contents, Fwrite_region): Use it.
767 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
769 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
771 * fns.c: Don't overflow int when computing a list length.
772 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
773 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
774 truncation on 64-bit hosts. Check for QUIT every
775 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
776 faster and is responsive enough.
777 (Flength): Report an error instead of overflowing an integer.
778 (Fsafe_length): Return a float if the value is not representable
779 as a fixnum. This shouldn't happen except in contrived situations.
780 (Fnthcdr, Fsort): Don't assume list length fits in int.
781 (Fcopy_sequence): Don't assume vector length fits in int.
783 * alloc.c: Check that resized vectors' lengths fit in fixnums.
784 (header_size, word_size): New constants.
785 (allocate_vectorlike): Don't check size overflow here.
786 (allocate_vector): Check it here instead, since this is the only
787 caller of allocate_vectorlike that could cause overflow.
788 Check that the new vector's length is representable as a fixnum.
790 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
791 The previous code was bogus. For example, next_almost_prime (32)
792 returned 39, which is undesirable as it is a multiple of 3; and
793 next_almost_prime (24) returned 25, which is a multiple of 5 so
794 why was the code bothering to check for multiples of 7?
796 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
798 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
800 Variadic C functions now count arguments with ptrdiff_t.
801 This partly undoes my 2011-03-30 change, which replaced int with size_t.
802 Back then I didn't know that the Emacs coding style prefers signed int.
803 Also, in the meantime I found a few more instances where arguments
804 were being counted with int, which may truncate counts on 64-bit
805 machines, or EMACS_INT, which may be unnecessarily wide.
806 * lisp.h (struct Lisp_Subr.function.aMANY)
807 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
808 Arg counts are now ptrdiff_t, not size_t.
809 All variadic functions and their callers changed accordingly.
810 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
811 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
812 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
813 * callint.c (Fcall_interactively): Check arg count for overflow,
814 to avoid potential buffer overrun. Use signed char, not 'int',
815 for 'varies' array, so that we needn't bother to check its size
816 calculation for overflow.
817 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
818 * eval.c (apply_lambda):
819 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
820 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
821 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
823 * callint.c (Fcall_interactively): Don't use index var as event count.
825 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
826 * mem-limits.h (SIZE): Remove; no longer used.
828 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
830 Remove unnecessary casts.
831 * xterm.c (x_term_init):
832 * xfns.c (x_set_border_pixel):
833 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
834 These aren't needed now that we assume ANSI C.
836 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
837 It's more likely to cause problems (due to unsigned overflow)
840 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
842 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
844 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
846 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
848 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
850 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
852 GLYPH_CODE_FACE returns EMACS_INT, not int.
853 * dispextern.h (merge_faces):
854 * xfaces.c (merge_faces):
855 * xdisp.c (get_next_display_element, next_element_from_display_vector):
856 Don't assume EMACS_INT fits in int.
858 * character.h (CHAR_VALID_P): Remove unused parameter.
859 * fontset.c, lisp.h, xdisp.c: All uses changed.
861 * editfns.c (Ftranslate_region_internal): Omit redundant test.
863 * fns.c (concat): Minor tuning based on overflow analysis.
864 This doesn't fix any bugs. Use int to hold character, instead
865 of constantly refetching from Emacs object. Use XFASTINT, not
866 XINT, for value known to be a character. Don't bother comparing
867 a single byte to 0400, as it's always less.
869 * floatfns.c (Fexpt):
870 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
872 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
875 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
877 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
878 Without this fix, on a 64-bit host (aset S 0 4294967386) would
879 incorrectly succeed when S was a string, because 4294967386 was
880 truncated before it was used.
882 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
883 Otherwise, an out-of-range integer could cause undefined behavior
886 * composite.c: Use int, not EMACS_INT, for characters.
887 (fill_gstring_body, composition_compute_stop_pos): Use int, not
888 EMACS_INT, for values that are known to be in character range.
889 This doesn't fix any bugs but is the usual style inside Emacs and
890 may generate better code on 32-bit machines.
892 Make sure a 64-bit char is never passed to ENCODE_CHAR.
893 This is for reasons similar to the recent CHAR_STRING fix.
894 * charset.c (Fencode_char): Check that character arg is actually
895 a character. Pass an int to ENCODE_CHAR.
896 * charset.h (ENCODE_CHAR): Verify that the character argument is no
897 wider than 'int', as a compile-time check to prevent future regressions
900 * character.c (char_string): Remove unnecessary casts.
902 Make sure a 64-bit char is never passed to CHAR_STRING.
903 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
904 by silently ignoring the top 32 bits, allowing some values
905 that were far too large to be valid characters.
906 * character.h: Include <verify.h>.
907 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
908 arguments are no wider than unsigned, as a compile-time check
909 to prevent future regressions in this area.
911 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
912 (Fsubst_char_in_region):
914 * xdisp.c (decode_mode_spec_coding):
915 Adjust to CHAR_STRING's new requirement.
916 * editfns.c (Finsert_char, Fsubst_char_in_region):
917 * fns.c (concat): Check that character args are actually
918 characters. Without this test, these functions did the wrong
919 thing with wildly out-of-range values on 64-bit hosts.
921 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
922 These casts should not be needed on 32-bit hosts, either.
923 * keyboard.c (read_char):
924 * lread.c (Fload): Remove casts to unsigned.
926 * lisp.h (UNSIGNED_CMP): New macro.
927 This fixes comparison bugs on 64-bit hosts.
928 (ASCII_CHAR_P): Use it.
929 * casefiddle.c (casify_object):
930 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
931 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
932 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
933 * dispextern.h (FACE_FROM_ID):
934 * keyboard.c (read_char): Use UNSIGNED_CMP.
936 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
937 not to EMACS_INT, to avoid GCC warning.
939 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
941 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
942 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
943 isn't needed on 32-bit machines.
945 * buffer.c (Fgenerate_new_buffer_name):
946 Use EMACS_INT for count, not int.
947 (advance_to_char_boundary): Return EMACS_INT, not int.
949 * data.c (Qcompiled_function): Now static.
951 * window.c (window_body_lines): Now static.
953 * image.c (gif_load): Rename local to avoid shadowing.
955 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
956 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
957 * alloc.c (make_save_value): Integer argument is now of type
959 (mark_object): Use ptrdiff_t, not int.
960 * lisp.h (pD): New macro.
961 * print.c (print_object): Use it.
963 * alloc.c: Use EMACS_INT, not int, to count objects.
964 (total_conses, total_markers, total_symbols, total_vector_size)
965 (total_free_conses, total_free_markers, total_free_symbols)
966 (total_free_floats, total_floats, total_free_intervals)
967 (total_intervals, total_strings, total_free_strings):
968 Now EMACS_INT, not int. All uses changed.
969 (Fgarbage_collect): Compute overall total using a double, so that
970 integer overflow is less likely to be a problem. Check for overflow
971 when converting back to an integer.
972 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
973 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
974 These were 'int' variables that could overflow on 64-bit hosts;
975 they were never used, so remove them instead of repairing them.
976 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
977 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
978 Previously, this ceilinged at INT_MAX, but that doesn't work on
980 (allocate_pseudovector): Don't use EMACS_INT when int would do.
982 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
983 (allocate_vectorlike): Check for ptrdiff_t overflow.
984 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
985 when a (possibly-narrower) signed value would do just as well.
986 We prefer using signed arithmetic, to avoid comparison confusion.
988 * alloc.c: Catch some string size overflows that we were missing.
989 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
990 for convenience in STRING_BYTES_MAX.
991 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
992 The definition here is exact; the one in lisp.h was approximate.
993 (allocate_string_data): Check for string overflow. This catches
994 some instances we weren't catching before. Also, it catches
995 size_t overflow on (unusual) hosts where SIZE_MAX <= min
996 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
997 and ptrdiff_t and EMACS_INT are both 64 bits.
999 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1000 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1001 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1003 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1005 * alloc.c (Fmake_string): Check for out-of-range init.
1007 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1009 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1011 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1013 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1014 xg_get_default_scrollbar_width.
1016 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1017 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1018 (style_changed_cb): Call update_theme_scrollbar_width and call
1019 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1020 all frames (Bug#8505).
1021 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1022 Call gtk_window_set_resizable if HAVE_GTK3.
1023 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1024 and height if HAVE_GTK3 (Bug#8505).
1025 (scroll_bar_width_for_theme): New variable.
1026 (update_theme_scrollbar_width): New function.
1027 (xg_get_default_scrollbar_width): Move code to
1028 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1029 (xg_initialize): Call update_theme_scrollbar_width.
1031 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1033 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1035 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1037 * frame.c (make_frame): Call other_buffer_safely instead of
1040 * window.c (temp_output_buffer_show): Call display_buffer with
1041 second argument Vtemp_buffer_show_specifiers and reset latter
1042 immediately after the call.
1043 (Vtemp_buffer_show_specifiers): New variable.
1044 (auto_window_vscroll_p, next_screen_context_lines)
1045 (Vscroll_preserve_screen_position): Remove leading asterisks from
1048 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1050 Fix minor problems found by GCC 4.6.0 static checking.
1051 * buffer.c (Qclone_number): Remove for now, as it's unused.
1052 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1053 (record_buffer): Remove unused local.
1054 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1055 (set_frame_buffer_list): Remove; unused.
1056 * frame.h (other_visible_frames): Remove decl.
1057 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1058 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1059 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1061 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1062 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1063 Define only if HAVE_GPM.
1064 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1065 (update_hints_inhibit): Remove; never set. All uses removed.
1066 * widgetprv.h (emacsFrameClassRec): Remove decl.
1067 * window.c (delete_deletable_window): Now returns void, since it
1068 wasn't returning anything.
1069 (compare_window_configurations): Remove unused locals.
1070 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1071 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1072 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1073 the same widths as pointers. This follows up on the 2011-05-06 patch.
1074 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1075 * xterm.h: Likewise.
1076 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1078 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1080 * makefile.w32-in: Update dependencies.
1081 (LISP_H): Add lib/intprops.h.
1083 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1085 * image.c (gif_load): Add animation frame delay to the metadata.
1086 (syms_of_image): Use DEFSYM. New symbol `delay'.
1088 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1090 * window.c (delete_deletable_window): Re-add.
1091 (Fset_window_configuration): Rewrite to handle dead buffers and
1092 consequently deletable windows.
1093 (window_tree, Fwindow_tree): Remove. Supply functionality in
1095 (compare_window_configurations): Simplify code.
1097 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1099 * image.c (imagemagick_load_image): Fix type mismatch.
1100 (Fimagemagick_types): Likewise.
1102 * window.h (replace_buffer_in_windows): Declare.
1104 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1106 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1107 Qclone_number. Remove external declaration of Qdelete_window.
1108 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1110 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1111 Qbuffer_list_update_hook if allowed.
1112 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1113 buffer list implementation.
1114 (other_buffer_safely): New function.
1115 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1116 calls to replace_buffer_in_windows and
1117 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1119 (record_buffer): Inhibit quitting and rewrite using quittable
1120 functions. Run Qbuffer_list_update_hook if allowed.
1121 (Frecord_buffer, Funrecord_buffer): New functions.
1122 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1123 switch-to-buffer to window.el.
1124 (bury-buffer): Move to window.el.
1125 (Vbuffer_list_update_hook): New variable.
1127 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1130 * window.h (resize_frame_windows): Move up in code.
1131 (Fwindow_frame): Remove EXFUN.
1132 (replace_buffer_in_all_windows): Remove prototype.
1133 (replace_buffer_in_windows_safely): Add prototype.
1135 * window.c: Declare Qdelete_window static again. Move down
1136 declaration of select_count.
1137 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1138 (Fother_window): Move to window.el.
1139 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1140 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1141 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1143 (replace_buffer_in_windows): Implement by calling
1144 Qreplace_buffer_in_windows.
1145 (replace_buffer_in_all_windows): Remove with some functionality
1146 moved into replace_buffer_in_windows_safely.
1147 (replace_buffer_in_windows_safely): New function.
1148 (select_window_norecord, select_frame_norecord): Move in front
1149 of run_window_configuration_change_hook. Remove now obsolete
1151 (Fset_window_buffer): Rewrite doc-string. Call
1152 Qrecord_window_buffer.
1153 (keys_of_window): Move binding for other-window to window.el.
1155 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1157 * dispextern.h (struct image): Replace data member, whose int_val
1158 and ptr_val fields were not used by anything, with a single
1161 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1162 (gif_clear_image, gif_load, imagemagick_load_image)
1163 (gs_clear_image, gs_load): Callers changed.
1165 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1167 * buffer.h: Include <time.h>, for time_t.
1168 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1170 Fix minor problems found by static checking.
1172 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1174 Make identifiers static if they are not used in other modules.
1175 * data.c (Qcompiled_function, Qframe, Qvector):
1176 * image.c (QimageMagick, Qsvg):
1177 * minibuf.c (Qmetadata):
1178 * window.c (resize_window_check, resize_root_window): Now static.
1179 * window.h (resize_window_check, resize_root_window): Remove decls.
1181 * window.c (window_deletion_count, delete_deletable_window):
1183 (window_body_lines): Now static.
1184 (Fdelete_other_windows_internal): Mark vars as initialized.
1185 Make sure 'resize_failed' is initialized.
1186 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1187 (resize_window_apply): Remove unused local.
1188 * window.h (delete_deletable_window): Remove decl.
1190 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1191 (imagemagick_load_image): Fix pointer signedness problem by changing
1192 last arg from unsigned char * to char *. All uses changed.
1193 Also, fix a local for similar reasons.
1194 Remove unused locals. Remove locals to avoid shadowing.
1195 (fn_rsvg_handle_free): Remove; unused.
1196 (svg_load, svg_load_image): Fix pointer signedness problem.
1197 (imagemagick_load_image): Don't use garbage pointer image_wand.
1199 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1201 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1203 * image.c (gif_load): Fix omitted cast error introduced by
1206 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1208 * window.h (resize_proportionally, orig_total_lines)
1209 (orig_top_line): Remove from window structure.
1210 (set_window_height, set_window_width, change_window_heights)
1211 (Fdelete_window): Remove prototypes.
1212 (resize_frame_windows): Remove duplicate declaration.
1214 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1216 * window.h (resize_frame_windows, resize_window_check)
1217 (delete_deletable_window, resize_root_window)
1218 (resize_frame_windows): Declare prototypes.
1220 * window.c (resize_window_apply): Make definition be "static" to
1221 match the prototype.
1223 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1225 * window.c: Remove declarations of Qwindow_size_fixed,
1226 window_min_size_1, window_min_size_2, window_min_size,
1227 size_window, window_fixed_size_p, enlarge_window, delete_window.
1228 Remove static from declaration of Qdelete_window, it's
1229 temporarily needed by Fbury_buffer.
1230 (replace_window): Don't assign orig_top_line and
1232 (Fdelete_window, delete_window): Remove. Window deletion is
1233 handled by window.el.
1234 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1235 Fdelete_window calls with calls to Qdelete_window.
1236 (Fdelete_other_windows): Remove. Deleting other windows is
1237 handled by window.el.
1238 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1239 handled in window.el.
1240 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1241 Window minimum sizes are handled in window.el.
1242 (shrink_windows, size_window, set_window_height)
1243 (set_window_width, change_window_heights, window_height)
1244 (window_width, CURBEG, CURSIZE, enlarge_window)
1245 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1246 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1247 handled in window.el.
1248 (make_dummy_parent): Rename to make_parent_window and give it a
1249 second argument horflag.
1250 (make_window): Don't set resize_proportionally any more.
1251 (Fsplit_window): Remove. Windows are split in window.el.
1252 (save_restore_action, save_restore_orig_size)
1253 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1254 Resize mini windows in window.el.
1255 (grow_mini_window, shrink_mini_window): Implement by calling
1256 Qresize_root_window_vertically, resize_window_check and
1257 resize_window_apply.
1258 (saved_window, Fset_window_configuration, save_window_save): Do
1259 not handle orig_top_line, orig_total_lines, and
1260 resize_proportionally.
1261 (window_min_height, window_min_width): Move to window.el.
1262 (keys_of_window): Move bindings for delete-other-windows,
1263 split-window, delete-window and enlarge-window to window.el.
1265 * buffer.c: Temporarily extern Qdelete_window.
1266 (Fbury_buffer): Temporarily call Qdelete_window instead of
1267 Fdelete_window (Fbury_buffer will move to window.el soon).
1269 * frame.c (set_menu_bar_lines_1): Remove code handling
1270 orig_top_line and orig_total_lines.
1272 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1273 set_window_height but set heights directly.
1274 (change_frame_size_1): Use resize_frame_windows.
1276 * xdisp.c (init_xdisp): Don't use set_window_height but set
1279 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1280 resize_frame_windows instead of change_window_heights and run
1281 run_window_configuration_change_hook.
1283 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1284 instead of change_window_heights and run
1285 run_window_configuration_change_hook.
1287 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1289 * window.c (replace_window): Rename second argument REPLACEMENT to
1290 NEW. New third argument SETFLAG. Rewrite.
1291 (delete_window, make_dummy_parent): Call replace_window with
1293 (window_list_1): Move down in code.
1294 (run_window_configuration_change_hook): Move set_buffer part
1295 before select_frame_norecord part in order to unwind correctly.
1296 Rename count1 to count.
1297 (recombine_windows, delete_deletable_window, resize_root_window)
1298 (Fdelete_other_windows_internal)
1299 (Frun_window_configuration_change_hook, make_parent_window)
1300 (resize_window_check, resize_window_apply, Fresize_window_apply)
1301 (resize_frame_windows, Fsplit_window_internal)
1302 (Fdelete_window_internal, Fresize_mini_window_internal): New
1304 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1306 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1308 * window.h (window): Add some new members to window structure -
1309 normal_lines, normal_cols, new_total, new_normal, clone_number,
1310 splits, nest, prev_buffers, next_buffers.
1311 (WINDOW_TOTAL_SIZE): Move here from window.c.
1312 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1314 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1316 (make_dummy_parent): Set new members of windows structure.
1317 (make_window): Move down in code. Handle new members of window
1319 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1320 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1321 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1322 (Fset_window_prev_buffers, Fwindow_next_buffers)
1323 (Fset_window_next_buffers, Fset_window_clone_number): New
1325 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1326 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1328 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1329 Argument WINDOW can be now internal window too.
1330 (Fwindow_use_time): Move up in code.
1331 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1333 (Fset_window_configuration, saved_window)
1334 (Fcurrent_window_configuration, save_window_save): Handle new
1335 members of window structure.
1336 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1337 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1338 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1339 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1340 Qget_mru_window, Qresize_root_window,
1341 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1342 Qauto_buffer_name; staticpro them.
1344 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1346 * window.c (Fwindow_total_size, Fwindow_left_column)
1347 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1348 (Fwindow_list_1): New functions.
1349 (window_box_text_cols): Replace with window_body_cols.
1350 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1351 window_body_cols instead of window_box_text_cols.
1352 (delete_window, Fset_window_configuration): Call
1353 delete_all_subwindows with window as argument.
1354 (delete_all_subwindows): Take a window as argument and not a
1356 (window_loop): Remove handling of GET_LRU_WINDOW and
1358 (Fget_lru_window, Fget_largest_window): Move to window.el.
1360 * window.h: Extern window_body_cols instead of
1361 window_box_text_cols. delete_all_subwindows now takes a
1362 Lisp_Object as argument.
1364 * indent.c (compute_motion, Fcompute_motion): Use
1365 window_body_cols instead of window_box_text_cols.
1367 * frame.c (delete_frame): Call delete_all_subwindows with root
1370 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1372 * fns.c (Fputhash): Document return value.
1374 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1376 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1378 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1380 Cons<->int and similar integer overflow fixes (Bug#8794).
1382 Check for overflow when converting integer to cons and back.
1383 * charset.c (Fdefine_charset_internal, Fdecode_char):
1384 Use cons_to_unsigned to catch overflow.
1385 (Fencode_char): Use INTEGER_TO_CONS.
1386 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1387 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1388 * data.c (long_to_cons, cons_to_long): Remove.
1389 (cons_to_unsigned, cons_to_signed): New functions.
1390 These signal an error for invalid or out-of-range values.
1391 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1392 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1393 * font.c (Ffont_variation_glyphs):
1394 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1395 * lisp.h: Include <intprops.h>.
1396 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1397 (cons_to_signed, cons_to_unsigned): New decls.
1398 (long_to_cons, cons_to_long): Remove decls.
1399 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1400 (Fprimitive_undo): Use CONS_TO_INTEGER.
1401 * xfns.c (Fx_window_property): Likewise.
1402 * xselect.c: Include <limits.h>.
1403 (x_own_selection, selection_data_to_lisp_data):
1404 Use INTEGER_TO_CONS.
1405 (x_handle_selection_request, x_handle_selection_clear)
1406 (x_get_foreign_selection, Fx_disown_selection_internal)
1407 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1408 (lisp_data_to_selection_data): Use cons_to_unsigned.
1409 (x_fill_property_data): Use cons_to_signed.
1410 Report values out of range.
1412 Check for buffer and string overflow more precisely.
1413 * buffer.h (BUF_BYTES_MAX): New macro.
1414 * lisp.h (STRING_BYTES_MAX): New macro.
1415 * alloc.c (Fmake_string):
1416 * character.c (string_escape_byte8):
1417 * coding.c (coding_alloc_by_realloc):
1418 * doprnt.c (doprnt):
1419 * editfns.c (Fformat):
1421 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1422 since they may not be the same number.
1423 * editfns.c (Finsert_char):
1424 * fileio.c (Finsert_file_contents):
1425 Likewise for BUF_BYTES_MAX.
1427 * image.c: Use ptrdiff_t, not int, for sizes.
1428 (slurp_file): Switch from int to ptrdiff_t.
1430 (slurp_file): Check that file size fits in both size_t (for
1431 malloc) and ptrdiff_t (for sanity and safety).
1433 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1434 if b->modtime has its maximal value.
1436 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1438 Don't assume time_t can fit into int.
1439 * buffer.h (struct buffer.modtime): Now time_t, not int.
1440 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1441 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1443 Minor fixes for signed vs unsigned integers.
1444 * character.h (MAYBE_UNIFY_CHAR):
1445 * charset.c (maybe_unify_char):
1446 * keyboard.c (read_char, reorder_modifiers):
1447 XINT -> XFASTINT, since the integer must be nonnegative.
1448 * ftfont.c (ftfont_spec_pattern):
1449 * keymap.c (access_keymap, silly_event_symbol_error):
1450 XUINT -> XFASTINT, since the integer must be nonnegative.
1451 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1452 since it makes no difference and we prefer signed.
1453 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1454 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1457 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1459 * window.h (Fwindow_frame): Declare.
1461 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1463 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1464 (SPARE_MEMORY): Always define.
1465 (LARGE_REQUEST): Remove.
1466 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1468 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1470 * lisp.h: Move EXFUNS for Fframe_root_window,
1471 Fframe_first_window and Fset_frame_selected_window to window.h.
1473 * window.h: Move EXFUNS for Fframe_root_window,
1474 Fframe_first_window and Fset_frame_selected_window here from
1477 * frame.c (Fwindow_frame, Fframe_first_window)
1478 (Fframe_root_window, Fframe_selected_window)
1479 (Fset_frame_selected_window): Move to window.c.
1480 (Factive_minibuffer_window): Move to minibuf.c.
1481 (Fother_visible_frames_p): New function.
1483 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1485 * window.c (decode_window, decode_any_window): Move up in code.
1486 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1487 (inhibit_frame_unsplittable): Remove unused variable.
1488 (Fwindow_buffer): Move up and rewrite doc-string.
1489 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1490 (Fwindow_prev): New functions.
1491 (Fwindow_frame): Move here from frame.c. Accept any window as
1493 (Fframe_root_window, Fframe_first_window)
1494 (Fframe_selected_window): Move here from frame.c. Accept frame
1495 or arbitrary window as argument. Update doc-strings.
1496 (Fminibuffer_window): Move up in code.
1497 (Fwindow_minibuffer_p): Move up in code and simplify.
1498 (Fset_frame_selected_window): Move here from frame.c.
1500 (Fselected_window, select_window, Fselect_window): Move up in
1501 code. Minor doc-string fixes.
1503 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1505 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1506 Do not assume that spare memory exists; that assumption is valid
1507 only if SYSTEM_MALLOC.
1508 (LARGE_REQUEST): New macro, so that the issue of large requests
1509 is separated from the issue of spare memory.
1511 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1513 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1516 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1518 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1521 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1523 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1525 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1527 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1528 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1530 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1532 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1534 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1536 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1537 (x_clipboard_manager_save): Add return value.
1538 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1540 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1541 Obey Vx_select_enable_clipboard_manager. Catch errors in
1542 x_clipboard_manager_save (Bug#8779).
1543 (Vx_select_enable_clipboard_manager): New variable.
1544 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1546 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1548 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1550 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1552 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1553 in the current matrix if keep_current_p is non-zero.
1555 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1557 * bidi.c (bidi_level_of_next_char): Fix last change.
1559 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1561 Support bidi reordering of text covered by display properties.
1563 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1564 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1565 (bidi_cache_search, bidi_cache_iterator_state)
1566 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1567 (bidi_level_of_next_char, bidi_move_to_visually_next):
1568 Support character positions inside a run of characters covered by a
1570 (bidi_paragraph_init, bidi_resolve_explicit_1)
1571 (bidi_level_of_next_char): Call bidi_fetch_char and
1572 bidi_fetch_char_advance instead of FETCH_CHAR and
1574 (bidi_init_it): Initialize new members.
1575 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1577 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1578 instead of using explicit *_CHAR codes.
1579 (bidi_resolve_explicit, bidi_resolve_weak):
1580 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1581 bidirectional text is supported only in multibyte buffers.
1582 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1583 it to initialize the frame_window_p member of struct bidi_it.
1584 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1585 (bidi_resolve_explicit, bidi_resolve_weak)
1586 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1587 bidi_it->nchars is non-positive.
1588 (bidi_level_of_next_char): Don't try to lookup the cache for the
1589 next/previous character if nothing is cached there yet, or if we
1590 were just reseat()'ed to a new position.
1592 * xdisp.c (set_cursor_from_row): Set start and stop points
1593 according to the row's direction when priming the loop that looks
1594 for the glyph on which to display cursor.
1595 (single_display_spec_intangible_p): Function deleted.
1596 (display_prop_intangible_p): Reimplement to call
1597 handle_display_spec instead of single_display_spec_intangible_p.
1598 Accept 3 additional arguments needed by handle_display_spec.
1599 This fixes incorrect cursor motion across display property with complex
1600 values: lists, `(when COND...)' forms, etc.
1601 (single_display_spec_string_p): Support property values that are
1602 lists with the argument STRING its top-level element.
1603 (display_prop_string_p): Fix the condition for processing a
1604 property that is a list to be consistent with handle_display_spec.
1605 (handle_display_spec): New function, refactored from the
1606 last portion of handle_display_prop.
1607 (compute_display_string_pos): Accept additional argument
1608 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1609 value of a `display' property is a "replacing spec".
1610 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1611 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1612 the display property, but just return a value indicating whether
1613 the display property will replace the characters it covers.
1614 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1615 frame_window_p members of struct bidi_it.
1616 (compute_display_string_pos, compute_display_string_end):
1618 (push_it): Accept second argument POSITION, where pop_it should
1619 jump to continue iteration.
1620 (reseat_1): Initialize bidi_it.disp_pos.
1622 * keyboard.c (adjust_point_for_property): Adjust the call to
1623 display_prop_intangible_p to its new signature.
1625 * dispextern.h (struct bidi_it): New member frame_window_p.
1626 (bidi_init_it): Update prototypes.
1627 (display_prop_intangible_p): Update prototype.
1628 (compute_display_string_pos, compute_display_string_end):
1630 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1633 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1635 Malloc failure behavior now depends on size of allocation.
1636 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1637 * lisp.h: Change signatures accordingly.
1638 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1639 All callers changed. (Bug#8762)
1641 * gnutls.c: Use Emacs's memory allocators.
1642 Without this change, the gnutls library would invoke malloc etc.
1643 directly, which causes problems on non-SYNC_INPUT hosts, and which
1644 runs afoul of improving memory_full behavior. (Bug#8761)
1645 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1646 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1647 xfree instead of the default malloc, realloc, free.
1648 (Fgnutls_boot): No need to check for memory allocation failure,
1649 since xmalloc does that for us.
1651 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1652 * category.c (hash_get_category_set):
1653 * ccl.c (ccl_driver):
1654 * charset.c (Fdefine_charset_internal):
1655 * charset.h (struct charset.hash_index):
1656 * composite.c (get_composition_id, gstring_lookup_cache)
1657 (composition_gstring_put_cache):
1658 * composite.h (struct composition.hash_index):
1659 * dispextern.h (struct image.hash):
1660 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1661 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1662 (hashfn_equal, hashfn_user_defined, make_hash_table)
1663 (maybe_resize_hash_table, hash_lookup, hash_put)
1664 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1665 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1666 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1667 * image.c (make_image, search_image_cache, lookup_image)
1668 (xpm_put_color_table_h):
1669 * lisp.h (struct Lisp_Hash_Table):
1670 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1671 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1672 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1673 * alloc.c (allocate_vectorlike):
1674 Check for overflow in vector size calculations.
1675 * ccl.c (ccl_driver):
1676 Check for overflow when converting EMACS_INT to int.
1677 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1678 need to be updated by these changes.
1679 * fns.c (make_hash_table, maybe_resize_hash_table):
1680 Check for integer overflow with large hash tables.
1681 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1682 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1683 (SXHASH_REDUCE): New macro.
1684 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1685 Use it instead of discarding useful hash info with large hash values.
1686 (sxhash_float): New function.
1687 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1688 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1689 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1690 Rewrite to use FIXNUM_BITS, as this simplifies things.
1691 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1692 Adjust signatures to match updated version of code.
1693 (consing_since_gc): Now EMACS_INT, since a single hash table can
1694 use more than INT_MAX bytes.
1696 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1698 Make it possible to build with GCC-4.6+ -O2 -flto.
1700 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1702 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1704 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1705 Call minibuffer-inactive-mode.
1707 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1709 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1710 Update dependencies.
1712 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1714 * data.c (init_data): Remove code for UTS, this system is not
1717 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1719 Don't force ./temacs to start in terminal mode.
1721 * frame.c (make_initial_frame): Initialize faces in all cases, not
1722 only when CANNOT_DUMP is defined.
1723 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1725 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1727 * dispnew.c (add_window_display_history): Use const for the string
1728 pointer. Remove declaration, not needed.
1730 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1732 Use 'inline', not 'INLINE'.
1733 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1734 * alloc.c, fontset.c (INLINE): Remove.
1735 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1736 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1737 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1738 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1739 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1741 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1743 Make it possible to run ./temacs.
1745 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1746 syms_of_callproc does the same thing. Remove test for
1747 "initialized", do it in the caller.
1748 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1750 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1752 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1753 (read_minibuf): Use get_minibuffer.
1754 (syms_of_minibuf): Use DEFSYM.
1755 (Qmetadata): New var.
1756 * data.c (Qbuffer): Don't make it static.
1757 (syms_of_data): Use DEFSYM.
1759 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1761 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1762 (CCL_CODE_MIN): New macro.
1764 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1766 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1768 * eval.c (Qdebug): Now static.
1769 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1770 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1771 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1773 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1775 * image.c: Various fixes to ImageMagick code comments.
1776 (Fimagemagick_types): Doc fix.
1778 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1780 Minor fixes prompted by GCC 4.6.0 warnings.
1782 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1784 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1785 (x_clipboard_manager_save_all): Move extern decl to ...
1786 * xterm.h: ... here, so that it can be checked for consistency.
1788 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1790 * xselect.c (x_clipboard_manager_save_frame)
1791 (x_clipboard_manager_save_all): New functions.
1792 (Fx_clipboard_manager_save): Lisp function deleted.
1794 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1795 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1797 * xterm.h: Update prototype.
1799 2011-05-28 William Xu <william.xwl@gmail.com>
1801 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1804 2011-05-28 Jim Meyering <meyering@redhat.com>
1806 Avoid a sign-extension bug in crypto_hash_function.
1807 * fns.c (to_uchar): Define.
1808 (crypto_hash_function): Use it to convert some newly-signed
1809 variables to unsigned, to avoid sign-extension bugs. For example,
1810 without this change, (md5 "truc") would evaluate to
1811 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1812 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1813 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1815 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1817 Integer overflow fixes.
1819 * dbusbind.c: Serial number integer overflow fixes.
1820 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1821 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1822 to hold a serial number that is too large for a fixnum.
1823 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1824 Check for serial numbers out of range. Decode any serial number
1825 that was so large that it became a float. (Bug#8722)
1827 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1828 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1829 Use XFASTINT rather than XUINT when numbers are nonnegative.
1830 (xd_append_arg, Fdbus_method_return_internal):
1831 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1832 arguments, check that Lisp number is nonnegative, rather than
1833 silently wrapping negative numbers around. (Bug#8722)
1834 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1837 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1839 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1841 ccl: add integer overflow checks
1842 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1843 (IN_INT_RANGE): New macros.
1844 (ccl_driver): Use them to check for integer overflow when
1845 decoding a CCL program. Many of the new checks are whether XINT (x)
1846 fits in int; it doesn't always, on 64-bit hosts. The new version
1847 doesn't catch all possible integer overflows, but it's an
1848 improvement. (Bug#8719)
1850 * alloc.c (make_event_array): Use XINT, not XUINT.
1851 There's no need for unsigned here.
1853 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1854 This follows up to the 2011-05-06 change that substituted uintptr_t
1855 for EMACS_INT. This case wasn't caught back then.
1857 Rework Fformat to avoid integer overflow issues.
1858 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1859 now (part of C89). Include <verify.h>.
1860 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1861 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1862 (Fformat): Avoid the prepass trying to compute sizes; it was only
1863 approximate and thus did not catch overflow reliably. Instead, walk
1864 through the format just once, formatting and computing sizes as we go,
1865 checking for integer overflow at every step, and allocating a larger
1866 buffer as needed. Keep track separately whether the format is
1867 multibyte. Keep only the most-recently calculated precision, rather
1868 than them all. Record whether each argument has been converted to
1869 string. Use EMACS_INT, not int, for byte and char and arg counts.
1870 Support field widths and precisions larger than INT_MAX. Avoid
1871 sprintf's undefined behavior with conversion specifications such as %#d
1872 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1873 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1874 formatting out-of-range floating point numbers with int
1877 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1879 * data.c: Avoid integer truncation in expressions involving floats.
1880 * data.c: Include <intprops.h>.
1881 (arith_driver): When there's an integer overflow in an expression
1882 involving floating point, convert the integers to floating point
1883 so that the resulting value does not suffer from catastrophic
1884 integer truncation. For example, on a 64-bit host (* 4
1885 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1886 Do not rely on undefined behavior after integer overflow.
1888 merge count_size_as_multibyte, parse_str_to_multibyte
1889 * character.c, character.h (count_size_as_multibyte):
1890 Rename from parse_str_to_multibyte; all uses changed.
1891 Check for integer overflow.
1892 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1893 since it's now a duplicate of the other. This is more of
1894 a character than a buffer op, so better that it's in character.c.
1895 * fns.c, print.c: Adjust to above changes.
1897 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1899 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1901 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1903 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1904 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1905 (x_clipboard_manager_save): Now static.
1906 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1908 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1909 (crypto_hash_function): Now static.
1910 Fix pointer signedness problems. Avoid unnecessary initializations.
1912 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1914 * termhooks.h (Vselection_alist): Make it terminal-local.
1916 * terminal.c (create_terminal): Initialize it.
1918 * xselect.c: Support for clipboard managers.
1919 (Vselection_alist): Move to termhooks.h as terminal-local var.
1920 (LOCAL_SELECTION): New macro.
1921 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1922 (symbol_to_x_atom): Remove gratuitous arg.
1923 (x_handle_selection_request, lisp_data_to_selection_data)
1924 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1925 (x_own_selection, x_get_local_selection, x_convert_selection):
1926 New arg, specifying work frame. Use terminal-local Vselection_alist.
1927 (some_frame_on_display): Delete unused function.
1928 (Fx_own_selection_internal, Fx_get_selection_internal)
1929 (Fx_disown_selection_internal, Fx_selection_owner_p)
1930 (Fx_selection_exists_p): New optional frame arg.
1931 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1932 (x_handle_selection_clear): Don't treat other terminals with the
1933 same keyboard specially. Use the terminal-local Vselection_alist.
1934 (x_clear_frame_selections): Use Frun_hook_with_args.
1936 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1938 * xterm.h: Add support for those atoms.
1940 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1942 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1943 (converted_selections, conversion_fail_tag): New global variables.
1944 (x_selection_request_lisp_error): Free the above.
1945 (x_get_local_selection): Remove unnecessary code.
1946 (x_reply_selection_request): Args changed; handle arbitrary array
1947 of converted selections stored in converted_selections.
1948 Separate the XChangeProperty and SelectionNotify steps.
1949 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1950 (x_convert_selection): New function.
1951 (x_handle_selection_event): Simplify.
1952 (x_get_foreign_selection): Don't ignore incoming requests while
1953 waiting for an answer; this will fail when we implement
1954 SAVE_TARGETS, and seems unnecessary anyway.
1955 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1956 (Vx_sent_selection_functions): Doc fix.
1958 2011-05-26 Leo Liu <sdl.web@gmail.com>
1960 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1962 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1964 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1966 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1967 for fringe update if it has periodic bitmap.
1968 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1969 and fringe_bitmap_periodic_p.
1971 * fringe.c (get_fringe_bitmap_data): New function.
1972 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1973 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1974 row. Mark glyph row for fringe update if periodicity changed.
1976 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1977 for fringe update unless it has periodic bitmap.
1979 2011-05-25 Kenichi Handa <handa@m17n.org>
1981 * xdisp.c (get_next_display_element): Set correct it->face_id for
1982 a static composition.
1984 2011-05-24 Leo Liu <sdl.web@gmail.com>
1987 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1989 * fns.c (crypto_hash_function, Fsha1): New function.
1990 (Fmd5): Use crypto_hash_function.
1991 (syms_of_fns): Add Ssha1.
1993 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1995 * gnutls.c: Remove unused macros.
1996 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1997 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1998 Remove macros that are defined and never used.
1999 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2001 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2003 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2004 (Fx_get_selection_internal): Minor cleanup.
2005 (Fx_own_selection_internal): Rename arguments for consistency with
2008 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2010 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2012 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2014 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2016 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2018 * dispnew.c (scrolling_window): Don't exclude the case that the
2019 last enabled row in the desired matrix touches the bottom boundary.
2021 2011-05-21 Glenn Morris <rgm@gnu.org>
2023 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2024 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2025 and add some more files.
2027 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2029 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2030 report_file_error introduced by the change from 2011-05-07.
2032 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2034 * systime.h (Time): Define only if emacs is defined.
2035 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2036 where the include path doesn't have X11/X.h by default. See
2037 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2039 2011-05-20 Kenichi Handa <handa@m17n.org>
2041 * composite.c (find_automatic_composition): Fix previous change.
2043 2011-05-20 Glenn Morris <rgm@gnu.org>
2045 * lisp.mk: New file, split from Makefile.in.
2046 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2047 (shortlisp): Remove.
2048 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2050 2011-05-19 Glenn Morris <rgm@gnu.org>
2052 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2053 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2054 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2055 (lisp): Set the order to that of loadup.el.
2056 (shortlisp): Make it a copy of $lisp.
2057 (SOME_MACHINE_LISP): Remove.
2058 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2059 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2061 2011-05-18 Kenichi Handa <handa@m17n.org>
2063 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2064 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2065 (find_automatic_composition): Mostly rewrite for efficiency.
2067 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2069 * makefile.w32-in: Update dependencies.
2071 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2073 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2074 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2076 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2078 Fix some integer overflow issues, such as string length overflow.
2080 * insdel.c (count_size_as_multibyte): Check for string overflow.
2082 * character.c (lisp_string_width): Check for string overflow.
2083 Use EMACS_INT, not int, for string indexes and lengths; in
2084 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2085 the resulting string length overflows an EMACS_INT; instead,
2086 report a string overflow if no precision given. When checking for
2087 precision exhaustion, use a check that cannot possibly have
2088 integer overflow. (Bug#8675)
2089 * character.h (lisp_string_width): Adjust to new signature.
2091 * alloc.c (string_overflow): New function.
2092 (Fmake_string): Use it. This doesn't change behavior, but saves
2093 a few bytes and will simplify future changes.
2094 * character.c (string_escape_byte8): Likewise.
2095 * lisp.h (string_overflow): New decl.
2097 Fixups, following up to the user-interface timestamp change.
2098 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2099 for UI timestamps, instead of unsigned long.
2100 * msdos.c (mouse_get_pos): Likewise.
2101 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2102 * w32gui.h (Time): Define by including "systime.h" rather than by
2103 declaring it ourselves. (Bug#8664)
2105 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2106 * image.c (clear_image_cache): Likewise.
2108 * term.c (term_mouse_position): Don't assume time_t wraparound.
2110 Be more systematic about user-interface timestamps.
2111 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2112 and sometimes 'EMACS_UINT', to represent these timestamps.
2113 This change causes it to use 'Time' uniformly, as that's what X uses.
2114 This makes the code easier to follow, and makes it easier to catch
2115 integer overflow bugs such as Bug#8664.
2116 * frame.c (Fmouse_position, Fmouse_pixel_position):
2117 Use Time, not unsigned long, for user-interface timestamps.
2118 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2119 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2120 * keyboard.h (last_event_timestamp): Likewise.
2121 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2122 * menu.h (xmenu_show): Likewise.
2123 * term.c (term_mouse_position): Likewise.
2124 * termhooks.h (struct input_event.timestamp): Likewise.
2125 (struct terminal.mouse_position_hook): Likewise.
2126 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2127 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2128 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2129 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2131 * menu.h, termhooks.h: Include "systime.h", for Time.
2133 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2134 Don't assume that the difference between two unsigned long values
2135 can fit into an integer. At this point, we know button_down_time
2136 <= event->timestamp, so the difference must be nonnegative, so
2137 there's no need to cast the result if double-click-time is
2138 nonnegative, as it should be; check that it's nonnegative, just in
2139 case. This bug is triggered when events are more than 2**31 ms
2140 apart (about 25 days). (Bug#8664)
2142 * xselect.c (last_event_timestamp): Remove duplicate decl.
2143 (x_own_selection): Remove needless cast to unsigned long.
2145 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2146 that always fit in int. Use a sentinel instead of a counter, to
2147 avoid a temp and to allay GCC's concerns about possible int overflow.
2148 * frame.h (struct frame): Use int for menu_bar_items_used
2149 instead of EMACS_INT, since it always fits in int.
2151 * menu.c (grow_menu_items): Check for int overflow.
2153 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2155 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2156 Before, the code was not consistent. These values cannot exceed
2157 2**31 - 1 so there's no need to make them unsigned.
2158 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2159 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2160 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2162 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2164 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2165 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2166 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2167 presumably because the widths might not match.
2169 * window.c (size_window): Avoid needless test at loop start.
2171 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2173 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2175 2011-05-12 Drew Adams <drew.adams@oracle.com>
2177 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2179 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2181 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2182 `width' to `bar_area_x' and `bar_area_width', respectively.
2183 (x_scroll_run): Take account of fringe background extension.
2185 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2186 Rename local vars `left' and `width' to `bar_area_x' and
2187 `bar_area_width', respectively.
2188 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2189 background extension.
2191 2011-05-10 Jim Meyering <meyering@redhat.com>
2193 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2195 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2197 * image.c (Finit_image_library): Return t for built-in image types,
2198 like pbm and xbm. (Bug#8640)
2200 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2202 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2204 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2206 * w32console.c (Fset_screen_color): Doc fix.
2207 (Fget_screen_color): New function.
2208 (syms_of_ntterm): Defsubr it.
2210 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2211 unlink the temporary file if Fcall_process didn't create it in the
2213 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2214 child process will be redirected to a file specified with `:file'.
2215 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2216 cue to call_process_cleanup not to close that handle.
2218 2011-05-07 Ben Key <bkey76@gmail.com>
2220 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2221 one of two shell specific rules, either bootstrap-temacs-CMD or
2222 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2223 to the previous implementation of the bootstrap-temacs rule.
2224 The bootstrap-temacs-CMD rule is similar to the previous
2225 implementation of the bootstrap-temacs rule except that it
2226 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2229 These changes, along with some changes to nt/configure.bat,
2230 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2231 earlier fix to add support for --cflags and --ldflags options
2232 that include quotes so that it works whether make uses cmd or
2235 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2237 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2238 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2240 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2241 a string. Handle both cases.
2242 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2243 (Fdbus_register_method): Use Qinvalid_function.
2245 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2247 * makefile.w32-in: Update dependencies.
2248 (LISP_H): Add inttypes.h and stdin.h.
2249 (PROCESS_H): Add unistd.h.
2251 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2253 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2254 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2256 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2258 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2260 * term.c (vfatal): Remove stray call to va_end.
2261 It's not needed and the C Standard doesn't allow it here anyway.
2263 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2264 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2266 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2269 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2271 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2273 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2275 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2277 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2279 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2280 * charset.c (Fdefine_charset_internal): Don't initialize
2281 charset.code_space[15]. The value was garbage, on hosts with
2282 32-bit int (Bug#8600).
2284 * lread.c (read_integer): Be more consistent with string-to-number.
2285 Use string_to_number to do the actual conversion; this avoids
2286 rounding errors and fixes some other screwups. Without this fix,
2287 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2288 (digit_to_number): Move earlier, for benefit of read_integer.
2289 Return -1 if the digit is out of range for the base, -2 if it is
2290 not a digit in any supported base. (Bug#8602)
2292 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2294 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2295 to match comment at start of function. This also removes a
2296 GCC warning about overflow in a 32+64-bit port.
2298 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2300 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2301 Reported by Stefan Monnier in
2302 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2303 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2304 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2306 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2307 (EMACS_UINTPTR): Likewise, with uintptr_t.
2309 * lisp.h: Prefer 64-bit EMACS_INT if available.
2310 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2311 on 32-bit hosts that have 64-bit int, so that they can access
2313 However, temporarily disable this change unless the temporary
2314 symbol WIDE_EMACS_INT is defined.
2316 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2318 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2319 This removes an assumption that EMACS_INT and long are the same
2320 width as pointers. The assumption is true for Emacs porting targets
2321 now, but we want to make other targets possible.
2322 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2323 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2324 In the rest of the code, change types of integers that hold casted
2325 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2326 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2327 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2328 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2329 No need to cast type when ORing.
2330 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2331 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2332 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2333 assume EMACS_INT is the same width as char *.
2334 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2335 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2336 Remove no-longer-needed casts.
2337 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2338 (xg_tool_bar_help_callback, xg_make_tool_item):
2339 Use EMACS_INTPTR to hold an integer
2340 that will be cast to void *; this can avoid a GCC warning
2341 if EMACS_INT is not the same width as void *.
2342 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2343 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2344 (current_message_1, set_message_1):
2345 Use a local to convert to proper width without a cast.
2346 * xmenu.c (dialog_selection_callback): Likewise.
2348 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2349 Also, don't assume VALBITS / RAND_BITS is less than 5,
2350 and don't rely on undefined behavior when shifting a 1 left into
2352 * lisp.h (get_random): Change signature to match.
2354 * lread.c (hash_string): Use size_t, not int, for hash computation.
2355 Normally we prefer signed values; but hashing is special, because
2356 it's better to use unsigned division on hash table sizes so that
2357 the remainder is nonnegative. Also, size_t is the natural width
2358 for hashing into memory. The previous code used 'int', which doesn't
2359 retain enough info to hash well into very large tables.
2360 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2362 * dbusbind.c: Don't possibly lose pointer info when converting.
2363 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2364 Use XPNTR rather than XHASH, so that the high-order bits of
2365 the pointer aren't lost when converting through void *.
2367 * eval.c (Fautoload): Don't double-shift a pointer.
2369 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2371 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2373 * gnutls.c (DEF_GNUTLS_FN):
2374 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2376 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2378 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2381 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2383 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2384 New version that can reserve upto 2GB of heap space.
2386 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2388 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2390 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2392 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2393 `gnutls_certificate_set_x509_key_file'.
2395 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2397 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2398 Update dependencies.
2400 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2402 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2403 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2404 Remove unused parameter `fildes'.
2405 * process.c (read_process_output, send_process): Don't pass it.
2407 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2409 Fix previous change: the library cache is defined in w32.c.
2410 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2411 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2413 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2415 Implement dynamic loading of GnuTLS on Windows.
2417 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2418 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2419 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2422 * gnutls.c (Qgnutls_dll): Define.
2423 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2424 (gnutls_*): Declare function pointers.
2425 (init_gnutls_functions): New function to initialize function pointers.
2426 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2427 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2428 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2429 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2430 (emacs_gnutls_write, emacs_gnutls_read)
2431 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2432 (Fgnutls_available_p): New function.
2433 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2434 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2435 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2437 * image.c: Include w32.h.
2438 (Vimage_type_cache): Delete.
2439 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2440 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2441 (w32_delayed_load): Move to w32.c.
2443 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2445 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2446 (w32_delayed_load): Move from image.c. When loading a library, record
2447 its filename in the :loaded-from property of the library id.
2448 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2449 Initialize and staticpro them.
2450 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2452 * process.c: Include lisp.h before w32.h, not after.
2453 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2454 instead of gnutls_record_check_pending.
2456 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2458 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2460 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2461 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2464 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2466 * xterm.c (x_set_frame_alpha): Do not set property on anything
2467 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2469 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2471 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2473 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2475 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2476 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2477 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2478 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2479 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2480 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2481 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2482 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2483 (Qgnutls_bootprop_callbacks_verify): Make static.
2485 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2487 * callproc.c: Indentation fixup.
2489 * sysdep.c (wait_for_termination_1): Make static.
2490 (wait_for_termination, interruptible_wait_for_termination):
2491 Move after wait_for_termination_1.
2493 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2495 * sysdep.c (interruptible_wait_for_termination): New function
2496 which is like wait_for_termination, but allows keyboard
2499 * callproc.c (Fcall_process): Add (:file "file") as an option for
2501 (Fcall_process_region): Ditto.
2503 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2505 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2506 rather than `XVECTOR (FOO)->size'.
2508 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2509 inttypes.h, as a gnulib replacement is used if it not available in
2512 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2514 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2515 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2516 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2518 * coding.c (coding_alloc_by_realloc): Error out if destination
2519 will grow beyond MOST_POSITIVE_FIXNUM.
2520 (decode_coding_emacs_mule): Abort if there isn't enough place in
2521 charbuf for the composition carryover bytes. Reserve an extra
2522 space for up to 2 characters produced in a loop.
2523 (decode_coding_iso_2022): Abort if there isn't enough place in
2524 charbuf for the composition carryover bytes.
2526 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2528 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2529 aborting when %lld or %lll format is passed.
2530 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2531 %llo or %llx format is passed. (Bug#8545)
2533 * window.c (window_scroll_line_based): Use a marker instead of
2534 simple variables to record original value of point. (Bug#7952)
2536 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2537 produced by %s or %c overflows available buffer space. (Bug#8545)
2539 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2541 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2542 (SIZE_MAX): Move defn after all includes, as they might #define it.
2544 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2546 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2548 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2550 * keyboard.c (Qdelayed_warnings_hook): Define.
2551 (command_loop_1): Run `delayed-warnings-hook'
2552 if Vdelayed_warnings_list is non-nil.
2553 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2554 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2556 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2558 * doprnt.c (doprnt): Don't return value smaller than the buffer
2559 size if the message was truncated. (Bug#8545).
2561 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2563 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2564 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2566 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2568 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2570 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2572 * makefile.w32-in: Update dependencies.
2574 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2576 Improve `doprnt' and its usage. (Bug#8545)
2577 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2578 `format_end'. Remove support for %l as a conversion specifier.
2579 Don't use xrealloc. Improve diagnostics when the %l size modifier
2580 is used. Update the commentary.
2582 * eval.c (verror): Simplify calculation of size_t.
2584 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2587 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2589 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2592 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2594 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2595 This makes this file independent of the recent pseudovector change.
2597 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2599 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2601 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2602 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2603 Remove unused local.
2604 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2606 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2607 GCC 4.6.0 optimizes based on type-based alias analysis.
2608 For example, if b is of type struct buffer * and v of type struct
2609 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2610 != &v->size, and therefore "v->size = 1; b->size = 2; return
2611 v->size;" must therefore return 1. This assumption is incorrect
2612 for Emacs, since it type-puns struct Lisp_Vector * with many other
2613 types. To fix this problem, this patch adds a new type struct
2614 vectorlike_header that documents the constraints on layout of vectors
2615 and pseudovectors, and helps optimizing compilers not get fooled
2616 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2617 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2618 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2620 (XSETPVECTYPE): Rewrite in terms of new macro.
2621 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2622 This is a bit clearer, and further avoids the possibility of
2623 undesirable aliasing.
2624 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2625 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2626 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2627 since Lisp_Subr is a special case (no "next" field).
2628 (ASIZE): Now uses header.size rather than size.
2629 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2630 to avoid the hassle of writing XVECTOR (foo)->header.size.
2631 (struct vectorlike_header): New type.
2632 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2633 object, to help avoid aliasing.
2634 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2635 (SUBRP): Likewise, since Lisp_Subr is a special case.
2636 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2637 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2638 (struct Lisp_Hash_Table): Combine first two members into a single
2639 struct vectorlike_header member. All uses of "size" and "next" members
2640 changed to be "header.size" and "header.next".
2641 * buffer.h (struct buffer): Likewise.
2642 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2643 * frame.h (struct frame): Likewise.
2644 * process.h (struct Lisp_Process): Likewise.
2645 * termhooks.h (struct terminal): Likewise.
2646 * window.c (struct save_window_data, struct saved_window): Likewise.
2647 * window.h (struct window): Likewise.
2648 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2649 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2650 * buffer.c (init_buffer_once): Likewise.
2651 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2653 * process.c (Fformat_network_address): Use local var for size,
2656 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2658 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2659 * data.c (atof): Remove decl; no longer used or needed.
2660 (digit_to_number): Move to lread.c.
2661 (Fstring_to_number): Use new string_to_number function, to be
2662 consistent with how the Lisp reader treats infinities and NaNs.
2663 Do not assume that floating-point numbers represent EMACS_INT
2664 without losing information; this is not true on most 64-bit hosts.
2665 Avoid double-rounding errors, by insisting on integers when
2666 parsing non-base-10 numbers, as the documentation specifies.
2667 * lisp.h (string_to_number): New decl, replacing ...
2668 (isfloat_string): Remove.
2669 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2670 (read1): Do not accept +. and -. as integers; this
2671 appears to have been a coding error. Similarly, do not accept
2672 strings like +-1e0 as floating point numbers. Do not report
2673 overflow for integer overflows unless the base is not 10 which
2674 means we have no simple and reliable way to continue.
2675 Break out the floating-point parsing into a new
2676 function string_to_number, so that Fstring_to_number parses
2677 floating point numbers consistently with the Lisp reader.
2678 (digit_to_number): Move here from data.c. Make it static inline.
2679 (E_CHAR, EXP_INT): Remove, replacing with ...
2680 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2681 (string_to_number): New function, replacing isfloat_string.
2682 This function checks for valid syntax and produces the resulting
2683 Lisp float number too. Rework it so that string-to-number
2684 no longer mishandles examples like "1.0e+". Use strtoumax,
2685 so that overflow for non-base-10 numbers is reported only when
2686 there's no portable and simple way to convert to floating point.
2688 * textprop.c (set_text_properties_1): Rewrite for clarity,
2689 and to avoid GCC warning about integer overflow.
2691 * intervals.h (struct interval): Use EMACS_INT for members
2692 where EMACS_UINT might cause problems. See
2693 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2694 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2695 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2697 (offset_intervals): Tell GCC not to worry about length overflow
2698 when negating a negative length.
2700 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2701 (overrun_check_free): Likewise.
2703 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2704 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2707 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2708 (gnutls_make_error): Rename local to avoid shadowing.
2709 (gnutls_emacs_global_deinit): ifdef out; not used.
2710 (Fgnutls_boot): Use const for pointer to readonly storage.
2711 Comment out unused local. Fix pointer signedness problems.
2713 * lread.c (openp): Don't stuff size_t into an 'int'.
2714 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2715 about possible signed overflow.
2717 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2718 (GDK_KEY_g): Don't define if already defined.
2719 (xg_prepare_tooltip): Avoid pointer signedness problem.
2720 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2722 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2723 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2725 * xfns.c (Fx_window_property): Simplify a bit,
2726 to make a bit faster and to avoid GCC 4.6.0 warning.
2727 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2729 * fns.c (internal_equal): Don't assume size_t fits in int.
2731 * alloc.c (compact_small_strings): Tighten assertion a little.
2733 Replace pEd with more-general pI, and fix some printf arg casts.
2734 * lisp.h (pI): New macro, generalizing old pEd macro to other
2735 conversion specifiers. For example, use "...%"pI"d..." rather
2736 than "...%"pEd"...".
2737 (pEd): Remove. All uses replaced with similar uses of pI.
2738 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2739 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2740 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2741 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2742 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2743 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2744 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2746 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2747 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2748 * print.c (safe_debug_print, print_object): Likewise.
2749 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2751 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2752 avoiding the 0 flag, which is not portable.
2753 * process.c (Fmake_network_process): Use pI to avoid cast.
2754 * region-cache.c (pp_cache): Likewise.
2755 * xdisp.c (decode_mode_spec): Likewise.
2756 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2757 behavior on 64-bit hosts with printf arg.
2758 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2759 (x_stop_queuing_selection_requests): Likewise.
2760 (x_get_window_property): Don't truncate byte count to an 'int'
2763 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2764 here, since it parses constructs like leading '-' and spaces,
2765 which are not wanted; and it overflows with large numbers.
2766 Instead, simply match F[0-9]+, which is what is wanted anyway.
2768 * alloc.c: Remove unportable assumptions about struct layout.
2769 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2770 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2771 (allocate_vectorlike, make_pure_vector): Use the new macros,
2772 plus offsetof, to remove unportable assumptions about struct layout.
2773 These assumptions hold on all porting targets that I know of, but
2774 they are not guaranteed, they're easy to remove, and removing them
2775 makes further changes easier.
2777 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2778 This doesn't fix a bug but makes the code clearer.
2779 (string_overrun_cookie): Now const. Use initializers that
2780 don't formally overflow signed char, to avoid warnings.
2781 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2782 can cause Emacs to crash when string overrun checking is enabled.
2783 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2784 multiple of sizeof (EMACS_INT); it need not be, if
2785 alignof(EMACS_INT) < sizeof (EMACS_INT).
2786 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2788 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2790 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2792 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2794 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2795 supposed to be handshaking. (Bug#8556)
2796 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2798 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2800 * lisp.h (Qdebug): List symbol.
2801 * eval.c (Qdebug): Restore global linkage.
2802 * keyboard.c (debug-on-event): New variable.
2803 (handle_user_signal): Break into debugger when debug-on-event
2804 matches the current signal symbol.
2806 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2808 * alloc.c (check_sblock, check_string_bytes)
2809 (check_string_free_list): Convert to standard C.
2811 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2813 * w32.c (emacs_gnutls_push): Fix typo.
2815 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2817 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2818 "cast to pointer from integer of different size".
2820 Improve doprnt and its use in verror. (Bug#8545)
2821 * doprnt.c (doprnt): Document the set of format control sequences
2822 supported by the function. Use SAFE_ALLOCA instead of always
2825 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2826 is one byte too soon. Don't use xrealloc; instead xfree and
2829 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2831 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2834 * gnutls.c: Renamed global_initialized to
2835 gnutls_global_initialized. Added internals for the
2836 :verify-hostname-error, :verify-error, and :verify-flags
2837 parameters of `gnutls-boot' and documented those parameters in the
2838 docstring. Start callback support.
2839 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2840 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2841 on error. Return error code.
2842 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2843 (emacs_gnutls_read): Likewise.
2844 (Fgnutls_boot): Return handshake error code.
2845 (emacs_gnutls_handle_error): New function.
2846 (wsaerror_to_errno): Likewise.
2848 * w32.h (emacs_gnutls_pull): Add prototype.
2849 (emacs_gnutls_push): Likewise.
2851 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2852 (emacs_gnutls_push): Likewise.
2854 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2856 * process.c (wait_reading_process_output): Check if GnuTLS
2857 buffered some data internally if no FDs are set for TLS
2860 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2861 (LIBS): Link to USER_LIBS.
2862 ($(BLD)/gnutls.$(0)): New target.
2864 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2866 * xdisp.c (handle_single_display_spec): Rename the
2867 display_replaced_before_p argument into display_replaced_p, to
2868 make it consistent with the commentary. Fix typos in the
2871 * textprop.c (syms_of_textprop): Remove dead code.
2872 (copy_text_properties): Delete obsolete commentary about an
2873 interface that was deleted long ago. Fix typos in the description
2876 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2877 to changes in oldXMenu/XMenu.h from 2011-04-16.
2878 <menu_help_message, prev_menu_help_message>: Constify.
2879 (IT_menu_make_room): menu->help_text is now `const char **';
2882 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2883 to changes in oldXMenu/XMenu.h from 2011-04-16.
2884 (struct XMenu): Declare `help_text' `const char **'.
2886 * xfaces.c <Qunspecified>: Make extern again.
2888 * syntax.c: Include sys/types.h before including regex.h, as
2891 * doc.c (get_doc_string): Improve the format passed to `error'.
2893 * doprnt.c (doprnt): Improve commentary.
2895 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2897 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2900 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2901 changes in globals.h immediately force recompilation.
2902 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2903 $(CURDIR)/s/ms-w32.h.
2904 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2906 * character.c (Fchar_direction): Function deleted.
2907 (syms_of_character): Don't defsubr it.
2908 <char-direction-table>: Deleted.
2910 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2912 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2913 * doprnt.c: Include limits.h.
2914 (SIZE_MAX): New macro.
2915 (doprnt): Return a size_t value. 2nd arg is now size_t.
2916 Many local variables are now size_t instead of int or unsigned.
2917 Improve overflow protection. Support `l' modifier for integer
2918 conversions. Support %l conversion. Don't assume an EMACS_INT
2919 argument for integer conversions and for %c.
2921 * lisp.h (doprnt): Restore prototype.
2923 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2926 * Makefile.in (base_obj): Add back doprnt.o.
2928 * deps.mk (doprnt.o): Add back prerequisites.
2929 (callint.o): Depend on character.h.
2931 * eval.c (internal_lisp_condition_case): Include the handler
2932 representation in the error message.
2933 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2934 when breaking from the loop.
2936 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2938 * callint.c (Fcall_interactively): When displaying error message
2939 about invalid control letter, pass the character's codepoint, not
2940 a pointer to its multibyte form. Improve display of the character
2941 in octal and display also its hex code.
2943 * character.c (char_string): Use %x to display the (unsigned)
2944 codepoint of an invalid character, to avoid displaying a bogus
2947 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2948 `error', not SYMBOL_NAME itself.
2950 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2951 character arguments to `error'.
2953 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2954 to `error' in error message about FINAL_CHAR argument. Make sure
2955 FINAL_CHAR is a character, and use %c when it is passed as
2956 argument to `error'.
2958 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2960 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2962 * w32.c: Include <time.h>.
2963 (sys_localtime): New function.
2965 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2967 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2969 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2971 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2973 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2976 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2978 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2979 gl_state.e_property when gl_state.object is Qt.
2981 * insdel.c (make_gap_larger): Remove limitation of buffer size
2984 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2986 * xdisp.c (lookup_glyphless_char_display)
2987 (produce_glyphless_glyph): Handle cons cell entry in
2988 glyphless-char-display.
2989 (Vglyphless_char_display): Document it.
2991 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2992 glyphless-char-display.
2994 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2996 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2998 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3000 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3001 definition for no-X builds.
3003 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3005 Static checks with GCC 4.6.0 and non-default toolkits.
3007 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3009 * process.c (keyboard_bit_set): Define only if SIGIO.
3010 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3011 (send_process): Repair possible setjmp clobbering.
3013 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3015 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3017 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3019 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3020 Define only if needed.
3022 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3023 by pacifying GCC about it. Maybe it's time to retire it?
3024 * xfaces.c (USG, __TIMEVAL__): Likewise.
3026 * dispextern.h (struct redisplay_interface): Rename param
3028 * termhooks.h (struct terminal): Likewise.
3029 * xterm.c (xembed_send_message): Likewise.
3031 * insdel.c (make_gap_smaller): Define only if
3032 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3034 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3037 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3038 so that we aren't warned about unused symbols.
3040 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3042 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3044 * xfns.c (x_real_positions): Mark locals as initialized.
3046 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3048 * xterm.c: Fix problems found by static analysis with other toolkits.
3049 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3050 (x_dispatch_event): Declare static if USE_GTK, and
3051 define if USE_GTK || USE_X_TOOLKIT.
3052 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3053 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3054 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3055 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3057 * xmenu.c (menu_help_callback): Pointer type fixes.
3058 Use const pointers when pointing at readonly data. Avoid pointer
3060 (FALSE): Remove unused macro.
3061 (update_frame_menubar): Remove unused decl.
3063 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3065 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3066 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3067 (single_menu_item): Rename local to avoid shadowing.
3069 * keyboard.c (make_lispy_event): Remove unused local var.
3071 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3072 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3074 * bitmaps: Change bitmaps from unsigned char back to the X11
3075 compatible char. Avoid the old compiler warnings about
3076 out-of-range initializers by using, for example, '\xab' rather
3079 * xgselect.c (xgselect_initialize): Check vs interface
3080 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3082 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3084 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3085 to read-only memory.
3087 * fns.c (vector): Remove; this old hack is no longer needed.
3089 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3091 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3093 * xrdb.c (x_load_resources): Omit unused local.
3095 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3096 (x_window): Rename locals to avoid shadowing.
3097 (USG): Use the kludged USG macro, to pacify gcc.
3099 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3100 (x_term_init): Remove local to avoid shadowing.
3102 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3104 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3105 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3107 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3109 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3111 Fix regex.c, syntax.c and friends for buffers > 2GB.
3112 * syntax.h (struct gl_state_s): Declare character position members
3115 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3117 * textprop.c (verify_interval_modification, interval_of):
3118 Declare arguments EMACS_INT.
3120 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3123 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3125 * indent.c (Fvertical_motion): Local variable it_start is now
3128 * regex.c (re_match, re_match_2, re_match_2_internal)
3129 (bcmp_translate, regcomp, regexec, print_double_string)
3130 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3131 (re_compile_pattern, re_exec): Declare arguments and local
3132 variables `size_t' and `ssize_t' and return values `regoff_t', as
3134 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3135 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3136 <compile_stack_type>: `size' and `avail' are now `size_t'.
3138 * regex.h <regoff_t>: Use ssize_t, not int.
3139 (re_search, re_search_2, re_match, re_match_2): Arguments that
3140 specify buffer/string position and length are now ssize_t and
3141 size_t. Return type is regoff_t.
3143 2011-04-16 Ben Key <bkey76@gmail.com>
3145 * nsfont.m: Fixed bugs in ns_get_family and
3146 ns_descriptor_to_entity that were caused by using free to
3147 deallocate memory blocks that were allocated by xmalloc (via
3148 xstrdup). This caused Emacs to crash when compiled with
3149 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3150 --enable-checking=xmallocoverrun). xfree is now used to
3151 deallocate these memory blocks.
3153 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3155 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3157 emacs_write: Accept and return EMACS_INT for sizes.
3158 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3160 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3161 Accept and return EMACS_INT.
3162 (emacs_gnutls_write): Return the number of bytes written on
3164 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3165 (emacs_read, emacs_write): Remove check for negative size, as the
3166 Emacs source code has been audited now.
3167 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3168 (emacs_read, emacs_write): Use it.
3169 * process.c (send_process): Adjust to the new signatures of
3170 emacs_write and emacs_gnutls_write. Do not attempt to store
3171 a byte offset into an 'int'; it might overflow.
3172 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3174 * sound.c: Don't assume sizes fit in 'int'.
3175 (struct sound_device.period_size, alsa_period_size):
3176 Return EMACS_INT, not int.
3177 (struct sound_device.write, vox_write, alsa_write):
3178 Accept EMACS_INT, not int.
3179 (wav_play, au_play): Use EMACS_INT to store sizes and to
3180 record read return values.
3182 2011-04-15 Ben Key <bkey76@gmail.com>
3184 * keyboard.c (Qundefined): Don't declare static since it is used
3186 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3187 static since they are used in nsfont.m.
3189 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3191 * process.c (Qprocessp): Don't declare static.
3192 * lisp.h (Qprocessp): Declare again.
3194 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3196 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3198 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3200 Improve C-level modularity by making more things 'static'.
3202 Don't publish debugger-only interfaces to other modules.
3203 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3204 (verify_bytepos, count_markers): Move decls to the only modules
3206 * region-cache.h (pp_cache): Likewise.
3207 * window.h (check_all_windows): Likewise.
3208 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3210 * sysdep.c (croak): Now static, if
3211 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3212 * syssignal.h (croak): Declare only if not static.
3214 * alloc.c (refill_memory_reserve): Now static if
3215 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3216 * lisp.h (refill_memory_reserve): Declare only if not static.
3218 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3219 Define only if USE_LUCID.
3221 * xrdb.c (x_customization_string, x_rm_string): Now static.
3223 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3224 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3226 * xdisp.c (draw_row_with_mouse_face): Now static.
3227 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3229 * window.h (check_all_windows): Mark externally visible.
3231 * window.c (window_deletion_count): Now static.
3233 * undo.c: Make symbols static if they're not exported.
3234 (last_undo_buffer, last_boundary_position, pending_boundary):
3237 * textprop.c (interval_insert_behind_hooks): Now static.
3238 (interval_insert_in_front_hooks): Likewise.
3240 * term.c: Make symbols static if they're not exported.
3241 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3242 (max_frame_lines, tty_set_terminal_modes):
3243 (tty_reset_terminal_modes, tty_turn_off_highlight):
3244 (get_tty_terminal): Now static.
3245 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3246 * termhooks.h (term_mouse_moveto): Do not declare if
3248 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3249 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3251 * sysdep.c: Make symbols static if they're not exported.
3252 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3254 (sigprocmask_set, full_mask): Remove; unused.
3255 (wait_debugging): Mark as visible.
3256 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3257 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3259 * syntax.c (syntax_temp): Define only if !__GNUC__.
3261 * sound.c (current_sound_device, current_sound): Now static.
3263 * search.c (searchbufs, searchbuf_head): Now static.
3265 * scroll.c (scroll_cost): Remove; unused.
3266 * dispextern.h (scroll_cost): Remove decl.
3268 * region-cache.h (pp_cache): Mark as externally visible.
3270 * process.c: Make symbols static if they're not exported.
3271 (process_tick, update_tick, create_process, chan_process):
3272 (Vprocess_alist, proc_buffered_char, datagram_access):
3273 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3274 (deactivate_process): Mark defn as static, as well as decl.
3275 * lisp.h (create_process): Remove decl.
3276 * process.h (chan_process, Vprocess_alist): Remove decls.
3278 * print.c: Make symbols static if they're not exported.
3279 (print_depth, new_backquote_output, being_printed, print_buffer):
3280 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3281 (print_interval, print_number_index, initial_stderr_stream):
3283 * lisp.h (Fprinc): Remove decl.
3284 (debug_output_compilation_hack): Mark as externally visible.
3286 * sysdep.c (croak): Move decl from here to syssignal.h.
3287 * syssignal.h (croak): Put it here, so the API can be checked when
3288 'croak' is called from dissociate_if_controlling_tty.
3290 * minibuf.c: Make symbols static if they're not exported.
3291 (minibuf_save_list, choose_minibuf_frame): Now static.
3292 * lisp.h (choose_minibuf_frame): Remove decl.
3294 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3296 * lread.c: Make symbols static if they're not exported.
3297 (read_objects, initial_obarray, oblookup_last_bucket_number):
3299 (make_symbol): Remove; unused.
3300 * lisp.h (initial_obarray, make_symbol): Remove decls.
3302 * keyboard.c: Make symbols static if they're not exported.
3303 (single_kboard, recent_keys_index, total_keys, recent_keys):
3304 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3305 (this_single_command_key_start, echoing, last_auto_save):
3306 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3307 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3308 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3309 (Vlispy_mouse_stem, double_click_count):
3311 (force_auto_save_soon): Define only if SIGDANGER.
3312 (ignore_mouse_drag_p): Now static if
3313 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3314 (print_help): Remove; unused.
3315 (stop_character, last_timer_event): Mark as externally visible.
3316 * keyboard.h (ignore_mouse_drag_p): Declare only if
3317 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3318 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3319 * lisp.h (echoing): Remove decl.
3320 (force_auto_save_soon): Declare only if SIGDANGER.
3321 * xdisp.c (redisplay_window): Simplify code, to make it more
3322 obvious that ignore_mouse_drag_p is not accessed if !defined
3323 USE_GTK && !defined HAVE_NS.
3325 * intervals.c: Make symbols static if they're not exported.
3326 (merge_properties_sticky, merge_interval_right, delete_interval):
3328 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3330 * insdel.c: Make symbols static if they're not exported.
3331 However, leave prepare_to_modify_buffer alone. It's never
3332 called from outside this function, but that appears to be a bug.
3333 (combine_after_change_list, combine_after_change_buffer):
3334 (adjust_after_replace, signal_before_change): Now static.
3335 (adjust_after_replace_noundo): Remove; unused.
3336 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3337 (signal_before_change): Remove decls.
3339 * indent.c (val_compute_motion, val_vmotion): Now static.
3341 * image.c: Make symbols static if they're not exported.
3342 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3344 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3345 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3347 * fringe.c (standard_bitmaps): Now static.
3348 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3350 * frame.c: Make symbols static if they're not exported.
3351 (x_report_frame_params, make_terminal_frame): Now static.
3352 (get_frame_param): Now static, unless HAVE_NS.
3353 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3354 (x_get_resource_string): Remove; not used.
3355 * frame.h (make_terminal_frame, x_report_frame_params):
3356 (x_get_resource_string); Remove decls.
3357 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3358 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3360 * font.c, fontset.c: Make symbols static if they're not exported.
3361 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3362 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3363 * font.c (font_close_object): Now static.
3364 * font.h (font_close_object): Remove.
3365 * fontset.c (FONTSET_OBJLIST): Remove.
3366 (free_realized_fontset) #if-0 the body, which does nothing.
3367 (face_suitable_for_char_p): #if-0, as it's never called.
3368 * fontset.h (face_suitable_for_char_p): Remove decl.
3369 * xfaces.c (face_at_string_position):
3370 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3371 since 0 is always ASCII.
3373 * fns.c (weak_hash_tables): Now static.
3375 * fileio.c: Make symbols static if they're not exported.
3376 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3377 (Vwrite_region_annotation_buffers): Now static.
3379 * eval.c: Make symbols static if they're not exported.
3380 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3381 * lisp.h (backtrace_list): Remove decl.
3383 * emacs.c: Make symbols static if they're not exported.
3384 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3385 (fatal_error_code, fatal_error_signal_hook, standard_args):
3387 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3388 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3389 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3390 * lisp.h (fatal_error_signal_hook): Remove decl.
3391 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3393 * editfns.c: Move a (normally-unused) function to its only use.
3394 * editfns.c, lisp.h (get_operating_system_release): Remove.
3395 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3396 worth the hassle of breaking this out.
3398 * xterm.c: Make symbols static if they're not exported.
3399 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3400 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3401 (x_destroy_window, x_delete_display):
3403 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3404 (x_mouse_leave): Remove; unused.
3405 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3406 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3407 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3409 (x_mouse_leave): Declare only if WINDOWSNT.
3410 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3411 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3414 * ftxfont.c: Make symbols static if they're not exported.
3415 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3417 * font.h (ftxfont_driver): Likewise.
3419 * xfns.c: Make symbols static if they're not exported.
3420 (x_last_font_name, x_display_info_for_name):
3421 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3422 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3423 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3424 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3425 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3426 (last_show_tip_args): Now static.
3427 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3428 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3429 (x_screen_planes): Remove; unused.
3430 * dispextern.h (x_screen_planes): Remove decl.
3432 * dispnew.c: Make symbols static if they're not exported.
3433 * dispextern.h (redraw_garbaged_frames, scrolling):
3434 (increment_row_positions): Remove.
3435 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3436 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3438 (redraw_garbaged_frames): Remove; unused.
3440 * xfaces.c: Make symbols static if they're not exported.
3441 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3443 * xterm.h (defined_color): Remove decls.
3444 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3445 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3446 (menu_face_changed_default, defined_color, free_realized_face):
3447 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3448 (ascii_face_of_lisp_face): Remove; unused.
3450 * xdisp.c: Make symbols static if they're not exported.
3451 * dispextern.h (scratch_glyph_row, window_box_edges):
3452 (glyph_to_pixel_coords, set_cursor_from_row):
3453 (get_next_display_element, set_iterator_to_next):
3454 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3455 (show_mouse_face): Remove decls
3456 * frame.h (message_buf_print): Likewise.
3457 * lisp.h (pop_message, set_message, check_point_in_composition):
3459 * xterm.h (set_vertical_scroll_bar): Likewise.
3460 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3461 (message_buf_print, scratch_glyph_row, displayed_buffer):
3462 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3463 (get_next_display_element, show_mouse_face, window_box_edges):
3464 (frame_to_window_pixel_xy, check_point_in_composition):
3465 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3466 (glyph_to_pixel_coords): Remove; unused.
3468 * dired.c (file_name_completion): Now static.
3470 * dbusbind.c (xd_in_read_queued_messages): Now static.
3472 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3473 * data.c (circular_list_error): Remove.
3475 * commands.h (last_point_position, last_point_position_buffer):
3476 (last_point_position_window): Remove decls.
3477 * keyboard.c: Make these variables static.
3479 * coding.h (coding, code_convert_region, encode_coding_gap):
3481 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3482 (iso_code_class, detect_coding, code_convert_region): Now static.
3483 (encode_coding_gap): Remove; unused.
3485 * chartab.c (chartab_chars, chartab_bits): Now static.
3487 * charset.h (charset_iso_8859_1): Remove decl.
3488 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3491 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3492 * ccl.c (Vccl_program_table): Now static.
3493 (check_ccl_update): Remove; unused.
3495 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3496 * category.h: ... from here.
3497 * category.c (check_category_table, set_category_set): Now static.
3499 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3500 * lisp.h: Remove these decls.
3502 * buffer.c (buffer_count): Remove unused var.
3504 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3505 so that it's not optimized away.
3506 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3507 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3508 exported only to the debugger.
3510 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3511 * atimer.h (run_all_atimers): Remove; not exported.
3513 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3514 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3515 was inaccessible from Lisp.
3516 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3517 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3519 alloc.c: Import and export fewer symbols, and remove unused items.
3520 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3522 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3523 it's not optimized away by whole-program optimization.
3524 (message_enable_multibyte, free_misc): Remove.
3525 (catchlist, handlerlist, mark_backtrace):
3526 Declare only if BYTE_MARK_STACK.
3527 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3528 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3529 (message_enable_multibyte): Remove decl.
3530 (free_misc, interval_free_list, float_block, float_block_index):
3531 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3532 (cons_free_list, last_marked_index):
3534 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3535 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3536 (mark_backtrace): Define only if BYTE_MARK_STACK.
3537 * xdisp.c (message_enable_multibyte): Now static.
3539 Declare Lisp_Object Q* variables to be 'static' if not exported.
3540 This makes it easier for human readers (and static analyzers)
3541 to see whether these variables are used from other modules.
3542 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3543 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3544 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3545 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3546 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3547 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3548 * xmenu.c, xselect.c:
3549 Declare Q* vars static if they are not used in other modules.
3550 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3551 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3552 Remove decls of unexported vars.
3553 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3555 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3557 Make Emacs functions such as Fatom 'static' by default.
3558 This makes it easier for human readers (and static analyzers)
3559 to see whether these functions can be called from other modules.
3560 DEFUN now defines a static function. To make the function external
3561 so that it can be used in other C modules, use the new macro DEFUE.
3562 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3563 (Finit_image_library):
3564 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3565 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3566 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3567 Remove decls, since these functions are now static.
3568 (Funintern, Fget_internal_run_time): New decls, since these functions
3569 were already external.
3571 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3572 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3573 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3574 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3575 * keyboard.c, keymap.c, lread.c:
3576 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3577 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3578 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3579 Mark functions with DEFUE instead of DEFUN,
3580 if they are used in other modules.
3581 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3582 decls for now-static functions.
3583 * buffer.h (Fdelete_overlay): Remove decl.
3584 * callproc.c (Fgetenv_internal): Mark as internal.
3585 * composite.c (Fremove_list_of_text_properties): Remove decl.
3586 (Fcomposition_get_gstring): New forward static decl.
3587 * composite.h (Fcomposite_get_gstring): Remove decl.
3588 * dired.c (Ffile_attributes): New forward static decl.
3589 * doc.c (Fdocumntation_property): New forward static decl.
3590 * eval.c (Ffetch_bytecode): New forward static decl.
3591 (Funintern): Remove extern decl; now in .h file where it belongs.
3592 * fileio.c (Fmake_symbolic_link): New forward static decl.
3593 * image.c (Finit_image_library): New forward static decl.
3594 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3595 * intervals.h (Fprevious_property_change):
3596 (Fremove_list_of_text_properties): Remove decls.
3597 * keyboard.c (Fthis_command_keys): Remove decl.
3598 (Fcommand_execute): New forward static decl.
3599 * keymap.c (Flookup_key): New forward static decl.
3600 (Fcopy_keymap): Now static.
3601 * keymap.h (Flookup_key): Remove decl.
3602 * process.c (Fget_process): New forward static decl.
3603 (Fprocess_datagram_address): Mark as internal.
3604 * syntax.c (Fsyntax_table_p): New forward static decl.
3605 (skip_chars): Remove duplicate decl.
3606 * textprop.c (Fprevious_property_change): New forward static decl.
3607 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3609 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3610 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3612 * editfns.c (Fformat): Remove unreachable code.
3614 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3616 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3619 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3621 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3622 when at ZV. (Bug#8487)
3624 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3626 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3628 * keyboard.c (parse_tool_bar_item): Likewise.
3629 * sound.c (sound_cleanup, alsa_close): Likewise.
3630 * termcap.c (tgetent): Likewise.
3631 * xfns.c (x_default_font_parameter): Likewise.
3632 * xsettings.c (read_and_apply_settings): Likewise.
3634 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3635 (overrun_check_free): Protoize.
3637 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3639 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3640 since callers should never pass a negative size.
3641 Change the signature to match that of plain 'read' and 'write'; see
3642 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3643 * lisp.h: Update prototypes of emacs_write and emacs_read.
3645 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3647 * xdisp.c (redisplay_window): Don't try to determine the character
3648 position of the scroll margin if the window start point w->startp
3649 is outside the buffer's accessible region. (Bug#8468)
3651 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3653 Fix write-region and its subroutines for buffers > 2GB.
3654 * fileio.c (a_write, e_write): Modify declaration of arguments and
3655 local variables to support buffers larger than 2GB.
3656 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3658 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3659 argument, local variables, and return value.
3661 * lisp.h: Update prototypes of emacs_write and emacs_read.
3663 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3665 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3667 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3669 Fix more problems found by GCC 4.6.0's static checks.
3671 * xdisp.c (vmessage): Use a better test for character truncation.
3673 * charset.c (load_charset_map): <, not <=, for optimization,
3674 and to avoid potential problems with integer overflow.
3675 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3676 * casetab.c (set_identity, shuffle): Likewise.
3677 * editfns.c (Fformat): Likewise.
3678 * syntax.c (skip_chars): Likewise.
3680 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3681 This also lets GCC 4.6.0 generate slightly better loop code.
3683 * callint.c (Fcall_interactively): <, not <=, for optimization.
3684 (Fcall_interactively): Count the number of arguments produced,
3685 not the number of arguments given. This is simpler and lets GCC
3686 4.6.0 generate slightly better code.
3688 * ftfont.c: Distingish more carefully between FcChar8 and char.
3689 The previous code passed unsigned char * to a functions like
3690 strlen and xstrcasecmp that expect char *, which does not
3691 conform to the C standard.
3692 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3693 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3694 char * when the C standard requires it.
3696 * keyboard.c (read_char): Remove unused var.
3698 * eval.c: Port to Windows vsnprintf (Bug#8435).
3700 (SIZE_MAX): Define if the headers do not.
3701 (verror): Do not give up if vsnprintf returns a negative count.
3702 Instead, grow the buffer. This ports to Windows vsnprintf, which
3703 does not conform to C99. Problem reported by Eli Zaretskii.
3704 Also, simplify the allocation scheme, by avoiding the need for
3705 calling realloc, and removing the ALLOCATED variable.
3707 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3709 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3710 But keep the doprint source code for now, as we might revamp it
3711 and use it again (Bug#8435).
3712 * lisp.h (doprnt): Remove.
3713 * Makefile.in (base_obj): Remove doprnt.o.
3714 * deps.mk (doprnt.o): Remove.
3716 error: Print 32- and 64-bit integers portably (Bug#8435).
3717 Without this change, on typical 64-bit hosts error ("...%d...", N)
3718 was used to print both 32- and 64-bit integers N, which relied on
3720 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3722 * lisp.h (error, verror): Mark as printf-like functions.
3723 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3724 Report overflow in size calculations when allocating printf buffer.
3725 Do not truncate output string at its first null byte.
3726 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3727 Truncate the output at a character boundary, since vsnprintf does not
3729 * charset.c (check_iso_charset_parameter): Convert internal
3730 character to string before calling 'error', since %c now has the
3732 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3733 overflow when computing char to be passed to 'error'. Do not
3734 pass Lisp_Object to 'error'; pass the integer instead.
3735 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3736 formatted with plain %d.
3738 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3740 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3742 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3744 * xterm.c (x_catch_errors): Remove duplicate declaration.
3746 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3748 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3750 2011-04-10 Jim Meyering <meyering@redhat.com>
3752 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3753 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3754 return ssize_t not "int", and use size_t as the buffer length.
3755 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3756 * gnutls.h: Update declarations.
3757 * process.c (read_process_output): Use ssize_t, to match.
3758 (send_process): Likewise.
3760 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3762 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3764 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3766 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3767 Use unsigned char, to match FcChar8 type definition.
3769 * xterm.c (handle_one_xevent):
3770 * xmenu.c (create_and_show_popup_menu):
3771 * xselect.c (x_decline_selection_request)
3772 (x_reply_selection_request): Avoid type-punned deref of X events.
3774 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3776 Fix some uses of `int' instead of EMACS_INT.
3777 * search.c (string_match_1, fast_string_match)
3778 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3779 (scan_buffer, find_next_newline_no_quit)
3780 (find_before_next_newline, search_command, Freplace_match)
3781 (Fmatch_data): Make some `int' variables be EMACS_INT.
3783 * xdisp.c (display_count_lines): 3rd argument and return value now
3784 EMACS_INT. All callers changed.
3785 (pint2hrstr): Last argument is now EMACS_INT.
3787 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3788 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3789 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3790 (decode_coding_utf_16, decode_coding_emacs_mule)
3791 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3792 (decode_coding_ccl, decode_coding_charset)
3793 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3794 (decode_coding_iso_2022, decode_coding_emacs_mule)
3795 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3796 <char_offset, last_offset>: Declare EMACS_INT.
3797 (encode_coding_utf_8, encode_coding_utf_16)
3798 (encode_coding_emacs_mule, encode_invocation_designation)
3799 (encode_designation_at_bol, encode_coding_iso_2022)
3800 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3801 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3803 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3804 (encode_invocation_designation): Last argument P_NCHARS is now
3806 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3807 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3809 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3812 * ccl.c (Fccl_execute_on_string): Declare some variables
3815 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3817 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3819 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3821 * process.c (Fformat_network_address): Doc fix.
3823 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3825 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3827 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3829 * keyboard.c (read_char): Call Lisp function help-form-show,
3830 instead of using internal_with_output_to_temp_buffer.
3831 (Qhelp_form_show): New var.
3832 (syms_of_keyboard): Use DEFSYM macro.
3834 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3836 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3838 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3840 * process.c (Flist_processes): Remove to Lisp.
3841 (list_processes_1): Delete.
3843 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3845 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3847 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3849 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3851 Fix more problems found by GCC 4.6.0's static checks.
3853 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3855 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3857 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3859 * xdisp.c (vmessage): Mark as a printf-like function.
3861 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3863 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3865 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3866 printf-like functions.
3867 (tiff_load): Add casts to remove these marks before passing them
3868 to system-supplied API.
3870 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3872 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3873 This avoids several warnings with gcc -Wstrict-overflow.
3874 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3875 directly, rather than having caller test rule sign. This avoids
3876 some unnecessary tests.
3877 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3878 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3879 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3881 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3882 (xfont_open): Avoid unnecessary tests.
3884 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3886 * composite.h, composite.c (composition_gstring_put_cache):
3887 Use EMACS_INT, not int, for length.
3889 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3890 breaking out part of COMPOSITION_DECODE_RULE.
3891 (COMPOSITION_DECODE_RULE): Use it.
3892 * composite.c (get_composition_id): Remove unused local vars,
3893 by using the new macro.
3895 * textprop.c (set_text_properties_1): Change while to do-while,
3896 since the condition is always true at first.
3898 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3899 (interval_deletion_adjustment): Return unsigned value.
3902 * process.c (list_processes_1, create_pty, read_process_output):
3903 (exec_sentinel): Remove vars that were set but not used.
3904 (create_pty): Remove unnecessary "volatile"s.
3905 (Fnetwork_interface_info): Avoid possibility of int overflow.
3906 (read_process_output): Do adaptive read buffering even if carryover.
3907 (read_process_output): Simplify nbytes computation if buffered.
3909 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3911 * syntax.c (scan_words): Remove var that was set but not used.
3912 (update_syntax_table): Use unsigned instead of int.
3914 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3915 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3916 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3918 * print.c (print_error_message): Avoid int overflow.
3920 * font.c (font_list_entities): Redo for clarity,
3921 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3923 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3924 (font_score): Avoid potential overflow in diff calculation.
3926 * fns.c (substring_both): Remove var that is set but not used.
3927 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3929 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3931 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3932 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3933 can always succeed if overflow has undefined behavior.
3935 * search.c (boyer_moore, wordify): Remove vars set but not used.
3936 (wordify): Omit three unnecessary tests.
3938 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3939 All callers changed. This avoids the need for an unused var.
3941 * casefiddle.c (casify_region): Remove var that is set but not used.
3943 * dired.c (file_name_completion): Remove var that is set but not used.
3945 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3947 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3948 (Finsert_file_contents): Remove unnecessary code checking fd.
3950 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3951 Check for integer overflow on size calculations.
3953 * buffer.c (Fprevious_overlay_change): Remove var that is set
3956 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3957 Remove vars that are set but not used.
3958 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3959 (timer_check_2): Mark vars as initialized.
3961 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3963 * image.c (lookup_image): Remove var that is set but not used.
3964 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3966 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3967 that are set but not used.
3969 * xfns.c (make_invisible_cursor): Don't return garbage
3970 if XCreateBitmapFromData fails (Bug#8410).
3972 * xselect.c (x_get_local_selection, x_handle_property_notify):
3973 Remove vars that are set but not used.
3975 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3976 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3978 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3979 Remove var that is set but not used.
3980 (scroll_bar_windows_size): Now size_t, not int.
3981 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3984 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3985 (map_tty_color) [!defined MSDOS]: Likewise.
3987 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3989 * coding.c: Remove vars that are set but not used.
3990 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3991 All callers changed.
3992 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3993 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3994 (decode_coding_charset): Remove vars that are set but not used.
3996 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3997 that is set but not used.
3999 * print.c (print_object): Remove var that is set but not used.
4001 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4002 The gnulib version avoids calling malloc in the usual case,
4003 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4004 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4005 * filelock.c (current_lock_owner): Likewise.
4006 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4007 * sysdep.c: Include allocator.h, careadlinkat.h.
4008 (emacs_no_realloc_allocator): New static constant.
4009 (emacs_readlink): New function.
4010 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4011 ../lib/careadlinkat.h.
4013 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4015 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4016 first non-nil return value).
4018 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4020 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4021 if not defined (Bug#8403).
4023 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4025 * xdisp.c (display_count_lines): Remove parameter `start',
4026 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4027 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4028 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4029 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4030 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4031 and thereabouts. All callers changed.
4032 (get_per_char_metric): Remove parameter `f', unused since
4033 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4035 2011-04-02 Jim Meyering <meyering@redhat.com>
4037 do not dereference NULL upon failed strdup
4038 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4039 (ns_get_family): Likewise.
4041 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4043 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4045 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4047 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4050 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4052 Add lexical binding.
4054 * window.c (Ftemp_output_buffer_show): New fun.
4055 (Fsave_window_excursion):
4056 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4058 * lread.c (lisp_file_lexically_bound_p): New function.
4059 (Fload): Bind Qlexical_binding.
4060 (readevalloop): Remove `evalfun' arg.
4061 Bind Qinternal_interpreter_environment.
4062 (Feval_buffer): Bind Qlexical_binding.
4063 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4065 (syms_of_lread): Declare `lexical-binding'.
4067 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4069 * keyboard.c (eval_dyn): New fun.
4070 (menu_item_eval_property): Use it.
4072 * image.c (parse_image_spec): Use Ffunctionp.
4074 * fns.c (concat, mapcar1): Accept byte-code-functions.
4076 * eval.c (Fsetq): Handle lexical vars.
4077 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4078 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4079 (FletX, Flet): Obey lexical binding.
4080 (Fcommandp): Handle closures.
4081 (Feval): New `lexical' arg.
4082 (eval_sub): New function extracted from Feval. Use it almost
4083 everywhere where Feval was used. Look up vars in lexical env.
4085 (Ffunctionp): Move from subr.el.
4086 (Ffuncall): Handle closures.
4087 (apply_lambda): Remove `eval_flags'.
4088 (funcall_lambda): Handle closures and new byte-code-functions.
4089 (Fspecial_variable_p): New function.
4090 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4091 but without exporting it to Lisp.
4093 * doc.c (Fdocumentation, store_function_docstring):
4094 * data.c (Finteractive_form): Handle closures.
4096 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4099 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4101 (exec_byte_code): New function extracted from Fbyte_code to handle new
4102 calling convention for byte-code-functions. Add new byte-codes.
4104 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4106 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4108 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4110 * xdisp.c (redisplay_internal): Fix prototype.
4112 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4114 * xdisp.c (SCROLL_LIMIT): New macro.
4115 (try_scrolling): Use it when setting scroll_limit.
4116 Limit scrolling to 100 screen lines.
4117 (redisplay_window): Even when falling back on "recentering",
4118 position point in the window according to scroll-conservatively,
4119 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4121 (try_scrolling): When point is above the window, allow searching
4122 as far as scroll_max, or one screenful, to compute vertical
4123 distance from PT to the scroll margin position. This prevents
4124 try_scrolling from unnecessarily failing when
4125 scroll-conservatively is set to a value slightly larger than the
4126 window height. Clean up the case of PT below the margin at bottom
4127 of window: scroll_max can no longer be INT_MAX. When aggressive
4128 scrolling is in use, don't let point enter the opposite scroll
4129 margin as result of the scroll.
4130 (syms_of_xdisp) <scroll-conservatively>: Document the
4131 threshold of 100 lines for never-recentering scrolling.
4133 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4135 * dispextern.h (move_it_by_lines):
4136 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4137 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4138 (message_log_check_duplicate): Remove parameters `prev_bol' and
4139 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4140 (redisplay_internal): Remove parameter `preserve_echo_area',
4141 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4143 * indent.c (Fvertical_motion):
4144 * window.c (window_scroll_pixel_based, Frecenter):
4145 Don't pass `need_y_p' to `move_it_by_lines'.
4147 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4149 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4150 steal a few bits to be more compact.
4151 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4152 Remove unneeded casts.
4154 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4156 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4158 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4159 binding" message (bug#7967).
4161 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4163 Fix more problems found by GCC 4.6.0's static checks.
4165 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4166 Remove unused local var.
4168 * editfns.c (Fmessage_box): Remove unused local var.
4170 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4171 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4172 Omit unused local vars.
4173 * window.c (shrink_windows): Omit unused local var.
4174 * menu.c (digest_single_submenu): Omit unused local var.
4175 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4176 Omit unused local var.
4178 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4179 Don't assume string length fits in int.
4180 (keyremap_step, read_key_sequence): Use size_t for sizes.
4181 (read_key_sequence): Don't check last_real_key_start redundantly.
4183 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4184 instead of alloca (Bug#8344).
4186 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4187 (Fbacktrace_frame): Don't assume nframes fits in int.
4189 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4191 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4194 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4196 * cm.c (calccost): Turn while-do into do-while, for clarity.
4198 * keyboard.c (syms_of_keyboard): Use the same style as later
4199 in this function when indexing through an array. This also
4200 works around GCC bug 48267.
4202 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4204 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4206 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4207 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4209 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4210 This avoids undefined behavior on integer overflow, and is a bit
4211 more convenient anyway since it is compared to a size_t variable.
4213 Variadic C functions now count arguments with size_t, not int.
4214 This avoids an unnecessary limitation on 64-bit machines, which
4215 caused (substring ...) to crash on large vectors (Bug#8344).
4216 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4217 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4218 All variadic functions and their callers changed accordingly.
4219 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4220 * data.c (arith_driver, float_arith_driver): Likewise.
4221 * editfns.c (general_insert_function): Likewise.
4222 * eval.c (struct backtrace.nargs, interactive_p)
4223 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4224 (funcall_lambda, mark_backtrace): Likewise.
4225 * fns.c (concat): Likewise.
4226 * frame.c (x_set_frame_parameters): Likewise.
4227 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4228 0 if not found, not -1. All callers changed.
4230 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4231 (stack_copy_size): Now size_t, not int.
4232 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4234 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4236 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4237 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4238 All callers changed.
4240 * lisp.h (multibyte_char_to_unibyte):
4241 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4242 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4243 * character.h (CHAR_TO_BYTE8):
4244 * cmds.c (internal_self_insert):
4245 * editfns.c (general_insert_function):
4246 * keymap.c (push_key_description):
4247 * search.c (Freplace_match):
4248 * xdisp.c (message_dolog, set_message_1): All callers changed.
4250 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4252 * keyboard.c (safe_run_hook_funcall): New function.
4253 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4254 don't set the hook to nil, but remove the offending function instead.
4255 (Qcommand_hook_internal): Remove, unused.
4256 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4257 Vcommand_hook_internal.
4259 * eval.c (enum run_hooks_condition): Remove.
4260 (funcall_nil, funcall_not): New functions.
4261 (run_hook_with_args): Call each function through a `funcall' argument.
4262 Remove `cond' argument, now redundant.
4263 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4264 (Frun_hook_with_args_until_failure): Adjust accordingly.
4265 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4267 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4269 * dispextern.h (string_buffer_position): Remove declaration.
4271 * print.c (strout): Remove parameter `multibyte', unused since
4272 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4274 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4275 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4276 All callers changed.
4278 * w32.c (_wsa_errlist): Use braces for struct initializers.
4280 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4281 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4282 All callers changed.
4283 (string_buffer_position): Likewise. Also, make static (it's never
4284 used outside xdisp.c).
4285 (cursor_row_p): Remove parameter `w', unused since
4286 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4287 (decode_mode_spec): Remove parameter `precision', introduced during
4288 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4289 All callers changed.
4291 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4293 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4295 2011-03-27 Anders Lindgren <andlind@gmail.com>
4297 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4298 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4299 (ns_update_auto_hide_menu_bar): New functions.
4300 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4301 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4302 ns_constrain_all_frames.
4303 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4304 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4306 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4308 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4310 2011-03-27 Glenn Morris <rgm@gnu.org>
4312 * syssignal.h: Replace RETSIGTYPE with void.
4313 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4314 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4315 Replace SIGTYPE with void everywhere.
4316 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4317 * s/template.h (SIGTYPE): Remove commented out definition.
4319 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4321 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4322 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4324 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4326 * w32.c (read_unc_volume): Use parameter `henum', instead of
4327 global variable `wget_enum_handle'.
4329 * keymap.c (describe_vector): Remove parameters `indices' and
4330 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4331 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4333 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4335 * keyboard.c (timer_check): Remove parameter `do_it_now',
4336 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4337 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4338 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4340 * keyboard.c (read_char):
4341 * w32menu.c (w32_menu_display_help):
4342 * xmenu.c (show_help_event, menu_help_callback):
4343 Adjust calls to `show_help_echo'.
4345 * gtkutil.c (xg_maybe_add_timer):
4346 * keyboard.c (readable_events):
4347 * process.c (wait_reading_process_output):
4348 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4350 * insdel.c (adjust_markers_gap_motion):
4351 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4352 (gap_left, gap_right): Don't call it.
4354 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4356 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4357 incurred during fontification.
4359 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4361 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4362 (DEFVAR_PER_BUFFER): Don't pass it.
4364 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4365 (scrolling_window): Don't pass it.
4367 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4369 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4371 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4373 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4374 of variables specific to SELinux and computation of `encoded_absname'.
4376 * image.c (XPutPixel): Remove unused variable `height'.
4378 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4380 * unexw32.c (get_section_info): Remove unused variable `section'.
4382 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4383 (system_process_attributes): Remove unused variable `sess'.
4384 (sys_read): Remove unused variable `err'.
4386 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4387 (w32_wnd_proc): Remove unused variable `isdead'.
4388 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4389 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4390 (x_create_tip_frame): Remove unused variable `tem'.
4392 * w32inevt.c (w32_console_read_socket):
4393 Remove unused variable `no_events'.
4395 * w32term.c (x_draw_composite_glyph_string_foreground):
4396 Remove unused variable `width'.
4398 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4400 * w32term.c (x_set_glyph_string_clipping):
4401 Don't pass uninitialized region to CombineRgn.
4403 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4405 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4406 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4407 (Fx_close_connection): Remove unused variable `i'.
4409 * w32font.c (w32font_draw): Return number of glyphs.
4410 (w32font_open_internal): Remove unused variable `i'.
4411 (w32font_driver): Add missing initializer.
4413 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4414 (fill_in_menu): Remove unused variable `items_added'.
4416 * w32term.c (last_mouse_press_frame): Remove static global variable.
4417 (w32_clip_to_row): Remove unused variable `f'.
4418 (x_delete_terminal): Remove unused variable `i'.
4420 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4421 (NOTHING): Remove unused static global variable.
4422 (uniscribe_check_otf): Remove unused variable `table'.
4423 (uniscribe_font_driver): Add missing initializers.
4425 2011-03-23 Julien Danjou <julien@danjou.info>
4427 * term.c (Fsuspend_tty, Fresume_tty):
4428 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4429 * window.c (temp_output_buffer_show):
4430 * insdel.c (signal_before_change):
4431 * frame.c (Fhandle_switch_frame):
4432 * fileio.c (Fdo_auto_save):
4433 * emacs.c (Fkill_emacs):
4434 * editfns.c (save_excursion_restore):
4435 * cmds.c (internal_self_insert):
4436 * callint.c (Fcall_interactively):
4437 * buffer.c (Fkill_all_local_variables):
4438 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4440 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4441 unconditionnaly since it does the check itself.
4443 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4445 Fix more problems found by GCC 4.5.2's static checks.
4447 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4448 the first time through the loop, since we know p0 < p1 then.
4449 This also avoids a gcc -Wstrict-overflow warning.
4451 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4452 leading to a memory leak, possible in functions like
4453 load_charset_map_from_file that can allocate an unbounded number
4454 of objects (Bug#8318).
4456 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4457 that could (at least in theory) be that large.
4459 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4460 This is less likely to overflow, and avoids undefined behavior if
4461 overflow does occur. All callers changed. Use strtoul to scan
4462 for the unsigned long integer.
4463 (pint2hrstr): Simplify and tune code slightly.
4464 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4466 * scroll.c (do_scrolling): Work around GCC bug 48228.
4467 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4469 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4470 This also avoids a warning with gcc -Wstrict-overflow.
4471 (validate_x_resource_name): Simplify count usage.
4472 This also avoids a warning with gcc -Wstrict-overflow.
4474 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4477 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4479 * process.c (Fmake_network_process): Use socklen_t, not int,
4480 where POSIX says socklen_t is required in portable programs.
4481 This fixes a porting bug on hosts like 64-bit HP-UX, where
4482 socklen_t is wider than int (Bug#8277).
4483 (Fmake_network_process, server_accept_connection):
4484 (wait_reading_process_output, read_process_output):
4487 * process.c: Rename or move locals to avoid shadowing.
4488 (list_processes_1, Fmake_network_process):
4489 (read_process_output_error_handler, exec_sentinel_error_handler):
4490 Rename or move locals.
4491 (Fmake_network_process): Define label "retry_connect" only if needed.
4492 (Fnetwork_interface_info): Fix pointer signedness.
4493 (process_send_signal): Add cast to avoid pointer signedness problem.
4494 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4495 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4497 Make tparam.h and terminfo.c consistent.
4498 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4499 Include tparam.h instead, since it declares them.
4500 * cm.h (PC): Remove extern decl; tparam.h now does this.
4501 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4502 * terminfo.c: Include tparam.h, to check interfaces.
4503 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4504 (tparam): Adjust signature to match interface in tparam.h;
4505 this removes some undefined behavior. Check that outstring and len
4506 are zero, which they always are with Emacs.
4507 * tparam.h (PC, BC, UP): New extern decls.
4509 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4510 (xftfont_open): Rename locals to avoid shadowing.
4512 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4513 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4514 (OTF_TAG_SYM): Omit macro if not needed.
4515 (ftfont_list): Remove unused local.
4516 (get_adstyle_property, ftfont_pattern_entity):
4517 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4518 Rename locals to avoid shadowing.
4520 * xfont.c (xfont_list_family): Mark var as initialized.
4522 * xml.c (make_dom): Now static.
4524 * composite.c (composition_compute_stop_pos): Rename local to
4526 (composition_reseat_it): Remove unused locals.
4527 (find_automatic_composition, composition_adjust_point): Likewise.
4528 (composition_update_it): Mark var as initialized.
4529 (find_automatic_composition): Mark vars as initialized,
4530 with a FIXME (Bug#8290).
4532 character.h: Rename locals to avoid shadowing.
4533 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4534 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4535 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4536 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4539 * textprop.c (property_change_between_p): Remove; unused.
4541 * intervals.c (interval_start_pos): Now static.
4543 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4545 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4546 Rename locals to avoid shadowing.
4548 * sound.c (wav_play, au_play, Fplay_sound_internal):
4549 Fix pointer signedness.
4550 (alsa_choose_format): Remove unused local var.
4551 (wav_play): Initialize a variable to 0, to prevent undefined
4552 behavior (Bug#8278).
4554 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4556 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4558 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4559 clobbering (Bug#8298).
4560 * sysdep.c (sys_subshell): Likewise.
4561 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4563 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4564 This should get cleaned up, so that child_setup has the
4565 same signature on all platforms.
4567 * callproc.c (call_process_cleanup): Now static.
4568 (relocate_fd): Rename locals to avoid shadowing.
4570 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4572 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4573 not to be necessary, and produces flickering.
4575 2011-03-20 Glenn Morris <rgm@gnu.org>
4577 * config.in: Remove file.
4579 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4581 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4582 are now in src/globals.h.
4583 (syms_of_minibuf): Remove spurious & from previous change.
4585 2011-03-20 Leo <sdl.web@gmail.com>
4587 * minibuf.c (completing-read-function): New variable.
4588 (completing-read-default): Rename from completing-read.
4589 (completing-read): Call completing-read-function.
4591 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4593 * xfaces.c (Fx_load_color_file):
4594 Read color file from absolute filename (bug#8250).
4596 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4598 * makefile.w32-in: Update dependencies.
4600 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4602 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4604 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4606 Fix more problems found by GCC 4.5.2's static checks.
4608 * process.c (make_serial_process_unwind, send_process_trap):
4609 (sigchld_handler): Now static.
4611 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4612 That way, the code declares only the vars that it needs.
4613 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4614 * s/cygwin.h (PTY_ITERATION): Likewise.
4615 * s/darwin.h (PTY_ITERATION): Likewise.
4616 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4618 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4619 * process.c (allocate_pty): Don't declare stb unless it's needed.
4621 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4622 (CONSTANTLIM): Remove; unused.
4623 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4624 Define only if needed.
4626 * unexelf.c (unexec): Name an expression,
4627 to avoid gcc -Wbad-function-cast warning.
4628 Use a different way to cause a compilation error if anyone uses
4629 n rather than nn, a way that does not involve shadowing.
4630 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4632 * deps.mk (unexalpha.o): Remove; unused.
4634 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4635 * unexec.h: New file.
4636 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4637 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4639 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4640 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4641 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4642 Change as necessary to match prototype in unexec.h.
4644 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4646 (back_comment, skip_chars): Mark vars as initialized.
4648 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4649 Rename locals to avoid shadowing.
4651 * lread.c (read1): Rewrite so as not to use empty "else".
4652 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4654 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4656 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4657 warning when compiling print.c.
4659 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4660 instead of using an uninitialized var.
4661 (font_sort_entities): Mark var as initialized.
4663 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4665 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4666 pointers to constants.
4667 (font_parse_fcname): Remove unused vars.
4668 (font_delete_unmatched): Now static.
4669 (font_get_spec): Remove; unused.
4670 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4671 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4672 Rename or move locals to avoid shadowing.
4674 * fns.c (require_nesting_list, require_unwind): Now static.
4675 (Ffillarray): Rename locals to avoid shadowing.
4677 * floatfns.c (domain_error2): Define only if needed.
4678 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4680 * alloc.c (mark_backtrace): Move decl from here ...
4681 * lisp.h: ... to here, so that it can be checked.
4683 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4684 (Fdefvar): Rewrite so as not to use empty "else".
4685 (lisp_indirect_variable): Name an expression,
4686 to avoid gcc -Wbad-function-cast warning.
4687 (Fdefvar): Rename locals to avoid shadowing.
4689 * callint.c (quotify_arg, quotify_args): Now static.
4690 (Fcall_interactively): Rename locals to avoid shadowing.
4691 Use const pointer when appropriate.
4693 * lisp.h (get_system_name, get_operating_system_release):
4694 Move decls here, to check interfaces.
4695 * process.c (get_operating_system_release): Move decl to lisp.h.
4696 * xrdb.c (get_system_name): Likewise.
4697 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4698 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4699 some of which prompt warnings from gcc -Wbad-function-cast.
4700 (Fformat_time_string, Fencode_time, Finsert_char):
4701 (Ftranslate_region_internal, Fformat):
4702 Rename or remove local vars to avoid shadowing.
4703 (Ftranslate_region_internal): Mark var as initialized.
4705 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4708 * lisp.h (eassert): Check that the argument compiles, even if
4709 ENABLE_CHECKING is not defined.
4711 * data.c (Findirect_variable): Name an expression, to avoid
4712 gcc -Wbad-function-cast warning.
4713 (default_value, arithcompare, arith_driver, arith_error): Now static.
4714 (store_symval_forwarding): Rename local to avoid shadowing.
4715 (Fmake_variable_buffer_local, Fmake_local_variable):
4716 Mark variables as initialized.
4717 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4719 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4720 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4721 Rename locals to avoid shadowing.
4722 (mark_stack): Move local variables into the #ifdef region where
4724 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4725 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4727 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4728 (GC_STRING_CHARS): Remove; not used.
4729 (Fmemory_limit): Cast sbrk's returned value to char *.
4731 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4732 avoids undefined behavior in theory.
4734 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4736 Use functions, not macros, for up- and down-casing (Bug#8254).
4737 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4738 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4739 to use the following functions instead of these macros.
4740 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4741 EMACS_INT, since callers assume the returned value fits in int.
4742 (upcase1): Likewise, for UPCASE_TABLE.
4743 (uppercasep, lowercasep, upcase): New static inline functions.
4744 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4745 the race-condition problem in the old DOWNCASE.
4747 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4748 Rename locals to avoid shadowing.
4749 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4750 (regex_compile, re_search_2, re_match_2_internal):
4751 Remove unused local vars.
4752 (FREE_VAR): Rewrite so as not to use empty "else",
4753 which gcc can warn about.
4754 (regex_compile, re_match_2_internal): Mark locals as initialized.
4755 (RETALLOC_IF): Define only if needed.
4756 (WORDCHAR_P): Likewise. This one is never needed, but is used
4757 only in a comment talking about a compiler bug, so put inside
4758 the #if 0 of that comment.
4759 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4760 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4763 * search.c (boyer_moore): Rename locals to avoid shadowing.
4764 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4765 (PREV_CHAR_BOUNDARY): Likewise.
4767 * search.c (simple_search): Remove unused var.
4769 * dired.c (compile_pattern): Move decl from here ...
4770 * lisp.h: ... to here, so that it can be checked.
4771 (struct re_registers): New forward decl.
4773 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4775 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4777 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4778 Rename locals to avoid shadowing.
4779 (Fvertical_motion): Mark locals as initialized.
4781 * casefiddle.c (casify_object, casify_region): Now static.
4782 (casify_region): Mark local as initialized.
4784 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4786 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4787 New macros, so that the caller can use some names other than
4788 gcpro1, gcpro2, etc.
4789 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4791 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4792 argument, for consistency with GCPRO2_VAR, etc: it is now the
4793 prefix of the variable, not the variable itself. All uses
4795 * dired.c (directory_files_internal, file_name_completion):
4796 Rename locals to avoid shadowing.
4798 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4799 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4800 dired.c's scmp function, had undefined behavior.
4801 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4802 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4803 * buffer.h: ... to here, because these macros use current_buffer,
4804 and the new implementation with inline functions needs to have
4805 current_buffer in scope now, rather than later when the macros
4807 (downcase, upcase1): New static inline functions.
4808 (DOWNCASE, UPCASE1): Reimplement using these functions.
4809 This avoids undefined behavior in expressions like
4810 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4811 from race conditions in accessing the global variables
4812 case_temp1 and case_temp2.
4813 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4814 * lisp.h (case_temp1, case_temp2): Remove their decls.
4815 * character.h (ASCII_CHAR_P): Move from here ...
4816 * lisp.h: ... to here, so that the inline functions mentioned
4819 * dired.c (directory_files_internal_unwind): Now static.
4821 * fileio.c (file_name_as_directory, directory_file_name):
4822 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4824 (file_name_as_directory): Use const pointers when appropriate.
4825 (Fexpand_file_name): Likewise. In particular, newdir might
4826 point at constant storage, so make it a const pointer.
4827 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4828 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4830 (Fset_file_times, Finsert_file_contents, auto_save_error):
4831 Rename locals to avoid shadowing.
4833 * minibuf.c (choose_minibuf_frame_1): Now static.
4834 (Ftry_completion, Fall_completions): Rename or remove locals
4837 * marker.c (bytepos_to_charpos): Remove; unused.
4839 * lisp.h (verify_bytepos, count_markers): New decls,
4840 so that gcc does not warn that these functions aren't declared.
4842 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4843 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4844 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4845 (copy_text): Remove unused local var.
4847 * filelock.c (within_one_second): Now static.
4848 (lock_file_1): Rename local to avoid shadowing.
4850 * buffer.c (fix_overlays_before): Mark locals as initialized.
4851 (fix_start_end_in_overlays): Likewise. This function should be
4852 simplified by using pointers-to-pointers, but that's a different
4854 (switch_to_buffer_1): Now static.
4855 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4856 (report_overlay_modification): Rename locals to avoid shadowing.
4858 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4859 Fix pointer signedness issue.
4860 (sys_subshell): Mark local as volatile if checking for lint,
4861 to suppress a gcc -Wclobbered warning that does not seem to be right.
4862 (MAXPATHLEN): Define only if needed.
4864 * process.c (serial_open, serial_configure): Move decls from here ...
4865 * systty.h: ... to here, so that they can be checked.
4867 * fns.c (get_random, seed_random): Move extern decls from here ...
4868 * lisp.h: ... to here, so that they can be checked.
4870 * sysdep.c (reset_io): Now static.
4871 (wait_for_termination_signal): Remove; unused.
4873 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4874 (copy_keymap_item, append_key, push_text_char_description):
4876 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4877 (DENSE_TABLE_SIZE): Remove; unused.
4878 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4879 (describe_map_tree):
4880 Rename locals to avoid shadowing.
4882 * keyboard.c: Declare functions static if they are not used elsewhere.
4883 (echo_char, echo_dash, cmd_error, top_level_2):
4884 (poll_for_input, handle_async_input): Now static.
4885 (read_char, kbd_buffer_get_event, make_lispy_position):
4886 (make_lispy_event, make_lispy_movement, apply_modifiers):
4887 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4888 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4889 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4890 (read_key_sequence, read_char): Mark locals as initialized.
4891 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4893 * keyboard.h (make_ctrl_char): New decl.
4894 (mark_kboards): Move decl here ...
4895 * alloc.c (mark_kboards): ... from here.
4897 * lisp.h (force_auto_save_soon): New decl.
4899 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4900 (DEFINE_DUMMY_FUNCTION): New macro.
4901 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4903 (main): Add casts to avoid warnings
4904 if GCC considers string literals to be constants.
4906 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4908 * dbusbind.c: Pointer signedness fixes.
4909 (xd_signature, xd_append_arg, xd_initialize):
4910 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4911 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4912 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4913 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4915 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4916 if GCC considers string literals to be constants.
4917 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4919 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4921 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4922 (print_preprocess, print_object): New macro to fix last change.
4924 * print.c (print_preprocess): Don't forget font objects.
4926 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4928 * emacs.c (USAGE3): Doc fixes.
4930 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4932 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4935 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4937 * lisp.h (VWindow_system, Qfile_name_history):
4938 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4939 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4940 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4942 * w32select.c: Don't #include "keyboard.h".
4943 (run_protected): Add extern declaration for waiting_for_input.
4945 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4946 * w32console.c (detect_input_pending, read_input_pending)
4947 (encode_terminal_code):
4948 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4949 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4950 (w32_system_caret_y, Qfile_name_history):
4951 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4952 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4953 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4954 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4955 * w32proc.c (Qlocal, report_file_error):
4956 * w32term.c (Vwindow_system, updating_frame):
4957 * w32uniscribe.c (initialized, uniscribe_font_driver):
4958 Remove unneeded extern declarations.
4960 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4962 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4964 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4966 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4967 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4968 These macros can no longer be used for assignment.
4970 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4971 Assign struct members directly, instead of using BUF_BEGV etc.
4972 (record_buffer_markers, fetch_buffer_markers): New functions for
4973 recording and fetching special buffer markers.
4974 (set_buffer_internal_1, set_buffer_temp): Use them.
4976 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4978 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4980 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4981 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4983 * xdisp.c (hscroll_window_tree):
4984 (reconsider_clip_changes): Use PT instead of BUF_PT.
4986 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4988 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4989 $(EMACS_ROOT)/lib/intprops.h.
4991 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4993 Fix more problems found by GCC 4.5.2's static checks.
4995 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4996 to unsigned char * to avoid compiler diagnostic.
4997 (xg_free_frame_widgets): Make it clear that a local variable is
4998 needed only if USE_GTK_TOOLTIP.
4999 (gdk_window_get_screen): Make it clear that this macro is needed
5000 only if USE_GTK_TOOLTIP.
5001 (int_gtk_range_get_value): New function, which avoids a diagnostic
5002 from gcc -Wbad-function-cast.
5003 (xg_set_toolkit_scroll_bar_thumb): Use it.
5004 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5005 diagnostic from gcc -Wbad-function-cast.
5006 (get_utf8_string, xg_get_file_with_chooser):
5007 Rename locals to avoid shadowing.
5008 (create_dialog): Move locals to avoid shadowing.
5010 * xgselect.c (xg_select): Remove unused var.
5012 * image.c (four_corners_best): Mark locals as initialized.
5013 (gif_load): Initialize transparent_p to zero (Bug#8238).
5014 Mark another local as initialized.
5015 (my_png_error, my_error_exit): Mark with NO_RETURN.
5017 * image.c (clear_image_cache): Now static.
5018 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5019 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5020 (x_edge_detection): Remove unnecessary cast that
5021 gcc -Wbad-function-cast diagnoses.
5022 (gif_load): Fix pointer signedness.
5023 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5024 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5026 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5028 Improve quality of tests for time stamp overflow.
5029 For example, without this patch (encode-time 0 0 0 1 1
5030 1152921504606846976) returns the obviously-bogus value (-948597
5031 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5032 reports time overflow. See
5033 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5034 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5035 * editfns.c: Include limits.h and intprops.h.
5036 (TIME_T_MIN, TIME_T_MAX): New macros.
5037 (time_overflow): Move earlier, to before first use.
5038 (hi_time, lo_time): New functions, for an accurate test for
5040 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5041 (Fget_internal_run_time): Don't assume time_t fits in int.
5042 (make_time): Use list2 instead of Fcons twice.
5043 (Fdecode_time): More accurate test for out-of-range times.
5044 (check_tm_member): New function.
5045 (Fencode_time): Use it, to test for out-of-range times.
5046 (lisp_time_argument): Don't rely on undefined left-shift and
5047 right-shift behavior when checking for time stamp overflow.
5049 * editfns.c (time_overflow): New function, refactoring common code.
5050 (Fformat_time_string, Fdecode_time, Fencode_time):
5051 (Fcurrent_time_string): Use it.
5053 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5054 * dired.c (make_time): Move to ...
5055 * editfns.c (make_time): ... here.
5056 * systime.h: Note the move.
5058 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5060 * fringe.c (update_window_fringes): Remove unused variables.
5062 * unexmacosx.c (copy_data_segment): Also copy __got section.
5065 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5067 * termcap.c [MSDOS]: Include "msdos.h".
5068 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5069 Constify `char *' arguments and their references according to
5070 prototypes in tparam.h.
5072 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5074 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5075 Adapt all references accordingly.
5077 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5079 2011-03-11 Tom Tromey <tromey@redhat.com>
5081 * buffer.c (syms_of_buffer): Remove obsolete comment.
5083 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5085 * termhooks.h (encode_terminal_code): Declare prototype.
5087 * msdos.c (encode_terminal_code): Don't declare prototype.
5089 * term.c (encode_terminal_code): Now external again, used by
5090 w32console.c and msdos.c.
5092 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5093 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5095 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5097 Fix some minor problems found by GCC 4.5.2's static checks.
5099 * fringe.c (update_window_fringes): Mark locals as initialized
5101 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5103 * alloc.c (mark_fringe_data): Move decl from here ...
5104 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5105 to check its interface.
5106 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5108 * fontset.c (free_realized_fontset): Now static.
5109 (Fset_fontset_font): Rename local to avoid shadowing.
5110 (fontset_font): Mark local as initialized.
5111 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5113 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5115 * xselect.c (x_disown_buffer_selections): Remove; not used.
5116 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5117 (x_own_selection, Fx_disown_selection_internal): Rename locals
5119 (x_handle_dnd_message): Remove local to avoid shadowing.
5121 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5122 so that the caller can use some name other than gcpro1.
5123 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5124 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5125 (Fx_backspace_delete_keys_p):
5126 Use them to avoid shadowing, and rename vars to avoid shadowing.
5127 (x_decode_color, x_set_name, x_window): Now static.
5128 (Fx_create_frame): Add braces to silence GCC warning.
5129 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5130 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5131 Remove unused locals.
5132 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5133 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5134 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5137 * xterm.h (x_mouse_leave): New decl.
5139 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5140 Remove unused functions.
5141 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5142 (x_calc_absolute_position): Now static.
5143 (XTread_socket): Don't define label "out" unless it's used.
5144 Don't declare local "event" unless it's used.
5145 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5146 unless they are used.
5147 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5148 (x_fatal_error_signal): Remove; not used.
5149 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5150 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5151 (x_error_catcher, x_connection_closed, x_error_handler):
5152 (x_error_quitter, xembed_send_message, x_iconify_frame):
5153 (my_log_handler): Rename locals to avoid shadowing.
5154 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5155 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5157 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5158 Rename or move locals to avoid shadowing.
5159 (tty_defined_color, merge_face_heights): Now static.
5160 (free_realized_faces_for_fontset): Remove; not used.
5161 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5162 does not deduce is never used uninitialized.
5163 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5164 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5166 * terminal.c (store_terminal_param): Now static.
5168 * xmenu.c (menu_highlight_callback): Now static.
5169 (set_frame_menubar): Remove unused local.
5170 (xmenu_show): Rename parameter to avoid shadowing.
5171 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5172 since they might point to immutable storage.
5173 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5174 since it's unused otherwise.
5176 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5177 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5178 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5179 avoids a gcc -Wuninitialized diagnostic.
5180 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5181 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5182 does not deduce are never used uninitialized.
5184 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5186 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5187 * window.c (window_loop, size_window):
5188 (run_window_configuration_change_hook, enlarge_window): Likewise.
5190 * window.c (display_buffer): Now static.
5191 (size_window): Mark variables that gcc -Wuninitialized
5192 does not deduce are never used uninitialized.
5193 * window.h (check_all_windows): New decl, to forestall
5194 gcc -Wmissing-prototypes diagnostic.
5195 * dispextern.h (bidi_dump_cached_states): Likewise.
5197 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5199 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5201 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5202 and to avoid gcc -Wuninitialized warning.
5203 (load_charset_map): Mark variables that gcc -Wuninitialized
5204 does not deduce are never used uninitialized.
5205 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5207 * coding.c (coding_set_source, coding_set_destination):
5208 Use "else { /* comment */ }" rather than "else /* comment */;"
5209 for clarity, and to avoid gcc -Wempty-body warning.
5210 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5211 a block, when the outer 'i' will do.
5212 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5213 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5214 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5215 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5216 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5217 Rename locals to avoid shadowing.
5218 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5219 * coding.c (emacs_mule_char, encode_invocation_designation):
5220 Now static, since they're not used elsewhere.
5221 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5222 (decode_coding_object, encode_coding_object, detect_coding_system):
5223 (decode_coding_emacs_mule): Mark variables that gcc
5224 -Wuninitialized does not deduce are never used uninitialized.
5225 (detect_coding_iso_2022): Initialize a local variable that might
5226 be used uninitialized. Leave a FIXME because it's not clear that
5227 this initialization is needed. (Bug#8211)
5228 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5229 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5230 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5231 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5232 Remove unused macros.
5234 * category.c (hash_get_category_set): Remove unused local var.
5235 (copy_category_table): Now static, since it's not used elsewhere.
5236 * character.c (string_count_byte8): Likewise.
5238 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5239 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5241 * chartab.c (copy_sub_char_table): Now static, since it's not used
5243 (sub_char_table_ref_and_range, char_table_ref_and_range):
5244 Rename locals to avoid shadowing.
5245 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5247 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5248 (BIDI_BOB): Remove unused macro.
5250 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5251 deduce are never used uninitialized.
5252 * term.c (encode_terminal_code): Likewise.
5254 * term.c (encode_terminal_code): Now static. Remove unused local.
5256 * tparam.h: New file.
5257 * term.c, tparam.h: Include it.
5258 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5259 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5260 Move these decls to tparam.h, and make them agree with what
5261 is actually in tparam.c. The previous trick of using incompatible
5262 decls in different modules does not conform to the C standard.
5263 All callers of tparam changed to use tparam's actual API.
5264 * tparam.c (tparam1, tparam, tgoto):
5265 Use const pointers where appropriate.
5267 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5268 * cm.h (struct cm): Likewise.
5269 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5270 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5271 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5272 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5273 (turn_on_face, init_tty): Likewise.
5274 * termchar.h (struct tty_display_info): Likewise.
5276 * term.c (term_mouse_position): Rename local to avoid shadowing.
5278 * alloc.c (mark_ttys): Move decl from here ...
5279 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5281 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5283 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5285 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5287 * search.c (compile_pattern_1): Remove argument regp, unused since
5288 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5289 (compile_pattern): Don't pass it.
5291 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5293 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5294 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5296 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5298 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5300 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5301 gdk_window_get_screen, gdk_window_get_geometry,
5302 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5303 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5304 (xg_get_pixbuf_from_pixmap): New function.
5305 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5306 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5307 Call xg_get_pixbuf_from_pixmap instead of
5308 gdk_pixbuf_get_from_drawable.
5309 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5310 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5311 (xg_check_special_colors): Use GtkStyleContext and its functions
5313 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5314 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5315 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5316 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5317 Call gtk_widget_get_preferred_size.
5318 (xg_frame_resized): gdk_window_get_geometry only takes 5
5320 (xg_win_to_widget, xg_event_is_for_menubar):
5321 Call gdk_x11_window_lookup_for_display.
5322 (xg_set_widget_bg): New function.
5323 (delete_cb): New function.
5324 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5325 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5326 (xg_set_background_color): Call xg_set_widget_bg.
5327 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5328 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5329 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5330 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5332 (update_frame_tool_bar): Call gtk_widget_hide.
5333 (xg_initialize): Use GDK_KEY_g.
5335 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5337 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5339 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5340 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5341 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5343 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5345 * w32xfns.c (select_palette): Check success of RealizePalette against
5346 GDI_ERROR, not zero.
5348 See ChangeLog.11 for earlier changes.
5354 Copyright (C) 2011 Free Software Foundation, Inc.
5356 This file is part of GNU Emacs.
5358 GNU Emacs is free software: you can redistribute it and/or modify
5359 it under the terms of the GNU General Public License as published by
5360 the Free Software Foundation, either version 3 of the License, or
5361 (at your option) any later version.
5363 GNU Emacs is distributed in the hope that it will be useful,
5364 but WITHOUT ANY WARRANTY; without even the implied warranty of
5365 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5366 GNU General Public License for more details.
5368 You should have received a copy of the GNU General Public License
5369 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.