Merge: Cons<->int and similar integer overflow fixes.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2
3 Cons<->int and similar integer overflow fixes.
4
5 Check for overflow when converting integer to cons and back.
6 * charset.c (Fdefine_charset_internal, Fdecode_char):
7 Use cons_to_unsigned to catch overflow.
8 (Fencode_char): Use INTEGER_TO_CONS.
9 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11 * data.c (long_to_cons, cons_to_long): Remove.
12 (cons_to_unsigned, cons_to_signed): New functions.
13 These signal an error for invalid or out-of-range values.
14 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
15 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
16 * font.c (Ffont_variation_glyphs):
17 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
18 * lisp.h: Include <intprops.h>.
19 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
20 (cons_to_signed, cons_to_unsigned): New decls.
21 (long_to_cons, cons_to_long): Remove decls.
22 * undo.c (record_first_change): Use INTEGER_TO_CONS.
23 (Fprimitive_undo): Use CONS_TO_INTEGER.
24 * xfns.c (Fx_window_property): Likewise.
25 * xselect.c: Include <limits.h>.
26 (x_own_selection, selection_data_to_lisp_data):
27 Use INTEGER_TO_CONS.
28 (x_handle_selection_request, x_handle_selection_clear)
29 (x_get_foreign_selection, Fx_disown_selection_internal)
30 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
31 (lisp_data_to_selection_data): Use cons_to_unsigned.
32 (x_fill_property_data): Use cons_to_signed.
33 Report values out of range.
34
35 Check for buffer and string overflow more precisely.
36 * buffer.h (BUF_BYTES_MAX): New macro.
37 * lisp.h (STRING_BYTES_MAX): New macro.
38 * alloc.c (Fmake_string):
39 * character.c (string_escape_byte8):
40 * coding.c (coding_alloc_by_realloc):
41 * doprnt.c (doprnt):
42 * editfns.c (Fformat):
43 * eval.c (verror):
44 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
45 since they may not be the same number.
46 * editfns.c (Finsert_char):
47 * fileio.c (Finsert_file_contents):
48 Likewise for BUF_BYTES_MAX.
49
50 * image.c: Use ptrdiff_t, not int, for sizes.
51 (slurp_file): Switch from int to ptrdiff_t.
52 All uses changed.
53 (slurp_file): Check that file size fits in both size_t (for
54 malloc) and ptrdiff_t (for sanity and safety).
55
56 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
57 if b->modtime has its maximal value.
58
59 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
60
61 Don't assume time_t can fit into int.
62 * buffer.h (struct buffer.modtime): Now time_t, not int.
63 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
64 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
65
66 Minor fixes for signed vs unsigned integers.
67 * character.h (MAYBE_UNIFY_CHAR):
68 * charset.c (maybe_unify_char):
69 * keyboard.c (read_char, reorder_modifiers):
70 XINT -> XFASTINT, since the integer must be nonnegative.
71 * ftfont.c (ftfont_spec_pattern):
72 * keymap.c (access_keymap, silly_event_symbol_error):
73 XUINT -> XFASTINT, since the integer must be nonnegative.
74 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
75 since it makes no difference and we prefer signed.
76 * keyboard.c (record_char): Use XUINT when all the neighbors do.
77 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
78 nonnegative.
79
80 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
81
82 * window.h (Fwindow_frame): Declare.
83
84 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
85
86 * alloc.c: Simplify handling of large-request failures (Bug#8800).
87 (SPARE_MEMORY): Always define.
88 (LARGE_REQUEST): Remove.
89 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
90
91 2011-06-06 Martin Rudalics <rudalics@gmx.at>
92
93 * lisp.h: Move EXFUNS for Fframe_root_window,
94 Fframe_first_window and Fset_frame_selected_window to window.h.
95
96 * window.h: Move EXFUNS for Fframe_root_window,
97 Fframe_first_window and Fset_frame_selected_window here from
98 lisp.h.
99
100 * frame.c (Fwindow_frame, Fframe_first_window)
101 (Fframe_root_window, Fframe_selected_window)
102 (Fset_frame_selected_window): Move to window.c.
103 (Factive_minibuffer_window): Move to minibuf.c.
104 (Fother_visible_frames_p): New function.
105
106 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
107
108 * window.c (decode_window, decode_any_window): Move up in code.
109 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
110 (inhibit_frame_unsplittable): Remove unused variable.
111 (Fwindow_buffer): Move up and rewrite doc-string.
112 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
113 (Fwindow_prev): New functions.
114 (Fwindow_frame): Move here from frame.c. Accept any window as
115 argument.
116 (Fframe_root_window, Fframe_first_window)
117 (Fframe_selected_window): Move here from frame.c. Accept frame
118 or arbitrary window as argument. Update doc-strings.
119 (Fminibuffer_window): Move up in code.
120 (Fwindow_minibuffer_p): Move up in code and simplify.
121 (Fset_frame_selected_window): Move here from frame.c.
122 Marginal rewrite.
123 (Fselected_window, select_window, Fselect_window): Move up in
124 code. Minor doc-string fixes.
125
126 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
127
128 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
129 Do not assume that spare memory exists; that assumption is valid
130 only if SYSTEM_MALLOC.
131 (LARGE_REQUEST): New macro, so that the issue of large requests
132 is separated from the issue of spare memory.
133
134 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
135
136 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
137 format. (Bug#8806)
138
139 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
140
141 * xfns.c (x_set_scroll_bar_default_width): Move declarations
142 before statements.
143
144 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
145
146 * gtkutil.c (xg_get_default_scrollbar_width): New function.
147
148 * gtkutil.h: Declare xg_get_default_scrollbar_width.
149
150 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
151 min width by calling x_set_scroll_bar_default_width (Bug#8505).
152
153 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
154
155 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
156
157 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
158
159 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
160 (x_clipboard_manager_save): Add return value.
161 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
162 New error handlers.
163 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
164 Obey Vx_select_enable_clipboard_manager. Catch errors in
165 x_clipboard_manager_save (Bug#8779).
166 (Vx_select_enable_clipboard_manager): New variable.
167 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
168
169 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
170
171 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
172
173 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
174
175 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
176 in the current matrix if keep_current_p is non-zero.
177
178 2011-06-04 Eli Zaretskii <eliz@gnu.org>
179
180 * bidi.c (bidi_level_of_next_char): Fix last change.
181
182 2011-06-03 Eli Zaretskii <eliz@gnu.org>
183
184 Support bidi reordering of text covered by display properties.
185
186 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
187 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
188 (bidi_cache_search, bidi_cache_iterator_state)
189 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
190 (bidi_level_of_next_char, bidi_move_to_visually_next):
191 Support character positions inside a run of characters covered by a
192 display string.
193 (bidi_paragraph_init, bidi_resolve_explicit_1)
194 (bidi_level_of_next_char): Call bidi_fetch_char and
195 bidi_fetch_char_advance instead of FETCH_CHAR and
196 FETCH_CHAR_ADVANCE.
197 (bidi_init_it): Initialize new members.
198 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
199 definitions.
200 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
201 instead of using explicit *_CHAR codes.
202 (bidi_resolve_explicit, bidi_resolve_weak):
203 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
204 bidirectional text is supported only in multibyte buffers.
205 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
206 it to initialize the frame_window_p member of struct bidi_it.
207 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
208 (bidi_resolve_explicit, bidi_resolve_weak)
209 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
210 bidi_it->nchars is non-positive.
211 (bidi_level_of_next_char): Don't try to lookup the cache for the
212 next/previous character if nothing is cached there yet, or if we
213 were just reseat()'ed to a new position.
214
215 * xdisp.c (set_cursor_from_row): Set start and stop points
216 according to the row's direction when priming the loop that looks
217 for the glyph on which to display cursor.
218 (single_display_spec_intangible_p): Function deleted.
219 (display_prop_intangible_p): Reimplement to call
220 handle_display_spec instead of single_display_spec_intangible_p.
221 Accept 3 additional arguments needed by handle_display_spec.
222 This fixes incorrect cursor motion across display property with complex
223 values: lists, `(when COND...)' forms, etc.
224 (single_display_spec_string_p): Support property values that are
225 lists with the argument STRING its top-level element.
226 (display_prop_string_p): Fix the condition for processing a
227 property that is a list to be consistent with handle_display_spec.
228 (handle_display_spec): New function, refactored from the
229 last portion of handle_display_prop.
230 (compute_display_string_pos): Accept additional argument
231 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
232 value of a `display' property is a "replacing spec".
233 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
234 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
235 the display property, but just return a value indicating whether
236 the display property will replace the characters it covers.
237 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
238 frame_window_p members of struct bidi_it.
239 (compute_display_string_pos, compute_display_string_end):
240 New functions.
241 (push_it): Accept second argument POSITION, where pop_it should
242 jump to continue iteration.
243 (reseat_1): Initialize bidi_it.disp_pos.
244
245 * keyboard.c (adjust_point_for_property): Adjust the call to
246 display_prop_intangible_p to its new signature.
247
248 * dispextern.h (struct bidi_it): New member frame_window_p.
249 (bidi_init_it): Update prototypes.
250 (display_prop_intangible_p): Update prototype.
251 (compute_display_string_pos, compute_display_string_end):
252 Declare prototypes.
253 (struct bidi_it): New members nchars and disp_pos. ch_len is now
254 EMACS_INT.
255
256 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
257
258 Malloc failure behavior now depends on size of allocation.
259 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
260 * lisp.h: Change signatures accordingly.
261 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
262 All callers changed. (Bug#8762)
263
264 * gnutls.c: Use Emacs's memory allocators.
265 Without this change, the gnutls library would invoke malloc etc.
266 directly, which causes problems on non-SYNC_INPUT hosts, and which
267 runs afoul of improving memory_full behavior. (Bug#8761)
268 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
269 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
270 xfree instead of the default malloc, realloc, free.
271 (Fgnutls_boot): No need to check for memory allocation failure,
272 since xmalloc does that for us.
273
274 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
275 * category.c (hash_get_category_set):
276 * ccl.c (ccl_driver):
277 * charset.c (Fdefine_charset_internal):
278 * charset.h (struct charset.hash_index):
279 * composite.c (get_composition_id, gstring_lookup_cache)
280 (composition_gstring_put_cache):
281 * composite.h (struct composition.hash_index):
282 * dispextern.h (struct image.hash):
283 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
284 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
285 (hashfn_equal, hashfn_user_defined, make_hash_table)
286 (maybe_resize_hash_table, hash_lookup, hash_put)
287 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
288 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
289 (Fsxhash, Fgethash, Fputhash, Fmaphash):
290 * image.c (make_image, search_image_cache, lookup_image)
291 (xpm_put_color_table_h):
292 * lisp.h (struct Lisp_Hash_Table):
293 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
294 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
295 for hashes and hash indexes, instead of 'unsigned' and 'int'.
296 * alloc.c (allocate_vectorlike):
297 Check for overflow in vector size calculations.
298 * ccl.c (ccl_driver):
299 Check for overflow when converting EMACS_INT to int.
300 * fns.c, image.c: Remove unnecessary static decls that would otherwise
301 need to be updated by these changes.
302 * fns.c (make_hash_table, maybe_resize_hash_table):
303 Check for integer overflow with large hash tables.
304 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
305 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
306 (SXHASH_REDUCE): New macro.
307 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
308 Use it instead of discarding useful hash info with large hash values.
309 (sxhash_float): New function.
310 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
311 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
312 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
313 Rewrite to use FIXNUM_BITS, as this simplifies things.
314 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
315 Adjust signatures to match updated version of code.
316 (consing_since_gc): Now EMACS_INT, since a single hash table can
317 use more than INT_MAX bytes.
318
319 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
320
321 Make it possible to build with GCC-4.6+ -O2 -flto.
322
323 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
324
325 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
326
327 * minibuf.c (get_minibuffer, read_minibuf_unwind):
328 Call minibuffer-inactive-mode.
329
330 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
331
332 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
333 Update dependencies.
334
335 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
336
337 * data.c (init_data): Remove code for UTS, this system is not
338 supported anymore.
339
340 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
341
342 Don't force ./temacs to start in terminal mode.
343
344 * frame.c (make_initial_frame): Initialize faces in all cases, not
345 only when CANNOT_DUMP is defined.
346 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
347
348 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
349
350 * dispnew.c (add_window_display_history): Use const for the string
351 pointer. Remove declaration, not needed.
352
353 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
354
355 Use 'inline', not 'INLINE'.
356 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
357 * alloc.c, fontset.c (INLINE): Remove.
358 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
359 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
360 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
361 * gmalloc.c (register_heapinfo): Use inline unconditionally.
362 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
363
364 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
365
366 Make it possible to run ./temacs.
367
368 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
369 syms_of_callproc does the same thing. Remove test for
370 "initialized", do it in the caller.
371 * emacs.c (main): Avoid calling set_initial_environment when dumping.
372
373 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
374
375 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
376 (read_minibuf): Use get_minibuffer.
377 (syms_of_minibuf): Use DEFSYM.
378 (Qmetadata): New var.
379 * data.c (Qbuffer): Don't make it static.
380 (syms_of_data): Use DEFSYM.
381
382 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
383
384 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
385 (CCL_CODE_MIN): New macro.
386
387 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
388
389 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
390
391 * eval.c (Qdebug): Now static.
392 * lisp.h (Qdebug): Remove decl. This reverts a part of the
393 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
394 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
395
396 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
397
398 * image.c: Various fixes to ImageMagick code comments.
399 (Fimagemagick_types): Doc fix.
400
401 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
402
403 Minor fixes prompted by GCC 4.6.0 warnings.
404
405 * xselect.c (converted_selections, conversion_fail_tag): Now static.
406
407 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
408 (x_clipboard_manager_save_all): Move extern decl to ...
409 * xterm.h: ... here, so that it can be checked for consistency.
410
411 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
412
413 * xselect.c (x_clipboard_manager_save_frame)
414 (x_clipboard_manager_save_all): New functions.
415 (Fx_clipboard_manager_save): Lisp function deleted.
416
417 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
418 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
419
420 * xterm.h: Update prototype.
421
422 2011-05-28 William Xu <william.xwl@gmail.com>
423
424 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
425 exiting (Bug#8239).
426
427 2011-05-28 Jim Meyering <meyering@redhat.com>
428
429 Avoid a sign-extension bug in crypto_hash_function.
430 * fns.c (to_uchar): Define.
431 (crypto_hash_function): Use it to convert some newly-signed
432 variables to unsigned, to avoid sign-extension bugs. For example,
433 without this change, (md5 "truc") would evaluate to
434 45723a2aff78ff4fff7fff1114760e62 rather than the expected
435 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
436 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
437
438 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
439
440 Integer overflow fixes.
441
442 * dbusbind.c: Serial number integer overflow fixes.
443 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
444 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
445 to hold a serial number that is too large for a fixnum.
446 (Fdbus_method_return_internal, Fdbus_method_error_internal):
447 Check for serial numbers out of range. Decode any serial number
448 that was so large that it became a float. (Bug#8722)
449
450 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
451 (Fdbus_call_method, Fdbus_call_method_asynchronously):
452 Use XFASTINT rather than XUINT when numbers are nonnegative.
453 (xd_append_arg, Fdbus_method_return_internal):
454 (Fdbus_method_error_internal): Likewise. Also, for unsigned
455 arguments, check that Lisp number is nonnegative, rather than
456 silently wrapping negative numbers around. (Bug#8722)
457 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
458 (Bug#8722)
459
460 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
461
462 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
463
464 ccl: add integer overflow checks
465 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
466 (IN_INT_RANGE): New macros.
467 (ccl_driver): Use them to check for integer overflow when
468 decoding a CCL program. Many of the new checks are whether XINT (x)
469 fits in int; it doesn't always, on 64-bit hosts. The new version
470 doesn't catch all possible integer overflows, but it's an
471 improvement. (Bug#8719)
472
473 * alloc.c (make_event_array): Use XINT, not XUINT.
474 There's no need for unsigned here.
475
476 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
477 This follows up to the 2011-05-06 change that substituted uintptr_t
478 for EMACS_INT. This case wasn't caught back then.
479
480 Rework Fformat to avoid integer overflow issues.
481 * editfns.c: Include <float.h> unconditionally, as it's everywhere
482 now (part of C89). Include <verify.h>.
483 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
484 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
485 (Fformat): Avoid the prepass trying to compute sizes; it was only
486 approximate and thus did not catch overflow reliably. Instead, walk
487 through the format just once, formatting and computing sizes as we go,
488 checking for integer overflow at every step, and allocating a larger
489 buffer as needed. Keep track separately whether the format is
490 multibyte. Keep only the most-recently calculated precision, rather
491 than them all. Record whether each argument has been converted to
492 string. Use EMACS_INT, not int, for byte and char and arg counts.
493 Support field widths and precisions larger than INT_MAX. Avoid
494 sprintf's undefined behavior with conversion specifications such as %#d
495 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
496 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
497 formatting out-of-range floating point numbers with int
498 formats. (Bug#8668)
499
500 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
501
502 * data.c: Avoid integer truncation in expressions involving floats.
503 * data.c: Include <intprops.h>.
504 (arith_driver): When there's an integer overflow in an expression
505 involving floating point, convert the integers to floating point
506 so that the resulting value does not suffer from catastrophic
507 integer truncation. For example, on a 64-bit host (* 4
508 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
509 Do not rely on undefined behavior after integer overflow.
510
511 merge count_size_as_multibyte, parse_str_to_multibyte
512 * character.c, character.h (count_size_as_multibyte):
513 Rename from parse_str_to_multibyte; all uses changed.
514 Check for integer overflow.
515 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
516 since it's now a duplicate of the other. This is more of
517 a character than a buffer op, so better that it's in character.c.
518 * fns.c, print.c: Adjust to above changes.
519
520 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
521
522 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
523
524 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
525
526 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
527 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
528 (x_clipboard_manager_save): Now static.
529 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
530
531 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
532 (crypto_hash_function): Now static.
533 Fix pointer signedness problems. Avoid unnecessary initializations.
534
535 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
536
537 * termhooks.h (Vselection_alist): Make it terminal-local.
538
539 * terminal.c (create_terminal): Initialize it.
540
541 * xselect.c: Support for clipboard managers.
542 (Vselection_alist): Move to termhooks.h as terminal-local var.
543 (LOCAL_SELECTION): New macro.
544 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
545 (symbol_to_x_atom): Remove gratuitous arg.
546 (x_handle_selection_request, lisp_data_to_selection_data)
547 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
548 (x_own_selection, x_get_local_selection, x_convert_selection):
549 New arg, specifying work frame. Use terminal-local Vselection_alist.
550 (some_frame_on_display): Delete unused function.
551 (Fx_own_selection_internal, Fx_get_selection_internal)
552 (Fx_disown_selection_internal, Fx_selection_owner_p)
553 (Fx_selection_exists_p): New optional frame arg.
554 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
555 (x_handle_selection_clear): Don't treat other terminals with the
556 same keyboard specially. Use the terminal-local Vselection_alist.
557 (x_clear_frame_selections): Use Frun_hook_with_args.
558
559 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
560
561 * xterm.h: Add support for those atoms.
562
563 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
564
565 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
566 (converted_selections, conversion_fail_tag): New global variables.
567 (x_selection_request_lisp_error): Free the above.
568 (x_get_local_selection): Remove unnecessary code.
569 (x_reply_selection_request): Args changed; handle arbitrary array
570 of converted selections stored in converted_selections.
571 Separate the XChangeProperty and SelectionNotify steps.
572 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
573 (x_convert_selection): New function.
574 (x_handle_selection_event): Simplify.
575 (x_get_foreign_selection): Don't ignore incoming requests while
576 waiting for an answer; this will fail when we implement
577 SAVE_TARGETS, and seems unnecessary anyway.
578 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
579 (Vx_sent_selection_functions): Doc fix.
580
581 2011-05-26 Leo Liu <sdl.web@gmail.com>
582
583 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
584
585 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
586
587 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
588
589 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
590 for fringe update if it has periodic bitmap.
591 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
592 and fringe_bitmap_periodic_p.
593
594 * fringe.c (get_fringe_bitmap_data): New function.
595 (draw_fringe_bitmap_1, update_window_fringes): Use it.
596 (update_window_fringes): Record periodicity of fringe bitmap in glyph
597 row. Mark glyph row for fringe update if periodicity changed.
598
599 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
600 for fringe update unless it has periodic bitmap.
601
602 2011-05-25 Kenichi Handa <handa@m17n.org>
603
604 * xdisp.c (get_next_display_element): Set correct it->face_id for
605 a static composition.
606
607 2011-05-24 Leo Liu <sdl.web@gmail.com>
608
609 * deps.mk (fns.o):
610 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
611
612 * fns.c (crypto_hash_function, Fsha1): New function.
613 (Fmd5): Use crypto_hash_function.
614 (syms_of_fns): Add Ssha1.
615
616 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
617
618 * gnutls.c: Remove unused macros.
619 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
620 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
621 Remove macros that are defined and never used.
622 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
623
624 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
625
626 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
627 (Fx_get_selection_internal): Minor cleanup.
628 (Fx_own_selection_internal): Rename arguments for consistency with
629 select.el.
630
631 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
632
633 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
634
635 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
636
637 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
638
639 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
640
641 * dispnew.c (scrolling_window): Don't exclude the case that the
642 last enabled row in the desired matrix touches the bottom boundary.
643
644 2011-05-21 Glenn Morris <rgm@gnu.org>
645
646 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
647 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
648 and add some more files.
649
650 2011-05-20 Eli Zaretskii <eliz@gnu.org>
651
652 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
653 report_file_error introduced by the change from 2011-05-07.
654
655 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
656
657 * systime.h (Time): Define only if emacs is defined.
658 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
659 where the include path doesn't have X11/X.h by default. See
660 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
661
662 2011-05-20 Kenichi Handa <handa@m17n.org>
663
664 * composite.c (find_automatic_composition): Fix previous change.
665
666 2011-05-20 Glenn Morris <rgm@gnu.org>
667
668 * lisp.mk: New file, split from Makefile.in.
669 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
670 (shortlisp): Remove.
671 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
672
673 2011-05-19 Glenn Morris <rgm@gnu.org>
674
675 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
676 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
677 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
678 (lisp): Set the order to that of loadup.el.
679 (shortlisp): Make it a copy of $lisp.
680 (SOME_MACHINE_LISP): Remove.
681 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
682 Use just $shortlisp, not $SOME_MACHINE_LISP too.
683
684 2011-05-18 Kenichi Handa <handa@m17n.org>
685
686 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
687 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
688 (find_automatic_composition): Mostly rewrite for efficiency.
689
690 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
691
692 * makefile.w32-in: Update dependencies.
693
694 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
695
696 * menu.c: Include limits.h (fixes the MS-Windows build broken by
697 revision 104625).
698
699 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
700
701 Fix some integer overflow issues, such as string length overflow.
702
703 * insdel.c (count_size_as_multibyte): Check for string overflow.
704
705 * character.c (lisp_string_width): Check for string overflow.
706 Use EMACS_INT, not int, for string indexes and lengths; in
707 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
708 the resulting string length overflows an EMACS_INT; instead,
709 report a string overflow if no precision given. When checking for
710 precision exhaustion, use a check that cannot possibly have
711 integer overflow. (Bug#8675)
712 * character.h (lisp_string_width): Adjust to new signature.
713
714 * alloc.c (string_overflow): New function.
715 (Fmake_string): Use it. This doesn't change behavior, but saves
716 a few bytes and will simplify future changes.
717 * character.c (string_escape_byte8): Likewise.
718 * lisp.h (string_overflow): New decl.
719
720 Fixups, following up to the user-interface timestamp change.
721 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
722 for UI timestamps, instead of unsigned long.
723 * msdos.c (mouse_get_pos): Likewise.
724 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
725 * w32gui.h (Time): Define by including "systime.h" rather than by
726 declaring it ourselves. (Bug#8664)
727
728 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
729 * image.c (clear_image_cache): Likewise.
730
731 * term.c (term_mouse_position): Don't assume time_t wraparound.
732
733 Be more systematic about user-interface timestamps.
734 Before, the code sometimes used 'Time', sometimes 'unsigned long',
735 and sometimes 'EMACS_UINT', to represent these timestamps.
736 This change causes it to use 'Time' uniformly, as that's what X uses.
737 This makes the code easier to follow, and makes it easier to catch
738 integer overflow bugs such as Bug#8664.
739 * frame.c (Fmouse_position, Fmouse_pixel_position):
740 Use Time, not unsigned long, for user-interface timestamps.
741 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
742 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
743 * keyboard.h (last_event_timestamp): Likewise.
744 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
745 * menu.h (xmenu_show): Likewise.
746 * term.c (term_mouse_position): Likewise.
747 * termhooks.h (struct input_event.timestamp): Likewise.
748 (struct terminal.mouse_position_hook): Likewise.
749 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
750 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
751 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
752 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
753 what it was before.
754 * menu.h, termhooks.h: Include "systime.h", for Time.
755
756 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
757 Don't assume that the difference between two unsigned long values
758 can fit into an integer. At this point, we know button_down_time
759 <= event->timestamp, so the difference must be nonnegative, so
760 there's no need to cast the result if double-click-time is
761 nonnegative, as it should be; check that it's nonnegative, just in
762 case. This bug is triggered when events are more than 2**31 ms
763 apart (about 25 days). (Bug#8664)
764
765 * xselect.c (last_event_timestamp): Remove duplicate decl.
766 (x_own_selection): Remove needless cast to unsigned long.
767
768 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
769 that always fit in int. Use a sentinel instead of a counter, to
770 avoid a temp and to allay GCC's concerns about possible int overflow.
771 * frame.h (struct frame): Use int for menu_bar_items_used
772 instead of EMACS_INT, since it always fits in int.
773
774 * menu.c (grow_menu_items): Check for int overflow.
775
776 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
777
778 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
779 Before, the code was not consistent. These values cannot exceed
780 2**31 - 1 so there's no need to make them unsigned.
781 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
782 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
783 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
784 as modifiers.
785 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
786
787 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
788 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
789 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
790 presumably because the widths might not match.
791
792 * window.c (size_window): Avoid needless test at loop start.
793
794 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
795
796 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
797
798 2011-05-12 Drew Adams <drew.adams@oracle.com>
799
800 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
801
802 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
803
804 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
805 `width' to `bar_area_x' and `bar_area_width', respectively.
806 (x_scroll_run): Take account of fringe background extension.
807
808 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
809 Rename local vars `left' and `width' to `bar_area_x' and
810 `bar_area_width', respectively.
811 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
812 background extension.
813
814 2011-05-10 Jim Meyering <meyering@redhat.com>
815
816 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
817
818 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
819
820 * image.c (Finit_image_library): Return t for built-in image types,
821 like pbm and xbm. (Bug#8640)
822
823 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
824
825 * w32menu.c (set_frame_menubar): Fix submenu allocation.
826
827 2011-05-07 Eli Zaretskii <eliz@gnu.org>
828
829 * w32console.c (Fset_screen_color): Doc fix.
830 (Fget_screen_color): New function.
831 (syms_of_ntterm): Defsubr it.
832
833 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
834 unlink the temporary file if Fcall_process didn't create it in the
835 first place.
836 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
837 child process will be redirected to a file specified with `:file'.
838 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
839 cue to call_process_cleanup not to close that handle.
840
841 2011-05-07 Ben Key <bkey76@gmail.com>
842
843 * makefile.w32-in: The bootstrap-temacs rule now makes use of
844 one of two shell specific rules, either bootstrap-temacs-CMD or
845 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
846 to the previous implementation of the bootstrap-temacs rule.
847 The bootstrap-temacs-CMD rule is similar to the previous
848 implementation of the bootstrap-temacs rule except that it
849 makes use of the ESC_CFLAGS variable instead of the CFLAGS
850 variable.
851
852 These changes, along with some changes to nt/configure.bat,
853 nt/gmake.defs, and nt/nmake.defs, are required to extend my
854 earlier fix to add support for --cflags and --ldflags options
855 that include quotes so that it works whether make uses cmd or
856 sh as the shell.
857
858 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
859
860 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
861 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
862 is a constant.
863 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
864 a string. Handle both cases.
865 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
866 (Fdbus_register_method): Use Qinvalid_function.
867
868 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
869
870 * makefile.w32-in: Update dependencies.
871 (LISP_H): Add inttypes.h and stdin.h.
872 (PROCESS_H): Add unistd.h.
873
874 2011-05-06 Eli Zaretskii <eliz@gnu.org>
875
876 * lread.c: Include limits.h (fixes the MS-Windows build broken by
877 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
878
879 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
880
881 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
882
883 * term.c (vfatal): Remove stray call to va_end.
884 It's not needed and the C Standard doesn't allow it here anyway.
885
886 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
887 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
888
889 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
890 bytes.
891
892 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
893
894 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
895
896 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
897
898 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
899
900 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
901
902 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
903 * charset.c (Fdefine_charset_internal): Don't initialize
904 charset.code_space[15]. The value was garbage, on hosts with
905 32-bit int (Bug#8600).
906
907 * lread.c (read_integer): Be more consistent with string-to-number.
908 Use string_to_number to do the actual conversion; this avoids
909 rounding errors and fixes some other screwups. Without this fix,
910 for example, #x1fffffffffffffff was misread as -2305843009213693952.
911 (digit_to_number): Move earlier, for benefit of read_integer.
912 Return -1 if the digit is out of range for the base, -2 if it is
913 not a digit in any supported base. (Bug#8602)
914
915 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
916
917 * dispnew.c (scrolling_window): Return 1 if we scrolled,
918 to match comment at start of function. This also removes a
919 GCC warning about overflow in a 32+64-bit port.
920
921 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
922
923 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
924 Reported by Stefan Monnier in
925 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
926 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
927 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
928
929 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
930 (EMACS_UINTPTR): Likewise, with uintptr_t.
931
932 * lisp.h: Prefer 64-bit EMACS_INT if available.
933 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
934 on 32-bit hosts that have 64-bit int, so that they can access
935 large files.
936 However, temporarily disable this change unless the temporary
937 symbol WIDE_EMACS_INT is defined.
938
939 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
940
941 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
942 This removes an assumption that EMACS_INT and long are the same
943 width as pointers. The assumption is true for Emacs porting targets
944 now, but we want to make other targets possible.
945 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
946 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
947 In the rest of the code, change types of integers that hold casted
948 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
949 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
950 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
951 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
952 No need to cast type when ORing.
953 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
954 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
955 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
956 assume EMACS_INT is the same width as char *.
957 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
958 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
959 Remove no-longer-needed casts.
960 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
961 (xg_tool_bar_help_callback, xg_make_tool_item):
962 Use EMACS_INTPTR to hold an integer
963 that will be cast to void *; this can avoid a GCC warning
964 if EMACS_INT is not the same width as void *.
965 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
966 * xdisp.c (display_echo_area_1, resize_mini_window_1):
967 (current_message_1, set_message_1):
968 Use a local to convert to proper width without a cast.
969 * xmenu.c (dialog_selection_callback): Likewise.
970
971 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
972 Also, don't assume VALBITS / RAND_BITS is less than 5,
973 and don't rely on undefined behavior when shifting a 1 left into
974 the sign bit.
975 * lisp.h (get_random): Change signature to match.
976
977 * lread.c (hash_string): Use size_t, not int, for hash computation.
978 Normally we prefer signed values; but hashing is special, because
979 it's better to use unsigned division on hash table sizes so that
980 the remainder is nonnegative. Also, size_t is the natural width
981 for hashing into memory. The previous code used 'int', which doesn't
982 retain enough info to hash well into very large tables.
983 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
984
985 * dbusbind.c: Don't possibly lose pointer info when converting.
986 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
987 Use XPNTR rather than XHASH, so that the high-order bits of
988 the pointer aren't lost when converting through void *.
989
990 * eval.c (Fautoload): Don't double-shift a pointer.
991
992 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
993
994 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
995
996 * gnutls.c (DEF_GNUTLS_FN):
997 * image.c (DEF_IMGLIB_FN): Make function pointers static.
998
999 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1000
1001 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1002 marker. (Bug#8610)
1003
1004 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1005
1006 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1007 New version that can reserve upto 2GB of heap space.
1008
1009 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1010
1011 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1012
1013 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1014
1015 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1016 `gnutls_certificate_set_x509_key_file'.
1017
1018 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1019
1020 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1021 Update dependencies.
1022
1023 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1024
1025 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1026 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1027 Remove unused parameter `fildes'.
1028 * process.c (read_process_output, send_process): Don't pass it.
1029
1030 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1031
1032 Fix previous change: the library cache is defined in w32.c.
1033 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1034 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1035
1036 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1037
1038 Implement dynamic loading of GnuTLS on Windows.
1039
1040 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1041 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1042 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1043 Declare.
1044
1045 * gnutls.c (Qgnutls_dll): Define.
1046 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1047 (gnutls_*): Declare function pointers.
1048 (init_gnutls_functions): New function to initialize function pointers.
1049 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1050 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1051 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1052 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1053 (emacs_gnutls_write, emacs_gnutls_read)
1054 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1055 (Fgnutls_available_p): New function.
1056 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1057 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1058 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1059
1060 * image.c: Include w32.h.
1061 (Vimage_type_cache): Delete.
1062 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1063 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1064 (w32_delayed_load): Move to w32.c.
1065
1066 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1067
1068 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1069 (w32_delayed_load): Move from image.c. When loading a library, record
1070 its filename in the :loaded-from property of the library id.
1071 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1072 Initialize and staticpro them.
1073 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1074
1075 * process.c: Include lisp.h before w32.h, not after.
1076 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1077 instead of gnutls_record_check_pending.
1078
1079 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1080
1081 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1082
1083 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1084 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1085 as passed in.
1086
1087 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1088
1089 * xterm.c (x_set_frame_alpha): Do not set property on anything
1090 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1091
1092 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1093
1094 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1095
1096 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1097
1098 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1099 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1100 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1101 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1102 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1103 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1104 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1105 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1106 (Qgnutls_bootprop_callbacks_verify): Make static.
1107
1108 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1109
1110 * callproc.c: Indentation fixup.
1111
1112 * sysdep.c (wait_for_termination_1): Make static.
1113 (wait_for_termination, interruptible_wait_for_termination):
1114 Move after wait_for_termination_1.
1115
1116 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1117
1118 * sysdep.c (interruptible_wait_for_termination): New function
1119 which is like wait_for_termination, but allows keyboard
1120 interruptions.
1121
1122 * callproc.c (Fcall_process): Add (:file "file") as an option for
1123 the STDOUT buffer.
1124 (Fcall_process_region): Ditto.
1125
1126 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1127
1128 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1129 rather than `XVECTOR (FOO)->size'.
1130
1131 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1132 inttypes.h, as a gnulib replacement is used if it not available in
1133 system headers.
1134
1135 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1136
1137 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1138 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1139 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1140
1141 * coding.c (coding_alloc_by_realloc): Error out if destination
1142 will grow beyond MOST_POSITIVE_FIXNUM.
1143 (decode_coding_emacs_mule): Abort if there isn't enough place in
1144 charbuf for the composition carryover bytes. Reserve an extra
1145 space for up to 2 characters produced in a loop.
1146 (decode_coding_iso_2022): Abort if there isn't enough place in
1147 charbuf for the composition carryover bytes.
1148
1149 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1150
1151 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1152 aborting when %lld or %lll format is passed.
1153 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1154 %llo or %llx format is passed. (Bug#8545)
1155
1156 * window.c (window_scroll_line_based): Use a marker instead of
1157 simple variables to record original value of point. (Bug#7952)
1158
1159 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1160 produced by %s or %c overflows available buffer space. (Bug#8545)
1161
1162 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1163
1164 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1165 (SIZE_MAX): Move defn after all includes, as they might #define it.
1166
1167 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1168
1169 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1170
1171 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1172
1173 * keyboard.c (Qdelayed_warnings_hook): Define.
1174 (command_loop_1): Run `delayed-warnings-hook'
1175 if Vdelayed_warnings_list is non-nil.
1176 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1177 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1178
1179 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1180
1181 * doprnt.c (doprnt): Don't return value smaller than the buffer
1182 size if the message was truncated. (Bug#8545).
1183
1184 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1185
1186 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1187 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1188
1189 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1192
1193 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1194
1195 * makefile.w32-in: Update dependencies.
1196
1197 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1198
1199 Improve `doprnt' and its usage. (Bug#8545)
1200 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1201 `format_end'. Remove support for %l as a conversion specifier.
1202 Don't use xrealloc. Improve diagnostics when the %l size modifier
1203 is used. Update the commentary.
1204
1205 * eval.c (verror): Simplify calculation of size_t.
1206
1207 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1208 messages.
1209
1210 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1211
1212 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1213 change.
1214
1215 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1216
1217 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1218 This makes this file independent of the recent pseudovector change.
1219
1220 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1221
1222 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1223
1224 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1225 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1226 Remove unused local.
1227 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1228
1229 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1230 GCC 4.6.0 optimizes based on type-based alias analysis.
1231 For example, if b is of type struct buffer * and v of type struct
1232 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1233 != &v->size, and therefore "v->size = 1; b->size = 2; return
1234 v->size;" must therefore return 1. This assumption is incorrect
1235 for Emacs, since it type-puns struct Lisp_Vector * with many other
1236 types. To fix this problem, this patch adds a new type struct
1237 vectorlike_header that documents the constraints on layout of vectors
1238 and pseudovectors, and helps optimizing compilers not get fooled
1239 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1240 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1241 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1242 the size member.
1243 (XSETPVECTYPE): Rewrite in terms of new macro.
1244 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1245 This is a bit clearer, and further avoids the possibility of
1246 undesirable aliasing.
1247 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1248 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1249 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1250 since Lisp_Subr is a special case (no "next" field).
1251 (ASIZE): Now uses header.size rather than size.
1252 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1253 to avoid the hassle of writing XVECTOR (foo)->header.size.
1254 (struct vectorlike_header): New type.
1255 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1256 object, to help avoid aliasing.
1257 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1258 (SUBRP): Likewise, since Lisp_Subr is a special case.
1259 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1260 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1261 (struct Lisp_Hash_Table): Combine first two members into a single
1262 struct vectorlike_header member. All uses of "size" and "next" members
1263 changed to be "header.size" and "header.next".
1264 * buffer.h (struct buffer): Likewise.
1265 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1266 * frame.h (struct frame): Likewise.
1267 * process.h (struct Lisp_Process): Likewise.
1268 * termhooks.h (struct terminal): Likewise.
1269 * window.c (struct save_window_data, struct saved_window): Likewise.
1270 * window.h (struct window): Likewise.
1271 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1272 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1273 * buffer.c (init_buffer_once): Likewise.
1274 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1275 special case.
1276 * process.c (Fformat_network_address): Use local var for size,
1277 for brevity.
1278
1279 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1280
1281 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1282 * data.c (atof): Remove decl; no longer used or needed.
1283 (digit_to_number): Move to lread.c.
1284 (Fstring_to_number): Use new string_to_number function, to be
1285 consistent with how the Lisp reader treats infinities and NaNs.
1286 Do not assume that floating-point numbers represent EMACS_INT
1287 without losing information; this is not true on most 64-bit hosts.
1288 Avoid double-rounding errors, by insisting on integers when
1289 parsing non-base-10 numbers, as the documentation specifies.
1290 * lisp.h (string_to_number): New decl, replacing ...
1291 (isfloat_string): Remove.
1292 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1293 (read1): Do not accept +. and -. as integers; this
1294 appears to have been a coding error. Similarly, do not accept
1295 strings like +-1e0 as floating point numbers. Do not report
1296 overflow for integer overflows unless the base is not 10 which
1297 means we have no simple and reliable way to continue.
1298 Break out the floating-point parsing into a new
1299 function string_to_number, so that Fstring_to_number parses
1300 floating point numbers consistently with the Lisp reader.
1301 (digit_to_number): Move here from data.c. Make it static inline.
1302 (E_CHAR, EXP_INT): Remove, replacing with ...
1303 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1304 (string_to_number): New function, replacing isfloat_string.
1305 This function checks for valid syntax and produces the resulting
1306 Lisp float number too. Rework it so that string-to-number
1307 no longer mishandles examples like "1.0e+". Use strtoumax,
1308 so that overflow for non-base-10 numbers is reported only when
1309 there's no portable and simple way to convert to floating point.
1310
1311 * textprop.c (set_text_properties_1): Rewrite for clarity,
1312 and to avoid GCC warning about integer overflow.
1313
1314 * intervals.h (struct interval): Use EMACS_INT for members
1315 where EMACS_UINT might cause problems. See
1316 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1317 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1318 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1319 All uses changed.
1320 (offset_intervals): Tell GCC not to worry about length overflow
1321 when negating a negative length.
1322
1323 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1324 (overrun_check_free): Likewise.
1325
1326 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1327 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1328 word size.
1329
1330 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1331 (gnutls_make_error): Rename local to avoid shadowing.
1332 (gnutls_emacs_global_deinit): ifdef out; not used.
1333 (Fgnutls_boot): Use const for pointer to readonly storage.
1334 Comment out unused local. Fix pointer signedness problems.
1335
1336 * lread.c (openp): Don't stuff size_t into an 'int'.
1337 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1338 about possible signed overflow.
1339
1340 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1341 (GDK_KEY_g): Don't define if already defined.
1342 (xg_prepare_tooltip): Avoid pointer signedness problem.
1343 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1344
1345 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1346 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1347
1348 * xfns.c (Fx_window_property): Simplify a bit,
1349 to make a bit faster and to avoid GCC 4.6.0 warning.
1350 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1351
1352 * fns.c (internal_equal): Don't assume size_t fits in int.
1353
1354 * alloc.c (compact_small_strings): Tighten assertion a little.
1355
1356 Replace pEd with more-general pI, and fix some printf arg casts.
1357 * lisp.h (pI): New macro, generalizing old pEd macro to other
1358 conversion specifiers. For example, use "...%"pI"d..." rather
1359 than "...%"pEd"...".
1360 (pEd): Remove. All uses replaced with similar uses of pI.
1361 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1362 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1363 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1364 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1365 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1366 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1367 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1368 64-bit hosts.
1369 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1370 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1371 * print.c (safe_debug_print, print_object): Likewise.
1372 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1373 to int.
1374 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1375 avoiding the 0 flag, which is not portable.
1376 * process.c (Fmake_network_process): Use pI to avoid cast.
1377 * region-cache.c (pp_cache): Likewise.
1378 * xdisp.c (decode_mode_spec): Likewise.
1379 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1380 behavior on 64-bit hosts with printf arg.
1381 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1382 (x_stop_queuing_selection_requests): Likewise.
1383 (x_get_window_property): Don't truncate byte count to an 'int'
1384 when tracing.
1385
1386 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1387 here, since it parses constructs like leading '-' and spaces,
1388 which are not wanted; and it overflows with large numbers.
1389 Instead, simply match F[0-9]+, which is what is wanted anyway.
1390
1391 * alloc.c: Remove unportable assumptions about struct layout.
1392 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1393 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1394 (allocate_vectorlike, make_pure_vector): Use the new macros,
1395 plus offsetof, to remove unportable assumptions about struct layout.
1396 These assumptions hold on all porting targets that I know of, but
1397 they are not guaranteed, they're easy to remove, and removing them
1398 makes further changes easier.
1399
1400 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1401 This doesn't fix a bug but makes the code clearer.
1402 (string_overrun_cookie): Now const. Use initializers that
1403 don't formally overflow signed char, to avoid warnings.
1404 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1405 can cause Emacs to crash when string overrun checking is enabled.
1406 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1407 multiple of sizeof (EMACS_INT); it need not be, if
1408 alignof(EMACS_INT) < sizeof (EMACS_INT).
1409 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1410
1411 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1412
1413 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1414
1415 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1416
1417 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1418 supposed to be handshaking. (Bug#8556)
1419 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1420
1421 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1422
1423 * lisp.h (Qdebug): List symbol.
1424 * eval.c (Qdebug): Restore global linkage.
1425 * keyboard.c (debug-on-event): New variable.
1426 (handle_user_signal): Break into debugger when debug-on-event
1427 matches the current signal symbol.
1428
1429 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1430
1431 * alloc.c (check_sblock, check_string_bytes)
1432 (check_string_free_list): Convert to standard C.
1433
1434 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1435
1436 * w32.c (emacs_gnutls_push): Fix typo.
1437
1438 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1439
1440 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1441 "cast to pointer from integer of different size".
1442
1443 Improve doprnt and its use in verror. (Bug#8545)
1444 * doprnt.c (doprnt): Document the set of format control sequences
1445 supported by the function. Use SAFE_ALLOCA instead of always
1446 using `alloca'.
1447
1448 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1449 is one byte too soon. Don't use xrealloc; instead xfree and
1450 xmalloc anew.
1451
1452 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1453
1454 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1455 callbacks stage.
1456
1457 * gnutls.c: Renamed global_initialized to
1458 gnutls_global_initialized. Added internals for the
1459 :verify-hostname-error, :verify-error, and :verify-flags
1460 parameters of `gnutls-boot' and documented those parameters in the
1461 docstring. Start callback support.
1462 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1463 unless a fatal error occured. Call gnutls_alert_send_appropriate
1464 on error. Return error code.
1465 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1466 (emacs_gnutls_read): Likewise.
1467 (Fgnutls_boot): Return handshake error code.
1468 (emacs_gnutls_handle_error): New function.
1469 (wsaerror_to_errno): Likewise.
1470
1471 * w32.h (emacs_gnutls_pull): Add prototype.
1472 (emacs_gnutls_push): Likewise.
1473
1474 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1475 (emacs_gnutls_push): Likewise.
1476
1477 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1478
1479 * process.c (wait_reading_process_output): Check if GnuTLS
1480 buffered some data internally if no FDs are set for TLS
1481 connections.
1482
1483 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1484 (LIBS): Link to USER_LIBS.
1485 ($(BLD)/gnutls.$(0)): New target.
1486
1487 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1488
1489 * xdisp.c (handle_single_display_spec): Rename the
1490 display_replaced_before_p argument into display_replaced_p, to
1491 make it consistent with the commentary. Fix typos in the
1492 commentary.
1493
1494 * textprop.c (syms_of_textprop): Remove dead code.
1495 (copy_text_properties): Delete obsolete commentary about an
1496 interface that was deleted long ago. Fix typos in the description
1497 of arguments.
1498
1499 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1500 to changes in oldXMenu/XMenu.h from 2011-04-16.
1501 <menu_help_message, prev_menu_help_message>: Constify.
1502 (IT_menu_make_room): menu->help_text is now `const char **';
1503 adjust.
1504
1505 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1506 to changes in oldXMenu/XMenu.h from 2011-04-16.
1507 (struct XMenu): Declare `help_text' `const char **'.
1508
1509 * xfaces.c <Qunspecified>: Make extern again.
1510
1511 * syntax.c: Include sys/types.h before including regex.h, as
1512 required by Posix.
1513
1514 * doc.c (get_doc_string): Improve the format passed to `error'.
1515
1516 * doprnt.c (doprnt): Improve commentary.
1517
1518 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1519
1520 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1521 them with etags.
1522
1523 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1524 changes in globals.h immediately force recompilation.
1525 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1526 $(CURDIR)/s/ms-w32.h.
1527 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1528
1529 * character.c (Fchar_direction): Function deleted.
1530 (syms_of_character): Don't defsubr it.
1531 <char-direction-table>: Deleted.
1532
1533 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1534
1535 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1536 * doprnt.c: Include limits.h.
1537 (SIZE_MAX): New macro.
1538 (doprnt): Return a size_t value. 2nd arg is now size_t.
1539 Many local variables are now size_t instead of int or unsigned.
1540 Improve overflow protection. Support `l' modifier for integer
1541 conversions. Support %l conversion. Don't assume an EMACS_INT
1542 argument for integer conversions and for %c.
1543
1544 * lisp.h (doprnt): Restore prototype.
1545
1546 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1547 $(SRC)/character.h.
1548
1549 * Makefile.in (base_obj): Add back doprnt.o.
1550
1551 * deps.mk (doprnt.o): Add back prerequisites.
1552 (callint.o): Depend on character.h.
1553
1554 * eval.c (internal_lisp_condition_case): Include the handler
1555 representation in the error message.
1556 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1557 when breaking from the loop.
1558
1559 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1560
1561 * callint.c (Fcall_interactively): When displaying error message
1562 about invalid control letter, pass the character's codepoint, not
1563 a pointer to its multibyte form. Improve display of the character
1564 in octal and display also its hex code.
1565
1566 * character.c (char_string): Use %x to display the (unsigned)
1567 codepoint of an invalid character, to avoid displaying a bogus
1568 negative value.
1569
1570 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1571 `error', not SYMBOL_NAME itself.
1572
1573 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1574 character arguments to `error'.
1575
1576 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1577 to `error' in error message about FINAL_CHAR argument. Make sure
1578 FINAL_CHAR is a character, and use %c when it is passed as
1579 argument to `error'.
1580
1581 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1582
1583 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1584
1585 * w32.c: Include <time.h>.
1586 (sys_localtime): New function.
1587
1588 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1589
1590 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1591
1592 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1593
1594 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1595
1596 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1597 zombies (Bug#8467).
1598
1599 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1600
1601 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1602 gl_state.e_property when gl_state.object is Qt.
1603
1604 * insdel.c (make_gap_larger): Remove limitation of buffer size
1605 to <= INT_MAX.
1606
1607 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1608
1609 * xdisp.c (lookup_glyphless_char_display)
1610 (produce_glyphless_glyph): Handle cons cell entry in
1611 glyphless-char-display.
1612 (Vglyphless_char_display): Document it.
1613
1614 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1615 glyphless-char-display.
1616
1617 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1618
1619 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1620
1621 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1622
1623 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1624 definition for no-X builds.
1625
1626 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 Static checks with GCC 4.6.0 and non-default toolkits.
1629
1630 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1631
1632 * process.c (keyboard_bit_set): Define only if SIGIO.
1633 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1634 (send_process): Repair possible setjmp clobbering.
1635
1636 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1637
1638 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1639
1640 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1641
1642 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1643 Define only if needed.
1644
1645 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1646 by pacifying GCC about it. Maybe it's time to retire it?
1647 * xfaces.c (USG, __TIMEVAL__): Likewise.
1648
1649 * dispextern.h (struct redisplay_interface): Rename param
1650 to avoid shadowing.
1651 * termhooks.h (struct terminal): Likewise.
1652 * xterm.c (xembed_send_message): Likewise.
1653
1654 * insdel.c (make_gap_smaller): Define only if
1655 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1656
1657 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1658 it.
1659
1660 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1661 so that we aren't warned about unused symbols.
1662
1663 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1664
1665 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1666
1667 * xfns.c (x_real_positions): Mark locals as initialized.
1668
1669 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1670
1671 * xterm.c: Fix problems found by static analysis with other toolkits.
1672 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1673 (x_dispatch_event): Declare static if USE_GTK, and
1674 define if USE_GTK || USE_X_TOOLKIT.
1675 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1676 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1677 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1678 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1679
1680 * xmenu.c (menu_help_callback): Pointer type fixes.
1681 Use const pointers when pointing at readonly data. Avoid pointer
1682 signedness clashes.
1683 (FALSE): Remove unused macro.
1684 (update_frame_menubar): Remove unused decl.
1685
1686 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1687
1688 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1689 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1690 (single_menu_item): Rename local to avoid shadowing.
1691
1692 * keyboard.c (make_lispy_event): Remove unused local var.
1693
1694 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1695 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1696
1697 * bitmaps: Change bitmaps from unsigned char back to the X11
1698 compatible char. Avoid the old compiler warnings about
1699 out-of-range initializers by using, for example, '\xab' rather
1700 than 0xab.
1701
1702 * xgselect.c (xgselect_initialize): Check vs interface
1703 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1704
1705 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1706
1707 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1708 to read-only memory.
1709
1710 * fns.c (vector): Remove; this old hack is no longer needed.
1711
1712 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1713 Remove unused var.
1714 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1715
1716 * xrdb.c (x_load_resources): Omit unused local.
1717
1718 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1719 (x_window): Rename locals to avoid shadowing.
1720 (USG): Use the kludged USG macro, to pacify gcc.
1721
1722 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1723 (x_term_init): Remove local to avoid shadowing.
1724
1725 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1726
1727 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1728 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1729
1730 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1731
1732 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1733
1734 Fix regex.c, syntax.c and friends for buffers > 2GB.
1735 * syntax.h (struct gl_state_s): Declare character position members
1736 EMACS_INT.
1737
1738 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1739
1740 * textprop.c (verify_interval_modification, interval_of):
1741 Declare arguments EMACS_INT.
1742
1743 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1744 EMACS_INT.
1745
1746 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1747
1748 * indent.c (Fvertical_motion): Local variable it_start is now
1749 EMACS_INT.
1750
1751 * regex.c (re_match, re_match_2, re_match_2_internal)
1752 (bcmp_translate, regcomp, regexec, print_double_string)
1753 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1754 (re_compile_pattern, re_exec): Declare arguments and local
1755 variables `size_t' and `ssize_t' and return values `regoff_t', as
1756 appropriate.
1757 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1758 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1759 <compile_stack_type>: `size' and `avail' are now `size_t'.
1760
1761 * regex.h <regoff_t>: Use ssize_t, not int.
1762 (re_search, re_search_2, re_match, re_match_2): Arguments that
1763 specify buffer/string position and length are now ssize_t and
1764 size_t. Return type is regoff_t.
1765
1766 2011-04-16 Ben Key <bkey76@gmail.com>
1767
1768 * nsfont.m: Fixed bugs in ns_get_family and
1769 ns_descriptor_to_entity that were caused by using free to
1770 deallocate memory blocks that were allocated by xmalloc (via
1771 xstrdup). This caused Emacs to crash when compiled with
1772 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1773 --enable-checking=xmallocoverrun). xfree is now used to
1774 deallocate these memory blocks.
1775
1776 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1779
1780 emacs_write: Accept and return EMACS_INT for sizes.
1781 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1782 et seq.
1783 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1784 Accept and return EMACS_INT.
1785 (emacs_gnutls_write): Return the number of bytes written on
1786 partial writes.
1787 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1788 (emacs_read, emacs_write): Remove check for negative size, as the
1789 Emacs source code has been audited now.
1790 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1791 (emacs_read, emacs_write): Use it.
1792 * process.c (send_process): Adjust to the new signatures of
1793 emacs_write and emacs_gnutls_write. Do not attempt to store
1794 a byte offset into an 'int'; it might overflow.
1795 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1796
1797 * sound.c: Don't assume sizes fit in 'int'.
1798 (struct sound_device.period_size, alsa_period_size):
1799 Return EMACS_INT, not int.
1800 (struct sound_device.write, vox_write, alsa_write):
1801 Accept EMACS_INT, not int.
1802 (wav_play, au_play): Use EMACS_INT to store sizes and to
1803 record read return values.
1804
1805 2011-04-15 Ben Key <bkey76@gmail.com>
1806
1807 * keyboard.c (Qundefined): Don't declare static since it is used
1808 in nsfns.m.
1809 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1810 static since they are used in nsfont.m.
1811
1812 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1813
1814 * process.c (Qprocessp): Don't declare static.
1815 * lisp.h (Qprocessp): Declare again.
1816
1817 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1818
1819 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1820
1821 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 Improve C-level modularity by making more things 'static'.
1824
1825 Don't publish debugger-only interfaces to other modules.
1826 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1827 (verify_bytepos, count_markers): Move decls to the only modules
1828 that need them.
1829 * region-cache.h (pp_cache): Likewise.
1830 * window.h (check_all_windows): Likewise.
1831 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1832
1833 * sysdep.c (croak): Now static, if
1834 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1835 * syssignal.h (croak): Declare only if not static.
1836
1837 * alloc.c (refill_memory_reserve): Now static if
1838 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1839 * lisp.h (refill_memory_reserve): Declare only if not static.
1840
1841 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1842 Define only if USE_LUCID.
1843
1844 * xrdb.c (x_customization_string, x_rm_string): Now static.
1845
1846 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1847 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1848
1849 * xdisp.c (draw_row_with_mouse_face): Now static.
1850 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1851
1852 * window.h (check_all_windows): Mark externally visible.
1853
1854 * window.c (window_deletion_count): Now static.
1855
1856 * undo.c: Make symbols static if they're not exported.
1857 (last_undo_buffer, last_boundary_position, pending_boundary):
1858 Now static.
1859
1860 * textprop.c (interval_insert_behind_hooks): Now static.
1861 (interval_insert_in_front_hooks): Likewise.
1862
1863 * term.c: Make symbols static if they're not exported.
1864 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1865 (max_frame_lines, tty_set_terminal_modes):
1866 (tty_reset_terminal_modes, tty_turn_off_highlight):
1867 (get_tty_terminal): Now static.
1868 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1869 * termhooks.h (term_mouse_moveto): Do not declare if
1870 HAVE_WINDOW_SYSTEM.
1871 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1872 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1873
1874 * sysdep.c: Make symbols static if they're not exported.
1875 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1876 Now static.
1877 (sigprocmask_set, full_mask): Remove; unused.
1878 (wait_debugging): Mark as visible.
1879 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1880 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1881
1882 * syntax.c (syntax_temp): Define only if !__GNUC__.
1883
1884 * sound.c (current_sound_device, current_sound): Now static.
1885
1886 * search.c (searchbufs, searchbuf_head): Now static.
1887
1888 * scroll.c (scroll_cost): Remove; unused.
1889 * dispextern.h (scroll_cost): Remove decl.
1890
1891 * region-cache.h (pp_cache): Mark as externally visible.
1892
1893 * process.c: Make symbols static if they're not exported.
1894 (process_tick, update_tick, create_process, chan_process):
1895 (Vprocess_alist, proc_buffered_char, datagram_access):
1896 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1897 (deactivate_process): Mark defn as static, as well as decl.
1898 * lisp.h (create_process): Remove decl.
1899 * process.h (chan_process, Vprocess_alist): Remove decls.
1900
1901 * print.c: Make symbols static if they're not exported.
1902 (print_depth, new_backquote_output, being_printed, print_buffer):
1903 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1904 (print_interval, print_number_index, initial_stderr_stream):
1905 Now static.
1906 * lisp.h (Fprinc): Remove decl.
1907 (debug_output_compilation_hack): Mark as externally visible.
1908
1909 * sysdep.c (croak): Move decl from here to syssignal.h.
1910 * syssignal.h (croak): Put it here, so the API can be checked when
1911 'croak' is called from dissociate_if_controlling_tty.
1912
1913 * minibuf.c: Make symbols static if they're not exported.
1914 (minibuf_save_list, choose_minibuf_frame): Now static.
1915 * lisp.h (choose_minibuf_frame): Remove decl.
1916
1917 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1918
1919 * lread.c: Make symbols static if they're not exported.
1920 (read_objects, initial_obarray, oblookup_last_bucket_number):
1921 Now static.
1922 (make_symbol): Remove; unused.
1923 * lisp.h (initial_obarray, make_symbol): Remove decls.
1924
1925 * keyboard.c: Make symbols static if they're not exported.
1926 (single_kboard, recent_keys_index, total_keys, recent_keys):
1927 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1928 (this_single_command_key_start, echoing, last_auto_save):
1929 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1930 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1931 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1932 (Vlispy_mouse_stem, double_click_count):
1933 Now static.
1934 (force_auto_save_soon): Define only if SIGDANGER.
1935 (ignore_mouse_drag_p): Now static if
1936 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1937 (print_help): Remove; unused.
1938 (stop_character, last_timer_event): Mark as externally visible.
1939 * keyboard.h (ignore_mouse_drag_p): Declare only if
1940 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1941 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1942 * lisp.h (echoing): Remove decl.
1943 (force_auto_save_soon): Declare only if SIGDANGER.
1944 * xdisp.c (redisplay_window): Simplify code, to make it more
1945 obvious that ignore_mouse_drag_p is not accessed if !defined
1946 USE_GTK && !defined HAVE_NS.
1947
1948 * intervals.c: Make symbols static if they're not exported.
1949 (merge_properties_sticky, merge_interval_right, delete_interval):
1950 Now static.
1951 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1952
1953 * insdel.c: Make symbols static if they're not exported.
1954 However, leave prepare_to_modify_buffer alone. It's never
1955 called from outside this function, but that appears to be a bug.
1956 (combine_after_change_list, combine_after_change_buffer):
1957 (adjust_after_replace, signal_before_change): Now static.
1958 (adjust_after_replace_noundo): Remove; unused.
1959 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1960 (signal_before_change): Remove decls.
1961
1962 * indent.c (val_compute_motion, val_vmotion): Now static.
1963
1964 * image.c: Make symbols static if they're not exported.
1965 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1966 if USE_GTK.
1967 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1968 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1969
1970 * fringe.c (standard_bitmaps): Now static.
1971 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1972
1973 * frame.c: Make symbols static if they're not exported.
1974 (x_report_frame_params, make_terminal_frame): Now static.
1975 (get_frame_param): Now static, unless HAVE_NS.
1976 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1977 (x_get_resource_string): Remove; not used.
1978 * frame.h (make_terminal_frame, x_report_frame_params):
1979 (x_get_resource_string); Remove decls.
1980 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1981 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1982
1983 * font.c, fontset.c: Make symbols static if they're not exported.
1984 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1985 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1986 * font.c (font_close_object): Now static.
1987 * font.h (font_close_object): Remove.
1988 * fontset.c (FONTSET_OBJLIST): Remove.
1989 (free_realized_fontset) #if-0 the body, which does nothing.
1990 (face_suitable_for_char_p): #if-0, as it's never called.
1991 * fontset.h (face_suitable_for_char_p): Remove decl.
1992 * xfaces.c (face_at_string_position):
1993 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1994 since 0 is always ASCII.
1995
1996 * fns.c (weak_hash_tables): Now static.
1997
1998 * fileio.c: Make symbols static if they're not exported.
1999 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2000 (Vwrite_region_annotation_buffers): Now static.
2001
2002 * eval.c: Make symbols static if they're not exported.
2003 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2004 * lisp.h (backtrace_list): Remove decl.
2005
2006 * emacs.c: Make symbols static if they're not exported.
2007 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2008 (fatal_error_code, fatal_error_signal_hook, standard_args):
2009 Now static.
2010 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2011 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2012 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2013 * lisp.h (fatal_error_signal_hook): Remove decl.
2014 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2015
2016 * editfns.c: Move a (normally-unused) function to its only use.
2017 * editfns.c, lisp.h (get_operating_system_release): Remove.
2018 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2019 worth the hassle of breaking this out.
2020
2021 * xterm.c: Make symbols static if they're not exported.
2022 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2023 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2024 (x_destroy_window, x_delete_display):
2025 Now static.
2026 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2027 (x_mouse_leave): Remove; unused.
2028 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2029 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2030 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2031 Remove decls.
2032 (x_mouse_leave): Declare only if WINDOWSNT.
2033 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2034 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2035 USE_X_TOOLKIT.
2036
2037 * ftxfont.c: Make symbols static if they're not exported.
2038 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2039 HAVE_FREETYPE.
2040 * font.h (ftxfont_driver): Likewise.
2041
2042 * xfns.c: Make symbols static if they're not exported.
2043 (x_last_font_name, x_display_info_for_name):
2044 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2045 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2046 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2047 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2048 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2049 (last_show_tip_args): Now static.
2050 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2051 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2052 (x_screen_planes): Remove; unused.
2053 * dispextern.h (x_screen_planes): Remove decl.
2054
2055 * dispnew.c: Make symbols static if they're not exported.
2056 * dispextern.h (redraw_garbaged_frames, scrolling):
2057 (increment_row_positions): Remove.
2058 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2059 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2060 Now static.
2061 (redraw_garbaged_frames): Remove; unused.
2062
2063 * xfaces.c: Make symbols static if they're not exported.
2064 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2065 Remove decls.
2066 * xterm.h (defined_color): Remove decls.
2067 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2068 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2069 (menu_face_changed_default, defined_color, free_realized_face):
2070 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2071 (ascii_face_of_lisp_face): Remove; unused.
2072
2073 * xdisp.c: Make symbols static if they're not exported.
2074 * dispextern.h (scratch_glyph_row, window_box_edges):
2075 (glyph_to_pixel_coords, set_cursor_from_row):
2076 (get_next_display_element, set_iterator_to_next):
2077 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2078 (show_mouse_face): Remove decls
2079 * frame.h (message_buf_print): Likewise.
2080 * lisp.h (pop_message, set_message, check_point_in_composition):
2081 Likewise.
2082 * xterm.h (set_vertical_scroll_bar): Likewise.
2083 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2084 (message_buf_print, scratch_glyph_row, displayed_buffer):
2085 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2086 (get_next_display_element, show_mouse_face, window_box_edges):
2087 (frame_to_window_pixel_xy, check_point_in_composition):
2088 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2089 (glyph_to_pixel_coords): Remove; unused.
2090
2091 * dired.c (file_name_completion): Now static.
2092
2093 * dbusbind.c (xd_in_read_queued_messages): Now static.
2094
2095 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2096 * data.c (circular_list_error): Remove.
2097
2098 * commands.h (last_point_position, last_point_position_buffer):
2099 (last_point_position_window): Remove decls.
2100 * keyboard.c: Make these variables static.
2101
2102 * coding.h (coding, code_convert_region, encode_coding_gap):
2103 Remove decls.
2104 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2105 (iso_code_class, detect_coding, code_convert_region): Now static.
2106 (encode_coding_gap): Remove; unused.
2107
2108 * chartab.c (chartab_chars, chartab_bits): Now static.
2109
2110 * charset.h (charset_iso_8859_1): Remove decl.
2111 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2112 Now static.
2113
2114 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2115 * ccl.c (Vccl_program_table): Now static.
2116 (check_ccl_update): Remove; unused.
2117
2118 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2119 * category.h: ... from here.
2120 * category.c (check_category_table, set_category_set): Now static.
2121
2122 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2123 * lisp.h: Remove these decls.
2124
2125 * buffer.c (buffer_count): Remove unused var.
2126
2127 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2128 so that it's not optimized away.
2129 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2130 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2131 exported only to the debugger.
2132
2133 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2134 * atimer.h (run_all_atimers): Remove; not exported.
2135
2136 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2137 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2138 was inaccessible from Lisp.
2139 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2140 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2141
2142 alloc.c: Import and export fewer symbols, and remove unused items.
2143 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2144 is defined.
2145 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2146 it's not optimized away by whole-program optimization.
2147 (message_enable_multibyte, free_misc): Remove.
2148 (catchlist, handlerlist, mark_backtrace):
2149 Declare only if BYTE_MARK_STACK.
2150 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2151 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2152 (message_enable_multibyte): Remove decl.
2153 (free_misc, interval_free_list, float_block, float_block_index):
2154 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2155 (cons_free_list, last_marked_index):
2156 Now static.
2157 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2158 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2159 (mark_backtrace): Define only if BYTE_MARK_STACK.
2160 * xdisp.c (message_enable_multibyte): Now static.
2161
2162 Declare Lisp_Object Q* variables to be 'static' if not exported.
2163 This makes it easier for human readers (and static analyzers)
2164 to see whether these variables are used from other modules.
2165 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2166 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2167 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2168 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2169 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2170 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2171 * xmenu.c, xselect.c:
2172 Declare Q* vars static if they are not used in other modules.
2173 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2174 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2175 Remove decls of unexported vars.
2176 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2177
2178 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2179
2180 Make Emacs functions such as Fatom 'static' by default.
2181 This makes it easier for human readers (and static analyzers)
2182 to see whether these functions can be called from other modules.
2183 DEFUN now defines a static function. To make the function external
2184 so that it can be used in other C modules, use the new macro DEFUE.
2185 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2186 (Finit_image_library):
2187 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2188 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2189 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2190 Remove decls, since these functions are now static.
2191 (Funintern, Fget_internal_run_time): New decls, since these functions
2192 were already external.
2193
2194 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2195 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2196 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2197 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2198 * keyboard.c, keymap.c, lread.c:
2199 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2200 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2201 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2202 Mark functions with DEFUE instead of DEFUN,
2203 if they are used in other modules.
2204 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2205 decls for now-static functions.
2206 * buffer.h (Fdelete_overlay): Remove decl.
2207 * callproc.c (Fgetenv_internal): Mark as internal.
2208 * composite.c (Fremove_list_of_text_properties): Remove decl.
2209 (Fcomposition_get_gstring): New forward static decl.
2210 * composite.h (Fcomposite_get_gstring): Remove decl.
2211 * dired.c (Ffile_attributes): New forward static decl.
2212 * doc.c (Fdocumntation_property): New forward static decl.
2213 * eval.c (Ffetch_bytecode): New forward static decl.
2214 (Funintern): Remove extern decl; now in .h file where it belongs.
2215 * fileio.c (Fmake_symbolic_link): New forward static decl.
2216 * image.c (Finit_image_library): New forward static decl.
2217 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2218 * intervals.h (Fprevious_property_change):
2219 (Fremove_list_of_text_properties): Remove decls.
2220 * keyboard.c (Fthis_command_keys): Remove decl.
2221 (Fcommand_execute): New forward static decl.
2222 * keymap.c (Flookup_key): New forward static decl.
2223 (Fcopy_keymap): Now static.
2224 * keymap.h (Flookup_key): Remove decl.
2225 * process.c (Fget_process): New forward static decl.
2226 (Fprocess_datagram_address): Mark as internal.
2227 * syntax.c (Fsyntax_table_p): New forward static decl.
2228 (skip_chars): Remove duplicate decl.
2229 * textprop.c (Fprevious_property_change): New forward static decl.
2230 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2231 Now internal.
2232 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2233 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2234
2235 * editfns.c (Fformat): Remove unreachable code.
2236
2237 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2238
2239 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2240 change. (Bug#8496)
2241
2242 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2243
2244 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2245 when at ZV. (Bug#8487)
2246
2247 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2248
2249 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2250 (Bug#8437)
2251 * keyboard.c (parse_tool_bar_item): Likewise.
2252 * sound.c (sound_cleanup, alsa_close): Likewise.
2253 * termcap.c (tgetent): Likewise.
2254 * xfns.c (x_default_font_parameter): Likewise.
2255 * xsettings.c (read_and_apply_settings): Likewise.
2256
2257 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2258 (overrun_check_free): Protoize.
2259
2260 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2263 since callers should never pass a negative size.
2264 Change the signature to match that of plain 'read' and 'write'; see
2265 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2266 * lisp.h: Update prototypes of emacs_write and emacs_read.
2267
2268 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2269
2270 * xdisp.c (redisplay_window): Don't try to determine the character
2271 position of the scroll margin if the window start point w->startp
2272 is outside the buffer's accessible region. (Bug#8468)
2273
2274 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2275
2276 Fix write-region and its subroutines for buffers > 2GB.
2277 * fileio.c (a_write, e_write): Modify declaration of arguments and
2278 local variables to support buffers larger than 2GB.
2279 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2280
2281 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2282 argument, local variables, and return value.
2283
2284 * lisp.h: Update prototypes of emacs_write and emacs_read.
2285
2286 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2287
2288 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2289
2290 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2291
2292 Fix more problems found by GCC 4.6.0's static checks.
2293
2294 * xdisp.c (vmessage): Use a better test for character truncation.
2295
2296 * charset.c (load_charset_map): <, not <=, for optimization,
2297 and to avoid potential problems with integer overflow.
2298 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2299 * casetab.c (set_identity, shuffle): Likewise.
2300 * editfns.c (Fformat): Likewise.
2301 * syntax.c (skip_chars): Likewise.
2302
2303 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2304 This also lets GCC 4.6.0 generate slightly better loop code.
2305
2306 * callint.c (Fcall_interactively): <, not <=, for optimization.
2307 (Fcall_interactively): Count the number of arguments produced,
2308 not the number of arguments given. This is simpler and lets GCC
2309 4.6.0 generate slightly better code.
2310
2311 * ftfont.c: Distingish more carefully between FcChar8 and char.
2312 The previous code passed unsigned char * to a functions like
2313 strlen and xstrcasecmp that expect char *, which does not
2314 conform to the C standard.
2315 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2316 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2317 char * when the C standard requires it.
2318
2319 * keyboard.c (read_char): Remove unused var.
2320
2321 * eval.c: Port to Windows vsnprintf (Bug#8435).
2322 Include <limits.h>.
2323 (SIZE_MAX): Define if the headers do not.
2324 (verror): Do not give up if vsnprintf returns a negative count.
2325 Instead, grow the buffer. This ports to Windows vsnprintf, which
2326 does not conform to C99. Problem reported by Eli Zaretskii.
2327 Also, simplify the allocation scheme, by avoiding the need for
2328 calling realloc, and removing the ALLOCATED variable.
2329
2330 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2331
2332 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2333 But keep the doprint source code for now, as we might revamp it
2334 and use it again (Bug#8435).
2335 * lisp.h (doprnt): Remove.
2336 * Makefile.in (base_obj): Remove doprnt.o.
2337 * deps.mk (doprnt.o): Remove.
2338
2339 error: Print 32- and 64-bit integers portably (Bug#8435).
2340 Without this change, on typical 64-bit hosts error ("...%d...", N)
2341 was used to print both 32- and 64-bit integers N, which relied on
2342 undefined behavior.
2343 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2344 New macro.
2345 * lisp.h (error, verror): Mark as printf-like functions.
2346 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2347 Report overflow in size calculations when allocating printf buffer.
2348 Do not truncate output string at its first null byte.
2349 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2350 Truncate the output at a character boundary, since vsnprintf does not
2351 do that.
2352 * charset.c (check_iso_charset_parameter): Convert internal
2353 character to string before calling 'error', since %c now has the
2354 printf meaning.
2355 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2356 overflow when computing char to be passed to 'error'. Do not
2357 pass Lisp_Object to 'error'; pass the integer instead.
2358 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2359 formatted with plain %d.
2360
2361 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2362
2363 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2364
2365 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2366
2367 * xterm.c (x_catch_errors): Remove duplicate declaration.
2368
2369 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2370
2371 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2372
2373 2011-04-10 Jim Meyering <meyering@redhat.com>
2374
2375 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2376 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2377 return ssize_t not "int", and use size_t as the buffer length.
2378 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2379 * gnutls.h: Update declarations.
2380 * process.c (read_process_output): Use ssize_t, to match.
2381 (send_process): Likewise.
2382
2383 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2384
2385 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2386
2387 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2388
2389 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2390 Use unsigned char, to match FcChar8 type definition.
2391
2392 * xterm.c (handle_one_xevent):
2393 * xmenu.c (create_and_show_popup_menu):
2394 * xselect.c (x_decline_selection_request)
2395 (x_reply_selection_request): Avoid type-punned deref of X events.
2396
2397 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2398
2399 Fix some uses of `int' instead of EMACS_INT.
2400 * search.c (string_match_1, fast_string_match)
2401 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2402 (scan_buffer, find_next_newline_no_quit)
2403 (find_before_next_newline, search_command, Freplace_match)
2404 (Fmatch_data): Make some `int' variables be EMACS_INT.
2405
2406 * xdisp.c (display_count_lines): 3rd argument and return value now
2407 EMACS_INT. All callers changed.
2408 (pint2hrstr): Last argument is now EMACS_INT.
2409
2410 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2411 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2412 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2413 (decode_coding_utf_16, decode_coding_emacs_mule)
2414 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2415 (decode_coding_ccl, decode_coding_charset)
2416 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2417 (decode_coding_iso_2022, decode_coding_emacs_mule)
2418 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2419 <char_offset, last_offset>: Declare EMACS_INT.
2420 (encode_coding_utf_8, encode_coding_utf_16)
2421 (encode_coding_emacs_mule, encode_invocation_designation)
2422 (encode_designation_at_bol, encode_coding_iso_2022)
2423 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2424 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2425 Declare EMACS_INT.
2426 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2427 (encode_invocation_designation): Last argument P_NCHARS is now
2428 EMACS_INT.
2429 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2430 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2431
2432 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2433 All users changed.
2434
2435 * ccl.c (Fccl_execute_on_string): Declare some variables
2436 EMACS_INT.
2437
2438 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2439
2440 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2441
2442 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2443
2444 * process.c (Fformat_network_address): Doc fix.
2445
2446 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2447
2448 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2449
2450 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2451
2452 * keyboard.c (read_char): Call Lisp function help-form-show,
2453 instead of using internal_with_output_to_temp_buffer.
2454 (Qhelp_form_show): New var.
2455 (syms_of_keyboard): Use DEFSYM macro.
2456
2457 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2458
2459 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2460
2461 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2462
2463 * process.c (Flist_processes): Remove to Lisp.
2464 (list_processes_1): Delete.
2465
2466 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2467
2468 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2469
2470 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2471
2472 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2473
2474 Fix more problems found by GCC 4.6.0's static checks.
2475
2476 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2477
2478 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2479
2480 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2481
2482 * xdisp.c (vmessage): Mark as a printf-like function.
2483
2484 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2485
2486 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2487
2488 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2489 printf-like functions.
2490 (tiff_load): Add casts to remove these marks before passing them
2491 to system-supplied API.
2492
2493 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2494
2495 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2496 This avoids several warnings with gcc -Wstrict-overflow.
2497 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2498 directly, rather than having caller test rule sign. This avoids
2499 some unnecessary tests.
2500 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2501 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2502 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2503
2504 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2505 (xfont_open): Avoid unnecessary tests.
2506
2507 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2508
2509 * composite.h, composite.c (composition_gstring_put_cache):
2510 Use EMACS_INT, not int, for length.
2511
2512 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2513 breaking out part of COMPOSITION_DECODE_RULE.
2514 (COMPOSITION_DECODE_RULE): Use it.
2515 * composite.c (get_composition_id): Remove unused local vars,
2516 by using the new macro.
2517
2518 * textprop.c (set_text_properties_1): Change while to do-while,
2519 since the condition is always true at first.
2520
2521 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2522 (interval_deletion_adjustment): Return unsigned value.
2523 All uses changed.
2524
2525 * process.c (list_processes_1, create_pty, read_process_output):
2526 (exec_sentinel): Remove vars that were set but not used.
2527 (create_pty): Remove unnecessary "volatile"s.
2528 (Fnetwork_interface_info): Avoid possibility of int overflow.
2529 (read_process_output): Do adaptive read buffering even if carryover.
2530 (read_process_output): Simplify nbytes computation if buffered.
2531
2532 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2533
2534 * syntax.c (scan_words): Remove var that was set but not used.
2535 (update_syntax_table): Use unsigned instead of int.
2536
2537 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2538 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2539 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2540
2541 * print.c (print_error_message): Avoid int overflow.
2542
2543 * font.c (font_list_entities): Redo for clarity,
2544 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2545
2546 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2547 (font_score): Avoid potential overflow in diff calculation.
2548
2549 * fns.c (substring_both): Remove var that is set but not used.
2550 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2551
2552 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2553
2554 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2555 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2556 can always succeed if overflow has undefined behavior.
2557
2558 * search.c (boyer_moore, wordify): Remove vars set but not used.
2559 (wordify): Omit three unnecessary tests.
2560
2561 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2562 All callers changed. This avoids the need for an unused var.
2563
2564 * casefiddle.c (casify_region): Remove var that is set but not used.
2565
2566 * dired.c (file_name_completion): Remove var that is set but not used.
2567
2568 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2569
2570 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2571 (Finsert_file_contents): Remove unnecessary code checking fd.
2572
2573 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2574 Check for integer overflow on size calculations.
2575
2576 * buffer.c (Fprevious_overlay_change): Remove var that is set
2577 but not used.
2578
2579 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2580 Remove vars that are set but not used.
2581 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2582 (timer_check_2): Mark vars as initialized.
2583
2584 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2585
2586 * image.c (lookup_image): Remove var that is set but not used.
2587 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2588
2589 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2590 that are set but not used.
2591
2592 * xfns.c (make_invisible_cursor): Don't return garbage
2593 if XCreateBitmapFromData fails (Bug#8410).
2594
2595 * xselect.c (x_get_local_selection, x_handle_property_notify):
2596 Remove vars that are set but not used.
2597
2598 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2599 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2600
2601 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2602 Remove var that is set but not used.
2603 (scroll_bar_windows_size): Now size_t, not int.
2604 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2605 Check for overflow.
2606
2607 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2608 (map_tty_color) [!defined MSDOS]: Likewise.
2609
2610 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2611
2612 * coding.c: Remove vars that are set but not used.
2613 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2614 All callers changed.
2615 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2616 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2617 (decode_coding_charset): Remove vars that are set but not used.
2618
2619 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2620 that is set but not used.
2621
2622 * print.c (print_object): Remove var that is set but not used.
2623
2624 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2625 The gnulib version avoids calling malloc in the usual case,
2626 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2627 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2628 * filelock.c (current_lock_owner): Likewise.
2629 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2630 * sysdep.c: Include allocator.h, careadlinkat.h.
2631 (emacs_no_realloc_allocator): New static constant.
2632 (emacs_readlink): New function.
2633 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2634 ../lib/careadlinkat.h.
2635
2636 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2637
2638 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2639 first non-nil return value).
2640
2641 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2642
2643 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2644 if not defined (Bug#8403).
2645
2646 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2647
2648 * xdisp.c (display_count_lines): Remove parameter `start',
2649 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2650 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2651 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2652 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2653 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2654 and thereabouts. All callers changed.
2655 (get_per_char_metric): Remove parameter `f', unused since
2656 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2657
2658 2011-04-02 Jim Meyering <meyering@redhat.com>
2659
2660 do not dereference NULL upon failed strdup
2661 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2662 (ns_get_family): Likewise.
2663
2664 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2665
2666 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2667
2668 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2669
2670 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2671 later (Bug#8403).
2672
2673 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2674
2675 Add lexical binding.
2676
2677 * window.c (Ftemp_output_buffer_show): New fun.
2678 (Fsave_window_excursion):
2679 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2680
2681 * lread.c (lisp_file_lexically_bound_p): New function.
2682 (Fload): Bind Qlexical_binding.
2683 (readevalloop): Remove `evalfun' arg.
2684 Bind Qinternal_interpreter_environment.
2685 (Feval_buffer): Bind Qlexical_binding.
2686 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2687 Mark as dynamic.
2688 (syms_of_lread): Declare `lexical-binding'.
2689
2690 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2691
2692 * keyboard.c (eval_dyn): New fun.
2693 (menu_item_eval_property): Use it.
2694
2695 * image.c (parse_image_spec): Use Ffunctionp.
2696
2697 * fns.c (concat, mapcar1): Accept byte-code-functions.
2698
2699 * eval.c (Fsetq): Handle lexical vars.
2700 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2701 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2702 (FletX, Flet): Obey lexical binding.
2703 (Fcommandp): Handle closures.
2704 (Feval): New `lexical' arg.
2705 (eval_sub): New function extracted from Feval. Use it almost
2706 everywhere where Feval was used. Look up vars in lexical env.
2707 Handle closures.
2708 (Ffunctionp): Move from subr.el.
2709 (Ffuncall): Handle closures.
2710 (apply_lambda): Remove `eval_flags'.
2711 (funcall_lambda): Handle closures and new byte-code-functions.
2712 (Fspecial_variable_p): New function.
2713 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2714 but without exporting it to Lisp.
2715
2716 * doc.c (Fdocumentation, store_function_docstring):
2717 * data.c (Finteractive_form): Handle closures.
2718
2719 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2720 interactive spec.
2721
2722 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2723 New byte-codes.
2724 (exec_byte_code): New function extracted from Fbyte_code to handle new
2725 calling convention for byte-code-functions. Add new byte-codes.
2726
2727 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2728
2729 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2730
2731 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2732
2733 * xdisp.c (redisplay_internal): Fix prototype.
2734
2735 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2736
2737 * xdisp.c (SCROLL_LIMIT): New macro.
2738 (try_scrolling): Use it when setting scroll_limit.
2739 Limit scrolling to 100 screen lines.
2740 (redisplay_window): Even when falling back on "recentering",
2741 position point in the window according to scroll-conservatively,
2742 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2743
2744 (try_scrolling): When point is above the window, allow searching
2745 as far as scroll_max, or one screenful, to compute vertical
2746 distance from PT to the scroll margin position. This prevents
2747 try_scrolling from unnecessarily failing when
2748 scroll-conservatively is set to a value slightly larger than the
2749 window height. Clean up the case of PT below the margin at bottom
2750 of window: scroll_max can no longer be INT_MAX. When aggressive
2751 scrolling is in use, don't let point enter the opposite scroll
2752 margin as result of the scroll.
2753 (syms_of_xdisp) <scroll-conservatively>: Document the
2754 threshold of 100 lines for never-recentering scrolling.
2755
2756 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2757
2758 * dispextern.h (move_it_by_lines):
2759 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2760 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2761 (message_log_check_duplicate): Remove parameters `prev_bol' and
2762 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2763 (redisplay_internal): Remove parameter `preserve_echo_area',
2764 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2765
2766 * indent.c (Fvertical_motion):
2767 * window.c (window_scroll_pixel_based, Frecenter):
2768 Don't pass `need_y_p' to `move_it_by_lines'.
2769
2770 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2771
2772 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2773 steal a few bits to be more compact.
2774 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2775 Remove unneeded casts.
2776
2777 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2778
2779 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2780
2781 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2782 binding" message (bug#7967).
2783
2784 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2785
2786 Fix more problems found by GCC 4.6.0's static checks.
2787
2788 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2789 Remove unused local var.
2790
2791 * editfns.c (Fmessage_box): Remove unused local var.
2792
2793 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2794 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2795 Omit unused local vars.
2796 * window.c (shrink_windows): Omit unused local var.
2797 * menu.c (digest_single_submenu): Omit unused local var.
2798 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2799 Omit unused local var.
2800
2801 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2802 Don't assume string length fits in int.
2803 (keyremap_step, read_key_sequence): Use size_t for sizes.
2804 (read_key_sequence): Don't check last_real_key_start redundantly.
2805
2806 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2807 instead of alloca (Bug#8344).
2808
2809 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2810 (Fbacktrace_frame): Don't assume nframes fits in int.
2811
2812 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2813
2814 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2815 concerns.
2816
2817 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2818
2819 * cm.c (calccost): Turn while-do into do-while, for clarity.
2820
2821 * keyboard.c (syms_of_keyboard): Use the same style as later
2822 in this function when indexing through an array. This also
2823 works around GCC bug 48267.
2824
2825 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2826
2827 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2828
2829 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2830 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2831
2832 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2833 This avoids undefined behavior on integer overflow, and is a bit
2834 more convenient anyway since it is compared to a size_t variable.
2835
2836 Variadic C functions now count arguments with size_t, not int.
2837 This avoids an unnecessary limitation on 64-bit machines, which
2838 caused (substring ...) to crash on large vectors (Bug#8344).
2839 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2840 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2841 All variadic functions and their callers changed accordingly.
2842 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2843 * data.c (arith_driver, float_arith_driver): Likewise.
2844 * editfns.c (general_insert_function): Likewise.
2845 * eval.c (struct backtrace.nargs, interactive_p)
2846 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2847 (funcall_lambda, mark_backtrace): Likewise.
2848 * fns.c (concat): Likewise.
2849 * frame.c (x_set_frame_parameters): Likewise.
2850 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2851 0 if not found, not -1. All callers changed.
2852
2853 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2854 (stack_copy_size): Now size_t, not int.
2855 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2856
2857 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2858
2859 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2860 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2861 All callers changed.
2862
2863 * lisp.h (multibyte_char_to_unibyte):
2864 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2865 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2866 * character.h (CHAR_TO_BYTE8):
2867 * cmds.c (internal_self_insert):
2868 * editfns.c (general_insert_function):
2869 * keymap.c (push_key_description):
2870 * search.c (Freplace_match):
2871 * xdisp.c (message_dolog, set_message_1): All callers changed.
2872
2873 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2874
2875 * keyboard.c (safe_run_hook_funcall): New function.
2876 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2877 don't set the hook to nil, but remove the offending function instead.
2878 (Qcommand_hook_internal): Remove, unused.
2879 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2880 Vcommand_hook_internal.
2881
2882 * eval.c (enum run_hooks_condition): Remove.
2883 (funcall_nil, funcall_not): New functions.
2884 (run_hook_with_args): Call each function through a `funcall' argument.
2885 Remove `cond' argument, now redundant.
2886 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2887 (Frun_hook_with_args_until_failure): Adjust accordingly.
2888 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2889
2890 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2891
2892 * dispextern.h (string_buffer_position): Remove declaration.
2893
2894 * print.c (strout): Remove parameter `multibyte', unused since
2895 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2896
2897 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2898 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2899 All callers changed.
2900
2901 * w32.c (_wsa_errlist): Use braces for struct initializers.
2902
2903 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2904 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2905 All callers changed.
2906 (string_buffer_position): Likewise. Also, make static (it's never
2907 used outside xdisp.c).
2908 (cursor_row_p): Remove parameter `w', unused since
2909 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2910 (decode_mode_spec): Remove parameter `precision', introduced during
2911 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2912 All callers changed.
2913
2914 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2915
2916 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2917
2918 2011-03-27 Anders Lindgren <andlind@gmail.com>
2919
2920 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2921 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2922 (ns_update_auto_hide_menu_bar): New functions.
2923 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2924 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2925 ns_constrain_all_frames.
2926 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2927 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2928
2929 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2930
2931 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2932
2933 2011-03-27 Glenn Morris <rgm@gnu.org>
2934
2935 * syssignal.h: Replace RETSIGTYPE with void.
2936 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2937 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2938 Replace SIGTYPE with void everywhere.
2939 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2940 * s/template.h (SIGTYPE): Remove commented out definition.
2941
2942 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2943
2944 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2945 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2946
2947 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2948
2949 * w32.c (read_unc_volume): Use parameter `henum', instead of
2950 global variable `wget_enum_handle'.
2951
2952 * keymap.c (describe_vector): Remove parameters `indices' and
2953 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2954 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2955
2956 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2957
2958 * keyboard.c (timer_check): Remove parameter `do_it_now',
2959 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2960 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2961 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2962
2963 * keyboard.c (read_char):
2964 * w32menu.c (w32_menu_display_help):
2965 * xmenu.c (show_help_event, menu_help_callback):
2966 Adjust calls to `show_help_echo'.
2967
2968 * gtkutil.c (xg_maybe_add_timer):
2969 * keyboard.c (readable_events):
2970 * process.c (wait_reading_process_output):
2971 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2972
2973 * insdel.c (adjust_markers_gap_motion):
2974 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2975 (gap_left, gap_right): Don't call it.
2976
2977 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2978
2979 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2980 incurred during fontification.
2981
2982 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2983
2984 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2985 (DEFVAR_PER_BUFFER): Don't pass it.
2986
2987 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2988 (scrolling_window): Don't pass it.
2989
2990 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2991
2992 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2993
2994 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2995 and `suffix'.
2996 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2997 of variables specific to SELinux and computation of `encoded_absname'.
2998
2999 * image.c (XPutPixel): Remove unused variable `height'.
3000
3001 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3002
3003 * unexw32.c (get_section_info): Remove unused variable `section'.
3004
3005 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3006 (system_process_attributes): Remove unused variable `sess'.
3007 (sys_read): Remove unused variable `err'.
3008
3009 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3010 (w32_wnd_proc): Remove unused variable `isdead'.
3011 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3012 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3013 (x_create_tip_frame): Remove unused variable `tem'.
3014
3015 * w32inevt.c (w32_console_read_socket):
3016 Remove unused variable `no_events'.
3017
3018 * w32term.c (x_draw_composite_glyph_string_foreground):
3019 Remove unused variable `width'.
3020
3021 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3022
3023 * w32term.c (x_set_glyph_string_clipping):
3024 Don't pass uninitialized region to CombineRgn.
3025
3026 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3027
3028 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3029 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3030 (Fx_close_connection): Remove unused variable `i'.
3031
3032 * w32font.c (w32font_draw): Return number of glyphs.
3033 (w32font_open_internal): Remove unused variable `i'.
3034 (w32font_driver): Add missing initializer.
3035
3036 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3037 (fill_in_menu): Remove unused variable `items_added'.
3038
3039 * w32term.c (last_mouse_press_frame): Remove static global variable.
3040 (w32_clip_to_row): Remove unused variable `f'.
3041 (x_delete_terminal): Remove unused variable `i'.
3042
3043 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3044 (NOTHING): Remove unused static global variable.
3045 (uniscribe_check_otf): Remove unused variable `table'.
3046 (uniscribe_font_driver): Add missing initializers.
3047
3048 2011-03-23 Julien Danjou <julien@danjou.info>
3049
3050 * term.c (Fsuspend_tty, Fresume_tty):
3051 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3052 * window.c (temp_output_buffer_show):
3053 * insdel.c (signal_before_change):
3054 * frame.c (Fhandle_switch_frame):
3055 * fileio.c (Fdo_auto_save):
3056 * emacs.c (Fkill_emacs):
3057 * editfns.c (save_excursion_restore):
3058 * cmds.c (internal_self_insert):
3059 * callint.c (Fcall_interactively):
3060 * buffer.c (Fkill_all_local_variables):
3061 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3062 Use Frun_hooks.
3063 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3064 unconditionnaly since it does the check itself.
3065
3066 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 Fix more problems found by GCC 4.5.2's static checks.
3069
3070 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3071 the first time through the loop, since we know p0 < p1 then.
3072 This also avoids a gcc -Wstrict-overflow warning.
3073
3074 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3075 leading to a memory leak, possible in functions like
3076 load_charset_map_from_file that can allocate an unbounded number
3077 of objects (Bug#8318).
3078
3079 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3080 that could (at least in theory) be that large.
3081
3082 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3083 This is less likely to overflow, and avoids undefined behavior if
3084 overflow does occur. All callers changed. Use strtoul to scan
3085 for the unsigned long integer.
3086 (pint2hrstr): Simplify and tune code slightly.
3087 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3088
3089 * scroll.c (do_scrolling): Work around GCC bug 48228.
3090 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3091
3092 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3093 This also avoids a warning with gcc -Wstrict-overflow.
3094 (validate_x_resource_name): Simplify count usage.
3095 This also avoids a warning with gcc -Wstrict-overflow.
3096
3097 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3098 fail (Bug#8306).
3099
3100 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3101
3102 * process.c (Fmake_network_process): Use socklen_t, not int,
3103 where POSIX says socklen_t is required in portable programs.
3104 This fixes a porting bug on hosts like 64-bit HP-UX, where
3105 socklen_t is wider than int (Bug#8277).
3106 (Fmake_network_process, server_accept_connection):
3107 (wait_reading_process_output, read_process_output):
3108 Likewise.
3109
3110 * process.c: Rename or move locals to avoid shadowing.
3111 (list_processes_1, Fmake_network_process):
3112 (read_process_output_error_handler, exec_sentinel_error_handler):
3113 Rename or move locals.
3114 (Fmake_network_process): Define label "retry_connect" only if needed.
3115 (Fnetwork_interface_info): Fix pointer signedness.
3116 (process_send_signal): Add cast to avoid pointer signedness problem.
3117 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3118 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3119
3120 Make tparam.h and terminfo.c consistent.
3121 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3122 Include tparam.h instead, since it declares them.
3123 * cm.h (PC): Remove extern decl; tparam.h now does this.
3124 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3125 * terminfo.c: Include tparam.h, to check interfaces.
3126 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3127 (tparam): Adjust signature to match interface in tparam.h;
3128 this removes some undefined behavior. Check that outstring and len
3129 are zero, which they always are with Emacs.
3130 * tparam.h (PC, BC, UP): New extern decls.
3131
3132 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3133 (xftfont_open): Rename locals to avoid shadowing.
3134
3135 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3136 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3137 (OTF_TAG_SYM): Omit macro if not needed.
3138 (ftfont_list): Remove unused local.
3139 (get_adstyle_property, ftfont_pattern_entity):
3140 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3141 Rename locals to avoid shadowing.
3142
3143 * xfont.c (xfont_list_family): Mark var as initialized.
3144
3145 * xml.c (make_dom): Now static.
3146
3147 * composite.c (composition_compute_stop_pos): Rename local to
3148 avoid shadowing.
3149 (composition_reseat_it): Remove unused locals.
3150 (find_automatic_composition, composition_adjust_point): Likewise.
3151 (composition_update_it): Mark var as initialized.
3152 (find_automatic_composition): Mark vars as initialized,
3153 with a FIXME (Bug#8290).
3154
3155 character.h: Rename locals to avoid shadowing.
3156 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3157 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3158 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3159 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3160 to avoid shadowing.
3161
3162 * textprop.c (property_change_between_p): Remove; unused.
3163
3164 * intervals.c (interval_start_pos): Now static.
3165
3166 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3167
3168 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3169 Rename locals to avoid shadowing.
3170
3171 * sound.c (wav_play, au_play, Fplay_sound_internal):
3172 Fix pointer signedness.
3173 (alsa_choose_format): Remove unused local var.
3174 (wav_play): Initialize a variable to 0, to prevent undefined
3175 behavior (Bug#8278).
3176
3177 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3178
3179 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3180
3181 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3182 clobbering (Bug#8298).
3183 * sysdep.c (sys_subshell): Likewise.
3184 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3185
3186 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3187 This should get cleaned up, so that child_setup has the
3188 same signature on all platforms.
3189
3190 * callproc.c (call_process_cleanup): Now static.
3191 (relocate_fd): Rename locals to avoid shadowing.
3192
3193 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3194
3195 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3196 not to be necessary, and produces flickering.
3197
3198 2011-03-20 Glenn Morris <rgm@gnu.org>
3199
3200 * config.in: Remove file.
3201
3202 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3203
3204 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3205 are now in src/globals.h.
3206 (syms_of_minibuf): Remove spurious & from previous change.
3207
3208 2011-03-20 Leo <sdl.web@gmail.com>
3209
3210 * minibuf.c (completing-read-function): New variable.
3211 (completing-read-default): Rename from completing-read.
3212 (completing-read): Call completing-read-function.
3213
3214 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3215
3216 * xfaces.c (Fx_load_color_file):
3217 Read color file from absolute filename (bug#8250).
3218
3219 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3220
3221 * makefile.w32-in: Update dependencies.
3222
3223 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3224
3225 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3226
3227 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3228
3229 Fix more problems found by GCC 4.5.2's static checks.
3230
3231 * process.c (make_serial_process_unwind, send_process_trap):
3232 (sigchld_handler): Now static.
3233
3234 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3235 That way, the code declares only the vars that it needs.
3236 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3237 * s/cygwin.h (PTY_ITERATION): Likewise.
3238 * s/darwin.h (PTY_ITERATION): Likewise.
3239 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3240
3241 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3242 * process.c (allocate_pty): Don't declare stb unless it's needed.
3243
3244 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3245 (CONSTANTLIM): Remove; unused.
3246 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3247 Define only if needed.
3248
3249 * unexelf.c (unexec): Name an expression,
3250 to avoid gcc -Wbad-function-cast warning.
3251 Use a different way to cause a compilation error if anyone uses
3252 n rather than nn, a way that does not involve shadowing.
3253 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3254
3255 * deps.mk (unexalpha.o): Remove; unused.
3256
3257 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3258 * unexec.h: New file.
3259 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3260 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3261 Depend on unexec.h.
3262 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3263 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3264 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3265 Change as necessary to match prototype in unexec.h.
3266
3267 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3268 shadowing.
3269 (back_comment, skip_chars): Mark vars as initialized.
3270
3271 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3272 Rename locals to avoid shadowing.
3273
3274 * lread.c (read1): Rewrite so as not to use empty "else".
3275 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3276
3277 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3278
3279 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3280 warning when compiling print.c.
3281
3282 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3283 instead of using an uninitialized var.
3284 (font_sort_entities): Mark var as initialized.
3285
3286 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3287
3288 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3289 pointers to constants.
3290 (font_parse_fcname): Remove unused vars.
3291 (font_delete_unmatched): Now static.
3292 (font_get_spec): Remove; unused.
3293 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3294 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3295 Rename or move locals to avoid shadowing.
3296
3297 * fns.c (require_nesting_list, require_unwind): Now static.
3298 (Ffillarray): Rename locals to avoid shadowing.
3299
3300 * floatfns.c (domain_error2): Define only if needed.
3301 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3302
3303 * alloc.c (mark_backtrace): Move decl from here ...
3304 * lisp.h: ... to here, so that it can be checked.
3305
3306 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3307 (Fdefvar): Rewrite so as not to use empty "else".
3308 (lisp_indirect_variable): Name an expression,
3309 to avoid gcc -Wbad-function-cast warning.
3310 (Fdefvar): Rename locals to avoid shadowing.
3311
3312 * callint.c (quotify_arg, quotify_args): Now static.
3313 (Fcall_interactively): Rename locals to avoid shadowing.
3314 Use const pointer when appropriate.
3315
3316 * lisp.h (get_system_name, get_operating_system_release):
3317 Move decls here, to check interfaces.
3318 * process.c (get_operating_system_release): Move decl to lisp.h.
3319 * xrdb.c (get_system_name): Likewise.
3320 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3321 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3322 some of which prompt warnings from gcc -Wbad-function-cast.
3323 (Fformat_time_string, Fencode_time, Finsert_char):
3324 (Ftranslate_region_internal, Fformat):
3325 Rename or remove local vars to avoid shadowing.
3326 (Ftranslate_region_internal): Mark var as initialized.
3327
3328 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3329 avoid shadowing.
3330
3331 * lisp.h (eassert): Check that the argument compiles, even if
3332 ENABLE_CHECKING is not defined.
3333
3334 * data.c (Findirect_variable): Name an expression, to avoid
3335 gcc -Wbad-function-cast warning.
3336 (default_value, arithcompare, arith_driver, arith_error): Now static.
3337 (store_symval_forwarding): Rename local to avoid shadowing.
3338 (Fmake_variable_buffer_local, Fmake_local_variable):
3339 Mark variables as initialized.
3340 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3341
3342 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3343 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3344 Rename locals to avoid shadowing.
3345 (mark_stack): Move local variables into the #ifdef region where
3346 they're used.
3347 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3348 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3349 needed otherwise.
3350 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3351 (GC_STRING_CHARS): Remove; not used.
3352 (Fmemory_limit): Cast sbrk's returned value to char *.
3353
3354 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3355 avoids undefined behavior in theory.
3356
3357 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3358
3359 Use functions, not macros, for up- and down-casing (Bug#8254).
3360 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3361 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3362 to use the following functions instead of these macros.
3363 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3364 EMACS_INT, since callers assume the returned value fits in int.
3365 (upcase1): Likewise, for UPCASE_TABLE.
3366 (uppercasep, lowercasep, upcase): New static inline functions.
3367 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3368 the race-condition problem in the old DOWNCASE.
3369
3370 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3371 Rename locals to avoid shadowing.
3372 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3373 (regex_compile, re_search_2, re_match_2_internal):
3374 Remove unused local vars.
3375 (FREE_VAR): Rewrite so as not to use empty "else",
3376 which gcc can warn about.
3377 (regex_compile, re_match_2_internal): Mark locals as initialized.
3378 (RETALLOC_IF): Define only if needed.
3379 (WORDCHAR_P): Likewise. This one is never needed, but is used
3380 only in a comment talking about a compiler bug, so put inside
3381 the #if 0 of that comment.
3382 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3383 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3384 Remove; unused.
3385
3386 * search.c (boyer_moore): Rename locals to avoid shadowing.
3387 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3388 (PREV_CHAR_BOUNDARY): Likewise.
3389
3390 * search.c (simple_search): Remove unused var.
3391
3392 * dired.c (compile_pattern): Move decl from here ...
3393 * lisp.h: ... to here, so that it can be checked.
3394 (struct re_registers): New forward decl.
3395
3396 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3397
3398 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3399 All uses changed.
3400 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3401 Rename locals to avoid shadowing.
3402 (Fvertical_motion): Mark locals as initialized.
3403
3404 * casefiddle.c (casify_object, casify_region): Now static.
3405 (casify_region): Mark local as initialized.
3406
3407 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3408
3409 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3410 New macros, so that the caller can use some names other than
3411 gcpro1, gcpro2, etc.
3412 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3413 of the new macros.
3414 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3415 argument, for consistency with GCPRO2_VAR, etc: it is now the
3416 prefix of the variable, not the variable itself. All uses
3417 changed.
3418 * dired.c (directory_files_internal, file_name_completion):
3419 Rename locals to avoid shadowing.
3420
3421 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3422 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3423 dired.c's scmp function, had undefined behavior.
3424 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3425 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3426 * buffer.h: ... to here, because these macros use current_buffer,
3427 and the new implementation with inline functions needs to have
3428 current_buffer in scope now, rather than later when the macros
3429 are used.
3430 (downcase, upcase1): New static inline functions.
3431 (DOWNCASE, UPCASE1): Reimplement using these functions.
3432 This avoids undefined behavior in expressions like
3433 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3434 from race conditions in accessing the global variables
3435 case_temp1 and case_temp2.
3436 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3437 * lisp.h (case_temp1, case_temp2): Remove their decls.
3438 * character.h (ASCII_CHAR_P): Move from here ...
3439 * lisp.h: ... to here, so that the inline functions mentioned
3440 above can use them.
3441
3442 * dired.c (directory_files_internal_unwind): Now static.
3443
3444 * fileio.c (file_name_as_directory, directory_file_name):
3445 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3446 Now static.
3447 (file_name_as_directory): Use const pointers when appropriate.
3448 (Fexpand_file_name): Likewise. In particular, newdir might
3449 point at constant storage, so make it a const pointer.
3450 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3451 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3452 signedness issues.
3453 (Fset_file_times, Finsert_file_contents, auto_save_error):
3454 Rename locals to avoid shadowing.
3455
3456 * minibuf.c (choose_minibuf_frame_1): Now static.
3457 (Ftry_completion, Fall_completions): Rename or remove locals
3458 to avoid shadowing.
3459
3460 * marker.c (bytepos_to_charpos): Remove; unused.
3461
3462 * lisp.h (verify_bytepos, count_markers): New decls,
3463 so that gcc does not warn that these functions aren't declared.
3464
3465 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3466 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3467 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3468 (copy_text): Remove unused local var.
3469
3470 * filelock.c (within_one_second): Now static.
3471 (lock_file_1): Rename local to avoid shadowing.
3472
3473 * buffer.c (fix_overlays_before): Mark locals as initialized.
3474 (fix_start_end_in_overlays): Likewise. This function should be
3475 simplified by using pointers-to-pointers, but that's a different
3476 matter.
3477 (switch_to_buffer_1): Now static.
3478 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3479 (report_overlay_modification): Rename locals to avoid shadowing.
3480
3481 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3482 Fix pointer signedness issue.
3483 (sys_subshell): Mark local as volatile if checking for lint,
3484 to suppress a gcc -Wclobbered warning that does not seem to be right.
3485 (MAXPATHLEN): Define only if needed.
3486
3487 * process.c (serial_open, serial_configure): Move decls from here ...
3488 * systty.h: ... to here, so that they can be checked.
3489
3490 * fns.c (get_random, seed_random): Move extern decls from here ...
3491 * lisp.h: ... to here, so that they can be checked.
3492
3493 * sysdep.c (reset_io): Now static.
3494 (wait_for_termination_signal): Remove; unused.
3495
3496 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3497 (copy_keymap_item, append_key, push_text_char_description):
3498 Now static.
3499 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3500 (DENSE_TABLE_SIZE): Remove; unused.
3501 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3502 (describe_map_tree):
3503 Rename locals to avoid shadowing.
3504
3505 * keyboard.c: Declare functions static if they are not used elsewhere.
3506 (echo_char, echo_dash, cmd_error, top_level_2):
3507 (poll_for_input, handle_async_input): Now static.
3508 (read_char, kbd_buffer_get_event, make_lispy_position):
3509 (make_lispy_event, make_lispy_movement, apply_modifiers):
3510 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3511 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3512 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3513 (read_key_sequence, read_char): Mark locals as initialized.
3514 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3515
3516 * keyboard.h (make_ctrl_char): New decl.
3517 (mark_kboards): Move decl here ...
3518 * alloc.c (mark_kboards): ... from here.
3519
3520 * lisp.h (force_auto_save_soon): New decl.
3521
3522 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3523 (DEFINE_DUMMY_FUNCTION): New macro.
3524 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3525 Use it.
3526 (main): Add casts to avoid warnings
3527 if GCC considers string literals to be constants.
3528
3529 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3530
3531 * dbusbind.c: Pointer signedness fixes.
3532 (xd_signature, xd_append_arg, xd_initialize):
3533 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3534 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3535 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3536 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3537
3538 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3539 if GCC considers string literals to be constants.
3540 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3541
3542 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3543
3544 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3545 (print_preprocess, print_object): New macro to fix last change.
3546
3547 * print.c (print_preprocess): Don't forget font objects.
3548
3549 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3550
3551 * emacs.c (USAGE3): Doc fixes.
3552
3553 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3554
3555 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3556 structure.
3557
3558 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3559
3560 * lisp.h (VWindow_system, Qfile_name_history):
3561 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3562 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3563 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3564
3565 * w32select.c: Don't #include "keyboard.h".
3566 (run_protected): Add extern declaration for waiting_for_input.
3567
3568 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3569 * w32console.c (detect_input_pending, read_input_pending)
3570 (encode_terminal_code):
3571 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3572 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3573 (w32_system_caret_y, Qfile_name_history):
3574 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3575 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3576 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3577 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3578 * w32proc.c (Qlocal, report_file_error):
3579 * w32term.c (Vwindow_system, updating_frame):
3580 * w32uniscribe.c (initialized, uniscribe_font_driver):
3581 Remove unneeded extern declarations.
3582
3583 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3584
3585 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3586
3587 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3588
3589 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3590 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3591 These macros can no longer be used for assignment.
3592
3593 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3594 Assign struct members directly, instead of using BUF_BEGV etc.
3595 (record_buffer_markers, fetch_buffer_markers): New functions for
3596 recording and fetching special buffer markers.
3597 (set_buffer_internal_1, set_buffer_temp): Use them.
3598
3599 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3600
3601 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3602
3603 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3604 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3605
3606 * xdisp.c (hscroll_window_tree):
3607 (reconsider_clip_changes): Use PT instead of BUF_PT.
3608
3609 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3610
3611 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3612 $(EMACS_ROOT)/lib/intprops.h.
3613
3614 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3615
3616 Fix more problems found by GCC 4.5.2's static checks.
3617
3618 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3619 to unsigned char * to avoid compiler diagnostic.
3620 (xg_free_frame_widgets): Make it clear that a local variable is
3621 needed only if USE_GTK_TOOLTIP.
3622 (gdk_window_get_screen): Make it clear that this macro is needed
3623 only if USE_GTK_TOOLTIP.
3624 (int_gtk_range_get_value): New function, which avoids a diagnostic
3625 from gcc -Wbad-function-cast.
3626 (xg_set_toolkit_scroll_bar_thumb): Use it.
3627 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3628 diagnostic from gcc -Wbad-function-cast.
3629 (get_utf8_string, xg_get_file_with_chooser):
3630 Rename locals to avoid shadowing.
3631 (create_dialog): Move locals to avoid shadowing.
3632
3633 * xgselect.c (xg_select): Remove unused var.
3634
3635 * image.c (four_corners_best): Mark locals as initialized.
3636 (gif_load): Initialize transparent_p to zero (Bug#8238).
3637 Mark another local as initialized.
3638 (my_png_error, my_error_exit): Mark with NO_RETURN.
3639
3640 * image.c (clear_image_cache): Now static.
3641 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3642 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3643 (x_edge_detection): Remove unnecessary cast that
3644 gcc -Wbad-function-cast diagnoses.
3645 (gif_load): Fix pointer signedness.
3646 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3647 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3648
3649 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3650
3651 Improve quality of tests for time stamp overflow.
3652 For example, without this patch (encode-time 0 0 0 1 1
3653 1152921504606846976) returns the obviously-bogus value (-948597
3654 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3655 reports time overflow. See
3656 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3657 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3658 * editfns.c: Include limits.h and intprops.h.
3659 (TIME_T_MIN, TIME_T_MAX): New macros.
3660 (time_overflow): Move earlier, to before first use.
3661 (hi_time, lo_time): New functions, for an accurate test for
3662 out-of-range times.
3663 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3664 (Fget_internal_run_time): Don't assume time_t fits in int.
3665 (make_time): Use list2 instead of Fcons twice.
3666 (Fdecode_time): More accurate test for out-of-range times.
3667 (check_tm_member): New function.
3668 (Fencode_time): Use it, to test for out-of-range times.
3669 (lisp_time_argument): Don't rely on undefined left-shift and
3670 right-shift behavior when checking for time stamp overflow.
3671
3672 * editfns.c (time_overflow): New function, refactoring common code.
3673 (Fformat_time_string, Fdecode_time, Fencode_time):
3674 (Fcurrent_time_string): Use it.
3675
3676 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3677 * dired.c (make_time): Move to ...
3678 * editfns.c (make_time): ... here.
3679 * systime.h: Note the move.
3680
3681 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3682
3683 * fringe.c (update_window_fringes): Remove unused variables.
3684
3685 * unexmacosx.c (copy_data_segment): Also copy __got section.
3686 (Bug#8223)
3687
3688 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3689
3690 * termcap.c [MSDOS]: Include "msdos.h".
3691 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3692 Constify `char *' arguments and their references according to
3693 prototypes in tparam.h.
3694
3695 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3696
3697 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3698 Adapt all references accordingly.
3699
3700 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3701
3702 2011-03-11 Tom Tromey <tromey@redhat.com>
3703
3704 * buffer.c (syms_of_buffer): Remove obsolete comment.
3705
3706 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3707
3708 * termhooks.h (encode_terminal_code): Declare prototype.
3709
3710 * msdos.c (encode_terminal_code): Don't declare prototype.
3711
3712 * term.c (encode_terminal_code): Now external again, used by
3713 w32console.c and msdos.c.
3714
3715 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3716 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3717
3718 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3719
3720 Fix some minor problems found by GCC 4.5.2's static checks.
3721
3722 * fringe.c (update_window_fringes): Mark locals as initialized
3723 (Bug#8227).
3724 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3725
3726 * alloc.c (mark_fringe_data): Move decl from here ...
3727 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3728 to check its interface.
3729 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3730
3731 * fontset.c (free_realized_fontset): Now static.
3732 (Fset_fontset_font): Rename local to avoid shadowing.
3733 (fontset_font): Mark local as initialized.
3734 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3735
3736 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3737
3738 * xselect.c (x_disown_buffer_selections): Remove; not used.
3739 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3740 (x_own_selection, Fx_disown_selection_internal): Rename locals
3741 to avoid shadowing.
3742 (x_handle_dnd_message): Remove local to avoid shadowing.
3743
3744 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3745 so that the caller can use some name other than gcpro1.
3746 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3747 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3748 (Fx_backspace_delete_keys_p):
3749 Use them to avoid shadowing, and rename vars to avoid shadowing.
3750 (x_decode_color, x_set_name, x_window): Now static.
3751 (Fx_create_frame): Add braces to silence GCC warning.
3752 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3753 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3754 Remove unused locals.
3755 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3756 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3757 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3758 macros.
3759
3760 * xterm.h (x_mouse_leave): New decl.
3761
3762 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3763 Remove unused functions.
3764 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3765 (x_calc_absolute_position): Now static.
3766 (XTread_socket): Don't define label "out" unless it's used.
3767 Don't declare local "event" unless it's used.
3768 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3769 unless they are used.
3770 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3771 (x_fatal_error_signal): Remove; not used.
3772 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3773 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3774 (x_error_catcher, x_connection_closed, x_error_handler):
3775 (x_error_quitter, xembed_send_message, x_iconify_frame):
3776 (my_log_handler): Rename locals to avoid shadowing.
3777 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3778 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3779
3780 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3781 Rename or move locals to avoid shadowing.
3782 (tty_defined_color, merge_face_heights): Now static.
3783 (free_realized_faces_for_fontset): Remove; not used.
3784 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3785 does not deduce is never used uninitialized.
3786 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3787 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3788
3789 * terminal.c (store_terminal_param): Now static.
3790
3791 * xmenu.c (menu_highlight_callback): Now static.
3792 (set_frame_menubar): Remove unused local.
3793 (xmenu_show): Rename parameter to avoid shadowing.
3794 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3795 since they might point to immutable storage.
3796 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3797 since it's unused otherwise.
3798
3799 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3800 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3801 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3802 avoids a gcc -Wuninitialized diagnostic.
3803 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3804 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3805 does not deduce are never used uninitialized.
3806
3807 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3808
3809 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3810 * window.c (window_loop, size_window):
3811 (run_window_configuration_change_hook, enlarge_window): Likewise.
3812
3813 * window.c (display_buffer): Now static.
3814 (size_window): Mark variables that gcc -Wuninitialized
3815 does not deduce are never used uninitialized.
3816 * window.h (check_all_windows): New decl, to forestall
3817 gcc -Wmissing-prototypes diagnostic.
3818 * dispextern.h (bidi_dump_cached_states): Likewise.
3819
3820 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3821 shadowing.
3822 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3823 Include <limits.h>.
3824 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3825 and to avoid gcc -Wuninitialized warning.
3826 (load_charset_map): Mark variables that gcc -Wuninitialized
3827 does not deduce are never used uninitialized.
3828 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3829
3830 * coding.c (coding_set_source, coding_set_destination):
3831 Use "else { /* comment */ }" rather than "else /* comment */;"
3832 for clarity, and to avoid gcc -Wempty-body warning.
3833 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3834 a block, when the outer 'i' will do.
3835 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3836 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3837 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3838 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3839 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3840 Rename locals to avoid shadowing.
3841 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3842 * coding.c (emacs_mule_char, encode_invocation_designation):
3843 Now static, since they're not used elsewhere.
3844 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3845 (decode_coding_object, encode_coding_object, detect_coding_system):
3846 (decode_coding_emacs_mule): Mark variables that gcc
3847 -Wuninitialized does not deduce are never used uninitialized.
3848 (detect_coding_iso_2022): Initialize a local variable that might
3849 be used uninitialized. Leave a FIXME because it's not clear that
3850 this initialization is needed. (Bug#8211)
3851 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3852 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3853 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3854 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3855 Remove unused macros.
3856
3857 * category.c (hash_get_category_set): Remove unused local var.
3858 (copy_category_table): Now static, since it's not used elsewhere.
3859 * character.c (string_count_byte8): Likewise.
3860
3861 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3862 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3863
3864 * chartab.c (copy_sub_char_table): Now static, since it's not used
3865 elsewhere.
3866 (sub_char_table_ref_and_range, char_table_ref_and_range):
3867 Rename locals to avoid shadowing.
3868 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3869
3870 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3871 (BIDI_BOB): Remove unused macro.
3872
3873 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3874 deduce are never used uninitialized.
3875 * term.c (encode_terminal_code): Likewise.
3876
3877 * term.c (encode_terminal_code): Now static. Remove unused local.
3878
3879 * tparam.h: New file.
3880 * term.c, tparam.h: Include it.
3881 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3882 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3883 Move these decls to tparam.h, and make them agree with what
3884 is actually in tparam.c. The previous trick of using incompatible
3885 decls in different modules does not conform to the C standard.
3886 All callers of tparam changed to use tparam's actual API.
3887 * tparam.c (tparam1, tparam, tgoto):
3888 Use const pointers where appropriate.
3889
3890 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3891 * cm.h (struct cm): Likewise.
3892 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3893 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3894 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3895 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3896 (turn_on_face, init_tty): Likewise.
3897 * termchar.h (struct tty_display_info): Likewise.
3898
3899 * term.c (term_mouse_position): Rename local to avoid shadowing.
3900
3901 * alloc.c (mark_ttys): Move decl from here ...
3902 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3903
3904 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3905
3906 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3907
3908 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3909
3910 * search.c (compile_pattern_1): Remove argument regp, unused since
3911 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3912 (compile_pattern): Don't pass it.
3913
3914 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3915
3916 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3917 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3918 for ! HAVE_GTK3.
3919 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3920
3921 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3922
3923 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3924 gdk_window_get_screen, gdk_window_get_geometry,
3925 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3926 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3927 (xg_get_pixbuf_from_pixmap): New function.
3928 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3929 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3930 Call xg_get_pixbuf_from_pixmap instead of
3931 gdk_pixbuf_get_from_drawable.
3932 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3933 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3934 (xg_check_special_colors): Use GtkStyleContext and its functions
3935 for HAVE_GTK3.
3936 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3937 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3938 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3939 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3940 Call gtk_widget_get_preferred_size.
3941 (xg_frame_resized): gdk_window_get_geometry only takes 5
3942 parameters.
3943 (xg_win_to_widget, xg_event_is_for_menubar):
3944 Call gdk_x11_window_lookup_for_display.
3945 (xg_set_widget_bg): New function.
3946 (delete_cb): New function.
3947 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3948 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3949 (xg_set_background_color): Call xg_set_widget_bg.
3950 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3951 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3952 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3953 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3954 if ! HAVE_GTK3.
3955 (update_frame_tool_bar): Call gtk_widget_hide.
3956 (xg_initialize): Use GDK_KEY_g.
3957
3958 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3959 if ! HAVE_GTK3
3960 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3961
3962 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3963 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3964 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3965
3966 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3967
3968 * w32xfns.c (select_palette): Check success of RealizePalette against
3969 GDI_ERROR, not zero.
3970
3971 See ChangeLog.11 for earlier changes.
3972
3973 ;; Local Variables:
3974 ;; coding: utf-8
3975 ;; End:
3976
3977 Copyright (C) 2011 Free Software Foundation, Inc.
3978
3979 This file is part of GNU Emacs.
3980
3981 GNU Emacs is free software: you can redistribute it and/or modify
3982 it under the terms of the GNU General Public License as published by
3983 the Free Software Foundation, either version 3 of the License, or
3984 (at your option) any later version.
3985
3986 GNU Emacs is distributed in the hope that it will be useful,
3987 but WITHOUT ANY WARRANTY; without even the implied warranty of
3988 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3989 GNU General Public License for more details.
3990
3991 You should have received a copy of the GNU General Public License
3992 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.