Protect the bidi iterator against zero bidi properties.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2
3 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4 character bidirectional type, use STRONG_L instead. Fixes crashes
5 in a buffer produced by `describe-categories'.
6
7 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8 members before the level stack, so they would be saved and
9 restored when copying iterator state. Fixes incorrect reordering
10 around TABs covered by display properties.
11
12 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
13
14 * process.c (Fnetwork_interface_list): Correctly determine buffer
15 size.
16
17 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
18
19 * eval.c (internal_condition_case, internal_condition_case_1)
20 (internal_condition_case_2, internal_condition_case_n): Remove
21 unnecessary aborts (Bug#9081).
22
23 2011-08-17 Eli Zaretskii <eliz@gnu.org>
24
25 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
26 has no `load' handler, try opening the file locally. (Bug#9311)
27
28 2011-08-16 Ken Brown <kbrown@cornell.edu>
29
30 * gmalloc.c: Expand comment.
31
32 2011-08-16 Eli Zaretskii <eliz@gnu.org>
33
34 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
35 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
36
37 2011-08-16 Ken Brown <kbrown@cornell.edu>
38
39 Fix memory allocation problems in Cygwin build (Bug#9273).
40
41 * unexcw.c ( __malloc_initialized): Declare external variable.
42 (fixup_executable): Force the dumped emacs to reinitialize malloc.
43
44 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
45 variables.
46 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
47 dumped emacs.
48 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
49 in the static heap.
50 [CYGWIN] (special_realloc): New function.
51 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
52 requests to realloc storage in the static heap.
53
54 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
55
56 * bidi.c (bidi_initialize): Remove unused local.
57
58 2011-08-15 Eli Zaretskii <eliz@gnu.org>
59
60 * biditype.h: File removed.
61
62 * bidimirror.h: File removed.
63
64 * deps.mk (bidi.o): Remove biditype.h and
65 bidimirror.h.
66
67 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
68 bidimirror.h.
69
70 * dispextern.h: Fix a typo in the comment to bidi_type_t.
71
72 * chartab.c: Improve commentary for the uniprop_table API.
73
74 * bidi.c (bidi_paragraph_init): Support zero value of
75 bidi_ignore_explicit_marks_for_paragraph_level.
76 (bidi_initialize): Use uniprop_table instead of including
77 biditype.h and bidimirror.h.
78
79 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
80 coordinates of the iterator when restoring from ppos_it.
81 (Bug#9296)
82
83 2011-08-14 Kenichi Handa <handa@m17n.org>
84
85 * process.c (create_process): Call setup_process_coding_systems
86 after the pid of the process is set to -1 (Bug#8162).
87
88 2011-08-14 Eli Zaretskii <eliz@gnu.org>
89
90 * xdisp.c (move_it_in_display_line_to): Don't invoke
91 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
92 ppos_it. Fixes vertical cursor motion when line beginning is
93 covered by an image. (Bug#9296)
94
95 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
96
97 * nsterm.h (ns_run_ascript): Declare.
98 (NSAPP_DATA2_RUNASSCRIPT): Define.
99
100 * nsfns.m (as_script, as_result, as_status): New static variables.
101 (ns_run_ascript): New function.
102 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
103 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
104 the event loop. Get status from as_status (Bug#7276).
105
106 * nsterm.m (sendEvent): If event is NSApplicationDefined and
107 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
108 the event loop (Bug#7276).
109
110 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
111
112 * gnutls.c (QCgnutls_bootprop_priority)
113 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
114 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
115 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
116 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
117 (QCgnutls_bootprop_verify_hostname_error)
118 (QCgnutls_bootprop_callbacks_verify): Rename from
119 Qgnutls_bootprop_..., all uses changed.
120
121 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
122 uses changed.
123
124 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
125
126 * xfaces.c (Qframe_set_background_mode): Now static.
127 * dispextern.h (Qframe_set_background_mode): Remove decl.
128
129 * process.c (Fnetwork_interface_info): Declare local only if needed.
130
131 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
132
133 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
134 (Fnetwork_interface_list): Allocate in increments of bytes instead
135 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
136 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
137 sockaddr.
138 (struct ifflag_def): notrailers is smart on OSX.
139 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
140 Get hardware address with getifaddrs if available.
141
142 2011-08-12 Eli Zaretskii <eliz@gnu.org>
143
144 * xdisp.c (iterate_out_of_display_property): xassert that
145 IT->position is set to within IT->object's boundaries. Break from
146 the loop as soon as EOB is reached; avoids infloops in redisplay
147 when IT->position is set up wrongly due to some bug. Set
148 IT->current to match the bidi iterator unconditionally.
149 (push_display_prop): Allow GET_FROM_STRING as IT->method on
150 entry. Force push_it to save on the stack the current
151 buffer/string position, to be restored by pop_it. Fix flags in
152 the iterator structure wrt the object coming from a display
153 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
154 properties. (Bug#9284)
155
156 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
157
158 * fontset.c (fontset_get_font_group): Add proper type checks.
159 (Bug#9172)
160
161 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
162
163 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
164 and LC_VERSION_MIN_MACOSX.
165 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
166 (dump_it) [LC_FUNCTION_STARTS]: Use it.
167
168 2011-08-08 Eli Zaretskii <eliz@gnu.org>
169
170 * xdisp.c (forward_to_next_line_start): Allow to use the
171 no-display-properties-and-no-overlays under bidi display. Set
172 disp_pos in the bidi iterator to avoid searches for display
173 properties and overlays.
174
175 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
176
177 * editfns.c (Fset_time_zone_rule): Document relationship with the
178 setenv function.
179
180 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
181 the font entity extracted from the cache (Bug#8109).
182
183 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
184
185 * composite.c (autocmp_chars): Don't reset point. That is done by
186 restore_point_unwind (Bug#5984).
187
188 2011-08-07 Juri Linkov <juri@jurta.org>
189
190 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
191 to show the arg `TIME' instead of `TIMEVAL'.
192
193 2011-08-06 Eli Zaretskii <eliz@gnu.org>
194
195 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
196 display property strides EOL and includes a newline, as in
197 longlines-mode. (Bug#9254)
198 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
199 word-wrap under bidirectional display. (Bug#9224)
200
201 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
202 is non-zero, even if the data buffer is NULL. Fixes a crash in
203 vertical-motion with longlines-mode. (Bug#9254)
204
205 2011-08-05 Eli Zaretskii <eliz@gnu.org>
206
207 * bidi.c <bidi_cache_total_alloc>: Now static.
208 (bidi_initialize): Initialize bidi_cache_total_alloc.
209
210 *xdisp.c (display_line): Release buffer allocated for shelved bidi
211 cache. (Bug#9221)
212
213 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
214 amount allocated this far in `bidi_cache_total_alloc'.
215 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
216 non-zero, only free the data buffer without restoring the cache
217 contents. All callers changed.
218
219 * dispextern.h (bidi_unshelve_cache): Update prototype.
220
221 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
222 (move_it_in_display_line, move_it_to)
223 (move_it_vertically_backward, move_it_by_lines): Replace the call
224 to xfree to an equivalent call to bidi_unshelve_cache.
225 (move_it_in_display_line_to): Fix logic of returning
226 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
227
228 2011-08-05 Eli Zaretskii <eliz@gnu.org>
229
230 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
231 came from a string character with a `cursor' property. (Bug#9229)
232
233 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
234
235 * Makefile.in (LIB_PTHREAD): New variable.
236 (LIBES): Add LIB_PTHREAD (Bug#9216).
237
238 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
239 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
240
241 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
242
243 * regex.c (re_iswctype): Remove some redundant boolean
244 conversions.
245
246 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
247
248 * xterm.c (x_find_topmost_parent): New function.
249 (x_set_frame_alpha): Find topmost parent window with
250 x_find_topmost_parent and set the property there also (bug#9181).
251 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
252
253 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
254
255 * callproc.c (Fcall_process): Avoid vfork clobbering
256 the local vars buffer, coding_systems, current_dir.
257
258 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
259
260 * keymap.c (Fmake_composed_keymap): Move to subr.el.
261
262 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
263
264 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
265 so that it is not optimized away.
266
267 * xdisp.c (compute_display_string_pos): Remove unused local.
268
269 2011-08-02 Eli Zaretskii <eliz@gnu.org>
270
271 Fix slow cursor motion and scrolling in large buffers with
272 selective display, like Org Mode buffers. (Bug#9218)
273
274 * dispextern.h (struct bidi_it): New member disp_prop_p.
275
276 * xdisp.c: Remove one-slot cache of display string positions.
277 (compute_display_string_pos): Accept an additional argument
278 DISP_PROP_P; callers changed. Scan at most 5K characters forward
279 for a display string or property. If found, set DISP_PROP_P
280 non-zero.
281
282 * bidi.c (bidi_fetch_char): Accept an additional argument
283 DISP_PROP_P, and pass it to compute_display_string_pos.
284 Only handle text covered by a display string if DISP_PROP_P is returned
285 non-zero. All callers of bidi_fetch_char changed.
286
287 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
288
289 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
290
291 2010-12-03 Don March <don@ohspite.net>
292
293 * keymap.c (Fdefine_key): Fix non-prefix key error message when
294 last character M-[char] is translated to ESC [char] (bug#7541).
295
296 2011-08-02 Kenichi Handa <handa@m17n.org>
297
298 * lisp.h (uniprop_table): Extern it.
299
300 * chartab.c (uniprop_table): Make it non-static.
301
302 2011-08-01 Eli Zaretskii <eliz@gnu.org>
303
304 * xdisp.c (forward_to_next_line_start): Accept additional argument
305 BIDI_IT_PREV, and store into it the state of the bidi iterator had
306 on the newline.
307 (reseat_at_next_visible_line_start): Use the bidi iterator state
308 returned by forward_to_next_line_start to restore the state of
309 it->bidi_it after backing up to previous newline. (Bug#9212)
310
311 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
312
313 * regex.c (re_comp): Protoize.
314 (re_exec): Fix return type.
315 (regexec): Fix type of `ret'. (Bug#9203)
316
317 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
318
319 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
320 This is needed if max-image-size is a floating-point number.
321
322 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
323
324 * print.c (print_object): Print empty symbol as ##.
325
326 * lread.c (read1): Read ## as empty symbol.
327
328 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
329
330 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
331 setting frame foreground color (Bug#9175).
332 (x_set_background_color): Likewise.
333
334 * nsmenu.m (-setText): Size tooltip dimensions precisely to
335 contents (Bug#9176).
336 (EmacsTooltip -init): Remove bezels and add shadows to
337 tooltip windows.
338
339 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
340 or scroll bar (Bug#8470).
341
342 * nsfont.m (nsfont_open): Remove assignment to voffset and
343 unnecessary vars hshink, expand, hd, full_height, min_height.
344 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
345
346 * nsterm.h (nsfont_info): Remove voffset field.
347
348 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
349
350 Implement strike-through and overline on NextStep (Bug#8863).
351
352 * nsfont.m (nsfont_open): Use underline position provided by font,
353 instead of hard-coded value of 2.
354 (nsfont_draw): Call ns_draw_text_decoration instead.
355
356 * nsterm.h: Add declaration for ns_draw_text_decoration.
357
358 * nsterm.m (ns_draw_text_decoration): New function for drawing
359 underline, overline, and strike-through.
360 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
361 ns_draw_text_decoration. Change treatment of cursor drawing to
362 accomodate underlining, etc.
363
364 2011-07-28 Eli Zaretskii <eliz@gnu.org>
365
366 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
367 default.
368
369 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
370
371 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
372 Without this fix, if a signal arrives just after memory fills up,
373 'malloc' might be invoked reentrantly.
374
375 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
376 In other words, assume that every image size is allowed, on non-X
377 hosts. This assumption is probably wrong, but it lets Emacs compile.
378
379 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
380
381 * regex.c (re_iswctype): Convert return values to boolean.
382
383 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
384
385 * xdisp.c (compute_display_string_pos): Don't use cached display
386 string position if the buffer had its restriction changed.
387 (Bug#9184)
388
389 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
390
391 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
392
393 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
394
395 Integer signedness and overflow and related fixes. (Bug#9079)
396
397 * bidi.c: Integer size and overflow fixes.
398 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
399 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
400 (bidi_cache_find_level_change, bidi_cache_ensure_space)
401 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
402 (bidi_find_other_level_edge):
403 Use ptrdiff_t instead of EMACS_INT where either will do.
404 This works better on 32-bit hosts configured --with-wide-int.
405 (bidi_cache_ensure_space): Check for size-calculation overflow.
406 Use % rather than repeated addition, for better worst-case speed.
407 Don't set bidi_cache_size until after xrealloc returns, because it
408 might not return.
409 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
410 (bidi_cache_ensure_space): Also check that the bidi cache size
411 does not exceed that of the largest Lisp string or buffer. See Eli
412 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
413
414 * alloc.c (__malloc_size_t): Remove.
415 All uses replaced by size_t. See Andreas Schwab's note
416 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
417
418 * image.c: Improve checking for integer overflow.
419 (check_image_size): Assume that f is nonnull, since
420 it is always nonnull in practice. This is one less thing to
421 worry about when checking for integer overflow later.
422 (x_check_image_size): New function, which checks for integer
423 overflow issues inside X.
424 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
425 This removes the need for a memory_full check.
426 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
427 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
428 (xbm_read_bitmap_data): Change locals back to 'int', since
429 their values must fit in 'int'.
430 (xpm_load_image, png_load, tiff_load):
431 Invoke x_create_x_image_and_pixmap earlier,
432 to avoid much needless work if the image is too large.
433 (tiff_load): Treat overly large images as if
434 x_create_x_image_and_pixmap failed, not as malloc failures.
435 (gs_load): Use x_check_image_size.
436
437 * gtkutil.c: Omit integer casts.
438 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
439 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
440
441 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
442
443 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
444 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
445 would wrongly return t on a 64-bit host.
446
447 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
448 The plain *_OVERFLOW macros run afoul of GCC bug 49705
449 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
450 and therefore cause GCC to emit a bogus diagnostic in some cases.
451
452 * image.c: Integer signedness and overflow and related fixes.
453 This is not an exhaustive set of fixes, but it's time to
454 record what I've got.
455 (lookup_pixel_color, check_image_size): Remove redundant decls.
456 (check_image_size): Don't assume that arbitrary EMACS_INT values
457 fit in 'int', or that arbitrary 'double' values fit in 'int'.
458 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
459 (tiff_load, imagemagick_load_image):
460 Check for overflow in size calculations.
461 (x_create_x_image_and_pixmap): Remove unnecessary test for
462 xmalloc returning NULL; that can't happen.
463 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
464 (xpm_color_bucket): Use better integer hashing function.
465 (xpm_cache_color): Don't possibly over-allocate memory.
466 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
467 (gif_memory_source):
468 Use ptrdiff_t, not int or size_t, to record sizes.
469 (png_load): Don't assume values greater than 2**31 fit in 'int'.
470 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
471 either works, as we prefer signed integers.
472 (tiff_read_from_memory, tiff_write_from_memory):
473 Return tsize_t, not size_t, since that's what the TIFF API wants.
474 (tiff_read_from_memory): Don't fail simply because the read would
475 go past EOF; instead, return a short read.
476 (tiff_load): Omit no-longer-needed casts.
477 (Fimagemagick_types): Don't assume size fits into 'int'.
478
479 Improve hashing quality when configured --with-wide-int.
480 * fns.c (hash_string): New function, taken from sxhash_string.
481 Do not discard information about ASCII character case; this
482 discarding is no longer needed.
483 (sxhash-string): Use it. Change sig to match it. Caller changed.
484 * lisp.h: Declare it.
485 * lread.c (hash_string): Remove, since we now use fns.c's version.
486 The fns.c version returns a wider integer if --with-wide-int is
487 specified, so this should help the quality of the hashing a bit.
488
489 * emacs.c: Integer overflow minor fix.
490 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
491 Define only if GNU_LINUX.
492 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
493
494 * dispnew.c: Integer signedness and overflow fixes.
495 Remove unnecessary forward decls, that were a maintenance hassle.
496 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
497 All uses changed.
498 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
499 (scrolling_window): Use ptrdiff_t, not int, for byte count.
500 (prepare_desired_row, line_draw_cost):
501 Use int, not unsigned, where either works.
502 (save_current_matrix, restore_current_matrix):
503 Use ptrdiff_t, not size_t, where either works.
504 (init_display): Check for overflow more accurately, and without
505 relying on undefined behavior.
506
507 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
508 Remove, replacing with the new symbols in lisp.h. All uses changed.
509 * fileio.c (make_temp_name):
510 * filelock.c (lock_file_1, lock_file):
511 * xdisp.c (message_dolog):
512 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
513 Use pMd etc. instead.
514 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
515 replacing the pWIDE etc. symbols removed from editfns.c.
516
517 * keyboard.h (num_input_events): Now uintmax_t.
518 This is (very slightly) less likely to mess up due to wraparound.
519 All uses changed.
520
521 * buffer.c: Integer signedness fixes.
522 (alloc_buffer_text, enlarge_buffer_text):
523 Use ptrdiff_t rather than size_t when either will do, as we prefer
524 signed integers.
525
526 * alloc.c: Integer signedness and overflow fixes.
527 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
528 (__malloc_size_t): Default to size_t, not to int.
529 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
530 (Fgarbage_collect, mark_object_loop_halt, mark_object):
531 Prefer ptrdiff_t to size_t when either would do, as we prefer
532 signed integers.
533 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
534 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
535 Now const. Initialize with values that are in range even if char
536 is signed.
537 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
538 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
539 These functions do the right thing with sizes > 2**32.
540 (check_depth): Now ptrdiff_t, not int.
541 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
542 Adjust to new way of storing sizes. Check for size overflow bugs
543 in rest of code.
544 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
545 slightly wrong anyway, as it missed one instance of
546 XMALLOC_OVERRUN_CHECK_OVERHEAD.
547 (refill_memory_reserve): Omit needless cast to size_t.
548 (mark_object_loop_halt): Mark as externally visible.
549
550 * xselect.c: Integer signedness and overflow fixes.
551 (Fx_register_dnd_atom, x_handle_dnd_message):
552 Use ptrdiff_t, not size_t, since we prefer signed.
553 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
554 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
555 x_dnd_atoms_size and x_dnd_atoms_length.
556
557 * doprnt.c: Prefer signed to unsigned when either works.
558 * eval.c (verror):
559 * doprnt.c (doprnt):
560 * lisp.h (doprnt):
561 * xdisp.c (vmessage):
562 Use ptrdiff_t, not size_t, when using or implementing doprnt,
563 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
564 prefer signed arithmetic to avoid comparison confusion.
565 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
566 but is a bit tricky.
567
568 Assume freestanding C89 headers, string.h, stdlib.h.
569 * data.c, doprnt.c, floatfns.c, print.c:
570 Include float.h unconditionally.
571 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
572 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
573 * regex.c: Likewise for stddef.h, string.h.
574 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
575 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
576 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
577 (STDC_HEADERS): Remove obsolete defines.
578 * sysdep.c: Include limits.h unconditionally.
579
580 Assume support for memcmp, memcpy, memmove, memset.
581 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
582 * regex.c (memcmp, memcpy):
583 Remove; we assume C89 now.
584
585 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
586 (__malloc_safe_bcopy): Remove; no longer needed.
587
588 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
589 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
590 well either way, and we prefer signed to unsigned.
591
592 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
593
594 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
595 closes the connection while we're reading (bug#9182).
596
597 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
598
599 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
600 are specified (Bug#9168).
601
602 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
603
604 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
605 Found by GCC static checking and --with-wide-int on a 32-bit host.
606
607 2011-07-25 Eli Zaretskii <eliz@gnu.org>
608
609 * xdisp.c (compute_display_string_pos): Fix logic of caching
610 previous display string position. Initialize cached_prev_pos to
611 -1. Fixes slow-down at the beginning of a buffer.
612
613 2011-07-24 Eli Zaretskii <eliz@gnu.org>
614
615 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
616 for attrs[LFACE_FONTSET_INDEX].
617
618 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
619
620 * xml.c (parse_region): Remove unused local
621 that was recently introduced.
622
623 2011-07-23 Eli Zaretskii <eliz@gnu.org>
624
625 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
626 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
627
628 * xdisp.c (move_it_in_display_line_to): Record the best matching
629 position for TO_CHARPOS while scanning the line, and restore it on
630 exit if none of the characters scanned was an exact match.
631 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
632 when exact match is impossible due to invisible text, and the
633 lines are truncated.
634
635 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
636
637 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
638 for OSX >= 10.7.
639
640 2011-07-22 Eli Zaretskii <eliz@gnu.org>
641
642 Fix a significant slow-down of cursor motion with C-n, C-p,
643 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
644 auto-repeat under bidi redisplay in fontified buffers.
645 * xdisp.c (compute_stop_pos_backwards): New function.
646 (next_element_from_buffer): Call compute_stop_pos_backwards to
647 find a suitable prev_stop when we find ourselves before
648 base_level_stop.
649 (reseat): Don't look for prev_stop, as that could mean a very long
650 run.
651 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
652 <cached_disp_overlay_modiff>: Cache for last found display string
653 position.
654 (compute_display_string_pos): Return the cached position if asked
655 about the same buffer in the same area of character positions, and
656 the buffer wasn't changed since the time the display string
657 position was cached.
658
659 2011-07-22 Eli Zaretskii <eliz@gnu.org>
660
661 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
662 is an integer, which is important for empty lines. (Bug#9149)
663
664 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
665
666 * frame.c (Fmodify_frame_parameters): In tty case, update the
667 default face if necessary (Bug#4238).
668
669 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
670
671 * editfns.c (Fstring_to_char): No need to explain what a character
672 is in the docstring (Bug#6576).
673
674 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
675
676 * xml.c (parse_region): Make sure we always return a tree.
677
678 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
679
680 * xml.c (parse_region): If a document contains only comments,
681 return that, too.
682
683 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
684
685 * xml.c (make_dom): Return comments, too.
686
687 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
688
689 Port to OpenBSD.
690 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
691 and the surrounding thread.
692 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
693 rather than fgets, and retry after EINTR. Otherwise, 'emacs
694 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
695 timer goes off.
696 * s/openbsd.h (BROKEN_SIGIO): Define.
697 * unexelf.c (unexec) [__OpenBSD__]:
698 Don't update the .mdebug section of the Alpha COFF symbol table.
699
700 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
701
702 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
703 (bug#8460).
704
705 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
706
707 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
708 This fixes some race conditions on the permissions of any newly
709 created file.
710
711 * alloc.c (valid_pointer_p): Use pipe, not open.
712 This fixes some permissions issues when debugging.
713
714 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
715 If fchown fails to set both uid and gid, try to set just gid,
716 as that is sometimes allowed. Adjust the file's mode to eliminate
717 setuid or setgid bits that are inappropriate if fchown fails.
718
719 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
720
721 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
722 to compare Lisp_Objects.
723 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
724 global_gnutls_log_level, don't mistake it for a Lisp_Object.
725 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
726
727 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
728
729 * lread.c (read_integer): Unread even EOF character.
730 (read1): Likewise. Properly record start position of symbol.
731
732 * lread.c (read1): Read `#:' as empty uninterned symbol if no
733 symbol character follows.
734
735 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
736
737 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
738 This works around a problem with the previous change to Fcopy_file.
739 Recent glibc declares fchown with __attribute__((warn_unused_result)),
740 and without this change, GCC might complain about discarding
741 fchown's return value.
742
743 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
744
745 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
746
747 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
748
749 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
750
751 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
752
753 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
754 it's used from the C level.
755
756 * process.c: Use the same condition for POLL_FOR_INPUT in both
757 keyboard.c and process.c (bug#1858).
758
759 2011-07-09 Lawrence Mitchell <wence@gmx.li>
760
761 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
762 (Fgnutls_boot): Use it.
763
764 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
765
766 * doc.c (Fsubstitute_command_keys): Revert last change.
767
768 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
769
770 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
771 quotes the next character, and doesn't affect other longer
772 sequences (bug#8935).
773
774 * lread.c (syms_of_lread): Clarify that is isn't only
775 `eval-buffer' and `eval-defun' that's affected by
776 `lexical-binding' (bug#8460).
777
778 2011-07-15 Eli Zaretskii <eliz@gnu.org>
779
780 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
781 bidi redisplay when a line includes both an image and is
782 truncated.
783
784 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
785
786 Fix minor problems found by static checking.
787 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
788 (elsz): Now a signed constant, not a size_t var. We prefer signed
789 types to unsigned, to avoid integer comparison confusion. Without
790 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
791 "cannot optimize loop, the loop counter may overflow", a symptom
792 of the confusion.
793 * indent.c (Fvertical_motion): Mark locals as initialized.
794 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
795
796 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
797
798 * search.c (Fre_search_backward): Mention `case-fold-search' in
799 all the re_search_* functions (bug#8138).
800
801 * keyboard.c (Fopen_dribble_file): Document when the file is
802 closed (bug#8056).
803
804 2011-07-14 Eli Zaretskii <eliz@gnu.org>
805
806 * bidi.c (bidi_dump_cached_states): Fix format of displaying
807 bidi_cache_idx.
808
809 Support bidi reordering of display and overlay strings.
810 * xdisp.c (compute_display_string_pos)
811 (compute_display_string_end): Accept additional argument STRING.
812 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
813 (reseat_to_string): Initialize bidi_it->string.s and
814 bidi_it->string.schars.
815 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
816 NULL (avoids a crash in bidi_paragraph_init).
817 Initialize itb.string.lstring.
818 (init_iterator): Call bidi_init_it only of a valid
819 buffer position was specified. Initialize paragraph_embedding to
820 L2R.
821 (reseat_to_string): Initialize the bidi iterator.
822 (display_string): If we need to ignore text properties of
823 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
824 original value of -1 will not work with bidi.)
825 (compute_display_string_pos): First arg is now struct
826 `text_pos *'; all callers changed. Support display properties on
827 Lisp strings.
828 (compute_display_string_end): Support display properties on Lisp
829 strings.
830 (init_iterator, reseat_1, reseat_to_string): Initialize the
831 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
832 when iterating on a string not from display properties).
833 (compute_display_string_pos, compute_display_string_end):
834 Fix calculation of the object to scan. Fixes an error when using
835 arrow keys.
836 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
837 base_level_stop; instead, set base_level_stop to BEGV.
838 Fixes crashes in vertical-motion.
839 (next_element_from_buffer): Improve commentary for when
840 the iterator is before prev_stop.
841 (init_iterator): Initialize bidi_p from the default value of
842 bidi-display-reordering, not from buffer-local value. Use the
843 buffer-local value only if initializing for buffer iteration.
844 (handle_invisible_prop): Support invisible properties on strings
845 that are being bidi-reordered.
846 (set_iterator_to_next): Support bidi reordering of C strings and
847 Lisp strings.
848 (next_element_from_string): Support bidi reordering of Lisp
849 strings.
850 (handle_stop_backwards): Support Lisp strings as well.
851 (display_string): Support display of R2L glyph rows.
852 Use IT_STRING_CHARPOS when displaying from a Lisp string.
853 (init_iterator): Don't initialize it->bidi_p for strings
854 here.
855 (reseat_to_string): Initialize it->bidi_p for strings here.
856 (next_element_from_string, next_element_from_c_string)
857 (next_element_from_buffer): Add xassert's for correspondence
858 between IT's object being iterated and it->bidi_it.string
859 structure.
860 (face_before_or_after_it_pos): Support bidi iteration.
861 (next_element_from_c_string): Handle the case of the first string
862 character that is not the first one in the visual order.
863 (get_visually_first_element): New function, refactored from common
864 parts of next_element_from_buffer, next_element_from_string, and
865 next_element_from_c_string.
866 (tool_bar_lines_needed, redisplay_tool_bar)
867 (display_menu_bar): Force left-to-right direction. Add a FIXME
868 comment for making that be controlled by a user option.
869 (push_it, pop_it): Save and restore the state of the
870 bidi iterator. Save and restore the bidi_p flag.
871 (pop_it): Iterate out of display property for string iteration as
872 well.
873 (iterate_out_of_display_property): Support iteration over strings.
874 (handle_single_display_spec): Set up it->bidi_it for iteration
875 over a display string, and call bidi_init_it.
876 (handle_single_display_spec, next_overlay_string)
877 (get_overlay_strings_1, push_display_prop): Set up the bidi
878 iterator for displaying display or overlay strings.
879 (forward_to_next_line_start): Don't use the shortcut if
880 bidi-iterating.
881 (back_to_previous_visible_line_start): If handle_display_prop
882 pushed the iterator stack, restore the internal state of the bidi
883 iterator by calling bidi_pop_it same number of times.
884 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
885 and we are bidi-iterating, don't decrement the iterator position;
886 instead, set the first_elt flag in the bidi iterator, to produce
887 the same effect.
888 (reseat_1): Remove redundant setting of string_from_display_prop_p.
889 (push_display_prop): xassert that we are iterating a buffer.
890 (push_it, pop_it): Save and restore paragraph_embedding member.
891 (handle_single_display_spec, next_overlay_string)
892 (get_overlay_strings_1, reseat_1, reseat_to_string)
893 (push_display_prop): Set up the `unibyte' member of bidi_it.string
894 correctly. Don't assume unibyte strings are not bidi-reordered.
895 (compute_display_string_pos)
896 (compute_display_string_end): Fix handling the case of C string.
897 (push_it, pop_it): Save and restore from_disp_prop_p.
898 (handle_single_display_spec, push_display_prop): Set the
899 from_disp_prop_p flag.
900 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
901 (pop_it): Call iterate_out_of_display_property only if we are
902 popping after iteration over a string that came from a display
903 property. Fix a typo in popping stretch info. Add an assertion
904 for verifying that the iterator position is in sync with the bidi
905 iterator.
906 (handle_single_display_spec, get_overlay_strings_1)
907 (push_display_prop): Fix initialization of paragraph direction for
908 string when that of the parent object is not yet determined.
909 (reseat_1): Call bidi_init_it to resync the bidi
910 iterator with IT's position. (Bug#7616)
911 (find_row_edges): If ROW->start.pos gives position
912 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
913 (handle_stop, back_to_previous_visible_line_start, reseat_1):
914 Reset the from_disp_prop_p flag.
915 (SAVE_IT, RESTORE_IT): New macros.
916 (pos_visible_p, face_before_or_after_it_pos)
917 (back_to_previous_visible_line_start)
918 (move_it_in_display_line_to, move_it_in_display_line)
919 (move_it_to, move_it_vertically_backward, move_it_by_lines)
920 (try_scrolling, redisplay_window, display_line): Use them when
921 saving a temporary copy of the iterator and restoring it back.
922 (back_to_previous_visible_line_start, reseat_1)
923 (init_iterator): Empty the bidi cache "stack".
924 (move_it_in_display_line_to): If iterator ended up at
925 EOL, but we never saw any buffer positions smaller than
926 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
927 motion in bidi-reordered lines.
928 (move_it_in_display_line_to): Record prev_method and prev_pos
929 immediately before the call to set_iterator_to_next. Fixes cursor
930 motion in bidi-reordered lines with stretch glyphs and strings
931 displayed in margins. (Bug#8133) (Bug#8867)
932 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
933 TO_CHARPOS.
934 (pos_visible_p): Support positions in bidi-reordered lines.
935 Save and restore bidi cache.
936
937 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
938 (bidi_paragraph_info): Delete unused struct.
939 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
940 (bidi_cache_start): New variable.
941 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
942 to zero.
943 (bidi_cache_fetch_state, bidi_cache_search)
944 (bidi_cache_find_level_change, bidi_cache_iterator_state)
945 (bidi_cache_find, bidi_peek_at_next_level)
946 (bidi_level_of_next_char, bidi_find_other_level_edge)
947 (bidi_move_to_visually_next): Compare cache index with
948 bidi_cache_start rather than with zero.
949 (bidi_fetch_char): Accept new argument STRING; all callers
950 changed. Support iteration over a string. Support strings with
951 display properties. Support unibyte strings. Fix the type of
952 `len' according to what STRING_CHAR_AND_LENGTH expects.
953 (bidi_paragraph_init, bidi_resolve_explicit_1)
954 (bidi_resolve_explicit, bidi_resolve_weak)
955 (bidi_level_of_next_char, bidi_move_to_visually_next):
956 Support iteration over a string.
957 (bidi_set_sor_type, bidi_resolve_explicit_1)
958 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
959 can now be zero (for strings); special values 0 and -1 were
960 changed to -1 and -2, respectively.
961 (bidi_char_at_pos): New function.
962 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
963 Call it instead of FETCH_MULTIBYTE_CHAR.
964 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
965 initialized to valid values.
966 (bidi_init_it): Don't initialize charpos and bytepos with invalid
967 values.
968 (bidi_level_of_next_char): Allow the sentinel "position" to pass
969 the test for valid cached positions. Fix the logic for looking up
970 the sentinel state in the cache. GCPRO the Lisp string we are
971 iterating.
972 (bidi_push_it, bidi_pop_it): New functions.
973 (bidi_initialize): Initialize the bidi cache start stack pointer.
974 (bidi_cache_ensure_space): New function, refactored from part of
975 bidi_cache_iterator_state. Don't assume the required size is just
976 one BIDI_CACHE_CHUNK away.
977 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
978 (bidi_count_bytes, bidi_char_at_pos): New functions.
979 (bidi_cache_search): Don't assume bidi_cache_last_idx is
980 always valid if bidi_cache_idx is valid.
981 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
982 is valid if it's going to be used.
983 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
984 (bidi_cache_fetch_state, bidi_cache_search)
985 (bidi_cache_find_level_change, bidi_cache_ensure_space)
986 (bidi_cache_iterator_state, bidi_cache_find)
987 (bidi_find_other_level_edge, bidi_cache_start_stack):
988 All variables related to cache indices are now EMACS_INT.
989
990 * dispextern.h (struct bidi_string_data): New structure.
991 (struct bidi_it): New member `string'. Make flag members be 1-bit
992 fields, and put them last in the struct.
993 (compute_display_string_pos, compute_display_string_end):
994 Update prototypes.
995 (bidi_push_it, bidi_pop_it): Add prototypes.
996 (struct iterator_stack_entry): New members bidi_p,
997 paragraph_embedding, and from_disp_prop_p.
998 (struct it): Member bidi_p is now a bit field 1 bit wide.
999 (bidi_shelve_cache, bidi_unshelve_cache):
1000 Declare prototypes.
1001
1002 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1003 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1004 and vector-like objects.
1005
1006 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1007 cache around display iteration.
1008
1009 * window.c (Fwindow_end, window_scroll_pixel_based)
1010 (displayed_window_lines, Frecenter): Save and restore the bidi
1011 cache around display iteration.
1012
1013 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1014
1015 * editfns.c (Fdelete_region): Clarify the use of the named
1016 parameters (bug#6788).
1017
1018 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1019
1020 * indent.c (Fvertical_motion): Set and restore w->pointm when
1021 saving and restoring the window's buffer (Bug#9006).
1022
1023 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1024
1025 * editfns.c (Fstring_to_char): Clarify just what is returned
1026 (bug#6576). Text by Eli Zaretskii.
1027
1028 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1029
1030 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1031
1032 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1033
1034 * buffer.c (mmap_find): Fix a typo.
1035
1036 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1037
1038 Fix execution of x selection hooks.
1039 * xselect.c (Qx_lost_selection_functions)
1040 (Qx_sent_selection_functions): New vars.
1041 (syms_of_xselect): DEFSYM them.
1042 (x_handle_selection_request): Pass Qx_sent_selection_functions
1043 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1044 (x_handle_selection_clear,x_clear_frame_selections):
1045 Pass Qx_lost_selection_functions rather than
1046 Vx_lost_selection_functions to Frun_hook_with_args.
1047
1048 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1051 The old code sometimes used this field without initializing it.
1052
1053 * alloc.c (gc_sweep): Don't read past end of array.
1054 In theory, the old code could also have corrupted Emacs internals,
1055 though it'd be very unlikely.
1056
1057 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1058
1059 * character.c (Fcharacterp): Don't advertise optional ignored
1060 argument. (Bug#4026)
1061
1062 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1063
1064 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1065 key" (bug#4257).
1066
1067 * window.c (Fset_window_start): Doc fix (bug#4199).
1068 (Fset_window_hscroll): Ditto.
1069
1070 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 Fix minor new problems caught by GCC 4.6.1.
1073 * term.c (init_tty): Remove unused local.
1074 * xsettings.c (store_monospaced_changed): Define this function only
1075 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1076 not used otherwise.
1077
1078 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1079
1080 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1081
1082 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1083
1084 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1085 are the mini-buffer and the echo area (bug#3320).
1086
1087 * term.c (init_tty): Remove support for supdup, c10 and perq
1088 terminals, which are no longer supported (bug#1482).
1089
1090 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1091
1092 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1093
1094 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1095
1096 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1097 for non-popups (Bug#3642).
1098
1099 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1100
1101 * alloc.c (reset_malloc_hooks): Protoize.
1102 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1103 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1104 * cm.c (losecursor): Likewise.
1105 * data.c (fmod): Likewise.
1106 * dispnew.c (swap_glyphs_in_rows): Likewise.
1107 * emacs.c (memory_warning_signal): Likewise.
1108 * floatfns.c (float_error): Likewise.
1109 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1110 (otf_open, font_otf_capability, generate_otf_features)
1111 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1112 Likewise.
1113 * image.c (pbm_read_file): Likewise.
1114 * indent.c (string_display_width): Likewise.
1115 * intervals.c (check_for_interval, search_for_interval)
1116 (inc_interval_count, count_intervals, root_interval)
1117 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1118 * lread.c (defalias): Likewise.
1119 * ralloc.c (r_alloc_check): Likewise.
1120 * regex.c (set_image_of_range_1, set_image_of_range)
1121 (regex_grow_registers): Likewise.
1122 * sysdep.c (strerror): Likewise.
1123 * termcap.c (valid_filename_p, tprint, main): Likewise.
1124 * tparam.c (main): Likewise.
1125 * unexhp9k800.c (run_time_remap, save_data_space)
1126 (update_file_ptrs, read_header, write_header, calculate_checksum)
1127 (copy_file, copy_rest, display_header): Likewise.
1128 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1129 Likewise.
1130 * xdisp.c (check_it): Likewise.
1131 * xfaces.c (register_color, unregister_color, unregister_colors):
1132 Likewise.
1133 * xfns.c (print_fontset_result): Likewise.
1134 * xrdb.c (member, fatal, main): Likewise.
1135
1136 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1137
1138 Fix minor problems found by static checking (Bug#9031).
1139 * chartab.c (char_table_set_range, map_sub_char_table):
1140 Remove unused locals.
1141 (uniprop_table): Now static.
1142 * composite.c (_work_char): Remove unused static var.
1143
1144 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1145
1146 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1147
1148 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1149
1150 * gtkutil.c (qttip_cb): Remove code without function.
1151
1152 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1153
1154 * w32.c (pthread_sigmask): New stub.
1155
1156 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1157
1158 Use pthread_sigmask, not sigprocmask (Bug#9010).
1159 sigprocmask is portable only for single-threaded applications, and
1160 Emacs can be multi-threaded when it uses GTK.
1161 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1162 (LIBES): Use it.
1163 * callproc.c (Fcall_process):
1164 * process.c (create_process):
1165 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1166 Use pthread_sigmask, not sigprocmask.
1167
1168 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1169
1170 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1171 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1172 wrong (Bug#8591).
1173
1174 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1175
1176 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1177 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1178 (xg_hide_tooltip): Fix comment.
1179
1180 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1181 in registerServicesMenuSendTypes.
1182 (validRequestorForSendType): Don't check ns_return_types.
1183
1184 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1185 ns_return_type.
1186
1187 2011-07-08 Jason Rumney <jasonr@gnu.org>
1188
1189 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1190 frame struct members of non-existent frames (Bug#6284).
1191
1192 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1193
1194 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1195 variable firstTime not needed on OSX >= 10.6.
1196 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1197 >= 10.5. Use setKnobProportion, setDoubleValue.
1198
1199 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1200 (MAC_OS_X_VERSION_10_5): Define if not defined.
1201 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1202 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1203 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1204
1205 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1206 cString and lossyCString on OSX >= 10.4
1207
1208 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1209 sizeToFit on OSX >= 10.2.
1210
1211 * nsimage.m (allocInitFromFile): Don't use deprecated method
1212 bestRepresentationForDevice on OSX >= 10.6.
1213
1214 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1215 to avoid warning.
1216
1217 * emacs.c: Declare unexec_init_emacs_zone.
1218
1219 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1220
1221 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1222
1223 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1224 on svcsMenu (Bug#8842).
1225
1226 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1227 ns_return_types.
1228 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1229
1230 * nsterm.m (QUTF8_STRING): Declare.
1231 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1232 (validRequestorForSendType): Return type is (id).
1233 Change indexOfObjectIdenticalTo to indexOfObject.
1234 Check if we have local selection before returning self (Bug#8842).
1235 (writeSelectionToPasteboard): Put local selection into paste board
1236 if we have a local selection (Bug#8842).
1237 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1238
1239 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1240 (ns_get_local_selection): Declare.
1241
1242 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1243
1244 * keymap.c (describe_map_tree): Don't insert a double newline at
1245 the end of the buffer (bug#1169) and return whether we inserted
1246 something.
1247
1248 * callint.c (Fcall_interactively): Change "reading args" to
1249 "providing args" to try to clarify what it does (bug#1010).
1250
1251 2011-07-07 Kenichi Handa <handa@m17n.org>
1252
1253 * composite.c (composition_compute_stop_pos): Ignore a static
1254 composition starting before CHARPOS (Bug#8915).
1255
1256 * xdisp.c (handle_composition_prop): Likewise.
1257
1258 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1259
1260 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1261 (Bug#9015)
1262
1263 2011-07-07 Kenichi Handa <handa@m17n.org>
1264
1265 * character.h (unicode_category_t): New enum type.
1266
1267 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1268 (Qchar_code_property_table): New variable.
1269 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1270 (UNIPROP_COMPRESSED_FORM_P): New macros.
1271 (char_table_ascii): Uncompress the compressed values.
1272 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1273 Uncompress the compressed values.
1274 (sub_char_table_ref_and_range): Likewise.
1275 (char_table_ref_and_range): Uncompress the compressed values.
1276 (sub_char_table_set): New arg is_uniprop. Callers changed.
1277 Uncompress the compressed values.
1278 (sub_char_table_set_range): Args changed. Callers changed.
1279 (char_table_set_range): Adjuted for the above change.
1280 (map_sub_char_table): Delete args default_val and parent. Add arg
1281 top. Give decoded values to a Lisp function.
1282 (map_char_table): Adjust for the above change. Give decoded
1283 values to a Lisp function. Gcpro more variables.
1284 (uniprop_table_uncompress)
1285 (uniprop_decode_value_run_length): New functions.
1286 (uniprop_decoder, uniprop_decoder_count): New variables.
1287 (uniprop_get_decoder, uniprop_encode_value_character)
1288 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1289 New functions.
1290 (uniprop_encoder, uniprop_encoder_count): New variables.
1291 (uniprop_get_encoder, uniprop_table)
1292 (Funicode_property_table_internal, Fget_unicode_property_internal)
1293 (Fput_unicode_property_internal): New functions.
1294 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1295 Sunicode_property_table_internal, Sget_unicode_property_internal,
1296 and Sput_unicode_property_internal. Defvar_lisp
1297 char-code-property-alist.
1298
1299 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1300 Vunicode_category_table.
1301
1302 * font.c (font_range): Adjust for the change of
1303 Vunicode_category_table.
1304
1305 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1306
1307 * m/iris4d.h: Remove file, move contents ...
1308 * s/irix6-5.h: ... here.
1309
1310 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1311
1312 Remove unportable assumption about struct layout (Bug#8884).
1313 * alloc.c (mark_buffer):
1314 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1315 (clone_per_buffer_values): Don't assume that
1316 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1317 This isn't true in general, and it's particularly not true
1318 if Emacs is configured with --with-wide-int.
1319 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1320 New macros, used in the buffer.c change.
1321
1322 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1323
1324 * xsettings.c: Use both GConf and GSettings if both are available.
1325 (store_config_changed_event): Add comment.
1326 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1327 (store_tool_bar_style_changed): New functions.
1328 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1329 (struct xsettings): Move font inside HAVE_XFT.
1330 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1331 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1332 Move inside HAVE_XFT.
1333 (something_changed_gsettingsCB): Rename from something_changedCB.
1334 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1335 also.
1336 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1337 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1338 (something_changed_gconfCB): Rename from something_changedCB.
1339 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1340 (parse_settings): Move check for font inside HAVE_XFT.
1341 (read_settings, apply_xft_settings): Add comment.
1342 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1343 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1344 call store_font_name_changed.
1345 (xft_settings_event): Add comment.
1346 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1347 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1348 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1349 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1350 (xsettings_initialize): Call init_gsettings last.
1351 (xsettings_get_system_font, xsettings_get_system_normal_font):
1352 Add comment.
1353
1354 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1355
1356 Random fixes. E.g., (random) never returned negative values.
1357 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1358 subseconds part to the entropy, as that's a bit more random.
1359 Prefer signed to unsigned, since the signedness doesn't matter and
1360 in general we prefer signed. When given a limit, use a
1361 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1362 latter isn't right if USE_2_TAGS_FOR_INTS.
1363 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1364 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1365
1366 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1367
1368 * textprop.c (text_property_stickiness):
1369 Obey Vtext_property_default_nonsticky.
1370 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1371 * w32fns.c (syms_of_w32fns):
1372 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1373
1374 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1377 This is more efficient than Ffile_directory_p and avoids a minor race.
1378
1379 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1380
1381 * buffer.c (Foverlay_put): Say what the return value is
1382 (bug#7835).
1383
1384 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1385 is a directory before asking whether to use the file name
1386 (bug#7564).
1387 (barf_or_query_if_file_exists): Make the "File is a directory"
1388 error be more correct.
1389
1390 * fns.c (Frequire): Remove the mention of the .gz files, since
1391 that's installation-specific, but keep the mention of
1392 `get-load-suffixes'.
1393
1394 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1395
1396 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1397 Report string overflow if the output is too long.
1398
1399 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1400
1401 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1402 (syms_of_gnutls): Remove duplicate DEFSYM for
1403 Qgnutls_bootprop_verify_hostname_error, an error for
1404 Qgnutls_bootprop_verify_error (which is no longer used).
1405
1406 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1407 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1408 Also (re)move comments that are misplaced or no longer relevant.
1409
1410 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1411
1412 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1413
1414 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1415
1416 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1417 and background color parameters if they have been changed.
1418
1419 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1420
1421 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1422
1423 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1424
1425 * xsettings.c (SYSTEM_FONT): Define only when used.
1426 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1427
1428 * keymap.c (access_keymap_1): Now static.
1429
1430 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1431
1432 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1433 leave any prefix arg for the up event (Bug#1586).
1434
1435 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1436
1437 * lread.c (syms_of_lread): Mention single symbols defined by
1438 `defvar' or `defconst' (bug#7154).
1439
1440 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1441 (Frequire): Mention get-load-suffixes.
1442
1443 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1444
1445 * window.h (window): Remove clone_number slot.
1446 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1447 Remove.
1448 (make_parent_window, make_window, saved_window)
1449 (Fset_window_configuration, save_window_save): Don't deal with
1450 clone numbers.
1451 * buffer.c (Qclone_number): Remove declaration.
1452 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1453
1454 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1455
1456 Add multiple inheritance to keymaps.
1457 * keymap.c (Fmake_composed_keymap): New function.
1458 (Fset_keymap_parent): Simplify.
1459 (fix_submap_inheritance): Remove.
1460 (access_keymap_1): New function extracted from access_keymap to handle
1461 embedded parents and handle lists of maps.
1462 (access_keymap): Use it.
1463 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1464 (Fcopy_keymap): Handle embedded parents.
1465 (Fcommand_remapping, define_as_prefix): Simplify.
1466 (Fkey_binding): Simplify.
1467 (syms_of_keymap): Move minibuffer-local-completion-map,
1468 minibuffer-local-filename-completion-map,
1469 minibuffer-local-must-match-map, and
1470 minibuffer-local-filename-must-match-map to Elisp.
1471 (syms_of_keymap): Defsubr make-composed-keymap.
1472 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1473 (parse_menu_item): Trivial simplification.
1474
1475 2011-07-01 Glenn Morris <rgm@gnu.org>
1476
1477 * Makefile.in (SETTINGS_LIBS): Fix typo.
1478
1479 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1480
1481 * coding.c (Fencode_coding_string): Record the last coding system
1482 used, as the function doc string says (bug#8738).
1483
1484 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1485
1486 * xsettings.c (store_monospaced_changed): Take new font as arg and
1487 check for change against current_mono_font.
1488 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1489 (emacs_settings_constructor, emacs_settings_get_property)
1490 (emacs_settings_set_property, emacs_settings_class_init)
1491 (emacs_settings_init, gsettings_obj): Remove.
1492 (something_changedCB): New function for HAVE_GSETTINGS.
1493 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1494 with value as argument.
1495 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1496 g_settings_new (Bug#8967). Do not create gsettings_obj.
1497 Remove calls to g_settings_bind. Connect something_changedCB to
1498 "changed".
1499
1500 * xgselect.c: Add defined (HAVE_GSETTINGS).
1501 (xgselect_initialize): Ditto.
1502
1503 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1504 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1505 xg_select.
1506
1507 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 * eval.c (struct backtrace): Simplify and port the data structure.
1510 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1511 signed bit field, as this assumption is not portable and it makes
1512 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1513 "char debug_on_exit : 1" as this is not portable either; instead,
1514 use the portable "unsigned int debug_on_exit : 1". Remove unused
1515 member evalargs. Remove obsolete comments about cc bombing out.
1516
1517 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1518
1519 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1520 Let HAVE_GSETTINGS override HAVE_GCONF.
1521 (store_monospaced_changed): New function.
1522 (EMACS_SETTINGS): A new type derived from GObject to handle
1523 GSettings notifications.
1524 (emacs_settings_constructor, emacs_settings_get_property)
1525 (emacs_settings_set_property, emacs_settings_class_init):
1526 New functions.
1527 (gsettings_client, gsettings_obj): New variables.
1528 (GSETTINGS_SCHEMA): New define.
1529 (something_changedCB): Call store_monospaced_changed.
1530 (init_gsettings): New function.
1531 (xsettings_initialize): Call init_gsettings.
1532 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1533 to NULL.
1534
1535 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1536 GCONF_CFLAGS/LIBS.
1537
1538 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1539
1540 * window.c (resize_root_window, grow_mini_window)
1541 (shrink_mini_window): Rename Qresize_root_window to
1542 Qwindow_resize_root_window and Qresize_root_window_vertically to
1543 Qwindow_resize_root_window_vertically.
1544
1545 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1546
1547 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1548
1549 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1550
1551 * makefile.w32-in: Redesign dependencies so they reflect more
1552 clearly which files are directly included by each source file,
1553 and not through other includes.
1554
1555 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1556
1557 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1558 (sort_overlays, overlay_strings): When an overlay's clone number
1559 matches the window's clone number process the overlay even if
1560 the overlay's window property doesn't match the current window.
1561
1562 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1563 (Fwindow_hchild): Rename to Fwindow_left_child.
1564 (Fwindow_next): Rename to Fwindow_next_sibling.
1565 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1566 (resize_window_check): Rename to window_resize_check.
1567 (resize_window_apply): Rename to window_resize_apply.
1568 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1569 (Fdelete_other_windows_internal, resize_frame_windows)
1570 (Fsplit_window_internal, Fdelete_window_internal)
1571 (grow_mini_window, shrink_mini_window)
1572 (Fresize_mini_window_internal): Fix callers accordingly.
1573
1574 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1575
1576 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1577 (emacs_fixed_set_min_size): Remove.
1578 (emacs_fixed_new): Take frame as argument.
1579
1580 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1581 (_EmacsFixedPrivate): Remove minwidth/height.
1582 Add struct frame *f.
1583 (emacs_fixed_init): Initialize priv->f.
1584 (get_parent_class, emacs_fixed_set_min_size): Remove.
1585 (emacs_fixed_new): Set priv->f to argument.
1586 (emacs_fixed_get_preferred_width)
1587 (emacs_fixed_get_preferred_height): Use min_width/height from
1588 frames size_hint to set minimum and natural (Bug#8919).
1589 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1590 and use min_width/height from frames size_hint to set
1591 min_width/height (Bug#8919).
1592
1593 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1594 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1595 Fix indentation.
1596
1597 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1598
1599 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1600 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1601 called at ZV.
1602
1603 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1604
1605 * process.c (wait_reading_process_output): Bypass select if
1606 waiting for a cell while ignoring keyboard input, and input is
1607 pending. Suggested by Jan Djärv (Bug#8869).
1608
1609 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1610
1611 Use gnulib's dup2 module instead of rolling our own.
1612 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1613
1614 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1615
1616 * dispnew.c (scrolling_window): Before scrolling, turn off a
1617 mouse-highlight in the window being scrolled.
1618
1619 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1620
1621 Move DEFSYM to lisp.h and use everywhere.
1622
1623 * character.h (DEFSYM): Move declaration...
1624 * lisp.h (DEFSYM): ...here.
1625
1626 * gnutls.c:
1627 * minibuf.c:
1628 * w32menu.c:
1629 * w32proc.c:
1630 * w32select.c: Don't include character.h.
1631
1632 * alloc.c (syms_of_alloc):
1633 * buffer.c (syms_of_buffer):
1634 * bytecode.c (syms_of_bytecode):
1635 * callint.c (syms_of_callint):
1636 * casefiddle.c (syms_of_casefiddle):
1637 * casetab.c (init_casetab_once):
1638 * category.c (init_category_once, syms_of_category):
1639 * ccl.c (syms_of_ccl):
1640 * cmds.c (syms_of_cmds):
1641 * composite.c (syms_of_composite):
1642 * dbusbind.c (syms_of_dbusbind):
1643 * dired.c (syms_of_dired):
1644 * dispnew.c (syms_of_display):
1645 * doc.c (syms_of_doc):
1646 * editfns.c (syms_of_editfns):
1647 * emacs.c (syms_of_emacs):
1648 * eval.c (syms_of_eval):
1649 * fileio.c (syms_of_fileio):
1650 * fns.c (syms_of_fns):
1651 * frame.c (syms_of_frame):
1652 * fringe.c (syms_of_fringe):
1653 * insdel.c (syms_of_insdel):
1654 * keymap.c (syms_of_keymap):
1655 * lread.c (init_obarray, syms_of_lread):
1656 * macros.c (syms_of_macros):
1657 * msdos.c (syms_of_msdos):
1658 * print.c (syms_of_print):
1659 * process.c (syms_of_process):
1660 * search.c (syms_of_search):
1661 * sound.c (syms_of_sound):
1662 * syntax.c (init_syntax_once, syms_of_syntax):
1663 * terminal.c (syms_of_terminal):
1664 * textprop.c (syms_of_textprop):
1665 * undo.c (syms_of_undo):
1666 * w32.c (globals_of_w32):
1667 * window.c (syms_of_window):
1668 * xdisp.c (syms_of_xdisp):
1669 * xfaces.c (syms_of_xfaces):
1670 * xfns.c (syms_of_xfns):
1671 * xmenu.c (syms_of_xmenu):
1672 * xsettings.c (syms_of_xsettings):
1673 * xterm.c (syms_of_xterm): Use DEFSYM.
1674
1675 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1676
1677 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1678
1679 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1680
1681 Integer and buffer overflow fixes (Bug#8873).
1682
1683 * print.c (printchar, strout): Check for string overflow.
1684 (PRINTPREPARE, printchar, strout):
1685 Don't set size unless allocation succeeds.
1686
1687 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1688 for sizes. Check for string overflow more accurately.
1689 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1690
1691 * macros.c: Integer and buffer overflow fixes.
1692 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1693 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1694 Use ptrdiff_t, not int, for sizes.
1695 Don't increment bufsize until after realloc succeeds.
1696 Check for size-calculation overflow.
1697 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1698
1699 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1700
1701 * lread.c: Integer overflow fixes.
1702 (read_integer): Radix is now EMACS_INT, not int,
1703 to improve quality of diagnostics for out-of-range radices.
1704 Calculate buffer size correctly for out-of-range radices.
1705 (read1): Check for integer overflow in radices, and in
1706 read-circle numbers.
1707 (read_escape): Avoid int overflow.
1708 (Fload, openp, read_buffer_size, read1)
1709 (substitute_object_recurse, read_vector, read_list, map_obarray):
1710 Use ptrdiff_t, not int, for sizes.
1711 (read1): Use EMACS_INT, not int, for sizes.
1712 Check for size overflow.
1713
1714 * image.c (cache_image): Check for size arithmetic overflow.
1715
1716 * lread.c: Integer overflow issues.
1717 (saved_doc_string_size, saved_doc_string_length)
1718 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1719 Now ptrdiff_t, not int.
1720 (read1): Don't assume doc string length fits in int. Check for
1721 out-of-range doc string lengths.
1722 (read_list): Don't assume file position fits in int.
1723 (read_escape): Check for hex character overflow.
1724
1725 2011-06-22 Leo Liu <sdl.web@gmail.com>
1726
1727 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1728 Move to minibuffer.el.
1729
1730 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1733 The following patches are for when GLYPH_DEBUG && !XASSERT.
1734 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1735 * dispnew.c (flush_stdout):
1736 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1737 Mark as externally visible.
1738 * dispnew.c (check_window_matrix_pointers): Now static.
1739 * dispnew.c (window_to_frame_vpos):
1740 * xfns.c (unwind_create_frame):
1741 * xterm.c (x_check_font): Remove unused local.
1742 * scroll.c (CHECK_BOUNDS):
1743 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1744 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1745 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1746 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1747 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1748 Now static.
1749 (debug_method_add): Use va_list and vsprintf rather than relying
1750 on undefined behavior with wrong number of arguments.
1751 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1752 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1753 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1754 since we're not interested in debugging glyphs with old libraries.
1755 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1756 GCC 4.6.0's static checking.
1757
1758 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1759
1760 Integer overflow and signedness fixes (Bug#8873).
1761 A few related buffer overrun fixes, too.
1762
1763 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1764
1765 * dispextern.h (struct face.stipple):
1766 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1767 (x_bitmap_mask, x_allocate_bitmap_record)
1768 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1769 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1770 (x_create_bitmap_from_xpm_data):
1771 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1772 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1773 (.bitmaps_last):
1774 * xfaces.c (load_pixmap):
1775 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1776 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1777 (.bitmaps_last, struct x_output.icon_bitmap):
1778 Use ptrdiff_t, not int, for bitmap indexes.
1779 (x_allocate_bitmap_record): Check for size overflow.
1780 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1781
1782 Use ptrdiff_t, not int, for overlay counts.
1783 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1784 * editfns.c (overlays_around, get_pos_property):
1785 * textprop.c (get_char_property_and_overlay):
1786 * xdisp.c (next_overlay_change, note_mouse_highlight):
1787 * xfaces.c (face_at_buffer_position):
1788 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1789 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1790 (Fnext_overlay_change, Fprevious_overlay_change)
1791 (mouse_face_overlay_overlaps, Foverlays_in):
1792 Use ptrdiff_t, not int, for sizes.
1793 (overlays_at, overlays_in): Check for size-calculation overflow.
1794
1795 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1796
1797 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1798 (x_session_initialize): Do not assume string length fits in int.
1799
1800 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1801 This is unlikely, but can occur if DPI is outlandish.
1802
1803 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1804 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1805
1806 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1807 * xrdb.c (magic_file_p, search_magic_path):
1808 Omit last arg SUFFIX; it was always 0. All callers changed.
1809 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1810
1811 * xfont.c (xfont_match): Avoid need for strlen.
1812
1813 * xfns.c: Don't assume strlen fits in int.
1814 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1815
1816 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1817 not unsigned long, as we prefer signed integers. All callers changed.
1818 Detect integer overflow in repeat count.
1819 (message_dolog): Don't assume print length fits in 39 bytes.
1820 (display_mode_element): Don't assume strlen fits in int.
1821
1822 * termcap.c: Don't assume sizes fit in int and never overflow.
1823 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1824 (gobble_line): Check for size-calculation overflow.
1825
1826 * minibuf.c (Fread_buffer):
1827 * lread.c (intern, intern_c_string):
1828 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1829 Don't assume string length fits in int.
1830
1831 * keyboard.c (parse_tool_bar_item):
1832 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1833
1834 * font.c: Don't assume string length fits in int.
1835 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1836 Use ptrdiff_t, not int.
1837 (font_intern_prop): Don't assume string length fits in int.
1838 Don't assume integer property fits in fixnum.
1839 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1840
1841 * filelock.c: Fix some buffer overrun and integer overflow issues.
1842 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1843 Reformulate so as not to need the command string.
1844 Invoke gzip -cd rather than gunzip, as it's more portable.
1845 (lock_info_type, lock_file_1, lock_file):
1846 Don't assume pid_t and time_t fit in unsigned long.
1847 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1848 (current_lock_owner): Prefer signed type for sizes.
1849 Use memcpy, not strncpy, where memcpy is what is really wanted.
1850 Don't assume (via atoi) that time_t and pid_t fit in int.
1851 Check for time_t and/or pid_t out of range, e.g., via a network share.
1852 Don't alloca where an auto var works fine.
1853
1854 * fileio.c: Fix some integer overflow issues.
1855 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1856 Don't assume string length fits in int.
1857 (directory_file_name): Don't assume string length fits in long.
1858 (make_temp_name): Don't assume pid fits in int, or that its print
1859 length is less than 20.
1860
1861 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1862
1863 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1864
1865 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1866
1867 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1868 We prefer signed integers, even for size calculations.
1869
1870 * emacs.c: Don't assume string length fits in 'int'.
1871 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1872 (main): Don't invoke strlen when not needed.
1873
1874 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1875 (XD_DEBUG_MESSAGE): Don't waste a byte.
1876
1877 * callproc.c (getenv_internal_1, getenv_internal)
1878 (Fgetenv_internal):
1879 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1880
1881 * lread.c (invalid_syntax): Omit length argument.
1882 All uses changed. This doesn't fix a bug, but it simplifies the
1883 code away from its former Hollerith-constant appearance, and it's
1884 one less 'int' to worry about when looking at integer-overflow issues.
1885 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1886
1887 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1888 This didn't break anything, but it didn't help either.
1889 It's confusing to put a bogus integer in a place where the actual
1890 value does not matter.
1891 (LIST_END_P): Remove unused macro and its bogus comment.
1892 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1893
1894 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1895 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1896 implementation.
1897 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1898 We prefer signed types, and the value cannot exceed the EMACS_INT
1899 range anyway (because otherwise the length would not be representable).
1900 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1901 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1902 This avoids a GCC warning when WIDE_EMACS_INT.
1903
1904 * indent.c (sane_tab_width): New function.
1905 (current_column, scan_for_column, Findent_to, position_indentation)
1906 (compute_motion): Use it. This is just for clarity.
1907 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1908
1909 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1910
1911 * lisp.h (lint_assume): New macro.
1912 * composite.c (composition_gstring_put_cache):
1913 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1914
1915 * editfns.c, insdel.c:
1916 Omit unnecessary forward decls, to simplify future changes.
1917
1918 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1919
1920 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1921
1922 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1923 Use much-faster test for byte-length change.
1924 Don't assume string byte-length fits in 'int'.
1925 Check that character arg fits in 'int'.
1926 (mapcar1): Declare byte as byte, for clarity.
1927
1928 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1929
1930 * fns.c (concat): Catch string overflow earlier.
1931 Do not rely on integer wraparound.
1932
1933 * dispextern.h (struct it.overlay_strings_charpos)
1934 (struct it.selective): Now EMACS_INT, not int.
1935 * xdisp.c (forward_to_next_line_start)
1936 (back_to_previous_visible_line_start)
1937 (reseat_at_next_visible_line_start, next_element_from_buffer):
1938 Don't arbitrarily truncate the value of 'selective' to int.
1939
1940 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1941
1942 * composite.c: Don't truncate sizes to 'int'.
1943 (composition_gstring_p, composition_reseat_it)
1944 (composition_adjust_point): Use EMACS_INT, not int.
1945 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1946 not EMACS_UINT, for indexes.
1947
1948 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1949
1950 * buffer.c: Include <verify.h>.
1951 (struct sortvec.priority, struct sortstr.priority):
1952 Now EMACS_INT, not int.
1953 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1954 (struct sortstr.size, record_overlay_string)
1955 (struct sortstrlist.size, struct sortlist.used):
1956 Don't truncate size to int.
1957 (record_overlay_string): Check for size-calculation overflow.
1958 (init_buffer_once): Check at compile-time, not run-time.
1959
1960 2011-06-22 Jim Meyering <meyering@redhat.com>
1961
1962 Don't leak an XBM-image-sized buffer
1963 * image.c (xbm_load): Free the image buffer after using it.
1964
1965 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 Port to Sun C.
1968 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1969 that Sun C diagnosed.
1970 * fns.c (secure_hash): Fix pointer signedness issue.
1971 * intervals.c (static_offset_intervals): New function.
1972 (offset_intervals): Use it.
1973
1974 2011-06-21 Leo Liu <sdl.web@gmail.com>
1975
1976 * deps.mk (fns.o):
1977 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1978 sha512.h.
1979
1980 * fns.c (secure_hash): Rename from crypto_hash_function and change
1981 the first arg to accept symbols.
1982 (Fsecure_hash): New primitive.
1983 (syms_of_fns): New symbols.
1984
1985 2011-06-20 Deniz Dogan <deniz@dogan.se>
1986
1987 * process.c (Fset_process_buffer): Clarify return value in
1988 docstring.
1989
1990 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1991
1992 * dispnew.c (add_window_display_history): Use BVAR.
1993
1994 * xdisp.c (debug_method_add): Use BVAR.
1995 (check_window_end, dump_glyph_matrix, dump_glyph)
1996 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1997
1998 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1999 Likewise.
2000
2001 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2002 check till after the cache is created in init_frame_faces.
2003
2004 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2005
2006 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2007
2008 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2009
2010 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2011 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2012 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2013
2014 Improve buffer-overflow checking (Bug#8873).
2015 * fileio.c (Finsert_file_contents):
2016 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2017 Remove the old (too-loose) buffer overflow checks.
2018 They weren't needed, since make_gap checks for buffer overflow.
2019 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2020 The old code merely checked for Emacs fixnum overflow, and relied
2021 on undefined (wraparound) behavior. The new code avoids undefined
2022 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2023
2024 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2025 Tune. Don't use wider integers than needed. Don't use alloca.
2026 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2027
2028 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2029
2030 * insdel.c, lisp.h (buffer_overflow): New function.
2031 (insert_from_buffer_1, replace_range, replace_range_2):
2032 * insdel.c (make_gap_larger):
2033 * editfns.c (Finsert_char):
2034 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2035
2036 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2037
2038 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2039
2040 Integer overflow and signedness fixes (Bug#8873).
2041
2042 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2043 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2044
2045 * fileio.c: Don't assume EMACS_INT fits in off_t.
2046 (emacs_lseek): New static function.
2047 (Finsert_file_contents, Fwrite_region): Use it.
2048 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2049
2050 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2051
2052 * fns.c: Don't overflow int when computing a list length.
2053 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2054 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2055 truncation on 64-bit hosts. Check for QUIT every
2056 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2057 faster and is responsive enough.
2058 (Flength): Report an error instead of overflowing an integer.
2059 (Fsafe_length): Return a float if the value is not representable
2060 as a fixnum. This shouldn't happen except in contrived situations.
2061 (Fnthcdr, Fsort): Don't assume list length fits in int.
2062 (Fcopy_sequence): Don't assume vector length fits in int.
2063
2064 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2065 (header_size, word_size): New constants.
2066 (allocate_vectorlike): Don't check size overflow here.
2067 (allocate_vector): Check it here instead, since this is the only
2068 caller of allocate_vectorlike that could cause overflow.
2069 Check that the new vector's length is representable as a fixnum.
2070
2071 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2072 The previous code was bogus. For example, next_almost_prime (32)
2073 returned 39, which is undesirable as it is a multiple of 3; and
2074 next_almost_prime (24) returned 25, which is a multiple of 5 so
2075 why was the code bothering to check for multiples of 7?
2076
2077 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2078
2079 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2080
2081 Variadic C functions now count arguments with ptrdiff_t.
2082 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2083 Back then I didn't know that the Emacs coding style prefers signed int.
2084 Also, in the meantime I found a few more instances where arguments
2085 were being counted with int, which may truncate counts on 64-bit
2086 machines, or EMACS_INT, which may be unnecessarily wide.
2087 * lisp.h (struct Lisp_Subr.function.aMANY)
2088 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2089 Arg counts are now ptrdiff_t, not size_t.
2090 All variadic functions and their callers changed accordingly.
2091 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2092 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2093 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2094 * callint.c (Fcall_interactively): Check arg count for overflow,
2095 to avoid potential buffer overrun. Use signed char, not 'int',
2096 for 'varies' array, so that we needn't bother to check its size
2097 calculation for overflow.
2098 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2099 * eval.c (apply_lambda):
2100 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2101 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2102 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2103
2104 * callint.c (Fcall_interactively): Don't use index var as event count.
2105
2106 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2107 * mem-limits.h (SIZE): Remove; no longer used.
2108
2109 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2110
2111 Remove unnecessary casts.
2112 * xterm.c (x_term_init):
2113 * xfns.c (x_set_border_pixel):
2114 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2115 These aren't needed now that we assume ANSI C.
2116
2117 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2118 It's more likely to cause problems (due to unsigned overflow)
2119 than to cure them.
2120
2121 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2122
2123 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2124
2125 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2126
2127 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2128
2129 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2130
2131 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2132
2133 GLYPH_CODE_FACE returns EMACS_INT, not int.
2134 * dispextern.h (merge_faces):
2135 * xfaces.c (merge_faces):
2136 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2137 Don't assume EMACS_INT fits in int.
2138
2139 * character.h (CHAR_VALID_P): Remove unused parameter.
2140 * fontset.c, lisp.h, xdisp.c: All uses changed.
2141
2142 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2143
2144 * fns.c (concat): Minor tuning based on overflow analysis.
2145 This doesn't fix any bugs. Use int to hold character, instead
2146 of constantly refetching from Emacs object. Use XFASTINT, not
2147 XINT, for value known to be a character. Don't bother comparing
2148 a single byte to 0400, as it's always less.
2149
2150 * floatfns.c (Fexpt):
2151 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2152
2153 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2154 for characters.
2155
2156 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2157
2158 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2159 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2160 incorrectly succeed when S was a string, because 4294967386 was
2161 truncated before it was used.
2162
2163 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2164 Otherwise, an out-of-range integer could cause undefined behavior
2165 on a 64-bit host.
2166
2167 * composite.c: Use int, not EMACS_INT, for characters.
2168 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2169 EMACS_INT, for values that are known to be in character range.
2170 This doesn't fix any bugs but is the usual style inside Emacs and
2171 may generate better code on 32-bit machines.
2172
2173 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2174 This is for reasons similar to the recent CHAR_STRING fix.
2175 * charset.c (Fencode_char): Check that character arg is actually
2176 a character. Pass an int to ENCODE_CHAR.
2177 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2178 wider than 'int', as a compile-time check to prevent future regressions
2179 in this area.
2180
2181 * character.c (char_string): Remove unnecessary casts.
2182
2183 Make sure a 64-bit char is never passed to CHAR_STRING.
2184 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2185 by silently ignoring the top 32 bits, allowing some values
2186 that were far too large to be valid characters.
2187 * character.h: Include <verify.h>.
2188 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2189 arguments are no wider than unsigned, as a compile-time check
2190 to prevent future regressions in this area.
2191 * data.c (Faset):
2192 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2193 (Fsubst_char_in_region):
2194 * fns.c (concat):
2195 * xdisp.c (decode_mode_spec_coding):
2196 Adjust to CHAR_STRING's new requirement.
2197 * editfns.c (Finsert_char, Fsubst_char_in_region):
2198 * fns.c (concat): Check that character args are actually
2199 characters. Without this test, these functions did the wrong
2200 thing with wildly out-of-range values on 64-bit hosts.
2201
2202 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2203 These casts should not be needed on 32-bit hosts, either.
2204 * keyboard.c (read_char):
2205 * lread.c (Fload): Remove casts to unsigned.
2206
2207 * lisp.h (UNSIGNED_CMP): New macro.
2208 This fixes comparison bugs on 64-bit hosts.
2209 (ASCII_CHAR_P): Use it.
2210 * casefiddle.c (casify_object):
2211 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2212 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2213 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2214 * dispextern.h (FACE_FROM_ID):
2215 * keyboard.c (read_char): Use UNSIGNED_CMP.
2216
2217 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2218 not to EMACS_INT, to avoid GCC warning.
2219
2220 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2221
2222 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2223 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2224 isn't needed on 32-bit machines.
2225
2226 * buffer.c (Fgenerate_new_buffer_name):
2227 Use EMACS_INT for count, not int.
2228 (advance_to_char_boundary): Return EMACS_INT, not int.
2229
2230 * data.c (Qcompiled_function): Now static.
2231
2232 * window.c (window_body_lines): Now static.
2233
2234 * image.c (gif_load): Rename local to avoid shadowing.
2235
2236 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2237 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2238 * alloc.c (make_save_value): Integer argument is now of type
2239 ptrdiff_t, not int.
2240 (mark_object): Use ptrdiff_t, not int.
2241 * lisp.h (pD): New macro.
2242 * print.c (print_object): Use it.
2243
2244 * alloc.c: Use EMACS_INT, not int, to count objects.
2245 (total_conses, total_markers, total_symbols, total_vector_size)
2246 (total_free_conses, total_free_markers, total_free_symbols)
2247 (total_free_floats, total_floats, total_free_intervals)
2248 (total_intervals, total_strings, total_free_strings):
2249 Now EMACS_INT, not int. All uses changed.
2250 (Fgarbage_collect): Compute overall total using a double, so that
2251 integer overflow is less likely to be a problem. Check for overflow
2252 when converting back to an integer.
2253 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2254 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2255 These were 'int' variables that could overflow on 64-bit hosts;
2256 they were never used, so remove them instead of repairing them.
2257 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2258 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2259 Previously, this ceilinged at INT_MAX, but that doesn't work on
2260 64-bit machines.
2261 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2262
2263 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2264 (allocate_vectorlike): Check for ptrdiff_t overflow.
2265 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2266 when a (possibly-narrower) signed value would do just as well.
2267 We prefer using signed arithmetic, to avoid comparison confusion.
2268
2269 * alloc.c: Catch some string size overflows that we were missing.
2270 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2271 for convenience in STRING_BYTES_MAX.
2272 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2273 The definition here is exact; the one in lisp.h was approximate.
2274 (allocate_string_data): Check for string overflow. This catches
2275 some instances we weren't catching before. Also, it catches
2276 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2277 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2278 and ptrdiff_t and EMACS_INT are both 64 bits.
2279
2280 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2281 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2282 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2283
2284 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2285
2286 * alloc.c (Fmake_string): Check for out-of-range init.
2287
2288 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2289
2290 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2291
2292 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2293
2294 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2295 xg_get_default_scrollbar_width.
2296
2297 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2298 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2299 (style_changed_cb): Call update_theme_scrollbar_width and call
2300 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2301 all frames (Bug#8505).
2302 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2303 Call gtk_window_set_resizable if HAVE_GTK3.
2304 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2305 and height if HAVE_GTK3 (Bug#8505).
2306 (scroll_bar_width_for_theme): New variable.
2307 (update_theme_scrollbar_width): New function.
2308 (xg_get_default_scrollbar_width): Move code to
2309 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2310 (xg_initialize): Call update_theme_scrollbar_width.
2311
2312 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2313
2314 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2315
2316 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2317
2318 * frame.c (make_frame): Call other_buffer_safely instead of
2319 other_buffer.
2320
2321 * window.c (temp_output_buffer_show): Call display_buffer with
2322 second argument Vtemp_buffer_show_specifiers and reset latter
2323 immediately after the call.
2324 (Vtemp_buffer_show_specifiers): New variable.
2325 (auto_window_vscroll_p, next_screen_context_lines)
2326 (Vscroll_preserve_screen_position): Remove leading asterisks from
2327 doc-strings.
2328
2329 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 Fix minor problems found by GCC 4.6.0 static checking.
2332 * buffer.c (Qclone_number): Remove for now, as it's unused.
2333 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2334 (record_buffer): Remove unused local.
2335 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2336 (set_frame_buffer_list): Remove; unused.
2337 * frame.h (other_visible_frames): Remove decl.
2338 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2339 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2340 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2341 if HAVE_GPM.
2342 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2343 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2344 Define only if HAVE_GPM.
2345 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2346 (update_hints_inhibit): Remove; never set. All uses removed.
2347 * widgetprv.h (emacsFrameClassRec): Remove decl.
2348 * window.c (delete_deletable_window): Now returns void, since it
2349 wasn't returning anything.
2350 (compare_window_configurations): Remove unused locals.
2351 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2352 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2353 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2354 the same widths as pointers. This follows up on the 2011-05-06 patch.
2355 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2356 * xterm.h: Likewise.
2357 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2358
2359 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2360
2361 * makefile.w32-in: Update dependencies.
2362 (LISP_H): Add lib/intprops.h.
2363
2364 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2365
2366 * image.c (gif_load): Add animation frame delay to the metadata.
2367 (syms_of_image): Use DEFSYM. New symbol `delay'.
2368
2369 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2370
2371 * window.c (delete_deletable_window): Re-add.
2372 (Fset_window_configuration): Rewrite to handle dead buffers and
2373 consequently deletable windows.
2374 (window_tree, Fwindow_tree): Remove. Supply functionality in
2375 window.el.
2376 (compare_window_configurations): Simplify code.
2377
2378 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2379
2380 * image.c (imagemagick_load_image): Fix type mismatch.
2381 (Fimagemagick_types): Likewise.
2382
2383 * window.h (replace_buffer_in_windows): Declare.
2384
2385 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2386
2387 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2388 Qclone_number. Remove external declaration of Qdelete_window.
2389 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2390 code.
2391 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2392 Run Qbuffer_list_update_hook if allowed.
2393 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2394 buffer list implementation.
2395 (other_buffer_safely): New function.
2396 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2397 calls to replace_buffer_in_windows and
2398 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2399 if allowed.
2400 (record_buffer): Inhibit quitting and rewrite using quittable
2401 functions. Run Qbuffer_list_update_hook if allowed.
2402 (Frecord_buffer, Funrecord_buffer): New functions.
2403 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2404 Move switch-to-buffer to window.el.
2405 (bury-buffer): Move to window.el.
2406 (Vbuffer_list_update_hook): New variable.
2407
2408 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2409 section.
2410
2411 * window.h (resize_frame_windows): Move up in code.
2412 (Fwindow_frame): Remove EXFUN.
2413 (replace_buffer_in_all_windows): Remove prototype.
2414 (replace_buffer_in_windows_safely): Add prototype.
2415
2416 * window.c: Declare Qdelete_window static again. Move down
2417 declaration of select_count.
2418 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2419 (Fother_window): Move to window.el.
2420 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2421 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2422 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2423 window.el.
2424 (replace_buffer_in_windows): Implement by calling
2425 Qreplace_buffer_in_windows.
2426 (replace_buffer_in_all_windows): Remove with some functionality
2427 moved into replace_buffer_in_windows_safely.
2428 (replace_buffer_in_windows_safely): New function.
2429 (select_window_norecord, select_frame_norecord): Move in front
2430 of run_window_configuration_change_hook. Remove now obsolete
2431 declarations.
2432 (Fset_window_buffer): Rewrite doc-string.
2433 Call Qrecord_window_buffer.
2434 (keys_of_window): Move binding for other-window to window.el.
2435
2436 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2437
2438 * dispextern.h (struct image): Replace data member, whose int_val
2439 and ptr_val fields were not used by anything, with a single
2440 lisp_val object.
2441
2442 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2443 (gif_clear_image, gif_load, imagemagick_load_image)
2444 (gs_clear_image, gs_load): Callers changed.
2445
2446 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2447
2448 * buffer.h: Include <time.h>, for time_t.
2449 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2450
2451 Fix minor problems found by static checking.
2452
2453 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2454
2455 Make identifiers static if they are not used in other modules.
2456 * data.c (Qcompiled_function, Qframe, Qvector):
2457 * image.c (QimageMagick, Qsvg):
2458 * minibuf.c (Qmetadata):
2459 * window.c (resize_window_check, resize_root_window): Now static.
2460 * window.h (resize_window_check, resize_root_window): Remove decls.
2461
2462 * window.c (window_deletion_count, delete_deletable_window):
2463 Remove; unused.
2464 (window_body_lines): Now static.
2465 (Fdelete_other_windows_internal): Mark vars as initialized.
2466 Make sure 'resize_failed' is initialized.
2467 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2468 (resize_window_apply): Remove unused local.
2469 * window.h (delete_deletable_window): Remove decl.
2470
2471 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2472 (imagemagick_load_image): Fix pointer signedness problem by changing
2473 last arg from unsigned char * to char *. All uses changed.
2474 Also, fix a local for similar reasons.
2475 Remove unused locals. Remove locals to avoid shadowing.
2476 (fn_rsvg_handle_free): Remove; unused.
2477 (svg_load, svg_load_image): Fix pointer signedness problem.
2478 (imagemagick_load_image): Don't use garbage pointer image_wand.
2479
2480 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2481
2482 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2483
2484 * image.c (gif_load): Fix omitted cast error introduced by
2485 2011-06-06 change.
2486
2487 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2488
2489 * window.h (resize_proportionally, orig_total_lines)
2490 (orig_top_line): Remove from window structure.
2491 (set_window_height, set_window_width, change_window_heights)
2492 (Fdelete_window): Remove prototypes.
2493 (resize_frame_windows): Remove duplicate declaration.
2494
2495 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2496
2497 * window.h (resize_frame_windows, resize_window_check)
2498 (delete_deletable_window, resize_root_window)
2499 (resize_frame_windows): Declare prototypes.
2500
2501 * window.c (resize_window_apply): Make definition be "static" to
2502 match the prototype.
2503
2504 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2505
2506 * window.c: Remove declarations of Qwindow_size_fixed,
2507 window_min_size_1, window_min_size_2, window_min_size,
2508 size_window, window_fixed_size_p, enlarge_window, delete_window.
2509 Remove static from declaration of Qdelete_window, it's
2510 temporarily needed by Fbury_buffer.
2511 (replace_window): Don't assign orig_top_line and
2512 orig_total_lines.
2513 (Fdelete_window, delete_window): Remove. Window deletion is
2514 handled by window.el.
2515 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2516 Replace Fdelete_window calls with calls to Qdelete_window.
2517 (Fdelete_other_windows): Remove. Deleting other windows is
2518 handled by window.el.
2519 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2520 handled in window.el.
2521 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2522 Window minimum sizes are handled in window.el.
2523 (shrink_windows, size_window, set_window_height)
2524 (set_window_width, change_window_heights, window_height)
2525 (window_width, CURBEG, CURSIZE, enlarge_window)
2526 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2527 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2528 handled in window.el.
2529 (make_dummy_parent): Rename to make_parent_window and give it a
2530 second argument horflag.
2531 (make_window): Don't set resize_proportionally any more.
2532 (Fsplit_window): Remove. Windows are split in window.el.
2533 (save_restore_action, save_restore_orig_size)
2534 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2535 Resize mini windows in window.el.
2536 (grow_mini_window, shrink_mini_window): Implement by calling
2537 Qresize_root_window_vertically, resize_window_check and
2538 resize_window_apply.
2539 (saved_window, Fset_window_configuration, save_window_save):
2540 Do not handle orig_top_line, orig_total_lines, and
2541 resize_proportionally.
2542 (window_min_height, window_min_width): Move to window.el.
2543 (keys_of_window): Move bindings for delete-other-windows,
2544 split-window, delete-window and enlarge-window to window.el.
2545
2546 * buffer.c: Temporarily extern Qdelete_window.
2547 (Fbury_buffer): Temporarily call Qdelete_window instead of
2548 Fdelete_window (Fbury_buffer will move to window.el soon).
2549
2550 * frame.c (set_menu_bar_lines_1): Remove code handling
2551 orig_top_line and orig_total_lines.
2552
2553 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2554 set_window_height but set heights directly.
2555 (change_frame_size_1): Use resize_frame_windows.
2556
2557 * xdisp.c (init_xdisp): Don't use set_window_height but set
2558 heights directly.
2559
2560 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2561 Use resize_frame_windows instead of change_window_heights and run
2562 run_window_configuration_change_hook.
2563
2564 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2565 instead of change_window_heights and run
2566 run_window_configuration_change_hook.
2567
2568 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2569
2570 * window.c (replace_window): Rename second argument REPLACEMENT to
2571 NEW. New third argument SETFLAG. Rewrite.
2572 (delete_window, make_dummy_parent): Call replace_window with
2573 third argument 1.
2574 (window_list_1): Move down in code.
2575 (run_window_configuration_change_hook): Move set_buffer part
2576 before select_frame_norecord part in order to unwind correctly.
2577 Rename count1 to count.
2578 (recombine_windows, delete_deletable_window, resize_root_window)
2579 (Fdelete_other_windows_internal)
2580 (Frun_window_configuration_change_hook, make_parent_window)
2581 (resize_window_check, resize_window_apply, Fresize_window_apply)
2582 (resize_frame_windows, Fsplit_window_internal)
2583 (Fdelete_window_internal, Fresize_mini_window_internal):
2584 New functions.
2585 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2586
2587 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2588
2589 * window.h (window): Add some new members to window structure -
2590 normal_lines, normal_cols, new_total, new_normal, clone_number,
2591 splits, nest, prev_buffers, next_buffers.
2592 (WINDOW_TOTAL_SIZE): Move here from window.c.
2593 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2594
2595 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2596 Remove.
2597 (make_dummy_parent): Set new members of windows structure.
2598 (make_window): Move down in code. Handle new members of window
2599 structure.
2600 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2601 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2602 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2603 (Fset_window_prev_buffers, Fwindow_next_buffers)
2604 (Fset_window_next_buffers, Fset_window_clone_number):
2605 New functions.
2606 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2607 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2608 Doc-string fixes.
2609 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2610 Argument WINDOW can be now internal window too.
2611 (Fwindow_use_time): Move up in code.
2612 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2613 Rewrite doc-string.
2614 (Fset_window_configuration, saved_window)
2615 (Fcurrent_window_configuration, save_window_save): Handle new
2616 members of window structure.
2617 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2618 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2619 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2620 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2621 Qget_mru_window, Qresize_root_window,
2622 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2623 Qauto_buffer_name; staticpro them.
2624
2625 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2626
2627 * window.c (Fwindow_total_size, Fwindow_left_column)
2628 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2629 (Fwindow_list_1): New functions.
2630 (window_box_text_cols): Replace with window_body_cols.
2631 (Fwindow_width, Fscroll_left, Fscroll_right):
2632 Use window_body_cols instead of window_box_text_cols.
2633 (delete_window, Fset_window_configuration):
2634 Call delete_all_subwindows with window as argument.
2635 (delete_all_subwindows): Take a window as argument and not a
2636 structure. Rewrite.
2637 (window_loop): Remove handling of GET_LRU_WINDOW and
2638 GET_LARGEST_WINDOW.
2639 (Fget_lru_window, Fget_largest_window): Move to window.el.
2640
2641 * window.h: Extern window_body_cols instead of
2642 window_box_text_cols. delete_all_subwindows now takes a
2643 Lisp_Object as argument.
2644
2645 * indent.c (compute_motion, Fcompute_motion):
2646 Use window_body_cols instead of window_box_text_cols.
2647
2648 * frame.c (delete_frame): Call delete_all_subwindows with root
2649 window as argument.
2650
2651 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2652
2653 * fns.c (Fputhash): Document return value.
2654
2655 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2656
2657 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2658
2659 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 Cons<->int and similar integer overflow fixes (Bug#8794).
2662
2663 Check for overflow when converting integer to cons and back.
2664 * charset.c (Fdefine_charset_internal, Fdecode_char):
2665 Use cons_to_unsigned to catch overflow.
2666 (Fencode_char): Use INTEGER_TO_CONS.
2667 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2668 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2669 * data.c (long_to_cons, cons_to_long): Remove.
2670 (cons_to_unsigned, cons_to_signed): New functions.
2671 These signal an error for invalid or out-of-range values.
2672 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2673 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2674 * font.c (Ffont_variation_glyphs):
2675 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2676 * lisp.h: Include <intprops.h>.
2677 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2678 (cons_to_signed, cons_to_unsigned): New decls.
2679 (long_to_cons, cons_to_long): Remove decls.
2680 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2681 (Fprimitive_undo): Use CONS_TO_INTEGER.
2682 * xfns.c (Fx_window_property): Likewise.
2683 * xselect.c: Include <limits.h>.
2684 (x_own_selection, selection_data_to_lisp_data):
2685 Use INTEGER_TO_CONS.
2686 (x_handle_selection_request, x_handle_selection_clear)
2687 (x_get_foreign_selection, Fx_disown_selection_internal)
2688 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2689 (lisp_data_to_selection_data): Use cons_to_unsigned.
2690 (x_fill_property_data): Use cons_to_signed.
2691 Report values out of range.
2692
2693 Check for buffer and string overflow more precisely.
2694 * buffer.h (BUF_BYTES_MAX): New macro.
2695 * lisp.h (STRING_BYTES_MAX): New macro.
2696 * alloc.c (Fmake_string):
2697 * character.c (string_escape_byte8):
2698 * coding.c (coding_alloc_by_realloc):
2699 * doprnt.c (doprnt):
2700 * editfns.c (Fformat):
2701 * eval.c (verror):
2702 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2703 since they may not be the same number.
2704 * editfns.c (Finsert_char):
2705 * fileio.c (Finsert_file_contents):
2706 Likewise for BUF_BYTES_MAX.
2707
2708 * image.c: Use ptrdiff_t, not int, for sizes.
2709 (slurp_file): Switch from int to ptrdiff_t.
2710 All uses changed.
2711 (slurp_file): Check that file size fits in both size_t (for
2712 malloc) and ptrdiff_t (for sanity and safety).
2713
2714 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2715 if b->modtime has its maximal value.
2716
2717 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2718
2719 Don't assume time_t can fit into int.
2720 * buffer.h (struct buffer.modtime): Now time_t, not int.
2721 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2722 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2723
2724 Minor fixes for signed vs unsigned integers.
2725 * character.h (MAYBE_UNIFY_CHAR):
2726 * charset.c (maybe_unify_char):
2727 * keyboard.c (read_char, reorder_modifiers):
2728 XINT -> XFASTINT, since the integer must be nonnegative.
2729 * ftfont.c (ftfont_spec_pattern):
2730 * keymap.c (access_keymap, silly_event_symbol_error):
2731 XUINT -> XFASTINT, since the integer must be nonnegative.
2732 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2733 since it makes no difference and we prefer signed.
2734 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2735 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2736 nonnegative.
2737
2738 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2739
2740 * window.h (Fwindow_frame): Declare.
2741
2742 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2743
2744 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2745 (SPARE_MEMORY): Always define.
2746 (LARGE_REQUEST): Remove.
2747 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2748
2749 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2750
2751 * lisp.h: Move EXFUNS for Fframe_root_window,
2752 Fframe_first_window and Fset_frame_selected_window to window.h.
2753
2754 * window.h: Move EXFUNS for Fframe_root_window,
2755 Fframe_first_window and Fset_frame_selected_window here from
2756 lisp.h.
2757
2758 * frame.c (Fwindow_frame, Fframe_first_window)
2759 (Fframe_root_window, Fframe_selected_window)
2760 (Fset_frame_selected_window): Move to window.c.
2761 (Factive_minibuffer_window): Move to minibuf.c.
2762 (Fother_visible_frames_p): New function.
2763
2764 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2765
2766 * window.c (decode_window, decode_any_window): Move up in code.
2767 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2768 (inhibit_frame_unsplittable): Remove unused variable.
2769 (Fwindow_buffer): Move up and rewrite doc-string.
2770 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2771 (Fwindow_prev): New functions.
2772 (Fwindow_frame): Move here from frame.c. Accept any window as
2773 argument.
2774 (Fframe_root_window, Fframe_first_window)
2775 (Fframe_selected_window): Move here from frame.c. Accept frame
2776 or arbitrary window as argument. Update doc-strings.
2777 (Fminibuffer_window): Move up in code.
2778 (Fwindow_minibuffer_p): Move up in code and simplify.
2779 (Fset_frame_selected_window): Move here from frame.c.
2780 Marginal rewrite.
2781 (Fselected_window, select_window, Fselect_window): Move up in
2782 code. Minor doc-string fixes.
2783
2784 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2785
2786 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2787 Do not assume that spare memory exists; that assumption is valid
2788 only if SYSTEM_MALLOC.
2789 (LARGE_REQUEST): New macro, so that the issue of large requests
2790 is separated from the issue of spare memory.
2791
2792 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2793
2794 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2795 format. (Bug#8806)
2796
2797 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2798
2799 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2800 before statements.
2801
2802 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2803
2804 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2805
2806 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2807
2808 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2809 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2810
2811 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2812
2813 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2814
2815 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2816
2817 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2818 (x_clipboard_manager_save): Add return value.
2819 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2820 New error handlers.
2821 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2822 Obey Vx_select_enable_clipboard_manager. Catch errors in
2823 x_clipboard_manager_save (Bug#8779).
2824 (Vx_select_enable_clipboard_manager): New variable.
2825 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2826
2827 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2828
2829 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2830
2831 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2832
2833 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2834 in the current matrix if keep_current_p is non-zero.
2835
2836 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2837
2838 * bidi.c (bidi_level_of_next_char): Fix last change.
2839
2840 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2841
2842 Support bidi reordering of text covered by display properties.
2843
2844 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2845 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2846 (bidi_cache_search, bidi_cache_iterator_state)
2847 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2848 (bidi_level_of_next_char, bidi_move_to_visually_next):
2849 Support character positions inside a run of characters covered by a
2850 display string.
2851 (bidi_paragraph_init, bidi_resolve_explicit_1)
2852 (bidi_level_of_next_char): Call bidi_fetch_char and
2853 bidi_fetch_char_advance instead of FETCH_CHAR and
2854 FETCH_CHAR_ADVANCE.
2855 (bidi_init_it): Initialize new members.
2856 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2857 definitions.
2858 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2859 instead of using explicit *_CHAR codes.
2860 (bidi_resolve_explicit, bidi_resolve_weak):
2861 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2862 bidirectional text is supported only in multibyte buffers.
2863 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2864 it to initialize the frame_window_p member of struct bidi_it.
2865 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2866 (bidi_resolve_explicit, bidi_resolve_weak)
2867 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2868 bidi_it->nchars is non-positive.
2869 (bidi_level_of_next_char): Don't try to lookup the cache for the
2870 next/previous character if nothing is cached there yet, or if we
2871 were just reseat()'ed to a new position.
2872
2873 * xdisp.c (set_cursor_from_row): Set start and stop points
2874 according to the row's direction when priming the loop that looks
2875 for the glyph on which to display cursor.
2876 (single_display_spec_intangible_p): Function deleted.
2877 (display_prop_intangible_p): Reimplement to call
2878 handle_display_spec instead of single_display_spec_intangible_p.
2879 Accept 3 additional arguments needed by handle_display_spec.
2880 This fixes incorrect cursor motion across display property with complex
2881 values: lists, `(when COND...)' forms, etc.
2882 (single_display_spec_string_p): Support property values that are
2883 lists with the argument STRING its top-level element.
2884 (display_prop_string_p): Fix the condition for processing a
2885 property that is a list to be consistent with handle_display_spec.
2886 (handle_display_spec): New function, refactored from the
2887 last portion of handle_display_prop.
2888 (compute_display_string_pos): Accept additional argument
2889 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2890 value of a `display' property is a "replacing spec".
2891 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2892 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2893 the display property, but just return a value indicating whether
2894 the display property will replace the characters it covers.
2895 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2896 frame_window_p members of struct bidi_it.
2897 (compute_display_string_pos, compute_display_string_end):
2898 New functions.
2899 (push_it): Accept second argument POSITION, where pop_it should
2900 jump to continue iteration.
2901 (reseat_1): Initialize bidi_it.disp_pos.
2902
2903 * keyboard.c (adjust_point_for_property): Adjust the call to
2904 display_prop_intangible_p to its new signature.
2905
2906 * dispextern.h (struct bidi_it): New member frame_window_p.
2907 (bidi_init_it): Update prototypes.
2908 (display_prop_intangible_p): Update prototype.
2909 (compute_display_string_pos, compute_display_string_end):
2910 Declare prototypes.
2911 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2912 EMACS_INT.
2913
2914 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2915
2916 Malloc failure behavior now depends on size of allocation.
2917 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2918 * lisp.h: Change signatures accordingly.
2919 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2920 All callers changed. (Bug#8762)
2921
2922 * gnutls.c: Use Emacs's memory allocators.
2923 Without this change, the gnutls library would invoke malloc etc.
2924 directly, which causes problems on non-SYNC_INPUT hosts, and which
2925 runs afoul of improving memory_full behavior. (Bug#8761)
2926 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2927 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2928 xfree instead of the default malloc, realloc, free.
2929 (Fgnutls_boot): No need to check for memory allocation failure,
2930 since xmalloc does that for us.
2931
2932 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2933 * category.c (hash_get_category_set):
2934 * ccl.c (ccl_driver):
2935 * charset.c (Fdefine_charset_internal):
2936 * charset.h (struct charset.hash_index):
2937 * composite.c (get_composition_id, gstring_lookup_cache)
2938 (composition_gstring_put_cache):
2939 * composite.h (struct composition.hash_index):
2940 * dispextern.h (struct image.hash):
2941 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2942 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2943 (hashfn_equal, hashfn_user_defined, make_hash_table)
2944 (maybe_resize_hash_table, hash_lookup, hash_put)
2945 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2946 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2947 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2948 * image.c (make_image, search_image_cache, lookup_image)
2949 (xpm_put_color_table_h):
2950 * lisp.h (struct Lisp_Hash_Table):
2951 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2952 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2953 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2954 * alloc.c (allocate_vectorlike):
2955 Check for overflow in vector size calculations.
2956 * ccl.c (ccl_driver):
2957 Check for overflow when converting EMACS_INT to int.
2958 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2959 need to be updated by these changes.
2960 * fns.c (make_hash_table, maybe_resize_hash_table):
2961 Check for integer overflow with large hash tables.
2962 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2963 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2964 (SXHASH_REDUCE): New macro.
2965 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2966 Use it instead of discarding useful hash info with large hash values.
2967 (sxhash_float): New function.
2968 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2969 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2970 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2971 Rewrite to use FIXNUM_BITS, as this simplifies things.
2972 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2973 Adjust signatures to match updated version of code.
2974 (consing_since_gc): Now EMACS_INT, since a single hash table can
2975 use more than INT_MAX bytes.
2976
2977 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2978
2979 Make it possible to build with GCC-4.6+ -O2 -flto.
2980
2981 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2982
2983 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2984
2985 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2986 Call minibuffer-inactive-mode.
2987
2988 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2989
2990 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2991 Update dependencies.
2992
2993 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2994
2995 * data.c (init_data): Remove code for UTS, this system is not
2996 supported anymore.
2997
2998 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2999
3000 Don't force ./temacs to start in terminal mode.
3001
3002 * frame.c (make_initial_frame): Initialize faces in all cases, not
3003 only when CANNOT_DUMP is defined.
3004 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3005
3006 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3007
3008 * dispnew.c (add_window_display_history): Use const for the string
3009 pointer. Remove declaration, not needed.
3010
3011 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3012
3013 Use 'inline', not 'INLINE'.
3014 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3015 * alloc.c, fontset.c (INLINE): Remove.
3016 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3017 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3018 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3019 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3020 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3021
3022 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3023
3024 Make it possible to run ./temacs.
3025
3026 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3027 syms_of_callproc does the same thing. Remove test for
3028 "initialized", do it in the caller.
3029 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3030
3031 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3032
3033 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3034 (read_minibuf): Use get_minibuffer.
3035 (syms_of_minibuf): Use DEFSYM.
3036 (Qmetadata): New var.
3037 * data.c (Qbuffer): Don't make it static.
3038 (syms_of_data): Use DEFSYM.
3039
3040 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3041
3042 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3043 (CCL_CODE_MIN): New macro.
3044
3045 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3046
3047 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3048
3049 * eval.c (Qdebug): Now static.
3050 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3051 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3052 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3053
3054 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3055
3056 * image.c: Various fixes to ImageMagick code comments.
3057 (Fimagemagick_types): Doc fix.
3058
3059 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3060
3061 Minor fixes prompted by GCC 4.6.0 warnings.
3062
3063 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3064
3065 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3066 (x_clipboard_manager_save_all): Move extern decl to ...
3067 * xterm.h: ... here, so that it can be checked for consistency.
3068
3069 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3070
3071 * xselect.c (x_clipboard_manager_save_frame)
3072 (x_clipboard_manager_save_all): New functions.
3073 (Fx_clipboard_manager_save): Lisp function deleted.
3074
3075 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3076 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3077
3078 * xterm.h: Update prototype.
3079
3080 2011-05-28 William Xu <william.xwl@gmail.com>
3081
3082 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3083 exiting (Bug#8239).
3084
3085 2011-05-28 Jim Meyering <meyering@redhat.com>
3086
3087 Avoid a sign-extension bug in crypto_hash_function.
3088 * fns.c (to_uchar): Define.
3089 (crypto_hash_function): Use it to convert some newly-signed
3090 variables to unsigned, to avoid sign-extension bugs. For example,
3091 without this change, (md5 "truc") would evaluate to
3092 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3093 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3094 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3095
3096 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3097
3098 Integer overflow fixes.
3099
3100 * dbusbind.c: Serial number integer overflow fixes.
3101 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3102 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3103 to hold a serial number that is too large for a fixnum.
3104 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3105 Check for serial numbers out of range. Decode any serial number
3106 that was so large that it became a float. (Bug#8722)
3107
3108 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3109 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3110 Use XFASTINT rather than XUINT when numbers are nonnegative.
3111 (xd_append_arg, Fdbus_method_return_internal):
3112 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3113 arguments, check that Lisp number is nonnegative, rather than
3114 silently wrapping negative numbers around. (Bug#8722)
3115 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3116 (Bug#8722)
3117
3118 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3119
3120 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3121
3122 ccl: add integer overflow checks
3123 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3124 (IN_INT_RANGE): New macros.
3125 (ccl_driver): Use them to check for integer overflow when
3126 decoding a CCL program. Many of the new checks are whether XINT (x)
3127 fits in int; it doesn't always, on 64-bit hosts. The new version
3128 doesn't catch all possible integer overflows, but it's an
3129 improvement. (Bug#8719)
3130
3131 * alloc.c (make_event_array): Use XINT, not XUINT.
3132 There's no need for unsigned here.
3133
3134 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3135 This follows up to the 2011-05-06 change that substituted uintptr_t
3136 for EMACS_INT. This case wasn't caught back then.
3137
3138 Rework Fformat to avoid integer overflow issues.
3139 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3140 now (part of C89). Include <verify.h>.
3141 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3142 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3143 (Fformat): Avoid the prepass trying to compute sizes; it was only
3144 approximate and thus did not catch overflow reliably. Instead, walk
3145 through the format just once, formatting and computing sizes as we go,
3146 checking for integer overflow at every step, and allocating a larger
3147 buffer as needed. Keep track separately whether the format is
3148 multibyte. Keep only the most-recently calculated precision, rather
3149 than them all. Record whether each argument has been converted to
3150 string. Use EMACS_INT, not int, for byte and char and arg counts.
3151 Support field widths and precisions larger than INT_MAX. Avoid
3152 sprintf's undefined behavior with conversion specifications such as %#d
3153 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3154 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3155 formatting out-of-range floating point numbers with int
3156 formats. (Bug#8668)
3157
3158 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3159
3160 * data.c: Avoid integer truncation in expressions involving floats.
3161 * data.c: Include <intprops.h>.
3162 (arith_driver): When there's an integer overflow in an expression
3163 involving floating point, convert the integers to floating point
3164 so that the resulting value does not suffer from catastrophic
3165 integer truncation. For example, on a 64-bit host (* 4
3166 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3167 Do not rely on undefined behavior after integer overflow.
3168
3169 merge count_size_as_multibyte, parse_str_to_multibyte
3170 * character.c, character.h (count_size_as_multibyte):
3171 Rename from parse_str_to_multibyte; all uses changed.
3172 Check for integer overflow.
3173 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3174 since it's now a duplicate of the other. This is more of
3175 a character than a buffer op, so better that it's in character.c.
3176 * fns.c, print.c: Adjust to above changes.
3177
3178 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3179
3180 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3181
3182 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3183
3184 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3185 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3186 (x_clipboard_manager_save): Now static.
3187 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3188
3189 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3190 (crypto_hash_function): Now static.
3191 Fix pointer signedness problems. Avoid unnecessary initializations.
3192
3193 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3194
3195 * termhooks.h (Vselection_alist): Make it terminal-local.
3196
3197 * terminal.c (create_terminal): Initialize it.
3198
3199 * xselect.c: Support for clipboard managers.
3200 (Vselection_alist): Move to termhooks.h as terminal-local var.
3201 (LOCAL_SELECTION): New macro.
3202 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3203 (symbol_to_x_atom): Remove gratuitous arg.
3204 (x_handle_selection_request, lisp_data_to_selection_data)
3205 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3206 (x_own_selection, x_get_local_selection, x_convert_selection):
3207 New arg, specifying work frame. Use terminal-local Vselection_alist.
3208 (some_frame_on_display): Delete unused function.
3209 (Fx_own_selection_internal, Fx_get_selection_internal)
3210 (Fx_disown_selection_internal, Fx_selection_owner_p)
3211 (Fx_selection_exists_p): New optional frame arg.
3212 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3213 (x_handle_selection_clear): Don't treat other terminals with the
3214 same keyboard specially. Use the terminal-local Vselection_alist.
3215 (x_clear_frame_selections): Use Frun_hook_with_args.
3216
3217 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3218
3219 * xterm.h: Add support for those atoms.
3220
3221 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3222
3223 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3224 (converted_selections, conversion_fail_tag): New global variables.
3225 (x_selection_request_lisp_error): Free the above.
3226 (x_get_local_selection): Remove unnecessary code.
3227 (x_reply_selection_request): Args changed; handle arbitrary array
3228 of converted selections stored in converted_selections.
3229 Separate the XChangeProperty and SelectionNotify steps.
3230 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3231 (x_convert_selection): New function.
3232 (x_handle_selection_event): Simplify.
3233 (x_get_foreign_selection): Don't ignore incoming requests while
3234 waiting for an answer; this will fail when we implement
3235 SAVE_TARGETS, and seems unnecessary anyway.
3236 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3237 (Vx_sent_selection_functions): Doc fix.
3238
3239 2011-05-26 Leo Liu <sdl.web@gmail.com>
3240
3241 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3242
3243 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3244
3245 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3246
3247 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3248 for fringe update if it has periodic bitmap.
3249 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3250 and fringe_bitmap_periodic_p.
3251
3252 * fringe.c (get_fringe_bitmap_data): New function.
3253 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3254 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3255 row. Mark glyph row for fringe update if periodicity changed.
3256
3257 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3258 for fringe update unless it has periodic bitmap.
3259
3260 2011-05-25 Kenichi Handa <handa@m17n.org>
3261
3262 * xdisp.c (get_next_display_element): Set correct it->face_id for
3263 a static composition.
3264
3265 2011-05-24 Leo Liu <sdl.web@gmail.com>
3266
3267 * deps.mk (fns.o):
3268 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3269
3270 * fns.c (crypto_hash_function, Fsha1): New function.
3271 (Fmd5): Use crypto_hash_function.
3272 (syms_of_fns): Add Ssha1.
3273
3274 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3275
3276 * gnutls.c: Remove unused macros.
3277 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3278 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3279 Remove macros that are defined and never used.
3280 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3281
3282 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3283
3284 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3285 (Fx_get_selection_internal): Minor cleanup.
3286 (Fx_own_selection_internal): Rename arguments for consistency with
3287 select.el.
3288
3289 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3290
3291 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3292
3293 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3294
3295 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3296
3297 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3298
3299 * dispnew.c (scrolling_window): Don't exclude the case that the
3300 last enabled row in the desired matrix touches the bottom boundary.
3301
3302 2011-05-21 Glenn Morris <rgm@gnu.org>
3303
3304 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3305 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3306 and add some more files.
3307
3308 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3309
3310 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3311 report_file_error introduced by the change from 2011-05-07.
3312
3313 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3314
3315 * systime.h (Time): Define only if emacs is defined.
3316 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3317 where the include path doesn't have X11/X.h by default. See
3318 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3319
3320 2011-05-20 Kenichi Handa <handa@m17n.org>
3321
3322 * composite.c (find_automatic_composition): Fix previous change.
3323
3324 2011-05-20 Glenn Morris <rgm@gnu.org>
3325
3326 * lisp.mk: New file, split from Makefile.in.
3327 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3328 (shortlisp): Remove.
3329 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3330
3331 2011-05-19 Glenn Morris <rgm@gnu.org>
3332
3333 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3334 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3335 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3336 (lisp): Set the order to that of loadup.el.
3337 (shortlisp): Make it a copy of $lisp.
3338 (SOME_MACHINE_LISP): Remove.
3339 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3340 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3341
3342 2011-05-18 Kenichi Handa <handa@m17n.org>
3343
3344 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3345 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3346 (find_automatic_composition): Mostly rewrite for efficiency.
3347
3348 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3349
3350 * makefile.w32-in: Update dependencies.
3351
3352 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3353
3354 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3355 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3356
3357 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3358
3359 Fix some integer overflow issues, such as string length overflow.
3360
3361 * insdel.c (count_size_as_multibyte): Check for string overflow.
3362
3363 * character.c (lisp_string_width): Check for string overflow.
3364 Use EMACS_INT, not int, for string indexes and lengths; in
3365 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3366 the resulting string length overflows an EMACS_INT; instead,
3367 report a string overflow if no precision given. When checking for
3368 precision exhaustion, use a check that cannot possibly have
3369 integer overflow. (Bug#8675)
3370 * character.h (lisp_string_width): Adjust to new signature.
3371
3372 * alloc.c (string_overflow): New function.
3373 (Fmake_string): Use it. This doesn't change behavior, but saves
3374 a few bytes and will simplify future changes.
3375 * character.c (string_escape_byte8): Likewise.
3376 * lisp.h (string_overflow): New decl.
3377
3378 Fixups, following up to the user-interface timestamp change.
3379 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3380 for UI timestamps, instead of unsigned long.
3381 * msdos.c (mouse_get_pos): Likewise.
3382 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3383 * w32gui.h (Time): Define by including "systime.h" rather than by
3384 declaring it ourselves. (Bug#8664)
3385
3386 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3387 * image.c (clear_image_cache): Likewise.
3388
3389 * term.c (term_mouse_position): Don't assume time_t wraparound.
3390
3391 Be more systematic about user-interface timestamps.
3392 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3393 and sometimes 'EMACS_UINT', to represent these timestamps.
3394 This change causes it to use 'Time' uniformly, as that's what X uses.
3395 This makes the code easier to follow, and makes it easier to catch
3396 integer overflow bugs such as Bug#8664.
3397 * frame.c (Fmouse_position, Fmouse_pixel_position):
3398 Use Time, not unsigned long, for user-interface timestamps.
3399 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3400 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3401 * keyboard.h (last_event_timestamp): Likewise.
3402 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3403 * menu.h (xmenu_show): Likewise.
3404 * term.c (term_mouse_position): Likewise.
3405 * termhooks.h (struct input_event.timestamp): Likewise.
3406 (struct terminal.mouse_position_hook): Likewise.
3407 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3408 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3409 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3410 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3411 what it was before.
3412 * menu.h, termhooks.h: Include "systime.h", for Time.
3413
3414 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3415 Don't assume that the difference between two unsigned long values
3416 can fit into an integer. At this point, we know button_down_time
3417 <= event->timestamp, so the difference must be nonnegative, so
3418 there's no need to cast the result if double-click-time is
3419 nonnegative, as it should be; check that it's nonnegative, just in
3420 case. This bug is triggered when events are more than 2**31 ms
3421 apart (about 25 days). (Bug#8664)
3422
3423 * xselect.c (last_event_timestamp): Remove duplicate decl.
3424 (x_own_selection): Remove needless cast to unsigned long.
3425
3426 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3427 that always fit in int. Use a sentinel instead of a counter, to
3428 avoid a temp and to allay GCC's concerns about possible int overflow.
3429 * frame.h (struct frame): Use int for menu_bar_items_used
3430 instead of EMACS_INT, since it always fits in int.
3431
3432 * menu.c (grow_menu_items): Check for int overflow.
3433
3434 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3435
3436 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3437 Before, the code was not consistent. These values cannot exceed
3438 2**31 - 1 so there's no need to make them unsigned.
3439 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3440 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3441 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3442 as modifiers.
3443 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3444
3445 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3446 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3447 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3448 presumably because the widths might not match.
3449
3450 * window.c (size_window): Avoid needless test at loop start.
3451
3452 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3453
3454 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3455
3456 2011-05-12 Drew Adams <drew.adams@oracle.com>
3457
3458 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3459
3460 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3461
3462 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3463 `width' to `bar_area_x' and `bar_area_width', respectively.
3464 (x_scroll_run): Take account of fringe background extension.
3465
3466 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3467 Rename local vars `left' and `width' to `bar_area_x' and
3468 `bar_area_width', respectively.
3469 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3470 background extension.
3471
3472 2011-05-10 Jim Meyering <meyering@redhat.com>
3473
3474 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3475
3476 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3477
3478 * image.c (Finit_image_library): Return t for built-in image types,
3479 like pbm and xbm. (Bug#8640)
3480
3481 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3482
3483 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3484
3485 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3486
3487 * w32console.c (Fset_screen_color): Doc fix.
3488 (Fget_screen_color): New function.
3489 (syms_of_ntterm): Defsubr it.
3490
3491 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3492 unlink the temporary file if Fcall_process didn't create it in the
3493 first place.
3494 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3495 child process will be redirected to a file specified with `:file'.
3496 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3497 cue to call_process_cleanup not to close that handle.
3498
3499 2011-05-07 Ben Key <bkey76@gmail.com>
3500
3501 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3502 one of two shell specific rules, either bootstrap-temacs-CMD or
3503 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3504 to the previous implementation of the bootstrap-temacs rule.
3505 The bootstrap-temacs-CMD rule is similar to the previous
3506 implementation of the bootstrap-temacs rule except that it
3507 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3508 variable.
3509
3510 These changes, along with some changes to nt/configure.bat,
3511 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3512 earlier fix to add support for --cflags and --ldflags options
3513 that include quotes so that it works whether make uses cmd or
3514 sh as the shell.
3515
3516 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3517
3518 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3519 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3520 is a constant.
3521 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3522 a string. Handle both cases.
3523 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3524 (Fdbus_register_method): Use Qinvalid_function.
3525
3526 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3527
3528 * makefile.w32-in: Update dependencies.
3529 (LISP_H): Add inttypes.h and stdin.h.
3530 (PROCESS_H): Add unistd.h.
3531
3532 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3533
3534 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3535 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3536
3537 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3538
3539 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3540
3541 * term.c (vfatal): Remove stray call to va_end.
3542 It's not needed and the C Standard doesn't allow it here anyway.
3543
3544 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3545 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3546
3547 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3548 bytes.
3549
3550 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3551
3552 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3553
3554 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3555
3556 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3557
3558 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3559
3560 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3561 * charset.c (Fdefine_charset_internal): Don't initialize
3562 charset.code_space[15]. The value was garbage, on hosts with
3563 32-bit int (Bug#8600).
3564
3565 * lread.c (read_integer): Be more consistent with string-to-number.
3566 Use string_to_number to do the actual conversion; this avoids
3567 rounding errors and fixes some other screwups. Without this fix,
3568 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3569 (digit_to_number): Move earlier, for benefit of read_integer.
3570 Return -1 if the digit is out of range for the base, -2 if it is
3571 not a digit in any supported base. (Bug#8602)
3572
3573 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3574
3575 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3576 to match comment at start of function. This also removes a
3577 GCC warning about overflow in a 32+64-bit port.
3578
3579 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3580
3581 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3582 Reported by Stefan Monnier in
3583 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3584 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3585 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3586
3587 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3588 (EMACS_UINTPTR): Likewise, with uintptr_t.
3589
3590 * lisp.h: Prefer 64-bit EMACS_INT if available.
3591 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3592 on 32-bit hosts that have 64-bit int, so that they can access
3593 large files.
3594 However, temporarily disable this change unless the temporary
3595 symbol WIDE_EMACS_INT is defined.
3596
3597 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3598
3599 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3600 This removes an assumption that EMACS_INT and long are the same
3601 width as pointers. The assumption is true for Emacs porting targets
3602 now, but we want to make other targets possible.
3603 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3604 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3605 In the rest of the code, change types of integers that hold casted
3606 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3607 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3608 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3609 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3610 No need to cast type when ORing.
3611 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3612 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3613 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3614 assume EMACS_INT is the same width as char *.
3615 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3616 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3617 Remove no-longer-needed casts.
3618 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3619 (xg_tool_bar_help_callback, xg_make_tool_item):
3620 Use EMACS_INTPTR to hold an integer
3621 that will be cast to void *; this can avoid a GCC warning
3622 if EMACS_INT is not the same width as void *.
3623 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3624 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3625 (current_message_1, set_message_1):
3626 Use a local to convert to proper width without a cast.
3627 * xmenu.c (dialog_selection_callback): Likewise.
3628
3629 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3630 Also, don't assume VALBITS / RAND_BITS is less than 5,
3631 and don't rely on undefined behavior when shifting a 1 left into
3632 the sign bit.
3633 * lisp.h (get_random): Change signature to match.
3634
3635 * lread.c (hash_string): Use size_t, not int, for hash computation.
3636 Normally we prefer signed values; but hashing is special, because
3637 it's better to use unsigned division on hash table sizes so that
3638 the remainder is nonnegative. Also, size_t is the natural width
3639 for hashing into memory. The previous code used 'int', which doesn't
3640 retain enough info to hash well into very large tables.
3641 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3642
3643 * dbusbind.c: Don't possibly lose pointer info when converting.
3644 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3645 Use XPNTR rather than XHASH, so that the high-order bits of
3646 the pointer aren't lost when converting through void *.
3647
3648 * eval.c (Fautoload): Don't double-shift a pointer.
3649
3650 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3651
3652 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3653
3654 * gnutls.c (DEF_GNUTLS_FN):
3655 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3656
3657 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3658
3659 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3660 marker. (Bug#8610)
3661
3662 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3663
3664 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3665 New version that can reserve upto 2GB of heap space.
3666
3667 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3668
3669 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3670
3671 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3672
3673 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3674 `gnutls_certificate_set_x509_key_file'.
3675
3676 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3677
3678 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3679 Update dependencies.
3680
3681 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3682
3683 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3684 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3685 Remove unused parameter `fildes'.
3686 * process.c (read_process_output, send_process): Don't pass it.
3687
3688 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3689
3690 Fix previous change: the library cache is defined in w32.c.
3691 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3692 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3693
3694 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3695
3696 Implement dynamic loading of GnuTLS on Windows.
3697
3698 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3699 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3700 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3701 Declare.
3702
3703 * gnutls.c (Qgnutls_dll): Define.
3704 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3705 (gnutls_*): Declare function pointers.
3706 (init_gnutls_functions): New function to initialize function pointers.
3707 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3708 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3709 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3710 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3711 (emacs_gnutls_write, emacs_gnutls_read)
3712 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3713 (Fgnutls_available_p): New function.
3714 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3715 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3716 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3717
3718 * image.c: Include w32.h.
3719 (Vimage_type_cache): Delete.
3720 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3721 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3722 (w32_delayed_load): Move to w32.c.
3723
3724 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3725
3726 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3727 (w32_delayed_load): Move from image.c. When loading a library, record
3728 its filename in the :loaded-from property of the library id.
3729 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3730 Initialize and staticpro them.
3731 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3732
3733 * process.c: Include lisp.h before w32.h, not after.
3734 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3735 instead of gnutls_record_check_pending.
3736
3737 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3738
3739 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3740
3741 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3742 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3743 as passed in.
3744
3745 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3746
3747 * xterm.c (x_set_frame_alpha): Do not set property on anything
3748 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3749
3750 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3751
3752 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3753
3754 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3755
3756 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3757 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3758 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3759 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3760 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3761 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3762 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3763 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3764 (Qgnutls_bootprop_callbacks_verify): Make static.
3765
3766 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3767
3768 * callproc.c: Indentation fixup.
3769
3770 * sysdep.c (wait_for_termination_1): Make static.
3771 (wait_for_termination, interruptible_wait_for_termination):
3772 Move after wait_for_termination_1.
3773
3774 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3775
3776 * sysdep.c (interruptible_wait_for_termination): New function
3777 which is like wait_for_termination, but allows keyboard
3778 interruptions.
3779
3780 * callproc.c (Fcall_process): Add (:file "file") as an option for
3781 the STDOUT buffer.
3782 (Fcall_process_region): Ditto.
3783
3784 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3785
3786 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3787 rather than `XVECTOR (FOO)->size'.
3788
3789 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3790 inttypes.h, as a gnulib replacement is used if it not available in
3791 system headers.
3792
3793 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3794
3795 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3796 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3797 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3798
3799 * coding.c (coding_alloc_by_realloc): Error out if destination
3800 will grow beyond MOST_POSITIVE_FIXNUM.
3801 (decode_coding_emacs_mule): Abort if there isn't enough place in
3802 charbuf for the composition carryover bytes. Reserve an extra
3803 space for up to 2 characters produced in a loop.
3804 (decode_coding_iso_2022): Abort if there isn't enough place in
3805 charbuf for the composition carryover bytes.
3806
3807 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3808
3809 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3810 aborting when %lld or %lll format is passed.
3811 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3812 %llo or %llx format is passed. (Bug#8545)
3813
3814 * window.c (window_scroll_line_based): Use a marker instead of
3815 simple variables to record original value of point. (Bug#7952)
3816
3817 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3818 produced by %s or %c overflows available buffer space. (Bug#8545)
3819
3820 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3821
3822 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3823 (SIZE_MAX): Move defn after all includes, as they might #define it.
3824
3825 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3826
3827 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3828
3829 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3830
3831 * keyboard.c (Qdelayed_warnings_hook): Define.
3832 (command_loop_1): Run `delayed-warnings-hook'
3833 if Vdelayed_warnings_list is non-nil.
3834 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3835 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3836
3837 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3838
3839 * doprnt.c (doprnt): Don't return value smaller than the buffer
3840 size if the message was truncated. (Bug#8545).
3841
3842 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3843
3844 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3845 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3846
3847 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3848
3849 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3850
3851 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3852
3853 * makefile.w32-in: Update dependencies.
3854
3855 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3856
3857 Improve `doprnt' and its usage. (Bug#8545)
3858 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3859 `format_end'. Remove support for %l as a conversion specifier.
3860 Don't use xrealloc. Improve diagnostics when the %l size modifier
3861 is used. Update the commentary.
3862
3863 * eval.c (verror): Simplify calculation of size_t.
3864
3865 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3866 messages.
3867
3868 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3869
3870 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3871 change.
3872
3873 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3874
3875 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3876 This makes this file independent of the recent pseudovector change.
3877
3878 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3879
3880 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3881
3882 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3883 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3884 Remove unused local.
3885 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3886
3887 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3888 GCC 4.6.0 optimizes based on type-based alias analysis.
3889 For example, if b is of type struct buffer * and v of type struct
3890 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3891 != &v->size, and therefore "v->size = 1; b->size = 2; return
3892 v->size;" must therefore return 1. This assumption is incorrect
3893 for Emacs, since it type-puns struct Lisp_Vector * with many other
3894 types. To fix this problem, this patch adds a new type struct
3895 vectorlike_header that documents the constraints on layout of vectors
3896 and pseudovectors, and helps optimizing compilers not get fooled
3897 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3898 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3899 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3900 the size member.
3901 (XSETPVECTYPE): Rewrite in terms of new macro.
3902 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3903 This is a bit clearer, and further avoids the possibility of
3904 undesirable aliasing.
3905 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3906 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3907 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3908 since Lisp_Subr is a special case (no "next" field).
3909 (ASIZE): Now uses header.size rather than size.
3910 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3911 to avoid the hassle of writing XVECTOR (foo)->header.size.
3912 (struct vectorlike_header): New type.
3913 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3914 object, to help avoid aliasing.
3915 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3916 (SUBRP): Likewise, since Lisp_Subr is a special case.
3917 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3918 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3919 (struct Lisp_Hash_Table): Combine first two members into a single
3920 struct vectorlike_header member. All uses of "size" and "next" members
3921 changed to be "header.size" and "header.next".
3922 * buffer.h (struct buffer): Likewise.
3923 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3924 * frame.h (struct frame): Likewise.
3925 * process.h (struct Lisp_Process): Likewise.
3926 * termhooks.h (struct terminal): Likewise.
3927 * window.c (struct save_window_data, struct saved_window): Likewise.
3928 * window.h (struct window): Likewise.
3929 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3930 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3931 * buffer.c (init_buffer_once): Likewise.
3932 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3933 special case.
3934 * process.c (Fformat_network_address): Use local var for size,
3935 for brevity.
3936
3937 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3938
3939 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3940 * data.c (atof): Remove decl; no longer used or needed.
3941 (digit_to_number): Move to lread.c.
3942 (Fstring_to_number): Use new string_to_number function, to be
3943 consistent with how the Lisp reader treats infinities and NaNs.
3944 Do not assume that floating-point numbers represent EMACS_INT
3945 without losing information; this is not true on most 64-bit hosts.
3946 Avoid double-rounding errors, by insisting on integers when
3947 parsing non-base-10 numbers, as the documentation specifies.
3948 * lisp.h (string_to_number): New decl, replacing ...
3949 (isfloat_string): Remove.
3950 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3951 (read1): Do not accept +. and -. as integers; this
3952 appears to have been a coding error. Similarly, do not accept
3953 strings like +-1e0 as floating point numbers. Do not report
3954 overflow for integer overflows unless the base is not 10 which
3955 means we have no simple and reliable way to continue.
3956 Break out the floating-point parsing into a new
3957 function string_to_number, so that Fstring_to_number parses
3958 floating point numbers consistently with the Lisp reader.
3959 (digit_to_number): Move here from data.c. Make it static inline.
3960 (E_CHAR, EXP_INT): Remove, replacing with ...
3961 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3962 (string_to_number): New function, replacing isfloat_string.
3963 This function checks for valid syntax and produces the resulting
3964 Lisp float number too. Rework it so that string-to-number
3965 no longer mishandles examples like "1.0e+". Use strtoumax,
3966 so that overflow for non-base-10 numbers is reported only when
3967 there's no portable and simple way to convert to floating point.
3968
3969 * textprop.c (set_text_properties_1): Rewrite for clarity,
3970 and to avoid GCC warning about integer overflow.
3971
3972 * intervals.h (struct interval): Use EMACS_INT for members
3973 where EMACS_UINT might cause problems. See
3974 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3975 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3976 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3977 All uses changed.
3978 (offset_intervals): Tell GCC not to worry about length overflow
3979 when negating a negative length.
3980
3981 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3982 (overrun_check_free): Likewise.
3983
3984 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3985 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3986 word size.
3987
3988 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3989 (gnutls_make_error): Rename local to avoid shadowing.
3990 (gnutls_emacs_global_deinit): ifdef out; not used.
3991 (Fgnutls_boot): Use const for pointer to readonly storage.
3992 Comment out unused local. Fix pointer signedness problems.
3993
3994 * lread.c (openp): Don't stuff size_t into an 'int'.
3995 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3996 about possible signed overflow.
3997
3998 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3999 (GDK_KEY_g): Don't define if already defined.
4000 (xg_prepare_tooltip): Avoid pointer signedness problem.
4001 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4002
4003 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4004 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4005
4006 * xfns.c (Fx_window_property): Simplify a bit,
4007 to make a bit faster and to avoid GCC 4.6.0 warning.
4008 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4009
4010 * fns.c (internal_equal): Don't assume size_t fits in int.
4011
4012 * alloc.c (compact_small_strings): Tighten assertion a little.
4013
4014 Replace pEd with more-general pI, and fix some printf arg casts.
4015 * lisp.h (pI): New macro, generalizing old pEd macro to other
4016 conversion specifiers. For example, use "...%"pI"d..." rather
4017 than "...%"pEd"...".
4018 (pEd): Remove. All uses replaced with similar uses of pI.
4019 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4020 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4021 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4022 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4023 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4024 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4025 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4026 64-bit hosts.
4027 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4028 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4029 * print.c (safe_debug_print, print_object): Likewise.
4030 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4031 to int.
4032 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4033 avoiding the 0 flag, which is not portable.
4034 * process.c (Fmake_network_process): Use pI to avoid cast.
4035 * region-cache.c (pp_cache): Likewise.
4036 * xdisp.c (decode_mode_spec): Likewise.
4037 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4038 behavior on 64-bit hosts with printf arg.
4039 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4040 (x_stop_queuing_selection_requests): Likewise.
4041 (x_get_window_property): Don't truncate byte count to an 'int'
4042 when tracing.
4043
4044 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4045 here, since it parses constructs like leading '-' and spaces,
4046 which are not wanted; and it overflows with large numbers.
4047 Instead, simply match F[0-9]+, which is what is wanted anyway.
4048
4049 * alloc.c: Remove unportable assumptions about struct layout.
4050 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4051 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4052 (allocate_vectorlike, make_pure_vector): Use the new macros,
4053 plus offsetof, to remove unportable assumptions about struct layout.
4054 These assumptions hold on all porting targets that I know of, but
4055 they are not guaranteed, they're easy to remove, and removing them
4056 makes further changes easier.
4057
4058 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4059 This doesn't fix a bug but makes the code clearer.
4060 (string_overrun_cookie): Now const. Use initializers that
4061 don't formally overflow signed char, to avoid warnings.
4062 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4063 can cause Emacs to crash when string overrun checking is enabled.
4064 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4065 multiple of sizeof (EMACS_INT); it need not be, if
4066 alignof(EMACS_INT) < sizeof (EMACS_INT).
4067 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4068
4069 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4070
4071 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4072
4073 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4074
4075 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4076 supposed to be handshaking. (Bug#8556)
4077 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4078
4079 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4080
4081 * lisp.h (Qdebug): List symbol.
4082 * eval.c (Qdebug): Restore global linkage.
4083 * keyboard.c (debug-on-event): New variable.
4084 (handle_user_signal): Break into debugger when debug-on-event
4085 matches the current signal symbol.
4086
4087 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4088
4089 * alloc.c (check_sblock, check_string_bytes)
4090 (check_string_free_list): Convert to standard C.
4091
4092 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4093
4094 * w32.c (emacs_gnutls_push): Fix typo.
4095
4096 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4097
4098 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4099 "cast to pointer from integer of different size".
4100
4101 Improve doprnt and its use in verror. (Bug#8545)
4102 * doprnt.c (doprnt): Document the set of format control sequences
4103 supported by the function. Use SAFE_ALLOCA instead of always
4104 using `alloca'.
4105
4106 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4107 is one byte too soon. Don't use xrealloc; instead xfree and
4108 xmalloc anew.
4109
4110 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4111
4112 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4113 callbacks stage.
4114
4115 * gnutls.c: Renamed global_initialized to
4116 gnutls_global_initialized. Added internals for the
4117 :verify-hostname-error, :verify-error, and :verify-flags
4118 parameters of `gnutls-boot' and documented those parameters in the
4119 docstring. Start callback support.
4120 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4121 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4122 on error. Return error code.
4123 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4124 (emacs_gnutls_read): Likewise.
4125 (Fgnutls_boot): Return handshake error code.
4126 (emacs_gnutls_handle_error): New function.
4127 (wsaerror_to_errno): Likewise.
4128
4129 * w32.h (emacs_gnutls_pull): Add prototype.
4130 (emacs_gnutls_push): Likewise.
4131
4132 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4133 (emacs_gnutls_push): Likewise.
4134
4135 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4136
4137 * process.c (wait_reading_process_output): Check if GnuTLS
4138 buffered some data internally if no FDs are set for TLS
4139 connections.
4140
4141 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4142 (LIBS): Link to USER_LIBS.
4143 ($(BLD)/gnutls.$(0)): New target.
4144
4145 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4146
4147 * xdisp.c (handle_single_display_spec): Rename the
4148 display_replaced_before_p argument into display_replaced_p, to
4149 make it consistent with the commentary. Fix typos in the
4150 commentary.
4151
4152 * textprop.c (syms_of_textprop): Remove dead code.
4153 (copy_text_properties): Delete obsolete commentary about an
4154 interface that was deleted long ago. Fix typos in the description
4155 of arguments.
4156
4157 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4158 to changes in oldXMenu/XMenu.h from 2011-04-16.
4159 <menu_help_message, prev_menu_help_message>: Constify.
4160 (IT_menu_make_room): menu->help_text is now `const char **';
4161 adjust.
4162
4163 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4164 to changes in oldXMenu/XMenu.h from 2011-04-16.
4165 (struct XMenu): Declare `help_text' `const char **'.
4166
4167 * xfaces.c <Qunspecified>: Make extern again.
4168
4169 * syntax.c: Include sys/types.h before including regex.h, as
4170 required by Posix.
4171
4172 * doc.c (get_doc_string): Improve the format passed to `error'.
4173
4174 * doprnt.c (doprnt): Improve commentary.
4175
4176 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4177
4178 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4179 them with etags.
4180
4181 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4182 changes in globals.h immediately force recompilation.
4183 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4184 $(CURDIR)/s/ms-w32.h.
4185 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4186
4187 * character.c (Fchar_direction): Function deleted.
4188 (syms_of_character): Don't defsubr it.
4189 <char-direction-table>: Deleted.
4190
4191 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4192
4193 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4194 * doprnt.c: Include limits.h.
4195 (SIZE_MAX): New macro.
4196 (doprnt): Return a size_t value. 2nd arg is now size_t.
4197 Many local variables are now size_t instead of int or unsigned.
4198 Improve overflow protection. Support `l' modifier for integer
4199 conversions. Support %l conversion. Don't assume an EMACS_INT
4200 argument for integer conversions and for %c.
4201
4202 * lisp.h (doprnt): Restore prototype.
4203
4204 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4205 $(SRC)/character.h.
4206
4207 * Makefile.in (base_obj): Add back doprnt.o.
4208
4209 * deps.mk (doprnt.o): Add back prerequisites.
4210 (callint.o): Depend on character.h.
4211
4212 * eval.c (internal_lisp_condition_case): Include the handler
4213 representation in the error message.
4214 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4215 when breaking from the loop.
4216
4217 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4218
4219 * callint.c (Fcall_interactively): When displaying error message
4220 about invalid control letter, pass the character's codepoint, not
4221 a pointer to its multibyte form. Improve display of the character
4222 in octal and display also its hex code.
4223
4224 * character.c (char_string): Use %x to display the (unsigned)
4225 codepoint of an invalid character, to avoid displaying a bogus
4226 negative value.
4227
4228 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4229 `error', not SYMBOL_NAME itself.
4230
4231 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4232 character arguments to `error'.
4233
4234 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4235 to `error' in error message about FINAL_CHAR argument. Make sure
4236 FINAL_CHAR is a character, and use %c when it is passed as
4237 argument to `error'.
4238
4239 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4240
4241 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4242
4243 * w32.c: Include <time.h>.
4244 (sys_localtime): New function.
4245
4246 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4247
4248 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4249
4250 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4251
4252 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4253
4254 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4255 zombies (Bug#8467).
4256
4257 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4258
4259 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4260 gl_state.e_property when gl_state.object is Qt.
4261
4262 * insdel.c (make_gap_larger): Remove limitation of buffer size
4263 to <= INT_MAX.
4264
4265 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4266
4267 * xdisp.c (lookup_glyphless_char_display)
4268 (produce_glyphless_glyph): Handle cons cell entry in
4269 glyphless-char-display.
4270 (Vglyphless_char_display): Document it.
4271
4272 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4273 glyphless-char-display.
4274
4275 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4276
4277 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4278
4279 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4280
4281 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4282 definition for no-X builds.
4283
4284 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4285
4286 Static checks with GCC 4.6.0 and non-default toolkits.
4287
4288 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4289
4290 * process.c (keyboard_bit_set): Define only if SIGIO.
4291 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4292 (send_process): Repair possible setjmp clobbering.
4293
4294 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4295
4296 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4297
4298 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4299
4300 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4301 Define only if needed.
4302
4303 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4304 by pacifying GCC about it. Maybe it's time to retire it?
4305 * xfaces.c (USG, __TIMEVAL__): Likewise.
4306
4307 * dispextern.h (struct redisplay_interface): Rename param
4308 to avoid shadowing.
4309 * termhooks.h (struct terminal): Likewise.
4310 * xterm.c (xembed_send_message): Likewise.
4311
4312 * insdel.c (make_gap_smaller): Define only if
4313 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4314
4315 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4316 it.
4317
4318 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4319 so that we aren't warned about unused symbols.
4320
4321 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4322
4323 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4324
4325 * xfns.c (x_real_positions): Mark locals as initialized.
4326
4327 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4328
4329 * xterm.c: Fix problems found by static analysis with other toolkits.
4330 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4331 (x_dispatch_event): Declare static if USE_GTK, and
4332 define if USE_GTK || USE_X_TOOLKIT.
4333 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4334 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4335 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4336 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4337
4338 * xmenu.c (menu_help_callback): Pointer type fixes.
4339 Use const pointers when pointing at readonly data. Avoid pointer
4340 signedness clashes.
4341 (FALSE): Remove unused macro.
4342 (update_frame_menubar): Remove unused decl.
4343
4344 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4345
4346 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4347 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4348 (single_menu_item): Rename local to avoid shadowing.
4349
4350 * keyboard.c (make_lispy_event): Remove unused local var.
4351
4352 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4353 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4354
4355 * bitmaps: Change bitmaps from unsigned char back to the X11
4356 compatible char. Avoid the old compiler warnings about
4357 out-of-range initializers by using, for example, '\xab' rather
4358 than 0xab.
4359
4360 * xgselect.c (xgselect_initialize): Check vs interface
4361 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4362
4363 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4364
4365 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4366 to read-only memory.
4367
4368 * fns.c (vector): Remove; this old hack is no longer needed.
4369
4370 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4371 Remove unused var.
4372 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4373
4374 * xrdb.c (x_load_resources): Omit unused local.
4375
4376 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4377 (x_window): Rename locals to avoid shadowing.
4378 (USG): Use the kludged USG macro, to pacify gcc.
4379
4380 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4381 (x_term_init): Remove local to avoid shadowing.
4382
4383 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4384
4385 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4386 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4387
4388 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4389
4390 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4391
4392 Fix regex.c, syntax.c and friends for buffers > 2GB.
4393 * syntax.h (struct gl_state_s): Declare character position members
4394 EMACS_INT.
4395
4396 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4397
4398 * textprop.c (verify_interval_modification, interval_of):
4399 Declare arguments EMACS_INT.
4400
4401 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4402 EMACS_INT.
4403
4404 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4405
4406 * indent.c (Fvertical_motion): Local variable it_start is now
4407 EMACS_INT.
4408
4409 * regex.c (re_match, re_match_2, re_match_2_internal)
4410 (bcmp_translate, regcomp, regexec, print_double_string)
4411 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4412 (re_compile_pattern, re_exec): Declare arguments and local
4413 variables `size_t' and `ssize_t' and return values `regoff_t', as
4414 appropriate.
4415 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4416 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4417 <compile_stack_type>: `size' and `avail' are now `size_t'.
4418
4419 * regex.h <regoff_t>: Use ssize_t, not int.
4420 (re_search, re_search_2, re_match, re_match_2): Arguments that
4421 specify buffer/string position and length are now ssize_t and
4422 size_t. Return type is regoff_t.
4423
4424 2011-04-16 Ben Key <bkey76@gmail.com>
4425
4426 * nsfont.m: Fixed bugs in ns_get_family and
4427 ns_descriptor_to_entity that were caused by using free to
4428 deallocate memory blocks that were allocated by xmalloc (via
4429 xstrdup). This caused Emacs to crash when compiled with
4430 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4431 --enable-checking=xmallocoverrun). xfree is now used to
4432 deallocate these memory blocks.
4433
4434 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4435
4436 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4437
4438 emacs_write: Accept and return EMACS_INT for sizes.
4439 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4440 et seq.
4441 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4442 Accept and return EMACS_INT.
4443 (emacs_gnutls_write): Return the number of bytes written on
4444 partial writes.
4445 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4446 (emacs_read, emacs_write): Remove check for negative size, as the
4447 Emacs source code has been audited now.
4448 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4449 (emacs_read, emacs_write): Use it.
4450 * process.c (send_process): Adjust to the new signatures of
4451 emacs_write and emacs_gnutls_write. Do not attempt to store
4452 a byte offset into an 'int'; it might overflow.
4453 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4454
4455 * sound.c: Don't assume sizes fit in 'int'.
4456 (struct sound_device.period_size, alsa_period_size):
4457 Return EMACS_INT, not int.
4458 (struct sound_device.write, vox_write, alsa_write):
4459 Accept EMACS_INT, not int.
4460 (wav_play, au_play): Use EMACS_INT to store sizes and to
4461 record read return values.
4462
4463 2011-04-15 Ben Key <bkey76@gmail.com>
4464
4465 * keyboard.c (Qundefined): Don't declare static since it is used
4466 in nsfns.m.
4467 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4468 static since they are used in nsfont.m.
4469
4470 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4471
4472 * process.c (Qprocessp): Don't declare static.
4473 * lisp.h (Qprocessp): Declare again.
4474
4475 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4476
4477 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4478
4479 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4480
4481 Improve C-level modularity by making more things 'static'.
4482
4483 Don't publish debugger-only interfaces to other modules.
4484 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4485 (verify_bytepos, count_markers): Move decls to the only modules
4486 that need them.
4487 * region-cache.h (pp_cache): Likewise.
4488 * window.h (check_all_windows): Likewise.
4489 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4490
4491 * sysdep.c (croak): Now static, if
4492 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4493 * syssignal.h (croak): Declare only if not static.
4494
4495 * alloc.c (refill_memory_reserve): Now static if
4496 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4497 * lisp.h (refill_memory_reserve): Declare only if not static.
4498
4499 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4500 Define only if USE_LUCID.
4501
4502 * xrdb.c (x_customization_string, x_rm_string): Now static.
4503
4504 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4505 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4506
4507 * xdisp.c (draw_row_with_mouse_face): Now static.
4508 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4509
4510 * window.h (check_all_windows): Mark externally visible.
4511
4512 * window.c (window_deletion_count): Now static.
4513
4514 * undo.c: Make symbols static if they're not exported.
4515 (last_undo_buffer, last_boundary_position, pending_boundary):
4516 Now static.
4517
4518 * textprop.c (interval_insert_behind_hooks): Now static.
4519 (interval_insert_in_front_hooks): Likewise.
4520
4521 * term.c: Make symbols static if they're not exported.
4522 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4523 (max_frame_lines, tty_set_terminal_modes):
4524 (tty_reset_terminal_modes, tty_turn_off_highlight):
4525 (get_tty_terminal): Now static.
4526 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4527 * termhooks.h (term_mouse_moveto): Do not declare if
4528 HAVE_WINDOW_SYSTEM.
4529 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4530 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4531
4532 * sysdep.c: Make symbols static if they're not exported.
4533 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4534 Now static.
4535 (sigprocmask_set, full_mask): Remove; unused.
4536 (wait_debugging): Mark as visible.
4537 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4538 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4539
4540 * syntax.c (syntax_temp): Define only if !__GNUC__.
4541
4542 * sound.c (current_sound_device, current_sound): Now static.
4543
4544 * search.c (searchbufs, searchbuf_head): Now static.
4545
4546 * scroll.c (scroll_cost): Remove; unused.
4547 * dispextern.h (scroll_cost): Remove decl.
4548
4549 * region-cache.h (pp_cache): Mark as externally visible.
4550
4551 * process.c: Make symbols static if they're not exported.
4552 (process_tick, update_tick, create_process, chan_process):
4553 (Vprocess_alist, proc_buffered_char, datagram_access):
4554 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4555 (deactivate_process): Mark defn as static, as well as decl.
4556 * lisp.h (create_process): Remove decl.
4557 * process.h (chan_process, Vprocess_alist): Remove decls.
4558
4559 * print.c: Make symbols static if they're not exported.
4560 (print_depth, new_backquote_output, being_printed, print_buffer):
4561 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4562 (print_interval, print_number_index, initial_stderr_stream):
4563 Now static.
4564 * lisp.h (Fprinc): Remove decl.
4565 (debug_output_compilation_hack): Mark as externally visible.
4566
4567 * sysdep.c (croak): Move decl from here to syssignal.h.
4568 * syssignal.h (croak): Put it here, so the API can be checked when
4569 'croak' is called from dissociate_if_controlling_tty.
4570
4571 * minibuf.c: Make symbols static if they're not exported.
4572 (minibuf_save_list, choose_minibuf_frame): Now static.
4573 * lisp.h (choose_minibuf_frame): Remove decl.
4574
4575 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4576
4577 * lread.c: Make symbols static if they're not exported.
4578 (read_objects, initial_obarray, oblookup_last_bucket_number):
4579 Now static.
4580 (make_symbol): Remove; unused.
4581 * lisp.h (initial_obarray, make_symbol): Remove decls.
4582
4583 * keyboard.c: Make symbols static if they're not exported.
4584 (single_kboard, recent_keys_index, total_keys, recent_keys):
4585 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4586 (this_single_command_key_start, echoing, last_auto_save):
4587 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4588 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4589 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4590 (Vlispy_mouse_stem, double_click_count):
4591 Now static.
4592 (force_auto_save_soon): Define only if SIGDANGER.
4593 (ignore_mouse_drag_p): Now static if
4594 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4595 (print_help): Remove; unused.
4596 (stop_character, last_timer_event): Mark as externally visible.
4597 * keyboard.h (ignore_mouse_drag_p): Declare only if
4598 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4599 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4600 * lisp.h (echoing): Remove decl.
4601 (force_auto_save_soon): Declare only if SIGDANGER.
4602 * xdisp.c (redisplay_window): Simplify code, to make it more
4603 obvious that ignore_mouse_drag_p is not accessed if !defined
4604 USE_GTK && !defined HAVE_NS.
4605
4606 * intervals.c: Make symbols static if they're not exported.
4607 (merge_properties_sticky, merge_interval_right, delete_interval):
4608 Now static.
4609 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4610
4611 * insdel.c: Make symbols static if they're not exported.
4612 However, leave prepare_to_modify_buffer alone. It's never
4613 called from outside this function, but that appears to be a bug.
4614 (combine_after_change_list, combine_after_change_buffer):
4615 (adjust_after_replace, signal_before_change): Now static.
4616 (adjust_after_replace_noundo): Remove; unused.
4617 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4618 (signal_before_change): Remove decls.
4619
4620 * indent.c (val_compute_motion, val_vmotion): Now static.
4621
4622 * image.c: Make symbols static if they're not exported.
4623 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4624 if USE_GTK.
4625 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4626 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4627
4628 * fringe.c (standard_bitmaps): Now static.
4629 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4630
4631 * frame.c: Make symbols static if they're not exported.
4632 (x_report_frame_params, make_terminal_frame): Now static.
4633 (get_frame_param): Now static, unless HAVE_NS.
4634 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4635 (x_get_resource_string): Remove; not used.
4636 * frame.h (make_terminal_frame, x_report_frame_params):
4637 (x_get_resource_string); Remove decls.
4638 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4639 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4640
4641 * font.c, fontset.c: Make symbols static if they're not exported.
4642 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4643 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4644 * font.c (font_close_object): Now static.
4645 * font.h (font_close_object): Remove.
4646 * fontset.c (FONTSET_OBJLIST): Remove.
4647 (free_realized_fontset) #if-0 the body, which does nothing.
4648 (face_suitable_for_char_p): #if-0, as it's never called.
4649 * fontset.h (face_suitable_for_char_p): Remove decl.
4650 * xfaces.c (face_at_string_position):
4651 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4652 since 0 is always ASCII.
4653
4654 * fns.c (weak_hash_tables): Now static.
4655
4656 * fileio.c: Make symbols static if they're not exported.
4657 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4658 (Vwrite_region_annotation_buffers): Now static.
4659
4660 * eval.c: Make symbols static if they're not exported.
4661 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4662 * lisp.h (backtrace_list): Remove decl.
4663
4664 * emacs.c: Make symbols static if they're not exported.
4665 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4666 (fatal_error_code, fatal_error_signal_hook, standard_args):
4667 Now static.
4668 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4669 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4670 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4671 * lisp.h (fatal_error_signal_hook): Remove decl.
4672 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4673
4674 * editfns.c: Move a (normally-unused) function to its only use.
4675 * editfns.c, lisp.h (get_operating_system_release): Remove.
4676 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4677 worth the hassle of breaking this out.
4678
4679 * xterm.c: Make symbols static if they're not exported.
4680 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4681 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4682 (x_destroy_window, x_delete_display):
4683 Now static.
4684 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4685 (x_mouse_leave): Remove; unused.
4686 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4687 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4688 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4689 Remove decls.
4690 (x_mouse_leave): Declare only if WINDOWSNT.
4691 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4692 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4693 USE_X_TOOLKIT.
4694
4695 * ftxfont.c: Make symbols static if they're not exported.
4696 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4697 HAVE_FREETYPE.
4698 * font.h (ftxfont_driver): Likewise.
4699
4700 * xfns.c: Make symbols static if they're not exported.
4701 (x_last_font_name, x_display_info_for_name):
4702 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4703 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4704 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4705 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4706 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4707 (last_show_tip_args): Now static.
4708 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4709 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4710 (x_screen_planes): Remove; unused.
4711 * dispextern.h (x_screen_planes): Remove decl.
4712
4713 * dispnew.c: Make symbols static if they're not exported.
4714 * dispextern.h (redraw_garbaged_frames, scrolling):
4715 (increment_row_positions): Remove.
4716 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4717 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4718 Now static.
4719 (redraw_garbaged_frames): Remove; unused.
4720
4721 * xfaces.c: Make symbols static if they're not exported.
4722 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4723 Remove decls.
4724 * xterm.h (defined_color): Remove decls.
4725 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4726 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4727 (menu_face_changed_default, defined_color, free_realized_face):
4728 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4729 (ascii_face_of_lisp_face): Remove; unused.
4730
4731 * xdisp.c: Make symbols static if they're not exported.
4732 * dispextern.h (scratch_glyph_row, window_box_edges):
4733 (glyph_to_pixel_coords, set_cursor_from_row):
4734 (get_next_display_element, set_iterator_to_next):
4735 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4736 (show_mouse_face): Remove decls
4737 * frame.h (message_buf_print): Likewise.
4738 * lisp.h (pop_message, set_message, check_point_in_composition):
4739 Likewise.
4740 * xterm.h (set_vertical_scroll_bar): Likewise.
4741 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4742 (message_buf_print, scratch_glyph_row, displayed_buffer):
4743 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4744 (get_next_display_element, show_mouse_face, window_box_edges):
4745 (frame_to_window_pixel_xy, check_point_in_composition):
4746 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4747 (glyph_to_pixel_coords): Remove; unused.
4748
4749 * dired.c (file_name_completion): Now static.
4750
4751 * dbusbind.c (xd_in_read_queued_messages): Now static.
4752
4753 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4754 * data.c (circular_list_error): Remove.
4755
4756 * commands.h (last_point_position, last_point_position_buffer):
4757 (last_point_position_window): Remove decls.
4758 * keyboard.c: Make these variables static.
4759
4760 * coding.h (coding, code_convert_region, encode_coding_gap):
4761 Remove decls.
4762 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4763 (iso_code_class, detect_coding, code_convert_region): Now static.
4764 (encode_coding_gap): Remove; unused.
4765
4766 * chartab.c (chartab_chars, chartab_bits): Now static.
4767
4768 * charset.h (charset_iso_8859_1): Remove decl.
4769 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4770 Now static.
4771
4772 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4773 * ccl.c (Vccl_program_table): Now static.
4774 (check_ccl_update): Remove; unused.
4775
4776 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4777 * category.h: ... from here.
4778 * category.c (check_category_table, set_category_set): Now static.
4779
4780 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4781 * lisp.h: Remove these decls.
4782
4783 * buffer.c (buffer_count): Remove unused var.
4784
4785 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4786 so that it's not optimized away.
4787 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4788 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4789 exported only to the debugger.
4790
4791 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4792 * atimer.h (run_all_atimers): Remove; not exported.
4793
4794 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4795 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4796 was inaccessible from Lisp.
4797 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4798 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4799
4800 alloc.c: Import and export fewer symbols, and remove unused items.
4801 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4802 is defined.
4803 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4804 it's not optimized away by whole-program optimization.
4805 (message_enable_multibyte, free_misc): Remove.
4806 (catchlist, handlerlist, mark_backtrace):
4807 Declare only if BYTE_MARK_STACK.
4808 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4809 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4810 (message_enable_multibyte): Remove decl.
4811 (free_misc, interval_free_list, float_block, float_block_index):
4812 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4813 (cons_free_list, last_marked_index):
4814 Now static.
4815 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4816 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4817 (mark_backtrace): Define only if BYTE_MARK_STACK.
4818 * xdisp.c (message_enable_multibyte): Now static.
4819
4820 Declare Lisp_Object Q* variables to be 'static' if not exported.
4821 This makes it easier for human readers (and static analyzers)
4822 to see whether these variables are used from other modules.
4823 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4824 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4825 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4826 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4827 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4828 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4829 * xmenu.c, xselect.c:
4830 Declare Q* vars static if they are not used in other modules.
4831 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4832 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4833 Remove decls of unexported vars.
4834 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4835
4836 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4837
4838 Make Emacs functions such as Fatom 'static' by default.
4839 This makes it easier for human readers (and static analyzers)
4840 to see whether these functions can be called from other modules.
4841 DEFUN now defines a static function. To make the function external
4842 so that it can be used in other C modules, use the new macro DEFUE.
4843 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4844 (Finit_image_library):
4845 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4846 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4847 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4848 Remove decls, since these functions are now static.
4849 (Funintern, Fget_internal_run_time): New decls, since these functions
4850 were already external.
4851
4852 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4853 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4854 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4855 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4856 * keyboard.c, keymap.c, lread.c:
4857 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4858 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4859 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4860 Mark functions with DEFUE instead of DEFUN,
4861 if they are used in other modules.
4862 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4863 decls for now-static functions.
4864 * buffer.h (Fdelete_overlay): Remove decl.
4865 * callproc.c (Fgetenv_internal): Mark as internal.
4866 * composite.c (Fremove_list_of_text_properties): Remove decl.
4867 (Fcomposition_get_gstring): New forward static decl.
4868 * composite.h (Fcomposite_get_gstring): Remove decl.
4869 * dired.c (Ffile_attributes): New forward static decl.
4870 * doc.c (Fdocumntation_property): New forward static decl.
4871 * eval.c (Ffetch_bytecode): New forward static decl.
4872 (Funintern): Remove extern decl; now in .h file where it belongs.
4873 * fileio.c (Fmake_symbolic_link): New forward static decl.
4874 * image.c (Finit_image_library): New forward static decl.
4875 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4876 * intervals.h (Fprevious_property_change):
4877 (Fremove_list_of_text_properties): Remove decls.
4878 * keyboard.c (Fthis_command_keys): Remove decl.
4879 (Fcommand_execute): New forward static decl.
4880 * keymap.c (Flookup_key): New forward static decl.
4881 (Fcopy_keymap): Now static.
4882 * keymap.h (Flookup_key): Remove decl.
4883 * process.c (Fget_process): New forward static decl.
4884 (Fprocess_datagram_address): Mark as internal.
4885 * syntax.c (Fsyntax_table_p): New forward static decl.
4886 (skip_chars): Remove duplicate decl.
4887 * textprop.c (Fprevious_property_change): New forward static decl.
4888 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4889 Now internal.
4890 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4891 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4892
4893 * editfns.c (Fformat): Remove unreachable code.
4894
4895 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4896
4897 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4898 change. (Bug#8496)
4899
4900 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4901
4902 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4903 when at ZV. (Bug#8487)
4904
4905 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4906
4907 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4908 (Bug#8437)
4909 * keyboard.c (parse_tool_bar_item): Likewise.
4910 * sound.c (sound_cleanup, alsa_close): Likewise.
4911 * termcap.c (tgetent): Likewise.
4912 * xfns.c (x_default_font_parameter): Likewise.
4913 * xsettings.c (read_and_apply_settings): Likewise.
4914
4915 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4916 (overrun_check_free): Protoize.
4917
4918 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4919
4920 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4921 since callers should never pass a negative size.
4922 Change the signature to match that of plain 'read' and 'write'; see
4923 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4924 * lisp.h: Update prototypes of emacs_write and emacs_read.
4925
4926 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4927
4928 * xdisp.c (redisplay_window): Don't try to determine the character
4929 position of the scroll margin if the window start point w->startp
4930 is outside the buffer's accessible region. (Bug#8468)
4931
4932 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4933
4934 Fix write-region and its subroutines for buffers > 2GB.
4935 * fileio.c (a_write, e_write): Modify declaration of arguments and
4936 local variables to support buffers larger than 2GB.
4937 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4938
4939 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4940 argument, local variables, and return value.
4941
4942 * lisp.h: Update prototypes of emacs_write and emacs_read.
4943
4944 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4945
4946 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4947
4948 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4949
4950 Fix more problems found by GCC 4.6.0's static checks.
4951
4952 * xdisp.c (vmessage): Use a better test for character truncation.
4953
4954 * charset.c (load_charset_map): <, not <=, for optimization,
4955 and to avoid potential problems with integer overflow.
4956 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4957 * casetab.c (set_identity, shuffle): Likewise.
4958 * editfns.c (Fformat): Likewise.
4959 * syntax.c (skip_chars): Likewise.
4960
4961 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4962 This also lets GCC 4.6.0 generate slightly better loop code.
4963
4964 * callint.c (Fcall_interactively): <, not <=, for optimization.
4965 (Fcall_interactively): Count the number of arguments produced,
4966 not the number of arguments given. This is simpler and lets GCC
4967 4.6.0 generate slightly better code.
4968
4969 * ftfont.c: Distingish more carefully between FcChar8 and char.
4970 The previous code passed unsigned char * to a functions like
4971 strlen and xstrcasecmp that expect char *, which does not
4972 conform to the C standard.
4973 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4974 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4975 char * when the C standard requires it.
4976
4977 * keyboard.c (read_char): Remove unused var.
4978
4979 * eval.c: Port to Windows vsnprintf (Bug#8435).
4980 Include <limits.h>.
4981 (SIZE_MAX): Define if the headers do not.
4982 (verror): Do not give up if vsnprintf returns a negative count.
4983 Instead, grow the buffer. This ports to Windows vsnprintf, which
4984 does not conform to C99. Problem reported by Eli Zaretskii.
4985 Also, simplify the allocation scheme, by avoiding the need for
4986 calling realloc, and removing the ALLOCATED variable.
4987
4988 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4989
4990 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4991 But keep the doprint source code for now, as we might revamp it
4992 and use it again (Bug#8435).
4993 * lisp.h (doprnt): Remove.
4994 * Makefile.in (base_obj): Remove doprnt.o.
4995 * deps.mk (doprnt.o): Remove.
4996
4997 error: Print 32- and 64-bit integers portably (Bug#8435).
4998 Without this change, on typical 64-bit hosts error ("...%d...", N)
4999 was used to print both 32- and 64-bit integers N, which relied on
5000 undefined behavior.
5001 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5002 New macro.
5003 * lisp.h (error, verror): Mark as printf-like functions.
5004 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5005 Report overflow in size calculations when allocating printf buffer.
5006 Do not truncate output string at its first null byte.
5007 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5008 Truncate the output at a character boundary, since vsnprintf does not
5009 do that.
5010 * charset.c (check_iso_charset_parameter): Convert internal
5011 character to string before calling 'error', since %c now has the
5012 printf meaning.
5013 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5014 overflow when computing char to be passed to 'error'. Do not
5015 pass Lisp_Object to 'error'; pass the integer instead.
5016 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5017 formatted with plain %d.
5018
5019 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5020
5021 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5022
5023 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5024
5025 * xterm.c (x_catch_errors): Remove duplicate declaration.
5026
5027 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5028
5029 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5030
5031 2011-04-10 Jim Meyering <meyering@redhat.com>
5032
5033 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5034 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5035 return ssize_t not "int", and use size_t as the buffer length.
5036 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5037 * gnutls.h: Update declarations.
5038 * process.c (read_process_output): Use ssize_t, to match.
5039 (send_process): Likewise.
5040
5041 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5042
5043 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5044
5045 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5046
5047 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5048 Use unsigned char, to match FcChar8 type definition.
5049
5050 * xterm.c (handle_one_xevent):
5051 * xmenu.c (create_and_show_popup_menu):
5052 * xselect.c (x_decline_selection_request)
5053 (x_reply_selection_request): Avoid type-punned deref of X events.
5054
5055 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5056
5057 Fix some uses of `int' instead of EMACS_INT.
5058 * search.c (string_match_1, fast_string_match)
5059 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5060 (scan_buffer, find_next_newline_no_quit)
5061 (find_before_next_newline, search_command, Freplace_match)
5062 (Fmatch_data): Make some `int' variables be EMACS_INT.
5063
5064 * xdisp.c (display_count_lines): 3rd argument and return value now
5065 EMACS_INT. All callers changed.
5066 (pint2hrstr): Last argument is now EMACS_INT.
5067
5068 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5069 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5070 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5071 (decode_coding_utf_16, decode_coding_emacs_mule)
5072 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5073 (decode_coding_ccl, decode_coding_charset)
5074 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5075 (decode_coding_iso_2022, decode_coding_emacs_mule)
5076 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5077 <char_offset, last_offset>: Declare EMACS_INT.
5078 (encode_coding_utf_8, encode_coding_utf_16)
5079 (encode_coding_emacs_mule, encode_invocation_designation)
5080 (encode_designation_at_bol, encode_coding_iso_2022)
5081 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5082 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5083 Declare EMACS_INT.
5084 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5085 (encode_invocation_designation): Last argument P_NCHARS is now
5086 EMACS_INT.
5087 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5088 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5089
5090 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5091 All users changed.
5092
5093 * ccl.c (Fccl_execute_on_string): Declare some variables
5094 EMACS_INT.
5095
5096 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5097
5098 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5099
5100 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5101
5102 * process.c (Fformat_network_address): Doc fix.
5103
5104 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5105
5106 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5107
5108 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5109
5110 * keyboard.c (read_char): Call Lisp function help-form-show,
5111 instead of using internal_with_output_to_temp_buffer.
5112 (Qhelp_form_show): New var.
5113 (syms_of_keyboard): Use DEFSYM macro.
5114
5115 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5116
5117 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5118
5119 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5120
5121 * process.c (Flist_processes): Remove to Lisp.
5122 (list_processes_1): Delete.
5123
5124 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5125
5126 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5127
5128 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5129
5130 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5131
5132 Fix more problems found by GCC 4.6.0's static checks.
5133
5134 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5135
5136 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5137
5138 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5139
5140 * xdisp.c (vmessage): Mark as a printf-like function.
5141
5142 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5143
5144 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5145
5146 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5147 printf-like functions.
5148 (tiff_load): Add casts to remove these marks before passing them
5149 to system-supplied API.
5150
5151 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5152
5153 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5154 This avoids several warnings with gcc -Wstrict-overflow.
5155 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5156 directly, rather than having caller test rule sign. This avoids
5157 some unnecessary tests.
5158 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5159 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5160 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5161
5162 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5163 (xfont_open): Avoid unnecessary tests.
5164
5165 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5166
5167 * composite.h, composite.c (composition_gstring_put_cache):
5168 Use EMACS_INT, not int, for length.
5169
5170 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5171 breaking out part of COMPOSITION_DECODE_RULE.
5172 (COMPOSITION_DECODE_RULE): Use it.
5173 * composite.c (get_composition_id): Remove unused local vars,
5174 by using the new macro.
5175
5176 * textprop.c (set_text_properties_1): Change while to do-while,
5177 since the condition is always true at first.
5178
5179 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5180 (interval_deletion_adjustment): Return unsigned value.
5181 All uses changed.
5182
5183 * process.c (list_processes_1, create_pty, read_process_output):
5184 (exec_sentinel): Remove vars that were set but not used.
5185 (create_pty): Remove unnecessary "volatile"s.
5186 (Fnetwork_interface_info): Avoid possibility of int overflow.
5187 (read_process_output): Do adaptive read buffering even if carryover.
5188 (read_process_output): Simplify nbytes computation if buffered.
5189
5190 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5191
5192 * syntax.c (scan_words): Remove var that was set but not used.
5193 (update_syntax_table): Use unsigned instead of int.
5194
5195 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5196 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5197 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5198
5199 * print.c (print_error_message): Avoid int overflow.
5200
5201 * font.c (font_list_entities): Redo for clarity,
5202 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5203
5204 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5205 (font_score): Avoid potential overflow in diff calculation.
5206
5207 * fns.c (substring_both): Remove var that is set but not used.
5208 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5209
5210 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5211
5212 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5213 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5214 can always succeed if overflow has undefined behavior.
5215
5216 * search.c (boyer_moore, wordify): Remove vars set but not used.
5217 (wordify): Omit three unnecessary tests.
5218
5219 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5220 All callers changed. This avoids the need for an unused var.
5221
5222 * casefiddle.c (casify_region): Remove var that is set but not used.
5223
5224 * dired.c (file_name_completion): Remove var that is set but not used.
5225
5226 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5227
5228 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5229 (Finsert_file_contents): Remove unnecessary code checking fd.
5230
5231 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5232 Check for integer overflow on size calculations.
5233
5234 * buffer.c (Fprevious_overlay_change): Remove var that is set
5235 but not used.
5236
5237 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5238 Remove vars that are set but not used.
5239 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5240 (timer_check_2): Mark vars as initialized.
5241
5242 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5243
5244 * image.c (lookup_image): Remove var that is set but not used.
5245 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5246
5247 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5248 that are set but not used.
5249
5250 * xfns.c (make_invisible_cursor): Don't return garbage
5251 if XCreateBitmapFromData fails (Bug#8410).
5252
5253 * xselect.c (x_get_local_selection, x_handle_property_notify):
5254 Remove vars that are set but not used.
5255
5256 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5257 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5258
5259 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5260 Remove var that is set but not used.
5261 (scroll_bar_windows_size): Now size_t, not int.
5262 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5263 Check for overflow.
5264
5265 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5266 (map_tty_color) [!defined MSDOS]: Likewise.
5267
5268 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5269
5270 * coding.c: Remove vars that are set but not used.
5271 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5272 All callers changed.
5273 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5274 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5275 (decode_coding_charset): Remove vars that are set but not used.
5276
5277 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5278 that is set but not used.
5279
5280 * print.c (print_object): Remove var that is set but not used.
5281
5282 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5283 The gnulib version avoids calling malloc in the usual case,
5284 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5285 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5286 * filelock.c (current_lock_owner): Likewise.
5287 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5288 * sysdep.c: Include allocator.h, careadlinkat.h.
5289 (emacs_no_realloc_allocator): New static constant.
5290 (emacs_readlink): New function.
5291 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5292 ../lib/careadlinkat.h.
5293
5294 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5295
5296 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5297 first non-nil return value).
5298
5299 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5300
5301 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5302 if not defined (Bug#8403).
5303
5304 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5305
5306 * xdisp.c (display_count_lines): Remove parameter `start',
5307 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5308 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5309 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5310 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5311 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5312 and thereabouts. All callers changed.
5313 (get_per_char_metric): Remove parameter `f', unused since
5314 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5315
5316 2011-04-02 Jim Meyering <meyering@redhat.com>
5317
5318 do not dereference NULL upon failed strdup
5319 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5320 (ns_get_family): Likewise.
5321
5322 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5323
5324 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5325
5326 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5327
5328 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5329 later (Bug#8403).
5330
5331 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5332
5333 Add lexical binding.
5334
5335 * window.c (Ftemp_output_buffer_show): New fun.
5336 (Fsave_window_excursion):
5337 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5338
5339 * lread.c (lisp_file_lexically_bound_p): New function.
5340 (Fload): Bind Qlexical_binding.
5341 (readevalloop): Remove `evalfun' arg.
5342 Bind Qinternal_interpreter_environment.
5343 (Feval_buffer): Bind Qlexical_binding.
5344 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5345 Mark as dynamic.
5346 (syms_of_lread): Declare `lexical-binding'.
5347
5348 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5349
5350 * keyboard.c (eval_dyn): New fun.
5351 (menu_item_eval_property): Use it.
5352
5353 * image.c (parse_image_spec): Use Ffunctionp.
5354
5355 * fns.c (concat, mapcar1): Accept byte-code-functions.
5356
5357 * eval.c (Fsetq): Handle lexical vars.
5358 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5359 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5360 (FletX, Flet): Obey lexical binding.
5361 (Fcommandp): Handle closures.
5362 (Feval): New `lexical' arg.
5363 (eval_sub): New function extracted from Feval. Use it almost
5364 everywhere where Feval was used. Look up vars in lexical env.
5365 Handle closures.
5366 (Ffunctionp): Move from subr.el.
5367 (Ffuncall): Handle closures.
5368 (apply_lambda): Remove `eval_flags'.
5369 (funcall_lambda): Handle closures and new byte-code-functions.
5370 (Fspecial_variable_p): New function.
5371 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5372 but without exporting it to Lisp.
5373
5374 * doc.c (Fdocumentation, store_function_docstring):
5375 * data.c (Finteractive_form): Handle closures.
5376
5377 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5378 interactive spec.
5379
5380 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5381 New byte-codes.
5382 (exec_byte_code): New function extracted from Fbyte_code to handle new
5383 calling convention for byte-code-functions. Add new byte-codes.
5384
5385 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5386
5387 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5388
5389 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5390
5391 * xdisp.c (redisplay_internal): Fix prototype.
5392
5393 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5394
5395 * xdisp.c (SCROLL_LIMIT): New macro.
5396 (try_scrolling): Use it when setting scroll_limit.
5397 Limit scrolling to 100 screen lines.
5398 (redisplay_window): Even when falling back on "recentering",
5399 position point in the window according to scroll-conservatively,
5400 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5401
5402 (try_scrolling): When point is above the window, allow searching
5403 as far as scroll_max, or one screenful, to compute vertical
5404 distance from PT to the scroll margin position. This prevents
5405 try_scrolling from unnecessarily failing when
5406 scroll-conservatively is set to a value slightly larger than the
5407 window height. Clean up the case of PT below the margin at bottom
5408 of window: scroll_max can no longer be INT_MAX. When aggressive
5409 scrolling is in use, don't let point enter the opposite scroll
5410 margin as result of the scroll.
5411 (syms_of_xdisp) <scroll-conservatively>: Document the
5412 threshold of 100 lines for never-recentering scrolling.
5413
5414 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5415
5416 * dispextern.h (move_it_by_lines):
5417 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5418 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5419 (message_log_check_duplicate): Remove parameters `prev_bol' and
5420 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5421 (redisplay_internal): Remove parameter `preserve_echo_area',
5422 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5423
5424 * indent.c (Fvertical_motion):
5425 * window.c (window_scroll_pixel_based, Frecenter):
5426 Don't pass `need_y_p' to `move_it_by_lines'.
5427
5428 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5429
5430 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5431 steal a few bits to be more compact.
5432 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5433 Remove unneeded casts.
5434
5435 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5436
5437 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5438
5439 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5440 binding" message (bug#7967).
5441
5442 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5443
5444 Fix more problems found by GCC 4.6.0's static checks.
5445
5446 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5447 Remove unused local var.
5448
5449 * editfns.c (Fmessage_box): Remove unused local var.
5450
5451 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5452 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5453 Omit unused local vars.
5454 * window.c (shrink_windows): Omit unused local var.
5455 * menu.c (digest_single_submenu): Omit unused local var.
5456 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5457 Omit unused local var.
5458
5459 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5460 Don't assume string length fits in int.
5461 (keyremap_step, read_key_sequence): Use size_t for sizes.
5462 (read_key_sequence): Don't check last_real_key_start redundantly.
5463
5464 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5465 instead of alloca (Bug#8344).
5466
5467 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5468 (Fbacktrace_frame): Don't assume nframes fits in int.
5469
5470 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5471
5472 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5473 concerns.
5474
5475 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5476
5477 * cm.c (calccost): Turn while-do into do-while, for clarity.
5478
5479 * keyboard.c (syms_of_keyboard): Use the same style as later
5480 in this function when indexing through an array. This also
5481 works around GCC bug 48267.
5482
5483 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5484
5485 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5486
5487 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5488 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5489
5490 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5491 This avoids undefined behavior on integer overflow, and is a bit
5492 more convenient anyway since it is compared to a size_t variable.
5493
5494 Variadic C functions now count arguments with size_t, not int.
5495 This avoids an unnecessary limitation on 64-bit machines, which
5496 caused (substring ...) to crash on large vectors (Bug#8344).
5497 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5498 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5499 All variadic functions and their callers changed accordingly.
5500 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5501 * data.c (arith_driver, float_arith_driver): Likewise.
5502 * editfns.c (general_insert_function): Likewise.
5503 * eval.c (struct backtrace.nargs, interactive_p)
5504 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5505 (funcall_lambda, mark_backtrace): Likewise.
5506 * fns.c (concat): Likewise.
5507 * frame.c (x_set_frame_parameters): Likewise.
5508 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5509 0 if not found, not -1. All callers changed.
5510
5511 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5512 (stack_copy_size): Now size_t, not int.
5513 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5514
5515 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5516
5517 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5518 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5519 All callers changed.
5520
5521 * lisp.h (multibyte_char_to_unibyte):
5522 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5523 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5524 * character.h (CHAR_TO_BYTE8):
5525 * cmds.c (internal_self_insert):
5526 * editfns.c (general_insert_function):
5527 * keymap.c (push_key_description):
5528 * search.c (Freplace_match):
5529 * xdisp.c (message_dolog, set_message_1): All callers changed.
5530
5531 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5532
5533 * keyboard.c (safe_run_hook_funcall): New function.
5534 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5535 don't set the hook to nil, but remove the offending function instead.
5536 (Qcommand_hook_internal): Remove, unused.
5537 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5538 Vcommand_hook_internal.
5539
5540 * eval.c (enum run_hooks_condition): Remove.
5541 (funcall_nil, funcall_not): New functions.
5542 (run_hook_with_args): Call each function through a `funcall' argument.
5543 Remove `cond' argument, now redundant.
5544 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5545 (Frun_hook_with_args_until_failure): Adjust accordingly.
5546 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5547
5548 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5549
5550 * dispextern.h (string_buffer_position): Remove declaration.
5551
5552 * print.c (strout): Remove parameter `multibyte', unused since
5553 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5554
5555 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5556 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5557 All callers changed.
5558
5559 * w32.c (_wsa_errlist): Use braces for struct initializers.
5560
5561 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5562 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5563 All callers changed.
5564 (string_buffer_position): Likewise. Also, make static (it's never
5565 used outside xdisp.c).
5566 (cursor_row_p): Remove parameter `w', unused since
5567 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5568 (decode_mode_spec): Remove parameter `precision', introduced during
5569 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5570 All callers changed.
5571
5572 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5573
5574 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5575
5576 2011-03-27 Anders Lindgren <andlind@gmail.com>
5577
5578 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5579 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5580 (ns_update_auto_hide_menu_bar): New functions.
5581 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5582 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5583 ns_constrain_all_frames.
5584 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5585 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5586
5587 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5588
5589 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5590
5591 2011-03-27 Glenn Morris <rgm@gnu.org>
5592
5593 * syssignal.h: Replace RETSIGTYPE with void.
5594 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5595 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5596 Replace SIGTYPE with void everywhere.
5597 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5598 * s/template.h (SIGTYPE): Remove commented out definition.
5599
5600 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5601
5602 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5603 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5604
5605 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5606
5607 * w32.c (read_unc_volume): Use parameter `henum', instead of
5608 global variable `wget_enum_handle'.
5609
5610 * keymap.c (describe_vector): Remove parameters `indices' and
5611 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5612 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5613
5614 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5615
5616 * keyboard.c (timer_check): Remove parameter `do_it_now',
5617 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5618 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5619 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5620
5621 * keyboard.c (read_char):
5622 * w32menu.c (w32_menu_display_help):
5623 * xmenu.c (show_help_event, menu_help_callback):
5624 Adjust calls to `show_help_echo'.
5625
5626 * gtkutil.c (xg_maybe_add_timer):
5627 * keyboard.c (readable_events):
5628 * process.c (wait_reading_process_output):
5629 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5630
5631 * insdel.c (adjust_markers_gap_motion):
5632 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5633 (gap_left, gap_right): Don't call it.
5634
5635 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5636
5637 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5638 incurred during fontification.
5639
5640 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5641
5642 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5643 (DEFVAR_PER_BUFFER): Don't pass it.
5644
5645 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5646 (scrolling_window): Don't pass it.
5647
5648 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5649
5650 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5651
5652 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5653 and `suffix'.
5654 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5655 of variables specific to SELinux and computation of `encoded_absname'.
5656
5657 * image.c (XPutPixel): Remove unused variable `height'.
5658
5659 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5660
5661 * unexw32.c (get_section_info): Remove unused variable `section'.
5662
5663 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5664 (system_process_attributes): Remove unused variable `sess'.
5665 (sys_read): Remove unused variable `err'.
5666
5667 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5668 (w32_wnd_proc): Remove unused variable `isdead'.
5669 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5670 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5671 (x_create_tip_frame): Remove unused variable `tem'.
5672
5673 * w32inevt.c (w32_console_read_socket):
5674 Remove unused variable `no_events'.
5675
5676 * w32term.c (x_draw_composite_glyph_string_foreground):
5677 Remove unused variable `width'.
5678
5679 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5680
5681 * w32term.c (x_set_glyph_string_clipping):
5682 Don't pass uninitialized region to CombineRgn.
5683
5684 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5685
5686 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5687 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5688 (Fx_close_connection): Remove unused variable `i'.
5689
5690 * w32font.c (w32font_draw): Return number of glyphs.
5691 (w32font_open_internal): Remove unused variable `i'.
5692 (w32font_driver): Add missing initializer.
5693
5694 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5695 (fill_in_menu): Remove unused variable `items_added'.
5696
5697 * w32term.c (last_mouse_press_frame): Remove static global variable.
5698 (w32_clip_to_row): Remove unused variable `f'.
5699 (x_delete_terminal): Remove unused variable `i'.
5700
5701 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5702 (NOTHING): Remove unused static global variable.
5703 (uniscribe_check_otf): Remove unused variable `table'.
5704 (uniscribe_font_driver): Add missing initializers.
5705
5706 2011-03-23 Julien Danjou <julien@danjou.info>
5707
5708 * term.c (Fsuspend_tty, Fresume_tty):
5709 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5710 * window.c (temp_output_buffer_show):
5711 * insdel.c (signal_before_change):
5712 * frame.c (Fhandle_switch_frame):
5713 * fileio.c (Fdo_auto_save):
5714 * emacs.c (Fkill_emacs):
5715 * editfns.c (save_excursion_restore):
5716 * cmds.c (internal_self_insert):
5717 * callint.c (Fcall_interactively):
5718 * buffer.c (Fkill_all_local_variables):
5719 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5720 Use Frun_hooks.
5721 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5722 unconditionnaly since it does the check itself.
5723
5724 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5725
5726 Fix more problems found by GCC 4.5.2's static checks.
5727
5728 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5729 the first time through the loop, since we know p0 < p1 then.
5730 This also avoids a gcc -Wstrict-overflow warning.
5731
5732 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5733 leading to a memory leak, possible in functions like
5734 load_charset_map_from_file that can allocate an unbounded number
5735 of objects (Bug#8318).
5736
5737 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5738 that could (at least in theory) be that large.
5739
5740 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5741 This is less likely to overflow, and avoids undefined behavior if
5742 overflow does occur. All callers changed. Use strtoul to scan
5743 for the unsigned long integer.
5744 (pint2hrstr): Simplify and tune code slightly.
5745 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5746
5747 * scroll.c (do_scrolling): Work around GCC bug 48228.
5748 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5749
5750 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5751 This also avoids a warning with gcc -Wstrict-overflow.
5752 (validate_x_resource_name): Simplify count usage.
5753 This also avoids a warning with gcc -Wstrict-overflow.
5754
5755 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5756 fail (Bug#8306).
5757
5758 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5759
5760 * process.c (Fmake_network_process): Use socklen_t, not int,
5761 where POSIX says socklen_t is required in portable programs.
5762 This fixes a porting bug on hosts like 64-bit HP-UX, where
5763 socklen_t is wider than int (Bug#8277).
5764 (Fmake_network_process, server_accept_connection):
5765 (wait_reading_process_output, read_process_output):
5766 Likewise.
5767
5768 * process.c: Rename or move locals to avoid shadowing.
5769 (list_processes_1, Fmake_network_process):
5770 (read_process_output_error_handler, exec_sentinel_error_handler):
5771 Rename or move locals.
5772 (Fmake_network_process): Define label "retry_connect" only if needed.
5773 (Fnetwork_interface_info): Fix pointer signedness.
5774 (process_send_signal): Add cast to avoid pointer signedness problem.
5775 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5776 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5777
5778 Make tparam.h and terminfo.c consistent.
5779 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5780 Include tparam.h instead, since it declares them.
5781 * cm.h (PC): Remove extern decl; tparam.h now does this.
5782 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5783 * terminfo.c: Include tparam.h, to check interfaces.
5784 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5785 (tparam): Adjust signature to match interface in tparam.h;
5786 this removes some undefined behavior. Check that outstring and len
5787 are zero, which they always are with Emacs.
5788 * tparam.h (PC, BC, UP): New extern decls.
5789
5790 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5791 (xftfont_open): Rename locals to avoid shadowing.
5792
5793 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5794 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5795 (OTF_TAG_SYM): Omit macro if not needed.
5796 (ftfont_list): Remove unused local.
5797 (get_adstyle_property, ftfont_pattern_entity):
5798 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5799 Rename locals to avoid shadowing.
5800
5801 * xfont.c (xfont_list_family): Mark var as initialized.
5802
5803 * xml.c (make_dom): Now static.
5804
5805 * composite.c (composition_compute_stop_pos): Rename local to
5806 avoid shadowing.
5807 (composition_reseat_it): Remove unused locals.
5808 (find_automatic_composition, composition_adjust_point): Likewise.
5809 (composition_update_it): Mark var as initialized.
5810 (find_automatic_composition): Mark vars as initialized,
5811 with a FIXME (Bug#8290).
5812
5813 character.h: Rename locals to avoid shadowing.
5814 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5815 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5816 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5817 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5818 to avoid shadowing.
5819
5820 * textprop.c (property_change_between_p): Remove; unused.
5821
5822 * intervals.c (interval_start_pos): Now static.
5823
5824 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5825
5826 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5827 Rename locals to avoid shadowing.
5828
5829 * sound.c (wav_play, au_play, Fplay_sound_internal):
5830 Fix pointer signedness.
5831 (alsa_choose_format): Remove unused local var.
5832 (wav_play): Initialize a variable to 0, to prevent undefined
5833 behavior (Bug#8278).
5834
5835 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5836
5837 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5838
5839 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5840 clobbering (Bug#8298).
5841 * sysdep.c (sys_subshell): Likewise.
5842 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5843
5844 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5845 This should get cleaned up, so that child_setup has the
5846 same signature on all platforms.
5847
5848 * callproc.c (call_process_cleanup): Now static.
5849 (relocate_fd): Rename locals to avoid shadowing.
5850
5851 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5852
5853 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5854 not to be necessary, and produces flickering.
5855
5856 2011-03-20 Glenn Morris <rgm@gnu.org>
5857
5858 * config.in: Remove file.
5859
5860 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5861
5862 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5863 are now in src/globals.h.
5864 (syms_of_minibuf): Remove spurious & from previous change.
5865
5866 2011-03-20 Leo <sdl.web@gmail.com>
5867
5868 * minibuf.c (completing-read-function): New variable.
5869 (completing-read-default): Rename from completing-read.
5870 (completing-read): Call completing-read-function.
5871
5872 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5873
5874 * xfaces.c (Fx_load_color_file):
5875 Read color file from absolute filename (bug#8250).
5876
5877 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5878
5879 * makefile.w32-in: Update dependencies.
5880
5881 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5882
5883 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5884
5885 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5886
5887 Fix more problems found by GCC 4.5.2's static checks.
5888
5889 * process.c (make_serial_process_unwind, send_process_trap):
5890 (sigchld_handler): Now static.
5891
5892 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5893 That way, the code declares only the vars that it needs.
5894 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5895 * s/cygwin.h (PTY_ITERATION): Likewise.
5896 * s/darwin.h (PTY_ITERATION): Likewise.
5897 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5898
5899 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5900 * process.c (allocate_pty): Don't declare stb unless it's needed.
5901
5902 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5903 (CONSTANTLIM): Remove; unused.
5904 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5905 Define only if needed.
5906
5907 * unexelf.c (unexec): Name an expression,
5908 to avoid gcc -Wbad-function-cast warning.
5909 Use a different way to cause a compilation error if anyone uses
5910 n rather than nn, a way that does not involve shadowing.
5911 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5912
5913 * deps.mk (unexalpha.o): Remove; unused.
5914
5915 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5916 * unexec.h: New file.
5917 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5918 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5919 Depend on unexec.h.
5920 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5921 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5922 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5923 Change as necessary to match prototype in unexec.h.
5924
5925 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5926 shadowing.
5927 (back_comment, skip_chars): Mark vars as initialized.
5928
5929 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5930 Rename locals to avoid shadowing.
5931
5932 * lread.c (read1): Rewrite so as not to use empty "else".
5933 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5934
5935 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5936
5937 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5938 warning when compiling print.c.
5939
5940 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5941 instead of using an uninitialized var.
5942 (font_sort_entities): Mark var as initialized.
5943
5944 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5945
5946 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5947 pointers to constants.
5948 (font_parse_fcname): Remove unused vars.
5949 (font_delete_unmatched): Now static.
5950 (font_get_spec): Remove; unused.
5951 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5952 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5953 Rename or move locals to avoid shadowing.
5954
5955 * fns.c (require_nesting_list, require_unwind): Now static.
5956 (Ffillarray): Rename locals to avoid shadowing.
5957
5958 * floatfns.c (domain_error2): Define only if needed.
5959 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5960
5961 * alloc.c (mark_backtrace): Move decl from here ...
5962 * lisp.h: ... to here, so that it can be checked.
5963
5964 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5965 (Fdefvar): Rewrite so as not to use empty "else".
5966 (lisp_indirect_variable): Name an expression,
5967 to avoid gcc -Wbad-function-cast warning.
5968 (Fdefvar): Rename locals to avoid shadowing.
5969
5970 * callint.c (quotify_arg, quotify_args): Now static.
5971 (Fcall_interactively): Rename locals to avoid shadowing.
5972 Use const pointer when appropriate.
5973
5974 * lisp.h (get_system_name, get_operating_system_release):
5975 Move decls here, to check interfaces.
5976 * process.c (get_operating_system_release): Move decl to lisp.h.
5977 * xrdb.c (get_system_name): Likewise.
5978 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5979 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5980 some of which prompt warnings from gcc -Wbad-function-cast.
5981 (Fformat_time_string, Fencode_time, Finsert_char):
5982 (Ftranslate_region_internal, Fformat):
5983 Rename or remove local vars to avoid shadowing.
5984 (Ftranslate_region_internal): Mark var as initialized.
5985
5986 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5987 avoid shadowing.
5988
5989 * lisp.h (eassert): Check that the argument compiles, even if
5990 ENABLE_CHECKING is not defined.
5991
5992 * data.c (Findirect_variable): Name an expression, to avoid
5993 gcc -Wbad-function-cast warning.
5994 (default_value, arithcompare, arith_driver, arith_error): Now static.
5995 (store_symval_forwarding): Rename local to avoid shadowing.
5996 (Fmake_variable_buffer_local, Fmake_local_variable):
5997 Mark variables as initialized.
5998 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5999
6000 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6001 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6002 Rename locals to avoid shadowing.
6003 (mark_stack): Move local variables into the #ifdef region where
6004 they're used.
6005 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6006 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6007 needed otherwise.
6008 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6009 (GC_STRING_CHARS): Remove; not used.
6010 (Fmemory_limit): Cast sbrk's returned value to char *.
6011
6012 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6013 avoids undefined behavior in theory.
6014
6015 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6016
6017 Use functions, not macros, for up- and down-casing (Bug#8254).
6018 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6019 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6020 to use the following functions instead of these macros.
6021 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6022 EMACS_INT, since callers assume the returned value fits in int.
6023 (upcase1): Likewise, for UPCASE_TABLE.
6024 (uppercasep, lowercasep, upcase): New static inline functions.
6025 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6026 the race-condition problem in the old DOWNCASE.
6027
6028 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6029 Rename locals to avoid shadowing.
6030 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6031 (regex_compile, re_search_2, re_match_2_internal):
6032 Remove unused local vars.
6033 (FREE_VAR): Rewrite so as not to use empty "else",
6034 which gcc can warn about.
6035 (regex_compile, re_match_2_internal): Mark locals as initialized.
6036 (RETALLOC_IF): Define only if needed.
6037 (WORDCHAR_P): Likewise. This one is never needed, but is used
6038 only in a comment talking about a compiler bug, so put inside
6039 the #if 0 of that comment.
6040 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6041 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6042 Remove; unused.
6043
6044 * search.c (boyer_moore): Rename locals to avoid shadowing.
6045 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6046 (PREV_CHAR_BOUNDARY): Likewise.
6047
6048 * search.c (simple_search): Remove unused var.
6049
6050 * dired.c (compile_pattern): Move decl from here ...
6051 * lisp.h: ... to here, so that it can be checked.
6052 (struct re_registers): New forward decl.
6053
6054 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6055
6056 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6057 All uses changed.
6058 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6059 Rename locals to avoid shadowing.
6060 (Fvertical_motion): Mark locals as initialized.
6061
6062 * casefiddle.c (casify_object, casify_region): Now static.
6063 (casify_region): Mark local as initialized.
6064
6065 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6066
6067 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6068 New macros, so that the caller can use some names other than
6069 gcpro1, gcpro2, etc.
6070 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6071 of the new macros.
6072 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6073 argument, for consistency with GCPRO2_VAR, etc: it is now the
6074 prefix of the variable, not the variable itself. All uses
6075 changed.
6076 * dired.c (directory_files_internal, file_name_completion):
6077 Rename locals to avoid shadowing.
6078
6079 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6080 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6081 dired.c's scmp function, had undefined behavior.
6082 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6083 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6084 * buffer.h: ... to here, because these macros use current_buffer,
6085 and the new implementation with inline functions needs to have
6086 current_buffer in scope now, rather than later when the macros
6087 are used.
6088 (downcase, upcase1): New static inline functions.
6089 (DOWNCASE, UPCASE1): Reimplement using these functions.
6090 This avoids undefined behavior in expressions like
6091 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6092 from race conditions in accessing the global variables
6093 case_temp1 and case_temp2.
6094 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6095 * lisp.h (case_temp1, case_temp2): Remove their decls.
6096 * character.h (ASCII_CHAR_P): Move from here ...
6097 * lisp.h: ... to here, so that the inline functions mentioned
6098 above can use them.
6099
6100 * dired.c (directory_files_internal_unwind): Now static.
6101
6102 * fileio.c (file_name_as_directory, directory_file_name):
6103 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6104 Now static.
6105 (file_name_as_directory): Use const pointers when appropriate.
6106 (Fexpand_file_name): Likewise. In particular, newdir might
6107 point at constant storage, so make it a const pointer.
6108 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6109 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6110 signedness issues.
6111 (Fset_file_times, Finsert_file_contents, auto_save_error):
6112 Rename locals to avoid shadowing.
6113
6114 * minibuf.c (choose_minibuf_frame_1): Now static.
6115 (Ftry_completion, Fall_completions): Rename or remove locals
6116 to avoid shadowing.
6117
6118 * marker.c (bytepos_to_charpos): Remove; unused.
6119
6120 * lisp.h (verify_bytepos, count_markers): New decls,
6121 so that gcc does not warn that these functions aren't declared.
6122
6123 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6124 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6125 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6126 (copy_text): Remove unused local var.
6127
6128 * filelock.c (within_one_second): Now static.
6129 (lock_file_1): Rename local to avoid shadowing.
6130
6131 * buffer.c (fix_overlays_before): Mark locals as initialized.
6132 (fix_start_end_in_overlays): Likewise. This function should be
6133 simplified by using pointers-to-pointers, but that's a different
6134 matter.
6135 (switch_to_buffer_1): Now static.
6136 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6137 (report_overlay_modification): Rename locals to avoid shadowing.
6138
6139 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6140 Fix pointer signedness issue.
6141 (sys_subshell): Mark local as volatile if checking for lint,
6142 to suppress a gcc -Wclobbered warning that does not seem to be right.
6143 (MAXPATHLEN): Define only if needed.
6144
6145 * process.c (serial_open, serial_configure): Move decls from here ...
6146 * systty.h: ... to here, so that they can be checked.
6147
6148 * fns.c (get_random, seed_random): Move extern decls from here ...
6149 * lisp.h: ... to here, so that they can be checked.
6150
6151 * sysdep.c (reset_io): Now static.
6152 (wait_for_termination_signal): Remove; unused.
6153
6154 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6155 (copy_keymap_item, append_key, push_text_char_description):
6156 Now static.
6157 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6158 (DENSE_TABLE_SIZE): Remove; unused.
6159 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6160 (describe_map_tree):
6161 Rename locals to avoid shadowing.
6162
6163 * keyboard.c: Declare functions static if they are not used elsewhere.
6164 (echo_char, echo_dash, cmd_error, top_level_2):
6165 (poll_for_input, handle_async_input): Now static.
6166 (read_char, kbd_buffer_get_event, make_lispy_position):
6167 (make_lispy_event, make_lispy_movement, apply_modifiers):
6168 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6169 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6170 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6171 (read_key_sequence, read_char): Mark locals as initialized.
6172 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6173
6174 * keyboard.h (make_ctrl_char): New decl.
6175 (mark_kboards): Move decl here ...
6176 * alloc.c (mark_kboards): ... from here.
6177
6178 * lisp.h (force_auto_save_soon): New decl.
6179
6180 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6181 (DEFINE_DUMMY_FUNCTION): New macro.
6182 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6183 Use it.
6184 (main): Add casts to avoid warnings
6185 if GCC considers string literals to be constants.
6186
6187 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6188
6189 * dbusbind.c: Pointer signedness fixes.
6190 (xd_signature, xd_append_arg, xd_initialize):
6191 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6192 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6193 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6194 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6195
6196 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6197 if GCC considers string literals to be constants.
6198 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6199
6200 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6201
6202 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6203 (print_preprocess, print_object): New macro to fix last change.
6204
6205 * print.c (print_preprocess): Don't forget font objects.
6206
6207 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6208
6209 * emacs.c (USAGE3): Doc fixes.
6210
6211 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6212
6213 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6214 structure.
6215
6216 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6217
6218 * lisp.h (VWindow_system, Qfile_name_history):
6219 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6220 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6221 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6222
6223 * w32select.c: Don't #include "keyboard.h".
6224 (run_protected): Add extern declaration for waiting_for_input.
6225
6226 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6227 * w32console.c (detect_input_pending, read_input_pending)
6228 (encode_terminal_code):
6229 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6230 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6231 (w32_system_caret_y, Qfile_name_history):
6232 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6233 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6234 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6235 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6236 * w32proc.c (Qlocal, report_file_error):
6237 * w32term.c (Vwindow_system, updating_frame):
6238 * w32uniscribe.c (initialized, uniscribe_font_driver):
6239 Remove unneeded extern declarations.
6240
6241 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6242
6243 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6244
6245 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6246
6247 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6248 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6249 These macros can no longer be used for assignment.
6250
6251 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6252 Assign struct members directly, instead of using BUF_BEGV etc.
6253 (record_buffer_markers, fetch_buffer_markers): New functions for
6254 recording and fetching special buffer markers.
6255 (set_buffer_internal_1, set_buffer_temp): Use them.
6256
6257 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6258
6259 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6260
6261 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6262 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6263
6264 * xdisp.c (hscroll_window_tree):
6265 (reconsider_clip_changes): Use PT instead of BUF_PT.
6266
6267 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6268
6269 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6270 $(EMACS_ROOT)/lib/intprops.h.
6271
6272 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6273
6274 Fix more problems found by GCC 4.5.2's static checks.
6275
6276 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6277 to unsigned char * to avoid compiler diagnostic.
6278 (xg_free_frame_widgets): Make it clear that a local variable is
6279 needed only if USE_GTK_TOOLTIP.
6280 (gdk_window_get_screen): Make it clear that this macro is needed
6281 only if USE_GTK_TOOLTIP.
6282 (int_gtk_range_get_value): New function, which avoids a diagnostic
6283 from gcc -Wbad-function-cast.
6284 (xg_set_toolkit_scroll_bar_thumb): Use it.
6285 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6286 diagnostic from gcc -Wbad-function-cast.
6287 (get_utf8_string, xg_get_file_with_chooser):
6288 Rename locals to avoid shadowing.
6289 (create_dialog): Move locals to avoid shadowing.
6290
6291 * xgselect.c (xg_select): Remove unused var.
6292
6293 * image.c (four_corners_best): Mark locals as initialized.
6294 (gif_load): Initialize transparent_p to zero (Bug#8238).
6295 Mark another local as initialized.
6296 (my_png_error, my_error_exit): Mark with NO_RETURN.
6297
6298 * image.c (clear_image_cache): Now static.
6299 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6300 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6301 (x_edge_detection): Remove unnecessary cast that
6302 gcc -Wbad-function-cast diagnoses.
6303 (gif_load): Fix pointer signedness.
6304 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6305 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6306
6307 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6308
6309 Improve quality of tests for time stamp overflow.
6310 For example, without this patch (encode-time 0 0 0 1 1
6311 1152921504606846976) returns the obviously-bogus value (-948597
6312 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6313 reports time overflow. See
6314 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6315 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6316 * editfns.c: Include limits.h and intprops.h.
6317 (TIME_T_MIN, TIME_T_MAX): New macros.
6318 (time_overflow): Move earlier, to before first use.
6319 (hi_time, lo_time): New functions, for an accurate test for
6320 out-of-range times.
6321 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6322 (Fget_internal_run_time): Don't assume time_t fits in int.
6323 (make_time): Use list2 instead of Fcons twice.
6324 (Fdecode_time): More accurate test for out-of-range times.
6325 (check_tm_member): New function.
6326 (Fencode_time): Use it, to test for out-of-range times.
6327 (lisp_time_argument): Don't rely on undefined left-shift and
6328 right-shift behavior when checking for time stamp overflow.
6329
6330 * editfns.c (time_overflow): New function, refactoring common code.
6331 (Fformat_time_string, Fdecode_time, Fencode_time):
6332 (Fcurrent_time_string): Use it.
6333
6334 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6335 * dired.c (make_time): Move to ...
6336 * editfns.c (make_time): ... here.
6337 * systime.h: Note the move.
6338
6339 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6340
6341 * fringe.c (update_window_fringes): Remove unused variables.
6342
6343 * unexmacosx.c (copy_data_segment): Also copy __got section.
6344 (Bug#8223)
6345
6346 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6347
6348 * termcap.c [MSDOS]: Include "msdos.h".
6349 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6350 Constify `char *' arguments and their references according to
6351 prototypes in tparam.h.
6352
6353 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6354
6355 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6356 Adapt all references accordingly.
6357
6358 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6359
6360 2011-03-11 Tom Tromey <tromey@redhat.com>
6361
6362 * buffer.c (syms_of_buffer): Remove obsolete comment.
6363
6364 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6365
6366 * termhooks.h (encode_terminal_code): Declare prototype.
6367
6368 * msdos.c (encode_terminal_code): Don't declare prototype.
6369
6370 * term.c (encode_terminal_code): Now external again, used by
6371 w32console.c and msdos.c.
6372
6373 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6374 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6375
6376 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6377
6378 Fix some minor problems found by GCC 4.5.2's static checks.
6379
6380 * fringe.c (update_window_fringes): Mark locals as initialized
6381 (Bug#8227).
6382 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6383
6384 * alloc.c (mark_fringe_data): Move decl from here ...
6385 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6386 to check its interface.
6387 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6388
6389 * fontset.c (free_realized_fontset): Now static.
6390 (Fset_fontset_font): Rename local to avoid shadowing.
6391 (fontset_font): Mark local as initialized.
6392 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6393
6394 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6395
6396 * xselect.c (x_disown_buffer_selections): Remove; not used.
6397 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6398 (x_own_selection, Fx_disown_selection_internal): Rename locals
6399 to avoid shadowing.
6400 (x_handle_dnd_message): Remove local to avoid shadowing.
6401
6402 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6403 so that the caller can use some name other than gcpro1.
6404 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6405 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6406 (Fx_backspace_delete_keys_p):
6407 Use them to avoid shadowing, and rename vars to avoid shadowing.
6408 (x_decode_color, x_set_name, x_window): Now static.
6409 (Fx_create_frame): Add braces to silence GCC warning.
6410 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6411 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6412 Remove unused locals.
6413 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6414 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6415 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6416 macros.
6417
6418 * xterm.h (x_mouse_leave): New decl.
6419
6420 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6421 Remove unused functions.
6422 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6423 (x_calc_absolute_position): Now static.
6424 (XTread_socket): Don't define label "out" unless it's used.
6425 Don't declare local "event" unless it's used.
6426 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6427 unless they are used.
6428 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6429 (x_fatal_error_signal): Remove; not used.
6430 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6431 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6432 (x_error_catcher, x_connection_closed, x_error_handler):
6433 (x_error_quitter, xembed_send_message, x_iconify_frame):
6434 (my_log_handler): Rename locals to avoid shadowing.
6435 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6436 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6437
6438 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6439 Rename or move locals to avoid shadowing.
6440 (tty_defined_color, merge_face_heights): Now static.
6441 (free_realized_faces_for_fontset): Remove; not used.
6442 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6443 does not deduce is never used uninitialized.
6444 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6445 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6446
6447 * terminal.c (store_terminal_param): Now static.
6448
6449 * xmenu.c (menu_highlight_callback): Now static.
6450 (set_frame_menubar): Remove unused local.
6451 (xmenu_show): Rename parameter to avoid shadowing.
6452 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6453 since they might point to immutable storage.
6454 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6455 since it's unused otherwise.
6456
6457 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6458 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6459 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6460 avoids a gcc -Wuninitialized diagnostic.
6461 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6462 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6463 does not deduce are never used uninitialized.
6464
6465 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6466
6467 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6468 * window.c (window_loop, size_window):
6469 (run_window_configuration_change_hook, enlarge_window): Likewise.
6470
6471 * window.c (display_buffer): Now static.
6472 (size_window): Mark variables that gcc -Wuninitialized
6473 does not deduce are never used uninitialized.
6474 * window.h (check_all_windows): New decl, to forestall
6475 gcc -Wmissing-prototypes diagnostic.
6476 * dispextern.h (bidi_dump_cached_states): Likewise.
6477
6478 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6479 shadowing.
6480 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6481 Include <limits.h>.
6482 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6483 and to avoid gcc -Wuninitialized warning.
6484 (load_charset_map): Mark variables that gcc -Wuninitialized
6485 does not deduce are never used uninitialized.
6486 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6487
6488 * coding.c (coding_set_source, coding_set_destination):
6489 Use "else { /* comment */ }" rather than "else /* comment */;"
6490 for clarity, and to avoid gcc -Wempty-body warning.
6491 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6492 a block, when the outer 'i' will do.
6493 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6494 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6495 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6496 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6497 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6498 Rename locals to avoid shadowing.
6499 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6500 * coding.c (emacs_mule_char, encode_invocation_designation):
6501 Now static, since they're not used elsewhere.
6502 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6503 (decode_coding_object, encode_coding_object, detect_coding_system):
6504 (decode_coding_emacs_mule): Mark variables that gcc
6505 -Wuninitialized does not deduce are never used uninitialized.
6506 (detect_coding_iso_2022): Initialize a local variable that might
6507 be used uninitialized. Leave a FIXME because it's not clear that
6508 this initialization is needed. (Bug#8211)
6509 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6510 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6511 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6512 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6513 Remove unused macros.
6514
6515 * category.c (hash_get_category_set): Remove unused local var.
6516 (copy_category_table): Now static, since it's not used elsewhere.
6517 * character.c (string_count_byte8): Likewise.
6518
6519 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6520 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6521
6522 * chartab.c (copy_sub_char_table): Now static, since it's not used
6523 elsewhere.
6524 (sub_char_table_ref_and_range, char_table_ref_and_range):
6525 Rename locals to avoid shadowing.
6526 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6527
6528 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6529 (BIDI_BOB): Remove unused macro.
6530
6531 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6532 deduce are never used uninitialized.
6533 * term.c (encode_terminal_code): Likewise.
6534
6535 * term.c (encode_terminal_code): Now static. Remove unused local.
6536
6537 * tparam.h: New file.
6538 * term.c, tparam.h: Include it.
6539 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6540 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6541 Move these decls to tparam.h, and make them agree with what
6542 is actually in tparam.c. The previous trick of using incompatible
6543 decls in different modules does not conform to the C standard.
6544 All callers of tparam changed to use tparam's actual API.
6545 * tparam.c (tparam1, tparam, tgoto):
6546 Use const pointers where appropriate.
6547
6548 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6549 * cm.h (struct cm): Likewise.
6550 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6551 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6552 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6553 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6554 (turn_on_face, init_tty): Likewise.
6555 * termchar.h (struct tty_display_info): Likewise.
6556
6557 * term.c (term_mouse_position): Rename local to avoid shadowing.
6558
6559 * alloc.c (mark_ttys): Move decl from here ...
6560 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6561
6562 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6563
6564 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6565
6566 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6567
6568 * search.c (compile_pattern_1): Remove argument regp, unused since
6569 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6570 (compile_pattern): Don't pass it.
6571
6572 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6573
6574 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6575 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6576 for ! HAVE_GTK3.
6577 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6578
6579 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6580
6581 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6582 gdk_window_get_screen, gdk_window_get_geometry,
6583 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6584 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6585 (xg_get_pixbuf_from_pixmap): New function.
6586 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6587 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6588 Call xg_get_pixbuf_from_pixmap instead of
6589 gdk_pixbuf_get_from_drawable.
6590 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6591 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6592 (xg_check_special_colors): Use GtkStyleContext and its functions
6593 for HAVE_GTK3.
6594 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6595 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6596 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6597 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6598 Call gtk_widget_get_preferred_size.
6599 (xg_frame_resized): gdk_window_get_geometry only takes 5
6600 parameters.
6601 (xg_win_to_widget, xg_event_is_for_menubar):
6602 Call gdk_x11_window_lookup_for_display.
6603 (xg_set_widget_bg): New function.
6604 (delete_cb): New function.
6605 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6606 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6607 (xg_set_background_color): Call xg_set_widget_bg.
6608 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6609 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6610 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6611 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6612 if ! HAVE_GTK3.
6613 (update_frame_tool_bar): Call gtk_widget_hide.
6614 (xg_initialize): Use GDK_KEY_g.
6615
6616 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6617 if ! HAVE_GTK3
6618 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6619
6620 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6621 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6622 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6623
6624 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6625
6626 * w32xfns.c (select_palette): Check success of RealizePalette against
6627 GDI_ERROR, not zero.
6628
6629 See ChangeLog.11 for earlier changes.
6630
6631 ;; Local Variables:
6632 ;; coding: utf-8
6633 ;; End:
6634
6635 Copyright (C) 2011 Free Software Foundation, Inc.
6636
6637 This file is part of GNU Emacs.
6638
6639 GNU Emacs is free software: you can redistribute it and/or modify
6640 it under the terms of the GNU General Public License as published by
6641 the Free Software Foundation, either version 3 of the License, or
6642 (at your option) any later version.
6643
6644 GNU Emacs is distributed in the hope that it will be useful,
6645 but WITHOUT ANY WARRANTY; without even the implied warranty of
6646 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6647 GNU General Public License for more details.
6648
6649 You should have received a copy of the GNU General Public License
6650 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.