1 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3 * buffer.c (mmap_find): Fix a typo.
5 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7 Fix execution of x selection hooks.
8 * xselect.c (Qx_lost_selection_functions)
9 (Qx_sent_selection_functions): New vars.
10 (syms_of_xselect): DEFSYM them.
11 (x_handle_selection_request): Pass Qx_sent_selection_functions
12 rather than Vx_sent_selection_functions to Frun_hook_with_args.
13 (x_handle_selection_clear,x_clear_frame_selections):
14 Pass Qx_lost_selection_functions rather than
15 Vx_lost_selection_functions to Frun_hook_with_args.
17 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
19 * buffer.c (Fget_buffer_create): Initialized inhibit_shrinking.
20 The old code sometimes used this field without initializing it.
22 * alloc.c (gc_sweep): Don't read past end of array.
23 In theory, the old code could also have corrupted Emacs internals,
24 though it'd be very unlikely.
26 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
28 * character.c (Fcharacterp): Don't advertise optional ignored
31 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
33 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
36 * window.c (Fset_window_start): Doc fix (bug#4199).
37 (Fset_window_hscroll): Ditto.
39 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
41 Fix minor new problems caught by GCC 4.6.1.
42 * term.c (init_tty): Remove unused local.
43 * xsettings.c (store_monospaced_changed): Define this function only
44 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
47 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
49 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
51 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
53 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
54 are the mini-buffer and the echo area (bug#3320).
56 * term.c (init_tty): Remove support for supdup, c10 and perq
57 terminals, which are no longer supported (bug#1482).
59 2011-07-10 Johan Bockgård <bojohan@gnu.org>
61 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
63 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
65 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
66 for non-popups (Bug#3642).
68 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
70 * alloc.c (reset_malloc_hooks): Protoize.
71 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
72 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
73 * cm.c (losecursor): Likewise.
74 * data.c (fmod): Likewise.
75 * dispnew.c (swap_glyphs_in_rows): Likewise.
76 * emacs.c (memory_warning_signal): Likewise.
77 * floatfns.c (float_error): Likewise.
78 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
79 (otf_open, font_otf_capability, generate_otf_features)
80 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
82 * image.c (pbm_read_file): Likewise.
83 * indent.c (string_display_width): Likewise.
84 * intervals.c (check_for_interval, search_for_interval)
85 (inc_interval_count, count_intervals, root_interval)
86 (adjust_intervals_for_insertion, make_new_interval): Likewise.
87 * lread.c (defalias): Likewise.
88 * ralloc.c (r_alloc_check): Likewise.
89 * regex.c (set_image_of_range_1, set_image_of_range)
90 (regex_grow_registers): Likewise.
91 * sysdep.c (strerror): Likewise.
92 * termcap.c (valid_filename_p, tprint, main): Likewise.
93 * tparam.c (main): Likewise.
94 * unexhp9k800.c (run_time_remap, save_data_space)
95 (update_file_ptrs, read_header, write_header, calculate_checksum)
96 (copy_file, copy_rest, display_header): Likewise.
97 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
99 * xdisp.c (check_it): Likewise.
100 * xfaces.c (register_color, unregister_color, unregister_colors):
102 * xfns.c (print_fontset_result): Likewise.
103 * xrdb.c (member, fatal, main): Likewise.
105 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
107 Fix minor problems found by static checking (Bug#9031).
108 * chartab.c (char_table_set_range, map_sub_char_table):
109 Remove unused locals.
110 (uniprop_table): Now static.
111 * composite.c (_work_char): Remove unused static var.
113 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
115 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
117 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
119 * gtkutil.c (qttip_cb): Remove code without function.
121 2011-07-09 Eli Zaretskii <eliz@gnu.org>
123 * w32.c (pthread_sigmask): New stub.
125 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
127 Use pthread_sigmask, not sigprocmask (Bug#9010).
128 sigprocmask is portable only for single-threaded applications, and
129 Emacs can be multi-threaded when it uses GTK.
130 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
132 * callproc.c (Fcall_process):
133 * process.c (create_process):
134 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
135 Use pthread_sigmask, not sigprocmask.
137 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
139 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
140 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
143 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
145 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
146 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
147 (xg_hide_tooltip): Fix comment.
149 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
150 in registerServicesMenuSendTypes.
151 (validRequestorForSendType): Don't check ns_return_types.
153 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
156 2011-07-08 Jason Rumney <jasonr@gnu.org>
158 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
159 frame struct members of non-existent frames (Bug#6284).
161 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
163 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
164 variable firstTime not needed on OSX >= 10.6.
165 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
166 >= 10.5. Use setKnobProportion, setDoubleValue.
168 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
169 (MAC_OS_X_VERSION_10_5): Define if not defined.
170 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
171 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
172 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
174 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
175 cString and lossyCString on OSX >= 10.4
177 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
178 sizeToFit on OSX >= 10.2.
180 * nsimage.m (allocInitFromFile): Don't use deprecated method
181 bestRepresentationForDevice on OSX >= 10.6.
183 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
186 * emacs.c: Declare unexec_init_emacs_zone.
188 * nsgui.h: Fix compiler warning about gnulib redefining verify.
190 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
192 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
193 on svcsMenu (Bug#8842).
195 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
197 (Fns_list_services): Just return Qnil on 10.6, code not working there.
199 * nsterm.m (QUTF8_STRING): Declare.
200 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
201 (validRequestorForSendType): Return type is (id).
202 Change indexOfObjectIdenticalTo to indexOfObject.
203 Check if we have local selection before returning self (Bug#8842).
204 (writeSelectionToPasteboard): Put local selection into paste board
205 if we have a local selection (Bug#8842).
206 (syms_of_nsterm): DEFSYM QUTF8_STRING.
208 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
209 (ns_get_local_selection): Declare.
211 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
213 * keymap.c (describe_map_tree): Don't insert a double newline at
214 the end of the buffer (bug#1169) and return whether we inserted
217 * callint.c (Fcall_interactively): Change "reading args" to
218 "providing args" to try to clarify what it does (bug#1010).
220 2011-07-07 Kenichi Handa <handa@m17n.org>
222 * composite.c (composition_compute_stop_pos): Ignore a static
223 composition starting before CHARPOS (Bug#8915).
225 * xdisp.c (handle_composition_prop): Likewise.
227 2011-07-07 Eli Zaretskii <eliz@gnu.org>
229 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
232 2011-07-07 Kenichi Handa <handa@m17n.org>
234 * character.h (unicode_category_t): New enum type.
236 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
237 (Qchar_code_property_table): New variable.
238 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
239 (UNIPROP_COMPRESSED_FORM_P): New macros.
240 (char_table_ascii): Uncompress the compressed values.
241 (sub_char_table_ref): New arg is_uniprop. Callers changed.
242 Uncompress the compressed values.
243 (sub_char_table_ref_and_range): Likewise.
244 (char_table_ref_and_range): Uncompress the compressed values.
245 (sub_char_table_set): New arg is_uniprop. Callers changed.
246 Uncompress the compressed values.
247 (sub_char_table_set_range): Args changed. Callers changed.
248 (char_table_set_range): Adjuted for the above change.
249 (map_sub_char_table): Delete args default_val and parent. Add arg
250 top. Give decoded values to a Lisp function.
251 (map_char_table): Adjusted for the above change. Give decoded
252 values to a Lisp function. Gcpro more variables.
253 (uniprop_table_uncompress)
254 (uniprop_decode_value_run_length): New functions.
255 (uniprop_decoder, uniprop_decoder_count): New variables.
256 (uniprop_get_decoder, uniprop_encode_value_character)
257 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
259 (uniprop_encoder, uniprop_encoder_count): New variables.
260 (uniprop_get_encoder, uniprop_table)
261 (Funicode_property_table_internal, Fget_unicode_property_internal)
262 (Fput_unicode_property_internal): New functions.
263 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
264 Sunicode_property_table_internal, Sget_unicode_property_internal,
265 and Sput_unicode_property_internal. Defvar_lisp
266 char-code-property-alist.
268 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
269 Vunicode_category_table.
271 * font.c (font_range): Adjusted for the change of
272 Vunicode_category_table.
274 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
276 * m/iris4d.h: Remove file, move contents ...
277 * s/irix6-5.h: ... here.
279 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
281 Remove unportable assumption about struct layout (Bug#8884).
282 * alloc.c (mark_buffer):
283 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
284 (clone_per_buffer_values): Don't assume that
285 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
286 This isn't true in general, and it's particularly not true
287 if Emacs is configured with --with-wide-int.
288 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
289 New macros, used in the buffer.c change.
291 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
293 * xsettings.c: Use both GConf and GSettings if both are available.
294 (store_config_changed_event): Add comment.
295 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
296 (store_tool_bar_style_changed): New functions.
297 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
298 (struct xsettings): Move font inside HAVE_XFT.
299 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
300 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
301 Move inside HAVE_XFT.
302 (something_changed_gsettingsCB): Renamed from something_changedCB.
303 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
305 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
306 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
307 (something_changed_gconfCB): Renamed from something_changedCB.
308 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
309 (parse_settings): Move check for font inside HAVE_XFT.
310 (read_settings, apply_xft_settings): Add comment.
311 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
312 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
313 call store_font_name_changed.
314 (xft_settings_event): Add comment.
315 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
316 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
317 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
318 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
319 (xsettings_initialize): Call init_gsettings last.
320 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
323 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
325 Random fixes. E.g., (random) never returned negative values.
326 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
327 subseconds part to the entropy, as that's a bit more random.
328 Prefer signed to unsigned, since the signedness doesn't matter and
329 in general we prefer signed. When given a limit, use a
330 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
331 latter isn't right if USE_2_TAGS_FOR_INTS.
332 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
333 not 0..VALMASK. Don't discard "excess" bits that random () returns.
335 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
337 * textprop.c (text_property_stickiness):
338 Obey Vtext_property_default_nonsticky.
339 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
340 * w32fns.c (syms_of_w32fns):
341 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
343 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
345 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
346 This is more efficient than Ffile_directory_p and avoids a minor race.
348 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
350 * buffer.c (Foverlay_put): Say what the return value is
353 * fileio.c (barf_or_query_if_file_exists): Check first if the file
354 is a directory before asking whether to use the file name
356 (barf_or_query_if_file_exists): Make the "File is a directory"
357 error be more correct.
359 * fns.c (Frequire): Remove the mention of the .gz files, since
360 that's installation-specific, but keep the mention of
363 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
365 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
366 Report string overflow if the output is too long.
368 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
370 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
371 (syms_of_gnutls): Remove duplicate DEFSYM for
372 Qgnutls_bootprop_verify_hostname_error, an error for
373 Qgnutls_bootprop_verify_error (which is no longer used).
375 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
376 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
377 Also (re)move comments that are misplaced or no longer relevant.
379 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
381 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
383 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
385 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
386 and background color parameters if they have been changed.
388 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
390 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
392 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
394 * xsettings.c (SYSTEM_FONT): Define only when used.
395 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
397 * keymap.c (access_keymap_1): Now static.
399 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
401 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
402 leave any prefix arg for the up event (Bug#1586).
404 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
406 * lread.c (syms_of_lread): Mention single symbols defined by
407 `defvar' or `defconst' (bug#7154).
409 * fns.c (Frequire): Mention .el.gz files (bug#7314).
410 (Frequire): Mention get-load-suffixes.
412 2011-07-02 Martin Rudalics <rudalics@gmx.at>
414 * window.h (window): Remove clone_number slot.
415 * window.c (Fwindow_clone_number, Fset_window_clone_number):
417 (make_parent_window, make_window, saved_window)
418 (Fset_window_configuration, save_window_save): Don't deal with
420 * buffer.c (Qclone_number): Remove declaration.
421 (sort_overlays, overlay_strings): Don't deal with clone numbers.
423 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
425 Add multiple inheritance to keymaps.
426 * keymap.c (Fmake_composed_keymap): New function.
427 (Fset_keymap_parent): Simplify.
428 (fix_submap_inheritance): Remove.
429 (access_keymap_1): New function extracted from access_keymap to handle
430 embedded parents and handle lists of maps.
431 (access_keymap): Use it.
432 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
433 (Fcopy_keymap): Handle embedded parents.
434 (Fcommand_remapping, define_as_prefix): Simplify.
435 (Fkey_binding): Simplify.
436 (syms_of_keymap): Move minibuffer-local-completion-map,
437 minibuffer-local-filename-completion-map,
438 minibuffer-local-must-match-map, and
439 minibuffer-local-filename-must-match-map to Elisp.
440 (syms_of_keymap): Defsubr make-composed-keymap.
441 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
442 (parse_menu_item): Trivial simplification.
444 2011-07-01 Glenn Morris <rgm@gnu.org>
446 * Makefile.in (SETTINGS_LIBS): Fix typo.
448 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
450 * coding.c (Fencode_coding_string): Record the last coding system
451 used, as the function doc string says (bug#8738).
453 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
455 * xsettings.c (store_monospaced_changed): Take new font as arg and
456 check for change against current_mono_font.
457 (EMACS_TYPE_SETTINGS): Remove this and related defines.
458 (emacs_settings_constructor, emacs_settings_get_property)
459 (emacs_settings_set_property, emacs_settings_class_init)
460 (emacs_settings_init, gsettings_obj): Remove.
461 (something_changedCB): New function for HAVE_GSETTINGS.
462 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
463 with value as argument.
464 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
465 g_settings_new (Bug#8967). Do not create gsettings_obj.
466 Remove calls to g_settings_bind. Connect something_changedCB to
469 * xgselect.c: Add defined (HAVE_GSETTINGS).
470 (xgselect_initialize): Ditto.
472 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
473 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
476 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
478 * eval.c (struct backtrace): Simplify and port the data structure.
479 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
480 signed bit field, as this assumption is not portable and it makes
481 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
482 "char debug_on_exit : 1" as this is not portable either; instead,
483 use the portable "unsigned int debug_on_exit : 1". Remove unused
484 member evalargs. Remove obsolete comments about cc bombing out.
486 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
488 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
489 Let HAVE_GSETTINGS override HAVE_GCONF.
490 (store_monospaced_changed): New function.
491 (EMACS_SETTINGS): A new type derived from GObject to handle
492 GSettings notifications.
493 (emacs_settings_constructor, emacs_settings_get_property)
494 (emacs_settings_set_property, emacs_settings_class_init):
496 (gsettings_client, gsettings_obj): New variables.
497 (GSETTINGS_SCHEMA): New define.
498 (something_changedCB): Call store_monospaced_changed.
499 (init_gsettings): New function.
500 (xsettings_initialize): Call init_gsettings.
501 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
504 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
507 2011-06-29 Martin Rudalics <rudalics@gmx.at>
509 * window.c (resize_root_window, grow_mini_window)
510 (shrink_mini_window): Rename Qresize_root_window to
511 Qwindow_resize_root_window and Qresize_root_window_vertically to
512 Qwindow_resize_root_window_vertically.
514 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
516 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
518 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
520 * makefile.w32-in: Redesign dependencies so they reflect more
521 clearly which files are directly included by each source file,
522 and not through other includes.
524 2011-06-27 Martin Rudalics <rudalics@gmx.at>
526 * buffer.c (Qclone_number): Declare static and DEFSYM it.
527 (sort_overlays, overlay_strings): When an overlay's clone number
528 matches the window's clone number process the overlay even if
529 the overlay's window property doesn't match the current window.
531 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
532 (Fwindow_hchild): Rename to Fwindow_left_child.
533 (Fwindow_next): Rename to Fwindow_next_sibling.
534 (Fwindow_prev): Rename to Fwindow_prev_sibling.
535 (resize_window_check): Rename to window_resize_check.
536 (resize_window_apply): Rename to window_resize_apply.
537 (Fresize_window_apply): Rename to Fwindow_resize_apply.
538 (Fdelete_other_windows_internal, resize_frame_windows)
539 (Fsplit_window_internal, Fdelete_window_internal)
540 (grow_mini_window, shrink_mini_window)
541 (Fresize_mini_window_internal): Fix callers accordingly.
543 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
545 * emacsgtkfixed.h: State that this is only used with Gtk+3.
546 (emacs_fixed_set_min_size): Remove.
547 (emacs_fixed_new): Take frame as argument.
549 * emacsgtkfixed.c: State that this is only used with Gtk+3.
550 (_EmacsFixedPrivate): Remove minwidth/height.
552 (emacs_fixed_init): Initialize priv->f.
553 (get_parent_class, emacs_fixed_set_min_size): Remove.
554 (emacs_fixed_new): Set priv->f to argument.
555 (emacs_fixed_get_preferred_width)
556 (emacs_fixed_get_preferred_height): Use min_width/height from
557 frames size_hint to set minimum and natural (Bug#8919).
558 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
559 and use min_width/height from frames size_hint to set
560 min_width/height (Bug#8919).
562 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
563 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
566 2011-06-26 Eli Zaretskii <eliz@gnu.org>
568 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
569 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
572 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
574 * process.c (wait_reading_process_output): Bypass select if
575 waiting for a cell while ignoring keyboard input, and input is
576 pending. Suggested by Jan Djärv (Bug#8869).
578 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
580 Use gnulib's dup2 module instead of rolling our own.
581 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
583 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
585 * dispnew.c (scrolling_window): Before scrolling, turn off a
586 mouse-highlight in the window being scrolled.
588 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
590 Move DEFSYM to lisp.h and use everywhere.
592 * character.h (DEFSYM): Move declaration...
593 * lisp.h (DEFSYM): ...here.
599 * w32select.c: Don't include character.h.
601 * alloc.c (syms_of_alloc):
602 * buffer.c (syms_of_buffer):
603 * bytecode.c (syms_of_bytecode):
604 * callint.c (syms_of_callint):
605 * casefiddle.c (syms_of_casefiddle):
606 * casetab.c (init_casetab_once):
607 * category.c (init_category_once, syms_of_category):
608 * ccl.c (syms_of_ccl):
609 * cmds.c (syms_of_cmds):
610 * composite.c (syms_of_composite):
611 * dbusbind.c (syms_of_dbusbind):
612 * dired.c (syms_of_dired):
613 * dispnew.c (syms_of_display):
614 * doc.c (syms_of_doc):
615 * editfns.c (syms_of_editfns):
616 * emacs.c (syms_of_emacs):
617 * eval.c (syms_of_eval):
618 * fileio.c (syms_of_fileio):
619 * fns.c (syms_of_fns):
620 * frame.c (syms_of_frame):
621 * fringe.c (syms_of_fringe):
622 * insdel.c (syms_of_insdel):
623 * keymap.c (syms_of_keymap):
624 * lread.c (init_obarray, syms_of_lread):
625 * macros.c (syms_of_macros):
626 * msdos.c (syms_of_msdos):
627 * print.c (syms_of_print):
628 * process.c (syms_of_process):
629 * search.c (syms_of_search):
630 * sound.c (syms_of_sound):
631 * syntax.c (init_syntax_once, syms_of_syntax):
632 * terminal.c (syms_of_terminal):
633 * textprop.c (syms_of_textprop):
634 * undo.c (syms_of_undo):
635 * w32.c (globals_of_w32):
636 * window.c (syms_of_window):
637 * xdisp.c (syms_of_xdisp):
638 * xfaces.c (syms_of_xfaces):
639 * xfns.c (syms_of_xfns):
640 * xmenu.c (syms_of_xmenu):
641 * xsettings.c (syms_of_xsettings):
642 * xterm.c (syms_of_xterm): Use DEFSYM.
644 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
646 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
648 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
650 Integer and buffer overflow fixes (Bug#8873).
652 * print.c (printchar, strout): Check for string overflow.
653 (PRINTPREPARE, printchar, strout):
654 Don't set size unless allocation succeeds.
656 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
657 for sizes. Check for string overflow more accurately.
658 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
660 * macros.c: Integer and buffer overflow fixes.
661 * keyboard.h (struct keyboard.kbd_macro_bufsize):
662 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
663 Use ptrdiff_t, not int, for sizes.
664 Don't increment bufsize until after realloc succeeds.
665 Check for size-calculation overflow.
666 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
668 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
670 * lread.c: Integer overflow fixes.
671 (read_integer): Radix is now EMACS_INT, not int,
672 to improve quality of diagnostics for out-of-range radices.
673 Calculate buffer size correctly for out-of-range radices.
674 (read1): Check for integer overflow in radices, and in
676 (read_escape): Avoid int overflow.
677 (Fload, openp, read_buffer_size, read1)
678 (substitute_object_recurse, read_vector, read_list, map_obarray):
679 Use ptrdiff_t, not int, for sizes.
680 (read1): Use EMACS_INT, not int, for sizes.
681 Check for size overflow.
683 * image.c (cache_image): Check for size arithmetic overflow.
685 * lread.c: Integer overflow issues.
686 (saved_doc_string_size, saved_doc_string_length)
687 (prev_saved_doc_string_size, prev_saved_doc_string_length):
688 Now ptrdiff_t, not int.
689 (read1): Don't assume doc string length fits in int. Check for
690 out-of-range doc string lengths.
691 (read_list): Don't assume file position fits in int.
692 (read_escape): Check for hex character overflow.
694 2011-06-22 Leo Liu <sdl.web@gmail.com>
696 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
697 Move to minibuffer.el.
699 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
701 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
702 The following patches are for when GLYPH_DEBUG && !XASSERT.
703 * dispextern.h (trace_redisplay_p, dump_glyph_string):
704 * dispnew.c (flush_stdout):
705 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
706 Mark as externally visible.
707 * dispnew.c (check_window_matrix_pointers): Now static.
708 * dispnew.c (window_to_frame_vpos):
709 * xfns.c (unwind_create_frame):
710 * xterm.c (x_check_font): Remove unused local.
711 * scroll.c (CHECK_BOUNDS):
712 * xfaces.c (cache_fache): Rename local to avoid shadowing.
713 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
714 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
715 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
716 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
718 (debug_method_add): Use va_list and vsprintf rather than relying
719 on undefined behavior with wrong number of arguments.
720 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
721 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
722 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
723 since we're not interested in debugging glyphs with old libraries.
724 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
725 GCC 4.6.0's static checking.
727 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
729 Integer overflow and signedness fixes (Bug#8873).
730 A few related buffer overrun fixes, too.
732 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
734 * dispextern.h (struct face.stipple):
735 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
736 (x_bitmap_mask, x_allocate_bitmap_record)
737 (x_create_bitmap_from_data, x_create_bitmap_from_file)
738 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
739 (x_create_bitmap_from_xpm_data):
740 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
741 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
743 * xfaces.c (load_pixmap):
744 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
745 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
746 (.bitmaps_last, struct x_output.icon_bitmap):
747 Use ptrdiff_t, not int, for bitmap indexes.
748 (x_allocate_bitmap_record): Check for size overflow.
749 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
751 Use ptrdiff_t, not int, for overlay counts.
752 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
753 * editfns.c (overlays_around, get_pos_property):
754 * textprop.c (get_char_property_and_overlay):
755 * xdisp.c (next_overlay_change, note_mouse_highlight):
756 * xfaces.c (face_at_buffer_position):
757 * buffer.c (OVERLAY_COUNT_MAX): New macro.
758 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
759 (Fnext_overlay_change, Fprevious_overlay_change)
760 (mouse_face_overlay_overlaps, Foverlays_in):
761 Use ptrdiff_t, not int, for sizes.
762 (overlays_at, overlays_in): Check for size-calculation overflow.
764 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
766 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
767 (x_session_initialize): Do not assume string length fits in int.
769 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
770 This is unlikely, but can occur if DPI is outlandish.
772 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
773 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
775 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
776 * xrdb.c (magic_file_p, search_magic_path):
777 Omit last arg SUFFIX; it was always 0. All callers changed.
778 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
780 * xfont.c (xfont_match): Avoid need for strlen.
782 * xfns.c: Don't assume strlen fits in int.
783 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
785 * xdisp.c (message_log_check_duplicate): Return intmax_t,
786 not unsigned long, as we prefer signed integers. All callers changed.
787 Detect integer overflow in repeat count.
788 (message_dolog): Don't assume print length fits in 39 bytes.
789 (display_mode_element): Don't assume strlen fits in int.
791 * termcap.c: Don't assume sizes fit in int and never overflow.
792 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
793 (gobble_line): Check for size-calculation overflow.
795 * minibuf.c (Fread_buffer):
796 * lread.c (intern, intern_c_string):
797 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
798 Don't assume string length fits in int.
800 * keyboard.c (parse_tool_bar_item):
801 * gtkutil.c (style_changed_cb): Avoid need for strlen.
803 * font.c: Don't assume string length fits in int.
804 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
805 Use ptrdiff_t, not int.
806 (font_intern_prop): Don't assume string length fits in int.
807 Don't assume integer property fits in fixnum.
808 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
810 * filelock.c: Fix some buffer overrun and integer overflow issues.
811 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
812 Reformulate so as not to need the command string.
813 Invoke gzip -cd rather than gunzip, as it's more portable.
814 (lock_info_type, lock_file_1, lock_file):
815 Don't assume pid_t and time_t fit in unsigned long.
816 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
817 (current_lock_owner): Prefer signed type for sizes.
818 Use memcpy, not strncpy, where memcpy is what is really wanted.
819 Don't assume (via atoi) that time_t and pid_t fit in int.
820 Check for time_t and/or pid_t out of range, e.g., via a network share.
821 Don't alloca where an auto var works fine.
823 * fileio.c: Fix some integer overflow issues.
824 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
825 Don't assume string length fits in int.
826 (directory_file_name): Don't assume string length fits in long.
827 (make_temp_name): Don't assume pid fits in int, or that its print
828 length is less than 20.
830 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
832 * coding.c (make_subsidiaries): Don't assume string length fits in int.
834 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
836 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
837 We prefer signed integers, even for size calculations.
839 * emacs.c: Don't assume string length fits in 'int'.
840 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
841 (main): Don't invoke strlen when not needed.
843 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
844 (XD_DEBUG_MESSAGE): Don't waste a byte.
846 * callproc.c (getenv_internal_1, getenv_internal)
848 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
850 * lread.c (invalid_syntax): Omit length argument.
851 All uses changed. This doesn't fix a bug, but it simplifies the
852 code away from its former Hollerith-constant appearance, and it's
853 one less 'int' to worry about when looking at integer-overflow issues.
854 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
856 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
857 This didn't break anything, but it didn't help either.
858 It's confusing to put a bogus integer in a place where the actual
859 value does not matter.
860 (LIST_END_P): Remove unused macro and its bogus comment.
861 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
863 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
864 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
866 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
867 We prefer signed types, and the value cannot exceed the EMACS_INT
868 range anyway (because otherwise the length would not be representable).
869 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
870 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
871 This avoids a GCC warning when WIDE_EMACS_INT.
873 * indent.c (sane_tab_width): New function.
874 (current_column, scan_for_column, Findent_to, position_indentation)
875 (compute_motion): Use it. This is just for clarity.
876 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
878 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
880 * lisp.h (lint_assume): New macro.
881 * composite.c (composition_gstring_put_cache):
882 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
884 * editfns.c, insdel.c:
885 Omit unnecessary forward decls, to simplify future changes.
887 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
889 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
891 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
892 Use much-faster test for byte-length change.
893 Don't assume string byte-length fits in 'int'.
894 Check that character arg fits in 'int'.
895 (mapcar1): Declare byte as byte, for clarity.
897 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
899 * fns.c (concat): Catch string overflow earlier.
900 Do not rely on integer wraparound.
902 * dispextern.h (struct it.overlay_strings_charpos)
903 (struct it.selective): Now EMACS_INT, not int.
904 * xdisp.c (forward_to_next_line_start)
905 (back_to_previous_visible_line_start)
906 (reseat_at_next_visible_line_start, next_element_from_buffer):
907 Don't arbitrarily truncate the value of 'selective' to int.
909 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
911 * composite.c: Don't truncate sizes to 'int'.
912 (composition_gstring_p, composition_reseat_it)
913 (composition_adjust_point): Use EMACS_INT, not int.
914 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
915 not EMACS_UINT, for indexes.
917 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
919 * buffer.c: Include <verify.h>.
920 (struct sortvec.priority, struct sortstr.priority):
921 Now EMACS_INT, not int.
922 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
923 (struct sortstr.size, record_overlay_string)
924 (struct sortstrlist.size, struct sortlist.used):
925 Don't truncate size to int.
926 (record_overlay_string): Check for size-calculation overflow.
927 (init_buffer_once): Check at compile-time, not run-time.
929 2011-06-22 Jim Meyering <meyering@redhat.com>
931 Don't leak an XBM-image-sized buffer
932 * image.c (xbm_load): Free the image buffer after using it.
934 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
937 * composite.c (find_automatic_composition): Omit needless 'return 0;'
938 that Sun C diagnosed.
939 * fns.c (secure_hash): Fix pointer signedness issue.
940 * intervals.c (static_offset_intervals): New function.
941 (offset_intervals): Use it.
943 2011-06-21 Leo Liu <sdl.web@gmail.com>
946 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
949 * fns.c (secure_hash): Rename from crypto_hash_function and change
950 the first arg to accept symbols.
951 (Fsecure_hash): New primitive.
952 (syms_of_fns): New symbols.
954 2011-06-20 Deniz Dogan <deniz@dogan.se>
956 * process.c (Fset_process_buffer): Clarify return value in
959 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
961 * dispnew.c (add_window_display_history): Use BVAR.
963 * xdisp.c (debug_method_add): Use BVAR.
964 (check_window_end, dump_glyph_matrix, dump_glyph)
965 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
967 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
970 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
971 check till after the cache is created in init_frame_faces.
973 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
975 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
977 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
979 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
980 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
981 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
983 Improve buffer-overflow checking (Bug#8873).
984 * fileio.c (Finsert_file_contents):
985 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
986 Remove the old (too-loose) buffer overflow checks.
987 They weren't needed, since make_gap checks for buffer overflow.
988 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
989 The old code merely checked for Emacs fixnum overflow, and relied
990 on undefined (wraparound) behavior. The new code avoids undefined
991 behavior, and also checks for ptrdiff_t and/or size_t overflow.
993 * editfns.c (Finsert_char): Don't dump core with very negative counts.
994 Tune. Don't use wider integers than needed. Don't use alloca.
995 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
997 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
999 * insdel.c, lisp.h (buffer_overflow): New function.
1000 (insert_from_buffer_1, replace_range, replace_range_2):
1001 * insdel.c (make_gap_larger):
1002 * editfns.c (Finsert_char):
1003 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1005 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1007 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1009 Integer overflow and signedness fixes (Bug#8873).
1011 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1012 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1014 * fileio.c: Don't assume EMACS_INT fits in off_t.
1015 (emacs_lseek): New static function.
1016 (Finsert_file_contents, Fwrite_region): Use it.
1017 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1019 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1021 * fns.c: Don't overflow int when computing a list length.
1022 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1023 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1024 truncation on 64-bit hosts. Check for QUIT every
1025 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1026 faster and is responsive enough.
1027 (Flength): Report an error instead of overflowing an integer.
1028 (Fsafe_length): Return a float if the value is not representable
1029 as a fixnum. This shouldn't happen except in contrived situations.
1030 (Fnthcdr, Fsort): Don't assume list length fits in int.
1031 (Fcopy_sequence): Don't assume vector length fits in int.
1033 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1034 (header_size, word_size): New constants.
1035 (allocate_vectorlike): Don't check size overflow here.
1036 (allocate_vector): Check it here instead, since this is the only
1037 caller of allocate_vectorlike that could cause overflow.
1038 Check that the new vector's length is representable as a fixnum.
1040 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1041 The previous code was bogus. For example, next_almost_prime (32)
1042 returned 39, which is undesirable as it is a multiple of 3; and
1043 next_almost_prime (24) returned 25, which is a multiple of 5 so
1044 why was the code bothering to check for multiples of 7?
1046 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1048 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1050 Variadic C functions now count arguments with ptrdiff_t.
1051 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1052 Back then I didn't know that the Emacs coding style prefers signed int.
1053 Also, in the meantime I found a few more instances where arguments
1054 were being counted with int, which may truncate counts on 64-bit
1055 machines, or EMACS_INT, which may be unnecessarily wide.
1056 * lisp.h (struct Lisp_Subr.function.aMANY)
1057 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1058 Arg counts are now ptrdiff_t, not size_t.
1059 All variadic functions and their callers changed accordingly.
1060 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1061 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1062 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1063 * callint.c (Fcall_interactively): Check arg count for overflow,
1064 to avoid potential buffer overrun. Use signed char, not 'int',
1065 for 'varies' array, so that we needn't bother to check its size
1066 calculation for overflow.
1067 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1068 * eval.c (apply_lambda):
1069 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1070 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1071 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1073 * callint.c (Fcall_interactively): Don't use index var as event count.
1075 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1076 * mem-limits.h (SIZE): Remove; no longer used.
1078 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1080 Remove unnecessary casts.
1081 * xterm.c (x_term_init):
1082 * xfns.c (x_set_border_pixel):
1083 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1084 These aren't needed now that we assume ANSI C.
1086 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1087 It's more likely to cause problems (due to unsigned overflow)
1090 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1092 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1094 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1096 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1098 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1100 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1102 GLYPH_CODE_FACE returns EMACS_INT, not int.
1103 * dispextern.h (merge_faces):
1104 * xfaces.c (merge_faces):
1105 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1106 Don't assume EMACS_INT fits in int.
1108 * character.h (CHAR_VALID_P): Remove unused parameter.
1109 * fontset.c, lisp.h, xdisp.c: All uses changed.
1111 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1113 * fns.c (concat): Minor tuning based on overflow analysis.
1114 This doesn't fix any bugs. Use int to hold character, instead
1115 of constantly refetching from Emacs object. Use XFASTINT, not
1116 XINT, for value known to be a character. Don't bother comparing
1117 a single byte to 0400, as it's always less.
1119 * floatfns.c (Fexpt):
1120 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1122 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1125 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1127 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1128 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1129 incorrectly succeed when S was a string, because 4294967386 was
1130 truncated before it was used.
1132 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1133 Otherwise, an out-of-range integer could cause undefined behavior
1136 * composite.c: Use int, not EMACS_INT, for characters.
1137 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1138 EMACS_INT, for values that are known to be in character range.
1139 This doesn't fix any bugs but is the usual style inside Emacs and
1140 may generate better code on 32-bit machines.
1142 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1143 This is for reasons similar to the recent CHAR_STRING fix.
1144 * charset.c (Fencode_char): Check that character arg is actually
1145 a character. Pass an int to ENCODE_CHAR.
1146 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1147 wider than 'int', as a compile-time check to prevent future regressions
1150 * character.c (char_string): Remove unnecessary casts.
1152 Make sure a 64-bit char is never passed to CHAR_STRING.
1153 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1154 by silently ignoring the top 32 bits, allowing some values
1155 that were far too large to be valid characters.
1156 * character.h: Include <verify.h>.
1157 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1158 arguments are no wider than unsigned, as a compile-time check
1159 to prevent future regressions in this area.
1161 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1162 (Fsubst_char_in_region):
1164 * xdisp.c (decode_mode_spec_coding):
1165 Adjust to CHAR_STRING's new requirement.
1166 * editfns.c (Finsert_char, Fsubst_char_in_region):
1167 * fns.c (concat): Check that character args are actually
1168 characters. Without this test, these functions did the wrong
1169 thing with wildly out-of-range values on 64-bit hosts.
1171 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1172 These casts should not be needed on 32-bit hosts, either.
1173 * keyboard.c (read_char):
1174 * lread.c (Fload): Remove casts to unsigned.
1176 * lisp.h (UNSIGNED_CMP): New macro.
1177 This fixes comparison bugs on 64-bit hosts.
1178 (ASCII_CHAR_P): Use it.
1179 * casefiddle.c (casify_object):
1180 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1181 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1182 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1183 * dispextern.h (FACE_FROM_ID):
1184 * keyboard.c (read_char): Use UNSIGNED_CMP.
1186 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1187 not to EMACS_INT, to avoid GCC warning.
1189 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1191 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1192 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1193 isn't needed on 32-bit machines.
1195 * buffer.c (Fgenerate_new_buffer_name):
1196 Use EMACS_INT for count, not int.
1197 (advance_to_char_boundary): Return EMACS_INT, not int.
1199 * data.c (Qcompiled_function): Now static.
1201 * window.c (window_body_lines): Now static.
1203 * image.c (gif_load): Rename local to avoid shadowing.
1205 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1206 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1207 * alloc.c (make_save_value): Integer argument is now of type
1209 (mark_object): Use ptrdiff_t, not int.
1210 * lisp.h (pD): New macro.
1211 * print.c (print_object): Use it.
1213 * alloc.c: Use EMACS_INT, not int, to count objects.
1214 (total_conses, total_markers, total_symbols, total_vector_size)
1215 (total_free_conses, total_free_markers, total_free_symbols)
1216 (total_free_floats, total_floats, total_free_intervals)
1217 (total_intervals, total_strings, total_free_strings):
1218 Now EMACS_INT, not int. All uses changed.
1219 (Fgarbage_collect): Compute overall total using a double, so that
1220 integer overflow is less likely to be a problem. Check for overflow
1221 when converting back to an integer.
1222 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1223 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1224 These were 'int' variables that could overflow on 64-bit hosts;
1225 they were never used, so remove them instead of repairing them.
1226 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1227 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1228 Previously, this ceilinged at INT_MAX, but that doesn't work on
1230 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1232 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1233 (allocate_vectorlike): Check for ptrdiff_t overflow.
1234 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1235 when a (possibly-narrower) signed value would do just as well.
1236 We prefer using signed arithmetic, to avoid comparison confusion.
1238 * alloc.c: Catch some string size overflows that we were missing.
1239 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1240 for convenience in STRING_BYTES_MAX.
1241 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1242 The definition here is exact; the one in lisp.h was approximate.
1243 (allocate_string_data): Check for string overflow. This catches
1244 some instances we weren't catching before. Also, it catches
1245 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1246 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1247 and ptrdiff_t and EMACS_INT are both 64 bits.
1249 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1250 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1251 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1253 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1255 * alloc.c (Fmake_string): Check for out-of-range init.
1257 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1259 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1261 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1263 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1264 xg_get_default_scrollbar_width.
1266 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1267 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1268 (style_changed_cb): Call update_theme_scrollbar_width and call
1269 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1270 all frames (Bug#8505).
1271 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1272 Call gtk_window_set_resizable if HAVE_GTK3.
1273 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1274 and height if HAVE_GTK3 (Bug#8505).
1275 (scroll_bar_width_for_theme): New variable.
1276 (update_theme_scrollbar_width): New function.
1277 (xg_get_default_scrollbar_width): Move code to
1278 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1279 (xg_initialize): Call update_theme_scrollbar_width.
1281 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1283 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1285 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1287 * frame.c (make_frame): Call other_buffer_safely instead of
1290 * window.c (temp_output_buffer_show): Call display_buffer with
1291 second argument Vtemp_buffer_show_specifiers and reset latter
1292 immediately after the call.
1293 (Vtemp_buffer_show_specifiers): New variable.
1294 (auto_window_vscroll_p, next_screen_context_lines)
1295 (Vscroll_preserve_screen_position): Remove leading asterisks from
1298 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1300 Fix minor problems found by GCC 4.6.0 static checking.
1301 * buffer.c (Qclone_number): Remove for now, as it's unused.
1302 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1303 (record_buffer): Remove unused local.
1304 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1305 (set_frame_buffer_list): Remove; unused.
1306 * frame.h (other_visible_frames): Remove decl.
1307 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1308 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1309 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1311 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1312 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1313 Define only if HAVE_GPM.
1314 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1315 (update_hints_inhibit): Remove; never set. All uses removed.
1316 * widgetprv.h (emacsFrameClassRec): Remove decl.
1317 * window.c (delete_deletable_window): Now returns void, since it
1318 wasn't returning anything.
1319 (compare_window_configurations): Remove unused locals.
1320 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1321 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1322 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1323 the same widths as pointers. This follows up on the 2011-05-06 patch.
1324 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1325 * xterm.h: Likewise.
1326 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1328 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1330 * makefile.w32-in: Update dependencies.
1331 (LISP_H): Add lib/intprops.h.
1333 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1335 * image.c (gif_load): Add animation frame delay to the metadata.
1336 (syms_of_image): Use DEFSYM. New symbol `delay'.
1338 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1340 * window.c (delete_deletable_window): Re-add.
1341 (Fset_window_configuration): Rewrite to handle dead buffers and
1342 consequently deletable windows.
1343 (window_tree, Fwindow_tree): Remove. Supply functionality in
1345 (compare_window_configurations): Simplify code.
1347 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1349 * image.c (imagemagick_load_image): Fix type mismatch.
1350 (Fimagemagick_types): Likewise.
1352 * window.h (replace_buffer_in_windows): Declare.
1354 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1356 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1357 Qclone_number. Remove external declaration of Qdelete_window.
1358 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1360 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1361 Qbuffer_list_update_hook if allowed.
1362 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1363 buffer list implementation.
1364 (other_buffer_safely): New function.
1365 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1366 calls to replace_buffer_in_windows and
1367 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1369 (record_buffer): Inhibit quitting and rewrite using quittable
1370 functions. Run Qbuffer_list_update_hook if allowed.
1371 (Frecord_buffer, Funrecord_buffer): New functions.
1372 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1373 switch-to-buffer to window.el.
1374 (bury-buffer): Move to window.el.
1375 (Vbuffer_list_update_hook): New variable.
1377 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1380 * window.h (resize_frame_windows): Move up in code.
1381 (Fwindow_frame): Remove EXFUN.
1382 (replace_buffer_in_all_windows): Remove prototype.
1383 (replace_buffer_in_windows_safely): Add prototype.
1385 * window.c: Declare Qdelete_window static again. Move down
1386 declaration of select_count.
1387 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1388 (Fother_window): Move to window.el.
1389 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1390 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1391 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1393 (replace_buffer_in_windows): Implement by calling
1394 Qreplace_buffer_in_windows.
1395 (replace_buffer_in_all_windows): Remove with some functionality
1396 moved into replace_buffer_in_windows_safely.
1397 (replace_buffer_in_windows_safely): New function.
1398 (select_window_norecord, select_frame_norecord): Move in front
1399 of run_window_configuration_change_hook. Remove now obsolete
1401 (Fset_window_buffer): Rewrite doc-string. Call
1402 Qrecord_window_buffer.
1403 (keys_of_window): Move binding for other-window to window.el.
1405 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1407 * dispextern.h (struct image): Replace data member, whose int_val
1408 and ptr_val fields were not used by anything, with a single
1411 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1412 (gif_clear_image, gif_load, imagemagick_load_image)
1413 (gs_clear_image, gs_load): Callers changed.
1415 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1417 * buffer.h: Include <time.h>, for time_t.
1418 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1420 Fix minor problems found by static checking.
1422 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1424 Make identifiers static if they are not used in other modules.
1425 * data.c (Qcompiled_function, Qframe, Qvector):
1426 * image.c (QimageMagick, Qsvg):
1427 * minibuf.c (Qmetadata):
1428 * window.c (resize_window_check, resize_root_window): Now static.
1429 * window.h (resize_window_check, resize_root_window): Remove decls.
1431 * window.c (window_deletion_count, delete_deletable_window):
1433 (window_body_lines): Now static.
1434 (Fdelete_other_windows_internal): Mark vars as initialized.
1435 Make sure 'resize_failed' is initialized.
1436 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1437 (resize_window_apply): Remove unused local.
1438 * window.h (delete_deletable_window): Remove decl.
1440 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1441 (imagemagick_load_image): Fix pointer signedness problem by changing
1442 last arg from unsigned char * to char *. All uses changed.
1443 Also, fix a local for similar reasons.
1444 Remove unused locals. Remove locals to avoid shadowing.
1445 (fn_rsvg_handle_free): Remove; unused.
1446 (svg_load, svg_load_image): Fix pointer signedness problem.
1447 (imagemagick_load_image): Don't use garbage pointer image_wand.
1449 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1451 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1453 * image.c (gif_load): Fix omitted cast error introduced by
1456 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1458 * window.h (resize_proportionally, orig_total_lines)
1459 (orig_top_line): Remove from window structure.
1460 (set_window_height, set_window_width, change_window_heights)
1461 (Fdelete_window): Remove prototypes.
1462 (resize_frame_windows): Remove duplicate declaration.
1464 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1466 * window.h (resize_frame_windows, resize_window_check)
1467 (delete_deletable_window, resize_root_window)
1468 (resize_frame_windows): Declare prototypes.
1470 * window.c (resize_window_apply): Make definition be "static" to
1471 match the prototype.
1473 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1475 * window.c: Remove declarations of Qwindow_size_fixed,
1476 window_min_size_1, window_min_size_2, window_min_size,
1477 size_window, window_fixed_size_p, enlarge_window, delete_window.
1478 Remove static from declaration of Qdelete_window, it's
1479 temporarily needed by Fbury_buffer.
1480 (replace_window): Don't assign orig_top_line and
1482 (Fdelete_window, delete_window): Remove. Window deletion is
1483 handled by window.el.
1484 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1485 Fdelete_window calls with calls to Qdelete_window.
1486 (Fdelete_other_windows): Remove. Deleting other windows is
1487 handled by window.el.
1488 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1489 handled in window.el.
1490 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1491 Window minimum sizes are handled in window.el.
1492 (shrink_windows, size_window, set_window_height)
1493 (set_window_width, change_window_heights, window_height)
1494 (window_width, CURBEG, CURSIZE, enlarge_window)
1495 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1496 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1497 handled in window.el.
1498 (make_dummy_parent): Rename to make_parent_window and give it a
1499 second argument horflag.
1500 (make_window): Don't set resize_proportionally any more.
1501 (Fsplit_window): Remove. Windows are split in window.el.
1502 (save_restore_action, save_restore_orig_size)
1503 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1504 Resize mini windows in window.el.
1505 (grow_mini_window, shrink_mini_window): Implement by calling
1506 Qresize_root_window_vertically, resize_window_check and
1507 resize_window_apply.
1508 (saved_window, Fset_window_configuration, save_window_save): Do
1509 not handle orig_top_line, orig_total_lines, and
1510 resize_proportionally.
1511 (window_min_height, window_min_width): Move to window.el.
1512 (keys_of_window): Move bindings for delete-other-windows,
1513 split-window, delete-window and enlarge-window to window.el.
1515 * buffer.c: Temporarily extern Qdelete_window.
1516 (Fbury_buffer): Temporarily call Qdelete_window instead of
1517 Fdelete_window (Fbury_buffer will move to window.el soon).
1519 * frame.c (set_menu_bar_lines_1): Remove code handling
1520 orig_top_line and orig_total_lines.
1522 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1523 set_window_height but set heights directly.
1524 (change_frame_size_1): Use resize_frame_windows.
1526 * xdisp.c (init_xdisp): Don't use set_window_height but set
1529 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1530 resize_frame_windows instead of change_window_heights and run
1531 run_window_configuration_change_hook.
1533 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1534 instead of change_window_heights and run
1535 run_window_configuration_change_hook.
1537 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1539 * window.c (replace_window): Rename second argument REPLACEMENT to
1540 NEW. New third argument SETFLAG. Rewrite.
1541 (delete_window, make_dummy_parent): Call replace_window with
1543 (window_list_1): Move down in code.
1544 (run_window_configuration_change_hook): Move set_buffer part
1545 before select_frame_norecord part in order to unwind correctly.
1546 Rename count1 to count.
1547 (recombine_windows, delete_deletable_window, resize_root_window)
1548 (Fdelete_other_windows_internal)
1549 (Frun_window_configuration_change_hook, make_parent_window)
1550 (resize_window_check, resize_window_apply, Fresize_window_apply)
1551 (resize_frame_windows, Fsplit_window_internal)
1552 (Fdelete_window_internal, Fresize_mini_window_internal): New
1554 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1556 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1558 * window.h (window): Add some new members to window structure -
1559 normal_lines, normal_cols, new_total, new_normal, clone_number,
1560 splits, nest, prev_buffers, next_buffers.
1561 (WINDOW_TOTAL_SIZE): Move here from window.c.
1562 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1564 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1566 (make_dummy_parent): Set new members of windows structure.
1567 (make_window): Move down in code. Handle new members of window
1569 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1570 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1571 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1572 (Fset_window_prev_buffers, Fwindow_next_buffers)
1573 (Fset_window_next_buffers, Fset_window_clone_number): New
1575 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1576 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1578 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1579 Argument WINDOW can be now internal window too.
1580 (Fwindow_use_time): Move up in code.
1581 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1583 (Fset_window_configuration, saved_window)
1584 (Fcurrent_window_configuration, save_window_save): Handle new
1585 members of window structure.
1586 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1587 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1588 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1589 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1590 Qget_mru_window, Qresize_root_window,
1591 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1592 Qauto_buffer_name; staticpro them.
1594 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1596 * window.c (Fwindow_total_size, Fwindow_left_column)
1597 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1598 (Fwindow_list_1): New functions.
1599 (window_box_text_cols): Replace with window_body_cols.
1600 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1601 window_body_cols instead of window_box_text_cols.
1602 (delete_window, Fset_window_configuration): Call
1603 delete_all_subwindows with window as argument.
1604 (delete_all_subwindows): Take a window as argument and not a
1606 (window_loop): Remove handling of GET_LRU_WINDOW and
1608 (Fget_lru_window, Fget_largest_window): Move to window.el.
1610 * window.h: Extern window_body_cols instead of
1611 window_box_text_cols. delete_all_subwindows now takes a
1612 Lisp_Object as argument.
1614 * indent.c (compute_motion, Fcompute_motion): Use
1615 window_body_cols instead of window_box_text_cols.
1617 * frame.c (delete_frame): Call delete_all_subwindows with root
1620 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1622 * fns.c (Fputhash): Document return value.
1624 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1626 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1628 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1630 Cons<->int and similar integer overflow fixes (Bug#8794).
1632 Check for overflow when converting integer to cons and back.
1633 * charset.c (Fdefine_charset_internal, Fdecode_char):
1634 Use cons_to_unsigned to catch overflow.
1635 (Fencode_char): Use INTEGER_TO_CONS.
1636 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1637 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1638 * data.c (long_to_cons, cons_to_long): Remove.
1639 (cons_to_unsigned, cons_to_signed): New functions.
1640 These signal an error for invalid or out-of-range values.
1641 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1642 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1643 * font.c (Ffont_variation_glyphs):
1644 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1645 * lisp.h: Include <intprops.h>.
1646 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1647 (cons_to_signed, cons_to_unsigned): New decls.
1648 (long_to_cons, cons_to_long): Remove decls.
1649 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1650 (Fprimitive_undo): Use CONS_TO_INTEGER.
1651 * xfns.c (Fx_window_property): Likewise.
1652 * xselect.c: Include <limits.h>.
1653 (x_own_selection, selection_data_to_lisp_data):
1654 Use INTEGER_TO_CONS.
1655 (x_handle_selection_request, x_handle_selection_clear)
1656 (x_get_foreign_selection, Fx_disown_selection_internal)
1657 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1658 (lisp_data_to_selection_data): Use cons_to_unsigned.
1659 (x_fill_property_data): Use cons_to_signed.
1660 Report values out of range.
1662 Check for buffer and string overflow more precisely.
1663 * buffer.h (BUF_BYTES_MAX): New macro.
1664 * lisp.h (STRING_BYTES_MAX): New macro.
1665 * alloc.c (Fmake_string):
1666 * character.c (string_escape_byte8):
1667 * coding.c (coding_alloc_by_realloc):
1668 * doprnt.c (doprnt):
1669 * editfns.c (Fformat):
1671 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1672 since they may not be the same number.
1673 * editfns.c (Finsert_char):
1674 * fileio.c (Finsert_file_contents):
1675 Likewise for BUF_BYTES_MAX.
1677 * image.c: Use ptrdiff_t, not int, for sizes.
1678 (slurp_file): Switch from int to ptrdiff_t.
1680 (slurp_file): Check that file size fits in both size_t (for
1681 malloc) and ptrdiff_t (for sanity and safety).
1683 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1684 if b->modtime has its maximal value.
1686 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1688 Don't assume time_t can fit into int.
1689 * buffer.h (struct buffer.modtime): Now time_t, not int.
1690 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1691 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1693 Minor fixes for signed vs unsigned integers.
1694 * character.h (MAYBE_UNIFY_CHAR):
1695 * charset.c (maybe_unify_char):
1696 * keyboard.c (read_char, reorder_modifiers):
1697 XINT -> XFASTINT, since the integer must be nonnegative.
1698 * ftfont.c (ftfont_spec_pattern):
1699 * keymap.c (access_keymap, silly_event_symbol_error):
1700 XUINT -> XFASTINT, since the integer must be nonnegative.
1701 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1702 since it makes no difference and we prefer signed.
1703 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1704 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1707 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1709 * window.h (Fwindow_frame): Declare.
1711 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1713 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1714 (SPARE_MEMORY): Always define.
1715 (LARGE_REQUEST): Remove.
1716 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1718 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1720 * lisp.h: Move EXFUNS for Fframe_root_window,
1721 Fframe_first_window and Fset_frame_selected_window to window.h.
1723 * window.h: Move EXFUNS for Fframe_root_window,
1724 Fframe_first_window and Fset_frame_selected_window here from
1727 * frame.c (Fwindow_frame, Fframe_first_window)
1728 (Fframe_root_window, Fframe_selected_window)
1729 (Fset_frame_selected_window): Move to window.c.
1730 (Factive_minibuffer_window): Move to minibuf.c.
1731 (Fother_visible_frames_p): New function.
1733 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1735 * window.c (decode_window, decode_any_window): Move up in code.
1736 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1737 (inhibit_frame_unsplittable): Remove unused variable.
1738 (Fwindow_buffer): Move up and rewrite doc-string.
1739 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1740 (Fwindow_prev): New functions.
1741 (Fwindow_frame): Move here from frame.c. Accept any window as
1743 (Fframe_root_window, Fframe_first_window)
1744 (Fframe_selected_window): Move here from frame.c. Accept frame
1745 or arbitrary window as argument. Update doc-strings.
1746 (Fminibuffer_window): Move up in code.
1747 (Fwindow_minibuffer_p): Move up in code and simplify.
1748 (Fset_frame_selected_window): Move here from frame.c.
1750 (Fselected_window, select_window, Fselect_window): Move up in
1751 code. Minor doc-string fixes.
1753 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1755 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1756 Do not assume that spare memory exists; that assumption is valid
1757 only if SYSTEM_MALLOC.
1758 (LARGE_REQUEST): New macro, so that the issue of large requests
1759 is separated from the issue of spare memory.
1761 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1763 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1766 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1768 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1771 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1773 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1775 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1777 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1778 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1780 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1782 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1784 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1786 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1787 (x_clipboard_manager_save): Add return value.
1788 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1790 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1791 Obey Vx_select_enable_clipboard_manager. Catch errors in
1792 x_clipboard_manager_save (Bug#8779).
1793 (Vx_select_enable_clipboard_manager): New variable.
1794 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1796 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1798 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1800 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1802 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1803 in the current matrix if keep_current_p is non-zero.
1805 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1807 * bidi.c (bidi_level_of_next_char): Fix last change.
1809 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1811 Support bidi reordering of text covered by display properties.
1813 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1814 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1815 (bidi_cache_search, bidi_cache_iterator_state)
1816 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1817 (bidi_level_of_next_char, bidi_move_to_visually_next):
1818 Support character positions inside a run of characters covered by a
1820 (bidi_paragraph_init, bidi_resolve_explicit_1)
1821 (bidi_level_of_next_char): Call bidi_fetch_char and
1822 bidi_fetch_char_advance instead of FETCH_CHAR and
1824 (bidi_init_it): Initialize new members.
1825 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1827 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1828 instead of using explicit *_CHAR codes.
1829 (bidi_resolve_explicit, bidi_resolve_weak):
1830 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1831 bidirectional text is supported only in multibyte buffers.
1832 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1833 it to initialize the frame_window_p member of struct bidi_it.
1834 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1835 (bidi_resolve_explicit, bidi_resolve_weak)
1836 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1837 bidi_it->nchars is non-positive.
1838 (bidi_level_of_next_char): Don't try to lookup the cache for the
1839 next/previous character if nothing is cached there yet, or if we
1840 were just reseat()'ed to a new position.
1842 * xdisp.c (set_cursor_from_row): Set start and stop points
1843 according to the row's direction when priming the loop that looks
1844 for the glyph on which to display cursor.
1845 (single_display_spec_intangible_p): Function deleted.
1846 (display_prop_intangible_p): Reimplement to call
1847 handle_display_spec instead of single_display_spec_intangible_p.
1848 Accept 3 additional arguments needed by handle_display_spec.
1849 This fixes incorrect cursor motion across display property with complex
1850 values: lists, `(when COND...)' forms, etc.
1851 (single_display_spec_string_p): Support property values that are
1852 lists with the argument STRING its top-level element.
1853 (display_prop_string_p): Fix the condition for processing a
1854 property that is a list to be consistent with handle_display_spec.
1855 (handle_display_spec): New function, refactored from the
1856 last portion of handle_display_prop.
1857 (compute_display_string_pos): Accept additional argument
1858 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1859 value of a `display' property is a "replacing spec".
1860 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1861 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1862 the display property, but just return a value indicating whether
1863 the display property will replace the characters it covers.
1864 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1865 frame_window_p members of struct bidi_it.
1866 (compute_display_string_pos, compute_display_string_end):
1868 (push_it): Accept second argument POSITION, where pop_it should
1869 jump to continue iteration.
1870 (reseat_1): Initialize bidi_it.disp_pos.
1872 * keyboard.c (adjust_point_for_property): Adjust the call to
1873 display_prop_intangible_p to its new signature.
1875 * dispextern.h (struct bidi_it): New member frame_window_p.
1876 (bidi_init_it): Update prototypes.
1877 (display_prop_intangible_p): Update prototype.
1878 (compute_display_string_pos, compute_display_string_end):
1880 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1883 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1885 Malloc failure behavior now depends on size of allocation.
1886 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1887 * lisp.h: Change signatures accordingly.
1888 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1889 All callers changed. (Bug#8762)
1891 * gnutls.c: Use Emacs's memory allocators.
1892 Without this change, the gnutls library would invoke malloc etc.
1893 directly, which causes problems on non-SYNC_INPUT hosts, and which
1894 runs afoul of improving memory_full behavior. (Bug#8761)
1895 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1896 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1897 xfree instead of the default malloc, realloc, free.
1898 (Fgnutls_boot): No need to check for memory allocation failure,
1899 since xmalloc does that for us.
1901 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1902 * category.c (hash_get_category_set):
1903 * ccl.c (ccl_driver):
1904 * charset.c (Fdefine_charset_internal):
1905 * charset.h (struct charset.hash_index):
1906 * composite.c (get_composition_id, gstring_lookup_cache)
1907 (composition_gstring_put_cache):
1908 * composite.h (struct composition.hash_index):
1909 * dispextern.h (struct image.hash):
1910 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1911 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1912 (hashfn_equal, hashfn_user_defined, make_hash_table)
1913 (maybe_resize_hash_table, hash_lookup, hash_put)
1914 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1915 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1916 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1917 * image.c (make_image, search_image_cache, lookup_image)
1918 (xpm_put_color_table_h):
1919 * lisp.h (struct Lisp_Hash_Table):
1920 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1921 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1922 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1923 * alloc.c (allocate_vectorlike):
1924 Check for overflow in vector size calculations.
1925 * ccl.c (ccl_driver):
1926 Check for overflow when converting EMACS_INT to int.
1927 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1928 need to be updated by these changes.
1929 * fns.c (make_hash_table, maybe_resize_hash_table):
1930 Check for integer overflow with large hash tables.
1931 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1932 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1933 (SXHASH_REDUCE): New macro.
1934 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1935 Use it instead of discarding useful hash info with large hash values.
1936 (sxhash_float): New function.
1937 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1938 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1939 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1940 Rewrite to use FIXNUM_BITS, as this simplifies things.
1941 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1942 Adjust signatures to match updated version of code.
1943 (consing_since_gc): Now EMACS_INT, since a single hash table can
1944 use more than INT_MAX bytes.
1946 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1948 Make it possible to build with GCC-4.6+ -O2 -flto.
1950 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1952 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1954 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1955 Call minibuffer-inactive-mode.
1957 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1959 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1960 Update dependencies.
1962 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1964 * data.c (init_data): Remove code for UTS, this system is not
1967 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1969 Don't force ./temacs to start in terminal mode.
1971 * frame.c (make_initial_frame): Initialize faces in all cases, not
1972 only when CANNOT_DUMP is defined.
1973 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1975 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1977 * dispnew.c (add_window_display_history): Use const for the string
1978 pointer. Remove declaration, not needed.
1980 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1982 Use 'inline', not 'INLINE'.
1983 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1984 * alloc.c, fontset.c (INLINE): Remove.
1985 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1986 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1987 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1988 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1989 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1991 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1993 Make it possible to run ./temacs.
1995 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1996 syms_of_callproc does the same thing. Remove test for
1997 "initialized", do it in the caller.
1998 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2000 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2002 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2003 (read_minibuf): Use get_minibuffer.
2004 (syms_of_minibuf): Use DEFSYM.
2005 (Qmetadata): New var.
2006 * data.c (Qbuffer): Don't make it static.
2007 (syms_of_data): Use DEFSYM.
2009 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2011 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2012 (CCL_CODE_MIN): New macro.
2014 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2016 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2018 * eval.c (Qdebug): Now static.
2019 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2020 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2021 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2023 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2025 * image.c: Various fixes to ImageMagick code comments.
2026 (Fimagemagick_types): Doc fix.
2028 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2030 Minor fixes prompted by GCC 4.6.0 warnings.
2032 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2034 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2035 (x_clipboard_manager_save_all): Move extern decl to ...
2036 * xterm.h: ... here, so that it can be checked for consistency.
2038 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2040 * xselect.c (x_clipboard_manager_save_frame)
2041 (x_clipboard_manager_save_all): New functions.
2042 (Fx_clipboard_manager_save): Lisp function deleted.
2044 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2045 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2047 * xterm.h: Update prototype.
2049 2011-05-28 William Xu <william.xwl@gmail.com>
2051 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2054 2011-05-28 Jim Meyering <meyering@redhat.com>
2056 Avoid a sign-extension bug in crypto_hash_function.
2057 * fns.c (to_uchar): Define.
2058 (crypto_hash_function): Use it to convert some newly-signed
2059 variables to unsigned, to avoid sign-extension bugs. For example,
2060 without this change, (md5 "truc") would evaluate to
2061 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2062 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2063 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2065 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2067 Integer overflow fixes.
2069 * dbusbind.c: Serial number integer overflow fixes.
2070 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2071 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2072 to hold a serial number that is too large for a fixnum.
2073 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2074 Check for serial numbers out of range. Decode any serial number
2075 that was so large that it became a float. (Bug#8722)
2077 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2078 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2079 Use XFASTINT rather than XUINT when numbers are nonnegative.
2080 (xd_append_arg, Fdbus_method_return_internal):
2081 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2082 arguments, check that Lisp number is nonnegative, rather than
2083 silently wrapping negative numbers around. (Bug#8722)
2084 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2087 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2089 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2091 ccl: add integer overflow checks
2092 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2093 (IN_INT_RANGE): New macros.
2094 (ccl_driver): Use them to check for integer overflow when
2095 decoding a CCL program. Many of the new checks are whether XINT (x)
2096 fits in int; it doesn't always, on 64-bit hosts. The new version
2097 doesn't catch all possible integer overflows, but it's an
2098 improvement. (Bug#8719)
2100 * alloc.c (make_event_array): Use XINT, not XUINT.
2101 There's no need for unsigned here.
2103 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2104 This follows up to the 2011-05-06 change that substituted uintptr_t
2105 for EMACS_INT. This case wasn't caught back then.
2107 Rework Fformat to avoid integer overflow issues.
2108 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2109 now (part of C89). Include <verify.h>.
2110 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2111 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2112 (Fformat): Avoid the prepass trying to compute sizes; it was only
2113 approximate and thus did not catch overflow reliably. Instead, walk
2114 through the format just once, formatting and computing sizes as we go,
2115 checking for integer overflow at every step, and allocating a larger
2116 buffer as needed. Keep track separately whether the format is
2117 multibyte. Keep only the most-recently calculated precision, rather
2118 than them all. Record whether each argument has been converted to
2119 string. Use EMACS_INT, not int, for byte and char and arg counts.
2120 Support field widths and precisions larger than INT_MAX. Avoid
2121 sprintf's undefined behavior with conversion specifications such as %#d
2122 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2123 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2124 formatting out-of-range floating point numbers with int
2127 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2129 * data.c: Avoid integer truncation in expressions involving floats.
2130 * data.c: Include <intprops.h>.
2131 (arith_driver): When there's an integer overflow in an expression
2132 involving floating point, convert the integers to floating point
2133 so that the resulting value does not suffer from catastrophic
2134 integer truncation. For example, on a 64-bit host (* 4
2135 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2136 Do not rely on undefined behavior after integer overflow.
2138 merge count_size_as_multibyte, parse_str_to_multibyte
2139 * character.c, character.h (count_size_as_multibyte):
2140 Rename from parse_str_to_multibyte; all uses changed.
2141 Check for integer overflow.
2142 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2143 since it's now a duplicate of the other. This is more of
2144 a character than a buffer op, so better that it's in character.c.
2145 * fns.c, print.c: Adjust to above changes.
2147 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2149 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2151 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2153 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2154 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2155 (x_clipboard_manager_save): Now static.
2156 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2158 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2159 (crypto_hash_function): Now static.
2160 Fix pointer signedness problems. Avoid unnecessary initializations.
2162 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2164 * termhooks.h (Vselection_alist): Make it terminal-local.
2166 * terminal.c (create_terminal): Initialize it.
2168 * xselect.c: Support for clipboard managers.
2169 (Vselection_alist): Move to termhooks.h as terminal-local var.
2170 (LOCAL_SELECTION): New macro.
2171 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2172 (symbol_to_x_atom): Remove gratuitous arg.
2173 (x_handle_selection_request, lisp_data_to_selection_data)
2174 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2175 (x_own_selection, x_get_local_selection, x_convert_selection):
2176 New arg, specifying work frame. Use terminal-local Vselection_alist.
2177 (some_frame_on_display): Delete unused function.
2178 (Fx_own_selection_internal, Fx_get_selection_internal)
2179 (Fx_disown_selection_internal, Fx_selection_owner_p)
2180 (Fx_selection_exists_p): New optional frame arg.
2181 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2182 (x_handle_selection_clear): Don't treat other terminals with the
2183 same keyboard specially. Use the terminal-local Vselection_alist.
2184 (x_clear_frame_selections): Use Frun_hook_with_args.
2186 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2188 * xterm.h: Add support for those atoms.
2190 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2192 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2193 (converted_selections, conversion_fail_tag): New global variables.
2194 (x_selection_request_lisp_error): Free the above.
2195 (x_get_local_selection): Remove unnecessary code.
2196 (x_reply_selection_request): Args changed; handle arbitrary array
2197 of converted selections stored in converted_selections.
2198 Separate the XChangeProperty and SelectionNotify steps.
2199 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2200 (x_convert_selection): New function.
2201 (x_handle_selection_event): Simplify.
2202 (x_get_foreign_selection): Don't ignore incoming requests while
2203 waiting for an answer; this will fail when we implement
2204 SAVE_TARGETS, and seems unnecessary anyway.
2205 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2206 (Vx_sent_selection_functions): Doc fix.
2208 2011-05-26 Leo Liu <sdl.web@gmail.com>
2210 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2212 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2214 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2216 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2217 for fringe update if it has periodic bitmap.
2218 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2219 and fringe_bitmap_periodic_p.
2221 * fringe.c (get_fringe_bitmap_data): New function.
2222 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2223 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2224 row. Mark glyph row for fringe update if periodicity changed.
2226 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2227 for fringe update unless it has periodic bitmap.
2229 2011-05-25 Kenichi Handa <handa@m17n.org>
2231 * xdisp.c (get_next_display_element): Set correct it->face_id for
2232 a static composition.
2234 2011-05-24 Leo Liu <sdl.web@gmail.com>
2237 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2239 * fns.c (crypto_hash_function, Fsha1): New function.
2240 (Fmd5): Use crypto_hash_function.
2241 (syms_of_fns): Add Ssha1.
2243 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2245 * gnutls.c: Remove unused macros.
2246 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2247 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2248 Remove macros that are defined and never used.
2249 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2251 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2253 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2254 (Fx_get_selection_internal): Minor cleanup.
2255 (Fx_own_selection_internal): Rename arguments for consistency with
2258 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2260 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2262 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2264 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2266 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2268 * dispnew.c (scrolling_window): Don't exclude the case that the
2269 last enabled row in the desired matrix touches the bottom boundary.
2271 2011-05-21 Glenn Morris <rgm@gnu.org>
2273 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2274 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2275 and add some more files.
2277 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2279 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2280 report_file_error introduced by the change from 2011-05-07.
2282 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2284 * systime.h (Time): Define only if emacs is defined.
2285 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2286 where the include path doesn't have X11/X.h by default. See
2287 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2289 2011-05-20 Kenichi Handa <handa@m17n.org>
2291 * composite.c (find_automatic_composition): Fix previous change.
2293 2011-05-20 Glenn Morris <rgm@gnu.org>
2295 * lisp.mk: New file, split from Makefile.in.
2296 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2297 (shortlisp): Remove.
2298 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2300 2011-05-19 Glenn Morris <rgm@gnu.org>
2302 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2303 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2304 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2305 (lisp): Set the order to that of loadup.el.
2306 (shortlisp): Make it a copy of $lisp.
2307 (SOME_MACHINE_LISP): Remove.
2308 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2309 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2311 2011-05-18 Kenichi Handa <handa@m17n.org>
2313 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2314 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2315 (find_automatic_composition): Mostly rewrite for efficiency.
2317 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2319 * makefile.w32-in: Update dependencies.
2321 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2323 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2324 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2326 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2328 Fix some integer overflow issues, such as string length overflow.
2330 * insdel.c (count_size_as_multibyte): Check for string overflow.
2332 * character.c (lisp_string_width): Check for string overflow.
2333 Use EMACS_INT, not int, for string indexes and lengths; in
2334 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2335 the resulting string length overflows an EMACS_INT; instead,
2336 report a string overflow if no precision given. When checking for
2337 precision exhaustion, use a check that cannot possibly have
2338 integer overflow. (Bug#8675)
2339 * character.h (lisp_string_width): Adjust to new signature.
2341 * alloc.c (string_overflow): New function.
2342 (Fmake_string): Use it. This doesn't change behavior, but saves
2343 a few bytes and will simplify future changes.
2344 * character.c (string_escape_byte8): Likewise.
2345 * lisp.h (string_overflow): New decl.
2347 Fixups, following up to the user-interface timestamp change.
2348 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2349 for UI timestamps, instead of unsigned long.
2350 * msdos.c (mouse_get_pos): Likewise.
2351 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2352 * w32gui.h (Time): Define by including "systime.h" rather than by
2353 declaring it ourselves. (Bug#8664)
2355 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2356 * image.c (clear_image_cache): Likewise.
2358 * term.c (term_mouse_position): Don't assume time_t wraparound.
2360 Be more systematic about user-interface timestamps.
2361 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2362 and sometimes 'EMACS_UINT', to represent these timestamps.
2363 This change causes it to use 'Time' uniformly, as that's what X uses.
2364 This makes the code easier to follow, and makes it easier to catch
2365 integer overflow bugs such as Bug#8664.
2366 * frame.c (Fmouse_position, Fmouse_pixel_position):
2367 Use Time, not unsigned long, for user-interface timestamps.
2368 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2369 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2370 * keyboard.h (last_event_timestamp): Likewise.
2371 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2372 * menu.h (xmenu_show): Likewise.
2373 * term.c (term_mouse_position): Likewise.
2374 * termhooks.h (struct input_event.timestamp): Likewise.
2375 (struct terminal.mouse_position_hook): Likewise.
2376 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2377 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2378 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2379 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2381 * menu.h, termhooks.h: Include "systime.h", for Time.
2383 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2384 Don't assume that the difference between two unsigned long values
2385 can fit into an integer. At this point, we know button_down_time
2386 <= event->timestamp, so the difference must be nonnegative, so
2387 there's no need to cast the result if double-click-time is
2388 nonnegative, as it should be; check that it's nonnegative, just in
2389 case. This bug is triggered when events are more than 2**31 ms
2390 apart (about 25 days). (Bug#8664)
2392 * xselect.c (last_event_timestamp): Remove duplicate decl.
2393 (x_own_selection): Remove needless cast to unsigned long.
2395 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2396 that always fit in int. Use a sentinel instead of a counter, to
2397 avoid a temp and to allay GCC's concerns about possible int overflow.
2398 * frame.h (struct frame): Use int for menu_bar_items_used
2399 instead of EMACS_INT, since it always fits in int.
2401 * menu.c (grow_menu_items): Check for int overflow.
2403 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2405 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2406 Before, the code was not consistent. These values cannot exceed
2407 2**31 - 1 so there's no need to make them unsigned.
2408 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2409 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2410 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2412 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2414 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2415 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2416 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2417 presumably because the widths might not match.
2419 * window.c (size_window): Avoid needless test at loop start.
2421 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2423 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2425 2011-05-12 Drew Adams <drew.adams@oracle.com>
2427 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2429 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2431 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2432 `width' to `bar_area_x' and `bar_area_width', respectively.
2433 (x_scroll_run): Take account of fringe background extension.
2435 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2436 Rename local vars `left' and `width' to `bar_area_x' and
2437 `bar_area_width', respectively.
2438 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2439 background extension.
2441 2011-05-10 Jim Meyering <meyering@redhat.com>
2443 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2445 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2447 * image.c (Finit_image_library): Return t for built-in image types,
2448 like pbm and xbm. (Bug#8640)
2450 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2452 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2454 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2456 * w32console.c (Fset_screen_color): Doc fix.
2457 (Fget_screen_color): New function.
2458 (syms_of_ntterm): Defsubr it.
2460 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2461 unlink the temporary file if Fcall_process didn't create it in the
2463 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2464 child process will be redirected to a file specified with `:file'.
2465 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2466 cue to call_process_cleanup not to close that handle.
2468 2011-05-07 Ben Key <bkey76@gmail.com>
2470 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2471 one of two shell specific rules, either bootstrap-temacs-CMD or
2472 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2473 to the previous implementation of the bootstrap-temacs rule.
2474 The bootstrap-temacs-CMD rule is similar to the previous
2475 implementation of the bootstrap-temacs rule except that it
2476 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2479 These changes, along with some changes to nt/configure.bat,
2480 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2481 earlier fix to add support for --cflags and --ldflags options
2482 that include quotes so that it works whether make uses cmd or
2485 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2487 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2488 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2490 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2491 a string. Handle both cases.
2492 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2493 (Fdbus_register_method): Use Qinvalid_function.
2495 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2497 * makefile.w32-in: Update dependencies.
2498 (LISP_H): Add inttypes.h and stdin.h.
2499 (PROCESS_H): Add unistd.h.
2501 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2503 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2504 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2506 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2508 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2510 * term.c (vfatal): Remove stray call to va_end.
2511 It's not needed and the C Standard doesn't allow it here anyway.
2513 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2514 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2516 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2519 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2521 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2523 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2525 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2527 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2529 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2530 * charset.c (Fdefine_charset_internal): Don't initialize
2531 charset.code_space[15]. The value was garbage, on hosts with
2532 32-bit int (Bug#8600).
2534 * lread.c (read_integer): Be more consistent with string-to-number.
2535 Use string_to_number to do the actual conversion; this avoids
2536 rounding errors and fixes some other screwups. Without this fix,
2537 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2538 (digit_to_number): Move earlier, for benefit of read_integer.
2539 Return -1 if the digit is out of range for the base, -2 if it is
2540 not a digit in any supported base. (Bug#8602)
2542 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2544 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2545 to match comment at start of function. This also removes a
2546 GCC warning about overflow in a 32+64-bit port.
2548 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2550 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2551 Reported by Stefan Monnier in
2552 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2553 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2554 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2556 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2557 (EMACS_UINTPTR): Likewise, with uintptr_t.
2559 * lisp.h: Prefer 64-bit EMACS_INT if available.
2560 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2561 on 32-bit hosts that have 64-bit int, so that they can access
2563 However, temporarily disable this change unless the temporary
2564 symbol WIDE_EMACS_INT is defined.
2566 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2568 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2569 This removes an assumption that EMACS_INT and long are the same
2570 width as pointers. The assumption is true for Emacs porting targets
2571 now, but we want to make other targets possible.
2572 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2573 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2574 In the rest of the code, change types of integers that hold casted
2575 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2576 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2577 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2578 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2579 No need to cast type when ORing.
2580 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2581 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2582 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2583 assume EMACS_INT is the same width as char *.
2584 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2585 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2586 Remove no-longer-needed casts.
2587 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2588 (xg_tool_bar_help_callback, xg_make_tool_item):
2589 Use EMACS_INTPTR to hold an integer
2590 that will be cast to void *; this can avoid a GCC warning
2591 if EMACS_INT is not the same width as void *.
2592 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2593 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2594 (current_message_1, set_message_1):
2595 Use a local to convert to proper width without a cast.
2596 * xmenu.c (dialog_selection_callback): Likewise.
2598 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2599 Also, don't assume VALBITS / RAND_BITS is less than 5,
2600 and don't rely on undefined behavior when shifting a 1 left into
2602 * lisp.h (get_random): Change signature to match.
2604 * lread.c (hash_string): Use size_t, not int, for hash computation.
2605 Normally we prefer signed values; but hashing is special, because
2606 it's better to use unsigned division on hash table sizes so that
2607 the remainder is nonnegative. Also, size_t is the natural width
2608 for hashing into memory. The previous code used 'int', which doesn't
2609 retain enough info to hash well into very large tables.
2610 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2612 * dbusbind.c: Don't possibly lose pointer info when converting.
2613 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2614 Use XPNTR rather than XHASH, so that the high-order bits of
2615 the pointer aren't lost when converting through void *.
2617 * eval.c (Fautoload): Don't double-shift a pointer.
2619 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2621 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2623 * gnutls.c (DEF_GNUTLS_FN):
2624 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2626 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2628 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2631 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2633 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2634 New version that can reserve upto 2GB of heap space.
2636 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2638 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2640 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2642 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2643 `gnutls_certificate_set_x509_key_file'.
2645 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2647 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2648 Update dependencies.
2650 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2652 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2653 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2654 Remove unused parameter `fildes'.
2655 * process.c (read_process_output, send_process): Don't pass it.
2657 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2659 Fix previous change: the library cache is defined in w32.c.
2660 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2661 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2663 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2665 Implement dynamic loading of GnuTLS on Windows.
2667 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2668 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2669 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2672 * gnutls.c (Qgnutls_dll): Define.
2673 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2674 (gnutls_*): Declare function pointers.
2675 (init_gnutls_functions): New function to initialize function pointers.
2676 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2677 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2678 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2679 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2680 (emacs_gnutls_write, emacs_gnutls_read)
2681 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2682 (Fgnutls_available_p): New function.
2683 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2684 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2685 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2687 * image.c: Include w32.h.
2688 (Vimage_type_cache): Delete.
2689 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2690 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2691 (w32_delayed_load): Move to w32.c.
2693 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2695 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2696 (w32_delayed_load): Move from image.c. When loading a library, record
2697 its filename in the :loaded-from property of the library id.
2698 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2699 Initialize and staticpro them.
2700 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2702 * process.c: Include lisp.h before w32.h, not after.
2703 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2704 instead of gnutls_record_check_pending.
2706 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2708 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2710 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2711 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2714 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2716 * xterm.c (x_set_frame_alpha): Do not set property on anything
2717 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2719 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2721 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2723 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2725 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2726 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2727 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2728 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2729 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2730 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2731 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2732 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2733 (Qgnutls_bootprop_callbacks_verify): Make static.
2735 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2737 * callproc.c: Indentation fixup.
2739 * sysdep.c (wait_for_termination_1): Make static.
2740 (wait_for_termination, interruptible_wait_for_termination):
2741 Move after wait_for_termination_1.
2743 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2745 * sysdep.c (interruptible_wait_for_termination): New function
2746 which is like wait_for_termination, but allows keyboard
2749 * callproc.c (Fcall_process): Add (:file "file") as an option for
2751 (Fcall_process_region): Ditto.
2753 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2755 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2756 rather than `XVECTOR (FOO)->size'.
2758 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2759 inttypes.h, as a gnulib replacement is used if it not available in
2762 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2764 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2765 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2766 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2768 * coding.c (coding_alloc_by_realloc): Error out if destination
2769 will grow beyond MOST_POSITIVE_FIXNUM.
2770 (decode_coding_emacs_mule): Abort if there isn't enough place in
2771 charbuf for the composition carryover bytes. Reserve an extra
2772 space for up to 2 characters produced in a loop.
2773 (decode_coding_iso_2022): Abort if there isn't enough place in
2774 charbuf for the composition carryover bytes.
2776 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2778 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2779 aborting when %lld or %lll format is passed.
2780 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2781 %llo or %llx format is passed. (Bug#8545)
2783 * window.c (window_scroll_line_based): Use a marker instead of
2784 simple variables to record original value of point. (Bug#7952)
2786 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2787 produced by %s or %c overflows available buffer space. (Bug#8545)
2789 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2791 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2792 (SIZE_MAX): Move defn after all includes, as they might #define it.
2794 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2796 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2798 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2800 * keyboard.c (Qdelayed_warnings_hook): Define.
2801 (command_loop_1): Run `delayed-warnings-hook'
2802 if Vdelayed_warnings_list is non-nil.
2803 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2804 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2806 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2808 * doprnt.c (doprnt): Don't return value smaller than the buffer
2809 size if the message was truncated. (Bug#8545).
2811 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2813 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2814 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2816 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2818 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2820 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2822 * makefile.w32-in: Update dependencies.
2824 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2826 Improve `doprnt' and its usage. (Bug#8545)
2827 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2828 `format_end'. Remove support for %l as a conversion specifier.
2829 Don't use xrealloc. Improve diagnostics when the %l size modifier
2830 is used. Update the commentary.
2832 * eval.c (verror): Simplify calculation of size_t.
2834 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2837 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2839 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2842 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2844 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2845 This makes this file independent of the recent pseudovector change.
2847 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2849 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2851 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2852 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2853 Remove unused local.
2854 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2856 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2857 GCC 4.6.0 optimizes based on type-based alias analysis.
2858 For example, if b is of type struct buffer * and v of type struct
2859 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2860 != &v->size, and therefore "v->size = 1; b->size = 2; return
2861 v->size;" must therefore return 1. This assumption is incorrect
2862 for Emacs, since it type-puns struct Lisp_Vector * with many other
2863 types. To fix this problem, this patch adds a new type struct
2864 vectorlike_header that documents the constraints on layout of vectors
2865 and pseudovectors, and helps optimizing compilers not get fooled
2866 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2867 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2868 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2870 (XSETPVECTYPE): Rewrite in terms of new macro.
2871 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2872 This is a bit clearer, and further avoids the possibility of
2873 undesirable aliasing.
2874 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2875 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2876 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2877 since Lisp_Subr is a special case (no "next" field).
2878 (ASIZE): Now uses header.size rather than size.
2879 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2880 to avoid the hassle of writing XVECTOR (foo)->header.size.
2881 (struct vectorlike_header): New type.
2882 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2883 object, to help avoid aliasing.
2884 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2885 (SUBRP): Likewise, since Lisp_Subr is a special case.
2886 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2887 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2888 (struct Lisp_Hash_Table): Combine first two members into a single
2889 struct vectorlike_header member. All uses of "size" and "next" members
2890 changed to be "header.size" and "header.next".
2891 * buffer.h (struct buffer): Likewise.
2892 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2893 * frame.h (struct frame): Likewise.
2894 * process.h (struct Lisp_Process): Likewise.
2895 * termhooks.h (struct terminal): Likewise.
2896 * window.c (struct save_window_data, struct saved_window): Likewise.
2897 * window.h (struct window): Likewise.
2898 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2899 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2900 * buffer.c (init_buffer_once): Likewise.
2901 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2903 * process.c (Fformat_network_address): Use local var for size,
2906 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2908 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2909 * data.c (atof): Remove decl; no longer used or needed.
2910 (digit_to_number): Move to lread.c.
2911 (Fstring_to_number): Use new string_to_number function, to be
2912 consistent with how the Lisp reader treats infinities and NaNs.
2913 Do not assume that floating-point numbers represent EMACS_INT
2914 without losing information; this is not true on most 64-bit hosts.
2915 Avoid double-rounding errors, by insisting on integers when
2916 parsing non-base-10 numbers, as the documentation specifies.
2917 * lisp.h (string_to_number): New decl, replacing ...
2918 (isfloat_string): Remove.
2919 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2920 (read1): Do not accept +. and -. as integers; this
2921 appears to have been a coding error. Similarly, do not accept
2922 strings like +-1e0 as floating point numbers. Do not report
2923 overflow for integer overflows unless the base is not 10 which
2924 means we have no simple and reliable way to continue.
2925 Break out the floating-point parsing into a new
2926 function string_to_number, so that Fstring_to_number parses
2927 floating point numbers consistently with the Lisp reader.
2928 (digit_to_number): Move here from data.c. Make it static inline.
2929 (E_CHAR, EXP_INT): Remove, replacing with ...
2930 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2931 (string_to_number): New function, replacing isfloat_string.
2932 This function checks for valid syntax and produces the resulting
2933 Lisp float number too. Rework it so that string-to-number
2934 no longer mishandles examples like "1.0e+". Use strtoumax,
2935 so that overflow for non-base-10 numbers is reported only when
2936 there's no portable and simple way to convert to floating point.
2938 * textprop.c (set_text_properties_1): Rewrite for clarity,
2939 and to avoid GCC warning about integer overflow.
2941 * intervals.h (struct interval): Use EMACS_INT for members
2942 where EMACS_UINT might cause problems. See
2943 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2944 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2945 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2947 (offset_intervals): Tell GCC not to worry about length overflow
2948 when negating a negative length.
2950 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2951 (overrun_check_free): Likewise.
2953 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2954 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2957 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2958 (gnutls_make_error): Rename local to avoid shadowing.
2959 (gnutls_emacs_global_deinit): ifdef out; not used.
2960 (Fgnutls_boot): Use const for pointer to readonly storage.
2961 Comment out unused local. Fix pointer signedness problems.
2963 * lread.c (openp): Don't stuff size_t into an 'int'.
2964 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2965 about possible signed overflow.
2967 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2968 (GDK_KEY_g): Don't define if already defined.
2969 (xg_prepare_tooltip): Avoid pointer signedness problem.
2970 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2972 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2973 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2975 * xfns.c (Fx_window_property): Simplify a bit,
2976 to make a bit faster and to avoid GCC 4.6.0 warning.
2977 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2979 * fns.c (internal_equal): Don't assume size_t fits in int.
2981 * alloc.c (compact_small_strings): Tighten assertion a little.
2983 Replace pEd with more-general pI, and fix some printf arg casts.
2984 * lisp.h (pI): New macro, generalizing old pEd macro to other
2985 conversion specifiers. For example, use "...%"pI"d..." rather
2986 than "...%"pEd"...".
2987 (pEd): Remove. All uses replaced with similar uses of pI.
2988 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2989 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2990 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2991 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2992 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2993 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2994 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2996 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2997 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2998 * print.c (safe_debug_print, print_object): Likewise.
2999 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3001 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3002 avoiding the 0 flag, which is not portable.
3003 * process.c (Fmake_network_process): Use pI to avoid cast.
3004 * region-cache.c (pp_cache): Likewise.
3005 * xdisp.c (decode_mode_spec): Likewise.
3006 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3007 behavior on 64-bit hosts with printf arg.
3008 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3009 (x_stop_queuing_selection_requests): Likewise.
3010 (x_get_window_property): Don't truncate byte count to an 'int'
3013 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3014 here, since it parses constructs like leading '-' and spaces,
3015 which are not wanted; and it overflows with large numbers.
3016 Instead, simply match F[0-9]+, which is what is wanted anyway.
3018 * alloc.c: Remove unportable assumptions about struct layout.
3019 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3020 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3021 (allocate_vectorlike, make_pure_vector): Use the new macros,
3022 plus offsetof, to remove unportable assumptions about struct layout.
3023 These assumptions hold on all porting targets that I know of, but
3024 they are not guaranteed, they're easy to remove, and removing them
3025 makes further changes easier.
3027 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3028 This doesn't fix a bug but makes the code clearer.
3029 (string_overrun_cookie): Now const. Use initializers that
3030 don't formally overflow signed char, to avoid warnings.
3031 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3032 can cause Emacs to crash when string overrun checking is enabled.
3033 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3034 multiple of sizeof (EMACS_INT); it need not be, if
3035 alignof(EMACS_INT) < sizeof (EMACS_INT).
3036 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3038 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3040 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3042 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3044 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3045 supposed to be handshaking. (Bug#8556)
3046 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3048 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3050 * lisp.h (Qdebug): List symbol.
3051 * eval.c (Qdebug): Restore global linkage.
3052 * keyboard.c (debug-on-event): New variable.
3053 (handle_user_signal): Break into debugger when debug-on-event
3054 matches the current signal symbol.
3056 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3058 * alloc.c (check_sblock, check_string_bytes)
3059 (check_string_free_list): Convert to standard C.
3061 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3063 * w32.c (emacs_gnutls_push): Fix typo.
3065 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3067 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3068 "cast to pointer from integer of different size".
3070 Improve doprnt and its use in verror. (Bug#8545)
3071 * doprnt.c (doprnt): Document the set of format control sequences
3072 supported by the function. Use SAFE_ALLOCA instead of always
3075 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3076 is one byte too soon. Don't use xrealloc; instead xfree and
3079 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3081 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3084 * gnutls.c: Renamed global_initialized to
3085 gnutls_global_initialized. Added internals for the
3086 :verify-hostname-error, :verify-error, and :verify-flags
3087 parameters of `gnutls-boot' and documented those parameters in the
3088 docstring. Start callback support.
3089 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3090 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3091 on error. Return error code.
3092 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3093 (emacs_gnutls_read): Likewise.
3094 (Fgnutls_boot): Return handshake error code.
3095 (emacs_gnutls_handle_error): New function.
3096 (wsaerror_to_errno): Likewise.
3098 * w32.h (emacs_gnutls_pull): Add prototype.
3099 (emacs_gnutls_push): Likewise.
3101 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3102 (emacs_gnutls_push): Likewise.
3104 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3106 * process.c (wait_reading_process_output): Check if GnuTLS
3107 buffered some data internally if no FDs are set for TLS
3110 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3111 (LIBS): Link to USER_LIBS.
3112 ($(BLD)/gnutls.$(0)): New target.
3114 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3116 * xdisp.c (handle_single_display_spec): Rename the
3117 display_replaced_before_p argument into display_replaced_p, to
3118 make it consistent with the commentary. Fix typos in the
3121 * textprop.c (syms_of_textprop): Remove dead code.
3122 (copy_text_properties): Delete obsolete commentary about an
3123 interface that was deleted long ago. Fix typos in the description
3126 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3127 to changes in oldXMenu/XMenu.h from 2011-04-16.
3128 <menu_help_message, prev_menu_help_message>: Constify.
3129 (IT_menu_make_room): menu->help_text is now `const char **';
3132 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3133 to changes in oldXMenu/XMenu.h from 2011-04-16.
3134 (struct XMenu): Declare `help_text' `const char **'.
3136 * xfaces.c <Qunspecified>: Make extern again.
3138 * syntax.c: Include sys/types.h before including regex.h, as
3141 * doc.c (get_doc_string): Improve the format passed to `error'.
3143 * doprnt.c (doprnt): Improve commentary.
3145 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3147 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3150 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3151 changes in globals.h immediately force recompilation.
3152 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3153 $(CURDIR)/s/ms-w32.h.
3154 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3156 * character.c (Fchar_direction): Function deleted.
3157 (syms_of_character): Don't defsubr it.
3158 <char-direction-table>: Deleted.
3160 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3162 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3163 * doprnt.c: Include limits.h.
3164 (SIZE_MAX): New macro.
3165 (doprnt): Return a size_t value. 2nd arg is now size_t.
3166 Many local variables are now size_t instead of int or unsigned.
3167 Improve overflow protection. Support `l' modifier for integer
3168 conversions. Support %l conversion. Don't assume an EMACS_INT
3169 argument for integer conversions and for %c.
3171 * lisp.h (doprnt): Restore prototype.
3173 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3176 * Makefile.in (base_obj): Add back doprnt.o.
3178 * deps.mk (doprnt.o): Add back prerequisites.
3179 (callint.o): Depend on character.h.
3181 * eval.c (internal_lisp_condition_case): Include the handler
3182 representation in the error message.
3183 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3184 when breaking from the loop.
3186 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3188 * callint.c (Fcall_interactively): When displaying error message
3189 about invalid control letter, pass the character's codepoint, not
3190 a pointer to its multibyte form. Improve display of the character
3191 in octal and display also its hex code.
3193 * character.c (char_string): Use %x to display the (unsigned)
3194 codepoint of an invalid character, to avoid displaying a bogus
3197 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3198 `error', not SYMBOL_NAME itself.
3200 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3201 character arguments to `error'.
3203 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3204 to `error' in error message about FINAL_CHAR argument. Make sure
3205 FINAL_CHAR is a character, and use %c when it is passed as
3206 argument to `error'.
3208 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3210 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3212 * w32.c: Include <time.h>.
3213 (sys_localtime): New function.
3215 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3217 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3219 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3221 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3223 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3226 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3228 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3229 gl_state.e_property when gl_state.object is Qt.
3231 * insdel.c (make_gap_larger): Remove limitation of buffer size
3234 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3236 * xdisp.c (lookup_glyphless_char_display)
3237 (produce_glyphless_glyph): Handle cons cell entry in
3238 glyphless-char-display.
3239 (Vglyphless_char_display): Document it.
3241 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3242 glyphless-char-display.
3244 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3246 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3248 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3250 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3251 definition for no-X builds.
3253 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3255 Static checks with GCC 4.6.0 and non-default toolkits.
3257 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3259 * process.c (keyboard_bit_set): Define only if SIGIO.
3260 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3261 (send_process): Repair possible setjmp clobbering.
3263 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3265 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3267 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3269 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3270 Define only if needed.
3272 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3273 by pacifying GCC about it. Maybe it's time to retire it?
3274 * xfaces.c (USG, __TIMEVAL__): Likewise.
3276 * dispextern.h (struct redisplay_interface): Rename param
3278 * termhooks.h (struct terminal): Likewise.
3279 * xterm.c (xembed_send_message): Likewise.
3281 * insdel.c (make_gap_smaller): Define only if
3282 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3284 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3287 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3288 so that we aren't warned about unused symbols.
3290 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3292 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3294 * xfns.c (x_real_positions): Mark locals as initialized.
3296 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3298 * xterm.c: Fix problems found by static analysis with other toolkits.
3299 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3300 (x_dispatch_event): Declare static if USE_GTK, and
3301 define if USE_GTK || USE_X_TOOLKIT.
3302 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3303 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3304 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3305 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3307 * xmenu.c (menu_help_callback): Pointer type fixes.
3308 Use const pointers when pointing at readonly data. Avoid pointer
3310 (FALSE): Remove unused macro.
3311 (update_frame_menubar): Remove unused decl.
3313 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3315 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3316 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3317 (single_menu_item): Rename local to avoid shadowing.
3319 * keyboard.c (make_lispy_event): Remove unused local var.
3321 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3322 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3324 * bitmaps: Change bitmaps from unsigned char back to the X11
3325 compatible char. Avoid the old compiler warnings about
3326 out-of-range initializers by using, for example, '\xab' rather
3329 * xgselect.c (xgselect_initialize): Check vs interface
3330 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3332 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3334 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3335 to read-only memory.
3337 * fns.c (vector): Remove; this old hack is no longer needed.
3339 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3341 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3343 * xrdb.c (x_load_resources): Omit unused local.
3345 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3346 (x_window): Rename locals to avoid shadowing.
3347 (USG): Use the kludged USG macro, to pacify gcc.
3349 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3350 (x_term_init): Remove local to avoid shadowing.
3352 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3354 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3355 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3357 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3359 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3361 Fix regex.c, syntax.c and friends for buffers > 2GB.
3362 * syntax.h (struct gl_state_s): Declare character position members
3365 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3367 * textprop.c (verify_interval_modification, interval_of):
3368 Declare arguments EMACS_INT.
3370 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3373 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3375 * indent.c (Fvertical_motion): Local variable it_start is now
3378 * regex.c (re_match, re_match_2, re_match_2_internal)
3379 (bcmp_translate, regcomp, regexec, print_double_string)
3380 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3381 (re_compile_pattern, re_exec): Declare arguments and local
3382 variables `size_t' and `ssize_t' and return values `regoff_t', as
3384 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3385 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3386 <compile_stack_type>: `size' and `avail' are now `size_t'.
3388 * regex.h <regoff_t>: Use ssize_t, not int.
3389 (re_search, re_search_2, re_match, re_match_2): Arguments that
3390 specify buffer/string position and length are now ssize_t and
3391 size_t. Return type is regoff_t.
3393 2011-04-16 Ben Key <bkey76@gmail.com>
3395 * nsfont.m: Fixed bugs in ns_get_family and
3396 ns_descriptor_to_entity that were caused by using free to
3397 deallocate memory blocks that were allocated by xmalloc (via
3398 xstrdup). This caused Emacs to crash when compiled with
3399 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3400 --enable-checking=xmallocoverrun). xfree is now used to
3401 deallocate these memory blocks.
3403 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3405 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3407 emacs_write: Accept and return EMACS_INT for sizes.
3408 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3410 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3411 Accept and return EMACS_INT.
3412 (emacs_gnutls_write): Return the number of bytes written on
3414 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3415 (emacs_read, emacs_write): Remove check for negative size, as the
3416 Emacs source code has been audited now.
3417 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3418 (emacs_read, emacs_write): Use it.
3419 * process.c (send_process): Adjust to the new signatures of
3420 emacs_write and emacs_gnutls_write. Do not attempt to store
3421 a byte offset into an 'int'; it might overflow.
3422 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3424 * sound.c: Don't assume sizes fit in 'int'.
3425 (struct sound_device.period_size, alsa_period_size):
3426 Return EMACS_INT, not int.
3427 (struct sound_device.write, vox_write, alsa_write):
3428 Accept EMACS_INT, not int.
3429 (wav_play, au_play): Use EMACS_INT to store sizes and to
3430 record read return values.
3432 2011-04-15 Ben Key <bkey76@gmail.com>
3434 * keyboard.c (Qundefined): Don't declare static since it is used
3436 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3437 static since they are used in nsfont.m.
3439 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3441 * process.c (Qprocessp): Don't declare static.
3442 * lisp.h (Qprocessp): Declare again.
3444 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3446 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3448 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3450 Improve C-level modularity by making more things 'static'.
3452 Don't publish debugger-only interfaces to other modules.
3453 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3454 (verify_bytepos, count_markers): Move decls to the only modules
3456 * region-cache.h (pp_cache): Likewise.
3457 * window.h (check_all_windows): Likewise.
3458 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3460 * sysdep.c (croak): Now static, if
3461 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3462 * syssignal.h (croak): Declare only if not static.
3464 * alloc.c (refill_memory_reserve): Now static if
3465 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3466 * lisp.h (refill_memory_reserve): Declare only if not static.
3468 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3469 Define only if USE_LUCID.
3471 * xrdb.c (x_customization_string, x_rm_string): Now static.
3473 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3474 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3476 * xdisp.c (draw_row_with_mouse_face): Now static.
3477 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3479 * window.h (check_all_windows): Mark externally visible.
3481 * window.c (window_deletion_count): Now static.
3483 * undo.c: Make symbols static if they're not exported.
3484 (last_undo_buffer, last_boundary_position, pending_boundary):
3487 * textprop.c (interval_insert_behind_hooks): Now static.
3488 (interval_insert_in_front_hooks): Likewise.
3490 * term.c: Make symbols static if they're not exported.
3491 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3492 (max_frame_lines, tty_set_terminal_modes):
3493 (tty_reset_terminal_modes, tty_turn_off_highlight):
3494 (get_tty_terminal): Now static.
3495 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3496 * termhooks.h (term_mouse_moveto): Do not declare if
3498 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3499 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3501 * sysdep.c: Make symbols static if they're not exported.
3502 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3504 (sigprocmask_set, full_mask): Remove; unused.
3505 (wait_debugging): Mark as visible.
3506 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3507 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3509 * syntax.c (syntax_temp): Define only if !__GNUC__.
3511 * sound.c (current_sound_device, current_sound): Now static.
3513 * search.c (searchbufs, searchbuf_head): Now static.
3515 * scroll.c (scroll_cost): Remove; unused.
3516 * dispextern.h (scroll_cost): Remove decl.
3518 * region-cache.h (pp_cache): Mark as externally visible.
3520 * process.c: Make symbols static if they're not exported.
3521 (process_tick, update_tick, create_process, chan_process):
3522 (Vprocess_alist, proc_buffered_char, datagram_access):
3523 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3524 (deactivate_process): Mark defn as static, as well as decl.
3525 * lisp.h (create_process): Remove decl.
3526 * process.h (chan_process, Vprocess_alist): Remove decls.
3528 * print.c: Make symbols static if they're not exported.
3529 (print_depth, new_backquote_output, being_printed, print_buffer):
3530 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3531 (print_interval, print_number_index, initial_stderr_stream):
3533 * lisp.h (Fprinc): Remove decl.
3534 (debug_output_compilation_hack): Mark as externally visible.
3536 * sysdep.c (croak): Move decl from here to syssignal.h.
3537 * syssignal.h (croak): Put it here, so the API can be checked when
3538 'croak' is called from dissociate_if_controlling_tty.
3540 * minibuf.c: Make symbols static if they're not exported.
3541 (minibuf_save_list, choose_minibuf_frame): Now static.
3542 * lisp.h (choose_minibuf_frame): Remove decl.
3544 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3546 * lread.c: Make symbols static if they're not exported.
3547 (read_objects, initial_obarray, oblookup_last_bucket_number):
3549 (make_symbol): Remove; unused.
3550 * lisp.h (initial_obarray, make_symbol): Remove decls.
3552 * keyboard.c: Make symbols static if they're not exported.
3553 (single_kboard, recent_keys_index, total_keys, recent_keys):
3554 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3555 (this_single_command_key_start, echoing, last_auto_save):
3556 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3557 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3558 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3559 (Vlispy_mouse_stem, double_click_count):
3561 (force_auto_save_soon): Define only if SIGDANGER.
3562 (ignore_mouse_drag_p): Now static if
3563 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3564 (print_help): Remove; unused.
3565 (stop_character, last_timer_event): Mark as externally visible.
3566 * keyboard.h (ignore_mouse_drag_p): Declare only if
3567 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3568 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3569 * lisp.h (echoing): Remove decl.
3570 (force_auto_save_soon): Declare only if SIGDANGER.
3571 * xdisp.c (redisplay_window): Simplify code, to make it more
3572 obvious that ignore_mouse_drag_p is not accessed if !defined
3573 USE_GTK && !defined HAVE_NS.
3575 * intervals.c: Make symbols static if they're not exported.
3576 (merge_properties_sticky, merge_interval_right, delete_interval):
3578 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3580 * insdel.c: Make symbols static if they're not exported.
3581 However, leave prepare_to_modify_buffer alone. It's never
3582 called from outside this function, but that appears to be a bug.
3583 (combine_after_change_list, combine_after_change_buffer):
3584 (adjust_after_replace, signal_before_change): Now static.
3585 (adjust_after_replace_noundo): Remove; unused.
3586 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3587 (signal_before_change): Remove decls.
3589 * indent.c (val_compute_motion, val_vmotion): Now static.
3591 * image.c: Make symbols static if they're not exported.
3592 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3594 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3595 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3597 * fringe.c (standard_bitmaps): Now static.
3598 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3600 * frame.c: Make symbols static if they're not exported.
3601 (x_report_frame_params, make_terminal_frame): Now static.
3602 (get_frame_param): Now static, unless HAVE_NS.
3603 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3604 (x_get_resource_string): Remove; not used.
3605 * frame.h (make_terminal_frame, x_report_frame_params):
3606 (x_get_resource_string); Remove decls.
3607 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3608 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3610 * font.c, fontset.c: Make symbols static if they're not exported.
3611 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3612 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3613 * font.c (font_close_object): Now static.
3614 * font.h (font_close_object): Remove.
3615 * fontset.c (FONTSET_OBJLIST): Remove.
3616 (free_realized_fontset) #if-0 the body, which does nothing.
3617 (face_suitable_for_char_p): #if-0, as it's never called.
3618 * fontset.h (face_suitable_for_char_p): Remove decl.
3619 * xfaces.c (face_at_string_position):
3620 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3621 since 0 is always ASCII.
3623 * fns.c (weak_hash_tables): Now static.
3625 * fileio.c: Make symbols static if they're not exported.
3626 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3627 (Vwrite_region_annotation_buffers): Now static.
3629 * eval.c: Make symbols static if they're not exported.
3630 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3631 * lisp.h (backtrace_list): Remove decl.
3633 * emacs.c: Make symbols static if they're not exported.
3634 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3635 (fatal_error_code, fatal_error_signal_hook, standard_args):
3637 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3638 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3639 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3640 * lisp.h (fatal_error_signal_hook): Remove decl.
3641 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3643 * editfns.c: Move a (normally-unused) function to its only use.
3644 * editfns.c, lisp.h (get_operating_system_release): Remove.
3645 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3646 worth the hassle of breaking this out.
3648 * xterm.c: Make symbols static if they're not exported.
3649 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3650 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3651 (x_destroy_window, x_delete_display):
3653 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3654 (x_mouse_leave): Remove; unused.
3655 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3656 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3657 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3659 (x_mouse_leave): Declare only if WINDOWSNT.
3660 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3661 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3664 * ftxfont.c: Make symbols static if they're not exported.
3665 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3667 * font.h (ftxfont_driver): Likewise.
3669 * xfns.c: Make symbols static if they're not exported.
3670 (x_last_font_name, x_display_info_for_name):
3671 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3672 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3673 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3674 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3675 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3676 (last_show_tip_args): Now static.
3677 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3678 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3679 (x_screen_planes): Remove; unused.
3680 * dispextern.h (x_screen_planes): Remove decl.
3682 * dispnew.c: Make symbols static if they're not exported.
3683 * dispextern.h (redraw_garbaged_frames, scrolling):
3684 (increment_row_positions): Remove.
3685 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3686 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3688 (redraw_garbaged_frames): Remove; unused.
3690 * xfaces.c: Make symbols static if they're not exported.
3691 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3693 * xterm.h (defined_color): Remove decls.
3694 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3695 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3696 (menu_face_changed_default, defined_color, free_realized_face):
3697 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3698 (ascii_face_of_lisp_face): Remove; unused.
3700 * xdisp.c: Make symbols static if they're not exported.
3701 * dispextern.h (scratch_glyph_row, window_box_edges):
3702 (glyph_to_pixel_coords, set_cursor_from_row):
3703 (get_next_display_element, set_iterator_to_next):
3704 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3705 (show_mouse_face): Remove decls
3706 * frame.h (message_buf_print): Likewise.
3707 * lisp.h (pop_message, set_message, check_point_in_composition):
3709 * xterm.h (set_vertical_scroll_bar): Likewise.
3710 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3711 (message_buf_print, scratch_glyph_row, displayed_buffer):
3712 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3713 (get_next_display_element, show_mouse_face, window_box_edges):
3714 (frame_to_window_pixel_xy, check_point_in_composition):
3715 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3716 (glyph_to_pixel_coords): Remove; unused.
3718 * dired.c (file_name_completion): Now static.
3720 * dbusbind.c (xd_in_read_queued_messages): Now static.
3722 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3723 * data.c (circular_list_error): Remove.
3725 * commands.h (last_point_position, last_point_position_buffer):
3726 (last_point_position_window): Remove decls.
3727 * keyboard.c: Make these variables static.
3729 * coding.h (coding, code_convert_region, encode_coding_gap):
3731 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3732 (iso_code_class, detect_coding, code_convert_region): Now static.
3733 (encode_coding_gap): Remove; unused.
3735 * chartab.c (chartab_chars, chartab_bits): Now static.
3737 * charset.h (charset_iso_8859_1): Remove decl.
3738 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3741 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3742 * ccl.c (Vccl_program_table): Now static.
3743 (check_ccl_update): Remove; unused.
3745 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3746 * category.h: ... from here.
3747 * category.c (check_category_table, set_category_set): Now static.
3749 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3750 * lisp.h: Remove these decls.
3752 * buffer.c (buffer_count): Remove unused var.
3754 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3755 so that it's not optimized away.
3756 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3757 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3758 exported only to the debugger.
3760 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3761 * atimer.h (run_all_atimers): Remove; not exported.
3763 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3764 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3765 was inaccessible from Lisp.
3766 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3767 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3769 alloc.c: Import and export fewer symbols, and remove unused items.
3770 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3772 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3773 it's not optimized away by whole-program optimization.
3774 (message_enable_multibyte, free_misc): Remove.
3775 (catchlist, handlerlist, mark_backtrace):
3776 Declare only if BYTE_MARK_STACK.
3777 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3778 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3779 (message_enable_multibyte): Remove decl.
3780 (free_misc, interval_free_list, float_block, float_block_index):
3781 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3782 (cons_free_list, last_marked_index):
3784 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3785 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3786 (mark_backtrace): Define only if BYTE_MARK_STACK.
3787 * xdisp.c (message_enable_multibyte): Now static.
3789 Declare Lisp_Object Q* variables to be 'static' if not exported.
3790 This makes it easier for human readers (and static analyzers)
3791 to see whether these variables are used from other modules.
3792 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3793 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3794 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3795 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3796 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3797 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3798 * xmenu.c, xselect.c:
3799 Declare Q* vars static if they are not used in other modules.
3800 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3801 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3802 Remove decls of unexported vars.
3803 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3805 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3807 Make Emacs functions such as Fatom 'static' by default.
3808 This makes it easier for human readers (and static analyzers)
3809 to see whether these functions can be called from other modules.
3810 DEFUN now defines a static function. To make the function external
3811 so that it can be used in other C modules, use the new macro DEFUE.
3812 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3813 (Finit_image_library):
3814 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3815 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3816 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3817 Remove decls, since these functions are now static.
3818 (Funintern, Fget_internal_run_time): New decls, since these functions
3819 were already external.
3821 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3822 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3823 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3824 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3825 * keyboard.c, keymap.c, lread.c:
3826 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3827 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3828 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3829 Mark functions with DEFUE instead of DEFUN,
3830 if they are used in other modules.
3831 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3832 decls for now-static functions.
3833 * buffer.h (Fdelete_overlay): Remove decl.
3834 * callproc.c (Fgetenv_internal): Mark as internal.
3835 * composite.c (Fremove_list_of_text_properties): Remove decl.
3836 (Fcomposition_get_gstring): New forward static decl.
3837 * composite.h (Fcomposite_get_gstring): Remove decl.
3838 * dired.c (Ffile_attributes): New forward static decl.
3839 * doc.c (Fdocumntation_property): New forward static decl.
3840 * eval.c (Ffetch_bytecode): New forward static decl.
3841 (Funintern): Remove extern decl; now in .h file where it belongs.
3842 * fileio.c (Fmake_symbolic_link): New forward static decl.
3843 * image.c (Finit_image_library): New forward static decl.
3844 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3845 * intervals.h (Fprevious_property_change):
3846 (Fremove_list_of_text_properties): Remove decls.
3847 * keyboard.c (Fthis_command_keys): Remove decl.
3848 (Fcommand_execute): New forward static decl.
3849 * keymap.c (Flookup_key): New forward static decl.
3850 (Fcopy_keymap): Now static.
3851 * keymap.h (Flookup_key): Remove decl.
3852 * process.c (Fget_process): New forward static decl.
3853 (Fprocess_datagram_address): Mark as internal.
3854 * syntax.c (Fsyntax_table_p): New forward static decl.
3855 (skip_chars): Remove duplicate decl.
3856 * textprop.c (Fprevious_property_change): New forward static decl.
3857 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3859 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3860 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3862 * editfns.c (Fformat): Remove unreachable code.
3864 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3866 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3869 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3871 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3872 when at ZV. (Bug#8487)
3874 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3876 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3878 * keyboard.c (parse_tool_bar_item): Likewise.
3879 * sound.c (sound_cleanup, alsa_close): Likewise.
3880 * termcap.c (tgetent): Likewise.
3881 * xfns.c (x_default_font_parameter): Likewise.
3882 * xsettings.c (read_and_apply_settings): Likewise.
3884 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3885 (overrun_check_free): Protoize.
3887 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3889 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3890 since callers should never pass a negative size.
3891 Change the signature to match that of plain 'read' and 'write'; see
3892 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3893 * lisp.h: Update prototypes of emacs_write and emacs_read.
3895 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3897 * xdisp.c (redisplay_window): Don't try to determine the character
3898 position of the scroll margin if the window start point w->startp
3899 is outside the buffer's accessible region. (Bug#8468)
3901 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3903 Fix write-region and its subroutines for buffers > 2GB.
3904 * fileio.c (a_write, e_write): Modify declaration of arguments and
3905 local variables to support buffers larger than 2GB.
3906 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3908 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3909 argument, local variables, and return value.
3911 * lisp.h: Update prototypes of emacs_write and emacs_read.
3913 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3915 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3917 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3919 Fix more problems found by GCC 4.6.0's static checks.
3921 * xdisp.c (vmessage): Use a better test for character truncation.
3923 * charset.c (load_charset_map): <, not <=, for optimization,
3924 and to avoid potential problems with integer overflow.
3925 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3926 * casetab.c (set_identity, shuffle): Likewise.
3927 * editfns.c (Fformat): Likewise.
3928 * syntax.c (skip_chars): Likewise.
3930 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3931 This also lets GCC 4.6.0 generate slightly better loop code.
3933 * callint.c (Fcall_interactively): <, not <=, for optimization.
3934 (Fcall_interactively): Count the number of arguments produced,
3935 not the number of arguments given. This is simpler and lets GCC
3936 4.6.0 generate slightly better code.
3938 * ftfont.c: Distingish more carefully between FcChar8 and char.
3939 The previous code passed unsigned char * to a functions like
3940 strlen and xstrcasecmp that expect char *, which does not
3941 conform to the C standard.
3942 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3943 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3944 char * when the C standard requires it.
3946 * keyboard.c (read_char): Remove unused var.
3948 * eval.c: Port to Windows vsnprintf (Bug#8435).
3950 (SIZE_MAX): Define if the headers do not.
3951 (verror): Do not give up if vsnprintf returns a negative count.
3952 Instead, grow the buffer. This ports to Windows vsnprintf, which
3953 does not conform to C99. Problem reported by Eli Zaretskii.
3954 Also, simplify the allocation scheme, by avoiding the need for
3955 calling realloc, and removing the ALLOCATED variable.
3957 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3959 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3960 But keep the doprint source code for now, as we might revamp it
3961 and use it again (Bug#8435).
3962 * lisp.h (doprnt): Remove.
3963 * Makefile.in (base_obj): Remove doprnt.o.
3964 * deps.mk (doprnt.o): Remove.
3966 error: Print 32- and 64-bit integers portably (Bug#8435).
3967 Without this change, on typical 64-bit hosts error ("...%d...", N)
3968 was used to print both 32- and 64-bit integers N, which relied on
3970 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3972 * lisp.h (error, verror): Mark as printf-like functions.
3973 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3974 Report overflow in size calculations when allocating printf buffer.
3975 Do not truncate output string at its first null byte.
3976 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3977 Truncate the output at a character boundary, since vsnprintf does not
3979 * charset.c (check_iso_charset_parameter): Convert internal
3980 character to string before calling 'error', since %c now has the
3982 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3983 overflow when computing char to be passed to 'error'. Do not
3984 pass Lisp_Object to 'error'; pass the integer instead.
3985 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3986 formatted with plain %d.
3988 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3990 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3992 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3994 * xterm.c (x_catch_errors): Remove duplicate declaration.
3996 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3998 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4000 2011-04-10 Jim Meyering <meyering@redhat.com>
4002 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4003 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4004 return ssize_t not "int", and use size_t as the buffer length.
4005 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4006 * gnutls.h: Update declarations.
4007 * process.c (read_process_output): Use ssize_t, to match.
4008 (send_process): Likewise.
4010 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4012 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4014 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4016 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4017 Use unsigned char, to match FcChar8 type definition.
4019 * xterm.c (handle_one_xevent):
4020 * xmenu.c (create_and_show_popup_menu):
4021 * xselect.c (x_decline_selection_request)
4022 (x_reply_selection_request): Avoid type-punned deref of X events.
4024 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4026 Fix some uses of `int' instead of EMACS_INT.
4027 * search.c (string_match_1, fast_string_match)
4028 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4029 (scan_buffer, find_next_newline_no_quit)
4030 (find_before_next_newline, search_command, Freplace_match)
4031 (Fmatch_data): Make some `int' variables be EMACS_INT.
4033 * xdisp.c (display_count_lines): 3rd argument and return value now
4034 EMACS_INT. All callers changed.
4035 (pint2hrstr): Last argument is now EMACS_INT.
4037 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4038 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4039 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4040 (decode_coding_utf_16, decode_coding_emacs_mule)
4041 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4042 (decode_coding_ccl, decode_coding_charset)
4043 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4044 (decode_coding_iso_2022, decode_coding_emacs_mule)
4045 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4046 <char_offset, last_offset>: Declare EMACS_INT.
4047 (encode_coding_utf_8, encode_coding_utf_16)
4048 (encode_coding_emacs_mule, encode_invocation_designation)
4049 (encode_designation_at_bol, encode_coding_iso_2022)
4050 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4051 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4053 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4054 (encode_invocation_designation): Last argument P_NCHARS is now
4056 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4057 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4059 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4062 * ccl.c (Fccl_execute_on_string): Declare some variables
4065 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4067 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4069 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4071 * process.c (Fformat_network_address): Doc fix.
4073 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4075 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4077 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4079 * keyboard.c (read_char): Call Lisp function help-form-show,
4080 instead of using internal_with_output_to_temp_buffer.
4081 (Qhelp_form_show): New var.
4082 (syms_of_keyboard): Use DEFSYM macro.
4084 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4086 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4088 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4090 * process.c (Flist_processes): Remove to Lisp.
4091 (list_processes_1): Delete.
4093 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4095 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4097 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4099 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4101 Fix more problems found by GCC 4.6.0's static checks.
4103 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4105 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4107 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4109 * xdisp.c (vmessage): Mark as a printf-like function.
4111 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4113 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4115 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4116 printf-like functions.
4117 (tiff_load): Add casts to remove these marks before passing them
4118 to system-supplied API.
4120 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4122 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4123 This avoids several warnings with gcc -Wstrict-overflow.
4124 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4125 directly, rather than having caller test rule sign. This avoids
4126 some unnecessary tests.
4127 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4128 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4129 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4131 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4132 (xfont_open): Avoid unnecessary tests.
4134 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4136 * composite.h, composite.c (composition_gstring_put_cache):
4137 Use EMACS_INT, not int, for length.
4139 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4140 breaking out part of COMPOSITION_DECODE_RULE.
4141 (COMPOSITION_DECODE_RULE): Use it.
4142 * composite.c (get_composition_id): Remove unused local vars,
4143 by using the new macro.
4145 * textprop.c (set_text_properties_1): Change while to do-while,
4146 since the condition is always true at first.
4148 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4149 (interval_deletion_adjustment): Return unsigned value.
4152 * process.c (list_processes_1, create_pty, read_process_output):
4153 (exec_sentinel): Remove vars that were set but not used.
4154 (create_pty): Remove unnecessary "volatile"s.
4155 (Fnetwork_interface_info): Avoid possibility of int overflow.
4156 (read_process_output): Do adaptive read buffering even if carryover.
4157 (read_process_output): Simplify nbytes computation if buffered.
4159 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4161 * syntax.c (scan_words): Remove var that was set but not used.
4162 (update_syntax_table): Use unsigned instead of int.
4164 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4165 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4166 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4168 * print.c (print_error_message): Avoid int overflow.
4170 * font.c (font_list_entities): Redo for clarity,
4171 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4173 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4174 (font_score): Avoid potential overflow in diff calculation.
4176 * fns.c (substring_both): Remove var that is set but not used.
4177 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4179 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4181 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4182 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4183 can always succeed if overflow has undefined behavior.
4185 * search.c (boyer_moore, wordify): Remove vars set but not used.
4186 (wordify): Omit three unnecessary tests.
4188 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4189 All callers changed. This avoids the need for an unused var.
4191 * casefiddle.c (casify_region): Remove var that is set but not used.
4193 * dired.c (file_name_completion): Remove var that is set but not used.
4195 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4197 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4198 (Finsert_file_contents): Remove unnecessary code checking fd.
4200 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4201 Check for integer overflow on size calculations.
4203 * buffer.c (Fprevious_overlay_change): Remove var that is set
4206 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4207 Remove vars that are set but not used.
4208 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4209 (timer_check_2): Mark vars as initialized.
4211 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4213 * image.c (lookup_image): Remove var that is set but not used.
4214 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4216 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4217 that are set but not used.
4219 * xfns.c (make_invisible_cursor): Don't return garbage
4220 if XCreateBitmapFromData fails (Bug#8410).
4222 * xselect.c (x_get_local_selection, x_handle_property_notify):
4223 Remove vars that are set but not used.
4225 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4226 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4228 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4229 Remove var that is set but not used.
4230 (scroll_bar_windows_size): Now size_t, not int.
4231 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4234 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4235 (map_tty_color) [!defined MSDOS]: Likewise.
4237 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4239 * coding.c: Remove vars that are set but not used.
4240 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4241 All callers changed.
4242 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4243 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4244 (decode_coding_charset): Remove vars that are set but not used.
4246 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4247 that is set but not used.
4249 * print.c (print_object): Remove var that is set but not used.
4251 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4252 The gnulib version avoids calling malloc in the usual case,
4253 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4254 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4255 * filelock.c (current_lock_owner): Likewise.
4256 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4257 * sysdep.c: Include allocator.h, careadlinkat.h.
4258 (emacs_no_realloc_allocator): New static constant.
4259 (emacs_readlink): New function.
4260 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4261 ../lib/careadlinkat.h.
4263 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4265 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4266 first non-nil return value).
4268 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4270 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4271 if not defined (Bug#8403).
4273 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4275 * xdisp.c (display_count_lines): Remove parameter `start',
4276 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4277 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4278 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4279 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4280 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4281 and thereabouts. All callers changed.
4282 (get_per_char_metric): Remove parameter `f', unused since
4283 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4285 2011-04-02 Jim Meyering <meyering@redhat.com>
4287 do not dereference NULL upon failed strdup
4288 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4289 (ns_get_family): Likewise.
4291 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4293 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4295 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4297 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4300 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4302 Add lexical binding.
4304 * window.c (Ftemp_output_buffer_show): New fun.
4305 (Fsave_window_excursion):
4306 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4308 * lread.c (lisp_file_lexically_bound_p): New function.
4309 (Fload): Bind Qlexical_binding.
4310 (readevalloop): Remove `evalfun' arg.
4311 Bind Qinternal_interpreter_environment.
4312 (Feval_buffer): Bind Qlexical_binding.
4313 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4315 (syms_of_lread): Declare `lexical-binding'.
4317 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4319 * keyboard.c (eval_dyn): New fun.
4320 (menu_item_eval_property): Use it.
4322 * image.c (parse_image_spec): Use Ffunctionp.
4324 * fns.c (concat, mapcar1): Accept byte-code-functions.
4326 * eval.c (Fsetq): Handle lexical vars.
4327 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4328 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4329 (FletX, Flet): Obey lexical binding.
4330 (Fcommandp): Handle closures.
4331 (Feval): New `lexical' arg.
4332 (eval_sub): New function extracted from Feval. Use it almost
4333 everywhere where Feval was used. Look up vars in lexical env.
4335 (Ffunctionp): Move from subr.el.
4336 (Ffuncall): Handle closures.
4337 (apply_lambda): Remove `eval_flags'.
4338 (funcall_lambda): Handle closures and new byte-code-functions.
4339 (Fspecial_variable_p): New function.
4340 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4341 but without exporting it to Lisp.
4343 * doc.c (Fdocumentation, store_function_docstring):
4344 * data.c (Finteractive_form): Handle closures.
4346 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4349 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4351 (exec_byte_code): New function extracted from Fbyte_code to handle new
4352 calling convention for byte-code-functions. Add new byte-codes.
4354 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4356 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4358 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4360 * xdisp.c (redisplay_internal): Fix prototype.
4362 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4364 * xdisp.c (SCROLL_LIMIT): New macro.
4365 (try_scrolling): Use it when setting scroll_limit.
4366 Limit scrolling to 100 screen lines.
4367 (redisplay_window): Even when falling back on "recentering",
4368 position point in the window according to scroll-conservatively,
4369 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4371 (try_scrolling): When point is above the window, allow searching
4372 as far as scroll_max, or one screenful, to compute vertical
4373 distance from PT to the scroll margin position. This prevents
4374 try_scrolling from unnecessarily failing when
4375 scroll-conservatively is set to a value slightly larger than the
4376 window height. Clean up the case of PT below the margin at bottom
4377 of window: scroll_max can no longer be INT_MAX. When aggressive
4378 scrolling is in use, don't let point enter the opposite scroll
4379 margin as result of the scroll.
4380 (syms_of_xdisp) <scroll-conservatively>: Document the
4381 threshold of 100 lines for never-recentering scrolling.
4383 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4385 * dispextern.h (move_it_by_lines):
4386 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4387 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4388 (message_log_check_duplicate): Remove parameters `prev_bol' and
4389 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4390 (redisplay_internal): Remove parameter `preserve_echo_area',
4391 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4393 * indent.c (Fvertical_motion):
4394 * window.c (window_scroll_pixel_based, Frecenter):
4395 Don't pass `need_y_p' to `move_it_by_lines'.
4397 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4399 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4400 steal a few bits to be more compact.
4401 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4402 Remove unneeded casts.
4404 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4406 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4408 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4409 binding" message (bug#7967).
4411 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4413 Fix more problems found by GCC 4.6.0's static checks.
4415 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4416 Remove unused local var.
4418 * editfns.c (Fmessage_box): Remove unused local var.
4420 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4421 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4422 Omit unused local vars.
4423 * window.c (shrink_windows): Omit unused local var.
4424 * menu.c (digest_single_submenu): Omit unused local var.
4425 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4426 Omit unused local var.
4428 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4429 Don't assume string length fits in int.
4430 (keyremap_step, read_key_sequence): Use size_t for sizes.
4431 (read_key_sequence): Don't check last_real_key_start redundantly.
4433 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4434 instead of alloca (Bug#8344).
4436 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4437 (Fbacktrace_frame): Don't assume nframes fits in int.
4439 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4441 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4444 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4446 * cm.c (calccost): Turn while-do into do-while, for clarity.
4448 * keyboard.c (syms_of_keyboard): Use the same style as later
4449 in this function when indexing through an array. This also
4450 works around GCC bug 48267.
4452 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4454 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4456 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4457 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4459 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4460 This avoids undefined behavior on integer overflow, and is a bit
4461 more convenient anyway since it is compared to a size_t variable.
4463 Variadic C functions now count arguments with size_t, not int.
4464 This avoids an unnecessary limitation on 64-bit machines, which
4465 caused (substring ...) to crash on large vectors (Bug#8344).
4466 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4467 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4468 All variadic functions and their callers changed accordingly.
4469 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4470 * data.c (arith_driver, float_arith_driver): Likewise.
4471 * editfns.c (general_insert_function): Likewise.
4472 * eval.c (struct backtrace.nargs, interactive_p)
4473 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4474 (funcall_lambda, mark_backtrace): Likewise.
4475 * fns.c (concat): Likewise.
4476 * frame.c (x_set_frame_parameters): Likewise.
4477 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4478 0 if not found, not -1. All callers changed.
4480 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4481 (stack_copy_size): Now size_t, not int.
4482 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4484 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4486 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4487 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4488 All callers changed.
4490 * lisp.h (multibyte_char_to_unibyte):
4491 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4492 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4493 * character.h (CHAR_TO_BYTE8):
4494 * cmds.c (internal_self_insert):
4495 * editfns.c (general_insert_function):
4496 * keymap.c (push_key_description):
4497 * search.c (Freplace_match):
4498 * xdisp.c (message_dolog, set_message_1): All callers changed.
4500 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4502 * keyboard.c (safe_run_hook_funcall): New function.
4503 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4504 don't set the hook to nil, but remove the offending function instead.
4505 (Qcommand_hook_internal): Remove, unused.
4506 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4507 Vcommand_hook_internal.
4509 * eval.c (enum run_hooks_condition): Remove.
4510 (funcall_nil, funcall_not): New functions.
4511 (run_hook_with_args): Call each function through a `funcall' argument.
4512 Remove `cond' argument, now redundant.
4513 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4514 (Frun_hook_with_args_until_failure): Adjust accordingly.
4515 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4517 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4519 * dispextern.h (string_buffer_position): Remove declaration.
4521 * print.c (strout): Remove parameter `multibyte', unused since
4522 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4524 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4525 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4526 All callers changed.
4528 * w32.c (_wsa_errlist): Use braces for struct initializers.
4530 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4531 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4532 All callers changed.
4533 (string_buffer_position): Likewise. Also, make static (it's never
4534 used outside xdisp.c).
4535 (cursor_row_p): Remove parameter `w', unused since
4536 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4537 (decode_mode_spec): Remove parameter `precision', introduced during
4538 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4539 All callers changed.
4541 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4543 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4545 2011-03-27 Anders Lindgren <andlind@gmail.com>
4547 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4548 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4549 (ns_update_auto_hide_menu_bar): New functions.
4550 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4551 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4552 ns_constrain_all_frames.
4553 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4554 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4556 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4558 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4560 2011-03-27 Glenn Morris <rgm@gnu.org>
4562 * syssignal.h: Replace RETSIGTYPE with void.
4563 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4564 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4565 Replace SIGTYPE with void everywhere.
4566 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4567 * s/template.h (SIGTYPE): Remove commented out definition.
4569 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4571 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4572 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4574 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4576 * w32.c (read_unc_volume): Use parameter `henum', instead of
4577 global variable `wget_enum_handle'.
4579 * keymap.c (describe_vector): Remove parameters `indices' and
4580 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4581 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4583 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4585 * keyboard.c (timer_check): Remove parameter `do_it_now',
4586 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4587 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4588 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4590 * keyboard.c (read_char):
4591 * w32menu.c (w32_menu_display_help):
4592 * xmenu.c (show_help_event, menu_help_callback):
4593 Adjust calls to `show_help_echo'.
4595 * gtkutil.c (xg_maybe_add_timer):
4596 * keyboard.c (readable_events):
4597 * process.c (wait_reading_process_output):
4598 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4600 * insdel.c (adjust_markers_gap_motion):
4601 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4602 (gap_left, gap_right): Don't call it.
4604 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4606 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4607 incurred during fontification.
4609 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4611 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4612 (DEFVAR_PER_BUFFER): Don't pass it.
4614 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4615 (scrolling_window): Don't pass it.
4617 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4619 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4621 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4623 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4624 of variables specific to SELinux and computation of `encoded_absname'.
4626 * image.c (XPutPixel): Remove unused variable `height'.
4628 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4630 * unexw32.c (get_section_info): Remove unused variable `section'.
4632 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4633 (system_process_attributes): Remove unused variable `sess'.
4634 (sys_read): Remove unused variable `err'.
4636 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4637 (w32_wnd_proc): Remove unused variable `isdead'.
4638 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4639 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4640 (x_create_tip_frame): Remove unused variable `tem'.
4642 * w32inevt.c (w32_console_read_socket):
4643 Remove unused variable `no_events'.
4645 * w32term.c (x_draw_composite_glyph_string_foreground):
4646 Remove unused variable `width'.
4648 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4650 * w32term.c (x_set_glyph_string_clipping):
4651 Don't pass uninitialized region to CombineRgn.
4653 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4655 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4656 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4657 (Fx_close_connection): Remove unused variable `i'.
4659 * w32font.c (w32font_draw): Return number of glyphs.
4660 (w32font_open_internal): Remove unused variable `i'.
4661 (w32font_driver): Add missing initializer.
4663 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4664 (fill_in_menu): Remove unused variable `items_added'.
4666 * w32term.c (last_mouse_press_frame): Remove static global variable.
4667 (w32_clip_to_row): Remove unused variable `f'.
4668 (x_delete_terminal): Remove unused variable `i'.
4670 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4671 (NOTHING): Remove unused static global variable.
4672 (uniscribe_check_otf): Remove unused variable `table'.
4673 (uniscribe_font_driver): Add missing initializers.
4675 2011-03-23 Julien Danjou <julien@danjou.info>
4677 * term.c (Fsuspend_tty, Fresume_tty):
4678 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4679 * window.c (temp_output_buffer_show):
4680 * insdel.c (signal_before_change):
4681 * frame.c (Fhandle_switch_frame):
4682 * fileio.c (Fdo_auto_save):
4683 * emacs.c (Fkill_emacs):
4684 * editfns.c (save_excursion_restore):
4685 * cmds.c (internal_self_insert):
4686 * callint.c (Fcall_interactively):
4687 * buffer.c (Fkill_all_local_variables):
4688 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4690 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4691 unconditionnaly since it does the check itself.
4693 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4695 Fix more problems found by GCC 4.5.2's static checks.
4697 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4698 the first time through the loop, since we know p0 < p1 then.
4699 This also avoids a gcc -Wstrict-overflow warning.
4701 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4702 leading to a memory leak, possible in functions like
4703 load_charset_map_from_file that can allocate an unbounded number
4704 of objects (Bug#8318).
4706 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4707 that could (at least in theory) be that large.
4709 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4710 This is less likely to overflow, and avoids undefined behavior if
4711 overflow does occur. All callers changed. Use strtoul to scan
4712 for the unsigned long integer.
4713 (pint2hrstr): Simplify and tune code slightly.
4714 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4716 * scroll.c (do_scrolling): Work around GCC bug 48228.
4717 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4719 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4720 This also avoids a warning with gcc -Wstrict-overflow.
4721 (validate_x_resource_name): Simplify count usage.
4722 This also avoids a warning with gcc -Wstrict-overflow.
4724 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4727 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4729 * process.c (Fmake_network_process): Use socklen_t, not int,
4730 where POSIX says socklen_t is required in portable programs.
4731 This fixes a porting bug on hosts like 64-bit HP-UX, where
4732 socklen_t is wider than int (Bug#8277).
4733 (Fmake_network_process, server_accept_connection):
4734 (wait_reading_process_output, read_process_output):
4737 * process.c: Rename or move locals to avoid shadowing.
4738 (list_processes_1, Fmake_network_process):
4739 (read_process_output_error_handler, exec_sentinel_error_handler):
4740 Rename or move locals.
4741 (Fmake_network_process): Define label "retry_connect" only if needed.
4742 (Fnetwork_interface_info): Fix pointer signedness.
4743 (process_send_signal): Add cast to avoid pointer signedness problem.
4744 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4745 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4747 Make tparam.h and terminfo.c consistent.
4748 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4749 Include tparam.h instead, since it declares them.
4750 * cm.h (PC): Remove extern decl; tparam.h now does this.
4751 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4752 * terminfo.c: Include tparam.h, to check interfaces.
4753 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4754 (tparam): Adjust signature to match interface in tparam.h;
4755 this removes some undefined behavior. Check that outstring and len
4756 are zero, which they always are with Emacs.
4757 * tparam.h (PC, BC, UP): New extern decls.
4759 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4760 (xftfont_open): Rename locals to avoid shadowing.
4762 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4763 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4764 (OTF_TAG_SYM): Omit macro if not needed.
4765 (ftfont_list): Remove unused local.
4766 (get_adstyle_property, ftfont_pattern_entity):
4767 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4768 Rename locals to avoid shadowing.
4770 * xfont.c (xfont_list_family): Mark var as initialized.
4772 * xml.c (make_dom): Now static.
4774 * composite.c (composition_compute_stop_pos): Rename local to
4776 (composition_reseat_it): Remove unused locals.
4777 (find_automatic_composition, composition_adjust_point): Likewise.
4778 (composition_update_it): Mark var as initialized.
4779 (find_automatic_composition): Mark vars as initialized,
4780 with a FIXME (Bug#8290).
4782 character.h: Rename locals to avoid shadowing.
4783 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4784 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4785 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4786 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4789 * textprop.c (property_change_between_p): Remove; unused.
4791 * intervals.c (interval_start_pos): Now static.
4793 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4795 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4796 Rename locals to avoid shadowing.
4798 * sound.c (wav_play, au_play, Fplay_sound_internal):
4799 Fix pointer signedness.
4800 (alsa_choose_format): Remove unused local var.
4801 (wav_play): Initialize a variable to 0, to prevent undefined
4802 behavior (Bug#8278).
4804 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4806 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4808 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4809 clobbering (Bug#8298).
4810 * sysdep.c (sys_subshell): Likewise.
4811 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4813 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4814 This should get cleaned up, so that child_setup has the
4815 same signature on all platforms.
4817 * callproc.c (call_process_cleanup): Now static.
4818 (relocate_fd): Rename locals to avoid shadowing.
4820 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4822 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4823 not to be necessary, and produces flickering.
4825 2011-03-20 Glenn Morris <rgm@gnu.org>
4827 * config.in: Remove file.
4829 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4831 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4832 are now in src/globals.h.
4833 (syms_of_minibuf): Remove spurious & from previous change.
4835 2011-03-20 Leo <sdl.web@gmail.com>
4837 * minibuf.c (completing-read-function): New variable.
4838 (completing-read-default): Rename from completing-read.
4839 (completing-read): Call completing-read-function.
4841 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4843 * xfaces.c (Fx_load_color_file):
4844 Read color file from absolute filename (bug#8250).
4846 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4848 * makefile.w32-in: Update dependencies.
4850 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4852 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4854 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4856 Fix more problems found by GCC 4.5.2's static checks.
4858 * process.c (make_serial_process_unwind, send_process_trap):
4859 (sigchld_handler): Now static.
4861 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4862 That way, the code declares only the vars that it needs.
4863 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4864 * s/cygwin.h (PTY_ITERATION): Likewise.
4865 * s/darwin.h (PTY_ITERATION): Likewise.
4866 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4868 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4869 * process.c (allocate_pty): Don't declare stb unless it's needed.
4871 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4872 (CONSTANTLIM): Remove; unused.
4873 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4874 Define only if needed.
4876 * unexelf.c (unexec): Name an expression,
4877 to avoid gcc -Wbad-function-cast warning.
4878 Use a different way to cause a compilation error if anyone uses
4879 n rather than nn, a way that does not involve shadowing.
4880 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4882 * deps.mk (unexalpha.o): Remove; unused.
4884 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4885 * unexec.h: New file.
4886 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4887 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4889 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4890 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4891 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4892 Change as necessary to match prototype in unexec.h.
4894 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4896 (back_comment, skip_chars): Mark vars as initialized.
4898 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4899 Rename locals to avoid shadowing.
4901 * lread.c (read1): Rewrite so as not to use empty "else".
4902 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4904 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4906 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4907 warning when compiling print.c.
4909 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4910 instead of using an uninitialized var.
4911 (font_sort_entities): Mark var as initialized.
4913 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4915 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4916 pointers to constants.
4917 (font_parse_fcname): Remove unused vars.
4918 (font_delete_unmatched): Now static.
4919 (font_get_spec): Remove; unused.
4920 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4921 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4922 Rename or move locals to avoid shadowing.
4924 * fns.c (require_nesting_list, require_unwind): Now static.
4925 (Ffillarray): Rename locals to avoid shadowing.
4927 * floatfns.c (domain_error2): Define only if needed.
4928 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4930 * alloc.c (mark_backtrace): Move decl from here ...
4931 * lisp.h: ... to here, so that it can be checked.
4933 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4934 (Fdefvar): Rewrite so as not to use empty "else".
4935 (lisp_indirect_variable): Name an expression,
4936 to avoid gcc -Wbad-function-cast warning.
4937 (Fdefvar): Rename locals to avoid shadowing.
4939 * callint.c (quotify_arg, quotify_args): Now static.
4940 (Fcall_interactively): Rename locals to avoid shadowing.
4941 Use const pointer when appropriate.
4943 * lisp.h (get_system_name, get_operating_system_release):
4944 Move decls here, to check interfaces.
4945 * process.c (get_operating_system_release): Move decl to lisp.h.
4946 * xrdb.c (get_system_name): Likewise.
4947 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4948 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4949 some of which prompt warnings from gcc -Wbad-function-cast.
4950 (Fformat_time_string, Fencode_time, Finsert_char):
4951 (Ftranslate_region_internal, Fformat):
4952 Rename or remove local vars to avoid shadowing.
4953 (Ftranslate_region_internal): Mark var as initialized.
4955 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4958 * lisp.h (eassert): Check that the argument compiles, even if
4959 ENABLE_CHECKING is not defined.
4961 * data.c (Findirect_variable): Name an expression, to avoid
4962 gcc -Wbad-function-cast warning.
4963 (default_value, arithcompare, arith_driver, arith_error): Now static.
4964 (store_symval_forwarding): Rename local to avoid shadowing.
4965 (Fmake_variable_buffer_local, Fmake_local_variable):
4966 Mark variables as initialized.
4967 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4969 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4970 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4971 Rename locals to avoid shadowing.
4972 (mark_stack): Move local variables into the #ifdef region where
4974 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4975 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4977 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4978 (GC_STRING_CHARS): Remove; not used.
4979 (Fmemory_limit): Cast sbrk's returned value to char *.
4981 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4982 avoids undefined behavior in theory.
4984 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4986 Use functions, not macros, for up- and down-casing (Bug#8254).
4987 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4988 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4989 to use the following functions instead of these macros.
4990 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4991 EMACS_INT, since callers assume the returned value fits in int.
4992 (upcase1): Likewise, for UPCASE_TABLE.
4993 (uppercasep, lowercasep, upcase): New static inline functions.
4994 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4995 the race-condition problem in the old DOWNCASE.
4997 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4998 Rename locals to avoid shadowing.
4999 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5000 (regex_compile, re_search_2, re_match_2_internal):
5001 Remove unused local vars.
5002 (FREE_VAR): Rewrite so as not to use empty "else",
5003 which gcc can warn about.
5004 (regex_compile, re_match_2_internal): Mark locals as initialized.
5005 (RETALLOC_IF): Define only if needed.
5006 (WORDCHAR_P): Likewise. This one is never needed, but is used
5007 only in a comment talking about a compiler bug, so put inside
5008 the #if 0 of that comment.
5009 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5010 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5013 * search.c (boyer_moore): Rename locals to avoid shadowing.
5014 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5015 (PREV_CHAR_BOUNDARY): Likewise.
5017 * search.c (simple_search): Remove unused var.
5019 * dired.c (compile_pattern): Move decl from here ...
5020 * lisp.h: ... to here, so that it can be checked.
5021 (struct re_registers): New forward decl.
5023 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5025 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5027 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5028 Rename locals to avoid shadowing.
5029 (Fvertical_motion): Mark locals as initialized.
5031 * casefiddle.c (casify_object, casify_region): Now static.
5032 (casify_region): Mark local as initialized.
5034 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5036 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5037 New macros, so that the caller can use some names other than
5038 gcpro1, gcpro2, etc.
5039 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5041 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5042 argument, for consistency with GCPRO2_VAR, etc: it is now the
5043 prefix of the variable, not the variable itself. All uses
5045 * dired.c (directory_files_internal, file_name_completion):
5046 Rename locals to avoid shadowing.
5048 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5049 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5050 dired.c's scmp function, had undefined behavior.
5051 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5052 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5053 * buffer.h: ... to here, because these macros use current_buffer,
5054 and the new implementation with inline functions needs to have
5055 current_buffer in scope now, rather than later when the macros
5057 (downcase, upcase1): New static inline functions.
5058 (DOWNCASE, UPCASE1): Reimplement using these functions.
5059 This avoids undefined behavior in expressions like
5060 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5061 from race conditions in accessing the global variables
5062 case_temp1 and case_temp2.
5063 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5064 * lisp.h (case_temp1, case_temp2): Remove their decls.
5065 * character.h (ASCII_CHAR_P): Move from here ...
5066 * lisp.h: ... to here, so that the inline functions mentioned
5069 * dired.c (directory_files_internal_unwind): Now static.
5071 * fileio.c (file_name_as_directory, directory_file_name):
5072 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5074 (file_name_as_directory): Use const pointers when appropriate.
5075 (Fexpand_file_name): Likewise. In particular, newdir might
5076 point at constant storage, so make it a const pointer.
5077 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5078 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5080 (Fset_file_times, Finsert_file_contents, auto_save_error):
5081 Rename locals to avoid shadowing.
5083 * minibuf.c (choose_minibuf_frame_1): Now static.
5084 (Ftry_completion, Fall_completions): Rename or remove locals
5087 * marker.c (bytepos_to_charpos): Remove; unused.
5089 * lisp.h (verify_bytepos, count_markers): New decls,
5090 so that gcc does not warn that these functions aren't declared.
5092 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5093 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5094 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5095 (copy_text): Remove unused local var.
5097 * filelock.c (within_one_second): Now static.
5098 (lock_file_1): Rename local to avoid shadowing.
5100 * buffer.c (fix_overlays_before): Mark locals as initialized.
5101 (fix_start_end_in_overlays): Likewise. This function should be
5102 simplified by using pointers-to-pointers, but that's a different
5104 (switch_to_buffer_1): Now static.
5105 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5106 (report_overlay_modification): Rename locals to avoid shadowing.
5108 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5109 Fix pointer signedness issue.
5110 (sys_subshell): Mark local as volatile if checking for lint,
5111 to suppress a gcc -Wclobbered warning that does not seem to be right.
5112 (MAXPATHLEN): Define only if needed.
5114 * process.c (serial_open, serial_configure): Move decls from here ...
5115 * systty.h: ... to here, so that they can be checked.
5117 * fns.c (get_random, seed_random): Move extern decls from here ...
5118 * lisp.h: ... to here, so that they can be checked.
5120 * sysdep.c (reset_io): Now static.
5121 (wait_for_termination_signal): Remove; unused.
5123 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5124 (copy_keymap_item, append_key, push_text_char_description):
5126 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5127 (DENSE_TABLE_SIZE): Remove; unused.
5128 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5129 (describe_map_tree):
5130 Rename locals to avoid shadowing.
5132 * keyboard.c: Declare functions static if they are not used elsewhere.
5133 (echo_char, echo_dash, cmd_error, top_level_2):
5134 (poll_for_input, handle_async_input): Now static.
5135 (read_char, kbd_buffer_get_event, make_lispy_position):
5136 (make_lispy_event, make_lispy_movement, apply_modifiers):
5137 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5138 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5139 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5140 (read_key_sequence, read_char): Mark locals as initialized.
5141 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5143 * keyboard.h (make_ctrl_char): New decl.
5144 (mark_kboards): Move decl here ...
5145 * alloc.c (mark_kboards): ... from here.
5147 * lisp.h (force_auto_save_soon): New decl.
5149 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5150 (DEFINE_DUMMY_FUNCTION): New macro.
5151 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5153 (main): Add casts to avoid warnings
5154 if GCC considers string literals to be constants.
5156 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5158 * dbusbind.c: Pointer signedness fixes.
5159 (xd_signature, xd_append_arg, xd_initialize):
5160 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5161 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5162 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5163 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5165 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5166 if GCC considers string literals to be constants.
5167 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5169 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5171 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5172 (print_preprocess, print_object): New macro to fix last change.
5174 * print.c (print_preprocess): Don't forget font objects.
5176 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5178 * emacs.c (USAGE3): Doc fixes.
5180 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5182 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5185 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5187 * lisp.h (VWindow_system, Qfile_name_history):
5188 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5189 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5190 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5192 * w32select.c: Don't #include "keyboard.h".
5193 (run_protected): Add extern declaration for waiting_for_input.
5195 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5196 * w32console.c (detect_input_pending, read_input_pending)
5197 (encode_terminal_code):
5198 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5199 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5200 (w32_system_caret_y, Qfile_name_history):
5201 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5202 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5203 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5204 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5205 * w32proc.c (Qlocal, report_file_error):
5206 * w32term.c (Vwindow_system, updating_frame):
5207 * w32uniscribe.c (initialized, uniscribe_font_driver):
5208 Remove unneeded extern declarations.
5210 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5212 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5214 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5216 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5217 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5218 These macros can no longer be used for assignment.
5220 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5221 Assign struct members directly, instead of using BUF_BEGV etc.
5222 (record_buffer_markers, fetch_buffer_markers): New functions for
5223 recording and fetching special buffer markers.
5224 (set_buffer_internal_1, set_buffer_temp): Use them.
5226 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5228 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5230 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5231 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5233 * xdisp.c (hscroll_window_tree):
5234 (reconsider_clip_changes): Use PT instead of BUF_PT.
5236 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5238 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5239 $(EMACS_ROOT)/lib/intprops.h.
5241 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5243 Fix more problems found by GCC 4.5.2's static checks.
5245 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5246 to unsigned char * to avoid compiler diagnostic.
5247 (xg_free_frame_widgets): Make it clear that a local variable is
5248 needed only if USE_GTK_TOOLTIP.
5249 (gdk_window_get_screen): Make it clear that this macro is needed
5250 only if USE_GTK_TOOLTIP.
5251 (int_gtk_range_get_value): New function, which avoids a diagnostic
5252 from gcc -Wbad-function-cast.
5253 (xg_set_toolkit_scroll_bar_thumb): Use it.
5254 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5255 diagnostic from gcc -Wbad-function-cast.
5256 (get_utf8_string, xg_get_file_with_chooser):
5257 Rename locals to avoid shadowing.
5258 (create_dialog): Move locals to avoid shadowing.
5260 * xgselect.c (xg_select): Remove unused var.
5262 * image.c (four_corners_best): Mark locals as initialized.
5263 (gif_load): Initialize transparent_p to zero (Bug#8238).
5264 Mark another local as initialized.
5265 (my_png_error, my_error_exit): Mark with NO_RETURN.
5267 * image.c (clear_image_cache): Now static.
5268 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5269 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5270 (x_edge_detection): Remove unnecessary cast that
5271 gcc -Wbad-function-cast diagnoses.
5272 (gif_load): Fix pointer signedness.
5273 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5274 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5276 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5278 Improve quality of tests for time stamp overflow.
5279 For example, without this patch (encode-time 0 0 0 1 1
5280 1152921504606846976) returns the obviously-bogus value (-948597
5281 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5282 reports time overflow. See
5283 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5284 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5285 * editfns.c: Include limits.h and intprops.h.
5286 (TIME_T_MIN, TIME_T_MAX): New macros.
5287 (time_overflow): Move earlier, to before first use.
5288 (hi_time, lo_time): New functions, for an accurate test for
5290 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5291 (Fget_internal_run_time): Don't assume time_t fits in int.
5292 (make_time): Use list2 instead of Fcons twice.
5293 (Fdecode_time): More accurate test for out-of-range times.
5294 (check_tm_member): New function.
5295 (Fencode_time): Use it, to test for out-of-range times.
5296 (lisp_time_argument): Don't rely on undefined left-shift and
5297 right-shift behavior when checking for time stamp overflow.
5299 * editfns.c (time_overflow): New function, refactoring common code.
5300 (Fformat_time_string, Fdecode_time, Fencode_time):
5301 (Fcurrent_time_string): Use it.
5303 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5304 * dired.c (make_time): Move to ...
5305 * editfns.c (make_time): ... here.
5306 * systime.h: Note the move.
5308 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5310 * fringe.c (update_window_fringes): Remove unused variables.
5312 * unexmacosx.c (copy_data_segment): Also copy __got section.
5315 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5317 * termcap.c [MSDOS]: Include "msdos.h".
5318 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5319 Constify `char *' arguments and their references according to
5320 prototypes in tparam.h.
5322 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5324 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5325 Adapt all references accordingly.
5327 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5329 2011-03-11 Tom Tromey <tromey@redhat.com>
5331 * buffer.c (syms_of_buffer): Remove obsolete comment.
5333 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5335 * termhooks.h (encode_terminal_code): Declare prototype.
5337 * msdos.c (encode_terminal_code): Don't declare prototype.
5339 * term.c (encode_terminal_code): Now external again, used by
5340 w32console.c and msdos.c.
5342 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5343 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5345 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5347 Fix some minor problems found by GCC 4.5.2's static checks.
5349 * fringe.c (update_window_fringes): Mark locals as initialized
5351 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5353 * alloc.c (mark_fringe_data): Move decl from here ...
5354 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5355 to check its interface.
5356 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5358 * fontset.c (free_realized_fontset): Now static.
5359 (Fset_fontset_font): Rename local to avoid shadowing.
5360 (fontset_font): Mark local as initialized.
5361 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5363 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5365 * xselect.c (x_disown_buffer_selections): Remove; not used.
5366 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5367 (x_own_selection, Fx_disown_selection_internal): Rename locals
5369 (x_handle_dnd_message): Remove local to avoid shadowing.
5371 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5372 so that the caller can use some name other than gcpro1.
5373 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5374 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5375 (Fx_backspace_delete_keys_p):
5376 Use them to avoid shadowing, and rename vars to avoid shadowing.
5377 (x_decode_color, x_set_name, x_window): Now static.
5378 (Fx_create_frame): Add braces to silence GCC warning.
5379 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5380 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5381 Remove unused locals.
5382 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5383 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5384 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5387 * xterm.h (x_mouse_leave): New decl.
5389 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5390 Remove unused functions.
5391 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5392 (x_calc_absolute_position): Now static.
5393 (XTread_socket): Don't define label "out" unless it's used.
5394 Don't declare local "event" unless it's used.
5395 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5396 unless they are used.
5397 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5398 (x_fatal_error_signal): Remove; not used.
5399 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5400 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5401 (x_error_catcher, x_connection_closed, x_error_handler):
5402 (x_error_quitter, xembed_send_message, x_iconify_frame):
5403 (my_log_handler): Rename locals to avoid shadowing.
5404 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5405 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5407 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5408 Rename or move locals to avoid shadowing.
5409 (tty_defined_color, merge_face_heights): Now static.
5410 (free_realized_faces_for_fontset): Remove; not used.
5411 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5412 does not deduce is never used uninitialized.
5413 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5414 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5416 * terminal.c (store_terminal_param): Now static.
5418 * xmenu.c (menu_highlight_callback): Now static.
5419 (set_frame_menubar): Remove unused local.
5420 (xmenu_show): Rename parameter to avoid shadowing.
5421 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5422 since they might point to immutable storage.
5423 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5424 since it's unused otherwise.
5426 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5427 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5428 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5429 avoids a gcc -Wuninitialized diagnostic.
5430 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5431 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5432 does not deduce are never used uninitialized.
5434 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5436 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5437 * window.c (window_loop, size_window):
5438 (run_window_configuration_change_hook, enlarge_window): Likewise.
5440 * window.c (display_buffer): Now static.
5441 (size_window): Mark variables that gcc -Wuninitialized
5442 does not deduce are never used uninitialized.
5443 * window.h (check_all_windows): New decl, to forestall
5444 gcc -Wmissing-prototypes diagnostic.
5445 * dispextern.h (bidi_dump_cached_states): Likewise.
5447 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5449 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5451 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5452 and to avoid gcc -Wuninitialized warning.
5453 (load_charset_map): Mark variables that gcc -Wuninitialized
5454 does not deduce are never used uninitialized.
5455 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5457 * coding.c (coding_set_source, coding_set_destination):
5458 Use "else { /* comment */ }" rather than "else /* comment */;"
5459 for clarity, and to avoid gcc -Wempty-body warning.
5460 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5461 a block, when the outer 'i' will do.
5462 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5463 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5464 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5465 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5466 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5467 Rename locals to avoid shadowing.
5468 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5469 * coding.c (emacs_mule_char, encode_invocation_designation):
5470 Now static, since they're not used elsewhere.
5471 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5472 (decode_coding_object, encode_coding_object, detect_coding_system):
5473 (decode_coding_emacs_mule): Mark variables that gcc
5474 -Wuninitialized does not deduce are never used uninitialized.
5475 (detect_coding_iso_2022): Initialize a local variable that might
5476 be used uninitialized. Leave a FIXME because it's not clear that
5477 this initialization is needed. (Bug#8211)
5478 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5479 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5480 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5481 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5482 Remove unused macros.
5484 * category.c (hash_get_category_set): Remove unused local var.
5485 (copy_category_table): Now static, since it's not used elsewhere.
5486 * character.c (string_count_byte8): Likewise.
5488 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5489 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5491 * chartab.c (copy_sub_char_table): Now static, since it's not used
5493 (sub_char_table_ref_and_range, char_table_ref_and_range):
5494 Rename locals to avoid shadowing.
5495 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5497 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5498 (BIDI_BOB): Remove unused macro.
5500 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5501 deduce are never used uninitialized.
5502 * term.c (encode_terminal_code): Likewise.
5504 * term.c (encode_terminal_code): Now static. Remove unused local.
5506 * tparam.h: New file.
5507 * term.c, tparam.h: Include it.
5508 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5509 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5510 Move these decls to tparam.h, and make them agree with what
5511 is actually in tparam.c. The previous trick of using incompatible
5512 decls in different modules does not conform to the C standard.
5513 All callers of tparam changed to use tparam's actual API.
5514 * tparam.c (tparam1, tparam, tgoto):
5515 Use const pointers where appropriate.
5517 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5518 * cm.h (struct cm): Likewise.
5519 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5520 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5521 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5522 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5523 (turn_on_face, init_tty): Likewise.
5524 * termchar.h (struct tty_display_info): Likewise.
5526 * term.c (term_mouse_position): Rename local to avoid shadowing.
5528 * alloc.c (mark_ttys): Move decl from here ...
5529 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5531 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5533 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5535 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5537 * search.c (compile_pattern_1): Remove argument regp, unused since
5538 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5539 (compile_pattern): Don't pass it.
5541 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5543 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5544 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5546 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5548 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5550 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5551 gdk_window_get_screen, gdk_window_get_geometry,
5552 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5553 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5554 (xg_get_pixbuf_from_pixmap): New function.
5555 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5556 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5557 Call xg_get_pixbuf_from_pixmap instead of
5558 gdk_pixbuf_get_from_drawable.
5559 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5560 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5561 (xg_check_special_colors): Use GtkStyleContext and its functions
5563 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5564 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5565 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5566 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5567 Call gtk_widget_get_preferred_size.
5568 (xg_frame_resized): gdk_window_get_geometry only takes 5
5570 (xg_win_to_widget, xg_event_is_for_menubar):
5571 Call gdk_x11_window_lookup_for_display.
5572 (xg_set_widget_bg): New function.
5573 (delete_cb): New function.
5574 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5575 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5576 (xg_set_background_color): Call xg_set_widget_bg.
5577 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5578 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5579 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5580 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5582 (update_frame_tool_bar): Call gtk_widget_hide.
5583 (xg_initialize): Use GDK_KEY_g.
5585 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5587 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5589 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5590 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5591 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5593 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5595 * w32xfns.c (select_palette): Check success of RealizePalette against
5596 GDI_ERROR, not zero.
5598 See ChangeLog.11 for earlier changes.
5604 Copyright (C) 2011 Free Software Foundation, Inc.
5606 This file is part of GNU Emacs.
5608 GNU Emacs is free software: you can redistribute it and/or modify
5609 it under the terms of the GNU General Public License as published by
5610 the Free Software Foundation, either version 3 of the License, or
5611 (at your option) any later version.
5613 GNU Emacs is distributed in the hope that it will be useful,
5614 but WITHOUT ANY WARRANTY; without even the implied warranty of
5615 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5616 GNU General Public License for more details.
5618 You should have received a copy of the GNU General Public License
5619 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.