Support bidi reordering of overlay and display strings.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2
3 Support bidi reordering of display and overlay strings.
4 * xdisp.c (compute_display_string_pos)
5 (compute_display_string_end): Accept additional argument STRING.
6 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7 (reseat_to_string): Initialize bidi_it->string.s and
8 bidi_it->string.schars.
9 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
10 NULL (avoids a crash in bidi_paragraph_init). Initialize
11 itb.string.lstring.
12 (init_iterator): Call bidi_init_it only of a valid
13 buffer position was specified. Initialize paragraph_embedding to
14 L2R.
15 (reseat_to_string): Initialize the bidi iterator.
16 (display_string): If we need to ignore text properties of
17 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
18 original value of -1 will not work with bidi.)
19 (compute_display_string_pos): First arg is now struct
20 `text_pos *'; all callers changed. Support display properties on
21 Lisp strings.
22 (compute_display_string_end): Support display properties on Lisp
23 strings.
24 (init_iterator, reseat_1, reseat_to_string): Initialize the
25 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
26 when iterating on a string not from display properties).
27 (compute_display_string_pos, compute_display_string_end): Fix
28 calculation of the object to scan. Fixes an error when using
29 arrow keys.
30 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
31 base_level_stop; instead, set base_level_stop to BEGV. Fixes
32 crashes in vertical-motion.
33 (next_element_from_buffer): Improve commentary for when
34 the iterator is before prev_stop.
35 (init_iterator): Initialize bidi_p from the default value of
36 bidi-display-reordering, not from buffer-local value. Use the
37 buffer-local value only if initializing for buffer iteration.
38 (handle_invisible_prop): Support invisible properties on strings
39 that are being bidi-reordered.
40 (set_iterator_to_next): Support bidi reordering of C strings and
41 Lisp strings.
42 (next_element_from_string): Support bidi reordering of Lisp
43 strings.
44 (handle_stop_backwards): Support Lisp strings as well.
45 (display_string): Support display of R2L glyph rows. Use
46 IT_STRING_CHARPOS when displaying from a Lisp string.
47 (init_iterator): Don't initialize it->bidi_p for strings
48 here.
49 (reseat_to_string): Initialize it->bidi_p for strings here.
50 (next_element_from_string, next_element_from_c_string)
51 (next_element_from_buffer): Add xassert's for correspondence
52 between IT's object being iterated and it->bidi_it.string
53 structure.
54 (face_before_or_after_it_pos): Support bidi iteration.
55 (next_element_from_c_string): Handle the case of the first string
56 character that is not the first one in the visual order.
57 (get_visually_first_element): New function, refactored from common
58 parts of next_element_from_buffer, next_element_from_string, and
59 next_element_from_c_string.
60 (tool_bar_lines_needed, redisplay_tool_bar)
61 (display_menu_bar): Force left-to-right direction. Add a FIXME
62 comment for making that be controlled by a user option.
63 (push_it, pop_it): Save and restore the state of the
64 bidi iterator. Save and restore the bidi_p flag.
65 (pop_it): Iterate out of display property for string iteration as
66 well.
67 (iterate_out_of_display_property): Support iteration over strings.
68 (handle_single_display_spec): Set up it->bidi_it for iteration
69 over a display string, and call bidi_init_it.
70 (handle_single_display_spec, next_overlay_string)
71 (get_overlay_strings_1, push_display_prop): Set up the bidi
72 iterator for displaying display or overlay strings.
73 (forward_to_next_line_start): Don't use the shortcut if
74 bidi-iterating.
75 (back_to_previous_visible_line_start): If handle_display_prop
76 pushed the iterator stack, restore the internal state of the bidi
77 iterator by calling bidi_pop_it same number of times.
78 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
79 and we are bidi-iterating, don't decrement the iterator position;
80 instead, set the first_elt flag in the bidi iterator, to produce
81 the same effect.
82 (reseat_1): Remove redundant setting of string_from_display_prop_p.
83 (push_display_prop): xassert that we are iterating a buffer.
84 (push_it, pop_it): Save and restore paragraph_embedding member.
85 (handle_single_display_spec, next_overlay_string)
86 (get_overlay_strings_1, reseat_1, reseat_to_string)
87 (push_display_prop): Set up the `unibyte' member of bidi_it.string
88 correctly. Don't assume unibyte strings are not bidi-reordered.
89 (compute_display_string_pos)
90 (compute_display_string_end): Fix handling the case of C string.
91 (push_it, pop_it): Save and restore from_disp_prop_p.
92 (handle_single_display_spec, push_display_prop): Set the
93 from_disp_prop_p flag.
94 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
95 (pop_it): Call iterate_out_of_display_property only if we are
96 popping after iteration over a string that came from a display
97 property. Fix a typo in popping stretch info. Add an assertion
98 for verifying that the iterator position is in sync with the bidi
99 iterator.
100 (handle_single_display_spec, get_overlay_strings_1)
101 (push_display_prop): Fix initialization of paragraph direction for
102 string when that of the parent object is not yet determined.
103 (reseat_1): Call bidi_init_it to resync the bidi
104 iterator with IT's position. (Bug#7616)
105 (find_row_edges): If ROW->start.pos gives position
106 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
107 (handle_stop, back_to_previous_visible_line_start, reseat_1):
108 Reset the from_disp_prop_p flag.
109 (SAVE_IT, RESTORE_IT): New macros.
110 (pos_visible_p, face_before_or_after_it_pos)
111 (back_to_previous_visible_line_start)
112 (move_it_in_display_line_to, move_it_in_display_line)
113 (move_it_to, move_it_vertically_backward, move_it_by_lines)
114 (try_scrolling, redisplay_window, display_line): Use them when
115 saving a temporary copy of the iterator and restoring it back.
116 (back_to_previous_visible_line_start, reseat_1)
117 (init_iterator): Empty the bidi cache "stack".
118 (move_it_in_display_line_to): If iterator ended up at
119 EOL, but we never saw any buffer positions smaller than
120 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
121 motion in bidi-reordered lines.
122 (move_it_in_display_line_to): Record prev_method and prev_pos
123 immediately before the call to set_iterator_to_next. Fixes cursor
124 motion in bidi-reordered lines with stretch glyphs and strings
125 displayed in margins. (Bug#8133) (Bug#8867)
126 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
127 TO_CHARPOS.
128 (pos_visible_p): Support positions in bidi-reordered lines. Save
129 and restore bidi cache.
130
131 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
132 (bidi_paragraph_info): Delete unused struct.
133 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
134 (bidi_cache_start): New variable.
135 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
136 to zero.
137 (bidi_cache_fetch_state, bidi_cache_search)
138 (bidi_cache_find_level_change, bidi_cache_iterator_state)
139 (bidi_cache_find, bidi_peek_at_next_level)
140 (bidi_level_of_next_char, bidi_find_other_level_edge)
141 (bidi_move_to_visually_next): Compare cache index with
142 bidi_cache_start rather than with zero.
143 (bidi_fetch_char): Accept new argument STRING; all callers
144 changed. Support iteration over a string. Support strings with
145 display properties. Support unibyte strings. Fix the type of
146 `len' according to what STRING_CHAR_AND_LENGTH expects.
147 (bidi_paragraph_init, bidi_resolve_explicit_1)
148 (bidi_resolve_explicit, bidi_resolve_weak)
149 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
150 iteration over a string.
151 (bidi_set_sor_type, bidi_resolve_explicit_1)
152 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
153 can now be zero (for strings); special values 0 and -1 were
154 changed to -1 and -2, respectively.
155 (bidi_char_at_pos): New function.
156 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
157 Call it instead of FETCH_MULTIBYTE_CHAR.
158 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
159 initialized to valid values.
160 (bidi_init_it): Don't initialize charpos and bytepos with invalid
161 values.
162 (bidi_level_of_next_char): Allow the sentinel "position" to pass
163 the test for valid cached positions. Fix the logic for looking up
164 the sentinel state in the cache. GCPRO the Lisp string we are
165 iterating.
166 (bidi_push_it, bidi_pop_it): New functions.
167 (bidi_initialize): Initialize the bidi cache start stack pointer.
168 (bidi_cache_ensure_space): New function, refactored from part of
169 bidi_cache_iterator_state. Don't assume the required size is just
170 one BIDI_CACHE_CHUNK away.
171 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
172 (bidi_count_bytes, bidi_char_at_pos): New functions.
173 (bidi_cache_search): Don't assume bidi_cache_last_idx is
174 always valid if bidi_cache_idx is valid.
175 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
176 is valid if it's going to be used.
177 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
178 (bidi_cache_fetch_state, bidi_cache_search)
179 (bidi_cache_find_level_change, bidi_cache_ensure_space)
180 (bidi_cache_iterator_state, bidi_cache_find)
181 (bidi_find_other_level_edge, bidi_cache_start_stack): All
182 variables related to cache indices are now EMACS_INT.
183
184 * dispextern.h (struct bidi_string_data): New structure.
185 (struct bidi_it): New member `string'. Make flag members be 1-bit
186 fields, and put them last in the struct.
187 (compute_display_string_pos, compute_display_string_end): Update
188 prototypes.
189 (bidi_push_it, bidi_pop_it): Add prototypes.
190 (struct iterator_stack_entry): New members bidi_p,
191 paragraph_embedding, and from_disp_prop_p.
192 (struct it): Member bidi_p is now a bit field 1 bit wide.
193 (bidi_shelve_cache, bidi_unshelve_cache): Declare
194 prototypes.
195
196 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
197 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
198 and vector-like objects.
199
200 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
201 cache around display iteration.
202
203 * window.c (Fwindow_end, window_scroll_pixel_based)
204 (displayed_window_lines, Frecenter): Save and restore the bidi
205 cache around display iteration.
206
207 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
208
209 * editfns.c (Fdelete_region): Clarify the use of the named
210 parameters (bug#6788).
211
212 2011-07-14 Martin Rudalics <rudalics@gmx.at>
213
214 * indent.c (Fvertical_motion): Set and restore w->pointm when
215 saving and restoring the window's buffer (Bug#9006).
216
217 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
218
219 * editfns.c (Fstring_to_char): Clarify just what is returned
220 (bug#6576). Text by Eli Zaretskii.
221
222 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
223
224 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
225
226 2011-07-13 Eli Zaretskii <eliz@gnu.org>
227
228 * buffer.c (mmap_find): Fix a typo.
229
230 2011-07-13 Johan Bockgård <bojohan@gnu.org>
231
232 Fix execution of x selection hooks.
233 * xselect.c (Qx_lost_selection_functions)
234 (Qx_sent_selection_functions): New vars.
235 (syms_of_xselect): DEFSYM them.
236 (x_handle_selection_request): Pass Qx_sent_selection_functions
237 rather than Vx_sent_selection_functions to Frun_hook_with_args.
238 (x_handle_selection_clear,x_clear_frame_selections):
239 Pass Qx_lost_selection_functions rather than
240 Vx_lost_selection_functions to Frun_hook_with_args.
241
242 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
243
244 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
245 The old code sometimes used this field without initializing it.
246
247 * alloc.c (gc_sweep): Don't read past end of array.
248 In theory, the old code could also have corrupted Emacs internals,
249 though it'd be very unlikely.
250
251 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
252
253 * character.c (Fcharacterp): Don't advertise optional ignored
254 argument. (Bug#4026)
255
256 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
257
258 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
259 key" (bug#4257).
260
261 * window.c (Fset_window_start): Doc fix (bug#4199).
262 (Fset_window_hscroll): Ditto.
263
264 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
265
266 Fix minor new problems caught by GCC 4.6.1.
267 * term.c (init_tty): Remove unused local.
268 * xsettings.c (store_monospaced_changed): Define this function only
269 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
270 not used otherwise.
271
272 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
273
274 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
275
276 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
277
278 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
279 are the mini-buffer and the echo area (bug#3320).
280
281 * term.c (init_tty): Remove support for supdup, c10 and perq
282 terminals, which are no longer supported (bug#1482).
283
284 2011-07-10 Johan Bockgård <bojohan@gnu.org>
285
286 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
287
288 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
289
290 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
291 for non-popups (Bug#3642).
292
293 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
294
295 * alloc.c (reset_malloc_hooks): Protoize.
296 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
297 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
298 * cm.c (losecursor): Likewise.
299 * data.c (fmod): Likewise.
300 * dispnew.c (swap_glyphs_in_rows): Likewise.
301 * emacs.c (memory_warning_signal): Likewise.
302 * floatfns.c (float_error): Likewise.
303 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
304 (otf_open, font_otf_capability, generate_otf_features)
305 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
306 Likewise.
307 * image.c (pbm_read_file): Likewise.
308 * indent.c (string_display_width): Likewise.
309 * intervals.c (check_for_interval, search_for_interval)
310 (inc_interval_count, count_intervals, root_interval)
311 (adjust_intervals_for_insertion, make_new_interval): Likewise.
312 * lread.c (defalias): Likewise.
313 * ralloc.c (r_alloc_check): Likewise.
314 * regex.c (set_image_of_range_1, set_image_of_range)
315 (regex_grow_registers): Likewise.
316 * sysdep.c (strerror): Likewise.
317 * termcap.c (valid_filename_p, tprint, main): Likewise.
318 * tparam.c (main): Likewise.
319 * unexhp9k800.c (run_time_remap, save_data_space)
320 (update_file_ptrs, read_header, write_header, calculate_checksum)
321 (copy_file, copy_rest, display_header): Likewise.
322 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
323 Likewise.
324 * xdisp.c (check_it): Likewise.
325 * xfaces.c (register_color, unregister_color, unregister_colors):
326 Likewise.
327 * xfns.c (print_fontset_result): Likewise.
328 * xrdb.c (member, fatal, main): Likewise.
329
330 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
331
332 Fix minor problems found by static checking (Bug#9031).
333 * chartab.c (char_table_set_range, map_sub_char_table):
334 Remove unused locals.
335 (uniprop_table): Now static.
336 * composite.c (_work_char): Remove unused static var.
337
338 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
339
340 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
341
342 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
343
344 * gtkutil.c (qttip_cb): Remove code without function.
345
346 2011-07-09 Eli Zaretskii <eliz@gnu.org>
347
348 * w32.c (pthread_sigmask): New stub.
349
350 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
351
352 Use pthread_sigmask, not sigprocmask (Bug#9010).
353 sigprocmask is portable only for single-threaded applications, and
354 Emacs can be multi-threaded when it uses GTK.
355 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
356 (LIBES): Use it.
357 * callproc.c (Fcall_process):
358 * process.c (create_process):
359 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
360 Use pthread_sigmask, not sigprocmask.
361
362 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
363
364 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
365 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
366 wrong (Bug#8591).
367
368 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
369
370 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
371 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
372 (xg_hide_tooltip): Fix comment.
373
374 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
375 in registerServicesMenuSendTypes.
376 (validRequestorForSendType): Don't check ns_return_types.
377
378 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
379 ns_return_type.
380
381 2011-07-08 Jason Rumney <jasonr@gnu.org>
382
383 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
384 frame struct members of non-existent frames (Bug#6284).
385
386 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
387
388 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
389 variable firstTime not needed on OSX >= 10.6.
390 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
391 >= 10.5. Use setKnobProportion, setDoubleValue.
392
393 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
394 (MAC_OS_X_VERSION_10_5): Define if not defined.
395 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
396 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
397 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
398
399 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
400 cString and lossyCString on OSX >= 10.4
401
402 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
403 sizeToFit on OSX >= 10.2.
404
405 * nsimage.m (allocInitFromFile): Don't use deprecated method
406 bestRepresentationForDevice on OSX >= 10.6.
407
408 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
409 to avoid warning.
410
411 * emacs.c: Declare unexec_init_emacs_zone.
412
413 * nsgui.h: Fix compiler warning about gnulib redefining verify.
414
415 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
416
417 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
418 on svcsMenu (Bug#8842).
419
420 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
421 ns_return_types.
422 (Fns_list_services): Just return Qnil on 10.6, code not working there.
423
424 * nsterm.m (QUTF8_STRING): Declare.
425 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
426 (validRequestorForSendType): Return type is (id).
427 Change indexOfObjectIdenticalTo to indexOfObject.
428 Check if we have local selection before returning self (Bug#8842).
429 (writeSelectionToPasteboard): Put local selection into paste board
430 if we have a local selection (Bug#8842).
431 (syms_of_nsterm): DEFSYM QUTF8_STRING.
432
433 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
434 (ns_get_local_selection): Declare.
435
436 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
437
438 * keymap.c (describe_map_tree): Don't insert a double newline at
439 the end of the buffer (bug#1169) and return whether we inserted
440 something.
441
442 * callint.c (Fcall_interactively): Change "reading args" to
443 "providing args" to try to clarify what it does (bug#1010).
444
445 2011-07-07 Kenichi Handa <handa@m17n.org>
446
447 * composite.c (composition_compute_stop_pos): Ignore a static
448 composition starting before CHARPOS (Bug#8915).
449
450 * xdisp.c (handle_composition_prop): Likewise.
451
452 2011-07-07 Eli Zaretskii <eliz@gnu.org>
453
454 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
455 (Bug#9015)
456
457 2011-07-07 Kenichi Handa <handa@m17n.org>
458
459 * character.h (unicode_category_t): New enum type.
460
461 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
462 (Qchar_code_property_table): New variable.
463 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
464 (UNIPROP_COMPRESSED_FORM_P): New macros.
465 (char_table_ascii): Uncompress the compressed values.
466 (sub_char_table_ref): New arg is_uniprop. Callers changed.
467 Uncompress the compressed values.
468 (sub_char_table_ref_and_range): Likewise.
469 (char_table_ref_and_range): Uncompress the compressed values.
470 (sub_char_table_set): New arg is_uniprop. Callers changed.
471 Uncompress the compressed values.
472 (sub_char_table_set_range): Args changed. Callers changed.
473 (char_table_set_range): Adjuted for the above change.
474 (map_sub_char_table): Delete args default_val and parent. Add arg
475 top. Give decoded values to a Lisp function.
476 (map_char_table): Adjusted for the above change. Give decoded
477 values to a Lisp function. Gcpro more variables.
478 (uniprop_table_uncompress)
479 (uniprop_decode_value_run_length): New functions.
480 (uniprop_decoder, uniprop_decoder_count): New variables.
481 (uniprop_get_decoder, uniprop_encode_value_character)
482 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
483 New functions.
484 (uniprop_encoder, uniprop_encoder_count): New variables.
485 (uniprop_get_encoder, uniprop_table)
486 (Funicode_property_table_internal, Fget_unicode_property_internal)
487 (Fput_unicode_property_internal): New functions.
488 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
489 Sunicode_property_table_internal, Sget_unicode_property_internal,
490 and Sput_unicode_property_internal. Defvar_lisp
491 char-code-property-alist.
492
493 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
494 Vunicode_category_table.
495
496 * font.c (font_range): Adjusted for the change of
497 Vunicode_category_table.
498
499 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
500
501 * m/iris4d.h: Remove file, move contents ...
502 * s/irix6-5.h: ... here.
503
504 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
505
506 Remove unportable assumption about struct layout (Bug#8884).
507 * alloc.c (mark_buffer):
508 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
509 (clone_per_buffer_values): Don't assume that
510 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
511 This isn't true in general, and it's particularly not true
512 if Emacs is configured with --with-wide-int.
513 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
514 New macros, used in the buffer.c change.
515
516 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
517
518 * xsettings.c: Use both GConf and GSettings if both are available.
519 (store_config_changed_event): Add comment.
520 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
521 (store_tool_bar_style_changed): New functions.
522 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
523 (struct xsettings): Move font inside HAVE_XFT.
524 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
525 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
526 Move inside HAVE_XFT.
527 (something_changed_gsettingsCB): Renamed from something_changedCB.
528 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
529 also.
530 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
531 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
532 (something_changed_gconfCB): Renamed from something_changedCB.
533 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
534 (parse_settings): Move check for font inside HAVE_XFT.
535 (read_settings, apply_xft_settings): Add comment.
536 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
537 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
538 call store_font_name_changed.
539 (xft_settings_event): Add comment.
540 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
541 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
542 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
543 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
544 (xsettings_initialize): Call init_gsettings last.
545 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
546 comment.
547
548 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
549
550 Random fixes. E.g., (random) never returned negative values.
551 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
552 subseconds part to the entropy, as that's a bit more random.
553 Prefer signed to unsigned, since the signedness doesn't matter and
554 in general we prefer signed. When given a limit, use a
555 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
556 latter isn't right if USE_2_TAGS_FOR_INTS.
557 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
558 not 0..VALMASK. Don't discard "excess" bits that random () returns.
559
560 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
561
562 * textprop.c (text_property_stickiness):
563 Obey Vtext_property_default_nonsticky.
564 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
565 * w32fns.c (syms_of_w32fns):
566 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
567
568 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
569
570 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
571 This is more efficient than Ffile_directory_p and avoids a minor race.
572
573 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
574
575 * buffer.c (Foverlay_put): Say what the return value is
576 (bug#7835).
577
578 * fileio.c (barf_or_query_if_file_exists): Check first if the file
579 is a directory before asking whether to use the file name
580 (bug#7564).
581 (barf_or_query_if_file_exists): Make the "File is a directory"
582 error be more correct.
583
584 * fns.c (Frequire): Remove the mention of the .gz files, since
585 that's installation-specific, but keep the mention of
586 `get-load-suffixes'.
587
588 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
589
590 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
591 Report string overflow if the output is too long.
592
593 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
594
595 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
596 (syms_of_gnutls): Remove duplicate DEFSYM for
597 Qgnutls_bootprop_verify_hostname_error, an error for
598 Qgnutls_bootprop_verify_error (which is no longer used).
599
600 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
601 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
602 Also (re)move comments that are misplaced or no longer relevant.
603
604 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
605
606 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
607
608 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
609
610 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
611 and background color parameters if they have been changed.
612
613 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
614
615 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
616
617 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
618
619 * xsettings.c (SYSTEM_FONT): Define only when used.
620 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
621
622 * keymap.c (access_keymap_1): Now static.
623
624 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
625
626 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
627 leave any prefix arg for the up event (Bug#1586).
628
629 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
630
631 * lread.c (syms_of_lread): Mention single symbols defined by
632 `defvar' or `defconst' (bug#7154).
633
634 * fns.c (Frequire): Mention .el.gz files (bug#7314).
635 (Frequire): Mention get-load-suffixes.
636
637 2011-07-02 Martin Rudalics <rudalics@gmx.at>
638
639 * window.h (window): Remove clone_number slot.
640 * window.c (Fwindow_clone_number, Fset_window_clone_number):
641 Remove.
642 (make_parent_window, make_window, saved_window)
643 (Fset_window_configuration, save_window_save): Don't deal with
644 clone numbers.
645 * buffer.c (Qclone_number): Remove declaration.
646 (sort_overlays, overlay_strings): Don't deal with clone numbers.
647
648 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
649
650 Add multiple inheritance to keymaps.
651 * keymap.c (Fmake_composed_keymap): New function.
652 (Fset_keymap_parent): Simplify.
653 (fix_submap_inheritance): Remove.
654 (access_keymap_1): New function extracted from access_keymap to handle
655 embedded parents and handle lists of maps.
656 (access_keymap): Use it.
657 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
658 (Fcopy_keymap): Handle embedded parents.
659 (Fcommand_remapping, define_as_prefix): Simplify.
660 (Fkey_binding): Simplify.
661 (syms_of_keymap): Move minibuffer-local-completion-map,
662 minibuffer-local-filename-completion-map,
663 minibuffer-local-must-match-map, and
664 minibuffer-local-filename-must-match-map to Elisp.
665 (syms_of_keymap): Defsubr make-composed-keymap.
666 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
667 (parse_menu_item): Trivial simplification.
668
669 2011-07-01 Glenn Morris <rgm@gnu.org>
670
671 * Makefile.in (SETTINGS_LIBS): Fix typo.
672
673 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
674
675 * coding.c (Fencode_coding_string): Record the last coding system
676 used, as the function doc string says (bug#8738).
677
678 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
679
680 * xsettings.c (store_monospaced_changed): Take new font as arg and
681 check for change against current_mono_font.
682 (EMACS_TYPE_SETTINGS): Remove this and related defines.
683 (emacs_settings_constructor, emacs_settings_get_property)
684 (emacs_settings_set_property, emacs_settings_class_init)
685 (emacs_settings_init, gsettings_obj): Remove.
686 (something_changedCB): New function for HAVE_GSETTINGS.
687 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
688 with value as argument.
689 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
690 g_settings_new (Bug#8967). Do not create gsettings_obj.
691 Remove calls to g_settings_bind. Connect something_changedCB to
692 "changed".
693
694 * xgselect.c: Add defined (HAVE_GSETTINGS).
695 (xgselect_initialize): Ditto.
696
697 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
698 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
699 xg_select.
700
701 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
702
703 * eval.c (struct backtrace): Simplify and port the data structure.
704 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
705 signed bit field, as this assumption is not portable and it makes
706 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
707 "char debug_on_exit : 1" as this is not portable either; instead,
708 use the portable "unsigned int debug_on_exit : 1". Remove unused
709 member evalargs. Remove obsolete comments about cc bombing out.
710
711 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
712
713 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
714 Let HAVE_GSETTINGS override HAVE_GCONF.
715 (store_monospaced_changed): New function.
716 (EMACS_SETTINGS): A new type derived from GObject to handle
717 GSettings notifications.
718 (emacs_settings_constructor, emacs_settings_get_property)
719 (emacs_settings_set_property, emacs_settings_class_init):
720 New functions.
721 (gsettings_client, gsettings_obj): New variables.
722 (GSETTINGS_SCHEMA): New define.
723 (something_changedCB): Call store_monospaced_changed.
724 (init_gsettings): New function.
725 (xsettings_initialize): Call init_gsettings.
726 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
727 to NULL.
728
729 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
730 GCONF_CFLAGS/LIBS.
731
732 2011-06-29 Martin Rudalics <rudalics@gmx.at>
733
734 * window.c (resize_root_window, grow_mini_window)
735 (shrink_mini_window): Rename Qresize_root_window to
736 Qwindow_resize_root_window and Qresize_root_window_vertically to
737 Qwindow_resize_root_window_vertically.
738
739 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
740
741 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
742
743 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
744
745 * makefile.w32-in: Redesign dependencies so they reflect more
746 clearly which files are directly included by each source file,
747 and not through other includes.
748
749 2011-06-27 Martin Rudalics <rudalics@gmx.at>
750
751 * buffer.c (Qclone_number): Declare static and DEFSYM it.
752 (sort_overlays, overlay_strings): When an overlay's clone number
753 matches the window's clone number process the overlay even if
754 the overlay's window property doesn't match the current window.
755
756 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
757 (Fwindow_hchild): Rename to Fwindow_left_child.
758 (Fwindow_next): Rename to Fwindow_next_sibling.
759 (Fwindow_prev): Rename to Fwindow_prev_sibling.
760 (resize_window_check): Rename to window_resize_check.
761 (resize_window_apply): Rename to window_resize_apply.
762 (Fresize_window_apply): Rename to Fwindow_resize_apply.
763 (Fdelete_other_windows_internal, resize_frame_windows)
764 (Fsplit_window_internal, Fdelete_window_internal)
765 (grow_mini_window, shrink_mini_window)
766 (Fresize_mini_window_internal): Fix callers accordingly.
767
768 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
769
770 * emacsgtkfixed.h: State that this is only used with Gtk+3.
771 (emacs_fixed_set_min_size): Remove.
772 (emacs_fixed_new): Take frame as argument.
773
774 * emacsgtkfixed.c: State that this is only used with Gtk+3.
775 (_EmacsFixedPrivate): Remove minwidth/height.
776 Add struct frame *f.
777 (emacs_fixed_init): Initialize priv->f.
778 (get_parent_class, emacs_fixed_set_min_size): Remove.
779 (emacs_fixed_new): Set priv->f to argument.
780 (emacs_fixed_get_preferred_width)
781 (emacs_fixed_get_preferred_height): Use min_width/height from
782 frames size_hint to set minimum and natural (Bug#8919).
783 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
784 and use min_width/height from frames size_hint to set
785 min_width/height (Bug#8919).
786
787 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
788 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
789 Fix indentation.
790
791 2011-06-26 Eli Zaretskii <eliz@gnu.org>
792
793 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
794 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
795 called at ZV.
796
797 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
798
799 * process.c (wait_reading_process_output): Bypass select if
800 waiting for a cell while ignoring keyboard input, and input is
801 pending. Suggested by Jan Djärv (Bug#8869).
802
803 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
804
805 Use gnulib's dup2 module instead of rolling our own.
806 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
807
808 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
809
810 * dispnew.c (scrolling_window): Before scrolling, turn off a
811 mouse-highlight in the window being scrolled.
812
813 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
814
815 Move DEFSYM to lisp.h and use everywhere.
816
817 * character.h (DEFSYM): Move declaration...
818 * lisp.h (DEFSYM): ...here.
819
820 * gnutls.c:
821 * minibuf.c:
822 * w32menu.c:
823 * w32proc.c:
824 * w32select.c: Don't include character.h.
825
826 * alloc.c (syms_of_alloc):
827 * buffer.c (syms_of_buffer):
828 * bytecode.c (syms_of_bytecode):
829 * callint.c (syms_of_callint):
830 * casefiddle.c (syms_of_casefiddle):
831 * casetab.c (init_casetab_once):
832 * category.c (init_category_once, syms_of_category):
833 * ccl.c (syms_of_ccl):
834 * cmds.c (syms_of_cmds):
835 * composite.c (syms_of_composite):
836 * dbusbind.c (syms_of_dbusbind):
837 * dired.c (syms_of_dired):
838 * dispnew.c (syms_of_display):
839 * doc.c (syms_of_doc):
840 * editfns.c (syms_of_editfns):
841 * emacs.c (syms_of_emacs):
842 * eval.c (syms_of_eval):
843 * fileio.c (syms_of_fileio):
844 * fns.c (syms_of_fns):
845 * frame.c (syms_of_frame):
846 * fringe.c (syms_of_fringe):
847 * insdel.c (syms_of_insdel):
848 * keymap.c (syms_of_keymap):
849 * lread.c (init_obarray, syms_of_lread):
850 * macros.c (syms_of_macros):
851 * msdos.c (syms_of_msdos):
852 * print.c (syms_of_print):
853 * process.c (syms_of_process):
854 * search.c (syms_of_search):
855 * sound.c (syms_of_sound):
856 * syntax.c (init_syntax_once, syms_of_syntax):
857 * terminal.c (syms_of_terminal):
858 * textprop.c (syms_of_textprop):
859 * undo.c (syms_of_undo):
860 * w32.c (globals_of_w32):
861 * window.c (syms_of_window):
862 * xdisp.c (syms_of_xdisp):
863 * xfaces.c (syms_of_xfaces):
864 * xfns.c (syms_of_xfns):
865 * xmenu.c (syms_of_xmenu):
866 * xsettings.c (syms_of_xsettings):
867 * xterm.c (syms_of_xterm): Use DEFSYM.
868
869 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
870
871 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
872
873 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
874
875 Integer and buffer overflow fixes (Bug#8873).
876
877 * print.c (printchar, strout): Check for string overflow.
878 (PRINTPREPARE, printchar, strout):
879 Don't set size unless allocation succeeds.
880
881 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
882 for sizes. Check for string overflow more accurately.
883 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
884
885 * macros.c: Integer and buffer overflow fixes.
886 * keyboard.h (struct keyboard.kbd_macro_bufsize):
887 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
888 Use ptrdiff_t, not int, for sizes.
889 Don't increment bufsize until after realloc succeeds.
890 Check for size-calculation overflow.
891 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
892
893 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
894
895 * lread.c: Integer overflow fixes.
896 (read_integer): Radix is now EMACS_INT, not int,
897 to improve quality of diagnostics for out-of-range radices.
898 Calculate buffer size correctly for out-of-range radices.
899 (read1): Check for integer overflow in radices, and in
900 read-circle numbers.
901 (read_escape): Avoid int overflow.
902 (Fload, openp, read_buffer_size, read1)
903 (substitute_object_recurse, read_vector, read_list, map_obarray):
904 Use ptrdiff_t, not int, for sizes.
905 (read1): Use EMACS_INT, not int, for sizes.
906 Check for size overflow.
907
908 * image.c (cache_image): Check for size arithmetic overflow.
909
910 * lread.c: Integer overflow issues.
911 (saved_doc_string_size, saved_doc_string_length)
912 (prev_saved_doc_string_size, prev_saved_doc_string_length):
913 Now ptrdiff_t, not int.
914 (read1): Don't assume doc string length fits in int. Check for
915 out-of-range doc string lengths.
916 (read_list): Don't assume file position fits in int.
917 (read_escape): Check for hex character overflow.
918
919 2011-06-22 Leo Liu <sdl.web@gmail.com>
920
921 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
922 Move to minibuffer.el.
923
924 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
925
926 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
927 The following patches are for when GLYPH_DEBUG && !XASSERT.
928 * dispextern.h (trace_redisplay_p, dump_glyph_string):
929 * dispnew.c (flush_stdout):
930 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
931 Mark as externally visible.
932 * dispnew.c (check_window_matrix_pointers): Now static.
933 * dispnew.c (window_to_frame_vpos):
934 * xfns.c (unwind_create_frame):
935 * xterm.c (x_check_font): Remove unused local.
936 * scroll.c (CHECK_BOUNDS):
937 * xfaces.c (cache_fache): Rename local to avoid shadowing.
938 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
939 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
940 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
941 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
942 Now static.
943 (debug_method_add): Use va_list and vsprintf rather than relying
944 on undefined behavior with wrong number of arguments.
945 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
946 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
947 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
948 since we're not interested in debugging glyphs with old libraries.
949 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
950 GCC 4.6.0's static checking.
951
952 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
953
954 Integer overflow and signedness fixes (Bug#8873).
955 A few related buffer overrun fixes, too.
956
957 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
958
959 * dispextern.h (struct face.stipple):
960 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
961 (x_bitmap_mask, x_allocate_bitmap_record)
962 (x_create_bitmap_from_data, x_create_bitmap_from_file)
963 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
964 (x_create_bitmap_from_xpm_data):
965 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
966 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
967 (.bitmaps_last):
968 * xfaces.c (load_pixmap):
969 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
970 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
971 (.bitmaps_last, struct x_output.icon_bitmap):
972 Use ptrdiff_t, not int, for bitmap indexes.
973 (x_allocate_bitmap_record): Check for size overflow.
974 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
975
976 Use ptrdiff_t, not int, for overlay counts.
977 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
978 * editfns.c (overlays_around, get_pos_property):
979 * textprop.c (get_char_property_and_overlay):
980 * xdisp.c (next_overlay_change, note_mouse_highlight):
981 * xfaces.c (face_at_buffer_position):
982 * buffer.c (OVERLAY_COUNT_MAX): New macro.
983 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
984 (Fnext_overlay_change, Fprevious_overlay_change)
985 (mouse_face_overlay_overlaps, Foverlays_in):
986 Use ptrdiff_t, not int, for sizes.
987 (overlays_at, overlays_in): Check for size-calculation overflow.
988
989 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
990
991 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
992 (x_session_initialize): Do not assume string length fits in int.
993
994 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
995 This is unlikely, but can occur if DPI is outlandish.
996
997 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
998 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
999
1000 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1001 * xrdb.c (magic_file_p, search_magic_path):
1002 Omit last arg SUFFIX; it was always 0. All callers changed.
1003 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1004
1005 * xfont.c (xfont_match): Avoid need for strlen.
1006
1007 * xfns.c: Don't assume strlen fits in int.
1008 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1009
1010 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1011 not unsigned long, as we prefer signed integers. All callers changed.
1012 Detect integer overflow in repeat count.
1013 (message_dolog): Don't assume print length fits in 39 bytes.
1014 (display_mode_element): Don't assume strlen fits in int.
1015
1016 * termcap.c: Don't assume sizes fit in int and never overflow.
1017 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1018 (gobble_line): Check for size-calculation overflow.
1019
1020 * minibuf.c (Fread_buffer):
1021 * lread.c (intern, intern_c_string):
1022 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1023 Don't assume string length fits in int.
1024
1025 * keyboard.c (parse_tool_bar_item):
1026 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1027
1028 * font.c: Don't assume string length fits in int.
1029 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1030 Use ptrdiff_t, not int.
1031 (font_intern_prop): Don't assume string length fits in int.
1032 Don't assume integer property fits in fixnum.
1033 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1034
1035 * filelock.c: Fix some buffer overrun and integer overflow issues.
1036 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1037 Reformulate so as not to need the command string.
1038 Invoke gzip -cd rather than gunzip, as it's more portable.
1039 (lock_info_type, lock_file_1, lock_file):
1040 Don't assume pid_t and time_t fit in unsigned long.
1041 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1042 (current_lock_owner): Prefer signed type for sizes.
1043 Use memcpy, not strncpy, where memcpy is what is really wanted.
1044 Don't assume (via atoi) that time_t and pid_t fit in int.
1045 Check for time_t and/or pid_t out of range, e.g., via a network share.
1046 Don't alloca where an auto var works fine.
1047
1048 * fileio.c: Fix some integer overflow issues.
1049 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1050 Don't assume string length fits in int.
1051 (directory_file_name): Don't assume string length fits in long.
1052 (make_temp_name): Don't assume pid fits in int, or that its print
1053 length is less than 20.
1054
1055 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1056
1057 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1058
1059 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1060
1061 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1062 We prefer signed integers, even for size calculations.
1063
1064 * emacs.c: Don't assume string length fits in 'int'.
1065 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1066 (main): Don't invoke strlen when not needed.
1067
1068 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1069 (XD_DEBUG_MESSAGE): Don't waste a byte.
1070
1071 * callproc.c (getenv_internal_1, getenv_internal)
1072 (Fgetenv_internal):
1073 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1074
1075 * lread.c (invalid_syntax): Omit length argument.
1076 All uses changed. This doesn't fix a bug, but it simplifies the
1077 code away from its former Hollerith-constant appearance, and it's
1078 one less 'int' to worry about when looking at integer-overflow issues.
1079 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1080
1081 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1082 This didn't break anything, but it didn't help either.
1083 It's confusing to put a bogus integer in a place where the actual
1084 value does not matter.
1085 (LIST_END_P): Remove unused macro and its bogus comment.
1086 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1087
1088 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1089 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1090 implementation.
1091 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1092 We prefer signed types, and the value cannot exceed the EMACS_INT
1093 range anyway (because otherwise the length would not be representable).
1094 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1095 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1096 This avoids a GCC warning when WIDE_EMACS_INT.
1097
1098 * indent.c (sane_tab_width): New function.
1099 (current_column, scan_for_column, Findent_to, position_indentation)
1100 (compute_motion): Use it. This is just for clarity.
1101 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1102
1103 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1104
1105 * lisp.h (lint_assume): New macro.
1106 * composite.c (composition_gstring_put_cache):
1107 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1108
1109 * editfns.c, insdel.c:
1110 Omit unnecessary forward decls, to simplify future changes.
1111
1112 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1113
1114 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1115
1116 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1117 Use much-faster test for byte-length change.
1118 Don't assume string byte-length fits in 'int'.
1119 Check that character arg fits in 'int'.
1120 (mapcar1): Declare byte as byte, for clarity.
1121
1122 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1123
1124 * fns.c (concat): Catch string overflow earlier.
1125 Do not rely on integer wraparound.
1126
1127 * dispextern.h (struct it.overlay_strings_charpos)
1128 (struct it.selective): Now EMACS_INT, not int.
1129 * xdisp.c (forward_to_next_line_start)
1130 (back_to_previous_visible_line_start)
1131 (reseat_at_next_visible_line_start, next_element_from_buffer):
1132 Don't arbitrarily truncate the value of 'selective' to int.
1133
1134 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1135
1136 * composite.c: Don't truncate sizes to 'int'.
1137 (composition_gstring_p, composition_reseat_it)
1138 (composition_adjust_point): Use EMACS_INT, not int.
1139 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1140 not EMACS_UINT, for indexes.
1141
1142 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1143
1144 * buffer.c: Include <verify.h>.
1145 (struct sortvec.priority, struct sortstr.priority):
1146 Now EMACS_INT, not int.
1147 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1148 (struct sortstr.size, record_overlay_string)
1149 (struct sortstrlist.size, struct sortlist.used):
1150 Don't truncate size to int.
1151 (record_overlay_string): Check for size-calculation overflow.
1152 (init_buffer_once): Check at compile-time, not run-time.
1153
1154 2011-06-22 Jim Meyering <meyering@redhat.com>
1155
1156 Don't leak an XBM-image-sized buffer
1157 * image.c (xbm_load): Free the image buffer after using it.
1158
1159 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1160
1161 Port to Sun C.
1162 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1163 that Sun C diagnosed.
1164 * fns.c (secure_hash): Fix pointer signedness issue.
1165 * intervals.c (static_offset_intervals): New function.
1166 (offset_intervals): Use it.
1167
1168 2011-06-21 Leo Liu <sdl.web@gmail.com>
1169
1170 * deps.mk (fns.o):
1171 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1172 sha512.h.
1173
1174 * fns.c (secure_hash): Rename from crypto_hash_function and change
1175 the first arg to accept symbols.
1176 (Fsecure_hash): New primitive.
1177 (syms_of_fns): New symbols.
1178
1179 2011-06-20 Deniz Dogan <deniz@dogan.se>
1180
1181 * process.c (Fset_process_buffer): Clarify return value in
1182 docstring.
1183
1184 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1185
1186 * dispnew.c (add_window_display_history): Use BVAR.
1187
1188 * xdisp.c (debug_method_add): Use BVAR.
1189 (check_window_end, dump_glyph_matrix, dump_glyph)
1190 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1191
1192 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1193 Likewise.
1194
1195 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1196 check till after the cache is created in init_frame_faces.
1197
1198 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1199
1200 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1201
1202 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1205 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1206 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1207
1208 Improve buffer-overflow checking (Bug#8873).
1209 * fileio.c (Finsert_file_contents):
1210 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1211 Remove the old (too-loose) buffer overflow checks.
1212 They weren't needed, since make_gap checks for buffer overflow.
1213 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1214 The old code merely checked for Emacs fixnum overflow, and relied
1215 on undefined (wraparound) behavior. The new code avoids undefined
1216 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1217
1218 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1219 Tune. Don't use wider integers than needed. Don't use alloca.
1220 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1221
1222 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1223
1224 * insdel.c, lisp.h (buffer_overflow): New function.
1225 (insert_from_buffer_1, replace_range, replace_range_2):
1226 * insdel.c (make_gap_larger):
1227 * editfns.c (Finsert_char):
1228 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1229
1230 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1231
1232 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 Integer overflow and signedness fixes (Bug#8873).
1235
1236 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1237 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1238
1239 * fileio.c: Don't assume EMACS_INT fits in off_t.
1240 (emacs_lseek): New static function.
1241 (Finsert_file_contents, Fwrite_region): Use it.
1242 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1243
1244 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1245
1246 * fns.c: Don't overflow int when computing a list length.
1247 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1248 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1249 truncation on 64-bit hosts. Check for QUIT every
1250 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1251 faster and is responsive enough.
1252 (Flength): Report an error instead of overflowing an integer.
1253 (Fsafe_length): Return a float if the value is not representable
1254 as a fixnum. This shouldn't happen except in contrived situations.
1255 (Fnthcdr, Fsort): Don't assume list length fits in int.
1256 (Fcopy_sequence): Don't assume vector length fits in int.
1257
1258 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1259 (header_size, word_size): New constants.
1260 (allocate_vectorlike): Don't check size overflow here.
1261 (allocate_vector): Check it here instead, since this is the only
1262 caller of allocate_vectorlike that could cause overflow.
1263 Check that the new vector's length is representable as a fixnum.
1264
1265 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1266 The previous code was bogus. For example, next_almost_prime (32)
1267 returned 39, which is undesirable as it is a multiple of 3; and
1268 next_almost_prime (24) returned 25, which is a multiple of 5 so
1269 why was the code bothering to check for multiples of 7?
1270
1271 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1272
1273 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1274
1275 Variadic C functions now count arguments with ptrdiff_t.
1276 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1277 Back then I didn't know that the Emacs coding style prefers signed int.
1278 Also, in the meantime I found a few more instances where arguments
1279 were being counted with int, which may truncate counts on 64-bit
1280 machines, or EMACS_INT, which may be unnecessarily wide.
1281 * lisp.h (struct Lisp_Subr.function.aMANY)
1282 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1283 Arg counts are now ptrdiff_t, not size_t.
1284 All variadic functions and their callers changed accordingly.
1285 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1286 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1287 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1288 * callint.c (Fcall_interactively): Check arg count for overflow,
1289 to avoid potential buffer overrun. Use signed char, not 'int',
1290 for 'varies' array, so that we needn't bother to check its size
1291 calculation for overflow.
1292 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1293 * eval.c (apply_lambda):
1294 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1295 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1296 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1297
1298 * callint.c (Fcall_interactively): Don't use index var as event count.
1299
1300 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1301 * mem-limits.h (SIZE): Remove; no longer used.
1302
1303 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1304
1305 Remove unnecessary casts.
1306 * xterm.c (x_term_init):
1307 * xfns.c (x_set_border_pixel):
1308 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1309 These aren't needed now that we assume ANSI C.
1310
1311 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1312 It's more likely to cause problems (due to unsigned overflow)
1313 than to cure them.
1314
1315 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1316
1317 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1318
1319 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1320
1321 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1322
1323 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1324
1325 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1326
1327 GLYPH_CODE_FACE returns EMACS_INT, not int.
1328 * dispextern.h (merge_faces):
1329 * xfaces.c (merge_faces):
1330 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1331 Don't assume EMACS_INT fits in int.
1332
1333 * character.h (CHAR_VALID_P): Remove unused parameter.
1334 * fontset.c, lisp.h, xdisp.c: All uses changed.
1335
1336 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1337
1338 * fns.c (concat): Minor tuning based on overflow analysis.
1339 This doesn't fix any bugs. Use int to hold character, instead
1340 of constantly refetching from Emacs object. Use XFASTINT, not
1341 XINT, for value known to be a character. Don't bother comparing
1342 a single byte to 0400, as it's always less.
1343
1344 * floatfns.c (Fexpt):
1345 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1346
1347 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1348 for characters.
1349
1350 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1351
1352 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1353 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1354 incorrectly succeed when S was a string, because 4294967386 was
1355 truncated before it was used.
1356
1357 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1358 Otherwise, an out-of-range integer could cause undefined behavior
1359 on a 64-bit host.
1360
1361 * composite.c: Use int, not EMACS_INT, for characters.
1362 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1363 EMACS_INT, for values that are known to be in character range.
1364 This doesn't fix any bugs but is the usual style inside Emacs and
1365 may generate better code on 32-bit machines.
1366
1367 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1368 This is for reasons similar to the recent CHAR_STRING fix.
1369 * charset.c (Fencode_char): Check that character arg is actually
1370 a character. Pass an int to ENCODE_CHAR.
1371 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1372 wider than 'int', as a compile-time check to prevent future regressions
1373 in this area.
1374
1375 * character.c (char_string): Remove unnecessary casts.
1376
1377 Make sure a 64-bit char is never passed to CHAR_STRING.
1378 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1379 by silently ignoring the top 32 bits, allowing some values
1380 that were far too large to be valid characters.
1381 * character.h: Include <verify.h>.
1382 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1383 arguments are no wider than unsigned, as a compile-time check
1384 to prevent future regressions in this area.
1385 * data.c (Faset):
1386 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1387 (Fsubst_char_in_region):
1388 * fns.c (concat):
1389 * xdisp.c (decode_mode_spec_coding):
1390 Adjust to CHAR_STRING's new requirement.
1391 * editfns.c (Finsert_char, Fsubst_char_in_region):
1392 * fns.c (concat): Check that character args are actually
1393 characters. Without this test, these functions did the wrong
1394 thing with wildly out-of-range values on 64-bit hosts.
1395
1396 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1397 These casts should not be needed on 32-bit hosts, either.
1398 * keyboard.c (read_char):
1399 * lread.c (Fload): Remove casts to unsigned.
1400
1401 * lisp.h (UNSIGNED_CMP): New macro.
1402 This fixes comparison bugs on 64-bit hosts.
1403 (ASCII_CHAR_P): Use it.
1404 * casefiddle.c (casify_object):
1405 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1406 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1407 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1408 * dispextern.h (FACE_FROM_ID):
1409 * keyboard.c (read_char): Use UNSIGNED_CMP.
1410
1411 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1412 not to EMACS_INT, to avoid GCC warning.
1413
1414 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1415
1416 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1417 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1418 isn't needed on 32-bit machines.
1419
1420 * buffer.c (Fgenerate_new_buffer_name):
1421 Use EMACS_INT for count, not int.
1422 (advance_to_char_boundary): Return EMACS_INT, not int.
1423
1424 * data.c (Qcompiled_function): Now static.
1425
1426 * window.c (window_body_lines): Now static.
1427
1428 * image.c (gif_load): Rename local to avoid shadowing.
1429
1430 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1431 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1432 * alloc.c (make_save_value): Integer argument is now of type
1433 ptrdiff_t, not int.
1434 (mark_object): Use ptrdiff_t, not int.
1435 * lisp.h (pD): New macro.
1436 * print.c (print_object): Use it.
1437
1438 * alloc.c: Use EMACS_INT, not int, to count objects.
1439 (total_conses, total_markers, total_symbols, total_vector_size)
1440 (total_free_conses, total_free_markers, total_free_symbols)
1441 (total_free_floats, total_floats, total_free_intervals)
1442 (total_intervals, total_strings, total_free_strings):
1443 Now EMACS_INT, not int. All uses changed.
1444 (Fgarbage_collect): Compute overall total using a double, so that
1445 integer overflow is less likely to be a problem. Check for overflow
1446 when converting back to an integer.
1447 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1448 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1449 These were 'int' variables that could overflow on 64-bit hosts;
1450 they were never used, so remove them instead of repairing them.
1451 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1452 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1453 Previously, this ceilinged at INT_MAX, but that doesn't work on
1454 64-bit machines.
1455 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1456
1457 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1458 (allocate_vectorlike): Check for ptrdiff_t overflow.
1459 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1460 when a (possibly-narrower) signed value would do just as well.
1461 We prefer using signed arithmetic, to avoid comparison confusion.
1462
1463 * alloc.c: Catch some string size overflows that we were missing.
1464 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1465 for convenience in STRING_BYTES_MAX.
1466 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1467 The definition here is exact; the one in lisp.h was approximate.
1468 (allocate_string_data): Check for string overflow. This catches
1469 some instances we weren't catching before. Also, it catches
1470 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1471 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1472 and ptrdiff_t and EMACS_INT are both 64 bits.
1473
1474 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1475 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1476 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1477
1478 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1479
1480 * alloc.c (Fmake_string): Check for out-of-range init.
1481
1482 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1483
1484 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1485
1486 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1487
1488 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1489 xg_get_default_scrollbar_width.
1490
1491 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1492 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1493 (style_changed_cb): Call update_theme_scrollbar_width and call
1494 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1495 all frames (Bug#8505).
1496 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1497 Call gtk_window_set_resizable if HAVE_GTK3.
1498 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1499 and height if HAVE_GTK3 (Bug#8505).
1500 (scroll_bar_width_for_theme): New variable.
1501 (update_theme_scrollbar_width): New function.
1502 (xg_get_default_scrollbar_width): Move code to
1503 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1504 (xg_initialize): Call update_theme_scrollbar_width.
1505
1506 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1507
1508 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1509
1510 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1511
1512 * frame.c (make_frame): Call other_buffer_safely instead of
1513 other_buffer.
1514
1515 * window.c (temp_output_buffer_show): Call display_buffer with
1516 second argument Vtemp_buffer_show_specifiers and reset latter
1517 immediately after the call.
1518 (Vtemp_buffer_show_specifiers): New variable.
1519 (auto_window_vscroll_p, next_screen_context_lines)
1520 (Vscroll_preserve_screen_position): Remove leading asterisks from
1521 doc-strings.
1522
1523 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 Fix minor problems found by GCC 4.6.0 static checking.
1526 * buffer.c (Qclone_number): Remove for now, as it's unused.
1527 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1528 (record_buffer): Remove unused local.
1529 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1530 (set_frame_buffer_list): Remove; unused.
1531 * frame.h (other_visible_frames): Remove decl.
1532 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1533 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1534 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1535 if HAVE_GPM.
1536 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1537 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1538 Define only if HAVE_GPM.
1539 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1540 (update_hints_inhibit): Remove; never set. All uses removed.
1541 * widgetprv.h (emacsFrameClassRec): Remove decl.
1542 * window.c (delete_deletable_window): Now returns void, since it
1543 wasn't returning anything.
1544 (compare_window_configurations): Remove unused locals.
1545 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1546 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1547 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1548 the same widths as pointers. This follows up on the 2011-05-06 patch.
1549 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1550 * xterm.h: Likewise.
1551 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1552
1553 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1554
1555 * makefile.w32-in: Update dependencies.
1556 (LISP_H): Add lib/intprops.h.
1557
1558 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1559
1560 * image.c (gif_load): Add animation frame delay to the metadata.
1561 (syms_of_image): Use DEFSYM. New symbol `delay'.
1562
1563 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1564
1565 * window.c (delete_deletable_window): Re-add.
1566 (Fset_window_configuration): Rewrite to handle dead buffers and
1567 consequently deletable windows.
1568 (window_tree, Fwindow_tree): Remove. Supply functionality in
1569 window.el.
1570 (compare_window_configurations): Simplify code.
1571
1572 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1573
1574 * image.c (imagemagick_load_image): Fix type mismatch.
1575 (Fimagemagick_types): Likewise.
1576
1577 * window.h (replace_buffer_in_windows): Declare.
1578
1579 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1580
1581 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1582 Qclone_number. Remove external declaration of Qdelete_window.
1583 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1584 code.
1585 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1586 Qbuffer_list_update_hook if allowed.
1587 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1588 buffer list implementation.
1589 (other_buffer_safely): New function.
1590 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1591 calls to replace_buffer_in_windows and
1592 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1593 if allowed.
1594 (record_buffer): Inhibit quitting and rewrite using quittable
1595 functions. Run Qbuffer_list_update_hook if allowed.
1596 (Frecord_buffer, Funrecord_buffer): New functions.
1597 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1598 switch-to-buffer to window.el.
1599 (bury-buffer): Move to window.el.
1600 (Vbuffer_list_update_hook): New variable.
1601
1602 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1603 section.
1604
1605 * window.h (resize_frame_windows): Move up in code.
1606 (Fwindow_frame): Remove EXFUN.
1607 (replace_buffer_in_all_windows): Remove prototype.
1608 (replace_buffer_in_windows_safely): Add prototype.
1609
1610 * window.c: Declare Qdelete_window static again. Move down
1611 declaration of select_count.
1612 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1613 (Fother_window): Move to window.el.
1614 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1615 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1616 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1617 window.el.
1618 (replace_buffer_in_windows): Implement by calling
1619 Qreplace_buffer_in_windows.
1620 (replace_buffer_in_all_windows): Remove with some functionality
1621 moved into replace_buffer_in_windows_safely.
1622 (replace_buffer_in_windows_safely): New function.
1623 (select_window_norecord, select_frame_norecord): Move in front
1624 of run_window_configuration_change_hook. Remove now obsolete
1625 declarations.
1626 (Fset_window_buffer): Rewrite doc-string. Call
1627 Qrecord_window_buffer.
1628 (keys_of_window): Move binding for other-window to window.el.
1629
1630 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1631
1632 * dispextern.h (struct image): Replace data member, whose int_val
1633 and ptr_val fields were not used by anything, with a single
1634 lisp_val object.
1635
1636 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1637 (gif_clear_image, gif_load, imagemagick_load_image)
1638 (gs_clear_image, gs_load): Callers changed.
1639
1640 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1641
1642 * buffer.h: Include <time.h>, for time_t.
1643 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1644
1645 Fix minor problems found by static checking.
1646
1647 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1648
1649 Make identifiers static if they are not used in other modules.
1650 * data.c (Qcompiled_function, Qframe, Qvector):
1651 * image.c (QimageMagick, Qsvg):
1652 * minibuf.c (Qmetadata):
1653 * window.c (resize_window_check, resize_root_window): Now static.
1654 * window.h (resize_window_check, resize_root_window): Remove decls.
1655
1656 * window.c (window_deletion_count, delete_deletable_window):
1657 Remove; unused.
1658 (window_body_lines): Now static.
1659 (Fdelete_other_windows_internal): Mark vars as initialized.
1660 Make sure 'resize_failed' is initialized.
1661 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1662 (resize_window_apply): Remove unused local.
1663 * window.h (delete_deletable_window): Remove decl.
1664
1665 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1666 (imagemagick_load_image): Fix pointer signedness problem by changing
1667 last arg from unsigned char * to char *. All uses changed.
1668 Also, fix a local for similar reasons.
1669 Remove unused locals. Remove locals to avoid shadowing.
1670 (fn_rsvg_handle_free): Remove; unused.
1671 (svg_load, svg_load_image): Fix pointer signedness problem.
1672 (imagemagick_load_image): Don't use garbage pointer image_wand.
1673
1674 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1675
1676 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1677
1678 * image.c (gif_load): Fix omitted cast error introduced by
1679 2011-06-06 change.
1680
1681 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1682
1683 * window.h (resize_proportionally, orig_total_lines)
1684 (orig_top_line): Remove from window structure.
1685 (set_window_height, set_window_width, change_window_heights)
1686 (Fdelete_window): Remove prototypes.
1687 (resize_frame_windows): Remove duplicate declaration.
1688
1689 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1690
1691 * window.h (resize_frame_windows, resize_window_check)
1692 (delete_deletable_window, resize_root_window)
1693 (resize_frame_windows): Declare prototypes.
1694
1695 * window.c (resize_window_apply): Make definition be "static" to
1696 match the prototype.
1697
1698 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1699
1700 * window.c: Remove declarations of Qwindow_size_fixed,
1701 window_min_size_1, window_min_size_2, window_min_size,
1702 size_window, window_fixed_size_p, enlarge_window, delete_window.
1703 Remove static from declaration of Qdelete_window, it's
1704 temporarily needed by Fbury_buffer.
1705 (replace_window): Don't assign orig_top_line and
1706 orig_total_lines.
1707 (Fdelete_window, delete_window): Remove. Window deletion is
1708 handled by window.el.
1709 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1710 Fdelete_window calls with calls to Qdelete_window.
1711 (Fdelete_other_windows): Remove. Deleting other windows is
1712 handled by window.el.
1713 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1714 handled in window.el.
1715 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1716 Window minimum sizes are handled in window.el.
1717 (shrink_windows, size_window, set_window_height)
1718 (set_window_width, change_window_heights, window_height)
1719 (window_width, CURBEG, CURSIZE, enlarge_window)
1720 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1721 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1722 handled in window.el.
1723 (make_dummy_parent): Rename to make_parent_window and give it a
1724 second argument horflag.
1725 (make_window): Don't set resize_proportionally any more.
1726 (Fsplit_window): Remove. Windows are split in window.el.
1727 (save_restore_action, save_restore_orig_size)
1728 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1729 Resize mini windows in window.el.
1730 (grow_mini_window, shrink_mini_window): Implement by calling
1731 Qresize_root_window_vertically, resize_window_check and
1732 resize_window_apply.
1733 (saved_window, Fset_window_configuration, save_window_save): Do
1734 not handle orig_top_line, orig_total_lines, and
1735 resize_proportionally.
1736 (window_min_height, window_min_width): Move to window.el.
1737 (keys_of_window): Move bindings for delete-other-windows,
1738 split-window, delete-window and enlarge-window to window.el.
1739
1740 * buffer.c: Temporarily extern Qdelete_window.
1741 (Fbury_buffer): Temporarily call Qdelete_window instead of
1742 Fdelete_window (Fbury_buffer will move to window.el soon).
1743
1744 * frame.c (set_menu_bar_lines_1): Remove code handling
1745 orig_top_line and orig_total_lines.
1746
1747 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1748 set_window_height but set heights directly.
1749 (change_frame_size_1): Use resize_frame_windows.
1750
1751 * xdisp.c (init_xdisp): Don't use set_window_height but set
1752 heights directly.
1753
1754 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1755 resize_frame_windows instead of change_window_heights and run
1756 run_window_configuration_change_hook.
1757
1758 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1759 instead of change_window_heights and run
1760 run_window_configuration_change_hook.
1761
1762 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1763
1764 * window.c (replace_window): Rename second argument REPLACEMENT to
1765 NEW. New third argument SETFLAG. Rewrite.
1766 (delete_window, make_dummy_parent): Call replace_window with
1767 third argument 1.
1768 (window_list_1): Move down in code.
1769 (run_window_configuration_change_hook): Move set_buffer part
1770 before select_frame_norecord part in order to unwind correctly.
1771 Rename count1 to count.
1772 (recombine_windows, delete_deletable_window, resize_root_window)
1773 (Fdelete_other_windows_internal)
1774 (Frun_window_configuration_change_hook, make_parent_window)
1775 (resize_window_check, resize_window_apply, Fresize_window_apply)
1776 (resize_frame_windows, Fsplit_window_internal)
1777 (Fdelete_window_internal, Fresize_mini_window_internal): New
1778 functions.
1779 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1780
1781 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1782
1783 * window.h (window): Add some new members to window structure -
1784 normal_lines, normal_cols, new_total, new_normal, clone_number,
1785 splits, nest, prev_buffers, next_buffers.
1786 (WINDOW_TOTAL_SIZE): Move here from window.c.
1787 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1788
1789 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1790 Remove.
1791 (make_dummy_parent): Set new members of windows structure.
1792 (make_window): Move down in code. Handle new members of window
1793 structure.
1794 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1795 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1796 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1797 (Fset_window_prev_buffers, Fwindow_next_buffers)
1798 (Fset_window_next_buffers, Fset_window_clone_number): New
1799 functions.
1800 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1801 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1802 Doc-string fixes.
1803 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1804 Argument WINDOW can be now internal window too.
1805 (Fwindow_use_time): Move up in code.
1806 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1807 Rewrite doc-string.
1808 (Fset_window_configuration, saved_window)
1809 (Fcurrent_window_configuration, save_window_save): Handle new
1810 members of window structure.
1811 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1812 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1813 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1814 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1815 Qget_mru_window, Qresize_root_window,
1816 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1817 Qauto_buffer_name; staticpro them.
1818
1819 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1820
1821 * window.c (Fwindow_total_size, Fwindow_left_column)
1822 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1823 (Fwindow_list_1): New functions.
1824 (window_box_text_cols): Replace with window_body_cols.
1825 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1826 window_body_cols instead of window_box_text_cols.
1827 (delete_window, Fset_window_configuration): Call
1828 delete_all_subwindows with window as argument.
1829 (delete_all_subwindows): Take a window as argument and not a
1830 structure. Rewrite.
1831 (window_loop): Remove handling of GET_LRU_WINDOW and
1832 GET_LARGEST_WINDOW.
1833 (Fget_lru_window, Fget_largest_window): Move to window.el.
1834
1835 * window.h: Extern window_body_cols instead of
1836 window_box_text_cols. delete_all_subwindows now takes a
1837 Lisp_Object as argument.
1838
1839 * indent.c (compute_motion, Fcompute_motion): Use
1840 window_body_cols instead of window_box_text_cols.
1841
1842 * frame.c (delete_frame): Call delete_all_subwindows with root
1843 window as argument.
1844
1845 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1846
1847 * fns.c (Fputhash): Document return value.
1848
1849 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1850
1851 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1852
1853 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1854
1855 Cons<->int and similar integer overflow fixes (Bug#8794).
1856
1857 Check for overflow when converting integer to cons and back.
1858 * charset.c (Fdefine_charset_internal, Fdecode_char):
1859 Use cons_to_unsigned to catch overflow.
1860 (Fencode_char): Use INTEGER_TO_CONS.
1861 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1862 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1863 * data.c (long_to_cons, cons_to_long): Remove.
1864 (cons_to_unsigned, cons_to_signed): New functions.
1865 These signal an error for invalid or out-of-range values.
1866 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1867 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1868 * font.c (Ffont_variation_glyphs):
1869 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1870 * lisp.h: Include <intprops.h>.
1871 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1872 (cons_to_signed, cons_to_unsigned): New decls.
1873 (long_to_cons, cons_to_long): Remove decls.
1874 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1875 (Fprimitive_undo): Use CONS_TO_INTEGER.
1876 * xfns.c (Fx_window_property): Likewise.
1877 * xselect.c: Include <limits.h>.
1878 (x_own_selection, selection_data_to_lisp_data):
1879 Use INTEGER_TO_CONS.
1880 (x_handle_selection_request, x_handle_selection_clear)
1881 (x_get_foreign_selection, Fx_disown_selection_internal)
1882 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1883 (lisp_data_to_selection_data): Use cons_to_unsigned.
1884 (x_fill_property_data): Use cons_to_signed.
1885 Report values out of range.
1886
1887 Check for buffer and string overflow more precisely.
1888 * buffer.h (BUF_BYTES_MAX): New macro.
1889 * lisp.h (STRING_BYTES_MAX): New macro.
1890 * alloc.c (Fmake_string):
1891 * character.c (string_escape_byte8):
1892 * coding.c (coding_alloc_by_realloc):
1893 * doprnt.c (doprnt):
1894 * editfns.c (Fformat):
1895 * eval.c (verror):
1896 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1897 since they may not be the same number.
1898 * editfns.c (Finsert_char):
1899 * fileio.c (Finsert_file_contents):
1900 Likewise for BUF_BYTES_MAX.
1901
1902 * image.c: Use ptrdiff_t, not int, for sizes.
1903 (slurp_file): Switch from int to ptrdiff_t.
1904 All uses changed.
1905 (slurp_file): Check that file size fits in both size_t (for
1906 malloc) and ptrdiff_t (for sanity and safety).
1907
1908 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1909 if b->modtime has its maximal value.
1910
1911 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1912
1913 Don't assume time_t can fit into int.
1914 * buffer.h (struct buffer.modtime): Now time_t, not int.
1915 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1916 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1917
1918 Minor fixes for signed vs unsigned integers.
1919 * character.h (MAYBE_UNIFY_CHAR):
1920 * charset.c (maybe_unify_char):
1921 * keyboard.c (read_char, reorder_modifiers):
1922 XINT -> XFASTINT, since the integer must be nonnegative.
1923 * ftfont.c (ftfont_spec_pattern):
1924 * keymap.c (access_keymap, silly_event_symbol_error):
1925 XUINT -> XFASTINT, since the integer must be nonnegative.
1926 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1927 since it makes no difference and we prefer signed.
1928 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1929 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1930 nonnegative.
1931
1932 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1933
1934 * window.h (Fwindow_frame): Declare.
1935
1936 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1937
1938 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1939 (SPARE_MEMORY): Always define.
1940 (LARGE_REQUEST): Remove.
1941 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1942
1943 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1944
1945 * lisp.h: Move EXFUNS for Fframe_root_window,
1946 Fframe_first_window and Fset_frame_selected_window to window.h.
1947
1948 * window.h: Move EXFUNS for Fframe_root_window,
1949 Fframe_first_window and Fset_frame_selected_window here from
1950 lisp.h.
1951
1952 * frame.c (Fwindow_frame, Fframe_first_window)
1953 (Fframe_root_window, Fframe_selected_window)
1954 (Fset_frame_selected_window): Move to window.c.
1955 (Factive_minibuffer_window): Move to minibuf.c.
1956 (Fother_visible_frames_p): New function.
1957
1958 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1959
1960 * window.c (decode_window, decode_any_window): Move up in code.
1961 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1962 (inhibit_frame_unsplittable): Remove unused variable.
1963 (Fwindow_buffer): Move up and rewrite doc-string.
1964 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1965 (Fwindow_prev): New functions.
1966 (Fwindow_frame): Move here from frame.c. Accept any window as
1967 argument.
1968 (Fframe_root_window, Fframe_first_window)
1969 (Fframe_selected_window): Move here from frame.c. Accept frame
1970 or arbitrary window as argument. Update doc-strings.
1971 (Fminibuffer_window): Move up in code.
1972 (Fwindow_minibuffer_p): Move up in code and simplify.
1973 (Fset_frame_selected_window): Move here from frame.c.
1974 Marginal rewrite.
1975 (Fselected_window, select_window, Fselect_window): Move up in
1976 code. Minor doc-string fixes.
1977
1978 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1979
1980 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1981 Do not assume that spare memory exists; that assumption is valid
1982 only if SYSTEM_MALLOC.
1983 (LARGE_REQUEST): New macro, so that the issue of large requests
1984 is separated from the issue of spare memory.
1985
1986 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1987
1988 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1989 format. (Bug#8806)
1990
1991 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1992
1993 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1994 before statements.
1995
1996 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1997
1998 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1999
2000 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2001
2002 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2003 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2004
2005 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2006
2007 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2008
2009 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2010
2011 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2012 (x_clipboard_manager_save): Add return value.
2013 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2014 New error handlers.
2015 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2016 Obey Vx_select_enable_clipboard_manager. Catch errors in
2017 x_clipboard_manager_save (Bug#8779).
2018 (Vx_select_enable_clipboard_manager): New variable.
2019 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2020
2021 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2022
2023 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2024
2025 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2026
2027 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2028 in the current matrix if keep_current_p is non-zero.
2029
2030 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2031
2032 * bidi.c (bidi_level_of_next_char): Fix last change.
2033
2034 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2035
2036 Support bidi reordering of text covered by display properties.
2037
2038 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2039 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2040 (bidi_cache_search, bidi_cache_iterator_state)
2041 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2042 (bidi_level_of_next_char, bidi_move_to_visually_next):
2043 Support character positions inside a run of characters covered by a
2044 display string.
2045 (bidi_paragraph_init, bidi_resolve_explicit_1)
2046 (bidi_level_of_next_char): Call bidi_fetch_char and
2047 bidi_fetch_char_advance instead of FETCH_CHAR and
2048 FETCH_CHAR_ADVANCE.
2049 (bidi_init_it): Initialize new members.
2050 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2051 definitions.
2052 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2053 instead of using explicit *_CHAR codes.
2054 (bidi_resolve_explicit, bidi_resolve_weak):
2055 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2056 bidirectional text is supported only in multibyte buffers.
2057 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2058 it to initialize the frame_window_p member of struct bidi_it.
2059 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2060 (bidi_resolve_explicit, bidi_resolve_weak)
2061 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2062 bidi_it->nchars is non-positive.
2063 (bidi_level_of_next_char): Don't try to lookup the cache for the
2064 next/previous character if nothing is cached there yet, or if we
2065 were just reseat()'ed to a new position.
2066
2067 * xdisp.c (set_cursor_from_row): Set start and stop points
2068 according to the row's direction when priming the loop that looks
2069 for the glyph on which to display cursor.
2070 (single_display_spec_intangible_p): Function deleted.
2071 (display_prop_intangible_p): Reimplement to call
2072 handle_display_spec instead of single_display_spec_intangible_p.
2073 Accept 3 additional arguments needed by handle_display_spec.
2074 This fixes incorrect cursor motion across display property with complex
2075 values: lists, `(when COND...)' forms, etc.
2076 (single_display_spec_string_p): Support property values that are
2077 lists with the argument STRING its top-level element.
2078 (display_prop_string_p): Fix the condition for processing a
2079 property that is a list to be consistent with handle_display_spec.
2080 (handle_display_spec): New function, refactored from the
2081 last portion of handle_display_prop.
2082 (compute_display_string_pos): Accept additional argument
2083 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2084 value of a `display' property is a "replacing spec".
2085 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2086 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2087 the display property, but just return a value indicating whether
2088 the display property will replace the characters it covers.
2089 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2090 frame_window_p members of struct bidi_it.
2091 (compute_display_string_pos, compute_display_string_end):
2092 New functions.
2093 (push_it): Accept second argument POSITION, where pop_it should
2094 jump to continue iteration.
2095 (reseat_1): Initialize bidi_it.disp_pos.
2096
2097 * keyboard.c (adjust_point_for_property): Adjust the call to
2098 display_prop_intangible_p to its new signature.
2099
2100 * dispextern.h (struct bidi_it): New member frame_window_p.
2101 (bidi_init_it): Update prototypes.
2102 (display_prop_intangible_p): Update prototype.
2103 (compute_display_string_pos, compute_display_string_end):
2104 Declare prototypes.
2105 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2106 EMACS_INT.
2107
2108 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 Malloc failure behavior now depends on size of allocation.
2111 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2112 * lisp.h: Change signatures accordingly.
2113 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2114 All callers changed. (Bug#8762)
2115
2116 * gnutls.c: Use Emacs's memory allocators.
2117 Without this change, the gnutls library would invoke malloc etc.
2118 directly, which causes problems on non-SYNC_INPUT hosts, and which
2119 runs afoul of improving memory_full behavior. (Bug#8761)
2120 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2121 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2122 xfree instead of the default malloc, realloc, free.
2123 (Fgnutls_boot): No need to check for memory allocation failure,
2124 since xmalloc does that for us.
2125
2126 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2127 * category.c (hash_get_category_set):
2128 * ccl.c (ccl_driver):
2129 * charset.c (Fdefine_charset_internal):
2130 * charset.h (struct charset.hash_index):
2131 * composite.c (get_composition_id, gstring_lookup_cache)
2132 (composition_gstring_put_cache):
2133 * composite.h (struct composition.hash_index):
2134 * dispextern.h (struct image.hash):
2135 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2136 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2137 (hashfn_equal, hashfn_user_defined, make_hash_table)
2138 (maybe_resize_hash_table, hash_lookup, hash_put)
2139 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2140 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2141 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2142 * image.c (make_image, search_image_cache, lookup_image)
2143 (xpm_put_color_table_h):
2144 * lisp.h (struct Lisp_Hash_Table):
2145 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2146 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2147 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2148 * alloc.c (allocate_vectorlike):
2149 Check for overflow in vector size calculations.
2150 * ccl.c (ccl_driver):
2151 Check for overflow when converting EMACS_INT to int.
2152 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2153 need to be updated by these changes.
2154 * fns.c (make_hash_table, maybe_resize_hash_table):
2155 Check for integer overflow with large hash tables.
2156 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2157 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2158 (SXHASH_REDUCE): New macro.
2159 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2160 Use it instead of discarding useful hash info with large hash values.
2161 (sxhash_float): New function.
2162 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2163 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2164 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2165 Rewrite to use FIXNUM_BITS, as this simplifies things.
2166 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2167 Adjust signatures to match updated version of code.
2168 (consing_since_gc): Now EMACS_INT, since a single hash table can
2169 use more than INT_MAX bytes.
2170
2171 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2172
2173 Make it possible to build with GCC-4.6+ -O2 -flto.
2174
2175 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2176
2177 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2178
2179 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2180 Call minibuffer-inactive-mode.
2181
2182 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2183
2184 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2185 Update dependencies.
2186
2187 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2188
2189 * data.c (init_data): Remove code for UTS, this system is not
2190 supported anymore.
2191
2192 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2193
2194 Don't force ./temacs to start in terminal mode.
2195
2196 * frame.c (make_initial_frame): Initialize faces in all cases, not
2197 only when CANNOT_DUMP is defined.
2198 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2199
2200 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2201
2202 * dispnew.c (add_window_display_history): Use const for the string
2203 pointer. Remove declaration, not needed.
2204
2205 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2206
2207 Use 'inline', not 'INLINE'.
2208 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2209 * alloc.c, fontset.c (INLINE): Remove.
2210 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2211 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2212 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2213 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2214 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2215
2216 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2217
2218 Make it possible to run ./temacs.
2219
2220 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2221 syms_of_callproc does the same thing. Remove test for
2222 "initialized", do it in the caller.
2223 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2224
2225 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2226
2227 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2228 (read_minibuf): Use get_minibuffer.
2229 (syms_of_minibuf): Use DEFSYM.
2230 (Qmetadata): New var.
2231 * data.c (Qbuffer): Don't make it static.
2232 (syms_of_data): Use DEFSYM.
2233
2234 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2235
2236 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2237 (CCL_CODE_MIN): New macro.
2238
2239 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2240
2241 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2242
2243 * eval.c (Qdebug): Now static.
2244 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2245 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2246 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2247
2248 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2249
2250 * image.c: Various fixes to ImageMagick code comments.
2251 (Fimagemagick_types): Doc fix.
2252
2253 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2254
2255 Minor fixes prompted by GCC 4.6.0 warnings.
2256
2257 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2258
2259 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2260 (x_clipboard_manager_save_all): Move extern decl to ...
2261 * xterm.h: ... here, so that it can be checked for consistency.
2262
2263 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2264
2265 * xselect.c (x_clipboard_manager_save_frame)
2266 (x_clipboard_manager_save_all): New functions.
2267 (Fx_clipboard_manager_save): Lisp function deleted.
2268
2269 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2270 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2271
2272 * xterm.h: Update prototype.
2273
2274 2011-05-28 William Xu <william.xwl@gmail.com>
2275
2276 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2277 exiting (Bug#8239).
2278
2279 2011-05-28 Jim Meyering <meyering@redhat.com>
2280
2281 Avoid a sign-extension bug in crypto_hash_function.
2282 * fns.c (to_uchar): Define.
2283 (crypto_hash_function): Use it to convert some newly-signed
2284 variables to unsigned, to avoid sign-extension bugs. For example,
2285 without this change, (md5 "truc") would evaluate to
2286 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2287 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2288 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2289
2290 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2291
2292 Integer overflow fixes.
2293
2294 * dbusbind.c: Serial number integer overflow fixes.
2295 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2296 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2297 to hold a serial number that is too large for a fixnum.
2298 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2299 Check for serial numbers out of range. Decode any serial number
2300 that was so large that it became a float. (Bug#8722)
2301
2302 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2303 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2304 Use XFASTINT rather than XUINT when numbers are nonnegative.
2305 (xd_append_arg, Fdbus_method_return_internal):
2306 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2307 arguments, check that Lisp number is nonnegative, rather than
2308 silently wrapping negative numbers around. (Bug#8722)
2309 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2310 (Bug#8722)
2311
2312 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2313
2314 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2315
2316 ccl: add integer overflow checks
2317 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2318 (IN_INT_RANGE): New macros.
2319 (ccl_driver): Use them to check for integer overflow when
2320 decoding a CCL program. Many of the new checks are whether XINT (x)
2321 fits in int; it doesn't always, on 64-bit hosts. The new version
2322 doesn't catch all possible integer overflows, but it's an
2323 improvement. (Bug#8719)
2324
2325 * alloc.c (make_event_array): Use XINT, not XUINT.
2326 There's no need for unsigned here.
2327
2328 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2329 This follows up to the 2011-05-06 change that substituted uintptr_t
2330 for EMACS_INT. This case wasn't caught back then.
2331
2332 Rework Fformat to avoid integer overflow issues.
2333 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2334 now (part of C89). Include <verify.h>.
2335 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2336 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2337 (Fformat): Avoid the prepass trying to compute sizes; it was only
2338 approximate and thus did not catch overflow reliably. Instead, walk
2339 through the format just once, formatting and computing sizes as we go,
2340 checking for integer overflow at every step, and allocating a larger
2341 buffer as needed. Keep track separately whether the format is
2342 multibyte. Keep only the most-recently calculated precision, rather
2343 than them all. Record whether each argument has been converted to
2344 string. Use EMACS_INT, not int, for byte and char and arg counts.
2345 Support field widths and precisions larger than INT_MAX. Avoid
2346 sprintf's undefined behavior with conversion specifications such as %#d
2347 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2348 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2349 formatting out-of-range floating point numbers with int
2350 formats. (Bug#8668)
2351
2352 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2353
2354 * data.c: Avoid integer truncation in expressions involving floats.
2355 * data.c: Include <intprops.h>.
2356 (arith_driver): When there's an integer overflow in an expression
2357 involving floating point, convert the integers to floating point
2358 so that the resulting value does not suffer from catastrophic
2359 integer truncation. For example, on a 64-bit host (* 4
2360 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2361 Do not rely on undefined behavior after integer overflow.
2362
2363 merge count_size_as_multibyte, parse_str_to_multibyte
2364 * character.c, character.h (count_size_as_multibyte):
2365 Rename from parse_str_to_multibyte; all uses changed.
2366 Check for integer overflow.
2367 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2368 since it's now a duplicate of the other. This is more of
2369 a character than a buffer op, so better that it's in character.c.
2370 * fns.c, print.c: Adjust to above changes.
2371
2372 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2373
2374 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2375
2376 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2377
2378 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2379 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2380 (x_clipboard_manager_save): Now static.
2381 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2382
2383 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2384 (crypto_hash_function): Now static.
2385 Fix pointer signedness problems. Avoid unnecessary initializations.
2386
2387 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2388
2389 * termhooks.h (Vselection_alist): Make it terminal-local.
2390
2391 * terminal.c (create_terminal): Initialize it.
2392
2393 * xselect.c: Support for clipboard managers.
2394 (Vselection_alist): Move to termhooks.h as terminal-local var.
2395 (LOCAL_SELECTION): New macro.
2396 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2397 (symbol_to_x_atom): Remove gratuitous arg.
2398 (x_handle_selection_request, lisp_data_to_selection_data)
2399 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2400 (x_own_selection, x_get_local_selection, x_convert_selection):
2401 New arg, specifying work frame. Use terminal-local Vselection_alist.
2402 (some_frame_on_display): Delete unused function.
2403 (Fx_own_selection_internal, Fx_get_selection_internal)
2404 (Fx_disown_selection_internal, Fx_selection_owner_p)
2405 (Fx_selection_exists_p): New optional frame arg.
2406 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2407 (x_handle_selection_clear): Don't treat other terminals with the
2408 same keyboard specially. Use the terminal-local Vselection_alist.
2409 (x_clear_frame_selections): Use Frun_hook_with_args.
2410
2411 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2412
2413 * xterm.h: Add support for those atoms.
2414
2415 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2416
2417 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2418 (converted_selections, conversion_fail_tag): New global variables.
2419 (x_selection_request_lisp_error): Free the above.
2420 (x_get_local_selection): Remove unnecessary code.
2421 (x_reply_selection_request): Args changed; handle arbitrary array
2422 of converted selections stored in converted_selections.
2423 Separate the XChangeProperty and SelectionNotify steps.
2424 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2425 (x_convert_selection): New function.
2426 (x_handle_selection_event): Simplify.
2427 (x_get_foreign_selection): Don't ignore incoming requests while
2428 waiting for an answer; this will fail when we implement
2429 SAVE_TARGETS, and seems unnecessary anyway.
2430 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2431 (Vx_sent_selection_functions): Doc fix.
2432
2433 2011-05-26 Leo Liu <sdl.web@gmail.com>
2434
2435 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2436
2437 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2438
2439 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2440
2441 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2442 for fringe update if it has periodic bitmap.
2443 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2444 and fringe_bitmap_periodic_p.
2445
2446 * fringe.c (get_fringe_bitmap_data): New function.
2447 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2448 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2449 row. Mark glyph row for fringe update if periodicity changed.
2450
2451 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2452 for fringe update unless it has periodic bitmap.
2453
2454 2011-05-25 Kenichi Handa <handa@m17n.org>
2455
2456 * xdisp.c (get_next_display_element): Set correct it->face_id for
2457 a static composition.
2458
2459 2011-05-24 Leo Liu <sdl.web@gmail.com>
2460
2461 * deps.mk (fns.o):
2462 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2463
2464 * fns.c (crypto_hash_function, Fsha1): New function.
2465 (Fmd5): Use crypto_hash_function.
2466 (syms_of_fns): Add Ssha1.
2467
2468 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2469
2470 * gnutls.c: Remove unused macros.
2471 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2472 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2473 Remove macros that are defined and never used.
2474 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2475
2476 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2477
2478 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2479 (Fx_get_selection_internal): Minor cleanup.
2480 (Fx_own_selection_internal): Rename arguments for consistency with
2481 select.el.
2482
2483 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2486
2487 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2488
2489 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2490
2491 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2492
2493 * dispnew.c (scrolling_window): Don't exclude the case that the
2494 last enabled row in the desired matrix touches the bottom boundary.
2495
2496 2011-05-21 Glenn Morris <rgm@gnu.org>
2497
2498 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2499 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2500 and add some more files.
2501
2502 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2503
2504 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2505 report_file_error introduced by the change from 2011-05-07.
2506
2507 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2508
2509 * systime.h (Time): Define only if emacs is defined.
2510 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2511 where the include path doesn't have X11/X.h by default. See
2512 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2513
2514 2011-05-20 Kenichi Handa <handa@m17n.org>
2515
2516 * composite.c (find_automatic_composition): Fix previous change.
2517
2518 2011-05-20 Glenn Morris <rgm@gnu.org>
2519
2520 * lisp.mk: New file, split from Makefile.in.
2521 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2522 (shortlisp): Remove.
2523 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2524
2525 2011-05-19 Glenn Morris <rgm@gnu.org>
2526
2527 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2528 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2529 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2530 (lisp): Set the order to that of loadup.el.
2531 (shortlisp): Make it a copy of $lisp.
2532 (SOME_MACHINE_LISP): Remove.
2533 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2534 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2535
2536 2011-05-18 Kenichi Handa <handa@m17n.org>
2537
2538 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2539 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2540 (find_automatic_composition): Mostly rewrite for efficiency.
2541
2542 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2543
2544 * makefile.w32-in: Update dependencies.
2545
2546 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2547
2548 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2549 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2550
2551 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2552
2553 Fix some integer overflow issues, such as string length overflow.
2554
2555 * insdel.c (count_size_as_multibyte): Check for string overflow.
2556
2557 * character.c (lisp_string_width): Check for string overflow.
2558 Use EMACS_INT, not int, for string indexes and lengths; in
2559 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2560 the resulting string length overflows an EMACS_INT; instead,
2561 report a string overflow if no precision given. When checking for
2562 precision exhaustion, use a check that cannot possibly have
2563 integer overflow. (Bug#8675)
2564 * character.h (lisp_string_width): Adjust to new signature.
2565
2566 * alloc.c (string_overflow): New function.
2567 (Fmake_string): Use it. This doesn't change behavior, but saves
2568 a few bytes and will simplify future changes.
2569 * character.c (string_escape_byte8): Likewise.
2570 * lisp.h (string_overflow): New decl.
2571
2572 Fixups, following up to the user-interface timestamp change.
2573 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2574 for UI timestamps, instead of unsigned long.
2575 * msdos.c (mouse_get_pos): Likewise.
2576 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2577 * w32gui.h (Time): Define by including "systime.h" rather than by
2578 declaring it ourselves. (Bug#8664)
2579
2580 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2581 * image.c (clear_image_cache): Likewise.
2582
2583 * term.c (term_mouse_position): Don't assume time_t wraparound.
2584
2585 Be more systematic about user-interface timestamps.
2586 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2587 and sometimes 'EMACS_UINT', to represent these timestamps.
2588 This change causes it to use 'Time' uniformly, as that's what X uses.
2589 This makes the code easier to follow, and makes it easier to catch
2590 integer overflow bugs such as Bug#8664.
2591 * frame.c (Fmouse_position, Fmouse_pixel_position):
2592 Use Time, not unsigned long, for user-interface timestamps.
2593 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2594 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2595 * keyboard.h (last_event_timestamp): Likewise.
2596 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2597 * menu.h (xmenu_show): Likewise.
2598 * term.c (term_mouse_position): Likewise.
2599 * termhooks.h (struct input_event.timestamp): Likewise.
2600 (struct terminal.mouse_position_hook): Likewise.
2601 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2602 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2603 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2604 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2605 what it was before.
2606 * menu.h, termhooks.h: Include "systime.h", for Time.
2607
2608 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2609 Don't assume that the difference between two unsigned long values
2610 can fit into an integer. At this point, we know button_down_time
2611 <= event->timestamp, so the difference must be nonnegative, so
2612 there's no need to cast the result if double-click-time is
2613 nonnegative, as it should be; check that it's nonnegative, just in
2614 case. This bug is triggered when events are more than 2**31 ms
2615 apart (about 25 days). (Bug#8664)
2616
2617 * xselect.c (last_event_timestamp): Remove duplicate decl.
2618 (x_own_selection): Remove needless cast to unsigned long.
2619
2620 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2621 that always fit in int. Use a sentinel instead of a counter, to
2622 avoid a temp and to allay GCC's concerns about possible int overflow.
2623 * frame.h (struct frame): Use int for menu_bar_items_used
2624 instead of EMACS_INT, since it always fits in int.
2625
2626 * menu.c (grow_menu_items): Check for int overflow.
2627
2628 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2629
2630 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2631 Before, the code was not consistent. These values cannot exceed
2632 2**31 - 1 so there's no need to make them unsigned.
2633 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2634 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2635 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2636 as modifiers.
2637 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2638
2639 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2640 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2641 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2642 presumably because the widths might not match.
2643
2644 * window.c (size_window): Avoid needless test at loop start.
2645
2646 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2647
2648 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2649
2650 2011-05-12 Drew Adams <drew.adams@oracle.com>
2651
2652 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2653
2654 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2655
2656 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2657 `width' to `bar_area_x' and `bar_area_width', respectively.
2658 (x_scroll_run): Take account of fringe background extension.
2659
2660 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2661 Rename local vars `left' and `width' to `bar_area_x' and
2662 `bar_area_width', respectively.
2663 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2664 background extension.
2665
2666 2011-05-10 Jim Meyering <meyering@redhat.com>
2667
2668 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2669
2670 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2671
2672 * image.c (Finit_image_library): Return t for built-in image types,
2673 like pbm and xbm. (Bug#8640)
2674
2675 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2676
2677 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2678
2679 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2680
2681 * w32console.c (Fset_screen_color): Doc fix.
2682 (Fget_screen_color): New function.
2683 (syms_of_ntterm): Defsubr it.
2684
2685 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2686 unlink the temporary file if Fcall_process didn't create it in the
2687 first place.
2688 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2689 child process will be redirected to a file specified with `:file'.
2690 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2691 cue to call_process_cleanup not to close that handle.
2692
2693 2011-05-07 Ben Key <bkey76@gmail.com>
2694
2695 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2696 one of two shell specific rules, either bootstrap-temacs-CMD or
2697 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2698 to the previous implementation of the bootstrap-temacs rule.
2699 The bootstrap-temacs-CMD rule is similar to the previous
2700 implementation of the bootstrap-temacs rule except that it
2701 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2702 variable.
2703
2704 These changes, along with some changes to nt/configure.bat,
2705 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2706 earlier fix to add support for --cflags and --ldflags options
2707 that include quotes so that it works whether make uses cmd or
2708 sh as the shell.
2709
2710 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2711
2712 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2713 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2714 is a constant.
2715 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2716 a string. Handle both cases.
2717 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2718 (Fdbus_register_method): Use Qinvalid_function.
2719
2720 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2721
2722 * makefile.w32-in: Update dependencies.
2723 (LISP_H): Add inttypes.h and stdin.h.
2724 (PROCESS_H): Add unistd.h.
2725
2726 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2727
2728 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2729 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2730
2731 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2732
2733 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2734
2735 * term.c (vfatal): Remove stray call to va_end.
2736 It's not needed and the C Standard doesn't allow it here anyway.
2737
2738 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2739 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2740
2741 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2742 bytes.
2743
2744 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2745
2746 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2747
2748 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2749
2750 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2751
2752 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2753
2754 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2755 * charset.c (Fdefine_charset_internal): Don't initialize
2756 charset.code_space[15]. The value was garbage, on hosts with
2757 32-bit int (Bug#8600).
2758
2759 * lread.c (read_integer): Be more consistent with string-to-number.
2760 Use string_to_number to do the actual conversion; this avoids
2761 rounding errors and fixes some other screwups. Without this fix,
2762 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2763 (digit_to_number): Move earlier, for benefit of read_integer.
2764 Return -1 if the digit is out of range for the base, -2 if it is
2765 not a digit in any supported base. (Bug#8602)
2766
2767 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2768
2769 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2770 to match comment at start of function. This also removes a
2771 GCC warning about overflow in a 32+64-bit port.
2772
2773 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2774
2775 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2776 Reported by Stefan Monnier in
2777 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2778 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2779 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2780
2781 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2782 (EMACS_UINTPTR): Likewise, with uintptr_t.
2783
2784 * lisp.h: Prefer 64-bit EMACS_INT if available.
2785 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2786 on 32-bit hosts that have 64-bit int, so that they can access
2787 large files.
2788 However, temporarily disable this change unless the temporary
2789 symbol WIDE_EMACS_INT is defined.
2790
2791 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2792
2793 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2794 This removes an assumption that EMACS_INT and long are the same
2795 width as pointers. The assumption is true for Emacs porting targets
2796 now, but we want to make other targets possible.
2797 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2798 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2799 In the rest of the code, change types of integers that hold casted
2800 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2801 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2802 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2803 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2804 No need to cast type when ORing.
2805 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2806 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2807 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2808 assume EMACS_INT is the same width as char *.
2809 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2810 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2811 Remove no-longer-needed casts.
2812 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2813 (xg_tool_bar_help_callback, xg_make_tool_item):
2814 Use EMACS_INTPTR to hold an integer
2815 that will be cast to void *; this can avoid a GCC warning
2816 if EMACS_INT is not the same width as void *.
2817 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2818 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2819 (current_message_1, set_message_1):
2820 Use a local to convert to proper width without a cast.
2821 * xmenu.c (dialog_selection_callback): Likewise.
2822
2823 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2824 Also, don't assume VALBITS / RAND_BITS is less than 5,
2825 and don't rely on undefined behavior when shifting a 1 left into
2826 the sign bit.
2827 * lisp.h (get_random): Change signature to match.
2828
2829 * lread.c (hash_string): Use size_t, not int, for hash computation.
2830 Normally we prefer signed values; but hashing is special, because
2831 it's better to use unsigned division on hash table sizes so that
2832 the remainder is nonnegative. Also, size_t is the natural width
2833 for hashing into memory. The previous code used 'int', which doesn't
2834 retain enough info to hash well into very large tables.
2835 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2836
2837 * dbusbind.c: Don't possibly lose pointer info when converting.
2838 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2839 Use XPNTR rather than XHASH, so that the high-order bits of
2840 the pointer aren't lost when converting through void *.
2841
2842 * eval.c (Fautoload): Don't double-shift a pointer.
2843
2844 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2845
2846 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2847
2848 * gnutls.c (DEF_GNUTLS_FN):
2849 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2850
2851 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2852
2853 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2854 marker. (Bug#8610)
2855
2856 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2857
2858 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2859 New version that can reserve upto 2GB of heap space.
2860
2861 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2862
2863 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2864
2865 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2866
2867 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2868 `gnutls_certificate_set_x509_key_file'.
2869
2870 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2871
2872 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2873 Update dependencies.
2874
2875 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2876
2877 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2878 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2879 Remove unused parameter `fildes'.
2880 * process.c (read_process_output, send_process): Don't pass it.
2881
2882 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2883
2884 Fix previous change: the library cache is defined in w32.c.
2885 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2886 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2887
2888 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2889
2890 Implement dynamic loading of GnuTLS on Windows.
2891
2892 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2893 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2894 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2895 Declare.
2896
2897 * gnutls.c (Qgnutls_dll): Define.
2898 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2899 (gnutls_*): Declare function pointers.
2900 (init_gnutls_functions): New function to initialize function pointers.
2901 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2902 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2903 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2904 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2905 (emacs_gnutls_write, emacs_gnutls_read)
2906 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2907 (Fgnutls_available_p): New function.
2908 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2909 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2910 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2911
2912 * image.c: Include w32.h.
2913 (Vimage_type_cache): Delete.
2914 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2915 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2916 (w32_delayed_load): Move to w32.c.
2917
2918 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2919
2920 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2921 (w32_delayed_load): Move from image.c. When loading a library, record
2922 its filename in the :loaded-from property of the library id.
2923 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2924 Initialize and staticpro them.
2925 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2926
2927 * process.c: Include lisp.h before w32.h, not after.
2928 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2929 instead of gnutls_record_check_pending.
2930
2931 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2932
2933 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2934
2935 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2936 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2937 as passed in.
2938
2939 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2940
2941 * xterm.c (x_set_frame_alpha): Do not set property on anything
2942 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2943
2944 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2945
2946 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2947
2948 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2949
2950 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2951 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2952 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2953 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2954 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2955 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2956 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2957 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2958 (Qgnutls_bootprop_callbacks_verify): Make static.
2959
2960 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2961
2962 * callproc.c: Indentation fixup.
2963
2964 * sysdep.c (wait_for_termination_1): Make static.
2965 (wait_for_termination, interruptible_wait_for_termination):
2966 Move after wait_for_termination_1.
2967
2968 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2969
2970 * sysdep.c (interruptible_wait_for_termination): New function
2971 which is like wait_for_termination, but allows keyboard
2972 interruptions.
2973
2974 * callproc.c (Fcall_process): Add (:file "file") as an option for
2975 the STDOUT buffer.
2976 (Fcall_process_region): Ditto.
2977
2978 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2979
2980 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2981 rather than `XVECTOR (FOO)->size'.
2982
2983 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2984 inttypes.h, as a gnulib replacement is used if it not available in
2985 system headers.
2986
2987 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2988
2989 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2990 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2991 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2992
2993 * coding.c (coding_alloc_by_realloc): Error out if destination
2994 will grow beyond MOST_POSITIVE_FIXNUM.
2995 (decode_coding_emacs_mule): Abort if there isn't enough place in
2996 charbuf for the composition carryover bytes. Reserve an extra
2997 space for up to 2 characters produced in a loop.
2998 (decode_coding_iso_2022): Abort if there isn't enough place in
2999 charbuf for the composition carryover bytes.
3000
3001 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3002
3003 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3004 aborting when %lld or %lll format is passed.
3005 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3006 %llo or %llx format is passed. (Bug#8545)
3007
3008 * window.c (window_scroll_line_based): Use a marker instead of
3009 simple variables to record original value of point. (Bug#7952)
3010
3011 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3012 produced by %s or %c overflows available buffer space. (Bug#8545)
3013
3014 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3015
3016 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3017 (SIZE_MAX): Move defn after all includes, as they might #define it.
3018
3019 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3020
3021 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3022
3023 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3024
3025 * keyboard.c (Qdelayed_warnings_hook): Define.
3026 (command_loop_1): Run `delayed-warnings-hook'
3027 if Vdelayed_warnings_list is non-nil.
3028 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3029 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3030
3031 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3032
3033 * doprnt.c (doprnt): Don't return value smaller than the buffer
3034 size if the message was truncated. (Bug#8545).
3035
3036 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3037
3038 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3039 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3040
3041 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3042
3043 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3044
3045 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3046
3047 * makefile.w32-in: Update dependencies.
3048
3049 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3050
3051 Improve `doprnt' and its usage. (Bug#8545)
3052 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3053 `format_end'. Remove support for %l as a conversion specifier.
3054 Don't use xrealloc. Improve diagnostics when the %l size modifier
3055 is used. Update the commentary.
3056
3057 * eval.c (verror): Simplify calculation of size_t.
3058
3059 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3060 messages.
3061
3062 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3063
3064 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3065 change.
3066
3067 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3068
3069 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3070 This makes this file independent of the recent pseudovector change.
3071
3072 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3073
3074 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3075
3076 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3077 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3078 Remove unused local.
3079 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3080
3081 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3082 GCC 4.6.0 optimizes based on type-based alias analysis.
3083 For example, if b is of type struct buffer * and v of type struct
3084 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3085 != &v->size, and therefore "v->size = 1; b->size = 2; return
3086 v->size;" must therefore return 1. This assumption is incorrect
3087 for Emacs, since it type-puns struct Lisp_Vector * with many other
3088 types. To fix this problem, this patch adds a new type struct
3089 vectorlike_header that documents the constraints on layout of vectors
3090 and pseudovectors, and helps optimizing compilers not get fooled
3091 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3092 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3093 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3094 the size member.
3095 (XSETPVECTYPE): Rewrite in terms of new macro.
3096 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3097 This is a bit clearer, and further avoids the possibility of
3098 undesirable aliasing.
3099 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3100 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3101 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3102 since Lisp_Subr is a special case (no "next" field).
3103 (ASIZE): Now uses header.size rather than size.
3104 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3105 to avoid the hassle of writing XVECTOR (foo)->header.size.
3106 (struct vectorlike_header): New type.
3107 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3108 object, to help avoid aliasing.
3109 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3110 (SUBRP): Likewise, since Lisp_Subr is a special case.
3111 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3112 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3113 (struct Lisp_Hash_Table): Combine first two members into a single
3114 struct vectorlike_header member. All uses of "size" and "next" members
3115 changed to be "header.size" and "header.next".
3116 * buffer.h (struct buffer): Likewise.
3117 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3118 * frame.h (struct frame): Likewise.
3119 * process.h (struct Lisp_Process): Likewise.
3120 * termhooks.h (struct terminal): Likewise.
3121 * window.c (struct save_window_data, struct saved_window): Likewise.
3122 * window.h (struct window): Likewise.
3123 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3124 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3125 * buffer.c (init_buffer_once): Likewise.
3126 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3127 special case.
3128 * process.c (Fformat_network_address): Use local var for size,
3129 for brevity.
3130
3131 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3132
3133 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3134 * data.c (atof): Remove decl; no longer used or needed.
3135 (digit_to_number): Move to lread.c.
3136 (Fstring_to_number): Use new string_to_number function, to be
3137 consistent with how the Lisp reader treats infinities and NaNs.
3138 Do not assume that floating-point numbers represent EMACS_INT
3139 without losing information; this is not true on most 64-bit hosts.
3140 Avoid double-rounding errors, by insisting on integers when
3141 parsing non-base-10 numbers, as the documentation specifies.
3142 * lisp.h (string_to_number): New decl, replacing ...
3143 (isfloat_string): Remove.
3144 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3145 (read1): Do not accept +. and -. as integers; this
3146 appears to have been a coding error. Similarly, do not accept
3147 strings like +-1e0 as floating point numbers. Do not report
3148 overflow for integer overflows unless the base is not 10 which
3149 means we have no simple and reliable way to continue.
3150 Break out the floating-point parsing into a new
3151 function string_to_number, so that Fstring_to_number parses
3152 floating point numbers consistently with the Lisp reader.
3153 (digit_to_number): Move here from data.c. Make it static inline.
3154 (E_CHAR, EXP_INT): Remove, replacing with ...
3155 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3156 (string_to_number): New function, replacing isfloat_string.
3157 This function checks for valid syntax and produces the resulting
3158 Lisp float number too. Rework it so that string-to-number
3159 no longer mishandles examples like "1.0e+". Use strtoumax,
3160 so that overflow for non-base-10 numbers is reported only when
3161 there's no portable and simple way to convert to floating point.
3162
3163 * textprop.c (set_text_properties_1): Rewrite for clarity,
3164 and to avoid GCC warning about integer overflow.
3165
3166 * intervals.h (struct interval): Use EMACS_INT for members
3167 where EMACS_UINT might cause problems. See
3168 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3169 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3170 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3171 All uses changed.
3172 (offset_intervals): Tell GCC not to worry about length overflow
3173 when negating a negative length.
3174
3175 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3176 (overrun_check_free): Likewise.
3177
3178 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3179 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3180 word size.
3181
3182 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3183 (gnutls_make_error): Rename local to avoid shadowing.
3184 (gnutls_emacs_global_deinit): ifdef out; not used.
3185 (Fgnutls_boot): Use const for pointer to readonly storage.
3186 Comment out unused local. Fix pointer signedness problems.
3187
3188 * lread.c (openp): Don't stuff size_t into an 'int'.
3189 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3190 about possible signed overflow.
3191
3192 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3193 (GDK_KEY_g): Don't define if already defined.
3194 (xg_prepare_tooltip): Avoid pointer signedness problem.
3195 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3196
3197 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3198 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3199
3200 * xfns.c (Fx_window_property): Simplify a bit,
3201 to make a bit faster and to avoid GCC 4.6.0 warning.
3202 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3203
3204 * fns.c (internal_equal): Don't assume size_t fits in int.
3205
3206 * alloc.c (compact_small_strings): Tighten assertion a little.
3207
3208 Replace pEd with more-general pI, and fix some printf arg casts.
3209 * lisp.h (pI): New macro, generalizing old pEd macro to other
3210 conversion specifiers. For example, use "...%"pI"d..." rather
3211 than "...%"pEd"...".
3212 (pEd): Remove. All uses replaced with similar uses of pI.
3213 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3214 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3215 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3216 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3217 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3218 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3219 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3220 64-bit hosts.
3221 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3222 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3223 * print.c (safe_debug_print, print_object): Likewise.
3224 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3225 to int.
3226 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3227 avoiding the 0 flag, which is not portable.
3228 * process.c (Fmake_network_process): Use pI to avoid cast.
3229 * region-cache.c (pp_cache): Likewise.
3230 * xdisp.c (decode_mode_spec): Likewise.
3231 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3232 behavior on 64-bit hosts with printf arg.
3233 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3234 (x_stop_queuing_selection_requests): Likewise.
3235 (x_get_window_property): Don't truncate byte count to an 'int'
3236 when tracing.
3237
3238 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3239 here, since it parses constructs like leading '-' and spaces,
3240 which are not wanted; and it overflows with large numbers.
3241 Instead, simply match F[0-9]+, which is what is wanted anyway.
3242
3243 * alloc.c: Remove unportable assumptions about struct layout.
3244 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3245 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3246 (allocate_vectorlike, make_pure_vector): Use the new macros,
3247 plus offsetof, to remove unportable assumptions about struct layout.
3248 These assumptions hold on all porting targets that I know of, but
3249 they are not guaranteed, they're easy to remove, and removing them
3250 makes further changes easier.
3251
3252 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3253 This doesn't fix a bug but makes the code clearer.
3254 (string_overrun_cookie): Now const. Use initializers that
3255 don't formally overflow signed char, to avoid warnings.
3256 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3257 can cause Emacs to crash when string overrun checking is enabled.
3258 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3259 multiple of sizeof (EMACS_INT); it need not be, if
3260 alignof(EMACS_INT) < sizeof (EMACS_INT).
3261 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3262
3263 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3264
3265 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3266
3267 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3268
3269 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3270 supposed to be handshaking. (Bug#8556)
3271 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3272
3273 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3274
3275 * lisp.h (Qdebug): List symbol.
3276 * eval.c (Qdebug): Restore global linkage.
3277 * keyboard.c (debug-on-event): New variable.
3278 (handle_user_signal): Break into debugger when debug-on-event
3279 matches the current signal symbol.
3280
3281 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3282
3283 * alloc.c (check_sblock, check_string_bytes)
3284 (check_string_free_list): Convert to standard C.
3285
3286 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3287
3288 * w32.c (emacs_gnutls_push): Fix typo.
3289
3290 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3291
3292 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3293 "cast to pointer from integer of different size".
3294
3295 Improve doprnt and its use in verror. (Bug#8545)
3296 * doprnt.c (doprnt): Document the set of format control sequences
3297 supported by the function. Use SAFE_ALLOCA instead of always
3298 using `alloca'.
3299
3300 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3301 is one byte too soon. Don't use xrealloc; instead xfree and
3302 xmalloc anew.
3303
3304 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3305
3306 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3307 callbacks stage.
3308
3309 * gnutls.c: Renamed global_initialized to
3310 gnutls_global_initialized. Added internals for the
3311 :verify-hostname-error, :verify-error, and :verify-flags
3312 parameters of `gnutls-boot' and documented those parameters in the
3313 docstring. Start callback support.
3314 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3315 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3316 on error. Return error code.
3317 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3318 (emacs_gnutls_read): Likewise.
3319 (Fgnutls_boot): Return handshake error code.
3320 (emacs_gnutls_handle_error): New function.
3321 (wsaerror_to_errno): Likewise.
3322
3323 * w32.h (emacs_gnutls_pull): Add prototype.
3324 (emacs_gnutls_push): Likewise.
3325
3326 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3327 (emacs_gnutls_push): Likewise.
3328
3329 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3330
3331 * process.c (wait_reading_process_output): Check if GnuTLS
3332 buffered some data internally if no FDs are set for TLS
3333 connections.
3334
3335 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3336 (LIBS): Link to USER_LIBS.
3337 ($(BLD)/gnutls.$(0)): New target.
3338
3339 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3340
3341 * xdisp.c (handle_single_display_spec): Rename the
3342 display_replaced_before_p argument into display_replaced_p, to
3343 make it consistent with the commentary. Fix typos in the
3344 commentary.
3345
3346 * textprop.c (syms_of_textprop): Remove dead code.
3347 (copy_text_properties): Delete obsolete commentary about an
3348 interface that was deleted long ago. Fix typos in the description
3349 of arguments.
3350
3351 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3352 to changes in oldXMenu/XMenu.h from 2011-04-16.
3353 <menu_help_message, prev_menu_help_message>: Constify.
3354 (IT_menu_make_room): menu->help_text is now `const char **';
3355 adjust.
3356
3357 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3358 to changes in oldXMenu/XMenu.h from 2011-04-16.
3359 (struct XMenu): Declare `help_text' `const char **'.
3360
3361 * xfaces.c <Qunspecified>: Make extern again.
3362
3363 * syntax.c: Include sys/types.h before including regex.h, as
3364 required by Posix.
3365
3366 * doc.c (get_doc_string): Improve the format passed to `error'.
3367
3368 * doprnt.c (doprnt): Improve commentary.
3369
3370 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3371
3372 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3373 them with etags.
3374
3375 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3376 changes in globals.h immediately force recompilation.
3377 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3378 $(CURDIR)/s/ms-w32.h.
3379 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3380
3381 * character.c (Fchar_direction): Function deleted.
3382 (syms_of_character): Don't defsubr it.
3383 <char-direction-table>: Deleted.
3384
3385 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3386
3387 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3388 * doprnt.c: Include limits.h.
3389 (SIZE_MAX): New macro.
3390 (doprnt): Return a size_t value. 2nd arg is now size_t.
3391 Many local variables are now size_t instead of int or unsigned.
3392 Improve overflow protection. Support `l' modifier for integer
3393 conversions. Support %l conversion. Don't assume an EMACS_INT
3394 argument for integer conversions and for %c.
3395
3396 * lisp.h (doprnt): Restore prototype.
3397
3398 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3399 $(SRC)/character.h.
3400
3401 * Makefile.in (base_obj): Add back doprnt.o.
3402
3403 * deps.mk (doprnt.o): Add back prerequisites.
3404 (callint.o): Depend on character.h.
3405
3406 * eval.c (internal_lisp_condition_case): Include the handler
3407 representation in the error message.
3408 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3409 when breaking from the loop.
3410
3411 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3412
3413 * callint.c (Fcall_interactively): When displaying error message
3414 about invalid control letter, pass the character's codepoint, not
3415 a pointer to its multibyte form. Improve display of the character
3416 in octal and display also its hex code.
3417
3418 * character.c (char_string): Use %x to display the (unsigned)
3419 codepoint of an invalid character, to avoid displaying a bogus
3420 negative value.
3421
3422 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3423 `error', not SYMBOL_NAME itself.
3424
3425 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3426 character arguments to `error'.
3427
3428 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3429 to `error' in error message about FINAL_CHAR argument. Make sure
3430 FINAL_CHAR is a character, and use %c when it is passed as
3431 argument to `error'.
3432
3433 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3434
3435 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3436
3437 * w32.c: Include <time.h>.
3438 (sys_localtime): New function.
3439
3440 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3441
3442 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3443
3444 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3445
3446 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3447
3448 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3449 zombies (Bug#8467).
3450
3451 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3452
3453 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3454 gl_state.e_property when gl_state.object is Qt.
3455
3456 * insdel.c (make_gap_larger): Remove limitation of buffer size
3457 to <= INT_MAX.
3458
3459 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3460
3461 * xdisp.c (lookup_glyphless_char_display)
3462 (produce_glyphless_glyph): Handle cons cell entry in
3463 glyphless-char-display.
3464 (Vglyphless_char_display): Document it.
3465
3466 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3467 glyphless-char-display.
3468
3469 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3470
3471 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3472
3473 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3474
3475 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3476 definition for no-X builds.
3477
3478 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3479
3480 Static checks with GCC 4.6.0 and non-default toolkits.
3481
3482 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3483
3484 * process.c (keyboard_bit_set): Define only if SIGIO.
3485 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3486 (send_process): Repair possible setjmp clobbering.
3487
3488 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3489
3490 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3491
3492 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3493
3494 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3495 Define only if needed.
3496
3497 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3498 by pacifying GCC about it. Maybe it's time to retire it?
3499 * xfaces.c (USG, __TIMEVAL__): Likewise.
3500
3501 * dispextern.h (struct redisplay_interface): Rename param
3502 to avoid shadowing.
3503 * termhooks.h (struct terminal): Likewise.
3504 * xterm.c (xembed_send_message): Likewise.
3505
3506 * insdel.c (make_gap_smaller): Define only if
3507 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3508
3509 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3510 it.
3511
3512 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3513 so that we aren't warned about unused symbols.
3514
3515 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3516
3517 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3518
3519 * xfns.c (x_real_positions): Mark locals as initialized.
3520
3521 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3522
3523 * xterm.c: Fix problems found by static analysis with other toolkits.
3524 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3525 (x_dispatch_event): Declare static if USE_GTK, and
3526 define if USE_GTK || USE_X_TOOLKIT.
3527 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3528 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3529 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3530 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3531
3532 * xmenu.c (menu_help_callback): Pointer type fixes.
3533 Use const pointers when pointing at readonly data. Avoid pointer
3534 signedness clashes.
3535 (FALSE): Remove unused macro.
3536 (update_frame_menubar): Remove unused decl.
3537
3538 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3539
3540 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3541 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3542 (single_menu_item): Rename local to avoid shadowing.
3543
3544 * keyboard.c (make_lispy_event): Remove unused local var.
3545
3546 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3547 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3548
3549 * bitmaps: Change bitmaps from unsigned char back to the X11
3550 compatible char. Avoid the old compiler warnings about
3551 out-of-range initializers by using, for example, '\xab' rather
3552 than 0xab.
3553
3554 * xgselect.c (xgselect_initialize): Check vs interface
3555 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3556
3557 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3558
3559 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3560 to read-only memory.
3561
3562 * fns.c (vector): Remove; this old hack is no longer needed.
3563
3564 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3565 Remove unused var.
3566 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3567
3568 * xrdb.c (x_load_resources): Omit unused local.
3569
3570 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3571 (x_window): Rename locals to avoid shadowing.
3572 (USG): Use the kludged USG macro, to pacify gcc.
3573
3574 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3575 (x_term_init): Remove local to avoid shadowing.
3576
3577 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3578
3579 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3580 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3581
3582 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3583
3584 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3585
3586 Fix regex.c, syntax.c and friends for buffers > 2GB.
3587 * syntax.h (struct gl_state_s): Declare character position members
3588 EMACS_INT.
3589
3590 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3591
3592 * textprop.c (verify_interval_modification, interval_of):
3593 Declare arguments EMACS_INT.
3594
3595 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3596 EMACS_INT.
3597
3598 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3599
3600 * indent.c (Fvertical_motion): Local variable it_start is now
3601 EMACS_INT.
3602
3603 * regex.c (re_match, re_match_2, re_match_2_internal)
3604 (bcmp_translate, regcomp, regexec, print_double_string)
3605 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3606 (re_compile_pattern, re_exec): Declare arguments and local
3607 variables `size_t' and `ssize_t' and return values `regoff_t', as
3608 appropriate.
3609 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3610 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3611 <compile_stack_type>: `size' and `avail' are now `size_t'.
3612
3613 * regex.h <regoff_t>: Use ssize_t, not int.
3614 (re_search, re_search_2, re_match, re_match_2): Arguments that
3615 specify buffer/string position and length are now ssize_t and
3616 size_t. Return type is regoff_t.
3617
3618 2011-04-16 Ben Key <bkey76@gmail.com>
3619
3620 * nsfont.m: Fixed bugs in ns_get_family and
3621 ns_descriptor_to_entity that were caused by using free to
3622 deallocate memory blocks that were allocated by xmalloc (via
3623 xstrdup). This caused Emacs to crash when compiled with
3624 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3625 --enable-checking=xmallocoverrun). xfree is now used to
3626 deallocate these memory blocks.
3627
3628 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3631
3632 emacs_write: Accept and return EMACS_INT for sizes.
3633 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3634 et seq.
3635 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3636 Accept and return EMACS_INT.
3637 (emacs_gnutls_write): Return the number of bytes written on
3638 partial writes.
3639 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3640 (emacs_read, emacs_write): Remove check for negative size, as the
3641 Emacs source code has been audited now.
3642 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3643 (emacs_read, emacs_write): Use it.
3644 * process.c (send_process): Adjust to the new signatures of
3645 emacs_write and emacs_gnutls_write. Do not attempt to store
3646 a byte offset into an 'int'; it might overflow.
3647 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3648
3649 * sound.c: Don't assume sizes fit in 'int'.
3650 (struct sound_device.period_size, alsa_period_size):
3651 Return EMACS_INT, not int.
3652 (struct sound_device.write, vox_write, alsa_write):
3653 Accept EMACS_INT, not int.
3654 (wav_play, au_play): Use EMACS_INT to store sizes and to
3655 record read return values.
3656
3657 2011-04-15 Ben Key <bkey76@gmail.com>
3658
3659 * keyboard.c (Qundefined): Don't declare static since it is used
3660 in nsfns.m.
3661 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3662 static since they are used in nsfont.m.
3663
3664 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3665
3666 * process.c (Qprocessp): Don't declare static.
3667 * lisp.h (Qprocessp): Declare again.
3668
3669 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3670
3671 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3672
3673 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3674
3675 Improve C-level modularity by making more things 'static'.
3676
3677 Don't publish debugger-only interfaces to other modules.
3678 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3679 (verify_bytepos, count_markers): Move decls to the only modules
3680 that need them.
3681 * region-cache.h (pp_cache): Likewise.
3682 * window.h (check_all_windows): Likewise.
3683 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3684
3685 * sysdep.c (croak): Now static, if
3686 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3687 * syssignal.h (croak): Declare only if not static.
3688
3689 * alloc.c (refill_memory_reserve): Now static if
3690 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3691 * lisp.h (refill_memory_reserve): Declare only if not static.
3692
3693 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3694 Define only if USE_LUCID.
3695
3696 * xrdb.c (x_customization_string, x_rm_string): Now static.
3697
3698 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3699 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3700
3701 * xdisp.c (draw_row_with_mouse_face): Now static.
3702 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3703
3704 * window.h (check_all_windows): Mark externally visible.
3705
3706 * window.c (window_deletion_count): Now static.
3707
3708 * undo.c: Make symbols static if they're not exported.
3709 (last_undo_buffer, last_boundary_position, pending_boundary):
3710 Now static.
3711
3712 * textprop.c (interval_insert_behind_hooks): Now static.
3713 (interval_insert_in_front_hooks): Likewise.
3714
3715 * term.c: Make symbols static if they're not exported.
3716 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3717 (max_frame_lines, tty_set_terminal_modes):
3718 (tty_reset_terminal_modes, tty_turn_off_highlight):
3719 (get_tty_terminal): Now static.
3720 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3721 * termhooks.h (term_mouse_moveto): Do not declare if
3722 HAVE_WINDOW_SYSTEM.
3723 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3724 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3725
3726 * sysdep.c: Make symbols static if they're not exported.
3727 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3728 Now static.
3729 (sigprocmask_set, full_mask): Remove; unused.
3730 (wait_debugging): Mark as visible.
3731 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3732 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3733
3734 * syntax.c (syntax_temp): Define only if !__GNUC__.
3735
3736 * sound.c (current_sound_device, current_sound): Now static.
3737
3738 * search.c (searchbufs, searchbuf_head): Now static.
3739
3740 * scroll.c (scroll_cost): Remove; unused.
3741 * dispextern.h (scroll_cost): Remove decl.
3742
3743 * region-cache.h (pp_cache): Mark as externally visible.
3744
3745 * process.c: Make symbols static if they're not exported.
3746 (process_tick, update_tick, create_process, chan_process):
3747 (Vprocess_alist, proc_buffered_char, datagram_access):
3748 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3749 (deactivate_process): Mark defn as static, as well as decl.
3750 * lisp.h (create_process): Remove decl.
3751 * process.h (chan_process, Vprocess_alist): Remove decls.
3752
3753 * print.c: Make symbols static if they're not exported.
3754 (print_depth, new_backquote_output, being_printed, print_buffer):
3755 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3756 (print_interval, print_number_index, initial_stderr_stream):
3757 Now static.
3758 * lisp.h (Fprinc): Remove decl.
3759 (debug_output_compilation_hack): Mark as externally visible.
3760
3761 * sysdep.c (croak): Move decl from here to syssignal.h.
3762 * syssignal.h (croak): Put it here, so the API can be checked when
3763 'croak' is called from dissociate_if_controlling_tty.
3764
3765 * minibuf.c: Make symbols static if they're not exported.
3766 (minibuf_save_list, choose_minibuf_frame): Now static.
3767 * lisp.h (choose_minibuf_frame): Remove decl.
3768
3769 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3770
3771 * lread.c: Make symbols static if they're not exported.
3772 (read_objects, initial_obarray, oblookup_last_bucket_number):
3773 Now static.
3774 (make_symbol): Remove; unused.
3775 * lisp.h (initial_obarray, make_symbol): Remove decls.
3776
3777 * keyboard.c: Make symbols static if they're not exported.
3778 (single_kboard, recent_keys_index, total_keys, recent_keys):
3779 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3780 (this_single_command_key_start, echoing, last_auto_save):
3781 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3782 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3783 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3784 (Vlispy_mouse_stem, double_click_count):
3785 Now static.
3786 (force_auto_save_soon): Define only if SIGDANGER.
3787 (ignore_mouse_drag_p): Now static if
3788 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3789 (print_help): Remove; unused.
3790 (stop_character, last_timer_event): Mark as externally visible.
3791 * keyboard.h (ignore_mouse_drag_p): Declare only if
3792 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3793 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3794 * lisp.h (echoing): Remove decl.
3795 (force_auto_save_soon): Declare only if SIGDANGER.
3796 * xdisp.c (redisplay_window): Simplify code, to make it more
3797 obvious that ignore_mouse_drag_p is not accessed if !defined
3798 USE_GTK && !defined HAVE_NS.
3799
3800 * intervals.c: Make symbols static if they're not exported.
3801 (merge_properties_sticky, merge_interval_right, delete_interval):
3802 Now static.
3803 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3804
3805 * insdel.c: Make symbols static if they're not exported.
3806 However, leave prepare_to_modify_buffer alone. It's never
3807 called from outside this function, but that appears to be a bug.
3808 (combine_after_change_list, combine_after_change_buffer):
3809 (adjust_after_replace, signal_before_change): Now static.
3810 (adjust_after_replace_noundo): Remove; unused.
3811 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3812 (signal_before_change): Remove decls.
3813
3814 * indent.c (val_compute_motion, val_vmotion): Now static.
3815
3816 * image.c: Make symbols static if they're not exported.
3817 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3818 if USE_GTK.
3819 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3820 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3821
3822 * fringe.c (standard_bitmaps): Now static.
3823 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3824
3825 * frame.c: Make symbols static if they're not exported.
3826 (x_report_frame_params, make_terminal_frame): Now static.
3827 (get_frame_param): Now static, unless HAVE_NS.
3828 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3829 (x_get_resource_string): Remove; not used.
3830 * frame.h (make_terminal_frame, x_report_frame_params):
3831 (x_get_resource_string); Remove decls.
3832 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3833 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3834
3835 * font.c, fontset.c: Make symbols static if they're not exported.
3836 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3837 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3838 * font.c (font_close_object): Now static.
3839 * font.h (font_close_object): Remove.
3840 * fontset.c (FONTSET_OBJLIST): Remove.
3841 (free_realized_fontset) #if-0 the body, which does nothing.
3842 (face_suitable_for_char_p): #if-0, as it's never called.
3843 * fontset.h (face_suitable_for_char_p): Remove decl.
3844 * xfaces.c (face_at_string_position):
3845 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3846 since 0 is always ASCII.
3847
3848 * fns.c (weak_hash_tables): Now static.
3849
3850 * fileio.c: Make symbols static if they're not exported.
3851 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3852 (Vwrite_region_annotation_buffers): Now static.
3853
3854 * eval.c: Make symbols static if they're not exported.
3855 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3856 * lisp.h (backtrace_list): Remove decl.
3857
3858 * emacs.c: Make symbols static if they're not exported.
3859 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3860 (fatal_error_code, fatal_error_signal_hook, standard_args):
3861 Now static.
3862 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3863 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3864 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3865 * lisp.h (fatal_error_signal_hook): Remove decl.
3866 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3867
3868 * editfns.c: Move a (normally-unused) function to its only use.
3869 * editfns.c, lisp.h (get_operating_system_release): Remove.
3870 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3871 worth the hassle of breaking this out.
3872
3873 * xterm.c: Make symbols static if they're not exported.
3874 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3875 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3876 (x_destroy_window, x_delete_display):
3877 Now static.
3878 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3879 (x_mouse_leave): Remove; unused.
3880 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3881 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3882 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3883 Remove decls.
3884 (x_mouse_leave): Declare only if WINDOWSNT.
3885 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3886 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3887 USE_X_TOOLKIT.
3888
3889 * ftxfont.c: Make symbols static if they're not exported.
3890 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3891 HAVE_FREETYPE.
3892 * font.h (ftxfont_driver): Likewise.
3893
3894 * xfns.c: Make symbols static if they're not exported.
3895 (x_last_font_name, x_display_info_for_name):
3896 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3897 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3898 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3899 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3900 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3901 (last_show_tip_args): Now static.
3902 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3903 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3904 (x_screen_planes): Remove; unused.
3905 * dispextern.h (x_screen_planes): Remove decl.
3906
3907 * dispnew.c: Make symbols static if they're not exported.
3908 * dispextern.h (redraw_garbaged_frames, scrolling):
3909 (increment_row_positions): Remove.
3910 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3911 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3912 Now static.
3913 (redraw_garbaged_frames): Remove; unused.
3914
3915 * xfaces.c: Make symbols static if they're not exported.
3916 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3917 Remove decls.
3918 * xterm.h (defined_color): Remove decls.
3919 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3920 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3921 (menu_face_changed_default, defined_color, free_realized_face):
3922 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3923 (ascii_face_of_lisp_face): Remove; unused.
3924
3925 * xdisp.c: Make symbols static if they're not exported.
3926 * dispextern.h (scratch_glyph_row, window_box_edges):
3927 (glyph_to_pixel_coords, set_cursor_from_row):
3928 (get_next_display_element, set_iterator_to_next):
3929 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3930 (show_mouse_face): Remove decls
3931 * frame.h (message_buf_print): Likewise.
3932 * lisp.h (pop_message, set_message, check_point_in_composition):
3933 Likewise.
3934 * xterm.h (set_vertical_scroll_bar): Likewise.
3935 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3936 (message_buf_print, scratch_glyph_row, displayed_buffer):
3937 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3938 (get_next_display_element, show_mouse_face, window_box_edges):
3939 (frame_to_window_pixel_xy, check_point_in_composition):
3940 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3941 (glyph_to_pixel_coords): Remove; unused.
3942
3943 * dired.c (file_name_completion): Now static.
3944
3945 * dbusbind.c (xd_in_read_queued_messages): Now static.
3946
3947 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3948 * data.c (circular_list_error): Remove.
3949
3950 * commands.h (last_point_position, last_point_position_buffer):
3951 (last_point_position_window): Remove decls.
3952 * keyboard.c: Make these variables static.
3953
3954 * coding.h (coding, code_convert_region, encode_coding_gap):
3955 Remove decls.
3956 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3957 (iso_code_class, detect_coding, code_convert_region): Now static.
3958 (encode_coding_gap): Remove; unused.
3959
3960 * chartab.c (chartab_chars, chartab_bits): Now static.
3961
3962 * charset.h (charset_iso_8859_1): Remove decl.
3963 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3964 Now static.
3965
3966 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3967 * ccl.c (Vccl_program_table): Now static.
3968 (check_ccl_update): Remove; unused.
3969
3970 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3971 * category.h: ... from here.
3972 * category.c (check_category_table, set_category_set): Now static.
3973
3974 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3975 * lisp.h: Remove these decls.
3976
3977 * buffer.c (buffer_count): Remove unused var.
3978
3979 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3980 so that it's not optimized away.
3981 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3982 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3983 exported only to the debugger.
3984
3985 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3986 * atimer.h (run_all_atimers): Remove; not exported.
3987
3988 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3989 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3990 was inaccessible from Lisp.
3991 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3992 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3993
3994 alloc.c: Import and export fewer symbols, and remove unused items.
3995 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3996 is defined.
3997 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3998 it's not optimized away by whole-program optimization.
3999 (message_enable_multibyte, free_misc): Remove.
4000 (catchlist, handlerlist, mark_backtrace):
4001 Declare only if BYTE_MARK_STACK.
4002 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4003 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4004 (message_enable_multibyte): Remove decl.
4005 (free_misc, interval_free_list, float_block, float_block_index):
4006 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4007 (cons_free_list, last_marked_index):
4008 Now static.
4009 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4010 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4011 (mark_backtrace): Define only if BYTE_MARK_STACK.
4012 * xdisp.c (message_enable_multibyte): Now static.
4013
4014 Declare Lisp_Object Q* variables to be 'static' if not exported.
4015 This makes it easier for human readers (and static analyzers)
4016 to see whether these variables are used from other modules.
4017 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4018 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4019 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4020 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4021 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4022 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4023 * xmenu.c, xselect.c:
4024 Declare Q* vars static if they are not used in other modules.
4025 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4026 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4027 Remove decls of unexported vars.
4028 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4029
4030 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4031
4032 Make Emacs functions such as Fatom 'static' by default.
4033 This makes it easier for human readers (and static analyzers)
4034 to see whether these functions can be called from other modules.
4035 DEFUN now defines a static function. To make the function external
4036 so that it can be used in other C modules, use the new macro DEFUE.
4037 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4038 (Finit_image_library):
4039 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4040 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4041 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4042 Remove decls, since these functions are now static.
4043 (Funintern, Fget_internal_run_time): New decls, since these functions
4044 were already external.
4045
4046 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4047 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4048 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4049 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4050 * keyboard.c, keymap.c, lread.c:
4051 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4052 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4053 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4054 Mark functions with DEFUE instead of DEFUN,
4055 if they are used in other modules.
4056 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4057 decls for now-static functions.
4058 * buffer.h (Fdelete_overlay): Remove decl.
4059 * callproc.c (Fgetenv_internal): Mark as internal.
4060 * composite.c (Fremove_list_of_text_properties): Remove decl.
4061 (Fcomposition_get_gstring): New forward static decl.
4062 * composite.h (Fcomposite_get_gstring): Remove decl.
4063 * dired.c (Ffile_attributes): New forward static decl.
4064 * doc.c (Fdocumntation_property): New forward static decl.
4065 * eval.c (Ffetch_bytecode): New forward static decl.
4066 (Funintern): Remove extern decl; now in .h file where it belongs.
4067 * fileio.c (Fmake_symbolic_link): New forward static decl.
4068 * image.c (Finit_image_library): New forward static decl.
4069 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4070 * intervals.h (Fprevious_property_change):
4071 (Fremove_list_of_text_properties): Remove decls.
4072 * keyboard.c (Fthis_command_keys): Remove decl.
4073 (Fcommand_execute): New forward static decl.
4074 * keymap.c (Flookup_key): New forward static decl.
4075 (Fcopy_keymap): Now static.
4076 * keymap.h (Flookup_key): Remove decl.
4077 * process.c (Fget_process): New forward static decl.
4078 (Fprocess_datagram_address): Mark as internal.
4079 * syntax.c (Fsyntax_table_p): New forward static decl.
4080 (skip_chars): Remove duplicate decl.
4081 * textprop.c (Fprevious_property_change): New forward static decl.
4082 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4083 Now internal.
4084 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4085 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4086
4087 * editfns.c (Fformat): Remove unreachable code.
4088
4089 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4090
4091 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4092 change. (Bug#8496)
4093
4094 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4095
4096 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4097 when at ZV. (Bug#8487)
4098
4099 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4100
4101 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4102 (Bug#8437)
4103 * keyboard.c (parse_tool_bar_item): Likewise.
4104 * sound.c (sound_cleanup, alsa_close): Likewise.
4105 * termcap.c (tgetent): Likewise.
4106 * xfns.c (x_default_font_parameter): Likewise.
4107 * xsettings.c (read_and_apply_settings): Likewise.
4108
4109 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4110 (overrun_check_free): Protoize.
4111
4112 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4113
4114 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4115 since callers should never pass a negative size.
4116 Change the signature to match that of plain 'read' and 'write'; see
4117 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4118 * lisp.h: Update prototypes of emacs_write and emacs_read.
4119
4120 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4121
4122 * xdisp.c (redisplay_window): Don't try to determine the character
4123 position of the scroll margin if the window start point w->startp
4124 is outside the buffer's accessible region. (Bug#8468)
4125
4126 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4127
4128 Fix write-region and its subroutines for buffers > 2GB.
4129 * fileio.c (a_write, e_write): Modify declaration of arguments and
4130 local variables to support buffers larger than 2GB.
4131 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4132
4133 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4134 argument, local variables, and return value.
4135
4136 * lisp.h: Update prototypes of emacs_write and emacs_read.
4137
4138 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4139
4140 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4141
4142 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4143
4144 Fix more problems found by GCC 4.6.0's static checks.
4145
4146 * xdisp.c (vmessage): Use a better test for character truncation.
4147
4148 * charset.c (load_charset_map): <, not <=, for optimization,
4149 and to avoid potential problems with integer overflow.
4150 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4151 * casetab.c (set_identity, shuffle): Likewise.
4152 * editfns.c (Fformat): Likewise.
4153 * syntax.c (skip_chars): Likewise.
4154
4155 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4156 This also lets GCC 4.6.0 generate slightly better loop code.
4157
4158 * callint.c (Fcall_interactively): <, not <=, for optimization.
4159 (Fcall_interactively): Count the number of arguments produced,
4160 not the number of arguments given. This is simpler and lets GCC
4161 4.6.0 generate slightly better code.
4162
4163 * ftfont.c: Distingish more carefully between FcChar8 and char.
4164 The previous code passed unsigned char * to a functions like
4165 strlen and xstrcasecmp that expect char *, which does not
4166 conform to the C standard.
4167 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4168 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4169 char * when the C standard requires it.
4170
4171 * keyboard.c (read_char): Remove unused var.
4172
4173 * eval.c: Port to Windows vsnprintf (Bug#8435).
4174 Include <limits.h>.
4175 (SIZE_MAX): Define if the headers do not.
4176 (verror): Do not give up if vsnprintf returns a negative count.
4177 Instead, grow the buffer. This ports to Windows vsnprintf, which
4178 does not conform to C99. Problem reported by Eli Zaretskii.
4179 Also, simplify the allocation scheme, by avoiding the need for
4180 calling realloc, and removing the ALLOCATED variable.
4181
4182 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4183
4184 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4185 But keep the doprint source code for now, as we might revamp it
4186 and use it again (Bug#8435).
4187 * lisp.h (doprnt): Remove.
4188 * Makefile.in (base_obj): Remove doprnt.o.
4189 * deps.mk (doprnt.o): Remove.
4190
4191 error: Print 32- and 64-bit integers portably (Bug#8435).
4192 Without this change, on typical 64-bit hosts error ("...%d...", N)
4193 was used to print both 32- and 64-bit integers N, which relied on
4194 undefined behavior.
4195 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4196 New macro.
4197 * lisp.h (error, verror): Mark as printf-like functions.
4198 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4199 Report overflow in size calculations when allocating printf buffer.
4200 Do not truncate output string at its first null byte.
4201 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4202 Truncate the output at a character boundary, since vsnprintf does not
4203 do that.
4204 * charset.c (check_iso_charset_parameter): Convert internal
4205 character to string before calling 'error', since %c now has the
4206 printf meaning.
4207 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4208 overflow when computing char to be passed to 'error'. Do not
4209 pass Lisp_Object to 'error'; pass the integer instead.
4210 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4211 formatted with plain %d.
4212
4213 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4214
4215 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4216
4217 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4218
4219 * xterm.c (x_catch_errors): Remove duplicate declaration.
4220
4221 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4222
4223 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4224
4225 2011-04-10 Jim Meyering <meyering@redhat.com>
4226
4227 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4228 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4229 return ssize_t not "int", and use size_t as the buffer length.
4230 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4231 * gnutls.h: Update declarations.
4232 * process.c (read_process_output): Use ssize_t, to match.
4233 (send_process): Likewise.
4234
4235 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4236
4237 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4238
4239 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4240
4241 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4242 Use unsigned char, to match FcChar8 type definition.
4243
4244 * xterm.c (handle_one_xevent):
4245 * xmenu.c (create_and_show_popup_menu):
4246 * xselect.c (x_decline_selection_request)
4247 (x_reply_selection_request): Avoid type-punned deref of X events.
4248
4249 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4250
4251 Fix some uses of `int' instead of EMACS_INT.
4252 * search.c (string_match_1, fast_string_match)
4253 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4254 (scan_buffer, find_next_newline_no_quit)
4255 (find_before_next_newline, search_command, Freplace_match)
4256 (Fmatch_data): Make some `int' variables be EMACS_INT.
4257
4258 * xdisp.c (display_count_lines): 3rd argument and return value now
4259 EMACS_INT. All callers changed.
4260 (pint2hrstr): Last argument is now EMACS_INT.
4261
4262 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4263 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4264 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4265 (decode_coding_utf_16, decode_coding_emacs_mule)
4266 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4267 (decode_coding_ccl, decode_coding_charset)
4268 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4269 (decode_coding_iso_2022, decode_coding_emacs_mule)
4270 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4271 <char_offset, last_offset>: Declare EMACS_INT.
4272 (encode_coding_utf_8, encode_coding_utf_16)
4273 (encode_coding_emacs_mule, encode_invocation_designation)
4274 (encode_designation_at_bol, encode_coding_iso_2022)
4275 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4276 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4277 Declare EMACS_INT.
4278 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4279 (encode_invocation_designation): Last argument P_NCHARS is now
4280 EMACS_INT.
4281 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4282 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4283
4284 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4285 All users changed.
4286
4287 * ccl.c (Fccl_execute_on_string): Declare some variables
4288 EMACS_INT.
4289
4290 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4291
4292 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4293
4294 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4295
4296 * process.c (Fformat_network_address): Doc fix.
4297
4298 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4299
4300 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4301
4302 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4303
4304 * keyboard.c (read_char): Call Lisp function help-form-show,
4305 instead of using internal_with_output_to_temp_buffer.
4306 (Qhelp_form_show): New var.
4307 (syms_of_keyboard): Use DEFSYM macro.
4308
4309 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4310
4311 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4312
4313 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4314
4315 * process.c (Flist_processes): Remove to Lisp.
4316 (list_processes_1): Delete.
4317
4318 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4319
4320 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4321
4322 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4323
4324 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4325
4326 Fix more problems found by GCC 4.6.0's static checks.
4327
4328 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4329
4330 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4331
4332 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4333
4334 * xdisp.c (vmessage): Mark as a printf-like function.
4335
4336 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4337
4338 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4339
4340 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4341 printf-like functions.
4342 (tiff_load): Add casts to remove these marks before passing them
4343 to system-supplied API.
4344
4345 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4346
4347 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4348 This avoids several warnings with gcc -Wstrict-overflow.
4349 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4350 directly, rather than having caller test rule sign. This avoids
4351 some unnecessary tests.
4352 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4353 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4354 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4355
4356 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4357 (xfont_open): Avoid unnecessary tests.
4358
4359 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4360
4361 * composite.h, composite.c (composition_gstring_put_cache):
4362 Use EMACS_INT, not int, for length.
4363
4364 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4365 breaking out part of COMPOSITION_DECODE_RULE.
4366 (COMPOSITION_DECODE_RULE): Use it.
4367 * composite.c (get_composition_id): Remove unused local vars,
4368 by using the new macro.
4369
4370 * textprop.c (set_text_properties_1): Change while to do-while,
4371 since the condition is always true at first.
4372
4373 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4374 (interval_deletion_adjustment): Return unsigned value.
4375 All uses changed.
4376
4377 * process.c (list_processes_1, create_pty, read_process_output):
4378 (exec_sentinel): Remove vars that were set but not used.
4379 (create_pty): Remove unnecessary "volatile"s.
4380 (Fnetwork_interface_info): Avoid possibility of int overflow.
4381 (read_process_output): Do adaptive read buffering even if carryover.
4382 (read_process_output): Simplify nbytes computation if buffered.
4383
4384 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4385
4386 * syntax.c (scan_words): Remove var that was set but not used.
4387 (update_syntax_table): Use unsigned instead of int.
4388
4389 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4390 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4391 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4392
4393 * print.c (print_error_message): Avoid int overflow.
4394
4395 * font.c (font_list_entities): Redo for clarity,
4396 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4397
4398 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4399 (font_score): Avoid potential overflow in diff calculation.
4400
4401 * fns.c (substring_both): Remove var that is set but not used.
4402 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4403
4404 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4405
4406 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4407 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4408 can always succeed if overflow has undefined behavior.
4409
4410 * search.c (boyer_moore, wordify): Remove vars set but not used.
4411 (wordify): Omit three unnecessary tests.
4412
4413 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4414 All callers changed. This avoids the need for an unused var.
4415
4416 * casefiddle.c (casify_region): Remove var that is set but not used.
4417
4418 * dired.c (file_name_completion): Remove var that is set but not used.
4419
4420 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4421
4422 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4423 (Finsert_file_contents): Remove unnecessary code checking fd.
4424
4425 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4426 Check for integer overflow on size calculations.
4427
4428 * buffer.c (Fprevious_overlay_change): Remove var that is set
4429 but not used.
4430
4431 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4432 Remove vars that are set but not used.
4433 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4434 (timer_check_2): Mark vars as initialized.
4435
4436 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4437
4438 * image.c (lookup_image): Remove var that is set but not used.
4439 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4440
4441 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4442 that are set but not used.
4443
4444 * xfns.c (make_invisible_cursor): Don't return garbage
4445 if XCreateBitmapFromData fails (Bug#8410).
4446
4447 * xselect.c (x_get_local_selection, x_handle_property_notify):
4448 Remove vars that are set but not used.
4449
4450 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4451 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4452
4453 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4454 Remove var that is set but not used.
4455 (scroll_bar_windows_size): Now size_t, not int.
4456 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4457 Check for overflow.
4458
4459 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4460 (map_tty_color) [!defined MSDOS]: Likewise.
4461
4462 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4463
4464 * coding.c: Remove vars that are set but not used.
4465 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4466 All callers changed.
4467 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4468 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4469 (decode_coding_charset): Remove vars that are set but not used.
4470
4471 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4472 that is set but not used.
4473
4474 * print.c (print_object): Remove var that is set but not used.
4475
4476 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4477 The gnulib version avoids calling malloc in the usual case,
4478 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4479 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4480 * filelock.c (current_lock_owner): Likewise.
4481 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4482 * sysdep.c: Include allocator.h, careadlinkat.h.
4483 (emacs_no_realloc_allocator): New static constant.
4484 (emacs_readlink): New function.
4485 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4486 ../lib/careadlinkat.h.
4487
4488 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4489
4490 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4491 first non-nil return value).
4492
4493 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4494
4495 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4496 if not defined (Bug#8403).
4497
4498 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4499
4500 * xdisp.c (display_count_lines): Remove parameter `start',
4501 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4502 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4503 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4504 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4505 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4506 and thereabouts. All callers changed.
4507 (get_per_char_metric): Remove parameter `f', unused since
4508 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4509
4510 2011-04-02 Jim Meyering <meyering@redhat.com>
4511
4512 do not dereference NULL upon failed strdup
4513 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4514 (ns_get_family): Likewise.
4515
4516 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4517
4518 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4519
4520 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4521
4522 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4523 later (Bug#8403).
4524
4525 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4526
4527 Add lexical binding.
4528
4529 * window.c (Ftemp_output_buffer_show): New fun.
4530 (Fsave_window_excursion):
4531 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4532
4533 * lread.c (lisp_file_lexically_bound_p): New function.
4534 (Fload): Bind Qlexical_binding.
4535 (readevalloop): Remove `evalfun' arg.
4536 Bind Qinternal_interpreter_environment.
4537 (Feval_buffer): Bind Qlexical_binding.
4538 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4539 Mark as dynamic.
4540 (syms_of_lread): Declare `lexical-binding'.
4541
4542 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4543
4544 * keyboard.c (eval_dyn): New fun.
4545 (menu_item_eval_property): Use it.
4546
4547 * image.c (parse_image_spec): Use Ffunctionp.
4548
4549 * fns.c (concat, mapcar1): Accept byte-code-functions.
4550
4551 * eval.c (Fsetq): Handle lexical vars.
4552 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4553 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4554 (FletX, Flet): Obey lexical binding.
4555 (Fcommandp): Handle closures.
4556 (Feval): New `lexical' arg.
4557 (eval_sub): New function extracted from Feval. Use it almost
4558 everywhere where Feval was used. Look up vars in lexical env.
4559 Handle closures.
4560 (Ffunctionp): Move from subr.el.
4561 (Ffuncall): Handle closures.
4562 (apply_lambda): Remove `eval_flags'.
4563 (funcall_lambda): Handle closures and new byte-code-functions.
4564 (Fspecial_variable_p): New function.
4565 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4566 but without exporting it to Lisp.
4567
4568 * doc.c (Fdocumentation, store_function_docstring):
4569 * data.c (Finteractive_form): Handle closures.
4570
4571 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4572 interactive spec.
4573
4574 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4575 New byte-codes.
4576 (exec_byte_code): New function extracted from Fbyte_code to handle new
4577 calling convention for byte-code-functions. Add new byte-codes.
4578
4579 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4580
4581 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4582
4583 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4584
4585 * xdisp.c (redisplay_internal): Fix prototype.
4586
4587 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4588
4589 * xdisp.c (SCROLL_LIMIT): New macro.
4590 (try_scrolling): Use it when setting scroll_limit.
4591 Limit scrolling to 100 screen lines.
4592 (redisplay_window): Even when falling back on "recentering",
4593 position point in the window according to scroll-conservatively,
4594 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4595
4596 (try_scrolling): When point is above the window, allow searching
4597 as far as scroll_max, or one screenful, to compute vertical
4598 distance from PT to the scroll margin position. This prevents
4599 try_scrolling from unnecessarily failing when
4600 scroll-conservatively is set to a value slightly larger than the
4601 window height. Clean up the case of PT below the margin at bottom
4602 of window: scroll_max can no longer be INT_MAX. When aggressive
4603 scrolling is in use, don't let point enter the opposite scroll
4604 margin as result of the scroll.
4605 (syms_of_xdisp) <scroll-conservatively>: Document the
4606 threshold of 100 lines for never-recentering scrolling.
4607
4608 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4609
4610 * dispextern.h (move_it_by_lines):
4611 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4612 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4613 (message_log_check_duplicate): Remove parameters `prev_bol' and
4614 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4615 (redisplay_internal): Remove parameter `preserve_echo_area',
4616 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4617
4618 * indent.c (Fvertical_motion):
4619 * window.c (window_scroll_pixel_based, Frecenter):
4620 Don't pass `need_y_p' to `move_it_by_lines'.
4621
4622 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4623
4624 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4625 steal a few bits to be more compact.
4626 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4627 Remove unneeded casts.
4628
4629 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4630
4631 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4632
4633 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4634 binding" message (bug#7967).
4635
4636 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4637
4638 Fix more problems found by GCC 4.6.0's static checks.
4639
4640 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4641 Remove unused local var.
4642
4643 * editfns.c (Fmessage_box): Remove unused local var.
4644
4645 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4646 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4647 Omit unused local vars.
4648 * window.c (shrink_windows): Omit unused local var.
4649 * menu.c (digest_single_submenu): Omit unused local var.
4650 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4651 Omit unused local var.
4652
4653 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4654 Don't assume string length fits in int.
4655 (keyremap_step, read_key_sequence): Use size_t for sizes.
4656 (read_key_sequence): Don't check last_real_key_start redundantly.
4657
4658 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4659 instead of alloca (Bug#8344).
4660
4661 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4662 (Fbacktrace_frame): Don't assume nframes fits in int.
4663
4664 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4665
4666 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4667 concerns.
4668
4669 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4670
4671 * cm.c (calccost): Turn while-do into do-while, for clarity.
4672
4673 * keyboard.c (syms_of_keyboard): Use the same style as later
4674 in this function when indexing through an array. This also
4675 works around GCC bug 48267.
4676
4677 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4678
4679 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4680
4681 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4682 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4683
4684 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4685 This avoids undefined behavior on integer overflow, and is a bit
4686 more convenient anyway since it is compared to a size_t variable.
4687
4688 Variadic C functions now count arguments with size_t, not int.
4689 This avoids an unnecessary limitation on 64-bit machines, which
4690 caused (substring ...) to crash on large vectors (Bug#8344).
4691 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4692 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4693 All variadic functions and their callers changed accordingly.
4694 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4695 * data.c (arith_driver, float_arith_driver): Likewise.
4696 * editfns.c (general_insert_function): Likewise.
4697 * eval.c (struct backtrace.nargs, interactive_p)
4698 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4699 (funcall_lambda, mark_backtrace): Likewise.
4700 * fns.c (concat): Likewise.
4701 * frame.c (x_set_frame_parameters): Likewise.
4702 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4703 0 if not found, not -1. All callers changed.
4704
4705 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4706 (stack_copy_size): Now size_t, not int.
4707 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4708
4709 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4710
4711 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4712 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4713 All callers changed.
4714
4715 * lisp.h (multibyte_char_to_unibyte):
4716 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4717 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4718 * character.h (CHAR_TO_BYTE8):
4719 * cmds.c (internal_self_insert):
4720 * editfns.c (general_insert_function):
4721 * keymap.c (push_key_description):
4722 * search.c (Freplace_match):
4723 * xdisp.c (message_dolog, set_message_1): All callers changed.
4724
4725 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4726
4727 * keyboard.c (safe_run_hook_funcall): New function.
4728 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4729 don't set the hook to nil, but remove the offending function instead.
4730 (Qcommand_hook_internal): Remove, unused.
4731 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4732 Vcommand_hook_internal.
4733
4734 * eval.c (enum run_hooks_condition): Remove.
4735 (funcall_nil, funcall_not): New functions.
4736 (run_hook_with_args): Call each function through a `funcall' argument.
4737 Remove `cond' argument, now redundant.
4738 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4739 (Frun_hook_with_args_until_failure): Adjust accordingly.
4740 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4741
4742 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4743
4744 * dispextern.h (string_buffer_position): Remove declaration.
4745
4746 * print.c (strout): Remove parameter `multibyte', unused since
4747 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4748
4749 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4750 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4751 All callers changed.
4752
4753 * w32.c (_wsa_errlist): Use braces for struct initializers.
4754
4755 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4756 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4757 All callers changed.
4758 (string_buffer_position): Likewise. Also, make static (it's never
4759 used outside xdisp.c).
4760 (cursor_row_p): Remove parameter `w', unused since
4761 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4762 (decode_mode_spec): Remove parameter `precision', introduced during
4763 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4764 All callers changed.
4765
4766 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4767
4768 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4769
4770 2011-03-27 Anders Lindgren <andlind@gmail.com>
4771
4772 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4773 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4774 (ns_update_auto_hide_menu_bar): New functions.
4775 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4776 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4777 ns_constrain_all_frames.
4778 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4779 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4780
4781 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4782
4783 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4784
4785 2011-03-27 Glenn Morris <rgm@gnu.org>
4786
4787 * syssignal.h: Replace RETSIGTYPE with void.
4788 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4789 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4790 Replace SIGTYPE with void everywhere.
4791 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4792 * s/template.h (SIGTYPE): Remove commented out definition.
4793
4794 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4795
4796 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4797 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4798
4799 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4800
4801 * w32.c (read_unc_volume): Use parameter `henum', instead of
4802 global variable `wget_enum_handle'.
4803
4804 * keymap.c (describe_vector): Remove parameters `indices' and
4805 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4806 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4807
4808 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4809
4810 * keyboard.c (timer_check): Remove parameter `do_it_now',
4811 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4812 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4813 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4814
4815 * keyboard.c (read_char):
4816 * w32menu.c (w32_menu_display_help):
4817 * xmenu.c (show_help_event, menu_help_callback):
4818 Adjust calls to `show_help_echo'.
4819
4820 * gtkutil.c (xg_maybe_add_timer):
4821 * keyboard.c (readable_events):
4822 * process.c (wait_reading_process_output):
4823 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4824
4825 * insdel.c (adjust_markers_gap_motion):
4826 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4827 (gap_left, gap_right): Don't call it.
4828
4829 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4830
4831 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4832 incurred during fontification.
4833
4834 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4835
4836 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4837 (DEFVAR_PER_BUFFER): Don't pass it.
4838
4839 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4840 (scrolling_window): Don't pass it.
4841
4842 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4843
4844 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4845
4846 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4847 and `suffix'.
4848 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4849 of variables specific to SELinux and computation of `encoded_absname'.
4850
4851 * image.c (XPutPixel): Remove unused variable `height'.
4852
4853 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4854
4855 * unexw32.c (get_section_info): Remove unused variable `section'.
4856
4857 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4858 (system_process_attributes): Remove unused variable `sess'.
4859 (sys_read): Remove unused variable `err'.
4860
4861 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4862 (w32_wnd_proc): Remove unused variable `isdead'.
4863 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4864 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4865 (x_create_tip_frame): Remove unused variable `tem'.
4866
4867 * w32inevt.c (w32_console_read_socket):
4868 Remove unused variable `no_events'.
4869
4870 * w32term.c (x_draw_composite_glyph_string_foreground):
4871 Remove unused variable `width'.
4872
4873 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4874
4875 * w32term.c (x_set_glyph_string_clipping):
4876 Don't pass uninitialized region to CombineRgn.
4877
4878 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4879
4880 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4881 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4882 (Fx_close_connection): Remove unused variable `i'.
4883
4884 * w32font.c (w32font_draw): Return number of glyphs.
4885 (w32font_open_internal): Remove unused variable `i'.
4886 (w32font_driver): Add missing initializer.
4887
4888 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4889 (fill_in_menu): Remove unused variable `items_added'.
4890
4891 * w32term.c (last_mouse_press_frame): Remove static global variable.
4892 (w32_clip_to_row): Remove unused variable `f'.
4893 (x_delete_terminal): Remove unused variable `i'.
4894
4895 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4896 (NOTHING): Remove unused static global variable.
4897 (uniscribe_check_otf): Remove unused variable `table'.
4898 (uniscribe_font_driver): Add missing initializers.
4899
4900 2011-03-23 Julien Danjou <julien@danjou.info>
4901
4902 * term.c (Fsuspend_tty, Fresume_tty):
4903 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4904 * window.c (temp_output_buffer_show):
4905 * insdel.c (signal_before_change):
4906 * frame.c (Fhandle_switch_frame):
4907 * fileio.c (Fdo_auto_save):
4908 * emacs.c (Fkill_emacs):
4909 * editfns.c (save_excursion_restore):
4910 * cmds.c (internal_self_insert):
4911 * callint.c (Fcall_interactively):
4912 * buffer.c (Fkill_all_local_variables):
4913 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4914 Use Frun_hooks.
4915 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4916 unconditionnaly since it does the check itself.
4917
4918 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4919
4920 Fix more problems found by GCC 4.5.2's static checks.
4921
4922 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4923 the first time through the loop, since we know p0 < p1 then.
4924 This also avoids a gcc -Wstrict-overflow warning.
4925
4926 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4927 leading to a memory leak, possible in functions like
4928 load_charset_map_from_file that can allocate an unbounded number
4929 of objects (Bug#8318).
4930
4931 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4932 that could (at least in theory) be that large.
4933
4934 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4935 This is less likely to overflow, and avoids undefined behavior if
4936 overflow does occur. All callers changed. Use strtoul to scan
4937 for the unsigned long integer.
4938 (pint2hrstr): Simplify and tune code slightly.
4939 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4940
4941 * scroll.c (do_scrolling): Work around GCC bug 48228.
4942 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4943
4944 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4945 This also avoids a warning with gcc -Wstrict-overflow.
4946 (validate_x_resource_name): Simplify count usage.
4947 This also avoids a warning with gcc -Wstrict-overflow.
4948
4949 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4950 fail (Bug#8306).
4951
4952 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4953
4954 * process.c (Fmake_network_process): Use socklen_t, not int,
4955 where POSIX says socklen_t is required in portable programs.
4956 This fixes a porting bug on hosts like 64-bit HP-UX, where
4957 socklen_t is wider than int (Bug#8277).
4958 (Fmake_network_process, server_accept_connection):
4959 (wait_reading_process_output, read_process_output):
4960 Likewise.
4961
4962 * process.c: Rename or move locals to avoid shadowing.
4963 (list_processes_1, Fmake_network_process):
4964 (read_process_output_error_handler, exec_sentinel_error_handler):
4965 Rename or move locals.
4966 (Fmake_network_process): Define label "retry_connect" only if needed.
4967 (Fnetwork_interface_info): Fix pointer signedness.
4968 (process_send_signal): Add cast to avoid pointer signedness problem.
4969 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4970 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4971
4972 Make tparam.h and terminfo.c consistent.
4973 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4974 Include tparam.h instead, since it declares them.
4975 * cm.h (PC): Remove extern decl; tparam.h now does this.
4976 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4977 * terminfo.c: Include tparam.h, to check interfaces.
4978 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4979 (tparam): Adjust signature to match interface in tparam.h;
4980 this removes some undefined behavior. Check that outstring and len
4981 are zero, which they always are with Emacs.
4982 * tparam.h (PC, BC, UP): New extern decls.
4983
4984 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4985 (xftfont_open): Rename locals to avoid shadowing.
4986
4987 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4988 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4989 (OTF_TAG_SYM): Omit macro if not needed.
4990 (ftfont_list): Remove unused local.
4991 (get_adstyle_property, ftfont_pattern_entity):
4992 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4993 Rename locals to avoid shadowing.
4994
4995 * xfont.c (xfont_list_family): Mark var as initialized.
4996
4997 * xml.c (make_dom): Now static.
4998
4999 * composite.c (composition_compute_stop_pos): Rename local to
5000 avoid shadowing.
5001 (composition_reseat_it): Remove unused locals.
5002 (find_automatic_composition, composition_adjust_point): Likewise.
5003 (composition_update_it): Mark var as initialized.
5004 (find_automatic_composition): Mark vars as initialized,
5005 with a FIXME (Bug#8290).
5006
5007 character.h: Rename locals to avoid shadowing.
5008 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5009 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5010 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5011 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5012 to avoid shadowing.
5013
5014 * textprop.c (property_change_between_p): Remove; unused.
5015
5016 * intervals.c (interval_start_pos): Now static.
5017
5018 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5019
5020 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5021 Rename locals to avoid shadowing.
5022
5023 * sound.c (wav_play, au_play, Fplay_sound_internal):
5024 Fix pointer signedness.
5025 (alsa_choose_format): Remove unused local var.
5026 (wav_play): Initialize a variable to 0, to prevent undefined
5027 behavior (Bug#8278).
5028
5029 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5030
5031 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5032
5033 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5034 clobbering (Bug#8298).
5035 * sysdep.c (sys_subshell): Likewise.
5036 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5037
5038 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5039 This should get cleaned up, so that child_setup has the
5040 same signature on all platforms.
5041
5042 * callproc.c (call_process_cleanup): Now static.
5043 (relocate_fd): Rename locals to avoid shadowing.
5044
5045 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5046
5047 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5048 not to be necessary, and produces flickering.
5049
5050 2011-03-20 Glenn Morris <rgm@gnu.org>
5051
5052 * config.in: Remove file.
5053
5054 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5055
5056 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5057 are now in src/globals.h.
5058 (syms_of_minibuf): Remove spurious & from previous change.
5059
5060 2011-03-20 Leo <sdl.web@gmail.com>
5061
5062 * minibuf.c (completing-read-function): New variable.
5063 (completing-read-default): Rename from completing-read.
5064 (completing-read): Call completing-read-function.
5065
5066 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5067
5068 * xfaces.c (Fx_load_color_file):
5069 Read color file from absolute filename (bug#8250).
5070
5071 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5072
5073 * makefile.w32-in: Update dependencies.
5074
5075 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5076
5077 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5078
5079 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5080
5081 Fix more problems found by GCC 4.5.2's static checks.
5082
5083 * process.c (make_serial_process_unwind, send_process_trap):
5084 (sigchld_handler): Now static.
5085
5086 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5087 That way, the code declares only the vars that it needs.
5088 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5089 * s/cygwin.h (PTY_ITERATION): Likewise.
5090 * s/darwin.h (PTY_ITERATION): Likewise.
5091 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5092
5093 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5094 * process.c (allocate_pty): Don't declare stb unless it's needed.
5095
5096 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5097 (CONSTANTLIM): Remove; unused.
5098 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5099 Define only if needed.
5100
5101 * unexelf.c (unexec): Name an expression,
5102 to avoid gcc -Wbad-function-cast warning.
5103 Use a different way to cause a compilation error if anyone uses
5104 n rather than nn, a way that does not involve shadowing.
5105 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5106
5107 * deps.mk (unexalpha.o): Remove; unused.
5108
5109 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5110 * unexec.h: New file.
5111 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5112 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5113 Depend on unexec.h.
5114 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5115 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5116 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5117 Change as necessary to match prototype in unexec.h.
5118
5119 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5120 shadowing.
5121 (back_comment, skip_chars): Mark vars as initialized.
5122
5123 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5124 Rename locals to avoid shadowing.
5125
5126 * lread.c (read1): Rewrite so as not to use empty "else".
5127 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5128
5129 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5130
5131 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5132 warning when compiling print.c.
5133
5134 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5135 instead of using an uninitialized var.
5136 (font_sort_entities): Mark var as initialized.
5137
5138 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5139
5140 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5141 pointers to constants.
5142 (font_parse_fcname): Remove unused vars.
5143 (font_delete_unmatched): Now static.
5144 (font_get_spec): Remove; unused.
5145 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5146 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5147 Rename or move locals to avoid shadowing.
5148
5149 * fns.c (require_nesting_list, require_unwind): Now static.
5150 (Ffillarray): Rename locals to avoid shadowing.
5151
5152 * floatfns.c (domain_error2): Define only if needed.
5153 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5154
5155 * alloc.c (mark_backtrace): Move decl from here ...
5156 * lisp.h: ... to here, so that it can be checked.
5157
5158 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5159 (Fdefvar): Rewrite so as not to use empty "else".
5160 (lisp_indirect_variable): Name an expression,
5161 to avoid gcc -Wbad-function-cast warning.
5162 (Fdefvar): Rename locals to avoid shadowing.
5163
5164 * callint.c (quotify_arg, quotify_args): Now static.
5165 (Fcall_interactively): Rename locals to avoid shadowing.
5166 Use const pointer when appropriate.
5167
5168 * lisp.h (get_system_name, get_operating_system_release):
5169 Move decls here, to check interfaces.
5170 * process.c (get_operating_system_release): Move decl to lisp.h.
5171 * xrdb.c (get_system_name): Likewise.
5172 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5173 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5174 some of which prompt warnings from gcc -Wbad-function-cast.
5175 (Fformat_time_string, Fencode_time, Finsert_char):
5176 (Ftranslate_region_internal, Fformat):
5177 Rename or remove local vars to avoid shadowing.
5178 (Ftranslate_region_internal): Mark var as initialized.
5179
5180 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5181 avoid shadowing.
5182
5183 * lisp.h (eassert): Check that the argument compiles, even if
5184 ENABLE_CHECKING is not defined.
5185
5186 * data.c (Findirect_variable): Name an expression, to avoid
5187 gcc -Wbad-function-cast warning.
5188 (default_value, arithcompare, arith_driver, arith_error): Now static.
5189 (store_symval_forwarding): Rename local to avoid shadowing.
5190 (Fmake_variable_buffer_local, Fmake_local_variable):
5191 Mark variables as initialized.
5192 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5193
5194 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5195 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5196 Rename locals to avoid shadowing.
5197 (mark_stack): Move local variables into the #ifdef region where
5198 they're used.
5199 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5200 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5201 needed otherwise.
5202 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5203 (GC_STRING_CHARS): Remove; not used.
5204 (Fmemory_limit): Cast sbrk's returned value to char *.
5205
5206 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5207 avoids undefined behavior in theory.
5208
5209 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5210
5211 Use functions, not macros, for up- and down-casing (Bug#8254).
5212 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5213 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5214 to use the following functions instead of these macros.
5215 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5216 EMACS_INT, since callers assume the returned value fits in int.
5217 (upcase1): Likewise, for UPCASE_TABLE.
5218 (uppercasep, lowercasep, upcase): New static inline functions.
5219 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5220 the race-condition problem in the old DOWNCASE.
5221
5222 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5223 Rename locals to avoid shadowing.
5224 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5225 (regex_compile, re_search_2, re_match_2_internal):
5226 Remove unused local vars.
5227 (FREE_VAR): Rewrite so as not to use empty "else",
5228 which gcc can warn about.
5229 (regex_compile, re_match_2_internal): Mark locals as initialized.
5230 (RETALLOC_IF): Define only if needed.
5231 (WORDCHAR_P): Likewise. This one is never needed, but is used
5232 only in a comment talking about a compiler bug, so put inside
5233 the #if 0 of that comment.
5234 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5235 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5236 Remove; unused.
5237
5238 * search.c (boyer_moore): Rename locals to avoid shadowing.
5239 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5240 (PREV_CHAR_BOUNDARY): Likewise.
5241
5242 * search.c (simple_search): Remove unused var.
5243
5244 * dired.c (compile_pattern): Move decl from here ...
5245 * lisp.h: ... to here, so that it can be checked.
5246 (struct re_registers): New forward decl.
5247
5248 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5249
5250 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5251 All uses changed.
5252 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5253 Rename locals to avoid shadowing.
5254 (Fvertical_motion): Mark locals as initialized.
5255
5256 * casefiddle.c (casify_object, casify_region): Now static.
5257 (casify_region): Mark local as initialized.
5258
5259 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5260
5261 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5262 New macros, so that the caller can use some names other than
5263 gcpro1, gcpro2, etc.
5264 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5265 of the new macros.
5266 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5267 argument, for consistency with GCPRO2_VAR, etc: it is now the
5268 prefix of the variable, not the variable itself. All uses
5269 changed.
5270 * dired.c (directory_files_internal, file_name_completion):
5271 Rename locals to avoid shadowing.
5272
5273 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5274 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5275 dired.c's scmp function, had undefined behavior.
5276 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5277 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5278 * buffer.h: ... to here, because these macros use current_buffer,
5279 and the new implementation with inline functions needs to have
5280 current_buffer in scope now, rather than later when the macros
5281 are used.
5282 (downcase, upcase1): New static inline functions.
5283 (DOWNCASE, UPCASE1): Reimplement using these functions.
5284 This avoids undefined behavior in expressions like
5285 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5286 from race conditions in accessing the global variables
5287 case_temp1 and case_temp2.
5288 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5289 * lisp.h (case_temp1, case_temp2): Remove their decls.
5290 * character.h (ASCII_CHAR_P): Move from here ...
5291 * lisp.h: ... to here, so that the inline functions mentioned
5292 above can use them.
5293
5294 * dired.c (directory_files_internal_unwind): Now static.
5295
5296 * fileio.c (file_name_as_directory, directory_file_name):
5297 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5298 Now static.
5299 (file_name_as_directory): Use const pointers when appropriate.
5300 (Fexpand_file_name): Likewise. In particular, newdir might
5301 point at constant storage, so make it a const pointer.
5302 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5303 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5304 signedness issues.
5305 (Fset_file_times, Finsert_file_contents, auto_save_error):
5306 Rename locals to avoid shadowing.
5307
5308 * minibuf.c (choose_minibuf_frame_1): Now static.
5309 (Ftry_completion, Fall_completions): Rename or remove locals
5310 to avoid shadowing.
5311
5312 * marker.c (bytepos_to_charpos): Remove; unused.
5313
5314 * lisp.h (verify_bytepos, count_markers): New decls,
5315 so that gcc does not warn that these functions aren't declared.
5316
5317 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5318 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5319 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5320 (copy_text): Remove unused local var.
5321
5322 * filelock.c (within_one_second): Now static.
5323 (lock_file_1): Rename local to avoid shadowing.
5324
5325 * buffer.c (fix_overlays_before): Mark locals as initialized.
5326 (fix_start_end_in_overlays): Likewise. This function should be
5327 simplified by using pointers-to-pointers, but that's a different
5328 matter.
5329 (switch_to_buffer_1): Now static.
5330 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5331 (report_overlay_modification): Rename locals to avoid shadowing.
5332
5333 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5334 Fix pointer signedness issue.
5335 (sys_subshell): Mark local as volatile if checking for lint,
5336 to suppress a gcc -Wclobbered warning that does not seem to be right.
5337 (MAXPATHLEN): Define only if needed.
5338
5339 * process.c (serial_open, serial_configure): Move decls from here ...
5340 * systty.h: ... to here, so that they can be checked.
5341
5342 * fns.c (get_random, seed_random): Move extern decls from here ...
5343 * lisp.h: ... to here, so that they can be checked.
5344
5345 * sysdep.c (reset_io): Now static.
5346 (wait_for_termination_signal): Remove; unused.
5347
5348 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5349 (copy_keymap_item, append_key, push_text_char_description):
5350 Now static.
5351 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5352 (DENSE_TABLE_SIZE): Remove; unused.
5353 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5354 (describe_map_tree):
5355 Rename locals to avoid shadowing.
5356
5357 * keyboard.c: Declare functions static if they are not used elsewhere.
5358 (echo_char, echo_dash, cmd_error, top_level_2):
5359 (poll_for_input, handle_async_input): Now static.
5360 (read_char, kbd_buffer_get_event, make_lispy_position):
5361 (make_lispy_event, make_lispy_movement, apply_modifiers):
5362 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5363 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5364 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5365 (read_key_sequence, read_char): Mark locals as initialized.
5366 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5367
5368 * keyboard.h (make_ctrl_char): New decl.
5369 (mark_kboards): Move decl here ...
5370 * alloc.c (mark_kboards): ... from here.
5371
5372 * lisp.h (force_auto_save_soon): New decl.
5373
5374 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5375 (DEFINE_DUMMY_FUNCTION): New macro.
5376 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5377 Use it.
5378 (main): Add casts to avoid warnings
5379 if GCC considers string literals to be constants.
5380
5381 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5382
5383 * dbusbind.c: Pointer signedness fixes.
5384 (xd_signature, xd_append_arg, xd_initialize):
5385 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5386 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5387 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5388 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5389
5390 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5391 if GCC considers string literals to be constants.
5392 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5393
5394 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5395
5396 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5397 (print_preprocess, print_object): New macro to fix last change.
5398
5399 * print.c (print_preprocess): Don't forget font objects.
5400
5401 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5402
5403 * emacs.c (USAGE3): Doc fixes.
5404
5405 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5406
5407 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5408 structure.
5409
5410 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5411
5412 * lisp.h (VWindow_system, Qfile_name_history):
5413 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5414 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5415 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5416
5417 * w32select.c: Don't #include "keyboard.h".
5418 (run_protected): Add extern declaration for waiting_for_input.
5419
5420 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5421 * w32console.c (detect_input_pending, read_input_pending)
5422 (encode_terminal_code):
5423 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5424 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5425 (w32_system_caret_y, Qfile_name_history):
5426 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5427 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5428 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5429 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5430 * w32proc.c (Qlocal, report_file_error):
5431 * w32term.c (Vwindow_system, updating_frame):
5432 * w32uniscribe.c (initialized, uniscribe_font_driver):
5433 Remove unneeded extern declarations.
5434
5435 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5436
5437 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5438
5439 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5440
5441 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5442 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5443 These macros can no longer be used for assignment.
5444
5445 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5446 Assign struct members directly, instead of using BUF_BEGV etc.
5447 (record_buffer_markers, fetch_buffer_markers): New functions for
5448 recording and fetching special buffer markers.
5449 (set_buffer_internal_1, set_buffer_temp): Use them.
5450
5451 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5452
5453 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5454
5455 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5456 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5457
5458 * xdisp.c (hscroll_window_tree):
5459 (reconsider_clip_changes): Use PT instead of BUF_PT.
5460
5461 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5462
5463 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5464 $(EMACS_ROOT)/lib/intprops.h.
5465
5466 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5467
5468 Fix more problems found by GCC 4.5.2's static checks.
5469
5470 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5471 to unsigned char * to avoid compiler diagnostic.
5472 (xg_free_frame_widgets): Make it clear that a local variable is
5473 needed only if USE_GTK_TOOLTIP.
5474 (gdk_window_get_screen): Make it clear that this macro is needed
5475 only if USE_GTK_TOOLTIP.
5476 (int_gtk_range_get_value): New function, which avoids a diagnostic
5477 from gcc -Wbad-function-cast.
5478 (xg_set_toolkit_scroll_bar_thumb): Use it.
5479 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5480 diagnostic from gcc -Wbad-function-cast.
5481 (get_utf8_string, xg_get_file_with_chooser):
5482 Rename locals to avoid shadowing.
5483 (create_dialog): Move locals to avoid shadowing.
5484
5485 * xgselect.c (xg_select): Remove unused var.
5486
5487 * image.c (four_corners_best): Mark locals as initialized.
5488 (gif_load): Initialize transparent_p to zero (Bug#8238).
5489 Mark another local as initialized.
5490 (my_png_error, my_error_exit): Mark with NO_RETURN.
5491
5492 * image.c (clear_image_cache): Now static.
5493 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5494 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5495 (x_edge_detection): Remove unnecessary cast that
5496 gcc -Wbad-function-cast diagnoses.
5497 (gif_load): Fix pointer signedness.
5498 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5499 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5500
5501 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5502
5503 Improve quality of tests for time stamp overflow.
5504 For example, without this patch (encode-time 0 0 0 1 1
5505 1152921504606846976) returns the obviously-bogus value (-948597
5506 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5507 reports time overflow. See
5508 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5509 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5510 * editfns.c: Include limits.h and intprops.h.
5511 (TIME_T_MIN, TIME_T_MAX): New macros.
5512 (time_overflow): Move earlier, to before first use.
5513 (hi_time, lo_time): New functions, for an accurate test for
5514 out-of-range times.
5515 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5516 (Fget_internal_run_time): Don't assume time_t fits in int.
5517 (make_time): Use list2 instead of Fcons twice.
5518 (Fdecode_time): More accurate test for out-of-range times.
5519 (check_tm_member): New function.
5520 (Fencode_time): Use it, to test for out-of-range times.
5521 (lisp_time_argument): Don't rely on undefined left-shift and
5522 right-shift behavior when checking for time stamp overflow.
5523
5524 * editfns.c (time_overflow): New function, refactoring common code.
5525 (Fformat_time_string, Fdecode_time, Fencode_time):
5526 (Fcurrent_time_string): Use it.
5527
5528 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5529 * dired.c (make_time): Move to ...
5530 * editfns.c (make_time): ... here.
5531 * systime.h: Note the move.
5532
5533 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5534
5535 * fringe.c (update_window_fringes): Remove unused variables.
5536
5537 * unexmacosx.c (copy_data_segment): Also copy __got section.
5538 (Bug#8223)
5539
5540 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5541
5542 * termcap.c [MSDOS]: Include "msdos.h".
5543 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5544 Constify `char *' arguments and their references according to
5545 prototypes in tparam.h.
5546
5547 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5548
5549 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5550 Adapt all references accordingly.
5551
5552 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5553
5554 2011-03-11 Tom Tromey <tromey@redhat.com>
5555
5556 * buffer.c (syms_of_buffer): Remove obsolete comment.
5557
5558 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5559
5560 * termhooks.h (encode_terminal_code): Declare prototype.
5561
5562 * msdos.c (encode_terminal_code): Don't declare prototype.
5563
5564 * term.c (encode_terminal_code): Now external again, used by
5565 w32console.c and msdos.c.
5566
5567 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5568 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5569
5570 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5571
5572 Fix some minor problems found by GCC 4.5.2's static checks.
5573
5574 * fringe.c (update_window_fringes): Mark locals as initialized
5575 (Bug#8227).
5576 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5577
5578 * alloc.c (mark_fringe_data): Move decl from here ...
5579 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5580 to check its interface.
5581 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5582
5583 * fontset.c (free_realized_fontset): Now static.
5584 (Fset_fontset_font): Rename local to avoid shadowing.
5585 (fontset_font): Mark local as initialized.
5586 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5587
5588 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5589
5590 * xselect.c (x_disown_buffer_selections): Remove; not used.
5591 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5592 (x_own_selection, Fx_disown_selection_internal): Rename locals
5593 to avoid shadowing.
5594 (x_handle_dnd_message): Remove local to avoid shadowing.
5595
5596 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5597 so that the caller can use some name other than gcpro1.
5598 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5599 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5600 (Fx_backspace_delete_keys_p):
5601 Use them to avoid shadowing, and rename vars to avoid shadowing.
5602 (x_decode_color, x_set_name, x_window): Now static.
5603 (Fx_create_frame): Add braces to silence GCC warning.
5604 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5605 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5606 Remove unused locals.
5607 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5608 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5609 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5610 macros.
5611
5612 * xterm.h (x_mouse_leave): New decl.
5613
5614 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5615 Remove unused functions.
5616 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5617 (x_calc_absolute_position): Now static.
5618 (XTread_socket): Don't define label "out" unless it's used.
5619 Don't declare local "event" unless it's used.
5620 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5621 unless they are used.
5622 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5623 (x_fatal_error_signal): Remove; not used.
5624 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5625 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5626 (x_error_catcher, x_connection_closed, x_error_handler):
5627 (x_error_quitter, xembed_send_message, x_iconify_frame):
5628 (my_log_handler): Rename locals to avoid shadowing.
5629 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5630 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5631
5632 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5633 Rename or move locals to avoid shadowing.
5634 (tty_defined_color, merge_face_heights): Now static.
5635 (free_realized_faces_for_fontset): Remove; not used.
5636 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5637 does not deduce is never used uninitialized.
5638 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5639 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5640
5641 * terminal.c (store_terminal_param): Now static.
5642
5643 * xmenu.c (menu_highlight_callback): Now static.
5644 (set_frame_menubar): Remove unused local.
5645 (xmenu_show): Rename parameter to avoid shadowing.
5646 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5647 since they might point to immutable storage.
5648 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5649 since it's unused otherwise.
5650
5651 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5652 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5653 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5654 avoids a gcc -Wuninitialized diagnostic.
5655 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5656 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5657 does not deduce are never used uninitialized.
5658
5659 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5660
5661 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5662 * window.c (window_loop, size_window):
5663 (run_window_configuration_change_hook, enlarge_window): Likewise.
5664
5665 * window.c (display_buffer): Now static.
5666 (size_window): Mark variables that gcc -Wuninitialized
5667 does not deduce are never used uninitialized.
5668 * window.h (check_all_windows): New decl, to forestall
5669 gcc -Wmissing-prototypes diagnostic.
5670 * dispextern.h (bidi_dump_cached_states): Likewise.
5671
5672 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5673 shadowing.
5674 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5675 Include <limits.h>.
5676 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5677 and to avoid gcc -Wuninitialized warning.
5678 (load_charset_map): Mark variables that gcc -Wuninitialized
5679 does not deduce are never used uninitialized.
5680 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5681
5682 * coding.c (coding_set_source, coding_set_destination):
5683 Use "else { /* comment */ }" rather than "else /* comment */;"
5684 for clarity, and to avoid gcc -Wempty-body warning.
5685 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5686 a block, when the outer 'i' will do.
5687 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5688 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5689 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5690 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5691 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5692 Rename locals to avoid shadowing.
5693 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5694 * coding.c (emacs_mule_char, encode_invocation_designation):
5695 Now static, since they're not used elsewhere.
5696 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5697 (decode_coding_object, encode_coding_object, detect_coding_system):
5698 (decode_coding_emacs_mule): Mark variables that gcc
5699 -Wuninitialized does not deduce are never used uninitialized.
5700 (detect_coding_iso_2022): Initialize a local variable that might
5701 be used uninitialized. Leave a FIXME because it's not clear that
5702 this initialization is needed. (Bug#8211)
5703 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5704 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5705 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5706 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5707 Remove unused macros.
5708
5709 * category.c (hash_get_category_set): Remove unused local var.
5710 (copy_category_table): Now static, since it's not used elsewhere.
5711 * character.c (string_count_byte8): Likewise.
5712
5713 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5714 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5715
5716 * chartab.c (copy_sub_char_table): Now static, since it's not used
5717 elsewhere.
5718 (sub_char_table_ref_and_range, char_table_ref_and_range):
5719 Rename locals to avoid shadowing.
5720 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5721
5722 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5723 (BIDI_BOB): Remove unused macro.
5724
5725 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5726 deduce are never used uninitialized.
5727 * term.c (encode_terminal_code): Likewise.
5728
5729 * term.c (encode_terminal_code): Now static. Remove unused local.
5730
5731 * tparam.h: New file.
5732 * term.c, tparam.h: Include it.
5733 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5734 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5735 Move these decls to tparam.h, and make them agree with what
5736 is actually in tparam.c. The previous trick of using incompatible
5737 decls in different modules does not conform to the C standard.
5738 All callers of tparam changed to use tparam's actual API.
5739 * tparam.c (tparam1, tparam, tgoto):
5740 Use const pointers where appropriate.
5741
5742 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5743 * cm.h (struct cm): Likewise.
5744 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5745 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5746 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5747 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5748 (turn_on_face, init_tty): Likewise.
5749 * termchar.h (struct tty_display_info): Likewise.
5750
5751 * term.c (term_mouse_position): Rename local to avoid shadowing.
5752
5753 * alloc.c (mark_ttys): Move decl from here ...
5754 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5755
5756 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5757
5758 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5759
5760 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5761
5762 * search.c (compile_pattern_1): Remove argument regp, unused since
5763 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5764 (compile_pattern): Don't pass it.
5765
5766 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5767
5768 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5769 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5770 for ! HAVE_GTK3.
5771 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5772
5773 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5774
5775 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5776 gdk_window_get_screen, gdk_window_get_geometry,
5777 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5778 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5779 (xg_get_pixbuf_from_pixmap): New function.
5780 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5781 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5782 Call xg_get_pixbuf_from_pixmap instead of
5783 gdk_pixbuf_get_from_drawable.
5784 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5785 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5786 (xg_check_special_colors): Use GtkStyleContext and its functions
5787 for HAVE_GTK3.
5788 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5789 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5790 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5791 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5792 Call gtk_widget_get_preferred_size.
5793 (xg_frame_resized): gdk_window_get_geometry only takes 5
5794 parameters.
5795 (xg_win_to_widget, xg_event_is_for_menubar):
5796 Call gdk_x11_window_lookup_for_display.
5797 (xg_set_widget_bg): New function.
5798 (delete_cb): New function.
5799 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5800 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5801 (xg_set_background_color): Call xg_set_widget_bg.
5802 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5803 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5804 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5805 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5806 if ! HAVE_GTK3.
5807 (update_frame_tool_bar): Call gtk_widget_hide.
5808 (xg_initialize): Use GDK_KEY_g.
5809
5810 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5811 if ! HAVE_GTK3
5812 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5813
5814 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5815 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5816 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5817
5818 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5819
5820 * w32xfns.c (select_palette): Check success of RealizePalette against
5821 GDI_ERROR, not zero.
5822
5823 See ChangeLog.11 for earlier changes.
5824
5825 ;; Local Variables:
5826 ;; coding: utf-8
5827 ;; End:
5828
5829 Copyright (C) 2011 Free Software Foundation, Inc.
5830
5831 This file is part of GNU Emacs.
5832
5833 GNU Emacs is free software: you can redistribute it and/or modify
5834 it under the terms of the GNU General Public License as published by
5835 the Free Software Foundation, either version 3 of the License, or
5836 (at your option) any later version.
5837
5838 GNU Emacs is distributed in the hope that it will be useful,
5839 but WITHOUT ANY WARRANTY; without even the implied warranty of
5840 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5841 GNU General Public License for more details.
5842
5843 You should have received a copy of the GNU General Public License
5844 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.