1 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (start_display): If the character at POS is displayed
4 via a display vector, reset IT->current.dpvec_index to zero.
5 (try_window_reusing_current_matrix): If a line ends in a display
6 vector or the next line starts in a display vector, continue
7 redrawing the window even though the character position of
11 2011-10-18 Chong Yidong <cyd@gnu.org>
13 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
14 with nobreak-char-display too.
16 2011-10-18 Eli Zaretskii <eliz@gnu.org>
18 Fix part 3 of bug#9771.
19 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
20 (bidi_resolve_neutral): Don't enter the expensive loop looking for
21 non-neutral characters if the current character is a paragraph
22 separator (a.k.a. Newline). This avoids running the same
23 expensive loop twice, once when we consume the preceding newline
24 and the other time when the line actually needs to be displayed.
25 Avoid the loop when we see neutrals on the base embedding level
26 following a character whose directionality is the same as the
27 paragraph's. This avoids running the expensive loop when a line
28 ends in a long sequence of neutrals, like control characters.
29 Add assertion against STRONG_AL type. Slightly rearrange code
30 that determines the type of a neutral given the first non-neutral
32 (bidi_level_of_next_char): Set next_en_pos to zero when
33 invalidating its info.
35 2011-10-17 Eli Zaretskii <eliz@gnu.org>
37 * xdisp.c (push_display_prop): Determine whether to record string
38 or buffer position by IT->string, not by IT->method. Allow
39 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
40 (move_it_vertically_backward): Don't look for character position
41 immediately after the newline when in a continuation line.
44 2011-10-15 Martin Rudalics <rudalics@gmx.at>
46 * window.c (coordinates_in_window): Rewrite and delabelize
47 vertical border check. (Bug#5357) (Bug#9618)
49 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
51 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
52 errors in XSetWindowBorder (bug#9310).
54 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
56 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
57 avoid crash when xmalloc overrun checking is enabled.
59 2011-10-13 Eli Zaretskii <eliz@gnu.org>
61 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
62 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
63 cursor motion with <left> and <right> arrow keys.
65 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
66 some callers set that themselves.
68 2011-10-12 Eli Zaretskii <eliz@gnu.org>
70 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
71 display string and the previous row comes from the same string and
72 is empty. (Bug#9739) (Bug#9738)
74 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
76 * doc.c (get_doc_string): Encode file name (bug#9735).
78 2011-10-12 Eli Zaretskii <eliz@gnu.org>
80 * bidi.c (bidi_level_of_next_char):
81 * xdisp.c (get_visually_first_element): Remove old incorrect
82 comments regarding the Unicode Line Separator character.
84 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
86 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
88 * alloc.c (Fgc_status): Do not access beyond zombies array
89 boundary if nzombies > MAX_ZOMBIES.
90 * alloc.c (dump_zombies): Add missing format specifier.
92 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
94 * xdisp.c (set_cursor_from_row): Simplify conditionals,
95 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
97 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
98 Some packages use them to denote characters with modifiers.
100 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
102 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
103 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
104 matching a pp-number. Rename parameter var to var1.
106 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
108 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
110 2011-10-08 Glenn Morris <rgm@gnu.org>
112 * callint.c (Fcall_interactively): Give a more explicit error for the
113 'c' case with a non-character input. (Bug#8479)
115 2011-10-08 Eli Zaretskii <eliz@gnu.org>
117 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
119 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
120 lines that are hscrolled on the left.
122 * dispnew.c (buffer_posn_from_coords): Account for a possible
123 presence of header-line. (Bug#4426)
125 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
127 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
128 Don't advertise functionality which we discourage or doesn't work.
130 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
132 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
133 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
134 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
135 this makes Emacs dump core during garbage collection on rare
136 occasions. sizeof is obviously inferior to offsetof here, so
138 (GC_POINTER_ALIGNMENT): New macro.
139 (mark_memory): Omit 3rd (offset) arg; caller changed.
140 Don't assume EMACS_INT alignment is the same as pointer alignment.
142 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
144 * keyboard.c (read_key_sequence_remapped): New var.
145 (read_key_sequence): Compute remapping in the right buffer.
146 (command_loop_1): Use read_key_sequence's remapping directly.
148 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
150 * dired.c (file_name_completion): Don't expand file name.
151 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
152 before checking file name handler.
154 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
155 they've been requested explicitly (bug#9591).
157 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
159 * keymap.c (Fsingle_key_description): Use make_specified_string
160 instead of build_string to build string from push_key_description.
163 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
165 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
166 This fixes a Y2038 bug on 64-bit hosts.
167 * buffer.c (reset_buffer):
168 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
169 (Fclear_buffer_auto_save_failure):
170 Use 0, not -1, to represent an unset failure time, since time_t
173 Remove dependency on glibc malloc internals.
174 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
175 Move back here from lisp.h, but with their new implementations.
176 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
177 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
178 * charset.c (charset_table_init): New static var.
179 (syms_of_charset): Use it instead of xmalloc. This removes a
180 dependency on glibc malloc internals. See Eli Zaretskii's comment in
181 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
182 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
183 Move back to alloc.c.
184 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
185 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
187 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
189 * nsterm.m (windowDidResize): Call x_set_window_size only when
190 ns_in_resize is true. Otherwise set pixelwidth/height and
191 call change_frame_size (Bug#9628).
193 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
195 Port --enable-checking=all to Fedora 14 x86-64.
196 * charset.c (syms_of_charset): Also account for glibc malloc's
197 internal overhead when calculating the initial malloc maximum.
199 Port --enable-checking=all to Fedora 14 x86.
200 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
202 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
203 (overrun_check_realloc, overrun_check_free):
204 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
205 That way, xmalloc returns a properly-aligned pointer even if
206 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
207 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
208 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
209 into account when calculating the initial malloc maximum.
210 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
211 Move here from alloc.c, so that charset.c can use it too.
212 Properly align; the old code wasn't right for common 32-bit hosts
213 when configured with --enable-checking=all.
214 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
215 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
217 2011-09-29 Eli Zaretskii <eliz@gnu.org>
219 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
222 2011-09-28 Eli Zaretskii <eliz@gnu.org>
224 * xdisp.c (compute_display_string_end): If there's no display
225 string at CHARPOS, return -1.
227 * bidi.c (bidi_fetch_char): When compute_display_string_end
228 returns a negative value, treat the character as a normal
229 character not covered by a display string. (Bug#9624)
231 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
233 * lread.c (Fread_from_string): Fix typo in docstring.
235 2011-09-27 Eli Zaretskii <eliz@gnu.org>
237 * xdisp.c (handle_invisible_prop): If invisible text ends on a
238 newline, reseat the iterator instead of bidi-iterating there one
239 character at a time. (Bug#9610)
240 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
241 TO_CHARPOS if the bidi iterator is at base embedding level.
243 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
245 * lread.c (readevalloop): Use correct code for NBSP.
246 (read1): Likewise. (Bug#9608)
248 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
250 * dbusbind.c (Fdbus_register_signal): When service is not
251 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
253 2011-09-25 Glenn Morris <rgm@gnu.org>
255 * buffer.c (truncate-lines): Doc fix.
257 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
259 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
260 (Fset_window_next_buffers): Doc fix.
262 2011-09-24 Glenn Morris <rgm@gnu.org>
264 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
266 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
268 Fix minor problems found by static checking.
269 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
270 * indent.c (Fvertical_motion): Fix == vs = typo.
272 2011-09-24 Eli Zaretskii <eliz@gnu.org>
274 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
275 Default value is now t. Doc fix.
277 * indent.c (Fvertical_motion): Compute and apply the overshoot
278 logic when moving up, not only when moving down. Fix the
279 confusing name and values of the it_overshoot_expected variable;
280 logic changes accordingly. (Bug#9254) (Bug#9549)
282 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
283 CHARPOS is covered by a display string which includes newlines.
284 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
285 is covered by a display string with embedded newlines.
287 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
289 * dbusbind.c (Fdbus_register_signal): Add match rule to
290 Vdbus_registered_objects_table. (Bug#9581)
291 (Fdbus_register_method, Vdbus_registered_objects_table):
294 2011-09-24 Jim Meyering <meyering@redhat.com>
296 do not ignore write error for any output size
297 The previous change was incomplete.
298 While it makes emacs --batch detect the vast majority of stdout
299 write failures, errors were still ignored whenever the output size is
300 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
301 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
302 && echo FAIL: ignored write error
303 FAIL: ignored write error
304 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
305 && echo FAIL: ignored write error
306 FAIL: ignored write error
307 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
309 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
311 * emacs.c (Fkill_emacs): In noninteractive mode exit
312 non-successfully if a write error occurred on stdout. (Bug#9574)
314 2011-09-21 Eli Zaretskii <eliz@gnu.org>
316 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
319 * dispextern.h (struct it): Update the comment documenting what
322 2011-09-20 Eli Zaretskii <eliz@gnu.org>
324 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
325 a display string, extend search for cursor position to end of row.
326 (find_row_edges): If the row ends in a newline from a display
327 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
328 Handle the case of a display string with multiple newlines.
329 (Fcurrent_bidi_paragraph_direction): Fix search for previous
330 non-empty line. Fixes confusing cursor motion with arrow keys at
331 the beginning of a line that starts with whitespace.
333 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
335 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
338 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
340 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
343 2011-09-18 Eli Zaretskii <eliz@gnu.org>
345 * xdisp.c (display_line): Record maximum and minimum buffer
346 positions even if no glyphs were produced (e.g., by a zero-width
347 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
348 buffer positions that will be removed from the glyph row because
350 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
351 column is beyond frame width: don't subtract 1 "pixel" when
352 computing width of the stretch.
353 (reseat_at_next_visible_line_start): Undo the change made on
354 2011-09-17 that saved paragraph information and restored it after
355 the call to `reseat'. (Bug#9545)
357 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
359 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
360 and turn window cursor on if cleared (Bug#9415).
362 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
364 * search.c (boyer_moore): Take unibyte characters from pattern
365 literally. (Bug#9458)
367 2011-09-18 Eli Zaretskii <eliz@gnu.org>
369 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
371 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
373 Fix minor problem found by static checking.
374 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
375 initialized, to pacify gcc -Wuninitialized.
377 * fileio.c: Report proper errno when syscall falls.
378 (Finsert_file_contents): Save and restore errno,
379 so that report_file_error outputs the correct diagnostic.
380 (Fwrite_region) [CLASH_DETECTION]: Likewise.
382 2011-09-18 Eli Zaretskii <eliz@gnu.org>
384 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
386 2011-09-17 Eli Zaretskii <eliz@gnu.org>
388 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
389 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
391 2011-09-17 Eli Zaretskii <eliz@gnu.org>
393 * xdisp.c (reseat_at_next_visible_line_start): Keep information
394 about the current paragraph and restore it after the call to reseat.
396 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
397 (bidi_find_paragraph_start): Search back for paragraph beginning
398 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
399 (bidi_move_to_visually_next): Only trigger paragraph-related
400 computations when the last character is a newline or at EOB, not
401 just any NEUTRAL_B. (Bug#9470)
403 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
404 truncated lines if point is covered by a display string. (Bug#9524)
406 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
408 * xselect.c: Relax test for outgoing X longs (Bug#9498).
409 (cons_to_x_long): New function.
410 (lisp_data_to_selection_data): Use it. Correct the test for
411 short-versus-long data; it was negated. Break out of vector
412 loop, for efficiency, when a long datum is discovered.
414 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
416 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
418 2011-09-16 Eli Zaretskii <eliz@gnu.org>
420 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
421 GCC PR/17406) by declaring this function with external scope.
423 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
425 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
426 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
428 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
430 * editfns.c (Fformat): Correctly handle text properties on "%%".
432 2011-09-15 Eli Zaretskii <eliz@gnu.org>
434 * xterm.c (x_draw_composite_glyph_string_foreground):
435 * w32term.c (x_draw_composite_glyph_string_foreground):
436 * term.c (encode_terminal_code):
437 * composite.c (composition_update_it, get_composition_id):
438 * xdisp.c (get_next_display_element)
439 (fill_composite_glyph_string): Add comments about special meaning
440 of TAB characters in a composition.
442 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
444 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
445 This occurs when processing a multibyte format.
446 Problem reported by Wolfgang Jenker.
448 2011-09-15 Johan Bockgård <bojohan@gnu.org>
450 * xdisp.c (try_cursor_movement): Only check for exact match if
451 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
453 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
455 Remove unused external symbols.
456 * dispextern.h (calc_pixel_width_or_height): Remove decl.
457 * xdisp.c (calc_pixel_width_or_height): Now static.
458 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
459 * indent.c (check_display_width):
460 * w32term.c: Fix comment to match code.
461 * xterm.c, xterm.h (x_catching_errors): Remove.
463 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
465 * xselect.c: Use signed conversions more consistently (Bug#9498).
466 (selection_data_to_lisp_data): Assume incoming selection data are
467 signed integers, not unsigned. This is to be consistent with
468 outgoing selection data, which was modified to use signed integers
469 in as part of the fix to Bug#9196 in response to Jan D.'s comment
470 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
471 expects long, not unsigned long.
473 2011-09-14 Eli Zaretskii <eliz@gnu.org>
475 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
476 computation of loop end. Reported by Johan Bockgård
479 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
481 * frame.c (Fother_visible_frames_p): Function deleted.
483 2011-09-12 Eli Zaretskii <eliz@gnu.org>
485 * indent.c (compute_motion): Process display vector front to back
486 rather than the other way around. (Bug#2496)
488 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
490 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
492 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
494 * minibuf.c (Fread_from_minibuffer): Doc fix.
496 2011-09-11 Eli Zaretskii <eliz@gnu.org>
498 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
499 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
501 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
503 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
504 value for non-existent files.
506 2011-09-11 Eli Zaretskii <eliz@gnu.org>
508 * fileio.c (Finsert_file_contents): If the file cannot be opened,
509 set its "size" to -1. This will set the modtime_size field of
510 the corresponding buffer to -1, which is what
511 verify-visited-file-modtime expects for files that do not exist.
514 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
516 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
518 * lisp.h: ... from here. push_key_description is no longer
519 defined in keyboard.c, so its declaration should not be in
520 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
521 logically belongs with push_key_description.
523 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
525 * buffer.h: Include <sys/types.h> instead of <time.h>.
526 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
527 Problem reported by Herbert J. Skuhra.
529 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
531 * xml.c (parse_region): Make the parsing work for
532 non-comment-starting XML files again (bug#9144).
534 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
536 * image.c (gif_load): Fix calculation of bottom and right corner.
539 2011-09-10 Eli Zaretskii <eliz@gnu.org>
541 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
542 redisplay in small windows.
544 2011-09-09 Eli Zaretskii <eliz@gnu.org>
546 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
548 2011-09-08 Martin Rudalics <rudalics@gmx.at>
550 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
551 Operate on live windows only.
553 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
555 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
557 2011-09-07 Eli Zaretskii <eliz@gnu.org>
559 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
560 only under bidi iteration.
562 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
564 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
566 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
568 isnan: Fix porting problem to Solaris 10 with bundled gcc.
569 Without this fix, the command to link temacs failed due to an
570 undefined symbol __builtin_isnan. This is because
571 /usr/include/iso/math_c99.h #defines isnan(x) to
572 __builtin_isnan(x), but the bundled gcc, which identifies itself
573 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
575 * floatfns.c (isnan): #undef, and then #define to a clone of
577 (Fisnan): Always define, since it's always available now.
578 (syms_of_floatfns): Always define isnan at the Lisp level.
580 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
582 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
584 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
586 * fileio.c: Fix bugs with large file offsets (Bug#9428).
587 The previous code assumed that file offsets (off_t values) fit in
588 EMACS_INT variables, which is not true on typical 32-bit hosts.
589 The code messed up by falsely reporting buffer overflow in cases
590 such as (insert-file-contents "big" nil 1 2) into an empty buffer
591 when "big" contains more than 2**29 bytes, even though this
592 inserts just one byte and does not overflow the buffer.
593 (Finsert_file_contents): Store file offsets as off_t
594 values, not as EMACS_INT values. Check for overflow when
595 converting between EMACS_INT and off_t. When checking for
596 buffer overflow or for overlap, take the offsets into account.
597 Don't use EMACS_INT for small values where int suffices.
598 When checking for overlap, fix a typo: ZV was used where
599 ZV_BYTE was intended.
600 (Fwrite_region): Don't assume off_t fits into 'long'.
601 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
603 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
605 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
607 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
609 sprintf-related integer and memory overflow issues (Bug#9412).
611 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
612 (esprintf, exprintf, evxprintf): New functions.
613 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
614 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
615 (modify_event_symbol): Do not assume that the length of
616 name_alist_or_stem is safe to alloca and fits in int.
617 (Fexecute_extended_command): Likewise for function name and binding.
618 (Frecursion_depth): Wrap around reliably on integer overflow.
619 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
620 since some callers pass EMACS_INT values.
621 (Fsingle_key_description): Don't crash if symbol name contains more
622 than MAX_ALLOCA bytes.
623 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
624 (get_minibuffer): Arg is now EMACS_INT, not int.
625 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
626 (esprintf, exprintf, evxprintf): New decls.
627 * window.h (command_loop_level, minibuf_level): Reflect API changes.
629 * dbusbind.c (signature_cat): New function.
630 (xd_signature, Fdbus_register_signal):
631 Do not overrun buffer; instead, report string overflow.
633 * dispnew.c (add_window_display_history): Don't overrun buffer.
634 Truncate instead; this is OK since it's just a log.
636 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
637 even if the time zone offset is outlandishly large.
638 Don't mishandle offset == INT_MIN.
640 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
641 when creating daemon; the previous buffer-overflow check was incorrect.
643 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
644 which has the guts of the old verror function.
646 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
647 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
649 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
650 (font_unparse_xlfd): Don't blindly alloca long strings.
651 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
652 fits in int, when using sprintf. Use single snprintf to count
653 length of string rather than counting it via multiple sprintfs;
654 that's simpler and more reliable.
655 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
656 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
657 sprintf, in case result does not fit in int.
659 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
660 (fontset_from_font): Print it.
662 * frame.c (tty_frame_count): Now printmax_t, not int.
663 (make_terminal_frame, set_term_frame_name): Print it.
664 (x_report_frame_params): In X, window IDs are unsigned long,
665 not signed long, so print them as unsigned.
666 (validate_x_resource_name): Check for implausibly long names,
667 and don't assume name length fits in 'int'.
668 (x_get_resource_string): Don't blindly alloca invocation name;
669 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
672 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
673 (xg_check_special_colors, xg_set_geometry):
674 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
676 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
677 Use esprintf, not sprintf, in case result does not fit in int.
679 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
680 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
681 it as a large positive number.
682 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
683 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
685 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
686 in case result does not fit in int.
688 * print.c (float_to_string): Detect width overflow more reliably.
689 (print_object): Make sprintf buffer a bit bigger, to avoid potential
690 buffer overrun. Don't assume list length fits in 'int'. Treat
691 print length of 0 as 0, not as infinity; to be consistent with other
692 uses of print length in this function. Don't overflow print length
693 index. Don't assume hash table size fits in 'long', or that
694 vectorlike size fits in 'unsigned long'.
696 * process.c (make_process): Use printmax_t, not int, to format
697 process-name gensyms.
699 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
701 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
702 to avoid potential buffer overrun.
704 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
705 if X resource line is longer than 512 bytes.
707 * xfns.c (x_window): Make sprintf buffer a bit bigger
708 to avoid potential buffer overrun.
710 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
712 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
714 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
716 Integer overflow fixes for scrolling, etc.
717 Without these, Emacs silently mishandles large integers sometimes.
718 For example, "C-u 4294967297 M-x recenter" was treated as if
719 it were "C-u 1 M-x recenter" on a typical 64-bit host.
721 * xdisp.c (try_window_id): Check Emacs fixnum range before
724 * window.c (window_scroll_line_based, Frecenter):
725 Check that an Emacs fixnum is in range before assigning it to 'int'.
726 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
727 values converted from Emacs fixnums.
728 (Frecenter): Don't wrap around a line count if it is out of 'int'
729 range; instead, treat it as an extreme value.
730 (Fset_window_configuration, compare_window_configurations):
731 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
733 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
734 that can exceed INT_MAX. Check that EMACS_INT value is in range
735 before assigning it to the (possibly-narrower) index.
736 (match_limit): Don't assume that a fixnum can fit in 'int'.
738 * print.c (print_object): Use ptrdiff_t, not int, for index that can
741 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
742 (Fvertical_motion): Don't wrap around LINES values that don't fit
743 in 'int'. Instead, treat them as extreme values. This is good
744 enough for windows, which can't have more than INT_MAX lines anyway.
746 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
748 * Require libxml/parser.h to avoid compilation warning.
750 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
752 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
753 since this reportedly can destroy thread storage.
755 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
757 * syntax.c (find_defun_start): Update all cache variables if
758 exiting early (Bug#9401).
760 2011-08-30 Eli Zaretskii <eliz@gnu.org>
762 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
764 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
765 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
766 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
768 * term.c (tty_append_glyph): New function.
769 (produce_stretch_glyph): Static function and its prototype deleted.
771 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
774 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
776 * image.c (parse_image_spec): Check for nonnegative, not for positive,
777 when checking :margin (Bug#9390).
778 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
779 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
780 so that the name doesn't mislead. All uses changed.
782 2011-08-28 Johan Bockgård <bojohan@gnu.org>
784 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
787 2011-08-27 Eli Zaretskii <eliz@gnu.org>
789 * xdisp.c (move_it_to): Don't bail out early when reaching
790 position beyond to_charpos, if we are scanning backwards.
791 (move_it_vertically_backward): When DY == 0, make sure we get to
792 the first character in the line after the newline.
794 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
796 * ccl.c: Improve and simplify overflow checking (Bug#9196).
797 (ccl_driver): Do not generate an out-of-range pointer.
798 (Fccl_execute_on_string): Remove unnecessary check for
799 integer overflow, noted by Stefan Monnier in
800 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
801 Remove a FIXME that didn't need fixing.
802 Simplify the newly-introduced buffer reallocation code.
804 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
806 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
808 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
810 Integer and memory overflow issues (Bug#9196).
812 * doc.c (get_doc_string): Rework so that
813 get_doc_string_buffer_size is the actual buffer size, rather than
814 being 1 less than the actual buffer size; this makes xpalloc more
817 * image.c (x_allocate_bitmap_record, cache_image):
818 * xselect.c (Fx_register_dnd_atom):
819 Simplify previous changes by using xpalloc.
821 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
822 since either will do and ptrdiff_t is convenient with xpalloc.
824 * charset.c (charset_table_size)
825 (struct charset_sort_data.priority): Now ptrdiff_t.
826 (charset_compare): Don't overflow if priorities differ greatly.
827 (Fsort_charsets): Don't assume list length fits in int.
828 Check for size-calculation overflow when allocating sort data.
829 (syms_of_charset): Allocate an initial charset table that is
830 just under 64 KiB, to avoid problems with glibc malloc and mmap.
832 * cmds.c (internal_self_insert): Check for size-calculation overflow.
834 * composite.h (struct composition.glyph_len): Now int, not unsigned.
835 The actual value is always <= INT_MAX, and leaving it unsigned made
836 overflow checking harder.
838 * dispextern.h (struct glyph_matrix.rows_allocated)
839 (struct face_cache.size): Now ptrdiff_t, for convenience in use
840 with xpalloc. The values are still always <= INT_MAX.
842 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
844 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
845 (SAFE_NALLOCA): New macro.
847 * region-cache.c (struct boundary.pos, find_cache_boundary)
848 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
849 (set_cache_region, invalidate_region_cache)
850 (revalidate_region_cache, know_region_cache, region_cache_forward)
851 (region_cache_backward, pp_cache):
852 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
853 so that ptrdiff_t * can be passed to xpalloc.
854 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
855 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
856 (pp_cache): Don't assume cache_len fits in int.
857 * region-cache.h: Adjust extern decls to match.
859 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
860 EMACS_INT, since either will do, for xpalloc.
862 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
863 (xnmalloc, xnrealloc, xpalloc): New functions.
865 * bidi.c (bidi_shelve_header_size): New constant.
866 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
867 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
869 * bidi.c (bidi_cache_shrink):
870 * buffer.c (overlays_at, overlays_in, record_overlay_string)
872 Don't update size of array until after memory allocation succeeds,
873 because xmalloc/xrealloc may not return.
874 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
875 now that we have proper integer overflow checking.
876 (record_overlay_string, overlay_strings): Catch overflows when
877 calculating size of overlay_str_buf.
879 * callproc.c (Fcall_process): Check for size overflow when
880 calculating size of args2.
881 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
882 Normally we prefer signed values, but sticking with ptrdiff_t would
883 require adding more-complicated checks.
885 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
886 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
887 Redo buffer-overflow calculations to avoid integer overflow.
888 Add a FIXME comment where memory seems to be over-allocated.
890 * character.c (Fstring): Check for size-calculation overflow.
892 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
893 unnecessary integer overflow. Check for size overflow.
894 (encode_coding_object): Don't update size until xmalloc succeeds.
896 * composite.c (get_composition_id): Check for overflow in glyph
899 Integer and memory overflow fixes for display code.
900 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
901 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
902 (scrolling_window): Check for overflow in size calculations.
903 (line_draw_cost, realloc_glyph_pool, add_row_entry):
904 Don't assume glyph table len fits in int.
905 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
906 (row_table_size): Now ptrdiff_t, not int.
907 (scrolling_window): Avoid overflow in size calculations.
908 Don't update size until allocation succeeds.
909 * fns.c (concat): Check for overflow in size calculations.
910 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
911 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
912 (NEXT_ALMOST_PRIME_LIMIT): New constant.
914 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
915 (get_doc_string): Check for size calculation overflow.
916 Don't update size until allocation succeeds.
917 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
918 EMACS_INT, where ptrdiff_t will do.
919 (Fsubstitute_command_keys): Check for string overflow.
921 * editfns.c (set_time_zone_rule): Don't assume environment length
923 (message_length): Now ptrdiff_t, not int.
924 (Fmessage_box): Don't update size until allocation succeeds.
925 Don't assume message length fits in int.
926 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
928 * emacs.c (main): Do not reallocate argv, since there is a null at
929 the end that can be overwritten, and this way there's no need to
930 worry about size-calculation overflow.
931 (sort_args): Check for size-calculation overflow.
933 * eval.c (init_eval_once, grow_specpdl): Don't update size until
935 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
937 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
938 (x_set_scroll_bar_width, x_figure_window_size):
939 Check for integer overflow.
940 (x_set_alpha): Do not assume XINT fits in int.
942 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
943 This is for the members text_lines, text_cols, total_lines, total_cols,
944 where the system imposes an 'int' limit.
946 * fringe.c (Fdefine_fringe_bitmap):
947 Don't update size until alloc works.
949 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
950 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
952 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
953 Check for size-calculation overflow.
954 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
955 do, as we prefer signed integers.
956 (id_to_widget.max_size, id_to_widget.used)
957 (xg_store_widget_in_map, xg_remove_widget_from_map)
958 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
959 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
960 Use and return ptrdiff_t, not int.
961 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
962 * gtkutil.h: Change prototypes to match the above.
964 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
965 are duplicate now that they've been promoted to lisp.h.
966 (x_allocate_bitmap_record, x_alloc_image_color)
967 (make_image_cache, cache_image, xpm_load):
968 Don't update size until alloc is done.
969 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
971 Check for size calculation overflow.
972 (ct_colors_allocated_max): New constant.
973 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
976 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
977 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
978 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
979 Use ptrdiff_t, not int, to count maps.
980 (read_char_minibuf_menu_prompt): Check for overflow in size
981 calculations. Don't update size until allocation succeeds.
982 Redo calculations to avoid overflow.
983 * keyboard.h: Change prototypes to match the above.
985 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
987 (current_minor_maps): Check for size calculation overflow.
988 * keymap.h: Change prototypes to match the above.
990 * lread.c (read1, init_obarray): Don't update size until alloc done.
992 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
993 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
995 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
996 Now ptrdiff_t, not int.
997 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
998 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1000 * process.c (Fnetwork_interface_list): Check for overflow
1001 in size calculation.
1003 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1005 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1006 overflow. Don't bother calling xmalloc when xrealloc will do.
1008 * search.c (Freplace_match): Check for size calculation overflow.
1009 (Fset_match_data): Don't assume list lengths fit in 'int'.
1011 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1012 for command line length. Do not attempt to address one before the
1013 beginning of an array, as that's not portable.
1015 * term.c (max_frame_lines): Remove; unused.
1016 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1018 (encode_terminal_code, calculate_costs): Check for size
1019 calculation overflow.
1020 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1021 table lengths and related sizes. Don't update size until alloc
1022 done. Redo calculations to avoid overflow.
1023 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1025 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1026 subtracting pointers.
1027 (gobble_line): Check for overflow more carefully. Don't update size
1030 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1031 Don't update size until alloc done.
1032 Redo size calculations to avoid overflow.
1033 Check for size calculation overflow.
1034 (main) [DEBUG]: Fix typo in invoking tparam1.
1036 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1037 Use ptrdiff_t, not int, for sizes.
1038 (store_mode_line_noprop_char): Don't update size until alloc done.
1040 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1041 Use ptrdiff_t, not int, for sizes.
1042 (Finternal_make_lisp_face, cache_face):
1043 Check for size calculation overflow.
1044 (cache_face): Treat size calculation overflows as if they were
1045 memory exhaustion (the usual treatment), rather than aborting.
1047 * xfns.c (x_encode_text, x_set_name_internal)
1048 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1049 sizes, since they can exceed INT_MAX in size. Check for size
1050 calculation overflow.
1052 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1053 (xg_select): Check for size calculation overflow.
1054 Don't update size until alloc done.
1056 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1057 as sprintf is limited to int lengths.
1059 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1060 (X_LONG_MIN): New macros.
1061 Use them to make the following changes clearer.
1062 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1063 This change doesn't affect the value now, but it may help remind
1064 future maintainers not to raise the value too much later.
1065 (SELECTION_QUANTUM): Remove, replacing with ...
1066 (selection_quantum): ... new function, which avoids overflow.
1068 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1069 assumption that selection length fits in 'int'.
1070 (x_reply_selection_request, x_handle_selection_request)
1071 (x_get_window_property, receive_incremental_selection)
1072 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1073 (lisp_data_to_selection_data, clean_local_selection_data):
1074 Use ptrdiff_t, not int, to record length of selection.
1075 (x_reply_selection_request, x_get_window_property)
1076 (receive_incremental_selection, x_property_data_to_lisp):
1077 Redo calculations to avoid overflow.
1078 (x_reply_selection_request): When sending hint, ceiling it at
1079 X_LONG_MAX rather than relying on wraparound overflow to send
1081 (x_get_window_property, receive_incremental_selection)
1082 (lisp_data_to_selection_data, x_property_data_to_lisp):
1083 Check for size-calculation overflow.
1084 (x_get_window_property, receive_incremental_selection)
1085 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1086 Don't store size until memory allocation succeeds.
1087 (x_get_window_property): Plug memory leak on memory exhaustion.
1088 Don't double-block input; malloc is safe here. Don't assume 2**34
1089 - 4 fits in unsigned long. Add an xassert to check
1090 XGetWindowProperty overflow. Be more careful about overflow
1091 calculations, and distinguish size from memory overflow better.
1092 (receive_incremental_selection): When tracing, don't assume
1093 unsigned int is less than INT_MAX.
1094 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1095 harmful) conversions of unsigned short to int.
1096 (lisp_data_to_selection_data): Don't assume that integers
1097 in the range -65535 through -1 fit in an X unsigned short.
1098 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1099 result parameters unless successful. Rely on cons_to_unsigned
1100 to report problems with elements; the old code wasn't right anyway.
1101 (x_check_property_data): Check for int overflow; we cannot use
1102 a wider type due to X limits.
1103 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1105 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1107 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1108 (x_term_init): Check for size calculation overflow.
1109 (x_color_cells): Don't store size until memory allocation succeeds.
1110 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1111 Don't assume alloca size is less than MAX_ALLOCA.
1112 (x_term_init): Don't assume length fits in int (sprintf is limited
1115 Use ptrdiff_t for composition IDs.
1116 * character.c (lisp_string_width):
1117 * composite.c (composition_table_size, n_compositions)
1118 (get_composition_id, composition_gstring_from_id):
1119 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1120 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1121 * window.c (Frecenter):
1122 Use ptrdiff_t, not int, for composition IDs.
1123 * composite.c (get_composition_id): Check for integer overflow.
1124 * composite.h: Adjust prototypes to match the above changes.
1126 Use ptrdiff_t for hash table indexes.
1127 * category.c (hash_get_category_set):
1128 * ccl.c (ccl_driver):
1129 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1130 * coding.c (coding_system_charset_list, detect_coding_system):
1131 * coding.h (struct coding_system.id):
1132 * composite.c (get_composition_id, gstring_lookup_cache):
1133 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1134 * image.c (xpm_get_color_table_h):
1135 * lisp.h (hash_lookup, hash_put):
1136 * minibuf.c (Ftest_completion):
1137 Use ptrdiff_t for hash table indexes, not int (which is too
1138 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1139 32-bit --with-wide-int hosts).
1141 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1142 Add a FIXME comment about memory leaks.
1143 (syms_of_charset): Don't assume xmalloc returns.
1145 Don't assume that stated character widths fit in int.
1146 * character.c (Fchar_width, c_string_width, lisp_string_width):
1147 * character.h (CHAR_WIDTH):
1148 * indent.c (MULTIBYTE_BYTES_WIDTH):
1149 Use sanitize_char_width to avoid undefined and/or bad behavior
1150 with outlandish widths.
1151 * character.h (sanitize_tab_width): Rename from sanitize_width,
1152 now that we have two such functions. All uses changed.
1153 (sanitize_char_width): New inline function.
1155 Don't assume that tab-width fits in int.
1156 * character.h (sanitize_width): New inline function.
1157 (SANE_TAB_WIDTH): New macro.
1158 (ASCII_CHAR_WIDTH): Use it.
1159 * indent.c (sane_tab_width): Remove. All uses replaced by
1160 SANE_TAB_WIDTH (current_buffer).
1161 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1163 * fileio.c: Integer overflow issues with file modes.
1164 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1166 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1167 Remove unreachable code.
1168 (read_hex, load_charset_map_from_file): Check for integer overflow.
1170 * xterm.c: don't go over XClientMessageEvent limit
1171 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1172 (x_send_scroll_bar_event): Likewise. Check that the size does not
1173 exceed limits imposed by XClientMessageEvent, as well as the usual
1174 ptrdiff_t and size_t limits.
1176 * keyboard.c: Overflow, signedness and related fixes.
1177 (make_lispy_movement): Use same integer type in forward decl
1178 that is used in the definition.
1179 (read_key_sequence, keyremap_step):
1180 Change bufsize argument back to int, undoing my 2011-03-30 change.
1181 We prefer signed types, and int is wide enough here.
1182 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1183 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1184 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1185 length, not size_t. Use ptrdiff_t for index, not int.
1186 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1187 possibility of integer overflow.
1189 Overflow, signedness and related fixes for images.
1191 * dispextern.h (struct it.stack[0].u.image.image_id)
1192 (struct_it.image_id, struct image.id, struct image_cache.size)
1193 (struct image_cache.used, struct image_cache.ref_count):
1194 * gtkutil.c (update_frame_tool_bar):
1195 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1196 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1197 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1198 * nsmenu.m (update_frame_tool_bar):
1199 * xdisp.c (calc_pixel_width_or_height):
1200 * xfns.c (image_cache_refcount):
1201 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1202 on typical 64-bit hosts.
1204 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1205 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1206 Omit unnecessary casts to int.
1207 (parse_image_spec): Check that integers fall into 'int' range
1208 when the callers expect that.
1209 (image_ascent): Redo ascent calculation to avoid int overflow.
1210 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1211 (lookup_image): Remove unnecessary tests.
1212 (xbm_image_p): Locals are now of int, not EMACS_INT,
1213 since parse_image_check makes sure they fit into int.
1214 (png_load, gif_load, svg_load_image):
1215 Prefer int to unsigned where either will do.
1216 (tiff_handler): New function, combining the cores of the
1217 old tiff_error_handler and tiff_warning_handler.
1218 This function is rewritten to use vsnprintf and thereby avoid
1219 stack buffer overflows. It uses only the features of vsnprintf
1220 that are common to both POSIX and native Microsoft.
1221 (tiff_error_handler, tiff_warning_handler): Use it.
1222 (tiff_load, gif_load, imagemagick_load_image):
1223 Don't assume :index value fits in 'int'.
1224 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1225 (imagemagick_load_image): Check that crop parameters fit into
1226 the integer types that MagickCropImage accepts. Don't assume
1227 Vimagemagick_render_type has a nonnegative value. Don't assume
1228 size_t fits in 'long'.
1229 (gs_load): Use printmax_t to print the widest integers possible.
1230 Check for integer overflow when computing image height and width.
1232 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1234 * xdisp.c (redisplay_window): Don't force window start if point
1235 will be invisible in the resulting window. (Bug#9324)
1237 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1239 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1240 the display spec is of the form `(space ...)'.
1241 (handle_display_spec): Return the value returned by
1242 handle_single_display_spec, not just 1 or zero.
1243 (handle_single_display_spec): If the display spec is of the form
1244 `(space ...)', and specifies display in the text area, return 2
1246 (try_cursor_movement): Check for the need to scroll more
1247 accurately, and prefer exact match for point under bidi.
1248 Don't advance `row' beyond the last row of the window.
1250 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1251 into disp_prop; all users changed.
1253 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1254 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1255 for the text covered by the display property.
1257 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1259 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1260 Change return value to nil.
1261 (Frecord_buffer): Delete unused function.
1263 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1265 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1266 buffers, return left-to-right.
1267 (set_cursor_from_row): Consider candidate row a win if its glyph
1268 represents a newline and point is on that newline. Fixes cursor
1269 positioning on the newline at EOL of R2L text within L2R
1270 paragraph, and vice versa.
1271 (try_cursor_movement): Check continued rows, in addition to
1272 continuation rows. Fixes unwarranted scroll when point enters a
1273 continued line of R2L text within an L2R paragraph, or vice versa.
1274 (cursor_row_p): Consider the case of point being equal to
1275 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1276 from the end of a short line to the beginning of a continued line
1277 of R2L text within L2R paragraph.
1278 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1279 composed characters.
1281 * bidi.c (bidi_check_type): Use xassert.
1282 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1285 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1287 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1290 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1292 * nsfont.m (ns_otf_to_script): Fix typo.
1294 2011-08-22 Kenichi Handa <handa@m17n.org>
1296 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1297 extra slot even if the purpose is char-code-property-table.
1299 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1301 * xdisp.c (redisplay_window): When computing centering_position,
1302 account for the height of the header line. (Bug#8874)
1304 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1305 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1306 candidate is selected by the mouse, and that candidate has a
1307 composed character under the mouse.
1309 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1310 coordinates reported by pos-visible-in-window-p for a composed
1311 character in column zero.
1313 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1315 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1317 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1319 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1320 consider it a hit if to_charpos is anywhere in the range of the
1321 composed buffer positions.
1323 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1325 * image.c (gif_load): Don't assume that each subimage has the same
1326 dimensions as the base image. Handle disposal method that is
1327 "undefined" by the gif spec (Bug#9335).
1329 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1331 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1332 (Fcondition_case): Document `debug' symbol in error handler.
1334 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1336 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1337 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1338 from an Org mode buffer to a Speedbar frame.
1340 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1341 a composition, take its buffer position from IT->cmp_it.charpos.
1342 Fixes cursor positioning at the beginning of a line that begins
1343 with a composed character.
1345 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1347 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1348 character bidirectional type, use STRONG_L instead. Fixes crashes
1349 in a buffer produced by `describe-categories'.
1351 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1352 members before the level stack, so they would be saved and
1353 restored when copying iterator state. Fixes incorrect reordering
1354 around TABs covered by display properties.
1356 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1358 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1360 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1362 * eval.c (internal_condition_case, internal_condition_case_1)
1363 (internal_condition_case_2, internal_condition_case_n):
1364 Remove unnecessary aborts (Bug#9081).
1366 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1368 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1369 has no `load' handler, try opening the file locally. (Bug#9311)
1371 2011-08-16 Ken Brown <kbrown@cornell.edu>
1373 * gmalloc.c: Expand comment.
1375 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1377 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1378 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1380 2011-08-16 Ken Brown <kbrown@cornell.edu>
1382 Fix memory allocation problems in Cygwin build (Bug#9273).
1384 * unexcw.c ( __malloc_initialized): Declare external variable.
1385 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1387 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1389 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1391 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1393 [CYGWIN] (special_realloc): New function.
1394 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1395 requests to realloc storage in the static heap.
1397 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1399 * bidi.c (bidi_initialize): Remove unused local.
1401 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1404 * biditype.h: Remove file.
1405 * makefile.w32-in ($(BLD)/bidi.$(O)):
1406 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1408 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1410 * chartab.c: Improve commentary for the uniprop_table API.
1412 * bidi.c (bidi_paragraph_init): Support zero value of
1413 bidi_ignore_explicit_marks_for_paragraph_level.
1414 (bidi_initialize): Use uniprop_table instead of including
1415 biditype.h and bidimirror.h.
1417 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1418 coordinates of the iterator when restoring from ppos_it.
1421 2011-08-14 Kenichi Handa <handa@m17n.org>
1423 * process.c (create_process): Call setup_process_coding_systems
1424 after the pid of the process is set to -1 (Bug#8162).
1426 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1428 * xdisp.c (move_it_in_display_line_to): Don't invoke
1429 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1430 ppos_it. Fixes vertical cursor motion when line beginning is
1431 covered by an image. (Bug#9296)
1433 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1435 * nsterm.h (ns_run_ascript): Declare.
1436 (NSAPP_DATA2_RUNASSCRIPT): Define.
1438 * nsfns.m (as_script, as_result, as_status): New static variables.
1439 (ns_run_ascript): New function.
1440 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1441 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1442 the event loop. Get status from as_status (Bug#7276).
1444 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1445 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1446 the event loop (Bug#7276).
1448 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1450 * gnutls.c (QCgnutls_bootprop_priority)
1451 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1452 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1453 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1454 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1455 (QCgnutls_bootprop_verify_hostname_error)
1456 (QCgnutls_bootprop_callbacks_verify): Rename from
1457 Qgnutls_bootprop_..., all uses changed.
1459 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1462 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1464 * xfaces.c (Qframe_set_background_mode): Now static.
1465 * dispextern.h (Qframe_set_background_mode): Remove decl.
1467 * process.c (Fnetwork_interface_info): Declare local only if needed.
1469 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1471 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1472 (Fnetwork_interface_list): Allocate in increments of bytes instead
1473 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1474 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1476 (struct ifflag_def): notrailers is smart on OSX.
1477 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1478 Get hardware address with getifaddrs if available.
1480 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1482 * xdisp.c (iterate_out_of_display_property): xassert that
1483 IT->position is set to within IT->object's boundaries. Break from
1484 the loop as soon as EOB is reached; avoids infloops in redisplay
1485 when IT->position is set up wrongly due to some bug.
1486 Set IT->current to match the bidi iterator unconditionally.
1487 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1488 entry. Force push_it to save on the stack the current
1489 buffer/string position, to be restored by pop_it. Fix flags in
1490 the iterator structure wrt the object coming from a display
1491 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1492 properties. (Bug#9284)
1494 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1496 * fontset.c (fontset_get_font_group): Add proper type checks.
1499 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1501 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1502 and LC_VERSION_MIN_MACOSX.
1503 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1504 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1506 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1508 * xdisp.c (forward_to_next_line_start): Allow to use the
1509 no-display-properties-and-no-overlays under bidi display.
1510 Set disp_pos in the bidi iterator to avoid searches for display
1511 properties and overlays.
1513 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1515 * editfns.c (Fset_time_zone_rule): Document relationship with the
1518 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1519 the font entity extracted from the cache (Bug#8109).
1521 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1523 * composite.c (autocmp_chars): Don't reset point. That is done by
1524 restore_point_unwind (Bug#5984).
1526 2011-08-07 Juri Linkov <juri@jurta.org>
1528 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1529 to show the arg `TIME' instead of `TIMEVAL'.
1531 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1533 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1534 display property strides EOL and includes a newline, as in
1535 longlines-mode. (Bug#9254)
1536 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1537 word-wrap under bidirectional display. (Bug#9224)
1539 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1540 is non-zero, even if the data buffer is NULL. Fixes a crash in
1541 vertical-motion with longlines-mode. (Bug#9254)
1543 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1545 * bidi.c <bidi_cache_total_alloc>: Now static.
1546 (bidi_initialize): Initialize bidi_cache_total_alloc.
1548 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1551 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1552 amount allocated this far in `bidi_cache_total_alloc'.
1553 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1554 non-zero, only free the data buffer without restoring the cache
1555 contents. All callers changed.
1557 * dispextern.h (bidi_unshelve_cache): Update prototype.
1559 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1560 (move_it_in_display_line, move_it_to)
1561 (move_it_vertically_backward, move_it_by_lines): Replace the call
1562 to xfree to an equivalent call to bidi_unshelve_cache.
1563 (move_it_in_display_line_to): Fix logic of returning
1564 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1566 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1568 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1569 came from a string character with a `cursor' property. (Bug#9229)
1571 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1573 * Makefile.in (LIB_PTHREAD): New variable.
1574 (LIBES): Add LIB_PTHREAD (Bug#9216).
1576 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1577 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1579 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1581 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1583 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1585 * xterm.c (x_find_topmost_parent): New function.
1586 (x_set_frame_alpha): Find topmost parent window with
1587 x_find_topmost_parent and set the property there also (bug#9181).
1588 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1590 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1592 * callproc.c (Fcall_process): Avoid vfork clobbering
1593 the local vars buffer, coding_systems, current_dir.
1595 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1597 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1599 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1601 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1602 so that it is not optimized away.
1604 * xdisp.c (compute_display_string_pos): Remove unused local.
1606 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1608 Fix slow cursor motion and scrolling in large buffers with
1609 selective display, like Org Mode buffers. (Bug#9218)
1611 * dispextern.h (struct bidi_it): New member disp_prop_p.
1613 * xdisp.c: Remove one-slot cache of display string positions.
1614 (compute_display_string_pos): Accept an additional argument
1615 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1616 for a display string or property. If found, set DISP_PROP_P
1619 * bidi.c (bidi_fetch_char): Accept an additional argument
1620 DISP_PROP_P, and pass it to compute_display_string_pos.
1621 Only handle text covered by a display string if DISP_PROP_P is returned
1622 non-zero. All callers of bidi_fetch_char changed.
1624 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1626 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1628 2010-12-03 Don March <don@ohspite.net>
1630 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1631 last character M-[char] is translated to ESC [char] (bug#7541).
1633 2011-08-02 Kenichi Handa <handa@m17n.org>
1635 * lisp.h (uniprop_table): Extern it.
1637 * chartab.c (uniprop_table): Make it non-static.
1639 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1641 * xdisp.c (forward_to_next_line_start): Accept additional argument
1642 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1644 (reseat_at_next_visible_line_start): Use the bidi iterator state
1645 returned by forward_to_next_line_start to restore the state of
1646 it->bidi_it after backing up to previous newline. (Bug#9212)
1648 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1650 * regex.c (re_comp): Protoize.
1651 (re_exec): Fix return type.
1652 (regexec): Fix type of `ret'. (Bug#9203)
1654 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1656 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1657 This is needed if max-image-size is a floating-point number.
1659 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1661 * print.c (print_object): Print empty symbol as ##.
1663 * lread.c (read1): Read ## as empty symbol.
1665 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1667 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1668 setting frame foreground color (Bug#9175).
1669 (x_set_background_color): Likewise.
1671 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1672 contents (Bug#9176).
1673 (EmacsTooltip -init): Remove bezels and add shadows to
1676 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1677 or scroll bar (Bug#8470).
1679 * nsfont.m (nsfont_open): Remove assignment to voffset and
1680 unnecessary vars hshink, expand, hd, full_height, min_height.
1681 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1683 * nsterm.h (nsfont_info): Remove voffset field.
1685 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1687 Implement strike-through and overline on NextStep (Bug#8863).
1689 * nsfont.m (nsfont_open): Use underline position provided by font,
1690 instead of hard-coded value of 2.
1691 (nsfont_draw): Call ns_draw_text_decoration instead.
1693 * nsterm.h: Add declaration for ns_draw_text_decoration.
1695 * nsterm.m (ns_draw_text_decoration): New function for drawing
1696 underline, overline, and strike-through.
1697 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1698 ns_draw_text_decoration. Change treatment of cursor drawing to
1699 accommodate underlining, etc.
1701 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1703 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1706 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1708 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1709 Without this fix, if a signal arrives just after memory fills up,
1710 'malloc' might be invoked reentrantly.
1712 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1713 In other words, assume that every image size is allowed, on non-X
1714 hosts. This assumption is probably wrong, but it lets Emacs compile.
1716 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1718 * regex.c (re_iswctype): Convert return values to boolean.
1720 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1722 * xdisp.c (compute_display_string_pos): Don't use cached display
1723 string position if the buffer had its restriction changed.
1726 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1728 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1730 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1732 Integer signedness and overflow and related fixes. (Bug#9079)
1734 * bidi.c: Integer size and overflow fixes.
1735 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1736 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1737 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1738 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1739 (bidi_find_other_level_edge):
1740 Use ptrdiff_t instead of EMACS_INT where either will do.
1741 This works better on 32-bit hosts configured --with-wide-int.
1742 (bidi_cache_ensure_space): Check for size-calculation overflow.
1743 Use % rather than repeated addition, for better worst-case speed.
1744 Don't set bidi_cache_size until after xrealloc returns, because it
1746 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1747 (bidi_cache_ensure_space): Also check that the bidi cache size
1748 does not exceed that of the largest Lisp string or buffer. See Eli
1749 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1751 * alloc.c (__malloc_size_t): Remove.
1752 All uses replaced by size_t. See Andreas Schwab's note
1753 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1755 * image.c: Improve checking for integer overflow.
1756 (check_image_size): Assume that f is nonnull, since
1757 it is always nonnull in practice. This is one less thing to
1758 worry about when checking for integer overflow later.
1759 (x_check_image_size): New function, which checks for integer
1760 overflow issues inside X.
1761 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1762 This removes the need for a memory_full check.
1763 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1764 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1765 (xbm_read_bitmap_data): Change locals back to 'int', since
1766 their values must fit in 'int'.
1767 (xpm_load_image, png_load, tiff_load):
1768 Invoke x_create_x_image_and_pixmap earlier,
1769 to avoid much needless work if the image is too large.
1770 (tiff_load): Treat overly large images as if
1771 x_create_x_image_and_pixmap failed, not as malloc failures.
1772 (gs_load): Use x_check_image_size.
1774 * gtkutil.c: Omit integer casts.
1775 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1776 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1778 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1780 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1781 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1782 would wrongly return t on a 64-bit host.
1784 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1785 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1786 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1787 and therefore cause GCC to emit a bogus diagnostic in some cases.
1789 * image.c: Integer signedness and overflow and related fixes.
1790 This is not an exhaustive set of fixes, but it's time to
1791 record what I've got.
1792 (lookup_pixel_color, check_image_size): Remove redundant decls.
1793 (check_image_size): Don't assume that arbitrary EMACS_INT values
1794 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1795 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1796 (tiff_load, imagemagick_load_image):
1797 Check for overflow in size calculations.
1798 (x_create_x_image_and_pixmap): Remove unnecessary test for
1799 xmalloc returning NULL; that can't happen.
1800 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1801 (xpm_color_bucket): Use better integer hashing function.
1802 (xpm_cache_color): Don't possibly over-allocate memory.
1803 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1804 (gif_memory_source):
1805 Use ptrdiff_t, not int or size_t, to record sizes.
1806 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1807 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1808 either works, as we prefer signed integers.
1809 (tiff_read_from_memory, tiff_write_from_memory):
1810 Return tsize_t, not size_t, since that's what the TIFF API wants.
1811 (tiff_read_from_memory): Don't fail simply because the read would
1812 go past EOF; instead, return a short read.
1813 (tiff_load): Omit no-longer-needed casts.
1814 (Fimagemagick_types): Don't assume size fits into 'int'.
1816 Improve hashing quality when configured --with-wide-int.
1817 * fns.c (hash_string): New function, taken from sxhash_string.
1818 Do not discard information about ASCII character case; this
1819 discarding is no longer needed.
1820 (sxhash-string): Use it. Change sig to match it. Caller changed.
1821 * lisp.h: Declare it.
1822 * lread.c (hash_string): Remove, since we now use fns.c's version.
1823 The fns.c version returns a wider integer if --with-wide-int is
1824 specified, so this should help the quality of the hashing a bit.
1826 * emacs.c: Integer overflow minor fix.
1827 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1828 Define only if GNU_LINUX.
1829 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1831 * dispnew.c: Integer signedness and overflow fixes.
1832 Remove unnecessary forward decls, that were a maintenance hassle.
1833 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1835 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1836 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1837 (prepare_desired_row, line_draw_cost):
1838 Use int, not unsigned, where either works.
1839 (save_current_matrix, restore_current_matrix):
1840 Use ptrdiff_t, not size_t, where either works.
1841 (init_display): Check for overflow more accurately, and without
1842 relying on undefined behavior.
1844 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1845 Remove, replacing with the new symbols in lisp.h. All uses changed.
1846 * fileio.c (make_temp_name):
1847 * filelock.c (lock_file_1, lock_file):
1848 * xdisp.c (message_dolog):
1849 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1850 Use pMd etc. instead.
1851 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1852 replacing the pWIDE etc. symbols removed from editfns.c.
1854 * keyboard.h (num_input_events): Now uintmax_t.
1855 This is (very slightly) less likely to mess up due to wraparound.
1858 * buffer.c: Integer signedness fixes.
1859 (alloc_buffer_text, enlarge_buffer_text):
1860 Use ptrdiff_t rather than size_t when either will do, as we prefer
1863 * alloc.c: Integer signedness and overflow fixes.
1864 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1865 (__malloc_size_t): Default to size_t, not to int.
1866 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1867 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1868 Prefer ptrdiff_t to size_t when either would do, as we prefer
1870 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1871 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1872 Now const. Initialize with values that are in range even if char
1874 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1875 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1876 These functions do the right thing with sizes > 2**32.
1877 (check_depth): Now ptrdiff_t, not int.
1878 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1879 Adjust to new way of storing sizes. Check for size overflow bugs
1881 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1882 slightly wrong anyway, as it missed one instance of
1883 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1884 (refill_memory_reserve): Omit needless cast to size_t.
1885 (mark_object_loop_halt): Mark as externally visible.
1887 * xselect.c: Integer signedness and overflow fixes.
1888 (Fx_register_dnd_atom, x_handle_dnd_message):
1889 Use ptrdiff_t, not size_t, since we prefer signed.
1890 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1891 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1892 x_dnd_atoms_size and x_dnd_atoms_length.
1894 * doprnt.c: Prefer signed to unsigned when either works.
1896 * doprnt.c (doprnt):
1898 * xdisp.c (vmessage):
1899 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1900 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1901 prefer signed arithmetic to avoid comparison confusion.
1902 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1903 but is a bit tricky.
1905 Assume freestanding C89 headers, string.h, stdlib.h.
1906 * data.c, doprnt.c, floatfns.c, print.c:
1907 Include float.h unconditionally.
1908 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1909 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1910 * regex.c: Likewise for stddef.h, string.h.
1911 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1912 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1913 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1914 (STDC_HEADERS): Remove obsolete defines.
1915 * sysdep.c: Include limits.h unconditionally.
1917 Assume support for memcmp, memcpy, memmove, memset.
1918 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1919 * regex.c (memcmp, memcpy):
1920 Remove; we assume C89 now.
1922 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1923 (__malloc_safe_bcopy): Remove; no longer needed.
1925 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1926 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1927 well either way, and we prefer signed to unsigned.
1929 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1931 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1932 closes the connection while we're reading (bug#9182).
1934 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1936 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1937 are specified (Bug#9168).
1939 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1941 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1942 Found by GCC static checking and --with-wide-int on a 32-bit host.
1944 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1946 * xdisp.c (compute_display_string_pos): Fix logic of caching
1947 previous display string position. Initialize cached_prev_pos to
1948 -1. Fixes slow-down at the beginning of a buffer.
1950 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1952 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1953 for attrs[LFACE_FONTSET_INDEX].
1955 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1957 * xml.c (parse_region): Remove unused local
1958 that was recently introduced.
1960 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1962 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1963 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1965 * xdisp.c (move_it_in_display_line_to): Record the best matching
1966 position for TO_CHARPOS while scanning the line, and restore it on
1967 exit if none of the characters scanned was an exact match.
1968 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1969 when exact match is impossible due to invisible text, and the
1970 lines are truncated.
1972 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1974 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1977 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1979 Fix a significant slow-down of cursor motion with C-n, C-p,
1980 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1981 auto-repeat under bidi redisplay in fontified buffers.
1982 * xdisp.c (compute_stop_pos_backwards): New function.
1983 (next_element_from_buffer): Call compute_stop_pos_backwards to
1984 find a suitable prev_stop when we find ourselves before
1986 (reseat): Don't look for prev_stop, as that could mean a very long
1988 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1989 <cached_disp_overlay_modiff>: Cache for last found display string
1991 (compute_display_string_pos): Return the cached position if asked
1992 about the same buffer in the same area of character positions, and
1993 the buffer wasn't changed since the time the display string
1994 position was cached.
1996 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1998 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1999 is an integer, which is important for empty lines. (Bug#9149)
2001 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2003 * frame.c (Fmodify_frame_parameters): In tty case, update the
2004 default face if necessary (Bug#4238).
2006 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2008 * editfns.c (Fstring_to_char): No need to explain what a character
2009 is in the docstring (Bug#6576).
2011 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2013 * xml.c (parse_region): Make sure we always return a tree.
2015 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2017 * xml.c (parse_region): If a document contains only comments,
2020 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2022 * xml.c (make_dom): Return comments, too.
2024 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2027 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2028 and the surrounding thread.
2029 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2030 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2031 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2033 * s/openbsd.h (BROKEN_SIGIO): Define.
2034 * unexelf.c (unexec) [__OpenBSD__]:
2035 Don't update the .mdebug section of the Alpha COFF symbol table.
2037 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2039 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2042 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2044 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2045 This fixes some race conditions on the permissions of any newly
2048 * alloc.c (valid_pointer_p): Use pipe, not open.
2049 This fixes some permissions issues when debugging.
2051 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2052 If fchown fails to set both uid and gid, try to set just gid,
2053 as that is sometimes allowed. Adjust the file's mode to eliminate
2054 setuid or setgid bits that are inappropriate if fchown fails.
2056 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2058 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2059 to compare Lisp_Objects.
2060 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2061 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2062 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2064 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2066 * lread.c (read_integer): Unread even EOF character.
2067 (read1): Likewise. Properly record start position of symbol.
2069 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2070 symbol character follows.
2072 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2074 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2075 This works around a problem with the previous change to Fcopy_file.
2076 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2077 and without this change, GCC might complain about discarding
2078 fchown's return value.
2080 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2082 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2084 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2086 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2088 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2090 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2091 it's used from the C level.
2093 * process.c: Use the same condition for POLL_FOR_INPUT in both
2094 keyboard.c and process.c (bug#1858).
2096 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2098 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2099 (Fgnutls_boot): Use it.
2101 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2103 * doc.c (Fsubstitute_command_keys): Revert last change.
2105 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2107 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2108 quotes the next character, and doesn't affect other longer
2109 sequences (bug#8935).
2111 * lread.c (syms_of_lread): Clarify that is isn't only
2112 `eval-buffer' and `eval-defun' that's affected by
2113 `lexical-binding' (bug#8460).
2115 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2117 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2118 bidi redisplay when a line includes both an image and is truncated.
2120 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2122 Fix minor problems found by static checking.
2123 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2124 (elsz): Now a signed constant, not a size_t var. We prefer signed
2125 types to unsigned, to avoid integer comparison confusion. Without
2126 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2127 "cannot optimize loop, the loop counter may overflow", a symptom
2129 * indent.c (Fvertical_motion): Mark locals as initialized.
2130 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2132 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2134 * search.c (Fre_search_backward): Mention `case-fold-search' in
2135 all the re_search_* functions (bug#8138).
2137 * keyboard.c (Fopen_dribble_file): Document when the file is
2140 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2142 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2145 Support bidi reordering of display and overlay strings.
2146 * xdisp.c (compute_display_string_pos)
2147 (compute_display_string_end): Accept additional argument STRING.
2148 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2149 (reseat_to_string): Initialize bidi_it->string.s and
2150 bidi_it->string.schars.
2151 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2152 NULL (avoids a crash in bidi_paragraph_init).
2153 Initialize itb.string.lstring.
2154 (init_iterator): Call bidi_init_it only of a valid
2155 buffer position was specified. Initialize paragraph_embedding to
2157 (reseat_to_string): Initialize the bidi iterator.
2158 (display_string): If we need to ignore text properties of
2159 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2160 original value of -1 will not work with bidi.)
2161 (compute_display_string_pos): First arg is now struct
2162 `text_pos *'; all callers changed. Support display properties on
2164 (compute_display_string_end): Support display properties on Lisp
2166 (init_iterator, reseat_1, reseat_to_string): Initialize the
2167 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2168 when iterating on a string not from display properties).
2169 (compute_display_string_pos, compute_display_string_end):
2170 Fix calculation of the object to scan. Fixes an error when using
2172 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2173 base_level_stop; instead, set base_level_stop to BEGV.
2174 Fixes crashes in vertical-motion.
2175 (next_element_from_buffer): Improve commentary for when
2176 the iterator is before prev_stop.
2177 (init_iterator): Initialize bidi_p from the default value of
2178 bidi-display-reordering, not from buffer-local value. Use the
2179 buffer-local value only if initializing for buffer iteration.
2180 (handle_invisible_prop): Support invisible properties on strings
2181 that are being bidi-reordered.
2182 (set_iterator_to_next): Support bidi reordering of C strings and
2184 (next_element_from_string): Support bidi reordering of Lisp
2186 (handle_stop_backwards): Support Lisp strings as well.
2187 (display_string): Support display of R2L glyph rows.
2188 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2189 (init_iterator): Don't initialize it->bidi_p for strings
2191 (reseat_to_string): Initialize it->bidi_p for strings here.
2192 (next_element_from_string, next_element_from_c_string)
2193 (next_element_from_buffer): Add xassert's for correspondence
2194 between IT's object being iterated and it->bidi_it.string
2196 (face_before_or_after_it_pos): Support bidi iteration.
2197 (next_element_from_c_string): Handle the case of the first string
2198 character that is not the first one in the visual order.
2199 (get_visually_first_element): New function, refactored from common
2200 parts of next_element_from_buffer, next_element_from_string, and
2201 next_element_from_c_string.
2202 (tool_bar_lines_needed, redisplay_tool_bar)
2203 (display_menu_bar): Force left-to-right direction. Add a FIXME
2204 comment for making that be controlled by a user option.
2205 (push_it, pop_it): Save and restore the state of the
2206 bidi iterator. Save and restore the bidi_p flag.
2207 (pop_it): Iterate out of display property for string iteration as
2209 (iterate_out_of_display_property): Support iteration over strings.
2210 (handle_single_display_spec): Set up it->bidi_it for iteration
2211 over a display string, and call bidi_init_it.
2212 (handle_single_display_spec, next_overlay_string)
2213 (get_overlay_strings_1, push_display_prop): Set up the bidi
2214 iterator for displaying display or overlay strings.
2215 (forward_to_next_line_start): Don't use the shortcut if
2217 (back_to_previous_visible_line_start): If handle_display_prop
2218 pushed the iterator stack, restore the internal state of the bidi
2219 iterator by calling bidi_pop_it same number of times.
2220 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2221 and we are bidi-iterating, don't decrement the iterator position;
2222 instead, set the first_elt flag in the bidi iterator, to produce
2224 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2225 (push_display_prop): xassert that we are iterating a buffer.
2226 (push_it, pop_it): Save and restore paragraph_embedding member.
2227 (handle_single_display_spec, next_overlay_string)
2228 (get_overlay_strings_1, reseat_1, reseat_to_string)
2229 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2230 correctly. Don't assume unibyte strings are not bidi-reordered.
2231 (compute_display_string_pos)
2232 (compute_display_string_end): Fix handling the case of C string.
2233 (push_it, pop_it): Save and restore from_disp_prop_p.
2234 (handle_single_display_spec, push_display_prop): Set the
2235 from_disp_prop_p flag.
2236 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2237 (pop_it): Call iterate_out_of_display_property only if we are
2238 popping after iteration over a string that came from a display
2239 property. Fix a typo in popping stretch info. Add an assertion
2240 for verifying that the iterator position is in sync with the bidi
2242 (handle_single_display_spec, get_overlay_strings_1)
2243 (push_display_prop): Fix initialization of paragraph direction for
2244 string when that of the parent object is not yet determined.
2245 (reseat_1): Call bidi_init_it to resync the bidi
2246 iterator with IT's position. (Bug#7616)
2247 (find_row_edges): If ROW->start.pos gives position
2248 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2249 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2250 Reset the from_disp_prop_p flag.
2251 (SAVE_IT, RESTORE_IT): New macros.
2252 (pos_visible_p, face_before_or_after_it_pos)
2253 (back_to_previous_visible_line_start)
2254 (move_it_in_display_line_to, move_it_in_display_line)
2255 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2256 (try_scrolling, redisplay_window, display_line): Use them when
2257 saving a temporary copy of the iterator and restoring it back.
2258 (back_to_previous_visible_line_start, reseat_1)
2259 (init_iterator): Empty the bidi cache "stack".
2260 (move_it_in_display_line_to): If iterator ended up at
2261 EOL, but we never saw any buffer positions smaller than
2262 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2263 motion in bidi-reordered lines.
2264 (move_it_in_display_line_to): Record prev_method and prev_pos
2265 immediately before the call to set_iterator_to_next. Fixes cursor
2266 motion in bidi-reordered lines with stretch glyphs and strings
2267 displayed in margins. (Bug#8133) (Bug#8867)
2268 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2270 (pos_visible_p): Support positions in bidi-reordered lines.
2271 Save and restore bidi cache.
2273 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2274 (bidi_paragraph_info): Delete unused struct.
2275 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2276 (bidi_cache_start): New variable.
2277 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2279 (bidi_cache_fetch_state, bidi_cache_search)
2280 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2281 (bidi_cache_find, bidi_peek_at_next_level)
2282 (bidi_level_of_next_char, bidi_find_other_level_edge)
2283 (bidi_move_to_visually_next): Compare cache index with
2284 bidi_cache_start rather than with zero.
2285 (bidi_fetch_char): Accept new argument STRING; all callers
2286 changed. Support iteration over a string. Support strings with
2287 display properties. Support unibyte strings. Fix the type of
2288 `len' according to what STRING_CHAR_AND_LENGTH expects.
2289 (bidi_paragraph_init, bidi_resolve_explicit_1)
2290 (bidi_resolve_explicit, bidi_resolve_weak)
2291 (bidi_level_of_next_char, bidi_move_to_visually_next):
2292 Support iteration over a string.
2293 (bidi_set_sor_type, bidi_resolve_explicit_1)
2294 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2295 can now be zero (for strings); special values 0 and -1 were
2296 changed to -1 and -2, respectively.
2297 (bidi_char_at_pos): New function.
2298 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2299 Call it instead of FETCH_MULTIBYTE_CHAR.
2300 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2301 initialized to valid values.
2302 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2304 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2305 the test for valid cached positions. Fix the logic for looking up
2306 the sentinel state in the cache. GCPRO the Lisp string we are
2308 (bidi_push_it, bidi_pop_it): New functions.
2309 (bidi_initialize): Initialize the bidi cache start stack pointer.
2310 (bidi_cache_ensure_space): New function, refactored from part of
2311 bidi_cache_iterator_state. Don't assume the required size is just
2312 one BIDI_CACHE_CHUNK away.
2313 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2314 (bidi_count_bytes, bidi_char_at_pos): New functions.
2315 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2316 always valid if bidi_cache_idx is valid.
2317 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2318 is valid if it's going to be used.
2319 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2320 (bidi_cache_fetch_state, bidi_cache_search)
2321 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2322 (bidi_cache_iterator_state, bidi_cache_find)
2323 (bidi_find_other_level_edge, bidi_cache_start_stack):
2324 All variables related to cache indices are now EMACS_INT.
2326 * dispextern.h (struct bidi_string_data): New structure.
2327 (struct bidi_it): New member `string'. Make flag members be 1-bit
2328 fields, and put them last in the struct.
2329 (compute_display_string_pos, compute_display_string_end):
2331 (bidi_push_it, bidi_pop_it): Add prototypes.
2332 (struct iterator_stack_entry): New members bidi_p,
2333 paragraph_embedding, and from_disp_prop_p.
2334 (struct it): Member bidi_p is now a bit field 1 bit wide.
2335 (bidi_shelve_cache, bidi_unshelve_cache):
2338 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2339 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2340 and vector-like objects.
2342 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2343 cache around display iteration.
2345 * window.c (Fwindow_end, window_scroll_pixel_based)
2346 (displayed_window_lines, Frecenter): Save and restore the bidi
2347 cache around display iteration.
2349 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2351 * editfns.c (Fdelete_region): Clarify the use of the named
2352 parameters (bug#6788).
2354 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2356 * indent.c (Fvertical_motion): Set and restore w->pointm when
2357 saving and restoring the window's buffer (Bug#9006).
2359 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2361 * editfns.c (Fstring_to_char): Clarify just what is returned
2362 (bug#6576). Text by Eli Zaretskii.
2364 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2366 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2368 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2370 * buffer.c (mmap_find): Fix a typo.
2372 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2374 Fix execution of x selection hooks.
2375 * xselect.c (Qx_lost_selection_functions)
2376 (Qx_sent_selection_functions): New vars.
2377 (syms_of_xselect): DEFSYM them.
2378 (x_handle_selection_request): Pass Qx_sent_selection_functions
2379 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2380 (x_handle_selection_clear,x_clear_frame_selections):
2381 Pass Qx_lost_selection_functions rather than
2382 Vx_lost_selection_functions to Frun_hook_with_args.
2384 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2386 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2387 The old code sometimes used this field without initializing it.
2389 * alloc.c (gc_sweep): Don't read past end of array.
2390 In theory, the old code could also have corrupted Emacs internals,
2391 though it'd be very unlikely.
2393 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2395 * character.c (Fcharacterp): Don't advertise optional ignored
2396 argument. (Bug#4026)
2398 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2400 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2403 * window.c (Fset_window_start): Doc fix (bug#4199).
2404 (Fset_window_hscroll): Ditto.
2406 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2408 Fix minor new problems caught by GCC 4.6.1.
2409 * term.c (init_tty): Remove unused local.
2410 * xsettings.c (store_monospaced_changed): Define this function only
2411 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2414 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2416 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2418 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2420 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2421 are the mini-buffer and the echo area (bug#3320).
2423 * term.c (init_tty): Remove support for supdup, c10 and perq
2424 terminals, which are no longer supported (bug#1482).
2426 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2428 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2430 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2432 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2433 for non-popups (Bug#3642).
2435 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2437 * alloc.c (reset_malloc_hooks): Protoize.
2438 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2439 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2440 * cm.c (losecursor): Likewise.
2441 * data.c (fmod): Likewise.
2442 * dispnew.c (swap_glyphs_in_rows): Likewise.
2443 * emacs.c (memory_warning_signal): Likewise.
2444 * floatfns.c (float_error): Likewise.
2445 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2446 (otf_open, font_otf_capability, generate_otf_features)
2447 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2449 * image.c (pbm_read_file): Likewise.
2450 * indent.c (string_display_width): Likewise.
2451 * intervals.c (check_for_interval, search_for_interval)
2452 (inc_interval_count, count_intervals, root_interval)
2453 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2454 * lread.c (defalias): Likewise.
2455 * ralloc.c (r_alloc_check): Likewise.
2456 * regex.c (set_image_of_range_1, set_image_of_range)
2457 (regex_grow_registers): Likewise.
2458 * sysdep.c (strerror): Likewise.
2459 * termcap.c (valid_filename_p, tprint, main): Likewise.
2460 * tparam.c (main): Likewise.
2461 * unexhp9k800.c (run_time_remap, save_data_space)
2462 (update_file_ptrs, read_header, write_header, calculate_checksum)
2463 (copy_file, copy_rest, display_header): Likewise.
2464 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2466 * xdisp.c (check_it): Likewise.
2467 * xfaces.c (register_color, unregister_color, unregister_colors):
2469 * xfns.c (print_fontset_result): Likewise.
2470 * xrdb.c (member, fatal, main): Likewise.
2472 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2474 Fix minor problems found by static checking (Bug#9031).
2475 * chartab.c (char_table_set_range, map_sub_char_table):
2476 Remove unused locals.
2477 (uniprop_table): Now static.
2478 * composite.c (_work_char): Remove unused static var.
2480 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2482 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2484 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2486 * gtkutil.c (qttip_cb): Remove code without function.
2488 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2490 * w32.c (pthread_sigmask): New stub.
2492 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2494 Use pthread_sigmask, not sigprocmask (Bug#9010).
2495 sigprocmask is portable only for single-threaded applications, and
2496 Emacs can be multi-threaded when it uses GTK.
2497 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2499 * callproc.c (Fcall_process):
2500 * process.c (create_process):
2501 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2502 Use pthread_sigmask, not sigprocmask.
2504 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2506 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2507 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2510 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2512 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2513 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2514 (xg_hide_tooltip): Fix comment.
2516 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2517 in registerServicesMenuSendTypes.
2518 (validRequestorForSendType): Don't check ns_return_types.
2520 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2523 2011-07-08 Jason Rumney <jasonr@gnu.org>
2525 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2526 frame struct members of non-existent frames (Bug#6284).
2528 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2530 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2531 variable firstTime not needed on OSX >= 10.6.
2532 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2533 >= 10.5. Use setKnobProportion, setDoubleValue.
2535 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2536 (MAC_OS_X_VERSION_10_5): Define if not defined.
2537 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2538 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2539 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2541 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2542 cString and lossyCString on OSX >= 10.4
2544 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2545 sizeToFit on OSX >= 10.2.
2547 * nsimage.m (allocInitFromFile): Don't use deprecated method
2548 bestRepresentationForDevice on OSX >= 10.6.
2550 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2553 * emacs.c: Declare unexec_init_emacs_zone.
2555 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2557 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2559 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2560 on svcsMenu (Bug#8842).
2562 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2564 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2566 * nsterm.m (QUTF8_STRING): Declare.
2567 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2568 (validRequestorForSendType): Return type is (id).
2569 Change indexOfObjectIdenticalTo to indexOfObject.
2570 Check if we have local selection before returning self (Bug#8842).
2571 (writeSelectionToPasteboard): Put local selection into paste board
2572 if we have a local selection (Bug#8842).
2573 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2575 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2576 (ns_get_local_selection): Declare.
2578 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2580 * keymap.c (describe_map_tree): Don't insert a double newline at
2581 the end of the buffer (bug#1169) and return whether we inserted
2584 * callint.c (Fcall_interactively): Change "reading args" to
2585 "providing args" to try to clarify what it does (bug#1010).
2587 2011-07-07 Kenichi Handa <handa@m17n.org>
2589 * composite.c (composition_compute_stop_pos): Ignore a static
2590 composition starting before CHARPOS (Bug#8915).
2592 * xdisp.c (handle_composition_prop): Likewise.
2594 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2596 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2599 2011-07-07 Kenichi Handa <handa@m17n.org>
2601 * character.h (unicode_category_t): New enum type.
2603 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2604 (Qchar_code_property_table): New variable.
2605 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2606 (UNIPROP_COMPRESSED_FORM_P): New macros.
2607 (char_table_ascii): Uncompress the compressed values.
2608 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2609 Uncompress the compressed values.
2610 (sub_char_table_ref_and_range): Likewise.
2611 (char_table_ref_and_range): Uncompress the compressed values.
2612 (sub_char_table_set): New arg is_uniprop. Callers changed.
2613 Uncompress the compressed values.
2614 (sub_char_table_set_range): Args changed. Callers changed.
2615 (char_table_set_range): Adjuted for the above change.
2616 (map_sub_char_table): Delete args default_val and parent. Add arg
2617 top. Give decoded values to a Lisp function.
2618 (map_char_table): Adjust for the above change. Give decoded
2619 values to a Lisp function. Gcpro more variables.
2620 (uniprop_table_uncompress)
2621 (uniprop_decode_value_run_length): New functions.
2622 (uniprop_decoder, uniprop_decoder_count): New variables.
2623 (uniprop_get_decoder, uniprop_encode_value_character)
2624 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2626 (uniprop_encoder, uniprop_encoder_count): New variables.
2627 (uniprop_get_encoder, uniprop_table)
2628 (Funicode_property_table_internal, Fget_unicode_property_internal)
2629 (Fput_unicode_property_internal): New functions.
2630 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2631 Sunicode_property_table_internal, Sget_unicode_property_internal,
2632 and Sput_unicode_property_internal. Defvar_lisp
2633 char-code-property-alist.
2635 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2636 Vunicode_category_table.
2638 * font.c (font_range): Adjust for the change of
2639 Vunicode_category_table.
2641 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2643 * m/iris4d.h: Remove file, move contents ...
2644 * s/irix6-5.h: ... here.
2646 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2648 Remove unportable assumption about struct layout (Bug#8884).
2649 * alloc.c (mark_buffer):
2650 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2651 (clone_per_buffer_values): Don't assume that
2652 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2653 This isn't true in general, and it's particularly not true
2654 if Emacs is configured with --with-wide-int.
2655 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2656 New macros, used in the buffer.c change.
2658 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2660 * xsettings.c: Use both GConf and GSettings if both are available.
2661 (store_config_changed_event): Add comment.
2662 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2663 (store_tool_bar_style_changed): New functions.
2664 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2665 (struct xsettings): Move font inside HAVE_XFT.
2666 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2667 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2668 Move inside HAVE_XFT.
2669 (something_changed_gsettingsCB): Rename from something_changedCB.
2670 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2672 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2673 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2674 (something_changed_gconfCB): Rename from something_changedCB.
2675 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2676 (parse_settings): Move check for font inside HAVE_XFT.
2677 (read_settings, apply_xft_settings): Add comment.
2678 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2679 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2680 call store_font_name_changed.
2681 (xft_settings_event): Add comment.
2682 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2683 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2684 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2685 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2686 (xsettings_initialize): Call init_gsettings last.
2687 (xsettings_get_system_font, xsettings_get_system_normal_font):
2690 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2692 Random fixes. E.g., (random) never returned negative values.
2693 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2694 subseconds part to the entropy, as that's a bit more random.
2695 Prefer signed to unsigned, since the signedness doesn't matter and
2696 in general we prefer signed. When given a limit, use a
2697 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2698 latter isn't right if USE_2_TAGS_FOR_INTS.
2699 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2700 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2702 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2704 * textprop.c (text_property_stickiness):
2705 Obey Vtext_property_default_nonsticky.
2706 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2707 * w32fns.c (syms_of_w32fns):
2708 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2710 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2712 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2713 This is more efficient than Ffile_directory_p and avoids a minor race.
2715 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2717 * buffer.c (Foverlay_put): Say what the return value is
2720 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2721 is a directory before asking whether to use the file name
2723 (barf_or_query_if_file_exists): Make the "File is a directory"
2724 error be more correct.
2726 * fns.c (Frequire): Remove the mention of the .gz files, since
2727 that's installation-specific, but keep the mention of
2728 `get-load-suffixes'.
2730 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2732 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2733 Report string overflow if the output is too long.
2735 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2737 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2738 (syms_of_gnutls): Remove duplicate DEFSYM for
2739 Qgnutls_bootprop_verify_hostname_error, an error for
2740 Qgnutls_bootprop_verify_error (which is no longer used).
2742 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2743 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2744 Also (re)move comments that are misplaced or no longer relevant.
2746 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2748 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2750 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2752 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2753 and background color parameters if they have been changed.
2755 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2757 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2759 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2761 * xsettings.c (SYSTEM_FONT): Define only when used.
2762 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2764 * keymap.c (access_keymap_1): Now static.
2766 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2768 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2769 leave any prefix arg for the up event (Bug#1586).
2771 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2773 * lread.c (syms_of_lread): Mention single symbols defined by
2774 `defvar' or `defconst' (bug#7154).
2776 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2777 (Frequire): Mention get-load-suffixes.
2779 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2781 * window.h (window): Remove clone_number slot.
2782 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2784 (make_parent_window, make_window, saved_window)
2785 (Fset_window_configuration, save_window_save): Don't deal with
2787 * buffer.c (Qclone_number): Remove declaration.
2788 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2790 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2792 Add multiple inheritance to keymaps.
2793 * keymap.c (Fmake_composed_keymap): New function.
2794 (Fset_keymap_parent): Simplify.
2795 (fix_submap_inheritance): Remove.
2796 (access_keymap_1): New function extracted from access_keymap to handle
2797 embedded parents and handle lists of maps.
2798 (access_keymap): Use it.
2799 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2800 (Fcopy_keymap): Handle embedded parents.
2801 (Fcommand_remapping, define_as_prefix): Simplify.
2802 (Fkey_binding): Simplify.
2803 (syms_of_keymap): Move minibuffer-local-completion-map,
2804 minibuffer-local-filename-completion-map,
2805 minibuffer-local-must-match-map, and
2806 minibuffer-local-filename-must-match-map to Elisp.
2807 (syms_of_keymap): Defsubr make-composed-keymap.
2808 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2809 (parse_menu_item): Trivial simplification.
2811 2011-07-01 Glenn Morris <rgm@gnu.org>
2813 * Makefile.in (SETTINGS_LIBS): Fix typo.
2815 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2817 * coding.c (Fencode_coding_string): Record the last coding system
2818 used, as the function doc string says (bug#8738).
2820 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2822 * xsettings.c (store_monospaced_changed): Take new font as arg and
2823 check for change against current_mono_font.
2824 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2825 (emacs_settings_constructor, emacs_settings_get_property)
2826 (emacs_settings_set_property, emacs_settings_class_init)
2827 (emacs_settings_init, gsettings_obj): Remove.
2828 (something_changedCB): New function for HAVE_GSETTINGS.
2829 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2830 with value as argument.
2831 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2832 g_settings_new (Bug#8967). Do not create gsettings_obj.
2833 Remove calls to g_settings_bind. Connect something_changedCB to
2836 * xgselect.c: Add defined (HAVE_GSETTINGS).
2837 (xgselect_initialize): Ditto.
2839 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2840 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2843 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2845 * eval.c (struct backtrace): Simplify and port the data structure.
2846 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2847 signed bit field, as this assumption is not portable and it makes
2848 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2849 "char debug_on_exit : 1" as this is not portable either; instead,
2850 use the portable "unsigned int debug_on_exit : 1". Remove unused
2851 member evalargs. Remove obsolete comments about cc bombing out.
2853 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2855 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2856 Let HAVE_GSETTINGS override HAVE_GCONF.
2857 (store_monospaced_changed): New function.
2858 (EMACS_SETTINGS): A new type derived from GObject to handle
2859 GSettings notifications.
2860 (emacs_settings_constructor, emacs_settings_get_property)
2861 (emacs_settings_set_property, emacs_settings_class_init):
2863 (gsettings_client, gsettings_obj): New variables.
2864 (GSETTINGS_SCHEMA): New define.
2865 (something_changedCB): Call store_monospaced_changed.
2866 (init_gsettings): New function.
2867 (xsettings_initialize): Call init_gsettings.
2868 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2871 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2874 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2876 * window.c (resize_root_window, grow_mini_window)
2877 (shrink_mini_window): Rename Qresize_root_window to
2878 Qwindow_resize_root_window and Qresize_root_window_vertically to
2879 Qwindow_resize_root_window_vertically.
2881 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2883 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2885 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2887 * makefile.w32-in: Redesign dependencies so they reflect more
2888 clearly which files are directly included by each source file,
2889 and not through other includes.
2891 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2893 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2894 (sort_overlays, overlay_strings): When an overlay's clone number
2895 matches the window's clone number process the overlay even if
2896 the overlay's window property doesn't match the current window.
2898 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2899 (Fwindow_hchild): Rename to Fwindow_left_child.
2900 (Fwindow_next): Rename to Fwindow_next_sibling.
2901 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2902 (resize_window_check): Rename to window_resize_check.
2903 (resize_window_apply): Rename to window_resize_apply.
2904 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2905 (Fdelete_other_windows_internal, resize_frame_windows)
2906 (Fsplit_window_internal, Fdelete_window_internal)
2907 (grow_mini_window, shrink_mini_window)
2908 (Fresize_mini_window_internal): Fix callers accordingly.
2910 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2912 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2913 (emacs_fixed_set_min_size): Remove.
2914 (emacs_fixed_new): Take frame as argument.
2916 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2917 (_EmacsFixedPrivate): Remove minwidth/height.
2918 Add struct frame *f.
2919 (emacs_fixed_init): Initialize priv->f.
2920 (get_parent_class, emacs_fixed_set_min_size): Remove.
2921 (emacs_fixed_new): Set priv->f to argument.
2922 (emacs_fixed_get_preferred_width)
2923 (emacs_fixed_get_preferred_height): Use min_width/height from
2924 frames size_hint to set minimum and natural (Bug#8919).
2925 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2926 and use min_width/height from frames size_hint to set
2927 min_width/height (Bug#8919).
2929 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2930 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2933 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2935 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2936 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2939 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2941 * process.c (wait_reading_process_output): Bypass select if
2942 waiting for a cell while ignoring keyboard input, and input is
2943 pending. Suggested by Jan Djärv (Bug#8869).
2945 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2947 Use gnulib's dup2 module instead of rolling our own.
2948 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2950 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2952 * dispnew.c (scrolling_window): Before scrolling, turn off a
2953 mouse-highlight in the window being scrolled.
2955 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2957 Move DEFSYM to lisp.h and use everywhere.
2959 * character.h (DEFSYM): Move declaration...
2960 * lisp.h (DEFSYM): ...here.
2966 * w32select.c: Don't include character.h.
2968 * alloc.c (syms_of_alloc):
2969 * buffer.c (syms_of_buffer):
2970 * bytecode.c (syms_of_bytecode):
2971 * callint.c (syms_of_callint):
2972 * casefiddle.c (syms_of_casefiddle):
2973 * casetab.c (init_casetab_once):
2974 * category.c (init_category_once, syms_of_category):
2975 * ccl.c (syms_of_ccl):
2976 * cmds.c (syms_of_cmds):
2977 * composite.c (syms_of_composite):
2978 * dbusbind.c (syms_of_dbusbind):
2979 * dired.c (syms_of_dired):
2980 * dispnew.c (syms_of_display):
2981 * doc.c (syms_of_doc):
2982 * editfns.c (syms_of_editfns):
2983 * emacs.c (syms_of_emacs):
2984 * eval.c (syms_of_eval):
2985 * fileio.c (syms_of_fileio):
2986 * fns.c (syms_of_fns):
2987 * frame.c (syms_of_frame):
2988 * fringe.c (syms_of_fringe):
2989 * insdel.c (syms_of_insdel):
2990 * keymap.c (syms_of_keymap):
2991 * lread.c (init_obarray, syms_of_lread):
2992 * macros.c (syms_of_macros):
2993 * msdos.c (syms_of_msdos):
2994 * print.c (syms_of_print):
2995 * process.c (syms_of_process):
2996 * search.c (syms_of_search):
2997 * sound.c (syms_of_sound):
2998 * syntax.c (init_syntax_once, syms_of_syntax):
2999 * terminal.c (syms_of_terminal):
3000 * textprop.c (syms_of_textprop):
3001 * undo.c (syms_of_undo):
3002 * w32.c (globals_of_w32):
3003 * window.c (syms_of_window):
3004 * xdisp.c (syms_of_xdisp):
3005 * xfaces.c (syms_of_xfaces):
3006 * xfns.c (syms_of_xfns):
3007 * xmenu.c (syms_of_xmenu):
3008 * xsettings.c (syms_of_xsettings):
3009 * xterm.c (syms_of_xterm): Use DEFSYM.
3011 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3013 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3015 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3017 Integer and buffer overflow fixes (Bug#8873).
3019 * print.c (printchar, strout): Check for string overflow.
3020 (PRINTPREPARE, printchar, strout):
3021 Don't set size unless allocation succeeds.
3023 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3024 for sizes. Check for string overflow more accurately.
3025 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3027 * macros.c: Integer and buffer overflow fixes.
3028 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3029 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3030 Use ptrdiff_t, not int, for sizes.
3031 Don't increment bufsize until after realloc succeeds.
3032 Check for size-calculation overflow.
3033 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3035 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3037 * lread.c: Integer overflow fixes.
3038 (read_integer): Radix is now EMACS_INT, not int,
3039 to improve quality of diagnostics for out-of-range radices.
3040 Calculate buffer size correctly for out-of-range radices.
3041 (read1): Check for integer overflow in radices, and in
3042 read-circle numbers.
3043 (read_escape): Avoid int overflow.
3044 (Fload, openp, read_buffer_size, read1)
3045 (substitute_object_recurse, read_vector, read_list, map_obarray):
3046 Use ptrdiff_t, not int, for sizes.
3047 (read1): Use EMACS_INT, not int, for sizes.
3048 Check for size overflow.
3050 * image.c (cache_image): Check for size arithmetic overflow.
3052 * lread.c: Integer overflow issues.
3053 (saved_doc_string_size, saved_doc_string_length)
3054 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3055 Now ptrdiff_t, not int.
3056 (read1): Don't assume doc string length fits in int. Check for
3057 out-of-range doc string lengths.
3058 (read_list): Don't assume file position fits in int.
3059 (read_escape): Check for hex character overflow.
3061 2011-06-22 Leo Liu <sdl.web@gmail.com>
3063 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3064 Move to minibuffer.el.
3066 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3068 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3069 The following patches are for when GLYPH_DEBUG && !XASSERT.
3070 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3071 * dispnew.c (flush_stdout):
3072 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3073 Mark as externally visible.
3074 * dispnew.c (check_window_matrix_pointers): Now static.
3075 * dispnew.c (window_to_frame_vpos):
3076 * xfns.c (unwind_create_frame):
3077 * xterm.c (x_check_font): Remove unused local.
3078 * scroll.c (CHECK_BOUNDS):
3079 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3080 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3081 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3082 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3083 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3085 (debug_method_add): Use va_list and vsprintf rather than relying
3086 on undefined behavior with wrong number of arguments.
3087 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3088 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3089 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3090 since we're not interested in debugging glyphs with old libraries.
3091 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3092 GCC 4.6.0's static checking.
3094 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3096 Integer overflow and signedness fixes (Bug#8873).
3097 A few related buffer overrun fixes, too.
3099 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3101 * dispextern.h (struct face.stipple):
3102 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3103 (x_bitmap_mask, x_allocate_bitmap_record)
3104 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3105 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3106 (x_create_bitmap_from_xpm_data):
3107 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3108 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3110 * xfaces.c (load_pixmap):
3111 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3112 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3113 (.bitmaps_last, struct x_output.icon_bitmap):
3114 Use ptrdiff_t, not int, for bitmap indexes.
3115 (x_allocate_bitmap_record): Check for size overflow.
3116 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3118 Use ptrdiff_t, not int, for overlay counts.
3119 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3120 * editfns.c (overlays_around, get_pos_property):
3121 * textprop.c (get_char_property_and_overlay):
3122 * xdisp.c (next_overlay_change, note_mouse_highlight):
3123 * xfaces.c (face_at_buffer_position):
3124 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3125 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3126 (Fnext_overlay_change, Fprevious_overlay_change)
3127 (mouse_face_overlay_overlaps, Foverlays_in):
3128 Use ptrdiff_t, not int, for sizes.
3129 (overlays_at, overlays_in): Check for size-calculation overflow.
3131 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3133 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3134 (x_session_initialize): Do not assume string length fits in int.
3136 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3137 This is unlikely, but can occur if DPI is outlandish.
3139 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3140 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3142 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3143 * xrdb.c (magic_file_p, search_magic_path):
3144 Omit last arg SUFFIX; it was always 0. All callers changed.
3145 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3147 * xfont.c (xfont_match): Avoid need for strlen.
3149 * xfns.c: Don't assume strlen fits in int.
3150 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3152 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3153 not unsigned long, as we prefer signed integers. All callers changed.
3154 Detect integer overflow in repeat count.
3155 (message_dolog): Don't assume print length fits in 39 bytes.
3156 (display_mode_element): Don't assume strlen fits in int.
3158 * termcap.c: Don't assume sizes fit in int and never overflow.
3159 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3160 (gobble_line): Check for size-calculation overflow.
3162 * minibuf.c (Fread_buffer):
3163 * lread.c (intern, intern_c_string):
3164 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3165 Don't assume string length fits in int.
3167 * keyboard.c (parse_tool_bar_item):
3168 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3170 * font.c: Don't assume string length fits in int.
3171 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3172 Use ptrdiff_t, not int.
3173 (font_intern_prop): Don't assume string length fits in int.
3174 Don't assume integer property fits in fixnum.
3175 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3177 * filelock.c: Fix some buffer overrun and integer overflow issues.
3178 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3179 Reformulate so as not to need the command string.
3180 Invoke gzip -cd rather than gunzip, as it's more portable.
3181 (lock_info_type, lock_file_1, lock_file):
3182 Don't assume pid_t and time_t fit in unsigned long.
3183 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3184 (current_lock_owner): Prefer signed type for sizes.
3185 Use memcpy, not strncpy, where memcpy is what is really wanted.
3186 Don't assume (via atoi) that time_t and pid_t fit in int.
3187 Check for time_t and/or pid_t out of range, e.g., via a network share.
3188 Don't alloca where an auto var works fine.
3190 * fileio.c: Fix some integer overflow issues.
3191 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3192 Don't assume string length fits in int.
3193 (directory_file_name): Don't assume string length fits in long.
3194 (make_temp_name): Don't assume pid fits in int, or that its print
3195 length is less than 20.
3197 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3199 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3201 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3203 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3204 We prefer signed integers, even for size calculations.
3206 * emacs.c: Don't assume string length fits in 'int'.
3207 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3208 (main): Don't invoke strlen when not needed.
3210 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3211 (XD_DEBUG_MESSAGE): Don't waste a byte.
3213 * callproc.c (getenv_internal_1, getenv_internal)
3215 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3217 * lread.c (invalid_syntax): Omit length argument.
3218 All uses changed. This doesn't fix a bug, but it simplifies the
3219 code away from its former Hollerith-constant appearance, and it's
3220 one less 'int' to worry about when looking at integer-overflow issues.
3221 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3223 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3224 This didn't break anything, but it didn't help either.
3225 It's confusing to put a bogus integer in a place where the actual
3226 value does not matter.
3227 (LIST_END_P): Remove unused macro and its bogus comment.
3228 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3230 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3231 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3233 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3234 We prefer signed types, and the value cannot exceed the EMACS_INT
3235 range anyway (because otherwise the length would not be representable).
3236 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3237 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3238 This avoids a GCC warning when WIDE_EMACS_INT.
3240 * indent.c (sane_tab_width): New function.
3241 (current_column, scan_for_column, Findent_to, position_indentation)
3242 (compute_motion): Use it. This is just for clarity.
3243 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3245 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3247 * lisp.h (lint_assume): New macro.
3248 * composite.c (composition_gstring_put_cache):
3249 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3251 * editfns.c, insdel.c:
3252 Omit unnecessary forward decls, to simplify future changes.
3254 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3256 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3258 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3259 Use much-faster test for byte-length change.
3260 Don't assume string byte-length fits in 'int'.
3261 Check that character arg fits in 'int'.
3262 (mapcar1): Declare byte as byte, for clarity.
3264 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3266 * fns.c (concat): Catch string overflow earlier.
3267 Do not rely on integer wraparound.
3269 * dispextern.h (struct it.overlay_strings_charpos)
3270 (struct it.selective): Now EMACS_INT, not int.
3271 * xdisp.c (forward_to_next_line_start)
3272 (back_to_previous_visible_line_start)
3273 (reseat_at_next_visible_line_start, next_element_from_buffer):
3274 Don't arbitrarily truncate the value of 'selective' to int.
3276 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3278 * composite.c: Don't truncate sizes to 'int'.
3279 (composition_gstring_p, composition_reseat_it)
3280 (composition_adjust_point): Use EMACS_INT, not int.
3281 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3282 not EMACS_UINT, for indexes.
3284 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3286 * buffer.c: Include <verify.h>.
3287 (struct sortvec.priority, struct sortstr.priority):
3288 Now EMACS_INT, not int.
3289 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3290 (struct sortstr.size, record_overlay_string)
3291 (struct sortstrlist.size, struct sortlist.used):
3292 Don't truncate size to int.
3293 (record_overlay_string): Check for size-calculation overflow.
3294 (init_buffer_once): Check at compile-time, not run-time.
3296 2011-06-22 Jim Meyering <meyering@redhat.com>
3298 Don't leak an XBM-image-sized buffer
3299 * image.c (xbm_load): Free the image buffer after using it.
3301 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3304 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3305 that Sun C diagnosed.
3306 * fns.c (secure_hash): Fix pointer signedness issue.
3307 * intervals.c (static_offset_intervals): New function.
3308 (offset_intervals): Use it.
3310 2011-06-21 Leo Liu <sdl.web@gmail.com>
3313 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3316 * fns.c (secure_hash): Rename from crypto_hash_function and change
3317 the first arg to accept symbols.
3318 (Fsecure_hash): New primitive.
3319 (syms_of_fns): New symbols.
3321 2011-06-20 Deniz Dogan <deniz@dogan.se>
3323 * process.c (Fset_process_buffer): Clarify return value in
3326 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3328 * dispnew.c (add_window_display_history): Use BVAR.
3330 * xdisp.c (debug_method_add): Use BVAR.
3331 (check_window_end, dump_glyph_matrix, dump_glyph)
3332 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3334 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3337 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3338 check till after the cache is created in init_frame_faces.
3340 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3342 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3344 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3346 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3347 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3348 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3350 Improve buffer-overflow checking (Bug#8873).
3351 * fileio.c (Finsert_file_contents):
3352 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3353 Remove the old (too-loose) buffer overflow checks.
3354 They weren't needed, since make_gap checks for buffer overflow.
3355 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3356 The old code merely checked for Emacs fixnum overflow, and relied
3357 on undefined (wraparound) behavior. The new code avoids undefined
3358 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3360 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3361 Tune. Don't use wider integers than needed. Don't use alloca.
3362 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3364 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3366 * insdel.c, lisp.h (buffer_overflow): New function.
3367 (insert_from_buffer_1, replace_range, replace_range_2):
3368 * insdel.c (make_gap_larger):
3369 * editfns.c (Finsert_char):
3370 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3372 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3374 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3376 Integer overflow and signedness fixes (Bug#8873).
3378 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3379 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3381 * fileio.c: Don't assume EMACS_INT fits in off_t.
3382 (emacs_lseek): New static function.
3383 (Finsert_file_contents, Fwrite_region): Use it.
3384 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3386 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3388 * fns.c: Don't overflow int when computing a list length.
3389 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3390 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3391 truncation on 64-bit hosts. Check for QUIT every
3392 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3393 faster and is responsive enough.
3394 (Flength): Report an error instead of overflowing an integer.
3395 (Fsafe_length): Return a float if the value is not representable
3396 as a fixnum. This shouldn't happen except in contrived situations.
3397 (Fnthcdr, Fsort): Don't assume list length fits in int.
3398 (Fcopy_sequence): Don't assume vector length fits in int.
3400 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3401 (header_size, word_size): New constants.
3402 (allocate_vectorlike): Don't check size overflow here.
3403 (allocate_vector): Check it here instead, since this is the only
3404 caller of allocate_vectorlike that could cause overflow.
3405 Check that the new vector's length is representable as a fixnum.
3407 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3408 The previous code was bogus. For example, next_almost_prime (32)
3409 returned 39, which is undesirable as it is a multiple of 3; and
3410 next_almost_prime (24) returned 25, which is a multiple of 5 so
3411 why was the code bothering to check for multiples of 7?
3413 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3415 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3417 Variadic C functions now count arguments with ptrdiff_t.
3418 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3419 Back then I didn't know that the Emacs coding style prefers signed int.
3420 Also, in the meantime I found a few more instances where arguments
3421 were being counted with int, which may truncate counts on 64-bit
3422 machines, or EMACS_INT, which may be unnecessarily wide.
3423 * lisp.h (struct Lisp_Subr.function.aMANY)
3424 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3425 Arg counts are now ptrdiff_t, not size_t.
3426 All variadic functions and their callers changed accordingly.
3427 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3428 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3429 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3430 * callint.c (Fcall_interactively): Check arg count for overflow,
3431 to avoid potential buffer overrun. Use signed char, not 'int',
3432 for 'varies' array, so that we needn't bother to check its size
3433 calculation for overflow.
3434 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3435 * eval.c (apply_lambda):
3436 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3437 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3438 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3440 * callint.c (Fcall_interactively): Don't use index var as event count.
3442 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3443 * mem-limits.h (SIZE): Remove; no longer used.
3445 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3447 Remove unnecessary casts.
3448 * xterm.c (x_term_init):
3449 * xfns.c (x_set_border_pixel):
3450 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3451 These aren't needed now that we assume ANSI C.
3453 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3454 It's more likely to cause problems (due to unsigned overflow)
3457 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3459 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3461 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3463 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3465 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3467 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3469 GLYPH_CODE_FACE returns EMACS_INT, not int.
3470 * dispextern.h (merge_faces):
3471 * xfaces.c (merge_faces):
3472 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3473 Don't assume EMACS_INT fits in int.
3475 * character.h (CHAR_VALID_P): Remove unused parameter.
3476 * fontset.c, lisp.h, xdisp.c: All uses changed.
3478 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3480 * fns.c (concat): Minor tuning based on overflow analysis.
3481 This doesn't fix any bugs. Use int to hold character, instead
3482 of constantly refetching from Emacs object. Use XFASTINT, not
3483 XINT, for value known to be a character. Don't bother comparing
3484 a single byte to 0400, as it's always less.
3486 * floatfns.c (Fexpt):
3487 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3489 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3492 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3494 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3495 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3496 incorrectly succeed when S was a string, because 4294967386 was
3497 truncated before it was used.
3499 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3500 Otherwise, an out-of-range integer could cause undefined behavior
3503 * composite.c: Use int, not EMACS_INT, for characters.
3504 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3505 EMACS_INT, for values that are known to be in character range.
3506 This doesn't fix any bugs but is the usual style inside Emacs and
3507 may generate better code on 32-bit machines.
3509 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3510 This is for reasons similar to the recent CHAR_STRING fix.
3511 * charset.c (Fencode_char): Check that character arg is actually
3512 a character. Pass an int to ENCODE_CHAR.
3513 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3514 wider than 'int', as a compile-time check to prevent future regressions
3517 * character.c (char_string): Remove unnecessary casts.
3519 Make sure a 64-bit char is never passed to CHAR_STRING.
3520 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3521 by silently ignoring the top 32 bits, allowing some values
3522 that were far too large to be valid characters.
3523 * character.h: Include <verify.h>.
3524 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3525 arguments are no wider than unsigned, as a compile-time check
3526 to prevent future regressions in this area.
3528 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3529 (Fsubst_char_in_region):
3531 * xdisp.c (decode_mode_spec_coding):
3532 Adjust to CHAR_STRING's new requirement.
3533 * editfns.c (Finsert_char, Fsubst_char_in_region):
3534 * fns.c (concat): Check that character args are actually
3535 characters. Without this test, these functions did the wrong
3536 thing with wildly out-of-range values on 64-bit hosts.
3538 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3539 These casts should not be needed on 32-bit hosts, either.
3540 * keyboard.c (read_char):
3541 * lread.c (Fload): Remove casts to unsigned.
3543 * lisp.h (UNSIGNED_CMP): New macro.
3544 This fixes comparison bugs on 64-bit hosts.
3545 (ASCII_CHAR_P): Use it.
3546 * casefiddle.c (casify_object):
3547 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3548 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3549 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3550 * dispextern.h (FACE_FROM_ID):
3551 * keyboard.c (read_char): Use UNSIGNED_CMP.
3553 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3554 not to EMACS_INT, to avoid GCC warning.
3556 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3558 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3559 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3560 isn't needed on 32-bit machines.
3562 * buffer.c (Fgenerate_new_buffer_name):
3563 Use EMACS_INT for count, not int.
3564 (advance_to_char_boundary): Return EMACS_INT, not int.
3566 * data.c (Qcompiled_function): Now static.
3568 * window.c (window_body_lines): Now static.
3570 * image.c (gif_load): Rename local to avoid shadowing.
3572 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3573 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3574 * alloc.c (make_save_value): Integer argument is now of type
3576 (mark_object): Use ptrdiff_t, not int.
3577 * lisp.h (pD): New macro.
3578 * print.c (print_object): Use it.
3580 * alloc.c: Use EMACS_INT, not int, to count objects.
3581 (total_conses, total_markers, total_symbols, total_vector_size)
3582 (total_free_conses, total_free_markers, total_free_symbols)
3583 (total_free_floats, total_floats, total_free_intervals)
3584 (total_intervals, total_strings, total_free_strings):
3585 Now EMACS_INT, not int. All uses changed.
3586 (Fgarbage_collect): Compute overall total using a double, so that
3587 integer overflow is less likely to be a problem. Check for overflow
3588 when converting back to an integer.
3589 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3590 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3591 These were 'int' variables that could overflow on 64-bit hosts;
3592 they were never used, so remove them instead of repairing them.
3593 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3594 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3595 Previously, this ceilinged at INT_MAX, but that doesn't work on
3597 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3599 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3600 (allocate_vectorlike): Check for ptrdiff_t overflow.
3601 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3602 when a (possibly-narrower) signed value would do just as well.
3603 We prefer using signed arithmetic, to avoid comparison confusion.
3605 * alloc.c: Catch some string size overflows that we were missing.
3606 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3607 for convenience in STRING_BYTES_MAX.
3608 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3609 The definition here is exact; the one in lisp.h was approximate.
3610 (allocate_string_data): Check for string overflow. This catches
3611 some instances we weren't catching before. Also, it catches
3612 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3613 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3614 and ptrdiff_t and EMACS_INT are both 64 bits.
3616 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3617 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3618 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3620 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3622 * alloc.c (Fmake_string): Check for out-of-range init.
3624 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3626 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3628 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3630 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3631 xg_get_default_scrollbar_width.
3633 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3634 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3635 (style_changed_cb): Call update_theme_scrollbar_width and call
3636 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3637 all frames (Bug#8505).
3638 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3639 Call gtk_window_set_resizable if HAVE_GTK3.
3640 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3641 and height if HAVE_GTK3 (Bug#8505).
3642 (scroll_bar_width_for_theme): New variable.
3643 (update_theme_scrollbar_width): New function.
3644 (xg_get_default_scrollbar_width): Move code to
3645 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3646 (xg_initialize): Call update_theme_scrollbar_width.
3648 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3650 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3652 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3654 * frame.c (make_frame): Call other_buffer_safely instead of
3657 * window.c (temp_output_buffer_show): Call display_buffer with
3658 second argument Vtemp_buffer_show_specifiers and reset latter
3659 immediately after the call.
3660 (Vtemp_buffer_show_specifiers): New variable.
3661 (auto_window_vscroll_p, next_screen_context_lines)
3662 (Vscroll_preserve_screen_position): Remove leading asterisks from
3665 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3667 Fix minor problems found by GCC 4.6.0 static checking.
3668 * buffer.c (Qclone_number): Remove for now, as it's unused.
3669 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3670 (record_buffer): Remove unused local.
3671 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3672 (set_frame_buffer_list): Remove; unused.
3673 * frame.h (other_visible_frames): Remove decl.
3674 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3675 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3676 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3678 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3679 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3680 Define only if HAVE_GPM.
3681 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3682 (update_hints_inhibit): Remove; never set. All uses removed.
3683 * widgetprv.h (emacsFrameClassRec): Remove decl.
3684 * window.c (delete_deletable_window): Now returns void, since it
3685 wasn't returning anything.
3686 (compare_window_configurations): Remove unused locals.
3687 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3688 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3689 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3690 the same widths as pointers. This follows up on the 2011-05-06 patch.
3691 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3692 * xterm.h: Likewise.
3693 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3695 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3697 * makefile.w32-in: Update dependencies.
3698 (LISP_H): Add lib/intprops.h.
3700 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3702 * image.c (gif_load): Add animation frame delay to the metadata.
3703 (syms_of_image): Use DEFSYM. New symbol `delay'.
3705 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3707 * window.c (delete_deletable_window): Re-add.
3708 (Fset_window_configuration): Rewrite to handle dead buffers and
3709 consequently deletable windows.
3710 (window_tree, Fwindow_tree): Remove. Supply functionality in
3712 (compare_window_configurations): Simplify code.
3714 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3716 * image.c (imagemagick_load_image): Fix type mismatch.
3717 (Fimagemagick_types): Likewise.
3719 * window.h (replace_buffer_in_windows): Declare.
3721 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3723 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3724 Qclone_number. Remove external declaration of Qdelete_window.
3725 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3727 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3728 Run Qbuffer_list_update_hook if allowed.
3729 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3730 buffer list implementation.
3731 (other_buffer_safely): New function.
3732 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3733 calls to replace_buffer_in_windows and
3734 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3736 (record_buffer): Inhibit quitting and rewrite using quittable
3737 functions. Run Qbuffer_list_update_hook if allowed.
3738 (Frecord_buffer, Funrecord_buffer): New functions.
3739 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3740 Move switch-to-buffer to window.el.
3741 (bury-buffer): Move to window.el.
3742 (Vbuffer_list_update_hook): New variable.
3744 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3747 * window.h (resize_frame_windows): Move up in code.
3748 (Fwindow_frame): Remove EXFUN.
3749 (replace_buffer_in_all_windows): Remove prototype.
3750 (replace_buffer_in_windows_safely): Add prototype.
3752 * window.c: Declare Qdelete_window static again. Move down
3753 declaration of select_count.
3754 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3755 (Fother_window): Move to window.el.
3756 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3757 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3758 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3760 (replace_buffer_in_windows): Implement by calling
3761 Qreplace_buffer_in_windows.
3762 (replace_buffer_in_all_windows): Remove with some functionality
3763 moved into replace_buffer_in_windows_safely.
3764 (replace_buffer_in_windows_safely): New function.
3765 (select_window_norecord, select_frame_norecord): Move in front
3766 of run_window_configuration_change_hook. Remove now obsolete
3768 (Fset_window_buffer): Rewrite doc-string.
3769 Call Qrecord_window_buffer.
3770 (keys_of_window): Move binding for other-window to window.el.
3772 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3774 * dispextern.h (struct image): Replace data member, whose int_val
3775 and ptr_val fields were not used by anything, with a single
3778 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3779 (gif_clear_image, gif_load, imagemagick_load_image)
3780 (gs_clear_image, gs_load): Callers changed.
3782 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3784 * buffer.h: Include <time.h>, for time_t.
3785 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3787 Fix minor problems found by static checking.
3789 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3791 Make identifiers static if they are not used in other modules.
3792 * data.c (Qcompiled_function, Qframe, Qvector):
3793 * image.c (QimageMagick, Qsvg):
3794 * minibuf.c (Qmetadata):
3795 * window.c (resize_window_check, resize_root_window): Now static.
3796 * window.h (resize_window_check, resize_root_window): Remove decls.
3798 * window.c (window_deletion_count, delete_deletable_window):
3800 (window_body_lines): Now static.
3801 (Fdelete_other_windows_internal): Mark vars as initialized.
3802 Make sure 'resize_failed' is initialized.
3803 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3804 (resize_window_apply): Remove unused local.
3805 * window.h (delete_deletable_window): Remove decl.
3807 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3808 (imagemagick_load_image): Fix pointer signedness problem by changing
3809 last arg from unsigned char * to char *. All uses changed.
3810 Also, fix a local for similar reasons.
3811 Remove unused locals. Remove locals to avoid shadowing.
3812 (fn_rsvg_handle_free): Remove; unused.
3813 (svg_load, svg_load_image): Fix pointer signedness problem.
3814 (imagemagick_load_image): Don't use garbage pointer image_wand.
3816 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3818 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3820 * image.c (gif_load): Fix omitted cast error introduced by
3823 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3825 * window.h (resize_proportionally, orig_total_lines)
3826 (orig_top_line): Remove from window structure.
3827 (set_window_height, set_window_width, change_window_heights)
3828 (Fdelete_window): Remove prototypes.
3829 (resize_frame_windows): Remove duplicate declaration.
3831 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3833 * window.h (resize_frame_windows, resize_window_check)
3834 (delete_deletable_window, resize_root_window)
3835 (resize_frame_windows): Declare prototypes.
3837 * window.c (resize_window_apply): Make definition be "static" to
3838 match the prototype.
3840 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3842 * window.c: Remove declarations of Qwindow_size_fixed,
3843 window_min_size_1, window_min_size_2, window_min_size,
3844 size_window, window_fixed_size_p, enlarge_window, delete_window.
3845 Remove static from declaration of Qdelete_window, it's
3846 temporarily needed by Fbury_buffer.
3847 (replace_window): Don't assign orig_top_line and
3849 (Fdelete_window, delete_window): Remove. Window deletion is
3850 handled by window.el.
3851 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3852 Replace Fdelete_window calls with calls to Qdelete_window.
3853 (Fdelete_other_windows): Remove. Deleting other windows is
3854 handled by window.el.
3855 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3856 handled in window.el.
3857 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3858 Window minimum sizes are handled in window.el.
3859 (shrink_windows, size_window, set_window_height)
3860 (set_window_width, change_window_heights, window_height)
3861 (window_width, CURBEG, CURSIZE, enlarge_window)
3862 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3863 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3864 handled in window.el.
3865 (make_dummy_parent): Rename to make_parent_window and give it a
3866 second argument horflag.
3867 (make_window): Don't set resize_proportionally any more.
3868 (Fsplit_window): Remove. Windows are split in window.el.
3869 (save_restore_action, save_restore_orig_size)
3870 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3871 Resize mini windows in window.el.
3872 (grow_mini_window, shrink_mini_window): Implement by calling
3873 Qresize_root_window_vertically, resize_window_check and
3874 resize_window_apply.
3875 (saved_window, Fset_window_configuration, save_window_save):
3876 Do not handle orig_top_line, orig_total_lines, and
3877 resize_proportionally.
3878 (window_min_height, window_min_width): Move to window.el.
3879 (keys_of_window): Move bindings for delete-other-windows,
3880 split-window, delete-window and enlarge-window to window.el.
3882 * buffer.c: Temporarily extern Qdelete_window.
3883 (Fbury_buffer): Temporarily call Qdelete_window instead of
3884 Fdelete_window (Fbury_buffer will move to window.el soon).
3886 * frame.c (set_menu_bar_lines_1): Remove code handling
3887 orig_top_line and orig_total_lines.
3889 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3890 set_window_height but set heights directly.
3891 (change_frame_size_1): Use resize_frame_windows.
3893 * xdisp.c (init_xdisp): Don't use set_window_height but set
3896 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3897 Use resize_frame_windows instead of change_window_heights and run
3898 run_window_configuration_change_hook.
3900 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3901 instead of change_window_heights and run
3902 run_window_configuration_change_hook.
3904 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3906 * window.c (replace_window): Rename second argument REPLACEMENT to
3907 NEW. New third argument SETFLAG. Rewrite.
3908 (delete_window, make_dummy_parent): Call replace_window with
3910 (window_list_1): Move down in code.
3911 (run_window_configuration_change_hook): Move set_buffer part
3912 before select_frame_norecord part in order to unwind correctly.
3913 Rename count1 to count.
3914 (recombine_windows, delete_deletable_window, resize_root_window)
3915 (Fdelete_other_windows_internal)
3916 (Frun_window_configuration_change_hook, make_parent_window)
3917 (resize_window_check, resize_window_apply, Fresize_window_apply)
3918 (resize_frame_windows, Fsplit_window_internal)
3919 (Fdelete_window_internal, Fresize_mini_window_internal):
3921 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3923 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3925 * window.h (window): Add some new members to window structure -
3926 normal_lines, normal_cols, new_total, new_normal, clone_number,
3927 splits, nest, prev_buffers, next_buffers.
3928 (WINDOW_TOTAL_SIZE): Move here from window.c.
3929 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3931 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3933 (make_dummy_parent): Set new members of windows structure.
3934 (make_window): Move down in code. Handle new members of window
3936 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3937 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3938 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3939 (Fset_window_prev_buffers, Fwindow_next_buffers)
3940 (Fset_window_next_buffers, Fset_window_clone_number):
3942 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3943 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3945 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3946 Argument WINDOW can be now internal window too.
3947 (Fwindow_use_time): Move up in code.
3948 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3950 (Fset_window_configuration, saved_window)
3951 (Fcurrent_window_configuration, save_window_save): Handle new
3952 members of window structure.
3953 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3954 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3955 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3956 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3957 Qget_mru_window, Qresize_root_window,
3958 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3959 Qauto_buffer_name; staticpro them.
3961 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3963 * window.c (Fwindow_total_size, Fwindow_left_column)
3964 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3965 (Fwindow_list_1): New functions.
3966 (window_box_text_cols): Replace with window_body_cols.
3967 (Fwindow_width, Fscroll_left, Fscroll_right):
3968 Use window_body_cols instead of window_box_text_cols.
3969 (delete_window, Fset_window_configuration):
3970 Call delete_all_subwindows with window as argument.
3971 (delete_all_subwindows): Take a window as argument and not a
3973 (window_loop): Remove handling of GET_LRU_WINDOW and
3975 (Fget_lru_window, Fget_largest_window): Move to window.el.
3977 * window.h: Extern window_body_cols instead of
3978 window_box_text_cols. delete_all_subwindows now takes a
3979 Lisp_Object as argument.
3981 * indent.c (compute_motion, Fcompute_motion):
3982 Use window_body_cols instead of window_box_text_cols.
3984 * frame.c (delete_frame): Call delete_all_subwindows with root
3987 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3989 * fns.c (Fputhash): Document return value.
3991 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3993 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3995 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3997 Cons<->int and similar integer overflow fixes (Bug#8794).
3999 Check for overflow when converting integer to cons and back.
4000 * charset.c (Fdefine_charset_internal, Fdecode_char):
4001 Use cons_to_unsigned to catch overflow.
4002 (Fencode_char): Use INTEGER_TO_CONS.
4003 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4004 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4005 * data.c (long_to_cons, cons_to_long): Remove.
4006 (cons_to_unsigned, cons_to_signed): New functions.
4007 These signal an error for invalid or out-of-range values.
4008 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4009 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4010 * font.c (Ffont_variation_glyphs):
4011 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4012 * lisp.h: Include <intprops.h>.
4013 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4014 (cons_to_signed, cons_to_unsigned): New decls.
4015 (long_to_cons, cons_to_long): Remove decls.
4016 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4017 (Fprimitive_undo): Use CONS_TO_INTEGER.
4018 * xfns.c (Fx_window_property): Likewise.
4019 * xselect.c: Include <limits.h>.
4020 (x_own_selection, selection_data_to_lisp_data):
4021 Use INTEGER_TO_CONS.
4022 (x_handle_selection_request, x_handle_selection_clear)
4023 (x_get_foreign_selection, Fx_disown_selection_internal)
4024 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4025 (lisp_data_to_selection_data): Use cons_to_unsigned.
4026 (x_fill_property_data): Use cons_to_signed.
4027 Report values out of range.
4029 Check for buffer and string overflow more precisely.
4030 * buffer.h (BUF_BYTES_MAX): New macro.
4031 * lisp.h (STRING_BYTES_MAX): New macro.
4032 * alloc.c (Fmake_string):
4033 * character.c (string_escape_byte8):
4034 * coding.c (coding_alloc_by_realloc):
4035 * doprnt.c (doprnt):
4036 * editfns.c (Fformat):
4038 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4039 since they may not be the same number.
4040 * editfns.c (Finsert_char):
4041 * fileio.c (Finsert_file_contents):
4042 Likewise for BUF_BYTES_MAX.
4044 * image.c: Use ptrdiff_t, not int, for sizes.
4045 (slurp_file): Switch from int to ptrdiff_t.
4047 (slurp_file): Check that file size fits in both size_t (for
4048 malloc) and ptrdiff_t (for sanity and safety).
4050 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4051 if b->modtime has its maximal value.
4053 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4055 Don't assume time_t can fit into int.
4056 * buffer.h (struct buffer.modtime): Now time_t, not int.
4057 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4058 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4060 Minor fixes for signed vs unsigned integers.
4061 * character.h (MAYBE_UNIFY_CHAR):
4062 * charset.c (maybe_unify_char):
4063 * keyboard.c (read_char, reorder_modifiers):
4064 XINT -> XFASTINT, since the integer must be nonnegative.
4065 * ftfont.c (ftfont_spec_pattern):
4066 * keymap.c (access_keymap, silly_event_symbol_error):
4067 XUINT -> XFASTINT, since the integer must be nonnegative.
4068 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4069 since it makes no difference and we prefer signed.
4070 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4071 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4074 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4076 * window.h (Fwindow_frame): Declare.
4078 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4080 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4081 (SPARE_MEMORY): Always define.
4082 (LARGE_REQUEST): Remove.
4083 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4085 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4087 * lisp.h: Move EXFUNS for Fframe_root_window,
4088 Fframe_first_window and Fset_frame_selected_window to window.h.
4090 * window.h: Move EXFUNS for Fframe_root_window,
4091 Fframe_first_window and Fset_frame_selected_window here from
4094 * frame.c (Fwindow_frame, Fframe_first_window)
4095 (Fframe_root_window, Fframe_selected_window)
4096 (Fset_frame_selected_window): Move to window.c.
4097 (Factive_minibuffer_window): Move to minibuf.c.
4098 (Fother_visible_frames_p): New function.
4100 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4102 * window.c (decode_window, decode_any_window): Move up in code.
4103 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4104 (inhibit_frame_unsplittable): Remove unused variable.
4105 (Fwindow_buffer): Move up and rewrite doc-string.
4106 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4107 (Fwindow_prev): New functions.
4108 (Fwindow_frame): Move here from frame.c. Accept any window as
4110 (Fframe_root_window, Fframe_first_window)
4111 (Fframe_selected_window): Move here from frame.c. Accept frame
4112 or arbitrary window as argument. Update doc-strings.
4113 (Fminibuffer_window): Move up in code.
4114 (Fwindow_minibuffer_p): Move up in code and simplify.
4115 (Fset_frame_selected_window): Move here from frame.c.
4117 (Fselected_window, select_window, Fselect_window): Move up in
4118 code. Minor doc-string fixes.
4120 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4122 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4123 Do not assume that spare memory exists; that assumption is valid
4124 only if SYSTEM_MALLOC.
4125 (LARGE_REQUEST): New macro, so that the issue of large requests
4126 is separated from the issue of spare memory.
4128 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4130 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4133 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4135 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4138 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4140 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4142 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4144 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4145 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4147 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4149 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4151 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4153 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4154 (x_clipboard_manager_save): Add return value.
4155 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4157 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4158 Obey Vx_select_enable_clipboard_manager. Catch errors in
4159 x_clipboard_manager_save (Bug#8779).
4160 (Vx_select_enable_clipboard_manager): New variable.
4161 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4163 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4165 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4167 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4169 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4170 in the current matrix if keep_current_p is non-zero.
4172 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4174 * bidi.c (bidi_level_of_next_char): Fix last change.
4176 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4178 Support bidi reordering of text covered by display properties.
4180 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4181 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4182 (bidi_cache_search, bidi_cache_iterator_state)
4183 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4184 (bidi_level_of_next_char, bidi_move_to_visually_next):
4185 Support character positions inside a run of characters covered by a
4187 (bidi_paragraph_init, bidi_resolve_explicit_1)
4188 (bidi_level_of_next_char): Call bidi_fetch_char and
4189 bidi_fetch_char_advance instead of FETCH_CHAR and
4191 (bidi_init_it): Initialize new members.
4192 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4194 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4195 instead of using explicit *_CHAR codes.
4196 (bidi_resolve_explicit, bidi_resolve_weak):
4197 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4198 bidirectional text is supported only in multibyte buffers.
4199 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4200 it to initialize the frame_window_p member of struct bidi_it.
4201 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4202 (bidi_resolve_explicit, bidi_resolve_weak)
4203 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4204 bidi_it->nchars is non-positive.
4205 (bidi_level_of_next_char): Don't try to lookup the cache for the
4206 next/previous character if nothing is cached there yet, or if we
4207 were just reseat()'ed to a new position.
4209 * xdisp.c (set_cursor_from_row): Set start and stop points
4210 according to the row's direction when priming the loop that looks
4211 for the glyph on which to display cursor.
4212 (single_display_spec_intangible_p): Function deleted.
4213 (display_prop_intangible_p): Reimplement to call
4214 handle_display_spec instead of single_display_spec_intangible_p.
4215 Accept 3 additional arguments needed by handle_display_spec.
4216 This fixes incorrect cursor motion across display property with complex
4217 values: lists, `(when COND...)' forms, etc.
4218 (single_display_spec_string_p): Support property values that are
4219 lists with the argument STRING its top-level element.
4220 (display_prop_string_p): Fix the condition for processing a
4221 property that is a list to be consistent with handle_display_spec.
4222 (handle_display_spec): New function, refactored from the
4223 last portion of handle_display_prop.
4224 (compute_display_string_pos): Accept additional argument
4225 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4226 value of a `display' property is a "replacing spec".
4227 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4228 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4229 the display property, but just return a value indicating whether
4230 the display property will replace the characters it covers.
4231 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4232 frame_window_p members of struct bidi_it.
4233 (compute_display_string_pos, compute_display_string_end):
4235 (push_it): Accept second argument POSITION, where pop_it should
4236 jump to continue iteration.
4237 (reseat_1): Initialize bidi_it.disp_pos.
4239 * keyboard.c (adjust_point_for_property): Adjust the call to
4240 display_prop_intangible_p to its new signature.
4242 * dispextern.h (struct bidi_it): New member frame_window_p.
4243 (bidi_init_it): Update prototypes.
4244 (display_prop_intangible_p): Update prototype.
4245 (compute_display_string_pos, compute_display_string_end):
4247 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4250 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4252 Malloc failure behavior now depends on size of allocation.
4253 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4254 * lisp.h: Change signatures accordingly.
4255 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4256 All callers changed. (Bug#8762)
4258 * gnutls.c: Use Emacs's memory allocators.
4259 Without this change, the gnutls library would invoke malloc etc.
4260 directly, which causes problems on non-SYNC_INPUT hosts, and which
4261 runs afoul of improving memory_full behavior. (Bug#8761)
4262 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4263 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4264 xfree instead of the default malloc, realloc, free.
4265 (Fgnutls_boot): No need to check for memory allocation failure,
4266 since xmalloc does that for us.
4268 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4269 * category.c (hash_get_category_set):
4270 * ccl.c (ccl_driver):
4271 * charset.c (Fdefine_charset_internal):
4272 * charset.h (struct charset.hash_index):
4273 * composite.c (get_composition_id, gstring_lookup_cache)
4274 (composition_gstring_put_cache):
4275 * composite.h (struct composition.hash_index):
4276 * dispextern.h (struct image.hash):
4277 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4278 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4279 (hashfn_equal, hashfn_user_defined, make_hash_table)
4280 (maybe_resize_hash_table, hash_lookup, hash_put)
4281 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4282 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4283 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4284 * image.c (make_image, search_image_cache, lookup_image)
4285 (xpm_put_color_table_h):
4286 * lisp.h (struct Lisp_Hash_Table):
4287 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4288 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4289 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4290 * alloc.c (allocate_vectorlike):
4291 Check for overflow in vector size calculations.
4292 * ccl.c (ccl_driver):
4293 Check for overflow when converting EMACS_INT to int.
4294 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4295 need to be updated by these changes.
4296 * fns.c (make_hash_table, maybe_resize_hash_table):
4297 Check for integer overflow with large hash tables.
4298 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4299 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4300 (SXHASH_REDUCE): New macro.
4301 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4302 Use it instead of discarding useful hash info with large hash values.
4303 (sxhash_float): New function.
4304 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4305 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4306 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4307 Rewrite to use FIXNUM_BITS, as this simplifies things.
4308 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4309 Adjust signatures to match updated version of code.
4310 (consing_since_gc): Now EMACS_INT, since a single hash table can
4311 use more than INT_MAX bytes.
4313 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4315 Make it possible to build with GCC-4.6+ -O2 -flto.
4317 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4319 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4321 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4322 Call minibuffer-inactive-mode.
4324 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4326 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4327 Update dependencies.
4329 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4331 * data.c (init_data): Remove code for UTS, this system is not
4334 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4336 Don't force ./temacs to start in terminal mode.
4338 * frame.c (make_initial_frame): Initialize faces in all cases, not
4339 only when CANNOT_DUMP is defined.
4340 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4342 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4344 * dispnew.c (add_window_display_history): Use const for the string
4345 pointer. Remove declaration, not needed.
4347 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4349 Use 'inline', not 'INLINE'.
4350 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4351 * alloc.c, fontset.c (INLINE): Remove.
4352 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4353 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4354 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4355 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4356 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4358 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4360 Make it possible to run ./temacs.
4362 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4363 syms_of_callproc does the same thing. Remove test for
4364 "initialized", do it in the caller.
4365 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4367 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4369 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4370 (read_minibuf): Use get_minibuffer.
4371 (syms_of_minibuf): Use DEFSYM.
4372 (Qmetadata): New var.
4373 * data.c (Qbuffer): Don't make it static.
4374 (syms_of_data): Use DEFSYM.
4376 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4378 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4379 (CCL_CODE_MIN): New macro.
4381 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4383 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4385 * eval.c (Qdebug): Now static.
4386 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4387 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4388 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4390 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4392 * image.c: Various fixes to ImageMagick code comments.
4393 (Fimagemagick_types): Doc fix.
4395 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4397 Minor fixes prompted by GCC 4.6.0 warnings.
4399 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4401 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4402 (x_clipboard_manager_save_all): Move extern decl to ...
4403 * xterm.h: ... here, so that it can be checked for consistency.
4405 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4407 * xselect.c (x_clipboard_manager_save_frame)
4408 (x_clipboard_manager_save_all): New functions.
4409 (Fx_clipboard_manager_save): Lisp function deleted.
4411 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4412 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4414 * xterm.h: Update prototype.
4416 2011-05-28 William Xu <william.xwl@gmail.com>
4418 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4421 2011-05-28 Jim Meyering <meyering@redhat.com>
4423 Avoid a sign-extension bug in crypto_hash_function.
4424 * fns.c (to_uchar): Define.
4425 (crypto_hash_function): Use it to convert some newly-signed
4426 variables to unsigned, to avoid sign-extension bugs. For example,
4427 without this change, (md5 "truc") would evaluate to
4428 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4429 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4430 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4432 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4434 Integer overflow fixes.
4436 * dbusbind.c: Serial number integer overflow fixes.
4437 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4438 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4439 to hold a serial number that is too large for a fixnum.
4440 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4441 Check for serial numbers out of range. Decode any serial number
4442 that was so large that it became a float. (Bug#8722)
4444 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4445 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4446 Use XFASTINT rather than XUINT when numbers are nonnegative.
4447 (xd_append_arg, Fdbus_method_return_internal):
4448 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4449 arguments, check that Lisp number is nonnegative, rather than
4450 silently wrapping negative numbers around. (Bug#8722)
4451 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4454 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4456 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4458 ccl: add integer overflow checks
4459 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4460 (IN_INT_RANGE): New macros.
4461 (ccl_driver): Use them to check for integer overflow when
4462 decoding a CCL program. Many of the new checks are whether XINT (x)
4463 fits in int; it doesn't always, on 64-bit hosts. The new version
4464 doesn't catch all possible integer overflows, but it's an
4465 improvement. (Bug#8719)
4467 * alloc.c (make_event_array): Use XINT, not XUINT.
4468 There's no need for unsigned here.
4470 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4471 This follows up to the 2011-05-06 change that substituted uintptr_t
4472 for EMACS_INT. This case wasn't caught back then.
4474 Rework Fformat to avoid integer overflow issues.
4475 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4476 now (part of C89). Include <verify.h>.
4477 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4478 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4479 (Fformat): Avoid the prepass trying to compute sizes; it was only
4480 approximate and thus did not catch overflow reliably. Instead, walk
4481 through the format just once, formatting and computing sizes as we go,
4482 checking for integer overflow at every step, and allocating a larger
4483 buffer as needed. Keep track separately whether the format is
4484 multibyte. Keep only the most-recently calculated precision, rather
4485 than them all. Record whether each argument has been converted to
4486 string. Use EMACS_INT, not int, for byte and char and arg counts.
4487 Support field widths and precisions larger than INT_MAX. Avoid
4488 sprintf's undefined behavior with conversion specifications such as %#d
4489 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4490 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4491 formatting out-of-range floating point numbers with int
4494 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4496 * data.c: Avoid integer truncation in expressions involving floats.
4497 * data.c: Include <intprops.h>.
4498 (arith_driver): When there's an integer overflow in an expression
4499 involving floating point, convert the integers to floating point
4500 so that the resulting value does not suffer from catastrophic
4501 integer truncation. For example, on a 64-bit host (* 4
4502 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4503 Do not rely on undefined behavior after integer overflow.
4505 merge count_size_as_multibyte, parse_str_to_multibyte
4506 * character.c, character.h (count_size_as_multibyte):
4507 Rename from parse_str_to_multibyte; all uses changed.
4508 Check for integer overflow.
4509 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4510 since it's now a duplicate of the other. This is more of
4511 a character than a buffer op, so better that it's in character.c.
4512 * fns.c, print.c: Adjust to above changes.
4514 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4516 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4518 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4520 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4521 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4522 (x_clipboard_manager_save): Now static.
4523 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4525 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4526 (crypto_hash_function): Now static.
4527 Fix pointer signedness problems. Avoid unnecessary initializations.
4529 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4531 * termhooks.h (Vselection_alist): Make it terminal-local.
4533 * terminal.c (create_terminal): Initialize it.
4535 * xselect.c: Support for clipboard managers.
4536 (Vselection_alist): Move to termhooks.h as terminal-local var.
4537 (LOCAL_SELECTION): New macro.
4538 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4539 (symbol_to_x_atom): Remove gratuitous arg.
4540 (x_handle_selection_request, lisp_data_to_selection_data)
4541 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4542 (x_own_selection, x_get_local_selection, x_convert_selection):
4543 New arg, specifying work frame. Use terminal-local Vselection_alist.
4544 (some_frame_on_display): Delete unused function.
4545 (Fx_own_selection_internal, Fx_get_selection_internal)
4546 (Fx_disown_selection_internal, Fx_selection_owner_p)
4547 (Fx_selection_exists_p): New optional frame arg.
4548 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4549 (x_handle_selection_clear): Don't treat other terminals with the
4550 same keyboard specially. Use the terminal-local Vselection_alist.
4551 (x_clear_frame_selections): Use Frun_hook_with_args.
4553 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4555 * xterm.h: Add support for those atoms.
4557 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4559 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4560 (converted_selections, conversion_fail_tag): New global variables.
4561 (x_selection_request_lisp_error): Free the above.
4562 (x_get_local_selection): Remove unnecessary code.
4563 (x_reply_selection_request): Args changed; handle arbitrary array
4564 of converted selections stored in converted_selections.
4565 Separate the XChangeProperty and SelectionNotify steps.
4566 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4567 (x_convert_selection): New function.
4568 (x_handle_selection_event): Simplify.
4569 (x_get_foreign_selection): Don't ignore incoming requests while
4570 waiting for an answer; this will fail when we implement
4571 SAVE_TARGETS, and seems unnecessary anyway.
4572 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4573 (Vx_sent_selection_functions): Doc fix.
4575 2011-05-26 Leo Liu <sdl.web@gmail.com>
4577 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4579 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4581 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4583 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4584 for fringe update if it has periodic bitmap.
4585 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4586 and fringe_bitmap_periodic_p.
4588 * fringe.c (get_fringe_bitmap_data): New function.
4589 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4590 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4591 row. Mark glyph row for fringe update if periodicity changed.
4593 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4594 for fringe update unless it has periodic bitmap.
4596 2011-05-25 Kenichi Handa <handa@m17n.org>
4598 * xdisp.c (get_next_display_element): Set correct it->face_id for
4599 a static composition.
4601 2011-05-24 Leo Liu <sdl.web@gmail.com>
4604 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4606 * fns.c (crypto_hash_function, Fsha1): New function.
4607 (Fmd5): Use crypto_hash_function.
4608 (syms_of_fns): Add Ssha1.
4610 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4612 * gnutls.c: Remove unused macros.
4613 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4614 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4615 Remove macros that are defined and never used.
4616 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4618 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4620 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4621 (Fx_get_selection_internal): Minor cleanup.
4622 (Fx_own_selection_internal): Rename arguments for consistency with
4625 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4627 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4629 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4631 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4633 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4635 * dispnew.c (scrolling_window): Don't exclude the case that the
4636 last enabled row in the desired matrix touches the bottom boundary.
4638 2011-05-21 Glenn Morris <rgm@gnu.org>
4640 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4641 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4642 and add some more files.
4644 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4646 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4647 report_file_error introduced by the change from 2011-05-07.
4649 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4651 * systime.h (Time): Define only if emacs is defined.
4652 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4653 where the include path doesn't have X11/X.h by default. See
4654 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4656 2011-05-20 Kenichi Handa <handa@m17n.org>
4658 * composite.c (find_automatic_composition): Fix previous change.
4660 2011-05-20 Glenn Morris <rgm@gnu.org>
4662 * lisp.mk: New file, split from Makefile.in.
4663 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4664 (shortlisp): Remove.
4665 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4667 2011-05-19 Glenn Morris <rgm@gnu.org>
4669 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4670 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4671 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4672 (lisp): Set the order to that of loadup.el.
4673 (shortlisp): Make it a copy of $lisp.
4674 (SOME_MACHINE_LISP): Remove.
4675 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4676 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4678 2011-05-18 Kenichi Handa <handa@m17n.org>
4680 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4681 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4682 (find_automatic_composition): Mostly rewrite for efficiency.
4684 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4686 * makefile.w32-in: Update dependencies.
4688 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4690 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4691 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4693 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4695 Fix some integer overflow issues, such as string length overflow.
4697 * insdel.c (count_size_as_multibyte): Check for string overflow.
4699 * character.c (lisp_string_width): Check for string overflow.
4700 Use EMACS_INT, not int, for string indexes and lengths; in
4701 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4702 the resulting string length overflows an EMACS_INT; instead,
4703 report a string overflow if no precision given. When checking for
4704 precision exhaustion, use a check that cannot possibly have
4705 integer overflow. (Bug#8675)
4706 * character.h (lisp_string_width): Adjust to new signature.
4708 * alloc.c (string_overflow): New function.
4709 (Fmake_string): Use it. This doesn't change behavior, but saves
4710 a few bytes and will simplify future changes.
4711 * character.c (string_escape_byte8): Likewise.
4712 * lisp.h (string_overflow): New decl.
4714 Fixups, following up to the user-interface timestamp change.
4715 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4716 for UI timestamps, instead of unsigned long.
4717 * msdos.c (mouse_get_pos): Likewise.
4718 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4719 * w32gui.h (Time): Define by including "systime.h" rather than by
4720 declaring it ourselves. (Bug#8664)
4722 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4723 * image.c (clear_image_cache): Likewise.
4725 * term.c (term_mouse_position): Don't assume time_t wraparound.
4727 Be more systematic about user-interface timestamps.
4728 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4729 and sometimes 'EMACS_UINT', to represent these timestamps.
4730 This change causes it to use 'Time' uniformly, as that's what X uses.
4731 This makes the code easier to follow, and makes it easier to catch
4732 integer overflow bugs such as Bug#8664.
4733 * frame.c (Fmouse_position, Fmouse_pixel_position):
4734 Use Time, not unsigned long, for user-interface timestamps.
4735 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4736 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4737 * keyboard.h (last_event_timestamp): Likewise.
4738 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4739 * menu.h (xmenu_show): Likewise.
4740 * term.c (term_mouse_position): Likewise.
4741 * termhooks.h (struct input_event.timestamp): Likewise.
4742 (struct terminal.mouse_position_hook): Likewise.
4743 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4744 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4745 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4746 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4748 * menu.h, termhooks.h: Include "systime.h", for Time.
4750 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4751 Don't assume that the difference between two unsigned long values
4752 can fit into an integer. At this point, we know button_down_time
4753 <= event->timestamp, so the difference must be nonnegative, so
4754 there's no need to cast the result if double-click-time is
4755 nonnegative, as it should be; check that it's nonnegative, just in
4756 case. This bug is triggered when events are more than 2**31 ms
4757 apart (about 25 days). (Bug#8664)
4759 * xselect.c (last_event_timestamp): Remove duplicate decl.
4760 (x_own_selection): Remove needless cast to unsigned long.
4762 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4763 that always fit in int. Use a sentinel instead of a counter, to
4764 avoid a temp and to allay GCC's concerns about possible int overflow.
4765 * frame.h (struct frame): Use int for menu_bar_items_used
4766 instead of EMACS_INT, since it always fits in int.
4768 * menu.c (grow_menu_items): Check for int overflow.
4770 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4772 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4773 Before, the code was not consistent. These values cannot exceed
4774 2**31 - 1 so there's no need to make them unsigned.
4775 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4776 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4777 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4779 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4781 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4782 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4783 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4784 presumably because the widths might not match.
4786 * window.c (size_window): Avoid needless test at loop start.
4788 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4790 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4792 2011-05-12 Drew Adams <drew.adams@oracle.com>
4794 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4796 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4798 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4799 `width' to `bar_area_x' and `bar_area_width', respectively.
4800 (x_scroll_run): Take account of fringe background extension.
4802 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4803 Rename local vars `left' and `width' to `bar_area_x' and
4804 `bar_area_width', respectively.
4805 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4806 background extension.
4808 2011-05-10 Jim Meyering <meyering@redhat.com>
4810 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4812 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4814 * image.c (Finit_image_library): Return t for built-in image types,
4815 like pbm and xbm. (Bug#8640)
4817 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4819 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4821 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4823 * w32console.c (Fset_screen_color): Doc fix.
4824 (Fget_screen_color): New function.
4825 (syms_of_ntterm): Defsubr it.
4827 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4828 unlink the temporary file if Fcall_process didn't create it in the
4830 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4831 child process will be redirected to a file specified with `:file'.
4832 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4833 cue to call_process_cleanup not to close that handle.
4835 2011-05-07 Ben Key <bkey76@gmail.com>
4837 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4838 one of two shell specific rules, either bootstrap-temacs-CMD or
4839 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4840 to the previous implementation of the bootstrap-temacs rule.
4841 The bootstrap-temacs-CMD rule is similar to the previous
4842 implementation of the bootstrap-temacs rule except that it
4843 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4846 These changes, along with some changes to nt/configure.bat,
4847 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4848 earlier fix to add support for --cflags and --ldflags options
4849 that include quotes so that it works whether make uses cmd or
4852 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4854 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4855 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4857 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4858 a string. Handle both cases.
4859 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4860 (Fdbus_register_method): Use Qinvalid_function.
4862 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4864 * makefile.w32-in: Update dependencies.
4865 (LISP_H): Add inttypes.h and stdin.h.
4866 (PROCESS_H): Add unistd.h.
4868 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4870 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4871 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4873 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4875 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4877 * term.c (vfatal): Remove stray call to va_end.
4878 It's not needed and the C Standard doesn't allow it here anyway.
4880 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4881 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4883 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4886 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4888 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4890 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4892 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4894 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4896 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4897 * charset.c (Fdefine_charset_internal): Don't initialize
4898 charset.code_space[15]. The value was garbage, on hosts with
4899 32-bit int (Bug#8600).
4901 * lread.c (read_integer): Be more consistent with string-to-number.
4902 Use string_to_number to do the actual conversion; this avoids
4903 rounding errors and fixes some other screwups. Without this fix,
4904 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4905 (digit_to_number): Move earlier, for benefit of read_integer.
4906 Return -1 if the digit is out of range for the base, -2 if it is
4907 not a digit in any supported base. (Bug#8602)
4909 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4911 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4912 to match comment at start of function. This also removes a
4913 GCC warning about overflow in a 32+64-bit port.
4915 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4917 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4918 Reported by Stefan Monnier in
4919 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4920 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4921 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4923 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4924 (EMACS_UINTPTR): Likewise, with uintptr_t.
4926 * lisp.h: Prefer 64-bit EMACS_INT if available.
4927 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4928 on 32-bit hosts that have 64-bit int, so that they can access
4930 However, temporarily disable this change unless the temporary
4931 symbol WIDE_EMACS_INT is defined.
4933 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4935 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4936 This removes an assumption that EMACS_INT and long are the same
4937 width as pointers. The assumption is true for Emacs porting targets
4938 now, but we want to make other targets possible.
4939 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4940 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4941 In the rest of the code, change types of integers that hold casted
4942 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4943 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4944 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4945 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4946 No need to cast type when ORing.
4947 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4948 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4949 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4950 assume EMACS_INT is the same width as char *.
4951 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4952 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4953 Remove no-longer-needed casts.
4954 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4955 (xg_tool_bar_help_callback, xg_make_tool_item):
4956 Use EMACS_INTPTR to hold an integer
4957 that will be cast to void *; this can avoid a GCC warning
4958 if EMACS_INT is not the same width as void *.
4959 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4960 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4961 (current_message_1, set_message_1):
4962 Use a local to convert to proper width without a cast.
4963 * xmenu.c (dialog_selection_callback): Likewise.
4965 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4966 Also, don't assume VALBITS / RAND_BITS is less than 5,
4967 and don't rely on undefined behavior when shifting a 1 left into
4969 * lisp.h (get_random): Change signature to match.
4971 * lread.c (hash_string): Use size_t, not int, for hash computation.
4972 Normally we prefer signed values; but hashing is special, because
4973 it's better to use unsigned division on hash table sizes so that
4974 the remainder is nonnegative. Also, size_t is the natural width
4975 for hashing into memory. The previous code used 'int', which doesn't
4976 retain enough info to hash well into very large tables.
4977 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4979 * dbusbind.c: Don't possibly lose pointer info when converting.
4980 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4981 Use XPNTR rather than XHASH, so that the high-order bits of
4982 the pointer aren't lost when converting through void *.
4984 * eval.c (Fautoload): Don't double-shift a pointer.
4986 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4988 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4990 * gnutls.c (DEF_GNUTLS_FN):
4991 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4993 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4995 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4998 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5000 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5001 New version that can reserve upto 2GB of heap space.
5003 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5005 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5007 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5009 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5010 `gnutls_certificate_set_x509_key_file'.
5012 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5014 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5015 Update dependencies.
5017 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5019 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5020 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5021 Remove unused parameter `fildes'.
5022 * process.c (read_process_output, send_process): Don't pass it.
5024 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5026 Fix previous change: the library cache is defined in w32.c.
5027 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5028 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5030 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5032 Implement dynamic loading of GnuTLS on Windows.
5034 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5035 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5036 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5039 * gnutls.c (Qgnutls_dll): Define.
5040 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5041 (gnutls_*): Declare function pointers.
5042 (init_gnutls_functions): New function to initialize function pointers.
5043 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5044 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5045 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5046 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5047 (emacs_gnutls_write, emacs_gnutls_read)
5048 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5049 (Fgnutls_available_p): New function.
5050 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5051 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5052 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5054 * image.c: Include w32.h.
5055 (Vimage_type_cache): Delete.
5056 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5057 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5058 (w32_delayed_load): Move to w32.c.
5060 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5062 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5063 (w32_delayed_load): Move from image.c. When loading a library, record
5064 its filename in the :loaded-from property of the library id.
5065 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5066 Initialize and staticpro them.
5067 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5069 * process.c: Include lisp.h before w32.h, not after.
5070 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5071 instead of gnutls_record_check_pending.
5073 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5075 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5077 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5078 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5081 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5083 * xterm.c (x_set_frame_alpha): Do not set property on anything
5084 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5086 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5088 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5090 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5092 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5093 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5094 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5095 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5096 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5097 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5098 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5099 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5100 (Qgnutls_bootprop_callbacks_verify): Make static.
5102 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5104 * callproc.c: Indentation fixup.
5106 * sysdep.c (wait_for_termination_1): Make static.
5107 (wait_for_termination, interruptible_wait_for_termination):
5108 Move after wait_for_termination_1.
5110 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5112 * sysdep.c (interruptible_wait_for_termination): New function
5113 which is like wait_for_termination, but allows keyboard
5116 * callproc.c (Fcall_process): Add (:file "file") as an option for
5118 (Fcall_process_region): Ditto.
5120 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5122 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5123 rather than `XVECTOR (FOO)->size'.
5125 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5126 inttypes.h, as a gnulib replacement is used if it not available in
5129 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5131 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5132 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5133 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5135 * coding.c (coding_alloc_by_realloc): Error out if destination
5136 will grow beyond MOST_POSITIVE_FIXNUM.
5137 (decode_coding_emacs_mule): Abort if there isn't enough place in
5138 charbuf for the composition carryover bytes. Reserve an extra
5139 space for up to 2 characters produced in a loop.
5140 (decode_coding_iso_2022): Abort if there isn't enough place in
5141 charbuf for the composition carryover bytes.
5143 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5145 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5146 aborting when %lld or %lll format is passed.
5147 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5148 %llo or %llx format is passed. (Bug#8545)
5150 * window.c (window_scroll_line_based): Use a marker instead of
5151 simple variables to record original value of point. (Bug#7952)
5153 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5154 produced by %s or %c overflows available buffer space. (Bug#8545)
5156 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5158 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5159 (SIZE_MAX): Move defn after all includes, as they might #define it.
5161 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5163 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5165 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5167 * keyboard.c (Qdelayed_warnings_hook): Define.
5168 (command_loop_1): Run `delayed-warnings-hook'
5169 if Vdelayed_warnings_list is non-nil.
5170 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5171 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5173 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5175 * doprnt.c (doprnt): Don't return value smaller than the buffer
5176 size if the message was truncated. (Bug#8545).
5178 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5180 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5181 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5183 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5185 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5187 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5189 * makefile.w32-in: Update dependencies.
5191 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5193 Improve `doprnt' and its usage. (Bug#8545)
5194 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5195 `format_end'. Remove support for %l as a conversion specifier.
5196 Don't use xrealloc. Improve diagnostics when the %l size modifier
5197 is used. Update the commentary.
5199 * eval.c (verror): Simplify calculation of size_t.
5201 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5204 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5206 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5209 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5211 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5212 This makes this file independent of the recent pseudovector change.
5214 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5216 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5218 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5219 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5220 Remove unused local.
5221 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5223 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5224 GCC 4.6.0 optimizes based on type-based alias analysis.
5225 For example, if b is of type struct buffer * and v of type struct
5226 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5227 != &v->size, and therefore "v->size = 1; b->size = 2; return
5228 v->size;" must therefore return 1. This assumption is incorrect
5229 for Emacs, since it type-puns struct Lisp_Vector * with many other
5230 types. To fix this problem, this patch adds a new type struct
5231 vectorlike_header that documents the constraints on layout of vectors
5232 and pseudovectors, and helps optimizing compilers not get fooled
5233 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5234 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5235 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5237 (XSETPVECTYPE): Rewrite in terms of new macro.
5238 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5239 This is a bit clearer, and further avoids the possibility of
5240 undesirable aliasing.
5241 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5242 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5243 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5244 since Lisp_Subr is a special case (no "next" field).
5245 (ASIZE): Now uses header.size rather than size.
5246 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5247 to avoid the hassle of writing XVECTOR (foo)->header.size.
5248 (struct vectorlike_header): New type.
5249 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5250 object, to help avoid aliasing.
5251 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5252 (SUBRP): Likewise, since Lisp_Subr is a special case.
5253 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5254 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5255 (struct Lisp_Hash_Table): Combine first two members into a single
5256 struct vectorlike_header member. All uses of "size" and "next" members
5257 changed to be "header.size" and "header.next".
5258 * buffer.h (struct buffer): Likewise.
5259 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5260 * frame.h (struct frame): Likewise.
5261 * process.h (struct Lisp_Process): Likewise.
5262 * termhooks.h (struct terminal): Likewise.
5263 * window.c (struct save_window_data, struct saved_window): Likewise.
5264 * window.h (struct window): Likewise.
5265 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5266 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5267 * buffer.c (init_buffer_once): Likewise.
5268 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5270 * process.c (Fformat_network_address): Use local var for size,
5273 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5275 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5276 * data.c (atof): Remove decl; no longer used or needed.
5277 (digit_to_number): Move to lread.c.
5278 (Fstring_to_number): Use new string_to_number function, to be
5279 consistent with how the Lisp reader treats infinities and NaNs.
5280 Do not assume that floating-point numbers represent EMACS_INT
5281 without losing information; this is not true on most 64-bit hosts.
5282 Avoid double-rounding errors, by insisting on integers when
5283 parsing non-base-10 numbers, as the documentation specifies.
5284 * lisp.h (string_to_number): New decl, replacing ...
5285 (isfloat_string): Remove.
5286 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5287 (read1): Do not accept +. and -. as integers; this
5288 appears to have been a coding error. Similarly, do not accept
5289 strings like +-1e0 as floating point numbers. Do not report
5290 overflow for integer overflows unless the base is not 10 which
5291 means we have no simple and reliable way to continue.
5292 Break out the floating-point parsing into a new
5293 function string_to_number, so that Fstring_to_number parses
5294 floating point numbers consistently with the Lisp reader.
5295 (digit_to_number): Move here from data.c. Make it static inline.
5296 (E_CHAR, EXP_INT): Remove, replacing with ...
5297 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5298 (string_to_number): New function, replacing isfloat_string.
5299 This function checks for valid syntax and produces the resulting
5300 Lisp float number too. Rework it so that string-to-number
5301 no longer mishandles examples like "1.0e+". Use strtoumax,
5302 so that overflow for non-base-10 numbers is reported only when
5303 there's no portable and simple way to convert to floating point.
5305 * textprop.c (set_text_properties_1): Rewrite for clarity,
5306 and to avoid GCC warning about integer overflow.
5308 * intervals.h (struct interval): Use EMACS_INT for members
5309 where EMACS_UINT might cause problems. See
5310 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5311 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5312 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5314 (offset_intervals): Tell GCC not to worry about length overflow
5315 when negating a negative length.
5317 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5318 (overrun_check_free): Likewise.
5320 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5321 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5324 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5325 (gnutls_make_error): Rename local to avoid shadowing.
5326 (gnutls_emacs_global_deinit): ifdef out; not used.
5327 (Fgnutls_boot): Use const for pointer to readonly storage.
5328 Comment out unused local. Fix pointer signedness problems.
5330 * lread.c (openp): Don't stuff size_t into an 'int'.
5331 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5332 about possible signed overflow.
5334 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5335 (GDK_KEY_g): Don't define if already defined.
5336 (xg_prepare_tooltip): Avoid pointer signedness problem.
5337 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5339 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5340 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5342 * xfns.c (Fx_window_property): Simplify a bit,
5343 to make a bit faster and to avoid GCC 4.6.0 warning.
5344 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5346 * fns.c (internal_equal): Don't assume size_t fits in int.
5348 * alloc.c (compact_small_strings): Tighten assertion a little.
5350 Replace pEd with more-general pI, and fix some printf arg casts.
5351 * lisp.h (pI): New macro, generalizing old pEd macro to other
5352 conversion specifiers. For example, use "...%"pI"d..." rather
5353 than "...%"pEd"...".
5354 (pEd): Remove. All uses replaced with similar uses of pI.
5355 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5356 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5357 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5358 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5359 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5360 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5361 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5363 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5364 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5365 * print.c (safe_debug_print, print_object): Likewise.
5366 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5368 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5369 avoiding the 0 flag, which is not portable.
5370 * process.c (Fmake_network_process): Use pI to avoid cast.
5371 * region-cache.c (pp_cache): Likewise.
5372 * xdisp.c (decode_mode_spec): Likewise.
5373 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5374 behavior on 64-bit hosts with printf arg.
5375 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5376 (x_stop_queuing_selection_requests): Likewise.
5377 (x_get_window_property): Don't truncate byte count to an 'int'
5380 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5381 here, since it parses constructs like leading '-' and spaces,
5382 which are not wanted; and it overflows with large numbers.
5383 Instead, simply match F[0-9]+, which is what is wanted anyway.
5385 * alloc.c: Remove unportable assumptions about struct layout.
5386 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5387 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5388 (allocate_vectorlike, make_pure_vector): Use the new macros,
5389 plus offsetof, to remove unportable assumptions about struct layout.
5390 These assumptions hold on all porting targets that I know of, but
5391 they are not guaranteed, they're easy to remove, and removing them
5392 makes further changes easier.
5394 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5395 This doesn't fix a bug but makes the code clearer.
5396 (string_overrun_cookie): Now const. Use initializers that
5397 don't formally overflow signed char, to avoid warnings.
5398 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5399 can cause Emacs to crash when string overrun checking is enabled.
5400 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5401 multiple of sizeof (EMACS_INT); it need not be, if
5402 alignof(EMACS_INT) < sizeof (EMACS_INT).
5403 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5405 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5407 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5409 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5411 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5412 supposed to be handshaking. (Bug#8556)
5413 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5415 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5417 * lisp.h (Qdebug): List symbol.
5418 * eval.c (Qdebug): Restore global linkage.
5419 * keyboard.c (debug-on-event): New variable.
5420 (handle_user_signal): Break into debugger when debug-on-event
5421 matches the current signal symbol.
5423 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5425 * alloc.c (check_sblock, check_string_bytes)
5426 (check_string_free_list): Convert to standard C.
5428 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5430 * w32.c (emacs_gnutls_push): Fix typo.
5432 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5434 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5435 "cast to pointer from integer of different size".
5437 Improve doprnt and its use in verror. (Bug#8545)
5438 * doprnt.c (doprnt): Document the set of format control sequences
5439 supported by the function. Use SAFE_ALLOCA instead of always
5442 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5443 is one byte too soon. Don't use xrealloc; instead xfree and
5446 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5448 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5451 * gnutls.c: Renamed global_initialized to
5452 gnutls_global_initialized. Added internals for the
5453 :verify-hostname-error, :verify-error, and :verify-flags
5454 parameters of `gnutls-boot' and documented those parameters in the
5455 docstring. Start callback support.
5456 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5457 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5458 on error. Return error code.
5459 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5460 (emacs_gnutls_read): Likewise.
5461 (Fgnutls_boot): Return handshake error code.
5462 (emacs_gnutls_handle_error): New function.
5463 (wsaerror_to_errno): Likewise.
5465 * w32.h (emacs_gnutls_pull): Add prototype.
5466 (emacs_gnutls_push): Likewise.
5468 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5469 (emacs_gnutls_push): Likewise.
5471 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5473 * process.c (wait_reading_process_output): Check if GnuTLS
5474 buffered some data internally if no FDs are set for TLS
5477 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5478 (LIBS): Link to USER_LIBS.
5479 ($(BLD)/gnutls.$(0)): New target.
5481 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5483 * xdisp.c (handle_single_display_spec): Rename the
5484 display_replaced_before_p argument into display_replaced_p, to
5485 make it consistent with the commentary. Fix typos in the
5488 * textprop.c (syms_of_textprop): Remove dead code.
5489 (copy_text_properties): Delete obsolete commentary about an
5490 interface that was deleted long ago. Fix typos in the description
5493 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5494 to changes in oldXMenu/XMenu.h from 2011-04-16.
5495 <menu_help_message, prev_menu_help_message>: Constify.
5496 (IT_menu_make_room): menu->help_text is now `const char **';
5499 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5500 to changes in oldXMenu/XMenu.h from 2011-04-16.
5501 (struct XMenu): Declare `help_text' `const char **'.
5503 * xfaces.c <Qunspecified>: Make extern again.
5505 * syntax.c: Include sys/types.h before including regex.h, as
5508 * doc.c (get_doc_string): Improve the format passed to `error'.
5510 * doprnt.c (doprnt): Improve commentary.
5512 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5514 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5517 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5518 changes in globals.h immediately force recompilation.
5519 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5520 $(CURDIR)/s/ms-w32.h.
5521 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5523 * character.c (Fchar_direction): Function deleted.
5524 (syms_of_character): Don't defsubr it.
5525 <char-direction-table>: Deleted.
5527 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5529 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5530 * doprnt.c: Include limits.h.
5531 (SIZE_MAX): New macro.
5532 (doprnt): Return a size_t value. 2nd arg is now size_t.
5533 Many local variables are now size_t instead of int or unsigned.
5534 Improve overflow protection. Support `l' modifier for integer
5535 conversions. Support %l conversion. Don't assume an EMACS_INT
5536 argument for integer conversions and for %c.
5538 * lisp.h (doprnt): Restore prototype.
5540 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5543 * Makefile.in (base_obj): Add back doprnt.o.
5545 * deps.mk (doprnt.o): Add back prerequisites.
5546 (callint.o): Depend on character.h.
5548 * eval.c (internal_lisp_condition_case): Include the handler
5549 representation in the error message.
5550 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5551 when breaking from the loop.
5553 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5555 * callint.c (Fcall_interactively): When displaying error message
5556 about invalid control letter, pass the character's codepoint, not
5557 a pointer to its multibyte form. Improve display of the character
5558 in octal and display also its hex code.
5560 * character.c (char_string): Use %x to display the (unsigned)
5561 codepoint of an invalid character, to avoid displaying a bogus
5564 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5565 `error', not SYMBOL_NAME itself.
5567 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5568 character arguments to `error'.
5570 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5571 to `error' in error message about FINAL_CHAR argument. Make sure
5572 FINAL_CHAR is a character, and use %c when it is passed as
5573 argument to `error'.
5575 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5577 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5579 * w32.c: Include <time.h>.
5580 (sys_localtime): New function.
5582 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5584 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5586 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5588 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5590 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5593 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5595 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5596 gl_state.e_property when gl_state.object is Qt.
5598 * insdel.c (make_gap_larger): Remove limitation of buffer size
5601 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5603 * xdisp.c (lookup_glyphless_char_display)
5604 (produce_glyphless_glyph): Handle cons cell entry in
5605 glyphless-char-display.
5606 (Vglyphless_char_display): Document it.
5608 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5609 glyphless-char-display.
5611 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5613 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5615 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5617 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5618 definition for no-X builds.
5620 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5622 Static checks with GCC 4.6.0 and non-default toolkits.
5624 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5626 * process.c (keyboard_bit_set): Define only if SIGIO.
5627 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5628 (send_process): Repair possible setjmp clobbering.
5630 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5632 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5634 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5636 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5637 Define only if needed.
5639 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5640 by pacifying GCC about it. Maybe it's time to retire it?
5641 * xfaces.c (USG, __TIMEVAL__): Likewise.
5643 * dispextern.h (struct redisplay_interface): Rename param
5645 * termhooks.h (struct terminal): Likewise.
5646 * xterm.c (xembed_send_message): Likewise.
5648 * insdel.c (make_gap_smaller): Define only if
5649 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5651 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5654 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5655 so that we aren't warned about unused symbols.
5657 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5659 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5661 * xfns.c (x_real_positions): Mark locals as initialized.
5663 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5665 * xterm.c: Fix problems found by static analysis with other toolkits.
5666 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5667 (x_dispatch_event): Declare static if USE_GTK, and
5668 define if USE_GTK || USE_X_TOOLKIT.
5669 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5670 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5671 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5672 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5674 * xmenu.c (menu_help_callback): Pointer type fixes.
5675 Use const pointers when pointing at readonly data. Avoid pointer
5677 (FALSE): Remove unused macro.
5678 (update_frame_menubar): Remove unused decl.
5680 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5682 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5683 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5684 (single_menu_item): Rename local to avoid shadowing.
5686 * keyboard.c (make_lispy_event): Remove unused local var.
5688 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5689 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5691 * bitmaps: Change bitmaps from unsigned char back to the X11
5692 compatible char. Avoid the old compiler warnings about
5693 out-of-range initializers by using, for example, '\xab' rather
5696 * xgselect.c (xgselect_initialize): Check vs interface
5697 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5699 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5701 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5702 to read-only memory.
5704 * fns.c (vector): Remove; this old hack is no longer needed.
5706 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5708 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5710 * xrdb.c (x_load_resources): Omit unused local.
5712 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5713 (x_window): Rename locals to avoid shadowing.
5714 (USG): Use the kludged USG macro, to pacify gcc.
5716 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5717 (x_term_init): Remove local to avoid shadowing.
5719 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5721 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5722 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5724 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5726 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5728 Fix regex.c, syntax.c and friends for buffers > 2GB.
5729 * syntax.h (struct gl_state_s): Declare character position members
5732 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5734 * textprop.c (verify_interval_modification, interval_of):
5735 Declare arguments EMACS_INT.
5737 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5740 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5742 * indent.c (Fvertical_motion): Local variable it_start is now
5745 * regex.c (re_match, re_match_2, re_match_2_internal)
5746 (bcmp_translate, regcomp, regexec, print_double_string)
5747 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5748 (re_compile_pattern, re_exec): Declare arguments and local
5749 variables `size_t' and `ssize_t' and return values `regoff_t', as
5751 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5752 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5753 <compile_stack_type>: `size' and `avail' are now `size_t'.
5755 * regex.h <regoff_t>: Use ssize_t, not int.
5756 (re_search, re_search_2, re_match, re_match_2): Arguments that
5757 specify buffer/string position and length are now ssize_t and
5758 size_t. Return type is regoff_t.
5760 2011-04-16 Ben Key <bkey76@gmail.com>
5762 * nsfont.m: Fixed bugs in ns_get_family and
5763 ns_descriptor_to_entity that were caused by using free to
5764 deallocate memory blocks that were allocated by xmalloc (via
5765 xstrdup). This caused Emacs to crash when compiled with
5766 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5767 --enable-checking=xmallocoverrun). xfree is now used to
5768 deallocate these memory blocks.
5770 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5772 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5774 emacs_write: Accept and return EMACS_INT for sizes.
5775 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5777 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5778 Accept and return EMACS_INT.
5779 (emacs_gnutls_write): Return the number of bytes written on
5781 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5782 (emacs_read, emacs_write): Remove check for negative size, as the
5783 Emacs source code has been audited now.
5784 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5785 (emacs_read, emacs_write): Use it.
5786 * process.c (send_process): Adjust to the new signatures of
5787 emacs_write and emacs_gnutls_write. Do not attempt to store
5788 a byte offset into an 'int'; it might overflow.
5789 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5791 * sound.c: Don't assume sizes fit in 'int'.
5792 (struct sound_device.period_size, alsa_period_size):
5793 Return EMACS_INT, not int.
5794 (struct sound_device.write, vox_write, alsa_write):
5795 Accept EMACS_INT, not int.
5796 (wav_play, au_play): Use EMACS_INT to store sizes and to
5797 record read return values.
5799 2011-04-15 Ben Key <bkey76@gmail.com>
5801 * keyboard.c (Qundefined): Don't declare static since it is used
5803 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5804 static since they are used in nsfont.m.
5806 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5808 * process.c (Qprocessp): Don't declare static.
5809 * lisp.h (Qprocessp): Declare again.
5811 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5813 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5815 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5817 Improve C-level modularity by making more things 'static'.
5819 Don't publish debugger-only interfaces to other modules.
5820 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5821 (verify_bytepos, count_markers): Move decls to the only modules
5823 * region-cache.h (pp_cache): Likewise.
5824 * window.h (check_all_windows): Likewise.
5825 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5827 * sysdep.c (croak): Now static, if
5828 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5829 * syssignal.h (croak): Declare only if not static.
5831 * alloc.c (refill_memory_reserve): Now static if
5832 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5833 * lisp.h (refill_memory_reserve): Declare only if not static.
5835 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5836 Define only if USE_LUCID.
5838 * xrdb.c (x_customization_string, x_rm_string): Now static.
5840 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5841 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5843 * xdisp.c (draw_row_with_mouse_face): Now static.
5844 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5846 * window.h (check_all_windows): Mark externally visible.
5848 * window.c (window_deletion_count): Now static.
5850 * undo.c: Make symbols static if they're not exported.
5851 (last_undo_buffer, last_boundary_position, pending_boundary):
5854 * textprop.c (interval_insert_behind_hooks): Now static.
5855 (interval_insert_in_front_hooks): Likewise.
5857 * term.c: Make symbols static if they're not exported.
5858 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5859 (max_frame_lines, tty_set_terminal_modes):
5860 (tty_reset_terminal_modes, tty_turn_off_highlight):
5861 (get_tty_terminal): Now static.
5862 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5863 * termhooks.h (term_mouse_moveto): Do not declare if
5865 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5866 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5868 * sysdep.c: Make symbols static if they're not exported.
5869 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5871 (sigprocmask_set, full_mask): Remove; unused.
5872 (wait_debugging): Mark as visible.
5873 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5874 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5876 * syntax.c (syntax_temp): Define only if !__GNUC__.
5878 * sound.c (current_sound_device, current_sound): Now static.
5880 * search.c (searchbufs, searchbuf_head): Now static.
5882 * scroll.c (scroll_cost): Remove; unused.
5883 * dispextern.h (scroll_cost): Remove decl.
5885 * region-cache.h (pp_cache): Mark as externally visible.
5887 * process.c: Make symbols static if they're not exported.
5888 (process_tick, update_tick, create_process, chan_process):
5889 (Vprocess_alist, proc_buffered_char, datagram_access):
5890 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5891 (deactivate_process): Mark defn as static, as well as decl.
5892 * lisp.h (create_process): Remove decl.
5893 * process.h (chan_process, Vprocess_alist): Remove decls.
5895 * print.c: Make symbols static if they're not exported.
5896 (print_depth, new_backquote_output, being_printed, print_buffer):
5897 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5898 (print_interval, print_number_index, initial_stderr_stream):
5900 * lisp.h (Fprinc): Remove decl.
5901 (debug_output_compilation_hack): Mark as externally visible.
5903 * sysdep.c (croak): Move decl from here to syssignal.h.
5904 * syssignal.h (croak): Put it here, so the API can be checked when
5905 'croak' is called from dissociate_if_controlling_tty.
5907 * minibuf.c: Make symbols static if they're not exported.
5908 (minibuf_save_list, choose_minibuf_frame): Now static.
5909 * lisp.h (choose_minibuf_frame): Remove decl.
5911 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5913 * lread.c: Make symbols static if they're not exported.
5914 (read_objects, initial_obarray, oblookup_last_bucket_number):
5916 (make_symbol): Remove; unused.
5917 * lisp.h (initial_obarray, make_symbol): Remove decls.
5919 * keyboard.c: Make symbols static if they're not exported.
5920 (single_kboard, recent_keys_index, total_keys, recent_keys):
5921 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5922 (this_single_command_key_start, echoing, last_auto_save):
5923 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5924 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5925 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5926 (Vlispy_mouse_stem, double_click_count):
5928 (force_auto_save_soon): Define only if SIGDANGER.
5929 (ignore_mouse_drag_p): Now static if
5930 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5931 (print_help): Remove; unused.
5932 (stop_character, last_timer_event): Mark as externally visible.
5933 * keyboard.h (ignore_mouse_drag_p): Declare only if
5934 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5935 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5936 * lisp.h (echoing): Remove decl.
5937 (force_auto_save_soon): Declare only if SIGDANGER.
5938 * xdisp.c (redisplay_window): Simplify code, to make it more
5939 obvious that ignore_mouse_drag_p is not accessed if !defined
5940 USE_GTK && !defined HAVE_NS.
5942 * intervals.c: Make symbols static if they're not exported.
5943 (merge_properties_sticky, merge_interval_right, delete_interval):
5945 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5947 * insdel.c: Make symbols static if they're not exported.
5948 However, leave prepare_to_modify_buffer alone. It's never
5949 called from outside this function, but that appears to be a bug.
5950 (combine_after_change_list, combine_after_change_buffer):
5951 (adjust_after_replace, signal_before_change): Now static.
5952 (adjust_after_replace_noundo): Remove; unused.
5953 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5954 (signal_before_change): Remove decls.
5956 * indent.c (val_compute_motion, val_vmotion): Now static.
5958 * image.c: Make symbols static if they're not exported.
5959 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5961 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5962 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5964 * fringe.c (standard_bitmaps): Now static.
5965 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5967 * frame.c: Make symbols static if they're not exported.
5968 (x_report_frame_params, make_terminal_frame): Now static.
5969 (get_frame_param): Now static, unless HAVE_NS.
5970 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5971 (x_get_resource_string): Remove; not used.
5972 * frame.h (make_terminal_frame, x_report_frame_params):
5973 (x_get_resource_string); Remove decls.
5974 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5975 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5977 * font.c, fontset.c: Make symbols static if they're not exported.
5978 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5979 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5980 * font.c (font_close_object): Now static.
5981 * font.h (font_close_object): Remove.
5982 * fontset.c (FONTSET_OBJLIST): Remove.
5983 (free_realized_fontset) #if-0 the body, which does nothing.
5984 (face_suitable_for_char_p): #if-0, as it's never called.
5985 * fontset.h (face_suitable_for_char_p): Remove decl.
5986 * xfaces.c (face_at_string_position):
5987 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5988 since 0 is always ASCII.
5990 * fns.c (weak_hash_tables): Now static.
5992 * fileio.c: Make symbols static if they're not exported.
5993 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5994 (Vwrite_region_annotation_buffers): Now static.
5996 * eval.c: Make symbols static if they're not exported.
5997 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5998 * lisp.h (backtrace_list): Remove decl.
6000 * emacs.c: Make symbols static if they're not exported.
6001 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6002 (fatal_error_code, fatal_error_signal_hook, standard_args):
6004 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6005 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6006 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6007 * lisp.h (fatal_error_signal_hook): Remove decl.
6008 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6010 * editfns.c: Move a (normally-unused) function to its only use.
6011 * editfns.c, lisp.h (get_operating_system_release): Remove.
6012 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6013 worth the hassle of breaking this out.
6015 * xterm.c: Make symbols static if they're not exported.
6016 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6017 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6018 (x_destroy_window, x_delete_display):
6020 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6021 (x_mouse_leave): Remove; unused.
6022 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6023 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6024 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6026 (x_mouse_leave): Declare only if WINDOWSNT.
6027 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6028 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6031 * ftxfont.c: Make symbols static if they're not exported.
6032 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6034 * font.h (ftxfont_driver): Likewise.
6036 * xfns.c: Make symbols static if they're not exported.
6037 (x_last_font_name, x_display_info_for_name):
6038 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6039 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6040 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6041 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6042 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6043 (last_show_tip_args): Now static.
6044 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6045 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6046 (x_screen_planes): Remove; unused.
6047 * dispextern.h (x_screen_planes): Remove decl.
6049 * dispnew.c: Make symbols static if they're not exported.
6050 * dispextern.h (redraw_garbaged_frames, scrolling):
6051 (increment_row_positions): Remove.
6052 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6053 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6055 (redraw_garbaged_frames): Remove; unused.
6057 * xfaces.c: Make symbols static if they're not exported.
6058 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6060 * xterm.h (defined_color): Remove decls.
6061 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6062 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6063 (menu_face_changed_default, defined_color, free_realized_face):
6064 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6065 (ascii_face_of_lisp_face): Remove; unused.
6067 * xdisp.c: Make symbols static if they're not exported.
6068 * dispextern.h (scratch_glyph_row, window_box_edges):
6069 (glyph_to_pixel_coords, set_cursor_from_row):
6070 (get_next_display_element, set_iterator_to_next):
6071 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6072 (show_mouse_face): Remove decls
6073 * frame.h (message_buf_print): Likewise.
6074 * lisp.h (pop_message, set_message, check_point_in_composition):
6076 * xterm.h (set_vertical_scroll_bar): Likewise.
6077 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6078 (message_buf_print, scratch_glyph_row, displayed_buffer):
6079 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6080 (get_next_display_element, show_mouse_face, window_box_edges):
6081 (frame_to_window_pixel_xy, check_point_in_composition):
6082 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6083 (glyph_to_pixel_coords): Remove; unused.
6085 * dired.c (file_name_completion): Now static.
6087 * dbusbind.c (xd_in_read_queued_messages): Now static.
6089 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6090 * data.c (circular_list_error): Remove.
6092 * commands.h (last_point_position, last_point_position_buffer):
6093 (last_point_position_window): Remove decls.
6094 * keyboard.c: Make these variables static.
6096 * coding.h (coding, code_convert_region, encode_coding_gap):
6098 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6099 (iso_code_class, detect_coding, code_convert_region): Now static.
6100 (encode_coding_gap): Remove; unused.
6102 * chartab.c (chartab_chars, chartab_bits): Now static.
6104 * charset.h (charset_iso_8859_1): Remove decl.
6105 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6108 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6109 * ccl.c (Vccl_program_table): Now static.
6110 (check_ccl_update): Remove; unused.
6112 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6113 * category.h: ... from here.
6114 * category.c (check_category_table, set_category_set): Now static.
6116 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6117 * lisp.h: Remove these decls.
6119 * buffer.c (buffer_count): Remove unused var.
6121 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6122 so that it's not optimized away.
6123 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6124 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6125 exported only to the debugger.
6127 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6128 * atimer.h (run_all_atimers): Remove; not exported.
6130 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6131 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6132 was inaccessible from Lisp.
6133 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6134 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6136 alloc.c: Import and export fewer symbols, and remove unused items.
6137 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6139 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6140 it's not optimized away by whole-program optimization.
6141 (message_enable_multibyte, free_misc): Remove.
6142 (catchlist, handlerlist, mark_backtrace):
6143 Declare only if BYTE_MARK_STACK.
6144 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6145 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6146 (message_enable_multibyte): Remove decl.
6147 (free_misc, interval_free_list, float_block, float_block_index):
6148 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6149 (cons_free_list, last_marked_index):
6151 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6152 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6153 (mark_backtrace): Define only if BYTE_MARK_STACK.
6154 * xdisp.c (message_enable_multibyte): Now static.
6156 Declare Lisp_Object Q* variables to be 'static' if not exported.
6157 This makes it easier for human readers (and static analyzers)
6158 to see whether these variables are used from other modules.
6159 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6160 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6161 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6162 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6163 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6164 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6165 * xmenu.c, xselect.c:
6166 Declare Q* vars static if they are not used in other modules.
6167 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6168 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6169 Remove decls of unexported vars.
6170 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6172 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6174 Make Emacs functions such as Fatom 'static' by default.
6175 This makes it easier for human readers (and static analyzers)
6176 to see whether these functions can be called from other modules.
6177 DEFUN now defines a static function. To make the function external
6178 so that it can be used in other C modules, use the new macro DEFUE.
6179 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6180 (Finit_image_library):
6181 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6182 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6183 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6184 Remove decls, since these functions are now static.
6185 (Funintern, Fget_internal_run_time): New decls, since these functions
6186 were already external.
6188 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6189 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6190 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6191 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6192 * keyboard.c, keymap.c, lread.c:
6193 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6194 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6195 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6196 Mark functions with DEFUE instead of DEFUN,
6197 if they are used in other modules.
6198 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6199 decls for now-static functions.
6200 * buffer.h (Fdelete_overlay): Remove decl.
6201 * callproc.c (Fgetenv_internal): Mark as internal.
6202 * composite.c (Fremove_list_of_text_properties): Remove decl.
6203 (Fcomposition_get_gstring): New forward static decl.
6204 * composite.h (Fcomposite_get_gstring): Remove decl.
6205 * dired.c (Ffile_attributes): New forward static decl.
6206 * doc.c (Fdocumntation_property): New forward static decl.
6207 * eval.c (Ffetch_bytecode): New forward static decl.
6208 (Funintern): Remove extern decl; now in .h file where it belongs.
6209 * fileio.c (Fmake_symbolic_link): New forward static decl.
6210 * image.c (Finit_image_library): New forward static decl.
6211 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6212 * intervals.h (Fprevious_property_change):
6213 (Fremove_list_of_text_properties): Remove decls.
6214 * keyboard.c (Fthis_command_keys): Remove decl.
6215 (Fcommand_execute): New forward static decl.
6216 * keymap.c (Flookup_key): New forward static decl.
6217 (Fcopy_keymap): Now static.
6218 * keymap.h (Flookup_key): Remove decl.
6219 * process.c (Fget_process): New forward static decl.
6220 (Fprocess_datagram_address): Mark as internal.
6221 * syntax.c (Fsyntax_table_p): New forward static decl.
6222 (skip_chars): Remove duplicate decl.
6223 * textprop.c (Fprevious_property_change): New forward static decl.
6224 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6226 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6227 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6229 * editfns.c (Fformat): Remove unreachable code.
6231 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6233 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6236 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6238 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6239 when at ZV. (Bug#8487)
6241 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6243 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6245 * keyboard.c (parse_tool_bar_item): Likewise.
6246 * sound.c (sound_cleanup, alsa_close): Likewise.
6247 * termcap.c (tgetent): Likewise.
6248 * xfns.c (x_default_font_parameter): Likewise.
6249 * xsettings.c (read_and_apply_settings): Likewise.
6251 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6252 (overrun_check_free): Protoize.
6254 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6256 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6257 since callers should never pass a negative size.
6258 Change the signature to match that of plain 'read' and 'write'; see
6259 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6260 * lisp.h: Update prototypes of emacs_write and emacs_read.
6262 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6264 * xdisp.c (redisplay_window): Don't try to determine the character
6265 position of the scroll margin if the window start point w->startp
6266 is outside the buffer's accessible region. (Bug#8468)
6268 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6270 Fix write-region and its subroutines for buffers > 2GB.
6271 * fileio.c (a_write, e_write): Modify declaration of arguments and
6272 local variables to support buffers larger than 2GB.
6273 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6275 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6276 argument, local variables, and return value.
6278 * lisp.h: Update prototypes of emacs_write and emacs_read.
6280 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6282 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6284 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6286 Fix more problems found by GCC 4.6.0's static checks.
6288 * xdisp.c (vmessage): Use a better test for character truncation.
6290 * charset.c (load_charset_map): <, not <=, for optimization,
6291 and to avoid potential problems with integer overflow.
6292 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6293 * casetab.c (set_identity, shuffle): Likewise.
6294 * editfns.c (Fformat): Likewise.
6295 * syntax.c (skip_chars): Likewise.
6297 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6298 This also lets GCC 4.6.0 generate slightly better loop code.
6300 * callint.c (Fcall_interactively): <, not <=, for optimization.
6301 (Fcall_interactively): Count the number of arguments produced,
6302 not the number of arguments given. This is simpler and lets GCC
6303 4.6.0 generate slightly better code.
6305 * ftfont.c: Distingish more carefully between FcChar8 and char.
6306 The previous code passed unsigned char * to a functions like
6307 strlen and xstrcasecmp that expect char *, which does not
6308 conform to the C standard.
6309 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6310 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6311 char * when the C standard requires it.
6313 * keyboard.c (read_char): Remove unused var.
6315 * eval.c: Port to Windows vsnprintf (Bug#8435).
6317 (SIZE_MAX): Define if the headers do not.
6318 (verror): Do not give up if vsnprintf returns a negative count.
6319 Instead, grow the buffer. This ports to Windows vsnprintf, which
6320 does not conform to C99. Problem reported by Eli Zaretskii.
6321 Also, simplify the allocation scheme, by avoiding the need for
6322 calling realloc, and removing the ALLOCATED variable.
6324 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6326 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6327 But keep the doprint source code for now, as we might revamp it
6328 and use it again (Bug#8435).
6329 * lisp.h (doprnt): Remove.
6330 * Makefile.in (base_obj): Remove doprnt.o.
6331 * deps.mk (doprnt.o): Remove.
6333 error: Print 32- and 64-bit integers portably (Bug#8435).
6334 Without this change, on typical 64-bit hosts error ("...%d...", N)
6335 was used to print both 32- and 64-bit integers N, which relied on
6337 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6339 * lisp.h (error, verror): Mark as printf-like functions.
6340 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6341 Report overflow in size calculations when allocating printf buffer.
6342 Do not truncate output string at its first null byte.
6343 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6344 Truncate the output at a character boundary, since vsnprintf does not
6346 * charset.c (check_iso_charset_parameter): Convert internal
6347 character to string before calling 'error', since %c now has the
6349 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6350 overflow when computing char to be passed to 'error'. Do not
6351 pass Lisp_Object to 'error'; pass the integer instead.
6352 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6353 formatted with plain %d.
6355 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6357 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6359 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6361 * xterm.c (x_catch_errors): Remove duplicate declaration.
6363 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6365 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6367 2011-04-10 Jim Meyering <meyering@redhat.com>
6369 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6370 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6371 return ssize_t not "int", and use size_t as the buffer length.
6372 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6373 * gnutls.h: Update declarations.
6374 * process.c (read_process_output): Use ssize_t, to match.
6375 (send_process): Likewise.
6377 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6379 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6381 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6383 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6384 Use unsigned char, to match FcChar8 type definition.
6386 * xterm.c (handle_one_xevent):
6387 * xmenu.c (create_and_show_popup_menu):
6388 * xselect.c (x_decline_selection_request)
6389 (x_reply_selection_request): Avoid type-punned deref of X events.
6391 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6393 Fix some uses of `int' instead of EMACS_INT.
6394 * search.c (string_match_1, fast_string_match)
6395 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6396 (scan_buffer, find_next_newline_no_quit)
6397 (find_before_next_newline, search_command, Freplace_match)
6398 (Fmatch_data): Make some `int' variables be EMACS_INT.
6400 * xdisp.c (display_count_lines): 3rd argument and return value now
6401 EMACS_INT. All callers changed.
6402 (pint2hrstr): Last argument is now EMACS_INT.
6404 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6405 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6406 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6407 (decode_coding_utf_16, decode_coding_emacs_mule)
6408 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6409 (decode_coding_ccl, decode_coding_charset)
6410 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6411 (decode_coding_iso_2022, decode_coding_emacs_mule)
6412 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6413 <char_offset, last_offset>: Declare EMACS_INT.
6414 (encode_coding_utf_8, encode_coding_utf_16)
6415 (encode_coding_emacs_mule, encode_invocation_designation)
6416 (encode_designation_at_bol, encode_coding_iso_2022)
6417 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6418 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6420 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6421 (encode_invocation_designation): Last argument P_NCHARS is now
6423 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6424 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6426 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6429 * ccl.c (Fccl_execute_on_string): Declare some variables
6432 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6434 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6436 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6438 * process.c (Fformat_network_address): Doc fix.
6440 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6442 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6444 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6446 * keyboard.c (read_char): Call Lisp function help-form-show,
6447 instead of using internal_with_output_to_temp_buffer.
6448 (Qhelp_form_show): New var.
6449 (syms_of_keyboard): Use DEFSYM macro.
6451 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6453 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6455 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6457 * process.c (Flist_processes): Remove to Lisp.
6458 (list_processes_1): Delete.
6460 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6462 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6464 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6466 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6468 Fix more problems found by GCC 4.6.0's static checks.
6470 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6472 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6474 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6476 * xdisp.c (vmessage): Mark as a printf-like function.
6478 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6480 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6482 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6483 printf-like functions.
6484 (tiff_load): Add casts to remove these marks before passing them
6485 to system-supplied API.
6487 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6489 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6490 This avoids several warnings with gcc -Wstrict-overflow.
6491 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6492 directly, rather than having caller test rule sign. This avoids
6493 some unnecessary tests.
6494 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6495 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6496 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6498 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6499 (xfont_open): Avoid unnecessary tests.
6501 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6503 * composite.h, composite.c (composition_gstring_put_cache):
6504 Use EMACS_INT, not int, for length.
6506 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6507 breaking out part of COMPOSITION_DECODE_RULE.
6508 (COMPOSITION_DECODE_RULE): Use it.
6509 * composite.c (get_composition_id): Remove unused local vars,
6510 by using the new macro.
6512 * textprop.c (set_text_properties_1): Change while to do-while,
6513 since the condition is always true at first.
6515 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6516 (interval_deletion_adjustment): Return unsigned value.
6519 * process.c (list_processes_1, create_pty, read_process_output):
6520 (exec_sentinel): Remove vars that were set but not used.
6521 (create_pty): Remove unnecessary "volatile"s.
6522 (Fnetwork_interface_info): Avoid possibility of int overflow.
6523 (read_process_output): Do adaptive read buffering even if carryover.
6524 (read_process_output): Simplify nbytes computation if buffered.
6526 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6528 * syntax.c (scan_words): Remove var that was set but not used.
6529 (update_syntax_table): Use unsigned instead of int.
6531 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6532 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6533 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6535 * print.c (print_error_message): Avoid int overflow.
6537 * font.c (font_list_entities): Redo for clarity,
6538 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6540 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6541 (font_score): Avoid potential overflow in diff calculation.
6543 * fns.c (substring_both): Remove var that is set but not used.
6544 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6546 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6548 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6549 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6550 can always succeed if overflow has undefined behavior.
6552 * search.c (boyer_moore, wordify): Remove vars set but not used.
6553 (wordify): Omit three unnecessary tests.
6555 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6556 All callers changed. This avoids the need for an unused var.
6558 * casefiddle.c (casify_region): Remove var that is set but not used.
6560 * dired.c (file_name_completion): Remove var that is set but not used.
6562 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6564 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6565 (Finsert_file_contents): Remove unnecessary code checking fd.
6567 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6568 Check for integer overflow on size calculations.
6570 * buffer.c (Fprevious_overlay_change): Remove var that is set
6573 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6574 Remove vars that are set but not used.
6575 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6576 (timer_check_2): Mark vars as initialized.
6578 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6580 * image.c (lookup_image): Remove var that is set but not used.
6581 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6583 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6584 that are set but not used.
6586 * xfns.c (make_invisible_cursor): Don't return garbage
6587 if XCreateBitmapFromData fails (Bug#8410).
6589 * xselect.c (x_get_local_selection, x_handle_property_notify):
6590 Remove vars that are set but not used.
6592 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6593 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6595 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6596 Remove var that is set but not used.
6597 (scroll_bar_windows_size): Now size_t, not int.
6598 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6601 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6602 (map_tty_color) [!defined MSDOS]: Likewise.
6604 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6606 * coding.c: Remove vars that are set but not used.
6607 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6608 All callers changed.
6609 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6610 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6611 (decode_coding_charset): Remove vars that are set but not used.
6613 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6614 that is set but not used.
6616 * print.c (print_object): Remove var that is set but not used.
6618 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6619 The gnulib version avoids calling malloc in the usual case,
6620 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6621 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6622 * filelock.c (current_lock_owner): Likewise.
6623 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6624 * sysdep.c: Include allocator.h, careadlinkat.h.
6625 (emacs_no_realloc_allocator): New static constant.
6626 (emacs_readlink): New function.
6627 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6628 ../lib/careadlinkat.h.
6630 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6632 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6633 first non-nil return value).
6635 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6637 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6638 if not defined (Bug#8403).
6640 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6642 * xdisp.c (display_count_lines): Remove parameter `start',
6643 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6644 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6645 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6646 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6647 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6648 and thereabouts. All callers changed.
6649 (get_per_char_metric): Remove parameter `f', unused since
6650 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6652 2011-04-02 Jim Meyering <meyering@redhat.com>
6654 do not dereference NULL upon failed strdup
6655 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6656 (ns_get_family): Likewise.
6658 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6660 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6662 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6664 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6667 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6669 Add lexical binding.
6671 * window.c (Ftemp_output_buffer_show): New fun.
6672 (Fsave_window_excursion):
6673 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6675 * lread.c (lisp_file_lexically_bound_p): New function.
6676 (Fload): Bind Qlexical_binding.
6677 (readevalloop): Remove `evalfun' arg.
6678 Bind Qinternal_interpreter_environment.
6679 (Feval_buffer): Bind Qlexical_binding.
6680 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6682 (syms_of_lread): Declare `lexical-binding'.
6684 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6686 * keyboard.c (eval_dyn): New fun.
6687 (menu_item_eval_property): Use it.
6689 * image.c (parse_image_spec): Use Ffunctionp.
6691 * fns.c (concat, mapcar1): Accept byte-code-functions.
6693 * eval.c (Fsetq): Handle lexical vars.
6694 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6695 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6696 (FletX, Flet): Obey lexical binding.
6697 (Fcommandp): Handle closures.
6698 (Feval): New `lexical' arg.
6699 (eval_sub): New function extracted from Feval. Use it almost
6700 everywhere where Feval was used. Look up vars in lexical env.
6702 (Ffunctionp): Move from subr.el.
6703 (Ffuncall): Handle closures.
6704 (apply_lambda): Remove `eval_flags'.
6705 (funcall_lambda): Handle closures and new byte-code-functions.
6706 (Fspecial_variable_p): New function.
6707 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6708 but without exporting it to Lisp.
6710 * doc.c (Fdocumentation, store_function_docstring):
6711 * data.c (Finteractive_form): Handle closures.
6713 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6716 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6718 (exec_byte_code): New function extracted from Fbyte_code to handle new
6719 calling convention for byte-code-functions. Add new byte-codes.
6721 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6723 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6725 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6727 * xdisp.c (redisplay_internal): Fix prototype.
6729 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6731 * xdisp.c (SCROLL_LIMIT): New macro.
6732 (try_scrolling): Use it when setting scroll_limit.
6733 Limit scrolling to 100 screen lines.
6734 (redisplay_window): Even when falling back on "recentering",
6735 position point in the window according to scroll-conservatively,
6736 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6738 (try_scrolling): When point is above the window, allow searching
6739 as far as scroll_max, or one screenful, to compute vertical
6740 distance from PT to the scroll margin position. This prevents
6741 try_scrolling from unnecessarily failing when
6742 scroll-conservatively is set to a value slightly larger than the
6743 window height. Clean up the case of PT below the margin at bottom
6744 of window: scroll_max can no longer be INT_MAX. When aggressive
6745 scrolling is in use, don't let point enter the opposite scroll
6746 margin as result of the scroll.
6747 (syms_of_xdisp) <scroll-conservatively>: Document the
6748 threshold of 100 lines for never-recentering scrolling.
6750 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6752 * dispextern.h (move_it_by_lines):
6753 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6754 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6755 (message_log_check_duplicate): Remove parameters `prev_bol' and
6756 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6757 (redisplay_internal): Remove parameter `preserve_echo_area',
6758 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6760 * indent.c (Fvertical_motion):
6761 * window.c (window_scroll_pixel_based, Frecenter):
6762 Don't pass `need_y_p' to `move_it_by_lines'.
6764 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6766 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6767 steal a few bits to be more compact.
6768 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6769 Remove unneeded casts.
6771 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6773 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6775 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6776 binding" message (bug#7967).
6778 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6780 Fix more problems found by GCC 4.6.0's static checks.
6782 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6783 Remove unused local var.
6785 * editfns.c (Fmessage_box): Remove unused local var.
6787 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6788 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6789 Omit unused local vars.
6790 * window.c (shrink_windows): Omit unused local var.
6791 * menu.c (digest_single_submenu): Omit unused local var.
6792 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6793 Omit unused local var.
6795 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6796 Don't assume string length fits in int.
6797 (keyremap_step, read_key_sequence): Use size_t for sizes.
6798 (read_key_sequence): Don't check last_real_key_start redundantly.
6800 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6801 instead of alloca (Bug#8344).
6803 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6804 (Fbacktrace_frame): Don't assume nframes fits in int.
6806 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6808 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6811 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6813 * cm.c (calccost): Turn while-do into do-while, for clarity.
6815 * keyboard.c (syms_of_keyboard): Use the same style as later
6816 in this function when indexing through an array. This also
6817 works around GCC bug 48267.
6819 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6821 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6823 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6824 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6826 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6827 This avoids undefined behavior on integer overflow, and is a bit
6828 more convenient anyway since it is compared to a size_t variable.
6830 Variadic C functions now count arguments with size_t, not int.
6831 This avoids an unnecessary limitation on 64-bit machines, which
6832 caused (substring ...) to crash on large vectors (Bug#8344).
6833 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6834 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6835 All variadic functions and their callers changed accordingly.
6836 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6837 * data.c (arith_driver, float_arith_driver): Likewise.
6838 * editfns.c (general_insert_function): Likewise.
6839 * eval.c (struct backtrace.nargs, interactive_p)
6840 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6841 (funcall_lambda, mark_backtrace): Likewise.
6842 * fns.c (concat): Likewise.
6843 * frame.c (x_set_frame_parameters): Likewise.
6844 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6845 0 if not found, not -1. All callers changed.
6847 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6848 (stack_copy_size): Now size_t, not int.
6849 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6851 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6853 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6854 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6855 All callers changed.
6857 * lisp.h (multibyte_char_to_unibyte):
6858 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6859 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6860 * character.h (CHAR_TO_BYTE8):
6861 * cmds.c (internal_self_insert):
6862 * editfns.c (general_insert_function):
6863 * keymap.c (push_key_description):
6864 * search.c (Freplace_match):
6865 * xdisp.c (message_dolog, set_message_1): All callers changed.
6867 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6869 * keyboard.c (safe_run_hook_funcall): New function.
6870 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6871 don't set the hook to nil, but remove the offending function instead.
6872 (Qcommand_hook_internal): Remove, unused.
6873 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6874 Vcommand_hook_internal.
6876 * eval.c (enum run_hooks_condition): Remove.
6877 (funcall_nil, funcall_not): New functions.
6878 (run_hook_with_args): Call each function through a `funcall' argument.
6879 Remove `cond' argument, now redundant.
6880 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6881 (Frun_hook_with_args_until_failure): Adjust accordingly.
6882 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6884 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6886 * dispextern.h (string_buffer_position): Remove declaration.
6888 * print.c (strout): Remove parameter `multibyte', unused since
6889 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6891 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6892 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6893 All callers changed.
6895 * w32.c (_wsa_errlist): Use braces for struct initializers.
6897 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6898 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6899 All callers changed.
6900 (string_buffer_position): Likewise. Also, make static (it's never
6901 used outside xdisp.c).
6902 (cursor_row_p): Remove parameter `w', unused since
6903 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6904 (decode_mode_spec): Remove parameter `precision', introduced during
6905 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6906 All callers changed.
6908 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6910 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6912 2011-03-27 Anders Lindgren <andlind@gmail.com>
6914 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6915 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6916 (ns_update_auto_hide_menu_bar): New functions.
6917 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6918 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6919 ns_constrain_all_frames.
6920 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6921 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6923 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6925 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6927 2011-03-27 Glenn Morris <rgm@gnu.org>
6929 * syssignal.h: Replace RETSIGTYPE with void.
6930 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6931 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6932 Replace SIGTYPE with void everywhere.
6933 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6934 * s/template.h (SIGTYPE): Remove commented out definition.
6936 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6938 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6939 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6941 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6943 * w32.c (read_unc_volume): Use parameter `henum', instead of
6944 global variable `wget_enum_handle'.
6946 * keymap.c (describe_vector): Remove parameters `indices' and
6947 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6948 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6950 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6952 * keyboard.c (timer_check): Remove parameter `do_it_now',
6953 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6954 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6955 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6957 * keyboard.c (read_char):
6958 * w32menu.c (w32_menu_display_help):
6959 * xmenu.c (show_help_event, menu_help_callback):
6960 Adjust calls to `show_help_echo'.
6962 * gtkutil.c (xg_maybe_add_timer):
6963 * keyboard.c (readable_events):
6964 * process.c (wait_reading_process_output):
6965 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6967 * insdel.c (adjust_markers_gap_motion):
6968 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6969 (gap_left, gap_right): Don't call it.
6971 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6973 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6974 incurred during fontification.
6976 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6978 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6979 (DEFVAR_PER_BUFFER): Don't pass it.
6981 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6982 (scrolling_window): Don't pass it.
6984 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6986 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6988 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6990 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6991 of variables specific to SELinux and computation of `encoded_absname'.
6993 * image.c (XPutPixel): Remove unused variable `height'.
6995 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6997 * unexw32.c (get_section_info): Remove unused variable `section'.
6999 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7000 (system_process_attributes): Remove unused variable `sess'.
7001 (sys_read): Remove unused variable `err'.
7003 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7004 (w32_wnd_proc): Remove unused variable `isdead'.
7005 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7006 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7007 (x_create_tip_frame): Remove unused variable `tem'.
7009 * w32inevt.c (w32_console_read_socket):
7010 Remove unused variable `no_events'.
7012 * w32term.c (x_draw_composite_glyph_string_foreground):
7013 Remove unused variable `width'.
7015 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7017 * w32term.c (x_set_glyph_string_clipping):
7018 Don't pass uninitialized region to CombineRgn.
7020 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7022 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7023 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7024 (Fx_close_connection): Remove unused variable `i'.
7026 * w32font.c (w32font_draw): Return number of glyphs.
7027 (w32font_open_internal): Remove unused variable `i'.
7028 (w32font_driver): Add missing initializer.
7030 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7031 (fill_in_menu): Remove unused variable `items_added'.
7033 * w32term.c (last_mouse_press_frame): Remove static global variable.
7034 (w32_clip_to_row): Remove unused variable `f'.
7035 (x_delete_terminal): Remove unused variable `i'.
7037 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7038 (NOTHING): Remove unused static global variable.
7039 (uniscribe_check_otf): Remove unused variable `table'.
7040 (uniscribe_font_driver): Add missing initializers.
7042 2011-03-23 Julien Danjou <julien@danjou.info>
7044 * term.c (Fsuspend_tty, Fresume_tty):
7045 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7046 * window.c (temp_output_buffer_show):
7047 * insdel.c (signal_before_change):
7048 * frame.c (Fhandle_switch_frame):
7049 * fileio.c (Fdo_auto_save):
7050 * emacs.c (Fkill_emacs):
7051 * editfns.c (save_excursion_restore):
7052 * cmds.c (internal_self_insert):
7053 * callint.c (Fcall_interactively):
7054 * buffer.c (Fkill_all_local_variables):
7055 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7057 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7058 unconditionnaly since it does the check itself.
7060 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7062 Fix more problems found by GCC 4.5.2's static checks.
7064 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7065 the first time through the loop, since we know p0 < p1 then.
7066 This also avoids a gcc -Wstrict-overflow warning.
7068 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7069 leading to a memory leak, possible in functions like
7070 load_charset_map_from_file that can allocate an unbounded number
7071 of objects (Bug#8318).
7073 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7074 that could (at least in theory) be that large.
7076 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7077 This is less likely to overflow, and avoids undefined behavior if
7078 overflow does occur. All callers changed. Use strtoul to scan
7079 for the unsigned long integer.
7080 (pint2hrstr): Simplify and tune code slightly.
7081 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7083 * scroll.c (do_scrolling): Work around GCC bug 48228.
7084 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7086 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7087 This also avoids a warning with gcc -Wstrict-overflow.
7088 (validate_x_resource_name): Simplify count usage.
7089 This also avoids a warning with gcc -Wstrict-overflow.
7091 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7094 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7096 * process.c (Fmake_network_process): Use socklen_t, not int,
7097 where POSIX says socklen_t is required in portable programs.
7098 This fixes a porting bug on hosts like 64-bit HP-UX, where
7099 socklen_t is wider than int (Bug#8277).
7100 (Fmake_network_process, server_accept_connection):
7101 (wait_reading_process_output, read_process_output):
7104 * process.c: Rename or move locals to avoid shadowing.
7105 (list_processes_1, Fmake_network_process):
7106 (read_process_output_error_handler, exec_sentinel_error_handler):
7107 Rename or move locals.
7108 (Fmake_network_process): Define label "retry_connect" only if needed.
7109 (Fnetwork_interface_info): Fix pointer signedness.
7110 (process_send_signal): Add cast to avoid pointer signedness problem.
7111 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7112 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7114 Make tparam.h and terminfo.c consistent.
7115 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7116 Include tparam.h instead, since it declares them.
7117 * cm.h (PC): Remove extern decl; tparam.h now does this.
7118 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7119 * terminfo.c: Include tparam.h, to check interfaces.
7120 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7121 (tparam): Adjust signature to match interface in tparam.h;
7122 this removes some undefined behavior. Check that outstring and len
7123 are zero, which they always are with Emacs.
7124 * tparam.h (PC, BC, UP): New extern decls.
7126 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7127 (xftfont_open): Rename locals to avoid shadowing.
7129 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7130 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7131 (OTF_TAG_SYM): Omit macro if not needed.
7132 (ftfont_list): Remove unused local.
7133 (get_adstyle_property, ftfont_pattern_entity):
7134 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7135 Rename locals to avoid shadowing.
7137 * xfont.c (xfont_list_family): Mark var as initialized.
7139 * xml.c (make_dom): Now static.
7141 * composite.c (composition_compute_stop_pos): Rename local to
7143 (composition_reseat_it): Remove unused locals.
7144 (find_automatic_composition, composition_adjust_point): Likewise.
7145 (composition_update_it): Mark var as initialized.
7146 (find_automatic_composition): Mark vars as initialized,
7147 with a FIXME (Bug#8290).
7149 character.h: Rename locals to avoid shadowing.
7150 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7151 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7152 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7153 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7156 * textprop.c (property_change_between_p): Remove; unused.
7158 * intervals.c (interval_start_pos): Now static.
7160 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7162 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7163 Rename locals to avoid shadowing.
7165 * sound.c (wav_play, au_play, Fplay_sound_internal):
7166 Fix pointer signedness.
7167 (alsa_choose_format): Remove unused local var.
7168 (wav_play): Initialize a variable to 0, to prevent undefined
7169 behavior (Bug#8278).
7171 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7173 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7175 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7176 clobbering (Bug#8298).
7177 * sysdep.c (sys_subshell): Likewise.
7178 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7180 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7181 This should get cleaned up, so that child_setup has the
7182 same signature on all platforms.
7184 * callproc.c (call_process_cleanup): Now static.
7185 (relocate_fd): Rename locals to avoid shadowing.
7187 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7189 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7190 not to be necessary, and produces flickering.
7192 2011-03-20 Glenn Morris <rgm@gnu.org>
7194 * config.in: Remove file.
7196 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7198 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7199 are now in src/globals.h.
7200 (syms_of_minibuf): Remove spurious & from previous change.
7202 2011-03-20 Leo <sdl.web@gmail.com>
7204 * minibuf.c (completing-read-function): New variable.
7205 (completing-read-default): Rename from completing-read.
7206 (completing-read): Call completing-read-function.
7208 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7210 * xfaces.c (Fx_load_color_file):
7211 Read color file from absolute filename (bug#8250).
7213 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7215 * makefile.w32-in: Update dependencies.
7217 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7219 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7221 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7223 Fix more problems found by GCC 4.5.2's static checks.
7225 * process.c (make_serial_process_unwind, send_process_trap):
7226 (sigchld_handler): Now static.
7228 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7229 That way, the code declares only the vars that it needs.
7230 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7231 * s/cygwin.h (PTY_ITERATION): Likewise.
7232 * s/darwin.h (PTY_ITERATION): Likewise.
7233 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7235 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7236 * process.c (allocate_pty): Don't declare stb unless it's needed.
7238 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7239 (CONSTANTLIM): Remove; unused.
7240 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7241 Define only if needed.
7243 * unexelf.c (unexec): Name an expression,
7244 to avoid gcc -Wbad-function-cast warning.
7245 Use a different way to cause a compilation error if anyone uses
7246 n rather than nn, a way that does not involve shadowing.
7247 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7249 * deps.mk (unexalpha.o): Remove; unused.
7251 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7252 * unexec.h: New file.
7253 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7254 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7256 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7257 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7258 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7259 Change as necessary to match prototype in unexec.h.
7261 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7263 (back_comment, skip_chars): Mark vars as initialized.
7265 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7266 Rename locals to avoid shadowing.
7268 * lread.c (read1): Rewrite so as not to use empty "else".
7269 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7271 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7273 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7274 warning when compiling print.c.
7276 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7277 instead of using an uninitialized var.
7278 (font_sort_entities): Mark var as initialized.
7280 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7282 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7283 pointers to constants.
7284 (font_parse_fcname): Remove unused vars.
7285 (font_delete_unmatched): Now static.
7286 (font_get_spec): Remove; unused.
7287 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7288 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7289 Rename or move locals to avoid shadowing.
7291 * fns.c (require_nesting_list, require_unwind): Now static.
7292 (Ffillarray): Rename locals to avoid shadowing.
7294 * floatfns.c (domain_error2): Define only if needed.
7295 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7297 * alloc.c (mark_backtrace): Move decl from here ...
7298 * lisp.h: ... to here, so that it can be checked.
7300 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7301 (Fdefvar): Rewrite so as not to use empty "else".
7302 (lisp_indirect_variable): Name an expression,
7303 to avoid gcc -Wbad-function-cast warning.
7304 (Fdefvar): Rename locals to avoid shadowing.
7306 * callint.c (quotify_arg, quotify_args): Now static.
7307 (Fcall_interactively): Rename locals to avoid shadowing.
7308 Use const pointer when appropriate.
7310 * lisp.h (get_system_name, get_operating_system_release):
7311 Move decls here, to check interfaces.
7312 * process.c (get_operating_system_release): Move decl to lisp.h.
7313 * xrdb.c (get_system_name): Likewise.
7314 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7315 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7316 some of which prompt warnings from gcc -Wbad-function-cast.
7317 (Fformat_time_string, Fencode_time, Finsert_char):
7318 (Ftranslate_region_internal, Fformat):
7319 Rename or remove local vars to avoid shadowing.
7320 (Ftranslate_region_internal): Mark var as initialized.
7322 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7325 * lisp.h (eassert): Check that the argument compiles, even if
7326 ENABLE_CHECKING is not defined.
7328 * data.c (Findirect_variable): Name an expression, to avoid
7329 gcc -Wbad-function-cast warning.
7330 (default_value, arithcompare, arith_driver, arith_error): Now static.
7331 (store_symval_forwarding): Rename local to avoid shadowing.
7332 (Fmake_variable_buffer_local, Fmake_local_variable):
7333 Mark variables as initialized.
7334 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7336 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7337 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7338 Rename locals to avoid shadowing.
7339 (mark_stack): Move local variables into the #ifdef region where
7341 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7342 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7344 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7345 (GC_STRING_CHARS): Remove; not used.
7346 (Fmemory_limit): Cast sbrk's returned value to char *.
7348 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7349 avoids undefined behavior in theory.
7351 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7353 Use functions, not macros, for up- and down-casing (Bug#8254).
7354 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7355 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7356 to use the following functions instead of these macros.
7357 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7358 EMACS_INT, since callers assume the returned value fits in int.
7359 (upcase1): Likewise, for UPCASE_TABLE.
7360 (uppercasep, lowercasep, upcase): New static inline functions.
7361 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7362 the race-condition problem in the old DOWNCASE.
7364 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7365 Rename locals to avoid shadowing.
7366 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7367 (regex_compile, re_search_2, re_match_2_internal):
7368 Remove unused local vars.
7369 (FREE_VAR): Rewrite so as not to use empty "else",
7370 which gcc can warn about.
7371 (regex_compile, re_match_2_internal): Mark locals as initialized.
7372 (RETALLOC_IF): Define only if needed.
7373 (WORDCHAR_P): Likewise. This one is never needed, but is used
7374 only in a comment talking about a compiler bug, so put inside
7375 the #if 0 of that comment.
7376 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7377 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7380 * search.c (boyer_moore): Rename locals to avoid shadowing.
7381 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7382 (PREV_CHAR_BOUNDARY): Likewise.
7384 * search.c (simple_search): Remove unused var.
7386 * dired.c (compile_pattern): Move decl from here ...
7387 * lisp.h: ... to here, so that it can be checked.
7388 (struct re_registers): New forward decl.
7390 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7392 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7394 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7395 Rename locals to avoid shadowing.
7396 (Fvertical_motion): Mark locals as initialized.
7398 * casefiddle.c (casify_object, casify_region): Now static.
7399 (casify_region): Mark local as initialized.
7401 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7403 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7404 New macros, so that the caller can use some names other than
7405 gcpro1, gcpro2, etc.
7406 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7408 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7409 argument, for consistency with GCPRO2_VAR, etc: it is now the
7410 prefix of the variable, not the variable itself. All uses
7412 * dired.c (directory_files_internal, file_name_completion):
7413 Rename locals to avoid shadowing.
7415 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7416 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7417 dired.c's scmp function, had undefined behavior.
7418 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7419 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7420 * buffer.h: ... to here, because these macros use current_buffer,
7421 and the new implementation with inline functions needs to have
7422 current_buffer in scope now, rather than later when the macros
7424 (downcase, upcase1): New static inline functions.
7425 (DOWNCASE, UPCASE1): Reimplement using these functions.
7426 This avoids undefined behavior in expressions like
7427 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7428 from race conditions in accessing the global variables
7429 case_temp1 and case_temp2.
7430 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7431 * lisp.h (case_temp1, case_temp2): Remove their decls.
7432 * character.h (ASCII_CHAR_P): Move from here ...
7433 * lisp.h: ... to here, so that the inline functions mentioned
7436 * dired.c (directory_files_internal_unwind): Now static.
7438 * fileio.c (file_name_as_directory, directory_file_name):
7439 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7441 (file_name_as_directory): Use const pointers when appropriate.
7442 (Fexpand_file_name): Likewise. In particular, newdir might
7443 point at constant storage, so make it a const pointer.
7444 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7445 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7447 (Fset_file_times, Finsert_file_contents, auto_save_error):
7448 Rename locals to avoid shadowing.
7450 * minibuf.c (choose_minibuf_frame_1): Now static.
7451 (Ftry_completion, Fall_completions): Rename or remove locals
7454 * marker.c (bytepos_to_charpos): Remove; unused.
7456 * lisp.h (verify_bytepos, count_markers): New decls,
7457 so that gcc does not warn that these functions aren't declared.
7459 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7460 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7461 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7462 (copy_text): Remove unused local var.
7464 * filelock.c (within_one_second): Now static.
7465 (lock_file_1): Rename local to avoid shadowing.
7467 * buffer.c (fix_overlays_before): Mark locals as initialized.
7468 (fix_start_end_in_overlays): Likewise. This function should be
7469 simplified by using pointers-to-pointers, but that's a different
7471 (switch_to_buffer_1): Now static.
7472 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7473 (report_overlay_modification): Rename locals to avoid shadowing.
7475 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7476 Fix pointer signedness issue.
7477 (sys_subshell): Mark local as volatile if checking for lint,
7478 to suppress a gcc -Wclobbered warning that does not seem to be right.
7479 (MAXPATHLEN): Define only if needed.
7481 * process.c (serial_open, serial_configure): Move decls from here ...
7482 * systty.h: ... to here, so that they can be checked.
7484 * fns.c (get_random, seed_random): Move extern decls from here ...
7485 * lisp.h: ... to here, so that they can be checked.
7487 * sysdep.c (reset_io): Now static.
7488 (wait_for_termination_signal): Remove; unused.
7490 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7491 (copy_keymap_item, append_key, push_text_char_description):
7493 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7494 (DENSE_TABLE_SIZE): Remove; unused.
7495 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7496 (describe_map_tree):
7497 Rename locals to avoid shadowing.
7499 * keyboard.c: Declare functions static if they are not used elsewhere.
7500 (echo_char, echo_dash, cmd_error, top_level_2):
7501 (poll_for_input, handle_async_input): Now static.
7502 (read_char, kbd_buffer_get_event, make_lispy_position):
7503 (make_lispy_event, make_lispy_movement, apply_modifiers):
7504 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7505 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7506 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7507 (read_key_sequence, read_char): Mark locals as initialized.
7508 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7510 * keyboard.h (make_ctrl_char): New decl.
7511 (mark_kboards): Move decl here ...
7512 * alloc.c (mark_kboards): ... from here.
7514 * lisp.h (force_auto_save_soon): New decl.
7516 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7517 (DEFINE_DUMMY_FUNCTION): New macro.
7518 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7520 (main): Add casts to avoid warnings
7521 if GCC considers string literals to be constants.
7523 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7525 * dbusbind.c: Pointer signedness fixes.
7526 (xd_signature, xd_append_arg, xd_initialize):
7527 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7528 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7529 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7530 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7532 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7533 if GCC considers string literals to be constants.
7534 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7536 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7538 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7539 (print_preprocess, print_object): New macro to fix last change.
7541 * print.c (print_preprocess): Don't forget font objects.
7543 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7545 * emacs.c (USAGE3): Doc fixes.
7547 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7549 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7552 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7554 * lisp.h (VWindow_system, Qfile_name_history):
7555 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7556 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7557 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7559 * w32select.c: Don't #include "keyboard.h".
7560 (run_protected): Add extern declaration for waiting_for_input.
7562 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7563 * w32console.c (detect_input_pending, read_input_pending)
7564 (encode_terminal_code):
7565 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7566 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7567 (w32_system_caret_y, Qfile_name_history):
7568 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7569 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7570 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7571 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7572 * w32proc.c (Qlocal, report_file_error):
7573 * w32term.c (Vwindow_system, updating_frame):
7574 * w32uniscribe.c (initialized, uniscribe_font_driver):
7575 Remove unneeded extern declarations.
7577 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7579 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7581 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7583 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7584 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7585 These macros can no longer be used for assignment.
7587 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7588 Assign struct members directly, instead of using BUF_BEGV etc.
7589 (record_buffer_markers, fetch_buffer_markers): New functions for
7590 recording and fetching special buffer markers.
7591 (set_buffer_internal_1, set_buffer_temp): Use them.
7593 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7595 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7597 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7598 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7600 * xdisp.c (hscroll_window_tree):
7601 (reconsider_clip_changes): Use PT instead of BUF_PT.
7603 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7605 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7606 $(EMACS_ROOT)/lib/intprops.h.
7608 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7610 Fix more problems found by GCC 4.5.2's static checks.
7612 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7613 to unsigned char * to avoid compiler diagnostic.
7614 (xg_free_frame_widgets): Make it clear that a local variable is
7615 needed only if USE_GTK_TOOLTIP.
7616 (gdk_window_get_screen): Make it clear that this macro is needed
7617 only if USE_GTK_TOOLTIP.
7618 (int_gtk_range_get_value): New function, which avoids a diagnostic
7619 from gcc -Wbad-function-cast.
7620 (xg_set_toolkit_scroll_bar_thumb): Use it.
7621 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7622 diagnostic from gcc -Wbad-function-cast.
7623 (get_utf8_string, xg_get_file_with_chooser):
7624 Rename locals to avoid shadowing.
7625 (create_dialog): Move locals to avoid shadowing.
7627 * xgselect.c (xg_select): Remove unused var.
7629 * image.c (four_corners_best): Mark locals as initialized.
7630 (gif_load): Initialize transparent_p to zero (Bug#8238).
7631 Mark another local as initialized.
7632 (my_png_error, my_error_exit): Mark with NO_RETURN.
7634 * image.c (clear_image_cache): Now static.
7635 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7636 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7637 (x_edge_detection): Remove unnecessary cast that
7638 gcc -Wbad-function-cast diagnoses.
7639 (gif_load): Fix pointer signedness.
7640 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7641 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7643 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7645 Improve quality of tests for time stamp overflow.
7646 For example, without this patch (encode-time 0 0 0 1 1
7647 1152921504606846976) returns the obviously-bogus value (-948597
7648 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7649 reports time overflow. See
7650 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7651 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7652 * editfns.c: Include limits.h and intprops.h.
7653 (TIME_T_MIN, TIME_T_MAX): New macros.
7654 (time_overflow): Move earlier, to before first use.
7655 (hi_time, lo_time): New functions, for an accurate test for
7657 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7658 (Fget_internal_run_time): Don't assume time_t fits in int.
7659 (make_time): Use list2 instead of Fcons twice.
7660 (Fdecode_time): More accurate test for out-of-range times.
7661 (check_tm_member): New function.
7662 (Fencode_time): Use it, to test for out-of-range times.
7663 (lisp_time_argument): Don't rely on undefined left-shift and
7664 right-shift behavior when checking for time stamp overflow.
7666 * editfns.c (time_overflow): New function, refactoring common code.
7667 (Fformat_time_string, Fdecode_time, Fencode_time):
7668 (Fcurrent_time_string): Use it.
7670 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7671 * dired.c (make_time): Move to ...
7672 * editfns.c (make_time): ... here.
7673 * systime.h: Note the move.
7675 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7677 * fringe.c (update_window_fringes): Remove unused variables.
7679 * unexmacosx.c (copy_data_segment): Also copy __got section.
7682 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7684 * termcap.c [MSDOS]: Include "msdos.h".
7685 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7686 Constify `char *' arguments and their references according to
7687 prototypes in tparam.h.
7689 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7691 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7692 Adapt all references accordingly.
7694 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7696 2011-03-11 Tom Tromey <tromey@redhat.com>
7698 * buffer.c (syms_of_buffer): Remove obsolete comment.
7700 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7702 * termhooks.h (encode_terminal_code): Declare prototype.
7704 * msdos.c (encode_terminal_code): Don't declare prototype.
7706 * term.c (encode_terminal_code): Now external again, used by
7707 w32console.c and msdos.c.
7709 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7710 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7712 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7714 Fix some minor problems found by GCC 4.5.2's static checks.
7716 * fringe.c (update_window_fringes): Mark locals as initialized
7718 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7720 * alloc.c (mark_fringe_data): Move decl from here ...
7721 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7722 to check its interface.
7723 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7725 * fontset.c (free_realized_fontset): Now static.
7726 (Fset_fontset_font): Rename local to avoid shadowing.
7727 (fontset_font): Mark local as initialized.
7728 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7730 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7732 * xselect.c (x_disown_buffer_selections): Remove; not used.
7733 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7734 (x_own_selection, Fx_disown_selection_internal): Rename locals
7736 (x_handle_dnd_message): Remove local to avoid shadowing.
7738 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7739 so that the caller can use some name other than gcpro1.
7740 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7741 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7742 (Fx_backspace_delete_keys_p):
7743 Use them to avoid shadowing, and rename vars to avoid shadowing.
7744 (x_decode_color, x_set_name, x_window): Now static.
7745 (Fx_create_frame): Add braces to silence GCC warning.
7746 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7747 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7748 Remove unused locals.
7749 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7750 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7751 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7754 * xterm.h (x_mouse_leave): New decl.
7756 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7757 Remove unused functions.
7758 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7759 (x_calc_absolute_position): Now static.
7760 (XTread_socket): Don't define label "out" unless it's used.
7761 Don't declare local "event" unless it's used.
7762 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7763 unless they are used.
7764 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7765 (x_fatal_error_signal): Remove; not used.
7766 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7767 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7768 (x_error_catcher, x_connection_closed, x_error_handler):
7769 (x_error_quitter, xembed_send_message, x_iconify_frame):
7770 (my_log_handler): Rename locals to avoid shadowing.
7771 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7772 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7774 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7775 Rename or move locals to avoid shadowing.
7776 (tty_defined_color, merge_face_heights): Now static.
7777 (free_realized_faces_for_fontset): Remove; not used.
7778 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7779 does not deduce is never used uninitialized.
7780 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7781 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7783 * terminal.c (store_terminal_param): Now static.
7785 * xmenu.c (menu_highlight_callback): Now static.
7786 (set_frame_menubar): Remove unused local.
7787 (xmenu_show): Rename parameter to avoid shadowing.
7788 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7789 since they might point to immutable storage.
7790 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7791 since it's unused otherwise.
7793 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7794 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7795 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7796 avoids a gcc -Wuninitialized diagnostic.
7797 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7798 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7799 does not deduce are never used uninitialized.
7801 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7803 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7804 * window.c (window_loop, size_window):
7805 (run_window_configuration_change_hook, enlarge_window): Likewise.
7807 * window.c (display_buffer): Now static.
7808 (size_window): Mark variables that gcc -Wuninitialized
7809 does not deduce are never used uninitialized.
7810 * window.h (check_all_windows): New decl, to forestall
7811 gcc -Wmissing-prototypes diagnostic.
7812 * dispextern.h (bidi_dump_cached_states): Likewise.
7814 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7816 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7818 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7819 and to avoid gcc -Wuninitialized warning.
7820 (load_charset_map): Mark variables that gcc -Wuninitialized
7821 does not deduce are never used uninitialized.
7822 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7824 * coding.c (coding_set_source, coding_set_destination):
7825 Use "else { /* comment */ }" rather than "else /* comment */;"
7826 for clarity, and to avoid gcc -Wempty-body warning.
7827 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7828 a block, when the outer 'i' will do.
7829 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7830 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7831 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7832 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7833 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7834 Rename locals to avoid shadowing.
7835 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7836 * coding.c (emacs_mule_char, encode_invocation_designation):
7837 Now static, since they're not used elsewhere.
7838 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7839 (decode_coding_object, encode_coding_object, detect_coding_system):
7840 (decode_coding_emacs_mule): Mark variables that gcc
7841 -Wuninitialized does not deduce are never used uninitialized.
7842 (detect_coding_iso_2022): Initialize a local variable that might
7843 be used uninitialized. Leave a FIXME because it's not clear that
7844 this initialization is needed. (Bug#8211)
7845 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7846 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7847 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7848 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7849 Remove unused macros.
7851 * category.c (hash_get_category_set): Remove unused local var.
7852 (copy_category_table): Now static, since it's not used elsewhere.
7853 * character.c (string_count_byte8): Likewise.
7855 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7856 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7858 * chartab.c (copy_sub_char_table): Now static, since it's not used
7860 (sub_char_table_ref_and_range, char_table_ref_and_range):
7861 Rename locals to avoid shadowing.
7862 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7864 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7865 (BIDI_BOB): Remove unused macro.
7867 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7868 deduce are never used uninitialized.
7869 * term.c (encode_terminal_code): Likewise.
7871 * term.c (encode_terminal_code): Now static. Remove unused local.
7873 * tparam.h: New file.
7874 * term.c, tparam.h: Include it.
7875 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7876 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7877 Move these decls to tparam.h, and make them agree with what
7878 is actually in tparam.c. The previous trick of using incompatible
7879 decls in different modules does not conform to the C standard.
7880 All callers of tparam changed to use tparam's actual API.
7881 * tparam.c (tparam1, tparam, tgoto):
7882 Use const pointers where appropriate.
7884 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7885 * cm.h (struct cm): Likewise.
7886 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7887 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7888 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7889 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7890 (turn_on_face, init_tty): Likewise.
7891 * termchar.h (struct tty_display_info): Likewise.
7893 * term.c (term_mouse_position): Rename local to avoid shadowing.
7895 * alloc.c (mark_ttys): Move decl from here ...
7896 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7898 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7900 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7902 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7904 * search.c (compile_pattern_1): Remove argument regp, unused since
7905 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7906 (compile_pattern): Don't pass it.
7908 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7910 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7911 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7913 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7915 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7917 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7918 gdk_window_get_screen, gdk_window_get_geometry,
7919 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7920 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7921 (xg_get_pixbuf_from_pixmap): New function.
7922 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7923 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7924 Call xg_get_pixbuf_from_pixmap instead of
7925 gdk_pixbuf_get_from_drawable.
7926 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7927 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7928 (xg_check_special_colors): Use GtkStyleContext and its functions
7930 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7931 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7932 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7933 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7934 Call gtk_widget_get_preferred_size.
7935 (xg_frame_resized): gdk_window_get_geometry only takes 5
7937 (xg_win_to_widget, xg_event_is_for_menubar):
7938 Call gdk_x11_window_lookup_for_display.
7939 (xg_set_widget_bg): New function.
7940 (delete_cb): New function.
7941 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7942 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7943 (xg_set_background_color): Call xg_set_widget_bg.
7944 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7945 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7946 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7947 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7949 (update_frame_tool_bar): Call gtk_widget_hide.
7950 (xg_initialize): Use GDK_KEY_g.
7952 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7954 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7956 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7957 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7958 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7960 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7962 * w32xfns.c (select_palette): Check success of RealizePalette against
7963 GDI_ERROR, not zero.
7965 See ChangeLog.11 for earlier changes.
7971 Copyright (C) 2011 Free Software Foundation, Inc.
7973 This file is part of GNU Emacs.
7975 GNU Emacs is free software: you can redistribute it and/or modify
7976 it under the terms of the GNU General Public License as published by
7977 the Free Software Foundation, either version 3 of the License, or
7978 (at your option) any later version.
7980 GNU Emacs is distributed in the hope that it will be useful,
7981 but WITHOUT ANY WARRANTY; without even the implied warranty of
7982 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7983 GNU General Public License for more details.
7985 You should have received a copy of the GNU General Public License
7986 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.