1 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3 Port --enable-checking=all to Fedora 14 x86-64.
4 * charset.c (syms_of_charset): Also account for glibc malloc's
5 internal overhead when calculating the initial malloc maximum.
7 Port --enable-checking=all to Fedora 14 x86.
8 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
11 (overrun_check_realloc, overrun_check_free):
12 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
13 That way, xmalloc returns a properly-aligned pointer even if
14 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
15 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
16 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
17 into account when calculating the initial malloc maximum.
18 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
19 Move here from alloc.c, so that charset.c can use it too.
20 Properly align; the old code wasn't right for common 32-bit hosts
21 when configured with --enable-checking=all.
22 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
23 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
25 2011-09-29 Eli Zaretskii <eliz@gnu.org>
27 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
30 2011-09-28 Eli Zaretskii <eliz@gnu.org>
32 * xdisp.c (compute_display_string_end): If there's no display
33 string at CHARPOS, return -1.
35 * bidi.c (bidi_fetch_char): When compute_display_string_end
36 returns a negative value, treat the character as a normal
37 character not covered by a display string. (Bug#9624)
39 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
41 * lread.c (Fread_from_string): Fix typo in docstring.
43 2011-09-27 Eli Zaretskii <eliz@gnu.org>
45 * xdisp.c (handle_invisible_prop): If invisible text ends on a
46 newline, reseat the iterator instead of bidi-iterating there one
47 character at a time. (Bug#9610)
48 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail out when
49 past TO_CHARPOS if the bidi iterator is at base embedding level.
51 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
53 * lread.c (readevalloop): Use correct code for NBSP.
54 (read1): Likewise. (Bug#9608)
56 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
58 * dbusbind.c (Fdbus_register_signal): When service is not
59 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
61 2011-09-25 Glenn Morris <rgm@gnu.org>
63 * buffer.c (truncate-lines): Doc fix.
65 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
67 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
68 (Fset_window_next_buffers): Doc fix.
70 2011-09-24 Glenn Morris <rgm@gnu.org>
72 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
74 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
76 Fix minor problems found by static checking.
77 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
78 * indent.c (Fvertical_motion): Fix == vs = typo.
80 2011-09-24 Eli Zaretskii <eliz@gnu.org>
82 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
83 value is now t. Doc fix.
85 * indent.c (Fvertical_motion): Compute and apply the overshoot
86 logic also when moving up, not only when moving down. Fix the
87 confusing name and values of the it_overshoot_expected variable;
88 logic changed accordingly. (Bug#9254) (Bug#9549)
90 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
91 CHARPOS is covered by a display string which includes newlines.
92 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
93 is covered by a display string with embedded newlines.
95 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
97 * dbusbind.c (Fdbus_register_signal): Add match rule to
98 Vdbus_registered_objects_table. (Bug#9581)
99 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
102 2011-09-24 Jim Meyering <meyering@redhat.com>
104 Do not ignore write error for any output size.
105 The previous change was incomplete.
106 While it makes emacs --batch detect the vast majority of stdout
107 write failures, errors were still ignored whenever the output size is
108 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
109 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
110 && echo FAIL: ignored write error
111 FAIL: ignored write error
112 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
113 && echo FAIL: ignored write error
114 FAIL: ignored write error
115 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
117 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
119 * emacs.c (Fkill_emacs): In noninteractive mode exit
120 non-successfully if a write error occurred on stdout. (Bug#9574)
122 2011-09-21 Eli Zaretskii <eliz@gnu.org>
124 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
127 * dispextern.h (struct it): Update the comment documenting what
130 2011-09-20 Eli Zaretskii <eliz@gnu.org>
132 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
133 a display string, extend search for cursor position to end of row.
134 (find_row_edges): If the row ends in a newline from a display
135 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
136 Handle the case of a display string with multiple newlines.
137 (Fcurrent_bidi_paragraph_direction): Fix search for previous
138 non-empty line. Fixes confusing cursor motion with arrow keys at
139 the beginning of a line that starts with whitespace.
141 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
143 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
146 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
148 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
151 2011-09-18 Eli Zaretskii <eliz@gnu.org>
153 * xdisp.c (display_line): Record maximum and minimum buffer
154 positions even if no glyphs were produced (e.g., by a zero-width
155 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
156 buffer positions that will be removed from the glyph row because
158 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
159 column is beyond frame width: don't subtract 1 "pixel" when
160 computing width of the stretch.
161 (reseat_at_next_visible_line_start): Undo the change made on
162 2011-09-17 that saved paragraph information and restored it after
163 the call to `reseat'. (Bug#9545)
165 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
167 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
168 and turn window cursor on if cleared (Bug#9415).
170 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
172 * search.c (boyer_moore): Take unibyte characters from pattern
173 literally. (Bug#9458)
175 2011-09-18 Eli Zaretskii <eliz@gnu.org>
177 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
179 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
181 Fix minor problem found by static checking.
182 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
183 initialized, to pacify gcc -Wuninitialized.
185 * fileio.c: Report proper errno when syscall falls.
186 (Finsert_file_contents): Save and restore errno,
187 so that report_file_error outputs the correct diagnostic.
188 (Fwrite_region) [CLASH_DETECTION]: Likewise.
190 2011-09-18 Eli Zaretskii <eliz@gnu.org>
192 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
194 2011-09-17 Eli Zaretskii <eliz@gnu.org>
196 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
197 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
199 2011-09-17 Eli Zaretskii <eliz@gnu.org>
201 * xdisp.c (reseat_at_next_visible_line_start): Keep information
202 about the current paragraph and restore it after the call to
205 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
206 (bidi_find_paragraph_start): Search back for paragraph beginning
207 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
208 (bidi_move_to_visually_next): Only trigger paragraph-related
209 computations when the last character is a newline or at EOB, not
210 just any NEUTRAL_B. (Bug#9470)
212 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
213 truncated lines if point is covered by a display string. (Bug#9524)
215 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
217 * xselect.c: Relax test for outgoing X longs (Bug#9498).
218 (cons_to_x_long): New function.
219 (lisp_data_to_selection_data): Use it. Correct the test for
220 short-versus-long data; it was negated. Break out of vector
221 loop, for efficiency, when a long datum is discovered.
223 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
225 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
227 2011-09-16 Eli Zaretskii <eliz@gnu.org>
229 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
230 GCC PR/17406) by declaring this function with external scope.
232 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
234 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
235 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
237 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
239 * editfns.c (Fformat): Correctly handle text properties on "%%".
241 2011-09-15 Eli Zaretskii <eliz@gnu.org>
243 * xterm.c (x_draw_composite_glyph_string_foreground):
244 * w32term.c (x_draw_composite_glyph_string_foreground):
245 * term.c (encode_terminal_code):
246 * composite.c (composition_update_it, get_composition_id):
247 * xdisp.c (get_next_display_element)
248 (fill_composite_glyph_string): Add comments about special meaning
249 of TAB characters in a composition.
251 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
253 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
254 This occurs when processing a multibyte format.
255 Problem reported by Wolfgang Jenker.
257 2011-09-15 Johan Bockgård <bojohan@gnu.org>
259 * xdisp.c (try_cursor_movement): Only check for exact match if
260 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
262 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
264 Remove unused external symbols.
265 * dispextern.h (calc_pixel_width_or_height): Remove decl.
266 * xdisp.c (calc_pixel_width_or_height): Now static.
267 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
268 * indent.c (check_display_width):
269 * w32term.c: Fix comment to match code.
270 * xterm.c, xterm.h (x_catching_errors): Remove.
272 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
274 * xselect.c: Use signed conversions more consistently (Bug#9498).
275 (selection_data_to_lisp_data): Assume incoming selection data are
276 signed integers, not unsigned. This is to be consistent with
277 outgoing selection data, which was modified to use signed integers
278 in as part of the fix to Bug#9196 in response to Jan D.'s comment
279 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
280 expects long, not unsigned long.
282 2011-09-14 Eli Zaretskii <eliz@gnu.org>
284 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
285 computation of loop end. Reported by Johan Bockgård
288 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
290 * frame.c (Fother_visible_frames_p): Function deleted.
292 2011-09-12 Eli Zaretskii <eliz@gnu.org>
294 * indent.c (compute_motion): Process display vector front to back
295 rather than the other way around. (Bug#2496)
297 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
299 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
301 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
303 * minibuf.c (Fread_from_minibuffer): Doc fix.
305 2011-09-11 Eli Zaretskii <eliz@gnu.org>
307 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
308 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
310 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
312 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
313 value for non-existent files.
315 2011-09-11 Eli Zaretskii <eliz@gnu.org>
317 * fileio.c (Finsert_file_contents): If the file cannot be opened,
318 set its "size" to -1. This will set the modtime_size field of
319 the corresponding buffer to -1, which is what
320 verify-visited-file-modtime expects for files that do not exist.
323 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
325 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
327 * lisp.h: ... from here. push_key_description is no longer
328 defined in keyboard.c, so its declaration should not be in
329 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
330 logically belongs with push_key_description.
332 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
334 * buffer.h: Include <sys/types.h> instead of <time.h>.
335 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
336 Problem reported by Herbert J. Skuhra.
338 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
340 * xml.c (parse_region): Make the parsing work for
341 non-comment-starting XML files again (bug#9144).
343 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
345 * image.c (gif_load): Fix calculation of bottom and right corner.
348 2011-09-10 Eli Zaretskii <eliz@gnu.org>
350 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
351 redisplay in small windows.
353 2011-09-09 Eli Zaretskii <eliz@gnu.org>
355 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
357 2011-09-08 Martin Rudalics <rudalics@gmx.at>
359 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
360 Operate on live windows only.
362 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
364 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
366 2011-09-07 Eli Zaretskii <eliz@gnu.org>
368 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
369 only under bidi iteration.
371 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
373 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
375 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
377 isnan: Fix porting problem to Solaris 10 with bundled gcc.
378 Without this fix, the command to link temacs failed due to an
379 undefined symbol __builtin_isnan. This is because
380 /usr/include/iso/math_c99.h #defines isnan(x) to
381 __builtin_isnan(x), but the bundled gcc, which identifies itself
382 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
384 * floatfns.c (isnan): #undef, and then #define to a clone of
386 (Fisnan): Always define, since it's always available now.
387 (syms_of_floatfns): Always define isnan at the Lisp level.
389 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
391 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
393 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
395 * fileio.c: Fix bugs with large file offsets (Bug#9428).
396 The previous code assumed that file offsets (off_t values) fit in
397 EMACS_INT variables, which is not true on typical 32-bit hosts.
398 The code messed up by falsely reporting buffer overflow in cases
399 such as (insert-file-contents "big" nil 1 2) into an empty buffer
400 when "big" contains more than 2**29 bytes, even though this
401 inserts just one byte and does not overflow the buffer.
402 (Finsert_file_contents): Store file offsets as off_t
403 values, not as EMACS_INT values. Check for overflow when
404 converting between EMACS_INT and off_t. When checking for
405 buffer overflow or for overlap, take the offsets into account.
406 Don't use EMACS_INT for small values where int suffices.
407 When checking for overlap, fix a typo: ZV was used where
408 ZV_BYTE was intended.
409 (Fwrite_region): Don't assume off_t fits into 'long'.
410 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
412 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
414 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
416 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
418 sprintf-related integer and memory overflow issues (Bug#9412).
420 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
421 (esprintf, exprintf, evxprintf): New functions.
422 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
423 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
424 (modify_event_symbol): Do not assume that the length of
425 name_alist_or_stem is safe to alloca and fits in int.
426 (Fexecute_extended_command): Likewise for function name and binding.
427 (Frecursion_depth): Wrap around reliably on integer overflow.
428 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
429 since some callers pass EMACS_INT values.
430 (Fsingle_key_description): Don't crash if symbol name contains more
431 than MAX_ALLOCA bytes.
432 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
433 (get_minibuffer): Arg is now EMACS_INT, not int.
434 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
435 (esprintf, exprintf, evxprintf): New decls.
436 * window.h (command_loop_level, minibuf_level): Reflect API changes.
438 * dbusbind.c (signature_cat): New function.
439 (xd_signature, Fdbus_register_signal):
440 Do not overrun buffer; instead, report string overflow.
442 * dispnew.c (add_window_display_history): Don't overrun buffer.
443 Truncate instead; this is OK since it's just a log.
445 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
446 even if the time zone offset is outlandishly large.
447 Don't mishandle offset == INT_MIN.
449 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
450 when creating daemon; the previous buffer-overflow check was incorrect.
452 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
453 which has the guts of the old verror function.
455 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
456 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
458 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
459 (font_unparse_xlfd): Don't blindly alloca long strings.
460 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
461 fits in int, when using sprintf. Use single snprintf to count
462 length of string rather than counting it via multiple sprintfs;
463 that's simpler and more reliable.
464 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
465 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
466 sprintf, in case result does not fit in int.
468 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
469 (fontset_from_font): Print it.
471 * frame.c (tty_frame_count): Now printmax_t, not int.
472 (make_terminal_frame, set_term_frame_name): Print it.
473 (x_report_frame_params): In X, window IDs are unsigned long,
474 not signed long, so print them as unsigned.
475 (validate_x_resource_name): Check for implausibly long names,
476 and don't assume name length fits in 'int'.
477 (x_get_resource_string): Don't blindly alloca invocation name;
478 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
481 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
482 (xg_check_special_colors, xg_set_geometry):
483 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
485 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
486 Use esprintf, not sprintf, in case result does not fit in int.
488 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
489 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
490 it as a large positive number.
491 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
492 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
494 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
495 in case result does not fit in int.
497 * print.c (float_to_string): Detect width overflow more reliably.
498 (print_object): Make sprintf buffer a bit bigger, to avoid potential
499 buffer overrun. Don't assume list length fits in 'int'. Treat
500 print length of 0 as 0, not as infinity; to be consistent with other
501 uses of print length in this function. Don't overflow print length
502 index. Don't assume hash table size fits in 'long', or that
503 vectorlike size fits in 'unsigned long'.
505 * process.c (make_process): Use printmax_t, not int, to format
506 process-name gensyms.
508 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
510 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
511 to avoid potential buffer overrun.
513 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
514 if X resource line is longer than 512 bytes.
516 * xfns.c (x_window): Make sprintf buffer a bit bigger
517 to avoid potential buffer overrun.
519 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
521 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
523 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
525 Integer overflow fixes for scrolling, etc.
526 Without these, Emacs silently mishandles large integers sometimes.
527 For example, "C-u 4294967297 M-x recenter" was treated as if
528 it were "C-u 1 M-x recenter" on a typical 64-bit host.
530 * xdisp.c (try_window_id): Check Emacs fixnum range before
533 * window.c (window_scroll_line_based, Frecenter):
534 Check that an Emacs fixnum is in range before assigning it to 'int'.
535 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
536 values converted from Emacs fixnums.
537 (Frecenter): Don't wrap around a line count if it is out of 'int'
538 range; instead, treat it as an extreme value.
539 (Fset_window_configuration, compare_window_configurations):
540 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
542 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
543 that can exceed INT_MAX. Check that EMACS_INT value is in range
544 before assigning it to the (possibly-narrower) index.
545 (match_limit): Don't assume that a fixnum can fit in 'int'.
547 * print.c (print_object): Use ptrdiff_t, not int, for index that can
550 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
551 (Fvertical_motion): Don't wrap around LINES values that don't fit
552 in 'int'. Instead, treat them as extreme values. This is good
553 enough for windows, which can't have more than INT_MAX lines anyway.
555 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
557 * Require libxml/parser.h to avoid compilation warning.
559 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
561 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
562 since this reportedly can destroy thread storage.
564 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
566 * syntax.c (find_defun_start): Update all cache variables if
567 exiting early (Bug#9401).
569 2011-08-30 Eli Zaretskii <eliz@gnu.org>
571 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
573 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
574 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
575 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
577 * term.c (tty_append_glyph): New function.
578 (produce_stretch_glyph): Static function and its prototype deleted.
580 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
583 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
585 * image.c (parse_image_spec): Check for nonnegative, not for positive,
586 when checking :margin (Bug#9390).
587 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
588 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
589 so that the name doesn't mislead. All uses changed.
591 2011-08-28 Johan Bockgård <bojohan@gnu.org>
593 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
596 2011-08-27 Eli Zaretskii <eliz@gnu.org>
598 * xdisp.c (move_it_to): Don't bail out early when reaching
599 position beyond to_charpos, if we are scanning backwards.
600 (move_it_vertically_backward): When DY == 0, make sure we get to
601 the first character in the line after the newline.
603 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
605 * ccl.c: Improve and simplify overflow checking (Bug#9196).
606 (ccl_driver): Do not generate an out-of-range pointer.
607 (Fccl_execute_on_string): Remove unnecessary check for
608 integer overflow, noted by Stefan Monnier in
609 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
610 Remove a FIXME that didn't need fixing.
611 Simplify the newly-introduced buffer reallocation code.
613 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
615 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
617 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
619 Integer and memory overflow issues (Bug#9196).
621 * doc.c (get_doc_string): Rework so that
622 get_doc_string_buffer_size is the actual buffer size, rather than
623 being 1 less than the actual buffer size; this makes xpalloc more
626 * image.c (x_allocate_bitmap_record, cache_image):
627 * xselect.c (Fx_register_dnd_atom):
628 Simplify previous changes by using xpalloc.
630 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
631 since either will do and ptrdiff_t is convenient with xpalloc.
633 * charset.c (charset_table_size)
634 (struct charset_sort_data.priority): Now ptrdiff_t.
635 (charset_compare): Don't overflow if priorities differ greatly.
636 (Fsort_charsets): Don't assume list length fits in int.
637 Check for size-calculation overflow when allocating sort data.
638 (syms_of_charset): Allocate an initial charset table that is
639 just under 64 KiB, to avoid problems with glibc malloc and mmap.
641 * cmds.c (internal_self_insert): Check for size-calculation overflow.
643 * composite.h (struct composition.glyph_len): Now int, not unsigned.
644 The actual value is always <= INT_MAX, and leaving it unsigned made
645 overflow checking harder.
647 * dispextern.h (struct glyph_matrix.rows_allocated)
648 (struct face_cache.size): Now ptrdiff_t, for convenience in use
649 with xpalloc. The values are still always <= INT_MAX.
651 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
653 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
654 (SAFE_NALLOCA): New macro.
656 * region-cache.c (struct boundary.pos, find_cache_boundary)
657 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
658 (set_cache_region, invalidate_region_cache)
659 (revalidate_region_cache, know_region_cache, region_cache_forward)
660 (region_cache_backward, pp_cache):
661 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
662 so that ptrdiff_t * can be passed to xpalloc.
663 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
664 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
665 (pp_cache): Don't assume cache_len fits in int.
666 * region-cache.h: Adjust extern decls to match.
668 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
669 EMACS_INT, since either will do, for xpalloc.
671 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
672 (xnmalloc, xnrealloc, xpalloc): New functions.
674 * bidi.c (bidi_shelve_header_size): New constant.
675 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
676 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
678 * bidi.c (bidi_cache_shrink):
679 * buffer.c (overlays_at, overlays_in, record_overlay_string)
681 Don't update size of array until after memory allocation succeeds,
682 because xmalloc/xrealloc may not return.
683 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
684 now that we have proper integer overflow checking.
685 (record_overlay_string, overlay_strings): Catch overflows when
686 calculating size of overlay_str_buf.
688 * callproc.c (Fcall_process): Check for size overflow when
689 calculating size of args2.
690 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
691 Normally we prefer signed values, but sticking with ptrdiff_t would
692 require adding more-complicated checks.
694 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
695 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
696 Redo buffer-overflow calculations to avoid integer overflow.
697 Add a FIXME comment where memory seems to be over-allocated.
699 * character.c (Fstring): Check for size-calculation overflow.
701 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
702 unnecessary integer overflow. Check for size overflow.
703 (encode_coding_object): Don't update size until xmalloc succeeds.
705 * composite.c (get_composition_id): Check for overflow in glyph
708 Integer and memory overflow fixes for display code.
709 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
710 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
711 (scrolling_window): Check for overflow in size calculations.
712 (line_draw_cost, realloc_glyph_pool, add_row_entry):
713 Don't assume glyph table len fits in int.
714 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
715 (row_table_size): Now ptrdiff_t, not int.
716 (scrolling_window): Avoid overflow in size calculations.
717 Don't update size until allocation succeeds.
718 * fns.c (concat): Check for overflow in size calculations.
719 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
720 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
721 (NEXT_ALMOST_PRIME_LIMIT): New constant.
723 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
724 (get_doc_string): Check for size calculation overflow.
725 Don't update size until allocation succeeds.
726 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
727 EMACS_INT, where ptrdiff_t will do.
728 (Fsubstitute_command_keys): Check for string overflow.
730 * editfns.c (set_time_zone_rule): Don't assume environment length
732 (message_length): Now ptrdiff_t, not int.
733 (Fmessage_box): Don't update size until allocation succeeds.
734 Don't assume message length fits in int.
735 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
737 * emacs.c (main): Do not reallocate argv, since there is a null at
738 the end that can be overwritten, and this way there's no need to
739 worry about size-calculation overflow.
740 (sort_args): Check for size-calculation overflow.
742 * eval.c (init_eval_once, grow_specpdl): Don't update size until
744 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
746 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
747 (x_set_scroll_bar_width, x_figure_window_size):
748 Check for integer overflow.
749 (x_set_alpha): Do not assume XINT fits in int.
751 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
752 This is for the members text_lines, text_cols, total_lines, total_cols,
753 where the system imposes an 'int' limit.
755 * fringe.c (Fdefine_fringe_bitmap):
756 Don't update size until alloc works.
758 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
759 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
761 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
762 Check for size-calculation overflow.
763 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
764 do, as we prefer signed integers.
765 (id_to_widget.max_size, id_to_widget.used)
766 (xg_store_widget_in_map, xg_remove_widget_from_map)
767 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
768 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
769 Use and return ptrdiff_t, not int.
770 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
771 * gtkutil.h: Change prototypes to match the above.
773 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
774 are duplicate now that they've been promoted to lisp.h.
775 (x_allocate_bitmap_record, x_alloc_image_color)
776 (make_image_cache, cache_image, xpm_load):
777 Don't update size until alloc is done.
778 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
780 Check for size calculation overflow.
781 (ct_colors_allocated_max): New constant.
782 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
785 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
786 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
787 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
788 Use ptrdiff_t, not int, to count maps.
789 (read_char_minibuf_menu_prompt): Check for overflow in size
790 calculations. Don't update size until allocation succeeds. Redo
791 calculations to avoid overflow.
792 * keyboard.h: Change prototypes to match the above.
794 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
796 (current_minor_maps): Check for size calculation overflow.
797 * keymap.h: Change prototypes to match the above.
799 * lread.c (read1, init_obarray): Don't update size until alloc done.
801 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
802 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
804 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
805 Now ptrdiff_t, not int.
806 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
807 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
809 * process.c (Fnetwork_interface_list): Check for overflow
812 * region-cache.c (move_cache_gap): Check for size calculation overflow.
814 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
815 overflow. Don't bother calling xmalloc when xrealloc will do.
817 * search.c (Freplace_match): Check for size calculation overflow.
818 (Fset_match_data): Don't assume list lengths fit in 'int'.
820 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
821 for command line length. Do not attempt to address one before the
822 beginning of an array, as that's not portable.
824 * term.c (max_frame_lines): Remove; unused.
825 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
827 (encode_terminal_code, calculate_costs): Check for size
828 calculation overflow.
829 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
830 table lengths and related sizes. Don't update size until alloc
831 done. Redo calculations to avoid overflow.
832 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
834 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
835 subtracting pointers.
836 (gobble_line): Check for overflow more carefully. Don't update size
839 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
840 Don't update size until alloc done.
841 Redo size calculations to avoid overflow.
842 Check for size calculation overflow.
843 (main) [DEBUG]: Fix typo in invoking tparam1.
845 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
846 Use ptrdiff_t, not int, for sizes.
847 (store_mode_line_noprop_char): Don't update size until alloc done.
849 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
850 Use ptrdiff_t, not int, for sizes.
851 (Finternal_make_lisp_face, cache_face):
852 Check for size calculation overflow.
853 (cache_face): Treat size calculation overflows as if they were
854 memory exhaustion (the usual treatment), rather than aborting.
856 * xfns.c (x_encode_text, x_set_name_internal)
857 (Fx_change_window_property): Use ptrdiff_t, not int, to count
858 sizes, since they can exceed INT_MAX in size. Check for size
859 calculation overflow.
861 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
862 (xg_select): Check for size calculation overflow.
863 Don't update size until alloc done.
865 * xrdb.c (get_environ_db): Don't assume path length fits in int,
866 as sprintf is limited to int lengths.
868 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
869 (X_LONG_MIN): New macros.
870 Use them to make the following changes clearer.
871 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
872 This change doesn't affect the value now, but it may help remind
873 future maintainers not to raise the value too much later.
874 (SELECTION_QUANTUM): Remove, replacing with ...
875 (selection_quantum): ... new function, which avoids overflow.
877 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
878 assumption that selection length fits in 'int'.
879 (x_reply_selection_request, x_handle_selection_request)
880 (x_get_window_property, receive_incremental_selection)
881 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
882 (lisp_data_to_selection_data, clean_local_selection_data):
883 Use ptrdiff_t, not int, to record length of selection.
884 (x_reply_selection_request, x_get_window_property)
885 (receive_incremental_selection, x_property_data_to_lisp):
886 Redo calculations to avoid overflow.
887 (x_reply_selection_request): When sending hint, ceiling it at
888 X_LONG_MAX rather than relying on wraparound overflow to send
890 (x_get_window_property, receive_incremental_selection)
891 (lisp_data_to_selection_data, x_property_data_to_lisp):
892 Check for size-calculation overflow.
893 (x_get_window_property, receive_incremental_selection)
894 (lisp_data_to_selection_data, Fx_register_dnd_atom):
895 Don't store size until memory allocation succeeds.
896 (x_get_window_property): Plug memory leak on memory exhaustion.
897 Don't double-block input; malloc is safe here. Don't assume 2**34
898 - 4 fits in unsigned long. Add an xassert to check
899 XGetWindowProperty overflow. Be more careful about overflow
900 calculations, and distinguish size from memory overflow better.
901 (receive_incremental_selection): When tracing, don't assume
902 unsigned int is less than INT_MAX.
903 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
904 harmful) conversions of unsigned short to int.
905 (lisp_data_to_selection_data): Don't assume that integers
906 in the range -65535 through -1 fit in an X unsigned short.
907 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
908 result parameters unless successful. Rely on cons_to_unsigned
909 to report problems with elements; the old code wasn't right anyway.
910 (x_check_property_data): Check for int overflow; we cannot use
911 a wider type due to X limits.
912 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
914 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
916 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
917 (x_term_init): Check for size calculation overflow.
918 (x_color_cells): Don't store size until memory allocation succeeds.
919 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
920 Don't assume alloca size is less than MAX_ALLOCA.
921 (x_term_init): Don't assume length fits in int (sprintf is limited
924 Use ptrdiff_t for composition IDs.
925 * character.c (lisp_string_width):
926 * composite.c (composition_table_size, n_compositions)
927 (get_composition_id, composition_gstring_from_id):
928 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
929 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
930 * window.c (Frecenter):
931 Use ptrdiff_t, not int, for composition IDs.
932 * composite.c (get_composition_id): Check for integer overflow.
933 * composite.h: Adjust prototypes to match the above changes.
935 Use ptrdiff_t for hash table indexes.
936 * category.c (hash_get_category_set):
937 * ccl.c (ccl_driver):
938 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
939 * coding.c (coding_system_charset_list, detect_coding_system):
940 * coding.h (struct coding_system.id):
941 * composite.c (get_composition_id, gstring_lookup_cache):
942 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
943 * image.c (xpm_get_color_table_h):
944 * lisp.h (hash_lookup, hash_put):
945 * minibuf.c (Ftest_completion):
946 Use ptrdiff_t for hash table indexes, not int (which is too
947 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
948 32-bit --with-wide-int hosts).
950 * charset.c (Fdefine_charset_internal): Check for integer overflow.
951 Add a FIXME comment about memory leaks.
952 (syms_of_charset): Don't assume xmalloc returns.
954 Don't assume that stated character widths fit in int.
955 * character.c (Fchar_width, c_string_width, lisp_string_width):
956 * character.h (CHAR_WIDTH):
957 * indent.c (MULTIBYTE_BYTES_WIDTH):
958 Use sanitize_char_width to avoid undefined and/or bad behavior
959 with outlandish widths.
960 * character.h (sanitize_tab_width): Renamed from sanitize_width,
961 now that we have two such functions. All uses changed.
962 (sanitize_char_width): New inline function.
964 Don't assume that tab-width fits in int.
965 * character.h (sanitize_width): New inline function.
966 (SANE_TAB_WIDTH): New macro.
967 (ASCII_CHAR_WIDTH): Use it.
968 * indent.c (sane_tab_width): Remove. All uses replaced by
969 SANE_TAB_WIDTH (current_buffer).
970 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
972 * fileio.c: Integer overflow issues with file modes.
973 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
975 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
976 Remove unreachable code.
977 (read_hex, load_charset_map_from_file): Check for integer overflow.
979 * xterm.c: don't go over XClientMessageEvent limit
980 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
981 (x_send_scroll_bar_event): Likewise. Check that the size does not
982 exceed limits imposed by XClientMessageEvent, as well as the usual
983 ptrdiff_t and size_t limits.
985 * keyboard.c: Overflow, signedness and related fixes.
986 (make_lispy_movement): Use same integer type in forward decl
987 that is used in the definition.
988 (read_key_sequence, keyremap_step):
989 Change bufsize argument back to int, undoing my 2011-03-30 change.
990 We prefer signed types, and int is wide enough here.
991 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
992 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
993 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
994 length, not size_t. Use ptrdiff_t for index, not int.
995 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
996 possibility of integer overflow.
998 Overflow, signedness and related fixes for images.
1000 * dispextern.h (struct it.stack[0].u.image.image_id)
1001 (struct_it.image_id, struct image.id, struct image_cache.size)
1002 (struct image_cache.used, struct image_cache.ref_count):
1003 * gtkutil.c (update_frame_tool_bar):
1004 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1005 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1006 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1007 * nsmenu.m (update_frame_tool_bar):
1008 * xdisp.c (calc_pixel_width_or_height):
1009 * xfns.c (image_cache_refcount):
1010 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1011 on typical 64-bit hosts.
1013 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1014 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1015 Omit unnecessary casts to int.
1016 (parse_image_spec): Check that integers fall into 'int' range
1017 when the callers expect that.
1018 (image_ascent): Redo ascent calculation to avoid int overflow.
1019 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1020 (lookup_image): Remove unnecessary tests.
1021 (xbm_image_p): Locals are now of int, not EMACS_INT,
1022 since parse_image_check makes sure they fit into int.
1023 (png_load, gif_load, svg_load_image):
1024 Prefer int to unsigned where either will do.
1025 (tiff_handler): New function, combining the cores of the
1026 old tiff_error_handler and tiff_warning_handler. This
1027 function is rewritten to use vsnprintf and thereby avoid
1028 stack buffer overflows. It uses only the features of vsnprintf
1029 that are common to both POSIX and native Microsoft.
1030 (tiff_error_handler, tiff_warning_handler): Use it.
1031 (tiff_load, gif_load, imagemagick_load_image):
1032 Don't assume :index value fits in 'int'.
1033 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1034 (imagemagick_load_image): Check that crop parameters fit into
1035 the integer types that MagickCropImage accepts. Don't assume
1036 Vimagemagick_render_type has a nonnegative value. Don't assume
1037 size_t fits in 'long'.
1038 (gs_load): Use printmax_t to print the widest integers possible.
1039 Check for integer overflow when computing image height and width.
1041 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1043 * xdisp.c (redisplay_window): Don't force window start if point
1044 will be invisible in the resulting window. (Bug#9324)
1046 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1048 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1049 the display spec is of the form `(space ...)'.
1050 (handle_display_spec): Return the value returned by
1051 handle_single_display_spec, not just 1 or zero.
1052 (handle_single_display_spec): If the display spec is of the form
1053 `(space ...)', and specifies display in the text area, return 2
1055 (try_cursor_movement): Check for the need to scroll more
1056 accurately, and prefer exact match for point under bidi. Don't
1057 advance `row' beyond the last row of the window.
1059 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1060 into disp_prop; all users changed.
1062 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1063 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1064 for the text covered by the display property.
1066 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1068 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1069 Change return value to nil.
1070 (Frecord_buffer): Delete unused function.
1072 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1074 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1075 buffers, return left-to-right.
1076 (set_cursor_from_row): Consider candidate row a win if its glyph
1077 represents a newline and point is on that newline. Fixes cursor
1078 positioning on the newline at EOL of R2L text within L2R
1079 paragraph, and vice versa.
1080 (try_cursor_movement): Check continued rows, in addition to
1081 continuation rows. Fixes unwarranted scroll when point enters a
1082 continued line of R2L text within an L2R paragraph, or vice versa.
1083 (cursor_row_p): Consider the case of point being equal to
1084 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1085 from the end of a short line to the beginning of a continued line
1086 of R2L text within L2R paragraph.
1087 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1088 composed characters.
1090 * bidi.c (bidi_check_type): Use xassert.
1091 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1094 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1096 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1099 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1101 * nsfont.m (ns_otf_to_script): Fix typo.
1103 2011-08-22 Kenichi Handa <handa@m17n.org>
1105 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1106 extra slot even if the purpose is char-code-property-table.
1108 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1110 * xdisp.c (redisplay_window): When computing centering_position,
1111 account for the height of the header line. (Bug#8874)
1113 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1114 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1115 candidate is selected by the mouse, and that candidate has a
1116 composed character under the mouse.
1118 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1119 coordinates reported by pos-visible-in-window-p for a composed
1120 character in column zero.
1122 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1124 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1126 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1128 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1129 consider it a hit if to_charpos is anywhere in the range of the
1130 composed buffer positions.
1132 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1134 * image.c (gif_load): Don't assume that each subimage has the same
1135 dimensions as the base image. Handle disposal method that is
1136 "undefined" by the gif spec (Bug#9335).
1138 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1140 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1141 (Fcondition_case): Document `debug' symbol in error handler.
1143 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1145 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1146 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1147 from an Org mode buffer to a Speedbar frame.
1149 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1150 a composition, take its buffer position from IT->cmp_it.charpos.
1151 Fixes cursor positioning at the beginning of a line that begins
1152 with a composed character.
1154 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1156 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1157 character bidirectional type, use STRONG_L instead. Fixes crashes
1158 in a buffer produced by `describe-categories'.
1160 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1161 members before the level stack, so they would be saved and
1162 restored when copying iterator state. Fixes incorrect reordering
1163 around TABs covered by display properties.
1165 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1167 * process.c (Fnetwork_interface_list): Correctly determine buffer
1170 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1172 * eval.c (internal_condition_case, internal_condition_case_1)
1173 (internal_condition_case_2, internal_condition_case_n):
1174 Remove unnecessary aborts (Bug#9081).
1176 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1178 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1179 has no `load' handler, try opening the file locally. (Bug#9311)
1181 2011-08-16 Ken Brown <kbrown@cornell.edu>
1183 * gmalloc.c: Expand comment.
1185 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1187 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1188 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1190 2011-08-16 Ken Brown <kbrown@cornell.edu>
1192 Fix memory allocation problems in Cygwin build (Bug#9273).
1194 * unexcw.c ( __malloc_initialized): Declare external variable.
1195 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1197 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1199 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1201 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1203 [CYGWIN] (special_realloc): New function.
1204 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1205 requests to realloc storage in the static heap.
1207 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1209 * bidi.c (bidi_initialize): Remove unused local.
1211 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1213 * biditype.h: File removed.
1215 * bidimirror.h: File removed.
1217 * deps.mk (bidi.o): Remove biditype.h and
1220 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1223 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1225 * chartab.c: Improve commentary for the uniprop_table API.
1227 * bidi.c (bidi_paragraph_init): Support zero value of
1228 bidi_ignore_explicit_marks_for_paragraph_level.
1229 (bidi_initialize): Use uniprop_table instead of including
1230 biditype.h and bidimirror.h.
1232 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1233 coordinates of the iterator when restoring from ppos_it.
1236 2011-08-14 Kenichi Handa <handa@m17n.org>
1238 * process.c (create_process): Call setup_process_coding_systems
1239 after the pid of the process is set to -1 (Bug#8162).
1241 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1243 * xdisp.c (move_it_in_display_line_to): Don't invoke
1244 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1245 ppos_it. Fixes vertical cursor motion when line beginning is
1246 covered by an image. (Bug#9296)
1248 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1250 * nsterm.h (ns_run_ascript): Declare.
1251 (NSAPP_DATA2_RUNASSCRIPT): Define.
1253 * nsfns.m (as_script, as_result, as_status): New static variables.
1254 (ns_run_ascript): New function.
1255 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1256 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1257 the event loop. Get status from as_status (Bug#7276).
1259 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1260 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1261 the event loop (Bug#7276).
1263 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1265 * gnutls.c (QCgnutls_bootprop_priority)
1266 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1267 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1268 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1269 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1270 (QCgnutls_bootprop_verify_hostname_error)
1271 (QCgnutls_bootprop_callbacks_verify): Rename from
1272 Qgnutls_bootprop_..., all uses changed.
1274 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1277 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1279 * xfaces.c (Qframe_set_background_mode): Now static.
1280 * dispextern.h (Qframe_set_background_mode): Remove decl.
1282 * process.c (Fnetwork_interface_info): Declare local only if needed.
1284 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1286 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1287 (Fnetwork_interface_list): Allocate in increments of bytes instead
1288 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1289 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1291 (struct ifflag_def): notrailers is smart on OSX.
1292 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1293 Get hardware address with getifaddrs if available.
1295 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1297 * xdisp.c (iterate_out_of_display_property): xassert that
1298 IT->position is set to within IT->object's boundaries. Break from
1299 the loop as soon as EOB is reached; avoids infloops in redisplay
1300 when IT->position is set up wrongly due to some bug.
1301 Set IT->current to match the bidi iterator unconditionally.
1302 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1303 entry. Force push_it to save on the stack the current
1304 buffer/string position, to be restored by pop_it. Fix flags in
1305 the iterator structure wrt the object coming from a display
1306 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1307 properties. (Bug#9284)
1309 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1311 * fontset.c (fontset_get_font_group): Add proper type checks.
1314 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1316 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1317 and LC_VERSION_MIN_MACOSX.
1318 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1319 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1321 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1323 * xdisp.c (forward_to_next_line_start): Allow to use the
1324 no-display-properties-and-no-overlays under bidi display.
1325 Set disp_pos in the bidi iterator to avoid searches for display
1326 properties and overlays.
1328 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1330 * editfns.c (Fset_time_zone_rule): Document relationship with the
1333 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1334 the font entity extracted from the cache (Bug#8109).
1336 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1338 * composite.c (autocmp_chars): Don't reset point. That is done by
1339 restore_point_unwind (Bug#5984).
1341 2011-08-07 Juri Linkov <juri@jurta.org>
1343 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1344 to show the arg `TIME' instead of `TIMEVAL'.
1346 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1348 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1349 display property strides EOL and includes a newline, as in
1350 longlines-mode. (Bug#9254)
1351 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1352 word-wrap under bidirectional display. (Bug#9224)
1354 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1355 is non-zero, even if the data buffer is NULL. Fixes a crash in
1356 vertical-motion with longlines-mode. (Bug#9254)
1358 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1360 * bidi.c <bidi_cache_total_alloc>: Now static.
1361 (bidi_initialize): Initialize bidi_cache_total_alloc.
1363 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1366 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1367 amount allocated this far in `bidi_cache_total_alloc'.
1368 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1369 non-zero, only free the data buffer without restoring the cache
1370 contents. All callers changed.
1372 * dispextern.h (bidi_unshelve_cache): Update prototype.
1374 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1375 (move_it_in_display_line, move_it_to)
1376 (move_it_vertically_backward, move_it_by_lines): Replace the call
1377 to xfree to an equivalent call to bidi_unshelve_cache.
1378 (move_it_in_display_line_to): Fix logic of returning
1379 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1381 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1383 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1384 came from a string character with a `cursor' property. (Bug#9229)
1386 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1388 * Makefile.in (LIB_PTHREAD): New variable.
1389 (LIBES): Add LIB_PTHREAD (Bug#9216).
1391 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1392 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1394 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1396 * regex.c (re_iswctype): Remove some redundant boolean
1399 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1401 * xterm.c (x_find_topmost_parent): New function.
1402 (x_set_frame_alpha): Find topmost parent window with
1403 x_find_topmost_parent and set the property there also (bug#9181).
1404 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1406 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1408 * callproc.c (Fcall_process): Avoid vfork clobbering
1409 the local vars buffer, coding_systems, current_dir.
1411 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1413 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1415 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1417 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1418 so that it is not optimized away.
1420 * xdisp.c (compute_display_string_pos): Remove unused local.
1422 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1424 Fix slow cursor motion and scrolling in large buffers with
1425 selective display, like Org Mode buffers. (Bug#9218)
1427 * dispextern.h (struct bidi_it): New member disp_prop_p.
1429 * xdisp.c: Remove one-slot cache of display string positions.
1430 (compute_display_string_pos): Accept an additional argument
1431 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1432 for a display string or property. If found, set DISP_PROP_P
1435 * bidi.c (bidi_fetch_char): Accept an additional argument
1436 DISP_PROP_P, and pass it to compute_display_string_pos.
1437 Only handle text covered by a display string if DISP_PROP_P is returned
1438 non-zero. All callers of bidi_fetch_char changed.
1440 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1442 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1444 2010-12-03 Don March <don@ohspite.net>
1446 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1447 last character M-[char] is translated to ESC [char] (bug#7541).
1449 2011-08-02 Kenichi Handa <handa@m17n.org>
1451 * lisp.h (uniprop_table): Extern it.
1453 * chartab.c (uniprop_table): Make it non-static.
1455 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1457 * xdisp.c (forward_to_next_line_start): Accept additional argument
1458 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1460 (reseat_at_next_visible_line_start): Use the bidi iterator state
1461 returned by forward_to_next_line_start to restore the state of
1462 it->bidi_it after backing up to previous newline. (Bug#9212)
1464 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1466 * regex.c (re_comp): Protoize.
1467 (re_exec): Fix return type.
1468 (regexec): Fix type of `ret'. (Bug#9203)
1470 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1472 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1473 This is needed if max-image-size is a floating-point number.
1475 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1477 * print.c (print_object): Print empty symbol as ##.
1479 * lread.c (read1): Read ## as empty symbol.
1481 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1483 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1484 setting frame foreground color (Bug#9175).
1485 (x_set_background_color): Likewise.
1487 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1488 contents (Bug#9176).
1489 (EmacsTooltip -init): Remove bezels and add shadows to
1492 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1493 or scroll bar (Bug#8470).
1495 * nsfont.m (nsfont_open): Remove assignment to voffset and
1496 unnecessary vars hshink, expand, hd, full_height, min_height.
1497 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1499 * nsterm.h (nsfont_info): Remove voffset field.
1501 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1503 Implement strike-through and overline on NextStep (Bug#8863).
1505 * nsfont.m (nsfont_open): Use underline position provided by font,
1506 instead of hard-coded value of 2.
1507 (nsfont_draw): Call ns_draw_text_decoration instead.
1509 * nsterm.h: Add declaration for ns_draw_text_decoration.
1511 * nsterm.m (ns_draw_text_decoration): New function for drawing
1512 underline, overline, and strike-through.
1513 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1514 ns_draw_text_decoration. Change treatment of cursor drawing to
1515 accommodate underlining, etc.
1517 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1519 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1522 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1524 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1525 Without this fix, if a signal arrives just after memory fills up,
1526 'malloc' might be invoked reentrantly.
1528 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1529 In other words, assume that every image size is allowed, on non-X
1530 hosts. This assumption is probably wrong, but it lets Emacs compile.
1532 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1534 * regex.c (re_iswctype): Convert return values to boolean.
1536 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1538 * xdisp.c (compute_display_string_pos): Don't use cached display
1539 string position if the buffer had its restriction changed.
1542 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1544 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1546 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1548 Integer signedness and overflow and related fixes. (Bug#9079)
1550 * bidi.c: Integer size and overflow fixes.
1551 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1552 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1553 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1554 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1555 (bidi_find_other_level_edge):
1556 Use ptrdiff_t instead of EMACS_INT where either will do.
1557 This works better on 32-bit hosts configured --with-wide-int.
1558 (bidi_cache_ensure_space): Check for size-calculation overflow.
1559 Use % rather than repeated addition, for better worst-case speed.
1560 Don't set bidi_cache_size until after xrealloc returns, because it
1562 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1563 (bidi_cache_ensure_space): Also check that the bidi cache size
1564 does not exceed that of the largest Lisp string or buffer. See Eli
1565 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1567 * alloc.c (__malloc_size_t): Remove.
1568 All uses replaced by size_t. See Andreas Schwab's note
1569 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1571 * image.c: Improve checking for integer overflow.
1572 (check_image_size): Assume that f is nonnull, since
1573 it is always nonnull in practice. This is one less thing to
1574 worry about when checking for integer overflow later.
1575 (x_check_image_size): New function, which checks for integer
1576 overflow issues inside X.
1577 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1578 This removes the need for a memory_full check.
1579 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1580 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1581 (xbm_read_bitmap_data): Change locals back to 'int', since
1582 their values must fit in 'int'.
1583 (xpm_load_image, png_load, tiff_load):
1584 Invoke x_create_x_image_and_pixmap earlier,
1585 to avoid much needless work if the image is too large.
1586 (tiff_load): Treat overly large images as if
1587 x_create_x_image_and_pixmap failed, not as malloc failures.
1588 (gs_load): Use x_check_image_size.
1590 * gtkutil.c: Omit integer casts.
1591 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1592 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1594 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1596 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1597 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1598 would wrongly return t on a 64-bit host.
1600 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1601 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1602 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1603 and therefore cause GCC to emit a bogus diagnostic in some cases.
1605 * image.c: Integer signedness and overflow and related fixes.
1606 This is not an exhaustive set of fixes, but it's time to
1607 record what I've got.
1608 (lookup_pixel_color, check_image_size): Remove redundant decls.
1609 (check_image_size): Don't assume that arbitrary EMACS_INT values
1610 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1611 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1612 (tiff_load, imagemagick_load_image):
1613 Check for overflow in size calculations.
1614 (x_create_x_image_and_pixmap): Remove unnecessary test for
1615 xmalloc returning NULL; that can't happen.
1616 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1617 (xpm_color_bucket): Use better integer hashing function.
1618 (xpm_cache_color): Don't possibly over-allocate memory.
1619 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1620 (gif_memory_source):
1621 Use ptrdiff_t, not int or size_t, to record sizes.
1622 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1623 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1624 either works, as we prefer signed integers.
1625 (tiff_read_from_memory, tiff_write_from_memory):
1626 Return tsize_t, not size_t, since that's what the TIFF API wants.
1627 (tiff_read_from_memory): Don't fail simply because the read would
1628 go past EOF; instead, return a short read.
1629 (tiff_load): Omit no-longer-needed casts.
1630 (Fimagemagick_types): Don't assume size fits into 'int'.
1632 Improve hashing quality when configured --with-wide-int.
1633 * fns.c (hash_string): New function, taken from sxhash_string.
1634 Do not discard information about ASCII character case; this
1635 discarding is no longer needed.
1636 (sxhash-string): Use it. Change sig to match it. Caller changed.
1637 * lisp.h: Declare it.
1638 * lread.c (hash_string): Remove, since we now use fns.c's version.
1639 The fns.c version returns a wider integer if --with-wide-int is
1640 specified, so this should help the quality of the hashing a bit.
1642 * emacs.c: Integer overflow minor fix.
1643 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1644 Define only if GNU_LINUX.
1645 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1647 * dispnew.c: Integer signedness and overflow fixes.
1648 Remove unnecessary forward decls, that were a maintenance hassle.
1649 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1651 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1652 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1653 (prepare_desired_row, line_draw_cost):
1654 Use int, not unsigned, where either works.
1655 (save_current_matrix, restore_current_matrix):
1656 Use ptrdiff_t, not size_t, where either works.
1657 (init_display): Check for overflow more accurately, and without
1658 relying on undefined behavior.
1660 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1661 Remove, replacing with the new symbols in lisp.h. All uses changed.
1662 * fileio.c (make_temp_name):
1663 * filelock.c (lock_file_1, lock_file):
1664 * xdisp.c (message_dolog):
1665 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1666 Use pMd etc. instead.
1667 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1668 replacing the pWIDE etc. symbols removed from editfns.c.
1670 * keyboard.h (num_input_events): Now uintmax_t.
1671 This is (very slightly) less likely to mess up due to wraparound.
1674 * buffer.c: Integer signedness fixes.
1675 (alloc_buffer_text, enlarge_buffer_text):
1676 Use ptrdiff_t rather than size_t when either will do, as we prefer
1679 * alloc.c: Integer signedness and overflow fixes.
1680 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1681 (__malloc_size_t): Default to size_t, not to int.
1682 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1683 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1684 Prefer ptrdiff_t to size_t when either would do, as we prefer
1686 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1687 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1688 Now const. Initialize with values that are in range even if char
1690 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1691 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1692 These functions do the right thing with sizes > 2**32.
1693 (check_depth): Now ptrdiff_t, not int.
1694 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1695 Adjust to new way of storing sizes. Check for size overflow bugs
1697 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1698 slightly wrong anyway, as it missed one instance of
1699 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1700 (refill_memory_reserve): Omit needless cast to size_t.
1701 (mark_object_loop_halt): Mark as externally visible.
1703 * xselect.c: Integer signedness and overflow fixes.
1704 (Fx_register_dnd_atom, x_handle_dnd_message):
1705 Use ptrdiff_t, not size_t, since we prefer signed.
1706 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1707 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1708 x_dnd_atoms_size and x_dnd_atoms_length.
1710 * doprnt.c: Prefer signed to unsigned when either works.
1712 * doprnt.c (doprnt):
1714 * xdisp.c (vmessage):
1715 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1716 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1717 prefer signed arithmetic to avoid comparison confusion.
1718 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1719 but is a bit tricky.
1721 Assume freestanding C89 headers, string.h, stdlib.h.
1722 * data.c, doprnt.c, floatfns.c, print.c:
1723 Include float.h unconditionally.
1724 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1725 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1726 * regex.c: Likewise for stddef.h, string.h.
1727 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1728 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1729 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1730 (STDC_HEADERS): Remove obsolete defines.
1731 * sysdep.c: Include limits.h unconditionally.
1733 Assume support for memcmp, memcpy, memmove, memset.
1734 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1735 * regex.c (memcmp, memcpy):
1736 Remove; we assume C89 now.
1738 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1739 (__malloc_safe_bcopy): Remove; no longer needed.
1741 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1742 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1743 well either way, and we prefer signed to unsigned.
1745 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1747 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1748 closes the connection while we're reading (bug#9182).
1750 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1752 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1753 are specified (Bug#9168).
1755 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1757 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1758 Found by GCC static checking and --with-wide-int on a 32-bit host.
1760 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1762 * xdisp.c (compute_display_string_pos): Fix logic of caching
1763 previous display string position. Initialize cached_prev_pos to
1764 -1. Fixes slow-down at the beginning of a buffer.
1766 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1768 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1769 for attrs[LFACE_FONTSET_INDEX].
1771 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1773 * xml.c (parse_region): Remove unused local
1774 that was recently introduced.
1776 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1778 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1779 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1781 * xdisp.c (move_it_in_display_line_to): Record the best matching
1782 position for TO_CHARPOS while scanning the line, and restore it on
1783 exit if none of the characters scanned was an exact match.
1784 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1785 when exact match is impossible due to invisible text, and the
1786 lines are truncated.
1788 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1790 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1793 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1795 Fix a significant slow-down of cursor motion with C-n, C-p,
1796 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1797 auto-repeat under bidi redisplay in fontified buffers.
1798 * xdisp.c (compute_stop_pos_backwards): New function.
1799 (next_element_from_buffer): Call compute_stop_pos_backwards to
1800 find a suitable prev_stop when we find ourselves before
1802 (reseat): Don't look for prev_stop, as that could mean a very long
1804 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1805 <cached_disp_overlay_modiff>: Cache for last found display string
1807 (compute_display_string_pos): Return the cached position if asked
1808 about the same buffer in the same area of character positions, and
1809 the buffer wasn't changed since the time the display string
1810 position was cached.
1812 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1814 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1815 is an integer, which is important for empty lines. (Bug#9149)
1817 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1819 * frame.c (Fmodify_frame_parameters): In tty case, update the
1820 default face if necessary (Bug#4238).
1822 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1824 * editfns.c (Fstring_to_char): No need to explain what a character
1825 is in the docstring (Bug#6576).
1827 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1829 * xml.c (parse_region): Make sure we always return a tree.
1831 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1833 * xml.c (parse_region): If a document contains only comments,
1836 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1838 * xml.c (make_dom): Return comments, too.
1840 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1843 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1844 and the surrounding thread.
1845 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1846 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1847 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1849 * s/openbsd.h (BROKEN_SIGIO): Define.
1850 * unexelf.c (unexec) [__OpenBSD__]:
1851 Don't update the .mdebug section of the Alpha COFF symbol table.
1853 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1855 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1858 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1860 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1861 This fixes some race conditions on the permissions of any newly
1864 * alloc.c (valid_pointer_p): Use pipe, not open.
1865 This fixes some permissions issues when debugging.
1867 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1868 If fchown fails to set both uid and gid, try to set just gid,
1869 as that is sometimes allowed. Adjust the file's mode to eliminate
1870 setuid or setgid bits that are inappropriate if fchown fails.
1872 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1874 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1875 to compare Lisp_Objects.
1876 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1877 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1878 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1880 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1882 * lread.c (read_integer): Unread even EOF character.
1883 (read1): Likewise. Properly record start position of symbol.
1885 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1886 symbol character follows.
1888 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1890 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1891 This works around a problem with the previous change to Fcopy_file.
1892 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1893 and without this change, GCC might complain about discarding
1894 fchown's return value.
1896 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1898 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1900 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1902 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1904 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1906 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1907 it's used from the C level.
1909 * process.c: Use the same condition for POLL_FOR_INPUT in both
1910 keyboard.c and process.c (bug#1858).
1912 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1914 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1915 (Fgnutls_boot): Use it.
1917 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1919 * doc.c (Fsubstitute_command_keys): Revert last change.
1921 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1923 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1924 quotes the next character, and doesn't affect other longer
1925 sequences (bug#8935).
1927 * lread.c (syms_of_lread): Clarify that is isn't only
1928 `eval-buffer' and `eval-defun' that's affected by
1929 `lexical-binding' (bug#8460).
1931 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1933 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1934 bidi redisplay when a line includes both an image and is
1937 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1939 Fix minor problems found by static checking.
1940 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1941 (elsz): Now a signed constant, not a size_t var. We prefer signed
1942 types to unsigned, to avoid integer comparison confusion. Without
1943 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1944 "cannot optimize loop, the loop counter may overflow", a symptom
1946 * indent.c (Fvertical_motion): Mark locals as initialized.
1947 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1949 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1951 * search.c (Fre_search_backward): Mention `case-fold-search' in
1952 all the re_search_* functions (bug#8138).
1954 * keyboard.c (Fopen_dribble_file): Document when the file is
1957 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1959 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1962 Support bidi reordering of display and overlay strings.
1963 * xdisp.c (compute_display_string_pos)
1964 (compute_display_string_end): Accept additional argument STRING.
1965 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1966 (reseat_to_string): Initialize bidi_it->string.s and
1967 bidi_it->string.schars.
1968 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1969 NULL (avoids a crash in bidi_paragraph_init).
1970 Initialize itb.string.lstring.
1971 (init_iterator): Call bidi_init_it only of a valid
1972 buffer position was specified. Initialize paragraph_embedding to
1974 (reseat_to_string): Initialize the bidi iterator.
1975 (display_string): If we need to ignore text properties of
1976 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1977 original value of -1 will not work with bidi.)
1978 (compute_display_string_pos): First arg is now struct
1979 `text_pos *'; all callers changed. Support display properties on
1981 (compute_display_string_end): Support display properties on Lisp
1983 (init_iterator, reseat_1, reseat_to_string): Initialize the
1984 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1985 when iterating on a string not from display properties).
1986 (compute_display_string_pos, compute_display_string_end):
1987 Fix calculation of the object to scan. Fixes an error when using
1989 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1990 base_level_stop; instead, set base_level_stop to BEGV.
1991 Fixes crashes in vertical-motion.
1992 (next_element_from_buffer): Improve commentary for when
1993 the iterator is before prev_stop.
1994 (init_iterator): Initialize bidi_p from the default value of
1995 bidi-display-reordering, not from buffer-local value. Use the
1996 buffer-local value only if initializing for buffer iteration.
1997 (handle_invisible_prop): Support invisible properties on strings
1998 that are being bidi-reordered.
1999 (set_iterator_to_next): Support bidi reordering of C strings and
2001 (next_element_from_string): Support bidi reordering of Lisp
2003 (handle_stop_backwards): Support Lisp strings as well.
2004 (display_string): Support display of R2L glyph rows.
2005 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2006 (init_iterator): Don't initialize it->bidi_p for strings
2008 (reseat_to_string): Initialize it->bidi_p for strings here.
2009 (next_element_from_string, next_element_from_c_string)
2010 (next_element_from_buffer): Add xassert's for correspondence
2011 between IT's object being iterated and it->bidi_it.string
2013 (face_before_or_after_it_pos): Support bidi iteration.
2014 (next_element_from_c_string): Handle the case of the first string
2015 character that is not the first one in the visual order.
2016 (get_visually_first_element): New function, refactored from common
2017 parts of next_element_from_buffer, next_element_from_string, and
2018 next_element_from_c_string.
2019 (tool_bar_lines_needed, redisplay_tool_bar)
2020 (display_menu_bar): Force left-to-right direction. Add a FIXME
2021 comment for making that be controlled by a user option.
2022 (push_it, pop_it): Save and restore the state of the
2023 bidi iterator. Save and restore the bidi_p flag.
2024 (pop_it): Iterate out of display property for string iteration as
2026 (iterate_out_of_display_property): Support iteration over strings.
2027 (handle_single_display_spec): Set up it->bidi_it for iteration
2028 over a display string, and call bidi_init_it.
2029 (handle_single_display_spec, next_overlay_string)
2030 (get_overlay_strings_1, push_display_prop): Set up the bidi
2031 iterator for displaying display or overlay strings.
2032 (forward_to_next_line_start): Don't use the shortcut if
2034 (back_to_previous_visible_line_start): If handle_display_prop
2035 pushed the iterator stack, restore the internal state of the bidi
2036 iterator by calling bidi_pop_it same number of times.
2037 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2038 and we are bidi-iterating, don't decrement the iterator position;
2039 instead, set the first_elt flag in the bidi iterator, to produce
2041 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2042 (push_display_prop): xassert that we are iterating a buffer.
2043 (push_it, pop_it): Save and restore paragraph_embedding member.
2044 (handle_single_display_spec, next_overlay_string)
2045 (get_overlay_strings_1, reseat_1, reseat_to_string)
2046 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2047 correctly. Don't assume unibyte strings are not bidi-reordered.
2048 (compute_display_string_pos)
2049 (compute_display_string_end): Fix handling the case of C string.
2050 (push_it, pop_it): Save and restore from_disp_prop_p.
2051 (handle_single_display_spec, push_display_prop): Set the
2052 from_disp_prop_p flag.
2053 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2054 (pop_it): Call iterate_out_of_display_property only if we are
2055 popping after iteration over a string that came from a display
2056 property. Fix a typo in popping stretch info. Add an assertion
2057 for verifying that the iterator position is in sync with the bidi
2059 (handle_single_display_spec, get_overlay_strings_1)
2060 (push_display_prop): Fix initialization of paragraph direction for
2061 string when that of the parent object is not yet determined.
2062 (reseat_1): Call bidi_init_it to resync the bidi
2063 iterator with IT's position. (Bug#7616)
2064 (find_row_edges): If ROW->start.pos gives position
2065 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2066 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2067 Reset the from_disp_prop_p flag.
2068 (SAVE_IT, RESTORE_IT): New macros.
2069 (pos_visible_p, face_before_or_after_it_pos)
2070 (back_to_previous_visible_line_start)
2071 (move_it_in_display_line_to, move_it_in_display_line)
2072 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2073 (try_scrolling, redisplay_window, display_line): Use them when
2074 saving a temporary copy of the iterator and restoring it back.
2075 (back_to_previous_visible_line_start, reseat_1)
2076 (init_iterator): Empty the bidi cache "stack".
2077 (move_it_in_display_line_to): If iterator ended up at
2078 EOL, but we never saw any buffer positions smaller than
2079 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2080 motion in bidi-reordered lines.
2081 (move_it_in_display_line_to): Record prev_method and prev_pos
2082 immediately before the call to set_iterator_to_next. Fixes cursor
2083 motion in bidi-reordered lines with stretch glyphs and strings
2084 displayed in margins. (Bug#8133) (Bug#8867)
2085 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2087 (pos_visible_p): Support positions in bidi-reordered lines.
2088 Save and restore bidi cache.
2090 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2091 (bidi_paragraph_info): Delete unused struct.
2092 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2093 (bidi_cache_start): New variable.
2094 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2096 (bidi_cache_fetch_state, bidi_cache_search)
2097 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2098 (bidi_cache_find, bidi_peek_at_next_level)
2099 (bidi_level_of_next_char, bidi_find_other_level_edge)
2100 (bidi_move_to_visually_next): Compare cache index with
2101 bidi_cache_start rather than with zero.
2102 (bidi_fetch_char): Accept new argument STRING; all callers
2103 changed. Support iteration over a string. Support strings with
2104 display properties. Support unibyte strings. Fix the type of
2105 `len' according to what STRING_CHAR_AND_LENGTH expects.
2106 (bidi_paragraph_init, bidi_resolve_explicit_1)
2107 (bidi_resolve_explicit, bidi_resolve_weak)
2108 (bidi_level_of_next_char, bidi_move_to_visually_next):
2109 Support iteration over a string.
2110 (bidi_set_sor_type, bidi_resolve_explicit_1)
2111 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2112 can now be zero (for strings); special values 0 and -1 were
2113 changed to -1 and -2, respectively.
2114 (bidi_char_at_pos): New function.
2115 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2116 Call it instead of FETCH_MULTIBYTE_CHAR.
2117 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2118 initialized to valid values.
2119 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2121 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2122 the test for valid cached positions. Fix the logic for looking up
2123 the sentinel state in the cache. GCPRO the Lisp string we are
2125 (bidi_push_it, bidi_pop_it): New functions.
2126 (bidi_initialize): Initialize the bidi cache start stack pointer.
2127 (bidi_cache_ensure_space): New function, refactored from part of
2128 bidi_cache_iterator_state. Don't assume the required size is just
2129 one BIDI_CACHE_CHUNK away.
2130 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2131 (bidi_count_bytes, bidi_char_at_pos): New functions.
2132 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2133 always valid if bidi_cache_idx is valid.
2134 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2135 is valid if it's going to be used.
2136 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2137 (bidi_cache_fetch_state, bidi_cache_search)
2138 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2139 (bidi_cache_iterator_state, bidi_cache_find)
2140 (bidi_find_other_level_edge, bidi_cache_start_stack):
2141 All variables related to cache indices are now EMACS_INT.
2143 * dispextern.h (struct bidi_string_data): New structure.
2144 (struct bidi_it): New member `string'. Make flag members be 1-bit
2145 fields, and put them last in the struct.
2146 (compute_display_string_pos, compute_display_string_end):
2148 (bidi_push_it, bidi_pop_it): Add prototypes.
2149 (struct iterator_stack_entry): New members bidi_p,
2150 paragraph_embedding, and from_disp_prop_p.
2151 (struct it): Member bidi_p is now a bit field 1 bit wide.
2152 (bidi_shelve_cache, bidi_unshelve_cache):
2155 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2156 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2157 and vector-like objects.
2159 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2160 cache around display iteration.
2162 * window.c (Fwindow_end, window_scroll_pixel_based)
2163 (displayed_window_lines, Frecenter): Save and restore the bidi
2164 cache around display iteration.
2166 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2168 * editfns.c (Fdelete_region): Clarify the use of the named
2169 parameters (bug#6788).
2171 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2173 * indent.c (Fvertical_motion): Set and restore w->pointm when
2174 saving and restoring the window's buffer (Bug#9006).
2176 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2178 * editfns.c (Fstring_to_char): Clarify just what is returned
2179 (bug#6576). Text by Eli Zaretskii.
2181 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2183 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2185 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2187 * buffer.c (mmap_find): Fix a typo.
2189 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2191 Fix execution of x selection hooks.
2192 * xselect.c (Qx_lost_selection_functions)
2193 (Qx_sent_selection_functions): New vars.
2194 (syms_of_xselect): DEFSYM them.
2195 (x_handle_selection_request): Pass Qx_sent_selection_functions
2196 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2197 (x_handle_selection_clear,x_clear_frame_selections):
2198 Pass Qx_lost_selection_functions rather than
2199 Vx_lost_selection_functions to Frun_hook_with_args.
2201 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2203 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2204 The old code sometimes used this field without initializing it.
2206 * alloc.c (gc_sweep): Don't read past end of array.
2207 In theory, the old code could also have corrupted Emacs internals,
2208 though it'd be very unlikely.
2210 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2212 * character.c (Fcharacterp): Don't advertise optional ignored
2213 argument. (Bug#4026)
2215 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2217 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2220 * window.c (Fset_window_start): Doc fix (bug#4199).
2221 (Fset_window_hscroll): Ditto.
2223 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2225 Fix minor new problems caught by GCC 4.6.1.
2226 * term.c (init_tty): Remove unused local.
2227 * xsettings.c (store_monospaced_changed): Define this function only
2228 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2231 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2233 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2235 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2237 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2238 are the mini-buffer and the echo area (bug#3320).
2240 * term.c (init_tty): Remove support for supdup, c10 and perq
2241 terminals, which are no longer supported (bug#1482).
2243 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2245 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2247 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2249 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2250 for non-popups (Bug#3642).
2252 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2254 * alloc.c (reset_malloc_hooks): Protoize.
2255 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2256 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2257 * cm.c (losecursor): Likewise.
2258 * data.c (fmod): Likewise.
2259 * dispnew.c (swap_glyphs_in_rows): Likewise.
2260 * emacs.c (memory_warning_signal): Likewise.
2261 * floatfns.c (float_error): Likewise.
2262 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2263 (otf_open, font_otf_capability, generate_otf_features)
2264 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2266 * image.c (pbm_read_file): Likewise.
2267 * indent.c (string_display_width): Likewise.
2268 * intervals.c (check_for_interval, search_for_interval)
2269 (inc_interval_count, count_intervals, root_interval)
2270 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2271 * lread.c (defalias): Likewise.
2272 * ralloc.c (r_alloc_check): Likewise.
2273 * regex.c (set_image_of_range_1, set_image_of_range)
2274 (regex_grow_registers): Likewise.
2275 * sysdep.c (strerror): Likewise.
2276 * termcap.c (valid_filename_p, tprint, main): Likewise.
2277 * tparam.c (main): Likewise.
2278 * unexhp9k800.c (run_time_remap, save_data_space)
2279 (update_file_ptrs, read_header, write_header, calculate_checksum)
2280 (copy_file, copy_rest, display_header): Likewise.
2281 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2283 * xdisp.c (check_it): Likewise.
2284 * xfaces.c (register_color, unregister_color, unregister_colors):
2286 * xfns.c (print_fontset_result): Likewise.
2287 * xrdb.c (member, fatal, main): Likewise.
2289 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2291 Fix minor problems found by static checking (Bug#9031).
2292 * chartab.c (char_table_set_range, map_sub_char_table):
2293 Remove unused locals.
2294 (uniprop_table): Now static.
2295 * composite.c (_work_char): Remove unused static var.
2297 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2299 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2301 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2303 * gtkutil.c (qttip_cb): Remove code without function.
2305 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2307 * w32.c (pthread_sigmask): New stub.
2309 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2311 Use pthread_sigmask, not sigprocmask (Bug#9010).
2312 sigprocmask is portable only for single-threaded applications, and
2313 Emacs can be multi-threaded when it uses GTK.
2314 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2316 * callproc.c (Fcall_process):
2317 * process.c (create_process):
2318 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2319 Use pthread_sigmask, not sigprocmask.
2321 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2323 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2324 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2327 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2329 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2330 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2331 (xg_hide_tooltip): Fix comment.
2333 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2334 in registerServicesMenuSendTypes.
2335 (validRequestorForSendType): Don't check ns_return_types.
2337 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2340 2011-07-08 Jason Rumney <jasonr@gnu.org>
2342 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2343 frame struct members of non-existent frames (Bug#6284).
2345 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2347 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2348 variable firstTime not needed on OSX >= 10.6.
2349 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2350 >= 10.5. Use setKnobProportion, setDoubleValue.
2352 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2353 (MAC_OS_X_VERSION_10_5): Define if not defined.
2354 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2355 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2356 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2358 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2359 cString and lossyCString on OSX >= 10.4
2361 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2362 sizeToFit on OSX >= 10.2.
2364 * nsimage.m (allocInitFromFile): Don't use deprecated method
2365 bestRepresentationForDevice on OSX >= 10.6.
2367 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2370 * emacs.c: Declare unexec_init_emacs_zone.
2372 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2374 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2376 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2377 on svcsMenu (Bug#8842).
2379 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2381 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2383 * nsterm.m (QUTF8_STRING): Declare.
2384 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2385 (validRequestorForSendType): Return type is (id).
2386 Change indexOfObjectIdenticalTo to indexOfObject.
2387 Check if we have local selection before returning self (Bug#8842).
2388 (writeSelectionToPasteboard): Put local selection into paste board
2389 if we have a local selection (Bug#8842).
2390 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2392 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2393 (ns_get_local_selection): Declare.
2395 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2397 * keymap.c (describe_map_tree): Don't insert a double newline at
2398 the end of the buffer (bug#1169) and return whether we inserted
2401 * callint.c (Fcall_interactively): Change "reading args" to
2402 "providing args" to try to clarify what it does (bug#1010).
2404 2011-07-07 Kenichi Handa <handa@m17n.org>
2406 * composite.c (composition_compute_stop_pos): Ignore a static
2407 composition starting before CHARPOS (Bug#8915).
2409 * xdisp.c (handle_composition_prop): Likewise.
2411 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2413 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2416 2011-07-07 Kenichi Handa <handa@m17n.org>
2418 * character.h (unicode_category_t): New enum type.
2420 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2421 (Qchar_code_property_table): New variable.
2422 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2423 (UNIPROP_COMPRESSED_FORM_P): New macros.
2424 (char_table_ascii): Uncompress the compressed values.
2425 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2426 Uncompress the compressed values.
2427 (sub_char_table_ref_and_range): Likewise.
2428 (char_table_ref_and_range): Uncompress the compressed values.
2429 (sub_char_table_set): New arg is_uniprop. Callers changed.
2430 Uncompress the compressed values.
2431 (sub_char_table_set_range): Args changed. Callers changed.
2432 (char_table_set_range): Adjuted for the above change.
2433 (map_sub_char_table): Delete args default_val and parent. Add arg
2434 top. Give decoded values to a Lisp function.
2435 (map_char_table): Adjust for the above change. Give decoded
2436 values to a Lisp function. Gcpro more variables.
2437 (uniprop_table_uncompress)
2438 (uniprop_decode_value_run_length): New functions.
2439 (uniprop_decoder, uniprop_decoder_count): New variables.
2440 (uniprop_get_decoder, uniprop_encode_value_character)
2441 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2443 (uniprop_encoder, uniprop_encoder_count): New variables.
2444 (uniprop_get_encoder, uniprop_table)
2445 (Funicode_property_table_internal, Fget_unicode_property_internal)
2446 (Fput_unicode_property_internal): New functions.
2447 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2448 Sunicode_property_table_internal, Sget_unicode_property_internal,
2449 and Sput_unicode_property_internal. Defvar_lisp
2450 char-code-property-alist.
2452 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2453 Vunicode_category_table.
2455 * font.c (font_range): Adjust for the change of
2456 Vunicode_category_table.
2458 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2460 * m/iris4d.h: Remove file, move contents ...
2461 * s/irix6-5.h: ... here.
2463 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2465 Remove unportable assumption about struct layout (Bug#8884).
2466 * alloc.c (mark_buffer):
2467 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2468 (clone_per_buffer_values): Don't assume that
2469 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2470 This isn't true in general, and it's particularly not true
2471 if Emacs is configured with --with-wide-int.
2472 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2473 New macros, used in the buffer.c change.
2475 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2477 * xsettings.c: Use both GConf and GSettings if both are available.
2478 (store_config_changed_event): Add comment.
2479 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2480 (store_tool_bar_style_changed): New functions.
2481 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2482 (struct xsettings): Move font inside HAVE_XFT.
2483 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2484 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2485 Move inside HAVE_XFT.
2486 (something_changed_gsettingsCB): Rename from something_changedCB.
2487 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2489 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2490 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2491 (something_changed_gconfCB): Rename from something_changedCB.
2492 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2493 (parse_settings): Move check for font inside HAVE_XFT.
2494 (read_settings, apply_xft_settings): Add comment.
2495 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2496 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2497 call store_font_name_changed.
2498 (xft_settings_event): Add comment.
2499 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2500 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2501 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2502 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2503 (xsettings_initialize): Call init_gsettings last.
2504 (xsettings_get_system_font, xsettings_get_system_normal_font):
2507 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2509 Random fixes. E.g., (random) never returned negative values.
2510 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2511 subseconds part to the entropy, as that's a bit more random.
2512 Prefer signed to unsigned, since the signedness doesn't matter and
2513 in general we prefer signed. When given a limit, use a
2514 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2515 latter isn't right if USE_2_TAGS_FOR_INTS.
2516 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2517 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2519 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2521 * textprop.c (text_property_stickiness):
2522 Obey Vtext_property_default_nonsticky.
2523 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2524 * w32fns.c (syms_of_w32fns):
2525 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2527 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2529 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2530 This is more efficient than Ffile_directory_p and avoids a minor race.
2532 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2534 * buffer.c (Foverlay_put): Say what the return value is
2537 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2538 is a directory before asking whether to use the file name
2540 (barf_or_query_if_file_exists): Make the "File is a directory"
2541 error be more correct.
2543 * fns.c (Frequire): Remove the mention of the .gz files, since
2544 that's installation-specific, but keep the mention of
2545 `get-load-suffixes'.
2547 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2549 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2550 Report string overflow if the output is too long.
2552 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2554 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2555 (syms_of_gnutls): Remove duplicate DEFSYM for
2556 Qgnutls_bootprop_verify_hostname_error, an error for
2557 Qgnutls_bootprop_verify_error (which is no longer used).
2559 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2560 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2561 Also (re)move comments that are misplaced or no longer relevant.
2563 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2565 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2567 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2569 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2570 and background color parameters if they have been changed.
2572 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2574 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2576 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2578 * xsettings.c (SYSTEM_FONT): Define only when used.
2579 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2581 * keymap.c (access_keymap_1): Now static.
2583 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2585 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2586 leave any prefix arg for the up event (Bug#1586).
2588 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2590 * lread.c (syms_of_lread): Mention single symbols defined by
2591 `defvar' or `defconst' (bug#7154).
2593 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2594 (Frequire): Mention get-load-suffixes.
2596 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2598 * window.h (window): Remove clone_number slot.
2599 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2601 (make_parent_window, make_window, saved_window)
2602 (Fset_window_configuration, save_window_save): Don't deal with
2604 * buffer.c (Qclone_number): Remove declaration.
2605 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2607 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2609 Add multiple inheritance to keymaps.
2610 * keymap.c (Fmake_composed_keymap): New function.
2611 (Fset_keymap_parent): Simplify.
2612 (fix_submap_inheritance): Remove.
2613 (access_keymap_1): New function extracted from access_keymap to handle
2614 embedded parents and handle lists of maps.
2615 (access_keymap): Use it.
2616 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2617 (Fcopy_keymap): Handle embedded parents.
2618 (Fcommand_remapping, define_as_prefix): Simplify.
2619 (Fkey_binding): Simplify.
2620 (syms_of_keymap): Move minibuffer-local-completion-map,
2621 minibuffer-local-filename-completion-map,
2622 minibuffer-local-must-match-map, and
2623 minibuffer-local-filename-must-match-map to Elisp.
2624 (syms_of_keymap): Defsubr make-composed-keymap.
2625 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2626 (parse_menu_item): Trivial simplification.
2628 2011-07-01 Glenn Morris <rgm@gnu.org>
2630 * Makefile.in (SETTINGS_LIBS): Fix typo.
2632 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2634 * coding.c (Fencode_coding_string): Record the last coding system
2635 used, as the function doc string says (bug#8738).
2637 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2639 * xsettings.c (store_monospaced_changed): Take new font as arg and
2640 check for change against current_mono_font.
2641 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2642 (emacs_settings_constructor, emacs_settings_get_property)
2643 (emacs_settings_set_property, emacs_settings_class_init)
2644 (emacs_settings_init, gsettings_obj): Remove.
2645 (something_changedCB): New function for HAVE_GSETTINGS.
2646 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2647 with value as argument.
2648 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2649 g_settings_new (Bug#8967). Do not create gsettings_obj.
2650 Remove calls to g_settings_bind. Connect something_changedCB to
2653 * xgselect.c: Add defined (HAVE_GSETTINGS).
2654 (xgselect_initialize): Ditto.
2656 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2657 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2660 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2662 * eval.c (struct backtrace): Simplify and port the data structure.
2663 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2664 signed bit field, as this assumption is not portable and it makes
2665 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2666 "char debug_on_exit : 1" as this is not portable either; instead,
2667 use the portable "unsigned int debug_on_exit : 1". Remove unused
2668 member evalargs. Remove obsolete comments about cc bombing out.
2670 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2672 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2673 Let HAVE_GSETTINGS override HAVE_GCONF.
2674 (store_monospaced_changed): New function.
2675 (EMACS_SETTINGS): A new type derived from GObject to handle
2676 GSettings notifications.
2677 (emacs_settings_constructor, emacs_settings_get_property)
2678 (emacs_settings_set_property, emacs_settings_class_init):
2680 (gsettings_client, gsettings_obj): New variables.
2681 (GSETTINGS_SCHEMA): New define.
2682 (something_changedCB): Call store_monospaced_changed.
2683 (init_gsettings): New function.
2684 (xsettings_initialize): Call init_gsettings.
2685 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2688 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2691 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2693 * window.c (resize_root_window, grow_mini_window)
2694 (shrink_mini_window): Rename Qresize_root_window to
2695 Qwindow_resize_root_window and Qresize_root_window_vertically to
2696 Qwindow_resize_root_window_vertically.
2698 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2700 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2702 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2704 * makefile.w32-in: Redesign dependencies so they reflect more
2705 clearly which files are directly included by each source file,
2706 and not through other includes.
2708 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2710 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2711 (sort_overlays, overlay_strings): When an overlay's clone number
2712 matches the window's clone number process the overlay even if
2713 the overlay's window property doesn't match the current window.
2715 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2716 (Fwindow_hchild): Rename to Fwindow_left_child.
2717 (Fwindow_next): Rename to Fwindow_next_sibling.
2718 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2719 (resize_window_check): Rename to window_resize_check.
2720 (resize_window_apply): Rename to window_resize_apply.
2721 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2722 (Fdelete_other_windows_internal, resize_frame_windows)
2723 (Fsplit_window_internal, Fdelete_window_internal)
2724 (grow_mini_window, shrink_mini_window)
2725 (Fresize_mini_window_internal): Fix callers accordingly.
2727 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2729 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2730 (emacs_fixed_set_min_size): Remove.
2731 (emacs_fixed_new): Take frame as argument.
2733 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2734 (_EmacsFixedPrivate): Remove minwidth/height.
2735 Add struct frame *f.
2736 (emacs_fixed_init): Initialize priv->f.
2737 (get_parent_class, emacs_fixed_set_min_size): Remove.
2738 (emacs_fixed_new): Set priv->f to argument.
2739 (emacs_fixed_get_preferred_width)
2740 (emacs_fixed_get_preferred_height): Use min_width/height from
2741 frames size_hint to set minimum and natural (Bug#8919).
2742 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2743 and use min_width/height from frames size_hint to set
2744 min_width/height (Bug#8919).
2746 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2747 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2750 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2752 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2753 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2756 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2758 * process.c (wait_reading_process_output): Bypass select if
2759 waiting for a cell while ignoring keyboard input, and input is
2760 pending. Suggested by Jan Djärv (Bug#8869).
2762 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2764 Use gnulib's dup2 module instead of rolling our own.
2765 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2767 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2769 * dispnew.c (scrolling_window): Before scrolling, turn off a
2770 mouse-highlight in the window being scrolled.
2772 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2774 Move DEFSYM to lisp.h and use everywhere.
2776 * character.h (DEFSYM): Move declaration...
2777 * lisp.h (DEFSYM): ...here.
2783 * w32select.c: Don't include character.h.
2785 * alloc.c (syms_of_alloc):
2786 * buffer.c (syms_of_buffer):
2787 * bytecode.c (syms_of_bytecode):
2788 * callint.c (syms_of_callint):
2789 * casefiddle.c (syms_of_casefiddle):
2790 * casetab.c (init_casetab_once):
2791 * category.c (init_category_once, syms_of_category):
2792 * ccl.c (syms_of_ccl):
2793 * cmds.c (syms_of_cmds):
2794 * composite.c (syms_of_composite):
2795 * dbusbind.c (syms_of_dbusbind):
2796 * dired.c (syms_of_dired):
2797 * dispnew.c (syms_of_display):
2798 * doc.c (syms_of_doc):
2799 * editfns.c (syms_of_editfns):
2800 * emacs.c (syms_of_emacs):
2801 * eval.c (syms_of_eval):
2802 * fileio.c (syms_of_fileio):
2803 * fns.c (syms_of_fns):
2804 * frame.c (syms_of_frame):
2805 * fringe.c (syms_of_fringe):
2806 * insdel.c (syms_of_insdel):
2807 * keymap.c (syms_of_keymap):
2808 * lread.c (init_obarray, syms_of_lread):
2809 * macros.c (syms_of_macros):
2810 * msdos.c (syms_of_msdos):
2811 * print.c (syms_of_print):
2812 * process.c (syms_of_process):
2813 * search.c (syms_of_search):
2814 * sound.c (syms_of_sound):
2815 * syntax.c (init_syntax_once, syms_of_syntax):
2816 * terminal.c (syms_of_terminal):
2817 * textprop.c (syms_of_textprop):
2818 * undo.c (syms_of_undo):
2819 * w32.c (globals_of_w32):
2820 * window.c (syms_of_window):
2821 * xdisp.c (syms_of_xdisp):
2822 * xfaces.c (syms_of_xfaces):
2823 * xfns.c (syms_of_xfns):
2824 * xmenu.c (syms_of_xmenu):
2825 * xsettings.c (syms_of_xsettings):
2826 * xterm.c (syms_of_xterm): Use DEFSYM.
2828 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2830 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2832 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2834 Integer and buffer overflow fixes (Bug#8873).
2836 * print.c (printchar, strout): Check for string overflow.
2837 (PRINTPREPARE, printchar, strout):
2838 Don't set size unless allocation succeeds.
2840 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2841 for sizes. Check for string overflow more accurately.
2842 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2844 * macros.c: Integer and buffer overflow fixes.
2845 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2846 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2847 Use ptrdiff_t, not int, for sizes.
2848 Don't increment bufsize until after realloc succeeds.
2849 Check for size-calculation overflow.
2850 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2852 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2854 * lread.c: Integer overflow fixes.
2855 (read_integer): Radix is now EMACS_INT, not int,
2856 to improve quality of diagnostics for out-of-range radices.
2857 Calculate buffer size correctly for out-of-range radices.
2858 (read1): Check for integer overflow in radices, and in
2859 read-circle numbers.
2860 (read_escape): Avoid int overflow.
2861 (Fload, openp, read_buffer_size, read1)
2862 (substitute_object_recurse, read_vector, read_list, map_obarray):
2863 Use ptrdiff_t, not int, for sizes.
2864 (read1): Use EMACS_INT, not int, for sizes.
2865 Check for size overflow.
2867 * image.c (cache_image): Check for size arithmetic overflow.
2869 * lread.c: Integer overflow issues.
2870 (saved_doc_string_size, saved_doc_string_length)
2871 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2872 Now ptrdiff_t, not int.
2873 (read1): Don't assume doc string length fits in int. Check for
2874 out-of-range doc string lengths.
2875 (read_list): Don't assume file position fits in int.
2876 (read_escape): Check for hex character overflow.
2878 2011-06-22 Leo Liu <sdl.web@gmail.com>
2880 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2881 Move to minibuffer.el.
2883 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2885 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2886 The following patches are for when GLYPH_DEBUG && !XASSERT.
2887 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2888 * dispnew.c (flush_stdout):
2889 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2890 Mark as externally visible.
2891 * dispnew.c (check_window_matrix_pointers): Now static.
2892 * dispnew.c (window_to_frame_vpos):
2893 * xfns.c (unwind_create_frame):
2894 * xterm.c (x_check_font): Remove unused local.
2895 * scroll.c (CHECK_BOUNDS):
2896 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2897 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2898 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2899 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2900 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2902 (debug_method_add): Use va_list and vsprintf rather than relying
2903 on undefined behavior with wrong number of arguments.
2904 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2905 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2906 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2907 since we're not interested in debugging glyphs with old libraries.
2908 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2909 GCC 4.6.0's static checking.
2911 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2913 Integer overflow and signedness fixes (Bug#8873).
2914 A few related buffer overrun fixes, too.
2916 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2918 * dispextern.h (struct face.stipple):
2919 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2920 (x_bitmap_mask, x_allocate_bitmap_record)
2921 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2922 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2923 (x_create_bitmap_from_xpm_data):
2924 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2925 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2927 * xfaces.c (load_pixmap):
2928 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2929 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2930 (.bitmaps_last, struct x_output.icon_bitmap):
2931 Use ptrdiff_t, not int, for bitmap indexes.
2932 (x_allocate_bitmap_record): Check for size overflow.
2933 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2935 Use ptrdiff_t, not int, for overlay counts.
2936 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2937 * editfns.c (overlays_around, get_pos_property):
2938 * textprop.c (get_char_property_and_overlay):
2939 * xdisp.c (next_overlay_change, note_mouse_highlight):
2940 * xfaces.c (face_at_buffer_position):
2941 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2942 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2943 (Fnext_overlay_change, Fprevious_overlay_change)
2944 (mouse_face_overlay_overlaps, Foverlays_in):
2945 Use ptrdiff_t, not int, for sizes.
2946 (overlays_at, overlays_in): Check for size-calculation overflow.
2948 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2950 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2951 (x_session_initialize): Do not assume string length fits in int.
2953 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2954 This is unlikely, but can occur if DPI is outlandish.
2956 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2957 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2959 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2960 * xrdb.c (magic_file_p, search_magic_path):
2961 Omit last arg SUFFIX; it was always 0. All callers changed.
2962 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2964 * xfont.c (xfont_match): Avoid need for strlen.
2966 * xfns.c: Don't assume strlen fits in int.
2967 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2969 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2970 not unsigned long, as we prefer signed integers. All callers changed.
2971 Detect integer overflow in repeat count.
2972 (message_dolog): Don't assume print length fits in 39 bytes.
2973 (display_mode_element): Don't assume strlen fits in int.
2975 * termcap.c: Don't assume sizes fit in int and never overflow.
2976 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2977 (gobble_line): Check for size-calculation overflow.
2979 * minibuf.c (Fread_buffer):
2980 * lread.c (intern, intern_c_string):
2981 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2982 Don't assume string length fits in int.
2984 * keyboard.c (parse_tool_bar_item):
2985 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2987 * font.c: Don't assume string length fits in int.
2988 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2989 Use ptrdiff_t, not int.
2990 (font_intern_prop): Don't assume string length fits in int.
2991 Don't assume integer property fits in fixnum.
2992 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2994 * filelock.c: Fix some buffer overrun and integer overflow issues.
2995 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2996 Reformulate so as not to need the command string.
2997 Invoke gzip -cd rather than gunzip, as it's more portable.
2998 (lock_info_type, lock_file_1, lock_file):
2999 Don't assume pid_t and time_t fit in unsigned long.
3000 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3001 (current_lock_owner): Prefer signed type for sizes.
3002 Use memcpy, not strncpy, where memcpy is what is really wanted.
3003 Don't assume (via atoi) that time_t and pid_t fit in int.
3004 Check for time_t and/or pid_t out of range, e.g., via a network share.
3005 Don't alloca where an auto var works fine.
3007 * fileio.c: Fix some integer overflow issues.
3008 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3009 Don't assume string length fits in int.
3010 (directory_file_name): Don't assume string length fits in long.
3011 (make_temp_name): Don't assume pid fits in int, or that its print
3012 length is less than 20.
3014 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3016 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3018 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3020 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3021 We prefer signed integers, even for size calculations.
3023 * emacs.c: Don't assume string length fits in 'int'.
3024 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3025 (main): Don't invoke strlen when not needed.
3027 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3028 (XD_DEBUG_MESSAGE): Don't waste a byte.
3030 * callproc.c (getenv_internal_1, getenv_internal)
3032 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3034 * lread.c (invalid_syntax): Omit length argument.
3035 All uses changed. This doesn't fix a bug, but it simplifies the
3036 code away from its former Hollerith-constant appearance, and it's
3037 one less 'int' to worry about when looking at integer-overflow issues.
3038 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3040 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3041 This didn't break anything, but it didn't help either.
3042 It's confusing to put a bogus integer in a place where the actual
3043 value does not matter.
3044 (LIST_END_P): Remove unused macro and its bogus comment.
3045 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3047 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3048 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3050 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3051 We prefer signed types, and the value cannot exceed the EMACS_INT
3052 range anyway (because otherwise the length would not be representable).
3053 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3054 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3055 This avoids a GCC warning when WIDE_EMACS_INT.
3057 * indent.c (sane_tab_width): New function.
3058 (current_column, scan_for_column, Findent_to, position_indentation)
3059 (compute_motion): Use it. This is just for clarity.
3060 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3062 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3064 * lisp.h (lint_assume): New macro.
3065 * composite.c (composition_gstring_put_cache):
3066 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3068 * editfns.c, insdel.c:
3069 Omit unnecessary forward decls, to simplify future changes.
3071 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3073 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3075 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3076 Use much-faster test for byte-length change.
3077 Don't assume string byte-length fits in 'int'.
3078 Check that character arg fits in 'int'.
3079 (mapcar1): Declare byte as byte, for clarity.
3081 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3083 * fns.c (concat): Catch string overflow earlier.
3084 Do not rely on integer wraparound.
3086 * dispextern.h (struct it.overlay_strings_charpos)
3087 (struct it.selective): Now EMACS_INT, not int.
3088 * xdisp.c (forward_to_next_line_start)
3089 (back_to_previous_visible_line_start)
3090 (reseat_at_next_visible_line_start, next_element_from_buffer):
3091 Don't arbitrarily truncate the value of 'selective' to int.
3093 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3095 * composite.c: Don't truncate sizes to 'int'.
3096 (composition_gstring_p, composition_reseat_it)
3097 (composition_adjust_point): Use EMACS_INT, not int.
3098 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3099 not EMACS_UINT, for indexes.
3101 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3103 * buffer.c: Include <verify.h>.
3104 (struct sortvec.priority, struct sortstr.priority):
3105 Now EMACS_INT, not int.
3106 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3107 (struct sortstr.size, record_overlay_string)
3108 (struct sortstrlist.size, struct sortlist.used):
3109 Don't truncate size to int.
3110 (record_overlay_string): Check for size-calculation overflow.
3111 (init_buffer_once): Check at compile-time, not run-time.
3113 2011-06-22 Jim Meyering <meyering@redhat.com>
3115 Don't leak an XBM-image-sized buffer
3116 * image.c (xbm_load): Free the image buffer after using it.
3118 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3121 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3122 that Sun C diagnosed.
3123 * fns.c (secure_hash): Fix pointer signedness issue.
3124 * intervals.c (static_offset_intervals): New function.
3125 (offset_intervals): Use it.
3127 2011-06-21 Leo Liu <sdl.web@gmail.com>
3130 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3133 * fns.c (secure_hash): Rename from crypto_hash_function and change
3134 the first arg to accept symbols.
3135 (Fsecure_hash): New primitive.
3136 (syms_of_fns): New symbols.
3138 2011-06-20 Deniz Dogan <deniz@dogan.se>
3140 * process.c (Fset_process_buffer): Clarify return value in
3143 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3145 * dispnew.c (add_window_display_history): Use BVAR.
3147 * xdisp.c (debug_method_add): Use BVAR.
3148 (check_window_end, dump_glyph_matrix, dump_glyph)
3149 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3151 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3154 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3155 check till after the cache is created in init_frame_faces.
3157 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3159 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3161 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3163 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3164 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3165 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3167 Improve buffer-overflow checking (Bug#8873).
3168 * fileio.c (Finsert_file_contents):
3169 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3170 Remove the old (too-loose) buffer overflow checks.
3171 They weren't needed, since make_gap checks for buffer overflow.
3172 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3173 The old code merely checked for Emacs fixnum overflow, and relied
3174 on undefined (wraparound) behavior. The new code avoids undefined
3175 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3177 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3178 Tune. Don't use wider integers than needed. Don't use alloca.
3179 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3181 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3183 * insdel.c, lisp.h (buffer_overflow): New function.
3184 (insert_from_buffer_1, replace_range, replace_range_2):
3185 * insdel.c (make_gap_larger):
3186 * editfns.c (Finsert_char):
3187 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3189 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3191 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3193 Integer overflow and signedness fixes (Bug#8873).
3195 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3196 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3198 * fileio.c: Don't assume EMACS_INT fits in off_t.
3199 (emacs_lseek): New static function.
3200 (Finsert_file_contents, Fwrite_region): Use it.
3201 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3203 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3205 * fns.c: Don't overflow int when computing a list length.
3206 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3207 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3208 truncation on 64-bit hosts. Check for QUIT every
3209 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3210 faster and is responsive enough.
3211 (Flength): Report an error instead of overflowing an integer.
3212 (Fsafe_length): Return a float if the value is not representable
3213 as a fixnum. This shouldn't happen except in contrived situations.
3214 (Fnthcdr, Fsort): Don't assume list length fits in int.
3215 (Fcopy_sequence): Don't assume vector length fits in int.
3217 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3218 (header_size, word_size): New constants.
3219 (allocate_vectorlike): Don't check size overflow here.
3220 (allocate_vector): Check it here instead, since this is the only
3221 caller of allocate_vectorlike that could cause overflow.
3222 Check that the new vector's length is representable as a fixnum.
3224 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3225 The previous code was bogus. For example, next_almost_prime (32)
3226 returned 39, which is undesirable as it is a multiple of 3; and
3227 next_almost_prime (24) returned 25, which is a multiple of 5 so
3228 why was the code bothering to check for multiples of 7?
3230 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3232 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3234 Variadic C functions now count arguments with ptrdiff_t.
3235 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3236 Back then I didn't know that the Emacs coding style prefers signed int.
3237 Also, in the meantime I found a few more instances where arguments
3238 were being counted with int, which may truncate counts on 64-bit
3239 machines, or EMACS_INT, which may be unnecessarily wide.
3240 * lisp.h (struct Lisp_Subr.function.aMANY)
3241 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3242 Arg counts are now ptrdiff_t, not size_t.
3243 All variadic functions and their callers changed accordingly.
3244 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3245 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3246 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3247 * callint.c (Fcall_interactively): Check arg count for overflow,
3248 to avoid potential buffer overrun. Use signed char, not 'int',
3249 for 'varies' array, so that we needn't bother to check its size
3250 calculation for overflow.
3251 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3252 * eval.c (apply_lambda):
3253 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3254 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3255 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3257 * callint.c (Fcall_interactively): Don't use index var as event count.
3259 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3260 * mem-limits.h (SIZE): Remove; no longer used.
3262 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3264 Remove unnecessary casts.
3265 * xterm.c (x_term_init):
3266 * xfns.c (x_set_border_pixel):
3267 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3268 These aren't needed now that we assume ANSI C.
3270 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3271 It's more likely to cause problems (due to unsigned overflow)
3274 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3276 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3278 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3280 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3282 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3284 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3286 GLYPH_CODE_FACE returns EMACS_INT, not int.
3287 * dispextern.h (merge_faces):
3288 * xfaces.c (merge_faces):
3289 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3290 Don't assume EMACS_INT fits in int.
3292 * character.h (CHAR_VALID_P): Remove unused parameter.
3293 * fontset.c, lisp.h, xdisp.c: All uses changed.
3295 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3297 * fns.c (concat): Minor tuning based on overflow analysis.
3298 This doesn't fix any bugs. Use int to hold character, instead
3299 of constantly refetching from Emacs object. Use XFASTINT, not
3300 XINT, for value known to be a character. Don't bother comparing
3301 a single byte to 0400, as it's always less.
3303 * floatfns.c (Fexpt):
3304 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3306 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3309 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3311 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3312 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3313 incorrectly succeed when S was a string, because 4294967386 was
3314 truncated before it was used.
3316 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3317 Otherwise, an out-of-range integer could cause undefined behavior
3320 * composite.c: Use int, not EMACS_INT, for characters.
3321 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3322 EMACS_INT, for values that are known to be in character range.
3323 This doesn't fix any bugs but is the usual style inside Emacs and
3324 may generate better code on 32-bit machines.
3326 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3327 This is for reasons similar to the recent CHAR_STRING fix.
3328 * charset.c (Fencode_char): Check that character arg is actually
3329 a character. Pass an int to ENCODE_CHAR.
3330 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3331 wider than 'int', as a compile-time check to prevent future regressions
3334 * character.c (char_string): Remove unnecessary casts.
3336 Make sure a 64-bit char is never passed to CHAR_STRING.
3337 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3338 by silently ignoring the top 32 bits, allowing some values
3339 that were far too large to be valid characters.
3340 * character.h: Include <verify.h>.
3341 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3342 arguments are no wider than unsigned, as a compile-time check
3343 to prevent future regressions in this area.
3345 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3346 (Fsubst_char_in_region):
3348 * xdisp.c (decode_mode_spec_coding):
3349 Adjust to CHAR_STRING's new requirement.
3350 * editfns.c (Finsert_char, Fsubst_char_in_region):
3351 * fns.c (concat): Check that character args are actually
3352 characters. Without this test, these functions did the wrong
3353 thing with wildly out-of-range values on 64-bit hosts.
3355 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3356 These casts should not be needed on 32-bit hosts, either.
3357 * keyboard.c (read_char):
3358 * lread.c (Fload): Remove casts to unsigned.
3360 * lisp.h (UNSIGNED_CMP): New macro.
3361 This fixes comparison bugs on 64-bit hosts.
3362 (ASCII_CHAR_P): Use it.
3363 * casefiddle.c (casify_object):
3364 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3365 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3366 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3367 * dispextern.h (FACE_FROM_ID):
3368 * keyboard.c (read_char): Use UNSIGNED_CMP.
3370 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3371 not to EMACS_INT, to avoid GCC warning.
3373 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3375 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3376 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3377 isn't needed on 32-bit machines.
3379 * buffer.c (Fgenerate_new_buffer_name):
3380 Use EMACS_INT for count, not int.
3381 (advance_to_char_boundary): Return EMACS_INT, not int.
3383 * data.c (Qcompiled_function): Now static.
3385 * window.c (window_body_lines): Now static.
3387 * image.c (gif_load): Rename local to avoid shadowing.
3389 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3390 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3391 * alloc.c (make_save_value): Integer argument is now of type
3393 (mark_object): Use ptrdiff_t, not int.
3394 * lisp.h (pD): New macro.
3395 * print.c (print_object): Use it.
3397 * alloc.c: Use EMACS_INT, not int, to count objects.
3398 (total_conses, total_markers, total_symbols, total_vector_size)
3399 (total_free_conses, total_free_markers, total_free_symbols)
3400 (total_free_floats, total_floats, total_free_intervals)
3401 (total_intervals, total_strings, total_free_strings):
3402 Now EMACS_INT, not int. All uses changed.
3403 (Fgarbage_collect): Compute overall total using a double, so that
3404 integer overflow is less likely to be a problem. Check for overflow
3405 when converting back to an integer.
3406 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3407 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3408 These were 'int' variables that could overflow on 64-bit hosts;
3409 they were never used, so remove them instead of repairing them.
3410 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3411 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3412 Previously, this ceilinged at INT_MAX, but that doesn't work on
3414 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3416 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3417 (allocate_vectorlike): Check for ptrdiff_t overflow.
3418 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3419 when a (possibly-narrower) signed value would do just as well.
3420 We prefer using signed arithmetic, to avoid comparison confusion.
3422 * alloc.c: Catch some string size overflows that we were missing.
3423 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3424 for convenience in STRING_BYTES_MAX.
3425 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3426 The definition here is exact; the one in lisp.h was approximate.
3427 (allocate_string_data): Check for string overflow. This catches
3428 some instances we weren't catching before. Also, it catches
3429 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3430 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3431 and ptrdiff_t and EMACS_INT are both 64 bits.
3433 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3434 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3435 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3437 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3439 * alloc.c (Fmake_string): Check for out-of-range init.
3441 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3443 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3445 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3447 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3448 xg_get_default_scrollbar_width.
3450 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3451 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3452 (style_changed_cb): Call update_theme_scrollbar_width and call
3453 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3454 all frames (Bug#8505).
3455 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3456 Call gtk_window_set_resizable if HAVE_GTK3.
3457 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3458 and height if HAVE_GTK3 (Bug#8505).
3459 (scroll_bar_width_for_theme): New variable.
3460 (update_theme_scrollbar_width): New function.
3461 (xg_get_default_scrollbar_width): Move code to
3462 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3463 (xg_initialize): Call update_theme_scrollbar_width.
3465 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3467 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3469 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3471 * frame.c (make_frame): Call other_buffer_safely instead of
3474 * window.c (temp_output_buffer_show): Call display_buffer with
3475 second argument Vtemp_buffer_show_specifiers and reset latter
3476 immediately after the call.
3477 (Vtemp_buffer_show_specifiers): New variable.
3478 (auto_window_vscroll_p, next_screen_context_lines)
3479 (Vscroll_preserve_screen_position): Remove leading asterisks from
3482 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3484 Fix minor problems found by GCC 4.6.0 static checking.
3485 * buffer.c (Qclone_number): Remove for now, as it's unused.
3486 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3487 (record_buffer): Remove unused local.
3488 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3489 (set_frame_buffer_list): Remove; unused.
3490 * frame.h (other_visible_frames): Remove decl.
3491 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3492 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3493 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3495 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3496 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3497 Define only if HAVE_GPM.
3498 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3499 (update_hints_inhibit): Remove; never set. All uses removed.
3500 * widgetprv.h (emacsFrameClassRec): Remove decl.
3501 * window.c (delete_deletable_window): Now returns void, since it
3502 wasn't returning anything.
3503 (compare_window_configurations): Remove unused locals.
3504 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3505 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3506 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3507 the same widths as pointers. This follows up on the 2011-05-06 patch.
3508 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3509 * xterm.h: Likewise.
3510 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3512 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3514 * makefile.w32-in: Update dependencies.
3515 (LISP_H): Add lib/intprops.h.
3517 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3519 * image.c (gif_load): Add animation frame delay to the metadata.
3520 (syms_of_image): Use DEFSYM. New symbol `delay'.
3522 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3524 * window.c (delete_deletable_window): Re-add.
3525 (Fset_window_configuration): Rewrite to handle dead buffers and
3526 consequently deletable windows.
3527 (window_tree, Fwindow_tree): Remove. Supply functionality in
3529 (compare_window_configurations): Simplify code.
3531 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3533 * image.c (imagemagick_load_image): Fix type mismatch.
3534 (Fimagemagick_types): Likewise.
3536 * window.h (replace_buffer_in_windows): Declare.
3538 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3540 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3541 Qclone_number. Remove external declaration of Qdelete_window.
3542 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3544 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3545 Run Qbuffer_list_update_hook if allowed.
3546 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3547 buffer list implementation.
3548 (other_buffer_safely): New function.
3549 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3550 calls to replace_buffer_in_windows and
3551 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3553 (record_buffer): Inhibit quitting and rewrite using quittable
3554 functions. Run Qbuffer_list_update_hook if allowed.
3555 (Frecord_buffer, Funrecord_buffer): New functions.
3556 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3557 Move switch-to-buffer to window.el.
3558 (bury-buffer): Move to window.el.
3559 (Vbuffer_list_update_hook): New variable.
3561 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3564 * window.h (resize_frame_windows): Move up in code.
3565 (Fwindow_frame): Remove EXFUN.
3566 (replace_buffer_in_all_windows): Remove prototype.
3567 (replace_buffer_in_windows_safely): Add prototype.
3569 * window.c: Declare Qdelete_window static again. Move down
3570 declaration of select_count.
3571 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3572 (Fother_window): Move to window.el.
3573 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3574 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3575 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3577 (replace_buffer_in_windows): Implement by calling
3578 Qreplace_buffer_in_windows.
3579 (replace_buffer_in_all_windows): Remove with some functionality
3580 moved into replace_buffer_in_windows_safely.
3581 (replace_buffer_in_windows_safely): New function.
3582 (select_window_norecord, select_frame_norecord): Move in front
3583 of run_window_configuration_change_hook. Remove now obsolete
3585 (Fset_window_buffer): Rewrite doc-string.
3586 Call Qrecord_window_buffer.
3587 (keys_of_window): Move binding for other-window to window.el.
3589 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3591 * dispextern.h (struct image): Replace data member, whose int_val
3592 and ptr_val fields were not used by anything, with a single
3595 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3596 (gif_clear_image, gif_load, imagemagick_load_image)
3597 (gs_clear_image, gs_load): Callers changed.
3599 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3601 * buffer.h: Include <time.h>, for time_t.
3602 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3604 Fix minor problems found by static checking.
3606 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3608 Make identifiers static if they are not used in other modules.
3609 * data.c (Qcompiled_function, Qframe, Qvector):
3610 * image.c (QimageMagick, Qsvg):
3611 * minibuf.c (Qmetadata):
3612 * window.c (resize_window_check, resize_root_window): Now static.
3613 * window.h (resize_window_check, resize_root_window): Remove decls.
3615 * window.c (window_deletion_count, delete_deletable_window):
3617 (window_body_lines): Now static.
3618 (Fdelete_other_windows_internal): Mark vars as initialized.
3619 Make sure 'resize_failed' is initialized.
3620 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3621 (resize_window_apply): Remove unused local.
3622 * window.h (delete_deletable_window): Remove decl.
3624 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3625 (imagemagick_load_image): Fix pointer signedness problem by changing
3626 last arg from unsigned char * to char *. All uses changed.
3627 Also, fix a local for similar reasons.
3628 Remove unused locals. Remove locals to avoid shadowing.
3629 (fn_rsvg_handle_free): Remove; unused.
3630 (svg_load, svg_load_image): Fix pointer signedness problem.
3631 (imagemagick_load_image): Don't use garbage pointer image_wand.
3633 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3635 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3637 * image.c (gif_load): Fix omitted cast error introduced by
3640 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3642 * window.h (resize_proportionally, orig_total_lines)
3643 (orig_top_line): Remove from window structure.
3644 (set_window_height, set_window_width, change_window_heights)
3645 (Fdelete_window): Remove prototypes.
3646 (resize_frame_windows): Remove duplicate declaration.
3648 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3650 * window.h (resize_frame_windows, resize_window_check)
3651 (delete_deletable_window, resize_root_window)
3652 (resize_frame_windows): Declare prototypes.
3654 * window.c (resize_window_apply): Make definition be "static" to
3655 match the prototype.
3657 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3659 * window.c: Remove declarations of Qwindow_size_fixed,
3660 window_min_size_1, window_min_size_2, window_min_size,
3661 size_window, window_fixed_size_p, enlarge_window, delete_window.
3662 Remove static from declaration of Qdelete_window, it's
3663 temporarily needed by Fbury_buffer.
3664 (replace_window): Don't assign orig_top_line and
3666 (Fdelete_window, delete_window): Remove. Window deletion is
3667 handled by window.el.
3668 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3669 Replace Fdelete_window calls with calls to Qdelete_window.
3670 (Fdelete_other_windows): Remove. Deleting other windows is
3671 handled by window.el.
3672 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3673 handled in window.el.
3674 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3675 Window minimum sizes are handled in window.el.
3676 (shrink_windows, size_window, set_window_height)
3677 (set_window_width, change_window_heights, window_height)
3678 (window_width, CURBEG, CURSIZE, enlarge_window)
3679 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3680 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3681 handled in window.el.
3682 (make_dummy_parent): Rename to make_parent_window and give it a
3683 second argument horflag.
3684 (make_window): Don't set resize_proportionally any more.
3685 (Fsplit_window): Remove. Windows are split in window.el.
3686 (save_restore_action, save_restore_orig_size)
3687 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3688 Resize mini windows in window.el.
3689 (grow_mini_window, shrink_mini_window): Implement by calling
3690 Qresize_root_window_vertically, resize_window_check and
3691 resize_window_apply.
3692 (saved_window, Fset_window_configuration, save_window_save):
3693 Do not handle orig_top_line, orig_total_lines, and
3694 resize_proportionally.
3695 (window_min_height, window_min_width): Move to window.el.
3696 (keys_of_window): Move bindings for delete-other-windows,
3697 split-window, delete-window and enlarge-window to window.el.
3699 * buffer.c: Temporarily extern Qdelete_window.
3700 (Fbury_buffer): Temporarily call Qdelete_window instead of
3701 Fdelete_window (Fbury_buffer will move to window.el soon).
3703 * frame.c (set_menu_bar_lines_1): Remove code handling
3704 orig_top_line and orig_total_lines.
3706 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3707 set_window_height but set heights directly.
3708 (change_frame_size_1): Use resize_frame_windows.
3710 * xdisp.c (init_xdisp): Don't use set_window_height but set
3713 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3714 Use resize_frame_windows instead of change_window_heights and run
3715 run_window_configuration_change_hook.
3717 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3718 instead of change_window_heights and run
3719 run_window_configuration_change_hook.
3721 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3723 * window.c (replace_window): Rename second argument REPLACEMENT to
3724 NEW. New third argument SETFLAG. Rewrite.
3725 (delete_window, make_dummy_parent): Call replace_window with
3727 (window_list_1): Move down in code.
3728 (run_window_configuration_change_hook): Move set_buffer part
3729 before select_frame_norecord part in order to unwind correctly.
3730 Rename count1 to count.
3731 (recombine_windows, delete_deletable_window, resize_root_window)
3732 (Fdelete_other_windows_internal)
3733 (Frun_window_configuration_change_hook, make_parent_window)
3734 (resize_window_check, resize_window_apply, Fresize_window_apply)
3735 (resize_frame_windows, Fsplit_window_internal)
3736 (Fdelete_window_internal, Fresize_mini_window_internal):
3738 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3740 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3742 * window.h (window): Add some new members to window structure -
3743 normal_lines, normal_cols, new_total, new_normal, clone_number,
3744 splits, nest, prev_buffers, next_buffers.
3745 (WINDOW_TOTAL_SIZE): Move here from window.c.
3746 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3748 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3750 (make_dummy_parent): Set new members of windows structure.
3751 (make_window): Move down in code. Handle new members of window
3753 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3754 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3755 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3756 (Fset_window_prev_buffers, Fwindow_next_buffers)
3757 (Fset_window_next_buffers, Fset_window_clone_number):
3759 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3760 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3762 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3763 Argument WINDOW can be now internal window too.
3764 (Fwindow_use_time): Move up in code.
3765 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3767 (Fset_window_configuration, saved_window)
3768 (Fcurrent_window_configuration, save_window_save): Handle new
3769 members of window structure.
3770 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3771 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3772 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3773 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3774 Qget_mru_window, Qresize_root_window,
3775 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3776 Qauto_buffer_name; staticpro them.
3778 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3780 * window.c (Fwindow_total_size, Fwindow_left_column)
3781 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3782 (Fwindow_list_1): New functions.
3783 (window_box_text_cols): Replace with window_body_cols.
3784 (Fwindow_width, Fscroll_left, Fscroll_right):
3785 Use window_body_cols instead of window_box_text_cols.
3786 (delete_window, Fset_window_configuration):
3787 Call delete_all_subwindows with window as argument.
3788 (delete_all_subwindows): Take a window as argument and not a
3790 (window_loop): Remove handling of GET_LRU_WINDOW and
3792 (Fget_lru_window, Fget_largest_window): Move to window.el.
3794 * window.h: Extern window_body_cols instead of
3795 window_box_text_cols. delete_all_subwindows now takes a
3796 Lisp_Object as argument.
3798 * indent.c (compute_motion, Fcompute_motion):
3799 Use window_body_cols instead of window_box_text_cols.
3801 * frame.c (delete_frame): Call delete_all_subwindows with root
3804 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3806 * fns.c (Fputhash): Document return value.
3808 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3810 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3812 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3814 Cons<->int and similar integer overflow fixes (Bug#8794).
3816 Check for overflow when converting integer to cons and back.
3817 * charset.c (Fdefine_charset_internal, Fdecode_char):
3818 Use cons_to_unsigned to catch overflow.
3819 (Fencode_char): Use INTEGER_TO_CONS.
3820 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3821 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3822 * data.c (long_to_cons, cons_to_long): Remove.
3823 (cons_to_unsigned, cons_to_signed): New functions.
3824 These signal an error for invalid or out-of-range values.
3825 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3826 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3827 * font.c (Ffont_variation_glyphs):
3828 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3829 * lisp.h: Include <intprops.h>.
3830 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3831 (cons_to_signed, cons_to_unsigned): New decls.
3832 (long_to_cons, cons_to_long): Remove decls.
3833 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3834 (Fprimitive_undo): Use CONS_TO_INTEGER.
3835 * xfns.c (Fx_window_property): Likewise.
3836 * xselect.c: Include <limits.h>.
3837 (x_own_selection, selection_data_to_lisp_data):
3838 Use INTEGER_TO_CONS.
3839 (x_handle_selection_request, x_handle_selection_clear)
3840 (x_get_foreign_selection, Fx_disown_selection_internal)
3841 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3842 (lisp_data_to_selection_data): Use cons_to_unsigned.
3843 (x_fill_property_data): Use cons_to_signed.
3844 Report values out of range.
3846 Check for buffer and string overflow more precisely.
3847 * buffer.h (BUF_BYTES_MAX): New macro.
3848 * lisp.h (STRING_BYTES_MAX): New macro.
3849 * alloc.c (Fmake_string):
3850 * character.c (string_escape_byte8):
3851 * coding.c (coding_alloc_by_realloc):
3852 * doprnt.c (doprnt):
3853 * editfns.c (Fformat):
3855 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3856 since they may not be the same number.
3857 * editfns.c (Finsert_char):
3858 * fileio.c (Finsert_file_contents):
3859 Likewise for BUF_BYTES_MAX.
3861 * image.c: Use ptrdiff_t, not int, for sizes.
3862 (slurp_file): Switch from int to ptrdiff_t.
3864 (slurp_file): Check that file size fits in both size_t (for
3865 malloc) and ptrdiff_t (for sanity and safety).
3867 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3868 if b->modtime has its maximal value.
3870 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3872 Don't assume time_t can fit into int.
3873 * buffer.h (struct buffer.modtime): Now time_t, not int.
3874 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3875 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3877 Minor fixes for signed vs unsigned integers.
3878 * character.h (MAYBE_UNIFY_CHAR):
3879 * charset.c (maybe_unify_char):
3880 * keyboard.c (read_char, reorder_modifiers):
3881 XINT -> XFASTINT, since the integer must be nonnegative.
3882 * ftfont.c (ftfont_spec_pattern):
3883 * keymap.c (access_keymap, silly_event_symbol_error):
3884 XUINT -> XFASTINT, since the integer must be nonnegative.
3885 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3886 since it makes no difference and we prefer signed.
3887 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3888 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3891 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3893 * window.h (Fwindow_frame): Declare.
3895 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3897 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3898 (SPARE_MEMORY): Always define.
3899 (LARGE_REQUEST): Remove.
3900 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3902 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3904 * lisp.h: Move EXFUNS for Fframe_root_window,
3905 Fframe_first_window and Fset_frame_selected_window to window.h.
3907 * window.h: Move EXFUNS for Fframe_root_window,
3908 Fframe_first_window and Fset_frame_selected_window here from
3911 * frame.c (Fwindow_frame, Fframe_first_window)
3912 (Fframe_root_window, Fframe_selected_window)
3913 (Fset_frame_selected_window): Move to window.c.
3914 (Factive_minibuffer_window): Move to minibuf.c.
3915 (Fother_visible_frames_p): New function.
3917 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3919 * window.c (decode_window, decode_any_window): Move up in code.
3920 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3921 (inhibit_frame_unsplittable): Remove unused variable.
3922 (Fwindow_buffer): Move up and rewrite doc-string.
3923 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3924 (Fwindow_prev): New functions.
3925 (Fwindow_frame): Move here from frame.c. Accept any window as
3927 (Fframe_root_window, Fframe_first_window)
3928 (Fframe_selected_window): Move here from frame.c. Accept frame
3929 or arbitrary window as argument. Update doc-strings.
3930 (Fminibuffer_window): Move up in code.
3931 (Fwindow_minibuffer_p): Move up in code and simplify.
3932 (Fset_frame_selected_window): Move here from frame.c.
3934 (Fselected_window, select_window, Fselect_window): Move up in
3935 code. Minor doc-string fixes.
3937 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3939 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3940 Do not assume that spare memory exists; that assumption is valid
3941 only if SYSTEM_MALLOC.
3942 (LARGE_REQUEST): New macro, so that the issue of large requests
3943 is separated from the issue of spare memory.
3945 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3947 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3950 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3952 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3955 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3957 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3959 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3961 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3962 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3964 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3966 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3968 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3970 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3971 (x_clipboard_manager_save): Add return value.
3972 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3974 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3975 Obey Vx_select_enable_clipboard_manager. Catch errors in
3976 x_clipboard_manager_save (Bug#8779).
3977 (Vx_select_enable_clipboard_manager): New variable.
3978 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3980 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3982 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3984 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3986 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3987 in the current matrix if keep_current_p is non-zero.
3989 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3991 * bidi.c (bidi_level_of_next_char): Fix last change.
3993 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3995 Support bidi reordering of text covered by display properties.
3997 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3998 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3999 (bidi_cache_search, bidi_cache_iterator_state)
4000 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4001 (bidi_level_of_next_char, bidi_move_to_visually_next):
4002 Support character positions inside a run of characters covered by a
4004 (bidi_paragraph_init, bidi_resolve_explicit_1)
4005 (bidi_level_of_next_char): Call bidi_fetch_char and
4006 bidi_fetch_char_advance instead of FETCH_CHAR and
4008 (bidi_init_it): Initialize new members.
4009 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4011 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4012 instead of using explicit *_CHAR codes.
4013 (bidi_resolve_explicit, bidi_resolve_weak):
4014 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4015 bidirectional text is supported only in multibyte buffers.
4016 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4017 it to initialize the frame_window_p member of struct bidi_it.
4018 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4019 (bidi_resolve_explicit, bidi_resolve_weak)
4020 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4021 bidi_it->nchars is non-positive.
4022 (bidi_level_of_next_char): Don't try to lookup the cache for the
4023 next/previous character if nothing is cached there yet, or if we
4024 were just reseat()'ed to a new position.
4026 * xdisp.c (set_cursor_from_row): Set start and stop points
4027 according to the row's direction when priming the loop that looks
4028 for the glyph on which to display cursor.
4029 (single_display_spec_intangible_p): Function deleted.
4030 (display_prop_intangible_p): Reimplement to call
4031 handle_display_spec instead of single_display_spec_intangible_p.
4032 Accept 3 additional arguments needed by handle_display_spec.
4033 This fixes incorrect cursor motion across display property with complex
4034 values: lists, `(when COND...)' forms, etc.
4035 (single_display_spec_string_p): Support property values that are
4036 lists with the argument STRING its top-level element.
4037 (display_prop_string_p): Fix the condition for processing a
4038 property that is a list to be consistent with handle_display_spec.
4039 (handle_display_spec): New function, refactored from the
4040 last portion of handle_display_prop.
4041 (compute_display_string_pos): Accept additional argument
4042 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4043 value of a `display' property is a "replacing spec".
4044 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4045 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4046 the display property, but just return a value indicating whether
4047 the display property will replace the characters it covers.
4048 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4049 frame_window_p members of struct bidi_it.
4050 (compute_display_string_pos, compute_display_string_end):
4052 (push_it): Accept second argument POSITION, where pop_it should
4053 jump to continue iteration.
4054 (reseat_1): Initialize bidi_it.disp_pos.
4056 * keyboard.c (adjust_point_for_property): Adjust the call to
4057 display_prop_intangible_p to its new signature.
4059 * dispextern.h (struct bidi_it): New member frame_window_p.
4060 (bidi_init_it): Update prototypes.
4061 (display_prop_intangible_p): Update prototype.
4062 (compute_display_string_pos, compute_display_string_end):
4064 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4067 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4069 Malloc failure behavior now depends on size of allocation.
4070 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4071 * lisp.h: Change signatures accordingly.
4072 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4073 All callers changed. (Bug#8762)
4075 * gnutls.c: Use Emacs's memory allocators.
4076 Without this change, the gnutls library would invoke malloc etc.
4077 directly, which causes problems on non-SYNC_INPUT hosts, and which
4078 runs afoul of improving memory_full behavior. (Bug#8761)
4079 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4080 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4081 xfree instead of the default malloc, realloc, free.
4082 (Fgnutls_boot): No need to check for memory allocation failure,
4083 since xmalloc does that for us.
4085 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4086 * category.c (hash_get_category_set):
4087 * ccl.c (ccl_driver):
4088 * charset.c (Fdefine_charset_internal):
4089 * charset.h (struct charset.hash_index):
4090 * composite.c (get_composition_id, gstring_lookup_cache)
4091 (composition_gstring_put_cache):
4092 * composite.h (struct composition.hash_index):
4093 * dispextern.h (struct image.hash):
4094 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4095 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4096 (hashfn_equal, hashfn_user_defined, make_hash_table)
4097 (maybe_resize_hash_table, hash_lookup, hash_put)
4098 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4099 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4100 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4101 * image.c (make_image, search_image_cache, lookup_image)
4102 (xpm_put_color_table_h):
4103 * lisp.h (struct Lisp_Hash_Table):
4104 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4105 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4106 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4107 * alloc.c (allocate_vectorlike):
4108 Check for overflow in vector size calculations.
4109 * ccl.c (ccl_driver):
4110 Check for overflow when converting EMACS_INT to int.
4111 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4112 need to be updated by these changes.
4113 * fns.c (make_hash_table, maybe_resize_hash_table):
4114 Check for integer overflow with large hash tables.
4115 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4116 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4117 (SXHASH_REDUCE): New macro.
4118 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4119 Use it instead of discarding useful hash info with large hash values.
4120 (sxhash_float): New function.
4121 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4122 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4123 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4124 Rewrite to use FIXNUM_BITS, as this simplifies things.
4125 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4126 Adjust signatures to match updated version of code.
4127 (consing_since_gc): Now EMACS_INT, since a single hash table can
4128 use more than INT_MAX bytes.
4130 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4132 Make it possible to build with GCC-4.6+ -O2 -flto.
4134 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4136 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4138 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4139 Call minibuffer-inactive-mode.
4141 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4143 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4144 Update dependencies.
4146 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4148 * data.c (init_data): Remove code for UTS, this system is not
4151 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4153 Don't force ./temacs to start in terminal mode.
4155 * frame.c (make_initial_frame): Initialize faces in all cases, not
4156 only when CANNOT_DUMP is defined.
4157 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4159 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4161 * dispnew.c (add_window_display_history): Use const for the string
4162 pointer. Remove declaration, not needed.
4164 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4166 Use 'inline', not 'INLINE'.
4167 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4168 * alloc.c, fontset.c (INLINE): Remove.
4169 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4170 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4171 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4172 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4173 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4175 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4177 Make it possible to run ./temacs.
4179 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4180 syms_of_callproc does the same thing. Remove test for
4181 "initialized", do it in the caller.
4182 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4184 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4186 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4187 (read_minibuf): Use get_minibuffer.
4188 (syms_of_minibuf): Use DEFSYM.
4189 (Qmetadata): New var.
4190 * data.c (Qbuffer): Don't make it static.
4191 (syms_of_data): Use DEFSYM.
4193 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4195 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4196 (CCL_CODE_MIN): New macro.
4198 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4200 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4202 * eval.c (Qdebug): Now static.
4203 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4204 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4205 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4207 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4209 * image.c: Various fixes to ImageMagick code comments.
4210 (Fimagemagick_types): Doc fix.
4212 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4214 Minor fixes prompted by GCC 4.6.0 warnings.
4216 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4218 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4219 (x_clipboard_manager_save_all): Move extern decl to ...
4220 * xterm.h: ... here, so that it can be checked for consistency.
4222 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4224 * xselect.c (x_clipboard_manager_save_frame)
4225 (x_clipboard_manager_save_all): New functions.
4226 (Fx_clipboard_manager_save): Lisp function deleted.
4228 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4229 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4231 * xterm.h: Update prototype.
4233 2011-05-28 William Xu <william.xwl@gmail.com>
4235 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4238 2011-05-28 Jim Meyering <meyering@redhat.com>
4240 Avoid a sign-extension bug in crypto_hash_function.
4241 * fns.c (to_uchar): Define.
4242 (crypto_hash_function): Use it to convert some newly-signed
4243 variables to unsigned, to avoid sign-extension bugs. For example,
4244 without this change, (md5 "truc") would evaluate to
4245 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4246 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4247 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4249 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4251 Integer overflow fixes.
4253 * dbusbind.c: Serial number integer overflow fixes.
4254 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4255 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4256 to hold a serial number that is too large for a fixnum.
4257 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4258 Check for serial numbers out of range. Decode any serial number
4259 that was so large that it became a float. (Bug#8722)
4261 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4262 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4263 Use XFASTINT rather than XUINT when numbers are nonnegative.
4264 (xd_append_arg, Fdbus_method_return_internal):
4265 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4266 arguments, check that Lisp number is nonnegative, rather than
4267 silently wrapping negative numbers around. (Bug#8722)
4268 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4271 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4273 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4275 ccl: add integer overflow checks
4276 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4277 (IN_INT_RANGE): New macros.
4278 (ccl_driver): Use them to check for integer overflow when
4279 decoding a CCL program. Many of the new checks are whether XINT (x)
4280 fits in int; it doesn't always, on 64-bit hosts. The new version
4281 doesn't catch all possible integer overflows, but it's an
4282 improvement. (Bug#8719)
4284 * alloc.c (make_event_array): Use XINT, not XUINT.
4285 There's no need for unsigned here.
4287 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4288 This follows up to the 2011-05-06 change that substituted uintptr_t
4289 for EMACS_INT. This case wasn't caught back then.
4291 Rework Fformat to avoid integer overflow issues.
4292 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4293 now (part of C89). Include <verify.h>.
4294 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4295 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4296 (Fformat): Avoid the prepass trying to compute sizes; it was only
4297 approximate and thus did not catch overflow reliably. Instead, walk
4298 through the format just once, formatting and computing sizes as we go,
4299 checking for integer overflow at every step, and allocating a larger
4300 buffer as needed. Keep track separately whether the format is
4301 multibyte. Keep only the most-recently calculated precision, rather
4302 than them all. Record whether each argument has been converted to
4303 string. Use EMACS_INT, not int, for byte and char and arg counts.
4304 Support field widths and precisions larger than INT_MAX. Avoid
4305 sprintf's undefined behavior with conversion specifications such as %#d
4306 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4307 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4308 formatting out-of-range floating point numbers with int
4311 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4313 * data.c: Avoid integer truncation in expressions involving floats.
4314 * data.c: Include <intprops.h>.
4315 (arith_driver): When there's an integer overflow in an expression
4316 involving floating point, convert the integers to floating point
4317 so that the resulting value does not suffer from catastrophic
4318 integer truncation. For example, on a 64-bit host (* 4
4319 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4320 Do not rely on undefined behavior after integer overflow.
4322 merge count_size_as_multibyte, parse_str_to_multibyte
4323 * character.c, character.h (count_size_as_multibyte):
4324 Rename from parse_str_to_multibyte; all uses changed.
4325 Check for integer overflow.
4326 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4327 since it's now a duplicate of the other. This is more of
4328 a character than a buffer op, so better that it's in character.c.
4329 * fns.c, print.c: Adjust to above changes.
4331 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4333 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4335 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4337 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4338 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4339 (x_clipboard_manager_save): Now static.
4340 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4342 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4343 (crypto_hash_function): Now static.
4344 Fix pointer signedness problems. Avoid unnecessary initializations.
4346 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4348 * termhooks.h (Vselection_alist): Make it terminal-local.
4350 * terminal.c (create_terminal): Initialize it.
4352 * xselect.c: Support for clipboard managers.
4353 (Vselection_alist): Move to termhooks.h as terminal-local var.
4354 (LOCAL_SELECTION): New macro.
4355 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4356 (symbol_to_x_atom): Remove gratuitous arg.
4357 (x_handle_selection_request, lisp_data_to_selection_data)
4358 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4359 (x_own_selection, x_get_local_selection, x_convert_selection):
4360 New arg, specifying work frame. Use terminal-local Vselection_alist.
4361 (some_frame_on_display): Delete unused function.
4362 (Fx_own_selection_internal, Fx_get_selection_internal)
4363 (Fx_disown_selection_internal, Fx_selection_owner_p)
4364 (Fx_selection_exists_p): New optional frame arg.
4365 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4366 (x_handle_selection_clear): Don't treat other terminals with the
4367 same keyboard specially. Use the terminal-local Vselection_alist.
4368 (x_clear_frame_selections): Use Frun_hook_with_args.
4370 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4372 * xterm.h: Add support for those atoms.
4374 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4376 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4377 (converted_selections, conversion_fail_tag): New global variables.
4378 (x_selection_request_lisp_error): Free the above.
4379 (x_get_local_selection): Remove unnecessary code.
4380 (x_reply_selection_request): Args changed; handle arbitrary array
4381 of converted selections stored in converted_selections.
4382 Separate the XChangeProperty and SelectionNotify steps.
4383 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4384 (x_convert_selection): New function.
4385 (x_handle_selection_event): Simplify.
4386 (x_get_foreign_selection): Don't ignore incoming requests while
4387 waiting for an answer; this will fail when we implement
4388 SAVE_TARGETS, and seems unnecessary anyway.
4389 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4390 (Vx_sent_selection_functions): Doc fix.
4392 2011-05-26 Leo Liu <sdl.web@gmail.com>
4394 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4396 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4398 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4400 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4401 for fringe update if it has periodic bitmap.
4402 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4403 and fringe_bitmap_periodic_p.
4405 * fringe.c (get_fringe_bitmap_data): New function.
4406 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4407 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4408 row. Mark glyph row for fringe update if periodicity changed.
4410 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4411 for fringe update unless it has periodic bitmap.
4413 2011-05-25 Kenichi Handa <handa@m17n.org>
4415 * xdisp.c (get_next_display_element): Set correct it->face_id for
4416 a static composition.
4418 2011-05-24 Leo Liu <sdl.web@gmail.com>
4421 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4423 * fns.c (crypto_hash_function, Fsha1): New function.
4424 (Fmd5): Use crypto_hash_function.
4425 (syms_of_fns): Add Ssha1.
4427 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4429 * gnutls.c: Remove unused macros.
4430 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4431 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4432 Remove macros that are defined and never used.
4433 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4435 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4437 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4438 (Fx_get_selection_internal): Minor cleanup.
4439 (Fx_own_selection_internal): Rename arguments for consistency with
4442 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4444 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4446 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4448 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4450 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4452 * dispnew.c (scrolling_window): Don't exclude the case that the
4453 last enabled row in the desired matrix touches the bottom boundary.
4455 2011-05-21 Glenn Morris <rgm@gnu.org>
4457 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4458 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4459 and add some more files.
4461 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4463 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4464 report_file_error introduced by the change from 2011-05-07.
4466 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4468 * systime.h (Time): Define only if emacs is defined.
4469 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4470 where the include path doesn't have X11/X.h by default. See
4471 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4473 2011-05-20 Kenichi Handa <handa@m17n.org>
4475 * composite.c (find_automatic_composition): Fix previous change.
4477 2011-05-20 Glenn Morris <rgm@gnu.org>
4479 * lisp.mk: New file, split from Makefile.in.
4480 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4481 (shortlisp): Remove.
4482 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4484 2011-05-19 Glenn Morris <rgm@gnu.org>
4486 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4487 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4488 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4489 (lisp): Set the order to that of loadup.el.
4490 (shortlisp): Make it a copy of $lisp.
4491 (SOME_MACHINE_LISP): Remove.
4492 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4493 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4495 2011-05-18 Kenichi Handa <handa@m17n.org>
4497 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4498 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4499 (find_automatic_composition): Mostly rewrite for efficiency.
4501 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4503 * makefile.w32-in: Update dependencies.
4505 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4507 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4508 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4510 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4512 Fix some integer overflow issues, such as string length overflow.
4514 * insdel.c (count_size_as_multibyte): Check for string overflow.
4516 * character.c (lisp_string_width): Check for string overflow.
4517 Use EMACS_INT, not int, for string indexes and lengths; in
4518 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4519 the resulting string length overflows an EMACS_INT; instead,
4520 report a string overflow if no precision given. When checking for
4521 precision exhaustion, use a check that cannot possibly have
4522 integer overflow. (Bug#8675)
4523 * character.h (lisp_string_width): Adjust to new signature.
4525 * alloc.c (string_overflow): New function.
4526 (Fmake_string): Use it. This doesn't change behavior, but saves
4527 a few bytes and will simplify future changes.
4528 * character.c (string_escape_byte8): Likewise.
4529 * lisp.h (string_overflow): New decl.
4531 Fixups, following up to the user-interface timestamp change.
4532 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4533 for UI timestamps, instead of unsigned long.
4534 * msdos.c (mouse_get_pos): Likewise.
4535 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4536 * w32gui.h (Time): Define by including "systime.h" rather than by
4537 declaring it ourselves. (Bug#8664)
4539 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4540 * image.c (clear_image_cache): Likewise.
4542 * term.c (term_mouse_position): Don't assume time_t wraparound.
4544 Be more systematic about user-interface timestamps.
4545 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4546 and sometimes 'EMACS_UINT', to represent these timestamps.
4547 This change causes it to use 'Time' uniformly, as that's what X uses.
4548 This makes the code easier to follow, and makes it easier to catch
4549 integer overflow bugs such as Bug#8664.
4550 * frame.c (Fmouse_position, Fmouse_pixel_position):
4551 Use Time, not unsigned long, for user-interface timestamps.
4552 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4553 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4554 * keyboard.h (last_event_timestamp): Likewise.
4555 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4556 * menu.h (xmenu_show): Likewise.
4557 * term.c (term_mouse_position): Likewise.
4558 * termhooks.h (struct input_event.timestamp): Likewise.
4559 (struct terminal.mouse_position_hook): Likewise.
4560 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4561 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4562 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4563 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4565 * menu.h, termhooks.h: Include "systime.h", for Time.
4567 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4568 Don't assume that the difference between two unsigned long values
4569 can fit into an integer. At this point, we know button_down_time
4570 <= event->timestamp, so the difference must be nonnegative, so
4571 there's no need to cast the result if double-click-time is
4572 nonnegative, as it should be; check that it's nonnegative, just in
4573 case. This bug is triggered when events are more than 2**31 ms
4574 apart (about 25 days). (Bug#8664)
4576 * xselect.c (last_event_timestamp): Remove duplicate decl.
4577 (x_own_selection): Remove needless cast to unsigned long.
4579 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4580 that always fit in int. Use a sentinel instead of a counter, to
4581 avoid a temp and to allay GCC's concerns about possible int overflow.
4582 * frame.h (struct frame): Use int for menu_bar_items_used
4583 instead of EMACS_INT, since it always fits in int.
4585 * menu.c (grow_menu_items): Check for int overflow.
4587 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4589 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4590 Before, the code was not consistent. These values cannot exceed
4591 2**31 - 1 so there's no need to make them unsigned.
4592 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4593 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4594 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4596 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4598 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4599 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4600 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4601 presumably because the widths might not match.
4603 * window.c (size_window): Avoid needless test at loop start.
4605 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4607 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4609 2011-05-12 Drew Adams <drew.adams@oracle.com>
4611 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4613 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4615 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4616 `width' to `bar_area_x' and `bar_area_width', respectively.
4617 (x_scroll_run): Take account of fringe background extension.
4619 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4620 Rename local vars `left' and `width' to `bar_area_x' and
4621 `bar_area_width', respectively.
4622 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4623 background extension.
4625 2011-05-10 Jim Meyering <meyering@redhat.com>
4627 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4629 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4631 * image.c (Finit_image_library): Return t for built-in image types,
4632 like pbm and xbm. (Bug#8640)
4634 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4636 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4638 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4640 * w32console.c (Fset_screen_color): Doc fix.
4641 (Fget_screen_color): New function.
4642 (syms_of_ntterm): Defsubr it.
4644 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4645 unlink the temporary file if Fcall_process didn't create it in the
4647 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4648 child process will be redirected to a file specified with `:file'.
4649 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4650 cue to call_process_cleanup not to close that handle.
4652 2011-05-07 Ben Key <bkey76@gmail.com>
4654 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4655 one of two shell specific rules, either bootstrap-temacs-CMD or
4656 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4657 to the previous implementation of the bootstrap-temacs rule.
4658 The bootstrap-temacs-CMD rule is similar to the previous
4659 implementation of the bootstrap-temacs rule except that it
4660 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4663 These changes, along with some changes to nt/configure.bat,
4664 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4665 earlier fix to add support for --cflags and --ldflags options
4666 that include quotes so that it works whether make uses cmd or
4669 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4671 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4672 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4674 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4675 a string. Handle both cases.
4676 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4677 (Fdbus_register_method): Use Qinvalid_function.
4679 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4681 * makefile.w32-in: Update dependencies.
4682 (LISP_H): Add inttypes.h and stdin.h.
4683 (PROCESS_H): Add unistd.h.
4685 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4687 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4688 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4690 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4692 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4694 * term.c (vfatal): Remove stray call to va_end.
4695 It's not needed and the C Standard doesn't allow it here anyway.
4697 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4698 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4700 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4703 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4705 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4707 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4709 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4711 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4713 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4714 * charset.c (Fdefine_charset_internal): Don't initialize
4715 charset.code_space[15]. The value was garbage, on hosts with
4716 32-bit int (Bug#8600).
4718 * lread.c (read_integer): Be more consistent with string-to-number.
4719 Use string_to_number to do the actual conversion; this avoids
4720 rounding errors and fixes some other screwups. Without this fix,
4721 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4722 (digit_to_number): Move earlier, for benefit of read_integer.
4723 Return -1 if the digit is out of range for the base, -2 if it is
4724 not a digit in any supported base. (Bug#8602)
4726 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4728 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4729 to match comment at start of function. This also removes a
4730 GCC warning about overflow in a 32+64-bit port.
4732 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4734 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4735 Reported by Stefan Monnier in
4736 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4737 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4738 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4740 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4741 (EMACS_UINTPTR): Likewise, with uintptr_t.
4743 * lisp.h: Prefer 64-bit EMACS_INT if available.
4744 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4745 on 32-bit hosts that have 64-bit int, so that they can access
4747 However, temporarily disable this change unless the temporary
4748 symbol WIDE_EMACS_INT is defined.
4750 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4752 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4753 This removes an assumption that EMACS_INT and long are the same
4754 width as pointers. The assumption is true for Emacs porting targets
4755 now, but we want to make other targets possible.
4756 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4757 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4758 In the rest of the code, change types of integers that hold casted
4759 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4760 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4761 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4762 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4763 No need to cast type when ORing.
4764 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4765 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4766 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4767 assume EMACS_INT is the same width as char *.
4768 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4769 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4770 Remove no-longer-needed casts.
4771 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4772 (xg_tool_bar_help_callback, xg_make_tool_item):
4773 Use EMACS_INTPTR to hold an integer
4774 that will be cast to void *; this can avoid a GCC warning
4775 if EMACS_INT is not the same width as void *.
4776 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4777 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4778 (current_message_1, set_message_1):
4779 Use a local to convert to proper width without a cast.
4780 * xmenu.c (dialog_selection_callback): Likewise.
4782 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4783 Also, don't assume VALBITS / RAND_BITS is less than 5,
4784 and don't rely on undefined behavior when shifting a 1 left into
4786 * lisp.h (get_random): Change signature to match.
4788 * lread.c (hash_string): Use size_t, not int, for hash computation.
4789 Normally we prefer signed values; but hashing is special, because
4790 it's better to use unsigned division on hash table sizes so that
4791 the remainder is nonnegative. Also, size_t is the natural width
4792 for hashing into memory. The previous code used 'int', which doesn't
4793 retain enough info to hash well into very large tables.
4794 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4796 * dbusbind.c: Don't possibly lose pointer info when converting.
4797 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4798 Use XPNTR rather than XHASH, so that the high-order bits of
4799 the pointer aren't lost when converting through void *.
4801 * eval.c (Fautoload): Don't double-shift a pointer.
4803 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4805 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4807 * gnutls.c (DEF_GNUTLS_FN):
4808 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4810 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4812 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4815 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4817 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4818 New version that can reserve upto 2GB of heap space.
4820 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4822 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4824 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4826 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4827 `gnutls_certificate_set_x509_key_file'.
4829 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4831 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4832 Update dependencies.
4834 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4836 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4837 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4838 Remove unused parameter `fildes'.
4839 * process.c (read_process_output, send_process): Don't pass it.
4841 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4843 Fix previous change: the library cache is defined in w32.c.
4844 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4845 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4847 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4849 Implement dynamic loading of GnuTLS on Windows.
4851 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4852 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4853 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4856 * gnutls.c (Qgnutls_dll): Define.
4857 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4858 (gnutls_*): Declare function pointers.
4859 (init_gnutls_functions): New function to initialize function pointers.
4860 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4861 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4862 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4863 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4864 (emacs_gnutls_write, emacs_gnutls_read)
4865 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4866 (Fgnutls_available_p): New function.
4867 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4868 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4869 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4871 * image.c: Include w32.h.
4872 (Vimage_type_cache): Delete.
4873 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4874 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4875 (w32_delayed_load): Move to w32.c.
4877 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4879 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4880 (w32_delayed_load): Move from image.c. When loading a library, record
4881 its filename in the :loaded-from property of the library id.
4882 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4883 Initialize and staticpro them.
4884 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4886 * process.c: Include lisp.h before w32.h, not after.
4887 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4888 instead of gnutls_record_check_pending.
4890 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4892 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4894 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4895 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4898 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4900 * xterm.c (x_set_frame_alpha): Do not set property on anything
4901 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4903 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4905 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4907 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4909 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4910 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4911 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4912 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4913 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4914 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4915 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4916 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4917 (Qgnutls_bootprop_callbacks_verify): Make static.
4919 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4921 * callproc.c: Indentation fixup.
4923 * sysdep.c (wait_for_termination_1): Make static.
4924 (wait_for_termination, interruptible_wait_for_termination):
4925 Move after wait_for_termination_1.
4927 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4929 * sysdep.c (interruptible_wait_for_termination): New function
4930 which is like wait_for_termination, but allows keyboard
4933 * callproc.c (Fcall_process): Add (:file "file") as an option for
4935 (Fcall_process_region): Ditto.
4937 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4939 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4940 rather than `XVECTOR (FOO)->size'.
4942 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4943 inttypes.h, as a gnulib replacement is used if it not available in
4946 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4948 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4949 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4950 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4952 * coding.c (coding_alloc_by_realloc): Error out if destination
4953 will grow beyond MOST_POSITIVE_FIXNUM.
4954 (decode_coding_emacs_mule): Abort if there isn't enough place in
4955 charbuf for the composition carryover bytes. Reserve an extra
4956 space for up to 2 characters produced in a loop.
4957 (decode_coding_iso_2022): Abort if there isn't enough place in
4958 charbuf for the composition carryover bytes.
4960 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4962 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4963 aborting when %lld or %lll format is passed.
4964 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4965 %llo or %llx format is passed. (Bug#8545)
4967 * window.c (window_scroll_line_based): Use a marker instead of
4968 simple variables to record original value of point. (Bug#7952)
4970 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4971 produced by %s or %c overflows available buffer space. (Bug#8545)
4973 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4975 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4976 (SIZE_MAX): Move defn after all includes, as they might #define it.
4978 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4980 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4982 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4984 * keyboard.c (Qdelayed_warnings_hook): Define.
4985 (command_loop_1): Run `delayed-warnings-hook'
4986 if Vdelayed_warnings_list is non-nil.
4987 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4988 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4990 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4992 * doprnt.c (doprnt): Don't return value smaller than the buffer
4993 size if the message was truncated. (Bug#8545).
4995 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4997 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4998 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5000 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5002 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5004 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5006 * makefile.w32-in: Update dependencies.
5008 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5010 Improve `doprnt' and its usage. (Bug#8545)
5011 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5012 `format_end'. Remove support for %l as a conversion specifier.
5013 Don't use xrealloc. Improve diagnostics when the %l size modifier
5014 is used. Update the commentary.
5016 * eval.c (verror): Simplify calculation of size_t.
5018 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5021 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5023 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5026 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5028 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5029 This makes this file independent of the recent pseudovector change.
5031 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5033 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5035 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5036 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5037 Remove unused local.
5038 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5040 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5041 GCC 4.6.0 optimizes based on type-based alias analysis.
5042 For example, if b is of type struct buffer * and v of type struct
5043 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5044 != &v->size, and therefore "v->size = 1; b->size = 2; return
5045 v->size;" must therefore return 1. This assumption is incorrect
5046 for Emacs, since it type-puns struct Lisp_Vector * with many other
5047 types. To fix this problem, this patch adds a new type struct
5048 vectorlike_header that documents the constraints on layout of vectors
5049 and pseudovectors, and helps optimizing compilers not get fooled
5050 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5051 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5052 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5054 (XSETPVECTYPE): Rewrite in terms of new macro.
5055 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5056 This is a bit clearer, and further avoids the possibility of
5057 undesirable aliasing.
5058 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5059 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5060 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5061 since Lisp_Subr is a special case (no "next" field).
5062 (ASIZE): Now uses header.size rather than size.
5063 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5064 to avoid the hassle of writing XVECTOR (foo)->header.size.
5065 (struct vectorlike_header): New type.
5066 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5067 object, to help avoid aliasing.
5068 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5069 (SUBRP): Likewise, since Lisp_Subr is a special case.
5070 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5071 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5072 (struct Lisp_Hash_Table): Combine first two members into a single
5073 struct vectorlike_header member. All uses of "size" and "next" members
5074 changed to be "header.size" and "header.next".
5075 * buffer.h (struct buffer): Likewise.
5076 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5077 * frame.h (struct frame): Likewise.
5078 * process.h (struct Lisp_Process): Likewise.
5079 * termhooks.h (struct terminal): Likewise.
5080 * window.c (struct save_window_data, struct saved_window): Likewise.
5081 * window.h (struct window): Likewise.
5082 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5083 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5084 * buffer.c (init_buffer_once): Likewise.
5085 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5087 * process.c (Fformat_network_address): Use local var for size,
5090 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5092 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5093 * data.c (atof): Remove decl; no longer used or needed.
5094 (digit_to_number): Move to lread.c.
5095 (Fstring_to_number): Use new string_to_number function, to be
5096 consistent with how the Lisp reader treats infinities and NaNs.
5097 Do not assume that floating-point numbers represent EMACS_INT
5098 without losing information; this is not true on most 64-bit hosts.
5099 Avoid double-rounding errors, by insisting on integers when
5100 parsing non-base-10 numbers, as the documentation specifies.
5101 * lisp.h (string_to_number): New decl, replacing ...
5102 (isfloat_string): Remove.
5103 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5104 (read1): Do not accept +. and -. as integers; this
5105 appears to have been a coding error. Similarly, do not accept
5106 strings like +-1e0 as floating point numbers. Do not report
5107 overflow for integer overflows unless the base is not 10 which
5108 means we have no simple and reliable way to continue.
5109 Break out the floating-point parsing into a new
5110 function string_to_number, so that Fstring_to_number parses
5111 floating point numbers consistently with the Lisp reader.
5112 (digit_to_number): Move here from data.c. Make it static inline.
5113 (E_CHAR, EXP_INT): Remove, replacing with ...
5114 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5115 (string_to_number): New function, replacing isfloat_string.
5116 This function checks for valid syntax and produces the resulting
5117 Lisp float number too. Rework it so that string-to-number
5118 no longer mishandles examples like "1.0e+". Use strtoumax,
5119 so that overflow for non-base-10 numbers is reported only when
5120 there's no portable and simple way to convert to floating point.
5122 * textprop.c (set_text_properties_1): Rewrite for clarity,
5123 and to avoid GCC warning about integer overflow.
5125 * intervals.h (struct interval): Use EMACS_INT for members
5126 where EMACS_UINT might cause problems. See
5127 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5128 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5129 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5131 (offset_intervals): Tell GCC not to worry about length overflow
5132 when negating a negative length.
5134 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5135 (overrun_check_free): Likewise.
5137 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5138 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5141 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5142 (gnutls_make_error): Rename local to avoid shadowing.
5143 (gnutls_emacs_global_deinit): ifdef out; not used.
5144 (Fgnutls_boot): Use const for pointer to readonly storage.
5145 Comment out unused local. Fix pointer signedness problems.
5147 * lread.c (openp): Don't stuff size_t into an 'int'.
5148 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5149 about possible signed overflow.
5151 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5152 (GDK_KEY_g): Don't define if already defined.
5153 (xg_prepare_tooltip): Avoid pointer signedness problem.
5154 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5156 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5157 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5159 * xfns.c (Fx_window_property): Simplify a bit,
5160 to make a bit faster and to avoid GCC 4.6.0 warning.
5161 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5163 * fns.c (internal_equal): Don't assume size_t fits in int.
5165 * alloc.c (compact_small_strings): Tighten assertion a little.
5167 Replace pEd with more-general pI, and fix some printf arg casts.
5168 * lisp.h (pI): New macro, generalizing old pEd macro to other
5169 conversion specifiers. For example, use "...%"pI"d..." rather
5170 than "...%"pEd"...".
5171 (pEd): Remove. All uses replaced with similar uses of pI.
5172 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5173 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5174 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5175 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5176 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5177 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5178 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5180 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5181 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5182 * print.c (safe_debug_print, print_object): Likewise.
5183 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5185 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5186 avoiding the 0 flag, which is not portable.
5187 * process.c (Fmake_network_process): Use pI to avoid cast.
5188 * region-cache.c (pp_cache): Likewise.
5189 * xdisp.c (decode_mode_spec): Likewise.
5190 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5191 behavior on 64-bit hosts with printf arg.
5192 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5193 (x_stop_queuing_selection_requests): Likewise.
5194 (x_get_window_property): Don't truncate byte count to an 'int'
5197 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5198 here, since it parses constructs like leading '-' and spaces,
5199 which are not wanted; and it overflows with large numbers.
5200 Instead, simply match F[0-9]+, which is what is wanted anyway.
5202 * alloc.c: Remove unportable assumptions about struct layout.
5203 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5204 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5205 (allocate_vectorlike, make_pure_vector): Use the new macros,
5206 plus offsetof, to remove unportable assumptions about struct layout.
5207 These assumptions hold on all porting targets that I know of, but
5208 they are not guaranteed, they're easy to remove, and removing them
5209 makes further changes easier.
5211 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5212 This doesn't fix a bug but makes the code clearer.
5213 (string_overrun_cookie): Now const. Use initializers that
5214 don't formally overflow signed char, to avoid warnings.
5215 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5216 can cause Emacs to crash when string overrun checking is enabled.
5217 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5218 multiple of sizeof (EMACS_INT); it need not be, if
5219 alignof(EMACS_INT) < sizeof (EMACS_INT).
5220 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5222 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5224 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5226 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5228 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5229 supposed to be handshaking. (Bug#8556)
5230 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5232 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5234 * lisp.h (Qdebug): List symbol.
5235 * eval.c (Qdebug): Restore global linkage.
5236 * keyboard.c (debug-on-event): New variable.
5237 (handle_user_signal): Break into debugger when debug-on-event
5238 matches the current signal symbol.
5240 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5242 * alloc.c (check_sblock, check_string_bytes)
5243 (check_string_free_list): Convert to standard C.
5245 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5247 * w32.c (emacs_gnutls_push): Fix typo.
5249 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5251 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5252 "cast to pointer from integer of different size".
5254 Improve doprnt and its use in verror. (Bug#8545)
5255 * doprnt.c (doprnt): Document the set of format control sequences
5256 supported by the function. Use SAFE_ALLOCA instead of always
5259 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5260 is one byte too soon. Don't use xrealloc; instead xfree and
5263 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5265 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5268 * gnutls.c: Renamed global_initialized to
5269 gnutls_global_initialized. Added internals for the
5270 :verify-hostname-error, :verify-error, and :verify-flags
5271 parameters of `gnutls-boot' and documented those parameters in the
5272 docstring. Start callback support.
5273 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5274 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5275 on error. Return error code.
5276 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5277 (emacs_gnutls_read): Likewise.
5278 (Fgnutls_boot): Return handshake error code.
5279 (emacs_gnutls_handle_error): New function.
5280 (wsaerror_to_errno): Likewise.
5282 * w32.h (emacs_gnutls_pull): Add prototype.
5283 (emacs_gnutls_push): Likewise.
5285 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5286 (emacs_gnutls_push): Likewise.
5288 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5290 * process.c (wait_reading_process_output): Check if GnuTLS
5291 buffered some data internally if no FDs are set for TLS
5294 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5295 (LIBS): Link to USER_LIBS.
5296 ($(BLD)/gnutls.$(0)): New target.
5298 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5300 * xdisp.c (handle_single_display_spec): Rename the
5301 display_replaced_before_p argument into display_replaced_p, to
5302 make it consistent with the commentary. Fix typos in the
5305 * textprop.c (syms_of_textprop): Remove dead code.
5306 (copy_text_properties): Delete obsolete commentary about an
5307 interface that was deleted long ago. Fix typos in the description
5310 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5311 to changes in oldXMenu/XMenu.h from 2011-04-16.
5312 <menu_help_message, prev_menu_help_message>: Constify.
5313 (IT_menu_make_room): menu->help_text is now `const char **';
5316 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5317 to changes in oldXMenu/XMenu.h from 2011-04-16.
5318 (struct XMenu): Declare `help_text' `const char **'.
5320 * xfaces.c <Qunspecified>: Make extern again.
5322 * syntax.c: Include sys/types.h before including regex.h, as
5325 * doc.c (get_doc_string): Improve the format passed to `error'.
5327 * doprnt.c (doprnt): Improve commentary.
5329 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5331 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5334 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5335 changes in globals.h immediately force recompilation.
5336 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5337 $(CURDIR)/s/ms-w32.h.
5338 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5340 * character.c (Fchar_direction): Function deleted.
5341 (syms_of_character): Don't defsubr it.
5342 <char-direction-table>: Deleted.
5344 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5346 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5347 * doprnt.c: Include limits.h.
5348 (SIZE_MAX): New macro.
5349 (doprnt): Return a size_t value. 2nd arg is now size_t.
5350 Many local variables are now size_t instead of int or unsigned.
5351 Improve overflow protection. Support `l' modifier for integer
5352 conversions. Support %l conversion. Don't assume an EMACS_INT
5353 argument for integer conversions and for %c.
5355 * lisp.h (doprnt): Restore prototype.
5357 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5360 * Makefile.in (base_obj): Add back doprnt.o.
5362 * deps.mk (doprnt.o): Add back prerequisites.
5363 (callint.o): Depend on character.h.
5365 * eval.c (internal_lisp_condition_case): Include the handler
5366 representation in the error message.
5367 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5368 when breaking from the loop.
5370 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5372 * callint.c (Fcall_interactively): When displaying error message
5373 about invalid control letter, pass the character's codepoint, not
5374 a pointer to its multibyte form. Improve display of the character
5375 in octal and display also its hex code.
5377 * character.c (char_string): Use %x to display the (unsigned)
5378 codepoint of an invalid character, to avoid displaying a bogus
5381 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5382 `error', not SYMBOL_NAME itself.
5384 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5385 character arguments to `error'.
5387 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5388 to `error' in error message about FINAL_CHAR argument. Make sure
5389 FINAL_CHAR is a character, and use %c when it is passed as
5390 argument to `error'.
5392 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5394 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5396 * w32.c: Include <time.h>.
5397 (sys_localtime): New function.
5399 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5401 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5403 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5405 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5407 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5410 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5412 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5413 gl_state.e_property when gl_state.object is Qt.
5415 * insdel.c (make_gap_larger): Remove limitation of buffer size
5418 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5420 * xdisp.c (lookup_glyphless_char_display)
5421 (produce_glyphless_glyph): Handle cons cell entry in
5422 glyphless-char-display.
5423 (Vglyphless_char_display): Document it.
5425 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5426 glyphless-char-display.
5428 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5430 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5432 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5434 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5435 definition for no-X builds.
5437 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5439 Static checks with GCC 4.6.0 and non-default toolkits.
5441 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5443 * process.c (keyboard_bit_set): Define only if SIGIO.
5444 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5445 (send_process): Repair possible setjmp clobbering.
5447 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5449 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5451 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5453 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5454 Define only if needed.
5456 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5457 by pacifying GCC about it. Maybe it's time to retire it?
5458 * xfaces.c (USG, __TIMEVAL__): Likewise.
5460 * dispextern.h (struct redisplay_interface): Rename param
5462 * termhooks.h (struct terminal): Likewise.
5463 * xterm.c (xembed_send_message): Likewise.
5465 * insdel.c (make_gap_smaller): Define only if
5466 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5468 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5471 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5472 so that we aren't warned about unused symbols.
5474 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5476 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5478 * xfns.c (x_real_positions): Mark locals as initialized.
5480 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5482 * xterm.c: Fix problems found by static analysis with other toolkits.
5483 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5484 (x_dispatch_event): Declare static if USE_GTK, and
5485 define if USE_GTK || USE_X_TOOLKIT.
5486 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5487 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5488 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5489 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5491 * xmenu.c (menu_help_callback): Pointer type fixes.
5492 Use const pointers when pointing at readonly data. Avoid pointer
5494 (FALSE): Remove unused macro.
5495 (update_frame_menubar): Remove unused decl.
5497 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5499 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5500 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5501 (single_menu_item): Rename local to avoid shadowing.
5503 * keyboard.c (make_lispy_event): Remove unused local var.
5505 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5506 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5508 * bitmaps: Change bitmaps from unsigned char back to the X11
5509 compatible char. Avoid the old compiler warnings about
5510 out-of-range initializers by using, for example, '\xab' rather
5513 * xgselect.c (xgselect_initialize): Check vs interface
5514 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5516 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5518 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5519 to read-only memory.
5521 * fns.c (vector): Remove; this old hack is no longer needed.
5523 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5525 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5527 * xrdb.c (x_load_resources): Omit unused local.
5529 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5530 (x_window): Rename locals to avoid shadowing.
5531 (USG): Use the kludged USG macro, to pacify gcc.
5533 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5534 (x_term_init): Remove local to avoid shadowing.
5536 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5538 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5539 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5541 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5543 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5545 Fix regex.c, syntax.c and friends for buffers > 2GB.
5546 * syntax.h (struct gl_state_s): Declare character position members
5549 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5551 * textprop.c (verify_interval_modification, interval_of):
5552 Declare arguments EMACS_INT.
5554 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5557 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5559 * indent.c (Fvertical_motion): Local variable it_start is now
5562 * regex.c (re_match, re_match_2, re_match_2_internal)
5563 (bcmp_translate, regcomp, regexec, print_double_string)
5564 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5565 (re_compile_pattern, re_exec): Declare arguments and local
5566 variables `size_t' and `ssize_t' and return values `regoff_t', as
5568 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5569 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5570 <compile_stack_type>: `size' and `avail' are now `size_t'.
5572 * regex.h <regoff_t>: Use ssize_t, not int.
5573 (re_search, re_search_2, re_match, re_match_2): Arguments that
5574 specify buffer/string position and length are now ssize_t and
5575 size_t. Return type is regoff_t.
5577 2011-04-16 Ben Key <bkey76@gmail.com>
5579 * nsfont.m: Fixed bugs in ns_get_family and
5580 ns_descriptor_to_entity that were caused by using free to
5581 deallocate memory blocks that were allocated by xmalloc (via
5582 xstrdup). This caused Emacs to crash when compiled with
5583 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5584 --enable-checking=xmallocoverrun). xfree is now used to
5585 deallocate these memory blocks.
5587 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5589 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5591 emacs_write: Accept and return EMACS_INT for sizes.
5592 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5594 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5595 Accept and return EMACS_INT.
5596 (emacs_gnutls_write): Return the number of bytes written on
5598 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5599 (emacs_read, emacs_write): Remove check for negative size, as the
5600 Emacs source code has been audited now.
5601 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5602 (emacs_read, emacs_write): Use it.
5603 * process.c (send_process): Adjust to the new signatures of
5604 emacs_write and emacs_gnutls_write. Do not attempt to store
5605 a byte offset into an 'int'; it might overflow.
5606 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5608 * sound.c: Don't assume sizes fit in 'int'.
5609 (struct sound_device.period_size, alsa_period_size):
5610 Return EMACS_INT, not int.
5611 (struct sound_device.write, vox_write, alsa_write):
5612 Accept EMACS_INT, not int.
5613 (wav_play, au_play): Use EMACS_INT to store sizes and to
5614 record read return values.
5616 2011-04-15 Ben Key <bkey76@gmail.com>
5618 * keyboard.c (Qundefined): Don't declare static since it is used
5620 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5621 static since they are used in nsfont.m.
5623 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5625 * process.c (Qprocessp): Don't declare static.
5626 * lisp.h (Qprocessp): Declare again.
5628 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5630 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5632 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5634 Improve C-level modularity by making more things 'static'.
5636 Don't publish debugger-only interfaces to other modules.
5637 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5638 (verify_bytepos, count_markers): Move decls to the only modules
5640 * region-cache.h (pp_cache): Likewise.
5641 * window.h (check_all_windows): Likewise.
5642 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5644 * sysdep.c (croak): Now static, if
5645 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5646 * syssignal.h (croak): Declare only if not static.
5648 * alloc.c (refill_memory_reserve): Now static if
5649 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5650 * lisp.h (refill_memory_reserve): Declare only if not static.
5652 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5653 Define only if USE_LUCID.
5655 * xrdb.c (x_customization_string, x_rm_string): Now static.
5657 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5658 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5660 * xdisp.c (draw_row_with_mouse_face): Now static.
5661 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5663 * window.h (check_all_windows): Mark externally visible.
5665 * window.c (window_deletion_count): Now static.
5667 * undo.c: Make symbols static if they're not exported.
5668 (last_undo_buffer, last_boundary_position, pending_boundary):
5671 * textprop.c (interval_insert_behind_hooks): Now static.
5672 (interval_insert_in_front_hooks): Likewise.
5674 * term.c: Make symbols static if they're not exported.
5675 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5676 (max_frame_lines, tty_set_terminal_modes):
5677 (tty_reset_terminal_modes, tty_turn_off_highlight):
5678 (get_tty_terminal): Now static.
5679 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5680 * termhooks.h (term_mouse_moveto): Do not declare if
5682 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5683 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5685 * sysdep.c: Make symbols static if they're not exported.
5686 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5688 (sigprocmask_set, full_mask): Remove; unused.
5689 (wait_debugging): Mark as visible.
5690 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5691 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5693 * syntax.c (syntax_temp): Define only if !__GNUC__.
5695 * sound.c (current_sound_device, current_sound): Now static.
5697 * search.c (searchbufs, searchbuf_head): Now static.
5699 * scroll.c (scroll_cost): Remove; unused.
5700 * dispextern.h (scroll_cost): Remove decl.
5702 * region-cache.h (pp_cache): Mark as externally visible.
5704 * process.c: Make symbols static if they're not exported.
5705 (process_tick, update_tick, create_process, chan_process):
5706 (Vprocess_alist, proc_buffered_char, datagram_access):
5707 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5708 (deactivate_process): Mark defn as static, as well as decl.
5709 * lisp.h (create_process): Remove decl.
5710 * process.h (chan_process, Vprocess_alist): Remove decls.
5712 * print.c: Make symbols static if they're not exported.
5713 (print_depth, new_backquote_output, being_printed, print_buffer):
5714 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5715 (print_interval, print_number_index, initial_stderr_stream):
5717 * lisp.h (Fprinc): Remove decl.
5718 (debug_output_compilation_hack): Mark as externally visible.
5720 * sysdep.c (croak): Move decl from here to syssignal.h.
5721 * syssignal.h (croak): Put it here, so the API can be checked when
5722 'croak' is called from dissociate_if_controlling_tty.
5724 * minibuf.c: Make symbols static if they're not exported.
5725 (minibuf_save_list, choose_minibuf_frame): Now static.
5726 * lisp.h (choose_minibuf_frame): Remove decl.
5728 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5730 * lread.c: Make symbols static if they're not exported.
5731 (read_objects, initial_obarray, oblookup_last_bucket_number):
5733 (make_symbol): Remove; unused.
5734 * lisp.h (initial_obarray, make_symbol): Remove decls.
5736 * keyboard.c: Make symbols static if they're not exported.
5737 (single_kboard, recent_keys_index, total_keys, recent_keys):
5738 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5739 (this_single_command_key_start, echoing, last_auto_save):
5740 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5741 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5742 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5743 (Vlispy_mouse_stem, double_click_count):
5745 (force_auto_save_soon): Define only if SIGDANGER.
5746 (ignore_mouse_drag_p): Now static if
5747 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5748 (print_help): Remove; unused.
5749 (stop_character, last_timer_event): Mark as externally visible.
5750 * keyboard.h (ignore_mouse_drag_p): Declare only if
5751 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5752 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5753 * lisp.h (echoing): Remove decl.
5754 (force_auto_save_soon): Declare only if SIGDANGER.
5755 * xdisp.c (redisplay_window): Simplify code, to make it more
5756 obvious that ignore_mouse_drag_p is not accessed if !defined
5757 USE_GTK && !defined HAVE_NS.
5759 * intervals.c: Make symbols static if they're not exported.
5760 (merge_properties_sticky, merge_interval_right, delete_interval):
5762 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5764 * insdel.c: Make symbols static if they're not exported.
5765 However, leave prepare_to_modify_buffer alone. It's never
5766 called from outside this function, but that appears to be a bug.
5767 (combine_after_change_list, combine_after_change_buffer):
5768 (adjust_after_replace, signal_before_change): Now static.
5769 (adjust_after_replace_noundo): Remove; unused.
5770 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5771 (signal_before_change): Remove decls.
5773 * indent.c (val_compute_motion, val_vmotion): Now static.
5775 * image.c: Make symbols static if they're not exported.
5776 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5778 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5779 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5781 * fringe.c (standard_bitmaps): Now static.
5782 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5784 * frame.c: Make symbols static if they're not exported.
5785 (x_report_frame_params, make_terminal_frame): Now static.
5786 (get_frame_param): Now static, unless HAVE_NS.
5787 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5788 (x_get_resource_string): Remove; not used.
5789 * frame.h (make_terminal_frame, x_report_frame_params):
5790 (x_get_resource_string); Remove decls.
5791 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5792 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5794 * font.c, fontset.c: Make symbols static if they're not exported.
5795 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5796 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5797 * font.c (font_close_object): Now static.
5798 * font.h (font_close_object): Remove.
5799 * fontset.c (FONTSET_OBJLIST): Remove.
5800 (free_realized_fontset) #if-0 the body, which does nothing.
5801 (face_suitable_for_char_p): #if-0, as it's never called.
5802 * fontset.h (face_suitable_for_char_p): Remove decl.
5803 * xfaces.c (face_at_string_position):
5804 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5805 since 0 is always ASCII.
5807 * fns.c (weak_hash_tables): Now static.
5809 * fileio.c: Make symbols static if they're not exported.
5810 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5811 (Vwrite_region_annotation_buffers): Now static.
5813 * eval.c: Make symbols static if they're not exported.
5814 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5815 * lisp.h (backtrace_list): Remove decl.
5817 * emacs.c: Make symbols static if they're not exported.
5818 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5819 (fatal_error_code, fatal_error_signal_hook, standard_args):
5821 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5822 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5823 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5824 * lisp.h (fatal_error_signal_hook): Remove decl.
5825 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5827 * editfns.c: Move a (normally-unused) function to its only use.
5828 * editfns.c, lisp.h (get_operating_system_release): Remove.
5829 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5830 worth the hassle of breaking this out.
5832 * xterm.c: Make symbols static if they're not exported.
5833 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5834 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5835 (x_destroy_window, x_delete_display):
5837 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5838 (x_mouse_leave): Remove; unused.
5839 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5840 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5841 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5843 (x_mouse_leave): Declare only if WINDOWSNT.
5844 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5845 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5848 * ftxfont.c: Make symbols static if they're not exported.
5849 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5851 * font.h (ftxfont_driver): Likewise.
5853 * xfns.c: Make symbols static if they're not exported.
5854 (x_last_font_name, x_display_info_for_name):
5855 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5856 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5857 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5858 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5859 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5860 (last_show_tip_args): Now static.
5861 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5862 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5863 (x_screen_planes): Remove; unused.
5864 * dispextern.h (x_screen_planes): Remove decl.
5866 * dispnew.c: Make symbols static if they're not exported.
5867 * dispextern.h (redraw_garbaged_frames, scrolling):
5868 (increment_row_positions): Remove.
5869 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5870 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5872 (redraw_garbaged_frames): Remove; unused.
5874 * xfaces.c: Make symbols static if they're not exported.
5875 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5877 * xterm.h (defined_color): Remove decls.
5878 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5879 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5880 (menu_face_changed_default, defined_color, free_realized_face):
5881 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5882 (ascii_face_of_lisp_face): Remove; unused.
5884 * xdisp.c: Make symbols static if they're not exported.
5885 * dispextern.h (scratch_glyph_row, window_box_edges):
5886 (glyph_to_pixel_coords, set_cursor_from_row):
5887 (get_next_display_element, set_iterator_to_next):
5888 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5889 (show_mouse_face): Remove decls
5890 * frame.h (message_buf_print): Likewise.
5891 * lisp.h (pop_message, set_message, check_point_in_composition):
5893 * xterm.h (set_vertical_scroll_bar): Likewise.
5894 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5895 (message_buf_print, scratch_glyph_row, displayed_buffer):
5896 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5897 (get_next_display_element, show_mouse_face, window_box_edges):
5898 (frame_to_window_pixel_xy, check_point_in_composition):
5899 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5900 (glyph_to_pixel_coords): Remove; unused.
5902 * dired.c (file_name_completion): Now static.
5904 * dbusbind.c (xd_in_read_queued_messages): Now static.
5906 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5907 * data.c (circular_list_error): Remove.
5909 * commands.h (last_point_position, last_point_position_buffer):
5910 (last_point_position_window): Remove decls.
5911 * keyboard.c: Make these variables static.
5913 * coding.h (coding, code_convert_region, encode_coding_gap):
5915 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5916 (iso_code_class, detect_coding, code_convert_region): Now static.
5917 (encode_coding_gap): Remove; unused.
5919 * chartab.c (chartab_chars, chartab_bits): Now static.
5921 * charset.h (charset_iso_8859_1): Remove decl.
5922 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5925 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5926 * ccl.c (Vccl_program_table): Now static.
5927 (check_ccl_update): Remove; unused.
5929 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5930 * category.h: ... from here.
5931 * category.c (check_category_table, set_category_set): Now static.
5933 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5934 * lisp.h: Remove these decls.
5936 * buffer.c (buffer_count): Remove unused var.
5938 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5939 so that it's not optimized away.
5940 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5941 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5942 exported only to the debugger.
5944 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5945 * atimer.h (run_all_atimers): Remove; not exported.
5947 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5948 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5949 was inaccessible from Lisp.
5950 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5951 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5953 alloc.c: Import and export fewer symbols, and remove unused items.
5954 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5956 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5957 it's not optimized away by whole-program optimization.
5958 (message_enable_multibyte, free_misc): Remove.
5959 (catchlist, handlerlist, mark_backtrace):
5960 Declare only if BYTE_MARK_STACK.
5961 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5962 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5963 (message_enable_multibyte): Remove decl.
5964 (free_misc, interval_free_list, float_block, float_block_index):
5965 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5966 (cons_free_list, last_marked_index):
5968 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5969 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5970 (mark_backtrace): Define only if BYTE_MARK_STACK.
5971 * xdisp.c (message_enable_multibyte): Now static.
5973 Declare Lisp_Object Q* variables to be 'static' if not exported.
5974 This makes it easier for human readers (and static analyzers)
5975 to see whether these variables are used from other modules.
5976 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5977 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5978 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5979 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5980 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5981 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5982 * xmenu.c, xselect.c:
5983 Declare Q* vars static if they are not used in other modules.
5984 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5985 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5986 Remove decls of unexported vars.
5987 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5989 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5991 Make Emacs functions such as Fatom 'static' by default.
5992 This makes it easier for human readers (and static analyzers)
5993 to see whether these functions can be called from other modules.
5994 DEFUN now defines a static function. To make the function external
5995 so that it can be used in other C modules, use the new macro DEFUE.
5996 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5997 (Finit_image_library):
5998 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5999 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6000 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6001 Remove decls, since these functions are now static.
6002 (Funintern, Fget_internal_run_time): New decls, since these functions
6003 were already external.
6005 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6006 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6007 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6008 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6009 * keyboard.c, keymap.c, lread.c:
6010 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6011 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6012 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6013 Mark functions with DEFUE instead of DEFUN,
6014 if they are used in other modules.
6015 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6016 decls for now-static functions.
6017 * buffer.h (Fdelete_overlay): Remove decl.
6018 * callproc.c (Fgetenv_internal): Mark as internal.
6019 * composite.c (Fremove_list_of_text_properties): Remove decl.
6020 (Fcomposition_get_gstring): New forward static decl.
6021 * composite.h (Fcomposite_get_gstring): Remove decl.
6022 * dired.c (Ffile_attributes): New forward static decl.
6023 * doc.c (Fdocumntation_property): New forward static decl.
6024 * eval.c (Ffetch_bytecode): New forward static decl.
6025 (Funintern): Remove extern decl; now in .h file where it belongs.
6026 * fileio.c (Fmake_symbolic_link): New forward static decl.
6027 * image.c (Finit_image_library): New forward static decl.
6028 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6029 * intervals.h (Fprevious_property_change):
6030 (Fremove_list_of_text_properties): Remove decls.
6031 * keyboard.c (Fthis_command_keys): Remove decl.
6032 (Fcommand_execute): New forward static decl.
6033 * keymap.c (Flookup_key): New forward static decl.
6034 (Fcopy_keymap): Now static.
6035 * keymap.h (Flookup_key): Remove decl.
6036 * process.c (Fget_process): New forward static decl.
6037 (Fprocess_datagram_address): Mark as internal.
6038 * syntax.c (Fsyntax_table_p): New forward static decl.
6039 (skip_chars): Remove duplicate decl.
6040 * textprop.c (Fprevious_property_change): New forward static decl.
6041 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6043 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6044 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6046 * editfns.c (Fformat): Remove unreachable code.
6048 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6050 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6053 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6055 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6056 when at ZV. (Bug#8487)
6058 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6060 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6062 * keyboard.c (parse_tool_bar_item): Likewise.
6063 * sound.c (sound_cleanup, alsa_close): Likewise.
6064 * termcap.c (tgetent): Likewise.
6065 * xfns.c (x_default_font_parameter): Likewise.
6066 * xsettings.c (read_and_apply_settings): Likewise.
6068 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6069 (overrun_check_free): Protoize.
6071 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6073 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6074 since callers should never pass a negative size.
6075 Change the signature to match that of plain 'read' and 'write'; see
6076 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6077 * lisp.h: Update prototypes of emacs_write and emacs_read.
6079 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6081 * xdisp.c (redisplay_window): Don't try to determine the character
6082 position of the scroll margin if the window start point w->startp
6083 is outside the buffer's accessible region. (Bug#8468)
6085 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6087 Fix write-region and its subroutines for buffers > 2GB.
6088 * fileio.c (a_write, e_write): Modify declaration of arguments and
6089 local variables to support buffers larger than 2GB.
6090 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6092 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6093 argument, local variables, and return value.
6095 * lisp.h: Update prototypes of emacs_write and emacs_read.
6097 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6099 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6101 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6103 Fix more problems found by GCC 4.6.0's static checks.
6105 * xdisp.c (vmessage): Use a better test for character truncation.
6107 * charset.c (load_charset_map): <, not <=, for optimization,
6108 and to avoid potential problems with integer overflow.
6109 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6110 * casetab.c (set_identity, shuffle): Likewise.
6111 * editfns.c (Fformat): Likewise.
6112 * syntax.c (skip_chars): Likewise.
6114 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6115 This also lets GCC 4.6.0 generate slightly better loop code.
6117 * callint.c (Fcall_interactively): <, not <=, for optimization.
6118 (Fcall_interactively): Count the number of arguments produced,
6119 not the number of arguments given. This is simpler and lets GCC
6120 4.6.0 generate slightly better code.
6122 * ftfont.c: Distingish more carefully between FcChar8 and char.
6123 The previous code passed unsigned char * to a functions like
6124 strlen and xstrcasecmp that expect char *, which does not
6125 conform to the C standard.
6126 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6127 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6128 char * when the C standard requires it.
6130 * keyboard.c (read_char): Remove unused var.
6132 * eval.c: Port to Windows vsnprintf (Bug#8435).
6134 (SIZE_MAX): Define if the headers do not.
6135 (verror): Do not give up if vsnprintf returns a negative count.
6136 Instead, grow the buffer. This ports to Windows vsnprintf, which
6137 does not conform to C99. Problem reported by Eli Zaretskii.
6138 Also, simplify the allocation scheme, by avoiding the need for
6139 calling realloc, and removing the ALLOCATED variable.
6141 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6143 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6144 But keep the doprint source code for now, as we might revamp it
6145 and use it again (Bug#8435).
6146 * lisp.h (doprnt): Remove.
6147 * Makefile.in (base_obj): Remove doprnt.o.
6148 * deps.mk (doprnt.o): Remove.
6150 error: Print 32- and 64-bit integers portably (Bug#8435).
6151 Without this change, on typical 64-bit hosts error ("...%d...", N)
6152 was used to print both 32- and 64-bit integers N, which relied on
6154 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6156 * lisp.h (error, verror): Mark as printf-like functions.
6157 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6158 Report overflow in size calculations when allocating printf buffer.
6159 Do not truncate output string at its first null byte.
6160 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6161 Truncate the output at a character boundary, since vsnprintf does not
6163 * charset.c (check_iso_charset_parameter): Convert internal
6164 character to string before calling 'error', since %c now has the
6166 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6167 overflow when computing char to be passed to 'error'. Do not
6168 pass Lisp_Object to 'error'; pass the integer instead.
6169 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6170 formatted with plain %d.
6172 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6174 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6176 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6178 * xterm.c (x_catch_errors): Remove duplicate declaration.
6180 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6182 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6184 2011-04-10 Jim Meyering <meyering@redhat.com>
6186 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6187 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6188 return ssize_t not "int", and use size_t as the buffer length.
6189 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6190 * gnutls.h: Update declarations.
6191 * process.c (read_process_output): Use ssize_t, to match.
6192 (send_process): Likewise.
6194 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6196 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6198 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6200 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6201 Use unsigned char, to match FcChar8 type definition.
6203 * xterm.c (handle_one_xevent):
6204 * xmenu.c (create_and_show_popup_menu):
6205 * xselect.c (x_decline_selection_request)
6206 (x_reply_selection_request): Avoid type-punned deref of X events.
6208 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6210 Fix some uses of `int' instead of EMACS_INT.
6211 * search.c (string_match_1, fast_string_match)
6212 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6213 (scan_buffer, find_next_newline_no_quit)
6214 (find_before_next_newline, search_command, Freplace_match)
6215 (Fmatch_data): Make some `int' variables be EMACS_INT.
6217 * xdisp.c (display_count_lines): 3rd argument and return value now
6218 EMACS_INT. All callers changed.
6219 (pint2hrstr): Last argument is now EMACS_INT.
6221 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6222 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6223 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6224 (decode_coding_utf_16, decode_coding_emacs_mule)
6225 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6226 (decode_coding_ccl, decode_coding_charset)
6227 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6228 (decode_coding_iso_2022, decode_coding_emacs_mule)
6229 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6230 <char_offset, last_offset>: Declare EMACS_INT.
6231 (encode_coding_utf_8, encode_coding_utf_16)
6232 (encode_coding_emacs_mule, encode_invocation_designation)
6233 (encode_designation_at_bol, encode_coding_iso_2022)
6234 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6235 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6237 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6238 (encode_invocation_designation): Last argument P_NCHARS is now
6240 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6241 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6243 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6246 * ccl.c (Fccl_execute_on_string): Declare some variables
6249 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6251 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6253 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6255 * process.c (Fformat_network_address): Doc fix.
6257 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6259 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6261 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6263 * keyboard.c (read_char): Call Lisp function help-form-show,
6264 instead of using internal_with_output_to_temp_buffer.
6265 (Qhelp_form_show): New var.
6266 (syms_of_keyboard): Use DEFSYM macro.
6268 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6270 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6272 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6274 * process.c (Flist_processes): Remove to Lisp.
6275 (list_processes_1): Delete.
6277 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6279 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6281 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6283 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6285 Fix more problems found by GCC 4.6.0's static checks.
6287 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6289 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6291 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6293 * xdisp.c (vmessage): Mark as a printf-like function.
6295 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6297 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6299 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6300 printf-like functions.
6301 (tiff_load): Add casts to remove these marks before passing them
6302 to system-supplied API.
6304 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6306 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6307 This avoids several warnings with gcc -Wstrict-overflow.
6308 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6309 directly, rather than having caller test rule sign. This avoids
6310 some unnecessary tests.
6311 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6312 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6313 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6315 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6316 (xfont_open): Avoid unnecessary tests.
6318 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6320 * composite.h, composite.c (composition_gstring_put_cache):
6321 Use EMACS_INT, not int, for length.
6323 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6324 breaking out part of COMPOSITION_DECODE_RULE.
6325 (COMPOSITION_DECODE_RULE): Use it.
6326 * composite.c (get_composition_id): Remove unused local vars,
6327 by using the new macro.
6329 * textprop.c (set_text_properties_1): Change while to do-while,
6330 since the condition is always true at first.
6332 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6333 (interval_deletion_adjustment): Return unsigned value.
6336 * process.c (list_processes_1, create_pty, read_process_output):
6337 (exec_sentinel): Remove vars that were set but not used.
6338 (create_pty): Remove unnecessary "volatile"s.
6339 (Fnetwork_interface_info): Avoid possibility of int overflow.
6340 (read_process_output): Do adaptive read buffering even if carryover.
6341 (read_process_output): Simplify nbytes computation if buffered.
6343 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6345 * syntax.c (scan_words): Remove var that was set but not used.
6346 (update_syntax_table): Use unsigned instead of int.
6348 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6349 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6350 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6352 * print.c (print_error_message): Avoid int overflow.
6354 * font.c (font_list_entities): Redo for clarity,
6355 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6357 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6358 (font_score): Avoid potential overflow in diff calculation.
6360 * fns.c (substring_both): Remove var that is set but not used.
6361 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6363 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6365 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6366 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6367 can always succeed if overflow has undefined behavior.
6369 * search.c (boyer_moore, wordify): Remove vars set but not used.
6370 (wordify): Omit three unnecessary tests.
6372 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6373 All callers changed. This avoids the need for an unused var.
6375 * casefiddle.c (casify_region): Remove var that is set but not used.
6377 * dired.c (file_name_completion): Remove var that is set but not used.
6379 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6381 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6382 (Finsert_file_contents): Remove unnecessary code checking fd.
6384 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6385 Check for integer overflow on size calculations.
6387 * buffer.c (Fprevious_overlay_change): Remove var that is set
6390 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6391 Remove vars that are set but not used.
6392 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6393 (timer_check_2): Mark vars as initialized.
6395 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6397 * image.c (lookup_image): Remove var that is set but not used.
6398 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6400 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6401 that are set but not used.
6403 * xfns.c (make_invisible_cursor): Don't return garbage
6404 if XCreateBitmapFromData fails (Bug#8410).
6406 * xselect.c (x_get_local_selection, x_handle_property_notify):
6407 Remove vars that are set but not used.
6409 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6410 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6412 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6413 Remove var that is set but not used.
6414 (scroll_bar_windows_size): Now size_t, not int.
6415 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6418 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6419 (map_tty_color) [!defined MSDOS]: Likewise.
6421 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6423 * coding.c: Remove vars that are set but not used.
6424 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6425 All callers changed.
6426 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6427 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6428 (decode_coding_charset): Remove vars that are set but not used.
6430 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6431 that is set but not used.
6433 * print.c (print_object): Remove var that is set but not used.
6435 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6436 The gnulib version avoids calling malloc in the usual case,
6437 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6438 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6439 * filelock.c (current_lock_owner): Likewise.
6440 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6441 * sysdep.c: Include allocator.h, careadlinkat.h.
6442 (emacs_no_realloc_allocator): New static constant.
6443 (emacs_readlink): New function.
6444 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6445 ../lib/careadlinkat.h.
6447 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6449 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6450 first non-nil return value).
6452 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6454 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6455 if not defined (Bug#8403).
6457 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6459 * xdisp.c (display_count_lines): Remove parameter `start',
6460 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6461 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6462 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6463 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6464 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6465 and thereabouts. All callers changed.
6466 (get_per_char_metric): Remove parameter `f', unused since
6467 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6469 2011-04-02 Jim Meyering <meyering@redhat.com>
6471 do not dereference NULL upon failed strdup
6472 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6473 (ns_get_family): Likewise.
6475 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6477 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6479 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6481 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6484 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6486 Add lexical binding.
6488 * window.c (Ftemp_output_buffer_show): New fun.
6489 (Fsave_window_excursion):
6490 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6492 * lread.c (lisp_file_lexically_bound_p): New function.
6493 (Fload): Bind Qlexical_binding.
6494 (readevalloop): Remove `evalfun' arg.
6495 Bind Qinternal_interpreter_environment.
6496 (Feval_buffer): Bind Qlexical_binding.
6497 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6499 (syms_of_lread): Declare `lexical-binding'.
6501 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6503 * keyboard.c (eval_dyn): New fun.
6504 (menu_item_eval_property): Use it.
6506 * image.c (parse_image_spec): Use Ffunctionp.
6508 * fns.c (concat, mapcar1): Accept byte-code-functions.
6510 * eval.c (Fsetq): Handle lexical vars.
6511 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6512 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6513 (FletX, Flet): Obey lexical binding.
6514 (Fcommandp): Handle closures.
6515 (Feval): New `lexical' arg.
6516 (eval_sub): New function extracted from Feval. Use it almost
6517 everywhere where Feval was used. Look up vars in lexical env.
6519 (Ffunctionp): Move from subr.el.
6520 (Ffuncall): Handle closures.
6521 (apply_lambda): Remove `eval_flags'.
6522 (funcall_lambda): Handle closures and new byte-code-functions.
6523 (Fspecial_variable_p): New function.
6524 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6525 but without exporting it to Lisp.
6527 * doc.c (Fdocumentation, store_function_docstring):
6528 * data.c (Finteractive_form): Handle closures.
6530 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6533 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6535 (exec_byte_code): New function extracted from Fbyte_code to handle new
6536 calling convention for byte-code-functions. Add new byte-codes.
6538 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6540 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6542 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6544 * xdisp.c (redisplay_internal): Fix prototype.
6546 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6548 * xdisp.c (SCROLL_LIMIT): New macro.
6549 (try_scrolling): Use it when setting scroll_limit.
6550 Limit scrolling to 100 screen lines.
6551 (redisplay_window): Even when falling back on "recentering",
6552 position point in the window according to scroll-conservatively,
6553 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6555 (try_scrolling): When point is above the window, allow searching
6556 as far as scroll_max, or one screenful, to compute vertical
6557 distance from PT to the scroll margin position. This prevents
6558 try_scrolling from unnecessarily failing when
6559 scroll-conservatively is set to a value slightly larger than the
6560 window height. Clean up the case of PT below the margin at bottom
6561 of window: scroll_max can no longer be INT_MAX. When aggressive
6562 scrolling is in use, don't let point enter the opposite scroll
6563 margin as result of the scroll.
6564 (syms_of_xdisp) <scroll-conservatively>: Document the
6565 threshold of 100 lines for never-recentering scrolling.
6567 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6569 * dispextern.h (move_it_by_lines):
6570 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6571 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6572 (message_log_check_duplicate): Remove parameters `prev_bol' and
6573 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6574 (redisplay_internal): Remove parameter `preserve_echo_area',
6575 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6577 * indent.c (Fvertical_motion):
6578 * window.c (window_scroll_pixel_based, Frecenter):
6579 Don't pass `need_y_p' to `move_it_by_lines'.
6581 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6583 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6584 steal a few bits to be more compact.
6585 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6586 Remove unneeded casts.
6588 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6590 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6592 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6593 binding" message (bug#7967).
6595 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6597 Fix more problems found by GCC 4.6.0's static checks.
6599 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6600 Remove unused local var.
6602 * editfns.c (Fmessage_box): Remove unused local var.
6604 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6605 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6606 Omit unused local vars.
6607 * window.c (shrink_windows): Omit unused local var.
6608 * menu.c (digest_single_submenu): Omit unused local var.
6609 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6610 Omit unused local var.
6612 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6613 Don't assume string length fits in int.
6614 (keyremap_step, read_key_sequence): Use size_t for sizes.
6615 (read_key_sequence): Don't check last_real_key_start redundantly.
6617 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6618 instead of alloca (Bug#8344).
6620 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6621 (Fbacktrace_frame): Don't assume nframes fits in int.
6623 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6625 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6628 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6630 * cm.c (calccost): Turn while-do into do-while, for clarity.
6632 * keyboard.c (syms_of_keyboard): Use the same style as later
6633 in this function when indexing through an array. This also
6634 works around GCC bug 48267.
6636 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6638 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6640 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6641 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6643 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6644 This avoids undefined behavior on integer overflow, and is a bit
6645 more convenient anyway since it is compared to a size_t variable.
6647 Variadic C functions now count arguments with size_t, not int.
6648 This avoids an unnecessary limitation on 64-bit machines, which
6649 caused (substring ...) to crash on large vectors (Bug#8344).
6650 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6651 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6652 All variadic functions and their callers changed accordingly.
6653 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6654 * data.c (arith_driver, float_arith_driver): Likewise.
6655 * editfns.c (general_insert_function): Likewise.
6656 * eval.c (struct backtrace.nargs, interactive_p)
6657 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6658 (funcall_lambda, mark_backtrace): Likewise.
6659 * fns.c (concat): Likewise.
6660 * frame.c (x_set_frame_parameters): Likewise.
6661 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6662 0 if not found, not -1. All callers changed.
6664 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6665 (stack_copy_size): Now size_t, not int.
6666 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6668 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6670 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6671 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6672 All callers changed.
6674 * lisp.h (multibyte_char_to_unibyte):
6675 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6676 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6677 * character.h (CHAR_TO_BYTE8):
6678 * cmds.c (internal_self_insert):
6679 * editfns.c (general_insert_function):
6680 * keymap.c (push_key_description):
6681 * search.c (Freplace_match):
6682 * xdisp.c (message_dolog, set_message_1): All callers changed.
6684 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6686 * keyboard.c (safe_run_hook_funcall): New function.
6687 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6688 don't set the hook to nil, but remove the offending function instead.
6689 (Qcommand_hook_internal): Remove, unused.
6690 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6691 Vcommand_hook_internal.
6693 * eval.c (enum run_hooks_condition): Remove.
6694 (funcall_nil, funcall_not): New functions.
6695 (run_hook_with_args): Call each function through a `funcall' argument.
6696 Remove `cond' argument, now redundant.
6697 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6698 (Frun_hook_with_args_until_failure): Adjust accordingly.
6699 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6701 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6703 * dispextern.h (string_buffer_position): Remove declaration.
6705 * print.c (strout): Remove parameter `multibyte', unused since
6706 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6708 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6709 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6710 All callers changed.
6712 * w32.c (_wsa_errlist): Use braces for struct initializers.
6714 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6715 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6716 All callers changed.
6717 (string_buffer_position): Likewise. Also, make static (it's never
6718 used outside xdisp.c).
6719 (cursor_row_p): Remove parameter `w', unused since
6720 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6721 (decode_mode_spec): Remove parameter `precision', introduced during
6722 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6723 All callers changed.
6725 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6727 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6729 2011-03-27 Anders Lindgren <andlind@gmail.com>
6731 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6732 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6733 (ns_update_auto_hide_menu_bar): New functions.
6734 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6735 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6736 ns_constrain_all_frames.
6737 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6738 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6740 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6742 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6744 2011-03-27 Glenn Morris <rgm@gnu.org>
6746 * syssignal.h: Replace RETSIGTYPE with void.
6747 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6748 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6749 Replace SIGTYPE with void everywhere.
6750 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6751 * s/template.h (SIGTYPE): Remove commented out definition.
6753 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6755 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6756 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6758 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6760 * w32.c (read_unc_volume): Use parameter `henum', instead of
6761 global variable `wget_enum_handle'.
6763 * keymap.c (describe_vector): Remove parameters `indices' and
6764 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6765 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6767 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6769 * keyboard.c (timer_check): Remove parameter `do_it_now',
6770 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6771 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6772 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6774 * keyboard.c (read_char):
6775 * w32menu.c (w32_menu_display_help):
6776 * xmenu.c (show_help_event, menu_help_callback):
6777 Adjust calls to `show_help_echo'.
6779 * gtkutil.c (xg_maybe_add_timer):
6780 * keyboard.c (readable_events):
6781 * process.c (wait_reading_process_output):
6782 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6784 * insdel.c (adjust_markers_gap_motion):
6785 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6786 (gap_left, gap_right): Don't call it.
6788 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6790 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6791 incurred during fontification.
6793 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6795 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6796 (DEFVAR_PER_BUFFER): Don't pass it.
6798 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6799 (scrolling_window): Don't pass it.
6801 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6803 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6805 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6807 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6808 of variables specific to SELinux and computation of `encoded_absname'.
6810 * image.c (XPutPixel): Remove unused variable `height'.
6812 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6814 * unexw32.c (get_section_info): Remove unused variable `section'.
6816 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6817 (system_process_attributes): Remove unused variable `sess'.
6818 (sys_read): Remove unused variable `err'.
6820 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6821 (w32_wnd_proc): Remove unused variable `isdead'.
6822 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6823 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6824 (x_create_tip_frame): Remove unused variable `tem'.
6826 * w32inevt.c (w32_console_read_socket):
6827 Remove unused variable `no_events'.
6829 * w32term.c (x_draw_composite_glyph_string_foreground):
6830 Remove unused variable `width'.
6832 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6834 * w32term.c (x_set_glyph_string_clipping):
6835 Don't pass uninitialized region to CombineRgn.
6837 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6839 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6840 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6841 (Fx_close_connection): Remove unused variable `i'.
6843 * w32font.c (w32font_draw): Return number of glyphs.
6844 (w32font_open_internal): Remove unused variable `i'.
6845 (w32font_driver): Add missing initializer.
6847 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6848 (fill_in_menu): Remove unused variable `items_added'.
6850 * w32term.c (last_mouse_press_frame): Remove static global variable.
6851 (w32_clip_to_row): Remove unused variable `f'.
6852 (x_delete_terminal): Remove unused variable `i'.
6854 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6855 (NOTHING): Remove unused static global variable.
6856 (uniscribe_check_otf): Remove unused variable `table'.
6857 (uniscribe_font_driver): Add missing initializers.
6859 2011-03-23 Julien Danjou <julien@danjou.info>
6861 * term.c (Fsuspend_tty, Fresume_tty):
6862 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6863 * window.c (temp_output_buffer_show):
6864 * insdel.c (signal_before_change):
6865 * frame.c (Fhandle_switch_frame):
6866 * fileio.c (Fdo_auto_save):
6867 * emacs.c (Fkill_emacs):
6868 * editfns.c (save_excursion_restore):
6869 * cmds.c (internal_self_insert):
6870 * callint.c (Fcall_interactively):
6871 * buffer.c (Fkill_all_local_variables):
6872 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6874 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6875 unconditionnaly since it does the check itself.
6877 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6879 Fix more problems found by GCC 4.5.2's static checks.
6881 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6882 the first time through the loop, since we know p0 < p1 then.
6883 This also avoids a gcc -Wstrict-overflow warning.
6885 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6886 leading to a memory leak, possible in functions like
6887 load_charset_map_from_file that can allocate an unbounded number
6888 of objects (Bug#8318).
6890 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6891 that could (at least in theory) be that large.
6893 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6894 This is less likely to overflow, and avoids undefined behavior if
6895 overflow does occur. All callers changed. Use strtoul to scan
6896 for the unsigned long integer.
6897 (pint2hrstr): Simplify and tune code slightly.
6898 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6900 * scroll.c (do_scrolling): Work around GCC bug 48228.
6901 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6903 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6904 This also avoids a warning with gcc -Wstrict-overflow.
6905 (validate_x_resource_name): Simplify count usage.
6906 This also avoids a warning with gcc -Wstrict-overflow.
6908 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6911 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6913 * process.c (Fmake_network_process): Use socklen_t, not int,
6914 where POSIX says socklen_t is required in portable programs.
6915 This fixes a porting bug on hosts like 64-bit HP-UX, where
6916 socklen_t is wider than int (Bug#8277).
6917 (Fmake_network_process, server_accept_connection):
6918 (wait_reading_process_output, read_process_output):
6921 * process.c: Rename or move locals to avoid shadowing.
6922 (list_processes_1, Fmake_network_process):
6923 (read_process_output_error_handler, exec_sentinel_error_handler):
6924 Rename or move locals.
6925 (Fmake_network_process): Define label "retry_connect" only if needed.
6926 (Fnetwork_interface_info): Fix pointer signedness.
6927 (process_send_signal): Add cast to avoid pointer signedness problem.
6928 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6929 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6931 Make tparam.h and terminfo.c consistent.
6932 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6933 Include tparam.h instead, since it declares them.
6934 * cm.h (PC): Remove extern decl; tparam.h now does this.
6935 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6936 * terminfo.c: Include tparam.h, to check interfaces.
6937 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6938 (tparam): Adjust signature to match interface in tparam.h;
6939 this removes some undefined behavior. Check that outstring and len
6940 are zero, which they always are with Emacs.
6941 * tparam.h (PC, BC, UP): New extern decls.
6943 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6944 (xftfont_open): Rename locals to avoid shadowing.
6946 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6947 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6948 (OTF_TAG_SYM): Omit macro if not needed.
6949 (ftfont_list): Remove unused local.
6950 (get_adstyle_property, ftfont_pattern_entity):
6951 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6952 Rename locals to avoid shadowing.
6954 * xfont.c (xfont_list_family): Mark var as initialized.
6956 * xml.c (make_dom): Now static.
6958 * composite.c (composition_compute_stop_pos): Rename local to
6960 (composition_reseat_it): Remove unused locals.
6961 (find_automatic_composition, composition_adjust_point): Likewise.
6962 (composition_update_it): Mark var as initialized.
6963 (find_automatic_composition): Mark vars as initialized,
6964 with a FIXME (Bug#8290).
6966 character.h: Rename locals to avoid shadowing.
6967 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6968 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6969 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6970 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6973 * textprop.c (property_change_between_p): Remove; unused.
6975 * intervals.c (interval_start_pos): Now static.
6977 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6979 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6980 Rename locals to avoid shadowing.
6982 * sound.c (wav_play, au_play, Fplay_sound_internal):
6983 Fix pointer signedness.
6984 (alsa_choose_format): Remove unused local var.
6985 (wav_play): Initialize a variable to 0, to prevent undefined
6986 behavior (Bug#8278).
6988 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6990 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6992 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6993 clobbering (Bug#8298).
6994 * sysdep.c (sys_subshell): Likewise.
6995 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6997 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6998 This should get cleaned up, so that child_setup has the
6999 same signature on all platforms.
7001 * callproc.c (call_process_cleanup): Now static.
7002 (relocate_fd): Rename locals to avoid shadowing.
7004 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7006 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7007 not to be necessary, and produces flickering.
7009 2011-03-20 Glenn Morris <rgm@gnu.org>
7011 * config.in: Remove file.
7013 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7015 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7016 are now in src/globals.h.
7017 (syms_of_minibuf): Remove spurious & from previous change.
7019 2011-03-20 Leo <sdl.web@gmail.com>
7021 * minibuf.c (completing-read-function): New variable.
7022 (completing-read-default): Rename from completing-read.
7023 (completing-read): Call completing-read-function.
7025 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7027 * xfaces.c (Fx_load_color_file):
7028 Read color file from absolute filename (bug#8250).
7030 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7032 * makefile.w32-in: Update dependencies.
7034 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7036 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7038 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7040 Fix more problems found by GCC 4.5.2's static checks.
7042 * process.c (make_serial_process_unwind, send_process_trap):
7043 (sigchld_handler): Now static.
7045 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7046 That way, the code declares only the vars that it needs.
7047 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7048 * s/cygwin.h (PTY_ITERATION): Likewise.
7049 * s/darwin.h (PTY_ITERATION): Likewise.
7050 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7052 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7053 * process.c (allocate_pty): Don't declare stb unless it's needed.
7055 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7056 (CONSTANTLIM): Remove; unused.
7057 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7058 Define only if needed.
7060 * unexelf.c (unexec): Name an expression,
7061 to avoid gcc -Wbad-function-cast warning.
7062 Use a different way to cause a compilation error if anyone uses
7063 n rather than nn, a way that does not involve shadowing.
7064 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7066 * deps.mk (unexalpha.o): Remove; unused.
7068 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7069 * unexec.h: New file.
7070 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7071 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7073 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7074 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7075 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7076 Change as necessary to match prototype in unexec.h.
7078 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7080 (back_comment, skip_chars): Mark vars as initialized.
7082 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7083 Rename locals to avoid shadowing.
7085 * lread.c (read1): Rewrite so as not to use empty "else".
7086 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7088 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7090 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7091 warning when compiling print.c.
7093 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7094 instead of using an uninitialized var.
7095 (font_sort_entities): Mark var as initialized.
7097 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7099 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7100 pointers to constants.
7101 (font_parse_fcname): Remove unused vars.
7102 (font_delete_unmatched): Now static.
7103 (font_get_spec): Remove; unused.
7104 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7105 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7106 Rename or move locals to avoid shadowing.
7108 * fns.c (require_nesting_list, require_unwind): Now static.
7109 (Ffillarray): Rename locals to avoid shadowing.
7111 * floatfns.c (domain_error2): Define only if needed.
7112 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7114 * alloc.c (mark_backtrace): Move decl from here ...
7115 * lisp.h: ... to here, so that it can be checked.
7117 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7118 (Fdefvar): Rewrite so as not to use empty "else".
7119 (lisp_indirect_variable): Name an expression,
7120 to avoid gcc -Wbad-function-cast warning.
7121 (Fdefvar): Rename locals to avoid shadowing.
7123 * callint.c (quotify_arg, quotify_args): Now static.
7124 (Fcall_interactively): Rename locals to avoid shadowing.
7125 Use const pointer when appropriate.
7127 * lisp.h (get_system_name, get_operating_system_release):
7128 Move decls here, to check interfaces.
7129 * process.c (get_operating_system_release): Move decl to lisp.h.
7130 * xrdb.c (get_system_name): Likewise.
7131 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7132 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7133 some of which prompt warnings from gcc -Wbad-function-cast.
7134 (Fformat_time_string, Fencode_time, Finsert_char):
7135 (Ftranslate_region_internal, Fformat):
7136 Rename or remove local vars to avoid shadowing.
7137 (Ftranslate_region_internal): Mark var as initialized.
7139 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7142 * lisp.h (eassert): Check that the argument compiles, even if
7143 ENABLE_CHECKING is not defined.
7145 * data.c (Findirect_variable): Name an expression, to avoid
7146 gcc -Wbad-function-cast warning.
7147 (default_value, arithcompare, arith_driver, arith_error): Now static.
7148 (store_symval_forwarding): Rename local to avoid shadowing.
7149 (Fmake_variable_buffer_local, Fmake_local_variable):
7150 Mark variables as initialized.
7151 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7153 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7154 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7155 Rename locals to avoid shadowing.
7156 (mark_stack): Move local variables into the #ifdef region where
7158 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7159 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7161 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7162 (GC_STRING_CHARS): Remove; not used.
7163 (Fmemory_limit): Cast sbrk's returned value to char *.
7165 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7166 avoids undefined behavior in theory.
7168 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7170 Use functions, not macros, for up- and down-casing (Bug#8254).
7171 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7172 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7173 to use the following functions instead of these macros.
7174 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7175 EMACS_INT, since callers assume the returned value fits in int.
7176 (upcase1): Likewise, for UPCASE_TABLE.
7177 (uppercasep, lowercasep, upcase): New static inline functions.
7178 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7179 the race-condition problem in the old DOWNCASE.
7181 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7182 Rename locals to avoid shadowing.
7183 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7184 (regex_compile, re_search_2, re_match_2_internal):
7185 Remove unused local vars.
7186 (FREE_VAR): Rewrite so as not to use empty "else",
7187 which gcc can warn about.
7188 (regex_compile, re_match_2_internal): Mark locals as initialized.
7189 (RETALLOC_IF): Define only if needed.
7190 (WORDCHAR_P): Likewise. This one is never needed, but is used
7191 only in a comment talking about a compiler bug, so put inside
7192 the #if 0 of that comment.
7193 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7194 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7197 * search.c (boyer_moore): Rename locals to avoid shadowing.
7198 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7199 (PREV_CHAR_BOUNDARY): Likewise.
7201 * search.c (simple_search): Remove unused var.
7203 * dired.c (compile_pattern): Move decl from here ...
7204 * lisp.h: ... to here, so that it can be checked.
7205 (struct re_registers): New forward decl.
7207 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7209 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7211 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7212 Rename locals to avoid shadowing.
7213 (Fvertical_motion): Mark locals as initialized.
7215 * casefiddle.c (casify_object, casify_region): Now static.
7216 (casify_region): Mark local as initialized.
7218 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7220 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7221 New macros, so that the caller can use some names other than
7222 gcpro1, gcpro2, etc.
7223 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7225 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7226 argument, for consistency with GCPRO2_VAR, etc: it is now the
7227 prefix of the variable, not the variable itself. All uses
7229 * dired.c (directory_files_internal, file_name_completion):
7230 Rename locals to avoid shadowing.
7232 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7233 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7234 dired.c's scmp function, had undefined behavior.
7235 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7236 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7237 * buffer.h: ... to here, because these macros use current_buffer,
7238 and the new implementation with inline functions needs to have
7239 current_buffer in scope now, rather than later when the macros
7241 (downcase, upcase1): New static inline functions.
7242 (DOWNCASE, UPCASE1): Reimplement using these functions.
7243 This avoids undefined behavior in expressions like
7244 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7245 from race conditions in accessing the global variables
7246 case_temp1 and case_temp2.
7247 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7248 * lisp.h (case_temp1, case_temp2): Remove their decls.
7249 * character.h (ASCII_CHAR_P): Move from here ...
7250 * lisp.h: ... to here, so that the inline functions mentioned
7253 * dired.c (directory_files_internal_unwind): Now static.
7255 * fileio.c (file_name_as_directory, directory_file_name):
7256 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7258 (file_name_as_directory): Use const pointers when appropriate.
7259 (Fexpand_file_name): Likewise. In particular, newdir might
7260 point at constant storage, so make it a const pointer.
7261 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7262 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7264 (Fset_file_times, Finsert_file_contents, auto_save_error):
7265 Rename locals to avoid shadowing.
7267 * minibuf.c (choose_minibuf_frame_1): Now static.
7268 (Ftry_completion, Fall_completions): Rename or remove locals
7271 * marker.c (bytepos_to_charpos): Remove; unused.
7273 * lisp.h (verify_bytepos, count_markers): New decls,
7274 so that gcc does not warn that these functions aren't declared.
7276 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7277 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7278 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7279 (copy_text): Remove unused local var.
7281 * filelock.c (within_one_second): Now static.
7282 (lock_file_1): Rename local to avoid shadowing.
7284 * buffer.c (fix_overlays_before): Mark locals as initialized.
7285 (fix_start_end_in_overlays): Likewise. This function should be
7286 simplified by using pointers-to-pointers, but that's a different
7288 (switch_to_buffer_1): Now static.
7289 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7290 (report_overlay_modification): Rename locals to avoid shadowing.
7292 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7293 Fix pointer signedness issue.
7294 (sys_subshell): Mark local as volatile if checking for lint,
7295 to suppress a gcc -Wclobbered warning that does not seem to be right.
7296 (MAXPATHLEN): Define only if needed.
7298 * process.c (serial_open, serial_configure): Move decls from here ...
7299 * systty.h: ... to here, so that they can be checked.
7301 * fns.c (get_random, seed_random): Move extern decls from here ...
7302 * lisp.h: ... to here, so that they can be checked.
7304 * sysdep.c (reset_io): Now static.
7305 (wait_for_termination_signal): Remove; unused.
7307 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7308 (copy_keymap_item, append_key, push_text_char_description):
7310 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7311 (DENSE_TABLE_SIZE): Remove; unused.
7312 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7313 (describe_map_tree):
7314 Rename locals to avoid shadowing.
7316 * keyboard.c: Declare functions static if they are not used elsewhere.
7317 (echo_char, echo_dash, cmd_error, top_level_2):
7318 (poll_for_input, handle_async_input): Now static.
7319 (read_char, kbd_buffer_get_event, make_lispy_position):
7320 (make_lispy_event, make_lispy_movement, apply_modifiers):
7321 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7322 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7323 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7324 (read_key_sequence, read_char): Mark locals as initialized.
7325 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7327 * keyboard.h (make_ctrl_char): New decl.
7328 (mark_kboards): Move decl here ...
7329 * alloc.c (mark_kboards): ... from here.
7331 * lisp.h (force_auto_save_soon): New decl.
7333 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7334 (DEFINE_DUMMY_FUNCTION): New macro.
7335 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7337 (main): Add casts to avoid warnings
7338 if GCC considers string literals to be constants.
7340 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7342 * dbusbind.c: Pointer signedness fixes.
7343 (xd_signature, xd_append_arg, xd_initialize):
7344 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7345 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7346 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7347 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7349 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7350 if GCC considers string literals to be constants.
7351 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7353 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7355 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7356 (print_preprocess, print_object): New macro to fix last change.
7358 * print.c (print_preprocess): Don't forget font objects.
7360 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7362 * emacs.c (USAGE3): Doc fixes.
7364 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7366 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7369 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7371 * lisp.h (VWindow_system, Qfile_name_history):
7372 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7373 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7374 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7376 * w32select.c: Don't #include "keyboard.h".
7377 (run_protected): Add extern declaration for waiting_for_input.
7379 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7380 * w32console.c (detect_input_pending, read_input_pending)
7381 (encode_terminal_code):
7382 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7383 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7384 (w32_system_caret_y, Qfile_name_history):
7385 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7386 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7387 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7388 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7389 * w32proc.c (Qlocal, report_file_error):
7390 * w32term.c (Vwindow_system, updating_frame):
7391 * w32uniscribe.c (initialized, uniscribe_font_driver):
7392 Remove unneeded extern declarations.
7394 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7396 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7398 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7400 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7401 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7402 These macros can no longer be used for assignment.
7404 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7405 Assign struct members directly, instead of using BUF_BEGV etc.
7406 (record_buffer_markers, fetch_buffer_markers): New functions for
7407 recording and fetching special buffer markers.
7408 (set_buffer_internal_1, set_buffer_temp): Use them.
7410 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7412 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7414 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7415 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7417 * xdisp.c (hscroll_window_tree):
7418 (reconsider_clip_changes): Use PT instead of BUF_PT.
7420 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7422 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7423 $(EMACS_ROOT)/lib/intprops.h.
7425 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7427 Fix more problems found by GCC 4.5.2's static checks.
7429 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7430 to unsigned char * to avoid compiler diagnostic.
7431 (xg_free_frame_widgets): Make it clear that a local variable is
7432 needed only if USE_GTK_TOOLTIP.
7433 (gdk_window_get_screen): Make it clear that this macro is needed
7434 only if USE_GTK_TOOLTIP.
7435 (int_gtk_range_get_value): New function, which avoids a diagnostic
7436 from gcc -Wbad-function-cast.
7437 (xg_set_toolkit_scroll_bar_thumb): Use it.
7438 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7439 diagnostic from gcc -Wbad-function-cast.
7440 (get_utf8_string, xg_get_file_with_chooser):
7441 Rename locals to avoid shadowing.
7442 (create_dialog): Move locals to avoid shadowing.
7444 * xgselect.c (xg_select): Remove unused var.
7446 * image.c (four_corners_best): Mark locals as initialized.
7447 (gif_load): Initialize transparent_p to zero (Bug#8238).
7448 Mark another local as initialized.
7449 (my_png_error, my_error_exit): Mark with NO_RETURN.
7451 * image.c (clear_image_cache): Now static.
7452 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7453 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7454 (x_edge_detection): Remove unnecessary cast that
7455 gcc -Wbad-function-cast diagnoses.
7456 (gif_load): Fix pointer signedness.
7457 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7458 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7460 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7462 Improve quality of tests for time stamp overflow.
7463 For example, without this patch (encode-time 0 0 0 1 1
7464 1152921504606846976) returns the obviously-bogus value (-948597
7465 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7466 reports time overflow. See
7467 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7468 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7469 * editfns.c: Include limits.h and intprops.h.
7470 (TIME_T_MIN, TIME_T_MAX): New macros.
7471 (time_overflow): Move earlier, to before first use.
7472 (hi_time, lo_time): New functions, for an accurate test for
7474 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7475 (Fget_internal_run_time): Don't assume time_t fits in int.
7476 (make_time): Use list2 instead of Fcons twice.
7477 (Fdecode_time): More accurate test for out-of-range times.
7478 (check_tm_member): New function.
7479 (Fencode_time): Use it, to test for out-of-range times.
7480 (lisp_time_argument): Don't rely on undefined left-shift and
7481 right-shift behavior when checking for time stamp overflow.
7483 * editfns.c (time_overflow): New function, refactoring common code.
7484 (Fformat_time_string, Fdecode_time, Fencode_time):
7485 (Fcurrent_time_string): Use it.
7487 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7488 * dired.c (make_time): Move to ...
7489 * editfns.c (make_time): ... here.
7490 * systime.h: Note the move.
7492 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7494 * fringe.c (update_window_fringes): Remove unused variables.
7496 * unexmacosx.c (copy_data_segment): Also copy __got section.
7499 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7501 * termcap.c [MSDOS]: Include "msdos.h".
7502 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7503 Constify `char *' arguments and their references according to
7504 prototypes in tparam.h.
7506 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7508 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7509 Adapt all references accordingly.
7511 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7513 2011-03-11 Tom Tromey <tromey@redhat.com>
7515 * buffer.c (syms_of_buffer): Remove obsolete comment.
7517 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7519 * termhooks.h (encode_terminal_code): Declare prototype.
7521 * msdos.c (encode_terminal_code): Don't declare prototype.
7523 * term.c (encode_terminal_code): Now external again, used by
7524 w32console.c and msdos.c.
7526 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7527 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7529 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7531 Fix some minor problems found by GCC 4.5.2's static checks.
7533 * fringe.c (update_window_fringes): Mark locals as initialized
7535 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7537 * alloc.c (mark_fringe_data): Move decl from here ...
7538 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7539 to check its interface.
7540 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7542 * fontset.c (free_realized_fontset): Now static.
7543 (Fset_fontset_font): Rename local to avoid shadowing.
7544 (fontset_font): Mark local as initialized.
7545 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7547 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7549 * xselect.c (x_disown_buffer_selections): Remove; not used.
7550 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7551 (x_own_selection, Fx_disown_selection_internal): Rename locals
7553 (x_handle_dnd_message): Remove local to avoid shadowing.
7555 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7556 so that the caller can use some name other than gcpro1.
7557 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7558 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7559 (Fx_backspace_delete_keys_p):
7560 Use them to avoid shadowing, and rename vars to avoid shadowing.
7561 (x_decode_color, x_set_name, x_window): Now static.
7562 (Fx_create_frame): Add braces to silence GCC warning.
7563 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7564 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7565 Remove unused locals.
7566 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7567 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7568 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7571 * xterm.h (x_mouse_leave): New decl.
7573 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7574 Remove unused functions.
7575 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7576 (x_calc_absolute_position): Now static.
7577 (XTread_socket): Don't define label "out" unless it's used.
7578 Don't declare local "event" unless it's used.
7579 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7580 unless they are used.
7581 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7582 (x_fatal_error_signal): Remove; not used.
7583 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7584 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7585 (x_error_catcher, x_connection_closed, x_error_handler):
7586 (x_error_quitter, xembed_send_message, x_iconify_frame):
7587 (my_log_handler): Rename locals to avoid shadowing.
7588 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7589 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7591 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7592 Rename or move locals to avoid shadowing.
7593 (tty_defined_color, merge_face_heights): Now static.
7594 (free_realized_faces_for_fontset): Remove; not used.
7595 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7596 does not deduce is never used uninitialized.
7597 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7598 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7600 * terminal.c (store_terminal_param): Now static.
7602 * xmenu.c (menu_highlight_callback): Now static.
7603 (set_frame_menubar): Remove unused local.
7604 (xmenu_show): Rename parameter to avoid shadowing.
7605 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7606 since they might point to immutable storage.
7607 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7608 since it's unused otherwise.
7610 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7611 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7612 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7613 avoids a gcc -Wuninitialized diagnostic.
7614 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7615 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7616 does not deduce are never used uninitialized.
7618 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7620 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7621 * window.c (window_loop, size_window):
7622 (run_window_configuration_change_hook, enlarge_window): Likewise.
7624 * window.c (display_buffer): Now static.
7625 (size_window): Mark variables that gcc -Wuninitialized
7626 does not deduce are never used uninitialized.
7627 * window.h (check_all_windows): New decl, to forestall
7628 gcc -Wmissing-prototypes diagnostic.
7629 * dispextern.h (bidi_dump_cached_states): Likewise.
7631 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7633 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7635 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7636 and to avoid gcc -Wuninitialized warning.
7637 (load_charset_map): Mark variables that gcc -Wuninitialized
7638 does not deduce are never used uninitialized.
7639 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7641 * coding.c (coding_set_source, coding_set_destination):
7642 Use "else { /* comment */ }" rather than "else /* comment */;"
7643 for clarity, and to avoid gcc -Wempty-body warning.
7644 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7645 a block, when the outer 'i' will do.
7646 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7647 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7648 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7649 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7650 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7651 Rename locals to avoid shadowing.
7652 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7653 * coding.c (emacs_mule_char, encode_invocation_designation):
7654 Now static, since they're not used elsewhere.
7655 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7656 (decode_coding_object, encode_coding_object, detect_coding_system):
7657 (decode_coding_emacs_mule): Mark variables that gcc
7658 -Wuninitialized does not deduce are never used uninitialized.
7659 (detect_coding_iso_2022): Initialize a local variable that might
7660 be used uninitialized. Leave a FIXME because it's not clear that
7661 this initialization is needed. (Bug#8211)
7662 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7663 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7664 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7665 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7666 Remove unused macros.
7668 * category.c (hash_get_category_set): Remove unused local var.
7669 (copy_category_table): Now static, since it's not used elsewhere.
7670 * character.c (string_count_byte8): Likewise.
7672 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7673 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7675 * chartab.c (copy_sub_char_table): Now static, since it's not used
7677 (sub_char_table_ref_and_range, char_table_ref_and_range):
7678 Rename locals to avoid shadowing.
7679 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7681 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7682 (BIDI_BOB): Remove unused macro.
7684 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7685 deduce are never used uninitialized.
7686 * term.c (encode_terminal_code): Likewise.
7688 * term.c (encode_terminal_code): Now static. Remove unused local.
7690 * tparam.h: New file.
7691 * term.c, tparam.h: Include it.
7692 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7693 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7694 Move these decls to tparam.h, and make them agree with what
7695 is actually in tparam.c. The previous trick of using incompatible
7696 decls in different modules does not conform to the C standard.
7697 All callers of tparam changed to use tparam's actual API.
7698 * tparam.c (tparam1, tparam, tgoto):
7699 Use const pointers where appropriate.
7701 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7702 * cm.h (struct cm): Likewise.
7703 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7704 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7705 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7706 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7707 (turn_on_face, init_tty): Likewise.
7708 * termchar.h (struct tty_display_info): Likewise.
7710 * term.c (term_mouse_position): Rename local to avoid shadowing.
7712 * alloc.c (mark_ttys): Move decl from here ...
7713 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7715 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7717 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7719 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7721 * search.c (compile_pattern_1): Remove argument regp, unused since
7722 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7723 (compile_pattern): Don't pass it.
7725 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7727 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7728 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7730 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7732 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7734 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7735 gdk_window_get_screen, gdk_window_get_geometry,
7736 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7737 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7738 (xg_get_pixbuf_from_pixmap): New function.
7739 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7740 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7741 Call xg_get_pixbuf_from_pixmap instead of
7742 gdk_pixbuf_get_from_drawable.
7743 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7744 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7745 (xg_check_special_colors): Use GtkStyleContext and its functions
7747 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7748 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7749 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7750 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7751 Call gtk_widget_get_preferred_size.
7752 (xg_frame_resized): gdk_window_get_geometry only takes 5
7754 (xg_win_to_widget, xg_event_is_for_menubar):
7755 Call gdk_x11_window_lookup_for_display.
7756 (xg_set_widget_bg): New function.
7757 (delete_cb): New function.
7758 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7759 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7760 (xg_set_background_color): Call xg_set_widget_bg.
7761 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7762 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7763 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7764 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7766 (update_frame_tool_bar): Call gtk_widget_hide.
7767 (xg_initialize): Use GDK_KEY_g.
7769 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7771 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7773 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7774 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7775 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7777 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7779 * w32xfns.c (select_palette): Check success of RealizePalette against
7780 GDI_ERROR, not zero.
7782 See ChangeLog.11 for earlier changes.
7788 Copyright (C) 2011 Free Software Foundation, Inc.
7790 This file is part of GNU Emacs.
7792 GNU Emacs is free software: you can redistribute it and/or modify
7793 it under the terms of the GNU General Public License as published by
7794 the Free Software Foundation, either version 3 of the License, or
7795 (at your option) any later version.
7797 GNU Emacs is distributed in the hope that it will be useful,
7798 but WITHOUT ANY WARRANTY; without even the implied warranty of
7799 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7800 GNU General Public License for more details.
7802 You should have received a copy of the GNU General Public License
7803 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.