1 2013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
3 * intervals.c (set_point_from_marker): New function.
4 * editfns.c (Fgoto_char):
5 * process.c (Finternal_default_process_filter):
6 * window.c (select_window_1): Use it.
7 * buffer.h (set_point_from_marker): Add prototype.
9 2013-08-29 Eli Zaretskii <eliz@gnu.org>
11 * w32.c (term_winsock): Call release_listen_threads before calling
13 (_sys_wait_accept): Wait for accept event in a loop with a finite
14 timeout, instead of waiting indefinitely. Will hopefully avoid
15 hanging during exit because WSACleanup deadlocks waiting for the
16 event object to be released. (Bug#14333)
18 * w32proc.c (release_listen_threads): New function, signals all
19 the reader threads that listen for connections to stop waiting.
21 * w32.h (release_listen_threads): Add prototype.
23 2013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
25 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
26 field of new marker (for sanity and safety).
27 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
28 anyway because XMISCTYPE is a function and can't be an lvalue).
30 2013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
32 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
33 (x_after_update_window_line, x_scroll_bar_create):
34 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
35 (handle_one_xevent, x_clear_frame_area):
36 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
37 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
38 * xterm.h (x_clear_area): Adjust prototype.
40 2013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
42 Hook scanning and indentation functions to find_newline. This helps
43 to avoid duplicated code and renders more respect to newline cache.
44 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
45 * cmds.c (Fforward_line):
46 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
47 Use find_newline and avoid unnecessary point movements.
48 * search.c (scan_newline): Implement on top of find_newline.
50 2013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
52 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
53 scoped code (bug#11258).
55 2013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
57 * nsterm.m (last_window): New variable.
58 (EV_TRAILER2): New macro.
59 (EV_TRAILER): Call EV_TRAILER2.
60 (mouseMoved:): Add support for mouse-autoselect-window
61 on nextstep (Bug#6888).
63 2013-08-28 Andreas Schwab <schwab@suse.de>
65 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
66 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
67 Remove unused macro definitions.
68 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
69 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
72 2013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
74 Prefer enum glyph_row_area to int where appropriate.
75 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
77 (window_box, window_box_width, window_box_left, window_box_left_offset)
78 (window_box_right, window_box_right_offset): Adjust prototypes.
79 * xdisp.c (window_box, window_box_width, window_box_left)
80 (window_box_left_offset, window_box_right, window_box_right_offset):
81 Use enum glyph_row_area. Adjust users and tweak comment where needed.
82 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
83 * nsterm.m (ns_clip_to_row):
84 * w32term.c (w32_clip_to_row):
85 * xterm.c (x_clip_to_row): Likewise.
87 2013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
89 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
90 (Fprevious_overlay_change): Fast path for buffer with no overlays.
92 2013-08-28 Paul Eggert <eggert@cs.ucla.edu>
94 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
95 for portability to hosts where /bin/sh has problems.
97 2013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
99 Redesign redisplay interface to drop global output_cursor.
100 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
101 (toplevel): Remove declaration of output_cursor.
102 (set_output_cursor, x_cursor_to): Remove prototype.
103 * window.h (struct window): New member output_cursor.
104 (output_cursor_to): New function to replace RIF member.
105 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
106 (update_text_area, set_window_cursor_after_update): Use it.
107 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
108 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
109 * nsterm.m (ns_update_window_begin, ns_update_window_end):
110 * w32term.c (x_update_window_begin, x_update_window_end):
111 * xterm.c (x_update_window_begin, x_update_window_end):
112 Adjust to use per-window output cursor.
114 2013-08-27 Paul Eggert <eggert@cs.ucla.edu>
116 Simplify SELECT_TYPE-related code.
117 Like EMACS_TIME, this portability layer is no longer needed, since
118 Emacs has been using fd_set as a portability layer for some time.
119 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
120 (SELECT_TYPE): Remove. All uses changed to fd_set.
121 (fd_set) [!FD_SET]: New typedef.
123 Simplify EMACS_TIME-related code.
124 This portability layer is no longer needed, since Emacs has been
125 using struct timespec as a portability layer for some time.
126 * atimer.h, buffer.h, dispextern.h, xgselect.h:
127 Include <time.h> rather than "systime.h"; that's all that's needed now.
128 * dispnew.c: Include <timespec.h> rather than "systime.h";
129 that's all that's needed now.
130 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
131 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
133 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
134 LOG10_TIMESPEC_RESOLUTION.
135 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
136 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
137 (make_emacs_time): Remove. All used changed to make_timespec.
138 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
139 (current_timespec): Rename from current_emacs_time. All uses changed.
140 (add_emacs_time): Remove. All uses changed to timespec_add.
141 (sub_emacs_time): Remove. All uses change dot timespec_sub.
142 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
143 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
144 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
145 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
146 (current_timespec): Rename from current_emacs_time. All uses changed.
147 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
148 changed to timespec_cmp.
149 * xgselect.c: Include <timespec.h>, since our .h files don't.
151 2013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
153 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
154 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
155 Remove the leftovers.
156 * gtkutil.c (toplevel): Do not declare Qxft but include
158 * image.c (toplevel): Do not declare Vlibrary_cache because
159 it's already done in lisp.h.
161 2013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
163 * lisp.h (Mouse_HLInfo): Move from here...
164 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
165 (reset_mouse_highlight): New function.
166 * msdos.c (dos_set_window_size, IT_update_begin)
167 (internal_terminal_init):
168 * nsterm.m (ns_update_window_end, x_free_frame_resources)
169 (ns_initialize_display_info):
170 * w32console.c (initialize_w32_display):
171 * w32term.c (x_update_window_end, x_free_frame_resources)
172 (w32_initialize_display_info):
173 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
174 * window.c (Fdelete_other_windows_internal):
175 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
176 * termchar.h (toplevel):
177 * xterm.h (toplevel): Include dispextern.h.
179 2013-08-26 Paul Eggert <eggert@cs.ucla.edu>
181 Fix minor problems found by static checking.
182 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
183 (expect): Avoid nested-if warning.
184 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
185 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
186 * nsterm.h, nsterm.m (ns_select):
187 * xgselect.c, xgselect.h (xg_select):
188 Adjust signature to better match pselect's.
189 * nsterm.m (ns_select):
190 Don't set *TIMEOUT, since pselect doesn't.
191 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
192 diagnostic about assigning const char * to it.
193 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
195 2013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
197 * lread.c (substitute_object_recurse): Handle hash-tables as well
200 2013-08-26 Paul Eggert <eggert@cs.ucla.edu>
202 Fix unlikely core dump in init_tty, and simplify terminfo case.
203 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
204 The old version incorrectly dumped core if malloc returned a
205 buffer containing only non-NUL bytes.
206 (init_tty): Do not allocate or free termcap buffers; the
207 struct does that for us now.
208 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
209 (struct tty_display_info): Define members termcap_term_buffer and
210 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
211 use them. Allocate them directly in struct rather than indirectly
212 via a pointer, to simplify init_tty.
214 * frame.c (check_minibuf_window): Initialize 'window' properly,
215 so that Emacs reliably aborts later if 'window' is not initialized.
217 2013-08-26 Jan Djärv <jan.h.d@swipnet.se>
219 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
220 of VoidSymbol (Bug#15154).
222 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
224 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
225 mouse_face_beg_y and mouse_face_end_y.
226 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
227 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
228 Adjust users and update comment where appropriate.
230 2013-08-26 Martin Rudalics <rudalics@gmx.at>
232 * frame.c (check_minibuf_window): New function.
233 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
234 Call check_minibuf_window (Bug#15183).
236 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
238 * window.h (struct window): Replace last_cursor with last_cursor_vpos
239 because this is the only last cursor data we need to keep and consult.
240 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
241 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
244 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
246 Fix recovering from possible decompression error.
247 Since insert_from_gap doesn't always move point, we can't use PT as
248 the position where the partially decompressed data ends, and
249 should count how many bytes was produced so far.
250 * decompress.c (struct decompress_unwind_data): Add nbytes member.
251 (unwind_decompress): Really delete partially uncompressed data.
252 (Fzlib_decompress_region): Take decompressed data size into account.
254 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
256 * syntax.c (init_syntax_once): Adjust comment and do an early
257 initialization of Qchar_table_extra_slots just once...
258 * casetab.c (init_casetab_once):
259 * category.c (init_category_once):
260 * character.c (syms_of_character):
261 * coding.c (syms_of_coding):
262 * xdisp.c (syms_of_xdisp): ...and omit it here.
264 2013-08-24 Eli Zaretskii <eliz@gnu.org>
266 * xdisp.c (get_next_display_element): Don't apply to characters
267 from a display vector the logic of setting it->end_of_box_run_p
268 suitable for characters from a buffer. (Bug#15175)
270 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
271 to handle directories, rather than '_utime' which doesn't.
274 2013-08-24 Jan Djärv <jan.h.d@swipnet.se>
276 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
277 or fullscreen (Bug#14627).
279 2013-08-24 Paul Eggert <eggert@cs.ucla.edu>
281 System-dependent integer overflow fixes.
282 * process.c (Fset_process_window_size): Signal an error if
283 the window size is outside the range supported by the lower level.
284 * sysdep.c (set_window_size): Return negative on error,
285 nonnegative on success, rather than -1, 0, 1 on not in system,
286 failure, success. This is simpler. Caller changed.
287 (serial_configure): Remove unnecessary initialization of local.
288 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
289 size fits in unsigned long; this isn't true on some 32-bit hosts.
290 Avoid buffer overrun if some future version of /proc/meminfo has a
291 variable name longer than 20 bytes.
292 (system_process_attributes) [__FreeBSD__]:
293 Don't assume hw.availpages fits in 'int'.
295 2013-08-23 Paul Eggert <eggert@cs.ucla.edu>
297 Don't let very long directory names overrun the stack.
298 Fix some related minor problems involving "//", vfork.
299 * callproc.c (encode_current_directory): New function.
300 (call_process): Don't append "/"; not needed.
301 * fileio.c (file_name_as_directory_slop): New constant.
302 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
303 this can save the caller having to alloca.
304 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
305 Use SAFE_ALLOCA, not alloca.
306 (directory_file_name, Fexpand_file_name): Leave leading "//"
307 alone, since it can be special even on POSIX platforms.
308 * callproc.c (call_process):
309 * process.c (Fformat_network_address):
310 * sysdep.c (sys_subshell):
311 Use encode_current_directory rather than rolling our own.
312 (create_process): No need to encode directory; caller does that now.
313 * process.h (encode_current_directory): New decl.
314 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
315 Rework to avoid 'goto xyzzy;'.
317 2013-08-23 Eli Zaretskii <eliz@gnu.org>
319 * xdisp.c (handle_face_prop): If the default face was remapped use
320 the remapped face for strings from prefix properties. (Bug#15155)
322 2013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
324 Minor cleanup for redisplay interface and few related functions.
325 * frame.h (enum text_cursor_kinds): Move from here...
326 * dispextern.h (enum text_cursor_kinds): ...to here.
327 (toplevel): Drop unnecessary declarations.
328 (struct redisplay_interface): Use bool and enum text_cursor_kinds
329 in update_window_end_hook and draw_window_cursor functions.
330 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
331 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
332 * w32term.c (x_update_window_end,w32_draw_window_cursor):
333 * xterm.c (x_update_window_end, x_draw_window_cursor):
334 * xdisp.c (display_and_set_cursor, update_window_cursor)
335 (update_cursor_in_window_tree, x_update_cursor): Use bool and
336 enum text_cursor_kinds where appropriate.
338 2013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
340 Redesign redisplay interface to drop updated_row and updated_area.
341 * dispextern.h (updated_row, updated_area): Remove declaration.
342 (struct redisplay_interface): Pass glyph row and row area parameters
343 to write_glyphs, insert_glyphs and clear_end_of_line functions.
344 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
346 * dispnew.c (updated_row, updated_area): Remove.
347 (redraw_overlapped_rows, update_window_line): Adjust user.
348 (update_marginal_area, update_text_area): Likewise. Pass updated row
349 as a parameter. Prefer enum glyph_row_area to int where appropriate.
350 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
353 2013-08-22 Paul Eggert <eggert@cs.ucla.edu>
355 * process.c (flush_pending_output): Remove stub.
358 2013-08-21 Paul Eggert <eggert@cs.ucla.edu>
360 * callproc.c: Fix race that killed background processes (Bug#15144).
361 (call_process): New arg TEMPFILE_INDEX. Callers changed.
362 Record deleted process-id in critical section, not afterwards.
363 Don't mistakenly kill process created by a call-process invocation
364 that discards output and does not wait.
366 2013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
368 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
369 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
370 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
371 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
372 to shut up compiler in mark_object.
373 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
375 2013-08-21 Paul Eggert <eggert@cs.ucla.edu>
377 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
378 We can't portably rely on PTY_OPEN doing that, even if
379 it calls posix_openpt with O_CLOEXEC.
381 2013-08-20 Kenichi Handa <handa@gnu.org>
383 * character.c (string_char): Improve commentary.
385 2013-08-20 Paul Eggert <eggert@cs.ucla.edu>
387 * image.c (SIGNATURE_DIGESTSIZE): Remove.
388 (struct animation_cache): Make signature a flexible array member.
389 All uses changed. This is a tad slower but may insulate us better
390 from future changes to ImageMagick.
392 2013-08-19 Paul Eggert <eggert@cs.ucla.edu>
394 * image.c: Shrink memory needed for animation cache.
395 (SIGNATURE_DIGESTSIZE): New constant.
396 (struct animation_cache): Make 'signature' a fixed size array of bytes.
397 (imagemagick_create_cache): Copy the signature. This saves
398 several KB of memory that ImageMagick wastes per signature.
399 Don't bother updating the update_time, as the caller does that now.
400 (imagemagick_prune_animation_cache): Don't destroy the signature, as
401 it's a fixed size struct member now.
402 (imagemagick_get_animation_cache): Always destroy the signature,
403 as it's now imagemagick_create_cache's responsibility to copy it.
404 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
405 and use memcmp rather than strcmp.
406 eassert that ImageMagick returns a signature of the specified length.
408 2013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
410 * image.c (imagemagick_get_animation_cache): Don't segfault on
412 (imagemagick_get_animation_cache): Revert to previous definition
413 so that it actually works. But keep the memory leak fix.
414 (imagemagick_get_animation_cache): Fix memory leak.
416 2013-08-19 Paul Eggert <eggert@cs.ucla.edu>
418 * image.c: Fix animation cache signature memory leak.
419 Fix some other minor performance problems while we're at it.
420 (imagemagick_create_cache): Clear just the members that
421 need clearing. Don't set update_time, as caller does that now.
422 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
423 Simplify by using pointer-to-pointer instead of a prev pointer.
424 (imagemagick_prune_animation_cache): Use make_emacs_time rather
425 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
426 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
427 it's already a copy. Free the signature probe unless it's cached.
429 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
430 This was introduced by my 2013-08-12 fix for Bug#15035.
432 2013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
434 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
435 (imagemagick_prune_animation_cache): Now static.
437 2013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
439 * image.c (imagemagick_get_animation_cache): Don't segfault when
442 2013-08-18 Ken Brown <kbrown@cornell.edu>
444 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
445 static heap if ENABLE_CHECKING is defined.
446 (max_bss_sbrk_ptr): New variable.
448 (report_sheap_usage): Report maximum static heap usage instead of
449 ending static heap usage.
451 2013-08-17 Eli Zaretskii <eliz@gnu.org>
453 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
454 of zlib_initialized according to the results of calling
457 2013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
459 * image.c: Implement an ImageMagick per-image cache.
460 (imagemagick_get_animation_cache): Fix a double-free error.
461 (imagemagick_load_image): Remove the ping_wand code, which only
462 apparently saved time on invalid animated images, and slowed down
463 everything else. Optimise for the common case.
465 2013-08-16 Xue Fuqiao <xfq.free@gmail.com>
467 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
469 * editfns.c (insert_before_markers): Mention overlay in the doc string.
471 * marker.c (set_marker): Remove documentation of undefined behavior.
473 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
475 * image.c (imagemagick_compute_animated_image): Animate correctly
476 when sub-images are smaller than the main image.
477 (imagemagick_compute_animated_image): Setting the iterator row to
478 zero is apparently not allowed.
479 (imagemagick_compute_animated_image): Allow images that say they
480 have sub-images that are bigger than the main image, but just crop
483 2013-08-15 Jan Djärv <jan.h.d@swipnet.se>
485 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
487 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
489 * image.c (imagemagick_compute_animated_image): Respect the GIF
492 2013-08-15 Ken Brown <kbrown@cornell.edu>
494 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
495 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
498 2013-08-15 Paul Eggert <eggert@cs.ucla.edu>
500 Fix minor problems found by static checking.
501 * frame.c (delete_frame):
502 * xdisp.c (next_element_from_display_vector):
503 Avoid uninitialized local.
504 * image.c (imagemagick_compute_animated_image): Port to C89.
505 Prefer usual GNU indentation style for loops.
506 Be more careful about bizarrely large sizes, by using ptrdiff_t
509 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
511 Fix infinite frame selection loop (Bug#15025).
512 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
514 2013-08-15 Eli Zaretskii <eliz@gnu.org>
516 * xdisp.c (compute_window_start_on_continuation_line):
517 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
518 to make sure we end up setting the window start at the leftmost
519 visible character of the display line. This avoids funky
520 horizontal shifting because the window start is not kept on the
521 same position. (Bug#15090)
522 (next_element_from_display_vector): Support 'box' face attribute
523 in the face definitions of a display vector. (Bug#15099)
525 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
527 * image.c (imagemagick_compute_animated_image): Implement animated
529 (imagemagick_compute_animated_image): Fix some compilation
530 warnings. Implement a very simple cache to make the animation
531 usable at all, but it should be replaced with a per-image cache.
533 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
535 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
536 to do `for' loops over alist values.
537 * buffer.h (FOR_EACH_BUFFER):
538 * process.c (FOR_EACH_PROCESS): Use it.
539 (handle_child_signal, status_notify, Fget_buffer_process)
540 (kill_buffer_processes): Use FOR_EACH_PROCESS.
542 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
544 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
545 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
546 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
547 to xzalloc and so avoid redundant call to memset.
548 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
549 members because it is allocated with xzalloc and so already zeroed.
551 2013-08-14 Ken Brown <kbrown@cornell.edu>
553 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
556 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
558 Utility function and macro to copy Lisp string to C string.
559 * lisp.h (xlispstrdupa): New macro.
560 (xlispstrdup): New prototype.
561 * alloc.c (xlispstrdup): New function.
562 * callint.c (Fcall_interactively):
563 * fileio.c (Ffile_name_directory, Fexpand_file_name)
564 (Fsubstitute_in_file_name):
565 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
566 * image.c (x_create_bitmap_from_file):
567 * w32term.c (w32_term_init):
568 * xterm.c (x_term_init): Use xlispstrdup.
570 2013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
572 * image.c (imagemagick_load_image): Make animated pictures work.
573 There's still some problems with background color settings, though
576 * decompress.c (unwind_decompress): Always restore point.
578 2013-08-14 Xue Fuqiao <xfq.free@gmail.com>
580 * marker.c (set_marker): Reformat documentation.
582 2013-08-14 Paul Eggert <eggert@cs.ucla.edu>
584 * xdisp.c (cursor_type_changed): Now static.
586 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
587 Use changed. This avoids the need to call xmalloc and for the
588 caller to call xfree, and avoids memory leaks in some situations.
590 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
592 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
593 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
594 (redisplay_window): If window_end_valid is cleared due to non-zero
595 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
596 so do not call to try_cursor_movement for that window.
598 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
600 * window.h (struct window): Convert window_end_pos and
601 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
602 (wset_window_end_pos, wset_window_end_vpos): Remove.
603 * dispnew.c (adjust_glyph_matrix):
604 * window.c (Fwindow_end, replace_window, set_window_buffer)
606 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
607 (set_vertical_scroll_bar, redisplay_window, try_window)
608 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
609 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
610 (note_mouse_highlight): Adjust users.
611 (try_cursor_movement): Likewise. Convert old precondition to eassert.
614 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
616 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
617 * image.c (imagemagick_filename_hint): Use `const char *' and
618 prefer SSDATA to SDATA to avoid warnings.
620 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
622 Cleanup window fringes, margins and scroll bars adjustments.
623 * window.c (set_window_fringes, set_window_margins)
624 (set_window_scroll_bars, apply_window_adjustment): New functions.
625 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
626 (Fset_window_scroll_bars): Use them.
628 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
630 * window.h (struct window): Convert scroll_bar_width
631 from Lisp_Object to integer. Adjust comment.
632 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
634 * window.c (wset_scroll_bar_width): Remove.
635 (make_window): Initialize scroll_bar_width.
636 (Fsplit_window_internal): Use direct assignment.
637 (Fset_window_configuration, save_window_save):
638 Convert Lisp_Object to integer and back where appropriate.
639 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
640 bar was actually changed, and mention this in docstring.
642 2013-08-13 Paul Eggert <eggert@cs.ucla.edu>
644 * decompress.c: Minor simplifications.
645 (Fzlib_decompress_region): Don't bother verifying
646 that avail_out <= UINT_MAX, as that was confusing.
647 Mention the restriction in a comment instead.
648 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
650 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
652 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
653 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
655 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
657 * image.c (imagemagick_filename_hint): Check for errors in the
660 2013-08-13 Eli Zaretskii <eliz@gnu.org>
662 * window.c (Fwindow_margins): Return nil when there's no marginal
663 area, as per the documented API.
665 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
666 Fmake_vector, as scroll bar's struct members are not all Lisp
667 objects now. This avoids crashes in GC.
669 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
670 bool, so its address could be taken.
672 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
674 * image.c (imagemagick_filename_hint): New function to possibly
675 apply `image-content-type-suffixes'.
676 (imagemagick_load_image): Use it.
678 2013-08-13 Eli Zaretskii <eliz@gnu.org>
680 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
681 if loading zlib failed.
683 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
685 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
686 2013-08-13 checkin below. Change bool to BOOL, rule is:
687 All Obj-C code uses BOOL, except for interfaces callable from C.
689 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
691 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
693 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
694 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
695 bool instead of BOOL.
696 * w32term.h (struct scroll_bar): Convert fringe_extended_p
697 from Lisp_Object to bitfield. Adjust comment.
698 * w32term.c (x_scroll_bar_create): Adjust user.
699 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
700 * xterm.c (XTset_vertical_scroll_bar): Likewise.
701 Use bool for boolean.
702 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
703 to `unsigned int' when defining a bitfield.
705 2013-08-13 Paul Eggert <eggert@cs.ucla.edu>
707 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
709 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
711 * window.h (struct window): Convert left_margin_cols and
712 right_margin_cols from Lisp_Objects to integers. Adjust comment.
713 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
714 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
716 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
718 (showing_window_margins_p, update_window_line, update_frame_1):
719 * fringe.c (draw_fringe_bitmap_1):
720 * xdisp.c (window_box_width): Adjust users.
721 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
722 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
723 Use direct assignment.
724 (Fset_window_configuration, save_window_save, Fwindow_margins):
725 Convert Lisp_Object to integer and back where appropriate.
726 (Fset_window_margins): Adjust user. Return t if any margin
727 was actually changed, and mention this in docstring.
729 2013-08-13 Xue Fuqiao <xfq.free@gmail.com>
731 * syntax.c (forward_word):
732 * cmds.c (forward_char, backward_char): Mention the optional argument.
734 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
736 * window.h (struct window): Convert left_fringe_width
737 and right_fringe_width from Lisp_Objects to integers.
739 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
740 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
741 * window.c (wset_left_fringe_width, wset_right_fringe_width):
743 (make_window): Initialize new integer fields to -1.
744 (Fsplit_window_internal): Use direct assignment.
745 (Fset_window_configuration, save_window_save):
746 Convert Lisp_Object to integer and back where appropriate.
747 (Fset_window_fringes): Adjust user. Return t if any fringe
748 was actually changed, and mention this in docstring.
750 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
752 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
753 * nsfns.m (x_set_cursor_type):
754 * w32fns.c (x_set_cursor_type):
755 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
756 * xdisp.c (set_frame_cursor_types): ...but in common code.
758 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
760 * font.c (clear_font_cache): New function, stripped from...
761 (Fclear_font_cache): ...here, which now uses the function
762 above. Adjust comment.
763 * font.h (clear_font_cache): Add prototype.
764 * xfaces.c (clear_face_cache): Use clear_font_cache.
766 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
768 * window.c (Fset_window_start): Compare `w', not `window' because
769 `w' might not be equal to `window' after call to decode_live_window.
771 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
773 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
774 This fixes a problem introduced by the Bug#15035 patch
775 when using GPG. Reported by Herbert J. Skuhra.
777 2013-08-12 Eli Zaretskii <eliz@gnu.org>
779 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
780 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
783 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
785 * decompress.c (Fzlib_decompress_region): Support zlib
786 decompression, too, and rename.
788 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
790 Minor zlib configuration tweaks.
791 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
792 Don't assume presence of fn_inflateInit2_ zlib internal function.
794 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
796 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
797 include the zlib prefix.
799 2013-08-12 Eli Zaretskii <eliz@gnu.org>
801 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
802 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
803 define static variables that are pointers to zlib functions to be
805 (init_zlib_functions) [WINDOWSNT]: New function.
806 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
808 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
809 macros instead of invoking the zlib functions directly.
810 (syms_of_decompress): DEFSYM Qzlib_dll.
811 Staticpro Szlib_available_p.
813 2013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
815 Avoid looping over all frame windows to freeze and unfreeze.
816 * window.h (struct window): Drop frozen_window_start_p.
817 (freeze_window_starts): Drop prototype.
818 * frame.h (struct frame): New frozen_window_starts flag.
819 (FRAME_WINDOWS_FROZEN): New macro.
820 * window.c (freeze_window_start, freeze_window_starts):
822 (select_window, replace_window): Adjust users.
823 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
824 (window_frozen_p): New function.
825 (redisplay_window): Use it.
827 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
829 Fix some fd issues when running subprocesses (Bug#15035).
830 Fix bugs that can leak files or file descriptors on errors.
831 Don't unlink open temp files, as that's hard for users to diagnose
832 when things go awry (e.g., temp disk exhausted).
833 Don't bother to lock temp files. Check for invalid recursion.
834 * callproc.c (synch_process_fd): Remove. All uses removed.
835 (synch_process_tempfile): New var or macro.
836 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
838 (record_kill_process): New arg, the temp name. All callers changed.
839 (delete_temp_file): Now just a simple wrapper around unlink.
840 (call_process_kill): New arg, the call_process_fd array.
841 Close them all. Clear synch_process_pid. Remove the temp file,
842 or arrange for it to be removed.
843 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
844 that's been moved to synch_process_tempfile. Caller changed.
845 Do not remove the tempfile; that's now call_process_kill's
847 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
848 call_process_kill; the caller now does that.
849 (call_process_cleanup): Do not close the process fd; that's now
850 call_process_kill's responsibility.
851 (Fcall_process): Implement via new function call_process, which
852 has most of the old body of Fcall_process, but with a different API.
853 (call_process): New function that does not open or close filefd if
854 it is nonnegative. Record which fds need to be closed, and let
855 call_process_kill close (and remove the tempfile, on MSDOS) on error.
856 Signal an error if invoked recursively (could be done via a hook).
857 Simplify creation of the tempfile in the MSDOS case.
858 Don't create the output file until after checking for the executable.
859 Report any failure to open /dev/null.
860 Don't open /dev/null for writing twice; once is enough.
861 Don't create pipe if all output is being discarded or sent to file.
862 Don't worry about setting up the coding system or reading from the
863 pipe if all output is being discarded.
864 Hoist fd_error local into top level, to lessen block nesting.
865 Don't record deleted pid here; now done by Fcall_process_region.
866 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
867 and note its success in synch_process_tempfile.
868 Do not leak resources when child_setup fails.
869 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
870 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
871 (create_temp_file): Now returns open fd, with an additional
872 Lisp_Object * argument to return the name. All callers changed.
873 Do not close the file; rewind it instead, and leave it open for
874 the caller. Do not lock the temp file. Unwind-protect the file
875 and the file-descriptor.
876 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
877 If an asynchrounous process, record it here, not in call_process.
878 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
879 * eval.c (set_unwind_protect): New function.
880 * fileio.c (write_region): New function, generalized from the
881 old Fwrite_region. Do not lock temp files.
882 (Fwrite_region): Use it.
883 * lisp.h (set_unwind_protect, write_region): New decls.
884 * process.c: Include <verify.h>.
885 (make_process): Mark fds as initially closed.
886 (deleted_pid_list): Now a list of pid-filename pairs.
888 (close_process_fd): New function.
889 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
890 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
891 New constants. Verify that their number matches PROCESS_OPEN_FDS.
892 (create_process, create_pty, Fmake_serial_process)
893 (server_accept_connection): Record which fds need to be closed,
894 and let deactivate_process close them.
895 (Fmake_network_process): Do not discard the unwind-protect
896 until it's safe to do so.
897 (deactivate_process): Close the fds opened by create_process etc.
898 (Fprocess_send_eof): Adjust to new way of recording open fds.
899 Report an error if /dev/null can't be opened, instead of aborting.
900 * process.h (PROCESS_OPEN_FDS): New constant.
901 (struct Lisp_Process): New member open_fds.
902 (record_kill_process, record_deleted_pid): Adjust signatures.
903 (record_deleted_pid): Move decl here ...
904 * syswait.h (record_deleted_pid): ... from here.
906 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
908 * decompress.c: Fix bugs with large buffers and weird inputs.
909 Tune a bit. Reindent as per usual Emacs style.
910 (BUFFER_SIZE): Remove.
911 (Fdecompress_gzipped_region): Do not mishandle input buffers with
912 more than UINT_MAX bytes. Decompress into the gap instead of into
913 an auto buffer, as this should avoid copying. Return nil if
914 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
915 set immediate_quit; we shouldn't trust zlib code that much.
917 2013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
919 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
920 errors, and really move the gap to where we want it.
922 * lisp.h: Include decompress.c support.
924 * emacs.c (main): Include decompress.c support.
926 * Makefile.in: Include -lz if present.
928 2013-08-11 Jan Djärv <jan.h.d@swipnet.se>
930 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
931 (initWithTitle:): Initialize frame to 0.
932 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
933 (fillWithWidgetValue:frame:): Rename from
934 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
936 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
937 fillWithWidgetValue:frame:
939 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
940 remove memory leak warnings.
942 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
943 (ns_check_menu_open): Handle menu == nil. Remove assignment to
946 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
947 (x_activate_menubar): Update the whole menu.
948 (trackingNotification:): Call ns_check_menu_open if tracking ends.
949 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
950 current event is not NSSystemDefined (Bug#15001).
951 Call ns_check_menu_open only if trackingMenu is 2.
952 (menuDidClose:): New method, decrease trackingMenu.
953 (fillWithWidgetValue:setDelegate:): New method.
954 (fillWithWidgetValue:): Call the above.
956 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
958 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
960 Omit some unnecessary casts.
961 Many of these go back to the old pre-C89 days, when they may have
962 been needed, but we've been assuming C89 or later for a while now.
963 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
964 (live_float_p, live_misc_p, live_vector_p):
965 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
966 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
968 * callint.c (Fcall_interactively):
969 * doc.c (Fsubstitute_command_keys):
970 * filelock.c (get_boot_time):
971 * frame.c (xrdb_get_resource):
972 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
973 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
974 (xg_get_file_name_from_selector, menuitem_destroy_callback)
975 (menuitem_highlight_callback, menu_destroy_callback)
976 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
977 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
978 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
979 (xg_tool_bar_help_callback, tb_size_cb):
980 * image.c (xpm_alloc_color, png_read_from_memory)
981 (png_read_from_file, png_load_body, our_memory_skip_input_data)
982 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
984 * keymap.c (describe_map):
985 * nsfns.m (Fns_display_monitor_attributes_list):
986 * nsmenu.m (process_dialog:):
987 * nsterm.m (hold_event):
988 * process.c (wait_reading_process_output):
989 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
990 * scroll.c (do_direct_scrolling, scrolling_1):
991 * termcap.c (tgetent):
992 * window.c (check_window_containing, add_window_to_list)
993 (freeze_window_starts):
994 * xdisp.c (compare_overlay_entries, vmessage):
995 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
996 (x_get_monitor_attributes_xrandr)
997 (Fx_display_monitor_attributes_list, x_display_info_for_name)
998 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
999 * xfont.c (xfont_match, xfont_open):
1000 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1001 (menubar_selection_callback, menu_position_func)
1002 (popup_selection_callback, create_and_show_popup_menu)
1003 (dialog_selection_callback, create_and_show_dialog):
1004 * xrdb.c (x_get_string_resource):
1006 * xsmfns.c (x_session_check_input):
1007 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1008 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1009 (xaw_jump_callback, xaw_scroll_callback):
1010 Omit unnecessary casts.
1012 2013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1014 Minor string-length refactoring.
1015 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1016 * frame.c (make_monitor_attribute_list):
1017 Prefer build_string to strlen + make_string.
1019 2013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1021 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1022 don't check minor_code (Bug#14417).
1024 2013-08-09 Eli Zaretskii <eliz@gnu.org>
1026 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1027 vertical positions instead. This avoids calling MATRIX_ROW with
1028 row numbers that are possibly beyond valid limits. (Bug#15064)
1030 2013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1032 Use xstrdup and build_unibyte_string where applicable.
1033 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1034 * xfns.c (x_window):
1035 * xrdb.c (x_get_customization_string):
1036 * xterm.c (xim_initialize):
1037 * w32fns.c (w32_window): Use xstrdup.
1038 (w32_display_monitor_attributes_list):
1039 * emacs.c (init_cmdargs):
1040 * keyboard.c (PUSH_C_STR):
1041 * nsfont.m (nsfont_open):
1042 * sysdep.c (system_process_attributes):
1043 * w32.c (system_process_attributes):
1044 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1046 2013-08-09 Eli Zaretskii <eliz@gnu.org>
1048 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1049 variables of these types so that GDB would know about them, as aid
1050 for debugging fatal exceptions. (Bug#15024) See also
1051 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1054 2013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1056 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1057 larger than the NSWindow (Bug#14934).
1059 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1061 Redesign redisplay interface to drop global variable updated_window.
1062 Always pass currently updated window as a parameter to update routines.
1063 * dispextern.h (updated_window): Remove declaration.
1064 (struct redisplay_interface): Pass window parameter to
1065 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1066 and after_update_window_hook.
1067 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1069 * dispnew.c (updated_window): Remove.
1070 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1071 (update_window_line): Adjust to match redisplay interface changes.
1072 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1073 (ns_scroll_run, ns_after_update_window_line):
1074 * w32term.c (x_update_window_begin, x_update_window_end)
1075 (x_after_update_window_line, x_scroll_run):
1076 * xterm.c (x_update_window_begin, x_update_window_end)
1077 (x_after_update_window_line, x_scroll_run):
1078 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1079 Likewise. Adjust comments where appropriate.
1080 (x_cursor_to): Simplify because this is always called during window
1081 update (but install debugging check anyway).
1082 (expose_window): Check must_be_updated_p flag to see whether this
1083 function is called during window update.
1085 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1087 Do not reset window modification event counters excessively.
1088 These leftovers and poor man's tricky methods to catch extra
1089 redisplay's attention are no longer needed.
1090 * frame.c (set_menu_bar_lines_1):
1091 * minibuf.c (read_minibuf_unwind):
1092 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1093 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1094 (window_scroll_line_based, Fset_window_configuration):
1095 * xdisp.c (redisplay_window): Do not reset last_modified and
1096 last_overlay_modified counters.
1098 2013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1100 * xselect.c (x_send_client_event): Set send_event and serial, memset
1101 data.l as it might be bigger than data.b. Use 24 bit mask to
1102 XSendEvent (Bug#15034).
1104 2013-08-07 Eli Zaretskii <eliz@gnu.org>
1106 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1107 for TTY frames that are not the top frame on their console.
1110 2013-08-07 Martin Rudalics <rudalics@gmx.at>
1112 * w32term.c (w32fullscreen_hook): Really maximize frame when
1113 asked for (Bug#14841).
1115 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1117 Prefer selected_window to Fselected_window, likewise for frames.
1118 * buffer.c (Fbuffer_swap_text):
1119 * data.c (Fvariable_binding_locus):
1120 * window.c (run_window_configuration_change_hook): Adjust users.
1121 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1122 Use decode_live_frame.
1124 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1126 Be more careful if selected window shows the buffer other than current,
1127 use window_outdated only if this is not so. This change should also
1128 address some weird issues discussed in Bug#13012.
1129 * window.h (window_outdated): New prototype.
1130 * window.c (window_outdated): Now here. Convert from static and
1131 always assume window's buffer.
1132 (Fwindow_end, Fwindow_line_height): Use it.
1133 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1134 and always assume window's buffer.
1135 (redisplay_window): Adjust user.
1136 (redisplay_internal): Call to reconsider_clip_changes once and
1137 check whether mode line should be updated only if selected window
1138 shows current buffer.
1139 (run_window_scroll_functions): Use eassert for debugging check.
1140 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1142 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1144 * window.c (window_scroll, window_scroll_pixel_based)
1145 (window_scroll_line_based): Use bool for booleans.
1147 2013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1149 * process.c: Fix minor off-by-one issues in descriptor counts.
1150 This shouldn't fix any real bugs, but it cleans up the code a bit.
1151 (max_process_desc, max_input_desc): -1, not 0, means none.
1153 (delete_input_desc): New function.
1154 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1155 (deactivate_process): Scan backwards when recomuting max_process_desc;
1156 that should be faster.
1157 (init_process_emacs): Initialize max_input_desc.
1159 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1161 Use region cache to speedup bidi_find_paragraph_start.
1162 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1163 Rename cache_long_line_scans to cache_long_scans.
1164 * buffer.c (bset_cache_long_line_scans): Rename to
1165 bset_cache_long_scans.
1166 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1167 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1169 (syms_of_buffer): Rename cache-long-line-scans to
1170 cache-long-scans. Adjust docstring.
1171 * search.c (newline_cache_on_off):
1172 * indent.c (width_run_cache_on_off): Adjust users.
1173 * bidi.c (bidi_paragraph_cache_on_off): New function.
1174 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
1175 * insdel.c (prepare_to_modify_buffer):
1176 Invalidate bidi_paragraph_cache if enabled.
1178 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1180 Invalidate region caches only if buffer text is going to be changed.
1181 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1182 (modify_text): ...new prototype.
1183 (prepare_to_modify_buffer_1): New prototype.
1184 * textprop.c (modify_region): Rename to...
1185 (modify_text_properties): ...new function.
1186 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1187 (Fremove_list_of_text_properties): Adjust users.
1188 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1189 (modify_text): ...new function.
1190 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1191 (prepare_to_modify_buffer_1): ...new function.
1192 * casefiddle.c (casify_region):
1193 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1194 (Ftranspose_regions): Use modify_text.
1196 2013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1198 * lisp.mk (lisp): Add nadvice.elc.
1200 2013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1202 New macro to iterate over live buffers similar to frames.
1203 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1204 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1205 Declare buffer-related variables here to offload lisp.h.
1206 * buffer.c (Vbuffer_alist): Adjust comment.
1207 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1208 (other_buffer_safely):
1209 * data.c (store_symval_forwarding):
1210 * dispnew.c (Fframe_or_buffer_changed_p):
1211 * fileio.c (Fdo_auto_save):
1212 * filelock.c (unlock_all_files):
1213 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1215 2013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1217 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1218 * callproc.c (create_temp_file):
1219 * filelock.c (create_lock_file):
1220 Assume mkostemp, since it's now provided by Gnulib.
1222 2013-08-04 Eli Zaretskii <eliz@gnu.org>
1224 * w32.c (mkostemp): New function.
1225 (mktemp): Remove, no longer used. Most of the code reused in
1226 mkostemp. (Bug#15015)
1227 (mktemp): Don't undef.
1229 2013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1231 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1232 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1233 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1234 (free_glyph_pool, check_glyph_memory): Likewise for
1235 all users. Adjust comments where appropriate.
1237 2013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1239 * composite.h: Minor fixups.
1240 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1241 to fix a misspelling, and change it to an inline function while
1242 we're at it (it need not be a macro). All uses changed.
1243 (composition_method, composition_valid_p):
1244 Rewrite to avoid assignments in if-conditions.
1246 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1248 Do not use global Lisp_Object in composition macros.
1249 * composite.h (composition_temp): Remove declaration.
1250 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1251 (composition_method, composition_valid_p): ...inline functions.
1252 (compose_region): Remove the leftover.
1253 * composite.c (composition_temp): Remove.
1254 (run_composition_function, update_compositions)
1255 (composition_compute_stop_pos, composition_adjust_point)
1256 (Ffind_composition_internal):
1257 * coding.c (handle_composition_annotation):
1258 * xdisp.c (handle_composition_prop, check_point_in_composition):
1259 Related users changed.
1261 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1263 Drop FRAME_PTR typedef.
1264 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1265 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1266 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1267 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1268 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1269 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1270 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1271 All related users changed.
1273 2013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1275 * eval.c (default_toplevel_binding): New function.
1277 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1278 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1279 (syms_of_eval): Export them.
1280 * data.c (Fdefault_value): Micro cleanup.
1281 * term.c (init_tty): Use "false".
1283 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1285 Fix X GC leak in GTK and raw (no toolkit) X ports.
1286 * xterm.c (x_free_frame_resources): If white and black relief
1287 GCs are allocated, always free them here.
1288 * xfns.c (x_make_gc): Omit redundant initialization.
1289 * widget.c (create_frame_gcs): Remove the leftover.
1290 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1291 in x_free_frame_resources.
1293 2013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1295 * nsterm.m (windowWillResize:toSize:): Only change title if
1296 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1298 (viewDidEndLiveResize): New method.
1300 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1301 inside NS_IMPL_COCOA.
1303 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1305 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1306 Do not check whether undo is enabled because record_insert and
1307 record_delete does that themselves.
1309 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1311 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1312 member which is not really used any more.
1313 (FRAME_XIC_BASE_FONTNAME): Remove.
1314 * xfns.c (xic_free_fontset): Adjust user.
1315 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1316 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1317 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1318 (xdialog_show): Use eassert for debugging check.
1319 * w32term.c (x_unfocus_frame): Remove unused dummy function.
1321 2013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1323 * fileio.c, fns.c (merge): Move extern decl from here ...
1324 * lisp.h (merge): ... to here.
1326 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1328 Fix last font-related change.
1329 * w32font.h (w32font_list_internal, w32font_match_internal):
1331 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1332 (uniscribe_list_family): Adjust to match font API change.
1333 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1334 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1336 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1338 * frame.h (FRAME_MOUSE_UPDATE):
1339 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1340 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1342 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1344 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1345 * font.h (struct font_driver): Change list, match, and list_family
1346 functions to accept struct frame * as first arg.
1347 * font.c (font_score, font_compare, font_sort_entities):
1349 (font_sort_entities, font_list_entities, font_select_entity):
1350 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1351 match font API change.
1352 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1353 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1354 * ftxfont.c (ftxfont_list, ftxfont_match):
1355 * xftfont.c (xftfont_list, xftfont_match):
1356 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1357 * w32font.c (w32font_list, w32font_match, w32font_list):
1358 (w32font_list_internal, w32_font_match_internal): Likewise.
1359 * xfaces.c (Fx_family_fonts): Adjust user.
1361 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1363 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1364 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1365 only if HAVE_X_WINDOWS is in use.
1366 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1367 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1368 * w32term.c (x_wm_set_icon_position): Likewise.
1369 * w32fns.c (x_icon): Adjust user.
1371 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1373 * xterm.c (last_mouse_press_frame): Remove the
1374 leftover which is not really used any more.
1375 (handle_one_xevent, syms_of_xterm): Adjust users.
1376 (x_flush): Call XFlush once per each X display, not frame.
1377 This is better because this code always unconditionally skips
1378 non-X frames in Vframe_list and issues the only XFlush if we
1379 have more than one X frame on the same X display.
1380 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1381 Use bool for booleans.
1382 (x_draw_glyph_string_background, cvt_string_to_pixel):
1383 (cvt_pixel_dtor): Drop unnecessary prototypes.
1384 * xterm.h (x_display_ok): Adjust prototype.
1386 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1388 Drop unnecessary functions that deals with frame pixel size.
1389 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1390 (x_pixel_height): Drop prototypes.
1391 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1392 (x_pixel_height): Drop implementations.
1393 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1394 which should be always valid for window frame.
1395 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1396 * w32menu.c (Fx_popup_dialog):
1397 * xmenu.c (Fx_popup_dialog): Likewise for both.
1399 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1401 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1402 frame parameters and call to Fmodify_frame_parameters just once.
1403 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1404 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1405 and mention nil frame in docstring.
1407 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1409 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1410 (x_figure_window_size): Likewise. Adjust to return long.
1411 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1412 (toplevel): Move Qterminal_live_p to...
1413 * terminal.c (toplevel): ...here, make it static, and...
1414 (syms_of_terminal): ...DEFSYM here.
1415 * frame.h (Qterminal_live_p): Remove declaration.
1416 (make_frame, x_figure_window_size): Adjust prototype.
1417 * nsfns.m (Fx_create_frame): Use long for window flags.
1419 2013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1421 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1422 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1423 Do not assume that emacs_close (INT_MAX) is a no-op.
1425 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1427 * xfaces.c (make_face_cache): For struct face_cache, prefer
1428 xmalloc to xzalloc and so avoid redundant call to memset.
1429 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1431 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1433 * fringe.c (draw_window_fringes, update_window_fringes)
1434 (compute_fringe_widths):
1435 * w32term.c (x_draw_glyph_string):
1436 * window.c (candidate_window_p, Frecenter):
1437 * xfaces.c (realize_basic_faces, realize_default_face)
1438 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1439 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1440 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1441 * xmenu.c (Fx_menu_bar_open_internal):
1442 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1443 * xsettings.c (xft_settings_event):
1444 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1445 Use bool for booleans. Adjust style and comments where
1447 * dispextern.h (draw_window_fringes, update_window_fringes)
1448 (compute_fringe_widths):
1449 * xterm.h (x_had_errors_p): Adjust prototype.
1451 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1453 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1454 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1456 2013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1458 * fns.c (toplevel): Remove comment before Fsafe_length because
1461 2013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1463 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1465 2013-07-28 Eli Zaretskii <eliz@gnu.org>
1467 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1468 frame which got the message is still alive, before dereferencing
1469 its pointer. (Bug#14970)
1471 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1472 be a live window, before using it as such. (Bug#14970)
1474 2013-07-27 Eli Zaretskii <eliz@gnu.org>
1476 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1477 w32_detect_focus_change instead of doing part of its job by hand.
1478 This fixes the problem whereby FOCUS_OUT events were not sent to
1481 2013-07-26 Eli Zaretskii <eliz@gnu.org>
1483 * process.c (Fprocess_list): Doc fix.
1485 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1486 being re-exposed only if it didn't ask to become visible.
1487 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1488 was previously iconified. (Bug#14841)
1489 (x_iconify_frame): Mark the frame iconified.
1491 2013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1493 Fix minor problems found by static checking.
1494 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1495 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1497 2013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1499 * eval.c (set_specpdl_old_value): New function.
1500 (unbind_to): Minor simplification.
1501 (get_backtrace_frame): New function.
1502 (Fbacktrace_frame): Use it. Add `base' argument.
1503 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1504 (syms_of_eval): Export backtrace-eval.
1505 * xterm.c (x_focus_changed): Simplify.
1507 2013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1509 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1511 2013-07-24 Eli Zaretskii <eliz@gnu.org>
1513 * xdisp.c (redisplay_window): Instead of moving point out of
1514 scroll margin, reject the force_start method, and try scrolling
1515 instead. (Bug#14780)
1517 2013-07-24 Ken Brown <kbrown@cornell.edu>
1519 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1522 2013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1524 * eval.c (Fprogn): Do not check that BODY is a proper list.
1525 This undoes the previous change. The check slows down the
1526 interpreter, and is not needed to prevent a crash. See
1527 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1529 2013-07-23 Glenn Morris <rgm@gnu.org>
1531 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1533 2013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1535 Port to GNU/Linux systems with tinfo but not ncurses.
1536 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1537 to decide whether ncurses is being used. Without this change,
1538 GCC complains about tgetent not being declared, on a system
1539 that has tinfo installed but ncurses not installed.
1541 * eval.c (Fprogn): Check that BODY is a proper list.
1543 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1544 * data.c (Fsetq_default):
1545 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1546 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1548 Tune by taking advantage of the fact that ARGS is always a list
1549 when a function is declared to have UNEVALLED args.
1551 * emacsgtkfixed.c: Port to GCC 4.6.
1552 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1554 2013-07-23 Juanma Barranquero <lekktu@gmail.com>
1556 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1557 here to silence compiler warnings.
1559 2013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1561 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1562 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1563 from messing up Emacs's 'struct frame' (Bug#14923).
1565 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1567 * alloc.c (make_save_ptr_ptr): Define this function.
1568 It was inadvertently omitted. It's needed only if
1569 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1571 2013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1573 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1574 frame have focus (Bug#14895).
1576 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1578 Avoid vfork-related deadlock more cleanly.
1579 * callproc.c (child_setup): When the child's exec fails, output
1580 the program name, as that's more useful. Use O_NONBLOCK to avoid
1582 * process.c (create_process_1): Remove; no longer needed.
1583 (create_process): Remove timer hack; no longer needed, now that
1584 the child avoids deadlock.
1586 2013-07-20 Glenn Morris <rgm@gnu.org>
1588 * image.c (Fimage_flush): Fix doc typo.
1590 2013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1592 Fix array bounds violation when pty allocation fails.
1593 * process.c (PTY_NAME_SIZE): New constant.
1594 (pty_name): Remove static variable; it's now auto.
1595 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1596 Take pty_name as an arg rather than using a static variable.
1597 All callers changed.
1598 (create_process): Recover pty_flag from process, not from volatile local.
1599 (create_pty): Stay inside array even when pty allocation fails.
1600 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1602 * lread.c (Fload): Avoid initialization only when lint checking.
1603 Mention that it's needed only for older GCCs.
1605 2013-07-20 Kenichi Handa <handa@gnu.org>
1607 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1608 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1610 2013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1612 * lread.c (Fload): Avoid uninitialized warning.
1614 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1616 Fix some minor file descriptor leaks and related glitches.
1617 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1618 (create_lock_file): Use write, not emacs_write.
1619 * image.c (slurp_file, png_load_body):
1620 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1621 (server_accept_connection):
1622 Don't leak an fd on memory allocation failure.
1623 * image.c (slurp_file): Add a cheap heuristic for growing files.
1624 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1625 as that's what the other routines do. Maybe input need not be
1626 blocked at all, but it's better to be consistent.
1627 Avoid undefined behavior when strlen is zero.
1629 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1630 (NSTATICS): Now a constant; doesn't need to be a macro.
1632 2013-07-19 Richard Stallman <rms@gnu.org>
1634 * coding.c (decode_coding_utf_8): Add simple loop for fast
1635 processing of ASCII characters.
1637 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1639 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1641 2013-07-19 Eli Zaretskii <eliz@gnu.org>
1643 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1644 unportable 'struct x_display_info'.
1645 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1648 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1650 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1651 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1653 (system_process_attributes): Prefer plain char to unsigned char
1654 when either will do. Clean up properly if interrupted or if
1655 memory allocations fail. Don't assume sscanf succeeds.
1656 Remove no-longer-needed workaround to stop GCC from whining.
1657 Read command-line once, instead of multiple times. Check read status a
1660 Fix obscure porting bug with varargs functions.
1661 The code assumed that int is treated like ptrdiff_t in a vararg
1662 function, which is not a portable assumption. There was a similar
1663 -- though these days less likely -- porting problem with various
1664 assumptions that pointers of different types all smell the same as
1665 far as vararg functions is conserved. To make this problem less
1666 likely in the future, redo the API to use varargs functions.
1667 * alloc.c (make_save_value): Remove this vararg function.
1668 All uses changed to ...
1669 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1670 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1672 (make_save_ptr): Rename from make_save_pointer, for consistency with
1673 the above. Define only on platforms that need it. All uses changed.
1675 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1677 * keyboard.c: Try to fix typos in previous change.
1678 (DISPLAY_LIST_INFO): New macro.
1679 (kbd_buffer_get_event): Do not access members that are not present
1680 in X11. Revert inadvertent change of "!=" to "=".
1682 2013-07-18 Juanma Barranquero <lekktu@gmail.com>
1684 * keyboard.c (kbd_buffer_get_event):
1685 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1686 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1688 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1690 * filelock.c: Fix unlikely file descriptor leaks.
1691 (get_boot_time_1): Rework to avoid using emacs_open.
1692 This doesn't actually fix a leak, but is better anyway.
1693 (read_lock_data): Use read, not emacs_read.
1695 * doc.c: Fix minor memory and file descriptor leaks.
1696 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1697 (get_doc_string, Fsnarf_documentation):
1698 Fix file descriptor leak on error.
1700 * term.c: Fix minor fdopen-related file descriptor leaks.
1701 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1702 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1704 * charset.c: Fix file descriptor leaks and errno issues.
1706 (load_charset_map_from_file): Don't leak file descriptor on error.
1707 Use plain record_xmalloc since the allocation is larger than
1708 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1710 * eval.c (record_unwind_protect_nothing):
1711 * fileio.c (fclose_unwind):
1713 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1714 The replacement doesn't block input, but that no longer seems
1717 2013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1719 * lread.c: Fix file descriptor leaks and errno issues.
1720 (Fload): Close some races that leaked fds or streams when 'load'
1722 (Fload, openp): Report error number of last nontrivial failure to open.
1723 ENOENT counts as trivial.
1724 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1726 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1727 now that the function is always called with a nonnegative arg.
1728 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1729 All uses replaced with ...
1730 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1732 A few more minor file errno-reporting bugs.
1733 * callproc.c (Fcall_process):
1734 * doc.c (Fsnarf_documentation):
1735 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1736 * process.c (set_socket_option):
1737 Don't let a constructor trash errno.
1738 * doc.c: Include <errno.h>.
1740 2013-07-16 Juanma Barranquero <lekktu@gmail.com>
1742 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1744 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1746 Fix w32 bug with call-process-region (Bug#14885).
1747 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1748 to Fcall_process when the input is empty. This simplifies the
1749 code a bit. It makes no difference on POSIXish platforms but
1750 apparently it fixes a bug on w32.
1752 Fix bug where insert-file-contents closes a file twice (Bug#14839).
1753 * fileio.c (close_file_unwind): Don't close if FD is negative;
1754 this can happen when unwinding a zapped file descriptor.
1755 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1756 in case Emacs runs out of memory between the two unwind-protects.
1757 Don't trash errno when closing FD.
1758 Zap the FD in the specpdl when closing it, instead of deferring
1759 the removal of the unwind-protect; this fixes a bug where a child
1760 function unwinds the stack past us.
1762 New unwind-protect flavors to better type-check C callbacks.
1763 This also lessens the need to write wrappers for callbacks,
1764 and the need for make_save_pointer.
1765 * alloca.c (free_save_value):
1766 * atimer.c (run_all_atimers):
1768 * alloc.c (safe_alloca_unwind):
1769 * atimer.c (unwind_stop_other_atimers):
1770 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1771 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1772 * minibuf.c (choose_minibuf_frame_1):
1773 * process.c (make_serial_process_unwind):
1774 * xdisp.h (pop_message_unwind):
1775 * xselect.c (queue_selection_requests_unwind):
1776 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1777 * alloca.c (record_xmalloc):
1778 Prefer record_unwind_protect_ptr to record_unwind_protect with
1780 * alloca.c (Fgarbage_collect):
1781 Prefer record_unwind_protect_void to passing a dummy.
1782 * buffer.c (restore_buffer):
1783 * window.c (restore_window_configuration):
1784 * xfns.c, w32fns.c (do_unwind_create_frame)
1785 New wrapper. All record-unwind uses of wrappee changed.
1786 * buffer.c (set_buffer_if_live):
1787 * callproc.c (call_process_cleanup, delete_temp_file):
1788 * coding.c (code_conversion_restore):
1789 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1790 * editfns.c (save_excursion_restore)
1791 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1792 (save_restriction_restore):
1793 * eval.c (restore_stack_limits, un_autoload):
1794 * fns.c (require_unwind):
1795 * keyboard.c (recursive_edit_unwind, tracking_off):
1796 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1797 * macros.c (pop_kbd_macro, restore_menu_items):
1798 * nsfns.m (unwind_create_frame):
1799 * print.c (print_unwind):
1800 * process.c (start_process_unwind):
1801 * search.c (unwind_set_match_data):
1802 * window.c (select_window_norecord, select_frame_norecord):
1803 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1804 (fast_set_selected_frame):
1805 * xfns.c, w32fns.c (unwind_create_tip_frame):
1806 Return void, not a dummy Lisp_Object. All uses changed.
1807 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1808 * callproc.c (call_process_kill):
1809 * fileio.c (restore_point_unwind, decide_coding_unwind)
1810 (build_annotations_unwind):
1811 * insdel.c (Fcombine_after_change_execute_1):
1812 * keyboard.c (read_char_help_form_unwind):
1813 * menu.c (unuse_menu_items):
1814 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1815 * sound.c (sound_cleanup):
1816 * xdisp.c (unwind_redisplay):
1817 * xfns.c (clean_up_dialog):
1818 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1819 Accept no args and return void, instead of accepting and returning
1820 a dummy Lisp_Object. All uses changed.
1821 * cygw32.c (fchdir_unwind):
1822 * fileio.c (close_file_unwind):
1823 * keyboard.c (restore_kboard_configuration):
1824 * lread.c (readevalllop_1):
1825 * process.c (wait_reading_process_output_unwind):
1826 Accept int and return void, rather than accepting an Emacs integer
1827 and returning a dummy object. In some cases this fixes an
1828 unlikely bug when the corresponding int is outside Emacs integer
1829 range. All uses changed.
1830 * dired.c (directory_files_internal_unwind):
1831 * fileio.c (do_auto_save_unwind):
1832 * gtkutil.c (pop_down_dialog):
1833 * insdel.c (reset_var_on_error):
1834 * lread.c (load_unwind):
1835 * xfns.c (clean_up_file_dialog):
1836 * xmenu.c, nsmenu.m (pop_down_menu):
1837 * xmenu.c (cleanup_widget_value_tree):
1838 * xselect.c (wait_for_property_change_unwind):
1839 Accept pointer and return void, rather than accepting an Emacs
1840 save value encapsulating the pointer and returning a dummy object.
1842 * editfns.c (Fformat): Update the saved pointer directly via
1843 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1844 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1845 (unwind_body): New function.
1846 (record_unwind_protect): First arg is now a function returning void,
1847 not a dummy Lisp_Object.
1848 (record_unwind_protect_ptr, record_unwind_protect_int)
1849 (record_unwind_protect_void): New functions.
1850 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1851 * fileio.c (struct auto_save_unwind): New type.
1852 (do_auto_save_unwind): Use it.
1853 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1854 * insdel.c (struct rvoe_arg): New type.
1855 (reset_var_on_error): Use it.
1856 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1858 (specbinding_func): Remove; there are now several such functions.
1859 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1860 (set_unwind_protect_ptr): New function.
1861 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1863 Be simpler and more consistent about reporting I/O errors.
1864 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1865 Say "Read error" and "Write error", rather than "I/O error", or
1866 "IO error reading", or "IO error writing", when a read or write
1868 * process.c (Fmake_network_process, wait_reading_process_output)
1869 (send_process, Fprocess_send_eof, wait_reading_process_output):
1870 Capitalize diagnostics consistently. Put "failed foo" at the
1871 start of the diagnostic, so that we don't capitalize the
1872 function name "foo". Consistently say "failed" for such
1874 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1875 All callers changed. This is so it can use report_file_error.
1876 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1877 diagnostics consistently as above.
1879 * fileio.c (report_file_errno): Fix errno reporting bug.
1880 If the file name is neither null nor a pair, package it up as a
1881 singleton list. All callers changed, both to this function and to
1882 report_file_error. This fixes a bug where the memory allocator
1883 invoked by list1 set errno so that the immediately following
1884 report_file_error reported the wrong errno value.
1886 Fix minor problems found by --enable-gcc-warnings.
1887 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1888 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1890 2013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1892 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1893 Set event->arg to Qt if switch-event shall be generated.
1894 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1896 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1898 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1901 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1902 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1903 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1904 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
1905 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
1906 and there is a focused frame.
1907 (head_table): Add focus-in and focus-out.
1908 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1909 bind to handle-focus-in/out.
1911 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1912 (Fhandle_switch_frame): Call Fhandle_focus_in.
1913 (syms_of_frame): defsubr handle-focus-in/out.
1915 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1917 Fix porting bug to older POSIXish platforms (Bug#14862).
1918 * sysdep.c (emacs_pipe): New function, that implements
1919 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1920 This should port better to CentOS 5 and to Mac OS X 10.6.
1921 All calls to pipe2 changed.
1923 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1924 This makes the code easier to read and the executable a bit smaller.
1925 Do not replace all calls to Fcons that happen to create lists,
1926 just calls that are intended to create lists. For example, when
1927 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1928 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1929 Similarly for list2 through list5.
1930 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1931 * bytecode.c (exec_byte_code):
1932 * callint.c (quotify_arg, Fcall_interactively):
1933 * callproc.c (Fcall_process, create_temp_file):
1934 * charset.c (load_charset_map_from_file)
1935 (Fdefine_charset_internal, init_charset):
1936 * coding.c (get_translation_table, detect_coding_system)
1937 (Fcheck_coding_systems_region)
1938 (Fset_terminal_coding_system_internal)
1939 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1940 * composite.c (update_compositions, Ffind_composition_internal):
1941 * dired.c (directory_files_internal, file_name_completion)
1943 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1944 * doc.c (Fsnarf_documentation):
1945 * editfns.c (Fmessage_box):
1947 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1948 (Feval, eval_sub, Ffuncall, apply_lambda):
1949 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1950 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1951 (Fset_file_times, Finsert_file_contents)
1952 (Fchoose_write_coding_system, Fwrite_region):
1953 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1954 * font.c (font_registry_charsets, font_parse_fcname)
1955 (font_prepare_cache, font_update_drivers, Flist_fonts):
1956 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1957 * frame.c (make_frame, Fmake_terminal_frame)
1958 (x_set_frame_parameters, x_report_frame_params)
1959 (x_default_parameter, Fx_parse_geometry):
1960 * ftfont.c (syms_of_ftfont):
1961 * image.c (gif_load):
1962 * keyboard.c (command_loop_1):
1963 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1964 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1965 (Fminor_mode_key_binding, accessible_keymaps_1)
1966 (Faccessible_keymaps, Fwhere_is_internal):
1967 * lread.c (read_emacs_mule_char):
1968 * menu.c (find_and_return_menu_selection):
1969 * minibuf.c (get_minibuffer):
1970 * nsfns.m (Fns_perform_service):
1971 * nsfont.m (ns_script_to_charset):
1972 * nsmenu.m (ns_popup_dialog):
1973 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1974 (Fx_own_selection_internal):
1975 * nsterm.m (append2):
1976 * print.c (Fredirect_debugging_output)
1977 (print_prune_string_charset):
1978 * process.c (Fdelete_process, Fprocess_contact)
1979 (Fformat_network_address, set_socket_option)
1980 (read_and_dispose_of_process_output, write_queue_push)
1981 (send_process, exec_sentinel):
1982 * sound.c (Fplay_sound_internal):
1983 * textprop.c (validate_plist, add_properties)
1984 (Fput_text_property, Fadd_face_text_property)
1985 (copy_text_properties, text_property_list, syms_of_textprop):
1986 * unexaix.c (report_error):
1987 * unexcoff.c (report_error):
1988 * unexsol.c (unexec):
1989 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1990 (Fformat_mode_line, syms_of_xdisp):
1991 * xfaces.c (set_font_frame_param)
1992 (Finternal_lisp_face_attribute_values)
1993 (Finternal_merge_in_global_face, syms_of_xfaces):
1994 * xfns.c (x_default_scroll_bar_color_parameter)
1995 (x_default_font_parameter, x_create_tip_frame):
1996 * xfont.c (xfont_supported_scripts):
1997 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1998 (menu_help_callback, xmenu_show):
2000 * xterm.c (set_wm_state):
2001 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2002 and similarly for list2 through list5.
2004 2013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2006 * callproc.c (Fcall_process_region): Fix minor race and tune.
2007 (create_temp_file): New function, with the temp-file-creation part
2008 of the old Fcall_process_region. Use Fcopy_sequence to create the
2009 temp file name, rather than alloca + build_string, for simplicity.
2010 Don't bother to block input around the temp file creation;
2011 shouldn't be needed. Simplify use of mktemp.
2012 Use record_unwind_protect immediately after creating the temp file;
2013 this closes an unlikely race where the temp file was not removed.
2014 Use memcpy rather than an open-coded loop.
2015 (Fcall_process_region): Use the new function. If the input is
2016 empty, redirect from /dev/null rather than from a newly created
2017 empty temp file; this avoids unnecessary file system traffic.
2019 2013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2021 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2022 Simplify by making this case like the other two. This is a bit
2023 slower on obsolete hosts, but the extra complexity isn't worth it.
2025 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2026 * process.c (create_process) [!DOS_NT]:
2027 Remove now-unnecessary calls to emacs_close.
2029 2013-07-13 Eli Zaretskii <eliz@gnu.org>
2031 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2032 returning early. (Bug#14850)
2034 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2035 and inhibit-iso-escape-detection attributes of 'undecided'.
2038 2013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2040 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2041 Reported by Herbert J. Skuhra in
2042 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2044 Don't lose top specpdl entry when memory is exhausted.
2045 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2046 specpdl overflow here, to simplify callers; all callers changed.
2047 Always reserve an unused entry at the stack top; this avoids
2048 losing the top entry's information when memory is exhausted.
2050 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2052 Clean up errno reporting and fix some errno-reporting bugs.
2053 * callproc.c (Fcall_process):
2054 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2055 * process.c (create_process, Fmake_network_process):
2056 * unexaix.c (report_error):
2057 * unexcoff.c (report_error):
2058 Be more careful about reporting the errno of failed operations.
2059 The code previously reported the wrong errno sometimes.
2060 Also, prefer report_file_errno to setting errno + report_file_error.
2061 (Fcall_process): Look at openp return value rather than at path,
2062 as that's a bit faster and clearer when there's a numeric predicate.
2063 * fileio.c (report_file_errno): New function, with most of the
2064 old contents of report_file_error.
2065 (report_file_error): Use it.
2066 (Ffile_exists_p, Ffile_accessible_directory_p):
2067 Set errno to 0 when it is junk.
2068 * fileio.c (Faccess_file):
2069 * image.c (x_create_bitmap_from_file):
2070 Use faccessat rather than opening the file, to avoid the hassle of
2071 having a file descriptor open.
2072 * lisp.h (report_file_errno): New decl.
2073 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2076 * process.c (create_process, wait_reading_process_output) [AIX]:
2077 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2078 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2079 a multithreaded environment anyway).
2080 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2082 2013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2084 * image.c (x_find_image_file): Don't close a remote file handle.
2086 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2088 Fix races with threads and file descriptors.
2089 * callproc.c (Fcall_process_region):
2090 * dired.c (open_directory):
2091 * emacs.c (main, Fdaemon_initialized):
2092 * image.c (x_find_image_file):
2093 * inotify.c (Finotify_rm_watch):
2094 * lread.c (Flocate_file_internal):
2095 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2096 * term.c (term_mouse_moveto, init_tty):
2097 * termcap.c (tgetent):
2098 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2099 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2100 * unexhp9k800.c, unexmacosx.c (unexec):
2101 * callproc.c (Fcall_process_region):
2102 Use emacs_close, not close.
2103 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2104 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2105 and posix_close function on current platforms (which all lack them).
2106 (emacs_close): Use it. This should fix the races on GNU/Linux and
2107 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2108 and it should avoid closing random victim file descriptors on
2111 2013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2113 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2114 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2117 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2118 This is for .gdbinit xbacktrace.
2120 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2121 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2122 (emacs_set_tty): Now static.
2123 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2124 * term.c (tty_capable_p, tty_default_color_capabilities)
2125 (get_tty_terminal, term_mouse_movement)
2126 (handle_one_term_event, init_tty, maybe_fatal):
2127 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2128 (tgetent, scan_file, name_match, compare_contin):
2129 * terminal.c (get_terminal):
2130 Use bool for boolean.
2131 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2132 Prefer char to unsigned char if either will do.
2133 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2134 (tty_write_glyphs): Prefer int to unsigned.
2135 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2136 All callers changed.
2137 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2139 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2142 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2143 (B__dummy__): New dummy symbol, to pacify C89.
2144 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2145 they can't grok varargs macros.
2146 * dispnew.c (add_window_display_history)
2147 (add_frame_display_history):
2148 * print.c (print_object):
2149 * xdisp.c (debug_method_add):
2150 Use %p printf format only for void pointers.
2151 * emacs.c (usage_message): New constant, replacing ...
2152 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2153 (main): Adjust to usage reorg.
2154 * fns.c (syms_of_fns):
2155 * profiler.c (syms_of_profiler):
2156 Don't use non-constant struct initializers.
2157 * gnutls.h (gnutls_initstage_t):
2158 * lisp.h (enum Lisp_Fwd_Type):
2159 * lread.c (lisp_file_lexically_bound_p):
2160 * xsettings.c (anonymous enum):
2161 Remove trailing comma.
2162 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2163 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2164 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2166 * regex.c (const_re_char): New type, to pacify strict C89.
2167 All uses of 'const re_char' replaced to use it.
2168 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2169 with glibc when strict C89. This change is imported from gnulib.
2171 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2172 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2173 Omit GNU_LINUX implementation, since it requires long long.
2174 * xterm.c (x_draw_underwave):
2175 Do not assume the traditional order of struct's members.
2176 (x_term_init): Rewrite to avoid the need for non-constant structure
2179 Syntax cleanup, mostly replacing macros with functions.
2180 This removes the need for the syntax_temp hack.
2181 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2182 * syntax.c (SYNTAX_INLINE): New macro.
2183 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2184 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2185 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2186 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2187 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2188 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2189 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2190 Now constants, not macros.
2191 (syntax_temp) [!__GNUC__]: Remove.
2192 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2193 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2194 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2195 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2196 Move here from syntax.h; now functions, not macros. Except for the
2197 last function, these are static since only syntax.c uses them.
2198 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2199 All uses changed. Now a function, not a macro; use this fact
2200 to simplify the code.
2201 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2202 compiler bugs; no longer relevant.
2203 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2204 (SYNTAX_INLINE): New macro.
2205 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2206 for the new functions. Use bool for boolean member.
2207 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2208 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2209 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2210 (SETUP_BUFFER_SYNTAX_TABLE):
2211 Now extern inline functions, not macros.
2212 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2213 Remove; all uses replaced by implementation.
2214 (syntax_temp) [!__GNUC__]: Remove decl.
2215 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2217 2013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2219 * emacs.c (main): Fix syntax error.
2221 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2223 Timestamp fixes for undo (Bug#14824).
2224 * atimer.c (schedule_atimer):
2225 * fileio.c (Ffile_newer_than_file_p):
2226 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2227 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2228 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2229 (syms_of_fileio): Remove Sclear_visited_file_name.
2230 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2231 file doesn't exist; this avoids an ambiguity with negative timestamps.
2232 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2233 * systime.h (make_emacs_time, invalid_emacs_time):
2234 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2235 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2236 * undo.c (record_first_change): Push (visited-file-modtime) onto
2237 undo list rather than reimplementing it by hand, incorrectly.
2239 2013-07-09 Ken Brown <kbrown@cornell.edu>
2241 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2243 2013-07-09 Juanma Barranquero <lekktu@gmail.com>
2245 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2247 2013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2249 Handle errno and exit status a bit more carefully.
2250 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2251 number into an exit status. Instead, use EXIT_CANCELED.
2252 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2253 * callproc.c (relocate_fd):
2254 * emacs.c (close_output_streams, main):
2255 * process.c (create_process):
2256 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2257 Use emacs_perror for simplicity.
2258 * callproc.c (relocate_fd, main):
2259 * sysdep.c (sys_subshell):
2260 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2261 (shut_down_emacs): Use emacs_write, not write.
2262 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2263 * fileio.c (Fcopy_file, e_write):
2264 * nsterm.m (ns_select):
2265 * process.c (send_process):
2266 * sound.c (vox_write):
2267 Use emacs_write_sig, not emacs_write.
2268 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2269 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2271 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2273 (emacs_full_write): New function.
2274 (emacs_write): Rewrite to use it.
2275 (emacswrite_sig, emacs_perror): New functions.
2276 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2278 2013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
2280 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2281 on NS even if it is present. Pixmap on NS is a void*.
2283 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2285 Port to Ubuntu 10 (Bug#14803).
2286 Problem reported by T.V. Raman.
2287 * process.c (close_on_exec, accept4, process_socket):
2288 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2290 2013-07-07 Eli Zaretskii <eliz@gnu.org>
2292 * w32.c (sys_dup): Declare prototype.
2296 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2298 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2300 Make file descriptors close-on-exec when possible (Bug#14803).
2301 This simplifies Emacs a bit, since it no longer needs to worry
2302 about closing file descriptors by hand in some cases.
2303 It also fixes some unlikely races. Not all such races, as
2304 libraries often open files internally without setting
2305 close-on-exec, but it's an improvement.
2306 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2307 * callproc.c (Fcall_process) [!MSDOS]:
2308 * emacs.c (main) [!DOS_NT]:
2309 * nsterm.m (ns_term_init):
2310 * process.c (create_process):
2311 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2312 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2313 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2314 Prefer mkostemp with O_CLOEXEC to mkstemp.
2315 * callproc.c (relocate_fd) [!WINDOWSNT]:
2316 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2317 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2319 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2320 Make the resulting file descriptor close-on-exec.
2321 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2322 * lread.c (load_descriptor_list, load_descriptor_unwind):
2323 Remove; no longer needed. All uses removed.
2324 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2325 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2327 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2328 (Fmake_network_process, Fnetwork_interface_list):
2329 (Fnetwork_interface_info, server_accept_connection):
2330 Make newly-created socket close-on-exec.
2331 * sysdep.c (emacs_open, emacs_fopen):
2332 Make new-created descriptor close-on-exec.
2333 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2334 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2336 2013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2338 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2339 for NS_IMPL_GNUSTEP.
2341 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2343 Fix openp errno handling.
2344 * callproc.c (Fcall_process): Preserve openp errno around close.
2345 * lread.c (openp): Set errno when returning -1, as some callers
2348 2013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2350 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2352 * nsterm.h (NSSavePanel): Update comment.
2353 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2354 (ns_run_file_dialog): Declare.
2356 * nsfns.m: Remove panelOK.
2358 (ns_run_file_dialog): New function.
2359 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2360 event loop, so file dialog is popped up by ns_run_file_dialog, called
2361 by sendEvent (Bug#14578).
2362 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2364 2013-07-06 Eli Zaretskii <eliz@gnu.org>
2366 * xdisp.c (default_line_pixel_height): New function.
2367 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2368 (try_cursor_movement, redisplay_window, try_window)
2369 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2371 * window.c (window_scroll_pixel_based):
2372 use default_line_pixel_height.
2374 * dispextern.h (default_line_pixel_height): Add prototype.
2376 * frame.c (x_set_line_spacing): Accept a float value for
2377 line-spacing parameter, per the documentation.
2379 * data.c (Fmultibyte_string_p): Doc fix.
2381 2013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2383 Use emacs_open more consistently when opening files.
2384 This handles EINTR more consistently now, and makes it easier
2385 to introduce other uniform changes to file descriptor handling.
2386 * src/systdio.h: New file.
2387 * src/buffer.c (mmap_init):
2388 * cygw32.c (chdir_to_default_directory):
2389 * dispnew.c (Fopen_termscript):
2390 * emacs.c (Fdaemon_initialized):
2391 * fileio.c (Fdo_auto_save):
2392 * image.c (slurp_file, png_load_body, jpeg_load_body):
2393 * keyboard.c (Fopen_dribble_file):
2395 * print.c (Fredirect_debugging_output):
2396 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2397 * termcap.c (tgetent):
2398 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2399 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2400 * w32term.c (w32_initialize) [CYGWIN]:
2401 * xfaces.c (Fx_load_color_file):
2402 Use emacs_open instead of plain open, and emacs_fopen instead of
2404 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2405 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2406 * callproc.c (default_output_mode): New constant.
2407 (Fcall_process): Use it to call emacs_open instead of plain creat.
2408 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2409 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2410 (emacs_fopen): New function.
2411 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2412 Include <lisp.h>, for emacs_open.
2413 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2415 Remove duplicate #include directives.
2416 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2418 Don't include stdio.h twice.
2419 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2420 Don't include sys/types.h or stdio.h twice.
2421 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2422 * lread.c: Don't include coding.h twice.
2423 * nsfont.m: Don't include frame.h twice.
2424 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2425 * ralloc.c: Don't include <unistd.h> twice.
2426 * xdisp.c: Don't include font.h twice.
2427 * xterm.c: Don't include fontset.h twice.
2428 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2430 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2432 Scale ImageMagick images more carefully.
2433 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2434 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2435 Be more careful about avoiding undefined behavior after
2436 integer overflow and division by zero.
2438 2013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2440 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2441 (syms_of_w32fns): DEFSYM them.
2442 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2443 (CCHDEVICENAME): Define macros if not defined.
2444 (struct MONITOR_INFO_EX): New struct.
2445 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2446 (enum_display_monitors_fn): New variable.
2447 (globals_of_w32fns): Initialize it.
2448 (Fx_display_pixel_width, Fx_display_pixel_height)
2449 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2450 multi-monitor setups in docstrings.
2451 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2452 screen size by primary monitor's millimeter per pixel.
2453 (w32_monitor_enum, w32_display_monitor_attributes_list)
2454 (w32_display_monitor_attributes_list_fallback)
2455 (Fw32_display_monitor_attributes_list): New functions.
2456 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2458 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2460 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2462 2013-07-04 Michael Albinus <michael.albinus@gmx.de>
2464 * fileio.c (Qfile_notify_error): New error symbol.
2466 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2467 * inotify.c (inotify_callback, symbol_to_inotifymask)
2468 (Finotify_add_watch, Finotify_rm_watch): Use it.
2469 (inotifyevent_to_event): Exchange order of cookie and file name.
2470 (Finotify_add_watch): Adapt docstring.
2472 * lisp.h (Qfile_notify_error): Declare.
2474 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2476 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2477 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2478 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2479 which did not work (see <http://bugs.gnu.org/14569#307>).
2480 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2481 && (!noninteractive || initialized)). This attempts to thread
2482 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2484 2013-07-04 Juanma Barranquero <lekktu@gmail.com>
2486 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2487 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2489 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2491 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2492 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2493 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2494 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2496 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2498 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2499 Define to __sys_siglist.
2501 2013-07-02 Eli Zaretskii <eliz@gnu.org>
2503 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2504 word-wrap, so that overflow-newline-into-fringe would work in
2505 visual-line-mode. (Bug#2749)
2506 (move_it_in_display_line_to): When the last scanned display
2507 element fits exactly on the display line, and
2508 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2509 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2510 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2511 finding buffer position that corresponds to pixel coordinates,
2512 e.g. in buffer_posn_from_coords.
2514 2013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2516 * process.c (handle_child_signal): Call catch_child_signal if
2519 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2521 Don't convert function pointers to void * and back.
2522 It isn't portable C, and it's easy enough to avoid.
2523 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2524 (make_save_value): Add support for SAVE_FUNCPOINTER.
2525 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2526 * print.c (print_object):
2527 Distinguish function from object pointers.
2528 * lisp.h (SAVE_FUNCPOINTER): New constant.
2529 (SAVE_SLOT_BITS): Adjust to it.
2530 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2531 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2532 (voidfuncptr): New typedef.
2533 (struct Lisp_Save_Value): New member data[0].funcpointer.
2534 (XSAVE_FUNCPOINTER): New function.
2536 Simplify buildobj processing.
2537 * Makefile.in (buildobj.h): Make it a sequence of strings each
2538 followed by comma, rather than a single string. Put it into a
2539 .tmp file in case there's an error while generating it.
2540 (gl-stamp): Use .tmp for temp files.
2541 (mostlyclean): Clean .tmp files.
2542 * doc.c (buildobj): Move to just the routine that needs it.
2543 It's now an array of strings, so processing is simpler.
2545 2013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2547 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2548 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2549 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2550 Invoke malloc_enable_thread even when not interactive.
2551 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2552 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2553 in this case, since the underlying bug has now been fixed.
2555 2013-07-01 Juanma Barranquero <lekktu@gmail.com>
2557 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2558 unlinking it (bug#14691).
2560 2013-06-30 Michal Nazarewicz <mina86@mina86.com>
2562 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2563 before checking whether buffer is modified. This lets
2564 `kill-buffer-query-functions' cancel killing of the buffer or save
2565 its content before `kill-buffer' asks user the "Buffer %s
2566 modified; kill anyway?" question.
2568 2013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2570 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2571 Let the super performKeyEquivalent deal with them (Bug#14747).
2573 2013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2575 * widget.c (resize_cb): Remove unused local.
2577 Do not use GTK 3 if it exists but cannot be compiled.
2578 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2579 * xterm.c (x_error_handler) [!USE_GTK]:
2582 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2584 2013-06-30 Eli Zaretskii <eliz@gnu.org>
2586 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2587 to the valid range of values. (Bug#14753)
2589 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2590 when moving point by using the current glyph matrix. This avoids
2591 the need to force redisplay when this function is called in a
2594 2013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2596 Fix minor problems found by static checking.
2597 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2598 Redo the latter's body to sidestep GCC parenthesization warnings.
2599 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2600 * coding.c (detect_coding, detect_coding_system):
2601 * coding.h (struct undecided_spec):
2602 Use bool for boolean.
2603 * image.c (QCmax_width, QCmax_height): Now static.
2604 * xdisp.c (Fmove_point_visually): Remove unused local.
2606 2013-06-29 Eli Zaretskii <eliz@gnu.org>
2608 * xdisp.c (Fmove_point_visually): New function.
2610 2013-06-28 Kenichi Handa <handa@gnu.org>
2612 * coding.h (define_coding_undecided_arg_index): New enum.
2613 (coding_attr_index): New members
2614 coding_attr_undecided_inhibit_null_byte_detection,
2615 coding_attr_undecided_inhibit_iso_escape_detection,
2616 coding_attr_undecided_prefer_utf_8.
2617 (undecided_spec): New struct.
2618 (struct coding_system): New member `undecided' of the member
2621 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2622 (detect_coding): Likewise.
2623 (detect_coding_system): Likewise.
2624 (Fdefine_coding_system_internal): New coding system properties
2625 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2627 (syms_of_coding): Adjust for coding_arg_undecided_max.
2629 2013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2631 * image.c (x_from_xcolors): Remove unused local.
2633 2013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2635 Defer image data transfer between X client and server until actual
2638 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2641 * image.c (Destroy_Image): Remove.
2642 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2643 `mask_p', and `colors_p'. All uses changed.
2644 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
2645 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2646 New macros for `flags' arg to x_clear_image_1.
2647 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2648 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
2649 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
2650 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2651 (image_get_x_image, image_unget_x_image): New functions or macros.
2652 (image_background, image_background_transparent, x_to_xcolors)
2653 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2654 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2655 instead of Destroy_Image.
2656 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2657 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2658 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2659 (imagemagick_load_image, svg_load_image): Use them instead of
2660 x_create_x_image_and_pixmap, and x_put_x_image followed by
2661 x_destroy_x_image, respectively.
2662 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2663 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2664 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2665 background_transparent fields.
2666 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2667 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2669 2013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2671 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2672 This mostly consists of undoing recent changes.
2673 * callproc.c (Fcall_process):
2674 * process.c (create_process):
2675 Do not worry about catching SIGCHLD here, undoing previous change.
2676 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2677 * process.c, process.h (catch_child_signal):
2678 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2679 * process.c (catch_child_handler): Don't worry about being called
2680 lazily and do not assume caller has blocked SIGCHLD, undoing
2681 previous change. Move first-time stuff back to
2682 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2683 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2684 set lib_child_handler if it's already initialized, which may
2685 help avoid problems on GNUStep.
2687 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2689 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2690 * callproc.c (Fcall_process):
2691 * process.c (create_process):
2692 Make sure SIGCHLD is caught before we fork,
2693 since Emacs startup no arranges to catch SIGCHLD.
2694 * process.c (lib_child_handler): Initialize to null, not to
2696 (catch_child_signal): Allow self to be called lazily.
2697 Do nothing if it's already been called.
2698 Assume caller has blocked SIGCHLD (all callers do now).
2699 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2700 just before it's really needed.
2701 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2702 since it hasn't been caught yet.
2704 2013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2706 * image.c (compute_image_size): New function to implement
2707 :max-width and :max-height.
2708 (imagemagick_load_image): Use it.
2710 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2712 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2713 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2715 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2716 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2717 the SIGCHLD handler, since the code is not atomic and (due to glib)
2718 signals may be arriving now.
2719 * sysdep.c (init_signals): Do not catch child signals here;
2720 'main' now does that later, at a safer time.
2722 2013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2724 Clean up SIGCHLD handling a bit (Bug#14569).
2725 * process.c, process.h (catch_child_signal):
2726 Now always extern, even if !NS_IMPL_GNUSTEP.
2727 * process.c (catch_child_signal): Move glib tickler here from
2728 init_process_emacs, so that it's done earlier in Emacs
2729 initialization. Also move the noninteractive && !initialized
2730 check here from init_process_emacs. This is all a bit cleaner for
2731 GNUish platforms, and I hope it works around the Cygwin bug.
2732 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2733 that glib signal handling is tickled before glib creates threads.
2735 * process.c (wait_reading_process_output): Avoid int overflow
2736 when reading more than 2 GiB total from a process.
2738 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2740 * process.c (create_process): Handle a couple more cases,
2741 i.e., work even if new_argv and wait_child_setup[i] are cached.
2742 Use Fcall_process's style for volatile vars.
2744 2013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2746 * process.c (create_process): Mark PROCESS volatile.
2748 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2750 Use C99-style flexible array members if available.
2751 This avoids some subtle aliasing issues, which typically
2752 aren't a problem with GCC but may be a problem elsewhere.
2753 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2754 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2755 In either case, it uses a flexible array member rather than
2756 the old struct hack. All uses changed.
2757 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2758 Adjust to sdata reorganization.
2759 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2760 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2761 that ports better to pre-C99 non-GCC.
2762 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2763 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2764 as the latter has changed.
2765 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2766 and port better to pre-C99 GCC.
2767 * image.c (struct xpm_cached_color):
2768 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2769 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2770 Use FLEXIBLE_ARRAY_MEMBER.
2771 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2772 Move decl to top level so it gets checked against implementation.
2773 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2774 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2776 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2778 * syntax.c: Integer cleanups.
2779 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2780 All uses that need 0-or-2 changed to:
2781 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2782 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2783 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2784 (char_quoted, prev_char_comend_first, back_comment)
2785 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2786 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2787 Use bool for boolean.
2788 (update_syntax_table, skip_chars, skip_syntaxes):
2789 Prefer int to unsigned when either will do.
2790 (back_comment): Return boolean success flag, like forw_comment,
2791 instead of positive-or-minus-1 (which might have overflowed int anyway).
2792 Don't stuff ptrdiff_t into int.
2793 (syntax_spec_code, syntax_code_spec): Now const.
2794 (Fmatching_paren, scan_lists, scan_sexps_forward):
2795 Use enum syntaxcode for syntax code.
2796 (Fmatching_paren): Check that arg is a character, not just an integer.
2797 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2798 (Finternal_describe_syntax_value): Omit no-longer-needed
2800 (skip_chars): Use char, not unsigned char, when the distinction
2802 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2803 * bytecode.c (exec_byte_code):
2804 * syntax.c (syntax_spec_code, Fchar_syntax)
2805 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2807 * syntax.h (SYNTAX_WITH_FLAGS):
2808 Omit unnecessary casts.
2810 2013-06-20 Eli Zaretskii <eliz@gnu.org>
2812 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2813 line dimensions here, to avoid race conditions with the main
2814 thread. (Bug#14062, bug#14630, bug#14669)
2816 * w32term.c (w32_draw_window_cursor): Compute the header line and
2817 mode line dimensions here.
2818 <w32_system_caret_window, w32_system_caret_hdr_height>:
2819 <w32_system_caret_mode_height>: New variables.
2821 * w32term.h: Declare them.
2823 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2825 * alloc.c (die): Move "assertion failed" string here ...
2826 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2827 COND when SUPPRESS_CHECKING. This shrinks the executable text
2828 size by 0.8% to 2.2% when configured with --enable-checking,
2829 depending on optimization flags (GCC 4.8.1 x86-64).
2831 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2833 2013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
2835 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2836 base is 2; this is more accurate.
2838 2013-06-19 Juanma Barranquero <lekktu@gmail.com>
2840 * sound.c (string_default): Move to !WINDOWSNT section.
2841 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2843 2013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2845 * sound.c: Integer cleanups.
2846 Remove unnecessary forward decls.
2847 (struct sound_device): The 'file' member is now a Lisp_Object, not
2848 a char *, so that we needn't invoke alloca on a huge size.
2849 (Fplay_sound_internal): Adjust to this.
2850 (string_default): New function.
2851 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2852 Use it to adjust to the struct sound_device change.
2853 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2854 (be2hs) [0]: Remove.
2856 * syntax.c (skip_chars): Don't use uninitialized storage
2857 when searching a multibyte buffer for characters that are not in a
2858 unibyte string that contains non-ASCII characters.
2860 2013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2862 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2863 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2865 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2867 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2869 2013-06-18 Kenichi Handa <handa@gnu.org>
2871 * font.c (Ffont_spec): Signal an error for an invalid font name
2874 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2876 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2877 In particular this ports to 32-bit sparc Sun cc.
2878 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2879 array with a dummy element at specpdl[-1], so that its address can
2881 (unbind_to): Do not copy the binding; not needed, now that we
2882 copy old_value in the one place where the copy is needed.
2883 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2884 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2885 (union specbinding): Rename from struct specbinding. Redo layout
2886 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2887 which is not portable. With Sun C 5.12 32-bit sparc, the
2888 declaration causes nargs to be an unsigned bitfield, a behavior
2889 that the C standard allows; but Emacs wants nargs to be signed.
2890 The overall type is now a union of structures rather than a
2891 structure of union of structures, and the 'kind' member is now a
2892 bitfield, so that the overall type doesn't grow. All uses changed.
2893 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2895 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2897 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2898 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2900 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2902 2013-06-17 Eli Zaretskii <eliz@gnu.org>
2904 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2905 unless we know that the window w's frame is a frame object.
2906 Another attempt at solving bug#14062 and bug#14630.
2908 2013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2910 * textprop.c (property_set_type): New enum.
2911 (add_properties): Allow appending/prepending text properties.
2912 (add_text_properties_1): Factored out of Fadd_text_properties.
2913 (Fadd_text_properties): Move all the code into
2914 add_text_properties_1.
2915 (Fadd_face_text_property): New function that calls
2916 add_text_properties_1.
2918 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2920 Move functions from lisp.h to individual modules when possible.
2921 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2922 * alloc.c (XFLOAT_INIT, set_symbol_name):
2923 * buffer.c (CHECK_OVERLAY):
2924 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2925 (set_char_table_parent):
2926 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2927 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2928 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2929 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2931 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2932 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2933 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2934 (backtrace_args, backtrace_debug_on_exit):
2935 * floatfns.c (CHECK_FLOAT):
2936 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2937 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2938 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2939 (set_hash_index_slot):
2940 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2941 * marker.c (CHECK_MARKER):
2942 * textprop.c (CHECK_STRING_OR_BUFFER):
2943 * window.c (CHECK_WINDOW_CONFIGURATION):
2944 Move here from lisp.h, and make these functions static rather than
2946 * buffer.c (Qoverlayp):
2948 * fns.c (Qhash_table_p):
2949 * window.c (Qwindow_configuration_p):
2951 * lisp.h: Remove the abovementioned defns and decls.
2953 Use functions, not macros, for XINT etc (Bug#11935).
2954 In lisp.h, prefer functions to function-like macros, and
2955 constants to object-like macros, when either will do. This:
2956 . simplifies use, as there's no more need to worry about
2957 arguments' side effects being evaluated multiple times.
2958 . makes the code easier to debug on some platforms.
2959 However, when using gcc -O0, keep using function-like macros
2960 for a few critical operations, for performance reasons.
2961 This sort of thing isn't needed with gcc -Og, but -Og
2962 is a GCC 4.8 feature and isn't widely-enough available yet.
2963 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2964 Remove enum lsb_bits; no longer needed.
2965 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2966 * buffer.c (Qoverlap):
2968 * fns.c (Qhash_table_p):
2969 Now extern, so lisp.h can use these symbols.
2970 * dispextern.h: Include character.h, for MAX_CHAR etc.
2971 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2972 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2973 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2974 (GLYPH_CODE_P): Move here from lisp.h.
2975 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2976 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2977 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2978 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2979 XUNTAG now returns void *.
2980 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2981 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2982 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2983 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2984 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2985 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2986 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2987 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2988 New macros, renamed from their sans-lisp_h_ counterparts.
2989 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2990 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2991 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2992 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2993 If compiling via GCC without optimization, define these as macros
2994 in addition to inline functions.
2995 To disable this, compile with -DINLINING=0.
2996 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2997 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2998 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2999 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3000 (INTMASK, VALMASK): Now macros, since static values cannot be
3001 accessed from extern inline functions.
3002 (VALMASK): Also a constant, for benefit of old GDB.
3003 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3004 is INTEGERP, which can fold it in.
3005 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
3006 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3007 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3008 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3009 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3010 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3011 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3012 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3013 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3014 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3015 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3016 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3017 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3018 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3019 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3020 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3021 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3022 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3023 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3024 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3025 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3026 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3027 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3028 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3029 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3030 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3031 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3032 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3033 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3034 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3035 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3036 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3037 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3039 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3040 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3041 (VALMASK): Define in one place rather than in two, merging the
3042 USE_LSB_TAG parts; this is simpler.
3043 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3044 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3045 Move up, to avoid use before definition.
3046 Also include "globals.h" earlier, for the same reason.
3047 (make_natnum): New function.
3048 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3049 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3050 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3051 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3052 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3053 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3054 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3055 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3056 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3057 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3058 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3059 (Qwindow_configuration_p, Qimage): New forward declarations.
3060 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3061 (STRING_COPYIN): Remove; unused.
3062 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3063 (xcar_addr, xcdr_addr): New functions. All uses changed.
3064 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3065 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3066 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3067 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3068 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3069 (TYPE_RANGED_INTEGERP): Simplify.
3070 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3071 (setlocale, fixup_locale, synchronize_system_messages_locale)
3072 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3073 Now empty functions, not macros.
3074 (functionp): Return bool, not int.
3075 * window.c (Qwindow_configuration_p): Now extern,
3076 so window.h can use it.
3077 * window.h (Qwindowp): Move decl back to lisp.h.
3079 2013-06-15 Eli Zaretskii <eliz@gnu.org>
3081 * xdisp.c (Fline_pixel_height): New function, required for solving
3084 2013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3086 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3088 2013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3090 * lread.c (syms_of_lread):
3091 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3093 2013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3095 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3097 2013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3099 * fileio.c (expand_file_name): Doc fix.
3101 2013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3103 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3104 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3105 Wait for self, not for 0. This can't hurt on GNU or similar
3106 system, and may help with Cygwin.
3108 * keyboard.c: Don't use PROP (...) as an lvalue.
3109 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3110 Use set_prop (A, B), not PROP (A) = B.
3112 2013-06-10 Eli Zaretskii <eliz@gnu.org>
3114 * xdisp.c (get_it_property): Use it->window instead of generating
3115 a Lisp object from it->w.
3117 2013-06-09 Eli Zaretskii <eliz@gnu.org>
3119 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3120 get-char-property the window that is being rendered, instead of
3121 the buffer, to support window-specific overlays. (Bug#14575)
3122 (compute_display_string_pos): When W is NULL, use the current
3123 buffer as the object to pass to get-char-property.
3124 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3125 pointer member of the bidi iterator, since no window is pertinent
3128 2013-06-08 Eli Zaretskii <eliz@gnu.org>
3130 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3131 being displayed, and pass it to compute_display_string_pos.
3132 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3133 (bidi_paragraph_init): All callers changed.
3135 * xdisp.c (init_from_display_pos, init_iterator)
3136 (handle_single_display_spec, next_overlay_string)
3137 (get_overlay_strings_1, reseat_1, reseat_to_string)
3138 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3139 Set bidi_it.w member from it->w.
3140 (compute_display_string_pos): Accept additional argument, the
3141 window being displayed, and pass it to Fget_char_property.
3144 * dispextern.h (struct bidi_it): New member w, the window being
3146 (compute_display_string_pos): Adjust prototype.
3148 2013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3150 * xgselect.c: Remove unneeded include xterm.h.
3152 * process.c (wait_reading_process_output): Check for NS before GLIB.
3153 GLIB may be linked in due to rsvg, but ns_select must be called.
3155 * xgselect.c (xg_select): Remove call to window_system_available
3156 and g_main_context_pending at the top, so Gdk events (i.e. file
3157 notify) are processed when Emacs is started with -nw.
3159 2013-06-07 Eli Zaretskii <eliz@gnu.org>
3161 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3162 (ctagsfiles3): New variable, includes only *.m files.
3163 (TAGS): Use an explicit language name in the regular expressions,
3164 to avoid transformation of '/SOMETHING' by MSYS to
3165 'c:\MSYS\SOMETHING'.
3167 2013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3169 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3171 2013-06-06 Eli Zaretskii <eliz@gnu.org>
3173 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3174 still need to set the mouse pointer shape and activate help-echo.
3177 2013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3179 A few porting etc. fixes for the new file monitor code.
3180 See the thread containing
3181 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3182 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3183 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3184 (dir_monitor_callback, Fgfile_rm_watch):
3185 Use assq_no_quit instead of Fassoc, for speed.
3186 (dir_monitor_callback, Fgfile_rm_watch):
3187 eassert that the monitor is a fixnum.
3188 (dir_monitor_callback): No need for CDR_SAFE.
3189 Simplify building of lisp with alternative tails.
3190 (Fgfile_add_watch, Fgfile_rm_watch):
3191 Do not assume glib functions set errno reliably on failure.
3192 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3193 and signal an error otherwise.
3194 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3195 Use Fdelq instead of Fdelete, for speed.
3197 2013-06-05 Eli Zaretskii <eliz@gnu.org>
3199 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3200 don't insist on being invoked on a highlighted tool-bar button.
3201 Avoids losing tool-bar functionality when mouse-highlight is nil.
3202 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3203 Don't highlight when mouse-highlight is nil.
3204 (note_mouse_highlight): When mouse-highlight is nil, don't return
3205 right away; instead, run tool-bar and mode-line highlight
3206 subroutine, clear any existing highlight, and revert the mouse
3207 pointer to its default shape. (Bug#14558)
3209 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3211 * lisp.mk (lisp): Add prog-mode.el.
3213 2013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3215 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3216 * process.c (dummy_handler): New function.
3217 (lib_child_handler): New static var.
3218 (handle_child_signal): Invoke it.
3219 (catch_child_signal): If a library has set up a signal handler,
3220 save it into lib_child_handler.
3221 (init_process_emacs): If using glib and not on Windows, tickle glib's
3222 child-handling code so that it initializes its private SIGCHLD handler.
3223 * syssignal.h (SA_SIGINFO): Default to 0.
3224 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3225 31; it should no longer be needed now.
3227 2013-06-05 Michael Albinus <michael.albinus@gmx.de>
3229 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3231 * gfilenotify.c (globals_of_gfilenotify): New function.
3232 (syms_of_gfilenotify): Move global initialization there.
3234 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3236 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3238 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3239 * keyboard.c (menu_bar_items, tool_bar_items):
3240 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3241 not override local keymaps any more.
3243 2013-06-04 Eli Zaretskii <eliz@gnu.org>
3245 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3247 2013-06-03 Eli Zaretskii <eliz@gnu.org>
3249 * w32console.c (initialize_w32_display): Return the dimensions of
3250 the console window via 2 additional arguments, not via the current
3251 frame. This avoids crashes due to overrunning the bounds of
3252 frame's decode_mode_spec_buffer, which is not resized following
3253 the change of the frame dimensions from the initial 10x10.
3255 * w32term.h (w32_initialize_display_info): Adjust prototype.
3257 * term.c (init_tty): Take dimensions of the frame from the values
3258 returned by initialize_w32_display.
3260 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3261 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3262 (LIBES): Add $(GFILENOTIFY_LIBS).
3264 * w32inevt.c (handle_file_notifications): Add dummy implementation
3265 for !HAVE_W32NOTIFY.
3267 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3269 2013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3271 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3273 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3275 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3277 2013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3279 Fix minor problems found by static checking.
3280 * data.c (pure_write_error):
3281 Use xsignal2, not Fsignal, as Fsignal might return.
3282 * eval.c (set_backtrace_debug_on_exit): Now static.
3283 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3284 No longer inline. EXTERN_INLINE is needed only for functions
3285 defined in .h files. Reindent function header as per GNU style.
3286 (backtrace_p, backtrace_top, backtrace_next):
3287 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3288 compiler or linker. Add extern decls to pacify gcc -Wall.
3289 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3291 * frame.c (free_monitors): Define only on platforms that need it.
3292 * nsterm.m (ns_term_init):
3293 * process.c (catch_child_signal):
3294 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3295 defined on all porting targets these days.
3296 * process.c, process.h (catch_child_signal):
3297 Make it extern only if NS_IMPL_GNUSTEP is defined.
3299 2013-06-03 Eli Zaretskii <eliz@gnu.org>
3301 * w32.c (gettimeofday): Make the signature identical to prototype
3302 in nt/inc/sys/time.h.
3304 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3306 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3309 * keyboard.c (safe_run_hooks_error): Improve error message.
3311 * data.c (pure_write_error): Add `object' argument.
3312 * puresize.h (CHECK_IMPURE): Use it.
3314 2013-06-03 Michael Albinus <michael.albinus@gmx.de>
3316 * Makefile.in (NOTIFY_OBJ): New variable.
3317 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3319 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3320 Call syms_of_gfilenotify.
3322 * gfilenotify.c: New file.
3324 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3325 and Qfile_w32notify.
3326 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3327 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3329 * lisp.h: Declare syms_of_gfilenotify.
3331 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3333 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3335 Merge the specpdl and backtrace stacks. Make the structure of the
3336 specpdl entries more obvious via a tagged union of structs.
3337 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3338 (enum specbind_tag): New enum.
3339 (struct specbinding): Make it a tagged union of structs.
3340 Add a case for backtrace records.
3341 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3342 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3343 (backtrace_debug_on_exit): New accessors.
3344 (struct backtrace): Remove.
3345 (struct catchtag): Remove backlist field.
3346 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3348 (Flocal_variable_p): Speed up the common case where the binding is
3350 * eval.c (backtrace_list): Remove.
3351 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3352 (set_backtrace_args, set_backtrace_nargs)
3353 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3354 (backtrace_next): New functions.
3355 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3356 (unwind_to_catch, internal_lisp_condition_case)
3357 (internal_condition_case, internal_condition_case_1)
3358 (internal_condition_case_2, internal_condition_case_n): Don't bother
3359 with backtrace_list any more.
3360 (Fsignal): Adjust to new backtrace format.
3361 (grow_specpdl): Move up.
3362 (record_in_backtrace): New function.
3363 (eval_sub, Ffuncall): Use it.
3364 (apply_lambda): Adjust to new backtrace format.
3365 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3367 (specbind): Adjust to new specpdl format. Simplify.
3368 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3369 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3371 (mark_backtrace): Remove.
3372 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3373 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3374 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3376 * profiler.c (record_backtrace): Use get_backtrace.
3377 (handle_profiler_signal): Use backtrace_top_function.
3378 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3381 2013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3383 * process.h (catch_child_signal): Declare.
3385 * process.c (catch_child_signal): New function.
3386 (init_process_emacs): Call it.
3388 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3389 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3391 (x_set_cursor_type): Remove declaration.
3392 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3393 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3394 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3395 (ns_get_color): Use F suffix on float.
3396 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3397 (ns_get_rgb_color): Remove.
3398 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3399 (note_mouse_movement): x and y are CGFloat.
3400 (ns_draw_fringe_bitmap): Remove unused rowY.
3401 Change #if to COCOA && >= 10_6.
3402 (ns_draw_window_cursor): Remove unused overspill.
3403 (ns_draw_underwave): width and x are EamcsCGFloat.
3404 (ns_draw_box): thickness is CGFloat.
3405 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3406 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3407 if not in main thread.
3408 (ns_get_pending_menu_title, ns_check_menu_open)
3409 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3410 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3411 (sendFromMainThread:): New method.
3412 (changeFont:): size is CGFloat.
3413 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3414 Disable warning about permanent text.
3415 (characterIndexForPoint:): Adjust return type depending on GNUStep
3417 (mouseDown:): delta is CGFloat.
3418 (updateFrameSize): Remove unised variable f.
3419 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3420 Cast float to EmacsCGFloat.
3421 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3422 also to -1 when restoring.
3423 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3424 inside NS_IMPL_COCOA.
3425 (toggleFullScreen:): Put call to toggleFullScreen inside
3426 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3427 (setPosition:portion:whole:): por is CGFloat.
3428 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3429 (mouseDown:): Use CGFloat.
3430 (mouseDragged:): Remove unised variable edge.
3431 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3433 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3435 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3436 when NS_IMPL_GNUSTEP.
3437 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3438 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3439 (EmacsToolbar): Add clearAll. Add tag argument to
3440 addDisplayItemWithImage.
3441 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3443 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3445 * nsmenu.m (ns_update_menubar): Make static.
3446 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3447 (fillWithWidgetValue:): Add cast to SEL for setAction.
3448 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3449 (update_frame_tool_bar): Update code for GNUStep.
3450 (clearAll): New method.
3451 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
3452 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
3453 Move identifierToItem setObject and activeIdentifiers addObject before
3454 call to insertItemWithItemIdentifier.
3455 (validateVisibleItems): Fix indentation.
3456 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3457 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3458 UtilityWindow to aStyle, remove call to setStyleMask.
3460 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3462 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3463 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3464 Use F suffix on floats.
3465 (ns_char_width): Returns CGFloat.
3466 (ns_ascii_average_width): w is CGFloat instead of float.
3467 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
3469 (ns_glyph_metrics): CGFloat instead of float.
3471 * nsfns.m (x_set_foreground_color, x_set_background_color):
3473 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3474 remove unused variables.
3475 (Fns_read_file_name): Keep track if panel is for save.
3476 Use ns_filename_from_panel/ns_directory_from_panel.
3477 (Fns_list_services): delegate only used for COCOA.
3478 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3479 Just return the input if GNUStep.
3480 (x_screen_planes): Remove.
3481 (Fxw_color_values): Use EmacsCGFloat
3482 (Fns_display_monitor_attributes_list): Only get screen number for
3484 (getDirectory, getFilename): Remove from EmacsOpenPanel and
3486 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3487 ns_directory_from_panel.
3489 2013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3491 * process.c (handle_child_signal): Also use WCONTINUED.
3492 This is so that list-processes doesn't mistakenly list the process
3493 as stopped, when the process has actually been continued and is
3496 2013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3498 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3499 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3500 not already configured.
3502 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3504 2013-05-29 Eli Zaretskii <eliz@gnu.org>
3506 * Makefile.in (mostlyclean): Remove *.res files.
3508 2013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3510 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3511 a buffer (bug#8447).
3513 2013-05-27 Eli Zaretskii <eliz@gnu.org>
3515 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3516 display vector, and we backtrack, handle the case that the
3517 previous character position is also displayed from a display
3518 vector or covered by a display string or image. (Bug#14476)
3520 2013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3522 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3523 (struct MonitorInfo, free_monitors): Remove.
3524 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3525 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3526 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3529 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3530 (struct MonitorInfo, free_monitors): Remove.
3531 (ns_screen_name): Make static.
3532 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3533 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3536 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3537 (struct MonitorInfo): New struct.
3538 (free_monitors, make_monitor_attribute_list): Declare.
3540 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3542 (free_monitors, make_monitor_attribute_list): New functions.
3543 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3546 2013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3548 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3550 2013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3552 * keyboard.c: Apply keyboard decoding only to events that come directly
3553 from the tty, not from unread-command-events (bug#14368).
3554 (read_event_from_main_queue): New function, extracted from read_char).
3555 (read_decoded_char): Remove.
3556 (read_decoded_event_from_main_queue): New function to replace it.
3557 (read_char): Use it.
3558 (read_key_sequence): Use read_char rather than read_decoded_char.
3560 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3562 2013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3564 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3566 2013-05-22 Kenichi Handa <handa@gnu.org>
3568 The following changes are to fix the setting of
3569 buffer-file-coding-system on, for instance, C-x RET c unix RET
3570 _FILE_OF_DOS_EOL_TYPE_ RET.
3572 * coding.h (struct coding_system): New member detected_utf8_chars.
3574 * coding.c (detect_coding_utf_8): Count characters and check EOL
3575 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3577 (setup_coding_system): Do not initialize coding->head_ascii.
3578 (check_ascii): Do not set coding->eol_seen but update it. Do not
3579 call adjust_coding_eol_type here.
3580 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3581 If the eol-type of CODING is already specified, adjust the eol type
3582 of the found coding-system.
3583 (decode_coding_gap): Cancel previous change. Utilize the
3584 character numbers counted by detect_coding_utf_8. Fix detection
3587 2013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3589 * search.c (looking_at_1): Only set last_thing_searched if the match
3590 changed the match-data (bug#14281).
3592 2013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3594 * xdisp.c (reseat_at_previous_visible_line_start):
3595 Already declared in dispextern.h, so remove it here.
3596 (move_it_vertically_backward): Likewise.
3598 2013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3600 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
3601 (Fx_display_pixel_width, Fx_display_pixel_height)
3602 (Fx_display_mm_width, Fx_display_mm_height):
3603 Mention `display-monitor-attributes-list' in docstrings.
3605 * nsfns.m (ns_get_screen): Remove function. All uses removed.
3606 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
3607 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3608 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3609 (Fx_display_backing_store, Fx_display_visual_class)
3610 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3611 (Fx_display_grayscale_p, Fx_display_pixel_width)
3612 (Fx_display_pixel_height, Fx_display_planes)
3613 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3614 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3615 (Fx_display_mm_width, Fx_display_mm_height)
3616 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3617 height for all physical monitors as in X11.
3619 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3620 Return pixel width or height for all physical monitors as in X11.
3622 2013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3624 Port --enable-gcc-warnings to clang.
3625 * bytecode.c (exec_byte_code):
3627 Redo diagnostic pragmas to pacify clang, too.
3628 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3629 * editfns.c (Fencode_time):
3630 * fileio.c (file_accessible_directory_p):
3631 * font.c (font_unparse_xlfd):
3632 Use '&"string"[index]' instead of '"string" + (index)'.
3633 * undo.c (user_error): Remove; unused.
3635 2013-05-16 Eli Zaretskii <eliz@gnu.org>
3637 * insdel.c (insert_1_both): Document the arguments, instead of
3638 referring to insert_1, which no longer exists.
3640 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3641 some window, increment windows_or_buffers_changed, so that
3642 *Messages* display in that window is updated. (Bug#14408)
3644 * w32.c: Include epaths.h.
3645 (init_environment): Use cmdproxy.exe without leading directories.
3646 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3648 (gettimeofday): Adjust signature and return value to Posix
3651 * unexw32.c (open_output_file): Delete the existing emacs.exe
3652 before creating it, to break the hard link to the versioned
3655 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3656 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3657 (FIRSTFILE_OBJ): New variables.
3658 (W32_RES): Rename to EMACSRES. All users changed.
3659 (base_obj): Use $(CM_OBJ).
3660 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3661 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3662 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3663 $(W32_RES_LINK) before $(LIBES).
3664 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3666 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3668 * makefile.w32-in (DOC): Use just "DOC".
3670 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3672 * process.c: Export default filters and sentinels to Elisp.
3673 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3675 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3676 (Fset_process_sentinel, Fformat_network_address):
3677 Default to them instead of nil.
3678 (server_accept_connection): Sentinels can't be nil any more.
3679 (read_and_dispose_of_process_output): New function, extracted from
3680 read_process_output.
3681 (read_process_output): Use it; filters can't be nil.
3682 (Finternal_default_process_filter): New function, extracted from
3683 read_process_output.
3684 (exec_sentinel_unwind): Remove function.
3685 (exec_sentinel): Don't zilch sentinel while running.
3686 (status_notify): Sentinels can't be nil.
3687 (Finternal_default_process_sentinel): New function extracted from
3689 (setup_process_coding_systems): Default filter is not nil any more.
3690 (syms_of_process): Export new Elisp functions and initialize
3692 * lisp.h (make_lisp_proc): New function.
3694 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3696 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3698 2013-05-14 Eli Zaretskii <eliz@gnu.org>
3700 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3701 unless we know that the window w is a leaf window.
3702 Another attempt at solving bug#14062.
3704 2013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3706 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3709 2013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3711 * image.c (gif_load): Check that subimages fit (Bug#14345).
3713 2013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3715 * lread.c (skip_dyn_eof): New function.
3716 (read1): Use it to skip the end of a file in response to #@00.
3718 * doc.c (get_doc_string): Slightly relax the sanity checking.
3720 2013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3722 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3723 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3724 (MonitorInfo): New struct.
3725 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3726 (Fns_display_monitor_attributes_list): New functions.
3727 (display-usable-bounds): Remove.
3728 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3731 2013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3733 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3734 (GTK_CHECK_VERSION): New macro, if not already defined.
3735 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3736 replaced by GTK_CHECK_VERSION.
3738 2013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3740 * xterm.h (GTK_PREREQ): New macro.
3741 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3742 to use this macro instead, for consistency and clarity.
3744 2013-05-08 Eli Zaretskii <eliz@gnu.org>
3746 * xdisp.c (row_for_charpos_p): New function, with code of
3747 cursor_row_p, but accepts an additional argument CHARPOS instead
3748 of using a hardcoded PT.
3749 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3750 (row_containing_pos): Call row_for_charpos_p instead of partially
3751 doing the same. Fixes cursor positioning under longlines-mode
3752 when longlines-show-effect includes more than one newline, when
3753 moving the cursor vertically up.
3755 2013-05-08 Juanma Barranquero <lekktu@gmail.com>
3757 * makefile.w32-in (ACL_H): New macro.
3758 ($(BLD)/fileio.$(O)): Update dependencies.
3760 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3762 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
3763 * Makefile.in (LIB_ACL): New macro.
3764 (LIBACL_LIBS): Remove.
3765 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3766 * fileio.c: Include <acl.h>.
3767 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3768 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3770 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3773 * unexelf.c: Don't assume ElfW (Half) fits in int.
3774 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3775 when dealing with ElfW (Half) values, since they can exceed 2**31
3776 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3777 (entry_address): Omit unused NUM arg. All uses changed.
3779 2013-05-07 Juri Linkov <juri@jurta.org>
3781 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3782 to the string converted from number with `Fnumber_to_string'.
3785 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3787 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3788 This fixes a problem introduced by my previous change.
3790 2013-05-07 Glenn Morris <rgm@gnu.org>
3792 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3794 2013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3796 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3798 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3800 Static checking by GCC 4.8.0.
3801 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3802 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3803 (x_get_monitor_attributes_fallback)
3804 (x_get_monitor_attributes_xinerama)
3805 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3806 Define only if USE_GTK.
3807 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3808 (x_get_monitor_attributes_fallback): Omit unused locals.
3809 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3810 Use double, not float, to avoid mixed-mode floating point arithmetic.
3812 2013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3813 Jan Djärv <jan.h.d@swipnet.se>
3815 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3816 (XINERAMA_CFLAGS): New macros.
3817 (ALL_CFLAGS, LIBES): Use them.
3819 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3820 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3821 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3822 (syms_of_xfns): DEFSYM them.
3823 (struct MonitorInfo): New struct.
3824 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3825 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3826 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3827 (x_get_monitor_attributes_xinerama): New functions.
3828 (Fx_display_monitor_attributes_list): New primitive.
3829 (syms_of_xfns): Defsubr it.
3831 * xterm.h (x_display_info): Add Xatom_net_workarea and
3832 Xatom_net_current_desktop.
3834 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3835 and dpyinfo->Xatom_net_current_desktop.
3837 2013-05-06 Eli Zaretskii <eliz@gnu.org>
3839 * xdisp.c (pos_visible_p): Use the special code for finding the
3840 beginning of a display property or overlay for any "replacing"
3841 display property, not just for display strings. This solves
3842 incorrect reporting of position by posn-at-point. (Bug#14241)
3844 2013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3846 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3847 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3848 Verify that ElfW (Half) fits in int.
3849 (fatal): Use same signature as lisp.h.
3850 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3851 configure and build with -DUNEXELF_DEBUG without worrying about
3852 other modules that use DEBUG.
3853 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3854 possibly-wide integers now uses it instead of plain fprintf.
3855 (entry_address): New function, which avoids problems with 32-bit
3856 overflow on 64-bit hosts.
3857 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3858 (round_up): Don't assume the remainder fits in int.
3859 (find_section): Use bool for boolean. Simplify debug code.
3860 (unexec): Don't assume file sizes fit in int or size_t.
3861 Omit unnecessary trailing newline in 'fatal' format.
3862 Use strerror rather than outputting decimal error number.
3863 Remove unused code when emacs is not defined;
3864 this file relies on Emacs now.
3865 Don't assume e_phnum and e_shnum are positive.
3867 * regex.c: Fix problems when DEBUG is defined.
3868 (extract_number, extract_number_and_incr): Define regardless of
3869 whether DEBUG is defined; that's simpler and makes the code less
3870 likely to go stale in the normal case when DEBUG is not defined.
3871 Return int rather than taking an int * arg. All callers changed.
3872 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3873 Remove, replacing with ...
3874 (DEBUG_PRINT): New macro. All callers changed.
3875 (DEBUG_COMPILES_ARGUMENTS): New macro.
3876 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3877 (print_compiled_pattern, print_double_string) [DEBUG]:
3878 Use prototype rather than old-style definition.
3879 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3880 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3881 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3882 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3883 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3884 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3885 This matters only when DEBUG is defined.
3887 2013-05-05 Eli Zaretskii <eliz@gnu.org>
3889 * xdisp.c (set_iterator_to_next): Set the
3890 ignore_overlay_strings_at_pos_p flag only if we are _really_
3891 iterating over an overlay string, as indicated by the
3892 current.overlay_string_index member. (Bug#14306)
3894 2013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3896 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3897 to where it is used, to avoid autorelease issues (Bug#14050).
3899 2013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3901 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3902 * fileio.c (syms_of_fileio): Implement this.
3903 * filelock.c (create_lock_file): If symbolic links don't work, so
3904 we use a regular file as a lock file, do not fsync the lock file;
3907 2013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3909 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3910 (syms_of_minibuf): Adjust accodingly.
3912 * callint.c (Fcall_interactively): Adjust calls accordingly.
3914 2013-05-04 Eli Zaretskii <eliz@gnu.org>
3916 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
3917 w->contents is a buffer before computing everything else.
3918 Use parentheses to disambiguate last part of the condition.
3920 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3921 assertion violations. (Bug#14062)
3923 2013-05-01 David Reitter <david.reitter@gmail.com>
3925 * nsfns.m (ns_tooltip): Initialize.
3927 2013-04-28 Eli Zaretskii <eliz@gnu.org>
3929 * coding.c (decode_coding_gap): Don't remove the character before
3930 a newline unless it's a CR character. (Bug#14287)
3932 2013-04-28 Dan Nicolaescu <dann@gnu.org>
3934 * dispextern.h (struct face): Move enum face_underline_type
3935 earlier so that bitfields can be in the same word.
3937 2013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3939 * nsfns.m (handlePanelKeys): New function.
3940 (EmacsOpenPanel:performKeyEquivalent:)
3941 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3942 arrows/function/control and copy/paste keys (Bug#14296).
3944 2013-04-27 Juri Linkov <juri@jurta.org>
3946 * callint.c (Fcall_interactively): Call `Qread_number' for
3947 interactive code letter `n' instead of using duplicate code.
3950 2013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3952 * systime.h (make_timeval): Declare as 'const'.
3954 2013-04-27 Kenichi Handa <handa@gnu.org>
3956 * font.c (font_open_entity): Always open a font of manageable
3959 2013-04-26 Paul Eggert <eggert@cs.ucla.edu>
3961 Port better to AIX (Bug#14258).
3962 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3965 2013-04-24 Kenichi Handa <handa@gnu.org>
3967 * coding.c (decode_coding_iso_2022): When an invalid escape
3968 sequence is encountered, reset the invocation and designation
3969 status to the safest one.
3971 2013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3973 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3974 Without this fix, "make distclean" leaves stamp-h1 behind.
3976 2013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3978 * w32fns.c (w32_fullscreen_rect): New function to compute the
3979 window rectangle for the given fullscreen mode.
3980 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3981 longer tunes the window size. This keeps the window's edges flush
3982 with the screen and allows the taskbar to hide itself in fullboth.
3984 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3985 window decorations and uses the entire screen.
3987 * w32term.h (w32_fullscreen_rect) Add prototype.
3988 (struct w32_output): Replace normal_width, normal_height,
3989 normal_top, and normal_left members with a single normal_placement
3991 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3993 (FRAME_NORMAL_PLACEMENT): New macro.
3995 2013-04-16 Juanma Barranquero <lekktu@gmail.com>
3997 * minibuf.c (Ftest_completion): Silence compiler warning.
3999 2013-04-15 Eli Zaretskii <eliz@gnu.org>
4001 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
4004 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4007 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4008 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4009 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4010 parentheses where appropriate.
4012 2013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4014 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4016 2013-04-14 Eli Zaretskii <eliz@gnu.org>
4018 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4019 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4020 Mention in the doc string that setting these variables takes
4021 effect only after a call to set-window-buffer. (Bug#14200)
4023 2013-04-13 Eli Zaretskii <eliz@gnu.org>
4025 * indent.c (Fvertical_motion): Don't consider display strings on
4026 overlay strings as display strings on the buffer position we
4027 started from. This prevents vertical cursor motion from jumping
4028 more than one line when there's an overlay string with a display
4029 property at end of line.
4030 Reported by Karl Chen <Karl.Chen@quarl.org> in
4031 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4033 2013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4035 * window.c (select_window): `record_buffer' even if window is
4036 already selected (bug#14191).
4038 2013-04-11 Eli Zaretskii <eliz@gnu.org>
4040 * window.c (Fwindow_end): Test more flags, including the buffer's
4041 last_overlay_modified flag, to determine whether the window's
4042 display is really up-to-date. Prevents the function from
4043 returning a stale value. (Bug#14170)
4044 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4047 2013-04-10 Eli Zaretskii <eliz@gnu.org>
4049 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
4050 garbaged only if it is not already the top frame on its TTY.
4051 This prevents flickering due to constant redrawing of TTY frames when
4052 there are GUI frames open in the same session. (Bug#13864)
4054 2013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4056 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4057 of marking the idle timers directly.
4059 2013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4061 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4064 2013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4066 * window.c (select_window): Don't record_buffer while the invariant is
4067 temporarily broken (bug#14161).
4069 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4071 2013-04-07 Eli Zaretskii <eliz@gnu.org>
4073 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4075 2013-04-07 Romain Francoise <romain@orebokech.com>
4077 Ignore additional platform-specific ACL errors (Bug#13702).
4078 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4079 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4081 2013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4083 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4086 2013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4088 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4089 This bug was introduced by my 2013-02-25 change that simplified
4090 data_start configuration. Without this change, on GNU/Linux
4091 an Emacs configured with --enable-profiling fails immediately
4092 due to a profiler signal.
4093 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4094 with these flags. On platforms where special flags are needed
4095 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4096 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4097 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4099 2013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4101 Get rid of some platform-specific functions examining window
4102 system and its capabilities. This is a partial rework of the
4104 * lisp.h (have_menus_p): Remove prototype. This function is
4105 replaced with platform-independent window_system_available.
4106 (check_window_system): Move to...
4107 * frame.h (decode_window_system_frame, window_system_available):
4108 ...here, add new prototypes.
4109 * frame.c (window_system_available, decode_window_system_frame):
4111 (check_window_system): Platform-independent now.
4112 * xterm.h (x_in_use): Remove declaration.
4114 * w32term.h (check_x_frame):
4115 * nsterm.h (check_x_frame): Remove prototypes. This function
4116 is replaced with platform-independent decode_window_system_frame.
4117 * msdos.c (have_menus_p): Remove.
4118 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4119 Remove platform-specific functions. Use check_window_system,
4120 decode_window_system_frame and check_ns_display_info where
4121 appropriate. Minor style and comment tweaks.
4122 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4123 (check_x_frame): Likewise.
4124 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4126 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4127 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4128 * xmenu.c, xselect.c: All related users changed.
4130 2013-04-03 Kenichi Handa <handa@gnu.org>
4132 The following changes is to optimize the code for reading UTF-8
4135 * coding.c (check_ascii): Rename from detect_ascii. Return value
4136 changed. Check EOL format. Do not call adjust_coding_eol_type
4138 (check_utf_8): New function.
4139 (adjust_coding_eol_type): Do nothing if already adjusted.
4140 (detect_coding): Compare the return value of check_ascii with
4141 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4142 (decode_coding_gap): Optimize for valid UTF-8.
4144 2013-03-21 Kenichi Handa <handa@gnu.org>
4146 * coding.c (syms_of_coding): Cancel previous change.
4148 * insdel.c (insert_from_gap): Fix previous change.
4150 2013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4152 Consistently use platform-specific function to detect window system.
4153 * lisp.h (check_window_system): New prototype. This function is
4154 going to replace check_x, check_w32 and check_ns.
4155 (have_menus_p): Mention msdos.c in comment.
4156 * fontset.c (check_window_system_func): Remove. Adjust all users.
4157 * fontset.h (check_window_system_func): Remove prototype.
4158 * nsterm.h (check_ns):
4159 * xterm.h (check_x):
4160 * w32term.h (check_w32): Likewise.
4161 * menu.c (Fx_popup_menu): Use check_window_system.
4162 * msdos.c (check_window_system): Define for MS-DOS.
4163 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4164 * w32fns.c (check_window_system): Likewise for MS-Windows.
4165 * xfns.c (check_window_system): Likewise for X.
4166 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4167 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4169 2013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4171 Prefer < to > in range checks such as 0 <= i && i < N.
4172 This makes it easier to visualize quantities on a number line.
4173 This patch doesn't apply to all such range checks,
4174 only to the range checks affected by the 2013-03-24 change.
4175 This patch reverts most of the 2013-03-24 change.
4176 * alloc.c (xpalloc, Fgarbage_collect):
4177 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4178 * character.c (string_escape_byte8):
4179 * charset.c (read_hex):
4180 * data.c (cons_to_unsigned):
4181 * dispnew.c (update_frame_1):
4182 * doc.c (Fsubstitute_command_keys):
4183 * doprnt.c (doprnt):
4184 * editfns.c (hi_time, decode_time_components):
4185 * fileio.c (file_offset):
4186 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4187 * font.c (font_intern_prop):
4188 * frame.c (x_set_alpha):
4189 * gtkutil.c (get_utf8_string):
4190 * indent.c (check_display_width):
4191 * keymap.c (Fkey_description):
4192 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4194 * minibuf.c (read_minibuf_noninteractive):
4195 * process.c (wait_reading_process_output):
4196 * search.c (Freplace_match):
4197 * window.c (get_phys_cursor_glyph):
4198 * xdisp.c (redisplay_internal):
4199 * xsmfns.c (smc_save_yourself_CB):
4200 Prefer < to > for range checks.
4201 * dispnew.c (sit_for): Don't mishandle NaNs.
4202 This fixes a bug introduced in the 2013-03-24 change.
4203 * editfns.c (decode_time_components): Don't hoist comparison.
4204 This fixes another bug introduced in the 2013-03-24 change.
4206 2013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4208 * frame.h (struct frame): Drop scroll_bottom_vpos
4209 member becaue all real users are dead long ago.
4210 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4211 * xdisp.c (redisplay_internal): Adjust user.
4213 2013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4215 * nsmenu.m (showAtX:Y:for:): setLevel to
4216 NSPopUpMenuWindowLevel (Bug#13998).
4218 2013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4220 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4221 (ns_check_pending_open_menu): Declare.
4223 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4224 (x_activate_menubar): Update the menu with title that matches
4225 ns_get_pending_menu_title, and call
4226 ns_check_pending_openmenu (Bug#12698).
4227 (menuWillOpen:): New method.
4228 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4230 * nsterm.m (menu_will_open_state, menu_mouse_point)
4231 (menu_pending_title): New varaibles.
4232 (ns_get_pending_menu_title, ns_check_menu_open)
4233 (ns_check_pending_open_menu): New functions.
4235 2013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4237 * indent.c (current_column_bol_cache): Remove leftover which is not
4238 used in Fmove_to_column any more.
4239 (current_column, scan_for_column): Adjust users.
4240 * keyboard.c (last_point_position_buffer, last_point_position_window):
4241 Remove leftovers which are not used for recording undo any more.
4242 (command_loop_1, syms_of_keyboard): Adjust users.
4243 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4244 redisplay_window any more.
4245 (move_it_to): Adjust user.
4247 2013-03-29 Juanma Barranquero <lekktu@gmail.com>
4249 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4250 Update dependencies.
4252 2013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4254 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4255 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4258 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4260 * window.h (struct window): Replace hchild, vchild and buffer slots
4261 with the only contents slot. This is possible because each valid
4262 window may have either the child window (in vertical or horizontal
4263 combination) or buffer to display (for the leaf window). Using that,
4264 a lof of operations to traverse and/or change window hierarchies may
4265 be simplified. New member horizontal is used to distinguish between
4266 horizontal and vertical combinations of internal windows.
4267 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4268 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4269 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4270 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4271 Use contents slot, not buffer, where appropriate.
4272 (wset_combination): New function.
4273 (wset_buffer): Add eassert.
4274 (Fframe_first_window): Simplify the loop reaching first window.
4275 (Fwindow_buffer): Use WINDOW_LEAF_P.
4276 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4277 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4278 (unshow_buffer): Convert initial debugging check to eassert.
4279 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4280 (make_parent_window, window_resize_check, window_resize_apply)
4281 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4282 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4283 Adjust to match struct window changes.
4284 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4285 (mark_window_cursors_off, count_windows, get_leaf_windows)
4286 (foreach_window_1): Simplify the loop.
4287 * alloc.c (mark_object): Do not check for the leaf window because
4288 internal windows has no glyph matrices anyway.
4289 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4290 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4291 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4292 (build_frame_matrix_from_window_tree, mirror_make_current)
4293 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4294 (update_window_tree, set_window_update_flags): Simplify the loop.
4295 (sync_window_with_frame_matrix_rows): Enforce live window.
4296 Use contents slot, not buffer, where appropriate.
4297 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4298 and WINDOW_HORIZONTAL_COMBINATION_P.
4299 (make_frame_visible_1): Simplify the loop.
4300 Use contents slot, not buffer, where appropriate.
4301 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4302 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4303 (expose_window_tree): Likewise.
4304 Use contents slot, not buffer, where appropriate.
4305 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4306 to avoid deleted windows. Use contents slot instead of buffer.
4307 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4308 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4309 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4310 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4312 2013-03-28 Eli Zaretskii <eliz@gnu.org>
4314 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4315 identify the reasons for assertion violations in bug#14062 and
4317 (Fx_show_tip): Fix compilation error under
4318 "--enable-check-lisp-object-type". (Bug#14073)
4320 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4321 Reported by <rzl24ozi@gmail.com>.
4323 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4325 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4327 (unwind_with_echo_area_buffer): ...to restore it here.
4328 This is needed to ensure that...
4329 (redisplay_window): ...both window markers are valid here,
4330 which is verified by eassert.
4331 * editfns.c (save_excursion_save): Do not assume that
4332 selected_window always displays the buffer.
4333 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4336 2013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4338 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4341 2013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4343 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4345 2013-03-27 Eli Zaretskii <eliz@gnu.org>
4347 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4348 since MinGW's w32api headers do. This avoids compiler warnings.
4350 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4353 2013-03-26 Eli Zaretskii <eliz@gnu.org>
4355 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4357 2013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4359 * gtkutil.c (style_changed_cb): Check if frame is live and an
4360 X frame (Bug#14038).
4362 2013-03-26 Eli Zaretskii <eliz@gnu.org>
4364 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4365 Define only for _WIN32_WINNT less than 0x0500.
4366 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4368 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4369 see its own definitions of 'struct timeval' and 'struct timezone'.
4371 Fix incompatibilities between MinGW.org and MinGW64 headers.
4372 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4374 * w32.c (REPARSE_DATA_BUFFER): Guard with
4375 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4377 2013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4379 * xterm.c: Include X11/XKBlib.h
4380 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4382 2013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4384 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4386 * blockinput.h (input_blocked_p): Likewise.
4387 * bytecode.c (exec_byte_code): Likewise.
4388 * callproc.c (call_process_kill, call_process_cleanup)
4389 (Fcall_process): Likewise.
4390 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4391 (Fccl_execute_on_string): Likewise.
4392 * character.c (string_escape_byte8): Likewise.
4393 * charset.c (read_hex): Likewise.
4394 * cm.c (calccost): Likewise.
4395 * data.c (cons_to_unsigned): Likewise.
4396 * dired.c (directory_files_internal, file_name_completion):
4398 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4399 (sit_for): Likewise.
4400 * doc.c (Fsubstitute_command_keys): Likewise.
4401 * doprnt.c (doprnt): Likewise.
4402 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4403 * emacsgtkfixed.c: Likewise.
4404 * fileio.c (file_offset, Fwrite_region): Likewise.
4405 * floatfns.c (Fexpt, fmod_float): Likewise.
4406 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4408 * font.c (font_intern_prop): Likewise.
4409 * frame.c (x_set_alpha): Likewise.
4410 * gtkutil.c (get_utf8_string): Likewise.
4411 * indent.c (check_display_width): Likewise.
4412 * intervals.c (create_root_interval, rotate_right, rotate_left)
4413 (split_interval_right, split_interval_left)
4414 (adjust_intervals_for_insertion, delete_node)
4415 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4416 (merge_interval_right, merge_interval_left, copy_intervals)
4417 (set_intervals_multibyte_1): Likewise.
4418 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4419 * keymap.c (Fkey_description): Likewise.
4420 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4421 * lread.c (openp, read_integer, read1, string_to_number):
4423 * menu.c (ensure_menu_items): Likewise.
4424 * minibuf.c (read_minibuf_noninteractive): Likewise.
4425 * print.c (printchar, strout): Likewise.
4426 * process.c (create_process, Faccept_process_output)
4427 (wait_reading_process_output, read_process_output, send_process)
4428 (wait_reading_process_output): Likewise.
4429 * profiler.c (make_log, handle_profiler_signal): Likewise.
4430 * regex.c (re_exec): Likewise.
4431 * regex.h: Likewise.
4432 * search.c (looking_at_1, Freplace_match): Likewise.
4433 * sysdep.c (get_child_status, procfs_ttyname)
4434 (procfs_get_total_memory): Likewise.
4435 * systime.h (EMACS_TIME_VALID_P): Likewise.
4436 * term.c (dissociate_if_controlling_tty): Likewise.
4437 * window.c (get_phys_cursor_glyph): Likewise.
4438 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4439 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4441 * xfns.c (Fx_window_property): Likewise.
4442 * xmenu.c (set_frame_menubar): Likewise.
4443 * xselect.c (x_get_window_property, x_handle_dnd_message):
4445 * xsmfns.c (smc_save_yourself_CB): Likewise.
4446 * xterm.c (x_scroll_bar_set_handle): Likewise.
4448 2013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4450 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4451 to be optional or nil. Adjust comment and convert it to docstring.
4452 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4453 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4455 2013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4457 Static checking by GCC 4.8-20130319.
4458 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4459 * process.c (Fset_process_datagram_address)
4460 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4461 * xdisp.c (get_char_face_and_encoding):
4462 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4463 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4464 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4466 2013-03-24 Ken Brown <kbrown@cornell.edu>
4468 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4469 fix compilation on 64-bit Cygwin, where underscores are not
4470 automatically prepended.
4472 * w32term.c (w32_initialize): Silence compiler warning.
4474 2013-03-23 Eli Zaretskii <eliz@gnu.org>
4476 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4477 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
4478 variables, to save and restore frame dimensions.
4479 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4480 after returning from a 'fullscreen' configuration.
4481 use SendMessage instead of PostMessage to send the SC_RESTORE message,
4482 to avoid races between the main thread and the input thread.
4484 * w32term.h (struct w32_output): New members normal_width,
4485 normal_height, normal_top, normal_left, and prev_fsmode.
4486 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4487 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4490 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4491 'fullscreen' parameter. Always record previous width and height
4492 of the frame, except when switching out of maximized modes, so
4493 that they could be restored correctly, instead of resetting to the
4494 default frame dimensions. Send SC_RESTORE command to the frame,
4495 unless we are going to send SC_MAXIMIZE, to restore the frame
4496 resize hints in the mouse pointer shown by the window manager.
4499 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4501 * lisp.h (get_frame_param): Adjust conditions for prototype
4504 2013-03-22 Ken Brown <kbrown@cornell.edu>
4506 * unexcw.c: Drop unneeded inclusion of w32common.h.
4507 (report_sheap_usage): Declare.
4508 (read_exe_header): Add magic numbers for x86_64.
4509 (fixup_executable): Fix printf format specifier for unsigned long
4512 2013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4514 * frame.h (struct frame): Put menu_bar_window under #ifdef
4515 because this member is not needed when X toolkit is in use.
4516 (fset_menu_bar_window):
4517 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4518 (free_glyphs, update_frame):
4519 * xdisp.c (expose_frame): Likewise.
4520 (display_menu_bar): Likewise. Remove redundant eassert.
4521 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4524 2013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4526 Use functions and constants to manipulate Lisp_Save_Value objects.
4527 This replaces code that used macros and strings and token-pasting.
4528 The change makes the C source a bit easier to follow,
4529 and shrinks the Emacs executable a bit.
4530 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4531 (make_save_value): Change 1st arg from string to enum. All callers
4534 (mark_object): Use if, not #if, for GC_MARK_STACK.
4535 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4536 (XSAVE_OBJECT): Now functions, not macros.
4537 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4538 the constant was never used.
4539 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4540 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4541 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4542 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4544 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4545 type3 with a single member save_type. All uses changed.
4546 (save_type, set_save_pointer, set_save_integer): New functions.
4547 * print.c (PRINTX): Remove.
4549 * alloc.c: Remove redundant static declarations.
4551 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4553 * window.h (struct window): Convert left_col, top_line, total_lines
4554 and total_cols from Lisp_Objects to integers. Adjust comments.
4555 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4557 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4558 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4559 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4560 Adjust users where appropriate.
4562 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4564 * frame.h (struct frame): Drop resx and resy because the same data is
4565 available from window system-specific output context. Adjust users.
4566 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4567 New functions to provide defaults when no window system available.
4568 (FRAME_RES_X, FRAME_RES_Y): New macros.
4569 (NUMVAL): Move from xdisp.c.
4570 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4571 (Ffont_face_attributes, Fopen_font):
4572 * image.c (gs_load):
4573 * w32font.c (fill_in_logfont):
4574 * xdisp.c (calc_pixel_width_or_height):
4575 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4576 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4578 2013-03-20 Kenichi Handa <handa@gnu.org>
4580 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4581 to 1 (temporary workaround until a bug related to ASCII
4582 optimization is fixed).
4584 2013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4586 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4587 Signal error if window is not internal. Adjust docstring.
4588 (delete_all_child_windows): Use combination_limit to save the buffer.
4589 (Fset_window_configuration): Adjust accordingly.
4590 * print.c (syms_of_print): Initialize debugging output not here...
4591 (init_print_once): ...but in a new function here.
4592 * lisp.h (init_print_once): Add prototype.
4593 * emacs.c (main): Add call to init_print_once. Adjust comments.
4595 2013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4597 * window.c (window_resize_check, window_resize_apply)
4598 (window_from_coordinates, recombine_windows, set_window_buffer)
4599 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4600 (Fsplit_window_internal, Fdelete_window_internal)
4601 (freeze_window_starts): Use bool for booleans.
4602 * window.h (window_frame_coordinates, resize_frame_windows)
4603 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4605 2013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4607 * dispnew.c (bitch_at_user): Use `user-error'.
4609 2013-03-17 Ken Brown <kbrown@cornell.edu>
4611 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4612 as return type of image_background. (Bug#13981)
4613 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4615 2013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4617 * nsterm.m (updateFrameSize:): Change resize increments if needed.
4618 (ns_select): Don't return with result uninitialized.
4620 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4623 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4625 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4626 directories. If filename is nil, get directory name (Bug#13932).
4627 Use getFilename and getDirectory.
4628 (getFilename, getDirectory): New methods for EmacsSavePanel and
4630 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4632 2013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4634 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4636 2013-03-15 Kenichi Handa <handa@gnu.org>
4638 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4639 (adjust_after_replace): Make it back to static. Delete the third
4640 arg text_at_gap_tail. Cancel the code for handling it.
4642 * coding.h (struct coding_system): New member eol_seen.
4644 * coding.c (detect_ascii): New function.
4645 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4646 when the source bytes are actually scanned. On detecting for
4647 coding_category_utf_8_auto, call detect_ascii instead of scanning
4648 source bytes directly.
4649 (produce_chars): Call insert_from_gap with the new arg 0.
4650 (encode_coding): Likewise.
4651 (decode_coding_gap): Control ASCII optimization by the variable
4652 disable_ascii_optimization instead of #ifndef .. #endif.
4653 Deccode EOL format according to coding->eol_seen.
4654 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4657 * lisp.h (adjust_after_replace): Cancel externing it.
4658 (insert_from_gap): Adjust prototype.
4660 2013-03-15 Eli Zaretskii <eliz@gnu.org>
4662 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4663 FULLSCREEN_MAXIMIZED. (Bug#13935)
4665 2013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4667 * region-cache.c (find_cache_boundary, move_cache_gap)
4668 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4669 Simplify debugging check and convert to eassert. Adjust comment.
4670 (pp_cache): Put under ENABLE_CHECKING.
4672 2013-03-14 Eli Zaretskii <eliz@gnu.org>
4674 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4675 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4677 (w32fullscreen_hook): If the frame is visible, reset
4678 f->want_fullscreen flag after changing the frame size. If the
4679 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4682 2013-03-13 Daniel Colascione <dancol@dancol.org>
4684 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4685 too so that these builds can use Cygwin's file conversion
4686 functions. (We've been building and linking cygw32.o all along
4687 and just not using it.)
4689 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4691 File synchronization fixes (Bug#13944).
4692 * Makefile.in (LIB_FDATASYNC): New macro.
4694 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4695 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4696 Don't worry about HAVE_FSYNC, since a substitute fsync is
4697 available if the system lacks one.
4698 (Fwrite_regin): Retry fsync if interrupted.
4700 2013-03-13 Eli Zaretskii <eliz@gnu.org>
4702 * w32term.c (w32_read_socket): If the Emacs frame is being
4703 activated, call w32fullscreen_hook, to make sure the new frame
4704 dimensions are in effect. (Bug#13937)
4706 2013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4708 * xdisp.c (init_iterator): Simplify because both character and byte
4709 positions are either specified or -1. Add eassert. Adjust comment.
4710 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4711 character and byte positions can be obtained from marker.
4713 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4715 Static checking by Sun C 5.12.
4716 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4717 * bytecode.c (exec_byte_code):
4718 * dispnew.c (init_display):
4720 * fileio.c (Fsubstitute_in_file_name):
4721 * keyboard.c (Fevent_convert_list):
4722 * keymap.c (Fsingle_key_description):
4723 * term.c (maybe_fatal, fatal):
4724 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4725 * xsmfns.c (Fhandle_save_session):
4726 Omit unreachable code.
4727 * keymap.c (map_keymap_char_table_item): Cast void * to
4728 a function pointer type; the C Standard requires this.
4730 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4731 Include <sys/param.h> unconditionally, as that works elsewhere and
4732 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4733 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4736 See ChangeLog.12 for earlier changes.
4742 Copyright (C) 2011-2013 Free Software Foundation, Inc.
4744 This file is part of GNU Emacs.
4746 GNU Emacs is free software: you can redistribute it and/or modify
4747 it under the terms of the GNU General Public License as published by
4748 the Free Software Foundation, either version 3 of the License, or
4749 (at your option) any later version.
4751 GNU Emacs is distributed in the hope that it will be useful,
4752 but WITHOUT ANY WARRANTY; without even the implied warranty of
4753 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4754 GNU General Public License for more details.
4756 You should have received a copy of the GNU General Public License
4757 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.