1 2011-12-02 Juri Linkov <juri@jurta.org>
3 * search.c (Fword_search_regexp): New Lisp function created from
4 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5 (Fword_search_backward, Fword_search_forward)
6 (Fword_search_backward_lax, Fword_search_forward_lax):
7 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
8 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
10 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
12 * fileio.c (Finsert_file_contents): Move after-change-function call
13 to before the "handled:" label, since all "goto handled" appear in
14 cases where the *-change-functions have already been properly called
17 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
19 * keyboard.c (interrupt_signal): Don't call kill-emacs when
20 waiting for input. (Bug#10169)
22 2011-11-30 Eli Zaretskii <eliz@gnu.org>
24 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
25 verifies glyph row's hash code--we have just reallocated the
26 glyphs, so their contents can be complete garbage. (Bug#10164)
28 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
30 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
32 2011-11-30 Eli Zaretskii <eliz@gnu.org>
34 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
35 attributes are tested _before_ calling verify_row_hash, to protect
36 against GCC re-ordering of the tests. (Bug#10164)
38 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
40 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
42 * xterm.c (handle_one_xevent): Only set async_visible and friends
43 if net_wm_state_hidden_seen is non-zero (Bug#10002)
44 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
45 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
47 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
49 Remove GCPRO-related macros that exist only to avoid shadowing locals.
50 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
51 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
52 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
53 All uses changed to use GCPRO1 etc.
54 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
55 Revert to old implementation (i.e., before 2011-03-11).
57 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
59 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
60 of scroll runs so as to avoid assigning disabled bogus rows and
61 unnecessary graphics copy operations.
63 2011-11-27 Eli Zaretskii <eliz@gnu.org>
65 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
66 (snprintf) [_MSC_VER]: Redirect to _snprintf.
67 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
68 (malloc, free, realloc, calloc): Redirect to e_* only when
71 * lisp.h (GCTYPEBITS): Move before first use.
72 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
73 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
74 this macro definition.
76 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
79 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
81 * gtkutil.c (xg_create_frame_widgets): Call
82 gtk_window_set_has_resize_grip (FALSE) if that function is
83 present with Gtk+ 2.0.
85 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
87 * fileio.c (Finsert_file_contents): Undo previous change; see
88 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
90 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
92 Rename locals to avoid shadowing.
93 * fileio.c (Finsert_file_contents):
94 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
95 * process.c (wait_reading_process_output):
96 Rename inner 'proc' to 'p' to avoid shadowing.
97 Indent for consistency with usual Emacs style.
99 2011-11-25 Eli Zaretskii <eliz@gnu.org>
101 * xdisp.c (redisplay_window): If cursor row is not fully visible
102 after recentering, and scroll-conservatively is set to a large
103 number, scroll window by a few more lines to make the cursor fully
104 visible and out of scroll-margin. (Bug#10105)
105 (start_display): Don't move to the next line if the display should
106 start at a newline that is part of a display vector or an overlay
109 2011-11-24 Juri Linkov <juri@jurta.org>
111 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
112 after the `MagickPingImage' call. (Bug#10112)
114 2011-11-23 Chong Yidong <cyd@gnu.org>
116 * window.c (Fcoordinates_in_window_p): Accept only live windows.
118 2011-11-23 Martin Rudalics <rudalics@gmx.at>
120 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
121 making another buffer current. (Bug#10114)
123 2011-11-23 Glenn Morris <rgm@gnu.org>
125 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
127 2011-11-23 Chong Yidong <cyd@gnu.org>
129 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
132 2011-11-22 Eli Zaretskii <eliz@gnu.org>
134 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
135 and header-lines, as they don't have one computed for them.
138 * .gdbinit (prow): Make displayed values more self-explaining.
141 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
143 * process.c (wait_reading_process_output): Fix asynchrounous
144 GnuTLS socket handling on some versions of the GnuTLS library.
145 (wait_reading_process_output): Add comment and URL.
147 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
149 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
151 2011-11-21 Chong Yidong <cyd@gnu.org>
153 * window.c (Fnext_window, Fprevious_window): Doc fix.
155 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
157 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
159 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
161 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
163 2011-11-20 Martin Rudalics <rudalics@gmx.at>
165 * window.c (Fset_window_combination_limit): Rename argument
167 (Vwindow_combination_limit): Remove "status" from doc-string.
169 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
171 * m/ibms390.h: Remove.
172 * m/ibms390x.h: Don't include "ibms390.h".
174 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
176 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
177 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
179 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
181 * casetab.c (Fset_case_table):
182 * charset.c (Fcharset_after): Fix typos.
184 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
186 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
187 Otherwise, valgrind does not work on some platforms.
188 Problem reported by Andreas Schwab in
189 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
190 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
191 is set, removing the need for VIRT_ADDRESS_VARIES.
192 (PURE_P): Use a more-efficient implementation that needs just one
193 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
194 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
195 to 4 (xorl, subq, cmpq, setbe).
196 * alloc.c (pure): Always extern now, since that's the
197 VIRT_ADDR_VARIES behavior.
198 (PURE_POINTER_P): Use a single comparison, not two, for
199 consistency with the new puresize.h.
200 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
201 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
202 Remove VIRT_ADDR_VARIES no longer needed.
204 2011-11-19 Eli Zaretskii <eliz@gnu.org>
206 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
207 (erase_phys_cursor, update_window_cursor, show_mouse_face)
208 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
209 behave as if the cursor position were at the window margin.
211 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
212 and the cursor position is out of bounds, behave as if the cursor
213 position were at the window margin. (Bug#10075)
215 2011-11-18 Chong Yidong <cyd@gnu.org>
217 * window.c (Fwindow_combination_limit): Make first argument
218 non-optional, since it is meaningless for live windows like the
221 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
223 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
225 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
227 * intervals.c: Fix grafting over the whole buffer (bug#10071).
228 (graft_intervals_into_buffer): Simplify.
230 2011-11-18 Eli Zaretskii <eliz@gnu.org>
232 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
233 hash values of the two rows.
234 (copy_row_except_pointers): Preserve the used[] arrays and the
235 hash values of the two rows. (Bug#10035)
236 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
238 * xdisp.c (row_hash): New function, body extracted from
239 compute_line_metrics.
240 (compute_line_metrics): Call row_hash, instead of computing the
243 * dispnew.c (verify_row_hash): Call row_hash for computing the
244 hash code of a row, instead of duplicating code from xdisp.c.
246 * dispextern.h (row_hash): Add prototype.
248 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
250 * frame.c (delete_frame): Don't delete the terminal when the last
251 X frame is closed if emacs is built with GTK toolkit.
253 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
255 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
257 2011-11-17 Martin Rudalics <rudalics@gmx.at>
259 * window.c (Vwindow_splits): Rename to
260 Vwindow_combination_resize. Suggested by Juri Linkov.
261 (Fsplit_window_internal): Use Vwindow_combination_resize instead
264 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
266 * nsfns.m (Fns_font_name):
267 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
269 2011-11-16 Martin Rudalics <rudalics@gmx.at>
271 * window.h (window): Rename slot "nest" to "combination_limit".
272 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
273 (Fset_window_nest): Rename to Fset_window_combination_limit.
274 (Vwindow_nest): Rename to Vwindow_combination_limit.
275 (recombine_windows, make_parent_window, make_window)
276 (Fsplit_window_internal, saved_window)
277 (Fset_window_configuration, save_window_save): Rename all
278 occurrences of window_nest to window_combination_limit.
280 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
282 * image.c (imagemagick_load_image): Fix typo.
284 2011-11-14 Eli Zaretskii <eliz@gnu.org>
286 * xdisp.c (display_line): Move the call to
287 highlight_trailing_whitespace before the call to
288 compute_line_metrics, since the latter needs to see the final
289 faces of all the glyphs to compute ROW's hash value. Fixes
290 assertion violations in row_equal_p. (Bug#10035)
292 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
294 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
295 just return (bug#10044).
297 2011-11-12 Eli Zaretskii <eliz@gnu.org>
299 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
300 with user-defined heap size. Bump the default size of the temacs
301 heap to 27MB, to avoid memory warning when running temacs.
302 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
304 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
305 current_matrix and desired_matrix. (Bug#9990)
306 (verify_row_hash) [XASSERTS]: New function.
307 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
308 that the hash value of glyph rows is correct.
310 2011-11-12 Martin Rudalics <rudalics@gmx.at>
312 * window.h (window): Remove splits slot.
313 * window.c (Fwindow_splits, Fset_window_splits): Remove.
314 (Fdelete_other_windows_internal, make_parent_window)
315 (make_window, Fsplit_window_internal, Fdelete_window_internal)
316 (Fset_window_configuration, save_window_save): Don't deal with
317 split status of windows.
318 (saved_window): Remove splits slot.
319 (Vwindow_splits): Rewrite doc-string.
321 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
323 * xfns.c (unwind_create_frame):
324 * nsfns.m (unwind_create_frame):
325 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
326 Vframe_list (Bug#9999).
328 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
330 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
332 2011-11-11 Kenichi Handa <handa@m17n.org>
334 * callproc.c (Fcall_process): Set the member dst_multibyte of
337 2011-11-11 Johan Bockgård <bojohan@gnu.org>
339 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
340 avoid a crash (bug#9496).
342 2011-11-09 Chong Yidong <cyd@gnu.org>
344 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
345 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
347 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
349 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
351 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
353 Avoid some portability problems by eschewing 'extern inline' functions.
354 The trivial performance wins aren't worth the portability hassles; see
355 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
357 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
358 (window_box_width, window_box_left, window_box_left_offset)
359 (window_box_right, window_box_right_offset): Undo previous change,
360 by removing the "extern"s.
361 * intervals.c (adjust_intervals_for_insertion)
362 (adjust_intervals_for_deletion): Undo previous change,
363 making these static again.
364 (offset_intervals, temp_set_point_both, temp_set_point)
365 (copy_intervals_to_string): No longer inline.
366 * xdisp.c (window_text_bottom_y, window_box_width)
367 (window_box_height, window_box_left_offset)
368 (window_box_right_offset, window_box_left, window_box_right)
369 (window_box): No longer inline.
371 2011-11-08 Chong Yidong <cyd@gnu.org>
373 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
374 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
375 an error if not a live window.
376 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
377 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
379 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
381 * lisp.h (syms_of_abbrev): Remove declaration.
382 Reported by CHENG Gao <chenggao@royau.me>.
384 2011-11-07 Eli Zaretskii <eliz@gnu.org>
386 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
387 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
388 of temacs in GUI mode.
390 2011-11-07 Martin Rudalics <rudalics@gmx.at>
392 * window.h: Declare delete_all_child_windows instead of
393 delete_all_subwindows.
394 * window.c (Fwindow_nest, Fset_window_nest)
395 (Fset_window_new_total, Fset_window_new_normal)
396 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
397 (delete_all_subwindows): Rename to delete_all_child_windows.
398 (Fdelete_other_windows_internal, Fset_window_configuration):
399 Call delete_all_child_windows instead of delete_all_subwindows.
400 * frame.c (delete_frame): Call delete_all_child_windows instead
401 of delete_all_subwindows.
403 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
405 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
406 This is also needed for porting to any host where GC_MARK_STACK is
407 not GC_MAKE_GCPROS_NOOPS.
408 (which_symbols): Use it.
410 2011-11-07 Kenichi Handa <handa@m17n.org>
412 * coding.c (coding_set_destination): Check coding->src_pos only
413 when coding->src_object is a buffer (bug#9910).
415 * process.c (send_process): Set the member src_multibyte of coding
416 to 0 (bug#9911) when sending a unibyte text.
418 * callproc.c (Fcall_process): Set the member src_multibyte of
419 process_coding to 0 (bug#9912).
421 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
423 * xmenu.c (cleanup_widget_value_tree): New function.
424 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
425 calling free_menubar_widget_value_tree directly (Bug#9830).
427 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
429 Fix some portability problems with 'inline'.
430 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
431 (window_box_width, window_box_left, window_box_left_offset)
432 (window_box_right, window_box_right_offset): Declare extern.
433 Otherwise, these inline functions do not conform to C99 and
434 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
435 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
436 * intervals.c (adjust_intervals_for_insertion)
437 (adjust_intervals_for_deletion): Now extern, because otherwise the
438 extern inline functions 'offset_intervals' couldn't refer to it.
439 (static_offset_intervals): Remove.
440 (offset_intervals): Rewrite using the old contents of
441 static_offset_intervals. The old version didn't conform to C99
442 because an extern inline function contained a reference to an
443 identifier with static linkage.
445 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
447 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
450 2011-11-06 Eli Zaretskii <eliz@gnu.org>
452 * xdisp.c (init_iterator, reseat_to_string): Don't set the
453 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
454 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
455 return Qleft_to_right.
457 2011-11-06 Chong Yidong <cyd@gnu.org>
459 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
460 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
461 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
462 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
463 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
464 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
465 (Fwindow_vscroll): Doc fix.
466 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
467 argument, since it makes no sense to pass a live window and for
468 consistency with window-child.
470 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
472 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
475 2011-11-05 Jason Rumney <jasonr@gnu.org>
477 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
478 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
480 (add_font_entity_to_list): Fix logic errors in mixed boolean and
481 bitwise arithmetic preventing use of unicode-sip and non-truetype
484 2011-11-05 Eli Zaretskii <eliz@gnu.org>
486 * s/ms-w32.h (fstat, stat, utime): Move redirections to
489 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
490 initialization code to keep similarity to xfns.c after changes
493 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
495 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
496 (unwind_create_frame): New function (Bug#9943).
497 (Fx_create_frame): Restructure code to be more similar to the one in
498 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
499 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
500 Move terminal->reference_count++ just before making the frame official
503 * nsterm.m (x_free_frame_resources): New function.
504 (x_destroy_window): Move code to x_free_frame_resources.
506 * xfns.c (unwind_create_frame): Fix comment.
507 (Fx_create_frame, x_create_tip_frame): Move
508 terminal->reference_count++ just before making the frame
509 official. Move initialization of image_cache_refcount and
510 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
512 2011-11-05 Eli Zaretskii <eliz@gnu.org>
514 Support MSVC build with newer versions of Visual Studio.
515 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
516 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
519 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
520 which are not supported by MSVC.
521 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
522 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
524 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
526 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
528 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
530 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
532 Support MSVC build with newer versions of Visual Studio.
533 * w32.c: Don't include w32api.h for MSVC.
534 (init_environment) [_MSC_VER]: Call sys_access, not _access.
536 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
537 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
538 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
539 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
541 (alloca) [_MSC_VER]: Define to _alloca.
543 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
545 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
547 2011-11-04 Eli Zaretskii <eliz@gnu.org>
549 * xdisp.c (note_mouse_highlight): If either of
550 previous/next-single-property-change returns nil, treat that as
551 the beginning or the end of the buffer. (Bug#9955)
553 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
555 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
556 label is not null (Bug#9951).
557 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
560 2011-11-04 Eli Zaretskii <eliz@gnu.org>
562 * window.c (Fwindow_body_size): Mention in the doc string that the
563 return value is in frame's canonical units. (Bug#9949)
565 2011-11-03 Eli Zaretskii <eliz@gnu.org>
567 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
569 * w32fns.c (unwind_create_frame): If needed, free the glyph
570 matrices of the partially constructed frame. (Bug#9943)
571 * xfns.c (unwind_create_frame): Likewise.
573 2011-11-01 Eli Zaretskii <eliz@gnu.org>
575 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
576 Don't stop backward scan on the continuation glyph, even though
577 its CHARPOS is positive.
578 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
579 cover_string to disp_string.
581 2011-11-01 Martin Rudalics <rudalics@gmx.at>
583 * window.c (temp_output_buffer_show): Don't use
584 Vtemp_buffer_show_specifiers.
585 (Vtemp_buffer_show_specifiers): Remove unused variable.
587 2011-10-30 Eli Zaretskii <eliz@gnu.org>
589 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
590 past the beginning of the current glyph matrix.
592 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
594 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
595 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
596 HAVE_GTK3 (Bug#9869).
598 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
599 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
601 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
603 * xterm.c: Declare x_handle_net_wm_state to return int.
604 (handle_one_xevent): Check if we are iconified but don't have
605 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
606 (get_current_wm_state): Return non-zero if not hidden,
607 check for _NET_WM_STATE_HIDDEN (Bug#9893).
608 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
609 (x_handle_net_wm_state): Return what get_current_wm_state returns.
610 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
612 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
614 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
615 so that this new function doesn't get optimized away by a
616 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
618 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
620 * frame.h (MOUSE_HL_INFO): Remove excess parens.
622 2011-10-29 Eli Zaretskii <eliz@gnu.org>
624 Fix the `xbytecode' command.
625 * .gdbinit (xprintbytestr): New command.
626 (xwhichsymbols): Rename from `which'; all callers changed.
627 (xbytecode): Print the byte-code string as well.
629 2011-10-29 Kim Storm <storm@cua.dk>
631 * alloc.c (which_symbols): New function.
633 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
635 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
638 2011-10-29 Glenn Morris <rgm@gnu.org>
640 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
641 Not clear what it was for, and it causes various bugs. (Bug#9839)
643 2011-10-28 Eli Zaretskii <eliz@gnu.org>
645 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
646 possible random value that matches one of those tested as
647 condition to clear the mouse face.
649 2011-10-28 Chong Yidong <cyd@gnu.org>
651 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
653 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
655 * window.c (make_window): Initialize phys_cursor_on_p.
657 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
659 * lisp.h (struct Lisp_Symbol): Update comments.
661 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
663 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
665 2011-10-28 Eli Zaretskii <eliz@gnu.org>
667 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
668 <oslsachem@gmail.com> for helping to debug this.
670 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
671 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
672 (g_b_init_get_glyph_outline_w): New static variables.
673 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
674 (GetGlyphOutlineW_Proc): New typedefs.
675 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
676 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
678 (w32font_open_internal, compute_metrics):
679 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
680 instead of calling the "wide" APIs directly.
682 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
684 * w32.h (syms_of_w32font): Add prototype.
686 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
688 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
689 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
690 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
691 (Fmove_to_window_line): Doc fix.
693 2011-10-27 Chong Yidong <cyd@gnu.org>
695 * process.c (make_process): Set gnutls_state to NULL.
697 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
698 non-NULL, regardless of GNUTLS_INITSTAGE.
699 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
700 an error. Set process slots as soon as we allocate them.
702 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
704 2011-10-27 Chong Yidong <cyd@gnu.org>
706 * gnutls.c (emacs_gnutls_deinit): New function.
707 Deallocate credentials structures as well as calling gnutls_deinit.
708 (Fgnutls_deinit, Fgnutls_boot): Use it.
710 * process.c (make_process): Initialize GnuTLS credentials to NULL.
711 (deactivate_process): Call emacs_gnutls_deinit.
713 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
715 * image.c (x_create_x_image_and_pixmap):
716 * w32.c (sys_rename, w32_delayed_load):
717 * w32font.c (fill_in_logfont):
718 * w32reg.c (x_get_string_resource): Silence compiler warnings.
720 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
722 * w32fns.c (w32_default_color_map): New function,
723 extracted from Fw32_default_color_map.
724 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
726 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
728 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
730 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
732 * keyboard.c (test_undefined): New function (bug#9751).
733 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
735 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
737 * sysdep.c (init_sys_modes): Fix the check for the controlling
740 2011-10-20 Eli Zaretskii <eliz@gnu.org>
742 * dispextern.h (struct bidi_it): New member next_en_type.
744 * bidi.c (bidi_line_init): Initialize the next_en_type member.
745 (bidi_resolve_explicit_1): When next_en_pos is valid for the
746 current character, check also for next_en_type being WEAK_EN.
747 (bidi_resolve_weak): Don't enter the expensive loop if the current
748 position is before next_en_pos. Record the bidi type of the first
749 non-ET, non-BN character we find, in addition to its position.
750 (bidi_level_of_next_char): Invalidate next_en_type when
751 next_en_pos is over-stepped.
753 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
755 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
756 * editfns.c: Rewrite current-time-zone so that it invokes
757 the equivalent of (format-time-string "%Z") to get the time zone name.
758 This fixes a bug when the time zone name contains characters that
759 need converting from the system time locale to Emacs internal format.
760 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
761 that patch fixed format-time-string to do the conversion, but
762 I forgot to fix current-time-zone.
763 (format_time_string): New function, containing most of
764 what Fformat_time_string used to contain.
765 (Fformat_time_string): Rewrite in terms of format_time_string.
766 This doesn't change this function's behavior.
767 (current-time-zone): Rewrite to use format_time_string.
768 This fixes the bug reported by Michael Schierl in
769 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
770 Jason Rumney's 2007-06-07 change worked around this bug, but
772 * systime.h (tzname, timezone): Remove no-longer-used declarations.
774 2011-10-19 Eli Zaretskii <eliz@gnu.org>
776 * xdisp.c (start_display): If the character at POS is displayed
777 via a display vector, reset IT->current.dpvec_index to zero.
778 (try_window_reusing_current_matrix): If a line ends in a display
779 vector or the next line starts in a display vector, continue
780 redrawing the window even though the character position of
781 start_row was reached.
784 2011-10-18 Chong Yidong <cyd@gnu.org>
786 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
787 with nobreak-char-display too.
789 2011-10-18 Eli Zaretskii <eliz@gnu.org>
791 Fix part 3 of bug#9771.
792 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
793 (bidi_resolve_neutral): Don't enter the expensive loop looking for
794 non-neutral characters if the current character is a paragraph
795 separator (a.k.a. Newline). This avoids running the same
796 expensive loop twice, once when we consume the preceding newline
797 and the other time when the line actually needs to be displayed.
798 Avoid the loop when we see neutrals on the base embedding level
799 following a character whose directionality is the same as the
800 paragraph's. This avoids running the expensive loop when a line
801 ends in a long sequence of neutrals, like control characters.
802 Add assertion against STRONG_AL type. Slightly rearrange code
803 that determines the type of a neutral given the first non-neutral
805 (bidi_level_of_next_char): Set next_en_pos to zero when
806 invalidating its info.
808 2011-10-17 Eli Zaretskii <eliz@gnu.org>
810 * xdisp.c (push_display_prop): Determine whether to record string
811 or buffer position by IT->string, not by IT->method. Allow
812 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
813 (move_it_vertically_backward): Don't look for character position
814 immediately after the newline when in a continuation line.
817 2011-10-15 Martin Rudalics <rudalics@gmx.at>
819 * window.c (coordinates_in_window): Rewrite and delabelize
820 vertical border check. (Bug#5357) (Bug#9618)
822 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
824 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
825 errors in XSetWindowBorder (bug#9310).
827 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
829 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
830 avoid crash when xmalloc overrun checking is enabled.
832 2011-10-13 Eli Zaretskii <eliz@gnu.org>
834 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
835 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
836 cursor motion with <left> and <right> arrow keys.
838 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
839 some callers set that themselves.
841 2011-10-12 Eli Zaretskii <eliz@gnu.org>
843 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
844 display string and the previous row comes from the same string and
845 is empty. (Bug#9739) (Bug#9738)
847 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
849 * doc.c (get_doc_string): Encode file name (bug#9735).
851 2011-10-12 Eli Zaretskii <eliz@gnu.org>
853 * bidi.c (bidi_level_of_next_char):
854 * xdisp.c (get_visually_first_element): Remove old incorrect
855 comments regarding the Unicode Line Separator character.
857 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
859 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
861 * alloc.c (Fgc_status): Do not access beyond zombies array
862 boundary if nzombies > MAX_ZOMBIES.
863 * alloc.c (dump_zombies): Add missing format specifier.
865 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
867 * xdisp.c (set_cursor_from_row): Simplify conditionals,
868 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
870 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
871 Some packages use them to denote characters with modifiers.
873 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
875 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
876 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
877 matching a pp-number. Rename parameter var to var1.
879 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
881 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
883 2011-10-08 Glenn Morris <rgm@gnu.org>
885 * callint.c (Fcall_interactively): Give a more explicit error for the
886 'c' case with a non-character input. (Bug#8479)
888 2011-10-08 Eli Zaretskii <eliz@gnu.org>
890 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
892 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
893 lines that are hscrolled on the left.
895 * dispnew.c (buffer_posn_from_coords): Account for a possible
896 presence of header-line. (Bug#4426)
898 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
900 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
901 Don't advertise functionality which we discourage or doesn't work.
903 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
905 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
906 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
907 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
908 this makes Emacs dump core during garbage collection on rare
909 occasions. sizeof is obviously inferior to offsetof here, so
911 (GC_POINTER_ALIGNMENT): New macro.
912 (mark_memory): Omit 3rd (offset) arg; caller changed.
913 Don't assume EMACS_INT alignment is the same as pointer alignment.
915 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
917 * keyboard.c (read_key_sequence_remapped): New var.
918 (read_key_sequence): Compute remapping in the right buffer.
919 (command_loop_1): Use read_key_sequence's remapping directly.
921 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
923 * dired.c (file_name_completion): Don't expand file name.
924 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
925 before checking file name handler.
927 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
928 they've been requested explicitly (bug#9591).
930 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
932 * keymap.c (Fsingle_key_description): Use make_specified_string
933 instead of build_string to build string from push_key_description.
936 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
938 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
939 This fixes a Y2038 bug on 64-bit hosts.
940 * buffer.c (reset_buffer):
941 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
942 (Fclear_buffer_auto_save_failure):
943 Use 0, not -1, to represent an unset failure time, since time_t
946 Remove dependency on glibc malloc internals.
947 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
948 Move back here from lisp.h, but with their new implementations.
949 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
950 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
951 * charset.c (charset_table_init): New static var.
952 (syms_of_charset): Use it instead of xmalloc. This removes a
953 dependency on glibc malloc internals. See Eli Zaretskii's comment in
954 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
955 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
956 Move back to alloc.c.
957 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
958 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
960 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
962 * nsterm.m (windowDidResize): Call x_set_window_size only when
963 ns_in_resize is true. Otherwise set pixelwidth/height and
964 call change_frame_size (Bug#9628).
966 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
968 Port --enable-checking=all to Fedora 14 x86-64.
969 * charset.c (syms_of_charset): Also account for glibc malloc's
970 internal overhead when calculating the initial malloc maximum.
972 Port --enable-checking=all to Fedora 14 x86.
973 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
975 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
976 (overrun_check_realloc, overrun_check_free):
977 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
978 That way, xmalloc returns a properly-aligned pointer even if
979 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
980 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
981 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
982 into account when calculating the initial malloc maximum.
983 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
984 Move here from alloc.c, so that charset.c can use it too.
985 Properly align; the old code wasn't right for common 32-bit hosts
986 when configured with --enable-checking=all.
987 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
988 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
990 2011-09-29 Eli Zaretskii <eliz@gnu.org>
992 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
995 2011-09-28 Eli Zaretskii <eliz@gnu.org>
997 * xdisp.c (compute_display_string_end): If there's no display
998 string at CHARPOS, return -1.
1000 * bidi.c (bidi_fetch_char): When compute_display_string_end
1001 returns a negative value, treat the character as a normal
1002 character not covered by a display string. (Bug#9624)
1004 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1006 * lread.c (Fread_from_string): Fix typo in docstring.
1008 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1010 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1011 newline, reseat the iterator instead of bidi-iterating there one
1012 character at a time. (Bug#9610)
1013 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1014 TO_CHARPOS if the bidi iterator is at base embedding level.
1016 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1018 * lread.c (readevalloop): Use correct code for NBSP.
1019 (read1): Likewise. (Bug#9608)
1021 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1023 * dbusbind.c (Fdbus_register_signal): When service is not
1024 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1026 2011-09-25 Glenn Morris <rgm@gnu.org>
1028 * buffer.c (truncate-lines): Doc fix.
1030 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1032 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1033 (Fset_window_next_buffers): Doc fix.
1035 2011-09-24 Glenn Morris <rgm@gnu.org>
1037 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1039 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1041 Fix minor problems found by static checking.
1042 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1043 * indent.c (Fvertical_motion): Fix == vs = typo.
1045 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1047 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1048 Default value is now t. Doc fix.
1050 * indent.c (Fvertical_motion): Compute and apply the overshoot
1051 logic when moving up, not only when moving down. Fix the
1052 confusing name and values of the it_overshoot_expected variable;
1053 logic changes accordingly. (Bug#9254) (Bug#9549)
1055 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1056 CHARPOS is covered by a display string which includes newlines.
1057 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1058 is covered by a display string with embedded newlines.
1060 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1062 * dbusbind.c (Fdbus_register_signal): Add match rule to
1063 Vdbus_registered_objects_table. (Bug#9581)
1064 (Fdbus_register_method, Vdbus_registered_objects_table):
1067 2011-09-24 Jim Meyering <meyering@redhat.com>
1069 do not ignore write error for any output size
1070 The previous change was incomplete.
1071 While it makes emacs --batch detect the vast majority of stdout
1072 write failures, errors were still ignored whenever the output size is
1073 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1074 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1075 && echo FAIL: ignored write error
1076 FAIL: ignored write error
1077 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1078 && echo FAIL: ignored write error
1079 FAIL: ignored write error
1080 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1082 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1084 * emacs.c (Fkill_emacs): In noninteractive mode exit
1085 non-successfully if a write error occurred on stdout. (Bug#9574)
1087 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1089 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1092 * dispextern.h (struct it): Update the comment documenting what
1095 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1097 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1098 a display string, extend search for cursor position to end of row.
1099 (find_row_edges): If the row ends in a newline from a display
1100 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1101 Handle the case of a display string with multiple newlines.
1102 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1103 non-empty line. Fixes confusing cursor motion with arrow keys at
1104 the beginning of a line that starts with whitespace.
1106 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1108 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1111 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1113 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1116 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1118 * xdisp.c (display_line): Record maximum and minimum buffer
1119 positions even if no glyphs were produced (e.g., by a zero-width
1120 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1121 buffer positions that will be removed from the glyph row because
1123 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1124 column is beyond frame width: don't subtract 1 "pixel" when
1125 computing width of the stretch.
1126 (reseat_at_next_visible_line_start): Undo the change made on
1127 2011-09-17 that saved paragraph information and restored it after
1128 the call to `reseat'. (Bug#9545)
1130 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1132 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1133 and turn window cursor on if cleared (Bug#9415).
1135 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1137 * search.c (boyer_moore): Take unibyte characters from pattern
1138 literally. (Bug#9458)
1140 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1142 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1144 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1146 Fix minor problem found by static checking.
1147 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1148 initialized, to pacify gcc -Wuninitialized.
1150 * fileio.c: Report proper errno when syscall falls.
1151 (Finsert_file_contents): Save and restore errno,
1152 so that report_file_error outputs the correct diagnostic.
1153 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1155 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1157 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1159 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1161 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1162 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1164 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1166 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1167 about the current paragraph and restore it after the call to reseat.
1169 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1170 (bidi_find_paragraph_start): Search back for paragraph beginning
1171 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1172 (bidi_move_to_visually_next): Only trigger paragraph-related
1173 computations when the last character is a newline or at EOB, not
1174 just any NEUTRAL_B. (Bug#9470)
1176 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1177 truncated lines if point is covered by a display string. (Bug#9524)
1179 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1181 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1182 (cons_to_x_long): New function.
1183 (lisp_data_to_selection_data): Use it. Correct the test for
1184 short-versus-long data; it was negated. Break out of vector
1185 loop, for efficiency, when a long datum is discovered.
1187 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1189 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1191 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1193 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1194 GCC PR/17406) by declaring this function with external scope.
1196 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1198 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1199 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1201 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1203 * editfns.c (Fformat): Correctly handle text properties on "%%".
1205 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1207 * xterm.c (x_draw_composite_glyph_string_foreground):
1208 * w32term.c (x_draw_composite_glyph_string_foreground):
1209 * term.c (encode_terminal_code):
1210 * composite.c (composition_update_it, get_composition_id):
1211 * xdisp.c (get_next_display_element)
1212 (fill_composite_glyph_string): Add comments about special meaning
1213 of TAB characters in a composition.
1215 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1217 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1218 This occurs when processing a multibyte format.
1219 Problem reported by Wolfgang Jenker.
1221 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1223 * xdisp.c (try_cursor_movement): Only check for exact match if
1224 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1226 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1228 Remove unused external symbols.
1229 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1230 * xdisp.c (calc_pixel_width_or_height): Now static.
1231 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1232 * indent.c (check_display_width):
1233 * w32term.c: Fix comment to match code.
1234 * xterm.c, xterm.h (x_catching_errors): Remove.
1236 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1238 * xselect.c: Use signed conversions more consistently (Bug#9498).
1239 (selection_data_to_lisp_data): Assume incoming selection data are
1240 signed integers, not unsigned. This is to be consistent with
1241 outgoing selection data, which was modified to use signed integers
1242 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1243 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1244 expects long, not unsigned long.
1246 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1248 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1249 computation of loop end. Reported by Johan Bockgård
1252 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1254 * frame.c (Fother_visible_frames_p): Function deleted.
1256 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1258 * indent.c (compute_motion): Process display vector front to back
1259 rather than the other way around. (Bug#2496)
1261 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1263 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1265 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1267 * minibuf.c (Fread_from_minibuffer): Doc fix.
1269 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1271 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1272 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1274 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1276 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1277 value for non-existent files.
1279 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1281 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1282 set its "size" to -1. This will set the modtime_size field of
1283 the corresponding buffer to -1, which is what
1284 verify-visited-file-modtime expects for files that do not exist.
1287 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1289 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1291 * lisp.h: ... from here. push_key_description is no longer
1292 defined in keyboard.c, so its declaration should not be in
1293 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1294 logically belongs with push_key_description.
1296 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1298 * buffer.h: Include <sys/types.h> instead of <time.h>.
1299 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1300 Problem reported by Herbert J. Skuhra.
1302 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1304 * xml.c (parse_region): Make the parsing work for
1305 non-comment-starting XML files again (bug#9144).
1307 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1309 * image.c (gif_load): Fix calculation of bottom and right corner.
1312 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1314 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1315 redisplay in small windows.
1317 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1319 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1321 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1323 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1324 Operate on live windows only.
1326 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1328 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1330 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1332 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1333 only under bidi iteration.
1335 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1337 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1339 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1341 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1342 Without this fix, the command to link temacs failed due to an
1343 undefined symbol __builtin_isnan. This is because
1344 /usr/include/iso/math_c99.h #defines isnan(x) to
1345 __builtin_isnan(x), but the bundled gcc, which identifies itself
1346 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1348 * floatfns.c (isnan): #undef, and then #define to a clone of
1350 (Fisnan): Always define, since it's always available now.
1351 (syms_of_floatfns): Always define isnan at the Lisp level.
1353 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1355 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1357 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1359 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1360 The previous code assumed that file offsets (off_t values) fit in
1361 EMACS_INT variables, which is not true on typical 32-bit hosts.
1362 The code messed up by falsely reporting buffer overflow in cases
1363 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1364 when "big" contains more than 2**29 bytes, even though this
1365 inserts just one byte and does not overflow the buffer.
1366 (Finsert_file_contents): Store file offsets as off_t
1367 values, not as EMACS_INT values. Check for overflow when
1368 converting between EMACS_INT and off_t. When checking for
1369 buffer overflow or for overlap, take the offsets into account.
1370 Don't use EMACS_INT for small values where int suffices.
1371 When checking for overlap, fix a typo: ZV was used where
1372 ZV_BYTE was intended.
1373 (Fwrite_region): Don't assume off_t fits into 'long'.
1374 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1376 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1378 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1380 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1382 sprintf-related integer and memory overflow issues (Bug#9412).
1384 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1385 (esprintf, exprintf, evxprintf): New functions.
1386 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1387 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1388 (modify_event_symbol): Do not assume that the length of
1389 name_alist_or_stem is safe to alloca and fits in int.
1390 (Fexecute_extended_command): Likewise for function name and binding.
1391 (Frecursion_depth): Wrap around reliably on integer overflow.
1392 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1393 since some callers pass EMACS_INT values.
1394 (Fsingle_key_description): Don't crash if symbol name contains more
1395 than MAX_ALLOCA bytes.
1396 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1397 (get_minibuffer): Arg is now EMACS_INT, not int.
1398 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1399 (esprintf, exprintf, evxprintf): New decls.
1400 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1402 * dbusbind.c (signature_cat): New function.
1403 (xd_signature, Fdbus_register_signal):
1404 Do not overrun buffer; instead, report string overflow.
1406 * dispnew.c (add_window_display_history): Don't overrun buffer.
1407 Truncate instead; this is OK since it's just a log.
1409 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1410 even if the time zone offset is outlandishly large.
1411 Don't mishandle offset == INT_MIN.
1413 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1414 when creating daemon; the previous buffer-overflow check was incorrect.
1416 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1417 which has the guts of the old verror function.
1419 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1420 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1422 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1423 (font_unparse_xlfd): Don't blindly alloca long strings.
1424 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1425 fits in int, when using sprintf. Use single snprintf to count
1426 length of string rather than counting it via multiple sprintfs;
1427 that's simpler and more reliable.
1428 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1429 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1430 sprintf, in case result does not fit in int.
1432 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1433 (fontset_from_font): Print it.
1435 * frame.c (tty_frame_count): Now printmax_t, not int.
1436 (make_terminal_frame, set_term_frame_name): Print it.
1437 (x_report_frame_params): In X, window IDs are unsigned long,
1438 not signed long, so print them as unsigned.
1439 (validate_x_resource_name): Check for implausibly long names,
1440 and don't assume name length fits in 'int'.
1441 (x_get_resource_string): Don't blindly alloca invocation name;
1442 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1445 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1446 (xg_check_special_colors, xg_set_geometry):
1447 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1449 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1450 Use esprintf, not sprintf, in case result does not fit in int.
1452 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1453 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1454 it as a large positive number.
1455 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1456 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1458 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1459 in case result does not fit in int.
1461 * print.c (float_to_string): Detect width overflow more reliably.
1462 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1463 buffer overrun. Don't assume list length fits in 'int'. Treat
1464 print length of 0 as 0, not as infinity; to be consistent with other
1465 uses of print length in this function. Don't overflow print length
1466 index. Don't assume hash table size fits in 'long', or that
1467 vectorlike size fits in 'unsigned long'.
1469 * process.c (make_process): Use printmax_t, not int, to format
1470 process-name gensyms.
1472 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1474 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1475 to avoid potential buffer overrun.
1477 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1478 if X resource line is longer than 512 bytes.
1480 * xfns.c (x_window): Make sprintf buffer a bit bigger
1481 to avoid potential buffer overrun.
1483 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1485 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1487 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1489 Integer overflow fixes for scrolling, etc.
1490 Without these, Emacs silently mishandles large integers sometimes.
1491 For example, "C-u 4294967297 M-x recenter" was treated as if
1492 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1494 * xdisp.c (try_window_id): Check Emacs fixnum range before
1495 converting to 'int'.
1497 * window.c (window_scroll_line_based, Frecenter):
1498 Check that an Emacs fixnum is in range before assigning it to 'int'.
1499 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1500 values converted from Emacs fixnums.
1501 (Frecenter): Don't wrap around a line count if it is out of 'int'
1502 range; instead, treat it as an extreme value.
1503 (Fset_window_configuration, compare_window_configurations):
1504 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1506 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1507 that can exceed INT_MAX. Check that EMACS_INT value is in range
1508 before assigning it to the (possibly-narrower) index.
1509 (match_limit): Don't assume that a fixnum can fit in 'int'.
1511 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1514 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1515 (Fvertical_motion): Don't wrap around LINES values that don't fit
1516 in 'int'. Instead, treat them as extreme values. This is good
1517 enough for windows, which can't have more than INT_MAX lines anyway.
1519 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1521 * Require libxml/parser.h to avoid compilation warning.
1523 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1525 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1526 since this reportedly can destroy thread storage.
1528 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1530 * syntax.c (find_defun_start): Update all cache variables if
1531 exiting early (Bug#9401).
1533 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1535 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1537 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1538 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1539 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1541 * term.c (tty_append_glyph): New function.
1542 (produce_stretch_glyph): Static function and its prototype deleted.
1544 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1547 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1549 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1550 when checking :margin (Bug#9390).
1551 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1552 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1553 so that the name doesn't mislead. All uses changed.
1555 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1557 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1560 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1562 * xdisp.c (move_it_to): Don't bail out early when reaching
1563 position beyond to_charpos, if we are scanning backwards.
1564 (move_it_vertically_backward): When DY == 0, make sure we get to
1565 the first character in the line after the newline.
1567 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1569 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1570 (ccl_driver): Do not generate an out-of-range pointer.
1571 (Fccl_execute_on_string): Remove unnecessary check for
1572 integer overflow, noted by Stefan Monnier in
1573 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1574 Remove a FIXME that didn't need fixing.
1575 Simplify the newly-introduced buffer reallocation code.
1577 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1579 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1581 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1583 Integer and memory overflow issues (Bug#9196).
1585 * doc.c (get_doc_string): Rework so that
1586 get_doc_string_buffer_size is the actual buffer size, rather than
1587 being 1 less than the actual buffer size; this makes xpalloc more
1590 * image.c (x_allocate_bitmap_record, cache_image):
1591 * xselect.c (Fx_register_dnd_atom):
1592 Simplify previous changes by using xpalloc.
1594 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1595 since either will do and ptrdiff_t is convenient with xpalloc.
1597 * charset.c (charset_table_size)
1598 (struct charset_sort_data.priority): Now ptrdiff_t.
1599 (charset_compare): Don't overflow if priorities differ greatly.
1600 (Fsort_charsets): Don't assume list length fits in int.
1601 Check for size-calculation overflow when allocating sort data.
1602 (syms_of_charset): Allocate an initial charset table that is
1603 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1605 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1607 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1608 The actual value is always <= INT_MAX, and leaving it unsigned made
1609 overflow checking harder.
1611 * dispextern.h (struct glyph_matrix.rows_allocated)
1612 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1613 with xpalloc. The values are still always <= INT_MAX.
1615 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1617 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1618 (SAFE_NALLOCA): New macro.
1620 * region-cache.c (struct boundary.pos, find_cache_boundary)
1621 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1622 (set_cache_region, invalidate_region_cache)
1623 (revalidate_region_cache, know_region_cache, region_cache_forward)
1624 (region_cache_backward, pp_cache):
1625 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1626 so that ptrdiff_t * can be passed to xpalloc.
1627 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1628 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1629 (pp_cache): Don't assume cache_len fits in int.
1630 * region-cache.h: Adjust extern decls to match.
1632 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1633 EMACS_INT, since either will do, for xpalloc.
1635 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1636 (xnmalloc, xnrealloc, xpalloc): New functions.
1638 * bidi.c (bidi_shelve_header_size): New constant.
1639 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1640 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1642 * bidi.c (bidi_cache_shrink):
1643 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1645 Don't update size of array until after memory allocation succeeds,
1646 because xmalloc/xrealloc may not return.
1647 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1648 now that we have proper integer overflow checking.
1649 (record_overlay_string, overlay_strings): Catch overflows when
1650 calculating size of overlay_str_buf.
1652 * callproc.c (Fcall_process): Check for size overflow when
1653 calculating size of args2.
1654 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1655 Normally we prefer signed values, but sticking with ptrdiff_t would
1656 require adding more-complicated checks.
1658 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1659 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1660 Redo buffer-overflow calculations to avoid integer overflow.
1661 Add a FIXME comment where memory seems to be over-allocated.
1663 * character.c (Fstring): Check for size-calculation overflow.
1665 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1666 unnecessary integer overflow. Check for size overflow.
1667 (encode_coding_object): Don't update size until xmalloc succeeds.
1669 * composite.c (get_composition_id): Check for overflow in glyph
1670 length calculations.
1672 Integer and memory overflow fixes for display code.
1673 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1674 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1675 (scrolling_window): Check for overflow in size calculations.
1676 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1677 Don't assume glyph table len fits in int.
1678 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1679 (row_table_size): Now ptrdiff_t, not int.
1680 (scrolling_window): Avoid overflow in size calculations.
1681 Don't update size until allocation succeeds.
1682 * fns.c (concat): Check for overflow in size calculations.
1683 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1684 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1685 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1687 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1688 (get_doc_string): Check for size calculation overflow.
1689 Don't update size until allocation succeeds.
1690 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1691 EMACS_INT, where ptrdiff_t will do.
1692 (Fsubstitute_command_keys): Check for string overflow.
1694 * editfns.c (set_time_zone_rule): Don't assume environment length
1696 (message_length): Now ptrdiff_t, not int.
1697 (Fmessage_box): Don't update size until allocation succeeds.
1698 Don't assume message length fits in int.
1699 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1701 * emacs.c (main): Do not reallocate argv, since there is a null at
1702 the end that can be overwritten, and this way there's no need to
1703 worry about size-calculation overflow.
1704 (sort_args): Check for size-calculation overflow.
1706 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1708 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1710 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1711 (x_set_scroll_bar_width, x_figure_window_size):
1712 Check for integer overflow.
1713 (x_set_alpha): Do not assume XINT fits in int.
1715 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1716 This is for the members text_lines, text_cols, total_lines, total_cols,
1717 where the system imposes an 'int' limit.
1719 * fringe.c (Fdefine_fringe_bitmap):
1720 Don't update size until alloc works.
1722 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1723 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1725 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1726 Check for size-calculation overflow.
1727 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1728 do, as we prefer signed integers.
1729 (id_to_widget.max_size, id_to_widget.used)
1730 (xg_store_widget_in_map, xg_remove_widget_from_map)
1731 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1732 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1733 Use and return ptrdiff_t, not int.
1734 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1735 * gtkutil.h: Change prototypes to match the above.
1737 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1738 are duplicate now that they've been promoted to lisp.h.
1739 (x_allocate_bitmap_record, x_alloc_image_color)
1740 (make_image_cache, cache_image, xpm_load):
1741 Don't update size until alloc is done.
1742 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1744 Check for size calculation overflow.
1745 (ct_colors_allocated_max): New constant.
1746 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1749 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1750 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1751 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1752 Use ptrdiff_t, not int, to count maps.
1753 (read_char_minibuf_menu_prompt): Check for overflow in size
1754 calculations. Don't update size until allocation succeeds.
1755 Redo calculations to avoid overflow.
1756 * keyboard.h: Change prototypes to match the above.
1758 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1760 (current_minor_maps): Check for size calculation overflow.
1761 * keymap.h: Change prototypes to match the above.
1763 * lread.c (read1, init_obarray): Don't update size until alloc done.
1765 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1766 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1768 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1769 Now ptrdiff_t, not int.
1770 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1771 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1773 * process.c (Fnetwork_interface_list): Check for overflow
1774 in size calculation.
1776 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1778 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1779 overflow. Don't bother calling xmalloc when xrealloc will do.
1781 * search.c (Freplace_match): Check for size calculation overflow.
1782 (Fset_match_data): Don't assume list lengths fit in 'int'.
1784 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1785 for command line length. Do not attempt to address one before the
1786 beginning of an array, as that's not portable.
1788 * term.c (max_frame_lines): Remove; unused.
1789 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1791 (encode_terminal_code, calculate_costs): Check for size
1792 calculation overflow.
1793 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1794 table lengths and related sizes. Don't update size until alloc
1795 done. Redo calculations to avoid overflow.
1796 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1798 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1799 subtracting pointers.
1800 (gobble_line): Check for overflow more carefully. Don't update size
1803 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1804 Don't update size until alloc done.
1805 Redo size calculations to avoid overflow.
1806 Check for size calculation overflow.
1807 (main) [DEBUG]: Fix typo in invoking tparam1.
1809 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1810 Use ptrdiff_t, not int, for sizes.
1811 (store_mode_line_noprop_char): Don't update size until alloc done.
1813 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1814 Use ptrdiff_t, not int, for sizes.
1815 (Finternal_make_lisp_face, cache_face):
1816 Check for size calculation overflow.
1817 (cache_face): Treat size calculation overflows as if they were
1818 memory exhaustion (the usual treatment), rather than aborting.
1820 * xfns.c (x_encode_text, x_set_name_internal)
1821 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1822 sizes, since they can exceed INT_MAX in size. Check for size
1823 calculation overflow.
1825 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1826 (xg_select): Check for size calculation overflow.
1827 Don't update size until alloc done.
1829 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1830 as sprintf is limited to int lengths.
1832 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1833 (X_LONG_MIN): New macros.
1834 Use them to make the following changes clearer.
1835 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1836 This change doesn't affect the value now, but it may help remind
1837 future maintainers not to raise the value too much later.
1838 (SELECTION_QUANTUM): Remove, replacing with ...
1839 (selection_quantum): ... new function, which avoids overflow.
1841 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1842 assumption that selection length fits in 'int'.
1843 (x_reply_selection_request, x_handle_selection_request)
1844 (x_get_window_property, receive_incremental_selection)
1845 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1846 (lisp_data_to_selection_data, clean_local_selection_data):
1847 Use ptrdiff_t, not int, to record length of selection.
1848 (x_reply_selection_request, x_get_window_property)
1849 (receive_incremental_selection, x_property_data_to_lisp):
1850 Redo calculations to avoid overflow.
1851 (x_reply_selection_request): When sending hint, ceiling it at
1852 X_LONG_MAX rather than relying on wraparound overflow to send
1854 (x_get_window_property, receive_incremental_selection)
1855 (lisp_data_to_selection_data, x_property_data_to_lisp):
1856 Check for size-calculation overflow.
1857 (x_get_window_property, receive_incremental_selection)
1858 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1859 Don't store size until memory allocation succeeds.
1860 (x_get_window_property): Plug memory leak on memory exhaustion.
1861 Don't double-block input; malloc is safe here. Don't assume 2**34
1862 - 4 fits in unsigned long. Add an xassert to check
1863 XGetWindowProperty overflow. Be more careful about overflow
1864 calculations, and distinguish size from memory overflow better.
1865 (receive_incremental_selection): When tracing, don't assume
1866 unsigned int is less than INT_MAX.
1867 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1868 harmful) conversions of unsigned short to int.
1869 (lisp_data_to_selection_data): Don't assume that integers
1870 in the range -65535 through -1 fit in an X unsigned short.
1871 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1872 result parameters unless successful. Rely on cons_to_unsigned
1873 to report problems with elements; the old code wasn't right anyway.
1874 (x_check_property_data): Check for int overflow; we cannot use
1875 a wider type due to X limits.
1876 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1878 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1880 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1881 (x_term_init): Check for size calculation overflow.
1882 (x_color_cells): Don't store size until memory allocation succeeds.
1883 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1884 Don't assume alloca size is less than MAX_ALLOCA.
1885 (x_term_init): Don't assume length fits in int (sprintf is limited
1888 Use ptrdiff_t for composition IDs.
1889 * character.c (lisp_string_width):
1890 * composite.c (composition_table_size, n_compositions)
1891 (get_composition_id, composition_gstring_from_id):
1892 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1893 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1894 * window.c (Frecenter):
1895 Use ptrdiff_t, not int, for composition IDs.
1896 * composite.c (get_composition_id): Check for integer overflow.
1897 * composite.h: Adjust prototypes to match the above changes.
1899 Use ptrdiff_t for hash table indexes.
1900 * category.c (hash_get_category_set):
1901 * ccl.c (ccl_driver):
1902 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1903 * coding.c (coding_system_charset_list, detect_coding_system):
1904 * coding.h (struct coding_system.id):
1905 * composite.c (get_composition_id, gstring_lookup_cache):
1906 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1907 * image.c (xpm_get_color_table_h):
1908 * lisp.h (hash_lookup, hash_put):
1909 * minibuf.c (Ftest_completion):
1910 Use ptrdiff_t for hash table indexes, not int (which is too
1911 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1912 32-bit --with-wide-int hosts).
1914 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1915 Add a FIXME comment about memory leaks.
1916 (syms_of_charset): Don't assume xmalloc returns.
1918 Don't assume that stated character widths fit in int.
1919 * character.c (Fchar_width, c_string_width, lisp_string_width):
1920 * character.h (CHAR_WIDTH):
1921 * indent.c (MULTIBYTE_BYTES_WIDTH):
1922 Use sanitize_char_width to avoid undefined and/or bad behavior
1923 with outlandish widths.
1924 * character.h (sanitize_tab_width): Rename from sanitize_width,
1925 now that we have two such functions. All uses changed.
1926 (sanitize_char_width): New inline function.
1928 Don't assume that tab-width fits in int.
1929 * character.h (sanitize_width): New inline function.
1930 (SANE_TAB_WIDTH): New macro.
1931 (ASCII_CHAR_WIDTH): Use it.
1932 * indent.c (sane_tab_width): Remove. All uses replaced by
1933 SANE_TAB_WIDTH (current_buffer).
1934 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1936 * fileio.c: Integer overflow issues with file modes.
1937 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1939 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1940 Remove unreachable code.
1941 (read_hex, load_charset_map_from_file): Check for integer overflow.
1943 * xterm.c: don't go over XClientMessageEvent limit
1944 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1945 (x_send_scroll_bar_event): Likewise. Check that the size does not
1946 exceed limits imposed by XClientMessageEvent, as well as the usual
1947 ptrdiff_t and size_t limits.
1949 * keyboard.c: Overflow, signedness and related fixes.
1950 (make_lispy_movement): Use same integer type in forward decl
1951 that is used in the definition.
1952 (read_key_sequence, keyremap_step):
1953 Change bufsize argument back to int, undoing my 2011-03-30 change.
1954 We prefer signed types, and int is wide enough here.
1955 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1956 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1957 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1958 length, not size_t. Use ptrdiff_t for index, not int.
1959 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1960 possibility of integer overflow.
1962 Overflow, signedness and related fixes for images.
1964 * dispextern.h (struct it.stack[0].u.image.image_id)
1965 (struct_it.image_id, struct image.id, struct image_cache.size)
1966 (struct image_cache.used, struct image_cache.ref_count):
1967 * gtkutil.c (update_frame_tool_bar):
1968 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1969 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1970 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1971 * nsmenu.m (update_frame_tool_bar):
1972 * xdisp.c (calc_pixel_width_or_height):
1973 * xfns.c (image_cache_refcount):
1974 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1975 on typical 64-bit hosts.
1977 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1978 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1979 Omit unnecessary casts to int.
1980 (parse_image_spec): Check that integers fall into 'int' range
1981 when the callers expect that.
1982 (image_ascent): Redo ascent calculation to avoid int overflow.
1983 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1984 (lookup_image): Remove unnecessary tests.
1985 (xbm_image_p): Locals are now of int, not EMACS_INT,
1986 since parse_image_check makes sure they fit into int.
1987 (png_load, gif_load, svg_load_image):
1988 Prefer int to unsigned where either will do.
1989 (tiff_handler): New function, combining the cores of the
1990 old tiff_error_handler and tiff_warning_handler.
1991 This function is rewritten to use vsnprintf and thereby avoid
1992 stack buffer overflows. It uses only the features of vsnprintf
1993 that are common to both POSIX and native Microsoft.
1994 (tiff_error_handler, tiff_warning_handler): Use it.
1995 (tiff_load, gif_load, imagemagick_load_image):
1996 Don't assume :index value fits in 'int'.
1997 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1998 (imagemagick_load_image): Check that crop parameters fit into
1999 the integer types that MagickCropImage accepts. Don't assume
2000 Vimagemagick_render_type has a nonnegative value. Don't assume
2001 size_t fits in 'long'.
2002 (gs_load): Use printmax_t to print the widest integers possible.
2003 Check for integer overflow when computing image height and width.
2005 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2007 * xdisp.c (redisplay_window): Don't force window start if point
2008 will be invisible in the resulting window. (Bug#9324)
2010 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2012 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2013 the display spec is of the form `(space ...)'.
2014 (handle_display_spec): Return the value returned by
2015 handle_single_display_spec, not just 1 or zero.
2016 (handle_single_display_spec): If the display spec is of the form
2017 `(space ...)', and specifies display in the text area, return 2
2019 (try_cursor_movement): Check for the need to scroll more
2020 accurately, and prefer exact match for point under bidi.
2021 Don't advance `row' beyond the last row of the window.
2023 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2024 into disp_prop; all users changed.
2026 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2027 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2028 for the text covered by the display property.
2030 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2032 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2033 Change return value to nil.
2034 (Frecord_buffer): Delete unused function.
2036 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2038 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2039 buffers, return left-to-right.
2040 (set_cursor_from_row): Consider candidate row a win if its glyph
2041 represents a newline and point is on that newline. Fixes cursor
2042 positioning on the newline at EOL of R2L text within L2R
2043 paragraph, and vice versa.
2044 (try_cursor_movement): Check continued rows, in addition to
2045 continuation rows. Fixes unwarranted scroll when point enters a
2046 continued line of R2L text within an L2R paragraph, or vice versa.
2047 (cursor_row_p): Consider the case of point being equal to
2048 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2049 from the end of a short line to the beginning of a continued line
2050 of R2L text within L2R paragraph.
2051 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2052 composed characters.
2054 * bidi.c (bidi_check_type): Use xassert.
2055 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2058 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2060 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2063 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2065 * nsfont.m (ns_otf_to_script): Fix typo.
2067 2011-08-22 Kenichi Handa <handa@m17n.org>
2069 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2070 extra slot even if the purpose is char-code-property-table.
2072 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2074 * xdisp.c (redisplay_window): When computing centering_position,
2075 account for the height of the header line. (Bug#8874)
2077 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2078 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2079 candidate is selected by the mouse, and that candidate has a
2080 composed character under the mouse.
2082 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2083 coordinates reported by pos-visible-in-window-p for a composed
2084 character in column zero.
2086 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2088 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2090 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2092 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2093 consider it a hit if to_charpos is anywhere in the range of the
2094 composed buffer positions.
2096 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2098 * image.c (gif_load): Don't assume that each subimage has the same
2099 dimensions as the base image. Handle disposal method that is
2100 "undefined" by the gif spec (Bug#9335).
2102 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2104 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2105 (Fcondition_case): Document `debug' symbol in error handler.
2107 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2109 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2110 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2111 from an Org mode buffer to a Speedbar frame.
2113 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2114 a composition, take its buffer position from IT->cmp_it.charpos.
2115 Fixes cursor positioning at the beginning of a line that begins
2116 with a composed character.
2118 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2120 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2121 character bidirectional type, use STRONG_L instead. Fixes crashes
2122 in a buffer produced by `describe-categories'.
2124 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2125 members before the level stack, so they would be saved and
2126 restored when copying iterator state. Fixes incorrect reordering
2127 around TABs covered by display properties.
2129 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2131 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2133 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2135 * eval.c (internal_condition_case, internal_condition_case_1)
2136 (internal_condition_case_2, internal_condition_case_n):
2137 Remove unnecessary aborts (Bug#9081).
2139 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2141 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2142 has no `load' handler, try opening the file locally. (Bug#9311)
2144 2011-08-16 Ken Brown <kbrown@cornell.edu>
2146 * gmalloc.c: Expand comment.
2148 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2150 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2151 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2153 2011-08-16 Ken Brown <kbrown@cornell.edu>
2155 Fix memory allocation problems in Cygwin build (Bug#9273).
2157 * unexcw.c ( __malloc_initialized): Declare external variable.
2158 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2160 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2162 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2164 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2166 [CYGWIN] (special_realloc): New function.
2167 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2168 requests to realloc storage in the static heap.
2170 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2172 * bidi.c (bidi_initialize): Remove unused local.
2174 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2177 * biditype.h: Remove file.
2178 * makefile.w32-in ($(BLD)/bidi.$(O)):
2179 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2181 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2183 * chartab.c: Improve commentary for the uniprop_table API.
2185 * bidi.c (bidi_paragraph_init): Support zero value of
2186 bidi_ignore_explicit_marks_for_paragraph_level.
2187 (bidi_initialize): Use uniprop_table instead of including
2188 biditype.h and bidimirror.h.
2190 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2191 coordinates of the iterator when restoring from ppos_it.
2194 2011-08-14 Kenichi Handa <handa@m17n.org>
2196 * process.c (create_process): Call setup_process_coding_systems
2197 after the pid of the process is set to -1 (Bug#8162).
2199 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2201 * xdisp.c (move_it_in_display_line_to): Don't invoke
2202 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2203 ppos_it. Fixes vertical cursor motion when line beginning is
2204 covered by an image. (Bug#9296)
2206 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2208 * nsterm.h (ns_run_ascript): Declare.
2209 (NSAPP_DATA2_RUNASSCRIPT): Define.
2211 * nsfns.m (as_script, as_result, as_status): New static variables.
2212 (ns_run_ascript): New function.
2213 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2214 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2215 the event loop. Get status from as_status (Bug#7276).
2217 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2218 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2219 the event loop (Bug#7276).
2221 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2223 * gnutls.c (QCgnutls_bootprop_priority)
2224 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2225 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2226 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2227 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2228 (QCgnutls_bootprop_verify_hostname_error)
2229 (QCgnutls_bootprop_callbacks_verify): Rename from
2230 Qgnutls_bootprop_..., all uses changed.
2232 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2235 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2237 * xfaces.c (Qframe_set_background_mode): Now static.
2238 * dispextern.h (Qframe_set_background_mode): Remove decl.
2240 * process.c (Fnetwork_interface_info): Declare local only if needed.
2242 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2244 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2245 (Fnetwork_interface_list): Allocate in increments of bytes instead
2246 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2247 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2249 (struct ifflag_def): notrailers is smart on OSX.
2250 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2251 Get hardware address with getifaddrs if available.
2253 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2255 * xdisp.c (iterate_out_of_display_property): xassert that
2256 IT->position is set to within IT->object's boundaries. Break from
2257 the loop as soon as EOB is reached; avoids infloops in redisplay
2258 when IT->position is set up wrongly due to some bug.
2259 Set IT->current to match the bidi iterator unconditionally.
2260 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2261 entry. Force push_it to save on the stack the current
2262 buffer/string position, to be restored by pop_it. Fix flags in
2263 the iterator structure wrt the object coming from a display
2264 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2265 properties. (Bug#9284)
2267 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2269 * fontset.c (fontset_get_font_group): Add proper type checks.
2272 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2274 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2275 and LC_VERSION_MIN_MACOSX.
2276 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2277 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2279 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2281 * xdisp.c (forward_to_next_line_start): Allow to use the
2282 no-display-properties-and-no-overlays under bidi display.
2283 Set disp_pos in the bidi iterator to avoid searches for display
2284 properties and overlays.
2286 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2288 * editfns.c (Fset_time_zone_rule): Document relationship with the
2291 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2292 the font entity extracted from the cache (Bug#8109).
2294 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2296 * composite.c (autocmp_chars): Don't reset point. That is done by
2297 restore_point_unwind (Bug#5984).
2299 2011-08-07 Juri Linkov <juri@jurta.org>
2301 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2302 to show the arg `TIME' instead of `TIMEVAL'.
2304 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2306 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2307 display property strides EOL and includes a newline, as in
2308 longlines-mode. (Bug#9254)
2309 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2310 word-wrap under bidirectional display. (Bug#9224)
2312 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2313 is non-zero, even if the data buffer is NULL. Fixes a crash in
2314 vertical-motion with longlines-mode. (Bug#9254)
2316 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2318 * bidi.c <bidi_cache_total_alloc>: Now static.
2319 (bidi_initialize): Initialize bidi_cache_total_alloc.
2321 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2324 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2325 amount allocated this far in `bidi_cache_total_alloc'.
2326 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2327 non-zero, only free the data buffer without restoring the cache
2328 contents. All callers changed.
2330 * dispextern.h (bidi_unshelve_cache): Update prototype.
2332 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2333 (move_it_in_display_line, move_it_to)
2334 (move_it_vertically_backward, move_it_by_lines): Replace the call
2335 to xfree to an equivalent call to bidi_unshelve_cache.
2336 (move_it_in_display_line_to): Fix logic of returning
2337 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2339 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2341 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2342 came from a string character with a `cursor' property. (Bug#9229)
2344 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2346 * Makefile.in (LIB_PTHREAD): New variable.
2347 (LIBES): Add LIB_PTHREAD (Bug#9216).
2349 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2350 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2352 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2354 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2356 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2358 * xterm.c (x_find_topmost_parent): New function.
2359 (x_set_frame_alpha): Find topmost parent window with
2360 x_find_topmost_parent and set the property there also (bug#9181).
2361 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2363 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2365 * callproc.c (Fcall_process): Avoid vfork clobbering
2366 the local vars buffer, coding_systems, current_dir.
2368 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2370 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2372 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2374 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2375 so that it is not optimized away.
2377 * xdisp.c (compute_display_string_pos): Remove unused local.
2379 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2381 Fix slow cursor motion and scrolling in large buffers with
2382 selective display, like Org Mode buffers. (Bug#9218)
2384 * dispextern.h (struct bidi_it): New member disp_prop_p.
2386 * xdisp.c: Remove one-slot cache of display string positions.
2387 (compute_display_string_pos): Accept an additional argument
2388 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2389 for a display string or property. If found, set DISP_PROP_P
2392 * bidi.c (bidi_fetch_char): Accept an additional argument
2393 DISP_PROP_P, and pass it to compute_display_string_pos.
2394 Only handle text covered by a display string if DISP_PROP_P is returned
2395 non-zero. All callers of bidi_fetch_char changed.
2397 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2399 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2401 2010-12-03 Don March <don@ohspite.net>
2403 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2404 last character M-[char] is translated to ESC [char] (bug#7541).
2406 2011-08-02 Kenichi Handa <handa@m17n.org>
2408 * lisp.h (uniprop_table): Extern it.
2410 * chartab.c (uniprop_table): Make it non-static.
2412 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2414 * xdisp.c (forward_to_next_line_start): Accept additional argument
2415 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2417 (reseat_at_next_visible_line_start): Use the bidi iterator state
2418 returned by forward_to_next_line_start to restore the state of
2419 it->bidi_it after backing up to previous newline. (Bug#9212)
2421 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2423 * regex.c (re_comp): Protoize.
2424 (re_exec): Fix return type.
2425 (regexec): Fix type of `ret'. (Bug#9203)
2427 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2429 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2430 This is needed if max-image-size is a floating-point number.
2432 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2434 * print.c (print_object): Print empty symbol as ##.
2436 * lread.c (read1): Read ## as empty symbol.
2438 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2440 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2441 setting frame foreground color (Bug#9175).
2442 (x_set_background_color): Likewise.
2444 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2445 contents (Bug#9176).
2446 (EmacsTooltip -init): Remove bezels and add shadows to
2449 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2450 or scroll bar (Bug#8470).
2452 * nsfont.m (nsfont_open): Remove assignment to voffset and
2453 unnecessary vars hshink, expand, hd, full_height, min_height.
2454 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2456 * nsterm.h (nsfont_info): Remove voffset field.
2458 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2460 Implement strike-through and overline on NextStep (Bug#8863).
2462 * nsfont.m (nsfont_open): Use underline position provided by font,
2463 instead of hard-coded value of 2.
2464 (nsfont_draw): Call ns_draw_text_decoration instead.
2466 * nsterm.h: Add declaration for ns_draw_text_decoration.
2468 * nsterm.m (ns_draw_text_decoration): New function for drawing
2469 underline, overline, and strike-through.
2470 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2471 ns_draw_text_decoration. Change treatment of cursor drawing to
2472 accommodate underlining, etc.
2474 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2476 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2479 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2481 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2482 Without this fix, if a signal arrives just after memory fills up,
2483 'malloc' might be invoked reentrantly.
2485 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2486 In other words, assume that every image size is allowed, on non-X
2487 hosts. This assumption is probably wrong, but it lets Emacs compile.
2489 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2491 * regex.c (re_iswctype): Convert return values to boolean.
2493 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2495 * xdisp.c (compute_display_string_pos): Don't use cached display
2496 string position if the buffer had its restriction changed.
2499 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2501 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2503 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2505 Integer signedness and overflow and related fixes. (Bug#9079)
2507 * bidi.c: Integer size and overflow fixes.
2508 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2509 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2510 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2511 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2512 (bidi_find_other_level_edge):
2513 Use ptrdiff_t instead of EMACS_INT where either will do.
2514 This works better on 32-bit hosts configured --with-wide-int.
2515 (bidi_cache_ensure_space): Check for size-calculation overflow.
2516 Use % rather than repeated addition, for better worst-case speed.
2517 Don't set bidi_cache_size until after xrealloc returns, because it
2519 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2520 (bidi_cache_ensure_space): Also check that the bidi cache size
2521 does not exceed that of the largest Lisp string or buffer. See Eli
2522 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2524 * alloc.c (__malloc_size_t): Remove.
2525 All uses replaced by size_t. See Andreas Schwab's note
2526 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2528 * image.c: Improve checking for integer overflow.
2529 (check_image_size): Assume that f is nonnull, since
2530 it is always nonnull in practice. This is one less thing to
2531 worry about when checking for integer overflow later.
2532 (x_check_image_size): New function, which checks for integer
2533 overflow issues inside X.
2534 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2535 This removes the need for a memory_full check.
2536 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2537 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2538 (xbm_read_bitmap_data): Change locals back to 'int', since
2539 their values must fit in 'int'.
2540 (xpm_load_image, png_load, tiff_load):
2541 Invoke x_create_x_image_and_pixmap earlier,
2542 to avoid much needless work if the image is too large.
2543 (tiff_load): Treat overly large images as if
2544 x_create_x_image_and_pixmap failed, not as malloc failures.
2545 (gs_load): Use x_check_image_size.
2547 * gtkutil.c: Omit integer casts.
2548 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2549 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2551 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2553 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2554 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2555 would wrongly return t on a 64-bit host.
2557 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2558 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2559 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2560 and therefore cause GCC to emit a bogus diagnostic in some cases.
2562 * image.c: Integer signedness and overflow and related fixes.
2563 This is not an exhaustive set of fixes, but it's time to
2564 record what I've got.
2565 (lookup_pixel_color, check_image_size): Remove redundant decls.
2566 (check_image_size): Don't assume that arbitrary EMACS_INT values
2567 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2568 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2569 (tiff_load, imagemagick_load_image):
2570 Check for overflow in size calculations.
2571 (x_create_x_image_and_pixmap): Remove unnecessary test for
2572 xmalloc returning NULL; that can't happen.
2573 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2574 (xpm_color_bucket): Use better integer hashing function.
2575 (xpm_cache_color): Don't possibly over-allocate memory.
2576 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2577 (gif_memory_source):
2578 Use ptrdiff_t, not int or size_t, to record sizes.
2579 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2580 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2581 either works, as we prefer signed integers.
2582 (tiff_read_from_memory, tiff_write_from_memory):
2583 Return tsize_t, not size_t, since that's what the TIFF API wants.
2584 (tiff_read_from_memory): Don't fail simply because the read would
2585 go past EOF; instead, return a short read.
2586 (tiff_load): Omit no-longer-needed casts.
2587 (Fimagemagick_types): Don't assume size fits into 'int'.
2589 Improve hashing quality when configured --with-wide-int.
2590 * fns.c (hash_string): New function, taken from sxhash_string.
2591 Do not discard information about ASCII character case; this
2592 discarding is no longer needed.
2593 (sxhash-string): Use it. Change sig to match it. Caller changed.
2594 * lisp.h: Declare it.
2595 * lread.c (hash_string): Remove, since we now use fns.c's version.
2596 The fns.c version returns a wider integer if --with-wide-int is
2597 specified, so this should help the quality of the hashing a bit.
2599 * emacs.c: Integer overflow minor fix.
2600 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2601 Define only if GNU_LINUX.
2602 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2604 * dispnew.c: Integer signedness and overflow fixes.
2605 Remove unnecessary forward decls, that were a maintenance hassle.
2606 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2608 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2609 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2610 (prepare_desired_row, line_draw_cost):
2611 Use int, not unsigned, where either works.
2612 (save_current_matrix, restore_current_matrix):
2613 Use ptrdiff_t, not size_t, where either works.
2614 (init_display): Check for overflow more accurately, and without
2615 relying on undefined behavior.
2617 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2618 Remove, replacing with the new symbols in lisp.h. All uses changed.
2619 * fileio.c (make_temp_name):
2620 * filelock.c (lock_file_1, lock_file):
2621 * xdisp.c (message_dolog):
2622 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2623 Use pMd etc. instead.
2624 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2625 replacing the pWIDE etc. symbols removed from editfns.c.
2627 * keyboard.h (num_input_events): Now uintmax_t.
2628 This is (very slightly) less likely to mess up due to wraparound.
2631 * buffer.c: Integer signedness fixes.
2632 (alloc_buffer_text, enlarge_buffer_text):
2633 Use ptrdiff_t rather than size_t when either will do, as we prefer
2636 * alloc.c: Integer signedness and overflow fixes.
2637 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2638 (__malloc_size_t): Default to size_t, not to int.
2639 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2640 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2641 Prefer ptrdiff_t to size_t when either would do, as we prefer
2643 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2644 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2645 Now const. Initialize with values that are in range even if char
2647 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2648 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2649 These functions do the right thing with sizes > 2**32.
2650 (check_depth): Now ptrdiff_t, not int.
2651 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2652 Adjust to new way of storing sizes. Check for size overflow bugs
2654 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2655 slightly wrong anyway, as it missed one instance of
2656 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2657 (refill_memory_reserve): Omit needless cast to size_t.
2658 (mark_object_loop_halt): Mark as externally visible.
2660 * xselect.c: Integer signedness and overflow fixes.
2661 (Fx_register_dnd_atom, x_handle_dnd_message):
2662 Use ptrdiff_t, not size_t, since we prefer signed.
2663 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2664 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2665 x_dnd_atoms_size and x_dnd_atoms_length.
2667 * doprnt.c: Prefer signed to unsigned when either works.
2669 * doprnt.c (doprnt):
2671 * xdisp.c (vmessage):
2672 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2673 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2674 prefer signed arithmetic to avoid comparison confusion.
2675 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2676 but is a bit tricky.
2678 Assume freestanding C89 headers, string.h, stdlib.h.
2679 * data.c, doprnt.c, floatfns.c, print.c:
2680 Include float.h unconditionally.
2681 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2682 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2683 * regex.c: Likewise for stddef.h, string.h.
2684 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2685 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2686 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2687 (STDC_HEADERS): Remove obsolete defines.
2688 * sysdep.c: Include limits.h unconditionally.
2690 Assume support for memcmp, memcpy, memmove, memset.
2691 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2692 * regex.c (memcmp, memcpy):
2693 Remove; we assume C89 now.
2695 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2696 (__malloc_safe_bcopy): Remove; no longer needed.
2698 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2699 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2700 well either way, and we prefer signed to unsigned.
2702 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2704 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2705 closes the connection while we're reading (bug#9182).
2707 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2709 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2710 are specified (Bug#9168).
2712 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2714 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2715 Found by GCC static checking and --with-wide-int on a 32-bit host.
2717 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2719 * xdisp.c (compute_display_string_pos): Fix logic of caching
2720 previous display string position. Initialize cached_prev_pos to
2721 -1. Fixes slow-down at the beginning of a buffer.
2723 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2725 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2726 for attrs[LFACE_FONTSET_INDEX].
2728 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2730 * xml.c (parse_region): Remove unused local
2731 that was recently introduced.
2733 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2735 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2736 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2738 * xdisp.c (move_it_in_display_line_to): Record the best matching
2739 position for TO_CHARPOS while scanning the line, and restore it on
2740 exit if none of the characters scanned was an exact match.
2741 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2742 when exact match is impossible due to invisible text, and the
2743 lines are truncated.
2745 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2747 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2750 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2752 Fix a significant slow-down of cursor motion with C-n, C-p,
2753 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2754 auto-repeat under bidi redisplay in fontified buffers.
2755 * xdisp.c (compute_stop_pos_backwards): New function.
2756 (next_element_from_buffer): Call compute_stop_pos_backwards to
2757 find a suitable prev_stop when we find ourselves before
2759 (reseat): Don't look for prev_stop, as that could mean a very long
2761 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2762 <cached_disp_overlay_modiff>: Cache for last found display string
2764 (compute_display_string_pos): Return the cached position if asked
2765 about the same buffer in the same area of character positions, and
2766 the buffer wasn't changed since the time the display string
2767 position was cached.
2769 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2771 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2772 is an integer, which is important for empty lines. (Bug#9149)
2774 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2776 * frame.c (Fmodify_frame_parameters): In tty case, update the
2777 default face if necessary (Bug#4238).
2779 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2781 * editfns.c (Fstring_to_char): No need to explain what a character
2782 is in the docstring (Bug#6576).
2784 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2786 * xml.c (parse_region): Make sure we always return a tree.
2788 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2790 * xml.c (parse_region): If a document contains only comments,
2793 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2795 * xml.c (make_dom): Return comments, too.
2797 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2800 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2801 and the surrounding thread.
2802 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2803 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2804 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2806 * s/openbsd.h (BROKEN_SIGIO): Define.
2807 * unexelf.c (unexec) [__OpenBSD__]:
2808 Don't update the .mdebug section of the Alpha COFF symbol table.
2810 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2812 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2815 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2817 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2818 This fixes some race conditions on the permissions of any newly
2821 * alloc.c (valid_pointer_p): Use pipe, not open.
2822 This fixes some permissions issues when debugging.
2824 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2825 If fchown fails to set both uid and gid, try to set just gid,
2826 as that is sometimes allowed. Adjust the file's mode to eliminate
2827 setuid or setgid bits that are inappropriate if fchown fails.
2829 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2831 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2832 to compare Lisp_Objects.
2833 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2834 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2835 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2837 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2839 * lread.c (read_integer): Unread even EOF character.
2840 (read1): Likewise. Properly record start position of symbol.
2842 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2843 symbol character follows.
2845 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2847 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2848 This works around a problem with the previous change to Fcopy_file.
2849 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2850 and without this change, GCC might complain about discarding
2851 fchown's return value.
2853 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2855 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2857 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2859 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2861 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2863 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2864 it's used from the C level.
2866 * process.c: Use the same condition for POLL_FOR_INPUT in both
2867 keyboard.c and process.c (bug#1858).
2869 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2871 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2872 (Fgnutls_boot): Use it.
2874 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2876 * doc.c (Fsubstitute_command_keys): Revert last change.
2878 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2880 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2881 quotes the next character, and doesn't affect other longer
2882 sequences (bug#8935).
2884 * lread.c (syms_of_lread): Clarify that is isn't only
2885 `eval-buffer' and `eval-defun' that's affected by
2886 `lexical-binding' (bug#8460).
2888 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2890 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2891 bidi redisplay when a line includes both an image and is truncated.
2893 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2895 Fix minor problems found by static checking.
2896 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2897 (elsz): Now a signed constant, not a size_t var. We prefer signed
2898 types to unsigned, to avoid integer comparison confusion. Without
2899 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2900 "cannot optimize loop, the loop counter may overflow", a symptom
2902 * indent.c (Fvertical_motion): Mark locals as initialized.
2903 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2905 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2907 * search.c (Fre_search_backward): Mention `case-fold-search' in
2908 all the re_search_* functions (bug#8138).
2910 * keyboard.c (Fopen_dribble_file): Document when the file is
2913 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2915 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2918 Support bidi reordering of display and overlay strings.
2919 * xdisp.c (compute_display_string_pos)
2920 (compute_display_string_end): Accept additional argument STRING.
2921 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2922 (reseat_to_string): Initialize bidi_it->string.s and
2923 bidi_it->string.schars.
2924 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2925 NULL (avoids a crash in bidi_paragraph_init).
2926 Initialize itb.string.lstring.
2927 (init_iterator): Call bidi_init_it only of a valid
2928 buffer position was specified. Initialize paragraph_embedding to
2930 (reseat_to_string): Initialize the bidi iterator.
2931 (display_string): If we need to ignore text properties of
2932 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2933 original value of -1 will not work with bidi.)
2934 (compute_display_string_pos): First arg is now struct
2935 `text_pos *'; all callers changed. Support display properties on
2937 (compute_display_string_end): Support display properties on Lisp
2939 (init_iterator, reseat_1, reseat_to_string): Initialize the
2940 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2941 when iterating on a string not from display properties).
2942 (compute_display_string_pos, compute_display_string_end):
2943 Fix calculation of the object to scan. Fixes an error when using
2945 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2946 base_level_stop; instead, set base_level_stop to BEGV.
2947 Fixes crashes in vertical-motion.
2948 (next_element_from_buffer): Improve commentary for when
2949 the iterator is before prev_stop.
2950 (init_iterator): Initialize bidi_p from the default value of
2951 bidi-display-reordering, not from buffer-local value. Use the
2952 buffer-local value only if initializing for buffer iteration.
2953 (handle_invisible_prop): Support invisible properties on strings
2954 that are being bidi-reordered.
2955 (set_iterator_to_next): Support bidi reordering of C strings and
2957 (next_element_from_string): Support bidi reordering of Lisp
2959 (handle_stop_backwards): Support Lisp strings as well.
2960 (display_string): Support display of R2L glyph rows.
2961 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2962 (init_iterator): Don't initialize it->bidi_p for strings
2964 (reseat_to_string): Initialize it->bidi_p for strings here.
2965 (next_element_from_string, next_element_from_c_string)
2966 (next_element_from_buffer): Add xassert's for correspondence
2967 between IT's object being iterated and it->bidi_it.string
2969 (face_before_or_after_it_pos): Support bidi iteration.
2970 (next_element_from_c_string): Handle the case of the first string
2971 character that is not the first one in the visual order.
2972 (get_visually_first_element): New function, refactored from common
2973 parts of next_element_from_buffer, next_element_from_string, and
2974 next_element_from_c_string.
2975 (tool_bar_lines_needed, redisplay_tool_bar)
2976 (display_menu_bar): Force left-to-right direction. Add a FIXME
2977 comment for making that be controlled by a user option.
2978 (push_it, pop_it): Save and restore the state of the
2979 bidi iterator. Save and restore the bidi_p flag.
2980 (pop_it): Iterate out of display property for string iteration as
2982 (iterate_out_of_display_property): Support iteration over strings.
2983 (handle_single_display_spec): Set up it->bidi_it for iteration
2984 over a display string, and call bidi_init_it.
2985 (handle_single_display_spec, next_overlay_string)
2986 (get_overlay_strings_1, push_display_prop): Set up the bidi
2987 iterator for displaying display or overlay strings.
2988 (forward_to_next_line_start): Don't use the shortcut if
2990 (back_to_previous_visible_line_start): If handle_display_prop
2991 pushed the iterator stack, restore the internal state of the bidi
2992 iterator by calling bidi_pop_it same number of times.
2993 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2994 and we are bidi-iterating, don't decrement the iterator position;
2995 instead, set the first_elt flag in the bidi iterator, to produce
2997 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2998 (push_display_prop): xassert that we are iterating a buffer.
2999 (push_it, pop_it): Save and restore paragraph_embedding member.
3000 (handle_single_display_spec, next_overlay_string)
3001 (get_overlay_strings_1, reseat_1, reseat_to_string)
3002 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3003 correctly. Don't assume unibyte strings are not bidi-reordered.
3004 (compute_display_string_pos)
3005 (compute_display_string_end): Fix handling the case of C string.
3006 (push_it, pop_it): Save and restore from_disp_prop_p.
3007 (handle_single_display_spec, push_display_prop): Set the
3008 from_disp_prop_p flag.
3009 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3010 (pop_it): Call iterate_out_of_display_property only if we are
3011 popping after iteration over a string that came from a display
3012 property. Fix a typo in popping stretch info. Add an assertion
3013 for verifying that the iterator position is in sync with the bidi
3015 (handle_single_display_spec, get_overlay_strings_1)
3016 (push_display_prop): Fix initialization of paragraph direction for
3017 string when that of the parent object is not yet determined.
3018 (reseat_1): Call bidi_init_it to resync the bidi
3019 iterator with IT's position. (Bug#7616)
3020 (find_row_edges): If ROW->start.pos gives position
3021 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3022 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3023 Reset the from_disp_prop_p flag.
3024 (SAVE_IT, RESTORE_IT): New macros.
3025 (pos_visible_p, face_before_or_after_it_pos)
3026 (back_to_previous_visible_line_start)
3027 (move_it_in_display_line_to, move_it_in_display_line)
3028 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3029 (try_scrolling, redisplay_window, display_line): Use them when
3030 saving a temporary copy of the iterator and restoring it back.
3031 (back_to_previous_visible_line_start, reseat_1)
3032 (init_iterator): Empty the bidi cache "stack".
3033 (move_it_in_display_line_to): If iterator ended up at
3034 EOL, but we never saw any buffer positions smaller than
3035 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3036 motion in bidi-reordered lines.
3037 (move_it_in_display_line_to): Record prev_method and prev_pos
3038 immediately before the call to set_iterator_to_next. Fixes cursor
3039 motion in bidi-reordered lines with stretch glyphs and strings
3040 displayed in margins. (Bug#8133) (Bug#8867)
3041 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3043 (pos_visible_p): Support positions in bidi-reordered lines.
3044 Save and restore bidi cache.
3046 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3047 (bidi_paragraph_info): Delete unused struct.
3048 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3049 (bidi_cache_start): New variable.
3050 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3052 (bidi_cache_fetch_state, bidi_cache_search)
3053 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3054 (bidi_cache_find, bidi_peek_at_next_level)
3055 (bidi_level_of_next_char, bidi_find_other_level_edge)
3056 (bidi_move_to_visually_next): Compare cache index with
3057 bidi_cache_start rather than with zero.
3058 (bidi_fetch_char): Accept new argument STRING; all callers
3059 changed. Support iteration over a string. Support strings with
3060 display properties. Support unibyte strings. Fix the type of
3061 `len' according to what STRING_CHAR_AND_LENGTH expects.
3062 (bidi_paragraph_init, bidi_resolve_explicit_1)
3063 (bidi_resolve_explicit, bidi_resolve_weak)
3064 (bidi_level_of_next_char, bidi_move_to_visually_next):
3065 Support iteration over a string.
3066 (bidi_set_sor_type, bidi_resolve_explicit_1)
3067 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3068 can now be zero (for strings); special values 0 and -1 were
3069 changed to -1 and -2, respectively.
3070 (bidi_char_at_pos): New function.
3071 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3072 Call it instead of FETCH_MULTIBYTE_CHAR.
3073 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3074 initialized to valid values.
3075 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3077 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3078 the test for valid cached positions. Fix the logic for looking up
3079 the sentinel state in the cache. GCPRO the Lisp string we are
3081 (bidi_push_it, bidi_pop_it): New functions.
3082 (bidi_initialize): Initialize the bidi cache start stack pointer.
3083 (bidi_cache_ensure_space): New function, refactored from part of
3084 bidi_cache_iterator_state. Don't assume the required size is just
3085 one BIDI_CACHE_CHUNK away.
3086 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3087 (bidi_count_bytes, bidi_char_at_pos): New functions.
3088 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3089 always valid if bidi_cache_idx is valid.
3090 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3091 is valid if it's going to be used.
3092 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3093 (bidi_cache_fetch_state, bidi_cache_search)
3094 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3095 (bidi_cache_iterator_state, bidi_cache_find)
3096 (bidi_find_other_level_edge, bidi_cache_start_stack):
3097 All variables related to cache indices are now EMACS_INT.
3099 * dispextern.h (struct bidi_string_data): New structure.
3100 (struct bidi_it): New member `string'. Make flag members be 1-bit
3101 fields, and put them last in the struct.
3102 (compute_display_string_pos, compute_display_string_end):
3104 (bidi_push_it, bidi_pop_it): Add prototypes.
3105 (struct iterator_stack_entry): New members bidi_p,
3106 paragraph_embedding, and from_disp_prop_p.
3107 (struct it): Member bidi_p is now a bit field 1 bit wide.
3108 (bidi_shelve_cache, bidi_unshelve_cache):
3111 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3112 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3113 and vector-like objects.
3115 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3116 cache around display iteration.
3118 * window.c (Fwindow_end, window_scroll_pixel_based)
3119 (displayed_window_lines, Frecenter): Save and restore the bidi
3120 cache around display iteration.
3122 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3124 * editfns.c (Fdelete_region): Clarify the use of the named
3125 parameters (bug#6788).
3127 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3129 * indent.c (Fvertical_motion): Set and restore w->pointm when
3130 saving and restoring the window's buffer (Bug#9006).
3132 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3134 * editfns.c (Fstring_to_char): Clarify just what is returned
3135 (bug#6576). Text by Eli Zaretskii.
3137 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3139 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3141 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3143 * buffer.c (mmap_find): Fix a typo.
3145 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3147 Fix execution of x selection hooks.
3148 * xselect.c (Qx_lost_selection_functions)
3149 (Qx_sent_selection_functions): New vars.
3150 (syms_of_xselect): DEFSYM them.
3151 (x_handle_selection_request): Pass Qx_sent_selection_functions
3152 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3153 (x_handle_selection_clear,x_clear_frame_selections):
3154 Pass Qx_lost_selection_functions rather than
3155 Vx_lost_selection_functions to Frun_hook_with_args.
3157 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3159 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3160 The old code sometimes used this field without initializing it.
3162 * alloc.c (gc_sweep): Don't read past end of array.
3163 In theory, the old code could also have corrupted Emacs internals,
3164 though it'd be very unlikely.
3166 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3168 * character.c (Fcharacterp): Don't advertise optional ignored
3169 argument. (Bug#4026)
3171 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3173 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3176 * window.c (Fset_window_start): Doc fix (bug#4199).
3177 (Fset_window_hscroll): Ditto.
3179 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3181 Fix minor new problems caught by GCC 4.6.1.
3182 * term.c (init_tty): Remove unused local.
3183 * xsettings.c (store_monospaced_changed): Define this function only
3184 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3187 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3189 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3191 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3193 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3194 are the mini-buffer and the echo area (bug#3320).
3196 * term.c (init_tty): Remove support for supdup, c10 and perq
3197 terminals, which are no longer supported (bug#1482).
3199 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3201 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3203 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3205 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3206 for non-popups (Bug#3642).
3208 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3210 * alloc.c (reset_malloc_hooks): Protoize.
3211 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3212 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3213 * cm.c (losecursor): Likewise.
3214 * data.c (fmod): Likewise.
3215 * dispnew.c (swap_glyphs_in_rows): Likewise.
3216 * emacs.c (memory_warning_signal): Likewise.
3217 * floatfns.c (float_error): Likewise.
3218 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3219 (otf_open, font_otf_capability, generate_otf_features)
3220 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3222 * image.c (pbm_read_file): Likewise.
3223 * indent.c (string_display_width): Likewise.
3224 * intervals.c (check_for_interval, search_for_interval)
3225 (inc_interval_count, count_intervals, root_interval)
3226 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3227 * lread.c (defalias): Likewise.
3228 * ralloc.c (r_alloc_check): Likewise.
3229 * regex.c (set_image_of_range_1, set_image_of_range)
3230 (regex_grow_registers): Likewise.
3231 * sysdep.c (strerror): Likewise.
3232 * termcap.c (valid_filename_p, tprint, main): Likewise.
3233 * tparam.c (main): Likewise.
3234 * unexhp9k800.c (run_time_remap, save_data_space)
3235 (update_file_ptrs, read_header, write_header, calculate_checksum)
3236 (copy_file, copy_rest, display_header): Likewise.
3237 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3239 * xdisp.c (check_it): Likewise.
3240 * xfaces.c (register_color, unregister_color, unregister_colors):
3242 * xfns.c (print_fontset_result): Likewise.
3243 * xrdb.c (member, fatal, main): Likewise.
3245 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3247 Fix minor problems found by static checking (Bug#9031).
3248 * chartab.c (char_table_set_range, map_sub_char_table):
3249 Remove unused locals.
3250 (uniprop_table): Now static.
3251 * composite.c (_work_char): Remove unused static var.
3253 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3255 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3257 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3259 * gtkutil.c (qttip_cb): Remove code without function.
3261 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3263 * w32.c (pthread_sigmask): New stub.
3265 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3267 Use pthread_sigmask, not sigprocmask (Bug#9010).
3268 sigprocmask is portable only for single-threaded applications, and
3269 Emacs can be multi-threaded when it uses GTK.
3270 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3272 * callproc.c (Fcall_process):
3273 * process.c (create_process):
3274 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3275 Use pthread_sigmask, not sigprocmask.
3277 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3279 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3280 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3283 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3285 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3286 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3287 (xg_hide_tooltip): Fix comment.
3289 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3290 in registerServicesMenuSendTypes.
3291 (validRequestorForSendType): Don't check ns_return_types.
3293 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3296 2011-07-08 Jason Rumney <jasonr@gnu.org>
3298 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3299 SH_SHOW for hidden windows (Bug#5482).
3301 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3302 frame struct members of non-existent frames (Bug#6284).
3304 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3306 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3307 variable firstTime not needed on OSX >= 10.6.
3308 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3309 >= 10.5. Use setKnobProportion, setDoubleValue.
3311 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3312 (MAC_OS_X_VERSION_10_5): Define if not defined.
3313 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3314 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3315 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3317 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3318 cString and lossyCString on OSX >= 10.4
3320 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3321 sizeToFit on OSX >= 10.2.
3323 * nsimage.m (allocInitFromFile): Don't use deprecated method
3324 bestRepresentationForDevice on OSX >= 10.6.
3326 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3329 * emacs.c: Declare unexec_init_emacs_zone.
3331 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3333 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3335 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3336 on svcsMenu (Bug#8842).
3338 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3340 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3342 * nsterm.m (QUTF8_STRING): Declare.
3343 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3344 (validRequestorForSendType): Return type is (id).
3345 Change indexOfObjectIdenticalTo to indexOfObject.
3346 Check if we have local selection before returning self (Bug#8842).
3347 (writeSelectionToPasteboard): Put local selection into paste board
3348 if we have a local selection (Bug#8842).
3349 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3351 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3352 (ns_get_local_selection): Declare.
3354 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3356 * keymap.c (describe_map_tree): Don't insert a double newline at
3357 the end of the buffer (bug#1169) and return whether we inserted
3360 * callint.c (Fcall_interactively): Change "reading args" to
3361 "providing args" to try to clarify what it does (bug#1010).
3363 2011-07-07 Kenichi Handa <handa@m17n.org>
3365 * composite.c (composition_compute_stop_pos): Ignore a static
3366 composition starting before CHARPOS (Bug#8915).
3368 * xdisp.c (handle_composition_prop): Likewise.
3370 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3372 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3375 2011-07-07 Kenichi Handa <handa@m17n.org>
3377 * character.h (unicode_category_t): New enum type.
3379 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3380 (Qchar_code_property_table): New variable.
3381 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3382 (UNIPROP_COMPRESSED_FORM_P): New macros.
3383 (char_table_ascii): Uncompress the compressed values.
3384 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3385 Uncompress the compressed values.
3386 (sub_char_table_ref_and_range): Likewise.
3387 (char_table_ref_and_range): Uncompress the compressed values.
3388 (sub_char_table_set): New arg is_uniprop. Callers changed.
3389 Uncompress the compressed values.
3390 (sub_char_table_set_range): Args changed. Callers changed.
3391 (char_table_set_range): Adjuted for the above change.
3392 (map_sub_char_table): Delete args default_val and parent. Add arg
3393 top. Give decoded values to a Lisp function.
3394 (map_char_table): Adjust for the above change. Give decoded
3395 values to a Lisp function. Gcpro more variables.
3396 (uniprop_table_uncompress)
3397 (uniprop_decode_value_run_length): New functions.
3398 (uniprop_decoder, uniprop_decoder_count): New variables.
3399 (uniprop_get_decoder, uniprop_encode_value_character)
3400 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3402 (uniprop_encoder, uniprop_encoder_count): New variables.
3403 (uniprop_get_encoder, uniprop_table)
3404 (Funicode_property_table_internal, Fget_unicode_property_internal)
3405 (Fput_unicode_property_internal): New functions.
3406 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3407 Sunicode_property_table_internal, Sget_unicode_property_internal,
3408 and Sput_unicode_property_internal. Defvar_lisp
3409 char-code-property-alist.
3411 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3412 Vunicode_category_table.
3414 * font.c (font_range): Adjust for the change of
3415 Vunicode_category_table.
3417 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3419 * m/iris4d.h: Remove file, move contents ...
3420 * s/irix6-5.h: ... here.
3422 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3424 Remove unportable assumption about struct layout (Bug#8884).
3425 * alloc.c (mark_buffer):
3426 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3427 (clone_per_buffer_values): Don't assume that
3428 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3429 This isn't true in general, and it's particularly not true
3430 if Emacs is configured with --with-wide-int.
3431 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3432 New macros, used in the buffer.c change.
3434 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3436 * xsettings.c: Use both GConf and GSettings if both are available.
3437 (store_config_changed_event): Add comment.
3438 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3439 (store_tool_bar_style_changed): New functions.
3440 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3441 (struct xsettings): Move font inside HAVE_XFT.
3442 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3443 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3444 Move inside HAVE_XFT.
3445 (something_changed_gsettingsCB): Rename from something_changedCB.
3446 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3448 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3449 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3450 (something_changed_gconfCB): Rename from something_changedCB.
3451 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3452 (parse_settings): Move check for font inside HAVE_XFT.
3453 (read_settings, apply_xft_settings): Add comment.
3454 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3455 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3456 call store_font_name_changed.
3457 (xft_settings_event): Add comment.
3458 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3459 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3460 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3461 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3462 (xsettings_initialize): Call init_gsettings last.
3463 (xsettings_get_system_font, xsettings_get_system_normal_font):
3466 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3468 Random fixes. E.g., (random) never returned negative values.
3469 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3470 subseconds part to the entropy, as that's a bit more random.
3471 Prefer signed to unsigned, since the signedness doesn't matter and
3472 in general we prefer signed. When given a limit, use a
3473 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3474 latter isn't right if USE_2_TAGS_FOR_INTS.
3475 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3476 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3478 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3480 * textprop.c (text_property_stickiness):
3481 Obey Vtext_property_default_nonsticky.
3482 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3483 * w32fns.c (syms_of_w32fns):
3484 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3486 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3488 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3489 This is more efficient than Ffile_directory_p and avoids a minor race.
3491 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3493 * buffer.c (Foverlay_put): Say what the return value is
3496 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3497 is a directory before asking whether to use the file name
3499 (barf_or_query_if_file_exists): Make the "File is a directory"
3500 error be more correct.
3502 * fns.c (Frequire): Remove the mention of the .gz files, since
3503 that's installation-specific, but keep the mention of
3504 `get-load-suffixes'.
3506 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3508 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3509 Report string overflow if the output is too long.
3511 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3513 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3514 (syms_of_gnutls): Remove duplicate DEFSYM for
3515 Qgnutls_bootprop_verify_hostname_error, an error for
3516 Qgnutls_bootprop_verify_error (which is no longer used).
3518 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3519 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3520 Also (re)move comments that are misplaced or no longer relevant.
3522 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3524 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3526 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3528 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3529 and background color parameters if they have been changed.
3531 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3533 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3535 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3537 * xsettings.c (SYSTEM_FONT): Define only when used.
3538 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3540 * keymap.c (access_keymap_1): Now static.
3542 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3544 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3545 leave any prefix arg for the up event (Bug#1586).
3547 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3549 * lread.c (syms_of_lread): Mention single symbols defined by
3550 `defvar' or `defconst' (bug#7154).
3552 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3553 (Frequire): Mention get-load-suffixes.
3555 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3557 * window.h (window): Remove clone_number slot.
3558 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3560 (make_parent_window, make_window, saved_window)
3561 (Fset_window_configuration, save_window_save): Don't deal with
3563 * buffer.c (Qclone_number): Remove declaration.
3564 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3566 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3568 Add multiple inheritance to keymaps.
3569 * keymap.c (Fmake_composed_keymap): New function.
3570 (Fset_keymap_parent): Simplify.
3571 (fix_submap_inheritance): Remove.
3572 (access_keymap_1): New function extracted from access_keymap to handle
3573 embedded parents and handle lists of maps.
3574 (access_keymap): Use it.
3575 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3576 (Fcopy_keymap): Handle embedded parents.
3577 (Fcommand_remapping, define_as_prefix): Simplify.
3578 (Fkey_binding): Simplify.
3579 (syms_of_keymap): Move minibuffer-local-completion-map,
3580 minibuffer-local-filename-completion-map,
3581 minibuffer-local-must-match-map, and
3582 minibuffer-local-filename-must-match-map to Elisp.
3583 (syms_of_keymap): Defsubr make-composed-keymap.
3584 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3585 (parse_menu_item): Trivial simplification.
3587 2011-07-01 Glenn Morris <rgm@gnu.org>
3589 * Makefile.in (SETTINGS_LIBS): Fix typo.
3591 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3593 * coding.c (Fencode_coding_string): Record the last coding system
3594 used, as the function doc string says (bug#8738).
3596 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3598 * xsettings.c (store_monospaced_changed): Take new font as arg and
3599 check for change against current_mono_font.
3600 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3601 (emacs_settings_constructor, emacs_settings_get_property)
3602 (emacs_settings_set_property, emacs_settings_class_init)
3603 (emacs_settings_init, gsettings_obj): Remove.
3604 (something_changedCB): New function for HAVE_GSETTINGS.
3605 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3606 with value as argument.
3607 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3608 g_settings_new (Bug#8967). Do not create gsettings_obj.
3609 Remove calls to g_settings_bind. Connect something_changedCB to
3612 * xgselect.c: Add defined (HAVE_GSETTINGS).
3613 (xgselect_initialize): Ditto.
3615 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3616 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3619 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3621 * eval.c (struct backtrace): Simplify and port the data structure.
3622 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3623 signed bit field, as this assumption is not portable and it makes
3624 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3625 "char debug_on_exit : 1" as this is not portable either; instead,
3626 use the portable "unsigned int debug_on_exit : 1". Remove unused
3627 member evalargs. Remove obsolete comments about cc bombing out.
3629 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3631 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3632 Let HAVE_GSETTINGS override HAVE_GCONF.
3633 (store_monospaced_changed): New function.
3634 (EMACS_SETTINGS): A new type derived from GObject to handle
3635 GSettings notifications.
3636 (emacs_settings_constructor, emacs_settings_get_property)
3637 (emacs_settings_set_property, emacs_settings_class_init):
3639 (gsettings_client, gsettings_obj): New variables.
3640 (GSETTINGS_SCHEMA): New define.
3641 (something_changedCB): Call store_monospaced_changed.
3642 (init_gsettings): New function.
3643 (xsettings_initialize): Call init_gsettings.
3644 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3647 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3650 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3652 * window.c (resize_root_window, grow_mini_window)
3653 (shrink_mini_window): Rename Qresize_root_window to
3654 Qwindow_resize_root_window and Qresize_root_window_vertically to
3655 Qwindow_resize_root_window_vertically.
3657 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3659 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3661 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3663 * makefile.w32-in: Redesign dependencies so they reflect more
3664 clearly which files are directly included by each source file,
3665 and not through other includes.
3667 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3669 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3670 (sort_overlays, overlay_strings): When an overlay's clone number
3671 matches the window's clone number process the overlay even if
3672 the overlay's window property doesn't match the current window.
3674 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3675 (Fwindow_hchild): Rename to Fwindow_left_child.
3676 (Fwindow_next): Rename to Fwindow_next_sibling.
3677 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3678 (resize_window_check): Rename to window_resize_check.
3679 (resize_window_apply): Rename to window_resize_apply.
3680 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3681 (Fdelete_other_windows_internal, resize_frame_windows)
3682 (Fsplit_window_internal, Fdelete_window_internal)
3683 (grow_mini_window, shrink_mini_window)
3684 (Fresize_mini_window_internal): Fix callers accordingly.
3686 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3688 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3689 (emacs_fixed_set_min_size): Remove.
3690 (emacs_fixed_new): Take frame as argument.
3692 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3693 (_EmacsFixedPrivate): Remove minwidth/height.
3694 Add struct frame *f.
3695 (emacs_fixed_init): Initialize priv->f.
3696 (get_parent_class, emacs_fixed_set_min_size): Remove.
3697 (emacs_fixed_new): Set priv->f to argument.
3698 (emacs_fixed_get_preferred_width)
3699 (emacs_fixed_get_preferred_height): Use min_width/height from
3700 frames size_hint to set minimum and natural (Bug#8919).
3701 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3702 and use min_width/height from frames size_hint to set
3703 min_width/height (Bug#8919).
3705 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3706 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3709 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3711 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3712 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3715 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3717 * process.c (wait_reading_process_output): Bypass select if
3718 waiting for a cell while ignoring keyboard input, and input is
3719 pending. Suggested by Jan Djärv (Bug#8869).
3721 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3723 Use gnulib's dup2 module instead of rolling our own.
3724 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3726 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3728 * dispnew.c (scrolling_window): Before scrolling, turn off a
3729 mouse-highlight in the window being scrolled.
3731 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3733 Move DEFSYM to lisp.h and use everywhere.
3735 * character.h (DEFSYM): Move declaration...
3736 * lisp.h (DEFSYM): ...here.
3742 * w32select.c: Don't include character.h.
3744 * alloc.c (syms_of_alloc):
3745 * buffer.c (syms_of_buffer):
3746 * bytecode.c (syms_of_bytecode):
3747 * callint.c (syms_of_callint):
3748 * casefiddle.c (syms_of_casefiddle):
3749 * casetab.c (init_casetab_once):
3750 * category.c (init_category_once, syms_of_category):
3751 * ccl.c (syms_of_ccl):
3752 * cmds.c (syms_of_cmds):
3753 * composite.c (syms_of_composite):
3754 * dbusbind.c (syms_of_dbusbind):
3755 * dired.c (syms_of_dired):
3756 * dispnew.c (syms_of_display):
3757 * doc.c (syms_of_doc):
3758 * editfns.c (syms_of_editfns):
3759 * emacs.c (syms_of_emacs):
3760 * eval.c (syms_of_eval):
3761 * fileio.c (syms_of_fileio):
3762 * fns.c (syms_of_fns):
3763 * frame.c (syms_of_frame):
3764 * fringe.c (syms_of_fringe):
3765 * insdel.c (syms_of_insdel):
3766 * keymap.c (syms_of_keymap):
3767 * lread.c (init_obarray, syms_of_lread):
3768 * macros.c (syms_of_macros):
3769 * msdos.c (syms_of_msdos):
3770 * print.c (syms_of_print):
3771 * process.c (syms_of_process):
3772 * search.c (syms_of_search):
3773 * sound.c (syms_of_sound):
3774 * syntax.c (init_syntax_once, syms_of_syntax):
3775 * terminal.c (syms_of_terminal):
3776 * textprop.c (syms_of_textprop):
3777 * undo.c (syms_of_undo):
3778 * w32.c (globals_of_w32):
3779 * window.c (syms_of_window):
3780 * xdisp.c (syms_of_xdisp):
3781 * xfaces.c (syms_of_xfaces):
3782 * xfns.c (syms_of_xfns):
3783 * xmenu.c (syms_of_xmenu):
3784 * xsettings.c (syms_of_xsettings):
3785 * xterm.c (syms_of_xterm): Use DEFSYM.
3787 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3789 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3791 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3793 Integer and buffer overflow fixes (Bug#8873).
3795 * print.c (printchar, strout): Check for string overflow.
3796 (PRINTPREPARE, printchar, strout):
3797 Don't set size unless allocation succeeds.
3799 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3800 for sizes. Check for string overflow more accurately.
3801 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3803 * macros.c: Integer and buffer overflow fixes.
3804 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3805 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3806 Use ptrdiff_t, not int, for sizes.
3807 Don't increment bufsize until after realloc succeeds.
3808 Check for size-calculation overflow.
3809 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3811 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3813 * lread.c: Integer overflow fixes.
3814 (read_integer): Radix is now EMACS_INT, not int,
3815 to improve quality of diagnostics for out-of-range radices.
3816 Calculate buffer size correctly for out-of-range radices.
3817 (read1): Check for integer overflow in radices, and in
3818 read-circle numbers.
3819 (read_escape): Avoid int overflow.
3820 (Fload, openp, read_buffer_size, read1)
3821 (substitute_object_recurse, read_vector, read_list, map_obarray):
3822 Use ptrdiff_t, not int, for sizes.
3823 (read1): Use EMACS_INT, not int, for sizes.
3824 Check for size overflow.
3826 * image.c (cache_image): Check for size arithmetic overflow.
3828 * lread.c: Integer overflow issues.
3829 (saved_doc_string_size, saved_doc_string_length)
3830 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3831 Now ptrdiff_t, not int.
3832 (read1): Don't assume doc string length fits in int. Check for
3833 out-of-range doc string lengths.
3834 (read_list): Don't assume file position fits in int.
3835 (read_escape): Check for hex character overflow.
3837 2011-06-22 Leo Liu <sdl.web@gmail.com>
3839 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3840 Move to minibuffer.el.
3842 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3844 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3845 The following patches are for when GLYPH_DEBUG && !XASSERT.
3846 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3847 * dispnew.c (flush_stdout):
3848 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3849 Mark as externally visible.
3850 * dispnew.c (check_window_matrix_pointers): Now static.
3851 * dispnew.c (window_to_frame_vpos):
3852 * xfns.c (unwind_create_frame):
3853 * xterm.c (x_check_font): Remove unused local.
3854 * scroll.c (CHECK_BOUNDS):
3855 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3856 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3857 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3858 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3859 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3861 (debug_method_add): Use va_list and vsprintf rather than relying
3862 on undefined behavior with wrong number of arguments.
3863 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3864 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3865 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3866 since we're not interested in debugging glyphs with old libraries.
3867 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3868 GCC 4.6.0's static checking.
3870 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3872 Integer overflow and signedness fixes (Bug#8873).
3873 A few related buffer overrun fixes, too.
3875 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3877 * dispextern.h (struct face.stipple):
3878 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3879 (x_bitmap_mask, x_allocate_bitmap_record)
3880 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3881 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3882 (x_create_bitmap_from_xpm_data):
3883 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3884 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3886 * xfaces.c (load_pixmap):
3887 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3888 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3889 (.bitmaps_last, struct x_output.icon_bitmap):
3890 Use ptrdiff_t, not int, for bitmap indexes.
3891 (x_allocate_bitmap_record): Check for size overflow.
3892 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3894 Use ptrdiff_t, not int, for overlay counts.
3895 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3896 * editfns.c (overlays_around, get_pos_property):
3897 * textprop.c (get_char_property_and_overlay):
3898 * xdisp.c (next_overlay_change, note_mouse_highlight):
3899 * xfaces.c (face_at_buffer_position):
3900 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3901 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3902 (Fnext_overlay_change, Fprevious_overlay_change)
3903 (mouse_face_overlay_overlaps, Foverlays_in):
3904 Use ptrdiff_t, not int, for sizes.
3905 (overlays_at, overlays_in): Check for size-calculation overflow.
3907 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3909 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3910 (x_session_initialize): Do not assume string length fits in int.
3912 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3913 This is unlikely, but can occur if DPI is outlandish.
3915 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3916 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3918 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3919 * xrdb.c (magic_file_p, search_magic_path):
3920 Omit last arg SUFFIX; it was always 0. All callers changed.
3921 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3923 * xfont.c (xfont_match): Avoid need for strlen.
3925 * xfns.c: Don't assume strlen fits in int.
3926 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3928 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3929 not unsigned long, as we prefer signed integers. All callers changed.
3930 Detect integer overflow in repeat count.
3931 (message_dolog): Don't assume print length fits in 39 bytes.
3932 (display_mode_element): Don't assume strlen fits in int.
3934 * termcap.c: Don't assume sizes fit in int and never overflow.
3935 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3936 (gobble_line): Check for size-calculation overflow.
3938 * minibuf.c (Fread_buffer):
3939 * lread.c (intern, intern_c_string):
3940 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3941 Don't assume string length fits in int.
3943 * keyboard.c (parse_tool_bar_item):
3944 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3946 * font.c: Don't assume string length fits in int.
3947 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3948 Use ptrdiff_t, not int.
3949 (font_intern_prop): Don't assume string length fits in int.
3950 Don't assume integer property fits in fixnum.
3951 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3953 * filelock.c: Fix some buffer overrun and integer overflow issues.
3954 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3955 Reformulate so as not to need the command string.
3956 Invoke gzip -cd rather than gunzip, as it's more portable.
3957 (lock_info_type, lock_file_1, lock_file):
3958 Don't assume pid_t and time_t fit in unsigned long.
3959 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3960 (current_lock_owner): Prefer signed type for sizes.
3961 Use memcpy, not strncpy, where memcpy is what is really wanted.
3962 Don't assume (via atoi) that time_t and pid_t fit in int.
3963 Check for time_t and/or pid_t out of range, e.g., via a network share.
3964 Don't alloca where an auto var works fine.
3966 * fileio.c: Fix some integer overflow issues.
3967 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3968 Don't assume string length fits in int.
3969 (directory_file_name): Don't assume string length fits in long.
3970 (make_temp_name): Don't assume pid fits in int, or that its print
3971 length is less than 20.
3973 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3975 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3977 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3979 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3980 We prefer signed integers, even for size calculations.
3982 * emacs.c: Don't assume string length fits in 'int'.
3983 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3984 (main): Don't invoke strlen when not needed.
3986 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3987 (XD_DEBUG_MESSAGE): Don't waste a byte.
3989 * callproc.c (getenv_internal_1, getenv_internal)
3991 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3993 * lread.c (invalid_syntax): Omit length argument.
3994 All uses changed. This doesn't fix a bug, but it simplifies the
3995 code away from its former Hollerith-constant appearance, and it's
3996 one less 'int' to worry about when looking at integer-overflow issues.
3997 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3999 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4000 This didn't break anything, but it didn't help either.
4001 It's confusing to put a bogus integer in a place where the actual
4002 value does not matter.
4003 (LIST_END_P): Remove unused macro and its bogus comment.
4004 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4006 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4007 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4009 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4010 We prefer signed types, and the value cannot exceed the EMACS_INT
4011 range anyway (because otherwise the length would not be representable).
4012 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4013 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4014 This avoids a GCC warning when WIDE_EMACS_INT.
4016 * indent.c (sane_tab_width): New function.
4017 (current_column, scan_for_column, Findent_to, position_indentation)
4018 (compute_motion): Use it. This is just for clarity.
4019 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4021 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4023 * lisp.h (lint_assume): New macro.
4024 * composite.c (composition_gstring_put_cache):
4025 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4027 * editfns.c, insdel.c:
4028 Omit unnecessary forward decls, to simplify future changes.
4030 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4032 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4034 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4035 Use much-faster test for byte-length change.
4036 Don't assume string byte-length fits in 'int'.
4037 Check that character arg fits in 'int'.
4038 (mapcar1): Declare byte as byte, for clarity.
4040 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4042 * fns.c (concat): Catch string overflow earlier.
4043 Do not rely on integer wraparound.
4045 * dispextern.h (struct it.overlay_strings_charpos)
4046 (struct it.selective): Now EMACS_INT, not int.
4047 * xdisp.c (forward_to_next_line_start)
4048 (back_to_previous_visible_line_start)
4049 (reseat_at_next_visible_line_start, next_element_from_buffer):
4050 Don't arbitrarily truncate the value of 'selective' to int.
4052 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4054 * composite.c: Don't truncate sizes to 'int'.
4055 (composition_gstring_p, composition_reseat_it)
4056 (composition_adjust_point): Use EMACS_INT, not int.
4057 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4058 not EMACS_UINT, for indexes.
4060 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4062 * buffer.c: Include <verify.h>.
4063 (struct sortvec.priority, struct sortstr.priority):
4064 Now EMACS_INT, not int.
4065 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4066 (struct sortstr.size, record_overlay_string)
4067 (struct sortstrlist.size, struct sortlist.used):
4068 Don't truncate size to int.
4069 (record_overlay_string): Check for size-calculation overflow.
4070 (init_buffer_once): Check at compile-time, not run-time.
4072 2011-06-22 Jim Meyering <meyering@redhat.com>
4074 Don't leak an XBM-image-sized buffer
4075 * image.c (xbm_load): Free the image buffer after using it.
4077 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4080 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4081 that Sun C diagnosed.
4082 * fns.c (secure_hash): Fix pointer signedness issue.
4083 * intervals.c (static_offset_intervals): New function.
4084 (offset_intervals): Use it.
4086 2011-06-21 Leo Liu <sdl.web@gmail.com>
4089 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4092 * fns.c (secure_hash): Rename from crypto_hash_function and change
4093 the first arg to accept symbols.
4094 (Fsecure_hash): New primitive.
4095 (syms_of_fns): New symbols.
4097 2011-06-20 Deniz Dogan <deniz@dogan.se>
4099 * process.c (Fset_process_buffer): Clarify return value in
4102 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4104 * dispnew.c (add_window_display_history): Use BVAR.
4106 * xdisp.c (debug_method_add): Use BVAR.
4107 (check_window_end, dump_glyph_matrix, dump_glyph)
4108 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4110 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4113 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4114 check till after the cache is created in init_frame_faces.
4116 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4118 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4120 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4122 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4123 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4124 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4126 Improve buffer-overflow checking (Bug#8873).
4127 * fileio.c (Finsert_file_contents):
4128 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4129 Remove the old (too-loose) buffer overflow checks.
4130 They weren't needed, since make_gap checks for buffer overflow.
4131 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4132 The old code merely checked for Emacs fixnum overflow, and relied
4133 on undefined (wraparound) behavior. The new code avoids undefined
4134 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4136 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4137 Tune. Don't use wider integers than needed. Don't use alloca.
4138 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4140 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4142 * insdel.c, lisp.h (buffer_overflow): New function.
4143 (insert_from_buffer_1, replace_range, replace_range_2):
4144 * insdel.c (make_gap_larger):
4145 * editfns.c (Finsert_char):
4146 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4148 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4150 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4152 Integer overflow and signedness fixes (Bug#8873).
4154 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4155 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4157 * fileio.c: Don't assume EMACS_INT fits in off_t.
4158 (emacs_lseek): New static function.
4159 (Finsert_file_contents, Fwrite_region): Use it.
4160 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4162 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4164 * fns.c: Don't overflow int when computing a list length.
4165 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4166 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4167 truncation on 64-bit hosts. Check for QUIT every
4168 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4169 faster and is responsive enough.
4170 (Flength): Report an error instead of overflowing an integer.
4171 (Fsafe_length): Return a float if the value is not representable
4172 as a fixnum. This shouldn't happen except in contrived situations.
4173 (Fnthcdr, Fsort): Don't assume list length fits in int.
4174 (Fcopy_sequence): Don't assume vector length fits in int.
4176 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4177 (header_size, word_size): New constants.
4178 (allocate_vectorlike): Don't check size overflow here.
4179 (allocate_vector): Check it here instead, since this is the only
4180 caller of allocate_vectorlike that could cause overflow.
4181 Check that the new vector's length is representable as a fixnum.
4183 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4184 The previous code was bogus. For example, next_almost_prime (32)
4185 returned 39, which is undesirable as it is a multiple of 3; and
4186 next_almost_prime (24) returned 25, which is a multiple of 5 so
4187 why was the code bothering to check for multiples of 7?
4189 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4191 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4193 Variadic C functions now count arguments with ptrdiff_t.
4194 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4195 Back then I didn't know that the Emacs coding style prefers signed int.
4196 Also, in the meantime I found a few more instances where arguments
4197 were being counted with int, which may truncate counts on 64-bit
4198 machines, or EMACS_INT, which may be unnecessarily wide.
4199 * lisp.h (struct Lisp_Subr.function.aMANY)
4200 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4201 Arg counts are now ptrdiff_t, not size_t.
4202 All variadic functions and their callers changed accordingly.
4203 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4204 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4205 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4206 * callint.c (Fcall_interactively): Check arg count for overflow,
4207 to avoid potential buffer overrun. Use signed char, not 'int',
4208 for 'varies' array, so that we needn't bother to check its size
4209 calculation for overflow.
4210 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4211 * eval.c (apply_lambda):
4212 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4213 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4214 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4216 * callint.c (Fcall_interactively): Don't use index var as event count.
4218 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4219 * mem-limits.h (SIZE): Remove; no longer used.
4221 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4223 Remove unnecessary casts.
4224 * xterm.c (x_term_init):
4225 * xfns.c (x_set_border_pixel):
4226 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4227 These aren't needed now that we assume ANSI C.
4229 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4230 It's more likely to cause problems (due to unsigned overflow)
4233 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4235 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4237 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4239 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4241 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4243 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4245 GLYPH_CODE_FACE returns EMACS_INT, not int.
4246 * dispextern.h (merge_faces):
4247 * xfaces.c (merge_faces):
4248 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4249 Don't assume EMACS_INT fits in int.
4251 * character.h (CHAR_VALID_P): Remove unused parameter.
4252 * fontset.c, lisp.h, xdisp.c: All uses changed.
4254 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4256 * fns.c (concat): Minor tuning based on overflow analysis.
4257 This doesn't fix any bugs. Use int to hold character, instead
4258 of constantly refetching from Emacs object. Use XFASTINT, not
4259 XINT, for value known to be a character. Don't bother comparing
4260 a single byte to 0400, as it's always less.
4262 * floatfns.c (Fexpt):
4263 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4265 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4268 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4270 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4271 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4272 incorrectly succeed when S was a string, because 4294967386 was
4273 truncated before it was used.
4275 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4276 Otherwise, an out-of-range integer could cause undefined behavior
4279 * composite.c: Use int, not EMACS_INT, for characters.
4280 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4281 EMACS_INT, for values that are known to be in character range.
4282 This doesn't fix any bugs but is the usual style inside Emacs and
4283 may generate better code on 32-bit machines.
4285 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4286 This is for reasons similar to the recent CHAR_STRING fix.
4287 * charset.c (Fencode_char): Check that character arg is actually
4288 a character. Pass an int to ENCODE_CHAR.
4289 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4290 wider than 'int', as a compile-time check to prevent future regressions
4293 * character.c (char_string): Remove unnecessary casts.
4295 Make sure a 64-bit char is never passed to CHAR_STRING.
4296 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4297 by silently ignoring the top 32 bits, allowing some values
4298 that were far too large to be valid characters.
4299 * character.h: Include <verify.h>.
4300 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4301 arguments are no wider than unsigned, as a compile-time check
4302 to prevent future regressions in this area.
4304 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4305 (Fsubst_char_in_region):
4307 * xdisp.c (decode_mode_spec_coding):
4308 Adjust to CHAR_STRING's new requirement.
4309 * editfns.c (Finsert_char, Fsubst_char_in_region):
4310 * fns.c (concat): Check that character args are actually
4311 characters. Without this test, these functions did the wrong
4312 thing with wildly out-of-range values on 64-bit hosts.
4314 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4315 These casts should not be needed on 32-bit hosts, either.
4316 * keyboard.c (read_char):
4317 * lread.c (Fload): Remove casts to unsigned.
4319 * lisp.h (UNSIGNED_CMP): New macro.
4320 This fixes comparison bugs on 64-bit hosts.
4321 (ASCII_CHAR_P): Use it.
4322 * casefiddle.c (casify_object):
4323 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4324 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4325 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4326 * dispextern.h (FACE_FROM_ID):
4327 * keyboard.c (read_char): Use UNSIGNED_CMP.
4329 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4330 not to EMACS_INT, to avoid GCC warning.
4332 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4334 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4335 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4336 isn't needed on 32-bit machines.
4338 * buffer.c (Fgenerate_new_buffer_name):
4339 Use EMACS_INT for count, not int.
4340 (advance_to_char_boundary): Return EMACS_INT, not int.
4342 * data.c (Qcompiled_function): Now static.
4344 * window.c (window_body_lines): Now static.
4346 * image.c (gif_load): Rename local to avoid shadowing.
4348 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4349 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4350 * alloc.c (make_save_value): Integer argument is now of type
4352 (mark_object): Use ptrdiff_t, not int.
4353 * lisp.h (pD): New macro.
4354 * print.c (print_object): Use it.
4356 * alloc.c: Use EMACS_INT, not int, to count objects.
4357 (total_conses, total_markers, total_symbols, total_vector_size)
4358 (total_free_conses, total_free_markers, total_free_symbols)
4359 (total_free_floats, total_floats, total_free_intervals)
4360 (total_intervals, total_strings, total_free_strings):
4361 Now EMACS_INT, not int. All uses changed.
4362 (Fgarbage_collect): Compute overall total using a double, so that
4363 integer overflow is less likely to be a problem. Check for overflow
4364 when converting back to an integer.
4365 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4366 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4367 These were 'int' variables that could overflow on 64-bit hosts;
4368 they were never used, so remove them instead of repairing them.
4369 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4370 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4371 Previously, this ceilinged at INT_MAX, but that doesn't work on
4373 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4375 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4376 (allocate_vectorlike): Check for ptrdiff_t overflow.
4377 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4378 when a (possibly-narrower) signed value would do just as well.
4379 We prefer using signed arithmetic, to avoid comparison confusion.
4381 * alloc.c: Catch some string size overflows that we were missing.
4382 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4383 for convenience in STRING_BYTES_MAX.
4384 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4385 The definition here is exact; the one in lisp.h was approximate.
4386 (allocate_string_data): Check for string overflow. This catches
4387 some instances we weren't catching before. Also, it catches
4388 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4389 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4390 and ptrdiff_t and EMACS_INT are both 64 bits.
4392 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4393 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4394 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4396 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4398 * alloc.c (Fmake_string): Check for out-of-range init.
4400 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4402 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4404 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4406 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4407 xg_get_default_scrollbar_width.
4409 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4410 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4411 (style_changed_cb): Call update_theme_scrollbar_width and call
4412 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4413 all frames (Bug#8505).
4414 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4415 Call gtk_window_set_resizable if HAVE_GTK3.
4416 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4417 and height if HAVE_GTK3 (Bug#8505).
4418 (scroll_bar_width_for_theme): New variable.
4419 (update_theme_scrollbar_width): New function.
4420 (xg_get_default_scrollbar_width): Move code to
4421 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4422 (xg_initialize): Call update_theme_scrollbar_width.
4424 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4426 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4428 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4430 * frame.c (make_frame): Call other_buffer_safely instead of
4433 * window.c (temp_output_buffer_show): Call display_buffer with
4434 second argument Vtemp_buffer_show_specifiers and reset latter
4435 immediately after the call.
4436 (Vtemp_buffer_show_specifiers): New variable.
4437 (auto_window_vscroll_p, next_screen_context_lines)
4438 (Vscroll_preserve_screen_position): Remove leading asterisks from
4441 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4443 Fix minor problems found by GCC 4.6.0 static checking.
4444 * buffer.c (Qclone_number): Remove for now, as it's unused.
4445 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4446 (record_buffer): Remove unused local.
4447 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4448 (set_frame_buffer_list): Remove; unused.
4449 * frame.h (other_visible_frames): Remove decl.
4450 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4451 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4452 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4454 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4455 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4456 Define only if HAVE_GPM.
4457 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4458 (update_hints_inhibit): Remove; never set. All uses removed.
4459 * widgetprv.h (emacsFrameClassRec): Remove decl.
4460 * window.c (delete_deletable_window): Now returns void, since it
4461 wasn't returning anything.
4462 (compare_window_configurations): Remove unused locals.
4463 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4464 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4465 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4466 the same widths as pointers. This follows up on the 2011-05-06 patch.
4467 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4468 * xterm.h: Likewise.
4469 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4471 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4473 * makefile.w32-in: Update dependencies.
4474 (LISP_H): Add lib/intprops.h.
4476 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4478 * image.c (gif_load): Add animation frame delay to the metadata.
4479 (syms_of_image): Use DEFSYM. New symbol `delay'.
4481 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4483 * window.c (delete_deletable_window): Re-add.
4484 (Fset_window_configuration): Rewrite to handle dead buffers and
4485 consequently deletable windows.
4486 (window_tree, Fwindow_tree): Remove. Supply functionality in
4488 (compare_window_configurations): Simplify code.
4490 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4492 * image.c (imagemagick_load_image): Fix type mismatch.
4493 (Fimagemagick_types): Likewise.
4495 * window.h (replace_buffer_in_windows): Declare.
4497 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4499 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4500 Qclone_number. Remove external declaration of Qdelete_window.
4501 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4503 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4504 Run Qbuffer_list_update_hook if allowed.
4505 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4506 buffer list implementation.
4507 (other_buffer_safely): New function.
4508 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4509 calls to replace_buffer_in_windows and
4510 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4512 (record_buffer): Inhibit quitting and rewrite using quittable
4513 functions. Run Qbuffer_list_update_hook if allowed.
4514 (Frecord_buffer, Funrecord_buffer): New functions.
4515 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4516 Move switch-to-buffer to window.el.
4517 (bury-buffer): Move to window.el.
4518 (Vbuffer_list_update_hook): New variable.
4520 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4523 * window.h (resize_frame_windows): Move up in code.
4524 (Fwindow_frame): Remove EXFUN.
4525 (replace_buffer_in_all_windows): Remove prototype.
4526 (replace_buffer_in_windows_safely): Add prototype.
4528 * window.c: Declare Qdelete_window static again. Move down
4529 declaration of select_count.
4530 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4531 (Fother_window): Move to window.el.
4532 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4533 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4534 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4536 (replace_buffer_in_windows): Implement by calling
4537 Qreplace_buffer_in_windows.
4538 (replace_buffer_in_all_windows): Remove with some functionality
4539 moved into replace_buffer_in_windows_safely.
4540 (replace_buffer_in_windows_safely): New function.
4541 (select_window_norecord, select_frame_norecord): Move in front
4542 of run_window_configuration_change_hook. Remove now obsolete
4544 (Fset_window_buffer): Rewrite doc-string.
4545 Call Qrecord_window_buffer.
4546 (keys_of_window): Move binding for other-window to window.el.
4548 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4550 * dispextern.h (struct image): Replace data member, whose int_val
4551 and ptr_val fields were not used by anything, with a single
4554 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4555 (gif_clear_image, gif_load, imagemagick_load_image)
4556 (gs_clear_image, gs_load): Callers changed.
4558 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4560 * buffer.h: Include <time.h>, for time_t.
4561 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4563 Fix minor problems found by static checking.
4565 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4567 Make identifiers static if they are not used in other modules.
4568 * data.c (Qcompiled_function, Qframe, Qvector):
4569 * image.c (QimageMagick, Qsvg):
4570 * minibuf.c (Qmetadata):
4571 * window.c (resize_window_check, resize_root_window): Now static.
4572 * window.h (resize_window_check, resize_root_window): Remove decls.
4574 * window.c (window_deletion_count, delete_deletable_window):
4576 (window_body_lines): Now static.
4577 (Fdelete_other_windows_internal): Mark vars as initialized.
4578 Make sure 'resize_failed' is initialized.
4579 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4580 (resize_window_apply): Remove unused local.
4581 * window.h (delete_deletable_window): Remove decl.
4583 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4584 (imagemagick_load_image): Fix pointer signedness problem by changing
4585 last arg from unsigned char * to char *. All uses changed.
4586 Also, fix a local for similar reasons.
4587 Remove unused locals. Remove locals to avoid shadowing.
4588 (fn_rsvg_handle_free): Remove; unused.
4589 (svg_load, svg_load_image): Fix pointer signedness problem.
4590 (imagemagick_load_image): Don't use garbage pointer image_wand.
4592 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4594 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4596 * image.c (gif_load): Fix omitted cast error introduced by
4599 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4601 * window.h (resize_proportionally, orig_total_lines)
4602 (orig_top_line): Remove from window structure.
4603 (set_window_height, set_window_width, change_window_heights)
4604 (Fdelete_window): Remove prototypes.
4605 (resize_frame_windows): Remove duplicate declaration.
4607 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4609 * window.h (resize_frame_windows, resize_window_check)
4610 (delete_deletable_window, resize_root_window)
4611 (resize_frame_windows): Declare prototypes.
4613 * window.c (resize_window_apply): Make definition be "static" to
4614 match the prototype.
4616 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4618 * window.c: Remove declarations of Qwindow_size_fixed,
4619 window_min_size_1, window_min_size_2, window_min_size,
4620 size_window, window_fixed_size_p, enlarge_window, delete_window.
4621 Remove static from declaration of Qdelete_window, it's
4622 temporarily needed by Fbury_buffer.
4623 (replace_window): Don't assign orig_top_line and
4625 (Fdelete_window, delete_window): Remove. Window deletion is
4626 handled by window.el.
4627 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4628 Replace Fdelete_window calls with calls to Qdelete_window.
4629 (Fdelete_other_windows): Remove. Deleting other windows is
4630 handled by window.el.
4631 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4632 handled in window.el.
4633 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4634 Window minimum sizes are handled in window.el.
4635 (shrink_windows, size_window, set_window_height)
4636 (set_window_width, change_window_heights, window_height)
4637 (window_width, CURBEG, CURSIZE, enlarge_window)
4638 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4639 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4640 handled in window.el.
4641 (make_dummy_parent): Rename to make_parent_window and give it a
4642 second argument horflag.
4643 (make_window): Don't set resize_proportionally any more.
4644 (Fsplit_window): Remove. Windows are split in window.el.
4645 (save_restore_action, save_restore_orig_size)
4646 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4647 Resize mini windows in window.el.
4648 (grow_mini_window, shrink_mini_window): Implement by calling
4649 Qresize_root_window_vertically, resize_window_check and
4650 resize_window_apply.
4651 (saved_window, Fset_window_configuration, save_window_save):
4652 Do not handle orig_top_line, orig_total_lines, and
4653 resize_proportionally.
4654 (window_min_height, window_min_width): Move to window.el.
4655 (keys_of_window): Move bindings for delete-other-windows,
4656 split-window, delete-window and enlarge-window to window.el.
4658 * buffer.c: Temporarily extern Qdelete_window.
4659 (Fbury_buffer): Temporarily call Qdelete_window instead of
4660 Fdelete_window (Fbury_buffer will move to window.el soon).
4662 * frame.c (set_menu_bar_lines_1): Remove code handling
4663 orig_top_line and orig_total_lines.
4665 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4666 set_window_height but set heights directly.
4667 (change_frame_size_1): Use resize_frame_windows.
4669 * xdisp.c (init_xdisp): Don't use set_window_height but set
4672 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4673 Use resize_frame_windows instead of change_window_heights and run
4674 run_window_configuration_change_hook.
4676 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4677 instead of change_window_heights and run
4678 run_window_configuration_change_hook.
4680 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4682 * window.c (replace_window): Rename second argument REPLACEMENT to
4683 NEW. New third argument SETFLAG. Rewrite.
4684 (delete_window, make_dummy_parent): Call replace_window with
4686 (window_list_1): Move down in code.
4687 (run_window_configuration_change_hook): Move set_buffer part
4688 before select_frame_norecord part in order to unwind correctly.
4689 Rename count1 to count.
4690 (recombine_windows, delete_deletable_window, resize_root_window)
4691 (Fdelete_other_windows_internal)
4692 (Frun_window_configuration_change_hook, make_parent_window)
4693 (resize_window_check, resize_window_apply, Fresize_window_apply)
4694 (resize_frame_windows, Fsplit_window_internal)
4695 (Fdelete_window_internal, Fresize_mini_window_internal):
4697 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4699 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4701 * window.h (window): Add some new members to window structure -
4702 normal_lines, normal_cols, new_total, new_normal, clone_number,
4703 splits, nest, prev_buffers, next_buffers.
4704 (WINDOW_TOTAL_SIZE): Move here from window.c.
4705 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4707 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4709 (make_dummy_parent): Set new members of windows structure.
4710 (make_window): Move down in code. Handle new members of window
4712 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4713 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4714 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4715 (Fset_window_prev_buffers, Fwindow_next_buffers)
4716 (Fset_window_next_buffers, Fset_window_clone_number):
4718 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4719 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4721 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4722 Argument WINDOW can be now internal window too.
4723 (Fwindow_use_time): Move up in code.
4724 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4726 (Fset_window_configuration, saved_window)
4727 (Fcurrent_window_configuration, save_window_save): Handle new
4728 members of window structure.
4729 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4730 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4731 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4732 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4733 Qget_mru_window, Qresize_root_window,
4734 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4735 Qauto_buffer_name; staticpro them.
4737 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4739 * window.c (Fwindow_total_size, Fwindow_left_column)
4740 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4741 (Fwindow_list_1): New functions.
4742 (window_box_text_cols): Replace with window_body_cols.
4743 (Fwindow_width, Fscroll_left, Fscroll_right):
4744 Use window_body_cols instead of window_box_text_cols.
4745 (delete_window, Fset_window_configuration):
4746 Call delete_all_subwindows with window as argument.
4747 (delete_all_subwindows): Take a window as argument and not a
4749 (window_loop): Remove handling of GET_LRU_WINDOW and
4751 (Fget_lru_window, Fget_largest_window): Move to window.el.
4753 * window.h: Extern window_body_cols instead of
4754 window_box_text_cols. delete_all_subwindows now takes a
4755 Lisp_Object as argument.
4757 * indent.c (compute_motion, Fcompute_motion):
4758 Use window_body_cols instead of window_box_text_cols.
4760 * frame.c (delete_frame): Call delete_all_subwindows with root
4763 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4765 * fns.c (Fputhash): Document return value.
4767 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4769 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4771 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4773 Cons<->int and similar integer overflow fixes (Bug#8794).
4775 Check for overflow when converting integer to cons and back.
4776 * charset.c (Fdefine_charset_internal, Fdecode_char):
4777 Use cons_to_unsigned to catch overflow.
4778 (Fencode_char): Use INTEGER_TO_CONS.
4779 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4780 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4781 * data.c (long_to_cons, cons_to_long): Remove.
4782 (cons_to_unsigned, cons_to_signed): New functions.
4783 These signal an error for invalid or out-of-range values.
4784 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4785 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4786 * font.c (Ffont_variation_glyphs):
4787 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4788 * lisp.h: Include <intprops.h>.
4789 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4790 (cons_to_signed, cons_to_unsigned): New decls.
4791 (long_to_cons, cons_to_long): Remove decls.
4792 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4793 (Fprimitive_undo): Use CONS_TO_INTEGER.
4794 * xfns.c (Fx_window_property): Likewise.
4795 * xselect.c: Include <limits.h>.
4796 (x_own_selection, selection_data_to_lisp_data):
4797 Use INTEGER_TO_CONS.
4798 (x_handle_selection_request, x_handle_selection_clear)
4799 (x_get_foreign_selection, Fx_disown_selection_internal)
4800 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4801 (lisp_data_to_selection_data): Use cons_to_unsigned.
4802 (x_fill_property_data): Use cons_to_signed.
4803 Report values out of range.
4805 Check for buffer and string overflow more precisely.
4806 * buffer.h (BUF_BYTES_MAX): New macro.
4807 * lisp.h (STRING_BYTES_MAX): New macro.
4808 * alloc.c (Fmake_string):
4809 * character.c (string_escape_byte8):
4810 * coding.c (coding_alloc_by_realloc):
4811 * doprnt.c (doprnt):
4812 * editfns.c (Fformat):
4814 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4815 since they may not be the same number.
4816 * editfns.c (Finsert_char):
4817 * fileio.c (Finsert_file_contents):
4818 Likewise for BUF_BYTES_MAX.
4820 * image.c: Use ptrdiff_t, not int, for sizes.
4821 (slurp_file): Switch from int to ptrdiff_t.
4823 (slurp_file): Check that file size fits in both size_t (for
4824 malloc) and ptrdiff_t (for sanity and safety).
4826 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4827 if b->modtime has its maximal value.
4829 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4831 Don't assume time_t can fit into int.
4832 * buffer.h (struct buffer.modtime): Now time_t, not int.
4833 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4834 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4836 Minor fixes for signed vs unsigned integers.
4837 * character.h (MAYBE_UNIFY_CHAR):
4838 * charset.c (maybe_unify_char):
4839 * keyboard.c (read_char, reorder_modifiers):
4840 XINT -> XFASTINT, since the integer must be nonnegative.
4841 * ftfont.c (ftfont_spec_pattern):
4842 * keymap.c (access_keymap, silly_event_symbol_error):
4843 XUINT -> XFASTINT, since the integer must be nonnegative.
4844 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4845 since it makes no difference and we prefer signed.
4846 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4847 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4850 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4852 * window.h (Fwindow_frame): Declare.
4854 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4856 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4857 (SPARE_MEMORY): Always define.
4858 (LARGE_REQUEST): Remove.
4859 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4861 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4863 * lisp.h: Move EXFUNS for Fframe_root_window,
4864 Fframe_first_window and Fset_frame_selected_window to window.h.
4866 * window.h: Move EXFUNS for Fframe_root_window,
4867 Fframe_first_window and Fset_frame_selected_window here from
4870 * frame.c (Fwindow_frame, Fframe_first_window)
4871 (Fframe_root_window, Fframe_selected_window)
4872 (Fset_frame_selected_window): Move to window.c.
4873 (Factive_minibuffer_window): Move to minibuf.c.
4874 (Fother_visible_frames_p): New function.
4876 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4878 * window.c (decode_window, decode_any_window): Move up in code.
4879 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4880 (inhibit_frame_unsplittable): Remove unused variable.
4881 (Fwindow_buffer): Move up and rewrite doc-string.
4882 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4883 (Fwindow_prev): New functions.
4884 (Fwindow_frame): Move here from frame.c. Accept any window as
4886 (Fframe_root_window, Fframe_first_window)
4887 (Fframe_selected_window): Move here from frame.c. Accept frame
4888 or arbitrary window as argument. Update doc-strings.
4889 (Fminibuffer_window): Move up in code.
4890 (Fwindow_minibuffer_p): Move up in code and simplify.
4891 (Fset_frame_selected_window): Move here from frame.c.
4893 (Fselected_window, select_window, Fselect_window): Move up in
4894 code. Minor doc-string fixes.
4896 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4898 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4899 Do not assume that spare memory exists; that assumption is valid
4900 only if SYSTEM_MALLOC.
4901 (LARGE_REQUEST): New macro, so that the issue of large requests
4902 is separated from the issue of spare memory.
4904 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4906 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4909 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4911 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4914 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4916 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4918 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4920 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4921 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4923 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4925 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4927 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4929 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4930 (x_clipboard_manager_save): Add return value.
4931 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4933 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4934 Obey Vx_select_enable_clipboard_manager. Catch errors in
4935 x_clipboard_manager_save (Bug#8779).
4936 (Vx_select_enable_clipboard_manager): New variable.
4937 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4939 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4941 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4943 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4945 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4946 in the current matrix if keep_current_p is non-zero.
4948 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4950 * bidi.c (bidi_level_of_next_char): Fix last change.
4952 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4954 Support bidi reordering of text covered by display properties.
4956 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4957 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4958 (bidi_cache_search, bidi_cache_iterator_state)
4959 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4960 (bidi_level_of_next_char, bidi_move_to_visually_next):
4961 Support character positions inside a run of characters covered by a
4963 (bidi_paragraph_init, bidi_resolve_explicit_1)
4964 (bidi_level_of_next_char): Call bidi_fetch_char and
4965 bidi_fetch_char_advance instead of FETCH_CHAR and
4967 (bidi_init_it): Initialize new members.
4968 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4970 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4971 instead of using explicit *_CHAR codes.
4972 (bidi_resolve_explicit, bidi_resolve_weak):
4973 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4974 bidirectional text is supported only in multibyte buffers.
4975 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4976 it to initialize the frame_window_p member of struct bidi_it.
4977 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4978 (bidi_resolve_explicit, bidi_resolve_weak)
4979 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4980 bidi_it->nchars is non-positive.
4981 (bidi_level_of_next_char): Don't try to lookup the cache for the
4982 next/previous character if nothing is cached there yet, or if we
4983 were just reseat()'ed to a new position.
4985 * xdisp.c (set_cursor_from_row): Set start and stop points
4986 according to the row's direction when priming the loop that looks
4987 for the glyph on which to display cursor.
4988 (single_display_spec_intangible_p): Function deleted.
4989 (display_prop_intangible_p): Reimplement to call
4990 handle_display_spec instead of single_display_spec_intangible_p.
4991 Accept 3 additional arguments needed by handle_display_spec.
4992 This fixes incorrect cursor motion across display property with complex
4993 values: lists, `(when COND...)' forms, etc.
4994 (single_display_spec_string_p): Support property values that are
4995 lists with the argument STRING its top-level element.
4996 (display_prop_string_p): Fix the condition for processing a
4997 property that is a list to be consistent with handle_display_spec.
4998 (handle_display_spec): New function, refactored from the
4999 last portion of handle_display_prop.
5000 (compute_display_string_pos): Accept additional argument
5001 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5002 value of a `display' property is a "replacing spec".
5003 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5004 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5005 the display property, but just return a value indicating whether
5006 the display property will replace the characters it covers.
5007 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5008 frame_window_p members of struct bidi_it.
5009 (compute_display_string_pos, compute_display_string_end):
5011 (push_it): Accept second argument POSITION, where pop_it should
5012 jump to continue iteration.
5013 (reseat_1): Initialize bidi_it.disp_pos.
5015 * keyboard.c (adjust_point_for_property): Adjust the call to
5016 display_prop_intangible_p to its new signature.
5018 * dispextern.h (struct bidi_it): New member frame_window_p.
5019 (bidi_init_it): Update prototypes.
5020 (display_prop_intangible_p): Update prototype.
5021 (compute_display_string_pos, compute_display_string_end):
5023 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5026 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5028 Malloc failure behavior now depends on size of allocation.
5029 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5030 * lisp.h: Change signatures accordingly.
5031 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5032 All callers changed. (Bug#8762)
5034 * gnutls.c: Use Emacs's memory allocators.
5035 Without this change, the gnutls library would invoke malloc etc.
5036 directly, which causes problems on non-SYNC_INPUT hosts, and which
5037 runs afoul of improving memory_full behavior. (Bug#8761)
5038 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5039 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5040 xfree instead of the default malloc, realloc, free.
5041 (Fgnutls_boot): No need to check for memory allocation failure,
5042 since xmalloc does that for us.
5044 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5045 * category.c (hash_get_category_set):
5046 * ccl.c (ccl_driver):
5047 * charset.c (Fdefine_charset_internal):
5048 * charset.h (struct charset.hash_index):
5049 * composite.c (get_composition_id, gstring_lookup_cache)
5050 (composition_gstring_put_cache):
5051 * composite.h (struct composition.hash_index):
5052 * dispextern.h (struct image.hash):
5053 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5054 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5055 (hashfn_equal, hashfn_user_defined, make_hash_table)
5056 (maybe_resize_hash_table, hash_lookup, hash_put)
5057 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5058 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5059 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5060 * image.c (make_image, search_image_cache, lookup_image)
5061 (xpm_put_color_table_h):
5062 * lisp.h (struct Lisp_Hash_Table):
5063 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5064 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5065 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5066 * alloc.c (allocate_vectorlike):
5067 Check for overflow in vector size calculations.
5068 * ccl.c (ccl_driver):
5069 Check for overflow when converting EMACS_INT to int.
5070 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5071 need to be updated by these changes.
5072 * fns.c (make_hash_table, maybe_resize_hash_table):
5073 Check for integer overflow with large hash tables.
5074 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5075 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5076 (SXHASH_REDUCE): New macro.
5077 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5078 Use it instead of discarding useful hash info with large hash values.
5079 (sxhash_float): New function.
5080 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5081 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5082 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5083 Rewrite to use FIXNUM_BITS, as this simplifies things.
5084 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5085 Adjust signatures to match updated version of code.
5086 (consing_since_gc): Now EMACS_INT, since a single hash table can
5087 use more than INT_MAX bytes.
5089 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5091 Make it possible to build with GCC-4.6+ -O2 -flto.
5093 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5095 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5097 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5098 Call minibuffer-inactive-mode.
5100 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5102 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5103 Update dependencies.
5105 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5107 * data.c (init_data): Remove code for UTS, this system is not
5110 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5112 Don't force ./temacs to start in terminal mode.
5114 * frame.c (make_initial_frame): Initialize faces in all cases, not
5115 only when CANNOT_DUMP is defined.
5116 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5118 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5120 * dispnew.c (add_window_display_history): Use const for the string
5121 pointer. Remove declaration, not needed.
5123 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5125 Use 'inline', not 'INLINE'.
5126 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5127 * alloc.c, fontset.c (INLINE): Remove.
5128 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5129 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5130 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5131 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5132 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5134 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5136 Make it possible to run ./temacs.
5138 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5139 syms_of_callproc does the same thing. Remove test for
5140 "initialized", do it in the caller.
5141 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5143 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5145 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5146 (read_minibuf): Use get_minibuffer.
5147 (syms_of_minibuf): Use DEFSYM.
5148 (Qmetadata): New var.
5149 * data.c (Qbuffer): Don't make it static.
5150 (syms_of_data): Use DEFSYM.
5152 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5154 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5155 (CCL_CODE_MIN): New macro.
5157 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5159 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5161 * eval.c (Qdebug): Now static.
5162 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5163 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5164 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5166 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5168 * image.c: Various fixes to ImageMagick code comments.
5169 (Fimagemagick_types): Doc fix.
5171 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5173 Minor fixes prompted by GCC 4.6.0 warnings.
5175 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5177 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5178 (x_clipboard_manager_save_all): Move extern decl to ...
5179 * xterm.h: ... here, so that it can be checked for consistency.
5181 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5183 * xselect.c (x_clipboard_manager_save_frame)
5184 (x_clipboard_manager_save_all): New functions.
5185 (Fx_clipboard_manager_save): Lisp function deleted.
5187 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5188 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5190 * xterm.h: Update prototype.
5192 2011-05-28 William Xu <william.xwl@gmail.com>
5194 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5197 2011-05-28 Jim Meyering <meyering@redhat.com>
5199 Avoid a sign-extension bug in crypto_hash_function.
5200 * fns.c (to_uchar): Define.
5201 (crypto_hash_function): Use it to convert some newly-signed
5202 variables to unsigned, to avoid sign-extension bugs. For example,
5203 without this change, (md5 "truc") would evaluate to
5204 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5205 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5206 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5208 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5210 Integer overflow fixes.
5212 * dbusbind.c: Serial number integer overflow fixes.
5213 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5214 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5215 to hold a serial number that is too large for a fixnum.
5216 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5217 Check for serial numbers out of range. Decode any serial number
5218 that was so large that it became a float. (Bug#8722)
5220 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5221 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5222 Use XFASTINT rather than XUINT when numbers are nonnegative.
5223 (xd_append_arg, Fdbus_method_return_internal):
5224 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5225 arguments, check that Lisp number is nonnegative, rather than
5226 silently wrapping negative numbers around. (Bug#8722)
5227 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5230 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5232 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5234 ccl: add integer overflow checks
5235 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5236 (IN_INT_RANGE): New macros.
5237 (ccl_driver): Use them to check for integer overflow when
5238 decoding a CCL program. Many of the new checks are whether XINT (x)
5239 fits in int; it doesn't always, on 64-bit hosts. The new version
5240 doesn't catch all possible integer overflows, but it's an
5241 improvement. (Bug#8719)
5243 * alloc.c (make_event_array): Use XINT, not XUINT.
5244 There's no need for unsigned here.
5246 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5247 This follows up to the 2011-05-06 change that substituted uintptr_t
5248 for EMACS_INT. This case wasn't caught back then.
5250 Rework Fformat to avoid integer overflow issues.
5251 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5252 now (part of C89). Include <verify.h>.
5253 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5254 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5255 (Fformat): Avoid the prepass trying to compute sizes; it was only
5256 approximate and thus did not catch overflow reliably. Instead, walk
5257 through the format just once, formatting and computing sizes as we go,
5258 checking for integer overflow at every step, and allocating a larger
5259 buffer as needed. Keep track separately whether the format is
5260 multibyte. Keep only the most-recently calculated precision, rather
5261 than them all. Record whether each argument has been converted to
5262 string. Use EMACS_INT, not int, for byte and char and arg counts.
5263 Support field widths and precisions larger than INT_MAX. Avoid
5264 sprintf's undefined behavior with conversion specifications such as %#d
5265 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5266 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5267 formatting out-of-range floating point numbers with int
5270 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5272 * data.c: Avoid integer truncation in expressions involving floats.
5273 * data.c: Include <intprops.h>.
5274 (arith_driver): When there's an integer overflow in an expression
5275 involving floating point, convert the integers to floating point
5276 so that the resulting value does not suffer from catastrophic
5277 integer truncation. For example, on a 64-bit host (* 4
5278 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5279 Do not rely on undefined behavior after integer overflow.
5281 merge count_size_as_multibyte, parse_str_to_multibyte
5282 * character.c, character.h (count_size_as_multibyte):
5283 Rename from parse_str_to_multibyte; all uses changed.
5284 Check for integer overflow.
5285 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5286 since it's now a duplicate of the other. This is more of
5287 a character than a buffer op, so better that it's in character.c.
5288 * fns.c, print.c: Adjust to above changes.
5290 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5292 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5294 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5296 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5297 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5298 (x_clipboard_manager_save): Now static.
5299 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5301 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5302 (crypto_hash_function): Now static.
5303 Fix pointer signedness problems. Avoid unnecessary initializations.
5305 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5307 * termhooks.h (Vselection_alist): Make it terminal-local.
5309 * terminal.c (create_terminal): Initialize it.
5311 * xselect.c: Support for clipboard managers.
5312 (Vselection_alist): Move to termhooks.h as terminal-local var.
5313 (LOCAL_SELECTION): New macro.
5314 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5315 (symbol_to_x_atom): Remove gratuitous arg.
5316 (x_handle_selection_request, lisp_data_to_selection_data)
5317 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5318 (x_own_selection, x_get_local_selection, x_convert_selection):
5319 New arg, specifying work frame. Use terminal-local Vselection_alist.
5320 (some_frame_on_display): Delete unused function.
5321 (Fx_own_selection_internal, Fx_get_selection_internal)
5322 (Fx_disown_selection_internal, Fx_selection_owner_p)
5323 (Fx_selection_exists_p): New optional frame arg.
5324 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5325 (x_handle_selection_clear): Don't treat other terminals with the
5326 same keyboard specially. Use the terminal-local Vselection_alist.
5327 (x_clear_frame_selections): Use Frun_hook_with_args.
5329 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5331 * xterm.h: Add support for those atoms.
5333 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5335 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5336 (converted_selections, conversion_fail_tag): New global variables.
5337 (x_selection_request_lisp_error): Free the above.
5338 (x_get_local_selection): Remove unnecessary code.
5339 (x_reply_selection_request): Args changed; handle arbitrary array
5340 of converted selections stored in converted_selections.
5341 Separate the XChangeProperty and SelectionNotify steps.
5342 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5343 (x_convert_selection): New function.
5344 (x_handle_selection_event): Simplify.
5345 (x_get_foreign_selection): Don't ignore incoming requests while
5346 waiting for an answer; this will fail when we implement
5347 SAVE_TARGETS, and seems unnecessary anyway.
5348 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5349 (Vx_sent_selection_functions): Doc fix.
5351 2011-05-26 Leo Liu <sdl.web@gmail.com>
5353 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5355 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5357 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5359 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5360 for fringe update if it has periodic bitmap.
5361 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5362 and fringe_bitmap_periodic_p.
5364 * fringe.c (get_fringe_bitmap_data): New function.
5365 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5366 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5367 row. Mark glyph row for fringe update if periodicity changed.
5369 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5370 for fringe update unless it has periodic bitmap.
5372 2011-05-25 Kenichi Handa <handa@m17n.org>
5374 * xdisp.c (get_next_display_element): Set correct it->face_id for
5375 a static composition.
5377 2011-05-24 Leo Liu <sdl.web@gmail.com>
5380 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5382 * fns.c (crypto_hash_function, Fsha1): New function.
5383 (Fmd5): Use crypto_hash_function.
5384 (syms_of_fns): Add Ssha1.
5386 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5388 * gnutls.c: Remove unused macros.
5389 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5390 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5391 Remove macros that are defined and never used.
5392 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5394 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5396 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5397 (Fx_get_selection_internal): Minor cleanup.
5398 (Fx_own_selection_internal): Rename arguments for consistency with
5401 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5403 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5405 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5407 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5409 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5411 * dispnew.c (scrolling_window): Don't exclude the case that the
5412 last enabled row in the desired matrix touches the bottom boundary.
5414 2011-05-21 Glenn Morris <rgm@gnu.org>
5416 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5417 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5418 and add some more files.
5420 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5422 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5423 report_file_error introduced by the change from 2011-05-07.
5425 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5427 * systime.h (Time): Define only if emacs is defined.
5428 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5429 where the include path doesn't have X11/X.h by default. See
5430 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5432 2011-05-20 Kenichi Handa <handa@m17n.org>
5434 * composite.c (find_automatic_composition): Fix previous change.
5436 2011-05-20 Glenn Morris <rgm@gnu.org>
5438 * lisp.mk: New file, split from Makefile.in.
5439 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5440 (shortlisp): Remove.
5441 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5443 2011-05-19 Glenn Morris <rgm@gnu.org>
5445 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5446 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5447 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5448 (lisp): Set the order to that of loadup.el.
5449 (shortlisp): Make it a copy of $lisp.
5450 (SOME_MACHINE_LISP): Remove.
5451 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5452 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5454 2011-05-18 Kenichi Handa <handa@m17n.org>
5456 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5457 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5458 (find_automatic_composition): Mostly rewrite for efficiency.
5460 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5462 * makefile.w32-in: Update dependencies.
5464 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5466 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5467 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5469 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5471 Fix some integer overflow issues, such as string length overflow.
5473 * insdel.c (count_size_as_multibyte): Check for string overflow.
5475 * character.c (lisp_string_width): Check for string overflow.
5476 Use EMACS_INT, not int, for string indexes and lengths; in
5477 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5478 the resulting string length overflows an EMACS_INT; instead,
5479 report a string overflow if no precision given. When checking for
5480 precision exhaustion, use a check that cannot possibly have
5481 integer overflow. (Bug#8675)
5482 * character.h (lisp_string_width): Adjust to new signature.
5484 * alloc.c (string_overflow): New function.
5485 (Fmake_string): Use it. This doesn't change behavior, but saves
5486 a few bytes and will simplify future changes.
5487 * character.c (string_escape_byte8): Likewise.
5488 * lisp.h (string_overflow): New decl.
5490 Fixups, following up to the user-interface timestamp change.
5491 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5492 for UI timestamps, instead of unsigned long.
5493 * msdos.c (mouse_get_pos): Likewise.
5494 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5495 * w32gui.h (Time): Define by including "systime.h" rather than by
5496 declaring it ourselves. (Bug#8664)
5498 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5499 * image.c (clear_image_cache): Likewise.
5501 * term.c (term_mouse_position): Don't assume time_t wraparound.
5503 Be more systematic about user-interface timestamps.
5504 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5505 and sometimes 'EMACS_UINT', to represent these timestamps.
5506 This change causes it to use 'Time' uniformly, as that's what X uses.
5507 This makes the code easier to follow, and makes it easier to catch
5508 integer overflow bugs such as Bug#8664.
5509 * frame.c (Fmouse_position, Fmouse_pixel_position):
5510 Use Time, not unsigned long, for user-interface timestamps.
5511 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5512 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5513 * keyboard.h (last_event_timestamp): Likewise.
5514 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5515 * menu.h (xmenu_show): Likewise.
5516 * term.c (term_mouse_position): Likewise.
5517 * termhooks.h (struct input_event.timestamp): Likewise.
5518 (struct terminal.mouse_position_hook): Likewise.
5519 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5520 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5521 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5522 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5524 * menu.h, termhooks.h: Include "systime.h", for Time.
5526 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5527 Don't assume that the difference between two unsigned long values
5528 can fit into an integer. At this point, we know button_down_time
5529 <= event->timestamp, so the difference must be nonnegative, so
5530 there's no need to cast the result if double-click-time is
5531 nonnegative, as it should be; check that it's nonnegative, just in
5532 case. This bug is triggered when events are more than 2**31 ms
5533 apart (about 25 days). (Bug#8664)
5535 * xselect.c (last_event_timestamp): Remove duplicate decl.
5536 (x_own_selection): Remove needless cast to unsigned long.
5538 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5539 that always fit in int. Use a sentinel instead of a counter, to
5540 avoid a temp and to allay GCC's concerns about possible int overflow.
5541 * frame.h (struct frame): Use int for menu_bar_items_used
5542 instead of EMACS_INT, since it always fits in int.
5544 * menu.c (grow_menu_items): Check for int overflow.
5546 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5548 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5549 Before, the code was not consistent. These values cannot exceed
5550 2**31 - 1 so there's no need to make them unsigned.
5551 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5552 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5553 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5555 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5557 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5558 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5559 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5560 presumably because the widths might not match.
5562 * window.c (size_window): Avoid needless test at loop start.
5564 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5566 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5568 2011-05-12 Drew Adams <drew.adams@oracle.com>
5570 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5572 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5574 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5575 `width' to `bar_area_x' and `bar_area_width', respectively.
5576 (x_scroll_run): Take account of fringe background extension.
5578 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5579 Rename local vars `left' and `width' to `bar_area_x' and
5580 `bar_area_width', respectively.
5581 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5582 background extension.
5584 2011-05-10 Jim Meyering <meyering@redhat.com>
5586 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5588 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5590 * image.c (Finit_image_library): Return t for built-in image types,
5591 like pbm and xbm. (Bug#8640)
5593 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5595 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5597 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5599 * w32console.c (Fset_screen_color): Doc fix.
5600 (Fget_screen_color): New function.
5601 (syms_of_ntterm): Defsubr it.
5603 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5604 unlink the temporary file if Fcall_process didn't create it in the
5606 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5607 child process will be redirected to a file specified with `:file'.
5608 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5609 cue to call_process_cleanup not to close that handle.
5611 2011-05-07 Ben Key <bkey76@gmail.com>
5613 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5614 one of two shell specific rules, either bootstrap-temacs-CMD or
5615 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5616 to the previous implementation of the bootstrap-temacs rule.
5617 The bootstrap-temacs-CMD rule is similar to the previous
5618 implementation of the bootstrap-temacs rule except that it
5619 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5622 These changes, along with some changes to nt/configure.bat,
5623 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5624 earlier fix to add support for --cflags and --ldflags options
5625 that include quotes so that it works whether make uses cmd or
5628 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5630 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5631 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5633 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5634 a string. Handle both cases.
5635 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5636 (Fdbus_register_method): Use Qinvalid_function.
5638 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5640 * makefile.w32-in: Update dependencies.
5641 (LISP_H): Add inttypes.h and stdin.h.
5642 (PROCESS_H): Add unistd.h.
5644 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5646 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5647 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5649 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5651 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5653 * term.c (vfatal): Remove stray call to va_end.
5654 It's not needed and the C Standard doesn't allow it here anyway.
5656 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5657 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5659 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5662 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5664 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5666 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5668 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5670 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5672 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5673 * charset.c (Fdefine_charset_internal): Don't initialize
5674 charset.code_space[15]. The value was garbage, on hosts with
5675 32-bit int (Bug#8600).
5677 * lread.c (read_integer): Be more consistent with string-to-number.
5678 Use string_to_number to do the actual conversion; this avoids
5679 rounding errors and fixes some other screwups. Without this fix,
5680 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5681 (digit_to_number): Move earlier, for benefit of read_integer.
5682 Return -1 if the digit is out of range for the base, -2 if it is
5683 not a digit in any supported base. (Bug#8602)
5685 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5687 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5688 to match comment at start of function. This also removes a
5689 GCC warning about overflow in a 32+64-bit port.
5691 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5693 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5694 Reported by Stefan Monnier in
5695 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5696 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5697 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5699 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5700 (EMACS_UINTPTR): Likewise, with uintptr_t.
5702 * lisp.h: Prefer 64-bit EMACS_INT if available.
5703 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5704 on 32-bit hosts that have 64-bit int, so that they can access
5706 However, temporarily disable this change unless the temporary
5707 symbol WIDE_EMACS_INT is defined.
5709 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5711 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5712 This removes an assumption that EMACS_INT and long are the same
5713 width as pointers. The assumption is true for Emacs porting targets
5714 now, but we want to make other targets possible.
5715 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5716 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5717 In the rest of the code, change types of integers that hold casted
5718 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5719 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5720 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5721 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5722 No need to cast type when ORing.
5723 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5724 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5725 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5726 assume EMACS_INT is the same width as char *.
5727 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5728 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5729 Remove no-longer-needed casts.
5730 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5731 (xg_tool_bar_help_callback, xg_make_tool_item):
5732 Use EMACS_INTPTR to hold an integer
5733 that will be cast to void *; this can avoid a GCC warning
5734 if EMACS_INT is not the same width as void *.
5735 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5736 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5737 (current_message_1, set_message_1):
5738 Use a local to convert to proper width without a cast.
5739 * xmenu.c (dialog_selection_callback): Likewise.
5741 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5742 Also, don't assume VALBITS / RAND_BITS is less than 5,
5743 and don't rely on undefined behavior when shifting a 1 left into
5745 * lisp.h (get_random): Change signature to match.
5747 * lread.c (hash_string): Use size_t, not int, for hash computation.
5748 Normally we prefer signed values; but hashing is special, because
5749 it's better to use unsigned division on hash table sizes so that
5750 the remainder is nonnegative. Also, size_t is the natural width
5751 for hashing into memory. The previous code used 'int', which doesn't
5752 retain enough info to hash well into very large tables.
5753 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5755 * dbusbind.c: Don't possibly lose pointer info when converting.
5756 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5757 Use XPNTR rather than XHASH, so that the high-order bits of
5758 the pointer aren't lost when converting through void *.
5760 * eval.c (Fautoload): Don't double-shift a pointer.
5762 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5764 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5766 * gnutls.c (DEF_GNUTLS_FN):
5767 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5769 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5771 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5774 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5776 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5777 New version that can reserve upto 2GB of heap space.
5779 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5781 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5783 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5785 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5786 `gnutls_certificate_set_x509_key_file'.
5788 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5790 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5791 Update dependencies.
5793 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5795 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5796 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5797 Remove unused parameter `fildes'.
5798 * process.c (read_process_output, send_process): Don't pass it.
5800 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5802 Fix previous change: the library cache is defined in w32.c.
5803 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5804 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5806 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5808 Implement dynamic loading of GnuTLS on Windows.
5810 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5811 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5812 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5815 * gnutls.c (Qgnutls_dll): Define.
5816 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5817 (gnutls_*): Declare function pointers.
5818 (init_gnutls_functions): New function to initialize function pointers.
5819 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5820 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5821 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5822 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5823 (emacs_gnutls_write, emacs_gnutls_read)
5824 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5825 (Fgnutls_available_p): New function.
5826 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5827 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5828 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5830 * image.c: Include w32.h.
5831 (Vimage_type_cache): Delete.
5832 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5833 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5834 (w32_delayed_load): Move to w32.c.
5836 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5838 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5839 (w32_delayed_load): Move from image.c. When loading a library, record
5840 its filename in the :loaded-from property of the library id.
5841 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5842 Initialize and staticpro them.
5843 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5845 * process.c: Include lisp.h before w32.h, not after.
5846 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5847 instead of gnutls_record_check_pending.
5849 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5851 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5853 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5854 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5857 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5859 * xterm.c (x_set_frame_alpha): Do not set property on anything
5860 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5862 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5864 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5866 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5868 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5869 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5870 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5871 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5872 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5873 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5874 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5875 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5876 (Qgnutls_bootprop_callbacks_verify): Make static.
5878 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5880 * callproc.c: Indentation fixup.
5882 * sysdep.c (wait_for_termination_1): Make static.
5883 (wait_for_termination, interruptible_wait_for_termination):
5884 Move after wait_for_termination_1.
5886 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5888 * sysdep.c (interruptible_wait_for_termination): New function
5889 which is like wait_for_termination, but allows keyboard
5892 * callproc.c (Fcall_process): Add (:file "file") as an option for
5894 (Fcall_process_region): Ditto.
5896 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5898 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5899 rather than `XVECTOR (FOO)->size'.
5901 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5902 inttypes.h, as a gnulib replacement is used if it not available in
5905 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5907 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5908 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5909 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5911 * coding.c (coding_alloc_by_realloc): Error out if destination
5912 will grow beyond MOST_POSITIVE_FIXNUM.
5913 (decode_coding_emacs_mule): Abort if there isn't enough place in
5914 charbuf for the composition carryover bytes. Reserve an extra
5915 space for up to 2 characters produced in a loop.
5916 (decode_coding_iso_2022): Abort if there isn't enough place in
5917 charbuf for the composition carryover bytes.
5919 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5921 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5922 aborting when %lld or %lll format is passed.
5923 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5924 %llo or %llx format is passed. (Bug#8545)
5926 * window.c (window_scroll_line_based): Use a marker instead of
5927 simple variables to record original value of point. (Bug#7952)
5929 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5930 produced by %s or %c overflows available buffer space. (Bug#8545)
5932 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5934 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5935 (SIZE_MAX): Move defn after all includes, as they might #define it.
5937 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5939 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5941 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5943 * keyboard.c (Qdelayed_warnings_hook): Define.
5944 (command_loop_1): Run `delayed-warnings-hook'
5945 if Vdelayed_warnings_list is non-nil.
5946 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5947 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5949 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5951 * doprnt.c (doprnt): Don't return value smaller than the buffer
5952 size if the message was truncated. (Bug#8545).
5954 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5956 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5957 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5959 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5961 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5963 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5965 * makefile.w32-in: Update dependencies.
5967 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5969 Improve `doprnt' and its usage. (Bug#8545)
5970 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5971 `format_end'. Remove support for %l as a conversion specifier.
5972 Don't use xrealloc. Improve diagnostics when the %l size modifier
5973 is used. Update the commentary.
5975 * eval.c (verror): Simplify calculation of size_t.
5977 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5980 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5982 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5985 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5987 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5988 This makes this file independent of the recent pseudovector change.
5990 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5992 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5994 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5995 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5996 Remove unused local.
5997 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5999 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6000 GCC 4.6.0 optimizes based on type-based alias analysis.
6001 For example, if b is of type struct buffer * and v of type struct
6002 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6003 != &v->size, and therefore "v->size = 1; b->size = 2; return
6004 v->size;" must therefore return 1. This assumption is incorrect
6005 for Emacs, since it type-puns struct Lisp_Vector * with many other
6006 types. To fix this problem, this patch adds a new type struct
6007 vectorlike_header that documents the constraints on layout of vectors
6008 and pseudovectors, and helps optimizing compilers not get fooled
6009 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6010 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6011 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6013 (XSETPVECTYPE): Rewrite in terms of new macro.
6014 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6015 This is a bit clearer, and further avoids the possibility of
6016 undesirable aliasing.
6017 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6018 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6019 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6020 since Lisp_Subr is a special case (no "next" field).
6021 (ASIZE): Now uses header.size rather than size.
6022 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6023 to avoid the hassle of writing XVECTOR (foo)->header.size.
6024 (struct vectorlike_header): New type.
6025 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6026 object, to help avoid aliasing.
6027 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6028 (SUBRP): Likewise, since Lisp_Subr is a special case.
6029 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6030 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6031 (struct Lisp_Hash_Table): Combine first two members into a single
6032 struct vectorlike_header member. All uses of "size" and "next" members
6033 changed to be "header.size" and "header.next".
6034 * buffer.h (struct buffer): Likewise.
6035 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6036 * frame.h (struct frame): Likewise.
6037 * process.h (struct Lisp_Process): Likewise.
6038 * termhooks.h (struct terminal): Likewise.
6039 * window.c (struct save_window_data, struct saved_window): Likewise.
6040 * window.h (struct window): Likewise.
6041 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6042 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6043 * buffer.c (init_buffer_once): Likewise.
6044 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6046 * process.c (Fformat_network_address): Use local var for size,
6049 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6051 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6052 * data.c (atof): Remove decl; no longer used or needed.
6053 (digit_to_number): Move to lread.c.
6054 (Fstring_to_number): Use new string_to_number function, to be
6055 consistent with how the Lisp reader treats infinities and NaNs.
6056 Do not assume that floating-point numbers represent EMACS_INT
6057 without losing information; this is not true on most 64-bit hosts.
6058 Avoid double-rounding errors, by insisting on integers when
6059 parsing non-base-10 numbers, as the documentation specifies.
6060 * lisp.h (string_to_number): New decl, replacing ...
6061 (isfloat_string): Remove.
6062 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6063 (read1): Do not accept +. and -. as integers; this
6064 appears to have been a coding error. Similarly, do not accept
6065 strings like +-1e0 as floating point numbers. Do not report
6066 overflow for integer overflows unless the base is not 10 which
6067 means we have no simple and reliable way to continue.
6068 Break out the floating-point parsing into a new
6069 function string_to_number, so that Fstring_to_number parses
6070 floating point numbers consistently with the Lisp reader.
6071 (digit_to_number): Move here from data.c. Make it static inline.
6072 (E_CHAR, EXP_INT): Remove, replacing with ...
6073 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6074 (string_to_number): New function, replacing isfloat_string.
6075 This function checks for valid syntax and produces the resulting
6076 Lisp float number too. Rework it so that string-to-number
6077 no longer mishandles examples like "1.0e+". Use strtoumax,
6078 so that overflow for non-base-10 numbers is reported only when
6079 there's no portable and simple way to convert to floating point.
6081 * textprop.c (set_text_properties_1): Rewrite for clarity,
6082 and to avoid GCC warning about integer overflow.
6084 * intervals.h (struct interval): Use EMACS_INT for members
6085 where EMACS_UINT might cause problems. See
6086 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6087 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6088 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6090 (offset_intervals): Tell GCC not to worry about length overflow
6091 when negating a negative length.
6093 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6094 (overrun_check_free): Likewise.
6096 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6097 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6100 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6101 (gnutls_make_error): Rename local to avoid shadowing.
6102 (gnutls_emacs_global_deinit): ifdef out; not used.
6103 (Fgnutls_boot): Use const for pointer to readonly storage.
6104 Comment out unused local. Fix pointer signedness problems.
6106 * lread.c (openp): Don't stuff size_t into an 'int'.
6107 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6108 about possible signed overflow.
6110 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6111 (GDK_KEY_g): Don't define if already defined.
6112 (xg_prepare_tooltip): Avoid pointer signedness problem.
6113 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6115 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6116 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6118 * xfns.c (Fx_window_property): Simplify a bit,
6119 to make a bit faster and to avoid GCC 4.6.0 warning.
6120 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6122 * fns.c (internal_equal): Don't assume size_t fits in int.
6124 * alloc.c (compact_small_strings): Tighten assertion a little.
6126 Replace pEd with more-general pI, and fix some printf arg casts.
6127 * lisp.h (pI): New macro, generalizing old pEd macro to other
6128 conversion specifiers. For example, use "...%"pI"d..." rather
6129 than "...%"pEd"...".
6130 (pEd): Remove. All uses replaced with similar uses of pI.
6131 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6132 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6133 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6134 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6135 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6136 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6137 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6139 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6140 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6141 * print.c (safe_debug_print, print_object): Likewise.
6142 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6144 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6145 avoiding the 0 flag, which is not portable.
6146 * process.c (Fmake_network_process): Use pI to avoid cast.
6147 * region-cache.c (pp_cache): Likewise.
6148 * xdisp.c (decode_mode_spec): Likewise.
6149 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6150 behavior on 64-bit hosts with printf arg.
6151 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6152 (x_stop_queuing_selection_requests): Likewise.
6153 (x_get_window_property): Don't truncate byte count to an 'int'
6156 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6157 here, since it parses constructs like leading '-' and spaces,
6158 which are not wanted; and it overflows with large numbers.
6159 Instead, simply match F[0-9]+, which is what is wanted anyway.
6161 * alloc.c: Remove unportable assumptions about struct layout.
6162 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6163 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6164 (allocate_vectorlike, make_pure_vector): Use the new macros,
6165 plus offsetof, to remove unportable assumptions about struct layout.
6166 These assumptions hold on all porting targets that I know of, but
6167 they are not guaranteed, they're easy to remove, and removing them
6168 makes further changes easier.
6170 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6171 This doesn't fix a bug but makes the code clearer.
6172 (string_overrun_cookie): Now const. Use initializers that
6173 don't formally overflow signed char, to avoid warnings.
6174 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6175 can cause Emacs to crash when string overrun checking is enabled.
6176 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6177 multiple of sizeof (EMACS_INT); it need not be, if
6178 alignof(EMACS_INT) < sizeof (EMACS_INT).
6179 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6181 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6183 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6185 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6187 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6188 supposed to be handshaking. (Bug#8556)
6189 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6191 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6193 * lisp.h (Qdebug): List symbol.
6194 * eval.c (Qdebug): Restore global linkage.
6195 * keyboard.c (debug-on-event): New variable.
6196 (handle_user_signal): Break into debugger when debug-on-event
6197 matches the current signal symbol.
6199 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6201 * alloc.c (check_sblock, check_string_bytes)
6202 (check_string_free_list): Convert to standard C.
6204 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6206 * w32.c (emacs_gnutls_push): Fix typo.
6208 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6210 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6211 "cast to pointer from integer of different size".
6213 Improve doprnt and its use in verror. (Bug#8545)
6214 * doprnt.c (doprnt): Document the set of format control sequences
6215 supported by the function. Use SAFE_ALLOCA instead of always
6218 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6219 is one byte too soon. Don't use xrealloc; instead xfree and
6222 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6224 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6227 * gnutls.c: Renamed global_initialized to
6228 gnutls_global_initialized. Added internals for the
6229 :verify-hostname-error, :verify-error, and :verify-flags
6230 parameters of `gnutls-boot' and documented those parameters in the
6231 docstring. Start callback support.
6232 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6233 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6234 on error. Return error code.
6235 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6236 (emacs_gnutls_read): Likewise.
6237 (Fgnutls_boot): Return handshake error code.
6238 (emacs_gnutls_handle_error): New function.
6239 (wsaerror_to_errno): Likewise.
6241 * w32.h (emacs_gnutls_pull): Add prototype.
6242 (emacs_gnutls_push): Likewise.
6244 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6245 (emacs_gnutls_push): Likewise.
6247 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6249 * process.c (wait_reading_process_output): Check if GnuTLS
6250 buffered some data internally if no FDs are set for TLS
6253 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6254 (LIBS): Link to USER_LIBS.
6255 ($(BLD)/gnutls.$(0)): New target.
6257 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6259 * xdisp.c (handle_single_display_spec): Rename the
6260 display_replaced_before_p argument into display_replaced_p, to
6261 make it consistent with the commentary. Fix typos in the
6264 * textprop.c (syms_of_textprop): Remove dead code.
6265 (copy_text_properties): Delete obsolete commentary about an
6266 interface that was deleted long ago. Fix typos in the description
6269 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6270 to changes in oldXMenu/XMenu.h from 2011-04-16.
6271 <menu_help_message, prev_menu_help_message>: Constify.
6272 (IT_menu_make_room): menu->help_text is now `const char **';
6275 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6276 to changes in oldXMenu/XMenu.h from 2011-04-16.
6277 (struct XMenu): Declare `help_text' `const char **'.
6279 * xfaces.c <Qunspecified>: Make extern again.
6281 * syntax.c: Include sys/types.h before including regex.h, as
6284 * doc.c (get_doc_string): Improve the format passed to `error'.
6286 * doprnt.c (doprnt): Improve commentary.
6288 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6290 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6293 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6294 changes in globals.h immediately force recompilation.
6295 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6296 $(CURDIR)/s/ms-w32.h.
6297 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6299 * character.c (Fchar_direction): Function deleted.
6300 (syms_of_character): Don't defsubr it.
6301 <char-direction-table>: Deleted.
6303 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6305 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6306 * doprnt.c: Include limits.h.
6307 (SIZE_MAX): New macro.
6308 (doprnt): Return a size_t value. 2nd arg is now size_t.
6309 Many local variables are now size_t instead of int or unsigned.
6310 Improve overflow protection. Support `l' modifier for integer
6311 conversions. Support %l conversion. Don't assume an EMACS_INT
6312 argument for integer conversions and for %c.
6314 * lisp.h (doprnt): Restore prototype.
6316 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6319 * Makefile.in (base_obj): Add back doprnt.o.
6321 * deps.mk (doprnt.o): Add back prerequisites.
6322 (callint.o): Depend on character.h.
6324 * eval.c (internal_lisp_condition_case): Include the handler
6325 representation in the error message.
6326 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6327 when breaking from the loop.
6329 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6331 * callint.c (Fcall_interactively): When displaying error message
6332 about invalid control letter, pass the character's codepoint, not
6333 a pointer to its multibyte form. Improve display of the character
6334 in octal and display also its hex code.
6336 * character.c (char_string): Use %x to display the (unsigned)
6337 codepoint of an invalid character, to avoid displaying a bogus
6340 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6341 `error', not SYMBOL_NAME itself.
6343 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6344 character arguments to `error'.
6346 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6347 to `error' in error message about FINAL_CHAR argument. Make sure
6348 FINAL_CHAR is a character, and use %c when it is passed as
6349 argument to `error'.
6351 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6353 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6355 * w32.c: Include <time.h>.
6356 (sys_localtime): New function.
6358 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6360 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6362 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6364 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6366 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6369 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6371 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6372 gl_state.e_property when gl_state.object is Qt.
6374 * insdel.c (make_gap_larger): Remove limitation of buffer size
6377 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6379 * xdisp.c (lookup_glyphless_char_display)
6380 (produce_glyphless_glyph): Handle cons cell entry in
6381 glyphless-char-display.
6382 (Vglyphless_char_display): Document it.
6384 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6385 glyphless-char-display.
6387 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6389 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6391 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6393 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6394 definition for no-X builds.
6396 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6398 Static checks with GCC 4.6.0 and non-default toolkits.
6400 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6402 * process.c (keyboard_bit_set): Define only if SIGIO.
6403 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6404 (send_process): Repair possible setjmp clobbering.
6406 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6408 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6410 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6412 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6413 Define only if needed.
6415 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6416 by pacifying GCC about it. Maybe it's time to retire it?
6417 * xfaces.c (USG, __TIMEVAL__): Likewise.
6419 * dispextern.h (struct redisplay_interface): Rename param
6421 * termhooks.h (struct terminal): Likewise.
6422 * xterm.c (xembed_send_message): Likewise.
6424 * insdel.c (make_gap_smaller): Define only if
6425 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6427 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6430 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6431 so that we aren't warned about unused symbols.
6433 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6435 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6437 * xfns.c (x_real_positions): Mark locals as initialized.
6439 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6441 * xterm.c: Fix problems found by static analysis with other toolkits.
6442 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6443 (x_dispatch_event): Declare static if USE_GTK, and
6444 define if USE_GTK || USE_X_TOOLKIT.
6445 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6446 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6447 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6448 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6450 * xmenu.c (menu_help_callback): Pointer type fixes.
6451 Use const pointers when pointing at readonly data. Avoid pointer
6453 (FALSE): Remove unused macro.
6454 (update_frame_menubar): Remove unused decl.
6456 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6458 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6459 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6460 (single_menu_item): Rename local to avoid shadowing.
6462 * keyboard.c (make_lispy_event): Remove unused local var.
6464 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6465 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6467 * bitmaps: Change bitmaps from unsigned char back to the X11
6468 compatible char. Avoid the old compiler warnings about
6469 out-of-range initializers by using, for example, '\xab' rather
6472 * xgselect.c (xgselect_initialize): Check vs interface
6473 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6475 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6477 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6478 to read-only memory.
6480 * fns.c (vector): Remove; this old hack is no longer needed.
6482 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6484 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6486 * xrdb.c (x_load_resources): Omit unused local.
6488 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6489 (x_window): Rename locals to avoid shadowing.
6490 (USG): Use the kludged USG macro, to pacify gcc.
6492 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6493 (x_term_init): Remove local to avoid shadowing.
6495 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6497 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6498 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6500 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6502 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6504 Fix regex.c, syntax.c and friends for buffers > 2GB.
6505 * syntax.h (struct gl_state_s): Declare character position members
6508 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6510 * textprop.c (verify_interval_modification, interval_of):
6511 Declare arguments EMACS_INT.
6513 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6516 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6518 * indent.c (Fvertical_motion): Local variable it_start is now
6521 * regex.c (re_match, re_match_2, re_match_2_internal)
6522 (bcmp_translate, regcomp, regexec, print_double_string)
6523 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6524 (re_compile_pattern, re_exec): Declare arguments and local
6525 variables `size_t' and `ssize_t' and return values `regoff_t', as
6527 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6528 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6529 <compile_stack_type>: `size' and `avail' are now `size_t'.
6531 * regex.h <regoff_t>: Use ssize_t, not int.
6532 (re_search, re_search_2, re_match, re_match_2): Arguments that
6533 specify buffer/string position and length are now ssize_t and
6534 size_t. Return type is regoff_t.
6536 2011-04-16 Ben Key <bkey76@gmail.com>
6538 * nsfont.m: Fixed bugs in ns_get_family and
6539 ns_descriptor_to_entity that were caused by using free to
6540 deallocate memory blocks that were allocated by xmalloc (via
6541 xstrdup). This caused Emacs to crash when compiled with
6542 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6543 --enable-checking=xmallocoverrun). xfree is now used to
6544 deallocate these memory blocks.
6546 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6548 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6550 emacs_write: Accept and return EMACS_INT for sizes.
6551 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6553 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6554 Accept and return EMACS_INT.
6555 (emacs_gnutls_write): Return the number of bytes written on
6557 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6558 (emacs_read, emacs_write): Remove check for negative size, as the
6559 Emacs source code has been audited now.
6560 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6561 (emacs_read, emacs_write): Use it.
6562 * process.c (send_process): Adjust to the new signatures of
6563 emacs_write and emacs_gnutls_write. Do not attempt to store
6564 a byte offset into an 'int'; it might overflow.
6565 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6567 * sound.c: Don't assume sizes fit in 'int'.
6568 (struct sound_device.period_size, alsa_period_size):
6569 Return EMACS_INT, not int.
6570 (struct sound_device.write, vox_write, alsa_write):
6571 Accept EMACS_INT, not int.
6572 (wav_play, au_play): Use EMACS_INT to store sizes and to
6573 record read return values.
6575 2011-04-15 Ben Key <bkey76@gmail.com>
6577 * keyboard.c (Qundefined): Don't declare static since it is used
6579 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6580 static since they are used in nsfont.m.
6582 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6584 * process.c (Qprocessp): Don't declare static.
6585 * lisp.h (Qprocessp): Declare again.
6587 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6589 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6591 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6593 Improve C-level modularity by making more things 'static'.
6595 Don't publish debugger-only interfaces to other modules.
6596 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6597 (verify_bytepos, count_markers): Move decls to the only modules
6599 * region-cache.h (pp_cache): Likewise.
6600 * window.h (check_all_windows): Likewise.
6601 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6603 * sysdep.c (croak): Now static, if
6604 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6605 * syssignal.h (croak): Declare only if not static.
6607 * alloc.c (refill_memory_reserve): Now static if
6608 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6609 * lisp.h (refill_memory_reserve): Declare only if not static.
6611 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6612 Define only if USE_LUCID.
6614 * xrdb.c (x_customization_string, x_rm_string): Now static.
6616 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6617 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6619 * xdisp.c (draw_row_with_mouse_face): Now static.
6620 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6622 * window.h (check_all_windows): Mark externally visible.
6624 * window.c (window_deletion_count): Now static.
6626 * undo.c: Make symbols static if they're not exported.
6627 (last_undo_buffer, last_boundary_position, pending_boundary):
6630 * textprop.c (interval_insert_behind_hooks): Now static.
6631 (interval_insert_in_front_hooks): Likewise.
6633 * term.c: Make symbols static if they're not exported.
6634 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6635 (max_frame_lines, tty_set_terminal_modes):
6636 (tty_reset_terminal_modes, tty_turn_off_highlight):
6637 (get_tty_terminal): Now static.
6638 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6639 * termhooks.h (term_mouse_moveto): Do not declare if
6641 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6642 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6644 * sysdep.c: Make symbols static if they're not exported.
6645 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6647 (sigprocmask_set, full_mask): Remove; unused.
6648 (wait_debugging): Mark as visible.
6649 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6650 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6652 * syntax.c (syntax_temp): Define only if !__GNUC__.
6654 * sound.c (current_sound_device, current_sound): Now static.
6656 * search.c (searchbufs, searchbuf_head): Now static.
6658 * scroll.c (scroll_cost): Remove; unused.
6659 * dispextern.h (scroll_cost): Remove decl.
6661 * region-cache.h (pp_cache): Mark as externally visible.
6663 * process.c: Make symbols static if they're not exported.
6664 (process_tick, update_tick, create_process, chan_process):
6665 (Vprocess_alist, proc_buffered_char, datagram_access):
6666 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6667 (deactivate_process): Mark defn as static, as well as decl.
6668 * lisp.h (create_process): Remove decl.
6669 * process.h (chan_process, Vprocess_alist): Remove decls.
6671 * print.c: Make symbols static if they're not exported.
6672 (print_depth, new_backquote_output, being_printed, print_buffer):
6673 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6674 (print_interval, print_number_index, initial_stderr_stream):
6676 * lisp.h (Fprinc): Remove decl.
6677 (debug_output_compilation_hack): Mark as externally visible.
6679 * sysdep.c (croak): Move decl from here to syssignal.h.
6680 * syssignal.h (croak): Put it here, so the API can be checked when
6681 'croak' is called from dissociate_if_controlling_tty.
6683 * minibuf.c: Make symbols static if they're not exported.
6684 (minibuf_save_list, choose_minibuf_frame): Now static.
6685 * lisp.h (choose_minibuf_frame): Remove decl.
6687 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6689 * lread.c: Make symbols static if they're not exported.
6690 (read_objects, initial_obarray, oblookup_last_bucket_number):
6692 (make_symbol): Remove; unused.
6693 * lisp.h (initial_obarray, make_symbol): Remove decls.
6695 * keyboard.c: Make symbols static if they're not exported.
6696 (single_kboard, recent_keys_index, total_keys, recent_keys):
6697 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6698 (this_single_command_key_start, echoing, last_auto_save):
6699 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6700 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6701 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6702 (Vlispy_mouse_stem, double_click_count):
6704 (force_auto_save_soon): Define only if SIGDANGER.
6705 (ignore_mouse_drag_p): Now static if
6706 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6707 (print_help): Remove; unused.
6708 (stop_character, last_timer_event): Mark as externally visible.
6709 * keyboard.h (ignore_mouse_drag_p): Declare only if
6710 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6711 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6712 * lisp.h (echoing): Remove decl.
6713 (force_auto_save_soon): Declare only if SIGDANGER.
6714 * xdisp.c (redisplay_window): Simplify code, to make it more
6715 obvious that ignore_mouse_drag_p is not accessed if !defined
6716 USE_GTK && !defined HAVE_NS.
6718 * intervals.c: Make symbols static if they're not exported.
6719 (merge_properties_sticky, merge_interval_right, delete_interval):
6721 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6723 * insdel.c: Make symbols static if they're not exported.
6724 However, leave prepare_to_modify_buffer alone. It's never
6725 called from outside this function, but that appears to be a bug.
6726 (combine_after_change_list, combine_after_change_buffer):
6727 (adjust_after_replace, signal_before_change): Now static.
6728 (adjust_after_replace_noundo): Remove; unused.
6729 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6730 (signal_before_change): Remove decls.
6732 * indent.c (val_compute_motion, val_vmotion): Now static.
6734 * image.c: Make symbols static if they're not exported.
6735 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6737 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6738 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6740 * fringe.c (standard_bitmaps): Now static.
6741 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6743 * frame.c: Make symbols static if they're not exported.
6744 (x_report_frame_params, make_terminal_frame): Now static.
6745 (get_frame_param): Now static, unless HAVE_NS.
6746 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6747 (x_get_resource_string): Remove; not used.
6748 * frame.h (make_terminal_frame, x_report_frame_params):
6749 (x_get_resource_string); Remove decls.
6750 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6751 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6753 * font.c, fontset.c: Make symbols static if they're not exported.
6754 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6755 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6756 * font.c (font_close_object): Now static.
6757 * font.h (font_close_object): Remove.
6758 * fontset.c (FONTSET_OBJLIST): Remove.
6759 (free_realized_fontset) #if-0 the body, which does nothing.
6760 (face_suitable_for_char_p): #if-0, as it's never called.
6761 * fontset.h (face_suitable_for_char_p): Remove decl.
6762 * xfaces.c (face_at_string_position):
6763 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6764 since 0 is always ASCII.
6766 * fns.c (weak_hash_tables): Now static.
6768 * fileio.c: Make symbols static if they're not exported.
6769 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6770 (Vwrite_region_annotation_buffers): Now static.
6772 * eval.c: Make symbols static if they're not exported.
6773 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6774 * lisp.h (backtrace_list): Remove decl.
6776 * emacs.c: Make symbols static if they're not exported.
6777 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6778 (fatal_error_code, fatal_error_signal_hook, standard_args):
6780 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6781 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6782 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6783 * lisp.h (fatal_error_signal_hook): Remove decl.
6784 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6786 * editfns.c: Move a (normally-unused) function to its only use.
6787 * editfns.c, lisp.h (get_operating_system_release): Remove.
6788 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6789 worth the hassle of breaking this out.
6791 * xterm.c: Make symbols static if they're not exported.
6792 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6793 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6794 (x_destroy_window, x_delete_display):
6796 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6797 (x_mouse_leave): Remove; unused.
6798 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6799 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6800 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6802 (x_mouse_leave): Declare only if WINDOWSNT.
6803 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6804 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6807 * ftxfont.c: Make symbols static if they're not exported.
6808 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6810 * font.h (ftxfont_driver): Likewise.
6812 * xfns.c: Make symbols static if they're not exported.
6813 (x_last_font_name, x_display_info_for_name):
6814 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6815 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6816 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6817 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6818 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6819 (last_show_tip_args): Now static.
6820 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6821 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6822 (x_screen_planes): Remove; unused.
6823 * dispextern.h (x_screen_planes): Remove decl.
6825 * dispnew.c: Make symbols static if they're not exported.
6826 * dispextern.h (redraw_garbaged_frames, scrolling):
6827 (increment_row_positions): Remove.
6828 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6829 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6831 (redraw_garbaged_frames): Remove; unused.
6833 * xfaces.c: Make symbols static if they're not exported.
6834 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6836 * xterm.h (defined_color): Remove decls.
6837 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6838 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6839 (menu_face_changed_default, defined_color, free_realized_face):
6840 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6841 (ascii_face_of_lisp_face): Remove; unused.
6843 * xdisp.c: Make symbols static if they're not exported.
6844 * dispextern.h (scratch_glyph_row, window_box_edges):
6845 (glyph_to_pixel_coords, set_cursor_from_row):
6846 (get_next_display_element, set_iterator_to_next):
6847 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6848 (show_mouse_face): Remove decls
6849 * frame.h (message_buf_print): Likewise.
6850 * lisp.h (pop_message, set_message, check_point_in_composition):
6852 * xterm.h (set_vertical_scroll_bar): Likewise.
6853 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6854 (message_buf_print, scratch_glyph_row, displayed_buffer):
6855 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6856 (get_next_display_element, show_mouse_face, window_box_edges):
6857 (frame_to_window_pixel_xy, check_point_in_composition):
6858 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6859 (glyph_to_pixel_coords): Remove; unused.
6861 * dired.c (file_name_completion): Now static.
6863 * dbusbind.c (xd_in_read_queued_messages): Now static.
6865 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6866 * data.c (circular_list_error): Remove.
6868 * commands.h (last_point_position, last_point_position_buffer):
6869 (last_point_position_window): Remove decls.
6870 * keyboard.c: Make these variables static.
6872 * coding.h (coding, code_convert_region, encode_coding_gap):
6874 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6875 (iso_code_class, detect_coding, code_convert_region): Now static.
6876 (encode_coding_gap): Remove; unused.
6878 * chartab.c (chartab_chars, chartab_bits): Now static.
6880 * charset.h (charset_iso_8859_1): Remove decl.
6881 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6884 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6885 * ccl.c (Vccl_program_table): Now static.
6886 (check_ccl_update): Remove; unused.
6888 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6889 * category.h: ... from here.
6890 * category.c (check_category_table, set_category_set): Now static.
6892 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6893 * lisp.h: Remove these decls.
6895 * buffer.c (buffer_count): Remove unused var.
6897 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6898 so that it's not optimized away.
6899 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6900 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6901 exported only to the debugger.
6903 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6904 * atimer.h (run_all_atimers): Remove; not exported.
6906 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6907 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6908 was inaccessible from Lisp.
6909 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6910 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6912 alloc.c: Import and export fewer symbols, and remove unused items.
6913 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6915 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6916 it's not optimized away by whole-program optimization.
6917 (message_enable_multibyte, free_misc): Remove.
6918 (catchlist, handlerlist, mark_backtrace):
6919 Declare only if BYTE_MARK_STACK.
6920 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6921 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6922 (message_enable_multibyte): Remove decl.
6923 (free_misc, interval_free_list, float_block, float_block_index):
6924 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6925 (cons_free_list, last_marked_index):
6927 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6928 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6929 (mark_backtrace): Define only if BYTE_MARK_STACK.
6930 * xdisp.c (message_enable_multibyte): Now static.
6932 Declare Lisp_Object Q* variables to be 'static' if not exported.
6933 This makes it easier for human readers (and static analyzers)
6934 to see whether these variables are used from other modules.
6935 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6936 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6937 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6938 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6939 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6940 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6941 * xmenu.c, xselect.c:
6942 Declare Q* vars static if they are not used in other modules.
6943 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6944 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6945 Remove decls of unexported vars.
6946 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6948 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6950 Make Emacs functions such as Fatom 'static' by default.
6951 This makes it easier for human readers (and static analyzers)
6952 to see whether these functions can be called from other modules.
6953 DEFUN now defines a static function. To make the function external
6954 so that it can be used in other C modules, use the new macro DEFUE.
6955 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6956 (Finit_image_library):
6957 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6958 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6959 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6960 Remove decls, since these functions are now static.
6961 (Funintern, Fget_internal_run_time): New decls, since these functions
6962 were already external.
6964 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6965 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6966 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6967 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6968 * keyboard.c, keymap.c, lread.c:
6969 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6970 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6971 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6972 Mark functions with DEFUE instead of DEFUN,
6973 if they are used in other modules.
6974 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6975 decls for now-static functions.
6976 * buffer.h (Fdelete_overlay): Remove decl.
6977 * callproc.c (Fgetenv_internal): Mark as internal.
6978 * composite.c (Fremove_list_of_text_properties): Remove decl.
6979 (Fcomposition_get_gstring): New forward static decl.
6980 * composite.h (Fcomposite_get_gstring): Remove decl.
6981 * dired.c (Ffile_attributes): New forward static decl.
6982 * doc.c (Fdocumntation_property): New forward static decl.
6983 * eval.c (Ffetch_bytecode): New forward static decl.
6984 (Funintern): Remove extern decl; now in .h file where it belongs.
6985 * fileio.c (Fmake_symbolic_link): New forward static decl.
6986 * image.c (Finit_image_library): New forward static decl.
6987 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6988 * intervals.h (Fprevious_property_change):
6989 (Fremove_list_of_text_properties): Remove decls.
6990 * keyboard.c (Fthis_command_keys): Remove decl.
6991 (Fcommand_execute): New forward static decl.
6992 * keymap.c (Flookup_key): New forward static decl.
6993 (Fcopy_keymap): Now static.
6994 * keymap.h (Flookup_key): Remove decl.
6995 * process.c (Fget_process): New forward static decl.
6996 (Fprocess_datagram_address): Mark as internal.
6997 * syntax.c (Fsyntax_table_p): New forward static decl.
6998 (skip_chars): Remove duplicate decl.
6999 * textprop.c (Fprevious_property_change): New forward static decl.
7000 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7002 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7003 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7005 * editfns.c (Fformat): Remove unreachable code.
7007 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7009 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7012 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7014 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7015 when at ZV. (Bug#8487)
7017 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7019 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7021 * keyboard.c (parse_tool_bar_item): Likewise.
7022 * sound.c (sound_cleanup, alsa_close): Likewise.
7023 * termcap.c (tgetent): Likewise.
7024 * xfns.c (x_default_font_parameter): Likewise.
7025 * xsettings.c (read_and_apply_settings): Likewise.
7027 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7028 (overrun_check_free): Protoize.
7030 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7032 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7033 since callers should never pass a negative size.
7034 Change the signature to match that of plain 'read' and 'write'; see
7035 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7036 * lisp.h: Update prototypes of emacs_write and emacs_read.
7038 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7040 * xdisp.c (redisplay_window): Don't try to determine the character
7041 position of the scroll margin if the window start point w->startp
7042 is outside the buffer's accessible region. (Bug#8468)
7044 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7046 Fix write-region and its subroutines for buffers > 2GB.
7047 * fileio.c (a_write, e_write): Modify declaration of arguments and
7048 local variables to support buffers larger than 2GB.
7049 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7051 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7052 argument, local variables, and return value.
7054 * lisp.h: Update prototypes of emacs_write and emacs_read.
7056 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7058 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7060 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7062 Fix more problems found by GCC 4.6.0's static checks.
7064 * xdisp.c (vmessage): Use a better test for character truncation.
7066 * charset.c (load_charset_map): <, not <=, for optimization,
7067 and to avoid potential problems with integer overflow.
7068 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7069 * casetab.c (set_identity, shuffle): Likewise.
7070 * editfns.c (Fformat): Likewise.
7071 * syntax.c (skip_chars): Likewise.
7073 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7074 This also lets GCC 4.6.0 generate slightly better loop code.
7076 * callint.c (Fcall_interactively): <, not <=, for optimization.
7077 (Fcall_interactively): Count the number of arguments produced,
7078 not the number of arguments given. This is simpler and lets GCC
7079 4.6.0 generate slightly better code.
7081 * ftfont.c: Distingish more carefully between FcChar8 and char.
7082 The previous code passed unsigned char * to a functions like
7083 strlen and xstrcasecmp that expect char *, which does not
7084 conform to the C standard.
7085 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7086 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7087 char * when the C standard requires it.
7089 * keyboard.c (read_char): Remove unused var.
7091 * eval.c: Port to Windows vsnprintf (Bug#8435).
7093 (SIZE_MAX): Define if the headers do not.
7094 (verror): Do not give up if vsnprintf returns a negative count.
7095 Instead, grow the buffer. This ports to Windows vsnprintf, which
7096 does not conform to C99. Problem reported by Eli Zaretskii.
7097 Also, simplify the allocation scheme, by avoiding the need for
7098 calling realloc, and removing the ALLOCATED variable.
7100 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7102 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7103 But keep the doprint source code for now, as we might revamp it
7104 and use it again (Bug#8435).
7105 * lisp.h (doprnt): Remove.
7106 * Makefile.in (base_obj): Remove doprnt.o.
7107 * deps.mk (doprnt.o): Remove.
7109 error: Print 32- and 64-bit integers portably (Bug#8435).
7110 Without this change, on typical 64-bit hosts error ("...%d...", N)
7111 was used to print both 32- and 64-bit integers N, which relied on
7113 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7115 * lisp.h (error, verror): Mark as printf-like functions.
7116 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7117 Report overflow in size calculations when allocating printf buffer.
7118 Do not truncate output string at its first null byte.
7119 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7120 Truncate the output at a character boundary, since vsnprintf does not
7122 * charset.c (check_iso_charset_parameter): Convert internal
7123 character to string before calling 'error', since %c now has the
7125 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7126 overflow when computing char to be passed to 'error'. Do not
7127 pass Lisp_Object to 'error'; pass the integer instead.
7128 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7129 formatted with plain %d.
7131 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7133 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7135 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7137 * xterm.c (x_catch_errors): Remove duplicate declaration.
7139 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7141 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7143 2011-04-10 Jim Meyering <meyering@redhat.com>
7145 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7146 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7147 return ssize_t not "int", and use size_t as the buffer length.
7148 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7149 * gnutls.h: Update declarations.
7150 * process.c (read_process_output): Use ssize_t, to match.
7151 (send_process): Likewise.
7153 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7155 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7157 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7159 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7160 Use unsigned char, to match FcChar8 type definition.
7162 * xterm.c (handle_one_xevent):
7163 * xmenu.c (create_and_show_popup_menu):
7164 * xselect.c (x_decline_selection_request)
7165 (x_reply_selection_request): Avoid type-punned deref of X events.
7167 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7169 Fix some uses of `int' instead of EMACS_INT.
7170 * search.c (string_match_1, fast_string_match)
7171 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7172 (scan_buffer, find_next_newline_no_quit)
7173 (find_before_next_newline, search_command, Freplace_match)
7174 (Fmatch_data): Make some `int' variables be EMACS_INT.
7176 * xdisp.c (display_count_lines): 3rd argument and return value now
7177 EMACS_INT. All callers changed.
7178 (pint2hrstr): Last argument is now EMACS_INT.
7180 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7181 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7182 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7183 (decode_coding_utf_16, decode_coding_emacs_mule)
7184 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7185 (decode_coding_ccl, decode_coding_charset)
7186 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7187 (decode_coding_iso_2022, decode_coding_emacs_mule)
7188 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7189 <char_offset, last_offset>: Declare EMACS_INT.
7190 (encode_coding_utf_8, encode_coding_utf_16)
7191 (encode_coding_emacs_mule, encode_invocation_designation)
7192 (encode_designation_at_bol, encode_coding_iso_2022)
7193 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7194 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7196 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7197 (encode_invocation_designation): Last argument P_NCHARS is now
7199 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7200 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7202 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7205 * ccl.c (Fccl_execute_on_string): Declare some variables
7208 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7210 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7212 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7214 * process.c (Fformat_network_address): Doc fix.
7216 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7218 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7220 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7222 * keyboard.c (read_char): Call Lisp function help-form-show,
7223 instead of using internal_with_output_to_temp_buffer.
7224 (Qhelp_form_show): New var.
7225 (syms_of_keyboard): Use DEFSYM macro.
7227 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7229 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7231 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7233 * process.c (Flist_processes): Remove to Lisp.
7234 (list_processes_1): Delete.
7236 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7238 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7240 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7242 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7244 Fix more problems found by GCC 4.6.0's static checks.
7246 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7248 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7250 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7252 * xdisp.c (vmessage): Mark as a printf-like function.
7254 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7256 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7258 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7259 printf-like functions.
7260 (tiff_load): Add casts to remove these marks before passing them
7261 to system-supplied API.
7263 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7265 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7266 This avoids several warnings with gcc -Wstrict-overflow.
7267 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7268 directly, rather than having caller test rule sign. This avoids
7269 some unnecessary tests.
7270 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7271 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7272 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7274 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7275 (xfont_open): Avoid unnecessary tests.
7277 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7279 * composite.h, composite.c (composition_gstring_put_cache):
7280 Use EMACS_INT, not int, for length.
7282 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7283 breaking out part of COMPOSITION_DECODE_RULE.
7284 (COMPOSITION_DECODE_RULE): Use it.
7285 * composite.c (get_composition_id): Remove unused local vars,
7286 by using the new macro.
7288 * textprop.c (set_text_properties_1): Change while to do-while,
7289 since the condition is always true at first.
7291 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7292 (interval_deletion_adjustment): Return unsigned value.
7295 * process.c (list_processes_1, create_pty, read_process_output):
7296 (exec_sentinel): Remove vars that were set but not used.
7297 (create_pty): Remove unnecessary "volatile"s.
7298 (Fnetwork_interface_info): Avoid possibility of int overflow.
7299 (read_process_output): Do adaptive read buffering even if carryover.
7300 (read_process_output): Simplify nbytes computation if buffered.
7302 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7304 * syntax.c (scan_words): Remove var that was set but not used.
7305 (update_syntax_table): Use unsigned instead of int.
7307 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7308 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7309 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7311 * print.c (print_error_message): Avoid int overflow.
7313 * font.c (font_list_entities): Redo for clarity,
7314 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7316 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7317 (font_score): Avoid potential overflow in diff calculation.
7319 * fns.c (substring_both): Remove var that is set but not used.
7320 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7322 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7324 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7325 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7326 can always succeed if overflow has undefined behavior.
7328 * search.c (boyer_moore, wordify): Remove vars set but not used.
7329 (wordify): Omit three unnecessary tests.
7331 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7332 All callers changed. This avoids the need for an unused var.
7334 * casefiddle.c (casify_region): Remove var that is set but not used.
7336 * dired.c (file_name_completion): Remove var that is set but not used.
7338 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7340 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7341 (Finsert_file_contents): Remove unnecessary code checking fd.
7343 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7344 Check for integer overflow on size calculations.
7346 * buffer.c (Fprevious_overlay_change): Remove var that is set
7349 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7350 Remove vars that are set but not used.
7351 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7352 (timer_check_2): Mark vars as initialized.
7354 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7356 * image.c (lookup_image): Remove var that is set but not used.
7357 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7359 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7360 that are set but not used.
7362 * xfns.c (make_invisible_cursor): Don't return garbage
7363 if XCreateBitmapFromData fails (Bug#8410).
7365 * xselect.c (x_get_local_selection, x_handle_property_notify):
7366 Remove vars that are set but not used.
7368 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7369 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7371 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7372 Remove var that is set but not used.
7373 (scroll_bar_windows_size): Now size_t, not int.
7374 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7377 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7378 (map_tty_color) [!defined MSDOS]: Likewise.
7380 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7382 * coding.c: Remove vars that are set but not used.
7383 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7384 All callers changed.
7385 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7386 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7387 (decode_coding_charset): Remove vars that are set but not used.
7389 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7390 that is set but not used.
7392 * print.c (print_object): Remove var that is set but not used.
7394 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7395 The gnulib version avoids calling malloc in the usual case,
7396 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7397 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7398 * filelock.c (current_lock_owner): Likewise.
7399 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7400 * sysdep.c: Include allocator.h, careadlinkat.h.
7401 (emacs_no_realloc_allocator): New static constant.
7402 (emacs_readlink): New function.
7403 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7404 ../lib/careadlinkat.h.
7406 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7408 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7409 first non-nil return value).
7411 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7413 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7414 if not defined (Bug#8403).
7416 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7418 * xdisp.c (display_count_lines): Remove parameter `start',
7419 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7420 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7421 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7422 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7423 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7424 and thereabouts. All callers changed.
7425 (get_per_char_metric): Remove parameter `f', unused since
7426 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7428 2011-04-02 Jim Meyering <meyering@redhat.com>
7430 do not dereference NULL upon failed strdup
7431 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7432 (ns_get_family): Likewise.
7434 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7436 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7438 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7440 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7443 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7445 Add lexical binding.
7447 * window.c (Ftemp_output_buffer_show): New fun.
7448 (Fsave_window_excursion):
7449 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7451 * lread.c (lisp_file_lexically_bound_p): New function.
7452 (Fload): Bind Qlexical_binding.
7453 (readevalloop): Remove `evalfun' arg.
7454 Bind Qinternal_interpreter_environment.
7455 (Feval_buffer): Bind Qlexical_binding.
7456 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7458 (syms_of_lread): Declare `lexical-binding'.
7460 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7462 * keyboard.c (eval_dyn): New fun.
7463 (menu_item_eval_property): Use it.
7465 * image.c (parse_image_spec): Use Ffunctionp.
7467 * fns.c (concat, mapcar1): Accept byte-code-functions.
7469 * eval.c (Fsetq): Handle lexical vars.
7470 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7471 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7472 (FletX, Flet): Obey lexical binding.
7473 (Fcommandp): Handle closures.
7474 (Feval): New `lexical' arg.
7475 (eval_sub): New function extracted from Feval. Use it almost
7476 everywhere where Feval was used. Look up vars in lexical env.
7478 (Ffunctionp): Move from subr.el.
7479 (Ffuncall): Handle closures.
7480 (apply_lambda): Remove `eval_flags'.
7481 (funcall_lambda): Handle closures and new byte-code-functions.
7482 (Fspecial_variable_p): New function.
7483 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7484 but without exporting it to Lisp.
7486 * doc.c (Fdocumentation, store_function_docstring):
7487 * data.c (Finteractive_form): Handle closures.
7489 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7492 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7494 (exec_byte_code): New function extracted from Fbyte_code to handle new
7495 calling convention for byte-code-functions. Add new byte-codes.
7497 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7499 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7501 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7503 * xdisp.c (redisplay_internal): Fix prototype.
7505 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7507 * xdisp.c (SCROLL_LIMIT): New macro.
7508 (try_scrolling): Use it when setting scroll_limit.
7509 Limit scrolling to 100 screen lines.
7510 (redisplay_window): Even when falling back on "recentering",
7511 position point in the window according to scroll-conservatively,
7512 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7514 (try_scrolling): When point is above the window, allow searching
7515 as far as scroll_max, or one screenful, to compute vertical
7516 distance from PT to the scroll margin position. This prevents
7517 try_scrolling from unnecessarily failing when
7518 scroll-conservatively is set to a value slightly larger than the
7519 window height. Clean up the case of PT below the margin at bottom
7520 of window: scroll_max can no longer be INT_MAX. When aggressive
7521 scrolling is in use, don't let point enter the opposite scroll
7522 margin as result of the scroll.
7523 (syms_of_xdisp) <scroll-conservatively>: Document the
7524 threshold of 100 lines for never-recentering scrolling.
7526 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7528 * dispextern.h (move_it_by_lines):
7529 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7530 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7531 (message_log_check_duplicate): Remove parameters `prev_bol' and
7532 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7533 (redisplay_internal): Remove parameter `preserve_echo_area',
7534 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7536 * indent.c (Fvertical_motion):
7537 * window.c (window_scroll_pixel_based, Frecenter):
7538 Don't pass `need_y_p' to `move_it_by_lines'.
7540 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7542 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7543 steal a few bits to be more compact.
7544 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7545 Remove unneeded casts.
7547 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7549 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7551 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7552 binding" message (bug#7967).
7554 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7556 Fix more problems found by GCC 4.6.0's static checks.
7558 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7559 Remove unused local var.
7561 * editfns.c (Fmessage_box): Remove unused local var.
7563 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7564 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7565 Omit unused local vars.
7566 * window.c (shrink_windows): Omit unused local var.
7567 * menu.c (digest_single_submenu): Omit unused local var.
7568 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7569 Omit unused local var.
7571 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7572 Don't assume string length fits in int.
7573 (keyremap_step, read_key_sequence): Use size_t for sizes.
7574 (read_key_sequence): Don't check last_real_key_start redundantly.
7576 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7577 instead of alloca (Bug#8344).
7579 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7580 (Fbacktrace_frame): Don't assume nframes fits in int.
7582 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7584 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7587 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7589 * cm.c (calccost): Turn while-do into do-while, for clarity.
7591 * keyboard.c (syms_of_keyboard): Use the same style as later
7592 in this function when indexing through an array. This also
7593 works around GCC bug 48267.
7595 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7597 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7599 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7600 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7602 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7603 This avoids undefined behavior on integer overflow, and is a bit
7604 more convenient anyway since it is compared to a size_t variable.
7606 Variadic C functions now count arguments with size_t, not int.
7607 This avoids an unnecessary limitation on 64-bit machines, which
7608 caused (substring ...) to crash on large vectors (Bug#8344).
7609 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7610 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7611 All variadic functions and their callers changed accordingly.
7612 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7613 * data.c (arith_driver, float_arith_driver): Likewise.
7614 * editfns.c (general_insert_function): Likewise.
7615 * eval.c (struct backtrace.nargs, interactive_p)
7616 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7617 (funcall_lambda, mark_backtrace): Likewise.
7618 * fns.c (concat): Likewise.
7619 * frame.c (x_set_frame_parameters): Likewise.
7620 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7621 0 if not found, not -1. All callers changed.
7623 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7624 (stack_copy_size): Now size_t, not int.
7625 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7627 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7629 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7630 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7631 All callers changed.
7633 * lisp.h (multibyte_char_to_unibyte):
7634 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7635 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7636 * character.h (CHAR_TO_BYTE8):
7637 * cmds.c (internal_self_insert):
7638 * editfns.c (general_insert_function):
7639 * keymap.c (push_key_description):
7640 * search.c (Freplace_match):
7641 * xdisp.c (message_dolog, set_message_1): All callers changed.
7643 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7645 * keyboard.c (safe_run_hook_funcall): New function.
7646 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7647 don't set the hook to nil, but remove the offending function instead.
7648 (Qcommand_hook_internal): Remove, unused.
7649 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7650 Vcommand_hook_internal.
7652 * eval.c (enum run_hooks_condition): Remove.
7653 (funcall_nil, funcall_not): New functions.
7654 (run_hook_with_args): Call each function through a `funcall' argument.
7655 Remove `cond' argument, now redundant.
7656 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7657 (Frun_hook_with_args_until_failure): Adjust accordingly.
7658 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7660 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7662 * dispextern.h (string_buffer_position): Remove declaration.
7664 * print.c (strout): Remove parameter `multibyte', unused since
7665 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7667 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7668 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7669 All callers changed.
7671 * w32.c (_wsa_errlist): Use braces for struct initializers.
7673 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7674 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7675 All callers changed.
7676 (string_buffer_position): Likewise. Also, make static (it's never
7677 used outside xdisp.c).
7678 (cursor_row_p): Remove parameter `w', unused since
7679 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7680 (decode_mode_spec): Remove parameter `precision', introduced during
7681 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7682 All callers changed.
7684 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7686 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7688 2011-03-27 Anders Lindgren <andlind@gmail.com>
7690 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7691 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7692 (ns_update_auto_hide_menu_bar): New functions.
7693 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7694 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7695 ns_constrain_all_frames.
7696 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7697 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7699 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7701 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7703 2011-03-27 Glenn Morris <rgm@gnu.org>
7705 * syssignal.h: Replace RETSIGTYPE with void.
7706 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7707 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7708 Replace SIGTYPE with void everywhere.
7709 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7710 * s/template.h (SIGTYPE): Remove commented out definition.
7712 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7714 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7715 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7717 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7719 * w32.c (read_unc_volume): Use parameter `henum', instead of
7720 global variable `wget_enum_handle'.
7722 * keymap.c (describe_vector): Remove parameters `indices' and
7723 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7724 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7726 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7728 * keyboard.c (timer_check): Remove parameter `do_it_now',
7729 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7730 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7731 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7733 * keyboard.c (read_char):
7734 * w32menu.c (w32_menu_display_help):
7735 * xmenu.c (show_help_event, menu_help_callback):
7736 Adjust calls to `show_help_echo'.
7738 * gtkutil.c (xg_maybe_add_timer):
7739 * keyboard.c (readable_events):
7740 * process.c (wait_reading_process_output):
7741 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7743 * insdel.c (adjust_markers_gap_motion):
7744 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7745 (gap_left, gap_right): Don't call it.
7747 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7749 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7750 incurred during fontification.
7752 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7754 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7755 (DEFVAR_PER_BUFFER): Don't pass it.
7757 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7758 (scrolling_window): Don't pass it.
7760 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7762 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7764 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7766 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7767 of variables specific to SELinux and computation of `encoded_absname'.
7769 * image.c (XPutPixel): Remove unused variable `height'.
7771 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7773 * unexw32.c (get_section_info): Remove unused variable `section'.
7775 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7776 (system_process_attributes): Remove unused variable `sess'.
7777 (sys_read): Remove unused variable `err'.
7779 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7780 (w32_wnd_proc): Remove unused variable `isdead'.
7781 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7782 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7783 (x_create_tip_frame): Remove unused variable `tem'.
7785 * w32inevt.c (w32_console_read_socket):
7786 Remove unused variable `no_events'.
7788 * w32term.c (x_draw_composite_glyph_string_foreground):
7789 Remove unused variable `width'.
7791 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7793 * w32term.c (x_set_glyph_string_clipping):
7794 Don't pass uninitialized region to CombineRgn.
7796 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7798 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7799 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7800 (Fx_close_connection): Remove unused variable `i'.
7802 * w32font.c (w32font_draw): Return number of glyphs.
7803 (w32font_open_internal): Remove unused variable `i'.
7804 (w32font_driver): Add missing initializer.
7806 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7807 (fill_in_menu): Remove unused variable `items_added'.
7809 * w32term.c (last_mouse_press_frame): Remove static global variable.
7810 (w32_clip_to_row): Remove unused variable `f'.
7811 (x_delete_terminal): Remove unused variable `i'.
7813 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7814 (NOTHING): Remove unused static global variable.
7815 (uniscribe_check_otf): Remove unused variable `table'.
7816 (uniscribe_font_driver): Add missing initializers.
7818 2011-03-23 Julien Danjou <julien@danjou.info>
7820 * term.c (Fsuspend_tty, Fresume_tty):
7821 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7822 * window.c (temp_output_buffer_show):
7823 * insdel.c (signal_before_change):
7824 * frame.c (Fhandle_switch_frame):
7825 * fileio.c (Fdo_auto_save):
7826 * emacs.c (Fkill_emacs):
7827 * editfns.c (save_excursion_restore):
7828 * cmds.c (internal_self_insert):
7829 * callint.c (Fcall_interactively):
7830 * buffer.c (Fkill_all_local_variables):
7831 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7833 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7834 unconditionally since it does the check itself.
7836 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7838 Fix more problems found by GCC 4.5.2's static checks.
7840 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7841 the first time through the loop, since we know p0 < p1 then.
7842 This also avoids a gcc -Wstrict-overflow warning.
7844 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7845 leading to a memory leak, possible in functions like
7846 load_charset_map_from_file that can allocate an unbounded number
7847 of objects (Bug#8318).
7849 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7850 that could (at least in theory) be that large.
7852 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7853 This is less likely to overflow, and avoids undefined behavior if
7854 overflow does occur. All callers changed. Use strtoul to scan
7855 for the unsigned long integer.
7856 (pint2hrstr): Simplify and tune code slightly.
7857 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7859 * scroll.c (do_scrolling): Work around GCC bug 48228.
7860 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7862 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7863 This also avoids a warning with gcc -Wstrict-overflow.
7864 (validate_x_resource_name): Simplify count usage.
7865 This also avoids a warning with gcc -Wstrict-overflow.
7867 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7870 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7872 * process.c (Fmake_network_process): Use socklen_t, not int,
7873 where POSIX says socklen_t is required in portable programs.
7874 This fixes a porting bug on hosts like 64-bit HP-UX, where
7875 socklen_t is wider than int (Bug#8277).
7876 (Fmake_network_process, server_accept_connection):
7877 (wait_reading_process_output, read_process_output):
7880 * process.c: Rename or move locals to avoid shadowing.
7881 (list_processes_1, Fmake_network_process):
7882 (read_process_output_error_handler, exec_sentinel_error_handler):
7883 Rename or move locals.
7884 (Fmake_network_process): Define label "retry_connect" only if needed.
7885 (Fnetwork_interface_info): Fix pointer signedness.
7886 (process_send_signal): Add cast to avoid pointer signedness problem.
7887 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7888 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7890 Make tparam.h and terminfo.c consistent.
7891 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7892 Include tparam.h instead, since it declares them.
7893 * cm.h (PC): Remove extern decl; tparam.h now does this.
7894 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7895 * terminfo.c: Include tparam.h, to check interfaces.
7896 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7897 (tparam): Adjust signature to match interface in tparam.h;
7898 this removes some undefined behavior. Check that outstring and len
7899 are zero, which they always are with Emacs.
7900 * tparam.h (PC, BC, UP): New extern decls.
7902 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7903 (xftfont_open): Rename locals to avoid shadowing.
7905 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7906 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7907 (OTF_TAG_SYM): Omit macro if not needed.
7908 (ftfont_list): Remove unused local.
7909 (get_adstyle_property, ftfont_pattern_entity):
7910 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7911 Rename locals to avoid shadowing.
7913 * xfont.c (xfont_list_family): Mark var as initialized.
7915 * xml.c (make_dom): Now static.
7917 * composite.c (composition_compute_stop_pos): Rename local to
7919 (composition_reseat_it): Remove unused locals.
7920 (find_automatic_composition, composition_adjust_point): Likewise.
7921 (composition_update_it): Mark var as initialized.
7922 (find_automatic_composition): Mark vars as initialized,
7923 with a FIXME (Bug#8290).
7925 character.h: Rename locals to avoid shadowing.
7926 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7927 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7928 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7929 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7932 * textprop.c (property_change_between_p): Remove; unused.
7934 * intervals.c (interval_start_pos): Now static.
7936 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7938 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7939 Rename locals to avoid shadowing.
7941 * sound.c (wav_play, au_play, Fplay_sound_internal):
7942 Fix pointer signedness.
7943 (alsa_choose_format): Remove unused local var.
7944 (wav_play): Initialize a variable to 0, to prevent undefined
7945 behavior (Bug#8278).
7947 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7949 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7951 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7952 clobbering (Bug#8298).
7953 * sysdep.c (sys_subshell): Likewise.
7954 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7956 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7957 This should get cleaned up, so that child_setup has the
7958 same signature on all platforms.
7960 * callproc.c (call_process_cleanup): Now static.
7961 (relocate_fd): Rename locals to avoid shadowing.
7963 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7965 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7966 not to be necessary, and produces flickering.
7968 2011-03-20 Glenn Morris <rgm@gnu.org>
7970 * config.in: Remove file.
7972 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7974 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7975 are now in src/globals.h.
7976 (syms_of_minibuf): Remove spurious & from previous change.
7978 2011-03-20 Leo <sdl.web@gmail.com>
7980 * minibuf.c (completing-read-function): New variable.
7981 (completing-read-default): Rename from completing-read.
7982 (completing-read): Call completing-read-function.
7984 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7986 * xfaces.c (Fx_load_color_file):
7987 Read color file from absolute filename (bug#8250).
7989 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7991 * makefile.w32-in: Update dependencies.
7993 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7995 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7997 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7999 Fix more problems found by GCC 4.5.2's static checks.
8001 * process.c (make_serial_process_unwind, send_process_trap):
8002 (sigchld_handler): Now static.
8004 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8005 That way, the code declares only the vars that it needs.
8006 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8007 * s/cygwin.h (PTY_ITERATION): Likewise.
8008 * s/darwin.h (PTY_ITERATION): Likewise.
8009 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8011 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8012 * process.c (allocate_pty): Don't declare stb unless it's needed.
8014 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8015 (CONSTANTLIM): Remove; unused.
8016 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8017 Define only if needed.
8019 * unexelf.c (unexec): Name an expression,
8020 to avoid gcc -Wbad-function-cast warning.
8021 Use a different way to cause a compilation error if anyone uses
8022 n rather than nn, a way that does not involve shadowing.
8023 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8025 * deps.mk (unexalpha.o): Remove; unused.
8027 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8028 * unexec.h: New file.
8029 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8030 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8032 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8033 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8034 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8035 Change as necessary to match prototype in unexec.h.
8037 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8039 (back_comment, skip_chars): Mark vars as initialized.
8041 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8042 Rename locals to avoid shadowing.
8044 * lread.c (read1): Rewrite so as not to use empty "else".
8045 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8047 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8049 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8050 warning when compiling print.c.
8052 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8053 instead of using an uninitialized var.
8054 (font_sort_entities): Mark var as initialized.
8056 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8058 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8059 pointers to constants.
8060 (font_parse_fcname): Remove unused vars.
8061 (font_delete_unmatched): Now static.
8062 (font_get_spec): Remove; unused.
8063 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8064 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8065 Rename or move locals to avoid shadowing.
8067 * fns.c (require_nesting_list, require_unwind): Now static.
8068 (Ffillarray): Rename locals to avoid shadowing.
8070 * floatfns.c (domain_error2): Define only if needed.
8071 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8073 * alloc.c (mark_backtrace): Move decl from here ...
8074 * lisp.h: ... to here, so that it can be checked.
8076 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8077 (Fdefvar): Rewrite so as not to use empty "else".
8078 (lisp_indirect_variable): Name an expression,
8079 to avoid gcc -Wbad-function-cast warning.
8080 (Fdefvar): Rename locals to avoid shadowing.
8082 * callint.c (quotify_arg, quotify_args): Now static.
8083 (Fcall_interactively): Rename locals to avoid shadowing.
8084 Use const pointer when appropriate.
8086 * lisp.h (get_system_name, get_operating_system_release):
8087 Move decls here, to check interfaces.
8088 * process.c (get_operating_system_release): Move decl to lisp.h.
8089 * xrdb.c (get_system_name): Likewise.
8090 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8091 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8092 some of which prompt warnings from gcc -Wbad-function-cast.
8093 (Fformat_time_string, Fencode_time, Finsert_char):
8094 (Ftranslate_region_internal, Fformat):
8095 Rename or remove local vars to avoid shadowing.
8096 (Ftranslate_region_internal): Mark var as initialized.
8098 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8101 * lisp.h (eassert): Check that the argument compiles, even if
8102 ENABLE_CHECKING is not defined.
8104 * data.c (Findirect_variable): Name an expression, to avoid
8105 gcc -Wbad-function-cast warning.
8106 (default_value, arithcompare, arith_driver, arith_error): Now static.
8107 (store_symval_forwarding): Rename local to avoid shadowing.
8108 (Fmake_variable_buffer_local, Fmake_local_variable):
8109 Mark variables as initialized.
8110 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8112 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8113 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8114 Rename locals to avoid shadowing.
8115 (mark_stack): Move local variables into the #ifdef region where
8117 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8118 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8120 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8121 (GC_STRING_CHARS): Remove; not used.
8122 (Fmemory_limit): Cast sbrk's returned value to char *.
8124 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8125 avoids undefined behavior in theory.
8127 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8129 Use functions, not macros, for up- and down-casing (Bug#8254).
8130 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8131 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8132 to use the following functions instead of these macros.
8133 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8134 EMACS_INT, since callers assume the returned value fits in int.
8135 (upcase1): Likewise, for UPCASE_TABLE.
8136 (uppercasep, lowercasep, upcase): New static inline functions.
8137 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8138 the race-condition problem in the old DOWNCASE.
8140 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8141 Rename locals to avoid shadowing.
8142 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8143 (regex_compile, re_search_2, re_match_2_internal):
8144 Remove unused local vars.
8145 (FREE_VAR): Rewrite so as not to use empty "else",
8146 which gcc can warn about.
8147 (regex_compile, re_match_2_internal): Mark locals as initialized.
8148 (RETALLOC_IF): Define only if needed.
8149 (WORDCHAR_P): Likewise. This one is never needed, but is used
8150 only in a comment talking about a compiler bug, so put inside
8151 the #if 0 of that comment.
8152 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8153 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8156 * search.c (boyer_moore): Rename locals to avoid shadowing.
8157 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8158 (PREV_CHAR_BOUNDARY): Likewise.
8160 * search.c (simple_search): Remove unused var.
8162 * dired.c (compile_pattern): Move decl from here ...
8163 * lisp.h: ... to here, so that it can be checked.
8164 (struct re_registers): New forward decl.
8166 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8168 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8170 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8171 Rename locals to avoid shadowing.
8172 (Fvertical_motion): Mark locals as initialized.
8174 * casefiddle.c (casify_object, casify_region): Now static.
8175 (casify_region): Mark local as initialized.
8177 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8179 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8180 New macros, so that the caller can use some names other than
8181 gcpro1, gcpro2, etc.
8182 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8184 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8185 argument, for consistency with GCPRO2_VAR, etc: it is now the
8186 prefix of the variable, not the variable itself. All uses
8188 * dired.c (directory_files_internal, file_name_completion):
8189 Rename locals to avoid shadowing.
8191 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8192 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8193 dired.c's scmp function, had undefined behavior.
8194 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8195 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8196 * buffer.h: ... to here, because these macros use current_buffer,
8197 and the new implementation with inline functions needs to have
8198 current_buffer in scope now, rather than later when the macros
8200 (downcase, upcase1): New static inline functions.
8201 (DOWNCASE, UPCASE1): Reimplement using these functions.
8202 This avoids undefined behavior in expressions like
8203 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8204 from race conditions in accessing the global variables
8205 case_temp1 and case_temp2.
8206 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8207 * lisp.h (case_temp1, case_temp2): Remove their decls.
8208 * character.h (ASCII_CHAR_P): Move from here ...
8209 * lisp.h: ... to here, so that the inline functions mentioned
8212 * dired.c (directory_files_internal_unwind): Now static.
8214 * fileio.c (file_name_as_directory, directory_file_name):
8215 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8217 (file_name_as_directory): Use const pointers when appropriate.
8218 (Fexpand_file_name): Likewise. In particular, newdir might
8219 point at constant storage, so make it a const pointer.
8220 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8221 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8223 (Fset_file_times, Finsert_file_contents, auto_save_error):
8224 Rename locals to avoid shadowing.
8226 * minibuf.c (choose_minibuf_frame_1): Now static.
8227 (Ftry_completion, Fall_completions): Rename or remove locals
8230 * marker.c (bytepos_to_charpos): Remove; unused.
8232 * lisp.h (verify_bytepos, count_markers): New decls,
8233 so that gcc does not warn that these functions aren't declared.
8235 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8236 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8237 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8238 (copy_text): Remove unused local var.
8240 * filelock.c (within_one_second): Now static.
8241 (lock_file_1): Rename local to avoid shadowing.
8243 * buffer.c (fix_overlays_before): Mark locals as initialized.
8244 (fix_start_end_in_overlays): Likewise. This function should be
8245 simplified by using pointers-to-pointers, but that's a different
8247 (switch_to_buffer_1): Now static.
8248 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8249 (report_overlay_modification): Rename locals to avoid shadowing.
8251 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8252 Fix pointer signedness issue.
8253 (sys_subshell): Mark local as volatile if checking for lint,
8254 to suppress a gcc -Wclobbered warning that does not seem to be right.
8255 (MAXPATHLEN): Define only if needed.
8257 * process.c (serial_open, serial_configure): Move decls from here ...
8258 * systty.h: ... to here, so that they can be checked.
8260 * fns.c (get_random, seed_random): Move extern decls from here ...
8261 * lisp.h: ... to here, so that they can be checked.
8263 * sysdep.c (reset_io): Now static.
8264 (wait_for_termination_signal): Remove; unused.
8266 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8267 (copy_keymap_item, append_key, push_text_char_description):
8269 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8270 (DENSE_TABLE_SIZE): Remove; unused.
8271 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8272 (describe_map_tree):
8273 Rename locals to avoid shadowing.
8275 * keyboard.c: Declare functions static if they are not used elsewhere.
8276 (echo_char, echo_dash, cmd_error, top_level_2):
8277 (poll_for_input, handle_async_input): Now static.
8278 (read_char, kbd_buffer_get_event, make_lispy_position):
8279 (make_lispy_event, make_lispy_movement, apply_modifiers):
8280 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8281 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8282 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8283 (read_key_sequence, read_char): Mark locals as initialized.
8284 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8286 * keyboard.h (make_ctrl_char): New decl.
8287 (mark_kboards): Move decl here ...
8288 * alloc.c (mark_kboards): ... from here.
8290 * lisp.h (force_auto_save_soon): New decl.
8292 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8293 (DEFINE_DUMMY_FUNCTION): New macro.
8294 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8296 (main): Add casts to avoid warnings
8297 if GCC considers string literals to be constants.
8299 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8301 * dbusbind.c: Pointer signedness fixes.
8302 (xd_signature, xd_append_arg, xd_initialize):
8303 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8304 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8305 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8306 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8308 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8309 if GCC considers string literals to be constants.
8310 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8312 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8314 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8315 (print_preprocess, print_object): New macro to fix last change.
8317 * print.c (print_preprocess): Don't forget font objects.
8319 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8321 * emacs.c (USAGE3): Doc fixes.
8323 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8325 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8328 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8330 * lisp.h (VWindow_system, Qfile_name_history):
8331 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8332 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8333 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8335 * w32select.c: Don't #include "keyboard.h".
8336 (run_protected): Add extern declaration for waiting_for_input.
8338 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8339 * w32console.c (detect_input_pending, read_input_pending)
8340 (encode_terminal_code):
8341 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8342 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8343 (w32_system_caret_y, Qfile_name_history):
8344 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8345 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8346 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8347 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8348 * w32proc.c (Qlocal, report_file_error):
8349 * w32term.c (Vwindow_system, updating_frame):
8350 * w32uniscribe.c (initialized, uniscribe_font_driver):
8351 Remove unneeded extern declarations.
8353 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8355 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8357 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8359 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8360 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8361 These macros can no longer be used for assignment.
8363 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8364 Assign struct members directly, instead of using BUF_BEGV etc.
8365 (record_buffer_markers, fetch_buffer_markers): New functions for
8366 recording and fetching special buffer markers.
8367 (set_buffer_internal_1, set_buffer_temp): Use them.
8369 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8371 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8373 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8374 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8376 * xdisp.c (hscroll_window_tree):
8377 (reconsider_clip_changes): Use PT instead of BUF_PT.
8379 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8381 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8382 $(EMACS_ROOT)/lib/intprops.h.
8384 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8386 Fix more problems found by GCC 4.5.2's static checks.
8388 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8389 to unsigned char * to avoid compiler diagnostic.
8390 (xg_free_frame_widgets): Make it clear that a local variable is
8391 needed only if USE_GTK_TOOLTIP.
8392 (gdk_window_get_screen): Make it clear that this macro is needed
8393 only if USE_GTK_TOOLTIP.
8394 (int_gtk_range_get_value): New function, which avoids a diagnostic
8395 from gcc -Wbad-function-cast.
8396 (xg_set_toolkit_scroll_bar_thumb): Use it.
8397 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8398 diagnostic from gcc -Wbad-function-cast.
8399 (get_utf8_string, xg_get_file_with_chooser):
8400 Rename locals to avoid shadowing.
8401 (create_dialog): Move locals to avoid shadowing.
8403 * xgselect.c (xg_select): Remove unused var.
8405 * image.c (four_corners_best): Mark locals as initialized.
8406 (gif_load): Initialize transparent_p to zero (Bug#8238).
8407 Mark another local as initialized.
8408 (my_png_error, my_error_exit): Mark with NO_RETURN.
8410 * image.c (clear_image_cache): Now static.
8411 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8412 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8413 (x_edge_detection): Remove unnecessary cast that
8414 gcc -Wbad-function-cast diagnoses.
8415 (gif_load): Fix pointer signedness.
8416 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8417 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8419 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8421 Improve quality of tests for time stamp overflow.
8422 For example, without this patch (encode-time 0 0 0 1 1
8423 1152921504606846976) returns the obviously-bogus value (-948597
8424 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8425 reports time overflow. See
8426 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8427 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8428 * editfns.c: Include limits.h and intprops.h.
8429 (TIME_T_MIN, TIME_T_MAX): New macros.
8430 (time_overflow): Move earlier, to before first use.
8431 (hi_time, lo_time): New functions, for an accurate test for
8433 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8434 (Fget_internal_run_time): Don't assume time_t fits in int.
8435 (make_time): Use list2 instead of Fcons twice.
8436 (Fdecode_time): More accurate test for out-of-range times.
8437 (check_tm_member): New function.
8438 (Fencode_time): Use it, to test for out-of-range times.
8439 (lisp_time_argument): Don't rely on undefined left-shift and
8440 right-shift behavior when checking for time stamp overflow.
8442 * editfns.c (time_overflow): New function, refactoring common code.
8443 (Fformat_time_string, Fdecode_time, Fencode_time):
8444 (Fcurrent_time_string): Use it.
8446 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8447 * dired.c (make_time): Move to ...
8448 * editfns.c (make_time): ... here.
8449 * systime.h: Note the move.
8451 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8453 * fringe.c (update_window_fringes): Remove unused variables.
8455 * unexmacosx.c (copy_data_segment): Also copy __got section.
8458 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8460 * termcap.c [MSDOS]: Include "msdos.h".
8461 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8462 Constify `char *' arguments and their references according to
8463 prototypes in tparam.h.
8465 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8467 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8468 Adapt all references accordingly.
8470 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8472 2011-03-11 Tom Tromey <tromey@redhat.com>
8474 * buffer.c (syms_of_buffer): Remove obsolete comment.
8476 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8478 * termhooks.h (encode_terminal_code): Declare prototype.
8480 * msdos.c (encode_terminal_code): Don't declare prototype.
8482 * term.c (encode_terminal_code): Now external again, used by
8483 w32console.c and msdos.c.
8485 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8486 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8488 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8490 Fix some minor problems found by GCC 4.5.2's static checks.
8492 * fringe.c (update_window_fringes): Mark locals as initialized
8494 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8496 * alloc.c (mark_fringe_data): Move decl from here ...
8497 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8498 to check its interface.
8499 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8501 * fontset.c (free_realized_fontset): Now static.
8502 (Fset_fontset_font): Rename local to avoid shadowing.
8503 (fontset_font): Mark local as initialized.
8504 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8506 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8508 * xselect.c (x_disown_buffer_selections): Remove; not used.
8509 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8510 (x_own_selection, Fx_disown_selection_internal): Rename locals
8512 (x_handle_dnd_message): Remove local to avoid shadowing.
8514 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8515 so that the caller can use some name other than gcpro1.
8516 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8517 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8518 (Fx_backspace_delete_keys_p):
8519 Use them to avoid shadowing, and rename vars to avoid shadowing.
8520 (x_decode_color, x_set_name, x_window): Now static.
8521 (Fx_create_frame): Add braces to silence GCC warning.
8522 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8523 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8524 Remove unused locals.
8525 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8526 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8527 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8530 * xterm.h (x_mouse_leave): New decl.
8532 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8533 Remove unused functions.
8534 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8535 (x_calc_absolute_position): Now static.
8536 (XTread_socket): Don't define label "out" unless it's used.
8537 Don't declare local "event" unless it's used.
8538 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8539 unless they are used.
8540 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8541 (x_fatal_error_signal): Remove; not used.
8542 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8543 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8544 (x_error_catcher, x_connection_closed, x_error_handler):
8545 (x_error_quitter, xembed_send_message, x_iconify_frame):
8546 (my_log_handler): Rename locals to avoid shadowing.
8547 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8548 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8550 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8551 Rename or move locals to avoid shadowing.
8552 (tty_defined_color, merge_face_heights): Now static.
8553 (free_realized_faces_for_fontset): Remove; not used.
8554 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8555 does not deduce is never used uninitialized.
8556 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8557 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8559 * terminal.c (store_terminal_param): Now static.
8561 * xmenu.c (menu_highlight_callback): Now static.
8562 (set_frame_menubar): Remove unused local.
8563 (xmenu_show): Rename parameter to avoid shadowing.
8564 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8565 since they might point to immutable storage.
8566 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8567 since it's unused otherwise.
8569 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8570 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8571 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8572 avoids a gcc -Wuninitialized diagnostic.
8573 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8574 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8575 does not deduce are never used uninitialized.
8577 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8579 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8580 * window.c (window_loop, size_window):
8581 (run_window_configuration_change_hook, enlarge_window): Likewise.
8583 * window.c (display_buffer): Now static.
8584 (size_window): Mark variables that gcc -Wuninitialized
8585 does not deduce are never used uninitialized.
8586 * window.h (check_all_windows): New decl, to forestall
8587 gcc -Wmissing-prototypes diagnostic.
8588 * dispextern.h (bidi_dump_cached_states): Likewise.
8590 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8592 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8594 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8595 and to avoid gcc -Wuninitialized warning.
8596 (load_charset_map): Mark variables that gcc -Wuninitialized
8597 does not deduce are never used uninitialized.
8598 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8600 * coding.c (coding_set_source, coding_set_destination):
8601 Use "else { /* comment */ }" rather than "else /* comment */;"
8602 for clarity, and to avoid gcc -Wempty-body warning.
8603 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8604 a block, when the outer 'i' will do.
8605 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8606 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8607 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8608 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8609 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8610 Rename locals to avoid shadowing.
8611 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8612 * coding.c (emacs_mule_char, encode_invocation_designation):
8613 Now static, since they're not used elsewhere.
8614 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8615 (decode_coding_object, encode_coding_object, detect_coding_system):
8616 (decode_coding_emacs_mule): Mark variables that gcc
8617 -Wuninitialized does not deduce are never used uninitialized.
8618 (detect_coding_iso_2022): Initialize a local variable that might
8619 be used uninitialized. Leave a FIXME because it's not clear that
8620 this initialization is needed. (Bug#8211)
8621 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8622 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8623 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8624 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8625 Remove unused macros.
8627 * category.c (hash_get_category_set): Remove unused local var.
8628 (copy_category_table): Now static, since it's not used elsewhere.
8629 * character.c (string_count_byte8): Likewise.
8631 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8632 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8634 * chartab.c (copy_sub_char_table): Now static, since it's not used
8636 (sub_char_table_ref_and_range, char_table_ref_and_range):
8637 Rename locals to avoid shadowing.
8638 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8640 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8641 (BIDI_BOB): Remove unused macro.
8643 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8644 deduce are never used uninitialized.
8645 * term.c (encode_terminal_code): Likewise.
8647 * term.c (encode_terminal_code): Now static. Remove unused local.
8649 * tparam.h: New file.
8650 * term.c, tparam.h: Include it.
8651 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8652 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8653 Move these decls to tparam.h, and make them agree with what
8654 is actually in tparam.c. The previous trick of using incompatible
8655 decls in different modules does not conform to the C standard.
8656 All callers of tparam changed to use tparam's actual API.
8657 * tparam.c (tparam1, tparam, tgoto):
8658 Use const pointers where appropriate.
8660 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8661 * cm.h (struct cm): Likewise.
8662 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8663 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8664 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8665 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8666 (turn_on_face, init_tty): Likewise.
8667 * termchar.h (struct tty_display_info): Likewise.
8669 * term.c (term_mouse_position): Rename local to avoid shadowing.
8671 * alloc.c (mark_ttys): Move decl from here ...
8672 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8674 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8676 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8678 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8680 * search.c (compile_pattern_1): Remove argument regp, unused since
8681 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8682 (compile_pattern): Don't pass it.
8684 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8686 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8687 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8689 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8691 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8693 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8694 gdk_window_get_screen, gdk_window_get_geometry,
8695 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8696 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8697 (xg_get_pixbuf_from_pixmap): New function.
8698 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8699 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8700 Call xg_get_pixbuf_from_pixmap instead of
8701 gdk_pixbuf_get_from_drawable.
8702 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8703 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8704 (xg_check_special_colors): Use GtkStyleContext and its functions
8706 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8707 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8708 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8709 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8710 Call gtk_widget_get_preferred_size.
8711 (xg_frame_resized): gdk_window_get_geometry only takes 5
8713 (xg_win_to_widget, xg_event_is_for_menubar):
8714 Call gdk_x11_window_lookup_for_display.
8715 (xg_set_widget_bg): New function.
8716 (delete_cb): New function.
8717 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8718 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
8719 (xg_set_background_color): Call xg_set_widget_bg.
8720 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8721 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8722 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8723 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8725 (update_frame_tool_bar): Call gtk_widget_hide.
8726 (xg_initialize): Use GDK_KEY_g.
8728 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8730 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8732 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8733 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8734 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8736 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8738 * w32xfns.c (select_palette): Check success of RealizePalette against
8739 GDI_ERROR, not zero.
8741 See ChangeLog.11 for earlier changes.
8747 Copyright (C) 2011 Free Software Foundation, Inc.
8749 This file is part of GNU Emacs.
8751 GNU Emacs is free software: you can redistribute it and/or modify
8752 it under the terms of the GNU General Public License as published by
8753 the Free Software Foundation, either version 3 of the License, or
8754 (at your option) any later version.
8756 GNU Emacs is distributed in the hope that it will be useful,
8757 but WITHOUT ANY WARRANTY; without even the implied warranty of
8758 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8759 GNU General Public License for more details.
8761 You should have received a copy of the GNU General Public License
8762 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.