2 * Copyright 2010, INRIA, University of Copenhagen
3 * Julia Lawall, Rene Rydhof Hansen, Gilles Muller, Nicolas Palix
4 * Copyright 2005-2009, Ecole des Mines de Nantes, University of Copenhagen
5 * Yoann Padioleau, Julia Lawall, Rene Rydhof Hansen, Henrik Stuart, Gilles Muller, Nicolas Palix
6 * This file is part of Coccinelle.
8 * Coccinelle is free software: you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation, according to version 2 of the License.
12 * Coccinelle is distributed in the hope that it will be useful,
13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 * GNU General Public License for more details.
17 * You should have received a copy of the GNU General Public License
18 * along with Coccinelle. If not, see <http://www.gnu.org/licenses/>.
20 * The authors reserve the right to distribute this or future versions of
21 * Coccinelle under other licenses.
26 * Copyright 2010, INRIA, University of Copenhagen
27 * Julia Lawall, Rene Rydhof Hansen, Gilles Muller, Nicolas Palix
28 * Copyright 2005-2009, Ecole des Mines de Nantes, University of Copenhagen
29 * Yoann Padioleau, Julia Lawall, Rene Rydhof Hansen, Henrik Stuart, Gilles Muller, Nicolas Palix
30 * This file is part of Coccinelle.
32 * Coccinelle is free software: you can redistribute it and/or modify
33 * it under the terms of the GNU General Public License as published by
34 * the Free Software Foundation, according to version 2 of the License.
36 * Coccinelle is distributed in the hope that it will be useful,
37 * but WITHOUT ANY WARRANTY; without even the implied warranty of
38 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
39 * GNU General Public License for more details.
41 * You should have received a copy of the GNU General Public License
42 * along with Coccinelle. If not, see <http://www.gnu.org/licenses/>.
44 * The authors reserve the right to distribute this or future versions of
45 * Coccinelle under other licenses.
49 (* ---------------------------------------------------------------- *)
50 (* code to check for ambiguities *)
52 (* Idea: for each node that is said to be modified in any witness tree, we
53 check that all backward paths end up at the root of some witness tree
54 that says that the node should be modified. We then give a warning, if
55 the node itself appears more than once in such a path, because then there
56 could be some instances that are modified and some that are not. An
57 example is as follows:
59 f(); ... g(); ... - h();
61 with C code: f(); while(E) { h(); g(); } g(); h();
63 Then the h() in the while loop matches both the first ... and the - h();
65 Concretely, if a node 47 is in the witness tree rooted at 1 and the
66 witness tree rooted at 2, then we give an error if 47 is not in the set
67 of nodes satisfying AF[1v2] and give a warning if 47 is in the set of
68 nodes satisfying EXEF(47 & EXEF(1v2)). (Note that the root of a witness
69 tree here is the node causing the pattern to match; there might not be
70 any witnesses associated with this node.)
72 Another try on the exists formula:
73 !(1v2) & EXE[!(1v2) U 47]
74 The first !(1v2) is to discard immediately cases where the beginning and
75 end of the path are the same. Afterwards, it would only seem necessary to
76 serach up to the next occurrence of 47 (leaf), ensuring that there are not
77 1s or 2s (starting points) along the way. Then the second 47 would be in
78 the path, but possible not transformed.
81 module G
= Ograph_extended
84 (* Step 1: for each tree, make a mapping from the modified nodes to the root
87 let modified = (Hashtbl.create
(25) : (G.nodei
, G.nodei list
ref) Hashtbl.t
)
89 let build_modified (n
,_
,wits
) =
90 let rec loop = function
91 CTL.Wit
(st
,[CTL.Subst
(x
,Wrapper_ctl.PredVal
(CTL.Modif
(v
)))],anno
,wit
) ->
93 try Hashtbl.find
modified st
95 let cell = ref [] in Hashtbl.add
modified st
cell; cell in
98 | CTL.Wit
(st
,_
,anno
,wit
) -> List.iter
loop wit
99 | CTL.NegWit
(wit
) -> () in
102 (* Step 2: For each node in the hash table, create the error and warning
105 type 'a nodes
= Node
of 'a
| After
107 let create_formulas _
=
115 (Ast_ctl.BACKWARD,wrap(Ast_ctl.EF(Ast_ctl.BACKWARD,f)))) in*)
116 let match_node = Ast_ctl.Pred
(Node
(node
)) in
118 List.map
(function n
-> Ast_ctl.Pred
(Node
(n
)))
119 (List.sort compare
!roots
) in
122 (function prev
-> function cur
-> Ast_ctl.Or
(prev
,cur
))
123 (List.hd
match_roots) (List.tl
match_roots) in
124 (* no point to search if no path, and the presence of after
125 in the AF formula can make things slow *)
126 if List.mem node
!roots
130 Ast_ctl.AF
(Ast_ctl.BACKWARD
,Ast_ctl.NONSTRICT
,
131 Ast_ctl.Or
(or_roots,Ast_ctl.Pred
(After
))),
134 Ast_ctl.Not
(or_roots),
137 Ast_ctl.EU
(Ast_ctl.BACKWARD
,or_roots,match_node))))
139 (wrap(Ast_ctl.And(Ast_ctl.NONSTRICT,match_node,exef(roots))))*)
143 (* Step 3: check the formula on the control-flow graph *)
147 type t
= Ograph_extended.nodei nodes
148 let print_predicate = function
149 After
-> Format.print_string
"after"
150 | Node x
-> Format.print_string
(string_of_int x
)
157 let eq_mvar x x'
= failwith
"should not be invoked"
158 let eq_val v v'
= failwith
"should not be invoked"
159 let merge_val v v'
= failwith
"should not be invoked"
161 let print_mvar s
= failwith
"should not be invoked"
162 let print_value x
= failwith
"should not be invoked"
168 type node
= Ograph_extended.nodei
170 (Control_flow_c.node
, Control_flow_c.edge
)
171 Ograph_extended.ograph_mutable
172 let predecessors cfg n
= List.map fst
((cfg#
predecessors n
)#tolist
)
173 let successors cfg n
= List.map fst
((cfg#
successors n
)#tolist
)
174 let extract_is_loop cfg n
=
175 Control_flow_c.extract_is_loop (cfg#nodes#find n
)
176 let print_node i
= Format.print_string
(string_of_int i
)
177 let size cfg
= cfg#nodes#length
178 let print_graph cfg label border_nodes fill_nodes filename
= ()
181 module ENGINE
= Ctl_engine.CTL_ENGINE
(ENV
) (CFG
) (PRED
)
183 let test_formula state formula cfg
=
185 Node pred
-> [(pred
,[],[])]
189 (fun (nodei
, node
) ->
190 match Control_flow_c.unwrap node
with
191 Control_flow_c.AfterNode
-> [(nodei
,[],[])]
194 let verbose = !Flag_ctl.verbose_ctl_engine
in
195 let pm = !Flag_ctl.partial_match
in
196 (* let gt = !Flag_ctl.graphical_trace in *)
197 Flag_ctl.verbose_ctl_engine
:= false;
198 Flag_ctl.partial_match
:= false;
199 Flag_ctl.checking_reachability
:= true;
200 (* Flag_ctl.graphical_trace := ""; *)
202 ENGINE.sat
(cfg
,label,List.map fst cfg#nodes#tolist
)
203 (CTL.And
(CTL.NONSTRICT
,CTL.Pred
(Node
(state
)),formula
))
205 Flag_ctl.verbose_ctl_engine
:= verbose;
206 Flag_ctl.partial_match
:= pm;
207 Flag_ctl.checking_reachability
:= false;
208 (* Flag_ctl.graphical_trace := gt; *)
209 match res with [] -> false | _
-> true
211 (* ---------------------------------------------------------------- *)
214 (* The argument is a list of triples with a node name, an empty environment
215 and a witness tree *)
218 (Ograph_extended.nodei
, unit,
219 (Ograph_extended.nodei
, unit, unit) Ast_ctl.generic_ctl list
)
220 Ast_ctl.generic_witnesstree
222 type ('a
,'b
,'c
,'d
,'e
) triples
=
223 (Ograph_extended.nodei
* 'a
*
224 (Ograph_extended.nodei
,
225 ('b
, ('c
, 'd
) Wrapper_ctl.wrapped_binding
) CTL.generic_subst list
, 'e
)
226 CTL.generic_witnesstree list
) list
228 let check_reachability triples cfg
=
229 Hashtbl.clear
modified;
230 List.iter
build_modified triples
;
231 let formulas = create_formulas() in
233 (function (node
,af_formula
,ef_formula
) ->
234 if test_formula node af_formula cfg
236 if test_formula node ef_formula cfg
238 Printf.printf
"warning: node %d may be inconsistently modified\n"
244 "node %d reachable by inconsistent control-flow paths" node
))