- fix error checking for read in case of failing bzip2/lzma/whatever
Spotted by -Wextra:
bzip2.cc: In member function ‘virtual bool Bzip2Method::Fetch(pkgAcqMethod::FetchItem*)’:
bzip2.cc:108:19: warning: comparison of unsigned expression < 0 is always false
bzip2.cc:111:19: warning: comparison of unsigned expression < 0 is always false
- fix LongDesc handling in LANG=C environment
* apt-pkg/contrib/strutl.cc:
- fix error checking for vsnprintf in its safe variant
+ * methods/bzip2.cc:
+ - fix error checking for read in case of failing bzip2/lzma/whatever
- -- David Kalnischkies <kalnischkies@gmail.com> Mon, 16 Aug 2010 11:35:53 +0200
+ -- David Kalnischkies <kalnischkies@gmail.com> Mon, 16 Aug 2010 12:07:54 +0200
apt (0.7.26~exp12) experimental; urgency=low
while (1)
{
unsigned char Buffer[4*1024];
- unsigned long Count;
- Count = read(GzOut[0],Buffer,sizeof(Buffer));
+ ssize_t Count = read(GzOut[0],Buffer,sizeof(Buffer));
if (Count < 0 && errno == EINTR)
continue;