gnu: icecat: Remove the bundled Onion Browser Button [security].

Fixes <https://bugs.gnu.org/35728>.

The Onion Browser Button (tortm-browser-button@jeremybenthum) version 0.1.8,
available from addons.mozilla.org and bundled with IceCat, malfunctions with
both IceCat 68.9 and Firefox ESR 68.9.  It tells the user that it's connected
to Tor, but fails to route traffic through it.  The same happens on Debian 9
with its "firefox-esr" package.

Remove this extension from IceCat, pending further investigation.

* gnu/packages/gnuzilla.scm (icecat-source): Remove the "data/extensions/
tortm-browser-button@jeremybenthum" directory before running makeicecat.

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 0a8edcb..3bffe12 100644 (file)
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -648,6 +648,12 @@ from forcing GEXP-PROMISE."
                           "-p1" "--input" #+makeicecat-patch)
                   (invoke "patch" "--force" "--no-backup-if-mismatch"
                           "-p1" "--input" #+gnuzilla-fixes-patch)
+
+                  ;; Remove the bundled tortm-browser-button extension,
+                  ;; which doesn't seem to be working properly.
+                  (delete-file-recursively
+                   "data/extensions/tortm-browser-button@jeremybenthum")
+
                   (patch-shebang "makeicecat")
                   (substitute* "makeicecat"
                     (("^FFMAJOR=(.*)" all ffmajor)