(listify-key-sequence-1, event-modifiers): Don't presume internal bit layout

[bpt/emacs.git] / lisp / novice.el

diff --git a/lisp/novice.el b/lisp/novice.el
index 9849fd4..0d23f26 100644 (file)
--- a/lisp/novice.el
+++ b/lisp/novice.el
@@ -1,9 +1,9 @@
 ;;; novice.el --- handling of disabled commands ("novice mode") for Emacs.
 
-;; Maintainer: FSF
-;; Last-Modified: 22 May 1991
+;; Copyright (C) 1985, 1986, 1987, 1994 Free Software Foundation, Inc.
 
-;; Copyright (C) 1985, 1986, 1987 Free Software Foundation, Inc.
+;; Maintainer: FSF
+;; Keywords: internal, help
 
 ;; This file is part of GNU Emacs.
 
@@ -21,7 +21,13 @@
 ;; along with GNU Emacs; see the file COPYING.  If not, write to
 ;; the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
 
-;; Code:
+;;; Commentary:
+
+;; This mode provides a hook which is, by default, attached to various
+;; putatively dangerous commands in a (probably futile) attempt to
+;; prevent lusers from shooting themselves in the feet.
+
+;;; Code:
 
 ;; This function is called (by autoloading)
 ;; to handle any disabled command.
@@ -36,7 +42,10 @@
   (let (char)
     (save-window-excursion
      (with-output-to-temp-buffer "*Help*"
-       (if (= (aref (this-command-keys) 0) ?\M-x)
+       (if (eq (aref (this-command-keys) 0)
+              (if (stringp (this-command-keys))
+                  (aref "\M-x" 0)
+                ?\M-x))
           (princ "You have invoked the disabled command ")
         (princ "You have typed ")
         (princ (key-description (this-command-keys)))
@@ -62,7 +71,10 @@
 Space to try the command just this once,
       but leave it disabled,
 Y to try it and enable it (no questions if you use it again),
-N to do nothing (command remains disabled)."))
+N to do nothing (command remains disabled).")
+       (save-excursion
+       (set-buffer standard-output)
+       (help-mode)))
      (message "Type y, n or Space: ")
      (let ((cursor-in-echo-area t))
        (while (not (memq (setq char (downcase (read-char)))
@@ -70,7 +82,9 @@ N to do nothing (command remains disabled)."))
         (ding)
         (message "Please type y, n or Space: "))))
     (if (= char ?y)
-       (if (y-or-n-p "Enable command for future editing sessions also? ")
+       (if (and user-init-file
+                (not (string= "" user-init-file))
+                (y-or-n-p "Enable command for future editing sessions also? "))
            (enable-command this-command)
          (put this-command 'disabled nil)))
     (if (/= char ?n)
@@ -84,16 +98,17 @@ to future sessions."
   (interactive "CEnable command: ")
   (put command 'disabled nil)
   (save-excursion
-   (set-buffer (find-file-noselect (substitute-in-file-name "~/.emacs")))
+   (set-buffer (find-file-noselect
+               (substitute-in-file-name user-init-file)))
    (goto-char (point-min))
    (if (search-forward (concat "(put '" (symbol-name command) " ") nil t)
        (delete-region
        (progn (beginning-of-line) (point))
-       (progn (forward-line 1) (point)))
-     ;; Must have been disabled by default.
-     (goto-char (point-max))
-     (insert "\n(put '" (symbol-name command) " 'disabled nil)\n"))
-   (setq foo (buffer-modified-p))
+       (progn (forward-line 1) (point))))
+   ;; Explicitly enable, in case this command is disabled by default
+   ;; or in case the code we deleted was actually a comment.
+   (goto-char (point-max))
+   (insert "\n(put '" (symbol-name command) " 'disabled nil)\n")
    (save-buffer)))
 
 ;;;###autoload
@@ -102,16 +117,19 @@ to future sessions."
 The user's .emacs file is altered so that this will apply
 to future sessions."
   (interactive "CDisable command: ")
+  (if (not (commandp command))
+      (error "Invalid command name `%s'" command))
   (put command 'disabled t)
   (save-excursion
-   (set-buffer (find-file-noselect (substitute-in-file-name "~/.emacs")))
+   (set-buffer (find-file-noselect
+               (substitute-in-file-name user-init-file)))
    (goto-char (point-min))
    (if (search-forward (concat "(put '" (symbol-name command) " ") nil t)
        (delete-region
        (progn (beginning-of-line) (point))
        (progn (forward-line 1) (point))))
    (goto-char (point-max))
-   (insert "(put '" (symbol-name command) " 'disabled t)\n")
+   (insert "\n(put '" (symbol-name command) " 'disabled t)\n")
    (save-buffer)))
 
 ;;; novice.el ends here