| 1 | 2011-08-25 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | |
| 3 | Integer and memory overflow issues (Bug#9196). |
| 4 | |
| 5 | * doc.c (get_doc_string): Rework so that |
| 6 | get_doc_string_buffer_size is the actual buffer size, rather than |
| 7 | being 1 less than the actual buffer size; this makes xpalloc more |
| 8 | convenient. |
| 9 | |
| 10 | * image.c (x_allocate_bitmap_record, cache_image): |
| 11 | * xselect.c (Fx_register_dnd_atom): |
| 12 | Simplify previous changes by using xpalloc. |
| 13 | |
| 14 | * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT, |
| 15 | since either will do and ptrdiff_t is convenient with xpalloc. |
| 16 | |
| 17 | * charset.c (charset_table_size) |
| 18 | (struct charset_sort_data.priority): Now ptrdiff_t. |
| 19 | (charset_compare): Don't overflow if priorities differ greatly. |
| 20 | (Fsort_charsets): Don't assume list length fits in int. |
| 21 | Check for size-calculation overflow when allocating sort data. |
| 22 | (syms_of_charset): Allocate an initial charset table that is |
| 23 | just under 64 KiB, to avoid problems with glibc malloc and mmap. |
| 24 | |
| 25 | * cmds.c (internal_self_insert): Check for size-calculation overflow. |
| 26 | |
| 27 | * composite.h (struct composition.glyph_len): Now int, not unsigned. |
| 28 | The actual value is always <= INT_MAX, and leaving it unsigned made |
| 29 | overflow checking harder. |
| 30 | |
| 31 | * dispextern.h (struct glyph_matrix.rows_allocated) |
| 32 | (struct face_cache.size): Now ptrdiff_t, for convenience in use |
| 33 | with xpalloc. The values are still always <= INT_MAX. |
| 34 | |
| 35 | * indent.c (compute_motion): Adjust to region_cache_forward sig change. |
| 36 | |
| 37 | * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls. |
| 38 | (SAFE_NALLOCA): New macro. |
| 39 | |
| 40 | * region-cache.c (struct boundary.pos, find_cache_boundary) |
| 41 | (move_cache_gap, insert_cache_boundary, delete_cache_boundaries) |
| 42 | (set_cache_region, invalidate_region_cache) |
| 43 | (revalidate_region_cache, know_region_cache, region_cache_forward) |
| 44 | (region_cache_backward, pp_cache): |
| 45 | Use ptrdiff_t, not EMACS_INT, since either will do. This is needed |
| 46 | so that ptrdiff_t * can be passed to xpalloc. |
| 47 | (struct region_cache): Similarly, for gap_start, gap_len, cache_len, |
| 48 | beg_unchanged, end_unchanged, buffer_beg, buffer_end members. |
| 49 | (pp_cache): Don't assume cache_len fits in int. |
| 50 | * region-cache.h: Adjust extern decls to match. |
| 51 | |
| 52 | * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not |
| 53 | EMACS_INT, since either will do, for xpalloc. |
| 54 | |
| 55 | * alloc.c: Include verify.h, and check that int fits in ptrdiff_t. |
| 56 | (xnmalloc, xnrealloc, xpalloc): New functions. |
| 57 | |
| 58 | * bidi.c (bidi_shelve_header_size): New constant. |
| 59 | (bidi_cache_ensure_space, bidi_shelve_cache): Use it. |
| 60 | (bidi_cache_ensure_space): Avoid integer overflow when allocating. |
| 61 | |
| 62 | * bidi.c (bidi_cache_shrink): |
| 63 | * buffer.c (overlays_at, overlays_in, record_overlay_string) |
| 64 | (overlay_strings): |
| 65 | Don't update size of array until after memory allocation succeeds, |
| 66 | because xmalloc/xrealloc may not return. |
| 67 | (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help |
| 68 | now that we have proper integer overflow checking. |
| 69 | (record_overlay_string, overlay_strings): Catch overflows when |
| 70 | calculating size of overlay_str_buf. |
| 71 | |
| 72 | * callproc.c (Fcall_process): Check for size overflow when |
| 73 | calculating size of args2. |
| 74 | (child_setup): Avoid overflow by using size_t rather than ptrdiff_t. |
| 75 | Normally we prefer signed values, but sticking with ptrdiff_t would |
| 76 | require adding more-complicated checks. |
| 77 | |
| 78 | * ccl.c (Fccl_execute_on_string): Check for memory overflow. |
| 79 | Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do. |
| 80 | Redo buffer-overflow calculations to avoid integer overflow. |
| 81 | Add a FIXME comment where memory seems to be over-allocated. |
| 82 | |
| 83 | * character.c (Fstring): Check for size-calculation overflow. |
| 84 | |
| 85 | * coding.c (produce_chars): Redo buffer-overflow calculations to avoid |
| 86 | unnecessary integer overflow. Check for size overflow. |
| 87 | (encode_coding_object): Don't update size until xmalloc succeeds. |
| 88 | |
| 89 | * composite.c (get_composition_id): Check for overflow in glyph |
| 90 | length calculations. |
| 91 | |
| 92 | Integer and memory overflow fixes for display code. |
| 93 | * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int. |
| 94 | * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool) |
| 95 | (scrolling_window): Check for overflow in size calculations. |
| 96 | (line_draw_cost, realloc_glyph_pool, add_row_entry): |
| 97 | Don't assume glyph table len fits in int. |
| 98 | (struct row_entry.bucket, row_entry_pool_size, row_entry_idx) |
| 99 | (row_table_size): Now ptrdiff_t, not int. |
| 100 | (scrolling_window): Avoid overflow in size calculations. |
| 101 | Don't update size until allocation succeeds. |
| 102 | * fns.c (concat): Check for overflow in size calculations. |
| 103 | (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT. |
| 104 | * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros. |
| 105 | (NEXT_ALMOST_PRIME_LIMIT): New constant. |
| 106 | |
| 107 | * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int. |
| 108 | (get_doc_string): Check for size calculation overflow. |
| 109 | Don't update size until allocation succeeds. |
| 110 | (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not |
| 111 | EMACS_INT, where ptrdiff_t will do. |
| 112 | (Fsubstitute_command_keys): Check for string overflow. |
| 113 | |
| 114 | * editfns.c (set_time_zone_rule): Don't assume environment length |
| 115 | fits in int. |
| 116 | (message_length): Now ptrdiff_t, not int. |
| 117 | (Fmessage_box): Don't update size until allocation succeeds. |
| 118 | Don't assume message length fits in int. |
| 119 | (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do. |
| 120 | |
| 121 | * emacs.c (main): Do not reallocate argv, since there is a null at |
| 122 | the end that can be overwritten, and this way there's no need to |
| 123 | worry about size-calculation overflow. |
| 124 | (sort_args): Check for size-calculation overflow. |
| 125 | |
| 126 | * eval.c (init_eval_once, grow_specpdl): Don't update size until |
| 127 | alloc succeeds. |
| 128 | (call_debugger, grow_specpdl): Redo calculations to avoid overflow. |
| 129 | |
| 130 | * frame.c (set_menu_bar_lines, x_set_frame_parameters) |
| 131 | (x_set_scroll_bar_width, x_figure_window_size): |
| 132 | Check for integer overflow. |
| 133 | (x_set_alpha): Do not assume XINT fits in int. |
| 134 | |
| 135 | * frame.h (struct frame): Use int, not EMACS_INT, where int works. |
| 136 | This is for the members text_lines, text_cols, total_lines, total_cols, |
| 137 | where the system imposes an 'int' limit. |
| 138 | |
| 139 | * fringe.c (Fdefine_fringe_bitmap): |
| 140 | Don't update size until alloc works. |
| 141 | |
| 142 | * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring) |
| 143 | (ftfont_shape_by_flt): Check for integer overflow in size calculations. |
| 144 | |
| 145 | * gtkutil.c (get_utf8_string, xg_store_widget_in_map): |
| 146 | Check for size-calculation overflow. |
| 147 | (get_utf8_string): Use ptrdiff_t, not size_t, where either will |
| 148 | do, as we prefer signed integers. |
| 149 | (id_to_widget.max_size, id_to_widget.used) |
| 150 | (xg_store_widget_in_map, xg_remove_widget_from_map) |
| 151 | (xg_get_widget_from_map, xg_get_scroll_id_for_window) |
| 152 | (xg_remove_scroll_bar, xg_update_scrollbar_pos): |
| 153 | Use and return ptrdiff_t, not int. |
| 154 | (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int. |
| 155 | * gtkutil.h: Change prototypes to match the above. |
| 156 | |
| 157 | * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these |
| 158 | are duplicate now that they've been promoted to lisp.h. |
| 159 | (x_allocate_bitmap_record, x_alloc_image_color) |
| 160 | (make_image_cache, cache_image, xpm_load): |
| 161 | Don't update size until alloc is done. |
| 162 | (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors) |
| 163 | (x_detect_edges): |
| 164 | Check for size calculation overflow. |
| 165 | (ct_colors_allocated_max): New constant. |
| 166 | (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid |
| 167 | overflow. |
| 168 | |
| 169 | * keyboard.c (read_char, menu_bar_items, tool_bar_items) |
| 170 | (read_char_x_menu_prompt, read_char_minibuf_menu_width) |
| 171 | (read_char_minibuf_menu_prompt, follow_key, read_key_sequence): |
| 172 | Use ptrdiff_t, not int, to count maps. |
| 173 | (read_char_minibuf_menu_prompt): Check for overflow in size |
| 174 | calculations. Don't update size until allocation succeeds. Redo |
| 175 | calculations to avoid overflow. |
| 176 | * keyboard.h: Change prototypes to match the above. |
| 177 | |
| 178 | * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int, |
| 179 | to count maps. |
| 180 | (current_minor_maps): Check for size calculation overflow. |
| 181 | * keymap.h: Change prototypes to match the above. |
| 182 | |
| 183 | * lread.c (read1, init_obarray): Don't update size until alloc done. |
| 184 | |
| 185 | * macros.c (Fstart_kbd_macro): Don't update size until alloc done. |
| 186 | (store_kbd_macro_char): Reorder multiplicands to avoid overflow. |
| 187 | |
| 188 | * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail): |
| 189 | Now ptrdiff_t, not int. |
| 190 | * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes. |
| 191 | (ns_draw_fringe_bitmap): Rewrite to avoid overflow. |
| 192 | |
| 193 | * process.c (Fnetwork_interface_list): Check for overflow |
| 194 | in size calculation. |
| 195 | |
| 196 | * region-cache.c (move_cache_gap): Check for size calculation overflow. |
| 197 | |
| 198 | * scroll.c (do_line_insertion_deletion_costs): Check for size calc |
| 199 | overflow. Don't bother calling xmalloc when xrealloc will do. |
| 200 | |
| 201 | * search.c (Freplace_match): Check for size calculation overflow. |
| 202 | (Fset_match_data): Don't assume list lengths fit in 'int'. |
| 203 | |
| 204 | * sysdep.c (system_process_attributes): Use ptrdiff_t, not int, |
| 205 | for command line length. Do not attempt to address one before the |
| 206 | beginning of an array, as that's not portable. |
| 207 | |
| 208 | * term.c (max_frame_lines): Remove; unused. |
| 209 | (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t, |
| 210 | not int. |
| 211 | (encode_terminal_code, calculate_costs): Check for size |
| 212 | calculation overflow. |
| 213 | (encode_terminal_code): Use ptrdiff_t, not int, to record glyph |
| 214 | table lengths and related sizes. Don't update size until alloc |
| 215 | done. Redo calculations to avoid overflow. |
| 216 | (calculate_costs): Don't bother calling xmalloc when xrealloc will do. |
| 217 | |
| 218 | * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of |
| 219 | subtracting pointers. |
| 220 | (gobble_line): Check for overflow more carefully. Don't update size |
| 221 | until alloc done. |
| 222 | |
| 223 | * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes. |
| 224 | Don't update size until alloc done. |
| 225 | Redo size calculations to avoid overflow. |
| 226 | Check for size calculation overflow. |
| 227 | (main) [DEBUG]: Fix typo in invoking tparam1. |
| 228 | |
| 229 | * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title): |
| 230 | Use ptrdiff_t, not int, for sizes. |
| 231 | (store_mode_line_noprop_char): Don't update size until alloc done. |
| 232 | |
| 233 | * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face): |
| 234 | Use ptrdiff_t, not int, for sizes. |
| 235 | (Finternal_make_lisp_face, cache_face): |
| 236 | Check for size calculation overflow. |
| 237 | (cache_face): Treat size calculation overflows as if they were |
| 238 | memory exhaustion (the usual treatment), rather than aborting. |
| 239 | |
| 240 | * xfns.c (x_encode_text, x_set_name_internal) |
| 241 | (Fx_change_window_property): Use ptrdiff_t, not int, to count |
| 242 | sizes, since they can exceed INT_MAX in size. Check for size |
| 243 | calculation overflow. |
| 244 | |
| 245 | * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc. |
| 246 | (xg_select): Check for size calculation overflow. |
| 247 | Don't update size until alloc done. |
| 248 | |
| 249 | * xrdb.c (get_environ_db): Don't assume path length fits in int, |
| 250 | as sprintf is limited to int lengths. |
| 251 | |
| 252 | * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX) |
| 253 | (X_LONG_MIN): New macros. |
| 254 | Use them to make the following changes clearer. |
| 255 | (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer. |
| 256 | This change doesn't affect the value now, but it may help remind |
| 257 | future maintainers not to raise the value too much later. |
| 258 | (SELECTION_QUANTUM): Remove, replacing with ... |
| 259 | (selection_quantum): ... new function, which avoids overflow. |
| 260 | All uses changed. |
| 261 | (struct selection_data.size): Now ptrdiff_t, not int, to avoid |
| 262 | assumption that selection length fits in 'int'. |
| 263 | (x_reply_selection_request, x_handle_selection_request) |
| 264 | (x_get_window_property, receive_incremental_selection) |
| 265 | (x_get_window_property_as_lisp_data, selection_data_to_lisp_data) |
| 266 | (lisp_data_to_selection_data, clean_local_selection_data): |
| 267 | Use ptrdiff_t, not int, to record length of selection. |
| 268 | (x_reply_selection_request, x_get_window_property) |
| 269 | (receive_incremental_selection, x_property_data_to_lisp): |
| 270 | Redo calculations to avoid overflow. |
| 271 | (x_reply_selection_request): When sending hint, ceiling it at |
| 272 | X_LONG_MAX rather than relying on wraparound overflow to send |
| 273 | something. |
| 274 | (x_get_window_property, receive_incremental_selection) |
| 275 | (lisp_data_to_selection_data, x_property_data_to_lisp): |
| 276 | Check for size-calculation overflow. |
| 277 | (x_get_window_property, receive_incremental_selection) |
| 278 | (lisp_data_to_selection_data, Fx_register_dnd_atom): |
| 279 | Don't store size until memory allocation succeeds. |
| 280 | (x_get_window_property): Plug memory leak on memory exhaustion. |
| 281 | Don't double-block input; malloc is safe here. Don't assume 2**34 |
| 282 | - 4 fits in unsigned long. Add an xassert to check |
| 283 | XGetWindowProperty overflow. Be more careful about overflow |
| 284 | calculations, and distinguish size from memory overflow better. |
| 285 | (receive_incremental_selection): When tracing, don't assume |
| 286 | unsigned int is less than INT_MAX. |
| 287 | (x_selection_data_to_lisp_data): Remove unnecessary (and in theory |
| 288 | harmful) conversions of unsigned short to int. |
| 289 | (lisp_data_to_selection_data): Don't assume that integers |
| 290 | in the range -65535 through -1 fit in an X unsigned short. |
| 291 | Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into |
| 292 | result parameters unless successful. Rely on cons_to_unsigned |
| 293 | to report problems with elements; the old code wasn't right anyway. |
| 294 | (x_check_property_data): Check for int overflow; we cannot use |
| 295 | a wider type due to X limits. |
| 296 | (x_handle_dnd_message): Use unsigned int, to avoid int overflow. |
| 297 | |
| 298 | * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow. |
| 299 | |
| 300 | * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent) |
| 301 | (x_term_init): Check for size calculation overflow. |
| 302 | (x_color_cells): Don't store size until memory allocation succeeds. |
| 303 | (handle_one_xevent): Use ptrdiff_t, not int, for byte counts. |
| 304 | Don't assume alloca size is less than MAX_ALLOCA. |
| 305 | (x_term_init): Don't assume length fits in int (sprintf is limited |
| 306 | to int size). |
| 307 | |
| 308 | Use ptrdiff_t for composition IDs. |
| 309 | * character.c (lisp_string_width): |
| 310 | * composite.c (composition_table_size, n_compositions) |
| 311 | (get_composition_id, composition_gstring_from_id): |
| 312 | * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id): |
| 313 | * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): |
| 314 | * window.c (Frecenter): |
| 315 | Use ptrdiff_t, not int, for composition IDs. |
| 316 | * composite.c (get_composition_id): Check for integer overflow. |
| 317 | * composite.h: Adjust prototypes to match the above changes. |
| 318 | |
| 319 | Use ptrdiff_t for hash table indexes. |
| 320 | * category.c (hash_get_category_set): |
| 321 | * ccl.c (ccl_driver): |
| 322 | * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID): |
| 323 | * coding.c (coding_system_charset_list, detect_coding_system): |
| 324 | * coding.h (struct coding_system.id): |
| 325 | * composite.c (get_composition_id, gstring_lookup_cache): |
| 326 | * fns.c (hash_lookup, hash_put, Fgethash, Fputhash): |
| 327 | * image.c (xpm_get_color_table_h): |
| 328 | * lisp.h (hash_lookup, hash_put): |
| 329 | * minibuf.c (Ftest_completion): |
| 330 | Use ptrdiff_t for hash table indexes, not int (which is too |
| 331 | narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on |
| 332 | 32-bit --with-wide-int hosts). |
| 333 | |
| 334 | * charset.c (Fdefine_charset_internal): Check for integer overflow. |
| 335 | Add a FIXME comment about memory leaks. |
| 336 | (syms_of_charset): Don't assume xmalloc returns. |
| 337 | |
| 338 | Don't assume that stated character widths fit in int. |
| 339 | * character.c (Fchar_width, c_string_width, lisp_string_width): |
| 340 | * character.h (CHAR_WIDTH): |
| 341 | * indent.c (MULTIBYTE_BYTES_WIDTH): |
| 342 | Use sanitize_char_width to avoid undefined and/or bad behavior |
| 343 | with outlandish widths. |
| 344 | * character.h (sanitize_tab_width): Renamed from sanitize_width, |
| 345 | now that we have two such functions. All uses changed. |
| 346 | (sanitize_char_width): New inline function. |
| 347 | |
| 348 | Don't assume that tab-width fits in int. |
| 349 | * character.h (sanitize_width): New inline function. |
| 350 | (SANE_TAB_WIDTH): New macro. |
| 351 | (ASCII_CHAR_WIDTH): Use it. |
| 352 | * indent.c (sane_tab_width): Remove. All uses replaced by |
| 353 | SANE_TAB_WIDTH (current_buffer). |
| 354 | * xdisp.c (init_iterator): Use SANE_TAB_WIDTH. |
| 355 | |
| 356 | * fileio.c: Integer overflow issues with file modes. |
| 357 | (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int. |
| 358 | |
| 359 | * charset.c (read_hex): New arg OVERFLOW. All uses changed. |
| 360 | Remove unreachable code. |
| 361 | (read_hex, load_charset_map_from_file): Check for integer overflow. |
| 362 | |
| 363 | * xterm.c: don't go over XClientMessageEvent limit |
| 364 | (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed. |
| 365 | (x_send_scroll_bar_event): Likewise. Check that the size does not |
| 366 | exceed limits imposed by XClientMessageEvent, as well as the usual |
| 367 | ptrdiff_t and size_t limits. |
| 368 | |
| 369 | * keyboard.c: Overflow, signedness and related fixes. |
| 370 | (make_lispy_movement): Use same integer type in forward decl |
| 371 | that is used in the definition. |
| 372 | (read_key_sequence, keyremap_step): |
| 373 | Change bufsize argument back to int, undoing my 2011-03-30 change. |
| 374 | We prefer signed types, and int is wide enough here. |
| 375 | (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less |
| 376 | than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow |
| 377 | larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string |
| 378 | length, not size_t. Use ptrdiff_t for index, not int. |
| 379 | (keyremap_step, read_key_sequence): Redo bufsize check to avoid |
| 380 | possibility of integer overflow. |
| 381 | |
| 382 | Overflow, signedness and related fixes for images. |
| 383 | |
| 384 | * dispextern.h (struct it.stack[0].u.image.image_id) |
| 385 | (struct_it.image_id, struct image.id, struct image_cache.size) |
| 386 | (struct image_cache.used, struct image_cache.ref_count): |
| 387 | * gtkutil.c (update_frame_tool_bar): |
| 388 | * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p) |
| 389 | (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image) |
| 390 | (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image): |
| 391 | * nsmenu.m (update_frame_tool_bar): |
| 392 | * xdisp.c (calc_pixel_width_or_height): |
| 393 | * xfns.c (image_cache_refcount): |
| 394 | Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits |
| 395 | on typical 64-bit hosts. |
| 396 | |
| 397 | * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros. |
| 398 | (x_bitmap_pixmap, x_create_x_image_and_pixmap): |
| 399 | Omit unnecessary casts to int. |
| 400 | (parse_image_spec): Check that integers fall into 'int' range |
| 401 | when the callers expect that. |
| 402 | (image_ascent): Redo ascent calculation to avoid int overflow. |
| 403 | (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages. |
| 404 | (lookup_image): Remove unnecessary tests. |
| 405 | (xbm_image_p): Locals are now of int, not EMACS_INT, |
| 406 | since parse_image_check makes sure they fit into int. |
| 407 | (png_load, gif_load, svg_load_image): |
| 408 | Prefer int to unsigned where either will do. |
| 409 | (tiff_handler): New function, combining the cores of the |
| 410 | old tiff_error_handler and tiff_warning_handler. This |
| 411 | function is rewritten to use vsnprintf and thereby avoid |
| 412 | stack buffer overflows. It uses only the features of vsnprintf |
| 413 | that are common to both POSIX and native Microsoft. |
| 414 | (tiff_error_handler, tiff_warning_handler): Use it. |
| 415 | (tiff_load, gif_load, imagemagick_load_image): |
| 416 | Don't assume :index value fits in 'int'. |
| 417 | (gif_load): Omit unnecessary cast to double, and avoid double-rounding. |
| 418 | (imagemagick_load_image): Check that crop parameters fit into |
| 419 | the integer types that MagickCropImage accepts. Don't assume |
| 420 | Vimagemagick_render_type has a nonnegative value. Don't assume |
| 421 | size_t fits in 'long'. |
| 422 | (gs_load): Use printmax_t to print the widest integers possible. |
| 423 | Check for integer overflow when computing image height and width. |
| 424 | |
| 425 | 2011-08-25 Eli Zaretskii <eliz@gnu.org> |
| 426 | |
| 427 | * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when |
| 428 | the display spec is of the form `(space ...)'. |
| 429 | (handle_display_spec): Return the value returned by |
| 430 | handle_single_display_spec, not just 1 or zero. |
| 431 | (handle_single_display_spec): If the display spec is of the form |
| 432 | `(space ...)', and specifies display in the text area, return 2 |
| 433 | rather than 1. |
| 434 | (try_cursor_movement): Check for the need to scroll more |
| 435 | accurately, and prefer exact match for point under bidi. Don't |
| 436 | advance `row' beyond the last row of the window. |
| 437 | |
| 438 | * dispextern.h (struct bidi_it): Rename the disp_prop_p member |
| 439 | into disp_prop; all users changed. |
| 440 | |
| 441 | * bidi.c (bidi_fetch_char): If compute_display_string_pos returns |
| 442 | DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character |
| 443 | for the text covered by the display property. |
| 444 | |
| 445 | 2011-08-25 Chong Yidong <cyd@stupidchicken.com> |
| 446 | |
| 447 | * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer. |
| 448 | Change return value to nil. |
| 449 | (Frecord_buffer): Delete unused function. |
| 450 | |
| 451 | 2011-08-24 Eli Zaretskii <eliz@gnu.org> |
| 452 | |
| 453 | * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte |
| 454 | buffers, return left-to-right. |
| 455 | (set_cursor_from_row): Consider candidate row a win if its glyph |
| 456 | represents a newline and point is on that newline. Fixes cursor |
| 457 | positioning on the newline at EOL of R2L text within L2R |
| 458 | paragraph, and vice versa. |
| 459 | (try_cursor_movement): Check continued rows, in addition to |
| 460 | continuation rows. Fixes unwarranted scroll when point enters a |
| 461 | continued line of R2L text within an L2R paragraph, or vice versa. |
| 462 | (cursor_row_p): Consider the case of point being equal to |
| 463 | MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving |
| 464 | from the end of a short line to the beginning of a continued line |
| 465 | of R2L text within L2R paragraph. |
| 466 | (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for |
| 467 | composed characters. |
| 468 | |
| 469 | * bidi.c (bidi_check_type): Use xassert. |
| 470 | (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p |
| 471 | members. |
| 472 | |
| 473 | 2011-08-23 Eli Zaretskii <eliz@gnu.org> |
| 474 | |
| 475 | * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of |
| 476 | a character. |
| 477 | |
| 478 | 2011-08-23 Chong Yidong <cyd@stupidchicken.com> |
| 479 | |
| 480 | * nsfont.m (ns_otf_to_script): Fix typo. |
| 481 | |
| 482 | 2011-08-22 Kenichi Handa <handa@m17n.org> |
| 483 | |
| 484 | * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a |
| 485 | extra slot even if the purpose is char-code-property-table. |
| 486 | |
| 487 | 2011-08-23 Eli Zaretskii <eliz@gnu.org> |
| 488 | |
| 489 | * xdisp.c (redisplay_window): When computing centering_position, |
| 490 | account for the height of the header line. (Bug#8874) |
| 491 | |
| 492 | * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos |
| 493 | instead of CHAR_TO_BYTE. Fixes a crash when a completion |
| 494 | candidate is selected by the mouse, and that candidate has a |
| 495 | composed character under the mouse. |
| 496 | |
| 497 | * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel |
| 498 | coordinates reported by pos-visible-in-window-p for a composed |
| 499 | character in column zero. |
| 500 | |
| 501 | 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca> |
| 502 | |
| 503 | * cmds.c (Fself_insert_command): Mention post-self-insert-hook. |
| 504 | |
| 505 | 2011-08-22 Eli Zaretskii <eliz@gnu.org> |
| 506 | |
| 507 | * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition, |
| 508 | consider it a hit if to_charpos is anywhere in the range of the |
| 509 | composed buffer positions. |
| 510 | |
| 511 | 2011-08-22 Chong Yidong <cyd@stupidchicken.com> |
| 512 | |
| 513 | * image.c (gif_load): Don't assume that each subimage has the same |
| 514 | dimensions as the base image. Handle disposal method that is |
| 515 | "undefined" by the gif spec (Bug#9335). |
| 516 | |
| 517 | 2011-08-20 Chong Yidong <cyd@stupidchicken.com> |
| 518 | |
| 519 | * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329). |
| 520 | (Fcondition_case): Document `debug' symbol in error handler. |
| 521 | |
| 522 | 2011-08-19 Eli Zaretskii <eliz@gnu.org> |
| 523 | |
| 524 | * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of |
| 525 | face ID by FACE_FROM_ID, and avoid a crash when mouse is moved |
| 526 | from an Org mode buffer to a Speedbar frame. |
| 527 | |
| 528 | * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from |
| 529 | a composition, take its buffer position from IT->cmp_it.charpos. |
| 530 | Fixes cursor positioning at the beginning of a line that begins |
| 531 | with a composed character. |
| 532 | |
| 533 | 2011-08-18 Eli Zaretskii <eliz@gnu.org> |
| 534 | |
| 535 | * bidi.c (bidi_get_type): If bidi_type_table reports zero as the |
| 536 | character bidirectional type, use STRONG_L instead. Fixes crashes |
| 537 | in a buffer produced by `describe-categories'. |
| 538 | |
| 539 | * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p |
| 540 | members before the level stack, so they would be saved and |
| 541 | restored when copying iterator state. Fixes incorrect reordering |
| 542 | around TABs covered by display properties. |
| 543 | |
| 544 | 2011-08-18 Andreas Schwab <schwab@linux-m68k.org> |
| 545 | |
| 546 | * process.c (Fnetwork_interface_list): Correctly determine buffer |
| 547 | size. |
| 548 | |
| 549 | 2011-08-17 Chong Yidong <cyd@stupidchicken.com> |
| 550 | |
| 551 | * eval.c (internal_condition_case, internal_condition_case_1) |
| 552 | (internal_condition_case_2, internal_condition_case_n): |
| 553 | Remove unnecessary aborts (Bug#9081). |
| 554 | |
| 555 | 2011-08-17 Eli Zaretskii <eliz@gnu.org> |
| 556 | |
| 557 | * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file |
| 558 | has no `load' handler, try opening the file locally. (Bug#9311) |
| 559 | |
| 560 | 2011-08-16 Ken Brown <kbrown@cornell.edu> |
| 561 | |
| 562 | * gmalloc.c: Expand comment. |
| 563 | |
| 564 | 2011-08-16 Eli Zaretskii <eliz@gnu.org> |
| 565 | |
| 566 | * xdisp.c (set_cursor_from_row): Don't accept a previous candidate |
| 567 | if it fails the cursor_row_p test. Fixes cursor positioning at ZV. |
| 568 | |
| 569 | 2011-08-16 Ken Brown <kbrown@cornell.edu> |
| 570 | |
| 571 | Fix memory allocation problems in Cygwin build (Bug#9273). |
| 572 | |
| 573 | * unexcw.c ( __malloc_initialized): Declare external variable. |
| 574 | (fixup_executable): Force the dumped emacs to reinitialize malloc. |
| 575 | |
| 576 | * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): |
| 577 | New variables. |
| 578 | (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the |
| 579 | dumped emacs. |
| 580 | (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage |
| 581 | in the static heap. |
| 582 | [CYGWIN] (special_realloc): New function. |
| 583 | (_realloc_internal_nolock) [CYGWIN]: Use the new function on |
| 584 | requests to realloc storage in the static heap. |
| 585 | |
| 586 | 2011-08-15 Paul Eggert <eggert@cs.ucla.edu> |
| 587 | |
| 588 | * bidi.c (bidi_initialize): Remove unused local. |
| 589 | |
| 590 | 2011-08-15 Eli Zaretskii <eliz@gnu.org> |
| 591 | |
| 592 | * biditype.h: File removed. |
| 593 | |
| 594 | * bidimirror.h: File removed. |
| 595 | |
| 596 | * deps.mk (bidi.o): Remove biditype.h and |
| 597 | bidimirror.h. |
| 598 | |
| 599 | * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and |
| 600 | bidimirror.h. |
| 601 | |
| 602 | * dispextern.h: Fix a typo in the comment to bidi_type_t. |
| 603 | |
| 604 | * chartab.c: Improve commentary for the uniprop_table API. |
| 605 | |
| 606 | * bidi.c (bidi_paragraph_init): Support zero value of |
| 607 | bidi_ignore_explicit_marks_for_paragraph_level. |
| 608 | (bidi_initialize): Use uniprop_table instead of including |
| 609 | biditype.h and bidimirror.h. |
| 610 | |
| 611 | * xdisp.c (move_it_in_display_line_to): Don't reset pixel |
| 612 | coordinates of the iterator when restoring from ppos_it. |
| 613 | (Bug#9296) |
| 614 | |
| 615 | 2011-08-14 Kenichi Handa <handa@m17n.org> |
| 616 | |
| 617 | * process.c (create_process): Call setup_process_coding_systems |
| 618 | after the pid of the process is set to -1 (Bug#8162). |
| 619 | |
| 620 | 2011-08-14 Eli Zaretskii <eliz@gnu.org> |
| 621 | |
| 622 | * xdisp.c (move_it_in_display_line_to): Don't invoke |
| 623 | IT_RESET_X_ASCENT_DESCENT when iterator position was restored from |
| 624 | ppos_it. Fixes vertical cursor motion when line beginning is |
| 625 | covered by an image. (Bug#9296) |
| 626 | |
| 627 | 2011-08-14 Jan Djärv <jan.h.d@swipnet.se> |
| 628 | |
| 629 | * nsterm.h (ns_run_ascript): Declare. |
| 630 | (NSAPP_DATA2_RUNASSCRIPT): Define. |
| 631 | |
| 632 | * nsfns.m (as_script, as_result, as_status): New static variables. |
| 633 | (ns_run_ascript): New function. |
| 634 | (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined |
| 635 | event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start |
| 636 | the event loop. Get status from as_status (Bug#7276). |
| 637 | |
| 638 | * nsterm.m (sendEvent): If event is NSApplicationDefined and |
| 639 | data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit |
| 640 | the event loop (Bug#7276). |
| 641 | |
| 642 | 2011-08-14 Andreas Schwab <schwab@linux-m68k.org> |
| 643 | |
| 644 | * gnutls.c (QCgnutls_bootprop_priority) |
| 645 | (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist) |
| 646 | (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks) |
| 647 | (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname) |
| 648 | (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags) |
| 649 | (QCgnutls_bootprop_verify_hostname_error) |
| 650 | (QCgnutls_bootprop_callbacks_verify): Rename from |
| 651 | Qgnutls_bootprop_..., all uses changed. |
| 652 | |
| 653 | * xfaces.c (QCignore_defface): Rename from Qignore_defface, all |
| 654 | uses changed. |
| 655 | |
| 656 | 2011-08-14 Paul Eggert <eggert@cs.ucla.edu> |
| 657 | |
| 658 | * xfaces.c (Qframe_set_background_mode): Now static. |
| 659 | * dispextern.h (Qframe_set_background_mode): Remove decl. |
| 660 | |
| 661 | * process.c (Fnetwork_interface_info): Declare local only if needed. |
| 662 | |
| 663 | 2011-08-13 Jan Djärv <jan.h.d@swipnet.se> |
| 664 | |
| 665 | * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477). |
| 666 | (Fnetwork_interface_list): Allocate in increments of bytes instead |
| 667 | of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting |
| 668 | bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct |
| 669 | sockaddr. |
| 670 | (struct ifflag_def): notrailers is smart on OSX. |
| 671 | (Fnetwork_interface_info): Handle case when ifr_flags is negative. |
| 672 | Get hardware address with getifaddrs if available. |
| 673 | |
| 674 | 2011-08-12 Eli Zaretskii <eliz@gnu.org> |
| 675 | |
| 676 | * xdisp.c (iterate_out_of_display_property): xassert that |
| 677 | IT->position is set to within IT->object's boundaries. Break from |
| 678 | the loop as soon as EOB is reached; avoids infloops in redisplay |
| 679 | when IT->position is set up wrongly due to some bug. |
| 680 | Set IT->current to match the bidi iterator unconditionally. |
| 681 | (push_display_prop): Allow GET_FROM_STRING as IT->method on |
| 682 | entry. Force push_it to save on the stack the current |
| 683 | buffer/string position, to be restored by pop_it. Fix flags in |
| 684 | the iterator structure wrt the object coming from a display |
| 685 | property, as `line-prefix' and `wrap-prefix' are not ``replacing'' |
| 686 | properties. (Bug#9284) |
| 687 | |
| 688 | 2011-08-09 Andreas Schwab <schwab@linux-m68k.org> |
| 689 | |
| 690 | * fontset.c (fontset_get_font_group): Add proper type checks. |
| 691 | (Bug#9172) |
| 692 | |
| 693 | 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
| 694 | |
| 695 | * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS |
| 696 | and LC_VERSION_MIN_MACOSX. |
| 697 | (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function. |
| 698 | (dump_it) [LC_FUNCTION_STARTS]: Use it. |
| 699 | |
| 700 | 2011-08-08 Eli Zaretskii <eliz@gnu.org> |
| 701 | |
| 702 | * xdisp.c (forward_to_next_line_start): Allow to use the |
| 703 | no-display-properties-and-no-overlays under bidi display. |
| 704 | Set disp_pos in the bidi iterator to avoid searches for display |
| 705 | properties and overlays. |
| 706 | |
| 707 | 2011-08-08 Chong Yidong <cyd@stupidchicken.com> |
| 708 | |
| 709 | * editfns.c (Fset_time_zone_rule): Document relationship with the |
| 710 | setenv function. |
| 711 | |
| 712 | * ftfont.c (ftfont_pattern_entity): Copy the extras argument to |
| 713 | the font entity extracted from the cache (Bug#8109). |
| 714 | |
| 715 | 2011-08-07 Chong Yidong <cyd@stupidchicken.com> |
| 716 | |
| 717 | * composite.c (autocmp_chars): Don't reset point. That is done by |
| 718 | restore_point_unwind (Bug#5984). |
| 719 | |
| 720 | 2011-08-07 Juri Linkov <juri@jurta.org> |
| 721 | |
| 722 | * editfns.c (Fformat_time_string): Doc fix, add tag `usage:' |
| 723 | to show the arg `TIME' instead of `TIMEVAL'. |
| 724 | |
| 725 | 2011-08-06 Eli Zaretskii <eliz@gnu.org> |
| 726 | |
| 727 | * xdisp.c (set_cursor_from_row): Fix cursor positioning when a |
| 728 | display property strides EOL and includes a newline, as in |
| 729 | longlines-mode. (Bug#9254) |
| 730 | (move_it_in_display_line_to): Fix vertical-motion in a buffer with |
| 731 | word-wrap under bidirectional display. (Bug#9224) |
| 732 | |
| 733 | * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE |
| 734 | is non-zero, even if the data buffer is NULL. Fixes a crash in |
| 735 | vertical-motion with longlines-mode. (Bug#9254) |
| 736 | |
| 737 | 2011-08-05 Eli Zaretskii <eliz@gnu.org> |
| 738 | |
| 739 | * bidi.c <bidi_cache_total_alloc>: Now static. |
| 740 | (bidi_initialize): Initialize bidi_cache_total_alloc. |
| 741 | |
| 742 | * xdisp.c (display_line): Release buffer allocated for shelved bidi |
| 743 | cache. (Bug#9221) |
| 744 | |
| 745 | * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total |
| 746 | amount allocated this far in `bidi_cache_total_alloc'. |
| 747 | (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if |
| 748 | non-zero, only free the data buffer without restoring the cache |
| 749 | contents. All callers changed. |
| 750 | |
| 751 | * dispextern.h (bidi_unshelve_cache): Update prototype. |
| 752 | |
| 753 | * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to) |
| 754 | (move_it_in_display_line, move_it_to) |
| 755 | (move_it_vertically_backward, move_it_by_lines): Replace the call |
| 756 | to xfree to an equivalent call to bidi_unshelve_cache. |
| 757 | (move_it_in_display_line_to): Fix logic of returning |
| 758 | MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224) |
| 759 | |
| 760 | 2011-08-05 Eli Zaretskii <eliz@gnu.org> |
| 761 | |
| 762 | * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that |
| 763 | came from a string character with a `cursor' property. (Bug#9229) |
| 764 | |
| 765 | 2011-08-04 Jan Djärv <jan.h.d@swipnet.se> |
| 766 | |
| 767 | * Makefile.in (LIB_PTHREAD): New variable. |
| 768 | (LIBES): Add LIB_PTHREAD (Bug#9216). |
| 769 | |
| 770 | * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h: |
| 771 | Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216). |
| 772 | |
| 773 | 2011-08-04 Andreas Schwab <schwab@linux-m68k.org> |
| 774 | |
| 775 | * regex.c (re_iswctype): Remove some redundant boolean |
| 776 | conversions. |
| 777 | |
| 778 | 2011-08-04 Jan Djärv <jan.h.d@swipnet.se> |
| 779 | |
| 780 | * xterm.c (x_find_topmost_parent): New function. |
| 781 | (x_set_frame_alpha): Find topmost parent window with |
| 782 | x_find_topmost_parent and set the property there also (bug#9181). |
| 783 | (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify. |
| 784 | |
| 785 | 2011-08-04 Paul Eggert <eggert@cs.ucla.edu> |
| 786 | |
| 787 | * callproc.c (Fcall_process): Avoid vfork clobbering |
| 788 | the local vars buffer, coding_systems, current_dir. |
| 789 | |
| 790 | 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca> |
| 791 | |
| 792 | * keymap.c (Fmake_composed_keymap): Move to subr.el. |
| 793 | |
| 794 | 2011-08-03 Paul Eggert <eggert@cs.ucla.edu> |
| 795 | |
| 796 | * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE |
| 797 | so that it is not optimized away. |
| 798 | |
| 799 | * xdisp.c (compute_display_string_pos): Remove unused local. |
| 800 | |
| 801 | 2011-08-02 Eli Zaretskii <eliz@gnu.org> |
| 802 | |
| 803 | Fix slow cursor motion and scrolling in large buffers with |
| 804 | selective display, like Org Mode buffers. (Bug#9218) |
| 805 | |
| 806 | * dispextern.h (struct bidi_it): New member disp_prop_p. |
| 807 | |
| 808 | * xdisp.c: Remove one-slot cache of display string positions. |
| 809 | (compute_display_string_pos): Accept an additional argument |
| 810 | DISP_PROP_P; callers changed. Scan at most 5K characters forward |
| 811 | for a display string or property. If found, set DISP_PROP_P |
| 812 | non-zero. |
| 813 | |
| 814 | * bidi.c (bidi_fetch_char): Accept an additional argument |
| 815 | DISP_PROP_P, and pass it to compute_display_string_pos. |
| 816 | Only handle text covered by a display string if DISP_PROP_P is returned |
| 817 | non-zero. All callers of bidi_fetch_char changed. |
| 818 | |
| 819 | 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca> |
| 820 | |
| 821 | * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE. |
| 822 | |
| 823 | 2010-12-03 Don March <don@ohspite.net> |
| 824 | |
| 825 | * keymap.c (Fdefine_key): Fix non-prefix key error message when |
| 826 | last character M-[char] is translated to ESC [char] (bug#7541). |
| 827 | |
| 828 | 2011-08-02 Kenichi Handa <handa@m17n.org> |
| 829 | |
| 830 | * lisp.h (uniprop_table): Extern it. |
| 831 | |
| 832 | * chartab.c (uniprop_table): Make it non-static. |
| 833 | |
| 834 | 2011-08-01 Eli Zaretskii <eliz@gnu.org> |
| 835 | |
| 836 | * xdisp.c (forward_to_next_line_start): Accept additional argument |
| 837 | BIDI_IT_PREV, and store into it the state of the bidi iterator had |
| 838 | on the newline. |
| 839 | (reseat_at_next_visible_line_start): Use the bidi iterator state |
| 840 | returned by forward_to_next_line_start to restore the state of |
| 841 | it->bidi_it after backing up to previous newline. (Bug#9212) |
| 842 | |
| 843 | 2011-07-30 Andreas Schwab <schwab@linux-m68k.org> |
| 844 | |
| 845 | * regex.c (re_comp): Protoize. |
| 846 | (re_exec): Fix return type. |
| 847 | (regexec): Fix type of `ret'. (Bug#9203) |
| 848 | |
| 849 | 2011-07-29 Paul Eggert <eggert@cs.ucla.edu> |
| 850 | |
| 851 | * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189). |
| 852 | This is needed if max-image-size is a floating-point number. |
| 853 | |
| 854 | 2011-07-28 Andreas Schwab <schwab@linux-m68k.org> |
| 855 | |
| 856 | * print.c (print_object): Print empty symbol as ##. |
| 857 | |
| 858 | * lread.c (read1): Read ## as empty symbol. |
| 859 | |
| 860 | 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com> |
| 861 | |
| 862 | * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when |
| 863 | setting frame foreground color (Bug#9175). |
| 864 | (x_set_background_color): Likewise. |
| 865 | |
| 866 | * nsmenu.m (-setText): Size tooltip dimensions precisely to |
| 867 | contents (Bug#9176). |
| 868 | (EmacsTooltip -init): Remove bezels and add shadows to |
| 869 | tooltip windows. |
| 870 | |
| 871 | * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe |
| 872 | or scroll bar (Bug#8470). |
| 873 | |
| 874 | * nsfont.m (nsfont_open): Remove assignment to voffset and |
| 875 | unnecessary vars hshink, expand, hd, full_height, min_height. |
| 876 | (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913). |
| 877 | |
| 878 | * nsterm.h (nsfont_info): Remove voffset field. |
| 879 | |
| 880 | 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com> |
| 881 | |
| 882 | Implement strike-through and overline on NextStep (Bug#8863). |
| 883 | |
| 884 | * nsfont.m (nsfont_open): Use underline position provided by font, |
| 885 | instead of hard-coded value of 2. |
| 886 | (nsfont_draw): Call ns_draw_text_decoration instead. |
| 887 | |
| 888 | * nsterm.h: Add declaration for ns_draw_text_decoration. |
| 889 | |
| 890 | * nsterm.m (ns_draw_text_decoration): New function for drawing |
| 891 | underline, overline, and strike-through. |
| 892 | (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to |
| 893 | ns_draw_text_decoration. Change treatment of cursor drawing to |
| 894 | accomodate underlining, etc. |
| 895 | |
| 896 | 2011-07-28 Eli Zaretskii <eliz@gnu.org> |
| 897 | |
| 898 | * buffer.c (init_buffer_once): Set bidi-display-reordering to t by |
| 899 | default. |
| 900 | |
| 901 | 2011-07-28 Paul Eggert <eggert@cs.ucla.edu> |
| 902 | |
| 903 | * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race. |
| 904 | Without this fix, if a signal arrives just after memory fills up, |
| 905 | 'malloc' might be invoked reentrantly. |
| 906 | |
| 907 | * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1. |
| 908 | In other words, assume that every image size is allowed, on non-X |
| 909 | hosts. This assumption is probably wrong, but it lets Emacs compile. |
| 910 | |
| 911 | 2011-07-28 Andreas Schwab <schwab@linux-m68k.org> |
| 912 | |
| 913 | * regex.c (re_iswctype): Convert return values to boolean. |
| 914 | |
| 915 | 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org> |
| 916 | |
| 917 | * xdisp.c (compute_display_string_pos): Don't use cached display |
| 918 | string position if the buffer had its restriction changed. |
| 919 | (Bug#9184) |
| 920 | |
| 921 | 2011-07-28 Paul Eggert <eggert@cs.ucla.edu> |
| 922 | |
| 923 | * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering. |
| 924 | |
| 925 | 2011-07-28 Paul Eggert <eggert@cs.ucla.edu> |
| 926 | |
| 927 | Integer signedness and overflow and related fixes. (Bug#9079) |
| 928 | |
| 929 | * bidi.c: Integer size and overflow fixes. |
| 930 | (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx) |
| 931 | (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search) |
| 932 | (bidi_cache_find_level_change, bidi_cache_ensure_space) |
| 933 | (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack) |
| 934 | (bidi_find_other_level_edge): |
| 935 | Use ptrdiff_t instead of EMACS_INT where either will do. |
| 936 | This works better on 32-bit hosts configured --with-wide-int. |
| 937 | (bidi_cache_ensure_space): Check for size-calculation overflow. |
| 938 | Use % rather than repeated addition, for better worst-case speed. |
| 939 | Don't set bidi_cache_size until after xrealloc returns, because it |
| 940 | might not return. |
| 941 | (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow. |
| 942 | (bidi_cache_ensure_space): Also check that the bidi cache size |
| 943 | does not exceed that of the largest Lisp string or buffer. See Eli |
| 944 | Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>. |
| 945 | |
| 946 | * alloc.c (__malloc_size_t): Remove. |
| 947 | All uses replaced by size_t. See Andreas Schwab's note |
| 948 | <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>. |
| 949 | |
| 950 | * image.c: Improve checking for integer overflow. |
| 951 | (check_image_size): Assume that f is nonnull, since |
| 952 | it is always nonnull in practice. This is one less thing to |
| 953 | worry about when checking for integer overflow later. |
| 954 | (x_check_image_size): New function, which checks for integer |
| 955 | overflow issues inside X. |
| 956 | (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it. |
| 957 | This removes the need for a memory_full check. |
| 958 | (xbm_image_p): Rewrite to avoid integer multiplication overflow. |
| 959 | (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size. |
| 960 | (xbm_read_bitmap_data): Change locals back to 'int', since |
| 961 | their values must fit in 'int'. |
| 962 | (xpm_load_image, png_load, tiff_load): |
| 963 | Invoke x_create_x_image_and_pixmap earlier, |
| 964 | to avoid much needless work if the image is too large. |
| 965 | (tiff_load): Treat overly large images as if |
| 966 | x_create_x_image_and_pixmap failed, not as malloc failures. |
| 967 | (gs_load): Use x_check_image_size. |
| 968 | |
| 969 | * gtkutil.c: Omit integer casts. |
| 970 | (xg_get_pixbuf_from_pixmap): Remove unnecessary cast. |
| 971 | (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast. |
| 972 | |
| 973 | * image.c (png_load): Don't assume height * row_bytes fits in 'int'. |
| 974 | |
| 975 | * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug. |
| 976 | Without this fix, (bitmap-spec-p '(34359738368 1 "x")) |
| 977 | would wrongly return t on a 64-bit host. |
| 978 | |
| 979 | * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros. |
| 980 | The plain *_OVERFLOW macros run afoul of GCC bug 49705 |
| 981 | <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705> |
| 982 | and therefore cause GCC to emit a bogus diagnostic in some cases. |
| 983 | |
| 984 | * image.c: Integer signedness and overflow and related fixes. |
| 985 | This is not an exhaustive set of fixes, but it's time to |
| 986 | record what I've got. |
| 987 | (lookup_pixel_color, check_image_size): Remove redundant decls. |
| 988 | (check_image_size): Don't assume that arbitrary EMACS_INT values |
| 989 | fit in 'int', or that arbitrary 'double' values fit in 'int'. |
| 990 | (x_alloc_image_color, x_create_x_image_and_pixmap, png_load) |
| 991 | (tiff_load, imagemagick_load_image): |
| 992 | Check for overflow in size calculations. |
| 993 | (x_create_x_image_and_pixmap): Remove unnecessary test for |
| 994 | xmalloc returning NULL; that can't happen. |
| 995 | (xbm_read_bitmap_data): Don't assume sizes fit into 'int'. |
| 996 | (xpm_color_bucket): Use better integer hashing function. |
| 997 | (xpm_cache_color): Don't possibly over-allocate memory. |
| 998 | (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory) |
| 999 | (gif_memory_source): |
| 1000 | Use ptrdiff_t, not int or size_t, to record sizes. |
| 1001 | (png_load): Don't assume values greater than 2**31 fit in 'int'. |
| 1002 | (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when |
| 1003 | either works, as we prefer signed integers. |
| 1004 | (tiff_read_from_memory, tiff_write_from_memory): |
| 1005 | Return tsize_t, not size_t, since that's what the TIFF API wants. |
| 1006 | (tiff_read_from_memory): Don't fail simply because the read would |
| 1007 | go past EOF; instead, return a short read. |
| 1008 | (tiff_load): Omit no-longer-needed casts. |
| 1009 | (Fimagemagick_types): Don't assume size fits into 'int'. |
| 1010 | |
| 1011 | Improve hashing quality when configured --with-wide-int. |
| 1012 | * fns.c (hash_string): New function, taken from sxhash_string. |
| 1013 | Do not discard information about ASCII character case; this |
| 1014 | discarding is no longer needed. |
| 1015 | (sxhash-string): Use it. Change sig to match it. Caller changed. |
| 1016 | * lisp.h: Declare it. |
| 1017 | * lread.c (hash_string): Remove, since we now use fns.c's version. |
| 1018 | The fns.c version returns a wider integer if --with-wide-int is |
| 1019 | specified, so this should help the quality of the hashing a bit. |
| 1020 | |
| 1021 | * emacs.c: Integer overflow minor fix. |
| 1022 | (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed. |
| 1023 | Define only if GNU_LINUX. |
| 1024 | (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX. |
| 1025 | |
| 1026 | * dispnew.c: Integer signedness and overflow fixes. |
| 1027 | Remove unnecessary forward decls, that were a maintenance hassle. |
| 1028 | (history_tick): Now uprintmax_t, so it's more likely to avoid overflow. |
| 1029 | All uses changed. |
| 1030 | (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer) |
| 1031 | (scrolling_window): Use ptrdiff_t, not int, for byte count. |
| 1032 | (prepare_desired_row, line_draw_cost): |
| 1033 | Use int, not unsigned, where either works. |
| 1034 | (save_current_matrix, restore_current_matrix): |
| 1035 | Use ptrdiff_t, not size_t, where either works. |
| 1036 | (init_display): Check for overflow more accurately, and without |
| 1037 | relying on undefined behavior. |
| 1038 | |
| 1039 | * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide): |
| 1040 | Remove, replacing with the new symbols in lisp.h. All uses changed. |
| 1041 | * fileio.c (make_temp_name): |
| 1042 | * filelock.c (lock_file_1, lock_file): |
| 1043 | * xdisp.c (message_dolog): |
| 1044 | Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts. |
| 1045 | Use pMd etc. instead. |
| 1046 | * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros, |
| 1047 | replacing the pWIDE etc. symbols removed from editfns.c. |
| 1048 | |
| 1049 | * keyboard.h (num_input_events): Now uintmax_t. |
| 1050 | This is (very slightly) less likely to mess up due to wraparound. |
| 1051 | All uses changed. |
| 1052 | |
| 1053 | * buffer.c: Integer signedness fixes. |
| 1054 | (alloc_buffer_text, enlarge_buffer_text): |
| 1055 | Use ptrdiff_t rather than size_t when either will do, as we prefer |
| 1056 | signed integers. |
| 1057 | |
| 1058 | * alloc.c: Integer signedness and overflow fixes. |
| 1059 | Do not impose an arbitrary 32-bit limit on malloc sizes when debugging. |
| 1060 | (__malloc_size_t): Default to size_t, not to int. |
| 1061 | (pure_size, pure_bytes_used_before_overflow, stack_copy_size) |
| 1062 | (Fgarbage_collect, mark_object_loop_halt, mark_object): |
| 1063 | Prefer ptrdiff_t to size_t when either would do, as we prefer |
| 1064 | signed integers. |
| 1065 | (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro. |
| 1066 | (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer): |
| 1067 | Now const. Initialize with values that are in range even if char |
| 1068 | is signed. |
| 1069 | (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ... |
| 1070 | (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed. |
| 1071 | These functions do the right thing with sizes > 2**32. |
| 1072 | (check_depth): Now ptrdiff_t, not int. |
| 1073 | (overrun_check_malloc, overrun_check_realloc, overrun_check_free): |
| 1074 | Adjust to new way of storing sizes. Check for size overflow bugs |
| 1075 | in rest of code. |
| 1076 | (STRING_BYTES_MAX): Adjust to new overheads. The old code was |
| 1077 | slightly wrong anyway, as it missed one instance of |
| 1078 | XMALLOC_OVERRUN_CHECK_OVERHEAD. |
| 1079 | (refill_memory_reserve): Omit needless cast to size_t. |
| 1080 | (mark_object_loop_halt): Mark as externally visible. |
| 1081 | |
| 1082 | * xselect.c: Integer signedness and overflow fixes. |
| 1083 | (Fx_register_dnd_atom, x_handle_dnd_message): |
| 1084 | Use ptrdiff_t, not size_t, since we prefer signed. |
| 1085 | (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow. |
| 1086 | * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for |
| 1087 | x_dnd_atoms_size and x_dnd_atoms_length. |
| 1088 | |
| 1089 | * doprnt.c: Prefer signed to unsigned when either works. |
| 1090 | * eval.c (verror): |
| 1091 | * doprnt.c (doprnt): |
| 1092 | * lisp.h (doprnt): |
| 1093 | * xdisp.c (vmessage): |
| 1094 | Use ptrdiff_t, not size_t, when using or implementing doprnt, |
| 1095 | since the sizes cannot exceed ptrdiff_t bounds anyway, and we |
| 1096 | prefer signed arithmetic to avoid comparison confusion. |
| 1097 | * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow, |
| 1098 | but is a bit tricky. |
| 1099 | |
| 1100 | Assume freestanding C89 headers, string.h, stdlib.h. |
| 1101 | * data.c, doprnt.c, floatfns.c, print.c: |
| 1102 | Include float.h unconditionally. |
| 1103 | * gmalloc.c: Assume C89-at-least behavior for preprocessor, |
| 1104 | limits.h, stddef.h, string.h. Use memset instead of 'flood'. |
| 1105 | * regex.c: Likewise for stddef.h, string.h. |
| 1106 | (ISASCII): Remove; can assume it returns 1 now. All uses removed. |
| 1107 | * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef. |
| 1108 | * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H) |
| 1109 | (STDC_HEADERS): Remove obsolete defines. |
| 1110 | * sysdep.c: Include limits.h unconditionally. |
| 1111 | |
| 1112 | Assume support for memcmp, memcpy, memmove, memset. |
| 1113 | * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset): |
| 1114 | * regex.c (memcmp, memcpy): |
| 1115 | Remove; we assume C89 now. |
| 1116 | |
| 1117 | * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now. |
| 1118 | (__malloc_safe_bcopy): Remove; no longer needed. |
| 1119 | |
| 1120 | * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes. |
| 1121 | Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally |
| 1122 | well either way, and we prefer signed to unsigned. |
| 1123 | |
| 1124 | 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1125 | |
| 1126 | * gnutls.c (emacs_gnutls_read): Don't message anything if the peer |
| 1127 | closes the connection while we're reading (bug#9182). |
| 1128 | |
| 1129 | 2011-07-25 Jan Djärv <jan.h.d@swipnet.se> |
| 1130 | |
| 1131 | * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons |
| 1132 | are specified (Bug#9168). |
| 1133 | |
| 1134 | 2011-07-25 Paul Eggert <eggert@cs.ucla.edu> |
| 1135 | |
| 1136 | * bidi.c (bidi_dump_cached_states): Fix printf format mismatch. |
| 1137 | Found by GCC static checking and --with-wide-int on a 32-bit host. |
| 1138 | |
| 1139 | 2011-07-25 Eli Zaretskii <eliz@gnu.org> |
| 1140 | |
| 1141 | * xdisp.c (compute_display_string_pos): Fix logic of caching |
| 1142 | previous display string position. Initialize cached_prev_pos to |
| 1143 | -1. Fixes slow-down at the beginning of a buffer. |
| 1144 | |
| 1145 | 2011-07-24 Eli Zaretskii <eliz@gnu.org> |
| 1146 | |
| 1147 | * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil' |
| 1148 | for attrs[LFACE_FONTSET_INDEX]. |
| 1149 | |
| 1150 | 2011-07-23 Paul Eggert <eggert@cs.ucla.edu> |
| 1151 | |
| 1152 | * xml.c (parse_region): Remove unused local |
| 1153 | that was recently introduced. |
| 1154 | |
| 1155 | 2011-07-23 Eli Zaretskii <eliz@gnu.org> |
| 1156 | |
| 1157 | * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in |
| 1158 | 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca. |
| 1159 | |
| 1160 | * xdisp.c (move_it_in_display_line_to): Record the best matching |
| 1161 | position for TO_CHARPOS while scanning the line, and restore it on |
| 1162 | exit if none of the characters scanned was an exact match. |
| 1163 | Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay |
| 1164 | when exact match is impossible due to invisible text, and the |
| 1165 | lines are truncated. |
| 1166 | |
| 1167 | 2011-07-23 Jan Djärv <jan.h.d@swipnet.se> |
| 1168 | |
| 1169 | * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask |
| 1170 | for OSX >= 10.7. |
| 1171 | |
| 1172 | 2011-07-22 Eli Zaretskii <eliz@gnu.org> |
| 1173 | |
| 1174 | Fix a significant slow-down of cursor motion with C-n, C-p, |
| 1175 | C-f/C-b, and C-v/M-v that couldn't keep up with keyboard |
| 1176 | auto-repeat under bidi redisplay in fontified buffers. |
| 1177 | * xdisp.c (compute_stop_pos_backwards): New function. |
| 1178 | (next_element_from_buffer): Call compute_stop_pos_backwards to |
| 1179 | find a suitable prev_stop when we find ourselves before |
| 1180 | base_level_stop. |
| 1181 | (reseat): Don't look for prev_stop, as that could mean a very long |
| 1182 | run. |
| 1183 | <cached_disp_pos, cached_disp_buffer, cached_disp_modiff> |
| 1184 | <cached_disp_overlay_modiff>: Cache for last found display string |
| 1185 | position. |
| 1186 | (compute_display_string_pos): Return the cached position if asked |
| 1187 | about the same buffer in the same area of character positions, and |
| 1188 | the buffer wasn't changed since the time the display string |
| 1189 | position was cached. |
| 1190 | |
| 1191 | 2011-07-22 Eli Zaretskii <eliz@gnu.org> |
| 1192 | |
| 1193 | * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object |
| 1194 | is an integer, which is important for empty lines. (Bug#9149) |
| 1195 | |
| 1196 | 2011-07-22 Chong Yidong <cyd@stupidchicken.com> |
| 1197 | |
| 1198 | * frame.c (Fmodify_frame_parameters): In tty case, update the |
| 1199 | default face if necessary (Bug#4238). |
| 1200 | |
| 1201 | 2011-07-21 Chong Yidong <cyd@stupidchicken.com> |
| 1202 | |
| 1203 | * editfns.c (Fstring_to_char): No need to explain what a character |
| 1204 | is in the docstring (Bug#6576). |
| 1205 | |
| 1206 | 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1207 | |
| 1208 | * xml.c (parse_region): Make sure we always return a tree. |
| 1209 | |
| 1210 | 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com> |
| 1211 | |
| 1212 | * xml.c (parse_region): If a document contains only comments, |
| 1213 | return that, too. |
| 1214 | |
| 1215 | 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1216 | |
| 1217 | * xml.c (make_dom): Return comments, too. |
| 1218 | |
| 1219 | 2011-07-19 Paul Eggert <eggert@cs.ucla.edu> |
| 1220 | |
| 1221 | Port to OpenBSD. |
| 1222 | See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html |
| 1223 | and the surrounding thread. |
| 1224 | * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar |
| 1225 | rather than fgets, and retry after EINTR. Otherwise, 'emacs |
| 1226 | --batch -f byte-compile-file' fails on OpenBSD if an inactivity |
| 1227 | timer goes off. |
| 1228 | * s/openbsd.h (BROKEN_SIGIO): Define. |
| 1229 | * unexelf.c (unexec) [__OpenBSD__]: |
| 1230 | Don't update the .mdebug section of the Alpha COFF symbol table. |
| 1231 | |
| 1232 | 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1233 | |
| 1234 | * lread.c (syms_of_lread): Clarify when `lexical-binding' is used |
| 1235 | (bug#8460). |
| 1236 | |
| 1237 | 2011-07-18 Paul Eggert <eggert@cs.ucla.edu> |
| 1238 | |
| 1239 | * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask. |
| 1240 | This fixes some race conditions on the permissions of any newly |
| 1241 | created file. |
| 1242 | |
| 1243 | * alloc.c (valid_pointer_p): Use pipe, not open. |
| 1244 | This fixes some permissions issues when debugging. |
| 1245 | |
| 1246 | * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002) |
| 1247 | If fchown fails to set both uid and gid, try to set just gid, |
| 1248 | as that is sometimes allowed. Adjust the file's mode to eliminate |
| 1249 | setuid or setgid bits that are inappropriate if fchown fails. |
| 1250 | |
| 1251 | 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca> |
| 1252 | |
| 1253 | * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ |
| 1254 | to compare Lisp_Objects. |
| 1255 | * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to |
| 1256 | global_gnutls_log_level, don't mistake it for a Lisp_Object. |
| 1257 | (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses. |
| 1258 | |
| 1259 | 2011-07-17 Andreas Schwab <schwab@linux-m68k.org> |
| 1260 | |
| 1261 | * lread.c (read_integer): Unread even EOF character. |
| 1262 | (read1): Likewise. Properly record start position of symbol. |
| 1263 | |
| 1264 | * lread.c (read1): Read `#:' as empty uninterned symbol if no |
| 1265 | symbol character follows. |
| 1266 | |
| 1267 | 2011-07-17 Paul Eggert <eggert@cs.ucla.edu> |
| 1268 | |
| 1269 | * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002) |
| 1270 | This works around a problem with the previous change to Fcopy_file. |
| 1271 | Recent glibc declares fchown with __attribute__((warn_unused_result)), |
| 1272 | and without this change, GCC might complain about discarding |
| 1273 | fchown's return value. |
| 1274 | |
| 1275 | 2011-07-16 Juanma Barranquero <lekktu@gmail.com> |
| 1276 | |
| 1277 | * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059). |
| 1278 | |
| 1279 | 2011-07-16 Paul Eggert <eggert@cs.ucla.edu> |
| 1280 | |
| 1281 | * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002) |
| 1282 | |
| 1283 | 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1284 | |
| 1285 | * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since |
| 1286 | it's used from the C level. |
| 1287 | |
| 1288 | * process.c: Use the same condition for POLL_FOR_INPUT in both |
| 1289 | keyboard.c and process.c (bug#1858). |
| 1290 | |
| 1291 | 2011-07-09 Lawrence Mitchell <wence@gmx.li> |
| 1292 | |
| 1293 | * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable. |
| 1294 | (Fgnutls_boot): Use it. |
| 1295 | |
| 1296 | 2011-07-15 Andreas Schwab <schwab@linux-m68k.org> |
| 1297 | |
| 1298 | * doc.c (Fsubstitute_command_keys): Revert last change. |
| 1299 | |
| 1300 | 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1301 | |
| 1302 | * doc.c (Fsubstitute_command_keys): Clarify that \= really only |
| 1303 | quotes the next character, and doesn't affect other longer |
| 1304 | sequences (bug#8935). |
| 1305 | |
| 1306 | * lread.c (syms_of_lread): Clarify that is isn't only |
| 1307 | `eval-buffer' and `eval-defun' that's affected by |
| 1308 | `lexical-binding' (bug#8460). |
| 1309 | |
| 1310 | 2011-07-15 Eli Zaretskii <eliz@gnu.org> |
| 1311 | |
| 1312 | * xdisp.c (move_it_in_display_line_to): Fix vertical motion with |
| 1313 | bidi redisplay when a line includes both an image and is |
| 1314 | truncated. |
| 1315 | |
| 1316 | 2011-07-14 Paul Eggert <eggert@cs.ucla.edu> |
| 1317 | |
| 1318 | Fix minor problems found by static checking. |
| 1319 | * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t. |
| 1320 | (elsz): Now a signed constant, not a size_t var. We prefer signed |
| 1321 | types to unsigned, to avoid integer comparison confusion. Without |
| 1322 | this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains |
| 1323 | "cannot optimize loop, the loop counter may overflow", a symptom |
| 1324 | of the confusion. |
| 1325 | * indent.c (Fvertical_motion): Mark locals as initialized. |
| 1326 | * xdisp.c (reseat_to_string): Fix pointer signedness issue. |
| 1327 | |
| 1328 | 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1329 | |
| 1330 | * search.c (Fre_search_backward): Mention `case-fold-search' in |
| 1331 | all the re_search_* functions (bug#8138). |
| 1332 | |
| 1333 | * keyboard.c (Fopen_dribble_file): Document when the file is |
| 1334 | closed (bug#8056). |
| 1335 | |
| 1336 | 2011-07-14 Eli Zaretskii <eliz@gnu.org> |
| 1337 | |
| 1338 | * bidi.c (bidi_dump_cached_states): Fix format of displaying |
| 1339 | bidi_cache_idx. |
| 1340 | |
| 1341 | Support bidi reordering of display and overlay strings. |
| 1342 | * xdisp.c (compute_display_string_pos) |
| 1343 | (compute_display_string_end): Accept additional argument STRING. |
| 1344 | (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL. |
| 1345 | (reseat_to_string): Initialize bidi_it->string.s and |
| 1346 | bidi_it->string.schars. |
| 1347 | (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to |
| 1348 | NULL (avoids a crash in bidi_paragraph_init). |
| 1349 | Initialize itb.string.lstring. |
| 1350 | (init_iterator): Call bidi_init_it only of a valid |
| 1351 | buffer position was specified. Initialize paragraph_embedding to |
| 1352 | L2R. |
| 1353 | (reseat_to_string): Initialize the bidi iterator. |
| 1354 | (display_string): If we need to ignore text properties of |
| 1355 | LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The |
| 1356 | original value of -1 will not work with bidi.) |
| 1357 | (compute_display_string_pos): First arg is now struct |
| 1358 | `text_pos *'; all callers changed. Support display properties on |
| 1359 | Lisp strings. |
| 1360 | (compute_display_string_end): Support display properties on Lisp |
| 1361 | strings. |
| 1362 | (init_iterator, reseat_1, reseat_to_string): Initialize the |
| 1363 | string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS |
| 1364 | when iterating on a string not from display properties). |
| 1365 | (compute_display_string_pos, compute_display_string_end): |
| 1366 | Fix calculation of the object to scan. Fixes an error when using |
| 1367 | arrow keys. |
| 1368 | (next_element_from_buffer): Don't abort when IT_CHARPOS is before |
| 1369 | base_level_stop; instead, set base_level_stop to BEGV. |
| 1370 | Fixes crashes in vertical-motion. |
| 1371 | (next_element_from_buffer): Improve commentary for when |
| 1372 | the iterator is before prev_stop. |
| 1373 | (init_iterator): Initialize bidi_p from the default value of |
| 1374 | bidi-display-reordering, not from buffer-local value. Use the |
| 1375 | buffer-local value only if initializing for buffer iteration. |
| 1376 | (handle_invisible_prop): Support invisible properties on strings |
| 1377 | that are being bidi-reordered. |
| 1378 | (set_iterator_to_next): Support bidi reordering of C strings and |
| 1379 | Lisp strings. |
| 1380 | (next_element_from_string): Support bidi reordering of Lisp |
| 1381 | strings. |
| 1382 | (handle_stop_backwards): Support Lisp strings as well. |
| 1383 | (display_string): Support display of R2L glyph rows. |
| 1384 | Use IT_STRING_CHARPOS when displaying from a Lisp string. |
| 1385 | (init_iterator): Don't initialize it->bidi_p for strings |
| 1386 | here. |
| 1387 | (reseat_to_string): Initialize it->bidi_p for strings here. |
| 1388 | (next_element_from_string, next_element_from_c_string) |
| 1389 | (next_element_from_buffer): Add xassert's for correspondence |
| 1390 | between IT's object being iterated and it->bidi_it.string |
| 1391 | structure. |
| 1392 | (face_before_or_after_it_pos): Support bidi iteration. |
| 1393 | (next_element_from_c_string): Handle the case of the first string |
| 1394 | character that is not the first one in the visual order. |
| 1395 | (get_visually_first_element): New function, refactored from common |
| 1396 | parts of next_element_from_buffer, next_element_from_string, and |
| 1397 | next_element_from_c_string. |
| 1398 | (tool_bar_lines_needed, redisplay_tool_bar) |
| 1399 | (display_menu_bar): Force left-to-right direction. Add a FIXME |
| 1400 | comment for making that be controlled by a user option. |
| 1401 | (push_it, pop_it): Save and restore the state of the |
| 1402 | bidi iterator. Save and restore the bidi_p flag. |
| 1403 | (pop_it): Iterate out of display property for string iteration as |
| 1404 | well. |
| 1405 | (iterate_out_of_display_property): Support iteration over strings. |
| 1406 | (handle_single_display_spec): Set up it->bidi_it for iteration |
| 1407 | over a display string, and call bidi_init_it. |
| 1408 | (handle_single_display_spec, next_overlay_string) |
| 1409 | (get_overlay_strings_1, push_display_prop): Set up the bidi |
| 1410 | iterator for displaying display or overlay strings. |
| 1411 | (forward_to_next_line_start): Don't use the shortcut if |
| 1412 | bidi-iterating. |
| 1413 | (back_to_previous_visible_line_start): If handle_display_prop |
| 1414 | pushed the iterator stack, restore the internal state of the bidi |
| 1415 | iterator by calling bidi_pop_it same number of times. |
| 1416 | (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero, |
| 1417 | and we are bidi-iterating, don't decrement the iterator position; |
| 1418 | instead, set the first_elt flag in the bidi iterator, to produce |
| 1419 | the same effect. |
| 1420 | (reseat_1): Remove redundant setting of string_from_display_prop_p. |
| 1421 | (push_display_prop): xassert that we are iterating a buffer. |
| 1422 | (push_it, pop_it): Save and restore paragraph_embedding member. |
| 1423 | (handle_single_display_spec, next_overlay_string) |
| 1424 | (get_overlay_strings_1, reseat_1, reseat_to_string) |
| 1425 | (push_display_prop): Set up the `unibyte' member of bidi_it.string |
| 1426 | correctly. Don't assume unibyte strings are not bidi-reordered. |
| 1427 | (compute_display_string_pos) |
| 1428 | (compute_display_string_end): Fix handling the case of C string. |
| 1429 | (push_it, pop_it): Save and restore from_disp_prop_p. |
| 1430 | (handle_single_display_spec, push_display_prop): Set the |
| 1431 | from_disp_prop_p flag. |
| 1432 | (get_overlay_strings_1): Reset the from_disp_prop_p flag. |
| 1433 | (pop_it): Call iterate_out_of_display_property only if we are |
| 1434 | popping after iteration over a string that came from a display |
| 1435 | property. Fix a typo in popping stretch info. Add an assertion |
| 1436 | for verifying that the iterator position is in sync with the bidi |
| 1437 | iterator. |
| 1438 | (handle_single_display_spec, get_overlay_strings_1) |
| 1439 | (push_display_prop): Fix initialization of paragraph direction for |
| 1440 | string when that of the parent object is not yet determined. |
| 1441 | (reseat_1): Call bidi_init_it to resync the bidi |
| 1442 | iterator with IT's position. (Bug#7616) |
| 1443 | (find_row_edges): If ROW->start.pos gives position |
| 1444 | smaller than min_pos, use it as ROW->minpos. (Bug#7616) |
| 1445 | (handle_stop, back_to_previous_visible_line_start, reseat_1): |
| 1446 | Reset the from_disp_prop_p flag. |
| 1447 | (SAVE_IT, RESTORE_IT): New macros. |
| 1448 | (pos_visible_p, face_before_or_after_it_pos) |
| 1449 | (back_to_previous_visible_line_start) |
| 1450 | (move_it_in_display_line_to, move_it_in_display_line) |
| 1451 | (move_it_to, move_it_vertically_backward, move_it_by_lines) |
| 1452 | (try_scrolling, redisplay_window, display_line): Use them when |
| 1453 | saving a temporary copy of the iterator and restoring it back. |
| 1454 | (back_to_previous_visible_line_start, reseat_1) |
| 1455 | (init_iterator): Empty the bidi cache "stack". |
| 1456 | (move_it_in_display_line_to): If iterator ended up at |
| 1457 | EOL, but we never saw any buffer positions smaller than |
| 1458 | to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor |
| 1459 | motion in bidi-reordered lines. |
| 1460 | (move_it_in_display_line_to): Record prev_method and prev_pos |
| 1461 | immediately before the call to set_iterator_to_next. Fixes cursor |
| 1462 | motion in bidi-reordered lines with stretch glyphs and strings |
| 1463 | displayed in margins. (Bug#8133) (Bug#8867) |
| 1464 | Return MOVE_POS_MATCH_OR_ZV only if iterator position is past |
| 1465 | TO_CHARPOS. |
| 1466 | (pos_visible_p): Support positions in bidi-reordered lines. |
| 1467 | Save and restore bidi cache. |
| 1468 | |
| 1469 | * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int. |
| 1470 | (bidi_paragraph_info): Delete unused struct. |
| 1471 | (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT. |
| 1472 | (bidi_cache_start): New variable. |
| 1473 | (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not |
| 1474 | to zero. |
| 1475 | (bidi_cache_fetch_state, bidi_cache_search) |
| 1476 | (bidi_cache_find_level_change, bidi_cache_iterator_state) |
| 1477 | (bidi_cache_find, bidi_peek_at_next_level) |
| 1478 | (bidi_level_of_next_char, bidi_find_other_level_edge) |
| 1479 | (bidi_move_to_visually_next): Compare cache index with |
| 1480 | bidi_cache_start rather than with zero. |
| 1481 | (bidi_fetch_char): Accept new argument STRING; all callers |
| 1482 | changed. Support iteration over a string. Support strings with |
| 1483 | display properties. Support unibyte strings. Fix the type of |
| 1484 | `len' according to what STRING_CHAR_AND_LENGTH expects. |
| 1485 | (bidi_paragraph_init, bidi_resolve_explicit_1) |
| 1486 | (bidi_resolve_explicit, bidi_resolve_weak) |
| 1487 | (bidi_level_of_next_char, bidi_move_to_visually_next): |
| 1488 | Support iteration over a string. |
| 1489 | (bidi_set_sor_type, bidi_resolve_explicit_1) |
| 1490 | (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit |
| 1491 | can now be zero (for strings); special values 0 and -1 were |
| 1492 | changed to -1 and -2, respectively. |
| 1493 | (bidi_char_at_pos): New function. |
| 1494 | (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak): |
| 1495 | Call it instead of FETCH_MULTIBYTE_CHAR. |
| 1496 | (bidi_move_to_visually_next): Abort if charpos or bytepos were not |
| 1497 | initialized to valid values. |
| 1498 | (bidi_init_it): Don't initialize charpos and bytepos with invalid |
| 1499 | values. |
| 1500 | (bidi_level_of_next_char): Allow the sentinel "position" to pass |
| 1501 | the test for valid cached positions. Fix the logic for looking up |
| 1502 | the sentinel state in the cache. GCPRO the Lisp string we are |
| 1503 | iterating. |
| 1504 | (bidi_push_it, bidi_pop_it): New functions. |
| 1505 | (bidi_initialize): Initialize the bidi cache start stack pointer. |
| 1506 | (bidi_cache_ensure_space): New function, refactored from part of |
| 1507 | bidi_cache_iterator_state. Don't assume the required size is just |
| 1508 | one BIDI_CACHE_CHUNK away. |
| 1509 | (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE. |
| 1510 | (bidi_count_bytes, bidi_char_at_pos): New functions. |
| 1511 | (bidi_cache_search): Don't assume bidi_cache_last_idx is |
| 1512 | always valid if bidi_cache_idx is valid. |
| 1513 | (bidi_cache_find_level_change): xassert that bidi_cache_last_idx |
| 1514 | is valid if it's going to be used. |
| 1515 | (bidi_shelve_cache, bidi_unshelve_cache): New functions. |
| 1516 | (bidi_cache_fetch_state, bidi_cache_search) |
| 1517 | (bidi_cache_find_level_change, bidi_cache_ensure_space) |
| 1518 | (bidi_cache_iterator_state, bidi_cache_find) |
| 1519 | (bidi_find_other_level_edge, bidi_cache_start_stack): |
| 1520 | All variables related to cache indices are now EMACS_INT. |
| 1521 | |
| 1522 | * dispextern.h (struct bidi_string_data): New structure. |
| 1523 | (struct bidi_it): New member `string'. Make flag members be 1-bit |
| 1524 | fields, and put them last in the struct. |
| 1525 | (compute_display_string_pos, compute_display_string_end): |
| 1526 | Update prototypes. |
| 1527 | (bidi_push_it, bidi_pop_it): Add prototypes. |
| 1528 | (struct iterator_stack_entry): New members bidi_p, |
| 1529 | paragraph_embedding, and from_disp_prop_p. |
| 1530 | (struct it): Member bidi_p is now a bit field 1 bit wide. |
| 1531 | (bidi_shelve_cache, bidi_unshelve_cache): |
| 1532 | Declare prototypes. |
| 1533 | |
| 1534 | * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector) |
| 1535 | (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors |
| 1536 | and vector-like objects. |
| 1537 | |
| 1538 | * dispnew.c (buffer_posn_from_coords): Save and restore the bidi |
| 1539 | cache around display iteration. |
| 1540 | |
| 1541 | * window.c (Fwindow_end, window_scroll_pixel_based) |
| 1542 | (displayed_window_lines, Frecenter): Save and restore the bidi |
| 1543 | cache around display iteration. |
| 1544 | |
| 1545 | 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1546 | |
| 1547 | * editfns.c (Fdelete_region): Clarify the use of the named |
| 1548 | parameters (bug#6788). |
| 1549 | |
| 1550 | 2011-07-14 Martin Rudalics <rudalics@gmx.at> |
| 1551 | |
| 1552 | * indent.c (Fvertical_motion): Set and restore w->pointm when |
| 1553 | saving and restoring the window's buffer (Bug#9006). |
| 1554 | |
| 1555 | 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1556 | |
| 1557 | * editfns.c (Fstring_to_char): Clarify just what is returned |
| 1558 | (bug#6576). Text by Eli Zaretskii. |
| 1559 | |
| 1560 | 2011-07-13 Juanma Barranquero <lekktu@gmail.com> |
| 1561 | |
| 1562 | * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059). |
| 1563 | |
| 1564 | 2011-07-13 Eli Zaretskii <eliz@gnu.org> |
| 1565 | |
| 1566 | * buffer.c (mmap_find): Fix a typo. |
| 1567 | |
| 1568 | 2011-07-13 Johan Bockgård <bojohan@gnu.org> |
| 1569 | |
| 1570 | Fix execution of x selection hooks. |
| 1571 | * xselect.c (Qx_lost_selection_functions) |
| 1572 | (Qx_sent_selection_functions): New vars. |
| 1573 | (syms_of_xselect): DEFSYM them. |
| 1574 | (x_handle_selection_request): Pass Qx_sent_selection_functions |
| 1575 | rather than Vx_sent_selection_functions to Frun_hook_with_args. |
| 1576 | (x_handle_selection_clear,x_clear_frame_selections): |
| 1577 | Pass Qx_lost_selection_functions rather than |
| 1578 | Vx_lost_selection_functions to Frun_hook_with_args. |
| 1579 | |
| 1580 | 2011-07-13 Paul Eggert <eggert@cs.ucla.edu> |
| 1581 | |
| 1582 | * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking. |
| 1583 | The old code sometimes used this field without initializing it. |
| 1584 | |
| 1585 | * alloc.c (gc_sweep): Don't read past end of array. |
| 1586 | In theory, the old code could also have corrupted Emacs internals, |
| 1587 | though it'd be very unlikely. |
| 1588 | |
| 1589 | 2011-07-12 Andreas Schwab <schwab@linux-m68k.org> |
| 1590 | |
| 1591 | * character.c (Fcharacterp): Don't advertise optional ignored |
| 1592 | argument. (Bug#4026) |
| 1593 | |
| 1594 | 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1595 | |
| 1596 | * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier |
| 1597 | key" (bug#4257). |
| 1598 | |
| 1599 | * window.c (Fset_window_start): Doc fix (bug#4199). |
| 1600 | (Fset_window_hscroll): Ditto. |
| 1601 | |
| 1602 | 2011-07-12 Paul Eggert <eggert@cs.ucla.edu> |
| 1603 | |
| 1604 | Fix minor new problems caught by GCC 4.6.1. |
| 1605 | * term.c (init_tty): Remove unused local. |
| 1606 | * xsettings.c (store_monospaced_changed): Define this function only |
| 1607 | if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's |
| 1608 | not used otherwise. |
| 1609 | |
| 1610 | 2011-07-12 Chong Yidong <cyd@stupidchicken.com> |
| 1611 | |
| 1612 | * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300). |
| 1613 | |
| 1614 | 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1615 | |
| 1616 | * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows |
| 1617 | are the mini-buffer and the echo area (bug#3320). |
| 1618 | |
| 1619 | * term.c (init_tty): Remove support for supdup, c10 and perq |
| 1620 | terminals, which are no longer supported (bug#1482). |
| 1621 | |
| 1622 | 2011-07-10 Johan Bockgård <bojohan@gnu.org> |
| 1623 | |
| 1624 | * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check. |
| 1625 | |
| 1626 | 2011-07-10 Jan Djärv <jan.h.d@swipnet.se> |
| 1627 | |
| 1628 | * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event |
| 1629 | for non-popups (Bug#3642). |
| 1630 | |
| 1631 | 2011-07-10 Andreas Schwab <schwab@linux-m68k.org> |
| 1632 | |
| 1633 | * alloc.c (reset_malloc_hooks): Protoize. |
| 1634 | * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge) |
| 1635 | (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise. |
| 1636 | * cm.c (losecursor): Likewise. |
| 1637 | * data.c (fmod): Likewise. |
| 1638 | * dispnew.c (swap_glyphs_in_rows): Likewise. |
| 1639 | * emacs.c (memory_warning_signal): Likewise. |
| 1640 | * floatfns.c (float_error): Likewise. |
| 1641 | * font.c (check_gstring, check_otf_features, otf_tag_symbol) |
| 1642 | (otf_open, font_otf_capability, generate_otf_features) |
| 1643 | (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor): |
| 1644 | Likewise. |
| 1645 | * image.c (pbm_read_file): Likewise. |
| 1646 | * indent.c (string_display_width): Likewise. |
| 1647 | * intervals.c (check_for_interval, search_for_interval) |
| 1648 | (inc_interval_count, count_intervals, root_interval) |
| 1649 | (adjust_intervals_for_insertion, make_new_interval): Likewise. |
| 1650 | * lread.c (defalias): Likewise. |
| 1651 | * ralloc.c (r_alloc_check): Likewise. |
| 1652 | * regex.c (set_image_of_range_1, set_image_of_range) |
| 1653 | (regex_grow_registers): Likewise. |
| 1654 | * sysdep.c (strerror): Likewise. |
| 1655 | * termcap.c (valid_filename_p, tprint, main): Likewise. |
| 1656 | * tparam.c (main): Likewise. |
| 1657 | * unexhp9k800.c (run_time_remap, save_data_space) |
| 1658 | (update_file_ptrs, read_header, write_header, calculate_checksum) |
| 1659 | (copy_file, copy_rest, display_header): Likewise. |
| 1660 | * widget.c (mark_shell_size_user_specified, create_frame_gcs): |
| 1661 | Likewise. |
| 1662 | * xdisp.c (check_it): Likewise. |
| 1663 | * xfaces.c (register_color, unregister_color, unregister_colors): |
| 1664 | Likewise. |
| 1665 | * xfns.c (print_fontset_result): Likewise. |
| 1666 | * xrdb.c (member, fatal, main): Likewise. |
| 1667 | |
| 1668 | 2011-07-10 Paul Eggert <eggert@cs.ucla.edu> |
| 1669 | |
| 1670 | Fix minor problems found by static checking (Bug#9031). |
| 1671 | * chartab.c (char_table_set_range, map_sub_char_table): |
| 1672 | Remove unused locals. |
| 1673 | (uniprop_table): Now static. |
| 1674 | * composite.c (_work_char): Remove unused static var. |
| 1675 | |
| 1676 | 2011-07-09 Juanma Barranquero <lekktu@gmail.com> |
| 1677 | |
| 1678 | * chartab.c (uniprop_table_uncompress): Remove unused local variable. |
| 1679 | |
| 1680 | 2011-07-09 Jan Djärv <jan.h.d@swipnet.se> |
| 1681 | |
| 1682 | * gtkutil.c (qttip_cb): Remove code without function. |
| 1683 | |
| 1684 | 2011-07-09 Eli Zaretskii <eliz@gnu.org> |
| 1685 | |
| 1686 | * w32.c (pthread_sigmask): New stub. |
| 1687 | |
| 1688 | 2011-07-08 Paul Eggert <eggert@cs.ucla.edu> |
| 1689 | |
| 1690 | Use pthread_sigmask, not sigprocmask (Bug#9010). |
| 1691 | sigprocmask is portable only for single-threaded applications, and |
| 1692 | Emacs can be multi-threaded when it uses GTK. |
| 1693 | * Makefile.in (LIB_PTHREAD_SIGMASK): New macro. |
| 1694 | (LIBES): Use it. |
| 1695 | * callproc.c (Fcall_process): |
| 1696 | * process.c (create_process): |
| 1697 | * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask): |
| 1698 | Use pthread_sigmask, not sigprocmask. |
| 1699 | |
| 1700 | 2011-07-08 Jan Djärv <jan.h.d@swipnet.se> |
| 1701 | |
| 1702 | * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget. |
| 1703 | (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was |
| 1704 | wrong (Bug#8591). |
| 1705 | |
| 1706 | 2011-07-08 Jan Djärv <jan.h.d@swipnet.se> |
| 1707 | |
| 1708 | * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment. |
| 1709 | Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591). |
| 1710 | (xg_hide_tooltip): Fix comment. |
| 1711 | |
| 1712 | * nsterm.m (initFrameFromEmacs): Don't use ns_return_types |
| 1713 | in registerServicesMenuSendTypes. |
| 1714 | (validRequestorForSendType): Don't check ns_return_types. |
| 1715 | |
| 1716 | * nsfns.m (Fx_open_connection): Put NSStringPboardType into |
| 1717 | ns_return_type. |
| 1718 | |
| 1719 | 2011-07-08 Jason Rumney <jasonr@gnu.org> |
| 1720 | |
| 1721 | * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using |
| 1722 | frame struct members of non-existent frames (Bug#6284). |
| 1723 | |
| 1724 | 2011-07-08 Jan Djärv <jan.h.d@swipnet.se> |
| 1725 | |
| 1726 | * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and |
| 1727 | variable firstTime not needed on OSX >= 10.6. |
| 1728 | (setPosition): setFloatValue:knobProportion: is deprecated on OSX |
| 1729 | >= 10.5. Use setKnobProportion, setDoubleValue. |
| 1730 | |
| 1731 | * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4) |
| 1732 | (MAC_OS_X_VERSION_10_5): Define if not defined. |
| 1733 | (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6. |
| 1734 | (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6. |
| 1735 | (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6. |
| 1736 | |
| 1737 | * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods |
| 1738 | cString and lossyCString on OSX >= 10.4 |
| 1739 | |
| 1740 | * nsmenu.m (fillWithWidgetValue): Don't use depercated method |
| 1741 | sizeToFit on OSX >= 10.2. |
| 1742 | |
| 1743 | * nsimage.m (allocInitFromFile): Don't use deprecated method |
| 1744 | bestRepresentationForDevice on OSX >= 10.6. |
| 1745 | |
| 1746 | * nsfns.m (check_ns_display_info): Cast to long and use %ld in error |
| 1747 | to avoid warning. |
| 1748 | |
| 1749 | * emacs.c: Declare unexec_init_emacs_zone. |
| 1750 | |
| 1751 | * nsgui.h: Fix compiler warning about gnulib redefining verify. |
| 1752 | |
| 1753 | * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842). |
| 1754 | |
| 1755 | * nsmenu.m (ns_update_menubar): Remove useless setDelegate call |
| 1756 | on svcsMenu (Bug#8842). |
| 1757 | |
| 1758 | * nsfns.m (Fx_open_connection): Remove NSStringPboardType from |
| 1759 | ns_return_types. |
| 1760 | (Fns_list_services): Just return Qnil on 10.6, code not working there. |
| 1761 | |
| 1762 | * nsterm.m (QUTF8_STRING): Declare. |
| 1763 | (initFrameFromEmacs): Call registerServicesMenuSendTypes. |
| 1764 | (validRequestorForSendType): Return type is (id). |
| 1765 | Change indexOfObjectIdenticalTo to indexOfObject. |
| 1766 | Check if we have local selection before returning self (Bug#8842). |
| 1767 | (writeSelectionToPasteboard): Put local selection into paste board |
| 1768 | if we have a local selection (Bug#8842). |
| 1769 | (syms_of_nsterm): DEFSYM QUTF8_STRING. |
| 1770 | |
| 1771 | * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m. |
| 1772 | (ns_get_local_selection): Declare. |
| 1773 | |
| 1774 | 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1775 | |
| 1776 | * keymap.c (describe_map_tree): Don't insert a double newline at |
| 1777 | the end of the buffer (bug#1169) and return whether we inserted |
| 1778 | something. |
| 1779 | |
| 1780 | * callint.c (Fcall_interactively): Change "reading args" to |
| 1781 | "providing args" to try to clarify what it does (bug#1010). |
| 1782 | |
| 1783 | 2011-07-07 Kenichi Handa <handa@m17n.org> |
| 1784 | |
| 1785 | * composite.c (composition_compute_stop_pos): Ignore a static |
| 1786 | composition starting before CHARPOS (Bug#8915). |
| 1787 | |
| 1788 | * xdisp.c (handle_composition_prop): Likewise. |
| 1789 | |
| 1790 | 2011-07-07 Eli Zaretskii <eliz@gnu.org> |
| 1791 | |
| 1792 | * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what. |
| 1793 | (Bug#9015) |
| 1794 | |
| 1795 | 2011-07-07 Kenichi Handa <handa@m17n.org> |
| 1796 | |
| 1797 | * character.h (unicode_category_t): New enum type. |
| 1798 | |
| 1799 | * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types. |
| 1800 | (Qchar_code_property_table): New variable. |
| 1801 | (UNIPROP_TABLE_P, UNIPROP_GET_DECODER) |
| 1802 | (UNIPROP_COMPRESSED_FORM_P): New macros. |
| 1803 | (char_table_ascii): Uncompress the compressed values. |
| 1804 | (sub_char_table_ref): New arg is_uniprop. Callers changed. |
| 1805 | Uncompress the compressed values. |
| 1806 | (sub_char_table_ref_and_range): Likewise. |
| 1807 | (char_table_ref_and_range): Uncompress the compressed values. |
| 1808 | (sub_char_table_set): New arg is_uniprop. Callers changed. |
| 1809 | Uncompress the compressed values. |
| 1810 | (sub_char_table_set_range): Args changed. Callers changed. |
| 1811 | (char_table_set_range): Adjuted for the above change. |
| 1812 | (map_sub_char_table): Delete args default_val and parent. Add arg |
| 1813 | top. Give decoded values to a Lisp function. |
| 1814 | (map_char_table): Adjust for the above change. Give decoded |
| 1815 | values to a Lisp function. Gcpro more variables. |
| 1816 | (uniprop_table_uncompress) |
| 1817 | (uniprop_decode_value_run_length): New functions. |
| 1818 | (uniprop_decoder, uniprop_decoder_count): New variables. |
| 1819 | (uniprop_get_decoder, uniprop_encode_value_character) |
| 1820 | (uniprop_encode_value_run_length, uniprop_encode_value_numeric): |
| 1821 | New functions. |
| 1822 | (uniprop_encoder, uniprop_encoder_count): New variables. |
| 1823 | (uniprop_get_encoder, uniprop_table) |
| 1824 | (Funicode_property_table_internal, Fget_unicode_property_internal) |
| 1825 | (Fput_unicode_property_internal): New functions. |
| 1826 | (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr |
| 1827 | Sunicode_property_table_internal, Sget_unicode_property_internal, |
| 1828 | and Sput_unicode_property_internal. Defvar_lisp |
| 1829 | char-code-property-alist. |
| 1830 | |
| 1831 | * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of |
| 1832 | Vunicode_category_table. |
| 1833 | |
| 1834 | * font.c (font_range): Adjust for the change of |
| 1835 | Vunicode_category_table. |
| 1836 | |
| 1837 | 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu> |
| 1838 | |
| 1839 | * m/iris4d.h: Remove file, move contents ... |
| 1840 | * s/irix6-5.h: ... here. |
| 1841 | |
| 1842 | 2011-07-06 Paul Eggert <eggert@cs.ucla.edu> |
| 1843 | |
| 1844 | Remove unportable assumption about struct layout (Bug#8884). |
| 1845 | * alloc.c (mark_buffer): |
| 1846 | * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables) |
| 1847 | (clone_per_buffer_values): Don't assume that |
| 1848 | sizeof (struct buffer) is a multiple of sizeof (Lisp_Object). |
| 1849 | This isn't true in general, and it's particularly not true |
| 1850 | if Emacs is configured with --with-wide-int. |
| 1851 | * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): |
| 1852 | New macros, used in the buffer.c change. |
| 1853 | |
| 1854 | 2011-07-05 Jan Djärv <jan.h.d@swipnet.se> |
| 1855 | |
| 1856 | * xsettings.c: Use both GConf and GSettings if both are available. |
| 1857 | (store_config_changed_event): Add comment. |
| 1858 | (dpyinfo_valid, store_font_name_changed, map_tool_bar_style) |
| 1859 | (store_tool_bar_style_changed): New functions. |
| 1860 | (store_monospaced_changed): Add comment. Call dpyinfo_valid. |
| 1861 | (struct xsettings): Move font inside HAVE_XFT. |
| 1862 | (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines. |
| 1863 | (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT. |
| 1864 | Move inside HAVE_XFT. |
| 1865 | (something_changed_gsettingsCB): Rename from something_changedCB. |
| 1866 | Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME |
| 1867 | also. |
| 1868 | (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines. |
| 1869 | (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT. |
| 1870 | (something_changed_gconfCB): Rename from something_changedCB. |
| 1871 | Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also. |
| 1872 | (parse_settings): Move check for font inside HAVE_XFT. |
| 1873 | (read_settings, apply_xft_settings): Add comment. |
| 1874 | (read_and_apply_settings): Add comment. Call map_tool_bar_style and |
| 1875 | store_tool_bar_style_changed. Move check for font inside HAVE_XFT and |
| 1876 | call store_font_name_changed. |
| 1877 | (xft_settings_event): Add comment. |
| 1878 | (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE |
| 1879 | and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT. |
| 1880 | (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE |
| 1881 | and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT. |
| 1882 | (xsettings_initialize): Call init_gsettings last. |
| 1883 | (xsettings_get_system_font, xsettings_get_system_normal_font): |
| 1884 | Add comment. |
| 1885 | |
| 1886 | 2011-07-05 Paul Eggert <eggert@cs.ucla.edu> |
| 1887 | |
| 1888 | Random fixes. E.g., (random) never returned negative values. |
| 1889 | * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the |
| 1890 | subseconds part to the entropy, as that's a bit more random. |
| 1891 | Prefer signed to unsigned, since the signedness doesn't matter and |
| 1892 | in general we prefer signed. When given a limit, use a |
| 1893 | denominator equal to INTMASK + 1, not to VALMASK + 1, because the |
| 1894 | latter isn't right if USE_2_TAGS_FOR_INTS. |
| 1895 | * sysdep.c (get_random): Return a value in the range 0..INTMASK, |
| 1896 | not 0..VALMASK. Don't discard "excess" bits that random () returns. |
| 1897 | |
| 1898 | 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca> |
| 1899 | |
| 1900 | * textprop.c (text_property_stickiness): |
| 1901 | Obey Vtext_property_default_nonsticky. |
| 1902 | (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky. |
| 1903 | * w32fns.c (syms_of_w32fns): |
| 1904 | * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default. |
| 1905 | |
| 1906 | 2011-07-04 Paul Eggert <eggert@cs.ucla.edu> |
| 1907 | |
| 1908 | * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR. |
| 1909 | This is more efficient than Ffile_directory_p and avoids a minor race. |
| 1910 | |
| 1911 | 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1912 | |
| 1913 | * buffer.c (Foverlay_put): Say what the return value is |
| 1914 | (bug#7835). |
| 1915 | |
| 1916 | * fileio.c (barf_or_query_if_file_exists): Check first if the file |
| 1917 | is a directory before asking whether to use the file name |
| 1918 | (bug#7564). |
| 1919 | (barf_or_query_if_file_exists): Make the "File is a directory" |
| 1920 | error be more correct. |
| 1921 | |
| 1922 | * fns.c (Frequire): Remove the mention of the .gz files, since |
| 1923 | that's installation-specific, but keep the mention of |
| 1924 | `get-load-suffixes'. |
| 1925 | |
| 1926 | 2011-07-04 Paul Eggert <eggert@cs.ucla.edu> |
| 1927 | |
| 1928 | * editfns.c (Fformat_time_string): Don't assume strlen fits in int. |
| 1929 | Report string overflow if the output is too long. |
| 1930 | |
| 1931 | 2011-07-04 Juanma Barranquero <lekktu@gmail.com> |
| 1932 | |
| 1933 | * gnutls.c (Fgnutls_boot): Don't mention :verify-error. |
| 1934 | (syms_of_gnutls): Remove duplicate DEFSYM for |
| 1935 | Qgnutls_bootprop_verify_hostname_error, an error for |
| 1936 | Qgnutls_bootprop_verify_error (which is no longer used). |
| 1937 | |
| 1938 | * eval.c (find_handler_clause): Remove parameters `sig' and `data', |
| 1939 | unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed. |
| 1940 | Also (re)move comments that are misplaced or no longer relevant. |
| 1941 | |
| 1942 | 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1943 | |
| 1944 | * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813). |
| 1945 | |
| 1946 | 2011-07-03 Chong Yidong <cyd@stupidchicken.com> |
| 1947 | |
| 1948 | * xfaces.c (Finternal_merge_in_global_face): Modify the foreground |
| 1949 | and background color parameters if they have been changed. |
| 1950 | |
| 1951 | 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1952 | |
| 1953 | * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659). |
| 1954 | |
| 1955 | 2011-07-03 Paul Eggert <eggert@cs.ucla.edu> |
| 1956 | |
| 1957 | * xsettings.c (SYSTEM_FONT): Define only when used. |
| 1958 | No need to define when HAVE_GSETTINGS || !HAVE_XFT. |
| 1959 | |
| 1960 | * keymap.c (access_keymap_1): Now static. |
| 1961 | |
| 1962 | 2011-07-02 Chong Yidong <cyd@stupidchicken.com> |
| 1963 | |
| 1964 | * keyboard.c (command_loop_1): If a down-mouse event is unbound, |
| 1965 | leave any prefix arg for the up event (Bug#1586). |
| 1966 | |
| 1967 | 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 1968 | |
| 1969 | * lread.c (syms_of_lread): Mention single symbols defined by |
| 1970 | `defvar' or `defconst' (bug#7154). |
| 1971 | |
| 1972 | * fns.c (Frequire): Mention .el.gz files (bug#7314). |
| 1973 | (Frequire): Mention get-load-suffixes. |
| 1974 | |
| 1975 | 2011-07-02 Martin Rudalics <rudalics@gmx.at> |
| 1976 | |
| 1977 | * window.h (window): Remove clone_number slot. |
| 1978 | * window.c (Fwindow_clone_number, Fset_window_clone_number): |
| 1979 | Remove. |
| 1980 | (make_parent_window, make_window, saved_window) |
| 1981 | (Fset_window_configuration, save_window_save): Don't deal with |
| 1982 | clone numbers. |
| 1983 | * buffer.c (Qclone_number): Remove declaration. |
| 1984 | (sort_overlays, overlay_strings): Don't deal with clone numbers. |
| 1985 | |
| 1986 | 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca> |
| 1987 | |
| 1988 | Add multiple inheritance to keymaps. |
| 1989 | * keymap.c (Fmake_composed_keymap): New function. |
| 1990 | (Fset_keymap_parent): Simplify. |
| 1991 | (fix_submap_inheritance): Remove. |
| 1992 | (access_keymap_1): New function extracted from access_keymap to handle |
| 1993 | embedded parents and handle lists of maps. |
| 1994 | (access_keymap): Use it. |
| 1995 | (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap) |
| 1996 | (Fcopy_keymap): Handle embedded parents. |
| 1997 | (Fcommand_remapping, define_as_prefix): Simplify. |
| 1998 | (Fkey_binding): Simplify. |
| 1999 | (syms_of_keymap): Move minibuffer-local-completion-map, |
| 2000 | minibuffer-local-filename-completion-map, |
| 2001 | minibuffer-local-must-match-map, and |
| 2002 | minibuffer-local-filename-must-match-map to Elisp. |
| 2003 | (syms_of_keymap): Defsubr make-composed-keymap. |
| 2004 | * keyboard.c (menu_bar_items): Use map_keymap_canonical. |
| 2005 | (parse_menu_item): Trivial simplification. |
| 2006 | |
| 2007 | 2011-07-01 Glenn Morris <rgm@gnu.org> |
| 2008 | |
| 2009 | * Makefile.in (SETTINGS_LIBS): Fix typo. |
| 2010 | |
| 2011 | 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch) |
| 2012 | |
| 2013 | * coding.c (Fencode_coding_string): Record the last coding system |
| 2014 | used, as the function doc string says (bug#8738). |
| 2015 | |
| 2016 | 2011-07-01 Jan Djärv <jan.h.d@swipnet.se> |
| 2017 | |
| 2018 | * xsettings.c (store_monospaced_changed): Take new font as arg and |
| 2019 | check for change against current_mono_font. |
| 2020 | (EMACS_TYPE_SETTINGS): Remove this and related defines. |
| 2021 | (emacs_settings_constructor, emacs_settings_get_property) |
| 2022 | (emacs_settings_set_property, emacs_settings_class_init) |
| 2023 | (emacs_settings_init, gsettings_obj): Remove. |
| 2024 | (something_changedCB): New function for HAVE_GSETTINGS. |
| 2025 | (something_changedCB): HAVE_GCONF: Call store_monospaced_changed |
| 2026 | with value as argument. |
| 2027 | (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling |
| 2028 | g_settings_new (Bug#8967). Do not create gsettings_obj. |
| 2029 | Remove calls to g_settings_bind. Connect something_changedCB to |
| 2030 | "changed". |
| 2031 | |
| 2032 | * xgselect.c: Add defined (HAVE_GSETTINGS). |
| 2033 | (xgselect_initialize): Ditto. |
| 2034 | |
| 2035 | * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h |
| 2036 | (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for |
| 2037 | xg_select. |
| 2038 | |
| 2039 | 2011-07-01 Paul Eggert <eggert@cs.ucla.edu> |
| 2040 | |
| 2041 | * eval.c (struct backtrace): Simplify and port the data structure. |
| 2042 | Do not assume that "int nargs : BITS_PER_INT - 2;" produces a |
| 2043 | signed bit field, as this assumption is not portable and it makes |
| 2044 | Emacs crash when compiled with Sun C 5.8 on sparc. Do not use |
| 2045 | "char debug_on_exit : 1" as this is not portable either; instead, |
| 2046 | use the portable "unsigned int debug_on_exit : 1". Remove unused |
| 2047 | member evalargs. Remove obsolete comments about cc bombing out. |
| 2048 | |
| 2049 | 2011-06-30 Jan Djärv <jan.h.d@swipnet.se> |
| 2050 | |
| 2051 | * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS. |
| 2052 | Let HAVE_GSETTINGS override HAVE_GCONF. |
| 2053 | (store_monospaced_changed): New function. |
| 2054 | (EMACS_SETTINGS): A new type derived from GObject to handle |
| 2055 | GSettings notifications. |
| 2056 | (emacs_settings_constructor, emacs_settings_get_property) |
| 2057 | (emacs_settings_set_property, emacs_settings_class_init): |
| 2058 | New functions. |
| 2059 | (gsettings_client, gsettings_obj): New variables. |
| 2060 | (GSETTINGS_SCHEMA): New define. |
| 2061 | (something_changedCB): Call store_monospaced_changed. |
| 2062 | (init_gsettings): New function. |
| 2063 | (xsettings_initialize): Call init_gsettings. |
| 2064 | (syms_of_xsettings): Initialize gsettings_client, gsettings_obj |
| 2065 | to NULL. |
| 2066 | |
| 2067 | * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from |
| 2068 | GCONF_CFLAGS/LIBS. |
| 2069 | |
| 2070 | 2011-06-29 Martin Rudalics <rudalics@gmx.at> |
| 2071 | |
| 2072 | * window.c (resize_root_window, grow_mini_window) |
| 2073 | (shrink_mini_window): Rename Qresize_root_window to |
| 2074 | Qwindow_resize_root_window and Qresize_root_window_vertically to |
| 2075 | Qwindow_resize_root_window_vertically. |
| 2076 | |
| 2077 | 2011-06-28 Paul Eggert <eggert@cs.ucla.edu> |
| 2078 | |
| 2079 | * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var. |
| 2080 | |
| 2081 | 2011-06-27 Juanma Barranquero <lekktu@gmail.com> |
| 2082 | |
| 2083 | * makefile.w32-in: Redesign dependencies so they reflect more |
| 2084 | clearly which files are directly included by each source file, |
| 2085 | and not through other includes. |
| 2086 | |
| 2087 | 2011-06-27 Martin Rudalics <rudalics@gmx.at> |
| 2088 | |
| 2089 | * buffer.c (Qclone_number): Declare static and DEFSYM it. |
| 2090 | (sort_overlays, overlay_strings): When an overlay's clone number |
| 2091 | matches the window's clone number process the overlay even if |
| 2092 | the overlay's window property doesn't match the current window. |
| 2093 | |
| 2094 | * window.c (Fwindow_vchild): Rename to Fwindow_top_child. |
| 2095 | (Fwindow_hchild): Rename to Fwindow_left_child. |
| 2096 | (Fwindow_next): Rename to Fwindow_next_sibling. |
| 2097 | (Fwindow_prev): Rename to Fwindow_prev_sibling. |
| 2098 | (resize_window_check): Rename to window_resize_check. |
| 2099 | (resize_window_apply): Rename to window_resize_apply. |
| 2100 | (Fresize_window_apply): Rename to Fwindow_resize_apply. |
| 2101 | (Fdelete_other_windows_internal, resize_frame_windows) |
| 2102 | (Fsplit_window_internal, Fdelete_window_internal) |
| 2103 | (grow_mini_window, shrink_mini_window) |
| 2104 | (Fresize_mini_window_internal): Fix callers accordingly. |
| 2105 | |
| 2106 | 2011-06-26 Jan Djärv <jan.h.d@swipnet.se> |
| 2107 | |
| 2108 | * emacsgtkfixed.h: State that this is only used with Gtk+3. |
| 2109 | (emacs_fixed_set_min_size): Remove. |
| 2110 | (emacs_fixed_new): Take frame as argument. |
| 2111 | |
| 2112 | * emacsgtkfixed.c: State that this is only used with Gtk+3. |
| 2113 | (_EmacsFixedPrivate): Remove minwidth/height. |
| 2114 | Add struct frame *f. |
| 2115 | (emacs_fixed_init): Initialize priv->f. |
| 2116 | (get_parent_class, emacs_fixed_set_min_size): Remove. |
| 2117 | (emacs_fixed_new): Set priv->f to argument. |
| 2118 | (emacs_fixed_get_preferred_width) |
| 2119 | (emacs_fixed_get_preferred_height): Use min_width/height from |
| 2120 | frames size_hint to set minimum and natural (Bug#8919). |
| 2121 | (XSetWMSizeHints, XSetWMNormalHints): Override these functions |
| 2122 | and use min_width/height from frames size_hint to set |
| 2123 | min_width/height (Bug#8919). |
| 2124 | |
| 2125 | * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new. |
| 2126 | (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. |
| 2127 | Fix indentation. |
| 2128 | |
| 2129 | 2011-06-26 Eli Zaretskii <eliz@gnu.org> |
| 2130 | |
| 2131 | * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling |
| 2132 | bidi_at_paragraph_end, since fast_looking_at doesn't like to be |
| 2133 | called at ZV. |
| 2134 | |
| 2135 | 2011-06-26 Chong Yidong <cyd@stupidchicken.com> |
| 2136 | |
| 2137 | * process.c (wait_reading_process_output): Bypass select if |
| 2138 | waiting for a cell while ignoring keyboard input, and input is |
| 2139 | pending. Suggested by Jan Djärv (Bug#8869). |
| 2140 | |
| 2141 | 2011-06-25 Paul Eggert <eggert@cs.ucla.edu> |
| 2142 | |
| 2143 | Use gnulib's dup2 module instead of rolling our own. |
| 2144 | * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this. |
| 2145 | |
| 2146 | 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
| 2147 | |
| 2148 | * dispnew.c (scrolling_window): Before scrolling, turn off a |
| 2149 | mouse-highlight in the window being scrolled. |
| 2150 | |
| 2151 | 2011-06-24 Juanma Barranquero <lekktu@gmail.com> |
| 2152 | |
| 2153 | Move DEFSYM to lisp.h and use everywhere. |
| 2154 | |
| 2155 | * character.h (DEFSYM): Move declaration... |
| 2156 | * lisp.h (DEFSYM): ...here. |
| 2157 | |
| 2158 | * gnutls.c: |
| 2159 | * minibuf.c: |
| 2160 | * w32menu.c: |
| 2161 | * w32proc.c: |
| 2162 | * w32select.c: Don't include character.h. |
| 2163 | |
| 2164 | * alloc.c (syms_of_alloc): |
| 2165 | * buffer.c (syms_of_buffer): |
| 2166 | * bytecode.c (syms_of_bytecode): |
| 2167 | * callint.c (syms_of_callint): |
| 2168 | * casefiddle.c (syms_of_casefiddle): |
| 2169 | * casetab.c (init_casetab_once): |
| 2170 | * category.c (init_category_once, syms_of_category): |
| 2171 | * ccl.c (syms_of_ccl): |
| 2172 | * cmds.c (syms_of_cmds): |
| 2173 | * composite.c (syms_of_composite): |
| 2174 | * dbusbind.c (syms_of_dbusbind): |
| 2175 | * dired.c (syms_of_dired): |
| 2176 | * dispnew.c (syms_of_display): |
| 2177 | * doc.c (syms_of_doc): |
| 2178 | * editfns.c (syms_of_editfns): |
| 2179 | * emacs.c (syms_of_emacs): |
| 2180 | * eval.c (syms_of_eval): |
| 2181 | * fileio.c (syms_of_fileio): |
| 2182 | * fns.c (syms_of_fns): |
| 2183 | * frame.c (syms_of_frame): |
| 2184 | * fringe.c (syms_of_fringe): |
| 2185 | * insdel.c (syms_of_insdel): |
| 2186 | * keymap.c (syms_of_keymap): |
| 2187 | * lread.c (init_obarray, syms_of_lread): |
| 2188 | * macros.c (syms_of_macros): |
| 2189 | * msdos.c (syms_of_msdos): |
| 2190 | * print.c (syms_of_print): |
| 2191 | * process.c (syms_of_process): |
| 2192 | * search.c (syms_of_search): |
| 2193 | * sound.c (syms_of_sound): |
| 2194 | * syntax.c (init_syntax_once, syms_of_syntax): |
| 2195 | * terminal.c (syms_of_terminal): |
| 2196 | * textprop.c (syms_of_textprop): |
| 2197 | * undo.c (syms_of_undo): |
| 2198 | * w32.c (globals_of_w32): |
| 2199 | * window.c (syms_of_window): |
| 2200 | * xdisp.c (syms_of_xdisp): |
| 2201 | * xfaces.c (syms_of_xfaces): |
| 2202 | * xfns.c (syms_of_xfns): |
| 2203 | * xmenu.c (syms_of_xmenu): |
| 2204 | * xsettings.c (syms_of_xsettings): |
| 2205 | * xterm.c (syms_of_xterm): Use DEFSYM. |
| 2206 | |
| 2207 | 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com> |
| 2208 | |
| 2209 | * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h. |
| 2210 | |
| 2211 | 2011-06-23 Paul Eggert <eggert@cs.ucla.edu> |
| 2212 | |
| 2213 | Integer and buffer overflow fixes (Bug#8873). |
| 2214 | |
| 2215 | * print.c (printchar, strout): Check for string overflow. |
| 2216 | (PRINTPREPARE, printchar, strout): |
| 2217 | Don't set size unless allocation succeeds. |
| 2218 | |
| 2219 | * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int, |
| 2220 | for sizes. Check for string overflow more accurately. |
| 2221 | Simplify newline removal at end; this suppresses a GCC 4.6.0 warning. |
| 2222 | |
| 2223 | * macros.c: Integer and buffer overflow fixes. |
| 2224 | * keyboard.h (struct keyboard.kbd_macro_bufsize): |
| 2225 | * macros.c (Fstart_kbd_macro, store_kbd_macro_char): |
| 2226 | Use ptrdiff_t, not int, for sizes. |
| 2227 | Don't increment bufsize until after realloc succeeds. |
| 2228 | Check for size-calculation overflow. |
| 2229 | (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result. |
| 2230 | |
| 2231 | * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling. |
| 2232 | |
| 2233 | * lread.c: Integer overflow fixes. |
| 2234 | (read_integer): Radix is now EMACS_INT, not int, |
| 2235 | to improve quality of diagnostics for out-of-range radices. |
| 2236 | Calculate buffer size correctly for out-of-range radices. |
| 2237 | (read1): Check for integer overflow in radices, and in |
| 2238 | read-circle numbers. |
| 2239 | (read_escape): Avoid int overflow. |
| 2240 | (Fload, openp, read_buffer_size, read1) |
| 2241 | (substitute_object_recurse, read_vector, read_list, map_obarray): |
| 2242 | Use ptrdiff_t, not int, for sizes. |
| 2243 | (read1): Use EMACS_INT, not int, for sizes. |
| 2244 | Check for size overflow. |
| 2245 | |
| 2246 | * image.c (cache_image): Check for size arithmetic overflow. |
| 2247 | |
| 2248 | * lread.c: Integer overflow issues. |
| 2249 | (saved_doc_string_size, saved_doc_string_length) |
| 2250 | (prev_saved_doc_string_size, prev_saved_doc_string_length): |
| 2251 | Now ptrdiff_t, not int. |
| 2252 | (read1): Don't assume doc string length fits in int. Check for |
| 2253 | out-of-range doc string lengths. |
| 2254 | (read_list): Don't assume file position fits in int. |
| 2255 | (read_escape): Check for hex character overflow. |
| 2256 | |
| 2257 | 2011-06-22 Leo Liu <sdl.web@gmail.com> |
| 2258 | |
| 2259 | * minibuf.c (Fcompleting_read_default, Vcompleting_read_function): |
| 2260 | Move to minibuffer.el. |
| 2261 | |
| 2262 | 2011-06-22 Paul Eggert <eggert@cs.ucla.edu> |
| 2263 | |
| 2264 | Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking. |
| 2265 | The following patches are for when GLYPH_DEBUG && !XASSERT. |
| 2266 | * dispextern.h (trace_redisplay_p, dump_glyph_string): |
| 2267 | * dispnew.c (flush_stdout): |
| 2268 | * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph): |
| 2269 | Mark as externally visible. |
| 2270 | * dispnew.c (check_window_matrix_pointers): Now static. |
| 2271 | * dispnew.c (window_to_frame_vpos): |
| 2272 | * xfns.c (unwind_create_frame): |
| 2273 | * xterm.c (x_check_font): Remove unused local. |
| 2274 | * scroll.c (CHECK_BOUNDS): |
| 2275 | * xfaces.c (cache_fache): Rename local to avoid shadowing. |
| 2276 | * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static. |
| 2277 | * xdisp.c (check_window_end): Now a no-op if !XASSERTS. |
| 2278 | (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos) |
| 2279 | (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos): |
| 2280 | Now static. |
| 2281 | (debug_method_add): Use va_list and vsprintf rather than relying |
| 2282 | on undefined behavior with wrong number of arguments. |
| 2283 | (dump_glyph, dump_glyph_row, Fdump_glyph_matrix): |
| 2284 | Don't assume ptrdiff_t and EMACS_INT are the same width as int. |
| 2285 | In this code, it's OK to assume C99 behavior for ptrdiff_t formats |
| 2286 | since we're not interested in debugging glyphs with old libraries. |
| 2287 | * xfaces.c (cache_face): Move debugging code earlier; this pacifies |
| 2288 | GCC 4.6.0's static checking. |
| 2289 | |
| 2290 | 2011-06-22 Paul Eggert <eggert@cs.ucla.edu> |
| 2291 | |
| 2292 | Integer overflow and signedness fixes (Bug#8873). |
| 2293 | A few related buffer overrun fixes, too. |
| 2294 | |
| 2295 | * font.c (font_score): Use EMACS_INT, not int, to store XINT value. |
| 2296 | |
| 2297 | * dispextern.h (struct face.stipple): |
| 2298 | * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap) |
| 2299 | (x_bitmap_mask, x_allocate_bitmap_record) |
| 2300 | (x_create_bitmap_from_data, x_create_bitmap_from_file) |
| 2301 | (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask) |
| 2302 | (x_create_bitmap_from_xpm_data): |
| 2303 | * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last): |
| 2304 | * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size) |
| 2305 | (.bitmaps_last): |
| 2306 | * xfaces.c (load_pixmap): |
| 2307 | * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap): |
| 2308 | * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size) |
| 2309 | (.bitmaps_last, struct x_output.icon_bitmap): |
| 2310 | Use ptrdiff_t, not int, for bitmap indexes. |
| 2311 | (x_allocate_bitmap_record): Check for size overflow. |
| 2312 | * dispextern.h, lisp.h: Adjust to API changes elsewhere. |
| 2313 | |
| 2314 | Use ptrdiff_t, not int, for overlay counts. |
| 2315 | * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT): |
| 2316 | * editfns.c (overlays_around, get_pos_property): |
| 2317 | * textprop.c (get_char_property_and_overlay): |
| 2318 | * xdisp.c (next_overlay_change, note_mouse_highlight): |
| 2319 | * xfaces.c (face_at_buffer_position): |
| 2320 | * buffer.c (OVERLAY_COUNT_MAX): New macro. |
| 2321 | (overlays_at, overlays_in, sort_overlays, Foverlays_at) |
| 2322 | (Fnext_overlay_change, Fprevious_overlay_change) |
| 2323 | (mouse_face_overlay_overlaps, Foverlays_in): |
| 2324 | Use ptrdiff_t, not int, for sizes. |
| 2325 | (overlays_at, overlays_in): Check for size-calculation overflow. |
| 2326 | |
| 2327 | * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int. |
| 2328 | |
| 2329 | * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen. |
| 2330 | (x_session_initialize): Do not assume string length fits in int. |
| 2331 | |
| 2332 | * xsettings.c (apply_xft_settings): Fix potential buffer overrun. |
| 2333 | This is unlikely, but can occur if DPI is outlandish. |
| 2334 | |
| 2335 | * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font): |
| 2336 | * xselect.c (Fx_get_atom_name): Avoid need for strlen. |
| 2337 | |
| 2338 | * xrdb.c: Don't assume strlen fits in int; avoid some strlens. |
| 2339 | * xrdb.c (magic_file_p, search_magic_path): |
| 2340 | Omit last arg SUFFIX; it was always 0. All callers changed. |
| 2341 | (magic_file_p): Use ptrdiff_t, not int. Check for size overflow. |
| 2342 | |
| 2343 | * xfont.c (xfont_match): Avoid need for strlen. |
| 2344 | |
| 2345 | * xfns.c: Don't assume strlen fits in int. |
| 2346 | (xic_create_fontsetname, x_window): Use ptrdiff_t, not int. |
| 2347 | |
| 2348 | * xdisp.c (message_log_check_duplicate): Return intmax_t, |
| 2349 | not unsigned long, as we prefer signed integers. All callers changed. |
| 2350 | Detect integer overflow in repeat count. |
| 2351 | (message_dolog): Don't assume print length fits in 39 bytes. |
| 2352 | (display_mode_element): Don't assume strlen fits in int. |
| 2353 | |
| 2354 | * termcap.c: Don't assume sizes fit in int and never overflow. |
| 2355 | (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes. |
| 2356 | (gobble_line): Check for size-calculation overflow. |
| 2357 | |
| 2358 | * minibuf.c (Fread_buffer): |
| 2359 | * lread.c (intern, intern_c_string): |
| 2360 | * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]: |
| 2361 | Don't assume string length fits in int. |
| 2362 | |
| 2363 | * keyboard.c (parse_tool_bar_item): |
| 2364 | * gtkutil.c (style_changed_cb): Avoid need for strlen. |
| 2365 | |
| 2366 | * font.c: Don't assume string length fits in int. |
| 2367 | (font_parse_xlfd, font_parse_fcname, font_unparse_fcname): |
| 2368 | Use ptrdiff_t, not int. |
| 2369 | (font_intern_prop): Don't assume string length fits in int. |
| 2370 | Don't assume integer property fits in fixnum. |
| 2371 | * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int. |
| 2372 | |
| 2373 | * filelock.c: Fix some buffer overrun and integer overflow issues. |
| 2374 | (get_boot_time): Don't assume gzip command string fits in 100 bytes. |
| 2375 | Reformulate so as not to need the command string. |
| 2376 | Invoke gzip -cd rather than gunzip, as it's more portable. |
| 2377 | (lock_info_type, lock_file_1, lock_file): |
| 2378 | Don't assume pid_t and time_t fit in unsigned long. |
| 2379 | (LOCK_PID_MAX): Remove; we now use more-reliable bounds. |
| 2380 | (current_lock_owner): Prefer signed type for sizes. |
| 2381 | Use memcpy, not strncpy, where memcpy is what is really wanted. |
| 2382 | Don't assume (via atoi) that time_t and pid_t fit in int. |
| 2383 | Check for time_t and/or pid_t out of range, e.g., via a network share. |
| 2384 | Don't alloca where an auto var works fine. |
| 2385 | |
| 2386 | * fileio.c: Fix some integer overflow issues. |
| 2387 | (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name): |
| 2388 | Don't assume string length fits in int. |
| 2389 | (directory_file_name): Don't assume string length fits in long. |
| 2390 | (make_temp_name): Don't assume pid fits in int, or that its print |
| 2391 | length is less than 20. |
| 2392 | |
| 2393 | * data.c (Fsubr_name): Rewrite to avoid a strlen call. |
| 2394 | |
| 2395 | * coding.c (make_subsidiaries): Don't assume string length fits in int. |
| 2396 | |
| 2397 | * callproc.c (child_setup): Rewrite to avoid two strlen calls. |
| 2398 | |
| 2399 | * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT. |
| 2400 | We prefer signed integers, even for size calculations. |
| 2401 | |
| 2402 | * emacs.c: Don't assume string length fits in 'int'. |
| 2403 | (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int. |
| 2404 | (main): Don't invoke strlen when not needed. |
| 2405 | |
| 2406 | * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string. |
| 2407 | (XD_DEBUG_MESSAGE): Don't waste a byte. |
| 2408 | |
| 2409 | * callproc.c (getenv_internal_1, getenv_internal) |
| 2410 | (Fgetenv_internal): |
| 2411 | * buffer.c (init_buffer): Don't assume string length fits in 'int'. |
| 2412 | |
| 2413 | * lread.c (invalid_syntax): Omit length argument. |
| 2414 | All uses changed. This doesn't fix a bug, but it simplifies the |
| 2415 | code away from its former Hollerith-constant appearance, and it's |
| 2416 | one less 'int' to worry about when looking at integer-overflow issues. |
| 2417 | (string_to_number): Simplify 2011-04-26 change by invoking xsignal1. |
| 2418 | |
| 2419 | * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr). |
| 2420 | This didn't break anything, but it didn't help either. |
| 2421 | It's confusing to put a bogus integer in a place where the actual |
| 2422 | value does not matter. |
| 2423 | (LIST_END_P): Remove unused macro and its bogus comment. |
| 2424 | (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT. |
| 2425 | |
| 2426 | * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT. |
| 2427 | This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE, |
| 2428 | implementation. |
| 2429 | (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT. |
| 2430 | We prefer signed types, and the value cannot exceed the EMACS_INT |
| 2431 | range anyway (because otherwise the length would not be representable). |
| 2432 | (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t, |
| 2433 | not EMACS_UINT and EMACS_INT, when converting pointer to integer. |
| 2434 | This avoids a GCC warning when WIDE_EMACS_INT. |
| 2435 | |
| 2436 | * indent.c (sane_tab_width): New function. |
| 2437 | (current_column, scan_for_column, Findent_to, position_indentation) |
| 2438 | (compute_motion): Use it. This is just for clarity. |
| 2439 | (Fcompute_motion): Don't assume hscroll and tab offset fit in int. |
| 2440 | |
| 2441 | * image.c (xbm_image_p): Don't assume stated width, height fit in int. |
| 2442 | |
| 2443 | * lisp.h (lint_assume): New macro. |
| 2444 | * composite.c (composition_gstring_put_cache): |
| 2445 | * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0. |
| 2446 | |
| 2447 | * editfns.c, insdel.c: |
| 2448 | Omit unnecessary forward decls, to simplify future changes. |
| 2449 | |
| 2450 | * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths. |
| 2451 | |
| 2452 | * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'. |
| 2453 | |
| 2454 | * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'. |
| 2455 | Use much-faster test for byte-length change. |
| 2456 | Don't assume string byte-length fits in 'int'. |
| 2457 | Check that character arg fits in 'int'. |
| 2458 | (mapcar1): Declare byte as byte, for clarity. |
| 2459 | |
| 2460 | * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication. |
| 2461 | |
| 2462 | * fns.c (concat): Catch string overflow earlier. |
| 2463 | Do not rely on integer wraparound. |
| 2464 | |
| 2465 | * dispextern.h (struct it.overlay_strings_charpos) |
| 2466 | (struct it.selective): Now EMACS_INT, not int. |
| 2467 | * xdisp.c (forward_to_next_line_start) |
| 2468 | (back_to_previous_visible_line_start) |
| 2469 | (reseat_at_next_visible_line_start, next_element_from_buffer): |
| 2470 | Don't arbitrarily truncate the value of 'selective' to int. |
| 2471 | |
| 2472 | * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0. |
| 2473 | |
| 2474 | * composite.c: Don't truncate sizes to 'int'. |
| 2475 | (composition_gstring_p, composition_reseat_it) |
| 2476 | (composition_adjust_point): Use EMACS_INT, not int. |
| 2477 | (get_composition_id, composition_gstring_put_cache): Use EMACS_INT, |
| 2478 | not EMACS_UINT, for indexes. |
| 2479 | |
| 2480 | * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT. |
| 2481 | |
| 2482 | * buffer.c: Include <verify.h>. |
| 2483 | (struct sortvec.priority, struct sortstr.priority): |
| 2484 | Now EMACS_INT, not int. |
| 2485 | (compare_overlays, cmp_for_strings): Avoid subtraction overflow. |
| 2486 | (struct sortstr.size, record_overlay_string) |
| 2487 | (struct sortstrlist.size, struct sortlist.used): |
| 2488 | Don't truncate size to int. |
| 2489 | (record_overlay_string): Check for size-calculation overflow. |
| 2490 | (init_buffer_once): Check at compile-time, not run-time. |
| 2491 | |
| 2492 | 2011-06-22 Jim Meyering <meyering@redhat.com> |
| 2493 | |
| 2494 | Don't leak an XBM-image-sized buffer |
| 2495 | * image.c (xbm_load): Free the image buffer after using it. |
| 2496 | |
| 2497 | 2011-06-21 Paul Eggert <eggert@cs.ucla.edu> |
| 2498 | |
| 2499 | Port to Sun C. |
| 2500 | * composite.c (find_automatic_composition): Omit needless 'return 0;' |
| 2501 | that Sun C diagnosed. |
| 2502 | * fns.c (secure_hash): Fix pointer signedness issue. |
| 2503 | * intervals.c (static_offset_intervals): New function. |
| 2504 | (offset_intervals): Use it. |
| 2505 | |
| 2506 | 2011-06-21 Leo Liu <sdl.web@gmail.com> |
| 2507 | |
| 2508 | * deps.mk (fns.o): |
| 2509 | * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and |
| 2510 | sha512.h. |
| 2511 | |
| 2512 | * fns.c (secure_hash): Rename from crypto_hash_function and change |
| 2513 | the first arg to accept symbols. |
| 2514 | (Fsecure_hash): New primitive. |
| 2515 | (syms_of_fns): New symbols. |
| 2516 | |
| 2517 | 2011-06-20 Deniz Dogan <deniz@dogan.se> |
| 2518 | |
| 2519 | * process.c (Fset_process_buffer): Clarify return value in |
| 2520 | docstring. |
| 2521 | |
| 2522 | 2011-06-18 Chong Yidong <cyd@stupidchicken.com> |
| 2523 | |
| 2524 | * dispnew.c (add_window_display_history): Use BVAR. |
| 2525 | |
| 2526 | * xdisp.c (debug_method_add): Use BVAR. |
| 2527 | (check_window_end, dump_glyph_matrix, dump_glyph) |
| 2528 | (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C. |
| 2529 | |
| 2530 | * xfaces.c (check_lface_attrs, check_lface, dump_realized_face): |
| 2531 | Likewise. |
| 2532 | |
| 2533 | * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache |
| 2534 | check till after the cache is created in init_frame_faces. |
| 2535 | |
| 2536 | 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca> |
| 2537 | |
| 2538 | * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup. |
| 2539 | |
| 2540 | 2011-06-16 Paul Eggert <eggert@cs.ucla.edu> |
| 2541 | |
| 2542 | * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX. |
| 2543 | Without this, prin1 mishandles Lisp_Misc_Save_Value printing on |
| 2544 | hosts with pre-C99 libraries, because pD is wrongly defined to "t". |
| 2545 | |
| 2546 | Improve buffer-overflow checking (Bug#8873). |
| 2547 | * fileio.c (Finsert_file_contents): |
| 2548 | * insdel.c (insert_from_buffer_1, replace_range, replace_range_2): |
| 2549 | Remove the old (too-loose) buffer overflow checks. |
| 2550 | They weren't needed, since make_gap checks for buffer overflow. |
| 2551 | * insdel.c (make_gap_larger): Catch buffer overflows that were missed. |
| 2552 | The old code merely checked for Emacs fixnum overflow, and relied |
| 2553 | on undefined (wraparound) behavior. The new code avoids undefined |
| 2554 | behavior, and also checks for ptrdiff_t and/or size_t overflow. |
| 2555 | |
| 2556 | * editfns.c (Finsert_char): Don't dump core with very negative counts. |
| 2557 | Tune. Don't use wider integers than needed. Don't use alloca. |
| 2558 | Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test. |
| 2559 | |
| 2560 | * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing. |
| 2561 | |
| 2562 | * insdel.c, lisp.h (buffer_overflow): New function. |
| 2563 | (insert_from_buffer_1, replace_range, replace_range_2): |
| 2564 | * insdel.c (make_gap_larger): |
| 2565 | * editfns.c (Finsert_char): |
| 2566 | * fileio.c (Finsert_file_contents): Use it, to normalize wording. |
| 2567 | |
| 2568 | * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed. |
| 2569 | |
| 2570 | 2011-06-15 Paul Eggert <eggert@cs.ucla.edu> |
| 2571 | |
| 2572 | Integer overflow and signedness fixes (Bug#8873). |
| 2573 | |
| 2574 | * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772. |
| 2575 | (GET_CCL_RANGE, IN_INT_RANGE): Use it. |
| 2576 | |
| 2577 | * fileio.c: Don't assume EMACS_INT fits in off_t. |
| 2578 | (emacs_lseek): New static function. |
| 2579 | (Finsert_file_contents, Fwrite_region): Use it. |
| 2580 | Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate. |
| 2581 | |
| 2582 | * fns.c (Fload_average): Don't assume 100 * load average fits in int. |
| 2583 | |
| 2584 | * fns.c: Don't overflow int when computing a list length. |
| 2585 | * fns.c (QUIT_COUNT_HEURISTIC): New constant. |
| 2586 | (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted |
| 2587 | truncation on 64-bit hosts. Check for QUIT every |
| 2588 | QUIT_COUNT_HEURISTIC entries rather than every other entry; that's |
| 2589 | faster and is responsive enough. |
| 2590 | (Flength): Report an error instead of overflowing an integer. |
| 2591 | (Fsafe_length): Return a float if the value is not representable |
| 2592 | as a fixnum. This shouldn't happen except in contrived situations. |
| 2593 | (Fnthcdr, Fsort): Don't assume list length fits in int. |
| 2594 | (Fcopy_sequence): Don't assume vector length fits in int. |
| 2595 | |
| 2596 | * alloc.c: Check that resized vectors' lengths fit in fixnums. |
| 2597 | (header_size, word_size): New constants. |
| 2598 | (allocate_vectorlike): Don't check size overflow here. |
| 2599 | (allocate_vector): Check it here instead, since this is the only |
| 2600 | caller of allocate_vectorlike that could cause overflow. |
| 2601 | Check that the new vector's length is representable as a fixnum. |
| 2602 | |
| 2603 | * fns.c (next_almost_prime): Don't return a multiple of 3 or 5. |
| 2604 | The previous code was bogus. For example, next_almost_prime (32) |
| 2605 | returned 39, which is undesirable as it is a multiple of 3; and |
| 2606 | next_almost_prime (24) returned 25, which is a multiple of 5 so |
| 2607 | why was the code bothering to check for multiples of 7? |
| 2608 | |
| 2609 | * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length. |
| 2610 | |
| 2611 | * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now. |
| 2612 | |
| 2613 | Variadic C functions now count arguments with ptrdiff_t. |
| 2614 | This partly undoes my 2011-03-30 change, which replaced int with size_t. |
| 2615 | Back then I didn't know that the Emacs coding style prefers signed int. |
| 2616 | Also, in the meantime I found a few more instances where arguments |
| 2617 | were being counted with int, which may truncate counts on 64-bit |
| 2618 | machines, or EMACS_INT, which may be unnecessarily wide. |
| 2619 | * lisp.h (struct Lisp_Subr.function.aMANY) |
| 2620 | (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): |
| 2621 | Arg counts are now ptrdiff_t, not size_t. |
| 2622 | All variadic functions and their callers changed accordingly. |
| 2623 | (struct gcpro.nvars): Now size_t, not size_t. All uses changed. |
| 2624 | * bytecode.c (exec_byte_code): Check maxdepth for overflow, |
| 2625 | to avoid potential buffer overrun. Don't assume arg counts fit in 'int'. |
| 2626 | * callint.c (Fcall_interactively): Check arg count for overflow, |
| 2627 | to avoid potential buffer overrun. Use signed char, not 'int', |
| 2628 | for 'varies' array, so that we needn't bother to check its size |
| 2629 | calculation for overflow. |
| 2630 | * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args. |
| 2631 | * eval.c (apply_lambda): |
| 2632 | * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length. |
| 2633 | (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed. |
| 2634 | (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args. |
| 2635 | |
| 2636 | * callint.c (Fcall_interactively): Don't use index var as event count. |
| 2637 | |
| 2638 | * vm-limit.c (check_memory_limits): Fix incorrect extern function decls. |
| 2639 | * mem-limits.h (SIZE): Remove; no longer used. |
| 2640 | |
| 2641 | * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works. |
| 2642 | |
| 2643 | Remove unnecessary casts. |
| 2644 | * xterm.c (x_term_init): |
| 2645 | * xfns.c (x_set_border_pixel): |
| 2646 | * widget.c (create_frame_gcs): Remove casts to unsigned long etc. |
| 2647 | These aren't needed now that we assume ANSI C. |
| 2648 | |
| 2649 | * sound.c (Fplay_sound_internal): Remove cast to unsigned long. |
| 2650 | It's more likely to cause problems (due to unsigned overflow) |
| 2651 | than to cure them. |
| 2652 | |
| 2653 | * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts. |
| 2654 | |
| 2655 | * unexelf.c (unexec): Don't assume BSS addr fits in unsigned. |
| 2656 | |
| 2657 | * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned. |
| 2658 | |
| 2659 | * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX. |
| 2660 | |
| 2661 | * lisp.h (CHAR_TABLE_SET): Omit now-redundant test. |
| 2662 | |
| 2663 | * lread.c (Fload): Don't compare a possibly-garbage time_t value. |
| 2664 | |
| 2665 | GLYPH_CODE_FACE returns EMACS_INT, not int. |
| 2666 | * dispextern.h (merge_faces): |
| 2667 | * xfaces.c (merge_faces): |
| 2668 | * xdisp.c (get_next_display_element, next_element_from_display_vector): |
| 2669 | Don't assume EMACS_INT fits in int. |
| 2670 | |
| 2671 | * character.h (CHAR_VALID_P): Remove unused parameter. |
| 2672 | * fontset.c, lisp.h, xdisp.c: All uses changed. |
| 2673 | |
| 2674 | * editfns.c (Ftranslate_region_internal): Omit redundant test. |
| 2675 | |
| 2676 | * fns.c (concat): Minor tuning based on overflow analysis. |
| 2677 | This doesn't fix any bugs. Use int to hold character, instead |
| 2678 | of constantly refetching from Emacs object. Use XFASTINT, not |
| 2679 | XINT, for value known to be a character. Don't bother comparing |
| 2680 | a single byte to 0400, as it's always less. |
| 2681 | |
| 2682 | * floatfns.c (Fexpt): |
| 2683 | * fileio.c (make_temp_name): Omit unnecessary cast to unsigned. |
| 2684 | |
| 2685 | * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT |
| 2686 | for characters. |
| 2687 | |
| 2688 | * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives. |
| 2689 | |
| 2690 | * data.c (Faset): If ARRAY is a string, check that NEWELT is a char. |
| 2691 | Without this fix, on a 64-bit host (aset S 0 4294967386) would |
| 2692 | incorrectly succeed when S was a string, because 4294967386 was |
| 2693 | truncated before it was used. |
| 2694 | |
| 2695 | * chartab.c (Fchar_table_range): Use CHARACTERP to check range. |
| 2696 | Otherwise, an out-of-range integer could cause undefined behavior |
| 2697 | on a 64-bit host. |
| 2698 | |
| 2699 | * composite.c: Use int, not EMACS_INT, for characters. |
| 2700 | (fill_gstring_body, composition_compute_stop_pos): Use int, not |
| 2701 | EMACS_INT, for values that are known to be in character range. |
| 2702 | This doesn't fix any bugs but is the usual style inside Emacs and |
| 2703 | may generate better code on 32-bit machines. |
| 2704 | |
| 2705 | Make sure a 64-bit char is never passed to ENCODE_CHAR. |
| 2706 | This is for reasons similar to the recent CHAR_STRING fix. |
| 2707 | * charset.c (Fencode_char): Check that character arg is actually |
| 2708 | a character. Pass an int to ENCODE_CHAR. |
| 2709 | * charset.h (ENCODE_CHAR): Verify that the character argument is no |
| 2710 | wider than 'int', as a compile-time check to prevent future regressions |
| 2711 | in this area. |
| 2712 | |
| 2713 | * character.c (char_string): Remove unnecessary casts. |
| 2714 | |
| 2715 | Make sure a 64-bit char is never passed to CHAR_STRING. |
| 2716 | Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform, |
| 2717 | by silently ignoring the top 32 bits, allowing some values |
| 2718 | that were far too large to be valid characters. |
| 2719 | * character.h: Include <verify.h>. |
| 2720 | (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character |
| 2721 | arguments are no wider than unsigned, as a compile-time check |
| 2722 | to prevent future regressions in this area. |
| 2723 | * data.c (Faset): |
| 2724 | * editfns.c (Fchar_to_string, general_insert_function, Finsert_char) |
| 2725 | (Fsubst_char_in_region): |
| 2726 | * fns.c (concat): |
| 2727 | * xdisp.c (decode_mode_spec_coding): |
| 2728 | Adjust to CHAR_STRING's new requirement. |
| 2729 | * editfns.c (Finsert_char, Fsubst_char_in_region): |
| 2730 | * fns.c (concat): Check that character args are actually |
| 2731 | characters. Without this test, these functions did the wrong |
| 2732 | thing with wildly out-of-range values on 64-bit hosts. |
| 2733 | |
| 2734 | Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts. |
| 2735 | These casts should not be needed on 32-bit hosts, either. |
| 2736 | * keyboard.c (read_char): |
| 2737 | * lread.c (Fload): Remove casts to unsigned. |
| 2738 | |
| 2739 | * lisp.h (UNSIGNED_CMP): New macro. |
| 2740 | This fixes comparison bugs on 64-bit hosts. |
| 2741 | (ASCII_CHAR_P): Use it. |
| 2742 | * casefiddle.c (casify_object): |
| 2743 | * character.h (ASCII_BYTE_P, CHAR_VALID_P) |
| 2744 | (SINGLE_BYTE_CHAR_P, CHAR_STRING): |
| 2745 | * composite.h (COMPOSITION_ENCODE_RULE_VALID): |
| 2746 | * dispextern.h (FACE_FROM_ID): |
| 2747 | * keyboard.c (read_char): Use UNSIGNED_CMP. |
| 2748 | |
| 2749 | * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t, |
| 2750 | not to EMACS_INT, to avoid GCC warning. |
| 2751 | |
| 2752 | * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals. |
| 2753 | |
| 2754 | * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast. |
| 2755 | The cast incorrectly truncated 64-bit byte offsets to 32 bits, and |
| 2756 | isn't needed on 32-bit machines. |
| 2757 | |
| 2758 | * buffer.c (Fgenerate_new_buffer_name): |
| 2759 | Use EMACS_INT for count, not int. |
| 2760 | (advance_to_char_boundary): Return EMACS_INT, not int. |
| 2761 | |
| 2762 | * data.c (Qcompiled_function): Now static. |
| 2763 | |
| 2764 | * window.c (window_body_lines): Now static. |
| 2765 | |
| 2766 | * image.c (gif_load): Rename local to avoid shadowing. |
| 2767 | |
| 2768 | * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow. |
| 2769 | (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member. |
| 2770 | * alloc.c (make_save_value): Integer argument is now of type |
| 2771 | ptrdiff_t, not int. |
| 2772 | (mark_object): Use ptrdiff_t, not int. |
| 2773 | * lisp.h (pD): New macro. |
| 2774 | * print.c (print_object): Use it. |
| 2775 | |
| 2776 | * alloc.c: Use EMACS_INT, not int, to count objects. |
| 2777 | (total_conses, total_markers, total_symbols, total_vector_size) |
| 2778 | (total_free_conses, total_free_markers, total_free_symbols) |
| 2779 | (total_free_floats, total_floats, total_free_intervals) |
| 2780 | (total_intervals, total_strings, total_free_strings): |
| 2781 | Now EMACS_INT, not int. All uses changed. |
| 2782 | (Fgarbage_collect): Compute overall total using a double, so that |
| 2783 | integer overflow is less likely to be a problem. Check for overflow |
| 2784 | when converting back to an integer. |
| 2785 | (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks) |
| 2786 | (n_vectors, n_symbol_blocks, n_marker_blocks): Remove. |
| 2787 | These were 'int' variables that could overflow on 64-bit hosts; |
| 2788 | they were never used, so remove them instead of repairing them. |
| 2789 | (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'. |
| 2790 | (inhibit_garbage_collection): Set gc_cons_threshold to max value. |
| 2791 | Previously, this ceilinged at INT_MAX, but that doesn't work on |
| 2792 | 64-bit machines. |
| 2793 | (allocate_pseudovector): Don't use EMACS_INT when int would do. |
| 2794 | |
| 2795 | * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int. |
| 2796 | (allocate_vectorlike): Check for ptrdiff_t overflow. |
| 2797 | (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT |
| 2798 | when a (possibly-narrower) signed value would do just as well. |
| 2799 | We prefer using signed arithmetic, to avoid comparison confusion. |
| 2800 | |
| 2801 | * alloc.c: Catch some string size overflows that we were missing. |
| 2802 | (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0, |
| 2803 | for convenience in STRING_BYTES_MAX. |
| 2804 | (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h. |
| 2805 | The definition here is exact; the one in lisp.h was approximate. |
| 2806 | (allocate_string_data): Check for string overflow. This catches |
| 2807 | some instances we weren't catching before. Also, it catches |
| 2808 | size_t overflow on (unusual) hosts where SIZE_MAX <= min |
| 2809 | (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits |
| 2810 | and ptrdiff_t and EMACS_INT are both 64 bits. |
| 2811 | |
| 2812 | * character.c, coding.c, doprnt.c, editfns.c, eval.c: |
| 2813 | All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND. |
| 2814 | * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX. |
| 2815 | |
| 2816 | * character.c (string_escape_byte8): Fix nbytes/nchars typo. |
| 2817 | |
| 2818 | * alloc.c (Fmake_string): Check for out-of-range init. |
| 2819 | |
| 2820 | 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca> |
| 2821 | |
| 2822 | * eval.c (Fdefvaralias): Also mark the target as variable-special-p. |
| 2823 | |
| 2824 | 2011-06-14 Jan Djärv <jan.h.d@swipnet.se> |
| 2825 | |
| 2826 | * xfns.c (x_set_scroll_bar_default_width): Remove argument to |
| 2827 | xg_get_default_scrollbar_width. |
| 2828 | |
| 2829 | * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3. |
| 2830 | (int_gtk_range_get_value): Move to the scroll bar part of the file. |
| 2831 | (style_changed_cb): Call update_theme_scrollbar_width and call |
| 2832 | x_set_scroll_bar_default_width and xg_frame_set_char_size for |
| 2833 | all frames (Bug#8505). |
| 2834 | (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505). |
| 2835 | Call gtk_window_set_resizable if HAVE_GTK3. |
| 2836 | (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width |
| 2837 | and height if HAVE_GTK3 (Bug#8505). |
| 2838 | (scroll_bar_width_for_theme): New variable. |
| 2839 | (update_theme_scrollbar_width): New function. |
| 2840 | (xg_get_default_scrollbar_width): Move code to |
| 2841 | update_theme_scrollbar_width, just return scroll_bar_width_for_theme. |
| 2842 | (xg_initialize): Call update_theme_scrollbar_width. |
| 2843 | |
| 2844 | * gtkutil.h (xg_get_default_scrollbar_width): Remove argument. |
| 2845 | |
| 2846 | * emacsgtkfixed.c, emacsgtkfixed.h: New files. |
| 2847 | |
| 2848 | 2011-06-12 Martin Rudalics <rudalics@gmx.at> |
| 2849 | |
| 2850 | * frame.c (make_frame): Call other_buffer_safely instead of |
| 2851 | other_buffer. |
| 2852 | |
| 2853 | * window.c (temp_output_buffer_show): Call display_buffer with |
| 2854 | second argument Vtemp_buffer_show_specifiers and reset latter |
| 2855 | immediately after the call. |
| 2856 | (Vtemp_buffer_show_specifiers): New variable. |
| 2857 | (auto_window_vscroll_p, next_screen_context_lines) |
| 2858 | (Vscroll_preserve_screen_position): Remove leading asterisks from |
| 2859 | doc-strings. |
| 2860 | |
| 2861 | 2011-06-12 Paul Eggert <eggert@cs.ucla.edu> |
| 2862 | |
| 2863 | Fix minor problems found by GCC 4.6.0 static checking. |
| 2864 | * buffer.c (Qclone_number): Remove for now, as it's unused. |
| 2865 | (record_buffer, Funrecord_buffer): Rename local to avoid shadowing. |
| 2866 | (record_buffer): Remove unused local. |
| 2867 | * frame.c (other_visible_frames, frame_buffer_list): Now static. |
| 2868 | (set_frame_buffer_list): Remove; unused. |
| 2869 | * frame.h (other_visible_frames): Remove decl. |
| 2870 | * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF. |
| 2871 | * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls. |
| 2872 | (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only |
| 2873 | if HAVE_GPM. |
| 2874 | * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF. |
| 2875 | * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): |
| 2876 | Define only if HAVE_GPM. |
| 2877 | * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static. |
| 2878 | (update_hints_inhibit): Remove; never set. All uses removed. |
| 2879 | * widgetprv.h (emacsFrameClassRec): Remove decl. |
| 2880 | * window.c (delete_deletable_window): Now returns void, since it |
| 2881 | wasn't returning anything. |
| 2882 | (compare_window_configurations): Remove unused locals. |
| 2883 | * xfns.c (x_set_scroll_bar_default_width): Remove unused locals. |
| 2884 | * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF. |
| 2885 | (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers |
| 2886 | the same widths as pointers. This follows up on the 2011-05-06 patch. |
| 2887 | * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID. |
| 2888 | * xterm.h: Likewise. |
| 2889 | (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF. |
| 2890 | |
| 2891 | 2011-06-12 Juanma Barranquero <lekktu@gmail.com> |
| 2892 | |
| 2893 | * makefile.w32-in: Update dependencies. |
| 2894 | (LISP_H): Add lib/intprops.h. |
| 2895 | |
| 2896 | 2011-06-11 Chong Yidong <cyd@stupidchicken.com> |
| 2897 | |
| 2898 | * image.c (gif_load): Add animation frame delay to the metadata. |
| 2899 | (syms_of_image): Use DEFSYM. New symbol `delay'. |
| 2900 | |
| 2901 | 2011-06-11 Martin Rudalics <rudalics@gmx.at> |
| 2902 | |
| 2903 | * window.c (delete_deletable_window): Re-add. |
| 2904 | (Fset_window_configuration): Rewrite to handle dead buffers and |
| 2905 | consequently deletable windows. |
| 2906 | (window_tree, Fwindow_tree): Remove. Supply functionality in |
| 2907 | window.el. |
| 2908 | (compare_window_configurations): Simplify code. |
| 2909 | |
| 2910 | 2011-06-11 Andreas Schwab <schwab@linux-m68k.org> |
| 2911 | |
| 2912 | * image.c (imagemagick_load_image): Fix type mismatch. |
| 2913 | (Fimagemagick_types): Likewise. |
| 2914 | |
| 2915 | * window.h (replace_buffer_in_windows): Declare. |
| 2916 | |
| 2917 | 2011-06-11 Martin Rudalics <rudalics@gmx.at> |
| 2918 | |
| 2919 | * buffer.c: New Lisp objects Qbuffer_list_update_hook and |
| 2920 | Qclone_number. Remove external declaration of Qdelete_window. |
| 2921 | (Fbuffer_list): Rewrite doc-string. Minor restructuring of |
| 2922 | code. |
| 2923 | (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): |
| 2924 | Run Qbuffer_list_update_hook if allowed. |
| 2925 | (Fother_buffer): Rewrite doc-string. Major rewrite for new |
| 2926 | buffer list implementation. |
| 2927 | (other_buffer_safely): New function. |
| 2928 | (Fkill_buffer): Replace call to replace_buffer_in_all_windows by |
| 2929 | calls to replace_buffer_in_windows and |
| 2930 | replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook |
| 2931 | if allowed. |
| 2932 | (record_buffer): Inhibit quitting and rewrite using quittable |
| 2933 | functions. Run Qbuffer_list_update_hook if allowed. |
| 2934 | (Frecord_buffer, Funrecord_buffer): New functions. |
| 2935 | (switch_to_buffer_1, Fswitch_to_buffer): Remove. |
| 2936 | Move switch-to-buffer to window.el. |
| 2937 | (bury-buffer): Move to window.el. |
| 2938 | (Vbuffer_list_update_hook): New variable. |
| 2939 | |
| 2940 | * lisp.h (other_buffer_safely): Add prototype in buffer.c |
| 2941 | section. |
| 2942 | |
| 2943 | * window.h (resize_frame_windows): Move up in code. |
| 2944 | (Fwindow_frame): Remove EXFUN. |
| 2945 | (replace_buffer_in_all_windows): Remove prototype. |
| 2946 | (replace_buffer_in_windows_safely): Add prototype. |
| 2947 | |
| 2948 | * window.c: Declare Qdelete_window static again. Move down |
| 2949 | declaration of select_count. |
| 2950 | (Fnext_window, Fprevious_window): Rewrite doc-strings. |
| 2951 | (Fother_window): Move to window.el. |
| 2952 | (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER |
| 2953 | cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case. |
| 2954 | (Fdelete_windows_on, Freplace_buffer_in_windows): Move to |
| 2955 | window.el. |
| 2956 | (replace_buffer_in_windows): Implement by calling |
| 2957 | Qreplace_buffer_in_windows. |
| 2958 | (replace_buffer_in_all_windows): Remove with some functionality |
| 2959 | moved into replace_buffer_in_windows_safely. |
| 2960 | (replace_buffer_in_windows_safely): New function. |
| 2961 | (select_window_norecord, select_frame_norecord): Move in front |
| 2962 | of run_window_configuration_change_hook. Remove now obsolete |
| 2963 | declarations. |
| 2964 | (Fset_window_buffer): Rewrite doc-string. |
| 2965 | Call Qrecord_window_buffer. |
| 2966 | (keys_of_window): Move binding for other-window to window.el. |
| 2967 | |
| 2968 | 2011-06-11 Chong Yidong <cyd@stupidchicken.com> |
| 2969 | |
| 2970 | * dispextern.h (struct image): Replace data member, whose int_val |
| 2971 | and ptr_val fields were not used by anything, with a single |
| 2972 | lisp_val object. |
| 2973 | |
| 2974 | * image.c (Fimage_metadata, make_image, mark_image, tiff_load) |
| 2975 | (gif_clear_image, gif_load, imagemagick_load_image) |
| 2976 | (gs_clear_image, gs_load): Callers changed. |
| 2977 | |
| 2978 | 2011-06-10 Paul Eggert <eggert@cs.ucla.edu> |
| 2979 | |
| 2980 | * buffer.h: Include <time.h>, for time_t. |
| 2981 | Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra. |
| 2982 | |
| 2983 | Fix minor problems found by static checking. |
| 2984 | |
| 2985 | * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't. |
| 2986 | |
| 2987 | Make identifiers static if they are not used in other modules. |
| 2988 | * data.c (Qcompiled_function, Qframe, Qvector): |
| 2989 | * image.c (QimageMagick, Qsvg): |
| 2990 | * minibuf.c (Qmetadata): |
| 2991 | * window.c (resize_window_check, resize_root_window): Now static. |
| 2992 | * window.h (resize_window_check, resize_root_window): Remove decls. |
| 2993 | |
| 2994 | * window.c (window_deletion_count, delete_deletable_window): |
| 2995 | Remove; unused. |
| 2996 | (window_body_lines): Now static. |
| 2997 | (Fdelete_other_windows_internal): Mark vars as initialized. |
| 2998 | Make sure 'resize_failed' is initialized. |
| 2999 | (run_window_configuration_change_hook): Rename local to avoid shadowing. |
| 3000 | (resize_window_apply): Remove unused local. |
| 3001 | * window.h (delete_deletable_window): Remove decl. |
| 3002 | |
| 3003 | * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing. |
| 3004 | (imagemagick_load_image): Fix pointer signedness problem by changing |
| 3005 | last arg from unsigned char * to char *. All uses changed. |
| 3006 | Also, fix a local for similar reasons. |
| 3007 | Remove unused locals. Remove locals to avoid shadowing. |
| 3008 | (fn_rsvg_handle_free): Remove; unused. |
| 3009 | (svg_load, svg_load_image): Fix pointer signedness problem. |
| 3010 | (imagemagick_load_image): Don't use garbage pointer image_wand. |
| 3011 | |
| 3012 | * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals. |
| 3013 | |
| 3014 | 2011-06-10 Chong Yidong <cyd@stupidchicken.com> |
| 3015 | |
| 3016 | * image.c (gif_load): Fix omitted cast error introduced by |
| 3017 | 2011-06-06 change. |
| 3018 | |
| 3019 | 2011-06-10 Martin Rudalics <rudalics@gmx.at> |
| 3020 | |
| 3021 | * window.h (resize_proportionally, orig_total_lines) |
| 3022 | (orig_top_line): Remove from window structure. |
| 3023 | (set_window_height, set_window_width, change_window_heights) |
| 3024 | (Fdelete_window): Remove prototypes. |
| 3025 | (resize_frame_windows): Remove duplicate declaration. |
| 3026 | |
| 3027 | 2011-06-10 Eli Zaretskii <eliz@gnu.org> |
| 3028 | |
| 3029 | * window.h (resize_frame_windows, resize_window_check) |
| 3030 | (delete_deletable_window, resize_root_window) |
| 3031 | (resize_frame_windows): Declare prototypes. |
| 3032 | |
| 3033 | * window.c (resize_window_apply): Make definition be "static" to |
| 3034 | match the prototype. |
| 3035 | |
| 3036 | 2011-06-10 Martin Rudalics <rudalics@gmx.at> |
| 3037 | |
| 3038 | * window.c: Remove declarations of Qwindow_size_fixed, |
| 3039 | window_min_size_1, window_min_size_2, window_min_size, |
| 3040 | size_window, window_fixed_size_p, enlarge_window, delete_window. |
| 3041 | Remove static from declaration of Qdelete_window, it's |
| 3042 | temporarily needed by Fbury_buffer. |
| 3043 | (replace_window): Don't assign orig_top_line and |
| 3044 | orig_total_lines. |
| 3045 | (Fdelete_window, delete_window): Remove. Window deletion is |
| 3046 | handled by window.el. |
| 3047 | (window_loop): Remove DELETE_OTHER_WINDOWS case. |
| 3048 | Replace Fdelete_window calls with calls to Qdelete_window. |
| 3049 | (Fdelete_other_windows): Remove. Deleting other windows is |
| 3050 | handled by window.el. |
| 3051 | (window_fixed_size_p): Remove. Fixed-sizeness of windows is |
| 3052 | handled in window.el. |
| 3053 | (window_min_size_2, window_min_size_1, window_min_size): Remove. |
| 3054 | Window minimum sizes are handled in window.el. |
| 3055 | (shrink_windows, size_window, set_window_height) |
| 3056 | (set_window_width, change_window_heights, window_height) |
| 3057 | (window_width, CURBEG, CURSIZE, enlarge_window) |
| 3058 | (adjust_window_trailing_edge, Fadjust_window_trailing_edge) |
| 3059 | (Fenlarge_window, Fshrink_window): Remove. Window resizing is |
| 3060 | handled in window.el. |
| 3061 | (make_dummy_parent): Rename to make_parent_window and give it a |
| 3062 | second argument horflag. |
| 3063 | (make_window): Don't set resize_proportionally any more. |
| 3064 | (Fsplit_window): Remove. Windows are split in window.el. |
| 3065 | (save_restore_action, save_restore_orig_size) |
| 3066 | (shrink_window_lowest_first, save_restore_orig_size): Remove. |
| 3067 | Resize mini windows in window.el. |
| 3068 | (grow_mini_window, shrink_mini_window): Implement by calling |
| 3069 | Qresize_root_window_vertically, resize_window_check and |
| 3070 | resize_window_apply. |
| 3071 | (saved_window, Fset_window_configuration, save_window_save): |
| 3072 | Do not handle orig_top_line, orig_total_lines, and |
| 3073 | resize_proportionally. |
| 3074 | (window_min_height, window_min_width): Move to window.el. |
| 3075 | (keys_of_window): Move bindings for delete-other-windows, |
| 3076 | split-window, delete-window and enlarge-window to window.el. |
| 3077 | |
| 3078 | * buffer.c: Temporarily extern Qdelete_window. |
| 3079 | (Fbury_buffer): Temporarily call Qdelete_window instead of |
| 3080 | Fdelete_window (Fbury_buffer will move to window.el soon). |
| 3081 | |
| 3082 | * frame.c (set_menu_bar_lines_1): Remove code handling |
| 3083 | orig_top_line and orig_total_lines. |
| 3084 | |
| 3085 | * dispnew.c (adjust_frame_glyphs_initially): Don't use |
| 3086 | set_window_height but set heights directly. |
| 3087 | (change_frame_size_1): Use resize_frame_windows. |
| 3088 | |
| 3089 | * xdisp.c (init_xdisp): Don't use set_window_height but set |
| 3090 | heights directly. |
| 3091 | |
| 3092 | * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): |
| 3093 | Use resize_frame_windows instead of change_window_heights and run |
| 3094 | run_window_configuration_change_hook. |
| 3095 | |
| 3096 | * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows |
| 3097 | instead of change_window_heights and run |
| 3098 | run_window_configuration_change_hook. |
| 3099 | |
| 3100 | 2011-06-09 Martin Rudalics <rudalics@gmx.at> |
| 3101 | |
| 3102 | * window.c (replace_window): Rename second argument REPLACEMENT to |
| 3103 | NEW. New third argument SETFLAG. Rewrite. |
| 3104 | (delete_window, make_dummy_parent): Call replace_window with |
| 3105 | third argument 1. |
| 3106 | (window_list_1): Move down in code. |
| 3107 | (run_window_configuration_change_hook): Move set_buffer part |
| 3108 | before select_frame_norecord part in order to unwind correctly. |
| 3109 | Rename count1 to count. |
| 3110 | (recombine_windows, delete_deletable_window, resize_root_window) |
| 3111 | (Fdelete_other_windows_internal) |
| 3112 | (Frun_window_configuration_change_hook, make_parent_window) |
| 3113 | (resize_window_check, resize_window_apply, Fresize_window_apply) |
| 3114 | (resize_frame_windows, Fsplit_window_internal) |
| 3115 | (Fdelete_window_internal, Fresize_mini_window_internal): |
| 3116 | New functions. |
| 3117 | (syms_of_window): New variables Vwindow_splits and Vwindow_nest. |
| 3118 | |
| 3119 | 2011-06-08 Martin Rudalics <rudalics@gmx.at> |
| 3120 | |
| 3121 | * window.h (window): Add some new members to window structure - |
| 3122 | normal_lines, normal_cols, new_total, new_normal, clone_number, |
| 3123 | splits, nest, prev_buffers, next_buffers. |
| 3124 | (WINDOW_TOTAL_SIZE): Move here from window.c. |
| 3125 | (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here. |
| 3126 | |
| 3127 | * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p): |
| 3128 | Remove. |
| 3129 | (make_dummy_parent): Set new members of windows structure. |
| 3130 | (make_window): Move down in code. Handle new members of window |
| 3131 | structure. |
| 3132 | (Fwindow_clone_number, Fwindow_splits, Fset_window_splits) |
| 3133 | (Fwindow_nest, Fset_window_nest, Fwindow_new_total) |
| 3134 | (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers) |
| 3135 | (Fset_window_prev_buffers, Fwindow_next_buffers) |
| 3136 | (Fset_window_next_buffers, Fset_window_clone_number): |
| 3137 | New functions. |
| 3138 | (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start) |
| 3139 | (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p): |
| 3140 | Doc-string fixes. |
| 3141 | (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter): |
| 3142 | Argument WINDOW can be now internal window too. |
| 3143 | (Fwindow_use_time): Move up in code. |
| 3144 | (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES. |
| 3145 | Rewrite doc-string. |
| 3146 | (Fset_window_configuration, saved_window) |
| 3147 | (Fcurrent_window_configuration, save_window_save): Handle new |
| 3148 | members of window structure. |
| 3149 | (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH) |
| 3150 | (MIN_SAFE_WINDOW_HEIGHT): Move to window.h. |
| 3151 | (syms_of_window): New Lisp objects Qrecord_window_buffer, |
| 3152 | Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows, |
| 3153 | Qget_mru_window, Qresize_root_window, |
| 3154 | Qresize_root_window_vertically, Qsafe, Qabove, Qbelow, |
| 3155 | Qauto_buffer_name; staticpro them. |
| 3156 | |
| 3157 | 2011-06-07 Martin Rudalics <rudalics@gmx.at> |
| 3158 | |
| 3159 | * window.c (Fwindow_total_size, Fwindow_left_column) |
| 3160 | (Fwindow_top_line, window_body_lines, Fwindow_body_size) |
| 3161 | (Fwindow_list_1): New functions. |
| 3162 | (window_box_text_cols): Replace with window_body_cols. |
| 3163 | (Fwindow_width, Fscroll_left, Fscroll_right): |
| 3164 | Use window_body_cols instead of window_box_text_cols. |
| 3165 | (delete_window, Fset_window_configuration): |
| 3166 | Call delete_all_subwindows with window as argument. |
| 3167 | (delete_all_subwindows): Take a window as argument and not a |
| 3168 | structure. Rewrite. |
| 3169 | (window_loop): Remove handling of GET_LRU_WINDOW and |
| 3170 | GET_LARGEST_WINDOW. |
| 3171 | (Fget_lru_window, Fget_largest_window): Move to window.el. |
| 3172 | |
| 3173 | * window.h: Extern window_body_cols instead of |
| 3174 | window_box_text_cols. delete_all_subwindows now takes a |
| 3175 | Lisp_Object as argument. |
| 3176 | |
| 3177 | * indent.c (compute_motion, Fcompute_motion): |
| 3178 | Use window_body_cols instead of window_box_text_cols. |
| 3179 | |
| 3180 | * frame.c (delete_frame): Call delete_all_subwindows with root |
| 3181 | window as argument. |
| 3182 | |
| 3183 | 2011-06-07 Daniel Colascione <dan.colascione@gmail.com> |
| 3184 | |
| 3185 | * fns.c (Fputhash): Document return value. |
| 3186 | |
| 3187 | 2011-06-06 Chong Yidong <cyd@stupidchicken.com> |
| 3188 | |
| 3189 | * image.c (gif_load): Implement gif89a spec "no disposal" method. |
| 3190 | |
| 3191 | 2011-06-06 Paul Eggert <eggert@cs.ucla.edu> |
| 3192 | |
| 3193 | Cons<->int and similar integer overflow fixes (Bug#8794). |
| 3194 | |
| 3195 | Check for overflow when converting integer to cons and back. |
| 3196 | * charset.c (Fdefine_charset_internal, Fdecode_char): |
| 3197 | Use cons_to_unsigned to catch overflow. |
| 3198 | (Fencode_char): Use INTEGER_TO_CONS. |
| 3199 | * composite.h (LGLYPH_CODE): Use cons_to_unsigned. |
| 3200 | (LGLYPH_SET_CODE): Use INTEGER_TO_CONS. |
| 3201 | * data.c (long_to_cons, cons_to_long): Remove. |
| 3202 | (cons_to_unsigned, cons_to_signed): New functions. |
| 3203 | These signal an error for invalid or out-of-range values. |
| 3204 | * dired.c (Ffile_attributes): Use INTEGER_TO_CONS. |
| 3205 | * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER. |
| 3206 | * font.c (Ffont_variation_glyphs): |
| 3207 | * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS. |
| 3208 | * lisp.h: Include <intprops.h>. |
| 3209 | (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros. |
| 3210 | (cons_to_signed, cons_to_unsigned): New decls. |
| 3211 | (long_to_cons, cons_to_long): Remove decls. |
| 3212 | * undo.c (record_first_change): Use INTEGER_TO_CONS. |
| 3213 | (Fprimitive_undo): Use CONS_TO_INTEGER. |
| 3214 | * xfns.c (Fx_window_property): Likewise. |
| 3215 | * xselect.c: Include <limits.h>. |
| 3216 | (x_own_selection, selection_data_to_lisp_data): |
| 3217 | Use INTEGER_TO_CONS. |
| 3218 | (x_handle_selection_request, x_handle_selection_clear) |
| 3219 | (x_get_foreign_selection, Fx_disown_selection_internal) |
| 3220 | (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER. |
| 3221 | (lisp_data_to_selection_data): Use cons_to_unsigned. |
| 3222 | (x_fill_property_data): Use cons_to_signed. |
| 3223 | Report values out of range. |
| 3224 | |
| 3225 | Check for buffer and string overflow more precisely. |
| 3226 | * buffer.h (BUF_BYTES_MAX): New macro. |
| 3227 | * lisp.h (STRING_BYTES_MAX): New macro. |
| 3228 | * alloc.c (Fmake_string): |
| 3229 | * character.c (string_escape_byte8): |
| 3230 | * coding.c (coding_alloc_by_realloc): |
| 3231 | * doprnt.c (doprnt): |
| 3232 | * editfns.c (Fformat): |
| 3233 | * eval.c (verror): |
| 3234 | Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM, |
| 3235 | since they may not be the same number. |
| 3236 | * editfns.c (Finsert_char): |
| 3237 | * fileio.c (Finsert_file_contents): |
| 3238 | Likewise for BUF_BYTES_MAX. |
| 3239 | |
| 3240 | * image.c: Use ptrdiff_t, not int, for sizes. |
| 3241 | (slurp_file): Switch from int to ptrdiff_t. |
| 3242 | All uses changed. |
| 3243 | (slurp_file): Check that file size fits in both size_t (for |
| 3244 | malloc) and ptrdiff_t (for sanity and safety). |
| 3245 | |
| 3246 | * fileio.c (Fverify_visited_file_modtime): Avoid time overflow |
| 3247 | if b->modtime has its maximal value. |
| 3248 | |
| 3249 | * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits. |
| 3250 | |
| 3251 | Don't assume time_t can fit into int. |
| 3252 | * buffer.h (struct buffer.modtime): Now time_t, not int. |
| 3253 | * fileio.c (Fvisited_file_modtime): No need for time_t cast now. |
| 3254 | * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value. |
| 3255 | |
| 3256 | Minor fixes for signed vs unsigned integers. |
| 3257 | * character.h (MAYBE_UNIFY_CHAR): |
| 3258 | * charset.c (maybe_unify_char): |
| 3259 | * keyboard.c (read_char, reorder_modifiers): |
| 3260 | XINT -> XFASTINT, since the integer must be nonnegative. |
| 3261 | * ftfont.c (ftfont_spec_pattern): |
| 3262 | * keymap.c (access_keymap, silly_event_symbol_error): |
| 3263 | XUINT -> XFASTINT, since the integer must be nonnegative. |
| 3264 | (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT, |
| 3265 | since it makes no difference and we prefer signed. |
| 3266 | * keyboard.c (record_char): Use XUINT when all the neighbors do. |
| 3267 | (access_keymap): NATNUMP -> INTEGERP, since the integer must be |
| 3268 | nonnegative. |
| 3269 | |
| 3270 | 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca> |
| 3271 | |
| 3272 | * window.h (Fwindow_frame): Declare. |
| 3273 | |
| 3274 | 2011-06-06 Paul Eggert <eggert@cs.ucla.edu> |
| 3275 | |
| 3276 | * alloc.c: Simplify handling of large-request failures (Bug#8800). |
| 3277 | (SPARE_MEMORY): Always define. |
| 3278 | (LARGE_REQUEST): Remove. |
| 3279 | (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST. |
| 3280 | |
| 3281 | 2011-06-06 Martin Rudalics <rudalics@gmx.at> |
| 3282 | |
| 3283 | * lisp.h: Move EXFUNS for Fframe_root_window, |
| 3284 | Fframe_first_window and Fset_frame_selected_window to window.h. |
| 3285 | |
| 3286 | * window.h: Move EXFUNS for Fframe_root_window, |
| 3287 | Fframe_first_window and Fset_frame_selected_window here from |
| 3288 | lisp.h. |
| 3289 | |
| 3290 | * frame.c (Fwindow_frame, Fframe_first_window) |
| 3291 | (Fframe_root_window, Fframe_selected_window) |
| 3292 | (Fset_frame_selected_window): Move to window.c. |
| 3293 | (Factive_minibuffer_window): Move to minibuf.c. |
| 3294 | (Fother_visible_frames_p): New function. |
| 3295 | |
| 3296 | * minibuf.c (Factive_minibuffer_window): Move here from frame.c. |
| 3297 | |
| 3298 | * window.c (decode_window, decode_any_window): Move up in code. |
| 3299 | (Fwindowp, Fwindow_live_p): Rewrite doc-strings. |
| 3300 | (inhibit_frame_unsplittable): Remove unused variable. |
| 3301 | (Fwindow_buffer): Move up and rewrite doc-string. |
| 3302 | (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next) |
| 3303 | (Fwindow_prev): New functions. |
| 3304 | (Fwindow_frame): Move here from frame.c. Accept any window as |
| 3305 | argument. |
| 3306 | (Fframe_root_window, Fframe_first_window) |
| 3307 | (Fframe_selected_window): Move here from frame.c. Accept frame |
| 3308 | or arbitrary window as argument. Update doc-strings. |
| 3309 | (Fminibuffer_window): Move up in code. |
| 3310 | (Fwindow_minibuffer_p): Move up in code and simplify. |
| 3311 | (Fset_frame_selected_window): Move here from frame.c. |
| 3312 | Marginal rewrite. |
| 3313 | (Fselected_window, select_window, Fselect_window): Move up in |
| 3314 | code. Minor doc-string fixes. |
| 3315 | |
| 3316 | 2011-06-06 Paul Eggert <eggert@cs.ucla.edu> |
| 3317 | |
| 3318 | * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800). |
| 3319 | Do not assume that spare memory exists; that assumption is valid |
| 3320 | only if SYSTEM_MALLOC. |
| 3321 | (LARGE_REQUEST): New macro, so that the issue of large requests |
| 3322 | is separated from the issue of spare memory. |
| 3323 | |
| 3324 | 2011-06-05 Andreas Schwab <schwab@linux-m68k.org> |
| 3325 | |
| 3326 | * editfns.c (Fformat): Correctly handle zero flag with hexadecimal |
| 3327 | format. (Bug#8806) |
| 3328 | |
| 3329 | * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning. |
| 3330 | |
| 3331 | * xfns.c (x_set_scroll_bar_default_width): Move declarations |
| 3332 | before statements. |
| 3333 | |
| 3334 | 2011-06-05 Jan Djärv <jan.h.d@swipnet.se> |
| 3335 | |
| 3336 | * gtkutil.c (xg_get_default_scrollbar_width): New function. |
| 3337 | |
| 3338 | * gtkutil.h: Declare xg_get_default_scrollbar_width. |
| 3339 | |
| 3340 | * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get |
| 3341 | min width by calling x_set_scroll_bar_default_width (Bug#8505). |
| 3342 | |
| 3343 | 2011-06-05 Juanma Barranquero <lekktu@gmail.com> |
| 3344 | |
| 3345 | * xdisp.c (single_display_spec_intangible_p): Remove declaration. |
| 3346 | |
| 3347 | 2011-06-04 Chong Yidong <cyd@stupidchicken.com> |
| 3348 | |
| 3349 | * xselect.c (x_clipboard_manager_save): Remove redundant arg. |
| 3350 | (x_clipboard_manager_save): Add return value. |
| 3351 | (x_clipboard_manager_error_1, x_clipboard_manager_error_2): |
| 3352 | New error handlers. |
| 3353 | (x_clipboard_manager_save_frame, x_clipboard_manager_save_all): |
| 3354 | Obey Vx_select_enable_clipboard_manager. Catch errors in |
| 3355 | x_clipboard_manager_save (Bug#8779). |
| 3356 | (Vx_select_enable_clipboard_manager): New variable. |
| 3357 | (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790). |
| 3358 | |
| 3359 | 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu> |
| 3360 | |
| 3361 | * emacs.c (main): Warn when starting a GTK emacs in daemon mode. |
| 3362 | |
| 3363 | 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
| 3364 | |
| 3365 | * fringe.c (update_window_fringes): Don't update overlay arrow bitmap |
| 3366 | in the current matrix if keep_current_p is non-zero. |
| 3367 | |
| 3368 | 2011-06-04 Eli Zaretskii <eliz@gnu.org> |
| 3369 | |
| 3370 | * bidi.c (bidi_level_of_next_char): Fix last change. |
| 3371 | |
| 3372 | 2011-06-03 Eli Zaretskii <eliz@gnu.org> |
| 3373 | |
| 3374 | Support bidi reordering of text covered by display properties. |
| 3375 | |
| 3376 | * bidi.c (bidi_copy_it): Use offsetof instead of emulating it. |
| 3377 | (bidi_fetch_char, bidi_fetch_char_advance): New functions. |
| 3378 | (bidi_cache_search, bidi_cache_iterator_state) |
| 3379 | (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak) |
| 3380 | (bidi_level_of_next_char, bidi_move_to_visually_next): |
| 3381 | Support character positions inside a run of characters covered by a |
| 3382 | display string. |
| 3383 | (bidi_paragraph_init, bidi_resolve_explicit_1) |
| 3384 | (bidi_level_of_next_char): Call bidi_fetch_char and |
| 3385 | bidi_fetch_char_advance instead of FETCH_CHAR and |
| 3386 | FETCH_CHAR_ADVANCE. |
| 3387 | (bidi_init_it): Initialize new members. |
| 3388 | (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro |
| 3389 | definitions. |
| 3390 | (bidi_explicit_dir_char): Lookup character type in bidi_type_table, |
| 3391 | instead of using explicit *_CHAR codes. |
| 3392 | (bidi_resolve_explicit, bidi_resolve_weak): |
| 3393 | Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of |
| 3394 | bidirectional text is supported only in multibyte buffers. |
| 3395 | (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use |
| 3396 | it to initialize the frame_window_p member of struct bidi_it. |
| 3397 | (bidi_cache_iterator_state, bidi_resolve_explicit_1) |
| 3398 | (bidi_resolve_explicit, bidi_resolve_weak) |
| 3399 | (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if |
| 3400 | bidi_it->nchars is non-positive. |
| 3401 | (bidi_level_of_next_char): Don't try to lookup the cache for the |
| 3402 | next/previous character if nothing is cached there yet, or if we |
| 3403 | were just reseat()'ed to a new position. |
| 3404 | |
| 3405 | * xdisp.c (set_cursor_from_row): Set start and stop points |
| 3406 | according to the row's direction when priming the loop that looks |
| 3407 | for the glyph on which to display cursor. |
| 3408 | (single_display_spec_intangible_p): Function deleted. |
| 3409 | (display_prop_intangible_p): Reimplement to call |
| 3410 | handle_display_spec instead of single_display_spec_intangible_p. |
| 3411 | Accept 3 additional arguments needed by handle_display_spec. |
| 3412 | This fixes incorrect cursor motion across display property with complex |
| 3413 | values: lists, `(when COND...)' forms, etc. |
| 3414 | (single_display_spec_string_p): Support property values that are |
| 3415 | lists with the argument STRING its top-level element. |
| 3416 | (display_prop_string_p): Fix the condition for processing a |
| 3417 | property that is a list to be consistent with handle_display_spec. |
| 3418 | (handle_display_spec): New function, refactored from the |
| 3419 | last portion of handle_display_prop. |
| 3420 | (compute_display_string_pos): Accept additional argument |
| 3421 | FRAME_WINDOW_P. Call handle_display_spec to determine whether the |
| 3422 | value of a `display' property is a "replacing spec". |
| 3423 | (handle_single_display_spec): Accept 2 additional arguments BUFPOS |
| 3424 | and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from |
| 3425 | the display property, but just return a value indicating whether |
| 3426 | the display property will replace the characters it covers. |
| 3427 | (Fcurrent_bidi_paragraph_direction): Initialize the nchars and |
| 3428 | frame_window_p members of struct bidi_it. |
| 3429 | (compute_display_string_pos, compute_display_string_end): |
| 3430 | New functions. |
| 3431 | (push_it): Accept second argument POSITION, where pop_it should |
| 3432 | jump to continue iteration. |
| 3433 | (reseat_1): Initialize bidi_it.disp_pos. |
| 3434 | |
| 3435 | * keyboard.c (adjust_point_for_property): Adjust the call to |
| 3436 | display_prop_intangible_p to its new signature. |
| 3437 | |
| 3438 | * dispextern.h (struct bidi_it): New member frame_window_p. |
| 3439 | (bidi_init_it): Update prototypes. |
| 3440 | (display_prop_intangible_p): Update prototype. |
| 3441 | (compute_display_string_pos, compute_display_string_end): |
| 3442 | Declare prototypes. |
| 3443 | (struct bidi_it): New members nchars and disp_pos. ch_len is now |
| 3444 | EMACS_INT. |
| 3445 | |
| 3446 | 2011-06-02 Paul Eggert <eggert@cs.ucla.edu> |
| 3447 | |
| 3448 | Malloc failure behavior now depends on size of allocation. |
| 3449 | * alloc.c (buffer_memory_full, memory_full): New arg NBYTES. |
| 3450 | * lisp.h: Change signatures accordingly. |
| 3451 | * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c: |
| 3452 | All callers changed. (Bug#8762) |
| 3453 | |
| 3454 | * gnutls.c: Use Emacs's memory allocators. |
| 3455 | Without this change, the gnutls library would invoke malloc etc. |
| 3456 | directly, which causes problems on non-SYNC_INPUT hosts, and which |
| 3457 | runs afoul of improving memory_full behavior. (Bug#8761) |
| 3458 | (fn_gnutls_global_set_mem_functions): New macro or function pointer. |
| 3459 | (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc, |
| 3460 | xfree instead of the default malloc, realloc, free. |
| 3461 | (Fgnutls_boot): No need to check for memory allocation failure, |
| 3462 | since xmalloc does that for us. |
| 3463 | |
| 3464 | Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771) |
| 3465 | * category.c (hash_get_category_set): |
| 3466 | * ccl.c (ccl_driver): |
| 3467 | * charset.c (Fdefine_charset_internal): |
| 3468 | * charset.h (struct charset.hash_index): |
| 3469 | * composite.c (get_composition_id, gstring_lookup_cache) |
| 3470 | (composition_gstring_put_cache): |
| 3471 | * composite.h (struct composition.hash_index): |
| 3472 | * dispextern.h (struct image.hash): |
| 3473 | * fns.c (next_almost_prime, larger_vector, cmpfn_eql) |
| 3474 | (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql) |
| 3475 | (hashfn_equal, hashfn_user_defined, make_hash_table) |
| 3476 | (maybe_resize_hash_table, hash_lookup, hash_put) |
| 3477 | (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE) |
| 3478 | (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector) |
| 3479 | (Fsxhash, Fgethash, Fputhash, Fmaphash): |
| 3480 | * image.c (make_image, search_image_cache, lookup_image) |
| 3481 | (xpm_put_color_table_h): |
| 3482 | * lisp.h (struct Lisp_Hash_Table): |
| 3483 | * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion): |
| 3484 | * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT' |
| 3485 | for hashes and hash indexes, instead of 'unsigned' and 'int'. |
| 3486 | * alloc.c (allocate_vectorlike): |
| 3487 | Check for overflow in vector size calculations. |
| 3488 | * ccl.c (ccl_driver): |
| 3489 | Check for overflow when converting EMACS_INT to int. |
| 3490 | * fns.c, image.c: Remove unnecessary static decls that would otherwise |
| 3491 | need to be updated by these changes. |
| 3492 | * fns.c (make_hash_table, maybe_resize_hash_table): |
| 3493 | Check for integer overflow with large hash tables. |
| 3494 | (make_hash_table, maybe_resize_hash_table, Fmake_hash_table): |
| 3495 | Prefer the faster XFLOAT_DATA to XFLOATINT where either will do. |
| 3496 | (SXHASH_REDUCE): New macro. |
| 3497 | (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector): |
| 3498 | Use it instead of discarding useful hash info with large hash values. |
| 3499 | (sxhash_float): New function. |
| 3500 | (sxhash): Use it. No more need for "& INTMASK" due to above changes. |
| 3501 | * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc. |
| 3502 | (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK): |
| 3503 | Rewrite to use FIXNUM_BITS, as this simplifies things. |
| 3504 | (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put): |
| 3505 | Adjust signatures to match updated version of code. |
| 3506 | (consing_since_gc): Now EMACS_INT, since a single hash table can |
| 3507 | use more than INT_MAX bytes. |
| 3508 | |
| 3509 | 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu> |
| 3510 | |
| 3511 | Make it possible to build with GCC-4.6+ -O2 -flto. |
| 3512 | |
| 3513 | * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE. |
| 3514 | |
| 3515 | 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca> |
| 3516 | |
| 3517 | * minibuf.c (get_minibuffer, read_minibuf_unwind): |
| 3518 | Call minibuffer-inactive-mode. |
| 3519 | |
| 3520 | 2011-05-31 Juanma Barranquero <lekktu@gmail.com> |
| 3521 | |
| 3522 | * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)): |
| 3523 | Update dependencies. |
| 3524 | |
| 3525 | 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu> |
| 3526 | |
| 3527 | * data.c (init_data): Remove code for UTS, this system is not |
| 3528 | supported anymore. |
| 3529 | |
| 3530 | 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu> |
| 3531 | |
| 3532 | Don't force ./temacs to start in terminal mode. |
| 3533 | |
| 3534 | * frame.c (make_initial_frame): Initialize faces in all cases, not |
| 3535 | only when CANNOT_DUMP is defined. |
| 3536 | * dispnew.c (init_display): Remove CANNOT_DUMP condition. |
| 3537 | |
| 3538 | 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu> |
| 3539 | |
| 3540 | * dispnew.c (add_window_display_history): Use const for the string |
| 3541 | pointer. Remove declaration, not needed. |
| 3542 | |
| 3543 | 2011-05-31 Paul Eggert <eggert@cs.ucla.edu> |
| 3544 | |
| 3545 | Use 'inline', not 'INLINE'. |
| 3546 | <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html> |
| 3547 | * alloc.c, fontset.c (INLINE): Remove. |
| 3548 | * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c: |
| 3549 | * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c: |
| 3550 | * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline. |
| 3551 | * gmalloc.c (register_heapinfo): Use inline unconditionally. |
| 3552 | * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__. |
| 3553 | |
| 3554 | 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu> |
| 3555 | |
| 3556 | Make it possible to run ./temacs. |
| 3557 | |
| 3558 | * callproc.c (set_initial_environment): Remove CANNOT_DUMP code, |
| 3559 | syms_of_callproc does the same thing. Remove test for |
| 3560 | "initialized", do it in the caller. |
| 3561 | * emacs.c (main): Avoid calling set_initial_environment when dumping. |
| 3562 | |
| 3563 | 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca> |
| 3564 | |
| 3565 | * minibuf.c (Finternal_complete_buffer): Return `category' metadata. |
| 3566 | (read_minibuf): Use get_minibuffer. |
| 3567 | (syms_of_minibuf): Use DEFSYM. |
| 3568 | (Qmetadata): New var. |
| 3569 | * data.c (Qbuffer): Don't make it static. |
| 3570 | (syms_of_data): Use DEFSYM. |
| 3571 | |
| 3572 | 2011-05-31 Paul Eggert <eggert@cs.ucla.edu> |
| 3573 | |
| 3574 | * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751) |
| 3575 | (CCL_CODE_MIN): New macro. |
| 3576 | |
| 3577 | 2011-05-30 Paul Eggert <eggert@cs.ucla.edu> |
| 3578 | |
| 3579 | * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests. |
| 3580 | |
| 3581 | * eval.c (Qdebug): Now static. |
| 3582 | * lisp.h (Qdebug): Remove decl. This reverts a part of the |
| 3583 | 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of |
| 3584 | 2011-04-14T06:48:41Z!eggert@cs.ucla.edu. |
| 3585 | |
| 3586 | 2011-05-29 Chong Yidong <cyd@stupidchicken.com> |
| 3587 | |
| 3588 | * image.c: Various fixes to ImageMagick code comments. |
| 3589 | (Fimagemagick_types): Doc fix. |
| 3590 | |
| 3591 | 2011-05-29 Paul Eggert <eggert@cs.ucla.edu> |
| 3592 | |
| 3593 | Minor fixes prompted by GCC 4.6.0 warnings. |
| 3594 | |
| 3595 | * xselect.c (converted_selections, conversion_fail_tag): Now static. |
| 3596 | |
| 3597 | * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h". |
| 3598 | (x_clipboard_manager_save_all): Move extern decl to ... |
| 3599 | * xterm.h: ... here, so that it can be checked for consistency. |
| 3600 | |
| 3601 | 2011-05-29 Chong Yidong <cyd@stupidchicken.com> |
| 3602 | |
| 3603 | * xselect.c (x_clipboard_manager_save_frame) |
| 3604 | (x_clipboard_manager_save_all): New functions. |
| 3605 | (Fx_clipboard_manager_save): Lisp function deleted. |
| 3606 | |
| 3607 | * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all. |
| 3608 | * frame.c (delete_frame): Call x_clipboard_manager_save_frame. |
| 3609 | |
| 3610 | * xterm.h: Update prototype. |
| 3611 | |
| 3612 | 2011-05-28 William Xu <william.xwl@gmail.com> |
| 3613 | |
| 3614 | * nsterm.m (ns_term_shutdown): Synchronize user defaults before |
| 3615 | exiting (Bug#8239). |
| 3616 | |
| 3617 | 2011-05-28 Jim Meyering <meyering@redhat.com> |
| 3618 | |
| 3619 | Avoid a sign-extension bug in crypto_hash_function. |
| 3620 | * fns.c (to_uchar): Define. |
| 3621 | (crypto_hash_function): Use it to convert some newly-signed |
| 3622 | variables to unsigned, to avoid sign-extension bugs. For example, |
| 3623 | without this change, (md5 "truc") would evaluate to |
| 3624 | 45723a2aff78ff4fff7fff1114760e62 rather than the expected |
| 3625 | 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in |
| 3626 | https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html. |
| 3627 | |
| 3628 | 2011-05-27 Paul Eggert <eggert@cs.ucla.edu> |
| 3629 | |
| 3630 | Integer overflow fixes. |
| 3631 | |
| 3632 | * dbusbind.c: Serial number integer overflow fixes. |
| 3633 | (CHECK_DBUS_SERIAL_GET_SERIAL): New macro. |
| 3634 | (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float |
| 3635 | to hold a serial number that is too large for a fixnum. |
| 3636 | (Fdbus_method_return_internal, Fdbus_method_error_internal): |
| 3637 | Check for serial numbers out of range. Decode any serial number |
| 3638 | that was so large that it became a float. (Bug#8722) |
| 3639 | |
| 3640 | * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg. |
| 3641 | (Fdbus_call_method, Fdbus_call_method_asynchronously): |
| 3642 | Use XFASTINT rather than XUINT when numbers are nonnegative. |
| 3643 | (xd_append_arg, Fdbus_method_return_internal): |
| 3644 | (Fdbus_method_error_internal): Likewise. Also, for unsigned |
| 3645 | arguments, check that Lisp number is nonnegative, rather than |
| 3646 | silently wrapping negative numbers around. (Bug#8722) |
| 3647 | (xd_read_message_1): Don't assume dbus_uint32_t can fit in int. |
| 3648 | (Bug#8722) |
| 3649 | |
| 3650 | * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT. |
| 3651 | |
| 3652 | * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'. |
| 3653 | |
| 3654 | ccl: add integer overflow checks |
| 3655 | * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT): |
| 3656 | (IN_INT_RANGE): New macros. |
| 3657 | (ccl_driver): Use them to check for integer overflow when |
| 3658 | decoding a CCL program. Many of the new checks are whether XINT (x) |
| 3659 | fits in int; it doesn't always, on 64-bit hosts. The new version |
| 3660 | doesn't catch all possible integer overflows, but it's an |
| 3661 | improvement. (Bug#8719) |
| 3662 | |
| 3663 | * alloc.c (make_event_array): Use XINT, not XUINT. |
| 3664 | There's no need for unsigned here. |
| 3665 | |
| 3666 | * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t |
| 3667 | This follows up to the 2011-05-06 change that substituted uintptr_t |
| 3668 | for EMACS_INT. This case wasn't caught back then. |
| 3669 | |
| 3670 | Rework Fformat to avoid integer overflow issues. |
| 3671 | * editfns.c: Include <float.h> unconditionally, as it's everywhere |
| 3672 | now (part of C89). Include <verify.h>. |
| 3673 | (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed. |
| 3674 | (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns. |
| 3675 | (Fformat): Avoid the prepass trying to compute sizes; it was only |
| 3676 | approximate and thus did not catch overflow reliably. Instead, walk |
| 3677 | through the format just once, formatting and computing sizes as we go, |
| 3678 | checking for integer overflow at every step, and allocating a larger |
| 3679 | buffer as needed. Keep track separately whether the format is |
| 3680 | multibyte. Keep only the most-recently calculated precision, rather |
| 3681 | than them all. Record whether each argument has been converted to |
| 3682 | string. Use EMACS_INT, not int, for byte and char and arg counts. |
| 3683 | Support field widths and precisions larger than INT_MAX. Avoid |
| 3684 | sprintf's undefined behavior with conversion specifications such as %#d |
| 3685 | and %.0c. Fix bug with strchr succeeding on '\0' when looking for |
| 3686 | flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when |
| 3687 | formatting out-of-range floating point numbers with int |
| 3688 | formats. (Bug#8668) |
| 3689 | |
| 3690 | * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN. |
| 3691 | |
| 3692 | * data.c: Avoid integer truncation in expressions involving floats. |
| 3693 | * data.c: Include <intprops.h>. |
| 3694 | (arith_driver): When there's an integer overflow in an expression |
| 3695 | involving floating point, convert the integers to floating point |
| 3696 | so that the resulting value does not suffer from catastrophic |
| 3697 | integer truncation. For example, on a 64-bit host (* 4 |
| 3698 | most-negative-fixnum 0.5) should yield about -4.6e+18, not zero. |
| 3699 | Do not rely on undefined behavior after integer overflow. |
| 3700 | |
| 3701 | merge count_size_as_multibyte, parse_str_to_multibyte |
| 3702 | * character.c, character.h (count_size_as_multibyte): |
| 3703 | Rename from parse_str_to_multibyte; all uses changed. |
| 3704 | Check for integer overflow. |
| 3705 | * insdel.c, lisp.h (count_size_as_multibyte): Remove, |
| 3706 | since it's now a duplicate of the other. This is more of |
| 3707 | a character than a buffer op, so better that it's in character.c. |
| 3708 | * fns.c, print.c: Adjust to above changes. |
| 3709 | |
| 3710 | 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca> |
| 3711 | |
| 3712 | * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup. |
| 3713 | |
| 3714 | 2011-05-27 Paul Eggert <eggert@cs.ucla.edu> |
| 3715 | |
| 3716 | * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings. |
| 3717 | (x_handle_selection_request, frame_for_x_selection): Remove unused vars. |
| 3718 | (x_clipboard_manager_save): Now static. |
| 3719 | (Fx_clipboard_manager_save): Rename local to avoid shadowing. |
| 3720 | |
| 3721 | * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings. |
| 3722 | (crypto_hash_function): Now static. |
| 3723 | Fix pointer signedness problems. Avoid unnecessary initializations. |
| 3724 | |
| 3725 | 2011-05-27 Chong Yidong <cyd@stupidchicken.com> |
| 3726 | |
| 3727 | * termhooks.h (Vselection_alist): Make it terminal-local. |
| 3728 | |
| 3729 | * terminal.c (create_terminal): Initialize it. |
| 3730 | |
| 3731 | * xselect.c: Support for clipboard managers. |
| 3732 | (Vselection_alist): Move to termhooks.h as terminal-local var. |
| 3733 | (LOCAL_SELECTION): New macro. |
| 3734 | (x_atom_to_symbol): Handle x_display_info_for_display fail case. |
| 3735 | (symbol_to_x_atom): Remove gratuitous arg. |
| 3736 | (x_handle_selection_request, lisp_data_to_selection_data) |
| 3737 | (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed. |
| 3738 | (x_own_selection, x_get_local_selection, x_convert_selection): |
| 3739 | New arg, specifying work frame. Use terminal-local Vselection_alist. |
| 3740 | (some_frame_on_display): Delete unused function. |
| 3741 | (Fx_own_selection_internal, Fx_get_selection_internal) |
| 3742 | (Fx_disown_selection_internal, Fx_selection_owner_p) |
| 3743 | (Fx_selection_exists_p): New optional frame arg. |
| 3744 | (frame_for_x_selection, Fx_clipboard_manager_save): New functions. |
| 3745 | (x_handle_selection_clear): Don't treat other terminals with the |
| 3746 | same keyboard specially. Use the terminal-local Vselection_alist. |
| 3747 | (x_clear_frame_selections): Use Frun_hook_with_args. |
| 3748 | |
| 3749 | * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms. |
| 3750 | |
| 3751 | * xterm.h: Add support for those atoms. |
| 3752 | |
| 3753 | 2011-05-26 Chong Yidong <cyd@stupidchicken.com> |
| 3754 | |
| 3755 | * xselect.c: ICCCM-compliant handling of MULTIPLE targets. |
| 3756 | (converted_selections, conversion_fail_tag): New global variables. |
| 3757 | (x_selection_request_lisp_error): Free the above. |
| 3758 | (x_get_local_selection): Remove unnecessary code. |
| 3759 | (x_reply_selection_request): Args changed; handle arbitrary array |
| 3760 | of converted selections stored in converted_selections. |
| 3761 | Separate the XChangeProperty and SelectionNotify steps. |
| 3762 | (x_handle_selection_request): Rewrite to handle MULTIPLE target. |
| 3763 | (x_convert_selection): New function. |
| 3764 | (x_handle_selection_event): Simplify. |
| 3765 | (x_get_foreign_selection): Don't ignore incoming requests while |
| 3766 | waiting for an answer; this will fail when we implement |
| 3767 | SAVE_TARGETS, and seems unnecessary anyway. |
| 3768 | (selection_data_to_lisp_data): Recognize ATOM_PAIR type. |
| 3769 | (Vx_sent_selection_functions): Doc fix. |
| 3770 | |
| 3771 | 2011-05-26 Leo Liu <sdl.web@gmail.com> |
| 3772 | |
| 3773 | * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699) |
| 3774 | |
| 3775 | 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
| 3776 | |
| 3777 | * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p. |
| 3778 | |
| 3779 | * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row |
| 3780 | for fringe update if it has periodic bitmap. |
| 3781 | (row_equal_p): Also compare left_fringe_offset, right_fringe_offset, |
| 3782 | and fringe_bitmap_periodic_p. |
| 3783 | |
| 3784 | * fringe.c (get_fringe_bitmap_data): New function. |
| 3785 | (draw_fringe_bitmap_1, update_window_fringes): Use it. |
| 3786 | (update_window_fringes): Record periodicity of fringe bitmap in glyph |
| 3787 | row. Mark glyph row for fringe update if periodicity changed. |
| 3788 | |
| 3789 | * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row |
| 3790 | for fringe update unless it has periodic bitmap. |
| 3791 | |
| 3792 | 2011-05-25 Kenichi Handa <handa@m17n.org> |
| 3793 | |
| 3794 | * xdisp.c (get_next_display_element): Set correct it->face_id for |
| 3795 | a static composition. |
| 3796 | |
| 3797 | 2011-05-24 Leo Liu <sdl.web@gmail.com> |
| 3798 | |
| 3799 | * deps.mk (fns.o): |
| 3800 | * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h. |
| 3801 | |
| 3802 | * fns.c (crypto_hash_function, Fsha1): New function. |
| 3803 | (Fmd5): Use crypto_hash_function. |
| 3804 | (syms_of_fns): Add Ssha1. |
| 3805 | |
| 3806 | 2011-05-22 Paul Eggert <eggert@cs.ucla.edu> |
| 3807 | |
| 3808 | * gnutls.c: Remove unused macros. |
| 3809 | (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function): |
| 3810 | (fn_gnutls_transport_set_push_function) [!WINDOWSNT]: |
| 3811 | Remove macros that are defined and never used. |
| 3812 | Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14). |
| 3813 | |
| 3814 | 2011-05-22 Chong Yidong <cyd@stupidchicken.com> |
| 3815 | |
| 3816 | * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS. |
| 3817 | (Fx_get_selection_internal): Minor cleanup. |
| 3818 | (Fx_own_selection_internal): Rename arguments for consistency with |
| 3819 | select.el. |
| 3820 | |
| 3821 | 2011-05-22 Paul Eggert <eggert@cs.ucla.edu> |
| 3822 | |
| 3823 | * xselect.c (QSAVE_TARGETS): New static var, to fix build failure. |
| 3824 | |
| 3825 | 2011-05-22 Chong Yidong <cyd@stupidchicken.com> |
| 3826 | |
| 3827 | * xselect.c (syms_of_xselect): Include character.h; use DEFSYM. |
| 3828 | |
| 3829 | 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
| 3830 | |
| 3831 | * dispnew.c (scrolling_window): Don't exclude the case that the |
| 3832 | last enabled row in the desired matrix touches the bottom boundary. |
| 3833 | |
| 3834 | 2011-05-21 Glenn Morris <rgm@gnu.org> |
| 3835 | |
| 3836 | * Makefile.in ($(etc)/DOC): Make second command line even shorter. |
| 3837 | (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion, |
| 3838 | and add some more files. |
| 3839 | |
| 3840 | 2011-05-20 Eli Zaretskii <eliz@gnu.org> |
| 3841 | |
| 3842 | * callproc.c (Fcall_process) [MSDOS]: Fix arguments to |
| 3843 | report_file_error introduced by the change from 2011-05-07. |
| 3844 | |
| 3845 | 2011-05-20 Paul Eggert <eggert@cs.ucla.edu> |
| 3846 | |
| 3847 | * systime.h (Time): Define only if emacs is defined. |
| 3848 | This is to allow ../lib-src/profile.c to be compiled on FreeBSD, |
| 3849 | where the include path doesn't have X11/X.h by default. See |
| 3850 | <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>. |
| 3851 | |
| 3852 | 2011-05-20 Kenichi Handa <handa@m17n.org> |
| 3853 | |
| 3854 | * composite.c (find_automatic_composition): Fix previous change. |
| 3855 | |
| 3856 | 2011-05-20 Glenn Morris <rgm@gnu.org> |
| 3857 | |
| 3858 | * lisp.mk: New file, split from Makefile.in. |
| 3859 | * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@. |
| 3860 | (shortlisp): Remove. |
| 3861 | ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp. |
| 3862 | |
| 3863 | 2011-05-19 Glenn Morris <rgm@gnu.org> |
| 3864 | |
| 3865 | * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT) |
| 3866 | (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT) |
| 3867 | (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove. |
| 3868 | (lisp): Set the order to that of loadup.el. |
| 3869 | (shortlisp): Make it a copy of $lisp. |
| 3870 | (SOME_MACHINE_LISP): Remove. |
| 3871 | ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too. |
| 3872 | Use just $shortlisp, not $SOME_MACHINE_LISP too. |
| 3873 | |
| 3874 | 2011-05-18 Kenichi Handa <handa@m17n.org> |
| 3875 | |
| 3876 | * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency. |
| 3877 | (BACKWARD_CHAR): Wrap the arg STOP by parenthesis. |
| 3878 | (find_automatic_composition): Mostly rewrite for efficiency. |
| 3879 | |
| 3880 | 2011-05-18 Juanma Barranquero <lekktu@gmail.com> |
| 3881 | |
| 3882 | * makefile.w32-in: Update dependencies. |
| 3883 | |
| 3884 | 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com> |
| 3885 | |
| 3886 | * menu.c: Include limits.h (fixes the MS-Windows build broken by |
| 3887 | 2011-06-18T18:49:19Z!cyd@stupidchicken.com). |
| 3888 | |
| 3889 | 2011-05-18 Paul Eggert <eggert@cs.ucla.edu> |
| 3890 | |
| 3891 | Fix some integer overflow issues, such as string length overflow. |
| 3892 | |
| 3893 | * insdel.c (count_size_as_multibyte): Check for string overflow. |
| 3894 | |
| 3895 | * character.c (lisp_string_width): Check for string overflow. |
| 3896 | Use EMACS_INT, not int, for string indexes and lengths; in |
| 3897 | particular, 2nd arg is now EMACS_INT, not int. Do not crash if |
| 3898 | the resulting string length overflows an EMACS_INT; instead, |
| 3899 | report a string overflow if no precision given. When checking for |
| 3900 | precision exhaustion, use a check that cannot possibly have |
| 3901 | integer overflow. (Bug#8675) |
| 3902 | * character.h (lisp_string_width): Adjust to new signature. |
| 3903 | |
| 3904 | * alloc.c (string_overflow): New function. |
| 3905 | (Fmake_string): Use it. This doesn't change behavior, but saves |
| 3906 | a few bytes and will simplify future changes. |
| 3907 | * character.c (string_escape_byte8): Likewise. |
| 3908 | * lisp.h (string_overflow): New decl. |
| 3909 | |
| 3910 | Fixups, following up to the user-interface timestamp change. |
| 3911 | * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time |
| 3912 | for UI timestamps, instead of unsigned long. |
| 3913 | * msdos.c (mouse_get_pos): Likewise. |
| 3914 | * w32inevt.c (movement_time, w32_console_mouse_position): Likewise. |
| 3915 | * w32gui.h (Time): Define by including "systime.h" rather than by |
| 3916 | declaring it ourselves. (Bug#8664) |
| 3917 | |
| 3918 | * dispextern.h (struct image): Don't assume time_t <= unsigned long. |
| 3919 | * image.c (clear_image_cache): Likewise. |
| 3920 | |
| 3921 | * term.c (term_mouse_position): Don't assume time_t wraparound. |
| 3922 | |
| 3923 | Be more systematic about user-interface timestamps. |
| 3924 | Before, the code sometimes used 'Time', sometimes 'unsigned long', |
| 3925 | and sometimes 'EMACS_UINT', to represent these timestamps. |
| 3926 | This change causes it to use 'Time' uniformly, as that's what X uses. |
| 3927 | This makes the code easier to follow, and makes it easier to catch |
| 3928 | integer overflow bugs such as Bug#8664. |
| 3929 | * frame.c (Fmouse_position, Fmouse_pixel_position): |
| 3930 | Use Time, not unsigned long, for user-interface timestamps. |
| 3931 | * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise. |
| 3932 | (button_down_time, make_lispy_position, make_lispy_movement): Likewise. |
| 3933 | * keyboard.h (last_event_timestamp): Likewise. |
| 3934 | * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise. |
| 3935 | * menu.h (xmenu_show): Likewise. |
| 3936 | * term.c (term_mouse_position): Likewise. |
| 3937 | * termhooks.h (struct input_event.timestamp): Likewise. |
| 3938 | (struct terminal.mouse_position_hook): Likewise. |
| 3939 | * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise. |
| 3940 | * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise. |
| 3941 | * systime.h (Time): New decl. Pull it in from <X11/X.h> if |
| 3942 | HAVE_X_WINDOWS, otherwise define it as unsigned long, which is |
| 3943 | what it was before. |
| 3944 | * menu.h, termhooks.h: Include "systime.h", for Time. |
| 3945 | |
| 3946 | * keyboard.c (make_lispy_event): Fix problem in integer overflow. |
| 3947 | Don't assume that the difference between two unsigned long values |
| 3948 | can fit into an integer. At this point, we know button_down_time |
| 3949 | <= event->timestamp, so the difference must be nonnegative, so |
| 3950 | there's no need to cast the result if double-click-time is |
| 3951 | nonnegative, as it should be; check that it's nonnegative, just in |
| 3952 | case. This bug is triggered when events are more than 2**31 ms |
| 3953 | apart (about 25 days). (Bug#8664) |
| 3954 | |
| 3955 | * xselect.c (last_event_timestamp): Remove duplicate decl. |
| 3956 | (x_own_selection): Remove needless cast to unsigned long. |
| 3957 | |
| 3958 | * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes |
| 3959 | that always fit in int. Use a sentinel instead of a counter, to |
| 3960 | avoid a temp and to allay GCC's concerns about possible int overflow. |
| 3961 | * frame.h (struct frame): Use int for menu_bar_items_used |
| 3962 | instead of EMACS_INT, since it always fits in int. |
| 3963 | |
| 3964 | * menu.c (grow_menu_items): Check for int overflow. |
| 3965 | |
| 3966 | * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils. |
| 3967 | |
| 3968 | * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers. |
| 3969 | Before, the code was not consistent. These values cannot exceed |
| 3970 | 2**31 - 1 so there's no need to make them unsigned. |
| 3971 | (x_x_to_emacs_modifiers): Accept int and return EMACS_INT. |
| 3972 | (x_emacs_to_x_modifiers): Accept EMACS_INT and return int. |
| 3973 | (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers |
| 3974 | as modifiers. |
| 3975 | * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change. |
| 3976 | |
| 3977 | * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT. |
| 3978 | (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT. |
| 3979 | Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)), |
| 3980 | presumably because the widths might not match. |
| 3981 | |
| 3982 | * window.c (size_window): Avoid needless test at loop start. |
| 3983 | |
| 3984 | 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change) |
| 3985 | |
| 3986 | * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687). |
| 3987 | |
| 3988 | 2011-05-12 Drew Adams <drew.adams@oracle.com> |
| 3989 | |
| 3990 | * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655). |
| 3991 | |
| 3992 | 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
| 3993 | |
| 3994 | * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and |
| 3995 | `width' to `bar_area_x' and `bar_area_width', respectively. |
| 3996 | (x_scroll_run): Take account of fringe background extension. |
| 3997 | |
| 3998 | * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]: |
| 3999 | Rename local vars `left' and `width' to `bar_area_x' and |
| 4000 | `bar_area_width', respectively. |
| 4001 | (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe |
| 4002 | background extension. |
| 4003 | |
| 4004 | 2011-05-10 Jim Meyering <meyering@redhat.com> |
| 4005 | |
| 4006 | * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the". |
| 4007 | |
| 4008 | 2011-05-10 Juanma Barranquero <lekktu@gmail.com> |
| 4009 | |
| 4010 | * image.c (Finit_image_library): Return t for built-in image types, |
| 4011 | like pbm and xbm. (Bug#8640) |
| 4012 | |
| 4013 | 2011-05-09 Andreas Schwab <schwab@linux-m68k.org> |
| 4014 | |
| 4015 | * w32menu.c (set_frame_menubar): Fix submenu allocation. |
| 4016 | |
| 4017 | 2011-05-07 Eli Zaretskii <eliz@gnu.org> |
| 4018 | |
| 4019 | * w32console.c (Fset_screen_color): Doc fix. |
| 4020 | (Fget_screen_color): New function. |
| 4021 | (syms_of_ntterm): Defsubr it. |
| 4022 | |
| 4023 | * callproc.c (call_process_cleanup) [MSDOS]: Don't close and |
| 4024 | unlink the temporary file if Fcall_process didn't create it in the |
| 4025 | first place. |
| 4026 | (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the |
| 4027 | child process will be redirected to a file specified with `:file'. |
| 4028 | Don't try to re-open tempfile in that case, and set fd[0] to -1 as |
| 4029 | cue to call_process_cleanup not to close that handle. |
| 4030 | |
| 4031 | 2011-05-07 Ben Key <bkey76@gmail.com> |
| 4032 | |
| 4033 | * makefile.w32-in: The bootstrap-temacs rule now makes use of |
| 4034 | one of two shell specific rules, either bootstrap-temacs-CMD or |
| 4035 | bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical |
| 4036 | to the previous implementation of the bootstrap-temacs rule. |
| 4037 | The bootstrap-temacs-CMD rule is similar to the previous |
| 4038 | implementation of the bootstrap-temacs rule except that it |
| 4039 | makes use of the ESC_CFLAGS variable instead of the CFLAGS |
| 4040 | variable. |
| 4041 | |
| 4042 | These changes, along with some changes to nt/configure.bat, |
| 4043 | nt/gmake.defs, and nt/nmake.defs, are required to extend my |
| 4044 | earlier fix to add support for --cflags and --ldflags options |
| 4045 | that include quotes so that it works whether make uses cmd or |
| 4046 | sh as the shell. |
| 4047 | |
| 4048 | 2011-05-06 Michael Albinus <michael.albinus@gmx.de> |
| 4049 | |
| 4050 | * dbusbind.c (QCdbus_type_unix_fd): Declare static. |
| 4051 | (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it |
| 4052 | is a constant. |
| 4053 | (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or |
| 4054 | a string. Handle both cases. |
| 4055 | (Fdbus_call_method_asynchronously, Fdbus_register_signal) |
| 4056 | (Fdbus_register_method): Use Qinvalid_function. |
| 4057 | |
| 4058 | 2011-05-06 Juanma Barranquero <lekktu@gmail.com> |
| 4059 | |
| 4060 | * makefile.w32-in: Update dependencies. |
| 4061 | (LISP_H): Add inttypes.h and stdin.h. |
| 4062 | (PROCESS_H): Add unistd.h. |
| 4063 | |
| 4064 | 2011-05-06 Eli Zaretskii <eliz@gnu.org> |
| 4065 | |
| 4066 | * lread.c: Include limits.h (fixes the MS-Windows build broken by |
| 4067 | 2011-05-06T07:13:19Z!eggert@cs.ucla.edu). |
| 4068 | |
| 4069 | 2011-05-06 Paul Eggert <eggert@cs.ucla.edu> |
| 4070 | |
| 4071 | * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local. |
| 4072 | |
| 4073 | * term.c (vfatal): Remove stray call to va_end. |
| 4074 | It's not needed and the C Standard doesn't allow it here anyway. |
| 4075 | |
| 4076 | Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux. |
| 4077 | * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545) |
| 4078 | |
| 4079 | * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM |
| 4080 | bytes. |
| 4081 | |
| 4082 | * term.c: Don't include <stdarg.h>, as <lisp.h> does that. |
| 4083 | |
| 4084 | * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering. |
| 4085 | |
| 4086 | * process.c (Fformat_network_address): Fix typo: args2 -> *args2. |
| 4087 | |
| 4088 | * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times). |
| 4089 | |
| 4090 | * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601). |
| 4091 | |
| 4092 | * charset.h (struct charset.code_space): Now has 15 elements, not 16. |
| 4093 | * charset.c (Fdefine_charset_internal): Don't initialize |
| 4094 | charset.code_space[15]. The value was garbage, on hosts with |
| 4095 | 32-bit int (Bug#8600). |
| 4096 | |
| 4097 | * lread.c (read_integer): Be more consistent with string-to-number. |
| 4098 | Use string_to_number to do the actual conversion; this avoids |
| 4099 | rounding errors and fixes some other screwups. Without this fix, |
| 4100 | for example, #x1fffffffffffffff was misread as -2305843009213693952. |
| 4101 | (digit_to_number): Move earlier, for benefit of read_integer. |
| 4102 | Return -1 if the digit is out of range for the base, -2 if it is |
| 4103 | not a digit in any supported base. (Bug#8602) |
| 4104 | |
| 4105 | * doprnt.c (doprnt): Support arbitrary pI values, such as "I64". |
| 4106 | |
| 4107 | * dispnew.c (scrolling_window): Return 1 if we scrolled, |
| 4108 | to match comment at start of function. This also removes a |
| 4109 | GCC warning about overflow in a 32+64-bit port. |
| 4110 | |
| 4111 | * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify. |
| 4112 | |
| 4113 | * dbusbind.c: Do not use XPNTR on a value that may be an integer. |
| 4114 | Reported by Stefan Monnier in |
| 4115 | <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>. |
| 4116 | (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): |
| 4117 | Use SYMBOLP-guarded XSYMBOL, not XPNTR. |
| 4118 | |
| 4119 | * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t. |
| 4120 | (EMACS_UINTPTR): Likewise, with uintptr_t. |
| 4121 | |
| 4122 | * lisp.h: Prefer 64-bit EMACS_INT if available. |
| 4123 | (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit |
| 4124 | on 32-bit hosts that have 64-bit int, so that they can access |
| 4125 | large files. |
| 4126 | However, temporarily disable this change unless the temporary |
| 4127 | symbol WIDE_EMACS_INT is defined. |
| 4128 | |
| 4129 | * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now. |
| 4130 | |
| 4131 | Prefer intptr_t/uintptr_t for integers the same widths as pointers. |
| 4132 | This removes an assumption that EMACS_INT and long are the same |
| 4133 | width as pointers. The assumption is true for Emacs porting targets |
| 4134 | now, but we want to make other targets possible. |
| 4135 | * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX. |
| 4136 | (EMACS_INTPTR, EMACS_UINTPTR): New macros. |
| 4137 | In the rest of the code, change types of integers that hold casted |
| 4138 | pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically |
| 4139 | replacing EMACS_INT, long, EMACS_UINT, and unsigned long. |
| 4140 | (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed. |
| 4141 | (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here. |
| 4142 | No need to cast type when ORing. |
| 4143 | (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR. |
| 4144 | * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast. |
| 4145 | * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to |
| 4146 | assume EMACS_INT is the same width as char *. |
| 4147 | * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb): |
| 4148 | (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item): |
| 4149 | Remove no-longer-needed casts. |
| 4150 | (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback): |
| 4151 | (xg_tool_bar_help_callback, xg_make_tool_item): |
| 4152 | Use EMACS_INTPTR to hold an integer |
| 4153 | that will be cast to void *; this can avoid a GCC warning |
| 4154 | if EMACS_INT is not the same width as void *. |
| 4155 | * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast. |
| 4156 | * xdisp.c (display_echo_area_1, resize_mini_window_1): |
| 4157 | (current_message_1, set_message_1): |
| 4158 | Use a local to convert to proper width without a cast. |
| 4159 | * xmenu.c (dialog_selection_callback): Likewise. |
| 4160 | |
| 4161 | * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long. |
| 4162 | Also, don't assume VALBITS / RAND_BITS is less than 5, |
| 4163 | and don't rely on undefined behavior when shifting a 1 left into |
| 4164 | the sign bit. |
| 4165 | * lisp.h (get_random): Change signature to match. |
| 4166 | |
| 4167 | * lread.c (hash_string): Use size_t, not int, for hash computation. |
| 4168 | Normally we prefer signed values; but hashing is special, because |
| 4169 | it's better to use unsigned division on hash table sizes so that |
| 4170 | the remainder is nonnegative. Also, size_t is the natural width |
| 4171 | for hashing into memory. The previous code used 'int', which doesn't |
| 4172 | retain enough info to hash well into very large tables. |
| 4173 | (oblookup, oblookup_last_bucket_number, Funintern): Likewise. |
| 4174 | |
| 4175 | * dbusbind.c: Don't possibly lose pointer info when converting. |
| 4176 | (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): |
| 4177 | Use XPNTR rather than XHASH, so that the high-order bits of |
| 4178 | the pointer aren't lost when converting through void *. |
| 4179 | |
| 4180 | * eval.c (Fautoload): Don't double-shift a pointer. |
| 4181 | |
| 4182 | * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long. |
| 4183 | |
| 4184 | 2011-05-06 Juanma Barranquero <lekktu@gmail.com> |
| 4185 | |
| 4186 | * gnutls.c (DEF_GNUTLS_FN): |
| 4187 | * image.c (DEF_IMGLIB_FN): Make function pointers static. |
| 4188 | |
| 4189 | 2011-05-05 Andreas Schwab <schwab@linux-m68k.org> |
| 4190 | |
| 4191 | * lread.c (lisp_file_lexically_bound_p): Stop scanning at end |
| 4192 | marker. (Bug#8610) |
| 4193 | |
| 4194 | 2011-05-05 Eli Zaretskii <eliz@gnu.org> |
| 4195 | |
| 4196 | * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]: |
| 4197 | New version that can reserve upto 2GB of heap space. |
| 4198 | |
| 4199 | 2011-05-05 Chong Yidong <cyd@stupidchicken.com> |
| 4200 | |
| 4201 | * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534). |
| 4202 | |
| 4203 | 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com> |
| 4204 | |
| 4205 | * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to |
| 4206 | `gnutls_certificate_set_x509_key_file'. |
| 4207 | |
| 4208 | 2011-05-05 Juanma Barranquero <lekktu@gmail.com> |
| 4209 | |
| 4210 | * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)): |
| 4211 | Update dependencies. |
| 4212 | |
| 4213 | 2011-05-04 Juanma Barranquero <lekktu@gmail.com> |
| 4214 | |
| 4215 | * gnutls.h (emacs_gnutls_write, emacs_gnutls_read): |
| 4216 | * gnutls.c (emacs_gnutls_write, emacs_gnutls_read): |
| 4217 | Remove unused parameter `fildes'. |
| 4218 | * process.c (read_process_output, send_process): Don't pass it. |
| 4219 | |
| 4220 | 2011-05-04 Juanma Barranquero <lekktu@gmail.com> |
| 4221 | |
| 4222 | Fix previous change: the library cache is defined in w32.c. |
| 4223 | * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop. |
| 4224 | (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI". |
| 4225 | |
| 4226 | 2011-05-04 Juanma Barranquero <lekktu@gmail.com> |
| 4227 | |
| 4228 | Implement dynamic loading of GnuTLS on Windows. |
| 4229 | |
| 4230 | * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro. |
| 4231 | (emacs_gnutls_write, emacs_gnutls_read): Mark as extern. |
| 4232 | (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno): |
| 4233 | Declare. |
| 4234 | |
| 4235 | * gnutls.c (Qgnutls_dll): Define. |
| 4236 | (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros. |
| 4237 | (gnutls_*): Declare function pointers. |
| 4238 | (init_gnutls_functions): New function to initialize function pointers. |
| 4239 | (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit) |
| 4240 | (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers. |
| 4241 | (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno): |
| 4242 | Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno. |
| 4243 | (emacs_gnutls_write, emacs_gnutls_read) |
| 4244 | (emacs_gnutls_handle_error, Fgnutls_error_fatalp) |
| 4245 | (Fgnutls_available_p): New function. |
| 4246 | (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers. |
| 4247 | (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it. |
| 4248 | (syms_of_gnutls) <Sgnutls_available_p>: defsubr it. |
| 4249 | |
| 4250 | * image.c: Include w32.h. |
| 4251 | (Vimage_type_cache): Delete. |
| 4252 | (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it. |
| 4253 | (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead. |
| 4254 | (w32_delayed_load): Move to w32.c. |
| 4255 | |
| 4256 | * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare. |
| 4257 | |
| 4258 | * w32.c (QCloaded_from, Vlibrary_cache): Define. |
| 4259 | (w32_delayed_load): Move from image.c. When loading a library, record |
| 4260 | its filename in the :loaded-from property of the library id. |
| 4261 | (globals_of_w32) <QCloaded_from, Vlibrary_cache>: |
| 4262 | Initialize and staticpro them. |
| 4263 | (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions. |
| 4264 | |
| 4265 | * process.c: Include lisp.h before w32.h, not after. |
| 4266 | (wait_reading_process_output): Call emacs_gnutls_record_check_pending |
| 4267 | instead of gnutls_record_check_pending. |
| 4268 | |
| 4269 | * callproc.c, emacs.c: Include lisp.h before w32.h, not after. |
| 4270 | |
| 4271 | 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com> |
| 4272 | |
| 4273 | * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options |
| 4274 | instead of :keyfiles. Give GnuTLS the keylist and the CRL lists |
| 4275 | as passed in. |
| 4276 | |
| 4277 | 2011-05-03 Jan Djärv <jan.h.d@swipnet.se> |
| 4278 | |
| 4279 | * xterm.c (x_set_frame_alpha): Do not set property on anything |
| 4280 | else than FRAME_X_OUTER_WINDOW (Bug#8608). |
| 4281 | |
| 4282 | 2011-05-02 Juanma Barranquero <lekktu@gmail.com> |
| 4283 | |
| 4284 | * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596) |
| 4285 | |
| 4286 | 2011-05-02 Juanma Barranquero <lekktu@gmail.com> |
| 4287 | |
| 4288 | * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon) |
| 4289 | (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again) |
| 4290 | (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake) |
| 4291 | (gnutls_global_initialized, Qgnutls_bootprop_priority) |
| 4292 | (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles) |
| 4293 | (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel) |
| 4294 | (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags) |
| 4295 | (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error) |
| 4296 | (Qgnutls_bootprop_callbacks_verify): Make static. |
| 4297 | |
| 4298 | 2011-05-01 Andreas Schwab <schwab@linux-m68k.org> |
| 4299 | |
| 4300 | * callproc.c: Indentation fixup. |
| 4301 | |
| 4302 | * sysdep.c (wait_for_termination_1): Make static. |
| 4303 | (wait_for_termination, interruptible_wait_for_termination): |
| 4304 | Move after wait_for_termination_1. |
| 4305 | |
| 4306 | 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org> |
| 4307 | |
| 4308 | * sysdep.c (interruptible_wait_for_termination): New function |
| 4309 | which is like wait_for_termination, but allows keyboard |
| 4310 | interruptions. |
| 4311 | |
| 4312 | * callproc.c (Fcall_process): Add (:file "file") as an option for |
| 4313 | the STDOUT buffer. |
| 4314 | (Fcall_process_region): Ditto. |
| 4315 | |
| 4316 | 2011-04-30 Eli Zaretskii <eliz@gnu.org> |
| 4317 | |
| 4318 | * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)' |
| 4319 | rather than `XVECTOR (FOO)->size'. |
| 4320 | |
| 4321 | * process.c: Remove HAVE_INTTYPES_H condition from inclusion of |
| 4322 | inttypes.h, as a gnulib replacement is used if it not available in |
| 4323 | system headers. |
| 4324 | |
| 4325 | 2011-04-21 Eli Zaretskii <eliz@gnu.org> |
| 4326 | |
| 4327 | Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files. |
| 4328 | * fileio.c (Finsert_file_contents): Don't limit file size to 1/4 |
| 4329 | of MOST_POSITIVE_FIXNUM. (Bug#8528) |
| 4330 | |
| 4331 | * coding.c (coding_alloc_by_realloc): Error out if destination |
| 4332 | will grow beyond MOST_POSITIVE_FIXNUM. |
| 4333 | (decode_coding_emacs_mule): Abort if there isn't enough place in |
| 4334 | charbuf for the composition carryover bytes. Reserve an extra |
| 4335 | space for up to 2 characters produced in a loop. |
| 4336 | (decode_coding_iso_2022): Abort if there isn't enough place in |
| 4337 | charbuf for the composition carryover bytes. |
| 4338 | |
| 4339 | 2011-04-21 Eli Zaretskii <eliz@gnu.org> |
| 4340 | |
| 4341 | * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of |
| 4342 | aborting when %lld or %lll format is passed. |
| 4343 | [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when |
| 4344 | %llo or %llx format is passed. (Bug#8545) |
| 4345 | |
| 4346 | * window.c (window_scroll_line_based): Use a marker instead of |
| 4347 | simple variables to record original value of point. (Bug#7952) |
| 4348 | |
| 4349 | * doprnt.c (doprnt): Fix the case where a multibyte sequence |
| 4350 | produced by %s or %c overflows available buffer space. (Bug#8545) |
| 4351 | |
| 4352 | 2011-04-28 Paul Eggert <eggert@cs.ucla.edu> |
| 4353 | |
| 4354 | * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545). |
| 4355 | (SIZE_MAX): Move defn after all includes, as they might #define it. |
| 4356 | |
| 4357 | 2011-04-28 Juanma Barranquero <lekktu@gmail.com> |
| 4358 | |
| 4359 | * w32.c (init_environment): Warn about defaulting HOME to C:\. |
| 4360 | |
| 4361 | 2011-04-28 Juanma Barranquero <lekktu@gmail.com> |
| 4362 | |
| 4363 | * keyboard.c (Qdelayed_warnings_hook): Define. |
| 4364 | (command_loop_1): Run `delayed-warnings-hook' |
| 4365 | if Vdelayed_warnings_list is non-nil. |
| 4366 | (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it. |
| 4367 | (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it. |
| 4368 | |
| 4369 | 2011-04-28 Eli Zaretskii <eliz@gnu.org> |
| 4370 | |
| 4371 | * doprnt.c (doprnt): Don't return value smaller than the buffer |
| 4372 | size if the message was truncated. (Bug#8545). |
| 4373 | |
| 4374 | 2011-04-28 Juanma Barranquero <lekktu@gmail.com> |
| 4375 | |
| 4376 | * w32fns.c (Fx_change_window_property, Fx_delete_window_property) |
| 4377 | (Fx_window_property): #if-0 the whole functions, not just the bodies. |
| 4378 | |
| 4379 | 2011-04-27 Paul Eggert <eggert@cs.ucla.edu> |
| 4380 | |
| 4381 | * doprnt.c (doprnt): Support "ll" length modifier, for long long. |
| 4382 | |
| 4383 | 2011-04-27 Juanma Barranquero <lekktu@gmail.com> |
| 4384 | |
| 4385 | * makefile.w32-in: Update dependencies. |
| 4386 | |
| 4387 | 2011-04-27 Eli Zaretskii <eliz@gnu.org> |
| 4388 | |
| 4389 | Improve `doprnt' and its usage. (Bug#8545) |
| 4390 | * doprnt.c (doprnt): Make sure `format' is never accessed beyond |
| 4391 | `format_end'. Remove support for %l as a conversion specifier. |
| 4392 | Don't use xrealloc. Improve diagnostics when the %l size modifier |
| 4393 | is used. Update the commentary. |
| 4394 | |
| 4395 | * eval.c (verror): Simplify calculation of size_t. |
| 4396 | |
| 4397 | * coding.c (Ffind_operation_coding_system): Fix diagnostic error |
| 4398 | messages. |
| 4399 | |
| 4400 | 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change) |
| 4401 | |
| 4402 | * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing |
| 4403 | change. |
| 4404 | |
| 4405 | 2011-04-27 Paul Eggert <eggert@cs.ucla.edu> |
| 4406 | |
| 4407 | * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF. |
| 4408 | This makes this file independent of the recent pseudovector change. |
| 4409 | |
| 4410 | 2011-04-26 Paul Eggert <eggert@cs.ucla.edu> |
| 4411 | |
| 4412 | * keyboard.c (handle_user_signal): Fix pointer signedness problem. |
| 4413 | |
| 4414 | * gnutls.c (emacs_gnutls_handle_error): Remove unused local. |
| 4415 | (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *. |
| 4416 | Remove unused local. |
| 4417 | (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0. |
| 4418 | |
| 4419 | * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546) |
| 4420 | GCC 4.6.0 optimizes based on type-based alias analysis. |
| 4421 | For example, if b is of type struct buffer * and v of type struct |
| 4422 | Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size |
| 4423 | != &v->size, and therefore "v->size = 1; b->size = 2; return |
| 4424 | v->size;" must therefore return 1. This assumption is incorrect |
| 4425 | for Emacs, since it type-puns struct Lisp_Vector * with many other |
| 4426 | types. To fix this problem, this patch adds a new type struct |
| 4427 | vectorlike_header that documents the constraints on layout of vectors |
| 4428 | and pseudovectors, and helps optimizing compilers not get fooled |
| 4429 | by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE |
| 4430 | XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons. |
| 4431 | * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of |
| 4432 | the size member. |
| 4433 | (XSETPVECTYPE): Rewrite in terms of new macro. |
| 4434 | (XSETPVECTYPESIZE): New macro, specifying both type and size. |
| 4435 | This is a bit clearer, and further avoids the possibility of |
| 4436 | undesirable aliasing. |
| 4437 | (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size. |
| 4438 | (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR. |
| 4439 | (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE, |
| 4440 | since Lisp_Subr is a special case (no "next" field). |
| 4441 | (ASIZE): Now uses header.size rather than size. |
| 4442 | All previous uses of XVECTOR (foo)->size replaced to use this macro, |
| 4443 | to avoid the hassle of writing XVECTOR (foo)->header.size. |
| 4444 | (struct vectorlike_header): New type. |
| 4445 | (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the |
| 4446 | object, to help avoid aliasing. |
| 4447 | (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP. |
| 4448 | (SUBRP): Likewise, since Lisp_Subr is a special case. |
| 4449 | * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table): |
| 4450 | (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector): |
| 4451 | (struct Lisp_Hash_Table): Combine first two members into a single |
| 4452 | struct vectorlike_header member. All uses of "size" and "next" members |
| 4453 | changed to be "header.size" and "header.next". |
| 4454 | * buffer.h (struct buffer): Likewise. |
| 4455 | * font.h (struct font_spec, struct font_entity, struct font): Likewise. |
| 4456 | * frame.h (struct frame): Likewise. |
| 4457 | * process.h (struct Lisp_Process): Likewise. |
| 4458 | * termhooks.h (struct terminal): Likewise. |
| 4459 | * window.c (struct save_window_data, struct saved_window): Likewise. |
| 4460 | * window.h (struct window): Likewise. |
| 4461 | * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector): |
| 4462 | Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems. |
| 4463 | * buffer.c (init_buffer_once): Likewise. |
| 4464 | * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a |
| 4465 | special case. |
| 4466 | * process.c (Fformat_network_address): Use local var for size, |
| 4467 | for brevity. |
| 4468 | |
| 4469 | * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR. |
| 4470 | |
| 4471 | Make the Lisp reader and string-to-float more consistent (Bug#8525) |
| 4472 | * data.c (atof): Remove decl; no longer used or needed. |
| 4473 | (digit_to_number): Move to lread.c. |
| 4474 | (Fstring_to_number): Use new string_to_number function, to be |
| 4475 | consistent with how the Lisp reader treats infinities and NaNs. |
| 4476 | Do not assume that floating-point numbers represent EMACS_INT |
| 4477 | without losing information; this is not true on most 64-bit hosts. |
| 4478 | Avoid double-rounding errors, by insisting on integers when |
| 4479 | parsing non-base-10 numbers, as the documentation specifies. |
| 4480 | * lisp.h (string_to_number): New decl, replacing ... |
| 4481 | (isfloat_string): Remove. |
| 4482 | * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax. |
| 4483 | (read1): Do not accept +. and -. as integers; this |
| 4484 | appears to have been a coding error. Similarly, do not accept |
| 4485 | strings like +-1e0 as floating point numbers. Do not report |
| 4486 | overflow for integer overflows unless the base is not 10 which |
| 4487 | means we have no simple and reliable way to continue. |
| 4488 | Break out the floating-point parsing into a new |
| 4489 | function string_to_number, so that Fstring_to_number parses |
| 4490 | floating point numbers consistently with the Lisp reader. |
| 4491 | (digit_to_number): Move here from data.c. Make it static inline. |
| 4492 | (E_CHAR, EXP_INT): Remove, replacing with ... |
| 4493 | (E_EXP): New macro, to solve the "1.0e+" problem mentioned below. |
| 4494 | (string_to_number): New function, replacing isfloat_string. |
| 4495 | This function checks for valid syntax and produces the resulting |
| 4496 | Lisp float number too. Rework it so that string-to-number |
| 4497 | no longer mishandles examples like "1.0e+". Use strtoumax, |
| 4498 | so that overflow for non-base-10 numbers is reported only when |
| 4499 | there's no portable and simple way to convert to floating point. |
| 4500 | |
| 4501 | * textprop.c (set_text_properties_1): Rewrite for clarity, |
| 4502 | and to avoid GCC warning about integer overflow. |
| 4503 | |
| 4504 | * intervals.h (struct interval): Use EMACS_INT for members |
| 4505 | where EMACS_UINT might cause problems. See |
| 4506 | <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>. |
| 4507 | (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed. |
| 4508 | * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT. |
| 4509 | All uses changed. |
| 4510 | (offset_intervals): Tell GCC not to worry about length overflow |
| 4511 | when negating a negative length. |
| 4512 | |
| 4513 | * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static. |
| 4514 | (overrun_check_free): Likewise. |
| 4515 | |
| 4516 | * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check |
| 4517 | in the common case where SDATA_DATA_OFFSET is a multiple of Emacs |
| 4518 | word size. |
| 4519 | |
| 4520 | * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10. |
| 4521 | (gnutls_make_error): Rename local to avoid shadowing. |
| 4522 | (gnutls_emacs_global_deinit): ifdef out; not used. |
| 4523 | (Fgnutls_boot): Use const for pointer to readonly storage. |
| 4524 | Comment out unused local. Fix pointer signedness problems. |
| 4525 | |
| 4526 | * lread.c (openp): Don't stuff size_t into an 'int'. |
| 4527 | Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning |
| 4528 | about possible signed overflow. |
| 4529 | |
| 4530 | * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10. |
| 4531 | (GDK_KEY_g): Don't define if already defined. |
| 4532 | (xg_prepare_tooltip): Avoid pointer signedness problem. |
| 4533 | (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts. |
| 4534 | |
| 4535 | * process.c (Fnetwork_interface_info): Avoid left-shift undefined |
| 4536 | behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts. |
| 4537 | |
| 4538 | * xfns.c (Fx_window_property): Simplify a bit, |
| 4539 | to make a bit faster and to avoid GCC 4.6.0 warning. |
| 4540 | * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise. |
| 4541 | |
| 4542 | * fns.c (internal_equal): Don't assume size_t fits in int. |
| 4543 | |
| 4544 | * alloc.c (compact_small_strings): Tighten assertion a little. |
| 4545 | |
| 4546 | Replace pEd with more-general pI, and fix some printf arg casts. |
| 4547 | * lisp.h (pI): New macro, generalizing old pEd macro to other |
| 4548 | conversion specifiers. For example, use "...%"pI"d..." rather |
| 4549 | than "...%"pEd"...". |
| 4550 | (pEd): Remove. All uses replaced with similar uses of pI. |
| 4551 | * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise. |
| 4552 | * alloc.c (check_pure_size): Don't overflow by converting size to int. |
| 4553 | * bidi.c (bidi_dump_cached_states): Use pI to avoid cast. |
| 4554 | * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort. |
| 4555 | * dbusbind.c (xd_append_arg): Use pI to avoid cast. |
| 4556 | (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise. |
| 4557 | * font.c (font_unparse_xlfd): Avoid potential buffer overrun on |
| 4558 | 64-bit hosts. |
| 4559 | (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts. |
| 4560 | * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts. |
| 4561 | * print.c (safe_debug_print, print_object): Likewise. |
| 4562 | (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT |
| 4563 | to int. |
| 4564 | Use pI instead of if-then-else-abort. Use %p to avoid casts, |
| 4565 | avoiding the 0 flag, which is not portable. |
| 4566 | * process.c (Fmake_network_process): Use pI to avoid cast. |
| 4567 | * region-cache.c (pp_cache): Likewise. |
| 4568 | * xdisp.c (decode_mode_spec): Likewise. |
| 4569 | * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined |
| 4570 | behavior on 64-bit hosts with printf arg. |
| 4571 | * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag. |
| 4572 | (x_stop_queuing_selection_requests): Likewise. |
| 4573 | (x_get_window_property): Don't truncate byte count to an 'int' |
| 4574 | when tracing. |
| 4575 | |
| 4576 | * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right |
| 4577 | here, since it parses constructs like leading '-' and spaces, |
| 4578 | which are not wanted; and it overflows with large numbers. |
| 4579 | Instead, simply match F[0-9]+, which is what is wanted anyway. |
| 4580 | |
| 4581 | * alloc.c: Remove unportable assumptions about struct layout. |
| 4582 | (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros. |
| 4583 | (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data): |
| 4584 | (allocate_vectorlike, make_pure_vector): Use the new macros, |
| 4585 | plus offsetof, to remove unportable assumptions about struct layout. |
| 4586 | These assumptions hold on all porting targets that I know of, but |
| 4587 | they are not guaranteed, they're easy to remove, and removing them |
| 4588 | makes further changes easier. |
| 4589 | |
| 4590 | * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks". |
| 4591 | This doesn't fix a bug but makes the code clearer. |
| 4592 | (string_overrun_cookie): Now const. Use initializers that |
| 4593 | don't formally overflow signed char, to avoid warnings. |
| 4594 | (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that |
| 4595 | can cause Emacs to crash when string overrun checking is enabled. |
| 4596 | (allocate_buffer): Don't assume sizeof (struct buffer) is a |
| 4597 | multiple of sizeof (EMACS_INT); it need not be, if |
| 4598 | alignof(EMACS_INT) < sizeof (EMACS_INT). |
| 4599 | (check_sblock, check_string_bytes, check_string_free_list): Protoize. |
| 4600 | |
| 4601 | 2011-04-26 Juanma Barranquero <lekktu@gmail.com> |
| 4602 | |
| 4603 | * keyboard.c (QCrtl): Rename from Qrtl. All uses changed. |
| 4604 | |
| 4605 | 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com> |
| 4606 | |
| 4607 | * gnutls.c (emacs_gnutls_handshake): Return an error if we're not |
| 4608 | supposed to be handshaking. (Bug#8556) |
| 4609 | Reported by Paul Eggert <eggert@cs.ucla.edu>. |
| 4610 | |
| 4611 | 2011-04-26 Daniel Colascione <dan.colascione@gmail.com> |
| 4612 | |
| 4613 | * lisp.h (Qdebug): List symbol. |
| 4614 | * eval.c (Qdebug): Restore global linkage. |
| 4615 | * keyboard.c (debug-on-event): New variable. |
| 4616 | (handle_user_signal): Break into debugger when debug-on-event |
| 4617 | matches the current signal symbol. |
| 4618 | |
| 4619 | 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu> |
| 4620 | |
| 4621 | * alloc.c (check_sblock, check_string_bytes) |
| 4622 | (check_string_free_list): Convert to standard C. |
| 4623 | |
| 4624 | 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com> |
| 4625 | |
| 4626 | * w32.c (emacs_gnutls_push): Fix typo. |
| 4627 | |
| 4628 | 2011-04-25 Eli Zaretskii <eliz@gnu.org> |
| 4629 | |
| 4630 | * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about |
| 4631 | "cast to pointer from integer of different size". |
| 4632 | |
| 4633 | Improve doprnt and its use in verror. (Bug#8545) |
| 4634 | * doprnt.c (doprnt): Document the set of format control sequences |
| 4635 | supported by the function. Use SAFE_ALLOCA instead of always |
| 4636 | using `alloca'. |
| 4637 | |
| 4638 | * eval.c (verror): Don't limit the buffer size at size_max-1, that |
| 4639 | is one byte too soon. Don't use xrealloc; instead xfree and |
| 4640 | xmalloc anew. |
| 4641 | |
| 4642 | 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com> |
| 4643 | |
| 4644 | * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the |
| 4645 | callbacks stage. |
| 4646 | |
| 4647 | * gnutls.c: Renamed global_initialized to |
| 4648 | gnutls_global_initialized. Added internals for the |
| 4649 | :verify-hostname-error, :verify-error, and :verify-flags |
| 4650 | parameters of `gnutls-boot' and documented those parameters in the |
| 4651 | docstring. Start callback support. |
| 4652 | (emacs_gnutls_handshake): Add Woe32 support. Retry handshake |
| 4653 | unless a fatal error occurred. Call gnutls_alert_send_appropriate |
| 4654 | on error. Return error code. |
| 4655 | (emacs_gnutls_write): Call emacs_gnutls_handle_error. |
| 4656 | (emacs_gnutls_read): Likewise. |
| 4657 | (Fgnutls_boot): Return handshake error code. |
| 4658 | (emacs_gnutls_handle_error): New function. |
| 4659 | (wsaerror_to_errno): Likewise. |
| 4660 | |
| 4661 | * w32.h (emacs_gnutls_pull): Add prototype. |
| 4662 | (emacs_gnutls_push): Likewise. |
| 4663 | |
| 4664 | * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32. |
| 4665 | (emacs_gnutls_push): Likewise. |
| 4666 | |
| 4667 | 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change) |
| 4668 | |
| 4669 | * process.c (wait_reading_process_output): Check if GnuTLS |
| 4670 | buffered some data internally if no FDs are set for TLS |
| 4671 | connections. |
| 4672 | |
| 4673 | * makefile.w32-in (OBJ2): Add gnutls.$(O). |
| 4674 | (LIBS): Link to USER_LIBS. |
| 4675 | ($(BLD)/gnutls.$(0)): New target. |
| 4676 | |
| 4677 | 2011-04-24 Eli Zaretskii <eliz@gnu.org> |
| 4678 | |
| 4679 | * xdisp.c (handle_single_display_spec): Rename the |
| 4680 | display_replaced_before_p argument into display_replaced_p, to |
| 4681 | make it consistent with the commentary. Fix typos in the |
| 4682 | commentary. |
| 4683 | |
| 4684 | * textprop.c (syms_of_textprop): Remove dead code. |
| 4685 | (copy_text_properties): Delete obsolete commentary about an |
| 4686 | interface that was deleted long ago. Fix typos in the description |
| 4687 | of arguments. |
| 4688 | |
| 4689 | * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list |
| 4690 | to changes in oldXMenu/XMenu.h from 2011-04-16. |
| 4691 | <menu_help_message, prev_menu_help_message>: Constify. |
| 4692 | (IT_menu_make_room): menu->help_text is now `const char **'; |
| 4693 | adjust. |
| 4694 | |
| 4695 | * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes |
| 4696 | to changes in oldXMenu/XMenu.h from 2011-04-16. |
| 4697 | (struct XMenu): Declare `help_text' `const char **'. |
| 4698 | |
| 4699 | * xfaces.c <Qunspecified>: Make extern again. |
| 4700 | |
| 4701 | * syntax.c: Include sys/types.h before including regex.h, as |
| 4702 | required by Posix. |
| 4703 | |
| 4704 | * doc.c (get_doc_string): Improve the format passed to `error'. |
| 4705 | |
| 4706 | * doprnt.c (doprnt): Improve commentary. |
| 4707 | |
| 4708 | * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal. |
| 4709 | |
| 4710 | * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan |
| 4711 | them with etags. |
| 4712 | |
| 4713 | * makefile.w32-in (globals.h): Add a dummy recipe, to make any |
| 4714 | changes in globals.h immediately force recompilation. |
| 4715 | (TAGS): Depend on $(CURDIR)/m/intel386.h and |
| 4716 | $(CURDIR)/s/ms-w32.h. |
| 4717 | (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h. |
| 4718 | |
| 4719 | * character.c (Fchar_direction): Function deleted. |
| 4720 | (syms_of_character): Don't defsubr it. |
| 4721 | <char-direction-table>: Deleted. |
| 4722 | |
| 4723 | 2011-04-23 Eli Zaretskii <eliz@gnu.org> |
| 4724 | |
| 4725 | Fix doprnt so it could be used again safely in `verror'. (Bug#8435) |
| 4726 | * doprnt.c: Include limits.h. |
| 4727 | (SIZE_MAX): New macro. |
| 4728 | (doprnt): Return a size_t value. 2nd arg is now size_t. |
| 4729 | Many local variables are now size_t instead of int or unsigned. |
| 4730 | Improve overflow protection. Support `l' modifier for integer |
| 4731 | conversions. Support %l conversion. Don't assume an EMACS_INT |
| 4732 | argument for integer conversions and for %c. |
| 4733 | |
| 4734 | * lisp.h (doprnt): Restore prototype. |
| 4735 | |
| 4736 | * makefile.w32-in ($(BLD)/callint.$(O)): Depend on |
| 4737 | $(SRC)/character.h. |
| 4738 | |
| 4739 | * Makefile.in (base_obj): Add back doprnt.o. |
| 4740 | |
| 4741 | * deps.mk (doprnt.o): Add back prerequisites. |
| 4742 | (callint.o): Depend on character.h. |
| 4743 | |
| 4744 | * eval.c (internal_lisp_condition_case): Include the handler |
| 4745 | representation in the error message. |
| 4746 | (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug |
| 4747 | when breaking from the loop. |
| 4748 | |
| 4749 | * xdisp.c (vmessage): Call doprnt instead of vsnprintf. |
| 4750 | |
| 4751 | * callint.c (Fcall_interactively): When displaying error message |
| 4752 | about invalid control letter, pass the character's codepoint, not |
| 4753 | a pointer to its multibyte form. Improve display of the character |
| 4754 | in octal and display also its hex code. |
| 4755 | |
| 4756 | * character.c (char_string): Use %x to display the (unsigned) |
| 4757 | codepoint of an invalid character, to avoid displaying a bogus |
| 4758 | negative value. |
| 4759 | |
| 4760 | * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to |
| 4761 | `error', not SYMBOL_NAME itself. |
| 4762 | |
| 4763 | * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for |
| 4764 | character arguments to `error'. |
| 4765 | |
| 4766 | * charset.c (check_iso_charset_parameter): Fix incorrect argument |
| 4767 | to `error' in error message about FINAL_CHAR argument. Make sure |
| 4768 | FINAL_CHAR is a character, and use %c when it is passed as |
| 4769 | argument to `error'. |
| 4770 | |
| 4771 | 2011-04-23 Eli Zaretskii <eliz@gnu.org> |
| 4772 | |
| 4773 | * s/ms-w32.h (localtime): Redirect to sys_localtime. |
| 4774 | |
| 4775 | * w32.c: Include <time.h>. |
| 4776 | (sys_localtime): New function. |
| 4777 | |
| 4778 | 2011-04-23 Chong Yidong <cyd@stupidchicken.com> |
| 4779 | |
| 4780 | * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451). |
| 4781 | |
| 4782 | * buffer.c (syms_of_buffer): Doc fix (Bug#6902). |
| 4783 | |
| 4784 | 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change) |
| 4785 | |
| 4786 | * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on |
| 4787 | zombies (Bug#8467). |
| 4788 | |
| 4789 | 2011-04-19 Eli Zaretskii <eliz@gnu.org> |
| 4790 | |
| 4791 | * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of |
| 4792 | gl_state.e_property when gl_state.object is Qt. |
| 4793 | |
| 4794 | * insdel.c (make_gap_larger): Remove limitation of buffer size |
| 4795 | to <= INT_MAX. |
| 4796 | |
| 4797 | 2011-04-18 Chong Yidong <cyd@stupidchicken.com> |
| 4798 | |
| 4799 | * xdisp.c (lookup_glyphless_char_display) |
| 4800 | (produce_glyphless_glyph): Handle cons cell entry in |
| 4801 | glyphless-char-display. |
| 4802 | (Vglyphless_char_display): Document it. |
| 4803 | |
| 4804 | * term.c (produce_glyphless_glyph): Handle cons cell entry in |
| 4805 | glyphless-char-display. |
| 4806 | |
| 4807 | 2011-04-17 Chong Yidong <cyd@stupidchicken.com> |
| 4808 | |
| 4809 | * xdisp.c (get_next_display_element): Remove unnecessary ifdefs. |
| 4810 | |
| 4811 | * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions. |
| 4812 | |
| 4813 | * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing |
| 4814 | definition for no-X builds. |
| 4815 | |
| 4816 | 2011-04-16 Paul Eggert <eggert@cs.ucla.edu> |
| 4817 | |
| 4818 | Static checks with GCC 4.6.0 and non-default toolkits. |
| 4819 | |
| 4820 | * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl. |
| 4821 | |
| 4822 | * process.c (keyboard_bit_set): Define only if SIGIO. |
| 4823 | (send_process_trap): Mark it with NO_RETURN if it doesn't return. |
| 4824 | (send_process): Repair possible setjmp clobbering. |
| 4825 | |
| 4826 | * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'. |
| 4827 | |
| 4828 | * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts. |
| 4829 | |
| 4830 | * data.c (arith_error): Mark with NO_RETURN if it doesn't return. |
| 4831 | |
| 4832 | * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED): |
| 4833 | Define only if needed. |
| 4834 | |
| 4835 | * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier |
| 4836 | by pacifying GCC about it. Maybe it's time to retire it? |
| 4837 | * xfaces.c (USG, __TIMEVAL__): Likewise. |
| 4838 | |
| 4839 | * dispextern.h (struct redisplay_interface): Rename param |
| 4840 | to avoid shadowing. |
| 4841 | * termhooks.h (struct terminal): Likewise. |
| 4842 | * xterm.c (xembed_send_message): Likewise. |
| 4843 | |
| 4844 | * insdel.c (make_gap_smaller): Define only if |
| 4845 | USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC. |
| 4846 | |
| 4847 | * keyboard.c (read_char): Make a var volatile so longjmp won't clobber |
| 4848 | it. |
| 4849 | |
| 4850 | * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used, |
| 4851 | so that we aren't warned about unused symbols. |
| 4852 | |
| 4853 | * xfns.c (Fx_file_dialog): Rename local to avoid shadowing. |
| 4854 | |
| 4855 | * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512). |
| 4856 | |
| 4857 | * xfns.c (x_real_positions): Mark locals as initialized. |
| 4858 | |
| 4859 | * xmenu.c (xmenu_show): Don't use uninitialized vars. |
| 4860 | |
| 4861 | * xterm.c: Fix problems found by static analysis with other toolkits. |
| 4862 | (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT. |
| 4863 | (x_dispatch_event): Declare static if USE_GTK, and |
| 4864 | define if USE_GTK || USE_X_TOOLKIT. |
| 4865 | (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK. |
| 4866 | * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT. |
| 4867 | * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only |
| 4868 | if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK. |
| 4869 | |
| 4870 | * xmenu.c (menu_help_callback): Pointer type fixes. |
| 4871 | Use const pointers when pointing at readonly data. Avoid pointer |
| 4872 | signedness clashes. |
| 4873 | (FALSE): Remove unused macro. |
| 4874 | (update_frame_menubar): Remove unused decl. |
| 4875 | |
| 4876 | * xfns.c (Fx_hide_tip): Move locals to avoid shadowing. |
| 4877 | |
| 4878 | * menu.c (push_submenu_start, push_submenu_end): Do not define unless |
| 4879 | USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI. |
| 4880 | (single_menu_item): Rename local to avoid shadowing. |
| 4881 | |
| 4882 | * keyboard.c (make_lispy_event): Remove unused local var. |
| 4883 | |
| 4884 | * frame.c, frame.h (x_get_resource_string): Bring this back, but |
| 4885 | only if HAVE_X_WINDOWS && !USE_X_TOOLKIT. |
| 4886 | |
| 4887 | * bitmaps: Change bitmaps from unsigned char back to the X11 |
| 4888 | compatible char. Avoid the old compiler warnings about |
| 4889 | out-of-range initializers by using, for example, '\xab' rather |
| 4890 | than 0xab. |
| 4891 | |
| 4892 | * xgselect.c (xgselect_initialize): Check vs interface |
| 4893 | even if ! (defined (USE_GTK) || defined (HAVE_GCONF)). |
| 4894 | |
| 4895 | * xmenu.c (xmenu_show): Rename parm to avoid shadowing. |
| 4896 | |
| 4897 | * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers |
| 4898 | to read-only memory. |
| 4899 | |
| 4900 | * fns.c (vector): Remove; this old hack is no longer needed. |
| 4901 | |
| 4902 | * xsmfns.c (create_client_leader_window): Rename shadowing arg. |
| 4903 | Remove unused var. |
| 4904 | (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define. |
| 4905 | |
| 4906 | * xrdb.c (x_load_resources): Omit unused local. |
| 4907 | |
| 4908 | * xfns.c (free_frame_menubar, atof): Remove duplicate decls. |
| 4909 | (x_window): Rename locals to avoid shadowing. |
| 4910 | (USG): Use the kludged USG macro, to pacify gcc. |
| 4911 | |
| 4912 | * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused. |
| 4913 | (x_term_init): Remove local to avoid shadowing. |
| 4914 | |
| 4915 | * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl. |
| 4916 | |
| 4917 | * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if |
| 4918 | USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then. |
| 4919 | |
| 4920 | 2011-04-16 Eli Zaretskii <eliz@gnu.org> |
| 4921 | |
| 4922 | * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'. |
| 4923 | |
| 4924 | Fix regex.c, syntax.c and friends for buffers > 2GB. |
| 4925 | * syntax.h (struct gl_state_s): Declare character position members |
| 4926 | EMACS_INT. |
| 4927 | |
| 4928 | * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT. |
| 4929 | |
| 4930 | * textprop.c (verify_interval_modification, interval_of): |
| 4931 | Declare arguments EMACS_INT. |
| 4932 | |
| 4933 | * intervals.c (adjust_intervals_for_insertion): Declare arguments |
| 4934 | EMACS_INT. |
| 4935 | |
| 4936 | * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'. |
| 4937 | |
| 4938 | * indent.c (Fvertical_motion): Local variable it_start is now |
| 4939 | EMACS_INT. |
| 4940 | |
| 4941 | * regex.c (re_match, re_match_2, re_match_2_internal) |
| 4942 | (bcmp_translate, regcomp, regexec, print_double_string) |
| 4943 | (group_in_compile_stack, re_search, re_search_2, regex_compile) |
| 4944 | (re_compile_pattern, re_exec): Declare arguments and local |
| 4945 | variables `size_t' and `ssize_t' and return values `regoff_t', as |
| 4946 | appropriate. |
| 4947 | (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'. |
| 4948 | (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'. |
| 4949 | <compile_stack_type>: `size' and `avail' are now `size_t'. |
| 4950 | |
| 4951 | * regex.h <regoff_t>: Use ssize_t, not int. |
| 4952 | (re_search, re_search_2, re_match, re_match_2): Arguments that |
| 4953 | specify buffer/string position and length are now ssize_t and |
| 4954 | size_t. Return type is regoff_t. |
| 4955 | |
| 4956 | 2011-04-16 Ben Key <bkey76@gmail.com> |
| 4957 | |
| 4958 | * nsfont.m: Fixed bugs in ns_get_family and |
| 4959 | ns_descriptor_to_entity that were caused by using free to |
| 4960 | deallocate memory blocks that were allocated by xmalloc (via |
| 4961 | xstrdup). This caused Emacs to crash when compiled with |
| 4962 | XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with |
| 4963 | --enable-checking=xmallocoverrun). xfree is now used to |
| 4964 | deallocate these memory blocks. |
| 4965 | |
| 4966 | 2011-04-15 Paul Eggert <eggert@cs.ucla.edu> |
| 4967 | |
| 4968 | * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT. |
| 4969 | |
| 4970 | emacs_write: Accept and return EMACS_INT for sizes. |
| 4971 | See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html |
| 4972 | et seq. |
| 4973 | * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write): |
| 4974 | Accept and return EMACS_INT. |
| 4975 | (emacs_gnutls_write): Return the number of bytes written on |
| 4976 | partial writes. |
| 4977 | * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise. |
| 4978 | (emacs_read, emacs_write): Remove check for negative size, as the |
| 4979 | Emacs source code has been audited now. |
| 4980 | * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs. |
| 4981 | (emacs_read, emacs_write): Use it. |
| 4982 | * process.c (send_process): Adjust to the new signatures of |
| 4983 | emacs_write and emacs_gnutls_write. Do not attempt to store |
| 4984 | a byte offset into an 'int'; it might overflow. |
| 4985 | See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html |
| 4986 | |
| 4987 | * sound.c: Don't assume sizes fit in 'int'. |
| 4988 | (struct sound_device.period_size, alsa_period_size): |
| 4989 | Return EMACS_INT, not int. |
| 4990 | (struct sound_device.write, vox_write, alsa_write): |
| 4991 | Accept EMACS_INT, not int. |
| 4992 | (wav_play, au_play): Use EMACS_INT to store sizes and to |
| 4993 | record read return values. |
| 4994 | |
| 4995 | 2011-04-15 Ben Key <bkey76@gmail.com> |
| 4996 | |
| 4997 | * keyboard.c (Qundefined): Don't declare static since it is used |
| 4998 | in nsfns.m. |
| 4999 | * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare |
| 5000 | static since they are used in nsfont.m. |
| 5001 | |
| 5002 | 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca> |
| 5003 | |
| 5004 | * process.c (Qprocessp): Don't declare static. |
| 5005 | * lisp.h (Qprocessp): Declare again. |
| 5006 | |
| 5007 | 2011-04-15 Juanma Barranquero <lekktu@gmail.com> |
| 5008 | |
| 5009 | * font.c (Qopentype): Don't make static (used from w32uniscribe.c). |
| 5010 | |
| 5011 | 2011-04-14 Paul Eggert <eggert@cs.ucla.edu> |
| 5012 | |
| 5013 | Improve C-level modularity by making more things 'static'. |
| 5014 | |
| 5015 | Don't publish debugger-only interfaces to other modules. |
| 5016 | * lisp.h (safe_debug_print, debug_output_compilation_hack): |
| 5017 | (verify_bytepos, count_markers): Move decls to the only modules |
| 5018 | that need them. |
| 5019 | * region-cache.h (pp_cache): Likewise. |
| 5020 | * window.h (check_all_windows): Likewise. |
| 5021 | * marker.c, print.c, region-cache.c, window.c: Decls moved here. |
| 5022 | |
| 5023 | * sysdep.c (croak): Now static, if |
| 5024 | defined TIOCNOTTY || defined USG5 || defined CYGWIN. |
| 5025 | * syssignal.h (croak): Declare only if not static. |
| 5026 | |
| 5027 | * alloc.c (refill_memory_reserve): Now static if |
| 5028 | !defined REL_ALLOC || defined SYSTEM_MALLOC. |
| 5029 | * lisp.h (refill_memory_reserve): Declare only if not static. |
| 5030 | |
| 5031 | * xsettings.c, xsettings.h (xsettings_get_system_normal_font): |
| 5032 | Define only if USE_LUCID. |
| 5033 | |
| 5034 | * xrdb.c (x_customization_string, x_rm_string): Now static. |
| 5035 | |
| 5036 | * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF. |
| 5037 | * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF. |
| 5038 | |
| 5039 | * xdisp.c (draw_row_with_mouse_face): Now static. |
| 5040 | * dispextern.h (draw_row_with_mouse_fave): Remove decl. |
| 5041 | |
| 5042 | * window.h (check_all_windows): Mark externally visible. |
| 5043 | |
| 5044 | * window.c (window_deletion_count): Now static. |
| 5045 | |
| 5046 | * undo.c: Make symbols static if they're not exported. |
| 5047 | (last_undo_buffer, last_boundary_position, pending_boundary): |
| 5048 | Now static. |
| 5049 | |
| 5050 | * textprop.c (interval_insert_behind_hooks): Now static. |
| 5051 | (interval_insert_in_front_hooks): Likewise. |
| 5052 | |
| 5053 | * term.c: Make symbols static if they're not exported. |
| 5054 | (tty_turn_off_highlight, get_tty_terminal, max_frame_cols): |
| 5055 | (max_frame_lines, tty_set_terminal_modes): |
| 5056 | (tty_reset_terminal_modes, tty_turn_off_highlight): |
| 5057 | (get_tty_terminal): Now static. |
| 5058 | (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM. |
| 5059 | * termhooks.h (term_mouse_moveto): Do not declare if |
| 5060 | HAVE_WINDOW_SYSTEM. |
| 5061 | * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes): |
| 5062 | (tty_turn_off_highlight, get_tty_terminal): Remove decls. |
| 5063 | |
| 5064 | * sysdep.c: Make symbols static if they're not exported. |
| 5065 | (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner): |
| 5066 | Now static. |
| 5067 | (sigprocmask_set, full_mask): Remove; unused. |
| 5068 | (wait_debugging): Mark as visible. |
| 5069 | * syssignal.h (SIGFULLMASK, full_mask): Remove decls. |
| 5070 | * systty.h (emacs_get_tty, emacs_set_tty): Remove decls. |
| 5071 | |
| 5072 | * syntax.c (syntax_temp): Define only if !__GNUC__. |
| 5073 | |
| 5074 | * sound.c (current_sound_device, current_sound): Now static. |
| 5075 | |
| 5076 | * search.c (searchbufs, searchbuf_head): Now static. |
| 5077 | |
| 5078 | * scroll.c (scroll_cost): Remove; unused. |
| 5079 | * dispextern.h (scroll_cost): Remove decl. |
| 5080 | |
| 5081 | * region-cache.h (pp_cache): Mark as externally visible. |
| 5082 | |
| 5083 | * process.c: Make symbols static if they're not exported. |
| 5084 | (process_tick, update_tick, create_process, chan_process): |
| 5085 | (Vprocess_alist, proc_buffered_char, datagram_access): |
| 5086 | (fd_callback_data, send_process_frame, process_sent_to): Now static. |
| 5087 | (deactivate_process): Mark defn as static, as well as decl. |
| 5088 | * lisp.h (create_process): Remove decl. |
| 5089 | * process.h (chan_process, Vprocess_alist): Remove decls. |
| 5090 | |
| 5091 | * print.c: Make symbols static if they're not exported. |
| 5092 | (print_depth, new_backquote_output, being_printed, print_buffer): |
| 5093 | (print_buffer_size, print_buffer_pos, print_buffer_pos_byte): |
| 5094 | (print_interval, print_number_index, initial_stderr_stream): |
| 5095 | Now static. |
| 5096 | * lisp.h (Fprinc): Remove decl. |
| 5097 | (debug_output_compilation_hack): Mark as externally visible. |
| 5098 | |
| 5099 | * sysdep.c (croak): Move decl from here to syssignal.h. |
| 5100 | * syssignal.h (croak): Put it here, so the API can be checked when |
| 5101 | 'croak' is called from dissociate_if_controlling_tty. |
| 5102 | |
| 5103 | * minibuf.c: Make symbols static if they're not exported. |
| 5104 | (minibuf_save_list, choose_minibuf_frame): Now static. |
| 5105 | * lisp.h (choose_minibuf_frame): Remove decl. |
| 5106 | |
| 5107 | * lisp.h (verify_bytepos, count_markers): Mark as externally visible. |
| 5108 | |
| 5109 | * lread.c: Make symbols static if they're not exported. |
| 5110 | (read_objects, initial_obarray, oblookup_last_bucket_number): |
| 5111 | Now static. |
| 5112 | (make_symbol): Remove; unused. |
| 5113 | * lisp.h (initial_obarray, make_symbol): Remove decls. |
| 5114 | |
| 5115 | * keyboard.c: Make symbols static if they're not exported. |
| 5116 | (single_kboard, recent_keys_index, total_keys, recent_keys): |
| 5117 | (this_command_key_count_reset, raw_keybuf, raw_keybuf_count): |
| 5118 | (this_single_command_key_start, echoing, last_auto_save): |
| 5119 | (read_key_sequence_cmd, dribble, recursive_edit_unwind): |
| 5120 | (command_loop, echo_now, keyboard_init_hook, help_char_p): |
| 5121 | (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer): |
| 5122 | (Vlispy_mouse_stem, double_click_count): |
| 5123 | Now static. |
| 5124 | (force_auto_save_soon): Define only if SIGDANGER. |
| 5125 | (ignore_mouse_drag_p): Now static if |
| 5126 | !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS. |
| 5127 | (print_help): Remove; unused. |
| 5128 | (stop_character, last_timer_event): Mark as externally visible. |
| 5129 | * keyboard.h (ignore_mouse_drag_p): Declare only if |
| 5130 | defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS. |
| 5131 | (echo_now, help_char_p, quit_throw_to_read_char): Remove decls. |
| 5132 | * lisp.h (echoing): Remove decl. |
| 5133 | (force_auto_save_soon): Declare only if SIGDANGER. |
| 5134 | * xdisp.c (redisplay_window): Simplify code, to make it more |
| 5135 | obvious that ignore_mouse_drag_p is not accessed if !defined |
| 5136 | USE_GTK && !defined HAVE_NS. |
| 5137 | |
| 5138 | * intervals.c: Make symbols static if they're not exported. |
| 5139 | (merge_properties_sticky, merge_interval_right, delete_interval): |
| 5140 | Now static. |
| 5141 | * intervals.h (merge_interval_right, delete_interval): Remove decls. |
| 5142 | |
| 5143 | * insdel.c: Make symbols static if they're not exported. |
| 5144 | However, leave prepare_to_modify_buffer alone. It's never |
| 5145 | called from outside this function, but that appears to be a bug. |
| 5146 | (combine_after_change_list, combine_after_change_buffer): |
| 5147 | (adjust_after_replace, signal_before_change): Now static. |
| 5148 | (adjust_after_replace_noundo): Remove; unused. |
| 5149 | * lisp.h (adjust_after_replace, adjust_after_replace_noundo): |
| 5150 | (signal_before_change): Remove decls. |
| 5151 | |
| 5152 | * indent.c (val_compute_motion, val_vmotion): Now static. |
| 5153 | |
| 5154 | * image.c: Make symbols static if they're not exported. |
| 5155 | * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare |
| 5156 | if USE_GTK. |
| 5157 | * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK. |
| 5158 | (xpm_color_cache, ct_table, ct_colors_allocated): Now static. |
| 5159 | |
| 5160 | * fringe.c (standard_bitmaps): Now static. |
| 5161 | (max_used_fringe_bitmap): Now static, unless HAVE_NS. |
| 5162 | |
| 5163 | * frame.c: Make symbols static if they're not exported. |
| 5164 | (x_report_frame_params, make_terminal_frame): Now static. |
| 5165 | (get_frame_param): Now static, unless HAVE_NS. |
| 5166 | (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM. |
| 5167 | (x_get_resource_string): Remove; not used. |
| 5168 | * frame.h (make_terminal_frame, x_report_frame_params): |
| 5169 | (x_get_resource_string); Remove decls. |
| 5170 | (x_fullscreen_adjust): Declare only if WINDOWSNT. |
| 5171 | * lisp.h (get_frame_param): Declare only if HAVE_NS. |
| 5172 | |
| 5173 | * font.c, fontset.c: Make symbols static if they're not exported. |
| 5174 | * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro. |
| 5175 | (FACE_SUITABLE_FOR_CHAR_P): Use it. |
| 5176 | * font.c (font_close_object): Now static. |
| 5177 | * font.h (font_close_object): Remove. |
| 5178 | * fontset.c (FONTSET_OBJLIST): Remove. |
| 5179 | (free_realized_fontset) #if-0 the body, which does nothing. |
| 5180 | (face_suitable_for_char_p): #if-0, as it's never called. |
| 5181 | * fontset.h (face_suitable_for_char_p): Remove decl. |
| 5182 | * xfaces.c (face_at_string_position): |
| 5183 | Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P, |
| 5184 | since 0 is always ASCII. |
| 5185 | |
| 5186 | * fns.c (weak_hash_tables): Now static. |
| 5187 | |
| 5188 | * fileio.c: Make symbols static if they're not exported. |
| 5189 | (auto_saving, auto_save_mode_bits, auto_save_error_occurred): |
| 5190 | (Vwrite_region_annotation_buffers): Now static. |
| 5191 | |
| 5192 | * eval.c: Make symbols static if they're not exported. |
| 5193 | (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static. |
| 5194 | * lisp.h (backtrace_list): Remove decl. |
| 5195 | |
| 5196 | * emacs.c: Make symbols static if they're not exported. |
| 5197 | (malloc_state_ptr, malloc_using_checking, syms_of_emacs): |
| 5198 | (fatal_error_code, fatal_error_signal_hook, standard_args): |
| 5199 | Now static. |
| 5200 | (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL. |
| 5201 | (DEFINE_DUMMY_FUNCTION): Mark function as externally visible. |
| 5202 | (__CTOR_LIST__, __DTOR_LIST__): Now externally visible. |
| 5203 | * lisp.h (fatal_error_signal_hook): Remove decl. |
| 5204 | (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL. |
| 5205 | |
| 5206 | * editfns.c: Move a (normally-unused) function to its only use. |
| 5207 | * editfns.c, lisp.h (get_operating_system_release): Remove. |
| 5208 | * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not |
| 5209 | worth the hassle of breaking this out. |
| 5210 | |
| 5211 | * xterm.c: Make symbols static if they're not exported. |
| 5212 | (x_raise_frame, x_lower_frame, x_wm_set_window_state): |
| 5213 | (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error): |
| 5214 | (x_destroy_window, x_delete_display): |
| 5215 | Now static. |
| 5216 | (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT). |
| 5217 | (x_mouse_leave): Remove; unused. |
| 5218 | * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame): |
| 5219 | (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap): |
| 5220 | (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes): |
| 5221 | Remove decls. |
| 5222 | (x_mouse_leave): Declare only if WINDOWSNT. |
| 5223 | (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT. |
| 5224 | (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS && |
| 5225 | USE_X_TOOLKIT. |
| 5226 | |
| 5227 | * ftxfont.c: Make symbols static if they're not exported. |
| 5228 | (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined |
| 5229 | HAVE_FREETYPE. |
| 5230 | * font.h (ftxfont_driver): Likewise. |
| 5231 | |
| 5232 | * xfns.c: Make symbols static if they're not exported. |
| 5233 | (x_last_font_name, x_display_info_for_name): |
| 5234 | (x_set_foreground_color, x_set_background_color, x_set_mouse_color): |
| 5235 | (x_set_cursor_color, x_set_border_pixel, x_set_border_color): |
| 5236 | (x_set_cursor_type, x_set_icon_type, x_set_icon_name): |
| 5237 | (x_set_scroll_bar_foreground, x_set_scroll_bar_background): |
| 5238 | (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer): |
| 5239 | (last_show_tip_args): Now static. |
| 5240 | (xic_defaut_fontset, xic_create_fontsetname): Define only if |
| 5241 | defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT |
| 5242 | (x_screen_planes): Remove; unused. |
| 5243 | * dispextern.h (x_screen_planes): Remove decl. |
| 5244 | |
| 5245 | * dispnew.c: Make symbols static if they're not exported. |
| 5246 | * dispextern.h (redraw_garbaged_frames, scrolling): |
| 5247 | (increment_row_positions): Remove. |
| 5248 | * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling): |
| 5249 | (delayed_size_change, glyph_matrix_count, glyph_pool_count): |
| 5250 | Now static. |
| 5251 | (redraw_garbaged_frames): Remove; unused. |
| 5252 | |
| 5253 | * xfaces.c: Make symbols static if they're not exported. |
| 5254 | * dispextern.h (ascii_face_of_lisp_face, free_realized_face): |
| 5255 | Remove decls. |
| 5256 | * xterm.h (defined_color): Remove decls. |
| 5257 | (x_free_dpy_colors): Declare only if USE_X_TOOLKIT. |
| 5258 | * xfaces.c (tty_suppress_bold_inverse_default_colors_p): |
| 5259 | (menu_face_changed_default, defined_color, free_realized_face): |
| 5260 | (x_free_dpy_colors): Define only if USE_X_TOOLKIT. |
| 5261 | (ascii_face_of_lisp_face): Remove; unused. |
| 5262 | |
| 5263 | * xdisp.c: Make symbols static if they're not exported. |
| 5264 | * dispextern.h (scratch_glyph_row, window_box_edges): |
| 5265 | (glyph_to_pixel_coords, set_cursor_from_row): |
| 5266 | (get_next_display_element, set_iterator_to_next): |
| 5267 | (highlight_trailing_whitespace, frame_to_window_pixel_xy): |
| 5268 | (show_mouse_face): Remove decls |
| 5269 | * frame.h (message_buf_print): Likewise. |
| 5270 | * lisp.h (pop_message, set_message, check_point_in_composition): |
| 5271 | Likewise. |
| 5272 | * xterm.h (set_vertical_scroll_bar): Likewise. |
| 5273 | * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed): |
| 5274 | (message_buf_print, scratch_glyph_row, displayed_buffer): |
| 5275 | (set_iterator_to_next, pop_message, set_message, set_cursor_from_row): |
| 5276 | (get_next_display_element, show_mouse_face, window_box_edges): |
| 5277 | (frame_to_window_pixel_xy, check_point_in_composition): |
| 5278 | (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static. |
| 5279 | (glyph_to_pixel_coords): Remove; unused. |
| 5280 | |
| 5281 | * dired.c (file_name_completion): Now static. |
| 5282 | |
| 5283 | * dbusbind.c (xd_in_read_queued_messages): Now static. |
| 5284 | |
| 5285 | * lisp.h (circular_list_error, FOREACH): Remove; unused. |
| 5286 | * data.c (circular_list_error): Remove. |
| 5287 | |
| 5288 | * commands.h (last_point_position, last_point_position_buffer): |
| 5289 | (last_point_position_window): Remove decls. |
| 5290 | * keyboard.c: Make these variables static. |
| 5291 | |
| 5292 | * coding.h (coding, code_convert_region, encode_coding_gap): |
| 5293 | Remove decls. |
| 5294 | * coding.c (Vsjis_coding_system, Vbig5_coding_system): |
| 5295 | (iso_code_class, detect_coding, code_convert_region): Now static. |
| 5296 | (encode_coding_gap): Remove; unused. |
| 5297 | |
| 5298 | * chartab.c (chartab_chars, chartab_bits): Now static. |
| 5299 | |
| 5300 | * charset.h (charset_iso_8859_1): Remove decl. |
| 5301 | * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump): |
| 5302 | Now static. |
| 5303 | |
| 5304 | * ccl.h (check_ccl_update, Vccl_program_table): Remove decls. |
| 5305 | * ccl.c (Vccl_program_table): Now static. |
| 5306 | (check_ccl_update): Remove; unused. |
| 5307 | |
| 5308 | * category.c (SET_CATEGORY_SET, set_category_set): Move here. |
| 5309 | * category.h: ... from here. |
| 5310 | * category.c (check_category_table, set_category_set): Now static. |
| 5311 | |
| 5312 | * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static. |
| 5313 | * lisp.h: Remove these decls. |
| 5314 | |
| 5315 | * buffer.c (buffer_count): Remove unused var. |
| 5316 | |
| 5317 | * bidi.c (bidi_dump_cached_states): Mark as externally visible, |
| 5318 | so that it's not optimized away. |
| 5319 | (bidi_ignore_explicit_marks_for_paragraph_level): Likewise. |
| 5320 | * dispextern.h (bidi_dump_cached_states): Remove, since it's |
| 5321 | exported only to the debugger. |
| 5322 | |
| 5323 | * atimer.c (alarm_signal_handler, run_all_atimers): Now static. |
| 5324 | * atimer.h (run_all_atimers): Remove; not exported. |
| 5325 | |
| 5326 | font.c: Make copy_font_spec and merge_font_spec ordinary C functions. |
| 5327 | * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it |
| 5328 | was inaccessible from Lisp. |
| 5329 | (merge_font_spec): Likewise, renaming from Fmerge_font_spec. |
| 5330 | * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses. |
| 5331 | |
| 5332 | alloc.c: Import and export fewer symbols, and remove unused items. |
| 5333 | * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING |
| 5334 | is defined. |
| 5335 | (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that |
| 5336 | it's not optimized away by whole-program optimization. |
| 5337 | (message_enable_multibyte, free_misc): Remove. |
| 5338 | (catchlist, handlerlist, mark_backtrace): |
| 5339 | Declare only if BYTE_MARK_STACK. |
| 5340 | (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo. |
| 5341 | * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined. |
| 5342 | (message_enable_multibyte): Remove decl. |
| 5343 | (free_misc, interval_free_list, float_block, float_block_index): |
| 5344 | (n_float_blocks, float_free_list, cons_block, cons_block_index): |
| 5345 | (cons_free_list, last_marked_index): |
| 5346 | Now static. |
| 5347 | (suppress_checking, die): Define only if ENABLE_CHECKING is defined. |
| 5348 | * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK. |
| 5349 | (mark_backtrace): Define only if BYTE_MARK_STACK. |
| 5350 | * xdisp.c (message_enable_multibyte): Now static. |
| 5351 | |
| 5352 | Declare Lisp_Object Q* variables to be 'static' if not exported. |
| 5353 | This makes it easier for human readers (and static analyzers) |
| 5354 | to see whether these variables are used from other modules. |
| 5355 | * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c: |
| 5356 | * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c: |
| 5357 | * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c: |
| 5358 | * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c: |
| 5359 | * lread.c, macros.c, minibuf.c, print.c, process.c, search.c: |
| 5360 | * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c: |
| 5361 | * xmenu.c, xselect.c: |
| 5362 | Declare Q* vars static if they are not used in other modules. |
| 5363 | * ccl.h, character.h, charset.h, coding.h, composite.h, font.h: |
| 5364 | * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h: |
| 5365 | Remove decls of unexported vars. |
| 5366 | * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro. |
| 5367 | |
| 5368 | * lisp.h (DEFINE_FUNC): Make sname 'static'. |
| 5369 | |
| 5370 | Make Emacs functions such as Fatom 'static' by default. |
| 5371 | This makes it easier for human readers (and static analyzers) |
| 5372 | to see whether these functions can be called from other modules. |
| 5373 | DEFUN now defines a static function. To make the function external |
| 5374 | so that it can be used in other C modules, use the new macro DEFUE. |
| 5375 | * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p): |
| 5376 | (Finit_image_library): |
| 5377 | (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer): |
| 5378 | (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute): |
| 5379 | (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes): |
| 5380 | Remove decls, since these functions are now static. |
| 5381 | (Funintern, Fget_internal_run_time): New decls, since these functions |
| 5382 | were already external. |
| 5383 | |
| 5384 | * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c: |
| 5385 | * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c: |
| 5386 | * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c: |
| 5387 | * fns.c, font.c, fontset.c, frame.c, image.c, indent.c: |
| 5388 | * keyboard.c, keymap.c, lread.c: |
| 5389 | * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c: |
| 5390 | * syntax.c, term.c, terminal.c, textprop.c, undo.c: |
| 5391 | * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c: |
| 5392 | Mark functions with DEFUE instead of DEFUN, |
| 5393 | if they are used in other modules. |
| 5394 | * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward |
| 5395 | decls for now-static functions. |
| 5396 | * buffer.h (Fdelete_overlay): Remove decl. |
| 5397 | * callproc.c (Fgetenv_internal): Mark as internal. |
| 5398 | * composite.c (Fremove_list_of_text_properties): Remove decl. |
| 5399 | (Fcomposition_get_gstring): New forward static decl. |
| 5400 | * composite.h (Fcomposite_get_gstring): Remove decl. |
| 5401 | * dired.c (Ffile_attributes): New forward static decl. |
| 5402 | * doc.c (Fdocumntation_property): New forward static decl. |
| 5403 | * eval.c (Ffetch_bytecode): New forward static decl. |
| 5404 | (Funintern): Remove extern decl; now in .h file where it belongs. |
| 5405 | * fileio.c (Fmake_symbolic_link): New forward static decl. |
| 5406 | * image.c (Finit_image_library): New forward static decl. |
| 5407 | * insdel.c (Fcombine_after_change_execute): Make forward decl static. |
| 5408 | * intervals.h (Fprevious_property_change): |
| 5409 | (Fremove_list_of_text_properties): Remove decls. |
| 5410 | * keyboard.c (Fthis_command_keys): Remove decl. |
| 5411 | (Fcommand_execute): New forward static decl. |
| 5412 | * keymap.c (Flookup_key): New forward static decl. |
| 5413 | (Fcopy_keymap): Now static. |
| 5414 | * keymap.h (Flookup_key): Remove decl. |
| 5415 | * process.c (Fget_process): New forward static decl. |
| 5416 | (Fprocess_datagram_address): Mark as internal. |
| 5417 | * syntax.c (Fsyntax_table_p): New forward static decl. |
| 5418 | (skip_chars): Remove duplicate decl. |
| 5419 | * textprop.c (Fprevious_property_change): New forward static decl. |
| 5420 | * window.c (Fset_window_fringes, Fset_window_scroll_bars): |
| 5421 | Now internal. |
| 5422 | (Fset_window_margins, Fset_window_vscroll): New forward static decls. |
| 5423 | * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls. |
| 5424 | |
| 5425 | * editfns.c (Fformat): Remove unreachable code. |
| 5426 | |
| 5427 | 2011-04-14 Andreas Schwab <schwab@linux-m68k.org> |
| 5428 | |
| 5429 | * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13 |
| 5430 | change. (Bug#8496) |
| 5431 | |
| 5432 | 2011-04-13 Eli Zaretskii <eliz@gnu.org> |
| 5433 | |
| 5434 | * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init |
| 5435 | when at ZV. (Bug#8487) |
| 5436 | |
| 5437 | 2011-04-12 Andreas Schwab <schwab@linux-m68k.org> |
| 5438 | |
| 5439 | * charset.c (Fclear_charset_maps): Use xfree instead of free. |
| 5440 | (Bug#8437) |
| 5441 | * keyboard.c (parse_tool_bar_item): Likewise. |
| 5442 | * sound.c (sound_cleanup, alsa_close): Likewise. |
| 5443 | * termcap.c (tgetent): Likewise. |
| 5444 | * xfns.c (x_default_font_parameter): Likewise. |
| 5445 | * xsettings.c (read_and_apply_settings): Likewise. |
| 5446 | |
| 5447 | * alloc.c (overrun_check_malloc, overrun_check_realloc) |
| 5448 | (overrun_check_free): Protoize. |
| 5449 | |
| 5450 | 2011-04-12 Paul Eggert <eggert@cs.ucla.edu> |
| 5451 | |
| 5452 | * sysdep.c (emacs_read, emacs_write): Check for negative sizes |
| 5453 | since callers should never pass a negative size. |
| 5454 | Change the signature to match that of plain 'read' and 'write'; see |
| 5455 | <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>. |
| 5456 | * lisp.h: Update prototypes of emacs_write and emacs_read. |
| 5457 | |
| 5458 | 2011-04-11 Eli Zaretskii <eliz@gnu.org> |
| 5459 | |
| 5460 | * xdisp.c (redisplay_window): Don't try to determine the character |
| 5461 | position of the scroll margin if the window start point w->startp |
| 5462 | is outside the buffer's accessible region. (Bug#8468) |
| 5463 | |
| 5464 | 2011-04-10 Eli Zaretskii <eliz@gnu.org> |
| 5465 | |
| 5466 | Fix write-region and its subroutines for buffers > 2GB. |
| 5467 | * fileio.c (a_write, e_write): Modify declaration of arguments and |
| 5468 | local variables to support buffers larger than 2GB. |
| 5469 | (Fcopy_file): Use EMACS_INT for return value of emacs_read. |
| 5470 | |
| 5471 | * sysdep.c (emacs_write, emacs_read): Use ssize_t for last |
| 5472 | argument, local variables, and return value. |
| 5473 | |
| 5474 | * lisp.h: Update prototypes of emacs_write and emacs_read. |
| 5475 | |
| 5476 | * sound.c (vox_write): Use ssize_t for return value of emacs_write. |
| 5477 | |
| 5478 | 2011-04-10 Paul Eggert <eggert@cs.ucla.edu> |
| 5479 | |
| 5480 | * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack. |
| 5481 | |
| 5482 | Fix more problems found by GCC 4.6.0's static checks. |
| 5483 | |
| 5484 | * xdisp.c (vmessage): Use a better test for character truncation. |
| 5485 | |
| 5486 | * charset.c (load_charset_map): <, not <=, for optimization, |
| 5487 | and to avoid potential problems with integer overflow. |
| 5488 | * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise. |
| 5489 | * casetab.c (set_identity, shuffle): Likewise. |
| 5490 | * editfns.c (Fformat): Likewise. |
| 5491 | * syntax.c (skip_chars): Likewise. |
| 5492 | |
| 5493 | * xmenu.c (set_frame_menubar): Allocate smaller local vectors. |
| 5494 | This also lets GCC 4.6.0 generate slightly better loop code. |
| 5495 | |
| 5496 | * callint.c (Fcall_interactively): <, not <=, for optimization. |
| 5497 | (Fcall_interactively): Count the number of arguments produced, |
| 5498 | not the number of arguments given. This is simpler and lets GCC |
| 5499 | 4.6.0 generate slightly better code. |
| 5500 | |
| 5501 | * ftfont.c: Distingish more carefully between FcChar8 and char. |
| 5502 | The previous code passed unsigned char * to a functions like |
| 5503 | strlen and xstrcasecmp that expect char *, which does not |
| 5504 | conform to the C standard. |
| 5505 | (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for |
| 5506 | arguments to FcPatternGetString, and explicitly cast FcChar8 * to |
| 5507 | char * when the C standard requires it. |
| 5508 | |
| 5509 | * keyboard.c (read_char): Remove unused var. |
| 5510 | |
| 5511 | * eval.c: Port to Windows vsnprintf (Bug#8435). |
| 5512 | Include <limits.h>. |
| 5513 | (SIZE_MAX): Define if the headers do not. |
| 5514 | (verror): Do not give up if vsnprintf returns a negative count. |
| 5515 | Instead, grow the buffer. This ports to Windows vsnprintf, which |
| 5516 | does not conform to C99. Problem reported by Eli Zaretskii. |
| 5517 | Also, simplify the allocation scheme, by avoiding the need for |
| 5518 | calling realloc, and removing the ALLOCATED variable. |
| 5519 | |
| 5520 | * eval.c (verror): Initial buffer size is 4000 (not 200) bytes. |
| 5521 | |
| 5522 | Remove invocations of doprnt, as Emacs now uses vsnprintf. |
| 5523 | But keep the doprint source code for now, as we might revamp it |
| 5524 | and use it again (Bug#8435). |
| 5525 | * lisp.h (doprnt): Remove. |
| 5526 | * Makefile.in (base_obj): Remove doprnt.o. |
| 5527 | * deps.mk (doprnt.o): Remove. |
| 5528 | |
| 5529 | error: Print 32- and 64-bit integers portably (Bug#8435). |
| 5530 | Without this change, on typical 64-bit hosts error ("...%d...", N) |
| 5531 | was used to print both 32- and 64-bit integers N, which relied on |
| 5532 | undefined behavior. |
| 5533 | * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd): |
| 5534 | New macro. |
| 5535 | * lisp.h (error, verror): Mark as printf-like functions. |
| 5536 | * eval.c (verror): Use vsnprintf, not doprnt, to do the real work. |
| 5537 | Report overflow in size calculations when allocating printf buffer. |
| 5538 | Do not truncate output string at its first null byte. |
| 5539 | * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work. |
| 5540 | Truncate the output at a character boundary, since vsnprintf does not |
| 5541 | do that. |
| 5542 | * charset.c (check_iso_charset_parameter): Convert internal |
| 5543 | character to string before calling 'error', since %c now has the |
| 5544 | printf meaning. |
| 5545 | * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int |
| 5546 | overflow when computing char to be passed to 'error'. Do not |
| 5547 | pass Lisp_Object to 'error'; pass the integer instead. |
| 5548 | * nsfns.m (Fns_do_applescript): Use int, not long, since it's |
| 5549 | formatted with plain %d. |
| 5550 | |
| 5551 | * eval.c (internal_lisp_condition_case): Don't pass spurious arg. |
| 5552 | |
| 5553 | * keyboard.c (access_keymap_keyremap): Print func name, not garbage. |
| 5554 | |
| 5555 | * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int. |
| 5556 | |
| 5557 | * xterm.c (x_catch_errors): Remove duplicate declaration. |
| 5558 | |
| 5559 | * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too. |
| 5560 | |
| 5561 | * xdisp.c, lisp.h (message_nolog): Remove; unused. |
| 5562 | |
| 5563 | 2011-04-10 Jim Meyering <meyering@redhat.com> |
| 5564 | |
| 5565 | use ssize_t and size_t for read- and write-like emacs_gnutls_* functions |
| 5566 | * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like: |
| 5567 | return ssize_t not "int", and use size_t as the buffer length. |
| 5568 | (emacs_gnutls_write): Likewise, and make the buffer pointer "const". |
| 5569 | * gnutls.h: Update declarations. |
| 5570 | * process.c (read_process_output): Use ssize_t, to match. |
| 5571 | (send_process): Likewise. |
| 5572 | |
| 5573 | 2011-04-09 Chong Yidong <cyd@stupidchicken.com> |
| 5574 | |
| 5575 | * image.c (Fimagemagick_types): Doc fix, and comment cleanup. |
| 5576 | |
| 5577 | 2011-04-09 Chong Yidong <cyd@stupidchicken.com> |
| 5578 | |
| 5579 | * ftfont.c (get_adstyle_property, ftfont_pattern_entity): |
| 5580 | Use unsigned char, to match FcChar8 type definition. |
| 5581 | |
| 5582 | * xterm.c (handle_one_xevent): |
| 5583 | * xmenu.c (create_and_show_popup_menu): |
| 5584 | * xselect.c (x_decline_selection_request) |
| 5585 | (x_reply_selection_request): Avoid type-punned deref of X events. |
| 5586 | |
| 5587 | 2011-04-09 Eli Zaretskii <eliz@gnu.org> |
| 5588 | |
| 5589 | Fix some uses of `int' instead of EMACS_INT. |
| 5590 | * search.c (string_match_1, fast_string_match) |
| 5591 | (fast_c_string_match_ignore_case, fast_string_match_ignore_case) |
| 5592 | (scan_buffer, find_next_newline_no_quit) |
| 5593 | (find_before_next_newline, search_command, Freplace_match) |
| 5594 | (Fmatch_data): Make some `int' variables be EMACS_INT. |
| 5595 | |
| 5596 | * xdisp.c (display_count_lines): 3rd argument and return value now |
| 5597 | EMACS_INT. All callers changed. |
| 5598 | (pint2hrstr): Last argument is now EMACS_INT. |
| 5599 | |
| 5600 | * coding.c (detect_coding_utf_8, detect_coding_emacs_mule) |
| 5601 | (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5) |
| 5602 | (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8) |
| 5603 | (decode_coding_utf_16, decode_coding_emacs_mule) |
| 5604 | (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5) |
| 5605 | (decode_coding_ccl, decode_coding_charset) |
| 5606 | <consumed_chars, consumed_chars_base>: Declare EMACS_INT. |
| 5607 | (decode_coding_iso_2022, decode_coding_emacs_mule) |
| 5608 | (decode_coding_sjis, decode_coding_big5, decode_coding_charset) |
| 5609 | <char_offset, last_offset>: Declare EMACS_INT. |
| 5610 | (encode_coding_utf_8, encode_coding_utf_16) |
| 5611 | (encode_coding_emacs_mule, encode_invocation_designation) |
| 5612 | (encode_designation_at_bol, encode_coding_iso_2022) |
| 5613 | (encode_coding_sjis, encode_coding_big5, encode_coding_ccl) |
| 5614 | (encode_coding_raw_text, encode_coding_charset) <produced_chars>: |
| 5615 | Declare EMACS_INT. |
| 5616 | (ASSURE_DESTINATION): Declare more_bytes EMACS_INT. |
| 5617 | (encode_invocation_designation): Last argument P_NCHARS is now |
| 5618 | EMACS_INT. |
| 5619 | (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT. |
| 5620 | (produce_chars): from_nchars and to_nchars are now EMACS_INT. |
| 5621 | |
| 5622 | * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT. |
| 5623 | All users changed. |
| 5624 | |
| 5625 | * ccl.c (Fccl_execute_on_string): Declare some variables |
| 5626 | EMACS_INT. |
| 5627 | |
| 5628 | 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change) |
| 5629 | |
| 5630 | * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450). |
| 5631 | |
| 5632 | 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com> |
| 5633 | |
| 5634 | * process.c (Fformat_network_address): Doc fix. |
| 5635 | |
| 5636 | 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change) |
| 5637 | |
| 5638 | * xml.c (parse_region): Avoid creating spurious whiespace nodes. |
| 5639 | |
| 5640 | 2011-04-08 Chong Yidong <cyd@stupidchicken.com> |
| 5641 | |
| 5642 | * keyboard.c (read_char): Call Lisp function help-form-show, |
| 5643 | instead of using internal_with_output_to_temp_buffer. |
| 5644 | (Qhelp_form_show): New var. |
| 5645 | (syms_of_keyboard): Use DEFSYM macro. |
| 5646 | |
| 5647 | * print.c (internal_with_output_to_temp_buffer): Function deleted. |
| 5648 | |
| 5649 | * lisp.h (internal_with_output_to_temp_buffer): Remove prototype. |
| 5650 | |
| 5651 | 2011-04-06 Chong Yidong <cyd@stupidchicken.com> |
| 5652 | |
| 5653 | * process.c (Flist_processes): Remove to Lisp. |
| 5654 | (list_processes_1): Delete. |
| 5655 | |
| 5656 | 2011-04-06 Eli Zaretskii <eliz@gnu.org> |
| 5657 | |
| 5658 | * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements. |
| 5659 | |
| 5660 | * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs. |
| 5661 | |
| 5662 | 2011-04-06 Paul Eggert <eggert@cs.ucla.edu> |
| 5663 | |
| 5664 | Fix more problems found by GCC 4.6.0's static checks. |
| 5665 | |
| 5666 | * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats. |
| 5667 | |
| 5668 | * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats. |
| 5669 | |
| 5670 | * lisp.h (message, message_nolog, fatal): Mark as printf-like. |
| 5671 | |
| 5672 | * xdisp.c (vmessage): Mark as a printf-like function. |
| 5673 | |
| 5674 | * term.c (vfatal, maybe_fatal): Mark as printf-like functions. |
| 5675 | |
| 5676 | * sound.c (sound_warning): Don't crash if arg contains a printf format. |
| 5677 | |
| 5678 | * image.c (tiff_error_handler, tiff_warning_handler): Mark as |
| 5679 | printf-like functions. |
| 5680 | (tiff_load): Add casts to remove these marks before passing them |
| 5681 | to system-supplied API. |
| 5682 | |
| 5683 | * eval.c (Fsignal): Remove excess argument to 'fatal'. |
| 5684 | |
| 5685 | * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int. |
| 5686 | This avoids several warnings with gcc -Wstrict-overflow. |
| 5687 | (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code |
| 5688 | directly, rather than having caller test rule sign. This avoids |
| 5689 | some unnecessary tests. |
| 5690 | * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro. |
| 5691 | (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This |
| 5692 | affects only one use, in DECODE_COMPOSITION_RULE, which is changed. |
| 5693 | |
| 5694 | * xfont.c (xfont_text_extents): Remove var that was set but not used. |
| 5695 | (xfont_open): Avoid unnecessary tests. |
| 5696 | |
| 5697 | * composite.c (composition_gstring_put_cache): Use unsigned integer. |
| 5698 | |
| 5699 | * composite.h, composite.c (composition_gstring_put_cache): |
| 5700 | Use EMACS_INT, not int, for length. |
| 5701 | |
| 5702 | * composite.h (COMPOSITION_DECODE_REFS): New macro, |
| 5703 | breaking out part of COMPOSITION_DECODE_RULE. |
| 5704 | (COMPOSITION_DECODE_RULE): Use it. |
| 5705 | * composite.c (get_composition_id): Remove unused local vars, |
| 5706 | by using the new macro. |
| 5707 | |
| 5708 | * textprop.c (set_text_properties_1): Change while to do-while, |
| 5709 | since the condition is always true at first. |
| 5710 | |
| 5711 | * intervals.c (graft_intervals_into_buffer): Mark var as used. |
| 5712 | (interval_deletion_adjustment): Return unsigned value. |
| 5713 | All uses changed. |
| 5714 | |
| 5715 | * process.c (list_processes_1, create_pty, read_process_output): |
| 5716 | (exec_sentinel): Remove vars that were set but not used. |
| 5717 | (create_pty): Remove unnecessary "volatile"s. |
| 5718 | (Fnetwork_interface_info): Avoid possibility of int overflow. |
| 5719 | (read_process_output): Do adaptive read buffering even if carryover. |
| 5720 | (read_process_output): Simplify nbytes computation if buffered. |
| 5721 | |
| 5722 | * bytecode.c (exec_byte_code): Rename local to avoid shadowing. |
| 5723 | |
| 5724 | * syntax.c (scan_words): Remove var that was set but not used. |
| 5725 | (update_syntax_table): Use unsigned instead of int. |
| 5726 | |
| 5727 | * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs. |
| 5728 | (lisp_file_lexically_bound_p, read1): Use unsigned instead of int. |
| 5729 | (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop. |
| 5730 | |
| 5731 | * print.c (print_error_message): Avoid int overflow. |
| 5732 | |
| 5733 | * font.c (font_list_entities): Redo for clarity, |
| 5734 | so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX. |
| 5735 | |
| 5736 | * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars. |
| 5737 | (font_score): Avoid potential overflow in diff calculation. |
| 5738 | |
| 5739 | * fns.c (substring_both): Remove var that is set but not used. |
| 5740 | (sxhash): Redo loop for clarity and to avoid wraparound warning. |
| 5741 | |
| 5742 | * eval.c (funcall_lambda): Rename local to avoid shadowing. |
| 5743 | |
| 5744 | * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int. |
| 5745 | Otherwise, GCC 4.6.0 optimizes the loop check away since the check |
| 5746 | can always succeed if overflow has undefined behavior. |
| 5747 | |
| 5748 | * search.c (boyer_moore, wordify): Remove vars set but not used. |
| 5749 | (wordify): Omit three unnecessary tests. |
| 5750 | |
| 5751 | * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column. |
| 5752 | All callers changed. This avoids the need for an unused var. |
| 5753 | |
| 5754 | * casefiddle.c (casify_region): Remove var that is set but not used. |
| 5755 | |
| 5756 | * dired.c (file_name_completion): Remove var that is set but not used. |
| 5757 | |
| 5758 | * fileio.c (Finsert_file_contents): Make EOF condition clearer. |
| 5759 | |
| 5760 | * fileio.c (Finsert_file_contents): Avoid signed integer overflow. |
| 5761 | (Finsert_file_contents): Remove unnecessary code checking fd. |
| 5762 | |
| 5763 | * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes. |
| 5764 | Check for integer overflow on size calculations. |
| 5765 | |
| 5766 | * buffer.c (Fprevious_overlay_change): Remove var that is set |
| 5767 | but not used. |
| 5768 | |
| 5769 | * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt): |
| 5770 | Remove vars that are set but not used. |
| 5771 | (timer_check_2): Don't assume timer-list and idle-timer-list are lists. |
| 5772 | (timer_check_2): Mark vars as initialized. |
| 5773 | |
| 5774 | * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized. |
| 5775 | |
| 5776 | * image.c (lookup_image): Remove var that is set but not used. |
| 5777 | (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable. |
| 5778 | |
| 5779 | * fontset.c (Finternal_char_font, Ffontset_info): Remove vars |
| 5780 | that are set but not used. |
| 5781 | |
| 5782 | * xfns.c (make_invisible_cursor): Don't return garbage |
| 5783 | if XCreateBitmapFromData fails (Bug#8410). |
| 5784 | |
| 5785 | * xselect.c (x_get_local_selection, x_handle_property_notify): |
| 5786 | Remove vars that are set but not used. |
| 5787 | |
| 5788 | * xfns.c (x_create_tip_frame): Remove var that is set but not used. |
| 5789 | (make_invisible_cursor): Initialize a possibly-uninitialized variable. |
| 5790 | |
| 5791 | * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]: |
| 5792 | Remove var that is set but not used. |
| 5793 | (scroll_bar_windows_size): Now size_t, not int. |
| 5794 | (x_send_scroll_bar_event): Use size_t, not int, for sizes. |
| 5795 | Check for overflow. |
| 5796 | |
| 5797 | * xfaces.c (realize_named_face): Remove vars that are set but not used. |
| 5798 | (map_tty_color) [!defined MSDOS]: Likewise. |
| 5799 | |
| 5800 | * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning. |
| 5801 | |
| 5802 | * coding.c: Remove vars that are set but not used. |
| 5803 | (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused. |
| 5804 | All callers changed. |
| 5805 | (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule): |
| 5806 | (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5): |
| 5807 | (decode_coding_charset): Remove vars that are set but not used. |
| 5808 | |
| 5809 | * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var |
| 5810 | that is set but not used. |
| 5811 | |
| 5812 | * print.c (print_object): Remove var that is set but not used. |
| 5813 | |
| 5814 | Replace 2 copies of readlink code with 1 gnulib version (Bug#8401). |
| 5815 | The gnulib version avoids calling malloc in the usual case, |
| 5816 | and on 64-bit hosts doesn't have some arbitrary 32-bit limits. |
| 5817 | * fileio.c (Ffile_symlink_p): Use emacs_readlink. |
| 5818 | * filelock.c (current_lock_owner): Likewise. |
| 5819 | * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function. |
| 5820 | * sysdep.c: Include allocator.h, careadlinkat.h. |
| 5821 | (emacs_no_realloc_allocator): New static constant. |
| 5822 | (emacs_readlink): New function. |
| 5823 | * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on |
| 5824 | ../lib/careadlinkat.h. |
| 5825 | |
| 5826 | 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca> |
| 5827 | |
| 5828 | * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the |
| 5829 | first non-nil return value). |
| 5830 | |
| 5831 | 2011-04-03 Jan Djärv <jan.h.d@swipnet.se> |
| 5832 | |
| 5833 | * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6 |
| 5834 | if not defined (Bug#8403). |
| 5835 | |
| 5836 | 2011-04-02 Juanma Barranquero <lekktu@gmail.com> |
| 5837 | |
| 5838 | * xdisp.c (display_count_lines): Remove parameter `start', |
| 5839 | unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed. |
| 5840 | (get_char_face_and_encoding): Remove parameter `multibyte_p', |
| 5841 | unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed. |
| 5842 | (fill_stretch_glyph_string): Remove parameters `row' and `area', |
| 5843 | unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk |
| 5844 | and thereabouts. All callers changed. |
| 5845 | (get_per_char_metric): Remove parameter `f', unused since |
| 5846 | 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed. |
| 5847 | |
| 5848 | 2011-04-02 Jim Meyering <meyering@redhat.com> |
| 5849 | |
| 5850 | do not dereference NULL upon failed strdup |
| 5851 | * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup. |
| 5852 | (ns_get_family): Likewise. |
| 5853 | |
| 5854 | 2011-04-02 Juanma Barranquero <lekktu@gmail.com> |
| 5855 | |
| 5856 | * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment. |
| 5857 | |
| 5858 | 2011-04-02 Jan Djärv <jan.h.d@swipnet.se> |
| 5859 | |
| 5860 | * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or |
| 5861 | later (Bug#8403). |
| 5862 | |
| 5863 | 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca> |
| 5864 | |
| 5865 | Add lexical binding. |
| 5866 | |
| 5867 | * window.c (Ftemp_output_buffer_show): New fun. |
| 5868 | (Fsave_window_excursion): |
| 5869 | * print.c (Fwith_output_to_temp_buffer): Move to subr.el. |
| 5870 | |
| 5871 | * lread.c (lisp_file_lexically_bound_p): New function. |
| 5872 | (Fload): Bind Qlexical_binding. |
| 5873 | (readevalloop): Remove `evalfun' arg. |
| 5874 | Bind Qinternal_interpreter_environment. |
| 5875 | (Feval_buffer): Bind Qlexical_binding. |
| 5876 | (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard): |
| 5877 | Mark as dynamic. |
| 5878 | (syms_of_lread): Declare `lexical-binding'. |
| 5879 | |
| 5880 | * lisp.h (struct Lisp_Symbol): New field `declared_special'. |
| 5881 | |
| 5882 | * keyboard.c (eval_dyn): New fun. |
| 5883 | (menu_item_eval_property): Use it. |
| 5884 | |
| 5885 | * image.c (parse_image_spec): Use Ffunctionp. |
| 5886 | |
| 5887 | * fns.c (concat, mapcar1): Accept byte-code-functions. |
| 5888 | |
| 5889 | * eval.c (Fsetq): Handle lexical vars. |
| 5890 | (Fdefun, Fdefmacro, Ffunction): Make closures when needed. |
| 5891 | (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic. |
| 5892 | (FletX, Flet): Obey lexical binding. |
| 5893 | (Fcommandp): Handle closures. |
| 5894 | (Feval): New `lexical' arg. |
| 5895 | (eval_sub): New function extracted from Feval. Use it almost |
| 5896 | everywhere where Feval was used. Look up vars in lexical env. |
| 5897 | Handle closures. |
| 5898 | (Ffunctionp): Move from subr.el. |
| 5899 | (Ffuncall): Handle closures. |
| 5900 | (apply_lambda): Remove `eval_flags'. |
| 5901 | (funcall_lambda): Handle closures and new byte-code-functions. |
| 5902 | (Fspecial_variable_p): New function. |
| 5903 | (syms_of_eval): Initialize the Vinternal_interpreter_environment var, |
| 5904 | but without exporting it to Lisp. |
| 5905 | |
| 5906 | * doc.c (Fdocumentation, store_function_docstring): |
| 5907 | * data.c (Finteractive_form): Handle closures. |
| 5908 | |
| 5909 | * callint.c (Fcall_interactively): Preserve lexical-binding mode for |
| 5910 | interactive spec. |
| 5911 | |
| 5912 | * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): |
| 5913 | New byte-codes. |
| 5914 | (exec_byte_code): New function extracted from Fbyte_code to handle new |
| 5915 | calling convention for byte-code-functions. Add new byte-codes. |
| 5916 | |
| 5917 | * buffer.c (defvar_per_buffer): Set new `declared_special' field. |
| 5918 | |
| 5919 | * alloc.c (Fmake_symbol): Init new `declared_special' field. |
| 5920 | |
| 5921 | 2011-03-31 Juanma Barranquero <lekktu@gmail.com> |
| 5922 | |
| 5923 | * xdisp.c (redisplay_internal): Fix prototype. |
| 5924 | |
| 5925 | 2011-03-31 Eli Zaretskii <eliz@gnu.org> |
| 5926 | |
| 5927 | * xdisp.c (SCROLL_LIMIT): New macro. |
| 5928 | (try_scrolling): Use it when setting scroll_limit. |
| 5929 | Limit scrolling to 100 screen lines. |
| 5930 | (redisplay_window): Even when falling back on "recentering", |
| 5931 | position point in the window according to scroll-conservatively, |
| 5932 | scroll-margin, and scroll-*-aggressively variables. (Bug#6671) |
| 5933 | |
| 5934 | (try_scrolling): When point is above the window, allow searching |
| 5935 | as far as scroll_max, or one screenful, to compute vertical |
| 5936 | distance from PT to the scroll margin position. This prevents |
| 5937 | try_scrolling from unnecessarily failing when |
| 5938 | scroll-conservatively is set to a value slightly larger than the |
| 5939 | window height. Clean up the case of PT below the margin at bottom |
| 5940 | of window: scroll_max can no longer be INT_MAX. When aggressive |
| 5941 | scrolling is in use, don't let point enter the opposite scroll |
| 5942 | margin as result of the scroll. |
| 5943 | (syms_of_xdisp) <scroll-conservatively>: Document the |
| 5944 | threshold of 100 lines for never-recentering scrolling. |
| 5945 | |
| 5946 | 2011-03-31 Juanma Barranquero <lekktu@gmail.com> |
| 5947 | |
| 5948 | * dispextern.h (move_it_by_lines): |
| 5949 | * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused |
| 5950 | since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed. |
| 5951 | (message_log_check_duplicate): Remove parameters `prev_bol' and |
| 5952 | `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed. |
| 5953 | (redisplay_internal): Remove parameter `preserve_echo_area', |
| 5954 | unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed. |
| 5955 | |
| 5956 | * indent.c (Fvertical_motion): |
| 5957 | * window.c (window_scroll_pixel_based, Frecenter): |
| 5958 | Don't pass `need_y_p' to `move_it_by_lines'. |
| 5959 | |
| 5960 | 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca> |
| 5961 | |
| 5962 | * eval.c (struct backtrace): Don't cheat with negative numbers, but do |
| 5963 | steal a few bits to be more compact. |
| 5964 | (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace): |
| 5965 | Remove unneeded casts. |
| 5966 | |
| 5967 | * bytecode.c (Fbyte_code): CAR and CDR can GC. |
| 5968 | |
| 5969 | 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change) |
| 5970 | |
| 5971 | * keyboard.c (Fexecute_extended_command): Do log the "suggest key |
| 5972 | binding" message (bug#7967). |
| 5973 | |
| 5974 | 2011-03-30 Paul Eggert <eggert@cs.ucla.edu> |
| 5975 | |
| 5976 | Fix more problems found by GCC 4.6.0's static checks. |
| 5977 | |
| 5978 | * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]: |
| 5979 | Remove unused local var. |
| 5980 | |
| 5981 | * editfns.c (Fmessage_box): Remove unused local var. |
| 5982 | |
| 5983 | * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs): |
| 5984 | (note_mode_line_or_margin_highlight, note_mouse_highlight): |
| 5985 | Omit unused local vars. |
| 5986 | * window.c (shrink_windows): Omit unused local var. |
| 5987 | * menu.c (digest_single_submenu): Omit unused local var. |
| 5988 | * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]: |
| 5989 | Omit unused local var. |
| 5990 | |
| 5991 | * keyboard.c (parse_modifiers_uncached, parse_modifiers): |
| 5992 | Don't assume string length fits in int. |
| 5993 | (keyremap_step, read_key_sequence): Use size_t for sizes. |
| 5994 | (read_key_sequence): Don't check last_real_key_start redundantly. |
| 5995 | |
| 5996 | * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA |
| 5997 | instead of alloca (Bug#8344). |
| 5998 | |
| 5999 | * eval.c (Fbacktrace): Don't assume nargs fits in int. |
| 6000 | (Fbacktrace_frame): Don't assume nframes fits in int. |
| 6001 | |
| 6002 | * syntax.c (scan_sexps_forward): Avoid pointer wraparound. |
| 6003 | |
| 6004 | * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow |
| 6005 | concerns. |
| 6006 | |
| 6007 | * term.c (produce_glyphless_glyph): Remove unnecessary test. |
| 6008 | |
| 6009 | * cm.c (calccost): Turn while-do into do-while, for clarity. |
| 6010 | |
| 6011 | * keyboard.c (syms_of_keyboard): Use the same style as later |
| 6012 | in this function when indexing through an array. This also |
| 6013 | works around GCC bug 48267. |
| 6014 | |
| 6015 | * image.c (tiff_load): Fix off-by-one image count (Bug#8336). |
| 6016 | |
| 6017 | * xselect.c (x_check_property_data): Return correct size (Bug#8335). |
| 6018 | |
| 6019 | * chartab.c (sub_char_table_ref_and_range): Redo for slight |
| 6020 | efficiency gain, and to bypass a gcc -Wstrict-overflow warning. |
| 6021 | |
| 6022 | * keyboard.c, keyboard.h (num_input_events): Now size_t. |
| 6023 | This avoids undefined behavior on integer overflow, and is a bit |
| 6024 | more convenient anyway since it is compared to a size_t variable. |
| 6025 | |
| 6026 | Variadic C functions now count arguments with size_t, not int. |
| 6027 | This avoids an unnecessary limitation on 64-bit machines, which |
| 6028 | caused (substring ...) to crash on large vectors (Bug#8344). |
| 6029 | * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int. |
| 6030 | (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise. |
| 6031 | All variadic functions and their callers changed accordingly. |
| 6032 | (struct gcpro.nvars): Now size_t, not int. All uses changed. |
| 6033 | * data.c (arith_driver, float_arith_driver): Likewise. |
| 6034 | * editfns.c (general_insert_function): Likewise. |
| 6035 | * eval.c (struct backtrace.nargs, interactive_p) |
| 6036 | (internal_condition_case_n, run_hook_with_args, apply_lambda) |
| 6037 | (funcall_lambda, mark_backtrace): Likewise. |
| 6038 | * fns.c (concat): Likewise. |
| 6039 | * frame.c (x_set_frame_parameters): Likewise. |
| 6040 | * fns.c (get_key_arg): Now accepts and returns size_t, and returns |
| 6041 | 0 if not found, not -1. All callers changed. |
| 6042 | |
| 6043 | * alloc.c (garbage_collect): Don't assume stack size fits in int. |
| 6044 | (stack_copy_size): Now size_t, not int. |
| 6045 | (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0. |
| 6046 | |
| 6047 | 2011-03-28 Juanma Barranquero <lekktu@gmail.com> |
| 6048 | |
| 6049 | * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end', |
| 6050 | unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org. |
| 6051 | All callers changed. |
| 6052 | |
| 6053 | * lisp.h (multibyte_char_to_unibyte): |
| 6054 | * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl', |
| 6055 | unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org. |
| 6056 | * character.h (CHAR_TO_BYTE8): |
| 6057 | * cmds.c (internal_self_insert): |
| 6058 | * editfns.c (general_insert_function): |
| 6059 | * keymap.c (push_key_description): |
| 6060 | * search.c (Freplace_match): |
| 6061 | * xdisp.c (message_dolog, set_message_1): All callers changed. |
| 6062 | |
| 6063 | 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca> |
| 6064 | |
| 6065 | * keyboard.c (safe_run_hook_funcall): New function. |
| 6066 | (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error, |
| 6067 | don't set the hook to nil, but remove the offending function instead. |
| 6068 | (Qcommand_hook_internal): Remove, unused. |
| 6069 | (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define |
| 6070 | Vcommand_hook_internal. |
| 6071 | |
| 6072 | * eval.c (enum run_hooks_condition): Remove. |
| 6073 | (funcall_nil, funcall_not): New functions. |
| 6074 | (run_hook_with_args): Call each function through a `funcall' argument. |
| 6075 | Remove `cond' argument, now redundant. |
| 6076 | (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success) |
| 6077 | (Frun_hook_with_args_until_failure): Adjust accordingly. |
| 6078 | (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions. |
| 6079 | |
| 6080 | 2011-03-28 Juanma Barranquero <lekktu@gmail.com> |
| 6081 | |
| 6082 | * dispextern.h (string_buffer_position): Remove declaration. |
| 6083 | |
| 6084 | * print.c (strout): Remove parameter `multibyte', unused since |
| 6085 | 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed. |
| 6086 | |
| 6087 | * search.c (boyer_moore): Remove parameters `len', `pos' and `lim', |
| 6088 | never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org. |
| 6089 | All callers changed. |
| 6090 | |
| 6091 | * w32.c (_wsa_errlist): Use braces for struct initializers. |
| 6092 | |
| 6093 | * xdisp.c (string_buffer_position_lim): Remove parameter `w', |
| 6094 | never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org. |
| 6095 | All callers changed. |
| 6096 | (string_buffer_position): Likewise. Also, make static (it's never |
| 6097 | used outside xdisp.c). |
| 6098 | (cursor_row_p): Remove parameter `w', unused since |
| 6099 | 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed. |
| 6100 | (decode_mode_spec): Remove parameter `precision', introduced during |
| 6101 | Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used. |
| 6102 | All callers changed. |
| 6103 | |
| 6104 | 2011-03-27 Jan Djärv <jan.h.d@swipnet.se> |
| 6105 | |
| 6106 | * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar. |
| 6107 | |
| 6108 | 2011-03-27 Anders Lindgren <andlind@gmail.com> |
| 6109 | |
| 6110 | * nsterm.m (ns_menu_bar_is_hidden): New variable. |
| 6111 | (ns_constrain_all_frames, ns_menu_bar_should_be_hidden) |
| 6112 | (ns_update_auto_hide_menu_bar): New functions. |
| 6113 | (ns_update_begin): Call ns_update_auto_hide_menu_bar. |
| 6114 | (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and |
| 6115 | ns_constrain_all_frames. |
| 6116 | (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden. |
| 6117 | (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil. |
| 6118 | |
| 6119 | 2011-03-27 Jan Djärv <jan.h.d@swipnet.se> |
| 6120 | |
| 6121 | * nsmenu.m (runDialogAt): Remove argument to timer_check. |
| 6122 | |
| 6123 | 2011-03-27 Glenn Morris <rgm@gnu.org> |
| 6124 | |
| 6125 | * syssignal.h: Replace RETSIGTYPE with void. |
| 6126 | * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c: |
| 6127 | * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c: |
| 6128 | Replace SIGTYPE with void everywhere. |
| 6129 | * s/usg5-4-common.h (SIGTYPE): Remove definition. |
| 6130 | * s/template.h (SIGTYPE): Remove commented out definition. |
| 6131 | |
| 6132 | 2011-03-26 Eli Zaretskii <eliz@gnu.org> |
| 6133 | |
| 6134 | * xdisp.c (redisplay_window): Don't check buffer's clip_changed |
| 6135 | flag as a prerequisite for invoking try_scrolling. (Bug#6671) |
| 6136 | |
| 6137 | 2011-03-26 Juanma Barranquero <lekktu@gmail.com> |
| 6138 | |
| 6139 | * w32.c (read_unc_volume): Use parameter `henum', instead of |
| 6140 | global variable `wget_enum_handle'. |
| 6141 | |
| 6142 | * keymap.c (describe_vector): Remove parameters `indices' and |
| 6143 | `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org. |
| 6144 | (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'. |
| 6145 | |
| 6146 | * keyboard.h (timer_check, show_help_echo): Remove unused parameters. |
| 6147 | |
| 6148 | * keyboard.c (timer_check): Remove parameter `do_it_now', |
| 6149 | unused since 1996-04-12T06:01:29Z!rms@gnu.org. |
| 6150 | (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo', |
| 6151 | unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca. |
| 6152 | |
| 6153 | * keyboard.c (read_char): |
| 6154 | * w32menu.c (w32_menu_display_help): |
| 6155 | * xmenu.c (show_help_event, menu_help_callback): |
| 6156 | Adjust calls to `show_help_echo'. |
| 6157 | |
| 6158 | * gtkutil.c (xg_maybe_add_timer): |
| 6159 | * keyboard.c (readable_events): |
| 6160 | * process.c (wait_reading_process_output): |
| 6161 | * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'. |
| 6162 | |
| 6163 | * insdel.c (adjust_markers_gap_motion): |
| 6164 | Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org. |
| 6165 | (gap_left, gap_right): Don't call it. |
| 6166 | |
| 6167 | 2011-03-25 Chong Yidong <cyd@stupidchicken.com> |
| 6168 | |
| 6169 | * xdisp.c (handle_fontified_prop): Discard changes to clip_changed |
| 6170 | incurred during fontification. |
| 6171 | |
| 6172 | 2011-03-25 Juanma Barranquero <lekktu@gmail.com> |
| 6173 | |
| 6174 | * buffer.c (defvar_per_buffer): Remove unused parameter `doc'. |
| 6175 | (DEFVAR_PER_BUFFER): Don't pass it. |
| 6176 | |
| 6177 | * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'. |
| 6178 | (scrolling_window): Don't pass it. |
| 6179 | |
| 6180 | 2011-03-25 Juanma Barranquero <lekktu@gmail.com> |
| 6181 | |
| 6182 | * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef. |
| 6183 | |
| 6184 | * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len' |
| 6185 | and `suffix'. |
| 6186 | (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration |
| 6187 | of variables specific to SELinux and computation of `encoded_absname'. |
| 6188 | |
| 6189 | * image.c (XPutPixel): Remove unused variable `height'. |
| 6190 | |
| 6191 | * keyboard.c (make_lispy_event): Remove unused variable `hpos'. |
| 6192 | |
| 6193 | * unexw32.c (get_section_info): Remove unused variable `section'. |
| 6194 | |
| 6195 | * w32.c (stat): Remove unused variables `drive_root' and `devtype'. |
| 6196 | (system_process_attributes): Remove unused variable `sess'. |
| 6197 | (sys_read): Remove unused variable `err'. |
| 6198 | |
| 6199 | * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef. |
| 6200 | (w32_wnd_proc): Remove unused variable `isdead'. |
| 6201 | (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef. |
| 6202 | (Fx_server_max_request_size): Remove unused variable `dpyinfo'. |
| 6203 | (x_create_tip_frame): Remove unused variable `tem'. |
| 6204 | |
| 6205 | * w32inevt.c (w32_console_read_socket): |
| 6206 | Remove unused variable `no_events'. |
| 6207 | |
| 6208 | * w32term.c (x_draw_composite_glyph_string_foreground): |
| 6209 | Remove unused variable `width'. |
| 6210 | |
| 6211 | 2011-03-24 Juanma Barranquero <lekktu@gmail.com> |
| 6212 | |
| 6213 | * w32term.c (x_set_glyph_string_clipping): |
| 6214 | Don't pass uninitialized region to CombineRgn. |
| 6215 | |
| 6216 | 2011-03-23 Juanma Barranquero <lekktu@gmail.com> |
| 6217 | |
| 6218 | * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'. |
| 6219 | (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer. |
| 6220 | (Fx_close_connection): Remove unused variable `i'. |
| 6221 | |
| 6222 | * w32font.c (w32font_draw): Return number of glyphs. |
| 6223 | (w32font_open_internal): Remove unused variable `i'. |
| 6224 | (w32font_driver): Add missing initializer. |
| 6225 | |
| 6226 | * w32menu.c (utf8to16): Remove unused variable `utf16'. |
| 6227 | (fill_in_menu): Remove unused variable `items_added'. |
| 6228 | |
| 6229 | * w32term.c (last_mouse_press_frame): Remove static global variable. |
| 6230 | (w32_clip_to_row): Remove unused variable `f'. |
| 6231 | (x_delete_terminal): Remove unused variable `i'. |
| 6232 | |
| 6233 | * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'. |
| 6234 | (NOTHING): Remove unused static global variable. |
| 6235 | (uniscribe_check_otf): Remove unused variable `table'. |
| 6236 | (uniscribe_font_driver): Add missing initializers. |
| 6237 | |
| 6238 | 2011-03-23 Julien Danjou <julien@danjou.info> |
| 6239 | |
| 6240 | * term.c (Fsuspend_tty, Fresume_tty): |
| 6241 | * minibuf.c (read_minibuf, run_exit_minibuf_hook): |
| 6242 | * window.c (temp_output_buffer_show): |
| 6243 | * insdel.c (signal_before_change): |
| 6244 | * frame.c (Fhandle_switch_frame): |
| 6245 | * fileio.c (Fdo_auto_save): |
| 6246 | * emacs.c (Fkill_emacs): |
| 6247 | * editfns.c (save_excursion_restore): |
| 6248 | * cmds.c (internal_self_insert): |
| 6249 | * callint.c (Fcall_interactively): |
| 6250 | * buffer.c (Fkill_all_local_variables): |
| 6251 | * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1): |
| 6252 | Use Frun_hooks. |
| 6253 | (command_loop_1): Use Frun_hooks. Call safe_run_hooks |
| 6254 | unconditionnaly since it does the check itself. |
| 6255 | |
| 6256 | 2011-03-23 Paul Eggert <eggert@cs.ucla.edu> |
| 6257 | |
| 6258 | Fix more problems found by GCC 4.5.2's static checks. |
| 6259 | |
| 6260 | * coding.c (encode_coding_raw_text): Avoid unnecessary test |
| 6261 | the first time through the loop, since we know p0 < p1 then. |
| 6262 | This also avoids a gcc -Wstrict-overflow warning. |
| 6263 | |
| 6264 | * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow |
| 6265 | leading to a memory leak, possible in functions like |
| 6266 | load_charset_map_from_file that can allocate an unbounded number |
| 6267 | of objects (Bug#8318). |
| 6268 | |
| 6269 | * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes |
| 6270 | that could (at least in theory) be that large. |
| 6271 | |
| 6272 | * xdisp.c (message_log_check_duplicate): Return unsigned long, not int. |
| 6273 | This is less likely to overflow, and avoids undefined behavior if |
| 6274 | overflow does occur. All callers changed. Use strtoul to scan |
| 6275 | for the unsigned long integer. |
| 6276 | (pint2hrstr): Simplify and tune code slightly. |
| 6277 | This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow. |
| 6278 | |
| 6279 | * scroll.c (do_scrolling): Work around GCC bug 48228. |
| 6280 | See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>. |
| 6281 | |
| 6282 | * frame.c (Fmodify_frame_parameters): Simplify loop counter. |
| 6283 | This also avoids a warning with gcc -Wstrict-overflow. |
| 6284 | (validate_x_resource_name): Simplify count usage. |
| 6285 | This also avoids a warning with gcc -Wstrict-overflow. |
| 6286 | |
| 6287 | * fileio.c (Fcopy_file): Report error if fchown or fchmod |
| 6288 | fail (Bug#8306). |
| 6289 | |
| 6290 | * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303). |
| 6291 | |
| 6292 | * process.c (Fmake_network_process): Use socklen_t, not int, |
| 6293 | where POSIX says socklen_t is required in portable programs. |
| 6294 | This fixes a porting bug on hosts like 64-bit HP-UX, where |
| 6295 | socklen_t is wider than int (Bug#8277). |
| 6296 | (Fmake_network_process, server_accept_connection): |
| 6297 | (wait_reading_process_output, read_process_output): |
| 6298 | Likewise. |
| 6299 | |
| 6300 | * process.c: Rename or move locals to avoid shadowing. |
| 6301 | (list_processes_1, Fmake_network_process): |
| 6302 | (read_process_output_error_handler, exec_sentinel_error_handler): |
| 6303 | Rename or move locals. |
| 6304 | (Fmake_network_process): Define label "retry_connect" only if needed. |
| 6305 | (Fnetwork_interface_info): Fix pointer signedness. |
| 6306 | (process_send_signal): Add cast to avoid pointer signedness problem. |
| 6307 | (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros. |
| 6308 | (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298). |
| 6309 | |
| 6310 | Make tparam.h and terminfo.c consistent. |
| 6311 | * cm.c (tputs, tgoto, BC, UP): Remove extern decls. |
| 6312 | Include tparam.h instead, since it declares them. |
| 6313 | * cm.h (PC): Remove extern decl; tparam.h now does this. |
| 6314 | * deps.mk (cm.o, terminfo.o): Depend on tparam.h. |
| 6315 | * terminfo.c: Include tparam.h, to check interfaces. |
| 6316 | (tparm): Make 1st arg a const pointer in decl. Put it at top level. |
| 6317 | (tparam): Adjust signature to match interface in tparam.h; |
| 6318 | this removes some undefined behavior. Check that outstring and len |
| 6319 | are zero, which they always are with Emacs. |
| 6320 | * tparam.h (PC, BC, UP): New extern decls. |
| 6321 | |
| 6322 | * xftfont.c (xftfont_shape): Now static, and defined only if needed. |
| 6323 | (xftfont_open): Rename locals to avoid shadowing. |
| 6324 | |
| 6325 | * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness. |
| 6326 | (ftfont_otf_capability, ftfont_shape): Omit decls if not needed. |
| 6327 | (OTF_TAG_SYM): Omit macro if not needed. |
| 6328 | (ftfont_list): Remove unused local. |
| 6329 | (get_adstyle_property, ftfont_pattern_entity): |
| 6330 | (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point): |
| 6331 | Rename locals to avoid shadowing. |
| 6332 | |
| 6333 | * xfont.c (xfont_list_family): Mark var as initialized. |
| 6334 | |
| 6335 | * xml.c (make_dom): Now static. |
| 6336 | |
| 6337 | * composite.c (composition_compute_stop_pos): Rename local to |
| 6338 | avoid shadowing. |
| 6339 | (composition_reseat_it): Remove unused locals. |
| 6340 | (find_automatic_composition, composition_adjust_point): Likewise. |
| 6341 | (composition_update_it): Mark var as initialized. |
| 6342 | (find_automatic_composition): Mark vars as initialized, |
| 6343 | with a FIXME (Bug#8290). |
| 6344 | |
| 6345 | character.h: Rename locals to avoid shadowing. |
| 6346 | * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE): |
| 6347 | (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE): |
| 6348 | (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS): |
| 6349 | (BUF_DEC_POS): Be more systematic about renaming local temporaries |
| 6350 | to avoid shadowing. |
| 6351 | |
| 6352 | * textprop.c (property_change_between_p): Remove; unused. |
| 6353 | |
| 6354 | * intervals.c (interval_start_pos): Now static. |
| 6355 | |
| 6356 | * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else". |
| 6357 | |
| 6358 | * atimer.c (start_atimer, append_atimer_lists, set_alarm): |
| 6359 | Rename locals to avoid shadowing. |
| 6360 | |
| 6361 | * sound.c (wav_play, au_play, Fplay_sound_internal): |
| 6362 | Fix pointer signedness. |
| 6363 | (alsa_choose_format): Remove unused local var. |
| 6364 | (wav_play): Initialize a variable to 0, to prevent undefined |
| 6365 | behavior (Bug#8278). |
| 6366 | |
| 6367 | * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing. |
| 6368 | |
| 6369 | * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes. |
| 6370 | |
| 6371 | * callproc.c (Fcall_process): Use 'volatile' to avoid vfork |
| 6372 | clobbering (Bug#8298). |
| 6373 | * sysdep.c (sys_subshell): Likewise. |
| 6374 | Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out. |
| 6375 | |
| 6376 | * lisp.h (child_setup): Now NO_RETURN unless DOS_NT. |
| 6377 | This should get cleaned up, so that child_setup has the |
| 6378 | same signature on all platforms. |
| 6379 | |
| 6380 | * callproc.c (call_process_cleanup): Now static. |
| 6381 | (relocate_fd): Rename locals to avoid shadowing. |
| 6382 | |
| 6383 | 2011-03-22 Chong Yidong <cyd@stupidchicken.com> |
| 6384 | |
| 6385 | * xterm.c (x_clear_frame): Remove XClearWindow call. This appears |
| 6386 | not to be necessary, and produces flickering. |
| 6387 | |
| 6388 | 2011-03-20 Glenn Morris <rgm@gnu.org> |
| 6389 | |
| 6390 | * config.in: Remove file. |
| 6391 | |
| 6392 | 2011-03-20 Juanma Barranquero <lekktu@gmail.com> |
| 6393 | |
| 6394 | * minibuf.c (Vcompleting_read_function): Don't declare, global variables |
| 6395 | are now in src/globals.h. |
| 6396 | (syms_of_minibuf): Remove spurious & from previous change. |
| 6397 | |
| 6398 | 2011-03-20 Leo <sdl.web@gmail.com> |
| 6399 | |
| 6400 | * minibuf.c (completing-read-function): New variable. |
| 6401 | (completing-read-default): Rename from completing-read. |
| 6402 | (completing-read): Call completing-read-function. |
| 6403 | |
| 6404 | 2011-03-19 Juanma Barranquero <lekktu@gmail.com> |
| 6405 | |
| 6406 | * xfaces.c (Fx_load_color_file): |
| 6407 | Read color file from absolute filename (bug#8250). |
| 6408 | |
| 6409 | 2011-03-19 Juanma Barranquero <lekktu@gmail.com> |
| 6410 | |
| 6411 | * makefile.w32-in: Update dependencies. |
| 6412 | |
| 6413 | 2011-03-17 Eli Zaretskii <eliz@gnu.org> |
| 6414 | |
| 6415 | * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h. |
| 6416 | |
| 6417 | 2011-03-17 Paul Eggert <eggert@cs.ucla.edu> |
| 6418 | |
| 6419 | Fix more problems found by GCC 4.5.2's static checks. |
| 6420 | |
| 6421 | * process.c (make_serial_process_unwind, send_process_trap): |
| 6422 | (sigchld_handler): Now static. |
| 6423 | |
| 6424 | * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars. |
| 6425 | That way, the code declares only the vars that it needs. |
| 6426 | * s/aix4-2.h (PTY_ITERATION): Declare iteration vars. |
| 6427 | * s/cygwin.h (PTY_ITERATION): Likewise. |
| 6428 | * s/darwin.h (PTY_ITERATION): Likewise. |
| 6429 | * s/gnu-linux.h (PTY_ITERATION): Likewise. |
| 6430 | |
| 6431 | * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling. |
| 6432 | * process.c (allocate_pty): Don't declare stb unless it's needed. |
| 6433 | |
| 6434 | * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else". |
| 6435 | (CONSTANTLIM): Remove; unused. |
| 6436 | (METER_CODE, Bscan_buffer, Bread_char, Bset_mark): |
| 6437 | Define only if needed. |
| 6438 | |
| 6439 | * unexelf.c (unexec): Name an expression, |
| 6440 | to avoid gcc -Wbad-function-cast warning. |
| 6441 | Use a different way to cause a compilation error if anyone uses |
| 6442 | n rather than nn, a way that does not involve shadowing. |
| 6443 | (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused. |
| 6444 | |
| 6445 | * deps.mk (unexalpha.o): Remove; unused. |
| 6446 | |
| 6447 | New file unexec.h, the (simple) interface for unexec (Bug#8267). |
| 6448 | * unexec.h: New file. |
| 6449 | * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o): |
| 6450 | (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o): |
| 6451 | Depend on unexec.h. |
| 6452 | * emacs.c [!defined CANNOT_DUMP]: Include unexec.h. |
| 6453 | * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c: |
| 6454 | * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h. |
| 6455 | Change as necessary to match prototype in unexec.h. |
| 6456 | |
| 6457 | * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid |
| 6458 | shadowing. |
| 6459 | (back_comment, skip_chars): Mark vars as initialized. |
| 6460 | |
| 6461 | * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS): |
| 6462 | Rename locals to avoid shadowing. |
| 6463 | |
| 6464 | * lread.c (read1): Rewrite so as not to use empty "else". |
| 6465 | (Fload, readevalloop, read1): Rename locals to avoid shadowing. |
| 6466 | |
| 6467 | * print.c (Fredirect_debugging_output): Fix pointer signedess. |
| 6468 | |
| 6469 | * lisp.h (debug_output_compilation_hack): Add decl here, to avoid |
| 6470 | warning when compiling print.c. |
| 6471 | |
| 6472 | * font.c (font_unparse_fcname): Abort in an "impossible" situation |
| 6473 | instead of using an uninitialized var. |
| 6474 | (font_sort_entities): Mark var as initialized. |
| 6475 | |
| 6476 | * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing. |
| 6477 | |
| 6478 | * font.c (font_unparse_xlfd): Don't mix pointers to variables with |
| 6479 | pointers to constants. |
| 6480 | (font_parse_fcname): Remove unused vars. |
| 6481 | (font_delete_unmatched): Now static. |
| 6482 | (font_get_spec): Remove; unused. |
| 6483 | (font_style_to_value, font_prop_validate_style, font_unparse_fcname): |
| 6484 | (font_update_drivers, Ffont_get_glyphs, font_add_log): |
| 6485 | Rename or move locals to avoid shadowing. |
| 6486 | |
| 6487 | * fns.c (require_nesting_list, require_unwind): Now static. |
| 6488 | (Ffillarray): Rename locals to avoid shadowing. |
| 6489 | |
| 6490 | * floatfns.c (domain_error2): Define only if needed. |
| 6491 | (Ffrexp, Fldexp): Rename locals to avoid shadowing. |
| 6492 | |
| 6493 | * alloc.c (mark_backtrace): Move decl from here ... |
| 6494 | * lisp.h: ... to here, so that it can be checked. |
| 6495 | |
| 6496 | * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static. |
| 6497 | (Fdefvar): Rewrite so as not to use empty "else". |
| 6498 | (lisp_indirect_variable): Name an expression, |
| 6499 | to avoid gcc -Wbad-function-cast warning. |
| 6500 | (Fdefvar): Rename locals to avoid shadowing. |
| 6501 | |
| 6502 | * callint.c (quotify_arg, quotify_args): Now static. |
| 6503 | (Fcall_interactively): Rename locals to avoid shadowing. |
| 6504 | Use const pointer when appropriate. |
| 6505 | |
| 6506 | * lisp.h (get_system_name, get_operating_system_release): |
| 6507 | Move decls here, to check interfaces. |
| 6508 | * process.c (get_operating_system_release): Move decl to lisp.h. |
| 6509 | * xrdb.c (get_system_name): Likewise. |
| 6510 | * editfns.c (init_editfns, Fuser_login_name, Fuser_uid): |
| 6511 | (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts, |
| 6512 | some of which prompt warnings from gcc -Wbad-function-cast. |
| 6513 | (Fformat_time_string, Fencode_time, Finsert_char): |
| 6514 | (Ftranslate_region_internal, Fformat): |
| 6515 | Rename or remove local vars to avoid shadowing. |
| 6516 | (Ftranslate_region_internal): Mark var as initialized. |
| 6517 | |
| 6518 | * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to |
| 6519 | avoid shadowing. |
| 6520 | |
| 6521 | * lisp.h (eassert): Check that the argument compiles, even if |
| 6522 | ENABLE_CHECKING is not defined. |
| 6523 | |
| 6524 | * data.c (Findirect_variable): Name an expression, to avoid |
| 6525 | gcc -Wbad-function-cast warning. |
| 6526 | (default_value, arithcompare, arith_driver, arith_error): Now static. |
| 6527 | (store_symval_forwarding): Rename local to avoid shadowing. |
| 6528 | (Fmake_variable_buffer_local, Fmake_local_variable): |
| 6529 | Mark variables as initialized. |
| 6530 | (do_blv_forwarding, do_symval_forwarding): Remove; unused. |
| 6531 | |
| 6532 | * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST. |
| 6533 | (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect): |
| 6534 | Rename locals to avoid shadowing. |
| 6535 | (mark_stack): Move local variables into the #ifdef region where |
| 6536 | they're used. |
| 6537 | (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if |
| 6538 | ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not |
| 6539 | needed otherwise. |
| 6540 | (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS. |
| 6541 | (GC_STRING_CHARS): Remove; not used. |
| 6542 | (Fmemory_limit): Cast sbrk's returned value to char *. |
| 6543 | |
| 6544 | * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this |
| 6545 | avoids undefined behavior in theory. |
| 6546 | |
| 6547 | * regex.c (IF_LINT): Add defn, for benefit of ../lib-src. |
| 6548 | |
| 6549 | Use functions, not macros, for up- and down-casing (Bug#8254). |
| 6550 | * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP): |
| 6551 | (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed |
| 6552 | to use the following functions instead of these macros. |
| 6553 | (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not |
| 6554 | EMACS_INT, since callers assume the returned value fits in int. |
| 6555 | (upcase1): Likewise, for UPCASE_TABLE. |
| 6556 | (uppercasep, lowercasep, upcase): New static inline functions. |
| 6557 | * editfns.c (Fchar_equal): Remove no-longer-needed workaround for |
| 6558 | the race-condition problem in the old DOWNCASE. |
| 6559 | |
| 6560 | * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT): |
| 6561 | Rename locals to avoid shadowing. |
| 6562 | (regex_compile, re_match_2_internal): Move locals to avoid shadowing. |
| 6563 | (regex_compile, re_search_2, re_match_2_internal): |
| 6564 | Remove unused local vars. |
| 6565 | (FREE_VAR): Rewrite so as not to use empty "else", |
| 6566 | which gcc can warn about. |
| 6567 | (regex_compile, re_match_2_internal): Mark locals as initialized. |
| 6568 | (RETALLOC_IF): Define only if needed. |
| 6569 | (WORDCHAR_P): Likewise. This one is never needed, but is used |
| 6570 | only in a comment talking about a compiler bug, so put inside |
| 6571 | the #if 0 of that comment. |
| 6572 | (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK): |
| 6573 | (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING): |
| 6574 | Remove; unused. |
| 6575 | |
| 6576 | * search.c (boyer_moore): Rename locals to avoid shadowing. |
| 6577 | * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE): |
| 6578 | (PREV_CHAR_BOUNDARY): Likewise. |
| 6579 | |
| 6580 | * search.c (simple_search): Remove unused var. |
| 6581 | |
| 6582 | * dired.c (compile_pattern): Move decl from here ... |
| 6583 | * lisp.h: ... to here, so that it can be checked. |
| 6584 | (struct re_registers): New forward decl. |
| 6585 | |
| 6586 | * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing. |
| 6587 | |
| 6588 | * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width. |
| 6589 | All uses changed. |
| 6590 | (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion): |
| 6591 | Rename locals to avoid shadowing. |
| 6592 | (Fvertical_motion): Mark locals as initialized. |
| 6593 | |
| 6594 | * casefiddle.c (casify_object, casify_region): Now static. |
| 6595 | (casify_region): Mark local as initialized. |
| 6596 | |
| 6597 | * cmds.c (internal_self_insert): Rename local to avoid shadowing. |
| 6598 | |
| 6599 | * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR): |
| 6600 | New macros, so that the caller can use some names other than |
| 6601 | gcpro1, gcpro2, etc. |
| 6602 | (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms |
| 6603 | of the new macros. |
| 6604 | (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second |
| 6605 | argument, for consistency with GCPRO2_VAR, etc: it is now the |
| 6606 | prefix of the variable, not the variable itself. All uses |
| 6607 | changed. |
| 6608 | * dired.c (directory_files_internal, file_name_completion): |
| 6609 | Rename locals to avoid shadowing. |
| 6610 | |
| 6611 | Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254). |
| 6612 | An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in |
| 6613 | dired.c's scmp function, had undefined behavior. |
| 6614 | * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP): |
| 6615 | (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ... |
| 6616 | * buffer.h: ... to here, because these macros use current_buffer, |
| 6617 | and the new implementation with inline functions needs to have |
| 6618 | current_buffer in scope now, rather than later when the macros |
| 6619 | are used. |
| 6620 | (downcase, upcase1): New static inline functions. |
| 6621 | (DOWNCASE, UPCASE1): Reimplement using these functions. |
| 6622 | This avoids undefined behavior in expressions like |
| 6623 | DOWNCASE (x) == DOWNCASE (y), which previously suffered |
| 6624 | from race conditions in accessing the global variables |
| 6625 | case_temp1 and case_temp2. |
| 6626 | * casetab.c (case_temp1, case_temp2): Remove; no longer needed. |
| 6627 | * lisp.h (case_temp1, case_temp2): Remove their decls. |
| 6628 | * character.h (ASCII_CHAR_P): Move from here ... |
| 6629 | * lisp.h: ... to here, so that the inline functions mentioned |
| 6630 | above can use them. |
| 6631 | |
| 6632 | * dired.c (directory_files_internal_unwind): Now static. |
| 6633 | |
| 6634 | * fileio.c (file_name_as_directory, directory_file_name): |
| 6635 | (barf_or_query_if_file_exists, auto_save_error, auto_save_1): |
| 6636 | Now static. |
| 6637 | (file_name_as_directory): Use const pointers when appropriate. |
| 6638 | (Fexpand_file_name): Likewise. In particular, newdir might |
| 6639 | point at constant storage, so make it a const pointer. |
| 6640 | (Fmake_directory_internal, Fread_file_name): Remove unused vars. |
| 6641 | (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer |
| 6642 | signedness issues. |
| 6643 | (Fset_file_times, Finsert_file_contents, auto_save_error): |
| 6644 | Rename locals to avoid shadowing. |
| 6645 | |
| 6646 | * minibuf.c (choose_minibuf_frame_1): Now static. |
| 6647 | (Ftry_completion, Fall_completions): Rename or remove locals |
| 6648 | to avoid shadowing. |
| 6649 | |
| 6650 | * marker.c (bytepos_to_charpos): Remove; unused. |
| 6651 | |
| 6652 | * lisp.h (verify_bytepos, count_markers): New decls, |
| 6653 | so that gcc does not warn that these functions aren't declared. |
| 6654 | |
| 6655 | * insdel.c (check_markers, make_gap_larger, make_gap_smaller): |
| 6656 | (reset_var_on_error, Fcombine_after_change_execute_1): Now static. |
| 6657 | (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic. |
| 6658 | (copy_text): Remove unused local var. |
| 6659 | |
| 6660 | * filelock.c (within_one_second): Now static. |
| 6661 | (lock_file_1): Rename local to avoid shadowing. |
| 6662 | |
| 6663 | * buffer.c (fix_overlays_before): Mark locals as initialized. |
| 6664 | (fix_start_end_in_overlays): Likewise. This function should be |
| 6665 | simplified by using pointers-to-pointers, but that's a different |
| 6666 | matter. |
| 6667 | (switch_to_buffer_1): Now static. |
| 6668 | (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte): |
| 6669 | (report_overlay_modification): Rename locals to avoid shadowing. |
| 6670 | |
| 6671 | * sysdep.c (system_process_attributes): Rename vars to avoid shadowing. |
| 6672 | Fix pointer signedness issue. |
| 6673 | (sys_subshell): Mark local as volatile if checking for lint, |
| 6674 | to suppress a gcc -Wclobbered warning that does not seem to be right. |
| 6675 | (MAXPATHLEN): Define only if needed. |
| 6676 | |
| 6677 | * process.c (serial_open, serial_configure): Move decls from here ... |
| 6678 | * systty.h: ... to here, so that they can be checked. |
| 6679 | |
| 6680 | * fns.c (get_random, seed_random): Move extern decls from here ... |
| 6681 | * lisp.h: ... to here, so that they can be checked. |
| 6682 | |
| 6683 | * sysdep.c (reset_io): Now static. |
| 6684 | (wait_for_termination_signal): Remove; unused. |
| 6685 | |
| 6686 | * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal): |
| 6687 | (copy_keymap_item, append_key, push_text_char_description): |
| 6688 | Now static. |
| 6689 | (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily. |
| 6690 | (DENSE_TABLE_SIZE): Remove; unused. |
| 6691 | (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal): |
| 6692 | (describe_map_tree): |
| 6693 | Rename locals to avoid shadowing. |
| 6694 | |
| 6695 | * keyboard.c: Declare functions static if they are not used elsewhere. |
| 6696 | (echo_char, echo_dash, cmd_error, top_level_2): |
| 6697 | (poll_for_input, handle_async_input): Now static. |
| 6698 | (read_char, kbd_buffer_get_event, make_lispy_position): |
| 6699 | (make_lispy_event, make_lispy_movement, apply_modifiers): |
| 6700 | (decode_keyboard_code, tty_read_avail_input, menu_bar_items): |
| 6701 | (parse_tool_bar_item, read_key_sequence, Fread_key_sequence): |
| 6702 | (Fread_key_sequence_vector): Rename locals to avoid shadowing. |
| 6703 | (read_key_sequence, read_char): Mark locals as initialized. |
| 6704 | (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN. |
| 6705 | |
| 6706 | * keyboard.h (make_ctrl_char): New decl. |
| 6707 | (mark_kboards): Move decl here ... |
| 6708 | * alloc.c (mark_kboards): ... from here. |
| 6709 | |
| 6710 | * lisp.h (force_auto_save_soon): New decl. |
| 6711 | |
| 6712 | * emacs.c (init_cmdargs): Rename local to avoid shadowing. |
| 6713 | (DEFINE_DUMMY_FUNCTION): New macro. |
| 6714 | (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main): |
| 6715 | Use it. |
| 6716 | (main): Add casts to avoid warnings |
| 6717 | if GCC considers string literals to be constants. |
| 6718 | |
| 6719 | * lisp.h (fatal_error_signal): Add decl, since it's exported. |
| 6720 | |
| 6721 | * dbusbind.c: Pointer signedness fixes. |
| 6722 | (xd_signature, xd_append_arg, xd_initialize): |
| 6723 | (Fdbus_call_method, Fdbus_call_method_asynchronously): |
| 6724 | (Fdbus_method_return_internal, Fdbus_method_error_internal): |
| 6725 | (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service): |
| 6726 | (Fdbus_register_signal): Use SSDATA when the context wants char *. |
| 6727 | |
| 6728 | * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning |
| 6729 | if GCC considers string literals to be constants. |
| 6730 | (Fdbus_register_service, Fdbus_register_method): Remove unused vars. |
| 6731 | |
| 6732 | 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca> |
| 6733 | |
| 6734 | * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro. |
| 6735 | (print_preprocess, print_object): New macro to fix last change. |
| 6736 | |
| 6737 | * print.c (print_preprocess): Don't forget font objects. |
| 6738 | |
| 6739 | 2011-03-16 Juanma Barranquero <lekktu@gmail.com> |
| 6740 | |
| 6741 | * emacs.c (USAGE3): Doc fixes. |
| 6742 | |
| 6743 | 2011-03-15 Andreas Schwab <schwab@linux-m68k.org> |
| 6744 | |
| 6745 | * coding.c (detect_coding_iso_2022): Reorganize code to clarify |
| 6746 | structure. |
| 6747 | |
| 6748 | 2011-03-14 Juanma Barranquero <lekktu@gmail.com> |
| 6749 | |
| 6750 | * lisp.h (VWindow_system, Qfile_name_history): |
| 6751 | * keyboard.h (lispy_function_keys) [WINDOWSNT]: |
| 6752 | * w32term.h (w32_system_caret_hwnd, w32_system_caret_height) |
| 6753 | (w32_system_caret_x, w32_system_caret_y): Declare extern. |
| 6754 | |
| 6755 | * w32select.c: Don't #include "keyboard.h". |
| 6756 | (run_protected): Add extern declaration for waiting_for_input. |
| 6757 | |
| 6758 | * w32.c (Qlocal, noninteractive1, inhibit_window_system): |
| 6759 | * w32console.c (detect_input_pending, read_input_pending) |
| 6760 | (encode_terminal_code): |
| 6761 | * w32fns.c (quit_char, lispy_function_keys, Qtooltip) |
| 6762 | (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x) |
| 6763 | (w32_system_caret_y, Qfile_name_history): |
| 6764 | * w32font.c (w32font_driver, QCantialias, QCotf, QClang): |
| 6765 | * w32inevt.c (reinvoke_input_signal, lispy_function_keys): |
| 6766 | * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map) |
| 6767 | (Qoverriding_terminal_local_map, Qmenu_bar_update_hook): |
| 6768 | * w32proc.c (Qlocal, report_file_error): |
| 6769 | * w32term.c (Vwindow_system, updating_frame): |
| 6770 | * w32uniscribe.c (initialized, uniscribe_font_driver): |
| 6771 | Remove unneeded extern declarations. |
| 6772 | |
| 6773 | 2011-03-14 Chong Yidong <cyd@stupidchicken.com> |
| 6774 | |
| 6775 | * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions. |
| 6776 | |
| 6777 | 2011-03-13 Chong Yidong <cyd@stupidchicken.com> |
| 6778 | |
| 6779 | * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT) |
| 6780 | (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219). |
| 6781 | These macros can no longer be used for assignment. |
| 6782 | |
| 6783 | * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): |
| 6784 | Assign struct members directly, instead of using BUF_BEGV etc. |
| 6785 | (record_buffer_markers, fetch_buffer_markers): New functions for |
| 6786 | recording and fetching special buffer markers. |
| 6787 | (set_buffer_internal_1, set_buffer_temp): Use them. |
| 6788 | |
| 6789 | * lread.c (unreadchar): Use SET_BUF_PT_BOTH. |
| 6790 | |
| 6791 | * insdel.c (adjust_point): Use SET_BUF_PT_BOTH. |
| 6792 | |
| 6793 | * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH. |
| 6794 | (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH. |
| 6795 | |
| 6796 | * xdisp.c (hscroll_window_tree): |
| 6797 | (reconsider_clip_changes): Use PT instead of BUF_PT. |
| 6798 | |
| 6799 | 2011-03-13 Eli Zaretskii <eliz@gnu.org> |
| 6800 | |
| 6801 | * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on |
| 6802 | $(EMACS_ROOT)/lib/intprops.h. |
| 6803 | |
| 6804 | 2011-03-13 Paul Eggert <eggert@cs.ucla.edu> |
| 6805 | |
| 6806 | Fix more problems found by GCC 4.5.2's static checks. |
| 6807 | |
| 6808 | * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char * |
| 6809 | to unsigned char * to avoid compiler diagnostic. |
| 6810 | (xg_free_frame_widgets): Make it clear that a local variable is |
| 6811 | needed only if USE_GTK_TOOLTIP. |
| 6812 | (gdk_window_get_screen): Make it clear that this macro is needed |
| 6813 | only if USE_GTK_TOOLTIP. |
| 6814 | (int_gtk_range_get_value): New function, which avoids a diagnostic |
| 6815 | from gcc -Wbad-function-cast. |
| 6816 | (xg_set_toolkit_scroll_bar_thumb): Use it. |
| 6817 | (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid |
| 6818 | diagnostic from gcc -Wbad-function-cast. |
| 6819 | (get_utf8_string, xg_get_file_with_chooser): |
| 6820 | Rename locals to avoid shadowing. |
| 6821 | (create_dialog): Move locals to avoid shadowing. |
| 6822 | |
| 6823 | * xgselect.c (xg_select): Remove unused var. |
| 6824 | |
| 6825 | * image.c (four_corners_best): Mark locals as initialized. |
| 6826 | (gif_load): Initialize transparent_p to zero (Bug#8238). |
| 6827 | Mark another local as initialized. |
| 6828 | (my_png_error, my_error_exit): Mark with NO_RETURN. |
| 6829 | |
| 6830 | * image.c (clear_image_cache): Now static. |
| 6831 | (DIM, HAVE_STDLIB_H_1): Remove unused macros. |
| 6832 | (xpm_load): Redo to avoid "discards qualifiers" gcc warning. |
| 6833 | (x_edge_detection): Remove unnecessary cast that |
| 6834 | gcc -Wbad-function-cast diagnoses. |
| 6835 | (gif_load): Fix pointer signedness. |
| 6836 | (clear_image_cache, xbm_read_bitmap_data, x_detect_edges): |
| 6837 | (jpeg_load, gif_load): Rename locals to avoid shadowing. |
| 6838 | |
| 6839 | 2011-03-12 Paul Eggert <eggert@cs.ucla.edu> |
| 6840 | |
| 6841 | Improve quality of tests for time stamp overflow. |
| 6842 | For example, without this patch (encode-time 0 0 0 1 1 |
| 6843 | 1152921504606846976) returns the obviously-bogus value (-948597 |
| 6844 | 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly |
| 6845 | reports time overflow. See |
| 6846 | <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>. |
| 6847 | * deps.mk (editfns.o): Depend on ../lib/intprops.h. |
| 6848 | * editfns.c: Include limits.h and intprops.h. |
| 6849 | (TIME_T_MIN, TIME_T_MAX): New macros. |
| 6850 | (time_overflow): Move earlier, to before first use. |
| 6851 | (hi_time, lo_time): New functions, for an accurate test for |
| 6852 | out-of-range times. |
| 6853 | (Fcurrent_time, Fget_internal_run_time, make_time): Use them. |
| 6854 | (Fget_internal_run_time): Don't assume time_t fits in int. |
| 6855 | (make_time): Use list2 instead of Fcons twice. |
| 6856 | (Fdecode_time): More accurate test for out-of-range times. |
| 6857 | (check_tm_member): New function. |
| 6858 | (Fencode_time): Use it, to test for out-of-range times. |
| 6859 | (lisp_time_argument): Don't rely on undefined left-shift and |
| 6860 | right-shift behavior when checking for time stamp overflow. |
| 6861 | |
| 6862 | * editfns.c (time_overflow): New function, refactoring common code. |
| 6863 | (Fformat_time_string, Fdecode_time, Fencode_time): |
| 6864 | (Fcurrent_time_string): Use it. |
| 6865 | |
| 6866 | Move 'make_time' to be next to its inverse 'lisp_time_argument'. |
| 6867 | * dired.c (make_time): Move to ... |
| 6868 | * editfns.c (make_time): ... here. |
| 6869 | * systime.h: Note the move. |
| 6870 | |
| 6871 | 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> |
| 6872 | |
| 6873 | * fringe.c (update_window_fringes): Remove unused variables. |
| 6874 | |
| 6875 | * unexmacosx.c (copy_data_segment): Also copy __got section. |
| 6876 | (Bug#8223) |
| 6877 | |
| 6878 | 2011-03-12 Eli Zaretskii <eliz@gnu.org> |
| 6879 | |
| 6880 | * termcap.c [MSDOS]: Include "msdos.h". |
| 6881 | (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent): |
| 6882 | Constify `char *' arguments and their references according to |
| 6883 | prototypes in tparam.h. |
| 6884 | |
| 6885 | * deps.mk (termcap.o): Depend on tparam.h and msdos.h. |
| 6886 | |
| 6887 | * msdos.c (XMenuAddPane): 3rd argument is `const char *' now. |
| 6888 | Adapt all references accordingly. |
| 6889 | |
| 6890 | * msdos.h (XMenuAddPane): 3rd argument is `const char *' now. |
| 6891 | |
| 6892 | 2011-03-11 Tom Tromey <tromey@redhat.com> |
| 6893 | |
| 6894 | * buffer.c (syms_of_buffer): Remove obsolete comment. |
| 6895 | |
| 6896 | 2011-03-11 Eli Zaretskii <eliz@gnu.org> |
| 6897 | |
| 6898 | * termhooks.h (encode_terminal_code): Declare prototype. |
| 6899 | |
| 6900 | * msdos.c (encode_terminal_code): Don't declare prototype. |
| 6901 | |
| 6902 | * term.c (encode_terminal_code): Now external again, used by |
| 6903 | w32console.c and msdos.c. |
| 6904 | |
| 6905 | * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)): |
| 6906 | Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu. |
| 6907 | |
| 6908 | 2011-03-11 Paul Eggert <eggert@cs.ucla.edu> |
| 6909 | |
| 6910 | Fix some minor problems found by GCC 4.5.2's static checks. |
| 6911 | |
| 6912 | * fringe.c (update_window_fringes): Mark locals as initialized |
| 6913 | (Bug#8227). |
| 6914 | (destroy_fringe_bitmap, init_fringe_bitmap): Now static. |
| 6915 | |
| 6916 | * alloc.c (mark_fringe_data): Move decl from here ... |
| 6917 | * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here, |
| 6918 | to check its interface. |
| 6919 | (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM. |
| 6920 | |
| 6921 | * fontset.c (free_realized_fontset): Now static. |
| 6922 | (Fset_fontset_font): Rename local to avoid shadowing. |
| 6923 | (fontset_font): Mark local as initialized. |
| 6924 | (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused. |
| 6925 | |
| 6926 | * xrdb.c: Include "xterm.h", to check x_load_resources's interface. |
| 6927 | |
| 6928 | * xselect.c (x_disown_buffer_selections): Remove; not used. |
| 6929 | (TRACE3) [!defined TRACE_SELECTION]: Remove; not used. |
| 6930 | (x_own_selection, Fx_disown_selection_internal): Rename locals |
| 6931 | to avoid shadowing. |
| 6932 | (x_handle_dnd_message): Remove local to avoid shadowing. |
| 6933 | |
| 6934 | * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros, |
| 6935 | so that the caller can use some name other than gcpro1. |
| 6936 | (GCPRO1, UNGCPRO): Reimplement in terms of the new macros. |
| 6937 | * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip): |
| 6938 | (Fx_backspace_delete_keys_p): |
| 6939 | Use them to avoid shadowing, and rename vars to avoid shadowing. |
| 6940 | (x_decode_color, x_set_name, x_window): Now static. |
| 6941 | (Fx_create_frame): Add braces to silence GCC warning. |
| 6942 | (Fx_file_dialog, Fx_select_font): Fix pointer signedness. |
| 6943 | (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame): |
| 6944 | Remove unused locals. |
| 6945 | (Fx_create_frame, x_create_tip_frame, Fx_show_tip): |
| 6946 | (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing. |
| 6947 | Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR |
| 6948 | macros. |
| 6949 | |
| 6950 | * xterm.h (x_mouse_leave): New decl. |
| 6951 | |
| 6952 | * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame): |
| 6953 | Remove unused functions. |
| 6954 | (x_shift_glyphs_for_insert, XTflash, XTring_bell): |
| 6955 | (x_calc_absolute_position): Now static. |
| 6956 | (XTread_socket): Don't define label "out" unless it's used. |
| 6957 | Don't declare local "event" unless it's used. |
| 6958 | (x_iconify_frame, x_free_frame_resources): Don't declare locals |
| 6959 | unless they are used. |
| 6960 | (XEMBED_VERSION, xembed_set_info): Don't define unless needed. |
| 6961 | (x_fatal_error_signal): Remove; not used. |
| 6962 | (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position): |
| 6963 | (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor): |
| 6964 | (x_error_catcher, x_connection_closed, x_error_handler): |
| 6965 | (x_error_quitter, xembed_send_message, x_iconify_frame): |
| 6966 | (my_log_handler): Rename locals to avoid shadowing. |
| 6967 | (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN. |
| 6968 | (x_connection_closed): Tell GCC not to suggest NO_RETURN. |
| 6969 | |
| 6970 | * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font): |
| 6971 | Rename or move locals to avoid shadowing. |
| 6972 | (tty_defined_color, merge_face_heights): Now static. |
| 6973 | (free_realized_faces_for_fontset): Remove; not used. |
| 6974 | (Fx_list_fonts): Mark variable that gcc -Wuninitialized |
| 6975 | does not deduce is never used uninitialized. |
| 6976 | (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used. |
| 6977 | (LFACEP): Define only if XASSERTS, as it's not needed otherwise. |
| 6978 | |
| 6979 | * terminal.c (store_terminal_param): Now static. |
| 6980 | |
| 6981 | * xmenu.c (menu_highlight_callback): Now static. |
| 6982 | (set_frame_menubar): Remove unused local. |
| 6983 | (xmenu_show): Rename parameter to avoid shadowing. |
| 6984 | (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const" |
| 6985 | since they might point to immutable storage. |
| 6986 | (next_menubar_widget_id): Declare only if USE_X_TOOLKIT, |
| 6987 | since it's unused otherwise. |
| 6988 | |
| 6989 | * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff. |
| 6990 | Add a FIXME, since the code still doesn't look right. (Bug#8215) |
| 6991 | (Fcurrent_bidi_paragraph_direction): Simplify slightly; this |
| 6992 | avoids a gcc -Wuninitialized diagnostic. |
| 6993 | (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs): |
| 6994 | (note_mouse_highlight): Mark variables that gcc -Wuninitialized |
| 6995 | does not deduce are never used uninitialized. |
| 6996 | |
| 6997 | * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c. |
| 6998 | |
| 6999 | * xdisp.c (redisplay_window): Rename local to avoid shadowing. |
| 7000 | * window.c (window_loop, size_window): |
| 7001 | (run_window_configuration_change_hook, enlarge_window): Likewise. |
| 7002 | |
| 7003 | * window.c (display_buffer): Now static. |
| 7004 | (size_window): Mark variables that gcc -Wuninitialized |
| 7005 | does not deduce are never used uninitialized. |
| 7006 | * window.h (check_all_windows): New decl, to forestall |
| 7007 | gcc -Wmissing-prototypes diagnostic. |
| 7008 | * dispextern.h (bidi_dump_cached_states): Likewise. |
| 7009 | |
| 7010 | * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid |
| 7011 | shadowing. |
| 7012 | * charset.c (map_charset_for_dump, Fchar_charset): Likewise. |
| 7013 | Include <limits.h>. |
| 7014 | (Fsort_charsets): Redo min/max calculation to shorten the code a bit |
| 7015 | and to avoid gcc -Wuninitialized warning. |
| 7016 | (load_charset_map): Mark variables that gcc -Wuninitialized |
| 7017 | does not deduce are never used uninitialized. |
| 7018 | (load_charset): Abort instead of using uninitialized var (Bug#8229). |
| 7019 | |
| 7020 | * coding.c (coding_set_source, coding_set_destination): |
| 7021 | Use "else { /* comment */ }" rather than "else /* comment */;" |
| 7022 | for clarity, and to avoid gcc -Wempty-body warning. |
| 7023 | (Fdefine_coding_system_internal): Don't redeclare 'i' inside |
| 7024 | a block, when the outer 'i' will do. |
| 7025 | (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule): |
| 7026 | (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022): |
| 7027 | (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5): |
| 7028 | (decode_coding_raw_text, decode_coding_charset, get_translation_table): |
| 7029 | (Fdecode_sjis_char, Fdefine_coding_system_internal): |
| 7030 | Rename locals to avoid shadowing. |
| 7031 | * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise. |
| 7032 | * coding.c (emacs_mule_char, encode_invocation_designation): |
| 7033 | Now static, since they're not used elsewhere. |
| 7034 | (decode_coding_iso_2022): Add "default: abort ();" as a safety check. |
| 7035 | (decode_coding_object, encode_coding_object, detect_coding_system): |
| 7036 | (decode_coding_emacs_mule): Mark variables that gcc |
| 7037 | -Wuninitialized does not deduce are never used uninitialized. |
| 7038 | (detect_coding_iso_2022): Initialize a local variable that might |
| 7039 | be used uninitialized. Leave a FIXME because it's not clear that |
| 7040 | this initialization is needed. (Bug#8211) |
| 7041 | (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT): |
| 7042 | (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P): |
| 7043 | (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER): |
| 7044 | (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R): |
| 7045 | Remove unused macros. |
| 7046 | |
| 7047 | * category.c (hash_get_category_set): Remove unused local var. |
| 7048 | (copy_category_table): Now static, since it's not used elsewhere. |
| 7049 | * character.c (string_count_byte8): Likewise. |
| 7050 | |
| 7051 | * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string): |
| 7052 | (Fregister_code_conversion_map): Rename locals to avoid shadowing. |
| 7053 | |
| 7054 | * chartab.c (copy_sub_char_table): Now static, since it's not used |
| 7055 | elsewhere. |
| 7056 | (sub_char_table_ref_and_range, char_table_ref_and_range): |
| 7057 | Rename locals to avoid shadowing. |
| 7058 | (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros. |
| 7059 | |
| 7060 | * bidi.c (bidi_check_type): Now static, since it's not used elsewhere. |
| 7061 | (BIDI_BOB): Remove unused macro. |
| 7062 | |
| 7063 | * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not |
| 7064 | deduce are never used uninitialized. |
| 7065 | * term.c (encode_terminal_code): Likewise. |
| 7066 | |
| 7067 | * term.c (encode_terminal_code): Now static. Remove unused local. |
| 7068 | |
| 7069 | * tparam.h: New file. |
| 7070 | * term.c, tparam.h: Include it. |
| 7071 | * deps.mk (term.o, tparam.o): Depend on tparam.h. |
| 7072 | * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr): |
| 7073 | Move these decls to tparam.h, and make them agree with what |
| 7074 | is actually in tparam.c. The previous trick of using incompatible |
| 7075 | decls in different modules does not conform to the C standard. |
| 7076 | All callers of tparam changed to use tparam's actual API. |
| 7077 | * tparam.c (tparam1, tparam, tgoto): |
| 7078 | Use const pointers where appropriate. |
| 7079 | |
| 7080 | * cm.c (calccost, cmgoto): Use const pointers where appropriate. |
| 7081 | * cm.h (struct cm): Likewise. |
| 7082 | * dispextern.h (do_line_insertion_deletion_costs): Likewise. |
| 7083 | * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise. |
| 7084 | * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table): |
| 7085 | (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph): |
| 7086 | (turn_on_face, init_tty): Likewise. |
| 7087 | * termchar.h (struct tty_display_info): Likewise. |
| 7088 | |
| 7089 | * term.c (term_mouse_position): Rename local to avoid shadowing. |
| 7090 | |
| 7091 | * alloc.c (mark_ttys): Move decl from here ... |
| 7092 | * lisp.h (mark_ttys): ... to here, so that it's checked against defn. |
| 7093 | |
| 7094 | 2011-03-11 Andreas Schwab <schwab@linux-m68k.org> |
| 7095 | |
| 7096 | * .gdbinit (pwinx, xbuffer): Fix access to buffer name. |
| 7097 | |
| 7098 | 2011-03-09 Juanma Barranquero <lekktu@gmail.com> |
| 7099 | |
| 7100 | * search.c (compile_pattern_1): Remove argument regp, unused since |
| 7101 | revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig. |
| 7102 | (compile_pattern): Don't pass it. |
| 7103 | |
| 7104 | 2011-03-08 Jan Djärv <jan.h.d@swipnet.se> |
| 7105 | |
| 7106 | * xterm.h (DEFAULT_GDK_DISPLAY): New define. |
| 7107 | (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines |
| 7108 | for ! HAVE_GTK3. |
| 7109 | (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID. |
| 7110 | |
| 7111 | * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size. |
| 7112 | |
| 7113 | * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define |
| 7114 | gdk_window_get_screen, gdk_window_get_geometry, |
| 7115 | gdk_x11_window_lookup_for_display and GDK_KEY_g. |
| 7116 | (xg_set_screen): Use DEFAULT_GDK_DISPLAY. |
| 7117 | (xg_get_pixbuf_from_pixmap): New function. |
| 7118 | (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap |
| 7119 | to Pixmap, take frame as parameter, remove GdkColormap parameter. |
| 7120 | Call xg_get_pixbuf_from_pixmap instead of |
| 7121 | gdk_pixbuf_get_from_drawable. |
| 7122 | (xg_get_image_for_pixmap): Do not make GdkPixmaps, call |
| 7123 | xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead. |
| 7124 | (xg_check_special_colors): Use GtkStyleContext and its functions |
| 7125 | for HAVE_GTK3. |
| 7126 | (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen. |
| 7127 | (xg_prepare_tooltip, create_dialog, menubar_map_cb) |
| 7128 | (xg_update_frame_menubar, xg_tool_bar_detach_callback) |
| 7129 | (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes): |
| 7130 | Call gtk_widget_get_preferred_size. |
| 7131 | (xg_frame_resized): gdk_window_get_geometry only takes 5 |
| 7132 | parameters. |
| 7133 | (xg_win_to_widget, xg_event_is_for_menubar): |
| 7134 | Call gdk_x11_window_lookup_for_display. |
| 7135 | (xg_set_widget_bg): New function. |
| 7136 | (delete_cb): New function. |
| 7137 | (xg_create_frame_widgets): Connect delete-event to delete_cb. |
| 7138 | Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3 |
| 7139 | (xg_set_background_color): Call xg_set_widget_bg. |
| 7140 | (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask. |
| 7141 | (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3. |
| 7142 | Only call gtk_range_set_update_policy if ! HAVE_GTK3. |
| 7143 | (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback |
| 7144 | if ! HAVE_GTK3. |
| 7145 | (update_frame_tool_bar): Call gtk_widget_hide. |
| 7146 | (xg_initialize): Use GDK_KEY_g. |
| 7147 | |
| 7148 | * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id |
| 7149 | if ! HAVE_GTK3 |
| 7150 | (x_session_initialize): Call gdk_x11_set_sm_client_id. |
| 7151 | |
| 7152 | * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3. |
| 7153 | (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS. |
| 7154 | Load ~/emacs.d/gtkrc only for ! HAVE_GTK3. |
| 7155 | |
| 7156 | 2011-03-08 Juanma Barranquero <lekktu@gmail.com> |
| 7157 | |
| 7158 | * w32xfns.c (select_palette): Check success of RealizePalette against |
| 7159 | GDI_ERROR, not zero. |
| 7160 | |
| 7161 | See ChangeLog.11 for earlier changes. |
| 7162 | |
| 7163 | ;; Local Variables: |
| 7164 | ;; coding: utf-8 |
| 7165 | ;; End: |
| 7166 | |
| 7167 | Copyright (C) 2011 Free Software Foundation, Inc. |
| 7168 | |
| 7169 | This file is part of GNU Emacs. |
| 7170 | |
| 7171 | GNU Emacs is free software: you can redistribute it and/or modify |
| 7172 | it under the terms of the GNU General Public License as published by |
| 7173 | the Free Software Foundation, either version 3 of the License, or |
| 7174 | (at your option) any later version. |
| 7175 | |
| 7176 | GNU Emacs is distributed in the hope that it will be useful, |
| 7177 | but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 7178 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| 7179 | GNU General Public License for more details. |
| 7180 | |
| 7181 | You should have received a copy of the GNU General Public License |
| 7182 | along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. |