* xmenu.c (set_frame_menubar): Allocate smaller local vectors.
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12011-04-09 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4 This also lets GCC 4.6.0 generate slightly better loop code.
5
6 * callint.c (Fcall_interactively): <, not <=, for optimization.
7 (Fcall_interactively): Count the number of arguments produced,
8 not the number of arguments given. This is simpler and lets GCC
9 4.6.0 generate slightly better code.
10
11 * ftfont.c: Distingish more carefully between FcChar8 and char.
12 The previous code passed unsigned char * to a functions like
13 strlen and xstrcasecmp that expect char *, which does not
14 conform to the C standard.
15 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
16 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
17 char * when the C standard requires it.
18
19 * keyboard.c (read_char): Remove unused var.
20
21 * eval.c: Port to Windows vsnprintf (Bug#8435).
22 Include <limits.h>.
23 (SIZE_MAX): Define if the headers do not.
24 (verror): Do not give up if vsnprintf returns a negative count.
25 Instead, grow the buffer. This ports to Windows vsnprintf, which
26 does not conform to C99. Problem reported by Eli Zaretskii.
27 Also, simplify the allocation scheme, by avoiding the need for
28 calling realloc, and removing the ALLOCATED variable.
29
30 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
31
32 Remove the doprnt implementation, as Emacs now uses vsnprintf.
33 * doprnt.c: Remove.
34 * lisp.h (doprnt): Remove.
35 * Makefile.in (base_obj): Remove doprnt.o.
36 * deps.mk (doprnt.o): Remove.
37
38 error: Print 32- and 64-bit integers portably (Bug#8435).
39 Without this change, on typical 64-bit hosts error ("...%d...", N)
40 was used to print both 32- and 64-bit integers N, which relied on
41 undefined behavior.
42 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
43 New macro.
44 * lisp.h (error, verror): Mark as printf-like functions.
45 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
46 Report overflow in size calculations when allocating printf buffer.
47 Do not truncate output string at its first null byte.
48 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
49 Truncate the output at a character boundary, since vsnprintf does not
50 do that.
51 * charset.c (check_iso_charset_parameter): Convert internal
52 character to string before calling 'error', since %c now has the
53 printf meaning.
54 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
55 overflow when computing char to be passed to 'error'. Do not
56 pass Lisp_Object to 'error'; pass the integer instead.
57 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
58 formatted with plain %d.
59
60 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
61
62 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
63
64 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
65
66 * xterm.c (x_catch_errors): Remove duplicate declaration.
67
68 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
69
70 * xdisp.c, lisp.h (message_nolog): Remove; unused.
71
722011-04-09 Chong Yidong <cyd@stupidchicken.com>
73
74 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
75 unsigned char, to match FcChar8 type definition.
76
77 * xterm.c (handle_one_xevent):
78 * xmenu.c (create_and_show_popup_menu):
79 * xselect.c (x_decline_selection_request)
80 (x_reply_selection_request): Avoid type-punned deref of X events.
81
822011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
83
84 Fix some uses of `int' instead of EMACS_INT.
85 * search.c (string_match_1, fast_string_match)
86 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
87 (scan_buffer, find_next_newline_no_quit)
88 (find_before_next_newline, search_command, Freplace_match)
89 (Fmatch_data): Make some `int' variables be EMACS_INT.
90
91 * xdisp.c (display_count_lines): 3rd argument and return value now
92 EMACS_INT. All callers changed.
93 (pint2hrstr): Last argument is now EMACS_INT.
94
95 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
96 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
97 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
98 (decode_coding_utf_16, decode_coding_emacs_mule)
99 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
100 (decode_coding_ccl, decode_coding_charset)
101 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
102 (decode_coding_iso_2022, decode_coding_emacs_mule)
103 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
104 <char_offset, last_offset>: Declare EMACS_INT.
105 (encode_coding_utf_8, encode_coding_utf_16)
106 (encode_coding_emacs_mule, encode_invocation_designation)
107 (encode_designation_at_bol, encode_coding_iso_2022)
108 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
109 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
110 Declare EMACS_INT.
111 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
112 (encode_invocation_designation): Last argument P_NCHARS is now
113 EMACS_INT.
114 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
115 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
116
117 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
118 All users changed.
119
120 * ccl.c (Fccl_execute_on_string): Declare some variables
121 EMACS_INT.
122
1232011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
124
125 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
126
1272011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
128
129 * process.c (Fformat_network_address): Doc fix.
130
1312011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
132
133 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
134
1352011-04-08 Chong Yidong <cyd@stupidchicken.com>
136
137 * keyboard.c (read_char): Call Lisp function help-form-show,
138 instead of using internal_with_output_to_temp_buffer.
139 (Qhelp_form_show): New var.
140 (syms_of_keyboard): Use DEFSYM macro.
141
142 * print.c (internal_with_output_to_temp_buffer): Function deleted.
143
144 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
145
1462011-04-06 Chong Yidong <cyd@stupidchicken.com>
147
148 * process.c (Flist_processes): Removed to Lisp.
149 (list_processes_1): Deleted.
150
1512011-04-06 Eli Zaretskii <eliz@gnu.org>
152
153 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
154
155 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
156
1572011-04-06 Paul Eggert <eggert@cs.ucla.edu>
158
159 Fix more problems found by GCC 4.6.0's static checks.
160
161 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
162
163 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
164
165 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
166
167 * xdisp.c (vmessage): Mark as a printf-like function.
168
169 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
170
171 * sound.c (sound_warning): Don't crash if arg contains a printf format.
172
173 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
174 printf-like functions.
175 (tiff_load): Add casts to remove these marks before passing them
176 to system-supplied API.
177
178 * eval.c (Fsignal): Remove excess argument to 'fatal'.
179
180 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
181 This avoids several warnings with gcc -Wstrict-overflow.
182 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
183 directly, rather than having caller test rule sign. This avoids
184 some unnecessary tests.
185 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
186 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
187 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
188
189 * xfont.c (xfont_text_extents): Remove var that was set but not used.
190 (xfont_open): Avoid unnecessary tests.
191
192 * composite.c (composition_gstring_put_cache): Use unsigned integer.
193
194 * composite.h, composite.c (composition_gstring_put_cache):
195 Use EMACS_INT, not int, for length.
196
197 * composite.h (COMPOSITION_DECODE_REFS): New macro,
198 breaking out part of COMPOSITION_DECODE_RULE.
199 (COMPOSITION_DECODE_RULE): Use it.
200 * composite.c (get_composition_id): Remove unused local vars,
201 by using the new macro.
202
203 * textprop.c (set_text_properties_1): Change while to do-while,
204 since the condition is always true at first.
205
206 * intervals.c (graft_intervals_into_buffer): Mark var as used.
207 (interval_deletion_adjustment): Return unsigned value.
208 All uses changed.
209
210 * process.c (list_processes_1, create_pty, read_process_output):
211 (exec_sentinel): Remove vars that were set but not used.
212 (create_pty): Remove unnecessary "volatile"s.
213 (Fnetwork_interface_info): Avoid possibility of int overflow.
214 (read_process_output): Do adaptive read buffering even if carryover.
215 (read_process_output): Simplify nbytes computation if buffered.
216
217 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
218
219 * syntax.c (scan_words): Remove var that was set but not used.
220 (update_syntax_table): Use unsigned instead of int.
221
222 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
223 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
224 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
225
226 * print.c (print_error_message): Avoid int overflow.
227
228 * font.c (font_list_entities): Redo for clarity,
229 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
230
231 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
232 (font_score): Avoid potential overflow in diff calculation.
233
234 * fns.c (substring_both): Remove var that is set but not used.
235 (sxhash): Redo loop for clarity and to avoid wraparound warning.
236
237 * eval.c (funcall_lambda): Rename local to avoid shadowing.
238
239 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
240 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
241 can always succeed if overflow has undefined behavior.
242
243 * search.c (boyer_moore, wordify): Remove vars set but not used.
244 (wordify): Omit three unnecessary tests.
245
246 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
247 All callers changed. This avoids the need for an unused var.
248
249 * casefiddle.c (casify_region): Remove var that is set but not used.
250
251 * dired.c (file_name_completion): Remove var that is set but not used.
252
253 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
254
255 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
256 (Finsert_file_contents): Remove unnecessary code checking fd.
257
258 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
259 Check for integer overflow on size calculations.
260
261 * buffer.c (Fprevious_overlay_change): Remove var that is set
262 but not used.
263
264 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
265 Remove vars that are set but not used.
266 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
267 (timer_check_2): Mark vars as initialized.
268
269 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
270
271 * image.c (lookup_image): Remove var that is set but not used.
272 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
273
274 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
275 that are set but not used.
276
277 * xfns.c (make_invisible_cursor): Don't return garbage
278 if XCreateBitmapFromData fails (Bug#8410).
279
280 * xselect.c (x_get_local_selection, x_handle_property_notify):
281 Remove vars that are set but not used.
282
283 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
284 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
285
286 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
287 Remove var that is set but not used.
288 (scroll_bar_windows_size): Now size_t, not int.
289 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
290 Check for overflow.
291
292 * xfaces.c (realize_named_face): Remove vars that are set but not used.
293 (map_tty_color) [!defined MSDOS]: Likewise.
294
295 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
296
297 * coding.c: Remove vars that are set but not used.
298 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
299 All callers changed.
300 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
301 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
302 (decode_coding_charset): Remove vars that are set but not used.
303
304 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
305 that is set but not used.
306
307 * print.c (print_object): Remove var that is set but not used.
308
309 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
310 The gnulib version avoids calling malloc in the usual case,
311 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
312 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
313 * filelock.c (current_lock_owner): Likewise.
314 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
315 * sysdep.c: Include allocator.h, careadlinkat.h.
316 (emacs_no_realloc_allocator): New static constant.
317 (emacs_readlink): New function.
318 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
319 ../lib/careadlinkat.h.
320
3212011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
322
323 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
324 first non-nil return value).
325
3262011-04-03 Jan Djärv <jan.h.d@swipnet.se>
327
328 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
329 if not defined (Bug#8403).
330
3312011-04-02 Juanma Barranquero <lekktu@gmail.com>
332
333 * xdisp.c (display_count_lines): Remove parameter `start',
334 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
335 (get_char_face_and_encoding): Remove parameter `multibyte_p',
336 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
337 (fill_stretch_glyph_string): Remove parameters `row' and `area',
338 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
339 and thereabouts. All callers changed.
340 (get_per_char_metric): Remove parameter `f', unused since
341 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
342
3432011-04-02 Jim Meyering <meyering@redhat.com>
344
345 do not dereference NULL upon failed strdup
346 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
347 (ns_get_family): Likewise.
348
3492011-04-02 Juanma Barranquero <lekktu@gmail.com>
350
351 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
352
3532011-04-02 Jan Djärv <jan.h.d@swipnet.se>
354
355 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
356 later (Bug#8403).
357
3582011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
359
360 Add lexical binding.
361
362 * window.c (Ftemp_output_buffer_show): New fun.
363 (Fsave_window_excursion):
364 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
365
366 * lread.c (lisp_file_lexically_bound_p): New function.
367 (Fload): Bind Qlexical_binding.
368 (readevalloop): Remove `evalfun' arg.
369 Bind Qinternal_interpreter_environment.
370 (Feval_buffer): Bind Qlexical_binding.
371 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
372 Mark as dynamic.
373 (syms_of_lread): Declare `lexical-binding'.
374
375 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
376
377 * keyboard.c (eval_dyn): New fun.
378 (menu_item_eval_property): Use it.
379
380 * image.c (parse_image_spec): Use Ffunctionp.
381
382 * fns.c (concat, mapcar1): Accept byte-code-functions.
383
384 * eval.c (Fsetq): Handle lexical vars.
385 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
386 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
387 (FletX, Flet): Obey lexical binding.
388 (Fcommandp): Handle closures.
389 (Feval): New `lexical' arg.
390 (eval_sub): New function extracted from Feval. Use it almost
391 everywhere where Feval was used. Look up vars in lexical env.
392 Handle closures.
393 (Ffunctionp): Move from subr.el.
394 (Ffuncall): Handle closures.
395 (apply_lambda): Remove `eval_flags'.
396 (funcall_lambda): Handle closures and new byte-code-functions.
397 (Fspecial_variable_p): New function.
398 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
399 but without exporting it to Lisp.
400
401 * doc.c (Fdocumentation, store_function_docstring):
402 * data.c (Finteractive_form): Handle closures.
403
404 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
405 interactive spec.
406
407 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
408 byte-codes.
409 (exec_byte_code): New function extracted from Fbyte_code to handle new
410 calling convention for byte-code-functions. Add new byte-codes.
411
412 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
413
414 * alloc.c (Fmake_symbol): Init new `declared_special' field.
415
4162011-03-31 Juanma Barranquero <lekktu@gmail.com>
417
418 * xdisp.c (redisplay_internal): Fix prototype.
419
4202011-03-31 Eli Zaretskii <eliz@gnu.org>
421
422 * xdisp.c (SCROLL_LIMIT): New macro.
423 (try_scrolling): Use it when setting scroll_limit. Limit
424 scrolling to 100 screen lines.
425 (redisplay_window): Even when falling back on "recentering",
426 position point in the window according to scroll-conservatively,
427 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
428
429 (try_scrolling): When point is above the window, allow searching
430 as far as scroll_max, or one screenful, to compute vertical
431 distance from PT to the scroll margin position. This prevents
432 try_scrolling from unnecessarily failing when
433 scroll-conservatively is set to a value slightly larger than the
434 window height. Clean up the case of PT below the margin at bottom
435 of window: scroll_max can no longer be INT_MAX. When aggressive
436 scrolling is in use, don't let point enter the opposite scroll
437 margin as result of the scroll.
438 (syms_of_xdisp) <scroll-conservatively>: Document the
439 threshold of 100 lines for never-recentering scrolling.
440
4412011-03-31 Juanma Barranquero <lekktu@gmail.com>
442
443 * dispextern.h (move_it_by_lines):
444 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
445 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
446 (message_log_check_duplicate): Remove parameters `prev_bol' and
447 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
448 (redisplay_internal): Remove parameter `preserve_echo_area',
449 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
450
451 * indent.c (Fvertical_motion):
452 * window.c (window_scroll_pixel_based, Frecenter):
453 Don't pass `need_y_p' to `move_it_by_lines'.
454
4552011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
456
457 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
458 steal a few bits to be more compact.
459 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
460 Remove unneeded casts.
461
462 * bytecode.c (Fbyte_code): CAR and CDR can GC.
463
4642011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
465
466 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
467 binding" message (bug#7967).
468
4692011-03-30 Paul Eggert <eggert@cs.ucla.edu>
470
471 Fix more problems found by GCC 4.6.0's static checks.
472
473 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
474 Remove unused local var.
475
476 * editfns.c (Fmessage_box): Remove unused local var.
477
478 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
479 (note_mode_line_or_margin_highlight, note_mouse_highlight):
480 Omit unused local vars.
481 * window.c (shrink_windows): Omit unused local var.
482 * menu.c (digest_single_submenu): Omit unused local var.
483 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
484 Omit unused local var.
485
486 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
487 Don't assume string length fits in int.
488 (keyremap_step, read_key_sequence): Use size_t for sizes.
489 (read_key_sequence): Don't check last_real_key_start redundantly.
490
491 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
492 instead of alloca (Bug#8344).
493
494 * eval.c (Fbacktrace): Don't assume nargs fits in int.
495 (Fbacktrace_frame): Don't assume nframes fits in int.
496
497 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
498
499 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
500 concerns.
501
502 * term.c (produce_glyphless_glyph): Remove unnecessary test.
503
504 * cm.c (calccost): Turn while-do into do-while, for clarity.
505
506 * keyboard.c (syms_of_keyboard): Use the same style as later
507 in this function when indexing through an array. This also
508 works around GCC bug 48267.
509
510 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
511
512 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
513
514 * chartab.c (sub_char_table_ref_and_range): Redo for slight
515 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
516
517 * keyboard.c, keyboard.h (num_input_events): Now size_t.
518 This avoids undefined behavior on integer overflow, and is a bit
519 more convenient anyway since it is compared to a size_t variable.
520
521 Variadic C functions now count arguments with size_t, not int.
522 This avoids an unnecessary limitation on 64-bit machines, which
523 caused (substring ...) to crash on large vectors (Bug#8344).
524 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
525 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
526 All variadic functions and their callers changed accordingly.
527 (struct gcpro.nvars): Now size_t, not int. All uses changed.
528 * data.c (arith_driver, float_arith_driver): Likewise.
529 * editfns.c (general_insert_function): Likewise.
530 * eval.c (struct backtrace.nargs, interactive_p)
531 (internal_condition_case_n, run_hook_with_args, apply_lambda)
532 (funcall_lambda, mark_backtrace): Likewise.
533 * fns.c (concat): Likewise.
534 * frame.c (x_set_frame_parameters): Likewise.
535 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
536 0 if not found, not -1. All callers changed.
537
538 * alloc.c (garbage_collect): Don't assume stack size fits in int.
539 (stack_copy_size): Now size_t, not int.
540 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
541
5422011-03-28 Juanma Barranquero <lekktu@gmail.com>
543
544 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
545 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
546 All callers changed.
547
548 * lisp.h (multibyte_char_to_unibyte):
549 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
550 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
551 * character.h (CHAR_TO_BYTE8):
552 * cmds.c (internal_self_insert):
553 * editfns.c (general_insert_function):
554 * keymap.c (push_key_description):
555 * search.c (Freplace_match):
556 * xdisp.c (message_dolog, set_message_1): All callers changed.
557
5582011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
559
560 * keyboard.c (safe_run_hook_funcall): New function.
561 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
562 don't set the hook to nil, but remove the offending function instead.
563 (Qcommand_hook_internal): Remove, unused.
564 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
565 Vcommand_hook_internal.
566
567 * eval.c (enum run_hooks_condition): Remove.
568 (funcall_nil, funcall_not): New functions.
569 (run_hook_with_args): Call each function through a `funcall' argument.
570 Remove `cond' argument, now redundant.
571 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
572 (Frun_hook_with_args_until_failure): Adjust accordingly.
573 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
574
5752011-03-28 Juanma Barranquero <lekktu@gmail.com>
576
577 * dispextern.h (string_buffer_position): Remove declaration.
578
579 * print.c (strout): Remove parameter `multibyte', unused since
580 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
581
582 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
583 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
584 All callers changed.
585
586 * w32.c (_wsa_errlist): Use braces for struct initializers.
587
588 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
589 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
590 All callers changed.
591 (string_buffer_position): Likewise. Also, make static (it's never
592 used outside xdisp.c).
593 (cursor_row_p): Remove parameter `w', unused since
594 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
595 (decode_mode_spec): Remove parameter `precision', introduced during
596 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
597 All callers changed.
598
5992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
600
601 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
602
6032011-03-27 Anders Lindgren <andlind@gmail.com>
604
605 * nsterm.m (ns_menu_bar_is_hidden): New variable.
606 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
607 (ns_update_auto_hide_menu_bar): New functions.
608 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
609 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
610 ns_constrain_all_frames.
611 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
612 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
613
6142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
615
616 * nsmenu.m (runDialogAt): Remove argument to timer_check.
617
6182011-03-27 Glenn Morris <rgm@gnu.org>
619
620 * syssignal.h: Replace RETSIGTYPE with void.
621 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
622 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
623 Replace SIGTYPE with void everywhere.
624 * s/usg5-4-common.h (SIGTYPE): Remove definition.
625 * s/template.h (SIGTYPE): Remove commented out definition.
626
6272011-03-26 Eli Zaretskii <eliz@gnu.org>
628
629 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
630 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
631
6322011-03-26 Juanma Barranquero <lekktu@gmail.com>
633
634 * w32.c (read_unc_volume): Use parameter `henum', instead of
635 global variable `wget_enum_handle'.
636
637 * keymap.c (describe_vector): Remove parameters `indices' and
638 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
639 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
640
641 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
642
643 * keyboard.c (timer_check): Remove parameter `do_it_now',
644 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
645 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
646 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
647
648 * keyboard.c (read_char):
649 * w32menu.c (w32_menu_display_help):
650 * xmenu.c (show_help_event, menu_help_callback):
651 Adjust calls to `show_help_echo'.
652
653 * gtkutil.c (xg_maybe_add_timer):
654 * keyboard.c (readable_events):
655 * process.c (wait_reading_process_output):
656 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
657
658 * insdel.c (adjust_markers_gap_motion):
659 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
660 (gap_left, gap_right): Don't call it.
661
6622011-03-25 Chong Yidong <cyd@stupidchicken.com>
663
664 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
665 incurred during fontification.
666
6672011-03-25 Juanma Barranquero <lekktu@gmail.com>
668
669 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
670 (DEFVAR_PER_BUFFER): Don't pass it.
671
672 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
673 (scrolling_window): Don't pass it.
674
6752011-03-25 Juanma Barranquero <lekktu@gmail.com>
676
677 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
678
679 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
680 and `suffix'.
681 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
682 of variables specific to SELinux and computation of `encoded_absname'.
683
684 * image.c (XPutPixel): Remove unused variable `height'.
685
686 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
687
688 * unexw32.c (get_section_info): Remove unused variable `section'.
689
690 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
691 (system_process_attributes): Remove unused variable `sess'.
692 (sys_read): Remove unused variable `err'.
693
694 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
695 (w32_wnd_proc): Remove unused variable `isdead'.
696 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
697 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
698 (x_create_tip_frame): Remove unused variable `tem'.
699
700 * w32inevt.c (w32_console_read_socket):
701 Remove unused variable `no_events'.
702
703 * w32term.c (x_draw_composite_glyph_string_foreground):
704 Remove unused variable `width'.
705
7062011-03-24 Juanma Barranquero <lekktu@gmail.com>
707
708 * w32term.c (x_set_glyph_string_clipping):
709 Don't pass uninitialized region to CombineRgn.
710
7112011-03-23 Juanma Barranquero <lekktu@gmail.com>
712
713 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
714 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
715 (Fx_close_connection): Remove unused variable `i'.
716
717 * w32font.c (w32font_draw): Return number of glyphs.
718 (w32font_open_internal): Remove unused variable `i'.
719 (w32font_driver): Add missing initializer.
720
721 * w32menu.c (utf8to16): Remove unused variable `utf16'.
722 (fill_in_menu): Remove unused variable `items_added'.
723
724 * w32term.c (last_mouse_press_frame): Remove static global variable.
725 (w32_clip_to_row): Remove unused variable `f'.
726 (x_delete_terminal): Remove unused variable `i'.
727
728 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
729 (NOTHING): Remove unused static global variable.
730 (uniscribe_check_otf): Remove unused variable `table'.
731 (uniscribe_font_driver): Add missing initializers.
732
7332011-03-23 Julien Danjou <julien@danjou.info>
734
735 * term.c (Fsuspend_tty, Fresume_tty):
736 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
737 * window.c (temp_output_buffer_show):
738 * insdel.c (signal_before_change):
739 * frame.c (Fhandle_switch_frame):
740 * fileio.c (Fdo_auto_save):
741 * emacs.c (Fkill_emacs):
742 * editfns.c (save_excursion_restore):
743 * cmds.c (internal_self_insert):
744 * callint.c (Fcall_interactively):
745 * buffer.c (Fkill_all_local_variables):
746 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
747 Use Frun_hooks.
748 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
749 unconditionnaly since it does the check itself.
750
7512011-03-23 Paul Eggert <eggert@cs.ucla.edu>
752
753 Fix more problems found by GCC 4.5.2's static checks.
754
755 * coding.c (encode_coding_raw_text): Avoid unnecessary test
756 the first time through the loop, since we know p0 < p1 then.
757 This also avoids a gcc -Wstrict-overflow warning.
758
759 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
760 leading to a memory leak, possible in functions like
761 load_charset_map_from_file that can allocate an unbounded number
762 of objects (Bug#8318).
763
764 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
765 that could (at least in theory) be that large.
766
767 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
768 This is less likely to overflow, and avoids undefined behavior if
769 overflow does occur. All callers changed. Use strtoul to scan
770 for the unsigned long integer.
771 (pint2hrstr): Simplify and tune code slightly.
772 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
773
774 * scroll.c (do_scrolling): Work around GCC bug 48228.
775 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
776
777 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
778 This also avoids a warning with gcc -Wstrict-overflow.
779 (validate_x_resource_name): Simplify count usage.
780 This also avoids a warning with gcc -Wstrict-overflow.
781
782 * fileio.c (Fcopy_file): Report error if fchown or fchmod
783 fail (Bug#8306).
784
785 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
786
787 * process.c (Fmake_network_process): Use socklen_t, not int,
788 where POSIX says socklen_t is required in portable programs.
789 This fixes a porting bug on hosts like 64-bit HP-UX, where
790 socklen_t is wider than int (Bug#8277).
791 (Fmake_network_process, server_accept_connection):
792 (wait_reading_process_output, read_process_output):
793 Likewise.
794
795 * process.c: Rename or move locals to avoid shadowing.
796 (list_processes_1, Fmake_network_process):
797 (read_process_output_error_handler, exec_sentinel_error_handler):
798 Rename or move locals.
799 (Fmake_network_process): Define label "retry_connect" only if needed.
800 (Fnetwork_interface_info): Fix pointer signedness.
801 (process_send_signal): Add cast to avoid pointer signedness problem.
802 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
803 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
804
805 Make tparam.h and terminfo.c consistent.
806 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
807 Include tparam.h instead, since it declares them.
808 * cm.h (PC): Remove extern decl; tparam.h now does this.
809 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
810 * terminfo.c: Include tparam.h, to check interfaces.
811 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
812 (tparam): Adjust signature to match interface in tparam.h;
813 this removes some undefined behavior. Check that outstring and len
814 are zero, which they always are with Emacs.
815 * tparam.h (PC, BC, UP): New extern decls.
816
817 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
818 (xftfont_open): Rename locals to avoid shadowing.
819
820 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
821 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
822 (OTF_TAG_SYM): Omit macro if not needed.
823 (ftfont_list): Remove unused local.
824 (get_adstyle_property, ftfont_pattern_entity):
825 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
826 Rename locals to avoid shadowing.
827
828 * xfont.c (xfont_list_family): Mark var as initialized.
829
830 * xml.c (make_dom): Now static.
831
832 * composite.c (composition_compute_stop_pos): Rename local to
833 avoid shadowing.
834 (composition_reseat_it): Remove unused locals.
835 (find_automatic_composition, composition_adjust_point): Likewise.
836 (composition_update_it): Mark var as initialized.
837 (find_automatic_composition): Mark vars as initialized,
838 with a FIXME (Bug#8290).
839
840 character.h: Rename locals to avoid shadowing.
841 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
842 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
843 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
844 (BUF_DEC_POS): Be more systematic about renaming local temporaries
845 to avoid shadowing.
846
847 * textprop.c (property_change_between_p): Remove; unused.
848
849 * intervals.c (interval_start_pos): Now static.
850
851 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
852
853 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
854 Rename locals to avoid shadowing.
855
856 * sound.c (wav_play, au_play, Fplay_sound_internal):
857 Fix pointer signedness.
858 (alsa_choose_format): Remove unused local var.
859 (wav_play): Initialize a variable to 0, to prevent undefined
860 behavior (Bug#8278).
861
862 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
863
864 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
865
866 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
867 clobbering (Bug#8298).
868 * sysdep.c (sys_subshell): Likewise.
869 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
870
871 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
872 This should get cleaned up, so that child_setup has the
873 same signature on all platforms.
874
875 * callproc.c (call_process_cleanup): Now static.
876 (relocate_fd): Rename locals to avoid shadowing.
877
8782011-03-22 Chong Yidong <cyd@stupidchicken.com>
879
880 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
881 not to be necessary, and produces flickering.
882
8832011-03-20 Glenn Morris <rgm@gnu.org>
884
885 * config.in: Remove file.
886
8872011-03-20 Juanma Barranquero <lekktu@gmail.com>
888
889 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
890 are now in src/globals.h.
891 (syms_of_minibuf): Remove spurious & from previous change.
892
8932011-03-20 Leo <sdl.web@gmail.com>
894
895 * minibuf.c (completing-read-function): New variable.
896 (completing-read-default): Rename from completing-read.
897 (completing-read): Call completing-read-function.
898
8992011-03-19 Juanma Barranquero <lekktu@gmail.com>
900
901 * xfaces.c (Fx_load_color_file):
902 Read color file from absolute filename (bug#8250).
903
9042011-03-19 Juanma Barranquero <lekktu@gmail.com>
905
906 * makefile.w32-in: Update dependencies.
907
9082011-03-17 Eli Zaretskii <eliz@gnu.org>
909
910 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
911
9122011-03-17 Paul Eggert <eggert@cs.ucla.edu>
913
914 Fix more problems found by GCC 4.5.2's static checks.
915
916 * process.c (make_serial_process_unwind, send_process_trap):
917 (sigchld_handler): Now static.
918
919 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
920 That way, the code declares only the vars that it needs.
921 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
922 * s/cygwin.h (PTY_ITERATION): Likewise.
923 * s/darwin.h (PTY_ITERATION): Likewise.
924 * s/gnu-linux.h (PTY_ITERATION): Likewise.
925
926 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
927 * process.c (allocate_pty): Don't declare stb unless it's needed.
928
929 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
930 (CONSTANTLIM): Remove; unused.
931 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
932 Define only if needed.
933
934 * unexelf.c (unexec): Name an expression,
935 to avoid gcc -Wbad-function-cast warning.
936 Use a different way to cause a compilation error if anyone uses
937 n rather than nn, a way that does not involve shadowing.
938 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
939
940 * deps.mk (unexalpha.o): Remove; unused.
941
942 New file unexec.h, the (simple) interface for unexec (Bug#8267).
943 * unexec.h: New file.
944 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
945 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
946 Depend on unexec.h.
947 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
948 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
949 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
950 Change as necessary to match prototype in unexec.h.
951
952 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
953 shadowing.
954 (back_comment, skip_chars): Mark vars as initialized.
955
956 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
957 Rename locals to avoid shadowing.
958
959 * lread.c (read1): Rewrite so as not to use empty "else".
960 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
961
962 * print.c (Fredirect_debugging_output): Fix pointer signedess.
963
964 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
965 warning when compiling print.c.
966
967 * font.c (font_unparse_fcname): Abort in an "impossible" situation
968 instead of using an uninitialized var.
969 (font_sort_entities): Mark var as initialized.
970
971 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
972
973 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
974 pointers to constants.
975 (font_parse_fcname): Remove unused vars.
976 (font_delete_unmatched): Now static.
977 (font_get_spec): Remove; unused.
978 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
979 (font_update_drivers, Ffont_get_glyphs, font_add_log):
980 Rename or move locals to avoid shadowing.
981
982 * fns.c (require_nesting_list, require_unwind): Now static.
983 (Ffillarray): Rename locals to avoid shadowing.
984
985 * floatfns.c (domain_error2): Define only if needed.
986 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
987
988 * alloc.c (mark_backtrace): Move decl from here ...
989 * lisp.h: ... to here, so that it can be checked.
990
991 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
992 (Fdefvar): Rewrite so as not to use empty "else".
993 (lisp_indirect_variable): Name an expression,
994 to avoid gcc -Wbad-function-cast warning.
995 (Fdefvar): Rename locals to avoid shadowing.
996
997 * callint.c (quotify_arg, quotify_args): Now static.
998 (Fcall_interactively): Rename locals to avoid shadowing.
999 Use const pointer when appropriate.
1000
1001 * lisp.h (get_system_name, get_operating_system_release):
1002 Move decls here, to check interfaces.
1003 * process.c (get_operating_system_release): Move decl to lisp.h.
1004 * xrdb.c (get_system_name): Likewise.
1005 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1006 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1007 some of which prompt warnings from gcc -Wbad-function-cast.
1008 (Fformat_time_string, Fencode_time, Finsert_char):
1009 (Ftranslate_region_internal, Fformat):
1010 Rename or remove local vars to avoid shadowing.
1011 (Ftranslate_region_internal): Mark var as initialized.
1012
1013 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1014 avoid shadowing.
1015
1016 * lisp.h (eassert): Check that the argument compiles, even if
1017 ENABLE_CHECKING is not defined.
1018
1019 * data.c (Findirect_variable): Name an expression, to avoid
1020 gcc -Wbad-function-cast warning.
1021 (default_value, arithcompare, arith_driver, arith_error): Now static.
1022 (store_symval_forwarding): Rename local to avoid shadowing.
1023 (Fmake_variable_buffer_local, Fmake_local_variable):
1024 Mark variables as initialized.
1025 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1026
1027 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1028 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1029 Rename locals to avoid shadowing.
1030 (mark_stack): Move local variables into the #ifdef region where
1031 they're used.
1032 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1033 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1034 needed otherwise.
1035 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1036 (GC_STRING_CHARS): Remove; not used.
1037 (Fmemory_limit): Cast sbrk's returned value to char *.
1038
1039 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1040 avoids undefined behavior in theory.
1041
1042 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1043
1044 Use functions, not macros, for up- and down-casing (Bug#8254).
1045 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1046 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1047 to use the following functions instead of these macros.
1048 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1049 EMACS_INT, since callers assume the returned value fits in int.
1050 (upcase1): Likewise, for UPCASE_TABLE.
1051 (uppercasep, lowercasep, upcase): New static inline functions.
1052 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1053 the race-condition problem in the old DOWNCASE.
1054
1055 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1056 Rename locals to avoid shadowing.
1057 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1058 (regex_compile, re_search_2, re_match_2_internal):
1059 Remove unused local vars.
1060 (FREE_VAR): Rewrite so as not to use empty "else",
1061 which gcc can warn about.
1062 (regex_compile, re_match_2_internal): Mark locals as initialized.
1063 (RETALLOC_IF): Define only if needed.
1064 (WORDCHAR_P): Likewise. This one is never needed, but is used
1065 only in a comment talking about a compiler bug, so put inside
1066 the #if 0 of that comment.
1067 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1068 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1069 Remove; unused.
1070
1071 * search.c (boyer_moore): Rename locals to avoid shadowing.
1072 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1073 (PREV_CHAR_BOUNDARY): Likewise.
1074
1075 * search.c (simple_search): Remove unused var.
1076
1077 * dired.c (compile_pattern): Move decl from here ...
1078 * lisp.h: ... to here, so that it can be checked.
1079 (struct re_registers): New forward decl.
1080
1081 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1082
1083 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1084 All uses changed.
1085 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1086 Rename locals to avoid shadowing.
1087 (Fvertical_motion): Mark locals as initialized.
1088
1089 * casefiddle.c (casify_object, casify_region): Now static.
1090 (casify_region): Mark local as initialized.
1091
1092 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1093
1094 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1095 New macros, so that the caller can use some names other than
1096 gcpro1, gcpro2, etc.
1097 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1098 of the new macros.
1099 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1100 argument, for consistency with GCPRO2_VAR, etc: it is now the
1101 prefix of the variable, not the variable itself. All uses
1102 changed.
1103 * dired.c (directory_files_internal, file_name_completion):
1104 Rename locals to avoid shadowing.
1105
1106 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1107 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1108 dired.c's scmp function, had undefined behavior.
1109 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1110 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1111 * buffer.h: ... to here, because these macros use current_buffer,
1112 and the new implementation with inline functions needs to have
1113 current_buffer in scope now, rather than later when the macros
1114 are used.
1115 (downcase, upcase1): New static inline functions.
1116 (DOWNCASE, UPCASE1): Reimplement using these functions.
1117 This avoids undefined behavior in expressions like
1118 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1119 from race conditions in accessing the global variables
1120 case_temp1 and case_temp2.
1121 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1122 * lisp.h (case_temp1, case_temp2): Remove their decls.
1123 * character.h (ASCII_CHAR_P): Move from here ...
1124 * lisp.h: ... to here, so that the inline functions mentioned
1125 above can use them.
1126
1127 * dired.c (directory_files_internal_unwind): Now static.
1128
1129 * fileio.c (file_name_as_directory, directory_file_name):
1130 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1131 Now static.
1132 (file_name_as_directory): Use const pointers when appropriate.
1133 (Fexpand_file_name): Likewise. In particular, newdir might
1134 point at constant storage, so make it a const pointer.
1135 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1136 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1137 signedness issues.
1138 (Fset_file_times, Finsert_file_contents, auto_save_error):
1139 Rename locals to avoid shadowing.
1140
1141 * minibuf.c (choose_minibuf_frame_1): Now static.
1142 (Ftry_completion, Fall_completions): Rename or remove locals
1143 to avoid shadowing.
1144
1145 * marker.c (bytepos_to_charpos): Remove; unused.
1146
1147 * lisp.h (verify_bytepos, count_markers): New decls,
1148 so that gcc does not warn that these functions aren't declared.
1149
1150 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1151 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1152 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1153 (copy_text): Remove unused local var.
1154
1155 * filelock.c (within_one_second): Now static.
1156 (lock_file_1): Rename local to avoid shadowing.
1157
1158 * buffer.c (fix_overlays_before): Mark locals as initialized.
1159 (fix_start_end_in_overlays): Likewise. This function should be
1160 simplified by using pointers-to-pointers, but that's a different
1161 matter.
1162 (switch_to_buffer_1): Now static.
1163 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1164 (report_overlay_modification): Rename locals to avoid shadowing.
1165
1166 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1167 Fix pointer signedness issue.
1168 (sys_subshell): Mark local as volatile if checking for lint,
1169 to suppress a gcc -Wclobbered warning that does not seem to be right.
1170 (MAXPATHLEN): Define only if needed.
1171
1172 * process.c (serial_open, serial_configure): Move decls from here ...
1173 * systty.h: ... to here, so that they can be checked.
1174
1175 * fns.c (get_random, seed_random): Move extern decls from here ...
1176 * lisp.h: ... to here, so that they can be checked.
1177
1178 * sysdep.c (reset_io): Now static.
1179 (wait_for_termination_signal): Remove; unused.
1180
1181 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1182 (copy_keymap_item, append_key, push_text_char_description):
1183 Now static.
1184 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1185 (DENSE_TABLE_SIZE): Remove; unused.
1186 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1187 (describe_map_tree):
1188 Rename locals to avoid shadowing.
1189
1190 * keyboard.c: Declare functions static if they are not used elsewhere.
1191 (echo_char, echo_dash, cmd_error, top_level_2):
1192 (poll_for_input, handle_async_input): Now static.
1193 (read_char, kbd_buffer_get_event, make_lispy_position):
1194 (make_lispy_event, make_lispy_movement, apply_modifiers):
1195 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1196 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1197 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1198 (read_key_sequence, read_char): Mark locals as initialized.
1199 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1200
1201 * keyboard.h (make_ctrl_char): New decl.
1202 (mark_kboards): Move decl here ...
1203 * alloc.c (mark_kboards): ... from here.
1204
1205 * lisp.h (force_auto_save_soon): New decl.
1206
1207 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1208 (DEFINE_DUMMY_FUNCTION): New macro.
1209 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1210 Use it.
1211 (main): Add casts to avoid warnings
1212 if GCC considers string literals to be constants.
1213
1214 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1215
1216 * dbusbind.c: Pointer signedness fixes.
1217 (xd_signature, xd_append_arg, xd_initialize):
1218 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1219 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1220 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1221 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1222
1223 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1224 if GCC considers string literals to be constants.
1225 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1226
12272011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1228
1229 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1230 (print_preprocess, print_object): New macro to fix last change.
1231
1232 * print.c (print_preprocess): Don't forget font objects.
1233
12342011-03-16 Juanma Barranquero <lekktu@gmail.com>
1235
1236 * emacs.c (USAGE3): Doc fixes.
1237
12382011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1239
1240 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1241 structure.
1242
12432011-03-14 Juanma Barranquero <lekktu@gmail.com>
1244
1245 * lisp.h (VWindow_system, Qfile_name_history):
1246 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1247 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1248 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1249
1250 * w32select.c: Don't #include "keyboard.h".
1251 (run_protected): Add extern declaration for waiting_for_input.
1252
1253 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1254 * w32console.c (detect_input_pending, read_input_pending)
1255 (encode_terminal_code):
1256 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1257 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1258 (w32_system_caret_y, Qfile_name_history):
1259 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1260 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1261 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1262 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1263 * w32proc.c (Qlocal, report_file_error):
1264 * w32term.c (Vwindow_system, updating_frame):
1265 * w32uniscribe.c (initialized, uniscribe_font_driver):
1266 Remove unneeded extern declarations.
1267
12682011-03-14 Chong Yidong <cyd@stupidchicken.com>
1269
1270 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1271
12722011-03-13 Chong Yidong <cyd@stupidchicken.com>
1273
1274 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1275 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1276 These macros can no longer be used for assignment.
1277
1278 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1279 Assign struct members directly, instead of using BUF_BEGV etc.
1280 (record_buffer_markers, fetch_buffer_markers): New functions for
1281 recording and fetching special buffer markers.
1282 (set_buffer_internal_1, set_buffer_temp): Use them.
1283
1284 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1285
1286 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1287
1288 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1289 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1290
1291 * xdisp.c (hscroll_window_tree):
1292 (reconsider_clip_changes): Use PT instead of BUF_PT.
1293
12942011-03-13 Eli Zaretskii <eliz@gnu.org>
1295
1296 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1297 $(EMACS_ROOT)/lib/intprops.h.
1298
12992011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1300
1301 Fix more problems found by GCC 4.5.2's static checks.
1302
1303 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1304 to unsigned char * to avoid compiler diagnostic.
1305 (xg_free_frame_widgets): Make it clear that a local variable is
1306 needed only if USE_GTK_TOOLTIP.
1307 (gdk_window_get_screen): Make it clear that this macro is needed
1308 only if USE_GTK_TOOLTIP.
1309 (int_gtk_range_get_value): New function, which avoids a diagnostic
1310 from gcc -Wbad-function-cast.
1311 (xg_set_toolkit_scroll_bar_thumb): Use it.
1312 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1313 diagnostic from gcc -Wbad-function-cast.
1314 (get_utf8_string, xg_get_file_with_chooser):
1315 Rename locals to avoid shadowing.
1316 (create_dialog): Move locals to avoid shadowing.
1317
1318 * xgselect.c (xg_select): Remove unused var.
1319
1320 * image.c (four_corners_best): Mark locals as initialized.
1321 (gif_load): Initialize transparent_p to zero (Bug#8238).
1322 Mark another local as initialized.
1323 (my_png_error, my_error_exit): Mark with NO_RETURN.
1324
1325 * image.c (clear_image_cache): Now static.
1326 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1327 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1328 (x_edge_detection): Remove unnecessary cast that
1329 gcc -Wbad-function-cast diagnoses.
1330 (gif_load): Fix pointer signedness.
1331 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1332 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1333
13342011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1335
1336 Improve quality of tests for time stamp overflow.
1337 For example, without this patch (encode-time 0 0 0 1 1
1338 1152921504606846976) returns the obviously-bogus value (-948597
1339 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1340 reports time overflow. See
1341 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1342 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1343 * editfns.c: Include limits.h and intprops.h.
1344 (TIME_T_MIN, TIME_T_MAX): New macros.
1345 (time_overflow): Move earlier, to before first use.
1346 (hi_time, lo_time): New functions, for an accurate test for
1347 out-of-range times.
1348 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1349 (Fget_internal_run_time): Don't assume time_t fits in int.
1350 (make_time): Use list2 instead of Fcons twice.
1351 (Fdecode_time): More accurate test for out-of-range times.
1352 (check_tm_member): New function.
1353 (Fencode_time): Use it, to test for out-of-range times.
1354 (lisp_time_argument): Don't rely on undefined left-shift and
1355 right-shift behavior when checking for time stamp overflow.
1356
1357 * editfns.c (time_overflow): New function, refactoring common code.
1358 (Fformat_time_string, Fdecode_time, Fencode_time):
1359 (Fcurrent_time_string): Use it.
1360
1361 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1362 * dired.c (make_time): Move to ...
1363 * editfns.c (make_time): ... here.
1364 * systime.h: Note the move.
1365
13662011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1367
1368 * fringe.c (update_window_fringes): Remove unused variables.
1369
1370 * unexmacosx.c (copy_data_segment): Also copy __got section.
1371 (Bug#8223)
1372
13732011-03-12 Eli Zaretskii <eliz@gnu.org>
1374
1375 * termcap.c [MSDOS]: Include "msdos.h".
1376 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1377 Constify `char *' arguments and their references according to
1378 prototypes in tparam.h.
1379
1380 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1381
1382 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1383 Adapt all references accordingly.
1384
1385 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1386
13872011-03-11 Tom Tromey <tromey@redhat.com>
1388
1389 * buffer.c (syms_of_buffer): Remove obsolete comment.
1390
13912011-03-11 Eli Zaretskii <eliz@gnu.org>
1392
1393 * termhooks.h (encode_terminal_code): Declare prototype.
1394
1395 * msdos.c (encode_terminal_code): Don't declare prototype.
1396
1397 * term.c (encode_terminal_code): Now external again, used by
1398 w32console.c and msdos.c.
1399
1400 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1401 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1402
14032011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1404
1405 Fix some minor problems found by GCC 4.5.2's static checks.
1406
1407 * fringe.c (update_window_fringes): Mark locals as initialized
1408 (Bug#8227).
1409 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1410
1411 * alloc.c (mark_fringe_data): Move decl from here ...
1412 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1413 to check its interface.
1414 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1415
1416 * fontset.c (free_realized_fontset): Now static.
1417 (Fset_fontset_font): Rename local to avoid shadowing.
1418 (fontset_font): Mark local as initialized.
1419 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1420
1421 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1422
1423 * xselect.c (x_disown_buffer_selections): Remove; not used.
1424 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1425 (x_own_selection, Fx_disown_selection_internal): Rename locals
1426 to avoid shadowing.
1427 (x_handle_dnd_message): Remove local to avoid shadowing.
1428
1429 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1430 so that the caller can use some name other than gcpro1.
1431 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1432 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1433 (Fx_backspace_delete_keys_p):
1434 Use them to avoid shadowing, and rename vars to avoid shadowing.
1435 (x_decode_color, x_set_name, x_window): Now static.
1436 (Fx_create_frame): Add braces to silence GCC warning.
1437 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1438 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1439 Remove unused locals.
1440 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1441 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1442 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1443 macros.
1444
1445 * xterm.h (x_mouse_leave): New decl.
1446
1447 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1448 Remove unused functions.
1449 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1450 (x_calc_absolute_position): Now static.
1451 (XTread_socket): Don't define label "out" unless it's used.
1452 Don't declare local "event" unless it's used.
1453 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1454 unless they are used.
1455 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1456 (x_fatal_error_signal): Remove; not used.
1457 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1458 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1459 (x_error_catcher, x_connection_closed, x_error_handler):
1460 (x_error_quitter, xembed_send_message, x_iconify_frame):
1461 (my_log_handler): Rename locals to avoid shadowing.
1462 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1463 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1464
1465 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1466 Rename or move locals to avoid shadowing.
1467 (tty_defined_color, merge_face_heights): Now static.
1468 (free_realized_faces_for_fontset): Remove; not used.
1469 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1470 does not deduce is never used uninitialized.
1471 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1472 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1473
1474 * terminal.c (store_terminal_param): Now static.
1475
1476 * xmenu.c (menu_highlight_callback): Now static.
1477 (set_frame_menubar): Remove unused local.
1478 (xmenu_show): Rename parameter to avoid shadowing.
1479 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1480 since they might point to immutable storage.
1481 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1482 since it's unused otherwise.
1483
1484 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1485 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1486 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1487 avoids a gcc -Wuninitialized diagnostic.
1488 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1489 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1490 does not deduce are never used uninitialized.
1491
1492 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1493
1494 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1495 * window.c (window_loop, size_window):
1496 (run_window_configuration_change_hook, enlarge_window): Likewise.
1497
1498 * window.c (display_buffer): Now static.
1499 (size_window): Mark variables that gcc -Wuninitialized
1500 does not deduce are never used uninitialized.
1501 * window.h (check_all_windows): New decl, to forestall
1502 gcc -Wmissing-prototypes diagnostic.
1503 * dispextern.h (bidi_dump_cached_states): Likewise.
1504
1505 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1506 shadowing.
1507 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1508 Include <limits.h>.
1509 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1510 and to avoid gcc -Wuninitialized warning.
1511 (load_charset_map): Mark variables that gcc -Wuninitialized
1512 does not deduce are never used uninitialized.
1513 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1514
1515 * coding.c (coding_set_source, coding_set_destination):
1516 Use "else { /* comment */ }" rather than "else /* comment */;"
1517 for clarity, and to avoid gcc -Wempty-body warning.
1518 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1519 a block, when the outer 'i' will do.
1520 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1521 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1522 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1523 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1524 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1525 Rename locals to avoid shadowing.
1526 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1527 * coding.c (emacs_mule_char, encode_invocation_designation):
1528 Now static, since they're not used elsewhere.
1529 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1530 (decode_coding_object, encode_coding_object, detect_coding_system):
1531 (decode_coding_emacs_mule): Mark variables that gcc
1532 -Wuninitialized does not deduce are never used uninitialized.
1533 (detect_coding_iso_2022): Initialize a local variable that might
1534 be used uninitialized. Leave a FIXME because it's not clear that
1535 this initialization is needed. (Bug#8211)
1536 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1537 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1538 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1539 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1540 Remove unused macros.
1541
1542 * category.c (hash_get_category_set): Remove unused local var.
1543 (copy_category_table): Now static, since it's not used elsewhere.
1544 * character.c (string_count_byte8): Likewise.
1545
1546 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1547 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1548
1549 * chartab.c (copy_sub_char_table): Now static, since it's not used
1550 elsewhere.
1551 (sub_char_table_ref_and_range, char_table_ref_and_range):
1552 Rename locals to avoid shadowing.
1553 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1554
1555 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1556 (BIDI_BOB): Remove unused macro.
1557
1558 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1559 deduce are never used uninitialized.
1560 * term.c (encode_terminal_code): Likewise.
1561
1562 * term.c (encode_terminal_code): Now static. Remove unused local.
1563
1564 * tparam.h: New file.
1565 * term.c, tparam.h: Include it.
1566 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1567 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1568 Move these decls to tparam.h, and make them agree with what
1569 is actually in tparam.c. The previous trick of using incompatible
1570 decls in different modules does not conform to the C standard.
1571 All callers of tparam changed to use tparam's actual API.
1572 * tparam.c (tparam1, tparam, tgoto):
1573 Use const pointers where appropriate.
1574
1575 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1576 * cm.h (struct cm): Likewise.
1577 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1578 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1579 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1580 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1581 (turn_on_face, init_tty): Likewise.
1582 * termchar.h (struct tty_display_info): Likewise.
1583
1584 * term.c (term_mouse_position): Rename local to avoid shadowing.
1585
1586 * alloc.c (mark_ttys): Move decl from here ...
1587 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1588
15892011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1590
1591 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1592
15932011-03-09 Juanma Barranquero <lekktu@gmail.com>
1594
1595 * search.c (compile_pattern_1): Remove argument regp, unused since
1596 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1597 (compile_pattern): Don't pass it.
1598
15992011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1600
1601 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1602 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1603 for ! HAVE_GTK3.
1604 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1605
1606 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1607
1608 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1609 gdk_window_get_screen, gdk_window_get_geometry,
1610 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1611 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1612 (xg_get_pixbuf_from_pixmap): New function.
1613 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1614 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1615 Call xg_get_pixbuf_from_pixmap instead of
1616 gdk_pixbuf_get_from_drawable.
1617 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1618 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1619 (xg_check_special_colors): Use GtkStyleContext and its functions
1620 for HAVE_GTK3.
1621 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1622 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1623 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1624 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1625 Call gtk_widget_get_preferred_size.
1626 (xg_frame_resized): gdk_window_get_geometry only takes 5
1627 parameters.
1628 (xg_win_to_widget, xg_event_is_for_menubar):
1629 Call gdk_x11_window_lookup_for_display.
1630 (xg_set_widget_bg): New function.
1631 (delete_cb): New function.
1632 (xg_create_frame_widgets): connect delete-event to delete_cb.
1633 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1634 (xg_set_background_color): Call xg_set_widget_bg.
1635 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1636 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1637 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1638 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1639 if ! HAVE_GTK3.
1640 (update_frame_tool_bar): Call gtk_widget_hide.
1641 (xg_initialize): Use GDK_KEY_g.
1642
1643 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1644 if ! HAVE_GTK3
1645 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1646
1647 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1648 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1649 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1650
16512011-03-08 Juanma Barranquero <lekktu@gmail.com>
1652
1653 * w32xfns.c (select_palette): Check success of RealizePalette against
1654 GDI_ERROR, not zero.
1655
1656See ChangeLog.11 for earlier changes.
1657
1658;; Local Variables:
1659;; coding: utf-8
1660;; End:
1661
1662 Copyright (C) 2011 Free Software Foundation, Inc.
1663
1664 This file is part of GNU Emacs.
1665
1666 GNU Emacs is free software: you can redistribute it and/or modify
1667 it under the terms of the GNU General Public License as published by
1668 the Free Software Foundation, either version 3 of the License, or
1669 (at your option) any later version.
1670
1671 GNU Emacs is distributed in the hope that it will be useful,
1672 but WITHOUT ANY WARRANTY; without even the implied warranty of
1673 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1674 GNU General Public License for more details.
1675
1676 You should have received a copy of the GNU General Public License
1677 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.