* font.c (font_intern_prop): Don't assume string length fits in int.
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12011-06-20 Paul Eggert <eggert@cs.ucla.edu>
2
3 * font.c: Don't assume string length fits in int.
4 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5 Use ptrdiff_t, not int.
6 (font_intern_prop): Don't assume string length fits in int.
7 Don't assume integer property fits in fixnum.
8 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9
10 * filelock.c: Fix some buffer overrun and integer overflow issues.
11 (get_boot_time): Don't assume that gzip command string fits in 100 bytes.
12 Reformulate so as not to need the command string.
13 Invoke gzip -cd rather than gunzip, as it's more portable.
14 (lock_info_type, lock_file_1, lock_file):
15 Don't assume pid_t and time_t fit in unsigned long.
16 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
17 (current_lock_owner): Prefer signed type for sizes.
18 Use memcpy, not strncpy, where memcpy is what is really wanted.
19 Don't assume (via atoi) that time_t and pid_t fit in int.
20 Check for time_t and/or pid_t out of range, e.g., via a network share.
21 Don't alloca where an auto var works fine.
22
232011-06-19 Paul Eggert <eggert@cs.ucla.edu>
24
25 * fileio.c: Fix some integer overflow issues.
26 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
27 Don't assume string length fits in int.
28 (directory_file_name): Don't assume string length fits in long.
29 (make_temp_name): Don't assume pid fits in int, or that its print
30 length is less than 20.
31
32 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
33
34 * coding.c (make_subsidiaries): Don't assume string length fits in int.
35
36 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
37
38 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
39 We prefer signed integers, even for size calculations.
40
41 * emacs.c: Don't assume string length fits in 'int'.
42 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
43 (main): Don't invoke strlen when not needed.
44
45 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
46 (XD_DEBUG_MESSAGE): Don't waste a byte.
47
48 * callproc.c (getenv_internal_1, getenv_internal)
49 (Fgetenv_internal):
50 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
51
52 * lread.c (invalid_syntax): Omit length argument.
53 All uses changed. This doesn't fix a bug, but it simplifies the
54 code away from its former Hollerith-constant appearance, and it's
55 one less 'int' to worry about when looking at integer-overflow issues.
56 (string_to_number): Simplify the 2011-04-26 change by invoking xsignal1.
57
58 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
59 This didn't break anything, but it didn't help either.
60 It's confusing to put a bogus integer in a place where the actual
61 value does not matter.
62 (LIST_END_P): Remove unused macro and its bogus comment.
63 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
64
652011-06-18 Paul Eggert <eggert@cs.ucla.edu>
66
67 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
68 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
69 implementation.
70 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
71 We prefer signed types, and the value cannot exceed the EMACS_INT
72 range anyway (because otherwise the length would not be representable).
73 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
74 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
75 This avoids a GCC warning when WIDE_EMACS_INT.
76
77 * indent.c (sane_tab_width): New function.
78 (current_column, scan_for_column, Findent_to, position_indentation)
79 (compute_motion): Use it. This is just for clarity.
80 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
81
82 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
83
84 * lisp.h (lint_assume): New macro.
85 * composite.c (composition_gstring_put_cache):
86 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
87
88 * editfns.c, insdel.c:
89 Omit unnecessary forward decls, to simplify future changes.
90
91 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
92
93 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
94
95 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
96 Use much-faster test for byte-length change.
97 Don't assume string byte-length fits in 'int'.
98 Check that character arg fits in 'int'.
99 (mapcar1): Declare byte as byte, for clarity.
100
101 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
102
103 * fns.c (concat): Catch string overflow earlier.
104 Do not rely on integer wraparound.
105
106 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
107
1082011-06-17 Paul Eggert <eggert@cs.ucla.edu>
109
110 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
111 * xdisp.c (forward_to_next_line_start)
112 (back_to_previous_visible_line_start)
113 (reseat_at_next_visible_line_start, next_element_from_buffer):
114 Don't arbitrarily truncate the value of 'selective' to int.
115
116 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
117
118 * composite.c: Don't truncate sizes to 'int'.
119 (composition_gstring_p, composition_reseat_it)
120 (composition_adjust_point): Use EMACS_INT, not int.
121 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
122 not EMACS_UINT, for indexes.
123
124 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
125
126 * buffer.c: Include <verify.h>.
127 (struct sortvec.priority, struct sortstr.priority):
128 Now EMACS_INT, not int.
129 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
130 (struct sortstr.size, record_overlay_string)
131 (struct sortstrlist.size, struct sortlist.used):
132 Don't truncate size to int.
133 (record_overlay_string): Check for size-calculation overflow.
134 (init_buffer_once): Check at compile-time, not run-time.
135
1362011-06-16 Paul Eggert <eggert@cs.ucla.edu>
137
138 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
139 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
140 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
141
142 Improve buffer-overflow checking (Bug#8873).
143 * fileio.c (Finsert_file_contents):
144 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
145 Remove the old (too-loose) buffer overflow checks.
146 They weren't needed, since make_gap checks for buffer overflow.
147 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
148 The old code merely checked for Emacs fixnum overflow, and relied
149 on undefined (wraparound) behavior. The new code avoids undefined
150 behavior, and also checks for ptrdiff_t and/or size_t overflow.
151
152 * editfns.c (Finsert_char): Don't dump core with very negative counts.
153 Tune. Don't use wider integers than needed. Don't use alloca.
154 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
155
156 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
157
158 * insdel.c, lisp.h (buffer_overflow): New function.
159 (insert_from_buffer_1, replace_range, replace_range_2):
160 * insdel.c (make_gap_larger):
161 * editfns.c (Finsert_char):
162 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
163
164 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
165
1662011-06-15 Paul Eggert <eggert@cs.ucla.edu>
167
168 Integer overflow and signedness fixes (Bug#8873).
169
170 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
171 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
172
173 * fileio.c: Don't assume EMACS_INT fits in off_t.
174 (emacs_lseek): New static function.
175 (Finsert_file_contents, Fwrite_region): Use it.
176 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
177
178 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
179
180 * fns.c: Don't overflow int when computing a list length.
181 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
182 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
183 truncation on 64-bit hosts. Check for QUIT every
184 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
185 faster and is responsive enough.
186 (Flength): Report an error instead of overflowing an integer.
187 (Fsafe_length): Return a float if the value is not representable
188 as a fixnum. This shouldn't happen except in contrived situations.
189 (Fnthcdr, Fsort): Don't assume list length fits in int.
190 (Fcopy_sequence): Don't assume vector length fits in int.
191
192 * alloc.c: Check that resized vectors' lengths fit in fixnums.
193 (header_size, word_size): New constants.
194 (allocate_vectorlike): Don't check size overflow here.
195 (allocate_vector): Check it here instead, since this is the only
196 caller of allocate_vectorlike that could cause overflow.
197 Check that the new vector's length is representable as a fixnum.
198
199 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
200 The previous code was bogus. For example, next_almost_prime (32)
201 returned 39, which is undesirable as it is a multiple of 3; and
202 next_almost_prime (24) returned 25, which is a multiple of 5 so
203 why was the code bothering to check for multiples of 7?
204
205 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
206
207 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
208
209 Variadic C functions now count arguments with ptrdiff_t.
210 This partly undoes my 2011-03-30 change, which replaced int with size_t.
211 Back then I didn't know that the Emacs coding style prefers signed int.
212 Also, in the meantime I found a few more instances where arguments
213 were being counted with int, which may truncate counts on 64-bit
214 machines, or EMACS_INT, which may be unnecessarily wide.
215 * lisp.h (struct Lisp_Subr.function.aMANY)
216 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
217 Arg counts are now ptrdiff_t, not size_t.
218 All variadic functions and their callers changed accordingly.
219 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
220 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
221 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
222 * callint.c (Fcall_interactively): Check arg count for overflow,
223 to avoid potential buffer overrun. Use signed char, not 'int',
224 for 'varies' array, so that we needn't bother to check its size
225 calculation for overflow.
226 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
227 * eval.c (apply_lambda):
228 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
229 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
230 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
231
232 * callint.c (Fcall_interactively): Don't use index var as event count.
233
234 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
235 * mem-limits.h (SIZE): Remove; no longer used.
236
237 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
238
239 Remove unnecessary casts.
240 * xterm.c (x_term_init):
241 * xfns.c (x_set_border_pixel):
242 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
243 These aren't needed now that we assume ANSI C.
244
245 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
246 It's more likely to cause problems (due to unsigned overflow)
247 than to cure them.
248
249 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
250
251 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
252
253 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
254
255 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
256
257 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
258
259 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
260
261 GLYPH_CODE_FACE returns EMACS_INT, not int.
262 * dispextern.h (merge_faces):
263 * xfaces.c (merge_faces):
264 * xdisp.c (get_next_display_element, next_element_from_display_vector):
265 Don't assume EMACS_INT fits in int.
266
267 * character.h (CHAR_VALID_P): Remove unused parameter.
268 * fontset.c, lisp.h, xdisp.c: All uses changed.
269
270 * editfns.c (Ftranslate_region_internal): Omit redundant test.
271
272 * fns.c (concat): Minor tuning based on overflow analysis.
273 This doesn't fix any bugs. Use int to hold character, instead
274 of constantly refetching from Emacs object. Use XFASTINT, not
275 XINT, for value known to be a character. Don't bother comparing
276 a single byte to 0400, as it's always less.
277
278 * floatfns.c (Fexpt):
279 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
280
281 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
282 for characters.
283
284 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
285
286 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
287 Without this fix, on a 64-bit host (aset S 0 4294967386) would
288 incorrectly succeed when S was a string, because 4294967386 was
289 truncated before it was used.
290
291 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
292 Otherwise, an out-of-range integer could cause undefined behavior
293 on a 64-bit host.
294
295 * composite.c: Use int, not EMACS_INT, for characters.
296 (fill_gstring_body, composition_compute_stop_pos): Use int, not
297 EMACS_INT, for values that are known to be in character range.
298 This doesn't fix any bugs but is the usual style inside Emacs and
299 may generate better code on 32-bit machines.
300
301 Make sure a 64-bit char is never passed to ENCODE_CHAR.
302 This is for reasons similar to the recent CHAR_STRING fix.
303 * charset.c (Fencode_char): Check that character arg is actually
304 a character. Pass an int to ENCODE_CHAR.
305 * charset.h (ENCODE_CHAR): Verify that the character argument is no
306 wider than 'int', as a compile-time check to prevent future regressions
307 in this area.
308
309 * character.c (char_string): Remove unnecessary casts.
310
311 Make sure a 64-bit char is never passed to CHAR_STRING.
312 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
313 by silently ignoring the top 32 bits, allowing some values
314 that were far too large to be valid characters.
315 * character.h: Include <verify.h>.
316 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
317 arguments are no wider than unsigned, as a compile-time check
318 to prevent future regressions in this area.
319 * data.c (Faset):
320 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
321 (Fsubst_char_in_region):
322 * fns.c (concat):
323 * xdisp.c (decode_mode_spec_coding):
324 Adjust to CHAR_STRING's new requirement.
325 * editfns.c (Finsert_char, Fsubst_char_in_region):
326 * fns.c (concat): Check that character args are actually
327 characters. Without this test, these functions did the wrong
328 thing with wildly out-of-range values on 64-bit hosts.
329
330 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
331 These casts should not be needed on 32-bit hosts, either.
332 * keyboard.c (read_char):
333 * lread.c (Fload): Remove casts to unsigned.
334
335 * lisp.h (UNSIGNED_CMP): New macro.
336 This fixes comparison bugs on 64-bit hosts.
337 (ASCII_CHAR_P): Use it.
338 * casefiddle.c (casify_object):
339 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
340 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
341 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
342 * dispextern.h (FACE_FROM_ID):
343 * keyboard.c (read_char): Use UNSIGNED_CMP.
344
345 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
346 not to EMACS_INT, to avoid GCC warning.
347
348 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
349
350 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
351 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
352 isn't needed on 32-bit machines.
353
354 * buffer.c (Fgenerate_new_buffer_name):
355 Use EMACS_INT for count, not int.
356 (advance_to_char_boundary): Return EMACS_INT, not int.
357
358 * data.c (Qcompiled_function): Now static.
359
360 * window.c (window_body_lines): Now static.
361
362 * image.c (gif_load): Rename local to avoid shadowing.
363
364 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
365 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
366 * alloc.c (make_save_value): Integer argument is now of type
367 ptrdiff_t, not int.
368 (mark_object): Use ptrdiff_t, not int.
369 * lisp.h (pD): New macro.
370 * print.c (print_object): Use it.
371
372 * alloc.c: Use EMACS_INT, not int, to count objects.
373 (total_conses, total_markers, total_symbols, total_vector_size)
374 (total_free_conses, total_free_markers, total_free_symbols)
375 (total_free_floats, total_floats, total_free_intervals)
376 (total_intervals, total_strings, total_free_strings):
377 Now EMACS_INT, not int. All uses changed.
378 (Fgarbage_collect): Compute overall total using a double, so that
379 integer overflow is less likely to be a problem. Check for overflow
380 when converting back to an integer.
381 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
382 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
383 These were 'int' variables that could overflow on 64-bit hosts;
384 they were never used, so remove them instead of repairing them.
385 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
386 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
387 Previously, this ceilinged at INT_MAX, but that doesn't work on
388 64-bit machines.
389 (allocate_pseudovector): Don't use EMACS_INT when int would do.
390
391 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
392 (allocate_vectorlike): Check for ptrdiff_t overflow.
393 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
394 when a (possibly-narrower) signed value would do just as well.
395 We prefer using signed arithmetic, to avoid comparison confusion.
396
397 * alloc.c: Catch some string size overflows that we were missing.
398 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
399 for convenience in STRING_BYTES_MAX.
400 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
401 The definition here is exact; the one in lisp.h was approximate.
402 (allocate_string_data): Check for string overflow. This catches
403 some instances we weren't catching before. Also, it catches
404 size_t overflow on (unusual) hosts where SIZE_MAX <= min
405 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
406 and ptrdiff_t and EMACS_INT are both 64 bits.
407
408 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
409 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
410 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
411
412 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
413
414 * alloc.c (Fmake_string): Check for out-of-range init.
415
4162011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
417
418 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
419
4202011-06-14 Jan Djärv <jan.h.d@swipnet.se>
421
422 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
423 xg_get_default_scrollbar_width.
424
425 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
426 (int_gtk_range_get_value): Move to the scroll bar part of the file.
427 (style_changed_cb): Call update_theme_scrollbar_width and call
428 x_set_scroll_bar_default_width and xg_frame_set_char_size for
429 all frames (Bug#8505).
430 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
431 Call gtk_window_set_resizable if HAVE_GTK3.
432 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
433 and height if HAVE_GTK3 (Bug#8505).
434 (scroll_bar_width_for_theme): New variable.
435 (update_theme_scrollbar_width): New function.
436 (xg_get_default_scrollbar_width): Move code to
437 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
438 (xg_initialize): Call update_theme_scrollbar_width.
439
440 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
441
442 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
443
4442011-06-12 Martin Rudalics <rudalics@gmx.at>
445
446 * frame.c (make_frame): Call other_buffer_safely instead of
447 other_buffer.
448
449 * window.c (temp_output_buffer_show): Call display_buffer with
450 second argument Vtemp_buffer_show_specifiers and reset latter
451 immediately after the call.
452 (Vtemp_buffer_show_specifiers): New variable.
453 (auto_window_vscroll_p, next_screen_context_lines)
454 (Vscroll_preserve_screen_position): Remove leading asterisks from
455 doc-strings.
456
4572011-06-12 Paul Eggert <eggert@cs.ucla.edu>
458
459 Fix minor problems found by GCC 4.6.0 static checking.
460 * buffer.c (Qclone_number): Remove for now, as it's unused.
461 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
462 (record_buffer): Remove unused local.
463 * frame.c (other_visible_frames, frame_buffer_list): Now static.
464 (set_frame_buffer_list): Remove; unused.
465 * frame.h (other_visible_frames): Remove decl.
466 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
467 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
468 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
469 if HAVE_GPM.
470 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
471 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
472 Define only if HAVE_GPM.
473 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
474 (update_hints_inhibit): Remove; never set. All uses removed.
475 * widgetprv.h (emacsFrameClassRec): Remove decl.
476 * window.c (delete_deletable_window): Now returns void, since it
477 wasn't returning anything.
478 (compare_window_configurations): Remove unused locals.
479 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
480 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
481 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
482 the same widths as pointers. This follows up on the 2011-05-06 patch.
483 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
484 * xterm.h: Likewise.
485 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
486
4872011-06-12 Juanma Barranquero <lekktu@gmail.com>
488
489 * makefile.w32-in: Update dependencies.
490 (LISP_H): Add lib/intprops.h.
491
4922011-06-11 Chong Yidong <cyd@stupidchicken.com>
493
494 * image.c (gif_load): Add animation frame delay to the metadata.
495 (syms_of_image): Use DEFSYM. New symbol `delay'.
496
4972011-06-11 Martin Rudalics <rudalics@gmx.at>
498
499 * window.c (delete_deletable_window): Re-add.
500 (Fset_window_configuration): Rewrite to handle dead buffers and
501 consequently deletable windows.
502 (window_tree, Fwindow_tree): Remove. Supply functionality in
503 window.el.
504 (compare_window_configurations): Simplify code.
505
5062011-06-11 Andreas Schwab <schwab@linux-m68k.org>
507
508 * image.c (imagemagick_load_image): Fix type mismatch.
509 (Fimagemagick_types): Likewise.
510
511 * window.h (replace_buffer_in_windows): Declare.
512
5132011-06-11 Martin Rudalics <rudalics@gmx.at>
514
515 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
516 Qclone_number. Remove external declaration of Qdelete_window.
517 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
518 code.
519 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
520 Qbuffer_list_update_hook if allowed.
521 (Fother_buffer): Rewrite doc-string. Major rewrite for new
522 buffer list implementation.
523 (other_buffer_safely): New function.
524 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
525 calls to replace_buffer_in_windows and
526 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
527 if allowed.
528 (record_buffer): Inhibit quitting and rewrite using quittable
529 functions. Run Qbuffer_list_update_hook if allowed.
530 (Frecord_buffer, Funrecord_buffer): New functions.
531 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
532 switch-to-buffer to window.el.
533 (bury-buffer): Move to window.el.
534 (Vbuffer_list_update_hook): New variable.
535
536 * lisp.h (other_buffer_safely): Add prototype in buffer.c
537 section.
538
539 * window.h (resize_frame_windows): Move up in code.
540 (Fwindow_frame): Remove EXFUN.
541 (replace_buffer_in_all_windows): Remove prototype.
542 (replace_buffer_in_windows_safely): Add prototype.
543
544 * window.c: Declare Qdelete_window static again. Move down
545 declaration of select_count.
546 (Fnext_window, Fprevious_window): Rewrite doc-strings.
547 (Fother_window): Move to window.el.
548 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
549 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
550 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
551 window.el.
552 (replace_buffer_in_windows): Implement by calling
553 Qreplace_buffer_in_windows.
554 (replace_buffer_in_all_windows): Remove with some functionality
555 moved into replace_buffer_in_windows_safely.
556 (replace_buffer_in_windows_safely): New function.
557 (select_window_norecord, select_frame_norecord): Move in front
558 of run_window_configuration_change_hook. Remove now obsolete
559 declarations.
560 (Fset_window_buffer): Rewrite doc-string. Call
561 Qrecord_window_buffer.
562 (keys_of_window): Move binding for other-window to window.el.
563
5642011-06-11 Chong Yidong <cyd@stupidchicken.com>
565
566 * dispextern.h (struct image): Replace data member, whose int_val
567 and ptr_val fields were not used by anything, with a single
568 lisp_val object.
569
570 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
571 (gif_clear_image, gif_load, imagemagick_load_image)
572 (gs_clear_image, gs_load): Callers changed.
573
5742011-06-10 Paul Eggert <eggert@cs.ucla.edu>
575
576 * buffer.h: Include <time.h>, for time_t.
577 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
578
579 Fix minor problems found by static checking.
580
581 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
582
583 Make identifiers static if they are not used in other modules.
584 * data.c (Qcompiled_function, Qframe, Qvector):
585 * image.c (QimageMagick, Qsvg):
586 * minibuf.c (Qmetadata):
587 * window.c (resize_window_check, resize_root_window): Now static.
588 * window.h (resize_window_check, resize_root_window): Remove decls.
589
590 * window.c (window_deletion_count, delete_deletable_window):
591 Remove; unused.
592 (window_body_lines): Now static.
593 (Fdelete_other_windows_internal): Mark vars as initialized.
594 Make sure 'resize_failed' is initialized.
595 (run_window_configuration_change_hook): Rename local to avoid shadowing.
596 (resize_window_apply): Remove unused local.
597 * window.h (delete_deletable_window): Remove decl.
598
599 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
600 (imagemagick_load_image): Fix pointer signedness problem by changing
601 last arg from unsigned char * to char *. All uses changed.
602 Also, fix a local for similar reasons.
603 Remove unused locals. Remove locals to avoid shadowing.
604 (fn_rsvg_handle_free): Remove; unused.
605 (svg_load, svg_load_image): Fix pointer signedness problem.
606 (imagemagick_load_image): Don't use garbage pointer image_wand.
607
608 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
609
6102011-06-10 Chong Yidong <cyd@stupidchicken.com>
611
612 * image.c (gif_load): Fix omitted cast error introduced by
613 2011-06-06 change.
614
6152011-06-10 Martin Rudalics <rudalics@gmx.at>
616
617 * window.h (resize_proportionally, orig_total_lines)
618 (orig_top_line): Remove from window structure.
619 (set_window_height, set_window_width, change_window_heights)
620 (Fdelete_window): Remove prototypes.
621 (resize_frame_windows): Remove duplicate declaration.
622
6232011-06-10 Eli Zaretskii <eliz@gnu.org>
624
625 * window.h (resize_frame_windows, resize_window_check)
626 (delete_deletable_window, resize_root_window)
627 (resize_frame_windows): Declare prototypes.
628
629 * window.c (resize_window_apply): Make definition be "static" to
630 match the prototype.
631
6322011-06-10 Martin Rudalics <rudalics@gmx.at>
633
634 * window.c: Remove declarations of Qwindow_size_fixed,
635 window_min_size_1, window_min_size_2, window_min_size,
636 size_window, window_fixed_size_p, enlarge_window, delete_window.
637 Remove static from declaration of Qdelete_window, it's
638 temporarily needed by Fbury_buffer.
639 (replace_window): Don't assign orig_top_line and
640 orig_total_lines.
641 (Fdelete_window, delete_window): Remove. Window deletion is
642 handled by window.el.
643 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
644 Fdelete_window calls with calls to Qdelete_window.
645 (Fdelete_other_windows): Remove. Deleting other windows is
646 handled by window.el.
647 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
648 handled in window.el.
649 (window_min_size_2, window_min_size_1, window_min_size): Remove.
650 Window minimum sizes are handled in window.el.
651 (shrink_windows, size_window, set_window_height)
652 (set_window_width, change_window_heights, window_height)
653 (window_width, CURBEG, CURSIZE, enlarge_window)
654 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
655 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
656 handled in window.el.
657 (make_dummy_parent): Rename to make_parent_window and give it a
658 second argument horflag.
659 (make_window): Don't set resize_proportionally any more.
660 (Fsplit_window): Remove. Windows are split in window.el.
661 (save_restore_action, save_restore_orig_size)
662 (shrink_window_lowest_first, save_restore_orig_size): Remove.
663 Resize mini windows in window.el.
664 (grow_mini_window, shrink_mini_window): Implement by calling
665 Qresize_root_window_vertically, resize_window_check and
666 resize_window_apply.
667 (saved_window, Fset_window_configuration, save_window_save): Do
668 not handle orig_top_line, orig_total_lines, and
669 resize_proportionally.
670 (window_min_height, window_min_width): Move to window.el.
671 (keys_of_window): Move bindings for delete-other-windows,
672 split-window, delete-window and enlarge-window to window.el.
673
674 * buffer.c: Temporarily extern Qdelete_window.
675 (Fbury_buffer): Temporarily call Qdelete_window instead of
676 Fdelete_window (Fbury_buffer will move to window.el soon).
677
678 * frame.c (set_menu_bar_lines_1): Remove code handling
679 orig_top_line and orig_total_lines.
680
681 * dispnew.c (adjust_frame_glyphs_initially): Don't use
682 set_window_height but set heights directly.
683 (change_frame_size_1): Use resize_frame_windows.
684
685 * xdisp.c (init_xdisp): Don't use set_window_height but set
686 heights directly.
687
688 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
689 resize_frame_windows instead of change_window_heights and run
690 run_window_configuration_change_hook.
691
692 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
693 instead of change_window_heights and run
694 run_window_configuration_change_hook.
695
6962011-06-09 Martin Rudalics <rudalics@gmx.at>
697
698 * window.c (replace_window): Rename second argument REPLACEMENT to
699 NEW. New third argument SETFLAG. Rewrite.
700 (delete_window, make_dummy_parent): Call replace_window with
701 third argument 1.
702 (window_list_1): Move down in code.
703 (run_window_configuration_change_hook): Move set_buffer part
704 before select_frame_norecord part in order to unwind correctly.
705 Rename count1 to count.
706 (recombine_windows, delete_deletable_window, resize_root_window)
707 (Fdelete_other_windows_internal)
708 (Frun_window_configuration_change_hook, make_parent_window)
709 (resize_window_check, resize_window_apply, Fresize_window_apply)
710 (resize_frame_windows, Fsplit_window_internal)
711 (Fdelete_window_internal, Fresize_mini_window_internal): New
712 functions.
713 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
714
7152011-06-08 Martin Rudalics <rudalics@gmx.at>
716
717 * window.h (window): Add some new members to window structure -
718 normal_lines, normal_cols, new_total, new_normal, clone_number,
719 splits, nest, prev_buffers, next_buffers.
720 (WINDOW_TOTAL_SIZE): Move here from window.c.
721 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
722
723 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
724 Remove.
725 (make_dummy_parent): Set new members of windows structure.
726 (make_window): Move down in code. Handle new members of window
727 structure.
728 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
729 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
730 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
731 (Fset_window_prev_buffers, Fwindow_next_buffers)
732 (Fset_window_next_buffers, Fset_window_clone_number): New
733 functions.
734 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
735 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
736 Doc-string fixes.
737 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
738 Argument WINDOW can be now internal window too.
739 (Fwindow_use_time): Move up in code.
740 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
741 Rewrite doc-string.
742 (Fset_window_configuration, saved_window)
743 (Fcurrent_window_configuration, save_window_save): Handle new
744 members of window structure.
745 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
746 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
747 (syms_of_window): New Lisp objects Qrecord_window_buffer,
748 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
749 Qget_mru_window, Qresize_root_window,
750 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
751 Qauto_buffer_name; staticpro them.
752
7532011-06-07 Martin Rudalics <rudalics@gmx.at>
754
755 * window.c (Fwindow_total_size, Fwindow_left_column)
756 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
757 (Fwindow_list_1): New functions.
758 (window_box_text_cols): Replace with window_body_cols.
759 (Fwindow_width, Fscroll_left, Fscroll_right): Use
760 window_body_cols instead of window_box_text_cols.
761 (delete_window, Fset_window_configuration): Call
762 delete_all_subwindows with window as argument.
763 (delete_all_subwindows): Take a window as argument and not a
764 structure. Rewrite.
765 (window_loop): Remove handling of GET_LRU_WINDOW and
766 GET_LARGEST_WINDOW.
767 (Fget_lru_window, Fget_largest_window): Move to window.el.
768
769 * window.h: Extern window_body_cols instead of
770 window_box_text_cols. delete_all_subwindows now takes a
771 Lisp_Object as argument.
772
773 * indent.c (compute_motion, Fcompute_motion): Use
774 window_body_cols instead of window_box_text_cols.
775
776 * frame.c (delete_frame): Call delete_all_subwindows with root
777 window as argument.
778
7792011-06-07 Daniel Colascione <dan.colascione@gmail.com>
780
781 * fns.c (Fputhash): Document return value.
782
7832011-06-06 Chong Yidong <cyd@stupidchicken.com>
784
785 * image.c (gif_load): Implement gif89a spec "no disposal" method.
786
7872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
788
789 Cons<->int and similar integer overflow fixes (Bug#8794).
790
791 Check for overflow when converting integer to cons and back.
792 * charset.c (Fdefine_charset_internal, Fdecode_char):
793 Use cons_to_unsigned to catch overflow.
794 (Fencode_char): Use INTEGER_TO_CONS.
795 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
796 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
797 * data.c (long_to_cons, cons_to_long): Remove.
798 (cons_to_unsigned, cons_to_signed): New functions.
799 These signal an error for invalid or out-of-range values.
800 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
801 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
802 * font.c (Ffont_variation_glyphs):
803 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
804 * lisp.h: Include <intprops.h>.
805 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
806 (cons_to_signed, cons_to_unsigned): New decls.
807 (long_to_cons, cons_to_long): Remove decls.
808 * undo.c (record_first_change): Use INTEGER_TO_CONS.
809 (Fprimitive_undo): Use CONS_TO_INTEGER.
810 * xfns.c (Fx_window_property): Likewise.
811 * xselect.c: Include <limits.h>.
812 (x_own_selection, selection_data_to_lisp_data):
813 Use INTEGER_TO_CONS.
814 (x_handle_selection_request, x_handle_selection_clear)
815 (x_get_foreign_selection, Fx_disown_selection_internal)
816 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
817 (lisp_data_to_selection_data): Use cons_to_unsigned.
818 (x_fill_property_data): Use cons_to_signed.
819 Report values out of range.
820
821 Check for buffer and string overflow more precisely.
822 * buffer.h (BUF_BYTES_MAX): New macro.
823 * lisp.h (STRING_BYTES_MAX): New macro.
824 * alloc.c (Fmake_string):
825 * character.c (string_escape_byte8):
826 * coding.c (coding_alloc_by_realloc):
827 * doprnt.c (doprnt):
828 * editfns.c (Fformat):
829 * eval.c (verror):
830 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
831 since they may not be the same number.
832 * editfns.c (Finsert_char):
833 * fileio.c (Finsert_file_contents):
834 Likewise for BUF_BYTES_MAX.
835
836 * image.c: Use ptrdiff_t, not int, for sizes.
837 (slurp_file): Switch from int to ptrdiff_t.
838 All uses changed.
839 (slurp_file): Check that file size fits in both size_t (for
840 malloc) and ptrdiff_t (for sanity and safety).
841
842 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
843 if b->modtime has its maximal value.
844
845 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
846
847 Don't assume time_t can fit into int.
848 * buffer.h (struct buffer.modtime): Now time_t, not int.
849 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
850 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
851
852 Minor fixes for signed vs unsigned integers.
853 * character.h (MAYBE_UNIFY_CHAR):
854 * charset.c (maybe_unify_char):
855 * keyboard.c (read_char, reorder_modifiers):
856 XINT -> XFASTINT, since the integer must be nonnegative.
857 * ftfont.c (ftfont_spec_pattern):
858 * keymap.c (access_keymap, silly_event_symbol_error):
859 XUINT -> XFASTINT, since the integer must be nonnegative.
860 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
861 since it makes no difference and we prefer signed.
862 * keyboard.c (record_char): Use XUINT when all the neighbors do.
863 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
864 nonnegative.
865
8662011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
867
868 * window.h (Fwindow_frame): Declare.
869
8702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
871
872 * alloc.c: Simplify handling of large-request failures (Bug#8800).
873 (SPARE_MEMORY): Always define.
874 (LARGE_REQUEST): Remove.
875 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
876
8772011-06-06 Martin Rudalics <rudalics@gmx.at>
878
879 * lisp.h: Move EXFUNS for Fframe_root_window,
880 Fframe_first_window and Fset_frame_selected_window to window.h.
881
882 * window.h: Move EXFUNS for Fframe_root_window,
883 Fframe_first_window and Fset_frame_selected_window here from
884 lisp.h.
885
886 * frame.c (Fwindow_frame, Fframe_first_window)
887 (Fframe_root_window, Fframe_selected_window)
888 (Fset_frame_selected_window): Move to window.c.
889 (Factive_minibuffer_window): Move to minibuf.c.
890 (Fother_visible_frames_p): New function.
891
892 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
893
894 * window.c (decode_window, decode_any_window): Move up in code.
895 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
896 (inhibit_frame_unsplittable): Remove unused variable.
897 (Fwindow_buffer): Move up and rewrite doc-string.
898 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
899 (Fwindow_prev): New functions.
900 (Fwindow_frame): Move here from frame.c. Accept any window as
901 argument.
902 (Fframe_root_window, Fframe_first_window)
903 (Fframe_selected_window): Move here from frame.c. Accept frame
904 or arbitrary window as argument. Update doc-strings.
905 (Fminibuffer_window): Move up in code.
906 (Fwindow_minibuffer_p): Move up in code and simplify.
907 (Fset_frame_selected_window): Move here from frame.c.
908 Marginal rewrite.
909 (Fselected_window, select_window, Fselect_window): Move up in
910 code. Minor doc-string fixes.
911
9122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
913
914 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
915 Do not assume that spare memory exists; that assumption is valid
916 only if SYSTEM_MALLOC.
917 (LARGE_REQUEST): New macro, so that the issue of large requests
918 is separated from the issue of spare memory.
919
9202011-06-05 Andreas Schwab <schwab@linux-m68k.org>
921
922 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
923 format. (Bug#8806)
924
925 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
926
927 * xfns.c (x_set_scroll_bar_default_width): Move declarations
928 before statements.
929
9302011-06-05 Jan Djärv <jan.h.d@swipnet.se>
931
932 * gtkutil.c (xg_get_default_scrollbar_width): New function.
933
934 * gtkutil.h: Declare xg_get_default_scrollbar_width.
935
936 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
937 min width by calling x_set_scroll_bar_default_width (Bug#8505).
938
9392011-06-05 Juanma Barranquero <lekktu@gmail.com>
940
941 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
942
9432011-06-04 Chong Yidong <cyd@stupidchicken.com>
944
945 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
946 (x_clipboard_manager_save): Add return value.
947 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
948 New error handlers.
949 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
950 Obey Vx_select_enable_clipboard_manager. Catch errors in
951 x_clipboard_manager_save (Bug#8779).
952 (Vx_select_enable_clipboard_manager): New variable.
953 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
954
9552011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
956
957 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
958
9592011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
960
961 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
962 in the current matrix if keep_current_p is non-zero.
963
9642011-06-04 Eli Zaretskii <eliz@gnu.org>
965
966 * bidi.c (bidi_level_of_next_char): Fix last change.
967
9682011-06-03 Eli Zaretskii <eliz@gnu.org>
969
970 Support bidi reordering of text covered by display properties.
971
972 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
973 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
974 (bidi_cache_search, bidi_cache_iterator_state)
975 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
976 (bidi_level_of_next_char, bidi_move_to_visually_next):
977 Support character positions inside a run of characters covered by a
978 display string.
979 (bidi_paragraph_init, bidi_resolve_explicit_1)
980 (bidi_level_of_next_char): Call bidi_fetch_char and
981 bidi_fetch_char_advance instead of FETCH_CHAR and
982 FETCH_CHAR_ADVANCE.
983 (bidi_init_it): Initialize new members.
984 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
985 definitions.
986 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
987 instead of using explicit *_CHAR codes.
988 (bidi_resolve_explicit, bidi_resolve_weak):
989 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
990 bidirectional text is supported only in multibyte buffers.
991 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
992 it to initialize the frame_window_p member of struct bidi_it.
993 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
994 (bidi_resolve_explicit, bidi_resolve_weak)
995 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
996 bidi_it->nchars is non-positive.
997 (bidi_level_of_next_char): Don't try to lookup the cache for the
998 next/previous character if nothing is cached there yet, or if we
999 were just reseat()'ed to a new position.
1000
1001 * xdisp.c (set_cursor_from_row): Set start and stop points
1002 according to the row's direction when priming the loop that looks
1003 for the glyph on which to display cursor.
1004 (single_display_spec_intangible_p): Function deleted.
1005 (display_prop_intangible_p): Reimplement to call
1006 handle_display_spec instead of single_display_spec_intangible_p.
1007 Accept 3 additional arguments needed by handle_display_spec.
1008 This fixes incorrect cursor motion across display property with complex
1009 values: lists, `(when COND...)' forms, etc.
1010 (single_display_spec_string_p): Support property values that are
1011 lists with the argument STRING its top-level element.
1012 (display_prop_string_p): Fix the condition for processing a
1013 property that is a list to be consistent with handle_display_spec.
1014 (handle_display_spec): New function, refactored from the
1015 last portion of handle_display_prop.
1016 (compute_display_string_pos): Accept additional argument
1017 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1018 value of a `display' property is a "replacing spec".
1019 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1020 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1021 the display property, but just return a value indicating whether
1022 the display property will replace the characters it covers.
1023 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1024 frame_window_p members of struct bidi_it.
1025 (compute_display_string_pos, compute_display_string_end):
1026 New functions.
1027 (push_it): Accept second argument POSITION, where pop_it should
1028 jump to continue iteration.
1029 (reseat_1): Initialize bidi_it.disp_pos.
1030
1031 * keyboard.c (adjust_point_for_property): Adjust the call to
1032 display_prop_intangible_p to its new signature.
1033
1034 * dispextern.h (struct bidi_it): New member frame_window_p.
1035 (bidi_init_it): Update prototypes.
1036 (display_prop_intangible_p): Update prototype.
1037 (compute_display_string_pos, compute_display_string_end):
1038 Declare prototypes.
1039 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1040 EMACS_INT.
1041
10422011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1043
1044 Malloc failure behavior now depends on size of allocation.
1045 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1046 * lisp.h: Change signatures accordingly.
1047 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1048 All callers changed. (Bug#8762)
1049
1050 * gnutls.c: Use Emacs's memory allocators.
1051 Without this change, the gnutls library would invoke malloc etc.
1052 directly, which causes problems on non-SYNC_INPUT hosts, and which
1053 runs afoul of improving memory_full behavior. (Bug#8761)
1054 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1055 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1056 xfree instead of the default malloc, realloc, free.
1057 (Fgnutls_boot): No need to check for memory allocation failure,
1058 since xmalloc does that for us.
1059
1060 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1061 * category.c (hash_get_category_set):
1062 * ccl.c (ccl_driver):
1063 * charset.c (Fdefine_charset_internal):
1064 * charset.h (struct charset.hash_index):
1065 * composite.c (get_composition_id, gstring_lookup_cache)
1066 (composition_gstring_put_cache):
1067 * composite.h (struct composition.hash_index):
1068 * dispextern.h (struct image.hash):
1069 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1070 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1071 (hashfn_equal, hashfn_user_defined, make_hash_table)
1072 (maybe_resize_hash_table, hash_lookup, hash_put)
1073 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1074 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1075 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1076 * image.c (make_image, search_image_cache, lookup_image)
1077 (xpm_put_color_table_h):
1078 * lisp.h (struct Lisp_Hash_Table):
1079 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1080 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1081 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1082 * alloc.c (allocate_vectorlike):
1083 Check for overflow in vector size calculations.
1084 * ccl.c (ccl_driver):
1085 Check for overflow when converting EMACS_INT to int.
1086 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1087 need to be updated by these changes.
1088 * fns.c (make_hash_table, maybe_resize_hash_table):
1089 Check for integer overflow with large hash tables.
1090 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1091 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1092 (SXHASH_REDUCE): New macro.
1093 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1094 Use it instead of discarding useful hash info with large hash values.
1095 (sxhash_float): New function.
1096 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1097 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1098 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1099 Rewrite to use FIXNUM_BITS, as this simplifies things.
1100 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1101 Adjust signatures to match updated version of code.
1102 (consing_since_gc): Now EMACS_INT, since a single hash table can
1103 use more than INT_MAX bytes.
1104
11052011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1106
1107 Make it possible to build with GCC-4.6+ -O2 -flto.
1108
1109 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1110
11112011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1112
1113 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1114 Call minibuffer-inactive-mode.
1115
11162011-05-31 Juanma Barranquero <lekktu@gmail.com>
1117
1118 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1119 Update dependencies.
1120
11212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1122
1123 * data.c (init_data): Remove code for UTS, this system is not
1124 supported anymore.
1125
11262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1127
1128 Don't force ./temacs to start in terminal mode.
1129
1130 * frame.c (make_initial_frame): Initialize faces in all cases, not
1131 only when CANNOT_DUMP is defined.
1132 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1133
11342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1135
1136 * dispnew.c (add_window_display_history): Use const for the string
1137 pointer. Remove declaration, not needed.
1138
11392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1140
1141 Use 'inline', not 'INLINE'.
1142 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1143 * alloc.c, fontset.c (INLINE): Remove.
1144 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1145 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1146 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1147 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1148 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1149
11502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1151
1152 Make it possible to run ./temacs.
1153
1154 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1155 syms_of_callproc does the same thing. Remove test for
1156 "initialized", do it in the caller.
1157 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1158
11592011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1160
1161 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1162 (read_minibuf): Use get_minibuffer.
1163 (syms_of_minibuf): Use DEFSYM.
1164 (Qmetadata): New var.
1165 * data.c (Qbuffer): Don't make it static.
1166 (syms_of_data): Use DEFSYM.
1167
11682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1169
1170 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1171 (CCL_CODE_MIN): New macro.
1172
11732011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1176
1177 * eval.c (Qdebug): Now static.
1178 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1179 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1180 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1181
11822011-05-29 Chong Yidong <cyd@stupidchicken.com>
1183
1184 * image.c: Various fixes to ImageMagick code comments.
1185 (Fimagemagick_types): Doc fix.
1186
11872011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1188
1189 Minor fixes prompted by GCC 4.6.0 warnings.
1190
1191 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1192
1193 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1194 (x_clipboard_manager_save_all): Move extern decl to ...
1195 * xterm.h: ... here, so that it can be checked for consistency.
1196
11972011-05-29 Chong Yidong <cyd@stupidchicken.com>
1198
1199 * xselect.c (x_clipboard_manager_save_frame)
1200 (x_clipboard_manager_save_all): New functions.
1201 (Fx_clipboard_manager_save): Lisp function deleted.
1202
1203 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1204 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1205
1206 * xterm.h: Update prototype.
1207
12082011-05-28 William Xu <william.xwl@gmail.com>
1209
1210 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1211 exiting (Bug#8239).
1212
12132011-05-28 Jim Meyering <meyering@redhat.com>
1214
1215 Avoid a sign-extension bug in crypto_hash_function.
1216 * fns.c (to_uchar): Define.
1217 (crypto_hash_function): Use it to convert some newly-signed
1218 variables to unsigned, to avoid sign-extension bugs. For example,
1219 without this change, (md5 "truc") would evaluate to
1220 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1221 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1222 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1223
12242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 Integer overflow fixes.
1227
1228 * dbusbind.c: Serial number integer overflow fixes.
1229 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1230 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1231 to hold a serial number that is too large for a fixnum.
1232 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1233 Check for serial numbers out of range. Decode any serial number
1234 that was so large that it became a float. (Bug#8722)
1235
1236 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1237 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1238 Use XFASTINT rather than XUINT when numbers are nonnegative.
1239 (xd_append_arg, Fdbus_method_return_internal):
1240 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1241 arguments, check that Lisp number is nonnegative, rather than
1242 silently wrapping negative numbers around. (Bug#8722)
1243 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1244 (Bug#8722)
1245
1246 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1247
1248 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1249
1250 ccl: add integer overflow checks
1251 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1252 (IN_INT_RANGE): New macros.
1253 (ccl_driver): Use them to check for integer overflow when
1254 decoding a CCL program. Many of the new checks are whether XINT (x)
1255 fits in int; it doesn't always, on 64-bit hosts. The new version
1256 doesn't catch all possible integer overflows, but it's an
1257 improvement. (Bug#8719)
1258
1259 * alloc.c (make_event_array): Use XINT, not XUINT.
1260 There's no need for unsigned here.
1261
1262 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1263 This follows up to the 2011-05-06 change that substituted uintptr_t
1264 for EMACS_INT. This case wasn't caught back then.
1265
1266 Rework Fformat to avoid integer overflow issues.
1267 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1268 now (part of C89). Include <verify.h>.
1269 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1270 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1271 (Fformat): Avoid the prepass trying to compute sizes; it was only
1272 approximate and thus did not catch overflow reliably. Instead, walk
1273 through the format just once, formatting and computing sizes as we go,
1274 checking for integer overflow at every step, and allocating a larger
1275 buffer as needed. Keep track separately whether the format is
1276 multibyte. Keep only the most-recently calculated precision, rather
1277 than them all. Record whether each argument has been converted to
1278 string. Use EMACS_INT, not int, for byte and char and arg counts.
1279 Support field widths and precisions larger than INT_MAX. Avoid
1280 sprintf's undefined behavior with conversion specifications such as %#d
1281 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1282 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1283 formatting out-of-range floating point numbers with int
1284 formats. (Bug#8668)
1285
1286 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1287
1288 * data.c: Avoid integer truncation in expressions involving floats.
1289 * data.c: Include <intprops.h>.
1290 (arith_driver): When there's an integer overflow in an expression
1291 involving floating point, convert the integers to floating point
1292 so that the resulting value does not suffer from catastrophic
1293 integer truncation. For example, on a 64-bit host (* 4
1294 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1295 Do not rely on undefined behavior after integer overflow.
1296
1297 merge count_size_as_multibyte, parse_str_to_multibyte
1298 * character.c, character.h (count_size_as_multibyte):
1299 Rename from parse_str_to_multibyte; all uses changed.
1300 Check for integer overflow.
1301 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1302 since it's now a duplicate of the other. This is more of
1303 a character than a buffer op, so better that it's in character.c.
1304 * fns.c, print.c: Adjust to above changes.
1305
13062011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1307
1308 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1309
13102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1311
1312 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1313 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1314 (x_clipboard_manager_save): Now static.
1315 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1316
1317 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1318 (crypto_hash_function): Now static.
1319 Fix pointer signedness problems. Avoid unnecessary initializations.
1320
13212011-05-27 Chong Yidong <cyd@stupidchicken.com>
1322
1323 * termhooks.h (Vselection_alist): Make it terminal-local.
1324
1325 * terminal.c (create_terminal): Initialize it.
1326
1327 * xselect.c: Support for clipboard managers.
1328 (Vselection_alist): Move to termhooks.h as terminal-local var.
1329 (LOCAL_SELECTION): New macro.
1330 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1331 (symbol_to_x_atom): Remove gratuitous arg.
1332 (x_handle_selection_request, lisp_data_to_selection_data)
1333 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1334 (x_own_selection, x_get_local_selection, x_convert_selection):
1335 New arg, specifying work frame. Use terminal-local Vselection_alist.
1336 (some_frame_on_display): Delete unused function.
1337 (Fx_own_selection_internal, Fx_get_selection_internal)
1338 (Fx_disown_selection_internal, Fx_selection_owner_p)
1339 (Fx_selection_exists_p): New optional frame arg.
1340 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1341 (x_handle_selection_clear): Don't treat other terminals with the
1342 same keyboard specially. Use the terminal-local Vselection_alist.
1343 (x_clear_frame_selections): Use Frun_hook_with_args.
1344
1345 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1346
1347 * xterm.h: Add support for those atoms.
1348
13492011-05-26 Chong Yidong <cyd@stupidchicken.com>
1350
1351 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1352 (converted_selections, conversion_fail_tag): New global variables.
1353 (x_selection_request_lisp_error): Free the above.
1354 (x_get_local_selection): Remove unnecessary code.
1355 (x_reply_selection_request): Args changed; handle arbitrary array
1356 of converted selections stored in converted_selections.
1357 Separate the XChangeProperty and SelectionNotify steps.
1358 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1359 (x_convert_selection): New function.
1360 (x_handle_selection_event): Simplify.
1361 (x_get_foreign_selection): Don't ignore incoming requests while
1362 waiting for an answer; this will fail when we implement
1363 SAVE_TARGETS, and seems unnecessary anyway.
1364 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1365 (Vx_sent_selection_functions): Doc fix.
1366
13672011-05-26 Leo Liu <sdl.web@gmail.com>
1368
1369 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1370
13712011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1372
1373 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1374
1375 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1376 for fringe update if it has periodic bitmap.
1377 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1378 and fringe_bitmap_periodic_p.
1379
1380 * fringe.c (get_fringe_bitmap_data): New function.
1381 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1382 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1383 row. Mark glyph row for fringe update if periodicity changed.
1384
1385 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1386 for fringe update unless it has periodic bitmap.
1387
13882011-05-25 Kenichi Handa <handa@m17n.org>
1389
1390 * xdisp.c (get_next_display_element): Set correct it->face_id for
1391 a static composition.
1392
13932011-05-24 Leo Liu <sdl.web@gmail.com>
1394
1395 * deps.mk (fns.o):
1396 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1397
1398 * fns.c (crypto_hash_function, Fsha1): New function.
1399 (Fmd5): Use crypto_hash_function.
1400 (syms_of_fns): Add Ssha1.
1401
14022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1403
1404 * gnutls.c: Remove unused macros.
1405 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1406 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1407 Remove macros that are defined and never used.
1408 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1409
14102011-05-22 Chong Yidong <cyd@stupidchicken.com>
1411
1412 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1413 (Fx_get_selection_internal): Minor cleanup.
1414 (Fx_own_selection_internal): Rename arguments for consistency with
1415 select.el.
1416
14172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1418
1419 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1420
14212011-05-22 Chong Yidong <cyd@stupidchicken.com>
1422
1423 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1424
14252011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1426
1427 * dispnew.c (scrolling_window): Don't exclude the case that the
1428 last enabled row in the desired matrix touches the bottom boundary.
1429
14302011-05-21 Glenn Morris <rgm@gnu.org>
1431
1432 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1433 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1434 and add some more files.
1435
14362011-05-20 Eli Zaretskii <eliz@gnu.org>
1437
1438 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1439 report_file_error introduced by the change from 2011-05-07.
1440
14412011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1442
1443 * systime.h (Time): Define only if emacs is defined.
1444 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1445 where the include path doesn't have X11/X.h by default. See
1446 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1447
14482011-05-20 Kenichi Handa <handa@m17n.org>
1449
1450 * composite.c (find_automatic_composition): Fix previous change.
1451
14522011-05-20 Glenn Morris <rgm@gnu.org>
1453
1454 * lisp.mk: New file, split from Makefile.in.
1455 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1456 (shortlisp): Remove.
1457 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1458
14592011-05-19 Glenn Morris <rgm@gnu.org>
1460
1461 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1462 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1463 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1464 (lisp): Set the order to that of loadup.el.
1465 (shortlisp): Make it a copy of $lisp.
1466 (SOME_MACHINE_LISP): Remove.
1467 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1468 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1469
14702011-05-18 Kenichi Handa <handa@m17n.org>
1471
1472 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1473 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1474 (find_automatic_composition): Mostly rewrite for efficiency.
1475
14762011-05-18 Juanma Barranquero <lekktu@gmail.com>
1477
1478 * makefile.w32-in: Update dependencies.
1479
14802011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1481
1482 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1483 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1484
14852011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 Fix some integer overflow issues, such as string length overflow.
1488
1489 * insdel.c (count_size_as_multibyte): Check for string overflow.
1490
1491 * character.c (lisp_string_width): Check for string overflow.
1492 Use EMACS_INT, not int, for string indexes and lengths; in
1493 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1494 the resulting string length overflows an EMACS_INT; instead,
1495 report a string overflow if no precision given. When checking for
1496 precision exhaustion, use a check that cannot possibly have
1497 integer overflow. (Bug#8675)
1498 * character.h (lisp_string_width): Adjust to new signature.
1499
1500 * alloc.c (string_overflow): New function.
1501 (Fmake_string): Use it. This doesn't change behavior, but saves
1502 a few bytes and will simplify future changes.
1503 * character.c (string_escape_byte8): Likewise.
1504 * lisp.h (string_overflow): New decl.
1505
1506 Fixups, following up to the user-interface timestamp change.
1507 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1508 for UI timestamps, instead of unsigned long.
1509 * msdos.c (mouse_get_pos): Likewise.
1510 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1511 * w32gui.h (Time): Define by including "systime.h" rather than by
1512 declaring it ourselves. (Bug#8664)
1513
1514 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1515 * image.c (clear_image_cache): Likewise.
1516
1517 * term.c (term_mouse_position): Don't assume time_t wraparound.
1518
1519 Be more systematic about user-interface timestamps.
1520 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1521 and sometimes 'EMACS_UINT', to represent these timestamps.
1522 This change causes it to use 'Time' uniformly, as that's what X uses.
1523 This makes the code easier to follow, and makes it easier to catch
1524 integer overflow bugs such as Bug#8664.
1525 * frame.c (Fmouse_position, Fmouse_pixel_position):
1526 Use Time, not unsigned long, for user-interface timestamps.
1527 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1528 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1529 * keyboard.h (last_event_timestamp): Likewise.
1530 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1531 * menu.h (xmenu_show): Likewise.
1532 * term.c (term_mouse_position): Likewise.
1533 * termhooks.h (struct input_event.timestamp): Likewise.
1534 (struct terminal.mouse_position_hook): Likewise.
1535 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1536 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1537 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1538 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1539 what it was before.
1540 * menu.h, termhooks.h: Include "systime.h", for Time.
1541
1542 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1543 Don't assume that the difference between two unsigned long values
1544 can fit into an integer. At this point, we know button_down_time
1545 <= event->timestamp, so the difference must be nonnegative, so
1546 there's no need to cast the result if double-click-time is
1547 nonnegative, as it should be; check that it's nonnegative, just in
1548 case. This bug is triggered when events are more than 2**31 ms
1549 apart (about 25 days). (Bug#8664)
1550
1551 * xselect.c (last_event_timestamp): Remove duplicate decl.
1552 (x_own_selection): Remove needless cast to unsigned long.
1553
1554 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1555 that always fit in int. Use a sentinel instead of a counter, to
1556 avoid a temp and to allay GCC's concerns about possible int overflow.
1557 * frame.h (struct frame): Use int for menu_bar_items_used
1558 instead of EMACS_INT, since it always fits in int.
1559
1560 * menu.c (grow_menu_items): Check for int overflow.
1561
1562 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1563
1564 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1565 Before, the code was not consistent. These values cannot exceed
1566 2**31 - 1 so there's no need to make them unsigned.
1567 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1568 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1569 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1570 as modifiers.
1571 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1572
1573 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1574 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1575 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1576 presumably because the widths might not match.
1577
1578 * window.c (size_window): Avoid needless test at loop start.
1579
15802011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1581
1582 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1583
15842011-05-12 Drew Adams <drew.adams@oracle.com>
1585
1586 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1587
15882011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1589
1590 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1591 `width' to `bar_area_x' and `bar_area_width', respectively.
1592 (x_scroll_run): Take account of fringe background extension.
1593
1594 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1595 Rename local vars `left' and `width' to `bar_area_x' and
1596 `bar_area_width', respectively.
1597 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1598 background extension.
1599
16002011-05-10 Jim Meyering <meyering@redhat.com>
1601
1602 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1603
16042011-05-10 Juanma Barranquero <lekktu@gmail.com>
1605
1606 * image.c (Finit_image_library): Return t for built-in image types,
1607 like pbm and xbm. (Bug#8640)
1608
16092011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1610
1611 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1612
16132011-05-07 Eli Zaretskii <eliz@gnu.org>
1614
1615 * w32console.c (Fset_screen_color): Doc fix.
1616 (Fget_screen_color): New function.
1617 (syms_of_ntterm): Defsubr it.
1618
1619 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1620 unlink the temporary file if Fcall_process didn't create it in the
1621 first place.
1622 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1623 child process will be redirected to a file specified with `:file'.
1624 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1625 cue to call_process_cleanup not to close that handle.
1626
16272011-05-07 Ben Key <bkey76@gmail.com>
1628
1629 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1630 one of two shell specific rules, either bootstrap-temacs-CMD or
1631 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1632 to the previous implementation of the bootstrap-temacs rule.
1633 The bootstrap-temacs-CMD rule is similar to the previous
1634 implementation of the bootstrap-temacs rule except that it
1635 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1636 variable.
1637
1638 These changes, along with some changes to nt/configure.bat,
1639 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1640 earlier fix to add support for --cflags and --ldflags options
1641 that include quotes so that it works whether make uses cmd or
1642 sh as the shell.
1643
16442011-05-06 Michael Albinus <michael.albinus@gmx.de>
1645
1646 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1647 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1648 is a constant.
1649 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1650 a string. Handle both cases.
1651 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1652 (Fdbus_register_method): Use Qinvalid_function.
1653
16542011-05-06 Juanma Barranquero <lekktu@gmail.com>
1655
1656 * makefile.w32-in: Update dependencies.
1657 (LISP_H): Add inttypes.h and stdin.h.
1658 (PROCESS_H): Add unistd.h.
1659
16602011-05-06 Eli Zaretskii <eliz@gnu.org>
1661
1662 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1663 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1664
16652011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1666
1667 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1668
1669 * term.c (vfatal): Remove stray call to va_end.
1670 It's not needed and the C Standard doesn't allow it here anyway.
1671
1672 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1673 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1674
1675 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1676 bytes.
1677
1678 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1679
1680 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1681
1682 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1683
1684 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1685
1686 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1687
1688 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1689 * charset.c (Fdefine_charset_internal): Don't initialize
1690 charset.code_space[15]. The value was garbage, on hosts with
1691 32-bit int (Bug#8600).
1692
1693 * lread.c (read_integer): Be more consistent with string-to-number.
1694 Use string_to_number to do the actual conversion; this avoids
1695 rounding errors and fixes some other screwups. Without this fix,
1696 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1697 (digit_to_number): Move earlier, for benefit of read_integer.
1698 Return -1 if the digit is out of range for the base, -2 if it is
1699 not a digit in any supported base. (Bug#8602)
1700
1701 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1702
1703 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1704 to match comment at start of function. This also removes a
1705 GCC warning about overflow in a 32+64-bit port.
1706
1707 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1708
1709 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1710 Reported by Stefan Monnier in
1711 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1712 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1713 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1714
1715 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1716 (EMACS_UINTPTR): Likewise, with uintptr_t.
1717
1718 * lisp.h: Prefer 64-bit EMACS_INT if available.
1719 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1720 on 32-bit hosts that have 64-bit int, so that they can access
1721 large files.
1722 However, temporarily disable this change unless the temporary
1723 symbol WIDE_EMACS_INT is defined.
1724
1725 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1726
1727 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1728 This removes an assumption that EMACS_INT and long are the same
1729 width as pointers. The assumption is true for Emacs porting targets
1730 now, but we want to make other targets possible.
1731 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1732 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1733 In the rest of the code, change types of integers that hold casted
1734 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1735 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1736 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1737 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1738 No need to cast type when ORing.
1739 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1740 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1741 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1742 assume EMACS_INT is the same width as char *.
1743 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1744 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1745 Remove no-longer-needed casts.
1746 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1747 (xg_tool_bar_help_callback, xg_make_tool_item):
1748 Use EMACS_INTPTR to hold an integer
1749 that will be cast to void *; this can avoid a GCC warning
1750 if EMACS_INT is not the same width as void *.
1751 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1752 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1753 (current_message_1, set_message_1):
1754 Use a local to convert to proper width without a cast.
1755 * xmenu.c (dialog_selection_callback): Likewise.
1756
1757 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1758 Also, don't assume VALBITS / RAND_BITS is less than 5,
1759 and don't rely on undefined behavior when shifting a 1 left into
1760 the sign bit.
1761 * lisp.h (get_random): Change signature to match.
1762
1763 * lread.c (hash_string): Use size_t, not int, for hash computation.
1764 Normally we prefer signed values; but hashing is special, because
1765 it's better to use unsigned division on hash table sizes so that
1766 the remainder is nonnegative. Also, size_t is the natural width
1767 for hashing into memory. The previous code used 'int', which doesn't
1768 retain enough info to hash well into very large tables.
1769 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1770
1771 * dbusbind.c: Don't possibly lose pointer info when converting.
1772 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1773 Use XPNTR rather than XHASH, so that the high-order bits of
1774 the pointer aren't lost when converting through void *.
1775
1776 * eval.c (Fautoload): Don't double-shift a pointer.
1777
1778 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1779
17802011-05-06 Juanma Barranquero <lekktu@gmail.com>
1781
1782 * gnutls.c (DEF_GNUTLS_FN):
1783 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1784
17852011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1786
1787 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1788 marker. (Bug#8610)
1789
17902011-05-05 Eli Zaretskii <eliz@gnu.org>
1791
1792 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1793 New version that can reserve upto 2GB of heap space.
1794
17952011-05-05 Chong Yidong <cyd@stupidchicken.com>
1796
1797 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1798
17992011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1800
1801 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1802 `gnutls_certificate_set_x509_key_file'.
1803
18042011-05-05 Juanma Barranquero <lekktu@gmail.com>
1805
1806 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1807 Update dependencies.
1808
18092011-05-04 Juanma Barranquero <lekktu@gmail.com>
1810
1811 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1812 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1813 Remove unused parameter `fildes'.
1814 * process.c (read_process_output, send_process): Don't pass it.
1815
18162011-05-04 Juanma Barranquero <lekktu@gmail.com>
1817
1818 Fix previous change: the library cache is defined in w32.c.
1819 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1820 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1821
18222011-05-04 Juanma Barranquero <lekktu@gmail.com>
1823
1824 Implement dynamic loading of GnuTLS on Windows.
1825
1826 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1827 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1828 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1829 Declare.
1830
1831 * gnutls.c (Qgnutls_dll): Define.
1832 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1833 (gnutls_*): Declare function pointers.
1834 (init_gnutls_functions): New function to initialize function pointers.
1835 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1836 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1837 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1838 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1839 (emacs_gnutls_write, emacs_gnutls_read)
1840 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1841 (Fgnutls_available_p): New function.
1842 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1843 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1844 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1845
1846 * image.c: Include w32.h.
1847 (Vimage_type_cache): Delete.
1848 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1849 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1850 (w32_delayed_load): Move to w32.c.
1851
1852 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1853
1854 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1855 (w32_delayed_load): Move from image.c. When loading a library, record
1856 its filename in the :loaded-from property of the library id.
1857 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1858 Initialize and staticpro them.
1859 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1860
1861 * process.c: Include lisp.h before w32.h, not after.
1862 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1863 instead of gnutls_record_check_pending.
1864
1865 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1866
18672011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1868
1869 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1870 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1871 as passed in.
1872
18732011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1874
1875 * xterm.c (x_set_frame_alpha): Do not set property on anything
1876 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1877
18782011-05-02 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1881
18822011-05-02 Juanma Barranquero <lekktu@gmail.com>
1883
1884 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1885 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1886 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1887 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1888 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1889 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1890 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1891 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1892 (Qgnutls_bootprop_callbacks_verify): Make static.
1893
18942011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1895
1896 * callproc.c: Indentation fixup.
1897
1898 * sysdep.c (wait_for_termination_1): Make static.
1899 (wait_for_termination, interruptible_wait_for_termination):
1900 Move after wait_for_termination_1.
1901
19022011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1903
1904 * sysdep.c (interruptible_wait_for_termination): New function
1905 which is like wait_for_termination, but allows keyboard
1906 interruptions.
1907
1908 * callproc.c (Fcall_process): Add (:file "file") as an option for
1909 the STDOUT buffer.
1910 (Fcall_process_region): Ditto.
1911
19122011-04-30 Eli Zaretskii <eliz@gnu.org>
1913
1914 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1915 rather than `XVECTOR (FOO)->size'.
1916
1917 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1918 inttypes.h, as a gnulib replacement is used if it not available in
1919 system headers.
1920
19212011-04-21 Eli Zaretskii <eliz@gnu.org>
1922
1923 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1924 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1925 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1926
1927 * coding.c (coding_alloc_by_realloc): Error out if destination
1928 will grow beyond MOST_POSITIVE_FIXNUM.
1929 (decode_coding_emacs_mule): Abort if there isn't enough place in
1930 charbuf for the composition carryover bytes. Reserve an extra
1931 space for up to 2 characters produced in a loop.
1932 (decode_coding_iso_2022): Abort if there isn't enough place in
1933 charbuf for the composition carryover bytes.
1934
19352011-04-21 Eli Zaretskii <eliz@gnu.org>
1936
1937 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1938 aborting when %lld or %lll format is passed.
1939 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1940 %llo or %llx format is passed. (Bug#8545)
1941
1942 * window.c (window_scroll_line_based): Use a marker instead of
1943 simple variables to record original value of point. (Bug#7952)
1944
1945 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1946 produced by %s or %c overflows available buffer space. (Bug#8545)
1947
19482011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1951 (SIZE_MAX): Move defn after all includes, as they might #define it.
1952
19532011-04-28 Juanma Barranquero <lekktu@gmail.com>
1954
1955 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1956
19572011-04-28 Juanma Barranquero <lekktu@gmail.com>
1958
1959 * keyboard.c (Qdelayed_warnings_hook): Define.
1960 (command_loop_1): Run `delayed-warnings-hook'
1961 if Vdelayed_warnings_list is non-nil.
1962 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1963 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1964
19652011-04-28 Eli Zaretskii <eliz@gnu.org>
1966
1967 * doprnt.c (doprnt): Don't return value smaller than the buffer
1968 size if the message was truncated. (Bug#8545).
1969
19702011-04-28 Juanma Barranquero <lekktu@gmail.com>
1971
1972 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1973 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1974
19752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1978
19792011-04-27 Juanma Barranquero <lekktu@gmail.com>
1980
1981 * makefile.w32-in: Update dependencies.
1982
19832011-04-27 Eli Zaretskii <eliz@gnu.org>
1984
1985 Improve `doprnt' and its usage. (Bug#8545)
1986 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1987 `format_end'. Remove support for %l as a conversion specifier.
1988 Don't use xrealloc. Improve diagnostics when the %l size modifier
1989 is used. Update the commentary.
1990
1991 * eval.c (verror): Simplify calculation of size_t.
1992
1993 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1994 messages.
1995
19962011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1997
1998 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1999 change.
2000
20012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2004 This makes this file independent of the recent pseudovector change.
2005
20062011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2007
2008 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2009
2010 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2011 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2012 Remove unused local.
2013 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2014
2015 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2016 GCC 4.6.0 optimizes based on type-based alias analysis.
2017 For example, if b is of type struct buffer * and v of type struct
2018 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2019 != &v->size, and therefore "v->size = 1; b->size = 2; return
2020 v->size;" must therefore return 1. This assumption is incorrect
2021 for Emacs, since it type-puns struct Lisp_Vector * with many other
2022 types. To fix this problem, this patch adds a new type struct
2023 vectorlike_header that documents the constraints on layout of vectors
2024 and pseudovectors, and helps optimizing compilers not get fooled
2025 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2026 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2027 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2028 the size member.
2029 (XSETPVECTYPE): Rewrite in terms of new macro.
2030 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2031 This is a bit clearer, and further avoids the possibility of
2032 undesirable aliasing.
2033 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2034 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2035 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2036 since Lisp_Subr is a special case (no "next" field).
2037 (ASIZE): Now uses header.size rather than size.
2038 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2039 to avoid the hassle of writing XVECTOR (foo)->header.size.
2040 (struct vectorlike_header): New type.
2041 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2042 object, to help avoid aliasing.
2043 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2044 (SUBRP): Likewise, since Lisp_Subr is a special case.
2045 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2046 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2047 (struct Lisp_Hash_Table): Combine first two members into a single
2048 struct vectorlike_header member. All uses of "size" and "next" members
2049 changed to be "header.size" and "header.next".
2050 * buffer.h (struct buffer): Likewise.
2051 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2052 * frame.h (struct frame): Likewise.
2053 * process.h (struct Lisp_Process): Likewise.
2054 * termhooks.h (struct terminal): Likewise.
2055 * window.c (struct save_window_data, struct saved_window): Likewise.
2056 * window.h (struct window): Likewise.
2057 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2058 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2059 * buffer.c (init_buffer_once): Likewise.
2060 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2061 special case.
2062 * process.c (Fformat_network_address): Use local var for size,
2063 for brevity.
2064
2065 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2066
2067 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2068 * data.c (atof): Remove decl; no longer used or needed.
2069 (digit_to_number): Move to lread.c.
2070 (Fstring_to_number): Use new string_to_number function, to be
2071 consistent with how the Lisp reader treats infinities and NaNs.
2072 Do not assume that floating-point numbers represent EMACS_INT
2073 without losing information; this is not true on most 64-bit hosts.
2074 Avoid double-rounding errors, by insisting on integers when
2075 parsing non-base-10 numbers, as the documentation specifies.
2076 * lisp.h (string_to_number): New decl, replacing ...
2077 (isfloat_string): Remove.
2078 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2079 (read1): Do not accept +. and -. as integers; this
2080 appears to have been a coding error. Similarly, do not accept
2081 strings like +-1e0 as floating point numbers. Do not report
2082 overflow for integer overflows unless the base is not 10 which
2083 means we have no simple and reliable way to continue.
2084 Break out the floating-point parsing into a new
2085 function string_to_number, so that Fstring_to_number parses
2086 floating point numbers consistently with the Lisp reader.
2087 (digit_to_number): Move here from data.c. Make it static inline.
2088 (E_CHAR, EXP_INT): Remove, replacing with ...
2089 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2090 (string_to_number): New function, replacing isfloat_string.
2091 This function checks for valid syntax and produces the resulting
2092 Lisp float number too. Rework it so that string-to-number
2093 no longer mishandles examples like "1.0e+". Use strtoumax,
2094 so that overflow for non-base-10 numbers is reported only when
2095 there's no portable and simple way to convert to floating point.
2096
2097 * textprop.c (set_text_properties_1): Rewrite for clarity,
2098 and to avoid GCC warning about integer overflow.
2099
2100 * intervals.h (struct interval): Use EMACS_INT for members
2101 where EMACS_UINT might cause problems. See
2102 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2103 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2104 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2105 All uses changed.
2106 (offset_intervals): Tell GCC not to worry about length overflow
2107 when negating a negative length.
2108
2109 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2110 (overrun_check_free): Likewise.
2111
2112 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2113 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2114 word size.
2115
2116 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2117 (gnutls_make_error): Rename local to avoid shadowing.
2118 (gnutls_emacs_global_deinit): ifdef out; not used.
2119 (Fgnutls_boot): Use const for pointer to readonly storage.
2120 Comment out unused local. Fix pointer signedness problems.
2121
2122 * lread.c (openp): Don't stuff size_t into an 'int'.
2123 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2124 about possible signed overflow.
2125
2126 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2127 (GDK_KEY_g): Don't define if already defined.
2128 (xg_prepare_tooltip): Avoid pointer signedness problem.
2129 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2130
2131 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2132 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2133
2134 * xfns.c (Fx_window_property): Simplify a bit,
2135 to make a bit faster and to avoid GCC 4.6.0 warning.
2136 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2137
2138 * fns.c (internal_equal): Don't assume size_t fits in int.
2139
2140 * alloc.c (compact_small_strings): Tighten assertion a little.
2141
2142 Replace pEd with more-general pI, and fix some printf arg casts.
2143 * lisp.h (pI): New macro, generalizing old pEd macro to other
2144 conversion specifiers. For example, use "...%"pI"d..." rather
2145 than "...%"pEd"...".
2146 (pEd): Remove. All uses replaced with similar uses of pI.
2147 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2148 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2149 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2150 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2151 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2152 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2153 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2154 64-bit hosts.
2155 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2156 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2157 * print.c (safe_debug_print, print_object): Likewise.
2158 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2159 to int.
2160 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2161 avoiding the 0 flag, which is not portable.
2162 * process.c (Fmake_network_process): Use pI to avoid cast.
2163 * region-cache.c (pp_cache): Likewise.
2164 * xdisp.c (decode_mode_spec): Likewise.
2165 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2166 behavior on 64-bit hosts with printf arg.
2167 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2168 (x_stop_queuing_selection_requests): Likewise.
2169 (x_get_window_property): Don't truncate byte count to an 'int'
2170 when tracing.
2171
2172 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2173 here, since it parses constructs like leading '-' and spaces,
2174 which are not wanted; and it overflows with large numbers.
2175 Instead, simply match F[0-9]+, which is what is wanted anyway.
2176
2177 * alloc.c: Remove unportable assumptions about struct layout.
2178 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2179 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2180 (allocate_vectorlike, make_pure_vector): Use the new macros,
2181 plus offsetof, to remove unportable assumptions about struct layout.
2182 These assumptions hold on all porting targets that I know of, but
2183 they are not guaranteed, they're easy to remove, and removing them
2184 makes further changes easier.
2185
2186 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2187 This doesn't fix a bug but makes the code clearer.
2188 (string_overrun_cookie): Now const. Use initializers that
2189 don't formally overflow signed char, to avoid warnings.
2190 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2191 can cause Emacs to crash when string overrun checking is enabled.
2192 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2193 multiple of sizeof (EMACS_INT); it need not be, if
2194 alignof(EMACS_INT) < sizeof (EMACS_INT).
2195 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2196
21972011-04-26 Juanma Barranquero <lekktu@gmail.com>
2198
2199 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2200
22012011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2202
2203 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2204 supposed to be handshaking. (Bug#8556)
2205 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2206
22072011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2208
2209 * lisp.h (Qdebug): List symbol.
2210 * eval.c (Qdebug): Restore global linkage.
2211 * keyboard.c (debug-on-event): New variable.
2212 (handle_user_signal): Break into debugger when debug-on-event
2213 matches the current signal symbol.
2214
22152011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2216
2217 * alloc.c (check_sblock, check_string_bytes)
2218 (check_string_free_list): Convert to standard C.
2219
22202011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2221
2222 * w32.c (emacs_gnutls_push): Fix typo.
2223
22242011-04-25 Eli Zaretskii <eliz@gnu.org>
2225
2226 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2227 "cast to pointer from integer of different size".
2228
2229 Improve doprnt and its use in verror. (Bug#8545)
2230 * doprnt.c (doprnt): Document the set of format control sequences
2231 supported by the function. Use SAFE_ALLOCA instead of always
2232 using `alloca'.
2233
2234 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2235 is one byte too soon. Don't use xrealloc; instead xfree and
2236 xmalloc anew.
2237
22382011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2239
2240 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2241 callbacks stage.
2242
2243 * gnutls.c: Renamed global_initialized to
2244 gnutls_global_initialized. Added internals for the
2245 :verify-hostname-error, :verify-error, and :verify-flags
2246 parameters of `gnutls-boot' and documented those parameters in the
2247 docstring. Start callback support.
2248 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2249 unless a fatal error occured. Call gnutls_alert_send_appropriate
2250 on error. Return error code.
2251 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2252 (emacs_gnutls_read): Likewise.
2253 (Fgnutls_boot): Return handshake error code.
2254 (emacs_gnutls_handle_error): New function.
2255 (wsaerror_to_errno): Likewise.
2256
2257 * w32.h (emacs_gnutls_pull): Add prototype.
2258 (emacs_gnutls_push): Likewise.
2259
2260 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2261 (emacs_gnutls_push): Likewise.
2262
22632011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2264
2265 * process.c (wait_reading_process_output): Check if GnuTLS
2266 buffered some data internally if no FDs are set for TLS
2267 connections.
2268
2269 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2270 (LIBS): Link to USER_LIBS.
2271 ($(BLD)/gnutls.$(0)): New target.
2272
22732011-04-24 Eli Zaretskii <eliz@gnu.org>
2274
2275 * xdisp.c (handle_single_display_spec): Rename the
2276 display_replaced_before_p argument into display_replaced_p, to
2277 make it consistent with the commentary. Fix typos in the
2278 commentary.
2279
2280 * textprop.c (syms_of_textprop): Remove dead code.
2281 (copy_text_properties): Delete obsolete commentary about an
2282 interface that was deleted long ago. Fix typos in the description
2283 of arguments.
2284
2285 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2286 to changes in oldXMenu/XMenu.h from 2011-04-16.
2287 <menu_help_message, prev_menu_help_message>: Constify.
2288 (IT_menu_make_room): menu->help_text is now `const char **';
2289 adjust.
2290
2291 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2292 to changes in oldXMenu/XMenu.h from 2011-04-16.
2293 (struct XMenu): Declare `help_text' `const char **'.
2294
2295 * xfaces.c <Qunspecified>: Make extern again.
2296
2297 * syntax.c: Include sys/types.h before including regex.h, as
2298 required by Posix.
2299
2300 * doc.c (get_doc_string): Improve the format passed to `error'.
2301
2302 * doprnt.c (doprnt): Improve commentary.
2303
2304 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2305
2306 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2307 them with etags.
2308
2309 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2310 changes in globals.h immediately force recompilation.
2311 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2312 $(CURDIR)/s/ms-w32.h.
2313 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2314
2315 * character.c (Fchar_direction): Function deleted.
2316 (syms_of_character): Don't defsubr it.
2317 <char-direction-table>: Deleted.
2318
23192011-04-23 Eli Zaretskii <eliz@gnu.org>
2320
2321 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2322 * doprnt.c: Include limits.h.
2323 (SIZE_MAX): New macro.
2324 (doprnt): Return a size_t value. 2nd arg is now size_t.
2325 Many local variables are now size_t instead of int or unsigned.
2326 Improve overflow protection. Support `l' modifier for integer
2327 conversions. Support %l conversion. Don't assume an EMACS_INT
2328 argument for integer conversions and for %c.
2329
2330 * lisp.h (doprnt): Restore prototype.
2331
2332 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2333 $(SRC)/character.h.
2334
2335 * Makefile.in (base_obj): Add back doprnt.o.
2336
2337 * deps.mk (doprnt.o): Add back prerequisites.
2338 (callint.o): Depend on character.h.
2339
2340 * eval.c (internal_lisp_condition_case): Include the handler
2341 representation in the error message.
2342 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2343 when breaking from the loop.
2344
2345 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2346
2347 * callint.c (Fcall_interactively): When displaying error message
2348 about invalid control letter, pass the character's codepoint, not
2349 a pointer to its multibyte form. Improve display of the character
2350 in octal and display also its hex code.
2351
2352 * character.c (char_string): Use %x to display the (unsigned)
2353 codepoint of an invalid character, to avoid displaying a bogus
2354 negative value.
2355
2356 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2357 `error', not SYMBOL_NAME itself.
2358
2359 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2360 character arguments to `error'.
2361
2362 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2363 to `error' in error message about FINAL_CHAR argument. Make sure
2364 FINAL_CHAR is a character, and use %c when it is passed as
2365 argument to `error'.
2366
23672011-04-23 Eli Zaretskii <eliz@gnu.org>
2368
2369 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2370
2371 * w32.c: Include <time.h>.
2372 (sys_localtime): New function.
2373
23742011-04-23 Chong Yidong <cyd@stupidchicken.com>
2375
2376 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2377
2378 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2379
23802011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2381
2382 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2383 zombies (Bug#8467).
2384
23852011-04-19 Eli Zaretskii <eliz@gnu.org>
2386
2387 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2388 gl_state.e_property when gl_state.object is Qt.
2389
2390 * insdel.c (make_gap_larger): Remove limitation of buffer size
2391 to <= INT_MAX.
2392
23932011-04-18 Chong Yidong <cyd@stupidchicken.com>
2394
2395 * xdisp.c (lookup_glyphless_char_display)
2396 (produce_glyphless_glyph): Handle cons cell entry in
2397 glyphless-char-display.
2398 (Vglyphless_char_display): Document it.
2399
2400 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2401 glyphless-char-display.
2402
24032011-04-17 Chong Yidong <cyd@stupidchicken.com>
2404
2405 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2406
2407 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2408
2409 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2410 definition for no-X builds.
2411
24122011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2413
2414 Static checks with GCC 4.6.0 and non-default toolkits.
2415
2416 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2417
2418 * process.c (keyboard_bit_set): Define only if SIGIO.
2419 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2420 (send_process): Repair possible setjmp clobbering.
2421
2422 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2423
2424 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2425
2426 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2427
2428 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2429 Define only if needed.
2430
2431 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2432 by pacifying GCC about it. Maybe it's time to retire it?
2433 * xfaces.c (USG, __TIMEVAL__): Likewise.
2434
2435 * dispextern.h (struct redisplay_interface): Rename param
2436 to avoid shadowing.
2437 * termhooks.h (struct terminal): Likewise.
2438 * xterm.c (xembed_send_message): Likewise.
2439
2440 * insdel.c (make_gap_smaller): Define only if
2441 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2442
2443 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2444 it.
2445
2446 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2447 so that we aren't warned about unused symbols.
2448
2449 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2450
2451 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2452
2453 * xfns.c (x_real_positions): Mark locals as initialized.
2454
2455 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2456
2457 * xterm.c: Fix problems found by static analysis with other toolkits.
2458 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2459 (x_dispatch_event): Declare static if USE_GTK, and
2460 define if USE_GTK || USE_X_TOOLKIT.
2461 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2462 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2463 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2464 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2465
2466 * xmenu.c (menu_help_callback): Pointer type fixes.
2467 Use const pointers when pointing at readonly data. Avoid pointer
2468 signedness clashes.
2469 (FALSE): Remove unused macro.
2470 (update_frame_menubar): Remove unused decl.
2471
2472 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2473
2474 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2475 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2476 (single_menu_item): Rename local to avoid shadowing.
2477
2478 * keyboard.c (make_lispy_event): Remove unused local var.
2479
2480 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2481 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2482
2483 * bitmaps: Change bitmaps from unsigned char back to the X11
2484 compatible char. Avoid the old compiler warnings about
2485 out-of-range initializers by using, for example, '\xab' rather
2486 than 0xab.
2487
2488 * xgselect.c (xgselect_initialize): Check vs interface
2489 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2490
2491 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2492
2493 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2494 to read-only memory.
2495
2496 * fns.c (vector): Remove; this old hack is no longer needed.
2497
2498 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2499 Remove unused var.
2500 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2501
2502 * xrdb.c (x_load_resources): Omit unused local.
2503
2504 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2505 (x_window): Rename locals to avoid shadowing.
2506 (USG): Use the kludged USG macro, to pacify gcc.
2507
2508 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2509 (x_term_init): Remove local to avoid shadowing.
2510
2511 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2512
2513 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2514 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2515
25162011-04-16 Eli Zaretskii <eliz@gnu.org>
2517
2518 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2519
2520 Fix regex.c, syntax.c and friends for buffers > 2GB.
2521 * syntax.h (struct gl_state_s): Declare character position members
2522 EMACS_INT.
2523
2524 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2525
2526 * textprop.c (verify_interval_modification, interval_of):
2527 Declare arguments EMACS_INT.
2528
2529 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2530 EMACS_INT.
2531
2532 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2533
2534 * indent.c (Fvertical_motion): Local variable it_start is now
2535 EMACS_INT.
2536
2537 * regex.c (re_match, re_match_2, re_match_2_internal)
2538 (bcmp_translate, regcomp, regexec, print_double_string)
2539 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2540 (re_compile_pattern, re_exec): Declare arguments and local
2541 variables `size_t' and `ssize_t' and return values `regoff_t', as
2542 appropriate.
2543 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2544 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2545 <compile_stack_type>: `size' and `avail' are now `size_t'.
2546
2547 * regex.h <regoff_t>: Use ssize_t, not int.
2548 (re_search, re_search_2, re_match, re_match_2): Arguments that
2549 specify buffer/string position and length are now ssize_t and
2550 size_t. Return type is regoff_t.
2551
25522011-04-16 Ben Key <bkey76@gmail.com>
2553
2554 * nsfont.m: Fixed bugs in ns_get_family and
2555 ns_descriptor_to_entity that were caused by using free to
2556 deallocate memory blocks that were allocated by xmalloc (via
2557 xstrdup). This caused Emacs to crash when compiled with
2558 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2559 --enable-checking=xmallocoverrun). xfree is now used to
2560 deallocate these memory blocks.
2561
25622011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2565
2566 emacs_write: Accept and return EMACS_INT for sizes.
2567 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2568 et seq.
2569 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2570 Accept and return EMACS_INT.
2571 (emacs_gnutls_write): Return the number of bytes written on
2572 partial writes.
2573 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2574 (emacs_read, emacs_write): Remove check for negative size, as the
2575 Emacs source code has been audited now.
2576 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2577 (emacs_read, emacs_write): Use it.
2578 * process.c (send_process): Adjust to the new signatures of
2579 emacs_write and emacs_gnutls_write. Do not attempt to store
2580 a byte offset into an 'int'; it might overflow.
2581 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2582
2583 * sound.c: Don't assume sizes fit in 'int'.
2584 (struct sound_device.period_size, alsa_period_size):
2585 Return EMACS_INT, not int.
2586 (struct sound_device.write, vox_write, alsa_write):
2587 Accept EMACS_INT, not int.
2588 (wav_play, au_play): Use EMACS_INT to store sizes and to
2589 record read return values.
2590
25912011-04-15 Ben Key <bkey76@gmail.com>
2592
2593 * keyboard.c (Qundefined): Don't declare static since it is used
2594 in nsfns.m.
2595 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2596 static since they are used in nsfont.m.
2597
25982011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2599
2600 * process.c (Qprocessp): Don't declare static.
2601 * lisp.h (Qprocessp): Declare again.
2602
26032011-04-15 Juanma Barranquero <lekktu@gmail.com>
2604
2605 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2606
26072011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2608
2609 Improve C-level modularity by making more things 'static'.
2610
2611 Don't publish debugger-only interfaces to other modules.
2612 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2613 (verify_bytepos, count_markers): Move decls to the only modules
2614 that need them.
2615 * region-cache.h (pp_cache): Likewise.
2616 * window.h (check_all_windows): Likewise.
2617 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2618
2619 * sysdep.c (croak): Now static, if
2620 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2621 * syssignal.h (croak): Declare only if not static.
2622
2623 * alloc.c (refill_memory_reserve): Now static if
2624 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2625 * lisp.h (refill_memory_reserve): Declare only if not static.
2626
2627 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2628 Define only if USE_LUCID.
2629
2630 * xrdb.c (x_customization_string, x_rm_string): Now static.
2631
2632 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2633 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2634
2635 * xdisp.c (draw_row_with_mouse_face): Now static.
2636 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2637
2638 * window.h (check_all_windows): Mark externally visible.
2639
2640 * window.c (window_deletion_count): Now static.
2641
2642 * undo.c: Make symbols static if they're not exported.
2643 (last_undo_buffer, last_boundary_position, pending_boundary):
2644 Now static.
2645
2646 * textprop.c (interval_insert_behind_hooks): Now static.
2647 (interval_insert_in_front_hooks): Likewise.
2648
2649 * term.c: Make symbols static if they're not exported.
2650 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2651 (max_frame_lines, tty_set_terminal_modes):
2652 (tty_reset_terminal_modes, tty_turn_off_highlight):
2653 (get_tty_terminal): Now static.
2654 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2655 * termhooks.h (term_mouse_moveto): Do not declare if
2656 HAVE_WINDOW_SYSTEM.
2657 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2658 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2659
2660 * sysdep.c: Make symbols static if they're not exported.
2661 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2662 Now static.
2663 (sigprocmask_set, full_mask): Remove; unused.
2664 (wait_debugging): Mark as visible.
2665 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2666 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2667
2668 * syntax.c (syntax_temp): Define only if !__GNUC__.
2669
2670 * sound.c (current_sound_device, current_sound): Now static.
2671
2672 * search.c (searchbufs, searchbuf_head): Now static.
2673
2674 * scroll.c (scroll_cost): Remove; unused.
2675 * dispextern.h (scroll_cost): Remove decl.
2676
2677 * region-cache.h (pp_cache): Mark as externally visible.
2678
2679 * process.c: Make symbols static if they're not exported.
2680 (process_tick, update_tick, create_process, chan_process):
2681 (Vprocess_alist, proc_buffered_char, datagram_access):
2682 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2683 (deactivate_process): Mark defn as static, as well as decl.
2684 * lisp.h (create_process): Remove decl.
2685 * process.h (chan_process, Vprocess_alist): Remove decls.
2686
2687 * print.c: Make symbols static if they're not exported.
2688 (print_depth, new_backquote_output, being_printed, print_buffer):
2689 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2690 (print_interval, print_number_index, initial_stderr_stream):
2691 Now static.
2692 * lisp.h (Fprinc): Remove decl.
2693 (debug_output_compilation_hack): Mark as externally visible.
2694
2695 * sysdep.c (croak): Move decl from here to syssignal.h.
2696 * syssignal.h (croak): Put it here, so the API can be checked when
2697 'croak' is called from dissociate_if_controlling_tty.
2698
2699 * minibuf.c: Make symbols static if they're not exported.
2700 (minibuf_save_list, choose_minibuf_frame): Now static.
2701 * lisp.h (choose_minibuf_frame): Remove decl.
2702
2703 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2704
2705 * lread.c: Make symbols static if they're not exported.
2706 (read_objects, initial_obarray, oblookup_last_bucket_number):
2707 Now static.
2708 (make_symbol): Remove; unused.
2709 * lisp.h (initial_obarray, make_symbol): Remove decls.
2710
2711 * keyboard.c: Make symbols static if they're not exported.
2712 (single_kboard, recent_keys_index, total_keys, recent_keys):
2713 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2714 (this_single_command_key_start, echoing, last_auto_save):
2715 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2716 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2717 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2718 (Vlispy_mouse_stem, double_click_count):
2719 Now static.
2720 (force_auto_save_soon): Define only if SIGDANGER.
2721 (ignore_mouse_drag_p): Now static if
2722 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2723 (print_help): Remove; unused.
2724 (stop_character, last_timer_event): Mark as externally visible.
2725 * keyboard.h (ignore_mouse_drag_p): Declare only if
2726 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2727 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2728 * lisp.h (echoing): Remove decl.
2729 (force_auto_save_soon): Declare only if SIGDANGER.
2730 * xdisp.c (redisplay_window): Simplify code, to make it more
2731 obvious that ignore_mouse_drag_p is not accessed if !defined
2732 USE_GTK && !defined HAVE_NS.
2733
2734 * intervals.c: Make symbols static if they're not exported.
2735 (merge_properties_sticky, merge_interval_right, delete_interval):
2736 Now static.
2737 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2738
2739 * insdel.c: Make symbols static if they're not exported.
2740 However, leave prepare_to_modify_buffer alone. It's never
2741 called from outside this function, but that appears to be a bug.
2742 (combine_after_change_list, combine_after_change_buffer):
2743 (adjust_after_replace, signal_before_change): Now static.
2744 (adjust_after_replace_noundo): Remove; unused.
2745 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2746 (signal_before_change): Remove decls.
2747
2748 * indent.c (val_compute_motion, val_vmotion): Now static.
2749
2750 * image.c: Make symbols static if they're not exported.
2751 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2752 if USE_GTK.
2753 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2754 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2755
2756 * fringe.c (standard_bitmaps): Now static.
2757 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2758
2759 * frame.c: Make symbols static if they're not exported.
2760 (x_report_frame_params, make_terminal_frame): Now static.
2761 (get_frame_param): Now static, unless HAVE_NS.
2762 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2763 (x_get_resource_string): Remove; not used.
2764 * frame.h (make_terminal_frame, x_report_frame_params):
2765 (x_get_resource_string); Remove decls.
2766 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2767 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2768
2769 * font.c, fontset.c: Make symbols static if they're not exported.
2770 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2771 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2772 * font.c (font_close_object): Now static.
2773 * font.h (font_close_object): Remove.
2774 * fontset.c (FONTSET_OBJLIST): Remove.
2775 (free_realized_fontset) #if-0 the body, which does nothing.
2776 (face_suitable_for_char_p): #if-0, as it's never called.
2777 * fontset.h (face_suitable_for_char_p): Remove decl.
2778 * xfaces.c (face_at_string_position):
2779 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2780 since 0 is always ASCII.
2781
2782 * fns.c (weak_hash_tables): Now static.
2783
2784 * fileio.c: Make symbols static if they're not exported.
2785 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2786 (Vwrite_region_annotation_buffers): Now static.
2787
2788 * eval.c: Make symbols static if they're not exported.
2789 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2790 * lisp.h (backtrace_list): Remove decl.
2791
2792 * emacs.c: Make symbols static if they're not exported.
2793 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2794 (fatal_error_code, fatal_error_signal_hook, standard_args):
2795 Now static.
2796 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2797 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2798 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2799 * lisp.h (fatal_error_signal_hook): Remove decl.
2800 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2801
2802 * editfns.c: Move a (normally-unused) function to its only use.
2803 * editfns.c, lisp.h (get_operating_system_release): Remove.
2804 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2805 worth the hassle of breaking this out.
2806
2807 * xterm.c: Make symbols static if they're not exported.
2808 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2809 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2810 (x_destroy_window, x_delete_display):
2811 Now static.
2812 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2813 (x_mouse_leave): Remove; unused.
2814 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2815 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2816 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2817 Remove decls.
2818 (x_mouse_leave): Declare only if WINDOWSNT.
2819 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2820 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2821 USE_X_TOOLKIT.
2822
2823 * ftxfont.c: Make symbols static if they're not exported.
2824 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2825 HAVE_FREETYPE.
2826 * font.h (ftxfont_driver): Likewise.
2827
2828 * xfns.c: Make symbols static if they're not exported.
2829 (x_last_font_name, x_display_info_for_name):
2830 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2831 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2832 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2833 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2834 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2835 (last_show_tip_args): Now static.
2836 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2837 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2838 (x_screen_planes): Remove; unused.
2839 * dispextern.h (x_screen_planes): Remove decl.
2840
2841 * dispnew.c: Make symbols static if they're not exported.
2842 * dispextern.h (redraw_garbaged_frames, scrolling):
2843 (increment_row_positions): Remove.
2844 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2845 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2846 Now static.
2847 (redraw_garbaged_frames): Remove; unused.
2848
2849 * xfaces.c: Make symbols static if they're not exported.
2850 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2851 Remove decls.
2852 * xterm.h (defined_color): Remove decls.
2853 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2854 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2855 (menu_face_changed_default, defined_color, free_realized_face):
2856 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2857 (ascii_face_of_lisp_face): Remove; unused.
2858
2859 * xdisp.c: Make symbols static if they're not exported.
2860 * dispextern.h (scratch_glyph_row, window_box_edges):
2861 (glyph_to_pixel_coords, set_cursor_from_row):
2862 (get_next_display_element, set_iterator_to_next):
2863 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2864 (show_mouse_face): Remove decls
2865 * frame.h (message_buf_print): Likewise.
2866 * lisp.h (pop_message, set_message, check_point_in_composition):
2867 Likewise.
2868 * xterm.h (set_vertical_scroll_bar): Likewise.
2869 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2870 (message_buf_print, scratch_glyph_row, displayed_buffer):
2871 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2872 (get_next_display_element, show_mouse_face, window_box_edges):
2873 (frame_to_window_pixel_xy, check_point_in_composition):
2874 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2875 (glyph_to_pixel_coords): Remove; unused.
2876
2877 * dired.c (file_name_completion): Now static.
2878
2879 * dbusbind.c (xd_in_read_queued_messages): Now static.
2880
2881 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2882 * data.c (circular_list_error): Remove.
2883
2884 * commands.h (last_point_position, last_point_position_buffer):
2885 (last_point_position_window): Remove decls.
2886 * keyboard.c: Make these variables static.
2887
2888 * coding.h (coding, code_convert_region, encode_coding_gap):
2889 Remove decls.
2890 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2891 (iso_code_class, detect_coding, code_convert_region): Now static.
2892 (encode_coding_gap): Remove; unused.
2893
2894 * chartab.c (chartab_chars, chartab_bits): Now static.
2895
2896 * charset.h (charset_iso_8859_1): Remove decl.
2897 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2898 Now static.
2899
2900 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2901 * ccl.c (Vccl_program_table): Now static.
2902 (check_ccl_update): Remove; unused.
2903
2904 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2905 * category.h: ... from here.
2906 * category.c (check_category_table, set_category_set): Now static.
2907
2908 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2909 * lisp.h: Remove these decls.
2910
2911 * buffer.c (buffer_count): Remove unused var.
2912
2913 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2914 so that it's not optimized away.
2915 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2916 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2917 exported only to the debugger.
2918
2919 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2920 * atimer.h (run_all_atimers): Remove; not exported.
2921
2922 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2923 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2924 was inaccessible from Lisp.
2925 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2926 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2927
2928 alloc.c: Import and export fewer symbols, and remove unused items.
2929 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2930 is defined.
2931 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2932 it's not optimized away by whole-program optimization.
2933 (message_enable_multibyte, free_misc): Remove.
2934 (catchlist, handlerlist, mark_backtrace):
2935 Declare only if BYTE_MARK_STACK.
2936 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2937 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2938 (message_enable_multibyte): Remove decl.
2939 (free_misc, interval_free_list, float_block, float_block_index):
2940 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2941 (cons_free_list, last_marked_index):
2942 Now static.
2943 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2944 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2945 (mark_backtrace): Define only if BYTE_MARK_STACK.
2946 * xdisp.c (message_enable_multibyte): Now static.
2947
2948 Declare Lisp_Object Q* variables to be 'static' if not exported.
2949 This makes it easier for human readers (and static analyzers)
2950 to see whether these variables are used from other modules.
2951 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2952 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2953 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2954 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2955 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2956 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2957 * xmenu.c, xselect.c:
2958 Declare Q* vars static if they are not used in other modules.
2959 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2960 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2961 Remove decls of unexported vars.
2962 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2963
2964 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2965
2966 Make Emacs functions such as Fatom 'static' by default.
2967 This makes it easier for human readers (and static analyzers)
2968 to see whether these functions can be called from other modules.
2969 DEFUN now defines a static function. To make the function external
2970 so that it can be used in other C modules, use the new macro DEFUE.
2971 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2972 (Finit_image_library):
2973 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2974 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2975 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2976 Remove decls, since these functions are now static.
2977 (Funintern, Fget_internal_run_time): New decls, since these functions
2978 were already external.
2979
2980 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2981 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2982 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2983 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2984 * keyboard.c, keymap.c, lread.c:
2985 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2986 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2987 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2988 Mark functions with DEFUE instead of DEFUN,
2989 if they are used in other modules.
2990 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2991 decls for now-static functions.
2992 * buffer.h (Fdelete_overlay): Remove decl.
2993 * callproc.c (Fgetenv_internal): Mark as internal.
2994 * composite.c (Fremove_list_of_text_properties): Remove decl.
2995 (Fcomposition_get_gstring): New forward static decl.
2996 * composite.h (Fcomposite_get_gstring): Remove decl.
2997 * dired.c (Ffile_attributes): New forward static decl.
2998 * doc.c (Fdocumntation_property): New forward static decl.
2999 * eval.c (Ffetch_bytecode): New forward static decl.
3000 (Funintern): Remove extern decl; now in .h file where it belongs.
3001 * fileio.c (Fmake_symbolic_link): New forward static decl.
3002 * image.c (Finit_image_library): New forward static decl.
3003 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3004 * intervals.h (Fprevious_property_change):
3005 (Fremove_list_of_text_properties): Remove decls.
3006 * keyboard.c (Fthis_command_keys): Remove decl.
3007 (Fcommand_execute): New forward static decl.
3008 * keymap.c (Flookup_key): New forward static decl.
3009 (Fcopy_keymap): Now static.
3010 * keymap.h (Flookup_key): Remove decl.
3011 * process.c (Fget_process): New forward static decl.
3012 (Fprocess_datagram_address): Mark as internal.
3013 * syntax.c (Fsyntax_table_p): New forward static decl.
3014 (skip_chars): Remove duplicate decl.
3015 * textprop.c (Fprevious_property_change): New forward static decl.
3016 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3017 Now internal.
3018 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3019 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3020
3021 * editfns.c (Fformat): Remove unreachable code.
3022
30232011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3024
3025 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3026 change. (Bug#8496)
3027
30282011-04-13 Eli Zaretskii <eliz@gnu.org>
3029
3030 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3031 when at ZV. (Bug#8487)
3032
30332011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3034
3035 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3036 (Bug#8437)
3037 * keyboard.c (parse_tool_bar_item): Likewise.
3038 * sound.c (sound_cleanup, alsa_close): Likewise.
3039 * termcap.c (tgetent): Likewise.
3040 * xfns.c (x_default_font_parameter): Likewise.
3041 * xsettings.c (read_and_apply_settings): Likewise.
3042
3043 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3044 (overrun_check_free): Protoize.
3045
30462011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3047
3048 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3049 since callers should never pass a negative size.
3050 Change the signature to match that of plain 'read' and 'write'; see
3051 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3052 * lisp.h: Update prototypes of emacs_write and emacs_read.
3053
30542011-04-11 Eli Zaretskii <eliz@gnu.org>
3055
3056 * xdisp.c (redisplay_window): Don't try to determine the character
3057 position of the scroll margin if the window start point w->startp
3058 is outside the buffer's accessible region. (Bug#8468)
3059
30602011-04-10 Eli Zaretskii <eliz@gnu.org>
3061
3062 Fix write-region and its subroutines for buffers > 2GB.
3063 * fileio.c (a_write, e_write): Modify declaration of arguments and
3064 local variables to support buffers larger than 2GB.
3065 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3066
3067 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3068 argument, local variables, and return value.
3069
3070 * lisp.h: Update prototypes of emacs_write and emacs_read.
3071
3072 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3073
30742011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3075
3076 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3077
3078 Fix more problems found by GCC 4.6.0's static checks.
3079
3080 * xdisp.c (vmessage): Use a better test for character truncation.
3081
3082 * charset.c (load_charset_map): <, not <=, for optimization,
3083 and to avoid potential problems with integer overflow.
3084 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3085 * casetab.c (set_identity, shuffle): Likewise.
3086 * editfns.c (Fformat): Likewise.
3087 * syntax.c (skip_chars): Likewise.
3088
3089 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3090 This also lets GCC 4.6.0 generate slightly better loop code.
3091
3092 * callint.c (Fcall_interactively): <, not <=, for optimization.
3093 (Fcall_interactively): Count the number of arguments produced,
3094 not the number of arguments given. This is simpler and lets GCC
3095 4.6.0 generate slightly better code.
3096
3097 * ftfont.c: Distingish more carefully between FcChar8 and char.
3098 The previous code passed unsigned char * to a functions like
3099 strlen and xstrcasecmp that expect char *, which does not
3100 conform to the C standard.
3101 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3102 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3103 char * when the C standard requires it.
3104
3105 * keyboard.c (read_char): Remove unused var.
3106
3107 * eval.c: Port to Windows vsnprintf (Bug#8435).
3108 Include <limits.h>.
3109 (SIZE_MAX): Define if the headers do not.
3110 (verror): Do not give up if vsnprintf returns a negative count.
3111 Instead, grow the buffer. This ports to Windows vsnprintf, which
3112 does not conform to C99. Problem reported by Eli Zaretskii.
3113 Also, simplify the allocation scheme, by avoiding the need for
3114 calling realloc, and removing the ALLOCATED variable.
3115
3116 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3117
3118 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3119 But keep the doprint source code for now, as we might revamp it
3120 and use it again (Bug#8435).
3121 * lisp.h (doprnt): Remove.
3122 * Makefile.in (base_obj): Remove doprnt.o.
3123 * deps.mk (doprnt.o): Remove.
3124
3125 error: Print 32- and 64-bit integers portably (Bug#8435).
3126 Without this change, on typical 64-bit hosts error ("...%d...", N)
3127 was used to print both 32- and 64-bit integers N, which relied on
3128 undefined behavior.
3129 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3130 New macro.
3131 * lisp.h (error, verror): Mark as printf-like functions.
3132 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3133 Report overflow in size calculations when allocating printf buffer.
3134 Do not truncate output string at its first null byte.
3135 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3136 Truncate the output at a character boundary, since vsnprintf does not
3137 do that.
3138 * charset.c (check_iso_charset_parameter): Convert internal
3139 character to string before calling 'error', since %c now has the
3140 printf meaning.
3141 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3142 overflow when computing char to be passed to 'error'. Do not
3143 pass Lisp_Object to 'error'; pass the integer instead.
3144 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3145 formatted with plain %d.
3146
3147 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3148
3149 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3150
3151 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3152
3153 * xterm.c (x_catch_errors): Remove duplicate declaration.
3154
3155 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3156
3157 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3158
31592011-04-10 Jim Meyering <meyering@redhat.com>
3160
3161 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3162 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3163 return ssize_t not "int", and use size_t as the buffer length.
3164 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3165 * gnutls.h: Update declarations.
3166 * process.c (read_process_output): Use ssize_t, to match.
3167 (send_process): Likewise.
3168
31692011-04-09 Chong Yidong <cyd@stupidchicken.com>
3170
3171 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3172
31732011-04-09 Chong Yidong <cyd@stupidchicken.com>
3174
3175 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3176 Use unsigned char, to match FcChar8 type definition.
3177
3178 * xterm.c (handle_one_xevent):
3179 * xmenu.c (create_and_show_popup_menu):
3180 * xselect.c (x_decline_selection_request)
3181 (x_reply_selection_request): Avoid type-punned deref of X events.
3182
31832011-04-09 Eli Zaretskii <eliz@gnu.org>
3184
3185 Fix some uses of `int' instead of EMACS_INT.
3186 * search.c (string_match_1, fast_string_match)
3187 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3188 (scan_buffer, find_next_newline_no_quit)
3189 (find_before_next_newline, search_command, Freplace_match)
3190 (Fmatch_data): Make some `int' variables be EMACS_INT.
3191
3192 * xdisp.c (display_count_lines): 3rd argument and return value now
3193 EMACS_INT. All callers changed.
3194 (pint2hrstr): Last argument is now EMACS_INT.
3195
3196 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3197 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3198 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3199 (decode_coding_utf_16, decode_coding_emacs_mule)
3200 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3201 (decode_coding_ccl, decode_coding_charset)
3202 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3203 (decode_coding_iso_2022, decode_coding_emacs_mule)
3204 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3205 <char_offset, last_offset>: Declare EMACS_INT.
3206 (encode_coding_utf_8, encode_coding_utf_16)
3207 (encode_coding_emacs_mule, encode_invocation_designation)
3208 (encode_designation_at_bol, encode_coding_iso_2022)
3209 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3210 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3211 Declare EMACS_INT.
3212 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3213 (encode_invocation_designation): Last argument P_NCHARS is now
3214 EMACS_INT.
3215 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3216 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3217
3218 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3219 All users changed.
3220
3221 * ccl.c (Fccl_execute_on_string): Declare some variables
3222 EMACS_INT.
3223
32242011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3225
3226 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3227
32282011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3229
3230 * process.c (Fformat_network_address): Doc fix.
3231
32322011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3233
3234 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3235
32362011-04-08 Chong Yidong <cyd@stupidchicken.com>
3237
3238 * keyboard.c (read_char): Call Lisp function help-form-show,
3239 instead of using internal_with_output_to_temp_buffer.
3240 (Qhelp_form_show): New var.
3241 (syms_of_keyboard): Use DEFSYM macro.
3242
3243 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3244
3245 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3246
32472011-04-06 Chong Yidong <cyd@stupidchicken.com>
3248
3249 * process.c (Flist_processes): Remove to Lisp.
3250 (list_processes_1): Delete.
3251
32522011-04-06 Eli Zaretskii <eliz@gnu.org>
3253
3254 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3255
3256 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3257
32582011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 Fix more problems found by GCC 4.6.0's static checks.
3261
3262 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3263
3264 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3265
3266 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3267
3268 * xdisp.c (vmessage): Mark as a printf-like function.
3269
3270 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3271
3272 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3273
3274 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3275 printf-like functions.
3276 (tiff_load): Add casts to remove these marks before passing them
3277 to system-supplied API.
3278
3279 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3280
3281 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3282 This avoids several warnings with gcc -Wstrict-overflow.
3283 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3284 directly, rather than having caller test rule sign. This avoids
3285 some unnecessary tests.
3286 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3287 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3288 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3289
3290 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3291 (xfont_open): Avoid unnecessary tests.
3292
3293 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3294
3295 * composite.h, composite.c (composition_gstring_put_cache):
3296 Use EMACS_INT, not int, for length.
3297
3298 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3299 breaking out part of COMPOSITION_DECODE_RULE.
3300 (COMPOSITION_DECODE_RULE): Use it.
3301 * composite.c (get_composition_id): Remove unused local vars,
3302 by using the new macro.
3303
3304 * textprop.c (set_text_properties_1): Change while to do-while,
3305 since the condition is always true at first.
3306
3307 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3308 (interval_deletion_adjustment): Return unsigned value.
3309 All uses changed.
3310
3311 * process.c (list_processes_1, create_pty, read_process_output):
3312 (exec_sentinel): Remove vars that were set but not used.
3313 (create_pty): Remove unnecessary "volatile"s.
3314 (Fnetwork_interface_info): Avoid possibility of int overflow.
3315 (read_process_output): Do adaptive read buffering even if carryover.
3316 (read_process_output): Simplify nbytes computation if buffered.
3317
3318 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3319
3320 * syntax.c (scan_words): Remove var that was set but not used.
3321 (update_syntax_table): Use unsigned instead of int.
3322
3323 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3324 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3325 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3326
3327 * print.c (print_error_message): Avoid int overflow.
3328
3329 * font.c (font_list_entities): Redo for clarity,
3330 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3331
3332 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3333 (font_score): Avoid potential overflow in diff calculation.
3334
3335 * fns.c (substring_both): Remove var that is set but not used.
3336 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3337
3338 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3339
3340 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3341 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3342 can always succeed if overflow has undefined behavior.
3343
3344 * search.c (boyer_moore, wordify): Remove vars set but not used.
3345 (wordify): Omit three unnecessary tests.
3346
3347 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3348 All callers changed. This avoids the need for an unused var.
3349
3350 * casefiddle.c (casify_region): Remove var that is set but not used.
3351
3352 * dired.c (file_name_completion): Remove var that is set but not used.
3353
3354 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3355
3356 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3357 (Finsert_file_contents): Remove unnecessary code checking fd.
3358
3359 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3360 Check for integer overflow on size calculations.
3361
3362 * buffer.c (Fprevious_overlay_change): Remove var that is set
3363 but not used.
3364
3365 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3366 Remove vars that are set but not used.
3367 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3368 (timer_check_2): Mark vars as initialized.
3369
3370 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3371
3372 * image.c (lookup_image): Remove var that is set but not used.
3373 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3374
3375 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3376 that are set but not used.
3377
3378 * xfns.c (make_invisible_cursor): Don't return garbage
3379 if XCreateBitmapFromData fails (Bug#8410).
3380
3381 * xselect.c (x_get_local_selection, x_handle_property_notify):
3382 Remove vars that are set but not used.
3383
3384 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3385 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3386
3387 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3388 Remove var that is set but not used.
3389 (scroll_bar_windows_size): Now size_t, not int.
3390 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3391 Check for overflow.
3392
3393 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3394 (map_tty_color) [!defined MSDOS]: Likewise.
3395
3396 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3397
3398 * coding.c: Remove vars that are set but not used.
3399 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3400 All callers changed.
3401 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3402 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3403 (decode_coding_charset): Remove vars that are set but not used.
3404
3405 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3406 that is set but not used.
3407
3408 * print.c (print_object): Remove var that is set but not used.
3409
3410 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3411 The gnulib version avoids calling malloc in the usual case,
3412 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3413 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3414 * filelock.c (current_lock_owner): Likewise.
3415 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3416 * sysdep.c: Include allocator.h, careadlinkat.h.
3417 (emacs_no_realloc_allocator): New static constant.
3418 (emacs_readlink): New function.
3419 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3420 ../lib/careadlinkat.h.
3421
34222011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3423
3424 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3425 first non-nil return value).
3426
34272011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3428
3429 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3430 if not defined (Bug#8403).
3431
34322011-04-02 Juanma Barranquero <lekktu@gmail.com>
3433
3434 * xdisp.c (display_count_lines): Remove parameter `start',
3435 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3436 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3437 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3438 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3439 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3440 and thereabouts. All callers changed.
3441 (get_per_char_metric): Remove parameter `f', unused since
3442 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3443
34442011-04-02 Jim Meyering <meyering@redhat.com>
3445
3446 do not dereference NULL upon failed strdup
3447 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3448 (ns_get_family): Likewise.
3449
34502011-04-02 Juanma Barranquero <lekktu@gmail.com>
3451
3452 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3453
34542011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3455
3456 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3457 later (Bug#8403).
3458
34592011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3460
3461 Add lexical binding.
3462
3463 * window.c (Ftemp_output_buffer_show): New fun.
3464 (Fsave_window_excursion):
3465 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3466
3467 * lread.c (lisp_file_lexically_bound_p): New function.
3468 (Fload): Bind Qlexical_binding.
3469 (readevalloop): Remove `evalfun' arg.
3470 Bind Qinternal_interpreter_environment.
3471 (Feval_buffer): Bind Qlexical_binding.
3472 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3473 Mark as dynamic.
3474 (syms_of_lread): Declare `lexical-binding'.
3475
3476 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3477
3478 * keyboard.c (eval_dyn): New fun.
3479 (menu_item_eval_property): Use it.
3480
3481 * image.c (parse_image_spec): Use Ffunctionp.
3482
3483 * fns.c (concat, mapcar1): Accept byte-code-functions.
3484
3485 * eval.c (Fsetq): Handle lexical vars.
3486 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3487 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3488 (FletX, Flet): Obey lexical binding.
3489 (Fcommandp): Handle closures.
3490 (Feval): New `lexical' arg.
3491 (eval_sub): New function extracted from Feval. Use it almost
3492 everywhere where Feval was used. Look up vars in lexical env.
3493 Handle closures.
3494 (Ffunctionp): Move from subr.el.
3495 (Ffuncall): Handle closures.
3496 (apply_lambda): Remove `eval_flags'.
3497 (funcall_lambda): Handle closures and new byte-code-functions.
3498 (Fspecial_variable_p): New function.
3499 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3500 but without exporting it to Lisp.
3501
3502 * doc.c (Fdocumentation, store_function_docstring):
3503 * data.c (Finteractive_form): Handle closures.
3504
3505 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3506 interactive spec.
3507
3508 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3509 New byte-codes.
3510 (exec_byte_code): New function extracted from Fbyte_code to handle new
3511 calling convention for byte-code-functions. Add new byte-codes.
3512
3513 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3514
3515 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3516
35172011-03-31 Juanma Barranquero <lekktu@gmail.com>
3518
3519 * xdisp.c (redisplay_internal): Fix prototype.
3520
35212011-03-31 Eli Zaretskii <eliz@gnu.org>
3522
3523 * xdisp.c (SCROLL_LIMIT): New macro.
3524 (try_scrolling): Use it when setting scroll_limit.
3525 Limit scrolling to 100 screen lines.
3526 (redisplay_window): Even when falling back on "recentering",
3527 position point in the window according to scroll-conservatively,
3528 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3529
3530 (try_scrolling): When point is above the window, allow searching
3531 as far as scroll_max, or one screenful, to compute vertical
3532 distance from PT to the scroll margin position. This prevents
3533 try_scrolling from unnecessarily failing when
3534 scroll-conservatively is set to a value slightly larger than the
3535 window height. Clean up the case of PT below the margin at bottom
3536 of window: scroll_max can no longer be INT_MAX. When aggressive
3537 scrolling is in use, don't let point enter the opposite scroll
3538 margin as result of the scroll.
3539 (syms_of_xdisp) <scroll-conservatively>: Document the
3540 threshold of 100 lines for never-recentering scrolling.
3541
35422011-03-31 Juanma Barranquero <lekktu@gmail.com>
3543
3544 * dispextern.h (move_it_by_lines):
3545 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3546 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3547 (message_log_check_duplicate): Remove parameters `prev_bol' and
3548 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3549 (redisplay_internal): Remove parameter `preserve_echo_area',
3550 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3551
3552 * indent.c (Fvertical_motion):
3553 * window.c (window_scroll_pixel_based, Frecenter):
3554 Don't pass `need_y_p' to `move_it_by_lines'.
3555
35562011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3557
3558 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3559 steal a few bits to be more compact.
3560 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3561 Remove unneeded casts.
3562
3563 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3564
35652011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3566
3567 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3568 binding" message (bug#7967).
3569
35702011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3571
3572 Fix more problems found by GCC 4.6.0's static checks.
3573
3574 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3575 Remove unused local var.
3576
3577 * editfns.c (Fmessage_box): Remove unused local var.
3578
3579 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3580 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3581 Omit unused local vars.
3582 * window.c (shrink_windows): Omit unused local var.
3583 * menu.c (digest_single_submenu): Omit unused local var.
3584 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3585 Omit unused local var.
3586
3587 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3588 Don't assume string length fits in int.
3589 (keyremap_step, read_key_sequence): Use size_t for sizes.
3590 (read_key_sequence): Don't check last_real_key_start redundantly.
3591
3592 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3593 instead of alloca (Bug#8344).
3594
3595 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3596 (Fbacktrace_frame): Don't assume nframes fits in int.
3597
3598 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3599
3600 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3601 concerns.
3602
3603 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3604
3605 * cm.c (calccost): Turn while-do into do-while, for clarity.
3606
3607 * keyboard.c (syms_of_keyboard): Use the same style as later
3608 in this function when indexing through an array. This also
3609 works around GCC bug 48267.
3610
3611 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3612
3613 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3614
3615 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3616 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3617
3618 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3619 This avoids undefined behavior on integer overflow, and is a bit
3620 more convenient anyway since it is compared to a size_t variable.
3621
3622 Variadic C functions now count arguments with size_t, not int.
3623 This avoids an unnecessary limitation on 64-bit machines, which
3624 caused (substring ...) to crash on large vectors (Bug#8344).
3625 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3626 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3627 All variadic functions and their callers changed accordingly.
3628 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3629 * data.c (arith_driver, float_arith_driver): Likewise.
3630 * editfns.c (general_insert_function): Likewise.
3631 * eval.c (struct backtrace.nargs, interactive_p)
3632 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3633 (funcall_lambda, mark_backtrace): Likewise.
3634 * fns.c (concat): Likewise.
3635 * frame.c (x_set_frame_parameters): Likewise.
3636 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3637 0 if not found, not -1. All callers changed.
3638
3639 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3640 (stack_copy_size): Now size_t, not int.
3641 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3642
36432011-03-28 Juanma Barranquero <lekktu@gmail.com>
3644
3645 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3646 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3647 All callers changed.
3648
3649 * lisp.h (multibyte_char_to_unibyte):
3650 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3651 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3652 * character.h (CHAR_TO_BYTE8):
3653 * cmds.c (internal_self_insert):
3654 * editfns.c (general_insert_function):
3655 * keymap.c (push_key_description):
3656 * search.c (Freplace_match):
3657 * xdisp.c (message_dolog, set_message_1): All callers changed.
3658
36592011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3660
3661 * keyboard.c (safe_run_hook_funcall): New function.
3662 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3663 don't set the hook to nil, but remove the offending function instead.
3664 (Qcommand_hook_internal): Remove, unused.
3665 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3666 Vcommand_hook_internal.
3667
3668 * eval.c (enum run_hooks_condition): Remove.
3669 (funcall_nil, funcall_not): New functions.
3670 (run_hook_with_args): Call each function through a `funcall' argument.
3671 Remove `cond' argument, now redundant.
3672 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3673 (Frun_hook_with_args_until_failure): Adjust accordingly.
3674 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3675
36762011-03-28 Juanma Barranquero <lekktu@gmail.com>
3677
3678 * dispextern.h (string_buffer_position): Remove declaration.
3679
3680 * print.c (strout): Remove parameter `multibyte', unused since
3681 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3682
3683 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3684 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3685 All callers changed.
3686
3687 * w32.c (_wsa_errlist): Use braces for struct initializers.
3688
3689 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3690 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3691 All callers changed.
3692 (string_buffer_position): Likewise. Also, make static (it's never
3693 used outside xdisp.c).
3694 (cursor_row_p): Remove parameter `w', unused since
3695 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3696 (decode_mode_spec): Remove parameter `precision', introduced during
3697 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3698 All callers changed.
3699
37002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3701
3702 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3703
37042011-03-27 Anders Lindgren <andlind@gmail.com>
3705
3706 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3707 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3708 (ns_update_auto_hide_menu_bar): New functions.
3709 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3710 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3711 ns_constrain_all_frames.
3712 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3713 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3714
37152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3716
3717 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3718
37192011-03-27 Glenn Morris <rgm@gnu.org>
3720
3721 * syssignal.h: Replace RETSIGTYPE with void.
3722 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3723 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3724 Replace SIGTYPE with void everywhere.
3725 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3726 * s/template.h (SIGTYPE): Remove commented out definition.
3727
37282011-03-26 Eli Zaretskii <eliz@gnu.org>
3729
3730 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3731 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3732
37332011-03-26 Juanma Barranquero <lekktu@gmail.com>
3734
3735 * w32.c (read_unc_volume): Use parameter `henum', instead of
3736 global variable `wget_enum_handle'.
3737
3738 * keymap.c (describe_vector): Remove parameters `indices' and
3739 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3740 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3741
3742 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3743
3744 * keyboard.c (timer_check): Remove parameter `do_it_now',
3745 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3746 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3747 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3748
3749 * keyboard.c (read_char):
3750 * w32menu.c (w32_menu_display_help):
3751 * xmenu.c (show_help_event, menu_help_callback):
3752 Adjust calls to `show_help_echo'.
3753
3754 * gtkutil.c (xg_maybe_add_timer):
3755 * keyboard.c (readable_events):
3756 * process.c (wait_reading_process_output):
3757 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3758
3759 * insdel.c (adjust_markers_gap_motion):
3760 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3761 (gap_left, gap_right): Don't call it.
3762
37632011-03-25 Chong Yidong <cyd@stupidchicken.com>
3764
3765 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3766 incurred during fontification.
3767
37682011-03-25 Juanma Barranquero <lekktu@gmail.com>
3769
3770 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3771 (DEFVAR_PER_BUFFER): Don't pass it.
3772
3773 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3774 (scrolling_window): Don't pass it.
3775
37762011-03-25 Juanma Barranquero <lekktu@gmail.com>
3777
3778 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3779
3780 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3781 and `suffix'.
3782 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3783 of variables specific to SELinux and computation of `encoded_absname'.
3784
3785 * image.c (XPutPixel): Remove unused variable `height'.
3786
3787 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3788
3789 * unexw32.c (get_section_info): Remove unused variable `section'.
3790
3791 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3792 (system_process_attributes): Remove unused variable `sess'.
3793 (sys_read): Remove unused variable `err'.
3794
3795 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3796 (w32_wnd_proc): Remove unused variable `isdead'.
3797 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3798 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3799 (x_create_tip_frame): Remove unused variable `tem'.
3800
3801 * w32inevt.c (w32_console_read_socket):
3802 Remove unused variable `no_events'.
3803
3804 * w32term.c (x_draw_composite_glyph_string_foreground):
3805 Remove unused variable `width'.
3806
38072011-03-24 Juanma Barranquero <lekktu@gmail.com>
3808
3809 * w32term.c (x_set_glyph_string_clipping):
3810 Don't pass uninitialized region to CombineRgn.
3811
38122011-03-23 Juanma Barranquero <lekktu@gmail.com>
3813
3814 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3815 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3816 (Fx_close_connection): Remove unused variable `i'.
3817
3818 * w32font.c (w32font_draw): Return number of glyphs.
3819 (w32font_open_internal): Remove unused variable `i'.
3820 (w32font_driver): Add missing initializer.
3821
3822 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3823 (fill_in_menu): Remove unused variable `items_added'.
3824
3825 * w32term.c (last_mouse_press_frame): Remove static global variable.
3826 (w32_clip_to_row): Remove unused variable `f'.
3827 (x_delete_terminal): Remove unused variable `i'.
3828
3829 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3830 (NOTHING): Remove unused static global variable.
3831 (uniscribe_check_otf): Remove unused variable `table'.
3832 (uniscribe_font_driver): Add missing initializers.
3833
38342011-03-23 Julien Danjou <julien@danjou.info>
3835
3836 * term.c (Fsuspend_tty, Fresume_tty):
3837 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3838 * window.c (temp_output_buffer_show):
3839 * insdel.c (signal_before_change):
3840 * frame.c (Fhandle_switch_frame):
3841 * fileio.c (Fdo_auto_save):
3842 * emacs.c (Fkill_emacs):
3843 * editfns.c (save_excursion_restore):
3844 * cmds.c (internal_self_insert):
3845 * callint.c (Fcall_interactively):
3846 * buffer.c (Fkill_all_local_variables):
3847 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3848 Use Frun_hooks.
3849 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3850 unconditionnaly since it does the check itself.
3851
38522011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3853
3854 Fix more problems found by GCC 4.5.2's static checks.
3855
3856 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3857 the first time through the loop, since we know p0 < p1 then.
3858 This also avoids a gcc -Wstrict-overflow warning.
3859
3860 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3861 leading to a memory leak, possible in functions like
3862 load_charset_map_from_file that can allocate an unbounded number
3863 of objects (Bug#8318).
3864
3865 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3866 that could (at least in theory) be that large.
3867
3868 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3869 This is less likely to overflow, and avoids undefined behavior if
3870 overflow does occur. All callers changed. Use strtoul to scan
3871 for the unsigned long integer.
3872 (pint2hrstr): Simplify and tune code slightly.
3873 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3874
3875 * scroll.c (do_scrolling): Work around GCC bug 48228.
3876 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3877
3878 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3879 This also avoids a warning with gcc -Wstrict-overflow.
3880 (validate_x_resource_name): Simplify count usage.
3881 This also avoids a warning with gcc -Wstrict-overflow.
3882
3883 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3884 fail (Bug#8306).
3885
3886 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3887
3888 * process.c (Fmake_network_process): Use socklen_t, not int,
3889 where POSIX says socklen_t is required in portable programs.
3890 This fixes a porting bug on hosts like 64-bit HP-UX, where
3891 socklen_t is wider than int (Bug#8277).
3892 (Fmake_network_process, server_accept_connection):
3893 (wait_reading_process_output, read_process_output):
3894 Likewise.
3895
3896 * process.c: Rename or move locals to avoid shadowing.
3897 (list_processes_1, Fmake_network_process):
3898 (read_process_output_error_handler, exec_sentinel_error_handler):
3899 Rename or move locals.
3900 (Fmake_network_process): Define label "retry_connect" only if needed.
3901 (Fnetwork_interface_info): Fix pointer signedness.
3902 (process_send_signal): Add cast to avoid pointer signedness problem.
3903 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3904 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3905
3906 Make tparam.h and terminfo.c consistent.
3907 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3908 Include tparam.h instead, since it declares them.
3909 * cm.h (PC): Remove extern decl; tparam.h now does this.
3910 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3911 * terminfo.c: Include tparam.h, to check interfaces.
3912 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3913 (tparam): Adjust signature to match interface in tparam.h;
3914 this removes some undefined behavior. Check that outstring and len
3915 are zero, which they always are with Emacs.
3916 * tparam.h (PC, BC, UP): New extern decls.
3917
3918 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3919 (xftfont_open): Rename locals to avoid shadowing.
3920
3921 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3922 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3923 (OTF_TAG_SYM): Omit macro if not needed.
3924 (ftfont_list): Remove unused local.
3925 (get_adstyle_property, ftfont_pattern_entity):
3926 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3927 Rename locals to avoid shadowing.
3928
3929 * xfont.c (xfont_list_family): Mark var as initialized.
3930
3931 * xml.c (make_dom): Now static.
3932
3933 * composite.c (composition_compute_stop_pos): Rename local to
3934 avoid shadowing.
3935 (composition_reseat_it): Remove unused locals.
3936 (find_automatic_composition, composition_adjust_point): Likewise.
3937 (composition_update_it): Mark var as initialized.
3938 (find_automatic_composition): Mark vars as initialized,
3939 with a FIXME (Bug#8290).
3940
3941 character.h: Rename locals to avoid shadowing.
3942 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3943 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3944 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3945 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3946 to avoid shadowing.
3947
3948 * textprop.c (property_change_between_p): Remove; unused.
3949
3950 * intervals.c (interval_start_pos): Now static.
3951
3952 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3953
3954 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3955 Rename locals to avoid shadowing.
3956
3957 * sound.c (wav_play, au_play, Fplay_sound_internal):
3958 Fix pointer signedness.
3959 (alsa_choose_format): Remove unused local var.
3960 (wav_play): Initialize a variable to 0, to prevent undefined
3961 behavior (Bug#8278).
3962
3963 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3964
3965 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3966
3967 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3968 clobbering (Bug#8298).
3969 * sysdep.c (sys_subshell): Likewise.
3970 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3971
3972 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3973 This should get cleaned up, so that child_setup has the
3974 same signature on all platforms.
3975
3976 * callproc.c (call_process_cleanup): Now static.
3977 (relocate_fd): Rename locals to avoid shadowing.
3978
39792011-03-22 Chong Yidong <cyd@stupidchicken.com>
3980
3981 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3982 not to be necessary, and produces flickering.
3983
39842011-03-20 Glenn Morris <rgm@gnu.org>
3985
3986 * config.in: Remove file.
3987
39882011-03-20 Juanma Barranquero <lekktu@gmail.com>
3989
3990 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3991 are now in src/globals.h.
3992 (syms_of_minibuf): Remove spurious & from previous change.
3993
39942011-03-20 Leo <sdl.web@gmail.com>
3995
3996 * minibuf.c (completing-read-function): New variable.
3997 (completing-read-default): Rename from completing-read.
3998 (completing-read): Call completing-read-function.
3999
40002011-03-19 Juanma Barranquero <lekktu@gmail.com>
4001
4002 * xfaces.c (Fx_load_color_file):
4003 Read color file from absolute filename (bug#8250).
4004
40052011-03-19 Juanma Barranquero <lekktu@gmail.com>
4006
4007 * makefile.w32-in: Update dependencies.
4008
40092011-03-17 Eli Zaretskii <eliz@gnu.org>
4010
4011 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4012
40132011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4014
4015 Fix more problems found by GCC 4.5.2's static checks.
4016
4017 * process.c (make_serial_process_unwind, send_process_trap):
4018 (sigchld_handler): Now static.
4019
4020 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4021 That way, the code declares only the vars that it needs.
4022 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4023 * s/cygwin.h (PTY_ITERATION): Likewise.
4024 * s/darwin.h (PTY_ITERATION): Likewise.
4025 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4026
4027 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4028 * process.c (allocate_pty): Don't declare stb unless it's needed.
4029
4030 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4031 (CONSTANTLIM): Remove; unused.
4032 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4033 Define only if needed.
4034
4035 * unexelf.c (unexec): Name an expression,
4036 to avoid gcc -Wbad-function-cast warning.
4037 Use a different way to cause a compilation error if anyone uses
4038 n rather than nn, a way that does not involve shadowing.
4039 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4040
4041 * deps.mk (unexalpha.o): Remove; unused.
4042
4043 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4044 * unexec.h: New file.
4045 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4046 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4047 Depend on unexec.h.
4048 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4049 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4050 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4051 Change as necessary to match prototype in unexec.h.
4052
4053 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4054 shadowing.
4055 (back_comment, skip_chars): Mark vars as initialized.
4056
4057 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4058 Rename locals to avoid shadowing.
4059
4060 * lread.c (read1): Rewrite so as not to use empty "else".
4061 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4062
4063 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4064
4065 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4066 warning when compiling print.c.
4067
4068 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4069 instead of using an uninitialized var.
4070 (font_sort_entities): Mark var as initialized.
4071
4072 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4073
4074 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4075 pointers to constants.
4076 (font_parse_fcname): Remove unused vars.
4077 (font_delete_unmatched): Now static.
4078 (font_get_spec): Remove; unused.
4079 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4080 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4081 Rename or move locals to avoid shadowing.
4082
4083 * fns.c (require_nesting_list, require_unwind): Now static.
4084 (Ffillarray): Rename locals to avoid shadowing.
4085
4086 * floatfns.c (domain_error2): Define only if needed.
4087 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4088
4089 * alloc.c (mark_backtrace): Move decl from here ...
4090 * lisp.h: ... to here, so that it can be checked.
4091
4092 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4093 (Fdefvar): Rewrite so as not to use empty "else".
4094 (lisp_indirect_variable): Name an expression,
4095 to avoid gcc -Wbad-function-cast warning.
4096 (Fdefvar): Rename locals to avoid shadowing.
4097
4098 * callint.c (quotify_arg, quotify_args): Now static.
4099 (Fcall_interactively): Rename locals to avoid shadowing.
4100 Use const pointer when appropriate.
4101
4102 * lisp.h (get_system_name, get_operating_system_release):
4103 Move decls here, to check interfaces.
4104 * process.c (get_operating_system_release): Move decl to lisp.h.
4105 * xrdb.c (get_system_name): Likewise.
4106 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4107 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4108 some of which prompt warnings from gcc -Wbad-function-cast.
4109 (Fformat_time_string, Fencode_time, Finsert_char):
4110 (Ftranslate_region_internal, Fformat):
4111 Rename or remove local vars to avoid shadowing.
4112 (Ftranslate_region_internal): Mark var as initialized.
4113
4114 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4115 avoid shadowing.
4116
4117 * lisp.h (eassert): Check that the argument compiles, even if
4118 ENABLE_CHECKING is not defined.
4119
4120 * data.c (Findirect_variable): Name an expression, to avoid
4121 gcc -Wbad-function-cast warning.
4122 (default_value, arithcompare, arith_driver, arith_error): Now static.
4123 (store_symval_forwarding): Rename local to avoid shadowing.
4124 (Fmake_variable_buffer_local, Fmake_local_variable):
4125 Mark variables as initialized.
4126 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4127
4128 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4129 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4130 Rename locals to avoid shadowing.
4131 (mark_stack): Move local variables into the #ifdef region where
4132 they're used.
4133 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4134 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4135 needed otherwise.
4136 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4137 (GC_STRING_CHARS): Remove; not used.
4138 (Fmemory_limit): Cast sbrk's returned value to char *.
4139
4140 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4141 avoids undefined behavior in theory.
4142
4143 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4144
4145 Use functions, not macros, for up- and down-casing (Bug#8254).
4146 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4147 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4148 to use the following functions instead of these macros.
4149 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4150 EMACS_INT, since callers assume the returned value fits in int.
4151 (upcase1): Likewise, for UPCASE_TABLE.
4152 (uppercasep, lowercasep, upcase): New static inline functions.
4153 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4154 the race-condition problem in the old DOWNCASE.
4155
4156 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4157 Rename locals to avoid shadowing.
4158 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4159 (regex_compile, re_search_2, re_match_2_internal):
4160 Remove unused local vars.
4161 (FREE_VAR): Rewrite so as not to use empty "else",
4162 which gcc can warn about.
4163 (regex_compile, re_match_2_internal): Mark locals as initialized.
4164 (RETALLOC_IF): Define only if needed.
4165 (WORDCHAR_P): Likewise. This one is never needed, but is used
4166 only in a comment talking about a compiler bug, so put inside
4167 the #if 0 of that comment.
4168 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4169 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4170 Remove; unused.
4171
4172 * search.c (boyer_moore): Rename locals to avoid shadowing.
4173 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4174 (PREV_CHAR_BOUNDARY): Likewise.
4175
4176 * search.c (simple_search): Remove unused var.
4177
4178 * dired.c (compile_pattern): Move decl from here ...
4179 * lisp.h: ... to here, so that it can be checked.
4180 (struct re_registers): New forward decl.
4181
4182 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4183
4184 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4185 All uses changed.
4186 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4187 Rename locals to avoid shadowing.
4188 (Fvertical_motion): Mark locals as initialized.
4189
4190 * casefiddle.c (casify_object, casify_region): Now static.
4191 (casify_region): Mark local as initialized.
4192
4193 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4194
4195 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4196 New macros, so that the caller can use some names other than
4197 gcpro1, gcpro2, etc.
4198 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4199 of the new macros.
4200 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4201 argument, for consistency with GCPRO2_VAR, etc: it is now the
4202 prefix of the variable, not the variable itself. All uses
4203 changed.
4204 * dired.c (directory_files_internal, file_name_completion):
4205 Rename locals to avoid shadowing.
4206
4207 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4208 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4209 dired.c's scmp function, had undefined behavior.
4210 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4211 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4212 * buffer.h: ... to here, because these macros use current_buffer,
4213 and the new implementation with inline functions needs to have
4214 current_buffer in scope now, rather than later when the macros
4215 are used.
4216 (downcase, upcase1): New static inline functions.
4217 (DOWNCASE, UPCASE1): Reimplement using these functions.
4218 This avoids undefined behavior in expressions like
4219 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4220 from race conditions in accessing the global variables
4221 case_temp1 and case_temp2.
4222 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4223 * lisp.h (case_temp1, case_temp2): Remove their decls.
4224 * character.h (ASCII_CHAR_P): Move from here ...
4225 * lisp.h: ... to here, so that the inline functions mentioned
4226 above can use them.
4227
4228 * dired.c (directory_files_internal_unwind): Now static.
4229
4230 * fileio.c (file_name_as_directory, directory_file_name):
4231 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4232 Now static.
4233 (file_name_as_directory): Use const pointers when appropriate.
4234 (Fexpand_file_name): Likewise. In particular, newdir might
4235 point at constant storage, so make it a const pointer.
4236 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4237 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4238 signedness issues.
4239 (Fset_file_times, Finsert_file_contents, auto_save_error):
4240 Rename locals to avoid shadowing.
4241
4242 * minibuf.c (choose_minibuf_frame_1): Now static.
4243 (Ftry_completion, Fall_completions): Rename or remove locals
4244 to avoid shadowing.
4245
4246 * marker.c (bytepos_to_charpos): Remove; unused.
4247
4248 * lisp.h (verify_bytepos, count_markers): New decls,
4249 so that gcc does not warn that these functions aren't declared.
4250
4251 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4252 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4253 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4254 (copy_text): Remove unused local var.
4255
4256 * filelock.c (within_one_second): Now static.
4257 (lock_file_1): Rename local to avoid shadowing.
4258
4259 * buffer.c (fix_overlays_before): Mark locals as initialized.
4260 (fix_start_end_in_overlays): Likewise. This function should be
4261 simplified by using pointers-to-pointers, but that's a different
4262 matter.
4263 (switch_to_buffer_1): Now static.
4264 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4265 (report_overlay_modification): Rename locals to avoid shadowing.
4266
4267 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4268 Fix pointer signedness issue.
4269 (sys_subshell): Mark local as volatile if checking for lint,
4270 to suppress a gcc -Wclobbered warning that does not seem to be right.
4271 (MAXPATHLEN): Define only if needed.
4272
4273 * process.c (serial_open, serial_configure): Move decls from here ...
4274 * systty.h: ... to here, so that they can be checked.
4275
4276 * fns.c (get_random, seed_random): Move extern decls from here ...
4277 * lisp.h: ... to here, so that they can be checked.
4278
4279 * sysdep.c (reset_io): Now static.
4280 (wait_for_termination_signal): Remove; unused.
4281
4282 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4283 (copy_keymap_item, append_key, push_text_char_description):
4284 Now static.
4285 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4286 (DENSE_TABLE_SIZE): Remove; unused.
4287 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4288 (describe_map_tree):
4289 Rename locals to avoid shadowing.
4290
4291 * keyboard.c: Declare functions static if they are not used elsewhere.
4292 (echo_char, echo_dash, cmd_error, top_level_2):
4293 (poll_for_input, handle_async_input): Now static.
4294 (read_char, kbd_buffer_get_event, make_lispy_position):
4295 (make_lispy_event, make_lispy_movement, apply_modifiers):
4296 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4297 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4298 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4299 (read_key_sequence, read_char): Mark locals as initialized.
4300 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4301
4302 * keyboard.h (make_ctrl_char): New decl.
4303 (mark_kboards): Move decl here ...
4304 * alloc.c (mark_kboards): ... from here.
4305
4306 * lisp.h (force_auto_save_soon): New decl.
4307
4308 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4309 (DEFINE_DUMMY_FUNCTION): New macro.
4310 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4311 Use it.
4312 (main): Add casts to avoid warnings
4313 if GCC considers string literals to be constants.
4314
4315 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4316
4317 * dbusbind.c: Pointer signedness fixes.
4318 (xd_signature, xd_append_arg, xd_initialize):
4319 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4320 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4321 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4322 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4323
4324 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4325 if GCC considers string literals to be constants.
4326 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4327
43282011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4329
4330 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4331 (print_preprocess, print_object): New macro to fix last change.
4332
4333 * print.c (print_preprocess): Don't forget font objects.
4334
43352011-03-16 Juanma Barranquero <lekktu@gmail.com>
4336
4337 * emacs.c (USAGE3): Doc fixes.
4338
43392011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4340
4341 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4342 structure.
4343
43442011-03-14 Juanma Barranquero <lekktu@gmail.com>
4345
4346 * lisp.h (VWindow_system, Qfile_name_history):
4347 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4348 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4349 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4350
4351 * w32select.c: Don't #include "keyboard.h".
4352 (run_protected): Add extern declaration for waiting_for_input.
4353
4354 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4355 * w32console.c (detect_input_pending, read_input_pending)
4356 (encode_terminal_code):
4357 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4358 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4359 (w32_system_caret_y, Qfile_name_history):
4360 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4361 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4362 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4363 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4364 * w32proc.c (Qlocal, report_file_error):
4365 * w32term.c (Vwindow_system, updating_frame):
4366 * w32uniscribe.c (initialized, uniscribe_font_driver):
4367 Remove unneeded extern declarations.
4368
43692011-03-14 Chong Yidong <cyd@stupidchicken.com>
4370
4371 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4372
43732011-03-13 Chong Yidong <cyd@stupidchicken.com>
4374
4375 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4376 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4377 These macros can no longer be used for assignment.
4378
4379 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4380 Assign struct members directly, instead of using BUF_BEGV etc.
4381 (record_buffer_markers, fetch_buffer_markers): New functions for
4382 recording and fetching special buffer markers.
4383 (set_buffer_internal_1, set_buffer_temp): Use them.
4384
4385 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4386
4387 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4388
4389 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4390 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4391
4392 * xdisp.c (hscroll_window_tree):
4393 (reconsider_clip_changes): Use PT instead of BUF_PT.
4394
43952011-03-13 Eli Zaretskii <eliz@gnu.org>
4396
4397 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4398 $(EMACS_ROOT)/lib/intprops.h.
4399
44002011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4401
4402 Fix more problems found by GCC 4.5.2's static checks.
4403
4404 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4405 to unsigned char * to avoid compiler diagnostic.
4406 (xg_free_frame_widgets): Make it clear that a local variable is
4407 needed only if USE_GTK_TOOLTIP.
4408 (gdk_window_get_screen): Make it clear that this macro is needed
4409 only if USE_GTK_TOOLTIP.
4410 (int_gtk_range_get_value): New function, which avoids a diagnostic
4411 from gcc -Wbad-function-cast.
4412 (xg_set_toolkit_scroll_bar_thumb): Use it.
4413 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4414 diagnostic from gcc -Wbad-function-cast.
4415 (get_utf8_string, xg_get_file_with_chooser):
4416 Rename locals to avoid shadowing.
4417 (create_dialog): Move locals to avoid shadowing.
4418
4419 * xgselect.c (xg_select): Remove unused var.
4420
4421 * image.c (four_corners_best): Mark locals as initialized.
4422 (gif_load): Initialize transparent_p to zero (Bug#8238).
4423 Mark another local as initialized.
4424 (my_png_error, my_error_exit): Mark with NO_RETURN.
4425
4426 * image.c (clear_image_cache): Now static.
4427 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4428 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4429 (x_edge_detection): Remove unnecessary cast that
4430 gcc -Wbad-function-cast diagnoses.
4431 (gif_load): Fix pointer signedness.
4432 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4433 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4434
44352011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4436
4437 Improve quality of tests for time stamp overflow.
4438 For example, without this patch (encode-time 0 0 0 1 1
4439 1152921504606846976) returns the obviously-bogus value (-948597
4440 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4441 reports time overflow. See
4442 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4443 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4444 * editfns.c: Include limits.h and intprops.h.
4445 (TIME_T_MIN, TIME_T_MAX): New macros.
4446 (time_overflow): Move earlier, to before first use.
4447 (hi_time, lo_time): New functions, for an accurate test for
4448 out-of-range times.
4449 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4450 (Fget_internal_run_time): Don't assume time_t fits in int.
4451 (make_time): Use list2 instead of Fcons twice.
4452 (Fdecode_time): More accurate test for out-of-range times.
4453 (check_tm_member): New function.
4454 (Fencode_time): Use it, to test for out-of-range times.
4455 (lisp_time_argument): Don't rely on undefined left-shift and
4456 right-shift behavior when checking for time stamp overflow.
4457
4458 * editfns.c (time_overflow): New function, refactoring common code.
4459 (Fformat_time_string, Fdecode_time, Fencode_time):
4460 (Fcurrent_time_string): Use it.
4461
4462 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4463 * dired.c (make_time): Move to ...
4464 * editfns.c (make_time): ... here.
4465 * systime.h: Note the move.
4466
44672011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4468
4469 * fringe.c (update_window_fringes): Remove unused variables.
4470
4471 * unexmacosx.c (copy_data_segment): Also copy __got section.
4472 (Bug#8223)
4473
44742011-03-12 Eli Zaretskii <eliz@gnu.org>
4475
4476 * termcap.c [MSDOS]: Include "msdos.h".
4477 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4478 Constify `char *' arguments and their references according to
4479 prototypes in tparam.h.
4480
4481 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4482
4483 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4484 Adapt all references accordingly.
4485
4486 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4487
44882011-03-11 Tom Tromey <tromey@redhat.com>
4489
4490 * buffer.c (syms_of_buffer): Remove obsolete comment.
4491
44922011-03-11 Eli Zaretskii <eliz@gnu.org>
4493
4494 * termhooks.h (encode_terminal_code): Declare prototype.
4495
4496 * msdos.c (encode_terminal_code): Don't declare prototype.
4497
4498 * term.c (encode_terminal_code): Now external again, used by
4499 w32console.c and msdos.c.
4500
4501 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4502 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4503
45042011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4505
4506 Fix some minor problems found by GCC 4.5.2's static checks.
4507
4508 * fringe.c (update_window_fringes): Mark locals as initialized
4509 (Bug#8227).
4510 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4511
4512 * alloc.c (mark_fringe_data): Move decl from here ...
4513 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4514 to check its interface.
4515 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4516
4517 * fontset.c (free_realized_fontset): Now static.
4518 (Fset_fontset_font): Rename local to avoid shadowing.
4519 (fontset_font): Mark local as initialized.
4520 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4521
4522 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4523
4524 * xselect.c (x_disown_buffer_selections): Remove; not used.
4525 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4526 (x_own_selection, Fx_disown_selection_internal): Rename locals
4527 to avoid shadowing.
4528 (x_handle_dnd_message): Remove local to avoid shadowing.
4529
4530 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4531 so that the caller can use some name other than gcpro1.
4532 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4533 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4534 (Fx_backspace_delete_keys_p):
4535 Use them to avoid shadowing, and rename vars to avoid shadowing.
4536 (x_decode_color, x_set_name, x_window): Now static.
4537 (Fx_create_frame): Add braces to silence GCC warning.
4538 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4539 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4540 Remove unused locals.
4541 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4542 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4543 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4544 macros.
4545
4546 * xterm.h (x_mouse_leave): New decl.
4547
4548 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4549 Remove unused functions.
4550 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4551 (x_calc_absolute_position): Now static.
4552 (XTread_socket): Don't define label "out" unless it's used.
4553 Don't declare local "event" unless it's used.
4554 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4555 unless they are used.
4556 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4557 (x_fatal_error_signal): Remove; not used.
4558 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4559 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4560 (x_error_catcher, x_connection_closed, x_error_handler):
4561 (x_error_quitter, xembed_send_message, x_iconify_frame):
4562 (my_log_handler): Rename locals to avoid shadowing.
4563 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4564 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4565
4566 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4567 Rename or move locals to avoid shadowing.
4568 (tty_defined_color, merge_face_heights): Now static.
4569 (free_realized_faces_for_fontset): Remove; not used.
4570 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4571 does not deduce is never used uninitialized.
4572 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4573 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4574
4575 * terminal.c (store_terminal_param): Now static.
4576
4577 * xmenu.c (menu_highlight_callback): Now static.
4578 (set_frame_menubar): Remove unused local.
4579 (xmenu_show): Rename parameter to avoid shadowing.
4580 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4581 since they might point to immutable storage.
4582 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4583 since it's unused otherwise.
4584
4585 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4586 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4587 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4588 avoids a gcc -Wuninitialized diagnostic.
4589 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4590 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4591 does not deduce are never used uninitialized.
4592
4593 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4594
4595 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4596 * window.c (window_loop, size_window):
4597 (run_window_configuration_change_hook, enlarge_window): Likewise.
4598
4599 * window.c (display_buffer): Now static.
4600 (size_window): Mark variables that gcc -Wuninitialized
4601 does not deduce are never used uninitialized.
4602 * window.h (check_all_windows): New decl, to forestall
4603 gcc -Wmissing-prototypes diagnostic.
4604 * dispextern.h (bidi_dump_cached_states): Likewise.
4605
4606 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4607 shadowing.
4608 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4609 Include <limits.h>.
4610 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4611 and to avoid gcc -Wuninitialized warning.
4612 (load_charset_map): Mark variables that gcc -Wuninitialized
4613 does not deduce are never used uninitialized.
4614 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4615
4616 * coding.c (coding_set_source, coding_set_destination):
4617 Use "else { /* comment */ }" rather than "else /* comment */;"
4618 for clarity, and to avoid gcc -Wempty-body warning.
4619 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4620 a block, when the outer 'i' will do.
4621 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4622 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4623 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4624 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4625 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4626 Rename locals to avoid shadowing.
4627 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4628 * coding.c (emacs_mule_char, encode_invocation_designation):
4629 Now static, since they're not used elsewhere.
4630 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4631 (decode_coding_object, encode_coding_object, detect_coding_system):
4632 (decode_coding_emacs_mule): Mark variables that gcc
4633 -Wuninitialized does not deduce are never used uninitialized.
4634 (detect_coding_iso_2022): Initialize a local variable that might
4635 be used uninitialized. Leave a FIXME because it's not clear that
4636 this initialization is needed. (Bug#8211)
4637 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4638 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4639 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4640 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4641 Remove unused macros.
4642
4643 * category.c (hash_get_category_set): Remove unused local var.
4644 (copy_category_table): Now static, since it's not used elsewhere.
4645 * character.c (string_count_byte8): Likewise.
4646
4647 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4648 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4649
4650 * chartab.c (copy_sub_char_table): Now static, since it's not used
4651 elsewhere.
4652 (sub_char_table_ref_and_range, char_table_ref_and_range):
4653 Rename locals to avoid shadowing.
4654 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4655
4656 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4657 (BIDI_BOB): Remove unused macro.
4658
4659 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4660 deduce are never used uninitialized.
4661 * term.c (encode_terminal_code): Likewise.
4662
4663 * term.c (encode_terminal_code): Now static. Remove unused local.
4664
4665 * tparam.h: New file.
4666 * term.c, tparam.h: Include it.
4667 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4668 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4669 Move these decls to tparam.h, and make them agree with what
4670 is actually in tparam.c. The previous trick of using incompatible
4671 decls in different modules does not conform to the C standard.
4672 All callers of tparam changed to use tparam's actual API.
4673 * tparam.c (tparam1, tparam, tgoto):
4674 Use const pointers where appropriate.
4675
4676 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4677 * cm.h (struct cm): Likewise.
4678 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4679 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4680 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4681 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4682 (turn_on_face, init_tty): Likewise.
4683 * termchar.h (struct tty_display_info): Likewise.
4684
4685 * term.c (term_mouse_position): Rename local to avoid shadowing.
4686
4687 * alloc.c (mark_ttys): Move decl from here ...
4688 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4689
46902011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4691
4692 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4693
46942011-03-09 Juanma Barranquero <lekktu@gmail.com>
4695
4696 * search.c (compile_pattern_1): Remove argument regp, unused since
4697 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4698 (compile_pattern): Don't pass it.
4699
47002011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4701
4702 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4703 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4704 for ! HAVE_GTK3.
4705 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4706
4707 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4708
4709 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4710 gdk_window_get_screen, gdk_window_get_geometry,
4711 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4712 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4713 (xg_get_pixbuf_from_pixmap): New function.
4714 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4715 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4716 Call xg_get_pixbuf_from_pixmap instead of
4717 gdk_pixbuf_get_from_drawable.
4718 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4719 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4720 (xg_check_special_colors): Use GtkStyleContext and its functions
4721 for HAVE_GTK3.
4722 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4723 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4724 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4725 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4726 Call gtk_widget_get_preferred_size.
4727 (xg_frame_resized): gdk_window_get_geometry only takes 5
4728 parameters.
4729 (xg_win_to_widget, xg_event_is_for_menubar):
4730 Call gdk_x11_window_lookup_for_display.
4731 (xg_set_widget_bg): New function.
4732 (delete_cb): New function.
4733 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4734 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4735 (xg_set_background_color): Call xg_set_widget_bg.
4736 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4737 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4738 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4739 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4740 if ! HAVE_GTK3.
4741 (update_frame_tool_bar): Call gtk_widget_hide.
4742 (xg_initialize): Use GDK_KEY_g.
4743
4744 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4745 if ! HAVE_GTK3
4746 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4747
4748 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4749 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4750 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4751
47522011-03-08 Juanma Barranquero <lekktu@gmail.com>
4753
4754 * w32xfns.c (select_palette): Check success of RealizePalette against
4755 GDI_ERROR, not zero.
4756
4757See ChangeLog.11 for earlier changes.
4758
4759;; Local Variables:
4760;; coding: utf-8
4761;; End:
4762
4763 Copyright (C) 2011 Free Software Foundation, Inc.
4764
4765 This file is part of GNU Emacs.
4766
4767 GNU Emacs is free software: you can redistribute it and/or modify
4768 it under the terms of the GNU General Public License as published by
4769 the Free Software Foundation, either version 3 of the License, or
4770 (at your option) any later version.
4771
4772 GNU Emacs is distributed in the hope that it will be useful,
4773 but WITHOUT ANY WARRANTY; without even the implied warranty of
4774 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4775 GNU General Public License for more details.
4776
4777 You should have received a copy of the GNU General Public License
4778 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.