Expose window-tree functions in Elisp.
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12011-06-06 Martin Rudalics <rudalics@gmx.at>
2
3 * window.c (decode_window, decode_any_window): Move up in code.
4 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5 (inhibit_frame_unsplittable): Remove unused variable.
6 (Fwindow_buffer): Move up and rewrite doc-string.
7 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8 (Fwindow_prev): New functions.
9
102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11
12 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
13 Do not assume that spare memory exists; that assumption is valid
14 only if SYSTEM_MALLOC.
15 (LARGE_REQUEST): New macro, so that the issue of large requests
16 is separated from the issue of spare memory.
17
182011-06-05 Andreas Schwab <schwab@linux-m68k.org>
19
20 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
21 format. (Bug#8806)
22
23 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
24
25 * xfns.c (x_set_scroll_bar_default_width): Move declarations
26 before statements.
27
282011-06-05 Jan Djärv <jan.h.d@swipnet.se>
29
30 * gtkutil.c (xg_get_default_scrollbar_width): New function.
31
32 * gtkutil.h: Declare xg_get_default_scrollbar_width.
33
34 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
35 min width by calling x_set_scroll_bar_default_width (Bug#8505).
36
372011-06-05 Juanma Barranquero <lekktu@gmail.com>
38
39 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
40
412011-06-04 Chong Yidong <cyd@stupidchicken.com>
42
43 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
44 (x_clipboard_manager_save): Add return value.
45 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
46 error handlers.
47 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
48 Obey Vx_select_enable_clipboard_manager. Catch errors in
49 x_clipboard_manager_save (Bug#8779).
50 (Vx_select_enable_clipboard_manager): New variable.
51 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
52
532011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
54
55 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
56
572011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
58
59 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
60 in the current matrix if keep_current_p is non-zero.
61
622011-06-04 Eli Zaretskii <eliz@gnu.org>
63
64 * bidi.c (bidi_level_of_next_char): Fix last change.
65
662011-06-03 Eli Zaretskii <eliz@gnu.org>
67
68 Support bidi reordering of text covered by display properties.
69
70 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
71 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
72 (bidi_cache_search, bidi_cache_iterator_state)
73 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
74 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
75 character positions inside a run of characters covered by a
76 display string.
77 (bidi_paragraph_init, bidi_resolve_explicit_1)
78 (bidi_level_of_next_char): Call bidi_fetch_char and
79 bidi_fetch_char_advance instead of FETCH_CHAR and
80 FETCH_CHAR_ADVANCE.
81 (bidi_init_it): Initialize new members.
82 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
83 definitions.
84 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
85 instead of using explicit *_CHAR codes.
86 (bidi_resolve_explicit, bidi_resolve_weak): Use
87 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
88 bidirectional text is supported only in multibyte buffers.
89 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
90 it to initialize the frame_window_p member of struct bidi_it.
91 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
92 (bidi_resolve_explicit, bidi_resolve_weak)
93 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
94 bidi_it->nchars is non-positive.
95 (bidi_level_of_next_char): Don't try to lookup the cache for the
96 next/previous character if nothing is cached there yet, or if we
97 were just reseat()'ed to a new position.
98
99 * xdisp.c (set_cursor_from_row): Set start and stop points
100 according to the row's direction when priming the loop that looks
101 for the glyph on which to display cursor.
102 (single_display_spec_intangible_p): Function deleted.
103 (display_prop_intangible_p): Reimplement to call
104 handle_display_spec instead of single_display_spec_intangible_p.
105 Accept 3 additional arguments needed by handle_display_spec. This
106 fixes incorrect cursor motion across display property with complex
107 values: lists, `(when COND...)' forms, etc.
108 (single_display_spec_string_p): Support property values that are
109 lists with the argument STRING its top-level element.
110 (display_prop_string_p): Fix the condition for processing a
111 property that is a list to be consistent with handle_display_spec.
112 (handle_display_spec): New function, refactored from the
113 last portion of handle_display_prop.
114 (compute_display_string_pos): Accept additional argument
115 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
116 value of a `display' property is a "replacing spec".
117 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
118 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
119 the display property, but just return a value indicating whether
120 the display property will replace the characters it covers.
121 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
122 frame_window_p members of struct bidi_it.
123 (compute_display_string_pos, compute_display_string_end): New
124 functions.
125 (push_it): Accept second argument POSITION, where pop_it should
126 jump to continue iteration.
127 (reseat_1): Initialize bidi_it.disp_pos.
128
129 * keyboard.c (adjust_point_for_property): Adjust the call to
130 display_prop_intangible_p to its new signature.
131
132 * dispextern.h (struct bidi_it): New member frame_window_p.
133 (bidi_init_it): Update prototypes.
134 (display_prop_intangible_p): Update prototype.
135 (compute_display_string_pos, compute_display_string_end): Declare
136 prototypes.
137 (struct bidi_it): New members nchars and disp_pos. ch_len is now
138 EMACS_INT.
139
1402011-06-02 Paul Eggert <eggert@cs.ucla.edu>
141
142 Malloc failure behavior now depends on size of allocation.
143 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
144 * lisp.h: Change signatures accordingly.
145 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
146 All callers changed. (Bug#8762)
147
148 * gnutls.c: Use Emacs's memory allocators.
149 Without this change, the gnutls library would invoke malloc etc.
150 directly, which causes problems on non-SYNC_INPUT hosts, and which
151 runs afoul of improving memory_full behavior. (Bug#8761)
152 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
153 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
154 xfree instead of the default malloc, realloc, free.
155 (Fgnutls_boot): No need to check for memory allocation failure,
156 since xmalloc does that for us.
157
158 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
159 * category.c (hash_get_category_set):
160 * ccl.c (ccl_driver):
161 * charset.c (Fdefine_charset_internal):
162 * charset.h (struct charset.hash_index):
163 * composite.c (get_composition_id, gstring_lookup_cache)
164 (composition_gstring_put_cache):
165 * composite.h (struct composition.hash_index):
166 * dispextern.h (struct image.hash):
167 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
168 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
169 (hashfn_equal, hashfn_user_defined, make_hash_table)
170 (maybe_resize_hash_table, hash_lookup, hash_put)
171 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
172 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
173 (Fsxhash, Fgethash, Fputhash, Fmaphash):
174 * image.c (make_image, search_image_cache, lookup_image)
175 (xpm_put_color_table_h):
176 * lisp.h (struct Lisp_Hash_Table):
177 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
178 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
179 for hashes and hash indexes, instead of 'unsigned' and 'int'.
180 * alloc.c (allocate_vectorlike):
181 Check for overflow in vector size calculations.
182 * ccl.c (ccl_driver):
183 Check for overflow when converting EMACS_INT to int.
184 * fns.c, image.c: Remove unnecessary static decls that would otherwise
185 need to be updated by these changes.
186 * fns.c (make_hash_table, maybe_resize_hash_table):
187 Check for integer overflow with large hash tables.
188 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
189 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
190 (SXHASH_REDUCE): New macro.
191 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
192 Use it instead of discarding useful hash info with large hash values.
193 (sxhash_float): New function.
194 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
195 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
196 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
197 Rewrite to use FIXNUM_BITS, as this simplifies things.
198 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
199 Adjust signatures to match updated version of code.
200 (consing_since_gc): Now EMACS_INT, since a single hash table can
201 use more than INT_MAX bytes.
202
2032011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
204
205 Make it possible to build with GCC-4.6+ -O2 -flto.
206
207 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
208
2092011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
210
211 * minibuf.c (get_minibuffer, read_minibuf_unwind):
212 Call minibuffer-inactive-mode.
213
2142011-05-31 Juanma Barranquero <lekktu@gmail.com>
215
216 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
217 Update dependencies.
218
2192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
220
221 * data.c (init_data): Remove code for UTS, this system is not
222 supported anymore.
223
2242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
225
226 Don't force ./temacs to start in terminal mode.
227
228 * frame.c (make_initial_frame): Initialize faces in all cases, not
229 only when CANNOT_DUMP is defined.
230 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
231
2322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
233
234 * dispnew.c (add_window_display_history): Use const for the string
235 pointer. Remove declaration, not needed.
236
2372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
238
239 Use 'inline', not 'INLINE'.
240 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
241 * alloc.c, fontset.c (INLINE): Remove.
242 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
243 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
244 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
245 * gmalloc.c (register_heapinfo): Use inline unconditionally.
246 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
247
2482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
249
250 Make it possible to run ./temacs.
251
252 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
253 syms_of_callproc does the same thing. Remove test for
254 "initialized", do it in the caller.
255 * emacs.c (main): Avoid calling set_initial_environment when dumping.
256
2572011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
258
259 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
260 (read_minibuf): Use get_minibuffer.
261 (syms_of_minibuf): Use DEFSYM.
262 (Qmetadata): New var.
263 * data.c (Qbuffer): Don't make it static.
264 (syms_of_data): Use DEFSYM.
265
2662011-05-31 Paul Eggert <eggert@cs.ucla.edu>
267
268 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
269 (CCL_CODE_MIN): New macro.
270
2712011-05-30 Paul Eggert <eggert@cs.ucla.edu>
272
273 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
274
275 * eval.c (Qdebug): Now static.
276 * lisp.h (Qdebug): Remove decl. This reverts a part of the
277 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
278 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
279
2802011-05-29 Chong Yidong <cyd@stupidchicken.com>
281
282 * image.c: Various fixes to ImageMagick code comments.
283 (Fimagemagick_types): Doc fix.
284
2852011-05-29 Paul Eggert <eggert@cs.ucla.edu>
286
287 Minor fixes prompted by GCC 4.6.0 warnings.
288
289 * xselect.c (converted_selections, conversion_fail_tag): Now static.
290
291 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
292 (x_clipboard_manager_save_all): Move extern decl to ...
293 * xterm.h: ... here, so that it can be checked for consistency.
294
2952011-05-29 Chong Yidong <cyd@stupidchicken.com>
296
297 * xselect.c (x_clipboard_manager_save_frame)
298 (x_clipboard_manager_save_all): New functions.
299 (Fx_clipboard_manager_save): Lisp function deleted.
300
301 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
302 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
303
304 * xterm.h: Update prototype.
305
3062011-05-28 William Xu <william.xwl@gmail.com>
307
308 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
309 exiting (Bug#8239).
310
3112011-05-28 Jim Meyering <meyering@redhat.com>
312
313 Avoid a sign-extension bug in crypto_hash_function.
314 * fns.c (to_uchar): Define.
315 (crypto_hash_function): Use it to convert some newly-signed
316 variables to unsigned, to avoid sign-extension bugs. For example,
317 without this change, (md5 "truc") would evaluate to
318 45723a2aff78ff4fff7fff1114760e62 rather than the expected
319 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
320 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
321
3222011-05-27 Paul Eggert <eggert@cs.ucla.edu>
323
324 Integer overflow fixes.
325
326 * dbusbind.c: Serial number integer overflow fixes.
327 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
328 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
329 to hold a serial number that is too large for a fixnum.
330 (Fdbus_method_return_internal, Fdbus_method_error_internal):
331 Check for serial numbers out of range. Decode any serial number
332 that was so large that it became a float. (Bug#8722)
333
334 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
335 (Fdbus_call_method, Fdbus_call_method_asynchronously):
336 Use XFASTINT rather than XUINT when numbers are nonnegative.
337 (xd_append_arg, Fdbus_method_return_internal):
338 (Fdbus_method_error_internal): Likewise. Also, for unsigned
339 arguments, check that Lisp number is nonnegative, rather than
340 silently wrapping negative numbers around. (Bug#8722)
341 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
342 (Bug#8722)
343
344 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
345
346 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
347
348 ccl: add integer overflow checks
349 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
350 (IN_INT_RANGE): New macros.
351 (ccl_driver): Use them to check for integer overflow when
352 decoding a CCL program. Many of the new checks are whether XINT (x)
353 fits in int; it doesn't always, on 64-bit hosts. The new version
354 doesn't catch all possible integer overflows, but it's an
355 improvement. (Bug#8719)
356
357 * alloc.c (make_event_array): Use XINT, not XUINT.
358 There's no need for unsigned here.
359
360 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
361 This follows up to the 2011-05-06 change that substituted uintptr_t
362 for EMACS_INT. This case wasn't caught back then.
363
364 Rework Fformat to avoid integer overflow issues.
365 * editfns.c: Include <float.h> unconditionally, as it's everywhere
366 now (part of C89). Include <verify.h>.
367 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
368 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
369 (Fformat): Avoid the prepass trying to compute sizes; it was only
370 approximate and thus did not catch overflow reliably. Instead, walk
371 through the format just once, formatting and computing sizes as we go,
372 checking for integer overflow at every step, and allocating a larger
373 buffer as needed. Keep track separately whether the format is
374 multibyte. Keep only the most-recently calculated precision, rather
375 than them all. Record whether each argument has been converted to
376 string. Use EMACS_INT, not int, for byte and char and arg counts.
377 Support field widths and precisions larger than INT_MAX. Avoid
378 sprintf's undefined behavior with conversion specifications such as %#d
379 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
380 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
381 formatting out-of-range floating point numbers with int
382 formats. (Bug#8668)
383
384 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
385
386 * data.c: Avoid integer truncation in expressions involving floats.
387 * data.c: Include <intprops.h>.
388 (arith_driver): When there's an integer overflow in an expression
389 involving floating point, convert the integers to floating point
390 so that the resulting value does not suffer from catastrophic
391 integer truncation. For example, on a 64-bit host (* 4
392 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
393 Do not rely on undefined behavior after integer overflow.
394
395 merge count_size_as_multibyte, parse_str_to_multibyte
396 * character.c, character.h (count_size_as_multibyte):
397 Rename from parse_str_to_multibyte; all uses changed.
398 Check for integer overflow.
399 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
400 since it's now a duplicate of the other. This is more of
401 a character than a buffer op, so better that it's in character.c.
402 * fns.c, print.c: Adjust to above changes.
403
4042011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
405
406 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
407
4082011-05-27 Paul Eggert <eggert@cs.ucla.edu>
409
410 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
411 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
412 (x_clipboard_manager_save): Now static.
413 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
414
415 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
416 (crypto_hash_function): Now static.
417 Fix pointer signedness problems. Avoid unnecessary initializations.
418
4192011-05-27 Chong Yidong <cyd@stupidchicken.com>
420
421 * termhooks.h (Vselection_alist): Make it terminal-local.
422
423 * terminal.c (create_terminal): Initialize it.
424
425 * xselect.c: Support for clipboard managers.
426 (Vselection_alist): Move to termhooks.h as terminal-local var.
427 (LOCAL_SELECTION): New macro.
428 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
429 (symbol_to_x_atom): Remove gratuitous arg.
430 (x_handle_selection_request, lisp_data_to_selection_data)
431 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
432 (x_own_selection, x_get_local_selection, x_convert_selection):
433 New arg, specifying work frame. Use terminal-local Vselection_alist.
434 (some_frame_on_display): Delete unused function.
435 (Fx_own_selection_internal, Fx_get_selection_internal)
436 (Fx_disown_selection_internal, Fx_selection_owner_p)
437 (Fx_selection_exists_p): New optional frame arg.
438 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
439 (x_handle_selection_clear): Don't treat other terminals with the
440 same keyboard specially. Use the terminal-local Vselection_alist.
441 (x_clear_frame_selections): Use Frun_hook_with_args.
442
443 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
444
445 * xterm.h: Add support for those atoms.
446
4472011-05-26 Chong Yidong <cyd@stupidchicken.com>
448
449 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
450 (converted_selections, conversion_fail_tag): New global variables.
451 (x_selection_request_lisp_error): Free the above.
452 (x_get_local_selection): Remove unnecessary code.
453 (x_reply_selection_request): Args changed; handle arbitrary array
454 of converted selections stored in converted_selections.
455 Separate the XChangeProperty and SelectionNotify steps.
456 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
457 (x_convert_selection): New function.
458 (x_handle_selection_event): Simplify.
459 (x_get_foreign_selection): Don't ignore incoming requests while
460 waiting for an answer; this will fail when we implement
461 SAVE_TARGETS, and seems unnecessary anyway.
462 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
463 (Vx_sent_selection_functions): Doc fix.
464
4652011-05-26 Leo Liu <sdl.web@gmail.com>
466
467 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
468
4692011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
470
471 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
472
473 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
474 for fringe update if it has periodic bitmap.
475 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
476 and fringe_bitmap_periodic_p.
477
478 * fringe.c (get_fringe_bitmap_data): New function.
479 (draw_fringe_bitmap_1, update_window_fringes): Use it.
480 (update_window_fringes): Record periodicity of fringe bitmap in glyph
481 row. Mark glyph row for fringe update if periodicity changed.
482
483 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
484 for fringe update unless it has periodic bitmap.
485
4862011-05-25 Kenichi Handa <handa@m17n.org>
487
488 * xdisp.c (get_next_display_element): Set correct it->face_id for
489 a static composition.
490
4912011-05-24 Leo Liu <sdl.web@gmail.com>
492
493 * deps.mk (fns.o):
494 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
495
496 * fns.c (crypto_hash_function, Fsha1): New function.
497 (Fmd5): Use crypto_hash_function.
498 (syms_of_fns): Add Ssha1.
499
5002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
501
502 * gnutls.c: Remove unused macros.
503 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
504 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
505 Remove macros that are defined and never used.
506 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
507
5082011-05-22 Chong Yidong <cyd@stupidchicken.com>
509
510 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
511 (Fx_get_selection_internal): Minor cleanup.
512 (Fx_own_selection_internal): Rename arguments for consistency with
513 select.el.
514
5152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
516
517 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
518
5192011-05-22 Chong Yidong <cyd@stupidchicken.com>
520
521 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
522
5232011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
524
525 * dispnew.c (scrolling_window): Don't exclude the case that the
526 last enabled row in the desired matrix touches the bottom boundary.
527
5282011-05-21 Glenn Morris <rgm@gnu.org>
529
530 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
531 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
532 and add some more files.
533
5342011-05-20 Eli Zaretskii <eliz@gnu.org>
535
536 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
537 report_file_error introduced by the change from 2011-05-07.
538
5392011-05-20 Paul Eggert <eggert@cs.ucla.edu>
540
541 * systime.h (Time): Define only if emacs is defined.
542 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
543 where the include path doesn't have X11/X.h by default. See
544 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
545
5462011-05-20 Kenichi Handa <handa@m17n.org>
547
548 * composite.c (find_automatic_composition): Fix previous change.
549
5502011-05-20 Glenn Morris <rgm@gnu.org>
551
552 * lisp.mk: New file, split from Makefile.in.
553 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
554 (shortlisp): Remove.
555 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
556
5572011-05-19 Glenn Morris <rgm@gnu.org>
558
559 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
560 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
561 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
562 (lisp): Set the order to that of loadup.el.
563 (shortlisp): Make it a copy of $lisp.
564 (SOME_MACHINE_LISP): Remove.
565 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
566 Use just $shortlisp, not $SOME_MACHINE_LISP too.
567
5682011-05-18 Kenichi Handa <handa@m17n.org>
569
570 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
571 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
572 (find_automatic_composition): Mostly rewrite for efficiency.
573
5742011-05-18 Juanma Barranquero <lekktu@gmail.com>
575
576 * makefile.w32-in: Update dependencies.
577
5782011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
579
580 * menu.c: Include limits.h (fixes the MS-Windows build broken by
581 revision 104625).
582
5832011-05-18 Paul Eggert <eggert@cs.ucla.edu>
584
585 Fix some integer overflow issues, such as string length overflow.
586
587 * insdel.c (count_size_as_multibyte): Check for string overflow.
588
589 * character.c (lisp_string_width): Check for string overflow.
590 Use EMACS_INT, not int, for string indexes and lengths; in
591 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
592 the resulting string length overflows an EMACS_INT; instead,
593 report a string overflow if no precision given. When checking for
594 precision exhaustion, use a check that cannot possibly have
595 integer overflow. (Bug#8675)
596 * character.h (lisp_string_width): Adjust to new signature.
597
598 * alloc.c (string_overflow): New function.
599 (Fmake_string): Use it. This doesn't change behavior, but saves
600 a few bytes and will simplify future changes.
601 * character.c (string_escape_byte8): Likewise.
602 * lisp.h (string_overflow): New decl.
603
604 Fixups, following up to the user-interface timestamp change.
605 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
606 for UI timestamps, instead of unsigned long.
607 * msdos.c (mouse_get_pos): Likewise.
608 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
609 * w32gui.h (Time): Define by including "systime.h" rather than by
610 declaring it ourselves. (Bug#8664)
611
612 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
613 * image.c (clear_image_cache): Likewise.
614
615 * term.c (term_mouse_position): Don't assume time_t wraparound.
616
617 Be more systematic about user-interface timestamps.
618 Before, the code sometimes used 'Time', sometimes 'unsigned long',
619 and sometimes 'EMACS_UINT', to represent these timestamps.
620 This change causes it to use 'Time' uniformly, as that's what X uses.
621 This makes the code easier to follow, and makes it easier to catch
622 integer overflow bugs such as Bug#8664.
623 * frame.c (Fmouse_position, Fmouse_pixel_position):
624 Use Time, not unsigned long, for user-interface timestamps.
625 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
626 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
627 * keyboard.h (last_event_timestamp): Likewise.
628 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
629 * menu.h (xmenu_show): Likewise.
630 * term.c (term_mouse_position): Likewise.
631 * termhooks.h (struct input_event.timestamp): Likewise.
632 (struct terminal.mouse_position_hook): Likewise.
633 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
634 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
635 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
636 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
637 what it was before.
638 * menu.h, termhooks.h: Include "systime.h", for Time.
639
640 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
641 Don't assume that the difference between two unsigned long values
642 can fit into an integer. At this point, we know button_down_time
643 <= event->timestamp, so the difference must be nonnegative, so
644 there's no need to cast the result if double-click-time is
645 nonnegative, as it should be; check that it's nonnegative, just in
646 case. This bug is triggered when events are more than 2**31 ms
647 apart (about 25 days). (Bug#8664)
648
649 * xselect.c (last_event_timestamp): Remove duplicate decl.
650 (x_own_selection): Remove needless cast to unsigned long.
651
652 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
653 that always fit in int. Use a sentinel instead of a counter, to
654 avoid a temp and to allay GCC's concerns about possible int overflow.
655 * frame.h (struct frame): Use int for menu_bar_items_used
656 instead of EMACS_INT, since it always fits in int.
657
658 * menu.c (grow_menu_items): Check for int overflow.
659
660 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
661
662 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
663 Before, the code was not consistent. These values cannot exceed
664 2**31 - 1 so there's no need to make them unsigned.
665 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
666 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
667 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
668 as modifiers.
669 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
670
671 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
672 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
673 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
674 presumably because the widths might not match.
675
676 * window.c (size_window): Avoid needless test at loop start.
677
6782011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
679
680 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
681
6822011-05-12 Drew Adams <drew.adams@oracle.com>
683
684 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
685
6862011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
687
688 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
689 `width' to `bar_area_x' and `bar_area_width', respectively.
690 (x_scroll_run): Take account of fringe background extension.
691
692 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
693 Rename local vars `left' and `width' to `bar_area_x' and
694 `bar_area_width', respectively.
695 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
696 background extension.
697
6982011-05-10 Jim Meyering <meyering@redhat.com>
699
700 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
701
7022011-05-10 Juanma Barranquero <lekktu@gmail.com>
703
704 * image.c (Finit_image_library): Return t for built-in image types,
705 like pbm and xbm. (Bug#8640)
706
7072011-05-09 Andreas Schwab <schwab@linux-m68k.org>
708
709 * w32menu.c (set_frame_menubar): Fix submenu allocation.
710
7112011-05-07 Eli Zaretskii <eliz@gnu.org>
712
713 * w32console.c (Fset_screen_color): Doc fix.
714 (Fget_screen_color): New function.
715 (syms_of_ntterm): Defsubr it.
716
717 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
718 unlink the temporary file if Fcall_process didn't create it in the
719 first place.
720 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
721 child process will be redirected to a file specified with `:file'.
722 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
723 cue to call_process_cleanup not to close that handle.
724
7252011-05-07 Ben Key <bkey76@gmail.com>
726
727 * makefile.w32-in: The bootstrap-temacs rule now makes use of
728 one of two shell specific rules, either bootstrap-temacs-CMD or
729 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
730 to the previous implementation of the bootstrap-temacs rule.
731 The bootstrap-temacs-CMD rule is similar to the previous
732 implementation of the bootstrap-temacs rule except that it
733 makes use of the ESC_CFLAGS variable instead of the CFLAGS
734 variable.
735
736 These changes, along with some changes to nt/configure.bat,
737 nt/gmake.defs, and nt/nmake.defs, are required to extend my
738 earlier fix to add support for --cflags and --ldflags options
739 that include quotes so that it works whether make uses cmd or
740 sh as the shell.
741
7422011-05-06 Michael Albinus <michael.albinus@gmx.de>
743
744 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
745 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
746 is a constant.
747 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
748 a string. Handle both cases.
749 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
750 (Fdbus_register_method): Use Qinvalid_function.
751
7522011-05-06 Juanma Barranquero <lekktu@gmail.com>
753
754 * makefile.w32-in: Update dependencies.
755 (LISP_H): Add inttypes.h and stdin.h.
756 (PROCESS_H): Add unistd.h.
757
7582011-05-06 Eli Zaretskii <eliz@gnu.org>
759
760 * lread.c: Include limits.h (fixes the MS-Windows build broken by
761 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
762
7632011-05-06 Paul Eggert <eggert@cs.ucla.edu>
764
765 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
766
767 * term.c (vfatal): Remove stray call to va_end.
768 It's not needed and the C Standard doesn't allow it here anyway.
769
770 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
771 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
772
773 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
774 bytes.
775
776 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
777
778 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
779
780 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
781
782 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
783
784 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
785
786 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
787 * charset.c (Fdefine_charset_internal): Don't initialize
788 charset.code_space[15]. The value was garbage, on hosts with
789 32-bit int (Bug#8600).
790
791 * lread.c (read_integer): Be more consistent with string-to-number.
792 Use string_to_number to do the actual conversion; this avoids
793 rounding errors and fixes some other screwups. Without this fix,
794 for example, #x1fffffffffffffff was misread as -2305843009213693952.
795 (digit_to_number): Move earlier, for benefit of read_integer.
796 Return -1 if the digit is out of range for the base, -2 if it is
797 not a digit in any supported base. (Bug#8602)
798
799 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
800
801 * dispnew.c (scrolling_window): Return 1 if we scrolled,
802 to match comment at start of function. This also removes a
803 GCC warning about overflow in a 32+64-bit port.
804
805 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
806
807 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
808 Reported by Stefan Monnier in
809 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
810 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
811 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
812
813 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
814 (EMACS_UINTPTR): Likewise, with uintptr_t.
815
816 * lisp.h: Prefer 64-bit EMACS_INT if available.
817 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
818 on 32-bit hosts that have 64-bit int, so that they can access
819 large files.
820 However, temporarily disable this change unless the temporary
821 symbol WIDE_EMACS_INT is defined.
822
823 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
824
825 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
826 This removes an assumption that EMACS_INT and long are the same
827 width as pointers. The assumption is true for Emacs porting targets
828 now, but we want to make other targets possible.
829 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
830 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
831 In the rest of the code, change types of integers that hold casted
832 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
833 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
834 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
835 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
836 No need to cast type when ORing.
837 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
838 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
839 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
840 assume EMACS_INT is the same width as char *.
841 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
842 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
843 Remove no-longer-needed casts.
844 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
845 (xg_tool_bar_help_callback, xg_make_tool_item):
846 Use EMACS_INTPTR to hold an integer
847 that will be cast to void *; this can avoid a GCC warning
848 if EMACS_INT is not the same width as void *.
849 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
850 * xdisp.c (display_echo_area_1, resize_mini_window_1):
851 (current_message_1, set_message_1):
852 Use a local to convert to proper width without a cast.
853 * xmenu.c (dialog_selection_callback): Likewise.
854
855 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
856 Also, don't assume VALBITS / RAND_BITS is less than 5,
857 and don't rely on undefined behavior when shifting a 1 left into
858 the sign bit.
859 * lisp.h (get_random): Change signature to match.
860
861 * lread.c (hash_string): Use size_t, not int, for hash computation.
862 Normally we prefer signed values; but hashing is special, because
863 it's better to use unsigned division on hash table sizes so that
864 the remainder is nonnegative. Also, size_t is the natural width
865 for hashing into memory. The previous code used 'int', which doesn't
866 retain enough info to hash well into very large tables.
867 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
868
869 * dbusbind.c: Don't possibly lose pointer info when converting.
870 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
871 Use XPNTR rather than XHASH, so that the high-order bits of
872 the pointer aren't lost when converting through void *.
873
874 * eval.c (Fautoload): Don't double-shift a pointer.
875
876 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
877
8782011-05-06 Juanma Barranquero <lekktu@gmail.com>
879
880 * gnutls.c (DEF_GNUTLS_FN):
881 * image.c (DEF_IMGLIB_FN): Make function pointers static.
882
8832011-05-05 Andreas Schwab <schwab@linux-m68k.org>
884
885 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
886 marker. (Bug#8610)
887
8882011-05-05 Eli Zaretskii <eliz@gnu.org>
889
890 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
891 New version that can reserve upto 2GB of heap space.
892
8932011-05-05 Chong Yidong <cyd@stupidchicken.com>
894
895 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
896
8972011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
898
899 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
900 `gnutls_certificate_set_x509_key_file'.
901
9022011-05-05 Juanma Barranquero <lekktu@gmail.com>
903
904 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
905 Update dependencies.
906
9072011-05-04 Juanma Barranquero <lekktu@gmail.com>
908
909 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
910 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
911 Remove unused parameter `fildes'.
912 * process.c (read_process_output, send_process): Don't pass it.
913
9142011-05-04 Juanma Barranquero <lekktu@gmail.com>
915
916 Fix previous change: the library cache is defined in w32.c.
917 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
918 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
919
9202011-05-04 Juanma Barranquero <lekktu@gmail.com>
921
922 Implement dynamic loading of GnuTLS on Windows.
923
924 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
925 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
926 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
927 Declare.
928
929 * gnutls.c (Qgnutls_dll): Define.
930 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
931 (gnutls_*): Declare function pointers.
932 (init_gnutls_functions): New function to initialize function pointers.
933 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
934 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
935 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
936 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
937 (emacs_gnutls_write, emacs_gnutls_read)
938 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
939 (Fgnutls_available_p): New function.
940 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
941 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
942 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
943
944 * image.c: Include w32.h.
945 (Vimage_type_cache): Delete.
946 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
947 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
948 (w32_delayed_load): Move to w32.c.
949
950 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
951
952 * w32.c (QCloaded_from, Vlibrary_cache): Define.
953 (w32_delayed_load): Move from image.c. When loading a library, record
954 its filename in the :loaded-from property of the library id.
955 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
956 Initialize and staticpro them.
957 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
958
959 * process.c: Include lisp.h before w32.h, not after.
960 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
961 instead of gnutls_record_check_pending.
962
963 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
964
9652011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
966
967 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
968 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
969 as passed in.
970
9712011-05-03 Jan Djärv <jan.h.d@swipnet.se>
972
973 * xterm.c (x_set_frame_alpha): Do not set property on anything
974 else than FRAME_X_OUTER_WINDOW (Bug#8608).
975
9762011-05-02 Juanma Barranquero <lekktu@gmail.com>
977
978 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
979
9802011-05-02 Juanma Barranquero <lekktu@gmail.com>
981
982 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
983 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
984 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
985 (gnutls_global_initialized, Qgnutls_bootprop_priority)
986 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
987 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
988 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
989 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
990 (Qgnutls_bootprop_callbacks_verify): Make static.
991
9922011-05-01 Andreas Schwab <schwab@linux-m68k.org>
993
994 * callproc.c: Indentation fixup.
995
996 * sysdep.c (wait_for_termination_1): Make static.
997 (wait_for_termination, interruptible_wait_for_termination):
998 Move after wait_for_termination_1.
999
10002011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1001
1002 * sysdep.c (interruptible_wait_for_termination): New function
1003 which is like wait_for_termination, but allows keyboard
1004 interruptions.
1005
1006 * callproc.c (Fcall_process): Add (:file "file") as an option for
1007 the STDOUT buffer.
1008 (Fcall_process_region): Ditto.
1009
10102011-04-30 Eli Zaretskii <eliz@gnu.org>
1011
1012 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1013 rather than `XVECTOR (FOO)->size'.
1014
1015 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1016 inttypes.h, as a gnulib replacement is used if it not available in
1017 system headers.
1018
10192011-04-21 Eli Zaretskii <eliz@gnu.org>
1020
1021 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1022 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1023 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1024
1025 * coding.c (coding_alloc_by_realloc): Error out if destination
1026 will grow beyond MOST_POSITIVE_FIXNUM.
1027 (decode_coding_emacs_mule): Abort if there isn't enough place in
1028 charbuf for the composition carryover bytes. Reserve an extra
1029 space for up to 2 characters produced in a loop.
1030 (decode_coding_iso_2022): Abort if there isn't enough place in
1031 charbuf for the composition carryover bytes.
1032
10332011-04-21 Eli Zaretskii <eliz@gnu.org>
1034
1035 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1036 aborting when %lld or %lll format is passed.
1037 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1038 %llo or %llx format is passed. (Bug#8545)
1039
1040 * window.c (window_scroll_line_based): Use a marker instead of
1041 simple variables to record original value of point. (Bug#7952)
1042
1043 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1044 produced by %s or %c overflows available buffer space. (Bug#8545)
1045
10462011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1047
1048 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1049 (SIZE_MAX): Move defn after all includes, as they might #define it.
1050
10512011-04-28 Juanma Barranquero <lekktu@gmail.com>
1052
1053 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1054
10552011-04-28 Juanma Barranquero <lekktu@gmail.com>
1056
1057 * keyboard.c (Qdelayed_warnings_hook): Define.
1058 (command_loop_1): Run `delayed-warnings-hook'
1059 if Vdelayed_warnings_list is non-nil.
1060 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1061 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1062
10632011-04-28 Eli Zaretskii <eliz@gnu.org>
1064
1065 * doprnt.c (doprnt): Don't return value smaller than the buffer
1066 size if the message was truncated. (Bug#8545).
1067
10682011-04-28 Juanma Barranquero <lekktu@gmail.com>
1069
1070 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1071 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1072
10732011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1074
1075 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1076
10772011-04-27 Juanma Barranquero <lekktu@gmail.com>
1078
1079 * makefile.w32-in: Update dependencies.
1080
10812011-04-27 Eli Zaretskii <eliz@gnu.org>
1082
1083 Improve `doprnt' and its usage. (Bug#8545)
1084 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1085 `format_end'. Remove support for %l as a conversion specifier.
1086 Don't use xrealloc. Improve diagnostics when the %l size modifier
1087 is used. Update the commentary.
1088
1089 * eval.c (verror): Simplify calculation of size_t.
1090
1091 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1092 messages.
1093
10942011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1095
1096 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1097 change.
1098
10992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1102 This makes this file independent of the recent pseudovector change.
1103
11042011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1105
1106 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1107
1108 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1109 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1110 Remove unused local.
1111 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1112
1113 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1114 GCC 4.6.0 optimizes based on type-based alias analysis.
1115 For example, if b is of type struct buffer * and v of type struct
1116 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1117 != &v->size, and therefore "v->size = 1; b->size = 2; return
1118 v->size;" must therefore return 1. This assumption is incorrect
1119 for Emacs, since it type-puns struct Lisp_Vector * with many other
1120 types. To fix this problem, this patch adds a new type struct
1121 vectorlike_header that documents the constraints on layout of vectors
1122 and pseudovectors, and helps optimizing compilers not get fooled
1123 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1124 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1125 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1126 the size member.
1127 (XSETPVECTYPE): Rewrite in terms of new macro.
1128 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1129 This is a bit clearer, and further avoids the possibility of
1130 undesirable aliasing.
1131 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1132 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1133 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1134 since Lisp_Subr is a special case (no "next" field).
1135 (ASIZE): Now uses header.size rather than size.
1136 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1137 to avoid the hassle of writing XVECTOR (foo)->header.size.
1138 (struct vectorlike_header): New type.
1139 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1140 object, to help avoid aliasing.
1141 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1142 (SUBRP): Likewise, since Lisp_Subr is a special case.
1143 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1144 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1145 (struct Lisp_Hash_Table): Combine first two members into a single
1146 struct vectorlike_header member. All uses of "size" and "next" members
1147 changed to be "header.size" and "header.next".
1148 * buffer.h (struct buffer): Likewise.
1149 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1150 * frame.h (struct frame): Likewise.
1151 * process.h (struct Lisp_Process): Likewise.
1152 * termhooks.h (struct terminal): Likewise.
1153 * window.c (struct save_window_data, struct saved_window): Likewise.
1154 * window.h (struct window): Likewise.
1155 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1156 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1157 * buffer.c (init_buffer_once): Likewise.
1158 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1159 special case.
1160 * process.c (Fformat_network_address): Use local var for size,
1161 for brevity.
1162
1163 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1164
1165 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1166 * data.c (atof): Remove decl; no longer used or needed.
1167 (digit_to_number): Move to lread.c.
1168 (Fstring_to_number): Use new string_to_number function, to be
1169 consistent with how the Lisp reader treats infinities and NaNs.
1170 Do not assume that floating-point numbers represent EMACS_INT
1171 without losing information; this is not true on most 64-bit hosts.
1172 Avoid double-rounding errors, by insisting on integers when
1173 parsing non-base-10 numbers, as the documentation specifies.
1174 * lisp.h (string_to_number): New decl, replacing ...
1175 (isfloat_string): Remove.
1176 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1177 (read1): Do not accept +. and -. as integers; this
1178 appears to have been a coding error. Similarly, do not accept
1179 strings like +-1e0 as floating point numbers. Do not report
1180 overflow for integer overflows unless the base is not 10 which
1181 means we have no simple and reliable way to continue.
1182 Break out the floating-point parsing into a new
1183 function string_to_number, so that Fstring_to_number parses
1184 floating point numbers consistently with the Lisp reader.
1185 (digit_to_number): Move here from data.c. Make it static inline.
1186 (E_CHAR, EXP_INT): Remove, replacing with ...
1187 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1188 (string_to_number): New function, replacing isfloat_string.
1189 This function checks for valid syntax and produces the resulting
1190 Lisp float number too. Rework it so that string-to-number
1191 no longer mishandles examples like "1.0e+". Use strtoumax,
1192 so that overflow for non-base-10 numbers is reported only when
1193 there's no portable and simple way to convert to floating point.
1194
1195 * textprop.c (set_text_properties_1): Rewrite for clarity,
1196 and to avoid GCC warning about integer overflow.
1197
1198 * intervals.h (struct interval): Use EMACS_INT for members
1199 where EMACS_UINT might cause problems. See
1200 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1201 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1202 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1203 All uses changed.
1204 (offset_intervals): Tell GCC not to worry about length overflow
1205 when negating a negative length.
1206
1207 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1208 (overrun_check_free): Likewise.
1209
1210 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1211 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1212 word size.
1213
1214 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1215 (gnutls_make_error): Rename local to avoid shadowing.
1216 (gnutls_emacs_global_deinit): ifdef out; not used.
1217 (Fgnutls_boot): Use const for pointer to readonly storage.
1218 Comment out unused local. Fix pointer signedness problems.
1219
1220 * lread.c (openp): Don't stuff size_t into an 'int'.
1221 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1222 about possible signed overflow.
1223
1224 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1225 (GDK_KEY_g): Don't define if already defined.
1226 (xg_prepare_tooltip): Avoid pointer signedness problem.
1227 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1228
1229 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1230 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1231
1232 * xfns.c (Fx_window_property): Simplify a bit,
1233 to make a bit faster and to avoid GCC 4.6.0 warning.
1234 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1235
1236 * fns.c (internal_equal): Don't assume size_t fits in int.
1237
1238 * alloc.c (compact_small_strings): Tighten assertion a little.
1239
1240 Replace pEd with more-general pI, and fix some printf arg casts.
1241 * lisp.h (pI): New macro, generalizing old pEd macro to other
1242 conversion specifiers. For example, use "...%"pI"d..." rather
1243 than "...%"pEd"...".
1244 (pEd): Remove. All uses replaced with similar uses of pI.
1245 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1246 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1247 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1248 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1249 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1250 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1251 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1252 64-bit hosts.
1253 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1254 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1255 * print.c (safe_debug_print, print_object): Likewise.
1256 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1257 to int.
1258 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1259 avoiding the 0 flag, which is not portable.
1260 * process.c (Fmake_network_process): Use pI to avoid cast.
1261 * region-cache.c (pp_cache): Likewise.
1262 * xdisp.c (decode_mode_spec): Likewise.
1263 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1264 behavior on 64-bit hosts with printf arg.
1265 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1266 (x_stop_queuing_selection_requests): Likewise.
1267 (x_get_window_property): Don't truncate byte count to an 'int'
1268 when tracing.
1269
1270 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1271 here, since it parses constructs like leading '-' and spaces,
1272 which are not wanted; and it overflows with large numbers.
1273 Instead, simply match F[0-9]+, which is what is wanted anyway.
1274
1275 * alloc.c: Remove unportable assumptions about struct layout.
1276 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1277 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1278 (allocate_vectorlike, make_pure_vector): Use the new macros,
1279 plus offsetof, to remove unportable assumptions about struct layout.
1280 These assumptions hold on all porting targets that I know of, but
1281 they are not guaranteed, they're easy to remove, and removing them
1282 makes further changes easier.
1283
1284 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1285 This doesn't fix a bug but makes the code clearer.
1286 (string_overrun_cookie): Now const. Use initializers that
1287 don't formally overflow signed char, to avoid warnings.
1288 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1289 can cause Emacs to crash when string overrun checking is enabled.
1290 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1291 multiple of sizeof (EMACS_INT); it need not be, if
1292 alignof(EMACS_INT) < sizeof (EMACS_INT).
1293 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1294
12952011-04-26 Juanma Barranquero <lekktu@gmail.com>
1296
1297 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1298
12992011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1300
1301 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1302 supposed to be handshaking. (Bug#8556)
1303 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1304
13052011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1306
1307 * lisp.h (Qdebug): List symbol.
1308 * eval.c (Qdebug): Restore global linkage.
1309 * keyboard.c (debug-on-event): New variable.
1310 (handle_user_signal): Break into debugger when debug-on-event
1311 matches the current signal symbol.
1312
13132011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1314
1315 * alloc.c (check_sblock, check_string_bytes)
1316 (check_string_free_list): Convert to standard C.
1317
13182011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1319
1320 * w32.c (emacs_gnutls_push): Fix typo.
1321
13222011-04-25 Eli Zaretskii <eliz@gnu.org>
1323
1324 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1325 "cast to pointer from integer of different size".
1326
1327 Improve doprnt and its use in verror. (Bug#8545)
1328 * doprnt.c (doprnt): Document the set of format control sequences
1329 supported by the function. Use SAFE_ALLOCA instead of always
1330 using `alloca'.
1331
1332 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1333 is one byte too soon. Don't use xrealloc; instead xfree and
1334 xmalloc anew.
1335
13362011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1337
1338 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1339 callbacks stage.
1340
1341 * gnutls.c: Renamed global_initialized to
1342 gnutls_global_initialized. Added internals for the
1343 :verify-hostname-error, :verify-error, and :verify-flags
1344 parameters of `gnutls-boot' and documented those parameters in the
1345 docstring. Start callback support.
1346 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1347 unless a fatal error occured. Call gnutls_alert_send_appropriate
1348 on error. Return error code.
1349 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1350 (emacs_gnutls_read): Likewise.
1351 (Fgnutls_boot): Return handshake error code.
1352 (emacs_gnutls_handle_error): New function.
1353 (wsaerror_to_errno): Likewise.
1354
1355 * w32.h (emacs_gnutls_pull): Add prototype.
1356 (emacs_gnutls_push): Likewise.
1357
1358 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1359 (emacs_gnutls_push): Likewise.
1360
13612011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1362
1363 * process.c (wait_reading_process_output): Check if GnuTLS
1364 buffered some data internally if no FDs are set for TLS
1365 connections.
1366
1367 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1368 (LIBS): Link to USER_LIBS.
1369 ($(BLD)/gnutls.$(0)): New target.
1370
13712011-04-24 Eli Zaretskii <eliz@gnu.org>
1372
1373 * xdisp.c (handle_single_display_spec): Rename the
1374 display_replaced_before_p argument into display_replaced_p, to
1375 make it consistent with the commentary. Fix typos in the
1376 commentary.
1377
1378 * textprop.c (syms_of_textprop): Remove dead code.
1379 (copy_text_properties): Delete obsolete commentary about an
1380 interface that was deleted long ago. Fix typos in the description
1381 of arguments.
1382
1383 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1384 to changes in oldXMenu/XMenu.h from 2011-04-16.
1385 <menu_help_message, prev_menu_help_message>: Constify.
1386 (IT_menu_make_room): menu->help_text is now `const char **';
1387 adjust.
1388
1389 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1390 to changes in oldXMenu/XMenu.h from 2011-04-16.
1391 (struct XMenu): Declare `help_text' `const char **'.
1392
1393 * xfaces.c <Qunspecified>: Make extern again.
1394
1395 * syntax.c: Include sys/types.h before including regex.h, as
1396 required by Posix.
1397
1398 * doc.c (get_doc_string): Improve the format passed to `error'.
1399
1400 * doprnt.c (doprnt): Improve commentary.
1401
1402 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1403
1404 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1405 them with etags.
1406
1407 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1408 changes in globals.h immediately force recompilation.
1409 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1410 $(CURDIR)/s/ms-w32.h.
1411 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1412
1413 * character.c (Fchar_direction): Function deleted.
1414 (syms_of_character): Don't defsubr it.
1415 <char-direction-table>: Deleted.
1416
14172011-04-23 Eli Zaretskii <eliz@gnu.org>
1418
1419 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1420 * doprnt.c: Include limits.h.
1421 (SIZE_MAX): New macro.
1422 (doprnt): Return a size_t value. 2nd arg is now size_t.
1423 Many local variables are now size_t instead of int or unsigned.
1424 Improve overflow protection. Support `l' modifier for integer
1425 conversions. Support %l conversion. Don't assume an EMACS_INT
1426 argument for integer conversions and for %c.
1427
1428 * lisp.h (doprnt): Restore prototype.
1429
1430 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1431 $(SRC)/character.h.
1432
1433 * Makefile.in (base_obj): Add back doprnt.o.
1434
1435 * deps.mk (doprnt.o): Add back prerequisites.
1436 (callint.o): Depend on character.h.
1437
1438 * eval.c (internal_lisp_condition_case): Include the handler
1439 representation in the error message.
1440 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1441 when breaking from the loop.
1442
1443 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1444
1445 * callint.c (Fcall_interactively): When displaying error message
1446 about invalid control letter, pass the character's codepoint, not
1447 a pointer to its multibyte form. Improve display of the character
1448 in octal and display also its hex code.
1449
1450 * character.c (char_string): Use %x to display the (unsigned)
1451 codepoint of an invalid character, to avoid displaying a bogus
1452 negative value.
1453
1454 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1455 `error', not SYMBOL_NAME itself.
1456
1457 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1458 character arguments to `error'.
1459
1460 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1461 to `error' in error message about FINAL_CHAR argument. Make sure
1462 FINAL_CHAR is a character, and use %c when it is passed as
1463 argument to `error'.
1464
14652011-04-23 Eli Zaretskii <eliz@gnu.org>
1466
1467 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1468
1469 * w32.c: Include <time.h>.
1470 (sys_localtime): New function.
1471
14722011-04-23 Chong Yidong <cyd@stupidchicken.com>
1473
1474 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1475
1476 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1477
14782011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1479
1480 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1481 zombies (Bug#8467).
1482
14832011-04-19 Eli Zaretskii <eliz@gnu.org>
1484
1485 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1486 gl_state.e_property when gl_state.object is Qt.
1487
1488 * insdel.c (make_gap_larger): Remove limitation of buffer size
1489 to <= INT_MAX.
1490
14912011-04-18 Chong Yidong <cyd@stupidchicken.com>
1492
1493 * xdisp.c (lookup_glyphless_char_display)
1494 (produce_glyphless_glyph): Handle cons cell entry in
1495 glyphless-char-display.
1496 (Vglyphless_char_display): Document it.
1497
1498 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1499 glyphless-char-display.
1500
15012011-04-17 Chong Yidong <cyd@stupidchicken.com>
1502
1503 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1504
1505 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1506
1507 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1508 definition for no-X builds.
1509
15102011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 Static checks with GCC 4.6.0 and non-default toolkits.
1513
1514 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1515
1516 * process.c (keyboard_bit_set): Define only if SIGIO.
1517 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1518 (send_process): Repair possible setjmp clobbering.
1519
1520 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1521
1522 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1523
1524 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1525
1526 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1527 Define only if needed.
1528
1529 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1530 by pacifying GCC about it. Maybe it's time to retire it?
1531 * xfaces.c (USG, __TIMEVAL__): Likewise.
1532
1533 * dispextern.h (struct redisplay_interface): Rename param
1534 to avoid shadowing.
1535 * termhooks.h (struct terminal): Likewise.
1536 * xterm.c (xembed_send_message): Likewise.
1537
1538 * insdel.c (make_gap_smaller): Define only if
1539 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1540
1541 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1542 it.
1543
1544 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1545 so that we aren't warned about unused symbols.
1546
1547 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1548
1549 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1550
1551 * xfns.c (x_real_positions): Mark locals as initialized.
1552
1553 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1554
1555 * xterm.c: Fix problems found by static analysis with other toolkits.
1556 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1557 (x_dispatch_event): Declare static if USE_GTK, and
1558 define if USE_GTK || USE_X_TOOLKIT.
1559 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1560 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1561 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1562 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1563
1564 * xmenu.c (menu_help_callback): Pointer type fixes.
1565 Use const pointers when pointing at readonly data. Avoid pointer
1566 signedness clashes.
1567 (FALSE): Remove unused macro.
1568 (update_frame_menubar): Remove unused decl.
1569
1570 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1571
1572 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1573 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1574 (single_menu_item): Rename local to avoid shadowing.
1575
1576 * keyboard.c (make_lispy_event): Remove unused local var.
1577
1578 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1579 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1580
1581 * bitmaps: Change bitmaps from unsigned char back to the X11
1582 compatible char. Avoid the old compiler warnings about
1583 out-of-range initializers by using, for example, '\xab' rather
1584 than 0xab.
1585
1586 * xgselect.c (xgselect_initialize): Check vs interface
1587 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1588
1589 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1590
1591 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1592 to read-only memory.
1593
1594 * fns.c (vector): Remove; this old hack is no longer needed.
1595
1596 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1597 Remove unused var.
1598 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1599
1600 * xrdb.c (x_load_resources): Omit unused local.
1601
1602 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1603 (x_window): Rename locals to avoid shadowing.
1604 (USG): Use the kludged USG macro, to pacify gcc.
1605
1606 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1607 (x_term_init): Remove local to avoid shadowing.
1608
1609 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1610
1611 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1612 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1613
16142011-04-16 Eli Zaretskii <eliz@gnu.org>
1615
1616 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1617
1618 Fix regex.c, syntax.c and friends for buffers > 2GB.
1619 * syntax.h (struct gl_state_s): Declare character position members
1620 EMACS_INT.
1621
1622 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1623
1624 * textprop.c (verify_interval_modification, interval_of):
1625 Declare arguments EMACS_INT.
1626
1627 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1628 EMACS_INT.
1629
1630 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1631
1632 * indent.c (Fvertical_motion): Local variable it_start is now
1633 EMACS_INT.
1634
1635 * regex.c (re_match, re_match_2, re_match_2_internal)
1636 (bcmp_translate, regcomp, regexec, print_double_string)
1637 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1638 (re_compile_pattern, re_exec): Declare arguments and local
1639 variables `size_t' and `ssize_t' and return values `regoff_t', as
1640 appropriate.
1641 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1642 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1643 <compile_stack_type>: `size' and `avail' are now `size_t'.
1644
1645 * regex.h <regoff_t>: Use ssize_t, not int.
1646 (re_search, re_search_2, re_match, re_match_2): Arguments that
1647 specify buffer/string position and length are now ssize_t and
1648 size_t. Return type is regoff_t.
1649
16502011-04-16 Ben Key <bkey76@gmail.com>
1651
1652 * nsfont.m: Fixed bugs in ns_get_family and
1653 ns_descriptor_to_entity that were caused by using free to
1654 deallocate memory blocks that were allocated by xmalloc (via
1655 xstrdup). This caused Emacs to crash when compiled with
1656 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1657 --enable-checking=xmallocoverrun). xfree is now used to
1658 deallocate these memory blocks.
1659
16602011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1661
1662 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1663
1664 emacs_write: Accept and return EMACS_INT for sizes.
1665 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1666 et seq.
1667 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1668 Accept and return EMACS_INT.
1669 (emacs_gnutls_write): Return the number of bytes written on
1670 partial writes.
1671 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1672 (emacs_read, emacs_write): Remove check for negative size, as the
1673 Emacs source code has been audited now.
1674 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1675 (emacs_read, emacs_write): Use it.
1676 * process.c (send_process): Adjust to the new signatures of
1677 emacs_write and emacs_gnutls_write. Do not attempt to store
1678 a byte offset into an 'int'; it might overflow.
1679 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1680
1681 * sound.c: Don't assume sizes fit in 'int'.
1682 (struct sound_device.period_size, alsa_period_size):
1683 Return EMACS_INT, not int.
1684 (struct sound_device.write, vox_write, alsa_write):
1685 Accept EMACS_INT, not int.
1686 (wav_play, au_play): Use EMACS_INT to store sizes and to
1687 record read return values.
1688
16892011-04-15 Ben Key <bkey76@gmail.com>
1690
1691 * keyboard.c (Qundefined): Don't declare static since it is used
1692 in nsfns.m.
1693 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1694 static since they are used in nsfont.m.
1695
16962011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1697
1698 * process.c (Qprocessp): Don't declare static.
1699 * lisp.h (Qprocessp): Declare again.
1700
17012011-04-15 Juanma Barranquero <lekktu@gmail.com>
1702
1703 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1704
17052011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1706
1707 Improve C-level modularity by making more things 'static'.
1708
1709 Don't publish debugger-only interfaces to other modules.
1710 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1711 (verify_bytepos, count_markers): Move decls to the only modules
1712 that need them.
1713 * region-cache.h (pp_cache): Likewise.
1714 * window.h (check_all_windows): Likewise.
1715 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1716
1717 * sysdep.c (croak): Now static, if
1718 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1719 * syssignal.h (croak): Declare only if not static.
1720
1721 * alloc.c (refill_memory_reserve): Now static if
1722 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1723 * lisp.h (refill_memory_reserve): Declare only if not static.
1724
1725 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1726 Define only if USE_LUCID.
1727
1728 * xrdb.c (x_customization_string, x_rm_string): Now static.
1729
1730 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1731 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1732
1733 * xdisp.c (draw_row_with_mouse_face): Now static.
1734 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1735
1736 * window.h (check_all_windows): Mark externally visible.
1737
1738 * window.c (window_deletion_count): Now static.
1739
1740 * undo.c: Make symbols static if they're not exported.
1741 (last_undo_buffer, last_boundary_position, pending_boundary):
1742 Now static.
1743
1744 * textprop.c (interval_insert_behind_hooks): Now static.
1745 (interval_insert_in_front_hooks): Likewise.
1746
1747 * term.c: Make symbols static if they're not exported.
1748 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1749 (max_frame_lines, tty_set_terminal_modes):
1750 (tty_reset_terminal_modes, tty_turn_off_highlight):
1751 (get_tty_terminal): Now static.
1752 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1753 * termhooks.h (term_mouse_moveto): Do not declare if
1754 HAVE_WINDOW_SYSTEM.
1755 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1756 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1757
1758 * sysdep.c: Make symbols static if they're not exported.
1759 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1760 Now static.
1761 (sigprocmask_set, full_mask): Remove; unused.
1762 (wait_debugging): Mark as visible.
1763 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1764 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1765
1766 * syntax.c (syntax_temp): Define only if !__GNUC__.
1767
1768 * sound.c (current_sound_device, current_sound): Now static.
1769
1770 * search.c (searchbufs, searchbuf_head): Now static.
1771
1772 * scroll.c (scroll_cost): Remove; unused.
1773 * dispextern.h (scroll_cost): Remove decl.
1774
1775 * region-cache.h (pp_cache): Mark as externally visible.
1776
1777 * process.c: Make symbols static if they're not exported.
1778 (process_tick, update_tick, create_process, chan_process):
1779 (Vprocess_alist, proc_buffered_char, datagram_access):
1780 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1781 (deactivate_process): Mark defn as static, as well as decl.
1782 * lisp.h (create_process): Remove decl.
1783 * process.h (chan_process, Vprocess_alist): Remove decls.
1784
1785 * print.c: Make symbols static if they're not exported.
1786 (print_depth, new_backquote_output, being_printed, print_buffer):
1787 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1788 (print_interval, print_number_index, initial_stderr_stream):
1789 Now static.
1790 * lisp.h (Fprinc): Remove decl.
1791 (debug_output_compilation_hack): Mark as externally visible.
1792
1793 * sysdep.c (croak): Move decl from here to syssignal.h.
1794 * syssignal.h (croak): Put it here, so the API can be checked when
1795 'croak' is called from dissociate_if_controlling_tty.
1796
1797 * minibuf.c: Make symbols static if they're not exported.
1798 (minibuf_save_list, choose_minibuf_frame): Now static.
1799 * lisp.h (choose_minibuf_frame): Remove decl.
1800
1801 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1802
1803 * lread.c: Make symbols static if they're not exported.
1804 (read_objects, initial_obarray, oblookup_last_bucket_number):
1805 Now static.
1806 (make_symbol): Remove; unused.
1807 * lisp.h (initial_obarray, make_symbol): Remove decls.
1808
1809 * keyboard.c: Make symbols static if they're not exported.
1810 (single_kboard, recent_keys_index, total_keys, recent_keys):
1811 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1812 (this_single_command_key_start, echoing, last_auto_save):
1813 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1814 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1815 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1816 (Vlispy_mouse_stem, double_click_count):
1817 Now static.
1818 (force_auto_save_soon): Define only if SIGDANGER.
1819 (ignore_mouse_drag_p): Now static if
1820 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1821 (print_help): Remove; unused.
1822 (stop_character, last_timer_event): Mark as externally visible.
1823 * keyboard.h (ignore_mouse_drag_p): Declare only if
1824 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1825 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1826 * lisp.h (echoing): Remove decl.
1827 (force_auto_save_soon): Declare only if SIGDANGER.
1828 * xdisp.c (redisplay_window): Simplify code, to make it more
1829 obvious that ignore_mouse_drag_p is not accessed if !defined
1830 USE_GTK && !defined HAVE_NS.
1831
1832 * intervals.c: Make symbols static if they're not exported.
1833 (merge_properties_sticky, merge_interval_right, delete_interval):
1834 Now static.
1835 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1836
1837 * insdel.c: Make symbols static if they're not exported.
1838 However, leave prepare_to_modify_buffer alone. It's never
1839 called from outside this function, but that appears to be a bug.
1840 (combine_after_change_list, combine_after_change_buffer):
1841 (adjust_after_replace, signal_before_change): Now static.
1842 (adjust_after_replace_noundo): Remove; unused.
1843 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1844 (signal_before_change): Remove decls.
1845
1846 * indent.c (val_compute_motion, val_vmotion): Now static.
1847
1848 * image.c: Make symbols static if they're not exported.
1849 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1850 if USE_GTK.
1851 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1852 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1853
1854 * fringe.c (standard_bitmaps): Now static.
1855 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1856
1857 * frame.c: Make symbols static if they're not exported.
1858 (x_report_frame_params, make_terminal_frame): Now static.
1859 (get_frame_param): Now static, unless HAVE_NS.
1860 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1861 (x_get_resource_string): Remove; not used.
1862 * frame.h (make_terminal_frame, x_report_frame_params):
1863 (x_get_resource_string); Remove decls.
1864 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1865 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1866
1867 * font.c, fontset.c: Make symbols static if they're not exported.
1868 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1869 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1870 * font.c (font_close_object): Now static.
1871 * font.h (font_close_object): Remove.
1872 * fontset.c (FONTSET_OBJLIST): Remove.
1873 (free_realized_fontset) #if-0 the body, which does nothing.
1874 (face_suitable_for_char_p): #if-0, as it's never called.
1875 * fontset.h (face_suitable_for_char_p): Remove decl.
1876 * xfaces.c (face_at_string_position):
1877 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1878 since 0 is always ASCII.
1879
1880 * fns.c (weak_hash_tables): Now static.
1881
1882 * fileio.c: Make symbols static if they're not exported.
1883 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1884 (Vwrite_region_annotation_buffers): Now static.
1885
1886 * eval.c: Make symbols static if they're not exported.
1887 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1888 * lisp.h (backtrace_list): Remove decl.
1889
1890 * emacs.c: Make symbols static if they're not exported.
1891 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1892 (fatal_error_code, fatal_error_signal_hook, standard_args):
1893 Now static.
1894 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1895 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1896 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1897 * lisp.h (fatal_error_signal_hook): Remove decl.
1898 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1899
1900 * editfns.c: Move a (normally-unused) function to its only use.
1901 * editfns.c, lisp.h (get_operating_system_release): Remove.
1902 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1903 worth the hassle of breaking this out.
1904
1905 * xterm.c: Make symbols static if they're not exported.
1906 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1907 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1908 (x_destroy_window, x_delete_display):
1909 Now static.
1910 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1911 (x_mouse_leave): Remove; unused.
1912 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1913 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1914 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1915 Remove decls.
1916 (x_mouse_leave): Declare only if WINDOWSNT.
1917 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1918 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1919 USE_X_TOOLKIT.
1920
1921 * ftxfont.c: Make symbols static if they're not exported.
1922 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1923 HAVE_FREETYPE.
1924 * font.h (ftxfont_driver): Likewise.
1925
1926 * xfns.c: Make symbols static if they're not exported.
1927 (x_last_font_name, x_display_info_for_name):
1928 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1929 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1930 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1931 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1932 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1933 (last_show_tip_args): Now static.
1934 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1935 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1936 (x_screen_planes): Remove; unused.
1937 * dispextern.h (x_screen_planes): Remove decl.
1938
1939 * dispnew.c: Make symbols static if they're not exported.
1940 * dispextern.h (redraw_garbaged_frames, scrolling):
1941 (increment_row_positions): Remove.
1942 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1943 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1944 Now static.
1945 (redraw_garbaged_frames): Remove; unused.
1946
1947 * xfaces.c: Make symbols static if they're not exported.
1948 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1949 Remove decls.
1950 * xterm.h (defined_color): Remove decls.
1951 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1952 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1953 (menu_face_changed_default, defined_color, free_realized_face):
1954 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1955 (ascii_face_of_lisp_face): Remove; unused.
1956
1957 * xdisp.c: Make symbols static if they're not exported.
1958 * dispextern.h (scratch_glyph_row, window_box_edges):
1959 (glyph_to_pixel_coords, set_cursor_from_row):
1960 (get_next_display_element, set_iterator_to_next):
1961 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1962 (show_mouse_face): Remove decls
1963 * frame.h (message_buf_print): Likewise.
1964 * lisp.h (pop_message, set_message, check_point_in_composition):
1965 Likewise.
1966 * xterm.h (set_vertical_scroll_bar): Likewise.
1967 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1968 (message_buf_print, scratch_glyph_row, displayed_buffer):
1969 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1970 (get_next_display_element, show_mouse_face, window_box_edges):
1971 (frame_to_window_pixel_xy, check_point_in_composition):
1972 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1973 (glyph_to_pixel_coords): Remove; unused.
1974
1975 * dired.c (file_name_completion): Now static.
1976
1977 * dbusbind.c (xd_in_read_queued_messages): Now static.
1978
1979 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1980 * data.c (circular_list_error): Remove.
1981
1982 * commands.h (last_point_position, last_point_position_buffer):
1983 (last_point_position_window): Remove decls.
1984 * keyboard.c: Make these variables static.
1985
1986 * coding.h (coding, code_convert_region, encode_coding_gap):
1987 Remove decls.
1988 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1989 (iso_code_class, detect_coding, code_convert_region): Now static.
1990 (encode_coding_gap): Remove; unused.
1991
1992 * chartab.c (chartab_chars, chartab_bits): Now static.
1993
1994 * charset.h (charset_iso_8859_1): Remove decl.
1995 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1996 Now static.
1997
1998 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1999 * ccl.c (Vccl_program_table): Now static.
2000 (check_ccl_update): Remove; unused.
2001
2002 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2003 * category.h: ... from here.
2004 * category.c (check_category_table, set_category_set): Now static.
2005
2006 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2007 * lisp.h: Remove these decls.
2008
2009 * buffer.c (buffer_count): Remove unused var.
2010
2011 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2012 so that it's not optimized away.
2013 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2014 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2015 exported only to the debugger.
2016
2017 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2018 * atimer.h (run_all_atimers): Remove; not exported.
2019
2020 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2021 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2022 was inaccessible from Lisp.
2023 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2024 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2025
2026 alloc.c: Import and export fewer symbols, and remove unused items.
2027 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2028 is defined.
2029 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2030 it's not optimized away by whole-program optimization.
2031 (message_enable_multibyte, free_misc): Remove.
2032 (catchlist, handlerlist, mark_backtrace):
2033 Declare only if BYTE_MARK_STACK.
2034 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2035 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2036 (message_enable_multibyte): Remove decl.
2037 (free_misc, interval_free_list, float_block, float_block_index):
2038 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2039 (cons_free_list, last_marked_index):
2040 Now static.
2041 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2042 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2043 (mark_backtrace): Define only if BYTE_MARK_STACK.
2044 * xdisp.c (message_enable_multibyte): Now static.
2045
2046 Declare Lisp_Object Q* variables to be 'static' if not exported.
2047 This makes it easier for human readers (and static analyzers)
2048 to see whether these variables are used from other modules.
2049 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2050 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2051 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2052 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2053 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2054 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2055 * xmenu.c, xselect.c:
2056 Declare Q* vars static if they are not used in other modules.
2057 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2058 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2059 Remove decls of unexported vars.
2060 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2061
2062 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2063
2064 Make Emacs functions such as Fatom 'static' by default.
2065 This makes it easier for human readers (and static analyzers)
2066 to see whether these functions can be called from other modules.
2067 DEFUN now defines a static function. To make the function external
2068 so that it can be used in other C modules, use the new macro DEFUE.
2069 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2070 (Finit_image_library):
2071 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2072 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2073 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2074 Remove decls, since these functions are now static.
2075 (Funintern, Fget_internal_run_time): New decls, since these functions
2076 were already external.
2077
2078 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2079 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2080 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2081 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2082 * keyboard.c, keymap.c, lread.c:
2083 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2084 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2085 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2086 Mark functions with DEFUE instead of DEFUN,
2087 if they are used in other modules.
2088 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2089 decls for now-static functions.
2090 * buffer.h (Fdelete_overlay): Remove decl.
2091 * callproc.c (Fgetenv_internal): Mark as internal.
2092 * composite.c (Fremove_list_of_text_properties): Remove decl.
2093 (Fcomposition_get_gstring): New forward static decl.
2094 * composite.h (Fcomposite_get_gstring): Remove decl.
2095 * dired.c (Ffile_attributes): New forward static decl.
2096 * doc.c (Fdocumntation_property): New forward static decl.
2097 * eval.c (Ffetch_bytecode): New forward static decl.
2098 (Funintern): Remove extern decl; now in .h file where it belongs.
2099 * fileio.c (Fmake_symbolic_link): New forward static decl.
2100 * image.c (Finit_image_library): New forward static decl.
2101 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2102 * intervals.h (Fprevious_property_change):
2103 (Fremove_list_of_text_properties): Remove decls.
2104 * keyboard.c (Fthis_command_keys): Remove decl.
2105 (Fcommand_execute): New forward static decl.
2106 * keymap.c (Flookup_key): New forward static decl.
2107 (Fcopy_keymap): Now static.
2108 * keymap.h (Flookup_key): Remove decl.
2109 * process.c (Fget_process): New forward static decl.
2110 (Fprocess_datagram_address): Mark as internal.
2111 * syntax.c (Fsyntax_table_p): New forward static decl.
2112 (skip_chars): Remove duplicate decl.
2113 * textprop.c (Fprevious_property_change): New forward static decl.
2114 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2115 Now internal.
2116 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2117 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2118
2119 * editfns.c (Fformat): Remove unreachable code.
2120
21212011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2122
2123 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2124 change. (Bug#8496)
2125
21262011-04-13 Eli Zaretskii <eliz@gnu.org>
2127
2128 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2129 when at ZV. (Bug#8487)
2130
21312011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2132
2133 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2134 (Bug#8437)
2135 * keyboard.c (parse_tool_bar_item): Likewise.
2136 * sound.c (sound_cleanup, alsa_close): Likewise.
2137 * termcap.c (tgetent): Likewise.
2138 * xfns.c (x_default_font_parameter): Likewise.
2139 * xsettings.c (read_and_apply_settings): Likewise.
2140
2141 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2142 (overrun_check_free): Protoize.
2143
21442011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2145
2146 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2147 since callers should never pass a negative size.
2148 Change the signature to match that of plain 'read' and 'write'; see
2149 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2150 * lisp.h: Update prototypes of emacs_write and emacs_read.
2151
21522011-04-11 Eli Zaretskii <eliz@gnu.org>
2153
2154 * xdisp.c (redisplay_window): Don't try to determine the character
2155 position of the scroll margin if the window start point w->startp
2156 is outside the buffer's accessible region. (Bug#8468)
2157
21582011-04-10 Eli Zaretskii <eliz@gnu.org>
2159
2160 Fix write-region and its subroutines for buffers > 2GB.
2161 * fileio.c (a_write, e_write): Modify declaration of arguments and
2162 local variables to support buffers larger than 2GB.
2163 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2164
2165 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2166 argument, local variables, and return value.
2167
2168 * lisp.h: Update prototypes of emacs_write and emacs_read.
2169
2170 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2171
21722011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2173
2174 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2175
2176 Fix more problems found by GCC 4.6.0's static checks.
2177
2178 * xdisp.c (vmessage): Use a better test for character truncation.
2179
2180 * charset.c (load_charset_map): <, not <=, for optimization,
2181 and to avoid potential problems with integer overflow.
2182 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2183 * casetab.c (set_identity, shuffle): Likewise.
2184 * editfns.c (Fformat): Likewise.
2185 * syntax.c (skip_chars): Likewise.
2186
2187 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2188 This also lets GCC 4.6.0 generate slightly better loop code.
2189
2190 * callint.c (Fcall_interactively): <, not <=, for optimization.
2191 (Fcall_interactively): Count the number of arguments produced,
2192 not the number of arguments given. This is simpler and lets GCC
2193 4.6.0 generate slightly better code.
2194
2195 * ftfont.c: Distingish more carefully between FcChar8 and char.
2196 The previous code passed unsigned char * to a functions like
2197 strlen and xstrcasecmp that expect char *, which does not
2198 conform to the C standard.
2199 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2200 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2201 char * when the C standard requires it.
2202
2203 * keyboard.c (read_char): Remove unused var.
2204
2205 * eval.c: Port to Windows vsnprintf (Bug#8435).
2206 Include <limits.h>.
2207 (SIZE_MAX): Define if the headers do not.
2208 (verror): Do not give up if vsnprintf returns a negative count.
2209 Instead, grow the buffer. This ports to Windows vsnprintf, which
2210 does not conform to C99. Problem reported by Eli Zaretskii.
2211 Also, simplify the allocation scheme, by avoiding the need for
2212 calling realloc, and removing the ALLOCATED variable.
2213
2214 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2215
2216 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2217 But keep the doprint source code for now, as we might revamp it
2218 and use it again (Bug#8435).
2219 * lisp.h (doprnt): Remove.
2220 * Makefile.in (base_obj): Remove doprnt.o.
2221 * deps.mk (doprnt.o): Remove.
2222
2223 error: Print 32- and 64-bit integers portably (Bug#8435).
2224 Without this change, on typical 64-bit hosts error ("...%d...", N)
2225 was used to print both 32- and 64-bit integers N, which relied on
2226 undefined behavior.
2227 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2228 New macro.
2229 * lisp.h (error, verror): Mark as printf-like functions.
2230 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2231 Report overflow in size calculations when allocating printf buffer.
2232 Do not truncate output string at its first null byte.
2233 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2234 Truncate the output at a character boundary, since vsnprintf does not
2235 do that.
2236 * charset.c (check_iso_charset_parameter): Convert internal
2237 character to string before calling 'error', since %c now has the
2238 printf meaning.
2239 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2240 overflow when computing char to be passed to 'error'. Do not
2241 pass Lisp_Object to 'error'; pass the integer instead.
2242 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2243 formatted with plain %d.
2244
2245 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2246
2247 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2248
2249 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2250
2251 * xterm.c (x_catch_errors): Remove duplicate declaration.
2252
2253 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2254
2255 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2256
22572011-04-10 Jim Meyering <meyering@redhat.com>
2258
2259 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2260 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2261 return ssize_t not "int", and use size_t as the buffer length.
2262 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2263 * gnutls.h: Update declarations.
2264 * process.c (read_process_output): Use ssize_t, to match.
2265 (send_process): Likewise.
2266
22672011-04-09 Chong Yidong <cyd@stupidchicken.com>
2268
2269 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2270
22712011-04-09 Chong Yidong <cyd@stupidchicken.com>
2272
2273 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2274 Use unsigned char, to match FcChar8 type definition.
2275
2276 * xterm.c (handle_one_xevent):
2277 * xmenu.c (create_and_show_popup_menu):
2278 * xselect.c (x_decline_selection_request)
2279 (x_reply_selection_request): Avoid type-punned deref of X events.
2280
22812011-04-09 Eli Zaretskii <eliz@gnu.org>
2282
2283 Fix some uses of `int' instead of EMACS_INT.
2284 * search.c (string_match_1, fast_string_match)
2285 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2286 (scan_buffer, find_next_newline_no_quit)
2287 (find_before_next_newline, search_command, Freplace_match)
2288 (Fmatch_data): Make some `int' variables be EMACS_INT.
2289
2290 * xdisp.c (display_count_lines): 3rd argument and return value now
2291 EMACS_INT. All callers changed.
2292 (pint2hrstr): Last argument is now EMACS_INT.
2293
2294 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2295 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2296 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2297 (decode_coding_utf_16, decode_coding_emacs_mule)
2298 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2299 (decode_coding_ccl, decode_coding_charset)
2300 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2301 (decode_coding_iso_2022, decode_coding_emacs_mule)
2302 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2303 <char_offset, last_offset>: Declare EMACS_INT.
2304 (encode_coding_utf_8, encode_coding_utf_16)
2305 (encode_coding_emacs_mule, encode_invocation_designation)
2306 (encode_designation_at_bol, encode_coding_iso_2022)
2307 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2308 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2309 Declare EMACS_INT.
2310 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2311 (encode_invocation_designation): Last argument P_NCHARS is now
2312 EMACS_INT.
2313 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2314 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2315
2316 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2317 All users changed.
2318
2319 * ccl.c (Fccl_execute_on_string): Declare some variables
2320 EMACS_INT.
2321
23222011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2323
2324 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2325
23262011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2327
2328 * process.c (Fformat_network_address): Doc fix.
2329
23302011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2331
2332 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2333
23342011-04-08 Chong Yidong <cyd@stupidchicken.com>
2335
2336 * keyboard.c (read_char): Call Lisp function help-form-show,
2337 instead of using internal_with_output_to_temp_buffer.
2338 (Qhelp_form_show): New var.
2339 (syms_of_keyboard): Use DEFSYM macro.
2340
2341 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2342
2343 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2344
23452011-04-06 Chong Yidong <cyd@stupidchicken.com>
2346
2347 * process.c (Flist_processes): Remove to Lisp.
2348 (list_processes_1): Delete.
2349
23502011-04-06 Eli Zaretskii <eliz@gnu.org>
2351
2352 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2353
2354 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2355
23562011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2357
2358 Fix more problems found by GCC 4.6.0's static checks.
2359
2360 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2361
2362 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2363
2364 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2365
2366 * xdisp.c (vmessage): Mark as a printf-like function.
2367
2368 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2369
2370 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2371
2372 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2373 printf-like functions.
2374 (tiff_load): Add casts to remove these marks before passing them
2375 to system-supplied API.
2376
2377 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2378
2379 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2380 This avoids several warnings with gcc -Wstrict-overflow.
2381 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2382 directly, rather than having caller test rule sign. This avoids
2383 some unnecessary tests.
2384 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2385 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2386 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2387
2388 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2389 (xfont_open): Avoid unnecessary tests.
2390
2391 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2392
2393 * composite.h, composite.c (composition_gstring_put_cache):
2394 Use EMACS_INT, not int, for length.
2395
2396 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2397 breaking out part of COMPOSITION_DECODE_RULE.
2398 (COMPOSITION_DECODE_RULE): Use it.
2399 * composite.c (get_composition_id): Remove unused local vars,
2400 by using the new macro.
2401
2402 * textprop.c (set_text_properties_1): Change while to do-while,
2403 since the condition is always true at first.
2404
2405 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2406 (interval_deletion_adjustment): Return unsigned value.
2407 All uses changed.
2408
2409 * process.c (list_processes_1, create_pty, read_process_output):
2410 (exec_sentinel): Remove vars that were set but not used.
2411 (create_pty): Remove unnecessary "volatile"s.
2412 (Fnetwork_interface_info): Avoid possibility of int overflow.
2413 (read_process_output): Do adaptive read buffering even if carryover.
2414 (read_process_output): Simplify nbytes computation if buffered.
2415
2416 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2417
2418 * syntax.c (scan_words): Remove var that was set but not used.
2419 (update_syntax_table): Use unsigned instead of int.
2420
2421 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2422 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2423 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2424
2425 * print.c (print_error_message): Avoid int overflow.
2426
2427 * font.c (font_list_entities): Redo for clarity,
2428 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2429
2430 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2431 (font_score): Avoid potential overflow in diff calculation.
2432
2433 * fns.c (substring_both): Remove var that is set but not used.
2434 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2435
2436 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2437
2438 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2439 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2440 can always succeed if overflow has undefined behavior.
2441
2442 * search.c (boyer_moore, wordify): Remove vars set but not used.
2443 (wordify): Omit three unnecessary tests.
2444
2445 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2446 All callers changed. This avoids the need for an unused var.
2447
2448 * casefiddle.c (casify_region): Remove var that is set but not used.
2449
2450 * dired.c (file_name_completion): Remove var that is set but not used.
2451
2452 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2453
2454 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2455 (Finsert_file_contents): Remove unnecessary code checking fd.
2456
2457 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2458 Check for integer overflow on size calculations.
2459
2460 * buffer.c (Fprevious_overlay_change): Remove var that is set
2461 but not used.
2462
2463 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2464 Remove vars that are set but not used.
2465 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2466 (timer_check_2): Mark vars as initialized.
2467
2468 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2469
2470 * image.c (lookup_image): Remove var that is set but not used.
2471 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2472
2473 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2474 that are set but not used.
2475
2476 * xfns.c (make_invisible_cursor): Don't return garbage
2477 if XCreateBitmapFromData fails (Bug#8410).
2478
2479 * xselect.c (x_get_local_selection, x_handle_property_notify):
2480 Remove vars that are set but not used.
2481
2482 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2483 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2484
2485 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2486 Remove var that is set but not used.
2487 (scroll_bar_windows_size): Now size_t, not int.
2488 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2489 Check for overflow.
2490
2491 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2492 (map_tty_color) [!defined MSDOS]: Likewise.
2493
2494 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2495
2496 * coding.c: Remove vars that are set but not used.
2497 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2498 All callers changed.
2499 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2500 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2501 (decode_coding_charset): Remove vars that are set but not used.
2502
2503 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2504 that is set but not used.
2505
2506 * print.c (print_object): Remove var that is set but not used.
2507
2508 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2509 The gnulib version avoids calling malloc in the usual case,
2510 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2511 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2512 * filelock.c (current_lock_owner): Likewise.
2513 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2514 * sysdep.c: Include allocator.h, careadlinkat.h.
2515 (emacs_no_realloc_allocator): New static constant.
2516 (emacs_readlink): New function.
2517 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2518 ../lib/careadlinkat.h.
2519
25202011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2521
2522 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2523 first non-nil return value).
2524
25252011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2526
2527 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2528 if not defined (Bug#8403).
2529
25302011-04-02 Juanma Barranquero <lekktu@gmail.com>
2531
2532 * xdisp.c (display_count_lines): Remove parameter `start',
2533 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2534 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2535 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2536 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2537 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2538 and thereabouts. All callers changed.
2539 (get_per_char_metric): Remove parameter `f', unused since
2540 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2541
25422011-04-02 Jim Meyering <meyering@redhat.com>
2543
2544 do not dereference NULL upon failed strdup
2545 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2546 (ns_get_family): Likewise.
2547
25482011-04-02 Juanma Barranquero <lekktu@gmail.com>
2549
2550 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2551
25522011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2553
2554 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2555 later (Bug#8403).
2556
25572011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2558
2559 Add lexical binding.
2560
2561 * window.c (Ftemp_output_buffer_show): New fun.
2562 (Fsave_window_excursion):
2563 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2564
2565 * lread.c (lisp_file_lexically_bound_p): New function.
2566 (Fload): Bind Qlexical_binding.
2567 (readevalloop): Remove `evalfun' arg.
2568 Bind Qinternal_interpreter_environment.
2569 (Feval_buffer): Bind Qlexical_binding.
2570 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2571 Mark as dynamic.
2572 (syms_of_lread): Declare `lexical-binding'.
2573
2574 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2575
2576 * keyboard.c (eval_dyn): New fun.
2577 (menu_item_eval_property): Use it.
2578
2579 * image.c (parse_image_spec): Use Ffunctionp.
2580
2581 * fns.c (concat, mapcar1): Accept byte-code-functions.
2582
2583 * eval.c (Fsetq): Handle lexical vars.
2584 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2585 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2586 (FletX, Flet): Obey lexical binding.
2587 (Fcommandp): Handle closures.
2588 (Feval): New `lexical' arg.
2589 (eval_sub): New function extracted from Feval. Use it almost
2590 everywhere where Feval was used. Look up vars in lexical env.
2591 Handle closures.
2592 (Ffunctionp): Move from subr.el.
2593 (Ffuncall): Handle closures.
2594 (apply_lambda): Remove `eval_flags'.
2595 (funcall_lambda): Handle closures and new byte-code-functions.
2596 (Fspecial_variable_p): New function.
2597 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2598 but without exporting it to Lisp.
2599
2600 * doc.c (Fdocumentation, store_function_docstring):
2601 * data.c (Finteractive_form): Handle closures.
2602
2603 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2604 interactive spec.
2605
2606 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2607 New byte-codes.
2608 (exec_byte_code): New function extracted from Fbyte_code to handle new
2609 calling convention for byte-code-functions. Add new byte-codes.
2610
2611 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2612
2613 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2614
26152011-03-31 Juanma Barranquero <lekktu@gmail.com>
2616
2617 * xdisp.c (redisplay_internal): Fix prototype.
2618
26192011-03-31 Eli Zaretskii <eliz@gnu.org>
2620
2621 * xdisp.c (SCROLL_LIMIT): New macro.
2622 (try_scrolling): Use it when setting scroll_limit.
2623 Limit scrolling to 100 screen lines.
2624 (redisplay_window): Even when falling back on "recentering",
2625 position point in the window according to scroll-conservatively,
2626 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2627
2628 (try_scrolling): When point is above the window, allow searching
2629 as far as scroll_max, or one screenful, to compute vertical
2630 distance from PT to the scroll margin position. This prevents
2631 try_scrolling from unnecessarily failing when
2632 scroll-conservatively is set to a value slightly larger than the
2633 window height. Clean up the case of PT below the margin at bottom
2634 of window: scroll_max can no longer be INT_MAX. When aggressive
2635 scrolling is in use, don't let point enter the opposite scroll
2636 margin as result of the scroll.
2637 (syms_of_xdisp) <scroll-conservatively>: Document the
2638 threshold of 100 lines for never-recentering scrolling.
2639
26402011-03-31 Juanma Barranquero <lekktu@gmail.com>
2641
2642 * dispextern.h (move_it_by_lines):
2643 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2644 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2645 (message_log_check_duplicate): Remove parameters `prev_bol' and
2646 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2647 (redisplay_internal): Remove parameter `preserve_echo_area',
2648 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2649
2650 * indent.c (Fvertical_motion):
2651 * window.c (window_scroll_pixel_based, Frecenter):
2652 Don't pass `need_y_p' to `move_it_by_lines'.
2653
26542011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2655
2656 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2657 steal a few bits to be more compact.
2658 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2659 Remove unneeded casts.
2660
2661 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2662
26632011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2664
2665 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2666 binding" message (bug#7967).
2667
26682011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2669
2670 Fix more problems found by GCC 4.6.0's static checks.
2671
2672 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2673 Remove unused local var.
2674
2675 * editfns.c (Fmessage_box): Remove unused local var.
2676
2677 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2678 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2679 Omit unused local vars.
2680 * window.c (shrink_windows): Omit unused local var.
2681 * menu.c (digest_single_submenu): Omit unused local var.
2682 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2683 Omit unused local var.
2684
2685 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2686 Don't assume string length fits in int.
2687 (keyremap_step, read_key_sequence): Use size_t for sizes.
2688 (read_key_sequence): Don't check last_real_key_start redundantly.
2689
2690 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2691 instead of alloca (Bug#8344).
2692
2693 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2694 (Fbacktrace_frame): Don't assume nframes fits in int.
2695
2696 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2697
2698 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2699 concerns.
2700
2701 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2702
2703 * cm.c (calccost): Turn while-do into do-while, for clarity.
2704
2705 * keyboard.c (syms_of_keyboard): Use the same style as later
2706 in this function when indexing through an array. This also
2707 works around GCC bug 48267.
2708
2709 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2710
2711 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2712
2713 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2714 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2715
2716 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2717 This avoids undefined behavior on integer overflow, and is a bit
2718 more convenient anyway since it is compared to a size_t variable.
2719
2720 Variadic C functions now count arguments with size_t, not int.
2721 This avoids an unnecessary limitation on 64-bit machines, which
2722 caused (substring ...) to crash on large vectors (Bug#8344).
2723 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2724 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2725 All variadic functions and their callers changed accordingly.
2726 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2727 * data.c (arith_driver, float_arith_driver): Likewise.
2728 * editfns.c (general_insert_function): Likewise.
2729 * eval.c (struct backtrace.nargs, interactive_p)
2730 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2731 (funcall_lambda, mark_backtrace): Likewise.
2732 * fns.c (concat): Likewise.
2733 * frame.c (x_set_frame_parameters): Likewise.
2734 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2735 0 if not found, not -1. All callers changed.
2736
2737 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2738 (stack_copy_size): Now size_t, not int.
2739 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2740
27412011-03-28 Juanma Barranquero <lekktu@gmail.com>
2742
2743 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2744 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2745 All callers changed.
2746
2747 * lisp.h (multibyte_char_to_unibyte):
2748 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2749 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2750 * character.h (CHAR_TO_BYTE8):
2751 * cmds.c (internal_self_insert):
2752 * editfns.c (general_insert_function):
2753 * keymap.c (push_key_description):
2754 * search.c (Freplace_match):
2755 * xdisp.c (message_dolog, set_message_1): All callers changed.
2756
27572011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2758
2759 * keyboard.c (safe_run_hook_funcall): New function.
2760 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2761 don't set the hook to nil, but remove the offending function instead.
2762 (Qcommand_hook_internal): Remove, unused.
2763 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2764 Vcommand_hook_internal.
2765
2766 * eval.c (enum run_hooks_condition): Remove.
2767 (funcall_nil, funcall_not): New functions.
2768 (run_hook_with_args): Call each function through a `funcall' argument.
2769 Remove `cond' argument, now redundant.
2770 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2771 (Frun_hook_with_args_until_failure): Adjust accordingly.
2772 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2773
27742011-03-28 Juanma Barranquero <lekktu@gmail.com>
2775
2776 * dispextern.h (string_buffer_position): Remove declaration.
2777
2778 * print.c (strout): Remove parameter `multibyte', unused since
2779 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2780
2781 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2782 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2783 All callers changed.
2784
2785 * w32.c (_wsa_errlist): Use braces for struct initializers.
2786
2787 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2788 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2789 All callers changed.
2790 (string_buffer_position): Likewise. Also, make static (it's never
2791 used outside xdisp.c).
2792 (cursor_row_p): Remove parameter `w', unused since
2793 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2794 (decode_mode_spec): Remove parameter `precision', introduced during
2795 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2796 All callers changed.
2797
27982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2799
2800 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2801
28022011-03-27 Anders Lindgren <andlind@gmail.com>
2803
2804 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2805 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2806 (ns_update_auto_hide_menu_bar): New functions.
2807 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2808 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2809 ns_constrain_all_frames.
2810 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2811 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2812
28132011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2814
2815 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2816
28172011-03-27 Glenn Morris <rgm@gnu.org>
2818
2819 * syssignal.h: Replace RETSIGTYPE with void.
2820 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2821 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2822 Replace SIGTYPE with void everywhere.
2823 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2824 * s/template.h (SIGTYPE): Remove commented out definition.
2825
28262011-03-26 Eli Zaretskii <eliz@gnu.org>
2827
2828 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2829 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2830
28312011-03-26 Juanma Barranquero <lekktu@gmail.com>
2832
2833 * w32.c (read_unc_volume): Use parameter `henum', instead of
2834 global variable `wget_enum_handle'.
2835
2836 * keymap.c (describe_vector): Remove parameters `indices' and
2837 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2838 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2839
2840 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2841
2842 * keyboard.c (timer_check): Remove parameter `do_it_now',
2843 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2844 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2845 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2846
2847 * keyboard.c (read_char):
2848 * w32menu.c (w32_menu_display_help):
2849 * xmenu.c (show_help_event, menu_help_callback):
2850 Adjust calls to `show_help_echo'.
2851
2852 * gtkutil.c (xg_maybe_add_timer):
2853 * keyboard.c (readable_events):
2854 * process.c (wait_reading_process_output):
2855 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2856
2857 * insdel.c (adjust_markers_gap_motion):
2858 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2859 (gap_left, gap_right): Don't call it.
2860
28612011-03-25 Chong Yidong <cyd@stupidchicken.com>
2862
2863 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2864 incurred during fontification.
2865
28662011-03-25 Juanma Barranquero <lekktu@gmail.com>
2867
2868 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2869 (DEFVAR_PER_BUFFER): Don't pass it.
2870
2871 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2872 (scrolling_window): Don't pass it.
2873
28742011-03-25 Juanma Barranquero <lekktu@gmail.com>
2875
2876 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2877
2878 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2879 and `suffix'.
2880 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2881 of variables specific to SELinux and computation of `encoded_absname'.
2882
2883 * image.c (XPutPixel): Remove unused variable `height'.
2884
2885 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2886
2887 * unexw32.c (get_section_info): Remove unused variable `section'.
2888
2889 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2890 (system_process_attributes): Remove unused variable `sess'.
2891 (sys_read): Remove unused variable `err'.
2892
2893 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2894 (w32_wnd_proc): Remove unused variable `isdead'.
2895 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2896 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2897 (x_create_tip_frame): Remove unused variable `tem'.
2898
2899 * w32inevt.c (w32_console_read_socket):
2900 Remove unused variable `no_events'.
2901
2902 * w32term.c (x_draw_composite_glyph_string_foreground):
2903 Remove unused variable `width'.
2904
29052011-03-24 Juanma Barranquero <lekktu@gmail.com>
2906
2907 * w32term.c (x_set_glyph_string_clipping):
2908 Don't pass uninitialized region to CombineRgn.
2909
29102011-03-23 Juanma Barranquero <lekktu@gmail.com>
2911
2912 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2913 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2914 (Fx_close_connection): Remove unused variable `i'.
2915
2916 * w32font.c (w32font_draw): Return number of glyphs.
2917 (w32font_open_internal): Remove unused variable `i'.
2918 (w32font_driver): Add missing initializer.
2919
2920 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2921 (fill_in_menu): Remove unused variable `items_added'.
2922
2923 * w32term.c (last_mouse_press_frame): Remove static global variable.
2924 (w32_clip_to_row): Remove unused variable `f'.
2925 (x_delete_terminal): Remove unused variable `i'.
2926
2927 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2928 (NOTHING): Remove unused static global variable.
2929 (uniscribe_check_otf): Remove unused variable `table'.
2930 (uniscribe_font_driver): Add missing initializers.
2931
29322011-03-23 Julien Danjou <julien@danjou.info>
2933
2934 * term.c (Fsuspend_tty, Fresume_tty):
2935 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2936 * window.c (temp_output_buffer_show):
2937 * insdel.c (signal_before_change):
2938 * frame.c (Fhandle_switch_frame):
2939 * fileio.c (Fdo_auto_save):
2940 * emacs.c (Fkill_emacs):
2941 * editfns.c (save_excursion_restore):
2942 * cmds.c (internal_self_insert):
2943 * callint.c (Fcall_interactively):
2944 * buffer.c (Fkill_all_local_variables):
2945 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2946 Use Frun_hooks.
2947 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2948 unconditionnaly since it does the check itself.
2949
29502011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 Fix more problems found by GCC 4.5.2's static checks.
2953
2954 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2955 the first time through the loop, since we know p0 < p1 then.
2956 This also avoids a gcc -Wstrict-overflow warning.
2957
2958 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2959 leading to a memory leak, possible in functions like
2960 load_charset_map_from_file that can allocate an unbounded number
2961 of objects (Bug#8318).
2962
2963 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2964 that could (at least in theory) be that large.
2965
2966 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2967 This is less likely to overflow, and avoids undefined behavior if
2968 overflow does occur. All callers changed. Use strtoul to scan
2969 for the unsigned long integer.
2970 (pint2hrstr): Simplify and tune code slightly.
2971 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2972
2973 * scroll.c (do_scrolling): Work around GCC bug 48228.
2974 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2975
2976 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2977 This also avoids a warning with gcc -Wstrict-overflow.
2978 (validate_x_resource_name): Simplify count usage.
2979 This also avoids a warning with gcc -Wstrict-overflow.
2980
2981 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2982 fail (Bug#8306).
2983
2984 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2985
2986 * process.c (Fmake_network_process): Use socklen_t, not int,
2987 where POSIX says socklen_t is required in portable programs.
2988 This fixes a porting bug on hosts like 64-bit HP-UX, where
2989 socklen_t is wider than int (Bug#8277).
2990 (Fmake_network_process, server_accept_connection):
2991 (wait_reading_process_output, read_process_output):
2992 Likewise.
2993
2994 * process.c: Rename or move locals to avoid shadowing.
2995 (list_processes_1, Fmake_network_process):
2996 (read_process_output_error_handler, exec_sentinel_error_handler):
2997 Rename or move locals.
2998 (Fmake_network_process): Define label "retry_connect" only if needed.
2999 (Fnetwork_interface_info): Fix pointer signedness.
3000 (process_send_signal): Add cast to avoid pointer signedness problem.
3001 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3002 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3003
3004 Make tparam.h and terminfo.c consistent.
3005 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3006 Include tparam.h instead, since it declares them.
3007 * cm.h (PC): Remove extern decl; tparam.h now does this.
3008 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3009 * terminfo.c: Include tparam.h, to check interfaces.
3010 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3011 (tparam): Adjust signature to match interface in tparam.h;
3012 this removes some undefined behavior. Check that outstring and len
3013 are zero, which they always are with Emacs.
3014 * tparam.h (PC, BC, UP): New extern decls.
3015
3016 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3017 (xftfont_open): Rename locals to avoid shadowing.
3018
3019 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3020 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3021 (OTF_TAG_SYM): Omit macro if not needed.
3022 (ftfont_list): Remove unused local.
3023 (get_adstyle_property, ftfont_pattern_entity):
3024 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3025 Rename locals to avoid shadowing.
3026
3027 * xfont.c (xfont_list_family): Mark var as initialized.
3028
3029 * xml.c (make_dom): Now static.
3030
3031 * composite.c (composition_compute_stop_pos): Rename local to
3032 avoid shadowing.
3033 (composition_reseat_it): Remove unused locals.
3034 (find_automatic_composition, composition_adjust_point): Likewise.
3035 (composition_update_it): Mark var as initialized.
3036 (find_automatic_composition): Mark vars as initialized,
3037 with a FIXME (Bug#8290).
3038
3039 character.h: Rename locals to avoid shadowing.
3040 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3041 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3042 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3043 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3044 to avoid shadowing.
3045
3046 * textprop.c (property_change_between_p): Remove; unused.
3047
3048 * intervals.c (interval_start_pos): Now static.
3049
3050 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3051
3052 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3053 Rename locals to avoid shadowing.
3054
3055 * sound.c (wav_play, au_play, Fplay_sound_internal):
3056 Fix pointer signedness.
3057 (alsa_choose_format): Remove unused local var.
3058 (wav_play): Initialize a variable to 0, to prevent undefined
3059 behavior (Bug#8278).
3060
3061 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3062
3063 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3064
3065 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3066 clobbering (Bug#8298).
3067 * sysdep.c (sys_subshell): Likewise.
3068 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3069
3070 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3071 This should get cleaned up, so that child_setup has the
3072 same signature on all platforms.
3073
3074 * callproc.c (call_process_cleanup): Now static.
3075 (relocate_fd): Rename locals to avoid shadowing.
3076
30772011-03-22 Chong Yidong <cyd@stupidchicken.com>
3078
3079 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3080 not to be necessary, and produces flickering.
3081
30822011-03-20 Glenn Morris <rgm@gnu.org>
3083
3084 * config.in: Remove file.
3085
30862011-03-20 Juanma Barranquero <lekktu@gmail.com>
3087
3088 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3089 are now in src/globals.h.
3090 (syms_of_minibuf): Remove spurious & from previous change.
3091
30922011-03-20 Leo <sdl.web@gmail.com>
3093
3094 * minibuf.c (completing-read-function): New variable.
3095 (completing-read-default): Rename from completing-read.
3096 (completing-read): Call completing-read-function.
3097
30982011-03-19 Juanma Barranquero <lekktu@gmail.com>
3099
3100 * xfaces.c (Fx_load_color_file):
3101 Read color file from absolute filename (bug#8250).
3102
31032011-03-19 Juanma Barranquero <lekktu@gmail.com>
3104
3105 * makefile.w32-in: Update dependencies.
3106
31072011-03-17 Eli Zaretskii <eliz@gnu.org>
3108
3109 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3110
31112011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3112
3113 Fix more problems found by GCC 4.5.2's static checks.
3114
3115 * process.c (make_serial_process_unwind, send_process_trap):
3116 (sigchld_handler): Now static.
3117
3118 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3119 That way, the code declares only the vars that it needs.
3120 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3121 * s/cygwin.h (PTY_ITERATION): Likewise.
3122 * s/darwin.h (PTY_ITERATION): Likewise.
3123 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3124
3125 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3126 * process.c (allocate_pty): Don't declare stb unless it's needed.
3127
3128 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3129 (CONSTANTLIM): Remove; unused.
3130 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3131 Define only if needed.
3132
3133 * unexelf.c (unexec): Name an expression,
3134 to avoid gcc -Wbad-function-cast warning.
3135 Use a different way to cause a compilation error if anyone uses
3136 n rather than nn, a way that does not involve shadowing.
3137 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3138
3139 * deps.mk (unexalpha.o): Remove; unused.
3140
3141 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3142 * unexec.h: New file.
3143 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3144 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3145 Depend on unexec.h.
3146 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3147 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3148 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3149 Change as necessary to match prototype in unexec.h.
3150
3151 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3152 shadowing.
3153 (back_comment, skip_chars): Mark vars as initialized.
3154
3155 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3156 Rename locals to avoid shadowing.
3157
3158 * lread.c (read1): Rewrite so as not to use empty "else".
3159 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3160
3161 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3162
3163 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3164 warning when compiling print.c.
3165
3166 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3167 instead of using an uninitialized var.
3168 (font_sort_entities): Mark var as initialized.
3169
3170 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3171
3172 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3173 pointers to constants.
3174 (font_parse_fcname): Remove unused vars.
3175 (font_delete_unmatched): Now static.
3176 (font_get_spec): Remove; unused.
3177 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3178 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3179 Rename or move locals to avoid shadowing.
3180
3181 * fns.c (require_nesting_list, require_unwind): Now static.
3182 (Ffillarray): Rename locals to avoid shadowing.
3183
3184 * floatfns.c (domain_error2): Define only if needed.
3185 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3186
3187 * alloc.c (mark_backtrace): Move decl from here ...
3188 * lisp.h: ... to here, so that it can be checked.
3189
3190 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3191 (Fdefvar): Rewrite so as not to use empty "else".
3192 (lisp_indirect_variable): Name an expression,
3193 to avoid gcc -Wbad-function-cast warning.
3194 (Fdefvar): Rename locals to avoid shadowing.
3195
3196 * callint.c (quotify_arg, quotify_args): Now static.
3197 (Fcall_interactively): Rename locals to avoid shadowing.
3198 Use const pointer when appropriate.
3199
3200 * lisp.h (get_system_name, get_operating_system_release):
3201 Move decls here, to check interfaces.
3202 * process.c (get_operating_system_release): Move decl to lisp.h.
3203 * xrdb.c (get_system_name): Likewise.
3204 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3205 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3206 some of which prompt warnings from gcc -Wbad-function-cast.
3207 (Fformat_time_string, Fencode_time, Finsert_char):
3208 (Ftranslate_region_internal, Fformat):
3209 Rename or remove local vars to avoid shadowing.
3210 (Ftranslate_region_internal): Mark var as initialized.
3211
3212 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3213 avoid shadowing.
3214
3215 * lisp.h (eassert): Check that the argument compiles, even if
3216 ENABLE_CHECKING is not defined.
3217
3218 * data.c (Findirect_variable): Name an expression, to avoid
3219 gcc -Wbad-function-cast warning.
3220 (default_value, arithcompare, arith_driver, arith_error): Now static.
3221 (store_symval_forwarding): Rename local to avoid shadowing.
3222 (Fmake_variable_buffer_local, Fmake_local_variable):
3223 Mark variables as initialized.
3224 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3225
3226 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3227 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3228 Rename locals to avoid shadowing.
3229 (mark_stack): Move local variables into the #ifdef region where
3230 they're used.
3231 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3232 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3233 needed otherwise.
3234 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3235 (GC_STRING_CHARS): Remove; not used.
3236 (Fmemory_limit): Cast sbrk's returned value to char *.
3237
3238 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3239 avoids undefined behavior in theory.
3240
3241 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3242
3243 Use functions, not macros, for up- and down-casing (Bug#8254).
3244 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3245 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3246 to use the following functions instead of these macros.
3247 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3248 EMACS_INT, since callers assume the returned value fits in int.
3249 (upcase1): Likewise, for UPCASE_TABLE.
3250 (uppercasep, lowercasep, upcase): New static inline functions.
3251 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3252 the race-condition problem in the old DOWNCASE.
3253
3254 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3255 Rename locals to avoid shadowing.
3256 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3257 (regex_compile, re_search_2, re_match_2_internal):
3258 Remove unused local vars.
3259 (FREE_VAR): Rewrite so as not to use empty "else",
3260 which gcc can warn about.
3261 (regex_compile, re_match_2_internal): Mark locals as initialized.
3262 (RETALLOC_IF): Define only if needed.
3263 (WORDCHAR_P): Likewise. This one is never needed, but is used
3264 only in a comment talking about a compiler bug, so put inside
3265 the #if 0 of that comment.
3266 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3267 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3268 Remove; unused.
3269
3270 * search.c (boyer_moore): Rename locals to avoid shadowing.
3271 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3272 (PREV_CHAR_BOUNDARY): Likewise.
3273
3274 * search.c (simple_search): Remove unused var.
3275
3276 * dired.c (compile_pattern): Move decl from here ...
3277 * lisp.h: ... to here, so that it can be checked.
3278 (struct re_registers): New forward decl.
3279
3280 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3281
3282 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3283 All uses changed.
3284 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3285 Rename locals to avoid shadowing.
3286 (Fvertical_motion): Mark locals as initialized.
3287
3288 * casefiddle.c (casify_object, casify_region): Now static.
3289 (casify_region): Mark local as initialized.
3290
3291 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3292
3293 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3294 New macros, so that the caller can use some names other than
3295 gcpro1, gcpro2, etc.
3296 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3297 of the new macros.
3298 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3299 argument, for consistency with GCPRO2_VAR, etc: it is now the
3300 prefix of the variable, not the variable itself. All uses
3301 changed.
3302 * dired.c (directory_files_internal, file_name_completion):
3303 Rename locals to avoid shadowing.
3304
3305 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3306 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3307 dired.c's scmp function, had undefined behavior.
3308 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3309 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3310 * buffer.h: ... to here, because these macros use current_buffer,
3311 and the new implementation with inline functions needs to have
3312 current_buffer in scope now, rather than later when the macros
3313 are used.
3314 (downcase, upcase1): New static inline functions.
3315 (DOWNCASE, UPCASE1): Reimplement using these functions.
3316 This avoids undefined behavior in expressions like
3317 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3318 from race conditions in accessing the global variables
3319 case_temp1 and case_temp2.
3320 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3321 * lisp.h (case_temp1, case_temp2): Remove their decls.
3322 * character.h (ASCII_CHAR_P): Move from here ...
3323 * lisp.h: ... to here, so that the inline functions mentioned
3324 above can use them.
3325
3326 * dired.c (directory_files_internal_unwind): Now static.
3327
3328 * fileio.c (file_name_as_directory, directory_file_name):
3329 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3330 Now static.
3331 (file_name_as_directory): Use const pointers when appropriate.
3332 (Fexpand_file_name): Likewise. In particular, newdir might
3333 point at constant storage, so make it a const pointer.
3334 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3335 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3336 signedness issues.
3337 (Fset_file_times, Finsert_file_contents, auto_save_error):
3338 Rename locals to avoid shadowing.
3339
3340 * minibuf.c (choose_minibuf_frame_1): Now static.
3341 (Ftry_completion, Fall_completions): Rename or remove locals
3342 to avoid shadowing.
3343
3344 * marker.c (bytepos_to_charpos): Remove; unused.
3345
3346 * lisp.h (verify_bytepos, count_markers): New decls,
3347 so that gcc does not warn that these functions aren't declared.
3348
3349 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3350 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3351 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3352 (copy_text): Remove unused local var.
3353
3354 * filelock.c (within_one_second): Now static.
3355 (lock_file_1): Rename local to avoid shadowing.
3356
3357 * buffer.c (fix_overlays_before): Mark locals as initialized.
3358 (fix_start_end_in_overlays): Likewise. This function should be
3359 simplified by using pointers-to-pointers, but that's a different
3360 matter.
3361 (switch_to_buffer_1): Now static.
3362 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3363 (report_overlay_modification): Rename locals to avoid shadowing.
3364
3365 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3366 Fix pointer signedness issue.
3367 (sys_subshell): Mark local as volatile if checking for lint,
3368 to suppress a gcc -Wclobbered warning that does not seem to be right.
3369 (MAXPATHLEN): Define only if needed.
3370
3371 * process.c (serial_open, serial_configure): Move decls from here ...
3372 * systty.h: ... to here, so that they can be checked.
3373
3374 * fns.c (get_random, seed_random): Move extern decls from here ...
3375 * lisp.h: ... to here, so that they can be checked.
3376
3377 * sysdep.c (reset_io): Now static.
3378 (wait_for_termination_signal): Remove; unused.
3379
3380 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3381 (copy_keymap_item, append_key, push_text_char_description):
3382 Now static.
3383 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3384 (DENSE_TABLE_SIZE): Remove; unused.
3385 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3386 (describe_map_tree):
3387 Rename locals to avoid shadowing.
3388
3389 * keyboard.c: Declare functions static if they are not used elsewhere.
3390 (echo_char, echo_dash, cmd_error, top_level_2):
3391 (poll_for_input, handle_async_input): Now static.
3392 (read_char, kbd_buffer_get_event, make_lispy_position):
3393 (make_lispy_event, make_lispy_movement, apply_modifiers):
3394 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3395 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3396 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3397 (read_key_sequence, read_char): Mark locals as initialized.
3398 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3399
3400 * keyboard.h (make_ctrl_char): New decl.
3401 (mark_kboards): Move decl here ...
3402 * alloc.c (mark_kboards): ... from here.
3403
3404 * lisp.h (force_auto_save_soon): New decl.
3405
3406 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3407 (DEFINE_DUMMY_FUNCTION): New macro.
3408 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3409 Use it.
3410 (main): Add casts to avoid warnings
3411 if GCC considers string literals to be constants.
3412
3413 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3414
3415 * dbusbind.c: Pointer signedness fixes.
3416 (xd_signature, xd_append_arg, xd_initialize):
3417 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3418 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3419 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3420 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3421
3422 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3423 if GCC considers string literals to be constants.
3424 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3425
34262011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3427
3428 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3429 (print_preprocess, print_object): New macro to fix last change.
3430
3431 * print.c (print_preprocess): Don't forget font objects.
3432
34332011-03-16 Juanma Barranquero <lekktu@gmail.com>
3434
3435 * emacs.c (USAGE3): Doc fixes.
3436
34372011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3438
3439 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3440 structure.
3441
34422011-03-14 Juanma Barranquero <lekktu@gmail.com>
3443
3444 * lisp.h (VWindow_system, Qfile_name_history):
3445 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3446 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3447 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3448
3449 * w32select.c: Don't #include "keyboard.h".
3450 (run_protected): Add extern declaration for waiting_for_input.
3451
3452 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3453 * w32console.c (detect_input_pending, read_input_pending)
3454 (encode_terminal_code):
3455 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3456 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3457 (w32_system_caret_y, Qfile_name_history):
3458 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3459 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3460 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3461 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3462 * w32proc.c (Qlocal, report_file_error):
3463 * w32term.c (Vwindow_system, updating_frame):
3464 * w32uniscribe.c (initialized, uniscribe_font_driver):
3465 Remove unneeded extern declarations.
3466
34672011-03-14 Chong Yidong <cyd@stupidchicken.com>
3468
3469 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3470
34712011-03-13 Chong Yidong <cyd@stupidchicken.com>
3472
3473 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3474 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3475 These macros can no longer be used for assignment.
3476
3477 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3478 Assign struct members directly, instead of using BUF_BEGV etc.
3479 (record_buffer_markers, fetch_buffer_markers): New functions for
3480 recording and fetching special buffer markers.
3481 (set_buffer_internal_1, set_buffer_temp): Use them.
3482
3483 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3484
3485 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3486
3487 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3488 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3489
3490 * xdisp.c (hscroll_window_tree):
3491 (reconsider_clip_changes): Use PT instead of BUF_PT.
3492
34932011-03-13 Eli Zaretskii <eliz@gnu.org>
3494
3495 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3496 $(EMACS_ROOT)/lib/intprops.h.
3497
34982011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3499
3500 Fix more problems found by GCC 4.5.2's static checks.
3501
3502 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3503 to unsigned char * to avoid compiler diagnostic.
3504 (xg_free_frame_widgets): Make it clear that a local variable is
3505 needed only if USE_GTK_TOOLTIP.
3506 (gdk_window_get_screen): Make it clear that this macro is needed
3507 only if USE_GTK_TOOLTIP.
3508 (int_gtk_range_get_value): New function, which avoids a diagnostic
3509 from gcc -Wbad-function-cast.
3510 (xg_set_toolkit_scroll_bar_thumb): Use it.
3511 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3512 diagnostic from gcc -Wbad-function-cast.
3513 (get_utf8_string, xg_get_file_with_chooser):
3514 Rename locals to avoid shadowing.
3515 (create_dialog): Move locals to avoid shadowing.
3516
3517 * xgselect.c (xg_select): Remove unused var.
3518
3519 * image.c (four_corners_best): Mark locals as initialized.
3520 (gif_load): Initialize transparent_p to zero (Bug#8238).
3521 Mark another local as initialized.
3522 (my_png_error, my_error_exit): Mark with NO_RETURN.
3523
3524 * image.c (clear_image_cache): Now static.
3525 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3526 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3527 (x_edge_detection): Remove unnecessary cast that
3528 gcc -Wbad-function-cast diagnoses.
3529 (gif_load): Fix pointer signedness.
3530 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3531 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3532
35332011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3534
3535 Improve quality of tests for time stamp overflow.
3536 For example, without this patch (encode-time 0 0 0 1 1
3537 1152921504606846976) returns the obviously-bogus value (-948597
3538 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3539 reports time overflow. See
3540 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3541 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3542 * editfns.c: Include limits.h and intprops.h.
3543 (TIME_T_MIN, TIME_T_MAX): New macros.
3544 (time_overflow): Move earlier, to before first use.
3545 (hi_time, lo_time): New functions, for an accurate test for
3546 out-of-range times.
3547 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3548 (Fget_internal_run_time): Don't assume time_t fits in int.
3549 (make_time): Use list2 instead of Fcons twice.
3550 (Fdecode_time): More accurate test for out-of-range times.
3551 (check_tm_member): New function.
3552 (Fencode_time): Use it, to test for out-of-range times.
3553 (lisp_time_argument): Don't rely on undefined left-shift and
3554 right-shift behavior when checking for time stamp overflow.
3555
3556 * editfns.c (time_overflow): New function, refactoring common code.
3557 (Fformat_time_string, Fdecode_time, Fencode_time):
3558 (Fcurrent_time_string): Use it.
3559
3560 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3561 * dired.c (make_time): Move to ...
3562 * editfns.c (make_time): ... here.
3563 * systime.h: Note the move.
3564
35652011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3566
3567 * fringe.c (update_window_fringes): Remove unused variables.
3568
3569 * unexmacosx.c (copy_data_segment): Also copy __got section.
3570 (Bug#8223)
3571
35722011-03-12 Eli Zaretskii <eliz@gnu.org>
3573
3574 * termcap.c [MSDOS]: Include "msdos.h".
3575 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3576 Constify `char *' arguments and their references according to
3577 prototypes in tparam.h.
3578
3579 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3580
3581 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3582 Adapt all references accordingly.
3583
3584 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3585
35862011-03-11 Tom Tromey <tromey@redhat.com>
3587
3588 * buffer.c (syms_of_buffer): Remove obsolete comment.
3589
35902011-03-11 Eli Zaretskii <eliz@gnu.org>
3591
3592 * termhooks.h (encode_terminal_code): Declare prototype.
3593
3594 * msdos.c (encode_terminal_code): Don't declare prototype.
3595
3596 * term.c (encode_terminal_code): Now external again, used by
3597 w32console.c and msdos.c.
3598
3599 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3600 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3601
36022011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3603
3604 Fix some minor problems found by GCC 4.5.2's static checks.
3605
3606 * fringe.c (update_window_fringes): Mark locals as initialized
3607 (Bug#8227).
3608 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3609
3610 * alloc.c (mark_fringe_data): Move decl from here ...
3611 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3612 to check its interface.
3613 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3614
3615 * fontset.c (free_realized_fontset): Now static.
3616 (Fset_fontset_font): Rename local to avoid shadowing.
3617 (fontset_font): Mark local as initialized.
3618 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3619
3620 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3621
3622 * xselect.c (x_disown_buffer_selections): Remove; not used.
3623 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3624 (x_own_selection, Fx_disown_selection_internal): Rename locals
3625 to avoid shadowing.
3626 (x_handle_dnd_message): Remove local to avoid shadowing.
3627
3628 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3629 so that the caller can use some name other than gcpro1.
3630 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3631 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3632 (Fx_backspace_delete_keys_p):
3633 Use them to avoid shadowing, and rename vars to avoid shadowing.
3634 (x_decode_color, x_set_name, x_window): Now static.
3635 (Fx_create_frame): Add braces to silence GCC warning.
3636 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3637 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3638 Remove unused locals.
3639 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3640 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3641 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3642 macros.
3643
3644 * xterm.h (x_mouse_leave): New decl.
3645
3646 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3647 Remove unused functions.
3648 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3649 (x_calc_absolute_position): Now static.
3650 (XTread_socket): Don't define label "out" unless it's used.
3651 Don't declare local "event" unless it's used.
3652 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3653 unless they are used.
3654 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3655 (x_fatal_error_signal): Remove; not used.
3656 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3657 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3658 (x_error_catcher, x_connection_closed, x_error_handler):
3659 (x_error_quitter, xembed_send_message, x_iconify_frame):
3660 (my_log_handler): Rename locals to avoid shadowing.
3661 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3662 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3663
3664 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3665 Rename or move locals to avoid shadowing.
3666 (tty_defined_color, merge_face_heights): Now static.
3667 (free_realized_faces_for_fontset): Remove; not used.
3668 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3669 does not deduce is never used uninitialized.
3670 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3671 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3672
3673 * terminal.c (store_terminal_param): Now static.
3674
3675 * xmenu.c (menu_highlight_callback): Now static.
3676 (set_frame_menubar): Remove unused local.
3677 (xmenu_show): Rename parameter to avoid shadowing.
3678 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3679 since they might point to immutable storage.
3680 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3681 since it's unused otherwise.
3682
3683 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3684 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3685 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3686 avoids a gcc -Wuninitialized diagnostic.
3687 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3688 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3689 does not deduce are never used uninitialized.
3690
3691 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3692
3693 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3694 * window.c (window_loop, size_window):
3695 (run_window_configuration_change_hook, enlarge_window): Likewise.
3696
3697 * window.c (display_buffer): Now static.
3698 (size_window): Mark variables that gcc -Wuninitialized
3699 does not deduce are never used uninitialized.
3700 * window.h (check_all_windows): New decl, to forestall
3701 gcc -Wmissing-prototypes diagnostic.
3702 * dispextern.h (bidi_dump_cached_states): Likewise.
3703
3704 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3705 shadowing.
3706 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3707 Include <limits.h>.
3708 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3709 and to avoid gcc -Wuninitialized warning.
3710 (load_charset_map): Mark variables that gcc -Wuninitialized
3711 does not deduce are never used uninitialized.
3712 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3713
3714 * coding.c (coding_set_source, coding_set_destination):
3715 Use "else { /* comment */ }" rather than "else /* comment */;"
3716 for clarity, and to avoid gcc -Wempty-body warning.
3717 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3718 a block, when the outer 'i' will do.
3719 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3720 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3721 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3722 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3723 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3724 Rename locals to avoid shadowing.
3725 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3726 * coding.c (emacs_mule_char, encode_invocation_designation):
3727 Now static, since they're not used elsewhere.
3728 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3729 (decode_coding_object, encode_coding_object, detect_coding_system):
3730 (decode_coding_emacs_mule): Mark variables that gcc
3731 -Wuninitialized does not deduce are never used uninitialized.
3732 (detect_coding_iso_2022): Initialize a local variable that might
3733 be used uninitialized. Leave a FIXME because it's not clear that
3734 this initialization is needed. (Bug#8211)
3735 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3736 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3737 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3738 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3739 Remove unused macros.
3740
3741 * category.c (hash_get_category_set): Remove unused local var.
3742 (copy_category_table): Now static, since it's not used elsewhere.
3743 * character.c (string_count_byte8): Likewise.
3744
3745 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3746 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3747
3748 * chartab.c (copy_sub_char_table): Now static, since it's not used
3749 elsewhere.
3750 (sub_char_table_ref_and_range, char_table_ref_and_range):
3751 Rename locals to avoid shadowing.
3752 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3753
3754 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3755 (BIDI_BOB): Remove unused macro.
3756
3757 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3758 deduce are never used uninitialized.
3759 * term.c (encode_terminal_code): Likewise.
3760
3761 * term.c (encode_terminal_code): Now static. Remove unused local.
3762
3763 * tparam.h: New file.
3764 * term.c, tparam.h: Include it.
3765 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3766 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3767 Move these decls to tparam.h, and make them agree with what
3768 is actually in tparam.c. The previous trick of using incompatible
3769 decls in different modules does not conform to the C standard.
3770 All callers of tparam changed to use tparam's actual API.
3771 * tparam.c (tparam1, tparam, tgoto):
3772 Use const pointers where appropriate.
3773
3774 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3775 * cm.h (struct cm): Likewise.
3776 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3777 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3778 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3779 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3780 (turn_on_face, init_tty): Likewise.
3781 * termchar.h (struct tty_display_info): Likewise.
3782
3783 * term.c (term_mouse_position): Rename local to avoid shadowing.
3784
3785 * alloc.c (mark_ttys): Move decl from here ...
3786 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3787
37882011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3789
3790 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3791
37922011-03-09 Juanma Barranquero <lekktu@gmail.com>
3793
3794 * search.c (compile_pattern_1): Remove argument regp, unused since
3795 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3796 (compile_pattern): Don't pass it.
3797
37982011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3799
3800 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3801 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3802 for ! HAVE_GTK3.
3803 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3804
3805 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3806
3807 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3808 gdk_window_get_screen, gdk_window_get_geometry,
3809 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3810 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3811 (xg_get_pixbuf_from_pixmap): New function.
3812 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3813 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3814 Call xg_get_pixbuf_from_pixmap instead of
3815 gdk_pixbuf_get_from_drawable.
3816 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3817 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3818 (xg_check_special_colors): Use GtkStyleContext and its functions
3819 for HAVE_GTK3.
3820 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3821 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3822 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3823 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3824 Call gtk_widget_get_preferred_size.
3825 (xg_frame_resized): gdk_window_get_geometry only takes 5
3826 parameters.
3827 (xg_win_to_widget, xg_event_is_for_menubar):
3828 Call gdk_x11_window_lookup_for_display.
3829 (xg_set_widget_bg): New function.
3830 (delete_cb): New function.
3831 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3832 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3833 (xg_set_background_color): Call xg_set_widget_bg.
3834 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3835 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3836 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3837 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3838 if ! HAVE_GTK3.
3839 (update_frame_tool_bar): Call gtk_widget_hide.
3840 (xg_initialize): Use GDK_KEY_g.
3841
3842 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3843 if ! HAVE_GTK3
3844 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3845
3846 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3847 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3848 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3849
38502011-03-08 Juanma Barranquero <lekktu@gmail.com>
3851
3852 * w32xfns.c (select_palette): Check success of RealizePalette against
3853 GDI_ERROR, not zero.
3854
3855See ChangeLog.11 for earlier changes.
3856
3857;; Local Variables:
3858;; coding: utf-8
3859;; End:
3860
3861 Copyright (C) 2011 Free Software Foundation, Inc.
3862
3863 This file is part of GNU Emacs.
3864
3865 GNU Emacs is free software: you can redistribute it and/or modify
3866 it under the terms of the GNU General Public License as published by
3867 the Free Software Foundation, either version 3 of the License, or
3868 (at your option) any later version.
3869
3870 GNU Emacs is distributed in the hope that it will be useful,
3871 but WITHOUT ANY WARRANTY; without even the implied warranty of
3872 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3873 GNU General Public License for more details.
3874
3875 You should have received a copy of the GNU General Public License
3876 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.