* doc/misc/Makefile.in (mostlyclean): Add still more TeX intermediates.
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12012-05-12 Eli Zaretskii <eliz@gnu.org>
2
3 * lisp.mk (lisp): Add newcomment.elc.
4
52012-05-12 Glenn Morris <rgm@gnu.org>
6
7 * Makefile.in (MKDIR_P): New, set by configure.
8 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
9
102012-05-11 Paul Eggert <eggert@cs.ucla.edu>
11
12 Remove unused function hourglass_started.
13 * dispextern.h (hourglass_started):
14 * w32fns.c (hourglass_started):
15 * xdisp.c (hourglass_started): Remove.
16
172012-05-10 Juanma Barranquero <lekktu@gmail.com>
18
19 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
20 Update dependencies.
21
222012-05-10 Paul Eggert <eggert@cs.ucla.edu>
23
24 * xgselect.c (xg_select): Put maxfds+1 into a var.
25 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
26
27 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
28
292012-05-10 Dave Abrahams <dave@boostpro.com>
30
31 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
32 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
33
342012-05-09 Michael Albinus <michael.albinus@gmx.de>
35
36 * dbusbind.c (xd_registered_buses): New internal Lisp object.
37 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
38 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
39 Initialize xd_registered_buses.
40
412012-05-09 Paul Eggert <eggert@cs.ucla.edu>
42
43 Untag more efficiently if USE_LSB_TAG.
44 This is based on a proposal by YAMAMOTO Mitsuharu in
45 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
46 For an admittedly artificial (nth 8000 longlist) benchmark on
47 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
48 Emacs's overall text size by 1%.
49 * lisp.h (XUNTAG): New macro.
50 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
51 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
52 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
53 * eval.c (Fautoload):
54 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
55 * frame.h (XFRAME): Use XUNTAG.
56
57 Port recent dbusbind.c changes to 32-bit --with-wide-int.
58 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
59 Remove unportable assumptions about print widths of types like
60 dbus_uint32_t.
61 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
62 intptr_t when converting between pointer and integer, to avoid GCC
63 warnings about wrong width.
64
652012-05-09 Eli Zaretskii <eliz@gnu.org>
66
67 * w32proc.c (new_child): Force Windows to reserve only 64KB of
68 stack for each reader_thread, instead of defaulting to 8MB
69 determined by the linker. This avoids failures in creating
70 subprocesses on Windows 7, see the discussion in this thread:
71 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
72
732012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
74
75 Fix up display of the *Minibuf-0* buffer in the mini window.
76 * keyboard.c (read_char): Don't clear the echo area if there's no
77 message to clear.
78 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
79 contents of *Minibuf-0*) if there's no message displayed in its stead.
80
812012-05-07 Michael Albinus <michael.albinus@gmx.de>
82
83 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
84 batch mode.
85
862012-05-06 Chong Yidong <cyd@gnu.org>
87
88 * lisp.mk (lisp): Update.
89
902012-05-05 Jim Meyering <meyering@redhat.com>
91
92 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
93
942012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
95
96 * data.c (PUT_ERROR): New macro.
97 (syms_of_data): Use it. Add new error type `user-error'.
98 * undo.c (user_error): New function.
99 (Fprimitive_undo): Use it.
100 * print.c (print_error_message): Adjust print style for `user-error'.
101 * keyboard.c (user_error): New function.
102 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
103
1042012-05-03 Paul Eggert <eggert@cs.ucla.edu>
105
106 Do not limit current-time-string to years 1000..9999.
107 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
108 (Fcurrent_time_string): Support any year that is supported by the
109 underlying localtime representation. Don't use asctime, as it
110 has undefined behavior for years outside the range -999..9999.
111
1122012-05-02 Paul Eggert <eggert@cs.ucla.edu>
113
114 Fix race conditions involving setenv, gmtime, localtime, asctime.
115 Without this fix, interrupts could mess up code that uses these
116 nonreentrant functions, since setting TZ invalidates existing
117 tm_zone or tzname values, and since most of these functions return
118 pointers to static storage.
119 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
120 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
121 Grow the critical sections to include not just invoking
122 localtime/gmtime, but also accessing these functions' results
123 including their tm_zone values if any, and any related TZ setting.
124 (format_time_string): Last arg is now struct tm *, not struct tm **,
125 so that the struct tm is saved in the critical section.
126 All callers changed. Simplify allocation of initial buffer, partly
127 motivated by the fact that memory allocation needs to be outside
128 the critical section.
129
1302012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
131
132 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
133 with RESET_INTERVAL.
134
135 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
136 Remove duplicated buffer name initialization.
137
1382012-05-02 Jim Meyering <jim@meyering.net>
139
140 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
141
142 * xfns.c (x_window): Use xstrdup (Bug#11375).
143
1442012-05-02 Eli Zaretskii <eliz@gnu.org>
145
146 * xdisp.c (pos_visible_p): If already at a newline from the
147 display string before the 'while' loop, don't walk back the glyphs
148 from it3.glyph_row. Solves assertion violation when the display
149 string begins with a newline (egg.el). (Bug#11367)
150
1512012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
152
153 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
154 Move to simple.el.
155
1562012-05-01 Glenn Morris <rgm@gnu.org>
157
158 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
159 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
160 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
161 All were removed before 23.1.
162
163 * dispnew.c: Remove HAVE_LIBNCURSES test;
164 it is always true on relevant platforms.
165
166 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
167 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
168
169 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
170
1712012-04-30 Andreas Schwab <schwab@linux-m68k.org>
172
173 * .gdbinit (xpr): Remove checks for no longer existing misc types.
174 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
175 Remove.
176
1772012-04-28 Paul Eggert <eggert@cs.ucla.edu>
178
179 Do not avoid creating empty evaporating overlays (Bug#9642).
180 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
181 That is, do not delete an evaporating overlay if it becomes
182 empty after its bounds are adjusted to fit within its buffer.
183 This fix caused other problems, and I'm reverting it until we get
184 to the bottom of them.
185
1862012-04-27 Chong Yidong <cyd@gnu.org>
187
188 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
189
1902012-04-27 Eli Zaretskii <eliz@gnu.org>
191
192 * xdisp.c (pos_visible_p): If the window start position is beyond
193 ZV, start the display from buffer beginning. Prevents assertion
194 violation in init_iterator when the minibuffer window is scrolled
195 via the scroll bar.
196
197 * window.c (window_scroll_pixel_based): Likewise.
198
1992012-04-27 Chong Yidong <cyd@gnu.org>
200
201 * keymap.c (where_is_internal): Doc fix (Bug#10872).
202
2032012-04-27 Glenn Morris <rgm@gnu.org>
204
205 * fileio.c (Fcopy_file, Fset_file_selinux_context):
206 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
207
2082012-04-27 Eli Zaretskii <eliz@gnu.org>
209
210 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
211 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
212
2132012-04-26 Eli Zaretskii <eliz@gnu.org>
214
215 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
216 display element, check also the underlying string or buffer
217 character. (Bug#11341)
218
219 * w32menu.c: Include w32heap.h.
220 (add_menu_item): If the call to AppendMenuW (via
221 unicode_append_menu) fails, disable Unicode menus only if we are
222 running on Windows 9X/Me.
223
2242012-04-24 Andreas Schwab <schwab@linux-m68k.org>
225
226 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
227 (xgetint): Add missing shift for LSB tags.
228
2292012-04-24 Martin Rudalics <rudalics@gmx.at>
230
231 * keyboard.c (read_char): Don't wipe echo area for select window
232 events: These might get delayed via `mouse-autoselect-window'
233 (Bug#11304).
234
2352012-04-24 Juanma Barranquero <lekktu@gmail.com>
236
237 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
238 manipulation of :loaded-from data.
239
2402012-04-23 Juanma Barranquero <lekktu@gmail.com>
241
242 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
243 now a cons (bug#11311).
244
2452012-04-23 Paul Eggert <eggert@cs.ucla.edu>
246
247 Do not create empty overlays with the evaporate property (Bug#9642).
248 * buffer.c (Fmove_overlay): Delete an evaporating overlay
249 if it becomes empty after its bounds are adjusted to fit within
250 its buffer. Without this fix, in a nonempty buffer (let ((o
251 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
252 yields an empty overlay that has the evaporate property, which is
253 not supposed to happen.
254
255 Fix minor GTK3 problems found by static checking.
256 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
257 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
258 (struct _EmacsFixedClass, emacs_fixed_get_type):
259 Move decls here from emacsgtkfixed.h, since they needn't be public.
260 (emacs_fixed_get_type): Now static.
261 (emacs_fixed_class_init): Omit unused local.
262 (emacs_fixed_child_type): Remove; unused.
263 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
264 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
265 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
266 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
267 (EMACS_FIXED_GET_CLASS): Remove; unused.
268 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
269
270 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
271 Problem reported by Juanma Barranquero for Windows -Wunused-function.
272
2732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
274
275 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
276 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
277 (__malloc_size_t, __malloc_ptrdiff_t):
278 Remove. All uses removed, replaced by the definiens if needed,
279 since we can assume C89 or better now.
280 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
281 (protect_malloc_state, align, get_contiguous_space)
282 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
283 (malloc_atfork_handler_child, malloc_enable_thread)
284 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
285 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
286 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
287 (special_realloc, _realloc_internal_nolock, _realloc_internal)
288 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
289 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
290 Define using prototypes, not old style.
291 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
292 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
293 (align): Don't assume that signed integer overflow wraps around.
294 Omit unused local var.
295 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
296 (_free_internal_nolock, memalign, mallochook, reallochook):
297 Omit no-longer-needed casts.
298 (valloc): Use getpagesize, not __getpagesize.
299 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
300 (struct hdr): The 'magic' member is now size_t, not unsigned long.
301
302 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
303
3042012-04-22 Michael Albinus <michael.albinus@gmx.de>
305
306 Move functions from C to Lisp. Make non-blocking method calls
307 the default. Implement further D-Bus standard interfaces.
308
309 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
310 (QCdbus_request_name_allow_replacement)
311 (QCdbus_request_name_replace_existing)
312 (QCdbus_request_name_do_not_queue)
313 (QCdbus_request_name_reply_primary_owner)
314 (QCdbus_request_name_reply_in_queue)
315 (QCdbus_request_name_reply_exists)
316 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
317 (QCdbus_registered_serial, QCdbus_registered_method)
318 (QCdbus_registered_signal): New Lisp objects.
319 (XD_DEBUG_MESSAGE): Use sizeof.
320 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
321 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
322 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
323 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
324 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
325 (xd_signature, xd_append_arg): Allow float for integer types.
326 (xd_get_connection_references): New function.
327 (xd_get_connection_address): Rename from xd_initialize.
328 Return cached address.
329 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
330 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
331 level.
332 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
333 Return number of refcounts.
334 (Fdbus_get_unique_name): Make stronger parameter check.
335 (Fdbus_message_internal): New defun.
336 (Fdbus_call_method, Fdbus_call_method_asynchronously)
337 (Fdbus_method_return_internal, Fdbus_method_error_internal)
338 (Fdbus_send_signal, Fdbus_register_service)
339 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
340 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
341 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
342 (Vdbus_compiled_version, Vdbus_runtime_version)
343 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
344 (Vdbus_message_type_method_return, Vdbus_message_type_error)
345 (Vdbus_message_type_signal): New defvars.
346 (Vdbus_registered_buses, Vdbus_registered_objects_table):
347 Adapt docstring.
348
3492012-04-22 Paul Eggert <eggert@cs.ucla.edu>
350
351 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
352 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
353 Do not assume ptrdiff_t is the same width as 'int'.
354
355 * alloc.c: Handle unusual debugging option combinations.
356 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
357 since the two debugging options are incompatible.
358 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
359 is defined.
360 (mem_init, mem_insert, mem_insert_fixup):
361 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
362 (NEED_MEM_INSERT): Remove; no longer needed.
363
3642012-04-22 Leo Liu <sdl.web@gmail.com>
365
366 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
367
3682012-04-22 Paul Eggert <eggert@cs.ucla.edu>
369
370 * sysdep.c [__FreeBSD__]: Minor cleanups.
371 (list_system_processes, system_process_attributes) [__FreeBSD__]:
372 Use Emacs indenting style more consistently. Avoid some casts.
373 Use 'double' consistently rather than mixing 'float' and 'double'.
374
3752012-04-21 Eduard Wiebe <usenet@pusto.de>
376
377 * sysdep.c (list_system_processes, system_process_attributes):
378 Add implementation for FreeBSD (Bug#5243).
379
3802012-04-21 Andreas Schwab <schwab@linux-m68k.org>
381
382 * lisp.mk (lisp): Update.
383
3842012-04-20 Paul Eggert <eggert@cs.ucla.edu>
385
386 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
387 It is never used otherwise.
388
3892012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
390
391 * print.c (print_preprocess): Only check print_depth if print-circle
392 is nil.
393 (print_object): Check for cycles even when print-circle is nil and
394 print-gensym is t, but only check print_depth if print-circle is nil.
395
3962012-04-20 Chong Yidong <cyd@gnu.org>
397
398 * process.c (wait_reading_process_output): If EIO occurs on a pty,
399 set the status to "failed" and ensure that sentinel is run.
400
4012012-04-20 Glenn Morris <rgm@gnu.org>
402
403 * process.c (Fset_process_inherit_coding_system_flag)
404 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
405 (Fmake_network_process, Fmake_serial_process): Doc fix.
406
4072012-04-20 Eli Zaretskii <eliz@gnu.org>
408
409 * xdisp.c (string_buffer_position_lim): Limit starting position to
410 BEGV.
411 (set_cursor_from_row): If called for a mode-line or header-line
412 row, return zero immediately.
413 (try_cursor_movement): If inside continuation line, don't back up
414 farther than the first row after the header line, if any.
415 Don't consider the header-line row as "partially visible", even if
416 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
417
4182012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
419
420 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
421 (bug#11238).
422
4232012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4242012-04-18 Paul Eggert <eggert@cs.ucla.edu>
425
426 configure: new option --enable-gcc-warnings (Bug#11207)
427 * Makefile.in (C_WARNINGS_SWITCH): Remove.
428 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
429 (ALL_CFLAGS): Use new macros rather than old.
430 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
431 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
432 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
433 -Wunused-result, -Wunused-variable. This should go away once
434 the Emacs and Gnulib regex code is merged.
435 (xmalloc, xrealloc): Now static.
436
4372012-04-17 Paul Eggert <eggert@cs.ucla.edu>
438
439 * dired.c (Fsystem_groups): Remove unused local.
440
4412012-04-17 Glenn Morris <rgm@gnu.org>
442
443 * dired.c (Fsystem_users): Doc fix.
444
4452012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
446
447 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
448 (syms_of_dired): Add them.
449
4502012-04-16 Paul Eggert <eggert@cs.ucla.edu>
451
452 Fix minor alloc.c problems found by static checking.
453 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
454 New extern decls, to avoid calling undeclared functions.
455 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
456 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
457 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
458 (NEED_MEM_INSERT): New macro.
459 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
460 Remove one incorrect comment and fix another.
461
462 Fix minor ralloc.c problems found by static checking.
463 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
464 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
465 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
466 (r_alloc_sbrk): Now static.
467
468 Improve ralloc.c interface checking.
469 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
470 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
471 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
472 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
473 [REL_ALLOC]: ... to here, to check interface.
474 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
475 Remove decls. This fixes an "It stinks!".
476
477 * alloc.c (which_symbols): Fix alignment issue / type clash.
478
4792012-04-15 Andreas Schwab <schwab@linux-m68k.org>
480
481 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
482 (struct Lisp_Misc_Any): Likewise.
483 (struct Lisp_Free): Likewise.
484 * alloc.c (union aligned_Lisp_Symbol): Define.
485 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
486 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
487 (union aligned_Lisp_Misc): Define.
488 (MARKER_BLOCK_SIZE, struct marker_block): Use union
489 aligned_Lisp_Misc instead of union Lisp_Misc.
490 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
491
4922012-04-14 Paul Eggert <eggert@cs.ucla.edu>
493
494 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
495 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
496 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
497 * s/netbsd.h, s/sol2-6.h:
498 Remove definition of GC_MARK_STACK, since the default now works.
499 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
500 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
501 no longer the default.
502 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
503
5042012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
505
506 * lread.c (lisp_file_lexically_bound_p):
507 Fix hang at ";-*-\n" (bug#11238).
508
5092012-04-14 Eli Zaretskii <eliz@gnu.org>
510
511 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
512 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
513
5142012-04-14 Jan Djärv <jan.h.d@swipnet.se>
515
516 * nsterm.m (constrainFrameRect): Always constrain when there is only
517 one screen (Bug#10962).
518
5192012-04-13 Ken Brown <kbrown@cornell.edu>
520
521 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
522
5232012-04-13 Reuben Thomas <rrt@sc3d.org>
524
525 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
526
5272012-04-11 Daniel Colascione <dancol@dancol.org>
528
529 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
530 against is gone. It's better to use vfork now so that when Cygwin
531 gains a new, working vfork, we use it automatically (bug#10398).
532
5332012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
534
535 * window.c (save_window_save): Obey window-point-insertion-type.
536
5372012-04-11 Glenn Morris <rgm@gnu.org>
538
539 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
540
5412012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
542
543 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
544
5452012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
546
547 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
548 (force_quit_count): New var.
549 (handle_interrupt): Use it.
550
5512012-04-10 Juanma Barranquero <lekktu@gmail.com>
552
553 * w32.c (w32_delayed_load): Record the full path of the library
554 being loaded (bug#10424).
555
5562012-04-09 Glenn Morris <rgm@gnu.org>
557
558 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
559 not just in the obarray, before snarfing them. (Bug#11036)
560
561 * Makefile.in ($(leimdir)/leim-list.el):
562 Pass EMACS rather than BUILT_EMACS.
563
5642012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
565
566 * process.c (make_process):
567 * process.h: Add integer `gnutls_handshakes_tried' member to
568 process struct.
569
570 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
571 Add convenience `GNUTLS_LOG2i' macro.
572
573 * gnutls.c (gnutls_log_function2i): Convenience log function.
574 (emacs_gnutls_read): Use new log functions,
575 `gnutls_handshakes_tried' process member, and
576 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
577 attempts per process (connection).
578
5792012-04-09 Chong Yidong <cyd@gnu.org>
580
581 * eval.c (Fuser_variable_p, user_variable_p_eh)
582 (lisp_indirect_variable): Functions deleted.
583 (Fdefvar): Caller changed.
584
585 * callint.c (Finteractive, Fcall_interactively):
586 * minibuf.c (Fread_variable): Callers changed.
587
5882012-04-09 Eli Zaretskii <eliz@gnu.org>
589
590 * xdisp.c (set_cursor_from_row): If the display string appears in
591 the buffer at position that is closer to point than the position
592 after the display string, display the cursor on the first glyph of
593 the display string. Fixes cursor display when a 'display' text
594 property immediately follows invisible text. (Bug#11094)
595
5962012-04-09 Paul Eggert <eggert@cs.ucla.edu>
597
598 composite.c: use 'double' consistently
599 * composite.c (get_composition_id): Use 'double' consistently
600 instead of converting 'float' to 'double' and vice versa; this is
601 easier to understand and avoids a GCC warning.
602
6032012-04-09 Glenn Morris <rgm@gnu.org>
604
605 * Makefile.in: Generate leim-list with bootstrap-emacs, in
606 preparation for dumping it with emacs. (Bug#4789)
607 (leimdir): New variable.
608 ($(leimdir)/leim-list.el): New rule.
609 (emacs$(EXEEXT)): Depend on leim-list.el.
610
611 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
612 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
613 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
614
6152012-04-08 Andreas Schwab <schwab@linux-m68k.org>
616
617 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
618 proper alignment.
619
6202012-04-07 Juanma Barranquero <lekktu@gmail.com>
621
622 * xml.c (init_libxml2_functions) [WINDOWSNT]:
623 Remove unused local variable.
624
6252012-04-07 Paul Eggert <eggert@cs.ucla.edu>
626
627 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
628 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
629 (mark_memory): Mark Lisp_Objects only if pointers might hide in
630 objects, as mark_maybe_pointer will catch them otherwise.
631 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
632 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
633
6342012-04-07 Paul Eggert <eggert@cs.ucla.edu>
635
636 Fix typo that broke non-Windows builds.
637 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
638
6392012-04-07 Eli Zaretskii <eliz@gnu.org>
640
641 Support building on MS-Windows with libxml2.
642
643 * makefile.w32-in (OBJ2): Add xml.$(O).
644 (GLOBAL_SOURCES): Add xml.c.
645 ($(BLD)/xml.$(O)): New dependency list.
646
647 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
648 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
649 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
650 [!WINDOWSNT]: New macros.
651 (init_libxml2_functions, libxml2_loaded_p): New functions.
652 (parse_region): Call fn_xmlCheckVersion instead of using the macro
653 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
654 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
655 Calls xmlCleanupParser only if libxml2 was loaded (or statically
656 linked in).
657 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
658 Call init_libxml2_functions before calling libxml2 functions.
659 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
660
661 * emacs.c: Don't include libxml/parser.h.
662 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
663 xmlCleanupParser directly.
664
665 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
666
6672012-04-07 Eli Zaretskii <eliz@gnu.org>
668
669 * indent.c (Fvertical_motion): If there is a display string at
670 point, use it.vpos to compute how many lines to backtrack after
671 move_it_to point. (Bug#11133)
672
6732012-04-06 Eli Zaretskii <eliz@gnu.org>
674
675 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
676 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
677 about subtle differences between FETCH_CHAR* and STRING_CHAR*
678 macros related to unification of CJK characters. For the details,
679 see the discussion following the message here:
680 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
681
6822012-04-04 Chong Yidong <cyd@gnu.org>
683
684 * keyboard.c (Vdelayed_warnings_list): Doc fix.
685
6862012-04-01 Eli Zaretskii <eliz@gnu.org>
687
688 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
689 instead of alloca. (Bug#11138)
690
6912012-04-01 Andreas Schwab <schwab@linux-m68k.org>
692
693 * w32menu.c (is_simple_dialog): Properly check lisp types.
694 (Bug#11141)
695
6962012-03-31 Eli Zaretskii <eliz@gnu.org>
697
698 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
699 position we get to after a call to move_it_to fails the
700 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
701 only if we wind up in a string from display property. (Bug#11063)
702
703 * window.c (Fdelete_other_windows_internal): Invalidate the row
704 and column information about mouse highlight, so that redisplay
705 restores it after reallocating the glyph matrices. (Bug#7464)
706
707 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
708 string comes from a `display' text property, use the buffer
709 position of that property as if we actually saw that position in
710 the row's glyphs.
711 (move_it_by_lines): Remove the assertion that
712 "it->current_x == 0 && it->hpos == 0" which can be legitimately
713 violated when there's a before-string at the beginning of a line.
714 (Bug#11063)
715
7162012-03-30 Eli Zaretskii <eliz@gnu.org>
717
718 * xdisp.c (append_space_for_newline): If the default face was
719 remapped, use the remapped face for the appended newline.
720 (extend_face_to_end_of_line): Use the remapped default face for
721 extending the face to the end of the line.
722 (display_line): Call extend_face_to_end_of_line when the default
723 face was remapped. (Bug#11068)
724
7252012-03-29 Eli Zaretskii <eliz@gnu.org>
726
727 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
728
7292012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
730
731 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
732
7332012-03-27 Glenn Morris <rgm@gnu.org>
734
735 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
736 Doc fixes.
737
7382012-03-26 Kenichi Handa <handa@m17n.org>
739
740 * dispextern.h (struct glyph): Fix previous change. Change the
741 bit length of glyphless.ch to 25 (Bug#11082).
742
7432012-03-26 Chong Yidong <cyd@gnu.org>
744
745 * keyboard.c (Vselection_inhibit_update_commands): New variable.
746 (command_loop_1): Use it; inhibit selection update for
747 handle-select-window too (Bug#8996).
748
7492012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
750
751 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
752
7532012-03-25 Kenichi Handa <handa@m17n.org>
754
755 * dispextern.h (struct glyph): Change the bit length of
756 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
757
7582012-03-24 Eli Zaretskii <eliz@gnu.org>
759
760 * s/ms-w32.h (tzname): Include time.h before redirecting to
761 _tzname. Fixes the MSVC build. (Bug#9960)
762
7632012-03-24 Andreas Schwab <schwab@linux-m68k.org>
764
765 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
766 characters.
767
768 * xterm.c (XTread_socket): Only modify handling_signal if
769 !SYNC_INPUT. (Bug#11080)
770
7712012-03-23 Eli Zaretskii <eliz@gnu.org>
772
773 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
774 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
775 when fetching a multibyte character consumes more bytes than
776 CHAR_BYTES returns, due to unification of CJK characters in
777 string_char. (Bug#11073)
778
7792012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
780
781 * process.c (wait_reading_process_output): Handle pty disconnect
782 by refraining from sending oneself a SIGCHLD (bug#10933).
783
7842012-03-22 Chong Yidong <cyd@gnu.org>
785
786 * dispextern.h (struct it): New member string_from_prefix_prop_p.
787
788 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
789 Mark string as coming from a prefix property.
790 (handle_face_prop): Use default face for prefix strings (Bug#4281).
791 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
792
7932012-03-21 Chong Yidong <cyd@gnu.org>
794
795 * xfaces.c (Vface_remapping_alist): Doc fix.
796
7972012-03-20 Eli Zaretskii <eliz@gnu.org>
798
799 * w32proc.c (Fw32_set_console_codepage)
800 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
801 Doc fixes.
802
8032012-03-20 Chong Yidong <cyd@gnu.org>
804
805 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
806 to reflect default non-nil value of redisplay-dont-pause.
807
8082012-03-19 Kenichi Handa <handa@m17n.org>
809
810 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
811 it fit in a valid range (Bug#11003).
812
8132012-03-18 Eli Zaretskii <eliz@gnu.org>
814
815 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
816 that is not from display property, accept the row as a "cursor
817 row" if one of the string's character has a non-nil `cursor'
818 property. Fixes cursor positioning when there are newlines in
819 overlay strings, e.g. in icomplete.el. (Bug#11035)
820
8212012-03-12 Paul Eggert <eggert@cs.ucla.edu>
822
823 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
824
8252012-03-12 Chong Yidong <cyd@gnu.org>
826
827 * eval.c (inhibit_lisp_code): Rename from
828 inhibit_window_configuration_change_hook; move from window.c.
829
830 * xfns.c (unwind_create_frame_1, Fx_create_frame):
831 * window.c (run_window_configuration_change_hook)
832 (syms_of_window): Callers changed.
833
8342012-03-11 Chong Yidong <cyd@gnu.org>
835
836 * keymap.c (Fkey_description): Doc fix (Bug#9700).
837
838 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
839
8402012-03-10 Chong Yidong <cyd@gnu.org>
841
842 * frame.c (other_visible_frames): Don't assume the selected frame
843 is visible (Bug#10955).
844
8452012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
846
847 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
848
8492012-03-08 Jan Djärv <jan.h.d@swipnet.se>
850
851 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
852 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
853 zero (Bug#10954).
854
8552012-03-03 Glenn Morris <rgm@gnu.org>
856
857 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
858
8592012-03-02 Eli Zaretskii <eliz@gnu.org>
860
861 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
862 position past the first glyph_row that ends at ZV. (Bug#10902)
863 (redisplay_window, next_element_from_string): Fix typos in
864 comments.
865 (redisplay_window): Pass to move_it_vertically the margin in
866 pixels, not in screen lines.
867
8682012-03-02 Glenn Morris <rgm@gnu.org>
869
870 * buffer.c (buffer-list-update-hook): Doc fix.
871
8722012-02-29 Eli Zaretskii <eliz@gnu.org>
873
874 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
875 push_it before setting up the iterator for the first overlay
876 string, even if we have an empty string loaded.
877 (next_overlay_string): If there's an empty string on the iterator
878 stack, pop the stack. (Bug#10903)
879
8802012-02-25 Paul Eggert <eggert@cs.ucla.edu>
881
882 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
883 Suggested by Stefan Monnier in
884 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
885 * alloc.c (widen_to_Lisp_Object): New static function.
886 (mark_memory): Also mark Lisp_Objects by fetching pointer words
887 and widening them to Lisp_Objects. This would work even if
888 USE_LSB_TAG is defined and wide integers are used, which might
889 happen in a future version of Emacs.
890
8912012-02-25 Chong Yidong <cyd@gnu.org>
892
893 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
894 Doc fix.
895
896 * xselect.c (Fx_selection_exists_p): Doc fix.
897 (x_clipboard_manager_save_all): Print an informative message
898 before saving to clipboard manager.
899
9002012-02-24 Chong Yidong <cyd@gnu.org>
901
902 * keyboard.c (process_special_events): Handle all X selection
903 requests in kbd_buffer, not just the next one (Bug#8869).
904
9052012-02-23 Chong Yidong <cyd@gnu.org>
906
907 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
908 call when setting menu-bar-lines and tool-bar-lines parameters.
909 (unwind_create_frame_1): New helper function.
910
911 * window.c (inhibit_window_configuration_change_hook): New var.
912 (run_window_configuration_change_hook): Obey it.
913 (syms_of_window): Initialize it.
914
9152012-02-22 Chong Yidong <cyd@gnu.org>
916
917 * xterm.c (x_draw_image_relief): Add missing type check for
918 Vtool_bar_button_margin (Bug#10743).
919
9202012-02-21 Chong Yidong <cyd@gnu.org>
921
922 * fileio.c (Vfile_name_handler_alist): Doc fix.
923
924 * buffer.c (Fget_file_buffer): Protect against invalid file
925 handler return value.
926
9272012-02-20 Paul Eggert <eggert@cs.ucla.edu>
928
929 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
930 when computing $valmask.
931
932 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
933 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
934 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
935 It's useless in that case, and it can cause problems on hosts
936 that allocate halves of EMACS_INT values separately.
937 Reported by Dan Horák. Diagnosed by Andreas Schwab in
938 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
939 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
940 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
941 it avoids undefined behavior on hosts where shifting right by more
942 than the word width has undefined behavior.
943
9442012-02-19 Chong Yidong <cyd@gnu.org>
945
946 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
947 (Funhandled_file_name_directory, Ffile_name_as_directory)
948 (Fdirectory_file_name, Fexpand_file_name)
949 (Fsubstitute_in_file_name): Protect against invalid file handler
950 return values (Bug#10845).
951
9522012-02-18 Eli Zaretskii <eliz@gnu.org>
953
954 * .gdbinit (pitx): Fix incorrect references to fields of the
955 iterator stack.
956
9572012-02-17 Chong Yidong <cyd@gnu.org>
958
959 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
960
9612012-02-15 Paul Eggert <eggert@cs.ucla.edu>
962
963 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
964 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
965
9662012-02-15 Chong Yidong <cyd@gnu.org>
967
968 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
969 marked as special. Also, starting docstrings with * is obsolete.
970
9712012-02-13 Andreas Schwab <schwab@linux-m68k.org>
972
973 * gnutls.c (emacs_gnutls_write): Fix last change.
974
9752012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
976
977 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
978 send_process.
979
9802012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
981
982 * keymap.c (Fsingle_key_description): Handle char ranges.
983
9842012-02-12 Chong Yidong <cyd@gnu.org>
985
986 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
987 as that creates a dangerous corner case.
988
989 * window.c (Fdelete_window_internal): Invalidate the mouse
990 highlight (Bug#9904).
991
9922012-02-12 Glenn Morris <rgm@gnu.org>
993
994 * xselect.c (Fx_own_selection_internal)
995 (Fx_get_selection_internal, Fx_disown_selection_internal)
996 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
997 * nsselect.m (Fx_own_selection_internal)
998 (Fx_disown_selection_internal, Fx_selection_exists_p)
999 (Fx_selection_owner_p, Fx_get_selection_internal):
1000 Sync docs and argument specs with the xselect.c versions.
1001
10022012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1003
1004 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1005
10062012-02-11 Eli Zaretskii <eliz@gnu.org>
1007
1008 * w32select.c (Fx_selection_exists_p): Sync doc string and
1009 argument list with xselect.c. (Bug#10783)
1010
1011 * w16select.c (Fx_selection_exists_p): Sync doc string and
1012 argument list with xselect.c. (Bug#10783)
1013
10142012-02-10 Glenn Morris <rgm@gnu.org>
1015
1016 * fns.c (Fsecure_hash): Doc fix.
1017
10182012-02-09 Kenichi Handa <handa@m17n.org>
1019
1020 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1021
10222012-02-07 Chong Yidong <cyd@gnu.org>
1023
1024 * buffer.c (Fbuffer_local_variables)
1025 (buffer_lisp_local_variables): Handle unbound vars correctly;
1026 don't let Qunbound leak into Lisp.
1027
10282012-02-07 Glenn Morris <rgm@gnu.org>
1029
1030 * image.c (Fimagemagick_types): Doc fix.
1031
1032 * image.c (imagemagick-render-type): Change it from a lisp object
1033 to an integer. Move the doc here from the lisp manual.
1034 Treat all values not equal to 0 the same.
1035
10362012-02-06 Chong Yidong <cyd@gnu.org>
1037
1038 * doc.c (store_function_docstring): Avoid applying docstring of
1039 alias to base function (Bug#2603).
1040
10412012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1042
1043 * .gdbinit (pp1, pv1): Remove redundant defines.
1044 (pr): Use pp.
1045
10462012-02-04 Chong Yidong <cyd@gnu.org>
1047
1048 * nsterm.m: Declare a global (Bug#10694).
1049
10502012-02-04 Eli Zaretskii <eliz@gnu.org>
1051
1052 * w32.c (get_emacs_configuration_options):
1053 Include --enable-checking, if specified, in the return value.
1054
10552012-02-04 Martin Rudalics <rudalics@gmx.at>
1056
1057 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1058 after rounding frame sizes. (Bug#9723)
1059
10602012-02-04 Eli Zaretskii <eliz@gnu.org>
1061
1062 * keyboard.c (adjust_point_for_property): Don't position point
1063 before BEGV. (Bug#10696)
1064
10652012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1066
1067 Handle overflow when computing char display width (Bug#9496).
1068 * character.c (char_width): Return EMACS_INT, not int.
1069 (char_width, c_string_width): Check for overflow when
1070 computing the width; this is possible now that individual
1071 characters can have unbounded width. Problem introduced
1072 by merge from Emacs 23 on 2012-01-19.
1073
10742012-02-02 Michael Albinus <michael.albinus@gmx.de>
1075
1076 * dbusbind.c (Fdbus_register_method): Mention the return value
1077 :ignore in the docstring.
1078
10792012-02-02 Glenn Morris <rgm@gnu.org>
1080
1081 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1082
1083 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1084 Unconditionally set to t. (Bug#10673)
1085 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1086 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1087 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1088
10892012-02-02 Kenichi Handa <handa@m17n.org>
1090
1091 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1092 0, do not call append_composite_glyph.
1093
10942012-02-02 Kenichi Handa <handa@m17n.org>
1095
1096 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1097 NULL (Bug#6988).
1098 (x_produce_glyphs): If the component of a composition is a null
1099 string, set it->pixel_width to 1 to avoid zero-width glyph.
1100
11012012-02-01 Eli Zaretskii <eliz@gnu.org>
1102
1103 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1104 first 2 arguments are identical. This makes inserting large
1105 output from a subprocess an order of magnitude faster on
1106 MS-Windows, where all sbrk'ed memory is always contiguous.
1107
11082012-01-31 Glenn Morris <rgm@gnu.org>
1109
1110 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1111 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1112 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1113
11142012-01-29 Glenn Morris <rgm@gnu.org>
1115
1116 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1117
11182012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1119
1120 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1121
11222012-01-28 Chong Yidong <cyd@gnu.org>
1123
1124 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1125
11262012-01-26 Chong Yidong <cyd@gnu.org>
1127
1128 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1129
1130 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1131 repeat counts (Bug#10507).
1132
11332012-01-26 Glenn Morris <rgm@gnu.org>
1134
1135 * lread.c (syms_of_lread): Doc fix.
1136
11372012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1138
1139 * coding.c (encode_designation_at_bol): Change return value to
1140 EMACS_INT.
1141
11422012-01-25 Chong Yidong <cyd@gnu.org>
1143
1144 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1145
11462012-01-21 Chong Yidong <cyd@gnu.org>
1147
1148 * floatfns.c (Fcopysign): Make the second argument non-optional,
1149 since nil is not allowed anyway.
1150
11512012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1152
1153 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1154 (send_process): Likewise.
1155
11562012-01-19 Martin Rudalics <rudalics@gmx.at>
1157
1158 * window.c (save_window_save, Fcurrent_window_configuration)
1159 (Vwindow_persistent_parameters): Do not use Qstate.
1160 Rewrite doc-strings.
1161
11622012-01-19 Kenichi Handa <handa@m17n.org>
1163
1164 * character.c (char_width): New function.
1165 (Fchar_width, c_string_width, lisp_string_width):
1166 Use char_width (Bug#9496).
1167
11682012-01-16 Martin Rudalics <rudalics@gmx.at>
1169
1170 * window.c (Vwindow_persistent_parameters): New variable.
1171 (Fset_window_configuration, save_window_save): Handle persistent
1172 window parameters.
1173
11742012-01-14 Eli Zaretskii <eliz@gnu.org>
1175
1176 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1177 thrashing the stack of the thread. (Bug#9087)
1178
11792012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1182
11832012-01-11 Eli Zaretskii <eliz@gnu.org>
1184
1185 * xdisp.c (rows_from_pos_range): Handle the case where the
1186 highlight ends on a newline. (Bug#10464)
1187 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1188 he end column for display of highlight that ends on a newline
1189 before a R2L line.
1190
11912012-01-11 Glenn Morris <rgm@gnu.org>
1192
1193 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1194 from load-path also when installation-directory is nil. (Bug#10208)
1195
11962012-01-10 Glenn Morris <rgm@gnu.org>
1197
1198 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1199
1200 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1201 Update template values to be closer to their typical values these days.
1202
12032012-01-09 Eli Zaretskii <eliz@gnu.org>
1204
1205 * xdisp.c (rows_from_pos_range): Accept additional argument
1206 DISP_STRING, and accept any glyph in a row whose object is that
1207 string as eligible for mouse highlight. Fixes mouse highlight of
1208 display strings from overlays. (Bug#10464)
1209
12102012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 emacs: fix an auto-save permissions race condition (Bug#10400)
1213 * fileio.c (auto_saving_dir_umask): New static var.
1214 (Fmake_directory_internal): Use it.
1215 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1216 creating the directory. The old code temporarily assigns
1217 too-generous permissions to the directory.
1218 (do_auto_save_eh): Clear it.
1219 (Fdo_auto_save): Catch all errors, not just file errors, so
1220 that the var is always cleared.
1221
12222012-01-07 Eli Zaretskii <eliz@gnu.org>
1223
1224 * search.c (scan_buffer): Pass character positions to
1225 know_region_cache, not byte positions. (Bug#6540)
1226
12272012-01-07 LynX <_LynX@bk.ru> (tiny change)
1228
1229 * w32.c (sys_rename): Report EXDEV when rename of a directory
1230 fails because the target is on another logical disk. (Bug#10284)
1231
12322012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1233
1234 * xterm.c (x_embed_request_focus): New function.
1235
1236 * xterm.h: Add prototype.
1237
1238 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1239
12402012-01-05 Glenn Morris <rgm@gnu.org>
1241
1242 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1243
12442012-01-01 Eli Zaretskii <eliz@gnu.org>
1245
1246 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1247 Load gnutls_transport_set_lowat only if GnuTLS version is below
1248 2.11.1.
1249 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1250 GnuTLS versions below 2.11.1.
1251
12522011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1253
1254 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1255 to the doc string advising against its use for altering the way
1256 windows are scrolled.
1257
12582011-12-28 Kenichi Handa <handa@m17n.org>
1259
1260 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1261 coding-system ASCII compatible only when it does not produce BOM
1262 on encoding (Bug#10383).
1263
12642011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1265
1266 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1267 can scroll.
1268 (create_and_show_popup_menu): Always use menu_position_func for
1269 Gtk3 (Bug#10361).
1270
12712011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1272
1273 * callint.c (Fcall_interactively): Don't truncate prompt string.
1274
12752011-12-23 Eli Zaretskii <eliz@gnu.org>
1276
1277 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1278 property that ends at ZV, so that the bidi iteration could be
1279 resumed from there (after widening). (Bug#10360)
1280
12812011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1282
1283 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1284
12852011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1286
1287 * nsterm.m (x_free_frame_resources):
1288 Release f->output_data.ns->miniimage.
1289 (ns_index_color): Fix indentation. Do not retain
1290 color_table->colors[i].
1291
1292 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1293 before returning.
1294
1295 * nsfns.m (x_set_background_color): Assign return value from
1296 ns_index_color to face-background instead of NSColor*.
1297 (ns_implicitly_set_icon_type): Fix indentation.
1298 Change assignment in for loop to comparison.
1299
1300 * emacs.c (ns_pool): New variable.
1301 (main): Assign ns_pool.
1302 (Fkill_emacs): Call ns_release_autorelease_pool.
1303
1304 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1305 autorelease fdesc, release fdAttrs and tdict.
1306 (ns_get_covering_families): Release charset.
1307 (ns_findfonts): Release NSFontDescriptor created with new.
1308 (ns_uni_to_glyphs): Fix indentation.
1309 (setString): Release attrStr before assigning new value.
1310
13112011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1312
1313 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1314 and NS_IMPL_COCOA.
1315 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1316 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1317
13182011-12-18 David Reitter <reitter@cmu.edu>
1319
1320 * nsterm.m (ns_term_init): Subscribe for notifications
1321 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1322 to method trackingNotification in EmacsMenu.
1323
1324 * nsmenu.m (trackingMenu): New variable.
1325 (trackingNotification): New method (from Aquamacs).
1326 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1327 from Aquamacs (Bug#7030).
1328
13292011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1330
1331 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1332 (symbol_to_nsstring): Fix indentation.
1333 (ns_symbol_to_pb): New function.
1334 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1335 (Fns_rotate_cut_buffers_internal): Remove.
1336 (Fns_store_selection_internal): Rename from
1337 Fns_store_cut_buffer_internal.
1338 (ns_get_foreign_selection, Fx_own_selection_internal)
1339 (Fx_disown_selection_internal, Fx_selection_exists_p)
1340 (Fns_get_selection_internal, Fns_store_selection_internal):
1341 Use ns_symbol_to_pb and check if return value is nil.
1342 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1343 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1344 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1345 renamed to Sns_store_selection_internal.
1346 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1347 and remove this function.
1348 (ns_handle_selection_clear): Remove, never used.
1349 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1350 here.
1351
13522011-12-17 Ken Brown <kbrown@cornell.edu>
1353
1354 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1355 GID is unknown (Bug#10257).
1356
13572011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1360 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1361 which caused a build failure on GNU/Linux IA-64. This problem was
1362 introduced by my 2011-10-07 patch.
1363
13642011-12-15 Juri Linkov <juri@jurta.org>
1365
1366 * image.c (imagemagick_error): New function. (Bug#10112)
1367 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1368 Use `imagemagick_error' where ImageMagick functions return
1369 `MagickFalse'.
1370 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1371 proper order.
1372
13732011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1374
1375 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1376 fill background (Bug#8992).
1377
13782011-12-13 Martin Rudalics <rudalics@gmx.at>
1379
1380 * window.c (Vwindow_combination_resize)
1381 (Vwindow_combination_limit): Use t instead of non-nil in
1382 doc-strings.
1383 (Vrecenter_redisplay): Add first sentence of doc-string on
1384 separate line.
1385 (Frecenter): Fix doc-string typo.
1386
13872011-12-11 Kenichi Handa <handa@m17n.org>
1388
1389 * coding.c (Funencodable_char_position): Pay attention to the
1390 buffer text relocation (Bug#9389).
1391
13922011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1393
1394 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1395 gtk_init (Bug#10100).
1396
13972011-12-10 Eli Zaretskii <eliz@gnu.org>
1398
1399 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1400 IT->string is nil. (Bug#10263)
1401
14022011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1403
1404 * nsterm.h (x_free_frame_resources): Declare.
1405
1406 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1407 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1408
1409 * nsterm.h (ns_get_defaults_value): Declare.
1410
1411 * nsterm.m (ns_default): Call ns_get_defaults_value.
1412
14132011-12-09 Eli Zaretskii <eliz@gnu.org>
1414
1415 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1416 (Bug#10170)
1417
14182011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1419
1420 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1421 that where the value of an _OBJC_* symbol points to is in the .bss
1422 section (Bug#10240).
1423
14242011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1425
1426 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1427 after the loop to call ccl_driver at least once (Bug#8619).
1428
14292011-12-08 Kenichi Handa <handa@m17n.org>
1430
1431 * ftfont.c (get_adstyle_property): Fix previous change
1432 (Bug#10233).
1433
14342011-12-07 Juanma Barranquero <lekktu@gmail.com>
1435
1436 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1437 dirs from the default value of EMACSLOADPATH (bug#10208).
1438
14392011-12-07 Glenn Morris <rgm@gnu.org>
1440
1441 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1442 installation and source directories as well. (Bug#10208)
1443
14442011-12-06 Chong Yidong <cyd@gnu.org>
1445
1446 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1447
14482011-12-06 Glenn Morris <rgm@gnu.org>
1449
1450 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1451 as an error, not just -1. (Bug#10217)
1452
14532011-12-05 Chong Yidong <cyd@gnu.org>
1454
1455 * keyboard.c (process_special_events): New function.
1456 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1457
14582011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1459
1460 * coding.c (encode_designation_at_bol): Don't use uninitialized
1461 local variable (Bug#9318).
1462
14632011-12-05 Kenichi Handa <handa@m17n.org>
1464
1465 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1466 return Qnil (Bug#8046, Bug#10193).
1467
14682011-12-05 Kenichi Handa <handa@m17n.org>
1469
1470 * coding.c (encode_designation_at_bol): New args charbuf_end and
1471 dst. Return the number of produced bytes. Callers changed.
1472 (coding_set_source): Return how many bytes coding->source was
1473 relocated.
1474 (coding_set_destination): Return how many bytes
1475 coding->destination was relocated.
1476 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1477 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1478
14792011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1480
1481 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1482 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1483 macro (Bug#9318).
1484
14852011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1486
1487 The following changes are to fix Bug#9318.
1488
1489 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1490 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1491 (encode_coding_iso_2022, encode_coding_sjis)
1492 (encode_coding_big5, encode_coding_charset): Use the above macros.
1493
14942011-12-05 Juanma Barranquero <lekktu@gmail.com>
1495
1496 * lisp.h (process_quit_flag): Fix external declaration.
1497
14982011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1499
1500 Don't macro-inline non-performance-critical code.
1501 * eval.c (process_quit_flag): New function.
1502 * lisp.h (QUIT): Use it.
1503
15042011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1505
1506 * nsfns.m (get_geometry_from_preferences): New function.
1507 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1508
15092011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1510
1511 * emacs.c (Qkill_emacs): Define.
1512 (syms_of_emacs): Initialize it.
1513 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1514 Qquit_flag to `kill-emacs' instead.
1515 (quit_throw_to_read_char): Add parameter `from_signal'.
1516 All callers changed. Call Fkill_emacs if requested and safe.
1517 * lisp.h (QUIT): Call Fkill_emacs if requested.
1518
15192011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1520
1521 * widget.c (update_wm_hints): Return if wmshell is null.
1522 (widget_update_wm_size_hints): New function.
1523
1524 * widget.h (widget_update_wm_size_hints): Declare.
1525
1526 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1527 widget_update_wm_size_hints (Bug#10104).
1528
15292011-12-03 Eli Zaretskii <eliz@gnu.org>
1530
1531 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1532 before a newline, prepare the bidi iterator for consuming the
1533 newline, and keep the current paragraph direction. (Bug#10183)
1534 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1535
15362011-12-02 Juri Linkov <juri@jurta.org>
1537
1538 * search.c (Fword_search_regexp): New Lisp function created from
1539 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1540 (Fword_search_backward, Fword_search_forward)
1541 (Fword_search_backward_lax, Fword_search_forward_lax):
1542 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1543 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1544
15452011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1546
1547 * fileio.c (Finsert_file_contents): Move after-change-function call
1548 to before the "handled:" label, since all "goto handled" appear in
1549 cases where the *-change-functions have already been properly called
1550 (bug#10117).
1551
15522011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1553
1554 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1555 waiting for input. (Bug#10169)
1556
15572011-11-30 Eli Zaretskii <eliz@gnu.org>
1558
1559 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1560 verifies glyph row's hash code--we have just reallocated the
1561 glyphs, so their contents can be complete garbage. (Bug#10164)
1562
15632011-11-30 Juanma Barranquero <lekktu@gmail.com>
1564
1565 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1566
15672011-11-30 Eli Zaretskii <eliz@gnu.org>
1568
1569 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1570 attributes are tested _before_ calling verify_row_hash, to protect
1571 against GCC re-ordering of the tests. (Bug#10164)
1572
15732011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1574
1575 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1576
1577 * xterm.c (handle_one_xevent): Only set async_visible and friends
1578 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1579 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1580 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1581
15822011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1583
1584 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1585 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1586 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1587 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1588 All uses changed to use GCPRO1 etc.
1589 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1590 Revert to old implementation (i.e., before 2011-03-11).
1591
15922011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1593
1594 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1595 of scroll runs so as to avoid assigning disabled bogus rows and
1596 unnecessary graphics copy operations.
1597
15982011-11-27 Eli Zaretskii <eliz@gnu.org>
1599
1600 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1601 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1602 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1603 (malloc, free, realloc, calloc): Redirect to e_* only when
1604 compiling Emacs.
1605
1606 * lisp.h (GCTYPEBITS): Move before first use.
1607 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1608 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1609 this macro definition.
1610
1611 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1612 _MSC_VER.
1613
16142011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1615
1616 * gtkutil.c (xg_create_frame_widgets):
1617 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1618 present with Gtk+ 2.0.
1619
16202011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1621
1622 * fileio.c (Finsert_file_contents): Undo previous change; see
1623 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1624
16252011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1626
1627 Rename locals to avoid shadowing.
1628 * fileio.c (Finsert_file_contents):
1629 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1630 * process.c (wait_reading_process_output):
1631 Rename inner 'proc' to 'p' to avoid shadowing.
1632 Indent for consistency with usual Emacs style.
1633
16342011-11-25 Eli Zaretskii <eliz@gnu.org>
1635
1636 * xdisp.c (redisplay_window): If cursor row is not fully visible
1637 after recentering, and scroll-conservatively is set to a large
1638 number, scroll window by a few more lines to make the cursor fully
1639 visible and out of scroll-margin. (Bug#10105)
1640 (start_display): Don't move to the next line if the display should
1641 start at a newline that is part of a display vector or an overlay
1642 string. (Bug#10119)
1643
16442011-11-24 Juri Linkov <juri@jurta.org>
1645
1646 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1647 after the `MagickPingImage' call. (Bug#10112)
1648
16492011-11-23 Chong Yidong <cyd@gnu.org>
1650
1651 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1652
16532011-11-23 Martin Rudalics <rudalics@gmx.at>
1654
1655 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1656 making another buffer current. (Bug#10114)
1657
16582011-11-23 Glenn Morris <rgm@gnu.org>
1659
1660 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1661
16622011-11-23 Chong Yidong <cyd@gnu.org>
1663
1664 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1665 using it (Bug#5984).
1666
16672011-11-22 Eli Zaretskii <eliz@gnu.org>
1668
1669 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1670 and header-lines, as they don't have one computed for them.
1671 (Bug#10098)
1672
1673 * .gdbinit (prow): Make displayed values more self-explaining.
1674 Add row's hash code.
1675
16762011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1677
1678 * process.c (wait_reading_process_output): Fix asynchrounous
1679 GnuTLS socket handling on some versions of the GnuTLS library.
1680 (wait_reading_process_output): Add comment and URL.
1681
16822011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1683
1684 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1685
16862011-11-21 Chong Yidong <cyd@gnu.org>
1687
1688 * window.c (Fnext_window, Fprevious_window): Doc fix.
1689
16902011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1691
1692 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1693
16942011-11-20 Juanma Barranquero <lekktu@gmail.com>
1695
1696 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1697
16982011-11-20 Martin Rudalics <rudalics@gmx.at>
1699
1700 * window.c (Fset_window_combination_limit): Rename argument
1701 STATUS to LIMIT.
1702 (Vwindow_combination_limit): Remove "status" from doc-string.
1703
17042011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1705
1706 * m/ibms390.h: Remove.
1707 * m/ibms390x.h: Don't include "ibms390.h".
1708
17092011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1710
1711 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1712 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1713
17142011-11-20 Juanma Barranquero <lekktu@gmail.com>
1715
1716 * casetab.c (Fset_case_table):
1717 * charset.c (Fcharset_after): Fix typos.
1718
17192011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1720
1721 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1722 Otherwise, valgrind does not work on some platforms.
1723 Problem reported by Andreas Schwab in
1724 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1725 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1726 is set, removing the need for VIRT_ADDRESS_VARIES.
1727 (PURE_P): Use a more-efficient implementation that needs just one
1728 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1729 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1730 to 4 (xorl, subq, cmpq, setbe).
1731 * alloc.c (pure): Always extern now, since that's the
1732 VIRT_ADDR_VARIES behavior.
1733 (PURE_POINTER_P): Use a single comparison, not two, for
1734 consistency with the new puresize.h.
1735 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1736 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1737 Remove VIRT_ADDR_VARIES no longer needed.
1738
17392011-11-19 Eli Zaretskii <eliz@gnu.org>
1740
1741 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1742 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1743 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1744 behave as if the cursor position were at the window margin.
1745
1746 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1747 and the cursor position is out of bounds, behave as if the cursor
1748 position were at the window margin. (Bug#10075)
1749
17502011-11-18 Chong Yidong <cyd@gnu.org>
1751
1752 * window.c (Fwindow_combination_limit): Make first argument
1753 non-optional, since it is meaningless for live windows like the
1754 selected window.
1755
17562011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1757
1758 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1759
17602011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1761
1762 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1763 (graft_intervals_into_buffer): Simplify.
1764
17652011-11-18 Eli Zaretskii <eliz@gnu.org>
1766
1767 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1768 hash values of the two rows.
1769 (copy_row_except_pointers): Preserve the used[] arrays and the
1770 hash values of the two rows. (Bug#10035)
1771 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1772
1773 * xdisp.c (row_hash): New function, body extracted from
1774 compute_line_metrics.
1775 (compute_line_metrics): Call row_hash, instead of computing the
1776 hash code inline.
1777
1778 * dispnew.c (verify_row_hash): Call row_hash for computing the
1779 hash code of a row, instead of duplicating code from xdisp.c.
1780
1781 * dispextern.h (row_hash): Add prototype.
1782
17832011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1784
1785 * frame.c (delete_frame): Don't delete the terminal when the last
1786 X frame is closed if emacs is built with GTK toolkit.
1787
17882011-11-17 Juanma Barranquero <lekktu@gmail.com>
1789
1790 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1791
17922011-11-17 Martin Rudalics <rudalics@gmx.at>
1793
1794 * window.c (Vwindow_splits): Rename to
1795 Vwindow_combination_resize. Suggested by Juri Linkov.
1796 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1797 of Vwindow_splits.
1798
17992011-11-16 Juanma Barranquero <lekktu@gmail.com>
1800
1801 * nsfns.m (Fns_font_name):
1802 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1803
18042011-11-16 Martin Rudalics <rudalics@gmx.at>
1805
1806 * window.h (window): Rename slot "nest" to "combination_limit".
1807 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1808 (Fset_window_nest): Rename to Fset_window_combination_limit.
1809 (Vwindow_nest): Rename to Vwindow_combination_limit.
1810 (recombine_windows, make_parent_window, make_window)
1811 (Fsplit_window_internal, saved_window)
1812 (Fset_window_configuration, save_window_save): Rename all
1813 occurrences of window_nest to window_combination_limit.
1814
18152011-11-15 Juanma Barranquero <lekktu@gmail.com>
1816
1817 * image.c (imagemagick_load_image): Fix typo.
1818
18192011-11-14 Eli Zaretskii <eliz@gnu.org>
1820
1821 * xdisp.c (display_line): Move the call to
1822 highlight_trailing_whitespace before the call to
1823 compute_line_metrics, since the latter needs to see the final
1824 faces of all the glyphs to compute ROW's hash value.
1825 Fixes assertion violations in row_equal_p. (Bug#10035)
1826
18272011-11-14 Juanma Barranquero <lekktu@gmail.com>
1828
1829 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1830 just return (bug#10044).
1831
18322011-11-12 Eli Zaretskii <eliz@gnu.org>
1833
1834 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1835 with user-defined heap size. Bump the default size of the temacs
1836 heap to 27MB, to avoid memory warning when running temacs.
1837 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1838
1839 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1840 current_matrix and desired_matrix. (Bug#9990)
1841 (verify_row_hash) [XASSERTS]: New function.
1842 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1843 that the hash value of glyph rows is correct.
1844
18452011-11-12 Martin Rudalics <rudalics@gmx.at>
1846
1847 * window.h (window): Remove splits slot.
1848 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1849 (Fdelete_other_windows_internal, make_parent_window)
1850 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1851 (Fset_window_configuration, save_window_save): Don't deal with
1852 split status of windows.
1853 (saved_window): Remove splits slot.
1854 (Vwindow_splits): Rewrite doc-string.
1855
18562011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1857
1858 * xfns.c (unwind_create_frame):
1859 * nsfns.m (unwind_create_frame):
1860 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1861 Vframe_list (Bug#9999).
1862
18632011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1864
1865 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1866
18672011-11-11 Kenichi Handa <handa@m17n.org>
1868
1869 * callproc.c (Fcall_process): Set the member dst_multibyte of
1870 process_coding.
1871
18722011-11-11 Johan Bockgård <bojohan@gnu.org>
1873
1874 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1875 avoid a crash (bug#9496).
1876
18772011-11-09 Chong Yidong <cyd@gnu.org>
1878
1879 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1880 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1881
18822011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1883
1884 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1885
18862011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1887
1888 Avoid some portability problems by eschewing 'extern inline' functions.
1889 The trivial performance wins aren't worth the portability hassles; see
1890 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1891 et seq.
1892 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1893 (window_box_width, window_box_left, window_box_left_offset)
1894 (window_box_right, window_box_right_offset): Undo previous change,
1895 by removing the "extern"s.
1896 * intervals.c (adjust_intervals_for_insertion)
1897 (adjust_intervals_for_deletion): Undo previous change,
1898 making these static again.
1899 (offset_intervals, temp_set_point_both, temp_set_point)
1900 (copy_intervals_to_string): No longer inline.
1901 * xdisp.c (window_text_bottom_y, window_box_width)
1902 (window_box_height, window_box_left_offset)
1903 (window_box_right_offset, window_box_left, window_box_right)
1904 (window_box): No longer inline.
1905
19062011-11-08 Chong Yidong <cyd@gnu.org>
1907
1908 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1909 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1910 Signal an error if not a live window.
1911 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1912 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1913
19142011-11-07 Juanma Barranquero <lekktu@gmail.com>
1915
1916 * lisp.h (syms_of_abbrev): Remove declaration.
1917 Reported by CHENG Gao <chenggao@royau.me>.
1918
19192011-11-07 Eli Zaretskii <eliz@gnu.org>
1920
1921 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1922 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1923 of temacs in GUI mode.
1924
19252011-11-07 Martin Rudalics <rudalics@gmx.at>
1926
1927 * window.h: Declare delete_all_child_windows instead of
1928 delete_all_subwindows.
1929 * window.c (Fwindow_nest, Fset_window_nest)
1930 (Fset_window_new_total, Fset_window_new_normal)
1931 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1932 (delete_all_subwindows): Rename to delete_all_child_windows.
1933 (Fdelete_other_windows_internal, Fset_window_configuration):
1934 Call delete_all_child_windows instead of delete_all_subwindows.
1935 * frame.c (delete_frame): Call delete_all_child_windows instead
1936 of delete_all_subwindows.
1937
19382011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1939
1940 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1941 This is also needed for porting to any host where GC_MARK_STACK is
1942 not GC_MAKE_GCPROS_NOOPS.
1943 (which_symbols): Use it.
1944
19452011-11-07 Kenichi Handa <handa@m17n.org>
1946
1947 * coding.c (coding_set_destination): Check coding->src_pos only
1948 when coding->src_object is a buffer (bug#9910).
1949
1950 * process.c (send_process): Set the member src_multibyte of coding
1951 to 0 (bug#9911) when sending a unibyte text.
1952
1953 * callproc.c (Fcall_process): Set the member src_multibyte of
1954 process_coding to 0 (bug#9912).
1955
19562011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1957
1958 * xmenu.c (cleanup_widget_value_tree): New function.
1959 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1960 calling free_menubar_widget_value_tree directly (Bug#9830).
1961
19622011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1963
1964 Fix some portability problems with 'inline'.
1965 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1966 (window_box_width, window_box_left, window_box_left_offset)
1967 (window_box_right, window_box_right_offset): Declare extern.
1968 Otherwise, these inline functions do not conform to C99 and
1969 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1970 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1971 * intervals.c (adjust_intervals_for_insertion)
1972 (adjust_intervals_for_deletion): Now extern, because otherwise the
1973 extern inline functions 'offset_intervals' couldn't refer to it.
1974 (static_offset_intervals): Remove.
1975 (offset_intervals): Rewrite using the old contents of
1976 static_offset_intervals. The old version didn't conform to C99
1977 because an extern inline function contained a reference to an
1978 identifier with static linkage.
1979
19802011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1981
1982 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1983 GC.
1984
19852011-11-06 Eli Zaretskii <eliz@gnu.org>
1986
1987 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1988 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1989 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1990 return Qleft_to_right.
1991
19922011-11-06 Chong Yidong <cyd@gnu.org>
1993
1994 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1995 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1996 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1997 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1998 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1999 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2000 (Fwindow_vscroll): Doc fix.
2001 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2002 argument, since it makes no sense to pass a live window and for
2003 consistency with window-child.
2004
20052011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2006
2007 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2008 support MSVC.
2009
20102011-11-05 Jason Rumney <jasonr@gnu.org>
2011
2012 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2013 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2014 fonts (Bug#6029).
2015 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2016 bitwise arithmetic preventing use of unicode-sip and non-truetype
2017 opentype fonts.
2018
20192011-11-05 Eli Zaretskii <eliz@gnu.org>
2020
2021 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2022 "emacs"-only part.
2023
2024 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2025 initialization code to keep similarity to xfns.c after changes
2026 from 2011-11-05.
2027
20282011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2029
2030 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2031 (unwind_create_frame): New function (Bug#9943).
2032 (Fx_create_frame): Restructure code to be more similar to the one in
2033 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2034 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2035 Move terminal->reference_count++ just before making the frame official
2036 (Bug#9943).
2037
2038 * nsterm.m (x_free_frame_resources): New function.
2039 (x_destroy_window): Move code to x_free_frame_resources.
2040
2041 * xfns.c (unwind_create_frame): Fix comment.
2042 (Fx_create_frame, x_create_tip_frame):
2043 Move terminal->reference_count++ just before making the frame
2044 official. Move initialization of image_cache_refcount and
2045 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2046
20472011-11-05 Eli Zaretskii <eliz@gnu.org>
2048
2049 Support MSVC build with newer versions of Visual Studio.
2050 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2051 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2052 nt/gmake.defs.
2053
2054 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2055 which are not supported by MSVC.
2056 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2057 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2058 bitfields.
2059 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2060 types in bitfields.
2061 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2062
2063 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2064
20652011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2066
2067 Support MSVC build with newer versions of Visual Studio.
2068 * w32.c: Don't include w32api.h for MSVC.
2069 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2070
2071 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2072 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2073 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2074 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2075 e_* cousins.
2076 (alloca) [_MSC_VER]: Define to _alloca.
2077
2078 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2079
2080 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2081
20822011-11-04 Eli Zaretskii <eliz@gnu.org>
2083
2084 * xdisp.c (note_mouse_highlight): If either of
2085 previous/next-single-property-change returns nil, treat that as
2086 the beginning or the end of the buffer. (Bug#9955)
2087
20882011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2089
2090 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2091 label is not null (Bug#9951).
2092 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2093 may be NULL.
2094
20952011-11-04 Eli Zaretskii <eliz@gnu.org>
2096
2097 * window.c (Fwindow_body_size): Mention in the doc string that the
2098 return value is in frame's canonical units. (Bug#9949)
2099
21002011-11-03 Eli Zaretskii <eliz@gnu.org>
2101
2102 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2103
2104 * w32fns.c (unwind_create_frame): If needed, free the glyph
2105 matrices of the partially constructed frame. (Bug#9943)
2106 * xfns.c (unwind_create_frame): Likewise.
2107
21082011-11-01 Eli Zaretskii <eliz@gnu.org>
2109
2110 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2111 Don't stop backward scan on the continuation glyph, even though
2112 its CHARPOS is positive.
2113 (mouse_face_from_buffer_pos, note_mouse_highlight):
2114 Rename cover_string to disp_string.
2115
21162011-11-01 Martin Rudalics <rudalics@gmx.at>
2117
2118 * window.c (temp_output_buffer_show): Don't use
2119 Vtemp_buffer_show_specifiers.
2120 (Vtemp_buffer_show_specifiers): Remove unused variable.
2121
21222011-10-30 Eli Zaretskii <eliz@gnu.org>
2123
2124 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2125 past the beginning of the current glyph matrix.
2126
21272011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2128
2129 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2130 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2131 HAVE_GTK3 (Bug#9869).
2132
2133 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2134 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2135
2136 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2137
2138 * xterm.c: Declare x_handle_net_wm_state to return int.
2139 (handle_one_xevent): Check if we are iconified but don't have
2140 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2141 (get_current_wm_state): Return non-zero if not hidden,
2142 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2143 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2144 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2145 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2146
21472011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2148
2149 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2150 so that this new function doesn't get optimized away by a
2151 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2152
21532011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2154
2155 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2156
21572011-10-29 Eli Zaretskii <eliz@gnu.org>
2158
2159 Fix the `xbytecode' command.
2160 * .gdbinit (xprintbytestr): New command.
2161 (xwhichsymbols): Rename from `which'; all callers changed.
2162 (xbytecode): Print the byte-code string as well.
2163
21642011-10-29 Kim Storm <storm@cua.dk>
2165
2166 * alloc.c (which_symbols): New function.
2167
21682011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2169
2170 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2171 line. (Bug#9903)
2172
21732011-10-29 Glenn Morris <rgm@gnu.org>
2174
2175 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2176 Not clear what it was for, and it causes various bugs. (Bug#9839)
2177
21782011-10-28 Eli Zaretskii <eliz@gnu.org>
2179
2180 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2181 possible random value that matches one of those tested as
2182 condition to clear the mouse face.
2183
21842011-10-28 Chong Yidong <cyd@gnu.org>
2185
2186 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2187
21882011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2189
2190 * window.c (make_window): Initialize phys_cursor_on_p.
2191
21922011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2193
2194 * lisp.h (struct Lisp_Symbol): Update comments.
2195
21962011-10-28 Juanma Barranquero <lekktu@gmail.com>
2197
2198 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2199
22002011-10-28 Eli Zaretskii <eliz@gnu.org>
2201
2202 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2203 <oslsachem@gmail.com> for helping to debug this.
2204
2205 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2206 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2207 (g_b_init_get_glyph_outline_w): New static variables.
2208 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2209 (GetGlyphOutlineW_Proc): New typedefs.
2210 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2211 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2212 New functions.
2213 (w32font_open_internal, compute_metrics):
2214 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2215 instead of calling the "wide" APIs directly.
2216
2217 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2218
2219 * w32.h (syms_of_w32font): Add prototype.
2220
22212011-10-27 Juanma Barranquero <lekktu@gmail.com>
2222
2223 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2224 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2225 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2226 (Fmove_to_window_line): Doc fix.
2227
22282011-10-27 Chong Yidong <cyd@gnu.org>
2229
2230 * process.c (make_process): Set gnutls_state to NULL.
2231
2232 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2233 non-NULL, regardless of GNUTLS_INITSTAGE.
2234 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2235 an error. Set process slots as soon as we allocate them.
2236
2237 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2238
22392011-10-27 Chong Yidong <cyd@gnu.org>
2240
2241 * gnutls.c (emacs_gnutls_deinit): New function.
2242 Deallocate credentials structures as well as calling gnutls_deinit.
2243 (Fgnutls_deinit, Fgnutls_boot): Use it.
2244
2245 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2246 (deactivate_process): Call emacs_gnutls_deinit.
2247
22482011-10-27 Juanma Barranquero <lekktu@gmail.com>
2249
2250 * image.c (x_create_x_image_and_pixmap):
2251 * w32.c (sys_rename, w32_delayed_load):
2252 * w32font.c (fill_in_logfont):
2253 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2254
22552011-10-26 Juanma Barranquero <lekktu@gmail.com>
2256
2257 * w32fns.c (w32_default_color_map): New function,
2258 extracted from Fw32_default_color_map.
2259 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2260
22612011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2262
2263 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2264
22652011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2266
2267 * keyboard.c (test_undefined): New function (bug#9751).
2268 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2269
22702011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2271
2272 * sysdep.c (init_sys_modes): Fix the check for the controlling
2273 terminal (Bug#6649).
2274
22752011-10-20 Eli Zaretskii <eliz@gnu.org>
2276
2277 * dispextern.h (struct bidi_it): New member next_en_type.
2278
2279 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2280 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2281 current character, check also for next_en_type being WEAK_EN.
2282 (bidi_resolve_weak): Don't enter the expensive loop if the current
2283 position is before next_en_pos. Record the bidi type of the first
2284 non-ET, non-BN character we find, in addition to its position.
2285 (bidi_level_of_next_char): Invalidate next_en_type when
2286 next_en_pos is over-stepped.
2287
22882011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2289
2290 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2291 * editfns.c: Rewrite current-time-zone so that it invokes
2292 the equivalent of (format-time-string "%Z") to get the time zone name.
2293 This fixes a bug when the time zone name contains characters that
2294 need converting from the system time locale to Emacs internal format.
2295 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2296 that patch fixed format-time-string to do the conversion, but
2297 I forgot to fix current-time-zone.
2298 (format_time_string): New function, containing most of
2299 what Fformat_time_string used to contain.
2300 (Fformat_time_string): Rewrite in terms of format_time_string.
2301 This doesn't change this function's behavior.
2302 (current-time-zone): Rewrite to use format_time_string.
2303 This fixes the bug reported by Michael Schierl in
2304 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2305 Jason Rumney's 2007-06-07 change worked around this bug, but
2306 didn't fix it.
2307 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2308
23092011-10-19 Eli Zaretskii <eliz@gnu.org>
2310
2311 * xdisp.c (start_display): If the character at POS is displayed
2312 via a display vector, reset IT->current.dpvec_index to zero.
2313 (try_window_reusing_current_matrix): If a line ends in a display
2314 vector or the next line starts in a display vector, continue
2315 redrawing the window even though the character position of
2316 start_row was reached.
2317 (Bug#9771, part 2)
2318
23192011-10-18 Chong Yidong <cyd@gnu.org>
2320
2321 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2322 with nobreak-char-display too.
2323
23242011-10-18 Eli Zaretskii <eliz@gnu.org>
2325
2326 Fix part 3 of bug#9771.
2327 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2328 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2329 non-neutral characters if the current character is a paragraph
2330 separator (a.k.a. Newline). This avoids running the same
2331 expensive loop twice, once when we consume the preceding newline
2332 and the other time when the line actually needs to be displayed.
2333 Avoid the loop when we see neutrals on the base embedding level
2334 following a character whose directionality is the same as the
2335 paragraph's. This avoids running the expensive loop when a line
2336 ends in a long sequence of neutrals, like control characters.
2337 Add assertion against STRONG_AL type. Slightly rearrange code
2338 that determines the type of a neutral given the first non-neutral
2339 that follows it.
2340 (bidi_level_of_next_char): Set next_en_pos to zero when
2341 invalidating its info.
2342
23432011-10-17 Eli Zaretskii <eliz@gnu.org>
2344
2345 * xdisp.c (push_display_prop): Determine whether to record string
2346 or buffer position by IT->string, not by IT->method. Allow
2347 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2348 (move_it_vertically_backward): Don't look for character position
2349 immediately after the newline when in a continuation line.
2350 (Bug#9771, part 1)
2351
23522011-10-15 Martin Rudalics <rudalics@gmx.at>
2353
2354 * window.c (coordinates_in_window): Rewrite and delabelize
2355 vertical border check. (Bug#5357) (Bug#9618)
2356
23572011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2358
2359 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2360 errors in XSetWindowBorder (bug#9310).
2361
23622011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2363
2364 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2365 avoid crash when xmalloc overrun checking is enabled.
2366
23672011-10-13 Eli Zaretskii <eliz@gnu.org>
2368
2369 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2370 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2371 cursor motion with <left> and <right> arrow keys.
2372
2373 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2374 some callers set that themselves.
2375
23762011-10-12 Eli Zaretskii <eliz@gnu.org>
2377
2378 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2379 display string and the previous row comes from the same string and
2380 is empty. (Bug#9739) (Bug#9738)
2381
23822011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2383
2384 * doc.c (get_doc_string): Encode file name (bug#9735).
2385
23862011-10-12 Eli Zaretskii <eliz@gnu.org>
2387
2388 * bidi.c (bidi_level_of_next_char):
2389 * xdisp.c (get_visually_first_element): Remove old incorrect
2390 comments regarding the Unicode Line Separator character.
2391
2392 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2393
23942011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2395
2396 * alloc.c (Fgc_status): Do not access beyond zombies array
2397 boundary if nzombies > MAX_ZOMBIES.
2398 * alloc.c (dump_zombies): Add missing format specifier.
2399
24002011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2401
2402 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2403 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2404
2405 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2406 Some packages use them to denote characters with modifiers.
2407
24082011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2409
2410 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2411 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2412 matching a pp-number. Rename parameter var to var1.
2413
24142011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2415
2416 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2417
24182011-10-08 Glenn Morris <rgm@gnu.org>
2419
2420 * callint.c (Fcall_interactively): Give a more explicit error for the
2421 'c' case with a non-character input. (Bug#8479)
2422
24232011-10-08 Eli Zaretskii <eliz@gnu.org>
2424
2425 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2426 lines.
2427 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2428 lines that are hscrolled on the left.
2429
2430 * dispnew.c (buffer_posn_from_coords): Account for a possible
2431 presence of header-line. (Bug#4426)
2432
24332011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2434
2435 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2436 Don't advertise functionality which we discourage or doesn't work.
2437
24382011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2439
2440 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2441 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2442 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2443 this makes Emacs dump core during garbage collection on rare
2444 occasions. sizeof is obviously inferior to offsetof here, so
2445 stick with offsetof.
2446 (GC_POINTER_ALIGNMENT): New macro.
2447 (mark_memory): Omit 3rd (offset) arg; caller changed.
2448 Don't assume EMACS_INT alignment is the same as pointer alignment.
2449
24502011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2451
2452 * keyboard.c (read_key_sequence_remapped): New var.
2453 (read_key_sequence): Compute remapping in the right buffer.
2454 (command_loop_1): Use read_key_sequence's remapping directly.
2455
24562011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2457
2458 * dired.c (file_name_completion): Don't expand file name.
2459 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2460 before checking file name handler.
2461
2462 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2463 they've been requested explicitly (bug#9591).
2464
24652011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2466
2467 * keymap.c (Fsingle_key_description): Use make_specified_string
2468 instead of build_string to build string from push_key_description.
2469 (Bug#5193)
2470
24712011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2472
2473 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2474 This fixes a Y2038 bug on 64-bit hosts.
2475 * buffer.c (reset_buffer):
2476 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2477 (Fclear_buffer_auto_save_failure):
2478 Use 0, not -1, to represent an unset failure time, since time_t
2479 might not be signed.
2480
2481 Remove dependency on glibc malloc internals.
2482 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2483 Move back here from lisp.h, but with their new implementations.
2484 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2485 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2486 * charset.c (charset_table_init): New static var.
2487 (syms_of_charset): Use it instead of xmalloc. This removes a
2488 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2489 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2490 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2491 Move back to alloc.c.
2492 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2493 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2494
24952011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2496
2497 * nsterm.m (windowDidResize): Call x_set_window_size only when
2498 ns_in_resize is true. Otherwise set pixelwidth/height and
2499 call change_frame_size (Bug#9628).
2500
25012011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 Port --enable-checking=all to Fedora 14 x86-64.
2504 * charset.c (syms_of_charset): Also account for glibc malloc's
2505 internal overhead when calculating the initial malloc maximum.
2506
2507 Port --enable-checking=all to Fedora 14 x86.
2508 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2509 Move to lisp.h.
2510 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2511 (overrun_check_realloc, overrun_check_free):
2512 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2513 That way, xmalloc returns a properly-aligned pointer even if
2514 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2515 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2516 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2517 into account when calculating the initial malloc maximum.
2518 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2519 Move here from alloc.c, so that charset.c can use it too.
2520 Properly align; the old code wasn't right for common 32-bit hosts
2521 when configured with --enable-checking=all.
2522 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2523 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2524
25252011-09-29 Eli Zaretskii <eliz@gnu.org>
2526
2527 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2528 use EDOM.
2529
25302011-09-28 Eli Zaretskii <eliz@gnu.org>
2531
2532 * xdisp.c (compute_display_string_end): If there's no display
2533 string at CHARPOS, return -1.
2534
2535 * bidi.c (bidi_fetch_char): When compute_display_string_end
2536 returns a negative value, treat the character as a normal
2537 character not covered by a display string. (Bug#9624)
2538
25392011-09-28 Juanma Barranquero <lekktu@gmail.com>
2540
2541 * lread.c (Fread_from_string): Fix typo in docstring.
2542
25432011-09-27 Eli Zaretskii <eliz@gnu.org>
2544
2545 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2546 newline, reseat the iterator instead of bidi-iterating there one
2547 character at a time. (Bug#9610)
2548 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2549 TO_CHARPOS if the bidi iterator is at base embedding level.
2550
25512011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2552
2553 * lread.c (readevalloop): Use correct code for NBSP.
2554 (read1): Likewise. (Bug#9608)
2555
25562011-09-25 Michael Albinus <michael.albinus@gmx.de>
2557
2558 * dbusbind.c (Fdbus_register_signal): When service is not
2559 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2560
25612011-09-25 Glenn Morris <rgm@gnu.org>
2562
2563 * buffer.c (truncate-lines): Doc fix.
2564
25652011-09-24 Chong Yidong <cyd@stupidchicken.com>
2566
2567 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2568 (Fset_window_next_buffers): Doc fix.
2569
25702011-09-24 Glenn Morris <rgm@gnu.org>
2571
2572 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2573
25742011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 Fix minor problems found by static checking.
2577 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2578 * indent.c (Fvertical_motion): Fix == vs = typo.
2579
25802011-09-24 Eli Zaretskii <eliz@gnu.org>
2581
2582 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2583 Default value is now t. Doc fix.
2584
2585 * indent.c (Fvertical_motion): Compute and apply the overshoot
2586 logic when moving up, not only when moving down. Fix the
2587 confusing name and values of the it_overshoot_expected variable;
2588 logic changes accordingly. (Bug#9254) (Bug#9549)
2589
2590 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2591 CHARPOS is covered by a display string which includes newlines.
2592 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2593 is covered by a display string with embedded newlines.
2594
25952011-09-24 Michael Albinus <michael.albinus@gmx.de>
2596
2597 * dbusbind.c (Fdbus_register_signal): Add match rule to
2598 Vdbus_registered_objects_table. (Bug#9581)
2599 (Fdbus_register_method, Vdbus_registered_objects_table):
2600 Fix docstring.
2601
26022011-09-24 Jim Meyering <meyering@redhat.com>
2603
2604 do not ignore write error for any output size
2605 The previous change was incomplete.
2606 While it makes emacs --batch detect the vast majority of stdout
2607 write failures, errors were still ignored whenever the output size is
2608 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2609 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2610 && echo FAIL: ignored write error
2611 FAIL: ignored write error
2612 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2613 && echo FAIL: ignored write error
2614 FAIL: ignored write error
2615 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2616
26172011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2618
2619 * emacs.c (Fkill_emacs): In noninteractive mode exit
2620 non-successfully if a write error occurred on stdout. (Bug#9574)
2621
26222011-09-21 Eli Zaretskii <eliz@gnu.org>
2623
2624 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2625 the xassert test.
2626
2627 * dispextern.h (struct it): Update the comment documenting what
2628 can it->OBJECT be.
2629
26302011-09-20 Eli Zaretskii <eliz@gnu.org>
2631
2632 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2633 a display string, extend search for cursor position to end of row.
2634 (find_row_edges): If the row ends in a newline from a display
2635 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2636 Handle the case of a display string with multiple newlines.
2637 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2638 non-empty line. Fixes confusing cursor motion with arrow keys at
2639 the beginning of a line that starts with whitespace.
2640
26412011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2642
2643 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2644 (bug#9493).
2645
26462011-09-18 Chong Yidong <cyd@stupidchicken.com>
2647
2648 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2649 boolean (Bug#9154).
2650
26512011-09-18 Eli Zaretskii <eliz@gnu.org>
2652
2653 * xdisp.c (display_line): Record maximum and minimum buffer
2654 positions even if no glyphs were produced (e.g., by a zero-width
2655 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2656 buffer positions that will be removed from the glyph row because
2657 they don't fit.
2658 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2659 column is beyond frame width: don't subtract 1 "pixel" when
2660 computing width of the stretch.
2661 (reseat_at_next_visible_line_start): Undo the change made on
2662 2011-09-17 that saved paragraph information and restored it after
2663 the call to `reseat'. (Bug#9545)
2664
26652011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2666
2667 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2668 and turn window cursor on if cleared (Bug#9415).
2669
26702011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2671
2672 * search.c (boyer_moore): Take unibyte characters from pattern
2673 literally. (Bug#9458)
2674
26752011-09-18 Eli Zaretskii <eliz@gnu.org>
2676
2677 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2678
26792011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 Fix minor problem found by static checking.
2682 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2683 initialized, to pacify gcc -Wuninitialized.
2684
2685 * fileio.c: Report proper errno when syscall falls.
2686 (Finsert_file_contents): Save and restore errno,
2687 so that report_file_error outputs the correct diagnostic.
2688 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2689
26902011-09-18 Eli Zaretskii <eliz@gnu.org>
2691
2692 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2693
26942011-09-17 Eli Zaretskii <eliz@gnu.org>
2695
2696 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2697 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2698
26992011-09-17 Eli Zaretskii <eliz@gnu.org>
2700
2701 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2702 about the current paragraph and restore it after the call to reseat.
2703
2704 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2705 (bidi_find_paragraph_start): Search back for paragraph beginning
2706 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2707 (bidi_move_to_visually_next): Only trigger paragraph-related
2708 computations when the last character is a newline or at EOB, not
2709 just any NEUTRAL_B. (Bug#9470)
2710
2711 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2712 truncated lines if point is covered by a display string. (Bug#9524)
2713
27142011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2715
2716 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2717 (cons_to_x_long): New function.
2718 (lisp_data_to_selection_data): Use it. Correct the test for
2719 short-versus-long data; it was negated. Break out of vector
2720 loop, for efficiency, when a long datum is discovered.
2721
27222011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2723
2724 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2725
27262011-09-16 Eli Zaretskii <eliz@gnu.org>
2727
2728 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2729 GCC PR/17406) by declaring this function with external scope.
2730
27312011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2732
2733 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2734 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2735
27362011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2737
2738 * editfns.c (Fformat): Correctly handle text properties on "%%".
2739
27402011-09-15 Eli Zaretskii <eliz@gnu.org>
2741
2742 * xterm.c (x_draw_composite_glyph_string_foreground):
2743 * w32term.c (x_draw_composite_glyph_string_foreground):
2744 * term.c (encode_terminal_code):
2745 * composite.c (composition_update_it, get_composition_id):
2746 * xdisp.c (get_next_display_element)
2747 (fill_composite_glyph_string): Add comments about special meaning
2748 of TAB characters in a composition.
2749
27502011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2751
2752 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2753 This occurs when processing a multibyte format.
2754 Problem reported by Wolfgang Jenker.
2755
27562011-09-15 Johan Bockgård <bojohan@gnu.org>
2757
2758 * xdisp.c (try_cursor_movement): Only check for exact match if
2759 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2760
27612011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2762
2763 Remove unused external symbols.
2764 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2765 * xdisp.c (calc_pixel_width_or_height): Now static.
2766 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2767 * indent.c (check_display_width):
2768 * w32term.c: Fix comment to match code.
2769 * xterm.c, xterm.h (x_catching_errors): Remove.
2770
27712011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2772
2773 * xselect.c: Use signed conversions more consistently (Bug#9498).
2774 (selection_data_to_lisp_data): Assume incoming selection data are
2775 signed integers, not unsigned. This is to be consistent with
2776 outgoing selection data, which was modified to use signed integers
2777 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2778 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2779 expects long, not unsigned long.
2780
27812011-09-14 Eli Zaretskii <eliz@gnu.org>
2782
2783 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2784 computation of loop end. Reported by Johan Bockgård
2785 <bojohan@gnu.org>.
2786
27872011-09-13 Chong Yidong <cyd@stupidchicken.com>
2788
2789 * frame.c (Fother_visible_frames_p): Function deleted.
2790
27912011-09-12 Eli Zaretskii <eliz@gnu.org>
2792
2793 * indent.c (compute_motion): Process display vector front to back
2794 rather than the other way around. (Bug#2496)
2795
27962011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2797
2798 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2799
28002011-09-11 Chong Yidong <cyd@stupidchicken.com>
2801
2802 * minibuf.c (Fread_from_minibuffer): Doc fix.
2803
28042011-09-11 Eli Zaretskii <eliz@gnu.org>
2805
2806 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2807 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2808
28092011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2810
2811 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2812 value for non-existent files.
2813
28142011-09-11 Eli Zaretskii <eliz@gnu.org>
2815
2816 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2817 set its "size" to -1. This will set the modtime_size field of
2818 the corresponding buffer to -1, which is what
2819 verify-visited-file-modtime expects for files that do not exist.
2820 (Bug#9139)
2821
28222011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2823
2824 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2825 here ...
2826 * lisp.h: ... from here. push_key_description is no longer
2827 defined in keyboard.c, so its declaration should not be in
2828 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2829 logically belongs with push_key_description.
2830
28312011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2832
2833 * buffer.h: Include <sys/types.h> instead of <time.h>.
2834 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2835 Problem reported by Herbert J. Skuhra.
2836
28372011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2838
2839 * xml.c (parse_region): Make the parsing work for
2840 non-comment-starting XML files again (bug#9144).
2841
28422011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2843
2844 * image.c (gif_load): Fix calculation of bottom and right corner.
2845 (Bug#9468)
2846
28472011-09-10 Eli Zaretskii <eliz@gnu.org>
2848
2849 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2850 redisplay in small windows.
2851
28522011-09-09 Eli Zaretskii <eliz@gnu.org>
2853
2854 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2855
28562011-09-08 Martin Rudalics <rudalics@gmx.at>
2857
2858 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2859 Operate on live windows only.
2860
28612011-09-08 Juanma Barranquero <lekktu@gmail.com>
2862
2863 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2864
28652011-09-07 Eli Zaretskii <eliz@gnu.org>
2866
2867 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2868 only under bidi iteration.
2869
28702011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2871
2872 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2873
28742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2875
2876 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2877 Without this fix, the command to link temacs failed due to an
2878 undefined symbol __builtin_isnan. This is because
2879 /usr/include/iso/math_c99.h #defines isnan(x) to
2880 __builtin_isnan(x), but the bundled gcc, which identifies itself
2881 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2882 a __builtin_isnan.
2883 * floatfns.c (isnan): #undef, and then #define to a clone of
2884 what's in data.c.
2885 (Fisnan): Always define, since it's always available now.
2886 (syms_of_floatfns): Always define isnan at the Lisp level.
2887
28882011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2889
2890 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2891
28922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2895 The previous code assumed that file offsets (off_t values) fit in
2896 EMACS_INT variables, which is not true on typical 32-bit hosts.
2897 The code messed up by falsely reporting buffer overflow in cases
2898 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2899 when "big" contains more than 2**29 bytes, even though this
2900 inserts just one byte and does not overflow the buffer.
2901 (Finsert_file_contents): Store file offsets as off_t
2902 values, not as EMACS_INT values. Check for overflow when
2903 converting between EMACS_INT and off_t. When checking for
2904 buffer overflow or for overlap, take the offsets into account.
2905 Don't use EMACS_INT for small values where int suffices.
2906 When checking for overlap, fix a typo: ZV was used where
2907 ZV_BYTE was intended.
2908 (Fwrite_region): Don't assume off_t fits into 'long'.
2909 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2910
29112011-09-05 Michael Albinus <michael.albinus@gmx.de>
2912
2913 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2914
29152011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2916
2917 sprintf-related integer and memory overflow issues (Bug#9412).
2918
2919 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2920 (esprintf, exprintf, evxprintf): New functions.
2921 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2922 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2923 (modify_event_symbol): Do not assume that the length of
2924 name_alist_or_stem is safe to alloca and fits in int.
2925 (Fexecute_extended_command): Likewise for function name and binding.
2926 (Frecursion_depth): Wrap around reliably on integer overflow.
2927 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2928 since some callers pass EMACS_INT values.
2929 (Fsingle_key_description): Don't crash if symbol name contains more
2930 than MAX_ALLOCA bytes.
2931 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2932 (get_minibuffer): Arg is now EMACS_INT, not int.
2933 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2934 (esprintf, exprintf, evxprintf): New decls.
2935 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2936
2937 * dbusbind.c (signature_cat): New function.
2938 (xd_signature, Fdbus_register_signal):
2939 Do not overrun buffer; instead, report string overflow.
2940
2941 * dispnew.c (add_window_display_history): Don't overrun buffer.
2942 Truncate instead; this is OK since it's just a log.
2943
2944 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2945 even if the time zone offset is outlandishly large.
2946 Don't mishandle offset == INT_MIN.
2947
2948 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2949 when creating daemon; the previous buffer-overflow check was incorrect.
2950
2951 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2952 which has the guts of the old verror function.
2953
2954 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2955 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2956
2957 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2958 (font_unparse_xlfd): Don't blindly alloca long strings.
2959 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2960 fits in int, when using sprintf. Use single snprintf to count
2961 length of string rather than counting it via multiple sprintfs;
2962 that's simpler and more reliable.
2963 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2964 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2965 sprintf, in case result does not fit in int.
2966
2967 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2968 (fontset_from_font): Print it.
2969
2970 * frame.c (tty_frame_count): Now printmax_t, not int.
2971 (make_terminal_frame, set_term_frame_name): Print it.
2972 (x_report_frame_params): In X, window IDs are unsigned long,
2973 not signed long, so print them as unsigned.
2974 (validate_x_resource_name): Check for implausibly long names,
2975 and don't assume name length fits in 'int'.
2976 (x_get_resource_string): Don't blindly alloca invocation name;
2977 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2978 not fit in int.
2979
2980 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2981 (xg_check_special_colors, xg_set_geometry):
2982 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2983
2984 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2985 Use esprintf, not sprintf, in case result does not fit in int.
2986
2987 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2988 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2989 it as a large positive number.
2990 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2991 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2992
2993 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2994 in case result does not fit in int.
2995
2996 * print.c (float_to_string): Detect width overflow more reliably.
2997 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2998 buffer overrun. Don't assume list length fits in 'int'. Treat
2999 print length of 0 as 0, not as infinity; to be consistent with other
3000 uses of print length in this function. Don't overflow print length
3001 index. Don't assume hash table size fits in 'long', or that
3002 vectorlike size fits in 'unsigned long'.
3003
3004 * process.c (make_process): Use printmax_t, not int, to format
3005 process-name gensyms.
3006
3007 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3008
3009 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3010 to avoid potential buffer overrun.
3011
3012 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3013 if X resource line is longer than 512 bytes.
3014
3015 * xfns.c (x_window): Make sprintf buffer a bit bigger
3016 to avoid potential buffer overrun.
3017
3018 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3019
3020 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3021
30222011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3023
3024 Integer overflow fixes for scrolling, etc.
3025 Without these, Emacs silently mishandles large integers sometimes.
3026 For example, "C-u 4294967297 M-x recenter" was treated as if
3027 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3028
3029 * xdisp.c (try_window_id): Check Emacs fixnum range before
3030 converting to 'int'.
3031
3032 * window.c (window_scroll_line_based, Frecenter):
3033 Check that an Emacs fixnum is in range before assigning it to 'int'.
3034 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3035 values converted from Emacs fixnums.
3036 (Frecenter): Don't wrap around a line count if it is out of 'int'
3037 range; instead, treat it as an extreme value.
3038 (Fset_window_configuration, compare_window_configurations):
3039 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3040
3041 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3042 that can exceed INT_MAX. Check that EMACS_INT value is in range
3043 before assigning it to the (possibly-narrower) index.
3044 (match_limit): Don't assume that a fixnum can fit in 'int'.
3045
3046 * print.c (print_object): Use ptrdiff_t, not int, for index that can
3047 exceed INT_MAX.
3048
3049 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3050 (Fvertical_motion): Don't wrap around LINES values that don't fit
3051 in 'int'. Instead, treat them as extreme values. This is good
3052 enough for windows, which can't have more than INT_MAX lines anyway.
3053
30542011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3055
3056 * Require libxml/parser.h to avoid compilation warning.
3057
3058 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3059
3060 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3061 since this reportedly can destroy thread storage.
3062
30632011-08-30 Chong Yidong <cyd@stupidchicken.com>
3064
3065 * syntax.c (find_defun_start): Update all cache variables if
3066 exiting early (Bug#9401).
3067
30682011-08-30 Eli Zaretskii <eliz@gnu.org>
3069
3070 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3071
3072 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3073 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3074 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3075
3076 * term.c (tty_append_glyph): New function.
3077 (produce_stretch_glyph): Static function and its prototype deleted.
3078
3079 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3080 Add prototypes.
3081
30822011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3083
3084 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3085 when checking :margin (Bug#9390).
3086 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3087 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3088 so that the name doesn't mislead. All uses changed.
3089
30902011-08-28 Johan Bockgård <bojohan@gnu.org>
3091
3092 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3093 set_tty_hooks.
3094
30952011-08-27 Eli Zaretskii <eliz@gnu.org>
3096
3097 * xdisp.c (move_it_to): Don't bail out early when reaching
3098 position beyond to_charpos, if we are scanning backwards.
3099 (move_it_vertically_backward): When DY == 0, make sure we get to
3100 the first character in the line after the newline.
3101
31022011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3103
3104 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3105 (ccl_driver): Do not generate an out-of-range pointer.
3106 (Fccl_execute_on_string): Remove unnecessary check for
3107 integer overflow, noted by Stefan Monnier in
3108 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3109 Remove a FIXME that didn't need fixing.
3110 Simplify the newly-introduced buffer reallocation code.
3111
31122011-08-27 Juanma Barranquero <lekktu@gmail.com>
3113
3114 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3115
31162011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3117
3118 Integer and memory overflow issues (Bug#9196).
3119
3120 * doc.c (get_doc_string): Rework so that
3121 get_doc_string_buffer_size is the actual buffer size, rather than
3122 being 1 less than the actual buffer size; this makes xpalloc more
3123 convenient.
3124
3125 * image.c (x_allocate_bitmap_record, cache_image):
3126 * xselect.c (Fx_register_dnd_atom):
3127 Simplify previous changes by using xpalloc.
3128
3129 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3130 since either will do and ptrdiff_t is convenient with xpalloc.
3131
3132 * charset.c (charset_table_size)
3133 (struct charset_sort_data.priority): Now ptrdiff_t.
3134 (charset_compare): Don't overflow if priorities differ greatly.
3135 (Fsort_charsets): Don't assume list length fits in int.
3136 Check for size-calculation overflow when allocating sort data.
3137 (syms_of_charset): Allocate an initial charset table that is
3138 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3139
3140 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3141
3142 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3143 The actual value is always <= INT_MAX, and leaving it unsigned made
3144 overflow checking harder.
3145
3146 * dispextern.h (struct glyph_matrix.rows_allocated)
3147 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3148 with xpalloc. The values are still always <= INT_MAX.
3149
3150 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3151
3152 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3153 (SAFE_NALLOCA): New macro.
3154
3155 * region-cache.c (struct boundary.pos, find_cache_boundary)
3156 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3157 (set_cache_region, invalidate_region_cache)
3158 (revalidate_region_cache, know_region_cache, region_cache_forward)
3159 (region_cache_backward, pp_cache):
3160 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3161 so that ptrdiff_t * can be passed to xpalloc.
3162 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3163 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3164 (pp_cache): Don't assume cache_len fits in int.
3165 * region-cache.h: Adjust extern decls to match.
3166
3167 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3168 EMACS_INT, since either will do, for xpalloc.
3169
3170 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3171 (xnmalloc, xnrealloc, xpalloc): New functions.
3172
3173 * bidi.c (bidi_shelve_header_size): New constant.
3174 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3175 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3176
3177 * bidi.c (bidi_cache_shrink):
3178 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3179 (overlay_strings):
3180 Don't update size of array until after memory allocation succeeds,
3181 because xmalloc/xrealloc may not return.
3182 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3183 now that we have proper integer overflow checking.
3184 (record_overlay_string, overlay_strings): Catch overflows when
3185 calculating size of overlay_str_buf.
3186
3187 * callproc.c (Fcall_process): Check for size overflow when
3188 calculating size of args2.
3189 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3190 Normally we prefer signed values, but sticking with ptrdiff_t would
3191 require adding more-complicated checks.
3192
3193 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3194 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3195 Redo buffer-overflow calculations to avoid integer overflow.
3196 Add a FIXME comment where memory seems to be over-allocated.
3197
3198 * character.c (Fstring): Check for size-calculation overflow.
3199
3200 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3201 unnecessary integer overflow. Check for size overflow.
3202 (encode_coding_object): Don't update size until xmalloc succeeds.
3203
3204 * composite.c (get_composition_id): Check for overflow in glyph
3205 length calculations.
3206
3207 Integer and memory overflow fixes for display code.
3208 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3209 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3210 (scrolling_window): Check for overflow in size calculations.
3211 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3212 Don't assume glyph table len fits in int.
3213 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3214 (row_table_size): Now ptrdiff_t, not int.
3215 (scrolling_window): Avoid overflow in size calculations.
3216 Don't update size until allocation succeeds.
3217 * fns.c (concat): Check for overflow in size calculations.
3218 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3219 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3220 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3221
3222 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3223 (get_doc_string): Check for size calculation overflow.
3224 Don't update size until allocation succeeds.
3225 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3226 EMACS_INT, where ptrdiff_t will do.
3227 (Fsubstitute_command_keys): Check for string overflow.
3228
3229 * editfns.c (set_time_zone_rule): Don't assume environment length
3230 fits in int.
3231 (message_length): Now ptrdiff_t, not int.
3232 (Fmessage_box): Don't update size until allocation succeeds.
3233 Don't assume message length fits in int.
3234 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3235
3236 * emacs.c (main): Do not reallocate argv, since there is a null at
3237 the end that can be overwritten, and this way there's no need to
3238 worry about size-calculation overflow.
3239 (sort_args): Check for size-calculation overflow.
3240
3241 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3242 alloc succeeds.
3243 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3244
3245 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3246 (x_set_scroll_bar_width, x_figure_window_size):
3247 Check for integer overflow.
3248 (x_set_alpha): Do not assume XINT fits in int.
3249
3250 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3251 This is for the members text_lines, text_cols, total_lines, total_cols,
3252 where the system imposes an 'int' limit.
3253
3254 * fringe.c (Fdefine_fringe_bitmap):
3255 Don't update size until alloc works.
3256
3257 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3258 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3259
3260 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3261 Check for size-calculation overflow.
3262 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3263 do, as we prefer signed integers.
3264 (id_to_widget.max_size, id_to_widget.used)
3265 (xg_store_widget_in_map, xg_remove_widget_from_map)
3266 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3267 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3268 Use and return ptrdiff_t, not int.
3269 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3270 * gtkutil.h: Change prototypes to match the above.
3271
3272 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3273 are duplicate now that they've been promoted to lisp.h.
3274 (x_allocate_bitmap_record, x_alloc_image_color)
3275 (make_image_cache, cache_image, xpm_load):
3276 Don't update size until alloc is done.
3277 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3278 (x_detect_edges):
3279 Check for size calculation overflow.
3280 (ct_colors_allocated_max): New constant.
3281 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3282 overflow.
3283
3284 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3285 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3286 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3287 Use ptrdiff_t, not int, to count maps.
3288 (read_char_minibuf_menu_prompt): Check for overflow in size
3289 calculations. Don't update size until allocation succeeds.
3290 Redo calculations to avoid overflow.
3291 * keyboard.h: Change prototypes to match the above.
3292
3293 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3294 to count maps.
3295 (current_minor_maps): Check for size calculation overflow.
3296 * keymap.h: Change prototypes to match the above.
3297
3298 * lread.c (read1, init_obarray): Don't update size until alloc done.
3299
3300 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3301 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3302
3303 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3304 Now ptrdiff_t, not int.
3305 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3306 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3307
3308 * process.c (Fnetwork_interface_list): Check for overflow
3309 in size calculation.
3310
3311 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3312
3313 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3314 overflow. Don't bother calling xmalloc when xrealloc will do.
3315
3316 * search.c (Freplace_match): Check for size calculation overflow.
3317 (Fset_match_data): Don't assume list lengths fit in 'int'.
3318
3319 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3320 for command line length. Do not attempt to address one before the
3321 beginning of an array, as that's not portable.
3322
3323 * term.c (max_frame_lines): Remove; unused.
3324 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3325 not int.
3326 (encode_terminal_code, calculate_costs): Check for size
3327 calculation overflow.
3328 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3329 table lengths and related sizes. Don't update size until alloc
3330 done. Redo calculations to avoid overflow.
3331 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3332
3333 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3334 subtracting pointers.
3335 (gobble_line): Check for overflow more carefully. Don't update size
3336 until alloc done.
3337
3338 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3339 Don't update size until alloc done.
3340 Redo size calculations to avoid overflow.
3341 Check for size calculation overflow.
3342 (main) [DEBUG]: Fix typo in invoking tparam1.
3343
3344 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3345 Use ptrdiff_t, not int, for sizes.
3346 (store_mode_line_noprop_char): Don't update size until alloc done.
3347
3348 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3349 Use ptrdiff_t, not int, for sizes.
3350 (Finternal_make_lisp_face, cache_face):
3351 Check for size calculation overflow.
3352 (cache_face): Treat size calculation overflows as if they were
3353 memory exhaustion (the usual treatment), rather than aborting.
3354
3355 * xfns.c (x_encode_text, x_set_name_internal)
3356 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3357 sizes, since they can exceed INT_MAX in size. Check for size
3358 calculation overflow.
3359
3360 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3361 (xg_select): Check for size calculation overflow.
3362 Don't update size until alloc done.
3363
3364 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3365 as sprintf is limited to int lengths.
3366
3367 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3368 (X_LONG_MIN): New macros.
3369 Use them to make the following changes clearer.
3370 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3371 This change doesn't affect the value now, but it may help remind
3372 future maintainers not to raise the value too much later.
3373 (SELECTION_QUANTUM): Remove, replacing with ...
3374 (selection_quantum): ... new function, which avoids overflow.
3375 All uses changed.
3376 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3377 assumption that selection length fits in 'int'.
3378 (x_reply_selection_request, x_handle_selection_request)
3379 (x_get_window_property, receive_incremental_selection)
3380 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3381 (lisp_data_to_selection_data, clean_local_selection_data):
3382 Use ptrdiff_t, not int, to record length of selection.
3383 (x_reply_selection_request, x_get_window_property)
3384 (receive_incremental_selection, x_property_data_to_lisp):
3385 Redo calculations to avoid overflow.
3386 (x_reply_selection_request): When sending hint, ceiling it at
3387 X_LONG_MAX rather than relying on wraparound overflow to send
3388 something.
3389 (x_get_window_property, receive_incremental_selection)
3390 (lisp_data_to_selection_data, x_property_data_to_lisp):
3391 Check for size-calculation overflow.
3392 (x_get_window_property, receive_incremental_selection)
3393 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3394 Don't store size until memory allocation succeeds.
3395 (x_get_window_property): Plug memory leak on memory exhaustion.
3396 Don't double-block input; malloc is safe here. Don't assume 2**34
3397 - 4 fits in unsigned long. Add an xassert to check
3398 XGetWindowProperty overflow. Be more careful about overflow
3399 calculations, and distinguish size from memory overflow better.
3400 (receive_incremental_selection): When tracing, don't assume
3401 unsigned int is less than INT_MAX.
3402 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3403 harmful) conversions of unsigned short to int.
3404 (lisp_data_to_selection_data): Don't assume that integers
3405 in the range -65535 through -1 fit in an X unsigned short.
3406 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3407 result parameters unless successful. Rely on cons_to_unsigned
3408 to report problems with elements; the old code wasn't right anyway.
3409 (x_check_property_data): Check for int overflow; we cannot use
3410 a wider type due to X limits.
3411 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3412
3413 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3414
3415 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3416 (x_term_init): Check for size calculation overflow.
3417 (x_color_cells): Don't store size until memory allocation succeeds.
3418 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3419 Don't assume alloca size is less than MAX_ALLOCA.
3420 (x_term_init): Don't assume length fits in int (sprintf is limited
3421 to int size).
3422
3423 Use ptrdiff_t for composition IDs.
3424 * character.c (lisp_string_width):
3425 * composite.c (composition_table_size, n_compositions)
3426 (get_composition_id, composition_gstring_from_id):
3427 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3428 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3429 * window.c (Frecenter):
3430 Use ptrdiff_t, not int, for composition IDs.
3431 * composite.c (get_composition_id): Check for integer overflow.
3432 * composite.h: Adjust prototypes to match the above changes.
3433
3434 Use ptrdiff_t for hash table indexes.
3435 * category.c (hash_get_category_set):
3436 * ccl.c (ccl_driver):
3437 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3438 * coding.c (coding_system_charset_list, detect_coding_system):
3439 * coding.h (struct coding_system.id):
3440 * composite.c (get_composition_id, gstring_lookup_cache):
3441 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3442 * image.c (xpm_get_color_table_h):
3443 * lisp.h (hash_lookup, hash_put):
3444 * minibuf.c (Ftest_completion):
3445 Use ptrdiff_t for hash table indexes, not int (which is too
3446 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3447 32-bit --with-wide-int hosts).
3448
3449 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3450 Add a FIXME comment about memory leaks.
3451 (syms_of_charset): Don't assume xmalloc returns.
3452
3453 Don't assume that stated character widths fit in int.
3454 * character.c (Fchar_width, c_string_width, lisp_string_width):
3455 * character.h (CHAR_WIDTH):
3456 * indent.c (MULTIBYTE_BYTES_WIDTH):
3457 Use sanitize_char_width to avoid undefined and/or bad behavior
3458 with outlandish widths.
3459 * character.h (sanitize_tab_width): Rename from sanitize_width,
3460 now that we have two such functions. All uses changed.
3461 (sanitize_char_width): New inline function.
3462
3463 Don't assume that tab-width fits in int.
3464 * character.h (sanitize_width): New inline function.
3465 (SANE_TAB_WIDTH): New macro.
3466 (ASCII_CHAR_WIDTH): Use it.
3467 * indent.c (sane_tab_width): Remove. All uses replaced by
3468 SANE_TAB_WIDTH (current_buffer).
3469 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3470
3471 * fileio.c: Integer overflow issues with file modes.
3472 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3473
3474 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3475 Remove unreachable code.
3476 (read_hex, load_charset_map_from_file): Check for integer overflow.
3477
3478 * xterm.c: Don't go over XClientMessageEvent limit.
3479 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3480 (x_send_scroll_bar_event): Likewise. Check that the size does not
3481 exceed limits imposed by XClientMessageEvent, as well as the usual
3482 ptrdiff_t and size_t limits.
3483
3484 * keyboard.c: Overflow, signedness and related fixes.
3485 (make_lispy_movement): Use same integer type in forward decl
3486 that is used in the definition.
3487 (read_key_sequence, keyremap_step):
3488 Change bufsize argument back to int, undoing my 2011-03-30 change.
3489 We prefer signed types, and int is wide enough here.
3490 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3491 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3492 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3493 length, not size_t. Use ptrdiff_t for index, not int.
3494 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3495 possibility of integer overflow.
3496
3497 Overflow, signedness and related fixes for images.
3498
3499 * dispextern.h (struct it.stack[0].u.image.image_id)
3500 (struct_it.image_id, struct image.id, struct image_cache.size)
3501 (struct image_cache.used, struct image_cache.ref_count):
3502 * gtkutil.c (update_frame_tool_bar):
3503 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3504 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3505 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3506 * nsmenu.m (update_frame_tool_bar):
3507 * xdisp.c (calc_pixel_width_or_height):
3508 * xfns.c (image_cache_refcount):
3509 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3510 on typical 64-bit hosts.
3511
3512 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3513 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3514 Omit unnecessary casts to int.
3515 (parse_image_spec): Check that integers fall into 'int' range
3516 when the callers expect that.
3517 (image_ascent): Redo ascent calculation to avoid int overflow.
3518 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3519 (lookup_image): Remove unnecessary tests.
3520 (xbm_image_p): Locals are now of int, not EMACS_INT,
3521 since parse_image_check makes sure they fit into int.
3522 (png_load, gif_load, svg_load_image):
3523 Prefer int to unsigned where either will do.
3524 (tiff_handler): New function, combining the cores of the
3525 old tiff_error_handler and tiff_warning_handler.
3526 This function is rewritten to use vsnprintf and thereby avoid
3527 stack buffer overflows. It uses only the features of vsnprintf
3528 that are common to both POSIX and native Microsoft.
3529 (tiff_error_handler, tiff_warning_handler): Use it.
3530 (tiff_load, gif_load, imagemagick_load_image):
3531 Don't assume :index value fits in 'int'.
3532 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3533 (imagemagick_load_image): Check that crop parameters fit into
3534 the integer types that MagickCropImage accepts. Don't assume
3535 Vimagemagick_render_type has a nonnegative value. Don't assume
3536 size_t fits in 'long'.
3537 (gs_load): Use printmax_t to print the widest integers possible.
3538 Check for integer overflow when computing image height and width.
3539
35402011-08-26 Eli Zaretskii <eliz@gnu.org>
3541
3542 * xdisp.c (redisplay_window): Don't force window start if point
3543 will be invisible in the resulting window. (Bug#9324)
3544
35452011-08-25 Eli Zaretskii <eliz@gnu.org>
3546
3547 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3548 the display spec is of the form `(space ...)'.
3549 (handle_display_spec): Return the value returned by
3550 handle_single_display_spec, not just 1 or zero.
3551 (handle_single_display_spec): If the display spec is of the form
3552 `(space ...)', and specifies display in the text area, return 2
3553 rather than 1.
3554 (try_cursor_movement): Check for the need to scroll more
3555 accurately, and prefer exact match for point under bidi.
3556 Don't advance `row' beyond the last row of the window.
3557
3558 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3559 into disp_prop; all users changed.
3560
3561 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3562 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3563 for the text covered by the display property.
3564
35652011-08-25 Chong Yidong <cyd@stupidchicken.com>
3566
3567 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3568 Change return value to nil.
3569 (Frecord_buffer): Delete unused function.
3570
35712011-08-24 Eli Zaretskii <eliz@gnu.org>
3572
3573 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3574 buffers, return left-to-right.
3575 (set_cursor_from_row): Consider candidate row a win if its glyph
3576 represents a newline and point is on that newline. Fixes cursor
3577 positioning on the newline at EOL of R2L text within L2R
3578 paragraph, and vice versa.
3579 (try_cursor_movement): Check continued rows, in addition to
3580 continuation rows. Fixes unwarranted scroll when point enters a
3581 continued line of R2L text within an L2R paragraph, or vice versa.
3582 (cursor_row_p): Consider the case of point being equal to
3583 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3584 from the end of a short line to the beginning of a continued line
3585 of R2L text within L2R paragraph.
3586 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3587 composed characters.
3588
3589 * bidi.c (bidi_check_type): Use xassert.
3590 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3591 members.
3592
35932011-08-23 Eli Zaretskii <eliz@gnu.org>
3594
3595 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3596 a character.
3597
35982011-08-23 Chong Yidong <cyd@stupidchicken.com>
3599
3600 * nsfont.m (ns_otf_to_script): Fix typo.
3601
36022011-08-22 Kenichi Handa <handa@m17n.org>
3603
3604 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3605 extra slot even if the purpose is char-code-property-table.
3606
36072011-08-23 Eli Zaretskii <eliz@gnu.org>
3608
3609 * xdisp.c (redisplay_window): When computing centering_position,
3610 account for the height of the header line. (Bug#8874)
3611
3612 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3613 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3614 candidate is selected by the mouse, and that candidate has a
3615 composed character under the mouse.
3616
3617 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3618 coordinates reported by pos-visible-in-window-p for a composed
3619 character in column zero.
3620
36212011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3622
3623 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3624
36252011-08-22 Eli Zaretskii <eliz@gnu.org>
3626
3627 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3628 consider it a hit if to_charpos is anywhere in the range of the
3629 composed buffer positions.
3630
36312011-08-22 Chong Yidong <cyd@stupidchicken.com>
3632
3633 * image.c (gif_load): Don't assume that each subimage has the same
3634 dimensions as the base image. Handle disposal method that is
3635 "undefined" by the gif spec (Bug#9335).
3636
36372011-08-20 Chong Yidong <cyd@stupidchicken.com>
3638
3639 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3640 (Fcondition_case): Document `debug' symbol in error handler.
3641
36422011-08-19 Eli Zaretskii <eliz@gnu.org>
3643
3644 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3645 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3646 from an Org mode buffer to a Speedbar frame.
3647
3648 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3649 a composition, take its buffer position from IT->cmp_it.charpos.
3650 Fixes cursor positioning at the beginning of a line that begins
3651 with a composed character.
3652
36532011-08-18 Eli Zaretskii <eliz@gnu.org>
3654
3655 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3656 character bidirectional type, use STRONG_L instead. Fixes crashes
3657 in a buffer produced by `describe-categories'.
3658
3659 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3660 members before the level stack, so they would be saved and
3661 restored when copying iterator state. Fixes incorrect reordering
3662 around TABs covered by display properties.
3663
36642011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3665
3666 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3667
36682011-08-17 Chong Yidong <cyd@stupidchicken.com>
3669
3670 * eval.c (internal_condition_case, internal_condition_case_1)
3671 (internal_condition_case_2, internal_condition_case_n):
3672 Remove unnecessary aborts (Bug#9081).
3673
36742011-08-17 Eli Zaretskii <eliz@gnu.org>
3675
3676 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3677 has no `load' handler, try opening the file locally. (Bug#9311)
3678
36792011-08-16 Ken Brown <kbrown@cornell.edu>
3680
3681 * gmalloc.c: Expand comment.
3682
36832011-08-16 Eli Zaretskii <eliz@gnu.org>
3684
3685 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3686 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3687
36882011-08-16 Ken Brown <kbrown@cornell.edu>
3689
3690 Fix memory allocation problems in Cygwin build (Bug#9273).
3691
3692 * unexcw.c ( __malloc_initialized): Declare external variable.
3693 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3694
3695 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3696 New variables.
3697 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3698 dumped emacs.
3699 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3700 in the static heap.
3701 [CYGWIN] (special_realloc): New function.
3702 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3703 requests to realloc storage in the static heap.
3704
37052011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 * bidi.c (bidi_initialize): Remove unused local.
3708
37092011-08-15 Eli Zaretskii <eliz@gnu.org>
3710
3711 * bidimirror.h:
3712 * biditype.h: Remove file.
3713 * makefile.w32-in ($(BLD)/bidi.$(O)):
3714 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3715
3716 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3717
3718 * chartab.c: Improve commentary for the uniprop_table API.
3719
3720 * bidi.c (bidi_paragraph_init): Support zero value of
3721 bidi_ignore_explicit_marks_for_paragraph_level.
3722 (bidi_initialize): Use uniprop_table instead of including
3723 biditype.h and bidimirror.h.
3724
3725 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3726 coordinates of the iterator when restoring from ppos_it.
3727 (Bug#9296)
3728
37292011-08-14 Kenichi Handa <handa@m17n.org>
3730
3731 * process.c (create_process): Call setup_process_coding_systems
3732 after the pid of the process is set to -1 (Bug#8162).
3733
37342011-08-14 Eli Zaretskii <eliz@gnu.org>
3735
3736 * xdisp.c (move_it_in_display_line_to): Don't invoke
3737 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3738 ppos_it. Fixes vertical cursor motion when line beginning is
3739 covered by an image. (Bug#9296)
3740
37412011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3742
3743 * nsterm.h (ns_run_ascript): Declare.
3744 (NSAPP_DATA2_RUNASSCRIPT): Define.
3745
3746 * nsfns.m (as_script, as_result, as_status): New static variables.
3747 (ns_run_ascript): New function.
3748 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3749 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3750 the event loop. Get status from as_status (Bug#7276).
3751
3752 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3753 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3754 the event loop (Bug#7276).
3755
37562011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3757
3758 * gnutls.c (QCgnutls_bootprop_priority)
3759 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3760 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3761 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3762 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3763 (QCgnutls_bootprop_verify_hostname_error)
3764 (QCgnutls_bootprop_callbacks_verify): Rename from
3765 Qgnutls_bootprop_..., all uses changed.
3766
3767 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3768 uses changed.
3769
37702011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3771
3772 * xfaces.c (Qframe_set_background_mode): Now static.
3773 * dispextern.h (Qframe_set_background_mode): Remove decl.
3774
3775 * process.c (Fnetwork_interface_info): Declare local only if needed.
3776
37772011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3778
3779 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3780 (Fnetwork_interface_list): Allocate in increments of bytes instead
3781 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3782 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3783 sockaddr.
3784 (struct ifflag_def): notrailers is smart on OSX.
3785 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3786 Get hardware address with getifaddrs if available.
3787
37882011-08-12 Eli Zaretskii <eliz@gnu.org>
3789
3790 * xdisp.c (iterate_out_of_display_property): xassert that
3791 IT->position is set to within IT->object's boundaries. Break from
3792 the loop as soon as EOB is reached; avoids infloops in redisplay
3793 when IT->position is set up wrongly due to some bug.
3794 Set IT->current to match the bidi iterator unconditionally.
3795 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3796 entry. Force push_it to save on the stack the current
3797 buffer/string position, to be restored by pop_it. Fix flags in
3798 the iterator structure wrt the object coming from a display
3799 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3800 properties. (Bug#9284)
3801
38022011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3803
3804 * fontset.c (fontset_get_font_group): Add proper type checks.
3805 (Bug#9172)
3806
38072011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3808
3809 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3810 and LC_VERSION_MIN_MACOSX.
3811 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3812 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3813
38142011-08-08 Eli Zaretskii <eliz@gnu.org>
3815
3816 * xdisp.c (forward_to_next_line_start): Allow to use the
3817 no-display-properties-and-no-overlays under bidi display.
3818 Set disp_pos in the bidi iterator to avoid searches for display
3819 properties and overlays.
3820
38212011-08-08 Chong Yidong <cyd@stupidchicken.com>
3822
3823 * editfns.c (Fset_time_zone_rule): Document relationship with the
3824 setenv function.
3825
3826 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3827 the font entity extracted from the cache (Bug#8109).
3828
38292011-08-07 Chong Yidong <cyd@stupidchicken.com>
3830
3831 * composite.c (autocmp_chars): Don't reset point. That is done by
3832 restore_point_unwind (Bug#5984).
3833
38342011-08-07 Juri Linkov <juri@jurta.org>
3835
3836 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3837 to show the arg `TIME' instead of `TIMEVAL'.
3838
38392011-08-06 Eli Zaretskii <eliz@gnu.org>
3840
3841 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3842 display property strides EOL and includes a newline, as in
3843 longlines-mode. (Bug#9254)
3844 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3845 word-wrap under bidirectional display. (Bug#9224)
3846
3847 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3848 is non-zero, even if the data buffer is NULL. Fixes a crash in
3849 vertical-motion with longlines-mode. (Bug#9254)
3850
38512011-08-05 Eli Zaretskii <eliz@gnu.org>
3852
3853 * bidi.c <bidi_cache_total_alloc>: Now static.
3854 (bidi_initialize): Initialize bidi_cache_total_alloc.
3855
3856 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3857 cache. (Bug#9221)
3858
3859 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3860 amount allocated this far in `bidi_cache_total_alloc'.
3861 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3862 non-zero, only free the data buffer without restoring the cache
3863 contents. All callers changed.
3864
3865 * dispextern.h (bidi_unshelve_cache): Update prototype.
3866
3867 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3868 (move_it_in_display_line, move_it_to)
3869 (move_it_vertically_backward, move_it_by_lines): Replace the call
3870 to xfree to an equivalent call to bidi_unshelve_cache.
3871 (move_it_in_display_line_to): Fix logic of returning
3872 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3873
38742011-08-05 Eli Zaretskii <eliz@gnu.org>
3875
3876 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3877 came from a string character with a `cursor' property. (Bug#9229)
3878
38792011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3880
3881 * Makefile.in (LIB_PTHREAD): New variable.
3882 (LIBES): Add LIB_PTHREAD (Bug#9216).
3883
3884 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3885 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3886
38872011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3888
3889 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3890
38912011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3892
3893 * xterm.c (x_find_topmost_parent): New function.
3894 (x_set_frame_alpha): Find topmost parent window with
3895 x_find_topmost_parent and set the property there also (bug#9181).
3896 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3897
38982011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3899
3900 * callproc.c (Fcall_process): Avoid vfork clobbering
3901 the local vars buffer, coding_systems, current_dir.
3902
39032011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3904
3905 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3906
39072011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3908
3909 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3910 so that it is not optimized away.
3911
3912 * xdisp.c (compute_display_string_pos): Remove unused local.
3913
39142011-08-02 Eli Zaretskii <eliz@gnu.org>
3915
3916 Fix slow cursor motion and scrolling in large buffers with
3917 selective display, like Org Mode buffers. (Bug#9218)
3918
3919 * dispextern.h (struct bidi_it): New member disp_prop_p.
3920
3921 * xdisp.c: Remove one-slot cache of display string positions.
3922 (compute_display_string_pos): Accept an additional argument
3923 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3924 for a display string or property. If found, set DISP_PROP_P
3925 non-zero.
3926
3927 * bidi.c (bidi_fetch_char): Accept an additional argument
3928 DISP_PROP_P, and pass it to compute_display_string_pos.
3929 Only handle text covered by a display string if DISP_PROP_P is returned
3930 non-zero. All callers of bidi_fetch_char changed.
3931
39322011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3933
3934 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3935
39362010-12-03 Don March <don@ohspite.net>
3937
3938 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3939 last character M-[char] is translated to ESC [char] (bug#7541).
3940
39412011-08-02 Kenichi Handa <handa@m17n.org>
3942
3943 * lisp.h (uniprop_table): Extern it.
3944
3945 * chartab.c (uniprop_table): Make it non-static.
3946
39472011-08-01 Eli Zaretskii <eliz@gnu.org>
3948
3949 * xdisp.c (forward_to_next_line_start): Accept additional argument
3950 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3951 on the newline.
3952 (reseat_at_next_visible_line_start): Use the bidi iterator state
3953 returned by forward_to_next_line_start to restore the state of
3954 it->bidi_it after backing up to previous newline. (Bug#9212)
3955
39562011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3957
3958 * regex.c (re_comp): Protoize.
3959 (re_exec): Fix return type.
3960 (regexec): Fix type of `ret'. (Bug#9203)
3961
39622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3963
3964 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3965 This is needed if max-image-size is a floating-point number.
3966
39672011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3968
3969 * print.c (print_object): Print empty symbol as ##.
3970
3971 * lread.c (read1): Read ## as empty symbol.
3972
39732011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3974
3975 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3976 setting frame foreground color (Bug#9175).
3977 (x_set_background_color): Likewise.
3978
3979 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3980 contents (Bug#9176).
3981 (EmacsTooltip -init): Remove bezels and add shadows to
3982 tooltip windows.
3983
3984 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3985 or scroll bar (Bug#8470).
3986
3987 * nsfont.m (nsfont_open): Remove assignment to voffset and
3988 unnecessary vars hshink, expand, hd, full_height, min_height.
3989 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3990
3991 * nsterm.h (nsfont_info): Remove voffset field.
3992
39932011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3994
3995 Implement strike-through and overline on NextStep (Bug#8863).
3996
3997 * nsfont.m (nsfont_open): Use underline position provided by font,
3998 instead of hard-coded value of 2.
3999 (nsfont_draw): Call ns_draw_text_decoration instead.
4000
4001 * nsterm.h: Add declaration for ns_draw_text_decoration.
4002
4003 * nsterm.m (ns_draw_text_decoration): New function for drawing
4004 underline, overline, and strike-through.
4005 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4006 ns_draw_text_decoration. Change treatment of cursor drawing to
4007 accommodate underlining, etc.
4008
40092011-07-28 Eli Zaretskii <eliz@gnu.org>
4010
4011 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4012 default.
4013
40142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4015
4016 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4017 Without this fix, if a signal arrives just after memory fills up,
4018 'malloc' might be invoked reentrantly.
4019
4020 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4021 In other words, assume that every image size is allowed, on non-X
4022 hosts. This assumption is probably wrong, but it lets Emacs compile.
4023
40242011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4025
4026 * regex.c (re_iswctype): Convert return values to boolean.
4027
40282011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4029
4030 * xdisp.c (compute_display_string_pos): Don't use cached display
4031 string position if the buffer had its restriction changed.
4032 (Bug#9184)
4033
40342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4035
4036 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4037
40382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4039
4040 Integer signedness and overflow and related fixes. (Bug#9079)
4041
4042 * bidi.c: Integer size and overflow fixes.
4043 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4044 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4045 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4046 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4047 (bidi_find_other_level_edge):
4048 Use ptrdiff_t instead of EMACS_INT where either will do.
4049 This works better on 32-bit hosts configured --with-wide-int.
4050 (bidi_cache_ensure_space): Check for size-calculation overflow.
4051 Use % rather than repeated addition, for better worst-case speed.
4052 Don't set bidi_cache_size until after xrealloc returns, because it
4053 might not return.
4054 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4055 (bidi_cache_ensure_space): Also check that the bidi cache size
4056 does not exceed that of the largest Lisp string or buffer. See Eli
4057 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4058
4059 * alloc.c (__malloc_size_t): Remove.
4060 All uses replaced by size_t. See Andreas Schwab's note
4061 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4062
4063 * image.c: Improve checking for integer overflow.
4064 (check_image_size): Assume that f is nonnull, since
4065 it is always nonnull in practice. This is one less thing to
4066 worry about when checking for integer overflow later.
4067 (x_check_image_size): New function, which checks for integer
4068 overflow issues inside X.
4069 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4070 This removes the need for a memory_full check.
4071 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4072 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4073 (xbm_read_bitmap_data): Change locals back to 'int', since
4074 their values must fit in 'int'.
4075 (xpm_load_image, png_load, tiff_load):
4076 Invoke x_create_x_image_and_pixmap earlier,
4077 to avoid much needless work if the image is too large.
4078 (tiff_load): Treat overly large images as if
4079 x_create_x_image_and_pixmap failed, not as malloc failures.
4080 (gs_load): Use x_check_image_size.
4081
4082 * gtkutil.c: Omit integer casts.
4083 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4084 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4085
4086 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4087
4088 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4089 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4090 would wrongly return t on a 64-bit host.
4091
4092 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4093 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4094 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4095 and therefore cause GCC to emit a bogus diagnostic in some cases.
4096
4097 * image.c: Integer signedness and overflow and related fixes.
4098 This is not an exhaustive set of fixes, but it's time to
4099 record what I've got.
4100 (lookup_pixel_color, check_image_size): Remove redundant decls.
4101 (check_image_size): Don't assume that arbitrary EMACS_INT values
4102 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4103 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4104 (tiff_load, imagemagick_load_image):
4105 Check for overflow in size calculations.
4106 (x_create_x_image_and_pixmap): Remove unnecessary test for
4107 xmalloc returning NULL; that can't happen.
4108 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4109 (xpm_color_bucket): Use better integer hashing function.
4110 (xpm_cache_color): Don't possibly over-allocate memory.
4111 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4112 (gif_memory_source):
4113 Use ptrdiff_t, not int or size_t, to record sizes.
4114 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4115 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4116 either works, as we prefer signed integers.
4117 (tiff_read_from_memory, tiff_write_from_memory):
4118 Return tsize_t, not size_t, since that's what the TIFF API wants.
4119 (tiff_read_from_memory): Don't fail simply because the read would
4120 go past EOF; instead, return a short read.
4121 (tiff_load): Omit no-longer-needed casts.
4122 (Fimagemagick_types): Don't assume size fits into 'int'.
4123
4124 Improve hashing quality when configured --with-wide-int.
4125 * fns.c (hash_string): New function, taken from sxhash_string.
4126 Do not discard information about ASCII character case; this
4127 discarding is no longer needed.
4128 (sxhash-string): Use it. Change sig to match it. Caller changed.
4129 * lisp.h: Declare it.
4130 * lread.c (hash_string): Remove, since we now use fns.c's version.
4131 The fns.c version returns a wider integer if --with-wide-int is
4132 specified, so this should help the quality of the hashing a bit.
4133
4134 * emacs.c: Integer overflow minor fix.
4135 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4136 Define only if GNU_LINUX.
4137 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4138
4139 * dispnew.c: Integer signedness and overflow fixes.
4140 Remove unnecessary forward decls, that were a maintenance hassle.
4141 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4142 All uses changed.
4143 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4144 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4145 (prepare_desired_row, line_draw_cost):
4146 Use int, not unsigned, where either works.
4147 (save_current_matrix, restore_current_matrix):
4148 Use ptrdiff_t, not size_t, where either works.
4149 (init_display): Check for overflow more accurately, and without
4150 relying on undefined behavior.
4151
4152 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4153 Remove, replacing with the new symbols in lisp.h. All uses changed.
4154 * fileio.c (make_temp_name):
4155 * filelock.c (lock_file_1, lock_file):
4156 * xdisp.c (message_dolog):
4157 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4158 Use pMd etc. instead.
4159 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4160 replacing the pWIDE etc. symbols removed from editfns.c.
4161
4162 * keyboard.h (num_input_events): Now uintmax_t.
4163 This is (very slightly) less likely to mess up due to wraparound.
4164 All uses changed.
4165
4166 * buffer.c: Integer signedness fixes.
4167 (alloc_buffer_text, enlarge_buffer_text):
4168 Use ptrdiff_t rather than size_t when either will do, as we prefer
4169 signed integers.
4170
4171 * alloc.c: Integer signedness and overflow fixes.
4172 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4173 (__malloc_size_t): Default to size_t, not to int.
4174 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4175 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4176 Prefer ptrdiff_t to size_t when either would do, as we prefer
4177 signed integers.
4178 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4179 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4180 Now const. Initialize with values that are in range even if char
4181 is signed.
4182 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4183 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4184 These functions do the right thing with sizes > 2**32.
4185 (check_depth): Now ptrdiff_t, not int.
4186 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4187 Adjust to new way of storing sizes. Check for size overflow bugs
4188 in rest of code.
4189 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4190 slightly wrong anyway, as it missed one instance of
4191 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4192 (refill_memory_reserve): Omit needless cast to size_t.
4193 (mark_object_loop_halt): Mark as externally visible.
4194
4195 * xselect.c: Integer signedness and overflow fixes.
4196 (Fx_register_dnd_atom, x_handle_dnd_message):
4197 Use ptrdiff_t, not size_t, since we prefer signed.
4198 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4199 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4200 x_dnd_atoms_size and x_dnd_atoms_length.
4201
4202 * doprnt.c: Prefer signed to unsigned when either works.
4203 * eval.c (verror):
4204 * doprnt.c (doprnt):
4205 * lisp.h (doprnt):
4206 * xdisp.c (vmessage):
4207 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4208 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4209 prefer signed arithmetic to avoid comparison confusion.
4210 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4211 but is a bit tricky.
4212
4213 Assume freestanding C89 headers, string.h, stdlib.h.
4214 * data.c, doprnt.c, floatfns.c, print.c:
4215 Include float.h unconditionally.
4216 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4217 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4218 * regex.c: Likewise for stddef.h, string.h.
4219 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4220 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4221 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4222 (STDC_HEADERS): Remove obsolete defines.
4223 * sysdep.c: Include limits.h unconditionally.
4224
4225 Assume support for memcmp, memcpy, memmove, memset.
4226 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4227 * regex.c (memcmp, memcpy):
4228 Remove; we assume C89 now.
4229
4230 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4231 (__malloc_safe_bcopy): Remove; no longer needed.
4232
4233 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4234 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4235 well either way, and we prefer signed to unsigned.
4236
42372011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4238
4239 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4240 closes the connection while we're reading (bug#9182).
4241
42422011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4243
4244 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4245 are specified (Bug#9168).
4246
42472011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4248
4249 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4250 Found by GCC static checking and --with-wide-int on a 32-bit host.
4251
42522011-07-25 Eli Zaretskii <eliz@gnu.org>
4253
4254 * xdisp.c (compute_display_string_pos): Fix logic of caching
4255 previous display string position. Initialize cached_prev_pos to
4256 -1. Fixes slow-down at the beginning of a buffer.
4257
42582011-07-24 Eli Zaretskii <eliz@gnu.org>
4259
4260 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4261 for attrs[LFACE_FONTSET_INDEX].
4262
42632011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4264
4265 * xml.c (parse_region): Remove unused local
4266 that was recently introduced.
4267
42682011-07-23 Eli Zaretskii <eliz@gnu.org>
4269
4270 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4271 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4272
4273 * xdisp.c (move_it_in_display_line_to): Record the best matching
4274 position for TO_CHARPOS while scanning the line, and restore it on
4275 exit if none of the characters scanned was an exact match.
4276 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4277 when exact match is impossible due to invisible text, and the
4278 lines are truncated.
4279
42802011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4281
4282 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4283 for OSX >= 10.7.
4284
42852011-07-22 Eli Zaretskii <eliz@gnu.org>
4286
4287 Fix a significant slow-down of cursor motion with C-n, C-p,
4288 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4289 auto-repeat under bidi redisplay in fontified buffers.
4290 * xdisp.c (compute_stop_pos_backwards): New function.
4291 (next_element_from_buffer): Call compute_stop_pos_backwards to
4292 find a suitable prev_stop when we find ourselves before
4293 base_level_stop.
4294 (reseat): Don't look for prev_stop, as that could mean a very long
4295 run.
4296 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4297 <cached_disp_overlay_modiff>: Cache for last found display string
4298 position.
4299 (compute_display_string_pos): Return the cached position if asked
4300 about the same buffer in the same area of character positions, and
4301 the buffer wasn't changed since the time the display string
4302 position was cached.
4303
43042011-07-22 Eli Zaretskii <eliz@gnu.org>
4305
4306 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4307 is an integer, which is important for empty lines. (Bug#9149)
4308
43092011-07-22 Chong Yidong <cyd@stupidchicken.com>
4310
4311 * frame.c (Fmodify_frame_parameters): In tty case, update the
4312 default face if necessary (Bug#4238).
4313
43142011-07-21 Chong Yidong <cyd@stupidchicken.com>
4315
4316 * editfns.c (Fstring_to_char): No need to explain what a character
4317 is in the docstring (Bug#6576).
4318
43192011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4320
4321 * xml.c (parse_region): Make sure we always return a tree.
4322
43232011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4324
4325 * xml.c (parse_region): If a document contains only comments,
4326 return that, too.
4327
43282011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4329
4330 * xml.c (make_dom): Return comments, too.
4331
43322011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 Port to OpenBSD.
4335 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4336 and the surrounding thread.
4337 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4338 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4339 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4340 timer goes off.
4341 * s/openbsd.h (BROKEN_SIGIO): Define.
4342 * unexelf.c (unexec) [__OpenBSD__]:
4343 Don't update the .mdebug section of the Alpha COFF symbol table.
4344
43452011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4346
4347 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4348 (bug#8460).
4349
43502011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4351
4352 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4353 This fixes some race conditions on the permissions of any newly
4354 created file.
4355
4356 * alloc.c (valid_pointer_p): Use pipe, not open.
4357 This fixes some permissions issues when debugging.
4358
4359 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4360 If fchown fails to set both uid and gid, try to set just gid,
4361 as that is sometimes allowed. Adjust the file's mode to eliminate
4362 setuid or setgid bits that are inappropriate if fchown fails.
4363
43642011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4365
4366 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4367 to compare Lisp_Objects.
4368 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4369 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4370 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4371
43722011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4373
4374 * lread.c (read_integer): Unread even EOF character.
4375 (read1): Likewise. Properly record start position of symbol.
4376
4377 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4378 symbol character follows.
4379
43802011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4381
4382 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4383 This works around a problem with the previous change to Fcopy_file.
4384 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4385 and without this change, GCC might complain about discarding
4386 fchown's return value.
4387
43882011-07-16 Juanma Barranquero <lekktu@gmail.com>
4389
4390 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4391
43922011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4393
4394 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4395
43962011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4397
4398 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4399 it's used from the C level.
4400
4401 * process.c: Use the same condition for POLL_FOR_INPUT in both
4402 keyboard.c and process.c (bug#1858).
4403
44042011-07-09 Lawrence Mitchell <wence@gmx.li>
4405
4406 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4407 (Fgnutls_boot): Use it.
4408
44092011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4410
4411 * doc.c (Fsubstitute_command_keys): Revert last change.
4412
44132011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4414
4415 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4416 quotes the next character, and doesn't affect other longer
4417 sequences (bug#8935).
4418
4419 * lread.c (syms_of_lread): Clarify that is isn't only
4420 `eval-buffer' and `eval-defun' that's affected by
4421 `lexical-binding' (bug#8460).
4422
44232011-07-15 Eli Zaretskii <eliz@gnu.org>
4424
4425 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4426 bidi redisplay when a line includes both an image and is truncated.
4427
44282011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4429
4430 Fix minor problems found by static checking.
4431 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4432 (elsz): Now a signed constant, not a size_t var. We prefer signed
4433 types to unsigned, to avoid integer comparison confusion. Without
4434 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4435 "cannot optimize loop, the loop counter may overflow", a symptom
4436 of the confusion.
4437 * indent.c (Fvertical_motion): Mark locals as initialized.
4438 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4439
44402011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4441
4442 * search.c (Fre_search_backward): Mention `case-fold-search' in
4443 all the re_search_* functions (bug#8138).
4444
4445 * keyboard.c (Fopen_dribble_file): Document when the file is
4446 closed (bug#8056).
4447
44482011-07-14 Eli Zaretskii <eliz@gnu.org>
4449
4450 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4451 bidi_cache_idx.
4452
4453 Support bidi reordering of display and overlay strings.
4454 * xdisp.c (compute_display_string_pos)
4455 (compute_display_string_end): Accept additional argument STRING.
4456 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4457 (reseat_to_string): Initialize bidi_it->string.s and
4458 bidi_it->string.schars.
4459 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4460 NULL (avoids a crash in bidi_paragraph_init).
4461 Initialize itb.string.lstring.
4462 (init_iterator): Call bidi_init_it only of a valid
4463 buffer position was specified. Initialize paragraph_embedding to
4464 L2R.
4465 (reseat_to_string): Initialize the bidi iterator.
4466 (display_string): If we need to ignore text properties of
4467 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4468 original value of -1 will not work with bidi.)
4469 (compute_display_string_pos): First arg is now struct
4470 `text_pos *'; all callers changed. Support display properties on
4471 Lisp strings.
4472 (compute_display_string_end): Support display properties on Lisp
4473 strings.
4474 (init_iterator, reseat_1, reseat_to_string): Initialize the
4475 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4476 when iterating on a string not from display properties).
4477 (compute_display_string_pos, compute_display_string_end):
4478 Fix calculation of the object to scan. Fixes an error when using
4479 arrow keys.
4480 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4481 base_level_stop; instead, set base_level_stop to BEGV.
4482 Fixes crashes in vertical-motion.
4483 (next_element_from_buffer): Improve commentary for when
4484 the iterator is before prev_stop.
4485 (init_iterator): Initialize bidi_p from the default value of
4486 bidi-display-reordering, not from buffer-local value. Use the
4487 buffer-local value only if initializing for buffer iteration.
4488 (handle_invisible_prop): Support invisible properties on strings
4489 that are being bidi-reordered.
4490 (set_iterator_to_next): Support bidi reordering of C strings and
4491 Lisp strings.
4492 (next_element_from_string): Support bidi reordering of Lisp
4493 strings.
4494 (handle_stop_backwards): Support Lisp strings as well.
4495 (display_string): Support display of R2L glyph rows.
4496 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4497 (init_iterator): Don't initialize it->bidi_p for strings
4498 here.
4499 (reseat_to_string): Initialize it->bidi_p for strings here.
4500 (next_element_from_string, next_element_from_c_string)
4501 (next_element_from_buffer): Add xassert's for correspondence
4502 between IT's object being iterated and it->bidi_it.string
4503 structure.
4504 (face_before_or_after_it_pos): Support bidi iteration.
4505 (next_element_from_c_string): Handle the case of the first string
4506 character that is not the first one in the visual order.
4507 (get_visually_first_element): New function, refactored from common
4508 parts of next_element_from_buffer, next_element_from_string, and
4509 next_element_from_c_string.
4510 (tool_bar_lines_needed, redisplay_tool_bar)
4511 (display_menu_bar): Force left-to-right direction. Add a FIXME
4512 comment for making that be controlled by a user option.
4513 (push_it, pop_it): Save and restore the state of the
4514 bidi iterator. Save and restore the bidi_p flag.
4515 (pop_it): Iterate out of display property for string iteration as
4516 well.
4517 (iterate_out_of_display_property): Support iteration over strings.
4518 (handle_single_display_spec): Set up it->bidi_it for iteration
4519 over a display string, and call bidi_init_it.
4520 (handle_single_display_spec, next_overlay_string)
4521 (get_overlay_strings_1, push_display_prop): Set up the bidi
4522 iterator for displaying display or overlay strings.
4523 (forward_to_next_line_start): Don't use the shortcut if
4524 bidi-iterating.
4525 (back_to_previous_visible_line_start): If handle_display_prop
4526 pushed the iterator stack, restore the internal state of the bidi
4527 iterator by calling bidi_pop_it same number of times.
4528 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4529 and we are bidi-iterating, don't decrement the iterator position;
4530 instead, set the first_elt flag in the bidi iterator, to produce
4531 the same effect.
4532 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4533 (push_display_prop): xassert that we are iterating a buffer.
4534 (push_it, pop_it): Save and restore paragraph_embedding member.
4535 (handle_single_display_spec, next_overlay_string)
4536 (get_overlay_strings_1, reseat_1, reseat_to_string)
4537 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4538 correctly. Don't assume unibyte strings are not bidi-reordered.
4539 (compute_display_string_pos)
4540 (compute_display_string_end): Fix handling the case of C string.
4541 (push_it, pop_it): Save and restore from_disp_prop_p.
4542 (handle_single_display_spec, push_display_prop): Set the
4543 from_disp_prop_p flag.
4544 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4545 (pop_it): Call iterate_out_of_display_property only if we are
4546 popping after iteration over a string that came from a display
4547 property. Fix a typo in popping stretch info. Add an assertion
4548 for verifying that the iterator position is in sync with the bidi
4549 iterator.
4550 (handle_single_display_spec, get_overlay_strings_1)
4551 (push_display_prop): Fix initialization of paragraph direction for
4552 string when that of the parent object is not yet determined.
4553 (reseat_1): Call bidi_init_it to resync the bidi
4554 iterator with IT's position. (Bug#7616)
4555 (find_row_edges): If ROW->start.pos gives position
4556 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4557 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4558 Reset the from_disp_prop_p flag.
4559 (SAVE_IT, RESTORE_IT): New macros.
4560 (pos_visible_p, face_before_or_after_it_pos)
4561 (back_to_previous_visible_line_start)
4562 (move_it_in_display_line_to, move_it_in_display_line)
4563 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4564 (try_scrolling, redisplay_window, display_line): Use them when
4565 saving a temporary copy of the iterator and restoring it back.
4566 (back_to_previous_visible_line_start, reseat_1)
4567 (init_iterator): Empty the bidi cache "stack".
4568 (move_it_in_display_line_to): If iterator ended up at
4569 EOL, but we never saw any buffer positions smaller than
4570 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4571 motion in bidi-reordered lines.
4572 (move_it_in_display_line_to): Record prev_method and prev_pos
4573 immediately before the call to set_iterator_to_next. Fixes cursor
4574 motion in bidi-reordered lines with stretch glyphs and strings
4575 displayed in margins. (Bug#8133) (Bug#8867)
4576 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4577 TO_CHARPOS.
4578 (pos_visible_p): Support positions in bidi-reordered lines.
4579 Save and restore bidi cache.
4580
4581 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4582 (bidi_paragraph_info): Delete unused struct.
4583 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4584 (bidi_cache_start): New variable.
4585 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4586 to zero.
4587 (bidi_cache_fetch_state, bidi_cache_search)
4588 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4589 (bidi_cache_find, bidi_peek_at_next_level)
4590 (bidi_level_of_next_char, bidi_find_other_level_edge)
4591 (bidi_move_to_visually_next): Compare cache index with
4592 bidi_cache_start rather than with zero.
4593 (bidi_fetch_char): Accept new argument STRING; all callers
4594 changed. Support iteration over a string. Support strings with
4595 display properties. Support unibyte strings. Fix the type of
4596 `len' according to what STRING_CHAR_AND_LENGTH expects.
4597 (bidi_paragraph_init, bidi_resolve_explicit_1)
4598 (bidi_resolve_explicit, bidi_resolve_weak)
4599 (bidi_level_of_next_char, bidi_move_to_visually_next):
4600 Support iteration over a string.
4601 (bidi_set_sor_type, bidi_resolve_explicit_1)
4602 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4603 can now be zero (for strings); special values 0 and -1 were
4604 changed to -1 and -2, respectively.
4605 (bidi_char_at_pos): New function.
4606 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4607 Call it instead of FETCH_MULTIBYTE_CHAR.
4608 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4609 initialized to valid values.
4610 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4611 values.
4612 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4613 the test for valid cached positions. Fix the logic for looking up
4614 the sentinel state in the cache. GCPRO the Lisp string we are
4615 iterating.
4616 (bidi_push_it, bidi_pop_it): New functions.
4617 (bidi_initialize): Initialize the bidi cache start stack pointer.
4618 (bidi_cache_ensure_space): New function, refactored from part of
4619 bidi_cache_iterator_state. Don't assume the required size is just
4620 one BIDI_CACHE_CHUNK away.
4621 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4622 (bidi_count_bytes, bidi_char_at_pos): New functions.
4623 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4624 always valid if bidi_cache_idx is valid.
4625 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4626 is valid if it's going to be used.
4627 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4628 (bidi_cache_fetch_state, bidi_cache_search)
4629 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4630 (bidi_cache_iterator_state, bidi_cache_find)
4631 (bidi_find_other_level_edge, bidi_cache_start_stack):
4632 All variables related to cache indices are now EMACS_INT.
4633
4634 * dispextern.h (struct bidi_string_data): New structure.
4635 (struct bidi_it): New member `string'. Make flag members be 1-bit
4636 fields, and put them last in the struct.
4637 (compute_display_string_pos, compute_display_string_end):
4638 Update prototypes.
4639 (bidi_push_it, bidi_pop_it): Add prototypes.
4640 (struct iterator_stack_entry): New members bidi_p,
4641 paragraph_embedding, and from_disp_prop_p.
4642 (struct it): Member bidi_p is now a bit field 1 bit wide.
4643 (bidi_shelve_cache, bidi_unshelve_cache):
4644 Declare prototypes.
4645
4646 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4647 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4648 and vector-like objects.
4649
4650 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4651 cache around display iteration.
4652
4653 * window.c (Fwindow_end, window_scroll_pixel_based)
4654 (displayed_window_lines, Frecenter): Save and restore the bidi
4655 cache around display iteration.
4656
46572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4658
4659 * editfns.c (Fdelete_region): Clarify the use of the named
4660 parameters (bug#6788).
4661
46622011-07-14 Martin Rudalics <rudalics@gmx.at>
4663
4664 * indent.c (Fvertical_motion): Set and restore w->pointm when
4665 saving and restoring the window's buffer (Bug#9006).
4666
46672011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4668
4669 * editfns.c (Fstring_to_char): Clarify just what is returned
4670 (bug#6576). Text by Eli Zaretskii.
4671
46722011-07-13 Juanma Barranquero <lekktu@gmail.com>
4673
4674 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4675
46762011-07-13 Eli Zaretskii <eliz@gnu.org>
4677
4678 * buffer.c (mmap_find): Fix a typo.
4679
46802011-07-13 Johan Bockgård <bojohan@gnu.org>
4681
4682 Fix execution of x selection hooks.
4683 * xselect.c (Qx_lost_selection_functions)
4684 (Qx_sent_selection_functions): New vars.
4685 (syms_of_xselect): DEFSYM them.
4686 (x_handle_selection_request): Pass Qx_sent_selection_functions
4687 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4688 (x_handle_selection_clear,x_clear_frame_selections):
4689 Pass Qx_lost_selection_functions rather than
4690 Vx_lost_selection_functions to Frun_hook_with_args.
4691
46922011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4693
4694 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4695 The old code sometimes used this field without initializing it.
4696
4697 * alloc.c (gc_sweep): Don't read past end of array.
4698 In theory, the old code could also have corrupted Emacs internals,
4699 though it'd be very unlikely.
4700
47012011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4702
4703 * character.c (Fcharacterp): Don't advertise optional ignored
4704 argument. (Bug#4026)
4705
47062011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4707
4708 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4709 key" (bug#4257).
4710
4711 * window.c (Fset_window_start): Doc fix (bug#4199).
4712 (Fset_window_hscroll): Ditto.
4713
47142011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4715
4716 Fix minor new problems caught by GCC 4.6.1.
4717 * term.c (init_tty): Remove unused local.
4718 * xsettings.c (store_monospaced_changed): Define this function only
4719 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4720 not used otherwise.
4721
47222011-07-12 Chong Yidong <cyd@stupidchicken.com>
4723
4724 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4725
47262011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4727
4728 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4729 are the mini-buffer and the echo area (bug#3320).
4730
4731 * term.c (init_tty): Remove support for supdup, c10 and perq
4732 terminals, which are no longer supported (bug#1482).
4733
47342011-07-10 Johan Bockgård <bojohan@gnu.org>
4735
4736 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4737
47382011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4739
4740 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4741 for non-popups (Bug#3642).
4742
47432011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4744
4745 * alloc.c (reset_malloc_hooks): Protoize.
4746 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4747 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4748 * cm.c (losecursor): Likewise.
4749 * data.c (fmod): Likewise.
4750 * dispnew.c (swap_glyphs_in_rows): Likewise.
4751 * emacs.c (memory_warning_signal): Likewise.
4752 * floatfns.c (float_error): Likewise.
4753 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4754 (otf_open, font_otf_capability, generate_otf_features)
4755 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4756 Likewise.
4757 * image.c (pbm_read_file): Likewise.
4758 * indent.c (string_display_width): Likewise.
4759 * intervals.c (check_for_interval, search_for_interval)
4760 (inc_interval_count, count_intervals, root_interval)
4761 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4762 * lread.c (defalias): Likewise.
4763 * ralloc.c (r_alloc_check): Likewise.
4764 * regex.c (set_image_of_range_1, set_image_of_range)
4765 (regex_grow_registers): Likewise.
4766 * sysdep.c (strerror): Likewise.
4767 * termcap.c (valid_filename_p, tprint, main): Likewise.
4768 * tparam.c (main): Likewise.
4769 * unexhp9k800.c (run_time_remap, save_data_space)
4770 (update_file_ptrs, read_header, write_header, calculate_checksum)
4771 (copy_file, copy_rest, display_header): Likewise.
4772 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4773 Likewise.
4774 * xdisp.c (check_it): Likewise.
4775 * xfaces.c (register_color, unregister_color, unregister_colors):
4776 Likewise.
4777 * xfns.c (print_fontset_result): Likewise.
4778 * xrdb.c (member, fatal, main): Likewise.
4779
47802011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4781
4782 Fix minor problems found by static checking (Bug#9031).
4783 * chartab.c (char_table_set_range, map_sub_char_table):
4784 Remove unused locals.
4785 (uniprop_table): Now static.
4786 * composite.c (_work_char): Remove unused static var.
4787
47882011-07-09 Juanma Barranquero <lekktu@gmail.com>
4789
4790 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4791
47922011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4793
4794 * gtkutil.c (qttip_cb): Remove code without function.
4795
47962011-07-09 Eli Zaretskii <eliz@gnu.org>
4797
4798 * w32.c (pthread_sigmask): New stub.
4799
48002011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4801
4802 Use pthread_sigmask, not sigprocmask (Bug#9010).
4803 sigprocmask is portable only for single-threaded applications, and
4804 Emacs can be multi-threaded when it uses GTK.
4805 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4806 (LIBES): Use it.
4807 * callproc.c (Fcall_process):
4808 * process.c (create_process):
4809 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4810 Use pthread_sigmask, not sigprocmask.
4811
48122011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4813
4814 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4815 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4816 wrong (Bug#8591).
4817
48182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4819
4820 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4821 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4822 (xg_hide_tooltip): Fix comment.
4823
4824 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4825 in registerServicesMenuSendTypes.
4826 (validRequestorForSendType): Don't check ns_return_types.
4827
4828 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4829 ns_return_type.
4830
48312011-07-08 Jason Rumney <jasonr@gnu.org>
4832
4833 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4834 SH_SHOW for hidden windows (Bug#5482).
4835
4836 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4837 frame struct members of non-existent frames (Bug#6284).
4838
48392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4840
4841 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4842 variable firstTime not needed on OSX >= 10.6.
4843 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4844 >= 10.5. Use setKnobProportion, setDoubleValue.
4845
4846 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4847 (MAC_OS_X_VERSION_10_5): Define if not defined.
4848 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4849 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4850 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4851
4852 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4853 cString and lossyCString on OSX >= 10.4
4854
4855 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4856 sizeToFit on OSX >= 10.2.
4857
4858 * nsimage.m (allocInitFromFile): Don't use deprecated method
4859 bestRepresentationForDevice on OSX >= 10.6.
4860
4861 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4862 to avoid warning.
4863
4864 * emacs.c: Declare unexec_init_emacs_zone.
4865
4866 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4867
4868 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4869
4870 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4871 on svcsMenu (Bug#8842).
4872
4873 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4874 ns_return_types.
4875 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4876
4877 * nsterm.m (QUTF8_STRING): Declare.
4878 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4879 (validRequestorForSendType): Return type is (id).
4880 Change indexOfObjectIdenticalTo to indexOfObject.
4881 Check if we have local selection before returning self (Bug#8842).
4882 (writeSelectionToPasteboard): Put local selection into paste board
4883 if we have a local selection (Bug#8842).
4884 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4885
4886 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4887 (ns_get_local_selection): Declare.
4888
48892011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4890
4891 * keymap.c (describe_map_tree): Don't insert a double newline at
4892 the end of the buffer (bug#1169) and return whether we inserted
4893 something.
4894
4895 * callint.c (Fcall_interactively): Change "reading args" to
4896 "providing args" to try to clarify what it does (bug#1010).
4897
48982011-07-07 Kenichi Handa <handa@m17n.org>
4899
4900 * composite.c (composition_compute_stop_pos): Ignore a static
4901 composition starting before CHARPOS (Bug#8915).
4902
4903 * xdisp.c (handle_composition_prop): Likewise.
4904
49052011-07-07 Eli Zaretskii <eliz@gnu.org>
4906
4907 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4908 (Bug#9015)
4909
49102011-07-07 Kenichi Handa <handa@m17n.org>
4911
4912 * character.h (unicode_category_t): New enum type.
4913
4914 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4915 (Qchar_code_property_table): New variable.
4916 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4917 (UNIPROP_COMPRESSED_FORM_P): New macros.
4918 (char_table_ascii): Uncompress the compressed values.
4919 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4920 Uncompress the compressed values.
4921 (sub_char_table_ref_and_range): Likewise.
4922 (char_table_ref_and_range): Uncompress the compressed values.
4923 (sub_char_table_set): New arg is_uniprop. Callers changed.
4924 Uncompress the compressed values.
4925 (sub_char_table_set_range): Args changed. Callers changed.
4926 (char_table_set_range): Adjuted for the above change.
4927 (map_sub_char_table): Delete args default_val and parent. Add arg
4928 top. Give decoded values to a Lisp function.
4929 (map_char_table): Adjust for the above change. Give decoded
4930 values to a Lisp function. Gcpro more variables.
4931 (uniprop_table_uncompress)
4932 (uniprop_decode_value_run_length): New functions.
4933 (uniprop_decoder, uniprop_decoder_count): New variables.
4934 (uniprop_get_decoder, uniprop_encode_value_character)
4935 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4936 New functions.
4937 (uniprop_encoder, uniprop_encoder_count): New variables.
4938 (uniprop_get_encoder, uniprop_table)
4939 (Funicode_property_table_internal, Fget_unicode_property_internal)
4940 (Fput_unicode_property_internal): New functions.
4941 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4942 Sunicode_property_table_internal, Sget_unicode_property_internal,
4943 and Sput_unicode_property_internal. Defvar_lisp
4944 char-code-property-alist.
4945
4946 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4947 Vunicode_category_table.
4948
4949 * font.c (font_range): Adjust for the change of
4950 Vunicode_category_table.
4951
49522011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4953
4954 * m/iris4d.h: Remove file, move contents ...
4955 * s/irix6-5.h: ... here.
4956
49572011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4958
4959 Remove unportable assumption about struct layout (Bug#8884).
4960 * alloc.c (mark_buffer):
4961 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4962 (clone_per_buffer_values): Don't assume that
4963 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4964 This isn't true in general, and it's particularly not true
4965 if Emacs is configured with --with-wide-int.
4966 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4967 New macros, used in the buffer.c change.
4968
49692011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4970
4971 * xsettings.c: Use both GConf and GSettings if both are available.
4972 (store_config_changed_event): Add comment.
4973 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4974 (store_tool_bar_style_changed): New functions.
4975 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4976 (struct xsettings): Move font inside HAVE_XFT.
4977 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4978 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4979 Move inside HAVE_XFT.
4980 (something_changed_gsettingsCB): Rename from something_changedCB.
4981 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4982 also.
4983 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4984 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4985 (something_changed_gconfCB): Rename from something_changedCB.
4986 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4987 (parse_settings): Move check for font inside HAVE_XFT.
4988 (read_settings, apply_xft_settings): Add comment.
4989 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4990 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4991 call store_font_name_changed.
4992 (xft_settings_event): Add comment.
4993 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4994 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4995 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4996 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4997 (xsettings_initialize): Call init_gsettings last.
4998 (xsettings_get_system_font, xsettings_get_system_normal_font):
4999 Add comment.
5000
50012011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5002
5003 Random fixes. E.g., (random) never returned negative values.
5004 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5005 subseconds part to the entropy, as that's a bit more random.
5006 Prefer signed to unsigned, since the signedness doesn't matter and
5007 in general we prefer signed. When given a limit, use a
5008 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5009 latter isn't right if USE_2_TAGS_FOR_INTS.
5010 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5011 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5012
50132011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5014
5015 * textprop.c (text_property_stickiness):
5016 Obey Vtext_property_default_nonsticky.
5017 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5018 * w32fns.c (syms_of_w32fns):
5019 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5020
50212011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5022
5023 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5024 This is more efficient than Ffile_directory_p and avoids a minor race.
5025
50262011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5027
5028 * buffer.c (Foverlay_put): Say what the return value is
5029 (bug#7835).
5030
5031 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5032 is a directory before asking whether to use the file name
5033 (bug#7564).
5034 (barf_or_query_if_file_exists): Make the "File is a directory"
5035 error be more correct.
5036
5037 * fns.c (Frequire): Remove the mention of the .gz files, since
5038 that's installation-specific, but keep the mention of
5039 `get-load-suffixes'.
5040
50412011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5042
5043 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5044 Report string overflow if the output is too long.
5045
50462011-07-04 Juanma Barranquero <lekktu@gmail.com>
5047
5048 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5049 (syms_of_gnutls): Remove duplicate DEFSYM for
5050 Qgnutls_bootprop_verify_hostname_error, an error for
5051 Qgnutls_bootprop_verify_error (which is no longer used).
5052
5053 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5054 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5055 Also (re)move comments that are misplaced or no longer relevant.
5056
50572011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5058
5059 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5060
50612011-07-03 Chong Yidong <cyd@stupidchicken.com>
5062
5063 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5064 and background color parameters if they have been changed.
5065
50662011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5067
5068 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5069
50702011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5071
5072 * xsettings.c (SYSTEM_FONT): Define only when used.
5073 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5074
5075 * keymap.c (access_keymap_1): Now static.
5076
50772011-07-02 Chong Yidong <cyd@stupidchicken.com>
5078
5079 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5080 leave any prefix arg for the up event (Bug#1586).
5081
50822011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5083
5084 * lread.c (syms_of_lread): Mention single symbols defined by
5085 `defvar' or `defconst' (bug#7154).
5086
5087 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5088 (Frequire): Mention get-load-suffixes.
5089
50902011-07-02 Martin Rudalics <rudalics@gmx.at>
5091
5092 * window.h (window): Remove clone_number slot.
5093 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5094 Remove.
5095 (make_parent_window, make_window, saved_window)
5096 (Fset_window_configuration, save_window_save): Don't deal with
5097 clone numbers.
5098 * buffer.c (Qclone_number): Remove declaration.
5099 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5100
51012011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5102
5103 Add multiple inheritance to keymaps.
5104 * keymap.c (Fmake_composed_keymap): New function.
5105 (Fset_keymap_parent): Simplify.
5106 (fix_submap_inheritance): Remove.
5107 (access_keymap_1): New function extracted from access_keymap to handle
5108 embedded parents and handle lists of maps.
5109 (access_keymap): Use it.
5110 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5111 (Fcopy_keymap): Handle embedded parents.
5112 (Fcommand_remapping, define_as_prefix): Simplify.
5113 (Fkey_binding): Simplify.
5114 (syms_of_keymap): Move minibuffer-local-completion-map,
5115 minibuffer-local-filename-completion-map,
5116 minibuffer-local-must-match-map, and
5117 minibuffer-local-filename-must-match-map to Elisp.
5118 (syms_of_keymap): Defsubr make-composed-keymap.
5119 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5120 (parse_menu_item): Trivial simplification.
5121
51222011-07-01 Glenn Morris <rgm@gnu.org>
5123
5124 * Makefile.in (SETTINGS_LIBS): Fix typo.
5125
51262011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5127
5128 * coding.c (Fencode_coding_string): Record the last coding system
5129 used, as the function doc string says (bug#8738).
5130
51312011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5132
5133 * xsettings.c (store_monospaced_changed): Take new font as arg and
5134 check for change against current_mono_font.
5135 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5136 (emacs_settings_constructor, emacs_settings_get_property)
5137 (emacs_settings_set_property, emacs_settings_class_init)
5138 (emacs_settings_init, gsettings_obj): Remove.
5139 (something_changedCB): New function for HAVE_GSETTINGS.
5140 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5141 with value as argument.
5142 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5143 g_settings_new (Bug#8967). Do not create gsettings_obj.
5144 Remove calls to g_settings_bind. Connect something_changedCB to
5145 "changed".
5146
5147 * xgselect.c: Add defined (HAVE_GSETTINGS).
5148 (xgselect_initialize): Ditto.
5149
5150 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5151 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5152 xg_select.
5153
51542011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5155
5156 * eval.c (struct backtrace): Simplify and port the data structure.
5157 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5158 signed bit field, as this assumption is not portable and it makes
5159 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5160 "char debug_on_exit : 1" as this is not portable either; instead,
5161 use the portable "unsigned int debug_on_exit : 1". Remove unused
5162 member evalargs. Remove obsolete comments about cc bombing out.
5163
51642011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5165
5166 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5167 Let HAVE_GSETTINGS override HAVE_GCONF.
5168 (store_monospaced_changed): New function.
5169 (EMACS_SETTINGS): A new type derived from GObject to handle
5170 GSettings notifications.
5171 (emacs_settings_constructor, emacs_settings_get_property)
5172 (emacs_settings_set_property, emacs_settings_class_init):
5173 New functions.
5174 (gsettings_client, gsettings_obj): New variables.
5175 (GSETTINGS_SCHEMA): New define.
5176 (something_changedCB): Call store_monospaced_changed.
5177 (init_gsettings): New function.
5178 (xsettings_initialize): Call init_gsettings.
5179 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5180 to NULL.
5181
5182 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5183 GCONF_CFLAGS/LIBS.
5184
51852011-06-29 Martin Rudalics <rudalics@gmx.at>
5186
5187 * window.c (resize_root_window, grow_mini_window)
5188 (shrink_mini_window): Rename Qresize_root_window to
5189 Qwindow_resize_root_window and Qresize_root_window_vertically to
5190 Qwindow_resize_root_window_vertically.
5191
51922011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5193
5194 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5195
51962011-06-27 Juanma Barranquero <lekktu@gmail.com>
5197
5198 * makefile.w32-in: Redesign dependencies so they reflect more
5199 clearly which files are directly included by each source file,
5200 and not through other includes.
5201
52022011-06-27 Martin Rudalics <rudalics@gmx.at>
5203
5204 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5205 (sort_overlays, overlay_strings): When an overlay's clone number
5206 matches the window's clone number process the overlay even if
5207 the overlay's window property doesn't match the current window.
5208
5209 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5210 (Fwindow_hchild): Rename to Fwindow_left_child.
5211 (Fwindow_next): Rename to Fwindow_next_sibling.
5212 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5213 (resize_window_check): Rename to window_resize_check.
5214 (resize_window_apply): Rename to window_resize_apply.
5215 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5216 (Fdelete_other_windows_internal, resize_frame_windows)
5217 (Fsplit_window_internal, Fdelete_window_internal)
5218 (grow_mini_window, shrink_mini_window)
5219 (Fresize_mini_window_internal): Fix callers accordingly.
5220
52212011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5222
5223 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5224 (emacs_fixed_set_min_size): Remove.
5225 (emacs_fixed_new): Take frame as argument.
5226
5227 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5228 (_EmacsFixedPrivate): Remove minwidth/height.
5229 Add struct frame *f.
5230 (emacs_fixed_init): Initialize priv->f.
5231 (get_parent_class, emacs_fixed_set_min_size): Remove.
5232 (emacs_fixed_new): Set priv->f to argument.
5233 (emacs_fixed_get_preferred_width)
5234 (emacs_fixed_get_preferred_height): Use min_width/height from
5235 frames size_hint to set minimum and natural (Bug#8919).
5236 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5237 and use min_width/height from frames size_hint to set
5238 min_width/height (Bug#8919).
5239
5240 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5241 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5242 Fix indentation.
5243
52442011-06-26 Eli Zaretskii <eliz@gnu.org>
5245
5246 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5247 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5248 called at ZV.
5249
52502011-06-26 Chong Yidong <cyd@stupidchicken.com>
5251
5252 * process.c (wait_reading_process_output): Bypass select if
5253 waiting for a cell while ignoring keyboard input, and input is
5254 pending. Suggested by Jan Djärv (Bug#8869).
5255
52562011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5257
5258 Use gnulib's dup2 module instead of rolling our own.
5259 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5260
52612011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5262
5263 * dispnew.c (scrolling_window): Before scrolling, turn off a
5264 mouse-highlight in the window being scrolled.
5265
52662011-06-24 Juanma Barranquero <lekktu@gmail.com>
5267
5268 Move DEFSYM to lisp.h and use everywhere.
5269
5270 * character.h (DEFSYM): Move declaration...
5271 * lisp.h (DEFSYM): ...here.
5272
5273 * gnutls.c:
5274 * minibuf.c:
5275 * w32menu.c:
5276 * w32proc.c:
5277 * w32select.c: Don't include character.h.
5278
5279 * alloc.c (syms_of_alloc):
5280 * buffer.c (syms_of_buffer):
5281 * bytecode.c (syms_of_bytecode):
5282 * callint.c (syms_of_callint):
5283 * casefiddle.c (syms_of_casefiddle):
5284 * casetab.c (init_casetab_once):
5285 * category.c (init_category_once, syms_of_category):
5286 * ccl.c (syms_of_ccl):
5287 * cmds.c (syms_of_cmds):
5288 * composite.c (syms_of_composite):
5289 * dbusbind.c (syms_of_dbusbind):
5290 * dired.c (syms_of_dired):
5291 * dispnew.c (syms_of_display):
5292 * doc.c (syms_of_doc):
5293 * editfns.c (syms_of_editfns):
5294 * emacs.c (syms_of_emacs):
5295 * eval.c (syms_of_eval):
5296 * fileio.c (syms_of_fileio):
5297 * fns.c (syms_of_fns):
5298 * frame.c (syms_of_frame):
5299 * fringe.c (syms_of_fringe):
5300 * insdel.c (syms_of_insdel):
5301 * keymap.c (syms_of_keymap):
5302 * lread.c (init_obarray, syms_of_lread):
5303 * macros.c (syms_of_macros):
5304 * msdos.c (syms_of_msdos):
5305 * print.c (syms_of_print):
5306 * process.c (syms_of_process):
5307 * search.c (syms_of_search):
5308 * sound.c (syms_of_sound):
5309 * syntax.c (init_syntax_once, syms_of_syntax):
5310 * terminal.c (syms_of_terminal):
5311 * textprop.c (syms_of_textprop):
5312 * undo.c (syms_of_undo):
5313 * w32.c (globals_of_w32):
5314 * window.c (syms_of_window):
5315 * xdisp.c (syms_of_xdisp):
5316 * xfaces.c (syms_of_xfaces):
5317 * xfns.c (syms_of_xfns):
5318 * xmenu.c (syms_of_xmenu):
5319 * xsettings.c (syms_of_xsettings):
5320 * xterm.c (syms_of_xterm): Use DEFSYM.
5321
53222011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5323
5324 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5325
53262011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5327
5328 Integer and buffer overflow fixes (Bug#8873).
5329
5330 * print.c (printchar, strout): Check for string overflow.
5331 (PRINTPREPARE, printchar, strout):
5332 Don't set size unless allocation succeeds.
5333
5334 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5335 for sizes. Check for string overflow more accurately.
5336 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5337
5338 * macros.c: Integer and buffer overflow fixes.
5339 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5340 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5341 Use ptrdiff_t, not int, for sizes.
5342 Don't increment bufsize until after realloc succeeds.
5343 Check for size-calculation overflow.
5344 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5345
5346 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5347
5348 * lread.c: Integer overflow fixes.
5349 (read_integer): Radix is now EMACS_INT, not int,
5350 to improve quality of diagnostics for out-of-range radices.
5351 Calculate buffer size correctly for out-of-range radices.
5352 (read1): Check for integer overflow in radices, and in
5353 read-circle numbers.
5354 (read_escape): Avoid int overflow.
5355 (Fload, openp, read_buffer_size, read1)
5356 (substitute_object_recurse, read_vector, read_list, map_obarray):
5357 Use ptrdiff_t, not int, for sizes.
5358 (read1): Use EMACS_INT, not int, for sizes.
5359 Check for size overflow.
5360
5361 * image.c (cache_image): Check for size arithmetic overflow.
5362
5363 * lread.c: Integer overflow issues.
5364 (saved_doc_string_size, saved_doc_string_length)
5365 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5366 Now ptrdiff_t, not int.
5367 (read1): Don't assume doc string length fits in int. Check for
5368 out-of-range doc string lengths.
5369 (read_list): Don't assume file position fits in int.
5370 (read_escape): Check for hex character overflow.
5371
53722011-06-22 Leo Liu <sdl.web@gmail.com>
5373
5374 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5375 Move to minibuffer.el.
5376
53772011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5378
5379 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5380 The following patches are for when GLYPH_DEBUG && !XASSERT.
5381 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5382 * dispnew.c (flush_stdout):
5383 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5384 Mark as externally visible.
5385 * dispnew.c (check_window_matrix_pointers): Now static.
5386 * dispnew.c (window_to_frame_vpos):
5387 * xfns.c (unwind_create_frame):
5388 * xterm.c (x_check_font): Remove unused local.
5389 * scroll.c (CHECK_BOUNDS):
5390 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5391 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5392 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5393 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5394 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5395 Now static.
5396 (debug_method_add): Use va_list and vsprintf rather than relying
5397 on undefined behavior with wrong number of arguments.
5398 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5399 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5400 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5401 since we're not interested in debugging glyphs with old libraries.
5402 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5403 GCC 4.6.0's static checking.
5404
54052011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5406
5407 Integer overflow and signedness fixes (Bug#8873).
5408 A few related buffer overrun fixes, too.
5409
5410 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5411
5412 * dispextern.h (struct face.stipple):
5413 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5414 (x_bitmap_mask, x_allocate_bitmap_record)
5415 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5416 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5417 (x_create_bitmap_from_xpm_data):
5418 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5419 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5420 (.bitmaps_last):
5421 * xfaces.c (load_pixmap):
5422 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5423 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5424 (.bitmaps_last, struct x_output.icon_bitmap):
5425 Use ptrdiff_t, not int, for bitmap indexes.
5426 (x_allocate_bitmap_record): Check for size overflow.
5427 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5428
5429 Use ptrdiff_t, not int, for overlay counts.
5430 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5431 * editfns.c (overlays_around, get_pos_property):
5432 * textprop.c (get_char_property_and_overlay):
5433 * xdisp.c (next_overlay_change, note_mouse_highlight):
5434 * xfaces.c (face_at_buffer_position):
5435 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5436 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5437 (Fnext_overlay_change, Fprevious_overlay_change)
5438 (mouse_face_overlay_overlaps, Foverlays_in):
5439 Use ptrdiff_t, not int, for sizes.
5440 (overlays_at, overlays_in): Check for size-calculation overflow.
5441
5442 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5443
5444 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5445 (x_session_initialize): Do not assume string length fits in int.
5446
5447 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5448 This is unlikely, but can occur if DPI is outlandish.
5449
5450 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5451 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5452
5453 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5454 * xrdb.c (magic_file_p, search_magic_path):
5455 Omit last arg SUFFIX; it was always 0. All callers changed.
5456 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5457
5458 * xfont.c (xfont_match): Avoid need for strlen.
5459
5460 * xfns.c: Don't assume strlen fits in int.
5461 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5462
5463 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5464 not unsigned long, as we prefer signed integers. All callers changed.
5465 Detect integer overflow in repeat count.
5466 (message_dolog): Don't assume print length fits in 39 bytes.
5467 (display_mode_element): Don't assume strlen fits in int.
5468
5469 * termcap.c: Don't assume sizes fit in int and never overflow.
5470 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5471 (gobble_line): Check for size-calculation overflow.
5472
5473 * minibuf.c (Fread_buffer):
5474 * lread.c (intern, intern_c_string):
5475 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5476 Don't assume string length fits in int.
5477
5478 * keyboard.c (parse_tool_bar_item):
5479 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5480
5481 * font.c: Don't assume string length fits in int.
5482 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5483 Use ptrdiff_t, not int.
5484 (font_intern_prop): Don't assume string length fits in int.
5485 Don't assume integer property fits in fixnum.
5486 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5487
5488 * filelock.c: Fix some buffer overrun and integer overflow issues.
5489 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5490 Reformulate so as not to need the command string.
5491 Invoke gzip -cd rather than gunzip, as it's more portable.
5492 (lock_info_type, lock_file_1, lock_file):
5493 Don't assume pid_t and time_t fit in unsigned long.
5494 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5495 (current_lock_owner): Prefer signed type for sizes.
5496 Use memcpy, not strncpy, where memcpy is what is really wanted.
5497 Don't assume (via atoi) that time_t and pid_t fit in int.
5498 Check for time_t and/or pid_t out of range, e.g., via a network share.
5499 Don't alloca where an auto var works fine.
5500
5501 * fileio.c: Fix some integer overflow issues.
5502 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5503 Don't assume string length fits in int.
5504 (directory_file_name): Don't assume string length fits in long.
5505 (make_temp_name): Don't assume pid fits in int, or that its print
5506 length is less than 20.
5507
5508 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5509
5510 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5511
5512 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5513
5514 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5515 We prefer signed integers, even for size calculations.
5516
5517 * emacs.c: Don't assume string length fits in 'int'.
5518 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5519 (main): Don't invoke strlen when not needed.
5520
5521 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5522 (XD_DEBUG_MESSAGE): Don't waste a byte.
5523
5524 * callproc.c (getenv_internal_1, getenv_internal)
5525 (Fgetenv_internal):
5526 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5527
5528 * lread.c (invalid_syntax): Omit length argument.
5529 All uses changed. This doesn't fix a bug, but it simplifies the
5530 code away from its former Hollerith-constant appearance, and it's
5531 one less 'int' to worry about when looking at integer-overflow issues.
5532 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5533
5534 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5535 This didn't break anything, but it didn't help either.
5536 It's confusing to put a bogus integer in a place where the actual
5537 value does not matter.
5538 (LIST_END_P): Remove unused macro and its bogus comment.
5539 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5540
5541 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5542 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5543 implementation.
5544 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5545 We prefer signed types, and the value cannot exceed the EMACS_INT
5546 range anyway (because otherwise the length would not be representable).
5547 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5548 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5549 This avoids a GCC warning when WIDE_EMACS_INT.
5550
5551 * indent.c (sane_tab_width): New function.
5552 (current_column, scan_for_column, Findent_to, position_indentation)
5553 (compute_motion): Use it. This is just for clarity.
5554 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5555
5556 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5557
5558 * lisp.h (lint_assume): New macro.
5559 * composite.c (composition_gstring_put_cache):
5560 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5561
5562 * editfns.c, insdel.c:
5563 Omit unnecessary forward decls, to simplify future changes.
5564
5565 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5566
5567 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5568
5569 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5570 Use much-faster test for byte-length change.
5571 Don't assume string byte-length fits in 'int'.
5572 Check that character arg fits in 'int'.
5573 (mapcar1): Declare byte as byte, for clarity.
5574
5575 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5576
5577 * fns.c (concat): Catch string overflow earlier.
5578 Do not rely on integer wraparound.
5579
5580 * dispextern.h (struct it.overlay_strings_charpos)
5581 (struct it.selective): Now EMACS_INT, not int.
5582 * xdisp.c (forward_to_next_line_start)
5583 (back_to_previous_visible_line_start)
5584 (reseat_at_next_visible_line_start, next_element_from_buffer):
5585 Don't arbitrarily truncate the value of 'selective' to int.
5586
5587 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5588
5589 * composite.c: Don't truncate sizes to 'int'.
5590 (composition_gstring_p, composition_reseat_it)
5591 (composition_adjust_point): Use EMACS_INT, not int.
5592 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5593 not EMACS_UINT, for indexes.
5594
5595 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5596
5597 * buffer.c: Include <verify.h>.
5598 (struct sortvec.priority, struct sortstr.priority):
5599 Now EMACS_INT, not int.
5600 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5601 (struct sortstr.size, record_overlay_string)
5602 (struct sortstrlist.size, struct sortlist.used):
5603 Don't truncate size to int.
5604 (record_overlay_string): Check for size-calculation overflow.
5605 (init_buffer_once): Check at compile-time, not run-time.
5606
56072011-06-22 Jim Meyering <meyering@redhat.com>
5608
5609 Don't leak an XBM-image-sized buffer
5610 * image.c (xbm_load): Free the image buffer after using it.
5611
56122011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5613
5614 Port to Sun C.
5615 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5616 that Sun C diagnosed.
5617 * fns.c (secure_hash): Fix pointer signedness issue.
5618 * intervals.c (static_offset_intervals): New function.
5619 (offset_intervals): Use it.
5620
56212011-06-21 Leo Liu <sdl.web@gmail.com>
5622
5623 * deps.mk (fns.o):
5624 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5625 sha512.h.
5626
5627 * fns.c (secure_hash): Rename from crypto_hash_function and change
5628 the first arg to accept symbols.
5629 (Fsecure_hash): New primitive.
5630 (syms_of_fns): New symbols.
5631
56322011-06-20 Deniz Dogan <deniz@dogan.se>
5633
5634 * process.c (Fset_process_buffer): Clarify return value in
5635 docstring.
5636
56372011-06-18 Chong Yidong <cyd@stupidchicken.com>
5638
5639 * dispnew.c (add_window_display_history): Use BVAR.
5640
5641 * xdisp.c (debug_method_add): Use BVAR.
5642 (check_window_end, dump_glyph_matrix, dump_glyph)
5643 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5644
5645 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5646 Likewise.
5647
5648 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5649 check till after the cache is created in init_frame_faces.
5650
56512011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5652
5653 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5654
56552011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5656
5657 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5658 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5659 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5660
5661 Improve buffer-overflow checking (Bug#8873).
5662 * fileio.c (Finsert_file_contents):
5663 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5664 Remove the old (too-loose) buffer overflow checks.
5665 They weren't needed, since make_gap checks for buffer overflow.
5666 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5667 The old code merely checked for Emacs fixnum overflow, and relied
5668 on undefined (wraparound) behavior. The new code avoids undefined
5669 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5670
5671 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5672 Tune. Don't use wider integers than needed. Don't use alloca.
5673 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5674
5675 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5676
5677 * insdel.c, lisp.h (buffer_overflow): New function.
5678 (insert_from_buffer_1, replace_range, replace_range_2):
5679 * insdel.c (make_gap_larger):
5680 * editfns.c (Finsert_char):
5681 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5682
5683 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5684
56852011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5686
5687 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5688
5689 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5690 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5691
5692 * fileio.c: Don't assume EMACS_INT fits in off_t.
5693 (emacs_lseek): New static function.
5694 (Finsert_file_contents, Fwrite_region): Use it.
5695 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5696
5697 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5698
5699 * fns.c: Don't overflow int when computing a list length.
5700 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5701 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5702 truncation on 64-bit hosts. Check for QUIT every
5703 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5704 faster and is responsive enough.
5705 (Flength): Report an error instead of overflowing an integer.
5706 (Fsafe_length): Return a float if the value is not representable
5707 as a fixnum. This shouldn't happen except in contrived situations.
5708 (Fnthcdr, Fsort): Don't assume list length fits in int.
5709 (Fcopy_sequence): Don't assume vector length fits in int.
5710
5711 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5712 (header_size, word_size): New constants.
5713 (allocate_vectorlike): Don't check size overflow here.
5714 (allocate_vector): Check it here instead, since this is the only
5715 caller of allocate_vectorlike that could cause overflow.
5716 Check that the new vector's length is representable as a fixnum.
5717
5718 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5719 The previous code was bogus. For example, next_almost_prime (32)
5720 returned 39, which is undesirable as it is a multiple of 3; and
5721 next_almost_prime (24) returned 25, which is a multiple of 5 so
5722 why was the code bothering to check for multiples of 7?
5723
5724 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5725
5726 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5727
5728 Variadic C functions now count arguments with ptrdiff_t.
5729 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5730 Back then I didn't know that the Emacs coding style prefers signed int.
5731 Also, in the meantime I found a few more instances where arguments
5732 were being counted with int, which may truncate counts on 64-bit
5733 machines, or EMACS_INT, which may be unnecessarily wide.
5734 * lisp.h (struct Lisp_Subr.function.aMANY)
5735 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5736 Arg counts are now ptrdiff_t, not size_t.
5737 All variadic functions and their callers changed accordingly.
5738 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5739 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5740 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5741 * callint.c (Fcall_interactively): Check arg count for overflow,
5742 to avoid potential buffer overrun. Use signed char, not 'int',
5743 for 'varies' array, so that we needn't bother to check its size
5744 calculation for overflow.
5745 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5746 * eval.c (apply_lambda):
5747 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5748 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5749 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5750
5751 * callint.c (Fcall_interactively): Don't use index var as event count.
5752
5753 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5754 * mem-limits.h (SIZE): Remove; no longer used.
5755
5756 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5757
5758 Remove unnecessary casts.
5759 * xterm.c (x_term_init):
5760 * xfns.c (x_set_border_pixel):
5761 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5762 These aren't needed now that we assume ANSI C.
5763
5764 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5765 It's more likely to cause problems (due to unsigned overflow)
5766 than to cure them.
5767
5768 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5769
5770 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5771
5772 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5773
5774 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5775
5776 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5777
5778 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5779
5780 GLYPH_CODE_FACE returns EMACS_INT, not int.
5781 * dispextern.h (merge_faces):
5782 * xfaces.c (merge_faces):
5783 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5784 Don't assume EMACS_INT fits in int.
5785
5786 * character.h (CHAR_VALID_P): Remove unused parameter.
5787 * fontset.c, lisp.h, xdisp.c: All uses changed.
5788
5789 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5790
5791 * fns.c (concat): Minor tuning based on overflow analysis.
5792 This doesn't fix any bugs. Use int to hold character, instead
5793 of constantly refetching from Emacs object. Use XFASTINT, not
5794 XINT, for value known to be a character. Don't bother comparing
5795 a single byte to 0400, as it's always less.
5796
5797 * floatfns.c (Fexpt):
5798 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5799
5800 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5801 for characters.
5802
5803 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5804
5805 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5806 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5807 incorrectly succeed when S was a string, because 4294967386 was
5808 truncated before it was used.
5809
5810 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5811 Otherwise, an out-of-range integer could cause undefined behavior
5812 on a 64-bit host.
5813
5814 * composite.c: Use int, not EMACS_INT, for characters.
5815 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5816 EMACS_INT, for values that are known to be in character range.
5817 This doesn't fix any bugs but is the usual style inside Emacs and
5818 may generate better code on 32-bit machines.
5819
5820 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5821 This is for reasons similar to the recent CHAR_STRING fix.
5822 * charset.c (Fencode_char): Check that character arg is actually
5823 a character. Pass an int to ENCODE_CHAR.
5824 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5825 wider than 'int', as a compile-time check to prevent future regressions
5826 in this area.
5827
5828 * character.c (char_string): Remove unnecessary casts.
5829
5830 Make sure a 64-bit char is never passed to CHAR_STRING.
5831 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5832 by silently ignoring the top 32 bits, allowing some values
5833 that were far too large to be valid characters.
5834 * character.h: Include <verify.h>.
5835 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5836 arguments are no wider than unsigned, as a compile-time check
5837 to prevent future regressions in this area.
5838 * data.c (Faset):
5839 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5840 (Fsubst_char_in_region):
5841 * fns.c (concat):
5842 * xdisp.c (decode_mode_spec_coding):
5843 Adjust to CHAR_STRING's new requirement.
5844 * editfns.c (Finsert_char, Fsubst_char_in_region):
5845 * fns.c (concat): Check that character args are actually
5846 characters. Without this test, these functions did the wrong
5847 thing with wildly out-of-range values on 64-bit hosts.
5848
5849 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5850 These casts should not be needed on 32-bit hosts, either.
5851 * keyboard.c (read_char):
5852 * lread.c (Fload): Remove casts to unsigned.
5853
5854 * lisp.h (UNSIGNED_CMP): New macro.
5855 This fixes comparison bugs on 64-bit hosts.
5856 (ASCII_CHAR_P): Use it.
5857 * casefiddle.c (casify_object):
5858 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5859 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5860 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5861 * dispextern.h (FACE_FROM_ID):
5862 * keyboard.c (read_char): Use UNSIGNED_CMP.
5863
5864 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5865 not to EMACS_INT, to avoid GCC warning.
5866
5867 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5868
5869 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5870 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5871 isn't needed on 32-bit machines.
5872
5873 * buffer.c (Fgenerate_new_buffer_name):
5874 Use EMACS_INT for count, not int.
5875 (advance_to_char_boundary): Return EMACS_INT, not int.
5876
5877 * data.c (Qcompiled_function): Now static.
5878
5879 * window.c (window_body_lines): Now static.
5880
5881 * image.c (gif_load): Rename local to avoid shadowing.
5882
5883 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5884 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5885 * alloc.c (make_save_value): Integer argument is now of type
5886 ptrdiff_t, not int.
5887 (mark_object): Use ptrdiff_t, not int.
5888 * lisp.h (pD): New macro.
5889 * print.c (print_object): Use it.
5890
5891 * alloc.c: Use EMACS_INT, not int, to count objects.
5892 (total_conses, total_markers, total_symbols, total_vector_size)
5893 (total_free_conses, total_free_markers, total_free_symbols)
5894 (total_free_floats, total_floats, total_free_intervals)
5895 (total_intervals, total_strings, total_free_strings):
5896 Now EMACS_INT, not int. All uses changed.
5897 (Fgarbage_collect): Compute overall total using a double, so that
5898 integer overflow is less likely to be a problem. Check for overflow
5899 when converting back to an integer.
5900 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5901 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5902 These were 'int' variables that could overflow on 64-bit hosts;
5903 they were never used, so remove them instead of repairing them.
5904 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5905 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5906 Previously, this ceilinged at INT_MAX, but that doesn't work on
5907 64-bit machines.
5908 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5909
5910 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5911 (allocate_vectorlike): Check for ptrdiff_t overflow.
5912 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5913 when a (possibly-narrower) signed value would do just as well.
5914 We prefer using signed arithmetic, to avoid comparison confusion.
5915
5916 * alloc.c: Catch some string size overflows that we were missing.
5917 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5918 for convenience in STRING_BYTES_MAX.
5919 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5920 The definition here is exact; the one in lisp.h was approximate.
5921 (allocate_string_data): Check for string overflow. This catches
5922 some instances we weren't catching before. Also, it catches
5923 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5924 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5925 and ptrdiff_t and EMACS_INT are both 64 bits.
5926
5927 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5928 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5929 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5930
5931 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5932
5933 * alloc.c (Fmake_string): Check for out-of-range init.
5934
59352011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5936
5937 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5938
59392011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5940
5941 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5942 xg_get_default_scrollbar_width.
5943
5944 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5945 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5946 (style_changed_cb): Call update_theme_scrollbar_width and call
5947 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5948 all frames (Bug#8505).
5949 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5950 Call gtk_window_set_resizable if HAVE_GTK3.
5951 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5952 and height if HAVE_GTK3 (Bug#8505).
5953 (scroll_bar_width_for_theme): New variable.
5954 (update_theme_scrollbar_width): New function.
5955 (xg_get_default_scrollbar_width): Move code to
5956 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5957 (xg_initialize): Call update_theme_scrollbar_width.
5958
5959 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5960
5961 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5962
59632011-06-12 Martin Rudalics <rudalics@gmx.at>
5964
5965 * frame.c (make_frame): Call other_buffer_safely instead of
5966 other_buffer.
5967
5968 * window.c (temp_output_buffer_show): Call display_buffer with
5969 second argument Vtemp_buffer_show_specifiers and reset latter
5970 immediately after the call.
5971 (Vtemp_buffer_show_specifiers): New variable.
5972 (auto_window_vscroll_p, next_screen_context_lines)
5973 (Vscroll_preserve_screen_position): Remove leading asterisks from
5974 doc-strings.
5975
59762011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5977
5978 Fix minor problems found by GCC 4.6.0 static checking.
5979 * buffer.c (Qclone_number): Remove for now, as it's unused.
5980 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5981 (record_buffer): Remove unused local.
5982 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5983 (set_frame_buffer_list): Remove; unused.
5984 * frame.h (other_visible_frames): Remove decl.
5985 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5986 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5987 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5988 if HAVE_GPM.
5989 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5990 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5991 Define only if HAVE_GPM.
5992 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5993 (update_hints_inhibit): Remove; never set. All uses removed.
5994 * widgetprv.h (emacsFrameClassRec): Remove decl.
5995 * window.c (delete_deletable_window): Now returns void, since it
5996 wasn't returning anything.
5997 (compare_window_configurations): Remove unused locals.
5998 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5999 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
6000 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6001 the same widths as pointers. This follows up on the 2011-05-06 patch.
6002 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6003 * xterm.h: Likewise.
6004 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6005
60062011-06-12 Juanma Barranquero <lekktu@gmail.com>
6007
6008 * makefile.w32-in: Update dependencies.
6009 (LISP_H): Add lib/intprops.h.
6010
60112011-06-11 Chong Yidong <cyd@stupidchicken.com>
6012
6013 * image.c (gif_load): Add animation frame delay to the metadata.
6014 (syms_of_image): Use DEFSYM. New symbol `delay'.
6015
60162011-06-11 Martin Rudalics <rudalics@gmx.at>
6017
6018 * window.c (delete_deletable_window): Re-add.
6019 (Fset_window_configuration): Rewrite to handle dead buffers and
6020 consequently deletable windows.
6021 (window_tree, Fwindow_tree): Remove. Supply functionality in
6022 window.el.
6023 (compare_window_configurations): Simplify code.
6024
60252011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6026
6027 * image.c (imagemagick_load_image): Fix type mismatch.
6028 (Fimagemagick_types): Likewise.
6029
6030 * window.h (replace_buffer_in_windows): Declare.
6031
60322011-06-11 Martin Rudalics <rudalics@gmx.at>
6033
6034 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6035 Qclone_number. Remove external declaration of Qdelete_window.
6036 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6037 code.
6038 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6039 Run Qbuffer_list_update_hook if allowed.
6040 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6041 buffer list implementation.
6042 (other_buffer_safely): New function.
6043 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6044 calls to replace_buffer_in_windows and
6045 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6046 if allowed.
6047 (record_buffer): Inhibit quitting and rewrite using quittable
6048 functions. Run Qbuffer_list_update_hook if allowed.
6049 (Frecord_buffer, Funrecord_buffer): New functions.
6050 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6051 Move switch-to-buffer to window.el.
6052 (bury-buffer): Move to window.el.
6053 (Vbuffer_list_update_hook): New variable.
6054
6055 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6056 section.
6057
6058 * window.h (resize_frame_windows): Move up in code.
6059 (Fwindow_frame): Remove EXFUN.
6060 (replace_buffer_in_all_windows): Remove prototype.
6061 (replace_buffer_in_windows_safely): Add prototype.
6062
6063 * window.c: Declare Qdelete_window static again. Move down
6064 declaration of select_count.
6065 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6066 (Fother_window): Move to window.el.
6067 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6068 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6069 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6070 window.el.
6071 (replace_buffer_in_windows): Implement by calling
6072 Qreplace_buffer_in_windows.
6073 (replace_buffer_in_all_windows): Remove with some functionality
6074 moved into replace_buffer_in_windows_safely.
6075 (replace_buffer_in_windows_safely): New function.
6076 (select_window_norecord, select_frame_norecord): Move in front
6077 of run_window_configuration_change_hook. Remove now obsolete
6078 declarations.
6079 (Fset_window_buffer): Rewrite doc-string.
6080 Call Qrecord_window_buffer.
6081 (keys_of_window): Move binding for other-window to window.el.
6082
60832011-06-11 Chong Yidong <cyd@stupidchicken.com>
6084
6085 * dispextern.h (struct image): Replace data member, whose int_val
6086 and ptr_val fields were not used by anything, with a single
6087 lisp_val object.
6088
6089 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6090 (gif_clear_image, gif_load, imagemagick_load_image)
6091 (gs_clear_image, gs_load): Callers changed.
6092
60932011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6094
6095 * buffer.h: Include <time.h>, for time_t.
6096 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6097
6098 Fix minor problems found by static checking.
6099
6100 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6101
6102 Make identifiers static if they are not used in other modules.
6103 * data.c (Qcompiled_function, Qframe, Qvector):
6104 * image.c (QimageMagick, Qsvg):
6105 * minibuf.c (Qmetadata):
6106 * window.c (resize_window_check, resize_root_window): Now static.
6107 * window.h (resize_window_check, resize_root_window): Remove decls.
6108
6109 * window.c (window_deletion_count, delete_deletable_window):
6110 Remove; unused.
6111 (window_body_lines): Now static.
6112 (Fdelete_other_windows_internal): Mark vars as initialized.
6113 Make sure 'resize_failed' is initialized.
6114 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6115 (resize_window_apply): Remove unused local.
6116 * window.h (delete_deletable_window): Remove decl.
6117
6118 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6119 (imagemagick_load_image): Fix pointer signedness problem by changing
6120 last arg from unsigned char * to char *. All uses changed.
6121 Also, fix a local for similar reasons.
6122 Remove unused locals. Remove locals to avoid shadowing.
6123 (fn_rsvg_handle_free): Remove; unused.
6124 (svg_load, svg_load_image): Fix pointer signedness problem.
6125 (imagemagick_load_image): Don't use garbage pointer image_wand.
6126
6127 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6128
61292011-06-10 Chong Yidong <cyd@stupidchicken.com>
6130
6131 * image.c (gif_load): Fix omitted cast error introduced by
6132 2011-06-06 change.
6133
61342011-06-10 Martin Rudalics <rudalics@gmx.at>
6135
6136 * window.h (resize_proportionally, orig_total_lines)
6137 (orig_top_line): Remove from window structure.
6138 (set_window_height, set_window_width, change_window_heights)
6139 (Fdelete_window): Remove prototypes.
6140 (resize_frame_windows): Remove duplicate declaration.
6141
61422011-06-10 Eli Zaretskii <eliz@gnu.org>
6143
6144 * window.h (resize_frame_windows, resize_window_check)
6145 (delete_deletable_window, resize_root_window)
6146 (resize_frame_windows): Declare prototypes.
6147
6148 * window.c (resize_window_apply): Make definition be "static" to
6149 match the prototype.
6150
61512011-06-10 Martin Rudalics <rudalics@gmx.at>
6152
6153 * window.c: Remove declarations of Qwindow_size_fixed,
6154 window_min_size_1, window_min_size_2, window_min_size,
6155 size_window, window_fixed_size_p, enlarge_window, delete_window.
6156 Remove static from declaration of Qdelete_window, it's
6157 temporarily needed by Fbury_buffer.
6158 (replace_window): Don't assign orig_top_line and
6159 orig_total_lines.
6160 (Fdelete_window, delete_window): Remove. Window deletion is
6161 handled by window.el.
6162 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6163 Replace Fdelete_window calls with calls to Qdelete_window.
6164 (Fdelete_other_windows): Remove. Deleting other windows is
6165 handled by window.el.
6166 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6167 handled in window.el.
6168 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6169 Window minimum sizes are handled in window.el.
6170 (shrink_windows, size_window, set_window_height)
6171 (set_window_width, change_window_heights, window_height)
6172 (window_width, CURBEG, CURSIZE, enlarge_window)
6173 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6174 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6175 handled in window.el.
6176 (make_dummy_parent): Rename to make_parent_window and give it a
6177 second argument horflag.
6178 (make_window): Don't set resize_proportionally any more.
6179 (Fsplit_window): Remove. Windows are split in window.el.
6180 (save_restore_action, save_restore_orig_size)
6181 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6182 Resize mini windows in window.el.
6183 (grow_mini_window, shrink_mini_window): Implement by calling
6184 Qresize_root_window_vertically, resize_window_check and
6185 resize_window_apply.
6186 (saved_window, Fset_window_configuration, save_window_save):
6187 Do not handle orig_top_line, orig_total_lines, and
6188 resize_proportionally.
6189 (window_min_height, window_min_width): Move to window.el.
6190 (keys_of_window): Move bindings for delete-other-windows,
6191 split-window, delete-window and enlarge-window to window.el.
6192
6193 * buffer.c: Temporarily extern Qdelete_window.
6194 (Fbury_buffer): Temporarily call Qdelete_window instead of
6195 Fdelete_window (Fbury_buffer will move to window.el soon).
6196
6197 * frame.c (set_menu_bar_lines_1): Remove code handling
6198 orig_top_line and orig_total_lines.
6199
6200 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6201 set_window_height but set heights directly.
6202 (change_frame_size_1): Use resize_frame_windows.
6203
6204 * xdisp.c (init_xdisp): Don't use set_window_height but set
6205 heights directly.
6206
6207 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6208 Use resize_frame_windows instead of change_window_heights and run
6209 run_window_configuration_change_hook.
6210
6211 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6212 instead of change_window_heights and run
6213 run_window_configuration_change_hook.
6214
62152011-06-09 Martin Rudalics <rudalics@gmx.at>
6216
6217 * window.c (replace_window): Rename second argument REPLACEMENT to
6218 NEW. New third argument SETFLAG. Rewrite.
6219 (delete_window, make_dummy_parent): Call replace_window with
6220 third argument 1.
6221 (window_list_1): Move down in code.
6222 (run_window_configuration_change_hook): Move set_buffer part
6223 before select_frame_norecord part in order to unwind correctly.
6224 Rename count1 to count.
6225 (recombine_windows, delete_deletable_window, resize_root_window)
6226 (Fdelete_other_windows_internal)
6227 (Frun_window_configuration_change_hook, make_parent_window)
6228 (resize_window_check, resize_window_apply, Fresize_window_apply)
6229 (resize_frame_windows, Fsplit_window_internal)
6230 (Fdelete_window_internal, Fresize_mini_window_internal):
6231 New functions.
6232 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6233
62342011-06-08 Martin Rudalics <rudalics@gmx.at>
6235
6236 * window.h (window): Add some new members to window structure -
6237 normal_lines, normal_cols, new_total, new_normal, clone_number,
6238 splits, nest, prev_buffers, next_buffers.
6239 (WINDOW_TOTAL_SIZE): Move here from window.c.
6240 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6241
6242 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6243 Remove.
6244 (make_dummy_parent): Set new members of windows structure.
6245 (make_window): Move down in code. Handle new members of window
6246 structure.
6247 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6248 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6249 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6250 (Fset_window_prev_buffers, Fwindow_next_buffers)
6251 (Fset_window_next_buffers, Fset_window_clone_number):
6252 New functions.
6253 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6254 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6255 Doc-string fixes.
6256 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6257 Argument WINDOW can be now internal window too.
6258 (Fwindow_use_time): Move up in code.
6259 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6260 Rewrite doc-string.
6261 (Fset_window_configuration, saved_window)
6262 (Fcurrent_window_configuration, save_window_save): Handle new
6263 members of window structure.
6264 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6265 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6266 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6267 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6268 Qget_mru_window, Qresize_root_window,
6269 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6270 Qauto_buffer_name; staticpro them.
6271
62722011-06-07 Martin Rudalics <rudalics@gmx.at>
6273
6274 * window.c (Fwindow_total_size, Fwindow_left_column)
6275 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6276 (Fwindow_list_1): New functions.
6277 (window_box_text_cols): Replace with window_body_cols.
6278 (Fwindow_width, Fscroll_left, Fscroll_right):
6279 Use window_body_cols instead of window_box_text_cols.
6280 (delete_window, Fset_window_configuration):
6281 Call delete_all_subwindows with window as argument.
6282 (delete_all_subwindows): Take a window as argument and not a
6283 structure. Rewrite.
6284 (window_loop): Remove handling of GET_LRU_WINDOW and
6285 GET_LARGEST_WINDOW.
6286 (Fget_lru_window, Fget_largest_window): Move to window.el.
6287
6288 * window.h: Extern window_body_cols instead of
6289 window_box_text_cols. delete_all_subwindows now takes a
6290 Lisp_Object as argument.
6291
6292 * indent.c (compute_motion, Fcompute_motion):
6293 Use window_body_cols instead of window_box_text_cols.
6294
6295 * frame.c (delete_frame): Call delete_all_subwindows with root
6296 window as argument.
6297
62982011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6299
6300 * fns.c (Fputhash): Document return value.
6301
63022011-06-06 Chong Yidong <cyd@stupidchicken.com>
6303
6304 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6305
63062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6307
6308 Cons<->int and similar integer overflow fixes (Bug#8794).
6309
6310 Check for overflow when converting integer to cons and back.
6311 * charset.c (Fdefine_charset_internal, Fdecode_char):
6312 Use cons_to_unsigned to catch overflow.
6313 (Fencode_char): Use INTEGER_TO_CONS.
6314 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6315 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6316 * data.c (long_to_cons, cons_to_long): Remove.
6317 (cons_to_unsigned, cons_to_signed): New functions.
6318 These signal an error for invalid or out-of-range values.
6319 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6320 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6321 * font.c (Ffont_variation_glyphs):
6322 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6323 * lisp.h: Include <intprops.h>.
6324 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6325 (cons_to_signed, cons_to_unsigned): New decls.
6326 (long_to_cons, cons_to_long): Remove decls.
6327 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6328 (Fprimitive_undo): Use CONS_TO_INTEGER.
6329 * xfns.c (Fx_window_property): Likewise.
6330 * xselect.c: Include <limits.h>.
6331 (x_own_selection, selection_data_to_lisp_data):
6332 Use INTEGER_TO_CONS.
6333 (x_handle_selection_request, x_handle_selection_clear)
6334 (x_get_foreign_selection, Fx_disown_selection_internal)
6335 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6336 (lisp_data_to_selection_data): Use cons_to_unsigned.
6337 (x_fill_property_data): Use cons_to_signed.
6338 Report values out of range.
6339
6340 Check for buffer and string overflow more precisely.
6341 * buffer.h (BUF_BYTES_MAX): New macro.
6342 * lisp.h (STRING_BYTES_MAX): New macro.
6343 * alloc.c (Fmake_string):
6344 * character.c (string_escape_byte8):
6345 * coding.c (coding_alloc_by_realloc):
6346 * doprnt.c (doprnt):
6347 * editfns.c (Fformat):
6348 * eval.c (verror):
6349 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6350 since they may not be the same number.
6351 * editfns.c (Finsert_char):
6352 * fileio.c (Finsert_file_contents):
6353 Likewise for BUF_BYTES_MAX.
6354
6355 * image.c: Use ptrdiff_t, not int, for sizes.
6356 (slurp_file): Switch from int to ptrdiff_t.
6357 All uses changed.
6358 (slurp_file): Check that file size fits in both size_t (for
6359 malloc) and ptrdiff_t (for sanity and safety).
6360
6361 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6362 if b->modtime has its maximal value.
6363
6364 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6365
6366 Don't assume time_t can fit into int.
6367 * buffer.h (struct buffer.modtime): Now time_t, not int.
6368 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6369 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6370
6371 Minor fixes for signed vs unsigned integers.
6372 * character.h (MAYBE_UNIFY_CHAR):
6373 * charset.c (maybe_unify_char):
6374 * keyboard.c (read_char, reorder_modifiers):
6375 XINT -> XFASTINT, since the integer must be nonnegative.
6376 * ftfont.c (ftfont_spec_pattern):
6377 * keymap.c (access_keymap, silly_event_symbol_error):
6378 XUINT -> XFASTINT, since the integer must be nonnegative.
6379 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6380 since it makes no difference and we prefer signed.
6381 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6382 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6383 nonnegative.
6384
63852011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6386
6387 * window.h (Fwindow_frame): Declare.
6388
63892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6390
6391 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6392 (SPARE_MEMORY): Always define.
6393 (LARGE_REQUEST): Remove.
6394 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6395
63962011-06-06 Martin Rudalics <rudalics@gmx.at>
6397
6398 * lisp.h: Move EXFUNS for Fframe_root_window,
6399 Fframe_first_window and Fset_frame_selected_window to window.h.
6400
6401 * window.h: Move EXFUNS for Fframe_root_window,
6402 Fframe_first_window and Fset_frame_selected_window here from
6403 lisp.h.
6404
6405 * frame.c (Fwindow_frame, Fframe_first_window)
6406 (Fframe_root_window, Fframe_selected_window)
6407 (Fset_frame_selected_window): Move to window.c.
6408 (Factive_minibuffer_window): Move to minibuf.c.
6409 (Fother_visible_frames_p): New function.
6410
6411 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6412
6413 * window.c (decode_window, decode_any_window): Move up in code.
6414 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6415 (inhibit_frame_unsplittable): Remove unused variable.
6416 (Fwindow_buffer): Move up and rewrite doc-string.
6417 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6418 (Fwindow_prev): New functions.
6419 (Fwindow_frame): Move here from frame.c. Accept any window as
6420 argument.
6421 (Fframe_root_window, Fframe_first_window)
6422 (Fframe_selected_window): Move here from frame.c. Accept frame
6423 or arbitrary window as argument. Update doc-strings.
6424 (Fminibuffer_window): Move up in code.
6425 (Fwindow_minibuffer_p): Move up in code and simplify.
6426 (Fset_frame_selected_window): Move here from frame.c.
6427 Marginal rewrite.
6428 (Fselected_window, select_window, Fselect_window): Move up in
6429 code. Minor doc-string fixes.
6430
64312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6432
6433 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6434 Do not assume that spare memory exists; that assumption is valid
6435 only if SYSTEM_MALLOC.
6436 (LARGE_REQUEST): New macro, so that the issue of large requests
6437 is separated from the issue of spare memory.
6438
64392011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6440
6441 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6442 format. (Bug#8806)
6443
6444 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6445
6446 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6447 before statements.
6448
64492011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6450
6451 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6452
6453 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6454
6455 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6456 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6457
64582011-06-05 Juanma Barranquero <lekktu@gmail.com>
6459
6460 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6461
64622011-06-04 Chong Yidong <cyd@stupidchicken.com>
6463
6464 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6465 (x_clipboard_manager_save): Add return value.
6466 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6467 New error handlers.
6468 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6469 Obey Vx_select_enable_clipboard_manager. Catch errors in
6470 x_clipboard_manager_save (Bug#8779).
6471 (Vx_select_enable_clipboard_manager): New variable.
6472 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6473
64742011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6475
6476 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6477
64782011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6479
6480 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6481 in the current matrix if keep_current_p is non-zero.
6482
64832011-06-04 Eli Zaretskii <eliz@gnu.org>
6484
6485 * bidi.c (bidi_level_of_next_char): Fix last change.
6486
64872011-06-03 Eli Zaretskii <eliz@gnu.org>
6488
6489 Support bidi reordering of text covered by display properties.
6490
6491 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6492 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6493 (bidi_cache_search, bidi_cache_iterator_state)
6494 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6495 (bidi_level_of_next_char, bidi_move_to_visually_next):
6496 Support character positions inside a run of characters covered by a
6497 display string.
6498 (bidi_paragraph_init, bidi_resolve_explicit_1)
6499 (bidi_level_of_next_char): Call bidi_fetch_char and
6500 bidi_fetch_char_advance instead of FETCH_CHAR and
6501 FETCH_CHAR_ADVANCE.
6502 (bidi_init_it): Initialize new members.
6503 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6504 definitions.
6505 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6506 instead of using explicit *_CHAR codes.
6507 (bidi_resolve_explicit, bidi_resolve_weak):
6508 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6509 bidirectional text is supported only in multibyte buffers.
6510 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6511 it to initialize the frame_window_p member of struct bidi_it.
6512 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6513 (bidi_resolve_explicit, bidi_resolve_weak)
6514 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6515 bidi_it->nchars is non-positive.
6516 (bidi_level_of_next_char): Don't try to lookup the cache for the
6517 next/previous character if nothing is cached there yet, or if we
6518 were just reseat()'ed to a new position.
6519
6520 * xdisp.c (set_cursor_from_row): Set start and stop points
6521 according to the row's direction when priming the loop that looks
6522 for the glyph on which to display cursor.
6523 (single_display_spec_intangible_p): Function deleted.
6524 (display_prop_intangible_p): Reimplement to call
6525 handle_display_spec instead of single_display_spec_intangible_p.
6526 Accept 3 additional arguments needed by handle_display_spec.
6527 This fixes incorrect cursor motion across display property with complex
6528 values: lists, `(when COND...)' forms, etc.
6529 (single_display_spec_string_p): Support property values that are
6530 lists with the argument STRING its top-level element.
6531 (display_prop_string_p): Fix the condition for processing a
6532 property that is a list to be consistent with handle_display_spec.
6533 (handle_display_spec): New function, refactored from the
6534 last portion of handle_display_prop.
6535 (compute_display_string_pos): Accept additional argument
6536 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6537 value of a `display' property is a "replacing spec".
6538 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6539 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6540 the display property, but just return a value indicating whether
6541 the display property will replace the characters it covers.
6542 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6543 frame_window_p members of struct bidi_it.
6544 (compute_display_string_pos, compute_display_string_end):
6545 New functions.
6546 (push_it): Accept second argument POSITION, where pop_it should
6547 jump to continue iteration.
6548 (reseat_1): Initialize bidi_it.disp_pos.
6549
6550 * keyboard.c (adjust_point_for_property): Adjust the call to
6551 display_prop_intangible_p to its new signature.
6552
6553 * dispextern.h (struct bidi_it): New member frame_window_p.
6554 (bidi_init_it): Update prototypes.
6555 (display_prop_intangible_p): Update prototype.
6556 (compute_display_string_pos, compute_display_string_end):
6557 Declare prototypes.
6558 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6559 EMACS_INT.
6560
65612011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6562
6563 Malloc failure behavior now depends on size of allocation.
6564 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6565 * lisp.h: Change signatures accordingly.
6566 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6567 All callers changed. (Bug#8762)
6568
6569 * gnutls.c: Use Emacs's memory allocators.
6570 Without this change, the gnutls library would invoke malloc etc.
6571 directly, which causes problems on non-SYNC_INPUT hosts, and which
6572 runs afoul of improving memory_full behavior. (Bug#8761)
6573 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6574 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6575 xfree instead of the default malloc, realloc, free.
6576 (Fgnutls_boot): No need to check for memory allocation failure,
6577 since xmalloc does that for us.
6578
6579 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6580 * category.c (hash_get_category_set):
6581 * ccl.c (ccl_driver):
6582 * charset.c (Fdefine_charset_internal):
6583 * charset.h (struct charset.hash_index):
6584 * composite.c (get_composition_id, gstring_lookup_cache)
6585 (composition_gstring_put_cache):
6586 * composite.h (struct composition.hash_index):
6587 * dispextern.h (struct image.hash):
6588 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6589 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6590 (hashfn_equal, hashfn_user_defined, make_hash_table)
6591 (maybe_resize_hash_table, hash_lookup, hash_put)
6592 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6593 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6594 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6595 * image.c (make_image, search_image_cache, lookup_image)
6596 (xpm_put_color_table_h):
6597 * lisp.h (struct Lisp_Hash_Table):
6598 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6599 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6600 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6601 * alloc.c (allocate_vectorlike):
6602 Check for overflow in vector size calculations.
6603 * ccl.c (ccl_driver):
6604 Check for overflow when converting EMACS_INT to int.
6605 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6606 need to be updated by these changes.
6607 * fns.c (make_hash_table, maybe_resize_hash_table):
6608 Check for integer overflow with large hash tables.
6609 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6610 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6611 (SXHASH_REDUCE): New macro.
6612 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6613 Use it instead of discarding useful hash info with large hash values.
6614 (sxhash_float): New function.
6615 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6616 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6617 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6618 Rewrite to use FIXNUM_BITS, as this simplifies things.
6619 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6620 Adjust signatures to match updated version of code.
6621 (consing_since_gc): Now EMACS_INT, since a single hash table can
6622 use more than INT_MAX bytes.
6623
66242011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6625
6626 Make it possible to build with GCC-4.6+ -O2 -flto.
6627
6628 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6629
66302011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6631
6632 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6633 Call minibuffer-inactive-mode.
6634
66352011-05-31 Juanma Barranquero <lekktu@gmail.com>
6636
6637 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6638 Update dependencies.
6639
66402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6641
6642 * data.c (init_data): Remove code for UTS, this system is not
6643 supported anymore.
6644
66452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6646
6647 Don't force ./temacs to start in terminal mode.
6648
6649 * frame.c (make_initial_frame): Initialize faces in all cases, not
6650 only when CANNOT_DUMP is defined.
6651 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6652
66532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6654
6655 * dispnew.c (add_window_display_history): Use const for the string
6656 pointer. Remove declaration, not needed.
6657
66582011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6659
6660 Use 'inline', not 'INLINE'.
6661 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6662 * alloc.c, fontset.c (INLINE): Remove.
6663 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6664 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6665 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6666 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6667 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6668
66692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6670
6671 Make it possible to run ./temacs.
6672
6673 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6674 syms_of_callproc does the same thing. Remove test for
6675 "initialized", do it in the caller.
6676 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6677
66782011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6679
6680 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6681 (read_minibuf): Use get_minibuffer.
6682 (syms_of_minibuf): Use DEFSYM.
6683 (Qmetadata): New var.
6684 * data.c (Qbuffer): Don't make it static.
6685 (syms_of_data): Use DEFSYM.
6686
66872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6688
6689 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6690 (CCL_CODE_MIN): New macro.
6691
66922011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6693
6694 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6695
6696 * eval.c (Qdebug): Now static.
6697 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6698 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6699 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6700
67012011-05-29 Chong Yidong <cyd@stupidchicken.com>
6702
6703 * image.c: Various fixes to ImageMagick code comments.
6704 (Fimagemagick_types): Doc fix.
6705
67062011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6707
6708 Minor fixes prompted by GCC 4.6.0 warnings.
6709
6710 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6711
6712 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6713 (x_clipboard_manager_save_all): Move extern decl to ...
6714 * xterm.h: ... here, so that it can be checked for consistency.
6715
67162011-05-29 Chong Yidong <cyd@stupidchicken.com>
6717
6718 * xselect.c (x_clipboard_manager_save_frame)
6719 (x_clipboard_manager_save_all): New functions.
6720 (Fx_clipboard_manager_save): Lisp function deleted.
6721
6722 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6723 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6724
6725 * xterm.h: Update prototype.
6726
67272011-05-28 William Xu <william.xwl@gmail.com>
6728
6729 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6730 exiting (Bug#8239).
6731
67322011-05-28 Jim Meyering <meyering@redhat.com>
6733
6734 Avoid a sign-extension bug in crypto_hash_function.
6735 * fns.c (to_uchar): Define.
6736 (crypto_hash_function): Use it to convert some newly-signed
6737 variables to unsigned, to avoid sign-extension bugs. For example,
6738 without this change, (md5 "truc") would evaluate to
6739 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6740 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6741 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6742
67432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6744
6745 Integer overflow fixes.
6746
6747 * dbusbind.c: Serial number integer overflow fixes.
6748 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6749 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6750 to hold a serial number that is too large for a fixnum.
6751 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6752 Check for serial numbers out of range. Decode any serial number
6753 that was so large that it became a float. (Bug#8722)
6754
6755 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6756 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6757 Use XFASTINT rather than XUINT when numbers are nonnegative.
6758 (xd_append_arg, Fdbus_method_return_internal):
6759 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6760 arguments, check that Lisp number is nonnegative, rather than
6761 silently wrapping negative numbers around. (Bug#8722)
6762 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6763 (Bug#8722)
6764
6765 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6766
6767 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6768
6769 ccl: Add integer overflow checks.
6770 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6771 (IN_INT_RANGE): New macros.
6772 (ccl_driver): Use them to check for integer overflow when
6773 decoding a CCL program. Many of the new checks are whether XINT (x)
6774 fits in int; it doesn't always, on 64-bit hosts. The new version
6775 doesn't catch all possible integer overflows, but it's an
6776 improvement. (Bug#8719)
6777
6778 * alloc.c (make_event_array): Use XINT, not XUINT.
6779 There's no need for unsigned here.
6780
6781 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6782 This follows up to the 2011-05-06 change that substituted uintptr_t
6783 for EMACS_INT. This case wasn't caught back then.
6784
6785 Rework Fformat to avoid integer overflow issues.
6786 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6787 now (part of C89). Include <verify.h>.
6788 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6789 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6790 (Fformat): Avoid the prepass trying to compute sizes; it was only
6791 approximate and thus did not catch overflow reliably. Instead, walk
6792 through the format just once, formatting and computing sizes as we go,
6793 checking for integer overflow at every step, and allocating a larger
6794 buffer as needed. Keep track separately whether the format is
6795 multibyte. Keep only the most-recently calculated precision, rather
6796 than them all. Record whether each argument has been converted to
6797 string. Use EMACS_INT, not int, for byte and char and arg counts.
6798 Support field widths and precisions larger than INT_MAX. Avoid
6799 sprintf's undefined behavior with conversion specifications such as %#d
6800 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6801 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6802 formatting out-of-range floating point numbers with int
6803 formats. (Bug#8668)
6804
6805 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6806
6807 * data.c: Avoid integer truncation in expressions involving floats.
6808 * data.c: Include <intprops.h>.
6809 (arith_driver): When there's an integer overflow in an expression
6810 involving floating point, convert the integers to floating point
6811 so that the resulting value does not suffer from catastrophic
6812 integer truncation. For example, on a 64-bit host (* 4
6813 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6814 Do not rely on undefined behavior after integer overflow.
6815
6816 merge count_size_as_multibyte, parse_str_to_multibyte
6817 * character.c, character.h (count_size_as_multibyte):
6818 Rename from parse_str_to_multibyte; all uses changed.
6819 Check for integer overflow.
6820 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6821 since it's now a duplicate of the other. This is more of
6822 a character than a buffer op, so better that it's in character.c.
6823 * fns.c, print.c: Adjust to above changes.
6824
68252011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6826
6827 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6828
68292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6830
6831 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6832 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6833 (x_clipboard_manager_save): Now static.
6834 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6835
6836 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6837 (crypto_hash_function): Now static.
6838 Fix pointer signedness problems. Avoid unnecessary initializations.
6839
68402011-05-27 Chong Yidong <cyd@stupidchicken.com>
6841
6842 * termhooks.h (Vselection_alist): Make it terminal-local.
6843
6844 * terminal.c (create_terminal): Initialize it.
6845
6846 * xselect.c: Support for clipboard managers.
6847 (Vselection_alist): Move to termhooks.h as terminal-local var.
6848 (LOCAL_SELECTION): New macro.
6849 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6850 (symbol_to_x_atom): Remove gratuitous arg.
6851 (x_handle_selection_request, lisp_data_to_selection_data)
6852 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6853 (x_own_selection, x_get_local_selection, x_convert_selection):
6854 New arg, specifying work frame. Use terminal-local Vselection_alist.
6855 (some_frame_on_display): Delete unused function.
6856 (Fx_own_selection_internal, Fx_get_selection_internal)
6857 (Fx_disown_selection_internal, Fx_selection_owner_p)
6858 (Fx_selection_exists_p): New optional frame arg.
6859 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6860 (x_handle_selection_clear): Don't treat other terminals with the
6861 same keyboard specially. Use the terminal-local Vselection_alist.
6862 (x_clear_frame_selections): Use Frun_hook_with_args.
6863
6864 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6865
6866 * xterm.h: Add support for those atoms.
6867
68682011-05-26 Chong Yidong <cyd@stupidchicken.com>
6869
6870 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6871 (converted_selections, conversion_fail_tag): New global variables.
6872 (x_selection_request_lisp_error): Free the above.
6873 (x_get_local_selection): Remove unnecessary code.
6874 (x_reply_selection_request): Args changed; handle arbitrary array
6875 of converted selections stored in converted_selections.
6876 Separate the XChangeProperty and SelectionNotify steps.
6877 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6878 (x_convert_selection): New function.
6879 (x_handle_selection_event): Simplify.
6880 (x_get_foreign_selection): Don't ignore incoming requests while
6881 waiting for an answer; this will fail when we implement
6882 SAVE_TARGETS, and seems unnecessary anyway.
6883 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6884 (Vx_sent_selection_functions): Doc fix.
6885
68862011-05-26 Leo Liu <sdl.web@gmail.com>
6887
6888 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6889
68902011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6891
6892 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6893
6894 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6895 for fringe update if it has periodic bitmap.
6896 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6897 and fringe_bitmap_periodic_p.
6898
6899 * fringe.c (get_fringe_bitmap_data): New function.
6900 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6901 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6902 row. Mark glyph row for fringe update if periodicity changed.
6903
6904 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6905 for fringe update unless it has periodic bitmap.
6906
69072011-05-25 Kenichi Handa <handa@m17n.org>
6908
6909 * xdisp.c (get_next_display_element): Set correct it->face_id for
6910 a static composition.
6911
69122011-05-24 Leo Liu <sdl.web@gmail.com>
6913
6914 * deps.mk (fns.o):
6915 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6916
6917 * fns.c (crypto_hash_function, Fsha1): New function.
6918 (Fmd5): Use crypto_hash_function.
6919 (syms_of_fns): Add Ssha1.
6920
69212011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6922
6923 * gnutls.c: Remove unused macros.
6924 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6925 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6926 Remove macros that are defined and never used.
6927 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6928
69292011-05-22 Chong Yidong <cyd@stupidchicken.com>
6930
6931 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6932 (Fx_get_selection_internal): Minor cleanup.
6933 (Fx_own_selection_internal): Rename arguments for consistency with
6934 select.el.
6935
69362011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6937
6938 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6939
69402011-05-22 Chong Yidong <cyd@stupidchicken.com>
6941
6942 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6943
69442011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6945
6946 * dispnew.c (scrolling_window): Don't exclude the case that the
6947 last enabled row in the desired matrix touches the bottom boundary.
6948
69492011-05-21 Glenn Morris <rgm@gnu.org>
6950
6951 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6952 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6953 and add some more files.
6954
69552011-05-20 Eli Zaretskii <eliz@gnu.org>
6956
6957 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6958 report_file_error introduced by the change from 2011-05-07.
6959
69602011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6961
6962 * systime.h (Time): Define only if emacs is defined.
6963 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6964 where the include path doesn't have X11/X.h by default. See
6965 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6966
69672011-05-20 Kenichi Handa <handa@m17n.org>
6968
6969 * composite.c (find_automatic_composition): Fix previous change.
6970
69712011-05-20 Glenn Morris <rgm@gnu.org>
6972
6973 * lisp.mk: New file, split from Makefile.in.
6974 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6975 (shortlisp): Remove.
6976 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6977
69782011-05-19 Glenn Morris <rgm@gnu.org>
6979
6980 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6981 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6982 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6983 (lisp): Set the order to that of loadup.el.
6984 (shortlisp): Make it a copy of $lisp.
6985 (SOME_MACHINE_LISP): Remove.
6986 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6987 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6988
69892011-05-18 Kenichi Handa <handa@m17n.org>
6990
6991 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6992 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6993 (find_automatic_composition): Mostly rewrite for efficiency.
6994
69952011-05-18 Juanma Barranquero <lekktu@gmail.com>
6996
6997 * makefile.w32-in: Update dependencies.
6998
69992011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7000
7001 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7002 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7003
70042011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7005
7006 Fix some integer overflow issues, such as string length overflow.
7007
7008 * insdel.c (count_size_as_multibyte): Check for string overflow.
7009
7010 * character.c (lisp_string_width): Check for string overflow.
7011 Use EMACS_INT, not int, for string indexes and lengths; in
7012 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7013 the resulting string length overflows an EMACS_INT; instead,
7014 report a string overflow if no precision given. When checking for
7015 precision exhaustion, use a check that cannot possibly have
7016 integer overflow. (Bug#8675)
7017 * character.h (lisp_string_width): Adjust to new signature.
7018
7019 * alloc.c (string_overflow): New function.
7020 (Fmake_string): Use it. This doesn't change behavior, but saves
7021 a few bytes and will simplify future changes.
7022 * character.c (string_escape_byte8): Likewise.
7023 * lisp.h (string_overflow): New decl.
7024
7025 Fixups, following up to the user-interface timestamp change.
7026 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7027 for UI timestamps, instead of unsigned long.
7028 * msdos.c (mouse_get_pos): Likewise.
7029 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
7030 * w32gui.h (Time): Define by including "systime.h" rather than by
7031 declaring it ourselves. (Bug#8664)
7032
7033 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7034 * image.c (clear_image_cache): Likewise.
7035
7036 * term.c (term_mouse_position): Don't assume time_t wraparound.
7037
7038 Be more systematic about user-interface timestamps.
7039 Before, the code sometimes used 'Time', sometimes 'unsigned long',
7040 and sometimes 'EMACS_UINT', to represent these timestamps.
7041 This change causes it to use 'Time' uniformly, as that's what X uses.
7042 This makes the code easier to follow, and makes it easier to catch
7043 integer overflow bugs such as Bug#8664.
7044 * frame.c (Fmouse_position, Fmouse_pixel_position):
7045 Use Time, not unsigned long, for user-interface timestamps.
7046 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7047 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7048 * keyboard.h (last_event_timestamp): Likewise.
7049 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7050 * menu.h (xmenu_show): Likewise.
7051 * term.c (term_mouse_position): Likewise.
7052 * termhooks.h (struct input_event.timestamp): Likewise.
7053 (struct terminal.mouse_position_hook): Likewise.
7054 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7055 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7056 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7057 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7058 what it was before.
7059 * menu.h, termhooks.h: Include "systime.h", for Time.
7060
7061 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7062 Don't assume that the difference between two unsigned long values
7063 can fit into an integer. At this point, we know button_down_time
7064 <= event->timestamp, so the difference must be nonnegative, so
7065 there's no need to cast the result if double-click-time is
7066 nonnegative, as it should be; check that it's nonnegative, just in
7067 case. This bug is triggered when events are more than 2**31 ms
7068 apart (about 25 days). (Bug#8664)
7069
7070 * xselect.c (last_event_timestamp): Remove duplicate decl.
7071 (x_own_selection): Remove needless cast to unsigned long.
7072
7073 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7074 that always fit in int. Use a sentinel instead of a counter, to
7075 avoid a temp and to allay GCC's concerns about possible int overflow.
7076 * frame.h (struct frame): Use int for menu_bar_items_used
7077 instead of EMACS_INT, since it always fits in int.
7078
7079 * menu.c (grow_menu_items): Check for int overflow.
7080
7081 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7082
7083 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7084 Before, the code was not consistent. These values cannot exceed
7085 2**31 - 1 so there's no need to make them unsigned.
7086 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7087 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7088 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7089 as modifiers.
7090 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7091
7092 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7093 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7094 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7095 presumably because the widths might not match.
7096
7097 * window.c (size_window): Avoid needless test at loop start.
7098
70992011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7100
7101 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7102
71032011-05-12 Drew Adams <drew.adams@oracle.com>
7104
7105 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7106
71072011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7108
7109 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7110 `width' to `bar_area_x' and `bar_area_width', respectively.
7111 (x_scroll_run): Take account of fringe background extension.
7112
7113 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7114 Rename local vars `left' and `width' to `bar_area_x' and
7115 `bar_area_width', respectively.
7116 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7117 background extension.
7118
71192011-05-10 Jim Meyering <meyering@redhat.com>
7120
7121 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7122
71232011-05-10 Juanma Barranquero <lekktu@gmail.com>
7124
7125 * image.c (Finit_image_library): Return t for built-in image types,
7126 like pbm and xbm. (Bug#8640)
7127
71282011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7129
7130 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7131
71322011-05-07 Eli Zaretskii <eliz@gnu.org>
7133
7134 * w32console.c (Fset_screen_color): Doc fix.
7135 (Fget_screen_color): New function.
7136 (syms_of_ntterm): Defsubr it.
7137
7138 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7139 unlink the temporary file if Fcall_process didn't create it in the
7140 first place.
7141 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7142 child process will be redirected to a file specified with `:file'.
7143 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7144 cue to call_process_cleanup not to close that handle.
7145
71462011-05-07 Ben Key <bkey76@gmail.com>
7147
7148 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7149 one of two shell specific rules, either bootstrap-temacs-CMD or
7150 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7151 to the previous implementation of the bootstrap-temacs rule.
7152 The bootstrap-temacs-CMD rule is similar to the previous
7153 implementation of the bootstrap-temacs rule except that it
7154 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7155 variable.
7156
7157 These changes, along with some changes to nt/configure.bat,
7158 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7159 earlier fix to add support for --cflags and --ldflags options
7160 that include quotes so that it works whether make uses cmd or
7161 sh as the shell.
7162
71632011-05-06 Michael Albinus <michael.albinus@gmx.de>
7164
7165 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7166 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7167 is a constant.
7168 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7169 a string. Handle both cases.
7170 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7171 (Fdbus_register_method): Use Qinvalid_function.
7172
71732011-05-06 Juanma Barranquero <lekktu@gmail.com>
7174
7175 * makefile.w32-in: Update dependencies.
7176 (LISP_H): Add inttypes.h and stdin.h.
7177 (PROCESS_H): Add unistd.h.
7178
71792011-05-06 Eli Zaretskii <eliz@gnu.org>
7180
7181 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7182 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7183
71842011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7185
7186 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7187
7188 * term.c (vfatal): Remove stray call to va_end.
7189 It's not needed and the C Standard doesn't allow it here anyway.
7190
7191 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7192 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7193
7194 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7195 bytes.
7196
7197 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7198
7199 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7200
7201 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7202
7203 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7204
7205 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7206
7207 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7208 * charset.c (Fdefine_charset_internal): Don't initialize
7209 charset.code_space[15]. The value was garbage, on hosts with
7210 32-bit int (Bug#8600).
7211
7212 * lread.c (read_integer): Be more consistent with string-to-number.
7213 Use string_to_number to do the actual conversion; this avoids
7214 rounding errors and fixes some other screwups. Without this fix,
7215 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7216 (digit_to_number): Move earlier, for benefit of read_integer.
7217 Return -1 if the digit is out of range for the base, -2 if it is
7218 not a digit in any supported base. (Bug#8602)
7219
7220 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7221
7222 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7223 to match comment at start of function. This also removes a
7224 GCC warning about overflow in a 32+64-bit port.
7225
7226 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7227
7228 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7229 Reported by Stefan Monnier in
7230 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7231 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7232 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7233
7234 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7235 (EMACS_UINTPTR): Likewise, with uintptr_t.
7236
7237 * lisp.h: Prefer 64-bit EMACS_INT if available.
7238 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7239 on 32-bit hosts that have 64-bit int, so that they can access
7240 large files.
7241 However, temporarily disable this change unless the temporary
7242 symbol WIDE_EMACS_INT is defined.
7243
7244 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7245
7246 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7247 This removes an assumption that EMACS_INT and long are the same
7248 width as pointers. The assumption is true for Emacs porting targets
7249 now, but we want to make other targets possible.
7250 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7251 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7252 In the rest of the code, change types of integers that hold casted
7253 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7254 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7255 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7256 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7257 No need to cast type when ORing.
7258 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7259 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7260 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7261 assume EMACS_INT is the same width as char *.
7262 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7263 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7264 Remove no-longer-needed casts.
7265 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7266 (xg_tool_bar_help_callback, xg_make_tool_item):
7267 Use EMACS_INTPTR to hold an integer
7268 that will be cast to void *; this can avoid a GCC warning
7269 if EMACS_INT is not the same width as void *.
7270 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7271 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7272 (current_message_1, set_message_1):
7273 Use a local to convert to proper width without a cast.
7274 * xmenu.c (dialog_selection_callback): Likewise.
7275
7276 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7277 Also, don't assume VALBITS / RAND_BITS is less than 5,
7278 and don't rely on undefined behavior when shifting a 1 left into
7279 the sign bit.
7280 * lisp.h (get_random): Change signature to match.
7281
7282 * lread.c (hash_string): Use size_t, not int, for hash computation.
7283 Normally we prefer signed values; but hashing is special, because
7284 it's better to use unsigned division on hash table sizes so that
7285 the remainder is nonnegative. Also, size_t is the natural width
7286 for hashing into memory. The previous code used 'int', which doesn't
7287 retain enough info to hash well into very large tables.
7288 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7289
7290 * dbusbind.c: Don't possibly lose pointer info when converting.
7291 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7292 Use XPNTR rather than XHASH, so that the high-order bits of
7293 the pointer aren't lost when converting through void *.
7294
7295 * eval.c (Fautoload): Don't double-shift a pointer.
7296
7297 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7298
72992011-05-06 Juanma Barranquero <lekktu@gmail.com>
7300
7301 * gnutls.c (DEF_GNUTLS_FN):
7302 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7303
73042011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7305
7306 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7307 marker. (Bug#8610)
7308
73092011-05-05 Eli Zaretskii <eliz@gnu.org>
7310
7311 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7312 New version that can reserve upto 2GB of heap space.
7313
73142011-05-05 Chong Yidong <cyd@stupidchicken.com>
7315
7316 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7317
73182011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7319
7320 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7321 `gnutls_certificate_set_x509_key_file'.
7322
73232011-05-05 Juanma Barranquero <lekktu@gmail.com>
7324
7325 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7326 Update dependencies.
7327
73282011-05-04 Juanma Barranquero <lekktu@gmail.com>
7329
7330 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7331 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7332 Remove unused parameter `fildes'.
7333 * process.c (read_process_output, send_process): Don't pass it.
7334
73352011-05-04 Juanma Barranquero <lekktu@gmail.com>
7336
7337 Fix previous change: the library cache is defined in w32.c.
7338 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7339 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7340
73412011-05-04 Juanma Barranquero <lekktu@gmail.com>
7342
7343 Implement dynamic loading of GnuTLS on Windows.
7344
7345 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7346 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7347 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7348 Declare.
7349
7350 * gnutls.c (Qgnutls_dll): Define.
7351 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7352 (gnutls_*): Declare function pointers.
7353 (init_gnutls_functions): New function to initialize function pointers.
7354 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7355 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7356 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7357 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7358 (emacs_gnutls_write, emacs_gnutls_read)
7359 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7360 (Fgnutls_available_p): New function.
7361 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7362 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7363 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7364
7365 * image.c: Include w32.h.
7366 (Vimage_type_cache): Delete.
7367 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7368 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7369 (w32_delayed_load): Move to w32.c.
7370
7371 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7372
7373 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7374 (w32_delayed_load): Move from image.c. When loading a library, record
7375 its filename in the :loaded-from property of the library id.
7376 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7377 Initialize and staticpro them.
7378 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7379
7380 * process.c: Include lisp.h before w32.h, not after.
7381 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7382 instead of gnutls_record_check_pending.
7383
7384 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7385
73862011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7387
7388 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7389 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7390 as passed in.
7391
73922011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7393
7394 * xterm.c (x_set_frame_alpha): Do not set property on anything
7395 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7396
73972011-05-02 Juanma Barranquero <lekktu@gmail.com>
7398
7399 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7400
74012011-05-02 Juanma Barranquero <lekktu@gmail.com>
7402
7403 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7404 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7405 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7406 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7407 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7408 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7409 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7410 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7411 (Qgnutls_bootprop_callbacks_verify): Make static.
7412
74132011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7414
7415 * callproc.c: Indentation fixup.
7416
7417 * sysdep.c (wait_for_termination_1): Make static.
7418 (wait_for_termination, interruptible_wait_for_termination):
7419 Move after wait_for_termination_1.
7420
74212011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7422
7423 * sysdep.c (interruptible_wait_for_termination): New function
7424 which is like wait_for_termination, but allows keyboard
7425 interruptions.
7426
7427 * callproc.c (Fcall_process): Add (:file "file") as an option for
7428 the STDOUT buffer.
7429 (Fcall_process_region): Ditto.
7430
74312011-04-30 Eli Zaretskii <eliz@gnu.org>
7432
7433 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7434 rather than `XVECTOR (FOO)->size'.
7435
7436 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7437 inttypes.h, as a gnulib replacement is used if it not available in
7438 system headers.
7439
74402011-04-21 Eli Zaretskii <eliz@gnu.org>
7441
7442 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7443 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7444 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7445
7446 * coding.c (coding_alloc_by_realloc): Error out if destination
7447 will grow beyond MOST_POSITIVE_FIXNUM.
7448 (decode_coding_emacs_mule): Abort if there isn't enough place in
7449 charbuf for the composition carryover bytes. Reserve an extra
7450 space for up to 2 characters produced in a loop.
7451 (decode_coding_iso_2022): Abort if there isn't enough place in
7452 charbuf for the composition carryover bytes.
7453
74542011-04-21 Eli Zaretskii <eliz@gnu.org>
7455
7456 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7457 aborting when %lld or %lll format is passed.
7458 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7459 %llo or %llx format is passed. (Bug#8545)
7460
7461 * window.c (window_scroll_line_based): Use a marker instead of
7462 simple variables to record original value of point. (Bug#7952)
7463
7464 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7465 produced by %s or %c overflows available buffer space. (Bug#8545)
7466
74672011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7468
7469 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7470 (SIZE_MAX): Move defn after all includes, as they might #define it.
7471
74722011-04-28 Juanma Barranquero <lekktu@gmail.com>
7473
7474 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7475
74762011-04-28 Juanma Barranquero <lekktu@gmail.com>
7477
7478 * keyboard.c (Qdelayed_warnings_hook): Define.
7479 (command_loop_1): Run `delayed-warnings-hook'
7480 if Vdelayed_warnings_list is non-nil.
7481 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7482 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7483
74842011-04-28 Eli Zaretskii <eliz@gnu.org>
7485
7486 * doprnt.c (doprnt): Don't return value smaller than the buffer
7487 size if the message was truncated. (Bug#8545).
7488
74892011-04-28 Juanma Barranquero <lekktu@gmail.com>
7490
7491 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7492 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7493
74942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7495
7496 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7497
74982011-04-27 Juanma Barranquero <lekktu@gmail.com>
7499
7500 * makefile.w32-in: Update dependencies.
7501
75022011-04-27 Eli Zaretskii <eliz@gnu.org>
7503
7504 Improve `doprnt' and its usage. (Bug#8545)
7505 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7506 `format_end'. Remove support for %l as a conversion specifier.
7507 Don't use xrealloc. Improve diagnostics when the %l size modifier
7508 is used. Update the commentary.
7509
7510 * eval.c (verror): Simplify calculation of size_t.
7511
7512 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7513 messages.
7514
75152011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7516
7517 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7518 change.
7519
75202011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7521
7522 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7523 This makes this file independent of the recent pseudovector change.
7524
75252011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7526
7527 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7528
7529 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7530 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7531 Remove unused local.
7532 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7533
7534 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7535 GCC 4.6.0 optimizes based on type-based alias analysis.
7536 For example, if b is of type struct buffer * and v of type struct
7537 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7538 != &v->size, and therefore "v->size = 1; b->size = 2; return
7539 v->size;" must therefore return 1. This assumption is incorrect
7540 for Emacs, since it type-puns struct Lisp_Vector * with many other
7541 types. To fix this problem, this patch adds a new type struct
7542 vectorlike_header that documents the constraints on layout of vectors
7543 and pseudovectors, and helps optimizing compilers not get fooled
7544 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7545 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7546 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7547 the size member.
7548 (XSETPVECTYPE): Rewrite in terms of new macro.
7549 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7550 This is a bit clearer, and further avoids the possibility of
7551 undesirable aliasing.
7552 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7553 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7554 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7555 since Lisp_Subr is a special case (no "next" field).
7556 (ASIZE): Now uses header.size rather than size.
7557 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7558 to avoid the hassle of writing XVECTOR (foo)->header.size.
7559 (struct vectorlike_header): New type.
7560 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7561 object, to help avoid aliasing.
7562 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7563 (SUBRP): Likewise, since Lisp_Subr is a special case.
7564 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7565 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7566 (struct Lisp_Hash_Table): Combine first two members into a single
7567 struct vectorlike_header member. All uses of "size" and "next" members
7568 changed to be "header.size" and "header.next".
7569 * buffer.h (struct buffer): Likewise.
7570 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7571 * frame.h (struct frame): Likewise.
7572 * process.h (struct Lisp_Process): Likewise.
7573 * termhooks.h (struct terminal): Likewise.
7574 * window.c (struct save_window_data, struct saved_window): Likewise.
7575 * window.h (struct window): Likewise.
7576 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7577 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7578 * buffer.c (init_buffer_once): Likewise.
7579 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7580 special case.
7581 * process.c (Fformat_network_address): Use local var for size,
7582 for brevity.
7583
7584 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7585
7586 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7587 * data.c (atof): Remove decl; no longer used or needed.
7588 (digit_to_number): Move to lread.c.
7589 (Fstring_to_number): Use new string_to_number function, to be
7590 consistent with how the Lisp reader treats infinities and NaNs.
7591 Do not assume that floating-point numbers represent EMACS_INT
7592 without losing information; this is not true on most 64-bit hosts.
7593 Avoid double-rounding errors, by insisting on integers when
7594 parsing non-base-10 numbers, as the documentation specifies.
7595 * lisp.h (string_to_number): New decl, replacing ...
7596 (isfloat_string): Remove.
7597 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7598 (read1): Do not accept +. and -. as integers; this
7599 appears to have been a coding error. Similarly, do not accept
7600 strings like +-1e0 as floating point numbers. Do not report
7601 overflow for integer overflows unless the base is not 10 which
7602 means we have no simple and reliable way to continue.
7603 Break out the floating-point parsing into a new
7604 function string_to_number, so that Fstring_to_number parses
7605 floating point numbers consistently with the Lisp reader.
7606 (digit_to_number): Move here from data.c. Make it static inline.
7607 (E_CHAR, EXP_INT): Remove, replacing with ...
7608 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7609 (string_to_number): New function, replacing isfloat_string.
7610 This function checks for valid syntax and produces the resulting
7611 Lisp float number too. Rework it so that string-to-number
7612 no longer mishandles examples like "1.0e+". Use strtoumax,
7613 so that overflow for non-base-10 numbers is reported only when
7614 there's no portable and simple way to convert to floating point.
7615
7616 * textprop.c (set_text_properties_1): Rewrite for clarity,
7617 and to avoid GCC warning about integer overflow.
7618
7619 * intervals.h (struct interval): Use EMACS_INT for members
7620 where EMACS_UINT might cause problems. See
7621 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7622 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7623 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7624 All uses changed.
7625 (offset_intervals): Tell GCC not to worry about length overflow
7626 when negating a negative length.
7627
7628 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7629 (overrun_check_free): Likewise.
7630
7631 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7632 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7633 word size.
7634
7635 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7636 (gnutls_make_error): Rename local to avoid shadowing.
7637 (gnutls_emacs_global_deinit): ifdef out; not used.
7638 (Fgnutls_boot): Use const for pointer to readonly storage.
7639 Comment out unused local. Fix pointer signedness problems.
7640
7641 * lread.c (openp): Don't stuff size_t into an 'int'.
7642 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7643 about possible signed overflow.
7644
7645 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7646 (GDK_KEY_g): Don't define if already defined.
7647 (xg_prepare_tooltip): Avoid pointer signedness problem.
7648 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7649
7650 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7651 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7652
7653 * xfns.c (Fx_window_property): Simplify a bit,
7654 to make a bit faster and to avoid GCC 4.6.0 warning.
7655 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7656
7657 * fns.c (internal_equal): Don't assume size_t fits in int.
7658
7659 * alloc.c (compact_small_strings): Tighten assertion a little.
7660
7661 Replace pEd with more-general pI, and fix some printf arg casts.
7662 * lisp.h (pI): New macro, generalizing old pEd macro to other
7663 conversion specifiers. For example, use "...%"pI"d..." rather
7664 than "...%"pEd"...".
7665 (pEd): Remove. All uses replaced with similar uses of pI.
7666 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7667 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7668 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7669 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7670 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7671 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7672 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7673 64-bit hosts.
7674 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7675 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7676 * print.c (safe_debug_print, print_object): Likewise.
7677 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7678 to int.
7679 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7680 avoiding the 0 flag, which is not portable.
7681 * process.c (Fmake_network_process): Use pI to avoid cast.
7682 * region-cache.c (pp_cache): Likewise.
7683 * xdisp.c (decode_mode_spec): Likewise.
7684 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7685 behavior on 64-bit hosts with printf arg.
7686 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7687 (x_stop_queuing_selection_requests): Likewise.
7688 (x_get_window_property): Don't truncate byte count to an 'int'
7689 when tracing.
7690
7691 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7692 here, since it parses constructs like leading '-' and spaces,
7693 which are not wanted; and it overflows with large numbers.
7694 Instead, simply match F[0-9]+, which is what is wanted anyway.
7695
7696 * alloc.c: Remove unportable assumptions about struct layout.
7697 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7698 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7699 (allocate_vectorlike, make_pure_vector): Use the new macros,
7700 plus offsetof, to remove unportable assumptions about struct layout.
7701 These assumptions hold on all porting targets that I know of, but
7702 they are not guaranteed, they're easy to remove, and removing them
7703 makes further changes easier.
7704
7705 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7706 This doesn't fix a bug but makes the code clearer.
7707 (string_overrun_cookie): Now const. Use initializers that
7708 don't formally overflow signed char, to avoid warnings.
7709 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7710 can cause Emacs to crash when string overrun checking is enabled.
7711 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7712 multiple of sizeof (EMACS_INT); it need not be, if
7713 alignof(EMACS_INT) < sizeof (EMACS_INT).
7714 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7715
77162011-04-26 Juanma Barranquero <lekktu@gmail.com>
7717
7718 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7719
77202011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7721
7722 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7723 supposed to be handshaking. (Bug#8556)
7724 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7725
77262011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7727
7728 * lisp.h (Qdebug): List symbol.
7729 * eval.c (Qdebug): Restore global linkage.
7730 * keyboard.c (debug-on-event): New variable.
7731 (handle_user_signal): Break into debugger when debug-on-event
7732 matches the current signal symbol.
7733
77342011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7735
7736 * alloc.c (check_sblock, check_string_bytes)
7737 (check_string_free_list): Convert to standard C.
7738
77392011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7740
7741 * w32.c (emacs_gnutls_push): Fix typo.
7742
77432011-04-25 Eli Zaretskii <eliz@gnu.org>
7744
7745 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7746 "cast to pointer from integer of different size".
7747
7748 Improve doprnt and its use in verror. (Bug#8545)
7749 * doprnt.c (doprnt): Document the set of format control sequences
7750 supported by the function. Use SAFE_ALLOCA instead of always
7751 using `alloca'.
7752
7753 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7754 is one byte too soon. Don't use xrealloc; instead xfree and
7755 xmalloc anew.
7756
77572011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7758
7759 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7760 callbacks stage.
7761
7762 * gnutls.c: Renamed global_initialized to
7763 gnutls_global_initialized. Added internals for the
7764 :verify-hostname-error, :verify-error, and :verify-flags
7765 parameters of `gnutls-boot' and documented those parameters in the
7766 docstring. Start callback support.
7767 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7768 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7769 on error. Return error code.
7770 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7771 (emacs_gnutls_read): Likewise.
7772 (Fgnutls_boot): Return handshake error code.
7773 (emacs_gnutls_handle_error): New function.
7774 (wsaerror_to_errno): Likewise.
7775
7776 * w32.h (emacs_gnutls_pull): Add prototype.
7777 (emacs_gnutls_push): Likewise.
7778
7779 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7780 (emacs_gnutls_push): Likewise.
7781
77822011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7783
7784 * process.c (wait_reading_process_output): Check if GnuTLS
7785 buffered some data internally if no FDs are set for TLS
7786 connections.
7787
7788 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7789 (LIBS): Link to USER_LIBS.
7790 ($(BLD)/gnutls.$(0)): New target.
7791
77922011-04-24 Eli Zaretskii <eliz@gnu.org>
7793
7794 * xdisp.c (handle_single_display_spec): Rename the
7795 display_replaced_before_p argument into display_replaced_p, to
7796 make it consistent with the commentary. Fix typos in the
7797 commentary.
7798
7799 * textprop.c (syms_of_textprop): Remove dead code.
7800 (copy_text_properties): Delete obsolete commentary about an
7801 interface that was deleted long ago. Fix typos in the description
7802 of arguments.
7803
7804 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7805 to changes in oldXMenu/XMenu.h from 2011-04-16.
7806 <menu_help_message, prev_menu_help_message>: Constify.
7807 (IT_menu_make_room): menu->help_text is now `const char **';
7808 adjust.
7809
7810 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7811 to changes in oldXMenu/XMenu.h from 2011-04-16.
7812 (struct XMenu): Declare `help_text' `const char **'.
7813
7814 * xfaces.c <Qunspecified>: Make extern again.
7815
7816 * syntax.c: Include sys/types.h before including regex.h, as
7817 required by POSIX.
7818
7819 * doc.c (get_doc_string): Improve the format passed to `error'.
7820
7821 * doprnt.c (doprnt): Improve commentary.
7822
7823 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7824
7825 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7826 them with etags.
7827
7828 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7829 changes in globals.h immediately force recompilation.
7830 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7831 $(CURDIR)/s/ms-w32.h.
7832 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7833
7834 * character.c (Fchar_direction): Function deleted.
7835 (syms_of_character): Don't defsubr it.
7836 <char-direction-table>: Deleted.
7837
78382011-04-23 Eli Zaretskii <eliz@gnu.org>
7839
7840 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7841 * doprnt.c: Include limits.h.
7842 (SIZE_MAX): New macro.
7843 (doprnt): Return a size_t value. 2nd arg is now size_t.
7844 Many local variables are now size_t instead of int or unsigned.
7845 Improve overflow protection. Support `l' modifier for integer
7846 conversions. Support %l conversion. Don't assume an EMACS_INT
7847 argument for integer conversions and for %c.
7848
7849 * lisp.h (doprnt): Restore prototype.
7850
7851 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7852 $(SRC)/character.h.
7853
7854 * Makefile.in (base_obj): Add back doprnt.o.
7855
7856 * deps.mk (doprnt.o): Add back prerequisites.
7857 (callint.o): Depend on character.h.
7858
7859 * eval.c (internal_lisp_condition_case): Include the handler
7860 representation in the error message.
7861 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7862 when breaking from the loop.
7863
7864 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7865
7866 * callint.c (Fcall_interactively): When displaying error message
7867 about invalid control letter, pass the character's codepoint, not
7868 a pointer to its multibyte form. Improve display of the character
7869 in octal and display also its hex code.
7870
7871 * character.c (char_string): Use %x to display the (unsigned)
7872 codepoint of an invalid character, to avoid displaying a bogus
7873 negative value.
7874
7875 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7876 `error', not SYMBOL_NAME itself.
7877
7878 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7879 character arguments to `error'.
7880
7881 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7882 to `error' in error message about FINAL_CHAR argument. Make sure
7883 FINAL_CHAR is a character, and use %c when it is passed as
7884 argument to `error'.
7885
78862011-04-23 Eli Zaretskii <eliz@gnu.org>
7887
7888 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7889
7890 * w32.c: Include <time.h>.
7891 (sys_localtime): New function.
7892
78932011-04-23 Chong Yidong <cyd@stupidchicken.com>
7894
7895 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7896
7897 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7898
78992011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7900
7901 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7902 zombies (Bug#8467).
7903
79042011-04-19 Eli Zaretskii <eliz@gnu.org>
7905
7906 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7907 gl_state.e_property when gl_state.object is Qt.
7908
7909 * insdel.c (make_gap_larger): Remove limitation of buffer size
7910 to <= INT_MAX.
7911
79122011-04-18 Chong Yidong <cyd@stupidchicken.com>
7913
7914 * xdisp.c (lookup_glyphless_char_display)
7915 (produce_glyphless_glyph): Handle cons cell entry in
7916 glyphless-char-display.
7917 (Vglyphless_char_display): Document it.
7918
7919 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7920 glyphless-char-display.
7921
79222011-04-17 Chong Yidong <cyd@stupidchicken.com>
7923
7924 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7925
7926 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7927
7928 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7929 definition for no-X builds.
7930
79312011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7932
7933 Static checks with GCC 4.6.0 and non-default toolkits.
7934
7935 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7936
7937 * process.c (keyboard_bit_set): Define only if SIGIO.
7938 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7939 (send_process): Repair possible setjmp clobbering.
7940
7941 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7942
7943 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7944
7945 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7946
7947 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7948 Define only if needed.
7949
7950 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7951 by pacifying GCC about it. Maybe it's time to retire it?
7952 * xfaces.c (USG, __TIMEVAL__): Likewise.
7953
7954 * dispextern.h (struct redisplay_interface): Rename param
7955 to avoid shadowing.
7956 * termhooks.h (struct terminal): Likewise.
7957 * xterm.c (xembed_send_message): Likewise.
7958
7959 * insdel.c (make_gap_smaller): Define only if
7960 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7961
7962 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7963 it.
7964
7965 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7966 so that we aren't warned about unused symbols.
7967
7968 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7969
7970 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7971
7972 * xfns.c (x_real_positions): Mark locals as initialized.
7973
7974 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7975
7976 * xterm.c: Fix problems found by static analysis with other toolkits.
7977 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7978 (x_dispatch_event): Declare static if USE_GTK, and
7979 define if USE_GTK || USE_X_TOOLKIT.
7980 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7981 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7982 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7983 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7984
7985 * xmenu.c (menu_help_callback): Pointer type fixes.
7986 Use const pointers when pointing at readonly data. Avoid pointer
7987 signedness clashes.
7988 (FALSE): Remove unused macro.
7989 (update_frame_menubar): Remove unused decl.
7990
7991 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7992
7993 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7994 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7995 (single_menu_item): Rename local to avoid shadowing.
7996
7997 * keyboard.c (make_lispy_event): Remove unused local var.
7998
7999 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8000 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8001
8002 * bitmaps: Change bitmaps from unsigned char back to the X11
8003 compatible char. Avoid the old compiler warnings about
8004 out-of-range initializers by using, for example, '\xab' rather
8005 than 0xab.
8006
8007 * xgselect.c (xgselect_initialize): Check vs interface
8008 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8009
8010 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8011
8012 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8013 to read-only memory.
8014
8015 * fns.c (vector): Remove; this old hack is no longer needed.
8016
8017 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
8018 Remove unused var.
8019 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
8020
8021 * xrdb.c (x_load_resources): Omit unused local.
8022
8023 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8024 (x_window): Rename locals to avoid shadowing.
8025 (USG): Use the kludged USG macro, to pacify gcc.
8026
8027 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
8028 (x_term_init): Remove local to avoid shadowing.
8029
8030 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
8031
8032 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8033 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8034
80352011-04-16 Eli Zaretskii <eliz@gnu.org>
8036
8037 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8038
8039 Fix regex.c, syntax.c and friends for buffers > 2GB.
8040 * syntax.h (struct gl_state_s): Declare character position members
8041 EMACS_INT.
8042
8043 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8044
8045 * textprop.c (verify_interval_modification, interval_of):
8046 Declare arguments EMACS_INT.
8047
8048 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8049 EMACS_INT.
8050
8051 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8052
8053 * indent.c (Fvertical_motion): Local variable it_start is now
8054 EMACS_INT.
8055
8056 * regex.c (re_match, re_match_2, re_match_2_internal)
8057 (bcmp_translate, regcomp, regexec, print_double_string)
8058 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8059 (re_compile_pattern, re_exec): Declare arguments and local
8060 variables `size_t' and `ssize_t' and return values `regoff_t', as
8061 appropriate.
8062 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8063 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8064 <compile_stack_type>: `size' and `avail' are now `size_t'.
8065
8066 * regex.h <regoff_t>: Use ssize_t, not int.
8067 (re_search, re_search_2, re_match, re_match_2): Arguments that
8068 specify buffer/string position and length are now ssize_t and
8069 size_t. Return type is regoff_t.
8070
80712011-04-16 Ben Key <bkey76@gmail.com>
8072
8073 * nsfont.m: Fixed bugs in ns_get_family and
8074 ns_descriptor_to_entity that were caused by using free to
8075 deallocate memory blocks that were allocated by xmalloc (via
8076 xstrdup). This caused Emacs to crash when compiled with
8077 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8078 --enable-checking=xmallocoverrun). xfree is now used to
8079 deallocate these memory blocks.
8080
80812011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8082
8083 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8084
8085 emacs_write: Accept and return EMACS_INT for sizes.
8086 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8087 et seq.
8088 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8089 Accept and return EMACS_INT.
8090 (emacs_gnutls_write): Return the number of bytes written on
8091 partial writes.
8092 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8093 (emacs_read, emacs_write): Remove check for negative size, as the
8094 Emacs source code has been audited now.
8095 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8096 (emacs_read, emacs_write): Use it.
8097 * process.c (send_process): Adjust to the new signatures of
8098 emacs_write and emacs_gnutls_write. Do not attempt to store
8099 a byte offset into an 'int'; it might overflow.
8100 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8101
8102 * sound.c: Don't assume sizes fit in 'int'.
8103 (struct sound_device.period_size, alsa_period_size):
8104 Return EMACS_INT, not int.
8105 (struct sound_device.write, vox_write, alsa_write):
8106 Accept EMACS_INT, not int.
8107 (wav_play, au_play): Use EMACS_INT to store sizes and to
8108 record read return values.
8109
81102011-04-15 Ben Key <bkey76@gmail.com>
8111
8112 * keyboard.c (Qundefined): Don't declare static since it is used
8113 in nsfns.m.
8114 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8115 static since they are used in nsfont.m.
8116
81172011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8118
8119 * process.c (Qprocessp): Don't declare static.
8120 * lisp.h (Qprocessp): Declare again.
8121
81222011-04-15 Juanma Barranquero <lekktu@gmail.com>
8123
8124 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8125
81262011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8127
8128 Improve C-level modularity by making more things 'static'.
8129
8130 Don't publish debugger-only interfaces to other modules.
8131 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8132 (verify_bytepos, count_markers): Move decls to the only modules
8133 that need them.
8134 * region-cache.h (pp_cache): Likewise.
8135 * window.h (check_all_windows): Likewise.
8136 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8137
8138 * sysdep.c (croak): Now static, if
8139 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8140 * syssignal.h (croak): Declare only if not static.
8141
8142 * alloc.c (refill_memory_reserve): Now static if
8143 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8144 * lisp.h (refill_memory_reserve): Declare only if not static.
8145
8146 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8147 Define only if USE_LUCID.
8148
8149 * xrdb.c (x_customization_string, x_rm_string): Now static.
8150
8151 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8152 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8153
8154 * xdisp.c (draw_row_with_mouse_face): Now static.
8155 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8156
8157 * window.h (check_all_windows): Mark externally visible.
8158
8159 * window.c (window_deletion_count): Now static.
8160
8161 * undo.c: Make symbols static if they're not exported.
8162 (last_undo_buffer, last_boundary_position, pending_boundary):
8163 Now static.
8164
8165 * textprop.c (interval_insert_behind_hooks): Now static.
8166 (interval_insert_in_front_hooks): Likewise.
8167
8168 * term.c: Make symbols static if they're not exported.
8169 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8170 (max_frame_lines, tty_set_terminal_modes):
8171 (tty_reset_terminal_modes, tty_turn_off_highlight):
8172 (get_tty_terminal): Now static.
8173 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8174 * termhooks.h (term_mouse_moveto): Do not declare if
8175 HAVE_WINDOW_SYSTEM.
8176 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8177 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8178
8179 * sysdep.c: Make symbols static if they're not exported.
8180 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8181 Now static.
8182 (sigprocmask_set, full_mask): Remove; unused.
8183 (wait_debugging): Mark as visible.
8184 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8185 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8186
8187 * syntax.c (syntax_temp): Define only if !__GNUC__.
8188
8189 * sound.c (current_sound_device, current_sound): Now static.
8190
8191 * search.c (searchbufs, searchbuf_head): Now static.
8192
8193 * scroll.c (scroll_cost): Remove; unused.
8194 * dispextern.h (scroll_cost): Remove decl.
8195
8196 * region-cache.h (pp_cache): Mark as externally visible.
8197
8198 * process.c: Make symbols static if they're not exported.
8199 (process_tick, update_tick, create_process, chan_process):
8200 (Vprocess_alist, proc_buffered_char, datagram_access):
8201 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8202 (deactivate_process): Mark defn as static, as well as decl.
8203 * lisp.h (create_process): Remove decl.
8204 * process.h (chan_process, Vprocess_alist): Remove decls.
8205
8206 * print.c: Make symbols static if they're not exported.
8207 (print_depth, new_backquote_output, being_printed, print_buffer):
8208 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8209 (print_interval, print_number_index, initial_stderr_stream):
8210 Now static.
8211 * lisp.h (Fprinc): Remove decl.
8212 (debug_output_compilation_hack): Mark as externally visible.
8213
8214 * sysdep.c (croak): Move decl from here to syssignal.h.
8215 * syssignal.h (croak): Put it here, so the API can be checked when
8216 'croak' is called from dissociate_if_controlling_tty.
8217
8218 * minibuf.c: Make symbols static if they're not exported.
8219 (minibuf_save_list, choose_minibuf_frame): Now static.
8220 * lisp.h (choose_minibuf_frame): Remove decl.
8221
8222 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8223
8224 * lread.c: Make symbols static if they're not exported.
8225 (read_objects, initial_obarray, oblookup_last_bucket_number):
8226 Now static.
8227 (make_symbol): Remove; unused.
8228 * lisp.h (initial_obarray, make_symbol): Remove decls.
8229
8230 * keyboard.c: Make symbols static if they're not exported.
8231 (single_kboard, recent_keys_index, total_keys, recent_keys):
8232 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8233 (this_single_command_key_start, echoing, last_auto_save):
8234 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8235 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8236 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8237 (Vlispy_mouse_stem, double_click_count):
8238 Now static.
8239 (force_auto_save_soon): Define only if SIGDANGER.
8240 (ignore_mouse_drag_p): Now static if
8241 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8242 (print_help): Remove; unused.
8243 (stop_character, last_timer_event): Mark as externally visible.
8244 * keyboard.h (ignore_mouse_drag_p): Declare only if
8245 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8246 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8247 * lisp.h (echoing): Remove decl.
8248 (force_auto_save_soon): Declare only if SIGDANGER.
8249 * xdisp.c (redisplay_window): Simplify code, to make it more
8250 obvious that ignore_mouse_drag_p is not accessed if !defined
8251 USE_GTK && !defined HAVE_NS.
8252
8253 * intervals.c: Make symbols static if they're not exported.
8254 (merge_properties_sticky, merge_interval_right, delete_interval):
8255 Now static.
8256 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8257
8258 * insdel.c: Make symbols static if they're not exported.
8259 However, leave prepare_to_modify_buffer alone. It's never
8260 called from outside this function, but that appears to be a bug.
8261 (combine_after_change_list, combine_after_change_buffer):
8262 (adjust_after_replace, signal_before_change): Now static.
8263 (adjust_after_replace_noundo): Remove; unused.
8264 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8265 (signal_before_change): Remove decls.
8266
8267 * indent.c (val_compute_motion, val_vmotion): Now static.
8268
8269 * image.c: Make symbols static if they're not exported.
8270 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8271 if USE_GTK.
8272 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8273 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8274
8275 * fringe.c (standard_bitmaps): Now static.
8276 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8277
8278 * frame.c: Make symbols static if they're not exported.
8279 (x_report_frame_params, make_terminal_frame): Now static.
8280 (get_frame_param): Now static, unless HAVE_NS.
8281 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8282 (x_get_resource_string): Remove; not used.
8283 * frame.h (make_terminal_frame, x_report_frame_params):
8284 (x_get_resource_string); Remove decls.
8285 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8286 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8287
8288 * font.c, fontset.c: Make symbols static if they're not exported.
8289 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8290 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8291 * font.c (font_close_object): Now static.
8292 * font.h (font_close_object): Remove.
8293 * fontset.c (FONTSET_OBJLIST): Remove.
8294 (free_realized_fontset) #if-0 the body, which does nothing.
8295 (face_suitable_for_char_p): #if-0, as it's never called.
8296 * fontset.h (face_suitable_for_char_p): Remove decl.
8297 * xfaces.c (face_at_string_position):
8298 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8299 since 0 is always ASCII.
8300
8301 * fns.c (weak_hash_tables): Now static.
8302
8303 * fileio.c: Make symbols static if they're not exported.
8304 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8305 (Vwrite_region_annotation_buffers): Now static.
8306
8307 * eval.c: Make symbols static if they're not exported.
8308 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8309 * lisp.h (backtrace_list): Remove decl.
8310
8311 * emacs.c: Make symbols static if they're not exported.
8312 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8313 (fatal_error_code, fatal_error_signal_hook, standard_args):
8314 Now static.
8315 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8316 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8317 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8318 * lisp.h (fatal_error_signal_hook): Remove decl.
8319 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8320
8321 * editfns.c: Move a (normally-unused) function to its only use.
8322 * editfns.c, lisp.h (get_operating_system_release): Remove.
8323 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8324 worth the hassle of breaking this out.
8325
8326 * xterm.c: Make symbols static if they're not exported.
8327 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8328 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8329 (x_destroy_window, x_delete_display):
8330 Now static.
8331 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8332 (x_mouse_leave): Remove; unused.
8333 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8334 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8335 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8336 Remove decls.
8337 (x_mouse_leave): Declare only if WINDOWSNT.
8338 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8339 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8340 USE_X_TOOLKIT.
8341
8342 * ftxfont.c: Make symbols static if they're not exported.
8343 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8344 HAVE_FREETYPE.
8345 * font.h (ftxfont_driver): Likewise.
8346
8347 * xfns.c: Make symbols static if they're not exported.
8348 (x_last_font_name, x_display_info_for_name):
8349 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8350 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8351 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8352 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8353 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8354 (last_show_tip_args): Now static.
8355 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8356 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8357 (x_screen_planes): Remove; unused.
8358 * dispextern.h (x_screen_planes): Remove decl.
8359
8360 * dispnew.c: Make symbols static if they're not exported.
8361 * dispextern.h (redraw_garbaged_frames, scrolling):
8362 (increment_row_positions): Remove.
8363 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8364 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8365 Now static.
8366 (redraw_garbaged_frames): Remove; unused.
8367
8368 * xfaces.c: Make symbols static if they're not exported.
8369 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8370 Remove decls.
8371 * xterm.h (defined_color): Remove decls.
8372 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8373 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8374 (menu_face_changed_default, defined_color, free_realized_face):
8375 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8376 (ascii_face_of_lisp_face): Remove; unused.
8377
8378 * xdisp.c: Make symbols static if they're not exported.
8379 * dispextern.h (scratch_glyph_row, window_box_edges):
8380 (glyph_to_pixel_coords, set_cursor_from_row):
8381 (get_next_display_element, set_iterator_to_next):
8382 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8383 (show_mouse_face): Remove decls
8384 * frame.h (message_buf_print): Likewise.
8385 * lisp.h (pop_message, set_message, check_point_in_composition):
8386 Likewise.
8387 * xterm.h (set_vertical_scroll_bar): Likewise.
8388 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8389 (message_buf_print, scratch_glyph_row, displayed_buffer):
8390 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8391 (get_next_display_element, show_mouse_face, window_box_edges):
8392 (frame_to_window_pixel_xy, check_point_in_composition):
8393 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8394 (glyph_to_pixel_coords): Remove; unused.
8395
8396 * dired.c (file_name_completion): Now static.
8397
8398 * dbusbind.c (xd_in_read_queued_messages): Now static.
8399
8400 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8401 * data.c (circular_list_error): Remove.
8402
8403 * commands.h (last_point_position, last_point_position_buffer):
8404 (last_point_position_window): Remove decls.
8405 * keyboard.c: Make these variables static.
8406
8407 * coding.h (coding, code_convert_region, encode_coding_gap):
8408 Remove decls.
8409 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8410 (iso_code_class, detect_coding, code_convert_region): Now static.
8411 (encode_coding_gap): Remove; unused.
8412
8413 * chartab.c (chartab_chars, chartab_bits): Now static.
8414
8415 * charset.h (charset_iso_8859_1): Remove decl.
8416 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8417 Now static.
8418
8419 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8420 * ccl.c (Vccl_program_table): Now static.
8421 (check_ccl_update): Remove; unused.
8422
8423 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8424 * category.h: ... from here.
8425 * category.c (check_category_table, set_category_set): Now static.
8426
8427 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8428 * lisp.h: Remove these decls.
8429
8430 * buffer.c (buffer_count): Remove unused var.
8431
8432 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8433 so that it's not optimized away.
8434 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8435 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8436 exported only to the debugger.
8437
8438 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8439 * atimer.h (run_all_atimers): Remove; not exported.
8440
8441 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8442 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8443 was inaccessible from Lisp.
8444 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8445 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8446
8447 alloc.c: Import and export fewer symbols, and remove unused items.
8448 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8449 is defined.
8450 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8451 it's not optimized away by whole-program optimization.
8452 (message_enable_multibyte, free_misc): Remove.
8453 (catchlist, handlerlist, mark_backtrace):
8454 Declare only if BYTE_MARK_STACK.
8455 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8456 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8457 (message_enable_multibyte): Remove decl.
8458 (free_misc, interval_free_list, float_block, float_block_index):
8459 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8460 (cons_free_list, last_marked_index):
8461 Now static.
8462 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8463 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8464 (mark_backtrace): Define only if BYTE_MARK_STACK.
8465 * xdisp.c (message_enable_multibyte): Now static.
8466
8467 Declare Lisp_Object Q* variables to be 'static' if not exported.
8468 This makes it easier for human readers (and static analyzers)
8469 to see whether these variables are used from other modules.
8470 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8471 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8472 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8473 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8474 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8475 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8476 * xmenu.c, xselect.c:
8477 Declare Q* vars static if they are not used in other modules.
8478 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8479 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8480 Remove decls of unexported vars.
8481 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8482
8483 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8484
8485 Make Emacs functions such as Fatom 'static' by default.
8486 This makes it easier for human readers (and static analyzers)
8487 to see whether these functions can be called from other modules.
8488 DEFUN now defines a static function. To make the function external
8489 so that it can be used in other C modules, use the new macro DEFUE.
8490 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8491 (Finit_image_library):
8492 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8493 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8494 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8495 Remove decls, since these functions are now static.
8496 (Funintern, Fget_internal_run_time): New decls, since these functions
8497 were already external.
8498
8499 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8500 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8501 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8502 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8503 * keyboard.c, keymap.c, lread.c:
8504 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8505 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8506 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8507 Mark functions with DEFUE instead of DEFUN,
8508 if they are used in other modules.
8509 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8510 decls for now-static functions.
8511 * buffer.h (Fdelete_overlay): Remove decl.
8512 * callproc.c (Fgetenv_internal): Mark as internal.
8513 * composite.c (Fremove_list_of_text_properties): Remove decl.
8514 (Fcomposition_get_gstring): New forward static decl.
8515 * composite.h (Fcomposite_get_gstring): Remove decl.
8516 * dired.c (Ffile_attributes): New forward static decl.
8517 * doc.c (Fdocumntation_property): New forward static decl.
8518 * eval.c (Ffetch_bytecode): New forward static decl.
8519 (Funintern): Remove extern decl; now in .h file where it belongs.
8520 * fileio.c (Fmake_symbolic_link): New forward static decl.
8521 * image.c (Finit_image_library): New forward static decl.
8522 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8523 * intervals.h (Fprevious_property_change):
8524 (Fremove_list_of_text_properties): Remove decls.
8525 * keyboard.c (Fthis_command_keys): Remove decl.
8526 (Fcommand_execute): New forward static decl.
8527 * keymap.c (Flookup_key): New forward static decl.
8528 (Fcopy_keymap): Now static.
8529 * keymap.h (Flookup_key): Remove decl.
8530 * process.c (Fget_process): New forward static decl.
8531 (Fprocess_datagram_address): Mark as internal.
8532 * syntax.c (Fsyntax_table_p): New forward static decl.
8533 (skip_chars): Remove duplicate decl.
8534 * textprop.c (Fprevious_property_change): New forward static decl.
8535 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8536 Now internal.
8537 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8538 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8539
8540 * editfns.c (Fformat): Remove unreachable code.
8541
85422011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8543
8544 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8545 change. (Bug#8496)
8546
85472011-04-13 Eli Zaretskii <eliz@gnu.org>
8548
8549 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8550 when at ZV. (Bug#8487)
8551
85522011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8553
8554 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8555 (Bug#8437)
8556 * keyboard.c (parse_tool_bar_item): Likewise.
8557 * sound.c (sound_cleanup, alsa_close): Likewise.
8558 * termcap.c (tgetent): Likewise.
8559 * xfns.c (x_default_font_parameter): Likewise.
8560 * xsettings.c (read_and_apply_settings): Likewise.
8561
8562 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8563 (overrun_check_free): Protoize.
8564
85652011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8566
8567 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8568 since callers should never pass a negative size.
8569 Change the signature to match that of plain 'read' and 'write'; see
8570 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8571 * lisp.h: Update prototypes of emacs_write and emacs_read.
8572
85732011-04-11 Eli Zaretskii <eliz@gnu.org>
8574
8575 * xdisp.c (redisplay_window): Don't try to determine the character
8576 position of the scroll margin if the window start point w->startp
8577 is outside the buffer's accessible region. (Bug#8468)
8578
85792011-04-10 Eli Zaretskii <eliz@gnu.org>
8580
8581 Fix write-region and its subroutines for buffers > 2GB.
8582 * fileio.c (a_write, e_write): Modify declaration of arguments and
8583 local variables to support buffers larger than 2GB.
8584 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8585
8586 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8587 argument, local variables, and return value.
8588
8589 * lisp.h: Update prototypes of emacs_write and emacs_read.
8590
8591 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8592
85932011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8594
8595 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8596
8597 Fix more problems found by GCC 4.6.0's static checks.
8598
8599 * xdisp.c (vmessage): Use a better test for character truncation.
8600
8601 * charset.c (load_charset_map): <, not <=, for optimization,
8602 and to avoid potential problems with integer overflow.
8603 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8604 * casetab.c (set_identity, shuffle): Likewise.
8605 * editfns.c (Fformat): Likewise.
8606 * syntax.c (skip_chars): Likewise.
8607
8608 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8609 This also lets GCC 4.6.0 generate slightly better loop code.
8610
8611 * callint.c (Fcall_interactively): <, not <=, for optimization.
8612 (Fcall_interactively): Count the number of arguments produced,
8613 not the number of arguments given. This is simpler and lets GCC
8614 4.6.0 generate slightly better code.
8615
8616 * ftfont.c: Distingish more carefully between FcChar8 and char.
8617 The previous code passed unsigned char * to a functions like
8618 strlen and xstrcasecmp that expect char *, which does not
8619 conform to the C standard.
8620 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8621 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8622 char * when the C standard requires it.
8623
8624 * keyboard.c (read_char): Remove unused var.
8625
8626 * eval.c: Port to Windows vsnprintf (Bug#8435).
8627 Include <limits.h>.
8628 (SIZE_MAX): Define if the headers do not.
8629 (verror): Do not give up if vsnprintf returns a negative count.
8630 Instead, grow the buffer. This ports to Windows vsnprintf, which
8631 does not conform to C99. Problem reported by Eli Zaretskii.
8632 Also, simplify the allocation scheme, by avoiding the need for
8633 calling realloc, and removing the ALLOCATED variable.
8634
8635 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8636
8637 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8638 But keep the doprint source code for now, as we might revamp it
8639 and use it again (Bug#8435).
8640 * lisp.h (doprnt): Remove.
8641 * Makefile.in (base_obj): Remove doprnt.o.
8642 * deps.mk (doprnt.o): Remove.
8643
8644 error: Print 32- and 64-bit integers portably (Bug#8435).
8645 Without this change, on typical 64-bit hosts error ("...%d...", N)
8646 was used to print both 32- and 64-bit integers N, which relied on
8647 undefined behavior.
8648 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8649 * lisp.h (error, verror): Mark as printf-like functions.
8650 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8651 Report overflow in size calculations when allocating printf buffer.
8652 Do not truncate output string at its first null byte.
8653 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8654 Truncate the output at a character boundary, since vsnprintf does not
8655 do that.
8656 * charset.c (check_iso_charset_parameter): Convert internal
8657 character to string before calling 'error', since %c now has the
8658 printf meaning.
8659 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8660 overflow when computing char to be passed to 'error'. Do not
8661 pass Lisp_Object to 'error'; pass the integer instead.
8662 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8663 formatted with plain %d.
8664
8665 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8666
8667 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8668
8669 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8670
8671 * xterm.c (x_catch_errors): Remove duplicate declaration.
8672
8673 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8674
8675 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8676
86772011-04-10 Jim Meyering <meyering@redhat.com>
8678
8679 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8680 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8681 return ssize_t not "int", and use size_t as the buffer length.
8682 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8683 * gnutls.h: Update declarations.
8684 * process.c (read_process_output): Use ssize_t, to match.
8685 (send_process): Likewise.
8686
86872011-04-09 Chong Yidong <cyd@stupidchicken.com>
8688
8689 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8690
86912011-04-09 Chong Yidong <cyd@stupidchicken.com>
8692
8693 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8694 Use unsigned char, to match FcChar8 type definition.
8695
8696 * xterm.c (handle_one_xevent):
8697 * xmenu.c (create_and_show_popup_menu):
8698 * xselect.c (x_decline_selection_request)
8699 (x_reply_selection_request): Avoid type-punned deref of X events.
8700
87012011-04-09 Eli Zaretskii <eliz@gnu.org>
8702
8703 Fix some uses of `int' instead of EMACS_INT.
8704 * search.c (string_match_1, fast_string_match)
8705 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8706 (scan_buffer, find_next_newline_no_quit)
8707 (find_before_next_newline, search_command, Freplace_match)
8708 (Fmatch_data): Make some `int' variables be EMACS_INT.
8709
8710 * xdisp.c (display_count_lines): 3rd argument and return value now
8711 EMACS_INT. All callers changed.
8712 (pint2hrstr): Last argument is now EMACS_INT.
8713
8714 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8715 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8716 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8717 (decode_coding_utf_16, decode_coding_emacs_mule)
8718 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8719 (decode_coding_ccl, decode_coding_charset)
8720 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8721 (decode_coding_iso_2022, decode_coding_emacs_mule)
8722 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8723 <char_offset, last_offset>: Declare EMACS_INT.
8724 (encode_coding_utf_8, encode_coding_utf_16)
8725 (encode_coding_emacs_mule, encode_invocation_designation)
8726 (encode_designation_at_bol, encode_coding_iso_2022)
8727 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8728 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8729 Declare EMACS_INT.
8730 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8731 (encode_invocation_designation): Last argument P_NCHARS is now
8732 EMACS_INT.
8733 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8734 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8735
8736 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8737 All users changed.
8738
8739 * ccl.c (Fccl_execute_on_string): Declare some variables
8740 EMACS_INT.
8741
87422011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8743
8744 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8745
87462011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8747
8748 * process.c (Fformat_network_address): Doc fix.
8749
87502011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8751
8752 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8753
87542011-04-08 Chong Yidong <cyd@stupidchicken.com>
8755
8756 * keyboard.c (read_char): Call Lisp function help-form-show,
8757 instead of using internal_with_output_to_temp_buffer.
8758 (Qhelp_form_show): New var.
8759 (syms_of_keyboard): Use DEFSYM macro.
8760
8761 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8762
8763 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8764
87652011-04-06 Chong Yidong <cyd@stupidchicken.com>
8766
8767 * process.c (Flist_processes): Remove to Lisp.
8768 (list_processes_1): Delete.
8769
87702011-04-06 Eli Zaretskii <eliz@gnu.org>
8771
8772 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8773
8774 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8775
87762011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8777
8778 Fix more problems found by GCC 4.6.0's static checks.
8779
8780 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8781
8782 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8783
8784 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8785
8786 * xdisp.c (vmessage): Mark as a printf-like function.
8787
8788 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8789
8790 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8791
8792 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8793 printf-like functions.
8794 (tiff_load): Add casts to remove these marks before passing them
8795 to system-supplied API.
8796
8797 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8798
8799 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8800 This avoids several warnings with gcc -Wstrict-overflow.
8801 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8802 directly, rather than having caller test rule sign. This avoids
8803 some unnecessary tests.
8804 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8805 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8806 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8807
8808 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8809 (xfont_open): Avoid unnecessary tests.
8810
8811 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8812
8813 * composite.h, composite.c (composition_gstring_put_cache):
8814 Use EMACS_INT, not int, for length.
8815
8816 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8817 breaking out part of COMPOSITION_DECODE_RULE.
8818 (COMPOSITION_DECODE_RULE): Use it.
8819 * composite.c (get_composition_id): Remove unused local vars,
8820 by using the new macro.
8821
8822 * textprop.c (set_text_properties_1): Change while to do-while,
8823 since the condition is always true at first.
8824
8825 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8826 (interval_deletion_adjustment): Return unsigned value.
8827 All uses changed.
8828
8829 * process.c (list_processes_1, create_pty, read_process_output):
8830 (exec_sentinel): Remove vars that were set but not used.
8831 (create_pty): Remove unnecessary "volatile"s.
8832 (Fnetwork_interface_info): Avoid possibility of int overflow.
8833 (read_process_output): Do adaptive read buffering even if carryover.
8834 (read_process_output): Simplify nbytes computation if buffered.
8835
8836 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8837
8838 * syntax.c (scan_words): Remove var that was set but not used.
8839 (update_syntax_table): Use unsigned instead of int.
8840
8841 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8842 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8843 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8844
8845 * print.c (print_error_message): Avoid int overflow.
8846
8847 * font.c (font_list_entities): Redo for clarity,
8848 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8849
8850 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8851 (font_score): Avoid potential overflow in diff calculation.
8852
8853 * fns.c (substring_both): Remove var that is set but not used.
8854 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8855
8856 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8857
8858 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8859 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8860 can always succeed if overflow has undefined behavior.
8861
8862 * search.c (boyer_moore, wordify): Remove vars set but not used.
8863 (wordify): Omit three unnecessary tests.
8864
8865 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8866 All callers changed. This avoids the need for an unused var.
8867
8868 * casefiddle.c (casify_region): Remove var that is set but not used.
8869
8870 * dired.c (file_name_completion): Remove var that is set but not used.
8871
8872 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8873
8874 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8875 (Finsert_file_contents): Remove unnecessary code checking fd.
8876
8877 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8878 Check for integer overflow on size calculations.
8879
8880 * buffer.c (Fprevious_overlay_change): Remove var that is set
8881 but not used.
8882
8883 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8884 Remove vars that are set but not used.
8885 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8886 (timer_check_2): Mark vars as initialized.
8887
8888 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8889
8890 * image.c (lookup_image): Remove var that is set but not used.
8891 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8892
8893 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8894 that are set but not used.
8895
8896 * xfns.c (make_invisible_cursor): Don't return garbage
8897 if XCreateBitmapFromData fails (Bug#8410).
8898
8899 * xselect.c (x_get_local_selection, x_handle_property_notify):
8900 Remove vars that are set but not used.
8901
8902 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8903 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8904
8905 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8906 Remove var that is set but not used.
8907 (scroll_bar_windows_size): Now size_t, not int.
8908 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8909 Check for overflow.
8910
8911 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8912 (map_tty_color) [!defined MSDOS]: Likewise.
8913
8914 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8915
8916 * coding.c: Remove vars that are set but not used.
8917 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8918 All callers changed.
8919 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8920 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8921 (decode_coding_charset): Remove vars that are set but not used.
8922
8923 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8924 that is set but not used.
8925
8926 * print.c (print_object): Remove var that is set but not used.
8927
8928 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8929 The gnulib version avoids calling malloc in the usual case,
8930 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8931 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8932 * filelock.c (current_lock_owner): Likewise.
8933 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8934 * sysdep.c: Include allocator.h, careadlinkat.h.
8935 (emacs_no_realloc_allocator): New static constant.
8936 (emacs_readlink): New function.
8937 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8938 ../lib/careadlinkat.h.
8939
89402011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8941
8942 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8943 first non-nil return value).
8944
89452011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8946
8947 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8948 if not defined (Bug#8403).
8949
89502011-04-02 Juanma Barranquero <lekktu@gmail.com>
8951
8952 * xdisp.c (display_count_lines): Remove parameter `start',
8953 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8954 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8955 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8956 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8957 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8958 and thereabouts. All callers changed.
8959 (get_per_char_metric): Remove parameter `f', unused since
8960 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8961
89622011-04-02 Jim Meyering <meyering@redhat.com>
8963
8964 do not dereference NULL upon failed strdup
8965 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8966 (ns_get_family): Likewise.
8967
89682011-04-02 Juanma Barranquero <lekktu@gmail.com>
8969
8970 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8971
89722011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8973
8974 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8975 later (Bug#8403).
8976
89772011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8978
8979 Add lexical binding.
8980
8981 * window.c (Ftemp_output_buffer_show): New fun.
8982 (Fsave_window_excursion):
8983 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8984
8985 * lread.c (lisp_file_lexically_bound_p): New function.
8986 (Fload): Bind Qlexical_binding.
8987 (readevalloop): Remove `evalfun' arg.
8988 Bind Qinternal_interpreter_environment.
8989 (Feval_buffer): Bind Qlexical_binding.
8990 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8991 Mark as dynamic.
8992 (syms_of_lread): Declare `lexical-binding'.
8993
8994 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8995
8996 * keyboard.c (eval_dyn): New fun.
8997 (menu_item_eval_property): Use it.
8998
8999 * image.c (parse_image_spec): Use Ffunctionp.
9000
9001 * fns.c (concat, mapcar1): Accept byte-code-functions.
9002
9003 * eval.c (Fsetq): Handle lexical vars.
9004 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9005 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9006 (FletX, Flet): Obey lexical binding.
9007 (Fcommandp): Handle closures.
9008 (Feval): New `lexical' arg.
9009 (eval_sub): New function extracted from Feval. Use it almost
9010 everywhere where Feval was used. Look up vars in lexical env.
9011 Handle closures.
9012 (Ffunctionp): Move from subr.el.
9013 (Ffuncall): Handle closures.
9014 (apply_lambda): Remove `eval_flags'.
9015 (funcall_lambda): Handle closures and new byte-code-functions.
9016 (Fspecial_variable_p): New function.
9017 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9018 but without exporting it to Lisp.
9019
9020 * doc.c (Fdocumentation, store_function_docstring):
9021 * data.c (Finteractive_form): Handle closures.
9022
9023 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9024 interactive spec.
9025
9026 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9027 New byte-codes.
9028 (exec_byte_code): New function extracted from Fbyte_code to handle new
9029 calling convention for byte-code-functions. Add new byte-codes.
9030
9031 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
9032
9033 * alloc.c (Fmake_symbol): Init new `declared_special' field.
9034
90352011-03-31 Juanma Barranquero <lekktu@gmail.com>
9036
9037 * xdisp.c (redisplay_internal): Fix prototype.
9038
90392011-03-31 Eli Zaretskii <eliz@gnu.org>
9040
9041 * xdisp.c (SCROLL_LIMIT): New macro.
9042 (try_scrolling): Use it when setting scroll_limit.
9043 Limit scrolling to 100 screen lines.
9044 (redisplay_window): Even when falling back on "recentering",
9045 position point in the window according to scroll-conservatively,
9046 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9047
9048 (try_scrolling): When point is above the window, allow searching
9049 as far as scroll_max, or one screenful, to compute vertical
9050 distance from PT to the scroll margin position. This prevents
9051 try_scrolling from unnecessarily failing when
9052 scroll-conservatively is set to a value slightly larger than the
9053 window height. Clean up the case of PT below the margin at bottom
9054 of window: scroll_max can no longer be INT_MAX. When aggressive
9055 scrolling is in use, don't let point enter the opposite scroll
9056 margin as result of the scroll.
9057 (syms_of_xdisp) <scroll-conservatively>: Document the
9058 threshold of 100 lines for never-recentering scrolling.
9059
90602011-03-31 Juanma Barranquero <lekktu@gmail.com>
9061
9062 * dispextern.h (move_it_by_lines):
9063 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9064 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9065 (message_log_check_duplicate): Remove parameters `prev_bol' and
9066 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9067 (redisplay_internal): Remove parameter `preserve_echo_area',
9068 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9069
9070 * indent.c (Fvertical_motion):
9071 * window.c (window_scroll_pixel_based, Frecenter):
9072 Don't pass `need_y_p' to `move_it_by_lines'.
9073
90742011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9075
9076 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9077 steal a few bits to be more compact.
9078 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9079 Remove unneeded casts.
9080
9081 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9082
90832011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9084
9085 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9086 binding" message (bug#7967).
9087
90882011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9089
9090 Fix more problems found by GCC 4.6.0's static checks.
9091
9092 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9093 Remove unused local var.
9094
9095 * editfns.c (Fmessage_box): Remove unused local var.
9096
9097 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9098 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9099 Omit unused local vars.
9100 * window.c (shrink_windows): Omit unused local var.
9101 * menu.c (digest_single_submenu): Omit unused local var.
9102 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9103 Omit unused local var.
9104
9105 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9106 Don't assume string length fits in int.
9107 (keyremap_step, read_key_sequence): Use size_t for sizes.
9108 (read_key_sequence): Don't check last_real_key_start redundantly.
9109
9110 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9111 instead of alloca (Bug#8344).
9112
9113 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9114 (Fbacktrace_frame): Don't assume nframes fits in int.
9115
9116 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9117
9118 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9119 concerns.
9120
9121 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9122
9123 * cm.c (calccost): Turn while-do into do-while, for clarity.
9124
9125 * keyboard.c (syms_of_keyboard): Use the same style as later
9126 in this function when indexing through an array. This also
9127 works around GCC bug 48267.
9128
9129 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9130
9131 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9132
9133 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9134 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9135
9136 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9137 This avoids undefined behavior on integer overflow, and is a bit
9138 more convenient anyway since it is compared to a size_t variable.
9139
9140 Variadic C functions now count arguments with size_t, not int.
9141 This avoids an unnecessary limitation on 64-bit machines, which
9142 caused (substring ...) to crash on large vectors (Bug#8344).
9143 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9144 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9145 All variadic functions and their callers changed accordingly.
9146 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9147 * data.c (arith_driver, float_arith_driver): Likewise.
9148 * editfns.c (general_insert_function): Likewise.
9149 * eval.c (struct backtrace.nargs, interactive_p)
9150 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9151 (funcall_lambda, mark_backtrace): Likewise.
9152 * fns.c (concat): Likewise.
9153 * frame.c (x_set_frame_parameters): Likewise.
9154 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9155 0 if not found, not -1. All callers changed.
9156
9157 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9158 (stack_copy_size): Now size_t, not int.
9159 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9160
91612011-03-28 Juanma Barranquero <lekktu@gmail.com>
9162
9163 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9164 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9165 All callers changed.
9166
9167 * lisp.h (multibyte_char_to_unibyte):
9168 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9169 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9170 * character.h (CHAR_TO_BYTE8):
9171 * cmds.c (internal_self_insert):
9172 * editfns.c (general_insert_function):
9173 * keymap.c (push_key_description):
9174 * search.c (Freplace_match):
9175 * xdisp.c (message_dolog, set_message_1): All callers changed.
9176
91772011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9178
9179 * keyboard.c (safe_run_hook_funcall): New function.
9180 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9181 don't set the hook to nil, but remove the offending function instead.
9182 (Qcommand_hook_internal): Remove, unused.
9183 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9184 Vcommand_hook_internal.
9185
9186 * eval.c (enum run_hooks_condition): Remove.
9187 (funcall_nil, funcall_not): New functions.
9188 (run_hook_with_args): Call each function through a `funcall' argument.
9189 Remove `cond' argument, now redundant.
9190 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9191 (Frun_hook_with_args_until_failure): Adjust accordingly.
9192 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9193
91942011-03-28 Juanma Barranquero <lekktu@gmail.com>
9195
9196 * dispextern.h (string_buffer_position): Remove declaration.
9197
9198 * print.c (strout): Remove parameter `multibyte', unused since
9199 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9200
9201 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9202 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9203 All callers changed.
9204
9205 * w32.c (_wsa_errlist): Use braces for struct initializers.
9206
9207 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9208 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9209 All callers changed.
9210 (string_buffer_position): Likewise. Also, make static (it's never
9211 used outside xdisp.c).
9212 (cursor_row_p): Remove parameter `w', unused since
9213 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9214 (decode_mode_spec): Remove parameter `precision', introduced during
9215 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9216 All callers changed.
9217
92182011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9219
9220 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9221
92222011-03-27 Anders Lindgren <andlind@gmail.com>
9223
9224 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9225 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9226 (ns_update_auto_hide_menu_bar): New functions.
9227 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9228 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9229 ns_constrain_all_frames.
9230 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9231 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9232
92332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9234
9235 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9236
92372011-03-27 Glenn Morris <rgm@gnu.org>
9238
9239 * syssignal.h: Replace RETSIGTYPE with void.
9240 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9241 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9242 Replace SIGTYPE with void everywhere.
9243 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9244 * s/template.h (SIGTYPE): Remove commented out definition.
9245
92462011-03-26 Eli Zaretskii <eliz@gnu.org>
9247
9248 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9249 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9250
92512011-03-26 Juanma Barranquero <lekktu@gmail.com>
9252
9253 * w32.c (read_unc_volume): Use parameter `henum', instead of
9254 global variable `wget_enum_handle'.
9255
9256 * keymap.c (describe_vector): Remove parameters `indices' and
9257 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9258 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9259
9260 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9261
9262 * keyboard.c (timer_check): Remove parameter `do_it_now',
9263 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9264 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9265 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9266
9267 * keyboard.c (read_char):
9268 * w32menu.c (w32_menu_display_help):
9269 * xmenu.c (show_help_event, menu_help_callback):
9270 Adjust calls to `show_help_echo'.
9271
9272 * gtkutil.c (xg_maybe_add_timer):
9273 * keyboard.c (readable_events):
9274 * process.c (wait_reading_process_output):
9275 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9276
9277 * insdel.c (adjust_markers_gap_motion):
9278 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9279 (gap_left, gap_right): Don't call it.
9280
92812011-03-25 Chong Yidong <cyd@stupidchicken.com>
9282
9283 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9284 incurred during fontification.
9285
92862011-03-25 Juanma Barranquero <lekktu@gmail.com>
9287
9288 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9289 (DEFVAR_PER_BUFFER): Don't pass it.
9290
9291 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9292 (scrolling_window): Don't pass it.
9293
92942011-03-25 Juanma Barranquero <lekktu@gmail.com>
9295
9296 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9297
9298 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9299 and `suffix'.
9300 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9301 of variables specific to SELinux and computation of `encoded_absname'.
9302
9303 * image.c (XPutPixel): Remove unused variable `height'.
9304
9305 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9306
9307 * unexw32.c (get_section_info): Remove unused variable `section'.
9308
9309 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9310 (system_process_attributes): Remove unused variable `sess'.
9311 (sys_read): Remove unused variable `err'.
9312
9313 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9314 (w32_wnd_proc): Remove unused variable `isdead'.
9315 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9316 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9317 (x_create_tip_frame): Remove unused variable `tem'.
9318
9319 * w32inevt.c (w32_console_read_socket):
9320 Remove unused variable `no_events'.
9321
9322 * w32term.c (x_draw_composite_glyph_string_foreground):
9323 Remove unused variable `width'.
9324
93252011-03-24 Juanma Barranquero <lekktu@gmail.com>
9326
9327 * w32term.c (x_set_glyph_string_clipping):
9328 Don't pass uninitialized region to CombineRgn.
9329
93302011-03-23 Juanma Barranquero <lekktu@gmail.com>
9331
9332 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9333 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9334 (Fx_close_connection): Remove unused variable `i'.
9335
9336 * w32font.c (w32font_draw): Return number of glyphs.
9337 (w32font_open_internal): Remove unused variable `i'.
9338 (w32font_driver): Add missing initializer.
9339
9340 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9341 (fill_in_menu): Remove unused variable `items_added'.
9342
9343 * w32term.c (last_mouse_press_frame): Remove static global variable.
9344 (w32_clip_to_row): Remove unused variable `f'.
9345 (x_delete_terminal): Remove unused variable `i'.
9346
9347 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9348 (NOTHING): Remove unused static global variable.
9349 (uniscribe_check_otf): Remove unused variable `table'.
9350 (uniscribe_font_driver): Add missing initializers.
9351
93522011-03-23 Julien Danjou <julien@danjou.info>
9353
9354 * term.c (Fsuspend_tty, Fresume_tty):
9355 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9356 * window.c (temp_output_buffer_show):
9357 * insdel.c (signal_before_change):
9358 * frame.c (Fhandle_switch_frame):
9359 * fileio.c (Fdo_auto_save):
9360 * emacs.c (Fkill_emacs):
9361 * editfns.c (save_excursion_restore):
9362 * cmds.c (internal_self_insert):
9363 * callint.c (Fcall_interactively):
9364 * buffer.c (Fkill_all_local_variables):
9365 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9366 Use Frun_hooks.
9367 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9368 unconditionally since it does the check itself.
9369
93702011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9371
9372 Fix more problems found by GCC 4.5.2's static checks.
9373
9374 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9375 the first time through the loop, since we know p0 < p1 then.
9376 This also avoids a gcc -Wstrict-overflow warning.
9377
9378 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9379 leading to a memory leak, possible in functions like
9380 load_charset_map_from_file that can allocate an unbounded number
9381 of objects (Bug#8318).
9382
9383 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9384 that could (at least in theory) be that large.
9385
9386 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9387 This is less likely to overflow, and avoids undefined behavior if
9388 overflow does occur. All callers changed. Use strtoul to scan
9389 for the unsigned long integer.
9390 (pint2hrstr): Simplify and tune code slightly.
9391 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9392
9393 * scroll.c (do_scrolling): Work around GCC bug 48228.
9394 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9395
9396 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9397 This also avoids a warning with gcc -Wstrict-overflow.
9398 (validate_x_resource_name): Simplify count usage.
9399 This also avoids a warning with gcc -Wstrict-overflow.
9400
9401 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9402 fail (Bug#8306).
9403
9404 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9405
9406 * process.c (Fmake_network_process): Use socklen_t, not int,
9407 where POSIX says socklen_t is required in portable programs.
9408 This fixes a porting bug on hosts like 64-bit HP-UX, where
9409 socklen_t is wider than int (Bug#8277).
9410 (Fmake_network_process, server_accept_connection):
9411 (wait_reading_process_output, read_process_output):
9412 Likewise.
9413
9414 * process.c: Rename or move locals to avoid shadowing.
9415 (list_processes_1, Fmake_network_process):
9416 (read_process_output_error_handler, exec_sentinel_error_handler):
9417 Rename or move locals.
9418 (Fmake_network_process): Define label "retry_connect" only if needed.
9419 (Fnetwork_interface_info): Fix pointer signedness.
9420 (process_send_signal): Add cast to avoid pointer signedness problem.
9421 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9422 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9423
9424 Make tparam.h and terminfo.c consistent.
9425 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9426 Include tparam.h instead, since it declares them.
9427 * cm.h (PC): Remove extern decl; tparam.h now does this.
9428 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9429 * terminfo.c: Include tparam.h, to check interfaces.
9430 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9431 (tparam): Adjust signature to match interface in tparam.h;
9432 this removes some undefined behavior. Check that outstring and len
9433 are zero, which they always are with Emacs.
9434 * tparam.h (PC, BC, UP): New extern decls.
9435
9436 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9437 (xftfont_open): Rename locals to avoid shadowing.
9438
9439 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9440 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9441 (OTF_TAG_SYM): Omit macro if not needed.
9442 (ftfont_list): Remove unused local.
9443 (get_adstyle_property, ftfont_pattern_entity):
9444 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9445 Rename locals to avoid shadowing.
9446
9447 * xfont.c (xfont_list_family): Mark var as initialized.
9448
9449 * xml.c (make_dom): Now static.
9450
9451 * composite.c (composition_compute_stop_pos): Rename local to
9452 avoid shadowing.
9453 (composition_reseat_it): Remove unused locals.
9454 (find_automatic_composition, composition_adjust_point): Likewise.
9455 (composition_update_it): Mark var as initialized.
9456 (find_automatic_composition): Mark vars as initialized,
9457 with a FIXME (Bug#8290).
9458
9459 character.h: Rename locals to avoid shadowing.
9460 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9461 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9462 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9463 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9464 to avoid shadowing.
9465
9466 * textprop.c (property_change_between_p): Remove; unused.
9467
9468 * intervals.c (interval_start_pos): Now static.
9469
9470 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9471
9472 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9473 Rename locals to avoid shadowing.
9474
9475 * sound.c (wav_play, au_play, Fplay_sound_internal):
9476 Fix pointer signedness.
9477 (alsa_choose_format): Remove unused local var.
9478 (wav_play): Initialize a variable to 0, to prevent undefined
9479 behavior (Bug#8278).
9480
9481 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9482
9483 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9484
9485 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9486 clobbering (Bug#8298).
9487 * sysdep.c (sys_subshell): Likewise.
9488 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9489
9490 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9491 This should get cleaned up, so that child_setup has the
9492 same signature on all platforms.
9493
9494 * callproc.c (call_process_cleanup): Now static.
9495 (relocate_fd): Rename locals to avoid shadowing.
9496
94972011-03-22 Chong Yidong <cyd@stupidchicken.com>
9498
9499 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9500 not to be necessary, and produces flickering.
9501
95022011-03-20 Glenn Morris <rgm@gnu.org>
9503
9504 * config.in: Remove file.
9505
95062011-03-20 Juanma Barranquero <lekktu@gmail.com>
9507
9508 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9509 are now in src/globals.h.
9510 (syms_of_minibuf): Remove spurious & from previous change.
9511
95122011-03-20 Leo Liu <sdl.web@gmail.com>
9513
9514 * minibuf.c (completing-read-function): New variable.
9515 (completing-read-default): Rename from completing-read.
9516 (completing-read): Call completing-read-function.
9517
95182011-03-19 Juanma Barranquero <lekktu@gmail.com>
9519
9520 * xfaces.c (Fx_load_color_file):
9521 Read color file from absolute filename (bug#8250).
9522
95232011-03-19 Juanma Barranquero <lekktu@gmail.com>
9524
9525 * makefile.w32-in: Update dependencies.
9526
95272011-03-17 Eli Zaretskii <eliz@gnu.org>
9528
9529 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9530
95312011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9532
9533 Fix more problems found by GCC 4.5.2's static checks.
9534
9535 * process.c (make_serial_process_unwind, send_process_trap):
9536 (sigchld_handler): Now static.
9537
9538 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9539 That way, the code declares only the vars that it needs.
9540 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9541 * s/cygwin.h (PTY_ITERATION): Likewise.
9542 * s/darwin.h (PTY_ITERATION): Likewise.
9543 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9544
9545 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9546 * process.c (allocate_pty): Don't declare stb unless it's needed.
9547
9548 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9549 (CONSTANTLIM): Remove; unused.
9550 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9551 Define only if needed.
9552
9553 * unexelf.c (unexec): Name an expression,
9554 to avoid gcc -Wbad-function-cast warning.
9555 Use a different way to cause a compilation error if anyone uses
9556 n rather than nn, a way that does not involve shadowing.
9557 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9558
9559 * deps.mk (unexalpha.o): Remove; unused.
9560
9561 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9562 * unexec.h: New file.
9563 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9564 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9565 Depend on unexec.h.
9566 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9567 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9568 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9569 Change as necessary to match prototype in unexec.h.
9570
9571 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9572 shadowing.
9573 (back_comment, skip_chars): Mark vars as initialized.
9574
9575 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9576 Rename locals to avoid shadowing.
9577
9578 * lread.c (read1): Rewrite so as not to use empty "else".
9579 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9580
9581 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9582
9583 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9584 warning when compiling print.c.
9585
9586 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9587 instead of using an uninitialized var.
9588 (font_sort_entities): Mark var as initialized.
9589
9590 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9591
9592 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9593 pointers to constants.
9594 (font_parse_fcname): Remove unused vars.
9595 (font_delete_unmatched): Now static.
9596 (font_get_spec): Remove; unused.
9597 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9598 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9599 Rename or move locals to avoid shadowing.
9600
9601 * fns.c (require_nesting_list, require_unwind): Now static.
9602 (Ffillarray): Rename locals to avoid shadowing.
9603
9604 * floatfns.c (domain_error2): Define only if needed.
9605 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9606
9607 * alloc.c (mark_backtrace): Move decl from here ...
9608 * lisp.h: ... to here, so that it can be checked.
9609
9610 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9611 (Fdefvar): Rewrite so as not to use empty "else".
9612 (lisp_indirect_variable): Name an expression,
9613 to avoid gcc -Wbad-function-cast warning.
9614 (Fdefvar): Rename locals to avoid shadowing.
9615
9616 * callint.c (quotify_arg, quotify_args): Now static.
9617 (Fcall_interactively): Rename locals to avoid shadowing.
9618 Use const pointer when appropriate.
9619
9620 * lisp.h (get_system_name, get_operating_system_release):
9621 Move decls here, to check interfaces.
9622 * process.c (get_operating_system_release): Move decl to lisp.h.
9623 * xrdb.c (get_system_name): Likewise.
9624 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9625 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9626 some of which prompt warnings from gcc -Wbad-function-cast.
9627 (Fformat_time_string, Fencode_time, Finsert_char):
9628 (Ftranslate_region_internal, Fformat):
9629 Rename or remove local vars to avoid shadowing.
9630 (Ftranslate_region_internal): Mark var as initialized.
9631
9632 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9633 avoid shadowing.
9634
9635 * lisp.h (eassert): Check that the argument compiles, even if
9636 ENABLE_CHECKING is not defined.
9637
9638 * data.c (Findirect_variable): Name an expression, to avoid
9639 gcc -Wbad-function-cast warning.
9640 (default_value, arithcompare, arith_driver, arith_error): Now static.
9641 (store_symval_forwarding): Rename local to avoid shadowing.
9642 (Fmake_variable_buffer_local, Fmake_local_variable):
9643 Mark variables as initialized.
9644 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9645
9646 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9647 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9648 Rename locals to avoid shadowing.
9649 (mark_stack): Move local variables into the #ifdef region where
9650 they're used.
9651 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9652 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9653 needed otherwise.
9654 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9655 (GC_STRING_CHARS): Remove; not used.
9656 (Fmemory_limit): Cast sbrk's returned value to char *.
9657
9658 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9659 avoids undefined behavior in theory.
9660
9661 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9662
9663 Use functions, not macros, for up- and down-casing (Bug#8254).
9664 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9665 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9666 to use the following functions instead of these macros.
9667 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9668 EMACS_INT, since callers assume the returned value fits in int.
9669 (upcase1): Likewise, for UPCASE_TABLE.
9670 (uppercasep, lowercasep, upcase): New static inline functions.
9671 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9672 the race-condition problem in the old DOWNCASE.
9673
9674 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9675 Rename locals to avoid shadowing.
9676 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9677 (regex_compile, re_search_2, re_match_2_internal):
9678 Remove unused local vars.
9679 (FREE_VAR): Rewrite so as not to use empty "else",
9680 which gcc can warn about.
9681 (regex_compile, re_match_2_internal): Mark locals as initialized.
9682 (RETALLOC_IF): Define only if needed.
9683 (WORDCHAR_P): Likewise. This one is never needed, but is used
9684 only in a comment talking about a compiler bug, so put inside
9685 the #if 0 of that comment.
9686 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9687 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9688 Remove; unused.
9689
9690 * search.c (boyer_moore): Rename locals to avoid shadowing.
9691 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9692 (PREV_CHAR_BOUNDARY): Likewise.
9693
9694 * search.c (simple_search): Remove unused var.
9695
9696 * dired.c (compile_pattern): Move decl from here ...
9697 * lisp.h: ... to here, so that it can be checked.
9698 (struct re_registers): New forward decl.
9699
9700 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9701
9702 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9703 All uses changed.
9704 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9705 Rename locals to avoid shadowing.
9706 (Fvertical_motion): Mark locals as initialized.
9707
9708 * casefiddle.c (casify_object, casify_region): Now static.
9709 (casify_region): Mark local as initialized.
9710
9711 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9712
9713 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9714 New macros, so that the caller can use some names other than
9715 gcpro1, gcpro2, etc.
9716 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9717 of the new macros.
9718 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9719 argument, for consistency with GCPRO2_VAR, etc: it is now the
9720 prefix of the variable, not the variable itself. All uses
9721 changed.
9722 * dired.c (directory_files_internal, file_name_completion):
9723 Rename locals to avoid shadowing.
9724
9725 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9726 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9727 dired.c's scmp function, had undefined behavior.
9728 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9729 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9730 * buffer.h: ... to here, because these macros use current_buffer,
9731 and the new implementation with inline functions needs to have
9732 current_buffer in scope now, rather than later when the macros
9733 are used.
9734 (downcase, upcase1): New static inline functions.
9735 (DOWNCASE, UPCASE1): Reimplement using these functions.
9736 This avoids undefined behavior in expressions like
9737 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9738 from race conditions in accessing the global variables
9739 case_temp1 and case_temp2.
9740 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9741 * lisp.h (case_temp1, case_temp2): Remove their decls.
9742 * character.h (ASCII_CHAR_P): Move from here ...
9743 * lisp.h: ... to here, so that the inline functions mentioned
9744 above can use them.
9745
9746 * dired.c (directory_files_internal_unwind): Now static.
9747
9748 * fileio.c (file_name_as_directory, directory_file_name):
9749 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9750 Now static.
9751 (file_name_as_directory): Use const pointers when appropriate.
9752 (Fexpand_file_name): Likewise. In particular, newdir might
9753 point at constant storage, so make it a const pointer.
9754 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9755 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9756 signedness issues.
9757 (Fset_file_times, Finsert_file_contents, auto_save_error):
9758 Rename locals to avoid shadowing.
9759
9760 * minibuf.c (choose_minibuf_frame_1): Now static.
9761 (Ftry_completion, Fall_completions): Rename or remove locals
9762 to avoid shadowing.
9763
9764 * marker.c (bytepos_to_charpos): Remove; unused.
9765
9766 * lisp.h (verify_bytepos, count_markers): New decls,
9767 so that gcc does not warn that these functions aren't declared.
9768
9769 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9770 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9771 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9772 (copy_text): Remove unused local var.
9773
9774 * filelock.c (within_one_second): Now static.
9775 (lock_file_1): Rename local to avoid shadowing.
9776
9777 * buffer.c (fix_overlays_before): Mark locals as initialized.
9778 (fix_start_end_in_overlays): Likewise. This function should be
9779 simplified by using pointers-to-pointers, but that's a different
9780 matter.
9781 (switch_to_buffer_1): Now static.
9782 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9783 (report_overlay_modification): Rename locals to avoid shadowing.
9784
9785 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9786 Fix pointer signedness issue.
9787 (sys_subshell): Mark local as volatile if checking for lint,
9788 to suppress a gcc -Wclobbered warning that does not seem to be right.
9789 (MAXPATHLEN): Define only if needed.
9790
9791 * process.c (serial_open, serial_configure): Move decls from here ...
9792 * systty.h: ... to here, so that they can be checked.
9793
9794 * fns.c (get_random, seed_random): Move extern decls from here ...
9795 * lisp.h: ... to here, so that they can be checked.
9796
9797 * sysdep.c (reset_io): Now static.
9798 (wait_for_termination_signal): Remove; unused.
9799
9800 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9801 (copy_keymap_item, append_key, push_text_char_description):
9802 Now static.
9803 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9804 (DENSE_TABLE_SIZE): Remove; unused.
9805 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9806 (describe_map_tree):
9807 Rename locals to avoid shadowing.
9808
9809 * keyboard.c: Declare functions static if they are not used elsewhere.
9810 (echo_char, echo_dash, cmd_error, top_level_2):
9811 (poll_for_input, handle_async_input): Now static.
9812 (read_char, kbd_buffer_get_event, make_lispy_position):
9813 (make_lispy_event, make_lispy_movement, apply_modifiers):
9814 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9815 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9816 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9817 (read_key_sequence, read_char): Mark locals as initialized.
9818 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9819
9820 * keyboard.h (make_ctrl_char): New decl.
9821 (mark_kboards): Move decl here ...
9822 * alloc.c (mark_kboards): ... from here.
9823
9824 * lisp.h (force_auto_save_soon): New decl.
9825
9826 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9827 (DEFINE_DUMMY_FUNCTION): New macro.
9828 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9829 Use it.
9830 (main): Add casts to avoid warnings
9831 if GCC considers string literals to be constants.
9832
9833 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9834
9835 * dbusbind.c: Pointer signedness fixes.
9836 (xd_signature, xd_append_arg, xd_initialize):
9837 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9838 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9839 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9840 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9841
9842 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9843 if GCC considers string literals to be constants.
9844 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9845
98462011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9847
9848 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9849 (print_preprocess, print_object): New macro to fix last change.
9850
9851 * print.c (print_preprocess): Don't forget font objects.
9852
98532011-03-16 Juanma Barranquero <lekktu@gmail.com>
9854
9855 * emacs.c (USAGE3): Doc fixes.
9856
98572011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9858
9859 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9860 structure.
9861
98622011-03-14 Juanma Barranquero <lekktu@gmail.com>
9863
9864 * lisp.h (VWindow_system, Qfile_name_history):
9865 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9866 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9867 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9868
9869 * w32select.c: Don't #include "keyboard.h".
9870 (run_protected): Add extern declaration for waiting_for_input.
9871
9872 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9873 * w32console.c (detect_input_pending, read_input_pending)
9874 (encode_terminal_code):
9875 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9876 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9877 (w32_system_caret_y, Qfile_name_history):
9878 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9879 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9880 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9881 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9882 * w32proc.c (Qlocal, report_file_error):
9883 * w32term.c (Vwindow_system, updating_frame):
9884 * w32uniscribe.c (initialized, uniscribe_font_driver):
9885 Remove unneeded extern declarations.
9886
98872011-03-14 Chong Yidong <cyd@stupidchicken.com>
9888
9889 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9890
98912011-03-13 Chong Yidong <cyd@stupidchicken.com>
9892
9893 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9894 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9895 These macros can no longer be used for assignment.
9896
9897 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9898 Assign struct members directly, instead of using BUF_BEGV etc.
9899 (record_buffer_markers, fetch_buffer_markers): New functions for
9900 recording and fetching special buffer markers.
9901 (set_buffer_internal_1, set_buffer_temp): Use them.
9902
9903 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9904
9905 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9906
9907 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9908 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9909
9910 * xdisp.c (hscroll_window_tree):
9911 (reconsider_clip_changes): Use PT instead of BUF_PT.
9912
99132011-03-13 Eli Zaretskii <eliz@gnu.org>
9914
9915 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9916 $(EMACS_ROOT)/lib/intprops.h.
9917
99182011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9919
9920 Fix more problems found by GCC 4.5.2's static checks.
9921
9922 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9923 to unsigned char * to avoid compiler diagnostic.
9924 (xg_free_frame_widgets): Make it clear that a local variable is
9925 needed only if USE_GTK_TOOLTIP.
9926 (gdk_window_get_screen): Make it clear that this macro is needed
9927 only if USE_GTK_TOOLTIP.
9928 (int_gtk_range_get_value): New function, which avoids a diagnostic
9929 from gcc -Wbad-function-cast.
9930 (xg_set_toolkit_scroll_bar_thumb): Use it.
9931 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9932 diagnostic from gcc -Wbad-function-cast.
9933 (get_utf8_string, xg_get_file_with_chooser):
9934 Rename locals to avoid shadowing.
9935 (create_dialog): Move locals to avoid shadowing.
9936
9937 * xgselect.c (xg_select): Remove unused var.
9938
9939 * image.c (four_corners_best): Mark locals as initialized.
9940 (gif_load): Initialize transparent_p to zero (Bug#8238).
9941 Mark another local as initialized.
9942 (my_png_error, my_error_exit): Mark with NO_RETURN.
9943
9944 * image.c (clear_image_cache): Now static.
9945 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9946 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9947 (x_edge_detection): Remove unnecessary cast that
9948 gcc -Wbad-function-cast diagnoses.
9949 (gif_load): Fix pointer signedness.
9950 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9951 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9952
99532011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9954
9955 Improve quality of tests for time stamp overflow.
9956 For example, without this patch (encode-time 0 0 0 1 1
9957 1152921504606846976) returns the obviously-bogus value (-948597
9958 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9959 reports time overflow. See
9960 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9961 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9962 * editfns.c: Include limits.h and intprops.h.
9963 (TIME_T_MIN, TIME_T_MAX): New macros.
9964 (time_overflow): Move earlier, to before first use.
9965 (hi_time, lo_time): New functions, for an accurate test for
9966 out-of-range times.
9967 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9968 (Fget_internal_run_time): Don't assume time_t fits in int.
9969 (make_time): Use list2 instead of Fcons twice.
9970 (Fdecode_time): More accurate test for out-of-range times.
9971 (check_tm_member): New function.
9972 (Fencode_time): Use it, to test for out-of-range times.
9973 (lisp_time_argument): Don't rely on undefined left-shift and
9974 right-shift behavior when checking for time stamp overflow.
9975
9976 * editfns.c (time_overflow): New function, refactoring common code.
9977 (Fformat_time_string, Fdecode_time, Fencode_time):
9978 (Fcurrent_time_string): Use it.
9979
9980 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9981 * dired.c (make_time): Move to ...
9982 * editfns.c (make_time): ... here.
9983 * systime.h: Note the move.
9984
99852011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9986
9987 * fringe.c (update_window_fringes): Remove unused variables.
9988
9989 * unexmacosx.c (copy_data_segment): Also copy __got section.
9990 (Bug#8223)
9991
99922011-03-12 Eli Zaretskii <eliz@gnu.org>
9993
9994 * termcap.c [MSDOS]: Include "msdos.h".
9995 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9996 Constify `char *' arguments and their references according to
9997 prototypes in tparam.h.
9998
9999 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
10000
10001 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10002 Adapt all references accordingly.
10003
10004 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10005
100062011-03-11 Tom Tromey <tromey@redhat.com>
10007
10008 * buffer.c (syms_of_buffer): Remove obsolete comment.
10009
100102011-03-11 Eli Zaretskii <eliz@gnu.org>
10011
10012 * termhooks.h (encode_terminal_code): Declare prototype.
10013
10014 * msdos.c (encode_terminal_code): Don't declare prototype.
10015
10016 * term.c (encode_terminal_code): Now external again, used by
10017 w32console.c and msdos.c.
10018
10019 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10020 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
10021
100222011-03-11 Paul Eggert <eggert@cs.ucla.edu>
10023
10024 Fix some minor problems found by GCC 4.5.2's static checks.
10025
10026 * fringe.c (update_window_fringes): Mark locals as initialized
10027 (Bug#8227).
10028 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
10029
10030 * alloc.c (mark_fringe_data): Move decl from here ...
10031 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10032 to check its interface.
10033 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10034
10035 * fontset.c (free_realized_fontset): Now static.
10036 (Fset_fontset_font): Rename local to avoid shadowing.
10037 (fontset_font): Mark local as initialized.
10038 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
10039
10040 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10041
10042 * xselect.c (x_disown_buffer_selections): Remove; not used.
10043 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
10044 (x_own_selection, Fx_disown_selection_internal): Rename locals
10045 to avoid shadowing.
10046 (x_handle_dnd_message): Remove local to avoid shadowing.
10047
10048 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10049 so that the caller can use some name other than gcpro1.
10050 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
10051 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10052 (Fx_backspace_delete_keys_p):
10053 Use them to avoid shadowing, and rename vars to avoid shadowing.
10054 (x_decode_color, x_set_name, x_window): Now static.
10055 (Fx_create_frame): Add braces to silence GCC warning.
10056 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10057 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10058 Remove unused locals.
10059 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10060 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10061 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10062 macros.
10063
10064 * xterm.h (x_mouse_leave): New decl.
10065
10066 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10067 Remove unused functions.
10068 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10069 (x_calc_absolute_position): Now static.
10070 (XTread_socket): Don't define label "out" unless it's used.
10071 Don't declare local "event" unless it's used.
10072 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10073 unless they are used.
10074 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10075 (x_fatal_error_signal): Remove; not used.
10076 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10077 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10078 (x_error_catcher, x_connection_closed, x_error_handler):
10079 (x_error_quitter, xembed_send_message, x_iconify_frame):
10080 (my_log_handler): Rename locals to avoid shadowing.
10081 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10082 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10083
10084 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10085 Rename or move locals to avoid shadowing.
10086 (tty_defined_color, merge_face_heights): Now static.
10087 (free_realized_faces_for_fontset): Remove; not used.
10088 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10089 does not deduce is never used uninitialized.
10090 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10091 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10092
10093 * terminal.c (store_terminal_param): Now static.
10094
10095 * xmenu.c (menu_highlight_callback): Now static.
10096 (set_frame_menubar): Remove unused local.
10097 (xmenu_show): Rename parameter to avoid shadowing.
10098 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10099 since they might point to immutable storage.
10100 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10101 since it's unused otherwise.
10102
10103 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10104 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10105 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10106 avoids a gcc -Wuninitialized diagnostic.
10107 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10108 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10109 does not deduce are never used uninitialized.
10110
10111 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10112
10113 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10114 * window.c (window_loop, size_window):
10115 (run_window_configuration_change_hook, enlarge_window): Likewise.
10116
10117 * window.c (display_buffer): Now static.
10118 (size_window): Mark variables that gcc -Wuninitialized
10119 does not deduce are never used uninitialized.
10120 * window.h (check_all_windows): New decl, to forestall
10121 gcc -Wmissing-prototypes diagnostic.
10122 * dispextern.h (bidi_dump_cached_states): Likewise.
10123
10124 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10125 shadowing.
10126 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10127 Include <limits.h>.
10128 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10129 and to avoid gcc -Wuninitialized warning.
10130 (load_charset_map): Mark variables that gcc -Wuninitialized
10131 does not deduce are never used uninitialized.
10132 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10133
10134 * coding.c (coding_set_source, coding_set_destination):
10135 Use "else { /* comment */ }" rather than "else /* comment */;"
10136 for clarity, and to avoid gcc -Wempty-body warning.
10137 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10138 a block, when the outer 'i' will do.
10139 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10140 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10141 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10142 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10143 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10144 Rename locals to avoid shadowing.
10145 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10146 * coding.c (emacs_mule_char, encode_invocation_designation):
10147 Now static, since they're not used elsewhere.
10148 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10149 (decode_coding_object, encode_coding_object, detect_coding_system):
10150 (decode_coding_emacs_mule): Mark variables that gcc
10151 -Wuninitialized does not deduce are never used uninitialized.
10152 (detect_coding_iso_2022): Initialize a local variable that might
10153 be used uninitialized. Leave a FIXME because it's not clear that
10154 this initialization is needed. (Bug#8211)
10155 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10156 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10157 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10158 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10159 Remove unused macros.
10160
10161 * category.c (hash_get_category_set): Remove unused local var.
10162 (copy_category_table): Now static, since it's not used elsewhere.
10163 * character.c (string_count_byte8): Likewise.
10164
10165 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10166 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10167
10168 * chartab.c (copy_sub_char_table): Now static, since it's not used
10169 elsewhere.
10170 (sub_char_table_ref_and_range, char_table_ref_and_range):
10171 Rename locals to avoid shadowing.
10172 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10173
10174 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10175 (BIDI_BOB): Remove unused macro.
10176
10177 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10178 deduce are never used uninitialized.
10179 * term.c (encode_terminal_code): Likewise.
10180
10181 * term.c (encode_terminal_code): Now static. Remove unused local.
10182
10183 * tparam.h: New file.
10184 * term.c, tparam.h: Include it.
10185 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10186 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10187 Move these decls to tparam.h, and make them agree with what
10188 is actually in tparam.c. The previous trick of using incompatible
10189 decls in different modules does not conform to the C standard.
10190 All callers of tparam changed to use tparam's actual API.
10191 * tparam.c (tparam1, tparam, tgoto):
10192 Use const pointers where appropriate.
10193
10194 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10195 * cm.h (struct cm): Likewise.
10196 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10197 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10198 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10199 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10200 (turn_on_face, init_tty): Likewise.
10201 * termchar.h (struct tty_display_info): Likewise.
10202
10203 * term.c (term_mouse_position): Rename local to avoid shadowing.
10204
10205 * alloc.c (mark_ttys): Move decl from here ...
10206 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10207
102082011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10209
10210 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10211
102122011-03-09 Juanma Barranquero <lekktu@gmail.com>
10213
10214 * search.c (compile_pattern_1): Remove argument regp, unused since
10215 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10216 (compile_pattern): Don't pass it.
10217
102182011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10219
10220 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10221 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10222 for ! HAVE_GTK3.
10223 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10224
10225 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10226
10227 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10228 gdk_window_get_screen, gdk_window_get_geometry,
10229 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10230 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10231 (xg_get_pixbuf_from_pixmap): New function.
10232 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10233 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10234 Call xg_get_pixbuf_from_pixmap instead of
10235 gdk_pixbuf_get_from_drawable.
10236 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10237 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10238 (xg_check_special_colors): Use GtkStyleContext and its functions
10239 for HAVE_GTK3.
10240 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10241 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10242 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10243 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10244 Call gtk_widget_get_preferred_size.
10245 (xg_frame_resized): gdk_window_get_geometry only takes 5
10246 parameters.
10247 (xg_win_to_widget, xg_event_is_for_menubar):
10248 Call gdk_x11_window_lookup_for_display.
10249 (xg_set_widget_bg): New function.
10250 (delete_cb): New function.
10251 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10252 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10253 (xg_set_background_color): Call xg_set_widget_bg.
10254 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10255 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10256 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10257 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10258 if ! HAVE_GTK3.
10259 (update_frame_tool_bar): Call gtk_widget_hide.
10260 (xg_initialize): Use GDK_KEY_g.
10261
10262 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10263 if ! HAVE_GTK3
10264 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10265
10266 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10267 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10268 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10269
102702011-03-08 Juanma Barranquero <lekktu@gmail.com>
10271
10272 * w32xfns.c (select_palette): Check success of RealizePalette against
10273 GDI_ERROR, not zero.
10274
10275See ChangeLog.11 for earlier changes.
10276
10277;; Local Variables:
10278;; coding: utf-8
10279;; End:
10280
10281 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10282
10283 This file is part of GNU Emacs.
10284
10285 GNU Emacs is free software: you can redistribute it and/or modify
10286 it under the terms of the GNU General Public License as published by
10287 the Free Software Foundation, either version 3 of the License, or
10288 (at your option) any later version.
10289
10290 GNU Emacs is distributed in the hope that it will be useful,
10291 but WITHOUT ANY WARRANTY; without even the implied warranty of
10292 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10293 GNU General Public License for more details.
10294
10295 You should have received a copy of the GNU General Public License
10296 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.