* lisp/net/rcirc.el (rcirc-prompt-for-encryption): Fix bug introduced in last change.
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2
3 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4
5 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6
7 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9
102011-06-05 Juanma Barranquero <lekktu@gmail.com>
11
12 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
13
142011-06-04 Chong Yidong <cyd@stupidchicken.com>
15
16 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
17 (x_clipboard_manager_save): Add return value.
18 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
19 error handlers.
20 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
21 Obey Vx_select_enable_clipboard_manager. Catch errors in
22 x_clipboard_manager_save (Bug#8779).
23 (Vx_select_enable_clipboard_manager): New variable.
24 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
25
262011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
27
28 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
29
302011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
31
32 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
33 in the current matrix if keep_current_p is non-zero.
34
352011-06-04 Eli Zaretskii <eliz@gnu.org>
36
37 * bidi.c (bidi_level_of_next_char): Fix last change.
38
392011-06-03 Eli Zaretskii <eliz@gnu.org>
40
41 Support bidi reordering of text covered by display properties.
42
43 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
44 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
45 (bidi_cache_search, bidi_cache_iterator_state)
46 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
47 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
48 character positions inside a run of characters covered by a
49 display string.
50 (bidi_paragraph_init, bidi_resolve_explicit_1)
51 (bidi_level_of_next_char): Call bidi_fetch_char and
52 bidi_fetch_char_advance instead of FETCH_CHAR and
53 FETCH_CHAR_ADVANCE.
54 (bidi_init_it): Initialize new members.
55 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
56 definitions.
57 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
58 instead of using explicit *_CHAR codes.
59 (bidi_resolve_explicit, bidi_resolve_weak): Use
60 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
61 bidirectional text is supported only in multibyte buffers.
62 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
63 it to initialize the frame_window_p member of struct bidi_it.
64 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
65 (bidi_resolve_explicit, bidi_resolve_weak)
66 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
67 bidi_it->nchars is non-positive.
68 (bidi_level_of_next_char): Don't try to lookup the cache for the
69 next/previous character if nothing is cached there yet, or if we
70 were just reseat()'ed to a new position.
71
72 * xdisp.c (set_cursor_from_row): Set start and stop points
73 according to the row's direction when priming the loop that looks
74 for the glyph on which to display cursor.
75 (single_display_spec_intangible_p): Function deleted.
76 (display_prop_intangible_p): Reimplement to call
77 handle_display_spec instead of single_display_spec_intangible_p.
78 Accept 3 additional arguments needed by handle_display_spec. This
79 fixes incorrect cursor motion across display property with complex
80 values: lists, `(when COND...)' forms, etc.
81 (single_display_spec_string_p): Support property values that are
82 lists with the argument STRING its top-level element.
83 (display_prop_string_p): Fix the condition for processing a
84 property that is a list to be consistent with handle_display_spec.
85 (handle_display_spec): New function, refactored from the
86 last portion of handle_display_prop.
87 (compute_display_string_pos): Accept additional argument
88 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
89 value of a `display' property is a "replacing spec".
90 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
91 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
92 the display property, but just return a value indicating whether
93 the display property will replace the characters it covers.
94 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
95 frame_window_p members of struct bidi_it.
96 (compute_display_string_pos, compute_display_string_end): New
97 functions.
98 (push_it): Accept second argument POSITION, where pop_it should
99 jump to continue iteration.
100 (reseat_1): Initialize bidi_it.disp_pos.
101
102 * keyboard.c (adjust_point_for_property): Adjust the call to
103 display_prop_intangible_p to its new signature.
104
105 * dispextern.h (struct bidi_it): New member frame_window_p.
106 (bidi_init_it): Update prototypes.
107 (display_prop_intangible_p): Update prototype.
108 (compute_display_string_pos, compute_display_string_end): Declare
109 prototypes.
110 (struct bidi_it): New members nchars and disp_pos. ch_len is now
111 EMACS_INT.
112
1132011-06-02 Paul Eggert <eggert@cs.ucla.edu>
114
115 Malloc failure behavior now depends on size of allocation.
116 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
117 * lisp.h: Change signatures accordingly.
118 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
119 All callers changed. (Bug#8762)
120
121 * gnutls.c: Use Emacs's memory allocators.
122 Without this change, the gnutls library would invoke malloc etc.
123 directly, which causes problems on non-SYNC_INPUT hosts, and which
124 runs afoul of improving memory_full behavior. (Bug#8761)
125 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
126 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
127 xfree instead of the default malloc, realloc, free.
128 (Fgnutls_boot): No need to check for memory allocation failure,
129 since xmalloc does that for us.
130
131 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
132 * category.c (hash_get_category_set):
133 * ccl.c (ccl_driver):
134 * charset.c (Fdefine_charset_internal):
135 * charset.h (struct charset.hash_index):
136 * composite.c (get_composition_id, gstring_lookup_cache)
137 (composition_gstring_put_cache):
138 * composite.h (struct composition.hash_index):
139 * dispextern.h (struct image.hash):
140 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
141 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
142 (hashfn_equal, hashfn_user_defined, make_hash_table)
143 (maybe_resize_hash_table, hash_lookup, hash_put)
144 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
145 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
146 (Fsxhash, Fgethash, Fputhash, Fmaphash):
147 * image.c (make_image, search_image_cache, lookup_image)
148 (xpm_put_color_table_h):
149 * lisp.h (struct Lisp_Hash_Table):
150 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
151 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
152 for hashes and hash indexes, instead of 'unsigned' and 'int'.
153 * alloc.c (allocate_vectorlike):
154 Check for overflow in vector size calculations.
155 * ccl.c (ccl_driver):
156 Check for overflow when converting EMACS_INT to int.
157 * fns.c, image.c: Remove unnecessary static decls that would otherwise
158 need to be updated by these changes.
159 * fns.c (make_hash_table, maybe_resize_hash_table):
160 Check for integer overflow with large hash tables.
161 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
162 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
163 (SXHASH_REDUCE): New macro.
164 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
165 Use it instead of discarding useful hash info with large hash values.
166 (sxhash_float): New function.
167 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
168 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
169 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
170 Rewrite to use FIXNUM_BITS, as this simplifies things.
171 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
172 Adjust signatures to match updated version of code.
173 (consing_since_gc): Now EMACS_INT, since a single hash table can
174 use more than INT_MAX bytes.
175
1762011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
177
178 Make it possible to build with GCC-4.6+ -O2 -flto.
179
180 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
181
1822011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
183
184 * minibuf.c (get_minibuffer, read_minibuf_unwind):
185 Call minibuffer-inactive-mode.
186
1872011-05-31 Juanma Barranquero <lekktu@gmail.com>
188
189 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
190 Update dependencies.
191
1922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
193
194 * data.c (init_data): Remove code for UTS, this system is not
195 supported anymore.
196
1972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
198
199 Don't force ./temacs to start in terminal mode.
200
201 * frame.c (make_initial_frame): Initialize faces in all cases, not
202 only when CANNOT_DUMP is defined.
203 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
204
2052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
206
207 * dispnew.c (add_window_display_history): Use const for the string
208 pointer. Remove declaration, not needed.
209
2102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
211
212 Use 'inline', not 'INLINE'.
213 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
214 * alloc.c, fontset.c (INLINE): Remove.
215 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
216 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
217 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
218 * gmalloc.c (register_heapinfo): Use inline unconditionally.
219 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
220
2212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
222
223 Make it possible to run ./temacs.
224
225 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
226 syms_of_callproc does the same thing. Remove test for
227 "initialized", do it in the caller.
228 * emacs.c (main): Avoid calling set_initial_environment when dumping.
229
2302011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
231
232 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
233 (read_minibuf): Use get_minibuffer.
234 (syms_of_minibuf): Use DEFSYM.
235 (Qmetadata): New var.
236 * data.c (Qbuffer): Don't make it static.
237 (syms_of_data): Use DEFSYM.
238
2392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
240
241 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
242 (CCL_CODE_MIN): New macro.
243
2442011-05-30 Paul Eggert <eggert@cs.ucla.edu>
245
246 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
247
248 * eval.c (Qdebug): Now static.
249 * lisp.h (Qdebug): Remove decl. This reverts a part of the
250 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
251 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
252
2532011-05-29 Chong Yidong <cyd@stupidchicken.com>
254
255 * image.c: Various fixes to ImageMagick code comments.
256 (Fimagemagick_types): Doc fix.
257
2582011-05-29 Paul Eggert <eggert@cs.ucla.edu>
259
260 Minor fixes prompted by GCC 4.6.0 warnings.
261
262 * xselect.c (converted_selections, conversion_fail_tag): Now static.
263
264 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
265 (x_clipboard_manager_save_all): Move extern decl to ...
266 * xterm.h: ... here, so that it can be checked for consistency.
267
2682011-05-29 Chong Yidong <cyd@stupidchicken.com>
269
270 * xselect.c (x_clipboard_manager_save_frame)
271 (x_clipboard_manager_save_all): New functions.
272 (Fx_clipboard_manager_save): Lisp function deleted.
273
274 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
275 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
276
277 * xterm.h: Update prototype.
278
2792011-05-28 William Xu <william.xwl@gmail.com>
280
281 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
282 exiting (Bug#8239).
283
2842011-05-28 Jim Meyering <meyering@redhat.com>
285
286 Avoid a sign-extension bug in crypto_hash_function.
287 * fns.c (to_uchar): Define.
288 (crypto_hash_function): Use it to convert some newly-signed
289 variables to unsigned, to avoid sign-extension bugs. For example,
290 without this change, (md5 "truc") would evaluate to
291 45723a2aff78ff4fff7fff1114760e62 rather than the expected
292 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
293 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
294
2952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
296
297 Integer overflow fixes.
298
299 * dbusbind.c: Serial number integer overflow fixes.
300 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
301 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
302 to hold a serial number that is too large for a fixnum.
303 (Fdbus_method_return_internal, Fdbus_method_error_internal):
304 Check for serial numbers out of range. Decode any serial number
305 that was so large that it became a float. (Bug#8722)
306
307 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
308 (Fdbus_call_method, Fdbus_call_method_asynchronously):
309 Use XFASTINT rather than XUINT when numbers are nonnegative.
310 (xd_append_arg, Fdbus_method_return_internal):
311 (Fdbus_method_error_internal): Likewise. Also, for unsigned
312 arguments, check that Lisp number is nonnegative, rather than
313 silently wrapping negative numbers around. (Bug#8722)
314 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
315 (Bug#8722)
316
317 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
318
319 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
320
321 ccl: add integer overflow checks
322 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
323 (IN_INT_RANGE): New macros.
324 (ccl_driver): Use them to check for integer overflow when
325 decoding a CCL program. Many of the new checks are whether XINT (x)
326 fits in int; it doesn't always, on 64-bit hosts. The new version
327 doesn't catch all possible integer overflows, but it's an
328 improvement. (Bug#8719)
329
330 * alloc.c (make_event_array): Use XINT, not XUINT.
331 There's no need for unsigned here.
332
333 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
334 This follows up to the 2011-05-06 change that substituted uintptr_t
335 for EMACS_INT. This case wasn't caught back then.
336
337 Rework Fformat to avoid integer overflow issues.
338 * editfns.c: Include <float.h> unconditionally, as it's everywhere
339 now (part of C89). Include <verify.h>.
340 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
341 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
342 (Fformat): Avoid the prepass trying to compute sizes; it was only
343 approximate and thus did not catch overflow reliably. Instead, walk
344 through the format just once, formatting and computing sizes as we go,
345 checking for integer overflow at every step, and allocating a larger
346 buffer as needed. Keep track separately whether the format is
347 multibyte. Keep only the most-recently calculated precision, rather
348 than them all. Record whether each argument has been converted to
349 string. Use EMACS_INT, not int, for byte and char and arg counts.
350 Support field widths and precisions larger than INT_MAX. Avoid
351 sprintf's undefined behavior with conversion specifications such as %#d
352 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
353 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
354 formatting out-of-range floating point numbers with int
355 formats. (Bug#8668)
356
357 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
358
359 * data.c: Avoid integer truncation in expressions involving floats.
360 * data.c: Include <intprops.h>.
361 (arith_driver): When there's an integer overflow in an expression
362 involving floating point, convert the integers to floating point
363 so that the resulting value does not suffer from catastrophic
364 integer truncation. For example, on a 64-bit host (* 4
365 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
366 Do not rely on undefined behavior after integer overflow.
367
368 merge count_size_as_multibyte, parse_str_to_multibyte
369 * character.c, character.h (count_size_as_multibyte):
370 Rename from parse_str_to_multibyte; all uses changed.
371 Check for integer overflow.
372 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
373 since it's now a duplicate of the other. This is more of
374 a character than a buffer op, so better that it's in character.c.
375 * fns.c, print.c: Adjust to above changes.
376
3772011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
378
379 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
380
3812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
382
383 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
384 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
385 (x_clipboard_manager_save): Now static.
386 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
387
388 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
389 (crypto_hash_function): Now static.
390 Fix pointer signedness problems. Avoid unnecessary initializations.
391
3922011-05-27 Chong Yidong <cyd@stupidchicken.com>
393
394 * termhooks.h (Vselection_alist): Make it terminal-local.
395
396 * terminal.c (create_terminal): Initialize it.
397
398 * xselect.c: Support for clipboard managers.
399 (Vselection_alist): Move to termhooks.h as terminal-local var.
400 (LOCAL_SELECTION): New macro.
401 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
402 (symbol_to_x_atom): Remove gratuitous arg.
403 (x_handle_selection_request, lisp_data_to_selection_data)
404 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
405 (x_own_selection, x_get_local_selection, x_convert_selection):
406 New arg, specifying work frame. Use terminal-local Vselection_alist.
407 (some_frame_on_display): Delete unused function.
408 (Fx_own_selection_internal, Fx_get_selection_internal)
409 (Fx_disown_selection_internal, Fx_selection_owner_p)
410 (Fx_selection_exists_p): New optional frame arg.
411 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
412 (x_handle_selection_clear): Don't treat other terminals with the
413 same keyboard specially. Use the terminal-local Vselection_alist.
414 (x_clear_frame_selections): Use Frun_hook_with_args.
415
416 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
417
418 * xterm.h: Add support for those atoms.
419
4202011-05-26 Chong Yidong <cyd@stupidchicken.com>
421
422 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
423 (converted_selections, conversion_fail_tag): New global variables.
424 (x_selection_request_lisp_error): Free the above.
425 (x_get_local_selection): Remove unnecessary code.
426 (x_reply_selection_request): Args changed; handle arbitrary array
427 of converted selections stored in converted_selections.
428 Separate the XChangeProperty and SelectionNotify steps.
429 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
430 (x_convert_selection): New function.
431 (x_handle_selection_event): Simplify.
432 (x_get_foreign_selection): Don't ignore incoming requests while
433 waiting for an answer; this will fail when we implement
434 SAVE_TARGETS, and seems unnecessary anyway.
435 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
436 (Vx_sent_selection_functions): Doc fix.
437
4382011-05-26 Leo Liu <sdl.web@gmail.com>
439
440 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
441
4422011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
443
444 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
445
446 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
447 for fringe update if it has periodic bitmap.
448 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
449 and fringe_bitmap_periodic_p.
450
451 * fringe.c (get_fringe_bitmap_data): New function.
452 (draw_fringe_bitmap_1, update_window_fringes): Use it.
453 (update_window_fringes): Record periodicity of fringe bitmap in glyph
454 row. Mark glyph row for fringe update if periodicity changed.
455
456 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
457 for fringe update unless it has periodic bitmap.
458
4592011-05-25 Kenichi Handa <handa@m17n.org>
460
461 * xdisp.c (get_next_display_element): Set correct it->face_id for
462 a static composition.
463
4642011-05-24 Leo Liu <sdl.web@gmail.com>
465
466 * deps.mk (fns.o):
467 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
468
469 * fns.c (crypto_hash_function, Fsha1): New function.
470 (Fmd5): Use crypto_hash_function.
471 (syms_of_fns): Add Ssha1.
472
4732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
474
475 * gnutls.c: Remove unused macros.
476 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
477 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
478 Remove macros that are defined and never used.
479 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
480
4812011-05-22 Chong Yidong <cyd@stupidchicken.com>
482
483 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
484 (Fx_get_selection_internal): Minor cleanup.
485 (Fx_own_selection_internal): Rename arguments for consistency with
486 select.el.
487
4882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
489
490 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
491
4922011-05-22 Chong Yidong <cyd@stupidchicken.com>
493
494 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
495
4962011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
497
498 * dispnew.c (scrolling_window): Don't exclude the case that the
499 last enabled row in the desired matrix touches the bottom boundary.
500
5012011-05-21 Glenn Morris <rgm@gnu.org>
502
503 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
504 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
505 and add some more files.
506
5072011-05-20 Eli Zaretskii <eliz@gnu.org>
508
509 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
510 report_file_error introduced by the change from 2011-05-07.
511
5122011-05-20 Paul Eggert <eggert@cs.ucla.edu>
513
514 * systime.h (Time): Define only if emacs is defined.
515 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
516 where the include path doesn't have X11/X.h by default. See
517 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
518
5192011-05-20 Kenichi Handa <handa@m17n.org>
520
521 * composite.c (find_automatic_composition): Fix previous change.
522
5232011-05-20 Glenn Morris <rgm@gnu.org>
524
525 * lisp.mk: New file, split from Makefile.in.
526 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
527 (shortlisp): Remove.
528 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
529
5302011-05-19 Glenn Morris <rgm@gnu.org>
531
532 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
533 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
534 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
535 (lisp): Set the order to that of loadup.el.
536 (shortlisp): Make it a copy of $lisp.
537 (SOME_MACHINE_LISP): Remove.
538 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
539 Use just $shortlisp, not $SOME_MACHINE_LISP too.
540
5412011-05-18 Kenichi Handa <handa@m17n.org>
542
543 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
544 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
545 (find_automatic_composition): Mostly rewrite for efficiency.
546
5472011-05-18 Juanma Barranquero <lekktu@gmail.com>
548
549 * makefile.w32-in: Update dependencies.
550
5512011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
552
553 * menu.c: Include limits.h (fixes the MS-Windows build broken by
554 revision 104625).
555
5562011-05-18 Paul Eggert <eggert@cs.ucla.edu>
557
558 Fix some integer overflow issues, such as string length overflow.
559
560 * insdel.c (count_size_as_multibyte): Check for string overflow.
561
562 * character.c (lisp_string_width): Check for string overflow.
563 Use EMACS_INT, not int, for string indexes and lengths; in
564 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
565 the resulting string length overflows an EMACS_INT; instead,
566 report a string overflow if no precision given. When checking for
567 precision exhaustion, use a check that cannot possibly have
568 integer overflow. (Bug#8675)
569 * character.h (lisp_string_width): Adjust to new signature.
570
571 * alloc.c (string_overflow): New function.
572 (Fmake_string): Use it. This doesn't change behavior, but saves
573 a few bytes and will simplify future changes.
574 * character.c (string_escape_byte8): Likewise.
575 * lisp.h (string_overflow): New decl.
576
577 Fixups, following up to the user-interface timestamp change.
578 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
579 for UI timestamps, instead of unsigned long.
580 * msdos.c (mouse_get_pos): Likewise.
581 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
582 * w32gui.h (Time): Define by including "systime.h" rather than by
583 declaring it ourselves. (Bug#8664)
584
585 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
586 * image.c (clear_image_cache): Likewise.
587
588 * term.c (term_mouse_position): Don't assume time_t wraparound.
589
590 Be more systematic about user-interface timestamps.
591 Before, the code sometimes used 'Time', sometimes 'unsigned long',
592 and sometimes 'EMACS_UINT', to represent these timestamps.
593 This change causes it to use 'Time' uniformly, as that's what X uses.
594 This makes the code easier to follow, and makes it easier to catch
595 integer overflow bugs such as Bug#8664.
596 * frame.c (Fmouse_position, Fmouse_pixel_position):
597 Use Time, not unsigned long, for user-interface timestamps.
598 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
599 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
600 * keyboard.h (last_event_timestamp): Likewise.
601 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
602 * menu.h (xmenu_show): Likewise.
603 * term.c (term_mouse_position): Likewise.
604 * termhooks.h (struct input_event.timestamp): Likewise.
605 (struct terminal.mouse_position_hook): Likewise.
606 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
607 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
608 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
609 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
610 what it was before.
611 * menu.h, termhooks.h: Include "systime.h", for Time.
612
613 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
614 Don't assume that the difference between two unsigned long values
615 can fit into an integer. At this point, we know button_down_time
616 <= event->timestamp, so the difference must be nonnegative, so
617 there's no need to cast the result if double-click-time is
618 nonnegative, as it should be; check that it's nonnegative, just in
619 case. This bug is triggered when events are more than 2**31 ms
620 apart (about 25 days). (Bug#8664)
621
622 * xselect.c (last_event_timestamp): Remove duplicate decl.
623 (x_own_selection): Remove needless cast to unsigned long.
624
625 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
626 that always fit in int. Use a sentinel instead of a counter, to
627 avoid a temp and to allay GCC's concerns about possible int overflow.
628 * frame.h (struct frame): Use int for menu_bar_items_used
629 instead of EMACS_INT, since it always fits in int.
630
631 * menu.c (grow_menu_items): Check for int overflow.
632
633 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
634
635 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
636 Before, the code was not consistent. These values cannot exceed
637 2**31 - 1 so there's no need to make them unsigned.
638 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
639 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
640 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
641 as modifiers.
642 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
643
644 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
645 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
646 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
647 presumably because the widths might not match.
648
649 * window.c (size_window): Avoid needless test at loop start.
650
6512011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
652
653 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
654
6552011-05-12 Drew Adams <drew.adams@oracle.com>
656
657 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
658
6592011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
660
661 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
662 `width' to `bar_area_x' and `bar_area_width', respectively.
663 (x_scroll_run): Take account of fringe background extension.
664
665 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
666 Rename local vars `left' and `width' to `bar_area_x' and
667 `bar_area_width', respectively.
668 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
669 background extension.
670
6712011-05-10 Jim Meyering <meyering@redhat.com>
672
673 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
674
6752011-05-10 Juanma Barranquero <lekktu@gmail.com>
676
677 * image.c (Finit_image_library): Return t for built-in image types,
678 like pbm and xbm. (Bug#8640)
679
6802011-05-09 Andreas Schwab <schwab@linux-m68k.org>
681
682 * w32menu.c (set_frame_menubar): Fix submenu allocation.
683
6842011-05-07 Eli Zaretskii <eliz@gnu.org>
685
686 * w32console.c (Fset_screen_color): Doc fix.
687 (Fget_screen_color): New function.
688 (syms_of_ntterm): Defsubr it.
689
690 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
691 unlink the temporary file if Fcall_process didn't create it in the
692 first place.
693 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
694 child process will be redirected to a file specified with `:file'.
695 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
696 cue to call_process_cleanup not to close that handle.
697
6982011-05-07 Ben Key <bkey76@gmail.com>
699
700 * makefile.w32-in: The bootstrap-temacs rule now makes use of
701 one of two shell specific rules, either bootstrap-temacs-CMD or
702 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
703 to the previous implementation of the bootstrap-temacs rule.
704 The bootstrap-temacs-CMD rule is similar to the previous
705 implementation of the bootstrap-temacs rule except that it
706 makes use of the ESC_CFLAGS variable instead of the CFLAGS
707 variable.
708
709 These changes, along with some changes to nt/configure.bat,
710 nt/gmake.defs, and nt/nmake.defs, are required to extend my
711 earlier fix to add support for --cflags and --ldflags options
712 that include quotes so that it works whether make uses cmd or
713 sh as the shell.
714
7152011-05-06 Michael Albinus <michael.albinus@gmx.de>
716
717 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
718 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
719 is a constant.
720 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
721 a string. Handle both cases.
722 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
723 (Fdbus_register_method): Use Qinvalid_function.
724
7252011-05-06 Juanma Barranquero <lekktu@gmail.com>
726
727 * makefile.w32-in: Update dependencies.
728 (LISP_H): Add inttypes.h and stdin.h.
729 (PROCESS_H): Add unistd.h.
730
7312011-05-06 Eli Zaretskii <eliz@gnu.org>
732
733 * lread.c: Include limits.h (fixes the MS-Windows build broken by
734 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
735
7362011-05-06 Paul Eggert <eggert@cs.ucla.edu>
737
738 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
739
740 * term.c (vfatal): Remove stray call to va_end.
741 It's not needed and the C Standard doesn't allow it here anyway.
742
743 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
744 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
745
746 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
747 bytes.
748
749 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
750
751 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
752
753 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
754
755 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
756
757 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
758
759 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
760 * charset.c (Fdefine_charset_internal): Don't initialize
761 charset.code_space[15]. The value was garbage, on hosts with
762 32-bit int (Bug#8600).
763
764 * lread.c (read_integer): Be more consistent with string-to-number.
765 Use string_to_number to do the actual conversion; this avoids
766 rounding errors and fixes some other screwups. Without this fix,
767 for example, #x1fffffffffffffff was misread as -2305843009213693952.
768 (digit_to_number): Move earlier, for benefit of read_integer.
769 Return -1 if the digit is out of range for the base, -2 if it is
770 not a digit in any supported base. (Bug#8602)
771
772 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
773
774 * dispnew.c (scrolling_window): Return 1 if we scrolled,
775 to match comment at start of function. This also removes a
776 GCC warning about overflow in a 32+64-bit port.
777
778 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
779
780 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
781 Reported by Stefan Monnier in
782 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
783 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
784 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
785
786 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
787 (EMACS_UINTPTR): Likewise, with uintptr_t.
788
789 * lisp.h: Prefer 64-bit EMACS_INT if available.
790 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
791 on 32-bit hosts that have 64-bit int, so that they can access
792 large files.
793 However, temporarily disable this change unless the temporary
794 symbol WIDE_EMACS_INT is defined.
795
796 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
797
798 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
799 This removes an assumption that EMACS_INT and long are the same
800 width as pointers. The assumption is true for Emacs porting targets
801 now, but we want to make other targets possible.
802 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
803 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
804 In the rest of the code, change types of integers that hold casted
805 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
806 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
807 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
808 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
809 No need to cast type when ORing.
810 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
811 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
812 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
813 assume EMACS_INT is the same width as char *.
814 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
815 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
816 Remove no-longer-needed casts.
817 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
818 (xg_tool_bar_help_callback, xg_make_tool_item):
819 Use EMACS_INTPTR to hold an integer
820 that will be cast to void *; this can avoid a GCC warning
821 if EMACS_INT is not the same width as void *.
822 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
823 * xdisp.c (display_echo_area_1, resize_mini_window_1):
824 (current_message_1, set_message_1):
825 Use a local to convert to proper width without a cast.
826 * xmenu.c (dialog_selection_callback): Likewise.
827
828 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
829 Also, don't assume VALBITS / RAND_BITS is less than 5,
830 and don't rely on undefined behavior when shifting a 1 left into
831 the sign bit.
832 * lisp.h (get_random): Change signature to match.
833
834 * lread.c (hash_string): Use size_t, not int, for hash computation.
835 Normally we prefer signed values; but hashing is special, because
836 it's better to use unsigned division on hash table sizes so that
837 the remainder is nonnegative. Also, size_t is the natural width
838 for hashing into memory. The previous code used 'int', which doesn't
839 retain enough info to hash well into very large tables.
840 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
841
842 * dbusbind.c: Don't possibly lose pointer info when converting.
843 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
844 Use XPNTR rather than XHASH, so that the high-order bits of
845 the pointer aren't lost when converting through void *.
846
847 * eval.c (Fautoload): Don't double-shift a pointer.
848
849 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
850
8512011-05-06 Juanma Barranquero <lekktu@gmail.com>
852
853 * gnutls.c (DEF_GNUTLS_FN):
854 * image.c (DEF_IMGLIB_FN): Make function pointers static.
855
8562011-05-05 Andreas Schwab <schwab@linux-m68k.org>
857
858 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
859 marker. (Bug#8610)
860
8612011-05-05 Eli Zaretskii <eliz@gnu.org>
862
863 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
864 New version that can reserve upto 2GB of heap space.
865
8662011-05-05 Chong Yidong <cyd@stupidchicken.com>
867
868 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
869
8702011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
871
872 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
873 `gnutls_certificate_set_x509_key_file'.
874
8752011-05-05 Juanma Barranquero <lekktu@gmail.com>
876
877 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
878 Update dependencies.
879
8802011-05-04 Juanma Barranquero <lekktu@gmail.com>
881
882 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
883 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
884 Remove unused parameter `fildes'.
885 * process.c (read_process_output, send_process): Don't pass it.
886
8872011-05-04 Juanma Barranquero <lekktu@gmail.com>
888
889 Fix previous change: the library cache is defined in w32.c.
890 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
891 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
892
8932011-05-04 Juanma Barranquero <lekktu@gmail.com>
894
895 Implement dynamic loading of GnuTLS on Windows.
896
897 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
898 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
899 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
900 Declare.
901
902 * gnutls.c (Qgnutls_dll): Define.
903 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
904 (gnutls_*): Declare function pointers.
905 (init_gnutls_functions): New function to initialize function pointers.
906 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
907 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
908 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
909 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
910 (emacs_gnutls_write, emacs_gnutls_read)
911 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
912 (Fgnutls_available_p): New function.
913 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
914 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
915 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
916
917 * image.c: Include w32.h.
918 (Vimage_type_cache): Delete.
919 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
920 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
921 (w32_delayed_load): Move to w32.c.
922
923 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
924
925 * w32.c (QCloaded_from, Vlibrary_cache): Define.
926 (w32_delayed_load): Move from image.c. When loading a library, record
927 its filename in the :loaded-from property of the library id.
928 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
929 Initialize and staticpro them.
930 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
931
932 * process.c: Include lisp.h before w32.h, not after.
933 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
934 instead of gnutls_record_check_pending.
935
936 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
937
9382011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
939
940 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
941 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
942 as passed in.
943
9442011-05-03 Jan Djärv <jan.h.d@swipnet.se>
945
946 * xterm.c (x_set_frame_alpha): Do not set property on anything
947 else than FRAME_X_OUTER_WINDOW (Bug#8608).
948
9492011-05-02 Juanma Barranquero <lekktu@gmail.com>
950
951 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
952
9532011-05-02 Juanma Barranquero <lekktu@gmail.com>
954
955 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
956 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
957 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
958 (gnutls_global_initialized, Qgnutls_bootprop_priority)
959 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
960 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
961 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
962 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
963 (Qgnutls_bootprop_callbacks_verify): Make static.
964
9652011-05-01 Andreas Schwab <schwab@linux-m68k.org>
966
967 * callproc.c: Indentation fixup.
968
969 * sysdep.c (wait_for_termination_1): Make static.
970 (wait_for_termination, interruptible_wait_for_termination):
971 Move after wait_for_termination_1.
972
9732011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
974
975 * sysdep.c (interruptible_wait_for_termination): New function
976 which is like wait_for_termination, but allows keyboard
977 interruptions.
978
979 * callproc.c (Fcall_process): Add (:file "file") as an option for
980 the STDOUT buffer.
981 (Fcall_process_region): Ditto.
982
9832011-04-30 Eli Zaretskii <eliz@gnu.org>
984
985 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
986 rather than `XVECTOR (FOO)->size'.
987
988 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
989 inttypes.h, as a gnulib replacement is used if it not available in
990 system headers.
991
9922011-04-21 Eli Zaretskii <eliz@gnu.org>
993
994 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
995 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
996 of MOST_POSITIVE_FIXNUM. (Bug#8528)
997
998 * coding.c (coding_alloc_by_realloc): Error out if destination
999 will grow beyond MOST_POSITIVE_FIXNUM.
1000 (decode_coding_emacs_mule): Abort if there isn't enough place in
1001 charbuf for the composition carryover bytes. Reserve an extra
1002 space for up to 2 characters produced in a loop.
1003 (decode_coding_iso_2022): Abort if there isn't enough place in
1004 charbuf for the composition carryover bytes.
1005
10062011-04-21 Eli Zaretskii <eliz@gnu.org>
1007
1008 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1009 aborting when %lld or %lll format is passed.
1010 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1011 %llo or %llx format is passed. (Bug#8545)
1012
1013 * window.c (window_scroll_line_based): Use a marker instead of
1014 simple variables to record original value of point. (Bug#7952)
1015
1016 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1017 produced by %s or %c overflows available buffer space. (Bug#8545)
1018
10192011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1022 (SIZE_MAX): Move defn after all includes, as they might #define it.
1023
10242011-04-28 Juanma Barranquero <lekktu@gmail.com>
1025
1026 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1027
10282011-04-28 Juanma Barranquero <lekktu@gmail.com>
1029
1030 * keyboard.c (Qdelayed_warnings_hook): Define.
1031 (command_loop_1): Run `delayed-warnings-hook'
1032 if Vdelayed_warnings_list is non-nil.
1033 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1034 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1035
10362011-04-28 Eli Zaretskii <eliz@gnu.org>
1037
1038 * doprnt.c (doprnt): Don't return value smaller than the buffer
1039 size if the message was truncated. (Bug#8545).
1040
10412011-04-28 Juanma Barranquero <lekktu@gmail.com>
1042
1043 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1044 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1045
10462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1047
1048 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1049
10502011-04-27 Juanma Barranquero <lekktu@gmail.com>
1051
1052 * makefile.w32-in: Update dependencies.
1053
10542011-04-27 Eli Zaretskii <eliz@gnu.org>
1055
1056 Improve `doprnt' and its usage. (Bug#8545)
1057 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1058 `format_end'. Remove support for %l as a conversion specifier.
1059 Don't use xrealloc. Improve diagnostics when the %l size modifier
1060 is used. Update the commentary.
1061
1062 * eval.c (verror): Simplify calculation of size_t.
1063
1064 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1065 messages.
1066
10672011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1068
1069 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1070 change.
1071
10722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1075 This makes this file independent of the recent pseudovector change.
1076
10772011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1078
1079 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1080
1081 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1082 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1083 Remove unused local.
1084 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1085
1086 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1087 GCC 4.6.0 optimizes based on type-based alias analysis.
1088 For example, if b is of type struct buffer * and v of type struct
1089 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1090 != &v->size, and therefore "v->size = 1; b->size = 2; return
1091 v->size;" must therefore return 1. This assumption is incorrect
1092 for Emacs, since it type-puns struct Lisp_Vector * with many other
1093 types. To fix this problem, this patch adds a new type struct
1094 vectorlike_header that documents the constraints on layout of vectors
1095 and pseudovectors, and helps optimizing compilers not get fooled
1096 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1097 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1098 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1099 the size member.
1100 (XSETPVECTYPE): Rewrite in terms of new macro.
1101 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1102 This is a bit clearer, and further avoids the possibility of
1103 undesirable aliasing.
1104 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1105 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1106 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1107 since Lisp_Subr is a special case (no "next" field).
1108 (ASIZE): Now uses header.size rather than size.
1109 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1110 to avoid the hassle of writing XVECTOR (foo)->header.size.
1111 (struct vectorlike_header): New type.
1112 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1113 object, to help avoid aliasing.
1114 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1115 (SUBRP): Likewise, since Lisp_Subr is a special case.
1116 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1117 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1118 (struct Lisp_Hash_Table): Combine first two members into a single
1119 struct vectorlike_header member. All uses of "size" and "next" members
1120 changed to be "header.size" and "header.next".
1121 * buffer.h (struct buffer): Likewise.
1122 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1123 * frame.h (struct frame): Likewise.
1124 * process.h (struct Lisp_Process): Likewise.
1125 * termhooks.h (struct terminal): Likewise.
1126 * window.c (struct save_window_data, struct saved_window): Likewise.
1127 * window.h (struct window): Likewise.
1128 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1129 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1130 * buffer.c (init_buffer_once): Likewise.
1131 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1132 special case.
1133 * process.c (Fformat_network_address): Use local var for size,
1134 for brevity.
1135
1136 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1137
1138 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1139 * data.c (atof): Remove decl; no longer used or needed.
1140 (digit_to_number): Move to lread.c.
1141 (Fstring_to_number): Use new string_to_number function, to be
1142 consistent with how the Lisp reader treats infinities and NaNs.
1143 Do not assume that floating-point numbers represent EMACS_INT
1144 without losing information; this is not true on most 64-bit hosts.
1145 Avoid double-rounding errors, by insisting on integers when
1146 parsing non-base-10 numbers, as the documentation specifies.
1147 * lisp.h (string_to_number): New decl, replacing ...
1148 (isfloat_string): Remove.
1149 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1150 (read1): Do not accept +. and -. as integers; this
1151 appears to have been a coding error. Similarly, do not accept
1152 strings like +-1e0 as floating point numbers. Do not report
1153 overflow for integer overflows unless the base is not 10 which
1154 means we have no simple and reliable way to continue.
1155 Break out the floating-point parsing into a new
1156 function string_to_number, so that Fstring_to_number parses
1157 floating point numbers consistently with the Lisp reader.
1158 (digit_to_number): Move here from data.c. Make it static inline.
1159 (E_CHAR, EXP_INT): Remove, replacing with ...
1160 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1161 (string_to_number): New function, replacing isfloat_string.
1162 This function checks for valid syntax and produces the resulting
1163 Lisp float number too. Rework it so that string-to-number
1164 no longer mishandles examples like "1.0e+". Use strtoumax,
1165 so that overflow for non-base-10 numbers is reported only when
1166 there's no portable and simple way to convert to floating point.
1167
1168 * textprop.c (set_text_properties_1): Rewrite for clarity,
1169 and to avoid GCC warning about integer overflow.
1170
1171 * intervals.h (struct interval): Use EMACS_INT for members
1172 where EMACS_UINT might cause problems. See
1173 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1174 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1175 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1176 All uses changed.
1177 (offset_intervals): Tell GCC not to worry about length overflow
1178 when negating a negative length.
1179
1180 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1181 (overrun_check_free): Likewise.
1182
1183 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1184 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1185 word size.
1186
1187 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1188 (gnutls_make_error): Rename local to avoid shadowing.
1189 (gnutls_emacs_global_deinit): ifdef out; not used.
1190 (Fgnutls_boot): Use const for pointer to readonly storage.
1191 Comment out unused local. Fix pointer signedness problems.
1192
1193 * lread.c (openp): Don't stuff size_t into an 'int'.
1194 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1195 about possible signed overflow.
1196
1197 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1198 (GDK_KEY_g): Don't define if already defined.
1199 (xg_prepare_tooltip): Avoid pointer signedness problem.
1200 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1201
1202 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1203 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1204
1205 * xfns.c (Fx_window_property): Simplify a bit,
1206 to make a bit faster and to avoid GCC 4.6.0 warning.
1207 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1208
1209 * fns.c (internal_equal): Don't assume size_t fits in int.
1210
1211 * alloc.c (compact_small_strings): Tighten assertion a little.
1212
1213 Replace pEd with more-general pI, and fix some printf arg casts.
1214 * lisp.h (pI): New macro, generalizing old pEd macro to other
1215 conversion specifiers. For example, use "...%"pI"d..." rather
1216 than "...%"pEd"...".
1217 (pEd): Remove. All uses replaced with similar uses of pI.
1218 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1219 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1220 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1221 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1222 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1223 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1224 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1225 64-bit hosts.
1226 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1227 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1228 * print.c (safe_debug_print, print_object): Likewise.
1229 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1230 to int.
1231 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1232 avoiding the 0 flag, which is not portable.
1233 * process.c (Fmake_network_process): Use pI to avoid cast.
1234 * region-cache.c (pp_cache): Likewise.
1235 * xdisp.c (decode_mode_spec): Likewise.
1236 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1237 behavior on 64-bit hosts with printf arg.
1238 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1239 (x_stop_queuing_selection_requests): Likewise.
1240 (x_get_window_property): Don't truncate byte count to an 'int'
1241 when tracing.
1242
1243 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1244 here, since it parses constructs like leading '-' and spaces,
1245 which are not wanted; and it overflows with large numbers.
1246 Instead, simply match F[0-9]+, which is what is wanted anyway.
1247
1248 * alloc.c: Remove unportable assumptions about struct layout.
1249 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1250 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1251 (allocate_vectorlike, make_pure_vector): Use the new macros,
1252 plus offsetof, to remove unportable assumptions about struct layout.
1253 These assumptions hold on all porting targets that I know of, but
1254 they are not guaranteed, they're easy to remove, and removing them
1255 makes further changes easier.
1256
1257 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1258 This doesn't fix a bug but makes the code clearer.
1259 (string_overrun_cookie): Now const. Use initializers that
1260 don't formally overflow signed char, to avoid warnings.
1261 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1262 can cause Emacs to crash when string overrun checking is enabled.
1263 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1264 multiple of sizeof (EMACS_INT); it need not be, if
1265 alignof(EMACS_INT) < sizeof (EMACS_INT).
1266 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1267
12682011-04-26 Juanma Barranquero <lekktu@gmail.com>
1269
1270 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1271
12722011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1273
1274 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1275 supposed to be handshaking. (Bug#8556)
1276 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1277
12782011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1279
1280 * lisp.h (Qdebug): List symbol.
1281 * eval.c (Qdebug): Restore global linkage.
1282 * keyboard.c (debug-on-event): New variable.
1283 (handle_user_signal): Break into debugger when debug-on-event
1284 matches the current signal symbol.
1285
12862011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1287
1288 * alloc.c (check_sblock, check_string_bytes)
1289 (check_string_free_list): Convert to standard C.
1290
12912011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1292
1293 * w32.c (emacs_gnutls_push): Fix typo.
1294
12952011-04-25 Eli Zaretskii <eliz@gnu.org>
1296
1297 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1298 "cast to pointer from integer of different size".
1299
1300 Improve doprnt and its use in verror. (Bug#8545)
1301 * doprnt.c (doprnt): Document the set of format control sequences
1302 supported by the function. Use SAFE_ALLOCA instead of always
1303 using `alloca'.
1304
1305 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1306 is one byte too soon. Don't use xrealloc; instead xfree and
1307 xmalloc anew.
1308
13092011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1310
1311 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1312 callbacks stage.
1313
1314 * gnutls.c: Renamed global_initialized to
1315 gnutls_global_initialized. Added internals for the
1316 :verify-hostname-error, :verify-error, and :verify-flags
1317 parameters of `gnutls-boot' and documented those parameters in the
1318 docstring. Start callback support.
1319 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1320 unless a fatal error occured. Call gnutls_alert_send_appropriate
1321 on error. Return error code.
1322 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1323 (emacs_gnutls_read): Likewise.
1324 (Fgnutls_boot): Return handshake error code.
1325 (emacs_gnutls_handle_error): New function.
1326 (wsaerror_to_errno): Likewise.
1327
1328 * w32.h (emacs_gnutls_pull): Add prototype.
1329 (emacs_gnutls_push): Likewise.
1330
1331 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1332 (emacs_gnutls_push): Likewise.
1333
13342011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1335
1336 * process.c (wait_reading_process_output): Check if GnuTLS
1337 buffered some data internally if no FDs are set for TLS
1338 connections.
1339
1340 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1341 (LIBS): Link to USER_LIBS.
1342 ($(BLD)/gnutls.$(0)): New target.
1343
13442011-04-24 Eli Zaretskii <eliz@gnu.org>
1345
1346 * xdisp.c (handle_single_display_spec): Rename the
1347 display_replaced_before_p argument into display_replaced_p, to
1348 make it consistent with the commentary. Fix typos in the
1349 commentary.
1350
1351 * textprop.c (syms_of_textprop): Remove dead code.
1352 (copy_text_properties): Delete obsolete commentary about an
1353 interface that was deleted long ago. Fix typos in the description
1354 of arguments.
1355
1356 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1357 to changes in oldXMenu/XMenu.h from 2011-04-16.
1358 <menu_help_message, prev_menu_help_message>: Constify.
1359 (IT_menu_make_room): menu->help_text is now `const char **';
1360 adjust.
1361
1362 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1363 to changes in oldXMenu/XMenu.h from 2011-04-16.
1364 (struct XMenu): Declare `help_text' `const char **'.
1365
1366 * xfaces.c <Qunspecified>: Make extern again.
1367
1368 * syntax.c: Include sys/types.h before including regex.h, as
1369 required by Posix.
1370
1371 * doc.c (get_doc_string): Improve the format passed to `error'.
1372
1373 * doprnt.c (doprnt): Improve commentary.
1374
1375 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1376
1377 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1378 them with etags.
1379
1380 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1381 changes in globals.h immediately force recompilation.
1382 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1383 $(CURDIR)/s/ms-w32.h.
1384 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1385
1386 * character.c (Fchar_direction): Function deleted.
1387 (syms_of_character): Don't defsubr it.
1388 <char-direction-table>: Deleted.
1389
13902011-04-23 Eli Zaretskii <eliz@gnu.org>
1391
1392 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1393 * doprnt.c: Include limits.h.
1394 (SIZE_MAX): New macro.
1395 (doprnt): Return a size_t value. 2nd arg is now size_t.
1396 Many local variables are now size_t instead of int or unsigned.
1397 Improve overflow protection. Support `l' modifier for integer
1398 conversions. Support %l conversion. Don't assume an EMACS_INT
1399 argument for integer conversions and for %c.
1400
1401 * lisp.h (doprnt): Restore prototype.
1402
1403 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1404 $(SRC)/character.h.
1405
1406 * Makefile.in (base_obj): Add back doprnt.o.
1407
1408 * deps.mk (doprnt.o): Add back prerequisites.
1409 (callint.o): Depend on character.h.
1410
1411 * eval.c (internal_lisp_condition_case): Include the handler
1412 representation in the error message.
1413 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1414 when breaking from the loop.
1415
1416 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1417
1418 * callint.c (Fcall_interactively): When displaying error message
1419 about invalid control letter, pass the character's codepoint, not
1420 a pointer to its multibyte form. Improve display of the character
1421 in octal and display also its hex code.
1422
1423 * character.c (char_string): Use %x to display the (unsigned)
1424 codepoint of an invalid character, to avoid displaying a bogus
1425 negative value.
1426
1427 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1428 `error', not SYMBOL_NAME itself.
1429
1430 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1431 character arguments to `error'.
1432
1433 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1434 to `error' in error message about FINAL_CHAR argument. Make sure
1435 FINAL_CHAR is a character, and use %c when it is passed as
1436 argument to `error'.
1437
14382011-04-23 Eli Zaretskii <eliz@gnu.org>
1439
1440 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1441
1442 * w32.c: Include <time.h>.
1443 (sys_localtime): New function.
1444
14452011-04-23 Chong Yidong <cyd@stupidchicken.com>
1446
1447 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1448
1449 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1450
14512011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1452
1453 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1454 zombies (Bug#8467).
1455
14562011-04-19 Eli Zaretskii <eliz@gnu.org>
1457
1458 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1459 gl_state.e_property when gl_state.object is Qt.
1460
1461 * insdel.c (make_gap_larger): Remove limitation of buffer size
1462 to <= INT_MAX.
1463
14642011-04-18 Chong Yidong <cyd@stupidchicken.com>
1465
1466 * xdisp.c (lookup_glyphless_char_display)
1467 (produce_glyphless_glyph): Handle cons cell entry in
1468 glyphless-char-display.
1469 (Vglyphless_char_display): Document it.
1470
1471 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1472 glyphless-char-display.
1473
14742011-04-17 Chong Yidong <cyd@stupidchicken.com>
1475
1476 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1477
1478 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1479
1480 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1481 definition for no-X builds.
1482
14832011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 Static checks with GCC 4.6.0 and non-default toolkits.
1486
1487 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1488
1489 * process.c (keyboard_bit_set): Define only if SIGIO.
1490 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1491 (send_process): Repair possible setjmp clobbering.
1492
1493 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1494
1495 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1496
1497 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1498
1499 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1500 Define only if needed.
1501
1502 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1503 by pacifying GCC about it. Maybe it's time to retire it?
1504 * xfaces.c (USG, __TIMEVAL__): Likewise.
1505
1506 * dispextern.h (struct redisplay_interface): Rename param
1507 to avoid shadowing.
1508 * termhooks.h (struct terminal): Likewise.
1509 * xterm.c (xembed_send_message): Likewise.
1510
1511 * insdel.c (make_gap_smaller): Define only if
1512 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1513
1514 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1515 it.
1516
1517 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1518 so that we aren't warned about unused symbols.
1519
1520 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1521
1522 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1523
1524 * xfns.c (x_real_positions): Mark locals as initialized.
1525
1526 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1527
1528 * xterm.c: Fix problems found by static analysis with other toolkits.
1529 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1530 (x_dispatch_event): Declare static if USE_GTK, and
1531 define if USE_GTK || USE_X_TOOLKIT.
1532 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1533 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1534 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1535 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1536
1537 * xmenu.c (menu_help_callback): Pointer type fixes.
1538 Use const pointers when pointing at readonly data. Avoid pointer
1539 signedness clashes.
1540 (FALSE): Remove unused macro.
1541 (update_frame_menubar): Remove unused decl.
1542
1543 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1544
1545 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1546 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1547 (single_menu_item): Rename local to avoid shadowing.
1548
1549 * keyboard.c (make_lispy_event): Remove unused local var.
1550
1551 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1552 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1553
1554 * bitmaps: Change bitmaps from unsigned char back to the X11
1555 compatible char. Avoid the old compiler warnings about
1556 out-of-range initializers by using, for example, '\xab' rather
1557 than 0xab.
1558
1559 * xgselect.c (xgselect_initialize): Check vs interface
1560 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1561
1562 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1563
1564 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1565 to read-only memory.
1566
1567 * fns.c (vector): Remove; this old hack is no longer needed.
1568
1569 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1570 Remove unused var.
1571 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1572
1573 * xrdb.c (x_load_resources): Omit unused local.
1574
1575 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1576 (x_window): Rename locals to avoid shadowing.
1577 (USG): Use the kludged USG macro, to pacify gcc.
1578
1579 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1580 (x_term_init): Remove local to avoid shadowing.
1581
1582 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1583
1584 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1585 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1586
15872011-04-16 Eli Zaretskii <eliz@gnu.org>
1588
1589 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1590
1591 Fix regex.c, syntax.c and friends for buffers > 2GB.
1592 * syntax.h (struct gl_state_s): Declare character position members
1593 EMACS_INT.
1594
1595 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1596
1597 * textprop.c (verify_interval_modification, interval_of):
1598 Declare arguments EMACS_INT.
1599
1600 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1601 EMACS_INT.
1602
1603 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1604
1605 * indent.c (Fvertical_motion): Local variable it_start is now
1606 EMACS_INT.
1607
1608 * regex.c (re_match, re_match_2, re_match_2_internal)
1609 (bcmp_translate, regcomp, regexec, print_double_string)
1610 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1611 (re_compile_pattern, re_exec): Declare arguments and local
1612 variables `size_t' and `ssize_t' and return values `regoff_t', as
1613 appropriate.
1614 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1615 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1616 <compile_stack_type>: `size' and `avail' are now `size_t'.
1617
1618 * regex.h <regoff_t>: Use ssize_t, not int.
1619 (re_search, re_search_2, re_match, re_match_2): Arguments that
1620 specify buffer/string position and length are now ssize_t and
1621 size_t. Return type is regoff_t.
1622
16232011-04-16 Ben Key <bkey76@gmail.com>
1624
1625 * nsfont.m: Fixed bugs in ns_get_family and
1626 ns_descriptor_to_entity that were caused by using free to
1627 deallocate memory blocks that were allocated by xmalloc (via
1628 xstrdup). This caused Emacs to crash when compiled with
1629 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1630 --enable-checking=xmallocoverrun). xfree is now used to
1631 deallocate these memory blocks.
1632
16332011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1634
1635 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1636
1637 emacs_write: Accept and return EMACS_INT for sizes.
1638 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1639 et seq.
1640 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1641 Accept and return EMACS_INT.
1642 (emacs_gnutls_write): Return the number of bytes written on
1643 partial writes.
1644 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1645 (emacs_read, emacs_write): Remove check for negative size, as the
1646 Emacs source code has been audited now.
1647 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1648 (emacs_read, emacs_write): Use it.
1649 * process.c (send_process): Adjust to the new signatures of
1650 emacs_write and emacs_gnutls_write. Do not attempt to store
1651 a byte offset into an 'int'; it might overflow.
1652 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1653
1654 * sound.c: Don't assume sizes fit in 'int'.
1655 (struct sound_device.period_size, alsa_period_size):
1656 Return EMACS_INT, not int.
1657 (struct sound_device.write, vox_write, alsa_write):
1658 Accept EMACS_INT, not int.
1659 (wav_play, au_play): Use EMACS_INT to store sizes and to
1660 record read return values.
1661
16622011-04-15 Ben Key <bkey76@gmail.com>
1663
1664 * keyboard.c (Qundefined): Don't declare static since it is used
1665 in nsfns.m.
1666 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1667 static since they are used in nsfont.m.
1668
16692011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1670
1671 * process.c (Qprocessp): Don't declare static.
1672 * lisp.h (Qprocessp): Declare again.
1673
16742011-04-15 Juanma Barranquero <lekktu@gmail.com>
1675
1676 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1677
16782011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 Improve C-level modularity by making more things 'static'.
1681
1682 Don't publish debugger-only interfaces to other modules.
1683 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1684 (verify_bytepos, count_markers): Move decls to the only modules
1685 that need them.
1686 * region-cache.h (pp_cache): Likewise.
1687 * window.h (check_all_windows): Likewise.
1688 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1689
1690 * sysdep.c (croak): Now static, if
1691 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1692 * syssignal.h (croak): Declare only if not static.
1693
1694 * alloc.c (refill_memory_reserve): Now static if
1695 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1696 * lisp.h (refill_memory_reserve): Declare only if not static.
1697
1698 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1699 Define only if USE_LUCID.
1700
1701 * xrdb.c (x_customization_string, x_rm_string): Now static.
1702
1703 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1704 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1705
1706 * xdisp.c (draw_row_with_mouse_face): Now static.
1707 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1708
1709 * window.h (check_all_windows): Mark externally visible.
1710
1711 * window.c (window_deletion_count): Now static.
1712
1713 * undo.c: Make symbols static if they're not exported.
1714 (last_undo_buffer, last_boundary_position, pending_boundary):
1715 Now static.
1716
1717 * textprop.c (interval_insert_behind_hooks): Now static.
1718 (interval_insert_in_front_hooks): Likewise.
1719
1720 * term.c: Make symbols static if they're not exported.
1721 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1722 (max_frame_lines, tty_set_terminal_modes):
1723 (tty_reset_terminal_modes, tty_turn_off_highlight):
1724 (get_tty_terminal): Now static.
1725 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1726 * termhooks.h (term_mouse_moveto): Do not declare if
1727 HAVE_WINDOW_SYSTEM.
1728 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1729 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1730
1731 * sysdep.c: Make symbols static if they're not exported.
1732 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1733 Now static.
1734 (sigprocmask_set, full_mask): Remove; unused.
1735 (wait_debugging): Mark as visible.
1736 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1737 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1738
1739 * syntax.c (syntax_temp): Define only if !__GNUC__.
1740
1741 * sound.c (current_sound_device, current_sound): Now static.
1742
1743 * search.c (searchbufs, searchbuf_head): Now static.
1744
1745 * scroll.c (scroll_cost): Remove; unused.
1746 * dispextern.h (scroll_cost): Remove decl.
1747
1748 * region-cache.h (pp_cache): Mark as externally visible.
1749
1750 * process.c: Make symbols static if they're not exported.
1751 (process_tick, update_tick, create_process, chan_process):
1752 (Vprocess_alist, proc_buffered_char, datagram_access):
1753 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1754 (deactivate_process): Mark defn as static, as well as decl.
1755 * lisp.h (create_process): Remove decl.
1756 * process.h (chan_process, Vprocess_alist): Remove decls.
1757
1758 * print.c: Make symbols static if they're not exported.
1759 (print_depth, new_backquote_output, being_printed, print_buffer):
1760 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1761 (print_interval, print_number_index, initial_stderr_stream):
1762 Now static.
1763 * lisp.h (Fprinc): Remove decl.
1764 (debug_output_compilation_hack): Mark as externally visible.
1765
1766 * sysdep.c (croak): Move decl from here to syssignal.h.
1767 * syssignal.h (croak): Put it here, so the API can be checked when
1768 'croak' is called from dissociate_if_controlling_tty.
1769
1770 * minibuf.c: Make symbols static if they're not exported.
1771 (minibuf_save_list, choose_minibuf_frame): Now static.
1772 * lisp.h (choose_minibuf_frame): Remove decl.
1773
1774 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1775
1776 * lread.c: Make symbols static if they're not exported.
1777 (read_objects, initial_obarray, oblookup_last_bucket_number):
1778 Now static.
1779 (make_symbol): Remove; unused.
1780 * lisp.h (initial_obarray, make_symbol): Remove decls.
1781
1782 * keyboard.c: Make symbols static if they're not exported.
1783 (single_kboard, recent_keys_index, total_keys, recent_keys):
1784 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1785 (this_single_command_key_start, echoing, last_auto_save):
1786 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1787 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1788 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1789 (Vlispy_mouse_stem, double_click_count):
1790 Now static.
1791 (force_auto_save_soon): Define only if SIGDANGER.
1792 (ignore_mouse_drag_p): Now static if
1793 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1794 (print_help): Remove; unused.
1795 (stop_character, last_timer_event): Mark as externally visible.
1796 * keyboard.h (ignore_mouse_drag_p): Declare only if
1797 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1798 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1799 * lisp.h (echoing): Remove decl.
1800 (force_auto_save_soon): Declare only if SIGDANGER.
1801 * xdisp.c (redisplay_window): Simplify code, to make it more
1802 obvious that ignore_mouse_drag_p is not accessed if !defined
1803 USE_GTK && !defined HAVE_NS.
1804
1805 * intervals.c: Make symbols static if they're not exported.
1806 (merge_properties_sticky, merge_interval_right, delete_interval):
1807 Now static.
1808 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1809
1810 * insdel.c: Make symbols static if they're not exported.
1811 However, leave prepare_to_modify_buffer alone. It's never
1812 called from outside this function, but that appears to be a bug.
1813 (combine_after_change_list, combine_after_change_buffer):
1814 (adjust_after_replace, signal_before_change): Now static.
1815 (adjust_after_replace_noundo): Remove; unused.
1816 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1817 (signal_before_change): Remove decls.
1818
1819 * indent.c (val_compute_motion, val_vmotion): Now static.
1820
1821 * image.c: Make symbols static if they're not exported.
1822 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1823 if USE_GTK.
1824 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1825 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1826
1827 * fringe.c (standard_bitmaps): Now static.
1828 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1829
1830 * frame.c: Make symbols static if they're not exported.
1831 (x_report_frame_params, make_terminal_frame): Now static.
1832 (get_frame_param): Now static, unless HAVE_NS.
1833 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1834 (x_get_resource_string): Remove; not used.
1835 * frame.h (make_terminal_frame, x_report_frame_params):
1836 (x_get_resource_string); Remove decls.
1837 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1838 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1839
1840 * font.c, fontset.c: Make symbols static if they're not exported.
1841 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1842 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1843 * font.c (font_close_object): Now static.
1844 * font.h (font_close_object): Remove.
1845 * fontset.c (FONTSET_OBJLIST): Remove.
1846 (free_realized_fontset) #if-0 the body, which does nothing.
1847 (face_suitable_for_char_p): #if-0, as it's never called.
1848 * fontset.h (face_suitable_for_char_p): Remove decl.
1849 * xfaces.c (face_at_string_position):
1850 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1851 since 0 is always ASCII.
1852
1853 * fns.c (weak_hash_tables): Now static.
1854
1855 * fileio.c: Make symbols static if they're not exported.
1856 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1857 (Vwrite_region_annotation_buffers): Now static.
1858
1859 * eval.c: Make symbols static if they're not exported.
1860 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1861 * lisp.h (backtrace_list): Remove decl.
1862
1863 * emacs.c: Make symbols static if they're not exported.
1864 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1865 (fatal_error_code, fatal_error_signal_hook, standard_args):
1866 Now static.
1867 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1868 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1869 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1870 * lisp.h (fatal_error_signal_hook): Remove decl.
1871 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1872
1873 * editfns.c: Move a (normally-unused) function to its only use.
1874 * editfns.c, lisp.h (get_operating_system_release): Remove.
1875 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1876 worth the hassle of breaking this out.
1877
1878 * xterm.c: Make symbols static if they're not exported.
1879 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1880 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1881 (x_destroy_window, x_delete_display):
1882 Now static.
1883 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1884 (x_mouse_leave): Remove; unused.
1885 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1886 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1887 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1888 Remove decls.
1889 (x_mouse_leave): Declare only if WINDOWSNT.
1890 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1891 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1892 USE_X_TOOLKIT.
1893
1894 * ftxfont.c: Make symbols static if they're not exported.
1895 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1896 HAVE_FREETYPE.
1897 * font.h (ftxfont_driver): Likewise.
1898
1899 * xfns.c: Make symbols static if they're not exported.
1900 (x_last_font_name, x_display_info_for_name):
1901 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1902 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1903 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1904 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1905 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1906 (last_show_tip_args): Now static.
1907 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1908 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1909 (x_screen_planes): Remove; unused.
1910 * dispextern.h (x_screen_planes): Remove decl.
1911
1912 * dispnew.c: Make symbols static if they're not exported.
1913 * dispextern.h (redraw_garbaged_frames, scrolling):
1914 (increment_row_positions): Remove.
1915 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1916 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1917 Now static.
1918 (redraw_garbaged_frames): Remove; unused.
1919
1920 * xfaces.c: Make symbols static if they're not exported.
1921 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1922 Remove decls.
1923 * xterm.h (defined_color): Remove decls.
1924 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1925 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1926 (menu_face_changed_default, defined_color, free_realized_face):
1927 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1928 (ascii_face_of_lisp_face): Remove; unused.
1929
1930 * xdisp.c: Make symbols static if they're not exported.
1931 * dispextern.h (scratch_glyph_row, window_box_edges):
1932 (glyph_to_pixel_coords, set_cursor_from_row):
1933 (get_next_display_element, set_iterator_to_next):
1934 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1935 (show_mouse_face): Remove decls
1936 * frame.h (message_buf_print): Likewise.
1937 * lisp.h (pop_message, set_message, check_point_in_composition):
1938 Likewise.
1939 * xterm.h (set_vertical_scroll_bar): Likewise.
1940 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1941 (message_buf_print, scratch_glyph_row, displayed_buffer):
1942 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1943 (get_next_display_element, show_mouse_face, window_box_edges):
1944 (frame_to_window_pixel_xy, check_point_in_composition):
1945 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1946 (glyph_to_pixel_coords): Remove; unused.
1947
1948 * dired.c (file_name_completion): Now static.
1949
1950 * dbusbind.c (xd_in_read_queued_messages): Now static.
1951
1952 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1953 * data.c (circular_list_error): Remove.
1954
1955 * commands.h (last_point_position, last_point_position_buffer):
1956 (last_point_position_window): Remove decls.
1957 * keyboard.c: Make these variables static.
1958
1959 * coding.h (coding, code_convert_region, encode_coding_gap):
1960 Remove decls.
1961 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1962 (iso_code_class, detect_coding, code_convert_region): Now static.
1963 (encode_coding_gap): Remove; unused.
1964
1965 * chartab.c (chartab_chars, chartab_bits): Now static.
1966
1967 * charset.h (charset_iso_8859_1): Remove decl.
1968 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1969 Now static.
1970
1971 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1972 * ccl.c (Vccl_program_table): Now static.
1973 (check_ccl_update): Remove; unused.
1974
1975 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1976 * category.h: ... from here.
1977 * category.c (check_category_table, set_category_set): Now static.
1978
1979 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1980 * lisp.h: Remove these decls.
1981
1982 * buffer.c (buffer_count): Remove unused var.
1983
1984 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1985 so that it's not optimized away.
1986 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1987 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1988 exported only to the debugger.
1989
1990 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1991 * atimer.h (run_all_atimers): Remove; not exported.
1992
1993 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1994 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1995 was inaccessible from Lisp.
1996 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1997 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1998
1999 alloc.c: Import and export fewer symbols, and remove unused items.
2000 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2001 is defined.
2002 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2003 it's not optimized away by whole-program optimization.
2004 (message_enable_multibyte, free_misc): Remove.
2005 (catchlist, handlerlist, mark_backtrace):
2006 Declare only if BYTE_MARK_STACK.
2007 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2008 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2009 (message_enable_multibyte): Remove decl.
2010 (free_misc, interval_free_list, float_block, float_block_index):
2011 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2012 (cons_free_list, last_marked_index):
2013 Now static.
2014 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2015 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2016 (mark_backtrace): Define only if BYTE_MARK_STACK.
2017 * xdisp.c (message_enable_multibyte): Now static.
2018
2019 Declare Lisp_Object Q* variables to be 'static' if not exported.
2020 This makes it easier for human readers (and static analyzers)
2021 to see whether these variables are used from other modules.
2022 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2023 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2024 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2025 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2026 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2027 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2028 * xmenu.c, xselect.c:
2029 Declare Q* vars static if they are not used in other modules.
2030 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2031 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2032 Remove decls of unexported vars.
2033 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2034
2035 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2036
2037 Make Emacs functions such as Fatom 'static' by default.
2038 This makes it easier for human readers (and static analyzers)
2039 to see whether these functions can be called from other modules.
2040 DEFUN now defines a static function. To make the function external
2041 so that it can be used in other C modules, use the new macro DEFUE.
2042 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2043 (Finit_image_library):
2044 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2045 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2046 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2047 Remove decls, since these functions are now static.
2048 (Funintern, Fget_internal_run_time): New decls, since these functions
2049 were already external.
2050
2051 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2052 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2053 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2054 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2055 * keyboard.c, keymap.c, lread.c:
2056 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2057 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2058 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2059 Mark functions with DEFUE instead of DEFUN,
2060 if they are used in other modules.
2061 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2062 decls for now-static functions.
2063 * buffer.h (Fdelete_overlay): Remove decl.
2064 * callproc.c (Fgetenv_internal): Mark as internal.
2065 * composite.c (Fremove_list_of_text_properties): Remove decl.
2066 (Fcomposition_get_gstring): New forward static decl.
2067 * composite.h (Fcomposite_get_gstring): Remove decl.
2068 * dired.c (Ffile_attributes): New forward static decl.
2069 * doc.c (Fdocumntation_property): New forward static decl.
2070 * eval.c (Ffetch_bytecode): New forward static decl.
2071 (Funintern): Remove extern decl; now in .h file where it belongs.
2072 * fileio.c (Fmake_symbolic_link): New forward static decl.
2073 * image.c (Finit_image_library): New forward static decl.
2074 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2075 * intervals.h (Fprevious_property_change):
2076 (Fremove_list_of_text_properties): Remove decls.
2077 * keyboard.c (Fthis_command_keys): Remove decl.
2078 (Fcommand_execute): New forward static decl.
2079 * keymap.c (Flookup_key): New forward static decl.
2080 (Fcopy_keymap): Now static.
2081 * keymap.h (Flookup_key): Remove decl.
2082 * process.c (Fget_process): New forward static decl.
2083 (Fprocess_datagram_address): Mark as internal.
2084 * syntax.c (Fsyntax_table_p): New forward static decl.
2085 (skip_chars): Remove duplicate decl.
2086 * textprop.c (Fprevious_property_change): New forward static decl.
2087 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2088 Now internal.
2089 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2090 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2091
2092 * editfns.c (Fformat): Remove unreachable code.
2093
20942011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2095
2096 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2097 change. (Bug#8496)
2098
20992011-04-13 Eli Zaretskii <eliz@gnu.org>
2100
2101 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2102 when at ZV. (Bug#8487)
2103
21042011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2105
2106 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2107 (Bug#8437)
2108 * keyboard.c (parse_tool_bar_item): Likewise.
2109 * sound.c (sound_cleanup, alsa_close): Likewise.
2110 * termcap.c (tgetent): Likewise.
2111 * xfns.c (x_default_font_parameter): Likewise.
2112 * xsettings.c (read_and_apply_settings): Likewise.
2113
2114 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2115 (overrun_check_free): Protoize.
2116
21172011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2118
2119 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2120 since callers should never pass a negative size.
2121 Change the signature to match that of plain 'read' and 'write'; see
2122 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2123 * lisp.h: Update prototypes of emacs_write and emacs_read.
2124
21252011-04-11 Eli Zaretskii <eliz@gnu.org>
2126
2127 * xdisp.c (redisplay_window): Don't try to determine the character
2128 position of the scroll margin if the window start point w->startp
2129 is outside the buffer's accessible region. (Bug#8468)
2130
21312011-04-10 Eli Zaretskii <eliz@gnu.org>
2132
2133 Fix write-region and its subroutines for buffers > 2GB.
2134 * fileio.c (a_write, e_write): Modify declaration of arguments and
2135 local variables to support buffers larger than 2GB.
2136 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2137
2138 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2139 argument, local variables, and return value.
2140
2141 * lisp.h: Update prototypes of emacs_write and emacs_read.
2142
2143 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2144
21452011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2146
2147 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2148
2149 Fix more problems found by GCC 4.6.0's static checks.
2150
2151 * xdisp.c (vmessage): Use a better test for character truncation.
2152
2153 * charset.c (load_charset_map): <, not <=, for optimization,
2154 and to avoid potential problems with integer overflow.
2155 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2156 * casetab.c (set_identity, shuffle): Likewise.
2157 * editfns.c (Fformat): Likewise.
2158 * syntax.c (skip_chars): Likewise.
2159
2160 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2161 This also lets GCC 4.6.0 generate slightly better loop code.
2162
2163 * callint.c (Fcall_interactively): <, not <=, for optimization.
2164 (Fcall_interactively): Count the number of arguments produced,
2165 not the number of arguments given. This is simpler and lets GCC
2166 4.6.0 generate slightly better code.
2167
2168 * ftfont.c: Distingish more carefully between FcChar8 and char.
2169 The previous code passed unsigned char * to a functions like
2170 strlen and xstrcasecmp that expect char *, which does not
2171 conform to the C standard.
2172 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2173 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2174 char * when the C standard requires it.
2175
2176 * keyboard.c (read_char): Remove unused var.
2177
2178 * eval.c: Port to Windows vsnprintf (Bug#8435).
2179 Include <limits.h>.
2180 (SIZE_MAX): Define if the headers do not.
2181 (verror): Do not give up if vsnprintf returns a negative count.
2182 Instead, grow the buffer. This ports to Windows vsnprintf, which
2183 does not conform to C99. Problem reported by Eli Zaretskii.
2184 Also, simplify the allocation scheme, by avoiding the need for
2185 calling realloc, and removing the ALLOCATED variable.
2186
2187 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2188
2189 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2190 But keep the doprint source code for now, as we might revamp it
2191 and use it again (Bug#8435).
2192 * lisp.h (doprnt): Remove.
2193 * Makefile.in (base_obj): Remove doprnt.o.
2194 * deps.mk (doprnt.o): Remove.
2195
2196 error: Print 32- and 64-bit integers portably (Bug#8435).
2197 Without this change, on typical 64-bit hosts error ("...%d...", N)
2198 was used to print both 32- and 64-bit integers N, which relied on
2199 undefined behavior.
2200 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2201 New macro.
2202 * lisp.h (error, verror): Mark as printf-like functions.
2203 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2204 Report overflow in size calculations when allocating printf buffer.
2205 Do not truncate output string at its first null byte.
2206 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2207 Truncate the output at a character boundary, since vsnprintf does not
2208 do that.
2209 * charset.c (check_iso_charset_parameter): Convert internal
2210 character to string before calling 'error', since %c now has the
2211 printf meaning.
2212 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2213 overflow when computing char to be passed to 'error'. Do not
2214 pass Lisp_Object to 'error'; pass the integer instead.
2215 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2216 formatted with plain %d.
2217
2218 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2219
2220 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2221
2222 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2223
2224 * xterm.c (x_catch_errors): Remove duplicate declaration.
2225
2226 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2227
2228 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2229
22302011-04-10 Jim Meyering <meyering@redhat.com>
2231
2232 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2233 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2234 return ssize_t not "int", and use size_t as the buffer length.
2235 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2236 * gnutls.h: Update declarations.
2237 * process.c (read_process_output): Use ssize_t, to match.
2238 (send_process): Likewise.
2239
22402011-04-09 Chong Yidong <cyd@stupidchicken.com>
2241
2242 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2243
22442011-04-09 Chong Yidong <cyd@stupidchicken.com>
2245
2246 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2247 Use unsigned char, to match FcChar8 type definition.
2248
2249 * xterm.c (handle_one_xevent):
2250 * xmenu.c (create_and_show_popup_menu):
2251 * xselect.c (x_decline_selection_request)
2252 (x_reply_selection_request): Avoid type-punned deref of X events.
2253
22542011-04-09 Eli Zaretskii <eliz@gnu.org>
2255
2256 Fix some uses of `int' instead of EMACS_INT.
2257 * search.c (string_match_1, fast_string_match)
2258 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2259 (scan_buffer, find_next_newline_no_quit)
2260 (find_before_next_newline, search_command, Freplace_match)
2261 (Fmatch_data): Make some `int' variables be EMACS_INT.
2262
2263 * xdisp.c (display_count_lines): 3rd argument and return value now
2264 EMACS_INT. All callers changed.
2265 (pint2hrstr): Last argument is now EMACS_INT.
2266
2267 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2268 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2269 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2270 (decode_coding_utf_16, decode_coding_emacs_mule)
2271 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2272 (decode_coding_ccl, decode_coding_charset)
2273 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2274 (decode_coding_iso_2022, decode_coding_emacs_mule)
2275 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2276 <char_offset, last_offset>: Declare EMACS_INT.
2277 (encode_coding_utf_8, encode_coding_utf_16)
2278 (encode_coding_emacs_mule, encode_invocation_designation)
2279 (encode_designation_at_bol, encode_coding_iso_2022)
2280 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2281 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2282 Declare EMACS_INT.
2283 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2284 (encode_invocation_designation): Last argument P_NCHARS is now
2285 EMACS_INT.
2286 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2287 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2288
2289 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2290 All users changed.
2291
2292 * ccl.c (Fccl_execute_on_string): Declare some variables
2293 EMACS_INT.
2294
22952011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2296
2297 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2298
22992011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2300
2301 * process.c (Fformat_network_address): Doc fix.
2302
23032011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2304
2305 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2306
23072011-04-08 Chong Yidong <cyd@stupidchicken.com>
2308
2309 * keyboard.c (read_char): Call Lisp function help-form-show,
2310 instead of using internal_with_output_to_temp_buffer.
2311 (Qhelp_form_show): New var.
2312 (syms_of_keyboard): Use DEFSYM macro.
2313
2314 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2315
2316 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2317
23182011-04-06 Chong Yidong <cyd@stupidchicken.com>
2319
2320 * process.c (Flist_processes): Remove to Lisp.
2321 (list_processes_1): Delete.
2322
23232011-04-06 Eli Zaretskii <eliz@gnu.org>
2324
2325 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2326
2327 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2328
23292011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 Fix more problems found by GCC 4.6.0's static checks.
2332
2333 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2334
2335 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2336
2337 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2338
2339 * xdisp.c (vmessage): Mark as a printf-like function.
2340
2341 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2342
2343 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2344
2345 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2346 printf-like functions.
2347 (tiff_load): Add casts to remove these marks before passing them
2348 to system-supplied API.
2349
2350 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2351
2352 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2353 This avoids several warnings with gcc -Wstrict-overflow.
2354 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2355 directly, rather than having caller test rule sign. This avoids
2356 some unnecessary tests.
2357 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2358 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2359 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2360
2361 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2362 (xfont_open): Avoid unnecessary tests.
2363
2364 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2365
2366 * composite.h, composite.c (composition_gstring_put_cache):
2367 Use EMACS_INT, not int, for length.
2368
2369 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2370 breaking out part of COMPOSITION_DECODE_RULE.
2371 (COMPOSITION_DECODE_RULE): Use it.
2372 * composite.c (get_composition_id): Remove unused local vars,
2373 by using the new macro.
2374
2375 * textprop.c (set_text_properties_1): Change while to do-while,
2376 since the condition is always true at first.
2377
2378 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2379 (interval_deletion_adjustment): Return unsigned value.
2380 All uses changed.
2381
2382 * process.c (list_processes_1, create_pty, read_process_output):
2383 (exec_sentinel): Remove vars that were set but not used.
2384 (create_pty): Remove unnecessary "volatile"s.
2385 (Fnetwork_interface_info): Avoid possibility of int overflow.
2386 (read_process_output): Do adaptive read buffering even if carryover.
2387 (read_process_output): Simplify nbytes computation if buffered.
2388
2389 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2390
2391 * syntax.c (scan_words): Remove var that was set but not used.
2392 (update_syntax_table): Use unsigned instead of int.
2393
2394 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2395 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2396 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2397
2398 * print.c (print_error_message): Avoid int overflow.
2399
2400 * font.c (font_list_entities): Redo for clarity,
2401 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2402
2403 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2404 (font_score): Avoid potential overflow in diff calculation.
2405
2406 * fns.c (substring_both): Remove var that is set but not used.
2407 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2408
2409 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2410
2411 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2412 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2413 can always succeed if overflow has undefined behavior.
2414
2415 * search.c (boyer_moore, wordify): Remove vars set but not used.
2416 (wordify): Omit three unnecessary tests.
2417
2418 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2419 All callers changed. This avoids the need for an unused var.
2420
2421 * casefiddle.c (casify_region): Remove var that is set but not used.
2422
2423 * dired.c (file_name_completion): Remove var that is set but not used.
2424
2425 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2426
2427 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2428 (Finsert_file_contents): Remove unnecessary code checking fd.
2429
2430 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2431 Check for integer overflow on size calculations.
2432
2433 * buffer.c (Fprevious_overlay_change): Remove var that is set
2434 but not used.
2435
2436 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2437 Remove vars that are set but not used.
2438 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2439 (timer_check_2): Mark vars as initialized.
2440
2441 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2442
2443 * image.c (lookup_image): Remove var that is set but not used.
2444 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2445
2446 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2447 that are set but not used.
2448
2449 * xfns.c (make_invisible_cursor): Don't return garbage
2450 if XCreateBitmapFromData fails (Bug#8410).
2451
2452 * xselect.c (x_get_local_selection, x_handle_property_notify):
2453 Remove vars that are set but not used.
2454
2455 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2456 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2457
2458 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2459 Remove var that is set but not used.
2460 (scroll_bar_windows_size): Now size_t, not int.
2461 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2462 Check for overflow.
2463
2464 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2465 (map_tty_color) [!defined MSDOS]: Likewise.
2466
2467 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2468
2469 * coding.c: Remove vars that are set but not used.
2470 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2471 All callers changed.
2472 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2473 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2474 (decode_coding_charset): Remove vars that are set but not used.
2475
2476 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2477 that is set but not used.
2478
2479 * print.c (print_object): Remove var that is set but not used.
2480
2481 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2482 The gnulib version avoids calling malloc in the usual case,
2483 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2484 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2485 * filelock.c (current_lock_owner): Likewise.
2486 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2487 * sysdep.c: Include allocator.h, careadlinkat.h.
2488 (emacs_no_realloc_allocator): New static constant.
2489 (emacs_readlink): New function.
2490 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2491 ../lib/careadlinkat.h.
2492
24932011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2494
2495 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2496 first non-nil return value).
2497
24982011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2499
2500 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2501 if not defined (Bug#8403).
2502
25032011-04-02 Juanma Barranquero <lekktu@gmail.com>
2504
2505 * xdisp.c (display_count_lines): Remove parameter `start',
2506 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2507 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2508 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2509 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2510 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2511 and thereabouts. All callers changed.
2512 (get_per_char_metric): Remove parameter `f', unused since
2513 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2514
25152011-04-02 Jim Meyering <meyering@redhat.com>
2516
2517 do not dereference NULL upon failed strdup
2518 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2519 (ns_get_family): Likewise.
2520
25212011-04-02 Juanma Barranquero <lekktu@gmail.com>
2522
2523 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2524
25252011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2526
2527 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2528 later (Bug#8403).
2529
25302011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2531
2532 Add lexical binding.
2533
2534 * window.c (Ftemp_output_buffer_show): New fun.
2535 (Fsave_window_excursion):
2536 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2537
2538 * lread.c (lisp_file_lexically_bound_p): New function.
2539 (Fload): Bind Qlexical_binding.
2540 (readevalloop): Remove `evalfun' arg.
2541 Bind Qinternal_interpreter_environment.
2542 (Feval_buffer): Bind Qlexical_binding.
2543 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2544 Mark as dynamic.
2545 (syms_of_lread): Declare `lexical-binding'.
2546
2547 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2548
2549 * keyboard.c (eval_dyn): New fun.
2550 (menu_item_eval_property): Use it.
2551
2552 * image.c (parse_image_spec): Use Ffunctionp.
2553
2554 * fns.c (concat, mapcar1): Accept byte-code-functions.
2555
2556 * eval.c (Fsetq): Handle lexical vars.
2557 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2558 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2559 (FletX, Flet): Obey lexical binding.
2560 (Fcommandp): Handle closures.
2561 (Feval): New `lexical' arg.
2562 (eval_sub): New function extracted from Feval. Use it almost
2563 everywhere where Feval was used. Look up vars in lexical env.
2564 Handle closures.
2565 (Ffunctionp): Move from subr.el.
2566 (Ffuncall): Handle closures.
2567 (apply_lambda): Remove `eval_flags'.
2568 (funcall_lambda): Handle closures and new byte-code-functions.
2569 (Fspecial_variable_p): New function.
2570 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2571 but without exporting it to Lisp.
2572
2573 * doc.c (Fdocumentation, store_function_docstring):
2574 * data.c (Finteractive_form): Handle closures.
2575
2576 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2577 interactive spec.
2578
2579 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2580 New byte-codes.
2581 (exec_byte_code): New function extracted from Fbyte_code to handle new
2582 calling convention for byte-code-functions. Add new byte-codes.
2583
2584 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2585
2586 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2587
25882011-03-31 Juanma Barranquero <lekktu@gmail.com>
2589
2590 * xdisp.c (redisplay_internal): Fix prototype.
2591
25922011-03-31 Eli Zaretskii <eliz@gnu.org>
2593
2594 * xdisp.c (SCROLL_LIMIT): New macro.
2595 (try_scrolling): Use it when setting scroll_limit.
2596 Limit scrolling to 100 screen lines.
2597 (redisplay_window): Even when falling back on "recentering",
2598 position point in the window according to scroll-conservatively,
2599 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2600
2601 (try_scrolling): When point is above the window, allow searching
2602 as far as scroll_max, or one screenful, to compute vertical
2603 distance from PT to the scroll margin position. This prevents
2604 try_scrolling from unnecessarily failing when
2605 scroll-conservatively is set to a value slightly larger than the
2606 window height. Clean up the case of PT below the margin at bottom
2607 of window: scroll_max can no longer be INT_MAX. When aggressive
2608 scrolling is in use, don't let point enter the opposite scroll
2609 margin as result of the scroll.
2610 (syms_of_xdisp) <scroll-conservatively>: Document the
2611 threshold of 100 lines for never-recentering scrolling.
2612
26132011-03-31 Juanma Barranquero <lekktu@gmail.com>
2614
2615 * dispextern.h (move_it_by_lines):
2616 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2617 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2618 (message_log_check_duplicate): Remove parameters `prev_bol' and
2619 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2620 (redisplay_internal): Remove parameter `preserve_echo_area',
2621 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2622
2623 * indent.c (Fvertical_motion):
2624 * window.c (window_scroll_pixel_based, Frecenter):
2625 Don't pass `need_y_p' to `move_it_by_lines'.
2626
26272011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2628
2629 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2630 steal a few bits to be more compact.
2631 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2632 Remove unneeded casts.
2633
2634 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2635
26362011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2637
2638 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2639 binding" message (bug#7967).
2640
26412011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 Fix more problems found by GCC 4.6.0's static checks.
2644
2645 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2646 Remove unused local var.
2647
2648 * editfns.c (Fmessage_box): Remove unused local var.
2649
2650 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2651 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2652 Omit unused local vars.
2653 * window.c (shrink_windows): Omit unused local var.
2654 * menu.c (digest_single_submenu): Omit unused local var.
2655 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2656 Omit unused local var.
2657
2658 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2659 Don't assume string length fits in int.
2660 (keyremap_step, read_key_sequence): Use size_t for sizes.
2661 (read_key_sequence): Don't check last_real_key_start redundantly.
2662
2663 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2664 instead of alloca (Bug#8344).
2665
2666 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2667 (Fbacktrace_frame): Don't assume nframes fits in int.
2668
2669 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2670
2671 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2672 concerns.
2673
2674 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2675
2676 * cm.c (calccost): Turn while-do into do-while, for clarity.
2677
2678 * keyboard.c (syms_of_keyboard): Use the same style as later
2679 in this function when indexing through an array. This also
2680 works around GCC bug 48267.
2681
2682 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2683
2684 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2685
2686 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2687 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2688
2689 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2690 This avoids undefined behavior on integer overflow, and is a bit
2691 more convenient anyway since it is compared to a size_t variable.
2692
2693 Variadic C functions now count arguments with size_t, not int.
2694 This avoids an unnecessary limitation on 64-bit machines, which
2695 caused (substring ...) to crash on large vectors (Bug#8344).
2696 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2697 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2698 All variadic functions and their callers changed accordingly.
2699 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2700 * data.c (arith_driver, float_arith_driver): Likewise.
2701 * editfns.c (general_insert_function): Likewise.
2702 * eval.c (struct backtrace.nargs, interactive_p)
2703 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2704 (funcall_lambda, mark_backtrace): Likewise.
2705 * fns.c (concat): Likewise.
2706 * frame.c (x_set_frame_parameters): Likewise.
2707 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2708 0 if not found, not -1. All callers changed.
2709
2710 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2711 (stack_copy_size): Now size_t, not int.
2712 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2713
27142011-03-28 Juanma Barranquero <lekktu@gmail.com>
2715
2716 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2717 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2718 All callers changed.
2719
2720 * lisp.h (multibyte_char_to_unibyte):
2721 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2722 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2723 * character.h (CHAR_TO_BYTE8):
2724 * cmds.c (internal_self_insert):
2725 * editfns.c (general_insert_function):
2726 * keymap.c (push_key_description):
2727 * search.c (Freplace_match):
2728 * xdisp.c (message_dolog, set_message_1): All callers changed.
2729
27302011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2731
2732 * keyboard.c (safe_run_hook_funcall): New function.
2733 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2734 don't set the hook to nil, but remove the offending function instead.
2735 (Qcommand_hook_internal): Remove, unused.
2736 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2737 Vcommand_hook_internal.
2738
2739 * eval.c (enum run_hooks_condition): Remove.
2740 (funcall_nil, funcall_not): New functions.
2741 (run_hook_with_args): Call each function through a `funcall' argument.
2742 Remove `cond' argument, now redundant.
2743 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2744 (Frun_hook_with_args_until_failure): Adjust accordingly.
2745 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2746
27472011-03-28 Juanma Barranquero <lekktu@gmail.com>
2748
2749 * dispextern.h (string_buffer_position): Remove declaration.
2750
2751 * print.c (strout): Remove parameter `multibyte', unused since
2752 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2753
2754 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2755 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2756 All callers changed.
2757
2758 * w32.c (_wsa_errlist): Use braces for struct initializers.
2759
2760 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2761 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2762 All callers changed.
2763 (string_buffer_position): Likewise. Also, make static (it's never
2764 used outside xdisp.c).
2765 (cursor_row_p): Remove parameter `w', unused since
2766 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2767 (decode_mode_spec): Remove parameter `precision', introduced during
2768 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2769 All callers changed.
2770
27712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2772
2773 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2774
27752011-03-27 Anders Lindgren <andlind@gmail.com>
2776
2777 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2778 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2779 (ns_update_auto_hide_menu_bar): New functions.
2780 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2781 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2782 ns_constrain_all_frames.
2783 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2784 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2785
27862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2787
2788 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2789
27902011-03-27 Glenn Morris <rgm@gnu.org>
2791
2792 * syssignal.h: Replace RETSIGTYPE with void.
2793 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2794 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2795 Replace SIGTYPE with void everywhere.
2796 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2797 * s/template.h (SIGTYPE): Remove commented out definition.
2798
27992011-03-26 Eli Zaretskii <eliz@gnu.org>
2800
2801 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2802 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2803
28042011-03-26 Juanma Barranquero <lekktu@gmail.com>
2805
2806 * w32.c (read_unc_volume): Use parameter `henum', instead of
2807 global variable `wget_enum_handle'.
2808
2809 * keymap.c (describe_vector): Remove parameters `indices' and
2810 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2811 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2812
2813 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2814
2815 * keyboard.c (timer_check): Remove parameter `do_it_now',
2816 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2817 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2818 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2819
2820 * keyboard.c (read_char):
2821 * w32menu.c (w32_menu_display_help):
2822 * xmenu.c (show_help_event, menu_help_callback):
2823 Adjust calls to `show_help_echo'.
2824
2825 * gtkutil.c (xg_maybe_add_timer):
2826 * keyboard.c (readable_events):
2827 * process.c (wait_reading_process_output):
2828 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2829
2830 * insdel.c (adjust_markers_gap_motion):
2831 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2832 (gap_left, gap_right): Don't call it.
2833
28342011-03-25 Chong Yidong <cyd@stupidchicken.com>
2835
2836 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2837 incurred during fontification.
2838
28392011-03-25 Juanma Barranquero <lekktu@gmail.com>
2840
2841 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2842 (DEFVAR_PER_BUFFER): Don't pass it.
2843
2844 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2845 (scrolling_window): Don't pass it.
2846
28472011-03-25 Juanma Barranquero <lekktu@gmail.com>
2848
2849 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2850
2851 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2852 and `suffix'.
2853 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2854 of variables specific to SELinux and computation of `encoded_absname'.
2855
2856 * image.c (XPutPixel): Remove unused variable `height'.
2857
2858 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2859
2860 * unexw32.c (get_section_info): Remove unused variable `section'.
2861
2862 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2863 (system_process_attributes): Remove unused variable `sess'.
2864 (sys_read): Remove unused variable `err'.
2865
2866 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2867 (w32_wnd_proc): Remove unused variable `isdead'.
2868 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2869 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2870 (x_create_tip_frame): Remove unused variable `tem'.
2871
2872 * w32inevt.c (w32_console_read_socket):
2873 Remove unused variable `no_events'.
2874
2875 * w32term.c (x_draw_composite_glyph_string_foreground):
2876 Remove unused variable `width'.
2877
28782011-03-24 Juanma Barranquero <lekktu@gmail.com>
2879
2880 * w32term.c (x_set_glyph_string_clipping):
2881 Don't pass uninitialized region to CombineRgn.
2882
28832011-03-23 Juanma Barranquero <lekktu@gmail.com>
2884
2885 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2886 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2887 (Fx_close_connection): Remove unused variable `i'.
2888
2889 * w32font.c (w32font_draw): Return number of glyphs.
2890 (w32font_open_internal): Remove unused variable `i'.
2891 (w32font_driver): Add missing initializer.
2892
2893 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2894 (fill_in_menu): Remove unused variable `items_added'.
2895
2896 * w32term.c (last_mouse_press_frame): Remove static global variable.
2897 (w32_clip_to_row): Remove unused variable `f'.
2898 (x_delete_terminal): Remove unused variable `i'.
2899
2900 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2901 (NOTHING): Remove unused static global variable.
2902 (uniscribe_check_otf): Remove unused variable `table'.
2903 (uniscribe_font_driver): Add missing initializers.
2904
29052011-03-23 Julien Danjou <julien@danjou.info>
2906
2907 * term.c (Fsuspend_tty, Fresume_tty):
2908 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2909 * window.c (temp_output_buffer_show):
2910 * insdel.c (signal_before_change):
2911 * frame.c (Fhandle_switch_frame):
2912 * fileio.c (Fdo_auto_save):
2913 * emacs.c (Fkill_emacs):
2914 * editfns.c (save_excursion_restore):
2915 * cmds.c (internal_self_insert):
2916 * callint.c (Fcall_interactively):
2917 * buffer.c (Fkill_all_local_variables):
2918 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2919 Use Frun_hooks.
2920 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2921 unconditionnaly since it does the check itself.
2922
29232011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2924
2925 Fix more problems found by GCC 4.5.2's static checks.
2926
2927 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2928 the first time through the loop, since we know p0 < p1 then.
2929 This also avoids a gcc -Wstrict-overflow warning.
2930
2931 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2932 leading to a memory leak, possible in functions like
2933 load_charset_map_from_file that can allocate an unbounded number
2934 of objects (Bug#8318).
2935
2936 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2937 that could (at least in theory) be that large.
2938
2939 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2940 This is less likely to overflow, and avoids undefined behavior if
2941 overflow does occur. All callers changed. Use strtoul to scan
2942 for the unsigned long integer.
2943 (pint2hrstr): Simplify and tune code slightly.
2944 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2945
2946 * scroll.c (do_scrolling): Work around GCC bug 48228.
2947 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2948
2949 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2950 This also avoids a warning with gcc -Wstrict-overflow.
2951 (validate_x_resource_name): Simplify count usage.
2952 This also avoids a warning with gcc -Wstrict-overflow.
2953
2954 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2955 fail (Bug#8306).
2956
2957 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2958
2959 * process.c (Fmake_network_process): Use socklen_t, not int,
2960 where POSIX says socklen_t is required in portable programs.
2961 This fixes a porting bug on hosts like 64-bit HP-UX, where
2962 socklen_t is wider than int (Bug#8277).
2963 (Fmake_network_process, server_accept_connection):
2964 (wait_reading_process_output, read_process_output):
2965 Likewise.
2966
2967 * process.c: Rename or move locals to avoid shadowing.
2968 (list_processes_1, Fmake_network_process):
2969 (read_process_output_error_handler, exec_sentinel_error_handler):
2970 Rename or move locals.
2971 (Fmake_network_process): Define label "retry_connect" only if needed.
2972 (Fnetwork_interface_info): Fix pointer signedness.
2973 (process_send_signal): Add cast to avoid pointer signedness problem.
2974 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2975 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2976
2977 Make tparam.h and terminfo.c consistent.
2978 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2979 Include tparam.h instead, since it declares them.
2980 * cm.h (PC): Remove extern decl; tparam.h now does this.
2981 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2982 * terminfo.c: Include tparam.h, to check interfaces.
2983 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2984 (tparam): Adjust signature to match interface in tparam.h;
2985 this removes some undefined behavior. Check that outstring and len
2986 are zero, which they always are with Emacs.
2987 * tparam.h (PC, BC, UP): New extern decls.
2988
2989 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2990 (xftfont_open): Rename locals to avoid shadowing.
2991
2992 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2993 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2994 (OTF_TAG_SYM): Omit macro if not needed.
2995 (ftfont_list): Remove unused local.
2996 (get_adstyle_property, ftfont_pattern_entity):
2997 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2998 Rename locals to avoid shadowing.
2999
3000 * xfont.c (xfont_list_family): Mark var as initialized.
3001
3002 * xml.c (make_dom): Now static.
3003
3004 * composite.c (composition_compute_stop_pos): Rename local to
3005 avoid shadowing.
3006 (composition_reseat_it): Remove unused locals.
3007 (find_automatic_composition, composition_adjust_point): Likewise.
3008 (composition_update_it): Mark var as initialized.
3009 (find_automatic_composition): Mark vars as initialized,
3010 with a FIXME (Bug#8290).
3011
3012 character.h: Rename locals to avoid shadowing.
3013 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3014 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3015 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3016 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3017 to avoid shadowing.
3018
3019 * textprop.c (property_change_between_p): Remove; unused.
3020
3021 * intervals.c (interval_start_pos): Now static.
3022
3023 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3024
3025 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3026 Rename locals to avoid shadowing.
3027
3028 * sound.c (wav_play, au_play, Fplay_sound_internal):
3029 Fix pointer signedness.
3030 (alsa_choose_format): Remove unused local var.
3031 (wav_play): Initialize a variable to 0, to prevent undefined
3032 behavior (Bug#8278).
3033
3034 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3035
3036 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3037
3038 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3039 clobbering (Bug#8298).
3040 * sysdep.c (sys_subshell): Likewise.
3041 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3042
3043 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3044 This should get cleaned up, so that child_setup has the
3045 same signature on all platforms.
3046
3047 * callproc.c (call_process_cleanup): Now static.
3048 (relocate_fd): Rename locals to avoid shadowing.
3049
30502011-03-22 Chong Yidong <cyd@stupidchicken.com>
3051
3052 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3053 not to be necessary, and produces flickering.
3054
30552011-03-20 Glenn Morris <rgm@gnu.org>
3056
3057 * config.in: Remove file.
3058
30592011-03-20 Juanma Barranquero <lekktu@gmail.com>
3060
3061 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3062 are now in src/globals.h.
3063 (syms_of_minibuf): Remove spurious & from previous change.
3064
30652011-03-20 Leo <sdl.web@gmail.com>
3066
3067 * minibuf.c (completing-read-function): New variable.
3068 (completing-read-default): Rename from completing-read.
3069 (completing-read): Call completing-read-function.
3070
30712011-03-19 Juanma Barranquero <lekktu@gmail.com>
3072
3073 * xfaces.c (Fx_load_color_file):
3074 Read color file from absolute filename (bug#8250).
3075
30762011-03-19 Juanma Barranquero <lekktu@gmail.com>
3077
3078 * makefile.w32-in: Update dependencies.
3079
30802011-03-17 Eli Zaretskii <eliz@gnu.org>
3081
3082 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3083
30842011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3085
3086 Fix more problems found by GCC 4.5.2's static checks.
3087
3088 * process.c (make_serial_process_unwind, send_process_trap):
3089 (sigchld_handler): Now static.
3090
3091 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3092 That way, the code declares only the vars that it needs.
3093 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3094 * s/cygwin.h (PTY_ITERATION): Likewise.
3095 * s/darwin.h (PTY_ITERATION): Likewise.
3096 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3097
3098 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3099 * process.c (allocate_pty): Don't declare stb unless it's needed.
3100
3101 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3102 (CONSTANTLIM): Remove; unused.
3103 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3104 Define only if needed.
3105
3106 * unexelf.c (unexec): Name an expression,
3107 to avoid gcc -Wbad-function-cast warning.
3108 Use a different way to cause a compilation error if anyone uses
3109 n rather than nn, a way that does not involve shadowing.
3110 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3111
3112 * deps.mk (unexalpha.o): Remove; unused.
3113
3114 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3115 * unexec.h: New file.
3116 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3117 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3118 Depend on unexec.h.
3119 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3120 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3121 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3122 Change as necessary to match prototype in unexec.h.
3123
3124 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3125 shadowing.
3126 (back_comment, skip_chars): Mark vars as initialized.
3127
3128 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3129 Rename locals to avoid shadowing.
3130
3131 * lread.c (read1): Rewrite so as not to use empty "else".
3132 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3133
3134 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3135
3136 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3137 warning when compiling print.c.
3138
3139 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3140 instead of using an uninitialized var.
3141 (font_sort_entities): Mark var as initialized.
3142
3143 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3144
3145 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3146 pointers to constants.
3147 (font_parse_fcname): Remove unused vars.
3148 (font_delete_unmatched): Now static.
3149 (font_get_spec): Remove; unused.
3150 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3151 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3152 Rename or move locals to avoid shadowing.
3153
3154 * fns.c (require_nesting_list, require_unwind): Now static.
3155 (Ffillarray): Rename locals to avoid shadowing.
3156
3157 * floatfns.c (domain_error2): Define only if needed.
3158 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3159
3160 * alloc.c (mark_backtrace): Move decl from here ...
3161 * lisp.h: ... to here, so that it can be checked.
3162
3163 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3164 (Fdefvar): Rewrite so as not to use empty "else".
3165 (lisp_indirect_variable): Name an expression,
3166 to avoid gcc -Wbad-function-cast warning.
3167 (Fdefvar): Rename locals to avoid shadowing.
3168
3169 * callint.c (quotify_arg, quotify_args): Now static.
3170 (Fcall_interactively): Rename locals to avoid shadowing.
3171 Use const pointer when appropriate.
3172
3173 * lisp.h (get_system_name, get_operating_system_release):
3174 Move decls here, to check interfaces.
3175 * process.c (get_operating_system_release): Move decl to lisp.h.
3176 * xrdb.c (get_system_name): Likewise.
3177 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3178 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3179 some of which prompt warnings from gcc -Wbad-function-cast.
3180 (Fformat_time_string, Fencode_time, Finsert_char):
3181 (Ftranslate_region_internal, Fformat):
3182 Rename or remove local vars to avoid shadowing.
3183 (Ftranslate_region_internal): Mark var as initialized.
3184
3185 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3186 avoid shadowing.
3187
3188 * lisp.h (eassert): Check that the argument compiles, even if
3189 ENABLE_CHECKING is not defined.
3190
3191 * data.c (Findirect_variable): Name an expression, to avoid
3192 gcc -Wbad-function-cast warning.
3193 (default_value, arithcompare, arith_driver, arith_error): Now static.
3194 (store_symval_forwarding): Rename local to avoid shadowing.
3195 (Fmake_variable_buffer_local, Fmake_local_variable):
3196 Mark variables as initialized.
3197 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3198
3199 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3200 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3201 Rename locals to avoid shadowing.
3202 (mark_stack): Move local variables into the #ifdef region where
3203 they're used.
3204 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3205 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3206 needed otherwise.
3207 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3208 (GC_STRING_CHARS): Remove; not used.
3209 (Fmemory_limit): Cast sbrk's returned value to char *.
3210
3211 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3212 avoids undefined behavior in theory.
3213
3214 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3215
3216 Use functions, not macros, for up- and down-casing (Bug#8254).
3217 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3218 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3219 to use the following functions instead of these macros.
3220 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3221 EMACS_INT, since callers assume the returned value fits in int.
3222 (upcase1): Likewise, for UPCASE_TABLE.
3223 (uppercasep, lowercasep, upcase): New static inline functions.
3224 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3225 the race-condition problem in the old DOWNCASE.
3226
3227 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3228 Rename locals to avoid shadowing.
3229 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3230 (regex_compile, re_search_2, re_match_2_internal):
3231 Remove unused local vars.
3232 (FREE_VAR): Rewrite so as not to use empty "else",
3233 which gcc can warn about.
3234 (regex_compile, re_match_2_internal): Mark locals as initialized.
3235 (RETALLOC_IF): Define only if needed.
3236 (WORDCHAR_P): Likewise. This one is never needed, but is used
3237 only in a comment talking about a compiler bug, so put inside
3238 the #if 0 of that comment.
3239 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3240 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3241 Remove; unused.
3242
3243 * search.c (boyer_moore): Rename locals to avoid shadowing.
3244 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3245 (PREV_CHAR_BOUNDARY): Likewise.
3246
3247 * search.c (simple_search): Remove unused var.
3248
3249 * dired.c (compile_pattern): Move decl from here ...
3250 * lisp.h: ... to here, so that it can be checked.
3251 (struct re_registers): New forward decl.
3252
3253 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3254
3255 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3256 All uses changed.
3257 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3258 Rename locals to avoid shadowing.
3259 (Fvertical_motion): Mark locals as initialized.
3260
3261 * casefiddle.c (casify_object, casify_region): Now static.
3262 (casify_region): Mark local as initialized.
3263
3264 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3265
3266 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3267 New macros, so that the caller can use some names other than
3268 gcpro1, gcpro2, etc.
3269 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3270 of the new macros.
3271 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3272 argument, for consistency with GCPRO2_VAR, etc: it is now the
3273 prefix of the variable, not the variable itself. All uses
3274 changed.
3275 * dired.c (directory_files_internal, file_name_completion):
3276 Rename locals to avoid shadowing.
3277
3278 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3279 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3280 dired.c's scmp function, had undefined behavior.
3281 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3282 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3283 * buffer.h: ... to here, because these macros use current_buffer,
3284 and the new implementation with inline functions needs to have
3285 current_buffer in scope now, rather than later when the macros
3286 are used.
3287 (downcase, upcase1): New static inline functions.
3288 (DOWNCASE, UPCASE1): Reimplement using these functions.
3289 This avoids undefined behavior in expressions like
3290 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3291 from race conditions in accessing the global variables
3292 case_temp1 and case_temp2.
3293 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3294 * lisp.h (case_temp1, case_temp2): Remove their decls.
3295 * character.h (ASCII_CHAR_P): Move from here ...
3296 * lisp.h: ... to here, so that the inline functions mentioned
3297 above can use them.
3298
3299 * dired.c (directory_files_internal_unwind): Now static.
3300
3301 * fileio.c (file_name_as_directory, directory_file_name):
3302 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3303 Now static.
3304 (file_name_as_directory): Use const pointers when appropriate.
3305 (Fexpand_file_name): Likewise. In particular, newdir might
3306 point at constant storage, so make it a const pointer.
3307 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3308 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3309 signedness issues.
3310 (Fset_file_times, Finsert_file_contents, auto_save_error):
3311 Rename locals to avoid shadowing.
3312
3313 * minibuf.c (choose_minibuf_frame_1): Now static.
3314 (Ftry_completion, Fall_completions): Rename or remove locals
3315 to avoid shadowing.
3316
3317 * marker.c (bytepos_to_charpos): Remove; unused.
3318
3319 * lisp.h (verify_bytepos, count_markers): New decls,
3320 so that gcc does not warn that these functions aren't declared.
3321
3322 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3323 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3324 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3325 (copy_text): Remove unused local var.
3326
3327 * filelock.c (within_one_second): Now static.
3328 (lock_file_1): Rename local to avoid shadowing.
3329
3330 * buffer.c (fix_overlays_before): Mark locals as initialized.
3331 (fix_start_end_in_overlays): Likewise. This function should be
3332 simplified by using pointers-to-pointers, but that's a different
3333 matter.
3334 (switch_to_buffer_1): Now static.
3335 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3336 (report_overlay_modification): Rename locals to avoid shadowing.
3337
3338 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3339 Fix pointer signedness issue.
3340 (sys_subshell): Mark local as volatile if checking for lint,
3341 to suppress a gcc -Wclobbered warning that does not seem to be right.
3342 (MAXPATHLEN): Define only if needed.
3343
3344 * process.c (serial_open, serial_configure): Move decls from here ...
3345 * systty.h: ... to here, so that they can be checked.
3346
3347 * fns.c (get_random, seed_random): Move extern decls from here ...
3348 * lisp.h: ... to here, so that they can be checked.
3349
3350 * sysdep.c (reset_io): Now static.
3351 (wait_for_termination_signal): Remove; unused.
3352
3353 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3354 (copy_keymap_item, append_key, push_text_char_description):
3355 Now static.
3356 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3357 (DENSE_TABLE_SIZE): Remove; unused.
3358 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3359 (describe_map_tree):
3360 Rename locals to avoid shadowing.
3361
3362 * keyboard.c: Declare functions static if they are not used elsewhere.
3363 (echo_char, echo_dash, cmd_error, top_level_2):
3364 (poll_for_input, handle_async_input): Now static.
3365 (read_char, kbd_buffer_get_event, make_lispy_position):
3366 (make_lispy_event, make_lispy_movement, apply_modifiers):
3367 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3368 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3369 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3370 (read_key_sequence, read_char): Mark locals as initialized.
3371 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3372
3373 * keyboard.h (make_ctrl_char): New decl.
3374 (mark_kboards): Move decl here ...
3375 * alloc.c (mark_kboards): ... from here.
3376
3377 * lisp.h (force_auto_save_soon): New decl.
3378
3379 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3380 (DEFINE_DUMMY_FUNCTION): New macro.
3381 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3382 Use it.
3383 (main): Add casts to avoid warnings
3384 if GCC considers string literals to be constants.
3385
3386 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3387
3388 * dbusbind.c: Pointer signedness fixes.
3389 (xd_signature, xd_append_arg, xd_initialize):
3390 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3391 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3392 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3393 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3394
3395 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3396 if GCC considers string literals to be constants.
3397 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3398
33992011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3400
3401 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3402 (print_preprocess, print_object): New macro to fix last change.
3403
3404 * print.c (print_preprocess): Don't forget font objects.
3405
34062011-03-16 Juanma Barranquero <lekktu@gmail.com>
3407
3408 * emacs.c (USAGE3): Doc fixes.
3409
34102011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3411
3412 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3413 structure.
3414
34152011-03-14 Juanma Barranquero <lekktu@gmail.com>
3416
3417 * lisp.h (VWindow_system, Qfile_name_history):
3418 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3419 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3420 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3421
3422 * w32select.c: Don't #include "keyboard.h".
3423 (run_protected): Add extern declaration for waiting_for_input.
3424
3425 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3426 * w32console.c (detect_input_pending, read_input_pending)
3427 (encode_terminal_code):
3428 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3429 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3430 (w32_system_caret_y, Qfile_name_history):
3431 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3432 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3433 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3434 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3435 * w32proc.c (Qlocal, report_file_error):
3436 * w32term.c (Vwindow_system, updating_frame):
3437 * w32uniscribe.c (initialized, uniscribe_font_driver):
3438 Remove unneeded extern declarations.
3439
34402011-03-14 Chong Yidong <cyd@stupidchicken.com>
3441
3442 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3443
34442011-03-13 Chong Yidong <cyd@stupidchicken.com>
3445
3446 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3447 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3448 These macros can no longer be used for assignment.
3449
3450 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3451 Assign struct members directly, instead of using BUF_BEGV etc.
3452 (record_buffer_markers, fetch_buffer_markers): New functions for
3453 recording and fetching special buffer markers.
3454 (set_buffer_internal_1, set_buffer_temp): Use them.
3455
3456 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3457
3458 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3459
3460 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3461 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3462
3463 * xdisp.c (hscroll_window_tree):
3464 (reconsider_clip_changes): Use PT instead of BUF_PT.
3465
34662011-03-13 Eli Zaretskii <eliz@gnu.org>
3467
3468 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3469 $(EMACS_ROOT)/lib/intprops.h.
3470
34712011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3472
3473 Fix more problems found by GCC 4.5.2's static checks.
3474
3475 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3476 to unsigned char * to avoid compiler diagnostic.
3477 (xg_free_frame_widgets): Make it clear that a local variable is
3478 needed only if USE_GTK_TOOLTIP.
3479 (gdk_window_get_screen): Make it clear that this macro is needed
3480 only if USE_GTK_TOOLTIP.
3481 (int_gtk_range_get_value): New function, which avoids a diagnostic
3482 from gcc -Wbad-function-cast.
3483 (xg_set_toolkit_scroll_bar_thumb): Use it.
3484 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3485 diagnostic from gcc -Wbad-function-cast.
3486 (get_utf8_string, xg_get_file_with_chooser):
3487 Rename locals to avoid shadowing.
3488 (create_dialog): Move locals to avoid shadowing.
3489
3490 * xgselect.c (xg_select): Remove unused var.
3491
3492 * image.c (four_corners_best): Mark locals as initialized.
3493 (gif_load): Initialize transparent_p to zero (Bug#8238).
3494 Mark another local as initialized.
3495 (my_png_error, my_error_exit): Mark with NO_RETURN.
3496
3497 * image.c (clear_image_cache): Now static.
3498 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3499 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3500 (x_edge_detection): Remove unnecessary cast that
3501 gcc -Wbad-function-cast diagnoses.
3502 (gif_load): Fix pointer signedness.
3503 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3504 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3505
35062011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3507
3508 Improve quality of tests for time stamp overflow.
3509 For example, without this patch (encode-time 0 0 0 1 1
3510 1152921504606846976) returns the obviously-bogus value (-948597
3511 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3512 reports time overflow. See
3513 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3514 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3515 * editfns.c: Include limits.h and intprops.h.
3516 (TIME_T_MIN, TIME_T_MAX): New macros.
3517 (time_overflow): Move earlier, to before first use.
3518 (hi_time, lo_time): New functions, for an accurate test for
3519 out-of-range times.
3520 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3521 (Fget_internal_run_time): Don't assume time_t fits in int.
3522 (make_time): Use list2 instead of Fcons twice.
3523 (Fdecode_time): More accurate test for out-of-range times.
3524 (check_tm_member): New function.
3525 (Fencode_time): Use it, to test for out-of-range times.
3526 (lisp_time_argument): Don't rely on undefined left-shift and
3527 right-shift behavior when checking for time stamp overflow.
3528
3529 * editfns.c (time_overflow): New function, refactoring common code.
3530 (Fformat_time_string, Fdecode_time, Fencode_time):
3531 (Fcurrent_time_string): Use it.
3532
3533 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3534 * dired.c (make_time): Move to ...
3535 * editfns.c (make_time): ... here.
3536 * systime.h: Note the move.
3537
35382011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3539
3540 * fringe.c (update_window_fringes): Remove unused variables.
3541
3542 * unexmacosx.c (copy_data_segment): Also copy __got section.
3543 (Bug#8223)
3544
35452011-03-12 Eli Zaretskii <eliz@gnu.org>
3546
3547 * termcap.c [MSDOS]: Include "msdos.h".
3548 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3549 Constify `char *' arguments and their references according to
3550 prototypes in tparam.h.
3551
3552 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3553
3554 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3555 Adapt all references accordingly.
3556
3557 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3558
35592011-03-11 Tom Tromey <tromey@redhat.com>
3560
3561 * buffer.c (syms_of_buffer): Remove obsolete comment.
3562
35632011-03-11 Eli Zaretskii <eliz@gnu.org>
3564
3565 * termhooks.h (encode_terminal_code): Declare prototype.
3566
3567 * msdos.c (encode_terminal_code): Don't declare prototype.
3568
3569 * term.c (encode_terminal_code): Now external again, used by
3570 w32console.c and msdos.c.
3571
3572 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3573 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3574
35752011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3576
3577 Fix some minor problems found by GCC 4.5.2's static checks.
3578
3579 * fringe.c (update_window_fringes): Mark locals as initialized
3580 (Bug#8227).
3581 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3582
3583 * alloc.c (mark_fringe_data): Move decl from here ...
3584 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3585 to check its interface.
3586 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3587
3588 * fontset.c (free_realized_fontset): Now static.
3589 (Fset_fontset_font): Rename local to avoid shadowing.
3590 (fontset_font): Mark local as initialized.
3591 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3592
3593 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3594
3595 * xselect.c (x_disown_buffer_selections): Remove; not used.
3596 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3597 (x_own_selection, Fx_disown_selection_internal): Rename locals
3598 to avoid shadowing.
3599 (x_handle_dnd_message): Remove local to avoid shadowing.
3600
3601 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3602 so that the caller can use some name other than gcpro1.
3603 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3604 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3605 (Fx_backspace_delete_keys_p):
3606 Use them to avoid shadowing, and rename vars to avoid shadowing.
3607 (x_decode_color, x_set_name, x_window): Now static.
3608 (Fx_create_frame): Add braces to silence GCC warning.
3609 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3610 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3611 Remove unused locals.
3612 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3613 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3614 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3615 macros.
3616
3617 * xterm.h (x_mouse_leave): New decl.
3618
3619 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3620 Remove unused functions.
3621 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3622 (x_calc_absolute_position): Now static.
3623 (XTread_socket): Don't define label "out" unless it's used.
3624 Don't declare local "event" unless it's used.
3625 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3626 unless they are used.
3627 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3628 (x_fatal_error_signal): Remove; not used.
3629 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3630 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3631 (x_error_catcher, x_connection_closed, x_error_handler):
3632 (x_error_quitter, xembed_send_message, x_iconify_frame):
3633 (my_log_handler): Rename locals to avoid shadowing.
3634 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3635 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3636
3637 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3638 Rename or move locals to avoid shadowing.
3639 (tty_defined_color, merge_face_heights): Now static.
3640 (free_realized_faces_for_fontset): Remove; not used.
3641 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3642 does not deduce is never used uninitialized.
3643 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3644 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3645
3646 * terminal.c (store_terminal_param): Now static.
3647
3648 * xmenu.c (menu_highlight_callback): Now static.
3649 (set_frame_menubar): Remove unused local.
3650 (xmenu_show): Rename parameter to avoid shadowing.
3651 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3652 since they might point to immutable storage.
3653 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3654 since it's unused otherwise.
3655
3656 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3657 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3658 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3659 avoids a gcc -Wuninitialized diagnostic.
3660 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3661 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3662 does not deduce are never used uninitialized.
3663
3664 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3665
3666 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3667 * window.c (window_loop, size_window):
3668 (run_window_configuration_change_hook, enlarge_window): Likewise.
3669
3670 * window.c (display_buffer): Now static.
3671 (size_window): Mark variables that gcc -Wuninitialized
3672 does not deduce are never used uninitialized.
3673 * window.h (check_all_windows): New decl, to forestall
3674 gcc -Wmissing-prototypes diagnostic.
3675 * dispextern.h (bidi_dump_cached_states): Likewise.
3676
3677 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3678 shadowing.
3679 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3680 Include <limits.h>.
3681 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3682 and to avoid gcc -Wuninitialized warning.
3683 (load_charset_map): Mark variables that gcc -Wuninitialized
3684 does not deduce are never used uninitialized.
3685 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3686
3687 * coding.c (coding_set_source, coding_set_destination):
3688 Use "else { /* comment */ }" rather than "else /* comment */;"
3689 for clarity, and to avoid gcc -Wempty-body warning.
3690 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3691 a block, when the outer 'i' will do.
3692 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3693 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3694 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3695 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3696 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3697 Rename locals to avoid shadowing.
3698 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3699 * coding.c (emacs_mule_char, encode_invocation_designation):
3700 Now static, since they're not used elsewhere.
3701 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3702 (decode_coding_object, encode_coding_object, detect_coding_system):
3703 (decode_coding_emacs_mule): Mark variables that gcc
3704 -Wuninitialized does not deduce are never used uninitialized.
3705 (detect_coding_iso_2022): Initialize a local variable that might
3706 be used uninitialized. Leave a FIXME because it's not clear that
3707 this initialization is needed. (Bug#8211)
3708 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3709 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3710 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3711 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3712 Remove unused macros.
3713
3714 * category.c (hash_get_category_set): Remove unused local var.
3715 (copy_category_table): Now static, since it's not used elsewhere.
3716 * character.c (string_count_byte8): Likewise.
3717
3718 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3719 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3720
3721 * chartab.c (copy_sub_char_table): Now static, since it's not used
3722 elsewhere.
3723 (sub_char_table_ref_and_range, char_table_ref_and_range):
3724 Rename locals to avoid shadowing.
3725 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3726
3727 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3728 (BIDI_BOB): Remove unused macro.
3729
3730 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3731 deduce are never used uninitialized.
3732 * term.c (encode_terminal_code): Likewise.
3733
3734 * term.c (encode_terminal_code): Now static. Remove unused local.
3735
3736 * tparam.h: New file.
3737 * term.c, tparam.h: Include it.
3738 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3739 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3740 Move these decls to tparam.h, and make them agree with what
3741 is actually in tparam.c. The previous trick of using incompatible
3742 decls in different modules does not conform to the C standard.
3743 All callers of tparam changed to use tparam's actual API.
3744 * tparam.c (tparam1, tparam, tgoto):
3745 Use const pointers where appropriate.
3746
3747 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3748 * cm.h (struct cm): Likewise.
3749 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3750 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3751 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3752 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3753 (turn_on_face, init_tty): Likewise.
3754 * termchar.h (struct tty_display_info): Likewise.
3755
3756 * term.c (term_mouse_position): Rename local to avoid shadowing.
3757
3758 * alloc.c (mark_ttys): Move decl from here ...
3759 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3760
37612011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3762
3763 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3764
37652011-03-09 Juanma Barranquero <lekktu@gmail.com>
3766
3767 * search.c (compile_pattern_1): Remove argument regp, unused since
3768 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3769 (compile_pattern): Don't pass it.
3770
37712011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3772
3773 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3774 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3775 for ! HAVE_GTK3.
3776 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3777
3778 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3779
3780 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3781 gdk_window_get_screen, gdk_window_get_geometry,
3782 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3783 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3784 (xg_get_pixbuf_from_pixmap): New function.
3785 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3786 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3787 Call xg_get_pixbuf_from_pixmap instead of
3788 gdk_pixbuf_get_from_drawable.
3789 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3790 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3791 (xg_check_special_colors): Use GtkStyleContext and its functions
3792 for HAVE_GTK3.
3793 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3794 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3795 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3796 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3797 Call gtk_widget_get_preferred_size.
3798 (xg_frame_resized): gdk_window_get_geometry only takes 5
3799 parameters.
3800 (xg_win_to_widget, xg_event_is_for_menubar):
3801 Call gdk_x11_window_lookup_for_display.
3802 (xg_set_widget_bg): New function.
3803 (delete_cb): New function.
3804 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3805 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3806 (xg_set_background_color): Call xg_set_widget_bg.
3807 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3808 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3809 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3810 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3811 if ! HAVE_GTK3.
3812 (update_frame_tool_bar): Call gtk_widget_hide.
3813 (xg_initialize): Use GDK_KEY_g.
3814
3815 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3816 if ! HAVE_GTK3
3817 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3818
3819 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3820 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3821 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3822
38232011-03-08 Juanma Barranquero <lekktu@gmail.com>
3824
3825 * w32xfns.c (select_palette): Check success of RealizePalette against
3826 GDI_ERROR, not zero.
3827
3828See ChangeLog.11 for earlier changes.
3829
3830;; Local Variables:
3831;; coding: utf-8
3832;; End:
3833
3834 Copyright (C) 2011 Free Software Foundation, Inc.
3835
3836 This file is part of GNU Emacs.
3837
3838 GNU Emacs is free software: you can redistribute it and/or modify
3839 it under the terms of the GNU General Public License as published by
3840 the Free Software Foundation, either version 3 of the License, or
3841 (at your option) any later version.
3842
3843 GNU Emacs is distributed in the hope that it will be useful,
3844 but WITHOUT ANY WARRANTY; without even the implied warranty of
3845 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3846 GNU General Public License for more details.
3847
3848 You should have received a copy of the GNU General Public License
3849 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.