* alloc.c (valid_pointer_p): Use pipe, not open.
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2
3 * alloc.c (valid_pointer_p): Use pipe, not open.
4 This fixes some permissions issues when debugging.
5
6 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7 If fchown fails to set both uid and gid, try to set just gid,
8 as that is sometimes allowed. Adjust the file's mode to eliminate
9 setuid or setgid bits that are inappropriate if fchown fails.
10
112011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
12
13 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
14 to compare Lisp_Objects.
15 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
16 global_gnutls_log_level, don't mistake it for a Lisp_Object.
17 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
18
192011-07-17 Andreas Schwab <schwab@linux-m68k.org>
20
21 * lread.c (read_integer): Unread even EOF character.
22 (read1): Likewise. Properly record start position of symbol.
23
24 * lread.c (read1): Read `#:' as empty uninterned symbol if no
25 symbol character follows.
26
272011-07-17 Paul Eggert <eggert@cs.ucla.edu>
28
29 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
30 This works around a problem with the previous change to Fcopy_file.
31 Recent glibc declares fchown with __attribute__((warn_unused_result)),
32 and without this change, GCC might complain about discarding
33 fchown's return value.
34
352011-07-16 Juanma Barranquero <lekktu@gmail.com>
36
37 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
38
392011-07-16 Paul Eggert <eggert@cs.ucla.edu>
40
41 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
42
432011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
44
45 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
46 it's used from the C level.
47
48 * process.c: Use the same condition for POLL_FOR_INPUT in both
49 keyboard.c and process.c (bug#1858).
50
512011-07-09 Lawrence Mitchell <wence@gmx.li>
52
53 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
54 (Fgnutls_boot): Use it.
55
562011-07-15 Andreas Schwab <schwab@linux-m68k.org>
57
58 * doc.c (Fsubstitute_command_keys): Revert last change.
59
602011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
61
62 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
63 quotes the next character, and doesn't affect other longer
64 sequences (bug#8935).
65
66 * lread.c (syms_of_lread): Clarify that is isn't only
67 `eval-buffer' and `eval-defun' that's affected by
68 `lexical-binding' (bug#8460).
69
702011-07-15 Eli Zaretskii <eliz@gnu.org>
71
72 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
73 bidi redisplay when a line includes both an image and is
74 truncated.
75
762011-07-14 Paul Eggert <eggert@cs.ucla.edu>
77
78 Fix minor problems found by static checking.
79 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
80 (elsz): Now a signed constant, not a size_t var. We prefer signed
81 types to unsigned, to avoid integer comparison confusion. Without
82 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
83 "cannot optimize loop, the loop counter may overflow", a symptom
84 of the confusion.
85 * indent.c (Fvertical_motion): Mark locals as initialized.
86 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
87
882011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
89
90 * search.c (Fre_search_backward): Mention `case-fold-search' in
91 all the re_search_* functions (bug#8138).
92
93 * keyboard.c (Fopen_dribble_file): Document when the file is
94 closed (bug#8056).
95
962011-07-14 Eli Zaretskii <eliz@gnu.org>
97
98 * bidi.c (bidi_dump_cached_states): Fix format of displaying
99 bidi_cache_idx.
100
101 Support bidi reordering of display and overlay strings.
102 * xdisp.c (compute_display_string_pos)
103 (compute_display_string_end): Accept additional argument STRING.
104 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
105 (reseat_to_string): Initialize bidi_it->string.s and
106 bidi_it->string.schars.
107 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
108 NULL (avoids a crash in bidi_paragraph_init). Initialize
109 itb.string.lstring.
110 (init_iterator): Call bidi_init_it only of a valid
111 buffer position was specified. Initialize paragraph_embedding to
112 L2R.
113 (reseat_to_string): Initialize the bidi iterator.
114 (display_string): If we need to ignore text properties of
115 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
116 original value of -1 will not work with bidi.)
117 (compute_display_string_pos): First arg is now struct
118 `text_pos *'; all callers changed. Support display properties on
119 Lisp strings.
120 (compute_display_string_end): Support display properties on Lisp
121 strings.
122 (init_iterator, reseat_1, reseat_to_string): Initialize the
123 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
124 when iterating on a string not from display properties).
125 (compute_display_string_pos, compute_display_string_end): Fix
126 calculation of the object to scan. Fixes an error when using
127 arrow keys.
128 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
129 base_level_stop; instead, set base_level_stop to BEGV. Fixes
130 crashes in vertical-motion.
131 (next_element_from_buffer): Improve commentary for when
132 the iterator is before prev_stop.
133 (init_iterator): Initialize bidi_p from the default value of
134 bidi-display-reordering, not from buffer-local value. Use the
135 buffer-local value only if initializing for buffer iteration.
136 (handle_invisible_prop): Support invisible properties on strings
137 that are being bidi-reordered.
138 (set_iterator_to_next): Support bidi reordering of C strings and
139 Lisp strings.
140 (next_element_from_string): Support bidi reordering of Lisp
141 strings.
142 (handle_stop_backwards): Support Lisp strings as well.
143 (display_string): Support display of R2L glyph rows. Use
144 IT_STRING_CHARPOS when displaying from a Lisp string.
145 (init_iterator): Don't initialize it->bidi_p for strings
146 here.
147 (reseat_to_string): Initialize it->bidi_p for strings here.
148 (next_element_from_string, next_element_from_c_string)
149 (next_element_from_buffer): Add xassert's for correspondence
150 between IT's object being iterated and it->bidi_it.string
151 structure.
152 (face_before_or_after_it_pos): Support bidi iteration.
153 (next_element_from_c_string): Handle the case of the first string
154 character that is not the first one in the visual order.
155 (get_visually_first_element): New function, refactored from common
156 parts of next_element_from_buffer, next_element_from_string, and
157 next_element_from_c_string.
158 (tool_bar_lines_needed, redisplay_tool_bar)
159 (display_menu_bar): Force left-to-right direction. Add a FIXME
160 comment for making that be controlled by a user option.
161 (push_it, pop_it): Save and restore the state of the
162 bidi iterator. Save and restore the bidi_p flag.
163 (pop_it): Iterate out of display property for string iteration as
164 well.
165 (iterate_out_of_display_property): Support iteration over strings.
166 (handle_single_display_spec): Set up it->bidi_it for iteration
167 over a display string, and call bidi_init_it.
168 (handle_single_display_spec, next_overlay_string)
169 (get_overlay_strings_1, push_display_prop): Set up the bidi
170 iterator for displaying display or overlay strings.
171 (forward_to_next_line_start): Don't use the shortcut if
172 bidi-iterating.
173 (back_to_previous_visible_line_start): If handle_display_prop
174 pushed the iterator stack, restore the internal state of the bidi
175 iterator by calling bidi_pop_it same number of times.
176 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
177 and we are bidi-iterating, don't decrement the iterator position;
178 instead, set the first_elt flag in the bidi iterator, to produce
179 the same effect.
180 (reseat_1): Remove redundant setting of string_from_display_prop_p.
181 (push_display_prop): xassert that we are iterating a buffer.
182 (push_it, pop_it): Save and restore paragraph_embedding member.
183 (handle_single_display_spec, next_overlay_string)
184 (get_overlay_strings_1, reseat_1, reseat_to_string)
185 (push_display_prop): Set up the `unibyte' member of bidi_it.string
186 correctly. Don't assume unibyte strings are not bidi-reordered.
187 (compute_display_string_pos)
188 (compute_display_string_end): Fix handling the case of C string.
189 (push_it, pop_it): Save and restore from_disp_prop_p.
190 (handle_single_display_spec, push_display_prop): Set the
191 from_disp_prop_p flag.
192 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
193 (pop_it): Call iterate_out_of_display_property only if we are
194 popping after iteration over a string that came from a display
195 property. Fix a typo in popping stretch info. Add an assertion
196 for verifying that the iterator position is in sync with the bidi
197 iterator.
198 (handle_single_display_spec, get_overlay_strings_1)
199 (push_display_prop): Fix initialization of paragraph direction for
200 string when that of the parent object is not yet determined.
201 (reseat_1): Call bidi_init_it to resync the bidi
202 iterator with IT's position. (Bug#7616)
203 (find_row_edges): If ROW->start.pos gives position
204 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
205 (handle_stop, back_to_previous_visible_line_start, reseat_1):
206 Reset the from_disp_prop_p flag.
207 (SAVE_IT, RESTORE_IT): New macros.
208 (pos_visible_p, face_before_or_after_it_pos)
209 (back_to_previous_visible_line_start)
210 (move_it_in_display_line_to, move_it_in_display_line)
211 (move_it_to, move_it_vertically_backward, move_it_by_lines)
212 (try_scrolling, redisplay_window, display_line): Use them when
213 saving a temporary copy of the iterator and restoring it back.
214 (back_to_previous_visible_line_start, reseat_1)
215 (init_iterator): Empty the bidi cache "stack".
216 (move_it_in_display_line_to): If iterator ended up at
217 EOL, but we never saw any buffer positions smaller than
218 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
219 motion in bidi-reordered lines.
220 (move_it_in_display_line_to): Record prev_method and prev_pos
221 immediately before the call to set_iterator_to_next. Fixes cursor
222 motion in bidi-reordered lines with stretch glyphs and strings
223 displayed in margins. (Bug#8133) (Bug#8867)
224 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
225 TO_CHARPOS.
226 (pos_visible_p): Support positions in bidi-reordered lines. Save
227 and restore bidi cache.
228
229 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
230 (bidi_paragraph_info): Delete unused struct.
231 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
232 (bidi_cache_start): New variable.
233 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
234 to zero.
235 (bidi_cache_fetch_state, bidi_cache_search)
236 (bidi_cache_find_level_change, bidi_cache_iterator_state)
237 (bidi_cache_find, bidi_peek_at_next_level)
238 (bidi_level_of_next_char, bidi_find_other_level_edge)
239 (bidi_move_to_visually_next): Compare cache index with
240 bidi_cache_start rather than with zero.
241 (bidi_fetch_char): Accept new argument STRING; all callers
242 changed. Support iteration over a string. Support strings with
243 display properties. Support unibyte strings. Fix the type of
244 `len' according to what STRING_CHAR_AND_LENGTH expects.
245 (bidi_paragraph_init, bidi_resolve_explicit_1)
246 (bidi_resolve_explicit, bidi_resolve_weak)
247 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
248 iteration over a string.
249 (bidi_set_sor_type, bidi_resolve_explicit_1)
250 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
251 can now be zero (for strings); special values 0 and -1 were
252 changed to -1 and -2, respectively.
253 (bidi_char_at_pos): New function.
254 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
255 Call it instead of FETCH_MULTIBYTE_CHAR.
256 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
257 initialized to valid values.
258 (bidi_init_it): Don't initialize charpos and bytepos with invalid
259 values.
260 (bidi_level_of_next_char): Allow the sentinel "position" to pass
261 the test for valid cached positions. Fix the logic for looking up
262 the sentinel state in the cache. GCPRO the Lisp string we are
263 iterating.
264 (bidi_push_it, bidi_pop_it): New functions.
265 (bidi_initialize): Initialize the bidi cache start stack pointer.
266 (bidi_cache_ensure_space): New function, refactored from part of
267 bidi_cache_iterator_state. Don't assume the required size is just
268 one BIDI_CACHE_CHUNK away.
269 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
270 (bidi_count_bytes, bidi_char_at_pos): New functions.
271 (bidi_cache_search): Don't assume bidi_cache_last_idx is
272 always valid if bidi_cache_idx is valid.
273 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
274 is valid if it's going to be used.
275 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
276 (bidi_cache_fetch_state, bidi_cache_search)
277 (bidi_cache_find_level_change, bidi_cache_ensure_space)
278 (bidi_cache_iterator_state, bidi_cache_find)
279 (bidi_find_other_level_edge, bidi_cache_start_stack): All
280 variables related to cache indices are now EMACS_INT.
281
282 * dispextern.h (struct bidi_string_data): New structure.
283 (struct bidi_it): New member `string'. Make flag members be 1-bit
284 fields, and put them last in the struct.
285 (compute_display_string_pos, compute_display_string_end): Update
286 prototypes.
287 (bidi_push_it, bidi_pop_it): Add prototypes.
288 (struct iterator_stack_entry): New members bidi_p,
289 paragraph_embedding, and from_disp_prop_p.
290 (struct it): Member bidi_p is now a bit field 1 bit wide.
291 (bidi_shelve_cache, bidi_unshelve_cache): Declare
292 prototypes.
293
294 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
295 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
296 and vector-like objects.
297
298 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
299 cache around display iteration.
300
301 * window.c (Fwindow_end, window_scroll_pixel_based)
302 (displayed_window_lines, Frecenter): Save and restore the bidi
303 cache around display iteration.
304
3052011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
306
307 * editfns.c (Fdelete_region): Clarify the use of the named
308 parameters (bug#6788).
309
3102011-07-14 Martin Rudalics <rudalics@gmx.at>
311
312 * indent.c (Fvertical_motion): Set and restore w->pointm when
313 saving and restoring the window's buffer (Bug#9006).
314
3152011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
316
317 * editfns.c (Fstring_to_char): Clarify just what is returned
318 (bug#6576). Text by Eli Zaretskii.
319
3202011-07-13 Juanma Barranquero <lekktu@gmail.com>
321
322 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
323
3242011-07-13 Eli Zaretskii <eliz@gnu.org>
325
326 * buffer.c (mmap_find): Fix a typo.
327
3282011-07-13 Johan Bockgård <bojohan@gnu.org>
329
330 Fix execution of x selection hooks.
331 * xselect.c (Qx_lost_selection_functions)
332 (Qx_sent_selection_functions): New vars.
333 (syms_of_xselect): DEFSYM them.
334 (x_handle_selection_request): Pass Qx_sent_selection_functions
335 rather than Vx_sent_selection_functions to Frun_hook_with_args.
336 (x_handle_selection_clear,x_clear_frame_selections):
337 Pass Qx_lost_selection_functions rather than
338 Vx_lost_selection_functions to Frun_hook_with_args.
339
3402011-07-13 Paul Eggert <eggert@cs.ucla.edu>
341
342 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
343 The old code sometimes used this field without initializing it.
344
345 * alloc.c (gc_sweep): Don't read past end of array.
346 In theory, the old code could also have corrupted Emacs internals,
347 though it'd be very unlikely.
348
3492011-07-12 Andreas Schwab <schwab@linux-m68k.org>
350
351 * character.c (Fcharacterp): Don't advertise optional ignored
352 argument. (Bug#4026)
353
3542011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
355
356 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
357 key" (bug#4257).
358
359 * window.c (Fset_window_start): Doc fix (bug#4199).
360 (Fset_window_hscroll): Ditto.
361
3622011-07-12 Paul Eggert <eggert@cs.ucla.edu>
363
364 Fix minor new problems caught by GCC 4.6.1.
365 * term.c (init_tty): Remove unused local.
366 * xsettings.c (store_monospaced_changed): Define this function only
367 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
368 not used otherwise.
369
3702011-07-12 Chong Yidong <cyd@stupidchicken.com>
371
372 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
373
3742011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
375
376 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
377 are the mini-buffer and the echo area (bug#3320).
378
379 * term.c (init_tty): Remove support for supdup, c10 and perq
380 terminals, which are no longer supported (bug#1482).
381
3822011-07-10 Johan Bockgård <bojohan@gnu.org>
383
384 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
385
3862011-07-10 Jan Djärv <jan.h.d@swipnet.se>
387
388 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
389 for non-popups (Bug#3642).
390
3912011-07-10 Andreas Schwab <schwab@linux-m68k.org>
392
393 * alloc.c (reset_malloc_hooks): Protoize.
394 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
395 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
396 * cm.c (losecursor): Likewise.
397 * data.c (fmod): Likewise.
398 * dispnew.c (swap_glyphs_in_rows): Likewise.
399 * emacs.c (memory_warning_signal): Likewise.
400 * floatfns.c (float_error): Likewise.
401 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
402 (otf_open, font_otf_capability, generate_otf_features)
403 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
404 Likewise.
405 * image.c (pbm_read_file): Likewise.
406 * indent.c (string_display_width): Likewise.
407 * intervals.c (check_for_interval, search_for_interval)
408 (inc_interval_count, count_intervals, root_interval)
409 (adjust_intervals_for_insertion, make_new_interval): Likewise.
410 * lread.c (defalias): Likewise.
411 * ralloc.c (r_alloc_check): Likewise.
412 * regex.c (set_image_of_range_1, set_image_of_range)
413 (regex_grow_registers): Likewise.
414 * sysdep.c (strerror): Likewise.
415 * termcap.c (valid_filename_p, tprint, main): Likewise.
416 * tparam.c (main): Likewise.
417 * unexhp9k800.c (run_time_remap, save_data_space)
418 (update_file_ptrs, read_header, write_header, calculate_checksum)
419 (copy_file, copy_rest, display_header): Likewise.
420 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
421 Likewise.
422 * xdisp.c (check_it): Likewise.
423 * xfaces.c (register_color, unregister_color, unregister_colors):
424 Likewise.
425 * xfns.c (print_fontset_result): Likewise.
426 * xrdb.c (member, fatal, main): Likewise.
427
4282011-07-10 Paul Eggert <eggert@cs.ucla.edu>
429
430 Fix minor problems found by static checking (Bug#9031).
431 * chartab.c (char_table_set_range, map_sub_char_table):
432 Remove unused locals.
433 (uniprop_table): Now static.
434 * composite.c (_work_char): Remove unused static var.
435
4362011-07-09 Juanma Barranquero <lekktu@gmail.com>
437
438 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
439
4402011-07-09 Jan Djärv <jan.h.d@swipnet.se>
441
442 * gtkutil.c (qttip_cb): Remove code without function.
443
4442011-07-09 Eli Zaretskii <eliz@gnu.org>
445
446 * w32.c (pthread_sigmask): New stub.
447
4482011-07-08 Paul Eggert <eggert@cs.ucla.edu>
449
450 Use pthread_sigmask, not sigprocmask (Bug#9010).
451 sigprocmask is portable only for single-threaded applications, and
452 Emacs can be multi-threaded when it uses GTK.
453 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
454 (LIBES): Use it.
455 * callproc.c (Fcall_process):
456 * process.c (create_process):
457 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
458 Use pthread_sigmask, not sigprocmask.
459
4602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
461
462 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
463 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
464 wrong (Bug#8591).
465
4662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
467
468 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
469 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
470 (xg_hide_tooltip): Fix comment.
471
472 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
473 in registerServicesMenuSendTypes.
474 (validRequestorForSendType): Don't check ns_return_types.
475
476 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
477 ns_return_type.
478
4792011-07-08 Jason Rumney <jasonr@gnu.org>
480
481 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
482 frame struct members of non-existent frames (Bug#6284).
483
4842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
485
486 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
487 variable firstTime not needed on OSX >= 10.6.
488 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
489 >= 10.5. Use setKnobProportion, setDoubleValue.
490
491 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
492 (MAC_OS_X_VERSION_10_5): Define if not defined.
493 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
494 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
495 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
496
497 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
498 cString and lossyCString on OSX >= 10.4
499
500 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
501 sizeToFit on OSX >= 10.2.
502
503 * nsimage.m (allocInitFromFile): Don't use deprecated method
504 bestRepresentationForDevice on OSX >= 10.6.
505
506 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
507 to avoid warning.
508
509 * emacs.c: Declare unexec_init_emacs_zone.
510
511 * nsgui.h: Fix compiler warning about gnulib redefining verify.
512
513 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
514
515 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
516 on svcsMenu (Bug#8842).
517
518 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
519 ns_return_types.
520 (Fns_list_services): Just return Qnil on 10.6, code not working there.
521
522 * nsterm.m (QUTF8_STRING): Declare.
523 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
524 (validRequestorForSendType): Return type is (id).
525 Change indexOfObjectIdenticalTo to indexOfObject.
526 Check if we have local selection before returning self (Bug#8842).
527 (writeSelectionToPasteboard): Put local selection into paste board
528 if we have a local selection (Bug#8842).
529 (syms_of_nsterm): DEFSYM QUTF8_STRING.
530
531 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
532 (ns_get_local_selection): Declare.
533
5342011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
535
536 * keymap.c (describe_map_tree): Don't insert a double newline at
537 the end of the buffer (bug#1169) and return whether we inserted
538 something.
539
540 * callint.c (Fcall_interactively): Change "reading args" to
541 "providing args" to try to clarify what it does (bug#1010).
542
5432011-07-07 Kenichi Handa <handa@m17n.org>
544
545 * composite.c (composition_compute_stop_pos): Ignore a static
546 composition starting before CHARPOS (Bug#8915).
547
548 * xdisp.c (handle_composition_prop): Likewise.
549
5502011-07-07 Eli Zaretskii <eliz@gnu.org>
551
552 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
553 (Bug#9015)
554
5552011-07-07 Kenichi Handa <handa@m17n.org>
556
557 * character.h (unicode_category_t): New enum type.
558
559 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
560 (Qchar_code_property_table): New variable.
561 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
562 (UNIPROP_COMPRESSED_FORM_P): New macros.
563 (char_table_ascii): Uncompress the compressed values.
564 (sub_char_table_ref): New arg is_uniprop. Callers changed.
565 Uncompress the compressed values.
566 (sub_char_table_ref_and_range): Likewise.
567 (char_table_ref_and_range): Uncompress the compressed values.
568 (sub_char_table_set): New arg is_uniprop. Callers changed.
569 Uncompress the compressed values.
570 (sub_char_table_set_range): Args changed. Callers changed.
571 (char_table_set_range): Adjuted for the above change.
572 (map_sub_char_table): Delete args default_val and parent. Add arg
573 top. Give decoded values to a Lisp function.
574 (map_char_table): Adjusted for the above change. Give decoded
575 values to a Lisp function. Gcpro more variables.
576 (uniprop_table_uncompress)
577 (uniprop_decode_value_run_length): New functions.
578 (uniprop_decoder, uniprop_decoder_count): New variables.
579 (uniprop_get_decoder, uniprop_encode_value_character)
580 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
581 New functions.
582 (uniprop_encoder, uniprop_encoder_count): New variables.
583 (uniprop_get_encoder, uniprop_table)
584 (Funicode_property_table_internal, Fget_unicode_property_internal)
585 (Fput_unicode_property_internal): New functions.
586 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
587 Sunicode_property_table_internal, Sget_unicode_property_internal,
588 and Sput_unicode_property_internal. Defvar_lisp
589 char-code-property-alist.
590
591 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
592 Vunicode_category_table.
593
594 * font.c (font_range): Adjusted for the change of
595 Vunicode_category_table.
596
5972011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
598
599 * m/iris4d.h: Remove file, move contents ...
600 * s/irix6-5.h: ... here.
601
6022011-07-06 Paul Eggert <eggert@cs.ucla.edu>
603
604 Remove unportable assumption about struct layout (Bug#8884).
605 * alloc.c (mark_buffer):
606 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
607 (clone_per_buffer_values): Don't assume that
608 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
609 This isn't true in general, and it's particularly not true
610 if Emacs is configured with --with-wide-int.
611 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
612 New macros, used in the buffer.c change.
613
6142011-07-05 Jan Djärv <jan.h.d@swipnet.se>
615
616 * xsettings.c: Use both GConf and GSettings if both are available.
617 (store_config_changed_event): Add comment.
618 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
619 (store_tool_bar_style_changed): New functions.
620 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
621 (struct xsettings): Move font inside HAVE_XFT.
622 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
623 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
624 Move inside HAVE_XFT.
625 (something_changed_gsettingsCB): Renamed from something_changedCB.
626 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
627 also.
628 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
629 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
630 (something_changed_gconfCB): Renamed from something_changedCB.
631 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
632 (parse_settings): Move check for font inside HAVE_XFT.
633 (read_settings, apply_xft_settings): Add comment.
634 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
635 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
636 call store_font_name_changed.
637 (xft_settings_event): Add comment.
638 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
639 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
640 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
641 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
642 (xsettings_initialize): Call init_gsettings last.
643 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
644 comment.
645
6462011-07-05 Paul Eggert <eggert@cs.ucla.edu>
647
648 Random fixes. E.g., (random) never returned negative values.
649 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
650 subseconds part to the entropy, as that's a bit more random.
651 Prefer signed to unsigned, since the signedness doesn't matter and
652 in general we prefer signed. When given a limit, use a
653 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
654 latter isn't right if USE_2_TAGS_FOR_INTS.
655 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
656 not 0..VALMASK. Don't discard "excess" bits that random () returns.
657
6582011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
659
660 * textprop.c (text_property_stickiness):
661 Obey Vtext_property_default_nonsticky.
662 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
663 * w32fns.c (syms_of_w32fns):
664 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
665
6662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
667
668 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
669 This is more efficient than Ffile_directory_p and avoids a minor race.
670
6712011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
672
673 * buffer.c (Foverlay_put): Say what the return value is
674 (bug#7835).
675
676 * fileio.c (barf_or_query_if_file_exists): Check first if the file
677 is a directory before asking whether to use the file name
678 (bug#7564).
679 (barf_or_query_if_file_exists): Make the "File is a directory"
680 error be more correct.
681
682 * fns.c (Frequire): Remove the mention of the .gz files, since
683 that's installation-specific, but keep the mention of
684 `get-load-suffixes'.
685
6862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
687
688 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
689 Report string overflow if the output is too long.
690
6912011-07-04 Juanma Barranquero <lekktu@gmail.com>
692
693 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
694 (syms_of_gnutls): Remove duplicate DEFSYM for
695 Qgnutls_bootprop_verify_hostname_error, an error for
696 Qgnutls_bootprop_verify_error (which is no longer used).
697
698 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
699 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
700 Also (re)move comments that are misplaced or no longer relevant.
701
7022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
703
704 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
705
7062011-07-03 Chong Yidong <cyd@stupidchicken.com>
707
708 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
709 and background color parameters if they have been changed.
710
7112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
712
713 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
714
7152011-07-03 Paul Eggert <eggert@cs.ucla.edu>
716
717 * xsettings.c (SYSTEM_FONT): Define only when used.
718 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
719
720 * keymap.c (access_keymap_1): Now static.
721
7222011-07-02 Chong Yidong <cyd@stupidchicken.com>
723
724 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
725 leave any prefix arg for the up event (Bug#1586).
726
7272011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
728
729 * lread.c (syms_of_lread): Mention single symbols defined by
730 `defvar' or `defconst' (bug#7154).
731
732 * fns.c (Frequire): Mention .el.gz files (bug#7314).
733 (Frequire): Mention get-load-suffixes.
734
7352011-07-02 Martin Rudalics <rudalics@gmx.at>
736
737 * window.h (window): Remove clone_number slot.
738 * window.c (Fwindow_clone_number, Fset_window_clone_number):
739 Remove.
740 (make_parent_window, make_window, saved_window)
741 (Fset_window_configuration, save_window_save): Don't deal with
742 clone numbers.
743 * buffer.c (Qclone_number): Remove declaration.
744 (sort_overlays, overlay_strings): Don't deal with clone numbers.
745
7462011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
747
748 Add multiple inheritance to keymaps.
749 * keymap.c (Fmake_composed_keymap): New function.
750 (Fset_keymap_parent): Simplify.
751 (fix_submap_inheritance): Remove.
752 (access_keymap_1): New function extracted from access_keymap to handle
753 embedded parents and handle lists of maps.
754 (access_keymap): Use it.
755 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
756 (Fcopy_keymap): Handle embedded parents.
757 (Fcommand_remapping, define_as_prefix): Simplify.
758 (Fkey_binding): Simplify.
759 (syms_of_keymap): Move minibuffer-local-completion-map,
760 minibuffer-local-filename-completion-map,
761 minibuffer-local-must-match-map, and
762 minibuffer-local-filename-must-match-map to Elisp.
763 (syms_of_keymap): Defsubr make-composed-keymap.
764 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
765 (parse_menu_item): Trivial simplification.
766
7672011-07-01 Glenn Morris <rgm@gnu.org>
768
769 * Makefile.in (SETTINGS_LIBS): Fix typo.
770
7712011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
772
773 * coding.c (Fencode_coding_string): Record the last coding system
774 used, as the function doc string says (bug#8738).
775
7762011-07-01 Jan Djärv <jan.h.d@swipnet.se>
777
778 * xsettings.c (store_monospaced_changed): Take new font as arg and
779 check for change against current_mono_font.
780 (EMACS_TYPE_SETTINGS): Remove this and related defines.
781 (emacs_settings_constructor, emacs_settings_get_property)
782 (emacs_settings_set_property, emacs_settings_class_init)
783 (emacs_settings_init, gsettings_obj): Remove.
784 (something_changedCB): New function for HAVE_GSETTINGS.
785 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
786 with value as argument.
787 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
788 g_settings_new (Bug#8967). Do not create gsettings_obj.
789 Remove calls to g_settings_bind. Connect something_changedCB to
790 "changed".
791
792 * xgselect.c: Add defined (HAVE_GSETTINGS).
793 (xgselect_initialize): Ditto.
794
795 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
796 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
797 xg_select.
798
7992011-07-01 Paul Eggert <eggert@cs.ucla.edu>
800
801 * eval.c (struct backtrace): Simplify and port the data structure.
802 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
803 signed bit field, as this assumption is not portable and it makes
804 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
805 "char debug_on_exit : 1" as this is not portable either; instead,
806 use the portable "unsigned int debug_on_exit : 1". Remove unused
807 member evalargs. Remove obsolete comments about cc bombing out.
808
8092011-06-30 Jan Djärv <jan.h.d@swipnet.se>
810
811 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
812 Let HAVE_GSETTINGS override HAVE_GCONF.
813 (store_monospaced_changed): New function.
814 (EMACS_SETTINGS): A new type derived from GObject to handle
815 GSettings notifications.
816 (emacs_settings_constructor, emacs_settings_get_property)
817 (emacs_settings_set_property, emacs_settings_class_init):
818 New functions.
819 (gsettings_client, gsettings_obj): New variables.
820 (GSETTINGS_SCHEMA): New define.
821 (something_changedCB): Call store_monospaced_changed.
822 (init_gsettings): New function.
823 (xsettings_initialize): Call init_gsettings.
824 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
825 to NULL.
826
827 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
828 GCONF_CFLAGS/LIBS.
829
8302011-06-29 Martin Rudalics <rudalics@gmx.at>
831
832 * window.c (resize_root_window, grow_mini_window)
833 (shrink_mini_window): Rename Qresize_root_window to
834 Qwindow_resize_root_window and Qresize_root_window_vertically to
835 Qwindow_resize_root_window_vertically.
836
8372011-06-28 Paul Eggert <eggert@cs.ucla.edu>
838
839 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
840
8412011-06-27 Juanma Barranquero <lekktu@gmail.com>
842
843 * makefile.w32-in: Redesign dependencies so they reflect more
844 clearly which files are directly included by each source file,
845 and not through other includes.
846
8472011-06-27 Martin Rudalics <rudalics@gmx.at>
848
849 * buffer.c (Qclone_number): Declare static and DEFSYM it.
850 (sort_overlays, overlay_strings): When an overlay's clone number
851 matches the window's clone number process the overlay even if
852 the overlay's window property doesn't match the current window.
853
854 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
855 (Fwindow_hchild): Rename to Fwindow_left_child.
856 (Fwindow_next): Rename to Fwindow_next_sibling.
857 (Fwindow_prev): Rename to Fwindow_prev_sibling.
858 (resize_window_check): Rename to window_resize_check.
859 (resize_window_apply): Rename to window_resize_apply.
860 (Fresize_window_apply): Rename to Fwindow_resize_apply.
861 (Fdelete_other_windows_internal, resize_frame_windows)
862 (Fsplit_window_internal, Fdelete_window_internal)
863 (grow_mini_window, shrink_mini_window)
864 (Fresize_mini_window_internal): Fix callers accordingly.
865
8662011-06-26 Jan Djärv <jan.h.d@swipnet.se>
867
868 * emacsgtkfixed.h: State that this is only used with Gtk+3.
869 (emacs_fixed_set_min_size): Remove.
870 (emacs_fixed_new): Take frame as argument.
871
872 * emacsgtkfixed.c: State that this is only used with Gtk+3.
873 (_EmacsFixedPrivate): Remove minwidth/height.
874 Add struct frame *f.
875 (emacs_fixed_init): Initialize priv->f.
876 (get_parent_class, emacs_fixed_set_min_size): Remove.
877 (emacs_fixed_new): Set priv->f to argument.
878 (emacs_fixed_get_preferred_width)
879 (emacs_fixed_get_preferred_height): Use min_width/height from
880 frames size_hint to set minimum and natural (Bug#8919).
881 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
882 and use min_width/height from frames size_hint to set
883 min_width/height (Bug#8919).
884
885 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
886 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
887 Fix indentation.
888
8892011-06-26 Eli Zaretskii <eliz@gnu.org>
890
891 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
892 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
893 called at ZV.
894
8952011-06-26 Chong Yidong <cyd@stupidchicken.com>
896
897 * process.c (wait_reading_process_output): Bypass select if
898 waiting for a cell while ignoring keyboard input, and input is
899 pending. Suggested by Jan Djärv (Bug#8869).
900
9012011-06-25 Paul Eggert <eggert@cs.ucla.edu>
902
903 Use gnulib's dup2 module instead of rolling our own.
904 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
905
9062011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
907
908 * dispnew.c (scrolling_window): Before scrolling, turn off a
909 mouse-highlight in the window being scrolled.
910
9112011-06-24 Juanma Barranquero <lekktu@gmail.com>
912
913 Move DEFSYM to lisp.h and use everywhere.
914
915 * character.h (DEFSYM): Move declaration...
916 * lisp.h (DEFSYM): ...here.
917
918 * gnutls.c:
919 * minibuf.c:
920 * w32menu.c:
921 * w32proc.c:
922 * w32select.c: Don't include character.h.
923
924 * alloc.c (syms_of_alloc):
925 * buffer.c (syms_of_buffer):
926 * bytecode.c (syms_of_bytecode):
927 * callint.c (syms_of_callint):
928 * casefiddle.c (syms_of_casefiddle):
929 * casetab.c (init_casetab_once):
930 * category.c (init_category_once, syms_of_category):
931 * ccl.c (syms_of_ccl):
932 * cmds.c (syms_of_cmds):
933 * composite.c (syms_of_composite):
934 * dbusbind.c (syms_of_dbusbind):
935 * dired.c (syms_of_dired):
936 * dispnew.c (syms_of_display):
937 * doc.c (syms_of_doc):
938 * editfns.c (syms_of_editfns):
939 * emacs.c (syms_of_emacs):
940 * eval.c (syms_of_eval):
941 * fileio.c (syms_of_fileio):
942 * fns.c (syms_of_fns):
943 * frame.c (syms_of_frame):
944 * fringe.c (syms_of_fringe):
945 * insdel.c (syms_of_insdel):
946 * keymap.c (syms_of_keymap):
947 * lread.c (init_obarray, syms_of_lread):
948 * macros.c (syms_of_macros):
949 * msdos.c (syms_of_msdos):
950 * print.c (syms_of_print):
951 * process.c (syms_of_process):
952 * search.c (syms_of_search):
953 * sound.c (syms_of_sound):
954 * syntax.c (init_syntax_once, syms_of_syntax):
955 * terminal.c (syms_of_terminal):
956 * textprop.c (syms_of_textprop):
957 * undo.c (syms_of_undo):
958 * w32.c (globals_of_w32):
959 * window.c (syms_of_window):
960 * xdisp.c (syms_of_xdisp):
961 * xfaces.c (syms_of_xfaces):
962 * xfns.c (syms_of_xfns):
963 * xmenu.c (syms_of_xmenu):
964 * xsettings.c (syms_of_xsettings):
965 * xterm.c (syms_of_xterm): Use DEFSYM.
966
9672011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
968
969 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
970
9712011-06-23 Paul Eggert <eggert@cs.ucla.edu>
972
973 Integer and buffer overflow fixes (Bug#8873).
974
975 * print.c (printchar, strout): Check for string overflow.
976 (PRINTPREPARE, printchar, strout):
977 Don't set size unless allocation succeeds.
978
979 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
980 for sizes. Check for string overflow more accurately.
981 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
982
983 * macros.c: Integer and buffer overflow fixes.
984 * keyboard.h (struct keyboard.kbd_macro_bufsize):
985 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
986 Use ptrdiff_t, not int, for sizes.
987 Don't increment bufsize until after realloc succeeds.
988 Check for size-calculation overflow.
989 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
990
991 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
992
993 * lread.c: Integer overflow fixes.
994 (read_integer): Radix is now EMACS_INT, not int,
995 to improve quality of diagnostics for out-of-range radices.
996 Calculate buffer size correctly for out-of-range radices.
997 (read1): Check for integer overflow in radices, and in
998 read-circle numbers.
999 (read_escape): Avoid int overflow.
1000 (Fload, openp, read_buffer_size, read1)
1001 (substitute_object_recurse, read_vector, read_list, map_obarray):
1002 Use ptrdiff_t, not int, for sizes.
1003 (read1): Use EMACS_INT, not int, for sizes.
1004 Check for size overflow.
1005
1006 * image.c (cache_image): Check for size arithmetic overflow.
1007
1008 * lread.c: Integer overflow issues.
1009 (saved_doc_string_size, saved_doc_string_length)
1010 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1011 Now ptrdiff_t, not int.
1012 (read1): Don't assume doc string length fits in int. Check for
1013 out-of-range doc string lengths.
1014 (read_list): Don't assume file position fits in int.
1015 (read_escape): Check for hex character overflow.
1016
10172011-06-22 Leo Liu <sdl.web@gmail.com>
1018
1019 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1020 Move to minibuffer.el.
1021
10222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1025 The following patches are for when GLYPH_DEBUG && !XASSERT.
1026 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1027 * dispnew.c (flush_stdout):
1028 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1029 Mark as externally visible.
1030 * dispnew.c (check_window_matrix_pointers): Now static.
1031 * dispnew.c (window_to_frame_vpos):
1032 * xfns.c (unwind_create_frame):
1033 * xterm.c (x_check_font): Remove unused local.
1034 * scroll.c (CHECK_BOUNDS):
1035 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1036 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1037 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1038 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1039 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1040 Now static.
1041 (debug_method_add): Use va_list and vsprintf rather than relying
1042 on undefined behavior with wrong number of arguments.
1043 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1044 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1045 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1046 since we're not interested in debugging glyphs with old libraries.
1047 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1048 GCC 4.6.0's static checking.
1049
10502011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 Integer overflow and signedness fixes (Bug#8873).
1053 A few related buffer overrun fixes, too.
1054
1055 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1056
1057 * dispextern.h (struct face.stipple):
1058 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1059 (x_bitmap_mask, x_allocate_bitmap_record)
1060 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1061 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1062 (x_create_bitmap_from_xpm_data):
1063 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1064 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1065 (.bitmaps_last):
1066 * xfaces.c (load_pixmap):
1067 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1068 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1069 (.bitmaps_last, struct x_output.icon_bitmap):
1070 Use ptrdiff_t, not int, for bitmap indexes.
1071 (x_allocate_bitmap_record): Check for size overflow.
1072 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1073
1074 Use ptrdiff_t, not int, for overlay counts.
1075 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1076 * editfns.c (overlays_around, get_pos_property):
1077 * textprop.c (get_char_property_and_overlay):
1078 * xdisp.c (next_overlay_change, note_mouse_highlight):
1079 * xfaces.c (face_at_buffer_position):
1080 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1081 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1082 (Fnext_overlay_change, Fprevious_overlay_change)
1083 (mouse_face_overlay_overlaps, Foverlays_in):
1084 Use ptrdiff_t, not int, for sizes.
1085 (overlays_at, overlays_in): Check for size-calculation overflow.
1086
1087 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1088
1089 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1090 (x_session_initialize): Do not assume string length fits in int.
1091
1092 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1093 This is unlikely, but can occur if DPI is outlandish.
1094
1095 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1096 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1097
1098 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1099 * xrdb.c (magic_file_p, search_magic_path):
1100 Omit last arg SUFFIX; it was always 0. All callers changed.
1101 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1102
1103 * xfont.c (xfont_match): Avoid need for strlen.
1104
1105 * xfns.c: Don't assume strlen fits in int.
1106 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1107
1108 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1109 not unsigned long, as we prefer signed integers. All callers changed.
1110 Detect integer overflow in repeat count.
1111 (message_dolog): Don't assume print length fits in 39 bytes.
1112 (display_mode_element): Don't assume strlen fits in int.
1113
1114 * termcap.c: Don't assume sizes fit in int and never overflow.
1115 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1116 (gobble_line): Check for size-calculation overflow.
1117
1118 * minibuf.c (Fread_buffer):
1119 * lread.c (intern, intern_c_string):
1120 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1121 Don't assume string length fits in int.
1122
1123 * keyboard.c (parse_tool_bar_item):
1124 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1125
1126 * font.c: Don't assume string length fits in int.
1127 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1128 Use ptrdiff_t, not int.
1129 (font_intern_prop): Don't assume string length fits in int.
1130 Don't assume integer property fits in fixnum.
1131 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1132
1133 * filelock.c: Fix some buffer overrun and integer overflow issues.
1134 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1135 Reformulate so as not to need the command string.
1136 Invoke gzip -cd rather than gunzip, as it's more portable.
1137 (lock_info_type, lock_file_1, lock_file):
1138 Don't assume pid_t and time_t fit in unsigned long.
1139 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1140 (current_lock_owner): Prefer signed type for sizes.
1141 Use memcpy, not strncpy, where memcpy is what is really wanted.
1142 Don't assume (via atoi) that time_t and pid_t fit in int.
1143 Check for time_t and/or pid_t out of range, e.g., via a network share.
1144 Don't alloca where an auto var works fine.
1145
1146 * fileio.c: Fix some integer overflow issues.
1147 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1148 Don't assume string length fits in int.
1149 (directory_file_name): Don't assume string length fits in long.
1150 (make_temp_name): Don't assume pid fits in int, or that its print
1151 length is less than 20.
1152
1153 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1154
1155 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1156
1157 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1158
1159 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1160 We prefer signed integers, even for size calculations.
1161
1162 * emacs.c: Don't assume string length fits in 'int'.
1163 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1164 (main): Don't invoke strlen when not needed.
1165
1166 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1167 (XD_DEBUG_MESSAGE): Don't waste a byte.
1168
1169 * callproc.c (getenv_internal_1, getenv_internal)
1170 (Fgetenv_internal):
1171 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1172
1173 * lread.c (invalid_syntax): Omit length argument.
1174 All uses changed. This doesn't fix a bug, but it simplifies the
1175 code away from its former Hollerith-constant appearance, and it's
1176 one less 'int' to worry about when looking at integer-overflow issues.
1177 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1178
1179 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1180 This didn't break anything, but it didn't help either.
1181 It's confusing to put a bogus integer in a place where the actual
1182 value does not matter.
1183 (LIST_END_P): Remove unused macro and its bogus comment.
1184 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1185
1186 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1187 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1188 implementation.
1189 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1190 We prefer signed types, and the value cannot exceed the EMACS_INT
1191 range anyway (because otherwise the length would not be representable).
1192 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1193 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1194 This avoids a GCC warning when WIDE_EMACS_INT.
1195
1196 * indent.c (sane_tab_width): New function.
1197 (current_column, scan_for_column, Findent_to, position_indentation)
1198 (compute_motion): Use it. This is just for clarity.
1199 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1200
1201 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1202
1203 * lisp.h (lint_assume): New macro.
1204 * composite.c (composition_gstring_put_cache):
1205 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1206
1207 * editfns.c, insdel.c:
1208 Omit unnecessary forward decls, to simplify future changes.
1209
1210 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1211
1212 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1213
1214 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1215 Use much-faster test for byte-length change.
1216 Don't assume string byte-length fits in 'int'.
1217 Check that character arg fits in 'int'.
1218 (mapcar1): Declare byte as byte, for clarity.
1219
1220 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1221
1222 * fns.c (concat): Catch string overflow earlier.
1223 Do not rely on integer wraparound.
1224
1225 * dispextern.h (struct it.overlay_strings_charpos)
1226 (struct it.selective): Now EMACS_INT, not int.
1227 * xdisp.c (forward_to_next_line_start)
1228 (back_to_previous_visible_line_start)
1229 (reseat_at_next_visible_line_start, next_element_from_buffer):
1230 Don't arbitrarily truncate the value of 'selective' to int.
1231
1232 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1233
1234 * composite.c: Don't truncate sizes to 'int'.
1235 (composition_gstring_p, composition_reseat_it)
1236 (composition_adjust_point): Use EMACS_INT, not int.
1237 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1238 not EMACS_UINT, for indexes.
1239
1240 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1241
1242 * buffer.c: Include <verify.h>.
1243 (struct sortvec.priority, struct sortstr.priority):
1244 Now EMACS_INT, not int.
1245 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1246 (struct sortstr.size, record_overlay_string)
1247 (struct sortstrlist.size, struct sortlist.used):
1248 Don't truncate size to int.
1249 (record_overlay_string): Check for size-calculation overflow.
1250 (init_buffer_once): Check at compile-time, not run-time.
1251
12522011-06-22 Jim Meyering <meyering@redhat.com>
1253
1254 Don't leak an XBM-image-sized buffer
1255 * image.c (xbm_load): Free the image buffer after using it.
1256
12572011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 Port to Sun C.
1260 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1261 that Sun C diagnosed.
1262 * fns.c (secure_hash): Fix pointer signedness issue.
1263 * intervals.c (static_offset_intervals): New function.
1264 (offset_intervals): Use it.
1265
12662011-06-21 Leo Liu <sdl.web@gmail.com>
1267
1268 * deps.mk (fns.o):
1269 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1270 sha512.h.
1271
1272 * fns.c (secure_hash): Rename from crypto_hash_function and change
1273 the first arg to accept symbols.
1274 (Fsecure_hash): New primitive.
1275 (syms_of_fns): New symbols.
1276
12772011-06-20 Deniz Dogan <deniz@dogan.se>
1278
1279 * process.c (Fset_process_buffer): Clarify return value in
1280 docstring.
1281
12822011-06-18 Chong Yidong <cyd@stupidchicken.com>
1283
1284 * dispnew.c (add_window_display_history): Use BVAR.
1285
1286 * xdisp.c (debug_method_add): Use BVAR.
1287 (check_window_end, dump_glyph_matrix, dump_glyph)
1288 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1289
1290 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1291 Likewise.
1292
1293 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1294 check till after the cache is created in init_frame_faces.
1295
12962011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1297
1298 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1299
13002011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1303 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1304 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1305
1306 Improve buffer-overflow checking (Bug#8873).
1307 * fileio.c (Finsert_file_contents):
1308 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1309 Remove the old (too-loose) buffer overflow checks.
1310 They weren't needed, since make_gap checks for buffer overflow.
1311 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1312 The old code merely checked for Emacs fixnum overflow, and relied
1313 on undefined (wraparound) behavior. The new code avoids undefined
1314 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1315
1316 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1317 Tune. Don't use wider integers than needed. Don't use alloca.
1318 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1319
1320 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1321
1322 * insdel.c, lisp.h (buffer_overflow): New function.
1323 (insert_from_buffer_1, replace_range, replace_range_2):
1324 * insdel.c (make_gap_larger):
1325 * editfns.c (Finsert_char):
1326 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1327
1328 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1329
13302011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 Integer overflow and signedness fixes (Bug#8873).
1333
1334 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1335 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1336
1337 * fileio.c: Don't assume EMACS_INT fits in off_t.
1338 (emacs_lseek): New static function.
1339 (Finsert_file_contents, Fwrite_region): Use it.
1340 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1341
1342 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1343
1344 * fns.c: Don't overflow int when computing a list length.
1345 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1346 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1347 truncation on 64-bit hosts. Check for QUIT every
1348 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1349 faster and is responsive enough.
1350 (Flength): Report an error instead of overflowing an integer.
1351 (Fsafe_length): Return a float if the value is not representable
1352 as a fixnum. This shouldn't happen except in contrived situations.
1353 (Fnthcdr, Fsort): Don't assume list length fits in int.
1354 (Fcopy_sequence): Don't assume vector length fits in int.
1355
1356 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1357 (header_size, word_size): New constants.
1358 (allocate_vectorlike): Don't check size overflow here.
1359 (allocate_vector): Check it here instead, since this is the only
1360 caller of allocate_vectorlike that could cause overflow.
1361 Check that the new vector's length is representable as a fixnum.
1362
1363 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1364 The previous code was bogus. For example, next_almost_prime (32)
1365 returned 39, which is undesirable as it is a multiple of 3; and
1366 next_almost_prime (24) returned 25, which is a multiple of 5 so
1367 why was the code bothering to check for multiples of 7?
1368
1369 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1370
1371 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1372
1373 Variadic C functions now count arguments with ptrdiff_t.
1374 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1375 Back then I didn't know that the Emacs coding style prefers signed int.
1376 Also, in the meantime I found a few more instances where arguments
1377 were being counted with int, which may truncate counts on 64-bit
1378 machines, or EMACS_INT, which may be unnecessarily wide.
1379 * lisp.h (struct Lisp_Subr.function.aMANY)
1380 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1381 Arg counts are now ptrdiff_t, not size_t.
1382 All variadic functions and their callers changed accordingly.
1383 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1384 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1385 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1386 * callint.c (Fcall_interactively): Check arg count for overflow,
1387 to avoid potential buffer overrun. Use signed char, not 'int',
1388 for 'varies' array, so that we needn't bother to check its size
1389 calculation for overflow.
1390 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1391 * eval.c (apply_lambda):
1392 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1393 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1394 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1395
1396 * callint.c (Fcall_interactively): Don't use index var as event count.
1397
1398 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1399 * mem-limits.h (SIZE): Remove; no longer used.
1400
1401 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1402
1403 Remove unnecessary casts.
1404 * xterm.c (x_term_init):
1405 * xfns.c (x_set_border_pixel):
1406 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1407 These aren't needed now that we assume ANSI C.
1408
1409 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1410 It's more likely to cause problems (due to unsigned overflow)
1411 than to cure them.
1412
1413 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1414
1415 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1416
1417 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1418
1419 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1420
1421 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1422
1423 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1424
1425 GLYPH_CODE_FACE returns EMACS_INT, not int.
1426 * dispextern.h (merge_faces):
1427 * xfaces.c (merge_faces):
1428 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1429 Don't assume EMACS_INT fits in int.
1430
1431 * character.h (CHAR_VALID_P): Remove unused parameter.
1432 * fontset.c, lisp.h, xdisp.c: All uses changed.
1433
1434 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1435
1436 * fns.c (concat): Minor tuning based on overflow analysis.
1437 This doesn't fix any bugs. Use int to hold character, instead
1438 of constantly refetching from Emacs object. Use XFASTINT, not
1439 XINT, for value known to be a character. Don't bother comparing
1440 a single byte to 0400, as it's always less.
1441
1442 * floatfns.c (Fexpt):
1443 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1444
1445 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1446 for characters.
1447
1448 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1449
1450 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1451 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1452 incorrectly succeed when S was a string, because 4294967386 was
1453 truncated before it was used.
1454
1455 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1456 Otherwise, an out-of-range integer could cause undefined behavior
1457 on a 64-bit host.
1458
1459 * composite.c: Use int, not EMACS_INT, for characters.
1460 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1461 EMACS_INT, for values that are known to be in character range.
1462 This doesn't fix any bugs but is the usual style inside Emacs and
1463 may generate better code on 32-bit machines.
1464
1465 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1466 This is for reasons similar to the recent CHAR_STRING fix.
1467 * charset.c (Fencode_char): Check that character arg is actually
1468 a character. Pass an int to ENCODE_CHAR.
1469 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1470 wider than 'int', as a compile-time check to prevent future regressions
1471 in this area.
1472
1473 * character.c (char_string): Remove unnecessary casts.
1474
1475 Make sure a 64-bit char is never passed to CHAR_STRING.
1476 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1477 by silently ignoring the top 32 bits, allowing some values
1478 that were far too large to be valid characters.
1479 * character.h: Include <verify.h>.
1480 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1481 arguments are no wider than unsigned, as a compile-time check
1482 to prevent future regressions in this area.
1483 * data.c (Faset):
1484 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1485 (Fsubst_char_in_region):
1486 * fns.c (concat):
1487 * xdisp.c (decode_mode_spec_coding):
1488 Adjust to CHAR_STRING's new requirement.
1489 * editfns.c (Finsert_char, Fsubst_char_in_region):
1490 * fns.c (concat): Check that character args are actually
1491 characters. Without this test, these functions did the wrong
1492 thing with wildly out-of-range values on 64-bit hosts.
1493
1494 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1495 These casts should not be needed on 32-bit hosts, either.
1496 * keyboard.c (read_char):
1497 * lread.c (Fload): Remove casts to unsigned.
1498
1499 * lisp.h (UNSIGNED_CMP): New macro.
1500 This fixes comparison bugs on 64-bit hosts.
1501 (ASCII_CHAR_P): Use it.
1502 * casefiddle.c (casify_object):
1503 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1504 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1505 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1506 * dispextern.h (FACE_FROM_ID):
1507 * keyboard.c (read_char): Use UNSIGNED_CMP.
1508
1509 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1510 not to EMACS_INT, to avoid GCC warning.
1511
1512 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1513
1514 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1515 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1516 isn't needed on 32-bit machines.
1517
1518 * buffer.c (Fgenerate_new_buffer_name):
1519 Use EMACS_INT for count, not int.
1520 (advance_to_char_boundary): Return EMACS_INT, not int.
1521
1522 * data.c (Qcompiled_function): Now static.
1523
1524 * window.c (window_body_lines): Now static.
1525
1526 * image.c (gif_load): Rename local to avoid shadowing.
1527
1528 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1529 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1530 * alloc.c (make_save_value): Integer argument is now of type
1531 ptrdiff_t, not int.
1532 (mark_object): Use ptrdiff_t, not int.
1533 * lisp.h (pD): New macro.
1534 * print.c (print_object): Use it.
1535
1536 * alloc.c: Use EMACS_INT, not int, to count objects.
1537 (total_conses, total_markers, total_symbols, total_vector_size)
1538 (total_free_conses, total_free_markers, total_free_symbols)
1539 (total_free_floats, total_floats, total_free_intervals)
1540 (total_intervals, total_strings, total_free_strings):
1541 Now EMACS_INT, not int. All uses changed.
1542 (Fgarbage_collect): Compute overall total using a double, so that
1543 integer overflow is less likely to be a problem. Check for overflow
1544 when converting back to an integer.
1545 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1546 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1547 These were 'int' variables that could overflow on 64-bit hosts;
1548 they were never used, so remove them instead of repairing them.
1549 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1550 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1551 Previously, this ceilinged at INT_MAX, but that doesn't work on
1552 64-bit machines.
1553 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1554
1555 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1556 (allocate_vectorlike): Check for ptrdiff_t overflow.
1557 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1558 when a (possibly-narrower) signed value would do just as well.
1559 We prefer using signed arithmetic, to avoid comparison confusion.
1560
1561 * alloc.c: Catch some string size overflows that we were missing.
1562 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1563 for convenience in STRING_BYTES_MAX.
1564 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1565 The definition here is exact; the one in lisp.h was approximate.
1566 (allocate_string_data): Check for string overflow. This catches
1567 some instances we weren't catching before. Also, it catches
1568 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1569 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1570 and ptrdiff_t and EMACS_INT are both 64 bits.
1571
1572 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1573 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1574 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1575
1576 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1577
1578 * alloc.c (Fmake_string): Check for out-of-range init.
1579
15802011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1581
1582 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1583
15842011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1585
1586 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1587 xg_get_default_scrollbar_width.
1588
1589 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1590 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1591 (style_changed_cb): Call update_theme_scrollbar_width and call
1592 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1593 all frames (Bug#8505).
1594 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1595 Call gtk_window_set_resizable if HAVE_GTK3.
1596 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1597 and height if HAVE_GTK3 (Bug#8505).
1598 (scroll_bar_width_for_theme): New variable.
1599 (update_theme_scrollbar_width): New function.
1600 (xg_get_default_scrollbar_width): Move code to
1601 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1602 (xg_initialize): Call update_theme_scrollbar_width.
1603
1604 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1605
1606 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1607
16082011-06-12 Martin Rudalics <rudalics@gmx.at>
1609
1610 * frame.c (make_frame): Call other_buffer_safely instead of
1611 other_buffer.
1612
1613 * window.c (temp_output_buffer_show): Call display_buffer with
1614 second argument Vtemp_buffer_show_specifiers and reset latter
1615 immediately after the call.
1616 (Vtemp_buffer_show_specifiers): New variable.
1617 (auto_window_vscroll_p, next_screen_context_lines)
1618 (Vscroll_preserve_screen_position): Remove leading asterisks from
1619 doc-strings.
1620
16212011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1622
1623 Fix minor problems found by GCC 4.6.0 static checking.
1624 * buffer.c (Qclone_number): Remove for now, as it's unused.
1625 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1626 (record_buffer): Remove unused local.
1627 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1628 (set_frame_buffer_list): Remove; unused.
1629 * frame.h (other_visible_frames): Remove decl.
1630 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1631 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1632 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1633 if HAVE_GPM.
1634 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1635 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1636 Define only if HAVE_GPM.
1637 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1638 (update_hints_inhibit): Remove; never set. All uses removed.
1639 * widgetprv.h (emacsFrameClassRec): Remove decl.
1640 * window.c (delete_deletable_window): Now returns void, since it
1641 wasn't returning anything.
1642 (compare_window_configurations): Remove unused locals.
1643 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1644 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1645 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1646 the same widths as pointers. This follows up on the 2011-05-06 patch.
1647 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1648 * xterm.h: Likewise.
1649 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1650
16512011-06-12 Juanma Barranquero <lekktu@gmail.com>
1652
1653 * makefile.w32-in: Update dependencies.
1654 (LISP_H): Add lib/intprops.h.
1655
16562011-06-11 Chong Yidong <cyd@stupidchicken.com>
1657
1658 * image.c (gif_load): Add animation frame delay to the metadata.
1659 (syms_of_image): Use DEFSYM. New symbol `delay'.
1660
16612011-06-11 Martin Rudalics <rudalics@gmx.at>
1662
1663 * window.c (delete_deletable_window): Re-add.
1664 (Fset_window_configuration): Rewrite to handle dead buffers and
1665 consequently deletable windows.
1666 (window_tree, Fwindow_tree): Remove. Supply functionality in
1667 window.el.
1668 (compare_window_configurations): Simplify code.
1669
16702011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1671
1672 * image.c (imagemagick_load_image): Fix type mismatch.
1673 (Fimagemagick_types): Likewise.
1674
1675 * window.h (replace_buffer_in_windows): Declare.
1676
16772011-06-11 Martin Rudalics <rudalics@gmx.at>
1678
1679 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1680 Qclone_number. Remove external declaration of Qdelete_window.
1681 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1682 code.
1683 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1684 Qbuffer_list_update_hook if allowed.
1685 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1686 buffer list implementation.
1687 (other_buffer_safely): New function.
1688 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1689 calls to replace_buffer_in_windows and
1690 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1691 if allowed.
1692 (record_buffer): Inhibit quitting and rewrite using quittable
1693 functions. Run Qbuffer_list_update_hook if allowed.
1694 (Frecord_buffer, Funrecord_buffer): New functions.
1695 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1696 switch-to-buffer to window.el.
1697 (bury-buffer): Move to window.el.
1698 (Vbuffer_list_update_hook): New variable.
1699
1700 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1701 section.
1702
1703 * window.h (resize_frame_windows): Move up in code.
1704 (Fwindow_frame): Remove EXFUN.
1705 (replace_buffer_in_all_windows): Remove prototype.
1706 (replace_buffer_in_windows_safely): Add prototype.
1707
1708 * window.c: Declare Qdelete_window static again. Move down
1709 declaration of select_count.
1710 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1711 (Fother_window): Move to window.el.
1712 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1713 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1714 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1715 window.el.
1716 (replace_buffer_in_windows): Implement by calling
1717 Qreplace_buffer_in_windows.
1718 (replace_buffer_in_all_windows): Remove with some functionality
1719 moved into replace_buffer_in_windows_safely.
1720 (replace_buffer_in_windows_safely): New function.
1721 (select_window_norecord, select_frame_norecord): Move in front
1722 of run_window_configuration_change_hook. Remove now obsolete
1723 declarations.
1724 (Fset_window_buffer): Rewrite doc-string. Call
1725 Qrecord_window_buffer.
1726 (keys_of_window): Move binding for other-window to window.el.
1727
17282011-06-11 Chong Yidong <cyd@stupidchicken.com>
1729
1730 * dispextern.h (struct image): Replace data member, whose int_val
1731 and ptr_val fields were not used by anything, with a single
1732 lisp_val object.
1733
1734 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1735 (gif_clear_image, gif_load, imagemagick_load_image)
1736 (gs_clear_image, gs_load): Callers changed.
1737
17382011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1739
1740 * buffer.h: Include <time.h>, for time_t.
1741 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1742
1743 Fix minor problems found by static checking.
1744
1745 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1746
1747 Make identifiers static if they are not used in other modules.
1748 * data.c (Qcompiled_function, Qframe, Qvector):
1749 * image.c (QimageMagick, Qsvg):
1750 * minibuf.c (Qmetadata):
1751 * window.c (resize_window_check, resize_root_window): Now static.
1752 * window.h (resize_window_check, resize_root_window): Remove decls.
1753
1754 * window.c (window_deletion_count, delete_deletable_window):
1755 Remove; unused.
1756 (window_body_lines): Now static.
1757 (Fdelete_other_windows_internal): Mark vars as initialized.
1758 Make sure 'resize_failed' is initialized.
1759 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1760 (resize_window_apply): Remove unused local.
1761 * window.h (delete_deletable_window): Remove decl.
1762
1763 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1764 (imagemagick_load_image): Fix pointer signedness problem by changing
1765 last arg from unsigned char * to char *. All uses changed.
1766 Also, fix a local for similar reasons.
1767 Remove unused locals. Remove locals to avoid shadowing.
1768 (fn_rsvg_handle_free): Remove; unused.
1769 (svg_load, svg_load_image): Fix pointer signedness problem.
1770 (imagemagick_load_image): Don't use garbage pointer image_wand.
1771
1772 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1773
17742011-06-10 Chong Yidong <cyd@stupidchicken.com>
1775
1776 * image.c (gif_load): Fix omitted cast error introduced by
1777 2011-06-06 change.
1778
17792011-06-10 Martin Rudalics <rudalics@gmx.at>
1780
1781 * window.h (resize_proportionally, orig_total_lines)
1782 (orig_top_line): Remove from window structure.
1783 (set_window_height, set_window_width, change_window_heights)
1784 (Fdelete_window): Remove prototypes.
1785 (resize_frame_windows): Remove duplicate declaration.
1786
17872011-06-10 Eli Zaretskii <eliz@gnu.org>
1788
1789 * window.h (resize_frame_windows, resize_window_check)
1790 (delete_deletable_window, resize_root_window)
1791 (resize_frame_windows): Declare prototypes.
1792
1793 * window.c (resize_window_apply): Make definition be "static" to
1794 match the prototype.
1795
17962011-06-10 Martin Rudalics <rudalics@gmx.at>
1797
1798 * window.c: Remove declarations of Qwindow_size_fixed,
1799 window_min_size_1, window_min_size_2, window_min_size,
1800 size_window, window_fixed_size_p, enlarge_window, delete_window.
1801 Remove static from declaration of Qdelete_window, it's
1802 temporarily needed by Fbury_buffer.
1803 (replace_window): Don't assign orig_top_line and
1804 orig_total_lines.
1805 (Fdelete_window, delete_window): Remove. Window deletion is
1806 handled by window.el.
1807 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1808 Fdelete_window calls with calls to Qdelete_window.
1809 (Fdelete_other_windows): Remove. Deleting other windows is
1810 handled by window.el.
1811 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1812 handled in window.el.
1813 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1814 Window minimum sizes are handled in window.el.
1815 (shrink_windows, size_window, set_window_height)
1816 (set_window_width, change_window_heights, window_height)
1817 (window_width, CURBEG, CURSIZE, enlarge_window)
1818 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1819 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1820 handled in window.el.
1821 (make_dummy_parent): Rename to make_parent_window and give it a
1822 second argument horflag.
1823 (make_window): Don't set resize_proportionally any more.
1824 (Fsplit_window): Remove. Windows are split in window.el.
1825 (save_restore_action, save_restore_orig_size)
1826 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1827 Resize mini windows in window.el.
1828 (grow_mini_window, shrink_mini_window): Implement by calling
1829 Qresize_root_window_vertically, resize_window_check and
1830 resize_window_apply.
1831 (saved_window, Fset_window_configuration, save_window_save): Do
1832 not handle orig_top_line, orig_total_lines, and
1833 resize_proportionally.
1834 (window_min_height, window_min_width): Move to window.el.
1835 (keys_of_window): Move bindings for delete-other-windows,
1836 split-window, delete-window and enlarge-window to window.el.
1837
1838 * buffer.c: Temporarily extern Qdelete_window.
1839 (Fbury_buffer): Temporarily call Qdelete_window instead of
1840 Fdelete_window (Fbury_buffer will move to window.el soon).
1841
1842 * frame.c (set_menu_bar_lines_1): Remove code handling
1843 orig_top_line and orig_total_lines.
1844
1845 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1846 set_window_height but set heights directly.
1847 (change_frame_size_1): Use resize_frame_windows.
1848
1849 * xdisp.c (init_xdisp): Don't use set_window_height but set
1850 heights directly.
1851
1852 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1853 resize_frame_windows instead of change_window_heights and run
1854 run_window_configuration_change_hook.
1855
1856 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1857 instead of change_window_heights and run
1858 run_window_configuration_change_hook.
1859
18602011-06-09 Martin Rudalics <rudalics@gmx.at>
1861
1862 * window.c (replace_window): Rename second argument REPLACEMENT to
1863 NEW. New third argument SETFLAG. Rewrite.
1864 (delete_window, make_dummy_parent): Call replace_window with
1865 third argument 1.
1866 (window_list_1): Move down in code.
1867 (run_window_configuration_change_hook): Move set_buffer part
1868 before select_frame_norecord part in order to unwind correctly.
1869 Rename count1 to count.
1870 (recombine_windows, delete_deletable_window, resize_root_window)
1871 (Fdelete_other_windows_internal)
1872 (Frun_window_configuration_change_hook, make_parent_window)
1873 (resize_window_check, resize_window_apply, Fresize_window_apply)
1874 (resize_frame_windows, Fsplit_window_internal)
1875 (Fdelete_window_internal, Fresize_mini_window_internal): New
1876 functions.
1877 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1878
18792011-06-08 Martin Rudalics <rudalics@gmx.at>
1880
1881 * window.h (window): Add some new members to window structure -
1882 normal_lines, normal_cols, new_total, new_normal, clone_number,
1883 splits, nest, prev_buffers, next_buffers.
1884 (WINDOW_TOTAL_SIZE): Move here from window.c.
1885 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1886
1887 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1888 Remove.
1889 (make_dummy_parent): Set new members of windows structure.
1890 (make_window): Move down in code. Handle new members of window
1891 structure.
1892 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1893 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1894 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1895 (Fset_window_prev_buffers, Fwindow_next_buffers)
1896 (Fset_window_next_buffers, Fset_window_clone_number): New
1897 functions.
1898 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1899 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1900 Doc-string fixes.
1901 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1902 Argument WINDOW can be now internal window too.
1903 (Fwindow_use_time): Move up in code.
1904 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1905 Rewrite doc-string.
1906 (Fset_window_configuration, saved_window)
1907 (Fcurrent_window_configuration, save_window_save): Handle new
1908 members of window structure.
1909 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1910 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1911 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1912 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1913 Qget_mru_window, Qresize_root_window,
1914 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1915 Qauto_buffer_name; staticpro them.
1916
19172011-06-07 Martin Rudalics <rudalics@gmx.at>
1918
1919 * window.c (Fwindow_total_size, Fwindow_left_column)
1920 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1921 (Fwindow_list_1): New functions.
1922 (window_box_text_cols): Replace with window_body_cols.
1923 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1924 window_body_cols instead of window_box_text_cols.
1925 (delete_window, Fset_window_configuration): Call
1926 delete_all_subwindows with window as argument.
1927 (delete_all_subwindows): Take a window as argument and not a
1928 structure. Rewrite.
1929 (window_loop): Remove handling of GET_LRU_WINDOW and
1930 GET_LARGEST_WINDOW.
1931 (Fget_lru_window, Fget_largest_window): Move to window.el.
1932
1933 * window.h: Extern window_body_cols instead of
1934 window_box_text_cols. delete_all_subwindows now takes a
1935 Lisp_Object as argument.
1936
1937 * indent.c (compute_motion, Fcompute_motion): Use
1938 window_body_cols instead of window_box_text_cols.
1939
1940 * frame.c (delete_frame): Call delete_all_subwindows with root
1941 window as argument.
1942
19432011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1944
1945 * fns.c (Fputhash): Document return value.
1946
19472011-06-06 Chong Yidong <cyd@stupidchicken.com>
1948
1949 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1950
19512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 Cons<->int and similar integer overflow fixes (Bug#8794).
1954
1955 Check for overflow when converting integer to cons and back.
1956 * charset.c (Fdefine_charset_internal, Fdecode_char):
1957 Use cons_to_unsigned to catch overflow.
1958 (Fencode_char): Use INTEGER_TO_CONS.
1959 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1960 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1961 * data.c (long_to_cons, cons_to_long): Remove.
1962 (cons_to_unsigned, cons_to_signed): New functions.
1963 These signal an error for invalid or out-of-range values.
1964 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1965 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1966 * font.c (Ffont_variation_glyphs):
1967 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1968 * lisp.h: Include <intprops.h>.
1969 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1970 (cons_to_signed, cons_to_unsigned): New decls.
1971 (long_to_cons, cons_to_long): Remove decls.
1972 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1973 (Fprimitive_undo): Use CONS_TO_INTEGER.
1974 * xfns.c (Fx_window_property): Likewise.
1975 * xselect.c: Include <limits.h>.
1976 (x_own_selection, selection_data_to_lisp_data):
1977 Use INTEGER_TO_CONS.
1978 (x_handle_selection_request, x_handle_selection_clear)
1979 (x_get_foreign_selection, Fx_disown_selection_internal)
1980 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1981 (lisp_data_to_selection_data): Use cons_to_unsigned.
1982 (x_fill_property_data): Use cons_to_signed.
1983 Report values out of range.
1984
1985 Check for buffer and string overflow more precisely.
1986 * buffer.h (BUF_BYTES_MAX): New macro.
1987 * lisp.h (STRING_BYTES_MAX): New macro.
1988 * alloc.c (Fmake_string):
1989 * character.c (string_escape_byte8):
1990 * coding.c (coding_alloc_by_realloc):
1991 * doprnt.c (doprnt):
1992 * editfns.c (Fformat):
1993 * eval.c (verror):
1994 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1995 since they may not be the same number.
1996 * editfns.c (Finsert_char):
1997 * fileio.c (Finsert_file_contents):
1998 Likewise for BUF_BYTES_MAX.
1999
2000 * image.c: Use ptrdiff_t, not int, for sizes.
2001 (slurp_file): Switch from int to ptrdiff_t.
2002 All uses changed.
2003 (slurp_file): Check that file size fits in both size_t (for
2004 malloc) and ptrdiff_t (for sanity and safety).
2005
2006 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2007 if b->modtime has its maximal value.
2008
2009 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2010
2011 Don't assume time_t can fit into int.
2012 * buffer.h (struct buffer.modtime): Now time_t, not int.
2013 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2014 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2015
2016 Minor fixes for signed vs unsigned integers.
2017 * character.h (MAYBE_UNIFY_CHAR):
2018 * charset.c (maybe_unify_char):
2019 * keyboard.c (read_char, reorder_modifiers):
2020 XINT -> XFASTINT, since the integer must be nonnegative.
2021 * ftfont.c (ftfont_spec_pattern):
2022 * keymap.c (access_keymap, silly_event_symbol_error):
2023 XUINT -> XFASTINT, since the integer must be nonnegative.
2024 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2025 since it makes no difference and we prefer signed.
2026 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2027 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2028 nonnegative.
2029
20302011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2031
2032 * window.h (Fwindow_frame): Declare.
2033
20342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2035
2036 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2037 (SPARE_MEMORY): Always define.
2038 (LARGE_REQUEST): Remove.
2039 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2040
20412011-06-06 Martin Rudalics <rudalics@gmx.at>
2042
2043 * lisp.h: Move EXFUNS for Fframe_root_window,
2044 Fframe_first_window and Fset_frame_selected_window to window.h.
2045
2046 * window.h: Move EXFUNS for Fframe_root_window,
2047 Fframe_first_window and Fset_frame_selected_window here from
2048 lisp.h.
2049
2050 * frame.c (Fwindow_frame, Fframe_first_window)
2051 (Fframe_root_window, Fframe_selected_window)
2052 (Fset_frame_selected_window): Move to window.c.
2053 (Factive_minibuffer_window): Move to minibuf.c.
2054 (Fother_visible_frames_p): New function.
2055
2056 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2057
2058 * window.c (decode_window, decode_any_window): Move up in code.
2059 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2060 (inhibit_frame_unsplittable): Remove unused variable.
2061 (Fwindow_buffer): Move up and rewrite doc-string.
2062 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2063 (Fwindow_prev): New functions.
2064 (Fwindow_frame): Move here from frame.c. Accept any window as
2065 argument.
2066 (Fframe_root_window, Fframe_first_window)
2067 (Fframe_selected_window): Move here from frame.c. Accept frame
2068 or arbitrary window as argument. Update doc-strings.
2069 (Fminibuffer_window): Move up in code.
2070 (Fwindow_minibuffer_p): Move up in code and simplify.
2071 (Fset_frame_selected_window): Move here from frame.c.
2072 Marginal rewrite.
2073 (Fselected_window, select_window, Fselect_window): Move up in
2074 code. Minor doc-string fixes.
2075
20762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2077
2078 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2079 Do not assume that spare memory exists; that assumption is valid
2080 only if SYSTEM_MALLOC.
2081 (LARGE_REQUEST): New macro, so that the issue of large requests
2082 is separated from the issue of spare memory.
2083
20842011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2085
2086 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2087 format. (Bug#8806)
2088
2089 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2090
2091 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2092 before statements.
2093
20942011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2095
2096 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2097
2098 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2099
2100 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2101 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2102
21032011-06-05 Juanma Barranquero <lekktu@gmail.com>
2104
2105 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2106
21072011-06-04 Chong Yidong <cyd@stupidchicken.com>
2108
2109 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2110 (x_clipboard_manager_save): Add return value.
2111 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2112 New error handlers.
2113 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2114 Obey Vx_select_enable_clipboard_manager. Catch errors in
2115 x_clipboard_manager_save (Bug#8779).
2116 (Vx_select_enable_clipboard_manager): New variable.
2117 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2118
21192011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2120
2121 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2122
21232011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2124
2125 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2126 in the current matrix if keep_current_p is non-zero.
2127
21282011-06-04 Eli Zaretskii <eliz@gnu.org>
2129
2130 * bidi.c (bidi_level_of_next_char): Fix last change.
2131
21322011-06-03 Eli Zaretskii <eliz@gnu.org>
2133
2134 Support bidi reordering of text covered by display properties.
2135
2136 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2137 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2138 (bidi_cache_search, bidi_cache_iterator_state)
2139 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2140 (bidi_level_of_next_char, bidi_move_to_visually_next):
2141 Support character positions inside a run of characters covered by a
2142 display string.
2143 (bidi_paragraph_init, bidi_resolve_explicit_1)
2144 (bidi_level_of_next_char): Call bidi_fetch_char and
2145 bidi_fetch_char_advance instead of FETCH_CHAR and
2146 FETCH_CHAR_ADVANCE.
2147 (bidi_init_it): Initialize new members.
2148 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2149 definitions.
2150 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2151 instead of using explicit *_CHAR codes.
2152 (bidi_resolve_explicit, bidi_resolve_weak):
2153 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2154 bidirectional text is supported only in multibyte buffers.
2155 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2156 it to initialize the frame_window_p member of struct bidi_it.
2157 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2158 (bidi_resolve_explicit, bidi_resolve_weak)
2159 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2160 bidi_it->nchars is non-positive.
2161 (bidi_level_of_next_char): Don't try to lookup the cache for the
2162 next/previous character if nothing is cached there yet, or if we
2163 were just reseat()'ed to a new position.
2164
2165 * xdisp.c (set_cursor_from_row): Set start and stop points
2166 according to the row's direction when priming the loop that looks
2167 for the glyph on which to display cursor.
2168 (single_display_spec_intangible_p): Function deleted.
2169 (display_prop_intangible_p): Reimplement to call
2170 handle_display_spec instead of single_display_spec_intangible_p.
2171 Accept 3 additional arguments needed by handle_display_spec.
2172 This fixes incorrect cursor motion across display property with complex
2173 values: lists, `(when COND...)' forms, etc.
2174 (single_display_spec_string_p): Support property values that are
2175 lists with the argument STRING its top-level element.
2176 (display_prop_string_p): Fix the condition for processing a
2177 property that is a list to be consistent with handle_display_spec.
2178 (handle_display_spec): New function, refactored from the
2179 last portion of handle_display_prop.
2180 (compute_display_string_pos): Accept additional argument
2181 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2182 value of a `display' property is a "replacing spec".
2183 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2184 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2185 the display property, but just return a value indicating whether
2186 the display property will replace the characters it covers.
2187 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2188 frame_window_p members of struct bidi_it.
2189 (compute_display_string_pos, compute_display_string_end):
2190 New functions.
2191 (push_it): Accept second argument POSITION, where pop_it should
2192 jump to continue iteration.
2193 (reseat_1): Initialize bidi_it.disp_pos.
2194
2195 * keyboard.c (adjust_point_for_property): Adjust the call to
2196 display_prop_intangible_p to its new signature.
2197
2198 * dispextern.h (struct bidi_it): New member frame_window_p.
2199 (bidi_init_it): Update prototypes.
2200 (display_prop_intangible_p): Update prototype.
2201 (compute_display_string_pos, compute_display_string_end):
2202 Declare prototypes.
2203 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2204 EMACS_INT.
2205
22062011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2207
2208 Malloc failure behavior now depends on size of allocation.
2209 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2210 * lisp.h: Change signatures accordingly.
2211 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2212 All callers changed. (Bug#8762)
2213
2214 * gnutls.c: Use Emacs's memory allocators.
2215 Without this change, the gnutls library would invoke malloc etc.
2216 directly, which causes problems on non-SYNC_INPUT hosts, and which
2217 runs afoul of improving memory_full behavior. (Bug#8761)
2218 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2219 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2220 xfree instead of the default malloc, realloc, free.
2221 (Fgnutls_boot): No need to check for memory allocation failure,
2222 since xmalloc does that for us.
2223
2224 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2225 * category.c (hash_get_category_set):
2226 * ccl.c (ccl_driver):
2227 * charset.c (Fdefine_charset_internal):
2228 * charset.h (struct charset.hash_index):
2229 * composite.c (get_composition_id, gstring_lookup_cache)
2230 (composition_gstring_put_cache):
2231 * composite.h (struct composition.hash_index):
2232 * dispextern.h (struct image.hash):
2233 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2234 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2235 (hashfn_equal, hashfn_user_defined, make_hash_table)
2236 (maybe_resize_hash_table, hash_lookup, hash_put)
2237 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2238 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2239 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2240 * image.c (make_image, search_image_cache, lookup_image)
2241 (xpm_put_color_table_h):
2242 * lisp.h (struct Lisp_Hash_Table):
2243 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2244 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2245 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2246 * alloc.c (allocate_vectorlike):
2247 Check for overflow in vector size calculations.
2248 * ccl.c (ccl_driver):
2249 Check for overflow when converting EMACS_INT to int.
2250 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2251 need to be updated by these changes.
2252 * fns.c (make_hash_table, maybe_resize_hash_table):
2253 Check for integer overflow with large hash tables.
2254 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2255 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2256 (SXHASH_REDUCE): New macro.
2257 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2258 Use it instead of discarding useful hash info with large hash values.
2259 (sxhash_float): New function.
2260 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2261 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2262 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2263 Rewrite to use FIXNUM_BITS, as this simplifies things.
2264 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2265 Adjust signatures to match updated version of code.
2266 (consing_since_gc): Now EMACS_INT, since a single hash table can
2267 use more than INT_MAX bytes.
2268
22692011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2270
2271 Make it possible to build with GCC-4.6+ -O2 -flto.
2272
2273 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2274
22752011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2276
2277 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2278 Call minibuffer-inactive-mode.
2279
22802011-05-31 Juanma Barranquero <lekktu@gmail.com>
2281
2282 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2283 Update dependencies.
2284
22852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2286
2287 * data.c (init_data): Remove code for UTS, this system is not
2288 supported anymore.
2289
22902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2291
2292 Don't force ./temacs to start in terminal mode.
2293
2294 * frame.c (make_initial_frame): Initialize faces in all cases, not
2295 only when CANNOT_DUMP is defined.
2296 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2297
22982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2299
2300 * dispnew.c (add_window_display_history): Use const for the string
2301 pointer. Remove declaration, not needed.
2302
23032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2304
2305 Use 'inline', not 'INLINE'.
2306 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2307 * alloc.c, fontset.c (INLINE): Remove.
2308 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2309 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2310 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2311 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2312 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2313
23142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2315
2316 Make it possible to run ./temacs.
2317
2318 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2319 syms_of_callproc does the same thing. Remove test for
2320 "initialized", do it in the caller.
2321 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2322
23232011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2324
2325 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2326 (read_minibuf): Use get_minibuffer.
2327 (syms_of_minibuf): Use DEFSYM.
2328 (Qmetadata): New var.
2329 * data.c (Qbuffer): Don't make it static.
2330 (syms_of_data): Use DEFSYM.
2331
23322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2333
2334 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2335 (CCL_CODE_MIN): New macro.
2336
23372011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2338
2339 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2340
2341 * eval.c (Qdebug): Now static.
2342 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2343 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2344 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2345
23462011-05-29 Chong Yidong <cyd@stupidchicken.com>
2347
2348 * image.c: Various fixes to ImageMagick code comments.
2349 (Fimagemagick_types): Doc fix.
2350
23512011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 Minor fixes prompted by GCC 4.6.0 warnings.
2354
2355 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2356
2357 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2358 (x_clipboard_manager_save_all): Move extern decl to ...
2359 * xterm.h: ... here, so that it can be checked for consistency.
2360
23612011-05-29 Chong Yidong <cyd@stupidchicken.com>
2362
2363 * xselect.c (x_clipboard_manager_save_frame)
2364 (x_clipboard_manager_save_all): New functions.
2365 (Fx_clipboard_manager_save): Lisp function deleted.
2366
2367 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2368 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2369
2370 * xterm.h: Update prototype.
2371
23722011-05-28 William Xu <william.xwl@gmail.com>
2373
2374 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2375 exiting (Bug#8239).
2376
23772011-05-28 Jim Meyering <meyering@redhat.com>
2378
2379 Avoid a sign-extension bug in crypto_hash_function.
2380 * fns.c (to_uchar): Define.
2381 (crypto_hash_function): Use it to convert some newly-signed
2382 variables to unsigned, to avoid sign-extension bugs. For example,
2383 without this change, (md5 "truc") would evaluate to
2384 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2385 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2386 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2387
23882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2389
2390 Integer overflow fixes.
2391
2392 * dbusbind.c: Serial number integer overflow fixes.
2393 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2394 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2395 to hold a serial number that is too large for a fixnum.
2396 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2397 Check for serial numbers out of range. Decode any serial number
2398 that was so large that it became a float. (Bug#8722)
2399
2400 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2401 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2402 Use XFASTINT rather than XUINT when numbers are nonnegative.
2403 (xd_append_arg, Fdbus_method_return_internal):
2404 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2405 arguments, check that Lisp number is nonnegative, rather than
2406 silently wrapping negative numbers around. (Bug#8722)
2407 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2408 (Bug#8722)
2409
2410 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2411
2412 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2413
2414 ccl: add integer overflow checks
2415 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2416 (IN_INT_RANGE): New macros.
2417 (ccl_driver): Use them to check for integer overflow when
2418 decoding a CCL program. Many of the new checks are whether XINT (x)
2419 fits in int; it doesn't always, on 64-bit hosts. The new version
2420 doesn't catch all possible integer overflows, but it's an
2421 improvement. (Bug#8719)
2422
2423 * alloc.c (make_event_array): Use XINT, not XUINT.
2424 There's no need for unsigned here.
2425
2426 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2427 This follows up to the 2011-05-06 change that substituted uintptr_t
2428 for EMACS_INT. This case wasn't caught back then.
2429
2430 Rework Fformat to avoid integer overflow issues.
2431 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2432 now (part of C89). Include <verify.h>.
2433 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2434 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2435 (Fformat): Avoid the prepass trying to compute sizes; it was only
2436 approximate and thus did not catch overflow reliably. Instead, walk
2437 through the format just once, formatting and computing sizes as we go,
2438 checking for integer overflow at every step, and allocating a larger
2439 buffer as needed. Keep track separately whether the format is
2440 multibyte. Keep only the most-recently calculated precision, rather
2441 than them all. Record whether each argument has been converted to
2442 string. Use EMACS_INT, not int, for byte and char and arg counts.
2443 Support field widths and precisions larger than INT_MAX. Avoid
2444 sprintf's undefined behavior with conversion specifications such as %#d
2445 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2446 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2447 formatting out-of-range floating point numbers with int
2448 formats. (Bug#8668)
2449
2450 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2451
2452 * data.c: Avoid integer truncation in expressions involving floats.
2453 * data.c: Include <intprops.h>.
2454 (arith_driver): When there's an integer overflow in an expression
2455 involving floating point, convert the integers to floating point
2456 so that the resulting value does not suffer from catastrophic
2457 integer truncation. For example, on a 64-bit host (* 4
2458 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2459 Do not rely on undefined behavior after integer overflow.
2460
2461 merge count_size_as_multibyte, parse_str_to_multibyte
2462 * character.c, character.h (count_size_as_multibyte):
2463 Rename from parse_str_to_multibyte; all uses changed.
2464 Check for integer overflow.
2465 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2466 since it's now a duplicate of the other. This is more of
2467 a character than a buffer op, so better that it's in character.c.
2468 * fns.c, print.c: Adjust to above changes.
2469
24702011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2471
2472 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2473
24742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2475
2476 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2477 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2478 (x_clipboard_manager_save): Now static.
2479 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2480
2481 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2482 (crypto_hash_function): Now static.
2483 Fix pointer signedness problems. Avoid unnecessary initializations.
2484
24852011-05-27 Chong Yidong <cyd@stupidchicken.com>
2486
2487 * termhooks.h (Vselection_alist): Make it terminal-local.
2488
2489 * terminal.c (create_terminal): Initialize it.
2490
2491 * xselect.c: Support for clipboard managers.
2492 (Vselection_alist): Move to termhooks.h as terminal-local var.
2493 (LOCAL_SELECTION): New macro.
2494 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2495 (symbol_to_x_atom): Remove gratuitous arg.
2496 (x_handle_selection_request, lisp_data_to_selection_data)
2497 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2498 (x_own_selection, x_get_local_selection, x_convert_selection):
2499 New arg, specifying work frame. Use terminal-local Vselection_alist.
2500 (some_frame_on_display): Delete unused function.
2501 (Fx_own_selection_internal, Fx_get_selection_internal)
2502 (Fx_disown_selection_internal, Fx_selection_owner_p)
2503 (Fx_selection_exists_p): New optional frame arg.
2504 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2505 (x_handle_selection_clear): Don't treat other terminals with the
2506 same keyboard specially. Use the terminal-local Vselection_alist.
2507 (x_clear_frame_selections): Use Frun_hook_with_args.
2508
2509 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2510
2511 * xterm.h: Add support for those atoms.
2512
25132011-05-26 Chong Yidong <cyd@stupidchicken.com>
2514
2515 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2516 (converted_selections, conversion_fail_tag): New global variables.
2517 (x_selection_request_lisp_error): Free the above.
2518 (x_get_local_selection): Remove unnecessary code.
2519 (x_reply_selection_request): Args changed; handle arbitrary array
2520 of converted selections stored in converted_selections.
2521 Separate the XChangeProperty and SelectionNotify steps.
2522 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2523 (x_convert_selection): New function.
2524 (x_handle_selection_event): Simplify.
2525 (x_get_foreign_selection): Don't ignore incoming requests while
2526 waiting for an answer; this will fail when we implement
2527 SAVE_TARGETS, and seems unnecessary anyway.
2528 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2529 (Vx_sent_selection_functions): Doc fix.
2530
25312011-05-26 Leo Liu <sdl.web@gmail.com>
2532
2533 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2534
25352011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2536
2537 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2538
2539 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2540 for fringe update if it has periodic bitmap.
2541 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2542 and fringe_bitmap_periodic_p.
2543
2544 * fringe.c (get_fringe_bitmap_data): New function.
2545 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2546 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2547 row. Mark glyph row for fringe update if periodicity changed.
2548
2549 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2550 for fringe update unless it has periodic bitmap.
2551
25522011-05-25 Kenichi Handa <handa@m17n.org>
2553
2554 * xdisp.c (get_next_display_element): Set correct it->face_id for
2555 a static composition.
2556
25572011-05-24 Leo Liu <sdl.web@gmail.com>
2558
2559 * deps.mk (fns.o):
2560 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2561
2562 * fns.c (crypto_hash_function, Fsha1): New function.
2563 (Fmd5): Use crypto_hash_function.
2564 (syms_of_fns): Add Ssha1.
2565
25662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2567
2568 * gnutls.c: Remove unused macros.
2569 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2570 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2571 Remove macros that are defined and never used.
2572 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2573
25742011-05-22 Chong Yidong <cyd@stupidchicken.com>
2575
2576 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2577 (Fx_get_selection_internal): Minor cleanup.
2578 (Fx_own_selection_internal): Rename arguments for consistency with
2579 select.el.
2580
25812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2582
2583 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2584
25852011-05-22 Chong Yidong <cyd@stupidchicken.com>
2586
2587 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2588
25892011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2590
2591 * dispnew.c (scrolling_window): Don't exclude the case that the
2592 last enabled row in the desired matrix touches the bottom boundary.
2593
25942011-05-21 Glenn Morris <rgm@gnu.org>
2595
2596 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2597 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2598 and add some more files.
2599
26002011-05-20 Eli Zaretskii <eliz@gnu.org>
2601
2602 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2603 report_file_error introduced by the change from 2011-05-07.
2604
26052011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2606
2607 * systime.h (Time): Define only if emacs is defined.
2608 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2609 where the include path doesn't have X11/X.h by default. See
2610 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2611
26122011-05-20 Kenichi Handa <handa@m17n.org>
2613
2614 * composite.c (find_automatic_composition): Fix previous change.
2615
26162011-05-20 Glenn Morris <rgm@gnu.org>
2617
2618 * lisp.mk: New file, split from Makefile.in.
2619 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2620 (shortlisp): Remove.
2621 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2622
26232011-05-19 Glenn Morris <rgm@gnu.org>
2624
2625 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2626 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2627 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2628 (lisp): Set the order to that of loadup.el.
2629 (shortlisp): Make it a copy of $lisp.
2630 (SOME_MACHINE_LISP): Remove.
2631 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2632 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2633
26342011-05-18 Kenichi Handa <handa@m17n.org>
2635
2636 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2637 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2638 (find_automatic_composition): Mostly rewrite for efficiency.
2639
26402011-05-18 Juanma Barranquero <lekktu@gmail.com>
2641
2642 * makefile.w32-in: Update dependencies.
2643
26442011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2645
2646 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2647 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2648
26492011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2650
2651 Fix some integer overflow issues, such as string length overflow.
2652
2653 * insdel.c (count_size_as_multibyte): Check for string overflow.
2654
2655 * character.c (lisp_string_width): Check for string overflow.
2656 Use EMACS_INT, not int, for string indexes and lengths; in
2657 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2658 the resulting string length overflows an EMACS_INT; instead,
2659 report a string overflow if no precision given. When checking for
2660 precision exhaustion, use a check that cannot possibly have
2661 integer overflow. (Bug#8675)
2662 * character.h (lisp_string_width): Adjust to new signature.
2663
2664 * alloc.c (string_overflow): New function.
2665 (Fmake_string): Use it. This doesn't change behavior, but saves
2666 a few bytes and will simplify future changes.
2667 * character.c (string_escape_byte8): Likewise.
2668 * lisp.h (string_overflow): New decl.
2669
2670 Fixups, following up to the user-interface timestamp change.
2671 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2672 for UI timestamps, instead of unsigned long.
2673 * msdos.c (mouse_get_pos): Likewise.
2674 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2675 * w32gui.h (Time): Define by including "systime.h" rather than by
2676 declaring it ourselves. (Bug#8664)
2677
2678 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2679 * image.c (clear_image_cache): Likewise.
2680
2681 * term.c (term_mouse_position): Don't assume time_t wraparound.
2682
2683 Be more systematic about user-interface timestamps.
2684 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2685 and sometimes 'EMACS_UINT', to represent these timestamps.
2686 This change causes it to use 'Time' uniformly, as that's what X uses.
2687 This makes the code easier to follow, and makes it easier to catch
2688 integer overflow bugs such as Bug#8664.
2689 * frame.c (Fmouse_position, Fmouse_pixel_position):
2690 Use Time, not unsigned long, for user-interface timestamps.
2691 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2692 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2693 * keyboard.h (last_event_timestamp): Likewise.
2694 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2695 * menu.h (xmenu_show): Likewise.
2696 * term.c (term_mouse_position): Likewise.
2697 * termhooks.h (struct input_event.timestamp): Likewise.
2698 (struct terminal.mouse_position_hook): Likewise.
2699 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2700 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2701 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2702 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2703 what it was before.
2704 * menu.h, termhooks.h: Include "systime.h", for Time.
2705
2706 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2707 Don't assume that the difference between two unsigned long values
2708 can fit into an integer. At this point, we know button_down_time
2709 <= event->timestamp, so the difference must be nonnegative, so
2710 there's no need to cast the result if double-click-time is
2711 nonnegative, as it should be; check that it's nonnegative, just in
2712 case. This bug is triggered when events are more than 2**31 ms
2713 apart (about 25 days). (Bug#8664)
2714
2715 * xselect.c (last_event_timestamp): Remove duplicate decl.
2716 (x_own_selection): Remove needless cast to unsigned long.
2717
2718 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2719 that always fit in int. Use a sentinel instead of a counter, to
2720 avoid a temp and to allay GCC's concerns about possible int overflow.
2721 * frame.h (struct frame): Use int for menu_bar_items_used
2722 instead of EMACS_INT, since it always fits in int.
2723
2724 * menu.c (grow_menu_items): Check for int overflow.
2725
2726 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2727
2728 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2729 Before, the code was not consistent. These values cannot exceed
2730 2**31 - 1 so there's no need to make them unsigned.
2731 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2732 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2733 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2734 as modifiers.
2735 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2736
2737 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2738 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2739 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2740 presumably because the widths might not match.
2741
2742 * window.c (size_window): Avoid needless test at loop start.
2743
27442011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2745
2746 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2747
27482011-05-12 Drew Adams <drew.adams@oracle.com>
2749
2750 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2751
27522011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2753
2754 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2755 `width' to `bar_area_x' and `bar_area_width', respectively.
2756 (x_scroll_run): Take account of fringe background extension.
2757
2758 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2759 Rename local vars `left' and `width' to `bar_area_x' and
2760 `bar_area_width', respectively.
2761 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2762 background extension.
2763
27642011-05-10 Jim Meyering <meyering@redhat.com>
2765
2766 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2767
27682011-05-10 Juanma Barranquero <lekktu@gmail.com>
2769
2770 * image.c (Finit_image_library): Return t for built-in image types,
2771 like pbm and xbm. (Bug#8640)
2772
27732011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2774
2775 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2776
27772011-05-07 Eli Zaretskii <eliz@gnu.org>
2778
2779 * w32console.c (Fset_screen_color): Doc fix.
2780 (Fget_screen_color): New function.
2781 (syms_of_ntterm): Defsubr it.
2782
2783 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2784 unlink the temporary file if Fcall_process didn't create it in the
2785 first place.
2786 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2787 child process will be redirected to a file specified with `:file'.
2788 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2789 cue to call_process_cleanup not to close that handle.
2790
27912011-05-07 Ben Key <bkey76@gmail.com>
2792
2793 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2794 one of two shell specific rules, either bootstrap-temacs-CMD or
2795 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2796 to the previous implementation of the bootstrap-temacs rule.
2797 The bootstrap-temacs-CMD rule is similar to the previous
2798 implementation of the bootstrap-temacs rule except that it
2799 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2800 variable.
2801
2802 These changes, along with some changes to nt/configure.bat,
2803 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2804 earlier fix to add support for --cflags and --ldflags options
2805 that include quotes so that it works whether make uses cmd or
2806 sh as the shell.
2807
28082011-05-06 Michael Albinus <michael.albinus@gmx.de>
2809
2810 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2811 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2812 is a constant.
2813 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2814 a string. Handle both cases.
2815 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2816 (Fdbus_register_method): Use Qinvalid_function.
2817
28182011-05-06 Juanma Barranquero <lekktu@gmail.com>
2819
2820 * makefile.w32-in: Update dependencies.
2821 (LISP_H): Add inttypes.h and stdin.h.
2822 (PROCESS_H): Add unistd.h.
2823
28242011-05-06 Eli Zaretskii <eliz@gnu.org>
2825
2826 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2827 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2828
28292011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2830
2831 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2832
2833 * term.c (vfatal): Remove stray call to va_end.
2834 It's not needed and the C Standard doesn't allow it here anyway.
2835
2836 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2837 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2838
2839 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2840 bytes.
2841
2842 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2843
2844 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2845
2846 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2847
2848 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2849
2850 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2851
2852 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2853 * charset.c (Fdefine_charset_internal): Don't initialize
2854 charset.code_space[15]. The value was garbage, on hosts with
2855 32-bit int (Bug#8600).
2856
2857 * lread.c (read_integer): Be more consistent with string-to-number.
2858 Use string_to_number to do the actual conversion; this avoids
2859 rounding errors and fixes some other screwups. Without this fix,
2860 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2861 (digit_to_number): Move earlier, for benefit of read_integer.
2862 Return -1 if the digit is out of range for the base, -2 if it is
2863 not a digit in any supported base. (Bug#8602)
2864
2865 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2866
2867 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2868 to match comment at start of function. This also removes a
2869 GCC warning about overflow in a 32+64-bit port.
2870
2871 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2872
2873 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2874 Reported by Stefan Monnier in
2875 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2876 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2877 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2878
2879 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2880 (EMACS_UINTPTR): Likewise, with uintptr_t.
2881
2882 * lisp.h: Prefer 64-bit EMACS_INT if available.
2883 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2884 on 32-bit hosts that have 64-bit int, so that they can access
2885 large files.
2886 However, temporarily disable this change unless the temporary
2887 symbol WIDE_EMACS_INT is defined.
2888
2889 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2890
2891 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2892 This removes an assumption that EMACS_INT and long are the same
2893 width as pointers. The assumption is true for Emacs porting targets
2894 now, but we want to make other targets possible.
2895 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2896 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2897 In the rest of the code, change types of integers that hold casted
2898 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2899 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2900 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2901 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2902 No need to cast type when ORing.
2903 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2904 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2905 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2906 assume EMACS_INT is the same width as char *.
2907 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2908 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2909 Remove no-longer-needed casts.
2910 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2911 (xg_tool_bar_help_callback, xg_make_tool_item):
2912 Use EMACS_INTPTR to hold an integer
2913 that will be cast to void *; this can avoid a GCC warning
2914 if EMACS_INT is not the same width as void *.
2915 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2916 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2917 (current_message_1, set_message_1):
2918 Use a local to convert to proper width without a cast.
2919 * xmenu.c (dialog_selection_callback): Likewise.
2920
2921 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2922 Also, don't assume VALBITS / RAND_BITS is less than 5,
2923 and don't rely on undefined behavior when shifting a 1 left into
2924 the sign bit.
2925 * lisp.h (get_random): Change signature to match.
2926
2927 * lread.c (hash_string): Use size_t, not int, for hash computation.
2928 Normally we prefer signed values; but hashing is special, because
2929 it's better to use unsigned division on hash table sizes so that
2930 the remainder is nonnegative. Also, size_t is the natural width
2931 for hashing into memory. The previous code used 'int', which doesn't
2932 retain enough info to hash well into very large tables.
2933 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2934
2935 * dbusbind.c: Don't possibly lose pointer info when converting.
2936 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2937 Use XPNTR rather than XHASH, so that the high-order bits of
2938 the pointer aren't lost when converting through void *.
2939
2940 * eval.c (Fautoload): Don't double-shift a pointer.
2941
2942 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2943
29442011-05-06 Juanma Barranquero <lekktu@gmail.com>
2945
2946 * gnutls.c (DEF_GNUTLS_FN):
2947 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2948
29492011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2950
2951 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2952 marker. (Bug#8610)
2953
29542011-05-05 Eli Zaretskii <eliz@gnu.org>
2955
2956 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2957 New version that can reserve upto 2GB of heap space.
2958
29592011-05-05 Chong Yidong <cyd@stupidchicken.com>
2960
2961 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2962
29632011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2964
2965 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2966 `gnutls_certificate_set_x509_key_file'.
2967
29682011-05-05 Juanma Barranquero <lekktu@gmail.com>
2969
2970 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2971 Update dependencies.
2972
29732011-05-04 Juanma Barranquero <lekktu@gmail.com>
2974
2975 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2976 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2977 Remove unused parameter `fildes'.
2978 * process.c (read_process_output, send_process): Don't pass it.
2979
29802011-05-04 Juanma Barranquero <lekktu@gmail.com>
2981
2982 Fix previous change: the library cache is defined in w32.c.
2983 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2984 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2985
29862011-05-04 Juanma Barranquero <lekktu@gmail.com>
2987
2988 Implement dynamic loading of GnuTLS on Windows.
2989
2990 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2991 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2992 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2993 Declare.
2994
2995 * gnutls.c (Qgnutls_dll): Define.
2996 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2997 (gnutls_*): Declare function pointers.
2998 (init_gnutls_functions): New function to initialize function pointers.
2999 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3000 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3001 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3002 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3003 (emacs_gnutls_write, emacs_gnutls_read)
3004 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3005 (Fgnutls_available_p): New function.
3006 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3007 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3008 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3009
3010 * image.c: Include w32.h.
3011 (Vimage_type_cache): Delete.
3012 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3013 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3014 (w32_delayed_load): Move to w32.c.
3015
3016 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3017
3018 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3019 (w32_delayed_load): Move from image.c. When loading a library, record
3020 its filename in the :loaded-from property of the library id.
3021 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3022 Initialize and staticpro them.
3023 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3024
3025 * process.c: Include lisp.h before w32.h, not after.
3026 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3027 instead of gnutls_record_check_pending.
3028
3029 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3030
30312011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3032
3033 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3034 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3035 as passed in.
3036
30372011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3038
3039 * xterm.c (x_set_frame_alpha): Do not set property on anything
3040 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3041
30422011-05-02 Juanma Barranquero <lekktu@gmail.com>
3043
3044 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3045
30462011-05-02 Juanma Barranquero <lekktu@gmail.com>
3047
3048 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3049 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3050 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3051 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3052 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3053 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3054 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3055 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3056 (Qgnutls_bootprop_callbacks_verify): Make static.
3057
30582011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3059
3060 * callproc.c: Indentation fixup.
3061
3062 * sysdep.c (wait_for_termination_1): Make static.
3063 (wait_for_termination, interruptible_wait_for_termination):
3064 Move after wait_for_termination_1.
3065
30662011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3067
3068 * sysdep.c (interruptible_wait_for_termination): New function
3069 which is like wait_for_termination, but allows keyboard
3070 interruptions.
3071
3072 * callproc.c (Fcall_process): Add (:file "file") as an option for
3073 the STDOUT buffer.
3074 (Fcall_process_region): Ditto.
3075
30762011-04-30 Eli Zaretskii <eliz@gnu.org>
3077
3078 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3079 rather than `XVECTOR (FOO)->size'.
3080
3081 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3082 inttypes.h, as a gnulib replacement is used if it not available in
3083 system headers.
3084
30852011-04-21 Eli Zaretskii <eliz@gnu.org>
3086
3087 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3088 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3089 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3090
3091 * coding.c (coding_alloc_by_realloc): Error out if destination
3092 will grow beyond MOST_POSITIVE_FIXNUM.
3093 (decode_coding_emacs_mule): Abort if there isn't enough place in
3094 charbuf for the composition carryover bytes. Reserve an extra
3095 space for up to 2 characters produced in a loop.
3096 (decode_coding_iso_2022): Abort if there isn't enough place in
3097 charbuf for the composition carryover bytes.
3098
30992011-04-21 Eli Zaretskii <eliz@gnu.org>
3100
3101 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3102 aborting when %lld or %lll format is passed.
3103 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3104 %llo or %llx format is passed. (Bug#8545)
3105
3106 * window.c (window_scroll_line_based): Use a marker instead of
3107 simple variables to record original value of point. (Bug#7952)
3108
3109 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3110 produced by %s or %c overflows available buffer space. (Bug#8545)
3111
31122011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3113
3114 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3115 (SIZE_MAX): Move defn after all includes, as they might #define it.
3116
31172011-04-28 Juanma Barranquero <lekktu@gmail.com>
3118
3119 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3120
31212011-04-28 Juanma Barranquero <lekktu@gmail.com>
3122
3123 * keyboard.c (Qdelayed_warnings_hook): Define.
3124 (command_loop_1): Run `delayed-warnings-hook'
3125 if Vdelayed_warnings_list is non-nil.
3126 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3127 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3128
31292011-04-28 Eli Zaretskii <eliz@gnu.org>
3130
3131 * doprnt.c (doprnt): Don't return value smaller than the buffer
3132 size if the message was truncated. (Bug#8545).
3133
31342011-04-28 Juanma Barranquero <lekktu@gmail.com>
3135
3136 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3137 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3138
31392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3140
3141 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3142
31432011-04-27 Juanma Barranquero <lekktu@gmail.com>
3144
3145 * makefile.w32-in: Update dependencies.
3146
31472011-04-27 Eli Zaretskii <eliz@gnu.org>
3148
3149 Improve `doprnt' and its usage. (Bug#8545)
3150 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3151 `format_end'. Remove support for %l as a conversion specifier.
3152 Don't use xrealloc. Improve diagnostics when the %l size modifier
3153 is used. Update the commentary.
3154
3155 * eval.c (verror): Simplify calculation of size_t.
3156
3157 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3158 messages.
3159
31602011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3161
3162 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3163 change.
3164
31652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3166
3167 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3168 This makes this file independent of the recent pseudovector change.
3169
31702011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3171
3172 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3173
3174 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3175 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3176 Remove unused local.
3177 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3178
3179 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3180 GCC 4.6.0 optimizes based on type-based alias analysis.
3181 For example, if b is of type struct buffer * and v of type struct
3182 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3183 != &v->size, and therefore "v->size = 1; b->size = 2; return
3184 v->size;" must therefore return 1. This assumption is incorrect
3185 for Emacs, since it type-puns struct Lisp_Vector * with many other
3186 types. To fix this problem, this patch adds a new type struct
3187 vectorlike_header that documents the constraints on layout of vectors
3188 and pseudovectors, and helps optimizing compilers not get fooled
3189 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3190 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3191 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3192 the size member.
3193 (XSETPVECTYPE): Rewrite in terms of new macro.
3194 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3195 This is a bit clearer, and further avoids the possibility of
3196 undesirable aliasing.
3197 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3198 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3199 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3200 since Lisp_Subr is a special case (no "next" field).
3201 (ASIZE): Now uses header.size rather than size.
3202 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3203 to avoid the hassle of writing XVECTOR (foo)->header.size.
3204 (struct vectorlike_header): New type.
3205 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3206 object, to help avoid aliasing.
3207 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3208 (SUBRP): Likewise, since Lisp_Subr is a special case.
3209 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3210 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3211 (struct Lisp_Hash_Table): Combine first two members into a single
3212 struct vectorlike_header member. All uses of "size" and "next" members
3213 changed to be "header.size" and "header.next".
3214 * buffer.h (struct buffer): Likewise.
3215 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3216 * frame.h (struct frame): Likewise.
3217 * process.h (struct Lisp_Process): Likewise.
3218 * termhooks.h (struct terminal): Likewise.
3219 * window.c (struct save_window_data, struct saved_window): Likewise.
3220 * window.h (struct window): Likewise.
3221 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3222 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3223 * buffer.c (init_buffer_once): Likewise.
3224 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3225 special case.
3226 * process.c (Fformat_network_address): Use local var for size,
3227 for brevity.
3228
3229 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3230
3231 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3232 * data.c (atof): Remove decl; no longer used or needed.
3233 (digit_to_number): Move to lread.c.
3234 (Fstring_to_number): Use new string_to_number function, to be
3235 consistent with how the Lisp reader treats infinities and NaNs.
3236 Do not assume that floating-point numbers represent EMACS_INT
3237 without losing information; this is not true on most 64-bit hosts.
3238 Avoid double-rounding errors, by insisting on integers when
3239 parsing non-base-10 numbers, as the documentation specifies.
3240 * lisp.h (string_to_number): New decl, replacing ...
3241 (isfloat_string): Remove.
3242 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3243 (read1): Do not accept +. and -. as integers; this
3244 appears to have been a coding error. Similarly, do not accept
3245 strings like +-1e0 as floating point numbers. Do not report
3246 overflow for integer overflows unless the base is not 10 which
3247 means we have no simple and reliable way to continue.
3248 Break out the floating-point parsing into a new
3249 function string_to_number, so that Fstring_to_number parses
3250 floating point numbers consistently with the Lisp reader.
3251 (digit_to_number): Move here from data.c. Make it static inline.
3252 (E_CHAR, EXP_INT): Remove, replacing with ...
3253 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3254 (string_to_number): New function, replacing isfloat_string.
3255 This function checks for valid syntax and produces the resulting
3256 Lisp float number too. Rework it so that string-to-number
3257 no longer mishandles examples like "1.0e+". Use strtoumax,
3258 so that overflow for non-base-10 numbers is reported only when
3259 there's no portable and simple way to convert to floating point.
3260
3261 * textprop.c (set_text_properties_1): Rewrite for clarity,
3262 and to avoid GCC warning about integer overflow.
3263
3264 * intervals.h (struct interval): Use EMACS_INT for members
3265 where EMACS_UINT might cause problems. See
3266 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3267 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3268 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3269 All uses changed.
3270 (offset_intervals): Tell GCC not to worry about length overflow
3271 when negating a negative length.
3272
3273 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3274 (overrun_check_free): Likewise.
3275
3276 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3277 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3278 word size.
3279
3280 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3281 (gnutls_make_error): Rename local to avoid shadowing.
3282 (gnutls_emacs_global_deinit): ifdef out; not used.
3283 (Fgnutls_boot): Use const for pointer to readonly storage.
3284 Comment out unused local. Fix pointer signedness problems.
3285
3286 * lread.c (openp): Don't stuff size_t into an 'int'.
3287 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3288 about possible signed overflow.
3289
3290 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3291 (GDK_KEY_g): Don't define if already defined.
3292 (xg_prepare_tooltip): Avoid pointer signedness problem.
3293 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3294
3295 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3296 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3297
3298 * xfns.c (Fx_window_property): Simplify a bit,
3299 to make a bit faster and to avoid GCC 4.6.0 warning.
3300 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3301
3302 * fns.c (internal_equal): Don't assume size_t fits in int.
3303
3304 * alloc.c (compact_small_strings): Tighten assertion a little.
3305
3306 Replace pEd with more-general pI, and fix some printf arg casts.
3307 * lisp.h (pI): New macro, generalizing old pEd macro to other
3308 conversion specifiers. For example, use "...%"pI"d..." rather
3309 than "...%"pEd"...".
3310 (pEd): Remove. All uses replaced with similar uses of pI.
3311 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3312 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3313 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3314 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3315 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3316 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3317 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3318 64-bit hosts.
3319 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3320 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3321 * print.c (safe_debug_print, print_object): Likewise.
3322 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3323 to int.
3324 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3325 avoiding the 0 flag, which is not portable.
3326 * process.c (Fmake_network_process): Use pI to avoid cast.
3327 * region-cache.c (pp_cache): Likewise.
3328 * xdisp.c (decode_mode_spec): Likewise.
3329 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3330 behavior on 64-bit hosts with printf arg.
3331 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3332 (x_stop_queuing_selection_requests): Likewise.
3333 (x_get_window_property): Don't truncate byte count to an 'int'
3334 when tracing.
3335
3336 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3337 here, since it parses constructs like leading '-' and spaces,
3338 which are not wanted; and it overflows with large numbers.
3339 Instead, simply match F[0-9]+, which is what is wanted anyway.
3340
3341 * alloc.c: Remove unportable assumptions about struct layout.
3342 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3343 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3344 (allocate_vectorlike, make_pure_vector): Use the new macros,
3345 plus offsetof, to remove unportable assumptions about struct layout.
3346 These assumptions hold on all porting targets that I know of, but
3347 they are not guaranteed, they're easy to remove, and removing them
3348 makes further changes easier.
3349
3350 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3351 This doesn't fix a bug but makes the code clearer.
3352 (string_overrun_cookie): Now const. Use initializers that
3353 don't formally overflow signed char, to avoid warnings.
3354 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3355 can cause Emacs to crash when string overrun checking is enabled.
3356 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3357 multiple of sizeof (EMACS_INT); it need not be, if
3358 alignof(EMACS_INT) < sizeof (EMACS_INT).
3359 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3360
33612011-04-26 Juanma Barranquero <lekktu@gmail.com>
3362
3363 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3364
33652011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3366
3367 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3368 supposed to be handshaking. (Bug#8556)
3369 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3370
33712011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3372
3373 * lisp.h (Qdebug): List symbol.
3374 * eval.c (Qdebug): Restore global linkage.
3375 * keyboard.c (debug-on-event): New variable.
3376 (handle_user_signal): Break into debugger when debug-on-event
3377 matches the current signal symbol.
3378
33792011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3380
3381 * alloc.c (check_sblock, check_string_bytes)
3382 (check_string_free_list): Convert to standard C.
3383
33842011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3385
3386 * w32.c (emacs_gnutls_push): Fix typo.
3387
33882011-04-25 Eli Zaretskii <eliz@gnu.org>
3389
3390 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3391 "cast to pointer from integer of different size".
3392
3393 Improve doprnt and its use in verror. (Bug#8545)
3394 * doprnt.c (doprnt): Document the set of format control sequences
3395 supported by the function. Use SAFE_ALLOCA instead of always
3396 using `alloca'.
3397
3398 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3399 is one byte too soon. Don't use xrealloc; instead xfree and
3400 xmalloc anew.
3401
34022011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3403
3404 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3405 callbacks stage.
3406
3407 * gnutls.c: Renamed global_initialized to
3408 gnutls_global_initialized. Added internals for the
3409 :verify-hostname-error, :verify-error, and :verify-flags
3410 parameters of `gnutls-boot' and documented those parameters in the
3411 docstring. Start callback support.
3412 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3413 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3414 on error. Return error code.
3415 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3416 (emacs_gnutls_read): Likewise.
3417 (Fgnutls_boot): Return handshake error code.
3418 (emacs_gnutls_handle_error): New function.
3419 (wsaerror_to_errno): Likewise.
3420
3421 * w32.h (emacs_gnutls_pull): Add prototype.
3422 (emacs_gnutls_push): Likewise.
3423
3424 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3425 (emacs_gnutls_push): Likewise.
3426
34272011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3428
3429 * process.c (wait_reading_process_output): Check if GnuTLS
3430 buffered some data internally if no FDs are set for TLS
3431 connections.
3432
3433 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3434 (LIBS): Link to USER_LIBS.
3435 ($(BLD)/gnutls.$(0)): New target.
3436
34372011-04-24 Eli Zaretskii <eliz@gnu.org>
3438
3439 * xdisp.c (handle_single_display_spec): Rename the
3440 display_replaced_before_p argument into display_replaced_p, to
3441 make it consistent with the commentary. Fix typos in the
3442 commentary.
3443
3444 * textprop.c (syms_of_textprop): Remove dead code.
3445 (copy_text_properties): Delete obsolete commentary about an
3446 interface that was deleted long ago. Fix typos in the description
3447 of arguments.
3448
3449 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3450 to changes in oldXMenu/XMenu.h from 2011-04-16.
3451 <menu_help_message, prev_menu_help_message>: Constify.
3452 (IT_menu_make_room): menu->help_text is now `const char **';
3453 adjust.
3454
3455 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3456 to changes in oldXMenu/XMenu.h from 2011-04-16.
3457 (struct XMenu): Declare `help_text' `const char **'.
3458
3459 * xfaces.c <Qunspecified>: Make extern again.
3460
3461 * syntax.c: Include sys/types.h before including regex.h, as
3462 required by Posix.
3463
3464 * doc.c (get_doc_string): Improve the format passed to `error'.
3465
3466 * doprnt.c (doprnt): Improve commentary.
3467
3468 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3469
3470 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3471 them with etags.
3472
3473 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3474 changes in globals.h immediately force recompilation.
3475 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3476 $(CURDIR)/s/ms-w32.h.
3477 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3478
3479 * character.c (Fchar_direction): Function deleted.
3480 (syms_of_character): Don't defsubr it.
3481 <char-direction-table>: Deleted.
3482
34832011-04-23 Eli Zaretskii <eliz@gnu.org>
3484
3485 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3486 * doprnt.c: Include limits.h.
3487 (SIZE_MAX): New macro.
3488 (doprnt): Return a size_t value. 2nd arg is now size_t.
3489 Many local variables are now size_t instead of int or unsigned.
3490 Improve overflow protection. Support `l' modifier for integer
3491 conversions. Support %l conversion. Don't assume an EMACS_INT
3492 argument for integer conversions and for %c.
3493
3494 * lisp.h (doprnt): Restore prototype.
3495
3496 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3497 $(SRC)/character.h.
3498
3499 * Makefile.in (base_obj): Add back doprnt.o.
3500
3501 * deps.mk (doprnt.o): Add back prerequisites.
3502 (callint.o): Depend on character.h.
3503
3504 * eval.c (internal_lisp_condition_case): Include the handler
3505 representation in the error message.
3506 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3507 when breaking from the loop.
3508
3509 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3510
3511 * callint.c (Fcall_interactively): When displaying error message
3512 about invalid control letter, pass the character's codepoint, not
3513 a pointer to its multibyte form. Improve display of the character
3514 in octal and display also its hex code.
3515
3516 * character.c (char_string): Use %x to display the (unsigned)
3517 codepoint of an invalid character, to avoid displaying a bogus
3518 negative value.
3519
3520 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3521 `error', not SYMBOL_NAME itself.
3522
3523 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3524 character arguments to `error'.
3525
3526 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3527 to `error' in error message about FINAL_CHAR argument. Make sure
3528 FINAL_CHAR is a character, and use %c when it is passed as
3529 argument to `error'.
3530
35312011-04-23 Eli Zaretskii <eliz@gnu.org>
3532
3533 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3534
3535 * w32.c: Include <time.h>.
3536 (sys_localtime): New function.
3537
35382011-04-23 Chong Yidong <cyd@stupidchicken.com>
3539
3540 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3541
3542 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3543
35442011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3545
3546 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3547 zombies (Bug#8467).
3548
35492011-04-19 Eli Zaretskii <eliz@gnu.org>
3550
3551 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3552 gl_state.e_property when gl_state.object is Qt.
3553
3554 * insdel.c (make_gap_larger): Remove limitation of buffer size
3555 to <= INT_MAX.
3556
35572011-04-18 Chong Yidong <cyd@stupidchicken.com>
3558
3559 * xdisp.c (lookup_glyphless_char_display)
3560 (produce_glyphless_glyph): Handle cons cell entry in
3561 glyphless-char-display.
3562 (Vglyphless_char_display): Document it.
3563
3564 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3565 glyphless-char-display.
3566
35672011-04-17 Chong Yidong <cyd@stupidchicken.com>
3568
3569 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3570
3571 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3572
3573 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3574 definition for no-X builds.
3575
35762011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3577
3578 Static checks with GCC 4.6.0 and non-default toolkits.
3579
3580 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3581
3582 * process.c (keyboard_bit_set): Define only if SIGIO.
3583 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3584 (send_process): Repair possible setjmp clobbering.
3585
3586 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3587
3588 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3589
3590 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3591
3592 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3593 Define only if needed.
3594
3595 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3596 by pacifying GCC about it. Maybe it's time to retire it?
3597 * xfaces.c (USG, __TIMEVAL__): Likewise.
3598
3599 * dispextern.h (struct redisplay_interface): Rename param
3600 to avoid shadowing.
3601 * termhooks.h (struct terminal): Likewise.
3602 * xterm.c (xembed_send_message): Likewise.
3603
3604 * insdel.c (make_gap_smaller): Define only if
3605 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3606
3607 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3608 it.
3609
3610 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3611 so that we aren't warned about unused symbols.
3612
3613 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3614
3615 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3616
3617 * xfns.c (x_real_positions): Mark locals as initialized.
3618
3619 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3620
3621 * xterm.c: Fix problems found by static analysis with other toolkits.
3622 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3623 (x_dispatch_event): Declare static if USE_GTK, and
3624 define if USE_GTK || USE_X_TOOLKIT.
3625 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3626 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3627 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3628 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3629
3630 * xmenu.c (menu_help_callback): Pointer type fixes.
3631 Use const pointers when pointing at readonly data. Avoid pointer
3632 signedness clashes.
3633 (FALSE): Remove unused macro.
3634 (update_frame_menubar): Remove unused decl.
3635
3636 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3637
3638 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3639 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3640 (single_menu_item): Rename local to avoid shadowing.
3641
3642 * keyboard.c (make_lispy_event): Remove unused local var.
3643
3644 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3645 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3646
3647 * bitmaps: Change bitmaps from unsigned char back to the X11
3648 compatible char. Avoid the old compiler warnings about
3649 out-of-range initializers by using, for example, '\xab' rather
3650 than 0xab.
3651
3652 * xgselect.c (xgselect_initialize): Check vs interface
3653 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3654
3655 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3656
3657 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3658 to read-only memory.
3659
3660 * fns.c (vector): Remove; this old hack is no longer needed.
3661
3662 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3663 Remove unused var.
3664 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3665
3666 * xrdb.c (x_load_resources): Omit unused local.
3667
3668 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3669 (x_window): Rename locals to avoid shadowing.
3670 (USG): Use the kludged USG macro, to pacify gcc.
3671
3672 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3673 (x_term_init): Remove local to avoid shadowing.
3674
3675 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3676
3677 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3678 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3679
36802011-04-16 Eli Zaretskii <eliz@gnu.org>
3681
3682 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3683
3684 Fix regex.c, syntax.c and friends for buffers > 2GB.
3685 * syntax.h (struct gl_state_s): Declare character position members
3686 EMACS_INT.
3687
3688 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3689
3690 * textprop.c (verify_interval_modification, interval_of):
3691 Declare arguments EMACS_INT.
3692
3693 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3694 EMACS_INT.
3695
3696 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3697
3698 * indent.c (Fvertical_motion): Local variable it_start is now
3699 EMACS_INT.
3700
3701 * regex.c (re_match, re_match_2, re_match_2_internal)
3702 (bcmp_translate, regcomp, regexec, print_double_string)
3703 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3704 (re_compile_pattern, re_exec): Declare arguments and local
3705 variables `size_t' and `ssize_t' and return values `regoff_t', as
3706 appropriate.
3707 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3708 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3709 <compile_stack_type>: `size' and `avail' are now `size_t'.
3710
3711 * regex.h <regoff_t>: Use ssize_t, not int.
3712 (re_search, re_search_2, re_match, re_match_2): Arguments that
3713 specify buffer/string position and length are now ssize_t and
3714 size_t. Return type is regoff_t.
3715
37162011-04-16 Ben Key <bkey76@gmail.com>
3717
3718 * nsfont.m: Fixed bugs in ns_get_family and
3719 ns_descriptor_to_entity that were caused by using free to
3720 deallocate memory blocks that were allocated by xmalloc (via
3721 xstrdup). This caused Emacs to crash when compiled with
3722 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3723 --enable-checking=xmallocoverrun). xfree is now used to
3724 deallocate these memory blocks.
3725
37262011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3727
3728 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3729
3730 emacs_write: Accept and return EMACS_INT for sizes.
3731 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3732 et seq.
3733 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3734 Accept and return EMACS_INT.
3735 (emacs_gnutls_write): Return the number of bytes written on
3736 partial writes.
3737 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3738 (emacs_read, emacs_write): Remove check for negative size, as the
3739 Emacs source code has been audited now.
3740 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3741 (emacs_read, emacs_write): Use it.
3742 * process.c (send_process): Adjust to the new signatures of
3743 emacs_write and emacs_gnutls_write. Do not attempt to store
3744 a byte offset into an 'int'; it might overflow.
3745 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3746
3747 * sound.c: Don't assume sizes fit in 'int'.
3748 (struct sound_device.period_size, alsa_period_size):
3749 Return EMACS_INT, not int.
3750 (struct sound_device.write, vox_write, alsa_write):
3751 Accept EMACS_INT, not int.
3752 (wav_play, au_play): Use EMACS_INT to store sizes and to
3753 record read return values.
3754
37552011-04-15 Ben Key <bkey76@gmail.com>
3756
3757 * keyboard.c (Qundefined): Don't declare static since it is used
3758 in nsfns.m.
3759 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3760 static since they are used in nsfont.m.
3761
37622011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3763
3764 * process.c (Qprocessp): Don't declare static.
3765 * lisp.h (Qprocessp): Declare again.
3766
37672011-04-15 Juanma Barranquero <lekktu@gmail.com>
3768
3769 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3770
37712011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3772
3773 Improve C-level modularity by making more things 'static'.
3774
3775 Don't publish debugger-only interfaces to other modules.
3776 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3777 (verify_bytepos, count_markers): Move decls to the only modules
3778 that need them.
3779 * region-cache.h (pp_cache): Likewise.
3780 * window.h (check_all_windows): Likewise.
3781 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3782
3783 * sysdep.c (croak): Now static, if
3784 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3785 * syssignal.h (croak): Declare only if not static.
3786
3787 * alloc.c (refill_memory_reserve): Now static if
3788 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3789 * lisp.h (refill_memory_reserve): Declare only if not static.
3790
3791 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3792 Define only if USE_LUCID.
3793
3794 * xrdb.c (x_customization_string, x_rm_string): Now static.
3795
3796 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3797 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3798
3799 * xdisp.c (draw_row_with_mouse_face): Now static.
3800 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3801
3802 * window.h (check_all_windows): Mark externally visible.
3803
3804 * window.c (window_deletion_count): Now static.
3805
3806 * undo.c: Make symbols static if they're not exported.
3807 (last_undo_buffer, last_boundary_position, pending_boundary):
3808 Now static.
3809
3810 * textprop.c (interval_insert_behind_hooks): Now static.
3811 (interval_insert_in_front_hooks): Likewise.
3812
3813 * term.c: Make symbols static if they're not exported.
3814 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3815 (max_frame_lines, tty_set_terminal_modes):
3816 (tty_reset_terminal_modes, tty_turn_off_highlight):
3817 (get_tty_terminal): Now static.
3818 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3819 * termhooks.h (term_mouse_moveto): Do not declare if
3820 HAVE_WINDOW_SYSTEM.
3821 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3822 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3823
3824 * sysdep.c: Make symbols static if they're not exported.
3825 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3826 Now static.
3827 (sigprocmask_set, full_mask): Remove; unused.
3828 (wait_debugging): Mark as visible.
3829 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3830 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3831
3832 * syntax.c (syntax_temp): Define only if !__GNUC__.
3833
3834 * sound.c (current_sound_device, current_sound): Now static.
3835
3836 * search.c (searchbufs, searchbuf_head): Now static.
3837
3838 * scroll.c (scroll_cost): Remove; unused.
3839 * dispextern.h (scroll_cost): Remove decl.
3840
3841 * region-cache.h (pp_cache): Mark as externally visible.
3842
3843 * process.c: Make symbols static if they're not exported.
3844 (process_tick, update_tick, create_process, chan_process):
3845 (Vprocess_alist, proc_buffered_char, datagram_access):
3846 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3847 (deactivate_process): Mark defn as static, as well as decl.
3848 * lisp.h (create_process): Remove decl.
3849 * process.h (chan_process, Vprocess_alist): Remove decls.
3850
3851 * print.c: Make symbols static if they're not exported.
3852 (print_depth, new_backquote_output, being_printed, print_buffer):
3853 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3854 (print_interval, print_number_index, initial_stderr_stream):
3855 Now static.
3856 * lisp.h (Fprinc): Remove decl.
3857 (debug_output_compilation_hack): Mark as externally visible.
3858
3859 * sysdep.c (croak): Move decl from here to syssignal.h.
3860 * syssignal.h (croak): Put it here, so the API can be checked when
3861 'croak' is called from dissociate_if_controlling_tty.
3862
3863 * minibuf.c: Make symbols static if they're not exported.
3864 (minibuf_save_list, choose_minibuf_frame): Now static.
3865 * lisp.h (choose_minibuf_frame): Remove decl.
3866
3867 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3868
3869 * lread.c: Make symbols static if they're not exported.
3870 (read_objects, initial_obarray, oblookup_last_bucket_number):
3871 Now static.
3872 (make_symbol): Remove; unused.
3873 * lisp.h (initial_obarray, make_symbol): Remove decls.
3874
3875 * keyboard.c: Make symbols static if they're not exported.
3876 (single_kboard, recent_keys_index, total_keys, recent_keys):
3877 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3878 (this_single_command_key_start, echoing, last_auto_save):
3879 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3880 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3881 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3882 (Vlispy_mouse_stem, double_click_count):
3883 Now static.
3884 (force_auto_save_soon): Define only if SIGDANGER.
3885 (ignore_mouse_drag_p): Now static if
3886 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3887 (print_help): Remove; unused.
3888 (stop_character, last_timer_event): Mark as externally visible.
3889 * keyboard.h (ignore_mouse_drag_p): Declare only if
3890 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3891 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3892 * lisp.h (echoing): Remove decl.
3893 (force_auto_save_soon): Declare only if SIGDANGER.
3894 * xdisp.c (redisplay_window): Simplify code, to make it more
3895 obvious that ignore_mouse_drag_p is not accessed if !defined
3896 USE_GTK && !defined HAVE_NS.
3897
3898 * intervals.c: Make symbols static if they're not exported.
3899 (merge_properties_sticky, merge_interval_right, delete_interval):
3900 Now static.
3901 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3902
3903 * insdel.c: Make symbols static if they're not exported.
3904 However, leave prepare_to_modify_buffer alone. It's never
3905 called from outside this function, but that appears to be a bug.
3906 (combine_after_change_list, combine_after_change_buffer):
3907 (adjust_after_replace, signal_before_change): Now static.
3908 (adjust_after_replace_noundo): Remove; unused.
3909 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3910 (signal_before_change): Remove decls.
3911
3912 * indent.c (val_compute_motion, val_vmotion): Now static.
3913
3914 * image.c: Make symbols static if they're not exported.
3915 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3916 if USE_GTK.
3917 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3918 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3919
3920 * fringe.c (standard_bitmaps): Now static.
3921 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3922
3923 * frame.c: Make symbols static if they're not exported.
3924 (x_report_frame_params, make_terminal_frame): Now static.
3925 (get_frame_param): Now static, unless HAVE_NS.
3926 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3927 (x_get_resource_string): Remove; not used.
3928 * frame.h (make_terminal_frame, x_report_frame_params):
3929 (x_get_resource_string); Remove decls.
3930 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3931 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3932
3933 * font.c, fontset.c: Make symbols static if they're not exported.
3934 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3935 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3936 * font.c (font_close_object): Now static.
3937 * font.h (font_close_object): Remove.
3938 * fontset.c (FONTSET_OBJLIST): Remove.
3939 (free_realized_fontset) #if-0 the body, which does nothing.
3940 (face_suitable_for_char_p): #if-0, as it's never called.
3941 * fontset.h (face_suitable_for_char_p): Remove decl.
3942 * xfaces.c (face_at_string_position):
3943 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3944 since 0 is always ASCII.
3945
3946 * fns.c (weak_hash_tables): Now static.
3947
3948 * fileio.c: Make symbols static if they're not exported.
3949 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3950 (Vwrite_region_annotation_buffers): Now static.
3951
3952 * eval.c: Make symbols static if they're not exported.
3953 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3954 * lisp.h (backtrace_list): Remove decl.
3955
3956 * emacs.c: Make symbols static if they're not exported.
3957 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3958 (fatal_error_code, fatal_error_signal_hook, standard_args):
3959 Now static.
3960 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3961 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3962 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3963 * lisp.h (fatal_error_signal_hook): Remove decl.
3964 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3965
3966 * editfns.c: Move a (normally-unused) function to its only use.
3967 * editfns.c, lisp.h (get_operating_system_release): Remove.
3968 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3969 worth the hassle of breaking this out.
3970
3971 * xterm.c: Make symbols static if they're not exported.
3972 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3973 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3974 (x_destroy_window, x_delete_display):
3975 Now static.
3976 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3977 (x_mouse_leave): Remove; unused.
3978 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3979 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3980 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3981 Remove decls.
3982 (x_mouse_leave): Declare only if WINDOWSNT.
3983 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3984 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3985 USE_X_TOOLKIT.
3986
3987 * ftxfont.c: Make symbols static if they're not exported.
3988 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3989 HAVE_FREETYPE.
3990 * font.h (ftxfont_driver): Likewise.
3991
3992 * xfns.c: Make symbols static if they're not exported.
3993 (x_last_font_name, x_display_info_for_name):
3994 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3995 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3996 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3997 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3998 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3999 (last_show_tip_args): Now static.
4000 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4001 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4002 (x_screen_planes): Remove; unused.
4003 * dispextern.h (x_screen_planes): Remove decl.
4004
4005 * dispnew.c: Make symbols static if they're not exported.
4006 * dispextern.h (redraw_garbaged_frames, scrolling):
4007 (increment_row_positions): Remove.
4008 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4009 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4010 Now static.
4011 (redraw_garbaged_frames): Remove; unused.
4012
4013 * xfaces.c: Make symbols static if they're not exported.
4014 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4015 Remove decls.
4016 * xterm.h (defined_color): Remove decls.
4017 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4018 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4019 (menu_face_changed_default, defined_color, free_realized_face):
4020 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4021 (ascii_face_of_lisp_face): Remove; unused.
4022
4023 * xdisp.c: Make symbols static if they're not exported.
4024 * dispextern.h (scratch_glyph_row, window_box_edges):
4025 (glyph_to_pixel_coords, set_cursor_from_row):
4026 (get_next_display_element, set_iterator_to_next):
4027 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4028 (show_mouse_face): Remove decls
4029 * frame.h (message_buf_print): Likewise.
4030 * lisp.h (pop_message, set_message, check_point_in_composition):
4031 Likewise.
4032 * xterm.h (set_vertical_scroll_bar): Likewise.
4033 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4034 (message_buf_print, scratch_glyph_row, displayed_buffer):
4035 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4036 (get_next_display_element, show_mouse_face, window_box_edges):
4037 (frame_to_window_pixel_xy, check_point_in_composition):
4038 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4039 (glyph_to_pixel_coords): Remove; unused.
4040
4041 * dired.c (file_name_completion): Now static.
4042
4043 * dbusbind.c (xd_in_read_queued_messages): Now static.
4044
4045 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4046 * data.c (circular_list_error): Remove.
4047
4048 * commands.h (last_point_position, last_point_position_buffer):
4049 (last_point_position_window): Remove decls.
4050 * keyboard.c: Make these variables static.
4051
4052 * coding.h (coding, code_convert_region, encode_coding_gap):
4053 Remove decls.
4054 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4055 (iso_code_class, detect_coding, code_convert_region): Now static.
4056 (encode_coding_gap): Remove; unused.
4057
4058 * chartab.c (chartab_chars, chartab_bits): Now static.
4059
4060 * charset.h (charset_iso_8859_1): Remove decl.
4061 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4062 Now static.
4063
4064 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4065 * ccl.c (Vccl_program_table): Now static.
4066 (check_ccl_update): Remove; unused.
4067
4068 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4069 * category.h: ... from here.
4070 * category.c (check_category_table, set_category_set): Now static.
4071
4072 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4073 * lisp.h: Remove these decls.
4074
4075 * buffer.c (buffer_count): Remove unused var.
4076
4077 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4078 so that it's not optimized away.
4079 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4080 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4081 exported only to the debugger.
4082
4083 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4084 * atimer.h (run_all_atimers): Remove; not exported.
4085
4086 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4087 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4088 was inaccessible from Lisp.
4089 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4090 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4091
4092 alloc.c: Import and export fewer symbols, and remove unused items.
4093 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4094 is defined.
4095 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4096 it's not optimized away by whole-program optimization.
4097 (message_enable_multibyte, free_misc): Remove.
4098 (catchlist, handlerlist, mark_backtrace):
4099 Declare only if BYTE_MARK_STACK.
4100 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4101 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4102 (message_enable_multibyte): Remove decl.
4103 (free_misc, interval_free_list, float_block, float_block_index):
4104 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4105 (cons_free_list, last_marked_index):
4106 Now static.
4107 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4108 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4109 (mark_backtrace): Define only if BYTE_MARK_STACK.
4110 * xdisp.c (message_enable_multibyte): Now static.
4111
4112 Declare Lisp_Object Q* variables to be 'static' if not exported.
4113 This makes it easier for human readers (and static analyzers)
4114 to see whether these variables are used from other modules.
4115 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4116 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4117 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4118 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4119 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4120 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4121 * xmenu.c, xselect.c:
4122 Declare Q* vars static if they are not used in other modules.
4123 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4124 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4125 Remove decls of unexported vars.
4126 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4127
4128 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4129
4130 Make Emacs functions such as Fatom 'static' by default.
4131 This makes it easier for human readers (and static analyzers)
4132 to see whether these functions can be called from other modules.
4133 DEFUN now defines a static function. To make the function external
4134 so that it can be used in other C modules, use the new macro DEFUE.
4135 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4136 (Finit_image_library):
4137 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4138 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4139 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4140 Remove decls, since these functions are now static.
4141 (Funintern, Fget_internal_run_time): New decls, since these functions
4142 were already external.
4143
4144 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4145 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4146 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4147 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4148 * keyboard.c, keymap.c, lread.c:
4149 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4150 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4151 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4152 Mark functions with DEFUE instead of DEFUN,
4153 if they are used in other modules.
4154 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4155 decls for now-static functions.
4156 * buffer.h (Fdelete_overlay): Remove decl.
4157 * callproc.c (Fgetenv_internal): Mark as internal.
4158 * composite.c (Fremove_list_of_text_properties): Remove decl.
4159 (Fcomposition_get_gstring): New forward static decl.
4160 * composite.h (Fcomposite_get_gstring): Remove decl.
4161 * dired.c (Ffile_attributes): New forward static decl.
4162 * doc.c (Fdocumntation_property): New forward static decl.
4163 * eval.c (Ffetch_bytecode): New forward static decl.
4164 (Funintern): Remove extern decl; now in .h file where it belongs.
4165 * fileio.c (Fmake_symbolic_link): New forward static decl.
4166 * image.c (Finit_image_library): New forward static decl.
4167 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4168 * intervals.h (Fprevious_property_change):
4169 (Fremove_list_of_text_properties): Remove decls.
4170 * keyboard.c (Fthis_command_keys): Remove decl.
4171 (Fcommand_execute): New forward static decl.
4172 * keymap.c (Flookup_key): New forward static decl.
4173 (Fcopy_keymap): Now static.
4174 * keymap.h (Flookup_key): Remove decl.
4175 * process.c (Fget_process): New forward static decl.
4176 (Fprocess_datagram_address): Mark as internal.
4177 * syntax.c (Fsyntax_table_p): New forward static decl.
4178 (skip_chars): Remove duplicate decl.
4179 * textprop.c (Fprevious_property_change): New forward static decl.
4180 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4181 Now internal.
4182 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4183 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4184
4185 * editfns.c (Fformat): Remove unreachable code.
4186
41872011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4188
4189 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4190 change. (Bug#8496)
4191
41922011-04-13 Eli Zaretskii <eliz@gnu.org>
4193
4194 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4195 when at ZV. (Bug#8487)
4196
41972011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4198
4199 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4200 (Bug#8437)
4201 * keyboard.c (parse_tool_bar_item): Likewise.
4202 * sound.c (sound_cleanup, alsa_close): Likewise.
4203 * termcap.c (tgetent): Likewise.
4204 * xfns.c (x_default_font_parameter): Likewise.
4205 * xsettings.c (read_and_apply_settings): Likewise.
4206
4207 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4208 (overrun_check_free): Protoize.
4209
42102011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4211
4212 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4213 since callers should never pass a negative size.
4214 Change the signature to match that of plain 'read' and 'write'; see
4215 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4216 * lisp.h: Update prototypes of emacs_write and emacs_read.
4217
42182011-04-11 Eli Zaretskii <eliz@gnu.org>
4219
4220 * xdisp.c (redisplay_window): Don't try to determine the character
4221 position of the scroll margin if the window start point w->startp
4222 is outside the buffer's accessible region. (Bug#8468)
4223
42242011-04-10 Eli Zaretskii <eliz@gnu.org>
4225
4226 Fix write-region and its subroutines for buffers > 2GB.
4227 * fileio.c (a_write, e_write): Modify declaration of arguments and
4228 local variables to support buffers larger than 2GB.
4229 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4230
4231 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4232 argument, local variables, and return value.
4233
4234 * lisp.h: Update prototypes of emacs_write and emacs_read.
4235
4236 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4237
42382011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4239
4240 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4241
4242 Fix more problems found by GCC 4.6.0's static checks.
4243
4244 * xdisp.c (vmessage): Use a better test for character truncation.
4245
4246 * charset.c (load_charset_map): <, not <=, for optimization,
4247 and to avoid potential problems with integer overflow.
4248 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4249 * casetab.c (set_identity, shuffle): Likewise.
4250 * editfns.c (Fformat): Likewise.
4251 * syntax.c (skip_chars): Likewise.
4252
4253 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4254 This also lets GCC 4.6.0 generate slightly better loop code.
4255
4256 * callint.c (Fcall_interactively): <, not <=, for optimization.
4257 (Fcall_interactively): Count the number of arguments produced,
4258 not the number of arguments given. This is simpler and lets GCC
4259 4.6.0 generate slightly better code.
4260
4261 * ftfont.c: Distingish more carefully between FcChar8 and char.
4262 The previous code passed unsigned char * to a functions like
4263 strlen and xstrcasecmp that expect char *, which does not
4264 conform to the C standard.
4265 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4266 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4267 char * when the C standard requires it.
4268
4269 * keyboard.c (read_char): Remove unused var.
4270
4271 * eval.c: Port to Windows vsnprintf (Bug#8435).
4272 Include <limits.h>.
4273 (SIZE_MAX): Define if the headers do not.
4274 (verror): Do not give up if vsnprintf returns a negative count.
4275 Instead, grow the buffer. This ports to Windows vsnprintf, which
4276 does not conform to C99. Problem reported by Eli Zaretskii.
4277 Also, simplify the allocation scheme, by avoiding the need for
4278 calling realloc, and removing the ALLOCATED variable.
4279
4280 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4281
4282 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4283 But keep the doprint source code for now, as we might revamp it
4284 and use it again (Bug#8435).
4285 * lisp.h (doprnt): Remove.
4286 * Makefile.in (base_obj): Remove doprnt.o.
4287 * deps.mk (doprnt.o): Remove.
4288
4289 error: Print 32- and 64-bit integers portably (Bug#8435).
4290 Without this change, on typical 64-bit hosts error ("...%d...", N)
4291 was used to print both 32- and 64-bit integers N, which relied on
4292 undefined behavior.
4293 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4294 New macro.
4295 * lisp.h (error, verror): Mark as printf-like functions.
4296 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4297 Report overflow in size calculations when allocating printf buffer.
4298 Do not truncate output string at its first null byte.
4299 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4300 Truncate the output at a character boundary, since vsnprintf does not
4301 do that.
4302 * charset.c (check_iso_charset_parameter): Convert internal
4303 character to string before calling 'error', since %c now has the
4304 printf meaning.
4305 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4306 overflow when computing char to be passed to 'error'. Do not
4307 pass Lisp_Object to 'error'; pass the integer instead.
4308 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4309 formatted with plain %d.
4310
4311 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4312
4313 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4314
4315 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4316
4317 * xterm.c (x_catch_errors): Remove duplicate declaration.
4318
4319 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4320
4321 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4322
43232011-04-10 Jim Meyering <meyering@redhat.com>
4324
4325 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4326 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4327 return ssize_t not "int", and use size_t as the buffer length.
4328 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4329 * gnutls.h: Update declarations.
4330 * process.c (read_process_output): Use ssize_t, to match.
4331 (send_process): Likewise.
4332
43332011-04-09 Chong Yidong <cyd@stupidchicken.com>
4334
4335 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4336
43372011-04-09 Chong Yidong <cyd@stupidchicken.com>
4338
4339 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4340 Use unsigned char, to match FcChar8 type definition.
4341
4342 * xterm.c (handle_one_xevent):
4343 * xmenu.c (create_and_show_popup_menu):
4344 * xselect.c (x_decline_selection_request)
4345 (x_reply_selection_request): Avoid type-punned deref of X events.
4346
43472011-04-09 Eli Zaretskii <eliz@gnu.org>
4348
4349 Fix some uses of `int' instead of EMACS_INT.
4350 * search.c (string_match_1, fast_string_match)
4351 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4352 (scan_buffer, find_next_newline_no_quit)
4353 (find_before_next_newline, search_command, Freplace_match)
4354 (Fmatch_data): Make some `int' variables be EMACS_INT.
4355
4356 * xdisp.c (display_count_lines): 3rd argument and return value now
4357 EMACS_INT. All callers changed.
4358 (pint2hrstr): Last argument is now EMACS_INT.
4359
4360 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4361 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4362 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4363 (decode_coding_utf_16, decode_coding_emacs_mule)
4364 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4365 (decode_coding_ccl, decode_coding_charset)
4366 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4367 (decode_coding_iso_2022, decode_coding_emacs_mule)
4368 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4369 <char_offset, last_offset>: Declare EMACS_INT.
4370 (encode_coding_utf_8, encode_coding_utf_16)
4371 (encode_coding_emacs_mule, encode_invocation_designation)
4372 (encode_designation_at_bol, encode_coding_iso_2022)
4373 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4374 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4375 Declare EMACS_INT.
4376 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4377 (encode_invocation_designation): Last argument P_NCHARS is now
4378 EMACS_INT.
4379 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4380 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4381
4382 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4383 All users changed.
4384
4385 * ccl.c (Fccl_execute_on_string): Declare some variables
4386 EMACS_INT.
4387
43882011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4389
4390 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4391
43922011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4393
4394 * process.c (Fformat_network_address): Doc fix.
4395
43962011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4397
4398 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4399
44002011-04-08 Chong Yidong <cyd@stupidchicken.com>
4401
4402 * keyboard.c (read_char): Call Lisp function help-form-show,
4403 instead of using internal_with_output_to_temp_buffer.
4404 (Qhelp_form_show): New var.
4405 (syms_of_keyboard): Use DEFSYM macro.
4406
4407 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4408
4409 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4410
44112011-04-06 Chong Yidong <cyd@stupidchicken.com>
4412
4413 * process.c (Flist_processes): Remove to Lisp.
4414 (list_processes_1): Delete.
4415
44162011-04-06 Eli Zaretskii <eliz@gnu.org>
4417
4418 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4419
4420 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4421
44222011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4423
4424 Fix more problems found by GCC 4.6.0's static checks.
4425
4426 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4427
4428 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4429
4430 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4431
4432 * xdisp.c (vmessage): Mark as a printf-like function.
4433
4434 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4435
4436 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4437
4438 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4439 printf-like functions.
4440 (tiff_load): Add casts to remove these marks before passing them
4441 to system-supplied API.
4442
4443 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4444
4445 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4446 This avoids several warnings with gcc -Wstrict-overflow.
4447 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4448 directly, rather than having caller test rule sign. This avoids
4449 some unnecessary tests.
4450 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4451 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4452 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4453
4454 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4455 (xfont_open): Avoid unnecessary tests.
4456
4457 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4458
4459 * composite.h, composite.c (composition_gstring_put_cache):
4460 Use EMACS_INT, not int, for length.
4461
4462 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4463 breaking out part of COMPOSITION_DECODE_RULE.
4464 (COMPOSITION_DECODE_RULE): Use it.
4465 * composite.c (get_composition_id): Remove unused local vars,
4466 by using the new macro.
4467
4468 * textprop.c (set_text_properties_1): Change while to do-while,
4469 since the condition is always true at first.
4470
4471 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4472 (interval_deletion_adjustment): Return unsigned value.
4473 All uses changed.
4474
4475 * process.c (list_processes_1, create_pty, read_process_output):
4476 (exec_sentinel): Remove vars that were set but not used.
4477 (create_pty): Remove unnecessary "volatile"s.
4478 (Fnetwork_interface_info): Avoid possibility of int overflow.
4479 (read_process_output): Do adaptive read buffering even if carryover.
4480 (read_process_output): Simplify nbytes computation if buffered.
4481
4482 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4483
4484 * syntax.c (scan_words): Remove var that was set but not used.
4485 (update_syntax_table): Use unsigned instead of int.
4486
4487 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4488 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4489 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4490
4491 * print.c (print_error_message): Avoid int overflow.
4492
4493 * font.c (font_list_entities): Redo for clarity,
4494 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4495
4496 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4497 (font_score): Avoid potential overflow in diff calculation.
4498
4499 * fns.c (substring_both): Remove var that is set but not used.
4500 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4501
4502 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4503
4504 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4505 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4506 can always succeed if overflow has undefined behavior.
4507
4508 * search.c (boyer_moore, wordify): Remove vars set but not used.
4509 (wordify): Omit three unnecessary tests.
4510
4511 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4512 All callers changed. This avoids the need for an unused var.
4513
4514 * casefiddle.c (casify_region): Remove var that is set but not used.
4515
4516 * dired.c (file_name_completion): Remove var that is set but not used.
4517
4518 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4519
4520 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4521 (Finsert_file_contents): Remove unnecessary code checking fd.
4522
4523 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4524 Check for integer overflow on size calculations.
4525
4526 * buffer.c (Fprevious_overlay_change): Remove var that is set
4527 but not used.
4528
4529 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4530 Remove vars that are set but not used.
4531 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4532 (timer_check_2): Mark vars as initialized.
4533
4534 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4535
4536 * image.c (lookup_image): Remove var that is set but not used.
4537 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4538
4539 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4540 that are set but not used.
4541
4542 * xfns.c (make_invisible_cursor): Don't return garbage
4543 if XCreateBitmapFromData fails (Bug#8410).
4544
4545 * xselect.c (x_get_local_selection, x_handle_property_notify):
4546 Remove vars that are set but not used.
4547
4548 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4549 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4550
4551 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4552 Remove var that is set but not used.
4553 (scroll_bar_windows_size): Now size_t, not int.
4554 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4555 Check for overflow.
4556
4557 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4558 (map_tty_color) [!defined MSDOS]: Likewise.
4559
4560 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4561
4562 * coding.c: Remove vars that are set but not used.
4563 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4564 All callers changed.
4565 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4566 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4567 (decode_coding_charset): Remove vars that are set but not used.
4568
4569 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4570 that is set but not used.
4571
4572 * print.c (print_object): Remove var that is set but not used.
4573
4574 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4575 The gnulib version avoids calling malloc in the usual case,
4576 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4577 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4578 * filelock.c (current_lock_owner): Likewise.
4579 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4580 * sysdep.c: Include allocator.h, careadlinkat.h.
4581 (emacs_no_realloc_allocator): New static constant.
4582 (emacs_readlink): New function.
4583 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4584 ../lib/careadlinkat.h.
4585
45862011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4587
4588 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4589 first non-nil return value).
4590
45912011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4592
4593 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4594 if not defined (Bug#8403).
4595
45962011-04-02 Juanma Barranquero <lekktu@gmail.com>
4597
4598 * xdisp.c (display_count_lines): Remove parameter `start',
4599 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4600 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4601 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4602 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4603 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4604 and thereabouts. All callers changed.
4605 (get_per_char_metric): Remove parameter `f', unused since
4606 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4607
46082011-04-02 Jim Meyering <meyering@redhat.com>
4609
4610 do not dereference NULL upon failed strdup
4611 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4612 (ns_get_family): Likewise.
4613
46142011-04-02 Juanma Barranquero <lekktu@gmail.com>
4615
4616 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4617
46182011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4619
4620 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4621 later (Bug#8403).
4622
46232011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4624
4625 Add lexical binding.
4626
4627 * window.c (Ftemp_output_buffer_show): New fun.
4628 (Fsave_window_excursion):
4629 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4630
4631 * lread.c (lisp_file_lexically_bound_p): New function.
4632 (Fload): Bind Qlexical_binding.
4633 (readevalloop): Remove `evalfun' arg.
4634 Bind Qinternal_interpreter_environment.
4635 (Feval_buffer): Bind Qlexical_binding.
4636 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4637 Mark as dynamic.
4638 (syms_of_lread): Declare `lexical-binding'.
4639
4640 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4641
4642 * keyboard.c (eval_dyn): New fun.
4643 (menu_item_eval_property): Use it.
4644
4645 * image.c (parse_image_spec): Use Ffunctionp.
4646
4647 * fns.c (concat, mapcar1): Accept byte-code-functions.
4648
4649 * eval.c (Fsetq): Handle lexical vars.
4650 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4651 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4652 (FletX, Flet): Obey lexical binding.
4653 (Fcommandp): Handle closures.
4654 (Feval): New `lexical' arg.
4655 (eval_sub): New function extracted from Feval. Use it almost
4656 everywhere where Feval was used. Look up vars in lexical env.
4657 Handle closures.
4658 (Ffunctionp): Move from subr.el.
4659 (Ffuncall): Handle closures.
4660 (apply_lambda): Remove `eval_flags'.
4661 (funcall_lambda): Handle closures and new byte-code-functions.
4662 (Fspecial_variable_p): New function.
4663 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4664 but without exporting it to Lisp.
4665
4666 * doc.c (Fdocumentation, store_function_docstring):
4667 * data.c (Finteractive_form): Handle closures.
4668
4669 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4670 interactive spec.
4671
4672 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4673 New byte-codes.
4674 (exec_byte_code): New function extracted from Fbyte_code to handle new
4675 calling convention for byte-code-functions. Add new byte-codes.
4676
4677 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4678
4679 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4680
46812011-03-31 Juanma Barranquero <lekktu@gmail.com>
4682
4683 * xdisp.c (redisplay_internal): Fix prototype.
4684
46852011-03-31 Eli Zaretskii <eliz@gnu.org>
4686
4687 * xdisp.c (SCROLL_LIMIT): New macro.
4688 (try_scrolling): Use it when setting scroll_limit.
4689 Limit scrolling to 100 screen lines.
4690 (redisplay_window): Even when falling back on "recentering",
4691 position point in the window according to scroll-conservatively,
4692 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4693
4694 (try_scrolling): When point is above the window, allow searching
4695 as far as scroll_max, or one screenful, to compute vertical
4696 distance from PT to the scroll margin position. This prevents
4697 try_scrolling from unnecessarily failing when
4698 scroll-conservatively is set to a value slightly larger than the
4699 window height. Clean up the case of PT below the margin at bottom
4700 of window: scroll_max can no longer be INT_MAX. When aggressive
4701 scrolling is in use, don't let point enter the opposite scroll
4702 margin as result of the scroll.
4703 (syms_of_xdisp) <scroll-conservatively>: Document the
4704 threshold of 100 lines for never-recentering scrolling.
4705
47062011-03-31 Juanma Barranquero <lekktu@gmail.com>
4707
4708 * dispextern.h (move_it_by_lines):
4709 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4710 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4711 (message_log_check_duplicate): Remove parameters `prev_bol' and
4712 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4713 (redisplay_internal): Remove parameter `preserve_echo_area',
4714 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4715
4716 * indent.c (Fvertical_motion):
4717 * window.c (window_scroll_pixel_based, Frecenter):
4718 Don't pass `need_y_p' to `move_it_by_lines'.
4719
47202011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4721
4722 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4723 steal a few bits to be more compact.
4724 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4725 Remove unneeded casts.
4726
4727 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4728
47292011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4730
4731 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4732 binding" message (bug#7967).
4733
47342011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4735
4736 Fix more problems found by GCC 4.6.0's static checks.
4737
4738 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4739 Remove unused local var.
4740
4741 * editfns.c (Fmessage_box): Remove unused local var.
4742
4743 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4744 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4745 Omit unused local vars.
4746 * window.c (shrink_windows): Omit unused local var.
4747 * menu.c (digest_single_submenu): Omit unused local var.
4748 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4749 Omit unused local var.
4750
4751 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4752 Don't assume string length fits in int.
4753 (keyremap_step, read_key_sequence): Use size_t for sizes.
4754 (read_key_sequence): Don't check last_real_key_start redundantly.
4755
4756 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4757 instead of alloca (Bug#8344).
4758
4759 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4760 (Fbacktrace_frame): Don't assume nframes fits in int.
4761
4762 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4763
4764 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4765 concerns.
4766
4767 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4768
4769 * cm.c (calccost): Turn while-do into do-while, for clarity.
4770
4771 * keyboard.c (syms_of_keyboard): Use the same style as later
4772 in this function when indexing through an array. This also
4773 works around GCC bug 48267.
4774
4775 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4776
4777 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4778
4779 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4780 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4781
4782 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4783 This avoids undefined behavior on integer overflow, and is a bit
4784 more convenient anyway since it is compared to a size_t variable.
4785
4786 Variadic C functions now count arguments with size_t, not int.
4787 This avoids an unnecessary limitation on 64-bit machines, which
4788 caused (substring ...) to crash on large vectors (Bug#8344).
4789 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4790 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4791 All variadic functions and their callers changed accordingly.
4792 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4793 * data.c (arith_driver, float_arith_driver): Likewise.
4794 * editfns.c (general_insert_function): Likewise.
4795 * eval.c (struct backtrace.nargs, interactive_p)
4796 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4797 (funcall_lambda, mark_backtrace): Likewise.
4798 * fns.c (concat): Likewise.
4799 * frame.c (x_set_frame_parameters): Likewise.
4800 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4801 0 if not found, not -1. All callers changed.
4802
4803 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4804 (stack_copy_size): Now size_t, not int.
4805 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4806
48072011-03-28 Juanma Barranquero <lekktu@gmail.com>
4808
4809 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4810 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4811 All callers changed.
4812
4813 * lisp.h (multibyte_char_to_unibyte):
4814 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4815 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4816 * character.h (CHAR_TO_BYTE8):
4817 * cmds.c (internal_self_insert):
4818 * editfns.c (general_insert_function):
4819 * keymap.c (push_key_description):
4820 * search.c (Freplace_match):
4821 * xdisp.c (message_dolog, set_message_1): All callers changed.
4822
48232011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4824
4825 * keyboard.c (safe_run_hook_funcall): New function.
4826 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4827 don't set the hook to nil, but remove the offending function instead.
4828 (Qcommand_hook_internal): Remove, unused.
4829 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4830 Vcommand_hook_internal.
4831
4832 * eval.c (enum run_hooks_condition): Remove.
4833 (funcall_nil, funcall_not): New functions.
4834 (run_hook_with_args): Call each function through a `funcall' argument.
4835 Remove `cond' argument, now redundant.
4836 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4837 (Frun_hook_with_args_until_failure): Adjust accordingly.
4838 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4839
48402011-03-28 Juanma Barranquero <lekktu@gmail.com>
4841
4842 * dispextern.h (string_buffer_position): Remove declaration.
4843
4844 * print.c (strout): Remove parameter `multibyte', unused since
4845 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4846
4847 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4848 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4849 All callers changed.
4850
4851 * w32.c (_wsa_errlist): Use braces for struct initializers.
4852
4853 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4854 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4855 All callers changed.
4856 (string_buffer_position): Likewise. Also, make static (it's never
4857 used outside xdisp.c).
4858 (cursor_row_p): Remove parameter `w', unused since
4859 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4860 (decode_mode_spec): Remove parameter `precision', introduced during
4861 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4862 All callers changed.
4863
48642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4865
4866 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4867
48682011-03-27 Anders Lindgren <andlind@gmail.com>
4869
4870 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4871 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4872 (ns_update_auto_hide_menu_bar): New functions.
4873 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4874 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4875 ns_constrain_all_frames.
4876 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4877 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4878
48792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4880
4881 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4882
48832011-03-27 Glenn Morris <rgm@gnu.org>
4884
4885 * syssignal.h: Replace RETSIGTYPE with void.
4886 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4887 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4888 Replace SIGTYPE with void everywhere.
4889 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4890 * s/template.h (SIGTYPE): Remove commented out definition.
4891
48922011-03-26 Eli Zaretskii <eliz@gnu.org>
4893
4894 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4895 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4896
48972011-03-26 Juanma Barranquero <lekktu@gmail.com>
4898
4899 * w32.c (read_unc_volume): Use parameter `henum', instead of
4900 global variable `wget_enum_handle'.
4901
4902 * keymap.c (describe_vector): Remove parameters `indices' and
4903 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4904 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4905
4906 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4907
4908 * keyboard.c (timer_check): Remove parameter `do_it_now',
4909 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4910 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4911 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4912
4913 * keyboard.c (read_char):
4914 * w32menu.c (w32_menu_display_help):
4915 * xmenu.c (show_help_event, menu_help_callback):
4916 Adjust calls to `show_help_echo'.
4917
4918 * gtkutil.c (xg_maybe_add_timer):
4919 * keyboard.c (readable_events):
4920 * process.c (wait_reading_process_output):
4921 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4922
4923 * insdel.c (adjust_markers_gap_motion):
4924 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4925 (gap_left, gap_right): Don't call it.
4926
49272011-03-25 Chong Yidong <cyd@stupidchicken.com>
4928
4929 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4930 incurred during fontification.
4931
49322011-03-25 Juanma Barranquero <lekktu@gmail.com>
4933
4934 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4935 (DEFVAR_PER_BUFFER): Don't pass it.
4936
4937 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4938 (scrolling_window): Don't pass it.
4939
49402011-03-25 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4943
4944 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4945 and `suffix'.
4946 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4947 of variables specific to SELinux and computation of `encoded_absname'.
4948
4949 * image.c (XPutPixel): Remove unused variable `height'.
4950
4951 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4952
4953 * unexw32.c (get_section_info): Remove unused variable `section'.
4954
4955 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4956 (system_process_attributes): Remove unused variable `sess'.
4957 (sys_read): Remove unused variable `err'.
4958
4959 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4960 (w32_wnd_proc): Remove unused variable `isdead'.
4961 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4962 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4963 (x_create_tip_frame): Remove unused variable `tem'.
4964
4965 * w32inevt.c (w32_console_read_socket):
4966 Remove unused variable `no_events'.
4967
4968 * w32term.c (x_draw_composite_glyph_string_foreground):
4969 Remove unused variable `width'.
4970
49712011-03-24 Juanma Barranquero <lekktu@gmail.com>
4972
4973 * w32term.c (x_set_glyph_string_clipping):
4974 Don't pass uninitialized region to CombineRgn.
4975
49762011-03-23 Juanma Barranquero <lekktu@gmail.com>
4977
4978 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4979 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4980 (Fx_close_connection): Remove unused variable `i'.
4981
4982 * w32font.c (w32font_draw): Return number of glyphs.
4983 (w32font_open_internal): Remove unused variable `i'.
4984 (w32font_driver): Add missing initializer.
4985
4986 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4987 (fill_in_menu): Remove unused variable `items_added'.
4988
4989 * w32term.c (last_mouse_press_frame): Remove static global variable.
4990 (w32_clip_to_row): Remove unused variable `f'.
4991 (x_delete_terminal): Remove unused variable `i'.
4992
4993 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4994 (NOTHING): Remove unused static global variable.
4995 (uniscribe_check_otf): Remove unused variable `table'.
4996 (uniscribe_font_driver): Add missing initializers.
4997
49982011-03-23 Julien Danjou <julien@danjou.info>
4999
5000 * term.c (Fsuspend_tty, Fresume_tty):
5001 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5002 * window.c (temp_output_buffer_show):
5003 * insdel.c (signal_before_change):
5004 * frame.c (Fhandle_switch_frame):
5005 * fileio.c (Fdo_auto_save):
5006 * emacs.c (Fkill_emacs):
5007 * editfns.c (save_excursion_restore):
5008 * cmds.c (internal_self_insert):
5009 * callint.c (Fcall_interactively):
5010 * buffer.c (Fkill_all_local_variables):
5011 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5012 Use Frun_hooks.
5013 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5014 unconditionnaly since it does the check itself.
5015
50162011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5017
5018 Fix more problems found by GCC 4.5.2's static checks.
5019
5020 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5021 the first time through the loop, since we know p0 < p1 then.
5022 This also avoids a gcc -Wstrict-overflow warning.
5023
5024 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5025 leading to a memory leak, possible in functions like
5026 load_charset_map_from_file that can allocate an unbounded number
5027 of objects (Bug#8318).
5028
5029 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5030 that could (at least in theory) be that large.
5031
5032 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5033 This is less likely to overflow, and avoids undefined behavior if
5034 overflow does occur. All callers changed. Use strtoul to scan
5035 for the unsigned long integer.
5036 (pint2hrstr): Simplify and tune code slightly.
5037 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5038
5039 * scroll.c (do_scrolling): Work around GCC bug 48228.
5040 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5041
5042 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5043 This also avoids a warning with gcc -Wstrict-overflow.
5044 (validate_x_resource_name): Simplify count usage.
5045 This also avoids a warning with gcc -Wstrict-overflow.
5046
5047 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5048 fail (Bug#8306).
5049
5050 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5051
5052 * process.c (Fmake_network_process): Use socklen_t, not int,
5053 where POSIX says socklen_t is required in portable programs.
5054 This fixes a porting bug on hosts like 64-bit HP-UX, where
5055 socklen_t is wider than int (Bug#8277).
5056 (Fmake_network_process, server_accept_connection):
5057 (wait_reading_process_output, read_process_output):
5058 Likewise.
5059
5060 * process.c: Rename or move locals to avoid shadowing.
5061 (list_processes_1, Fmake_network_process):
5062 (read_process_output_error_handler, exec_sentinel_error_handler):
5063 Rename or move locals.
5064 (Fmake_network_process): Define label "retry_connect" only if needed.
5065 (Fnetwork_interface_info): Fix pointer signedness.
5066 (process_send_signal): Add cast to avoid pointer signedness problem.
5067 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5068 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5069
5070 Make tparam.h and terminfo.c consistent.
5071 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5072 Include tparam.h instead, since it declares them.
5073 * cm.h (PC): Remove extern decl; tparam.h now does this.
5074 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5075 * terminfo.c: Include tparam.h, to check interfaces.
5076 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5077 (tparam): Adjust signature to match interface in tparam.h;
5078 this removes some undefined behavior. Check that outstring and len
5079 are zero, which they always are with Emacs.
5080 * tparam.h (PC, BC, UP): New extern decls.
5081
5082 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5083 (xftfont_open): Rename locals to avoid shadowing.
5084
5085 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5086 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5087 (OTF_TAG_SYM): Omit macro if not needed.
5088 (ftfont_list): Remove unused local.
5089 (get_adstyle_property, ftfont_pattern_entity):
5090 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5091 Rename locals to avoid shadowing.
5092
5093 * xfont.c (xfont_list_family): Mark var as initialized.
5094
5095 * xml.c (make_dom): Now static.
5096
5097 * composite.c (composition_compute_stop_pos): Rename local to
5098 avoid shadowing.
5099 (composition_reseat_it): Remove unused locals.
5100 (find_automatic_composition, composition_adjust_point): Likewise.
5101 (composition_update_it): Mark var as initialized.
5102 (find_automatic_composition): Mark vars as initialized,
5103 with a FIXME (Bug#8290).
5104
5105 character.h: Rename locals to avoid shadowing.
5106 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5107 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5108 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5109 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5110 to avoid shadowing.
5111
5112 * textprop.c (property_change_between_p): Remove; unused.
5113
5114 * intervals.c (interval_start_pos): Now static.
5115
5116 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5117
5118 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5119 Rename locals to avoid shadowing.
5120
5121 * sound.c (wav_play, au_play, Fplay_sound_internal):
5122 Fix pointer signedness.
5123 (alsa_choose_format): Remove unused local var.
5124 (wav_play): Initialize a variable to 0, to prevent undefined
5125 behavior (Bug#8278).
5126
5127 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5128
5129 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5130
5131 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5132 clobbering (Bug#8298).
5133 * sysdep.c (sys_subshell): Likewise.
5134 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5135
5136 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5137 This should get cleaned up, so that child_setup has the
5138 same signature on all platforms.
5139
5140 * callproc.c (call_process_cleanup): Now static.
5141 (relocate_fd): Rename locals to avoid shadowing.
5142
51432011-03-22 Chong Yidong <cyd@stupidchicken.com>
5144
5145 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5146 not to be necessary, and produces flickering.
5147
51482011-03-20 Glenn Morris <rgm@gnu.org>
5149
5150 * config.in: Remove file.
5151
51522011-03-20 Juanma Barranquero <lekktu@gmail.com>
5153
5154 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5155 are now in src/globals.h.
5156 (syms_of_minibuf): Remove spurious & from previous change.
5157
51582011-03-20 Leo <sdl.web@gmail.com>
5159
5160 * minibuf.c (completing-read-function): New variable.
5161 (completing-read-default): Rename from completing-read.
5162 (completing-read): Call completing-read-function.
5163
51642011-03-19 Juanma Barranquero <lekktu@gmail.com>
5165
5166 * xfaces.c (Fx_load_color_file):
5167 Read color file from absolute filename (bug#8250).
5168
51692011-03-19 Juanma Barranquero <lekktu@gmail.com>
5170
5171 * makefile.w32-in: Update dependencies.
5172
51732011-03-17 Eli Zaretskii <eliz@gnu.org>
5174
5175 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5176
51772011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5178
5179 Fix more problems found by GCC 4.5.2's static checks.
5180
5181 * process.c (make_serial_process_unwind, send_process_trap):
5182 (sigchld_handler): Now static.
5183
5184 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5185 That way, the code declares only the vars that it needs.
5186 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5187 * s/cygwin.h (PTY_ITERATION): Likewise.
5188 * s/darwin.h (PTY_ITERATION): Likewise.
5189 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5190
5191 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5192 * process.c (allocate_pty): Don't declare stb unless it's needed.
5193
5194 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5195 (CONSTANTLIM): Remove; unused.
5196 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5197 Define only if needed.
5198
5199 * unexelf.c (unexec): Name an expression,
5200 to avoid gcc -Wbad-function-cast warning.
5201 Use a different way to cause a compilation error if anyone uses
5202 n rather than nn, a way that does not involve shadowing.
5203 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5204
5205 * deps.mk (unexalpha.o): Remove; unused.
5206
5207 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5208 * unexec.h: New file.
5209 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5210 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5211 Depend on unexec.h.
5212 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5213 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5214 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5215 Change as necessary to match prototype in unexec.h.
5216
5217 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5218 shadowing.
5219 (back_comment, skip_chars): Mark vars as initialized.
5220
5221 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5222 Rename locals to avoid shadowing.
5223
5224 * lread.c (read1): Rewrite so as not to use empty "else".
5225 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5226
5227 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5228
5229 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5230 warning when compiling print.c.
5231
5232 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5233 instead of using an uninitialized var.
5234 (font_sort_entities): Mark var as initialized.
5235
5236 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5237
5238 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5239 pointers to constants.
5240 (font_parse_fcname): Remove unused vars.
5241 (font_delete_unmatched): Now static.
5242 (font_get_spec): Remove; unused.
5243 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5244 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5245 Rename or move locals to avoid shadowing.
5246
5247 * fns.c (require_nesting_list, require_unwind): Now static.
5248 (Ffillarray): Rename locals to avoid shadowing.
5249
5250 * floatfns.c (domain_error2): Define only if needed.
5251 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5252
5253 * alloc.c (mark_backtrace): Move decl from here ...
5254 * lisp.h: ... to here, so that it can be checked.
5255
5256 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5257 (Fdefvar): Rewrite so as not to use empty "else".
5258 (lisp_indirect_variable): Name an expression,
5259 to avoid gcc -Wbad-function-cast warning.
5260 (Fdefvar): Rename locals to avoid shadowing.
5261
5262 * callint.c (quotify_arg, quotify_args): Now static.
5263 (Fcall_interactively): Rename locals to avoid shadowing.
5264 Use const pointer when appropriate.
5265
5266 * lisp.h (get_system_name, get_operating_system_release):
5267 Move decls here, to check interfaces.
5268 * process.c (get_operating_system_release): Move decl to lisp.h.
5269 * xrdb.c (get_system_name): Likewise.
5270 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5271 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5272 some of which prompt warnings from gcc -Wbad-function-cast.
5273 (Fformat_time_string, Fencode_time, Finsert_char):
5274 (Ftranslate_region_internal, Fformat):
5275 Rename or remove local vars to avoid shadowing.
5276 (Ftranslate_region_internal): Mark var as initialized.
5277
5278 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5279 avoid shadowing.
5280
5281 * lisp.h (eassert): Check that the argument compiles, even if
5282 ENABLE_CHECKING is not defined.
5283
5284 * data.c (Findirect_variable): Name an expression, to avoid
5285 gcc -Wbad-function-cast warning.
5286 (default_value, arithcompare, arith_driver, arith_error): Now static.
5287 (store_symval_forwarding): Rename local to avoid shadowing.
5288 (Fmake_variable_buffer_local, Fmake_local_variable):
5289 Mark variables as initialized.
5290 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5291
5292 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5293 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5294 Rename locals to avoid shadowing.
5295 (mark_stack): Move local variables into the #ifdef region where
5296 they're used.
5297 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5298 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5299 needed otherwise.
5300 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5301 (GC_STRING_CHARS): Remove; not used.
5302 (Fmemory_limit): Cast sbrk's returned value to char *.
5303
5304 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5305 avoids undefined behavior in theory.
5306
5307 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5308
5309 Use functions, not macros, for up- and down-casing (Bug#8254).
5310 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5311 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5312 to use the following functions instead of these macros.
5313 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5314 EMACS_INT, since callers assume the returned value fits in int.
5315 (upcase1): Likewise, for UPCASE_TABLE.
5316 (uppercasep, lowercasep, upcase): New static inline functions.
5317 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5318 the race-condition problem in the old DOWNCASE.
5319
5320 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5321 Rename locals to avoid shadowing.
5322 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5323 (regex_compile, re_search_2, re_match_2_internal):
5324 Remove unused local vars.
5325 (FREE_VAR): Rewrite so as not to use empty "else",
5326 which gcc can warn about.
5327 (regex_compile, re_match_2_internal): Mark locals as initialized.
5328 (RETALLOC_IF): Define only if needed.
5329 (WORDCHAR_P): Likewise. This one is never needed, but is used
5330 only in a comment talking about a compiler bug, so put inside
5331 the #if 0 of that comment.
5332 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5333 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5334 Remove; unused.
5335
5336 * search.c (boyer_moore): Rename locals to avoid shadowing.
5337 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5338 (PREV_CHAR_BOUNDARY): Likewise.
5339
5340 * search.c (simple_search): Remove unused var.
5341
5342 * dired.c (compile_pattern): Move decl from here ...
5343 * lisp.h: ... to here, so that it can be checked.
5344 (struct re_registers): New forward decl.
5345
5346 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5347
5348 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5349 All uses changed.
5350 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5351 Rename locals to avoid shadowing.
5352 (Fvertical_motion): Mark locals as initialized.
5353
5354 * casefiddle.c (casify_object, casify_region): Now static.
5355 (casify_region): Mark local as initialized.
5356
5357 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5358
5359 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5360 New macros, so that the caller can use some names other than
5361 gcpro1, gcpro2, etc.
5362 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5363 of the new macros.
5364 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5365 argument, for consistency with GCPRO2_VAR, etc: it is now the
5366 prefix of the variable, not the variable itself. All uses
5367 changed.
5368 * dired.c (directory_files_internal, file_name_completion):
5369 Rename locals to avoid shadowing.
5370
5371 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5372 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5373 dired.c's scmp function, had undefined behavior.
5374 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5375 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5376 * buffer.h: ... to here, because these macros use current_buffer,
5377 and the new implementation with inline functions needs to have
5378 current_buffer in scope now, rather than later when the macros
5379 are used.
5380 (downcase, upcase1): New static inline functions.
5381 (DOWNCASE, UPCASE1): Reimplement using these functions.
5382 This avoids undefined behavior in expressions like
5383 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5384 from race conditions in accessing the global variables
5385 case_temp1 and case_temp2.
5386 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5387 * lisp.h (case_temp1, case_temp2): Remove their decls.
5388 * character.h (ASCII_CHAR_P): Move from here ...
5389 * lisp.h: ... to here, so that the inline functions mentioned
5390 above can use them.
5391
5392 * dired.c (directory_files_internal_unwind): Now static.
5393
5394 * fileio.c (file_name_as_directory, directory_file_name):
5395 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5396 Now static.
5397 (file_name_as_directory): Use const pointers when appropriate.
5398 (Fexpand_file_name): Likewise. In particular, newdir might
5399 point at constant storage, so make it a const pointer.
5400 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5401 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5402 signedness issues.
5403 (Fset_file_times, Finsert_file_contents, auto_save_error):
5404 Rename locals to avoid shadowing.
5405
5406 * minibuf.c (choose_minibuf_frame_1): Now static.
5407 (Ftry_completion, Fall_completions): Rename or remove locals
5408 to avoid shadowing.
5409
5410 * marker.c (bytepos_to_charpos): Remove; unused.
5411
5412 * lisp.h (verify_bytepos, count_markers): New decls,
5413 so that gcc does not warn that these functions aren't declared.
5414
5415 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5416 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5417 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5418 (copy_text): Remove unused local var.
5419
5420 * filelock.c (within_one_second): Now static.
5421 (lock_file_1): Rename local to avoid shadowing.
5422
5423 * buffer.c (fix_overlays_before): Mark locals as initialized.
5424 (fix_start_end_in_overlays): Likewise. This function should be
5425 simplified by using pointers-to-pointers, but that's a different
5426 matter.
5427 (switch_to_buffer_1): Now static.
5428 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5429 (report_overlay_modification): Rename locals to avoid shadowing.
5430
5431 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5432 Fix pointer signedness issue.
5433 (sys_subshell): Mark local as volatile if checking for lint,
5434 to suppress a gcc -Wclobbered warning that does not seem to be right.
5435 (MAXPATHLEN): Define only if needed.
5436
5437 * process.c (serial_open, serial_configure): Move decls from here ...
5438 * systty.h: ... to here, so that they can be checked.
5439
5440 * fns.c (get_random, seed_random): Move extern decls from here ...
5441 * lisp.h: ... to here, so that they can be checked.
5442
5443 * sysdep.c (reset_io): Now static.
5444 (wait_for_termination_signal): Remove; unused.
5445
5446 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5447 (copy_keymap_item, append_key, push_text_char_description):
5448 Now static.
5449 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5450 (DENSE_TABLE_SIZE): Remove; unused.
5451 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5452 (describe_map_tree):
5453 Rename locals to avoid shadowing.
5454
5455 * keyboard.c: Declare functions static if they are not used elsewhere.
5456 (echo_char, echo_dash, cmd_error, top_level_2):
5457 (poll_for_input, handle_async_input): Now static.
5458 (read_char, kbd_buffer_get_event, make_lispy_position):
5459 (make_lispy_event, make_lispy_movement, apply_modifiers):
5460 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5461 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5462 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5463 (read_key_sequence, read_char): Mark locals as initialized.
5464 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5465
5466 * keyboard.h (make_ctrl_char): New decl.
5467 (mark_kboards): Move decl here ...
5468 * alloc.c (mark_kboards): ... from here.
5469
5470 * lisp.h (force_auto_save_soon): New decl.
5471
5472 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5473 (DEFINE_DUMMY_FUNCTION): New macro.
5474 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5475 Use it.
5476 (main): Add casts to avoid warnings
5477 if GCC considers string literals to be constants.
5478
5479 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5480
5481 * dbusbind.c: Pointer signedness fixes.
5482 (xd_signature, xd_append_arg, xd_initialize):
5483 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5484 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5485 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5486 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5487
5488 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5489 if GCC considers string literals to be constants.
5490 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5491
54922011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5493
5494 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5495 (print_preprocess, print_object): New macro to fix last change.
5496
5497 * print.c (print_preprocess): Don't forget font objects.
5498
54992011-03-16 Juanma Barranquero <lekktu@gmail.com>
5500
5501 * emacs.c (USAGE3): Doc fixes.
5502
55032011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5504
5505 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5506 structure.
5507
55082011-03-14 Juanma Barranquero <lekktu@gmail.com>
5509
5510 * lisp.h (VWindow_system, Qfile_name_history):
5511 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5512 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5513 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5514
5515 * w32select.c: Don't #include "keyboard.h".
5516 (run_protected): Add extern declaration for waiting_for_input.
5517
5518 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5519 * w32console.c (detect_input_pending, read_input_pending)
5520 (encode_terminal_code):
5521 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5522 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5523 (w32_system_caret_y, Qfile_name_history):
5524 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5525 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5526 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5527 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5528 * w32proc.c (Qlocal, report_file_error):
5529 * w32term.c (Vwindow_system, updating_frame):
5530 * w32uniscribe.c (initialized, uniscribe_font_driver):
5531 Remove unneeded extern declarations.
5532
55332011-03-14 Chong Yidong <cyd@stupidchicken.com>
5534
5535 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5536
55372011-03-13 Chong Yidong <cyd@stupidchicken.com>
5538
5539 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5540 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5541 These macros can no longer be used for assignment.
5542
5543 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5544 Assign struct members directly, instead of using BUF_BEGV etc.
5545 (record_buffer_markers, fetch_buffer_markers): New functions for
5546 recording and fetching special buffer markers.
5547 (set_buffer_internal_1, set_buffer_temp): Use them.
5548
5549 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5550
5551 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5552
5553 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5554 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5555
5556 * xdisp.c (hscroll_window_tree):
5557 (reconsider_clip_changes): Use PT instead of BUF_PT.
5558
55592011-03-13 Eli Zaretskii <eliz@gnu.org>
5560
5561 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5562 $(EMACS_ROOT)/lib/intprops.h.
5563
55642011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5565
5566 Fix more problems found by GCC 4.5.2's static checks.
5567
5568 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5569 to unsigned char * to avoid compiler diagnostic.
5570 (xg_free_frame_widgets): Make it clear that a local variable is
5571 needed only if USE_GTK_TOOLTIP.
5572 (gdk_window_get_screen): Make it clear that this macro is needed
5573 only if USE_GTK_TOOLTIP.
5574 (int_gtk_range_get_value): New function, which avoids a diagnostic
5575 from gcc -Wbad-function-cast.
5576 (xg_set_toolkit_scroll_bar_thumb): Use it.
5577 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5578 diagnostic from gcc -Wbad-function-cast.
5579 (get_utf8_string, xg_get_file_with_chooser):
5580 Rename locals to avoid shadowing.
5581 (create_dialog): Move locals to avoid shadowing.
5582
5583 * xgselect.c (xg_select): Remove unused var.
5584
5585 * image.c (four_corners_best): Mark locals as initialized.
5586 (gif_load): Initialize transparent_p to zero (Bug#8238).
5587 Mark another local as initialized.
5588 (my_png_error, my_error_exit): Mark with NO_RETURN.
5589
5590 * image.c (clear_image_cache): Now static.
5591 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5592 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5593 (x_edge_detection): Remove unnecessary cast that
5594 gcc -Wbad-function-cast diagnoses.
5595 (gif_load): Fix pointer signedness.
5596 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5597 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5598
55992011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5600
5601 Improve quality of tests for time stamp overflow.
5602 For example, without this patch (encode-time 0 0 0 1 1
5603 1152921504606846976) returns the obviously-bogus value (-948597
5604 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5605 reports time overflow. See
5606 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5607 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5608 * editfns.c: Include limits.h and intprops.h.
5609 (TIME_T_MIN, TIME_T_MAX): New macros.
5610 (time_overflow): Move earlier, to before first use.
5611 (hi_time, lo_time): New functions, for an accurate test for
5612 out-of-range times.
5613 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5614 (Fget_internal_run_time): Don't assume time_t fits in int.
5615 (make_time): Use list2 instead of Fcons twice.
5616 (Fdecode_time): More accurate test for out-of-range times.
5617 (check_tm_member): New function.
5618 (Fencode_time): Use it, to test for out-of-range times.
5619 (lisp_time_argument): Don't rely on undefined left-shift and
5620 right-shift behavior when checking for time stamp overflow.
5621
5622 * editfns.c (time_overflow): New function, refactoring common code.
5623 (Fformat_time_string, Fdecode_time, Fencode_time):
5624 (Fcurrent_time_string): Use it.
5625
5626 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5627 * dired.c (make_time): Move to ...
5628 * editfns.c (make_time): ... here.
5629 * systime.h: Note the move.
5630
56312011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5632
5633 * fringe.c (update_window_fringes): Remove unused variables.
5634
5635 * unexmacosx.c (copy_data_segment): Also copy __got section.
5636 (Bug#8223)
5637
56382011-03-12 Eli Zaretskii <eliz@gnu.org>
5639
5640 * termcap.c [MSDOS]: Include "msdos.h".
5641 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5642 Constify `char *' arguments and their references according to
5643 prototypes in tparam.h.
5644
5645 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5646
5647 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5648 Adapt all references accordingly.
5649
5650 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5651
56522011-03-11 Tom Tromey <tromey@redhat.com>
5653
5654 * buffer.c (syms_of_buffer): Remove obsolete comment.
5655
56562011-03-11 Eli Zaretskii <eliz@gnu.org>
5657
5658 * termhooks.h (encode_terminal_code): Declare prototype.
5659
5660 * msdos.c (encode_terminal_code): Don't declare prototype.
5661
5662 * term.c (encode_terminal_code): Now external again, used by
5663 w32console.c and msdos.c.
5664
5665 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5666 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5667
56682011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5669
5670 Fix some minor problems found by GCC 4.5.2's static checks.
5671
5672 * fringe.c (update_window_fringes): Mark locals as initialized
5673 (Bug#8227).
5674 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5675
5676 * alloc.c (mark_fringe_data): Move decl from here ...
5677 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5678 to check its interface.
5679 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5680
5681 * fontset.c (free_realized_fontset): Now static.
5682 (Fset_fontset_font): Rename local to avoid shadowing.
5683 (fontset_font): Mark local as initialized.
5684 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5685
5686 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5687
5688 * xselect.c (x_disown_buffer_selections): Remove; not used.
5689 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5690 (x_own_selection, Fx_disown_selection_internal): Rename locals
5691 to avoid shadowing.
5692 (x_handle_dnd_message): Remove local to avoid shadowing.
5693
5694 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5695 so that the caller can use some name other than gcpro1.
5696 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5697 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5698 (Fx_backspace_delete_keys_p):
5699 Use them to avoid shadowing, and rename vars to avoid shadowing.
5700 (x_decode_color, x_set_name, x_window): Now static.
5701 (Fx_create_frame): Add braces to silence GCC warning.
5702 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5703 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5704 Remove unused locals.
5705 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5706 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5707 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5708 macros.
5709
5710 * xterm.h (x_mouse_leave): New decl.
5711
5712 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5713 Remove unused functions.
5714 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5715 (x_calc_absolute_position): Now static.
5716 (XTread_socket): Don't define label "out" unless it's used.
5717 Don't declare local "event" unless it's used.
5718 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5719 unless they are used.
5720 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5721 (x_fatal_error_signal): Remove; not used.
5722 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5723 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5724 (x_error_catcher, x_connection_closed, x_error_handler):
5725 (x_error_quitter, xembed_send_message, x_iconify_frame):
5726 (my_log_handler): Rename locals to avoid shadowing.
5727 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5728 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5729
5730 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5731 Rename or move locals to avoid shadowing.
5732 (tty_defined_color, merge_face_heights): Now static.
5733 (free_realized_faces_for_fontset): Remove; not used.
5734 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5735 does not deduce is never used uninitialized.
5736 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5737 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5738
5739 * terminal.c (store_terminal_param): Now static.
5740
5741 * xmenu.c (menu_highlight_callback): Now static.
5742 (set_frame_menubar): Remove unused local.
5743 (xmenu_show): Rename parameter to avoid shadowing.
5744 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5745 since they might point to immutable storage.
5746 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5747 since it's unused otherwise.
5748
5749 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5750 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5751 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5752 avoids a gcc -Wuninitialized diagnostic.
5753 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5754 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5755 does not deduce are never used uninitialized.
5756
5757 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5758
5759 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5760 * window.c (window_loop, size_window):
5761 (run_window_configuration_change_hook, enlarge_window): Likewise.
5762
5763 * window.c (display_buffer): Now static.
5764 (size_window): Mark variables that gcc -Wuninitialized
5765 does not deduce are never used uninitialized.
5766 * window.h (check_all_windows): New decl, to forestall
5767 gcc -Wmissing-prototypes diagnostic.
5768 * dispextern.h (bidi_dump_cached_states): Likewise.
5769
5770 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5771 shadowing.
5772 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5773 Include <limits.h>.
5774 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5775 and to avoid gcc -Wuninitialized warning.
5776 (load_charset_map): Mark variables that gcc -Wuninitialized
5777 does not deduce are never used uninitialized.
5778 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5779
5780 * coding.c (coding_set_source, coding_set_destination):
5781 Use "else { /* comment */ }" rather than "else /* comment */;"
5782 for clarity, and to avoid gcc -Wempty-body warning.
5783 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5784 a block, when the outer 'i' will do.
5785 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5786 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5787 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5788 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5789 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5790 Rename locals to avoid shadowing.
5791 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5792 * coding.c (emacs_mule_char, encode_invocation_designation):
5793 Now static, since they're not used elsewhere.
5794 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5795 (decode_coding_object, encode_coding_object, detect_coding_system):
5796 (decode_coding_emacs_mule): Mark variables that gcc
5797 -Wuninitialized does not deduce are never used uninitialized.
5798 (detect_coding_iso_2022): Initialize a local variable that might
5799 be used uninitialized. Leave a FIXME because it's not clear that
5800 this initialization is needed. (Bug#8211)
5801 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5802 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5803 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5804 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5805 Remove unused macros.
5806
5807 * category.c (hash_get_category_set): Remove unused local var.
5808 (copy_category_table): Now static, since it's not used elsewhere.
5809 * character.c (string_count_byte8): Likewise.
5810
5811 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5812 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5813
5814 * chartab.c (copy_sub_char_table): Now static, since it's not used
5815 elsewhere.
5816 (sub_char_table_ref_and_range, char_table_ref_and_range):
5817 Rename locals to avoid shadowing.
5818 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5819
5820 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5821 (BIDI_BOB): Remove unused macro.
5822
5823 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5824 deduce are never used uninitialized.
5825 * term.c (encode_terminal_code): Likewise.
5826
5827 * term.c (encode_terminal_code): Now static. Remove unused local.
5828
5829 * tparam.h: New file.
5830 * term.c, tparam.h: Include it.
5831 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5832 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5833 Move these decls to tparam.h, and make them agree with what
5834 is actually in tparam.c. The previous trick of using incompatible
5835 decls in different modules does not conform to the C standard.
5836 All callers of tparam changed to use tparam's actual API.
5837 * tparam.c (tparam1, tparam, tgoto):
5838 Use const pointers where appropriate.
5839
5840 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5841 * cm.h (struct cm): Likewise.
5842 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5843 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5844 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5845 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5846 (turn_on_face, init_tty): Likewise.
5847 * termchar.h (struct tty_display_info): Likewise.
5848
5849 * term.c (term_mouse_position): Rename local to avoid shadowing.
5850
5851 * alloc.c (mark_ttys): Move decl from here ...
5852 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5853
58542011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5855
5856 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5857
58582011-03-09 Juanma Barranquero <lekktu@gmail.com>
5859
5860 * search.c (compile_pattern_1): Remove argument regp, unused since
5861 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5862 (compile_pattern): Don't pass it.
5863
58642011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5865
5866 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5867 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5868 for ! HAVE_GTK3.
5869 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5870
5871 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5872
5873 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5874 gdk_window_get_screen, gdk_window_get_geometry,
5875 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5876 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5877 (xg_get_pixbuf_from_pixmap): New function.
5878 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5879 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5880 Call xg_get_pixbuf_from_pixmap instead of
5881 gdk_pixbuf_get_from_drawable.
5882 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5883 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5884 (xg_check_special_colors): Use GtkStyleContext and its functions
5885 for HAVE_GTK3.
5886 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5887 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5888 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5889 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5890 Call gtk_widget_get_preferred_size.
5891 (xg_frame_resized): gdk_window_get_geometry only takes 5
5892 parameters.
5893 (xg_win_to_widget, xg_event_is_for_menubar):
5894 Call gdk_x11_window_lookup_for_display.
5895 (xg_set_widget_bg): New function.
5896 (delete_cb): New function.
5897 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5898 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5899 (xg_set_background_color): Call xg_set_widget_bg.
5900 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5901 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5902 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5903 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5904 if ! HAVE_GTK3.
5905 (update_frame_tool_bar): Call gtk_widget_hide.
5906 (xg_initialize): Use GDK_KEY_g.
5907
5908 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5909 if ! HAVE_GTK3
5910 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5911
5912 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5913 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5914 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5915
59162011-03-08 Juanma Barranquero <lekktu@gmail.com>
5917
5918 * w32xfns.c (select_palette): Check success of RealizePalette against
5919 GDI_ERROR, not zero.
5920
5921See ChangeLog.11 for earlier changes.
5922
5923;; Local Variables:
5924;; coding: utf-8
5925;; End:
5926
5927 Copyright (C) 2011 Free Software Foundation, Inc.
5928
5929 This file is part of GNU Emacs.
5930
5931 GNU Emacs is free software: you can redistribute it and/or modify
5932 it under the terms of the GNU General Public License as published by
5933 the Free Software Foundation, either version 3 of the License, or
5934 (at your option) any later version.
5935
5936 GNU Emacs is distributed in the hope that it will be useful,
5937 but WITHOUT ANY WARRANTY; without even the implied warranty of
5938 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5939 GNU General Public License for more details.
5940
5941 You should have received a copy of the GNU General Public License
5942 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.