Merge from mainline.
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2
3 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4 (emacs_read, emacs_write): Use it.
5
6 * process.c (send_process): Count partial writes as successes.
7 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8
9 emacs_write: Return size_t, not ssize_t, to avoid overflow issues.
10 * gnutls.c, gnutls.h (emacs_gnutls_write): Return size_t, not ssize_t.
11 * sysdep.c, lisp.h (emacs_write): Likewise.
12 Without the above change, emacs_gnutls_write and emacs_write had
13 undefined behavior and would typically mistakenly report an error
14 when writing a buffer whose size exceeds SSIZE_MAX.
15 (emacs_read, emacs_write): Remove check for negative size, as the
16 Emacs source code has been audited now.
17 (emacs_write): Adjust to new signature, making the code look more
18 like that of emacs_gnutls_write.
19 * process.c (send_process): Adjust to the new signatures of
20 emacs_write and emacs_gnutls_write. Do not attempt to store
21 a byte offset into an 'int'; it might overflow.
22
23 * sound.c: Don't assume sizes fit in 'int'.
24 (struct sound_device.period_size, alsa_period_size):
25 Return size_t, not int.
26 (struct sound_device.write, vox_write, alsa_write):
27 Accept size_t, not int.
28 (wav_play, au_play): Use size_t to store sizes, and ssize_t to
29 record read return values.
30
312011-04-15 Ben Key <bkey76@gmail.com>
32
33 * keyboard.c (Qundefined): Don't declare static since it is
34 used in nsfns.m.
35 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
36 declare static since they are used in nsfont.m.
37
382011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
39
40 * process.c (Qprocessp): Don't declare static.
41 * lisp.h (Qprocessp): Declare again.
42
432011-04-15 Juanma Barranquero <lekktu@gmail.com>
44
45 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
46
472011-04-14 Paul Eggert <eggert@cs.ucla.edu>
48
49 Improve C-level modularity by making more things 'static'.
50
51 Don't publish debugger-only interfaces to other modules.
52 * lisp.h (safe_debug_print, debug_output_compilation_hack):
53 (verify_bytepos, count_markers): Move decls to the only modules
54 that need them.
55 * region-cache.h (pp_cache): Likewise.
56 * window.h (check_all_windows): Likewise.
57 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
58
59 * sysdep.c (croak): Now static, if
60 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
61 * syssignal.h (croak): Declare only if not static.
62
63 * alloc.c (refill_memory_reserve): Now static if
64 !defined REL_ALLOC || defined SYSTEM_MALLOC.
65 * lisp.h (refill_memory_reserve): Declare only if not static.
66
67 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
68 Define only if USE_LUCID.
69
70 * xrdb.c (x_customization_string, x_rm_string): Now static.
71
72 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
73 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
74
75 * xdisp.c (draw_row_with_mouse_face): Now static.
76 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
77
78 * window.h (check_all_windows): Mark externally visible.
79
80 * window.c (window_deletion_count): Now static.
81
82 * undo.c: Make symbols static if they're not exported.
83 (last_undo_buffer, last_boundary_position, pending_boundary):
84 Now static.
85
86 * textprop.c (interval_insert_behind_hooks): Now static.
87 (interval_insert_in_front_hooks): Likewise.
88
89 * term.c: Make symbols static if they're not exported.
90 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
91 (max_frame_lines, tty_set_terminal_modes):
92 (tty_reset_terminal_modes, tty_turn_off_highlight):
93 (get_tty_terminal): Now static.
94 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
95 * termhooks.h (term_mouse_moveto): Do not declare if
96 HAVE_WINDOW_SYSTEM.
97 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
98 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
99
100 * sysdep.c: Make symbols static if they're not exported.
101 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
102 Now static.
103 (sigprocmask_set, full_mask): Remove; unused.
104 (wait_debugging): Mark as visible.
105 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
106 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
107
108 * syntax.c (syntax_temp): Define only if !__GNUC__.
109
110 * sound.c (current_sound_device, current_sound): Now static.
111
112 * search.c (searchbufs, searchbuf_head): Now static.
113
114 * scroll.c (scroll_cost): Remove; unused.
115 * dispextern.h (scroll_cost): Remove decl.
116
117 * region-cache.h (pp_cache): Mark as externally visible.
118
119 * process.c: Make symbols static if they're not exported.
120 (process_tick, update_tick, create_process, chan_process):
121 (Vprocess_alist, proc_buffered_char, datagram_access):
122 (fd_callback_data, send_process_frame, process_sent_to): Now static.
123 (deactivate_process): Mark defn as static, as well as decl.
124 * lisp.h (create_process): Remove decl.
125 * process.h (chan_process, Vprocess_alist): Remove decls.
126
127 * print.c: Make symbols static if they're not exported.
128 (print_depth, new_backquote_output, being_printed, print_buffer):
129 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
130 (print_interval, print_number_index, initial_stderr_stream):
131 Now static.
132 * lisp.h (Fprinc): Remove decl.
133 (debug_output_compilation_hack): Mark as externally visible.
134
135 * sysdep.c (croak): Move decl from here to syssignal.h.
136 * syssignal.h (croak): Put it here, so the API can be checked when
137 'croak' is called from dissociate_if_controlling_tty.
138
139 * minibuf.c: Make symbols static if they're not exported.
140 (minibuf_save_list, choose_minibuf_frame): Now static.
141 * lisp.h (choose_minibuf_frame): Remove decl.
142
143 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
144
145 * lread.c: Make symbols static if they're not exported.
146 (read_objects, initial_obarray, oblookup_last_bucket_number):
147 Now static.
148 (make_symbol): Remove; unused.
149 * lisp.h (initial_obarray, make_symbol): Remove decls.
150
151 * keyboard.c: Make symbols static if they're not exported.
152 (single_kboard, recent_keys_index, total_keys, recent_keys):
153 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
154 (this_single_command_key_start, echoing, last_auto_save):
155 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
156 (command_loop, echo_now, keyboard_init_hook, help_char_p):
157 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
158 (Vlispy_mouse_stem, double_click_count):
159 Now static.
160 (force_auto_save_soon): Define only if SIGDANGER.
161 (ignore_mouse_drag_p): Now static if
162 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
163 (print_help): Remove; unused.
164 (stop_character, last_timer_event): Mark as externally visible.
165 * keyboard.h (ignore_mouse_drag_p): Declare only if
166 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
167 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
168 * lisp.h (echoing): Remove decl.
169 (force_auto_save_soon): Declare only if SIGDANGER.
170 * xdisp.c (redisplay_window): Simplify code, to make it more
171 obvious that ignore_mouse_drag_p is not accessed if !defined
172 USE_GTK && !defined HAVE_NS.
173
174 * intervals.c: Make symbols static if they're not exported.
175 (merge_properties_sticky, merge_interval_right, delete_interval):
176 Now static.
177 * intervals.h (merge_interval_right, delete_interval): Remove decls.
178
179 * insdel.c: Make symbols static if they're not exported.
180 However, leave prepare_to_modify_buffer alone. It's never
181 called from outside this function, but that appears to be a bug.
182 (combine_after_change_list, combine_after_change_buffer):
183 (adjust_after_replace, signal_before_change): Now static.
184 (adjust_after_replace_noundo): Remove; unused.
185 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
186 (signal_before_change): Remove decls.
187
188 * indent.c (val_compute_motion, val_vmotion): Now static.
189
190 * image.c: Make symbols static if they're not exported.
191 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
192 if USE_GTK.
193 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
194 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
195
196 * fringe.c (standard_bitmaps): Now static.
197 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
198
199 * frame.c: Make symbols static if they're not exported.
200 (x_report_frame_params, make_terminal_frame): Now static.
201 (get_frame_param): Now static, unless HAVE_NS.
202 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
203 (x_get_resource_string): Remove; not used.
204 * frame.h (make_terminal_frame, x_report_frame_params):
205 (x_get_resource_string); Remove decls.
206 (x_fullscreen_adjust): Declare only if WINDOWSNT.
207 * lisp.h (get_frame_param): Declare only if HAVE_NS.
208
209 * font.c, fontset.c: Make symbols static if they're not exported.
210 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
211 (FACE_SUITABLE_FOR_CHAR_P): Use it.
212 * font.c (font_close_object): Now static.
213 * font.h (font_close_object): Remove.
214 * fontset.c (FONTSET_OBJLIST): Remove.
215 (free_realized_fontset) #if-0 the body, which does nothing.
216 (face_suitable_for_char_p): #if-0, as it's never called.
217 * fontset.h (face_suitable_for_char_p): Remove decl.
218 * xfaces.c (face_at_string_position): Use
219 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
220 since 0 is always ASCII.
221
222 * fns.c (weak_hash_tables): Now static.
223
224 * fileio.c: Make symbols static if they're not exported.
225 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
226 (Vwrite_region_annotation_buffers): Now static.
227
228 * eval.c: Make symbols static if they're not exported.
229 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
230 * lisp.h (backtrace_list): Remove decl.
231
232 * emacs.c: Make symbols static if they're not exported.
233 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
234 (fatal_error_code, fatal_error_signal_hook, standard_args):
235 Now static.
236 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
237 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
238 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
239 * lisp.h (fatal_error_signal_hook): Remove decl.
240 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
241
242 * editfns.c: Move a (normally-unused) function to its only use.
243 * editfns.c, lisp.h (get_operating_system_release): Remove.
244 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
245 worth the hassle of breaking this out.
246
247 * xterm.c: Make symbols static if they're not exported.
248 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
249 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
250 (x_destroy_window, x_delete_display):
251 Now static.
252 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
253 (x_mouse_leave): Remove; unused.
254 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
255 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
256 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
257 Remove decls.
258 (x_mouse_leave): Declare only if WINDOWSNT.
259 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
260 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
261 USE_X_TOOLKIT.
262
263 * ftxfont.c: Make symbols static if they're not exported.
264 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
265 HAVE_FREETYPE.
266 * font.h (ftxfont_driver): Likewise.
267
268 * xfns.c: Make symbols static if they're not exported.
269 (x_last_font_name, x_display_info_for_name):
270 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
271 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
272 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
273 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
274 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
275 (last_show_tip_args): Now static.
276 (xic_defaut_fontset, xic_create_fontsetname): Define only if
277 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
278 (x_screen_planes): Remove; unused.
279 * dispextern.h (x_screen_planes): Remove decl.
280
281 * dispnew.c: Make symbols static if they're not exported.
282 * dispextern.h (redraw_garbaged_frames, scrolling):
283 (increment_row_positions): Remove.
284 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
285 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
286 Now static.
287 (redraw_garbaged_frames): Remove; unused.
288
289 * xfaces.c: Make symbols static if they're not exported.
290 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
291 Remove decls.
292 * xterm.h (defined_color): Remove decls.
293 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
294 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
295 (menu_face_changed_default, defined_color, free_realized_face):
296 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
297 (ascii_face_of_lisp_face): Remove; unused.
298
299 * xdisp.c: Make symbols static if they're not exported.
300 * dispextern.h (scratch_glyph_row, window_box_edges):
301 (glyph_to_pixel_coords, set_cursor_from_row):
302 (get_next_display_element, set_iterator_to_next):
303 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
304 (show_mouse_face): Remove decls
305 * frame.h (message_buf_print): Likewise.
306 * lisp.h (pop_message, set_message, check_point_in_composition):
307 Likewise.
308 * xterm.h (set_vertical_scroll_bar): Likewise.
309 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
310 (message_buf_print, scratch_glyph_row, displayed_buffer):
311 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
312 (get_next_display_element, show_mouse_face, window_box_edges):
313 (frame_to_window_pixel_xy, check_point_in_composition):
314 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
315 (glyph_to_pixel_coords): Remove; unused.
316
317 * dired.c (file_name_completion): Now static.
318
319 * dbusbind.c (xd_in_read_queued_messages): Now static.
320
321 * lisp.h (circular_list_error, FOREACH): Remove; unused.
322 * data.c (circular_list_error): Remove.
323
324 * commands.h (last_point_position, last_point_position_buffer):
325 (last_point_position_window): Remove decls.
326 * keyboard.c: Make these variables static.
327
328 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
329 decls.
330 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
331 (iso_code_class, detect_coding, code_convert_region): Now static.
332 (encode_coding_gap): Remove; unused.
333
334 * chartab.c (chartab_chars, chartab_bits): Now static.
335
336 * charset.h (charset_iso_8859_1): Remove decl.
337 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
338 Now static.
339
340 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
341 * ccl.c (Vccl_program_table): Now static.
342 (check_ccl_update): Remove; unused.
343
344 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
345 * category.h: ... from here.
346 * category.c (check_category_table, set_category_set): Now static.
347
348 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
349 * lisp.h: Remove these decls.
350
351 * buffer.c (buffer_count): Remove unused var.
352
353 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
354 so that it's not optimized away.
355 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
356 * dispextern.h (bidi_dump_cached_states): Remove, since it's
357 exported only to the debugger.
358
359 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
360 * atimer.h (run_all_atimers): Removed; not exported.
361
362 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
363 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
364 was inaccessible from Lisp.
365 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
366 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
367
368 alloc.c: Import and export fewer symbols, and remove unused items.
369 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
370 is defined.
371 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
372 it's not optimized away by whole-program optimization.
373 (message_enable_multibyte, free_misc): Remove.
374 (catchlist, handlerlist, mark_backtrace):
375 Declare only if BYTE_MARK_STACK.
376 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
377 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
378 (message_enable_multibyte): Remove decl.
379 (free_misc, interval_free_list, float_block, float_block_index):
380 (n_float_blocks, float_free_list, cons_block, cons_block_index):
381 (cons_free_list, last_marked_index):
382 Now static.
383 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
384 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
385 (mark_backtrace): Define only if BYTE_MARK_STACK.
386 * xdisp.c (message_enable_multibyte): Now static.
387
388 Declare Lisp_Object Q* variables to be 'static' if not exproted.
389 This makes it easier for human readers (and static analyzers)
390 to see whether these variables are used from other modules.
391 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
392 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
393 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
394 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
395 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
396 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
397 * xmenu.c, xselect.c:
398 Declare Q* vars static if they are not used in other modules.
399 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
400 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
401 Remove decls of unexported vars.
402 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
403
404 * lisp.h (DEFINE_FUNC): Make sname 'static'.
405
406 Make Emacs functions such as Fatom 'static' by default.
407 This makes it easier for human readers (and static analyzers)
408 to see whether these functions can be called from other modules.
409 DEFUN now defines a static function. To make the function external
410 so that it can be used in other C modules, use the new macro DEFUE.
411 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
412 (Finit_image_library):
413 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
414 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
415 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
416 Remove decls, since these functions are now static.
417 (Funintern, Fget_internal_run_time): New decls, since these functions
418 were already external.
419
420 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
421 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
422 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
423 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
424 * keyboard.c, keymap.c, lread.c:
425 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
426 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
427 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
428 Mark functions with DEFUE instead of DEFUN,
429 if they are used in other modules.
430 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
431 decls for now-static functions.
432 * buffer.h (Fdelete_overlay): Remove decl.
433 * callproc.c (Fgetenv_internal): Mark as internal.
434 * composite.c (Fremove_list_of_text_properties): Remove decl.
435 (Fcomposition_get_gstring): New forward static decl.
436 * composite.h (Fcomposite_get_gstring): Remove decl.
437 * dired.c (Ffile_attributes): New forward static decl.
438 * doc.c (Fdocumntation_property): New forward static decl.
439 * eval.c (Ffetch_bytecode): New forward static decl.
440 (Funintern): Remove extern decl; now in .h file where it belongs.
441 * fileio.c (Fmake_symbolic_link): New forward static decl.
442 * image.c (Finit_image_library): New forward static decl.
443 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
444 * intervals.h (Fprevious_property_change):
445 (Fremove_list_of_text_properties): Remove decls.
446 * keyboard.c (Fthis_command_keys): Remove decl.
447 (Fcommand_execute): New forward static decl.
448 * keymap.c (Flookup_key): New forward static decl.
449 (Fcopy_keymap): Now static.
450 * keymap.h (Flookup_key): Remove decl.
451 * process.c (Fget_process): New forward static decl.
452 (Fprocess_datagram_address): Mark as internal.
453 * syntax.c (Fsyntax_table_p): New forward static decl.
454 (skip_chars): Remove duplicate decl.
455 * textprop.c (Fprevious_property_change): New forward static decl.
456 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
457 Now internal.
458 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
459 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
460
461 * editfns.c (Fformat): Remove unreachable code.
462
4632011-04-14 Andreas Schwab <schwab@linux-m68k.org>
464
465 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
466 change. (Bug#8496)
467
4682011-04-13 Eli Zaretskii <eliz@gnu.org>
469
470 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
471 when at ZV. (Bug#8487)
472
4732011-04-12 Andreas Schwab <schwab@linux-m68k.org>
474
475 * charset.c (Fclear_charset_maps): Use xfree instead of free.
476 (Bug#8437)
477 * keyboard.c (parse_tool_bar_item): Likewise.
478 * sound.c (sound_cleanup, alsa_close): Likewise.
479 * termcap.c (tgetent): Likewise.
480 * xfns.c (x_default_font_parameter): Likewise.
481 * xsettings.c (read_and_apply_settings): Likewise.
482
483 * alloc.c (overrun_check_malloc, overrun_check_realloc)
484 (overrun_check_free): Protoize.
485
4862011-04-12 Paul Eggert <eggert@cs.ucla.edu>
487
488 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
489 since callers should never pass a negative size.
490 Change the signature to match that of plain 'read' and 'write'; see
491 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
492 * lisp.h: Update prototypes of emacs_write and emacs_read.
493
4942011-04-11 Eli Zaretskii <eliz@gnu.org>
495
496 * xdisp.c (redisplay_window): Don't try to determine the character
497 position of the scroll margin if the window start point w->startp
498 is outside the buffer's accessible region. (Bug#8468)
499
5002011-04-10 Eli Zaretskii <eliz@gnu.org>
501
502 Fix write-region and its subroutines for buffers > 2GB.
503 * fileio.c (a_write, e_write): Modify declaration of arguments and
504 local variables to support buffers larger than 2GB.
505 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
506
507 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
508 argument, local variables, and return value.
509
510 * lisp.h: Update prototypes of emacs_write and emacs_read.
511
512 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
513
5142011-04-10 Paul Eggert <eggert@cs.ucla.edu>
515
516 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
517
518 Fix more problems found by GCC 4.6.0's static checks.
519
520 * xdisp.c (vmessage): Use a better test for character truncation.
521
522 * charset.c (load_charset_map): <, not <=, for optimization,
523 and to avoid potential problems with integer overflow.
524 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
525 * casetab.c (set_identity, shuffle): Likewise.
526 * editfns.c (Fformat): Likewise.
527 * syntax.c (skip_chars): Likewise.
528
529 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
530 This also lets GCC 4.6.0 generate slightly better loop code.
531
532 * callint.c (Fcall_interactively): <, not <=, for optimization.
533 (Fcall_interactively): Count the number of arguments produced,
534 not the number of arguments given. This is simpler and lets GCC
535 4.6.0 generate slightly better code.
536
537 * ftfont.c: Distingish more carefully between FcChar8 and char.
538 The previous code passed unsigned char * to a functions like
539 strlen and xstrcasecmp that expect char *, which does not
540 conform to the C standard.
541 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
542 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
543 char * when the C standard requires it.
544
545 * keyboard.c (read_char): Remove unused var.
546
547 * eval.c: Port to Windows vsnprintf (Bug#8435).
548 Include <limits.h>.
549 (SIZE_MAX): Define if the headers do not.
550 (verror): Do not give up if vsnprintf returns a negative count.
551 Instead, grow the buffer. This ports to Windows vsnprintf, which
552 does not conform to C99. Problem reported by Eli Zaretskii.
553 Also, simplify the allocation scheme, by avoiding the need for
554 calling realloc, and removing the ALLOCATED variable.
555
556 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
557
558 Remove invocations of doprnt, as Emacs now uses vsnprintf.
559 But keep the doprint source code for now, as we might revamp it
560 and use it again (Bug#8435).
561 * lisp.h (doprnt): Remove.
562 * Makefile.in (base_obj): Remove doprnt.o.
563 * deps.mk (doprnt.o): Remove.
564
565 error: Print 32- and 64-bit integers portably (Bug#8435).
566 Without this change, on typical 64-bit hosts error ("...%d...", N)
567 was used to print both 32- and 64-bit integers N, which relied on
568 undefined behavior.
569 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
570 New macro.
571 * lisp.h (error, verror): Mark as printf-like functions.
572 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
573 Report overflow in size calculations when allocating printf buffer.
574 Do not truncate output string at its first null byte.
575 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
576 Truncate the output at a character boundary, since vsnprintf does not
577 do that.
578 * charset.c (check_iso_charset_parameter): Convert internal
579 character to string before calling 'error', since %c now has the
580 printf meaning.
581 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
582 overflow when computing char to be passed to 'error'. Do not
583 pass Lisp_Object to 'error'; pass the integer instead.
584 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
585 formatted with plain %d.
586
587 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
588
589 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
590
591 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
592
593 * xterm.c (x_catch_errors): Remove duplicate declaration.
594
595 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
596
597 * xdisp.c, lisp.h (message_nolog): Remove; unused.
598
5992011-04-10 Jim Meyering <meyering@redhat.com>
600
601 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
602 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
603 return ssize_t not "int", and use size_t as the buffer length.
604 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
605 * gnutls.h: Update declarations.
606 * process.c (read_process_output): Use ssize_t, to match.
607 (send_process): Likewise.
608
6092011-04-09 Chong Yidong <cyd@stupidchicken.com>
610
611 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
612
6132011-04-09 Chong Yidong <cyd@stupidchicken.com>
614
615 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
616 unsigned char, to match FcChar8 type definition.
617
618 * xterm.c (handle_one_xevent):
619 * xmenu.c (create_and_show_popup_menu):
620 * xselect.c (x_decline_selection_request)
621 (x_reply_selection_request): Avoid type-punned deref of X events.
622
6232011-04-09 Eli Zaretskii <eliz@gnu.org>
624
625 Fix some uses of `int' instead of EMACS_INT.
626 * search.c (string_match_1, fast_string_match)
627 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
628 (scan_buffer, find_next_newline_no_quit)
629 (find_before_next_newline, search_command, Freplace_match)
630 (Fmatch_data): Make some `int' variables be EMACS_INT.
631
632 * xdisp.c (display_count_lines): 3rd argument and return value now
633 EMACS_INT. All callers changed.
634 (pint2hrstr): Last argument is now EMACS_INT.
635
636 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
637 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
638 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
639 (decode_coding_utf_16, decode_coding_emacs_mule)
640 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
641 (decode_coding_ccl, decode_coding_charset)
642 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
643 (decode_coding_iso_2022, decode_coding_emacs_mule)
644 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
645 <char_offset, last_offset>: Declare EMACS_INT.
646 (encode_coding_utf_8, encode_coding_utf_16)
647 (encode_coding_emacs_mule, encode_invocation_designation)
648 (encode_designation_at_bol, encode_coding_iso_2022)
649 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
650 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
651 Declare EMACS_INT.
652 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
653 (encode_invocation_designation): Last argument P_NCHARS is now
654 EMACS_INT.
655 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
656 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
657
658 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
659 All users changed.
660
661 * ccl.c (Fccl_execute_on_string): Declare some variables
662 EMACS_INT.
663
6642011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
665
666 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
667
6682011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
669
670 * process.c (Fformat_network_address): Doc fix.
671
6722011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
673
674 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
675
6762011-04-08 Chong Yidong <cyd@stupidchicken.com>
677
678 * keyboard.c (read_char): Call Lisp function help-form-show,
679 instead of using internal_with_output_to_temp_buffer.
680 (Qhelp_form_show): New var.
681 (syms_of_keyboard): Use DEFSYM macro.
682
683 * print.c (internal_with_output_to_temp_buffer): Function deleted.
684
685 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
686
6872011-04-06 Chong Yidong <cyd@stupidchicken.com>
688
689 * process.c (Flist_processes): Removed to Lisp.
690 (list_processes_1): Deleted.
691
6922011-04-06 Eli Zaretskii <eliz@gnu.org>
693
694 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
695
696 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
697
6982011-04-06 Paul Eggert <eggert@cs.ucla.edu>
699
700 Fix more problems found by GCC 4.6.0's static checks.
701
702 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
703
704 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
705
706 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
707
708 * xdisp.c (vmessage): Mark as a printf-like function.
709
710 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
711
712 * sound.c (sound_warning): Don't crash if arg contains a printf format.
713
714 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
715 printf-like functions.
716 (tiff_load): Add casts to remove these marks before passing them
717 to system-supplied API.
718
719 * eval.c (Fsignal): Remove excess argument to 'fatal'.
720
721 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
722 This avoids several warnings with gcc -Wstrict-overflow.
723 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
724 directly, rather than having caller test rule sign. This avoids
725 some unnecessary tests.
726 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
727 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
728 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
729
730 * xfont.c (xfont_text_extents): Remove var that was set but not used.
731 (xfont_open): Avoid unnecessary tests.
732
733 * composite.c (composition_gstring_put_cache): Use unsigned integer.
734
735 * composite.h, composite.c (composition_gstring_put_cache):
736 Use EMACS_INT, not int, for length.
737
738 * composite.h (COMPOSITION_DECODE_REFS): New macro,
739 breaking out part of COMPOSITION_DECODE_RULE.
740 (COMPOSITION_DECODE_RULE): Use it.
741 * composite.c (get_composition_id): Remove unused local vars,
742 by using the new macro.
743
744 * textprop.c (set_text_properties_1): Change while to do-while,
745 since the condition is always true at first.
746
747 * intervals.c (graft_intervals_into_buffer): Mark var as used.
748 (interval_deletion_adjustment): Return unsigned value.
749 All uses changed.
750
751 * process.c (list_processes_1, create_pty, read_process_output):
752 (exec_sentinel): Remove vars that were set but not used.
753 (create_pty): Remove unnecessary "volatile"s.
754 (Fnetwork_interface_info): Avoid possibility of int overflow.
755 (read_process_output): Do adaptive read buffering even if carryover.
756 (read_process_output): Simplify nbytes computation if buffered.
757
758 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
759
760 * syntax.c (scan_words): Remove var that was set but not used.
761 (update_syntax_table): Use unsigned instead of int.
762
763 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
764 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
765 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
766
767 * print.c (print_error_message): Avoid int overflow.
768
769 * font.c (font_list_entities): Redo for clarity,
770 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
771
772 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
773 (font_score): Avoid potential overflow in diff calculation.
774
775 * fns.c (substring_both): Remove var that is set but not used.
776 (sxhash): Redo loop for clarity and to avoid wraparound warning.
777
778 * eval.c (funcall_lambda): Rename local to avoid shadowing.
779
780 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
781 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
782 can always succeed if overflow has undefined behavior.
783
784 * search.c (boyer_moore, wordify): Remove vars set but not used.
785 (wordify): Omit three unnecessary tests.
786
787 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
788 All callers changed. This avoids the need for an unused var.
789
790 * casefiddle.c (casify_region): Remove var that is set but not used.
791
792 * dired.c (file_name_completion): Remove var that is set but not used.
793
794 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
795
796 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
797 (Finsert_file_contents): Remove unnecessary code checking fd.
798
799 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
800 Check for integer overflow on size calculations.
801
802 * buffer.c (Fprevious_overlay_change): Remove var that is set
803 but not used.
804
805 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
806 Remove vars that are set but not used.
807 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
808 (timer_check_2): Mark vars as initialized.
809
810 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
811
812 * image.c (lookup_image): Remove var that is set but not used.
813 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
814
815 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
816 that are set but not used.
817
818 * xfns.c (make_invisible_cursor): Don't return garbage
819 if XCreateBitmapFromData fails (Bug#8410).
820
821 * xselect.c (x_get_local_selection, x_handle_property_notify):
822 Remove vars that are set but not used.
823
824 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
825 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
826
827 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
828 Remove var that is set but not used.
829 (scroll_bar_windows_size): Now size_t, not int.
830 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
831 Check for overflow.
832
833 * xfaces.c (realize_named_face): Remove vars that are set but not used.
834 (map_tty_color) [!defined MSDOS]: Likewise.
835
836 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
837
838 * coding.c: Remove vars that are set but not used.
839 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
840 All callers changed.
841 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
842 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
843 (decode_coding_charset): Remove vars that are set but not used.
844
845 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
846 that is set but not used.
847
848 * print.c (print_object): Remove var that is set but not used.
849
850 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
851 The gnulib version avoids calling malloc in the usual case,
852 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
853 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
854 * filelock.c (current_lock_owner): Likewise.
855 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
856 * sysdep.c: Include allocator.h, careadlinkat.h.
857 (emacs_no_realloc_allocator): New static constant.
858 (emacs_readlink): New function.
859 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
860 ../lib/careadlinkat.h.
861
8622011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
863
864 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
865 first non-nil return value).
866
8672011-04-03 Jan Djärv <jan.h.d@swipnet.se>
868
869 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
870 if not defined (Bug#8403).
871
8722011-04-02 Juanma Barranquero <lekktu@gmail.com>
873
874 * xdisp.c (display_count_lines): Remove parameter `start',
875 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
876 (get_char_face_and_encoding): Remove parameter `multibyte_p',
877 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
878 (fill_stretch_glyph_string): Remove parameters `row' and `area',
879 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
880 and thereabouts. All callers changed.
881 (get_per_char_metric): Remove parameter `f', unused since
882 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
883
8842011-04-02 Jim Meyering <meyering@redhat.com>
885
886 do not dereference NULL upon failed strdup
887 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
888 (ns_get_family): Likewise.
889
8902011-04-02 Juanma Barranquero <lekktu@gmail.com>
891
892 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
893
8942011-04-02 Jan Djärv <jan.h.d@swipnet.se>
895
896 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
897 later (Bug#8403).
898
8992011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
900
901 Add lexical binding.
902
903 * window.c (Ftemp_output_buffer_show): New fun.
904 (Fsave_window_excursion):
905 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
906
907 * lread.c (lisp_file_lexically_bound_p): New function.
908 (Fload): Bind Qlexical_binding.
909 (readevalloop): Remove `evalfun' arg.
910 Bind Qinternal_interpreter_environment.
911 (Feval_buffer): Bind Qlexical_binding.
912 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
913 Mark as dynamic.
914 (syms_of_lread): Declare `lexical-binding'.
915
916 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
917
918 * keyboard.c (eval_dyn): New fun.
919 (menu_item_eval_property): Use it.
920
921 * image.c (parse_image_spec): Use Ffunctionp.
922
923 * fns.c (concat, mapcar1): Accept byte-code-functions.
924
925 * eval.c (Fsetq): Handle lexical vars.
926 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
927 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
928 (FletX, Flet): Obey lexical binding.
929 (Fcommandp): Handle closures.
930 (Feval): New `lexical' arg.
931 (eval_sub): New function extracted from Feval. Use it almost
932 everywhere where Feval was used. Look up vars in lexical env.
933 Handle closures.
934 (Ffunctionp): Move from subr.el.
935 (Ffuncall): Handle closures.
936 (apply_lambda): Remove `eval_flags'.
937 (funcall_lambda): Handle closures and new byte-code-functions.
938 (Fspecial_variable_p): New function.
939 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
940 but without exporting it to Lisp.
941
942 * doc.c (Fdocumentation, store_function_docstring):
943 * data.c (Finteractive_form): Handle closures.
944
945 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
946 interactive spec.
947
948 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
949 byte-codes.
950 (exec_byte_code): New function extracted from Fbyte_code to handle new
951 calling convention for byte-code-functions. Add new byte-codes.
952
953 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
954
955 * alloc.c (Fmake_symbol): Init new `declared_special' field.
956
9572011-03-31 Juanma Barranquero <lekktu@gmail.com>
958
959 * xdisp.c (redisplay_internal): Fix prototype.
960
9612011-03-31 Eli Zaretskii <eliz@gnu.org>
962
963 * xdisp.c (SCROLL_LIMIT): New macro.
964 (try_scrolling): Use it when setting scroll_limit. Limit
965 scrolling to 100 screen lines.
966 (redisplay_window): Even when falling back on "recentering",
967 position point in the window according to scroll-conservatively,
968 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
969
970 (try_scrolling): When point is above the window, allow searching
971 as far as scroll_max, or one screenful, to compute vertical
972 distance from PT to the scroll margin position. This prevents
973 try_scrolling from unnecessarily failing when
974 scroll-conservatively is set to a value slightly larger than the
975 window height. Clean up the case of PT below the margin at bottom
976 of window: scroll_max can no longer be INT_MAX. When aggressive
977 scrolling is in use, don't let point enter the opposite scroll
978 margin as result of the scroll.
979 (syms_of_xdisp) <scroll-conservatively>: Document the
980 threshold of 100 lines for never-recentering scrolling.
981
9822011-03-31 Juanma Barranquero <lekktu@gmail.com>
983
984 * dispextern.h (move_it_by_lines):
985 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
986 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
987 (message_log_check_duplicate): Remove parameters `prev_bol' and
988 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
989 (redisplay_internal): Remove parameter `preserve_echo_area',
990 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
991
992 * indent.c (Fvertical_motion):
993 * window.c (window_scroll_pixel_based, Frecenter):
994 Don't pass `need_y_p' to `move_it_by_lines'.
995
9962011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
997
998 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
999 steal a few bits to be more compact.
1000 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1001 Remove unneeded casts.
1002
1003 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1004
10052011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1006
1007 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1008 binding" message (bug#7967).
1009
10102011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1011
1012 Fix more problems found by GCC 4.6.0's static checks.
1013
1014 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1015 Remove unused local var.
1016
1017 * editfns.c (Fmessage_box): Remove unused local var.
1018
1019 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1020 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1021 Omit unused local vars.
1022 * window.c (shrink_windows): Omit unused local var.
1023 * menu.c (digest_single_submenu): Omit unused local var.
1024 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1025 Omit unused local var.
1026
1027 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1028 Don't assume string length fits in int.
1029 (keyremap_step, read_key_sequence): Use size_t for sizes.
1030 (read_key_sequence): Don't check last_real_key_start redundantly.
1031
1032 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1033 instead of alloca (Bug#8344).
1034
1035 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1036 (Fbacktrace_frame): Don't assume nframes fits in int.
1037
1038 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1039
1040 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1041 concerns.
1042
1043 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1044
1045 * cm.c (calccost): Turn while-do into do-while, for clarity.
1046
1047 * keyboard.c (syms_of_keyboard): Use the same style as later
1048 in this function when indexing through an array. This also
1049 works around GCC bug 48267.
1050
1051 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1052
1053 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1054
1055 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1056 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1057
1058 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1059 This avoids undefined behavior on integer overflow, and is a bit
1060 more convenient anyway since it is compared to a size_t variable.
1061
1062 Variadic C functions now count arguments with size_t, not int.
1063 This avoids an unnecessary limitation on 64-bit machines, which
1064 caused (substring ...) to crash on large vectors (Bug#8344).
1065 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1066 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1067 All variadic functions and their callers changed accordingly.
1068 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1069 * data.c (arith_driver, float_arith_driver): Likewise.
1070 * editfns.c (general_insert_function): Likewise.
1071 * eval.c (struct backtrace.nargs, interactive_p)
1072 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1073 (funcall_lambda, mark_backtrace): Likewise.
1074 * fns.c (concat): Likewise.
1075 * frame.c (x_set_frame_parameters): Likewise.
1076 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1077 0 if not found, not -1. All callers changed.
1078
1079 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1080 (stack_copy_size): Now size_t, not int.
1081 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1082
10832011-03-28 Juanma Barranquero <lekktu@gmail.com>
1084
1085 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1086 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1087 All callers changed.
1088
1089 * lisp.h (multibyte_char_to_unibyte):
1090 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1091 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1092 * character.h (CHAR_TO_BYTE8):
1093 * cmds.c (internal_self_insert):
1094 * editfns.c (general_insert_function):
1095 * keymap.c (push_key_description):
1096 * search.c (Freplace_match):
1097 * xdisp.c (message_dolog, set_message_1): All callers changed.
1098
10992011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1100
1101 * keyboard.c (safe_run_hook_funcall): New function.
1102 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1103 don't set the hook to nil, but remove the offending function instead.
1104 (Qcommand_hook_internal): Remove, unused.
1105 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1106 Vcommand_hook_internal.
1107
1108 * eval.c (enum run_hooks_condition): Remove.
1109 (funcall_nil, funcall_not): New functions.
1110 (run_hook_with_args): Call each function through a `funcall' argument.
1111 Remove `cond' argument, now redundant.
1112 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1113 (Frun_hook_with_args_until_failure): Adjust accordingly.
1114 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1115
11162011-03-28 Juanma Barranquero <lekktu@gmail.com>
1117
1118 * dispextern.h (string_buffer_position): Remove declaration.
1119
1120 * print.c (strout): Remove parameter `multibyte', unused since
1121 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1122
1123 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1124 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1125 All callers changed.
1126
1127 * w32.c (_wsa_errlist): Use braces for struct initializers.
1128
1129 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1130 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1131 All callers changed.
1132 (string_buffer_position): Likewise. Also, make static (it's never
1133 used outside xdisp.c).
1134 (cursor_row_p): Remove parameter `w', unused since
1135 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1136 (decode_mode_spec): Remove parameter `precision', introduced during
1137 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1138 All callers changed.
1139
11402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1141
1142 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1143
11442011-03-27 Anders Lindgren <andlind@gmail.com>
1145
1146 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1147 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1148 (ns_update_auto_hide_menu_bar): New functions.
1149 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1150 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1151 ns_constrain_all_frames.
1152 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1153 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1154
11552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1156
1157 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1158
11592011-03-27 Glenn Morris <rgm@gnu.org>
1160
1161 * syssignal.h: Replace RETSIGTYPE with void.
1162 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1163 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1164 Replace SIGTYPE with void everywhere.
1165 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1166 * s/template.h (SIGTYPE): Remove commented out definition.
1167
11682011-03-26 Eli Zaretskii <eliz@gnu.org>
1169
1170 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1171 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1172
11732011-03-26 Juanma Barranquero <lekktu@gmail.com>
1174
1175 * w32.c (read_unc_volume): Use parameter `henum', instead of
1176 global variable `wget_enum_handle'.
1177
1178 * keymap.c (describe_vector): Remove parameters `indices' and
1179 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1180 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1181
1182 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1183
1184 * keyboard.c (timer_check): Remove parameter `do_it_now',
1185 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1186 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1187 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1188
1189 * keyboard.c (read_char):
1190 * w32menu.c (w32_menu_display_help):
1191 * xmenu.c (show_help_event, menu_help_callback):
1192 Adjust calls to `show_help_echo'.
1193
1194 * gtkutil.c (xg_maybe_add_timer):
1195 * keyboard.c (readable_events):
1196 * process.c (wait_reading_process_output):
1197 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1198
1199 * insdel.c (adjust_markers_gap_motion):
1200 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1201 (gap_left, gap_right): Don't call it.
1202
12032011-03-25 Chong Yidong <cyd@stupidchicken.com>
1204
1205 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1206 incurred during fontification.
1207
12082011-03-25 Juanma Barranquero <lekktu@gmail.com>
1209
1210 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1211 (DEFVAR_PER_BUFFER): Don't pass it.
1212
1213 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1214 (scrolling_window): Don't pass it.
1215
12162011-03-25 Juanma Barranquero <lekktu@gmail.com>
1217
1218 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1219
1220 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1221 and `suffix'.
1222 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1223 of variables specific to SELinux and computation of `encoded_absname'.
1224
1225 * image.c (XPutPixel): Remove unused variable `height'.
1226
1227 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1228
1229 * unexw32.c (get_section_info): Remove unused variable `section'.
1230
1231 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1232 (system_process_attributes): Remove unused variable `sess'.
1233 (sys_read): Remove unused variable `err'.
1234
1235 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1236 (w32_wnd_proc): Remove unused variable `isdead'.
1237 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1238 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1239 (x_create_tip_frame): Remove unused variable `tem'.
1240
1241 * w32inevt.c (w32_console_read_socket):
1242 Remove unused variable `no_events'.
1243
1244 * w32term.c (x_draw_composite_glyph_string_foreground):
1245 Remove unused variable `width'.
1246
12472011-03-24 Juanma Barranquero <lekktu@gmail.com>
1248
1249 * w32term.c (x_set_glyph_string_clipping):
1250 Don't pass uninitialized region to CombineRgn.
1251
12522011-03-23 Juanma Barranquero <lekktu@gmail.com>
1253
1254 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1255 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1256 (Fx_close_connection): Remove unused variable `i'.
1257
1258 * w32font.c (w32font_draw): Return number of glyphs.
1259 (w32font_open_internal): Remove unused variable `i'.
1260 (w32font_driver): Add missing initializer.
1261
1262 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1263 (fill_in_menu): Remove unused variable `items_added'.
1264
1265 * w32term.c (last_mouse_press_frame): Remove static global variable.
1266 (w32_clip_to_row): Remove unused variable `f'.
1267 (x_delete_terminal): Remove unused variable `i'.
1268
1269 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1270 (NOTHING): Remove unused static global variable.
1271 (uniscribe_check_otf): Remove unused variable `table'.
1272 (uniscribe_font_driver): Add missing initializers.
1273
12742011-03-23 Julien Danjou <julien@danjou.info>
1275
1276 * term.c (Fsuspend_tty, Fresume_tty):
1277 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1278 * window.c (temp_output_buffer_show):
1279 * insdel.c (signal_before_change):
1280 * frame.c (Fhandle_switch_frame):
1281 * fileio.c (Fdo_auto_save):
1282 * emacs.c (Fkill_emacs):
1283 * editfns.c (save_excursion_restore):
1284 * cmds.c (internal_self_insert):
1285 * callint.c (Fcall_interactively):
1286 * buffer.c (Fkill_all_local_variables):
1287 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1288 Use Frun_hooks.
1289 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1290 unconditionnaly since it does the check itself.
1291
12922011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 Fix more problems found by GCC 4.5.2's static checks.
1295
1296 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1297 the first time through the loop, since we know p0 < p1 then.
1298 This also avoids a gcc -Wstrict-overflow warning.
1299
1300 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1301 leading to a memory leak, possible in functions like
1302 load_charset_map_from_file that can allocate an unbounded number
1303 of objects (Bug#8318).
1304
1305 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1306 that could (at least in theory) be that large.
1307
1308 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1309 This is less likely to overflow, and avoids undefined behavior if
1310 overflow does occur. All callers changed. Use strtoul to scan
1311 for the unsigned long integer.
1312 (pint2hrstr): Simplify and tune code slightly.
1313 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1314
1315 * scroll.c (do_scrolling): Work around GCC bug 48228.
1316 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1317
1318 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1319 This also avoids a warning with gcc -Wstrict-overflow.
1320 (validate_x_resource_name): Simplify count usage.
1321 This also avoids a warning with gcc -Wstrict-overflow.
1322
1323 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1324 fail (Bug#8306).
1325
1326 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1327
1328 * process.c (Fmake_network_process): Use socklen_t, not int,
1329 where POSIX says socklen_t is required in portable programs.
1330 This fixes a porting bug on hosts like 64-bit HP-UX, where
1331 socklen_t is wider than int (Bug#8277).
1332 (Fmake_network_process, server_accept_connection):
1333 (wait_reading_process_output, read_process_output):
1334 Likewise.
1335
1336 * process.c: Rename or move locals to avoid shadowing.
1337 (list_processes_1, Fmake_network_process):
1338 (read_process_output_error_handler, exec_sentinel_error_handler):
1339 Rename or move locals.
1340 (Fmake_network_process): Define label "retry_connect" only if needed.
1341 (Fnetwork_interface_info): Fix pointer signedness.
1342 (process_send_signal): Add cast to avoid pointer signedness problem.
1343 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1344 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1345
1346 Make tparam.h and terminfo.c consistent.
1347 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1348 Include tparam.h instead, since it declares them.
1349 * cm.h (PC): Remove extern decl; tparam.h now does this.
1350 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1351 * terminfo.c: Include tparam.h, to check interfaces.
1352 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1353 (tparam): Adjust signature to match interface in tparam.h;
1354 this removes some undefined behavior. Check that outstring and len
1355 are zero, which they always are with Emacs.
1356 * tparam.h (PC, BC, UP): New extern decls.
1357
1358 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1359 (xftfont_open): Rename locals to avoid shadowing.
1360
1361 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1362 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1363 (OTF_TAG_SYM): Omit macro if not needed.
1364 (ftfont_list): Remove unused local.
1365 (get_adstyle_property, ftfont_pattern_entity):
1366 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1367 Rename locals to avoid shadowing.
1368
1369 * xfont.c (xfont_list_family): Mark var as initialized.
1370
1371 * xml.c (make_dom): Now static.
1372
1373 * composite.c (composition_compute_stop_pos): Rename local to
1374 avoid shadowing.
1375 (composition_reseat_it): Remove unused locals.
1376 (find_automatic_composition, composition_adjust_point): Likewise.
1377 (composition_update_it): Mark var as initialized.
1378 (find_automatic_composition): Mark vars as initialized,
1379 with a FIXME (Bug#8290).
1380
1381 character.h: Rename locals to avoid shadowing.
1382 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1383 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1384 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1385 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1386 to avoid shadowing.
1387
1388 * textprop.c (property_change_between_p): Remove; unused.
1389
1390 * intervals.c (interval_start_pos): Now static.
1391
1392 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1393
1394 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1395 Rename locals to avoid shadowing.
1396
1397 * sound.c (wav_play, au_play, Fplay_sound_internal):
1398 Fix pointer signedness.
1399 (alsa_choose_format): Remove unused local var.
1400 (wav_play): Initialize a variable to 0, to prevent undefined
1401 behavior (Bug#8278).
1402
1403 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1404
1405 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1406
1407 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1408 clobbering (Bug#8298).
1409 * sysdep.c (sys_subshell): Likewise.
1410 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1411
1412 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1413 This should get cleaned up, so that child_setup has the
1414 same signature on all platforms.
1415
1416 * callproc.c (call_process_cleanup): Now static.
1417 (relocate_fd): Rename locals to avoid shadowing.
1418
14192011-03-22 Chong Yidong <cyd@stupidchicken.com>
1420
1421 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1422 not to be necessary, and produces flickering.
1423
14242011-03-20 Glenn Morris <rgm@gnu.org>
1425
1426 * config.in: Remove file.
1427
14282011-03-20 Juanma Barranquero <lekktu@gmail.com>
1429
1430 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1431 are now in src/globals.h.
1432 (syms_of_minibuf): Remove spurious & from previous change.
1433
14342011-03-20 Leo <sdl.web@gmail.com>
1435
1436 * minibuf.c (completing-read-function): New variable.
1437 (completing-read-default): Rename from completing-read.
1438 (completing-read): Call completing-read-function.
1439
14402011-03-19 Juanma Barranquero <lekktu@gmail.com>
1441
1442 * xfaces.c (Fx_load_color_file):
1443 Read color file from absolute filename (bug#8250).
1444
14452011-03-19 Juanma Barranquero <lekktu@gmail.com>
1446
1447 * makefile.w32-in: Update dependencies.
1448
14492011-03-17 Eli Zaretskii <eliz@gnu.org>
1450
1451 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1452
14532011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1454
1455 Fix more problems found by GCC 4.5.2's static checks.
1456
1457 * process.c (make_serial_process_unwind, send_process_trap):
1458 (sigchld_handler): Now static.
1459
1460 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1461 That way, the code declares only the vars that it needs.
1462 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1463 * s/cygwin.h (PTY_ITERATION): Likewise.
1464 * s/darwin.h (PTY_ITERATION): Likewise.
1465 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1466
1467 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1468 * process.c (allocate_pty): Don't declare stb unless it's needed.
1469
1470 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1471 (CONSTANTLIM): Remove; unused.
1472 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1473 Define only if needed.
1474
1475 * unexelf.c (unexec): Name an expression,
1476 to avoid gcc -Wbad-function-cast warning.
1477 Use a different way to cause a compilation error if anyone uses
1478 n rather than nn, a way that does not involve shadowing.
1479 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1480
1481 * deps.mk (unexalpha.o): Remove; unused.
1482
1483 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1484 * unexec.h: New file.
1485 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1486 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1487 Depend on unexec.h.
1488 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1489 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1490 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1491 Change as necessary to match prototype in unexec.h.
1492
1493 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1494 shadowing.
1495 (back_comment, skip_chars): Mark vars as initialized.
1496
1497 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1498 Rename locals to avoid shadowing.
1499
1500 * lread.c (read1): Rewrite so as not to use empty "else".
1501 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1502
1503 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1504
1505 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1506 warning when compiling print.c.
1507
1508 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1509 instead of using an uninitialized var.
1510 (font_sort_entities): Mark var as initialized.
1511
1512 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1513
1514 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1515 pointers to constants.
1516 (font_parse_fcname): Remove unused vars.
1517 (font_delete_unmatched): Now static.
1518 (font_get_spec): Remove; unused.
1519 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1520 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1521 Rename or move locals to avoid shadowing.
1522
1523 * fns.c (require_nesting_list, require_unwind): Now static.
1524 (Ffillarray): Rename locals to avoid shadowing.
1525
1526 * floatfns.c (domain_error2): Define only if needed.
1527 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1528
1529 * alloc.c (mark_backtrace): Move decl from here ...
1530 * lisp.h: ... to here, so that it can be checked.
1531
1532 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1533 (Fdefvar): Rewrite so as not to use empty "else".
1534 (lisp_indirect_variable): Name an expression,
1535 to avoid gcc -Wbad-function-cast warning.
1536 (Fdefvar): Rename locals to avoid shadowing.
1537
1538 * callint.c (quotify_arg, quotify_args): Now static.
1539 (Fcall_interactively): Rename locals to avoid shadowing.
1540 Use const pointer when appropriate.
1541
1542 * lisp.h (get_system_name, get_operating_system_release):
1543 Move decls here, to check interfaces.
1544 * process.c (get_operating_system_release): Move decl to lisp.h.
1545 * xrdb.c (get_system_name): Likewise.
1546 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1547 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1548 some of which prompt warnings from gcc -Wbad-function-cast.
1549 (Fformat_time_string, Fencode_time, Finsert_char):
1550 (Ftranslate_region_internal, Fformat):
1551 Rename or remove local vars to avoid shadowing.
1552 (Ftranslate_region_internal): Mark var as initialized.
1553
1554 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1555 avoid shadowing.
1556
1557 * lisp.h (eassert): Check that the argument compiles, even if
1558 ENABLE_CHECKING is not defined.
1559
1560 * data.c (Findirect_variable): Name an expression, to avoid
1561 gcc -Wbad-function-cast warning.
1562 (default_value, arithcompare, arith_driver, arith_error): Now static.
1563 (store_symval_forwarding): Rename local to avoid shadowing.
1564 (Fmake_variable_buffer_local, Fmake_local_variable):
1565 Mark variables as initialized.
1566 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1567
1568 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1569 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1570 Rename locals to avoid shadowing.
1571 (mark_stack): Move local variables into the #ifdef region where
1572 they're used.
1573 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1574 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1575 needed otherwise.
1576 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1577 (GC_STRING_CHARS): Remove; not used.
1578 (Fmemory_limit): Cast sbrk's returned value to char *.
1579
1580 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1581 avoids undefined behavior in theory.
1582
1583 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1584
1585 Use functions, not macros, for up- and down-casing (Bug#8254).
1586 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1587 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1588 to use the following functions instead of these macros.
1589 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1590 EMACS_INT, since callers assume the returned value fits in int.
1591 (upcase1): Likewise, for UPCASE_TABLE.
1592 (uppercasep, lowercasep, upcase): New static inline functions.
1593 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1594 the race-condition problem in the old DOWNCASE.
1595
1596 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1597 Rename locals to avoid shadowing.
1598 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1599 (regex_compile, re_search_2, re_match_2_internal):
1600 Remove unused local vars.
1601 (FREE_VAR): Rewrite so as not to use empty "else",
1602 which gcc can warn about.
1603 (regex_compile, re_match_2_internal): Mark locals as initialized.
1604 (RETALLOC_IF): Define only if needed.
1605 (WORDCHAR_P): Likewise. This one is never needed, but is used
1606 only in a comment talking about a compiler bug, so put inside
1607 the #if 0 of that comment.
1608 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1609 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1610 Remove; unused.
1611
1612 * search.c (boyer_moore): Rename locals to avoid shadowing.
1613 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1614 (PREV_CHAR_BOUNDARY): Likewise.
1615
1616 * search.c (simple_search): Remove unused var.
1617
1618 * dired.c (compile_pattern): Move decl from here ...
1619 * lisp.h: ... to here, so that it can be checked.
1620 (struct re_registers): New forward decl.
1621
1622 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1623
1624 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1625 All uses changed.
1626 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1627 Rename locals to avoid shadowing.
1628 (Fvertical_motion): Mark locals as initialized.
1629
1630 * casefiddle.c (casify_object, casify_region): Now static.
1631 (casify_region): Mark local as initialized.
1632
1633 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1634
1635 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1636 New macros, so that the caller can use some names other than
1637 gcpro1, gcpro2, etc.
1638 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1639 of the new macros.
1640 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1641 argument, for consistency with GCPRO2_VAR, etc: it is now the
1642 prefix of the variable, not the variable itself. All uses
1643 changed.
1644 * dired.c (directory_files_internal, file_name_completion):
1645 Rename locals to avoid shadowing.
1646
1647 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1648 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1649 dired.c's scmp function, had undefined behavior.
1650 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1651 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1652 * buffer.h: ... to here, because these macros use current_buffer,
1653 and the new implementation with inline functions needs to have
1654 current_buffer in scope now, rather than later when the macros
1655 are used.
1656 (downcase, upcase1): New static inline functions.
1657 (DOWNCASE, UPCASE1): Reimplement using these functions.
1658 This avoids undefined behavior in expressions like
1659 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1660 from race conditions in accessing the global variables
1661 case_temp1 and case_temp2.
1662 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1663 * lisp.h (case_temp1, case_temp2): Remove their decls.
1664 * character.h (ASCII_CHAR_P): Move from here ...
1665 * lisp.h: ... to here, so that the inline functions mentioned
1666 above can use them.
1667
1668 * dired.c (directory_files_internal_unwind): Now static.
1669
1670 * fileio.c (file_name_as_directory, directory_file_name):
1671 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1672 Now static.
1673 (file_name_as_directory): Use const pointers when appropriate.
1674 (Fexpand_file_name): Likewise. In particular, newdir might
1675 point at constant storage, so make it a const pointer.
1676 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1677 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1678 signedness issues.
1679 (Fset_file_times, Finsert_file_contents, auto_save_error):
1680 Rename locals to avoid shadowing.
1681
1682 * minibuf.c (choose_minibuf_frame_1): Now static.
1683 (Ftry_completion, Fall_completions): Rename or remove locals
1684 to avoid shadowing.
1685
1686 * marker.c (bytepos_to_charpos): Remove; unused.
1687
1688 * lisp.h (verify_bytepos, count_markers): New decls,
1689 so that gcc does not warn that these functions aren't declared.
1690
1691 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1692 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1693 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1694 (copy_text): Remove unused local var.
1695
1696 * filelock.c (within_one_second): Now static.
1697 (lock_file_1): Rename local to avoid shadowing.
1698
1699 * buffer.c (fix_overlays_before): Mark locals as initialized.
1700 (fix_start_end_in_overlays): Likewise. This function should be
1701 simplified by using pointers-to-pointers, but that's a different
1702 matter.
1703 (switch_to_buffer_1): Now static.
1704 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1705 (report_overlay_modification): Rename locals to avoid shadowing.
1706
1707 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1708 Fix pointer signedness issue.
1709 (sys_subshell): Mark local as volatile if checking for lint,
1710 to suppress a gcc -Wclobbered warning that does not seem to be right.
1711 (MAXPATHLEN): Define only if needed.
1712
1713 * process.c (serial_open, serial_configure): Move decls from here ...
1714 * systty.h: ... to here, so that they can be checked.
1715
1716 * fns.c (get_random, seed_random): Move extern decls from here ...
1717 * lisp.h: ... to here, so that they can be checked.
1718
1719 * sysdep.c (reset_io): Now static.
1720 (wait_for_termination_signal): Remove; unused.
1721
1722 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1723 (copy_keymap_item, append_key, push_text_char_description):
1724 Now static.
1725 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1726 (DENSE_TABLE_SIZE): Remove; unused.
1727 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1728 (describe_map_tree):
1729 Rename locals to avoid shadowing.
1730
1731 * keyboard.c: Declare functions static if they are not used elsewhere.
1732 (echo_char, echo_dash, cmd_error, top_level_2):
1733 (poll_for_input, handle_async_input): Now static.
1734 (read_char, kbd_buffer_get_event, make_lispy_position):
1735 (make_lispy_event, make_lispy_movement, apply_modifiers):
1736 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1737 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1738 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1739 (read_key_sequence, read_char): Mark locals as initialized.
1740 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1741
1742 * keyboard.h (make_ctrl_char): New decl.
1743 (mark_kboards): Move decl here ...
1744 * alloc.c (mark_kboards): ... from here.
1745
1746 * lisp.h (force_auto_save_soon): New decl.
1747
1748 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1749 (DEFINE_DUMMY_FUNCTION): New macro.
1750 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1751 Use it.
1752 (main): Add casts to avoid warnings
1753 if GCC considers string literals to be constants.
1754
1755 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1756
1757 * dbusbind.c: Pointer signedness fixes.
1758 (xd_signature, xd_append_arg, xd_initialize):
1759 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1760 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1761 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1762 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1763
1764 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1765 if GCC considers string literals to be constants.
1766 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1767
17682011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1769
1770 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1771 (print_preprocess, print_object): New macro to fix last change.
1772
1773 * print.c (print_preprocess): Don't forget font objects.
1774
17752011-03-16 Juanma Barranquero <lekktu@gmail.com>
1776
1777 * emacs.c (USAGE3): Doc fixes.
1778
17792011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1780
1781 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1782 structure.
1783
17842011-03-14 Juanma Barranquero <lekktu@gmail.com>
1785
1786 * lisp.h (VWindow_system, Qfile_name_history):
1787 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1788 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1789 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1790
1791 * w32select.c: Don't #include "keyboard.h".
1792 (run_protected): Add extern declaration for waiting_for_input.
1793
1794 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1795 * w32console.c (detect_input_pending, read_input_pending)
1796 (encode_terminal_code):
1797 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1798 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1799 (w32_system_caret_y, Qfile_name_history):
1800 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1801 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1802 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1803 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1804 * w32proc.c (Qlocal, report_file_error):
1805 * w32term.c (Vwindow_system, updating_frame):
1806 * w32uniscribe.c (initialized, uniscribe_font_driver):
1807 Remove unneeded extern declarations.
1808
18092011-03-14 Chong Yidong <cyd@stupidchicken.com>
1810
1811 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1812
18132011-03-13 Chong Yidong <cyd@stupidchicken.com>
1814
1815 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1816 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1817 These macros can no longer be used for assignment.
1818
1819 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1820 Assign struct members directly, instead of using BUF_BEGV etc.
1821 (record_buffer_markers, fetch_buffer_markers): New functions for
1822 recording and fetching special buffer markers.
1823 (set_buffer_internal_1, set_buffer_temp): Use them.
1824
1825 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1826
1827 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1828
1829 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1830 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1831
1832 * xdisp.c (hscroll_window_tree):
1833 (reconsider_clip_changes): Use PT instead of BUF_PT.
1834
18352011-03-13 Eli Zaretskii <eliz@gnu.org>
1836
1837 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1838 $(EMACS_ROOT)/lib/intprops.h.
1839
18402011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1841
1842 Fix more problems found by GCC 4.5.2's static checks.
1843
1844 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1845 to unsigned char * to avoid compiler diagnostic.
1846 (xg_free_frame_widgets): Make it clear that a local variable is
1847 needed only if USE_GTK_TOOLTIP.
1848 (gdk_window_get_screen): Make it clear that this macro is needed
1849 only if USE_GTK_TOOLTIP.
1850 (int_gtk_range_get_value): New function, which avoids a diagnostic
1851 from gcc -Wbad-function-cast.
1852 (xg_set_toolkit_scroll_bar_thumb): Use it.
1853 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1854 diagnostic from gcc -Wbad-function-cast.
1855 (get_utf8_string, xg_get_file_with_chooser):
1856 Rename locals to avoid shadowing.
1857 (create_dialog): Move locals to avoid shadowing.
1858
1859 * xgselect.c (xg_select): Remove unused var.
1860
1861 * image.c (four_corners_best): Mark locals as initialized.
1862 (gif_load): Initialize transparent_p to zero (Bug#8238).
1863 Mark another local as initialized.
1864 (my_png_error, my_error_exit): Mark with NO_RETURN.
1865
1866 * image.c (clear_image_cache): Now static.
1867 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1868 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1869 (x_edge_detection): Remove unnecessary cast that
1870 gcc -Wbad-function-cast diagnoses.
1871 (gif_load): Fix pointer signedness.
1872 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1873 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1874
18752011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 Improve quality of tests for time stamp overflow.
1878 For example, without this patch (encode-time 0 0 0 1 1
1879 1152921504606846976) returns the obviously-bogus value (-948597
1880 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1881 reports time overflow. See
1882 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1883 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1884 * editfns.c: Include limits.h and intprops.h.
1885 (TIME_T_MIN, TIME_T_MAX): New macros.
1886 (time_overflow): Move earlier, to before first use.
1887 (hi_time, lo_time): New functions, for an accurate test for
1888 out-of-range times.
1889 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1890 (Fget_internal_run_time): Don't assume time_t fits in int.
1891 (make_time): Use list2 instead of Fcons twice.
1892 (Fdecode_time): More accurate test for out-of-range times.
1893 (check_tm_member): New function.
1894 (Fencode_time): Use it, to test for out-of-range times.
1895 (lisp_time_argument): Don't rely on undefined left-shift and
1896 right-shift behavior when checking for time stamp overflow.
1897
1898 * editfns.c (time_overflow): New function, refactoring common code.
1899 (Fformat_time_string, Fdecode_time, Fencode_time):
1900 (Fcurrent_time_string): Use it.
1901
1902 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1903 * dired.c (make_time): Move to ...
1904 * editfns.c (make_time): ... here.
1905 * systime.h: Note the move.
1906
19072011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1908
1909 * fringe.c (update_window_fringes): Remove unused variables.
1910
1911 * unexmacosx.c (copy_data_segment): Also copy __got section.
1912 (Bug#8223)
1913
19142011-03-12 Eli Zaretskii <eliz@gnu.org>
1915
1916 * termcap.c [MSDOS]: Include "msdos.h".
1917 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1918 Constify `char *' arguments and their references according to
1919 prototypes in tparam.h.
1920
1921 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1922
1923 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1924 Adapt all references accordingly.
1925
1926 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1927
19282011-03-11 Tom Tromey <tromey@redhat.com>
1929
1930 * buffer.c (syms_of_buffer): Remove obsolete comment.
1931
19322011-03-11 Eli Zaretskii <eliz@gnu.org>
1933
1934 * termhooks.h (encode_terminal_code): Declare prototype.
1935
1936 * msdos.c (encode_terminal_code): Don't declare prototype.
1937
1938 * term.c (encode_terminal_code): Now external again, used by
1939 w32console.c and msdos.c.
1940
1941 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1942 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1943
19442011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1945
1946 Fix some minor problems found by GCC 4.5.2's static checks.
1947
1948 * fringe.c (update_window_fringes): Mark locals as initialized
1949 (Bug#8227).
1950 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1951
1952 * alloc.c (mark_fringe_data): Move decl from here ...
1953 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1954 to check its interface.
1955 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1956
1957 * fontset.c (free_realized_fontset): Now static.
1958 (Fset_fontset_font): Rename local to avoid shadowing.
1959 (fontset_font): Mark local as initialized.
1960 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1961
1962 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1963
1964 * xselect.c (x_disown_buffer_selections): Remove; not used.
1965 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1966 (x_own_selection, Fx_disown_selection_internal): Rename locals
1967 to avoid shadowing.
1968 (x_handle_dnd_message): Remove local to avoid shadowing.
1969
1970 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1971 so that the caller can use some name other than gcpro1.
1972 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1973 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1974 (Fx_backspace_delete_keys_p):
1975 Use them to avoid shadowing, and rename vars to avoid shadowing.
1976 (x_decode_color, x_set_name, x_window): Now static.
1977 (Fx_create_frame): Add braces to silence GCC warning.
1978 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1979 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1980 Remove unused locals.
1981 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1982 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1983 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1984 macros.
1985
1986 * xterm.h (x_mouse_leave): New decl.
1987
1988 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1989 Remove unused functions.
1990 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1991 (x_calc_absolute_position): Now static.
1992 (XTread_socket): Don't define label "out" unless it's used.
1993 Don't declare local "event" unless it's used.
1994 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1995 unless they are used.
1996 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1997 (x_fatal_error_signal): Remove; not used.
1998 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1999 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2000 (x_error_catcher, x_connection_closed, x_error_handler):
2001 (x_error_quitter, xembed_send_message, x_iconify_frame):
2002 (my_log_handler): Rename locals to avoid shadowing.
2003 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2004 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2005
2006 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2007 Rename or move locals to avoid shadowing.
2008 (tty_defined_color, merge_face_heights): Now static.
2009 (free_realized_faces_for_fontset): Remove; not used.
2010 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2011 does not deduce is never used uninitialized.
2012 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2013 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2014
2015 * terminal.c (store_terminal_param): Now static.
2016
2017 * xmenu.c (menu_highlight_callback): Now static.
2018 (set_frame_menubar): Remove unused local.
2019 (xmenu_show): Rename parameter to avoid shadowing.
2020 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2021 since they might point to immutable storage.
2022 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2023 since it's unused otherwise.
2024
2025 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2026 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2027 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2028 avoids a gcc -Wuninitialized diagnostic.
2029 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2030 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2031 does not deduce are never used uninitialized.
2032
2033 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2034
2035 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2036 * window.c (window_loop, size_window):
2037 (run_window_configuration_change_hook, enlarge_window): Likewise.
2038
2039 * window.c (display_buffer): Now static.
2040 (size_window): Mark variables that gcc -Wuninitialized
2041 does not deduce are never used uninitialized.
2042 * window.h (check_all_windows): New decl, to forestall
2043 gcc -Wmissing-prototypes diagnostic.
2044 * dispextern.h (bidi_dump_cached_states): Likewise.
2045
2046 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2047 shadowing.
2048 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2049 Include <limits.h>.
2050 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2051 and to avoid gcc -Wuninitialized warning.
2052 (load_charset_map): Mark variables that gcc -Wuninitialized
2053 does not deduce are never used uninitialized.
2054 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2055
2056 * coding.c (coding_set_source, coding_set_destination):
2057 Use "else { /* comment */ }" rather than "else /* comment */;"
2058 for clarity, and to avoid gcc -Wempty-body warning.
2059 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2060 a block, when the outer 'i' will do.
2061 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2062 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2063 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2064 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2065 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2066 Rename locals to avoid shadowing.
2067 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2068 * coding.c (emacs_mule_char, encode_invocation_designation):
2069 Now static, since they're not used elsewhere.
2070 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2071 (decode_coding_object, encode_coding_object, detect_coding_system):
2072 (decode_coding_emacs_mule): Mark variables that gcc
2073 -Wuninitialized does not deduce are never used uninitialized.
2074 (detect_coding_iso_2022): Initialize a local variable that might
2075 be used uninitialized. Leave a FIXME because it's not clear that
2076 this initialization is needed. (Bug#8211)
2077 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2078 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2079 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2080 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2081 Remove unused macros.
2082
2083 * category.c (hash_get_category_set): Remove unused local var.
2084 (copy_category_table): Now static, since it's not used elsewhere.
2085 * character.c (string_count_byte8): Likewise.
2086
2087 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2088 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2089
2090 * chartab.c (copy_sub_char_table): Now static, since it's not used
2091 elsewhere.
2092 (sub_char_table_ref_and_range, char_table_ref_and_range):
2093 Rename locals to avoid shadowing.
2094 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2095
2096 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2097 (BIDI_BOB): Remove unused macro.
2098
2099 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2100 deduce are never used uninitialized.
2101 * term.c (encode_terminal_code): Likewise.
2102
2103 * term.c (encode_terminal_code): Now static. Remove unused local.
2104
2105 * tparam.h: New file.
2106 * term.c, tparam.h: Include it.
2107 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2108 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2109 Move these decls to tparam.h, and make them agree with what
2110 is actually in tparam.c. The previous trick of using incompatible
2111 decls in different modules does not conform to the C standard.
2112 All callers of tparam changed to use tparam's actual API.
2113 * tparam.c (tparam1, tparam, tgoto):
2114 Use const pointers where appropriate.
2115
2116 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2117 * cm.h (struct cm): Likewise.
2118 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2119 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2120 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2121 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2122 (turn_on_face, init_tty): Likewise.
2123 * termchar.h (struct tty_display_info): Likewise.
2124
2125 * term.c (term_mouse_position): Rename local to avoid shadowing.
2126
2127 * alloc.c (mark_ttys): Move decl from here ...
2128 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2129
21302011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2131
2132 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2133
21342011-03-09 Juanma Barranquero <lekktu@gmail.com>
2135
2136 * search.c (compile_pattern_1): Remove argument regp, unused since
2137 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2138 (compile_pattern): Don't pass it.
2139
21402011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2141
2142 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2143 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2144 for ! HAVE_GTK3.
2145 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2146
2147 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2148
2149 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2150 gdk_window_get_screen, gdk_window_get_geometry,
2151 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2152 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2153 (xg_get_pixbuf_from_pixmap): New function.
2154 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2155 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2156 Call xg_get_pixbuf_from_pixmap instead of
2157 gdk_pixbuf_get_from_drawable.
2158 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2159 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2160 (xg_check_special_colors): Use GtkStyleContext and its functions
2161 for HAVE_GTK3.
2162 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2163 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2164 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2165 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2166 Call gtk_widget_get_preferred_size.
2167 (xg_frame_resized): gdk_window_get_geometry only takes 5
2168 parameters.
2169 (xg_win_to_widget, xg_event_is_for_menubar):
2170 Call gdk_x11_window_lookup_for_display.
2171 (xg_set_widget_bg): New function.
2172 (delete_cb): New function.
2173 (xg_create_frame_widgets): connect delete-event to delete_cb.
2174 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2175 (xg_set_background_color): Call xg_set_widget_bg.
2176 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2177 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2178 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2179 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2180 if ! HAVE_GTK3.
2181 (update_frame_tool_bar): Call gtk_widget_hide.
2182 (xg_initialize): Use GDK_KEY_g.
2183
2184 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2185 if ! HAVE_GTK3
2186 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2187
2188 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2189 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2190 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2191
21922011-03-08 Juanma Barranquero <lekktu@gmail.com>
2193
2194 * w32xfns.c (select_palette): Check success of RealizePalette against
2195 GDI_ERROR, not zero.
2196
2197See ChangeLog.11 for earlier changes.
2198
2199;; Local Variables:
2200;; coding: utf-8
2201;; End:
2202
2203 Copyright (C) 2011 Free Software Foundation, Inc.
2204
2205 This file is part of GNU Emacs.
2206
2207 GNU Emacs is free software: you can redistribute it and/or modify
2208 it under the terms of the GNU General Public License as published by
2209 the Free Software Foundation, either version 3 of the License, or
2210 (at your option) any later version.
2211
2212 GNU Emacs is distributed in the hope that it will be useful,
2213 but WITHOUT ANY WARRANTY; without even the implied warranty of
2214 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2215 GNU General Public License for more details.
2216
2217 You should have received a copy of the GNU General Public License
2218 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.