run-hooks-with-args-* do fixes (bug#12393)
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12012-09-18 Glenn Morris <rgm@gnu.org>
2
3 * eval.c (Frun_hook_with_args_until_success)
4 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
5
62012-09-14 Andreas Schwab <schwab@linux-m68k.org>
7
8 * fileio.c (Ffile_selinux_context): Only call freecon when
9 lgetfilecon succeeded.
10 (Fset_file_selinux_context): Likewise. (Bug#12444)
11
122012-09-12 Eli Zaretskii <eliz@gnu.org>
13
14 * xdisp.c (try_window_reusing_current_matrix): Under bidi
15 reordering, locate the cursor by calling set_cursor_from_row; if
16 that fails, clear the desired glyph matrix before returning a
17 failure indication to the caller. Fixes leaving garbled display
18 when fast scrolling with a down-key. (Bug#12403)
19 (compute_stop_pos_backwards): Fix a typo that caused crashes while
20 scrolling through multibyte text.
21
222012-09-12 Jan Djärv <jan.h.d@swipnet.se>
23
24 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
25 does not become zero (Bug#12234). Backport from trunk.
26
272012-08-24 Chong Yidong <cyd@gnu.org>
28
29 * Version 24.2 released.
30
312012-08-24 Eli Zaretskii <eliz@gnu.org>
32
33 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
34 is not one of the heaps we manage. (Bug#12242)
35
362012-08-14 Glenn Morris <rgm@gnu.org>
37
38 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
39
402012-08-14 Ulrich Mueller <ulm@gentoo.org>
41
42 * systime.h (EMACS_TIME_CMP): Don't cast time_t values to long
43 (Bug#11712).
44
452012-08-13 Eli Zaretskii <eliz@gnu.org>
46
47 * w32menu.c: Include w32heap.h.
48 (add_menu_item): If the call to AppendMenuW (via
49 unicode_append_menu) fails, disable Unicode menus only if we are
50 running on Windows 9X/Me.
51
52 * makefile.w32-in ($(BLD)/w32menu.$(O)): Depend on w32heap.h.
53
54 * window.c (Fdelete_other_windows_internal)
55 (Fdelete_window_internal): Don't access frame's mouse highlight
56 info of the initial frame. (Bug#11677)
57
582012-08-12 Jan Djärv <jan.h.d@swipnet.se>
59
60 * nsterm.m (ns_read_socket): Return early if there is a modal
61 window (Bug#12043).
62
63 * nsmenu.m (Popdown_data): New struct.
64 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
65 free Popdown_data.
66 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
67 (initWithContentRect): Make imgView and contentView non-static
68 and autorelease them. Also autorelease img and matrix (Bug#12005).
69 (dealloc): Remove (Bug#12005).
70
71 * nsterm.m (keyDown:): Interpret flags without left/right bits
72 as the left key (Bug#11670).
73
74 * nsmenu.m (ns_update_menubar): Add braces to ambigous if-else.
75
762012-08-08 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
77
78 * unexmacosx.c (copy_data_segment): Copy initialized data in
79 statically linked libraries from input file rather than memory.
80
812012-08-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
82
83 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
84 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
85 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
86
872012-07-19 Chong Yidong <cyd@gnu.org>
88
89 * window.c (Fwindow_absolute_pixel_edges)
90 (Fdelete_other_windows_internal): Signal an error if the window is
91 on a dead frame (Bug#11984).
92
932012-07-14 Eli Zaretskii <eliz@gnu.org>
94
95 Remove FILE_SYSTEM_CASE.
96 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
97
98 * fileio.c (FILE_SYSTEM_CASE): Don't define.
99 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
100 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
101 call-process-region passes it through expand-file-name.
102
103 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
104
1052012-07-12 Andreas Schwab <schwab@linux-m68k.org>
106
107 Fix crash when creating indirect buffer (Bug#11917)
108 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
109 Don't handle unbound variables specially if non-zero.
110 (Fbuffer_local_variables): Pass zero.
111 (clone_per_buffer_values): Pass non-zero.
112
1132012-06-28 Andreas Schwab <schwab@linux-m68k.org>
114
115 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
116 to make the loop interruptible.
117
1182012-06-26 Andreas Schwab <schwab@linux-m68k.org>
119
120 * gnutls.c (emacs_gnutls_handshake): Only retry if
121 GNUTLS_E_INTERRUPTED.
122
1232012-06-23 Eli Zaretskii <eliz@gnu.org>
124
125 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
126 in the logic of incrementing and decrementing the value of
127 use_relocatable_buffers.
128
1292012-06-21 Glenn Morris <rgm@gnu.org>
130
131 * charset.c (init_charset): Make lack of etc/charsets fatal.
132
1332012-06-11 Jan Djärv <jan.h.d@swipnet.se>
134
135 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
136 referenced (Bug#11583).
137
1382012-06-01 Chong Yidong <cyd@gnu.org>
139
140 * Version 24.1 released.
141
1422012-05-30 Eli Zaretskii <eliz@gnu.org>
143
144 * xdisp.c (handle_stop): Detect whether we have overlay strings
145 loaded by testing it->current.overlay_string_index to be
146 non-negative, instead of checking whether n_overlay_strings is
147 positive. (Bug#11587)
148
1492012-05-30 Chong Yidong <cyd@gnu.org>
150
151 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
152
153 * doc.c (Fsubstitute_command_keys): Doc fix.
154
1552012-05-29 Eli Zaretskii <eliz@gnu.org>
156
157 * search.c (search_buffer): Remove calls to
158 r_alloc_inhibit_buffer_relocation, as it is now called by
159 maybe_unify_char, which was the cause of relocation of buffer text
160 in bug#11519.
161
1622012-05-23 Eli Zaretskii <eliz@gnu.org>
163
164 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
165 for the duration of call to load_charset, to avoid problems with
166 callers of maybe_unify_char that access buffer text through C
167 pointers.
168
169 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
170 decrement the inhibition flag, instead of just setting or
171 resetting it.
172
1732012-05-24 Ken Brown <kbrown@cornell.edu>
174
175 * callproc.c (Fcall_process): Restore a line that was accidentally
176 commented out in the 2011-02-13 change (bug#11547).
177
1782012-05-23 Eli Zaretskii <eliz@gnu.org>
179
180 * lisp.h [REL_ALLOC]: Add prototypes for external functions
181 defined on ralloc.c.
182
183 * buffer.c [REL_ALLOC]: Remove prototypes of
184 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
185 they are now on lisp.h.
186
187 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
188
189 * search.c (search_buffer): Use it to inhibit relocation of buffer
190 text while re_search_2 is doing its job, because re_search_2 is
191 passed C pointers to buffer text. (Bug#11519)
192
1932012-05-21 Eli Zaretskii <eliz@gnu.org>
194
195 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
196 Update value to 24.
197
1982012-05-19 Eli Zaretskii <eliz@gnu.org>
199
200 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
201 state after an additional call to move_it_in_display_line_to, keep
202 the values of it->max_ascent and it->max_descent found for the
203 entire line.
204 (pos_visible_p): Revert the comparison against bottom_y to what it
205 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
206 (Bug#11464)
207
2082012-05-15 Eli Zaretskii <eliz@gnu.org>
209
210 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
211
2122012-05-13 Eli Zaretskii <eliz@gnu.org>
213
214 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
215 already have overlays loaded.
216 (handle_single_display_spec): Before returning without displaying
217 fringe bitmap, synchronize the bidi iterator with the main display
218 iterator, by calling iterate_out_of_display_property.
219 (iterate_out_of_display_property): Detect buffer iteration by
220 testing that it->string is a Lisp string.
221 (get_next_display_element): When the current object is exhausted,
222 and there's something on it->stack, call set_iterator_to_next to
223 proceed with what's on the stack, instead of returning zero.
224 (set_iterator_to_next): If called at the end of a Lisp string,
225 proceed to consider_string_end without incrementing string
226 position. Don't increment display vector index past the end of
227 the display vector. (Bug#11417)
228 (pos_visible_p): Don't report a position visible when move_it_to
229 stopped at the last line of window, which happens to be scanned
230 backwards by the bidi iteration. (Bug#11464)
231
2322012-05-11 Eli Zaretskii <eliz@gnu.org>
233
234 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
235 and right-margin display specs even if the spec is invalid or we
236 are on a TTY, and thus unable to display on the fringes. That's
237 because the text with the property will not be displayed anyway,
238 so we need to signal to the caller that this is a "replacing"
239 display spec. This fixes display when the spec is invalid or we
240 are on a TTY.
241
2422012-05-09 Paul Eggert <eggert@cs.ucla.edu>
243
244 * unexaix.c (make_hdr): Fix typo in prototype.
245 This bug broke the build on AIX. Problem reported by Gilles Pion.
246
2472012-05-05 Eli Zaretskii <eliz@gnu.org>
248
249 * w32proc.c (new_child): Force Windows to reserve only 64KB of
250 stack for each reader_thread, instead of defaulting to 8MB
251 determined by the linker. This avoids failures in creating
252 subprocesses on Windows 7, see the discussion in this thread:
253 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
254
2552012-05-02 Jim Meyering <meyering@redhat.com>
256
257 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
258
2592012-04-29 Eli Zaretskii <eliz@gnu.org>
260
261 * xdisp.c (pos_visible_p): If already at a newline from the
262 display string before the 'while' loop, don't walk back the glyphs
263 from it3.glyph_row. Solves assertion violation when the display
264 string begins with a newline (egg.el). (Bug#11367)
265
2662012-04-24 Chong Yidong <cyd@gnu.org>
267
268 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
269
2702012-04-23 Eli Zaretskii <eliz@gnu.org>
271
272 * xdisp.c (pos_visible_p): If the window start position is beyond
273 ZV, start the display from buffer beginning. Prevents assertion
274 violation in init_iterator when the minibuffer window is scrolled
275 via the scroll bar.
276
277 * window.c (window_scroll_pixel_based): Likewise.
278
2792012-04-23 Chong Yidong <cyd@gnu.org>
280
281 * keymap.c (where_is_internal): Doc fix (Bug#10872).
282
2832012-04-20 Glenn Morris <rgm@gnu.org>
284
285 * fileio.c (Fcopy_file, Fset_file_selinux_context):
286 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
287
2882012-04-20 Eli Zaretskii <eliz@gnu.org>
289
290 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
291 overrun array limits of glyph row's used[] array. (Bug#11288)
292
2932012-04-20 Chong Yidong <cyd@gnu.org>
294
295 * process.c (wait_reading_process_output): If EIO occurs on a pty,
296 set the status to "failed" and ensure that sentinel is run.
297
2982012-04-18 Glenn Morris <rgm@gnu.org>
299
300 * process.c (Fset_process_inherit_coding_system_flag)
301 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
302 (Fmake_network_process, Fmake_serial_process): Doc fix.
303
3042012-04-17 Eli Zaretskii <eliz@gnu.org>
305
306 * xdisp.c (string_buffer_position_lim): Limit starting position to
307 BEGV.
308 (set_cursor_from_row): If called for a mode-line or header-line
309 row, return zero immediately.
310 (try_cursor_movement): If inside continuation line, don't back up
311 farther than the first row after the header line, if any. Don't
312 consider the header-line row as "partially visible", even if
313 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
314
3152012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
316
317 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
318
3192012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
320
321 * process.c (make_process):
322 * process.h: Add integer `gnutls_handshakes_tried' member to
323 process struct.
324
325 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
326 Add convenience `GNUTLS_LOG2i' macro.
327
328 * gnutls.c (gnutls_log_function2i): Convenience log function.
329 (emacs_gnutls_read): Use new log functions,
330 `gnutls_handshakes_tried' process member, and
331 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
332 attempts per process (connection).
333
3342012-04-09 Eli Zaretskii <eliz@gnu.org>
335
336 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
337 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
338
3392012-04-09 Jan Djärv <jan.h.d@swipnet.se>
340
341 * nsterm.m (constrainFrameRect): Always constrain when there is only
342 one screen (Bug#10962).
343
3442012-04-06 Eli Zaretskii <eliz@gnu.org>
345
346 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
347 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
348 about subtle differences between FETCH_CHAR* and STRING_CHAR*
349 macros related to unification of CJK characters. For the details,
350 see the discussion following the message here:
351 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
352
3532012-04-04 Chong Yidong <cyd@gnu.org>
354
355 * keyboard.c (Vdelayed_warnings_list): Doc fix.
356
3572012-04-01 Eli Zaretskii <eliz@gnu.org>
358
359 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
360 instead of alloca. (Bug#11138)
361
3622012-04-01 Andreas Schwab <schwab@linux-m68k.org>
363
364 * w32menu.c (is_simple_dialog): Properly check lisp types.
365 (Bug#11141)
366
3672012-03-31 Eli Zaretskii <eliz@gnu.org>
368
369 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
370 position we get to after a call to move_it_to fails the
371 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
372 only if we wind up in a string from display property. (Bug#11063)
373
374 * window.c (Fdelete_other_windows_internal): Invalidate the row
375 and column information about mouse highlight, so that redisplay
376 restores it after reallocating the glyph matrices. (Bug#7464)
377
378 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
379 string comes from a `display' text property, use the buffer
380 position of that property as if we actually saw that position in
381 the row's glyphs.
382 (move_it_by_lines): Remove the assertion that
383 "it->current_x == 0 && it->hpos == 0" which can be legitimately
384 violated when there's a before-string at the beginning of a line.
385 (Bug#11063)
386
3872012-03-30 Eli Zaretskii <eliz@gnu.org>
388
389 * xdisp.c (append_space_for_newline): If the default face was
390 remapped, use the remapped face for the appended newline.
391 (extend_face_to_end_of_line): Use the remapped default face for
392 extending the face to the end of the line.
393 (display_line): Call extend_face_to_end_of_line when the default
394 face was remapped. (Bug#11068)
395
3962012-03-29 Eli Zaretskii <eliz@gnu.org>
397
398 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
399
4002012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
401
402 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
403
4042012-03-27 Glenn Morris <rgm@gnu.org>
405
406 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
407 Doc fixes.
408
4092012-03-26 Kenichi Handa <handa@m17n.org>
410
411 * dispextern.h (struct glyph): Fix previous change. Change the
412 bit length of glyphless.ch to 25 (Bug#11082).
413
4142012-03-26 Chong Yidong <cyd@gnu.org>
415
416 * keyboard.c (Vselection_inhibit_update_commands): New variable.
417 (command_loop_1): Use it; inhibit selection update for
418 handle-select-window too (Bug#8996).
419
4202012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
421
422 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
423
4242012-03-25 Kenichi Handa <handa@m17n.org>
425
426 * dispextern.h (struct glyph): Change the bit length of
427 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
428
4292012-03-24 Eli Zaretskii <eliz@gnu.org>
430
431 * s/ms-w32.h (tzname): Include time.h before redirecting to
432 _tzname. Fixes the MSVC build. (Bug#9960)
433
4342012-03-24 Andreas Schwab <schwab@linux-m68k.org>
435
436 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
437 characters.
438
439 * xterm.c (XTread_socket): Only modify handling_signal if
440 !SYNC_INPUT. (Bug#11080)
441
4422012-03-23 Eli Zaretskii <eliz@gnu.org>
443
444 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
445 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
446 when fetching a multibyte character consumes more bytes than
447 CHAR_BYTES returns, due to unification of CJK characters in
448 string_char. (Bug#11073)
449
4502012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
451
452 * process.c (wait_reading_process_output): Handle pty disconnect
453 by refraining from sending oneself a SIGCHLD (bug#10933).
454
4552012-03-22 Chong Yidong <cyd@gnu.org>
456
457 * dispextern.h (struct it): New member string_from_prefix_prop_p.
458
459 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
460 Mark string as coming from a prefix property.
461 (handle_face_prop): Use default face for prefix strings (Bug#4281).
462 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
463
4642012-03-21 Chong Yidong <cyd@gnu.org>
465
466 * xfaces.c (Vface_remapping_alist): Doc fix.
467
4682012-03-20 Eli Zaretskii <eliz@gnu.org>
469
470 * w32proc.c (Fw32_set_console_codepage)
471 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
472 Doc fixes.
473
4742012-03-20 Chong Yidong <cyd@gnu.org>
475
476 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
477 to reflect default non-nil value of redisplay-dont-pause.
478
4792012-03-19 Kenichi Handa <handa@m17n.org>
480
481 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
482 it fit in a valid range (Bug#11003).
483
4842012-03-18 Eli Zaretskii <eliz@gnu.org>
485
486 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
487 that is not from display property, accept the row as a "cursor
488 row" if one of the string's character has a non-nil `cursor'
489 property. Fixes cursor positioning when there are newlines in
490 overlay strings, e.g. in icomplete.el. (Bug#11035)
491
4922012-03-12 Paul Eggert <eggert@cs.ucla.edu>
493
494 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
495
4962012-03-12 Chong Yidong <cyd@gnu.org>
497
498 * eval.c (inhibit_lisp_code): Rename from
499 inhibit_window_configuration_change_hook; move from window.c.
500
501 * xfns.c (unwind_create_frame_1, Fx_create_frame):
502 * window.c (run_window_configuration_change_hook)
503 (syms_of_window): Callers changed.
504
5052012-03-11 Chong Yidong <cyd@gnu.org>
506
507 * keymap.c (Fkey_description): Doc fix (Bug#9700).
508
509 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
510
5112012-03-10 Chong Yidong <cyd@gnu.org>
512
513 * frame.c (other_visible_frames): Don't assume the selected frame
514 is visible (Bug#10955).
515
5162012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
517
518 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
519
5202012-03-08 Jan Djärv <jan.h.d@swipnet.se>
521
522 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
523 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
524 zero (Bug#10954).
525
5262012-03-03 Glenn Morris <rgm@gnu.org>
527
528 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
529
5302012-03-02 Eli Zaretskii <eliz@gnu.org>
531
532 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
533 position past the first glyph_row that ends at ZV. (Bug#10902)
534 (redisplay_window, next_element_from_string): Fix typos in
535 comments.
536 (redisplay_window): Pass to move_it_vertically the margin in
537 pixels, not in screen lines.
538
5392012-03-02 Glenn Morris <rgm@gnu.org>
540
541 * buffer.c (buffer-list-update-hook): Doc fix.
542
5432012-02-29 Eli Zaretskii <eliz@gnu.org>
544
545 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
546 push_it before setting up the iterator for the first overlay
547 string, even if we have an empty string loaded.
548 (next_overlay_string): If there's an empty string on the iterator
549 stack, pop the stack. (Bug#10903)
550
5512012-02-25 Paul Eggert <eggert@cs.ucla.edu>
552
553 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
554 Suggested by Stefan Monnier in
555 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
556 * alloc.c (widen_to_Lisp_Object): New static function.
557 (mark_memory): Also mark Lisp_Objects by fetching pointer words
558 and widening them to Lisp_Objects. This would work even if
559 USE_LSB_TAG is defined and wide integers are used, which might
560 happen in a future version of Emacs.
561
5622012-02-25 Chong Yidong <cyd@gnu.org>
563
564 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
565 Doc fix.
566
567 * xselect.c (Fx_selection_exists_p): Doc fix.
568 (x_clipboard_manager_save_all): Print an informative message
569 before saving to clipboard manager.
570
5712012-02-24 Chong Yidong <cyd@gnu.org>
572
573 * keyboard.c (process_special_events): Handle all X selection
574 requests in kbd_buffer, not just the next one (Bug#8869).
575
5762012-02-23 Chong Yidong <cyd@gnu.org>
577
578 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
579 call when setting menu-bar-lines and tool-bar-lines parameters.
580 (unwind_create_frame_1): New helper function.
581
582 * window.c (inhibit_window_configuration_change_hook): New var.
583 (run_window_configuration_change_hook): Obey it.
584 (syms_of_window): Initialize it.
585
5862012-02-22 Chong Yidong <cyd@gnu.org>
587
588 * xterm.c (x_draw_image_relief): Add missing type check for
589 Vtool_bar_button_margin (Bug#10743).
590
5912012-02-21 Chong Yidong <cyd@gnu.org>
592
593 * fileio.c (Vfile_name_handler_alist): Doc fix.
594
595 * buffer.c (Fget_file_buffer): Protect against invalid file
596 handler return value.
597
5982012-02-20 Paul Eggert <eggert@cs.ucla.edu>
599
600 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
601 when computing $valmask.
602
603 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
604 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
605 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
606 It's useless in that case, and it can cause problems on hosts
607 that allocate halves of EMACS_INT values separately.
608 Reported by Dan Horák. Diagnosed by Andreas Schwab in
609 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
610 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
611 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
612 it avoids undefined behavior on hosts where shifting right by more
613 than the word width has undefined behavior.
614
6152012-02-19 Chong Yidong <cyd@gnu.org>
616
617 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
618 (Funhandled_file_name_directory, Ffile_name_as_directory)
619 (Fdirectory_file_name, Fexpand_file_name)
620 (Fsubstitute_in_file_name): Protect against invalid file handler
621 return values (Bug#10845).
622
6232012-02-18 Eli Zaretskii <eliz@gnu.org>
624
625 * .gdbinit (pitx): Fix incorrect references to fields of the
626 iterator stack.
627
6282012-02-17 Chong Yidong <cyd@gnu.org>
629
630 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
631
6322012-02-15 Paul Eggert <eggert@cs.ucla.edu>
633
634 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
635 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
636
6372012-02-15 Chong Yidong <cyd@gnu.org>
638
639 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
640 marked as special. Also, starting docstrings with * is obsolete.
641
6422012-02-13 Andreas Schwab <schwab@linux-m68k.org>
643
644 * gnutls.c (emacs_gnutls_write): Fix last change.
645
6462012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
647
648 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
649 send_process.
650
6512012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
652
653 * keymap.c (Fsingle_key_description): Handle char ranges.
654
6552012-02-12 Chong Yidong <cyd@gnu.org>
656
657 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
658 as that creates a dangerous corner case.
659
660 * window.c (Fdelete_window_internal): Invalidate the mouse
661 highlight (Bug#9904).
662
6632012-02-12 Glenn Morris <rgm@gnu.org>
664
665 * xselect.c (Fx_own_selection_internal)
666 (Fx_get_selection_internal, Fx_disown_selection_internal)
667 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
668 * nsselect.m (Fx_own_selection_internal)
669 (Fx_disown_selection_internal, Fx_selection_exists_p)
670 (Fx_selection_owner_p, Fx_get_selection_internal):
671 Sync docs and argument specs with the xselect.c versions.
672
6732012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
674
675 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
676
6772012-02-11 Eli Zaretskii <eliz@gnu.org>
678
679 * w32select.c (Fx_selection_exists_p): Sync doc string and
680 argument list with xselect.c. (Bug#10783)
681
682 * w16select.c (Fx_selection_exists_p): Sync doc string and
683 argument list with xselect.c. (Bug#10783)
684
6852012-02-10 Glenn Morris <rgm@gnu.org>
686
687 * fns.c (Fsecure_hash): Doc fix.
688
6892012-02-09 Kenichi Handa <handa@m17n.org>
690
691 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
692
6932012-02-07 Chong Yidong <cyd@gnu.org>
694
695 * buffer.c (Fbuffer_local_variables)
696 (buffer_lisp_local_variables): Handle unbound vars correctly;
697 don't let Qunbound leak into Lisp.
698
6992012-02-07 Glenn Morris <rgm@gnu.org>
700
701 * image.c (Fimagemagick_types): Doc fix.
702
703 * image.c (imagemagick-render-type): Change it from a lisp object
704 to an integer. Move the doc here from the lisp manual.
705 Treat all values not equal to 0 the same.
706
7072012-02-06 Chong Yidong <cyd@gnu.org>
708
709 * doc.c (store_function_docstring): Avoid applying docstring of
710 alias to base function (Bug#2603).
711
7122012-02-04 Andreas Schwab <schwab@linux-m68k.org>
713
714 * .gdbinit (pp1, pv1): Remove redundant defines.
715 (pr): Use pp.
716
7172012-02-04 Chong Yidong <cyd@gnu.org>
718
719 * nsterm.m: Declare a global (Bug#10694).
720
7212012-02-04 Eli Zaretskii <eliz@gnu.org>
722
723 * w32.c (get_emacs_configuration_options):
724 Include --enable-checking, if specified, in the return value.
725
7262012-02-04 Martin Rudalics <rudalics@gmx.at>
727
728 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
729 after rounding frame sizes. (Bug#9723)
730
7312012-02-04 Eli Zaretskii <eliz@gnu.org>
732
733 * keyboard.c (adjust_point_for_property): Don't position point
734 before BEGV. (Bug#10696)
735
7362012-02-03 Paul Eggert <eggert@cs.ucla.edu>
737
738 Handle overflow when computing char display width (Bug#9496).
739 * character.c (char_width): Return EMACS_INT, not int.
740 (char_width, c_string_width): Check for overflow when
741 computing the width; this is possible now that individual
742 characters can have unbounded width. Problem introduced
743 by merge from Emacs 23 on 2012-01-19.
744
7452012-02-02 Michael Albinus <michael.albinus@gmx.de>
746
747 * dbusbind.c (Fdbus_register_method): Mention the return value
748 :ignore in the docstring.
749
7502012-02-02 Glenn Morris <rgm@gnu.org>
751
752 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
753
754 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
755 Unconditionally set to t. (Bug#10673)
756 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
757 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
758 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
759
7602012-02-02 Kenichi Handa <handa@m17n.org>
761
762 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
763 0, do not call append_composite_glyph.
764
7652012-02-02 Kenichi Handa <handa@m17n.org>
766
767 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
768 NULL (Bug#6988).
769 (x_produce_glyphs): If the component of a composition is a null
770 string, set it->pixel_width to 1 to avoid zero-width glyph.
771
7722012-02-01 Eli Zaretskii <eliz@gnu.org>
773
774 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
775 first 2 arguments are identical. This makes inserting large
776 output from a subprocess an order of magnitude faster on
777 MS-Windows, where all sbrk'ed memory is always contiguous.
778
7792012-01-31 Glenn Morris <rgm@gnu.org>
780
781 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
782 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
783 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
784
7852012-01-29 Glenn Morris <rgm@gnu.org>
786
787 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
788
7892012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
790
791 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
792
7932012-01-28 Chong Yidong <cyd@gnu.org>
794
795 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
796
7972012-01-26 Chong Yidong <cyd@gnu.org>
798
799 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
800
801 * search.c (Fsearch_forward, Fsearch_backward): Document negative
802 repeat counts (Bug#10507).
803
8042012-01-26 Glenn Morris <rgm@gnu.org>
805
806 * lread.c (syms_of_lread): Doc fix.
807
8082012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
809
810 * coding.c (encode_designation_at_bol): Change return value to
811 EMACS_INT.
812
8132012-01-25 Chong Yidong <cyd@gnu.org>
814
815 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
816
8172012-01-21 Chong Yidong <cyd@gnu.org>
818
819 * floatfns.c (Fcopysign): Make the second argument non-optional,
820 since nil is not allowed anyway.
821
8222012-01-21 Andreas Schwab <schwab@linux-m68k.org>
823
824 * process.c (read_process_output): Use p instead of XPROCESS (proc).
825 (send_process): Likewise.
826
8272012-01-19 Martin Rudalics <rudalics@gmx.at>
828
829 * window.c (save_window_save, Fcurrent_window_configuration)
830 (Vwindow_persistent_parameters): Do not use Qstate.
831 Rewrite doc-strings.
832
8332012-01-19 Kenichi Handa <handa@m17n.org>
834
835 * character.c (char_width): New function.
836 (Fchar_width, c_string_width, lisp_string_width):
837 Use char_width (Bug#9496).
838
8392012-01-16 Martin Rudalics <rudalics@gmx.at>
840
841 * window.c (Vwindow_persistent_parameters): New variable.
842 (Fset_window_configuration, save_window_save): Handle persistent
843 window parameters.
844
8452012-01-14 Eli Zaretskii <eliz@gnu.org>
846
847 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
848 thrashing the stack of the thread. (Bug#9087)
849
8502012-01-12 Paul Eggert <eggert@cs.ucla.edu>
851
852 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
853
8542012-01-11 Eli Zaretskii <eliz@gnu.org>
855
856 * xdisp.c (rows_from_pos_range): Handle the case where the
857 highlight ends on a newline. (Bug#10464)
858 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
859 he end column for display of highlight that ends on a newline
860 before a R2L line.
861
8622012-01-11 Glenn Morris <rgm@gnu.org>
863
864 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
865 from load-path also when installation-directory is nil. (Bug#10208)
866
8672012-01-10 Glenn Morris <rgm@gnu.org>
868
869 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
870
871 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
872 Update template values to be closer to their typical values these days.
873
8742012-01-09 Eli Zaretskii <eliz@gnu.org>
875
876 * xdisp.c (rows_from_pos_range): Accept additional argument
877 DISP_STRING, and accept any glyph in a row whose object is that
878 string as eligible for mouse highlight. Fixes mouse highlight of
879 display strings from overlays. (Bug#10464)
880
8812012-01-07 Paul Eggert <eggert@cs.ucla.edu>
882
883 emacs: fix an auto-save permissions race condition (Bug#10400)
884 * fileio.c (auto_saving_dir_umask): New static var.
885 (Fmake_directory_internal): Use it.
886 (do_auto_save_make_dir): Set it, instead of invoking chmod after
887 creating the directory. The old code temporarily assigns
888 too-generous permissions to the directory.
889 (do_auto_save_eh): Clear it.
890 (Fdo_auto_save): Catch all errors, not just file errors, so
891 that the var is always cleared.
892
8932012-01-07 Eli Zaretskii <eliz@gnu.org>
894
895 * search.c (scan_buffer): Pass character positions to
896 know_region_cache, not byte positions. (Bug#6540)
897
8982012-01-07 LynX <_LynX@bk.ru> (tiny change)
899
900 * w32.c (sys_rename): Report EXDEV when rename of a directory
901 fails because the target is on another logical disk. (Bug#10284)
902
9032012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
904
905 * xterm.c (x_embed_request_focus): New function.
906
907 * xterm.h: Add prototype.
908
909 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
910
9112012-01-05 Glenn Morris <rgm@gnu.org>
912
913 * emacs.c (emacs_copyright): Update short copyright year to 2012.
914
9152012-01-01 Eli Zaretskii <eliz@gnu.org>
916
917 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
918 Load gnutls_transport_set_lowat only if GnuTLS version is below
919 2.11.1.
920 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
921 GnuTLS versions below 2.11.1.
922
9232011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
924
925 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
926 to the doc string advising against its use for altering the way
927 windows are scrolled.
928
9292011-12-28 Kenichi Handa <handa@m17n.org>
930
931 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
932 coding-system ASCII compatible only when it does not produce BOM
933 on encoding (Bug#10383).
934
9352011-12-26 Jan Djärv <jan.h.d@swipnet.se>
936
937 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
938 can scroll.
939 (create_and_show_popup_menu): Always use menu_position_func for
940 Gtk3 (Bug#10361).
941
9422011-12-24 Andreas Schwab <schwab@linux-m68k.org>
943
944 * callint.c (Fcall_interactively): Don't truncate prompt string.
945
9462011-12-23 Eli Zaretskii <eliz@gnu.org>
947
948 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
949 property that ends at ZV, so that the bidi iteration could be
950 resumed from there (after widening). (Bug#10360)
951
9522011-12-22 Jan Djärv <jan.h.d@swipnet.se>
953
954 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
955
9562011-12-21 Jan Djärv <jan.h.d@swipnet.se>
957
958 * nsterm.m (x_free_frame_resources):
959 Release f->output_data.ns->miniimage.
960 (ns_index_color): Fix indentation. Do not retain
961 color_table->colors[i].
962
963 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
964 before returning.
965
966 * nsfns.m (x_set_background_color): Assign return value from
967 ns_index_color to face-background instead of NSColor*.
968 (ns_implicitly_set_icon_type): Fix indentation.
969 Change assignment in for loop to comparison.
970
971 * emacs.c (ns_pool): New variable.
972 (main): Assign ns_pool.
973 (Fkill_emacs): Call ns_release_autorelease_pool.
974
975 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
976 autorelease fdesc, release fdAttrs and tdict.
977 (ns_get_covering_families): Release charset.
978 (ns_findfonts): Release NSFontDescriptor created with new.
979 (ns_uni_to_glyphs): Fix indentation.
980 (setString): Release attrStr before assigning new value.
981
9822011-12-18 Jan Djärv <jan.h.d@swipnet.se>
983
984 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
985 and NS_IMPL_COCOA.
986 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
987 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
988
9892011-12-18 David Reitter <reitter@cmu.edu>
990
991 * nsterm.m (ns_term_init): Subscribe for notifications
992 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
993 to method trackingNotification in EmacsMenu.
994
995 * nsmenu.m (trackingMenu): New variable.
996 (trackingNotification): New method (from Aquamacs).
997 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
998 from Aquamacs (Bug#7030).
999
10002011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1001
1002 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1003 (symbol_to_nsstring): Fix indentation.
1004 (ns_symbol_to_pb): New function.
1005 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1006 (Fns_rotate_cut_buffers_internal): Remove.
1007 (Fns_store_selection_internal): Rename from
1008 Fns_store_cut_buffer_internal.
1009 (ns_get_foreign_selection, Fx_own_selection_internal)
1010 (Fx_disown_selection_internal, Fx_selection_exists_p)
1011 (Fns_get_selection_internal, Fns_store_selection_internal):
1012 Use ns_symbol_to_pb and check if return value is nil.
1013 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1014 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1015 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1016 renamed to Sns_store_selection_internal.
1017 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1018 and remove this function.
1019 (ns_handle_selection_clear): Remove, never used.
1020 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1021 here.
1022
10232011-12-17 Ken Brown <kbrown@cornell.edu>
1024
1025 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1026 GID is unknown (Bug#10257).
1027
10282011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1029
1030 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1031 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1032 which caused a build failure on GNU/Linux IA-64. This problem was
1033 introduced by my 2011-10-07 patch.
1034
10352011-12-15 Juri Linkov <juri@jurta.org>
1036
1037 * image.c (imagemagick_error): New function. (Bug#10112)
1038 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1039 Use `imagemagick_error' where ImageMagick functions return
1040 `MagickFalse'.
1041 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1042 proper order.
1043
10442011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1045
1046 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1047 fill background (Bug#8992).
1048
10492011-12-13 Martin Rudalics <rudalics@gmx.at>
1050
1051 * window.c (Vwindow_combination_resize)
1052 (Vwindow_combination_limit): Use t instead of non-nil in
1053 doc-strings.
1054 (Vrecenter_redisplay): Add first sentence of doc-string on
1055 separate line.
1056 (Frecenter): Fix doc-string typo.
1057
10582011-12-11 Kenichi Handa <handa@m17n.org>
1059
1060 * coding.c (Funencodable_char_position): Pay attention to the
1061 buffer text relocation (Bug#9389).
1062
10632011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1064
1065 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1066 gtk_init (Bug#10100).
1067
10682011-12-10 Eli Zaretskii <eliz@gnu.org>
1069
1070 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1071 IT->string is nil. (Bug#10263)
1072
10732011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1074
1075 * nsterm.h (x_free_frame_resources): Declare.
1076
1077 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1078 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1079
1080 * nsterm.h (ns_get_defaults_value): Declare.
1081
1082 * nsterm.m (ns_default): Call ns_get_defaults_value.
1083
10842011-12-09 Eli Zaretskii <eliz@gnu.org>
1085
1086 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1087 (Bug#10170)
1088
10892011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1090
1091 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1092 that where the value of an _OBJC_* symbol points to is in the .bss
1093 section (Bug#10240).
1094
10952011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1096
1097 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1098 after the loop to call ccl_driver at least once (Bug#8619).
1099
11002011-12-08 Kenichi Handa <handa@m17n.org>
1101
1102 * ftfont.c (get_adstyle_property): Fix previous change
1103 (Bug#10233).
1104
11052011-12-07 Juanma Barranquero <lekktu@gmail.com>
1106
1107 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1108 dirs from the default value of EMACSLOADPATH (bug#10208).
1109
11102011-12-07 Glenn Morris <rgm@gnu.org>
1111
1112 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1113 installation and source directories as well. (Bug#10208)
1114
11152011-12-06 Chong Yidong <cyd@gnu.org>
1116
1117 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1118
11192011-12-06 Glenn Morris <rgm@gnu.org>
1120
1121 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1122 as an error, not just -1. (Bug#10217)
1123
11242011-12-05 Chong Yidong <cyd@gnu.org>
1125
1126 * keyboard.c (process_special_events): New function.
1127 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1128
11292011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1130
1131 * coding.c (encode_designation_at_bol): Don't use uninitialized
1132 local variable (Bug#9318).
1133
11342011-12-05 Kenichi Handa <handa@m17n.org>
1135
1136 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1137 return Qnil (Bug#8046, Bug#10193).
1138
11392011-12-05 Kenichi Handa <handa@m17n.org>
1140
1141 * coding.c (encode_designation_at_bol): New args charbuf_end and
1142 dst. Return the number of produced bytes. Callers changed.
1143 (coding_set_source): Return how many bytes coding->source was
1144 relocated.
1145 (coding_set_destination): Return how many bytes
1146 coding->destination was relocated.
1147 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1148 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1149
11502011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1151
1152 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1153 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1154 macro (Bug#9318).
1155
11562011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1157
1158 The following changes are to fix Bug#9318.
1159
1160 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1161 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1162 (encode_coding_iso_2022, encode_coding_sjis)
1163 (encode_coding_big5, encode_coding_charset): Use the above macros.
1164
11652011-12-05 Juanma Barranquero <lekktu@gmail.com>
1166
1167 * lisp.h (process_quit_flag): Fix external declaration.
1168
11692011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1170
1171 Don't macro-inline non-performance-critical code.
1172 * eval.c (process_quit_flag): New function.
1173 * lisp.h (QUIT): Use it.
1174
11752011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1176
1177 * nsfns.m (get_geometry_from_preferences): New function.
1178 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1179
11802011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1181
1182 * emacs.c (Qkill_emacs): Define.
1183 (syms_of_emacs): Initialize it.
1184 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1185 Qquit_flag to `kill-emacs' instead.
1186 (quit_throw_to_read_char): Add parameter `from_signal'.
1187 All callers changed. Call Fkill_emacs if requested and safe.
1188 * lisp.h (QUIT): Call Fkill_emacs if requested.
1189
11902011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1191
1192 * widget.c (update_wm_hints): Return if wmshell is null.
1193 (widget_update_wm_size_hints): New function.
1194
1195 * widget.h (widget_update_wm_size_hints): Declare.
1196
1197 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1198 widget_update_wm_size_hints (Bug#10104).
1199
12002011-12-03 Eli Zaretskii <eliz@gnu.org>
1201
1202 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1203 before a newline, prepare the bidi iterator for consuming the
1204 newline, and keep the current paragraph direction. (Bug#10183)
1205 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1206
12072011-12-02 Juri Linkov <juri@jurta.org>
1208
1209 * search.c (Fword_search_regexp): New Lisp function created from
1210 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1211 (Fword_search_backward, Fword_search_forward)
1212 (Fword_search_backward_lax, Fword_search_forward_lax):
1213 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1214 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1215
12162011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1217
1218 * fileio.c (Finsert_file_contents): Move after-change-function call
1219 to before the "handled:" label, since all "goto handled" appear in
1220 cases where the *-change-functions have already been properly called
1221 (bug#10117).
1222
12232011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1224
1225 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1226 waiting for input. (Bug#10169)
1227
12282011-11-30 Eli Zaretskii <eliz@gnu.org>
1229
1230 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1231 verifies glyph row's hash code--we have just reallocated the
1232 glyphs, so their contents can be complete garbage. (Bug#10164)
1233
12342011-11-30 Juanma Barranquero <lekktu@gmail.com>
1235
1236 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1237
12382011-11-30 Eli Zaretskii <eliz@gnu.org>
1239
1240 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1241 attributes are tested _before_ calling verify_row_hash, to protect
1242 against GCC re-ordering of the tests. (Bug#10164)
1243
12442011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1245
1246 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1247
1248 * xterm.c (handle_one_xevent): Only set async_visible and friends
1249 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1250 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1251 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1252
12532011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1254
1255 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1256 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1257 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1258 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1259 All uses changed to use GCPRO1 etc.
1260 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1261 Revert to old implementation (i.e., before 2011-03-11).
1262
12632011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1264
1265 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1266 of scroll runs so as to avoid assigning disabled bogus rows and
1267 unnecessary graphics copy operations.
1268
12692011-11-27 Eli Zaretskii <eliz@gnu.org>
1270
1271 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1272 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1273 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1274 (malloc, free, realloc, calloc): Redirect to e_* only when
1275 compiling Emacs.
1276
1277 * lisp.h (GCTYPEBITS): Move before first use.
1278 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1279 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1280 this macro definition.
1281
1282 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1283 _MSC_VER.
1284
12852011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1286
1287 * gtkutil.c (xg_create_frame_widgets):
1288 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1289 present with Gtk+ 2.0.
1290
12912011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1292
1293 * fileio.c (Finsert_file_contents): Undo previous change; see
1294 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1295
12962011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 Rename locals to avoid shadowing.
1299 * fileio.c (Finsert_file_contents):
1300 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1301 * process.c (wait_reading_process_output):
1302 Rename inner 'proc' to 'p' to avoid shadowing.
1303 Indent for consistency with usual Emacs style.
1304
13052011-11-25 Eli Zaretskii <eliz@gnu.org>
1306
1307 * xdisp.c (redisplay_window): If cursor row is not fully visible
1308 after recentering, and scroll-conservatively is set to a large
1309 number, scroll window by a few more lines to make the cursor fully
1310 visible and out of scroll-margin. (Bug#10105)
1311 (start_display): Don't move to the next line if the display should
1312 start at a newline that is part of a display vector or an overlay
1313 string. (Bug#10119)
1314
13152011-11-24 Juri Linkov <juri@jurta.org>
1316
1317 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1318 after the `MagickPingImage' call. (Bug#10112)
1319
13202011-11-23 Chong Yidong <cyd@gnu.org>
1321
1322 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1323
13242011-11-23 Martin Rudalics <rudalics@gmx.at>
1325
1326 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1327 making another buffer current. (Bug#10114)
1328
13292011-11-23 Glenn Morris <rgm@gnu.org>
1330
1331 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1332
13332011-11-23 Chong Yidong <cyd@gnu.org>
1334
1335 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1336 using it (Bug#5984).
1337
13382011-11-22 Eli Zaretskii <eliz@gnu.org>
1339
1340 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1341 and header-lines, as they don't have one computed for them.
1342 (Bug#10098)
1343
1344 * .gdbinit (prow): Make displayed values more self-explaining.
1345 Add row's hash code.
1346
13472011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1348
1349 * process.c (wait_reading_process_output): Fix asynchrounous
1350 GnuTLS socket handling on some versions of the GnuTLS library.
1351 (wait_reading_process_output): Add comment and URL.
1352
13532011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1354
1355 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1356
13572011-11-21 Chong Yidong <cyd@gnu.org>
1358
1359 * window.c (Fnext_window, Fprevious_window): Doc fix.
1360
13612011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1362
1363 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1364
13652011-11-20 Juanma Barranquero <lekktu@gmail.com>
1366
1367 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1368
13692011-11-20 Martin Rudalics <rudalics@gmx.at>
1370
1371 * window.c (Fset_window_combination_limit): Rename argument
1372 STATUS to LIMIT.
1373 (Vwindow_combination_limit): Remove "status" from doc-string.
1374
13752011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1376
1377 * m/ibms390.h: Remove.
1378 * m/ibms390x.h: Don't include "ibms390.h".
1379
13802011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1381
1382 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1383 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1384
13852011-11-20 Juanma Barranquero <lekktu@gmail.com>
1386
1387 * casetab.c (Fset_case_table):
1388 * charset.c (Fcharset_after): Fix typos.
1389
13902011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1391
1392 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1393 Otherwise, valgrind does not work on some platforms.
1394 Problem reported by Andreas Schwab in
1395 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1396 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1397 is set, removing the need for VIRT_ADDRESS_VARIES.
1398 (PURE_P): Use a more-efficient implementation that needs just one
1399 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1400 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1401 to 4 (xorl, subq, cmpq, setbe).
1402 * alloc.c (pure): Always extern now, since that's the
1403 VIRT_ADDR_VARIES behavior.
1404 (PURE_POINTER_P): Use a single comparison, not two, for
1405 consistency with the new puresize.h.
1406 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1407 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1408 Remove VIRT_ADDR_VARIES no longer needed.
1409
14102011-11-19 Eli Zaretskii <eliz@gnu.org>
1411
1412 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1413 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1414 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1415 behave as if the cursor position were at the window margin.
1416
1417 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1418 and the cursor position is out of bounds, behave as if the cursor
1419 position were at the window margin. (Bug#10075)
1420
14212011-11-18 Chong Yidong <cyd@gnu.org>
1422
1423 * window.c (Fwindow_combination_limit): Make first argument
1424 non-optional, since it is meaningless for live windows like the
1425 selected window.
1426
14272011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1428
1429 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1430
14312011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1432
1433 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1434 (graft_intervals_into_buffer): Simplify.
1435
14362011-11-18 Eli Zaretskii <eliz@gnu.org>
1437
1438 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1439 hash values of the two rows.
1440 (copy_row_except_pointers): Preserve the used[] arrays and the
1441 hash values of the two rows. (Bug#10035)
1442 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1443
1444 * xdisp.c (row_hash): New function, body extracted from
1445 compute_line_metrics.
1446 (compute_line_metrics): Call row_hash, instead of computing the
1447 hash code inline.
1448
1449 * dispnew.c (verify_row_hash): Call row_hash for computing the
1450 hash code of a row, instead of duplicating code from xdisp.c.
1451
1452 * dispextern.h (row_hash): Add prototype.
1453
14542011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1455
1456 * frame.c (delete_frame): Don't delete the terminal when the last
1457 X frame is closed if emacs is built with GTK toolkit.
1458
14592011-11-17 Juanma Barranquero <lekktu@gmail.com>
1460
1461 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1462
14632011-11-17 Martin Rudalics <rudalics@gmx.at>
1464
1465 * window.c (Vwindow_splits): Rename to
1466 Vwindow_combination_resize. Suggested by Juri Linkov.
1467 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1468 of Vwindow_splits.
1469
14702011-11-16 Juanma Barranquero <lekktu@gmail.com>
1471
1472 * nsfns.m (Fns_font_name):
1473 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1474
14752011-11-16 Martin Rudalics <rudalics@gmx.at>
1476
1477 * window.h (window): Rename slot "nest" to "combination_limit".
1478 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1479 (Fset_window_nest): Rename to Fset_window_combination_limit.
1480 (Vwindow_nest): Rename to Vwindow_combination_limit.
1481 (recombine_windows, make_parent_window, make_window)
1482 (Fsplit_window_internal, saved_window)
1483 (Fset_window_configuration, save_window_save): Rename all
1484 occurrences of window_nest to window_combination_limit.
1485
14862011-11-15 Juanma Barranquero <lekktu@gmail.com>
1487
1488 * image.c (imagemagick_load_image): Fix typo.
1489
14902011-11-14 Eli Zaretskii <eliz@gnu.org>
1491
1492 * xdisp.c (display_line): Move the call to
1493 highlight_trailing_whitespace before the call to
1494 compute_line_metrics, since the latter needs to see the final
1495 faces of all the glyphs to compute ROW's hash value.
1496 Fixes assertion violations in row_equal_p. (Bug#10035)
1497
14982011-11-14 Juanma Barranquero <lekktu@gmail.com>
1499
1500 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1501 just return (bug#10044).
1502
15032011-11-12 Eli Zaretskii <eliz@gnu.org>
1504
1505 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1506 with user-defined heap size. Bump the default size of the temacs
1507 heap to 27MB, to avoid memory warning when running temacs.
1508 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1509
1510 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1511 current_matrix and desired_matrix. (Bug#9990)
1512 (verify_row_hash) [XASSERTS]: New function.
1513 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1514 that the hash value of glyph rows is correct.
1515
15162011-11-12 Martin Rudalics <rudalics@gmx.at>
1517
1518 * window.h (window): Remove splits slot.
1519 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1520 (Fdelete_other_windows_internal, make_parent_window)
1521 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1522 (Fset_window_configuration, save_window_save): Don't deal with
1523 split status of windows.
1524 (saved_window): Remove splits slot.
1525 (Vwindow_splits): Rewrite doc-string.
1526
15272011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1528
1529 * xfns.c (unwind_create_frame):
1530 * nsfns.m (unwind_create_frame):
1531 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1532 Vframe_list (Bug#9999).
1533
15342011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1537
15382011-11-11 Kenichi Handa <handa@m17n.org>
1539
1540 * callproc.c (Fcall_process): Set the member dst_multibyte of
1541 process_coding.
1542
15432011-11-11 Johan Bockgård <bojohan@gnu.org>
1544
1545 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1546 avoid a crash (bug#9496).
1547
15482011-11-09 Chong Yidong <cyd@gnu.org>
1549
1550 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1551 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1552
15532011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1556
15572011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 Avoid some portability problems by eschewing 'extern inline' functions.
1560 The trivial performance wins aren't worth the portability hassles; see
1561 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1562 et seq.
1563 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1564 (window_box_width, window_box_left, window_box_left_offset)
1565 (window_box_right, window_box_right_offset): Undo previous change,
1566 by removing the "extern"s.
1567 * intervals.c (adjust_intervals_for_insertion)
1568 (adjust_intervals_for_deletion): Undo previous change,
1569 making these static again.
1570 (offset_intervals, temp_set_point_both, temp_set_point)
1571 (copy_intervals_to_string): No longer inline.
1572 * xdisp.c (window_text_bottom_y, window_box_width)
1573 (window_box_height, window_box_left_offset)
1574 (window_box_right_offset, window_box_left, window_box_right)
1575 (window_box): No longer inline.
1576
15772011-11-08 Chong Yidong <cyd@gnu.org>
1578
1579 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1580 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1581 Signal an error if not a live window.
1582 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1583 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1584
15852011-11-07 Juanma Barranquero <lekktu@gmail.com>
1586
1587 * lisp.h (syms_of_abbrev): Remove declaration.
1588 Reported by CHENG Gao <chenggao@royau.me>.
1589
15902011-11-07 Eli Zaretskii <eliz@gnu.org>
1591
1592 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1593 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1594 of temacs in GUI mode.
1595
15962011-11-07 Martin Rudalics <rudalics@gmx.at>
1597
1598 * window.h: Declare delete_all_child_windows instead of
1599 delete_all_subwindows.
1600 * window.c (Fwindow_nest, Fset_window_nest)
1601 (Fset_window_new_total, Fset_window_new_normal)
1602 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1603 (delete_all_subwindows): Rename to delete_all_child_windows.
1604 (Fdelete_other_windows_internal, Fset_window_configuration):
1605 Call delete_all_child_windows instead of delete_all_subwindows.
1606 * frame.c (delete_frame): Call delete_all_child_windows instead
1607 of delete_all_subwindows.
1608
16092011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1610
1611 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1612 This is also needed for porting to any host where GC_MARK_STACK is
1613 not GC_MAKE_GCPROS_NOOPS.
1614 (which_symbols): Use it.
1615
16162011-11-07 Kenichi Handa <handa@m17n.org>
1617
1618 * coding.c (coding_set_destination): Check coding->src_pos only
1619 when coding->src_object is a buffer (bug#9910).
1620
1621 * process.c (send_process): Set the member src_multibyte of coding
1622 to 0 (bug#9911) when sending a unibyte text.
1623
1624 * callproc.c (Fcall_process): Set the member src_multibyte of
1625 process_coding to 0 (bug#9912).
1626
16272011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1628
1629 * xmenu.c (cleanup_widget_value_tree): New function.
1630 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1631 calling free_menubar_widget_value_tree directly (Bug#9830).
1632
16332011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1634
1635 Fix some portability problems with 'inline'.
1636 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1637 (window_box_width, window_box_left, window_box_left_offset)
1638 (window_box_right, window_box_right_offset): Declare extern.
1639 Otherwise, these inline functions do not conform to C99 and
1640 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1641 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1642 * intervals.c (adjust_intervals_for_insertion)
1643 (adjust_intervals_for_deletion): Now extern, because otherwise the
1644 extern inline functions 'offset_intervals' couldn't refer to it.
1645 (static_offset_intervals): Remove.
1646 (offset_intervals): Rewrite using the old contents of
1647 static_offset_intervals. The old version didn't conform to C99
1648 because an extern inline function contained a reference to an
1649 identifier with static linkage.
1650
16512011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1652
1653 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1654 GC.
1655
16562011-11-06 Eli Zaretskii <eliz@gnu.org>
1657
1658 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1659 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1660 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1661 return Qleft_to_right.
1662
16632011-11-06 Chong Yidong <cyd@gnu.org>
1664
1665 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1666 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1667 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1668 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1669 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1670 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1671 (Fwindow_vscroll): Doc fix.
1672 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1673 argument, since it makes no sense to pass a live window and for
1674 consistency with window-child.
1675
16762011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1677
1678 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1679 support MSVC.
1680
16812011-11-05 Jason Rumney <jasonr@gnu.org>
1682
1683 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1684 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1685 fonts (Bug#6029).
1686 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1687 bitwise arithmetic preventing use of unicode-sip and non-truetype
1688 opentype fonts.
1689
16902011-11-05 Eli Zaretskii <eliz@gnu.org>
1691
1692 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1693 "emacs"-only part.
1694
1695 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1696 initialization code to keep similarity to xfns.c after changes
1697 from 2011-11-05.
1698
16992011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1700
1701 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1702 (unwind_create_frame): New function (Bug#9943).
1703 (Fx_create_frame): Restructure code to be more similar to the one in
1704 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1705 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1706 Move terminal->reference_count++ just before making the frame official
1707 (Bug#9943).
1708
1709 * nsterm.m (x_free_frame_resources): New function.
1710 (x_destroy_window): Move code to x_free_frame_resources.
1711
1712 * xfns.c (unwind_create_frame): Fix comment.
1713 (Fx_create_frame, x_create_tip_frame):
1714 Move terminal->reference_count++ just before making the frame
1715 official. Move initialization of image_cache_refcount and
1716 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1717
17182011-11-05 Eli Zaretskii <eliz@gnu.org>
1719
1720 Support MSVC build with newer versions of Visual Studio.
1721 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1722 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1723 nt/gmake.defs.
1724
1725 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1726 which are not supported by MSVC.
1727 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1728 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1729 bitfields.
1730 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1731 types in bitfields.
1732 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1733
1734 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1735
17362011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1737
1738 Support MSVC build with newer versions of Visual Studio.
1739 * w32.c: Don't include w32api.h for MSVC.
1740 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1741
1742 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1743 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1744 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1745 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1746 e_* cousins.
1747 (alloca) [_MSC_VER]: Define to _alloca.
1748
1749 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1750
1751 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1752
17532011-11-04 Eli Zaretskii <eliz@gnu.org>
1754
1755 * xdisp.c (note_mouse_highlight): If either of
1756 previous/next-single-property-change returns nil, treat that as
1757 the beginning or the end of the buffer. (Bug#9955)
1758
17592011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1760
1761 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1762 label is not null (Bug#9951).
1763 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1764 may be NULL.
1765
17662011-11-04 Eli Zaretskii <eliz@gnu.org>
1767
1768 * window.c (Fwindow_body_size): Mention in the doc string that the
1769 return value is in frame's canonical units. (Bug#9949)
1770
17712011-11-03 Eli Zaretskii <eliz@gnu.org>
1772
1773 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1774
1775 * w32fns.c (unwind_create_frame): If needed, free the glyph
1776 matrices of the partially constructed frame. (Bug#9943)
1777 * xfns.c (unwind_create_frame): Likewise.
1778
17792011-11-01 Eli Zaretskii <eliz@gnu.org>
1780
1781 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1782 Don't stop backward scan on the continuation glyph, even though
1783 its CHARPOS is positive.
1784 (mouse_face_from_buffer_pos, note_mouse_highlight):
1785 Rename cover_string to disp_string.
1786
17872011-11-01 Martin Rudalics <rudalics@gmx.at>
1788
1789 * window.c (temp_output_buffer_show): Don't use
1790 Vtemp_buffer_show_specifiers.
1791 (Vtemp_buffer_show_specifiers): Remove unused variable.
1792
17932011-10-30 Eli Zaretskii <eliz@gnu.org>
1794
1795 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1796 past the beginning of the current glyph matrix.
1797
17982011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1799
1800 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1801 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1802 HAVE_GTK3 (Bug#9869).
1803
1804 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1805 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1806
1807 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1808
1809 * xterm.c: Declare x_handle_net_wm_state to return int.
1810 (handle_one_xevent): Check if we are iconified but don't have
1811 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1812 (get_current_wm_state): Return non-zero if not hidden,
1813 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1814 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1815 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1816 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1817
18182011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1819
1820 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1821 so that this new function doesn't get optimized away by a
1822 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1823
18242011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1825
1826 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1827
18282011-10-29 Eli Zaretskii <eliz@gnu.org>
1829
1830 Fix the `xbytecode' command.
1831 * .gdbinit (xprintbytestr): New command.
1832 (xwhichsymbols): Rename from `which'; all callers changed.
1833 (xbytecode): Print the byte-code string as well.
1834
18352011-10-29 Kim Storm <storm@cua.dk>
1836
1837 * alloc.c (which_symbols): New function.
1838
18392011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1840
1841 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1842 line. (Bug#9903)
1843
18442011-10-29 Glenn Morris <rgm@gnu.org>
1845
1846 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1847 Not clear what it was for, and it causes various bugs. (Bug#9839)
1848
18492011-10-28 Eli Zaretskii <eliz@gnu.org>
1850
1851 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1852 possible random value that matches one of those tested as
1853 condition to clear the mouse face.
1854
18552011-10-28 Chong Yidong <cyd@gnu.org>
1856
1857 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1858
18592011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1860
1861 * window.c (make_window): Initialize phys_cursor_on_p.
1862
18632011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1864
1865 * lisp.h (struct Lisp_Symbol): Update comments.
1866
18672011-10-28 Juanma Barranquero <lekktu@gmail.com>
1868
1869 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1870
18712011-10-28 Eli Zaretskii <eliz@gnu.org>
1872
1873 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1874 <oslsachem@gmail.com> for helping to debug this.
1875
1876 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1877 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1878 (g_b_init_get_glyph_outline_w): New static variables.
1879 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1880 (GetGlyphOutlineW_Proc): New typedefs.
1881 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1882 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1883 New functions.
1884 (w32font_open_internal, compute_metrics):
1885 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1886 instead of calling the "wide" APIs directly.
1887
1888 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1889
1890 * w32.h (syms_of_w32font): Add prototype.
1891
18922011-10-27 Juanma Barranquero <lekktu@gmail.com>
1893
1894 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1895 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1896 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1897 (Fmove_to_window_line): Doc fix.
1898
18992011-10-27 Chong Yidong <cyd@gnu.org>
1900
1901 * process.c (make_process): Set gnutls_state to NULL.
1902
1903 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1904 non-NULL, regardless of GNUTLS_INITSTAGE.
1905 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1906 an error. Set process slots as soon as we allocate them.
1907
1908 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1909
19102011-10-27 Chong Yidong <cyd@gnu.org>
1911
1912 * gnutls.c (emacs_gnutls_deinit): New function.
1913 Deallocate credentials structures as well as calling gnutls_deinit.
1914 (Fgnutls_deinit, Fgnutls_boot): Use it.
1915
1916 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1917 (deactivate_process): Call emacs_gnutls_deinit.
1918
19192011-10-27 Juanma Barranquero <lekktu@gmail.com>
1920
1921 * image.c (x_create_x_image_and_pixmap):
1922 * w32.c (sys_rename, w32_delayed_load):
1923 * w32font.c (fill_in_logfont):
1924 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1925
19262011-10-26 Juanma Barranquero <lekktu@gmail.com>
1927
1928 * w32fns.c (w32_default_color_map): New function,
1929 extracted from Fw32_default_color_map.
1930 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1931
19322011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1933
1934 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1935
19362011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1937
1938 * keyboard.c (test_undefined): New function (bug#9751).
1939 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1940
19412011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1942
1943 * sysdep.c (init_sys_modes): Fix the check for the controlling
1944 terminal (Bug#6649).
1945
19462011-10-20 Eli Zaretskii <eliz@gnu.org>
1947
1948 * dispextern.h (struct bidi_it): New member next_en_type.
1949
1950 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1951 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1952 current character, check also for next_en_type being WEAK_EN.
1953 (bidi_resolve_weak): Don't enter the expensive loop if the current
1954 position is before next_en_pos. Record the bidi type of the first
1955 non-ET, non-BN character we find, in addition to its position.
1956 (bidi_level_of_next_char): Invalidate next_en_type when
1957 next_en_pos is over-stepped.
1958
19592011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1960
1961 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1962 * editfns.c: Rewrite current-time-zone so that it invokes
1963 the equivalent of (format-time-string "%Z") to get the time zone name.
1964 This fixes a bug when the time zone name contains characters that
1965 need converting from the system time locale to Emacs internal format.
1966 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1967 that patch fixed format-time-string to do the conversion, but
1968 I forgot to fix current-time-zone.
1969 (format_time_string): New function, containing most of
1970 what Fformat_time_string used to contain.
1971 (Fformat_time_string): Rewrite in terms of format_time_string.
1972 This doesn't change this function's behavior.
1973 (current-time-zone): Rewrite to use format_time_string.
1974 This fixes the bug reported by Michael Schierl in
1975 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1976 Jason Rumney's 2007-06-07 change worked around this bug, but
1977 didn't fix it.
1978 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1979
19802011-10-19 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (start_display): If the character at POS is displayed
1983 via a display vector, reset IT->current.dpvec_index to zero.
1984 (try_window_reusing_current_matrix): If a line ends in a display
1985 vector or the next line starts in a display vector, continue
1986 redrawing the window even though the character position of
1987 start_row was reached.
1988 (Bug#9771, part 2)
1989
19902011-10-18 Chong Yidong <cyd@gnu.org>
1991
1992 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1993 with nobreak-char-display too.
1994
19952011-10-18 Eli Zaretskii <eliz@gnu.org>
1996
1997 Fix part 3 of bug#9771.
1998 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1999 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2000 non-neutral characters if the current character is a paragraph
2001 separator (a.k.a. Newline). This avoids running the same
2002 expensive loop twice, once when we consume the preceding newline
2003 and the other time when the line actually needs to be displayed.
2004 Avoid the loop when we see neutrals on the base embedding level
2005 following a character whose directionality is the same as the
2006 paragraph's. This avoids running the expensive loop when a line
2007 ends in a long sequence of neutrals, like control characters.
2008 Add assertion against STRONG_AL type. Slightly rearrange code
2009 that determines the type of a neutral given the first non-neutral
2010 that follows it.
2011 (bidi_level_of_next_char): Set next_en_pos to zero when
2012 invalidating its info.
2013
20142011-10-17 Eli Zaretskii <eliz@gnu.org>
2015
2016 * xdisp.c (push_display_prop): Determine whether to record string
2017 or buffer position by IT->string, not by IT->method. Allow
2018 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2019 (move_it_vertically_backward): Don't look for character position
2020 immediately after the newline when in a continuation line.
2021 (Bug#9771, part 1)
2022
20232011-10-15 Martin Rudalics <rudalics@gmx.at>
2024
2025 * window.c (coordinates_in_window): Rewrite and delabelize
2026 vertical border check. (Bug#5357) (Bug#9618)
2027
20282011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2029
2030 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2031 errors in XSetWindowBorder (bug#9310).
2032
20332011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2034
2035 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2036 avoid crash when xmalloc overrun checking is enabled.
2037
20382011-10-13 Eli Zaretskii <eliz@gnu.org>
2039
2040 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2041 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2042 cursor motion with <left> and <right> arrow keys.
2043
2044 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2045 some callers set that themselves.
2046
20472011-10-12 Eli Zaretskii <eliz@gnu.org>
2048
2049 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2050 display string and the previous row comes from the same string and
2051 is empty. (Bug#9739) (Bug#9738)
2052
20532011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2054
2055 * doc.c (get_doc_string): Encode file name (bug#9735).
2056
20572011-10-12 Eli Zaretskii <eliz@gnu.org>
2058
2059 * bidi.c (bidi_level_of_next_char):
2060 * xdisp.c (get_visually_first_element): Remove old incorrect
2061 comments regarding the Unicode Line Separator character.
2062
2063 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2064
20652011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2066
2067 * alloc.c (Fgc_status): Do not access beyond zombies array
2068 boundary if nzombies > MAX_ZOMBIES.
2069 * alloc.c (dump_zombies): Add missing format specifier.
2070
20712011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2074 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2075
2076 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2077 Some packages use them to denote characters with modifiers.
2078
20792011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2080
2081 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2082 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2083 matching a pp-number. Rename parameter var to var1.
2084
20852011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2086
2087 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2088
20892011-10-08 Glenn Morris <rgm@gnu.org>
2090
2091 * callint.c (Fcall_interactively): Give a more explicit error for the
2092 'c' case with a non-character input. (Bug#8479)
2093
20942011-10-08 Eli Zaretskii <eliz@gnu.org>
2095
2096 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2097 lines.
2098 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2099 lines that are hscrolled on the left.
2100
2101 * dispnew.c (buffer_posn_from_coords): Account for a possible
2102 presence of header-line. (Bug#4426)
2103
21042011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2105
2106 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2107 Don't advertise functionality which we discourage or doesn't work.
2108
21092011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2112 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2113 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2114 this makes Emacs dump core during garbage collection on rare
2115 occasions. sizeof is obviously inferior to offsetof here, so
2116 stick with offsetof.
2117 (GC_POINTER_ALIGNMENT): New macro.
2118 (mark_memory): Omit 3rd (offset) arg; caller changed.
2119 Don't assume EMACS_INT alignment is the same as pointer alignment.
2120
21212011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2122
2123 * keyboard.c (read_key_sequence_remapped): New var.
2124 (read_key_sequence): Compute remapping in the right buffer.
2125 (command_loop_1): Use read_key_sequence's remapping directly.
2126
21272011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2128
2129 * dired.c (file_name_completion): Don't expand file name.
2130 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2131 before checking file name handler.
2132
2133 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2134 they've been requested explicitly (bug#9591).
2135
21362011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2137
2138 * keymap.c (Fsingle_key_description): Use make_specified_string
2139 instead of build_string to build string from push_key_description.
2140 (Bug#5193)
2141
21422011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2143
2144 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2145 This fixes a Y2038 bug on 64-bit hosts.
2146 * buffer.c (reset_buffer):
2147 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2148 (Fclear_buffer_auto_save_failure):
2149 Use 0, not -1, to represent an unset failure time, since time_t
2150 might not be signed.
2151
2152 Remove dependency on glibc malloc internals.
2153 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2154 Move back here from lisp.h, but with their new implementations.
2155 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2156 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2157 * charset.c (charset_table_init): New static var.
2158 (syms_of_charset): Use it instead of xmalloc. This removes a
2159 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2160 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2161 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2162 Move back to alloc.c.
2163 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2164 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2165
21662011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2167
2168 * nsterm.m (windowDidResize): Call x_set_window_size only when
2169 ns_in_resize is true. Otherwise set pixelwidth/height and
2170 call change_frame_size (Bug#9628).
2171
21722011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2173
2174 Port --enable-checking=all to Fedora 14 x86-64.
2175 * charset.c (syms_of_charset): Also account for glibc malloc's
2176 internal overhead when calculating the initial malloc maximum.
2177
2178 Port --enable-checking=all to Fedora 14 x86.
2179 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2180 Move to lisp.h.
2181 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2182 (overrun_check_realloc, overrun_check_free):
2183 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2184 That way, xmalloc returns a properly-aligned pointer even if
2185 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2186 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2187 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2188 into account when calculating the initial malloc maximum.
2189 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2190 Move here from alloc.c, so that charset.c can use it too.
2191 Properly align; the old code wasn't right for common 32-bit hosts
2192 when configured with --enable-checking=all.
2193 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2194 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2195
21962011-09-29 Eli Zaretskii <eliz@gnu.org>
2197
2198 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2199 use EDOM.
2200
22012011-09-28 Eli Zaretskii <eliz@gnu.org>
2202
2203 * xdisp.c (compute_display_string_end): If there's no display
2204 string at CHARPOS, return -1.
2205
2206 * bidi.c (bidi_fetch_char): When compute_display_string_end
2207 returns a negative value, treat the character as a normal
2208 character not covered by a display string. (Bug#9624)
2209
22102011-09-28 Juanma Barranquero <lekktu@gmail.com>
2211
2212 * lread.c (Fread_from_string): Fix typo in docstring.
2213
22142011-09-27 Eli Zaretskii <eliz@gnu.org>
2215
2216 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2217 newline, reseat the iterator instead of bidi-iterating there one
2218 character at a time. (Bug#9610)
2219 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2220 TO_CHARPOS if the bidi iterator is at base embedding level.
2221
22222011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2223
2224 * lread.c (readevalloop): Use correct code for NBSP.
2225 (read1): Likewise. (Bug#9608)
2226
22272011-09-25 Michael Albinus <michael.albinus@gmx.de>
2228
2229 * dbusbind.c (Fdbus_register_signal): When service is not
2230 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2231
22322011-09-25 Glenn Morris <rgm@gnu.org>
2233
2234 * buffer.c (truncate-lines): Doc fix.
2235
22362011-09-24 Chong Yidong <cyd@stupidchicken.com>
2237
2238 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2239 (Fset_window_next_buffers): Doc fix.
2240
22412011-09-24 Glenn Morris <rgm@gnu.org>
2242
2243 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2244
22452011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2246
2247 Fix minor problems found by static checking.
2248 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2249 * indent.c (Fvertical_motion): Fix == vs = typo.
2250
22512011-09-24 Eli Zaretskii <eliz@gnu.org>
2252
2253 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2254 Default value is now t. Doc fix.
2255
2256 * indent.c (Fvertical_motion): Compute and apply the overshoot
2257 logic when moving up, not only when moving down. Fix the
2258 confusing name and values of the it_overshoot_expected variable;
2259 logic changes accordingly. (Bug#9254) (Bug#9549)
2260
2261 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2262 CHARPOS is covered by a display string which includes newlines.
2263 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2264 is covered by a display string with embedded newlines.
2265
22662011-09-24 Michael Albinus <michael.albinus@gmx.de>
2267
2268 * dbusbind.c (Fdbus_register_signal): Add match rule to
2269 Vdbus_registered_objects_table. (Bug#9581)
2270 (Fdbus_register_method, Vdbus_registered_objects_table):
2271 Fix docstring.
2272
22732011-09-24 Jim Meyering <meyering@redhat.com>
2274
2275 do not ignore write error for any output size
2276 The previous change was incomplete.
2277 While it makes emacs --batch detect the vast majority of stdout
2278 write failures, errors were still ignored whenever the output size is
2279 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2280 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2281 && echo FAIL: ignored write error
2282 FAIL: ignored write error
2283 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2284 && echo FAIL: ignored write error
2285 FAIL: ignored write error
2286 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2287
22882011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2289
2290 * emacs.c (Fkill_emacs): In noninteractive mode exit
2291 non-successfully if a write error occurred on stdout. (Bug#9574)
2292
22932011-09-21 Eli Zaretskii <eliz@gnu.org>
2294
2295 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2296 the xassert test.
2297
2298 * dispextern.h (struct it): Update the comment documenting what
2299 can it->OBJECT be.
2300
23012011-09-20 Eli Zaretskii <eliz@gnu.org>
2302
2303 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2304 a display string, extend search for cursor position to end of row.
2305 (find_row_edges): If the row ends in a newline from a display
2306 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2307 Handle the case of a display string with multiple newlines.
2308 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2309 non-empty line. Fixes confusing cursor motion with arrow keys at
2310 the beginning of a line that starts with whitespace.
2311
23122011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2313
2314 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2315 (bug#9493).
2316
23172011-09-18 Chong Yidong <cyd@stupidchicken.com>
2318
2319 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2320 boolean (Bug#9154).
2321
23222011-09-18 Eli Zaretskii <eliz@gnu.org>
2323
2324 * xdisp.c (display_line): Record maximum and minimum buffer
2325 positions even if no glyphs were produced (e.g., by a zero-width
2326 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2327 buffer positions that will be removed from the glyph row because
2328 they don't fit.
2329 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2330 column is beyond frame width: don't subtract 1 "pixel" when
2331 computing width of the stretch.
2332 (reseat_at_next_visible_line_start): Undo the change made on
2333 2011-09-17 that saved paragraph information and restored it after
2334 the call to `reseat'. (Bug#9545)
2335
23362011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2337
2338 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2339 and turn window cursor on if cleared (Bug#9415).
2340
23412011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2342
2343 * search.c (boyer_moore): Take unibyte characters from pattern
2344 literally. (Bug#9458)
2345
23462011-09-18 Eli Zaretskii <eliz@gnu.org>
2347
2348 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2349
23502011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2351
2352 Fix minor problem found by static checking.
2353 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2354 initialized, to pacify gcc -Wuninitialized.
2355
2356 * fileio.c: Report proper errno when syscall falls.
2357 (Finsert_file_contents): Save and restore errno,
2358 so that report_file_error outputs the correct diagnostic.
2359 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2360
23612011-09-18 Eli Zaretskii <eliz@gnu.org>
2362
2363 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2364
23652011-09-17 Eli Zaretskii <eliz@gnu.org>
2366
2367 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2368 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2369
23702011-09-17 Eli Zaretskii <eliz@gnu.org>
2371
2372 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2373 about the current paragraph and restore it after the call to reseat.
2374
2375 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2376 (bidi_find_paragraph_start): Search back for paragraph beginning
2377 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2378 (bidi_move_to_visually_next): Only trigger paragraph-related
2379 computations when the last character is a newline or at EOB, not
2380 just any NEUTRAL_B. (Bug#9470)
2381
2382 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2383 truncated lines if point is covered by a display string. (Bug#9524)
2384
23852011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2386
2387 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2388 (cons_to_x_long): New function.
2389 (lisp_data_to_selection_data): Use it. Correct the test for
2390 short-versus-long data; it was negated. Break out of vector
2391 loop, for efficiency, when a long datum is discovered.
2392
23932011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2394
2395 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2396
23972011-09-16 Eli Zaretskii <eliz@gnu.org>
2398
2399 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2400 GCC PR/17406) by declaring this function with external scope.
2401
24022011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2405 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2406
24072011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2408
2409 * editfns.c (Fformat): Correctly handle text properties on "%%".
2410
24112011-09-15 Eli Zaretskii <eliz@gnu.org>
2412
2413 * xterm.c (x_draw_composite_glyph_string_foreground):
2414 * w32term.c (x_draw_composite_glyph_string_foreground):
2415 * term.c (encode_terminal_code):
2416 * composite.c (composition_update_it, get_composition_id):
2417 * xdisp.c (get_next_display_element)
2418 (fill_composite_glyph_string): Add comments about special meaning
2419 of TAB characters in a composition.
2420
24212011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2424 This occurs when processing a multibyte format.
2425 Problem reported by Wolfgang Jenker.
2426
24272011-09-15 Johan Bockgård <bojohan@gnu.org>
2428
2429 * xdisp.c (try_cursor_movement): Only check for exact match if
2430 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2431
24322011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2433
2434 Remove unused external symbols.
2435 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2436 * xdisp.c (calc_pixel_width_or_height): Now static.
2437 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2438 * indent.c (check_display_width):
2439 * w32term.c: Fix comment to match code.
2440 * xterm.c, xterm.h (x_catching_errors): Remove.
2441
24422011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2443
2444 * xselect.c: Use signed conversions more consistently (Bug#9498).
2445 (selection_data_to_lisp_data): Assume incoming selection data are
2446 signed integers, not unsigned. This is to be consistent with
2447 outgoing selection data, which was modified to use signed integers
2448 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2449 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2450 expects long, not unsigned long.
2451
24522011-09-14 Eli Zaretskii <eliz@gnu.org>
2453
2454 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2455 computation of loop end. Reported by Johan Bockgård
2456 <bojohan@gnu.org>.
2457
24582011-09-13 Chong Yidong <cyd@stupidchicken.com>
2459
2460 * frame.c (Fother_visible_frames_p): Function deleted.
2461
24622011-09-12 Eli Zaretskii <eliz@gnu.org>
2463
2464 * indent.c (compute_motion): Process display vector front to back
2465 rather than the other way around. (Bug#2496)
2466
24672011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2468
2469 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2470
24712011-09-11 Chong Yidong <cyd@stupidchicken.com>
2472
2473 * minibuf.c (Fread_from_minibuffer): Doc fix.
2474
24752011-09-11 Eli Zaretskii <eliz@gnu.org>
2476
2477 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2478 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2479
24802011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2481
2482 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2483 value for non-existent files.
2484
24852011-09-11 Eli Zaretskii <eliz@gnu.org>
2486
2487 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2488 set its "size" to -1. This will set the modtime_size field of
2489 the corresponding buffer to -1, which is what
2490 verify-visited-file-modtime expects for files that do not exist.
2491 (Bug#9139)
2492
24932011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2494
2495 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2496 here ...
2497 * lisp.h: ... from here. push_key_description is no longer
2498 defined in keyboard.c, so its declaration should not be in
2499 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2500 logically belongs with push_key_description.
2501
25022011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2503
2504 * buffer.h: Include <sys/types.h> instead of <time.h>.
2505 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2506 Problem reported by Herbert J. Skuhra.
2507
25082011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2509
2510 * xml.c (parse_region): Make the parsing work for
2511 non-comment-starting XML files again (bug#9144).
2512
25132011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2514
2515 * image.c (gif_load): Fix calculation of bottom and right corner.
2516 (Bug#9468)
2517
25182011-09-10 Eli Zaretskii <eliz@gnu.org>
2519
2520 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2521 redisplay in small windows.
2522
25232011-09-09 Eli Zaretskii <eliz@gnu.org>
2524
2525 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2526
25272011-09-08 Martin Rudalics <rudalics@gmx.at>
2528
2529 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2530 Operate on live windows only.
2531
25322011-09-08 Juanma Barranquero <lekktu@gmail.com>
2533
2534 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2535
25362011-09-07 Eli Zaretskii <eliz@gnu.org>
2537
2538 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2539 only under bidi iteration.
2540
25412011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2542
2543 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2544
25452011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2546
2547 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2548 Without this fix, the command to link temacs failed due to an
2549 undefined symbol __builtin_isnan. This is because
2550 /usr/include/iso/math_c99.h #defines isnan(x) to
2551 __builtin_isnan(x), but the bundled gcc, which identifies itself
2552 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2553 a __builtin_isnan.
2554 * floatfns.c (isnan): #undef, and then #define to a clone of
2555 what's in data.c.
2556 (Fisnan): Always define, since it's always available now.
2557 (syms_of_floatfns): Always define isnan at the Lisp level.
2558
25592011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2560
2561 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2562
25632011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2564
2565 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2566 The previous code assumed that file offsets (off_t values) fit in
2567 EMACS_INT variables, which is not true on typical 32-bit hosts.
2568 The code messed up by falsely reporting buffer overflow in cases
2569 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2570 when "big" contains more than 2**29 bytes, even though this
2571 inserts just one byte and does not overflow the buffer.
2572 (Finsert_file_contents): Store file offsets as off_t
2573 values, not as EMACS_INT values. Check for overflow when
2574 converting between EMACS_INT and off_t. When checking for
2575 buffer overflow or for overlap, take the offsets into account.
2576 Don't use EMACS_INT for small values where int suffices.
2577 When checking for overlap, fix a typo: ZV was used where
2578 ZV_BYTE was intended.
2579 (Fwrite_region): Don't assume off_t fits into 'long'.
2580 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2581
25822011-09-05 Michael Albinus <michael.albinus@gmx.de>
2583
2584 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2585
25862011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2587
2588 sprintf-related integer and memory overflow issues (Bug#9412).
2589
2590 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2591 (esprintf, exprintf, evxprintf): New functions.
2592 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2593 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2594 (modify_event_symbol): Do not assume that the length of
2595 name_alist_or_stem is safe to alloca and fits in int.
2596 (Fexecute_extended_command): Likewise for function name and binding.
2597 (Frecursion_depth): Wrap around reliably on integer overflow.
2598 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2599 since some callers pass EMACS_INT values.
2600 (Fsingle_key_description): Don't crash if symbol name contains more
2601 than MAX_ALLOCA bytes.
2602 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2603 (get_minibuffer): Arg is now EMACS_INT, not int.
2604 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2605 (esprintf, exprintf, evxprintf): New decls.
2606 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2607
2608 * dbusbind.c (signature_cat): New function.
2609 (xd_signature, Fdbus_register_signal):
2610 Do not overrun buffer; instead, report string overflow.
2611
2612 * dispnew.c (add_window_display_history): Don't overrun buffer.
2613 Truncate instead; this is OK since it's just a log.
2614
2615 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2616 even if the time zone offset is outlandishly large.
2617 Don't mishandle offset == INT_MIN.
2618
2619 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2620 when creating daemon; the previous buffer-overflow check was incorrect.
2621
2622 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2623 which has the guts of the old verror function.
2624
2625 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2626 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2627
2628 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2629 (font_unparse_xlfd): Don't blindly alloca long strings.
2630 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2631 fits in int, when using sprintf. Use single snprintf to count
2632 length of string rather than counting it via multiple sprintfs;
2633 that's simpler and more reliable.
2634 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2635 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2636 sprintf, in case result does not fit in int.
2637
2638 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2639 (fontset_from_font): Print it.
2640
2641 * frame.c (tty_frame_count): Now printmax_t, not int.
2642 (make_terminal_frame, set_term_frame_name): Print it.
2643 (x_report_frame_params): In X, window IDs are unsigned long,
2644 not signed long, so print them as unsigned.
2645 (validate_x_resource_name): Check for implausibly long names,
2646 and don't assume name length fits in 'int'.
2647 (x_get_resource_string): Don't blindly alloca invocation name;
2648 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2649 not fit in int.
2650
2651 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2652 (xg_check_special_colors, xg_set_geometry):
2653 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2654
2655 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2656 Use esprintf, not sprintf, in case result does not fit in int.
2657
2658 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2659 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2660 it as a large positive number.
2661 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2662 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2663
2664 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2665 in case result does not fit in int.
2666
2667 * print.c (float_to_string): Detect width overflow more reliably.
2668 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2669 buffer overrun. Don't assume list length fits in 'int'. Treat
2670 print length of 0 as 0, not as infinity; to be consistent with other
2671 uses of print length in this function. Don't overflow print length
2672 index. Don't assume hash table size fits in 'long', or that
2673 vectorlike size fits in 'unsigned long'.
2674
2675 * process.c (make_process): Use printmax_t, not int, to format
2676 process-name gensyms.
2677
2678 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2679
2680 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2681 to avoid potential buffer overrun.
2682
2683 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2684 if X resource line is longer than 512 bytes.
2685
2686 * xfns.c (x_window): Make sprintf buffer a bit bigger
2687 to avoid potential buffer overrun.
2688
2689 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2690
2691 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2692
26932011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2694
2695 Integer overflow fixes for scrolling, etc.
2696 Without these, Emacs silently mishandles large integers sometimes.
2697 For example, "C-u 4294967297 M-x recenter" was treated as if
2698 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2699
2700 * xdisp.c (try_window_id): Check Emacs fixnum range before
2701 converting to 'int'.
2702
2703 * window.c (window_scroll_line_based, Frecenter):
2704 Check that an Emacs fixnum is in range before assigning it to 'int'.
2705 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2706 values converted from Emacs fixnums.
2707 (Frecenter): Don't wrap around a line count if it is out of 'int'
2708 range; instead, treat it as an extreme value.
2709 (Fset_window_configuration, compare_window_configurations):
2710 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2711
2712 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2713 that can exceed INT_MAX. Check that EMACS_INT value is in range
2714 before assigning it to the (possibly-narrower) index.
2715 (match_limit): Don't assume that a fixnum can fit in 'int'.
2716
2717 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2718 exceed INT_MAX.
2719
2720 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2721 (Fvertical_motion): Don't wrap around LINES values that don't fit
2722 in 'int'. Instead, treat them as extreme values. This is good
2723 enough for windows, which can't have more than INT_MAX lines anyway.
2724
27252011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2726
2727 * Require libxml/parser.h to avoid compilation warning.
2728
2729 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2730
2731 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2732 since this reportedly can destroy thread storage.
2733
27342011-08-30 Chong Yidong <cyd@stupidchicken.com>
2735
2736 * syntax.c (find_defun_start): Update all cache variables if
2737 exiting early (Bug#9401).
2738
27392011-08-30 Eli Zaretskii <eliz@gnu.org>
2740
2741 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2742
2743 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2744 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2745 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2746
2747 * term.c (tty_append_glyph): New function.
2748 (produce_stretch_glyph): Static function and its prototype deleted.
2749
2750 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2751 Add prototypes.
2752
27532011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2754
2755 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2756 when checking :margin (Bug#9390).
2757 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2758 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2759 so that the name doesn't mislead. All uses changed.
2760
27612011-08-28 Johan Bockgård <bojohan@gnu.org>
2762
2763 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2764 set_tty_hooks.
2765
27662011-08-27 Eli Zaretskii <eliz@gnu.org>
2767
2768 * xdisp.c (move_it_to): Don't bail out early when reaching
2769 position beyond to_charpos, if we are scanning backwards.
2770 (move_it_vertically_backward): When DY == 0, make sure we get to
2771 the first character in the line after the newline.
2772
27732011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2774
2775 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2776 (ccl_driver): Do not generate an out-of-range pointer.
2777 (Fccl_execute_on_string): Remove unnecessary check for
2778 integer overflow, noted by Stefan Monnier in
2779 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2780 Remove a FIXME that didn't need fixing.
2781 Simplify the newly-introduced buffer reallocation code.
2782
27832011-08-27 Juanma Barranquero <lekktu@gmail.com>
2784
2785 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2786
27872011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2788
2789 Integer and memory overflow issues (Bug#9196).
2790
2791 * doc.c (get_doc_string): Rework so that
2792 get_doc_string_buffer_size is the actual buffer size, rather than
2793 being 1 less than the actual buffer size; this makes xpalloc more
2794 convenient.
2795
2796 * image.c (x_allocate_bitmap_record, cache_image):
2797 * xselect.c (Fx_register_dnd_atom):
2798 Simplify previous changes by using xpalloc.
2799
2800 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2801 since either will do and ptrdiff_t is convenient with xpalloc.
2802
2803 * charset.c (charset_table_size)
2804 (struct charset_sort_data.priority): Now ptrdiff_t.
2805 (charset_compare): Don't overflow if priorities differ greatly.
2806 (Fsort_charsets): Don't assume list length fits in int.
2807 Check for size-calculation overflow when allocating sort data.
2808 (syms_of_charset): Allocate an initial charset table that is
2809 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2810
2811 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2812
2813 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2814 The actual value is always <= INT_MAX, and leaving it unsigned made
2815 overflow checking harder.
2816
2817 * dispextern.h (struct glyph_matrix.rows_allocated)
2818 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2819 with xpalloc. The values are still always <= INT_MAX.
2820
2821 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2822
2823 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2824 (SAFE_NALLOCA): New macro.
2825
2826 * region-cache.c (struct boundary.pos, find_cache_boundary)
2827 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2828 (set_cache_region, invalidate_region_cache)
2829 (revalidate_region_cache, know_region_cache, region_cache_forward)
2830 (region_cache_backward, pp_cache):
2831 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2832 so that ptrdiff_t * can be passed to xpalloc.
2833 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2834 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2835 (pp_cache): Don't assume cache_len fits in int.
2836 * region-cache.h: Adjust extern decls to match.
2837
2838 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2839 EMACS_INT, since either will do, for xpalloc.
2840
2841 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2842 (xnmalloc, xnrealloc, xpalloc): New functions.
2843
2844 * bidi.c (bidi_shelve_header_size): New constant.
2845 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2846 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2847
2848 * bidi.c (bidi_cache_shrink):
2849 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2850 (overlay_strings):
2851 Don't update size of array until after memory allocation succeeds,
2852 because xmalloc/xrealloc may not return.
2853 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2854 now that we have proper integer overflow checking.
2855 (record_overlay_string, overlay_strings): Catch overflows when
2856 calculating size of overlay_str_buf.
2857
2858 * callproc.c (Fcall_process): Check for size overflow when
2859 calculating size of args2.
2860 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2861 Normally we prefer signed values, but sticking with ptrdiff_t would
2862 require adding more-complicated checks.
2863
2864 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2865 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2866 Redo buffer-overflow calculations to avoid integer overflow.
2867 Add a FIXME comment where memory seems to be over-allocated.
2868
2869 * character.c (Fstring): Check for size-calculation overflow.
2870
2871 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2872 unnecessary integer overflow. Check for size overflow.
2873 (encode_coding_object): Don't update size until xmalloc succeeds.
2874
2875 * composite.c (get_composition_id): Check for overflow in glyph
2876 length calculations.
2877
2878 Integer and memory overflow fixes for display code.
2879 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2880 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2881 (scrolling_window): Check for overflow in size calculations.
2882 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2883 Don't assume glyph table len fits in int.
2884 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2885 (row_table_size): Now ptrdiff_t, not int.
2886 (scrolling_window): Avoid overflow in size calculations.
2887 Don't update size until allocation succeeds.
2888 * fns.c (concat): Check for overflow in size calculations.
2889 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2890 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2891 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2892
2893 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2894 (get_doc_string): Check for size calculation overflow.
2895 Don't update size until allocation succeeds.
2896 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2897 EMACS_INT, where ptrdiff_t will do.
2898 (Fsubstitute_command_keys): Check for string overflow.
2899
2900 * editfns.c (set_time_zone_rule): Don't assume environment length
2901 fits in int.
2902 (message_length): Now ptrdiff_t, not int.
2903 (Fmessage_box): Don't update size until allocation succeeds.
2904 Don't assume message length fits in int.
2905 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2906
2907 * emacs.c (main): Do not reallocate argv, since there is a null at
2908 the end that can be overwritten, and this way there's no need to
2909 worry about size-calculation overflow.
2910 (sort_args): Check for size-calculation overflow.
2911
2912 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2913 alloc succeeds.
2914 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2915
2916 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2917 (x_set_scroll_bar_width, x_figure_window_size):
2918 Check for integer overflow.
2919 (x_set_alpha): Do not assume XINT fits in int.
2920
2921 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2922 This is for the members text_lines, text_cols, total_lines, total_cols,
2923 where the system imposes an 'int' limit.
2924
2925 * fringe.c (Fdefine_fringe_bitmap):
2926 Don't update size until alloc works.
2927
2928 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2929 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2930
2931 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2932 Check for size-calculation overflow.
2933 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2934 do, as we prefer signed integers.
2935 (id_to_widget.max_size, id_to_widget.used)
2936 (xg_store_widget_in_map, xg_remove_widget_from_map)
2937 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2938 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2939 Use and return ptrdiff_t, not int.
2940 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2941 * gtkutil.h: Change prototypes to match the above.
2942
2943 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2944 are duplicate now that they've been promoted to lisp.h.
2945 (x_allocate_bitmap_record, x_alloc_image_color)
2946 (make_image_cache, cache_image, xpm_load):
2947 Don't update size until alloc is done.
2948 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2949 (x_detect_edges):
2950 Check for size calculation overflow.
2951 (ct_colors_allocated_max): New constant.
2952 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2953 overflow.
2954
2955 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2956 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2957 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2958 Use ptrdiff_t, not int, to count maps.
2959 (read_char_minibuf_menu_prompt): Check for overflow in size
2960 calculations. Don't update size until allocation succeeds.
2961 Redo calculations to avoid overflow.
2962 * keyboard.h: Change prototypes to match the above.
2963
2964 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2965 to count maps.
2966 (current_minor_maps): Check for size calculation overflow.
2967 * keymap.h: Change prototypes to match the above.
2968
2969 * lread.c (read1, init_obarray): Don't update size until alloc done.
2970
2971 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2972 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2973
2974 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2975 Now ptrdiff_t, not int.
2976 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2977 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2978
2979 * process.c (Fnetwork_interface_list): Check for overflow
2980 in size calculation.
2981
2982 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2983
2984 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2985 overflow. Don't bother calling xmalloc when xrealloc will do.
2986
2987 * search.c (Freplace_match): Check for size calculation overflow.
2988 (Fset_match_data): Don't assume list lengths fit in 'int'.
2989
2990 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2991 for command line length. Do not attempt to address one before the
2992 beginning of an array, as that's not portable.
2993
2994 * term.c (max_frame_lines): Remove; unused.
2995 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2996 not int.
2997 (encode_terminal_code, calculate_costs): Check for size
2998 calculation overflow.
2999 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3000 table lengths and related sizes. Don't update size until alloc
3001 done. Redo calculations to avoid overflow.
3002 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3003
3004 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3005 subtracting pointers.
3006 (gobble_line): Check for overflow more carefully. Don't update size
3007 until alloc done.
3008
3009 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3010 Don't update size until alloc done.
3011 Redo size calculations to avoid overflow.
3012 Check for size calculation overflow.
3013 (main) [DEBUG]: Fix typo in invoking tparam1.
3014
3015 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3016 Use ptrdiff_t, not int, for sizes.
3017 (store_mode_line_noprop_char): Don't update size until alloc done.
3018
3019 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3020 Use ptrdiff_t, not int, for sizes.
3021 (Finternal_make_lisp_face, cache_face):
3022 Check for size calculation overflow.
3023 (cache_face): Treat size calculation overflows as if they were
3024 memory exhaustion (the usual treatment), rather than aborting.
3025
3026 * xfns.c (x_encode_text, x_set_name_internal)
3027 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3028 sizes, since they can exceed INT_MAX in size. Check for size
3029 calculation overflow.
3030
3031 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3032 (xg_select): Check for size calculation overflow.
3033 Don't update size until alloc done.
3034
3035 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3036 as sprintf is limited to int lengths.
3037
3038 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3039 (X_LONG_MIN): New macros.
3040 Use them to make the following changes clearer.
3041 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3042 This change doesn't affect the value now, but it may help remind
3043 future maintainers not to raise the value too much later.
3044 (SELECTION_QUANTUM): Remove, replacing with ...
3045 (selection_quantum): ... new function, which avoids overflow.
3046 All uses changed.
3047 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3048 assumption that selection length fits in 'int'.
3049 (x_reply_selection_request, x_handle_selection_request)
3050 (x_get_window_property, receive_incremental_selection)
3051 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3052 (lisp_data_to_selection_data, clean_local_selection_data):
3053 Use ptrdiff_t, not int, to record length of selection.
3054 (x_reply_selection_request, x_get_window_property)
3055 (receive_incremental_selection, x_property_data_to_lisp):
3056 Redo calculations to avoid overflow.
3057 (x_reply_selection_request): When sending hint, ceiling it at
3058 X_LONG_MAX rather than relying on wraparound overflow to send
3059 something.
3060 (x_get_window_property, receive_incremental_selection)
3061 (lisp_data_to_selection_data, x_property_data_to_lisp):
3062 Check for size-calculation overflow.
3063 (x_get_window_property, receive_incremental_selection)
3064 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3065 Don't store size until memory allocation succeeds.
3066 (x_get_window_property): Plug memory leak on memory exhaustion.
3067 Don't double-block input; malloc is safe here. Don't assume 2**34
3068 - 4 fits in unsigned long. Add an xassert to check
3069 XGetWindowProperty overflow. Be more careful about overflow
3070 calculations, and distinguish size from memory overflow better.
3071 (receive_incremental_selection): When tracing, don't assume
3072 unsigned int is less than INT_MAX.
3073 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3074 harmful) conversions of unsigned short to int.
3075 (lisp_data_to_selection_data): Don't assume that integers
3076 in the range -65535 through -1 fit in an X unsigned short.
3077 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3078 result parameters unless successful. Rely on cons_to_unsigned
3079 to report problems with elements; the old code wasn't right anyway.
3080 (x_check_property_data): Check for int overflow; we cannot use
3081 a wider type due to X limits.
3082 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3083
3084 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3085
3086 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3087 (x_term_init): Check for size calculation overflow.
3088 (x_color_cells): Don't store size until memory allocation succeeds.
3089 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3090 Don't assume alloca size is less than MAX_ALLOCA.
3091 (x_term_init): Don't assume length fits in int (sprintf is limited
3092 to int size).
3093
3094 Use ptrdiff_t for composition IDs.
3095 * character.c (lisp_string_width):
3096 * composite.c (composition_table_size, n_compositions)
3097 (get_composition_id, composition_gstring_from_id):
3098 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3099 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3100 * window.c (Frecenter):
3101 Use ptrdiff_t, not int, for composition IDs.
3102 * composite.c (get_composition_id): Check for integer overflow.
3103 * composite.h: Adjust prototypes to match the above changes.
3104
3105 Use ptrdiff_t for hash table indexes.
3106 * category.c (hash_get_category_set):
3107 * ccl.c (ccl_driver):
3108 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3109 * coding.c (coding_system_charset_list, detect_coding_system):
3110 * coding.h (struct coding_system.id):
3111 * composite.c (get_composition_id, gstring_lookup_cache):
3112 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3113 * image.c (xpm_get_color_table_h):
3114 * lisp.h (hash_lookup, hash_put):
3115 * minibuf.c (Ftest_completion):
3116 Use ptrdiff_t for hash table indexes, not int (which is too
3117 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3118 32-bit --with-wide-int hosts).
3119
3120 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3121 Add a FIXME comment about memory leaks.
3122 (syms_of_charset): Don't assume xmalloc returns.
3123
3124 Don't assume that stated character widths fit in int.
3125 * character.c (Fchar_width, c_string_width, lisp_string_width):
3126 * character.h (CHAR_WIDTH):
3127 * indent.c (MULTIBYTE_BYTES_WIDTH):
3128 Use sanitize_char_width to avoid undefined and/or bad behavior
3129 with outlandish widths.
3130 * character.h (sanitize_tab_width): Rename from sanitize_width,
3131 now that we have two such functions. All uses changed.
3132 (sanitize_char_width): New inline function.
3133
3134 Don't assume that tab-width fits in int.
3135 * character.h (sanitize_width): New inline function.
3136 (SANE_TAB_WIDTH): New macro.
3137 (ASCII_CHAR_WIDTH): Use it.
3138 * indent.c (sane_tab_width): Remove. All uses replaced by
3139 SANE_TAB_WIDTH (current_buffer).
3140 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3141
3142 * fileio.c: Integer overflow issues with file modes.
3143 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3144
3145 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3146 Remove unreachable code.
3147 (read_hex, load_charset_map_from_file): Check for integer overflow.
3148
3149 * xterm.c: Don't go over XClientMessageEvent limit.
3150 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3151 (x_send_scroll_bar_event): Likewise. Check that the size does not
3152 exceed limits imposed by XClientMessageEvent, as well as the usual
3153 ptrdiff_t and size_t limits.
3154
3155 * keyboard.c: Overflow, signedness and related fixes.
3156 (make_lispy_movement): Use same integer type in forward decl
3157 that is used in the definition.
3158 (read_key_sequence, keyremap_step):
3159 Change bufsize argument back to int, undoing my 2011-03-30 change.
3160 We prefer signed types, and int is wide enough here.
3161 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3162 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3163 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3164 length, not size_t. Use ptrdiff_t for index, not int.
3165 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3166 possibility of integer overflow.
3167
3168 Overflow, signedness and related fixes for images.
3169
3170 * dispextern.h (struct it.stack[0].u.image.image_id)
3171 (struct_it.image_id, struct image.id, struct image_cache.size)
3172 (struct image_cache.used, struct image_cache.ref_count):
3173 * gtkutil.c (update_frame_tool_bar):
3174 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3175 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3176 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3177 * nsmenu.m (update_frame_tool_bar):
3178 * xdisp.c (calc_pixel_width_or_height):
3179 * xfns.c (image_cache_refcount):
3180 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3181 on typical 64-bit hosts.
3182
3183 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3184 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3185 Omit unnecessary casts to int.
3186 (parse_image_spec): Check that integers fall into 'int' range
3187 when the callers expect that.
3188 (image_ascent): Redo ascent calculation to avoid int overflow.
3189 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3190 (lookup_image): Remove unnecessary tests.
3191 (xbm_image_p): Locals are now of int, not EMACS_INT,
3192 since parse_image_check makes sure they fit into int.
3193 (png_load, gif_load, svg_load_image):
3194 Prefer int to unsigned where either will do.
3195 (tiff_handler): New function, combining the cores of the
3196 old tiff_error_handler and tiff_warning_handler.
3197 This function is rewritten to use vsnprintf and thereby avoid
3198 stack buffer overflows. It uses only the features of vsnprintf
3199 that are common to both POSIX and native Microsoft.
3200 (tiff_error_handler, tiff_warning_handler): Use it.
3201 (tiff_load, gif_load, imagemagick_load_image):
3202 Don't assume :index value fits in 'int'.
3203 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3204 (imagemagick_load_image): Check that crop parameters fit into
3205 the integer types that MagickCropImage accepts. Don't assume
3206 Vimagemagick_render_type has a nonnegative value. Don't assume
3207 size_t fits in 'long'.
3208 (gs_load): Use printmax_t to print the widest integers possible.
3209 Check for integer overflow when computing image height and width.
3210
32112011-08-26 Eli Zaretskii <eliz@gnu.org>
3212
3213 * xdisp.c (redisplay_window): Don't force window start if point
3214 will be invisible in the resulting window. (Bug#9324)
3215
32162011-08-25 Eli Zaretskii <eliz@gnu.org>
3217
3218 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3219 the display spec is of the form `(space ...)'.
3220 (handle_display_spec): Return the value returned by
3221 handle_single_display_spec, not just 1 or zero.
3222 (handle_single_display_spec): If the display spec is of the form
3223 `(space ...)', and specifies display in the text area, return 2
3224 rather than 1.
3225 (try_cursor_movement): Check for the need to scroll more
3226 accurately, and prefer exact match for point under bidi.
3227 Don't advance `row' beyond the last row of the window.
3228
3229 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3230 into disp_prop; all users changed.
3231
3232 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3233 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3234 for the text covered by the display property.
3235
32362011-08-25 Chong Yidong <cyd@stupidchicken.com>
3237
3238 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3239 Change return value to nil.
3240 (Frecord_buffer): Delete unused function.
3241
32422011-08-24 Eli Zaretskii <eliz@gnu.org>
3243
3244 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3245 buffers, return left-to-right.
3246 (set_cursor_from_row): Consider candidate row a win if its glyph
3247 represents a newline and point is on that newline. Fixes cursor
3248 positioning on the newline at EOL of R2L text within L2R
3249 paragraph, and vice versa.
3250 (try_cursor_movement): Check continued rows, in addition to
3251 continuation rows. Fixes unwarranted scroll when point enters a
3252 continued line of R2L text within an L2R paragraph, or vice versa.
3253 (cursor_row_p): Consider the case of point being equal to
3254 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3255 from the end of a short line to the beginning of a continued line
3256 of R2L text within L2R paragraph.
3257 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3258 composed characters.
3259
3260 * bidi.c (bidi_check_type): Use xassert.
3261 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3262 members.
3263
32642011-08-23 Eli Zaretskii <eliz@gnu.org>
3265
3266 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3267 a character.
3268
32692011-08-23 Chong Yidong <cyd@stupidchicken.com>
3270
3271 * nsfont.m (ns_otf_to_script): Fix typo.
3272
32732011-08-22 Kenichi Handa <handa@m17n.org>
3274
3275 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3276 extra slot even if the purpose is char-code-property-table.
3277
32782011-08-23 Eli Zaretskii <eliz@gnu.org>
3279
3280 * xdisp.c (redisplay_window): When computing centering_position,
3281 account for the height of the header line. (Bug#8874)
3282
3283 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3284 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3285 candidate is selected by the mouse, and that candidate has a
3286 composed character under the mouse.
3287
3288 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3289 coordinates reported by pos-visible-in-window-p for a composed
3290 character in column zero.
3291
32922011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3293
3294 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3295
32962011-08-22 Eli Zaretskii <eliz@gnu.org>
3297
3298 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3299 consider it a hit if to_charpos is anywhere in the range of the
3300 composed buffer positions.
3301
33022011-08-22 Chong Yidong <cyd@stupidchicken.com>
3303
3304 * image.c (gif_load): Don't assume that each subimage has the same
3305 dimensions as the base image. Handle disposal method that is
3306 "undefined" by the gif spec (Bug#9335).
3307
33082011-08-20 Chong Yidong <cyd@stupidchicken.com>
3309
3310 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3311 (Fcondition_case): Document `debug' symbol in error handler.
3312
33132011-08-19 Eli Zaretskii <eliz@gnu.org>
3314
3315 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3316 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3317 from an Org mode buffer to a Speedbar frame.
3318
3319 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3320 a composition, take its buffer position from IT->cmp_it.charpos.
3321 Fixes cursor positioning at the beginning of a line that begins
3322 with a composed character.
3323
33242011-08-18 Eli Zaretskii <eliz@gnu.org>
3325
3326 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3327 character bidirectional type, use STRONG_L instead. Fixes crashes
3328 in a buffer produced by `describe-categories'.
3329
3330 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3331 members before the level stack, so they would be saved and
3332 restored when copying iterator state. Fixes incorrect reordering
3333 around TABs covered by display properties.
3334
33352011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3336
3337 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3338
33392011-08-17 Chong Yidong <cyd@stupidchicken.com>
3340
3341 * eval.c (internal_condition_case, internal_condition_case_1)
3342 (internal_condition_case_2, internal_condition_case_n):
3343 Remove unnecessary aborts (Bug#9081).
3344
33452011-08-17 Eli Zaretskii <eliz@gnu.org>
3346
3347 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3348 has no `load' handler, try opening the file locally. (Bug#9311)
3349
33502011-08-16 Ken Brown <kbrown@cornell.edu>
3351
3352 * gmalloc.c: Expand comment.
3353
33542011-08-16 Eli Zaretskii <eliz@gnu.org>
3355
3356 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3357 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3358
33592011-08-16 Ken Brown <kbrown@cornell.edu>
3360
3361 Fix memory allocation problems in Cygwin build (Bug#9273).
3362
3363 * unexcw.c ( __malloc_initialized): Declare external variable.
3364 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3365
3366 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3367 New variables.
3368 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3369 dumped emacs.
3370 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3371 in the static heap.
3372 [CYGWIN] (special_realloc): New function.
3373 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3374 requests to realloc storage in the static heap.
3375
33762011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3377
3378 * bidi.c (bidi_initialize): Remove unused local.
3379
33802011-08-15 Eli Zaretskii <eliz@gnu.org>
3381
3382 * bidimirror.h:
3383 * biditype.h: Remove file.
3384 * makefile.w32-in ($(BLD)/bidi.$(O)):
3385 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3386
3387 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3388
3389 * chartab.c: Improve commentary for the uniprop_table API.
3390
3391 * bidi.c (bidi_paragraph_init): Support zero value of
3392 bidi_ignore_explicit_marks_for_paragraph_level.
3393 (bidi_initialize): Use uniprop_table instead of including
3394 biditype.h and bidimirror.h.
3395
3396 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3397 coordinates of the iterator when restoring from ppos_it.
3398 (Bug#9296)
3399
34002011-08-14 Kenichi Handa <handa@m17n.org>
3401
3402 * process.c (create_process): Call setup_process_coding_systems
3403 after the pid of the process is set to -1 (Bug#8162).
3404
34052011-08-14 Eli Zaretskii <eliz@gnu.org>
3406
3407 * xdisp.c (move_it_in_display_line_to): Don't invoke
3408 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3409 ppos_it. Fixes vertical cursor motion when line beginning is
3410 covered by an image. (Bug#9296)
3411
34122011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3413
3414 * nsterm.h (ns_run_ascript): Declare.
3415 (NSAPP_DATA2_RUNASSCRIPT): Define.
3416
3417 * nsfns.m (as_script, as_result, as_status): New static variables.
3418 (ns_run_ascript): New function.
3419 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3420 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3421 the event loop. Get status from as_status (Bug#7276).
3422
3423 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3424 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3425 the event loop (Bug#7276).
3426
34272011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3428
3429 * gnutls.c (QCgnutls_bootprop_priority)
3430 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3431 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3432 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3433 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3434 (QCgnutls_bootprop_verify_hostname_error)
3435 (QCgnutls_bootprop_callbacks_verify): Rename from
3436 Qgnutls_bootprop_..., all uses changed.
3437
3438 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3439 uses changed.
3440
34412011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3442
3443 * xfaces.c (Qframe_set_background_mode): Now static.
3444 * dispextern.h (Qframe_set_background_mode): Remove decl.
3445
3446 * process.c (Fnetwork_interface_info): Declare local only if needed.
3447
34482011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3449
3450 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3451 (Fnetwork_interface_list): Allocate in increments of bytes instead
3452 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3453 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3454 sockaddr.
3455 (struct ifflag_def): notrailers is smart on OSX.
3456 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3457 Get hardware address with getifaddrs if available.
3458
34592011-08-12 Eli Zaretskii <eliz@gnu.org>
3460
3461 * xdisp.c (iterate_out_of_display_property): xassert that
3462 IT->position is set to within IT->object's boundaries. Break from
3463 the loop as soon as EOB is reached; avoids infloops in redisplay
3464 when IT->position is set up wrongly due to some bug.
3465 Set IT->current to match the bidi iterator unconditionally.
3466 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3467 entry. Force push_it to save on the stack the current
3468 buffer/string position, to be restored by pop_it. Fix flags in
3469 the iterator structure wrt the object coming from a display
3470 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3471 properties. (Bug#9284)
3472
34732011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3474
3475 * fontset.c (fontset_get_font_group): Add proper type checks.
3476 (Bug#9172)
3477
34782011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3479
3480 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3481 and LC_VERSION_MIN_MACOSX.
3482 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3483 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3484
34852011-08-08 Eli Zaretskii <eliz@gnu.org>
3486
3487 * xdisp.c (forward_to_next_line_start): Allow to use the
3488 no-display-properties-and-no-overlays under bidi display.
3489 Set disp_pos in the bidi iterator to avoid searches for display
3490 properties and overlays.
3491
34922011-08-08 Chong Yidong <cyd@stupidchicken.com>
3493
3494 * editfns.c (Fset_time_zone_rule): Document relationship with the
3495 setenv function.
3496
3497 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3498 the font entity extracted from the cache (Bug#8109).
3499
35002011-08-07 Chong Yidong <cyd@stupidchicken.com>
3501
3502 * composite.c (autocmp_chars): Don't reset point. That is done by
3503 restore_point_unwind (Bug#5984).
3504
35052011-08-07 Juri Linkov <juri@jurta.org>
3506
3507 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3508 to show the arg `TIME' instead of `TIMEVAL'.
3509
35102011-08-06 Eli Zaretskii <eliz@gnu.org>
3511
3512 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3513 display property strides EOL and includes a newline, as in
3514 longlines-mode. (Bug#9254)
3515 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3516 word-wrap under bidirectional display. (Bug#9224)
3517
3518 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3519 is non-zero, even if the data buffer is NULL. Fixes a crash in
3520 vertical-motion with longlines-mode. (Bug#9254)
3521
35222011-08-05 Eli Zaretskii <eliz@gnu.org>
3523
3524 * bidi.c <bidi_cache_total_alloc>: Now static.
3525 (bidi_initialize): Initialize bidi_cache_total_alloc.
3526
3527 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3528 cache. (Bug#9221)
3529
3530 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3531 amount allocated this far in `bidi_cache_total_alloc'.
3532 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3533 non-zero, only free the data buffer without restoring the cache
3534 contents. All callers changed.
3535
3536 * dispextern.h (bidi_unshelve_cache): Update prototype.
3537
3538 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3539 (move_it_in_display_line, move_it_to)
3540 (move_it_vertically_backward, move_it_by_lines): Replace the call
3541 to xfree to an equivalent call to bidi_unshelve_cache.
3542 (move_it_in_display_line_to): Fix logic of returning
3543 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3544
35452011-08-05 Eli Zaretskii <eliz@gnu.org>
3546
3547 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3548 came from a string character with a `cursor' property. (Bug#9229)
3549
35502011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3551
3552 * Makefile.in (LIB_PTHREAD): New variable.
3553 (LIBES): Add LIB_PTHREAD (Bug#9216).
3554
3555 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3556 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3557
35582011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3559
3560 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3561
35622011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3563
3564 * xterm.c (x_find_topmost_parent): New function.
3565 (x_set_frame_alpha): Find topmost parent window with
3566 x_find_topmost_parent and set the property there also (bug#9181).
3567 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3568
35692011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3570
3571 * callproc.c (Fcall_process): Avoid vfork clobbering
3572 the local vars buffer, coding_systems, current_dir.
3573
35742011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3575
3576 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3577
35782011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3579
3580 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3581 so that it is not optimized away.
3582
3583 * xdisp.c (compute_display_string_pos): Remove unused local.
3584
35852011-08-02 Eli Zaretskii <eliz@gnu.org>
3586
3587 Fix slow cursor motion and scrolling in large buffers with
3588 selective display, like Org Mode buffers. (Bug#9218)
3589
3590 * dispextern.h (struct bidi_it): New member disp_prop_p.
3591
3592 * xdisp.c: Remove one-slot cache of display string positions.
3593 (compute_display_string_pos): Accept an additional argument
3594 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3595 for a display string or property. If found, set DISP_PROP_P
3596 non-zero.
3597
3598 * bidi.c (bidi_fetch_char): Accept an additional argument
3599 DISP_PROP_P, and pass it to compute_display_string_pos.
3600 Only handle text covered by a display string if DISP_PROP_P is returned
3601 non-zero. All callers of bidi_fetch_char changed.
3602
36032011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3604
3605 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3606
36072010-12-03 Don March <don@ohspite.net>
3608
3609 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3610 last character M-[char] is translated to ESC [char] (bug#7541).
3611
36122011-08-02 Kenichi Handa <handa@m17n.org>
3613
3614 * lisp.h (uniprop_table): Extern it.
3615
3616 * chartab.c (uniprop_table): Make it non-static.
3617
36182011-08-01 Eli Zaretskii <eliz@gnu.org>
3619
3620 * xdisp.c (forward_to_next_line_start): Accept additional argument
3621 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3622 on the newline.
3623 (reseat_at_next_visible_line_start): Use the bidi iterator state
3624 returned by forward_to_next_line_start to restore the state of
3625 it->bidi_it after backing up to previous newline. (Bug#9212)
3626
36272011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3628
3629 * regex.c (re_comp): Protoize.
3630 (re_exec): Fix return type.
3631 (regexec): Fix type of `ret'. (Bug#9203)
3632
36332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3634
3635 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3636 This is needed if max-image-size is a floating-point number.
3637
36382011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3639
3640 * print.c (print_object): Print empty symbol as ##.
3641
3642 * lread.c (read1): Read ## as empty symbol.
3643
36442011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3645
3646 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3647 setting frame foreground color (Bug#9175).
3648 (x_set_background_color): Likewise.
3649
3650 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3651 contents (Bug#9176).
3652 (EmacsTooltip -init): Remove bezels and add shadows to
3653 tooltip windows.
3654
3655 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3656 or scroll bar (Bug#8470).
3657
3658 * nsfont.m (nsfont_open): Remove assignment to voffset and
3659 unnecessary vars hshink, expand, hd, full_height, min_height.
3660 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3661
3662 * nsterm.h (nsfont_info): Remove voffset field.
3663
36642011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3665
3666 Implement strike-through and overline on NextStep (Bug#8863).
3667
3668 * nsfont.m (nsfont_open): Use underline position provided by font,
3669 instead of hard-coded value of 2.
3670 (nsfont_draw): Call ns_draw_text_decoration instead.
3671
3672 * nsterm.h: Add declaration for ns_draw_text_decoration.
3673
3674 * nsterm.m (ns_draw_text_decoration): New function for drawing
3675 underline, overline, and strike-through.
3676 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3677 ns_draw_text_decoration. Change treatment of cursor drawing to
3678 accommodate underlining, etc.
3679
36802011-07-28 Eli Zaretskii <eliz@gnu.org>
3681
3682 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3683 default.
3684
36852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3686
3687 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3688 Without this fix, if a signal arrives just after memory fills up,
3689 'malloc' might be invoked reentrantly.
3690
3691 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3692 In other words, assume that every image size is allowed, on non-X
3693 hosts. This assumption is probably wrong, but it lets Emacs compile.
3694
36952011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3696
3697 * regex.c (re_iswctype): Convert return values to boolean.
3698
36992011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3700
3701 * xdisp.c (compute_display_string_pos): Don't use cached display
3702 string position if the buffer had its restriction changed.
3703 (Bug#9184)
3704
37052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3708
37092011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3710
3711 Integer signedness and overflow and related fixes. (Bug#9079)
3712
3713 * bidi.c: Integer size and overflow fixes.
3714 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3715 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3716 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3717 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3718 (bidi_find_other_level_edge):
3719 Use ptrdiff_t instead of EMACS_INT where either will do.
3720 This works better on 32-bit hosts configured --with-wide-int.
3721 (bidi_cache_ensure_space): Check for size-calculation overflow.
3722 Use % rather than repeated addition, for better worst-case speed.
3723 Don't set bidi_cache_size until after xrealloc returns, because it
3724 might not return.
3725 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3726 (bidi_cache_ensure_space): Also check that the bidi cache size
3727 does not exceed that of the largest Lisp string or buffer. See Eli
3728 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3729
3730 * alloc.c (__malloc_size_t): Remove.
3731 All uses replaced by size_t. See Andreas Schwab's note
3732 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3733
3734 * image.c: Improve checking for integer overflow.
3735 (check_image_size): Assume that f is nonnull, since
3736 it is always nonnull in practice. This is one less thing to
3737 worry about when checking for integer overflow later.
3738 (x_check_image_size): New function, which checks for integer
3739 overflow issues inside X.
3740 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3741 This removes the need for a memory_full check.
3742 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3743 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3744 (xbm_read_bitmap_data): Change locals back to 'int', since
3745 their values must fit in 'int'.
3746 (xpm_load_image, png_load, tiff_load):
3747 Invoke x_create_x_image_and_pixmap earlier,
3748 to avoid much needless work if the image is too large.
3749 (tiff_load): Treat overly large images as if
3750 x_create_x_image_and_pixmap failed, not as malloc failures.
3751 (gs_load): Use x_check_image_size.
3752
3753 * gtkutil.c: Omit integer casts.
3754 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3755 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3756
3757 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3758
3759 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3760 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3761 would wrongly return t on a 64-bit host.
3762
3763 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3764 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3765 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3766 and therefore cause GCC to emit a bogus diagnostic in some cases.
3767
3768 * image.c: Integer signedness and overflow and related fixes.
3769 This is not an exhaustive set of fixes, but it's time to
3770 record what I've got.
3771 (lookup_pixel_color, check_image_size): Remove redundant decls.
3772 (check_image_size): Don't assume that arbitrary EMACS_INT values
3773 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3774 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3775 (tiff_load, imagemagick_load_image):
3776 Check for overflow in size calculations.
3777 (x_create_x_image_and_pixmap): Remove unnecessary test for
3778 xmalloc returning NULL; that can't happen.
3779 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3780 (xpm_color_bucket): Use better integer hashing function.
3781 (xpm_cache_color): Don't possibly over-allocate memory.
3782 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3783 (gif_memory_source):
3784 Use ptrdiff_t, not int or size_t, to record sizes.
3785 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3786 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3787 either works, as we prefer signed integers.
3788 (tiff_read_from_memory, tiff_write_from_memory):
3789 Return tsize_t, not size_t, since that's what the TIFF API wants.
3790 (tiff_read_from_memory): Don't fail simply because the read would
3791 go past EOF; instead, return a short read.
3792 (tiff_load): Omit no-longer-needed casts.
3793 (Fimagemagick_types): Don't assume size fits into 'int'.
3794
3795 Improve hashing quality when configured --with-wide-int.
3796 * fns.c (hash_string): New function, taken from sxhash_string.
3797 Do not discard information about ASCII character case; this
3798 discarding is no longer needed.
3799 (sxhash-string): Use it. Change sig to match it. Caller changed.
3800 * lisp.h: Declare it.
3801 * lread.c (hash_string): Remove, since we now use fns.c's version.
3802 The fns.c version returns a wider integer if --with-wide-int is
3803 specified, so this should help the quality of the hashing a bit.
3804
3805 * emacs.c: Integer overflow minor fix.
3806 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3807 Define only if GNU_LINUX.
3808 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3809
3810 * dispnew.c: Integer signedness and overflow fixes.
3811 Remove unnecessary forward decls, that were a maintenance hassle.
3812 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3813 All uses changed.
3814 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3815 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3816 (prepare_desired_row, line_draw_cost):
3817 Use int, not unsigned, where either works.
3818 (save_current_matrix, restore_current_matrix):
3819 Use ptrdiff_t, not size_t, where either works.
3820 (init_display): Check for overflow more accurately, and without
3821 relying on undefined behavior.
3822
3823 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3824 Remove, replacing with the new symbols in lisp.h. All uses changed.
3825 * fileio.c (make_temp_name):
3826 * filelock.c (lock_file_1, lock_file):
3827 * xdisp.c (message_dolog):
3828 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3829 Use pMd etc. instead.
3830 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3831 replacing the pWIDE etc. symbols removed from editfns.c.
3832
3833 * keyboard.h (num_input_events): Now uintmax_t.
3834 This is (very slightly) less likely to mess up due to wraparound.
3835 All uses changed.
3836
3837 * buffer.c: Integer signedness fixes.
3838 (alloc_buffer_text, enlarge_buffer_text):
3839 Use ptrdiff_t rather than size_t when either will do, as we prefer
3840 signed integers.
3841
3842 * alloc.c: Integer signedness and overflow fixes.
3843 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3844 (__malloc_size_t): Default to size_t, not to int.
3845 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3846 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3847 Prefer ptrdiff_t to size_t when either would do, as we prefer
3848 signed integers.
3849 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3850 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3851 Now const. Initialize with values that are in range even if char
3852 is signed.
3853 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3854 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3855 These functions do the right thing with sizes > 2**32.
3856 (check_depth): Now ptrdiff_t, not int.
3857 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3858 Adjust to new way of storing sizes. Check for size overflow bugs
3859 in rest of code.
3860 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3861 slightly wrong anyway, as it missed one instance of
3862 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3863 (refill_memory_reserve): Omit needless cast to size_t.
3864 (mark_object_loop_halt): Mark as externally visible.
3865
3866 * xselect.c: Integer signedness and overflow fixes.
3867 (Fx_register_dnd_atom, x_handle_dnd_message):
3868 Use ptrdiff_t, not size_t, since we prefer signed.
3869 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3870 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3871 x_dnd_atoms_size and x_dnd_atoms_length.
3872
3873 * doprnt.c: Prefer signed to unsigned when either works.
3874 * eval.c (verror):
3875 * doprnt.c (doprnt):
3876 * lisp.h (doprnt):
3877 * xdisp.c (vmessage):
3878 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3879 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3880 prefer signed arithmetic to avoid comparison confusion.
3881 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3882 but is a bit tricky.
3883
3884 Assume freestanding C89 headers, string.h, stdlib.h.
3885 * data.c, doprnt.c, floatfns.c, print.c:
3886 Include float.h unconditionally.
3887 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3888 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3889 * regex.c: Likewise for stddef.h, string.h.
3890 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3891 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3892 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3893 (STDC_HEADERS): Remove obsolete defines.
3894 * sysdep.c: Include limits.h unconditionally.
3895
3896 Assume support for memcmp, memcpy, memmove, memset.
3897 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3898 * regex.c (memcmp, memcpy):
3899 Remove; we assume C89 now.
3900
3901 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3902 (__malloc_safe_bcopy): Remove; no longer needed.
3903
3904 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3905 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3906 well either way, and we prefer signed to unsigned.
3907
39082011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3909
3910 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3911 closes the connection while we're reading (bug#9182).
3912
39132011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3914
3915 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3916 are specified (Bug#9168).
3917
39182011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3919
3920 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3921 Found by GCC static checking and --with-wide-int on a 32-bit host.
3922
39232011-07-25 Eli Zaretskii <eliz@gnu.org>
3924
3925 * xdisp.c (compute_display_string_pos): Fix logic of caching
3926 previous display string position. Initialize cached_prev_pos to
3927 -1. Fixes slow-down at the beginning of a buffer.
3928
39292011-07-24 Eli Zaretskii <eliz@gnu.org>
3930
3931 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3932 for attrs[LFACE_FONTSET_INDEX].
3933
39342011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3935
3936 * xml.c (parse_region): Remove unused local
3937 that was recently introduced.
3938
39392011-07-23 Eli Zaretskii <eliz@gnu.org>
3940
3941 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3942 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3943
3944 * xdisp.c (move_it_in_display_line_to): Record the best matching
3945 position for TO_CHARPOS while scanning the line, and restore it on
3946 exit if none of the characters scanned was an exact match.
3947 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3948 when exact match is impossible due to invisible text, and the
3949 lines are truncated.
3950
39512011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3952
3953 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3954 for OSX >= 10.7.
3955
39562011-07-22 Eli Zaretskii <eliz@gnu.org>
3957
3958 Fix a significant slow-down of cursor motion with C-n, C-p,
3959 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3960 auto-repeat under bidi redisplay in fontified buffers.
3961 * xdisp.c (compute_stop_pos_backwards): New function.
3962 (next_element_from_buffer): Call compute_stop_pos_backwards to
3963 find a suitable prev_stop when we find ourselves before
3964 base_level_stop.
3965 (reseat): Don't look for prev_stop, as that could mean a very long
3966 run.
3967 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3968 <cached_disp_overlay_modiff>: Cache for last found display string
3969 position.
3970 (compute_display_string_pos): Return the cached position if asked
3971 about the same buffer in the same area of character positions, and
3972 the buffer wasn't changed since the time the display string
3973 position was cached.
3974
39752011-07-22 Eli Zaretskii <eliz@gnu.org>
3976
3977 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3978 is an integer, which is important for empty lines. (Bug#9149)
3979
39802011-07-22 Chong Yidong <cyd@stupidchicken.com>
3981
3982 * frame.c (Fmodify_frame_parameters): In tty case, update the
3983 default face if necessary (Bug#4238).
3984
39852011-07-21 Chong Yidong <cyd@stupidchicken.com>
3986
3987 * editfns.c (Fstring_to_char): No need to explain what a character
3988 is in the docstring (Bug#6576).
3989
39902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3991
3992 * xml.c (parse_region): Make sure we always return a tree.
3993
39942011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3995
3996 * xml.c (parse_region): If a document contains only comments,
3997 return that, too.
3998
39992011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4000
4001 * xml.c (make_dom): Return comments, too.
4002
40032011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4004
4005 Port to OpenBSD.
4006 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4007 and the surrounding thread.
4008 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4009 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4010 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4011 timer goes off.
4012 * s/openbsd.h (BROKEN_SIGIO): Define.
4013 * unexelf.c (unexec) [__OpenBSD__]:
4014 Don't update the .mdebug section of the Alpha COFF symbol table.
4015
40162011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4017
4018 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4019 (bug#8460).
4020
40212011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4022
4023 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4024 This fixes some race conditions on the permissions of any newly
4025 created file.
4026
4027 * alloc.c (valid_pointer_p): Use pipe, not open.
4028 This fixes some permissions issues when debugging.
4029
4030 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4031 If fchown fails to set both uid and gid, try to set just gid,
4032 as that is sometimes allowed. Adjust the file's mode to eliminate
4033 setuid or setgid bits that are inappropriate if fchown fails.
4034
40352011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4036
4037 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4038 to compare Lisp_Objects.
4039 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4040 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4041 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4042
40432011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4044
4045 * lread.c (read_integer): Unread even EOF character.
4046 (read1): Likewise. Properly record start position of symbol.
4047
4048 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4049 symbol character follows.
4050
40512011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4052
4053 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4054 This works around a problem with the previous change to Fcopy_file.
4055 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4056 and without this change, GCC might complain about discarding
4057 fchown's return value.
4058
40592011-07-16 Juanma Barranquero <lekktu@gmail.com>
4060
4061 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4062
40632011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4064
4065 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4066
40672011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4068
4069 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4070 it's used from the C level.
4071
4072 * process.c: Use the same condition for POLL_FOR_INPUT in both
4073 keyboard.c and process.c (bug#1858).
4074
40752011-07-09 Lawrence Mitchell <wence@gmx.li>
4076
4077 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4078 (Fgnutls_boot): Use it.
4079
40802011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4081
4082 * doc.c (Fsubstitute_command_keys): Revert last change.
4083
40842011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4085
4086 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4087 quotes the next character, and doesn't affect other longer
4088 sequences (bug#8935).
4089
4090 * lread.c (syms_of_lread): Clarify that is isn't only
4091 `eval-buffer' and `eval-defun' that's affected by
4092 `lexical-binding' (bug#8460).
4093
40942011-07-15 Eli Zaretskii <eliz@gnu.org>
4095
4096 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4097 bidi redisplay when a line includes both an image and is truncated.
4098
40992011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4100
4101 Fix minor problems found by static checking.
4102 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4103 (elsz): Now a signed constant, not a size_t var. We prefer signed
4104 types to unsigned, to avoid integer comparison confusion. Without
4105 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4106 "cannot optimize loop, the loop counter may overflow", a symptom
4107 of the confusion.
4108 * indent.c (Fvertical_motion): Mark locals as initialized.
4109 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4110
41112011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4112
4113 * search.c (Fre_search_backward): Mention `case-fold-search' in
4114 all the re_search_* functions (bug#8138).
4115
4116 * keyboard.c (Fopen_dribble_file): Document when the file is
4117 closed (bug#8056).
4118
41192011-07-14 Eli Zaretskii <eliz@gnu.org>
4120
4121 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4122 bidi_cache_idx.
4123
4124 Support bidi reordering of display and overlay strings.
4125 * xdisp.c (compute_display_string_pos)
4126 (compute_display_string_end): Accept additional argument STRING.
4127 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4128 (reseat_to_string): Initialize bidi_it->string.s and
4129 bidi_it->string.schars.
4130 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4131 NULL (avoids a crash in bidi_paragraph_init).
4132 Initialize itb.string.lstring.
4133 (init_iterator): Call bidi_init_it only of a valid
4134 buffer position was specified. Initialize paragraph_embedding to
4135 L2R.
4136 (reseat_to_string): Initialize the bidi iterator.
4137 (display_string): If we need to ignore text properties of
4138 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4139 original value of -1 will not work with bidi.)
4140 (compute_display_string_pos): First arg is now struct
4141 `text_pos *'; all callers changed. Support display properties on
4142 Lisp strings.
4143 (compute_display_string_end): Support display properties on Lisp
4144 strings.
4145 (init_iterator, reseat_1, reseat_to_string): Initialize the
4146 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4147 when iterating on a string not from display properties).
4148 (compute_display_string_pos, compute_display_string_end):
4149 Fix calculation of the object to scan. Fixes an error when using
4150 arrow keys.
4151 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4152 base_level_stop; instead, set base_level_stop to BEGV.
4153 Fixes crashes in vertical-motion.
4154 (next_element_from_buffer): Improve commentary for when
4155 the iterator is before prev_stop.
4156 (init_iterator): Initialize bidi_p from the default value of
4157 bidi-display-reordering, not from buffer-local value. Use the
4158 buffer-local value only if initializing for buffer iteration.
4159 (handle_invisible_prop): Support invisible properties on strings
4160 that are being bidi-reordered.
4161 (set_iterator_to_next): Support bidi reordering of C strings and
4162 Lisp strings.
4163 (next_element_from_string): Support bidi reordering of Lisp
4164 strings.
4165 (handle_stop_backwards): Support Lisp strings as well.
4166 (display_string): Support display of R2L glyph rows.
4167 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4168 (init_iterator): Don't initialize it->bidi_p for strings
4169 here.
4170 (reseat_to_string): Initialize it->bidi_p for strings here.
4171 (next_element_from_string, next_element_from_c_string)
4172 (next_element_from_buffer): Add xassert's for correspondence
4173 between IT's object being iterated and it->bidi_it.string
4174 structure.
4175 (face_before_or_after_it_pos): Support bidi iteration.
4176 (next_element_from_c_string): Handle the case of the first string
4177 character that is not the first one in the visual order.
4178 (get_visually_first_element): New function, refactored from common
4179 parts of next_element_from_buffer, next_element_from_string, and
4180 next_element_from_c_string.
4181 (tool_bar_lines_needed, redisplay_tool_bar)
4182 (display_menu_bar): Force left-to-right direction. Add a FIXME
4183 comment for making that be controlled by a user option.
4184 (push_it, pop_it): Save and restore the state of the
4185 bidi iterator. Save and restore the bidi_p flag.
4186 (pop_it): Iterate out of display property for string iteration as
4187 well.
4188 (iterate_out_of_display_property): Support iteration over strings.
4189 (handle_single_display_spec): Set up it->bidi_it for iteration
4190 over a display string, and call bidi_init_it.
4191 (handle_single_display_spec, next_overlay_string)
4192 (get_overlay_strings_1, push_display_prop): Set up the bidi
4193 iterator for displaying display or overlay strings.
4194 (forward_to_next_line_start): Don't use the shortcut if
4195 bidi-iterating.
4196 (back_to_previous_visible_line_start): If handle_display_prop
4197 pushed the iterator stack, restore the internal state of the bidi
4198 iterator by calling bidi_pop_it same number of times.
4199 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4200 and we are bidi-iterating, don't decrement the iterator position;
4201 instead, set the first_elt flag in the bidi iterator, to produce
4202 the same effect.
4203 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4204 (push_display_prop): xassert that we are iterating a buffer.
4205 (push_it, pop_it): Save and restore paragraph_embedding member.
4206 (handle_single_display_spec, next_overlay_string)
4207 (get_overlay_strings_1, reseat_1, reseat_to_string)
4208 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4209 correctly. Don't assume unibyte strings are not bidi-reordered.
4210 (compute_display_string_pos)
4211 (compute_display_string_end): Fix handling the case of C string.
4212 (push_it, pop_it): Save and restore from_disp_prop_p.
4213 (handle_single_display_spec, push_display_prop): Set the
4214 from_disp_prop_p flag.
4215 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4216 (pop_it): Call iterate_out_of_display_property only if we are
4217 popping after iteration over a string that came from a display
4218 property. Fix a typo in popping stretch info. Add an assertion
4219 for verifying that the iterator position is in sync with the bidi
4220 iterator.
4221 (handle_single_display_spec, get_overlay_strings_1)
4222 (push_display_prop): Fix initialization of paragraph direction for
4223 string when that of the parent object is not yet determined.
4224 (reseat_1): Call bidi_init_it to resync the bidi
4225 iterator with IT's position. (Bug#7616)
4226 (find_row_edges): If ROW->start.pos gives position
4227 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4228 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4229 Reset the from_disp_prop_p flag.
4230 (SAVE_IT, RESTORE_IT): New macros.
4231 (pos_visible_p, face_before_or_after_it_pos)
4232 (back_to_previous_visible_line_start)
4233 (move_it_in_display_line_to, move_it_in_display_line)
4234 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4235 (try_scrolling, redisplay_window, display_line): Use them when
4236 saving a temporary copy of the iterator and restoring it back.
4237 (back_to_previous_visible_line_start, reseat_1)
4238 (init_iterator): Empty the bidi cache "stack".
4239 (move_it_in_display_line_to): If iterator ended up at
4240 EOL, but we never saw any buffer positions smaller than
4241 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4242 motion in bidi-reordered lines.
4243 (move_it_in_display_line_to): Record prev_method and prev_pos
4244 immediately before the call to set_iterator_to_next. Fixes cursor
4245 motion in bidi-reordered lines with stretch glyphs and strings
4246 displayed in margins. (Bug#8133) (Bug#8867)
4247 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4248 TO_CHARPOS.
4249 (pos_visible_p): Support positions in bidi-reordered lines.
4250 Save and restore bidi cache.
4251
4252 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4253 (bidi_paragraph_info): Delete unused struct.
4254 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4255 (bidi_cache_start): New variable.
4256 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4257 to zero.
4258 (bidi_cache_fetch_state, bidi_cache_search)
4259 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4260 (bidi_cache_find, bidi_peek_at_next_level)
4261 (bidi_level_of_next_char, bidi_find_other_level_edge)
4262 (bidi_move_to_visually_next): Compare cache index with
4263 bidi_cache_start rather than with zero.
4264 (bidi_fetch_char): Accept new argument STRING; all callers
4265 changed. Support iteration over a string. Support strings with
4266 display properties. Support unibyte strings. Fix the type of
4267 `len' according to what STRING_CHAR_AND_LENGTH expects.
4268 (bidi_paragraph_init, bidi_resolve_explicit_1)
4269 (bidi_resolve_explicit, bidi_resolve_weak)
4270 (bidi_level_of_next_char, bidi_move_to_visually_next):
4271 Support iteration over a string.
4272 (bidi_set_sor_type, bidi_resolve_explicit_1)
4273 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4274 can now be zero (for strings); special values 0 and -1 were
4275 changed to -1 and -2, respectively.
4276 (bidi_char_at_pos): New function.
4277 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4278 Call it instead of FETCH_MULTIBYTE_CHAR.
4279 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4280 initialized to valid values.
4281 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4282 values.
4283 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4284 the test for valid cached positions. Fix the logic for looking up
4285 the sentinel state in the cache. GCPRO the Lisp string we are
4286 iterating.
4287 (bidi_push_it, bidi_pop_it): New functions.
4288 (bidi_initialize): Initialize the bidi cache start stack pointer.
4289 (bidi_cache_ensure_space): New function, refactored from part of
4290 bidi_cache_iterator_state. Don't assume the required size is just
4291 one BIDI_CACHE_CHUNK away.
4292 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4293 (bidi_count_bytes, bidi_char_at_pos): New functions.
4294 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4295 always valid if bidi_cache_idx is valid.
4296 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4297 is valid if it's going to be used.
4298 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4299 (bidi_cache_fetch_state, bidi_cache_search)
4300 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4301 (bidi_cache_iterator_state, bidi_cache_find)
4302 (bidi_find_other_level_edge, bidi_cache_start_stack):
4303 All variables related to cache indices are now EMACS_INT.
4304
4305 * dispextern.h (struct bidi_string_data): New structure.
4306 (struct bidi_it): New member `string'. Make flag members be 1-bit
4307 fields, and put them last in the struct.
4308 (compute_display_string_pos, compute_display_string_end):
4309 Update prototypes.
4310 (bidi_push_it, bidi_pop_it): Add prototypes.
4311 (struct iterator_stack_entry): New members bidi_p,
4312 paragraph_embedding, and from_disp_prop_p.
4313 (struct it): Member bidi_p is now a bit field 1 bit wide.
4314 (bidi_shelve_cache, bidi_unshelve_cache):
4315 Declare prototypes.
4316
4317 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4318 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4319 and vector-like objects.
4320
4321 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4322 cache around display iteration.
4323
4324 * window.c (Fwindow_end, window_scroll_pixel_based)
4325 (displayed_window_lines, Frecenter): Save and restore the bidi
4326 cache around display iteration.
4327
43282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4329
4330 * editfns.c (Fdelete_region): Clarify the use of the named
4331 parameters (bug#6788).
4332
43332011-07-14 Martin Rudalics <rudalics@gmx.at>
4334
4335 * indent.c (Fvertical_motion): Set and restore w->pointm when
4336 saving and restoring the window's buffer (Bug#9006).
4337
43382011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4339
4340 * editfns.c (Fstring_to_char): Clarify just what is returned
4341 (bug#6576). Text by Eli Zaretskii.
4342
43432011-07-13 Juanma Barranquero <lekktu@gmail.com>
4344
4345 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4346
43472011-07-13 Eli Zaretskii <eliz@gnu.org>
4348
4349 * buffer.c (mmap_find): Fix a typo.
4350
43512011-07-13 Johan Bockgård <bojohan@gnu.org>
4352
4353 Fix execution of x selection hooks.
4354 * xselect.c (Qx_lost_selection_functions)
4355 (Qx_sent_selection_functions): New vars.
4356 (syms_of_xselect): DEFSYM them.
4357 (x_handle_selection_request): Pass Qx_sent_selection_functions
4358 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4359 (x_handle_selection_clear,x_clear_frame_selections):
4360 Pass Qx_lost_selection_functions rather than
4361 Vx_lost_selection_functions to Frun_hook_with_args.
4362
43632011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4364
4365 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4366 The old code sometimes used this field without initializing it.
4367
4368 * alloc.c (gc_sweep): Don't read past end of array.
4369 In theory, the old code could also have corrupted Emacs internals,
4370 though it'd be very unlikely.
4371
43722011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4373
4374 * character.c (Fcharacterp): Don't advertise optional ignored
4375 argument. (Bug#4026)
4376
43772011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4378
4379 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4380 key" (bug#4257).
4381
4382 * window.c (Fset_window_start): Doc fix (bug#4199).
4383 (Fset_window_hscroll): Ditto.
4384
43852011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 Fix minor new problems caught by GCC 4.6.1.
4388 * term.c (init_tty): Remove unused local.
4389 * xsettings.c (store_monospaced_changed): Define this function only
4390 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4391 not used otherwise.
4392
43932011-07-12 Chong Yidong <cyd@stupidchicken.com>
4394
4395 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4396
43972011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4398
4399 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4400 are the mini-buffer and the echo area (bug#3320).
4401
4402 * term.c (init_tty): Remove support for supdup, c10 and perq
4403 terminals, which are no longer supported (bug#1482).
4404
44052011-07-10 Johan Bockgård <bojohan@gnu.org>
4406
4407 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4408
44092011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4410
4411 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4412 for non-popups (Bug#3642).
4413
44142011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4415
4416 * alloc.c (reset_malloc_hooks): Protoize.
4417 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4418 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4419 * cm.c (losecursor): Likewise.
4420 * data.c (fmod): Likewise.
4421 * dispnew.c (swap_glyphs_in_rows): Likewise.
4422 * emacs.c (memory_warning_signal): Likewise.
4423 * floatfns.c (float_error): Likewise.
4424 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4425 (otf_open, font_otf_capability, generate_otf_features)
4426 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4427 Likewise.
4428 * image.c (pbm_read_file): Likewise.
4429 * indent.c (string_display_width): Likewise.
4430 * intervals.c (check_for_interval, search_for_interval)
4431 (inc_interval_count, count_intervals, root_interval)
4432 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4433 * lread.c (defalias): Likewise.
4434 * ralloc.c (r_alloc_check): Likewise.
4435 * regex.c (set_image_of_range_1, set_image_of_range)
4436 (regex_grow_registers): Likewise.
4437 * sysdep.c (strerror): Likewise.
4438 * termcap.c (valid_filename_p, tprint, main): Likewise.
4439 * tparam.c (main): Likewise.
4440 * unexhp9k800.c (run_time_remap, save_data_space)
4441 (update_file_ptrs, read_header, write_header, calculate_checksum)
4442 (copy_file, copy_rest, display_header): Likewise.
4443 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4444 Likewise.
4445 * xdisp.c (check_it): Likewise.
4446 * xfaces.c (register_color, unregister_color, unregister_colors):
4447 Likewise.
4448 * xfns.c (print_fontset_result): Likewise.
4449 * xrdb.c (member, fatal, main): Likewise.
4450
44512011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4452
4453 Fix minor problems found by static checking (Bug#9031).
4454 * chartab.c (char_table_set_range, map_sub_char_table):
4455 Remove unused locals.
4456 (uniprop_table): Now static.
4457 * composite.c (_work_char): Remove unused static var.
4458
44592011-07-09 Juanma Barranquero <lekktu@gmail.com>
4460
4461 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4462
44632011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4464
4465 * gtkutil.c (qttip_cb): Remove code without function.
4466
44672011-07-09 Eli Zaretskii <eliz@gnu.org>
4468
4469 * w32.c (pthread_sigmask): New stub.
4470
44712011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4472
4473 Use pthread_sigmask, not sigprocmask (Bug#9010).
4474 sigprocmask is portable only for single-threaded applications, and
4475 Emacs can be multi-threaded when it uses GTK.
4476 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4477 (LIBES): Use it.
4478 * callproc.c (Fcall_process):
4479 * process.c (create_process):
4480 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4481 Use pthread_sigmask, not sigprocmask.
4482
44832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4484
4485 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4486 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4487 wrong (Bug#8591).
4488
44892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4490
4491 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4492 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4493 (xg_hide_tooltip): Fix comment.
4494
4495 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4496 in registerServicesMenuSendTypes.
4497 (validRequestorForSendType): Don't check ns_return_types.
4498
4499 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4500 ns_return_type.
4501
45022011-07-08 Jason Rumney <jasonr@gnu.org>
4503
4504 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4505 SH_SHOW for hidden windows (Bug#5482).
4506
4507 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4508 frame struct members of non-existent frames (Bug#6284).
4509
45102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4511
4512 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4513 variable firstTime not needed on OSX >= 10.6.
4514 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4515 >= 10.5. Use setKnobProportion, setDoubleValue.
4516
4517 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4518 (MAC_OS_X_VERSION_10_5): Define if not defined.
4519 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4520 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4521 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4522
4523 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4524 cString and lossyCString on OSX >= 10.4
4525
4526 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4527 sizeToFit on OSX >= 10.2.
4528
4529 * nsimage.m (allocInitFromFile): Don't use deprecated method
4530 bestRepresentationForDevice on OSX >= 10.6.
4531
4532 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4533 to avoid warning.
4534
4535 * emacs.c: Declare unexec_init_emacs_zone.
4536
4537 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4538
4539 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4540
4541 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4542 on svcsMenu (Bug#8842).
4543
4544 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4545 ns_return_types.
4546 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4547
4548 * nsterm.m (QUTF8_STRING): Declare.
4549 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4550 (validRequestorForSendType): Return type is (id).
4551 Change indexOfObjectIdenticalTo to indexOfObject.
4552 Check if we have local selection before returning self (Bug#8842).
4553 (writeSelectionToPasteboard): Put local selection into paste board
4554 if we have a local selection (Bug#8842).
4555 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4556
4557 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4558 (ns_get_local_selection): Declare.
4559
45602011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4561
4562 * keymap.c (describe_map_tree): Don't insert a double newline at
4563 the end of the buffer (bug#1169) and return whether we inserted
4564 something.
4565
4566 * callint.c (Fcall_interactively): Change "reading args" to
4567 "providing args" to try to clarify what it does (bug#1010).
4568
45692011-07-07 Kenichi Handa <handa@m17n.org>
4570
4571 * composite.c (composition_compute_stop_pos): Ignore a static
4572 composition starting before CHARPOS (Bug#8915).
4573
4574 * xdisp.c (handle_composition_prop): Likewise.
4575
45762011-07-07 Eli Zaretskii <eliz@gnu.org>
4577
4578 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4579 (Bug#9015)
4580
45812011-07-07 Kenichi Handa <handa@m17n.org>
4582
4583 * character.h (unicode_category_t): New enum type.
4584
4585 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4586 (Qchar_code_property_table): New variable.
4587 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4588 (UNIPROP_COMPRESSED_FORM_P): New macros.
4589 (char_table_ascii): Uncompress the compressed values.
4590 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4591 Uncompress the compressed values.
4592 (sub_char_table_ref_and_range): Likewise.
4593 (char_table_ref_and_range): Uncompress the compressed values.
4594 (sub_char_table_set): New arg is_uniprop. Callers changed.
4595 Uncompress the compressed values.
4596 (sub_char_table_set_range): Args changed. Callers changed.
4597 (char_table_set_range): Adjuted for the above change.
4598 (map_sub_char_table): Delete args default_val and parent. Add arg
4599 top. Give decoded values to a Lisp function.
4600 (map_char_table): Adjust for the above change. Give decoded
4601 values to a Lisp function. Gcpro more variables.
4602 (uniprop_table_uncompress)
4603 (uniprop_decode_value_run_length): New functions.
4604 (uniprop_decoder, uniprop_decoder_count): New variables.
4605 (uniprop_get_decoder, uniprop_encode_value_character)
4606 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4607 New functions.
4608 (uniprop_encoder, uniprop_encoder_count): New variables.
4609 (uniprop_get_encoder, uniprop_table)
4610 (Funicode_property_table_internal, Fget_unicode_property_internal)
4611 (Fput_unicode_property_internal): New functions.
4612 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4613 Sunicode_property_table_internal, Sget_unicode_property_internal,
4614 and Sput_unicode_property_internal. Defvar_lisp
4615 char-code-property-alist.
4616
4617 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4618 Vunicode_category_table.
4619
4620 * font.c (font_range): Adjust for the change of
4621 Vunicode_category_table.
4622
46232011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4624
4625 * m/iris4d.h: Remove file, move contents ...
4626 * s/irix6-5.h: ... here.
4627
46282011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4629
4630 Remove unportable assumption about struct layout (Bug#8884).
4631 * alloc.c (mark_buffer):
4632 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4633 (clone_per_buffer_values): Don't assume that
4634 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4635 This isn't true in general, and it's particularly not true
4636 if Emacs is configured with --with-wide-int.
4637 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4638 New macros, used in the buffer.c change.
4639
46402011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4641
4642 * xsettings.c: Use both GConf and GSettings if both are available.
4643 (store_config_changed_event): Add comment.
4644 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4645 (store_tool_bar_style_changed): New functions.
4646 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4647 (struct xsettings): Move font inside HAVE_XFT.
4648 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4649 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4650 Move inside HAVE_XFT.
4651 (something_changed_gsettingsCB): Rename from something_changedCB.
4652 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4653 also.
4654 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4655 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4656 (something_changed_gconfCB): Rename from something_changedCB.
4657 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4658 (parse_settings): Move check for font inside HAVE_XFT.
4659 (read_settings, apply_xft_settings): Add comment.
4660 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4661 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4662 call store_font_name_changed.
4663 (xft_settings_event): Add comment.
4664 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4665 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4666 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4667 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4668 (xsettings_initialize): Call init_gsettings last.
4669 (xsettings_get_system_font, xsettings_get_system_normal_font):
4670 Add comment.
4671
46722011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4673
4674 Random fixes. E.g., (random) never returned negative values.
4675 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4676 subseconds part to the entropy, as that's a bit more random.
4677 Prefer signed to unsigned, since the signedness doesn't matter and
4678 in general we prefer signed. When given a limit, use a
4679 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4680 latter isn't right if USE_2_TAGS_FOR_INTS.
4681 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4682 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4683
46842011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4685
4686 * textprop.c (text_property_stickiness):
4687 Obey Vtext_property_default_nonsticky.
4688 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4689 * w32fns.c (syms_of_w32fns):
4690 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4691
46922011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4693
4694 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4695 This is more efficient than Ffile_directory_p and avoids a minor race.
4696
46972011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4698
4699 * buffer.c (Foverlay_put): Say what the return value is
4700 (bug#7835).
4701
4702 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4703 is a directory before asking whether to use the file name
4704 (bug#7564).
4705 (barf_or_query_if_file_exists): Make the "File is a directory"
4706 error be more correct.
4707
4708 * fns.c (Frequire): Remove the mention of the .gz files, since
4709 that's installation-specific, but keep the mention of
4710 `get-load-suffixes'.
4711
47122011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4713
4714 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4715 Report string overflow if the output is too long.
4716
47172011-07-04 Juanma Barranquero <lekktu@gmail.com>
4718
4719 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4720 (syms_of_gnutls): Remove duplicate DEFSYM for
4721 Qgnutls_bootprop_verify_hostname_error, an error for
4722 Qgnutls_bootprop_verify_error (which is no longer used).
4723
4724 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4725 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4726 Also (re)move comments that are misplaced or no longer relevant.
4727
47282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4729
4730 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4731
47322011-07-03 Chong Yidong <cyd@stupidchicken.com>
4733
4734 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4735 and background color parameters if they have been changed.
4736
47372011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4738
4739 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4740
47412011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4742
4743 * xsettings.c (SYSTEM_FONT): Define only when used.
4744 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4745
4746 * keymap.c (access_keymap_1): Now static.
4747
47482011-07-02 Chong Yidong <cyd@stupidchicken.com>
4749
4750 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4751 leave any prefix arg for the up event (Bug#1586).
4752
47532011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4754
4755 * lread.c (syms_of_lread): Mention single symbols defined by
4756 `defvar' or `defconst' (bug#7154).
4757
4758 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4759 (Frequire): Mention get-load-suffixes.
4760
47612011-07-02 Martin Rudalics <rudalics@gmx.at>
4762
4763 * window.h (window): Remove clone_number slot.
4764 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4765 Remove.
4766 (make_parent_window, make_window, saved_window)
4767 (Fset_window_configuration, save_window_save): Don't deal with
4768 clone numbers.
4769 * buffer.c (Qclone_number): Remove declaration.
4770 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4771
47722011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4773
4774 Add multiple inheritance to keymaps.
4775 * keymap.c (Fmake_composed_keymap): New function.
4776 (Fset_keymap_parent): Simplify.
4777 (fix_submap_inheritance): Remove.
4778 (access_keymap_1): New function extracted from access_keymap to handle
4779 embedded parents and handle lists of maps.
4780 (access_keymap): Use it.
4781 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4782 (Fcopy_keymap): Handle embedded parents.
4783 (Fcommand_remapping, define_as_prefix): Simplify.
4784 (Fkey_binding): Simplify.
4785 (syms_of_keymap): Move minibuffer-local-completion-map,
4786 minibuffer-local-filename-completion-map,
4787 minibuffer-local-must-match-map, and
4788 minibuffer-local-filename-must-match-map to Elisp.
4789 (syms_of_keymap): Defsubr make-composed-keymap.
4790 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4791 (parse_menu_item): Trivial simplification.
4792
47932011-07-01 Glenn Morris <rgm@gnu.org>
4794
4795 * Makefile.in (SETTINGS_LIBS): Fix typo.
4796
47972011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4798
4799 * coding.c (Fencode_coding_string): Record the last coding system
4800 used, as the function doc string says (bug#8738).
4801
48022011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4803
4804 * xsettings.c (store_monospaced_changed): Take new font as arg and
4805 check for change against current_mono_font.
4806 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4807 (emacs_settings_constructor, emacs_settings_get_property)
4808 (emacs_settings_set_property, emacs_settings_class_init)
4809 (emacs_settings_init, gsettings_obj): Remove.
4810 (something_changedCB): New function for HAVE_GSETTINGS.
4811 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4812 with value as argument.
4813 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4814 g_settings_new (Bug#8967). Do not create gsettings_obj.
4815 Remove calls to g_settings_bind. Connect something_changedCB to
4816 "changed".
4817
4818 * xgselect.c: Add defined (HAVE_GSETTINGS).
4819 (xgselect_initialize): Ditto.
4820
4821 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4822 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4823 xg_select.
4824
48252011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4826
4827 * eval.c (struct backtrace): Simplify and port the data structure.
4828 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4829 signed bit field, as this assumption is not portable and it makes
4830 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4831 "char debug_on_exit : 1" as this is not portable either; instead,
4832 use the portable "unsigned int debug_on_exit : 1". Remove unused
4833 member evalargs. Remove obsolete comments about cc bombing out.
4834
48352011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4836
4837 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4838 Let HAVE_GSETTINGS override HAVE_GCONF.
4839 (store_monospaced_changed): New function.
4840 (EMACS_SETTINGS): A new type derived from GObject to handle
4841 GSettings notifications.
4842 (emacs_settings_constructor, emacs_settings_get_property)
4843 (emacs_settings_set_property, emacs_settings_class_init):
4844 New functions.
4845 (gsettings_client, gsettings_obj): New variables.
4846 (GSETTINGS_SCHEMA): New define.
4847 (something_changedCB): Call store_monospaced_changed.
4848 (init_gsettings): New function.
4849 (xsettings_initialize): Call init_gsettings.
4850 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4851 to NULL.
4852
4853 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4854 GCONF_CFLAGS/LIBS.
4855
48562011-06-29 Martin Rudalics <rudalics@gmx.at>
4857
4858 * window.c (resize_root_window, grow_mini_window)
4859 (shrink_mini_window): Rename Qresize_root_window to
4860 Qwindow_resize_root_window and Qresize_root_window_vertically to
4861 Qwindow_resize_root_window_vertically.
4862
48632011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4864
4865 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4866
48672011-06-27 Juanma Barranquero <lekktu@gmail.com>
4868
4869 * makefile.w32-in: Redesign dependencies so they reflect more
4870 clearly which files are directly included by each source file,
4871 and not through other includes.
4872
48732011-06-27 Martin Rudalics <rudalics@gmx.at>
4874
4875 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4876 (sort_overlays, overlay_strings): When an overlay's clone number
4877 matches the window's clone number process the overlay even if
4878 the overlay's window property doesn't match the current window.
4879
4880 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4881 (Fwindow_hchild): Rename to Fwindow_left_child.
4882 (Fwindow_next): Rename to Fwindow_next_sibling.
4883 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4884 (resize_window_check): Rename to window_resize_check.
4885 (resize_window_apply): Rename to window_resize_apply.
4886 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4887 (Fdelete_other_windows_internal, resize_frame_windows)
4888 (Fsplit_window_internal, Fdelete_window_internal)
4889 (grow_mini_window, shrink_mini_window)
4890 (Fresize_mini_window_internal): Fix callers accordingly.
4891
48922011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4893
4894 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4895 (emacs_fixed_set_min_size): Remove.
4896 (emacs_fixed_new): Take frame as argument.
4897
4898 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4899 (_EmacsFixedPrivate): Remove minwidth/height.
4900 Add struct frame *f.
4901 (emacs_fixed_init): Initialize priv->f.
4902 (get_parent_class, emacs_fixed_set_min_size): Remove.
4903 (emacs_fixed_new): Set priv->f to argument.
4904 (emacs_fixed_get_preferred_width)
4905 (emacs_fixed_get_preferred_height): Use min_width/height from
4906 frames size_hint to set minimum and natural (Bug#8919).
4907 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4908 and use min_width/height from frames size_hint to set
4909 min_width/height (Bug#8919).
4910
4911 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4912 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4913 Fix indentation.
4914
49152011-06-26 Eli Zaretskii <eliz@gnu.org>
4916
4917 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4918 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4919 called at ZV.
4920
49212011-06-26 Chong Yidong <cyd@stupidchicken.com>
4922
4923 * process.c (wait_reading_process_output): Bypass select if
4924 waiting for a cell while ignoring keyboard input, and input is
4925 pending. Suggested by Jan Djärv (Bug#8869).
4926
49272011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4928
4929 Use gnulib's dup2 module instead of rolling our own.
4930 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4931
49322011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4933
4934 * dispnew.c (scrolling_window): Before scrolling, turn off a
4935 mouse-highlight in the window being scrolled.
4936
49372011-06-24 Juanma Barranquero <lekktu@gmail.com>
4938
4939 Move DEFSYM to lisp.h and use everywhere.
4940
4941 * character.h (DEFSYM): Move declaration...
4942 * lisp.h (DEFSYM): ...here.
4943
4944 * gnutls.c:
4945 * minibuf.c:
4946 * w32menu.c:
4947 * w32proc.c:
4948 * w32select.c: Don't include character.h.
4949
4950 * alloc.c (syms_of_alloc):
4951 * buffer.c (syms_of_buffer):
4952 * bytecode.c (syms_of_bytecode):
4953 * callint.c (syms_of_callint):
4954 * casefiddle.c (syms_of_casefiddle):
4955 * casetab.c (init_casetab_once):
4956 * category.c (init_category_once, syms_of_category):
4957 * ccl.c (syms_of_ccl):
4958 * cmds.c (syms_of_cmds):
4959 * composite.c (syms_of_composite):
4960 * dbusbind.c (syms_of_dbusbind):
4961 * dired.c (syms_of_dired):
4962 * dispnew.c (syms_of_display):
4963 * doc.c (syms_of_doc):
4964 * editfns.c (syms_of_editfns):
4965 * emacs.c (syms_of_emacs):
4966 * eval.c (syms_of_eval):
4967 * fileio.c (syms_of_fileio):
4968 * fns.c (syms_of_fns):
4969 * frame.c (syms_of_frame):
4970 * fringe.c (syms_of_fringe):
4971 * insdel.c (syms_of_insdel):
4972 * keymap.c (syms_of_keymap):
4973 * lread.c (init_obarray, syms_of_lread):
4974 * macros.c (syms_of_macros):
4975 * msdos.c (syms_of_msdos):
4976 * print.c (syms_of_print):
4977 * process.c (syms_of_process):
4978 * search.c (syms_of_search):
4979 * sound.c (syms_of_sound):
4980 * syntax.c (init_syntax_once, syms_of_syntax):
4981 * terminal.c (syms_of_terminal):
4982 * textprop.c (syms_of_textprop):
4983 * undo.c (syms_of_undo):
4984 * w32.c (globals_of_w32):
4985 * window.c (syms_of_window):
4986 * xdisp.c (syms_of_xdisp):
4987 * xfaces.c (syms_of_xfaces):
4988 * xfns.c (syms_of_xfns):
4989 * xmenu.c (syms_of_xmenu):
4990 * xsettings.c (syms_of_xsettings):
4991 * xterm.c (syms_of_xterm): Use DEFSYM.
4992
49932011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4994
4995 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4996
49972011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4998
4999 Integer and buffer overflow fixes (Bug#8873).
5000
5001 * print.c (printchar, strout): Check for string overflow.
5002 (PRINTPREPARE, printchar, strout):
5003 Don't set size unless allocation succeeds.
5004
5005 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5006 for sizes. Check for string overflow more accurately.
5007 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5008
5009 * macros.c: Integer and buffer overflow fixes.
5010 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5011 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5012 Use ptrdiff_t, not int, for sizes.
5013 Don't increment bufsize until after realloc succeeds.
5014 Check for size-calculation overflow.
5015 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5016
5017 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5018
5019 * lread.c: Integer overflow fixes.
5020 (read_integer): Radix is now EMACS_INT, not int,
5021 to improve quality of diagnostics for out-of-range radices.
5022 Calculate buffer size correctly for out-of-range radices.
5023 (read1): Check for integer overflow in radices, and in
5024 read-circle numbers.
5025 (read_escape): Avoid int overflow.
5026 (Fload, openp, read_buffer_size, read1)
5027 (substitute_object_recurse, read_vector, read_list, map_obarray):
5028 Use ptrdiff_t, not int, for sizes.
5029 (read1): Use EMACS_INT, not int, for sizes.
5030 Check for size overflow.
5031
5032 * image.c (cache_image): Check for size arithmetic overflow.
5033
5034 * lread.c: Integer overflow issues.
5035 (saved_doc_string_size, saved_doc_string_length)
5036 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5037 Now ptrdiff_t, not int.
5038 (read1): Don't assume doc string length fits in int. Check for
5039 out-of-range doc string lengths.
5040 (read_list): Don't assume file position fits in int.
5041 (read_escape): Check for hex character overflow.
5042
50432011-06-22 Leo Liu <sdl.web@gmail.com>
5044
5045 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5046 Move to minibuffer.el.
5047
50482011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5049
5050 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5051 The following patches are for when GLYPH_DEBUG && !XASSERT.
5052 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5053 * dispnew.c (flush_stdout):
5054 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5055 Mark as externally visible.
5056 * dispnew.c (check_window_matrix_pointers): Now static.
5057 * dispnew.c (window_to_frame_vpos):
5058 * xfns.c (unwind_create_frame):
5059 * xterm.c (x_check_font): Remove unused local.
5060 * scroll.c (CHECK_BOUNDS):
5061 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5062 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5063 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5064 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5065 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5066 Now static.
5067 (debug_method_add): Use va_list and vsprintf rather than relying
5068 on undefined behavior with wrong number of arguments.
5069 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5070 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5071 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5072 since we're not interested in debugging glyphs with old libraries.
5073 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5074 GCC 4.6.0's static checking.
5075
50762011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5077
5078 Integer overflow and signedness fixes (Bug#8873).
5079 A few related buffer overrun fixes, too.
5080
5081 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5082
5083 * dispextern.h (struct face.stipple):
5084 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5085 (x_bitmap_mask, x_allocate_bitmap_record)
5086 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5087 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5088 (x_create_bitmap_from_xpm_data):
5089 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5090 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5091 (.bitmaps_last):
5092 * xfaces.c (load_pixmap):
5093 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5094 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5095 (.bitmaps_last, struct x_output.icon_bitmap):
5096 Use ptrdiff_t, not int, for bitmap indexes.
5097 (x_allocate_bitmap_record): Check for size overflow.
5098 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5099
5100 Use ptrdiff_t, not int, for overlay counts.
5101 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5102 * editfns.c (overlays_around, get_pos_property):
5103 * textprop.c (get_char_property_and_overlay):
5104 * xdisp.c (next_overlay_change, note_mouse_highlight):
5105 * xfaces.c (face_at_buffer_position):
5106 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5107 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5108 (Fnext_overlay_change, Fprevious_overlay_change)
5109 (mouse_face_overlay_overlaps, Foverlays_in):
5110 Use ptrdiff_t, not int, for sizes.
5111 (overlays_at, overlays_in): Check for size-calculation overflow.
5112
5113 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5114
5115 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5116 (x_session_initialize): Do not assume string length fits in int.
5117
5118 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5119 This is unlikely, but can occur if DPI is outlandish.
5120
5121 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5122 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5123
5124 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5125 * xrdb.c (magic_file_p, search_magic_path):
5126 Omit last arg SUFFIX; it was always 0. All callers changed.
5127 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5128
5129 * xfont.c (xfont_match): Avoid need for strlen.
5130
5131 * xfns.c: Don't assume strlen fits in int.
5132 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5133
5134 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5135 not unsigned long, as we prefer signed integers. All callers changed.
5136 Detect integer overflow in repeat count.
5137 (message_dolog): Don't assume print length fits in 39 bytes.
5138 (display_mode_element): Don't assume strlen fits in int.
5139
5140 * termcap.c: Don't assume sizes fit in int and never overflow.
5141 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5142 (gobble_line): Check for size-calculation overflow.
5143
5144 * minibuf.c (Fread_buffer):
5145 * lread.c (intern, intern_c_string):
5146 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5147 Don't assume string length fits in int.
5148
5149 * keyboard.c (parse_tool_bar_item):
5150 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5151
5152 * font.c: Don't assume string length fits in int.
5153 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5154 Use ptrdiff_t, not int.
5155 (font_intern_prop): Don't assume string length fits in int.
5156 Don't assume integer property fits in fixnum.
5157 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5158
5159 * filelock.c: Fix some buffer overrun and integer overflow issues.
5160 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5161 Reformulate so as not to need the command string.
5162 Invoke gzip -cd rather than gunzip, as it's more portable.
5163 (lock_info_type, lock_file_1, lock_file):
5164 Don't assume pid_t and time_t fit in unsigned long.
5165 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5166 (current_lock_owner): Prefer signed type for sizes.
5167 Use memcpy, not strncpy, where memcpy is what is really wanted.
5168 Don't assume (via atoi) that time_t and pid_t fit in int.
5169 Check for time_t and/or pid_t out of range, e.g., via a network share.
5170 Don't alloca where an auto var works fine.
5171
5172 * fileio.c: Fix some integer overflow issues.
5173 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5174 Don't assume string length fits in int.
5175 (directory_file_name): Don't assume string length fits in long.
5176 (make_temp_name): Don't assume pid fits in int, or that its print
5177 length is less than 20.
5178
5179 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5180
5181 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5182
5183 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5184
5185 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5186 We prefer signed integers, even for size calculations.
5187
5188 * emacs.c: Don't assume string length fits in 'int'.
5189 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5190 (main): Don't invoke strlen when not needed.
5191
5192 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5193 (XD_DEBUG_MESSAGE): Don't waste a byte.
5194
5195 * callproc.c (getenv_internal_1, getenv_internal)
5196 (Fgetenv_internal):
5197 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5198
5199 * lread.c (invalid_syntax): Omit length argument.
5200 All uses changed. This doesn't fix a bug, but it simplifies the
5201 code away from its former Hollerith-constant appearance, and it's
5202 one less 'int' to worry about when looking at integer-overflow issues.
5203 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5204
5205 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5206 This didn't break anything, but it didn't help either.
5207 It's confusing to put a bogus integer in a place where the actual
5208 value does not matter.
5209 (LIST_END_P): Remove unused macro and its bogus comment.
5210 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5211
5212 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5213 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5214 implementation.
5215 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5216 We prefer signed types, and the value cannot exceed the EMACS_INT
5217 range anyway (because otherwise the length would not be representable).
5218 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5219 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5220 This avoids a GCC warning when WIDE_EMACS_INT.
5221
5222 * indent.c (sane_tab_width): New function.
5223 (current_column, scan_for_column, Findent_to, position_indentation)
5224 (compute_motion): Use it. This is just for clarity.
5225 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5226
5227 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5228
5229 * lisp.h (lint_assume): New macro.
5230 * composite.c (composition_gstring_put_cache):
5231 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5232
5233 * editfns.c, insdel.c:
5234 Omit unnecessary forward decls, to simplify future changes.
5235
5236 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5237
5238 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5239
5240 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5241 Use much-faster test for byte-length change.
5242 Don't assume string byte-length fits in 'int'.
5243 Check that character arg fits in 'int'.
5244 (mapcar1): Declare byte as byte, for clarity.
5245
5246 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5247
5248 * fns.c (concat): Catch string overflow earlier.
5249 Do not rely on integer wraparound.
5250
5251 * dispextern.h (struct it.overlay_strings_charpos)
5252 (struct it.selective): Now EMACS_INT, not int.
5253 * xdisp.c (forward_to_next_line_start)
5254 (back_to_previous_visible_line_start)
5255 (reseat_at_next_visible_line_start, next_element_from_buffer):
5256 Don't arbitrarily truncate the value of 'selective' to int.
5257
5258 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5259
5260 * composite.c: Don't truncate sizes to 'int'.
5261 (composition_gstring_p, composition_reseat_it)
5262 (composition_adjust_point): Use EMACS_INT, not int.
5263 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5264 not EMACS_UINT, for indexes.
5265
5266 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5267
5268 * buffer.c: Include <verify.h>.
5269 (struct sortvec.priority, struct sortstr.priority):
5270 Now EMACS_INT, not int.
5271 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5272 (struct sortstr.size, record_overlay_string)
5273 (struct sortstrlist.size, struct sortlist.used):
5274 Don't truncate size to int.
5275 (record_overlay_string): Check for size-calculation overflow.
5276 (init_buffer_once): Check at compile-time, not run-time.
5277
52782011-06-22 Jim Meyering <meyering@redhat.com>
5279
5280 Don't leak an XBM-image-sized buffer
5281 * image.c (xbm_load): Free the image buffer after using it.
5282
52832011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5284
5285 Port to Sun C.
5286 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5287 that Sun C diagnosed.
5288 * fns.c (secure_hash): Fix pointer signedness issue.
5289 * intervals.c (static_offset_intervals): New function.
5290 (offset_intervals): Use it.
5291
52922011-06-21 Leo Liu <sdl.web@gmail.com>
5293
5294 * deps.mk (fns.o):
5295 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5296 sha512.h.
5297
5298 * fns.c (secure_hash): Rename from crypto_hash_function and change
5299 the first arg to accept symbols.
5300 (Fsecure_hash): New primitive.
5301 (syms_of_fns): New symbols.
5302
53032011-06-20 Deniz Dogan <deniz@dogan.se>
5304
5305 * process.c (Fset_process_buffer): Clarify return value in
5306 docstring.
5307
53082011-06-18 Chong Yidong <cyd@stupidchicken.com>
5309
5310 * dispnew.c (add_window_display_history): Use BVAR.
5311
5312 * xdisp.c (debug_method_add): Use BVAR.
5313 (check_window_end, dump_glyph_matrix, dump_glyph)
5314 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5315
5316 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5317 Likewise.
5318
5319 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5320 check till after the cache is created in init_frame_faces.
5321
53222011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5323
5324 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5325
53262011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5327
5328 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5329 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5330 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5331
5332 Improve buffer-overflow checking (Bug#8873).
5333 * fileio.c (Finsert_file_contents):
5334 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5335 Remove the old (too-loose) buffer overflow checks.
5336 They weren't needed, since make_gap checks for buffer overflow.
5337 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5338 The old code merely checked for Emacs fixnum overflow, and relied
5339 on undefined (wraparound) behavior. The new code avoids undefined
5340 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5341
5342 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5343 Tune. Don't use wider integers than needed. Don't use alloca.
5344 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5345
5346 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5347
5348 * insdel.c, lisp.h (buffer_overflow): New function.
5349 (insert_from_buffer_1, replace_range, replace_range_2):
5350 * insdel.c (make_gap_larger):
5351 * editfns.c (Finsert_char):
5352 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5353
5354 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5355
53562011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5357
5358 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5359
5360 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5361 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5362
5363 * fileio.c: Don't assume EMACS_INT fits in off_t.
5364 (emacs_lseek): New static function.
5365 (Finsert_file_contents, Fwrite_region): Use it.
5366 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5367
5368 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5369
5370 * fns.c: Don't overflow int when computing a list length.
5371 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5372 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5373 truncation on 64-bit hosts. Check for QUIT every
5374 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5375 faster and is responsive enough.
5376 (Flength): Report an error instead of overflowing an integer.
5377 (Fsafe_length): Return a float if the value is not representable
5378 as a fixnum. This shouldn't happen except in contrived situations.
5379 (Fnthcdr, Fsort): Don't assume list length fits in int.
5380 (Fcopy_sequence): Don't assume vector length fits in int.
5381
5382 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5383 (header_size, word_size): New constants.
5384 (allocate_vectorlike): Don't check size overflow here.
5385 (allocate_vector): Check it here instead, since this is the only
5386 caller of allocate_vectorlike that could cause overflow.
5387 Check that the new vector's length is representable as a fixnum.
5388
5389 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5390 The previous code was bogus. For example, next_almost_prime (32)
5391 returned 39, which is undesirable as it is a multiple of 3; and
5392 next_almost_prime (24) returned 25, which is a multiple of 5 so
5393 why was the code bothering to check for multiples of 7?
5394
5395 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5396
5397 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5398
5399 Variadic C functions now count arguments with ptrdiff_t.
5400 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5401 Back then I didn't know that the Emacs coding style prefers signed int.
5402 Also, in the meantime I found a few more instances where arguments
5403 were being counted with int, which may truncate counts on 64-bit
5404 machines, or EMACS_INT, which may be unnecessarily wide.
5405 * lisp.h (struct Lisp_Subr.function.aMANY)
5406 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5407 Arg counts are now ptrdiff_t, not size_t.
5408 All variadic functions and their callers changed accordingly.
5409 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5410 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5411 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5412 * callint.c (Fcall_interactively): Check arg count for overflow,
5413 to avoid potential buffer overrun. Use signed char, not 'int',
5414 for 'varies' array, so that we needn't bother to check its size
5415 calculation for overflow.
5416 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5417 * eval.c (apply_lambda):
5418 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5419 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5420 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5421
5422 * callint.c (Fcall_interactively): Don't use index var as event count.
5423
5424 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5425 * mem-limits.h (SIZE): Remove; no longer used.
5426
5427 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5428
5429 Remove unnecessary casts.
5430 * xterm.c (x_term_init):
5431 * xfns.c (x_set_border_pixel):
5432 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5433 These aren't needed now that we assume ANSI C.
5434
5435 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5436 It's more likely to cause problems (due to unsigned overflow)
5437 than to cure them.
5438
5439 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5440
5441 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5442
5443 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5444
5445 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5446
5447 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5448
5449 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5450
5451 GLYPH_CODE_FACE returns EMACS_INT, not int.
5452 * dispextern.h (merge_faces):
5453 * xfaces.c (merge_faces):
5454 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5455 Don't assume EMACS_INT fits in int.
5456
5457 * character.h (CHAR_VALID_P): Remove unused parameter.
5458 * fontset.c, lisp.h, xdisp.c: All uses changed.
5459
5460 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5461
5462 * fns.c (concat): Minor tuning based on overflow analysis.
5463 This doesn't fix any bugs. Use int to hold character, instead
5464 of constantly refetching from Emacs object. Use XFASTINT, not
5465 XINT, for value known to be a character. Don't bother comparing
5466 a single byte to 0400, as it's always less.
5467
5468 * floatfns.c (Fexpt):
5469 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5470
5471 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5472 for characters.
5473
5474 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5475
5476 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5477 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5478 incorrectly succeed when S was a string, because 4294967386 was
5479 truncated before it was used.
5480
5481 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5482 Otherwise, an out-of-range integer could cause undefined behavior
5483 on a 64-bit host.
5484
5485 * composite.c: Use int, not EMACS_INT, for characters.
5486 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5487 EMACS_INT, for values that are known to be in character range.
5488 This doesn't fix any bugs but is the usual style inside Emacs and
5489 may generate better code on 32-bit machines.
5490
5491 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5492 This is for reasons similar to the recent CHAR_STRING fix.
5493 * charset.c (Fencode_char): Check that character arg is actually
5494 a character. Pass an int to ENCODE_CHAR.
5495 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5496 wider than 'int', as a compile-time check to prevent future regressions
5497 in this area.
5498
5499 * character.c (char_string): Remove unnecessary casts.
5500
5501 Make sure a 64-bit char is never passed to CHAR_STRING.
5502 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5503 by silently ignoring the top 32 bits, allowing some values
5504 that were far too large to be valid characters.
5505 * character.h: Include <verify.h>.
5506 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5507 arguments are no wider than unsigned, as a compile-time check
5508 to prevent future regressions in this area.
5509 * data.c (Faset):
5510 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5511 (Fsubst_char_in_region):
5512 * fns.c (concat):
5513 * xdisp.c (decode_mode_spec_coding):
5514 Adjust to CHAR_STRING's new requirement.
5515 * editfns.c (Finsert_char, Fsubst_char_in_region):
5516 * fns.c (concat): Check that character args are actually
5517 characters. Without this test, these functions did the wrong
5518 thing with wildly out-of-range values on 64-bit hosts.
5519
5520 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5521 These casts should not be needed on 32-bit hosts, either.
5522 * keyboard.c (read_char):
5523 * lread.c (Fload): Remove casts to unsigned.
5524
5525 * lisp.h (UNSIGNED_CMP): New macro.
5526 This fixes comparison bugs on 64-bit hosts.
5527 (ASCII_CHAR_P): Use it.
5528 * casefiddle.c (casify_object):
5529 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5530 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5531 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5532 * dispextern.h (FACE_FROM_ID):
5533 * keyboard.c (read_char): Use UNSIGNED_CMP.
5534
5535 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5536 not to EMACS_INT, to avoid GCC warning.
5537
5538 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5539
5540 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5541 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5542 isn't needed on 32-bit machines.
5543
5544 * buffer.c (Fgenerate_new_buffer_name):
5545 Use EMACS_INT for count, not int.
5546 (advance_to_char_boundary): Return EMACS_INT, not int.
5547
5548 * data.c (Qcompiled_function): Now static.
5549
5550 * window.c (window_body_lines): Now static.
5551
5552 * image.c (gif_load): Rename local to avoid shadowing.
5553
5554 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5555 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5556 * alloc.c (make_save_value): Integer argument is now of type
5557 ptrdiff_t, not int.
5558 (mark_object): Use ptrdiff_t, not int.
5559 * lisp.h (pD): New macro.
5560 * print.c (print_object): Use it.
5561
5562 * alloc.c: Use EMACS_INT, not int, to count objects.
5563 (total_conses, total_markers, total_symbols, total_vector_size)
5564 (total_free_conses, total_free_markers, total_free_symbols)
5565 (total_free_floats, total_floats, total_free_intervals)
5566 (total_intervals, total_strings, total_free_strings):
5567 Now EMACS_INT, not int. All uses changed.
5568 (Fgarbage_collect): Compute overall total using a double, so that
5569 integer overflow is less likely to be a problem. Check for overflow
5570 when converting back to an integer.
5571 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5572 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5573 These were 'int' variables that could overflow on 64-bit hosts;
5574 they were never used, so remove them instead of repairing them.
5575 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5576 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5577 Previously, this ceilinged at INT_MAX, but that doesn't work on
5578 64-bit machines.
5579 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5580
5581 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5582 (allocate_vectorlike): Check for ptrdiff_t overflow.
5583 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5584 when a (possibly-narrower) signed value would do just as well.
5585 We prefer using signed arithmetic, to avoid comparison confusion.
5586
5587 * alloc.c: Catch some string size overflows that we were missing.
5588 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5589 for convenience in STRING_BYTES_MAX.
5590 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5591 The definition here is exact; the one in lisp.h was approximate.
5592 (allocate_string_data): Check for string overflow. This catches
5593 some instances we weren't catching before. Also, it catches
5594 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5595 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5596 and ptrdiff_t and EMACS_INT are both 64 bits.
5597
5598 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5599 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5600 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5601
5602 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5603
5604 * alloc.c (Fmake_string): Check for out-of-range init.
5605
56062011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5607
5608 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5609
56102011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5611
5612 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5613 xg_get_default_scrollbar_width.
5614
5615 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5616 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5617 (style_changed_cb): Call update_theme_scrollbar_width and call
5618 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5619 all frames (Bug#8505).
5620 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5621 Call gtk_window_set_resizable if HAVE_GTK3.
5622 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5623 and height if HAVE_GTK3 (Bug#8505).
5624 (scroll_bar_width_for_theme): New variable.
5625 (update_theme_scrollbar_width): New function.
5626 (xg_get_default_scrollbar_width): Move code to
5627 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5628 (xg_initialize): Call update_theme_scrollbar_width.
5629
5630 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5631
5632 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5633
56342011-06-12 Martin Rudalics <rudalics@gmx.at>
5635
5636 * frame.c (make_frame): Call other_buffer_safely instead of
5637 other_buffer.
5638
5639 * window.c (temp_output_buffer_show): Call display_buffer with
5640 second argument Vtemp_buffer_show_specifiers and reset latter
5641 immediately after the call.
5642 (Vtemp_buffer_show_specifiers): New variable.
5643 (auto_window_vscroll_p, next_screen_context_lines)
5644 (Vscroll_preserve_screen_position): Remove leading asterisks from
5645 doc-strings.
5646
56472011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5648
5649 Fix minor problems found by GCC 4.6.0 static checking.
5650 * buffer.c (Qclone_number): Remove for now, as it's unused.
5651 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5652 (record_buffer): Remove unused local.
5653 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5654 (set_frame_buffer_list): Remove; unused.
5655 * frame.h (other_visible_frames): Remove decl.
5656 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5657 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5658 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5659 if HAVE_GPM.
5660 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5661 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5662 Define only if HAVE_GPM.
5663 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5664 (update_hints_inhibit): Remove; never set. All uses removed.
5665 * widgetprv.h (emacsFrameClassRec): Remove decl.
5666 * window.c (delete_deletable_window): Now returns void, since it
5667 wasn't returning anything.
5668 (compare_window_configurations): Remove unused locals.
5669 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5670 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5671 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5672 the same widths as pointers. This follows up on the 2011-05-06 patch.
5673 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5674 * xterm.h: Likewise.
5675 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5676
56772011-06-12 Juanma Barranquero <lekktu@gmail.com>
5678
5679 * makefile.w32-in: Update dependencies.
5680 (LISP_H): Add lib/intprops.h.
5681
56822011-06-11 Chong Yidong <cyd@stupidchicken.com>
5683
5684 * image.c (gif_load): Add animation frame delay to the metadata.
5685 (syms_of_image): Use DEFSYM. New symbol `delay'.
5686
56872011-06-11 Martin Rudalics <rudalics@gmx.at>
5688
5689 * window.c (delete_deletable_window): Re-add.
5690 (Fset_window_configuration): Rewrite to handle dead buffers and
5691 consequently deletable windows.
5692 (window_tree, Fwindow_tree): Remove. Supply functionality in
5693 window.el.
5694 (compare_window_configurations): Simplify code.
5695
56962011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5697
5698 * image.c (imagemagick_load_image): Fix type mismatch.
5699 (Fimagemagick_types): Likewise.
5700
5701 * window.h (replace_buffer_in_windows): Declare.
5702
57032011-06-11 Martin Rudalics <rudalics@gmx.at>
5704
5705 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5706 Qclone_number. Remove external declaration of Qdelete_window.
5707 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5708 code.
5709 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5710 Run Qbuffer_list_update_hook if allowed.
5711 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5712 buffer list implementation.
5713 (other_buffer_safely): New function.
5714 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5715 calls to replace_buffer_in_windows and
5716 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5717 if allowed.
5718 (record_buffer): Inhibit quitting and rewrite using quittable
5719 functions. Run Qbuffer_list_update_hook if allowed.
5720 (Frecord_buffer, Funrecord_buffer): New functions.
5721 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5722 Move switch-to-buffer to window.el.
5723 (bury-buffer): Move to window.el.
5724 (Vbuffer_list_update_hook): New variable.
5725
5726 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5727 section.
5728
5729 * window.h (resize_frame_windows): Move up in code.
5730 (Fwindow_frame): Remove EXFUN.
5731 (replace_buffer_in_all_windows): Remove prototype.
5732 (replace_buffer_in_windows_safely): Add prototype.
5733
5734 * window.c: Declare Qdelete_window static again. Move down
5735 declaration of select_count.
5736 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5737 (Fother_window): Move to window.el.
5738 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5739 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5740 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5741 window.el.
5742 (replace_buffer_in_windows): Implement by calling
5743 Qreplace_buffer_in_windows.
5744 (replace_buffer_in_all_windows): Remove with some functionality
5745 moved into replace_buffer_in_windows_safely.
5746 (replace_buffer_in_windows_safely): New function.
5747 (select_window_norecord, select_frame_norecord): Move in front
5748 of run_window_configuration_change_hook. Remove now obsolete
5749 declarations.
5750 (Fset_window_buffer): Rewrite doc-string.
5751 Call Qrecord_window_buffer.
5752 (keys_of_window): Move binding for other-window to window.el.
5753
57542011-06-11 Chong Yidong <cyd@stupidchicken.com>
5755
5756 * dispextern.h (struct image): Replace data member, whose int_val
5757 and ptr_val fields were not used by anything, with a single
5758 lisp_val object.
5759
5760 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5761 (gif_clear_image, gif_load, imagemagick_load_image)
5762 (gs_clear_image, gs_load): Callers changed.
5763
57642011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5765
5766 * buffer.h: Include <time.h>, for time_t.
5767 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5768
5769 Fix minor problems found by static checking.
5770
5771 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5772
5773 Make identifiers static if they are not used in other modules.
5774 * data.c (Qcompiled_function, Qframe, Qvector):
5775 * image.c (QimageMagick, Qsvg):
5776 * minibuf.c (Qmetadata):
5777 * window.c (resize_window_check, resize_root_window): Now static.
5778 * window.h (resize_window_check, resize_root_window): Remove decls.
5779
5780 * window.c (window_deletion_count, delete_deletable_window):
5781 Remove; unused.
5782 (window_body_lines): Now static.
5783 (Fdelete_other_windows_internal): Mark vars as initialized.
5784 Make sure 'resize_failed' is initialized.
5785 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5786 (resize_window_apply): Remove unused local.
5787 * window.h (delete_deletable_window): Remove decl.
5788
5789 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5790 (imagemagick_load_image): Fix pointer signedness problem by changing
5791 last arg from unsigned char * to char *. All uses changed.
5792 Also, fix a local for similar reasons.
5793 Remove unused locals. Remove locals to avoid shadowing.
5794 (fn_rsvg_handle_free): Remove; unused.
5795 (svg_load, svg_load_image): Fix pointer signedness problem.
5796 (imagemagick_load_image): Don't use garbage pointer image_wand.
5797
5798 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5799
58002011-06-10 Chong Yidong <cyd@stupidchicken.com>
5801
5802 * image.c (gif_load): Fix omitted cast error introduced by
5803 2011-06-06 change.
5804
58052011-06-10 Martin Rudalics <rudalics@gmx.at>
5806
5807 * window.h (resize_proportionally, orig_total_lines)
5808 (orig_top_line): Remove from window structure.
5809 (set_window_height, set_window_width, change_window_heights)
5810 (Fdelete_window): Remove prototypes.
5811 (resize_frame_windows): Remove duplicate declaration.
5812
58132011-06-10 Eli Zaretskii <eliz@gnu.org>
5814
5815 * window.h (resize_frame_windows, resize_window_check)
5816 (delete_deletable_window, resize_root_window)
5817 (resize_frame_windows): Declare prototypes.
5818
5819 * window.c (resize_window_apply): Make definition be "static" to
5820 match the prototype.
5821
58222011-06-10 Martin Rudalics <rudalics@gmx.at>
5823
5824 * window.c: Remove declarations of Qwindow_size_fixed,
5825 window_min_size_1, window_min_size_2, window_min_size,
5826 size_window, window_fixed_size_p, enlarge_window, delete_window.
5827 Remove static from declaration of Qdelete_window, it's
5828 temporarily needed by Fbury_buffer.
5829 (replace_window): Don't assign orig_top_line and
5830 orig_total_lines.
5831 (Fdelete_window, delete_window): Remove. Window deletion is
5832 handled by window.el.
5833 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5834 Replace Fdelete_window calls with calls to Qdelete_window.
5835 (Fdelete_other_windows): Remove. Deleting other windows is
5836 handled by window.el.
5837 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5838 handled in window.el.
5839 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5840 Window minimum sizes are handled in window.el.
5841 (shrink_windows, size_window, set_window_height)
5842 (set_window_width, change_window_heights, window_height)
5843 (window_width, CURBEG, CURSIZE, enlarge_window)
5844 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5845 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5846 handled in window.el.
5847 (make_dummy_parent): Rename to make_parent_window and give it a
5848 second argument horflag.
5849 (make_window): Don't set resize_proportionally any more.
5850 (Fsplit_window): Remove. Windows are split in window.el.
5851 (save_restore_action, save_restore_orig_size)
5852 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5853 Resize mini windows in window.el.
5854 (grow_mini_window, shrink_mini_window): Implement by calling
5855 Qresize_root_window_vertically, resize_window_check and
5856 resize_window_apply.
5857 (saved_window, Fset_window_configuration, save_window_save):
5858 Do not handle orig_top_line, orig_total_lines, and
5859 resize_proportionally.
5860 (window_min_height, window_min_width): Move to window.el.
5861 (keys_of_window): Move bindings for delete-other-windows,
5862 split-window, delete-window and enlarge-window to window.el.
5863
5864 * buffer.c: Temporarily extern Qdelete_window.
5865 (Fbury_buffer): Temporarily call Qdelete_window instead of
5866 Fdelete_window (Fbury_buffer will move to window.el soon).
5867
5868 * frame.c (set_menu_bar_lines_1): Remove code handling
5869 orig_top_line and orig_total_lines.
5870
5871 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5872 set_window_height but set heights directly.
5873 (change_frame_size_1): Use resize_frame_windows.
5874
5875 * xdisp.c (init_xdisp): Don't use set_window_height but set
5876 heights directly.
5877
5878 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5879 Use resize_frame_windows instead of change_window_heights and run
5880 run_window_configuration_change_hook.
5881
5882 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5883 instead of change_window_heights and run
5884 run_window_configuration_change_hook.
5885
58862011-06-09 Martin Rudalics <rudalics@gmx.at>
5887
5888 * window.c (replace_window): Rename second argument REPLACEMENT to
5889 NEW. New third argument SETFLAG. Rewrite.
5890 (delete_window, make_dummy_parent): Call replace_window with
5891 third argument 1.
5892 (window_list_1): Move down in code.
5893 (run_window_configuration_change_hook): Move set_buffer part
5894 before select_frame_norecord part in order to unwind correctly.
5895 Rename count1 to count.
5896 (recombine_windows, delete_deletable_window, resize_root_window)
5897 (Fdelete_other_windows_internal)
5898 (Frun_window_configuration_change_hook, make_parent_window)
5899 (resize_window_check, resize_window_apply, Fresize_window_apply)
5900 (resize_frame_windows, Fsplit_window_internal)
5901 (Fdelete_window_internal, Fresize_mini_window_internal):
5902 New functions.
5903 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5904
59052011-06-08 Martin Rudalics <rudalics@gmx.at>
5906
5907 * window.h (window): Add some new members to window structure -
5908 normal_lines, normal_cols, new_total, new_normal, clone_number,
5909 splits, nest, prev_buffers, next_buffers.
5910 (WINDOW_TOTAL_SIZE): Move here from window.c.
5911 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5912
5913 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5914 Remove.
5915 (make_dummy_parent): Set new members of windows structure.
5916 (make_window): Move down in code. Handle new members of window
5917 structure.
5918 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5919 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5920 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5921 (Fset_window_prev_buffers, Fwindow_next_buffers)
5922 (Fset_window_next_buffers, Fset_window_clone_number):
5923 New functions.
5924 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5925 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5926 Doc-string fixes.
5927 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5928 Argument WINDOW can be now internal window too.
5929 (Fwindow_use_time): Move up in code.
5930 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5931 Rewrite doc-string.
5932 (Fset_window_configuration, saved_window)
5933 (Fcurrent_window_configuration, save_window_save): Handle new
5934 members of window structure.
5935 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5936 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5937 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5938 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5939 Qget_mru_window, Qresize_root_window,
5940 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5941 Qauto_buffer_name; staticpro them.
5942
59432011-06-07 Martin Rudalics <rudalics@gmx.at>
5944
5945 * window.c (Fwindow_total_size, Fwindow_left_column)
5946 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5947 (Fwindow_list_1): New functions.
5948 (window_box_text_cols): Replace with window_body_cols.
5949 (Fwindow_width, Fscroll_left, Fscroll_right):
5950 Use window_body_cols instead of window_box_text_cols.
5951 (delete_window, Fset_window_configuration):
5952 Call delete_all_subwindows with window as argument.
5953 (delete_all_subwindows): Take a window as argument and not a
5954 structure. Rewrite.
5955 (window_loop): Remove handling of GET_LRU_WINDOW and
5956 GET_LARGEST_WINDOW.
5957 (Fget_lru_window, Fget_largest_window): Move to window.el.
5958
5959 * window.h: Extern window_body_cols instead of
5960 window_box_text_cols. delete_all_subwindows now takes a
5961 Lisp_Object as argument.
5962
5963 * indent.c (compute_motion, Fcompute_motion):
5964 Use window_body_cols instead of window_box_text_cols.
5965
5966 * frame.c (delete_frame): Call delete_all_subwindows with root
5967 window as argument.
5968
59692011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5970
5971 * fns.c (Fputhash): Document return value.
5972
59732011-06-06 Chong Yidong <cyd@stupidchicken.com>
5974
5975 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5976
59772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5978
5979 Cons<->int and similar integer overflow fixes (Bug#8794).
5980
5981 Check for overflow when converting integer to cons and back.
5982 * charset.c (Fdefine_charset_internal, Fdecode_char):
5983 Use cons_to_unsigned to catch overflow.
5984 (Fencode_char): Use INTEGER_TO_CONS.
5985 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5986 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5987 * data.c (long_to_cons, cons_to_long): Remove.
5988 (cons_to_unsigned, cons_to_signed): New functions.
5989 These signal an error for invalid or out-of-range values.
5990 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5991 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5992 * font.c (Ffont_variation_glyphs):
5993 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5994 * lisp.h: Include <intprops.h>.
5995 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5996 (cons_to_signed, cons_to_unsigned): New decls.
5997 (long_to_cons, cons_to_long): Remove decls.
5998 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5999 (Fprimitive_undo): Use CONS_TO_INTEGER.
6000 * xfns.c (Fx_window_property): Likewise.
6001 * xselect.c: Include <limits.h>.
6002 (x_own_selection, selection_data_to_lisp_data):
6003 Use INTEGER_TO_CONS.
6004 (x_handle_selection_request, x_handle_selection_clear)
6005 (x_get_foreign_selection, Fx_disown_selection_internal)
6006 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6007 (lisp_data_to_selection_data): Use cons_to_unsigned.
6008 (x_fill_property_data): Use cons_to_signed.
6009 Report values out of range.
6010
6011 Check for buffer and string overflow more precisely.
6012 * buffer.h (BUF_BYTES_MAX): New macro.
6013 * lisp.h (STRING_BYTES_MAX): New macro.
6014 * alloc.c (Fmake_string):
6015 * character.c (string_escape_byte8):
6016 * coding.c (coding_alloc_by_realloc):
6017 * doprnt.c (doprnt):
6018 * editfns.c (Fformat):
6019 * eval.c (verror):
6020 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6021 since they may not be the same number.
6022 * editfns.c (Finsert_char):
6023 * fileio.c (Finsert_file_contents):
6024 Likewise for BUF_BYTES_MAX.
6025
6026 * image.c: Use ptrdiff_t, not int, for sizes.
6027 (slurp_file): Switch from int to ptrdiff_t.
6028 All uses changed.
6029 (slurp_file): Check that file size fits in both size_t (for
6030 malloc) and ptrdiff_t (for sanity and safety).
6031
6032 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6033 if b->modtime has its maximal value.
6034
6035 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6036
6037 Don't assume time_t can fit into int.
6038 * buffer.h (struct buffer.modtime): Now time_t, not int.
6039 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6040 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6041
6042 Minor fixes for signed vs unsigned integers.
6043 * character.h (MAYBE_UNIFY_CHAR):
6044 * charset.c (maybe_unify_char):
6045 * keyboard.c (read_char, reorder_modifiers):
6046 XINT -> XFASTINT, since the integer must be nonnegative.
6047 * ftfont.c (ftfont_spec_pattern):
6048 * keymap.c (access_keymap, silly_event_symbol_error):
6049 XUINT -> XFASTINT, since the integer must be nonnegative.
6050 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6051 since it makes no difference and we prefer signed.
6052 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6053 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6054 nonnegative.
6055
60562011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6057
6058 * window.h (Fwindow_frame): Declare.
6059
60602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6061
6062 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6063 (SPARE_MEMORY): Always define.
6064 (LARGE_REQUEST): Remove.
6065 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6066
60672011-06-06 Martin Rudalics <rudalics@gmx.at>
6068
6069 * lisp.h: Move EXFUNS for Fframe_root_window,
6070 Fframe_first_window and Fset_frame_selected_window to window.h.
6071
6072 * window.h: Move EXFUNS for Fframe_root_window,
6073 Fframe_first_window and Fset_frame_selected_window here from
6074 lisp.h.
6075
6076 * frame.c (Fwindow_frame, Fframe_first_window)
6077 (Fframe_root_window, Fframe_selected_window)
6078 (Fset_frame_selected_window): Move to window.c.
6079 (Factive_minibuffer_window): Move to minibuf.c.
6080 (Fother_visible_frames_p): New function.
6081
6082 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6083
6084 * window.c (decode_window, decode_any_window): Move up in code.
6085 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6086 (inhibit_frame_unsplittable): Remove unused variable.
6087 (Fwindow_buffer): Move up and rewrite doc-string.
6088 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6089 (Fwindow_prev): New functions.
6090 (Fwindow_frame): Move here from frame.c. Accept any window as
6091 argument.
6092 (Fframe_root_window, Fframe_first_window)
6093 (Fframe_selected_window): Move here from frame.c. Accept frame
6094 or arbitrary window as argument. Update doc-strings.
6095 (Fminibuffer_window): Move up in code.
6096 (Fwindow_minibuffer_p): Move up in code and simplify.
6097 (Fset_frame_selected_window): Move here from frame.c.
6098 Marginal rewrite.
6099 (Fselected_window, select_window, Fselect_window): Move up in
6100 code. Minor doc-string fixes.
6101
61022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6103
6104 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6105 Do not assume that spare memory exists; that assumption is valid
6106 only if SYSTEM_MALLOC.
6107 (LARGE_REQUEST): New macro, so that the issue of large requests
6108 is separated from the issue of spare memory.
6109
61102011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6111
6112 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6113 format. (Bug#8806)
6114
6115 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6116
6117 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6118 before statements.
6119
61202011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6121
6122 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6123
6124 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6125
6126 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6127 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6128
61292011-06-05 Juanma Barranquero <lekktu@gmail.com>
6130
6131 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6132
61332011-06-04 Chong Yidong <cyd@stupidchicken.com>
6134
6135 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6136 (x_clipboard_manager_save): Add return value.
6137 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6138 New error handlers.
6139 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6140 Obey Vx_select_enable_clipboard_manager. Catch errors in
6141 x_clipboard_manager_save (Bug#8779).
6142 (Vx_select_enable_clipboard_manager): New variable.
6143 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6144
61452011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6146
6147 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6148
61492011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6150
6151 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6152 in the current matrix if keep_current_p is non-zero.
6153
61542011-06-04 Eli Zaretskii <eliz@gnu.org>
6155
6156 * bidi.c (bidi_level_of_next_char): Fix last change.
6157
61582011-06-03 Eli Zaretskii <eliz@gnu.org>
6159
6160 Support bidi reordering of text covered by display properties.
6161
6162 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6163 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6164 (bidi_cache_search, bidi_cache_iterator_state)
6165 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6166 (bidi_level_of_next_char, bidi_move_to_visually_next):
6167 Support character positions inside a run of characters covered by a
6168 display string.
6169 (bidi_paragraph_init, bidi_resolve_explicit_1)
6170 (bidi_level_of_next_char): Call bidi_fetch_char and
6171 bidi_fetch_char_advance instead of FETCH_CHAR and
6172 FETCH_CHAR_ADVANCE.
6173 (bidi_init_it): Initialize new members.
6174 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6175 definitions.
6176 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6177 instead of using explicit *_CHAR codes.
6178 (bidi_resolve_explicit, bidi_resolve_weak):
6179 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6180 bidirectional text is supported only in multibyte buffers.
6181 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6182 it to initialize the frame_window_p member of struct bidi_it.
6183 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6184 (bidi_resolve_explicit, bidi_resolve_weak)
6185 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6186 bidi_it->nchars is non-positive.
6187 (bidi_level_of_next_char): Don't try to lookup the cache for the
6188 next/previous character if nothing is cached there yet, or if we
6189 were just reseat()'ed to a new position.
6190
6191 * xdisp.c (set_cursor_from_row): Set start and stop points
6192 according to the row's direction when priming the loop that looks
6193 for the glyph on which to display cursor.
6194 (single_display_spec_intangible_p): Function deleted.
6195 (display_prop_intangible_p): Reimplement to call
6196 handle_display_spec instead of single_display_spec_intangible_p.
6197 Accept 3 additional arguments needed by handle_display_spec.
6198 This fixes incorrect cursor motion across display property with complex
6199 values: lists, `(when COND...)' forms, etc.
6200 (single_display_spec_string_p): Support property values that are
6201 lists with the argument STRING its top-level element.
6202 (display_prop_string_p): Fix the condition for processing a
6203 property that is a list to be consistent with handle_display_spec.
6204 (handle_display_spec): New function, refactored from the
6205 last portion of handle_display_prop.
6206 (compute_display_string_pos): Accept additional argument
6207 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6208 value of a `display' property is a "replacing spec".
6209 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6210 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6211 the display property, but just return a value indicating whether
6212 the display property will replace the characters it covers.
6213 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6214 frame_window_p members of struct bidi_it.
6215 (compute_display_string_pos, compute_display_string_end):
6216 New functions.
6217 (push_it): Accept second argument POSITION, where pop_it should
6218 jump to continue iteration.
6219 (reseat_1): Initialize bidi_it.disp_pos.
6220
6221 * keyboard.c (adjust_point_for_property): Adjust the call to
6222 display_prop_intangible_p to its new signature.
6223
6224 * dispextern.h (struct bidi_it): New member frame_window_p.
6225 (bidi_init_it): Update prototypes.
6226 (display_prop_intangible_p): Update prototype.
6227 (compute_display_string_pos, compute_display_string_end):
6228 Declare prototypes.
6229 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6230 EMACS_INT.
6231
62322011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6233
6234 Malloc failure behavior now depends on size of allocation.
6235 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6236 * lisp.h: Change signatures accordingly.
6237 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6238 All callers changed. (Bug#8762)
6239
6240 * gnutls.c: Use Emacs's memory allocators.
6241 Without this change, the gnutls library would invoke malloc etc.
6242 directly, which causes problems on non-SYNC_INPUT hosts, and which
6243 runs afoul of improving memory_full behavior. (Bug#8761)
6244 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6245 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6246 xfree instead of the default malloc, realloc, free.
6247 (Fgnutls_boot): No need to check for memory allocation failure,
6248 since xmalloc does that for us.
6249
6250 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6251 * category.c (hash_get_category_set):
6252 * ccl.c (ccl_driver):
6253 * charset.c (Fdefine_charset_internal):
6254 * charset.h (struct charset.hash_index):
6255 * composite.c (get_composition_id, gstring_lookup_cache)
6256 (composition_gstring_put_cache):
6257 * composite.h (struct composition.hash_index):
6258 * dispextern.h (struct image.hash):
6259 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6260 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6261 (hashfn_equal, hashfn_user_defined, make_hash_table)
6262 (maybe_resize_hash_table, hash_lookup, hash_put)
6263 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6264 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6265 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6266 * image.c (make_image, search_image_cache, lookup_image)
6267 (xpm_put_color_table_h):
6268 * lisp.h (struct Lisp_Hash_Table):
6269 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6270 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6271 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6272 * alloc.c (allocate_vectorlike):
6273 Check for overflow in vector size calculations.
6274 * ccl.c (ccl_driver):
6275 Check for overflow when converting EMACS_INT to int.
6276 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6277 need to be updated by these changes.
6278 * fns.c (make_hash_table, maybe_resize_hash_table):
6279 Check for integer overflow with large hash tables.
6280 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6281 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6282 (SXHASH_REDUCE): New macro.
6283 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6284 Use it instead of discarding useful hash info with large hash values.
6285 (sxhash_float): New function.
6286 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6287 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6288 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6289 Rewrite to use FIXNUM_BITS, as this simplifies things.
6290 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6291 Adjust signatures to match updated version of code.
6292 (consing_since_gc): Now EMACS_INT, since a single hash table can
6293 use more than INT_MAX bytes.
6294
62952011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6296
6297 Make it possible to build with GCC-4.6+ -O2 -flto.
6298
6299 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6300
63012011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6302
6303 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6304 Call minibuffer-inactive-mode.
6305
63062011-05-31 Juanma Barranquero <lekktu@gmail.com>
6307
6308 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6309 Update dependencies.
6310
63112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6312
6313 * data.c (init_data): Remove code for UTS, this system is not
6314 supported anymore.
6315
63162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6317
6318 Don't force ./temacs to start in terminal mode.
6319
6320 * frame.c (make_initial_frame): Initialize faces in all cases, not
6321 only when CANNOT_DUMP is defined.
6322 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6323
63242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6325
6326 * dispnew.c (add_window_display_history): Use const for the string
6327 pointer. Remove declaration, not needed.
6328
63292011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6330
6331 Use 'inline', not 'INLINE'.
6332 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6333 * alloc.c, fontset.c (INLINE): Remove.
6334 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6335 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6336 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6337 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6338 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6339
63402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6341
6342 Make it possible to run ./temacs.
6343
6344 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6345 syms_of_callproc does the same thing. Remove test for
6346 "initialized", do it in the caller.
6347 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6348
63492011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6350
6351 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6352 (read_minibuf): Use get_minibuffer.
6353 (syms_of_minibuf): Use DEFSYM.
6354 (Qmetadata): New var.
6355 * data.c (Qbuffer): Don't make it static.
6356 (syms_of_data): Use DEFSYM.
6357
63582011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6359
6360 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6361 (CCL_CODE_MIN): New macro.
6362
63632011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6364
6365 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6366
6367 * eval.c (Qdebug): Now static.
6368 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6369 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6370 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6371
63722011-05-29 Chong Yidong <cyd@stupidchicken.com>
6373
6374 * image.c: Various fixes to ImageMagick code comments.
6375 (Fimagemagick_types): Doc fix.
6376
63772011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6378
6379 Minor fixes prompted by GCC 4.6.0 warnings.
6380
6381 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6382
6383 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6384 (x_clipboard_manager_save_all): Move extern decl to ...
6385 * xterm.h: ... here, so that it can be checked for consistency.
6386
63872011-05-29 Chong Yidong <cyd@stupidchicken.com>
6388
6389 * xselect.c (x_clipboard_manager_save_frame)
6390 (x_clipboard_manager_save_all): New functions.
6391 (Fx_clipboard_manager_save): Lisp function deleted.
6392
6393 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6394 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6395
6396 * xterm.h: Update prototype.
6397
63982011-05-28 William Xu <william.xwl@gmail.com>
6399
6400 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6401 exiting (Bug#8239).
6402
64032011-05-28 Jim Meyering <meyering@redhat.com>
6404
6405 Avoid a sign-extension bug in crypto_hash_function.
6406 * fns.c (to_uchar): Define.
6407 (crypto_hash_function): Use it to convert some newly-signed
6408 variables to unsigned, to avoid sign-extension bugs. For example,
6409 without this change, (md5 "truc") would evaluate to
6410 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6411 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6412 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6413
64142011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6415
6416 Integer overflow fixes.
6417
6418 * dbusbind.c: Serial number integer overflow fixes.
6419 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6420 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6421 to hold a serial number that is too large for a fixnum.
6422 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6423 Check for serial numbers out of range. Decode any serial number
6424 that was so large that it became a float. (Bug#8722)
6425
6426 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6427 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6428 Use XFASTINT rather than XUINT when numbers are nonnegative.
6429 (xd_append_arg, Fdbus_method_return_internal):
6430 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6431 arguments, check that Lisp number is nonnegative, rather than
6432 silently wrapping negative numbers around. (Bug#8722)
6433 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6434 (Bug#8722)
6435
6436 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6437
6438 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6439
6440 ccl: Add integer overflow checks.
6441 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6442 (IN_INT_RANGE): New macros.
6443 (ccl_driver): Use them to check for integer overflow when
6444 decoding a CCL program. Many of the new checks are whether XINT (x)
6445 fits in int; it doesn't always, on 64-bit hosts. The new version
6446 doesn't catch all possible integer overflows, but it's an
6447 improvement. (Bug#8719)
6448
6449 * alloc.c (make_event_array): Use XINT, not XUINT.
6450 There's no need for unsigned here.
6451
6452 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6453 This follows up to the 2011-05-06 change that substituted uintptr_t
6454 for EMACS_INT. This case wasn't caught back then.
6455
6456 Rework Fformat to avoid integer overflow issues.
6457 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6458 now (part of C89). Include <verify.h>.
6459 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6460 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6461 (Fformat): Avoid the prepass trying to compute sizes; it was only
6462 approximate and thus did not catch overflow reliably. Instead, walk
6463 through the format just once, formatting and computing sizes as we go,
6464 checking for integer overflow at every step, and allocating a larger
6465 buffer as needed. Keep track separately whether the format is
6466 multibyte. Keep only the most-recently calculated precision, rather
6467 than them all. Record whether each argument has been converted to
6468 string. Use EMACS_INT, not int, for byte and char and arg counts.
6469 Support field widths and precisions larger than INT_MAX. Avoid
6470 sprintf's undefined behavior with conversion specifications such as %#d
6471 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6472 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6473 formatting out-of-range floating point numbers with int
6474 formats. (Bug#8668)
6475
6476 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6477
6478 * data.c: Avoid integer truncation in expressions involving floats.
6479 * data.c: Include <intprops.h>.
6480 (arith_driver): When there's an integer overflow in an expression
6481 involving floating point, convert the integers to floating point
6482 so that the resulting value does not suffer from catastrophic
6483 integer truncation. For example, on a 64-bit host (* 4
6484 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6485 Do not rely on undefined behavior after integer overflow.
6486
6487 merge count_size_as_multibyte, parse_str_to_multibyte
6488 * character.c, character.h (count_size_as_multibyte):
6489 Rename from parse_str_to_multibyte; all uses changed.
6490 Check for integer overflow.
6491 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6492 since it's now a duplicate of the other. This is more of
6493 a character than a buffer op, so better that it's in character.c.
6494 * fns.c, print.c: Adjust to above changes.
6495
64962011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6497
6498 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6499
65002011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6501
6502 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6503 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6504 (x_clipboard_manager_save): Now static.
6505 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6506
6507 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6508 (crypto_hash_function): Now static.
6509 Fix pointer signedness problems. Avoid unnecessary initializations.
6510
65112011-05-27 Chong Yidong <cyd@stupidchicken.com>
6512
6513 * termhooks.h (Vselection_alist): Make it terminal-local.
6514
6515 * terminal.c (create_terminal): Initialize it.
6516
6517 * xselect.c: Support for clipboard managers.
6518 (Vselection_alist): Move to termhooks.h as terminal-local var.
6519 (LOCAL_SELECTION): New macro.
6520 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6521 (symbol_to_x_atom): Remove gratuitous arg.
6522 (x_handle_selection_request, lisp_data_to_selection_data)
6523 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6524 (x_own_selection, x_get_local_selection, x_convert_selection):
6525 New arg, specifying work frame. Use terminal-local Vselection_alist.
6526 (some_frame_on_display): Delete unused function.
6527 (Fx_own_selection_internal, Fx_get_selection_internal)
6528 (Fx_disown_selection_internal, Fx_selection_owner_p)
6529 (Fx_selection_exists_p): New optional frame arg.
6530 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6531 (x_handle_selection_clear): Don't treat other terminals with the
6532 same keyboard specially. Use the terminal-local Vselection_alist.
6533 (x_clear_frame_selections): Use Frun_hook_with_args.
6534
6535 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6536
6537 * xterm.h: Add support for those atoms.
6538
65392011-05-26 Chong Yidong <cyd@stupidchicken.com>
6540
6541 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6542 (converted_selections, conversion_fail_tag): New global variables.
6543 (x_selection_request_lisp_error): Free the above.
6544 (x_get_local_selection): Remove unnecessary code.
6545 (x_reply_selection_request): Args changed; handle arbitrary array
6546 of converted selections stored in converted_selections.
6547 Separate the XChangeProperty and SelectionNotify steps.
6548 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6549 (x_convert_selection): New function.
6550 (x_handle_selection_event): Simplify.
6551 (x_get_foreign_selection): Don't ignore incoming requests while
6552 waiting for an answer; this will fail when we implement
6553 SAVE_TARGETS, and seems unnecessary anyway.
6554 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6555 (Vx_sent_selection_functions): Doc fix.
6556
65572011-05-26 Leo Liu <sdl.web@gmail.com>
6558
6559 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6560
65612011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6562
6563 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6564
6565 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6566 for fringe update if it has periodic bitmap.
6567 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6568 and fringe_bitmap_periodic_p.
6569
6570 * fringe.c (get_fringe_bitmap_data): New function.
6571 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6572 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6573 row. Mark glyph row for fringe update if periodicity changed.
6574
6575 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6576 for fringe update unless it has periodic bitmap.
6577
65782011-05-25 Kenichi Handa <handa@m17n.org>
6579
6580 * xdisp.c (get_next_display_element): Set correct it->face_id for
6581 a static composition.
6582
65832011-05-24 Leo Liu <sdl.web@gmail.com>
6584
6585 * deps.mk (fns.o):
6586 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6587
6588 * fns.c (crypto_hash_function, Fsha1): New function.
6589 (Fmd5): Use crypto_hash_function.
6590 (syms_of_fns): Add Ssha1.
6591
65922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6593
6594 * gnutls.c: Remove unused macros.
6595 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6596 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6597 Remove macros that are defined and never used.
6598 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6599
66002011-05-22 Chong Yidong <cyd@stupidchicken.com>
6601
6602 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6603 (Fx_get_selection_internal): Minor cleanup.
6604 (Fx_own_selection_internal): Rename arguments for consistency with
6605 select.el.
6606
66072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6608
6609 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6610
66112011-05-22 Chong Yidong <cyd@stupidchicken.com>
6612
6613 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6614
66152011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6616
6617 * dispnew.c (scrolling_window): Don't exclude the case that the
6618 last enabled row in the desired matrix touches the bottom boundary.
6619
66202011-05-21 Glenn Morris <rgm@gnu.org>
6621
6622 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6623 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6624 and add some more files.
6625
66262011-05-20 Eli Zaretskii <eliz@gnu.org>
6627
6628 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6629 report_file_error introduced by the change from 2011-05-07.
6630
66312011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6632
6633 * systime.h (Time): Define only if emacs is defined.
6634 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6635 where the include path doesn't have X11/X.h by default. See
6636 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6637
66382011-05-20 Kenichi Handa <handa@m17n.org>
6639
6640 * composite.c (find_automatic_composition): Fix previous change.
6641
66422011-05-20 Glenn Morris <rgm@gnu.org>
6643
6644 * lisp.mk: New file, split from Makefile.in.
6645 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6646 (shortlisp): Remove.
6647 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6648
66492011-05-19 Glenn Morris <rgm@gnu.org>
6650
6651 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6652 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6653 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6654 (lisp): Set the order to that of loadup.el.
6655 (shortlisp): Make it a copy of $lisp.
6656 (SOME_MACHINE_LISP): Remove.
6657 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6658 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6659
66602011-05-18 Kenichi Handa <handa@m17n.org>
6661
6662 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6663 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6664 (find_automatic_composition): Mostly rewrite for efficiency.
6665
66662011-05-18 Juanma Barranquero <lekktu@gmail.com>
6667
6668 * makefile.w32-in: Update dependencies.
6669
66702011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6671
6672 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6673 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6674
66752011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6676
6677 Fix some integer overflow issues, such as string length overflow.
6678
6679 * insdel.c (count_size_as_multibyte): Check for string overflow.
6680
6681 * character.c (lisp_string_width): Check for string overflow.
6682 Use EMACS_INT, not int, for string indexes and lengths; in
6683 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6684 the resulting string length overflows an EMACS_INT; instead,
6685 report a string overflow if no precision given. When checking for
6686 precision exhaustion, use a check that cannot possibly have
6687 integer overflow. (Bug#8675)
6688 * character.h (lisp_string_width): Adjust to new signature.
6689
6690 * alloc.c (string_overflow): New function.
6691 (Fmake_string): Use it. This doesn't change behavior, but saves
6692 a few bytes and will simplify future changes.
6693 * character.c (string_escape_byte8): Likewise.
6694 * lisp.h (string_overflow): New decl.
6695
6696 Fixups, following up to the user-interface timestamp change.
6697 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6698 for UI timestamps, instead of unsigned long.
6699 * msdos.c (mouse_get_pos): Likewise.
6700 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6701 * w32gui.h (Time): Define by including "systime.h" rather than by
6702 declaring it ourselves. (Bug#8664)
6703
6704 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6705 * image.c (clear_image_cache): Likewise.
6706
6707 * term.c (term_mouse_position): Don't assume time_t wraparound.
6708
6709 Be more systematic about user-interface timestamps.
6710 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6711 and sometimes 'EMACS_UINT', to represent these timestamps.
6712 This change causes it to use 'Time' uniformly, as that's what X uses.
6713 This makes the code easier to follow, and makes it easier to catch
6714 integer overflow bugs such as Bug#8664.
6715 * frame.c (Fmouse_position, Fmouse_pixel_position):
6716 Use Time, not unsigned long, for user-interface timestamps.
6717 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6718 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6719 * keyboard.h (last_event_timestamp): Likewise.
6720 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6721 * menu.h (xmenu_show): Likewise.
6722 * term.c (term_mouse_position): Likewise.
6723 * termhooks.h (struct input_event.timestamp): Likewise.
6724 (struct terminal.mouse_position_hook): Likewise.
6725 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6726 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6727 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6728 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6729 what it was before.
6730 * menu.h, termhooks.h: Include "systime.h", for Time.
6731
6732 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6733 Don't assume that the difference between two unsigned long values
6734 can fit into an integer. At this point, we know button_down_time
6735 <= event->timestamp, so the difference must be nonnegative, so
6736 there's no need to cast the result if double-click-time is
6737 nonnegative, as it should be; check that it's nonnegative, just in
6738 case. This bug is triggered when events are more than 2**31 ms
6739 apart (about 25 days). (Bug#8664)
6740
6741 * xselect.c (last_event_timestamp): Remove duplicate decl.
6742 (x_own_selection): Remove needless cast to unsigned long.
6743
6744 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6745 that always fit in int. Use a sentinel instead of a counter, to
6746 avoid a temp and to allay GCC's concerns about possible int overflow.
6747 * frame.h (struct frame): Use int for menu_bar_items_used
6748 instead of EMACS_INT, since it always fits in int.
6749
6750 * menu.c (grow_menu_items): Check for int overflow.
6751
6752 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6753
6754 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6755 Before, the code was not consistent. These values cannot exceed
6756 2**31 - 1 so there's no need to make them unsigned.
6757 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6758 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6759 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6760 as modifiers.
6761 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6762
6763 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6764 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6765 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6766 presumably because the widths might not match.
6767
6768 * window.c (size_window): Avoid needless test at loop start.
6769
67702011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6771
6772 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6773
67742011-05-12 Drew Adams <drew.adams@oracle.com>
6775
6776 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6777
67782011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6779
6780 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6781 `width' to `bar_area_x' and `bar_area_width', respectively.
6782 (x_scroll_run): Take account of fringe background extension.
6783
6784 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6785 Rename local vars `left' and `width' to `bar_area_x' and
6786 `bar_area_width', respectively.
6787 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6788 background extension.
6789
67902011-05-10 Jim Meyering <meyering@redhat.com>
6791
6792 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6793
67942011-05-10 Juanma Barranquero <lekktu@gmail.com>
6795
6796 * image.c (Finit_image_library): Return t for built-in image types,
6797 like pbm and xbm. (Bug#8640)
6798
67992011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6800
6801 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6802
68032011-05-07 Eli Zaretskii <eliz@gnu.org>
6804
6805 * w32console.c (Fset_screen_color): Doc fix.
6806 (Fget_screen_color): New function.
6807 (syms_of_ntterm): Defsubr it.
6808
6809 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6810 unlink the temporary file if Fcall_process didn't create it in the
6811 first place.
6812 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6813 child process will be redirected to a file specified with `:file'.
6814 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6815 cue to call_process_cleanup not to close that handle.
6816
68172011-05-07 Ben Key <bkey76@gmail.com>
6818
6819 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6820 one of two shell specific rules, either bootstrap-temacs-CMD or
6821 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6822 to the previous implementation of the bootstrap-temacs rule.
6823 The bootstrap-temacs-CMD rule is similar to the previous
6824 implementation of the bootstrap-temacs rule except that it
6825 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6826 variable.
6827
6828 These changes, along with some changes to nt/configure.bat,
6829 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6830 earlier fix to add support for --cflags and --ldflags options
6831 that include quotes so that it works whether make uses cmd or
6832 sh as the shell.
6833
68342011-05-06 Michael Albinus <michael.albinus@gmx.de>
6835
6836 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6837 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6838 is a constant.
6839 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6840 a string. Handle both cases.
6841 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6842 (Fdbus_register_method): Use Qinvalid_function.
6843
68442011-05-06 Juanma Barranquero <lekktu@gmail.com>
6845
6846 * makefile.w32-in: Update dependencies.
6847 (LISP_H): Add inttypes.h and stdin.h.
6848 (PROCESS_H): Add unistd.h.
6849
68502011-05-06 Eli Zaretskii <eliz@gnu.org>
6851
6852 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6853 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6854
68552011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6856
6857 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6858
6859 * term.c (vfatal): Remove stray call to va_end.
6860 It's not needed and the C Standard doesn't allow it here anyway.
6861
6862 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6863 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6864
6865 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6866 bytes.
6867
6868 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6869
6870 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6871
6872 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6873
6874 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6875
6876 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6877
6878 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6879 * charset.c (Fdefine_charset_internal): Don't initialize
6880 charset.code_space[15]. The value was garbage, on hosts with
6881 32-bit int (Bug#8600).
6882
6883 * lread.c (read_integer): Be more consistent with string-to-number.
6884 Use string_to_number to do the actual conversion; this avoids
6885 rounding errors and fixes some other screwups. Without this fix,
6886 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6887 (digit_to_number): Move earlier, for benefit of read_integer.
6888 Return -1 if the digit is out of range for the base, -2 if it is
6889 not a digit in any supported base. (Bug#8602)
6890
6891 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6892
6893 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6894 to match comment at start of function. This also removes a
6895 GCC warning about overflow in a 32+64-bit port.
6896
6897 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6898
6899 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6900 Reported by Stefan Monnier in
6901 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6902 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6903 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6904
6905 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6906 (EMACS_UINTPTR): Likewise, with uintptr_t.
6907
6908 * lisp.h: Prefer 64-bit EMACS_INT if available.
6909 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6910 on 32-bit hosts that have 64-bit int, so that they can access
6911 large files.
6912 However, temporarily disable this change unless the temporary
6913 symbol WIDE_EMACS_INT is defined.
6914
6915 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6916
6917 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6918 This removes an assumption that EMACS_INT and long are the same
6919 width as pointers. The assumption is true for Emacs porting targets
6920 now, but we want to make other targets possible.
6921 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6922 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6923 In the rest of the code, change types of integers that hold casted
6924 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6925 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6926 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6927 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6928 No need to cast type when ORing.
6929 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6930 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6931 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6932 assume EMACS_INT is the same width as char *.
6933 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6934 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6935 Remove no-longer-needed casts.
6936 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6937 (xg_tool_bar_help_callback, xg_make_tool_item):
6938 Use EMACS_INTPTR to hold an integer
6939 that will be cast to void *; this can avoid a GCC warning
6940 if EMACS_INT is not the same width as void *.
6941 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6942 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6943 (current_message_1, set_message_1):
6944 Use a local to convert to proper width without a cast.
6945 * xmenu.c (dialog_selection_callback): Likewise.
6946
6947 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6948 Also, don't assume VALBITS / RAND_BITS is less than 5,
6949 and don't rely on undefined behavior when shifting a 1 left into
6950 the sign bit.
6951 * lisp.h (get_random): Change signature to match.
6952
6953 * lread.c (hash_string): Use size_t, not int, for hash computation.
6954 Normally we prefer signed values; but hashing is special, because
6955 it's better to use unsigned division on hash table sizes so that
6956 the remainder is nonnegative. Also, size_t is the natural width
6957 for hashing into memory. The previous code used 'int', which doesn't
6958 retain enough info to hash well into very large tables.
6959 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6960
6961 * dbusbind.c: Don't possibly lose pointer info when converting.
6962 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6963 Use XPNTR rather than XHASH, so that the high-order bits of
6964 the pointer aren't lost when converting through void *.
6965
6966 * eval.c (Fautoload): Don't double-shift a pointer.
6967
6968 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6969
69702011-05-06 Juanma Barranquero <lekktu@gmail.com>
6971
6972 * gnutls.c (DEF_GNUTLS_FN):
6973 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6974
69752011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6976
6977 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6978 marker. (Bug#8610)
6979
69802011-05-05 Eli Zaretskii <eliz@gnu.org>
6981
6982 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6983 New version that can reserve upto 2GB of heap space.
6984
69852011-05-05 Chong Yidong <cyd@stupidchicken.com>
6986
6987 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6988
69892011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6990
6991 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6992 `gnutls_certificate_set_x509_key_file'.
6993
69942011-05-05 Juanma Barranquero <lekktu@gmail.com>
6995
6996 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6997 Update dependencies.
6998
69992011-05-04 Juanma Barranquero <lekktu@gmail.com>
7000
7001 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7002 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7003 Remove unused parameter `fildes'.
7004 * process.c (read_process_output, send_process): Don't pass it.
7005
70062011-05-04 Juanma Barranquero <lekktu@gmail.com>
7007
7008 Fix previous change: the library cache is defined in w32.c.
7009 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7010 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7011
70122011-05-04 Juanma Barranquero <lekktu@gmail.com>
7013
7014 Implement dynamic loading of GnuTLS on Windows.
7015
7016 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7017 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7018 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7019 Declare.
7020
7021 * gnutls.c (Qgnutls_dll): Define.
7022 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7023 (gnutls_*): Declare function pointers.
7024 (init_gnutls_functions): New function to initialize function pointers.
7025 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7026 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7027 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7028 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7029 (emacs_gnutls_write, emacs_gnutls_read)
7030 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7031 (Fgnutls_available_p): New function.
7032 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7033 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7034 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7035
7036 * image.c: Include w32.h.
7037 (Vimage_type_cache): Delete.
7038 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7039 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7040 (w32_delayed_load): Move to w32.c.
7041
7042 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7043
7044 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7045 (w32_delayed_load): Move from image.c. When loading a library, record
7046 its filename in the :loaded-from property of the library id.
7047 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7048 Initialize and staticpro them.
7049 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7050
7051 * process.c: Include lisp.h before w32.h, not after.
7052 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7053 instead of gnutls_record_check_pending.
7054
7055 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7056
70572011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7058
7059 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7060 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7061 as passed in.
7062
70632011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7064
7065 * xterm.c (x_set_frame_alpha): Do not set property on anything
7066 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7067
70682011-05-02 Juanma Barranquero <lekktu@gmail.com>
7069
7070 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7071
70722011-05-02 Juanma Barranquero <lekktu@gmail.com>
7073
7074 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7075 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7076 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7077 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7078 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7079 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7080 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7081 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7082 (Qgnutls_bootprop_callbacks_verify): Make static.
7083
70842011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7085
7086 * callproc.c: Indentation fixup.
7087
7088 * sysdep.c (wait_for_termination_1): Make static.
7089 (wait_for_termination, interruptible_wait_for_termination):
7090 Move after wait_for_termination_1.
7091
70922011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7093
7094 * sysdep.c (interruptible_wait_for_termination): New function
7095 which is like wait_for_termination, but allows keyboard
7096 interruptions.
7097
7098 * callproc.c (Fcall_process): Add (:file "file") as an option for
7099 the STDOUT buffer.
7100 (Fcall_process_region): Ditto.
7101
71022011-04-30 Eli Zaretskii <eliz@gnu.org>
7103
7104 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7105 rather than `XVECTOR (FOO)->size'.
7106
7107 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7108 inttypes.h, as a gnulib replacement is used if it not available in
7109 system headers.
7110
71112011-04-21 Eli Zaretskii <eliz@gnu.org>
7112
7113 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7114 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7115 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7116
7117 * coding.c (coding_alloc_by_realloc): Error out if destination
7118 will grow beyond MOST_POSITIVE_FIXNUM.
7119 (decode_coding_emacs_mule): Abort if there isn't enough place in
7120 charbuf for the composition carryover bytes. Reserve an extra
7121 space for up to 2 characters produced in a loop.
7122 (decode_coding_iso_2022): Abort if there isn't enough place in
7123 charbuf for the composition carryover bytes.
7124
71252011-04-21 Eli Zaretskii <eliz@gnu.org>
7126
7127 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7128 aborting when %lld or %lll format is passed.
7129 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7130 %llo or %llx format is passed. (Bug#8545)
7131
7132 * window.c (window_scroll_line_based): Use a marker instead of
7133 simple variables to record original value of point. (Bug#7952)
7134
7135 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7136 produced by %s or %c overflows available buffer space. (Bug#8545)
7137
71382011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7139
7140 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7141 (SIZE_MAX): Move defn after all includes, as they might #define it.
7142
71432011-04-28 Juanma Barranquero <lekktu@gmail.com>
7144
7145 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7146
71472011-04-28 Juanma Barranquero <lekktu@gmail.com>
7148
7149 * keyboard.c (Qdelayed_warnings_hook): Define.
7150 (command_loop_1): Run `delayed-warnings-hook'
7151 if Vdelayed_warnings_list is non-nil.
7152 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7153 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7154
71552011-04-28 Eli Zaretskii <eliz@gnu.org>
7156
7157 * doprnt.c (doprnt): Don't return value smaller than the buffer
7158 size if the message was truncated. (Bug#8545).
7159
71602011-04-28 Juanma Barranquero <lekktu@gmail.com>
7161
7162 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7163 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7164
71652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7166
7167 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7168
71692011-04-27 Juanma Barranquero <lekktu@gmail.com>
7170
7171 * makefile.w32-in: Update dependencies.
7172
71732011-04-27 Eli Zaretskii <eliz@gnu.org>
7174
7175 Improve `doprnt' and its usage. (Bug#8545)
7176 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7177 `format_end'. Remove support for %l as a conversion specifier.
7178 Don't use xrealloc. Improve diagnostics when the %l size modifier
7179 is used. Update the commentary.
7180
7181 * eval.c (verror): Simplify calculation of size_t.
7182
7183 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7184 messages.
7185
71862011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7187
7188 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7189 change.
7190
71912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7192
7193 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7194 This makes this file independent of the recent pseudovector change.
7195
71962011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7197
7198 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7199
7200 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7201 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7202 Remove unused local.
7203 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7204
7205 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7206 GCC 4.6.0 optimizes based on type-based alias analysis.
7207 For example, if b is of type struct buffer * and v of type struct
7208 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7209 != &v->size, and therefore "v->size = 1; b->size = 2; return
7210 v->size;" must therefore return 1. This assumption is incorrect
7211 for Emacs, since it type-puns struct Lisp_Vector * with many other
7212 types. To fix this problem, this patch adds a new type struct
7213 vectorlike_header that documents the constraints on layout of vectors
7214 and pseudovectors, and helps optimizing compilers not get fooled
7215 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7216 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7217 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7218 the size member.
7219 (XSETPVECTYPE): Rewrite in terms of new macro.
7220 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7221 This is a bit clearer, and further avoids the possibility of
7222 undesirable aliasing.
7223 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7224 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7225 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7226 since Lisp_Subr is a special case (no "next" field).
7227 (ASIZE): Now uses header.size rather than size.
7228 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7229 to avoid the hassle of writing XVECTOR (foo)->header.size.
7230 (struct vectorlike_header): New type.
7231 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7232 object, to help avoid aliasing.
7233 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7234 (SUBRP): Likewise, since Lisp_Subr is a special case.
7235 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7236 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7237 (struct Lisp_Hash_Table): Combine first two members into a single
7238 struct vectorlike_header member. All uses of "size" and "next" members
7239 changed to be "header.size" and "header.next".
7240 * buffer.h (struct buffer): Likewise.
7241 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7242 * frame.h (struct frame): Likewise.
7243 * process.h (struct Lisp_Process): Likewise.
7244 * termhooks.h (struct terminal): Likewise.
7245 * window.c (struct save_window_data, struct saved_window): Likewise.
7246 * window.h (struct window): Likewise.
7247 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7248 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7249 * buffer.c (init_buffer_once): Likewise.
7250 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7251 special case.
7252 * process.c (Fformat_network_address): Use local var for size,
7253 for brevity.
7254
7255 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7256
7257 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7258 * data.c (atof): Remove decl; no longer used or needed.
7259 (digit_to_number): Move to lread.c.
7260 (Fstring_to_number): Use new string_to_number function, to be
7261 consistent with how the Lisp reader treats infinities and NaNs.
7262 Do not assume that floating-point numbers represent EMACS_INT
7263 without losing information; this is not true on most 64-bit hosts.
7264 Avoid double-rounding errors, by insisting on integers when
7265 parsing non-base-10 numbers, as the documentation specifies.
7266 * lisp.h (string_to_number): New decl, replacing ...
7267 (isfloat_string): Remove.
7268 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7269 (read1): Do not accept +. and -. as integers; this
7270 appears to have been a coding error. Similarly, do not accept
7271 strings like +-1e0 as floating point numbers. Do not report
7272 overflow for integer overflows unless the base is not 10 which
7273 means we have no simple and reliable way to continue.
7274 Break out the floating-point parsing into a new
7275 function string_to_number, so that Fstring_to_number parses
7276 floating point numbers consistently with the Lisp reader.
7277 (digit_to_number): Move here from data.c. Make it static inline.
7278 (E_CHAR, EXP_INT): Remove, replacing with ...
7279 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7280 (string_to_number): New function, replacing isfloat_string.
7281 This function checks for valid syntax and produces the resulting
7282 Lisp float number too. Rework it so that string-to-number
7283 no longer mishandles examples like "1.0e+". Use strtoumax,
7284 so that overflow for non-base-10 numbers is reported only when
7285 there's no portable and simple way to convert to floating point.
7286
7287 * textprop.c (set_text_properties_1): Rewrite for clarity,
7288 and to avoid GCC warning about integer overflow.
7289
7290 * intervals.h (struct interval): Use EMACS_INT for members
7291 where EMACS_UINT might cause problems. See
7292 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7293 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7294 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7295 All uses changed.
7296 (offset_intervals): Tell GCC not to worry about length overflow
7297 when negating a negative length.
7298
7299 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7300 (overrun_check_free): Likewise.
7301
7302 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7303 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7304 word size.
7305
7306 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7307 (gnutls_make_error): Rename local to avoid shadowing.
7308 (gnutls_emacs_global_deinit): ifdef out; not used.
7309 (Fgnutls_boot): Use const for pointer to readonly storage.
7310 Comment out unused local. Fix pointer signedness problems.
7311
7312 * lread.c (openp): Don't stuff size_t into an 'int'.
7313 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7314 about possible signed overflow.
7315
7316 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7317 (GDK_KEY_g): Don't define if already defined.
7318 (xg_prepare_tooltip): Avoid pointer signedness problem.
7319 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7320
7321 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7322 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7323
7324 * xfns.c (Fx_window_property): Simplify a bit,
7325 to make a bit faster and to avoid GCC 4.6.0 warning.
7326 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7327
7328 * fns.c (internal_equal): Don't assume size_t fits in int.
7329
7330 * alloc.c (compact_small_strings): Tighten assertion a little.
7331
7332 Replace pEd with more-general pI, and fix some printf arg casts.
7333 * lisp.h (pI): New macro, generalizing old pEd macro to other
7334 conversion specifiers. For example, use "...%"pI"d..." rather
7335 than "...%"pEd"...".
7336 (pEd): Remove. All uses replaced with similar uses of pI.
7337 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7338 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7339 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7340 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7341 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7342 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7343 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7344 64-bit hosts.
7345 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7346 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7347 * print.c (safe_debug_print, print_object): Likewise.
7348 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7349 to int.
7350 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7351 avoiding the 0 flag, which is not portable.
7352 * process.c (Fmake_network_process): Use pI to avoid cast.
7353 * region-cache.c (pp_cache): Likewise.
7354 * xdisp.c (decode_mode_spec): Likewise.
7355 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7356 behavior on 64-bit hosts with printf arg.
7357 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7358 (x_stop_queuing_selection_requests): Likewise.
7359 (x_get_window_property): Don't truncate byte count to an 'int'
7360 when tracing.
7361
7362 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7363 here, since it parses constructs like leading '-' and spaces,
7364 which are not wanted; and it overflows with large numbers.
7365 Instead, simply match F[0-9]+, which is what is wanted anyway.
7366
7367 * alloc.c: Remove unportable assumptions about struct layout.
7368 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7369 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7370 (allocate_vectorlike, make_pure_vector): Use the new macros,
7371 plus offsetof, to remove unportable assumptions about struct layout.
7372 These assumptions hold on all porting targets that I know of, but
7373 they are not guaranteed, they're easy to remove, and removing them
7374 makes further changes easier.
7375
7376 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7377 This doesn't fix a bug but makes the code clearer.
7378 (string_overrun_cookie): Now const. Use initializers that
7379 don't formally overflow signed char, to avoid warnings.
7380 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7381 can cause Emacs to crash when string overrun checking is enabled.
7382 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7383 multiple of sizeof (EMACS_INT); it need not be, if
7384 alignof(EMACS_INT) < sizeof (EMACS_INT).
7385 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7386
73872011-04-26 Juanma Barranquero <lekktu@gmail.com>
7388
7389 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7390
73912011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7392
7393 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7394 supposed to be handshaking. (Bug#8556)
7395 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7396
73972011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7398
7399 * lisp.h (Qdebug): List symbol.
7400 * eval.c (Qdebug): Restore global linkage.
7401 * keyboard.c (debug-on-event): New variable.
7402 (handle_user_signal): Break into debugger when debug-on-event
7403 matches the current signal symbol.
7404
74052011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7406
7407 * alloc.c (check_sblock, check_string_bytes)
7408 (check_string_free_list): Convert to standard C.
7409
74102011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7411
7412 * w32.c (emacs_gnutls_push): Fix typo.
7413
74142011-04-25 Eli Zaretskii <eliz@gnu.org>
7415
7416 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7417 "cast to pointer from integer of different size".
7418
7419 Improve doprnt and its use in verror. (Bug#8545)
7420 * doprnt.c (doprnt): Document the set of format control sequences
7421 supported by the function. Use SAFE_ALLOCA instead of always
7422 using `alloca'.
7423
7424 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7425 is one byte too soon. Don't use xrealloc; instead xfree and
7426 xmalloc anew.
7427
74282011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7429
7430 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7431 callbacks stage.
7432
7433 * gnutls.c: Renamed global_initialized to
7434 gnutls_global_initialized. Added internals for the
7435 :verify-hostname-error, :verify-error, and :verify-flags
7436 parameters of `gnutls-boot' and documented those parameters in the
7437 docstring. Start callback support.
7438 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7439 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7440 on error. Return error code.
7441 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7442 (emacs_gnutls_read): Likewise.
7443 (Fgnutls_boot): Return handshake error code.
7444 (emacs_gnutls_handle_error): New function.
7445 (wsaerror_to_errno): Likewise.
7446
7447 * w32.h (emacs_gnutls_pull): Add prototype.
7448 (emacs_gnutls_push): Likewise.
7449
7450 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7451 (emacs_gnutls_push): Likewise.
7452
74532011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7454
7455 * process.c (wait_reading_process_output): Check if GnuTLS
7456 buffered some data internally if no FDs are set for TLS
7457 connections.
7458
7459 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7460 (LIBS): Link to USER_LIBS.
7461 ($(BLD)/gnutls.$(0)): New target.
7462
74632011-04-24 Eli Zaretskii <eliz@gnu.org>
7464
7465 * xdisp.c (handle_single_display_spec): Rename the
7466 display_replaced_before_p argument into display_replaced_p, to
7467 make it consistent with the commentary. Fix typos in the
7468 commentary.
7469
7470 * textprop.c (syms_of_textprop): Remove dead code.
7471 (copy_text_properties): Delete obsolete commentary about an
7472 interface that was deleted long ago. Fix typos in the description
7473 of arguments.
7474
7475 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7476 to changes in oldXMenu/XMenu.h from 2011-04-16.
7477 <menu_help_message, prev_menu_help_message>: Constify.
7478 (IT_menu_make_room): menu->help_text is now `const char **';
7479 adjust.
7480
7481 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7482 to changes in oldXMenu/XMenu.h from 2011-04-16.
7483 (struct XMenu): Declare `help_text' `const char **'.
7484
7485 * xfaces.c <Qunspecified>: Make extern again.
7486
7487 * syntax.c: Include sys/types.h before including regex.h, as
7488 required by Posix.
7489
7490 * doc.c (get_doc_string): Improve the format passed to `error'.
7491
7492 * doprnt.c (doprnt): Improve commentary.
7493
7494 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7495
7496 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7497 them with etags.
7498
7499 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7500 changes in globals.h immediately force recompilation.
7501 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7502 $(CURDIR)/s/ms-w32.h.
7503 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7504
7505 * character.c (Fchar_direction): Function deleted.
7506 (syms_of_character): Don't defsubr it.
7507 <char-direction-table>: Deleted.
7508
75092011-04-23 Eli Zaretskii <eliz@gnu.org>
7510
7511 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7512 * doprnt.c: Include limits.h.
7513 (SIZE_MAX): New macro.
7514 (doprnt): Return a size_t value. 2nd arg is now size_t.
7515 Many local variables are now size_t instead of int or unsigned.
7516 Improve overflow protection. Support `l' modifier for integer
7517 conversions. Support %l conversion. Don't assume an EMACS_INT
7518 argument for integer conversions and for %c.
7519
7520 * lisp.h (doprnt): Restore prototype.
7521
7522 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7523 $(SRC)/character.h.
7524
7525 * Makefile.in (base_obj): Add back doprnt.o.
7526
7527 * deps.mk (doprnt.o): Add back prerequisites.
7528 (callint.o): Depend on character.h.
7529
7530 * eval.c (internal_lisp_condition_case): Include the handler
7531 representation in the error message.
7532 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7533 when breaking from the loop.
7534
7535 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7536
7537 * callint.c (Fcall_interactively): When displaying error message
7538 about invalid control letter, pass the character's codepoint, not
7539 a pointer to its multibyte form. Improve display of the character
7540 in octal and display also its hex code.
7541
7542 * character.c (char_string): Use %x to display the (unsigned)
7543 codepoint of an invalid character, to avoid displaying a bogus
7544 negative value.
7545
7546 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7547 `error', not SYMBOL_NAME itself.
7548
7549 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7550 character arguments to `error'.
7551
7552 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7553 to `error' in error message about FINAL_CHAR argument. Make sure
7554 FINAL_CHAR is a character, and use %c when it is passed as
7555 argument to `error'.
7556
75572011-04-23 Eli Zaretskii <eliz@gnu.org>
7558
7559 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7560
7561 * w32.c: Include <time.h>.
7562 (sys_localtime): New function.
7563
75642011-04-23 Chong Yidong <cyd@stupidchicken.com>
7565
7566 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7567
7568 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7569
75702011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7571
7572 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7573 zombies (Bug#8467).
7574
75752011-04-19 Eli Zaretskii <eliz@gnu.org>
7576
7577 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7578 gl_state.e_property when gl_state.object is Qt.
7579
7580 * insdel.c (make_gap_larger): Remove limitation of buffer size
7581 to <= INT_MAX.
7582
75832011-04-18 Chong Yidong <cyd@stupidchicken.com>
7584
7585 * xdisp.c (lookup_glyphless_char_display)
7586 (produce_glyphless_glyph): Handle cons cell entry in
7587 glyphless-char-display.
7588 (Vglyphless_char_display): Document it.
7589
7590 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7591 glyphless-char-display.
7592
75932011-04-17 Chong Yidong <cyd@stupidchicken.com>
7594
7595 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7596
7597 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7598
7599 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7600 definition for no-X builds.
7601
76022011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7603
7604 Static checks with GCC 4.6.0 and non-default toolkits.
7605
7606 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7607
7608 * process.c (keyboard_bit_set): Define only if SIGIO.
7609 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7610 (send_process): Repair possible setjmp clobbering.
7611
7612 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7613
7614 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7615
7616 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7617
7618 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7619 Define only if needed.
7620
7621 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7622 by pacifying GCC about it. Maybe it's time to retire it?
7623 * xfaces.c (USG, __TIMEVAL__): Likewise.
7624
7625 * dispextern.h (struct redisplay_interface): Rename param
7626 to avoid shadowing.
7627 * termhooks.h (struct terminal): Likewise.
7628 * xterm.c (xembed_send_message): Likewise.
7629
7630 * insdel.c (make_gap_smaller): Define only if
7631 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7632
7633 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7634 it.
7635
7636 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7637 so that we aren't warned about unused symbols.
7638
7639 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7640
7641 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7642
7643 * xfns.c (x_real_positions): Mark locals as initialized.
7644
7645 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7646
7647 * xterm.c: Fix problems found by static analysis with other toolkits.
7648 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7649 (x_dispatch_event): Declare static if USE_GTK, and
7650 define if USE_GTK || USE_X_TOOLKIT.
7651 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7652 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7653 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7654 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7655
7656 * xmenu.c (menu_help_callback): Pointer type fixes.
7657 Use const pointers when pointing at readonly data. Avoid pointer
7658 signedness clashes.
7659 (FALSE): Remove unused macro.
7660 (update_frame_menubar): Remove unused decl.
7661
7662 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7663
7664 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7665 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7666 (single_menu_item): Rename local to avoid shadowing.
7667
7668 * keyboard.c (make_lispy_event): Remove unused local var.
7669
7670 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7671 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7672
7673 * bitmaps: Change bitmaps from unsigned char back to the X11
7674 compatible char. Avoid the old compiler warnings about
7675 out-of-range initializers by using, for example, '\xab' rather
7676 than 0xab.
7677
7678 * xgselect.c (xgselect_initialize): Check vs interface
7679 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7680
7681 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7682
7683 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7684 to read-only memory.
7685
7686 * fns.c (vector): Remove; this old hack is no longer needed.
7687
7688 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7689 Remove unused var.
7690 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7691
7692 * xrdb.c (x_load_resources): Omit unused local.
7693
7694 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7695 (x_window): Rename locals to avoid shadowing.
7696 (USG): Use the kludged USG macro, to pacify gcc.
7697
7698 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7699 (x_term_init): Remove local to avoid shadowing.
7700
7701 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7702
7703 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7704 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7705
77062011-04-16 Eli Zaretskii <eliz@gnu.org>
7707
7708 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7709
7710 Fix regex.c, syntax.c and friends for buffers > 2GB.
7711 * syntax.h (struct gl_state_s): Declare character position members
7712 EMACS_INT.
7713
7714 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7715
7716 * textprop.c (verify_interval_modification, interval_of):
7717 Declare arguments EMACS_INT.
7718
7719 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7720 EMACS_INT.
7721
7722 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7723
7724 * indent.c (Fvertical_motion): Local variable it_start is now
7725 EMACS_INT.
7726
7727 * regex.c (re_match, re_match_2, re_match_2_internal)
7728 (bcmp_translate, regcomp, regexec, print_double_string)
7729 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7730 (re_compile_pattern, re_exec): Declare arguments and local
7731 variables `size_t' and `ssize_t' and return values `regoff_t', as
7732 appropriate.
7733 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7734 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7735 <compile_stack_type>: `size' and `avail' are now `size_t'.
7736
7737 * regex.h <regoff_t>: Use ssize_t, not int.
7738 (re_search, re_search_2, re_match, re_match_2): Arguments that
7739 specify buffer/string position and length are now ssize_t and
7740 size_t. Return type is regoff_t.
7741
77422011-04-16 Ben Key <bkey76@gmail.com>
7743
7744 * nsfont.m: Fixed bugs in ns_get_family and
7745 ns_descriptor_to_entity that were caused by using free to
7746 deallocate memory blocks that were allocated by xmalloc (via
7747 xstrdup). This caused Emacs to crash when compiled with
7748 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7749 --enable-checking=xmallocoverrun). xfree is now used to
7750 deallocate these memory blocks.
7751
77522011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7753
7754 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7755
7756 emacs_write: Accept and return EMACS_INT for sizes.
7757 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7758 et seq.
7759 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7760 Accept and return EMACS_INT.
7761 (emacs_gnutls_write): Return the number of bytes written on
7762 partial writes.
7763 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7764 (emacs_read, emacs_write): Remove check for negative size, as the
7765 Emacs source code has been audited now.
7766 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7767 (emacs_read, emacs_write): Use it.
7768 * process.c (send_process): Adjust to the new signatures of
7769 emacs_write and emacs_gnutls_write. Do not attempt to store
7770 a byte offset into an 'int'; it might overflow.
7771 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7772
7773 * sound.c: Don't assume sizes fit in 'int'.
7774 (struct sound_device.period_size, alsa_period_size):
7775 Return EMACS_INT, not int.
7776 (struct sound_device.write, vox_write, alsa_write):
7777 Accept EMACS_INT, not int.
7778 (wav_play, au_play): Use EMACS_INT to store sizes and to
7779 record read return values.
7780
77812011-04-15 Ben Key <bkey76@gmail.com>
7782
7783 * keyboard.c (Qundefined): Don't declare static since it is used
7784 in nsfns.m.
7785 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7786 static since they are used in nsfont.m.
7787
77882011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7789
7790 * process.c (Qprocessp): Don't declare static.
7791 * lisp.h (Qprocessp): Declare again.
7792
77932011-04-15 Juanma Barranquero <lekktu@gmail.com>
7794
7795 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7796
77972011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7798
7799 Improve C-level modularity by making more things 'static'.
7800
7801 Don't publish debugger-only interfaces to other modules.
7802 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7803 (verify_bytepos, count_markers): Move decls to the only modules
7804 that need them.
7805 * region-cache.h (pp_cache): Likewise.
7806 * window.h (check_all_windows): Likewise.
7807 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7808
7809 * sysdep.c (croak): Now static, if
7810 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7811 * syssignal.h (croak): Declare only if not static.
7812
7813 * alloc.c (refill_memory_reserve): Now static if
7814 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7815 * lisp.h (refill_memory_reserve): Declare only if not static.
7816
7817 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7818 Define only if USE_LUCID.
7819
7820 * xrdb.c (x_customization_string, x_rm_string): Now static.
7821
7822 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7823 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7824
7825 * xdisp.c (draw_row_with_mouse_face): Now static.
7826 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7827
7828 * window.h (check_all_windows): Mark externally visible.
7829
7830 * window.c (window_deletion_count): Now static.
7831
7832 * undo.c: Make symbols static if they're not exported.
7833 (last_undo_buffer, last_boundary_position, pending_boundary):
7834 Now static.
7835
7836 * textprop.c (interval_insert_behind_hooks): Now static.
7837 (interval_insert_in_front_hooks): Likewise.
7838
7839 * term.c: Make symbols static if they're not exported.
7840 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7841 (max_frame_lines, tty_set_terminal_modes):
7842 (tty_reset_terminal_modes, tty_turn_off_highlight):
7843 (get_tty_terminal): Now static.
7844 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7845 * termhooks.h (term_mouse_moveto): Do not declare if
7846 HAVE_WINDOW_SYSTEM.
7847 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7848 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7849
7850 * sysdep.c: Make symbols static if they're not exported.
7851 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7852 Now static.
7853 (sigprocmask_set, full_mask): Remove; unused.
7854 (wait_debugging): Mark as visible.
7855 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7856 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7857
7858 * syntax.c (syntax_temp): Define only if !__GNUC__.
7859
7860 * sound.c (current_sound_device, current_sound): Now static.
7861
7862 * search.c (searchbufs, searchbuf_head): Now static.
7863
7864 * scroll.c (scroll_cost): Remove; unused.
7865 * dispextern.h (scroll_cost): Remove decl.
7866
7867 * region-cache.h (pp_cache): Mark as externally visible.
7868
7869 * process.c: Make symbols static if they're not exported.
7870 (process_tick, update_tick, create_process, chan_process):
7871 (Vprocess_alist, proc_buffered_char, datagram_access):
7872 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7873 (deactivate_process): Mark defn as static, as well as decl.
7874 * lisp.h (create_process): Remove decl.
7875 * process.h (chan_process, Vprocess_alist): Remove decls.
7876
7877 * print.c: Make symbols static if they're not exported.
7878 (print_depth, new_backquote_output, being_printed, print_buffer):
7879 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7880 (print_interval, print_number_index, initial_stderr_stream):
7881 Now static.
7882 * lisp.h (Fprinc): Remove decl.
7883 (debug_output_compilation_hack): Mark as externally visible.
7884
7885 * sysdep.c (croak): Move decl from here to syssignal.h.
7886 * syssignal.h (croak): Put it here, so the API can be checked when
7887 'croak' is called from dissociate_if_controlling_tty.
7888
7889 * minibuf.c: Make symbols static if they're not exported.
7890 (minibuf_save_list, choose_minibuf_frame): Now static.
7891 * lisp.h (choose_minibuf_frame): Remove decl.
7892
7893 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7894
7895 * lread.c: Make symbols static if they're not exported.
7896 (read_objects, initial_obarray, oblookup_last_bucket_number):
7897 Now static.
7898 (make_symbol): Remove; unused.
7899 * lisp.h (initial_obarray, make_symbol): Remove decls.
7900
7901 * keyboard.c: Make symbols static if they're not exported.
7902 (single_kboard, recent_keys_index, total_keys, recent_keys):
7903 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7904 (this_single_command_key_start, echoing, last_auto_save):
7905 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7906 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7907 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7908 (Vlispy_mouse_stem, double_click_count):
7909 Now static.
7910 (force_auto_save_soon): Define only if SIGDANGER.
7911 (ignore_mouse_drag_p): Now static if
7912 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7913 (print_help): Remove; unused.
7914 (stop_character, last_timer_event): Mark as externally visible.
7915 * keyboard.h (ignore_mouse_drag_p): Declare only if
7916 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7917 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7918 * lisp.h (echoing): Remove decl.
7919 (force_auto_save_soon): Declare only if SIGDANGER.
7920 * xdisp.c (redisplay_window): Simplify code, to make it more
7921 obvious that ignore_mouse_drag_p is not accessed if !defined
7922 USE_GTK && !defined HAVE_NS.
7923
7924 * intervals.c: Make symbols static if they're not exported.
7925 (merge_properties_sticky, merge_interval_right, delete_interval):
7926 Now static.
7927 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7928
7929 * insdel.c: Make symbols static if they're not exported.
7930 However, leave prepare_to_modify_buffer alone. It's never
7931 called from outside this function, but that appears to be a bug.
7932 (combine_after_change_list, combine_after_change_buffer):
7933 (adjust_after_replace, signal_before_change): Now static.
7934 (adjust_after_replace_noundo): Remove; unused.
7935 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7936 (signal_before_change): Remove decls.
7937
7938 * indent.c (val_compute_motion, val_vmotion): Now static.
7939
7940 * image.c: Make symbols static if they're not exported.
7941 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7942 if USE_GTK.
7943 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7944 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7945
7946 * fringe.c (standard_bitmaps): Now static.
7947 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7948
7949 * frame.c: Make symbols static if they're not exported.
7950 (x_report_frame_params, make_terminal_frame): Now static.
7951 (get_frame_param): Now static, unless HAVE_NS.
7952 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7953 (x_get_resource_string): Remove; not used.
7954 * frame.h (make_terminal_frame, x_report_frame_params):
7955 (x_get_resource_string); Remove decls.
7956 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7957 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7958
7959 * font.c, fontset.c: Make symbols static if they're not exported.
7960 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7961 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7962 * font.c (font_close_object): Now static.
7963 * font.h (font_close_object): Remove.
7964 * fontset.c (FONTSET_OBJLIST): Remove.
7965 (free_realized_fontset) #if-0 the body, which does nothing.
7966 (face_suitable_for_char_p): #if-0, as it's never called.
7967 * fontset.h (face_suitable_for_char_p): Remove decl.
7968 * xfaces.c (face_at_string_position):
7969 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7970 since 0 is always ASCII.
7971
7972 * fns.c (weak_hash_tables): Now static.
7973
7974 * fileio.c: Make symbols static if they're not exported.
7975 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7976 (Vwrite_region_annotation_buffers): Now static.
7977
7978 * eval.c: Make symbols static if they're not exported.
7979 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7980 * lisp.h (backtrace_list): Remove decl.
7981
7982 * emacs.c: Make symbols static if they're not exported.
7983 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7984 (fatal_error_code, fatal_error_signal_hook, standard_args):
7985 Now static.
7986 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7987 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7988 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7989 * lisp.h (fatal_error_signal_hook): Remove decl.
7990 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7991
7992 * editfns.c: Move a (normally-unused) function to its only use.
7993 * editfns.c, lisp.h (get_operating_system_release): Remove.
7994 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7995 worth the hassle of breaking this out.
7996
7997 * xterm.c: Make symbols static if they're not exported.
7998 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7999 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8000 (x_destroy_window, x_delete_display):
8001 Now static.
8002 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8003 (x_mouse_leave): Remove; unused.
8004 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8005 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8006 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8007 Remove decls.
8008 (x_mouse_leave): Declare only if WINDOWSNT.
8009 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8010 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8011 USE_X_TOOLKIT.
8012
8013 * ftxfont.c: Make symbols static if they're not exported.
8014 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8015 HAVE_FREETYPE.
8016 * font.h (ftxfont_driver): Likewise.
8017
8018 * xfns.c: Make symbols static if they're not exported.
8019 (x_last_font_name, x_display_info_for_name):
8020 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8021 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8022 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8023 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8024 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8025 (last_show_tip_args): Now static.
8026 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8027 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8028 (x_screen_planes): Remove; unused.
8029 * dispextern.h (x_screen_planes): Remove decl.
8030
8031 * dispnew.c: Make symbols static if they're not exported.
8032 * dispextern.h (redraw_garbaged_frames, scrolling):
8033 (increment_row_positions): Remove.
8034 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8035 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8036 Now static.
8037 (redraw_garbaged_frames): Remove; unused.
8038
8039 * xfaces.c: Make symbols static if they're not exported.
8040 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8041 Remove decls.
8042 * xterm.h (defined_color): Remove decls.
8043 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8044 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8045 (menu_face_changed_default, defined_color, free_realized_face):
8046 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8047 (ascii_face_of_lisp_face): Remove; unused.
8048
8049 * xdisp.c: Make symbols static if they're not exported.
8050 * dispextern.h (scratch_glyph_row, window_box_edges):
8051 (glyph_to_pixel_coords, set_cursor_from_row):
8052 (get_next_display_element, set_iterator_to_next):
8053 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8054 (show_mouse_face): Remove decls
8055 * frame.h (message_buf_print): Likewise.
8056 * lisp.h (pop_message, set_message, check_point_in_composition):
8057 Likewise.
8058 * xterm.h (set_vertical_scroll_bar): Likewise.
8059 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8060 (message_buf_print, scratch_glyph_row, displayed_buffer):
8061 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8062 (get_next_display_element, show_mouse_face, window_box_edges):
8063 (frame_to_window_pixel_xy, check_point_in_composition):
8064 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8065 (glyph_to_pixel_coords): Remove; unused.
8066
8067 * dired.c (file_name_completion): Now static.
8068
8069 * dbusbind.c (xd_in_read_queued_messages): Now static.
8070
8071 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8072 * data.c (circular_list_error): Remove.
8073
8074 * commands.h (last_point_position, last_point_position_buffer):
8075 (last_point_position_window): Remove decls.
8076 * keyboard.c: Make these variables static.
8077
8078 * coding.h (coding, code_convert_region, encode_coding_gap):
8079 Remove decls.
8080 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8081 (iso_code_class, detect_coding, code_convert_region): Now static.
8082 (encode_coding_gap): Remove; unused.
8083
8084 * chartab.c (chartab_chars, chartab_bits): Now static.
8085
8086 * charset.h (charset_iso_8859_1): Remove decl.
8087 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8088 Now static.
8089
8090 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8091 * ccl.c (Vccl_program_table): Now static.
8092 (check_ccl_update): Remove; unused.
8093
8094 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8095 * category.h: ... from here.
8096 * category.c (check_category_table, set_category_set): Now static.
8097
8098 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8099 * lisp.h: Remove these decls.
8100
8101 * buffer.c (buffer_count): Remove unused var.
8102
8103 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8104 so that it's not optimized away.
8105 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8106 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8107 exported only to the debugger.
8108
8109 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8110 * atimer.h (run_all_atimers): Remove; not exported.
8111
8112 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8113 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8114 was inaccessible from Lisp.
8115 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8116 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8117
8118 alloc.c: Import and export fewer symbols, and remove unused items.
8119 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8120 is defined.
8121 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8122 it's not optimized away by whole-program optimization.
8123 (message_enable_multibyte, free_misc): Remove.
8124 (catchlist, handlerlist, mark_backtrace):
8125 Declare only if BYTE_MARK_STACK.
8126 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8127 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8128 (message_enable_multibyte): Remove decl.
8129 (free_misc, interval_free_list, float_block, float_block_index):
8130 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8131 (cons_free_list, last_marked_index):
8132 Now static.
8133 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8134 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8135 (mark_backtrace): Define only if BYTE_MARK_STACK.
8136 * xdisp.c (message_enable_multibyte): Now static.
8137
8138 Declare Lisp_Object Q* variables to be 'static' if not exported.
8139 This makes it easier for human readers (and static analyzers)
8140 to see whether these variables are used from other modules.
8141 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8142 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8143 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8144 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8145 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8146 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8147 * xmenu.c, xselect.c:
8148 Declare Q* vars static if they are not used in other modules.
8149 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8150 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8151 Remove decls of unexported vars.
8152 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8153
8154 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8155
8156 Make Emacs functions such as Fatom 'static' by default.
8157 This makes it easier for human readers (and static analyzers)
8158 to see whether these functions can be called from other modules.
8159 DEFUN now defines a static function. To make the function external
8160 so that it can be used in other C modules, use the new macro DEFUE.
8161 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8162 (Finit_image_library):
8163 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8164 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8165 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8166 Remove decls, since these functions are now static.
8167 (Funintern, Fget_internal_run_time): New decls, since these functions
8168 were already external.
8169
8170 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8171 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8172 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8173 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8174 * keyboard.c, keymap.c, lread.c:
8175 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8176 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8177 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8178 Mark functions with DEFUE instead of DEFUN,
8179 if they are used in other modules.
8180 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8181 decls for now-static functions.
8182 * buffer.h (Fdelete_overlay): Remove decl.
8183 * callproc.c (Fgetenv_internal): Mark as internal.
8184 * composite.c (Fremove_list_of_text_properties): Remove decl.
8185 (Fcomposition_get_gstring): New forward static decl.
8186 * composite.h (Fcomposite_get_gstring): Remove decl.
8187 * dired.c (Ffile_attributes): New forward static decl.
8188 * doc.c (Fdocumntation_property): New forward static decl.
8189 * eval.c (Ffetch_bytecode): New forward static decl.
8190 (Funintern): Remove extern decl; now in .h file where it belongs.
8191 * fileio.c (Fmake_symbolic_link): New forward static decl.
8192 * image.c (Finit_image_library): New forward static decl.
8193 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8194 * intervals.h (Fprevious_property_change):
8195 (Fremove_list_of_text_properties): Remove decls.
8196 * keyboard.c (Fthis_command_keys): Remove decl.
8197 (Fcommand_execute): New forward static decl.
8198 * keymap.c (Flookup_key): New forward static decl.
8199 (Fcopy_keymap): Now static.
8200 * keymap.h (Flookup_key): Remove decl.
8201 * process.c (Fget_process): New forward static decl.
8202 (Fprocess_datagram_address): Mark as internal.
8203 * syntax.c (Fsyntax_table_p): New forward static decl.
8204 (skip_chars): Remove duplicate decl.
8205 * textprop.c (Fprevious_property_change): New forward static decl.
8206 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8207 Now internal.
8208 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8209 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8210
8211 * editfns.c (Fformat): Remove unreachable code.
8212
82132011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8214
8215 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8216 change. (Bug#8496)
8217
82182011-04-13 Eli Zaretskii <eliz@gnu.org>
8219
8220 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8221 when at ZV. (Bug#8487)
8222
82232011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8224
8225 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8226 (Bug#8437)
8227 * keyboard.c (parse_tool_bar_item): Likewise.
8228 * sound.c (sound_cleanup, alsa_close): Likewise.
8229 * termcap.c (tgetent): Likewise.
8230 * xfns.c (x_default_font_parameter): Likewise.
8231 * xsettings.c (read_and_apply_settings): Likewise.
8232
8233 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8234 (overrun_check_free): Protoize.
8235
82362011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8237
8238 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8239 since callers should never pass a negative size.
8240 Change the signature to match that of plain 'read' and 'write'; see
8241 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8242 * lisp.h: Update prototypes of emacs_write and emacs_read.
8243
82442011-04-11 Eli Zaretskii <eliz@gnu.org>
8245
8246 * xdisp.c (redisplay_window): Don't try to determine the character
8247 position of the scroll margin if the window start point w->startp
8248 is outside the buffer's accessible region. (Bug#8468)
8249
82502011-04-10 Eli Zaretskii <eliz@gnu.org>
8251
8252 Fix write-region and its subroutines for buffers > 2GB.
8253 * fileio.c (a_write, e_write): Modify declaration of arguments and
8254 local variables to support buffers larger than 2GB.
8255 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8256
8257 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8258 argument, local variables, and return value.
8259
8260 * lisp.h: Update prototypes of emacs_write and emacs_read.
8261
8262 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8263
82642011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8265
8266 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8267
8268 Fix more problems found by GCC 4.6.0's static checks.
8269
8270 * xdisp.c (vmessage): Use a better test for character truncation.
8271
8272 * charset.c (load_charset_map): <, not <=, for optimization,
8273 and to avoid potential problems with integer overflow.
8274 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8275 * casetab.c (set_identity, shuffle): Likewise.
8276 * editfns.c (Fformat): Likewise.
8277 * syntax.c (skip_chars): Likewise.
8278
8279 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8280 This also lets GCC 4.6.0 generate slightly better loop code.
8281
8282 * callint.c (Fcall_interactively): <, not <=, for optimization.
8283 (Fcall_interactively): Count the number of arguments produced,
8284 not the number of arguments given. This is simpler and lets GCC
8285 4.6.0 generate slightly better code.
8286
8287 * ftfont.c: Distingish more carefully between FcChar8 and char.
8288 The previous code passed unsigned char * to a functions like
8289 strlen and xstrcasecmp that expect char *, which does not
8290 conform to the C standard.
8291 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8292 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8293 char * when the C standard requires it.
8294
8295 * keyboard.c (read_char): Remove unused var.
8296
8297 * eval.c: Port to Windows vsnprintf (Bug#8435).
8298 Include <limits.h>.
8299 (SIZE_MAX): Define if the headers do not.
8300 (verror): Do not give up if vsnprintf returns a negative count.
8301 Instead, grow the buffer. This ports to Windows vsnprintf, which
8302 does not conform to C99. Problem reported by Eli Zaretskii.
8303 Also, simplify the allocation scheme, by avoiding the need for
8304 calling realloc, and removing the ALLOCATED variable.
8305
8306 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8307
8308 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8309 But keep the doprint source code for now, as we might revamp it
8310 and use it again (Bug#8435).
8311 * lisp.h (doprnt): Remove.
8312 * Makefile.in (base_obj): Remove doprnt.o.
8313 * deps.mk (doprnt.o): Remove.
8314
8315 error: Print 32- and 64-bit integers portably (Bug#8435).
8316 Without this change, on typical 64-bit hosts error ("...%d...", N)
8317 was used to print both 32- and 64-bit integers N, which relied on
8318 undefined behavior.
8319 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8320 * lisp.h (error, verror): Mark as printf-like functions.
8321 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8322 Report overflow in size calculations when allocating printf buffer.
8323 Do not truncate output string at its first null byte.
8324 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8325 Truncate the output at a character boundary, since vsnprintf does not
8326 do that.
8327 * charset.c (check_iso_charset_parameter): Convert internal
8328 character to string before calling 'error', since %c now has the
8329 printf meaning.
8330 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8331 overflow when computing char to be passed to 'error'. Do not
8332 pass Lisp_Object to 'error'; pass the integer instead.
8333 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8334 formatted with plain %d.
8335
8336 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8337
8338 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8339
8340 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8341
8342 * xterm.c (x_catch_errors): Remove duplicate declaration.
8343
8344 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8345
8346 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8347
83482011-04-10 Jim Meyering <meyering@redhat.com>
8349
8350 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8351 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8352 return ssize_t not "int", and use size_t as the buffer length.
8353 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8354 * gnutls.h: Update declarations.
8355 * process.c (read_process_output): Use ssize_t, to match.
8356 (send_process): Likewise.
8357
83582011-04-09 Chong Yidong <cyd@stupidchicken.com>
8359
8360 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8361
83622011-04-09 Chong Yidong <cyd@stupidchicken.com>
8363
8364 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8365 Use unsigned char, to match FcChar8 type definition.
8366
8367 * xterm.c (handle_one_xevent):
8368 * xmenu.c (create_and_show_popup_menu):
8369 * xselect.c (x_decline_selection_request)
8370 (x_reply_selection_request): Avoid type-punned deref of X events.
8371
83722011-04-09 Eli Zaretskii <eliz@gnu.org>
8373
8374 Fix some uses of `int' instead of EMACS_INT.
8375 * search.c (string_match_1, fast_string_match)
8376 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8377 (scan_buffer, find_next_newline_no_quit)
8378 (find_before_next_newline, search_command, Freplace_match)
8379 (Fmatch_data): Make some `int' variables be EMACS_INT.
8380
8381 * xdisp.c (display_count_lines): 3rd argument and return value now
8382 EMACS_INT. All callers changed.
8383 (pint2hrstr): Last argument is now EMACS_INT.
8384
8385 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8386 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8387 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8388 (decode_coding_utf_16, decode_coding_emacs_mule)
8389 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8390 (decode_coding_ccl, decode_coding_charset)
8391 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8392 (decode_coding_iso_2022, decode_coding_emacs_mule)
8393 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8394 <char_offset, last_offset>: Declare EMACS_INT.
8395 (encode_coding_utf_8, encode_coding_utf_16)
8396 (encode_coding_emacs_mule, encode_invocation_designation)
8397 (encode_designation_at_bol, encode_coding_iso_2022)
8398 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8399 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8400 Declare EMACS_INT.
8401 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8402 (encode_invocation_designation): Last argument P_NCHARS is now
8403 EMACS_INT.
8404 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8405 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8406
8407 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8408 All users changed.
8409
8410 * ccl.c (Fccl_execute_on_string): Declare some variables
8411 EMACS_INT.
8412
84132011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8414
8415 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8416
84172011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8418
8419 * process.c (Fformat_network_address): Doc fix.
8420
84212011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8422
8423 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8424
84252011-04-08 Chong Yidong <cyd@stupidchicken.com>
8426
8427 * keyboard.c (read_char): Call Lisp function help-form-show,
8428 instead of using internal_with_output_to_temp_buffer.
8429 (Qhelp_form_show): New var.
8430 (syms_of_keyboard): Use DEFSYM macro.
8431
8432 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8433
8434 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8435
84362011-04-06 Chong Yidong <cyd@stupidchicken.com>
8437
8438 * process.c (Flist_processes): Remove to Lisp.
8439 (list_processes_1): Delete.
8440
84412011-04-06 Eli Zaretskii <eliz@gnu.org>
8442
8443 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8444
8445 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8446
84472011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8448
8449 Fix more problems found by GCC 4.6.0's static checks.
8450
8451 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8452
8453 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8454
8455 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8456
8457 * xdisp.c (vmessage): Mark as a printf-like function.
8458
8459 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8460
8461 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8462
8463 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8464 printf-like functions.
8465 (tiff_load): Add casts to remove these marks before passing them
8466 to system-supplied API.
8467
8468 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8469
8470 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8471 This avoids several warnings with gcc -Wstrict-overflow.
8472 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8473 directly, rather than having caller test rule sign. This avoids
8474 some unnecessary tests.
8475 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8476 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8477 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8478
8479 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8480 (xfont_open): Avoid unnecessary tests.
8481
8482 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8483
8484 * composite.h, composite.c (composition_gstring_put_cache):
8485 Use EMACS_INT, not int, for length.
8486
8487 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8488 breaking out part of COMPOSITION_DECODE_RULE.
8489 (COMPOSITION_DECODE_RULE): Use it.
8490 * composite.c (get_composition_id): Remove unused local vars,
8491 by using the new macro.
8492
8493 * textprop.c (set_text_properties_1): Change while to do-while,
8494 since the condition is always true at first.
8495
8496 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8497 (interval_deletion_adjustment): Return unsigned value.
8498 All uses changed.
8499
8500 * process.c (list_processes_1, create_pty, read_process_output):
8501 (exec_sentinel): Remove vars that were set but not used.
8502 (create_pty): Remove unnecessary "volatile"s.
8503 (Fnetwork_interface_info): Avoid possibility of int overflow.
8504 (read_process_output): Do adaptive read buffering even if carryover.
8505 (read_process_output): Simplify nbytes computation if buffered.
8506
8507 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8508
8509 * syntax.c (scan_words): Remove var that was set but not used.
8510 (update_syntax_table): Use unsigned instead of int.
8511
8512 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8513 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8514 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8515
8516 * print.c (print_error_message): Avoid int overflow.
8517
8518 * font.c (font_list_entities): Redo for clarity,
8519 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8520
8521 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8522 (font_score): Avoid potential overflow in diff calculation.
8523
8524 * fns.c (substring_both): Remove var that is set but not used.
8525 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8526
8527 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8528
8529 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8530 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8531 can always succeed if overflow has undefined behavior.
8532
8533 * search.c (boyer_moore, wordify): Remove vars set but not used.
8534 (wordify): Omit three unnecessary tests.
8535
8536 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8537 All callers changed. This avoids the need for an unused var.
8538
8539 * casefiddle.c (casify_region): Remove var that is set but not used.
8540
8541 * dired.c (file_name_completion): Remove var that is set but not used.
8542
8543 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8544
8545 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8546 (Finsert_file_contents): Remove unnecessary code checking fd.
8547
8548 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8549 Check for integer overflow on size calculations.
8550
8551 * buffer.c (Fprevious_overlay_change): Remove var that is set
8552 but not used.
8553
8554 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8555 Remove vars that are set but not used.
8556 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8557 (timer_check_2): Mark vars as initialized.
8558
8559 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8560
8561 * image.c (lookup_image): Remove var that is set but not used.
8562 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8563
8564 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8565 that are set but not used.
8566
8567 * xfns.c (make_invisible_cursor): Don't return garbage
8568 if XCreateBitmapFromData fails (Bug#8410).
8569
8570 * xselect.c (x_get_local_selection, x_handle_property_notify):
8571 Remove vars that are set but not used.
8572
8573 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8574 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8575
8576 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8577 Remove var that is set but not used.
8578 (scroll_bar_windows_size): Now size_t, not int.
8579 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8580 Check for overflow.
8581
8582 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8583 (map_tty_color) [!defined MSDOS]: Likewise.
8584
8585 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8586
8587 * coding.c: Remove vars that are set but not used.
8588 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8589 All callers changed.
8590 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8591 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8592 (decode_coding_charset): Remove vars that are set but not used.
8593
8594 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8595 that is set but not used.
8596
8597 * print.c (print_object): Remove var that is set but not used.
8598
8599 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8600 The gnulib version avoids calling malloc in the usual case,
8601 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8602 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8603 * filelock.c (current_lock_owner): Likewise.
8604 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8605 * sysdep.c: Include allocator.h, careadlinkat.h.
8606 (emacs_no_realloc_allocator): New static constant.
8607 (emacs_readlink): New function.
8608 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8609 ../lib/careadlinkat.h.
8610
86112011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8612
8613 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8614 first non-nil return value).
8615
86162011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8617
8618 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8619 if not defined (Bug#8403).
8620
86212011-04-02 Juanma Barranquero <lekktu@gmail.com>
8622
8623 * xdisp.c (display_count_lines): Remove parameter `start',
8624 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8625 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8626 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8627 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8628 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8629 and thereabouts. All callers changed.
8630 (get_per_char_metric): Remove parameter `f', unused since
8631 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8632
86332011-04-02 Jim Meyering <meyering@redhat.com>
8634
8635 do not dereference NULL upon failed strdup
8636 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8637 (ns_get_family): Likewise.
8638
86392011-04-02 Juanma Barranquero <lekktu@gmail.com>
8640
8641 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8642
86432011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8644
8645 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8646 later (Bug#8403).
8647
86482011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8649
8650 Add lexical binding.
8651
8652 * window.c (Ftemp_output_buffer_show): New fun.
8653 (Fsave_window_excursion):
8654 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8655
8656 * lread.c (lisp_file_lexically_bound_p): New function.
8657 (Fload): Bind Qlexical_binding.
8658 (readevalloop): Remove `evalfun' arg.
8659 Bind Qinternal_interpreter_environment.
8660 (Feval_buffer): Bind Qlexical_binding.
8661 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8662 Mark as dynamic.
8663 (syms_of_lread): Declare `lexical-binding'.
8664
8665 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8666
8667 * keyboard.c (eval_dyn): New fun.
8668 (menu_item_eval_property): Use it.
8669
8670 * image.c (parse_image_spec): Use Ffunctionp.
8671
8672 * fns.c (concat, mapcar1): Accept byte-code-functions.
8673
8674 * eval.c (Fsetq): Handle lexical vars.
8675 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8676 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8677 (FletX, Flet): Obey lexical binding.
8678 (Fcommandp): Handle closures.
8679 (Feval): New `lexical' arg.
8680 (eval_sub): New function extracted from Feval. Use it almost
8681 everywhere where Feval was used. Look up vars in lexical env.
8682 Handle closures.
8683 (Ffunctionp): Move from subr.el.
8684 (Ffuncall): Handle closures.
8685 (apply_lambda): Remove `eval_flags'.
8686 (funcall_lambda): Handle closures and new byte-code-functions.
8687 (Fspecial_variable_p): New function.
8688 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8689 but without exporting it to Lisp.
8690
8691 * doc.c (Fdocumentation, store_function_docstring):
8692 * data.c (Finteractive_form): Handle closures.
8693
8694 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8695 interactive spec.
8696
8697 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8698 New byte-codes.
8699 (exec_byte_code): New function extracted from Fbyte_code to handle new
8700 calling convention for byte-code-functions. Add new byte-codes.
8701
8702 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8703
8704 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8705
87062011-03-31 Juanma Barranquero <lekktu@gmail.com>
8707
8708 * xdisp.c (redisplay_internal): Fix prototype.
8709
87102011-03-31 Eli Zaretskii <eliz@gnu.org>
8711
8712 * xdisp.c (SCROLL_LIMIT): New macro.
8713 (try_scrolling): Use it when setting scroll_limit.
8714 Limit scrolling to 100 screen lines.
8715 (redisplay_window): Even when falling back on "recentering",
8716 position point in the window according to scroll-conservatively,
8717 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8718
8719 (try_scrolling): When point is above the window, allow searching
8720 as far as scroll_max, or one screenful, to compute vertical
8721 distance from PT to the scroll margin position. This prevents
8722 try_scrolling from unnecessarily failing when
8723 scroll-conservatively is set to a value slightly larger than the
8724 window height. Clean up the case of PT below the margin at bottom
8725 of window: scroll_max can no longer be INT_MAX. When aggressive
8726 scrolling is in use, don't let point enter the opposite scroll
8727 margin as result of the scroll.
8728 (syms_of_xdisp) <scroll-conservatively>: Document the
8729 threshold of 100 lines for never-recentering scrolling.
8730
87312011-03-31 Juanma Barranquero <lekktu@gmail.com>
8732
8733 * dispextern.h (move_it_by_lines):
8734 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8735 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8736 (message_log_check_duplicate): Remove parameters `prev_bol' and
8737 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8738 (redisplay_internal): Remove parameter `preserve_echo_area',
8739 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8740
8741 * indent.c (Fvertical_motion):
8742 * window.c (window_scroll_pixel_based, Frecenter):
8743 Don't pass `need_y_p' to `move_it_by_lines'.
8744
87452011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8746
8747 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8748 steal a few bits to be more compact.
8749 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8750 Remove unneeded casts.
8751
8752 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8753
87542011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8755
8756 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8757 binding" message (bug#7967).
8758
87592011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8760
8761 Fix more problems found by GCC 4.6.0's static checks.
8762
8763 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8764 Remove unused local var.
8765
8766 * editfns.c (Fmessage_box): Remove unused local var.
8767
8768 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8769 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8770 Omit unused local vars.
8771 * window.c (shrink_windows): Omit unused local var.
8772 * menu.c (digest_single_submenu): Omit unused local var.
8773 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8774 Omit unused local var.
8775
8776 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8777 Don't assume string length fits in int.
8778 (keyremap_step, read_key_sequence): Use size_t for sizes.
8779 (read_key_sequence): Don't check last_real_key_start redundantly.
8780
8781 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8782 instead of alloca (Bug#8344).
8783
8784 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8785 (Fbacktrace_frame): Don't assume nframes fits in int.
8786
8787 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8788
8789 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8790 concerns.
8791
8792 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8793
8794 * cm.c (calccost): Turn while-do into do-while, for clarity.
8795
8796 * keyboard.c (syms_of_keyboard): Use the same style as later
8797 in this function when indexing through an array. This also
8798 works around GCC bug 48267.
8799
8800 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8801
8802 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8803
8804 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8805 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8806
8807 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8808 This avoids undefined behavior on integer overflow, and is a bit
8809 more convenient anyway since it is compared to a size_t variable.
8810
8811 Variadic C functions now count arguments with size_t, not int.
8812 This avoids an unnecessary limitation on 64-bit machines, which
8813 caused (substring ...) to crash on large vectors (Bug#8344).
8814 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8815 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8816 All variadic functions and their callers changed accordingly.
8817 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8818 * data.c (arith_driver, float_arith_driver): Likewise.
8819 * editfns.c (general_insert_function): Likewise.
8820 * eval.c (struct backtrace.nargs, interactive_p)
8821 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8822 (funcall_lambda, mark_backtrace): Likewise.
8823 * fns.c (concat): Likewise.
8824 * frame.c (x_set_frame_parameters): Likewise.
8825 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8826 0 if not found, not -1. All callers changed.
8827
8828 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8829 (stack_copy_size): Now size_t, not int.
8830 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8831
88322011-03-28 Juanma Barranquero <lekktu@gmail.com>
8833
8834 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8835 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8836 All callers changed.
8837
8838 * lisp.h (multibyte_char_to_unibyte):
8839 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8840 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8841 * character.h (CHAR_TO_BYTE8):
8842 * cmds.c (internal_self_insert):
8843 * editfns.c (general_insert_function):
8844 * keymap.c (push_key_description):
8845 * search.c (Freplace_match):
8846 * xdisp.c (message_dolog, set_message_1): All callers changed.
8847
88482011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8849
8850 * keyboard.c (safe_run_hook_funcall): New function.
8851 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8852 don't set the hook to nil, but remove the offending function instead.
8853 (Qcommand_hook_internal): Remove, unused.
8854 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8855 Vcommand_hook_internal.
8856
8857 * eval.c (enum run_hooks_condition): Remove.
8858 (funcall_nil, funcall_not): New functions.
8859 (run_hook_with_args): Call each function through a `funcall' argument.
8860 Remove `cond' argument, now redundant.
8861 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8862 (Frun_hook_with_args_until_failure): Adjust accordingly.
8863 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8864
88652011-03-28 Juanma Barranquero <lekktu@gmail.com>
8866
8867 * dispextern.h (string_buffer_position): Remove declaration.
8868
8869 * print.c (strout): Remove parameter `multibyte', unused since
8870 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8871
8872 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8873 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8874 All callers changed.
8875
8876 * w32.c (_wsa_errlist): Use braces for struct initializers.
8877
8878 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8879 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8880 All callers changed.
8881 (string_buffer_position): Likewise. Also, make static (it's never
8882 used outside xdisp.c).
8883 (cursor_row_p): Remove parameter `w', unused since
8884 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8885 (decode_mode_spec): Remove parameter `precision', introduced during
8886 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8887 All callers changed.
8888
88892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8890
8891 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8892
88932011-03-27 Anders Lindgren <andlind@gmail.com>
8894
8895 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8896 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8897 (ns_update_auto_hide_menu_bar): New functions.
8898 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8899 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8900 ns_constrain_all_frames.
8901 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8902 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8903
89042011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8905
8906 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8907
89082011-03-27 Glenn Morris <rgm@gnu.org>
8909
8910 * syssignal.h: Replace RETSIGTYPE with void.
8911 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8912 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8913 Replace SIGTYPE with void everywhere.
8914 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8915 * s/template.h (SIGTYPE): Remove commented out definition.
8916
89172011-03-26 Eli Zaretskii <eliz@gnu.org>
8918
8919 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8920 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8921
89222011-03-26 Juanma Barranquero <lekktu@gmail.com>
8923
8924 * w32.c (read_unc_volume): Use parameter `henum', instead of
8925 global variable `wget_enum_handle'.
8926
8927 * keymap.c (describe_vector): Remove parameters `indices' and
8928 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8929 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8930
8931 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8932
8933 * keyboard.c (timer_check): Remove parameter `do_it_now',
8934 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8935 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8936 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8937
8938 * keyboard.c (read_char):
8939 * w32menu.c (w32_menu_display_help):
8940 * xmenu.c (show_help_event, menu_help_callback):
8941 Adjust calls to `show_help_echo'.
8942
8943 * gtkutil.c (xg_maybe_add_timer):
8944 * keyboard.c (readable_events):
8945 * process.c (wait_reading_process_output):
8946 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8947
8948 * insdel.c (adjust_markers_gap_motion):
8949 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8950 (gap_left, gap_right): Don't call it.
8951
89522011-03-25 Chong Yidong <cyd@stupidchicken.com>
8953
8954 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8955 incurred during fontification.
8956
89572011-03-25 Juanma Barranquero <lekktu@gmail.com>
8958
8959 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8960 (DEFVAR_PER_BUFFER): Don't pass it.
8961
8962 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8963 (scrolling_window): Don't pass it.
8964
89652011-03-25 Juanma Barranquero <lekktu@gmail.com>
8966
8967 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8968
8969 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8970 and `suffix'.
8971 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8972 of variables specific to SELinux and computation of `encoded_absname'.
8973
8974 * image.c (XPutPixel): Remove unused variable `height'.
8975
8976 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8977
8978 * unexw32.c (get_section_info): Remove unused variable `section'.
8979
8980 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8981 (system_process_attributes): Remove unused variable `sess'.
8982 (sys_read): Remove unused variable `err'.
8983
8984 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8985 (w32_wnd_proc): Remove unused variable `isdead'.
8986 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8987 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8988 (x_create_tip_frame): Remove unused variable `tem'.
8989
8990 * w32inevt.c (w32_console_read_socket):
8991 Remove unused variable `no_events'.
8992
8993 * w32term.c (x_draw_composite_glyph_string_foreground):
8994 Remove unused variable `width'.
8995
89962011-03-24 Juanma Barranquero <lekktu@gmail.com>
8997
8998 * w32term.c (x_set_glyph_string_clipping):
8999 Don't pass uninitialized region to CombineRgn.
9000
90012011-03-23 Juanma Barranquero <lekktu@gmail.com>
9002
9003 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9004 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9005 (Fx_close_connection): Remove unused variable `i'.
9006
9007 * w32font.c (w32font_draw): Return number of glyphs.
9008 (w32font_open_internal): Remove unused variable `i'.
9009 (w32font_driver): Add missing initializer.
9010
9011 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9012 (fill_in_menu): Remove unused variable `items_added'.
9013
9014 * w32term.c (last_mouse_press_frame): Remove static global variable.
9015 (w32_clip_to_row): Remove unused variable `f'.
9016 (x_delete_terminal): Remove unused variable `i'.
9017
9018 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9019 (NOTHING): Remove unused static global variable.
9020 (uniscribe_check_otf): Remove unused variable `table'.
9021 (uniscribe_font_driver): Add missing initializers.
9022
90232011-03-23 Julien Danjou <julien@danjou.info>
9024
9025 * term.c (Fsuspend_tty, Fresume_tty):
9026 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9027 * window.c (temp_output_buffer_show):
9028 * insdel.c (signal_before_change):
9029 * frame.c (Fhandle_switch_frame):
9030 * fileio.c (Fdo_auto_save):
9031 * emacs.c (Fkill_emacs):
9032 * editfns.c (save_excursion_restore):
9033 * cmds.c (internal_self_insert):
9034 * callint.c (Fcall_interactively):
9035 * buffer.c (Fkill_all_local_variables):
9036 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9037 Use Frun_hooks.
9038 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9039 unconditionally since it does the check itself.
9040
90412011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9042
9043 Fix more problems found by GCC 4.5.2's static checks.
9044
9045 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9046 the first time through the loop, since we know p0 < p1 then.
9047 This also avoids a gcc -Wstrict-overflow warning.
9048
9049 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9050 leading to a memory leak, possible in functions like
9051 load_charset_map_from_file that can allocate an unbounded number
9052 of objects (Bug#8318).
9053
9054 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9055 that could (at least in theory) be that large.
9056
9057 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9058 This is less likely to overflow, and avoids undefined behavior if
9059 overflow does occur. All callers changed. Use strtoul to scan
9060 for the unsigned long integer.
9061 (pint2hrstr): Simplify and tune code slightly.
9062 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9063
9064 * scroll.c (do_scrolling): Work around GCC bug 48228.
9065 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9066
9067 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9068 This also avoids a warning with gcc -Wstrict-overflow.
9069 (validate_x_resource_name): Simplify count usage.
9070 This also avoids a warning with gcc -Wstrict-overflow.
9071
9072 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9073 fail (Bug#8306).
9074
9075 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9076
9077 * process.c (Fmake_network_process): Use socklen_t, not int,
9078 where POSIX says socklen_t is required in portable programs.
9079 This fixes a porting bug on hosts like 64-bit HP-UX, where
9080 socklen_t is wider than int (Bug#8277).
9081 (Fmake_network_process, server_accept_connection):
9082 (wait_reading_process_output, read_process_output):
9083 Likewise.
9084
9085 * process.c: Rename or move locals to avoid shadowing.
9086 (list_processes_1, Fmake_network_process):
9087 (read_process_output_error_handler, exec_sentinel_error_handler):
9088 Rename or move locals.
9089 (Fmake_network_process): Define label "retry_connect" only if needed.
9090 (Fnetwork_interface_info): Fix pointer signedness.
9091 (process_send_signal): Add cast to avoid pointer signedness problem.
9092 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9093 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9094
9095 Make tparam.h and terminfo.c consistent.
9096 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9097 Include tparam.h instead, since it declares them.
9098 * cm.h (PC): Remove extern decl; tparam.h now does this.
9099 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9100 * terminfo.c: Include tparam.h, to check interfaces.
9101 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9102 (tparam): Adjust signature to match interface in tparam.h;
9103 this removes some undefined behavior. Check that outstring and len
9104 are zero, which they always are with Emacs.
9105 * tparam.h (PC, BC, UP): New extern decls.
9106
9107 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9108 (xftfont_open): Rename locals to avoid shadowing.
9109
9110 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9111 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9112 (OTF_TAG_SYM): Omit macro if not needed.
9113 (ftfont_list): Remove unused local.
9114 (get_adstyle_property, ftfont_pattern_entity):
9115 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9116 Rename locals to avoid shadowing.
9117
9118 * xfont.c (xfont_list_family): Mark var as initialized.
9119
9120 * xml.c (make_dom): Now static.
9121
9122 * composite.c (composition_compute_stop_pos): Rename local to
9123 avoid shadowing.
9124 (composition_reseat_it): Remove unused locals.
9125 (find_automatic_composition, composition_adjust_point): Likewise.
9126 (composition_update_it): Mark var as initialized.
9127 (find_automatic_composition): Mark vars as initialized,
9128 with a FIXME (Bug#8290).
9129
9130 character.h: Rename locals to avoid shadowing.
9131 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9132 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9133 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9134 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9135 to avoid shadowing.
9136
9137 * textprop.c (property_change_between_p): Remove; unused.
9138
9139 * intervals.c (interval_start_pos): Now static.
9140
9141 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9142
9143 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9144 Rename locals to avoid shadowing.
9145
9146 * sound.c (wav_play, au_play, Fplay_sound_internal):
9147 Fix pointer signedness.
9148 (alsa_choose_format): Remove unused local var.
9149 (wav_play): Initialize a variable to 0, to prevent undefined
9150 behavior (Bug#8278).
9151
9152 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9153
9154 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9155
9156 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9157 clobbering (Bug#8298).
9158 * sysdep.c (sys_subshell): Likewise.
9159 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9160
9161 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9162 This should get cleaned up, so that child_setup has the
9163 same signature on all platforms.
9164
9165 * callproc.c (call_process_cleanup): Now static.
9166 (relocate_fd): Rename locals to avoid shadowing.
9167
91682011-03-22 Chong Yidong <cyd@stupidchicken.com>
9169
9170 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9171 not to be necessary, and produces flickering.
9172
91732011-03-20 Glenn Morris <rgm@gnu.org>
9174
9175 * config.in: Remove file.
9176
91772011-03-20 Juanma Barranquero <lekktu@gmail.com>
9178
9179 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9180 are now in src/globals.h.
9181 (syms_of_minibuf): Remove spurious & from previous change.
9182
91832011-03-20 Leo Liu <sdl.web@gmail.com>
9184
9185 * minibuf.c (completing-read-function): New variable.
9186 (completing-read-default): Rename from completing-read.
9187 (completing-read): Call completing-read-function.
9188
91892011-03-19 Juanma Barranquero <lekktu@gmail.com>
9190
9191 * xfaces.c (Fx_load_color_file):
9192 Read color file from absolute filename (bug#8250).
9193
91942011-03-19 Juanma Barranquero <lekktu@gmail.com>
9195
9196 * makefile.w32-in: Update dependencies.
9197
91982011-03-17 Eli Zaretskii <eliz@gnu.org>
9199
9200 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9201
92022011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9203
9204 Fix more problems found by GCC 4.5.2's static checks.
9205
9206 * process.c (make_serial_process_unwind, send_process_trap):
9207 (sigchld_handler): Now static.
9208
9209 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9210 That way, the code declares only the vars that it needs.
9211 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9212 * s/cygwin.h (PTY_ITERATION): Likewise.
9213 * s/darwin.h (PTY_ITERATION): Likewise.
9214 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9215
9216 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9217 * process.c (allocate_pty): Don't declare stb unless it's needed.
9218
9219 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9220 (CONSTANTLIM): Remove; unused.
9221 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9222 Define only if needed.
9223
9224 * unexelf.c (unexec): Name an expression,
9225 to avoid gcc -Wbad-function-cast warning.
9226 Use a different way to cause a compilation error if anyone uses
9227 n rather than nn, a way that does not involve shadowing.
9228 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9229
9230 * deps.mk (unexalpha.o): Remove; unused.
9231
9232 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9233 * unexec.h: New file.
9234 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9235 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9236 Depend on unexec.h.
9237 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9238 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9239 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9240 Change as necessary to match prototype in unexec.h.
9241
9242 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9243 shadowing.
9244 (back_comment, skip_chars): Mark vars as initialized.
9245
9246 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9247 Rename locals to avoid shadowing.
9248
9249 * lread.c (read1): Rewrite so as not to use empty "else".
9250 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9251
9252 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9253
9254 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9255 warning when compiling print.c.
9256
9257 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9258 instead of using an uninitialized var.
9259 (font_sort_entities): Mark var as initialized.
9260
9261 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9262
9263 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9264 pointers to constants.
9265 (font_parse_fcname): Remove unused vars.
9266 (font_delete_unmatched): Now static.
9267 (font_get_spec): Remove; unused.
9268 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9269 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9270 Rename or move locals to avoid shadowing.
9271
9272 * fns.c (require_nesting_list, require_unwind): Now static.
9273 (Ffillarray): Rename locals to avoid shadowing.
9274
9275 * floatfns.c (domain_error2): Define only if needed.
9276 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9277
9278 * alloc.c (mark_backtrace): Move decl from here ...
9279 * lisp.h: ... to here, so that it can be checked.
9280
9281 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9282 (Fdefvar): Rewrite so as not to use empty "else".
9283 (lisp_indirect_variable): Name an expression,
9284 to avoid gcc -Wbad-function-cast warning.
9285 (Fdefvar): Rename locals to avoid shadowing.
9286
9287 * callint.c (quotify_arg, quotify_args): Now static.
9288 (Fcall_interactively): Rename locals to avoid shadowing.
9289 Use const pointer when appropriate.
9290
9291 * lisp.h (get_system_name, get_operating_system_release):
9292 Move decls here, to check interfaces.
9293 * process.c (get_operating_system_release): Move decl to lisp.h.
9294 * xrdb.c (get_system_name): Likewise.
9295 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9296 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9297 some of which prompt warnings from gcc -Wbad-function-cast.
9298 (Fformat_time_string, Fencode_time, Finsert_char):
9299 (Ftranslate_region_internal, Fformat):
9300 Rename or remove local vars to avoid shadowing.
9301 (Ftranslate_region_internal): Mark var as initialized.
9302
9303 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9304 avoid shadowing.
9305
9306 * lisp.h (eassert): Check that the argument compiles, even if
9307 ENABLE_CHECKING is not defined.
9308
9309 * data.c (Findirect_variable): Name an expression, to avoid
9310 gcc -Wbad-function-cast warning.
9311 (default_value, arithcompare, arith_driver, arith_error): Now static.
9312 (store_symval_forwarding): Rename local to avoid shadowing.
9313 (Fmake_variable_buffer_local, Fmake_local_variable):
9314 Mark variables as initialized.
9315 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9316
9317 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9318 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9319 Rename locals to avoid shadowing.
9320 (mark_stack): Move local variables into the #ifdef region where
9321 they're used.
9322 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9323 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9324 needed otherwise.
9325 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9326 (GC_STRING_CHARS): Remove; not used.
9327 (Fmemory_limit): Cast sbrk's returned value to char *.
9328
9329 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9330 avoids undefined behavior in theory.
9331
9332 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9333
9334 Use functions, not macros, for up- and down-casing (Bug#8254).
9335 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9336 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9337 to use the following functions instead of these macros.
9338 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9339 EMACS_INT, since callers assume the returned value fits in int.
9340 (upcase1): Likewise, for UPCASE_TABLE.
9341 (uppercasep, lowercasep, upcase): New static inline functions.
9342 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9343 the race-condition problem in the old DOWNCASE.
9344
9345 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9346 Rename locals to avoid shadowing.
9347 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9348 (regex_compile, re_search_2, re_match_2_internal):
9349 Remove unused local vars.
9350 (FREE_VAR): Rewrite so as not to use empty "else",
9351 which gcc can warn about.
9352 (regex_compile, re_match_2_internal): Mark locals as initialized.
9353 (RETALLOC_IF): Define only if needed.
9354 (WORDCHAR_P): Likewise. This one is never needed, but is used
9355 only in a comment talking about a compiler bug, so put inside
9356 the #if 0 of that comment.
9357 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9358 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9359 Remove; unused.
9360
9361 * search.c (boyer_moore): Rename locals to avoid shadowing.
9362 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9363 (PREV_CHAR_BOUNDARY): Likewise.
9364
9365 * search.c (simple_search): Remove unused var.
9366
9367 * dired.c (compile_pattern): Move decl from here ...
9368 * lisp.h: ... to here, so that it can be checked.
9369 (struct re_registers): New forward decl.
9370
9371 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9372
9373 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9374 All uses changed.
9375 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9376 Rename locals to avoid shadowing.
9377 (Fvertical_motion): Mark locals as initialized.
9378
9379 * casefiddle.c (casify_object, casify_region): Now static.
9380 (casify_region): Mark local as initialized.
9381
9382 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9383
9384 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9385 New macros, so that the caller can use some names other than
9386 gcpro1, gcpro2, etc.
9387 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9388 of the new macros.
9389 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9390 argument, for consistency with GCPRO2_VAR, etc: it is now the
9391 prefix of the variable, not the variable itself. All uses
9392 changed.
9393 * dired.c (directory_files_internal, file_name_completion):
9394 Rename locals to avoid shadowing.
9395
9396 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9397 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9398 dired.c's scmp function, had undefined behavior.
9399 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9400 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9401 * buffer.h: ... to here, because these macros use current_buffer,
9402 and the new implementation with inline functions needs to have
9403 current_buffer in scope now, rather than later when the macros
9404 are used.
9405 (downcase, upcase1): New static inline functions.
9406 (DOWNCASE, UPCASE1): Reimplement using these functions.
9407 This avoids undefined behavior in expressions like
9408 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9409 from race conditions in accessing the global variables
9410 case_temp1 and case_temp2.
9411 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9412 * lisp.h (case_temp1, case_temp2): Remove their decls.
9413 * character.h (ASCII_CHAR_P): Move from here ...
9414 * lisp.h: ... to here, so that the inline functions mentioned
9415 above can use them.
9416
9417 * dired.c (directory_files_internal_unwind): Now static.
9418
9419 * fileio.c (file_name_as_directory, directory_file_name):
9420 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9421 Now static.
9422 (file_name_as_directory): Use const pointers when appropriate.
9423 (Fexpand_file_name): Likewise. In particular, newdir might
9424 point at constant storage, so make it a const pointer.
9425 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9426 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9427 signedness issues.
9428 (Fset_file_times, Finsert_file_contents, auto_save_error):
9429 Rename locals to avoid shadowing.
9430
9431 * minibuf.c (choose_minibuf_frame_1): Now static.
9432 (Ftry_completion, Fall_completions): Rename or remove locals
9433 to avoid shadowing.
9434
9435 * marker.c (bytepos_to_charpos): Remove; unused.
9436
9437 * lisp.h (verify_bytepos, count_markers): New decls,
9438 so that gcc does not warn that these functions aren't declared.
9439
9440 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9441 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9442 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9443 (copy_text): Remove unused local var.
9444
9445 * filelock.c (within_one_second): Now static.
9446 (lock_file_1): Rename local to avoid shadowing.
9447
9448 * buffer.c (fix_overlays_before): Mark locals as initialized.
9449 (fix_start_end_in_overlays): Likewise. This function should be
9450 simplified by using pointers-to-pointers, but that's a different
9451 matter.
9452 (switch_to_buffer_1): Now static.
9453 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9454 (report_overlay_modification): Rename locals to avoid shadowing.
9455
9456 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9457 Fix pointer signedness issue.
9458 (sys_subshell): Mark local as volatile if checking for lint,
9459 to suppress a gcc -Wclobbered warning that does not seem to be right.
9460 (MAXPATHLEN): Define only if needed.
9461
9462 * process.c (serial_open, serial_configure): Move decls from here ...
9463 * systty.h: ... to here, so that they can be checked.
9464
9465 * fns.c (get_random, seed_random): Move extern decls from here ...
9466 * lisp.h: ... to here, so that they can be checked.
9467
9468 * sysdep.c (reset_io): Now static.
9469 (wait_for_termination_signal): Remove; unused.
9470
9471 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9472 (copy_keymap_item, append_key, push_text_char_description):
9473 Now static.
9474 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9475 (DENSE_TABLE_SIZE): Remove; unused.
9476 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9477 (describe_map_tree):
9478 Rename locals to avoid shadowing.
9479
9480 * keyboard.c: Declare functions static if they are not used elsewhere.
9481 (echo_char, echo_dash, cmd_error, top_level_2):
9482 (poll_for_input, handle_async_input): Now static.
9483 (read_char, kbd_buffer_get_event, make_lispy_position):
9484 (make_lispy_event, make_lispy_movement, apply_modifiers):
9485 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9486 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9487 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9488 (read_key_sequence, read_char): Mark locals as initialized.
9489 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9490
9491 * keyboard.h (make_ctrl_char): New decl.
9492 (mark_kboards): Move decl here ...
9493 * alloc.c (mark_kboards): ... from here.
9494
9495 * lisp.h (force_auto_save_soon): New decl.
9496
9497 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9498 (DEFINE_DUMMY_FUNCTION): New macro.
9499 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9500 Use it.
9501 (main): Add casts to avoid warnings
9502 if GCC considers string literals to be constants.
9503
9504 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9505
9506 * dbusbind.c: Pointer signedness fixes.
9507 (xd_signature, xd_append_arg, xd_initialize):
9508 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9509 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9510 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9511 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9512
9513 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9514 if GCC considers string literals to be constants.
9515 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9516
95172011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9518
9519 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9520 (print_preprocess, print_object): New macro to fix last change.
9521
9522 * print.c (print_preprocess): Don't forget font objects.
9523
95242011-03-16 Juanma Barranquero <lekktu@gmail.com>
9525
9526 * emacs.c (USAGE3): Doc fixes.
9527
95282011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9529
9530 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9531 structure.
9532
95332011-03-14 Juanma Barranquero <lekktu@gmail.com>
9534
9535 * lisp.h (VWindow_system, Qfile_name_history):
9536 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9537 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9538 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9539
9540 * w32select.c: Don't #include "keyboard.h".
9541 (run_protected): Add extern declaration for waiting_for_input.
9542
9543 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9544 * w32console.c (detect_input_pending, read_input_pending)
9545 (encode_terminal_code):
9546 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9547 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9548 (w32_system_caret_y, Qfile_name_history):
9549 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9550 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9551 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9552 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9553 * w32proc.c (Qlocal, report_file_error):
9554 * w32term.c (Vwindow_system, updating_frame):
9555 * w32uniscribe.c (initialized, uniscribe_font_driver):
9556 Remove unneeded extern declarations.
9557
95582011-03-14 Chong Yidong <cyd@stupidchicken.com>
9559
9560 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9561
95622011-03-13 Chong Yidong <cyd@stupidchicken.com>
9563
9564 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9565 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9566 These macros can no longer be used for assignment.
9567
9568 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9569 Assign struct members directly, instead of using BUF_BEGV etc.
9570 (record_buffer_markers, fetch_buffer_markers): New functions for
9571 recording and fetching special buffer markers.
9572 (set_buffer_internal_1, set_buffer_temp): Use them.
9573
9574 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9575
9576 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9577
9578 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9579 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9580
9581 * xdisp.c (hscroll_window_tree):
9582 (reconsider_clip_changes): Use PT instead of BUF_PT.
9583
95842011-03-13 Eli Zaretskii <eliz@gnu.org>
9585
9586 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9587 $(EMACS_ROOT)/lib/intprops.h.
9588
95892011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9590
9591 Fix more problems found by GCC 4.5.2's static checks.
9592
9593 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9594 to unsigned char * to avoid compiler diagnostic.
9595 (xg_free_frame_widgets): Make it clear that a local variable is
9596 needed only if USE_GTK_TOOLTIP.
9597 (gdk_window_get_screen): Make it clear that this macro is needed
9598 only if USE_GTK_TOOLTIP.
9599 (int_gtk_range_get_value): New function, which avoids a diagnostic
9600 from gcc -Wbad-function-cast.
9601 (xg_set_toolkit_scroll_bar_thumb): Use it.
9602 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9603 diagnostic from gcc -Wbad-function-cast.
9604 (get_utf8_string, xg_get_file_with_chooser):
9605 Rename locals to avoid shadowing.
9606 (create_dialog): Move locals to avoid shadowing.
9607
9608 * xgselect.c (xg_select): Remove unused var.
9609
9610 * image.c (four_corners_best): Mark locals as initialized.
9611 (gif_load): Initialize transparent_p to zero (Bug#8238).
9612 Mark another local as initialized.
9613 (my_png_error, my_error_exit): Mark with NO_RETURN.
9614
9615 * image.c (clear_image_cache): Now static.
9616 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9617 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9618 (x_edge_detection): Remove unnecessary cast that
9619 gcc -Wbad-function-cast diagnoses.
9620 (gif_load): Fix pointer signedness.
9621 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9622 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9623
96242011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9625
9626 Improve quality of tests for time stamp overflow.
9627 For example, without this patch (encode-time 0 0 0 1 1
9628 1152921504606846976) returns the obviously-bogus value (-948597
9629 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9630 reports time overflow. See
9631 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9632 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9633 * editfns.c: Include limits.h and intprops.h.
9634 (TIME_T_MIN, TIME_T_MAX): New macros.
9635 (time_overflow): Move earlier, to before first use.
9636 (hi_time, lo_time): New functions, for an accurate test for
9637 out-of-range times.
9638 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9639 (Fget_internal_run_time): Don't assume time_t fits in int.
9640 (make_time): Use list2 instead of Fcons twice.
9641 (Fdecode_time): More accurate test for out-of-range times.
9642 (check_tm_member): New function.
9643 (Fencode_time): Use it, to test for out-of-range times.
9644 (lisp_time_argument): Don't rely on undefined left-shift and
9645 right-shift behavior when checking for time stamp overflow.
9646
9647 * editfns.c (time_overflow): New function, refactoring common code.
9648 (Fformat_time_string, Fdecode_time, Fencode_time):
9649 (Fcurrent_time_string): Use it.
9650
9651 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9652 * dired.c (make_time): Move to ...
9653 * editfns.c (make_time): ... here.
9654 * systime.h: Note the move.
9655
96562011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9657
9658 * fringe.c (update_window_fringes): Remove unused variables.
9659
9660 * unexmacosx.c (copy_data_segment): Also copy __got section.
9661 (Bug#8223)
9662
96632011-03-12 Eli Zaretskii <eliz@gnu.org>
9664
9665 * termcap.c [MSDOS]: Include "msdos.h".
9666 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9667 Constify `char *' arguments and their references according to
9668 prototypes in tparam.h.
9669
9670 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9671
9672 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9673 Adapt all references accordingly.
9674
9675 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9676
96772011-03-11 Tom Tromey <tromey@redhat.com>
9678
9679 * buffer.c (syms_of_buffer): Remove obsolete comment.
9680
96812011-03-11 Eli Zaretskii <eliz@gnu.org>
9682
9683 * termhooks.h (encode_terminal_code): Declare prototype.
9684
9685 * msdos.c (encode_terminal_code): Don't declare prototype.
9686
9687 * term.c (encode_terminal_code): Now external again, used by
9688 w32console.c and msdos.c.
9689
9690 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9691 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9692
96932011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9694
9695 Fix some minor problems found by GCC 4.5.2's static checks.
9696
9697 * fringe.c (update_window_fringes): Mark locals as initialized
9698 (Bug#8227).
9699 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9700
9701 * alloc.c (mark_fringe_data): Move decl from here ...
9702 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9703 to check its interface.
9704 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9705
9706 * fontset.c (free_realized_fontset): Now static.
9707 (Fset_fontset_font): Rename local to avoid shadowing.
9708 (fontset_font): Mark local as initialized.
9709 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9710
9711 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9712
9713 * xselect.c (x_disown_buffer_selections): Remove; not used.
9714 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9715 (x_own_selection, Fx_disown_selection_internal): Rename locals
9716 to avoid shadowing.
9717 (x_handle_dnd_message): Remove local to avoid shadowing.
9718
9719 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9720 so that the caller can use some name other than gcpro1.
9721 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9722 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9723 (Fx_backspace_delete_keys_p):
9724 Use them to avoid shadowing, and rename vars to avoid shadowing.
9725 (x_decode_color, x_set_name, x_window): Now static.
9726 (Fx_create_frame): Add braces to silence GCC warning.
9727 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9728 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9729 Remove unused locals.
9730 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9731 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9732 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9733 macros.
9734
9735 * xterm.h (x_mouse_leave): New decl.
9736
9737 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9738 Remove unused functions.
9739 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9740 (x_calc_absolute_position): Now static.
9741 (XTread_socket): Don't define label "out" unless it's used.
9742 Don't declare local "event" unless it's used.
9743 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9744 unless they are used.
9745 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9746 (x_fatal_error_signal): Remove; not used.
9747 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9748 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9749 (x_error_catcher, x_connection_closed, x_error_handler):
9750 (x_error_quitter, xembed_send_message, x_iconify_frame):
9751 (my_log_handler): Rename locals to avoid shadowing.
9752 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9753 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9754
9755 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9756 Rename or move locals to avoid shadowing.
9757 (tty_defined_color, merge_face_heights): Now static.
9758 (free_realized_faces_for_fontset): Remove; not used.
9759 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9760 does not deduce is never used uninitialized.
9761 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9762 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9763
9764 * terminal.c (store_terminal_param): Now static.
9765
9766 * xmenu.c (menu_highlight_callback): Now static.
9767 (set_frame_menubar): Remove unused local.
9768 (xmenu_show): Rename parameter to avoid shadowing.
9769 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9770 since they might point to immutable storage.
9771 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9772 since it's unused otherwise.
9773
9774 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9775 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9776 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9777 avoids a gcc -Wuninitialized diagnostic.
9778 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9779 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9780 does not deduce are never used uninitialized.
9781
9782 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9783
9784 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9785 * window.c (window_loop, size_window):
9786 (run_window_configuration_change_hook, enlarge_window): Likewise.
9787
9788 * window.c (display_buffer): Now static.
9789 (size_window): Mark variables that gcc -Wuninitialized
9790 does not deduce are never used uninitialized.
9791 * window.h (check_all_windows): New decl, to forestall
9792 gcc -Wmissing-prototypes diagnostic.
9793 * dispextern.h (bidi_dump_cached_states): Likewise.
9794
9795 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9796 shadowing.
9797 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9798 Include <limits.h>.
9799 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9800 and to avoid gcc -Wuninitialized warning.
9801 (load_charset_map): Mark variables that gcc -Wuninitialized
9802 does not deduce are never used uninitialized.
9803 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9804
9805 * coding.c (coding_set_source, coding_set_destination):
9806 Use "else { /* comment */ }" rather than "else /* comment */;"
9807 for clarity, and to avoid gcc -Wempty-body warning.
9808 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9809 a block, when the outer 'i' will do.
9810 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9811 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9812 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9813 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9814 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9815 Rename locals to avoid shadowing.
9816 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9817 * coding.c (emacs_mule_char, encode_invocation_designation):
9818 Now static, since they're not used elsewhere.
9819 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9820 (decode_coding_object, encode_coding_object, detect_coding_system):
9821 (decode_coding_emacs_mule): Mark variables that gcc
9822 -Wuninitialized does not deduce are never used uninitialized.
9823 (detect_coding_iso_2022): Initialize a local variable that might
9824 be used uninitialized. Leave a FIXME because it's not clear that
9825 this initialization is needed. (Bug#8211)
9826 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9827 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9828 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9829 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9830 Remove unused macros.
9831
9832 * category.c (hash_get_category_set): Remove unused local var.
9833 (copy_category_table): Now static, since it's not used elsewhere.
9834 * character.c (string_count_byte8): Likewise.
9835
9836 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9837 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9838
9839 * chartab.c (copy_sub_char_table): Now static, since it's not used
9840 elsewhere.
9841 (sub_char_table_ref_and_range, char_table_ref_and_range):
9842 Rename locals to avoid shadowing.
9843 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9844
9845 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9846 (BIDI_BOB): Remove unused macro.
9847
9848 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9849 deduce are never used uninitialized.
9850 * term.c (encode_terminal_code): Likewise.
9851
9852 * term.c (encode_terminal_code): Now static. Remove unused local.
9853
9854 * tparam.h: New file.
9855 * term.c, tparam.h: Include it.
9856 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9857 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9858 Move these decls to tparam.h, and make them agree with what
9859 is actually in tparam.c. The previous trick of using incompatible
9860 decls in different modules does not conform to the C standard.
9861 All callers of tparam changed to use tparam's actual API.
9862 * tparam.c (tparam1, tparam, tgoto):
9863 Use const pointers where appropriate.
9864
9865 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9866 * cm.h (struct cm): Likewise.
9867 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9868 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9869 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9870 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9871 (turn_on_face, init_tty): Likewise.
9872 * termchar.h (struct tty_display_info): Likewise.
9873
9874 * term.c (term_mouse_position): Rename local to avoid shadowing.
9875
9876 * alloc.c (mark_ttys): Move decl from here ...
9877 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9878
98792011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9880
9881 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9882
98832011-03-09 Juanma Barranquero <lekktu@gmail.com>
9884
9885 * search.c (compile_pattern_1): Remove argument regp, unused since
9886 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9887 (compile_pattern): Don't pass it.
9888
98892011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9890
9891 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9892 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9893 for ! HAVE_GTK3.
9894 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9895
9896 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9897
9898 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9899 gdk_window_get_screen, gdk_window_get_geometry,
9900 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9901 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9902 (xg_get_pixbuf_from_pixmap): New function.
9903 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9904 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9905 Call xg_get_pixbuf_from_pixmap instead of
9906 gdk_pixbuf_get_from_drawable.
9907 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9908 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9909 (xg_check_special_colors): Use GtkStyleContext and its functions
9910 for HAVE_GTK3.
9911 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9912 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9913 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9914 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9915 Call gtk_widget_get_preferred_size.
9916 (xg_frame_resized): gdk_window_get_geometry only takes 5
9917 parameters.
9918 (xg_win_to_widget, xg_event_is_for_menubar):
9919 Call gdk_x11_window_lookup_for_display.
9920 (xg_set_widget_bg): New function.
9921 (delete_cb): New function.
9922 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9923 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9924 (xg_set_background_color): Call xg_set_widget_bg.
9925 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9926 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9927 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9928 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9929 if ! HAVE_GTK3.
9930 (update_frame_tool_bar): Call gtk_widget_hide.
9931 (xg_initialize): Use GDK_KEY_g.
9932
9933 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9934 if ! HAVE_GTK3
9935 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9936
9937 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9938 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9939 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9940
99412011-03-08 Juanma Barranquero <lekktu@gmail.com>
9942
9943 * w32xfns.c (select_palette): Check success of RealizePalette against
9944 GDI_ERROR, not zero.
9945
9946See ChangeLog.11 for earlier changes.
9947
9948;; Local Variables:
9949;; coding: utf-8
9950;; End:
9951
9952 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9953
9954 This file is part of GNU Emacs.
9955
9956 GNU Emacs is free software: you can redistribute it and/or modify
9957 it under the terms of the GNU General Public License as published by
9958 the Free Software Foundation, either version 3 of the License, or
9959 (at your option) any later version.
9960
9961 GNU Emacs is distributed in the hope that it will be useful,
9962 but WITHOUT ANY WARRANTY; without even the implied warranty of
9963 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9964 GNU General Public License for more details.
9965
9966 You should have received a copy of the GNU General Public License
9967 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.