* chartab.c: Use similar style as for other recent patches.
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12011-04-09 Paul Eggert <eggert@cs.ucla.edu>
2
3 * charset.c (load_charset_map): <, not <=, for optimization.
4 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5 * casetab.c (set_identity, shuffle): Likewise.
6
7 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8 This also lets GCC 4.6.0 generate slightly better loop code.
9
10 * callint.c (Fcall_interactively): <, not <=, for optimization.
11 (Fcall_interactively): Count the number of arguments produced,
12 not the number of arguments given. This is simpler and lets GCC
13 4.6.0 generate slightly better code.
14
15 * ftfont.c: Distingish more carefully between FcChar8 and char.
16 The previous code passed unsigned char * to a functions like
17 strlen and xstrcasecmp that expect char *, which does not
18 conform to the C standard.
19 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
20 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
21 char * when the C standard requires it.
22
23 * keyboard.c (read_char): Remove unused var.
24
25 * eval.c: Port to Windows vsnprintf (Bug#8435).
26 Include <limits.h>.
27 (SIZE_MAX): Define if the headers do not.
28 (verror): Do not give up if vsnprintf returns a negative count.
29 Instead, grow the buffer. This ports to Windows vsnprintf, which
30 does not conform to C99. Problem reported by Eli Zaretskii.
31 Also, simplify the allocation scheme, by avoiding the need for
32 calling realloc, and removing the ALLOCATED variable.
33
34 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
35
36 Remove the doprnt implementation, as Emacs now uses vsnprintf.
37 * doprnt.c: Remove.
38 * lisp.h (doprnt): Remove.
39 * Makefile.in (base_obj): Remove doprnt.o.
40 * deps.mk (doprnt.o): Remove.
41
42 error: Print 32- and 64-bit integers portably (Bug#8435).
43 Without this change, on typical 64-bit hosts error ("...%d...", N)
44 was used to print both 32- and 64-bit integers N, which relied on
45 undefined behavior.
46 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
47 New macro.
48 * lisp.h (error, verror): Mark as printf-like functions.
49 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
50 Report overflow in size calculations when allocating printf buffer.
51 Do not truncate output string at its first null byte.
52 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
53 Truncate the output at a character boundary, since vsnprintf does not
54 do that.
55 * charset.c (check_iso_charset_parameter): Convert internal
56 character to string before calling 'error', since %c now has the
57 printf meaning.
58 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
59 overflow when computing char to be passed to 'error'. Do not
60 pass Lisp_Object to 'error'; pass the integer instead.
61 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
62 formatted with plain %d.
63
64 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
65
66 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
67
68 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
69
70 * xterm.c (x_catch_errors): Remove duplicate declaration.
71
72 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
73
74 * xdisp.c, lisp.h (message_nolog): Remove; unused.
75
762011-04-09 Chong Yidong <cyd@stupidchicken.com>
77
78 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
79 unsigned char, to match FcChar8 type definition.
80
81 * xterm.c (handle_one_xevent):
82 * xmenu.c (create_and_show_popup_menu):
83 * xselect.c (x_decline_selection_request)
84 (x_reply_selection_request): Avoid type-punned deref of X events.
85
862011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
87
88 Fix some uses of `int' instead of EMACS_INT.
89 * search.c (string_match_1, fast_string_match)
90 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
91 (scan_buffer, find_next_newline_no_quit)
92 (find_before_next_newline, search_command, Freplace_match)
93 (Fmatch_data): Make some `int' variables be EMACS_INT.
94
95 * xdisp.c (display_count_lines): 3rd argument and return value now
96 EMACS_INT. All callers changed.
97 (pint2hrstr): Last argument is now EMACS_INT.
98
99 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
100 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
101 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
102 (decode_coding_utf_16, decode_coding_emacs_mule)
103 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
104 (decode_coding_ccl, decode_coding_charset)
105 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
106 (decode_coding_iso_2022, decode_coding_emacs_mule)
107 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
108 <char_offset, last_offset>: Declare EMACS_INT.
109 (encode_coding_utf_8, encode_coding_utf_16)
110 (encode_coding_emacs_mule, encode_invocation_designation)
111 (encode_designation_at_bol, encode_coding_iso_2022)
112 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
113 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
114 Declare EMACS_INT.
115 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
116 (encode_invocation_designation): Last argument P_NCHARS is now
117 EMACS_INT.
118 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
119 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
120
121 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
122 All users changed.
123
124 * ccl.c (Fccl_execute_on_string): Declare some variables
125 EMACS_INT.
126
1272011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
128
129 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
130
1312011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
132
133 * process.c (Fformat_network_address): Doc fix.
134
1352011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
136
137 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
138
1392011-04-08 Chong Yidong <cyd@stupidchicken.com>
140
141 * keyboard.c (read_char): Call Lisp function help-form-show,
142 instead of using internal_with_output_to_temp_buffer.
143 (Qhelp_form_show): New var.
144 (syms_of_keyboard): Use DEFSYM macro.
145
146 * print.c (internal_with_output_to_temp_buffer): Function deleted.
147
148 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
149
1502011-04-06 Chong Yidong <cyd@stupidchicken.com>
151
152 * process.c (Flist_processes): Removed to Lisp.
153 (list_processes_1): Deleted.
154
1552011-04-06 Eli Zaretskii <eliz@gnu.org>
156
157 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
158
159 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
160
1612011-04-06 Paul Eggert <eggert@cs.ucla.edu>
162
163 Fix more problems found by GCC 4.6.0's static checks.
164
165 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
166
167 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
168
169 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
170
171 * xdisp.c (vmessage): Mark as a printf-like function.
172
173 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
174
175 * sound.c (sound_warning): Don't crash if arg contains a printf format.
176
177 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
178 printf-like functions.
179 (tiff_load): Add casts to remove these marks before passing them
180 to system-supplied API.
181
182 * eval.c (Fsignal): Remove excess argument to 'fatal'.
183
184 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
185 This avoids several warnings with gcc -Wstrict-overflow.
186 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
187 directly, rather than having caller test rule sign. This avoids
188 some unnecessary tests.
189 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
190 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
191 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
192
193 * xfont.c (xfont_text_extents): Remove var that was set but not used.
194 (xfont_open): Avoid unnecessary tests.
195
196 * composite.c (composition_gstring_put_cache): Use unsigned integer.
197
198 * composite.h, composite.c (composition_gstring_put_cache):
199 Use EMACS_INT, not int, for length.
200
201 * composite.h (COMPOSITION_DECODE_REFS): New macro,
202 breaking out part of COMPOSITION_DECODE_RULE.
203 (COMPOSITION_DECODE_RULE): Use it.
204 * composite.c (get_composition_id): Remove unused local vars,
205 by using the new macro.
206
207 * textprop.c (set_text_properties_1): Change while to do-while,
208 since the condition is always true at first.
209
210 * intervals.c (graft_intervals_into_buffer): Mark var as used.
211 (interval_deletion_adjustment): Return unsigned value.
212 All uses changed.
213
214 * process.c (list_processes_1, create_pty, read_process_output):
215 (exec_sentinel): Remove vars that were set but not used.
216 (create_pty): Remove unnecessary "volatile"s.
217 (Fnetwork_interface_info): Avoid possibility of int overflow.
218 (read_process_output): Do adaptive read buffering even if carryover.
219 (read_process_output): Simplify nbytes computation if buffered.
220
221 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
222
223 * syntax.c (scan_words): Remove var that was set but not used.
224 (update_syntax_table): Use unsigned instead of int.
225
226 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
227 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
228 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
229
230 * print.c (print_error_message): Avoid int overflow.
231
232 * font.c (font_list_entities): Redo for clarity,
233 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
234
235 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
236 (font_score): Avoid potential overflow in diff calculation.
237
238 * fns.c (substring_both): Remove var that is set but not used.
239 (sxhash): Redo loop for clarity and to avoid wraparound warning.
240
241 * eval.c (funcall_lambda): Rename local to avoid shadowing.
242
243 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
244 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
245 can always succeed if overflow has undefined behavior.
246
247 * search.c (boyer_moore, wordify): Remove vars set but not used.
248 (wordify): Omit three unnecessary tests.
249
250 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
251 All callers changed. This avoids the need for an unused var.
252
253 * casefiddle.c (casify_region): Remove var that is set but not used.
254
255 * dired.c (file_name_completion): Remove var that is set but not used.
256
257 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
258
259 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
260 (Finsert_file_contents): Remove unnecessary code checking fd.
261
262 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
263 Check for integer overflow on size calculations.
264
265 * buffer.c (Fprevious_overlay_change): Remove var that is set
266 but not used.
267
268 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
269 Remove vars that are set but not used.
270 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
271 (timer_check_2): Mark vars as initialized.
272
273 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
274
275 * image.c (lookup_image): Remove var that is set but not used.
276 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
277
278 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
279 that are set but not used.
280
281 * xfns.c (make_invisible_cursor): Don't return garbage
282 if XCreateBitmapFromData fails (Bug#8410).
283
284 * xselect.c (x_get_local_selection, x_handle_property_notify):
285 Remove vars that are set but not used.
286
287 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
288 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
289
290 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
291 Remove var that is set but not used.
292 (scroll_bar_windows_size): Now size_t, not int.
293 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
294 Check for overflow.
295
296 * xfaces.c (realize_named_face): Remove vars that are set but not used.
297 (map_tty_color) [!defined MSDOS]: Likewise.
298
299 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
300
301 * coding.c: Remove vars that are set but not used.
302 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
303 All callers changed.
304 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
305 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
306 (decode_coding_charset): Remove vars that are set but not used.
307
308 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
309 that is set but not used.
310
311 * print.c (print_object): Remove var that is set but not used.
312
313 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
314 The gnulib version avoids calling malloc in the usual case,
315 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
316 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
317 * filelock.c (current_lock_owner): Likewise.
318 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
319 * sysdep.c: Include allocator.h, careadlinkat.h.
320 (emacs_no_realloc_allocator): New static constant.
321 (emacs_readlink): New function.
322 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
323 ../lib/careadlinkat.h.
324
3252011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
326
327 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
328 first non-nil return value).
329
3302011-04-03 Jan Djärv <jan.h.d@swipnet.se>
331
332 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
333 if not defined (Bug#8403).
334
3352011-04-02 Juanma Barranquero <lekktu@gmail.com>
336
337 * xdisp.c (display_count_lines): Remove parameter `start',
338 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
339 (get_char_face_and_encoding): Remove parameter `multibyte_p',
340 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
341 (fill_stretch_glyph_string): Remove parameters `row' and `area',
342 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
343 and thereabouts. All callers changed.
344 (get_per_char_metric): Remove parameter `f', unused since
345 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
346
3472011-04-02 Jim Meyering <meyering@redhat.com>
348
349 do not dereference NULL upon failed strdup
350 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
351 (ns_get_family): Likewise.
352
3532011-04-02 Juanma Barranquero <lekktu@gmail.com>
354
355 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
356
3572011-04-02 Jan Djärv <jan.h.d@swipnet.se>
358
359 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
360 later (Bug#8403).
361
3622011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
363
364 Add lexical binding.
365
366 * window.c (Ftemp_output_buffer_show): New fun.
367 (Fsave_window_excursion):
368 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
369
370 * lread.c (lisp_file_lexically_bound_p): New function.
371 (Fload): Bind Qlexical_binding.
372 (readevalloop): Remove `evalfun' arg.
373 Bind Qinternal_interpreter_environment.
374 (Feval_buffer): Bind Qlexical_binding.
375 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
376 Mark as dynamic.
377 (syms_of_lread): Declare `lexical-binding'.
378
379 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
380
381 * keyboard.c (eval_dyn): New fun.
382 (menu_item_eval_property): Use it.
383
384 * image.c (parse_image_spec): Use Ffunctionp.
385
386 * fns.c (concat, mapcar1): Accept byte-code-functions.
387
388 * eval.c (Fsetq): Handle lexical vars.
389 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
390 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
391 (FletX, Flet): Obey lexical binding.
392 (Fcommandp): Handle closures.
393 (Feval): New `lexical' arg.
394 (eval_sub): New function extracted from Feval. Use it almost
395 everywhere where Feval was used. Look up vars in lexical env.
396 Handle closures.
397 (Ffunctionp): Move from subr.el.
398 (Ffuncall): Handle closures.
399 (apply_lambda): Remove `eval_flags'.
400 (funcall_lambda): Handle closures and new byte-code-functions.
401 (Fspecial_variable_p): New function.
402 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
403 but without exporting it to Lisp.
404
405 * doc.c (Fdocumentation, store_function_docstring):
406 * data.c (Finteractive_form): Handle closures.
407
408 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
409 interactive spec.
410
411 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
412 byte-codes.
413 (exec_byte_code): New function extracted from Fbyte_code to handle new
414 calling convention for byte-code-functions. Add new byte-codes.
415
416 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
417
418 * alloc.c (Fmake_symbol): Init new `declared_special' field.
419
4202011-03-31 Juanma Barranquero <lekktu@gmail.com>
421
422 * xdisp.c (redisplay_internal): Fix prototype.
423
4242011-03-31 Eli Zaretskii <eliz@gnu.org>
425
426 * xdisp.c (SCROLL_LIMIT): New macro.
427 (try_scrolling): Use it when setting scroll_limit. Limit
428 scrolling to 100 screen lines.
429 (redisplay_window): Even when falling back on "recentering",
430 position point in the window according to scroll-conservatively,
431 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
432
433 (try_scrolling): When point is above the window, allow searching
434 as far as scroll_max, or one screenful, to compute vertical
435 distance from PT to the scroll margin position. This prevents
436 try_scrolling from unnecessarily failing when
437 scroll-conservatively is set to a value slightly larger than the
438 window height. Clean up the case of PT below the margin at bottom
439 of window: scroll_max can no longer be INT_MAX. When aggressive
440 scrolling is in use, don't let point enter the opposite scroll
441 margin as result of the scroll.
442 (syms_of_xdisp) <scroll-conservatively>: Document the
443 threshold of 100 lines for never-recentering scrolling.
444
4452011-03-31 Juanma Barranquero <lekktu@gmail.com>
446
447 * dispextern.h (move_it_by_lines):
448 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
449 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
450 (message_log_check_duplicate): Remove parameters `prev_bol' and
451 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
452 (redisplay_internal): Remove parameter `preserve_echo_area',
453 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
454
455 * indent.c (Fvertical_motion):
456 * window.c (window_scroll_pixel_based, Frecenter):
457 Don't pass `need_y_p' to `move_it_by_lines'.
458
4592011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
460
461 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
462 steal a few bits to be more compact.
463 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
464 Remove unneeded casts.
465
466 * bytecode.c (Fbyte_code): CAR and CDR can GC.
467
4682011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
469
470 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
471 binding" message (bug#7967).
472
4732011-03-30 Paul Eggert <eggert@cs.ucla.edu>
474
475 Fix more problems found by GCC 4.6.0's static checks.
476
477 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
478 Remove unused local var.
479
480 * editfns.c (Fmessage_box): Remove unused local var.
481
482 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
483 (note_mode_line_or_margin_highlight, note_mouse_highlight):
484 Omit unused local vars.
485 * window.c (shrink_windows): Omit unused local var.
486 * menu.c (digest_single_submenu): Omit unused local var.
487 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
488 Omit unused local var.
489
490 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
491 Don't assume string length fits in int.
492 (keyremap_step, read_key_sequence): Use size_t for sizes.
493 (read_key_sequence): Don't check last_real_key_start redundantly.
494
495 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
496 instead of alloca (Bug#8344).
497
498 * eval.c (Fbacktrace): Don't assume nargs fits in int.
499 (Fbacktrace_frame): Don't assume nframes fits in int.
500
501 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
502
503 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
504 concerns.
505
506 * term.c (produce_glyphless_glyph): Remove unnecessary test.
507
508 * cm.c (calccost): Turn while-do into do-while, for clarity.
509
510 * keyboard.c (syms_of_keyboard): Use the same style as later
511 in this function when indexing through an array. This also
512 works around GCC bug 48267.
513
514 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
515
516 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
517
518 * chartab.c (sub_char_table_ref_and_range): Redo for slight
519 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
520
521 * keyboard.c, keyboard.h (num_input_events): Now size_t.
522 This avoids undefined behavior on integer overflow, and is a bit
523 more convenient anyway since it is compared to a size_t variable.
524
525 Variadic C functions now count arguments with size_t, not int.
526 This avoids an unnecessary limitation on 64-bit machines, which
527 caused (substring ...) to crash on large vectors (Bug#8344).
528 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
529 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
530 All variadic functions and their callers changed accordingly.
531 (struct gcpro.nvars): Now size_t, not int. All uses changed.
532 * data.c (arith_driver, float_arith_driver): Likewise.
533 * editfns.c (general_insert_function): Likewise.
534 * eval.c (struct backtrace.nargs, interactive_p)
535 (internal_condition_case_n, run_hook_with_args, apply_lambda)
536 (funcall_lambda, mark_backtrace): Likewise.
537 * fns.c (concat): Likewise.
538 * frame.c (x_set_frame_parameters): Likewise.
539 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
540 0 if not found, not -1. All callers changed.
541
542 * alloc.c (garbage_collect): Don't assume stack size fits in int.
543 (stack_copy_size): Now size_t, not int.
544 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
545
5462011-03-28 Juanma Barranquero <lekktu@gmail.com>
547
548 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
549 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
550 All callers changed.
551
552 * lisp.h (multibyte_char_to_unibyte):
553 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
554 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
555 * character.h (CHAR_TO_BYTE8):
556 * cmds.c (internal_self_insert):
557 * editfns.c (general_insert_function):
558 * keymap.c (push_key_description):
559 * search.c (Freplace_match):
560 * xdisp.c (message_dolog, set_message_1): All callers changed.
561
5622011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
563
564 * keyboard.c (safe_run_hook_funcall): New function.
565 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
566 don't set the hook to nil, but remove the offending function instead.
567 (Qcommand_hook_internal): Remove, unused.
568 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
569 Vcommand_hook_internal.
570
571 * eval.c (enum run_hooks_condition): Remove.
572 (funcall_nil, funcall_not): New functions.
573 (run_hook_with_args): Call each function through a `funcall' argument.
574 Remove `cond' argument, now redundant.
575 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
576 (Frun_hook_with_args_until_failure): Adjust accordingly.
577 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
578
5792011-03-28 Juanma Barranquero <lekktu@gmail.com>
580
581 * dispextern.h (string_buffer_position): Remove declaration.
582
583 * print.c (strout): Remove parameter `multibyte', unused since
584 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
585
586 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
587 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
588 All callers changed.
589
590 * w32.c (_wsa_errlist): Use braces for struct initializers.
591
592 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
593 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
594 All callers changed.
595 (string_buffer_position): Likewise. Also, make static (it's never
596 used outside xdisp.c).
597 (cursor_row_p): Remove parameter `w', unused since
598 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
599 (decode_mode_spec): Remove parameter `precision', introduced during
600 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
601 All callers changed.
602
6032011-03-27 Jan Djärv <jan.h.d@swipnet.se>
604
605 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
606
6072011-03-27 Anders Lindgren <andlind@gmail.com>
608
609 * nsterm.m (ns_menu_bar_is_hidden): New variable.
610 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
611 (ns_update_auto_hide_menu_bar): New functions.
612 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
613 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
614 ns_constrain_all_frames.
615 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
616 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
617
6182011-03-27 Jan Djärv <jan.h.d@swipnet.se>
619
620 * nsmenu.m (runDialogAt): Remove argument to timer_check.
621
6222011-03-27 Glenn Morris <rgm@gnu.org>
623
624 * syssignal.h: Replace RETSIGTYPE with void.
625 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
626 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
627 Replace SIGTYPE with void everywhere.
628 * s/usg5-4-common.h (SIGTYPE): Remove definition.
629 * s/template.h (SIGTYPE): Remove commented out definition.
630
6312011-03-26 Eli Zaretskii <eliz@gnu.org>
632
633 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
634 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
635
6362011-03-26 Juanma Barranquero <lekktu@gmail.com>
637
638 * w32.c (read_unc_volume): Use parameter `henum', instead of
639 global variable `wget_enum_handle'.
640
641 * keymap.c (describe_vector): Remove parameters `indices' and
642 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
643 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
644
645 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
646
647 * keyboard.c (timer_check): Remove parameter `do_it_now',
648 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
649 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
650 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
651
652 * keyboard.c (read_char):
653 * w32menu.c (w32_menu_display_help):
654 * xmenu.c (show_help_event, menu_help_callback):
655 Adjust calls to `show_help_echo'.
656
657 * gtkutil.c (xg_maybe_add_timer):
658 * keyboard.c (readable_events):
659 * process.c (wait_reading_process_output):
660 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
661
662 * insdel.c (adjust_markers_gap_motion):
663 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
664 (gap_left, gap_right): Don't call it.
665
6662011-03-25 Chong Yidong <cyd@stupidchicken.com>
667
668 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
669 incurred during fontification.
670
6712011-03-25 Juanma Barranquero <lekktu@gmail.com>
672
673 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
674 (DEFVAR_PER_BUFFER): Don't pass it.
675
676 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
677 (scrolling_window): Don't pass it.
678
6792011-03-25 Juanma Barranquero <lekktu@gmail.com>
680
681 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
682
683 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
684 and `suffix'.
685 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
686 of variables specific to SELinux and computation of `encoded_absname'.
687
688 * image.c (XPutPixel): Remove unused variable `height'.
689
690 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
691
692 * unexw32.c (get_section_info): Remove unused variable `section'.
693
694 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
695 (system_process_attributes): Remove unused variable `sess'.
696 (sys_read): Remove unused variable `err'.
697
698 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
699 (w32_wnd_proc): Remove unused variable `isdead'.
700 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
701 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
702 (x_create_tip_frame): Remove unused variable `tem'.
703
704 * w32inevt.c (w32_console_read_socket):
705 Remove unused variable `no_events'.
706
707 * w32term.c (x_draw_composite_glyph_string_foreground):
708 Remove unused variable `width'.
709
7102011-03-24 Juanma Barranquero <lekktu@gmail.com>
711
712 * w32term.c (x_set_glyph_string_clipping):
713 Don't pass uninitialized region to CombineRgn.
714
7152011-03-23 Juanma Barranquero <lekktu@gmail.com>
716
717 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
718 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
719 (Fx_close_connection): Remove unused variable `i'.
720
721 * w32font.c (w32font_draw): Return number of glyphs.
722 (w32font_open_internal): Remove unused variable `i'.
723 (w32font_driver): Add missing initializer.
724
725 * w32menu.c (utf8to16): Remove unused variable `utf16'.
726 (fill_in_menu): Remove unused variable `items_added'.
727
728 * w32term.c (last_mouse_press_frame): Remove static global variable.
729 (w32_clip_to_row): Remove unused variable `f'.
730 (x_delete_terminal): Remove unused variable `i'.
731
732 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
733 (NOTHING): Remove unused static global variable.
734 (uniscribe_check_otf): Remove unused variable `table'.
735 (uniscribe_font_driver): Add missing initializers.
736
7372011-03-23 Julien Danjou <julien@danjou.info>
738
739 * term.c (Fsuspend_tty, Fresume_tty):
740 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
741 * window.c (temp_output_buffer_show):
742 * insdel.c (signal_before_change):
743 * frame.c (Fhandle_switch_frame):
744 * fileio.c (Fdo_auto_save):
745 * emacs.c (Fkill_emacs):
746 * editfns.c (save_excursion_restore):
747 * cmds.c (internal_self_insert):
748 * callint.c (Fcall_interactively):
749 * buffer.c (Fkill_all_local_variables):
750 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
751 Use Frun_hooks.
752 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
753 unconditionnaly since it does the check itself.
754
7552011-03-23 Paul Eggert <eggert@cs.ucla.edu>
756
757 Fix more problems found by GCC 4.5.2's static checks.
758
759 * coding.c (encode_coding_raw_text): Avoid unnecessary test
760 the first time through the loop, since we know p0 < p1 then.
761 This also avoids a gcc -Wstrict-overflow warning.
762
763 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
764 leading to a memory leak, possible in functions like
765 load_charset_map_from_file that can allocate an unbounded number
766 of objects (Bug#8318).
767
768 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
769 that could (at least in theory) be that large.
770
771 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
772 This is less likely to overflow, and avoids undefined behavior if
773 overflow does occur. All callers changed. Use strtoul to scan
774 for the unsigned long integer.
775 (pint2hrstr): Simplify and tune code slightly.
776 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
777
778 * scroll.c (do_scrolling): Work around GCC bug 48228.
779 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
780
781 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
782 This also avoids a warning with gcc -Wstrict-overflow.
783 (validate_x_resource_name): Simplify count usage.
784 This also avoids a warning with gcc -Wstrict-overflow.
785
786 * fileio.c (Fcopy_file): Report error if fchown or fchmod
787 fail (Bug#8306).
788
789 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
790
791 * process.c (Fmake_network_process): Use socklen_t, not int,
792 where POSIX says socklen_t is required in portable programs.
793 This fixes a porting bug on hosts like 64-bit HP-UX, where
794 socklen_t is wider than int (Bug#8277).
795 (Fmake_network_process, server_accept_connection):
796 (wait_reading_process_output, read_process_output):
797 Likewise.
798
799 * process.c: Rename or move locals to avoid shadowing.
800 (list_processes_1, Fmake_network_process):
801 (read_process_output_error_handler, exec_sentinel_error_handler):
802 Rename or move locals.
803 (Fmake_network_process): Define label "retry_connect" only if needed.
804 (Fnetwork_interface_info): Fix pointer signedness.
805 (process_send_signal): Add cast to avoid pointer signedness problem.
806 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
807 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
808
809 Make tparam.h and terminfo.c consistent.
810 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
811 Include tparam.h instead, since it declares them.
812 * cm.h (PC): Remove extern decl; tparam.h now does this.
813 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
814 * terminfo.c: Include tparam.h, to check interfaces.
815 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
816 (tparam): Adjust signature to match interface in tparam.h;
817 this removes some undefined behavior. Check that outstring and len
818 are zero, which they always are with Emacs.
819 * tparam.h (PC, BC, UP): New extern decls.
820
821 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
822 (xftfont_open): Rename locals to avoid shadowing.
823
824 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
825 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
826 (OTF_TAG_SYM): Omit macro if not needed.
827 (ftfont_list): Remove unused local.
828 (get_adstyle_property, ftfont_pattern_entity):
829 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
830 Rename locals to avoid shadowing.
831
832 * xfont.c (xfont_list_family): Mark var as initialized.
833
834 * xml.c (make_dom): Now static.
835
836 * composite.c (composition_compute_stop_pos): Rename local to
837 avoid shadowing.
838 (composition_reseat_it): Remove unused locals.
839 (find_automatic_composition, composition_adjust_point): Likewise.
840 (composition_update_it): Mark var as initialized.
841 (find_automatic_composition): Mark vars as initialized,
842 with a FIXME (Bug#8290).
843
844 character.h: Rename locals to avoid shadowing.
845 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
846 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
847 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
848 (BUF_DEC_POS): Be more systematic about renaming local temporaries
849 to avoid shadowing.
850
851 * textprop.c (property_change_between_p): Remove; unused.
852
853 * intervals.c (interval_start_pos): Now static.
854
855 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
856
857 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
858 Rename locals to avoid shadowing.
859
860 * sound.c (wav_play, au_play, Fplay_sound_internal):
861 Fix pointer signedness.
862 (alsa_choose_format): Remove unused local var.
863 (wav_play): Initialize a variable to 0, to prevent undefined
864 behavior (Bug#8278).
865
866 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
867
868 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
869
870 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
871 clobbering (Bug#8298).
872 * sysdep.c (sys_subshell): Likewise.
873 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
874
875 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
876 This should get cleaned up, so that child_setup has the
877 same signature on all platforms.
878
879 * callproc.c (call_process_cleanup): Now static.
880 (relocate_fd): Rename locals to avoid shadowing.
881
8822011-03-22 Chong Yidong <cyd@stupidchicken.com>
883
884 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
885 not to be necessary, and produces flickering.
886
8872011-03-20 Glenn Morris <rgm@gnu.org>
888
889 * config.in: Remove file.
890
8912011-03-20 Juanma Barranquero <lekktu@gmail.com>
892
893 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
894 are now in src/globals.h.
895 (syms_of_minibuf): Remove spurious & from previous change.
896
8972011-03-20 Leo <sdl.web@gmail.com>
898
899 * minibuf.c (completing-read-function): New variable.
900 (completing-read-default): Rename from completing-read.
901 (completing-read): Call completing-read-function.
902
9032011-03-19 Juanma Barranquero <lekktu@gmail.com>
904
905 * xfaces.c (Fx_load_color_file):
906 Read color file from absolute filename (bug#8250).
907
9082011-03-19 Juanma Barranquero <lekktu@gmail.com>
909
910 * makefile.w32-in: Update dependencies.
911
9122011-03-17 Eli Zaretskii <eliz@gnu.org>
913
914 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
915
9162011-03-17 Paul Eggert <eggert@cs.ucla.edu>
917
918 Fix more problems found by GCC 4.5.2's static checks.
919
920 * process.c (make_serial_process_unwind, send_process_trap):
921 (sigchld_handler): Now static.
922
923 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
924 That way, the code declares only the vars that it needs.
925 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
926 * s/cygwin.h (PTY_ITERATION): Likewise.
927 * s/darwin.h (PTY_ITERATION): Likewise.
928 * s/gnu-linux.h (PTY_ITERATION): Likewise.
929
930 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
931 * process.c (allocate_pty): Don't declare stb unless it's needed.
932
933 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
934 (CONSTANTLIM): Remove; unused.
935 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
936 Define only if needed.
937
938 * unexelf.c (unexec): Name an expression,
939 to avoid gcc -Wbad-function-cast warning.
940 Use a different way to cause a compilation error if anyone uses
941 n rather than nn, a way that does not involve shadowing.
942 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
943
944 * deps.mk (unexalpha.o): Remove; unused.
945
946 New file unexec.h, the (simple) interface for unexec (Bug#8267).
947 * unexec.h: New file.
948 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
949 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
950 Depend on unexec.h.
951 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
952 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
953 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
954 Change as necessary to match prototype in unexec.h.
955
956 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
957 shadowing.
958 (back_comment, skip_chars): Mark vars as initialized.
959
960 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
961 Rename locals to avoid shadowing.
962
963 * lread.c (read1): Rewrite so as not to use empty "else".
964 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
965
966 * print.c (Fredirect_debugging_output): Fix pointer signedess.
967
968 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
969 warning when compiling print.c.
970
971 * font.c (font_unparse_fcname): Abort in an "impossible" situation
972 instead of using an uninitialized var.
973 (font_sort_entities): Mark var as initialized.
974
975 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
976
977 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
978 pointers to constants.
979 (font_parse_fcname): Remove unused vars.
980 (font_delete_unmatched): Now static.
981 (font_get_spec): Remove; unused.
982 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
983 (font_update_drivers, Ffont_get_glyphs, font_add_log):
984 Rename or move locals to avoid shadowing.
985
986 * fns.c (require_nesting_list, require_unwind): Now static.
987 (Ffillarray): Rename locals to avoid shadowing.
988
989 * floatfns.c (domain_error2): Define only if needed.
990 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
991
992 * alloc.c (mark_backtrace): Move decl from here ...
993 * lisp.h: ... to here, so that it can be checked.
994
995 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
996 (Fdefvar): Rewrite so as not to use empty "else".
997 (lisp_indirect_variable): Name an expression,
998 to avoid gcc -Wbad-function-cast warning.
999 (Fdefvar): Rename locals to avoid shadowing.
1000
1001 * callint.c (quotify_arg, quotify_args): Now static.
1002 (Fcall_interactively): Rename locals to avoid shadowing.
1003 Use const pointer when appropriate.
1004
1005 * lisp.h (get_system_name, get_operating_system_release):
1006 Move decls here, to check interfaces.
1007 * process.c (get_operating_system_release): Move decl to lisp.h.
1008 * xrdb.c (get_system_name): Likewise.
1009 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1010 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1011 some of which prompt warnings from gcc -Wbad-function-cast.
1012 (Fformat_time_string, Fencode_time, Finsert_char):
1013 (Ftranslate_region_internal, Fformat):
1014 Rename or remove local vars to avoid shadowing.
1015 (Ftranslate_region_internal): Mark var as initialized.
1016
1017 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1018 avoid shadowing.
1019
1020 * lisp.h (eassert): Check that the argument compiles, even if
1021 ENABLE_CHECKING is not defined.
1022
1023 * data.c (Findirect_variable): Name an expression, to avoid
1024 gcc -Wbad-function-cast warning.
1025 (default_value, arithcompare, arith_driver, arith_error): Now static.
1026 (store_symval_forwarding): Rename local to avoid shadowing.
1027 (Fmake_variable_buffer_local, Fmake_local_variable):
1028 Mark variables as initialized.
1029 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1030
1031 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1032 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1033 Rename locals to avoid shadowing.
1034 (mark_stack): Move local variables into the #ifdef region where
1035 they're used.
1036 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1037 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1038 needed otherwise.
1039 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1040 (GC_STRING_CHARS): Remove; not used.
1041 (Fmemory_limit): Cast sbrk's returned value to char *.
1042
1043 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1044 avoids undefined behavior in theory.
1045
1046 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1047
1048 Use functions, not macros, for up- and down-casing (Bug#8254).
1049 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1050 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1051 to use the following functions instead of these macros.
1052 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1053 EMACS_INT, since callers assume the returned value fits in int.
1054 (upcase1): Likewise, for UPCASE_TABLE.
1055 (uppercasep, lowercasep, upcase): New static inline functions.
1056 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1057 the race-condition problem in the old DOWNCASE.
1058
1059 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1060 Rename locals to avoid shadowing.
1061 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1062 (regex_compile, re_search_2, re_match_2_internal):
1063 Remove unused local vars.
1064 (FREE_VAR): Rewrite so as not to use empty "else",
1065 which gcc can warn about.
1066 (regex_compile, re_match_2_internal): Mark locals as initialized.
1067 (RETALLOC_IF): Define only if needed.
1068 (WORDCHAR_P): Likewise. This one is never needed, but is used
1069 only in a comment talking about a compiler bug, so put inside
1070 the #if 0 of that comment.
1071 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1072 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1073 Remove; unused.
1074
1075 * search.c (boyer_moore): Rename locals to avoid shadowing.
1076 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1077 (PREV_CHAR_BOUNDARY): Likewise.
1078
1079 * search.c (simple_search): Remove unused var.
1080
1081 * dired.c (compile_pattern): Move decl from here ...
1082 * lisp.h: ... to here, so that it can be checked.
1083 (struct re_registers): New forward decl.
1084
1085 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1086
1087 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1088 All uses changed.
1089 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1090 Rename locals to avoid shadowing.
1091 (Fvertical_motion): Mark locals as initialized.
1092
1093 * casefiddle.c (casify_object, casify_region): Now static.
1094 (casify_region): Mark local as initialized.
1095
1096 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1097
1098 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1099 New macros, so that the caller can use some names other than
1100 gcpro1, gcpro2, etc.
1101 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1102 of the new macros.
1103 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1104 argument, for consistency with GCPRO2_VAR, etc: it is now the
1105 prefix of the variable, not the variable itself. All uses
1106 changed.
1107 * dired.c (directory_files_internal, file_name_completion):
1108 Rename locals to avoid shadowing.
1109
1110 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1111 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1112 dired.c's scmp function, had undefined behavior.
1113 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1114 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1115 * buffer.h: ... to here, because these macros use current_buffer,
1116 and the new implementation with inline functions needs to have
1117 current_buffer in scope now, rather than later when the macros
1118 are used.
1119 (downcase, upcase1): New static inline functions.
1120 (DOWNCASE, UPCASE1): Reimplement using these functions.
1121 This avoids undefined behavior in expressions like
1122 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1123 from race conditions in accessing the global variables
1124 case_temp1 and case_temp2.
1125 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1126 * lisp.h (case_temp1, case_temp2): Remove their decls.
1127 * character.h (ASCII_CHAR_P): Move from here ...
1128 * lisp.h: ... to here, so that the inline functions mentioned
1129 above can use them.
1130
1131 * dired.c (directory_files_internal_unwind): Now static.
1132
1133 * fileio.c (file_name_as_directory, directory_file_name):
1134 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1135 Now static.
1136 (file_name_as_directory): Use const pointers when appropriate.
1137 (Fexpand_file_name): Likewise. In particular, newdir might
1138 point at constant storage, so make it a const pointer.
1139 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1140 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1141 signedness issues.
1142 (Fset_file_times, Finsert_file_contents, auto_save_error):
1143 Rename locals to avoid shadowing.
1144
1145 * minibuf.c (choose_minibuf_frame_1): Now static.
1146 (Ftry_completion, Fall_completions): Rename or remove locals
1147 to avoid shadowing.
1148
1149 * marker.c (bytepos_to_charpos): Remove; unused.
1150
1151 * lisp.h (verify_bytepos, count_markers): New decls,
1152 so that gcc does not warn that these functions aren't declared.
1153
1154 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1155 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1156 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1157 (copy_text): Remove unused local var.
1158
1159 * filelock.c (within_one_second): Now static.
1160 (lock_file_1): Rename local to avoid shadowing.
1161
1162 * buffer.c (fix_overlays_before): Mark locals as initialized.
1163 (fix_start_end_in_overlays): Likewise. This function should be
1164 simplified by using pointers-to-pointers, but that's a different
1165 matter.
1166 (switch_to_buffer_1): Now static.
1167 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1168 (report_overlay_modification): Rename locals to avoid shadowing.
1169
1170 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1171 Fix pointer signedness issue.
1172 (sys_subshell): Mark local as volatile if checking for lint,
1173 to suppress a gcc -Wclobbered warning that does not seem to be right.
1174 (MAXPATHLEN): Define only if needed.
1175
1176 * process.c (serial_open, serial_configure): Move decls from here ...
1177 * systty.h: ... to here, so that they can be checked.
1178
1179 * fns.c (get_random, seed_random): Move extern decls from here ...
1180 * lisp.h: ... to here, so that they can be checked.
1181
1182 * sysdep.c (reset_io): Now static.
1183 (wait_for_termination_signal): Remove; unused.
1184
1185 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1186 (copy_keymap_item, append_key, push_text_char_description):
1187 Now static.
1188 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1189 (DENSE_TABLE_SIZE): Remove; unused.
1190 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1191 (describe_map_tree):
1192 Rename locals to avoid shadowing.
1193
1194 * keyboard.c: Declare functions static if they are not used elsewhere.
1195 (echo_char, echo_dash, cmd_error, top_level_2):
1196 (poll_for_input, handle_async_input): Now static.
1197 (read_char, kbd_buffer_get_event, make_lispy_position):
1198 (make_lispy_event, make_lispy_movement, apply_modifiers):
1199 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1200 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1201 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1202 (read_key_sequence, read_char): Mark locals as initialized.
1203 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1204
1205 * keyboard.h (make_ctrl_char): New decl.
1206 (mark_kboards): Move decl here ...
1207 * alloc.c (mark_kboards): ... from here.
1208
1209 * lisp.h (force_auto_save_soon): New decl.
1210
1211 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1212 (DEFINE_DUMMY_FUNCTION): New macro.
1213 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1214 Use it.
1215 (main): Add casts to avoid warnings
1216 if GCC considers string literals to be constants.
1217
1218 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1219
1220 * dbusbind.c: Pointer signedness fixes.
1221 (xd_signature, xd_append_arg, xd_initialize):
1222 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1223 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1224 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1225 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1226
1227 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1228 if GCC considers string literals to be constants.
1229 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1230
12312011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1232
1233 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1234 (print_preprocess, print_object): New macro to fix last change.
1235
1236 * print.c (print_preprocess): Don't forget font objects.
1237
12382011-03-16 Juanma Barranquero <lekktu@gmail.com>
1239
1240 * emacs.c (USAGE3): Doc fixes.
1241
12422011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1243
1244 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1245 structure.
1246
12472011-03-14 Juanma Barranquero <lekktu@gmail.com>
1248
1249 * lisp.h (VWindow_system, Qfile_name_history):
1250 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1251 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1252 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1253
1254 * w32select.c: Don't #include "keyboard.h".
1255 (run_protected): Add extern declaration for waiting_for_input.
1256
1257 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1258 * w32console.c (detect_input_pending, read_input_pending)
1259 (encode_terminal_code):
1260 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1261 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1262 (w32_system_caret_y, Qfile_name_history):
1263 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1264 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1265 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1266 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1267 * w32proc.c (Qlocal, report_file_error):
1268 * w32term.c (Vwindow_system, updating_frame):
1269 * w32uniscribe.c (initialized, uniscribe_font_driver):
1270 Remove unneeded extern declarations.
1271
12722011-03-14 Chong Yidong <cyd@stupidchicken.com>
1273
1274 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1275
12762011-03-13 Chong Yidong <cyd@stupidchicken.com>
1277
1278 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1279 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1280 These macros can no longer be used for assignment.
1281
1282 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1283 Assign struct members directly, instead of using BUF_BEGV etc.
1284 (record_buffer_markers, fetch_buffer_markers): New functions for
1285 recording and fetching special buffer markers.
1286 (set_buffer_internal_1, set_buffer_temp): Use them.
1287
1288 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1289
1290 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1291
1292 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1293 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1294
1295 * xdisp.c (hscroll_window_tree):
1296 (reconsider_clip_changes): Use PT instead of BUF_PT.
1297
12982011-03-13 Eli Zaretskii <eliz@gnu.org>
1299
1300 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1301 $(EMACS_ROOT)/lib/intprops.h.
1302
13032011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1304
1305 Fix more problems found by GCC 4.5.2's static checks.
1306
1307 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1308 to unsigned char * to avoid compiler diagnostic.
1309 (xg_free_frame_widgets): Make it clear that a local variable is
1310 needed only if USE_GTK_TOOLTIP.
1311 (gdk_window_get_screen): Make it clear that this macro is needed
1312 only if USE_GTK_TOOLTIP.
1313 (int_gtk_range_get_value): New function, which avoids a diagnostic
1314 from gcc -Wbad-function-cast.
1315 (xg_set_toolkit_scroll_bar_thumb): Use it.
1316 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1317 diagnostic from gcc -Wbad-function-cast.
1318 (get_utf8_string, xg_get_file_with_chooser):
1319 Rename locals to avoid shadowing.
1320 (create_dialog): Move locals to avoid shadowing.
1321
1322 * xgselect.c (xg_select): Remove unused var.
1323
1324 * image.c (four_corners_best): Mark locals as initialized.
1325 (gif_load): Initialize transparent_p to zero (Bug#8238).
1326 Mark another local as initialized.
1327 (my_png_error, my_error_exit): Mark with NO_RETURN.
1328
1329 * image.c (clear_image_cache): Now static.
1330 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1331 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1332 (x_edge_detection): Remove unnecessary cast that
1333 gcc -Wbad-function-cast diagnoses.
1334 (gif_load): Fix pointer signedness.
1335 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1336 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1337
13382011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 Improve quality of tests for time stamp overflow.
1341 For example, without this patch (encode-time 0 0 0 1 1
1342 1152921504606846976) returns the obviously-bogus value (-948597
1343 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1344 reports time overflow. See
1345 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1346 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1347 * editfns.c: Include limits.h and intprops.h.
1348 (TIME_T_MIN, TIME_T_MAX): New macros.
1349 (time_overflow): Move earlier, to before first use.
1350 (hi_time, lo_time): New functions, for an accurate test for
1351 out-of-range times.
1352 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1353 (Fget_internal_run_time): Don't assume time_t fits in int.
1354 (make_time): Use list2 instead of Fcons twice.
1355 (Fdecode_time): More accurate test for out-of-range times.
1356 (check_tm_member): New function.
1357 (Fencode_time): Use it, to test for out-of-range times.
1358 (lisp_time_argument): Don't rely on undefined left-shift and
1359 right-shift behavior when checking for time stamp overflow.
1360
1361 * editfns.c (time_overflow): New function, refactoring common code.
1362 (Fformat_time_string, Fdecode_time, Fencode_time):
1363 (Fcurrent_time_string): Use it.
1364
1365 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1366 * dired.c (make_time): Move to ...
1367 * editfns.c (make_time): ... here.
1368 * systime.h: Note the move.
1369
13702011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1371
1372 * fringe.c (update_window_fringes): Remove unused variables.
1373
1374 * unexmacosx.c (copy_data_segment): Also copy __got section.
1375 (Bug#8223)
1376
13772011-03-12 Eli Zaretskii <eliz@gnu.org>
1378
1379 * termcap.c [MSDOS]: Include "msdos.h".
1380 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1381 Constify `char *' arguments and their references according to
1382 prototypes in tparam.h.
1383
1384 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1385
1386 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1387 Adapt all references accordingly.
1388
1389 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1390
13912011-03-11 Tom Tromey <tromey@redhat.com>
1392
1393 * buffer.c (syms_of_buffer): Remove obsolete comment.
1394
13952011-03-11 Eli Zaretskii <eliz@gnu.org>
1396
1397 * termhooks.h (encode_terminal_code): Declare prototype.
1398
1399 * msdos.c (encode_terminal_code): Don't declare prototype.
1400
1401 * term.c (encode_terminal_code): Now external again, used by
1402 w32console.c and msdos.c.
1403
1404 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1405 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1406
14072011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1408
1409 Fix some minor problems found by GCC 4.5.2's static checks.
1410
1411 * fringe.c (update_window_fringes): Mark locals as initialized
1412 (Bug#8227).
1413 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1414
1415 * alloc.c (mark_fringe_data): Move decl from here ...
1416 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1417 to check its interface.
1418 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1419
1420 * fontset.c (free_realized_fontset): Now static.
1421 (Fset_fontset_font): Rename local to avoid shadowing.
1422 (fontset_font): Mark local as initialized.
1423 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1424
1425 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1426
1427 * xselect.c (x_disown_buffer_selections): Remove; not used.
1428 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1429 (x_own_selection, Fx_disown_selection_internal): Rename locals
1430 to avoid shadowing.
1431 (x_handle_dnd_message): Remove local to avoid shadowing.
1432
1433 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1434 so that the caller can use some name other than gcpro1.
1435 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1436 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1437 (Fx_backspace_delete_keys_p):
1438 Use them to avoid shadowing, and rename vars to avoid shadowing.
1439 (x_decode_color, x_set_name, x_window): Now static.
1440 (Fx_create_frame): Add braces to silence GCC warning.
1441 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1442 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1443 Remove unused locals.
1444 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1445 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1446 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1447 macros.
1448
1449 * xterm.h (x_mouse_leave): New decl.
1450
1451 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1452 Remove unused functions.
1453 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1454 (x_calc_absolute_position): Now static.
1455 (XTread_socket): Don't define label "out" unless it's used.
1456 Don't declare local "event" unless it's used.
1457 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1458 unless they are used.
1459 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1460 (x_fatal_error_signal): Remove; not used.
1461 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1462 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1463 (x_error_catcher, x_connection_closed, x_error_handler):
1464 (x_error_quitter, xembed_send_message, x_iconify_frame):
1465 (my_log_handler): Rename locals to avoid shadowing.
1466 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1467 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1468
1469 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1470 Rename or move locals to avoid shadowing.
1471 (tty_defined_color, merge_face_heights): Now static.
1472 (free_realized_faces_for_fontset): Remove; not used.
1473 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1474 does not deduce is never used uninitialized.
1475 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1476 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1477
1478 * terminal.c (store_terminal_param): Now static.
1479
1480 * xmenu.c (menu_highlight_callback): Now static.
1481 (set_frame_menubar): Remove unused local.
1482 (xmenu_show): Rename parameter to avoid shadowing.
1483 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1484 since they might point to immutable storage.
1485 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1486 since it's unused otherwise.
1487
1488 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1489 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1490 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1491 avoids a gcc -Wuninitialized diagnostic.
1492 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1493 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1494 does not deduce are never used uninitialized.
1495
1496 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1497
1498 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1499 * window.c (window_loop, size_window):
1500 (run_window_configuration_change_hook, enlarge_window): Likewise.
1501
1502 * window.c (display_buffer): Now static.
1503 (size_window): Mark variables that gcc -Wuninitialized
1504 does not deduce are never used uninitialized.
1505 * window.h (check_all_windows): New decl, to forestall
1506 gcc -Wmissing-prototypes diagnostic.
1507 * dispextern.h (bidi_dump_cached_states): Likewise.
1508
1509 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1510 shadowing.
1511 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1512 Include <limits.h>.
1513 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1514 and to avoid gcc -Wuninitialized warning.
1515 (load_charset_map): Mark variables that gcc -Wuninitialized
1516 does not deduce are never used uninitialized.
1517 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1518
1519 * coding.c (coding_set_source, coding_set_destination):
1520 Use "else { /* comment */ }" rather than "else /* comment */;"
1521 for clarity, and to avoid gcc -Wempty-body warning.
1522 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1523 a block, when the outer 'i' will do.
1524 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1525 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1526 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1527 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1528 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1529 Rename locals to avoid shadowing.
1530 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1531 * coding.c (emacs_mule_char, encode_invocation_designation):
1532 Now static, since they're not used elsewhere.
1533 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1534 (decode_coding_object, encode_coding_object, detect_coding_system):
1535 (decode_coding_emacs_mule): Mark variables that gcc
1536 -Wuninitialized does not deduce are never used uninitialized.
1537 (detect_coding_iso_2022): Initialize a local variable that might
1538 be used uninitialized. Leave a FIXME because it's not clear that
1539 this initialization is needed. (Bug#8211)
1540 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1541 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1542 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1543 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1544 Remove unused macros.
1545
1546 * category.c (hash_get_category_set): Remove unused local var.
1547 (copy_category_table): Now static, since it's not used elsewhere.
1548 * character.c (string_count_byte8): Likewise.
1549
1550 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1551 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1552
1553 * chartab.c (copy_sub_char_table): Now static, since it's not used
1554 elsewhere.
1555 (sub_char_table_ref_and_range, char_table_ref_and_range):
1556 Rename locals to avoid shadowing.
1557 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1558
1559 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1560 (BIDI_BOB): Remove unused macro.
1561
1562 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1563 deduce are never used uninitialized.
1564 * term.c (encode_terminal_code): Likewise.
1565
1566 * term.c (encode_terminal_code): Now static. Remove unused local.
1567
1568 * tparam.h: New file.
1569 * term.c, tparam.h: Include it.
1570 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1571 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1572 Move these decls to tparam.h, and make them agree with what
1573 is actually in tparam.c. The previous trick of using incompatible
1574 decls in different modules does not conform to the C standard.
1575 All callers of tparam changed to use tparam's actual API.
1576 * tparam.c (tparam1, tparam, tgoto):
1577 Use const pointers where appropriate.
1578
1579 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1580 * cm.h (struct cm): Likewise.
1581 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1582 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1583 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1584 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1585 (turn_on_face, init_tty): Likewise.
1586 * termchar.h (struct tty_display_info): Likewise.
1587
1588 * term.c (term_mouse_position): Rename local to avoid shadowing.
1589
1590 * alloc.c (mark_ttys): Move decl from here ...
1591 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1592
15932011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1594
1595 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1596
15972011-03-09 Juanma Barranquero <lekktu@gmail.com>
1598
1599 * search.c (compile_pattern_1): Remove argument regp, unused since
1600 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1601 (compile_pattern): Don't pass it.
1602
16032011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1604
1605 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1606 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1607 for ! HAVE_GTK3.
1608 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1609
1610 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1611
1612 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1613 gdk_window_get_screen, gdk_window_get_geometry,
1614 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1615 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1616 (xg_get_pixbuf_from_pixmap): New function.
1617 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1618 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1619 Call xg_get_pixbuf_from_pixmap instead of
1620 gdk_pixbuf_get_from_drawable.
1621 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1622 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1623 (xg_check_special_colors): Use GtkStyleContext and its functions
1624 for HAVE_GTK3.
1625 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1626 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1627 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1628 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1629 Call gtk_widget_get_preferred_size.
1630 (xg_frame_resized): gdk_window_get_geometry only takes 5
1631 parameters.
1632 (xg_win_to_widget, xg_event_is_for_menubar):
1633 Call gdk_x11_window_lookup_for_display.
1634 (xg_set_widget_bg): New function.
1635 (delete_cb): New function.
1636 (xg_create_frame_widgets): connect delete-event to delete_cb.
1637 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1638 (xg_set_background_color): Call xg_set_widget_bg.
1639 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1640 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1641 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1642 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1643 if ! HAVE_GTK3.
1644 (update_frame_tool_bar): Call gtk_widget_hide.
1645 (xg_initialize): Use GDK_KEY_g.
1646
1647 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1648 if ! HAVE_GTK3
1649 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1650
1651 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1652 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1653 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1654
16552011-03-08 Juanma Barranquero <lekktu@gmail.com>
1656
1657 * w32xfns.c (select_palette): Check success of RealizePalette against
1658 GDI_ERROR, not zero.
1659
1660See ChangeLog.11 for earlier changes.
1661
1662;; Local Variables:
1663;; coding: utf-8
1664;; End:
1665
1666 Copyright (C) 2011 Free Software Foundation, Inc.
1667
1668 This file is part of GNU Emacs.
1669
1670 GNU Emacs is free software: you can redistribute it and/or modify
1671 it under the terms of the GNU General Public License as published by
1672 the Free Software Foundation, either version 3 of the License, or
1673 (at your option) any later version.
1674
1675 GNU Emacs is distributed in the hope that it will be useful,
1676 but WITHOUT ANY WARRANTY; without even the implied warranty of
1677 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1678 GNU General Public License for more details.
1679
1680 You should have received a copy of the GNU General Public License
1681 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.