Be more systematic about user-interface timestamps.
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12011-05-12 Paul Eggert <eggert@cs.ucla.edu>
2
3 Be more systematic about user-interface timestamps.
4 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5 and sometimes 'EMACS_UINT', to represent these timestamps. This
6 change causes it to use 'Time' uniformly, as that's what X uses.
7 This makes the code easier to follow, and makes it easier to catch
8 integer overflow bugs such as Bug#8664.
9 * frame.c (Fmouse_position, Fmouse_pixel_position):
10 Use Time, not unsigned long, for user-interface timestamps.
11 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
13 * keyboard.h (last_event_timestamp): Likewise.
14 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
15 * menu.h (xmenu_show): Likewise.
16 * term.c (term_mouse_position): Likewise.
17 * termhooks.h (struct input_event.timestamp): Likewise.
18 (struct terminal.mouse_position_hook): Likewise.
19 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
20 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
21 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
22 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
23 what it was before.
24 * menu.h, termhooks.h: Include "systime.h", for Time.
25
26 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
27 Don't assume that the difference between two unsigned long values
28 can fit into an integer. At this point, we know button_down_time
29 <= event->timestamp, so the difference must be nonnegative, so
30 there's no need to cast the result if double-click-time is
31 nonnegative, as it should be; check that it's nonnegative, just in
32 case. This bug is triggered when events are more than 2**31 ms
33 apart (about 25 days). (Bug#8664)
34
35 * xselect.c (last_event_timestamp): Remove duplicate decl.
36 (x_own_selection): Remove needless cast to unsigned long.
37
38 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
39 that always fit in int. Use a sentinel instead of a counter, to
40 avoid a temp and to allay GCC's concerns about possible int overflow.
41 * frame.h (struct frame): Use int for menu_bar_items_used
42 instead of EMACS_INT, since it always fits in int.
43
44 * menu.c (grow_menu_items): Check for int overflow.
45
46 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
47
482011-05-11 Paul Eggert <eggert@cs.ucla.edu>
49
50 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
51 Before, the code was not consistent. These values cannot exceed
52 2**31 - 1 so there's no need to make them unsigned.
53 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
54 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
55 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
56 as modifiers.
57 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
58
59 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
60 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
61 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
62 presumably because the widths might not match.
63
64 * window.c (size_window): Avoid needless test at loop start.
65
662011-05-10 Juanma Barranquero <lekktu@gmail.com>
67
68 * image.c (Finit_image_library): Return t for built-in image types,
69 like pbm and xbm. (Bug#8640)
70
712011-05-09 Andreas Schwab <schwab@linux-m68k.org>
72
73 * w32menu.c (set_frame_menubar): Fix submenu allocation.
74
752011-05-07 Eli Zaretskii <eliz@gnu.org>
76
77 * w32console.c (Fset_screen_color): Doc fix.
78 (Fget_screen_color): New function.
79 (syms_of_ntterm): Defsubr it.
80
81 * callproc.c (call_process_cleanup): Don't close and unlink the
82 temporary file if Fcall_process didn't create it in the first
83 place.
84 (Fcall_process): Don't create tempfile if stdout of the child
85 process will be redirected to a file specified with `:file'.
86 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
87 cue to call_process_cleanup not to close that handle.
88
892011-05-07 Ben Key <bkey76@gmail.com>
90
91 * makefile.w32-in: The bootstrap-temacs rule now makes use of
92 one of two shell specific rules, either bootstrap-temacs-CMD or
93 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
94 to the previous implementation of the bootstrap-temacs rule.
95 The bootstrap-temacs-CMD rule is similar to the previous
96 implementation of the bootstrap-temacs rule except that it
97 makes use of the ESC_CFLAGS variable instead of the CFLAGS
98 variable.
99
100 These changes, along with some changes to nt/configure.bat,
101 nt/gmake.defs, and nt/nmake.defs, are required to extend my
102 earlier fix to add support for --cflags and --ldflags options
103 that include quotes so that it works whether make uses cmd or
104 sh as the shell.
105
1062011-05-06 Michael Albinus <michael.albinus@gmx.de>
107
108 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
109 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
110 is a constant.
111 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
112 a string. Handle both cases.
113 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
114 (Fdbus_register_method): Use Qinvalid_function.
115
1162011-05-06 Juanma Barranquero <lekktu@gmail.com>
117
118 * makefile.w32-in: Update dependencies.
119 (LISP_H): Add inttypes.h and stdin.h.
120 (PROCESS_H): Add unistd.h.
121
1222011-05-06 Eli Zaretskii <eliz@gnu.org>
123
124 * lread.c: Include limits.h (fixes the MS-Windows build broken by
125 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
126
1272011-05-06 Paul Eggert <eggert@cs.ucla.edu>
128
129 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
130
131 * term.c (vfatal): Remove stray call to va_end.
132 It's not needed and the C Standard doesn't allow it here anyway.
133
134 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
135 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
136
137 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
138 bytes.
139
140 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
141
142 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
143
144 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
145
146 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
147
148 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
149
150 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
151 * charset.c (Fdefine_charset_internal): Don't initialize
152 charset.code_space[15]. The value was garbage, on hosts with
153 32-bit int (Bug#8600).
154
155 * lread.c (read_integer): Be more consistent with string-to-number.
156 Use string_to_number to do the actual conversion; this avoids
157 rounding errors and fixes some other screwups. Without this fix,
158 for example, #x1fffffffffffffff was misread as -2305843009213693952.
159 (digit_to_number): Move earlier, for benefit of read_integer.
160 Return -1 if the digit is out of range for the base, -2 if it is
161 not a digit in any supported base. (Bug#8602)
162
163 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
164
165 * dispnew.c (scrolling_window): Return 1 if we scrolled,
166 to match comment at start of function. This also removes a
167 GCC warning about overflow in a 32+64-bit port.
168
169 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
170
171 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
172 Reported by Stefan Monnier in
173 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
174 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
175 SYMBOLP-guarded XSYMBOL, not XPNTR.
176
177 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
178 (EMACS_UINTPTR): Likewise, with uintptr_t.
179
180 * lisp.h: Prefer 64-bit EMACS_INT if available.
181 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
182 on 32-bit hosts that have 64-bit int, so that they can access
183 large files.
184 However, temporarily disable this change unless the temporary
185 symbol WIDE_EMACS_INT is defined.
186
187 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
188
189 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
190 This removes an assumption that EMACS_INT and long are the same
191 width as pointers. The assumption is true for Emacs porting targets
192 now, but we want to make other targets possible.
193 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
194 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
195 In the rest of the code, change types of integers that hold casted
196 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
197 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
198 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
199 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
200 No need to cast type when ORing.
201 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
202 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
203 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
204 assume EMACS_INT is the same width as char *.
205 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
206 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
207 Remove no-longer-needed casts.
208 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
209 (xg_tool_bar_help_callback, xg_make_tool_item):
210 Use EMACS_INTPTR to hold an integer
211 that will be cast to void *; this can avoid a GCC warning
212 if EMACS_INT is not the same width as void *.
213 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
214 * xdisp.c (display_echo_area_1, resize_mini_window_1):
215 (current_message_1, set_message_1):
216 Use a local to convert to proper width without a cast.
217 * xmenu.c (dialog_selection_callback): Likewise.
218
219 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
220 Also, don't assume VALBITS / RAND_BITS is less than 5,
221 and don't rely on undefined behavior when shifting a 1 left into
222 the sign bit.
223 * lisp.h (get_random): Change signature to match.
224
225 * lread.c (hash_string): Use size_t, not int, for hash computation.
226 Normally we prefer signed values; but hashing is special, because
227 it's better to use unsigned division on hash table sizes so that
228 the remainder is nonnegative. Also, size_t is the natural width
229 for hashing into memory. The previous code used 'int', which doesn't
230 retain enough info to hash well into very large tables.
231 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
232
233 * dbusbind.c: Don't possibly lose pointer info when converting.
234 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
235 Use XPNTR rather than XHASH, so that the high-order bits of
236 the pointer aren't lost when converting through void *.
237
238 * eval.c (Fautoload): Don't double-shift a pointer.
239
240 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
241
2422011-05-06 Juanma Barranquero <lekktu@gmail.com>
243
244 * gnutls.c (DEF_GNUTLS_FN):
245 * image.c (DEF_IMGLIB_FN): Make function pointers static.
246
2472011-05-05 Andreas Schwab <schwab@linux-m68k.org>
248
249 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
250 marker. (Bug#8610)
251
2522011-05-05 Eli Zaretskii <eliz@gnu.org>
253
254 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
255 New version that can reserve upto 2GB of heap space.
256
2572011-05-05 Chong Yidong <cyd@stupidchicken.com>
258
259 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
260
2612011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
262
263 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
264 `gnutls_certificate_set_x509_key_file'.
265
2662011-05-05 Juanma Barranquero <lekktu@gmail.com>
267
268 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
269 Update dependencies.
270
2712011-05-04 Juanma Barranquero <lekktu@gmail.com>
272
273 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
274 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
275 Remove unused parameter `fildes'.
276 * process.c (read_process_output, send_process): Don't pass it.
277
2782011-05-04 Juanma Barranquero <lekktu@gmail.com>
279
280 Fix previous change: the library cache is defined in w32.c.
281 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
282 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
283
2842011-05-04 Juanma Barranquero <lekktu@gmail.com>
285
286 Implement dynamic loading of GnuTLS on Windows.
287
288 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
289 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
290 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
291 Declare.
292
293 * gnutls.c (Qgnutls_dll): Define.
294 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
295 (gnutls_*): Declare function pointers.
296 (init_gnutls_functions): New function to initialize function pointers.
297 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
298 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
299 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
300 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
301 (emacs_gnutls_write, emacs_gnutls_read)
302 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
303 (Fgnutls_available_p): New function.
304 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
305 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
306 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
307
308 * image.c: Include w32.h.
309 (Vimage_type_cache): Delete.
310 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
311 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
312 (w32_delayed_load): Move to w32.c.
313
314 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
315
316 * w32.c (QCloaded_from, Vlibrary_cache): Define.
317 (w32_delayed_load): Move from image.c. When loading a library, record
318 its filename in the :loaded-from property of the library id.
319 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
320 Initialize and staticpro them.
321 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
322
323 * process.c: Include lisp.h before w32.h, not after.
324 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
325 instead of gnutls_record_check_pending.
326
327 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
328
3292011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
330
331 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
332 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
333 as passed in.
334
3352011-05-03 Jan Djärv <jan.h.d@swipnet.se>
336
337 * xterm.c (x_set_frame_alpha): Do not set property on anything
338 else than FRAME_X_OUTER_WINDOW (Bug#8608).
339
3402011-05-02 Juanma Barranquero <lekktu@gmail.com>
341
342 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
343
3442011-05-02 Juanma Barranquero <lekktu@gmail.com>
345
346 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
347 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
348 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
349 (gnutls_global_initialized, Qgnutls_bootprop_priority)
350 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
351 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
352 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
353 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
354 (Qgnutls_bootprop_callbacks_verify): Make static.
355
3562011-05-01 Andreas Schwab <schwab@linux-m68k.org>
357
358 * callproc.c: Indentation fixup.
359
360 * sysdep.c (wait_for_termination_1): Make static.
361 (wait_for_termination, interruptible_wait_for_termination): Move
362 after wait_for_termination_1.
363
3642011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
365
366 * sysdep.c (interruptible_wait_for_termination): New function
367 which is like wait_for_termination, but allows keyboard
368 interruptions.
369
370 * callproc.c (Fcall_process): Add (:file "file") as an option for
371 the STDOUT buffer.
372 (Fcall_process_region): Ditto.
373
3742011-04-30 Eli Zaretskii <eliz@gnu.org>
375
376 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
377 rather than `XVECTOR (FOO)->size'.
378
379 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
380 inttypes.h, as a gnulib replacement is used if it not available in
381 system headers.
382
3832011-04-21 Eli Zaretskii <eliz@gnu.org>
384
385 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
386 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
387 of MOST_POSITIVE_FIXNUM. (Bug#8528)
388
389 * coding.c (coding_alloc_by_realloc): Error out if destination
390 will grow beyond MOST_POSITIVE_FIXNUM.
391 (decode_coding_emacs_mule): Abort if there isn't enough place in
392 charbuf for the composition carryover bytes. Reserve an extra
393 space for up to 2 characters produced in a loop.
394 (decode_coding_iso_2022): Abort if there isn't enough place in
395 charbuf for the composition carryover bytes.
396
3972011-04-21 Eli Zaretskii <eliz@gnu.org>
398
399 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
400 aborting when %lld or %lll format is passed.
401 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
402 %llo or %llx format is passed. (Bug#8545)
403
404 * window.c (window_scroll_line_based): Use a marker instead of
405 simple variables to record original value of point. (Bug#7952)
406
407 * doprnt.c (doprnt): Fix the case where a multibyte sequence
408 produced by %s or %c overflows available buffer space. (Bug#8545)
409
4102011-04-28 Paul Eggert <eggert@cs.ucla.edu>
411
412 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
413 (SIZE_MAX): Move defn after all includes, as they might #define it.
414
4152011-04-28 Juanma Barranquero <lekktu@gmail.com>
416
417 * w32.c (init_environment): Warn about defaulting HOME to C:\.
418
4192011-04-28 Juanma Barranquero <lekktu@gmail.com>
420
421 * keyboard.c (Qdelayed_warnings_hook): Define.
422 (command_loop_1): Run `delayed-warnings-hook'
423 if Vdelayed_warnings_list is non-nil.
424 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
425 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
426
4272011-04-28 Eli Zaretskii <eliz@gnu.org>
428
429 * doprnt.c (doprnt): Don't return value smaller than the buffer
430 size if the message was truncated. (Bug#8545).
431
4322011-04-28 Juanma Barranquero <lekktu@gmail.com>
433
434 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
435 (Fx_window_property): #if-0 the whole functions, not just the bodies.
436
4372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
438
439 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
440
4412011-04-27 Juanma Barranquero <lekktu@gmail.com>
442
443 * makefile.w32-in: Update dependencies.
444
4452011-04-27 Eli Zaretskii <eliz@gnu.org>
446
447 Improve `doprnt' and its usage. (Bug#8545)
448 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
449 `format_end'. Remove support for %l as a conversion specifier.
450 Don't use xrealloc. Improve diagnostics when the %l size modifier
451 is used. Update the commentary.
452
453 * eval.c (verror): Simplify calculation of size_t.
454
455 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
456 messages.
457
4582011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
459
460 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
461 change.
462
4632011-04-27 Paul Eggert <eggert@cs.ucla.edu>
464
465 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
466 This makes this file independent of the recent pseudovector change.
467
4682011-04-26 Paul Eggert <eggert@cs.ucla.edu>
469
470 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
471
472 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
473 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
474 Remove unused local.
475 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
476
477 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
478 GCC 4.6.0 optimizes based on type-based alias analysis. For
479 example, if b is of type struct buffer * and v of type struct
480 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
481 != &v->size, and therefore "v->size = 1; b->size = 2; return
482 v->size;" must therefore return 1. This assumption is incorrect
483 for Emacs, since it type-puns struct Lisp_Vector * with many other
484 types. To fix this problem, this patch adds a new type struct
485 vectorlike_header that documents the constraints on layout of vectors
486 and pseudovectors, and helps optimizing compilers not get fooled
487 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
488 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
489 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
490 the size member.
491 (XSETPVECTYPE): Rewrite in terms of new macro.
492 (XSETPVECTYPESIZE): New macro, specifying both type and size.
493 This is a bit clearer, and further avoids the possibility of
494 undesirable aliasing.
495 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
496 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
497 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
498 since Lisp_Subr is a special case (no "next" field).
499 (ASIZE): Now uses header.size rather than size. All
500 previous uses of XVECTOR (foo)->size replaced to use this macro,
501 to avoid the hassle of writing XVECTOR (foo)->header.size.
502 (struct vectorlike_header): New type.
503 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
504 object, to help avoid aliasing.
505 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
506 (SUBRP): Likewise, since Lisp_Subr is a special case.
507 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
508 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
509 (struct Lisp_Hash_Table): Combine first two members into a single
510 struct vectorlike_header member. All uses of "size" and "next" members
511 changed to be "header.size" and "header.next".
512 * buffer.h (struct buffer): Likewise.
513 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
514 * frame.h (struct frame): Likewise.
515 * process.h (struct Lisp_Process): Likewise.
516 * termhooks.h (struct terminal): Likewise.
517 * window.c (struct save_window_data, struct saved_window): Likewise.
518 * window.h (struct window): Likewise.
519 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
520 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
521 * buffer.c (init_buffer_once): Likewise.
522 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
523 special case.
524 * process.c (Fformat_network_address): Use local var for size,
525 for brevity.
526
527 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
528
529 Make the Lisp reader and string-to-float more consistent (Bug#8525)
530 * data.c (atof): Remove decl; no longer used or needed.
531 (digit_to_number): Move to lread.c.
532 (Fstring_to_number): Use new string_to_number function, to be
533 consistent with how the Lisp reader treats infinities and NaNs.
534 Do not assume that floating-point numbers represent EMACS_INT
535 without losing information; this is not true on most 64-bit hosts.
536 Avoid double-rounding errors, by insisting on integers when
537 parsing non-base-10 numbers, as the documentation specifies.
538 * lisp.h (string_to_number): New decl, replacing ...
539 (isfloat_string): Remove.
540 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
541 (read1): Do not accept +. and -. as integers; this
542 appears to have been a coding error. Similarly, do not accept
543 strings like +-1e0 as floating point numbers. Do not report
544 overflow for integer overflows unless the base is not 10 which
545 means we have no simple and reliable way to continue.
546 Break out the floating-point parsing into a new
547 function string_to_number, so that Fstring_to_number parses
548 floating point numbers consistently with the Lisp reader.
549 (digit_to_number): Moved here from data.c. Make it static inline.
550 (E_CHAR, EXP_INT): Remove, replacing with ...
551 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
552 (string_to_number): New function, replacing isfloat_string.
553 This function checks for valid syntax and produces the resulting
554 Lisp float number too. Rework it so that string-to-number
555 no longer mishandles examples like "1.0e+". Use strtoumax,
556 so that overflow for non-base-10 numbers is reported only when
557 there's no portable and simple way to convert to floating point.
558
559 * textprop.c (set_text_properties_1): Rewrite for clarity,
560 and to avoid GCC warning about integer overflow.
561
562 * intervals.h (struct interval): Use EMACS_INT for members
563 where EMACS_UINT might cause problems. See
564 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
565 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
566 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
567 All uses changed.
568 (offset_intervals): Tell GCC not to worry about length overflow
569 when negating a negative length.
570
571 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
572 (overrun_check_free): Likewise.
573
574 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
575 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
576 word size.
577
578 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
579 (gnutls_make_error): Rename local to avoid shadowing.
580 (gnutls_emacs_global_deinit): ifdef out; not used.
581 (Fgnutls_boot): Use const for pointer to readonly storage.
582 Comment out unused local. Fix pointer signedness problems.
583
584 * lread.c (openp): Don't stuff size_t into an 'int'.
585 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
586 about possible signed overflow.
587
588 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
589 (GDK_KEY_g): Don't define if already defined.
590 (xg_prepare_tooltip): Avoid pointer signedness problem.
591 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
592
593 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
594 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
595
596 * xfns.c (Fx_window_property): Simplify a bit,
597 to make a bit faster and to avoid GCC 4.6.0 warning.
598 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
599
600 * fns.c (internal_equal): Don't assume size_t fits in int.
601
602 * alloc.c (compact_small_strings): Tighten assertion a little.
603
604 Replace pEd with more-general pI, and fix some printf arg casts.
605 * lisp.h (pI): New macro, generalizing old pEd macro to other
606 conversion specifiers. For example, use "...%"pI"d..." rather
607 than "...%"pEd"...".
608 (pEd): Remove. All uses replaced with similar uses of pI.
609 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
610 * alloc.c (check_pure_size): Don't overflow by converting size to int.
611 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
612 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
613 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
614 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
615 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
616 64-bit hosts.
617 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
618 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
619 * print.c (safe_debug_print, print_object): Likewise.
620 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
621 to int.
622 Use pI instead of if-then-else-abort. Use %p to avoid casts,
623 avoiding the 0 flag, which is not portable.
624 * process.c (Fmake_network_process): Use pI to avoid cast.
625 * region-cache.c (pp_cache): Likewise.
626 * xdisp.c (decode_mode_spec): Likewise.
627 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
628 behavior on 64-bit hosts with printf arg.
629 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
630 (x_stop_queuing_selection_requests): Likewise.
631 (x_get_window_property): Don't truncate byte count to an 'int'
632 when tracing.
633
634 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
635 here, since it parses constructs like leading '-' and spaces,
636 which are not wanted; and it overflows with large numbers.
637 Instead, simply match F[0-9]+, which is what is wanted anyway.
638
639 * alloc.c: Remove unportable assumptions about struct layout.
640 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
641 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
642 (allocate_vectorlike, make_pure_vector): Use the new macros,
643 plus offsetof, to remove unportable assumptions about struct layout.
644 These assumptions hold on all porting targets that I know of, but
645 they are not guaranteed, they're easy to remove, and removing them
646 makes further changes easier.
647
648 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
649 This doesn't fix a bug but makes the code clearer.
650 (string_overrun_cookie): Now const. Use initializers that
651 don't formally overflow signed char, to avoid warnings.
652 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
653 can cause Emacs to crash when string overrun checking is enabled.
654 (allocate_buffer): Don't assume sizeof (struct buffer) is a
655 multiple of sizeof (EMACS_INT); it need not be, if
656 alignof(EMACS_INT) < sizeof (EMACS_INT).
657 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
658
6592011-04-26 Juanma Barranquero <lekktu@gmail.com>
660
661 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
662
6632011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
664
665 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
666 supposed to be handshaking. (Bug#8556)
667 Reported by Paul Eggert <eggert@cs.ucla.edu>.
668
6692011-04-26 Daniel Colascione <dan.colascione@gmail.com>
670
671 * lisp.h (Qdebug): List symbol.
672 * eval.c (Qdebug): Restore global linkage.
673 * keyboard.c (debug-on-event): New variable.
674 (handle_user_signal): Break into debugger when debug-on-event
675 matches the current signal symbol.
676
6772011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
678
679 * alloc.c (check_sblock, check_string_bytes)
680 (check_string_free_list): Convert to standard C.
681
6822011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
683
684 * w32.c (emacs_gnutls_push): Fix typo.
685
6862011-04-25 Eli Zaretskii <eliz@gnu.org>
687
688 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
689 "cast to pointer from integer of different size".
690
691 Improve doprnt and its use in verror. (Bug#8545)
692 * doprnt.c (doprnt): Document the set of format control sequences
693 supported by the function. Use SAFE_ALLOCA instead of always
694 using `alloca'.
695
696 * eval.c (verror): Don't limit the buffer size at size_max-1, that
697 is one byte too soon. Don't use xrealloc; instead xfree and
698 xmalloc anew.
699
7002011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
701
702 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
703 callbacks stage.
704
705 * gnutls.c: Renamed global_initialized to
706 gnutls_global_initialized. Added internals for the
707 :verify-hostname-error, :verify-error, and :verify-flags
708 parameters of `gnutls-boot' and documented those parameters in the
709 docstring. Start callback support.
710 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
711 unless a fatal error occured. Call gnutls_alert_send_appropriate
712 on error. Return error code.
713 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
714 (emacs_gnutls_read): Likewise.
715 (Fgnutls_boot): Return handshake error code.
716 (emacs_gnutls_handle_error): New function.
717 (wsaerror_to_errno): Likewise.
718
719 * w32.h (emacs_gnutls_pull): Add prototype.
720 (emacs_gnutls_push): Likewise.
721
722 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
723 (emacs_gnutls_push): Likewise.
724
7252011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
726
727 * process.c (wait_reading_process_output): Check if GnuTLS
728 buffered some data internally if no FDs are set for TLS
729 connections.
730
731 * makefile.w32-in (OBJ2): Add gnutls.$(O).
732 (LIBS): Link to USER_LIBS.
733 ($(BLD)/gnutls.$(0)): New target.
734
7352011-04-24 Eli Zaretskii <eliz@gnu.org>
736
737 * xdisp.c (handle_single_display_spec): Rename the
738 display_replaced_before_p argument into display_replaced_p, to
739 make it consistent with the commentary. Fix typos in the
740 commentary.
741
742 * textprop.c (syms_of_textprop): Remove dead code.
743 (copy_text_properties): Delete obsolete commentary about an
744 interface that was deleted long ago. Fix typos in the description
745 of arguments.
746
747 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
748 to changes in oldXMenu/XMenu.h from 2011-04-16.
749 <menu_help_message, prev_menu_help_message>: Constify.
750 (IT_menu_make_room): menu->help_text is now `const char **';
751 adjust.
752
753 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
754 to changes in oldXMenu/XMenu.h from 2011-04-16.
755 (struct XMenu): Declare `help_text' `const char **'.
756
757 * xfaces.c <Qunspecified>: Make extern again.
758
759 * syntax.c: Include sys/types.h before including regex.h, as
760 required by Posix.
761
762 * doc.c (get_doc_string): Improve the format passed to `error'.
763
764 * doprnt.c (doprnt): Improve commentary.
765
766 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
767
768 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
769 them with etags.
770
771 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
772 changes in globals.h immediately force recompilation.
773 (TAGS): Depend on $(CURDIR)/m/intel386.h and
774 $(CURDIR)/s/ms-w32.h.
775 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
776
777 * character.c (Fchar_direction): Function deleted.
778 (syms_of_character): Don't defsubr it.
779 <char-direction-table>: Deleted.
780
7812011-04-23 Eli Zaretskii <eliz@gnu.org>
782
783 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
784 * doprnt.c: Include limits.h.
785 (SIZE_MAX): New macro.
786 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
787 local variables are now size_t instead of int or unsigned.
788 Improve overflow protection. Support `l' modifier for integer
789 conversions. Support %l conversion. Don't assume an EMACS_INT
790 argument for integer conversions and for %c.
791
792 * lisp.h (doprnt): Restore prototype.
793
794 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
795 $(SRC)/character.h.
796
797 * Makefile.in (base_obj): Add back doprnt.o.
798
799 * deps.mk (doprnt.o): Add back prerequisites.
800 (callint.o): Depend on character.h.
801
802 * eval.c (internal_lisp_condition_case): Include the handler
803 representation in the error message.
804 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
805 when breaking from the loop.
806
807 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
808
809 * callint.c (Fcall_interactively): When displaying error message
810 about invalid control letter, pass the character's codepoint, not
811 a pointer to its multibyte form. Improve display of the character
812 in octal and display also its hex code.
813
814 * character.c (char_string): Use %x to display the (unsigned)
815 codepoint of an invalid character, to avoid displaying a bogus
816 negative value.
817
818 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
819 `error', not SYMBOL_NAME itself.
820
821 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
822 character arguments to `error'.
823
824 * charset.c (check_iso_charset_parameter): Fix incorrect argument
825 to `error' in error message about FINAL_CHAR argument. Make sure
826 FINAL_CHAR is a character, and use %c when it is passed as
827 argument to `error'.
828
8292011-04-23 Eli Zaretskii <eliz@gnu.org>
830
831 * s/ms-w32.h (localtime): Redirect to sys_localtime.
832
833 * w32.c: Include <time.h>.
834 (sys_localtime): New function.
835
8362011-04-23 Chong Yidong <cyd@stupidchicken.com>
837
838 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
839
840 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
841
8422011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
843
844 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
845 zombies (Bug#8467).
846
8472011-04-19 Eli Zaretskii <eliz@gnu.org>
848
849 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
850 gl_state.e_property when gl_state.object is Qt.
851
852 * insdel.c (make_gap_larger): Remove limitation of buffer size
853 to <= INT_MAX.
854
8552011-04-18 Chong Yidong <cyd@stupidchicken.com>
856
857 * xdisp.c (lookup_glyphless_char_display)
858 (produce_glyphless_glyph): Handle cons cell entry in
859 glyphless-char-display.
860 (Vglyphless_char_display): Document it.
861
862 * term.c (produce_glyphless_glyph): Handle cons cell entry in
863 glyphless-char-display.
864
8652011-04-17 Chong Yidong <cyd@stupidchicken.com>
866
867 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
868
869 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
870
871 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
872 definition for no-X builds.
873
8742011-04-16 Paul Eggert <eggert@cs.ucla.edu>
875
876 Static checks with GCC 4.6.0 and non-default toolkits.
877
878 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
879
880 * process.c (keyboard_bit_set): Define only if SIGIO.
881 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
882 (send_process): Repair possible setjmp clobbering.
883
884 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
885
886 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
887
888 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
889
890 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
891 Define only if needed.
892
893 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
894 by pacifying GCC about it. Maybe it's time to retire it?
895 * xfaces.c (USG, __TIMEVAL__): Likewise.
896
897 * dispextern.h (struct redisplay_interface): Rename param
898 to avoid shadowing.
899 * termhooks.h (struct terminal): Likewise.
900 * xterm.c (xembed_send_message): Likewise.
901
902 * insdel.c (make_gap_smaller): Define only if
903 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
904
905 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
906 it.
907
908 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
909 so that we aren't warned about unused symbols.
910
911 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
912
913 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
914
915 * xfns.c (x_real_positions): Mark locals as initialized.
916
917 * xmenu.c (xmenu_show): Don't use uninitialized vars.
918
919 * xterm.c: Fix problems found by static analysis with other toolkits.
920 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
921 (x_dispatch_event): Declare static if USE_GTK, and
922 define if USE_GTK || USE_X_TOOLKIT.
923 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
924 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
925 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
926 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
927
928 * xmenu.c (menu_help_callback): Pointer type fixes.
929 Use const pointers when pointing at readonly data. Avoid pointer
930 signedness clashes.
931 (FALSE): Remove unused macro.
932 (update_frame_menubar): Remove unused decl.
933
934 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
935
936 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
937 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
938 (single_menu_item): Rename local to avoid shadowing.
939
940 * keyboard.c (make_lispy_event): Remove unused local var.
941
942 * frame.c, frame.h (x_get_resource_string): Bring this back, but
943 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
944
945 * bitmaps: Change bitmaps from unsigned char back to the X11
946 compatible char. Avoid the old compiler warnings about
947 out-of-range initializers by using, for example, '\xab' rather
948 than 0xab.
949
950 * xgselect.c (xgselect_initialize): Check vs interface
951 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
952
953 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
954
955 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
956 to read-only memory.
957
958 * fns.c (vector): Remove; this old hack is no longer needed.
959
960 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
961 Remove unused var.
962 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
963
964 * xrdb.c (x_load_resources): Omit unused local.
965
966 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
967 (x_window): Rename locals to avoid shadowing.
968 (USG): Use the kludged USG macro, to pacify gcc.
969
970 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
971 (x_term_init): Remove local to avoid shadowing.
972
973 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
974
975 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
976 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
977
9782011-04-16 Eli Zaretskii <eliz@gnu.org>
979
980 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
981
982 Fix regex.c, syntax.c and friends for buffers > 2GB.
983 * syntax.h (struct gl_state_s): Declare character position members
984 EMACS_INT.
985
986 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
987
988 * textprop.c (verify_interval_modification, interval_of): Declare
989 arguments EMACS_INT.
990
991 * intervals.c (adjust_intervals_for_insertion): Declare arguments
992 EMACS_INT.
993
994 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
995
996 * indent.c (Fvertical_motion): Local variable it_start is now
997 EMACS_INT.
998
999 * regex.c (re_match, re_match_2, re_match_2_internal)
1000 (bcmp_translate, regcomp, regexec, print_double_string)
1001 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1002 (re_compile_pattern, re_exec): Declare arguments and local
1003 variables `size_t' and `ssize_t' and return values `regoff_t', as
1004 appropriate.
1005 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1006 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1007 <compile_stack_type>: `size' and `avail' are now `size_t'.
1008
1009 * regex.h <regoff_t>: Use ssize_t, not int.
1010 (re_search, re_search_2, re_match, re_match_2): Arguments that
1011 specify buffer/string position and length are now ssize_t and
1012 size_t. Return type is regoff_t.
1013
10142011-04-16 Ben Key <bkey76@gmail.com>
1015
1016 * nsfont.m: Fixed bugs in ns_get_family and
1017 ns_descriptor_to_entity that were caused by using free to
1018 deallocate memory blocks that were allocated by xmalloc (via
1019 xstrdup). This caused Emacs to crash when compiled with
1020 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1021 --enable-checking=xmallocoverrun). xfree is now used to
1022 deallocate these memory blocks.
1023
10242011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1027
1028 emacs_write: Accept and return EMACS_INT for sizes.
1029 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1030 et seq.
1031 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1032 Accept and return EMACS_INT.
1033 (emacs_gnutls_write): Return the number of bytes written on
1034 partial writes.
1035 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1036 (emacs_read, emacs_write): Remove check for negative size, as the
1037 Emacs source code has been audited now.
1038 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1039 (emacs_read, emacs_write): Use it.
1040 * process.c (send_process): Adjust to the new signatures of
1041 emacs_write and emacs_gnutls_write. Do not attempt to store
1042 a byte offset into an 'int'; it might overflow.
1043 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1044
1045 * sound.c: Don't assume sizes fit in 'int'.
1046 (struct sound_device.period_size, alsa_period_size):
1047 Return EMACS_INT, not int.
1048 (struct sound_device.write, vox_write, alsa_write):
1049 Accept EMACS_INT, not int.
1050 (wav_play, au_play): Use EMACS_INT to store sizes and to
1051 record read return values.
1052
10532011-04-15 Ben Key <bkey76@gmail.com>
1054
1055 * keyboard.c (Qundefined): Don't declare static since it is used
1056 in nsfns.m.
1057 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1058 static since they are used in nsfont.m.
1059
10602011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1061
1062 * process.c (Qprocessp): Don't declare static.
1063 * lisp.h (Qprocessp): Declare again.
1064
10652011-04-15 Juanma Barranquero <lekktu@gmail.com>
1066
1067 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1068
10692011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1070
1071 Improve C-level modularity by making more things 'static'.
1072
1073 Don't publish debugger-only interfaces to other modules.
1074 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1075 (verify_bytepos, count_markers): Move decls to the only modules
1076 that need them.
1077 * region-cache.h (pp_cache): Likewise.
1078 * window.h (check_all_windows): Likewise.
1079 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1080
1081 * sysdep.c (croak): Now static, if
1082 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1083 * syssignal.h (croak): Declare only if not static.
1084
1085 * alloc.c (refill_memory_reserve): Now static if
1086 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1087 * lisp.h (refill_memory_reserve): Declare only if not static.
1088
1089 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1090 Define only if USE_LUCID.
1091
1092 * xrdb.c (x_customization_string, x_rm_string): Now static.
1093
1094 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1095 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1096
1097 * xdisp.c (draw_row_with_mouse_face): Now static.
1098 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1099
1100 * window.h (check_all_windows): Mark externally visible.
1101
1102 * window.c (window_deletion_count): Now static.
1103
1104 * undo.c: Make symbols static if they're not exported.
1105 (last_undo_buffer, last_boundary_position, pending_boundary):
1106 Now static.
1107
1108 * textprop.c (interval_insert_behind_hooks): Now static.
1109 (interval_insert_in_front_hooks): Likewise.
1110
1111 * term.c: Make symbols static if they're not exported.
1112 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1113 (max_frame_lines, tty_set_terminal_modes):
1114 (tty_reset_terminal_modes, tty_turn_off_highlight):
1115 (get_tty_terminal): Now static.
1116 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1117 * termhooks.h (term_mouse_moveto): Do not declare if
1118 HAVE_WINDOW_SYSTEM.
1119 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1120 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1121
1122 * sysdep.c: Make symbols static if they're not exported.
1123 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1124 Now static.
1125 (sigprocmask_set, full_mask): Remove; unused.
1126 (wait_debugging): Mark as visible.
1127 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1128 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1129
1130 * syntax.c (syntax_temp): Define only if !__GNUC__.
1131
1132 * sound.c (current_sound_device, current_sound): Now static.
1133
1134 * search.c (searchbufs, searchbuf_head): Now static.
1135
1136 * scroll.c (scroll_cost): Remove; unused.
1137 * dispextern.h (scroll_cost): Remove decl.
1138
1139 * region-cache.h (pp_cache): Mark as externally visible.
1140
1141 * process.c: Make symbols static if they're not exported.
1142 (process_tick, update_tick, create_process, chan_process):
1143 (Vprocess_alist, proc_buffered_char, datagram_access):
1144 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1145 (deactivate_process): Mark defn as static, as well as decl.
1146 * lisp.h (create_process): Remove decl.
1147 * process.h (chan_process, Vprocess_alist): Remove decls.
1148
1149 * print.c: Make symbols static if they're not exported.
1150 (print_depth, new_backquote_output, being_printed, print_buffer):
1151 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1152 (print_interval, print_number_index, initial_stderr_stream):
1153 Now static.
1154 * lisp.h (Fprinc): Remove decl.
1155 (debug_output_compilation_hack): Mark as externally visible.
1156
1157 * sysdep.c (croak): Move decl from here to syssignal.h.
1158 * syssignal.h (croak): Put it here, so the API can be checked when
1159 'croak' is called from dissociate_if_controlling_tty.
1160
1161 * minibuf.c: Make symbols static if they're not exported.
1162 (minibuf_save_list, choose_minibuf_frame): Now static.
1163 * lisp.h (choose_minibuf_frame): Remove decl.
1164
1165 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1166
1167 * lread.c: Make symbols static if they're not exported.
1168 (read_objects, initial_obarray, oblookup_last_bucket_number):
1169 Now static.
1170 (make_symbol): Remove; unused.
1171 * lisp.h (initial_obarray, make_symbol): Remove decls.
1172
1173 * keyboard.c: Make symbols static if they're not exported.
1174 (single_kboard, recent_keys_index, total_keys, recent_keys):
1175 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1176 (this_single_command_key_start, echoing, last_auto_save):
1177 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1178 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1179 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1180 (Vlispy_mouse_stem, double_click_count):
1181 Now static.
1182 (force_auto_save_soon): Define only if SIGDANGER.
1183 (ignore_mouse_drag_p): Now static if
1184 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1185 (print_help): Remove; unused.
1186 (stop_character, last_timer_event): Mark as externally visible.
1187 * keyboard.h (ignore_mouse_drag_p): Declare only if
1188 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1189 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1190 * lisp.h (echoing): Remove decl.
1191 (force_auto_save_soon): Declare only if SIGDANGER.
1192 * xdisp.c (redisplay_window): Simplify code, to make it more
1193 obvious that ignore_mouse_drag_p is not accessed if !defined
1194 USE_GTK && !defined HAVE_NS.
1195
1196 * intervals.c: Make symbols static if they're not exported.
1197 (merge_properties_sticky, merge_interval_right, delete_interval):
1198 Now static.
1199 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1200
1201 * insdel.c: Make symbols static if they're not exported.
1202 However, leave prepare_to_modify_buffer alone. It's never
1203 called from outside this function, but that appears to be a bug.
1204 (combine_after_change_list, combine_after_change_buffer):
1205 (adjust_after_replace, signal_before_change): Now static.
1206 (adjust_after_replace_noundo): Remove; unused.
1207 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1208 (signal_before_change): Remove decls.
1209
1210 * indent.c (val_compute_motion, val_vmotion): Now static.
1211
1212 * image.c: Make symbols static if they're not exported.
1213 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1214 if USE_GTK.
1215 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1216 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1217
1218 * fringe.c (standard_bitmaps): Now static.
1219 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1220
1221 * frame.c: Make symbols static if they're not exported.
1222 (x_report_frame_params, make_terminal_frame): Now static.
1223 (get_frame_param): Now static, unless HAVE_NS.
1224 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1225 (x_get_resource_string): Remove; not used.
1226 * frame.h (make_terminal_frame, x_report_frame_params):
1227 (x_get_resource_string); Remove decls.
1228 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1229 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1230
1231 * font.c, fontset.c: Make symbols static if they're not exported.
1232 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1233 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1234 * font.c (font_close_object): Now static.
1235 * font.h (font_close_object): Remove.
1236 * fontset.c (FONTSET_OBJLIST): Remove.
1237 (free_realized_fontset) #if-0 the body, which does nothing.
1238 (face_suitable_for_char_p): #if-0, as it's never called.
1239 * fontset.h (face_suitable_for_char_p): Remove decl.
1240 * xfaces.c (face_at_string_position): Use
1241 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1242 since 0 is always ASCII.
1243
1244 * fns.c (weak_hash_tables): Now static.
1245
1246 * fileio.c: Make symbols static if they're not exported.
1247 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1248 (Vwrite_region_annotation_buffers): Now static.
1249
1250 * eval.c: Make symbols static if they're not exported.
1251 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1252 * lisp.h (backtrace_list): Remove decl.
1253
1254 * emacs.c: Make symbols static if they're not exported.
1255 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1256 (fatal_error_code, fatal_error_signal_hook, standard_args):
1257 Now static.
1258 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1259 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1260 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1261 * lisp.h (fatal_error_signal_hook): Remove decl.
1262 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1263
1264 * editfns.c: Move a (normally-unused) function to its only use.
1265 * editfns.c, lisp.h (get_operating_system_release): Remove.
1266 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1267 worth the hassle of breaking this out.
1268
1269 * xterm.c: Make symbols static if they're not exported.
1270 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1271 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1272 (x_destroy_window, x_delete_display):
1273 Now static.
1274 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1275 (x_mouse_leave): Remove; unused.
1276 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1277 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1278 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1279 Remove decls.
1280 (x_mouse_leave): Declare only if WINDOWSNT.
1281 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1282 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1283 USE_X_TOOLKIT.
1284
1285 * ftxfont.c: Make symbols static if they're not exported.
1286 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1287 HAVE_FREETYPE.
1288 * font.h (ftxfont_driver): Likewise.
1289
1290 * xfns.c: Make symbols static if they're not exported.
1291 (x_last_font_name, x_display_info_for_name):
1292 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1293 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1294 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1295 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1296 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1297 (last_show_tip_args): Now static.
1298 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1299 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1300 (x_screen_planes): Remove; unused.
1301 * dispextern.h (x_screen_planes): Remove decl.
1302
1303 * dispnew.c: Make symbols static if they're not exported.
1304 * dispextern.h (redraw_garbaged_frames, scrolling):
1305 (increment_row_positions): Remove.
1306 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1307 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1308 Now static.
1309 (redraw_garbaged_frames): Remove; unused.
1310
1311 * xfaces.c: Make symbols static if they're not exported.
1312 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1313 Remove decls.
1314 * xterm.h (defined_color): Remove decls.
1315 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1316 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1317 (menu_face_changed_default, defined_color, free_realized_face):
1318 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1319 (ascii_face_of_lisp_face): Remove; unused.
1320
1321 * xdisp.c: Make symbols static if they're not exported.
1322 * dispextern.h (scratch_glyph_row, window_box_edges):
1323 (glyph_to_pixel_coords, set_cursor_from_row):
1324 (get_next_display_element, set_iterator_to_next):
1325 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1326 (show_mouse_face): Remove decls
1327 * frame.h (message_buf_print): Likewise.
1328 * lisp.h (pop_message, set_message, check_point_in_composition):
1329 Likewise.
1330 * xterm.h (set_vertical_scroll_bar): Likewise.
1331 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1332 (message_buf_print, scratch_glyph_row, displayed_buffer):
1333 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1334 (get_next_display_element, show_mouse_face, window_box_edges):
1335 (frame_to_window_pixel_xy, check_point_in_composition):
1336 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1337 (glyph_to_pixel_coords): Remove; unused.
1338
1339 * dired.c (file_name_completion): Now static.
1340
1341 * dbusbind.c (xd_in_read_queued_messages): Now static.
1342
1343 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1344 * data.c (circular_list_error): Remove.
1345
1346 * commands.h (last_point_position, last_point_position_buffer):
1347 (last_point_position_window): Remove decls.
1348 * keyboard.c: Make these variables static.
1349
1350 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1351 decls.
1352 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1353 (iso_code_class, detect_coding, code_convert_region): Now static.
1354 (encode_coding_gap): Remove; unused.
1355
1356 * chartab.c (chartab_chars, chartab_bits): Now static.
1357
1358 * charset.h (charset_iso_8859_1): Remove decl.
1359 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1360 Now static.
1361
1362 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1363 * ccl.c (Vccl_program_table): Now static.
1364 (check_ccl_update): Remove; unused.
1365
1366 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1367 * category.h: ... from here.
1368 * category.c (check_category_table, set_category_set): Now static.
1369
1370 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1371 * lisp.h: Remove these decls.
1372
1373 * buffer.c (buffer_count): Remove unused var.
1374
1375 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1376 so that it's not optimized away.
1377 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1378 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1379 exported only to the debugger.
1380
1381 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1382 * atimer.h (run_all_atimers): Removed; not exported.
1383
1384 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1385 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1386 was inaccessible from Lisp.
1387 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1388 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1389
1390 alloc.c: Import and export fewer symbols, and remove unused items.
1391 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1392 is defined.
1393 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1394 it's not optimized away by whole-program optimization.
1395 (message_enable_multibyte, free_misc): Remove.
1396 (catchlist, handlerlist, mark_backtrace):
1397 Declare only if BYTE_MARK_STACK.
1398 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1399 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1400 (message_enable_multibyte): Remove decl.
1401 (free_misc, interval_free_list, float_block, float_block_index):
1402 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1403 (cons_free_list, last_marked_index):
1404 Now static.
1405 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1406 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1407 (mark_backtrace): Define only if BYTE_MARK_STACK.
1408 * xdisp.c (message_enable_multibyte): Now static.
1409
1410 Declare Lisp_Object Q* variables to be 'static' if not exported.
1411 This makes it easier for human readers (and static analyzers)
1412 to see whether these variables are used from other modules.
1413 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1414 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1415 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1416 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1417 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1418 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1419 * xmenu.c, xselect.c:
1420 Declare Q* vars static if they are not used in other modules.
1421 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1422 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1423 Remove decls of unexported vars.
1424 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1425
1426 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1427
1428 Make Emacs functions such as Fatom 'static' by default.
1429 This makes it easier for human readers (and static analyzers)
1430 to see whether these functions can be called from other modules.
1431 DEFUN now defines a static function. To make the function external
1432 so that it can be used in other C modules, use the new macro DEFUE.
1433 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1434 (Finit_image_library):
1435 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1436 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1437 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1438 Remove decls, since these functions are now static.
1439 (Funintern, Fget_internal_run_time): New decls, since these functions
1440 were already external.
1441
1442 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1443 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1444 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1445 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1446 * keyboard.c, keymap.c, lread.c:
1447 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1448 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1449 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1450 Mark functions with DEFUE instead of DEFUN,
1451 if they are used in other modules.
1452 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1453 decls for now-static functions.
1454 * buffer.h (Fdelete_overlay): Remove decl.
1455 * callproc.c (Fgetenv_internal): Mark as internal.
1456 * composite.c (Fremove_list_of_text_properties): Remove decl.
1457 (Fcomposition_get_gstring): New forward static decl.
1458 * composite.h (Fcomposite_get_gstring): Remove decl.
1459 * dired.c (Ffile_attributes): New forward static decl.
1460 * doc.c (Fdocumntation_property): New forward static decl.
1461 * eval.c (Ffetch_bytecode): New forward static decl.
1462 (Funintern): Remove extern decl; now in .h file where it belongs.
1463 * fileio.c (Fmake_symbolic_link): New forward static decl.
1464 * image.c (Finit_image_library): New forward static decl.
1465 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1466 * intervals.h (Fprevious_property_change):
1467 (Fremove_list_of_text_properties): Remove decls.
1468 * keyboard.c (Fthis_command_keys): Remove decl.
1469 (Fcommand_execute): New forward static decl.
1470 * keymap.c (Flookup_key): New forward static decl.
1471 (Fcopy_keymap): Now static.
1472 * keymap.h (Flookup_key): Remove decl.
1473 * process.c (Fget_process): New forward static decl.
1474 (Fprocess_datagram_address): Mark as internal.
1475 * syntax.c (Fsyntax_table_p): New forward static decl.
1476 (skip_chars): Remove duplicate decl.
1477 * textprop.c (Fprevious_property_change): New forward static decl.
1478 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1479 Now internal.
1480 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1481 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1482
1483 * editfns.c (Fformat): Remove unreachable code.
1484
14852011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1486
1487 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1488 change. (Bug#8496)
1489
14902011-04-13 Eli Zaretskii <eliz@gnu.org>
1491
1492 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1493 when at ZV. (Bug#8487)
1494
14952011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1496
1497 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1498 (Bug#8437)
1499 * keyboard.c (parse_tool_bar_item): Likewise.
1500 * sound.c (sound_cleanup, alsa_close): Likewise.
1501 * termcap.c (tgetent): Likewise.
1502 * xfns.c (x_default_font_parameter): Likewise.
1503 * xsettings.c (read_and_apply_settings): Likewise.
1504
1505 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1506 (overrun_check_free): Protoize.
1507
15082011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1509
1510 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1511 since callers should never pass a negative size.
1512 Change the signature to match that of plain 'read' and 'write'; see
1513 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1514 * lisp.h: Update prototypes of emacs_write and emacs_read.
1515
15162011-04-11 Eli Zaretskii <eliz@gnu.org>
1517
1518 * xdisp.c (redisplay_window): Don't try to determine the character
1519 position of the scroll margin if the window start point w->startp
1520 is outside the buffer's accessible region. (Bug#8468)
1521
15222011-04-10 Eli Zaretskii <eliz@gnu.org>
1523
1524 Fix write-region and its subroutines for buffers > 2GB.
1525 * fileio.c (a_write, e_write): Modify declaration of arguments and
1526 local variables to support buffers larger than 2GB.
1527 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1528
1529 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1530 argument, local variables, and return value.
1531
1532 * lisp.h: Update prototypes of emacs_write and emacs_read.
1533
1534 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1535
15362011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1537
1538 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1539
1540 Fix more problems found by GCC 4.6.0's static checks.
1541
1542 * xdisp.c (vmessage): Use a better test for character truncation.
1543
1544 * charset.c (load_charset_map): <, not <=, for optimization,
1545 and to avoid potential problems with integer overflow.
1546 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1547 * casetab.c (set_identity, shuffle): Likewise.
1548 * editfns.c (Fformat): Likewise.
1549 * syntax.c (skip_chars): Likewise.
1550
1551 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1552 This also lets GCC 4.6.0 generate slightly better loop code.
1553
1554 * callint.c (Fcall_interactively): <, not <=, for optimization.
1555 (Fcall_interactively): Count the number of arguments produced,
1556 not the number of arguments given. This is simpler and lets GCC
1557 4.6.0 generate slightly better code.
1558
1559 * ftfont.c: Distingish more carefully between FcChar8 and char.
1560 The previous code passed unsigned char * to a functions like
1561 strlen and xstrcasecmp that expect char *, which does not
1562 conform to the C standard.
1563 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1564 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1565 char * when the C standard requires it.
1566
1567 * keyboard.c (read_char): Remove unused var.
1568
1569 * eval.c: Port to Windows vsnprintf (Bug#8435).
1570 Include <limits.h>.
1571 (SIZE_MAX): Define if the headers do not.
1572 (verror): Do not give up if vsnprintf returns a negative count.
1573 Instead, grow the buffer. This ports to Windows vsnprintf, which
1574 does not conform to C99. Problem reported by Eli Zaretskii.
1575 Also, simplify the allocation scheme, by avoiding the need for
1576 calling realloc, and removing the ALLOCATED variable.
1577
1578 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1579
1580 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1581 But keep the doprint source code for now, as we might revamp it
1582 and use it again (Bug#8435).
1583 * lisp.h (doprnt): Remove.
1584 * Makefile.in (base_obj): Remove doprnt.o.
1585 * deps.mk (doprnt.o): Remove.
1586
1587 error: Print 32- and 64-bit integers portably (Bug#8435).
1588 Without this change, on typical 64-bit hosts error ("...%d...", N)
1589 was used to print both 32- and 64-bit integers N, which relied on
1590 undefined behavior.
1591 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1592 New macro.
1593 * lisp.h (error, verror): Mark as printf-like functions.
1594 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1595 Report overflow in size calculations when allocating printf buffer.
1596 Do not truncate output string at its first null byte.
1597 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1598 Truncate the output at a character boundary, since vsnprintf does not
1599 do that.
1600 * charset.c (check_iso_charset_parameter): Convert internal
1601 character to string before calling 'error', since %c now has the
1602 printf meaning.
1603 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1604 overflow when computing char to be passed to 'error'. Do not
1605 pass Lisp_Object to 'error'; pass the integer instead.
1606 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1607 formatted with plain %d.
1608
1609 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1610
1611 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1612
1613 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1614
1615 * xterm.c (x_catch_errors): Remove duplicate declaration.
1616
1617 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1618
1619 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1620
16212011-04-10 Jim Meyering <meyering@redhat.com>
1622
1623 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1624 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1625 return ssize_t not "int", and use size_t as the buffer length.
1626 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1627 * gnutls.h: Update declarations.
1628 * process.c (read_process_output): Use ssize_t, to match.
1629 (send_process): Likewise.
1630
16312011-04-09 Chong Yidong <cyd@stupidchicken.com>
1632
1633 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1634
16352011-04-09 Chong Yidong <cyd@stupidchicken.com>
1636
1637 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1638 unsigned char, to match FcChar8 type definition.
1639
1640 * xterm.c (handle_one_xevent):
1641 * xmenu.c (create_and_show_popup_menu):
1642 * xselect.c (x_decline_selection_request)
1643 (x_reply_selection_request): Avoid type-punned deref of X events.
1644
16452011-04-09 Eli Zaretskii <eliz@gnu.org>
1646
1647 Fix some uses of `int' instead of EMACS_INT.
1648 * search.c (string_match_1, fast_string_match)
1649 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1650 (scan_buffer, find_next_newline_no_quit)
1651 (find_before_next_newline, search_command, Freplace_match)
1652 (Fmatch_data): Make some `int' variables be EMACS_INT.
1653
1654 * xdisp.c (display_count_lines): 3rd argument and return value now
1655 EMACS_INT. All callers changed.
1656 (pint2hrstr): Last argument is now EMACS_INT.
1657
1658 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1659 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1660 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1661 (decode_coding_utf_16, decode_coding_emacs_mule)
1662 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1663 (decode_coding_ccl, decode_coding_charset)
1664 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1665 (decode_coding_iso_2022, decode_coding_emacs_mule)
1666 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1667 <char_offset, last_offset>: Declare EMACS_INT.
1668 (encode_coding_utf_8, encode_coding_utf_16)
1669 (encode_coding_emacs_mule, encode_invocation_designation)
1670 (encode_designation_at_bol, encode_coding_iso_2022)
1671 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1672 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1673 Declare EMACS_INT.
1674 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1675 (encode_invocation_designation): Last argument P_NCHARS is now
1676 EMACS_INT.
1677 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1678 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1679
1680 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1681 All users changed.
1682
1683 * ccl.c (Fccl_execute_on_string): Declare some variables
1684 EMACS_INT.
1685
16862011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1687
1688 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1689
16902011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1691
1692 * process.c (Fformat_network_address): Doc fix.
1693
16942011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1695
1696 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1697
16982011-04-08 Chong Yidong <cyd@stupidchicken.com>
1699
1700 * keyboard.c (read_char): Call Lisp function help-form-show,
1701 instead of using internal_with_output_to_temp_buffer.
1702 (Qhelp_form_show): New var.
1703 (syms_of_keyboard): Use DEFSYM macro.
1704
1705 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1706
1707 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1708
17092011-04-06 Chong Yidong <cyd@stupidchicken.com>
1710
1711 * process.c (Flist_processes): Removed to Lisp.
1712 (list_processes_1): Deleted.
1713
17142011-04-06 Eli Zaretskii <eliz@gnu.org>
1715
1716 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1717
1718 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1719
17202011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1721
1722 Fix more problems found by GCC 4.6.0's static checks.
1723
1724 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1725
1726 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1727
1728 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1729
1730 * xdisp.c (vmessage): Mark as a printf-like function.
1731
1732 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1733
1734 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1735
1736 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1737 printf-like functions.
1738 (tiff_load): Add casts to remove these marks before passing them
1739 to system-supplied API.
1740
1741 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1742
1743 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1744 This avoids several warnings with gcc -Wstrict-overflow.
1745 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1746 directly, rather than having caller test rule sign. This avoids
1747 some unnecessary tests.
1748 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1749 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1750 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1751
1752 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1753 (xfont_open): Avoid unnecessary tests.
1754
1755 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1756
1757 * composite.h, composite.c (composition_gstring_put_cache):
1758 Use EMACS_INT, not int, for length.
1759
1760 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1761 breaking out part of COMPOSITION_DECODE_RULE.
1762 (COMPOSITION_DECODE_RULE): Use it.
1763 * composite.c (get_composition_id): Remove unused local vars,
1764 by using the new macro.
1765
1766 * textprop.c (set_text_properties_1): Change while to do-while,
1767 since the condition is always true at first.
1768
1769 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1770 (interval_deletion_adjustment): Return unsigned value.
1771 All uses changed.
1772
1773 * process.c (list_processes_1, create_pty, read_process_output):
1774 (exec_sentinel): Remove vars that were set but not used.
1775 (create_pty): Remove unnecessary "volatile"s.
1776 (Fnetwork_interface_info): Avoid possibility of int overflow.
1777 (read_process_output): Do adaptive read buffering even if carryover.
1778 (read_process_output): Simplify nbytes computation if buffered.
1779
1780 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1781
1782 * syntax.c (scan_words): Remove var that was set but not used.
1783 (update_syntax_table): Use unsigned instead of int.
1784
1785 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1786 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1787 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1788
1789 * print.c (print_error_message): Avoid int overflow.
1790
1791 * font.c (font_list_entities): Redo for clarity,
1792 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1793
1794 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1795 (font_score): Avoid potential overflow in diff calculation.
1796
1797 * fns.c (substring_both): Remove var that is set but not used.
1798 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1799
1800 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1801
1802 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1803 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1804 can always succeed if overflow has undefined behavior.
1805
1806 * search.c (boyer_moore, wordify): Remove vars set but not used.
1807 (wordify): Omit three unnecessary tests.
1808
1809 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1810 All callers changed. This avoids the need for an unused var.
1811
1812 * casefiddle.c (casify_region): Remove var that is set but not used.
1813
1814 * dired.c (file_name_completion): Remove var that is set but not used.
1815
1816 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1817
1818 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1819 (Finsert_file_contents): Remove unnecessary code checking fd.
1820
1821 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1822 Check for integer overflow on size calculations.
1823
1824 * buffer.c (Fprevious_overlay_change): Remove var that is set
1825 but not used.
1826
1827 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1828 Remove vars that are set but not used.
1829 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1830 (timer_check_2): Mark vars as initialized.
1831
1832 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1833
1834 * image.c (lookup_image): Remove var that is set but not used.
1835 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1836
1837 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1838 that are set but not used.
1839
1840 * xfns.c (make_invisible_cursor): Don't return garbage
1841 if XCreateBitmapFromData fails (Bug#8410).
1842
1843 * xselect.c (x_get_local_selection, x_handle_property_notify):
1844 Remove vars that are set but not used.
1845
1846 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1847 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1848
1849 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1850 Remove var that is set but not used.
1851 (scroll_bar_windows_size): Now size_t, not int.
1852 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1853 Check for overflow.
1854
1855 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1856 (map_tty_color) [!defined MSDOS]: Likewise.
1857
1858 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1859
1860 * coding.c: Remove vars that are set but not used.
1861 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1862 All callers changed.
1863 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1864 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1865 (decode_coding_charset): Remove vars that are set but not used.
1866
1867 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1868 that is set but not used.
1869
1870 * print.c (print_object): Remove var that is set but not used.
1871
1872 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1873 The gnulib version avoids calling malloc in the usual case,
1874 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1875 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1876 * filelock.c (current_lock_owner): Likewise.
1877 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1878 * sysdep.c: Include allocator.h, careadlinkat.h.
1879 (emacs_no_realloc_allocator): New static constant.
1880 (emacs_readlink): New function.
1881 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1882 ../lib/careadlinkat.h.
1883
18842011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1885
1886 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1887 first non-nil return value).
1888
18892011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1890
1891 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1892 if not defined (Bug#8403).
1893
18942011-04-02 Juanma Barranquero <lekktu@gmail.com>
1895
1896 * xdisp.c (display_count_lines): Remove parameter `start',
1897 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1898 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1899 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1900 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1901 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1902 and thereabouts. All callers changed.
1903 (get_per_char_metric): Remove parameter `f', unused since
1904 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1905
19062011-04-02 Jim Meyering <meyering@redhat.com>
1907
1908 do not dereference NULL upon failed strdup
1909 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1910 (ns_get_family): Likewise.
1911
19122011-04-02 Juanma Barranquero <lekktu@gmail.com>
1913
1914 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1915
19162011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1917
1918 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1919 later (Bug#8403).
1920
19212011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1922
1923 Add lexical binding.
1924
1925 * window.c (Ftemp_output_buffer_show): New fun.
1926 (Fsave_window_excursion):
1927 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1928
1929 * lread.c (lisp_file_lexically_bound_p): New function.
1930 (Fload): Bind Qlexical_binding.
1931 (readevalloop): Remove `evalfun' arg.
1932 Bind Qinternal_interpreter_environment.
1933 (Feval_buffer): Bind Qlexical_binding.
1934 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1935 Mark as dynamic.
1936 (syms_of_lread): Declare `lexical-binding'.
1937
1938 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1939
1940 * keyboard.c (eval_dyn): New fun.
1941 (menu_item_eval_property): Use it.
1942
1943 * image.c (parse_image_spec): Use Ffunctionp.
1944
1945 * fns.c (concat, mapcar1): Accept byte-code-functions.
1946
1947 * eval.c (Fsetq): Handle lexical vars.
1948 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1949 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1950 (FletX, Flet): Obey lexical binding.
1951 (Fcommandp): Handle closures.
1952 (Feval): New `lexical' arg.
1953 (eval_sub): New function extracted from Feval. Use it almost
1954 everywhere where Feval was used. Look up vars in lexical env.
1955 Handle closures.
1956 (Ffunctionp): Move from subr.el.
1957 (Ffuncall): Handle closures.
1958 (apply_lambda): Remove `eval_flags'.
1959 (funcall_lambda): Handle closures and new byte-code-functions.
1960 (Fspecial_variable_p): New function.
1961 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1962 but without exporting it to Lisp.
1963
1964 * doc.c (Fdocumentation, store_function_docstring):
1965 * data.c (Finteractive_form): Handle closures.
1966
1967 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1968 interactive spec.
1969
1970 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1971 byte-codes.
1972 (exec_byte_code): New function extracted from Fbyte_code to handle new
1973 calling convention for byte-code-functions. Add new byte-codes.
1974
1975 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1976
1977 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1978
19792011-03-31 Juanma Barranquero <lekktu@gmail.com>
1980
1981 * xdisp.c (redisplay_internal): Fix prototype.
1982
19832011-03-31 Eli Zaretskii <eliz@gnu.org>
1984
1985 * xdisp.c (SCROLL_LIMIT): New macro.
1986 (try_scrolling): Use it when setting scroll_limit. Limit
1987 scrolling to 100 screen lines.
1988 (redisplay_window): Even when falling back on "recentering",
1989 position point in the window according to scroll-conservatively,
1990 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1991
1992 (try_scrolling): When point is above the window, allow searching
1993 as far as scroll_max, or one screenful, to compute vertical
1994 distance from PT to the scroll margin position. This prevents
1995 try_scrolling from unnecessarily failing when
1996 scroll-conservatively is set to a value slightly larger than the
1997 window height. Clean up the case of PT below the margin at bottom
1998 of window: scroll_max can no longer be INT_MAX. When aggressive
1999 scrolling is in use, don't let point enter the opposite scroll
2000 margin as result of the scroll.
2001 (syms_of_xdisp) <scroll-conservatively>: Document the
2002 threshold of 100 lines for never-recentering scrolling.
2003
20042011-03-31 Juanma Barranquero <lekktu@gmail.com>
2005
2006 * dispextern.h (move_it_by_lines):
2007 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2008 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2009 (message_log_check_duplicate): Remove parameters `prev_bol' and
2010 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2011 (redisplay_internal): Remove parameter `preserve_echo_area',
2012 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2013
2014 * indent.c (Fvertical_motion):
2015 * window.c (window_scroll_pixel_based, Frecenter):
2016 Don't pass `need_y_p' to `move_it_by_lines'.
2017
20182011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2019
2020 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2021 steal a few bits to be more compact.
2022 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2023 Remove unneeded casts.
2024
2025 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2026
20272011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2028
2029 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2030 binding" message (bug#7967).
2031
20322011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2033
2034 Fix more problems found by GCC 4.6.0's static checks.
2035
2036 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2037 Remove unused local var.
2038
2039 * editfns.c (Fmessage_box): Remove unused local var.
2040
2041 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2042 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2043 Omit unused local vars.
2044 * window.c (shrink_windows): Omit unused local var.
2045 * menu.c (digest_single_submenu): Omit unused local var.
2046 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2047 Omit unused local var.
2048
2049 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2050 Don't assume string length fits in int.
2051 (keyremap_step, read_key_sequence): Use size_t for sizes.
2052 (read_key_sequence): Don't check last_real_key_start redundantly.
2053
2054 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2055 instead of alloca (Bug#8344).
2056
2057 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2058 (Fbacktrace_frame): Don't assume nframes fits in int.
2059
2060 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2061
2062 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2063 concerns.
2064
2065 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2066
2067 * cm.c (calccost): Turn while-do into do-while, for clarity.
2068
2069 * keyboard.c (syms_of_keyboard): Use the same style as later
2070 in this function when indexing through an array. This also
2071 works around GCC bug 48267.
2072
2073 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2074
2075 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2076
2077 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2078 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2079
2080 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2081 This avoids undefined behavior on integer overflow, and is a bit
2082 more convenient anyway since it is compared to a size_t variable.
2083
2084 Variadic C functions now count arguments with size_t, not int.
2085 This avoids an unnecessary limitation on 64-bit machines, which
2086 caused (substring ...) to crash on large vectors (Bug#8344).
2087 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2088 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2089 All variadic functions and their callers changed accordingly.
2090 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2091 * data.c (arith_driver, float_arith_driver): Likewise.
2092 * editfns.c (general_insert_function): Likewise.
2093 * eval.c (struct backtrace.nargs, interactive_p)
2094 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2095 (funcall_lambda, mark_backtrace): Likewise.
2096 * fns.c (concat): Likewise.
2097 * frame.c (x_set_frame_parameters): Likewise.
2098 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2099 0 if not found, not -1. All callers changed.
2100
2101 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2102 (stack_copy_size): Now size_t, not int.
2103 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2104
21052011-03-28 Juanma Barranquero <lekktu@gmail.com>
2106
2107 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2108 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2109 All callers changed.
2110
2111 * lisp.h (multibyte_char_to_unibyte):
2112 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2113 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2114 * character.h (CHAR_TO_BYTE8):
2115 * cmds.c (internal_self_insert):
2116 * editfns.c (general_insert_function):
2117 * keymap.c (push_key_description):
2118 * search.c (Freplace_match):
2119 * xdisp.c (message_dolog, set_message_1): All callers changed.
2120
21212011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2122
2123 * keyboard.c (safe_run_hook_funcall): New function.
2124 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2125 don't set the hook to nil, but remove the offending function instead.
2126 (Qcommand_hook_internal): Remove, unused.
2127 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2128 Vcommand_hook_internal.
2129
2130 * eval.c (enum run_hooks_condition): Remove.
2131 (funcall_nil, funcall_not): New functions.
2132 (run_hook_with_args): Call each function through a `funcall' argument.
2133 Remove `cond' argument, now redundant.
2134 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2135 (Frun_hook_with_args_until_failure): Adjust accordingly.
2136 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2137
21382011-03-28 Juanma Barranquero <lekktu@gmail.com>
2139
2140 * dispextern.h (string_buffer_position): Remove declaration.
2141
2142 * print.c (strout): Remove parameter `multibyte', unused since
2143 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2144
2145 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2146 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2147 All callers changed.
2148
2149 * w32.c (_wsa_errlist): Use braces for struct initializers.
2150
2151 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2152 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2153 All callers changed.
2154 (string_buffer_position): Likewise. Also, make static (it's never
2155 used outside xdisp.c).
2156 (cursor_row_p): Remove parameter `w', unused since
2157 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2158 (decode_mode_spec): Remove parameter `precision', introduced during
2159 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2160 All callers changed.
2161
21622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2163
2164 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2165
21662011-03-27 Anders Lindgren <andlind@gmail.com>
2167
2168 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2169 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2170 (ns_update_auto_hide_menu_bar): New functions.
2171 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2172 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2173 ns_constrain_all_frames.
2174 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2175 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2176
21772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2178
2179 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2180
21812011-03-27 Glenn Morris <rgm@gnu.org>
2182
2183 * syssignal.h: Replace RETSIGTYPE with void.
2184 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2185 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2186 Replace SIGTYPE with void everywhere.
2187 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2188 * s/template.h (SIGTYPE): Remove commented out definition.
2189
21902011-03-26 Eli Zaretskii <eliz@gnu.org>
2191
2192 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2193 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2194
21952011-03-26 Juanma Barranquero <lekktu@gmail.com>
2196
2197 * w32.c (read_unc_volume): Use parameter `henum', instead of
2198 global variable `wget_enum_handle'.
2199
2200 * keymap.c (describe_vector): Remove parameters `indices' and
2201 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2202 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2203
2204 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2205
2206 * keyboard.c (timer_check): Remove parameter `do_it_now',
2207 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2208 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2209 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2210
2211 * keyboard.c (read_char):
2212 * w32menu.c (w32_menu_display_help):
2213 * xmenu.c (show_help_event, menu_help_callback):
2214 Adjust calls to `show_help_echo'.
2215
2216 * gtkutil.c (xg_maybe_add_timer):
2217 * keyboard.c (readable_events):
2218 * process.c (wait_reading_process_output):
2219 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2220
2221 * insdel.c (adjust_markers_gap_motion):
2222 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2223 (gap_left, gap_right): Don't call it.
2224
22252011-03-25 Chong Yidong <cyd@stupidchicken.com>
2226
2227 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2228 incurred during fontification.
2229
22302011-03-25 Juanma Barranquero <lekktu@gmail.com>
2231
2232 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2233 (DEFVAR_PER_BUFFER): Don't pass it.
2234
2235 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2236 (scrolling_window): Don't pass it.
2237
22382011-03-25 Juanma Barranquero <lekktu@gmail.com>
2239
2240 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2241
2242 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2243 and `suffix'.
2244 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2245 of variables specific to SELinux and computation of `encoded_absname'.
2246
2247 * image.c (XPutPixel): Remove unused variable `height'.
2248
2249 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2250
2251 * unexw32.c (get_section_info): Remove unused variable `section'.
2252
2253 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2254 (system_process_attributes): Remove unused variable `sess'.
2255 (sys_read): Remove unused variable `err'.
2256
2257 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2258 (w32_wnd_proc): Remove unused variable `isdead'.
2259 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2260 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2261 (x_create_tip_frame): Remove unused variable `tem'.
2262
2263 * w32inevt.c (w32_console_read_socket):
2264 Remove unused variable `no_events'.
2265
2266 * w32term.c (x_draw_composite_glyph_string_foreground):
2267 Remove unused variable `width'.
2268
22692011-03-24 Juanma Barranquero <lekktu@gmail.com>
2270
2271 * w32term.c (x_set_glyph_string_clipping):
2272 Don't pass uninitialized region to CombineRgn.
2273
22742011-03-23 Juanma Barranquero <lekktu@gmail.com>
2275
2276 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2277 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2278 (Fx_close_connection): Remove unused variable `i'.
2279
2280 * w32font.c (w32font_draw): Return number of glyphs.
2281 (w32font_open_internal): Remove unused variable `i'.
2282 (w32font_driver): Add missing initializer.
2283
2284 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2285 (fill_in_menu): Remove unused variable `items_added'.
2286
2287 * w32term.c (last_mouse_press_frame): Remove static global variable.
2288 (w32_clip_to_row): Remove unused variable `f'.
2289 (x_delete_terminal): Remove unused variable `i'.
2290
2291 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2292 (NOTHING): Remove unused static global variable.
2293 (uniscribe_check_otf): Remove unused variable `table'.
2294 (uniscribe_font_driver): Add missing initializers.
2295
22962011-03-23 Julien Danjou <julien@danjou.info>
2297
2298 * term.c (Fsuspend_tty, Fresume_tty):
2299 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2300 * window.c (temp_output_buffer_show):
2301 * insdel.c (signal_before_change):
2302 * frame.c (Fhandle_switch_frame):
2303 * fileio.c (Fdo_auto_save):
2304 * emacs.c (Fkill_emacs):
2305 * editfns.c (save_excursion_restore):
2306 * cmds.c (internal_self_insert):
2307 * callint.c (Fcall_interactively):
2308 * buffer.c (Fkill_all_local_variables):
2309 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2310 Use Frun_hooks.
2311 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2312 unconditionnaly since it does the check itself.
2313
23142011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 Fix more problems found by GCC 4.5.2's static checks.
2317
2318 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2319 the first time through the loop, since we know p0 < p1 then.
2320 This also avoids a gcc -Wstrict-overflow warning.
2321
2322 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2323 leading to a memory leak, possible in functions like
2324 load_charset_map_from_file that can allocate an unbounded number
2325 of objects (Bug#8318).
2326
2327 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2328 that could (at least in theory) be that large.
2329
2330 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2331 This is less likely to overflow, and avoids undefined behavior if
2332 overflow does occur. All callers changed. Use strtoul to scan
2333 for the unsigned long integer.
2334 (pint2hrstr): Simplify and tune code slightly.
2335 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2336
2337 * scroll.c (do_scrolling): Work around GCC bug 48228.
2338 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2339
2340 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2341 This also avoids a warning with gcc -Wstrict-overflow.
2342 (validate_x_resource_name): Simplify count usage.
2343 This also avoids a warning with gcc -Wstrict-overflow.
2344
2345 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2346 fail (Bug#8306).
2347
2348 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2349
2350 * process.c (Fmake_network_process): Use socklen_t, not int,
2351 where POSIX says socklen_t is required in portable programs.
2352 This fixes a porting bug on hosts like 64-bit HP-UX, where
2353 socklen_t is wider than int (Bug#8277).
2354 (Fmake_network_process, server_accept_connection):
2355 (wait_reading_process_output, read_process_output):
2356 Likewise.
2357
2358 * process.c: Rename or move locals to avoid shadowing.
2359 (list_processes_1, Fmake_network_process):
2360 (read_process_output_error_handler, exec_sentinel_error_handler):
2361 Rename or move locals.
2362 (Fmake_network_process): Define label "retry_connect" only if needed.
2363 (Fnetwork_interface_info): Fix pointer signedness.
2364 (process_send_signal): Add cast to avoid pointer signedness problem.
2365 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2366 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2367
2368 Make tparam.h and terminfo.c consistent.
2369 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2370 Include tparam.h instead, since it declares them.
2371 * cm.h (PC): Remove extern decl; tparam.h now does this.
2372 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2373 * terminfo.c: Include tparam.h, to check interfaces.
2374 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2375 (tparam): Adjust signature to match interface in tparam.h;
2376 this removes some undefined behavior. Check that outstring and len
2377 are zero, which they always are with Emacs.
2378 * tparam.h (PC, BC, UP): New extern decls.
2379
2380 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2381 (xftfont_open): Rename locals to avoid shadowing.
2382
2383 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2384 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2385 (OTF_TAG_SYM): Omit macro if not needed.
2386 (ftfont_list): Remove unused local.
2387 (get_adstyle_property, ftfont_pattern_entity):
2388 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2389 Rename locals to avoid shadowing.
2390
2391 * xfont.c (xfont_list_family): Mark var as initialized.
2392
2393 * xml.c (make_dom): Now static.
2394
2395 * composite.c (composition_compute_stop_pos): Rename local to
2396 avoid shadowing.
2397 (composition_reseat_it): Remove unused locals.
2398 (find_automatic_composition, composition_adjust_point): Likewise.
2399 (composition_update_it): Mark var as initialized.
2400 (find_automatic_composition): Mark vars as initialized,
2401 with a FIXME (Bug#8290).
2402
2403 character.h: Rename locals to avoid shadowing.
2404 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2405 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2406 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2407 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2408 to avoid shadowing.
2409
2410 * textprop.c (property_change_between_p): Remove; unused.
2411
2412 * intervals.c (interval_start_pos): Now static.
2413
2414 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2415
2416 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2417 Rename locals to avoid shadowing.
2418
2419 * sound.c (wav_play, au_play, Fplay_sound_internal):
2420 Fix pointer signedness.
2421 (alsa_choose_format): Remove unused local var.
2422 (wav_play): Initialize a variable to 0, to prevent undefined
2423 behavior (Bug#8278).
2424
2425 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2426
2427 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2428
2429 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2430 clobbering (Bug#8298).
2431 * sysdep.c (sys_subshell): Likewise.
2432 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2433
2434 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2435 This should get cleaned up, so that child_setup has the
2436 same signature on all platforms.
2437
2438 * callproc.c (call_process_cleanup): Now static.
2439 (relocate_fd): Rename locals to avoid shadowing.
2440
24412011-03-22 Chong Yidong <cyd@stupidchicken.com>
2442
2443 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2444 not to be necessary, and produces flickering.
2445
24462011-03-20 Glenn Morris <rgm@gnu.org>
2447
2448 * config.in: Remove file.
2449
24502011-03-20 Juanma Barranquero <lekktu@gmail.com>
2451
2452 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2453 are now in src/globals.h.
2454 (syms_of_minibuf): Remove spurious & from previous change.
2455
24562011-03-20 Leo <sdl.web@gmail.com>
2457
2458 * minibuf.c (completing-read-function): New variable.
2459 (completing-read-default): Rename from completing-read.
2460 (completing-read): Call completing-read-function.
2461
24622011-03-19 Juanma Barranquero <lekktu@gmail.com>
2463
2464 * xfaces.c (Fx_load_color_file):
2465 Read color file from absolute filename (bug#8250).
2466
24672011-03-19 Juanma Barranquero <lekktu@gmail.com>
2468
2469 * makefile.w32-in: Update dependencies.
2470
24712011-03-17 Eli Zaretskii <eliz@gnu.org>
2472
2473 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2474
24752011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2476
2477 Fix more problems found by GCC 4.5.2's static checks.
2478
2479 * process.c (make_serial_process_unwind, send_process_trap):
2480 (sigchld_handler): Now static.
2481
2482 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2483 That way, the code declares only the vars that it needs.
2484 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2485 * s/cygwin.h (PTY_ITERATION): Likewise.
2486 * s/darwin.h (PTY_ITERATION): Likewise.
2487 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2488
2489 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2490 * process.c (allocate_pty): Don't declare stb unless it's needed.
2491
2492 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2493 (CONSTANTLIM): Remove; unused.
2494 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2495 Define only if needed.
2496
2497 * unexelf.c (unexec): Name an expression,
2498 to avoid gcc -Wbad-function-cast warning.
2499 Use a different way to cause a compilation error if anyone uses
2500 n rather than nn, a way that does not involve shadowing.
2501 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2502
2503 * deps.mk (unexalpha.o): Remove; unused.
2504
2505 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2506 * unexec.h: New file.
2507 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2508 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2509 Depend on unexec.h.
2510 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2511 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2512 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2513 Change as necessary to match prototype in unexec.h.
2514
2515 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2516 shadowing.
2517 (back_comment, skip_chars): Mark vars as initialized.
2518
2519 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2520 Rename locals to avoid shadowing.
2521
2522 * lread.c (read1): Rewrite so as not to use empty "else".
2523 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2524
2525 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2526
2527 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2528 warning when compiling print.c.
2529
2530 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2531 instead of using an uninitialized var.
2532 (font_sort_entities): Mark var as initialized.
2533
2534 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2535
2536 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2537 pointers to constants.
2538 (font_parse_fcname): Remove unused vars.
2539 (font_delete_unmatched): Now static.
2540 (font_get_spec): Remove; unused.
2541 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2542 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2543 Rename or move locals to avoid shadowing.
2544
2545 * fns.c (require_nesting_list, require_unwind): Now static.
2546 (Ffillarray): Rename locals to avoid shadowing.
2547
2548 * floatfns.c (domain_error2): Define only if needed.
2549 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2550
2551 * alloc.c (mark_backtrace): Move decl from here ...
2552 * lisp.h: ... to here, so that it can be checked.
2553
2554 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2555 (Fdefvar): Rewrite so as not to use empty "else".
2556 (lisp_indirect_variable): Name an expression,
2557 to avoid gcc -Wbad-function-cast warning.
2558 (Fdefvar): Rename locals to avoid shadowing.
2559
2560 * callint.c (quotify_arg, quotify_args): Now static.
2561 (Fcall_interactively): Rename locals to avoid shadowing.
2562 Use const pointer when appropriate.
2563
2564 * lisp.h (get_system_name, get_operating_system_release):
2565 Move decls here, to check interfaces.
2566 * process.c (get_operating_system_release): Move decl to lisp.h.
2567 * xrdb.c (get_system_name): Likewise.
2568 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2569 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2570 some of which prompt warnings from gcc -Wbad-function-cast.
2571 (Fformat_time_string, Fencode_time, Finsert_char):
2572 (Ftranslate_region_internal, Fformat):
2573 Rename or remove local vars to avoid shadowing.
2574 (Ftranslate_region_internal): Mark var as initialized.
2575
2576 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2577 avoid shadowing.
2578
2579 * lisp.h (eassert): Check that the argument compiles, even if
2580 ENABLE_CHECKING is not defined.
2581
2582 * data.c (Findirect_variable): Name an expression, to avoid
2583 gcc -Wbad-function-cast warning.
2584 (default_value, arithcompare, arith_driver, arith_error): Now static.
2585 (store_symval_forwarding): Rename local to avoid shadowing.
2586 (Fmake_variable_buffer_local, Fmake_local_variable):
2587 Mark variables as initialized.
2588 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2589
2590 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2591 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2592 Rename locals to avoid shadowing.
2593 (mark_stack): Move local variables into the #ifdef region where
2594 they're used.
2595 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2596 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2597 needed otherwise.
2598 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2599 (GC_STRING_CHARS): Remove; not used.
2600 (Fmemory_limit): Cast sbrk's returned value to char *.
2601
2602 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2603 avoids undefined behavior in theory.
2604
2605 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2606
2607 Use functions, not macros, for up- and down-casing (Bug#8254).
2608 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2609 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2610 to use the following functions instead of these macros.
2611 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2612 EMACS_INT, since callers assume the returned value fits in int.
2613 (upcase1): Likewise, for UPCASE_TABLE.
2614 (uppercasep, lowercasep, upcase): New static inline functions.
2615 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2616 the race-condition problem in the old DOWNCASE.
2617
2618 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2619 Rename locals to avoid shadowing.
2620 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2621 (regex_compile, re_search_2, re_match_2_internal):
2622 Remove unused local vars.
2623 (FREE_VAR): Rewrite so as not to use empty "else",
2624 which gcc can warn about.
2625 (regex_compile, re_match_2_internal): Mark locals as initialized.
2626 (RETALLOC_IF): Define only if needed.
2627 (WORDCHAR_P): Likewise. This one is never needed, but is used
2628 only in a comment talking about a compiler bug, so put inside
2629 the #if 0 of that comment.
2630 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2631 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2632 Remove; unused.
2633
2634 * search.c (boyer_moore): Rename locals to avoid shadowing.
2635 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2636 (PREV_CHAR_BOUNDARY): Likewise.
2637
2638 * search.c (simple_search): Remove unused var.
2639
2640 * dired.c (compile_pattern): Move decl from here ...
2641 * lisp.h: ... to here, so that it can be checked.
2642 (struct re_registers): New forward decl.
2643
2644 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2645
2646 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2647 All uses changed.
2648 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2649 Rename locals to avoid shadowing.
2650 (Fvertical_motion): Mark locals as initialized.
2651
2652 * casefiddle.c (casify_object, casify_region): Now static.
2653 (casify_region): Mark local as initialized.
2654
2655 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2656
2657 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2658 New macros, so that the caller can use some names other than
2659 gcpro1, gcpro2, etc.
2660 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2661 of the new macros.
2662 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2663 argument, for consistency with GCPRO2_VAR, etc: it is now the
2664 prefix of the variable, not the variable itself. All uses
2665 changed.
2666 * dired.c (directory_files_internal, file_name_completion):
2667 Rename locals to avoid shadowing.
2668
2669 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2670 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2671 dired.c's scmp function, had undefined behavior.
2672 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2673 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2674 * buffer.h: ... to here, because these macros use current_buffer,
2675 and the new implementation with inline functions needs to have
2676 current_buffer in scope now, rather than later when the macros
2677 are used.
2678 (downcase, upcase1): New static inline functions.
2679 (DOWNCASE, UPCASE1): Reimplement using these functions.
2680 This avoids undefined behavior in expressions like
2681 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2682 from race conditions in accessing the global variables
2683 case_temp1 and case_temp2.
2684 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2685 * lisp.h (case_temp1, case_temp2): Remove their decls.
2686 * character.h (ASCII_CHAR_P): Move from here ...
2687 * lisp.h: ... to here, so that the inline functions mentioned
2688 above can use them.
2689
2690 * dired.c (directory_files_internal_unwind): Now static.
2691
2692 * fileio.c (file_name_as_directory, directory_file_name):
2693 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2694 Now static.
2695 (file_name_as_directory): Use const pointers when appropriate.
2696 (Fexpand_file_name): Likewise. In particular, newdir might
2697 point at constant storage, so make it a const pointer.
2698 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2699 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2700 signedness issues.
2701 (Fset_file_times, Finsert_file_contents, auto_save_error):
2702 Rename locals to avoid shadowing.
2703
2704 * minibuf.c (choose_minibuf_frame_1): Now static.
2705 (Ftry_completion, Fall_completions): Rename or remove locals
2706 to avoid shadowing.
2707
2708 * marker.c (bytepos_to_charpos): Remove; unused.
2709
2710 * lisp.h (verify_bytepos, count_markers): New decls,
2711 so that gcc does not warn that these functions aren't declared.
2712
2713 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2714 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2715 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2716 (copy_text): Remove unused local var.
2717
2718 * filelock.c (within_one_second): Now static.
2719 (lock_file_1): Rename local to avoid shadowing.
2720
2721 * buffer.c (fix_overlays_before): Mark locals as initialized.
2722 (fix_start_end_in_overlays): Likewise. This function should be
2723 simplified by using pointers-to-pointers, but that's a different
2724 matter.
2725 (switch_to_buffer_1): Now static.
2726 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2727 (report_overlay_modification): Rename locals to avoid shadowing.
2728
2729 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2730 Fix pointer signedness issue.
2731 (sys_subshell): Mark local as volatile if checking for lint,
2732 to suppress a gcc -Wclobbered warning that does not seem to be right.
2733 (MAXPATHLEN): Define only if needed.
2734
2735 * process.c (serial_open, serial_configure): Move decls from here ...
2736 * systty.h: ... to here, so that they can be checked.
2737
2738 * fns.c (get_random, seed_random): Move extern decls from here ...
2739 * lisp.h: ... to here, so that they can be checked.
2740
2741 * sysdep.c (reset_io): Now static.
2742 (wait_for_termination_signal): Remove; unused.
2743
2744 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2745 (copy_keymap_item, append_key, push_text_char_description):
2746 Now static.
2747 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2748 (DENSE_TABLE_SIZE): Remove; unused.
2749 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2750 (describe_map_tree):
2751 Rename locals to avoid shadowing.
2752
2753 * keyboard.c: Declare functions static if they are not used elsewhere.
2754 (echo_char, echo_dash, cmd_error, top_level_2):
2755 (poll_for_input, handle_async_input): Now static.
2756 (read_char, kbd_buffer_get_event, make_lispy_position):
2757 (make_lispy_event, make_lispy_movement, apply_modifiers):
2758 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2759 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2760 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2761 (read_key_sequence, read_char): Mark locals as initialized.
2762 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2763
2764 * keyboard.h (make_ctrl_char): New decl.
2765 (mark_kboards): Move decl here ...
2766 * alloc.c (mark_kboards): ... from here.
2767
2768 * lisp.h (force_auto_save_soon): New decl.
2769
2770 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2771 (DEFINE_DUMMY_FUNCTION): New macro.
2772 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2773 Use it.
2774 (main): Add casts to avoid warnings
2775 if GCC considers string literals to be constants.
2776
2777 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2778
2779 * dbusbind.c: Pointer signedness fixes.
2780 (xd_signature, xd_append_arg, xd_initialize):
2781 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2782 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2783 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2784 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2785
2786 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2787 if GCC considers string literals to be constants.
2788 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2789
27902011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2791
2792 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2793 (print_preprocess, print_object): New macro to fix last change.
2794
2795 * print.c (print_preprocess): Don't forget font objects.
2796
27972011-03-16 Juanma Barranquero <lekktu@gmail.com>
2798
2799 * emacs.c (USAGE3): Doc fixes.
2800
28012011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2802
2803 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2804 structure.
2805
28062011-03-14 Juanma Barranquero <lekktu@gmail.com>
2807
2808 * lisp.h (VWindow_system, Qfile_name_history):
2809 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2810 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2811 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2812
2813 * w32select.c: Don't #include "keyboard.h".
2814 (run_protected): Add extern declaration for waiting_for_input.
2815
2816 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2817 * w32console.c (detect_input_pending, read_input_pending)
2818 (encode_terminal_code):
2819 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2820 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2821 (w32_system_caret_y, Qfile_name_history):
2822 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2823 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2824 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2825 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2826 * w32proc.c (Qlocal, report_file_error):
2827 * w32term.c (Vwindow_system, updating_frame):
2828 * w32uniscribe.c (initialized, uniscribe_font_driver):
2829 Remove unneeded extern declarations.
2830
28312011-03-14 Chong Yidong <cyd@stupidchicken.com>
2832
2833 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2834
28352011-03-13 Chong Yidong <cyd@stupidchicken.com>
2836
2837 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2838 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2839 These macros can no longer be used for assignment.
2840
2841 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2842 Assign struct members directly, instead of using BUF_BEGV etc.
2843 (record_buffer_markers, fetch_buffer_markers): New functions for
2844 recording and fetching special buffer markers.
2845 (set_buffer_internal_1, set_buffer_temp): Use them.
2846
2847 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2848
2849 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2850
2851 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2852 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2853
2854 * xdisp.c (hscroll_window_tree):
2855 (reconsider_clip_changes): Use PT instead of BUF_PT.
2856
28572011-03-13 Eli Zaretskii <eliz@gnu.org>
2858
2859 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2860 $(EMACS_ROOT)/lib/intprops.h.
2861
28622011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2863
2864 Fix more problems found by GCC 4.5.2's static checks.
2865
2866 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2867 to unsigned char * to avoid compiler diagnostic.
2868 (xg_free_frame_widgets): Make it clear that a local variable is
2869 needed only if USE_GTK_TOOLTIP.
2870 (gdk_window_get_screen): Make it clear that this macro is needed
2871 only if USE_GTK_TOOLTIP.
2872 (int_gtk_range_get_value): New function, which avoids a diagnostic
2873 from gcc -Wbad-function-cast.
2874 (xg_set_toolkit_scroll_bar_thumb): Use it.
2875 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2876 diagnostic from gcc -Wbad-function-cast.
2877 (get_utf8_string, xg_get_file_with_chooser):
2878 Rename locals to avoid shadowing.
2879 (create_dialog): Move locals to avoid shadowing.
2880
2881 * xgselect.c (xg_select): Remove unused var.
2882
2883 * image.c (four_corners_best): Mark locals as initialized.
2884 (gif_load): Initialize transparent_p to zero (Bug#8238).
2885 Mark another local as initialized.
2886 (my_png_error, my_error_exit): Mark with NO_RETURN.
2887
2888 * image.c (clear_image_cache): Now static.
2889 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2890 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2891 (x_edge_detection): Remove unnecessary cast that
2892 gcc -Wbad-function-cast diagnoses.
2893 (gif_load): Fix pointer signedness.
2894 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2895 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2896
28972011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 Improve quality of tests for time stamp overflow.
2900 For example, without this patch (encode-time 0 0 0 1 1
2901 1152921504606846976) returns the obviously-bogus value (-948597
2902 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2903 reports time overflow. See
2904 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2905 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2906 * editfns.c: Include limits.h and intprops.h.
2907 (TIME_T_MIN, TIME_T_MAX): New macros.
2908 (time_overflow): Move earlier, to before first use.
2909 (hi_time, lo_time): New functions, for an accurate test for
2910 out-of-range times.
2911 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2912 (Fget_internal_run_time): Don't assume time_t fits in int.
2913 (make_time): Use list2 instead of Fcons twice.
2914 (Fdecode_time): More accurate test for out-of-range times.
2915 (check_tm_member): New function.
2916 (Fencode_time): Use it, to test for out-of-range times.
2917 (lisp_time_argument): Don't rely on undefined left-shift and
2918 right-shift behavior when checking for time stamp overflow.
2919
2920 * editfns.c (time_overflow): New function, refactoring common code.
2921 (Fformat_time_string, Fdecode_time, Fencode_time):
2922 (Fcurrent_time_string): Use it.
2923
2924 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2925 * dired.c (make_time): Move to ...
2926 * editfns.c (make_time): ... here.
2927 * systime.h: Note the move.
2928
29292011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2930
2931 * fringe.c (update_window_fringes): Remove unused variables.
2932
2933 * unexmacosx.c (copy_data_segment): Also copy __got section.
2934 (Bug#8223)
2935
29362011-03-12 Eli Zaretskii <eliz@gnu.org>
2937
2938 * termcap.c [MSDOS]: Include "msdos.h".
2939 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2940 Constify `char *' arguments and their references according to
2941 prototypes in tparam.h.
2942
2943 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2944
2945 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2946 Adapt all references accordingly.
2947
2948 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2949
29502011-03-11 Tom Tromey <tromey@redhat.com>
2951
2952 * buffer.c (syms_of_buffer): Remove obsolete comment.
2953
29542011-03-11 Eli Zaretskii <eliz@gnu.org>
2955
2956 * termhooks.h (encode_terminal_code): Declare prototype.
2957
2958 * msdos.c (encode_terminal_code): Don't declare prototype.
2959
2960 * term.c (encode_terminal_code): Now external again, used by
2961 w32console.c and msdos.c.
2962
2963 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2964 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2965
29662011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 Fix some minor problems found by GCC 4.5.2's static checks.
2969
2970 * fringe.c (update_window_fringes): Mark locals as initialized
2971 (Bug#8227).
2972 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2973
2974 * alloc.c (mark_fringe_data): Move decl from here ...
2975 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2976 to check its interface.
2977 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2978
2979 * fontset.c (free_realized_fontset): Now static.
2980 (Fset_fontset_font): Rename local to avoid shadowing.
2981 (fontset_font): Mark local as initialized.
2982 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2983
2984 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2985
2986 * xselect.c (x_disown_buffer_selections): Remove; not used.
2987 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2988 (x_own_selection, Fx_disown_selection_internal): Rename locals
2989 to avoid shadowing.
2990 (x_handle_dnd_message): Remove local to avoid shadowing.
2991
2992 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2993 so that the caller can use some name other than gcpro1.
2994 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2995 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2996 (Fx_backspace_delete_keys_p):
2997 Use them to avoid shadowing, and rename vars to avoid shadowing.
2998 (x_decode_color, x_set_name, x_window): Now static.
2999 (Fx_create_frame): Add braces to silence GCC warning.
3000 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3001 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3002 Remove unused locals.
3003 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3004 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3005 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3006 macros.
3007
3008 * xterm.h (x_mouse_leave): New decl.
3009
3010 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3011 Remove unused functions.
3012 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3013 (x_calc_absolute_position): Now static.
3014 (XTread_socket): Don't define label "out" unless it's used.
3015 Don't declare local "event" unless it's used.
3016 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3017 unless they are used.
3018 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3019 (x_fatal_error_signal): Remove; not used.
3020 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3021 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3022 (x_error_catcher, x_connection_closed, x_error_handler):
3023 (x_error_quitter, xembed_send_message, x_iconify_frame):
3024 (my_log_handler): Rename locals to avoid shadowing.
3025 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3026 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3027
3028 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3029 Rename or move locals to avoid shadowing.
3030 (tty_defined_color, merge_face_heights): Now static.
3031 (free_realized_faces_for_fontset): Remove; not used.
3032 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3033 does not deduce is never used uninitialized.
3034 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3035 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3036
3037 * terminal.c (store_terminal_param): Now static.
3038
3039 * xmenu.c (menu_highlight_callback): Now static.
3040 (set_frame_menubar): Remove unused local.
3041 (xmenu_show): Rename parameter to avoid shadowing.
3042 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3043 since they might point to immutable storage.
3044 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3045 since it's unused otherwise.
3046
3047 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3048 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3049 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3050 avoids a gcc -Wuninitialized diagnostic.
3051 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3052 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3053 does not deduce are never used uninitialized.
3054
3055 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3056
3057 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3058 * window.c (window_loop, size_window):
3059 (run_window_configuration_change_hook, enlarge_window): Likewise.
3060
3061 * window.c (display_buffer): Now static.
3062 (size_window): Mark variables that gcc -Wuninitialized
3063 does not deduce are never used uninitialized.
3064 * window.h (check_all_windows): New decl, to forestall
3065 gcc -Wmissing-prototypes diagnostic.
3066 * dispextern.h (bidi_dump_cached_states): Likewise.
3067
3068 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3069 shadowing.
3070 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3071 Include <limits.h>.
3072 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3073 and to avoid gcc -Wuninitialized warning.
3074 (load_charset_map): Mark variables that gcc -Wuninitialized
3075 does not deduce are never used uninitialized.
3076 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3077
3078 * coding.c (coding_set_source, coding_set_destination):
3079 Use "else { /* comment */ }" rather than "else /* comment */;"
3080 for clarity, and to avoid gcc -Wempty-body warning.
3081 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3082 a block, when the outer 'i' will do.
3083 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3084 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3085 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3086 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3087 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3088 Rename locals to avoid shadowing.
3089 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3090 * coding.c (emacs_mule_char, encode_invocation_designation):
3091 Now static, since they're not used elsewhere.
3092 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3093 (decode_coding_object, encode_coding_object, detect_coding_system):
3094 (decode_coding_emacs_mule): Mark variables that gcc
3095 -Wuninitialized does not deduce are never used uninitialized.
3096 (detect_coding_iso_2022): Initialize a local variable that might
3097 be used uninitialized. Leave a FIXME because it's not clear that
3098 this initialization is needed. (Bug#8211)
3099 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3100 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3101 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3102 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3103 Remove unused macros.
3104
3105 * category.c (hash_get_category_set): Remove unused local var.
3106 (copy_category_table): Now static, since it's not used elsewhere.
3107 * character.c (string_count_byte8): Likewise.
3108
3109 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3110 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3111
3112 * chartab.c (copy_sub_char_table): Now static, since it's not used
3113 elsewhere.
3114 (sub_char_table_ref_and_range, char_table_ref_and_range):
3115 Rename locals to avoid shadowing.
3116 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3117
3118 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3119 (BIDI_BOB): Remove unused macro.
3120
3121 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3122 deduce are never used uninitialized.
3123 * term.c (encode_terminal_code): Likewise.
3124
3125 * term.c (encode_terminal_code): Now static. Remove unused local.
3126
3127 * tparam.h: New file.
3128 * term.c, tparam.h: Include it.
3129 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3130 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3131 Move these decls to tparam.h, and make them agree with what
3132 is actually in tparam.c. The previous trick of using incompatible
3133 decls in different modules does not conform to the C standard.
3134 All callers of tparam changed to use tparam's actual API.
3135 * tparam.c (tparam1, tparam, tgoto):
3136 Use const pointers where appropriate.
3137
3138 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3139 * cm.h (struct cm): Likewise.
3140 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3141 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3142 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3143 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3144 (turn_on_face, init_tty): Likewise.
3145 * termchar.h (struct tty_display_info): Likewise.
3146
3147 * term.c (term_mouse_position): Rename local to avoid shadowing.
3148
3149 * alloc.c (mark_ttys): Move decl from here ...
3150 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3151
31522011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3153
3154 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3155
31562011-03-09 Juanma Barranquero <lekktu@gmail.com>
3157
3158 * search.c (compile_pattern_1): Remove argument regp, unused since
3159 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3160 (compile_pattern): Don't pass it.
3161
31622011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3163
3164 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3165 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3166 for ! HAVE_GTK3.
3167 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3168
3169 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3170
3171 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3172 gdk_window_get_screen, gdk_window_get_geometry,
3173 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3174 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3175 (xg_get_pixbuf_from_pixmap): New function.
3176 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3177 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3178 Call xg_get_pixbuf_from_pixmap instead of
3179 gdk_pixbuf_get_from_drawable.
3180 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3181 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3182 (xg_check_special_colors): Use GtkStyleContext and its functions
3183 for HAVE_GTK3.
3184 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3185 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3186 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3187 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3188 Call gtk_widget_get_preferred_size.
3189 (xg_frame_resized): gdk_window_get_geometry only takes 5
3190 parameters.
3191 (xg_win_to_widget, xg_event_is_for_menubar):
3192 Call gdk_x11_window_lookup_for_display.
3193 (xg_set_widget_bg): New function.
3194 (delete_cb): New function.
3195 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3196 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3197 (xg_set_background_color): Call xg_set_widget_bg.
3198 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3199 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3200 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3201 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3202 if ! HAVE_GTK3.
3203 (update_frame_tool_bar): Call gtk_widget_hide.
3204 (xg_initialize): Use GDK_KEY_g.
3205
3206 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3207 if ! HAVE_GTK3
3208 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3209
3210 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3211 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3212 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3213
32142011-03-08 Juanma Barranquero <lekktu@gmail.com>
3215
3216 * w32xfns.c (select_palette): Check success of RealizePalette against
3217 GDI_ERROR, not zero.
3218
3219See ChangeLog.11 for earlier changes.
3220
3221;; Local Variables:
3222;; coding: utf-8
3223;; End:
3224
3225 Copyright (C) 2011 Free Software Foundation, Inc.
3226
3227 This file is part of GNU Emacs.
3228
3229 GNU Emacs is free software: you can redistribute it and/or modify
3230 it under the terms of the GNU General Public License as published by
3231 the Free Software Foundation, either version 3 of the License, or
3232 (at your option) any later version.
3233
3234 GNU Emacs is distributed in the hope that it will be useful,
3235 but WITHOUT ANY WARRANTY; without even the implied warranty of
3236 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3237 GNU General Public License for more details.
3238
3239 You should have received a copy of the GNU General Public License
3240 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.