nt/INSTALL: Elaborate on debugging fatal errors.
[bpt/emacs.git] / src / ChangeLog
... / ...
CommitLineData
12011-11-25 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (redisplay_window): If cursor row is not fully visible
4 after recentering, and scroll-conservatively is set to a large
5 number, scroll window by a few more lines to make the cursor fully
6 visible and out of scroll-margin. (Bug#10105)
7
82011-11-24 Juri Linkov <juri@jurta.org>
9
10 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
11 after the `MagickPingImage' call. (Bug#10112)
12
132011-11-23 Chong Yidong <cyd@gnu.org>
14
15 * window.c (Fcoordinates_in_window_p): Accept only live windows.
16
172011-11-23 Martin Rudalics <rudalics@gmx.at>
18
19 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
20 making another buffer current. (Bug#10114)
21
222011-11-23 Glenn Morris <rgm@gnu.org>
23
24 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
25
262011-11-23 Chong Yidong <cyd@gnu.org>
27
28 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
29 using it (Bug#5984).
30
312011-11-22 Eli Zaretskii <eliz@gnu.org>
32
33 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
34 and header-lines, as they don't have one computed for them.
35 (Bug#10098)
36
37 * .gdbinit (prow): Make displayed values more self-explaining.
38 Add row's hash code.
39
402011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
41
42 * process.c (wait_reading_process_output): Fix asynchrounous
43 GnuTLS socket handling on some versions of the GnuTLS library.
44 (wait_reading_process_output): Add comment and URL.
45
462011-11-21 Jan Djärv <jan.h.d@swipnet.se>
47
48 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
49
502011-11-21 Chong Yidong <cyd@gnu.org>
51
52 * window.c (Fnext_window, Fprevious_window): Doc fix.
53
542011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
55
56 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
57
582011-11-20 Juanma Barranquero <lekktu@gmail.com>
59
60 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
61
622011-11-20 Martin Rudalics <rudalics@gmx.at>
63
64 * window.c (Fset_window_combination_limit): Rename argument
65 STATUS to LIMIT.
66 (Vwindow_combination_limit): Remove "status" from doc-string.
67
682011-11-20 Andreas Schwab <schwab@linux-m68k.org>
69
70 * m/ibms390.h: Remove.
71 * m/ibms390x.h: Don't include "ibms390.h".
72
732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
74
75 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
76 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
77
782011-11-20 Juanma Barranquero <lekktu@gmail.com>
79
80 * casetab.c (Fset_case_table):
81 * charset.c (Fcharset_after): Fix typos.
82
832011-11-20 Paul Eggert <eggert@cs.ucla.edu>
84
85 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
86 Otherwise, valgrind does not work on some platforms.
87 Problem reported by Andreas Schwab in
88 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
89 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
90 is set, removing the need for VIRT_ADDRESS_VARIES.
91 (PURE_P): Use a more-efficient implementation that needs just one
92 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
93 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
94 to 4 (xorl, subq, cmpq, setbe).
95 * alloc.c (pure): Always extern now, since that's the
96 VIRT_ADDR_VARIES behavior.
97 (PURE_POINTER_P): Use a single comparison, not two, for
98 consistency with the new puresize.h.
99 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
100 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
101 Remove VIRT_ADDR_VARIES no longer needed.
102
1032011-11-19 Eli Zaretskii <eliz@gnu.org>
104
105 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
106 (erase_phys_cursor, update_window_cursor, show_mouse_face)
107 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
108 behave as if the cursor position were at the window margin.
109
110 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
111 and the cursor position is out of bounds, behave as if the cursor
112 position were at the window margin. (Bug#10075)
113
1142011-11-18 Chong Yidong <cyd@gnu.org>
115
116 * window.c (Fwindow_combination_limit): Make first argument
117 non-optional, since it is meaningless for live windows like the
118 selected window.
119
1202011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
121
122 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
123
1242011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
125
126 * intervals.c: Fix grafting over the whole buffer (bug#10071).
127 (graft_intervals_into_buffer): Simplify.
128
1292011-11-18 Eli Zaretskii <eliz@gnu.org>
130
131 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
132 hash values of the two rows.
133 (copy_row_except_pointers): Preserve the used[] arrays and the
134 hash values of the two rows. (Bug#10035)
135 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
136
137 * xdisp.c (row_hash): New function, body extracted from
138 compute_line_metrics.
139 (compute_line_metrics): Call row_hash, instead of computing the
140 hash code inline.
141
142 * dispnew.c (verify_row_hash): Call row_hash for computing the
143 hash code of a row, instead of duplicating code from xdisp.c.
144
145 * dispextern.h (row_hash): Add prototype.
146
1472011-11-18 Tassilo Horn <tassilo@member.fsf.org>
148
149 * frame.c (delete_frame): Don't delete the terminal when the last
150 X frame is closed if emacs is built with GTK toolkit.
151
1522011-11-17 Juanma Barranquero <lekktu@gmail.com>
153
154 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
155
1562011-11-17 Martin Rudalics <rudalics@gmx.at>
157
158 * window.c (Vwindow_splits): Rename to
159 Vwindow_combination_resize. Suggested by Juri Linkov.
160 (Fsplit_window_internal): Use Vwindow_combination_resize instead
161 of Vwindow_splits.
162
1632011-11-16 Juanma Barranquero <lekktu@gmail.com>
164
165 * nsfns.m (Fns_font_name):
166 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
167
1682011-11-16 Martin Rudalics <rudalics@gmx.at>
169
170 * window.h (window): Rename slot "nest" to "combination_limit".
171 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
172 (Fset_window_nest): Rename to Fset_window_combination_limit.
173 (Vwindow_nest): Rename to Vwindow_combination_limit.
174 (recombine_windows, make_parent_window, make_window)
175 (Fsplit_window_internal, saved_window)
176 (Fset_window_configuration, save_window_save): Rename all
177 occurrences of window_nest to window_combination_limit.
178
1792011-11-15 Juanma Barranquero <lekktu@gmail.com>
180
181 * image.c (imagemagick_load_image): Fix typo.
182
1832011-11-14 Eli Zaretskii <eliz@gnu.org>
184
185 * xdisp.c (display_line): Move the call to
186 highlight_trailing_whitespace before the call to
187 compute_line_metrics, since the latter needs to see the final
188 faces of all the glyphs to compute ROW's hash value. Fixes
189 assertion violations in row_equal_p. (Bug#10035)
190
1912011-11-14 Juanma Barranquero <lekktu@gmail.com>
192
193 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
194 just return (bug#10044).
195
1962011-11-12 Eli Zaretskii <eliz@gnu.org>
197
198 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
199 with user-defined heap size. Bump the default size of the temacs
200 heap to 27MB, to avoid memory warning when running temacs.
201 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
202
203 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
204 current_matrix and desired_matrix. (Bug#9990)
205 (verify_row_hash) [XASSERTS]: New function.
206 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
207 that the hash value of glyph rows is correct.
208
2092011-11-12 Martin Rudalics <rudalics@gmx.at>
210
211 * window.h (window): Remove splits slot.
212 * window.c (Fwindow_splits, Fset_window_splits): Remove.
213 (Fdelete_other_windows_internal, make_parent_window)
214 (make_window, Fsplit_window_internal, Fdelete_window_internal)
215 (Fset_window_configuration, save_window_save): Don't deal with
216 split status of windows.
217 (saved_window): Remove splits slot.
218 (Vwindow_splits): Rewrite doc-string.
219
2202011-11-11 Jan Djärv <jan.h.d@swipnet.se>
221
222 * xfns.c (unwind_create_frame):
223 * nsfns.m (unwind_create_frame):
224 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
225 Vframe_list (Bug#9999).
226
2272011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
228
229 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
230
2312011-11-11 Kenichi Handa <handa@m17n.org>
232
233 * callproc.c (Fcall_process): Set the member dst_multibyte of
234 process_coding.
235
2362011-11-11 Johan Bockgård <bojohan@gnu.org>
237
238 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
239 avoid a crash (bug#9496).
240
2412011-11-09 Chong Yidong <cyd@gnu.org>
242
243 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
244 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
245
2462011-11-08 Paul Eggert <eggert@cs.ucla.edu>
247
248 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
249
2502011-11-08 Paul Eggert <eggert@cs.ucla.edu>
251
252 Avoid some portability problems by eschewing 'extern inline' functions.
253 The trivial performance wins aren't worth the portability hassles; see
254 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
255 et seq.
256 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
257 (window_box_width, window_box_left, window_box_left_offset)
258 (window_box_right, window_box_right_offset): Undo previous change,
259 by removing the "extern"s.
260 * intervals.c (adjust_intervals_for_insertion)
261 (adjust_intervals_for_deletion): Undo previous change,
262 making these static again.
263 (offset_intervals, temp_set_point_both, temp_set_point)
264 (copy_intervals_to_string): No longer inline.
265 * xdisp.c (window_text_bottom_y, window_box_width)
266 (window_box_height, window_box_left_offset)
267 (window_box_right_offset, window_box_left, window_box_right)
268 (window_box): No longer inline.
269
2702011-11-08 Chong Yidong <cyd@gnu.org>
271
272 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
273 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
274 an error if not a live window.
275 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
276 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
277
2782011-11-07 Juanma Barranquero <lekktu@gmail.com>
279
280 * lisp.h (syms_of_abbrev): Remove declaration.
281 Reported by CHENG Gao <chenggao@royau.me>.
282
2832011-11-07 Eli Zaretskii <eliz@gnu.org>
284
285 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
286 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
287 of temacs in GUI mode.
288
2892011-11-07 Martin Rudalics <rudalics@gmx.at>
290
291 * window.h: Declare delete_all_child_windows instead of
292 delete_all_subwindows.
293 * window.c (Fwindow_nest, Fset_window_nest)
294 (Fset_window_new_total, Fset_window_new_normal)
295 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
296 (delete_all_subwindows): Rename to delete_all_child_windows.
297 (Fdelete_other_windows_internal, Fset_window_configuration):
298 Call delete_all_child_windows instead of delete_all_subwindows.
299 * frame.c (delete_frame): Call delete_all_child_windows instead
300 of delete_all_subwindows.
301
3022011-11-07 Paul Eggert <eggert@cs.ucla.edu>
303
304 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
305 This is also needed for porting to any host where GC_MARK_STACK is
306 not GC_MAKE_GCPROS_NOOPS.
307 (which_symbols): Use it.
308
3092011-11-07 Kenichi Handa <handa@m17n.org>
310
311 * coding.c (coding_set_destination): Check coding->src_pos only
312 when coding->src_object is a buffer (bug#9910).
313
314 * process.c (send_process): Set the member src_multibyte of coding
315 to 0 (bug#9911) when sending a unibyte text.
316
317 * callproc.c (Fcall_process): Set the member src_multibyte of
318 process_coding to 0 (bug#9912).
319
3202011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
321
322 * xmenu.c (cleanup_widget_value_tree): New function.
323 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
324 calling free_menubar_widget_value_tree directly (Bug#9830).
325
3262011-11-06 Paul Eggert <eggert@cs.ucla.edu>
327
328 Fix some portability problems with 'inline'.
329 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
330 (window_box_width, window_box_left, window_box_left_offset)
331 (window_box_right, window_box_right_offset): Declare extern.
332 Otherwise, these inline functions do not conform to C99 and
333 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
334 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
335 * intervals.c (adjust_intervals_for_insertion)
336 (adjust_intervals_for_deletion): Now extern, because otherwise the
337 extern inline functions 'offset_intervals' couldn't refer to it.
338 (static_offset_intervals): Remove.
339 (offset_intervals): Rewrite using the old contents of
340 static_offset_intervals. The old version didn't conform to C99
341 because an extern inline function contained a reference to an
342 identifier with static linkage.
343
3442011-11-06 Andreas Schwab <schwab@linux-m68k.org>
345
346 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
347 GC.
348
3492011-11-06 Eli Zaretskii <eliz@gnu.org>
350
351 * xdisp.c (init_iterator, reseat_to_string): Don't set the
352 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
353 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
354 return Qleft_to_right.
355
3562011-11-06 Chong Yidong <cyd@gnu.org>
357
358 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
359 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
360 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
361 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
362 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
363 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
364 (Fwindow_vscroll): Doc fix.
365 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
366 argument, since it makes no sense to pass a live window and for
367 consistency with window-child.
368
3692011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
370
371 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
372 support MSVC.
373
3742011-11-05 Jason Rumney <jasonr@gnu.org>
375
376 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
377 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
378 fonts (Bug#6029).
379 (add_font_entity_to_list): Fix logic errors in mixed boolean and
380 bitwise arithmetic preventing use of unicode-sip and non-truetype
381 opentype fonts.
382
3832011-11-05 Eli Zaretskii <eliz@gnu.org>
384
385 * s/ms-w32.h (fstat, stat, utime): Move redirections to
386 "emacs"-only part.
387
388 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
389 initialization code to keep similarity to xfns.c after changes
390 from 2011-11-05.
391
3922011-11-05 Jan Djärv <jan.h.d@swipnet.se>
393
394 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
395 (unwind_create_frame): New function (Bug#9943).
396 (Fx_create_frame): Restructure code to be more similar to the one in
397 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
398 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
399 Move terminal->reference_count++ just before making the frame official
400 (Bug#9943).
401
402 * nsterm.m (x_free_frame_resources): New function.
403 (x_destroy_window): Move code to x_free_frame_resources.
404
405 * xfns.c (unwind_create_frame): Fix comment.
406 (Fx_create_frame, x_create_tip_frame): Move
407 terminal->reference_count++ just before making the frame
408 official. Move initialization of image_cache_refcount and
409 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
410
4112011-11-05 Eli Zaretskii <eliz@gnu.org>
412
413 Support MSVC build with newer versions of Visual Studio.
414 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
415 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
416 nt/gmake.defs.
417
418 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
419 which are not supported by MSVC.
420 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
421 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
422 bitfields.
423 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
424 types in bitfields.
425 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
426
427 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
428
4292011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
430
431 Support MSVC build with newer versions of Visual Studio.
432 * w32.c: Don't include w32api.h for MSVC.
433 (init_environment) [_MSC_VER]: Call sys_access, not _access.
434
435 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
436 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
437 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
438 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
439 e_* cousins.
440 (alloca) [_MSC_VER]: Define to _alloca.
441
442 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
443
444 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
445
4462011-11-04 Eli Zaretskii <eliz@gnu.org>
447
448 * xdisp.c (note_mouse_highlight): If either of
449 previous/next-single-property-change returns nil, treat that as
450 the beginning or the end of the buffer. (Bug#9955)
451
4522011-11-04 Jan Djärv <jan.h.d@swipnet.se>
453
454 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
455 label is not null (Bug#9951).
456 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
457 may be NULL.
458
4592011-11-04 Eli Zaretskii <eliz@gnu.org>
460
461 * window.c (Fwindow_body_size): Mention in the doc string that the
462 return value is in frame's canonical units. (Bug#9949)
463
4642011-11-03 Eli Zaretskii <eliz@gnu.org>
465
466 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
467
468 * w32fns.c (unwind_create_frame): If needed, free the glyph
469 matrices of the partially constructed frame. (Bug#9943)
470 * xfns.c (unwind_create_frame): Likewise.
471
4722011-11-01 Eli Zaretskii <eliz@gnu.org>
473
474 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
475 Don't stop backward scan on the continuation glyph, even though
476 its CHARPOS is positive.
477 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
478 cover_string to disp_string.
479
4802011-11-01 Martin Rudalics <rudalics@gmx.at>
481
482 * window.c (temp_output_buffer_show): Don't use
483 Vtemp_buffer_show_specifiers.
484 (Vtemp_buffer_show_specifiers): Remove unused variable.
485
4862011-10-30 Eli Zaretskii <eliz@gnu.org>
487
488 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
489 past the beginning of the current glyph matrix.
490
4912011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
492
493 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
494 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
495 HAVE_GTK3 (Bug#9869).
496
497 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
498 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
499
500 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
501
502 * xterm.c: Declare x_handle_net_wm_state to return int.
503 (handle_one_xevent): Check if we are iconified but don't have
504 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
505 (get_current_wm_state): Return non-zero if not hidden,
506 check for _NET_WM_STATE_HIDDEN (Bug#9893).
507 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
508 (x_handle_net_wm_state): Return what get_current_wm_state returns.
509 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
510
5112011-10-29 Paul Eggert <eggert@cs.ucla.edu>
512
513 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
514 so that this new function doesn't get optimized away by a
515 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
516
5172011-10-29 Andreas Schwab <schwab@linux-m68k.org>
518
519 * frame.h (MOUSE_HL_INFO): Remove excess parens.
520
5212011-10-29 Eli Zaretskii <eliz@gnu.org>
522
523 Fix the `xbytecode' command.
524 * .gdbinit (xprintbytestr): New command.
525 (xwhichsymbols): Rename from `which'; all callers changed.
526 (xbytecode): Print the byte-code string as well.
527
5282011-10-29 Kim Storm <storm@cua.dk>
529
530 * alloc.c (which_symbols): New function.
531
5322011-10-29 Andreas Schwab <schwab@linux-m68k.org>
533
534 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
535 line. (Bug#9903)
536
5372011-10-29 Glenn Morris <rgm@gnu.org>
538
539 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
540 Not clear what it was for, and it causes various bugs. (Bug#9839)
541
5422011-10-28 Eli Zaretskii <eliz@gnu.org>
543
544 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
545 possible random value that matches one of those tested as
546 condition to clear the mouse face.
547
5482011-10-28 Chong Yidong <cyd@gnu.org>
549
550 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
551
5522011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
553
554 * window.c (make_window): Initialize phys_cursor_on_p.
555
5562011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
557
558 * lisp.h (struct Lisp_Symbol): Update comments.
559
5602011-10-28 Juanma Barranquero <lekktu@gmail.com>
561
562 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
563
5642011-10-28 Eli Zaretskii <eliz@gnu.org>
565
566 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
567 <oslsachem@gmail.com> for helping to debug this.
568
569 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
570 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
571 (g_b_init_get_glyph_outline_w): New static variables.
572 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
573 (GetGlyphOutlineW_Proc): New typedefs.
574 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
575 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
576 New functions.
577 (w32font_open_internal, compute_metrics):
578 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
579 instead of calling the "wide" APIs directly.
580
581 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
582
583 * w32.h (syms_of_w32font): Add prototype.
584
5852011-10-27 Juanma Barranquero <lekktu@gmail.com>
586
587 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
588 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
589 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
590 (Fmove_to_window_line): Doc fix.
591
5922011-10-27 Chong Yidong <cyd@gnu.org>
593
594 * process.c (make_process): Set gnutls_state to NULL.
595
596 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
597 non-NULL, regardless of GNUTLS_INITSTAGE.
598 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
599 an error. Set process slots as soon as we allocate them.
600
601 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
602
6032011-10-27 Chong Yidong <cyd@gnu.org>
604
605 * gnutls.c (emacs_gnutls_deinit): New function.
606 Deallocate credentials structures as well as calling gnutls_deinit.
607 (Fgnutls_deinit, Fgnutls_boot): Use it.
608
609 * process.c (make_process): Initialize GnuTLS credentials to NULL.
610 (deactivate_process): Call emacs_gnutls_deinit.
611
6122011-10-27 Juanma Barranquero <lekktu@gmail.com>
613
614 * image.c (x_create_x_image_and_pixmap):
615 * w32.c (sys_rename, w32_delayed_load):
616 * w32font.c (fill_in_logfont):
617 * w32reg.c (x_get_string_resource): Silence compiler warnings.
618
6192011-10-26 Juanma Barranquero <lekktu@gmail.com>
620
621 * w32fns.c (w32_default_color_map): New function,
622 extracted from Fw32_default_color_map.
623 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
624
6252011-10-25 Paul Eggert <eggert@cs.ucla.edu>
626
627 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
628
6292011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
630
631 * keyboard.c (test_undefined): New function (bug#9751).
632 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
633
6342011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
635
636 * sysdep.c (init_sys_modes): Fix the check for the controlling
637 terminal (Bug#6649).
638
6392011-10-20 Eli Zaretskii <eliz@gnu.org>
640
641 * dispextern.h (struct bidi_it): New member next_en_type.
642
643 * bidi.c (bidi_line_init): Initialize the next_en_type member.
644 (bidi_resolve_explicit_1): When next_en_pos is valid for the
645 current character, check also for next_en_type being WEAK_EN.
646 (bidi_resolve_weak): Don't enter the expensive loop if the current
647 position is before next_en_pos. Record the bidi type of the first
648 non-ET, non-BN character we find, in addition to its position.
649 (bidi_level_of_next_char): Invalidate next_en_type when
650 next_en_pos is over-stepped.
651
6522011-10-20 Paul Eggert <eggert@cs.ucla.edu>
653
654 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
655 * editfns.c: Rewrite current-time-zone so that it invokes
656 the equivalent of (format-time-string "%Z") to get the time zone name.
657 This fixes a bug when the time zone name contains characters that
658 need converting from the system time locale to Emacs internal format.
659 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
660 that patch fixed format-time-string to do the conversion, but
661 I forgot to fix current-time-zone.
662 (format_time_string): New function, containing most of
663 what Fformat_time_string used to contain.
664 (Fformat_time_string): Rewrite in terms of format_time_string.
665 This doesn't change this function's behavior.
666 (current-time-zone): Rewrite to use format_time_string.
667 This fixes the bug reported by Michael Schierl in
668 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
669 Jason Rumney's 2007-06-07 change worked around this bug, but
670 didn't fix it.
671 * systime.h (tzname, timezone): Remove no-longer-used declarations.
672
6732011-10-19 Eli Zaretskii <eliz@gnu.org>
674
675 * xdisp.c (start_display): If the character at POS is displayed
676 via a display vector, reset IT->current.dpvec_index to zero.
677 (try_window_reusing_current_matrix): If a line ends in a display
678 vector or the next line starts in a display vector, continue
679 redrawing the window even though the character position of
680 start_row was reached.
681 (Bug#9771, part 2)
682
6832011-10-18 Chong Yidong <cyd@gnu.org>
684
685 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
686 with nobreak-char-display too.
687
6882011-10-18 Eli Zaretskii <eliz@gnu.org>
689
690 Fix part 3 of bug#9771.
691 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
692 (bidi_resolve_neutral): Don't enter the expensive loop looking for
693 non-neutral characters if the current character is a paragraph
694 separator (a.k.a. Newline). This avoids running the same
695 expensive loop twice, once when we consume the preceding newline
696 and the other time when the line actually needs to be displayed.
697 Avoid the loop when we see neutrals on the base embedding level
698 following a character whose directionality is the same as the
699 paragraph's. This avoids running the expensive loop when a line
700 ends in a long sequence of neutrals, like control characters.
701 Add assertion against STRONG_AL type. Slightly rearrange code
702 that determines the type of a neutral given the first non-neutral
703 that follows it.
704 (bidi_level_of_next_char): Set next_en_pos to zero when
705 invalidating its info.
706
7072011-10-17 Eli Zaretskii <eliz@gnu.org>
708
709 * xdisp.c (push_display_prop): Determine whether to record string
710 or buffer position by IT->string, not by IT->method. Allow
711 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
712 (move_it_vertically_backward): Don't look for character position
713 immediately after the newline when in a continuation line.
714 (Bug#9771, part 1)
715
7162011-10-15 Martin Rudalics <rudalics@gmx.at>
717
718 * window.c (coordinates_in_window): Rewrite and delabelize
719 vertical border check. (Bug#5357) (Bug#9618)
720
7212011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
722
723 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
724 errors in XSetWindowBorder (bug#9310).
725
7262011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
727
728 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
729 avoid crash when xmalloc overrun checking is enabled.
730
7312011-10-13 Eli Zaretskii <eliz@gnu.org>
732
733 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
734 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
735 cursor motion with <left> and <right> arrow keys.
736
737 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
738 some callers set that themselves.
739
7402011-10-12 Eli Zaretskii <eliz@gnu.org>
741
742 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
743 display string and the previous row comes from the same string and
744 is empty. (Bug#9739) (Bug#9738)
745
7462011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
747
748 * doc.c (get_doc_string): Encode file name (bug#9735).
749
7502011-10-12 Eli Zaretskii <eliz@gnu.org>
751
752 * bidi.c (bidi_level_of_next_char):
753 * xdisp.c (get_visually_first_element): Remove old incorrect
754 comments regarding the Unicode Line Separator character.
755
756 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
757
7582011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
759
760 * alloc.c (Fgc_status): Do not access beyond zombies array
761 boundary if nzombies > MAX_ZOMBIES.
762 * alloc.c (dump_zombies): Add missing format specifier.
763
7642011-10-12 Paul Eggert <eggert@cs.ucla.edu>
765
766 * xdisp.c (set_cursor_from_row): Simplify conditionals,
767 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
768
769 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
770 Some packages use them to denote characters with modifiers.
771
7722011-10-11 Andreas Schwab <schwab@linux-m68k.org>
773
774 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
775 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
776 matching a pp-number. Rename parameter var to var1.
777
7782011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
779
780 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
781
7822011-10-08 Glenn Morris <rgm@gnu.org>
783
784 * callint.c (Fcall_interactively): Give a more explicit error for the
785 'c' case with a non-character input. (Bug#8479)
786
7872011-10-08 Eli Zaretskii <eliz@gnu.org>
788
789 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
790 lines.
791 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
792 lines that are hscrolled on the left.
793
794 * dispnew.c (buffer_posn_from_coords): Account for a possible
795 presence of header-line. (Bug#4426)
796
7972011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
798
799 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
800 Don't advertise functionality which we discourage or doesn't work.
801
8022011-10-07 Paul Eggert <eggert@cs.ucla.edu>
803
804 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
805 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
806 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
807 this makes Emacs dump core during garbage collection on rare
808 occasions. sizeof is obviously inferior to offsetof here, so
809 stick with offsetof.
810 (GC_POINTER_ALIGNMENT): New macro.
811 (mark_memory): Omit 3rd (offset) arg; caller changed.
812 Don't assume EMACS_INT alignment is the same as pointer alignment.
813
8142011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
815
816 * keyboard.c (read_key_sequence_remapped): New var.
817 (read_key_sequence): Compute remapping in the right buffer.
818 (command_loop_1): Use read_key_sequence's remapping directly.
819
8202011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
821
822 * dired.c (file_name_completion): Don't expand file name.
823 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
824 before checking file name handler.
825
826 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
827 they've been requested explicitly (bug#9591).
828
8292011-10-01 Andreas Schwab <schwab@linux-m68k.org>
830
831 * keymap.c (Fsingle_key_description): Use make_specified_string
832 instead of build_string to build string from push_key_description.
833 (Bug#5193)
834
8352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
836
837 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
838 This fixes a Y2038 bug on 64-bit hosts.
839 * buffer.c (reset_buffer):
840 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
841 (Fclear_buffer_auto_save_failure):
842 Use 0, not -1, to represent an unset failure time, since time_t
843 might not be signed.
844
845 Remove dependency on glibc malloc internals.
846 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
847 Move back here from lisp.h, but with their new implementations.
848 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
849 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
850 * charset.c (charset_table_init): New static var.
851 (syms_of_charset): Use it instead of xmalloc. This removes a
852 dependency on glibc malloc internals. See Eli Zaretskii's comment in
853 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
854 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
855 Move back to alloc.c.
856 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
857 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
858
8592011-09-30 Jan Djärv <jan.h.d@swipnet.se>
860
861 * nsterm.m (windowDidResize): Call x_set_window_size only when
862 ns_in_resize is true. Otherwise set pixelwidth/height and
863 call change_frame_size (Bug#9628).
864
8652011-09-30 Paul Eggert <eggert@cs.ucla.edu>
866
867 Port --enable-checking=all to Fedora 14 x86-64.
868 * charset.c (syms_of_charset): Also account for glibc malloc's
869 internal overhead when calculating the initial malloc maximum.
870
871 Port --enable-checking=all to Fedora 14 x86.
872 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
873 Move to lisp.h.
874 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
875 (overrun_check_realloc, overrun_check_free):
876 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
877 That way, xmalloc returns a properly-aligned pointer even if
878 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
879 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
880 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
881 into account when calculating the initial malloc maximum.
882 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
883 Move here from alloc.c, so that charset.c can use it too.
884 Properly align; the old code wasn't right for common 32-bit hosts
885 when configured with --enable-checking=all.
886 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
887 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
888
8892011-09-29 Eli Zaretskii <eliz@gnu.org>
890
891 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
892 use EDOM.
893
8942011-09-28 Eli Zaretskii <eliz@gnu.org>
895
896 * xdisp.c (compute_display_string_end): If there's no display
897 string at CHARPOS, return -1.
898
899 * bidi.c (bidi_fetch_char): When compute_display_string_end
900 returns a negative value, treat the character as a normal
901 character not covered by a display string. (Bug#9624)
902
9032011-09-28 Juanma Barranquero <lekktu@gmail.com>
904
905 * lread.c (Fread_from_string): Fix typo in docstring.
906
9072011-09-27 Eli Zaretskii <eliz@gnu.org>
908
909 * xdisp.c (handle_invisible_prop): If invisible text ends on a
910 newline, reseat the iterator instead of bidi-iterating there one
911 character at a time. (Bug#9610)
912 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
913 TO_CHARPOS if the bidi iterator is at base embedding level.
914
9152011-09-27 Andreas Schwab <schwab@linux-m68k.org>
916
917 * lread.c (readevalloop): Use correct code for NBSP.
918 (read1): Likewise. (Bug#9608)
919
9202011-09-25 Michael Albinus <michael.albinus@gmx.de>
921
922 * dbusbind.c (Fdbus_register_signal): When service is not
923 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
924
9252011-09-25 Glenn Morris <rgm@gnu.org>
926
927 * buffer.c (truncate-lines): Doc fix.
928
9292011-09-24 Chong Yidong <cyd@stupidchicken.com>
930
931 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
932 (Fset_window_next_buffers): Doc fix.
933
9342011-09-24 Glenn Morris <rgm@gnu.org>
935
936 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
937
9382011-09-24 Paul Eggert <eggert@cs.ucla.edu>
939
940 Fix minor problems found by static checking.
941 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
942 * indent.c (Fvertical_motion): Fix == vs = typo.
943
9442011-09-24 Eli Zaretskii <eliz@gnu.org>
945
946 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
947 Default value is now t. Doc fix.
948
949 * indent.c (Fvertical_motion): Compute and apply the overshoot
950 logic when moving up, not only when moving down. Fix the
951 confusing name and values of the it_overshoot_expected variable;
952 logic changes accordingly. (Bug#9254) (Bug#9549)
953
954 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
955 CHARPOS is covered by a display string which includes newlines.
956 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
957 is covered by a display string with embedded newlines.
958
9592011-09-24 Michael Albinus <michael.albinus@gmx.de>
960
961 * dbusbind.c (Fdbus_register_signal): Add match rule to
962 Vdbus_registered_objects_table. (Bug#9581)
963 (Fdbus_register_method, Vdbus_registered_objects_table):
964 Fix docstring.
965
9662011-09-24 Jim Meyering <meyering@redhat.com>
967
968 do not ignore write error for any output size
969 The previous change was incomplete.
970 While it makes emacs --batch detect the vast majority of stdout
971 write failures, errors were still ignored whenever the output size is
972 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
973 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
974 && echo FAIL: ignored write error
975 FAIL: ignored write error
976 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
977 && echo FAIL: ignored write error
978 FAIL: ignored write error
979 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
980
9812011-09-23 Andreas Schwab <schwab@linux-m68k.org>
982
983 * emacs.c (Fkill_emacs): In noninteractive mode exit
984 non-successfully if a write error occurred on stdout. (Bug#9574)
985
9862011-09-21 Eli Zaretskii <eliz@gnu.org>
987
988 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
989 the xassert test.
990
991 * dispextern.h (struct it): Update the comment documenting what
992 can it->OBJECT be.
993
9942011-09-20 Eli Zaretskii <eliz@gnu.org>
995
996 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
997 a display string, extend search for cursor position to end of row.
998 (find_row_edges): If the row ends in a newline from a display
999 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1000 Handle the case of a display string with multiple newlines.
1001 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1002 non-empty line. Fixes confusing cursor motion with arrow keys at
1003 the beginning of a line that starts with whitespace.
1004
10052011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1006
1007 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1008 (bug#9493).
1009
10102011-09-18 Chong Yidong <cyd@stupidchicken.com>
1011
1012 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1013 boolean (Bug#9154).
1014
10152011-09-18 Eli Zaretskii <eliz@gnu.org>
1016
1017 * xdisp.c (display_line): Record maximum and minimum buffer
1018 positions even if no glyphs were produced (e.g., by a zero-width
1019 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1020 buffer positions that will be removed from the glyph row because
1021 they don't fit.
1022 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1023 column is beyond frame width: don't subtract 1 "pixel" when
1024 computing width of the stretch.
1025 (reseat_at_next_visible_line_start): Undo the change made on
1026 2011-09-17 that saved paragraph information and restored it after
1027 the call to `reseat'. (Bug#9545)
1028
10292011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1030
1031 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1032 and turn window cursor on if cleared (Bug#9415).
1033
10342011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1035
1036 * search.c (boyer_moore): Take unibyte characters from pattern
1037 literally. (Bug#9458)
1038
10392011-09-18 Eli Zaretskii <eliz@gnu.org>
1040
1041 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1042
10432011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1044
1045 Fix minor problem found by static checking.
1046 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1047 initialized, to pacify gcc -Wuninitialized.
1048
1049 * fileio.c: Report proper errno when syscall falls.
1050 (Finsert_file_contents): Save and restore errno,
1051 so that report_file_error outputs the correct diagnostic.
1052 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1053
10542011-09-18 Eli Zaretskii <eliz@gnu.org>
1055
1056 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1057
10582011-09-17 Eli Zaretskii <eliz@gnu.org>
1059
1060 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1061 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1062
10632011-09-17 Eli Zaretskii <eliz@gnu.org>
1064
1065 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1066 about the current paragraph and restore it after the call to reseat.
1067
1068 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1069 (bidi_find_paragraph_start): Search back for paragraph beginning
1070 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1071 (bidi_move_to_visually_next): Only trigger paragraph-related
1072 computations when the last character is a newline or at EOB, not
1073 just any NEUTRAL_B. (Bug#9470)
1074
1075 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1076 truncated lines if point is covered by a display string. (Bug#9524)
1077
10782011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1079
1080 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1081 (cons_to_x_long): New function.
1082 (lisp_data_to_selection_data): Use it. Correct the test for
1083 short-versus-long data; it was negated. Break out of vector
1084 loop, for efficiency, when a long datum is discovered.
1085
10862011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1087
1088 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1089
10902011-09-16 Eli Zaretskii <eliz@gnu.org>
1091
1092 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1093 GCC PR/17406) by declaring this function with external scope.
1094
10952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1098 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1099
11002011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1101
1102 * editfns.c (Fformat): Correctly handle text properties on "%%".
1103
11042011-09-15 Eli Zaretskii <eliz@gnu.org>
1105
1106 * xterm.c (x_draw_composite_glyph_string_foreground):
1107 * w32term.c (x_draw_composite_glyph_string_foreground):
1108 * term.c (encode_terminal_code):
1109 * composite.c (composition_update_it, get_composition_id):
1110 * xdisp.c (get_next_display_element)
1111 (fill_composite_glyph_string): Add comments about special meaning
1112 of TAB characters in a composition.
1113
11142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1115
1116 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1117 This occurs when processing a multibyte format.
1118 Problem reported by Wolfgang Jenker.
1119
11202011-09-15 Johan Bockgård <bojohan@gnu.org>
1121
1122 * xdisp.c (try_cursor_movement): Only check for exact match if
1123 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1124
11252011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1126
1127 Remove unused external symbols.
1128 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1129 * xdisp.c (calc_pixel_width_or_height): Now static.
1130 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1131 * indent.c (check_display_width):
1132 * w32term.c: Fix comment to match code.
1133 * xterm.c, xterm.h (x_catching_errors): Remove.
1134
11352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1136
1137 * xselect.c: Use signed conversions more consistently (Bug#9498).
1138 (selection_data_to_lisp_data): Assume incoming selection data are
1139 signed integers, not unsigned. This is to be consistent with
1140 outgoing selection data, which was modified to use signed integers
1141 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1142 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1143 expects long, not unsigned long.
1144
11452011-09-14 Eli Zaretskii <eliz@gnu.org>
1146
1147 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1148 computation of loop end. Reported by Johan Bockgård
1149 <bojohan@gnu.org>.
1150
11512011-09-13 Chong Yidong <cyd@stupidchicken.com>
1152
1153 * frame.c (Fother_visible_frames_p): Function deleted.
1154
11552011-09-12 Eli Zaretskii <eliz@gnu.org>
1156
1157 * indent.c (compute_motion): Process display vector front to back
1158 rather than the other way around. (Bug#2496)
1159
11602011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1161
1162 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1163
11642011-09-11 Chong Yidong <cyd@stupidchicken.com>
1165
1166 * minibuf.c (Fread_from_minibuffer): Doc fix.
1167
11682011-09-11 Eli Zaretskii <eliz@gnu.org>
1169
1170 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1171 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1172
11732011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1174
1175 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1176 value for non-existent files.
1177
11782011-09-11 Eli Zaretskii <eliz@gnu.org>
1179
1180 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1181 set its "size" to -1. This will set the modtime_size field of
1182 the corresponding buffer to -1, which is what
1183 verify-visited-file-modtime expects for files that do not exist.
1184 (Bug#9139)
1185
11862011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1187
1188 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1189 here ...
1190 * lisp.h: ... from here. push_key_description is no longer
1191 defined in keyboard.c, so its declaration should not be in
1192 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1193 logically belongs with push_key_description.
1194
11952011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1196
1197 * buffer.h: Include <sys/types.h> instead of <time.h>.
1198 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1199 Problem reported by Herbert J. Skuhra.
1200
12012011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1202
1203 * xml.c (parse_region): Make the parsing work for
1204 non-comment-starting XML files again (bug#9144).
1205
12062011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1207
1208 * image.c (gif_load): Fix calculation of bottom and right corner.
1209 (Bug#9468)
1210
12112011-09-10 Eli Zaretskii <eliz@gnu.org>
1212
1213 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1214 redisplay in small windows.
1215
12162011-09-09 Eli Zaretskii <eliz@gnu.org>
1217
1218 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1219
12202011-09-08 Martin Rudalics <rudalics@gmx.at>
1221
1222 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1223 Operate on live windows only.
1224
12252011-09-08 Juanma Barranquero <lekktu@gmail.com>
1226
1227 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1228
12292011-09-07 Eli Zaretskii <eliz@gnu.org>
1230
1231 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1232 only under bidi iteration.
1233
12342011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1235
1236 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1237
12382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1239
1240 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1241 Without this fix, the command to link temacs failed due to an
1242 undefined symbol __builtin_isnan. This is because
1243 /usr/include/iso/math_c99.h #defines isnan(x) to
1244 __builtin_isnan(x), but the bundled gcc, which identifies itself
1245 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1246 a __builtin_isnan.
1247 * floatfns.c (isnan): #undef, and then #define to a clone of
1248 what's in data.c.
1249 (Fisnan): Always define, since it's always available now.
1250 (syms_of_floatfns): Always define isnan at the Lisp level.
1251
12522011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1253
1254 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1255
12562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1259 The previous code assumed that file offsets (off_t values) fit in
1260 EMACS_INT variables, which is not true on typical 32-bit hosts.
1261 The code messed up by falsely reporting buffer overflow in cases
1262 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1263 when "big" contains more than 2**29 bytes, even though this
1264 inserts just one byte and does not overflow the buffer.
1265 (Finsert_file_contents): Store file offsets as off_t
1266 values, not as EMACS_INT values. Check for overflow when
1267 converting between EMACS_INT and off_t. When checking for
1268 buffer overflow or for overlap, take the offsets into account.
1269 Don't use EMACS_INT for small values where int suffices.
1270 When checking for overlap, fix a typo: ZV was used where
1271 ZV_BYTE was intended.
1272 (Fwrite_region): Don't assume off_t fits into 'long'.
1273 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1274
12752011-09-05 Michael Albinus <michael.albinus@gmx.de>
1276
1277 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1278
12792011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 sprintf-related integer and memory overflow issues (Bug#9412).
1282
1283 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1284 (esprintf, exprintf, evxprintf): New functions.
1285 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1286 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1287 (modify_event_symbol): Do not assume that the length of
1288 name_alist_or_stem is safe to alloca and fits in int.
1289 (Fexecute_extended_command): Likewise for function name and binding.
1290 (Frecursion_depth): Wrap around reliably on integer overflow.
1291 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1292 since some callers pass EMACS_INT values.
1293 (Fsingle_key_description): Don't crash if symbol name contains more
1294 than MAX_ALLOCA bytes.
1295 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1296 (get_minibuffer): Arg is now EMACS_INT, not int.
1297 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1298 (esprintf, exprintf, evxprintf): New decls.
1299 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1300
1301 * dbusbind.c (signature_cat): New function.
1302 (xd_signature, Fdbus_register_signal):
1303 Do not overrun buffer; instead, report string overflow.
1304
1305 * dispnew.c (add_window_display_history): Don't overrun buffer.
1306 Truncate instead; this is OK since it's just a log.
1307
1308 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1309 even if the time zone offset is outlandishly large.
1310 Don't mishandle offset == INT_MIN.
1311
1312 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1313 when creating daemon; the previous buffer-overflow check was incorrect.
1314
1315 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1316 which has the guts of the old verror function.
1317
1318 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1319 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1320
1321 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1322 (font_unparse_xlfd): Don't blindly alloca long strings.
1323 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1324 fits in int, when using sprintf. Use single snprintf to count
1325 length of string rather than counting it via multiple sprintfs;
1326 that's simpler and more reliable.
1327 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1328 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1329 sprintf, in case result does not fit in int.
1330
1331 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1332 (fontset_from_font): Print it.
1333
1334 * frame.c (tty_frame_count): Now printmax_t, not int.
1335 (make_terminal_frame, set_term_frame_name): Print it.
1336 (x_report_frame_params): In X, window IDs are unsigned long,
1337 not signed long, so print them as unsigned.
1338 (validate_x_resource_name): Check for implausibly long names,
1339 and don't assume name length fits in 'int'.
1340 (x_get_resource_string): Don't blindly alloca invocation name;
1341 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1342 not fit in int.
1343
1344 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1345 (xg_check_special_colors, xg_set_geometry):
1346 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1347
1348 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1349 Use esprintf, not sprintf, in case result does not fit in int.
1350
1351 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1352 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1353 it as a large positive number.
1354 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1355 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1356
1357 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1358 in case result does not fit in int.
1359
1360 * print.c (float_to_string): Detect width overflow more reliably.
1361 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1362 buffer overrun. Don't assume list length fits in 'int'. Treat
1363 print length of 0 as 0, not as infinity; to be consistent with other
1364 uses of print length in this function. Don't overflow print length
1365 index. Don't assume hash table size fits in 'long', or that
1366 vectorlike size fits in 'unsigned long'.
1367
1368 * process.c (make_process): Use printmax_t, not int, to format
1369 process-name gensyms.
1370
1371 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1372
1373 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1374 to avoid potential buffer overrun.
1375
1376 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1377 if X resource line is longer than 512 bytes.
1378
1379 * xfns.c (x_window): Make sprintf buffer a bit bigger
1380 to avoid potential buffer overrun.
1381
1382 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1383
1384 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1385
13862011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 Integer overflow fixes for scrolling, etc.
1389 Without these, Emacs silently mishandles large integers sometimes.
1390 For example, "C-u 4294967297 M-x recenter" was treated as if
1391 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1392
1393 * xdisp.c (try_window_id): Check Emacs fixnum range before
1394 converting to 'int'.
1395
1396 * window.c (window_scroll_line_based, Frecenter):
1397 Check that an Emacs fixnum is in range before assigning it to 'int'.
1398 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1399 values converted from Emacs fixnums.
1400 (Frecenter): Don't wrap around a line count if it is out of 'int'
1401 range; instead, treat it as an extreme value.
1402 (Fset_window_configuration, compare_window_configurations):
1403 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1404
1405 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1406 that can exceed INT_MAX. Check that EMACS_INT value is in range
1407 before assigning it to the (possibly-narrower) index.
1408 (match_limit): Don't assume that a fixnum can fit in 'int'.
1409
1410 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1411 exceed INT_MAX.
1412
1413 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1414 (Fvertical_motion): Don't wrap around LINES values that don't fit
1415 in 'int'. Instead, treat them as extreme values. This is good
1416 enough for windows, which can't have more than INT_MAX lines anyway.
1417
14182011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1419
1420 * Require libxml/parser.h to avoid compilation warning.
1421
1422 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1423
1424 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1425 since this reportedly can destroy thread storage.
1426
14272011-08-30 Chong Yidong <cyd@stupidchicken.com>
1428
1429 * syntax.c (find_defun_start): Update all cache variables if
1430 exiting early (Bug#9401).
1431
14322011-08-30 Eli Zaretskii <eliz@gnu.org>
1433
1434 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1435
1436 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1437 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1438 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1439
1440 * term.c (tty_append_glyph): New function.
1441 (produce_stretch_glyph): Static function and its prototype deleted.
1442
1443 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1444 Add prototypes.
1445
14462011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1447
1448 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1449 when checking :margin (Bug#9390).
1450 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1451 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1452 so that the name doesn't mislead. All uses changed.
1453
14542011-08-28 Johan Bockgård <bojohan@gnu.org>
1455
1456 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1457 set_tty_hooks.
1458
14592011-08-27 Eli Zaretskii <eliz@gnu.org>
1460
1461 * xdisp.c (move_it_to): Don't bail out early when reaching
1462 position beyond to_charpos, if we are scanning backwards.
1463 (move_it_vertically_backward): When DY == 0, make sure we get to
1464 the first character in the line after the newline.
1465
14662011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1467
1468 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1469 (ccl_driver): Do not generate an out-of-range pointer.
1470 (Fccl_execute_on_string): Remove unnecessary check for
1471 integer overflow, noted by Stefan Monnier in
1472 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1473 Remove a FIXME that didn't need fixing.
1474 Simplify the newly-introduced buffer reallocation code.
1475
14762011-08-27 Juanma Barranquero <lekktu@gmail.com>
1477
1478 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1479
14802011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1481
1482 Integer and memory overflow issues (Bug#9196).
1483
1484 * doc.c (get_doc_string): Rework so that
1485 get_doc_string_buffer_size is the actual buffer size, rather than
1486 being 1 less than the actual buffer size; this makes xpalloc more
1487 convenient.
1488
1489 * image.c (x_allocate_bitmap_record, cache_image):
1490 * xselect.c (Fx_register_dnd_atom):
1491 Simplify previous changes by using xpalloc.
1492
1493 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1494 since either will do and ptrdiff_t is convenient with xpalloc.
1495
1496 * charset.c (charset_table_size)
1497 (struct charset_sort_data.priority): Now ptrdiff_t.
1498 (charset_compare): Don't overflow if priorities differ greatly.
1499 (Fsort_charsets): Don't assume list length fits in int.
1500 Check for size-calculation overflow when allocating sort data.
1501 (syms_of_charset): Allocate an initial charset table that is
1502 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1503
1504 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1505
1506 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1507 The actual value is always <= INT_MAX, and leaving it unsigned made
1508 overflow checking harder.
1509
1510 * dispextern.h (struct glyph_matrix.rows_allocated)
1511 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1512 with xpalloc. The values are still always <= INT_MAX.
1513
1514 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1515
1516 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1517 (SAFE_NALLOCA): New macro.
1518
1519 * region-cache.c (struct boundary.pos, find_cache_boundary)
1520 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1521 (set_cache_region, invalidate_region_cache)
1522 (revalidate_region_cache, know_region_cache, region_cache_forward)
1523 (region_cache_backward, pp_cache):
1524 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1525 so that ptrdiff_t * can be passed to xpalloc.
1526 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1527 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1528 (pp_cache): Don't assume cache_len fits in int.
1529 * region-cache.h: Adjust extern decls to match.
1530
1531 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1532 EMACS_INT, since either will do, for xpalloc.
1533
1534 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1535 (xnmalloc, xnrealloc, xpalloc): New functions.
1536
1537 * bidi.c (bidi_shelve_header_size): New constant.
1538 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1539 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1540
1541 * bidi.c (bidi_cache_shrink):
1542 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1543 (overlay_strings):
1544 Don't update size of array until after memory allocation succeeds,
1545 because xmalloc/xrealloc may not return.
1546 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1547 now that we have proper integer overflow checking.
1548 (record_overlay_string, overlay_strings): Catch overflows when
1549 calculating size of overlay_str_buf.
1550
1551 * callproc.c (Fcall_process): Check for size overflow when
1552 calculating size of args2.
1553 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1554 Normally we prefer signed values, but sticking with ptrdiff_t would
1555 require adding more-complicated checks.
1556
1557 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1558 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1559 Redo buffer-overflow calculations to avoid integer overflow.
1560 Add a FIXME comment where memory seems to be over-allocated.
1561
1562 * character.c (Fstring): Check for size-calculation overflow.
1563
1564 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1565 unnecessary integer overflow. Check for size overflow.
1566 (encode_coding_object): Don't update size until xmalloc succeeds.
1567
1568 * composite.c (get_composition_id): Check for overflow in glyph
1569 length calculations.
1570
1571 Integer and memory overflow fixes for display code.
1572 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1573 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1574 (scrolling_window): Check for overflow in size calculations.
1575 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1576 Don't assume glyph table len fits in int.
1577 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1578 (row_table_size): Now ptrdiff_t, not int.
1579 (scrolling_window): Avoid overflow in size calculations.
1580 Don't update size until allocation succeeds.
1581 * fns.c (concat): Check for overflow in size calculations.
1582 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1583 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1584 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1585
1586 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1587 (get_doc_string): Check for size calculation overflow.
1588 Don't update size until allocation succeeds.
1589 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1590 EMACS_INT, where ptrdiff_t will do.
1591 (Fsubstitute_command_keys): Check for string overflow.
1592
1593 * editfns.c (set_time_zone_rule): Don't assume environment length
1594 fits in int.
1595 (message_length): Now ptrdiff_t, not int.
1596 (Fmessage_box): Don't update size until allocation succeeds.
1597 Don't assume message length fits in int.
1598 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1599
1600 * emacs.c (main): Do not reallocate argv, since there is a null at
1601 the end that can be overwritten, and this way there's no need to
1602 worry about size-calculation overflow.
1603 (sort_args): Check for size-calculation overflow.
1604
1605 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1606 alloc succeeds.
1607 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1608
1609 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1610 (x_set_scroll_bar_width, x_figure_window_size):
1611 Check for integer overflow.
1612 (x_set_alpha): Do not assume XINT fits in int.
1613
1614 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1615 This is for the members text_lines, text_cols, total_lines, total_cols,
1616 where the system imposes an 'int' limit.
1617
1618 * fringe.c (Fdefine_fringe_bitmap):
1619 Don't update size until alloc works.
1620
1621 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1622 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1623
1624 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1625 Check for size-calculation overflow.
1626 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1627 do, as we prefer signed integers.
1628 (id_to_widget.max_size, id_to_widget.used)
1629 (xg_store_widget_in_map, xg_remove_widget_from_map)
1630 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1631 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1632 Use and return ptrdiff_t, not int.
1633 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1634 * gtkutil.h: Change prototypes to match the above.
1635
1636 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1637 are duplicate now that they've been promoted to lisp.h.
1638 (x_allocate_bitmap_record, x_alloc_image_color)
1639 (make_image_cache, cache_image, xpm_load):
1640 Don't update size until alloc is done.
1641 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1642 (x_detect_edges):
1643 Check for size calculation overflow.
1644 (ct_colors_allocated_max): New constant.
1645 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1646 overflow.
1647
1648 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1649 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1650 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1651 Use ptrdiff_t, not int, to count maps.
1652 (read_char_minibuf_menu_prompt): Check for overflow in size
1653 calculations. Don't update size until allocation succeeds.
1654 Redo calculations to avoid overflow.
1655 * keyboard.h: Change prototypes to match the above.
1656
1657 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1658 to count maps.
1659 (current_minor_maps): Check for size calculation overflow.
1660 * keymap.h: Change prototypes to match the above.
1661
1662 * lread.c (read1, init_obarray): Don't update size until alloc done.
1663
1664 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1665 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1666
1667 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1668 Now ptrdiff_t, not int.
1669 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1670 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1671
1672 * process.c (Fnetwork_interface_list): Check for overflow
1673 in size calculation.
1674
1675 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1676
1677 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1678 overflow. Don't bother calling xmalloc when xrealloc will do.
1679
1680 * search.c (Freplace_match): Check for size calculation overflow.
1681 (Fset_match_data): Don't assume list lengths fit in 'int'.
1682
1683 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1684 for command line length. Do not attempt to address one before the
1685 beginning of an array, as that's not portable.
1686
1687 * term.c (max_frame_lines): Remove; unused.
1688 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1689 not int.
1690 (encode_terminal_code, calculate_costs): Check for size
1691 calculation overflow.
1692 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1693 table lengths and related sizes. Don't update size until alloc
1694 done. Redo calculations to avoid overflow.
1695 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1696
1697 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1698 subtracting pointers.
1699 (gobble_line): Check for overflow more carefully. Don't update size
1700 until alloc done.
1701
1702 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1703 Don't update size until alloc done.
1704 Redo size calculations to avoid overflow.
1705 Check for size calculation overflow.
1706 (main) [DEBUG]: Fix typo in invoking tparam1.
1707
1708 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1709 Use ptrdiff_t, not int, for sizes.
1710 (store_mode_line_noprop_char): Don't update size until alloc done.
1711
1712 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1713 Use ptrdiff_t, not int, for sizes.
1714 (Finternal_make_lisp_face, cache_face):
1715 Check for size calculation overflow.
1716 (cache_face): Treat size calculation overflows as if they were
1717 memory exhaustion (the usual treatment), rather than aborting.
1718
1719 * xfns.c (x_encode_text, x_set_name_internal)
1720 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1721 sizes, since they can exceed INT_MAX in size. Check for size
1722 calculation overflow.
1723
1724 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1725 (xg_select): Check for size calculation overflow.
1726 Don't update size until alloc done.
1727
1728 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1729 as sprintf is limited to int lengths.
1730
1731 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1732 (X_LONG_MIN): New macros.
1733 Use them to make the following changes clearer.
1734 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1735 This change doesn't affect the value now, but it may help remind
1736 future maintainers not to raise the value too much later.
1737 (SELECTION_QUANTUM): Remove, replacing with ...
1738 (selection_quantum): ... new function, which avoids overflow.
1739 All uses changed.
1740 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1741 assumption that selection length fits in 'int'.
1742 (x_reply_selection_request, x_handle_selection_request)
1743 (x_get_window_property, receive_incremental_selection)
1744 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1745 (lisp_data_to_selection_data, clean_local_selection_data):
1746 Use ptrdiff_t, not int, to record length of selection.
1747 (x_reply_selection_request, x_get_window_property)
1748 (receive_incremental_selection, x_property_data_to_lisp):
1749 Redo calculations to avoid overflow.
1750 (x_reply_selection_request): When sending hint, ceiling it at
1751 X_LONG_MAX rather than relying on wraparound overflow to send
1752 something.
1753 (x_get_window_property, receive_incremental_selection)
1754 (lisp_data_to_selection_data, x_property_data_to_lisp):
1755 Check for size-calculation overflow.
1756 (x_get_window_property, receive_incremental_selection)
1757 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1758 Don't store size until memory allocation succeeds.
1759 (x_get_window_property): Plug memory leak on memory exhaustion.
1760 Don't double-block input; malloc is safe here. Don't assume 2**34
1761 - 4 fits in unsigned long. Add an xassert to check
1762 XGetWindowProperty overflow. Be more careful about overflow
1763 calculations, and distinguish size from memory overflow better.
1764 (receive_incremental_selection): When tracing, don't assume
1765 unsigned int is less than INT_MAX.
1766 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1767 harmful) conversions of unsigned short to int.
1768 (lisp_data_to_selection_data): Don't assume that integers
1769 in the range -65535 through -1 fit in an X unsigned short.
1770 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1771 result parameters unless successful. Rely on cons_to_unsigned
1772 to report problems with elements; the old code wasn't right anyway.
1773 (x_check_property_data): Check for int overflow; we cannot use
1774 a wider type due to X limits.
1775 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1776
1777 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1778
1779 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1780 (x_term_init): Check for size calculation overflow.
1781 (x_color_cells): Don't store size until memory allocation succeeds.
1782 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1783 Don't assume alloca size is less than MAX_ALLOCA.
1784 (x_term_init): Don't assume length fits in int (sprintf is limited
1785 to int size).
1786
1787 Use ptrdiff_t for composition IDs.
1788 * character.c (lisp_string_width):
1789 * composite.c (composition_table_size, n_compositions)
1790 (get_composition_id, composition_gstring_from_id):
1791 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1792 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1793 * window.c (Frecenter):
1794 Use ptrdiff_t, not int, for composition IDs.
1795 * composite.c (get_composition_id): Check for integer overflow.
1796 * composite.h: Adjust prototypes to match the above changes.
1797
1798 Use ptrdiff_t for hash table indexes.
1799 * category.c (hash_get_category_set):
1800 * ccl.c (ccl_driver):
1801 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1802 * coding.c (coding_system_charset_list, detect_coding_system):
1803 * coding.h (struct coding_system.id):
1804 * composite.c (get_composition_id, gstring_lookup_cache):
1805 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1806 * image.c (xpm_get_color_table_h):
1807 * lisp.h (hash_lookup, hash_put):
1808 * minibuf.c (Ftest_completion):
1809 Use ptrdiff_t for hash table indexes, not int (which is too
1810 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1811 32-bit --with-wide-int hosts).
1812
1813 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1814 Add a FIXME comment about memory leaks.
1815 (syms_of_charset): Don't assume xmalloc returns.
1816
1817 Don't assume that stated character widths fit in int.
1818 * character.c (Fchar_width, c_string_width, lisp_string_width):
1819 * character.h (CHAR_WIDTH):
1820 * indent.c (MULTIBYTE_BYTES_WIDTH):
1821 Use sanitize_char_width to avoid undefined and/or bad behavior
1822 with outlandish widths.
1823 * character.h (sanitize_tab_width): Rename from sanitize_width,
1824 now that we have two such functions. All uses changed.
1825 (sanitize_char_width): New inline function.
1826
1827 Don't assume that tab-width fits in int.
1828 * character.h (sanitize_width): New inline function.
1829 (SANE_TAB_WIDTH): New macro.
1830 (ASCII_CHAR_WIDTH): Use it.
1831 * indent.c (sane_tab_width): Remove. All uses replaced by
1832 SANE_TAB_WIDTH (current_buffer).
1833 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1834
1835 * fileio.c: Integer overflow issues with file modes.
1836 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1837
1838 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1839 Remove unreachable code.
1840 (read_hex, load_charset_map_from_file): Check for integer overflow.
1841
1842 * xterm.c: don't go over XClientMessageEvent limit
1843 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1844 (x_send_scroll_bar_event): Likewise. Check that the size does not
1845 exceed limits imposed by XClientMessageEvent, as well as the usual
1846 ptrdiff_t and size_t limits.
1847
1848 * keyboard.c: Overflow, signedness and related fixes.
1849 (make_lispy_movement): Use same integer type in forward decl
1850 that is used in the definition.
1851 (read_key_sequence, keyremap_step):
1852 Change bufsize argument back to int, undoing my 2011-03-30 change.
1853 We prefer signed types, and int is wide enough here.
1854 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1855 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1856 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1857 length, not size_t. Use ptrdiff_t for index, not int.
1858 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1859 possibility of integer overflow.
1860
1861 Overflow, signedness and related fixes for images.
1862
1863 * dispextern.h (struct it.stack[0].u.image.image_id)
1864 (struct_it.image_id, struct image.id, struct image_cache.size)
1865 (struct image_cache.used, struct image_cache.ref_count):
1866 * gtkutil.c (update_frame_tool_bar):
1867 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1868 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1869 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1870 * nsmenu.m (update_frame_tool_bar):
1871 * xdisp.c (calc_pixel_width_or_height):
1872 * xfns.c (image_cache_refcount):
1873 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1874 on typical 64-bit hosts.
1875
1876 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1877 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1878 Omit unnecessary casts to int.
1879 (parse_image_spec): Check that integers fall into 'int' range
1880 when the callers expect that.
1881 (image_ascent): Redo ascent calculation to avoid int overflow.
1882 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1883 (lookup_image): Remove unnecessary tests.
1884 (xbm_image_p): Locals are now of int, not EMACS_INT,
1885 since parse_image_check makes sure they fit into int.
1886 (png_load, gif_load, svg_load_image):
1887 Prefer int to unsigned where either will do.
1888 (tiff_handler): New function, combining the cores of the
1889 old tiff_error_handler and tiff_warning_handler.
1890 This function is rewritten to use vsnprintf and thereby avoid
1891 stack buffer overflows. It uses only the features of vsnprintf
1892 that are common to both POSIX and native Microsoft.
1893 (tiff_error_handler, tiff_warning_handler): Use it.
1894 (tiff_load, gif_load, imagemagick_load_image):
1895 Don't assume :index value fits in 'int'.
1896 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1897 (imagemagick_load_image): Check that crop parameters fit into
1898 the integer types that MagickCropImage accepts. Don't assume
1899 Vimagemagick_render_type has a nonnegative value. Don't assume
1900 size_t fits in 'long'.
1901 (gs_load): Use printmax_t to print the widest integers possible.
1902 Check for integer overflow when computing image height and width.
1903
19042011-08-26 Eli Zaretskii <eliz@gnu.org>
1905
1906 * xdisp.c (redisplay_window): Don't force window start if point
1907 will be invisible in the resulting window. (Bug#9324)
1908
19092011-08-25 Eli Zaretskii <eliz@gnu.org>
1910
1911 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1912 the display spec is of the form `(space ...)'.
1913 (handle_display_spec): Return the value returned by
1914 handle_single_display_spec, not just 1 or zero.
1915 (handle_single_display_spec): If the display spec is of the form
1916 `(space ...)', and specifies display in the text area, return 2
1917 rather than 1.
1918 (try_cursor_movement): Check for the need to scroll more
1919 accurately, and prefer exact match for point under bidi.
1920 Don't advance `row' beyond the last row of the window.
1921
1922 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1923 into disp_prop; all users changed.
1924
1925 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1926 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1927 for the text covered by the display property.
1928
19292011-08-25 Chong Yidong <cyd@stupidchicken.com>
1930
1931 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1932 Change return value to nil.
1933 (Frecord_buffer): Delete unused function.
1934
19352011-08-24 Eli Zaretskii <eliz@gnu.org>
1936
1937 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1938 buffers, return left-to-right.
1939 (set_cursor_from_row): Consider candidate row a win if its glyph
1940 represents a newline and point is on that newline. Fixes cursor
1941 positioning on the newline at EOL of R2L text within L2R
1942 paragraph, and vice versa.
1943 (try_cursor_movement): Check continued rows, in addition to
1944 continuation rows. Fixes unwarranted scroll when point enters a
1945 continued line of R2L text within an L2R paragraph, or vice versa.
1946 (cursor_row_p): Consider the case of point being equal to
1947 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1948 from the end of a short line to the beginning of a continued line
1949 of R2L text within L2R paragraph.
1950 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1951 composed characters.
1952
1953 * bidi.c (bidi_check_type): Use xassert.
1954 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1955 members.
1956
19572011-08-23 Eli Zaretskii <eliz@gnu.org>
1958
1959 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1960 a character.
1961
19622011-08-23 Chong Yidong <cyd@stupidchicken.com>
1963
1964 * nsfont.m (ns_otf_to_script): Fix typo.
1965
19662011-08-22 Kenichi Handa <handa@m17n.org>
1967
1968 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1969 extra slot even if the purpose is char-code-property-table.
1970
19712011-08-23 Eli Zaretskii <eliz@gnu.org>
1972
1973 * xdisp.c (redisplay_window): When computing centering_position,
1974 account for the height of the header line. (Bug#8874)
1975
1976 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1977 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1978 candidate is selected by the mouse, and that candidate has a
1979 composed character under the mouse.
1980
1981 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1982 coordinates reported by pos-visible-in-window-p for a composed
1983 character in column zero.
1984
19852011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1986
1987 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1988
19892011-08-22 Eli Zaretskii <eliz@gnu.org>
1990
1991 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1992 consider it a hit if to_charpos is anywhere in the range of the
1993 composed buffer positions.
1994
19952011-08-22 Chong Yidong <cyd@stupidchicken.com>
1996
1997 * image.c (gif_load): Don't assume that each subimage has the same
1998 dimensions as the base image. Handle disposal method that is
1999 "undefined" by the gif spec (Bug#9335).
2000
20012011-08-20 Chong Yidong <cyd@stupidchicken.com>
2002
2003 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2004 (Fcondition_case): Document `debug' symbol in error handler.
2005
20062011-08-19 Eli Zaretskii <eliz@gnu.org>
2007
2008 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2009 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2010 from an Org mode buffer to a Speedbar frame.
2011
2012 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2013 a composition, take its buffer position from IT->cmp_it.charpos.
2014 Fixes cursor positioning at the beginning of a line that begins
2015 with a composed character.
2016
20172011-08-18 Eli Zaretskii <eliz@gnu.org>
2018
2019 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2020 character bidirectional type, use STRONG_L instead. Fixes crashes
2021 in a buffer produced by `describe-categories'.
2022
2023 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2024 members before the level stack, so they would be saved and
2025 restored when copying iterator state. Fixes incorrect reordering
2026 around TABs covered by display properties.
2027
20282011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2029
2030 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2031
20322011-08-17 Chong Yidong <cyd@stupidchicken.com>
2033
2034 * eval.c (internal_condition_case, internal_condition_case_1)
2035 (internal_condition_case_2, internal_condition_case_n):
2036 Remove unnecessary aborts (Bug#9081).
2037
20382011-08-17 Eli Zaretskii <eliz@gnu.org>
2039
2040 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2041 has no `load' handler, try opening the file locally. (Bug#9311)
2042
20432011-08-16 Ken Brown <kbrown@cornell.edu>
2044
2045 * gmalloc.c: Expand comment.
2046
20472011-08-16 Eli Zaretskii <eliz@gnu.org>
2048
2049 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2050 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2051
20522011-08-16 Ken Brown <kbrown@cornell.edu>
2053
2054 Fix memory allocation problems in Cygwin build (Bug#9273).
2055
2056 * unexcw.c ( __malloc_initialized): Declare external variable.
2057 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2058
2059 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2060 New variables.
2061 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2062 dumped emacs.
2063 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2064 in the static heap.
2065 [CYGWIN] (special_realloc): New function.
2066 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2067 requests to realloc storage in the static heap.
2068
20692011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2070
2071 * bidi.c (bidi_initialize): Remove unused local.
2072
20732011-08-15 Eli Zaretskii <eliz@gnu.org>
2074
2075 * bidimirror.h:
2076 * biditype.h: Remove file.
2077 * makefile.w32-in ($(BLD)/bidi.$(O)):
2078 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2079
2080 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2081
2082 * chartab.c: Improve commentary for the uniprop_table API.
2083
2084 * bidi.c (bidi_paragraph_init): Support zero value of
2085 bidi_ignore_explicit_marks_for_paragraph_level.
2086 (bidi_initialize): Use uniprop_table instead of including
2087 biditype.h and bidimirror.h.
2088
2089 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2090 coordinates of the iterator when restoring from ppos_it.
2091 (Bug#9296)
2092
20932011-08-14 Kenichi Handa <handa@m17n.org>
2094
2095 * process.c (create_process): Call setup_process_coding_systems
2096 after the pid of the process is set to -1 (Bug#8162).
2097
20982011-08-14 Eli Zaretskii <eliz@gnu.org>
2099
2100 * xdisp.c (move_it_in_display_line_to): Don't invoke
2101 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2102 ppos_it. Fixes vertical cursor motion when line beginning is
2103 covered by an image. (Bug#9296)
2104
21052011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2106
2107 * nsterm.h (ns_run_ascript): Declare.
2108 (NSAPP_DATA2_RUNASSCRIPT): Define.
2109
2110 * nsfns.m (as_script, as_result, as_status): New static variables.
2111 (ns_run_ascript): New function.
2112 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2113 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2114 the event loop. Get status from as_status (Bug#7276).
2115
2116 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2117 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2118 the event loop (Bug#7276).
2119
21202011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2121
2122 * gnutls.c (QCgnutls_bootprop_priority)
2123 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2124 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2125 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2126 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2127 (QCgnutls_bootprop_verify_hostname_error)
2128 (QCgnutls_bootprop_callbacks_verify): Rename from
2129 Qgnutls_bootprop_..., all uses changed.
2130
2131 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2132 uses changed.
2133
21342011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2135
2136 * xfaces.c (Qframe_set_background_mode): Now static.
2137 * dispextern.h (Qframe_set_background_mode): Remove decl.
2138
2139 * process.c (Fnetwork_interface_info): Declare local only if needed.
2140
21412011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2142
2143 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2144 (Fnetwork_interface_list): Allocate in increments of bytes instead
2145 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2146 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2147 sockaddr.
2148 (struct ifflag_def): notrailers is smart on OSX.
2149 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2150 Get hardware address with getifaddrs if available.
2151
21522011-08-12 Eli Zaretskii <eliz@gnu.org>
2153
2154 * xdisp.c (iterate_out_of_display_property): xassert that
2155 IT->position is set to within IT->object's boundaries. Break from
2156 the loop as soon as EOB is reached; avoids infloops in redisplay
2157 when IT->position is set up wrongly due to some bug.
2158 Set IT->current to match the bidi iterator unconditionally.
2159 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2160 entry. Force push_it to save on the stack the current
2161 buffer/string position, to be restored by pop_it. Fix flags in
2162 the iterator structure wrt the object coming from a display
2163 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2164 properties. (Bug#9284)
2165
21662011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2167
2168 * fontset.c (fontset_get_font_group): Add proper type checks.
2169 (Bug#9172)
2170
21712011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2172
2173 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2174 and LC_VERSION_MIN_MACOSX.
2175 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2176 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2177
21782011-08-08 Eli Zaretskii <eliz@gnu.org>
2179
2180 * xdisp.c (forward_to_next_line_start): Allow to use the
2181 no-display-properties-and-no-overlays under bidi display.
2182 Set disp_pos in the bidi iterator to avoid searches for display
2183 properties and overlays.
2184
21852011-08-08 Chong Yidong <cyd@stupidchicken.com>
2186
2187 * editfns.c (Fset_time_zone_rule): Document relationship with the
2188 setenv function.
2189
2190 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2191 the font entity extracted from the cache (Bug#8109).
2192
21932011-08-07 Chong Yidong <cyd@stupidchicken.com>
2194
2195 * composite.c (autocmp_chars): Don't reset point. That is done by
2196 restore_point_unwind (Bug#5984).
2197
21982011-08-07 Juri Linkov <juri@jurta.org>
2199
2200 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2201 to show the arg `TIME' instead of `TIMEVAL'.
2202
22032011-08-06 Eli Zaretskii <eliz@gnu.org>
2204
2205 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2206 display property strides EOL and includes a newline, as in
2207 longlines-mode. (Bug#9254)
2208 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2209 word-wrap under bidirectional display. (Bug#9224)
2210
2211 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2212 is non-zero, even if the data buffer is NULL. Fixes a crash in
2213 vertical-motion with longlines-mode. (Bug#9254)
2214
22152011-08-05 Eli Zaretskii <eliz@gnu.org>
2216
2217 * bidi.c <bidi_cache_total_alloc>: Now static.
2218 (bidi_initialize): Initialize bidi_cache_total_alloc.
2219
2220 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2221 cache. (Bug#9221)
2222
2223 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2224 amount allocated this far in `bidi_cache_total_alloc'.
2225 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2226 non-zero, only free the data buffer without restoring the cache
2227 contents. All callers changed.
2228
2229 * dispextern.h (bidi_unshelve_cache): Update prototype.
2230
2231 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2232 (move_it_in_display_line, move_it_to)
2233 (move_it_vertically_backward, move_it_by_lines): Replace the call
2234 to xfree to an equivalent call to bidi_unshelve_cache.
2235 (move_it_in_display_line_to): Fix logic of returning
2236 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2237
22382011-08-05 Eli Zaretskii <eliz@gnu.org>
2239
2240 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2241 came from a string character with a `cursor' property. (Bug#9229)
2242
22432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2244
2245 * Makefile.in (LIB_PTHREAD): New variable.
2246 (LIBES): Add LIB_PTHREAD (Bug#9216).
2247
2248 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2249 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2250
22512011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2252
2253 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2254
22552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2256
2257 * xterm.c (x_find_topmost_parent): New function.
2258 (x_set_frame_alpha): Find topmost parent window with
2259 x_find_topmost_parent and set the property there also (bug#9181).
2260 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2261
22622011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2263
2264 * callproc.c (Fcall_process): Avoid vfork clobbering
2265 the local vars buffer, coding_systems, current_dir.
2266
22672011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2268
2269 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2270
22712011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2272
2273 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2274 so that it is not optimized away.
2275
2276 * xdisp.c (compute_display_string_pos): Remove unused local.
2277
22782011-08-02 Eli Zaretskii <eliz@gnu.org>
2279
2280 Fix slow cursor motion and scrolling in large buffers with
2281 selective display, like Org Mode buffers. (Bug#9218)
2282
2283 * dispextern.h (struct bidi_it): New member disp_prop_p.
2284
2285 * xdisp.c: Remove one-slot cache of display string positions.
2286 (compute_display_string_pos): Accept an additional argument
2287 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2288 for a display string or property. If found, set DISP_PROP_P
2289 non-zero.
2290
2291 * bidi.c (bidi_fetch_char): Accept an additional argument
2292 DISP_PROP_P, and pass it to compute_display_string_pos.
2293 Only handle text covered by a display string if DISP_PROP_P is returned
2294 non-zero. All callers of bidi_fetch_char changed.
2295
22962011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2297
2298 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2299
23002010-12-03 Don March <don@ohspite.net>
2301
2302 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2303 last character M-[char] is translated to ESC [char] (bug#7541).
2304
23052011-08-02 Kenichi Handa <handa@m17n.org>
2306
2307 * lisp.h (uniprop_table): Extern it.
2308
2309 * chartab.c (uniprop_table): Make it non-static.
2310
23112011-08-01 Eli Zaretskii <eliz@gnu.org>
2312
2313 * xdisp.c (forward_to_next_line_start): Accept additional argument
2314 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2315 on the newline.
2316 (reseat_at_next_visible_line_start): Use the bidi iterator state
2317 returned by forward_to_next_line_start to restore the state of
2318 it->bidi_it after backing up to previous newline. (Bug#9212)
2319
23202011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2321
2322 * regex.c (re_comp): Protoize.
2323 (re_exec): Fix return type.
2324 (regexec): Fix type of `ret'. (Bug#9203)
2325
23262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2327
2328 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2329 This is needed if max-image-size is a floating-point number.
2330
23312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2332
2333 * print.c (print_object): Print empty symbol as ##.
2334
2335 * lread.c (read1): Read ## as empty symbol.
2336
23372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2338
2339 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2340 setting frame foreground color (Bug#9175).
2341 (x_set_background_color): Likewise.
2342
2343 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2344 contents (Bug#9176).
2345 (EmacsTooltip -init): Remove bezels and add shadows to
2346 tooltip windows.
2347
2348 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2349 or scroll bar (Bug#8470).
2350
2351 * nsfont.m (nsfont_open): Remove assignment to voffset and
2352 unnecessary vars hshink, expand, hd, full_height, min_height.
2353 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2354
2355 * nsterm.h (nsfont_info): Remove voffset field.
2356
23572011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2358
2359 Implement strike-through and overline on NextStep (Bug#8863).
2360
2361 * nsfont.m (nsfont_open): Use underline position provided by font,
2362 instead of hard-coded value of 2.
2363 (nsfont_draw): Call ns_draw_text_decoration instead.
2364
2365 * nsterm.h: Add declaration for ns_draw_text_decoration.
2366
2367 * nsterm.m (ns_draw_text_decoration): New function for drawing
2368 underline, overline, and strike-through.
2369 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2370 ns_draw_text_decoration. Change treatment of cursor drawing to
2371 accommodate underlining, etc.
2372
23732011-07-28 Eli Zaretskii <eliz@gnu.org>
2374
2375 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2376 default.
2377
23782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2381 Without this fix, if a signal arrives just after memory fills up,
2382 'malloc' might be invoked reentrantly.
2383
2384 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2385 In other words, assume that every image size is allowed, on non-X
2386 hosts. This assumption is probably wrong, but it lets Emacs compile.
2387
23882011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2389
2390 * regex.c (re_iswctype): Convert return values to boolean.
2391
23922011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2393
2394 * xdisp.c (compute_display_string_pos): Don't use cached display
2395 string position if the buffer had its restriction changed.
2396 (Bug#9184)
2397
23982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2401
24022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 Integer signedness and overflow and related fixes. (Bug#9079)
2405
2406 * bidi.c: Integer size and overflow fixes.
2407 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2408 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2409 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2410 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2411 (bidi_find_other_level_edge):
2412 Use ptrdiff_t instead of EMACS_INT where either will do.
2413 This works better on 32-bit hosts configured --with-wide-int.
2414 (bidi_cache_ensure_space): Check for size-calculation overflow.
2415 Use % rather than repeated addition, for better worst-case speed.
2416 Don't set bidi_cache_size until after xrealloc returns, because it
2417 might not return.
2418 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2419 (bidi_cache_ensure_space): Also check that the bidi cache size
2420 does not exceed that of the largest Lisp string or buffer. See Eli
2421 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2422
2423 * alloc.c (__malloc_size_t): Remove.
2424 All uses replaced by size_t. See Andreas Schwab's note
2425 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2426
2427 * image.c: Improve checking for integer overflow.
2428 (check_image_size): Assume that f is nonnull, since
2429 it is always nonnull in practice. This is one less thing to
2430 worry about when checking for integer overflow later.
2431 (x_check_image_size): New function, which checks for integer
2432 overflow issues inside X.
2433 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2434 This removes the need for a memory_full check.
2435 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2436 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2437 (xbm_read_bitmap_data): Change locals back to 'int', since
2438 their values must fit in 'int'.
2439 (xpm_load_image, png_load, tiff_load):
2440 Invoke x_create_x_image_and_pixmap earlier,
2441 to avoid much needless work if the image is too large.
2442 (tiff_load): Treat overly large images as if
2443 x_create_x_image_and_pixmap failed, not as malloc failures.
2444 (gs_load): Use x_check_image_size.
2445
2446 * gtkutil.c: Omit integer casts.
2447 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2448 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2449
2450 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2451
2452 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2453 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2454 would wrongly return t on a 64-bit host.
2455
2456 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2457 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2458 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2459 and therefore cause GCC to emit a bogus diagnostic in some cases.
2460
2461 * image.c: Integer signedness and overflow and related fixes.
2462 This is not an exhaustive set of fixes, but it's time to
2463 record what I've got.
2464 (lookup_pixel_color, check_image_size): Remove redundant decls.
2465 (check_image_size): Don't assume that arbitrary EMACS_INT values
2466 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2467 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2468 (tiff_load, imagemagick_load_image):
2469 Check for overflow in size calculations.
2470 (x_create_x_image_and_pixmap): Remove unnecessary test for
2471 xmalloc returning NULL; that can't happen.
2472 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2473 (xpm_color_bucket): Use better integer hashing function.
2474 (xpm_cache_color): Don't possibly over-allocate memory.
2475 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2476 (gif_memory_source):
2477 Use ptrdiff_t, not int or size_t, to record sizes.
2478 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2479 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2480 either works, as we prefer signed integers.
2481 (tiff_read_from_memory, tiff_write_from_memory):
2482 Return tsize_t, not size_t, since that's what the TIFF API wants.
2483 (tiff_read_from_memory): Don't fail simply because the read would
2484 go past EOF; instead, return a short read.
2485 (tiff_load): Omit no-longer-needed casts.
2486 (Fimagemagick_types): Don't assume size fits into 'int'.
2487
2488 Improve hashing quality when configured --with-wide-int.
2489 * fns.c (hash_string): New function, taken from sxhash_string.
2490 Do not discard information about ASCII character case; this
2491 discarding is no longer needed.
2492 (sxhash-string): Use it. Change sig to match it. Caller changed.
2493 * lisp.h: Declare it.
2494 * lread.c (hash_string): Remove, since we now use fns.c's version.
2495 The fns.c version returns a wider integer if --with-wide-int is
2496 specified, so this should help the quality of the hashing a bit.
2497
2498 * emacs.c: Integer overflow minor fix.
2499 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2500 Define only if GNU_LINUX.
2501 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2502
2503 * dispnew.c: Integer signedness and overflow fixes.
2504 Remove unnecessary forward decls, that were a maintenance hassle.
2505 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2506 All uses changed.
2507 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2508 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2509 (prepare_desired_row, line_draw_cost):
2510 Use int, not unsigned, where either works.
2511 (save_current_matrix, restore_current_matrix):
2512 Use ptrdiff_t, not size_t, where either works.
2513 (init_display): Check for overflow more accurately, and without
2514 relying on undefined behavior.
2515
2516 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2517 Remove, replacing with the new symbols in lisp.h. All uses changed.
2518 * fileio.c (make_temp_name):
2519 * filelock.c (lock_file_1, lock_file):
2520 * xdisp.c (message_dolog):
2521 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2522 Use pMd etc. instead.
2523 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2524 replacing the pWIDE etc. symbols removed from editfns.c.
2525
2526 * keyboard.h (num_input_events): Now uintmax_t.
2527 This is (very slightly) less likely to mess up due to wraparound.
2528 All uses changed.
2529
2530 * buffer.c: Integer signedness fixes.
2531 (alloc_buffer_text, enlarge_buffer_text):
2532 Use ptrdiff_t rather than size_t when either will do, as we prefer
2533 signed integers.
2534
2535 * alloc.c: Integer signedness and overflow fixes.
2536 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2537 (__malloc_size_t): Default to size_t, not to int.
2538 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2539 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2540 Prefer ptrdiff_t to size_t when either would do, as we prefer
2541 signed integers.
2542 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2543 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2544 Now const. Initialize with values that are in range even if char
2545 is signed.
2546 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2547 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2548 These functions do the right thing with sizes > 2**32.
2549 (check_depth): Now ptrdiff_t, not int.
2550 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2551 Adjust to new way of storing sizes. Check for size overflow bugs
2552 in rest of code.
2553 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2554 slightly wrong anyway, as it missed one instance of
2555 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2556 (refill_memory_reserve): Omit needless cast to size_t.
2557 (mark_object_loop_halt): Mark as externally visible.
2558
2559 * xselect.c: Integer signedness and overflow fixes.
2560 (Fx_register_dnd_atom, x_handle_dnd_message):
2561 Use ptrdiff_t, not size_t, since we prefer signed.
2562 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2563 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2564 x_dnd_atoms_size and x_dnd_atoms_length.
2565
2566 * doprnt.c: Prefer signed to unsigned when either works.
2567 * eval.c (verror):
2568 * doprnt.c (doprnt):
2569 * lisp.h (doprnt):
2570 * xdisp.c (vmessage):
2571 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2572 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2573 prefer signed arithmetic to avoid comparison confusion.
2574 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2575 but is a bit tricky.
2576
2577 Assume freestanding C89 headers, string.h, stdlib.h.
2578 * data.c, doprnt.c, floatfns.c, print.c:
2579 Include float.h unconditionally.
2580 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2581 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2582 * regex.c: Likewise for stddef.h, string.h.
2583 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2584 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2585 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2586 (STDC_HEADERS): Remove obsolete defines.
2587 * sysdep.c: Include limits.h unconditionally.
2588
2589 Assume support for memcmp, memcpy, memmove, memset.
2590 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2591 * regex.c (memcmp, memcpy):
2592 Remove; we assume C89 now.
2593
2594 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2595 (__malloc_safe_bcopy): Remove; no longer needed.
2596
2597 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2598 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2599 well either way, and we prefer signed to unsigned.
2600
26012011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2602
2603 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2604 closes the connection while we're reading (bug#9182).
2605
26062011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2607
2608 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2609 are specified (Bug#9168).
2610
26112011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2614 Found by GCC static checking and --with-wide-int on a 32-bit host.
2615
26162011-07-25 Eli Zaretskii <eliz@gnu.org>
2617
2618 * xdisp.c (compute_display_string_pos): Fix logic of caching
2619 previous display string position. Initialize cached_prev_pos to
2620 -1. Fixes slow-down at the beginning of a buffer.
2621
26222011-07-24 Eli Zaretskii <eliz@gnu.org>
2623
2624 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2625 for attrs[LFACE_FONTSET_INDEX].
2626
26272011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2628
2629 * xml.c (parse_region): Remove unused local
2630 that was recently introduced.
2631
26322011-07-23 Eli Zaretskii <eliz@gnu.org>
2633
2634 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2635 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2636
2637 * xdisp.c (move_it_in_display_line_to): Record the best matching
2638 position for TO_CHARPOS while scanning the line, and restore it on
2639 exit if none of the characters scanned was an exact match.
2640 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2641 when exact match is impossible due to invisible text, and the
2642 lines are truncated.
2643
26442011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2645
2646 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2647 for OSX >= 10.7.
2648
26492011-07-22 Eli Zaretskii <eliz@gnu.org>
2650
2651 Fix a significant slow-down of cursor motion with C-n, C-p,
2652 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2653 auto-repeat under bidi redisplay in fontified buffers.
2654 * xdisp.c (compute_stop_pos_backwards): New function.
2655 (next_element_from_buffer): Call compute_stop_pos_backwards to
2656 find a suitable prev_stop when we find ourselves before
2657 base_level_stop.
2658 (reseat): Don't look for prev_stop, as that could mean a very long
2659 run.
2660 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2661 <cached_disp_overlay_modiff>: Cache for last found display string
2662 position.
2663 (compute_display_string_pos): Return the cached position if asked
2664 about the same buffer in the same area of character positions, and
2665 the buffer wasn't changed since the time the display string
2666 position was cached.
2667
26682011-07-22 Eli Zaretskii <eliz@gnu.org>
2669
2670 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2671 is an integer, which is important for empty lines. (Bug#9149)
2672
26732011-07-22 Chong Yidong <cyd@stupidchicken.com>
2674
2675 * frame.c (Fmodify_frame_parameters): In tty case, update the
2676 default face if necessary (Bug#4238).
2677
26782011-07-21 Chong Yidong <cyd@stupidchicken.com>
2679
2680 * editfns.c (Fstring_to_char): No need to explain what a character
2681 is in the docstring (Bug#6576).
2682
26832011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2684
2685 * xml.c (parse_region): Make sure we always return a tree.
2686
26872011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2688
2689 * xml.c (parse_region): If a document contains only comments,
2690 return that, too.
2691
26922011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2693
2694 * xml.c (make_dom): Return comments, too.
2695
26962011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 Port to OpenBSD.
2699 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2700 and the surrounding thread.
2701 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2702 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2703 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2704 timer goes off.
2705 * s/openbsd.h (BROKEN_SIGIO): Define.
2706 * unexelf.c (unexec) [__OpenBSD__]:
2707 Don't update the .mdebug section of the Alpha COFF symbol table.
2708
27092011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2710
2711 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2712 (bug#8460).
2713
27142011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2715
2716 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2717 This fixes some race conditions on the permissions of any newly
2718 created file.
2719
2720 * alloc.c (valid_pointer_p): Use pipe, not open.
2721 This fixes some permissions issues when debugging.
2722
2723 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2724 If fchown fails to set both uid and gid, try to set just gid,
2725 as that is sometimes allowed. Adjust the file's mode to eliminate
2726 setuid or setgid bits that are inappropriate if fchown fails.
2727
27282011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2729
2730 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2731 to compare Lisp_Objects.
2732 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2733 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2734 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2735
27362011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2737
2738 * lread.c (read_integer): Unread even EOF character.
2739 (read1): Likewise. Properly record start position of symbol.
2740
2741 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2742 symbol character follows.
2743
27442011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2745
2746 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2747 This works around a problem with the previous change to Fcopy_file.
2748 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2749 and without this change, GCC might complain about discarding
2750 fchown's return value.
2751
27522011-07-16 Juanma Barranquero <lekktu@gmail.com>
2753
2754 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2755
27562011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2757
2758 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2759
27602011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2761
2762 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2763 it's used from the C level.
2764
2765 * process.c: Use the same condition for POLL_FOR_INPUT in both
2766 keyboard.c and process.c (bug#1858).
2767
27682011-07-09 Lawrence Mitchell <wence@gmx.li>
2769
2770 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2771 (Fgnutls_boot): Use it.
2772
27732011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2774
2775 * doc.c (Fsubstitute_command_keys): Revert last change.
2776
27772011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2778
2779 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2780 quotes the next character, and doesn't affect other longer
2781 sequences (bug#8935).
2782
2783 * lread.c (syms_of_lread): Clarify that is isn't only
2784 `eval-buffer' and `eval-defun' that's affected by
2785 `lexical-binding' (bug#8460).
2786
27872011-07-15 Eli Zaretskii <eliz@gnu.org>
2788
2789 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2790 bidi redisplay when a line includes both an image and is truncated.
2791
27922011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2793
2794 Fix minor problems found by static checking.
2795 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2796 (elsz): Now a signed constant, not a size_t var. We prefer signed
2797 types to unsigned, to avoid integer comparison confusion. Without
2798 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2799 "cannot optimize loop, the loop counter may overflow", a symptom
2800 of the confusion.
2801 * indent.c (Fvertical_motion): Mark locals as initialized.
2802 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2803
28042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2805
2806 * search.c (Fre_search_backward): Mention `case-fold-search' in
2807 all the re_search_* functions (bug#8138).
2808
2809 * keyboard.c (Fopen_dribble_file): Document when the file is
2810 closed (bug#8056).
2811
28122011-07-14 Eli Zaretskii <eliz@gnu.org>
2813
2814 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2815 bidi_cache_idx.
2816
2817 Support bidi reordering of display and overlay strings.
2818 * xdisp.c (compute_display_string_pos)
2819 (compute_display_string_end): Accept additional argument STRING.
2820 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2821 (reseat_to_string): Initialize bidi_it->string.s and
2822 bidi_it->string.schars.
2823 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2824 NULL (avoids a crash in bidi_paragraph_init).
2825 Initialize itb.string.lstring.
2826 (init_iterator): Call bidi_init_it only of a valid
2827 buffer position was specified. Initialize paragraph_embedding to
2828 L2R.
2829 (reseat_to_string): Initialize the bidi iterator.
2830 (display_string): If we need to ignore text properties of
2831 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2832 original value of -1 will not work with bidi.)
2833 (compute_display_string_pos): First arg is now struct
2834 `text_pos *'; all callers changed. Support display properties on
2835 Lisp strings.
2836 (compute_display_string_end): Support display properties on Lisp
2837 strings.
2838 (init_iterator, reseat_1, reseat_to_string): Initialize the
2839 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2840 when iterating on a string not from display properties).
2841 (compute_display_string_pos, compute_display_string_end):
2842 Fix calculation of the object to scan. Fixes an error when using
2843 arrow keys.
2844 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2845 base_level_stop; instead, set base_level_stop to BEGV.
2846 Fixes crashes in vertical-motion.
2847 (next_element_from_buffer): Improve commentary for when
2848 the iterator is before prev_stop.
2849 (init_iterator): Initialize bidi_p from the default value of
2850 bidi-display-reordering, not from buffer-local value. Use the
2851 buffer-local value only if initializing for buffer iteration.
2852 (handle_invisible_prop): Support invisible properties on strings
2853 that are being bidi-reordered.
2854 (set_iterator_to_next): Support bidi reordering of C strings and
2855 Lisp strings.
2856 (next_element_from_string): Support bidi reordering of Lisp
2857 strings.
2858 (handle_stop_backwards): Support Lisp strings as well.
2859 (display_string): Support display of R2L glyph rows.
2860 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2861 (init_iterator): Don't initialize it->bidi_p for strings
2862 here.
2863 (reseat_to_string): Initialize it->bidi_p for strings here.
2864 (next_element_from_string, next_element_from_c_string)
2865 (next_element_from_buffer): Add xassert's for correspondence
2866 between IT's object being iterated and it->bidi_it.string
2867 structure.
2868 (face_before_or_after_it_pos): Support bidi iteration.
2869 (next_element_from_c_string): Handle the case of the first string
2870 character that is not the first one in the visual order.
2871 (get_visually_first_element): New function, refactored from common
2872 parts of next_element_from_buffer, next_element_from_string, and
2873 next_element_from_c_string.
2874 (tool_bar_lines_needed, redisplay_tool_bar)
2875 (display_menu_bar): Force left-to-right direction. Add a FIXME
2876 comment for making that be controlled by a user option.
2877 (push_it, pop_it): Save and restore the state of the
2878 bidi iterator. Save and restore the bidi_p flag.
2879 (pop_it): Iterate out of display property for string iteration as
2880 well.
2881 (iterate_out_of_display_property): Support iteration over strings.
2882 (handle_single_display_spec): Set up it->bidi_it for iteration
2883 over a display string, and call bidi_init_it.
2884 (handle_single_display_spec, next_overlay_string)
2885 (get_overlay_strings_1, push_display_prop): Set up the bidi
2886 iterator for displaying display or overlay strings.
2887 (forward_to_next_line_start): Don't use the shortcut if
2888 bidi-iterating.
2889 (back_to_previous_visible_line_start): If handle_display_prop
2890 pushed the iterator stack, restore the internal state of the bidi
2891 iterator by calling bidi_pop_it same number of times.
2892 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2893 and we are bidi-iterating, don't decrement the iterator position;
2894 instead, set the first_elt flag in the bidi iterator, to produce
2895 the same effect.
2896 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2897 (push_display_prop): xassert that we are iterating a buffer.
2898 (push_it, pop_it): Save and restore paragraph_embedding member.
2899 (handle_single_display_spec, next_overlay_string)
2900 (get_overlay_strings_1, reseat_1, reseat_to_string)
2901 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2902 correctly. Don't assume unibyte strings are not bidi-reordered.
2903 (compute_display_string_pos)
2904 (compute_display_string_end): Fix handling the case of C string.
2905 (push_it, pop_it): Save and restore from_disp_prop_p.
2906 (handle_single_display_spec, push_display_prop): Set the
2907 from_disp_prop_p flag.
2908 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2909 (pop_it): Call iterate_out_of_display_property only if we are
2910 popping after iteration over a string that came from a display
2911 property. Fix a typo in popping stretch info. Add an assertion
2912 for verifying that the iterator position is in sync with the bidi
2913 iterator.
2914 (handle_single_display_spec, get_overlay_strings_1)
2915 (push_display_prop): Fix initialization of paragraph direction for
2916 string when that of the parent object is not yet determined.
2917 (reseat_1): Call bidi_init_it to resync the bidi
2918 iterator with IT's position. (Bug#7616)
2919 (find_row_edges): If ROW->start.pos gives position
2920 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2921 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2922 Reset the from_disp_prop_p flag.
2923 (SAVE_IT, RESTORE_IT): New macros.
2924 (pos_visible_p, face_before_or_after_it_pos)
2925 (back_to_previous_visible_line_start)
2926 (move_it_in_display_line_to, move_it_in_display_line)
2927 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2928 (try_scrolling, redisplay_window, display_line): Use them when
2929 saving a temporary copy of the iterator and restoring it back.
2930 (back_to_previous_visible_line_start, reseat_1)
2931 (init_iterator): Empty the bidi cache "stack".
2932 (move_it_in_display_line_to): If iterator ended up at
2933 EOL, but we never saw any buffer positions smaller than
2934 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2935 motion in bidi-reordered lines.
2936 (move_it_in_display_line_to): Record prev_method and prev_pos
2937 immediately before the call to set_iterator_to_next. Fixes cursor
2938 motion in bidi-reordered lines with stretch glyphs and strings
2939 displayed in margins. (Bug#8133) (Bug#8867)
2940 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2941 TO_CHARPOS.
2942 (pos_visible_p): Support positions in bidi-reordered lines.
2943 Save and restore bidi cache.
2944
2945 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2946 (bidi_paragraph_info): Delete unused struct.
2947 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2948 (bidi_cache_start): New variable.
2949 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2950 to zero.
2951 (bidi_cache_fetch_state, bidi_cache_search)
2952 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2953 (bidi_cache_find, bidi_peek_at_next_level)
2954 (bidi_level_of_next_char, bidi_find_other_level_edge)
2955 (bidi_move_to_visually_next): Compare cache index with
2956 bidi_cache_start rather than with zero.
2957 (bidi_fetch_char): Accept new argument STRING; all callers
2958 changed. Support iteration over a string. Support strings with
2959 display properties. Support unibyte strings. Fix the type of
2960 `len' according to what STRING_CHAR_AND_LENGTH expects.
2961 (bidi_paragraph_init, bidi_resolve_explicit_1)
2962 (bidi_resolve_explicit, bidi_resolve_weak)
2963 (bidi_level_of_next_char, bidi_move_to_visually_next):
2964 Support iteration over a string.
2965 (bidi_set_sor_type, bidi_resolve_explicit_1)
2966 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2967 can now be zero (for strings); special values 0 and -1 were
2968 changed to -1 and -2, respectively.
2969 (bidi_char_at_pos): New function.
2970 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2971 Call it instead of FETCH_MULTIBYTE_CHAR.
2972 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2973 initialized to valid values.
2974 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2975 values.
2976 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2977 the test for valid cached positions. Fix the logic for looking up
2978 the sentinel state in the cache. GCPRO the Lisp string we are
2979 iterating.
2980 (bidi_push_it, bidi_pop_it): New functions.
2981 (bidi_initialize): Initialize the bidi cache start stack pointer.
2982 (bidi_cache_ensure_space): New function, refactored from part of
2983 bidi_cache_iterator_state. Don't assume the required size is just
2984 one BIDI_CACHE_CHUNK away.
2985 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2986 (bidi_count_bytes, bidi_char_at_pos): New functions.
2987 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2988 always valid if bidi_cache_idx is valid.
2989 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2990 is valid if it's going to be used.
2991 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2992 (bidi_cache_fetch_state, bidi_cache_search)
2993 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2994 (bidi_cache_iterator_state, bidi_cache_find)
2995 (bidi_find_other_level_edge, bidi_cache_start_stack):
2996 All variables related to cache indices are now EMACS_INT.
2997
2998 * dispextern.h (struct bidi_string_data): New structure.
2999 (struct bidi_it): New member `string'. Make flag members be 1-bit
3000 fields, and put them last in the struct.
3001 (compute_display_string_pos, compute_display_string_end):
3002 Update prototypes.
3003 (bidi_push_it, bidi_pop_it): Add prototypes.
3004 (struct iterator_stack_entry): New members bidi_p,
3005 paragraph_embedding, and from_disp_prop_p.
3006 (struct it): Member bidi_p is now a bit field 1 bit wide.
3007 (bidi_shelve_cache, bidi_unshelve_cache):
3008 Declare prototypes.
3009
3010 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3011 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3012 and vector-like objects.
3013
3014 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3015 cache around display iteration.
3016
3017 * window.c (Fwindow_end, window_scroll_pixel_based)
3018 (displayed_window_lines, Frecenter): Save and restore the bidi
3019 cache around display iteration.
3020
30212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3022
3023 * editfns.c (Fdelete_region): Clarify the use of the named
3024 parameters (bug#6788).
3025
30262011-07-14 Martin Rudalics <rudalics@gmx.at>
3027
3028 * indent.c (Fvertical_motion): Set and restore w->pointm when
3029 saving and restoring the window's buffer (Bug#9006).
3030
30312011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3032
3033 * editfns.c (Fstring_to_char): Clarify just what is returned
3034 (bug#6576). Text by Eli Zaretskii.
3035
30362011-07-13 Juanma Barranquero <lekktu@gmail.com>
3037
3038 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3039
30402011-07-13 Eli Zaretskii <eliz@gnu.org>
3041
3042 * buffer.c (mmap_find): Fix a typo.
3043
30442011-07-13 Johan Bockgård <bojohan@gnu.org>
3045
3046 Fix execution of x selection hooks.
3047 * xselect.c (Qx_lost_selection_functions)
3048 (Qx_sent_selection_functions): New vars.
3049 (syms_of_xselect): DEFSYM them.
3050 (x_handle_selection_request): Pass Qx_sent_selection_functions
3051 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3052 (x_handle_selection_clear,x_clear_frame_selections):
3053 Pass Qx_lost_selection_functions rather than
3054 Vx_lost_selection_functions to Frun_hook_with_args.
3055
30562011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3057
3058 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3059 The old code sometimes used this field without initializing it.
3060
3061 * alloc.c (gc_sweep): Don't read past end of array.
3062 In theory, the old code could also have corrupted Emacs internals,
3063 though it'd be very unlikely.
3064
30652011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3066
3067 * character.c (Fcharacterp): Don't advertise optional ignored
3068 argument. (Bug#4026)
3069
30702011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3071
3072 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3073 key" (bug#4257).
3074
3075 * window.c (Fset_window_start): Doc fix (bug#4199).
3076 (Fset_window_hscroll): Ditto.
3077
30782011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3079
3080 Fix minor new problems caught by GCC 4.6.1.
3081 * term.c (init_tty): Remove unused local.
3082 * xsettings.c (store_monospaced_changed): Define this function only
3083 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3084 not used otherwise.
3085
30862011-07-12 Chong Yidong <cyd@stupidchicken.com>
3087
3088 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3089
30902011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3091
3092 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3093 are the mini-buffer and the echo area (bug#3320).
3094
3095 * term.c (init_tty): Remove support for supdup, c10 and perq
3096 terminals, which are no longer supported (bug#1482).
3097
30982011-07-10 Johan Bockgård <bojohan@gnu.org>
3099
3100 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3101
31022011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3103
3104 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3105 for non-popups (Bug#3642).
3106
31072011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3108
3109 * alloc.c (reset_malloc_hooks): Protoize.
3110 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3111 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3112 * cm.c (losecursor): Likewise.
3113 * data.c (fmod): Likewise.
3114 * dispnew.c (swap_glyphs_in_rows): Likewise.
3115 * emacs.c (memory_warning_signal): Likewise.
3116 * floatfns.c (float_error): Likewise.
3117 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3118 (otf_open, font_otf_capability, generate_otf_features)
3119 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3120 Likewise.
3121 * image.c (pbm_read_file): Likewise.
3122 * indent.c (string_display_width): Likewise.
3123 * intervals.c (check_for_interval, search_for_interval)
3124 (inc_interval_count, count_intervals, root_interval)
3125 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3126 * lread.c (defalias): Likewise.
3127 * ralloc.c (r_alloc_check): Likewise.
3128 * regex.c (set_image_of_range_1, set_image_of_range)
3129 (regex_grow_registers): Likewise.
3130 * sysdep.c (strerror): Likewise.
3131 * termcap.c (valid_filename_p, tprint, main): Likewise.
3132 * tparam.c (main): Likewise.
3133 * unexhp9k800.c (run_time_remap, save_data_space)
3134 (update_file_ptrs, read_header, write_header, calculate_checksum)
3135 (copy_file, copy_rest, display_header): Likewise.
3136 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3137 Likewise.
3138 * xdisp.c (check_it): Likewise.
3139 * xfaces.c (register_color, unregister_color, unregister_colors):
3140 Likewise.
3141 * xfns.c (print_fontset_result): Likewise.
3142 * xrdb.c (member, fatal, main): Likewise.
3143
31442011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3145
3146 Fix minor problems found by static checking (Bug#9031).
3147 * chartab.c (char_table_set_range, map_sub_char_table):
3148 Remove unused locals.
3149 (uniprop_table): Now static.
3150 * composite.c (_work_char): Remove unused static var.
3151
31522011-07-09 Juanma Barranquero <lekktu@gmail.com>
3153
3154 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3155
31562011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3157
3158 * gtkutil.c (qttip_cb): Remove code without function.
3159
31602011-07-09 Eli Zaretskii <eliz@gnu.org>
3161
3162 * w32.c (pthread_sigmask): New stub.
3163
31642011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3165
3166 Use pthread_sigmask, not sigprocmask (Bug#9010).
3167 sigprocmask is portable only for single-threaded applications, and
3168 Emacs can be multi-threaded when it uses GTK.
3169 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3170 (LIBES): Use it.
3171 * callproc.c (Fcall_process):
3172 * process.c (create_process):
3173 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3174 Use pthread_sigmask, not sigprocmask.
3175
31762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3177
3178 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3179 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3180 wrong (Bug#8591).
3181
31822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3183
3184 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3185 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3186 (xg_hide_tooltip): Fix comment.
3187
3188 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3189 in registerServicesMenuSendTypes.
3190 (validRequestorForSendType): Don't check ns_return_types.
3191
3192 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3193 ns_return_type.
3194
31952011-07-08 Jason Rumney <jasonr@gnu.org>
3196
3197 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3198 SH_SHOW for hidden windows (Bug#5482).
3199
3200 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3201 frame struct members of non-existent frames (Bug#6284).
3202
32032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3204
3205 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3206 variable firstTime not needed on OSX >= 10.6.
3207 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3208 >= 10.5. Use setKnobProportion, setDoubleValue.
3209
3210 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3211 (MAC_OS_X_VERSION_10_5): Define if not defined.
3212 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3213 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3214 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3215
3216 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3217 cString and lossyCString on OSX >= 10.4
3218
3219 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3220 sizeToFit on OSX >= 10.2.
3221
3222 * nsimage.m (allocInitFromFile): Don't use deprecated method
3223 bestRepresentationForDevice on OSX >= 10.6.
3224
3225 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3226 to avoid warning.
3227
3228 * emacs.c: Declare unexec_init_emacs_zone.
3229
3230 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3231
3232 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3233
3234 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3235 on svcsMenu (Bug#8842).
3236
3237 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3238 ns_return_types.
3239 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3240
3241 * nsterm.m (QUTF8_STRING): Declare.
3242 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3243 (validRequestorForSendType): Return type is (id).
3244 Change indexOfObjectIdenticalTo to indexOfObject.
3245 Check if we have local selection before returning self (Bug#8842).
3246 (writeSelectionToPasteboard): Put local selection into paste board
3247 if we have a local selection (Bug#8842).
3248 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3249
3250 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3251 (ns_get_local_selection): Declare.
3252
32532011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3254
3255 * keymap.c (describe_map_tree): Don't insert a double newline at
3256 the end of the buffer (bug#1169) and return whether we inserted
3257 something.
3258
3259 * callint.c (Fcall_interactively): Change "reading args" to
3260 "providing args" to try to clarify what it does (bug#1010).
3261
32622011-07-07 Kenichi Handa <handa@m17n.org>
3263
3264 * composite.c (composition_compute_stop_pos): Ignore a static
3265 composition starting before CHARPOS (Bug#8915).
3266
3267 * xdisp.c (handle_composition_prop): Likewise.
3268
32692011-07-07 Eli Zaretskii <eliz@gnu.org>
3270
3271 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3272 (Bug#9015)
3273
32742011-07-07 Kenichi Handa <handa@m17n.org>
3275
3276 * character.h (unicode_category_t): New enum type.
3277
3278 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3279 (Qchar_code_property_table): New variable.
3280 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3281 (UNIPROP_COMPRESSED_FORM_P): New macros.
3282 (char_table_ascii): Uncompress the compressed values.
3283 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3284 Uncompress the compressed values.
3285 (sub_char_table_ref_and_range): Likewise.
3286 (char_table_ref_and_range): Uncompress the compressed values.
3287 (sub_char_table_set): New arg is_uniprop. Callers changed.
3288 Uncompress the compressed values.
3289 (sub_char_table_set_range): Args changed. Callers changed.
3290 (char_table_set_range): Adjuted for the above change.
3291 (map_sub_char_table): Delete args default_val and parent. Add arg
3292 top. Give decoded values to a Lisp function.
3293 (map_char_table): Adjust for the above change. Give decoded
3294 values to a Lisp function. Gcpro more variables.
3295 (uniprop_table_uncompress)
3296 (uniprop_decode_value_run_length): New functions.
3297 (uniprop_decoder, uniprop_decoder_count): New variables.
3298 (uniprop_get_decoder, uniprop_encode_value_character)
3299 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3300 New functions.
3301 (uniprop_encoder, uniprop_encoder_count): New variables.
3302 (uniprop_get_encoder, uniprop_table)
3303 (Funicode_property_table_internal, Fget_unicode_property_internal)
3304 (Fput_unicode_property_internal): New functions.
3305 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3306 Sunicode_property_table_internal, Sget_unicode_property_internal,
3307 and Sput_unicode_property_internal. Defvar_lisp
3308 char-code-property-alist.
3309
3310 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3311 Vunicode_category_table.
3312
3313 * font.c (font_range): Adjust for the change of
3314 Vunicode_category_table.
3315
33162011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3317
3318 * m/iris4d.h: Remove file, move contents ...
3319 * s/irix6-5.h: ... here.
3320
33212011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3322
3323 Remove unportable assumption about struct layout (Bug#8884).
3324 * alloc.c (mark_buffer):
3325 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3326 (clone_per_buffer_values): Don't assume that
3327 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3328 This isn't true in general, and it's particularly not true
3329 if Emacs is configured with --with-wide-int.
3330 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3331 New macros, used in the buffer.c change.
3332
33332011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3334
3335 * xsettings.c: Use both GConf and GSettings if both are available.
3336 (store_config_changed_event): Add comment.
3337 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3338 (store_tool_bar_style_changed): New functions.
3339 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3340 (struct xsettings): Move font inside HAVE_XFT.
3341 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3342 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3343 Move inside HAVE_XFT.
3344 (something_changed_gsettingsCB): Rename from something_changedCB.
3345 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3346 also.
3347 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3348 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3349 (something_changed_gconfCB): Rename from something_changedCB.
3350 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3351 (parse_settings): Move check for font inside HAVE_XFT.
3352 (read_settings, apply_xft_settings): Add comment.
3353 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3354 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3355 call store_font_name_changed.
3356 (xft_settings_event): Add comment.
3357 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3358 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3359 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3360 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3361 (xsettings_initialize): Call init_gsettings last.
3362 (xsettings_get_system_font, xsettings_get_system_normal_font):
3363 Add comment.
3364
33652011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3366
3367 Random fixes. E.g., (random) never returned negative values.
3368 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3369 subseconds part to the entropy, as that's a bit more random.
3370 Prefer signed to unsigned, since the signedness doesn't matter and
3371 in general we prefer signed. When given a limit, use a
3372 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3373 latter isn't right if USE_2_TAGS_FOR_INTS.
3374 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3375 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3376
33772011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3378
3379 * textprop.c (text_property_stickiness):
3380 Obey Vtext_property_default_nonsticky.
3381 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3382 * w32fns.c (syms_of_w32fns):
3383 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3384
33852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3386
3387 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3388 This is more efficient than Ffile_directory_p and avoids a minor race.
3389
33902011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3391
3392 * buffer.c (Foverlay_put): Say what the return value is
3393 (bug#7835).
3394
3395 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3396 is a directory before asking whether to use the file name
3397 (bug#7564).
3398 (barf_or_query_if_file_exists): Make the "File is a directory"
3399 error be more correct.
3400
3401 * fns.c (Frequire): Remove the mention of the .gz files, since
3402 that's installation-specific, but keep the mention of
3403 `get-load-suffixes'.
3404
34052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3406
3407 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3408 Report string overflow if the output is too long.
3409
34102011-07-04 Juanma Barranquero <lekktu@gmail.com>
3411
3412 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3413 (syms_of_gnutls): Remove duplicate DEFSYM for
3414 Qgnutls_bootprop_verify_hostname_error, an error for
3415 Qgnutls_bootprop_verify_error (which is no longer used).
3416
3417 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3418 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3419 Also (re)move comments that are misplaced or no longer relevant.
3420
34212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3422
3423 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3424
34252011-07-03 Chong Yidong <cyd@stupidchicken.com>
3426
3427 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3428 and background color parameters if they have been changed.
3429
34302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3431
3432 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3433
34342011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3435
3436 * xsettings.c (SYSTEM_FONT): Define only when used.
3437 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3438
3439 * keymap.c (access_keymap_1): Now static.
3440
34412011-07-02 Chong Yidong <cyd@stupidchicken.com>
3442
3443 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3444 leave any prefix arg for the up event (Bug#1586).
3445
34462011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3447
3448 * lread.c (syms_of_lread): Mention single symbols defined by
3449 `defvar' or `defconst' (bug#7154).
3450
3451 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3452 (Frequire): Mention get-load-suffixes.
3453
34542011-07-02 Martin Rudalics <rudalics@gmx.at>
3455
3456 * window.h (window): Remove clone_number slot.
3457 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3458 Remove.
3459 (make_parent_window, make_window, saved_window)
3460 (Fset_window_configuration, save_window_save): Don't deal with
3461 clone numbers.
3462 * buffer.c (Qclone_number): Remove declaration.
3463 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3464
34652011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3466
3467 Add multiple inheritance to keymaps.
3468 * keymap.c (Fmake_composed_keymap): New function.
3469 (Fset_keymap_parent): Simplify.
3470 (fix_submap_inheritance): Remove.
3471 (access_keymap_1): New function extracted from access_keymap to handle
3472 embedded parents and handle lists of maps.
3473 (access_keymap): Use it.
3474 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3475 (Fcopy_keymap): Handle embedded parents.
3476 (Fcommand_remapping, define_as_prefix): Simplify.
3477 (Fkey_binding): Simplify.
3478 (syms_of_keymap): Move minibuffer-local-completion-map,
3479 minibuffer-local-filename-completion-map,
3480 minibuffer-local-must-match-map, and
3481 minibuffer-local-filename-must-match-map to Elisp.
3482 (syms_of_keymap): Defsubr make-composed-keymap.
3483 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3484 (parse_menu_item): Trivial simplification.
3485
34862011-07-01 Glenn Morris <rgm@gnu.org>
3487
3488 * Makefile.in (SETTINGS_LIBS): Fix typo.
3489
34902011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3491
3492 * coding.c (Fencode_coding_string): Record the last coding system
3493 used, as the function doc string says (bug#8738).
3494
34952011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3496
3497 * xsettings.c (store_monospaced_changed): Take new font as arg and
3498 check for change against current_mono_font.
3499 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3500 (emacs_settings_constructor, emacs_settings_get_property)
3501 (emacs_settings_set_property, emacs_settings_class_init)
3502 (emacs_settings_init, gsettings_obj): Remove.
3503 (something_changedCB): New function for HAVE_GSETTINGS.
3504 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3505 with value as argument.
3506 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3507 g_settings_new (Bug#8967). Do not create gsettings_obj.
3508 Remove calls to g_settings_bind. Connect something_changedCB to
3509 "changed".
3510
3511 * xgselect.c: Add defined (HAVE_GSETTINGS).
3512 (xgselect_initialize): Ditto.
3513
3514 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3515 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3516 xg_select.
3517
35182011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3519
3520 * eval.c (struct backtrace): Simplify and port the data structure.
3521 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3522 signed bit field, as this assumption is not portable and it makes
3523 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3524 "char debug_on_exit : 1" as this is not portable either; instead,
3525 use the portable "unsigned int debug_on_exit : 1". Remove unused
3526 member evalargs. Remove obsolete comments about cc bombing out.
3527
35282011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3529
3530 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3531 Let HAVE_GSETTINGS override HAVE_GCONF.
3532 (store_monospaced_changed): New function.
3533 (EMACS_SETTINGS): A new type derived from GObject to handle
3534 GSettings notifications.
3535 (emacs_settings_constructor, emacs_settings_get_property)
3536 (emacs_settings_set_property, emacs_settings_class_init):
3537 New functions.
3538 (gsettings_client, gsettings_obj): New variables.
3539 (GSETTINGS_SCHEMA): New define.
3540 (something_changedCB): Call store_monospaced_changed.
3541 (init_gsettings): New function.
3542 (xsettings_initialize): Call init_gsettings.
3543 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3544 to NULL.
3545
3546 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3547 GCONF_CFLAGS/LIBS.
3548
35492011-06-29 Martin Rudalics <rudalics@gmx.at>
3550
3551 * window.c (resize_root_window, grow_mini_window)
3552 (shrink_mini_window): Rename Qresize_root_window to
3553 Qwindow_resize_root_window and Qresize_root_window_vertically to
3554 Qwindow_resize_root_window_vertically.
3555
35562011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3557
3558 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3559
35602011-06-27 Juanma Barranquero <lekktu@gmail.com>
3561
3562 * makefile.w32-in: Redesign dependencies so they reflect more
3563 clearly which files are directly included by each source file,
3564 and not through other includes.
3565
35662011-06-27 Martin Rudalics <rudalics@gmx.at>
3567
3568 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3569 (sort_overlays, overlay_strings): When an overlay's clone number
3570 matches the window's clone number process the overlay even if
3571 the overlay's window property doesn't match the current window.
3572
3573 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3574 (Fwindow_hchild): Rename to Fwindow_left_child.
3575 (Fwindow_next): Rename to Fwindow_next_sibling.
3576 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3577 (resize_window_check): Rename to window_resize_check.
3578 (resize_window_apply): Rename to window_resize_apply.
3579 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3580 (Fdelete_other_windows_internal, resize_frame_windows)
3581 (Fsplit_window_internal, Fdelete_window_internal)
3582 (grow_mini_window, shrink_mini_window)
3583 (Fresize_mini_window_internal): Fix callers accordingly.
3584
35852011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3586
3587 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3588 (emacs_fixed_set_min_size): Remove.
3589 (emacs_fixed_new): Take frame as argument.
3590
3591 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3592 (_EmacsFixedPrivate): Remove minwidth/height.
3593 Add struct frame *f.
3594 (emacs_fixed_init): Initialize priv->f.
3595 (get_parent_class, emacs_fixed_set_min_size): Remove.
3596 (emacs_fixed_new): Set priv->f to argument.
3597 (emacs_fixed_get_preferred_width)
3598 (emacs_fixed_get_preferred_height): Use min_width/height from
3599 frames size_hint to set minimum and natural (Bug#8919).
3600 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3601 and use min_width/height from frames size_hint to set
3602 min_width/height (Bug#8919).
3603
3604 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3605 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3606 Fix indentation.
3607
36082011-06-26 Eli Zaretskii <eliz@gnu.org>
3609
3610 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3611 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3612 called at ZV.
3613
36142011-06-26 Chong Yidong <cyd@stupidchicken.com>
3615
3616 * process.c (wait_reading_process_output): Bypass select if
3617 waiting for a cell while ignoring keyboard input, and input is
3618 pending. Suggested by Jan Djärv (Bug#8869).
3619
36202011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3621
3622 Use gnulib's dup2 module instead of rolling our own.
3623 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3624
36252011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3626
3627 * dispnew.c (scrolling_window): Before scrolling, turn off a
3628 mouse-highlight in the window being scrolled.
3629
36302011-06-24 Juanma Barranquero <lekktu@gmail.com>
3631
3632 Move DEFSYM to lisp.h and use everywhere.
3633
3634 * character.h (DEFSYM): Move declaration...
3635 * lisp.h (DEFSYM): ...here.
3636
3637 * gnutls.c:
3638 * minibuf.c:
3639 * w32menu.c:
3640 * w32proc.c:
3641 * w32select.c: Don't include character.h.
3642
3643 * alloc.c (syms_of_alloc):
3644 * buffer.c (syms_of_buffer):
3645 * bytecode.c (syms_of_bytecode):
3646 * callint.c (syms_of_callint):
3647 * casefiddle.c (syms_of_casefiddle):
3648 * casetab.c (init_casetab_once):
3649 * category.c (init_category_once, syms_of_category):
3650 * ccl.c (syms_of_ccl):
3651 * cmds.c (syms_of_cmds):
3652 * composite.c (syms_of_composite):
3653 * dbusbind.c (syms_of_dbusbind):
3654 * dired.c (syms_of_dired):
3655 * dispnew.c (syms_of_display):
3656 * doc.c (syms_of_doc):
3657 * editfns.c (syms_of_editfns):
3658 * emacs.c (syms_of_emacs):
3659 * eval.c (syms_of_eval):
3660 * fileio.c (syms_of_fileio):
3661 * fns.c (syms_of_fns):
3662 * frame.c (syms_of_frame):
3663 * fringe.c (syms_of_fringe):
3664 * insdel.c (syms_of_insdel):
3665 * keymap.c (syms_of_keymap):
3666 * lread.c (init_obarray, syms_of_lread):
3667 * macros.c (syms_of_macros):
3668 * msdos.c (syms_of_msdos):
3669 * print.c (syms_of_print):
3670 * process.c (syms_of_process):
3671 * search.c (syms_of_search):
3672 * sound.c (syms_of_sound):
3673 * syntax.c (init_syntax_once, syms_of_syntax):
3674 * terminal.c (syms_of_terminal):
3675 * textprop.c (syms_of_textprop):
3676 * undo.c (syms_of_undo):
3677 * w32.c (globals_of_w32):
3678 * window.c (syms_of_window):
3679 * xdisp.c (syms_of_xdisp):
3680 * xfaces.c (syms_of_xfaces):
3681 * xfns.c (syms_of_xfns):
3682 * xmenu.c (syms_of_xmenu):
3683 * xsettings.c (syms_of_xsettings):
3684 * xterm.c (syms_of_xterm): Use DEFSYM.
3685
36862011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3687
3688 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3689
36902011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3691
3692 Integer and buffer overflow fixes (Bug#8873).
3693
3694 * print.c (printchar, strout): Check for string overflow.
3695 (PRINTPREPARE, printchar, strout):
3696 Don't set size unless allocation succeeds.
3697
3698 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3699 for sizes. Check for string overflow more accurately.
3700 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3701
3702 * macros.c: Integer and buffer overflow fixes.
3703 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3704 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3705 Use ptrdiff_t, not int, for sizes.
3706 Don't increment bufsize until after realloc succeeds.
3707 Check for size-calculation overflow.
3708 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3709
3710 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3711
3712 * lread.c: Integer overflow fixes.
3713 (read_integer): Radix is now EMACS_INT, not int,
3714 to improve quality of diagnostics for out-of-range radices.
3715 Calculate buffer size correctly for out-of-range radices.
3716 (read1): Check for integer overflow in radices, and in
3717 read-circle numbers.
3718 (read_escape): Avoid int overflow.
3719 (Fload, openp, read_buffer_size, read1)
3720 (substitute_object_recurse, read_vector, read_list, map_obarray):
3721 Use ptrdiff_t, not int, for sizes.
3722 (read1): Use EMACS_INT, not int, for sizes.
3723 Check for size overflow.
3724
3725 * image.c (cache_image): Check for size arithmetic overflow.
3726
3727 * lread.c: Integer overflow issues.
3728 (saved_doc_string_size, saved_doc_string_length)
3729 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3730 Now ptrdiff_t, not int.
3731 (read1): Don't assume doc string length fits in int. Check for
3732 out-of-range doc string lengths.
3733 (read_list): Don't assume file position fits in int.
3734 (read_escape): Check for hex character overflow.
3735
37362011-06-22 Leo Liu <sdl.web@gmail.com>
3737
3738 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3739 Move to minibuffer.el.
3740
37412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3742
3743 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3744 The following patches are for when GLYPH_DEBUG && !XASSERT.
3745 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3746 * dispnew.c (flush_stdout):
3747 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3748 Mark as externally visible.
3749 * dispnew.c (check_window_matrix_pointers): Now static.
3750 * dispnew.c (window_to_frame_vpos):
3751 * xfns.c (unwind_create_frame):
3752 * xterm.c (x_check_font): Remove unused local.
3753 * scroll.c (CHECK_BOUNDS):
3754 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3755 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3756 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3757 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3758 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3759 Now static.
3760 (debug_method_add): Use va_list and vsprintf rather than relying
3761 on undefined behavior with wrong number of arguments.
3762 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3763 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3764 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3765 since we're not interested in debugging glyphs with old libraries.
3766 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3767 GCC 4.6.0's static checking.
3768
37692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3770
3771 Integer overflow and signedness fixes (Bug#8873).
3772 A few related buffer overrun fixes, too.
3773
3774 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3775
3776 * dispextern.h (struct face.stipple):
3777 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3778 (x_bitmap_mask, x_allocate_bitmap_record)
3779 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3780 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3781 (x_create_bitmap_from_xpm_data):
3782 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3783 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3784 (.bitmaps_last):
3785 * xfaces.c (load_pixmap):
3786 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3787 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3788 (.bitmaps_last, struct x_output.icon_bitmap):
3789 Use ptrdiff_t, not int, for bitmap indexes.
3790 (x_allocate_bitmap_record): Check for size overflow.
3791 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3792
3793 Use ptrdiff_t, not int, for overlay counts.
3794 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3795 * editfns.c (overlays_around, get_pos_property):
3796 * textprop.c (get_char_property_and_overlay):
3797 * xdisp.c (next_overlay_change, note_mouse_highlight):
3798 * xfaces.c (face_at_buffer_position):
3799 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3800 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3801 (Fnext_overlay_change, Fprevious_overlay_change)
3802 (mouse_face_overlay_overlaps, Foverlays_in):
3803 Use ptrdiff_t, not int, for sizes.
3804 (overlays_at, overlays_in): Check for size-calculation overflow.
3805
3806 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3807
3808 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3809 (x_session_initialize): Do not assume string length fits in int.
3810
3811 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3812 This is unlikely, but can occur if DPI is outlandish.
3813
3814 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3815 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3816
3817 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3818 * xrdb.c (magic_file_p, search_magic_path):
3819 Omit last arg SUFFIX; it was always 0. All callers changed.
3820 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3821
3822 * xfont.c (xfont_match): Avoid need for strlen.
3823
3824 * xfns.c: Don't assume strlen fits in int.
3825 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3826
3827 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3828 not unsigned long, as we prefer signed integers. All callers changed.
3829 Detect integer overflow in repeat count.
3830 (message_dolog): Don't assume print length fits in 39 bytes.
3831 (display_mode_element): Don't assume strlen fits in int.
3832
3833 * termcap.c: Don't assume sizes fit in int and never overflow.
3834 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3835 (gobble_line): Check for size-calculation overflow.
3836
3837 * minibuf.c (Fread_buffer):
3838 * lread.c (intern, intern_c_string):
3839 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3840 Don't assume string length fits in int.
3841
3842 * keyboard.c (parse_tool_bar_item):
3843 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3844
3845 * font.c: Don't assume string length fits in int.
3846 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3847 Use ptrdiff_t, not int.
3848 (font_intern_prop): Don't assume string length fits in int.
3849 Don't assume integer property fits in fixnum.
3850 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3851
3852 * filelock.c: Fix some buffer overrun and integer overflow issues.
3853 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3854 Reformulate so as not to need the command string.
3855 Invoke gzip -cd rather than gunzip, as it's more portable.
3856 (lock_info_type, lock_file_1, lock_file):
3857 Don't assume pid_t and time_t fit in unsigned long.
3858 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3859 (current_lock_owner): Prefer signed type for sizes.
3860 Use memcpy, not strncpy, where memcpy is what is really wanted.
3861 Don't assume (via atoi) that time_t and pid_t fit in int.
3862 Check for time_t and/or pid_t out of range, e.g., via a network share.
3863 Don't alloca where an auto var works fine.
3864
3865 * fileio.c: Fix some integer overflow issues.
3866 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3867 Don't assume string length fits in int.
3868 (directory_file_name): Don't assume string length fits in long.
3869 (make_temp_name): Don't assume pid fits in int, or that its print
3870 length is less than 20.
3871
3872 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3873
3874 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3875
3876 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3877
3878 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3879 We prefer signed integers, even for size calculations.
3880
3881 * emacs.c: Don't assume string length fits in 'int'.
3882 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3883 (main): Don't invoke strlen when not needed.
3884
3885 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3886 (XD_DEBUG_MESSAGE): Don't waste a byte.
3887
3888 * callproc.c (getenv_internal_1, getenv_internal)
3889 (Fgetenv_internal):
3890 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3891
3892 * lread.c (invalid_syntax): Omit length argument.
3893 All uses changed. This doesn't fix a bug, but it simplifies the
3894 code away from its former Hollerith-constant appearance, and it's
3895 one less 'int' to worry about when looking at integer-overflow issues.
3896 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3897
3898 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3899 This didn't break anything, but it didn't help either.
3900 It's confusing to put a bogus integer in a place where the actual
3901 value does not matter.
3902 (LIST_END_P): Remove unused macro and its bogus comment.
3903 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3904
3905 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3906 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3907 implementation.
3908 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3909 We prefer signed types, and the value cannot exceed the EMACS_INT
3910 range anyway (because otherwise the length would not be representable).
3911 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3912 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3913 This avoids a GCC warning when WIDE_EMACS_INT.
3914
3915 * indent.c (sane_tab_width): New function.
3916 (current_column, scan_for_column, Findent_to, position_indentation)
3917 (compute_motion): Use it. This is just for clarity.
3918 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3919
3920 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3921
3922 * lisp.h (lint_assume): New macro.
3923 * composite.c (composition_gstring_put_cache):
3924 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3925
3926 * editfns.c, insdel.c:
3927 Omit unnecessary forward decls, to simplify future changes.
3928
3929 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3930
3931 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3932
3933 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3934 Use much-faster test for byte-length change.
3935 Don't assume string byte-length fits in 'int'.
3936 Check that character arg fits in 'int'.
3937 (mapcar1): Declare byte as byte, for clarity.
3938
3939 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3940
3941 * fns.c (concat): Catch string overflow earlier.
3942 Do not rely on integer wraparound.
3943
3944 * dispextern.h (struct it.overlay_strings_charpos)
3945 (struct it.selective): Now EMACS_INT, not int.
3946 * xdisp.c (forward_to_next_line_start)
3947 (back_to_previous_visible_line_start)
3948 (reseat_at_next_visible_line_start, next_element_from_buffer):
3949 Don't arbitrarily truncate the value of 'selective' to int.
3950
3951 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3952
3953 * composite.c: Don't truncate sizes to 'int'.
3954 (composition_gstring_p, composition_reseat_it)
3955 (composition_adjust_point): Use EMACS_INT, not int.
3956 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3957 not EMACS_UINT, for indexes.
3958
3959 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3960
3961 * buffer.c: Include <verify.h>.
3962 (struct sortvec.priority, struct sortstr.priority):
3963 Now EMACS_INT, not int.
3964 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3965 (struct sortstr.size, record_overlay_string)
3966 (struct sortstrlist.size, struct sortlist.used):
3967 Don't truncate size to int.
3968 (record_overlay_string): Check for size-calculation overflow.
3969 (init_buffer_once): Check at compile-time, not run-time.
3970
39712011-06-22 Jim Meyering <meyering@redhat.com>
3972
3973 Don't leak an XBM-image-sized buffer
3974 * image.c (xbm_load): Free the image buffer after using it.
3975
39762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3977
3978 Port to Sun C.
3979 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3980 that Sun C diagnosed.
3981 * fns.c (secure_hash): Fix pointer signedness issue.
3982 * intervals.c (static_offset_intervals): New function.
3983 (offset_intervals): Use it.
3984
39852011-06-21 Leo Liu <sdl.web@gmail.com>
3986
3987 * deps.mk (fns.o):
3988 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3989 sha512.h.
3990
3991 * fns.c (secure_hash): Rename from crypto_hash_function and change
3992 the first arg to accept symbols.
3993 (Fsecure_hash): New primitive.
3994 (syms_of_fns): New symbols.
3995
39962011-06-20 Deniz Dogan <deniz@dogan.se>
3997
3998 * process.c (Fset_process_buffer): Clarify return value in
3999 docstring.
4000
40012011-06-18 Chong Yidong <cyd@stupidchicken.com>
4002
4003 * dispnew.c (add_window_display_history): Use BVAR.
4004
4005 * xdisp.c (debug_method_add): Use BVAR.
4006 (check_window_end, dump_glyph_matrix, dump_glyph)
4007 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4008
4009 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4010 Likewise.
4011
4012 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4013 check till after the cache is created in init_frame_faces.
4014
40152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4016
4017 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4018
40192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4020
4021 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4022 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4023 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4024
4025 Improve buffer-overflow checking (Bug#8873).
4026 * fileio.c (Finsert_file_contents):
4027 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4028 Remove the old (too-loose) buffer overflow checks.
4029 They weren't needed, since make_gap checks for buffer overflow.
4030 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4031 The old code merely checked for Emacs fixnum overflow, and relied
4032 on undefined (wraparound) behavior. The new code avoids undefined
4033 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4034
4035 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4036 Tune. Don't use wider integers than needed. Don't use alloca.
4037 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4038
4039 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4040
4041 * insdel.c, lisp.h (buffer_overflow): New function.
4042 (insert_from_buffer_1, replace_range, replace_range_2):
4043 * insdel.c (make_gap_larger):
4044 * editfns.c (Finsert_char):
4045 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4046
4047 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4048
40492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4050
4051 Integer overflow and signedness fixes (Bug#8873).
4052
4053 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4054 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4055
4056 * fileio.c: Don't assume EMACS_INT fits in off_t.
4057 (emacs_lseek): New static function.
4058 (Finsert_file_contents, Fwrite_region): Use it.
4059 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4060
4061 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4062
4063 * fns.c: Don't overflow int when computing a list length.
4064 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4065 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4066 truncation on 64-bit hosts. Check for QUIT every
4067 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4068 faster and is responsive enough.
4069 (Flength): Report an error instead of overflowing an integer.
4070 (Fsafe_length): Return a float if the value is not representable
4071 as a fixnum. This shouldn't happen except in contrived situations.
4072 (Fnthcdr, Fsort): Don't assume list length fits in int.
4073 (Fcopy_sequence): Don't assume vector length fits in int.
4074
4075 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4076 (header_size, word_size): New constants.
4077 (allocate_vectorlike): Don't check size overflow here.
4078 (allocate_vector): Check it here instead, since this is the only
4079 caller of allocate_vectorlike that could cause overflow.
4080 Check that the new vector's length is representable as a fixnum.
4081
4082 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4083 The previous code was bogus. For example, next_almost_prime (32)
4084 returned 39, which is undesirable as it is a multiple of 3; and
4085 next_almost_prime (24) returned 25, which is a multiple of 5 so
4086 why was the code bothering to check for multiples of 7?
4087
4088 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4089
4090 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4091
4092 Variadic C functions now count arguments with ptrdiff_t.
4093 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4094 Back then I didn't know that the Emacs coding style prefers signed int.
4095 Also, in the meantime I found a few more instances where arguments
4096 were being counted with int, which may truncate counts on 64-bit
4097 machines, or EMACS_INT, which may be unnecessarily wide.
4098 * lisp.h (struct Lisp_Subr.function.aMANY)
4099 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4100 Arg counts are now ptrdiff_t, not size_t.
4101 All variadic functions and their callers changed accordingly.
4102 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4103 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4104 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4105 * callint.c (Fcall_interactively): Check arg count for overflow,
4106 to avoid potential buffer overrun. Use signed char, not 'int',
4107 for 'varies' array, so that we needn't bother to check its size
4108 calculation for overflow.
4109 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4110 * eval.c (apply_lambda):
4111 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4112 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4113 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4114
4115 * callint.c (Fcall_interactively): Don't use index var as event count.
4116
4117 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4118 * mem-limits.h (SIZE): Remove; no longer used.
4119
4120 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4121
4122 Remove unnecessary casts.
4123 * xterm.c (x_term_init):
4124 * xfns.c (x_set_border_pixel):
4125 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4126 These aren't needed now that we assume ANSI C.
4127
4128 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4129 It's more likely to cause problems (due to unsigned overflow)
4130 than to cure them.
4131
4132 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4133
4134 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4135
4136 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4137
4138 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4139
4140 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4141
4142 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4143
4144 GLYPH_CODE_FACE returns EMACS_INT, not int.
4145 * dispextern.h (merge_faces):
4146 * xfaces.c (merge_faces):
4147 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4148 Don't assume EMACS_INT fits in int.
4149
4150 * character.h (CHAR_VALID_P): Remove unused parameter.
4151 * fontset.c, lisp.h, xdisp.c: All uses changed.
4152
4153 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4154
4155 * fns.c (concat): Minor tuning based on overflow analysis.
4156 This doesn't fix any bugs. Use int to hold character, instead
4157 of constantly refetching from Emacs object. Use XFASTINT, not
4158 XINT, for value known to be a character. Don't bother comparing
4159 a single byte to 0400, as it's always less.
4160
4161 * floatfns.c (Fexpt):
4162 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4163
4164 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4165 for characters.
4166
4167 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4168
4169 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4170 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4171 incorrectly succeed when S was a string, because 4294967386 was
4172 truncated before it was used.
4173
4174 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4175 Otherwise, an out-of-range integer could cause undefined behavior
4176 on a 64-bit host.
4177
4178 * composite.c: Use int, not EMACS_INT, for characters.
4179 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4180 EMACS_INT, for values that are known to be in character range.
4181 This doesn't fix any bugs but is the usual style inside Emacs and
4182 may generate better code on 32-bit machines.
4183
4184 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4185 This is for reasons similar to the recent CHAR_STRING fix.
4186 * charset.c (Fencode_char): Check that character arg is actually
4187 a character. Pass an int to ENCODE_CHAR.
4188 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4189 wider than 'int', as a compile-time check to prevent future regressions
4190 in this area.
4191
4192 * character.c (char_string): Remove unnecessary casts.
4193
4194 Make sure a 64-bit char is never passed to CHAR_STRING.
4195 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4196 by silently ignoring the top 32 bits, allowing some values
4197 that were far too large to be valid characters.
4198 * character.h: Include <verify.h>.
4199 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4200 arguments are no wider than unsigned, as a compile-time check
4201 to prevent future regressions in this area.
4202 * data.c (Faset):
4203 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4204 (Fsubst_char_in_region):
4205 * fns.c (concat):
4206 * xdisp.c (decode_mode_spec_coding):
4207 Adjust to CHAR_STRING's new requirement.
4208 * editfns.c (Finsert_char, Fsubst_char_in_region):
4209 * fns.c (concat): Check that character args are actually
4210 characters. Without this test, these functions did the wrong
4211 thing with wildly out-of-range values on 64-bit hosts.
4212
4213 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4214 These casts should not be needed on 32-bit hosts, either.
4215 * keyboard.c (read_char):
4216 * lread.c (Fload): Remove casts to unsigned.
4217
4218 * lisp.h (UNSIGNED_CMP): New macro.
4219 This fixes comparison bugs on 64-bit hosts.
4220 (ASCII_CHAR_P): Use it.
4221 * casefiddle.c (casify_object):
4222 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4223 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4224 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4225 * dispextern.h (FACE_FROM_ID):
4226 * keyboard.c (read_char): Use UNSIGNED_CMP.
4227
4228 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4229 not to EMACS_INT, to avoid GCC warning.
4230
4231 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4232
4233 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4234 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4235 isn't needed on 32-bit machines.
4236
4237 * buffer.c (Fgenerate_new_buffer_name):
4238 Use EMACS_INT for count, not int.
4239 (advance_to_char_boundary): Return EMACS_INT, not int.
4240
4241 * data.c (Qcompiled_function): Now static.
4242
4243 * window.c (window_body_lines): Now static.
4244
4245 * image.c (gif_load): Rename local to avoid shadowing.
4246
4247 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4248 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4249 * alloc.c (make_save_value): Integer argument is now of type
4250 ptrdiff_t, not int.
4251 (mark_object): Use ptrdiff_t, not int.
4252 * lisp.h (pD): New macro.
4253 * print.c (print_object): Use it.
4254
4255 * alloc.c: Use EMACS_INT, not int, to count objects.
4256 (total_conses, total_markers, total_symbols, total_vector_size)
4257 (total_free_conses, total_free_markers, total_free_symbols)
4258 (total_free_floats, total_floats, total_free_intervals)
4259 (total_intervals, total_strings, total_free_strings):
4260 Now EMACS_INT, not int. All uses changed.
4261 (Fgarbage_collect): Compute overall total using a double, so that
4262 integer overflow is less likely to be a problem. Check for overflow
4263 when converting back to an integer.
4264 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4265 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4266 These were 'int' variables that could overflow on 64-bit hosts;
4267 they were never used, so remove them instead of repairing them.
4268 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4269 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4270 Previously, this ceilinged at INT_MAX, but that doesn't work on
4271 64-bit machines.
4272 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4273
4274 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4275 (allocate_vectorlike): Check for ptrdiff_t overflow.
4276 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4277 when a (possibly-narrower) signed value would do just as well.
4278 We prefer using signed arithmetic, to avoid comparison confusion.
4279
4280 * alloc.c: Catch some string size overflows that we were missing.
4281 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4282 for convenience in STRING_BYTES_MAX.
4283 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4284 The definition here is exact; the one in lisp.h was approximate.
4285 (allocate_string_data): Check for string overflow. This catches
4286 some instances we weren't catching before. Also, it catches
4287 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4288 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4289 and ptrdiff_t and EMACS_INT are both 64 bits.
4290
4291 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4292 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4293 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4294
4295 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4296
4297 * alloc.c (Fmake_string): Check for out-of-range init.
4298
42992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4300
4301 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4302
43032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4304
4305 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4306 xg_get_default_scrollbar_width.
4307
4308 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4309 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4310 (style_changed_cb): Call update_theme_scrollbar_width and call
4311 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4312 all frames (Bug#8505).
4313 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4314 Call gtk_window_set_resizable if HAVE_GTK3.
4315 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4316 and height if HAVE_GTK3 (Bug#8505).
4317 (scroll_bar_width_for_theme): New variable.
4318 (update_theme_scrollbar_width): New function.
4319 (xg_get_default_scrollbar_width): Move code to
4320 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4321 (xg_initialize): Call update_theme_scrollbar_width.
4322
4323 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4324
4325 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4326
43272011-06-12 Martin Rudalics <rudalics@gmx.at>
4328
4329 * frame.c (make_frame): Call other_buffer_safely instead of
4330 other_buffer.
4331
4332 * window.c (temp_output_buffer_show): Call display_buffer with
4333 second argument Vtemp_buffer_show_specifiers and reset latter
4334 immediately after the call.
4335 (Vtemp_buffer_show_specifiers): New variable.
4336 (auto_window_vscroll_p, next_screen_context_lines)
4337 (Vscroll_preserve_screen_position): Remove leading asterisks from
4338 doc-strings.
4339
43402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4341
4342 Fix minor problems found by GCC 4.6.0 static checking.
4343 * buffer.c (Qclone_number): Remove for now, as it's unused.
4344 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4345 (record_buffer): Remove unused local.
4346 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4347 (set_frame_buffer_list): Remove; unused.
4348 * frame.h (other_visible_frames): Remove decl.
4349 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4350 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4351 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4352 if HAVE_GPM.
4353 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4354 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4355 Define only if HAVE_GPM.
4356 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4357 (update_hints_inhibit): Remove; never set. All uses removed.
4358 * widgetprv.h (emacsFrameClassRec): Remove decl.
4359 * window.c (delete_deletable_window): Now returns void, since it
4360 wasn't returning anything.
4361 (compare_window_configurations): Remove unused locals.
4362 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4363 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4364 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4365 the same widths as pointers. This follows up on the 2011-05-06 patch.
4366 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4367 * xterm.h: Likewise.
4368 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4369
43702011-06-12 Juanma Barranquero <lekktu@gmail.com>
4371
4372 * makefile.w32-in: Update dependencies.
4373 (LISP_H): Add lib/intprops.h.
4374
43752011-06-11 Chong Yidong <cyd@stupidchicken.com>
4376
4377 * image.c (gif_load): Add animation frame delay to the metadata.
4378 (syms_of_image): Use DEFSYM. New symbol `delay'.
4379
43802011-06-11 Martin Rudalics <rudalics@gmx.at>
4381
4382 * window.c (delete_deletable_window): Re-add.
4383 (Fset_window_configuration): Rewrite to handle dead buffers and
4384 consequently deletable windows.
4385 (window_tree, Fwindow_tree): Remove. Supply functionality in
4386 window.el.
4387 (compare_window_configurations): Simplify code.
4388
43892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4390
4391 * image.c (imagemagick_load_image): Fix type mismatch.
4392 (Fimagemagick_types): Likewise.
4393
4394 * window.h (replace_buffer_in_windows): Declare.
4395
43962011-06-11 Martin Rudalics <rudalics@gmx.at>
4397
4398 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4399 Qclone_number. Remove external declaration of Qdelete_window.
4400 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4401 code.
4402 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4403 Run Qbuffer_list_update_hook if allowed.
4404 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4405 buffer list implementation.
4406 (other_buffer_safely): New function.
4407 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4408 calls to replace_buffer_in_windows and
4409 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4410 if allowed.
4411 (record_buffer): Inhibit quitting and rewrite using quittable
4412 functions. Run Qbuffer_list_update_hook if allowed.
4413 (Frecord_buffer, Funrecord_buffer): New functions.
4414 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4415 Move switch-to-buffer to window.el.
4416 (bury-buffer): Move to window.el.
4417 (Vbuffer_list_update_hook): New variable.
4418
4419 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4420 section.
4421
4422 * window.h (resize_frame_windows): Move up in code.
4423 (Fwindow_frame): Remove EXFUN.
4424 (replace_buffer_in_all_windows): Remove prototype.
4425 (replace_buffer_in_windows_safely): Add prototype.
4426
4427 * window.c: Declare Qdelete_window static again. Move down
4428 declaration of select_count.
4429 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4430 (Fother_window): Move to window.el.
4431 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4432 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4433 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4434 window.el.
4435 (replace_buffer_in_windows): Implement by calling
4436 Qreplace_buffer_in_windows.
4437 (replace_buffer_in_all_windows): Remove with some functionality
4438 moved into replace_buffer_in_windows_safely.
4439 (replace_buffer_in_windows_safely): New function.
4440 (select_window_norecord, select_frame_norecord): Move in front
4441 of run_window_configuration_change_hook. Remove now obsolete
4442 declarations.
4443 (Fset_window_buffer): Rewrite doc-string.
4444 Call Qrecord_window_buffer.
4445 (keys_of_window): Move binding for other-window to window.el.
4446
44472011-06-11 Chong Yidong <cyd@stupidchicken.com>
4448
4449 * dispextern.h (struct image): Replace data member, whose int_val
4450 and ptr_val fields were not used by anything, with a single
4451 lisp_val object.
4452
4453 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4454 (gif_clear_image, gif_load, imagemagick_load_image)
4455 (gs_clear_image, gs_load): Callers changed.
4456
44572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4458
4459 * buffer.h: Include <time.h>, for time_t.
4460 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4461
4462 Fix minor problems found by static checking.
4463
4464 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4465
4466 Make identifiers static if they are not used in other modules.
4467 * data.c (Qcompiled_function, Qframe, Qvector):
4468 * image.c (QimageMagick, Qsvg):
4469 * minibuf.c (Qmetadata):
4470 * window.c (resize_window_check, resize_root_window): Now static.
4471 * window.h (resize_window_check, resize_root_window): Remove decls.
4472
4473 * window.c (window_deletion_count, delete_deletable_window):
4474 Remove; unused.
4475 (window_body_lines): Now static.
4476 (Fdelete_other_windows_internal): Mark vars as initialized.
4477 Make sure 'resize_failed' is initialized.
4478 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4479 (resize_window_apply): Remove unused local.
4480 * window.h (delete_deletable_window): Remove decl.
4481
4482 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4483 (imagemagick_load_image): Fix pointer signedness problem by changing
4484 last arg from unsigned char * to char *. All uses changed.
4485 Also, fix a local for similar reasons.
4486 Remove unused locals. Remove locals to avoid shadowing.
4487 (fn_rsvg_handle_free): Remove; unused.
4488 (svg_load, svg_load_image): Fix pointer signedness problem.
4489 (imagemagick_load_image): Don't use garbage pointer image_wand.
4490
4491 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4492
44932011-06-10 Chong Yidong <cyd@stupidchicken.com>
4494
4495 * image.c (gif_load): Fix omitted cast error introduced by
4496 2011-06-06 change.
4497
44982011-06-10 Martin Rudalics <rudalics@gmx.at>
4499
4500 * window.h (resize_proportionally, orig_total_lines)
4501 (orig_top_line): Remove from window structure.
4502 (set_window_height, set_window_width, change_window_heights)
4503 (Fdelete_window): Remove prototypes.
4504 (resize_frame_windows): Remove duplicate declaration.
4505
45062011-06-10 Eli Zaretskii <eliz@gnu.org>
4507
4508 * window.h (resize_frame_windows, resize_window_check)
4509 (delete_deletable_window, resize_root_window)
4510 (resize_frame_windows): Declare prototypes.
4511
4512 * window.c (resize_window_apply): Make definition be "static" to
4513 match the prototype.
4514
45152011-06-10 Martin Rudalics <rudalics@gmx.at>
4516
4517 * window.c: Remove declarations of Qwindow_size_fixed,
4518 window_min_size_1, window_min_size_2, window_min_size,
4519 size_window, window_fixed_size_p, enlarge_window, delete_window.
4520 Remove static from declaration of Qdelete_window, it's
4521 temporarily needed by Fbury_buffer.
4522 (replace_window): Don't assign orig_top_line and
4523 orig_total_lines.
4524 (Fdelete_window, delete_window): Remove. Window deletion is
4525 handled by window.el.
4526 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4527 Replace Fdelete_window calls with calls to Qdelete_window.
4528 (Fdelete_other_windows): Remove. Deleting other windows is
4529 handled by window.el.
4530 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4531 handled in window.el.
4532 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4533 Window minimum sizes are handled in window.el.
4534 (shrink_windows, size_window, set_window_height)
4535 (set_window_width, change_window_heights, window_height)
4536 (window_width, CURBEG, CURSIZE, enlarge_window)
4537 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4538 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4539 handled in window.el.
4540 (make_dummy_parent): Rename to make_parent_window and give it a
4541 second argument horflag.
4542 (make_window): Don't set resize_proportionally any more.
4543 (Fsplit_window): Remove. Windows are split in window.el.
4544 (save_restore_action, save_restore_orig_size)
4545 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4546 Resize mini windows in window.el.
4547 (grow_mini_window, shrink_mini_window): Implement by calling
4548 Qresize_root_window_vertically, resize_window_check and
4549 resize_window_apply.
4550 (saved_window, Fset_window_configuration, save_window_save):
4551 Do not handle orig_top_line, orig_total_lines, and
4552 resize_proportionally.
4553 (window_min_height, window_min_width): Move to window.el.
4554 (keys_of_window): Move bindings for delete-other-windows,
4555 split-window, delete-window and enlarge-window to window.el.
4556
4557 * buffer.c: Temporarily extern Qdelete_window.
4558 (Fbury_buffer): Temporarily call Qdelete_window instead of
4559 Fdelete_window (Fbury_buffer will move to window.el soon).
4560
4561 * frame.c (set_menu_bar_lines_1): Remove code handling
4562 orig_top_line and orig_total_lines.
4563
4564 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4565 set_window_height but set heights directly.
4566 (change_frame_size_1): Use resize_frame_windows.
4567
4568 * xdisp.c (init_xdisp): Don't use set_window_height but set
4569 heights directly.
4570
4571 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4572 Use resize_frame_windows instead of change_window_heights and run
4573 run_window_configuration_change_hook.
4574
4575 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4576 instead of change_window_heights and run
4577 run_window_configuration_change_hook.
4578
45792011-06-09 Martin Rudalics <rudalics@gmx.at>
4580
4581 * window.c (replace_window): Rename second argument REPLACEMENT to
4582 NEW. New third argument SETFLAG. Rewrite.
4583 (delete_window, make_dummy_parent): Call replace_window with
4584 third argument 1.
4585 (window_list_1): Move down in code.
4586 (run_window_configuration_change_hook): Move set_buffer part
4587 before select_frame_norecord part in order to unwind correctly.
4588 Rename count1 to count.
4589 (recombine_windows, delete_deletable_window, resize_root_window)
4590 (Fdelete_other_windows_internal)
4591 (Frun_window_configuration_change_hook, make_parent_window)
4592 (resize_window_check, resize_window_apply, Fresize_window_apply)
4593 (resize_frame_windows, Fsplit_window_internal)
4594 (Fdelete_window_internal, Fresize_mini_window_internal):
4595 New functions.
4596 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4597
45982011-06-08 Martin Rudalics <rudalics@gmx.at>
4599
4600 * window.h (window): Add some new members to window structure -
4601 normal_lines, normal_cols, new_total, new_normal, clone_number,
4602 splits, nest, prev_buffers, next_buffers.
4603 (WINDOW_TOTAL_SIZE): Move here from window.c.
4604 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4605
4606 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4607 Remove.
4608 (make_dummy_parent): Set new members of windows structure.
4609 (make_window): Move down in code. Handle new members of window
4610 structure.
4611 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4612 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4613 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4614 (Fset_window_prev_buffers, Fwindow_next_buffers)
4615 (Fset_window_next_buffers, Fset_window_clone_number):
4616 New functions.
4617 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4618 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4619 Doc-string fixes.
4620 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4621 Argument WINDOW can be now internal window too.
4622 (Fwindow_use_time): Move up in code.
4623 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4624 Rewrite doc-string.
4625 (Fset_window_configuration, saved_window)
4626 (Fcurrent_window_configuration, save_window_save): Handle new
4627 members of window structure.
4628 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4629 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4630 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4631 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4632 Qget_mru_window, Qresize_root_window,
4633 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4634 Qauto_buffer_name; staticpro them.
4635
46362011-06-07 Martin Rudalics <rudalics@gmx.at>
4637
4638 * window.c (Fwindow_total_size, Fwindow_left_column)
4639 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4640 (Fwindow_list_1): New functions.
4641 (window_box_text_cols): Replace with window_body_cols.
4642 (Fwindow_width, Fscroll_left, Fscroll_right):
4643 Use window_body_cols instead of window_box_text_cols.
4644 (delete_window, Fset_window_configuration):
4645 Call delete_all_subwindows with window as argument.
4646 (delete_all_subwindows): Take a window as argument and not a
4647 structure. Rewrite.
4648 (window_loop): Remove handling of GET_LRU_WINDOW and
4649 GET_LARGEST_WINDOW.
4650 (Fget_lru_window, Fget_largest_window): Move to window.el.
4651
4652 * window.h: Extern window_body_cols instead of
4653 window_box_text_cols. delete_all_subwindows now takes a
4654 Lisp_Object as argument.
4655
4656 * indent.c (compute_motion, Fcompute_motion):
4657 Use window_body_cols instead of window_box_text_cols.
4658
4659 * frame.c (delete_frame): Call delete_all_subwindows with root
4660 window as argument.
4661
46622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4663
4664 * fns.c (Fputhash): Document return value.
4665
46662011-06-06 Chong Yidong <cyd@stupidchicken.com>
4667
4668 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4669
46702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4671
4672 Cons<->int and similar integer overflow fixes (Bug#8794).
4673
4674 Check for overflow when converting integer to cons and back.
4675 * charset.c (Fdefine_charset_internal, Fdecode_char):
4676 Use cons_to_unsigned to catch overflow.
4677 (Fencode_char): Use INTEGER_TO_CONS.
4678 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4679 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4680 * data.c (long_to_cons, cons_to_long): Remove.
4681 (cons_to_unsigned, cons_to_signed): New functions.
4682 These signal an error for invalid or out-of-range values.
4683 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4684 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4685 * font.c (Ffont_variation_glyphs):
4686 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4687 * lisp.h: Include <intprops.h>.
4688 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4689 (cons_to_signed, cons_to_unsigned): New decls.
4690 (long_to_cons, cons_to_long): Remove decls.
4691 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4692 (Fprimitive_undo): Use CONS_TO_INTEGER.
4693 * xfns.c (Fx_window_property): Likewise.
4694 * xselect.c: Include <limits.h>.
4695 (x_own_selection, selection_data_to_lisp_data):
4696 Use INTEGER_TO_CONS.
4697 (x_handle_selection_request, x_handle_selection_clear)
4698 (x_get_foreign_selection, Fx_disown_selection_internal)
4699 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4700 (lisp_data_to_selection_data): Use cons_to_unsigned.
4701 (x_fill_property_data): Use cons_to_signed.
4702 Report values out of range.
4703
4704 Check for buffer and string overflow more precisely.
4705 * buffer.h (BUF_BYTES_MAX): New macro.
4706 * lisp.h (STRING_BYTES_MAX): New macro.
4707 * alloc.c (Fmake_string):
4708 * character.c (string_escape_byte8):
4709 * coding.c (coding_alloc_by_realloc):
4710 * doprnt.c (doprnt):
4711 * editfns.c (Fformat):
4712 * eval.c (verror):
4713 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4714 since they may not be the same number.
4715 * editfns.c (Finsert_char):
4716 * fileio.c (Finsert_file_contents):
4717 Likewise for BUF_BYTES_MAX.
4718
4719 * image.c: Use ptrdiff_t, not int, for sizes.
4720 (slurp_file): Switch from int to ptrdiff_t.
4721 All uses changed.
4722 (slurp_file): Check that file size fits in both size_t (for
4723 malloc) and ptrdiff_t (for sanity and safety).
4724
4725 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4726 if b->modtime has its maximal value.
4727
4728 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4729
4730 Don't assume time_t can fit into int.
4731 * buffer.h (struct buffer.modtime): Now time_t, not int.
4732 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4733 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4734
4735 Minor fixes for signed vs unsigned integers.
4736 * character.h (MAYBE_UNIFY_CHAR):
4737 * charset.c (maybe_unify_char):
4738 * keyboard.c (read_char, reorder_modifiers):
4739 XINT -> XFASTINT, since the integer must be nonnegative.
4740 * ftfont.c (ftfont_spec_pattern):
4741 * keymap.c (access_keymap, silly_event_symbol_error):
4742 XUINT -> XFASTINT, since the integer must be nonnegative.
4743 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4744 since it makes no difference and we prefer signed.
4745 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4746 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4747 nonnegative.
4748
47492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4750
4751 * window.h (Fwindow_frame): Declare.
4752
47532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4754
4755 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4756 (SPARE_MEMORY): Always define.
4757 (LARGE_REQUEST): Remove.
4758 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4759
47602011-06-06 Martin Rudalics <rudalics@gmx.at>
4761
4762 * lisp.h: Move EXFUNS for Fframe_root_window,
4763 Fframe_first_window and Fset_frame_selected_window to window.h.
4764
4765 * window.h: Move EXFUNS for Fframe_root_window,
4766 Fframe_first_window and Fset_frame_selected_window here from
4767 lisp.h.
4768
4769 * frame.c (Fwindow_frame, Fframe_first_window)
4770 (Fframe_root_window, Fframe_selected_window)
4771 (Fset_frame_selected_window): Move to window.c.
4772 (Factive_minibuffer_window): Move to minibuf.c.
4773 (Fother_visible_frames_p): New function.
4774
4775 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4776
4777 * window.c (decode_window, decode_any_window): Move up in code.
4778 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4779 (inhibit_frame_unsplittable): Remove unused variable.
4780 (Fwindow_buffer): Move up and rewrite doc-string.
4781 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4782 (Fwindow_prev): New functions.
4783 (Fwindow_frame): Move here from frame.c. Accept any window as
4784 argument.
4785 (Fframe_root_window, Fframe_first_window)
4786 (Fframe_selected_window): Move here from frame.c. Accept frame
4787 or arbitrary window as argument. Update doc-strings.
4788 (Fminibuffer_window): Move up in code.
4789 (Fwindow_minibuffer_p): Move up in code and simplify.
4790 (Fset_frame_selected_window): Move here from frame.c.
4791 Marginal rewrite.
4792 (Fselected_window, select_window, Fselect_window): Move up in
4793 code. Minor doc-string fixes.
4794
47952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4796
4797 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4798 Do not assume that spare memory exists; that assumption is valid
4799 only if SYSTEM_MALLOC.
4800 (LARGE_REQUEST): New macro, so that the issue of large requests
4801 is separated from the issue of spare memory.
4802
48032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4804
4805 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4806 format. (Bug#8806)
4807
4808 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4809
4810 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4811 before statements.
4812
48132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4814
4815 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4816
4817 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4818
4819 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4820 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4821
48222011-06-05 Juanma Barranquero <lekktu@gmail.com>
4823
4824 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4825
48262011-06-04 Chong Yidong <cyd@stupidchicken.com>
4827
4828 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4829 (x_clipboard_manager_save): Add return value.
4830 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4831 New error handlers.
4832 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4833 Obey Vx_select_enable_clipboard_manager. Catch errors in
4834 x_clipboard_manager_save (Bug#8779).
4835 (Vx_select_enable_clipboard_manager): New variable.
4836 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4837
48382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4839
4840 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4841
48422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4843
4844 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4845 in the current matrix if keep_current_p is non-zero.
4846
48472011-06-04 Eli Zaretskii <eliz@gnu.org>
4848
4849 * bidi.c (bidi_level_of_next_char): Fix last change.
4850
48512011-06-03 Eli Zaretskii <eliz@gnu.org>
4852
4853 Support bidi reordering of text covered by display properties.
4854
4855 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4856 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4857 (bidi_cache_search, bidi_cache_iterator_state)
4858 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4859 (bidi_level_of_next_char, bidi_move_to_visually_next):
4860 Support character positions inside a run of characters covered by a
4861 display string.
4862 (bidi_paragraph_init, bidi_resolve_explicit_1)
4863 (bidi_level_of_next_char): Call bidi_fetch_char and
4864 bidi_fetch_char_advance instead of FETCH_CHAR and
4865 FETCH_CHAR_ADVANCE.
4866 (bidi_init_it): Initialize new members.
4867 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4868 definitions.
4869 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4870 instead of using explicit *_CHAR codes.
4871 (bidi_resolve_explicit, bidi_resolve_weak):
4872 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4873 bidirectional text is supported only in multibyte buffers.
4874 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4875 it to initialize the frame_window_p member of struct bidi_it.
4876 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4877 (bidi_resolve_explicit, bidi_resolve_weak)
4878 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4879 bidi_it->nchars is non-positive.
4880 (bidi_level_of_next_char): Don't try to lookup the cache for the
4881 next/previous character if nothing is cached there yet, or if we
4882 were just reseat()'ed to a new position.
4883
4884 * xdisp.c (set_cursor_from_row): Set start and stop points
4885 according to the row's direction when priming the loop that looks
4886 for the glyph on which to display cursor.
4887 (single_display_spec_intangible_p): Function deleted.
4888 (display_prop_intangible_p): Reimplement to call
4889 handle_display_spec instead of single_display_spec_intangible_p.
4890 Accept 3 additional arguments needed by handle_display_spec.
4891 This fixes incorrect cursor motion across display property with complex
4892 values: lists, `(when COND...)' forms, etc.
4893 (single_display_spec_string_p): Support property values that are
4894 lists with the argument STRING its top-level element.
4895 (display_prop_string_p): Fix the condition for processing a
4896 property that is a list to be consistent with handle_display_spec.
4897 (handle_display_spec): New function, refactored from the
4898 last portion of handle_display_prop.
4899 (compute_display_string_pos): Accept additional argument
4900 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4901 value of a `display' property is a "replacing spec".
4902 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4903 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4904 the display property, but just return a value indicating whether
4905 the display property will replace the characters it covers.
4906 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4907 frame_window_p members of struct bidi_it.
4908 (compute_display_string_pos, compute_display_string_end):
4909 New functions.
4910 (push_it): Accept second argument POSITION, where pop_it should
4911 jump to continue iteration.
4912 (reseat_1): Initialize bidi_it.disp_pos.
4913
4914 * keyboard.c (adjust_point_for_property): Adjust the call to
4915 display_prop_intangible_p to its new signature.
4916
4917 * dispextern.h (struct bidi_it): New member frame_window_p.
4918 (bidi_init_it): Update prototypes.
4919 (display_prop_intangible_p): Update prototype.
4920 (compute_display_string_pos, compute_display_string_end):
4921 Declare prototypes.
4922 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4923 EMACS_INT.
4924
49252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4926
4927 Malloc failure behavior now depends on size of allocation.
4928 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4929 * lisp.h: Change signatures accordingly.
4930 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4931 All callers changed. (Bug#8762)
4932
4933 * gnutls.c: Use Emacs's memory allocators.
4934 Without this change, the gnutls library would invoke malloc etc.
4935 directly, which causes problems on non-SYNC_INPUT hosts, and which
4936 runs afoul of improving memory_full behavior. (Bug#8761)
4937 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4938 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4939 xfree instead of the default malloc, realloc, free.
4940 (Fgnutls_boot): No need to check for memory allocation failure,
4941 since xmalloc does that for us.
4942
4943 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4944 * category.c (hash_get_category_set):
4945 * ccl.c (ccl_driver):
4946 * charset.c (Fdefine_charset_internal):
4947 * charset.h (struct charset.hash_index):
4948 * composite.c (get_composition_id, gstring_lookup_cache)
4949 (composition_gstring_put_cache):
4950 * composite.h (struct composition.hash_index):
4951 * dispextern.h (struct image.hash):
4952 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4953 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4954 (hashfn_equal, hashfn_user_defined, make_hash_table)
4955 (maybe_resize_hash_table, hash_lookup, hash_put)
4956 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4957 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4958 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4959 * image.c (make_image, search_image_cache, lookup_image)
4960 (xpm_put_color_table_h):
4961 * lisp.h (struct Lisp_Hash_Table):
4962 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4963 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4964 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4965 * alloc.c (allocate_vectorlike):
4966 Check for overflow in vector size calculations.
4967 * ccl.c (ccl_driver):
4968 Check for overflow when converting EMACS_INT to int.
4969 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4970 need to be updated by these changes.
4971 * fns.c (make_hash_table, maybe_resize_hash_table):
4972 Check for integer overflow with large hash tables.
4973 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4974 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4975 (SXHASH_REDUCE): New macro.
4976 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4977 Use it instead of discarding useful hash info with large hash values.
4978 (sxhash_float): New function.
4979 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4980 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4981 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4982 Rewrite to use FIXNUM_BITS, as this simplifies things.
4983 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4984 Adjust signatures to match updated version of code.
4985 (consing_since_gc): Now EMACS_INT, since a single hash table can
4986 use more than INT_MAX bytes.
4987
49882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4989
4990 Make it possible to build with GCC-4.6+ -O2 -flto.
4991
4992 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4993
49942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4995
4996 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4997 Call minibuffer-inactive-mode.
4998
49992011-05-31 Juanma Barranquero <lekktu@gmail.com>
5000
5001 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5002 Update dependencies.
5003
50042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5005
5006 * data.c (init_data): Remove code for UTS, this system is not
5007 supported anymore.
5008
50092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5010
5011 Don't force ./temacs to start in terminal mode.
5012
5013 * frame.c (make_initial_frame): Initialize faces in all cases, not
5014 only when CANNOT_DUMP is defined.
5015 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5016
50172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5018
5019 * dispnew.c (add_window_display_history): Use const for the string
5020 pointer. Remove declaration, not needed.
5021
50222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5023
5024 Use 'inline', not 'INLINE'.
5025 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5026 * alloc.c, fontset.c (INLINE): Remove.
5027 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5028 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5029 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5030 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5031 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5032
50332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5034
5035 Make it possible to run ./temacs.
5036
5037 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5038 syms_of_callproc does the same thing. Remove test for
5039 "initialized", do it in the caller.
5040 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5041
50422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5043
5044 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5045 (read_minibuf): Use get_minibuffer.
5046 (syms_of_minibuf): Use DEFSYM.
5047 (Qmetadata): New var.
5048 * data.c (Qbuffer): Don't make it static.
5049 (syms_of_data): Use DEFSYM.
5050
50512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5052
5053 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5054 (CCL_CODE_MIN): New macro.
5055
50562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5057
5058 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5059
5060 * eval.c (Qdebug): Now static.
5061 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5062 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5063 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5064
50652011-05-29 Chong Yidong <cyd@stupidchicken.com>
5066
5067 * image.c: Various fixes to ImageMagick code comments.
5068 (Fimagemagick_types): Doc fix.
5069
50702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5071
5072 Minor fixes prompted by GCC 4.6.0 warnings.
5073
5074 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5075
5076 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5077 (x_clipboard_manager_save_all): Move extern decl to ...
5078 * xterm.h: ... here, so that it can be checked for consistency.
5079
50802011-05-29 Chong Yidong <cyd@stupidchicken.com>
5081
5082 * xselect.c (x_clipboard_manager_save_frame)
5083 (x_clipboard_manager_save_all): New functions.
5084 (Fx_clipboard_manager_save): Lisp function deleted.
5085
5086 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5087 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5088
5089 * xterm.h: Update prototype.
5090
50912011-05-28 William Xu <william.xwl@gmail.com>
5092
5093 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5094 exiting (Bug#8239).
5095
50962011-05-28 Jim Meyering <meyering@redhat.com>
5097
5098 Avoid a sign-extension bug in crypto_hash_function.
5099 * fns.c (to_uchar): Define.
5100 (crypto_hash_function): Use it to convert some newly-signed
5101 variables to unsigned, to avoid sign-extension bugs. For example,
5102 without this change, (md5 "truc") would evaluate to
5103 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5104 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5105 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5106
51072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5108
5109 Integer overflow fixes.
5110
5111 * dbusbind.c: Serial number integer overflow fixes.
5112 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5113 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5114 to hold a serial number that is too large for a fixnum.
5115 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5116 Check for serial numbers out of range. Decode any serial number
5117 that was so large that it became a float. (Bug#8722)
5118
5119 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5120 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5121 Use XFASTINT rather than XUINT when numbers are nonnegative.
5122 (xd_append_arg, Fdbus_method_return_internal):
5123 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5124 arguments, check that Lisp number is nonnegative, rather than
5125 silently wrapping negative numbers around. (Bug#8722)
5126 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5127 (Bug#8722)
5128
5129 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5130
5131 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5132
5133 ccl: add integer overflow checks
5134 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5135 (IN_INT_RANGE): New macros.
5136 (ccl_driver): Use them to check for integer overflow when
5137 decoding a CCL program. Many of the new checks are whether XINT (x)
5138 fits in int; it doesn't always, on 64-bit hosts. The new version
5139 doesn't catch all possible integer overflows, but it's an
5140 improvement. (Bug#8719)
5141
5142 * alloc.c (make_event_array): Use XINT, not XUINT.
5143 There's no need for unsigned here.
5144
5145 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5146 This follows up to the 2011-05-06 change that substituted uintptr_t
5147 for EMACS_INT. This case wasn't caught back then.
5148
5149 Rework Fformat to avoid integer overflow issues.
5150 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5151 now (part of C89). Include <verify.h>.
5152 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5153 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5154 (Fformat): Avoid the prepass trying to compute sizes; it was only
5155 approximate and thus did not catch overflow reliably. Instead, walk
5156 through the format just once, formatting and computing sizes as we go,
5157 checking for integer overflow at every step, and allocating a larger
5158 buffer as needed. Keep track separately whether the format is
5159 multibyte. Keep only the most-recently calculated precision, rather
5160 than them all. Record whether each argument has been converted to
5161 string. Use EMACS_INT, not int, for byte and char and arg counts.
5162 Support field widths and precisions larger than INT_MAX. Avoid
5163 sprintf's undefined behavior with conversion specifications such as %#d
5164 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5165 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5166 formatting out-of-range floating point numbers with int
5167 formats. (Bug#8668)
5168
5169 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5170
5171 * data.c: Avoid integer truncation in expressions involving floats.
5172 * data.c: Include <intprops.h>.
5173 (arith_driver): When there's an integer overflow in an expression
5174 involving floating point, convert the integers to floating point
5175 so that the resulting value does not suffer from catastrophic
5176 integer truncation. For example, on a 64-bit host (* 4
5177 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5178 Do not rely on undefined behavior after integer overflow.
5179
5180 merge count_size_as_multibyte, parse_str_to_multibyte
5181 * character.c, character.h (count_size_as_multibyte):
5182 Rename from parse_str_to_multibyte; all uses changed.
5183 Check for integer overflow.
5184 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5185 since it's now a duplicate of the other. This is more of
5186 a character than a buffer op, so better that it's in character.c.
5187 * fns.c, print.c: Adjust to above changes.
5188
51892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5190
5191 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5192
51932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5194
5195 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5196 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5197 (x_clipboard_manager_save): Now static.
5198 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5199
5200 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5201 (crypto_hash_function): Now static.
5202 Fix pointer signedness problems. Avoid unnecessary initializations.
5203
52042011-05-27 Chong Yidong <cyd@stupidchicken.com>
5205
5206 * termhooks.h (Vselection_alist): Make it terminal-local.
5207
5208 * terminal.c (create_terminal): Initialize it.
5209
5210 * xselect.c: Support for clipboard managers.
5211 (Vselection_alist): Move to termhooks.h as terminal-local var.
5212 (LOCAL_SELECTION): New macro.
5213 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5214 (symbol_to_x_atom): Remove gratuitous arg.
5215 (x_handle_selection_request, lisp_data_to_selection_data)
5216 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5217 (x_own_selection, x_get_local_selection, x_convert_selection):
5218 New arg, specifying work frame. Use terminal-local Vselection_alist.
5219 (some_frame_on_display): Delete unused function.
5220 (Fx_own_selection_internal, Fx_get_selection_internal)
5221 (Fx_disown_selection_internal, Fx_selection_owner_p)
5222 (Fx_selection_exists_p): New optional frame arg.
5223 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5224 (x_handle_selection_clear): Don't treat other terminals with the
5225 same keyboard specially. Use the terminal-local Vselection_alist.
5226 (x_clear_frame_selections): Use Frun_hook_with_args.
5227
5228 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5229
5230 * xterm.h: Add support for those atoms.
5231
52322011-05-26 Chong Yidong <cyd@stupidchicken.com>
5233
5234 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5235 (converted_selections, conversion_fail_tag): New global variables.
5236 (x_selection_request_lisp_error): Free the above.
5237 (x_get_local_selection): Remove unnecessary code.
5238 (x_reply_selection_request): Args changed; handle arbitrary array
5239 of converted selections stored in converted_selections.
5240 Separate the XChangeProperty and SelectionNotify steps.
5241 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5242 (x_convert_selection): New function.
5243 (x_handle_selection_event): Simplify.
5244 (x_get_foreign_selection): Don't ignore incoming requests while
5245 waiting for an answer; this will fail when we implement
5246 SAVE_TARGETS, and seems unnecessary anyway.
5247 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5248 (Vx_sent_selection_functions): Doc fix.
5249
52502011-05-26 Leo Liu <sdl.web@gmail.com>
5251
5252 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5253
52542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5255
5256 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5257
5258 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5259 for fringe update if it has periodic bitmap.
5260 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5261 and fringe_bitmap_periodic_p.
5262
5263 * fringe.c (get_fringe_bitmap_data): New function.
5264 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5265 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5266 row. Mark glyph row for fringe update if periodicity changed.
5267
5268 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5269 for fringe update unless it has periodic bitmap.
5270
52712011-05-25 Kenichi Handa <handa@m17n.org>
5272
5273 * xdisp.c (get_next_display_element): Set correct it->face_id for
5274 a static composition.
5275
52762011-05-24 Leo Liu <sdl.web@gmail.com>
5277
5278 * deps.mk (fns.o):
5279 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5280
5281 * fns.c (crypto_hash_function, Fsha1): New function.
5282 (Fmd5): Use crypto_hash_function.
5283 (syms_of_fns): Add Ssha1.
5284
52852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5286
5287 * gnutls.c: Remove unused macros.
5288 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5289 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5290 Remove macros that are defined and never used.
5291 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5292
52932011-05-22 Chong Yidong <cyd@stupidchicken.com>
5294
5295 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5296 (Fx_get_selection_internal): Minor cleanup.
5297 (Fx_own_selection_internal): Rename arguments for consistency with
5298 select.el.
5299
53002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5301
5302 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5303
53042011-05-22 Chong Yidong <cyd@stupidchicken.com>
5305
5306 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5307
53082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5309
5310 * dispnew.c (scrolling_window): Don't exclude the case that the
5311 last enabled row in the desired matrix touches the bottom boundary.
5312
53132011-05-21 Glenn Morris <rgm@gnu.org>
5314
5315 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5316 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5317 and add some more files.
5318
53192011-05-20 Eli Zaretskii <eliz@gnu.org>
5320
5321 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5322 report_file_error introduced by the change from 2011-05-07.
5323
53242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5325
5326 * systime.h (Time): Define only if emacs is defined.
5327 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5328 where the include path doesn't have X11/X.h by default. See
5329 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5330
53312011-05-20 Kenichi Handa <handa@m17n.org>
5332
5333 * composite.c (find_automatic_composition): Fix previous change.
5334
53352011-05-20 Glenn Morris <rgm@gnu.org>
5336
5337 * lisp.mk: New file, split from Makefile.in.
5338 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5339 (shortlisp): Remove.
5340 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5341
53422011-05-19 Glenn Morris <rgm@gnu.org>
5343
5344 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5345 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5346 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5347 (lisp): Set the order to that of loadup.el.
5348 (shortlisp): Make it a copy of $lisp.
5349 (SOME_MACHINE_LISP): Remove.
5350 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5351 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5352
53532011-05-18 Kenichi Handa <handa@m17n.org>
5354
5355 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5356 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5357 (find_automatic_composition): Mostly rewrite for efficiency.
5358
53592011-05-18 Juanma Barranquero <lekktu@gmail.com>
5360
5361 * makefile.w32-in: Update dependencies.
5362
53632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5364
5365 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5366 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5367
53682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5369
5370 Fix some integer overflow issues, such as string length overflow.
5371
5372 * insdel.c (count_size_as_multibyte): Check for string overflow.
5373
5374 * character.c (lisp_string_width): Check for string overflow.
5375 Use EMACS_INT, not int, for string indexes and lengths; in
5376 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5377 the resulting string length overflows an EMACS_INT; instead,
5378 report a string overflow if no precision given. When checking for
5379 precision exhaustion, use a check that cannot possibly have
5380 integer overflow. (Bug#8675)
5381 * character.h (lisp_string_width): Adjust to new signature.
5382
5383 * alloc.c (string_overflow): New function.
5384 (Fmake_string): Use it. This doesn't change behavior, but saves
5385 a few bytes and will simplify future changes.
5386 * character.c (string_escape_byte8): Likewise.
5387 * lisp.h (string_overflow): New decl.
5388
5389 Fixups, following up to the user-interface timestamp change.
5390 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5391 for UI timestamps, instead of unsigned long.
5392 * msdos.c (mouse_get_pos): Likewise.
5393 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5394 * w32gui.h (Time): Define by including "systime.h" rather than by
5395 declaring it ourselves. (Bug#8664)
5396
5397 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5398 * image.c (clear_image_cache): Likewise.
5399
5400 * term.c (term_mouse_position): Don't assume time_t wraparound.
5401
5402 Be more systematic about user-interface timestamps.
5403 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5404 and sometimes 'EMACS_UINT', to represent these timestamps.
5405 This change causes it to use 'Time' uniformly, as that's what X uses.
5406 This makes the code easier to follow, and makes it easier to catch
5407 integer overflow bugs such as Bug#8664.
5408 * frame.c (Fmouse_position, Fmouse_pixel_position):
5409 Use Time, not unsigned long, for user-interface timestamps.
5410 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5411 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5412 * keyboard.h (last_event_timestamp): Likewise.
5413 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5414 * menu.h (xmenu_show): Likewise.
5415 * term.c (term_mouse_position): Likewise.
5416 * termhooks.h (struct input_event.timestamp): Likewise.
5417 (struct terminal.mouse_position_hook): Likewise.
5418 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5419 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5420 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5421 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5422 what it was before.
5423 * menu.h, termhooks.h: Include "systime.h", for Time.
5424
5425 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5426 Don't assume that the difference between two unsigned long values
5427 can fit into an integer. At this point, we know button_down_time
5428 <= event->timestamp, so the difference must be nonnegative, so
5429 there's no need to cast the result if double-click-time is
5430 nonnegative, as it should be; check that it's nonnegative, just in
5431 case. This bug is triggered when events are more than 2**31 ms
5432 apart (about 25 days). (Bug#8664)
5433
5434 * xselect.c (last_event_timestamp): Remove duplicate decl.
5435 (x_own_selection): Remove needless cast to unsigned long.
5436
5437 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5438 that always fit in int. Use a sentinel instead of a counter, to
5439 avoid a temp and to allay GCC's concerns about possible int overflow.
5440 * frame.h (struct frame): Use int for menu_bar_items_used
5441 instead of EMACS_INT, since it always fits in int.
5442
5443 * menu.c (grow_menu_items): Check for int overflow.
5444
5445 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5446
5447 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5448 Before, the code was not consistent. These values cannot exceed
5449 2**31 - 1 so there's no need to make them unsigned.
5450 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5451 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5452 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5453 as modifiers.
5454 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5455
5456 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5457 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5458 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5459 presumably because the widths might not match.
5460
5461 * window.c (size_window): Avoid needless test at loop start.
5462
54632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5464
5465 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5466
54672011-05-12 Drew Adams <drew.adams@oracle.com>
5468
5469 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5470
54712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5472
5473 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5474 `width' to `bar_area_x' and `bar_area_width', respectively.
5475 (x_scroll_run): Take account of fringe background extension.
5476
5477 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5478 Rename local vars `left' and `width' to `bar_area_x' and
5479 `bar_area_width', respectively.
5480 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5481 background extension.
5482
54832011-05-10 Jim Meyering <meyering@redhat.com>
5484
5485 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5486
54872011-05-10 Juanma Barranquero <lekktu@gmail.com>
5488
5489 * image.c (Finit_image_library): Return t for built-in image types,
5490 like pbm and xbm. (Bug#8640)
5491
54922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5493
5494 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5495
54962011-05-07 Eli Zaretskii <eliz@gnu.org>
5497
5498 * w32console.c (Fset_screen_color): Doc fix.
5499 (Fget_screen_color): New function.
5500 (syms_of_ntterm): Defsubr it.
5501
5502 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5503 unlink the temporary file if Fcall_process didn't create it in the
5504 first place.
5505 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5506 child process will be redirected to a file specified with `:file'.
5507 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5508 cue to call_process_cleanup not to close that handle.
5509
55102011-05-07 Ben Key <bkey76@gmail.com>
5511
5512 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5513 one of two shell specific rules, either bootstrap-temacs-CMD or
5514 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5515 to the previous implementation of the bootstrap-temacs rule.
5516 The bootstrap-temacs-CMD rule is similar to the previous
5517 implementation of the bootstrap-temacs rule except that it
5518 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5519 variable.
5520
5521 These changes, along with some changes to nt/configure.bat,
5522 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5523 earlier fix to add support for --cflags and --ldflags options
5524 that include quotes so that it works whether make uses cmd or
5525 sh as the shell.
5526
55272011-05-06 Michael Albinus <michael.albinus@gmx.de>
5528
5529 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5530 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5531 is a constant.
5532 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5533 a string. Handle both cases.
5534 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5535 (Fdbus_register_method): Use Qinvalid_function.
5536
55372011-05-06 Juanma Barranquero <lekktu@gmail.com>
5538
5539 * makefile.w32-in: Update dependencies.
5540 (LISP_H): Add inttypes.h and stdin.h.
5541 (PROCESS_H): Add unistd.h.
5542
55432011-05-06 Eli Zaretskii <eliz@gnu.org>
5544
5545 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5546 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5547
55482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5549
5550 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5551
5552 * term.c (vfatal): Remove stray call to va_end.
5553 It's not needed and the C Standard doesn't allow it here anyway.
5554
5555 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5556 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5557
5558 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5559 bytes.
5560
5561 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5562
5563 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5564
5565 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5566
5567 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5568
5569 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5570
5571 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5572 * charset.c (Fdefine_charset_internal): Don't initialize
5573 charset.code_space[15]. The value was garbage, on hosts with
5574 32-bit int (Bug#8600).
5575
5576 * lread.c (read_integer): Be more consistent with string-to-number.
5577 Use string_to_number to do the actual conversion; this avoids
5578 rounding errors and fixes some other screwups. Without this fix,
5579 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5580 (digit_to_number): Move earlier, for benefit of read_integer.
5581 Return -1 if the digit is out of range for the base, -2 if it is
5582 not a digit in any supported base. (Bug#8602)
5583
5584 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5585
5586 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5587 to match comment at start of function. This also removes a
5588 GCC warning about overflow in a 32+64-bit port.
5589
5590 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5591
5592 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5593 Reported by Stefan Monnier in
5594 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5595 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5596 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5597
5598 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5599 (EMACS_UINTPTR): Likewise, with uintptr_t.
5600
5601 * lisp.h: Prefer 64-bit EMACS_INT if available.
5602 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5603 on 32-bit hosts that have 64-bit int, so that they can access
5604 large files.
5605 However, temporarily disable this change unless the temporary
5606 symbol WIDE_EMACS_INT is defined.
5607
5608 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5609
5610 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5611 This removes an assumption that EMACS_INT and long are the same
5612 width as pointers. The assumption is true for Emacs porting targets
5613 now, but we want to make other targets possible.
5614 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5615 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5616 In the rest of the code, change types of integers that hold casted
5617 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5618 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5619 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5620 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5621 No need to cast type when ORing.
5622 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5623 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5624 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5625 assume EMACS_INT is the same width as char *.
5626 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5627 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5628 Remove no-longer-needed casts.
5629 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5630 (xg_tool_bar_help_callback, xg_make_tool_item):
5631 Use EMACS_INTPTR to hold an integer
5632 that will be cast to void *; this can avoid a GCC warning
5633 if EMACS_INT is not the same width as void *.
5634 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5635 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5636 (current_message_1, set_message_1):
5637 Use a local to convert to proper width without a cast.
5638 * xmenu.c (dialog_selection_callback): Likewise.
5639
5640 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5641 Also, don't assume VALBITS / RAND_BITS is less than 5,
5642 and don't rely on undefined behavior when shifting a 1 left into
5643 the sign bit.
5644 * lisp.h (get_random): Change signature to match.
5645
5646 * lread.c (hash_string): Use size_t, not int, for hash computation.
5647 Normally we prefer signed values; but hashing is special, because
5648 it's better to use unsigned division on hash table sizes so that
5649 the remainder is nonnegative. Also, size_t is the natural width
5650 for hashing into memory. The previous code used 'int', which doesn't
5651 retain enough info to hash well into very large tables.
5652 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5653
5654 * dbusbind.c: Don't possibly lose pointer info when converting.
5655 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5656 Use XPNTR rather than XHASH, so that the high-order bits of
5657 the pointer aren't lost when converting through void *.
5658
5659 * eval.c (Fautoload): Don't double-shift a pointer.
5660
5661 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5662
56632011-05-06 Juanma Barranquero <lekktu@gmail.com>
5664
5665 * gnutls.c (DEF_GNUTLS_FN):
5666 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5667
56682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5669
5670 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5671 marker. (Bug#8610)
5672
56732011-05-05 Eli Zaretskii <eliz@gnu.org>
5674
5675 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5676 New version that can reserve upto 2GB of heap space.
5677
56782011-05-05 Chong Yidong <cyd@stupidchicken.com>
5679
5680 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5681
56822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5683
5684 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5685 `gnutls_certificate_set_x509_key_file'.
5686
56872011-05-05 Juanma Barranquero <lekktu@gmail.com>
5688
5689 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5690 Update dependencies.
5691
56922011-05-04 Juanma Barranquero <lekktu@gmail.com>
5693
5694 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5695 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5696 Remove unused parameter `fildes'.
5697 * process.c (read_process_output, send_process): Don't pass it.
5698
56992011-05-04 Juanma Barranquero <lekktu@gmail.com>
5700
5701 Fix previous change: the library cache is defined in w32.c.
5702 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5703 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5704
57052011-05-04 Juanma Barranquero <lekktu@gmail.com>
5706
5707 Implement dynamic loading of GnuTLS on Windows.
5708
5709 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5710 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5711 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5712 Declare.
5713
5714 * gnutls.c (Qgnutls_dll): Define.
5715 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5716 (gnutls_*): Declare function pointers.
5717 (init_gnutls_functions): New function to initialize function pointers.
5718 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5719 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5720 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5721 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5722 (emacs_gnutls_write, emacs_gnutls_read)
5723 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5724 (Fgnutls_available_p): New function.
5725 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5726 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5727 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5728
5729 * image.c: Include w32.h.
5730 (Vimage_type_cache): Delete.
5731 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5732 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5733 (w32_delayed_load): Move to w32.c.
5734
5735 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5736
5737 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5738 (w32_delayed_load): Move from image.c. When loading a library, record
5739 its filename in the :loaded-from property of the library id.
5740 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5741 Initialize and staticpro them.
5742 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5743
5744 * process.c: Include lisp.h before w32.h, not after.
5745 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5746 instead of gnutls_record_check_pending.
5747
5748 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5749
57502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5751
5752 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5753 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5754 as passed in.
5755
57562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5757
5758 * xterm.c (x_set_frame_alpha): Do not set property on anything
5759 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5760
57612011-05-02 Juanma Barranquero <lekktu@gmail.com>
5762
5763 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5764
57652011-05-02 Juanma Barranquero <lekktu@gmail.com>
5766
5767 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5768 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5769 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5770 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5771 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5772 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5773 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5774 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5775 (Qgnutls_bootprop_callbacks_verify): Make static.
5776
57772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5778
5779 * callproc.c: Indentation fixup.
5780
5781 * sysdep.c (wait_for_termination_1): Make static.
5782 (wait_for_termination, interruptible_wait_for_termination):
5783 Move after wait_for_termination_1.
5784
57852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5786
5787 * sysdep.c (interruptible_wait_for_termination): New function
5788 which is like wait_for_termination, but allows keyboard
5789 interruptions.
5790
5791 * callproc.c (Fcall_process): Add (:file "file") as an option for
5792 the STDOUT buffer.
5793 (Fcall_process_region): Ditto.
5794
57952011-04-30 Eli Zaretskii <eliz@gnu.org>
5796
5797 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5798 rather than `XVECTOR (FOO)->size'.
5799
5800 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5801 inttypes.h, as a gnulib replacement is used if it not available in
5802 system headers.
5803
58042011-04-21 Eli Zaretskii <eliz@gnu.org>
5805
5806 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5807 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5808 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5809
5810 * coding.c (coding_alloc_by_realloc): Error out if destination
5811 will grow beyond MOST_POSITIVE_FIXNUM.
5812 (decode_coding_emacs_mule): Abort if there isn't enough place in
5813 charbuf for the composition carryover bytes. Reserve an extra
5814 space for up to 2 characters produced in a loop.
5815 (decode_coding_iso_2022): Abort if there isn't enough place in
5816 charbuf for the composition carryover bytes.
5817
58182011-04-21 Eli Zaretskii <eliz@gnu.org>
5819
5820 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5821 aborting when %lld or %lll format is passed.
5822 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5823 %llo or %llx format is passed. (Bug#8545)
5824
5825 * window.c (window_scroll_line_based): Use a marker instead of
5826 simple variables to record original value of point. (Bug#7952)
5827
5828 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5829 produced by %s or %c overflows available buffer space. (Bug#8545)
5830
58312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5832
5833 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5834 (SIZE_MAX): Move defn after all includes, as they might #define it.
5835
58362011-04-28 Juanma Barranquero <lekktu@gmail.com>
5837
5838 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5839
58402011-04-28 Juanma Barranquero <lekktu@gmail.com>
5841
5842 * keyboard.c (Qdelayed_warnings_hook): Define.
5843 (command_loop_1): Run `delayed-warnings-hook'
5844 if Vdelayed_warnings_list is non-nil.
5845 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5846 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5847
58482011-04-28 Eli Zaretskii <eliz@gnu.org>
5849
5850 * doprnt.c (doprnt): Don't return value smaller than the buffer
5851 size if the message was truncated. (Bug#8545).
5852
58532011-04-28 Juanma Barranquero <lekktu@gmail.com>
5854
5855 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5856 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5857
58582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5859
5860 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5861
58622011-04-27 Juanma Barranquero <lekktu@gmail.com>
5863
5864 * makefile.w32-in: Update dependencies.
5865
58662011-04-27 Eli Zaretskii <eliz@gnu.org>
5867
5868 Improve `doprnt' and its usage. (Bug#8545)
5869 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5870 `format_end'. Remove support for %l as a conversion specifier.
5871 Don't use xrealloc. Improve diagnostics when the %l size modifier
5872 is used. Update the commentary.
5873
5874 * eval.c (verror): Simplify calculation of size_t.
5875
5876 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5877 messages.
5878
58792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5880
5881 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5882 change.
5883
58842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5885
5886 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5887 This makes this file independent of the recent pseudovector change.
5888
58892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5890
5891 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5892
5893 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5894 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5895 Remove unused local.
5896 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5897
5898 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5899 GCC 4.6.0 optimizes based on type-based alias analysis.
5900 For example, if b is of type struct buffer * and v of type struct
5901 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5902 != &v->size, and therefore "v->size = 1; b->size = 2; return
5903 v->size;" must therefore return 1. This assumption is incorrect
5904 for Emacs, since it type-puns struct Lisp_Vector * with many other
5905 types. To fix this problem, this patch adds a new type struct
5906 vectorlike_header that documents the constraints on layout of vectors
5907 and pseudovectors, and helps optimizing compilers not get fooled
5908 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5909 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5910 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5911 the size member.
5912 (XSETPVECTYPE): Rewrite in terms of new macro.
5913 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5914 This is a bit clearer, and further avoids the possibility of
5915 undesirable aliasing.
5916 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5917 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5918 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5919 since Lisp_Subr is a special case (no "next" field).
5920 (ASIZE): Now uses header.size rather than size.
5921 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5922 to avoid the hassle of writing XVECTOR (foo)->header.size.
5923 (struct vectorlike_header): New type.
5924 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5925 object, to help avoid aliasing.
5926 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5927 (SUBRP): Likewise, since Lisp_Subr is a special case.
5928 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5929 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5930 (struct Lisp_Hash_Table): Combine first two members into a single
5931 struct vectorlike_header member. All uses of "size" and "next" members
5932 changed to be "header.size" and "header.next".
5933 * buffer.h (struct buffer): Likewise.
5934 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5935 * frame.h (struct frame): Likewise.
5936 * process.h (struct Lisp_Process): Likewise.
5937 * termhooks.h (struct terminal): Likewise.
5938 * window.c (struct save_window_data, struct saved_window): Likewise.
5939 * window.h (struct window): Likewise.
5940 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5941 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5942 * buffer.c (init_buffer_once): Likewise.
5943 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5944 special case.
5945 * process.c (Fformat_network_address): Use local var for size,
5946 for brevity.
5947
5948 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5949
5950 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5951 * data.c (atof): Remove decl; no longer used or needed.
5952 (digit_to_number): Move to lread.c.
5953 (Fstring_to_number): Use new string_to_number function, to be
5954 consistent with how the Lisp reader treats infinities and NaNs.
5955 Do not assume that floating-point numbers represent EMACS_INT
5956 without losing information; this is not true on most 64-bit hosts.
5957 Avoid double-rounding errors, by insisting on integers when
5958 parsing non-base-10 numbers, as the documentation specifies.
5959 * lisp.h (string_to_number): New decl, replacing ...
5960 (isfloat_string): Remove.
5961 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5962 (read1): Do not accept +. and -. as integers; this
5963 appears to have been a coding error. Similarly, do not accept
5964 strings like +-1e0 as floating point numbers. Do not report
5965 overflow for integer overflows unless the base is not 10 which
5966 means we have no simple and reliable way to continue.
5967 Break out the floating-point parsing into a new
5968 function string_to_number, so that Fstring_to_number parses
5969 floating point numbers consistently with the Lisp reader.
5970 (digit_to_number): Move here from data.c. Make it static inline.
5971 (E_CHAR, EXP_INT): Remove, replacing with ...
5972 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5973 (string_to_number): New function, replacing isfloat_string.
5974 This function checks for valid syntax and produces the resulting
5975 Lisp float number too. Rework it so that string-to-number
5976 no longer mishandles examples like "1.0e+". Use strtoumax,
5977 so that overflow for non-base-10 numbers is reported only when
5978 there's no portable and simple way to convert to floating point.
5979
5980 * textprop.c (set_text_properties_1): Rewrite for clarity,
5981 and to avoid GCC warning about integer overflow.
5982
5983 * intervals.h (struct interval): Use EMACS_INT for members
5984 where EMACS_UINT might cause problems. See
5985 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5986 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5987 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5988 All uses changed.
5989 (offset_intervals): Tell GCC not to worry about length overflow
5990 when negating a negative length.
5991
5992 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5993 (overrun_check_free): Likewise.
5994
5995 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5996 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5997 word size.
5998
5999 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6000 (gnutls_make_error): Rename local to avoid shadowing.
6001 (gnutls_emacs_global_deinit): ifdef out; not used.
6002 (Fgnutls_boot): Use const for pointer to readonly storage.
6003 Comment out unused local. Fix pointer signedness problems.
6004
6005 * lread.c (openp): Don't stuff size_t into an 'int'.
6006 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6007 about possible signed overflow.
6008
6009 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6010 (GDK_KEY_g): Don't define if already defined.
6011 (xg_prepare_tooltip): Avoid pointer signedness problem.
6012 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6013
6014 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6015 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6016
6017 * xfns.c (Fx_window_property): Simplify a bit,
6018 to make a bit faster and to avoid GCC 4.6.0 warning.
6019 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6020
6021 * fns.c (internal_equal): Don't assume size_t fits in int.
6022
6023 * alloc.c (compact_small_strings): Tighten assertion a little.
6024
6025 Replace pEd with more-general pI, and fix some printf arg casts.
6026 * lisp.h (pI): New macro, generalizing old pEd macro to other
6027 conversion specifiers. For example, use "...%"pI"d..." rather
6028 than "...%"pEd"...".
6029 (pEd): Remove. All uses replaced with similar uses of pI.
6030 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6031 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6032 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6033 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6034 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6035 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6036 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6037 64-bit hosts.
6038 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6039 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6040 * print.c (safe_debug_print, print_object): Likewise.
6041 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6042 to int.
6043 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6044 avoiding the 0 flag, which is not portable.
6045 * process.c (Fmake_network_process): Use pI to avoid cast.
6046 * region-cache.c (pp_cache): Likewise.
6047 * xdisp.c (decode_mode_spec): Likewise.
6048 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6049 behavior on 64-bit hosts with printf arg.
6050 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6051 (x_stop_queuing_selection_requests): Likewise.
6052 (x_get_window_property): Don't truncate byte count to an 'int'
6053 when tracing.
6054
6055 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6056 here, since it parses constructs like leading '-' and spaces,
6057 which are not wanted; and it overflows with large numbers.
6058 Instead, simply match F[0-9]+, which is what is wanted anyway.
6059
6060 * alloc.c: Remove unportable assumptions about struct layout.
6061 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6062 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6063 (allocate_vectorlike, make_pure_vector): Use the new macros,
6064 plus offsetof, to remove unportable assumptions about struct layout.
6065 These assumptions hold on all porting targets that I know of, but
6066 they are not guaranteed, they're easy to remove, and removing them
6067 makes further changes easier.
6068
6069 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6070 This doesn't fix a bug but makes the code clearer.
6071 (string_overrun_cookie): Now const. Use initializers that
6072 don't formally overflow signed char, to avoid warnings.
6073 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6074 can cause Emacs to crash when string overrun checking is enabled.
6075 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6076 multiple of sizeof (EMACS_INT); it need not be, if
6077 alignof(EMACS_INT) < sizeof (EMACS_INT).
6078 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6079
60802011-04-26 Juanma Barranquero <lekktu@gmail.com>
6081
6082 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6083
60842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6085
6086 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6087 supposed to be handshaking. (Bug#8556)
6088 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6089
60902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6091
6092 * lisp.h (Qdebug): List symbol.
6093 * eval.c (Qdebug): Restore global linkage.
6094 * keyboard.c (debug-on-event): New variable.
6095 (handle_user_signal): Break into debugger when debug-on-event
6096 matches the current signal symbol.
6097
60982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6099
6100 * alloc.c (check_sblock, check_string_bytes)
6101 (check_string_free_list): Convert to standard C.
6102
61032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6104
6105 * w32.c (emacs_gnutls_push): Fix typo.
6106
61072011-04-25 Eli Zaretskii <eliz@gnu.org>
6108
6109 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6110 "cast to pointer from integer of different size".
6111
6112 Improve doprnt and its use in verror. (Bug#8545)
6113 * doprnt.c (doprnt): Document the set of format control sequences
6114 supported by the function. Use SAFE_ALLOCA instead of always
6115 using `alloca'.
6116
6117 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6118 is one byte too soon. Don't use xrealloc; instead xfree and
6119 xmalloc anew.
6120
61212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6122
6123 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6124 callbacks stage.
6125
6126 * gnutls.c: Renamed global_initialized to
6127 gnutls_global_initialized. Added internals for the
6128 :verify-hostname-error, :verify-error, and :verify-flags
6129 parameters of `gnutls-boot' and documented those parameters in the
6130 docstring. Start callback support.
6131 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6132 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6133 on error. Return error code.
6134 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6135 (emacs_gnutls_read): Likewise.
6136 (Fgnutls_boot): Return handshake error code.
6137 (emacs_gnutls_handle_error): New function.
6138 (wsaerror_to_errno): Likewise.
6139
6140 * w32.h (emacs_gnutls_pull): Add prototype.
6141 (emacs_gnutls_push): Likewise.
6142
6143 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6144 (emacs_gnutls_push): Likewise.
6145
61462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6147
6148 * process.c (wait_reading_process_output): Check if GnuTLS
6149 buffered some data internally if no FDs are set for TLS
6150 connections.
6151
6152 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6153 (LIBS): Link to USER_LIBS.
6154 ($(BLD)/gnutls.$(0)): New target.
6155
61562011-04-24 Eli Zaretskii <eliz@gnu.org>
6157
6158 * xdisp.c (handle_single_display_spec): Rename the
6159 display_replaced_before_p argument into display_replaced_p, to
6160 make it consistent with the commentary. Fix typos in the
6161 commentary.
6162
6163 * textprop.c (syms_of_textprop): Remove dead code.
6164 (copy_text_properties): Delete obsolete commentary about an
6165 interface that was deleted long ago. Fix typos in the description
6166 of arguments.
6167
6168 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6169 to changes in oldXMenu/XMenu.h from 2011-04-16.
6170 <menu_help_message, prev_menu_help_message>: Constify.
6171 (IT_menu_make_room): menu->help_text is now `const char **';
6172 adjust.
6173
6174 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6175 to changes in oldXMenu/XMenu.h from 2011-04-16.
6176 (struct XMenu): Declare `help_text' `const char **'.
6177
6178 * xfaces.c <Qunspecified>: Make extern again.
6179
6180 * syntax.c: Include sys/types.h before including regex.h, as
6181 required by Posix.
6182
6183 * doc.c (get_doc_string): Improve the format passed to `error'.
6184
6185 * doprnt.c (doprnt): Improve commentary.
6186
6187 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6188
6189 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6190 them with etags.
6191
6192 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6193 changes in globals.h immediately force recompilation.
6194 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6195 $(CURDIR)/s/ms-w32.h.
6196 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6197
6198 * character.c (Fchar_direction): Function deleted.
6199 (syms_of_character): Don't defsubr it.
6200 <char-direction-table>: Deleted.
6201
62022011-04-23 Eli Zaretskii <eliz@gnu.org>
6203
6204 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6205 * doprnt.c: Include limits.h.
6206 (SIZE_MAX): New macro.
6207 (doprnt): Return a size_t value. 2nd arg is now size_t.
6208 Many local variables are now size_t instead of int or unsigned.
6209 Improve overflow protection. Support `l' modifier for integer
6210 conversions. Support %l conversion. Don't assume an EMACS_INT
6211 argument for integer conversions and for %c.
6212
6213 * lisp.h (doprnt): Restore prototype.
6214
6215 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6216 $(SRC)/character.h.
6217
6218 * Makefile.in (base_obj): Add back doprnt.o.
6219
6220 * deps.mk (doprnt.o): Add back prerequisites.
6221 (callint.o): Depend on character.h.
6222
6223 * eval.c (internal_lisp_condition_case): Include the handler
6224 representation in the error message.
6225 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6226 when breaking from the loop.
6227
6228 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6229
6230 * callint.c (Fcall_interactively): When displaying error message
6231 about invalid control letter, pass the character's codepoint, not
6232 a pointer to its multibyte form. Improve display of the character
6233 in octal and display also its hex code.
6234
6235 * character.c (char_string): Use %x to display the (unsigned)
6236 codepoint of an invalid character, to avoid displaying a bogus
6237 negative value.
6238
6239 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6240 `error', not SYMBOL_NAME itself.
6241
6242 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6243 character arguments to `error'.
6244
6245 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6246 to `error' in error message about FINAL_CHAR argument. Make sure
6247 FINAL_CHAR is a character, and use %c when it is passed as
6248 argument to `error'.
6249
62502011-04-23 Eli Zaretskii <eliz@gnu.org>
6251
6252 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6253
6254 * w32.c: Include <time.h>.
6255 (sys_localtime): New function.
6256
62572011-04-23 Chong Yidong <cyd@stupidchicken.com>
6258
6259 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6260
6261 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6262
62632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6264
6265 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6266 zombies (Bug#8467).
6267
62682011-04-19 Eli Zaretskii <eliz@gnu.org>
6269
6270 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6271 gl_state.e_property when gl_state.object is Qt.
6272
6273 * insdel.c (make_gap_larger): Remove limitation of buffer size
6274 to <= INT_MAX.
6275
62762011-04-18 Chong Yidong <cyd@stupidchicken.com>
6277
6278 * xdisp.c (lookup_glyphless_char_display)
6279 (produce_glyphless_glyph): Handle cons cell entry in
6280 glyphless-char-display.
6281 (Vglyphless_char_display): Document it.
6282
6283 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6284 glyphless-char-display.
6285
62862011-04-17 Chong Yidong <cyd@stupidchicken.com>
6287
6288 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6289
6290 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6291
6292 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6293 definition for no-X builds.
6294
62952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6296
6297 Static checks with GCC 4.6.0 and non-default toolkits.
6298
6299 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6300
6301 * process.c (keyboard_bit_set): Define only if SIGIO.
6302 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6303 (send_process): Repair possible setjmp clobbering.
6304
6305 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6306
6307 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6308
6309 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6310
6311 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6312 Define only if needed.
6313
6314 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6315 by pacifying GCC about it. Maybe it's time to retire it?
6316 * xfaces.c (USG, __TIMEVAL__): Likewise.
6317
6318 * dispextern.h (struct redisplay_interface): Rename param
6319 to avoid shadowing.
6320 * termhooks.h (struct terminal): Likewise.
6321 * xterm.c (xembed_send_message): Likewise.
6322
6323 * insdel.c (make_gap_smaller): Define only if
6324 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6325
6326 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6327 it.
6328
6329 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6330 so that we aren't warned about unused symbols.
6331
6332 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6333
6334 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6335
6336 * xfns.c (x_real_positions): Mark locals as initialized.
6337
6338 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6339
6340 * xterm.c: Fix problems found by static analysis with other toolkits.
6341 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6342 (x_dispatch_event): Declare static if USE_GTK, and
6343 define if USE_GTK || USE_X_TOOLKIT.
6344 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6345 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6346 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6347 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6348
6349 * xmenu.c (menu_help_callback): Pointer type fixes.
6350 Use const pointers when pointing at readonly data. Avoid pointer
6351 signedness clashes.
6352 (FALSE): Remove unused macro.
6353 (update_frame_menubar): Remove unused decl.
6354
6355 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6356
6357 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6358 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6359 (single_menu_item): Rename local to avoid shadowing.
6360
6361 * keyboard.c (make_lispy_event): Remove unused local var.
6362
6363 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6364 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6365
6366 * bitmaps: Change bitmaps from unsigned char back to the X11
6367 compatible char. Avoid the old compiler warnings about
6368 out-of-range initializers by using, for example, '\xab' rather
6369 than 0xab.
6370
6371 * xgselect.c (xgselect_initialize): Check vs interface
6372 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6373
6374 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6375
6376 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6377 to read-only memory.
6378
6379 * fns.c (vector): Remove; this old hack is no longer needed.
6380
6381 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6382 Remove unused var.
6383 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6384
6385 * xrdb.c (x_load_resources): Omit unused local.
6386
6387 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6388 (x_window): Rename locals to avoid shadowing.
6389 (USG): Use the kludged USG macro, to pacify gcc.
6390
6391 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6392 (x_term_init): Remove local to avoid shadowing.
6393
6394 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6395
6396 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6397 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6398
63992011-04-16 Eli Zaretskii <eliz@gnu.org>
6400
6401 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6402
6403 Fix regex.c, syntax.c and friends for buffers > 2GB.
6404 * syntax.h (struct gl_state_s): Declare character position members
6405 EMACS_INT.
6406
6407 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6408
6409 * textprop.c (verify_interval_modification, interval_of):
6410 Declare arguments EMACS_INT.
6411
6412 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6413 EMACS_INT.
6414
6415 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6416
6417 * indent.c (Fvertical_motion): Local variable it_start is now
6418 EMACS_INT.
6419
6420 * regex.c (re_match, re_match_2, re_match_2_internal)
6421 (bcmp_translate, regcomp, regexec, print_double_string)
6422 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6423 (re_compile_pattern, re_exec): Declare arguments and local
6424 variables `size_t' and `ssize_t' and return values `regoff_t', as
6425 appropriate.
6426 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6427 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6428 <compile_stack_type>: `size' and `avail' are now `size_t'.
6429
6430 * regex.h <regoff_t>: Use ssize_t, not int.
6431 (re_search, re_search_2, re_match, re_match_2): Arguments that
6432 specify buffer/string position and length are now ssize_t and
6433 size_t. Return type is regoff_t.
6434
64352011-04-16 Ben Key <bkey76@gmail.com>
6436
6437 * nsfont.m: Fixed bugs in ns_get_family and
6438 ns_descriptor_to_entity that were caused by using free to
6439 deallocate memory blocks that were allocated by xmalloc (via
6440 xstrdup). This caused Emacs to crash when compiled with
6441 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6442 --enable-checking=xmallocoverrun). xfree is now used to
6443 deallocate these memory blocks.
6444
64452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6446
6447 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6448
6449 emacs_write: Accept and return EMACS_INT for sizes.
6450 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6451 et seq.
6452 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6453 Accept and return EMACS_INT.
6454 (emacs_gnutls_write): Return the number of bytes written on
6455 partial writes.
6456 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6457 (emacs_read, emacs_write): Remove check for negative size, as the
6458 Emacs source code has been audited now.
6459 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6460 (emacs_read, emacs_write): Use it.
6461 * process.c (send_process): Adjust to the new signatures of
6462 emacs_write and emacs_gnutls_write. Do not attempt to store
6463 a byte offset into an 'int'; it might overflow.
6464 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6465
6466 * sound.c: Don't assume sizes fit in 'int'.
6467 (struct sound_device.period_size, alsa_period_size):
6468 Return EMACS_INT, not int.
6469 (struct sound_device.write, vox_write, alsa_write):
6470 Accept EMACS_INT, not int.
6471 (wav_play, au_play): Use EMACS_INT to store sizes and to
6472 record read return values.
6473
64742011-04-15 Ben Key <bkey76@gmail.com>
6475
6476 * keyboard.c (Qundefined): Don't declare static since it is used
6477 in nsfns.m.
6478 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6479 static since they are used in nsfont.m.
6480
64812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6482
6483 * process.c (Qprocessp): Don't declare static.
6484 * lisp.h (Qprocessp): Declare again.
6485
64862011-04-15 Juanma Barranquero <lekktu@gmail.com>
6487
6488 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6489
64902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6491
6492 Improve C-level modularity by making more things 'static'.
6493
6494 Don't publish debugger-only interfaces to other modules.
6495 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6496 (verify_bytepos, count_markers): Move decls to the only modules
6497 that need them.
6498 * region-cache.h (pp_cache): Likewise.
6499 * window.h (check_all_windows): Likewise.
6500 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6501
6502 * sysdep.c (croak): Now static, if
6503 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6504 * syssignal.h (croak): Declare only if not static.
6505
6506 * alloc.c (refill_memory_reserve): Now static if
6507 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6508 * lisp.h (refill_memory_reserve): Declare only if not static.
6509
6510 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6511 Define only if USE_LUCID.
6512
6513 * xrdb.c (x_customization_string, x_rm_string): Now static.
6514
6515 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6516 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6517
6518 * xdisp.c (draw_row_with_mouse_face): Now static.
6519 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6520
6521 * window.h (check_all_windows): Mark externally visible.
6522
6523 * window.c (window_deletion_count): Now static.
6524
6525 * undo.c: Make symbols static if they're not exported.
6526 (last_undo_buffer, last_boundary_position, pending_boundary):
6527 Now static.
6528
6529 * textprop.c (interval_insert_behind_hooks): Now static.
6530 (interval_insert_in_front_hooks): Likewise.
6531
6532 * term.c: Make symbols static if they're not exported.
6533 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6534 (max_frame_lines, tty_set_terminal_modes):
6535 (tty_reset_terminal_modes, tty_turn_off_highlight):
6536 (get_tty_terminal): Now static.
6537 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6538 * termhooks.h (term_mouse_moveto): Do not declare if
6539 HAVE_WINDOW_SYSTEM.
6540 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6541 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6542
6543 * sysdep.c: Make symbols static if they're not exported.
6544 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6545 Now static.
6546 (sigprocmask_set, full_mask): Remove; unused.
6547 (wait_debugging): Mark as visible.
6548 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6549 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6550
6551 * syntax.c (syntax_temp): Define only if !__GNUC__.
6552
6553 * sound.c (current_sound_device, current_sound): Now static.
6554
6555 * search.c (searchbufs, searchbuf_head): Now static.
6556
6557 * scroll.c (scroll_cost): Remove; unused.
6558 * dispextern.h (scroll_cost): Remove decl.
6559
6560 * region-cache.h (pp_cache): Mark as externally visible.
6561
6562 * process.c: Make symbols static if they're not exported.
6563 (process_tick, update_tick, create_process, chan_process):
6564 (Vprocess_alist, proc_buffered_char, datagram_access):
6565 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6566 (deactivate_process): Mark defn as static, as well as decl.
6567 * lisp.h (create_process): Remove decl.
6568 * process.h (chan_process, Vprocess_alist): Remove decls.
6569
6570 * print.c: Make symbols static if they're not exported.
6571 (print_depth, new_backquote_output, being_printed, print_buffer):
6572 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6573 (print_interval, print_number_index, initial_stderr_stream):
6574 Now static.
6575 * lisp.h (Fprinc): Remove decl.
6576 (debug_output_compilation_hack): Mark as externally visible.
6577
6578 * sysdep.c (croak): Move decl from here to syssignal.h.
6579 * syssignal.h (croak): Put it here, so the API can be checked when
6580 'croak' is called from dissociate_if_controlling_tty.
6581
6582 * minibuf.c: Make symbols static if they're not exported.
6583 (minibuf_save_list, choose_minibuf_frame): Now static.
6584 * lisp.h (choose_minibuf_frame): Remove decl.
6585
6586 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6587
6588 * lread.c: Make symbols static if they're not exported.
6589 (read_objects, initial_obarray, oblookup_last_bucket_number):
6590 Now static.
6591 (make_symbol): Remove; unused.
6592 * lisp.h (initial_obarray, make_symbol): Remove decls.
6593
6594 * keyboard.c: Make symbols static if they're not exported.
6595 (single_kboard, recent_keys_index, total_keys, recent_keys):
6596 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6597 (this_single_command_key_start, echoing, last_auto_save):
6598 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6599 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6600 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6601 (Vlispy_mouse_stem, double_click_count):
6602 Now static.
6603 (force_auto_save_soon): Define only if SIGDANGER.
6604 (ignore_mouse_drag_p): Now static if
6605 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6606 (print_help): Remove; unused.
6607 (stop_character, last_timer_event): Mark as externally visible.
6608 * keyboard.h (ignore_mouse_drag_p): Declare only if
6609 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6610 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6611 * lisp.h (echoing): Remove decl.
6612 (force_auto_save_soon): Declare only if SIGDANGER.
6613 * xdisp.c (redisplay_window): Simplify code, to make it more
6614 obvious that ignore_mouse_drag_p is not accessed if !defined
6615 USE_GTK && !defined HAVE_NS.
6616
6617 * intervals.c: Make symbols static if they're not exported.
6618 (merge_properties_sticky, merge_interval_right, delete_interval):
6619 Now static.
6620 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6621
6622 * insdel.c: Make symbols static if they're not exported.
6623 However, leave prepare_to_modify_buffer alone. It's never
6624 called from outside this function, but that appears to be a bug.
6625 (combine_after_change_list, combine_after_change_buffer):
6626 (adjust_after_replace, signal_before_change): Now static.
6627 (adjust_after_replace_noundo): Remove; unused.
6628 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6629 (signal_before_change): Remove decls.
6630
6631 * indent.c (val_compute_motion, val_vmotion): Now static.
6632
6633 * image.c: Make symbols static if they're not exported.
6634 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6635 if USE_GTK.
6636 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6637 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6638
6639 * fringe.c (standard_bitmaps): Now static.
6640 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6641
6642 * frame.c: Make symbols static if they're not exported.
6643 (x_report_frame_params, make_terminal_frame): Now static.
6644 (get_frame_param): Now static, unless HAVE_NS.
6645 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6646 (x_get_resource_string): Remove; not used.
6647 * frame.h (make_terminal_frame, x_report_frame_params):
6648 (x_get_resource_string); Remove decls.
6649 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6650 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6651
6652 * font.c, fontset.c: Make symbols static if they're not exported.
6653 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6654 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6655 * font.c (font_close_object): Now static.
6656 * font.h (font_close_object): Remove.
6657 * fontset.c (FONTSET_OBJLIST): Remove.
6658 (free_realized_fontset) #if-0 the body, which does nothing.
6659 (face_suitable_for_char_p): #if-0, as it's never called.
6660 * fontset.h (face_suitable_for_char_p): Remove decl.
6661 * xfaces.c (face_at_string_position):
6662 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6663 since 0 is always ASCII.
6664
6665 * fns.c (weak_hash_tables): Now static.
6666
6667 * fileio.c: Make symbols static if they're not exported.
6668 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6669 (Vwrite_region_annotation_buffers): Now static.
6670
6671 * eval.c: Make symbols static if they're not exported.
6672 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6673 * lisp.h (backtrace_list): Remove decl.
6674
6675 * emacs.c: Make symbols static if they're not exported.
6676 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6677 (fatal_error_code, fatal_error_signal_hook, standard_args):
6678 Now static.
6679 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6680 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6681 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6682 * lisp.h (fatal_error_signal_hook): Remove decl.
6683 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6684
6685 * editfns.c: Move a (normally-unused) function to its only use.
6686 * editfns.c, lisp.h (get_operating_system_release): Remove.
6687 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6688 worth the hassle of breaking this out.
6689
6690 * xterm.c: Make symbols static if they're not exported.
6691 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6692 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6693 (x_destroy_window, x_delete_display):
6694 Now static.
6695 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6696 (x_mouse_leave): Remove; unused.
6697 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6698 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6699 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6700 Remove decls.
6701 (x_mouse_leave): Declare only if WINDOWSNT.
6702 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6703 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6704 USE_X_TOOLKIT.
6705
6706 * ftxfont.c: Make symbols static if they're not exported.
6707 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6708 HAVE_FREETYPE.
6709 * font.h (ftxfont_driver): Likewise.
6710
6711 * xfns.c: Make symbols static if they're not exported.
6712 (x_last_font_name, x_display_info_for_name):
6713 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6714 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6715 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6716 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6717 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6718 (last_show_tip_args): Now static.
6719 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6720 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6721 (x_screen_planes): Remove; unused.
6722 * dispextern.h (x_screen_planes): Remove decl.
6723
6724 * dispnew.c: Make symbols static if they're not exported.
6725 * dispextern.h (redraw_garbaged_frames, scrolling):
6726 (increment_row_positions): Remove.
6727 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6728 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6729 Now static.
6730 (redraw_garbaged_frames): Remove; unused.
6731
6732 * xfaces.c: Make symbols static if they're not exported.
6733 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6734 Remove decls.
6735 * xterm.h (defined_color): Remove decls.
6736 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6737 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6738 (menu_face_changed_default, defined_color, free_realized_face):
6739 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6740 (ascii_face_of_lisp_face): Remove; unused.
6741
6742 * xdisp.c: Make symbols static if they're not exported.
6743 * dispextern.h (scratch_glyph_row, window_box_edges):
6744 (glyph_to_pixel_coords, set_cursor_from_row):
6745 (get_next_display_element, set_iterator_to_next):
6746 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6747 (show_mouse_face): Remove decls
6748 * frame.h (message_buf_print): Likewise.
6749 * lisp.h (pop_message, set_message, check_point_in_composition):
6750 Likewise.
6751 * xterm.h (set_vertical_scroll_bar): Likewise.
6752 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6753 (message_buf_print, scratch_glyph_row, displayed_buffer):
6754 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6755 (get_next_display_element, show_mouse_face, window_box_edges):
6756 (frame_to_window_pixel_xy, check_point_in_composition):
6757 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6758 (glyph_to_pixel_coords): Remove; unused.
6759
6760 * dired.c (file_name_completion): Now static.
6761
6762 * dbusbind.c (xd_in_read_queued_messages): Now static.
6763
6764 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6765 * data.c (circular_list_error): Remove.
6766
6767 * commands.h (last_point_position, last_point_position_buffer):
6768 (last_point_position_window): Remove decls.
6769 * keyboard.c: Make these variables static.
6770
6771 * coding.h (coding, code_convert_region, encode_coding_gap):
6772 Remove decls.
6773 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6774 (iso_code_class, detect_coding, code_convert_region): Now static.
6775 (encode_coding_gap): Remove; unused.
6776
6777 * chartab.c (chartab_chars, chartab_bits): Now static.
6778
6779 * charset.h (charset_iso_8859_1): Remove decl.
6780 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6781 Now static.
6782
6783 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6784 * ccl.c (Vccl_program_table): Now static.
6785 (check_ccl_update): Remove; unused.
6786
6787 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6788 * category.h: ... from here.
6789 * category.c (check_category_table, set_category_set): Now static.
6790
6791 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6792 * lisp.h: Remove these decls.
6793
6794 * buffer.c (buffer_count): Remove unused var.
6795
6796 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6797 so that it's not optimized away.
6798 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6799 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6800 exported only to the debugger.
6801
6802 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6803 * atimer.h (run_all_atimers): Remove; not exported.
6804
6805 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6806 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6807 was inaccessible from Lisp.
6808 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6809 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6810
6811 alloc.c: Import and export fewer symbols, and remove unused items.
6812 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6813 is defined.
6814 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6815 it's not optimized away by whole-program optimization.
6816 (message_enable_multibyte, free_misc): Remove.
6817 (catchlist, handlerlist, mark_backtrace):
6818 Declare only if BYTE_MARK_STACK.
6819 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6820 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6821 (message_enable_multibyte): Remove decl.
6822 (free_misc, interval_free_list, float_block, float_block_index):
6823 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6824 (cons_free_list, last_marked_index):
6825 Now static.
6826 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6827 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6828 (mark_backtrace): Define only if BYTE_MARK_STACK.
6829 * xdisp.c (message_enable_multibyte): Now static.
6830
6831 Declare Lisp_Object Q* variables to be 'static' if not exported.
6832 This makes it easier for human readers (and static analyzers)
6833 to see whether these variables are used from other modules.
6834 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6835 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6836 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6837 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6838 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6839 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6840 * xmenu.c, xselect.c:
6841 Declare Q* vars static if they are not used in other modules.
6842 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6843 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6844 Remove decls of unexported vars.
6845 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6846
6847 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6848
6849 Make Emacs functions such as Fatom 'static' by default.
6850 This makes it easier for human readers (and static analyzers)
6851 to see whether these functions can be called from other modules.
6852 DEFUN now defines a static function. To make the function external
6853 so that it can be used in other C modules, use the new macro DEFUE.
6854 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6855 (Finit_image_library):
6856 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6857 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6858 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6859 Remove decls, since these functions are now static.
6860 (Funintern, Fget_internal_run_time): New decls, since these functions
6861 were already external.
6862
6863 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6864 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6865 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6866 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6867 * keyboard.c, keymap.c, lread.c:
6868 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6869 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6870 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6871 Mark functions with DEFUE instead of DEFUN,
6872 if they are used in other modules.
6873 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6874 decls for now-static functions.
6875 * buffer.h (Fdelete_overlay): Remove decl.
6876 * callproc.c (Fgetenv_internal): Mark as internal.
6877 * composite.c (Fremove_list_of_text_properties): Remove decl.
6878 (Fcomposition_get_gstring): New forward static decl.
6879 * composite.h (Fcomposite_get_gstring): Remove decl.
6880 * dired.c (Ffile_attributes): New forward static decl.
6881 * doc.c (Fdocumntation_property): New forward static decl.
6882 * eval.c (Ffetch_bytecode): New forward static decl.
6883 (Funintern): Remove extern decl; now in .h file where it belongs.
6884 * fileio.c (Fmake_symbolic_link): New forward static decl.
6885 * image.c (Finit_image_library): New forward static decl.
6886 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6887 * intervals.h (Fprevious_property_change):
6888 (Fremove_list_of_text_properties): Remove decls.
6889 * keyboard.c (Fthis_command_keys): Remove decl.
6890 (Fcommand_execute): New forward static decl.
6891 * keymap.c (Flookup_key): New forward static decl.
6892 (Fcopy_keymap): Now static.
6893 * keymap.h (Flookup_key): Remove decl.
6894 * process.c (Fget_process): New forward static decl.
6895 (Fprocess_datagram_address): Mark as internal.
6896 * syntax.c (Fsyntax_table_p): New forward static decl.
6897 (skip_chars): Remove duplicate decl.
6898 * textprop.c (Fprevious_property_change): New forward static decl.
6899 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6900 Now internal.
6901 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6902 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6903
6904 * editfns.c (Fformat): Remove unreachable code.
6905
69062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6907
6908 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6909 change. (Bug#8496)
6910
69112011-04-13 Eli Zaretskii <eliz@gnu.org>
6912
6913 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6914 when at ZV. (Bug#8487)
6915
69162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6917
6918 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6919 (Bug#8437)
6920 * keyboard.c (parse_tool_bar_item): Likewise.
6921 * sound.c (sound_cleanup, alsa_close): Likewise.
6922 * termcap.c (tgetent): Likewise.
6923 * xfns.c (x_default_font_parameter): Likewise.
6924 * xsettings.c (read_and_apply_settings): Likewise.
6925
6926 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6927 (overrun_check_free): Protoize.
6928
69292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6930
6931 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6932 since callers should never pass a negative size.
6933 Change the signature to match that of plain 'read' and 'write'; see
6934 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6935 * lisp.h: Update prototypes of emacs_write and emacs_read.
6936
69372011-04-11 Eli Zaretskii <eliz@gnu.org>
6938
6939 * xdisp.c (redisplay_window): Don't try to determine the character
6940 position of the scroll margin if the window start point w->startp
6941 is outside the buffer's accessible region. (Bug#8468)
6942
69432011-04-10 Eli Zaretskii <eliz@gnu.org>
6944
6945 Fix write-region and its subroutines for buffers > 2GB.
6946 * fileio.c (a_write, e_write): Modify declaration of arguments and
6947 local variables to support buffers larger than 2GB.
6948 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6949
6950 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6951 argument, local variables, and return value.
6952
6953 * lisp.h: Update prototypes of emacs_write and emacs_read.
6954
6955 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6956
69572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6958
6959 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6960
6961 Fix more problems found by GCC 4.6.0's static checks.
6962
6963 * xdisp.c (vmessage): Use a better test for character truncation.
6964
6965 * charset.c (load_charset_map): <, not <=, for optimization,
6966 and to avoid potential problems with integer overflow.
6967 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6968 * casetab.c (set_identity, shuffle): Likewise.
6969 * editfns.c (Fformat): Likewise.
6970 * syntax.c (skip_chars): Likewise.
6971
6972 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6973 This also lets GCC 4.6.0 generate slightly better loop code.
6974
6975 * callint.c (Fcall_interactively): <, not <=, for optimization.
6976 (Fcall_interactively): Count the number of arguments produced,
6977 not the number of arguments given. This is simpler and lets GCC
6978 4.6.0 generate slightly better code.
6979
6980 * ftfont.c: Distingish more carefully between FcChar8 and char.
6981 The previous code passed unsigned char * to a functions like
6982 strlen and xstrcasecmp that expect char *, which does not
6983 conform to the C standard.
6984 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6985 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6986 char * when the C standard requires it.
6987
6988 * keyboard.c (read_char): Remove unused var.
6989
6990 * eval.c: Port to Windows vsnprintf (Bug#8435).
6991 Include <limits.h>.
6992 (SIZE_MAX): Define if the headers do not.
6993 (verror): Do not give up if vsnprintf returns a negative count.
6994 Instead, grow the buffer. This ports to Windows vsnprintf, which
6995 does not conform to C99. Problem reported by Eli Zaretskii.
6996 Also, simplify the allocation scheme, by avoiding the need for
6997 calling realloc, and removing the ALLOCATED variable.
6998
6999 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7000
7001 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7002 But keep the doprint source code for now, as we might revamp it
7003 and use it again (Bug#8435).
7004 * lisp.h (doprnt): Remove.
7005 * Makefile.in (base_obj): Remove doprnt.o.
7006 * deps.mk (doprnt.o): Remove.
7007
7008 error: Print 32- and 64-bit integers portably (Bug#8435).
7009 Without this change, on typical 64-bit hosts error ("...%d...", N)
7010 was used to print both 32- and 64-bit integers N, which relied on
7011 undefined behavior.
7012 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7013 New macro.
7014 * lisp.h (error, verror): Mark as printf-like functions.
7015 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7016 Report overflow in size calculations when allocating printf buffer.
7017 Do not truncate output string at its first null byte.
7018 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7019 Truncate the output at a character boundary, since vsnprintf does not
7020 do that.
7021 * charset.c (check_iso_charset_parameter): Convert internal
7022 character to string before calling 'error', since %c now has the
7023 printf meaning.
7024 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7025 overflow when computing char to be passed to 'error'. Do not
7026 pass Lisp_Object to 'error'; pass the integer instead.
7027 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7028 formatted with plain %d.
7029
7030 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7031
7032 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7033
7034 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7035
7036 * xterm.c (x_catch_errors): Remove duplicate declaration.
7037
7038 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7039
7040 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7041
70422011-04-10 Jim Meyering <meyering@redhat.com>
7043
7044 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7045 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7046 return ssize_t not "int", and use size_t as the buffer length.
7047 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7048 * gnutls.h: Update declarations.
7049 * process.c (read_process_output): Use ssize_t, to match.
7050 (send_process): Likewise.
7051
70522011-04-09 Chong Yidong <cyd@stupidchicken.com>
7053
7054 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7055
70562011-04-09 Chong Yidong <cyd@stupidchicken.com>
7057
7058 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7059 Use unsigned char, to match FcChar8 type definition.
7060
7061 * xterm.c (handle_one_xevent):
7062 * xmenu.c (create_and_show_popup_menu):
7063 * xselect.c (x_decline_selection_request)
7064 (x_reply_selection_request): Avoid type-punned deref of X events.
7065
70662011-04-09 Eli Zaretskii <eliz@gnu.org>
7067
7068 Fix some uses of `int' instead of EMACS_INT.
7069 * search.c (string_match_1, fast_string_match)
7070 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7071 (scan_buffer, find_next_newline_no_quit)
7072 (find_before_next_newline, search_command, Freplace_match)
7073 (Fmatch_data): Make some `int' variables be EMACS_INT.
7074
7075 * xdisp.c (display_count_lines): 3rd argument and return value now
7076 EMACS_INT. All callers changed.
7077 (pint2hrstr): Last argument is now EMACS_INT.
7078
7079 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7080 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7081 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7082 (decode_coding_utf_16, decode_coding_emacs_mule)
7083 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7084 (decode_coding_ccl, decode_coding_charset)
7085 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7086 (decode_coding_iso_2022, decode_coding_emacs_mule)
7087 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7088 <char_offset, last_offset>: Declare EMACS_INT.
7089 (encode_coding_utf_8, encode_coding_utf_16)
7090 (encode_coding_emacs_mule, encode_invocation_designation)
7091 (encode_designation_at_bol, encode_coding_iso_2022)
7092 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7093 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7094 Declare EMACS_INT.
7095 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7096 (encode_invocation_designation): Last argument P_NCHARS is now
7097 EMACS_INT.
7098 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7099 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7100
7101 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7102 All users changed.
7103
7104 * ccl.c (Fccl_execute_on_string): Declare some variables
7105 EMACS_INT.
7106
71072011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7108
7109 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7110
71112011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7112
7113 * process.c (Fformat_network_address): Doc fix.
7114
71152011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7116
7117 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7118
71192011-04-08 Chong Yidong <cyd@stupidchicken.com>
7120
7121 * keyboard.c (read_char): Call Lisp function help-form-show,
7122 instead of using internal_with_output_to_temp_buffer.
7123 (Qhelp_form_show): New var.
7124 (syms_of_keyboard): Use DEFSYM macro.
7125
7126 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7127
7128 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7129
71302011-04-06 Chong Yidong <cyd@stupidchicken.com>
7131
7132 * process.c (Flist_processes): Remove to Lisp.
7133 (list_processes_1): Delete.
7134
71352011-04-06 Eli Zaretskii <eliz@gnu.org>
7136
7137 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7138
7139 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7140
71412011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7142
7143 Fix more problems found by GCC 4.6.0's static checks.
7144
7145 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7146
7147 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7148
7149 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7150
7151 * xdisp.c (vmessage): Mark as a printf-like function.
7152
7153 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7154
7155 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7156
7157 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7158 printf-like functions.
7159 (tiff_load): Add casts to remove these marks before passing them
7160 to system-supplied API.
7161
7162 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7163
7164 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7165 This avoids several warnings with gcc -Wstrict-overflow.
7166 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7167 directly, rather than having caller test rule sign. This avoids
7168 some unnecessary tests.
7169 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7170 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7171 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7172
7173 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7174 (xfont_open): Avoid unnecessary tests.
7175
7176 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7177
7178 * composite.h, composite.c (composition_gstring_put_cache):
7179 Use EMACS_INT, not int, for length.
7180
7181 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7182 breaking out part of COMPOSITION_DECODE_RULE.
7183 (COMPOSITION_DECODE_RULE): Use it.
7184 * composite.c (get_composition_id): Remove unused local vars,
7185 by using the new macro.
7186
7187 * textprop.c (set_text_properties_1): Change while to do-while,
7188 since the condition is always true at first.
7189
7190 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7191 (interval_deletion_adjustment): Return unsigned value.
7192 All uses changed.
7193
7194 * process.c (list_processes_1, create_pty, read_process_output):
7195 (exec_sentinel): Remove vars that were set but not used.
7196 (create_pty): Remove unnecessary "volatile"s.
7197 (Fnetwork_interface_info): Avoid possibility of int overflow.
7198 (read_process_output): Do adaptive read buffering even if carryover.
7199 (read_process_output): Simplify nbytes computation if buffered.
7200
7201 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7202
7203 * syntax.c (scan_words): Remove var that was set but not used.
7204 (update_syntax_table): Use unsigned instead of int.
7205
7206 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7207 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7208 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7209
7210 * print.c (print_error_message): Avoid int overflow.
7211
7212 * font.c (font_list_entities): Redo for clarity,
7213 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7214
7215 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7216 (font_score): Avoid potential overflow in diff calculation.
7217
7218 * fns.c (substring_both): Remove var that is set but not used.
7219 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7220
7221 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7222
7223 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7224 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7225 can always succeed if overflow has undefined behavior.
7226
7227 * search.c (boyer_moore, wordify): Remove vars set but not used.
7228 (wordify): Omit three unnecessary tests.
7229
7230 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7231 All callers changed. This avoids the need for an unused var.
7232
7233 * casefiddle.c (casify_region): Remove var that is set but not used.
7234
7235 * dired.c (file_name_completion): Remove var that is set but not used.
7236
7237 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7238
7239 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7240 (Finsert_file_contents): Remove unnecessary code checking fd.
7241
7242 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7243 Check for integer overflow on size calculations.
7244
7245 * buffer.c (Fprevious_overlay_change): Remove var that is set
7246 but not used.
7247
7248 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7249 Remove vars that are set but not used.
7250 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7251 (timer_check_2): Mark vars as initialized.
7252
7253 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7254
7255 * image.c (lookup_image): Remove var that is set but not used.
7256 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7257
7258 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7259 that are set but not used.
7260
7261 * xfns.c (make_invisible_cursor): Don't return garbage
7262 if XCreateBitmapFromData fails (Bug#8410).
7263
7264 * xselect.c (x_get_local_selection, x_handle_property_notify):
7265 Remove vars that are set but not used.
7266
7267 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7268 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7269
7270 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7271 Remove var that is set but not used.
7272 (scroll_bar_windows_size): Now size_t, not int.
7273 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7274 Check for overflow.
7275
7276 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7277 (map_tty_color) [!defined MSDOS]: Likewise.
7278
7279 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7280
7281 * coding.c: Remove vars that are set but not used.
7282 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7283 All callers changed.
7284 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7285 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7286 (decode_coding_charset): Remove vars that are set but not used.
7287
7288 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7289 that is set but not used.
7290
7291 * print.c (print_object): Remove var that is set but not used.
7292
7293 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7294 The gnulib version avoids calling malloc in the usual case,
7295 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7296 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7297 * filelock.c (current_lock_owner): Likewise.
7298 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7299 * sysdep.c: Include allocator.h, careadlinkat.h.
7300 (emacs_no_realloc_allocator): New static constant.
7301 (emacs_readlink): New function.
7302 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7303 ../lib/careadlinkat.h.
7304
73052011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7306
7307 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7308 first non-nil return value).
7309
73102011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7311
7312 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7313 if not defined (Bug#8403).
7314
73152011-04-02 Juanma Barranquero <lekktu@gmail.com>
7316
7317 * xdisp.c (display_count_lines): Remove parameter `start',
7318 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7319 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7320 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7321 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7322 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7323 and thereabouts. All callers changed.
7324 (get_per_char_metric): Remove parameter `f', unused since
7325 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7326
73272011-04-02 Jim Meyering <meyering@redhat.com>
7328
7329 do not dereference NULL upon failed strdup
7330 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7331 (ns_get_family): Likewise.
7332
73332011-04-02 Juanma Barranquero <lekktu@gmail.com>
7334
7335 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7336
73372011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7338
7339 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7340 later (Bug#8403).
7341
73422011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7343
7344 Add lexical binding.
7345
7346 * window.c (Ftemp_output_buffer_show): New fun.
7347 (Fsave_window_excursion):
7348 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7349
7350 * lread.c (lisp_file_lexically_bound_p): New function.
7351 (Fload): Bind Qlexical_binding.
7352 (readevalloop): Remove `evalfun' arg.
7353 Bind Qinternal_interpreter_environment.
7354 (Feval_buffer): Bind Qlexical_binding.
7355 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7356 Mark as dynamic.
7357 (syms_of_lread): Declare `lexical-binding'.
7358
7359 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7360
7361 * keyboard.c (eval_dyn): New fun.
7362 (menu_item_eval_property): Use it.
7363
7364 * image.c (parse_image_spec): Use Ffunctionp.
7365
7366 * fns.c (concat, mapcar1): Accept byte-code-functions.
7367
7368 * eval.c (Fsetq): Handle lexical vars.
7369 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7370 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7371 (FletX, Flet): Obey lexical binding.
7372 (Fcommandp): Handle closures.
7373 (Feval): New `lexical' arg.
7374 (eval_sub): New function extracted from Feval. Use it almost
7375 everywhere where Feval was used. Look up vars in lexical env.
7376 Handle closures.
7377 (Ffunctionp): Move from subr.el.
7378 (Ffuncall): Handle closures.
7379 (apply_lambda): Remove `eval_flags'.
7380 (funcall_lambda): Handle closures and new byte-code-functions.
7381 (Fspecial_variable_p): New function.
7382 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7383 but without exporting it to Lisp.
7384
7385 * doc.c (Fdocumentation, store_function_docstring):
7386 * data.c (Finteractive_form): Handle closures.
7387
7388 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7389 interactive spec.
7390
7391 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7392 New byte-codes.
7393 (exec_byte_code): New function extracted from Fbyte_code to handle new
7394 calling convention for byte-code-functions. Add new byte-codes.
7395
7396 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7397
7398 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7399
74002011-03-31 Juanma Barranquero <lekktu@gmail.com>
7401
7402 * xdisp.c (redisplay_internal): Fix prototype.
7403
74042011-03-31 Eli Zaretskii <eliz@gnu.org>
7405
7406 * xdisp.c (SCROLL_LIMIT): New macro.
7407 (try_scrolling): Use it when setting scroll_limit.
7408 Limit scrolling to 100 screen lines.
7409 (redisplay_window): Even when falling back on "recentering",
7410 position point in the window according to scroll-conservatively,
7411 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7412
7413 (try_scrolling): When point is above the window, allow searching
7414 as far as scroll_max, or one screenful, to compute vertical
7415 distance from PT to the scroll margin position. This prevents
7416 try_scrolling from unnecessarily failing when
7417 scroll-conservatively is set to a value slightly larger than the
7418 window height. Clean up the case of PT below the margin at bottom
7419 of window: scroll_max can no longer be INT_MAX. When aggressive
7420 scrolling is in use, don't let point enter the opposite scroll
7421 margin as result of the scroll.
7422 (syms_of_xdisp) <scroll-conservatively>: Document the
7423 threshold of 100 lines for never-recentering scrolling.
7424
74252011-03-31 Juanma Barranquero <lekktu@gmail.com>
7426
7427 * dispextern.h (move_it_by_lines):
7428 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7429 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7430 (message_log_check_duplicate): Remove parameters `prev_bol' and
7431 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7432 (redisplay_internal): Remove parameter `preserve_echo_area',
7433 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7434
7435 * indent.c (Fvertical_motion):
7436 * window.c (window_scroll_pixel_based, Frecenter):
7437 Don't pass `need_y_p' to `move_it_by_lines'.
7438
74392011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7440
7441 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7442 steal a few bits to be more compact.
7443 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7444 Remove unneeded casts.
7445
7446 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7447
74482011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7449
7450 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7451 binding" message (bug#7967).
7452
74532011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7454
7455 Fix more problems found by GCC 4.6.0's static checks.
7456
7457 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7458 Remove unused local var.
7459
7460 * editfns.c (Fmessage_box): Remove unused local var.
7461
7462 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7463 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7464 Omit unused local vars.
7465 * window.c (shrink_windows): Omit unused local var.
7466 * menu.c (digest_single_submenu): Omit unused local var.
7467 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7468 Omit unused local var.
7469
7470 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7471 Don't assume string length fits in int.
7472 (keyremap_step, read_key_sequence): Use size_t for sizes.
7473 (read_key_sequence): Don't check last_real_key_start redundantly.
7474
7475 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7476 instead of alloca (Bug#8344).
7477
7478 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7479 (Fbacktrace_frame): Don't assume nframes fits in int.
7480
7481 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7482
7483 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7484 concerns.
7485
7486 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7487
7488 * cm.c (calccost): Turn while-do into do-while, for clarity.
7489
7490 * keyboard.c (syms_of_keyboard): Use the same style as later
7491 in this function when indexing through an array. This also
7492 works around GCC bug 48267.
7493
7494 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7495
7496 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7497
7498 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7499 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7500
7501 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7502 This avoids undefined behavior on integer overflow, and is a bit
7503 more convenient anyway since it is compared to a size_t variable.
7504
7505 Variadic C functions now count arguments with size_t, not int.
7506 This avoids an unnecessary limitation on 64-bit machines, which
7507 caused (substring ...) to crash on large vectors (Bug#8344).
7508 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7509 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7510 All variadic functions and their callers changed accordingly.
7511 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7512 * data.c (arith_driver, float_arith_driver): Likewise.
7513 * editfns.c (general_insert_function): Likewise.
7514 * eval.c (struct backtrace.nargs, interactive_p)
7515 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7516 (funcall_lambda, mark_backtrace): Likewise.
7517 * fns.c (concat): Likewise.
7518 * frame.c (x_set_frame_parameters): Likewise.
7519 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7520 0 if not found, not -1. All callers changed.
7521
7522 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7523 (stack_copy_size): Now size_t, not int.
7524 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7525
75262011-03-28 Juanma Barranquero <lekktu@gmail.com>
7527
7528 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7529 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7530 All callers changed.
7531
7532 * lisp.h (multibyte_char_to_unibyte):
7533 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7534 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7535 * character.h (CHAR_TO_BYTE8):
7536 * cmds.c (internal_self_insert):
7537 * editfns.c (general_insert_function):
7538 * keymap.c (push_key_description):
7539 * search.c (Freplace_match):
7540 * xdisp.c (message_dolog, set_message_1): All callers changed.
7541
75422011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7543
7544 * keyboard.c (safe_run_hook_funcall): New function.
7545 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7546 don't set the hook to nil, but remove the offending function instead.
7547 (Qcommand_hook_internal): Remove, unused.
7548 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7549 Vcommand_hook_internal.
7550
7551 * eval.c (enum run_hooks_condition): Remove.
7552 (funcall_nil, funcall_not): New functions.
7553 (run_hook_with_args): Call each function through a `funcall' argument.
7554 Remove `cond' argument, now redundant.
7555 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7556 (Frun_hook_with_args_until_failure): Adjust accordingly.
7557 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7558
75592011-03-28 Juanma Barranquero <lekktu@gmail.com>
7560
7561 * dispextern.h (string_buffer_position): Remove declaration.
7562
7563 * print.c (strout): Remove parameter `multibyte', unused since
7564 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7565
7566 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7567 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7568 All callers changed.
7569
7570 * w32.c (_wsa_errlist): Use braces for struct initializers.
7571
7572 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7573 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7574 All callers changed.
7575 (string_buffer_position): Likewise. Also, make static (it's never
7576 used outside xdisp.c).
7577 (cursor_row_p): Remove parameter `w', unused since
7578 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7579 (decode_mode_spec): Remove parameter `precision', introduced during
7580 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7581 All callers changed.
7582
75832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7584
7585 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7586
75872011-03-27 Anders Lindgren <andlind@gmail.com>
7588
7589 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7590 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7591 (ns_update_auto_hide_menu_bar): New functions.
7592 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7593 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7594 ns_constrain_all_frames.
7595 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7596 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7597
75982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7599
7600 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7601
76022011-03-27 Glenn Morris <rgm@gnu.org>
7603
7604 * syssignal.h: Replace RETSIGTYPE with void.
7605 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7606 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7607 Replace SIGTYPE with void everywhere.
7608 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7609 * s/template.h (SIGTYPE): Remove commented out definition.
7610
76112011-03-26 Eli Zaretskii <eliz@gnu.org>
7612
7613 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7614 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7615
76162011-03-26 Juanma Barranquero <lekktu@gmail.com>
7617
7618 * w32.c (read_unc_volume): Use parameter `henum', instead of
7619 global variable `wget_enum_handle'.
7620
7621 * keymap.c (describe_vector): Remove parameters `indices' and
7622 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7623 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7624
7625 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7626
7627 * keyboard.c (timer_check): Remove parameter `do_it_now',
7628 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7629 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7630 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7631
7632 * keyboard.c (read_char):
7633 * w32menu.c (w32_menu_display_help):
7634 * xmenu.c (show_help_event, menu_help_callback):
7635 Adjust calls to `show_help_echo'.
7636
7637 * gtkutil.c (xg_maybe_add_timer):
7638 * keyboard.c (readable_events):
7639 * process.c (wait_reading_process_output):
7640 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7641
7642 * insdel.c (adjust_markers_gap_motion):
7643 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7644 (gap_left, gap_right): Don't call it.
7645
76462011-03-25 Chong Yidong <cyd@stupidchicken.com>
7647
7648 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7649 incurred during fontification.
7650
76512011-03-25 Juanma Barranquero <lekktu@gmail.com>
7652
7653 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7654 (DEFVAR_PER_BUFFER): Don't pass it.
7655
7656 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7657 (scrolling_window): Don't pass it.
7658
76592011-03-25 Juanma Barranquero <lekktu@gmail.com>
7660
7661 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7662
7663 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7664 and `suffix'.
7665 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7666 of variables specific to SELinux and computation of `encoded_absname'.
7667
7668 * image.c (XPutPixel): Remove unused variable `height'.
7669
7670 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7671
7672 * unexw32.c (get_section_info): Remove unused variable `section'.
7673
7674 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7675 (system_process_attributes): Remove unused variable `sess'.
7676 (sys_read): Remove unused variable `err'.
7677
7678 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7679 (w32_wnd_proc): Remove unused variable `isdead'.
7680 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7681 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7682 (x_create_tip_frame): Remove unused variable `tem'.
7683
7684 * w32inevt.c (w32_console_read_socket):
7685 Remove unused variable `no_events'.
7686
7687 * w32term.c (x_draw_composite_glyph_string_foreground):
7688 Remove unused variable `width'.
7689
76902011-03-24 Juanma Barranquero <lekktu@gmail.com>
7691
7692 * w32term.c (x_set_glyph_string_clipping):
7693 Don't pass uninitialized region to CombineRgn.
7694
76952011-03-23 Juanma Barranquero <lekktu@gmail.com>
7696
7697 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7698 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7699 (Fx_close_connection): Remove unused variable `i'.
7700
7701 * w32font.c (w32font_draw): Return number of glyphs.
7702 (w32font_open_internal): Remove unused variable `i'.
7703 (w32font_driver): Add missing initializer.
7704
7705 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7706 (fill_in_menu): Remove unused variable `items_added'.
7707
7708 * w32term.c (last_mouse_press_frame): Remove static global variable.
7709 (w32_clip_to_row): Remove unused variable `f'.
7710 (x_delete_terminal): Remove unused variable `i'.
7711
7712 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7713 (NOTHING): Remove unused static global variable.
7714 (uniscribe_check_otf): Remove unused variable `table'.
7715 (uniscribe_font_driver): Add missing initializers.
7716
77172011-03-23 Julien Danjou <julien@danjou.info>
7718
7719 * term.c (Fsuspend_tty, Fresume_tty):
7720 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7721 * window.c (temp_output_buffer_show):
7722 * insdel.c (signal_before_change):
7723 * frame.c (Fhandle_switch_frame):
7724 * fileio.c (Fdo_auto_save):
7725 * emacs.c (Fkill_emacs):
7726 * editfns.c (save_excursion_restore):
7727 * cmds.c (internal_self_insert):
7728 * callint.c (Fcall_interactively):
7729 * buffer.c (Fkill_all_local_variables):
7730 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7731 Use Frun_hooks.
7732 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7733 unconditionnaly since it does the check itself.
7734
77352011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7736
7737 Fix more problems found by GCC 4.5.2's static checks.
7738
7739 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7740 the first time through the loop, since we know p0 < p1 then.
7741 This also avoids a gcc -Wstrict-overflow warning.
7742
7743 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7744 leading to a memory leak, possible in functions like
7745 load_charset_map_from_file that can allocate an unbounded number
7746 of objects (Bug#8318).
7747
7748 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7749 that could (at least in theory) be that large.
7750
7751 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7752 This is less likely to overflow, and avoids undefined behavior if
7753 overflow does occur. All callers changed. Use strtoul to scan
7754 for the unsigned long integer.
7755 (pint2hrstr): Simplify and tune code slightly.
7756 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7757
7758 * scroll.c (do_scrolling): Work around GCC bug 48228.
7759 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7760
7761 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7762 This also avoids a warning with gcc -Wstrict-overflow.
7763 (validate_x_resource_name): Simplify count usage.
7764 This also avoids a warning with gcc -Wstrict-overflow.
7765
7766 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7767 fail (Bug#8306).
7768
7769 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7770
7771 * process.c (Fmake_network_process): Use socklen_t, not int,
7772 where POSIX says socklen_t is required in portable programs.
7773 This fixes a porting bug on hosts like 64-bit HP-UX, where
7774 socklen_t is wider than int (Bug#8277).
7775 (Fmake_network_process, server_accept_connection):
7776 (wait_reading_process_output, read_process_output):
7777 Likewise.
7778
7779 * process.c: Rename or move locals to avoid shadowing.
7780 (list_processes_1, Fmake_network_process):
7781 (read_process_output_error_handler, exec_sentinel_error_handler):
7782 Rename or move locals.
7783 (Fmake_network_process): Define label "retry_connect" only if needed.
7784 (Fnetwork_interface_info): Fix pointer signedness.
7785 (process_send_signal): Add cast to avoid pointer signedness problem.
7786 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7787 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7788
7789 Make tparam.h and terminfo.c consistent.
7790 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7791 Include tparam.h instead, since it declares them.
7792 * cm.h (PC): Remove extern decl; tparam.h now does this.
7793 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7794 * terminfo.c: Include tparam.h, to check interfaces.
7795 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7796 (tparam): Adjust signature to match interface in tparam.h;
7797 this removes some undefined behavior. Check that outstring and len
7798 are zero, which they always are with Emacs.
7799 * tparam.h (PC, BC, UP): New extern decls.
7800
7801 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7802 (xftfont_open): Rename locals to avoid shadowing.
7803
7804 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7805 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7806 (OTF_TAG_SYM): Omit macro if not needed.
7807 (ftfont_list): Remove unused local.
7808 (get_adstyle_property, ftfont_pattern_entity):
7809 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7810 Rename locals to avoid shadowing.
7811
7812 * xfont.c (xfont_list_family): Mark var as initialized.
7813
7814 * xml.c (make_dom): Now static.
7815
7816 * composite.c (composition_compute_stop_pos): Rename local to
7817 avoid shadowing.
7818 (composition_reseat_it): Remove unused locals.
7819 (find_automatic_composition, composition_adjust_point): Likewise.
7820 (composition_update_it): Mark var as initialized.
7821 (find_automatic_composition): Mark vars as initialized,
7822 with a FIXME (Bug#8290).
7823
7824 character.h: Rename locals to avoid shadowing.
7825 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7826 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7827 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7828 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7829 to avoid shadowing.
7830
7831 * textprop.c (property_change_between_p): Remove; unused.
7832
7833 * intervals.c (interval_start_pos): Now static.
7834
7835 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7836
7837 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7838 Rename locals to avoid shadowing.
7839
7840 * sound.c (wav_play, au_play, Fplay_sound_internal):
7841 Fix pointer signedness.
7842 (alsa_choose_format): Remove unused local var.
7843 (wav_play): Initialize a variable to 0, to prevent undefined
7844 behavior (Bug#8278).
7845
7846 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7847
7848 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7849
7850 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7851 clobbering (Bug#8298).
7852 * sysdep.c (sys_subshell): Likewise.
7853 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7854
7855 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7856 This should get cleaned up, so that child_setup has the
7857 same signature on all platforms.
7858
7859 * callproc.c (call_process_cleanup): Now static.
7860 (relocate_fd): Rename locals to avoid shadowing.
7861
78622011-03-22 Chong Yidong <cyd@stupidchicken.com>
7863
7864 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7865 not to be necessary, and produces flickering.
7866
78672011-03-20 Glenn Morris <rgm@gnu.org>
7868
7869 * config.in: Remove file.
7870
78712011-03-20 Juanma Barranquero <lekktu@gmail.com>
7872
7873 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7874 are now in src/globals.h.
7875 (syms_of_minibuf): Remove spurious & from previous change.
7876
78772011-03-20 Leo <sdl.web@gmail.com>
7878
7879 * minibuf.c (completing-read-function): New variable.
7880 (completing-read-default): Rename from completing-read.
7881 (completing-read): Call completing-read-function.
7882
78832011-03-19 Juanma Barranquero <lekktu@gmail.com>
7884
7885 * xfaces.c (Fx_load_color_file):
7886 Read color file from absolute filename (bug#8250).
7887
78882011-03-19 Juanma Barranquero <lekktu@gmail.com>
7889
7890 * makefile.w32-in: Update dependencies.
7891
78922011-03-17 Eli Zaretskii <eliz@gnu.org>
7893
7894 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7895
78962011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7897
7898 Fix more problems found by GCC 4.5.2's static checks.
7899
7900 * process.c (make_serial_process_unwind, send_process_trap):
7901 (sigchld_handler): Now static.
7902
7903 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7904 That way, the code declares only the vars that it needs.
7905 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7906 * s/cygwin.h (PTY_ITERATION): Likewise.
7907 * s/darwin.h (PTY_ITERATION): Likewise.
7908 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7909
7910 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7911 * process.c (allocate_pty): Don't declare stb unless it's needed.
7912
7913 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7914 (CONSTANTLIM): Remove; unused.
7915 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7916 Define only if needed.
7917
7918 * unexelf.c (unexec): Name an expression,
7919 to avoid gcc -Wbad-function-cast warning.
7920 Use a different way to cause a compilation error if anyone uses
7921 n rather than nn, a way that does not involve shadowing.
7922 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7923
7924 * deps.mk (unexalpha.o): Remove; unused.
7925
7926 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7927 * unexec.h: New file.
7928 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7929 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7930 Depend on unexec.h.
7931 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7932 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7933 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7934 Change as necessary to match prototype in unexec.h.
7935
7936 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7937 shadowing.
7938 (back_comment, skip_chars): Mark vars as initialized.
7939
7940 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7941 Rename locals to avoid shadowing.
7942
7943 * lread.c (read1): Rewrite so as not to use empty "else".
7944 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7945
7946 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7947
7948 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7949 warning when compiling print.c.
7950
7951 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7952 instead of using an uninitialized var.
7953 (font_sort_entities): Mark var as initialized.
7954
7955 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7956
7957 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7958 pointers to constants.
7959 (font_parse_fcname): Remove unused vars.
7960 (font_delete_unmatched): Now static.
7961 (font_get_spec): Remove; unused.
7962 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7963 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7964 Rename or move locals to avoid shadowing.
7965
7966 * fns.c (require_nesting_list, require_unwind): Now static.
7967 (Ffillarray): Rename locals to avoid shadowing.
7968
7969 * floatfns.c (domain_error2): Define only if needed.
7970 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7971
7972 * alloc.c (mark_backtrace): Move decl from here ...
7973 * lisp.h: ... to here, so that it can be checked.
7974
7975 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7976 (Fdefvar): Rewrite so as not to use empty "else".
7977 (lisp_indirect_variable): Name an expression,
7978 to avoid gcc -Wbad-function-cast warning.
7979 (Fdefvar): Rename locals to avoid shadowing.
7980
7981 * callint.c (quotify_arg, quotify_args): Now static.
7982 (Fcall_interactively): Rename locals to avoid shadowing.
7983 Use const pointer when appropriate.
7984
7985 * lisp.h (get_system_name, get_operating_system_release):
7986 Move decls here, to check interfaces.
7987 * process.c (get_operating_system_release): Move decl to lisp.h.
7988 * xrdb.c (get_system_name): Likewise.
7989 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7990 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7991 some of which prompt warnings from gcc -Wbad-function-cast.
7992 (Fformat_time_string, Fencode_time, Finsert_char):
7993 (Ftranslate_region_internal, Fformat):
7994 Rename or remove local vars to avoid shadowing.
7995 (Ftranslate_region_internal): Mark var as initialized.
7996
7997 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7998 avoid shadowing.
7999
8000 * lisp.h (eassert): Check that the argument compiles, even if
8001 ENABLE_CHECKING is not defined.
8002
8003 * data.c (Findirect_variable): Name an expression, to avoid
8004 gcc -Wbad-function-cast warning.
8005 (default_value, arithcompare, arith_driver, arith_error): Now static.
8006 (store_symval_forwarding): Rename local to avoid shadowing.
8007 (Fmake_variable_buffer_local, Fmake_local_variable):
8008 Mark variables as initialized.
8009 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8010
8011 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8012 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8013 Rename locals to avoid shadowing.
8014 (mark_stack): Move local variables into the #ifdef region where
8015 they're used.
8016 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8017 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8018 needed otherwise.
8019 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8020 (GC_STRING_CHARS): Remove; not used.
8021 (Fmemory_limit): Cast sbrk's returned value to char *.
8022
8023 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8024 avoids undefined behavior in theory.
8025
8026 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8027
8028 Use functions, not macros, for up- and down-casing (Bug#8254).
8029 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8030 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8031 to use the following functions instead of these macros.
8032 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8033 EMACS_INT, since callers assume the returned value fits in int.
8034 (upcase1): Likewise, for UPCASE_TABLE.
8035 (uppercasep, lowercasep, upcase): New static inline functions.
8036 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8037 the race-condition problem in the old DOWNCASE.
8038
8039 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8040 Rename locals to avoid shadowing.
8041 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8042 (regex_compile, re_search_2, re_match_2_internal):
8043 Remove unused local vars.
8044 (FREE_VAR): Rewrite so as not to use empty "else",
8045 which gcc can warn about.
8046 (regex_compile, re_match_2_internal): Mark locals as initialized.
8047 (RETALLOC_IF): Define only if needed.
8048 (WORDCHAR_P): Likewise. This one is never needed, but is used
8049 only in a comment talking about a compiler bug, so put inside
8050 the #if 0 of that comment.
8051 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8052 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8053 Remove; unused.
8054
8055 * search.c (boyer_moore): Rename locals to avoid shadowing.
8056 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8057 (PREV_CHAR_BOUNDARY): Likewise.
8058
8059 * search.c (simple_search): Remove unused var.
8060
8061 * dired.c (compile_pattern): Move decl from here ...
8062 * lisp.h: ... to here, so that it can be checked.
8063 (struct re_registers): New forward decl.
8064
8065 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8066
8067 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8068 All uses changed.
8069 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8070 Rename locals to avoid shadowing.
8071 (Fvertical_motion): Mark locals as initialized.
8072
8073 * casefiddle.c (casify_object, casify_region): Now static.
8074 (casify_region): Mark local as initialized.
8075
8076 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8077
8078 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8079 New macros, so that the caller can use some names other than
8080 gcpro1, gcpro2, etc.
8081 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8082 of the new macros.
8083 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8084 argument, for consistency with GCPRO2_VAR, etc: it is now the
8085 prefix of the variable, not the variable itself. All uses
8086 changed.
8087 * dired.c (directory_files_internal, file_name_completion):
8088 Rename locals to avoid shadowing.
8089
8090 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8091 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8092 dired.c's scmp function, had undefined behavior.
8093 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8094 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8095 * buffer.h: ... to here, because these macros use current_buffer,
8096 and the new implementation with inline functions needs to have
8097 current_buffer in scope now, rather than later when the macros
8098 are used.
8099 (downcase, upcase1): New static inline functions.
8100 (DOWNCASE, UPCASE1): Reimplement using these functions.
8101 This avoids undefined behavior in expressions like
8102 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8103 from race conditions in accessing the global variables
8104 case_temp1 and case_temp2.
8105 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8106 * lisp.h (case_temp1, case_temp2): Remove their decls.
8107 * character.h (ASCII_CHAR_P): Move from here ...
8108 * lisp.h: ... to here, so that the inline functions mentioned
8109 above can use them.
8110
8111 * dired.c (directory_files_internal_unwind): Now static.
8112
8113 * fileio.c (file_name_as_directory, directory_file_name):
8114 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8115 Now static.
8116 (file_name_as_directory): Use const pointers when appropriate.
8117 (Fexpand_file_name): Likewise. In particular, newdir might
8118 point at constant storage, so make it a const pointer.
8119 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8120 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8121 signedness issues.
8122 (Fset_file_times, Finsert_file_contents, auto_save_error):
8123 Rename locals to avoid shadowing.
8124
8125 * minibuf.c (choose_minibuf_frame_1): Now static.
8126 (Ftry_completion, Fall_completions): Rename or remove locals
8127 to avoid shadowing.
8128
8129 * marker.c (bytepos_to_charpos): Remove; unused.
8130
8131 * lisp.h (verify_bytepos, count_markers): New decls,
8132 so that gcc does not warn that these functions aren't declared.
8133
8134 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8135 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8136 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8137 (copy_text): Remove unused local var.
8138
8139 * filelock.c (within_one_second): Now static.
8140 (lock_file_1): Rename local to avoid shadowing.
8141
8142 * buffer.c (fix_overlays_before): Mark locals as initialized.
8143 (fix_start_end_in_overlays): Likewise. This function should be
8144 simplified by using pointers-to-pointers, but that's a different
8145 matter.
8146 (switch_to_buffer_1): Now static.
8147 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8148 (report_overlay_modification): Rename locals to avoid shadowing.
8149
8150 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8151 Fix pointer signedness issue.
8152 (sys_subshell): Mark local as volatile if checking for lint,
8153 to suppress a gcc -Wclobbered warning that does not seem to be right.
8154 (MAXPATHLEN): Define only if needed.
8155
8156 * process.c (serial_open, serial_configure): Move decls from here ...
8157 * systty.h: ... to here, so that they can be checked.
8158
8159 * fns.c (get_random, seed_random): Move extern decls from here ...
8160 * lisp.h: ... to here, so that they can be checked.
8161
8162 * sysdep.c (reset_io): Now static.
8163 (wait_for_termination_signal): Remove; unused.
8164
8165 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8166 (copy_keymap_item, append_key, push_text_char_description):
8167 Now static.
8168 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8169 (DENSE_TABLE_SIZE): Remove; unused.
8170 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8171 (describe_map_tree):
8172 Rename locals to avoid shadowing.
8173
8174 * keyboard.c: Declare functions static if they are not used elsewhere.
8175 (echo_char, echo_dash, cmd_error, top_level_2):
8176 (poll_for_input, handle_async_input): Now static.
8177 (read_char, kbd_buffer_get_event, make_lispy_position):
8178 (make_lispy_event, make_lispy_movement, apply_modifiers):
8179 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8180 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8181 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8182 (read_key_sequence, read_char): Mark locals as initialized.
8183 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8184
8185 * keyboard.h (make_ctrl_char): New decl.
8186 (mark_kboards): Move decl here ...
8187 * alloc.c (mark_kboards): ... from here.
8188
8189 * lisp.h (force_auto_save_soon): New decl.
8190
8191 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8192 (DEFINE_DUMMY_FUNCTION): New macro.
8193 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8194 Use it.
8195 (main): Add casts to avoid warnings
8196 if GCC considers string literals to be constants.
8197
8198 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8199
8200 * dbusbind.c: Pointer signedness fixes.
8201 (xd_signature, xd_append_arg, xd_initialize):
8202 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8203 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8204 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8205 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8206
8207 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8208 if GCC considers string literals to be constants.
8209 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8210
82112011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8212
8213 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8214 (print_preprocess, print_object): New macro to fix last change.
8215
8216 * print.c (print_preprocess): Don't forget font objects.
8217
82182011-03-16 Juanma Barranquero <lekktu@gmail.com>
8219
8220 * emacs.c (USAGE3): Doc fixes.
8221
82222011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8223
8224 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8225 structure.
8226
82272011-03-14 Juanma Barranquero <lekktu@gmail.com>
8228
8229 * lisp.h (VWindow_system, Qfile_name_history):
8230 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8231 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8232 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8233
8234 * w32select.c: Don't #include "keyboard.h".
8235 (run_protected): Add extern declaration for waiting_for_input.
8236
8237 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8238 * w32console.c (detect_input_pending, read_input_pending)
8239 (encode_terminal_code):
8240 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8241 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8242 (w32_system_caret_y, Qfile_name_history):
8243 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8244 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8245 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8246 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8247 * w32proc.c (Qlocal, report_file_error):
8248 * w32term.c (Vwindow_system, updating_frame):
8249 * w32uniscribe.c (initialized, uniscribe_font_driver):
8250 Remove unneeded extern declarations.
8251
82522011-03-14 Chong Yidong <cyd@stupidchicken.com>
8253
8254 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8255
82562011-03-13 Chong Yidong <cyd@stupidchicken.com>
8257
8258 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8259 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8260 These macros can no longer be used for assignment.
8261
8262 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8263 Assign struct members directly, instead of using BUF_BEGV etc.
8264 (record_buffer_markers, fetch_buffer_markers): New functions for
8265 recording and fetching special buffer markers.
8266 (set_buffer_internal_1, set_buffer_temp): Use them.
8267
8268 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8269
8270 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8271
8272 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8273 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8274
8275 * xdisp.c (hscroll_window_tree):
8276 (reconsider_clip_changes): Use PT instead of BUF_PT.
8277
82782011-03-13 Eli Zaretskii <eliz@gnu.org>
8279
8280 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8281 $(EMACS_ROOT)/lib/intprops.h.
8282
82832011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8284
8285 Fix more problems found by GCC 4.5.2's static checks.
8286
8287 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8288 to unsigned char * to avoid compiler diagnostic.
8289 (xg_free_frame_widgets): Make it clear that a local variable is
8290 needed only if USE_GTK_TOOLTIP.
8291 (gdk_window_get_screen): Make it clear that this macro is needed
8292 only if USE_GTK_TOOLTIP.
8293 (int_gtk_range_get_value): New function, which avoids a diagnostic
8294 from gcc -Wbad-function-cast.
8295 (xg_set_toolkit_scroll_bar_thumb): Use it.
8296 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8297 diagnostic from gcc -Wbad-function-cast.
8298 (get_utf8_string, xg_get_file_with_chooser):
8299 Rename locals to avoid shadowing.
8300 (create_dialog): Move locals to avoid shadowing.
8301
8302 * xgselect.c (xg_select): Remove unused var.
8303
8304 * image.c (four_corners_best): Mark locals as initialized.
8305 (gif_load): Initialize transparent_p to zero (Bug#8238).
8306 Mark another local as initialized.
8307 (my_png_error, my_error_exit): Mark with NO_RETURN.
8308
8309 * image.c (clear_image_cache): Now static.
8310 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8311 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8312 (x_edge_detection): Remove unnecessary cast that
8313 gcc -Wbad-function-cast diagnoses.
8314 (gif_load): Fix pointer signedness.
8315 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8316 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8317
83182011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8319
8320 Improve quality of tests for time stamp overflow.
8321 For example, without this patch (encode-time 0 0 0 1 1
8322 1152921504606846976) returns the obviously-bogus value (-948597
8323 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8324 reports time overflow. See
8325 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8326 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8327 * editfns.c: Include limits.h and intprops.h.
8328 (TIME_T_MIN, TIME_T_MAX): New macros.
8329 (time_overflow): Move earlier, to before first use.
8330 (hi_time, lo_time): New functions, for an accurate test for
8331 out-of-range times.
8332 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8333 (Fget_internal_run_time): Don't assume time_t fits in int.
8334 (make_time): Use list2 instead of Fcons twice.
8335 (Fdecode_time): More accurate test for out-of-range times.
8336 (check_tm_member): New function.
8337 (Fencode_time): Use it, to test for out-of-range times.
8338 (lisp_time_argument): Don't rely on undefined left-shift and
8339 right-shift behavior when checking for time stamp overflow.
8340
8341 * editfns.c (time_overflow): New function, refactoring common code.
8342 (Fformat_time_string, Fdecode_time, Fencode_time):
8343 (Fcurrent_time_string): Use it.
8344
8345 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8346 * dired.c (make_time): Move to ...
8347 * editfns.c (make_time): ... here.
8348 * systime.h: Note the move.
8349
83502011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8351
8352 * fringe.c (update_window_fringes): Remove unused variables.
8353
8354 * unexmacosx.c (copy_data_segment): Also copy __got section.
8355 (Bug#8223)
8356
83572011-03-12 Eli Zaretskii <eliz@gnu.org>
8358
8359 * termcap.c [MSDOS]: Include "msdos.h".
8360 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8361 Constify `char *' arguments and their references according to
8362 prototypes in tparam.h.
8363
8364 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8365
8366 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8367 Adapt all references accordingly.
8368
8369 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8370
83712011-03-11 Tom Tromey <tromey@redhat.com>
8372
8373 * buffer.c (syms_of_buffer): Remove obsolete comment.
8374
83752011-03-11 Eli Zaretskii <eliz@gnu.org>
8376
8377 * termhooks.h (encode_terminal_code): Declare prototype.
8378
8379 * msdos.c (encode_terminal_code): Don't declare prototype.
8380
8381 * term.c (encode_terminal_code): Now external again, used by
8382 w32console.c and msdos.c.
8383
8384 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8385 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8386
83872011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8388
8389 Fix some minor problems found by GCC 4.5.2's static checks.
8390
8391 * fringe.c (update_window_fringes): Mark locals as initialized
8392 (Bug#8227).
8393 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8394
8395 * alloc.c (mark_fringe_data): Move decl from here ...
8396 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8397 to check its interface.
8398 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8399
8400 * fontset.c (free_realized_fontset): Now static.
8401 (Fset_fontset_font): Rename local to avoid shadowing.
8402 (fontset_font): Mark local as initialized.
8403 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8404
8405 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8406
8407 * xselect.c (x_disown_buffer_selections): Remove; not used.
8408 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8409 (x_own_selection, Fx_disown_selection_internal): Rename locals
8410 to avoid shadowing.
8411 (x_handle_dnd_message): Remove local to avoid shadowing.
8412
8413 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8414 so that the caller can use some name other than gcpro1.
8415 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8416 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8417 (Fx_backspace_delete_keys_p):
8418 Use them to avoid shadowing, and rename vars to avoid shadowing.
8419 (x_decode_color, x_set_name, x_window): Now static.
8420 (Fx_create_frame): Add braces to silence GCC warning.
8421 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8422 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8423 Remove unused locals.
8424 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8425 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8426 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8427 macros.
8428
8429 * xterm.h (x_mouse_leave): New decl.
8430
8431 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8432 Remove unused functions.
8433 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8434 (x_calc_absolute_position): Now static.
8435 (XTread_socket): Don't define label "out" unless it's used.
8436 Don't declare local "event" unless it's used.
8437 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8438 unless they are used.
8439 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8440 (x_fatal_error_signal): Remove; not used.
8441 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8442 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8443 (x_error_catcher, x_connection_closed, x_error_handler):
8444 (x_error_quitter, xembed_send_message, x_iconify_frame):
8445 (my_log_handler): Rename locals to avoid shadowing.
8446 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8447 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8448
8449 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8450 Rename or move locals to avoid shadowing.
8451 (tty_defined_color, merge_face_heights): Now static.
8452 (free_realized_faces_for_fontset): Remove; not used.
8453 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8454 does not deduce is never used uninitialized.
8455 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8456 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8457
8458 * terminal.c (store_terminal_param): Now static.
8459
8460 * xmenu.c (menu_highlight_callback): Now static.
8461 (set_frame_menubar): Remove unused local.
8462 (xmenu_show): Rename parameter to avoid shadowing.
8463 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8464 since they might point to immutable storage.
8465 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8466 since it's unused otherwise.
8467
8468 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8469 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8470 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8471 avoids a gcc -Wuninitialized diagnostic.
8472 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8473 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8474 does not deduce are never used uninitialized.
8475
8476 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8477
8478 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8479 * window.c (window_loop, size_window):
8480 (run_window_configuration_change_hook, enlarge_window): Likewise.
8481
8482 * window.c (display_buffer): Now static.
8483 (size_window): Mark variables that gcc -Wuninitialized
8484 does not deduce are never used uninitialized.
8485 * window.h (check_all_windows): New decl, to forestall
8486 gcc -Wmissing-prototypes diagnostic.
8487 * dispextern.h (bidi_dump_cached_states): Likewise.
8488
8489 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8490 shadowing.
8491 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8492 Include <limits.h>.
8493 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8494 and to avoid gcc -Wuninitialized warning.
8495 (load_charset_map): Mark variables that gcc -Wuninitialized
8496 does not deduce are never used uninitialized.
8497 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8498
8499 * coding.c (coding_set_source, coding_set_destination):
8500 Use "else { /* comment */ }" rather than "else /* comment */;"
8501 for clarity, and to avoid gcc -Wempty-body warning.
8502 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8503 a block, when the outer 'i' will do.
8504 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8505 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8506 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8507 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8508 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8509 Rename locals to avoid shadowing.
8510 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8511 * coding.c (emacs_mule_char, encode_invocation_designation):
8512 Now static, since they're not used elsewhere.
8513 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8514 (decode_coding_object, encode_coding_object, detect_coding_system):
8515 (decode_coding_emacs_mule): Mark variables that gcc
8516 -Wuninitialized does not deduce are never used uninitialized.
8517 (detect_coding_iso_2022): Initialize a local variable that might
8518 be used uninitialized. Leave a FIXME because it's not clear that
8519 this initialization is needed. (Bug#8211)
8520 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8521 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8522 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8523 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8524 Remove unused macros.
8525
8526 * category.c (hash_get_category_set): Remove unused local var.
8527 (copy_category_table): Now static, since it's not used elsewhere.
8528 * character.c (string_count_byte8): Likewise.
8529
8530 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8531 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8532
8533 * chartab.c (copy_sub_char_table): Now static, since it's not used
8534 elsewhere.
8535 (sub_char_table_ref_and_range, char_table_ref_and_range):
8536 Rename locals to avoid shadowing.
8537 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8538
8539 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8540 (BIDI_BOB): Remove unused macro.
8541
8542 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8543 deduce are never used uninitialized.
8544 * term.c (encode_terminal_code): Likewise.
8545
8546 * term.c (encode_terminal_code): Now static. Remove unused local.
8547
8548 * tparam.h: New file.
8549 * term.c, tparam.h: Include it.
8550 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8551 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8552 Move these decls to tparam.h, and make them agree with what
8553 is actually in tparam.c. The previous trick of using incompatible
8554 decls in different modules does not conform to the C standard.
8555 All callers of tparam changed to use tparam's actual API.
8556 * tparam.c (tparam1, tparam, tgoto):
8557 Use const pointers where appropriate.
8558
8559 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8560 * cm.h (struct cm): Likewise.
8561 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8562 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8563 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8564 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8565 (turn_on_face, init_tty): Likewise.
8566 * termchar.h (struct tty_display_info): Likewise.
8567
8568 * term.c (term_mouse_position): Rename local to avoid shadowing.
8569
8570 * alloc.c (mark_ttys): Move decl from here ...
8571 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8572
85732011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8574
8575 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8576
85772011-03-09 Juanma Barranquero <lekktu@gmail.com>
8578
8579 * search.c (compile_pattern_1): Remove argument regp, unused since
8580 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8581 (compile_pattern): Don't pass it.
8582
85832011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8584
8585 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8586 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8587 for ! HAVE_GTK3.
8588 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8589
8590 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8591
8592 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8593 gdk_window_get_screen, gdk_window_get_geometry,
8594 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8595 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8596 (xg_get_pixbuf_from_pixmap): New function.
8597 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8598 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8599 Call xg_get_pixbuf_from_pixmap instead of
8600 gdk_pixbuf_get_from_drawable.
8601 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8602 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8603 (xg_check_special_colors): Use GtkStyleContext and its functions
8604 for HAVE_GTK3.
8605 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8606 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8607 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8608 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8609 Call gtk_widget_get_preferred_size.
8610 (xg_frame_resized): gdk_window_get_geometry only takes 5
8611 parameters.
8612 (xg_win_to_widget, xg_event_is_for_menubar):
8613 Call gdk_x11_window_lookup_for_display.
8614 (xg_set_widget_bg): New function.
8615 (delete_cb): New function.
8616 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8617 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8618 (xg_set_background_color): Call xg_set_widget_bg.
8619 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8620 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8621 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8622 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8623 if ! HAVE_GTK3.
8624 (update_frame_tool_bar): Call gtk_widget_hide.
8625 (xg_initialize): Use GDK_KEY_g.
8626
8627 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8628 if ! HAVE_GTK3
8629 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8630
8631 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8632 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8633 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8634
86352011-03-08 Juanma Barranquero <lekktu@gmail.com>
8636
8637 * w32xfns.c (select_palette): Check success of RealizePalette against
8638 GDI_ERROR, not zero.
8639
8640See ChangeLog.11 for earlier changes.
8641
8642;; Local Variables:
8643;; coding: utf-8
8644;; End:
8645
8646 Copyright (C) 2011 Free Software Foundation, Inc.
8647
8648 This file is part of GNU Emacs.
8649
8650 GNU Emacs is free software: you can redistribute it and/or modify
8651 it under the terms of the GNU General Public License as published by
8652 the Free Software Foundation, either version 3 of the License, or
8653 (at your option) any later version.
8654
8655 GNU Emacs is distributed in the hope that it will be useful,
8656 but WITHOUT ANY WARRANTY; without even the implied warranty of
8657 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8658 GNU General Public License for more details.
8659
8660 You should have received a copy of the GNU General Public License
8661 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.