tests/bad_noputm1

   1 diff -u -p -b a/arch/sparc64/kernel/isa.c b/arch/sparc64/kernel/isa.c
   2 OK send
   3 --- a/arch/sparc64/kernel/isa.c 2007-08-12 13:27:06.000000000 +0200
   4 +++ b/arch/sparc64/kernel/isa.c 2007-11-18 18:32:16.000000000 +0100
   5 @@ -155,6 +155,7 @@ void __init isa_init(void)
   6                 isa_br = kzalloc(sizeof(*isa_br), GFP_KERNEL);
   7                 if (!isa_br) {
   8                         printk(KERN_DEBUG "isa: cannot allocate sparc_isa_bridge");
   9 +                       pci_dev_put(pdev);
  10                         return;
  11                 }
  12
  13 @@ -168,6 +169,7 @@ void __init isa_init(void)
  14                         printk(KERN_DEBUG "isa: device registration error for %s!\n",
  15                                dp->path_component_name);
  16                         kfree(isa_br);
  17 +                       pci_dev_put(pdev);
  18                         return;
  19                 }
  20
  21 diff -u -p -b a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
  22 --- a/drivers/char/agp/amd64-agp.c 2007-11-01 10:30:39.000000000 +0100
  23 +++ b/drivers/char/agp/amd64-agp.c 2007-11-18 18:32:36.000000000 +0100
  24 NOT SURE
  25 @@ -771,6 +771,7 @@ int __init agp_amd64_init(void)
  26                         /* Only one bridge supported right now */
  27                         if (agp_amd64_probe(dev, NULL) == 0) {
  28                                 err = 0;
  29 +                               pci_dev_put(dev);
  30                                 break;
  31                         }
  32                 }
  33 diff -u -p -b a/drivers/char/applicom.c b/drivers/char/applicom.c
  34 --- a/drivers/char/applicom.c 2006-11-30 19:04:20.000000000 +0100
  35 +++ b/drivers/char/applicom.c 2007-11-18 18:32:39.000000000 +0100
  36 @@ -204,7 +204,9 @@ static int __init applicom_init(void)
  37                         continue;
  38
  39                 if (pci_enable_device(dev))
  40 -                       return -EIO;
  41 +                       {
  42 +                       pci_dev_put(dev);
  43 +                       return -EIO;}
  44
  45                 RamIO = ioremap(dev->resource[0].start, LEN_RAM_IO);
  46
  47 @@ -213,6 +215,7 @@ static int __init applicom_init(void)
  48                                 "space at 0x%llx\n",
  49                                 (unsigned long long)dev->resource[0].start);
  50                         pci_disable_device(dev);
  51 +                       pci_dev_put(dev);
  52                         return -EIO;
  53                 }
  54
  55 diff -u -p -b a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
  56 --- a/drivers/macintosh/via-pmu.c 2007-10-22 11:25:10.000000000 +0200
  57 +++ b/drivers/macintosh/via-pmu.c 2007-11-18 18:33:24.000000000 +0100
  58 OK sent
  59 @@ -1897,7 +1897,9 @@ pbook_pci_restore(void)
  60                 pci_write_config_dword(pd, 4, ps->config[1]);
  61  #else
  62                 if (npci-- == 0)
  63 -                       return;
  64 +                       {
  65 +                       pci_dev_put(pd);
  66 +                       return;}
  67                 ps++;
  68                 if (ps->command == 0)
  69                         continue;
  70 diff -u -p -b a/drivers/mmc/host/ricoh_mmc.c b/drivers/mmc/host/ricoh_mmc.c
  71 --- a/drivers/mmc/host/ricoh_mmc.c 2007-11-18 16:56:19.000000000 +0100
  72 +++ b/drivers/mmc/host/ricoh_mmc.c 2007-11-18 18:33:44.000000000 +0100
  73 @@ -68,6 +68,7 @@ static int __devinit ricoh_mmc_probe(str
  74                         if (disable & 0x02) {
  75                                 printk(KERN_INFO DRIVER_NAME
  76                                        ": Controller already disabled. Nothing to do.\n");
  77 +                               pci_dev_put(fw_dev);
  78                                 return -ENODEV;
  79                         }
  80
  81 @@ -81,6 +82,7 @@ static int __devinit ricoh_mmc_probe(str
  82                         printk(KERN_INFO DRIVER_NAME
  83                                ": Controller is now disabled.\n");
  84
  85 +                       pci_dev_put(fw_dev);
  86                         break;
  87                 }
  88         }
  89 diff -u -p -b a/drivers/net/s2io.c b/drivers/net/s2io.c
  90 --- a/drivers/net/s2io.c 2007-11-15 15:09:36.000000000 +0100
  91 +++ b/drivers/net/s2io.c 2007-11-18 18:34:15.000000000 +0100
  92 BIZARRE submitted
  93 @@ -983,6 +983,7 @@ static int s2io_on_nec_bridge(struct pci
  94                 if (tdev->vendor == NEC_VENID && tdev->device == NEC_DEVID) {
  95                         if (tdev->bus == s2io_pdev->bus->parent)
  96                                 pci_dev_put(tdev);
  97 +                               pci_dev_put(tdev);
  98                                 return 1;
  99                 }
 100         }
 101 diff -u -p -b a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
 102 OK sent
 103 --- a/drivers/pci/pci-sysfs.c 2007-07-20 17:45:56.000000000 +0200
 104 +++ b/drivers/pci/pci-sysfs.c 2007-11-18 18:34:41.000000000 +0100
 105 @@ -703,7 +703,9 @@ static int __init pci_sysfs_init(void)
 106         for_each_pci_dev(pdev) {
 107                 retval = pci_create_sysfs_dev_files(pdev);
 108                 if (retval)
 109 -                       return retval;
 110 +                       {
 111 +                       pci_dev_put(pdev);
 112 +                       return retval;}
 113         }
 114
 115         return 0;
 116 diff -u -p -b a/drivers/pnp/resource.c b/drivers/pnp/resource.c
 117 OK sent
 118 --- a/drivers/pnp/resource.c 2007-10-22 11:25:20.000000000 +0200
 119 +++ b/drivers/pnp/resource.c 2007-11-18 18:34:46.000000000 +0100
 120 @@ -368,7 +368,9 @@ int pnp_check_irq(struct pnp_dev *dev, i
 121                 struct pci_dev *pci = NULL;
 122                 for_each_pci_dev(pci) {
 123                         if (pci->irq == *irq)
 124 -                               return 0;
 125 +                               {
 126 +                               pci_dev_put(pci);
 127 +                               return 0;}
 128                 }
 129         }
 130  #endif
 131 diff -u -p -b a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
 132 --- a/drivers/scsi/dpt_i2o.c 2007-10-22 11:25:23.000000000 +0200
 133 +++ b/drivers/scsi/dpt_i2o.c 2007-11-18 18:36:30.000000000 +0100
 134 NOT SURE
 135 code is written in an inconsistent manner, such that adpt_install_hba
 136 might do a put on pDev, or might not
 137 @@ -189,6 +189,7 @@ static int adpt_detect(void)
 138                         if(adpt_install_hba(pDev) ){
 139                                 PERROR("Could not Init an I2O RAID device\n");
 140                                 PERROR("Will not try to detect others.\n");
 141 +                               pci_dev_put(pDev);
 142                                 return hba_count-1;
 143                         }
 144                         pci_dev_get(pDev);
 145 diff -u -p -b a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
 146 NO.  iTCO_wdt_init does put.
 147 --- a/drivers/watchdog/iTCO_wdt.c 2007-11-08 08:00:52.000000000 +0100
 148 +++ b/drivers/watchdog/iTCO_wdt.c 2007-11-18 18:37:09.000000000 +0100
 149 @@ -740,6 +740,7 @@ static int __devinit iTCO_wdt_probe(stru
 150                 if (ent) {
 151                         if (!(iTCO_wdt_init(pdev, ent, dev))) {
 152                                 found++;
 153 +                               pci_dev_put(pdev);
 154                                 break;
 155                         }
 156                 }
 157 diff -u -p -b a/sound/core/memalloc.c b/sound/core/memalloc.c
 158 OK sent
 159 --- a/sound/core/memalloc.c 2007-10-22 11:25:51.000000000 +0200
 160 +++ b/sound/core/memalloc.c 2007-11-18 18:38:21.000000000 +0100
 161 @@ -568,6 +568,7 @@ static ssize_t snd_mem_proc_write(struct
 162                                 if (pci_set_dma_mask(pci, mask) < 0 ||
 163                                     pci_set_consistent_dma_mask(pci, mask) < 0) {
 164                                         printk(KERN_ERR "snd-page-alloc: cannot set DMA mask %lx for pci %04x:%04x\n", mask, vendor, device);
 165 +                                       pci_dev_put(pci);
 166                                         return count;
 167                                 }
 168                         }