ntk/apt.git
12 years agoadd implicit dependencies needed for Multi-Arch at the time a Version
David Kalnischkies [Wed, 12 Oct 2011 18:16:02 +0000 (20:16 +0200)]
add implicit dependencies needed for Multi-Arch at the time a Version
struct is created and not at the end of the cache generation

This allows us to be independent from the configured architectures for
these kind of conflicts, we get natural progress for free and
only the needed dependencies are in th respective binary cache.

12 years agouse one string to construct the error message instead of using multiple
David Kalnischkies [Wed, 12 Oct 2011 17:34:06 +0000 (19:34 +0200)]
use one string to construct the error message instead of using multiple
just with different debugging information at the end

12 years agoa version can have only a single md5 for descriptions, so we can optimize
David Kalnischkies [Wed, 12 Oct 2011 13:47:56 +0000 (15:47 +0200)]
a version can have only a single md5 for descriptions, so we can optimize
the merging with this knowledge a bit and by correctly sharing the lists
we only need to have a single description list for possibly many different
versions. This also means that description translations are shared between
different sources

12 years agoshare description list between "same" versions (LP: #868977)
David Kalnischkies [Tue, 11 Oct 2011 19:10:31 +0000 (21:10 +0200)]
share description list between "same" versions (LP: #868977)

12 years ago* apt-pkg/pkgcachegen.cc:
David Kalnischkies [Tue, 11 Oct 2011 16:34:21 +0000 (18:34 +0200)]
* apt-pkg/pkgcachegen.cc:
  - refactor MergeList by creating -Group, -Package and -Version specialist

12 years agorun apt-get download in quiet mode as it messes with output otherwise
David Kalnischkies [Tue, 11 Oct 2011 12:44:05 +0000 (14:44 +0200)]
run apt-get download in quiet mode as it messes with output otherwise

12 years agorun integration tests on my new amd64 box without failures
David Kalnischkies [Tue, 11 Oct 2011 12:37:03 +0000 (14:37 +0200)]
run integration tests on my new amd64 box without failures

12 years agofix compiler warning about signed comparision on amd64, too
David Kalnischkies [Tue, 11 Oct 2011 11:05:40 +0000 (13:05 +0200)]
fix compiler warning about signed comparision on amd64, too

12 years ago* apt-pkg/deb/debmetaindex.cc:
David Kalnischkies [Wed, 5 Oct 2011 20:45:22 +0000 (22:45 +0200)]
* apt-pkg/deb/debmetaindex.cc:
  - none is a separator, not a language: no need for Index (Closes: #624218)
* apt-pkg/aptconfiguration.cc:
  - do not builtin languages only if none is forced (Closes: #643787)

12 years agomerge with current debian apt/experimental
David Kalnischkies [Wed, 5 Oct 2011 16:43:00 +0000 (18:43 +0200)]
merge with current debian apt/experimental

12 years ago* apt-pkg/contrib/configuration.cc:
Michael Vogt [Wed, 5 Oct 2011 16:14:38 +0000 (18:14 +0200)]
* apt-pkg/contrib/configuration.cc:
  - fix double delete (LP: #848907)
  - ignore only the invalid regexp instead of all options
* apt-pkg/acquire-item.h, apt-pkg/deb/debmetaindex.cc:
  - fix fetching language information by adding OptionalSubIndexTarget
* methods/https.cc:
  - cleanup broken downloads properly

* ftparchive/cachedb.cc:
  - fix buffersize in bytes2hex
* apt-pkg/deb/deblistparser.cc:
  - fix crash when the dynamic mmap needs to be grown in
    LoadReleaseInfo (LP: #854090)

12 years agomerged fix from donkult
Michael Vogt [Mon, 26 Sep 2011 11:30:19 +0000 (13:30 +0200)]
merged fix from donkult

12 years agoftparchive/cachedb.cc: rewrite to fix the fixed length field
Michael Vogt [Thu, 22 Sep 2011 13:15:30 +0000 (15:15 +0200)]
ftparchive/cachedb.cc: rewrite to fix the fixed length field

12 years ago* ftparchive/cachedb.cc:
Michael Vogt [Thu, 22 Sep 2011 12:17:13 +0000 (14:17 +0200)]
* ftparchive/cachedb.cc:
  - fix buffersize in bytes2hex

12 years ago* apt-pkg/deb/debsrcrecords.cc:
David Kalnischkies [Wed, 21 Sep 2011 17:31:03 +0000 (19:31 +0200)]
* apt-pkg/deb/debsrcrecords.cc:
  - remove the limit of 400 Binaries for a source package (Closes: #622110)

12 years ago* methods/https.cc:
Michael Vogt [Tue, 20 Sep 2011 16:21:21 +0000 (18:21 +0200)]
* methods/https.cc:
  - cleanup broken downloads properly

12 years ago* apt-pkg/algorithms.cc:
David Kalnischkies [Tue, 20 Sep 2011 12:21:23 +0000 (14:21 +0200)]
* apt-pkg/algorithms.cc:
  - if a package is garbage, don't try to save it with FixByInstall

12 years ago* cmdline/apt-get.cc:
David Kalnischkies [Tue, 20 Sep 2011 11:27:53 +0000 (13:27 +0200)]
* cmdline/apt-get.cc:
  - follow Provides in the evaluation of saving candidates, too, for
    statisfying garbage package dependencies (Closes: #640590)

12 years agoload the dpkg base arguments only one time and reuse them later
David Kalnischkies [Tue, 20 Sep 2011 09:54:15 +0000 (11:54 +0200)]
load the dpkg base arguments only one time and reuse them later

12 years ago* apt-pkg/deb/dpkgpm.cc:
David Kalnischkies [Tue, 20 Sep 2011 09:34:37 +0000 (11:34 +0200)]
* apt-pkg/deb/dpkgpm.cc:
  - use std::vector instead of fixed size arrays to store args and
    multiarch-packagename strings

12 years agofix foldmarker in algorithms.h
David Kalnischkies [Mon, 19 Sep 2011 19:05:00 +0000 (21:05 +0200)]
fix foldmarker in algorithms.h

12 years agoremove old APT_COMPATIBILITY ifdef's
David Kalnischkies [Mon, 19 Sep 2011 17:27:07 +0000 (19:27 +0200)]
remove old APT_COMPATIBILITY ifdef's

12 years agouse forward declaration in headers if possible instead of includes
David Kalnischkies [Mon, 19 Sep 2011 17:14:19 +0000 (19:14 +0200)]
use forward declaration in headers if possible instead of includes

12 years agodo not pollute namespace in the headers with using (Closes: #500198)
David Kalnischkies [Mon, 19 Sep 2011 11:31:29 +0000 (13:31 +0200)]
do not pollute namespace in the headers with using (Closes: #500198)

12 years agoremove an extra argument for the error mesage format
David Kalnischkies [Mon, 19 Sep 2011 10:26:56 +0000 (12:26 +0200)]
remove an extra argument for the error mesage format

12 years ago* apt-pkg/acquire-item.h, apt-pkg/deb/debmetaindex.cc:
Michael Vogt [Fri, 16 Sep 2011 07:15:17 +0000 (09:15 +0200)]
* apt-pkg/acquire-item.h, apt-pkg/deb/debmetaindex.cc:
  - fix fetching language information by adding OptionalSubIndexTarget

12 years agoreleasing version 0.8.16~exp6
Michael Vogt [Wed, 14 Sep 2011 19:19:05 +0000 (21:19 +0200)]
releasing version 0.8.16~exp6

12 years agomerged from donkult
Michael Vogt [Wed, 14 Sep 2011 18:30:15 +0000 (20:30 +0200)]
merged from donkult

12 years agoenable APT in unpack/configure ordering to handle loops as well
David Kalnischkies [Wed, 14 Sep 2011 18:22:31 +0000 (20:22 +0200)]
enable APT in unpack/configure ordering to handle loops as well
as tight dependencies between immediate packages better
enabling also the possibility to mark all packages as immediate
(at least Closes: #353290, #540227, #559733, #621836, #639290)

12 years agomerged from donkult
Michael Vogt [Wed, 14 Sep 2011 18:14:30 +0000 (20:14 +0200)]
merged from donkult

12 years agoupdate symbols
David Kalnischkies [Wed, 14 Sep 2011 13:48:18 +0000 (15:48 +0200)]
update symbols

12 years agoupdate package names too for the new abi
Michael Vogt [Wed, 14 Sep 2011 11:56:33 +0000 (13:56 +0200)]
update package names too for the new abi

12 years ago* [abi-break] Support large files in the complete toolset. Indexes of this
Michael Vogt [Wed, 14 Sep 2011 11:24:23 +0000 (13:24 +0200)]
* [abi-break] Support large files in the complete toolset. Indexes of this
* bump ABI version

12 years agomerged from lp:~donkult/apt/experimental
Michael Vogt [Wed, 14 Sep 2011 11:22:19 +0000 (13:22 +0200)]
merged from lp:~donkult/apt/experimental

12 years agomerge with debian/sid
David Kalnischkies [Tue, 13 Sep 2011 16:00:22 +0000 (18:00 +0200)]
merge with debian/sid

12 years agomerge with debian/experimental
David Kalnischkies [Tue, 13 Sep 2011 15:52:22 +0000 (17:52 +0200)]
merge with debian/experimental

12 years agoSupport large files in the complete toolset. Indexes of this
David Kalnischkies [Tue, 13 Sep 2011 15:46:48 +0000 (17:46 +0200)]
Support large files in the complete toolset. Indexes of this
size are pretty unlikely for now, but we need it for deb
packages which could become bigger than 4GB now (LP: #815895)

12 years ago* apt-pkg/contrib/configuration.cc:
Michael Vogt [Tue, 13 Sep 2011 14:19:09 +0000 (16:19 +0200)]
* apt-pkg/contrib/configuration.cc:
  - fix double delete (LP: #848907)
  - ignore only the invalid regexp instead of all options

12 years agoreorder includes: add <config.h> if needed and include it at first
David Kalnischkies [Tue, 13 Sep 2011 08:09:00 +0000 (10:09 +0200)]
reorder includes: add <config.h> if needed and include it at first

12 years agoreleasing version 0.8.15.7 0.8.15.7
Michael Vogt [Mon, 12 Sep 2011 16:25:41 +0000 (18:25 +0200)]
releasing version 0.8.15.7

12 years agomerged from lp:~donkult/apt/sid
Michael Vogt [Mon, 12 Sep 2011 14:09:53 +0000 (16:09 +0200)]
merged from lp:~donkult/apt/sid

12 years agofix changelog typos and bugfix-link
David Kalnischkies [Fri, 9 Sep 2011 10:51:18 +0000 (12:51 +0200)]
fix changelog typos and bugfix-link

12 years agoM-A:same lockstep unpack should operate on installed
David Kalnischkies [Fri, 9 Sep 2011 10:35:22 +0000 (12:35 +0200)]
M-A:same lockstep unpack should operate on installed
packages first (LP: #835625)

12 years agofix bashism (local outside function) and releasefile creation in testcases
David Kalnischkies [Fri, 9 Sep 2011 08:56:42 +0000 (10:56 +0200)]
fix bashism (local outside function) and releasefile creation in testcases

12 years ago - add an Acquire::Min-ValidTime option (Closes: #640122)
David Kalnischkies [Mon, 5 Sep 2011 13:58:19 +0000 (15:58 +0200)]
  - add an Acquire::Min-ValidTime option (Closes: #640122)
* doc/apt.conf.5.xml:
  - reword Acquire::Max-ValidTime documentation to make clear
    that it doesn't provide the new Min-ValidTime functionality

12 years ago* apt-pkg/indexrecords.cc:
David Kalnischkies [Mon, 5 Sep 2011 12:50:30 +0000 (14:50 +0200)]
* apt-pkg/indexrecords.cc:
  - fix Acquire::Max-ValidTime option by interpreting it really
    as seconds as specified in the manpage and not as days

12 years ago* apt-pkg/orderlist.cc:
David Kalnischkies [Tue, 23 Aug 2011 22:41:30 +0000 (00:41 +0200)]
* apt-pkg/orderlist.cc:
  - prefer visiting packages marked for deletion in VisitProvides
    if we are operating on a negative dependency so that we can
    deal early with the fallout of this remove

12 years agoprint from their the visit came from
David Kalnischkies [Tue, 23 Aug 2011 18:17:19 +0000 (20:17 +0200)]
print from their the visit came from

12 years ago* cmdline/apt-key:
David Kalnischkies [Tue, 23 Aug 2011 09:20:51 +0000 (11:20 +0200)]
* cmdline/apt-key:
  - if command is 'add' do not error out if the specified
    keyring doesn't exist, it will be created by gpg

12 years agoremove the caches in 'apt-get update', too, as they will be
David Kalnischkies [Mon, 22 Aug 2011 21:10:15 +0000 (23:10 +0200)]
remove the caches in 'apt-get update', too, as they will be
invalid in most cases anyway

12 years ago* apt-pkg/acquire.cc:
David Kalnischkies [Mon, 22 Aug 2011 21:08:16 +0000 (23:08 +0200)]
* apt-pkg/acquire.cc:
  - non-existing directories are by definition clean

12 years ago* apt-pkg/acquire-item.cc:
David Kalnischkies [Mon, 22 Aug 2011 20:52:25 +0000 (22:52 +0200)]
* apt-pkg/acquire-item.cc:
  - if no Release.gpg file is found try to verify with hashes,
    but do not fail if a hash can't be found

12 years ago* cmdline/apt-get.cc:
David Kalnischkies [Thu, 18 Aug 2011 09:45:51 +0000 (11:45 +0200)]
* cmdline/apt-get.cc:
  - remove the binary caches in 'apt-get clean' as it is the first
    thing recommend by many supporters in case of APT segfaults

12 years agomerged lp:~donkult/apt/sid
Michael Vogt [Wed, 17 Aug 2011 16:14:27 +0000 (18:14 +0200)]
merged lp:~donkult/apt/sid

12 years agoset the msglevel to a high dummy value if none is specified
David Kalnischkies [Wed, 17 Aug 2011 13:49:59 +0000 (15:49 +0200)]
set the msglevel to a high dummy value if none is specified

12 years agofor consistency allow the usage of 'make test' instead of './run-tests'
David Kalnischkies [Wed, 17 Aug 2011 13:47:08 +0000 (15:47 +0200)]
for consistency allow the usage of 'make test' instead of './run-tests'

12 years agounderstand DEB_BUILD_OPTIONS nocheck to disable the testexecution
David Kalnischkies [Wed, 17 Aug 2011 13:14:45 +0000 (15:14 +0200)]
understand DEB_BUILD_OPTIONS nocheck to disable the testexecution

12 years ago* debian/apt.symbols:
David Kalnischkies [Wed, 17 Aug 2011 13:09:57 +0000 (15:09 +0200)]
* debian/apt.symbols:
  - add the newly added symbols since 0.8.15.3

12 years ago* test/*
David Kalnischkies [Wed, 17 Aug 2011 12:49:03 +0000 (14:49 +0200)]
* test/*
  - reorganize the various testcases and helper we have and
    integrate them better into the buildsystem
  - run the test/libapt testcases at package build-time

12 years agofix 'comparison between signed and unsigned integer expressions' warning
David Kalnischkies [Wed, 17 Aug 2011 12:41:02 +0000 (14:41 +0200)]
fix 'comparison between signed and unsigned integer expressions' warning
in the udevcdrom testcase

12 years agodo not output color in the testcases if stdout/stderr are not a /dev/pts
David Kalnischkies [Wed, 17 Aug 2011 12:37:25 +0000 (14:37 +0200)]
do not output color in the testcases if stdout/stderr are not a /dev/pts

12 years agobuild test-binaries by default and add a test target to toplevel
David Kalnischkies [Wed, 17 Aug 2011 12:35:58 +0000 (14:35 +0200)]
build test-binaries by default and add a test target to toplevel

12 years agofix the compareversion test to work then called from outside of libapt
David Kalnischkies [Wed, 17 Aug 2011 10:39:59 +0000 (12:39 +0200)]
fix the compareversion test to work then called from outside of libapt

12 years agothe experimental branch has a better version of this test in libapt,
David Kalnischkies [Wed, 17 Aug 2011 10:15:39 +0000 (12:15 +0200)]
the experimental branch has a better version of this test in libapt,
so remove it now - we will get it back at merge-time with experimental

12 years agoremove fake-status leftover from the python-test
David Kalnischkies [Wed, 17 Aug 2011 10:15:21 +0000 (12:15 +0200)]
remove fake-status leftover from the python-test

12 years agomove the networkless test to the interactive helpers as it needs
David Kalnischkies [Wed, 17 Aug 2011 10:13:38 +0000 (12:13 +0200)]
move the networkless test to the interactive helpers as it needs
root rights for operation (ifup/down, iptables) so it is better run
under supervision

12 years agoremove the python testcases as this is covered by integration/
David Kalnischkies [Wed, 17 Aug 2011 10:09:12 +0000 (12:09 +0200)]
remove the python testcases as this is covered by integration/

12 years agomove the interactive helper to a subdirectory of test
David Kalnischkies [Wed, 17 Aug 2011 10:06:37 +0000 (12:06 +0200)]
move the interactive helper to a subdirectory of test

12 years agoadd 'dirs' target to the 'all' target to ensure that for e.g. the tests
David Kalnischkies [Wed, 17 Aug 2011 10:05:22 +0000 (12:05 +0200)]
add 'dirs' target to the 'all' target to ensure that for e.g. the tests
all (sub)directories are build which are needed (e.g. obj/ and co)

12 years agomove the list of versions to test with to the libapt subdirectory
David Kalnischkies [Wed, 17 Aug 2011 09:42:02 +0000 (11:42 +0200)]
move the list of versions to test with to the libapt subdirectory

12 years agomerged from lp:~donkult/apt/sid
Michael Vogt [Wed, 17 Aug 2011 09:38:45 +0000 (11:38 +0200)]
merged from lp:~donkult/apt/sid

12 years agoremove the interactive scratch test, it doesn't test much and what
David Kalnischkies [Wed, 17 Aug 2011 09:38:10 +0000 (11:38 +0200)]
remove the interactive scratch test, it doesn't test much and what
it tests is covered by your non-interactive testcases,
so this one wasn't used for a looooong time

12 years agoreplaced by the integration/test-compressed-indexes test
David Kalnischkies [Wed, 17 Aug 2011 09:34:10 +0000 (11:34 +0200)]
replaced by the integration/test-compressed-indexes test

12 years agomerge with the final changelog from debian-sid
David Kalnischkies [Wed, 17 Aug 2011 09:15:36 +0000 (11:15 +0200)]
merge with the final changelog from debian-sid

12 years ago* apt-pkg/packagemanager.cc, apt-pkg/pkgcache.cc:
David Kalnischkies [Wed, 17 Aug 2011 09:13:50 +0000 (11:13 +0200)]
* apt-pkg/packagemanager.cc, apt-pkg/pkgcache.cc:
  - ignore "self"-conflicts for all architectures of a package
    instead of just for the architecture of the package locked at
    in the ordering of installations too (Closes: #802901)

12 years agomerge the tests for configuration into another libapt-test
David Kalnischkies [Wed, 17 Aug 2011 07:59:19 +0000 (09:59 +0200)]
merge the tests for configuration into another libapt-test

12 years agoFixed a problem where the loop flag would be removed prematurely.
Christopher Baines [Tue, 16 Aug 2011 17:00:01 +0000 (18:00 +0100)]
Fixed a problem where the loop flag would be removed prematurely.

  SmartConfigure xserver-xorg-video-apm (1:1.2.3-0ubuntu1)
    SmartConfigure xserver-xorg-core (2:1.9.0-0ubuntu7.3) <- Loop flag set on xserver-xorg-core
      SmartConfigure xserver-xorg (1:7.5+6ubuntu3)
        SmartConfigure xserver-xorg-core (2:1.9.0-0ubuntu7.3) (Only Correct Dependancies) <- Loop flag removed prematurely
          SmartConfigure libpciaccess0 (0.12.0-1)
          SmartConfigure libpixman-1-0 (0.18.4-1)
        SmartConfigure xserver-xorg-video-all (1:7.5+6ubuntu3)
          SmartConfigure xserver-xorg-video-apm (1:1.2.3-0ubuntu1) (Only Correct Dependancies)
            SmartConfigure xserver-xorg-core (2:1.9.0-0ubuntu7.3) <- Incorrectly detects first run as no loop flag

Also applied this fix to the SmartUnpack method.

12 years agoFixed a bug where SmartUnPack would be called with Immediate=true (to resolve dependa...
Christopher Baines [Mon, 15 Aug 2011 21:31:09 +0000 (22:31 +0100)]
Fixed a bug where SmartUnPack would be called with Immediate=true (to resolve dependancies in SmartConfigure) yet Pkg
would not be immediately configured. This was because SmartUnPack still required the immediate flag to be set on Pkg.

Also inproved the debuging adding indented output for SmartUnPack and SmartConfigure and specifying in the output if
SmartConfigure or SmartUnPack was called just to Correct something (PkgLoop = true) or not.

12 years agosupport yet another webserver in the integration tests: gatling
David Kalnischkies [Mon, 15 Aug 2011 16:23:54 +0000 (18:23 +0200)]
support yet another webserver in the integration tests: gatling

12 years agowrite a proper testcase replacing the print-only uri.cc test
David Kalnischkies [Mon, 15 Aug 2011 16:22:44 +0000 (18:22 +0200)]
write a proper testcase replacing the print-only uri.cc test

12 years agoreleasing version 0.8.16~exp5
Michael Vogt [Mon, 15 Aug 2011 13:35:01 +0000 (15:35 +0200)]
releasing version 0.8.16~exp5

12 years agomerged from lp:~mvo/apt/mvo
Michael Vogt [Mon, 15 Aug 2011 12:21:31 +0000 (14:21 +0200)]
merged from lp:~mvo/apt/mvo

12 years agomerged from the debian-sid branch
Michael Vogt [Mon, 15 Aug 2011 12:10:42 +0000 (14:10 +0200)]
merged from  the debian-sid branch

12 years agoreleasing version 0.8.15.6 0.8.15.6
Michael Vogt [Mon, 15 Aug 2011 11:50:22 +0000 (13:50 +0200)]
releasing version 0.8.15.6

12 years agomerged fixes from lp:~mvo/apt/mvo
Michael Vogt [Mon, 15 Aug 2011 07:23:39 +0000 (09:23 +0200)]
merged fixes from lp:~mvo/apt/mvo

12 years agoApplied DonKult (David)'s excellent fix for inproving the loop management. Now both...
Christopher Baines [Sun, 14 Aug 2011 17:41:38 +0000 (18:41 +0100)]
Applied DonKult (David)'s excellent fix for inproving the loop management. Now both SmartConfigure and SmartUnPack can be
called mutiple times on the same package, this is to make sure that when loops are broken all packages that are required
are kept in the same dpkg run.

12 years agoFix a bug introduced in Rev.2159 on line 398, also fix another potential bug.
Christopher Baines [Sat, 13 Aug 2011 16:29:49 +0000 (17:29 +0100)]
Fix a bug introduced in Rev.2159 on line 398, also fix another potential bug.

12 years agoAdded code to allow SmartConfigure to be called mutiple times on the same package...
Christopher Baines [Fri, 12 Aug 2011 15:36:25 +0000 (16:36 +0100)]
Added code to allow SmartConfigure to be called mutiple times on the same package to ensure all dependancies are satisfied.

12 years agoInproved debug with versioning
Christopher Baines [Fri, 12 Aug 2011 11:22:17 +0000 (12:22 +0100)]
Inproved debug with versioning

12 years agoSmall fix for loop handeling.
Christopher Baines [Fri, 12 Aug 2011 09:38:19 +0000 (10:38 +0100)]
Small fix for loop handeling.

12 years agolots of cppcheck fixes
Michael Vogt [Fri, 12 Aug 2011 08:32:05 +0000 (10:32 +0200)]
lots of cppcheck fixes

12 years agocherry pick test/integration/Packages-hashsum-verification addition from lp:~mvo...
Michael Vogt [Fri, 12 Aug 2011 07:58:55 +0000 (09:58 +0200)]
cherry pick test/integration/Packages-hashsum-verification addition from lp:~mvo/apt/mvo

12 years agotest/integration/Packages-hashsum-verification: commit the forgotten packages file
Michael Vogt [Fri, 12 Aug 2011 07:56:14 +0000 (09:56 +0200)]
test/integration/Packages-hashsum-verification: commit the forgotten packages file

12 years agofollow the recommendation of cppcheck to make some method methods (scnr)
David Kalnischkies [Thu, 11 Aug 2011 21:30:09 +0000 (23:30 +0200)]
follow the recommendation of cppcheck to make some method methods (scnr)
const and initial mostly Debug member values in the constructors

12 years agorename the parameter name of MarkDelete from Purge to MarkPurge to
David Kalnischkies [Thu, 11 Aug 2011 21:06:46 +0000 (23:06 +0200)]
rename the parameter name of MarkDelete from Purge to MarkPurge to
fix a cosmetic warning from cppcheck:
[apt-pkg/depcache.h:462] -> [apt-pkg/depcache.h:122]:
 (style) Variable 'Purge' hides enumerator with same name

12 years agofix a few more cppcheck performance and scope warnings
David Kalnischkies [Thu, 11 Aug 2011 21:01:15 +0000 (23:01 +0200)]
fix a few more cppcheck performance and scope warnings

12 years agocppcheck complains about some possible speed improvements which could be
David Kalnischkies [Thu, 11 Aug 2011 18:53:28 +0000 (20:53 +0200)]
cppcheck complains about some possible speed improvements which could be
done on the mirco-optimazation level, so lets fix them:
 (performance) Possible inefficient checking for emptiness.
 (performance) Prefer prefix ++/-- operators for non-primitive types.

12 years agofix some cppcheck: (warning) Member variable is not initialized in the constructor.
David Kalnischkies [Thu, 11 Aug 2011 17:20:53 +0000 (19:20 +0200)]
fix some cppcheck: (warning) Member variable is not initialized in the constructor.

12 years agocppcheck is right that the check for preventing null deference of Query
David Kalnischkies [Thu, 11 Aug 2011 16:42:19 +0000 (18:42 +0200)]
cppcheck is right that the check for preventing null deference of Query
is redundant in Redirect() as we can't reach the code with null anyway

[apt-pkg/acquire-method.cc:433]: (error) Possible null pointer dereference:
 Queue - otherwise it is redundant to check if Queue is null at line 425

12 years agoAdded a RmFlag function to remvoe the loop flag, this should prevent any errors or...
Christopher Baines [Thu, 11 Aug 2011 14:35:54 +0000 (15:35 +0100)]
Added a RmFlag function to remvoe the loop flag, this should prevent any errors or wierd behaviour because of the loop flag being used
at mutiple stages in both SmartUnpack and SmartConfigure.