David Kalnischkies [Sun, 15 Sep 2013 22:02:21 +0000 (00:02 +0200)]
add Range and If-Range support in the webserver
Git-Dch: Ignore
David Kalnischkies [Sun, 15 Sep 2013 20:54:04 +0000 (22:54 +0200)]
access _config via GET requests in the webserver
Git-Dch: Ignore
David Kalnischkies [Mon, 30 Sep 2013 07:08:33 +0000 (09:08 +0200)]
APT has no bugs
Okay, maybe it does have a "few", but the DDTP issues mentioned in this
file are long since gone, so lets just drop the file and look at the PTS
instead: http://bugs.debian.org/cgi-bin/pkgreport.cgi?src=apt
Git-Dch: Ignore
David Kalnischkies [Thu, 26 Sep 2013 14:25:11 +0000 (16:25 +0200)]
test: apt-get source with more than one argument
Closes: 722549
Git-Dch: Ignore
David Kalnischkies [Thu, 26 Sep 2013 12:56:45 +0000 (14:56 +0200)]
print-uris prints regardless of quiet-level again
While the InstallPackages code was moved from apt-get into the private
library the output was moved from (std::)cout to c1out which isn't shown
in quiet level 2 (and above), so we flip back to std::cout to ensure
that it is always printed as you are not going to use --print-uris if
you don't want to see the uris…
Closes: 722207
David Kalnischkies [Thu, 26 Sep 2013 12:06:25 +0000 (14:06 +0200)]
compression-neutral message for missing data.tar member
It even reuses the message used for the other check-for members, so one
less message to translate (good, as not that many people will ever see it).
Closes: 722710
David Kalnischkies [Thu, 26 Sep 2013 11:32:49 +0000 (13:32 +0200)]
pkg from only trusted sources keeps being trusted
--allow-unauthenticated switches the download to a pre-0.6 system in
which a package can come from any source, rather than that trusted
packages can only come from trusted sources.
To allow this the flag used to set all packages as untrusted, which is a
bit much, so we check now if the package can be acquired via an
untrusted source and only if this is the case set it as untrusted.
As APT nowadays supports setting sources as trusted via a flag in the
sources.list this mode shouldn't be used that much anymore though.
[Note that this is not the patch from the BTS]
Closes: 617690
David Kalnischkies [Sat, 21 Sep 2013 12:23:02 +0000 (14:23 +0200)]
don't strip :any from dependencies in single-arch
The parser goes a bit to far by stripping :any from dependencies in a
single architecture environment. the flag "Multi-Arch: allowed" doesn't
care any architecture restrictions in that case (as in single arch
everything is native), but it still limits the possible versions
statisfying the dependency so stripping :any over-simplifies in upgrade
situations from "Multi-Arch: none" to "Multi-Arch: allowed".
Closes: 723586
Christian PERRIER [Mon, 23 Sep 2013 05:06:18 +0000 (07:06 +0200)]
Fix typo in apt-private/private-show.cc. Thanks to Benjamin Keresa. Closes: #724073
Michael Vogt [Fri, 20 Sep 2013 12:11:48 +0000 (14:11 +0200)]
releasing package apt version 0.9.11.4
David Kalnischkies [Fri, 20 Sep 2013 11:34:22 +0000 (13:34 +0200)]
do not trust FileFd::Eof() in pkgTagFile::Fill()
The Eof check was added (by me of course) in
0aae6d14390193e25ab6d0fd49295bd7b131954f
as part of a fix up ~a month ago (at DebConf).
The idea was not that bad, but doesn't make that much sense either
as this bit is set by the FileFd based on Actual as well, so this is
basically doing the same check again – with the difference that the
HitEof bit can still linger from a previous Read we did at the end of
the file, but have seek'd away from it now.
Combined with the length of entries, entry order and other not that
easily controllable conditions you can be 'lucky' enough to hit this
problem in a way which even visible (truncating of other fields might
not be visible easily, like 'Tags' and others).
Closes: 723705
Thanks: Cyril Brulebois
David Kalnischkies [Thu, 12 Sep 2013 11:42:37 +0000 (13:42 +0200)]
add a testcase for 100 char long path truncate bug #689582
Git-Dch: Ignore
Oskari Saarenmaa [Thu, 12 Sep 2013 11:20:01 +0000 (13:20 +0200)]
don't truncate 100 char long paths in tar extraction
When a data.tar.{gz,xz} contains a path name that is exactly
100 characters long, it will get truncated to 99 chars upon
extraction in ExtractTar::Go().
Using all of the 100 available characters for the filename
seems to be new behaviour in gnu tar.
Closes: #689582
Thanks: Mika Eloranta for the testcase!
Michael Vogt [Tue, 10 Sep 2013 15:41:01 +0000 (17:41 +0200)]
Fix regression of "apt-cache unmet -i", thanks to Daniel Schepler (closes: #722324)
Michael Vogt [Tue, 10 Sep 2013 15:32:50 +0000 (17:32 +0200)]
prepare upload
David Kalnischkies [Tue, 3 Sep 2013 21:00:37 +0000 (23:00 +0200)]
use FileFd in HashSum test to unbreak non-linux ports
The testcode happily mixes FILE* operations and direct access to fds
which is even a bit suprising that it works on linux and worked so
long for non-linux ports, so we switch to usage of FileFd instead
which provides us with simple fd-only operations. Its overkill for this
test as its a bare file and we ask for the descriptor all the time, but
it shouldn't hurt to implicitly test it a bit this way.
Closes: 721723
Thanks: Aaron M. Ucko
David Kalnischkies [Fri, 30 Aug 2013 15:18:20 +0000 (17:18 +0200)]
fix vim-style foldmarker
Git-Dch: Ignore
Michael Vogt [Sun, 1 Sep 2013 16:34:34 +0000 (18:34 +0200)]
Remove invalid "-f" option for apt-get check
Thanks to Philipp Weis (closes: #721477)
Michael Vogt [Sun, 1 Sep 2013 16:33:26 +0000 (18:33 +0200)]
Merge branch 'debian/sid' of ssh://git.debian.org/git/apt/apt into debian/sid
Michael Vogt [Sat, 31 Aug 2013 15:05:23 +0000 (17:05 +0200)]
fix typo (mkostemp->mkstemp)
Michael Vogt [Sat, 31 Aug 2013 14:31:53 +0000 (16:31 +0200)]
prepare upload of 0.9.12
Michael Vogt [Wed, 28 Aug 2013 08:59:54 +0000 (10:59 +0200)]
Merge remote-tracking branch 'mvo/feature/install-progress' into debian/sid
Michael Vogt [Wed, 28 Aug 2013 07:15:26 +0000 (09:15 +0200)]
Merge remote-tracking branch 'mvo/feature/upgrade-with-cmdline' into debian/sid
Michael Vogt [Wed, 28 Aug 2013 07:12:41 +0000 (09:12 +0200)]
Merge remote-tracking branch 'donkult/debian/sid' into debian/sid
Christian PERRIER [Wed, 28 Aug 2013 04:54:13 +0000 (06:54 +0200)]
Complete Italian translation
David Kalnischkies [Tue, 27 Aug 2013 22:24:32 +0000 (00:24 +0200)]
configurable compression for testcases
Compressing files in 4 different styles eats test-time for no practical
gain if we don't test them explicitly, so default to just building 'gz'
compressed files as it is the simplest compression algorithm supported
Git-Dch: Ignore
David Kalnischkies [Tue, 27 Aug 2013 21:14:49 +0000 (23:14 +0200)]
old-style dpkg foreign architecture adding for tests
Looks like the travis service runs on Ubuntu in a version which has dpkg
with an earlier interface implementation, so lets try if we can't make
the framework work with this dpkg version as well.
Git-Dch: Ignore
David Kalnischkies [Tue, 27 Aug 2013 19:50:22 +0000 (21:50 +0200)]
use mkstemp instead of mkostemp in FileFd::Open()
FileFd currently supports no fileflags which would make sense to provide
via mkostemp, so we can just use mkstemp here which is a standard
function compared to glib extension mkostemp.
O_CREAT (Create) and O_TRUNC (Empty) are implied by O_EXCL, which is the
mode mkstemp uses by default. The file description is opened ReadWrite,
but that used to be the default for FileFd in the old times and not a
problem as the difference is needed by FileFd to decide in which way the
compressor pipeline needs to be created (if any).
Git-Dch: Ignore
Angel Guzman Maeso [Tue, 27 Aug 2013 19:29:01 +0000 (21:29 +0200)]
replace usage of potential dangerous mktemp with mkstemp
Avoid the warning "the use of `mktemp' is dangerous,
better use `mkstemp' or `mkdtemp'". It is not strictly necessary to
change the usage from a security point of view here, but mktemp is
also removed from the standard since POSIX.1-2008.
The mkostemp call returns a file descriptor the logic for
TemporaryFileName has been changed accordingly to get the same results.
The file permissions are corrected by using fchmod() as the default for
FileFd is 666 while mkstemp creates files with 600 by default.
Christian PERRIER [Tue, 27 Aug 2013 17:01:46 +0000 (19:01 +0200)]
Update Italian translation. Closes: #721030
Michael Vogt [Tue, 27 Aug 2013 06:50:06 +0000 (08:50 +0200)]
allow pkg manipulation in the upgrade/dist-upgrade commandline, e.g. apt-get dist-upgrade 2vcard- 4g8+
Michael Vogt [Tue, 27 Aug 2013 06:38:05 +0000 (08:38 +0200)]
use SPtr<pkgProblemResolver> to simply code
Michael Vogt [Mon, 26 Aug 2013 16:52:13 +0000 (18:52 +0200)]
update changelog
Michael Vogt [Mon, 26 Aug 2013 16:52:06 +0000 (18:52 +0200)]
apt-private/private-cmndline.cc: fix typo: s/deselect-upgrade/dselect-upgrade/
Michael Vogt [Mon, 26 Aug 2013 16:51:40 +0000 (18:51 +0200)]
dselect/install: add new DSELECT_UPGRADE_OPTS="-f"
Michael Vogt [Mon, 26 Aug 2013 16:45:32 +0000 (18:45 +0200)]
dselect/install:
* dselect/install:
- remove "-f" option for apt-get dselect-upgrade (closes: #720532)
Michael Vogt [Mon, 26 Aug 2013 16:42:58 +0000 (18:42 +0200)]
Merge branch 'debian/sid' of ssh://git.debian.org/git/apt/apt into debian/sid
Conflicts:
debian/changelog
Christian PERRIER [Sun, 25 Aug 2013 13:40:44 +0000 (15:40 +0200)]
Changelog entry for Vietnamese translation
Tran Ngoc Quan [Sun, 25 Aug 2013 07:20:31 +0000 (14:20 +0700)]
Update Vietnamese translation to 0.9.11
Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>
Michael Vogt [Sat, 24 Aug 2013 07:13:57 +0000 (09:13 +0200)]
update changelog for update
Michael Vogt [Sat, 24 Aug 2013 07:07:37 +0000 (09:07 +0200)]
Merge remote-tracking branch 'mvo/debian/sid' into debian/sid
Michael Vogt [Fri, 23 Aug 2013 11:44:21 +0000 (13:44 +0200)]
dselect/update: remove "-f" option as its not being used in the context of apt-get update
Michael Vogt [Fri, 23 Aug 2013 07:15:00 +0000 (09:15 +0200)]
ftparchive/override.cc: fix "skip empty lines" code, the pointer needs to get de-referenced first
Michael Vogt [Thu, 22 Aug 2013 21:00:31 +0000 (23:00 +0200)]
Merge branch 'debian/sid' of ssh://git.debian.org/git/apt/apt into debian/sid
Michael Vogt [Thu, 22 Aug 2013 20:30:20 +0000 (22:30 +0200)]
do chdir("/") after chroot()
Michael Vogt [Thu, 22 Aug 2013 20:26:05 +0000 (22:26 +0200)]
Merge remote-tracking branch 'donkult/debian/sid' into debian/sid
Ángel Guzmán Maeso [Wed, 21 Aug 2013 17:38:35 +0000 (19:38 +0200)]
apt-pkg:contrib Avoid compiler warning about sign-compare
The fix avoid the warning "comparison between signed and
unsigned integer expressions [-Wsign-compare]"· The index for the loop needs
to be unsigned for compare with globbuf.gl_pathc structure
member
Michael Vogt [Thu, 22 Aug 2013 20:24:27 +0000 (22:24 +0200)]
Merge remote-tracking branch 'mvo/bugfix/coverity' into debian/sid
Conflicts:
apt-pkg/tagfile.h
Michael Vogt [Thu, 22 Aug 2013 20:23:04 +0000 (22:23 +0200)]
Merge remote-tracking branch 'mvo/debian/sid' into debian/sid
Angel Guzman Maeso [Thu, 22 Aug 2013 14:54:20 +0000 (16:54 +0200)]
fix compiler warning about sign-compare
This fix avoids the warning "comparison between signed and unsigned
integer expressions [-Wsign-compare]". The index for the loop
needs to be unsigned for compare with globbuf.gl_pathc structure
member.
David Kalnischkies [Thu, 22 Aug 2013 14:46:43 +0000 (16:46 +0200)]
add versions to manpages-it Replaces+Breaks
In the meantime the package was updated to remove the old APT manpages
from this package, so we can now add a Breaks and version it, too.
The intial Replaces was added in:
b57220d815aedbc023847d0885e08c6ed50e629a
David Kalnischkies [Thu, 22 Aug 2013 14:36:31 +0000 (16:36 +0200)]
add a breaks libapt-inst for FileFd changes in 0.9.9
Partial upgrades…
The fix for 704608 assumes that
bf35c19b817cc1474b3deabce0b0953c248bad42
was applied to libapt-inst which isn't the case for partial upgrades of
course, so break it to ensure that it is the case.
Closes: 720449
Michael Vogt [Wed, 21 Aug 2013 15:59:30 +0000 (17:59 +0200)]
prepare unstable upload
Michael Vogt [Mon, 19 Aug 2013 13:54:23 +0000 (15:54 +0200)]
fix incorrect bugnumber for the Pre-Install-Pkgs hook (Closes: #671726)
Michael Vogt [Mon, 19 Aug 2013 12:59:29 +0000 (14:59 +0200)]
add lintian override for no-shlibs-control-file and only install libapt-private.so.* instead libapt-private.so
Michael Vogt [Mon, 19 Aug 2013 12:39:55 +0000 (05:39 -0700)]
Merge pull request #3 from cbaines/debian/sid
Add test for bug 507998
Michael Vogt [Mon, 19 Aug 2013 09:00:44 +0000 (11:00 +0200)]
prepare for release
Michael Vogt [Sat, 17 Aug 2013 08:03:02 +0000 (10:03 +0200)]
update changelog
Michael Vogt [Sat, 17 Aug 2013 07:18:36 +0000 (09:18 +0200)]
Merge remote-tracking branch 'mvo/feature/apt-binary2' into debian/sid
Conflicts:
cmdline/apt-get.cc
Michael Vogt [Sat, 17 Aug 2013 06:38:09 +0000 (08:38 +0200)]
Merge remote-tracking branch 'donkult/debian/sid' into debian/sid
Christian PERRIER [Sat, 17 Aug 2013 05:58:13 +0000 (07:58 +0200)]
Merge branch 'debian/sid' of git://git.debian.org/git/apt/apt into debian/sid
Christian PERRIER [Sat, 17 Aug 2013 05:58:02 +0000 (07:58 +0200)]
French translation update.
Christopher Baines [Fri, 16 Aug 2013 10:44:00 +0000 (12:44 +0200)]
Add test for bug 507998
David Kalnischkies [Tue, 13 Aug 2013 16:18:15 +0000 (18:18 +0200)]
allow Pre-Install-Pkgs hooks to get info over an FD != stdin
This adds ::InfoFD option alongside the ::Version one to request sending
the information to the specified FD, by default it is STDIN as it was
the case before.
The environment variable APT_HOOK_INFO_FD contains the FD the data is on as
a confirmation that the APT version used understood the request.
Allowing the hook to choose the FD is needed/helpful e.g. for shellscripts
which have a hard time accessing FDs above 9 (as >= 10 are usually used
internally by them)
Closes: #671728
David Kalnischkies [Thu, 15 Aug 2013 15:26:30 +0000 (17:26 +0200)]
use malloc instead of new[] in pkgTagFile
We don't need initialized memory for pkgTagFile, but more to the point
we can use realloc this way which hides the bloody details of increasing
the size of the buffer used.
Git-Dch: Ignore
David Kalnischkies [Thu, 15 Aug 2013 14:49:51 +0000 (16:49 +0200)]
ensure that pkgTagFile isn't writing past Buffer length
In
91c4cc14d3654636edf997d23852f05ad3de4853 I removed the +256 from
the pkgTagFile call parsing Release files as I couldn't find a
mentioning of a reason for why and it was marked as XXX which suggested
that at least someone else was suspicious.
It turns out that it is indeed "documented", it just didn't found it at
first but the changelog of apt 0.6.6 (29. Dec 2003) mentions:
* Restore the ugly hack I removed from indexRecords::Load which set the
pkgTagFile buffer size to (file size)+256. This is concealing a bug,
but I can't fix it right now. This should fix the segfaults that
folks are seeing with 0.6.[45].
The bug it is "hiding" is that if pkgTagFile works with a file which doesn't
end in a double newline it will be adding it without checking if the Buffer
is big enough to store them. Its also not a good idea to let the End
pointer be past the end of our space, even if we don't access the data.
Closes: 719629
David Kalnischkies [Thu, 15 Aug 2013 14:45:09 +0000 (16:45 +0200)]
set MALLOC_CHECK_ and MALLOC_PERTURB_ for testcases
In bugreport deb:719629 Paul Wise mentions both to enable some malloc
checks and as more testing can't hurt we enable both for all testcases.
Git-Dch: Ignore
David Kalnischkies [Thu, 15 Aug 2013 14:41:16 +0000 (16:41 +0200)]
rework the parameter creation for the Hashsum test
Avoids having to different places from which test binaries are called
Git-Dch: Ignore
David Kalnischkies [Thu, 15 Aug 2013 14:36:32 +0000 (16:36 +0200)]
do not call make from libapt/run-tests if its called by make
If we are called by make everything is build already and
so this is just a noise nop we can just skip.
(Noisy as it complains about being unable to communicate with
the other makes to coordinate with the jobserver)
Git-Dch: Ignore
David Kalnischkies [Tue, 13 Aug 2013 19:46:32 +0000 (21:46 +0200)]
init the pkgTagFile with the size of the Release file
Release files are basically one big Section, so we might safe some
Resize circles by starting with the filesize.
Git-Dch: Ignore
Michael Vogt [Thu, 15 Aug 2013 11:39:32 +0000 (13:39 +0200)]
add PACKAGE_MATCHER_ABI_COMPAT mode for now so that this branch can be merged without breaking ABI
Michael Vogt [Wed, 17 Oct 2012 08:27:50 +0000 (10:27 +0200)]
* lp:~mvo/apt/add-glob-function:
- add Glob() to fileutl.{cc,h}
Conflicts:
apt-pkg/contrib/fileutl.h
debian/changelog
Michael Vogt [Wed, 17 Oct 2012 08:29:52 +0000 (10:29 +0200)]
* lp:~mvo/apt/config-clear:
- support Configuration.Clear() for a clear of the entire
configuration
Conflicts:
debian/changelog
Michael Vogt [Tue, 23 Apr 2013 06:16:21 +0000 (08:16 +0200)]
merge patch from Daniel Hartwig to Show a error message if {,dist-}upgrade is used with additional
arguments (closes: #705510)
Michael Vogt [Tue, 23 Apr 2013 06:15:06 +0000 (08:15 +0200)]
merge patch from Daniel Hartwig to Clarify units of Acquire::http::Dl-Limit (closes: #705445)
Conflicts:
debian/changelog
Michael Vogt [Thu, 15 Aug 2013 07:04:25 +0000 (09:04 +0200)]
make destructors virtual
Michael Vogt [Mon, 12 Aug 2013 21:59:44 +0000 (23:59 +0200)]
really build apt.install
Michael Vogt [Mon, 12 Aug 2013 21:42:35 +0000 (23:42 +0200)]
install libapt-private* into the apt binary
Michael Vogt [Mon, 12 Aug 2013 21:35:21 +0000 (23:35 +0200)]
Merge remote-tracking branch 'upstream/debian/sid' into feature/apt-binary2
Michael Vogt [Mon, 12 Aug 2013 21:33:57 +0000 (23:33 +0200)]
fix typo in the test for abi-compliance-checker
Michael Vogt [Mon, 12 Aug 2013 21:24:08 +0000 (23:24 +0200)]
squash merge of the feature/apt-binary branch without the changes from experimental
Michael Vogt [Mon, 12 Aug 2013 19:45:59 +0000 (21:45 +0200)]
update changelog for upload
David Kalnischkies [Mon, 12 Aug 2013 15:26:54 +0000 (17:26 +0200)]
do not call 'apt-key update' in apt.postinst
The debian-archive-keyring package ships trusted.gpg.d fragment files
for a while now and dropped their call to 'apt-key update', so there is
no need for use to call it as the keys will always be available.
This also finally allows a user to remove key(ring)s without APT to
overriding this decision by readding them with this step.
The functionality is kept around in the odd case that an old
debian-archive-keyring package is used which still calls 'apt-key
update' and depends on the import (hence, we also do not enforce a newer
version of the debian-archive-keyring via our dependencies)
David Kalnischkies [Mon, 12 Aug 2013 14:19:37 +0000 (16:19 +0200)]
let apt-key del work better with softlink and single key keyrings
Having fragement files means there is a good chance that there is one
key per keyring, so deal with that as well as with setups in which
keyrings are linked into trusted.gpg.d as we can't just modify those
files (they might be in /usr for example).
David Kalnischkies [Mon, 12 Aug 2013 13:51:42 +0000 (15:51 +0200)]
ensure that testcases exiting because of set -e aren't successful
Git-Dch: Ignore
David Kalnischkies [Sun, 11 Aug 2013 22:36:52 +0000 (00:36 +0200)]
make the keyring locations in apt-key configurable
Might come in handy for more than just a simple testcase.
David Kalnischkies [Sun, 11 Aug 2013 22:33:37 +0000 (00:33 +0200)]
do not double-slash paths in apt-key
Closes: 665411
David Kalnischkies [Sun, 11 Aug 2013 22:19:10 +0000 (00:19 +0200)]
use a tmpfile for trustdb.gpg in apt-key
for some "interesting" reason gpg decides that it needs to update its
trustdb.gpg file in a --list-keys command even if right before gpg is
asked to --check-trustdb. That wouldn't be as bad if it wouldn't modify
the keyring being listed at that moment as well, which generates not
only warnings which are not a problem for us, but as the keyring
modified can be in /usr it modified files which aren't allowed to be
modified.
The suggested solution in the bugreport is running --check-trustdb
unconditionally in an 'apt-key update' call, but this command will not
be used in the future and this could still potentially bite us in
net-update or adv calls. All of this just to keep a file around, which
we do not need…
The commit therefore switches to the use of a temporary created
trusted.gpg file for everyone and asks gpg to not try to update the
trustdb after its intial creation, which seems to avoid the problem
altogether.
It is using your also faked secring btw as calling the check-trustdb
without a keyring is a lot slower …
Closes: #687611
Thanks: Andreas Beckmann for the initial patch!
David Kalnischkies [Thu, 11 Jul 2013 18:07:22 +0000 (20:07 +0200)]
always use our own trustdb.gpg in apt-key
APT doesn't care for the trustdb.gpg, but gnupg requires one even for
the simplest commands, so we either use the one root has available in
/etc or if we don't have access to it (as only root can read that file)
we create a temporary directory to store a trustdb.gpg in it.
We can't create just a temporary file as gpg requires the given
trustdb.gpg file to be valid (if it exists), so we would have to remove
the file before calling gnupg which would allow mktemp (and co) to hand
exactly this filename out to another program (unlikely, but still).
David Kalnischkies [Thu, 11 Jul 2013 17:20:09 +0000 (19:20 +0200)]
add a not documented apt-key --fakeroot option
Usually, most apt-key commands require root, so the script is checking
for being run as root, but in your tests we use a non-root location, so
we don't need to be root and therefore need an option to skip the check.
Git-Dch: Ignore
David Kalnischkies [Sat, 13 Jul 2013 21:14:41 +0000 (23:14 +0200)]
use our _error stack to generate openpty errors
While we don't want these error messages on our usual stack, we can use
our usual infrastructure to generate an error message with all the usual
bells like errno and strerror attached.
Git-Dch: Ignore
David Kalnischkies [Sat, 13 Jul 2013 21:05:55 +0000 (23:05 +0200)]
do not try to chown if not run as root
If this code is run as non-root we are in a special situation (e.g. in
our testcases) where it is obvious that we can't enforce user/group on
any file, so skip this code altogether instead of bugging users with
an error message – which we also switch to a warning as a failure to
open the file is "just" a warning, so the 'wrong' owner shouldn't be
that much of an issue.
The file is still handled with chmod, so all the security we can enforce
is still enforced of course, which also gets a warning if it fails.
Git-Dch: Ignore
David Kalnischkies [Sat, 13 Jul 2013 20:57:44 +0000 (22:57 +0200)]
fix output redirection order
First redirect output to a file, then redirect other outputs to this
output, not the other way around as this will not work.
Git-Dch: Ignore
David Kalnischkies [Sat, 10 Aug 2013 10:40:37 +0000 (12:40 +0200)]
fix: --print-uris removes authentication
The constructors of our (clear)sign-acquire-items move a pre-existent
file for error-recovery away, which gets restored or discarded later as
the acquire progresses, but --print-uris never really starts the
acquire process, so the files aren't restored (as they should).
To fix this both get a destructor which checks for signs of acquire
doing anything and if it hasn't the file is restored.
Note that these virtual destructors theoretically break the API, but
only with classes extending the sign-acquire-items and nobody does this,
as it would be insane for library users to fiddle with Acquire
internals – and these classes are internals.
Closes: 719263
David Kalnischkies [Sat, 10 Aug 2013 08:01:06 +0000 (10:01 +0200)]
add chronic-like testsuccess/testfailure helpers
For many commands the output isn't stable (like then dpkg is called) but
the exitcode is, so this helper enhances the common && msgpass ||
msgfail by generating automatically a msgtest and showing the output of
the command in case of failure instead of discarding it unconditionally,
the later being chronic-like behaviour
Git-Dch: Ignore
David Kalnischkies [Fri, 9 Aug 2013 20:20:27 +0000 (22:20 +0200)]
test Release file handling with expired keys
Signing files with expired keys is not as easy as it sounds, so the
framework jumps a few loops to do it, but it might come in handy to have
an expired key around for later tests even if it is not that different
from having no key in regards to APT behaviour.
Git-Dch: Ignore
Michael Vogt [Mon, 12 Aug 2013 15:41:36 +0000 (17:41 +0200)]
improve error message
Michael Vogt [Mon, 12 Aug 2013 15:24:15 +0000 (17:24 +0200)]
some more coverity fixes
Michael Vogt [Mon, 12 Aug 2013 15:11:41 +0000 (17:11 +0200)]
use the 'abi-complicance-checker package instead of using the buildin copy for the abi checks
Christian PERRIER [Sun, 11 Aug 2013 13:42:09 +0000 (15:42 +0200)]
Complete Japanese translation