cleanup upgrade API some more (thanks for the feedback from David)
[ntk/apt.git] / apt-pkg / algorithms.cc
CommitLineData
6c139d6e
AL
1// -*- mode: cpp; mode: fold -*-
2// Description /*{{{*/
b8c0f9b7 3// $Id: algorithms.cc,v 1.44 2002/11/28 18:49:16 jgg Exp $
6c139d6e
AL
4/* ######################################################################
5
6 Algorithms - A set of misc algorithms
7
0a8e3465
AL
8 The pkgProblemResolver class has become insanely complex and
9 very sophisticated, it handles every test case I have thrown at it
10 to my satisfaction. Understanding exactly why all the steps the class
11 does are required is difficult and changing though not very risky
12 may result in other cases not working.
13
6c139d6e
AL
14 ##################################################################### */
15 /*}}}*/
16// Include Files /*{{{*/
ea542140
DK
17#include <config.h>
18
094a497d
AL
19#include <apt-pkg/algorithms.h>
20#include <apt-pkg/error.h>
0a8e3465 21#include <apt-pkg/configuration.h>
0a57c0f0 22#include <apt-pkg/version.h>
b2e465d6 23#include <apt-pkg/sptr.h>
760d4968 24#include <apt-pkg/acquire-item.h>
c3b85126 25#include <apt-pkg/edsp.h>
472ff00e
DK
26#include <apt-pkg/sourcelist.h>
27#include <apt-pkg/fileutl.h>
28#include <apt-pkg/progress.h>
6d38011b 29
22dcc318 30#include <sys/types.h>
152ab79e
MV
31#include <cstdlib>
32#include <algorithm>
90f057fd 33#include <iostream>
6d38011b 34#include <stdio.h>
ea542140
DK
35
36#include <apti18n.h>
6c139d6e 37 /*}}}*/
584e4558 38using namespace std;
6c139d6e
AL
39
40pkgProblemResolver *pkgProblemResolver::This = 0;
41
42// Simulate::Simulate - Constructor /*{{{*/
43// ---------------------------------------------------------------------
b2e465d6
AL
44/* The legacy translations here of input Pkg iterators is obsolete,
45 this is not necessary since the pkgCaches are fully shared now. */
46pkgSimulate::pkgSimulate(pkgDepCache *Cache) : pkgPackageManager(Cache),
47 iPolicy(Cache),
496d5c70
MV
48 Sim(&Cache->GetCache(),&iPolicy),
49 group(Sim)
6c139d6e 50{
b2e465d6
AL
51 Sim.Init(0);
52 Flags = new unsigned char[Cache->Head().PackageCount];
53 memset(Flags,0,sizeof(*Flags)*Cache->Head().PackageCount);
281daf46
AL
54
55 // Fake a filename so as not to activate the media swapping
56 string Jnk = "SIMULATE";
b2e465d6 57 for (unsigned int I = 0; I != Cache->Head().PackageCount; I++)
281daf46 58 FileNames[I] = Jnk;
6c139d6e
AL
59}
60 /*}}}*/
b270388b
MV
61// Simulate::~Simulate - Destructor /*{{{*/
62pkgSimulate::~pkgSimulate()
63{
64 delete[] Flags;
65}
66 /*}}}*/
b2e465d6
AL
67// Simulate::Describe - Describe a package /*{{{*/
68// ---------------------------------------------------------------------
3826564e
MZ
69/* Parameter Current == true displays the current package version,
70 Parameter Candidate == true displays the candidate package version */
71void pkgSimulate::Describe(PkgIterator Pkg,ostream &out,bool Current,bool Candidate)
b2e465d6
AL
72{
73 VerIterator Ver(Sim);
e59458f7 74
47f6d1b7 75 out << Pkg.FullName(true);
e59458f7 76
3826564e 77 if (Current == true)
e59458f7 78 {
b2e465d6 79 Ver = Pkg.CurrentVer();
e59458f7
AL
80 if (Ver.end() == false)
81 out << " [" << Ver.VerStr() << ']';
82 }
b2e465d6 83
3826564e
MZ
84 if (Candidate == true)
85 {
86 Ver = Sim[Pkg].CandidateVerIter(Sim);
87 if (Ver.end() == true)
88 return;
b2e465d6 89
3826564e
MZ
90 out << " (" << Ver.VerStr() << ' ' << Ver.RelStr() << ')';
91 }
b2e465d6
AL
92}
93 /*}}}*/
6c139d6e
AL
94// Simulate::Install - Simulate unpacking of a package /*{{{*/
95// ---------------------------------------------------------------------
96/* */
97bool pkgSimulate::Install(PkgIterator iPkg,string /*File*/)
98{
99 // Adapt the iterator
803ea2a8 100 PkgIterator Pkg = Sim.FindPkg(iPkg.Name(), iPkg.Arch());
6c139d6e
AL
101 Flags[Pkg->ID] = 1;
102
b2e465d6 103 cout << "Inst ";
3826564e 104 Describe(Pkg,cout,true,true);
6c139d6e 105 Sim.MarkInstall(Pkg,false);
803ea2a8 106
6c139d6e 107 // Look for broken conflicts+predepends.
f7f0d6c7 108 for (PkgIterator I = Sim.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
109 {
110 if (Sim[I].InstallVer == 0)
111 continue;
112
b2e465d6
AL
113 for (DepIterator D = Sim[I].InstVerIter(Sim).DependsList(); D.end() == false;)
114 {
115 DepIterator Start;
116 DepIterator End;
117 D.GlobOr(Start,End);
359e46db 118 if (Start.IsNegative() == true ||
b2e465d6 119 End->Type == pkgCache::Dep::PreDepends)
6c139d6e 120 {
b2e465d6 121 if ((Sim[End] & pkgDepCache::DepGInstall) == 0)
6c139d6e 122 {
47f6d1b7 123 cout << " [" << I.FullName(false) << " on " << Start.TargetPkg().FullName(false) << ']';
b2e465d6 124 if (Start->Type == pkgCache::Dep::Conflicts)
47f6d1b7 125 _error->Error("Fatal, conflicts violated %s",I.FullName(false).c_str());
6c139d6e 126 }
b2e465d6
AL
127 }
128 }
6c139d6e
AL
129 }
130
131 if (Sim.BrokenCount() != 0)
132 ShortBreaks();
133 else
04aa15a8 134 cout << endl;
6c139d6e
AL
135 return true;
136}
137 /*}}}*/
138// Simulate::Configure - Simulate configuration of a Package /*{{{*/
139// ---------------------------------------------------------------------
140/* This is not an acurate simulation of relatity, we should really not
141 install the package.. For some investigations it may be necessary
142 however. */
143bool pkgSimulate::Configure(PkgIterator iPkg)
144{
145 // Adapt the iterator
803ea2a8 146 PkgIterator Pkg = Sim.FindPkg(iPkg.Name(), iPkg.Arch());
6c139d6e
AL
147
148 Flags[Pkg->ID] = 2;
803ea2a8 149
6c139d6e
AL
150 if (Sim[Pkg].InstBroken() == true)
151 {
47f6d1b7 152 cout << "Conf " << Pkg.FullName(false) << " broken" << endl;
6c139d6e
AL
153
154 Sim.Update();
155
156 // Print out each package and the failed dependencies
f7f0d6c7 157 for (pkgCache::DepIterator D = Sim[Pkg].InstVerIter(Sim).DependsList(); D.end() == false; ++D)
6c139d6e
AL
158 {
159 if (Sim.IsImportantDep(D) == false ||
160 (Sim[D] & pkgDepCache::DepInstall) != 0)
161 continue;
162
b2e465d6 163 if (D->Type == pkgCache::Dep::Obsoletes)
47f6d1b7 164 cout << " Obsoletes:" << D.TargetPkg().FullName(false);
b2e465d6 165 else if (D->Type == pkgCache::Dep::Conflicts)
47f6d1b7 166 cout << " Conflicts:" << D.TargetPkg().FullName(false);
308c7d30 167 else if (D->Type == pkgCache::Dep::DpkgBreaks)
47f6d1b7 168 cout << " Breaks:" << D.TargetPkg().FullName(false);
6c139d6e 169 else
47f6d1b7 170 cout << " Depends:" << D.TargetPkg().FullName(false);
6c139d6e 171 }
04aa15a8 172 cout << endl;
6c139d6e 173
09a10f9c 174 _error->Error("Conf Broken %s",Pkg.FullName(false).c_str());
6c139d6e
AL
175 }
176 else
b2e465d6
AL
177 {
178 cout << "Conf ";
3826564e 179 Describe(Pkg,cout,false,true);
b2e465d6 180 }
6c139d6e
AL
181
182 if (Sim.BrokenCount() != 0)
183 ShortBreaks();
184 else
04aa15a8 185 cout << endl;
6c139d6e
AL
186
187 return true;
188}
189 /*}}}*/
190// Simulate::Remove - Simulate the removal of a package /*{{{*/
191// ---------------------------------------------------------------------
192/* */
fc4b5c9f 193bool pkgSimulate::Remove(PkgIterator iPkg,bool Purge)
6c139d6e
AL
194{
195 // Adapt the iterator
803ea2a8 196 PkgIterator Pkg = Sim.FindPkg(iPkg.Name(), iPkg.Arch());
c919ad6e
DK
197 if (Pkg.end() == true)
198 {
199 std::cerr << (Purge ? "Purg" : "Remv") << " invalid package " << iPkg.FullName() << std::endl;
200 return false;
201 }
6c139d6e
AL
202
203 Flags[Pkg->ID] = 3;
204 Sim.MarkDelete(Pkg);
803ea2a8 205
fc4b5c9f 206 if (Purge == true)
b2e465d6 207 cout << "Purg ";
fc4b5c9f 208 else
b2e465d6 209 cout << "Remv ";
3826564e 210 Describe(Pkg,cout,true,false);
6c139d6e
AL
211
212 if (Sim.BrokenCount() != 0)
213 ShortBreaks();
214 else
04aa15a8 215 cout << endl;
6c139d6e
AL
216
217 return true;
218}
219 /*}}}*/
220// Simulate::ShortBreaks - Print out a short line describing all breaks /*{{{*/
221// ---------------------------------------------------------------------
222/* */
223void pkgSimulate::ShortBreaks()
224{
04aa15a8 225 cout << " [";
f7f0d6c7 226 for (PkgIterator I = Sim.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
227 {
228 if (Sim[I].InstBroken() == true)
229 {
230 if (Flags[I->ID] == 0)
47f6d1b7 231 cout << I.FullName(false) << ' ';
6c139d6e 232/* else
04aa15a8 233 cout << I.Name() << "! ";*/
6c139d6e
AL
234 }
235 }
04aa15a8 236 cout << ']' << endl;
6c139d6e
AL
237}
238 /*}}}*/
239// ApplyStatus - Adjust for non-ok packages /*{{{*/
240// ---------------------------------------------------------------------
241/* We attempt to change the state of the all packages that have failed
242 installation toward their real state. The ordering code will perform
243 the necessary calculations to deal with the problems. */
244bool pkgApplyStatus(pkgDepCache &Cache)
245{
74a05226
MV
246 pkgDepCache::ActionGroup group(Cache);
247
f7f0d6c7 248 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e 249 {
e481d5b0
AL
250 if (I->VersionList == 0)
251 continue;
252
d38b7b3d
AL
253 // Only choice for a ReInstReq package is to reinstall
254 if (I->InstState == pkgCache::State::ReInstReq ||
255 I->InstState == pkgCache::State::HoldReInstReq)
256 {
5871718b 257 if (I->CurrentVer != 0 && I.CurrentVer().Downloadable() == true)
74a05226 258 Cache.MarkKeep(I, false, false);
813c8eea
AL
259 else
260 {
261 // Is this right? Will dpkg choke on an upgrade?
2a3f3893
AL
262 if (Cache[I].CandidateVer != 0 &&
263 Cache[I].CandidateVerIter(Cache).Downloadable() == true)
74a05226 264 Cache.MarkInstall(I, false, 0, false);
813c8eea 265 else
b2e465d6 266 return _error->Error(_("The package %s needs to be reinstalled, "
09a10f9c 267 "but I can't find an archive for it."),I.FullName(true).c_str());
813c8eea
AL
268 }
269
d38b7b3d
AL
270 continue;
271 }
272
6c139d6e
AL
273 switch (I->CurrentState)
274 {
813c8eea
AL
275 /* This means installation failed somehow - it does not need to be
276 re-unpacked (probably) */
b518cca6
AL
277 case pkgCache::State::UnPacked:
278 case pkgCache::State::HalfConfigured:
9d06bc80
MV
279 case pkgCache::State::TriggersAwaited:
280 case pkgCache::State::TriggersPending:
5871718b 281 if ((I->CurrentVer != 0 && I.CurrentVer().Downloadable() == true) ||
813c8eea 282 I.State() != pkgCache::PkgIterator::NeedsUnpack)
74a05226 283 Cache.MarkKeep(I, false, false);
813c8eea
AL
284 else
285 {
2a3f3893
AL
286 if (Cache[I].CandidateVer != 0 &&
287 Cache[I].CandidateVerIter(Cache).Downloadable() == true)
74a05226 288 Cache.MarkInstall(I, true, 0, false);
813c8eea 289 else
b83cad32 290 Cache.MarkDelete(I, false, 0, false);
813c8eea 291 }
6c139d6e
AL
292 break;
293
294 // This means removal failed
b518cca6 295 case pkgCache::State::HalfInstalled:
b83cad32 296 Cache.MarkDelete(I, false, 0, false);
6c139d6e
AL
297 break;
298
299 default:
b518cca6 300 if (I->InstState != pkgCache::State::Ok)
6c139d6e 301 return _error->Error("The package %s is not ok and I "
09a10f9c 302 "don't know how to fix it!",I.FullName(false).c_str());
6c139d6e
AL
303 }
304 }
305 return true;
306}
307 /*}}}*/
308// FixBroken - Fix broken packages /*{{{*/
309// ---------------------------------------------------------------------
0a8e3465
AL
310/* This autoinstalls every broken package and then runs the problem resolver
311 on the result. */
6c139d6e
AL
312bool pkgFixBroken(pkgDepCache &Cache)
313{
74a05226
MV
314 pkgDepCache::ActionGroup group(Cache);
315
6c139d6e 316 // Auto upgrade all broken packages
f7f0d6c7 317 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e 318 if (Cache[I].NowBroken() == true)
74a05226 319 Cache.MarkInstall(I, true, 0, false);
7e798dd7 320
6c139d6e
AL
321 /* Fix packages that are in a NeedArchive state but don't have a
322 downloadable install version */
f7f0d6c7 323 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
324 {
325 if (I.State() != pkgCache::PkgIterator::NeedsUnpack ||
326 Cache[I].Delete() == true)
327 continue;
328
b518cca6 329 if (Cache[I].InstVerIter(Cache).Downloadable() == false)
6c139d6e
AL
330 continue;
331
74a05226 332 Cache.MarkInstall(I, true, 0, false);
6c139d6e
AL
333 }
334
b2e465d6 335 pkgProblemResolver Fix(&Cache);
6c139d6e
AL
336 return Fix.Resolve(true);
337}
338 /*}}}*/
339// DistUpgrade - Distribution upgrade /*{{{*/
340// ---------------------------------------------------------------------
341/* This autoinstalls every package and then force installs every
342 pre-existing package. This creates the initial set of conditions which
343 most likely contain problems because too many things were installed.
344
0a8e3465 345 The problem resolver is used to resolve the problems.
6c139d6e
AL
346 */
347bool pkgDistUpgrade(pkgDepCache &Cache)
348{
98278a81 349 std::string const solver = _config->Find("APT::Solver", "internal");
b57c0e35
DK
350 if (solver != "internal") {
351 OpTextProgress Prog(*_config);
352 return EDSP::ResolveExternal(solver.c_str(), Cache, false, true, false, &Prog);
353 }
741b7da9 354
74a05226
MV
355 pkgDepCache::ActionGroup group(Cache);
356
c427b1e2
DK
357 /* Upgrade all installed packages first without autoinst to help the resolver
358 in versioned or-groups to upgrade the old solver instead of installing
359 a new one (if the old solver is not the first one [anymore]) */
360 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
361 if (I->CurrentVer != 0)
362 Cache.MarkInstall(I, false, 0, false);
363
6c139d6e
AL
364 /* Auto upgrade all installed packages, this provides the basis
365 for the installation */
f7f0d6c7 366 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e 367 if (I->CurrentVer != 0)
74a05226 368 Cache.MarkInstall(I, true, 0, false);
6c139d6e 369
e5a91f7e
DK
370 /* Now, install each essential package which is not installed
371 (and not provided by another package in the same name group) */
372 std::string essential = _config->Find("pkgCacheGen::Essential", "all");
373 if (essential == "all")
374 {
375 for (pkgCache::GrpIterator G = Cache.GrpBegin(); G.end() == false; ++G)
376 {
377 bool isEssential = false;
378 bool instEssential = false;
379 for (pkgCache::PkgIterator P = G.PackageList(); P.end() == false; P = G.NextPkg(P))
380 {
381 if ((P->Flags & pkgCache::Flag::Essential) != pkgCache::Flag::Essential)
382 continue;
383 isEssential = true;
384 if (Cache[P].Install() == true)
385 {
386 instEssential = true;
387 break;
388 }
389 }
390 if (isEssential == false || instEssential == true)
391 continue;
392 pkgCache::PkgIterator P = G.FindPreferredPkg();
393 Cache.MarkInstall(P, true, 0, false);
394 }
395 }
396 else if (essential != "none")
397 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
398 if ((I->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential)
399 Cache.MarkInstall(I, true, 0, false);
6c139d6e
AL
400
401 /* We do it again over all previously installed packages to force
402 conflict resolution on them all. */
f7f0d6c7 403 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e 404 if (I->CurrentVer != 0)
74a05226 405 Cache.MarkInstall(I, false, 0, false);
6c139d6e 406
b2e465d6 407 pkgProblemResolver Fix(&Cache);
c88edf1d 408
6c139d6e 409 // Hold back held packages.
4490f2de 410 if (_config->FindB("APT::Ignore-Hold",false) == false)
6c139d6e 411 {
f7f0d6c7 412 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e 413 {
c88edf1d
AL
414 if (I->SelectedState == pkgCache::State::Hold)
415 {
416 Fix.Protect(I);
74a05226 417 Cache.MarkKeep(I, false, false);
c88edf1d 418 }
6c139d6e
AL
419 }
420 }
421
422 return Fix.Resolve();
423}
424 /*}}}*/
facea693
MV
425// AllUpgradeNoNewPackages - Upgrade but no removals or new pkgs /*{{{*/
426bool pkgAllUpgradeNoNewPackages(pkgDepCache &Cache)
0a8e3465 427{
98278a81 428 std::string const solver = _config->Find("APT::Solver", "internal");
b57c0e35
DK
429 if (solver != "internal") {
430 OpTextProgress Prog(*_config);
431 return EDSP::ResolveExternal(solver.c_str(), Cache, true, false, false, &Prog);
432 }
741b7da9 433
74a05226
MV
434 pkgDepCache::ActionGroup group(Cache);
435
b2e465d6 436 pkgProblemResolver Fix(&Cache);
0a8e3465
AL
437
438 if (Cache.BrokenCount() != 0)
439 return false;
440
441 // Upgrade all installed packages
f7f0d6c7 442 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
0a8e3465
AL
443 {
444 if (Cache[I].Install() == true)
445 Fix.Protect(I);
446
b2e465d6 447 if (_config->FindB("APT::Ignore-Hold",false) == false)
c88edf1d
AL
448 if (I->SelectedState == pkgCache::State::Hold)
449 continue;
0a8e3465
AL
450
451 if (I->CurrentVer != 0 && Cache[I].InstallVer != 0)
74a05226 452 Cache.MarkInstall(I, false, 0, false);
0a8e3465
AL
453 }
454
b9179170
MV
455 return Fix.ResolveByKeep();
456}
457 /*}}}*/
facea693 458// AllUpgradeWithNewInstalls - Upgrade + install new packages as needed /*{{{*/
b9179170
MV
459// ---------------------------------------------------------------------
460/* Right now the system must be consistent before this can be called.
461 * Upgrade as much as possible without deleting anything (useful for
462 * stable systems)
463 */
facea693 464bool pkgAllUpgradeWithNewPackages(pkgDepCache &Cache)
b9179170
MV
465{
466 pkgDepCache::ActionGroup group(Cache);
467
468 pkgProblemResolver Fix(&Cache);
469
470 if (Cache.BrokenCount() != 0)
471 return false;
472
473 // provide the initial set of stuff we want to upgrade by marking
474 // all upgradable packages for upgrade
475 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
476 {
477 if (I->CurrentVer != 0 && Cache[I].InstallVer != 0)
478 {
479 if (_config->FindB("APT::Ignore-Hold",false) == false)
480 if (I->SelectedState == pkgCache::State::Hold)
481 continue;
482
483 Cache.MarkInstall(I, false, 0, false);
484 }
485 }
486
487 // then let auto-install loose
488 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
489 if (Cache[I].Install())
490 Cache.MarkInstall(I, true, 0, false);
491
492 // ... but it may remove stuff, we we need to clean up afterwards again
493 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
494 if (Cache[I].Delete() == true)
495 Cache.MarkKeep(I, false, false);
496
497 // resolve remaining issues via keep
0a8e3465
AL
498 return Fix.ResolveByKeep();
499}
500 /*}}}*/
facea693
MV
501// AllUpgrade - Upgrade as many packages as possible /*{{{*/
502// ---------------------------------------------------------------------
503/* Right now the system must be consistent before this can be called.
504 It also will not change packages marked for install, it only tries
505 to install packages not marked for install */
506bool pkgAllUpgrade(pkgDepCache &Cache)
507{
508 return pkgAllUpgradeNoNewPackages(Cache);
509}
510 /*}}}*/
7e798dd7
AL
511// MinimizeUpgrade - Minimizes the set of packages to be upgraded /*{{{*/
512// ---------------------------------------------------------------------
513/* This simply goes over the entire set of packages and tries to keep
514 each package marked for upgrade. If a conflict is generated then
515 the package is restored. */
516bool pkgMinimizeUpgrade(pkgDepCache &Cache)
517{
74a05226
MV
518 pkgDepCache::ActionGroup group(Cache);
519
7e798dd7
AL
520 if (Cache.BrokenCount() != 0)
521 return false;
522
abc8419e 523 // We loop for 10 tries to get the minimal set size.
7e798dd7 524 bool Change = false;
a005475e 525 unsigned int Count = 0;
7e798dd7
AL
526 do
527 {
528 Change = false;
f7f0d6c7 529 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
7e798dd7
AL
530 {
531 // Not interesting
532 if (Cache[I].Upgrade() == false || Cache[I].NewInstall() == true)
533 continue;
a005475e 534
7e798dd7 535 // Keep it and see if that is OK
74a05226 536 Cache.MarkKeep(I, false, false);
7e798dd7 537 if (Cache.BrokenCount() != 0)
74a05226 538 Cache.MarkInstall(I, false, 0, false);
7e798dd7 539 else
a005475e
AL
540 {
541 // If keep didnt actually do anything then there was no change..
542 if (Cache[I].Upgrade() == false)
543 Change = true;
544 }
7e798dd7 545 }
f7f0d6c7 546 ++Count;
7e798dd7 547 }
a005475e 548 while (Change == true && Count < 10);
7e798dd7
AL
549
550 if (Cache.BrokenCount() != 0)
551 return _error->Error("Internal Error in pkgMinimizeUpgrade");
552
553 return true;
554}
555 /*}}}*/
facea693 556// APT::Upgrade::Upgrade - Upgrade using a specific strategy /*{{{*/
5ca0cf51 557bool APT::Upgrade::Upgrade(pkgDepCache &Cache, int mode)
facea693 558{
5ca0cf51
MV
559 if (mode == 0)
560 {
561 return pkgDistUpgrade(Cache);
562 }
563 else if ((mode & ~FORBID_REMOVE_PACKAGES) == 0)
564 {
565 return pkgAllUpgradeWithNewPackages(Cache);
566 }
567 else if ((mode & ~(FORBID_REMOVE_PACKAGES|FORBID_NEW_INSTALL_PACKAGES)) == 0)
568 {
569 return pkgAllUpgradeNoNewPackages(Cache);
facea693 570 }
5ca0cf51
MV
571 else
572 _error->Error("pkgAllUpgrade called with unsupported mode %i", mode);
573
facea693
MV
574 return false;
575}
576 /*}}}*/
6c139d6e
AL
577// ProblemResolver::pkgProblemResolver - Constructor /*{{{*/
578// ---------------------------------------------------------------------
579/* */
dcaa1185 580pkgProblemResolver::pkgProblemResolver(pkgDepCache *pCache) : d(NULL), Cache(*pCache)
6c139d6e
AL
581{
582 // Allocate memory
b2e465d6 583 unsigned long Size = Cache.Head().PackageCount;
d0f2c87c 584 Scores = new int[Size];
6c139d6e
AL
585 Flags = new unsigned char[Size];
586 memset(Flags,0,sizeof(*Flags)*Size);
587
588 // Set debug to true to see its decision logic
0a8e3465 589 Debug = _config->FindB("Debug::pkgProblemResolver",false);
6c139d6e
AL
590}
591 /*}}}*/
b2e465d6
AL
592// ProblemResolver::~pkgProblemResolver - Destructor /*{{{*/
593// ---------------------------------------------------------------------
594/* */
595pkgProblemResolver::~pkgProblemResolver()
596{
597 delete [] Scores;
598 delete [] Flags;
599}
600 /*}}}*/
6c139d6e
AL
601// ProblemResolver::ScoreSort - Sort the list by score /*{{{*/
602// ---------------------------------------------------------------------
603/* */
604int pkgProblemResolver::ScoreSort(const void *a,const void *b)
605{
606 Package const **A = (Package const **)a;
607 Package const **B = (Package const **)b;
608 if (This->Scores[(*A)->ID] > This->Scores[(*B)->ID])
609 return -1;
610 if (This->Scores[(*A)->ID] < This->Scores[(*B)->ID])
611 return 1;
612 return 0;
613}
614 /*}}}*/
615// ProblemResolver::MakeScores - Make the score table /*{{{*/
616// ---------------------------------------------------------------------
617/* */
618void pkgProblemResolver::MakeScores()
619{
b2e465d6 620 unsigned long Size = Cache.Head().PackageCount;
6c139d6e
AL
621 memset(Scores,0,sizeof(*Scores)*Size);
622
b9179170
MV
623 // maps to pkgCache::State::VerPriority:
624 // Required Important Standard Optional Extra
d0f2c87c 625 int PrioMap[] = {
8b4894fe 626 0,
84de0cea 627 _config->FindI("pkgProblemResolver::Scores::Required",3),
b9179170 628 _config->FindI("pkgProblemResolver::Scores::Important",2),
d0f2c87c
CW
629 _config->FindI("pkgProblemResolver::Scores::Standard",1),
630 _config->FindI("pkgProblemResolver::Scores::Optional",-1),
631 _config->FindI("pkgProblemResolver::Scores::Extra",-2)
8b4894fe 632 };
d0f2c87c
CW
633 int PrioEssentials = _config->FindI("pkgProblemResolver::Scores::Essentials",100);
634 int PrioInstalledAndNotObsolete = _config->FindI("pkgProblemResolver::Scores::NotObsolete",1);
635 int PrioDepends = _config->FindI("pkgProblemResolver::Scores::Depends",1);
636 int PrioRecommends = _config->FindI("pkgProblemResolver::Scores::Recommends",1);
637 int AddProtected = _config->FindI("pkgProblemResolver::Scores::AddProtected",10000);
638 int AddEssential = _config->FindI("pkgProblemResolver::Scores::AddEssential",5000);
8b4894fe
MV
639
640 if (_config->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
641 clog << "Settings used to calculate pkgProblemResolver::Scores::" << endl
84de0cea
MV
642 << " Required => " << PrioMap[pkgCache::State::Required] << endl
643 << " Important => " << PrioMap[pkgCache::State::Important] << endl
644 << " Standard => " << PrioMap[pkgCache::State::Standard] << endl
645 << " Optional => " << PrioMap[pkgCache::State::Optional] << endl
646 << " Extra => " << PrioMap[pkgCache::State::Extra] << endl
8b4894fe
MV
647 << " Essentials => " << PrioEssentials << endl
648 << " InstalledAndNotObsolete => " << PrioInstalledAndNotObsolete << endl
649 << " Depends => " << PrioDepends << endl
53391d0f 650 << " Recommends => " << PrioRecommends << endl
8b4894fe
MV
651 << " AddProtected => " << AddProtected << endl
652 << " AddEssential => " << AddEssential << endl;
653
6c139d6e 654 // Generate the base scores for a package based on its properties
f7f0d6c7 655 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
656 {
657 if (Cache[I].InstallVer == 0)
658 continue;
659
d0f2c87c 660 int &Score = Scores[I->ID];
6c139d6e 661
7365ff46 662 /* This is arbitrary, it should be high enough to elevate an
6c139d6e
AL
663 essantial package above most other packages but low enough
664 to allow an obsolete essential packages to be removed by
665 a conflicts on a powerfull normal package (ie libc6) */
c5200869
JAK
666 if ((I->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential
667 || (I->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important)
8b4894fe 668 Score += PrioEssentials;
6c139d6e
AL
669
670 // We transform the priority
6c139d6e
AL
671 if (Cache[I].InstVerIter(Cache)->Priority <= 5)
672 Score += PrioMap[Cache[I].InstVerIter(Cache)->Priority];
673
674 /* This helps to fix oddball problems with conflicting packages
4172c784
MV
675 on the same level. We enhance the score of installed packages
676 if those are not obsolete
677 */
020daa7b 678 if (I->CurrentVer != 0 && Cache[I].CandidateVer != 0 && Cache[I].CandidateVerIter(Cache).Downloadable())
8b4894fe 679 Score += PrioInstalledAndNotObsolete;
6c139d6e
AL
680 }
681
682 // Now that we have the base scores we go and propogate dependencies
f7f0d6c7 683 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
684 {
685 if (Cache[I].InstallVer == 0)
686 continue;
687
f7f0d6c7 688 for (pkgCache::DepIterator D = Cache[I].InstVerIter(Cache).DependsList(); D.end() == false; ++D)
6c139d6e 689 {
3a998f6a 690 if (D->Type == pkgCache::Dep::Depends ||
53391d0f
MV
691 D->Type == pkgCache::Dep::PreDepends)
692 Scores[D.TargetPkg()->ID] += PrioDepends;
693 else if (D->Type == pkgCache::Dep::Recommends)
694 Scores[D.TargetPkg()->ID] += PrioRecommends;
6c139d6e
AL
695 }
696 }
697
698 // Copy the scores to advoid additive looping
d0f2c87c 699 SPtrArray<int> OldScores = new int[Size];
6c139d6e
AL
700 memcpy(OldScores,Scores,sizeof(*Scores)*Size);
701
702 /* Now we cause 1 level of dependency inheritance, that is we add the
703 score of the packages that depend on the target Package. This
704 fortifies high scoring packages */
f7f0d6c7 705 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
706 {
707 if (Cache[I].InstallVer == 0)
708 continue;
709
f7f0d6c7 710 for (pkgCache::DepIterator D = I.RevDependsList(); D.end() == false; ++D)
6c139d6e
AL
711 {
712 // Only do it for the install version
713 if ((pkgCache::Version *)D.ParentVer() != Cache[D.ParentPkg()].InstallVer ||
3a998f6a
MV
714 (D->Type != pkgCache::Dep::Depends &&
715 D->Type != pkgCache::Dep::PreDepends &&
716 D->Type != pkgCache::Dep::Recommends))
6c139d6e
AL
717 continue;
718
dec5b117
MV
719 // Do not propagate negative scores otherwise
720 // an extra (-2) package might score better than an optional (-1)
721 if (OldScores[D.ParentPkg()->ID] > 0)
722 Scores[I->ID] += OldScores[D.ParentPkg()->ID];
6c139d6e
AL
723 }
724 }
725
726 /* Now we propogate along provides. This makes the packages that
727 provide important packages extremely important */
f7f0d6c7 728 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e 729 {
f7f0d6c7 730 for (pkgCache::PrvIterator P = I.ProvidesList(); P.end() == false; ++P)
6c139d6e
AL
731 {
732 // Only do it once per package
733 if ((pkgCache::Version *)P.OwnerVer() != Cache[P.OwnerPkg()].InstallVer)
734 continue;
735 Scores[P.OwnerPkg()->ID] += abs(Scores[I->ID] - OldScores[I->ID]);
736 }
737 }
738
739 /* Protected things are pushed really high up. This number should put them
740 ahead of everything */
f7f0d6c7 741 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
d2685fd6 742 {
6c139d6e 743 if ((Flags[I->ID] & Protected) != 0)
8b4894fe 744 Scores[I->ID] += AddProtected;
c5200869
JAK
745 if ((I->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential ||
746 (I->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important)
8b4894fe
MV
747 Scores[I->ID] += AddEssential;
748 }
6c139d6e
AL
749}
750 /*}}}*/
751// ProblemResolver::DoUpgrade - Attempt to upgrade this package /*{{{*/
752// ---------------------------------------------------------------------
753/* This goes through and tries to reinstall packages to make this package
754 installable */
755bool pkgProblemResolver::DoUpgrade(pkgCache::PkgIterator Pkg)
756{
74a05226
MV
757 pkgDepCache::ActionGroup group(Cache);
758
6c139d6e
AL
759 if ((Flags[Pkg->ID] & Upgradable) == 0 || Cache[Pkg].Upgradable() == false)
760 return false;
3a486305
AL
761 if ((Flags[Pkg->ID] & Protected) == Protected)
762 return false;
0a8e3465 763
6c139d6e
AL
764 Flags[Pkg->ID] &= ~Upgradable;
765
766 bool WasKept = Cache[Pkg].Keep();
74a05226 767 Cache.MarkInstall(Pkg, false, 0, false);
6c139d6e 768
0a8e3465
AL
769 // This must be a virtual package or something like that.
770 if (Cache[Pkg].InstVerIter(Cache).end() == true)
771 return false;
772
6c139d6e
AL
773 // Isolate the problem dependency
774 bool Fail = false;
775 for (pkgCache::DepIterator D = Cache[Pkg].InstVerIter(Cache).DependsList(); D.end() == false;)
776 {
777 // Compute a single dependency element (glob or)
778 pkgCache::DepIterator Start = D;
779 pkgCache::DepIterator End = D;
4b1b89c5 780 for (bool LastOR = true; D.end() == false && LastOR == true;)
6c139d6e 781 {
b518cca6 782 LastOR = (D->CompareOp & pkgCache::Dep::Or) == pkgCache::Dep::Or;
0284eee4 783 ++D;
6c139d6e
AL
784 if (LastOR == true)
785 End = D;
786 }
787
788 // We only worry about critical deps.
789 if (End.IsCritical() != true)
790 continue;
4b1b89c5
AL
791
792 // Iterate over all the members in the or group
793 while (1)
0a8e3465 794 {
4b1b89c5
AL
795 // Dep is ok now
796 if ((Cache[End] & pkgDepCache::DepGInstall) == pkgDepCache::DepGInstall)
797 break;
798
799 // Do not change protected packages
800 PkgIterator P = Start.SmartTargetPkg();
801 if ((Flags[P->ID] & Protected) == Protected)
802 {
803 if (Debug == true)
47f6d1b7 804 clog << " Reinst Failed because of protected " << P.FullName(false) << endl;
4b1b89c5 805 Fail = true;
4b1b89c5 806 }
648e3cb4 807 else
6c139d6e 808 {
648e3cb4
AL
809 // Upgrade the package if the candidate version will fix the problem.
810 if ((Cache[Start] & pkgDepCache::DepCVer) == pkgDepCache::DepCVer)
811 {
812 if (DoUpgrade(P) == false)
813 {
814 if (Debug == true)
47f6d1b7 815 clog << " Reinst Failed because of " << P.FullName(false) << endl;
648e3cb4
AL
816 Fail = true;
817 }
818 else
819 {
820 Fail = false;
821 break;
822 }
823 }
824 else
4b1b89c5 825 {
648e3cb4
AL
826 /* We let the algorithm deal with conflicts on its next iteration,
827 it is much smarter than us */
359e46db 828 if (Start.IsNegative() == true)
b2e465d6 829 break;
648e3cb4 830
4b1b89c5 831 if (Debug == true)
47f6d1b7 832 clog << " Reinst Failed early because of " << Start.TargetPkg().FullName(false) << endl;
4b1b89c5 833 Fail = true;
648e3cb4 834 }
4b1b89c5 835 }
6c139d6e 836
4b1b89c5
AL
837 if (Start == End)
838 break;
f7f0d6c7 839 ++Start;
4b1b89c5
AL
840 }
841 if (Fail == true)
6c139d6e 842 break;
6c139d6e
AL
843 }
844
845 // Undo our operations - it might be smart to undo everything this did..
846 if (Fail == true)
847 {
848 if (WasKept == true)
74a05226 849 Cache.MarkKeep(Pkg, false, false);
6c139d6e 850 else
b83cad32 851 Cache.MarkDelete(Pkg, false, 0, false);
6c139d6e
AL
852 return false;
853 }
854
855 if (Debug == true)
47f6d1b7 856 clog << " Re-Instated " << Pkg.FullName(false) << endl;
6c139d6e
AL
857 return true;
858}
859 /*}}}*/
6d38011b
DK
860// ProblemResolver::Resolve - calls a resolver to fix the situation /*{{{*/
861// ---------------------------------------------------------------------
862/* */
863bool pkgProblemResolver::Resolve(bool BrokenFix)
864{
98278a81 865 std::string const solver = _config->Find("APT::Solver", "internal");
b57c0e35
DK
866 if (solver != "internal") {
867 OpTextProgress Prog(*_config);
868 return EDSP::ResolveExternal(solver.c_str(), Cache, false, false, false, &Prog);
869 }
6d38011b
DK
870 return ResolveInternal(BrokenFix);
871}
872 /*}}}*/
873// ProblemResolver::ResolveInternal - Run the resolution pass /*{{{*/
6c139d6e
AL
874// ---------------------------------------------------------------------
875/* This routines works by calculating a score for each package. The score
876 is derived by considering the package's priority and all reverse
877 dependents giving an integer that reflects the amount of breakage that
878 adjusting the package will inflict.
879
880 It goes from highest score to lowest and corrects all of the breaks by
881 keeping or removing the dependant packages. If that fails then it removes
882 the package itself and goes on. The routine should be able to intelligently
883 go from any broken state to a fixed state.
884
885 The BrokenFix flag enables a mode where the algorithm tries to
886 upgrade packages to advoid problems. */
6d38011b 887bool pkgProblemResolver::ResolveInternal(bool const BrokenFix)
6c139d6e 888{
74a05226
MV
889 pkgDepCache::ActionGroup group(Cache);
890
6c139d6e
AL
891 // Record which packages are marked for install
892 bool Again = false;
893 do
894 {
895 Again = false;
f7f0d6c7 896 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
897 {
898 if (Cache[I].Install() == true)
899 Flags[I->ID] |= PreInstalled;
900 else
901 {
902 if (Cache[I].InstBroken() == true && BrokenFix == true)
903 {
74a05226 904 Cache.MarkInstall(I, false, 0, false);
6c139d6e
AL
905 if (Cache[I].Install() == true)
906 Again = true;
907 }
908
909 Flags[I->ID] &= ~PreInstalled;
910 }
911 Flags[I->ID] |= Upgradable;
912 }
913 }
914 while (Again == true);
915
32b5dd08 916 if (Debug == true) {
49b49018
MV
917 clog << "Starting pkgProblemResolver with broken count: "
918 << Cache.BrokenCount() << endl;
32b5dd08 919 }
6c139d6e
AL
920
921 MakeScores();
6d38011b
DK
922
923 unsigned long const Size = Cache.Head().PackageCount;
924
6c139d6e
AL
925 /* We have to order the packages so that the broken fixing pass
926 operates from highest score to lowest. This prevents problems when
927 high score packages cause the removal of lower score packages that
928 would cause the removal of even lower score packages. */
b2e465d6 929 SPtrArray<pkgCache::Package *> PList = new pkgCache::Package *[Size];
6c139d6e 930 pkgCache::Package **PEnd = PList;
f7f0d6c7 931 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
6c139d6e
AL
932 *PEnd++ = I;
933 This = this;
934 qsort(PList,PEnd - PList,sizeof(*PList),&ScoreSort);
8b4894fe
MV
935
936 if (_config->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
937 {
938 clog << "Show Scores" << endl;
939 for (pkgCache::Package **K = PList; K != PEnd; K++)
940 if (Scores[(*K)->ID] != 0)
941 {
942 pkgCache::PkgIterator Pkg(Cache,*K);
943 clog << Scores[(*K)->ID] << ' ' << Pkg << std::endl;
944 }
945 }
6c139d6e 946
32b5dd08 947 if (Debug == true) {
49b49018
MV
948 clog << "Starting 2 pkgProblemResolver with broken count: "
949 << Cache.BrokenCount() << endl;
32b5dd08 950 }
8b4894fe 951
6c139d6e
AL
952 /* Now consider all broken packages. For each broken package we either
953 remove the package or fix it's problem. We do this once, it should
954 not be possible for a loop to form (that is a < b < c and fixing b by
955 changing a breaks c) */
956 bool Change = true;
09a10f9c 957 bool const TryFixByInstall = _config->FindB("pkgProblemResolver::FixByInstall", true);
6c139d6e
AL
958 for (int Counter = 0; Counter != 10 && Change == true; Counter++)
959 {
960 Change = false;
961 for (pkgCache::Package **K = PList; K != PEnd; K++)
962 {
963 pkgCache::PkgIterator I(Cache,*K);
964
965 /* We attempt to install this and see if any breaks result,
966 this takes care of some strange cases */
967 if (Cache[I].CandidateVer != Cache[I].InstallVer &&
968 I->CurrentVer != 0 && Cache[I].InstallVer != 0 &&
969 (Flags[I->ID] & PreInstalled) != 0 &&
0a8e3465
AL
970 (Flags[I->ID] & Protected) == 0 &&
971 (Flags[I->ID] & ReInstateTried) == 0)
6c139d6e
AL
972 {
973 if (Debug == true)
09a10f9c 974 clog << " Try to Re-Instate (" << Counter << ") " << I.FullName(false) << endl;
a6568219 975 unsigned long OldBreaks = Cache.BrokenCount();
6c139d6e 976 pkgCache::Version *OldVer = Cache[I].InstallVer;
0a8e3465
AL
977 Flags[I->ID] &= ReInstateTried;
978
74a05226 979 Cache.MarkInstall(I, false, 0, false);
6c139d6e
AL
980 if (Cache[I].InstBroken() == true ||
981 OldBreaks < Cache.BrokenCount())
982 {
983 if (OldVer == 0)
b83cad32 984 Cache.MarkDelete(I, false, 0, false);
6c139d6e 985 else
74a05226 986 Cache.MarkKeep(I, false, false);
6c139d6e
AL
987 }
988 else
989 if (Debug == true)
47f6d1b7 990 clog << "Re-Instated " << I.FullName(false) << " (" << OldBreaks << " vs " << Cache.BrokenCount() << ')' << endl;
6c139d6e
AL
991 }
992
993 if (Cache[I].InstallVer == 0 || Cache[I].InstBroken() == false)
994 continue;
995
00b47c98 996 if (Debug == true)
09a10f9c 997 clog << "Investigating (" << Counter << ") " << I << endl;
00b47c98 998
6c139d6e
AL
999 // Isolate the problem dependency
1000 PackageKill KillList[100];
1001 PackageKill *LEnd = KillList;
421c8d10
AL
1002 bool InOr = false;
1003 pkgCache::DepIterator Start;
1004 pkgCache::DepIterator End;
b2e465d6 1005 PackageKill *OldEnd = LEnd;
648e3cb4
AL
1006
1007 enum {OrRemove,OrKeep} OrOp = OrRemove;
421c8d10
AL
1008 for (pkgCache::DepIterator D = Cache[I].InstVerIter(Cache).DependsList();
1009 D.end() == false || InOr == true;)
6c139d6e
AL
1010 {
1011 // Compute a single dependency element (glob or)
648e3cb4
AL
1012 if (Start == End)
1013 {
1014 // Decide what to do
09a10f9c 1015 if (InOr == true && OldEnd == LEnd)
648e3cb4 1016 {
09a10f9c 1017 if (OrOp == OrRemove)
70777d4b
AL
1018 {
1019 if ((Flags[I->ID] & Protected) != Protected)
00b47c98
AL
1020 {
1021 if (Debug == true)
47f6d1b7 1022 clog << " Or group remove for " << I.FullName(false) << endl;
b83cad32 1023 Cache.MarkDelete(I, false, 0, false);
cd14eaf2 1024 Change = true;
09a10f9c
DK
1025 }
1026 }
1027 else if (OrOp == OrKeep)
00b47c98
AL
1028 {
1029 if (Debug == true)
47f6d1b7 1030 clog << " Or group keep for " << I.FullName(false) << endl;
74a05226 1031 Cache.MarkKeep(I, false, false);
cd14eaf2 1032 Change = true;
b2e465d6 1033 }
648e3cb4
AL
1034 }
1035
b2e465d6
AL
1036 /* We do an extra loop (as above) to finalize the or group
1037 processing */
1038 InOr = false;
648e3cb4 1039 OrOp = OrRemove;
421c8d10 1040 D.GlobOr(Start,End);
b2e465d6
AL
1041 if (Start.end() == true)
1042 break;
cd14eaf2 1043
b2e465d6
AL
1044 // We only worry about critical deps.
1045 if (End.IsCritical() != true)
1046 continue;
cd14eaf2 1047
648e3cb4
AL
1048 InOr = Start != End;
1049 OldEnd = LEnd;
cd14eaf2 1050 }
421c8d10 1051 else
4cc152f9 1052 {
f7f0d6c7 1053 ++Start;
4cc152f9
MV
1054 // We only worry about critical deps.
1055 if (Start.IsCritical() != true)
1056 continue;
1057 }
cd14eaf2 1058
6c139d6e
AL
1059 // Dep is ok
1060 if ((Cache[End] & pkgDepCache::DepGInstall) == pkgDepCache::DepGInstall)
cd14eaf2
AL
1061 {
1062 InOr = false;
6c139d6e 1063 continue;
cd14eaf2
AL
1064 }
1065
6c139d6e 1066 if (Debug == true)
47f6d1b7 1067 clog << "Broken " << Start << endl;
fcf85120
AL
1068
1069 /* Look across the version list. If there are no possible
1070 targets then we keep the package and bail. This is necessary
1071 if a package has a dep on another package that cant be found */
b2e465d6 1072 SPtrArray<pkgCache::Version *> VList = Start.AllTargets();
fcf85120 1073 if (*VList == 0 && (Flags[I->ID] & Protected) != Protected &&
359e46db 1074 Start.IsNegative() == false &&
fcf85120 1075 Cache[I].NowBroken() == false)
648e3cb4
AL
1076 {
1077 if (InOr == true)
1078 {
1079 /* No keep choice because the keep being OK could be the
1080 result of another element in the OR group! */
1081 continue;
1082 }
1083
fcf85120 1084 Change = true;
74a05226 1085 Cache.MarkKeep(I, false, false);
fcf85120
AL
1086 break;
1087 }
1088
6c139d6e
AL
1089 bool Done = false;
1090 for (pkgCache::Version **V = VList; *V != 0; V++)
1091 {
1092 pkgCache::VerIterator Ver(Cache,*V);
1093 pkgCache::PkgIterator Pkg = Ver.ParentPkg();
a6bfe583 1094
2ba99db8
MV
1095 /* This is a conflicts, and the version we are looking
1096 at is not the currently selected version of the
1097 package, which means it is not necessary to
1098 remove/keep */
359e46db 1099 if (Cache[Pkg].InstallVer != Ver && Start.IsNegative() == true)
4429616b 1100 {
2ba99db8
MV
1101 if (Debug)
1102 clog << " Conflicts//Breaks against version "
1103 << Ver.VerStr() << " for " << Pkg.Name()
1104 << " but that is not InstVer, ignoring"
24e93662 1105 << endl;
2ba99db8 1106 continue;
4429616b
MV
1107 }
1108
6c139d6e 1109 if (Debug == true)
47f6d1b7
DK
1110 clog << " Considering " << Pkg.FullName(false) << ' ' << (int)Scores[Pkg->ID] <<
1111 " as a solution to " << I.FullName(false) << ' ' << (int)Scores[I->ID] << endl;
a6bfe583
AL
1112
1113 /* Try to fix the package under consideration rather than
1114 fiddle with the VList package */
6c139d6e 1115 if (Scores[I->ID] <= Scores[Pkg->ID] ||
421c8d10 1116 ((Cache[Start] & pkgDepCache::DepNow) == 0 &&
359e46db 1117 End.IsNegative() == false))
6c139d6e 1118 {
200f8c52 1119 // Try a little harder to fix protected packages..
3b5421b4 1120 if ((Flags[I->ID] & Protected) == Protected)
200f8c52
AL
1121 {
1122 if (DoUpgrade(Pkg) == true)
0296c633 1123 {
b2e465d6
AL
1124 if (Scores[Pkg->ID] > Scores[I->ID])
1125 Scores[Pkg->ID] = Scores[I->ID];
0296c633
AL
1126 break;
1127 }
1128
6c139d6e 1129 continue;
200f8c52
AL
1130 }
1131
1132 /* See if a keep will do, unless the package is protected,
648e3cb4
AL
1133 then installing it will be necessary */
1134 bool Installed = Cache[I].Install();
74a05226 1135 Cache.MarkKeep(I, false, false);
6c139d6e
AL
1136 if (Cache[I].InstBroken() == false)
1137 {
648e3cb4
AL
1138 // Unwind operation will be keep now
1139 if (OrOp == OrRemove)
1140 OrOp = OrKeep;
1141
1142 // Restore
1143 if (InOr == true && Installed == true)
74a05226 1144 Cache.MarkInstall(I, false, 0, false);
648e3cb4 1145
6c139d6e 1146 if (Debug == true)
47f6d1b7 1147 clog << " Holding Back " << I.FullName(false) << " rather than change " << Start.TargetPkg().FullName(false) << endl;
6c139d6e
AL
1148 }
1149 else
421c8d10 1150 {
6c139d6e
AL
1151 if (BrokenFix == false || DoUpgrade(I) == false)
1152 {
421c8d10 1153 // Consider other options
87da7451 1154 if (InOr == false || Cache[I].Garbage == true)
421c8d10 1155 {
6910a2ac 1156 if (Debug == true)
47f6d1b7 1157 clog << " Removing " << I.FullName(false) << " rather than change " << Start.TargetPkg().FullName(false) << endl;
b83cad32 1158 Cache.MarkDelete(I, false, 0, false);
6910a2ac
DK
1159 if (Counter > 1 && Scores[Pkg->ID] > Scores[I->ID])
1160 Scores[I->ID] = Scores[Pkg->ID];
d6ebeb21 1161 }
09a10f9c
DK
1162 else if (TryFixByInstall == true &&
1163 Start.TargetPkg()->CurrentVer == 0 &&
1164 Cache[Start.TargetPkg()].Delete() == false &&
a3f1a6cc 1165 (Flags[Start.TargetPkg()->ID] & ToRemove) != ToRemove &&
09a10f9c
DK
1166 Cache.GetCandidateVer(Start.TargetPkg()).end() == false)
1167 {
1168 /* Before removing or keeping the package with the broken dependency
1169 try instead to install the first not previously installed package
1170 solving this dependency. This helps every time a previous solver
1171 is removed by the resolver because of a conflict or alike but it is
1172 dangerous as it could trigger new breaks/conflicts… */
443266ef
DK
1173 if (Debug == true)
1174 clog << " Try Installing " << Start.TargetPkg() << " before changing " << I.FullName(false) << std::endl;
09a10f9c
DK
1175 unsigned long const OldBroken = Cache.BrokenCount();
1176 Cache.MarkInstall(Start.TargetPkg(), true, 1, false);
1177 // FIXME: we should undo the complete MarkInstall process here
1178 if (Cache[Start.TargetPkg()].InstBroken() == true || Cache.BrokenCount() > OldBroken)
1179 Cache.MarkDelete(Start.TargetPkg(), false, 1, false);
1180 }
0a8e3465 1181 }
6c139d6e 1182 }
b5dc9785 1183
6c139d6e
AL
1184 Change = true;
1185 Done = true;
1186 break;
1187 }
1188 else
1189 {
308c7d30
IJ
1190 if (Start->Type == pkgCache::Dep::DpkgBreaks)
1191 {
76264cb7
MV
1192 // first, try upgradring the package, if that
1193 // does not help, the breaks goes onto the
1194 // kill list
2ba99db8 1195 //
76264cb7 1196 // FIXME: use DoUpgrade(Pkg) instead?
2ba99db8 1197 if (Cache[End] & pkgDepCache::DepGCVer)
76264cb7 1198 {
308c7d30 1199 if (Debug)
47f6d1b7 1200 clog << " Upgrading " << Pkg.FullName(false) << " due to Breaks field in " << I.FullName(false) << endl;
308c7d30
IJ
1201 Cache.MarkInstall(Pkg, false, 0, false);
1202 continue;
1203 }
308c7d30
IJ
1204 }
1205
648e3cb4 1206 // Skip adding to the kill list if it is protected
6c139d6e
AL
1207 if ((Flags[Pkg->ID] & Protected) != 0)
1208 continue;
a6bfe583
AL
1209
1210 if (Debug == true)
47f6d1b7 1211 clog << " Added " << Pkg.FullName(false) << " to the remove list" << endl;
6c139d6e
AL
1212
1213 LEnd->Pkg = Pkg;
1214 LEnd->Dep = End;
1215 LEnd++;
0a8e3465 1216
b47053bd 1217 if (Start.IsNegative() == false)
6c139d6e
AL
1218 break;
1219 }
1220 }
1221
1222 // Hm, nothing can possibly satisify this dep. Nuke it.
359e46db
DK
1223 if (VList[0] == 0 &&
1224 Start.IsNegative() == false &&
648e3cb4 1225 (Flags[I->ID] & Protected) != Protected)
6c139d6e 1226 {
648e3cb4 1227 bool Installed = Cache[I].Install();
6c139d6e
AL
1228 Cache.MarkKeep(I);
1229 if (Cache[I].InstBroken() == false)
1230 {
648e3cb4
AL
1231 // Unwind operation will be keep now
1232 if (OrOp == OrRemove)
1233 OrOp = OrKeep;
1234
1235 // Restore
1236 if (InOr == true && Installed == true)
74a05226 1237 Cache.MarkInstall(I, false, 0, false);
648e3cb4 1238
6c139d6e 1239 if (Debug == true)
47f6d1b7 1240 clog << " Holding Back " << I.FullName(false) << " because I can't find " << Start.TargetPkg().FullName(false) << endl;
6c139d6e
AL
1241 }
1242 else
1243 {
1244 if (Debug == true)
47f6d1b7 1245 clog << " Removing " << I.FullName(false) << " because I can't find " << Start.TargetPkg().FullName(false) << endl;
648e3cb4 1246 if (InOr == false)
b83cad32 1247 Cache.MarkDelete(I, false, 0, false);
6c139d6e
AL
1248 }
1249
1250 Change = true;
1251 Done = true;
1252 }
1253
421c8d10
AL
1254 // Try some more
1255 if (InOr == true)
1256 continue;
1257
6c139d6e
AL
1258 if (Done == true)
1259 break;
1260 }
1261
1262 // Apply the kill list now
1263 if (Cache[I].InstallVer != 0)
648e3cb4 1264 {
6c139d6e 1265 for (PackageKill *J = KillList; J != LEnd; J++)
6c139d6e 1266 {
648e3cb4
AL
1267 Change = true;
1268 if ((Cache[J->Dep] & pkgDepCache::DepGNow) == 0)
1269 {
359e46db 1270 if (J->Dep.IsNegative() == true)
648e3cb4
AL
1271 {
1272 if (Debug == true)
47f6d1b7 1273 clog << " Fixing " << I.FullName(false) << " via remove of " << J->Pkg.FullName(false) << endl;
b83cad32 1274 Cache.MarkDelete(J->Pkg, false, 0, false);
648e3cb4
AL
1275 }
1276 }
1277 else
6c139d6e
AL
1278 {
1279 if (Debug == true)
47f6d1b7 1280 clog << " Fixing " << I.FullName(false) << " via keep of " << J->Pkg.FullName(false) << endl;
74a05226 1281 Cache.MarkKeep(J->Pkg, false, false);
6c139d6e 1282 }
b2e465d6 1283
648e3cb4 1284 if (Counter > 1)
b2e465d6
AL
1285 {
1286 if (Scores[I->ID] > Scores[J->Pkg->ID])
1287 Scores[J->Pkg->ID] = Scores[I->ID];
1288 }
648e3cb4
AL
1289 }
1290 }
1291 }
6c139d6e
AL
1292 }
1293
1294 if (Debug == true)
0a8e3465 1295 clog << "Done" << endl;
b2e465d6 1296
6c139d6e 1297 if (Cache.BrokenCount() != 0)
b5dc9785
AL
1298 {
1299 // See if this is the result of a hold
1300 pkgCache::PkgIterator I = Cache.PkgBegin();
f7f0d6c7 1301 for (;I.end() != true; ++I)
b5dc9785
AL
1302 {
1303 if (Cache[I].InstBroken() == false)
1304 continue;
1305 if ((Flags[I->ID] & Protected) != Protected)
b2e465d6 1306 return _error->Error(_("Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages."));
b5dc9785 1307 }
b2e465d6 1308 return _error->Error(_("Unable to correct problems, you have held broken packages."));
b5dc9785
AL
1309 }
1310
fce72602 1311 // set the auto-flags (mvo: I'm not sure if we _really_ need this)
80fa0d8a 1312 pkgCache::PkgIterator I = Cache.PkgBegin();
f7f0d6c7 1313 for (;I.end() != true; ++I) {
80fa0d8a 1314 if (Cache[I].NewInstall() && !(Flags[I->ID] & PreInstalled)) {
120365ce 1315 if(_config->FindI("Debug::pkgAutoRemove",false)) {
47f6d1b7 1316 std::clog << "Resolve installed new pkg: " << I.FullName(false)
120365ce
MV
1317 << " (now marking it as auto)" << std::endl;
1318 }
80fa0d8a
MV
1319 Cache[I].Flags |= pkgCache::Flag::Auto;
1320 }
1321 }
1322
1323
0a8e3465
AL
1324 return true;
1325}
1326 /*}}}*/
953b348c
MV
1327// ProblemResolver::BreaksInstOrPolicy - Check if the given pkg is broken/*{{{*/
1328// ---------------------------------------------------------------------
1329/* This checks if the given package is broken either by a hard dependency
1330 (InstBroken()) or by introducing a new policy breakage e.g. new
1331 unsatisfied recommends for a package that was in "policy-good" state
1332
1333 Note that this is not perfect as it will ignore further breakage
1334 for already broken policy (recommends)
1335*/
1336bool pkgProblemResolver::InstOrNewPolicyBroken(pkgCache::PkgIterator I)
1337{
953b348c
MV
1338 // a broken install is always a problem
1339 if (Cache[I].InstBroken() == true)
deec6474
DK
1340 {
1341 if (Debug == true)
1342 std::clog << " Dependencies are not satisfied for " << I << std::endl;
953b348c 1343 return true;
deec6474 1344 }
953b348c
MV
1345
1346 // a newly broken policy (recommends/suggests) is a problem
1347 if (Cache[I].NowPolicyBroken() == false &&
1348 Cache[I].InstPolicyBroken() == true)
deec6474
DK
1349 {
1350 if (Debug == true)
1351 std::clog << " Policy breaks with upgrade of " << I << std::endl;
953b348c 1352 return true;
deec6474
DK
1353 }
1354
953b348c
MV
1355 return false;
1356}
36a171e1 1357 /*}}}*/
0a8e3465
AL
1358// ProblemResolver::ResolveByKeep - Resolve problems using keep /*{{{*/
1359// ---------------------------------------------------------------------
1360/* This is the work horse of the soft upgrade routine. It is very gental
1361 in that it does not install or remove any packages. It is assumed that the
1362 system was non-broken previously. */
1363bool pkgProblemResolver::ResolveByKeep()
741b7da9 1364{
98278a81 1365 std::string const solver = _config->Find("APT::Solver", "internal");
b57c0e35
DK
1366 if (solver != "internal") {
1367 OpTextProgress Prog(*_config);
1368 return EDSP::ResolveExternal(solver.c_str(), Cache, true, false, false, &Prog);
1369 }
741b7da9
DK
1370 return ResolveByKeepInternal();
1371}
1372 /*}}}*/
1373// ProblemResolver::ResolveByKeepInternal - Resolve problems using keep /*{{{*/
1374// ---------------------------------------------------------------------
1375/* This is the work horse of the soft upgrade routine. It is very gental
1376 in that it does not install or remove any packages. It is assumed that the
1377 system was non-broken previously. */
1378bool pkgProblemResolver::ResolveByKeepInternal()
0a8e3465 1379{
74a05226
MV
1380 pkgDepCache::ActionGroup group(Cache);
1381
b2e465d6 1382 unsigned long Size = Cache.Head().PackageCount;
0a8e3465 1383
0a8e3465
AL
1384 MakeScores();
1385
1386 /* We have to order the packages so that the broken fixing pass
1387 operates from highest score to lowest. This prevents problems when
1388 high score packages cause the removal of lower score packages that
1389 would cause the removal of even lower score packages. */
1390 pkgCache::Package **PList = new pkgCache::Package *[Size];
1391 pkgCache::Package **PEnd = PList;
f7f0d6c7 1392 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
0a8e3465
AL
1393 *PEnd++ = I;
1394 This = this;
1395 qsort(PList,PEnd - PList,sizeof(*PList),&ScoreSort);
8b4894fe
MV
1396
1397 if (_config->FindB("Debug::pkgProblemResolver::ShowScores",false) == true)
1398 {
1399 clog << "Show Scores" << endl;
1400 for (pkgCache::Package **K = PList; K != PEnd; K++)
1401 if (Scores[(*K)->ID] != 0)
1402 {
1403 pkgCache::PkgIterator Pkg(Cache,*K);
1404 clog << Scores[(*K)->ID] << ' ' << Pkg << std::endl;
1405 }
1406 }
1407
1408 if (Debug == true)
1409 clog << "Entering ResolveByKeep" << endl;
1410
0a8e3465
AL
1411 // Consider each broken package
1412 pkgCache::Package **LastStop = 0;
1413 for (pkgCache::Package **K = PList; K != PEnd; K++)
1414 {
1415 pkgCache::PkgIterator I(Cache,*K);
1416
953b348c 1417 if (Cache[I].InstallVer == 0)
0a8e3465
AL
1418 continue;
1419
953b348c
MV
1420 if (InstOrNewPolicyBroken(I) == false)
1421 continue;
1422
0a8e3465 1423 /* Keep the package. If this works then great, otherwise we have
b2e465d6 1424 to be significantly more agressive and manipulate its dependencies */
0a8e3465
AL
1425 if ((Flags[I->ID] & Protected) == 0)
1426 {
1427 if (Debug == true)
47f6d1b7 1428 clog << "Keeping package " << I.FullName(false) << endl;
74a05226 1429 Cache.MarkKeep(I, false, false);
953b348c 1430 if (InstOrNewPolicyBroken(I) == false)
0a8e3465 1431 {
b2e465d6 1432 K = PList - 1;
0a8e3465
AL
1433 continue;
1434 }
1435 }
1436
1437 // Isolate the problem dependencies
1438 for (pkgCache::DepIterator D = Cache[I].InstVerIter(Cache).DependsList(); D.end() == false;)
1439 {
c5532863
AL
1440 DepIterator Start;
1441 DepIterator End;
1442 D.GlobOr(Start,End);
1443
0a8e3465
AL
1444 // We only worry about critical deps.
1445 if (End.IsCritical() != true)
1446 continue;
1447
1448 // Dep is ok
1449 if ((Cache[End] & pkgDepCache::DepGInstall) == pkgDepCache::DepGInstall)
1450 continue;
c5532863
AL
1451
1452 /* Hm, the group is broken.. I suppose the best thing to do is to
1453 is to try every combination of keep/not-keep for the set, but thats
1454 slow, and this never happens, just be conservative and assume the
1455 list of ors is in preference and keep till it starts to work. */
1456 while (true)
0a8e3465 1457 {
c5532863 1458 if (Debug == true)
47f6d1b7 1459 clog << "Package " << I.FullName(false) << " " << Start << endl;
8b4894fe 1460
c5532863
AL
1461 // Look at all the possible provides on this package
1462 SPtrArray<pkgCache::Version *> VList = Start.AllTargets();
1463 for (pkgCache::Version **V = VList; *V != 0; V++)
0a8e3465 1464 {
c5532863
AL
1465 pkgCache::VerIterator Ver(Cache,*V);
1466 pkgCache::PkgIterator Pkg = Ver.ParentPkg();
1467
1468 // It is not keepable
1469 if (Cache[Pkg].InstallVer == 0 ||
1470 Pkg->CurrentVer == 0)
1471 continue;
1472
1473 if ((Flags[I->ID] & Protected) == 0)
1474 {
1475 if (Debug == true)
47f6d1b7 1476 clog << " Keeping Package " << Pkg.FullName(false) << " due to " << Start.DepType() << endl;
74a05226 1477 Cache.MarkKeep(Pkg, false, false);
c5532863
AL
1478 }
1479
953b348c 1480 if (InstOrNewPolicyBroken(I) == false)
c5532863 1481 break;
0a8e3465
AL
1482 }
1483
953b348c 1484 if (InstOrNewPolicyBroken(I) == false)
0a8e3465 1485 break;
0a8e3465 1486
c5532863
AL
1487 if (Start == End)
1488 break;
f7f0d6c7 1489 ++Start;
c5532863
AL
1490 }
1491
953b348c 1492 if (InstOrNewPolicyBroken(I) == false)
0a8e3465
AL
1493 break;
1494 }
1495
953b348c 1496 if (InstOrNewPolicyBroken(I) == true)
0a8e3465
AL
1497 continue;
1498
1499 // Restart again.
0291f645
JT
1500 if (K == LastStop) {
1501 // I is an iterator based off our temporary package list,
1502 // so copy the name we need before deleting the temporary list
1503 std::string const LoopingPackage = I.FullName(false);
1504 delete[] PList;
1505 return _error->Error("Internal Error, pkgProblemResolver::ResolveByKeep is looping on package %s.", LoopingPackage.c_str());
1506 }
0a8e3465 1507 LastStop = K;
b2e465d6 1508 K = PList - 1;
0291f645 1509 }
6c139d6e 1510
0291f645 1511 delete[] PList;
6c139d6e
AL
1512 return true;
1513}
1514 /*}}}*/
f3c736f9 1515// ProblemResolver::InstallProtect - deprecated cpu-eating no-op /*{{{*/
3b5421b4 1516// ---------------------------------------------------------------------
f3c736f9
DK
1517/* Actions issued with FromUser bit set are protected from further
1518 modification (expect by other calls with FromUser set) nowadays , so we
1519 don't need to reissue actions here, they are already set in stone. */
3b5421b4
AL
1520void pkgProblemResolver::InstallProtect()
1521{
74a05226
MV
1522 pkgDepCache::ActionGroup group(Cache);
1523
f7f0d6c7 1524 for (pkgCache::PkgIterator I = Cache.PkgBegin(); I.end() == false; ++I)
3b5421b4
AL
1525 {
1526 if ((Flags[I->ID] & Protected) == Protected)
1527 {
1528 if ((Flags[I->ID] & ToRemove) == ToRemove)
1529 Cache.MarkDelete(I);
c15f5690
MV
1530 else
1531 {
da543ed8
OS
1532 // preserve the information whether the package was auto
1533 // or manually installed
c15f5690
MV
1534 bool autoInst = (Cache[I].Flags & pkgCache::Flag::Auto);
1535 Cache.MarkInstall(I, false, 0, !autoInst);
1536 }
3b5421b4
AL
1537 }
1538 }
1539}
1540 /*}}}*/
b2e465d6
AL
1541// PrioSortList - Sort a list of versions by priority /*{{{*/
1542// ---------------------------------------------------------------------
1543/* This is ment to be used in conjunction with AllTargets to get a list
1544 of versions ordered by preference. */
1545static pkgCache *PrioCache;
1546static int PrioComp(const void *A,const void *B)
1547{
1548 pkgCache::VerIterator L(*PrioCache,*(pkgCache::Version **)A);
1549 pkgCache::VerIterator R(*PrioCache,*(pkgCache::Version **)B);
1550
1551 if ((L.ParentPkg()->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential &&
b8c0f9b7
AL
1552 (R.ParentPkg()->Flags & pkgCache::Flag::Essential) != pkgCache::Flag::Essential)
1553 return 1;
b2e465d6 1554 if ((L.ParentPkg()->Flags & pkgCache::Flag::Essential) != pkgCache::Flag::Essential &&
b8c0f9b7
AL
1555 (R.ParentPkg()->Flags & pkgCache::Flag::Essential) == pkgCache::Flag::Essential)
1556 return -1;
c5200869
JAK
1557
1558 if ((L.ParentPkg()->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important &&
1559 (R.ParentPkg()->Flags & pkgCache::Flag::Important) != pkgCache::Flag::Important)
1560 return 1;
1561 if ((L.ParentPkg()->Flags & pkgCache::Flag::Important) != pkgCache::Flag::Important &&
1562 (R.ParentPkg()->Flags & pkgCache::Flag::Important) == pkgCache::Flag::Important)
1563 return -1;
b2e465d6
AL
1564
1565 if (L->Priority != R->Priority)
b8c0f9b7 1566 return R->Priority - L->Priority;
b2e465d6
AL
1567 return strcmp(L.ParentPkg().Name(),R.ParentPkg().Name());
1568}
1569void pkgPrioSortList(pkgCache &Cache,pkgCache::Version **List)
1570{
1571 unsigned long Count = 0;
1572 PrioCache = &Cache;
1573 for (pkgCache::Version **I = List; *I != 0; I++)
1574 Count++;
1575 qsort(List,Count,sizeof(*List),PrioComp);
1576}
1577 /*}}}*/
db09a1c5 1578// ListUpdate - construct Fetcher and update the cache files /*{{{*/
760d4968
MV
1579// ---------------------------------------------------------------------
1580/* This is a simple wrapper to update the cache. it will fetch stuff
1581 * from the network (or any other sources defined in sources.list)
1582 */
1583bool ListUpdate(pkgAcquireStatus &Stat,
1584 pkgSourceList &List,
1585 int PulseInterval)
1586{
1cd1c398
DK
1587 pkgAcquire Fetcher;
1588 if (Fetcher.Setup(&Stat, _config->FindDir("Dir::State::Lists")) == false)
1589 return false;
760d4968
MV
1590
1591 // Populate it with the source selection
1592 if (List.GetIndexes(&Fetcher) == false)
1593 return false;
1594
db09a1c5
DK
1595 return AcquireUpdate(Fetcher, PulseInterval, true);
1596}
1597 /*}}}*/
1598// AcquireUpdate - take Fetcher and update the cache files /*{{{*/
1599// ---------------------------------------------------------------------
1600/* This is a simple wrapper to update the cache with a provided acquire
1601 * If you only need control over Status and the used SourcesList use
1602 * ListUpdate method instead.
1603 */
1604bool AcquireUpdate(pkgAcquire &Fetcher, int const PulseInterval,
1605 bool const RunUpdateScripts, bool const ListCleanup)
1606{
760d4968 1607 // Run scripts
db09a1c5
DK
1608 if (RunUpdateScripts == true)
1609 RunScripts("APT::Update::Pre-Invoke");
1610
1611 pkgAcquire::RunResult res;
1612 if(PulseInterval > 0)
760d4968
MV
1613 res = Fetcher.Run(PulseInterval);
1614 else
1615 res = Fetcher.Run();
1616
1617 if (res == pkgAcquire::Failed)
1618 return false;
1619
1620 bool Failed = false;
1621 bool TransientNetworkFailure = false;
1622 for (pkgAcquire::ItemIterator I = Fetcher.ItemsBegin();
f7f0d6c7 1623 I != Fetcher.ItemsEnd(); ++I)
760d4968
MV
1624 {
1625 if ((*I)->Status == pkgAcquire::Item::StatDone)
1626 continue;
1627
1628 (*I)->Finished();
1629
70b3d263
MV
1630 ::URI uri((*I)->DescURI());
1631 uri.User.clear();
1632 uri.Password.clear();
1633 string descUri = string(uri);
4805f1cf 1634 _error->Warning(_("Failed to fetch %s %s\n"), descUri.c_str(),
760d4968
MV
1635 (*I)->ErrorText.c_str());
1636
1637 if ((*I)->Status == pkgAcquire::Item::StatTransientNetworkError)
1638 {
1639 TransientNetworkFailure = true;
1640 continue;
1641 }
1642
1643 Failed = true;
1644 }
1645
1646 // Clean out any old list files
1647 // Keep "APT::Get::List-Cleanup" name for compatibility, but
1648 // this is really a global option for the APT library now
db09a1c5 1649 if (!TransientNetworkFailure && !Failed && ListCleanup == true &&
b7c5ca8c 1650 (_config->FindB("APT::Get::List-Cleanup",true) == true &&
760d4968
MV
1651 _config->FindB("APT::List-Cleanup",true) == true))
1652 {
1653 if (Fetcher.Clean(_config->FindDir("Dir::State::lists")) == false ||
1654 Fetcher.Clean(_config->FindDir("Dir::State::lists") + "partial/") == false)
1655 // something went wrong with the clean
1656 return false;
1657 }
1658
1659 if (TransientNetworkFailure == true)
196c511c 1660 _error->Warning(_("Some index files failed to download. They have been ignored, or old ones used instead."));
760d4968 1661 else if (Failed == true)
196c511c 1662 return _error->Error(_("Some index files failed to download. They have been ignored, or old ones used instead."));
760d4968
MV
1663
1664
e06c72cd 1665 // Run the success scripts if all was fine
db09a1c5
DK
1666 if (RunUpdateScripts == true)
1667 {
1668 if(!TransientNetworkFailure && !Failed)
1669 RunScripts("APT::Update::Post-Invoke-Success");
e06c72cd 1670
db09a1c5
DK
1671 // Run the other scripts
1672 RunScripts("APT::Update::Post-Invoke");
1673 }
760d4968
MV
1674 return true;
1675}
1676 /*}}}*/