plsql: disable until uid 1001 issue resolved.
[jackhill/mal.git] / Makefile
CommitLineData
5b207de7
JM
1# Usage/help
2all help:
3 @echo
4 @echo 'USAGE:'
5 @echo
6 @echo 'Rules/Targets:'
7 @echo
8 @echo 'make "IMPL" # build all steps of IMPL'
9 @echo 'make "IMPL^STEP" # build STEP of IMPL'
10 @echo
11 @echo 'make "test" # test all implementations'
12 @echo 'make "test^IMPL" # test all steps of IMPL'
13 @echo 'make "test^STEP" # test STEP for all implementations'
14 @echo 'make "test^IMPL^STEP" # test STEP of IMPL'
15 @echo
16 @echo 'make "perf" # run microbenchmarks for all implementations'
17 @echo 'make "perf^IMPL" # run microbenchmarks for IMPL'
18 @echo
19 @echo 'make "repl^IMPL" # run stepA of IMPL'
20 @echo 'make "repl^IMPL^STEP" # test STEP of IMPL'
21 @echo
22 @echo 'make "clean" # run 'make clean' for all implementations'
23 @echo 'make "clean^IMPL" # run 'make clean' for IMPL'
24 @echo
25 @echo 'make "stats" # run 'make stats' for all implementations'
26 @echo 'make "stats-lisp" # run 'make stats-lisp' for all implementations'
27 @echo 'make "stats^IMPL" # run 'make stats' for IMPL'
28 @echo 'make "stats-lisp^IMPL" # run 'make stats-lisp' for IMPL'
29 @echo
30 @echo 'Options/Settings:'
31 @echo
32 @echo 'make MAL_IMPL=IMPL "test^mal..." # use IMPL for self-host tests'
33 @echo 'make REGRESS=1 "test..." # test with previous step tests too'
34 @echo 'make DOCKERIZE=1 ... # to dockerize above rules/targets'
35 @echo
36 @echo 'Other:'
37 @echo
38 @echo 'make "docker-build^IMPL" # build docker image for IMPL'
39 @echo
40
31690700
JM
41#
42# Command line settings
43#
44
45MAL_IMPL = js
46
a05f7822 47PYTHON = python
47699629 48USE_MATLAB =
32d0a1cf
JM
49# python, js, cpp, or neko are currently supported
50HAXE_MODE = neko
a05f7822 51
337c8031
JM
52# Extra options to pass to runtest.py
53TEST_OPTS =
54
17180e85
JM
55# Test with previous test files not just the test files for the
56# current step. Step 0 and 1 tests are special and not included in
57# later steps.
5b207de7 58REGRESS =
17180e85 59
a1eb30fc 60DEFERRABLE=1
46e25689
JM
61OPTIONAL=1
62
337c8031
JM
63# Extra implementation specific options to pass to runtest.py
64mal_TEST_OPTS = --start-timeout 60 --test-timeout 120
f2b067cb 65miniMAL_TEST_OPTS = --start-timeout 60 --test-timeout 120
08e44c41 66plpgsql_TEST_OPTS = --start-timeout 60 --test-timeout 180
8119e744 67plsql_TEST_OPTS = --start-timeout 60 --test-timeout 120
f2b067cb
JM
68
69DOCKERIZE=
337c8031 70
5b207de7
JM
71# Run target/rule within docker image for the implementation
72DOCKERIZE =
a05f7822 73
31690700
JM
74#
75# Settings
76#
77
adc03a1a 78IMPLS = ada awk bash c d clojure coffee cpp crystal cs erlang elisp \
0067158f
JM
79 elixir es6 factor forth fsharp go groovy guile haskell haxe \
80 io java julia js kotlin lua make mal ocaml matlab miniMAL \
97df14cd 81 nim objc objpascal perl php plpgsql plsql ps python r racket \
36e91db4 82 rpython ruby rust scala swift swift3 tcl vb vhdl vimscript
31690700
JM
83
84step0 = step0_repl
85step1 = step1_read_print
86step2 = step2_eval
87step3 = step3_env
88step4 = step4_if_fn_do
89step5 = step5_tco
90step6 = step6_file
91step7 = step7_quote
92step8 = step8_macros
01c97316 93step9 = step9_try
90f618cb 94stepA = stepA_mal
31690700 95
17180e85
JM
96regress_step0 = step0
97regress_step1 = step1
98regress_step2 = step2
99regress_step3 = $(regress_step2) step3
100regress_step4 = $(regress_step3) step4
101regress_step5 = $(regress_step4) step5
102regress_step6 = $(regress_step5) step6
103regress_step7 = $(regress_step6) step7
104regress_step8 = $(regress_step7) step8
105regress_step9 = $(regress_step8) step9
106regress_stepA = $(regress_step9) stepA
107
dca6b585
JM
108test_EXCLUDES += test^bash^step5 # never completes at 10,000
109test_EXCLUDES += test^make^step5 # no TCO capability (iteration or recursion)
110test_EXCLUDES += test^mal^step5 # host impl dependent
111test_EXCLUDES += test^matlab^step5 # never completes at 10,000
8119e744
JM
112test_EXCLUDES += test^plpgsql^step5 # too slow for 10,000
113test_EXCLUDES += test^plsql^step5 # too slow for 10,000
dca6b585
JM
114
115perf_EXCLUDES = mal # TODO: fix this
31690700 116
bcfd8b70 117dist_EXCLUDES += mal
5245b079 118# TODO: still need to implement dist
bcfd8b70 119dist_EXCLUDES += guile io julia matlab swift
31690700
JM
120
121#
122# Utility functions
123#
124
32d0a1cf
JM
125haxe_STEP_TO_PROG_neko = haxe/$($(1)).n
126haxe_STEP_TO_PROG_python = haxe/$($(1)).py
127haxe_STEP_TO_PROG_cpp = haxe/cpp/$($(1))
128haxe_STEP_TO_PROG_js = haxe/$($(1)).js
129
20e8dea0 130opt_DEFERRABLE = $(if $(strip $(DEFERRABLE)),$(if $(filter t true T True TRUE 1 y yes Yes YES,$(DEFERRABLE)),--deferrable,--no-deferrable),--no-deferrable)
46e25689
JM
131opt_OPTIONAL = $(if $(strip $(OPTIONAL)),$(if $(filter t true T True TRUE 1 y yes Yes YES,$(OPTIONAL)),--optional,--no-optional),--no-optional)
132
17180e85
JM
133# Return list of test files for a given step. If REGRESS is set then
134# test files will include step 2 tests through tests for the step
135# being tested.
136STEP_TEST_FILES = $(strip $(wildcard \
137 $(foreach s,$(if $(strip $(REGRESS)),$(regress_$(2)),$(2)),\
138 $(1)/tests/$($(s)).mal tests/$($(s)).mal)))
31690700 139
17180e85 140# Map of step (e.g. "step8") to executable file for that step
99be41df 141ada_STEP_TO_PROG = ada/$($(1))
3b7ef8c7 142awk_STEP_TO_PROG = awk/$($(1)).awk
db4c329a
JM
143bash_STEP_TO_PROG = bash/$($(1)).sh
144c_STEP_TO_PROG = c/$($(1))
f82cb965 145d_STEP_TO_PROG = d/$($(1))
20e8dea0 146clojure_STEP_TO_PROG = clojure/target/$($(1)).jar
891c3f3b 147coffee_STEP_TO_PROG = coffee/$($(1)).coffee
9ddaa0b9 148cpp_STEP_TO_PROG = cpp/$($(1))
86fe6314 149crystal_STEP_TO_PROG = crystal/$($(1))
db4c329a 150cs_STEP_TO_PROG = cs/$($(1)).exe
ae28e856 151elisp_STEP_TO_PROG = elisp/$($(1)).el
51c2c1fe 152elixir_STEP_TO_PROG = elixir/lib/mix/tasks/$($(1)).ex
2cc3804b 153erlang_STEP_TO_PROG = erlang/$($(1))
4eb71990 154es6_STEP_TO_PROG = es6/build/$($(1)).js
199b1ce7 155factor_STEP_TO_PROG = factor/$($(1))/$($(1)).factor
59038a10 156forth_STEP_TO_PROG = forth/$($(1)).fs
1c358979 157fsharp_STEP_TO_PROG = fsharp/$($(1)).exe
69b4abd6 158go_STEP_TO_PROG = go/$($(1))
a9cd6543 159groovy_STEP_TO_PROG = groovy/$($(1)).groovy
36e287b5 160java_STEP_TO_PROG = java/target/classes/mal/$($(1)).class
b76aa73b 161haskell_STEP_TO_PROG = haskell/$($(1))
32d0a1cf 162haxe_STEP_TO_PROG = $(haxe_STEP_TO_PROG_$(HAXE_MODE))
7511317b 163io_STEP_TO_PROG = io/$($(1)).io
a23e0cdb 164julia_STEP_TO_PROG = julia/$($(1)).jl
db4c329a 165js_STEP_TO_PROG = js/$($(1)).js
53c2ea70 166kotlin_STEP_TO_PROG = kotlin/$($(1)).jar
9d42904e 167lua_STEP_TO_PROG = lua/$($(1)).lua
db4c329a
JM
168make_STEP_TO_PROG = make/$($(1)).mk
169mal_STEP_TO_PROG = mal/$($(1)).mal
59d10e1b 170ocaml_STEP_TO_PROG = ocaml/$($(1))
9a54ea18 171matlab_STEP_TO_PROG = matlab/$($(1)).m
c1fe72ae 172miniMAL_STEP_TO_PROG = miniMAL/$($(1)).json
dbac60df 173nim_STEP_TO_PROG = nim/$($(1))
2faae94c 174objc_STEP_TO_PROG = objc/$($(1))
0067158f 175objpascal_STEP_TO_PROG = objpascal/$($(1))
b5dedee0 176perl_STEP_TO_PROG = perl/$($(1)).pl
db4c329a 177php_STEP_TO_PROG = php/$($(1)).php
adc5b4fb 178plpgsql_STEP_TO_PROG = plpgsql/$($(1)).sql
97df14cd 179plsql_STEP_TO_PROG = plsql/$($(1)).sql
db4c329a
JM
180ps_STEP_TO_PROG = ps/$($(1)).ps
181python_STEP_TO_PROG = python/$($(1)).py
4d1456b9 182r_STEP_TO_PROG = r/$($(1)).r
f5223195 183racket_STEP_TO_PROG = racket/$($(1)).rkt
80320efc 184rpython_STEP_TO_PROG = rpython/$($(1))
db4c329a 185ruby_STEP_TO_PROG = ruby/$($(1)).rb
434516e0 186rust_STEP_TO_PROG = rust/target/release/$($(1))
37a33ac7 187scala_STEP_TO_PROG = scala/target/scala-2.11/classes/$($(1)).class
2539e6af 188swift_STEP_TO_PROG = swift/$($(1))
0eace3df 189swift3_STEP_TO_PROG = swift3/$($(1))
54d9903c 190tcl_STEP_TO_PROG = tcl/$($(1)).tcl
ee7cd585 191vb_STEP_TO_PROG = vb/$($(1)).exe
36e91db4 192vhdl_STEP_TO_PROG = vhdl/$($(1))
50a964ce 193vimscript_STEP_TO_PROG = vimscript/$($(1)).vim
5eb1f5cb 194guile_STEP_TO_PROG = guile/$($(1)).scm
db4c329a 195
db4c329a 196
c4033aab
JM
197# Needed some argument munging
198COMMA = ,
199noop =
200SPACE = $(noop) $(noop)
d1596ac2 201export FACTOR_ROOTS := .
db4c329a 202
4959b19d
JM
203# DOCKERIZE utility functions
204lc = $(subst A,a,$(subst B,b,$(subst C,c,$(subst D,d,$(subst E,e,$(subst F,f,$(subst G,g,$(subst H,h,$(subst I,i,$(subst J,j,$(subst K,k,$(subst L,l,$(subst M,m,$(subst N,n,$(subst O,o,$(subst P,p,$(subst Q,q,$(subst R,r,$(subst S,s,$(subst T,t,$(subst U,u,$(subst V,v,$(subst W,w,$(subst X,x,$(subst Y,y,$(subst Z,z,$1))))))))))))))))))))))))))
205impl_to_image = kanaka/mal-test-$(call lc,$(1))
206
207actual_impl = $(if $(filter mal,$(1)),$(MAL_IMPL),$(1))
208
20e8dea0
JM
209# Takes impl
210# Returns nothing if DOCKERIZE is not set, otherwise returns the
211# docker prefix necessary to run make within the docker environment
212# for this impl
4959b19d 213get_build_prefix = $(if $(strip $(DOCKERIZE)),docker run -it --rm -u $(shell id -u) -v $(dir $(abspath $(lastword $(MAKEFILE_LIST)))):/mal -w /mal/$(1) $(if $(filter factor,$(1)),-e FACTOR_ROOTS=$(FACTOR_ROOTS),) $(call impl_to_image,$(1)) ,)
db4c329a 214
20e8dea0
JM
215# Takes impl and step arguments
216# Returns a command prefix (docker command and environment variables)
217# necessary to launch the given impl and step
218get_run_prefix = $(strip $(if $(strip $(DOCKERIZE)),\
219 docker run -e STEP=$($2) \
220 -it --rm -u $(shell id -u) \
221 -v $(dir $(abspath $(lastword $(MAKEFILE_LIST)))):/mal \
222 -w /mal/$(call actual_impl,$(1)) \
223 $(if $(filter haxe,$(1)),-e HAXE_MODE=$(HAXE_MODE),) \
224 $(if $(filter factor,$(1)),-e FACTOR_ROOTS=$(FACTOR_ROOTS),) \
225 $(foreach env,$(3),-e $(env)) \
226 $(call impl_to_image,$(call actual_impl,$(1))) \
227 ,\
228 env STEP=$($2) \
229 $(if $(filter haxe,$(1)),HAXE_MODE=$(HAXE_MODE),) \
230 $(if $(filter factor,$(1)),FACTOR_ROOTS=$(FACTOR_ROOTS),) \
231 $(3)))
232
233# Takes impl and step
234# Returns the runtest command prefix (with runtest options) for testing the given step
235get_runtest_cmd = $(call get_run_prefix,$(1),$(2),$(if $(filter cs fsharp tcl vb,$(1)),RAW=1,)) \
236 ../runtest.py $(TEST_OPTS) $(opt_DEFERRABLE) $(opt_OPTIONAL) $(call $(1)_TEST_OPTS)
237
238# Takes impl and step
239# Returns the runtest command prefix (with runtest options) for testing the given step
240get_argvtest_cmd = $(call get_run_prefix,$(1),$(2)) ../run_argv_test.sh
31690700 241
50a964ce
DM
242vimscript_TEST_OPTS = --test-timeout 30
243ifeq ($(MAL_IMPL),vimscript)
244mal_TEST_OPTS = --start-timeout 60 --test-timeout 180
245endif
31690700
JM
246
247# Derived lists
248STEPS = $(sort $(filter step%,$(.VARIABLES)))
8569b2af
JM
249DO_IMPLS = $(filter-out $(SKIP_IMPLS),$(IMPLS))
250IMPL_TESTS = $(foreach impl,$(DO_IMPLS),test^$(impl))
31690700 251STEP_TESTS = $(foreach step,$(STEPS),test^$(step))
dca6b585 252ALL_TESTS = $(filter-out $(test_EXCLUDES),\
31690700 253 $(strip $(sort \
8569b2af 254 $(foreach impl,$(DO_IMPLS),\
31690700
JM
255 $(foreach step,$(STEPS),test^$(impl)^$(step))))))
256
cf1d3eae
JM
257DOCKER_BUILD = $(foreach impl,$(DO_IMPLS),docker-build^$(impl))
258
dca6b585 259IMPL_PERF = $(foreach impl,$(filter-out $(perf_EXCLUDES),$(DO_IMPLS)),perf^$(impl))
db4c329a 260
854cf2a6
DM
261IMPL_REPL = $(foreach impl,$(DO_IMPLS),repl^$(impl))
262ALL_REPL = $(strip $(sort \
263 $(foreach impl,$(DO_IMPLS),\
264 $(foreach step,$(STEPS),repl^$(impl)^$(step)))))
db4c329a 265
31690700
JM
266#
267# Build rules
268#
269
4fc7a281 270# Build a program in an implementation directory
f045aba1
JM
271# Make sure we always try and build first because the dependencies are
272# encoded in the implementation Makefile not here
273.PHONY: $(foreach i,$(DO_IMPLS),$(foreach s,$(STEPS),$(call $(i)_STEP_TO_PROG,$(s))))
4fc7a281 274$(foreach i,$(DO_IMPLS),$(foreach s,$(STEPS),$(call $(i)_STEP_TO_PROG,$(s)))):
f045aba1 275 $(foreach impl,$(word 1,$(subst /, ,$(@))),\
4959b19d
JM
276 $(if $(DOCKERIZE), \
277 $(call get_build_prefix,$(impl))$(MAKE) $(patsubst $(impl)/%,%,$(@)), \
278 $(MAKE) -C $(impl) $(subst $(impl)/,,$(@))))
31690700 279
5b207de7 280# Allow IMPL, and IMPL^STEP
31690700 281.SECONDEXPANSION:
5b207de7 282$(DO_IMPLS): $$(foreach s,$$(STEPS),$$(call $$(@)_STEP_TO_PROG,$$(s)))
31690700
JM
283
284.SECONDEXPANSION:
5b207de7
JM
285$(foreach i,$(DO_IMPLS),$(foreach s,$(STEPS),$(i)^$(s))): $$(call $$(word 1,$$(subst ^, ,$$(@)))_STEP_TO_PROG,$$(word 2,$$(subst ^, ,$$(@))))
286
287
288#
289# Test rules
290#
31690700
JM
291
292.SECONDEXPANSION:
293$(ALL_TESTS): $$(call $$(word 2,$$(subst ^, ,$$(@)))_STEP_TO_PROG,$$(word 3,$$(subst ^, ,$$(@))))
294 @$(foreach impl,$(word 2,$(subst ^, ,$(@))),\
295 $(foreach step,$(word 3,$(subst ^, ,$(@))),\
d5221bcf 296 cd $(if $(filter mal,$(impl)),$(MAL_IMPL),$(impl)) && \
31690700 297 $(foreach test,$(call STEP_TEST_FILES,$(impl),$(step)),\
d5221bcf 298 echo '----------------------------------------------' && \
20e8dea0
JM
299 echo 'Testing $@; step file: $+, test file: $(test)' && \
300 echo 'Running: $(call get_runtest_cmd,$(impl),$(step)) $(call $(impl)_TEST_OPTS) ../$(test) -- ../$(impl)/run' && \
301 $(call get_runtest_cmd,$(impl),$(step)) $(call $(impl)_TEST_OPTS) ../$(test) -- ../$(impl)/run && \
d3c401c1
DM
302 $(if $(filter tests/step6_file.mal,$(test)),\
303 echo '----------------------------------------------' && \
304 echo 'Testing ARGV of $@; step file: $+' && \
20e8dea0
JM
305 echo 'Running: $(call get_argvtest_cmd,$(impl),$(step)) ../$(impl)/run ' && \
306 $(call get_argvtest_cmd,$(impl),$(step)) ../$(impl)/run && ,\
d3c401c1 307 true && ))\
d5221bcf 308 true))
31690700 309
5b207de7 310# Allow test, tests, test^STEP, test^IMPL, and test^IMPL^STEP
31690700
JM
311test: $(ALL_TESTS)
312tests: $(ALL_TESTS)
313
5b207de7
JM
314.SECONDEXPANSION:
315$(IMPL_TESTS): $$(filter $$@^%,$$(ALL_TESTS))
31690700 316
5b207de7
JM
317.SECONDEXPANSION:
318$(STEP_TESTS): $$(foreach step,$$(subst test^,,$$@),$$(filter %^$$(step),$$(ALL_TESTS)))
31690700 319
db4c329a 320
5b207de7
JM
321#
322# Dist rules
323#
b6dc3e37
JM
324
325dist: $(IMPL_DIST)
31690700 326
712af9ef 327.SECONDEXPANSION:
b6dc3e37 328$(IMPL_DIST):
712af9ef
JM
329 @echo "----------------------------------------------"; \
330 $(foreach impl,$(word 2,$(subst ^, ,$(@))),\
b6dc3e37
JM
331 echo "Running: make -C $(impl) dist"; \
332 $(MAKE) --no-print-directory -C $(impl) dist)
333
712af9ef 334
5b207de7 335#
cf1d3eae 336# Docker build rules
5b207de7 337#
cf1d3eae
JM
338
339docker-build: $(DOCKER_BUILD)
340
341.SECONDEXPANSION:
342$(DOCKER_BUILD):
343 echo "----------------------------------------------"; \
344 $(foreach impl,$(word 2,$(subst ^, ,$(@))),\
4959b19d
JM
345 echo "Running: docker build -t $(call impl_to_image,$(impl)) .:"; \
346 cd $(impl) && docker build -t $(call impl_to_image,$(impl)) .)
db4c329a 347
5b207de7
JM
348
349#
db4c329a 350# Performance test rules
5b207de7 351#
db4c329a
JM
352
353perf: $(IMPL_PERF)
354
355.SECONDEXPANSION:
356$(IMPL_PERF):
357 @echo "----------------------------------------------"; \
358 $(foreach impl,$(word 2,$(subst ^, ,$(@))),\
359 cd $(if $(filter mal,$(impl)),$(MAL_IMPL),$(impl)); \
360 echo "Performance test for $(impl):"; \
20e8dea0
JM
361 echo 'Running: $(call get_run_prefix,$(impl),stepA) ../$(impl)/run ../tests/perf1.mal'; \
362 $(call get_run_prefix,$(impl),stepA) ../$(impl)/run ../tests/perf1.mal; \
363 echo 'Running: $(call get_run_prefix,$(impl),stepA) ../$(impl)/run ../tests/perf2.mal'; \
364 $(call get_run_prefix,$(impl),stepA) ../$(impl)/run ../tests/perf2.mal; \
365 echo 'Running: $(call get_run_prefix,$(impl),stepA) ../$(impl)/run ../tests/perf3.mal'; \
366 $(call get_run_prefix,$(impl),stepA) ../$(impl)/run ../tests/perf3.mal)
db4c329a 367
854cf2a6 368
5b207de7 369#
854cf2a6 370# REPL invocation rules
5b207de7 371#
854cf2a6
DM
372
373.SECONDEXPANSION:
374$(ALL_REPL): $$(call $$(word 2,$$(subst ^, ,$$(@)))_STEP_TO_PROG,$$(word 3,$$(subst ^, ,$$(@))))
375 @$(foreach impl,$(word 2,$(subst ^, ,$(@))),\
376 $(foreach step,$(word 3,$(subst ^, ,$(@))),\
377 cd $(if $(filter mal,$(impl)),$(MAL_IMPL),$(impl)); \
378 echo 'REPL implementation $(impl), step file: $+'; \
20e8dea0
JM
379 echo 'Running: $(call get_run_prefix,$(impl),$(step)) ../$(impl)/run'; \
380 $(call get_run_prefix,$(impl),$(step)) ../$(impl)/run;))
bcfd8b70 381
5b207de7
JM
382# Allow repl^IMPL^STEP and repl^IMPL (which starts REPL of stepA)
383.SECONDEXPANSION:
384$(IMPL_REPL): $$@^stepA
385
dca6b585
JM
386#
387# Utility functions
388#
389.SECONDEXPANSION:
390print-%:
391 @echo "$($(*))"
bcfd8b70 392
5b207de7 393#
bcfd8b70 394# Recursive rules (call make FOO in each subdirectory)
5b207de7 395#
bcfd8b70
JM
396
397define recur_template
398.PHONY: $(1)
399$(1): $(2)
400.SECONDEXPANSION:
401$(2):
402 @echo "----------------------------------------------"; \
403 $$(foreach impl,$$(word 2,$$(subst ^, ,$$(@))),\
4959b19d
JM
404 $$(if $$(DOCKERIZE), \
405 echo "Running: $$(call get_build_prefix,$$(impl))$$(MAKE) --no-print-directory $(1)"; \
406 $$(call get_build_prefix,$$(impl))$$(MAKE) --no-print-directory $(1), \
407 echo "Running: $$(MAKE) --no-print-directory -C $$(impl) $(1)"; \
408 $$(MAKE) --no-print-directory -C $$(impl) $(1)))
bcfd8b70
JM
409endef
410
411recur_impls_ = $(filter-out $(foreach impl,$($(1)_EXCLUDES),$(1)^$(impl)),$(foreach impl,$(IMPLS),$(1)^$(impl)))
412
413# recursive clean
414$(eval $(call recur_template,clean,$(call recur_impls_,clean)))
415
416# recursive stats
417$(eval $(call recur_template,stats,$(call recur_impls_,stats)))
418$(eval $(call recur_template,stats-lisp,$(call recur_impls_,stats-lisp)))
419
420# recursive dist
421$(eval $(call recur_template,dist,$(call recur_impls_,dist)))