file-systems: Remove 'title' field and add <file-system-label>.
authorLudovic Courtès <ludo@gnu.org>
Fri, 18 May 2018 11:43:07 +0000 (13:43 +0200)
committerLudovic Courtès <ludo@gnu.org>
Mon, 28 May 2018 11:24:11 +0000 (13:24 +0200)
commita5acc17a3c10a3779b5b8b1a2565ef130be77e51
tree988afc136bcdb5848543167375118283a958fb38
parent25816c4306ff7d4cec21a3f0e7ce917aea75385f
file-systems: Remove 'title' field and add <file-system-label>.

The 'title' field was easily overlooked and was an endless source of
confusion.  Now, the value of the 'device' field is self-contained.

* gnu/system/file-systems.scm (<file-system>): Change constructor name
to '%file-system'.
[title]: Remove.
(<file-system-label>): New record type with printer.
(report-deprecation, device-expression)
(process-file-system-declaration, file-system): New macros.
(file-system-title): New procedure.
(file-system->spec, spec->file-system): Adjust to handle
<file-system-label>.
* gnu/system.scm (bootable-kernel-arguments): Add case for
'file-system-label?'.
(read-boot-parameters): Likewise.
(mapped-device-user): Avoid 'file-system-title'.
(fs->boot-device): Remove.
(operating-system-boot-parameters): Use 'file-system-device' instead of
'fs->boot-device'.
(device->sexp): Add case for 'file-system-label?'.
* gnu/bootloader/grub.scm (grub-root-search): Add case for
'file-system-label?'.
* gnu/system/examples/bare-bones.tmpl,
gnu/system/examples/beaglebone-black.tmpl,
gnu/system/examples/lightweight-desktop.tmpl,
gnu/system/examples/vm-image.tmpl: Remove uses of 'title'.
* gnu/system/vm.scm (virtualized-operating-system): Remove uses of
'file-system-title'.
* guix/scripts/system.scm (check-file-system-availability): Likewise,
and adjust fix-it hint.
(check-initrd-modules)[file-system-/dev]: Likewise.
* gnu/build/file-systems.scm (canonicalize-device-spec): Remove 'title'
parameter.
[canonical-title]: Remove.
Match on SPEC's type rather than on CANONICAL-TITLE.
(mount-file-system): Adjust caller.
* gnu/build/linux-boot.scm (boot-system): Interpret ROOT here.
* gnu/services/base.scm (file-system->fstab-entry): Remove use of
'file-system-title'.
* doc/guix.texi (File Systems): Remove documentation of the 'title'
field.  Rewrite documentation of 'device' and document
'file-system-label'.
13 files changed:
doc/guix.texi
gnu/bootloader/grub.scm
gnu/build/file-systems.scm
gnu/build/linux-boot.scm
gnu/services/base.scm
gnu/system.scm
gnu/system/examples/bare-bones.tmpl
gnu/system/examples/beaglebone-black.tmpl
gnu/system/examples/lightweight-desktop.tmpl
gnu/system/examples/vm-image.tmpl
gnu/system/file-systems.scm
gnu/system/vm.scm
guix/scripts/system.scm