substitute-binary: Pass `filtered-port' an unbuffered port.
authorLudovic Courtès <ludo@gnu.org>
Wed, 15 May 2013 21:40:09 +0000 (23:40 +0200)
committerLudovic Courtès <ludo@gnu.org>
Wed, 15 May 2013 21:40:09 +0000 (23:40 +0200)
commit101d9f3fd43b436d5dc7ef13e644c7fbbc7f62d5
treee3a4eed4c2e50b932d333fa5344d343125c42cfd
parent3d6b71e87eca505262f9756644d72e545c7e48f8
substitute-binary: Pass `filtered-port' an unbuffered port.

This fixes a bug whereby `read-response' would read more than just the
response, with the extra data going into the port's buffer; the
"bzip2 -dc" process spawned by `filtered-port' would not see the those
buffered data, which are definitely lost, and would bail out with
"bzip2: (stdin) is not a bzip2 file."

* guix/utils.scm (filtered-port): Document that INPUT must be
  unbuffered.
* guix/web.scm (http-fetch): Add `buffered?' parameter.  Call
  `open-socket-for-uri' explicitly, and call `setvbuf' when BUFFERED? is
  false.  Pass the port to `http-get'.  Close it upon 301/302.
* guix/scripts/substitute-binary.scm (fetch): Add `buffered?'
  parameter.  Pass it to `http-fetch'; honor it for `file' URIs.
  (guix-substitute-binary): Call `fetch' with #:buffered? #f for port RAW.
* tests/utils.scm ("filtered-port, file"): Open FILE as unbuffered.
guix/scripts/substitute-binary.scm
guix/utils.scm
guix/web.scm
tests/utils.scm