From: Clinton Ebadi <clinton@unknownlamer.org>
Date: Sat, 5 Jan 2019 23:02:49 +0000 (-0500)
Subject: apache: disallow backslashes in rewrite_arg type
X-Git-Tag: release_20190105-2
X-Git-Url: https://git.hcoop.net/hcoop/domtool2.git/commitdiff_plain/19716bb3f9673de2dd3fb87ed0b227c980eb51ab

apache: disallow backslashes in rewrite_arg type

backlashes can be used to create invalid config (e.g. using one at the
end of the line), and don't seem to be particularly useful
here. Disallow entirely for now.
---

diff --git a/src/plugins/apache.sml b/src/plugins/apache.sml
index 9d180ab..aecc2e1 100644
--- a/src/plugins/apache.sml
+++ b/src/plugins/apache.sml
@@ -97,7 +97,7 @@ val _ = Env.type_one "proxy_reverse_target"
 
 val _ = Env.type_one "rewrite_arg"
 	Env.string
-	(CharVector.all (fn ch => (Char.isGraph ch) andalso not (List.exists (fn c => ch = c) [ #"[", #"]", #",", #"\"", #"'", #"=", #":" ])))
+	(CharVector.all (fn ch => (Char.isGraph ch) andalso not (List.exists (fn c => ch = c) [ #"[", #"]", #",", #"\"", #"'", #"=", #":", "\\" ])))
 
 val _ = Env.type_one "suexec_flag"
 	Env.bool