* Safer handling of $1 in all scripts

[hcoop/domtool2.git] / scripts / domtool-addcert

diff --git a/scripts/domtool-addcert b/scripts/domtool-addcert
index 3f2313f..3fb6b82 100755 (executable)
--- a/scripts/domtool-addcert
+++ b/scripts/domtool-addcert
@@ -1,5 +1,11 @@
 #!/bin/sh -e
 
+USER="$1"
+if test -z "$USER"; then
+       echo Usage: domtool-addcert USERNAME
+       exit 1
+fi   
+
   KEYDIR=/afs/hcoop.net/common/etc/domtool/keys/$1
  KEYFILE=$KEYDIR/key.pem
 CERTFILE=/afs/hcoop.net/common/etc/domtool/certs/$1.pem
@@ -10,14 +16,14 @@ CERTFILE=/afs/hcoop.net/common/etc/domtool/certs/$1.pem
 mkdir -p $KEYDIR
 openssl genrsa -out $KEYFILE
 chown -R domtool.domtool $KEYDIR
-fs sa $KEYDIR $1 read
+fs sa $KEYDIR $USER read
 echo "." >$KEYIN
 echo "." >>$KEYIN
 echo "." >>$KEYIN
 echo "." >>$KEYIN
 echo "." >>$KEYIN
-echo "$1" >>$KEYIN
-echo "$1@hcoop.net" >>$KEYIN
+echo "$USER" >>$KEYIN
+echo "$USER@hcoop.net" >>$KEYIN
 echo "" >>$KEYIN
 echo "" >>$KEYIN
 openssl req -new -key $KEYFILE -out $NEWREQ -days 365 <$KEYIN