From: Todd Lewis <utoddl@email.unc.edu>
Date: Wed, 5 Mar 2014 05:29:34 +0000 (-0500)
Subject: Fix possible buffer overflow: buflen (a size_t*) was being used
X-Git-Tag: debian/2.03~3
X-Git-Url: https://git.hcoop.net/hcoop/debian/libnss-afs.git/commitdiff_plain/5fea146a0336c48c8628edabfde1288ae988d249?hp=3237e08ec8c6c25a654e04d9a949fb35c9e19991

Fix possible buffer overflow: buflen (a size_t*) was being used
directly in a comparison instead of being dereferenced
---

diff --git a/nss_afs.c b/nss_afs.c
index aa9ed1a..126b5c5 100644
--- a/nss_afs.c
+++ b/nss_afs.c
@@ -138,7 +138,7 @@ enum nss_status ptsid2name(int uid, char **buffer, int *buflen) {
   ret = NSS_STATUS_NOTFOUND;
   for (i=0;i<lnames.namelist_len;i++) {
     int delta = strlen(lnames.namelist_val[i]);
-    if ( (delta < buflen) && islower(*(lnames.namelist_val[i])) ) {
+    if ( (delta < *buflen) && islower(*(lnames.namelist_val[i])) ) {
       cpstr(lnames.namelist_val[i], buffer, buflen);
       ret = NSS_STATUS_SUCCESS;
     }