remobe ROFL and add validation

[clinton/lisp-on-lines.git] / src / description.lisp

diff --git a/src/description.lisp b/src/description.lisp
index bb1f88a..073dc94 100644 (file)
--- a/src/description.lisp
+++ b/src/description.lisp
@@ -31,7 +31,7 @@
 (defun find-attribute (description attribute-name &optional (errorp t))
   (or (find attribute-name (description-attributes description)
            :key #'attribute-name)
-      (when errorp (error "No attribute named ~A found in ~A" attribute-name description))))
+      (when errorp (error "No attribute named ~A found in ~A describing ~A" attribute-name description (described-object description)))))
 
 (define-layered-function description-active-descriptions (description)
   (:method ((description standard-description-object))
@@ -51,21 +51,22 @@
            (find-attribute description 'active-attributes))
           (attributes (when active-attributes
                         (ignore-errors (attribute-value active-attributes)))))
-      (if attributes
-         (mapcar (lambda (spec)                    
-                   (find-attribute 
-                    description
-                    (if (listp spec)
-                        (car spec)
-                        spec)))
-                 attributes)
-         (remove-if-not 
-          (lambda (attribute)
-            (and (attribute-active-p attribute)                     
-                 (some #'layer-active-p 
-                       (mapcar #'find-layer 
-                               (slot-definition-layers 
-                                (attribute-effective-attribute-definition attribute))))))
+      (remove-if-not 
+       (lambda (attribute)
+        (and attribute
+             (attribute-active-p attribute)                 
+             (some #'layer-active-p 
+                   (mapcar #'find-layer 
+                           (slot-definition-layers 
+                            (attribute-effective-attribute-definition attribute))))))
+       (if attributes
+          (mapcar (lambda (spec)                   
+                    (find-attribute 
+                     description
+                     (if (listp spec)
+                         (car spec)
+                         spec)))
+                  attributes)
           (description-attributes description))))))