From 634e77be24c4a412bf1830b9c7965e6545d50fd6 Mon Sep 17 00:00:00 2001 From: data Date: Sat, 4 Feb 2006 12:03:00 +0000 Subject: [PATCH] Added id3ed as a ID3 editor. More more more quotes work. git-svn-id: http://abcde.googlecode.com/svn/trunk@197 a0fa61bc-5347-0410-a1a9-7f54aa4e1825 --- abcde | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/abcde b/abcde index ab24d28..e3330d4 100755 --- a/abcde +++ b/abcde @@ -54,7 +54,6 @@ echo "-P Use UNIX pipes to read+encode without wav files" echo "-r " echo " Also encode on these remote hosts" echo "-R Use local CDDB in recursive mode" -#echo "-R Add replaygain values to the tag info (only for vorbis,flac,mp3)" echo "-s " echo " Show dielfs from the CDDB info (year,genre)" echo "-S <#> Set the CD speed" @@ -357,7 +356,7 @@ checkexec () log error "$X is not in your path." >&2 log info "Define the full path to the executable if it exists on your system." >&2 exit 1 - elif [ ! -x $(which $X) ]; then + elif [ ! -x "$(which $X)" ]; then log error "$X is not executable." >&2 exit 1 fi @@ -721,15 +720,25 @@ do_tag () case "$ID3SYNTAX" in id3);; eyed3) - # FIXME # track numbers in mp3 come with 1/10, so we cannot happily substitute them with $TRACKNUM - run_command tagtrack-$OUTPUT-$1 $TAGGER $TAGGEROPTS --commen=::"$COMMENTOUTPUT" \ - -A "$DALBUM" -a "$TRACKARTIST" -t "$TRACKNAME" -Y "$CDYEAR" \ + # FIXME # track numbers in mp3 come with 1/10, so we cannot + # happily substitute them with $TRACKNUM + run_command tagtrack-$OUTPUT-$1 $TAGGER $TAGGEROPTS \ + --comment=::"$COMMENTOUTPUT" -A "$DALBUM" \ + -a "$TRACKARTIST" -t "$TRACKNAME" -Y "$CDYEAR" \ -G "$GENREID" -n "${TRACKNUM:-$1}" "${TRACKNUM:+-N $TRACKS}" \ - "${ENCODING:+--set-encoding=$ENCODING}" + "${ENCODING:+--set-encoding=$ENCODING}" \ + "$ABCDETEMPDIR/track$1.$OUTPUT" + ;; + # FIXME # Still not activated... + id3ed) + run_command tagtrack-$OUTPUT-$1 $TAGGER $TAGGEROPTS -c "$COMMENTOUTPUT" \ + -a "$DALBUM" -n "$TRACKARTIST" -s "$TRACKNAME" -y "$CDYEAR" \ + -g "$GENREID" -k "${TRACKNUM:-$1}" \ "$ABCDETEMPDIR/track$1.$OUTPUT" ;; *) - # FIXME # track numbers in mp3 come with 1/10, so we cannot happily substitute them with $TRACKNUM + # FIXME # track numbers in mp3 come with 1/10, so we cannot + # happily substitute them with $TRACKNUM run_command tagtrack-$OUTPUT-$1 $TAGGER $TAGGEROPTS -c "$COMMENTOUTPUT" \ -A "$DALBUM" -a "$TRACKARTIST" -t "$TRACKNAME" -y "$CDYEAR" \ -g "$GENREID" -T "${TRACKNUM:-$1/$TRACKS}" \ -- 2.20.1