From: EinvalSledge@gmail.com <EinvalSledge@gmail.com@a0fa61bc-5347-0410-a1a9-7f54aa4e1825>
Date: Thu, 19 Apr 2012 14:10:02 +0000 (+0000)
Subject:   * Fix aac tagging. (Closes issue 7).
X-Git-Url: https://git.hcoop.net/clinton/abcde.git/commitdiff_plain/2b5ab14a99dc63d5a5a0274b0aca1f5a0050f11b

  * Fix aac tagging. (Closes issue 7).
    Thanks to Andrew Strong for forwarding the patch.



git-svn-id: http://abcde.googlecode.com/svn/trunk@313 a0fa61bc-5347-0410-a1a9-7f54aa4e1825
---

diff --git a/abcde b/abcde
index 6281693..e1123a5 100755
--- a/abcde
+++ b/abcde
@@ -1151,8 +1151,8 @@ do_encode ()
 				$RUN_COMMAND nice $EFFECTIVE_NICE $MPPENCODER $MPPENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title "$TRACKNAME" --track "$1" --genre "$CDGENRE" --year "$CDYEAR" --comment "$COMMENT" "$IN" "$OUT"
 				;;
 			m4a)
-				# Quick hack to avoid tagging Ogg/Speex, since there is no other way to tag than inline tagging
-				if [ ! "$DOTAG" = "y" ]; then
+				# Tag the file at encode time, as it can't be done after encoding.
+				if [ "$DOTAG" = "y" ]; then
 					$RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title "$TRACKNAME" --track "$1" --genre "$CDGENRE" --year "$CDYEAR" --comment "$COMMENT" -o "$OUT" "$IN"
 					
 				else
diff --git a/changelog b/changelog
index 4faf31d..45846cf 100644
--- a/changelog
+++ b/changelog
@@ -10,6 +10,8 @@ abcde 2.5.1 UNRELEASED
       Closes: #669141
   * Fix speex tagging. (Closes issue 19).
     Thanks to vskytta for the patch.
+  * Fix aac tagging. (Closes issue 7).
+    Thanks to Andrew Strong for forwarding the patch.
 
   [ Colin Tuckley ]
   * replace deprecated egrep with grep -E (Closes issue 24).